1 2012-02-06 Chong Yidong <cyd@gnu.org>
3 * doc.c (store_function_docstring): Avoid applying docstring of
4 alias to base function (Bug#2603).
6 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
8 * .gdbinit (pp1, pv1): Remove redundant defines.
11 2012-02-04 Chong Yidong <cyd@gnu.org>
13 * nsterm.m: Declare a global (Bug#10694).
15 2012-02-04 Eli Zaretskii <eliz@gnu.org>
17 * w32.c (get_emacs_configuration_options): Include
18 --enable-checking, if specified, in the return value.
20 2012-02-04 Martin Rudalics <rudalics@gmx.at>
22 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
23 after rounding frame sizes. (Bug#9723)
25 2012-02-04 Eli Zaretskii <eliz@gnu.org>
27 * keyboard.c (adjust_point_for_property): Don't position point
28 before BEGV. (Bug#10696)
30 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
32 Handle overflow when computing char display width (Bug#9496).
33 * character.c (char_width): Return EMACS_INT, not int.
34 (char_width, c_string_width): Check for overflow when
35 computing the width; this is possible now that individual
36 characters can have unbounded width. Problem introduced
37 by merge from Emacs 23 on 2012-01-19.
39 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
41 * dbusbind.c (Fdbus_register_method): Mention the return value
42 :ignore in the docstring.
44 2012-02-02 Glenn Morris <rgm@gnu.org>
46 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
48 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
49 Unconditionally set to t. (Bug#10673)
50 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
51 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
52 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
54 2012-02-02 Kenichi Handa <handa@m17n.org>
56 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
57 0, do not call append_composite_glyph.
59 2012-02-02 Kenichi Handa <handa@m17n.org>
61 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
63 (x_produce_glyphs): If the component of a composition is a null
64 string, set it->pixel_width to 1 to avoid zero-width glyph.
66 2012-02-01 Eli Zaretskii <eliz@gnu.org>
68 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
69 first 2 arguments are identical. This makes inserting large
70 output from a subprocess an order of magnitude faster on
71 MS-Windows, where all sbrk'ed memory is always contiguous.
73 2012-01-31 Glenn Morris <rgm@gnu.org>
75 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
76 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
77 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
79 2012-01-29 Glenn Morris <rgm@gnu.org>
81 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
83 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
85 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
87 2012-01-28 Chong Yidong <cyd@gnu.org>
89 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
91 2012-01-26 Chong Yidong <cyd@gnu.org>
93 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
95 * search.c (Fsearch_forward, Fsearch_backward): Document negative
96 repeat counts (Bug#10507).
98 2012-01-26 Glenn Morris <rgm@gnu.org>
100 * lread.c (syms_of_lread): Doc fix.
102 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
104 * coding.c (encode_designation_at_bol): Change return value to
107 2012-01-25 Chong Yidong <cyd@gnu.org>
109 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
111 2012-01-21 Chong Yidong <cyd@gnu.org>
113 * floatfns.c (Fcopysign): Make the second argument non-optional,
114 since nil is not allowed anyway.
116 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
118 * process.c (read_process_output): Use p instead of XPROCESS (proc).
119 (send_process): Likewise.
121 2012-01-19 Martin Rudalics <rudalics@gmx.at>
123 * window.c (save_window_save, Fcurrent_window_configuration)
124 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
127 2012-01-19 Kenichi Handa <handa@m17n.org>
129 * character.c (char_width): New function.
130 (Fchar_width, c_string_width, lisp_string_width):
131 Use char_width (Bug#9496).
133 2012-01-16 Martin Rudalics <rudalics@gmx.at>
135 * window.c (Vwindow_persistent_parameters): New variable.
136 (Fset_window_configuration, save_window_save): Handle persistent
139 2012-01-14 Eli Zaretskii <eliz@gnu.org>
141 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
142 thrashing the stack of the thread. (Bug#9087)
144 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
146 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
148 2012-01-11 Eli Zaretskii <eliz@gnu.org>
150 * xdisp.c (rows_from_pos_range): Handle the case where the
151 highlight ends on a newline. (Bug#10464)
152 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
153 he end column for display of highlight that ends on a newline
156 2012-01-11 Glenn Morris <rgm@gnu.org>
158 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
159 from load-path also when installation-directory is nil. (Bug#10208)
161 2012-01-10 Glenn Morris <rgm@gnu.org>
163 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
165 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
166 Update template values to be closer to their typical values these days.
168 2012-01-09 Eli Zaretskii <eliz@gnu.org>
170 * xdisp.c (rows_from_pos_range): Accept additional argument
171 DISP_STRING, and accept any glyph in a row whose object is that
172 string as eligible for mouse highlight. Fixes mouse highlight of
173 display strings from overlays. (Bug#10464)
175 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
177 emacs: fix an auto-save permissions race condition (Bug#10400)
178 * fileio.c (auto_saving_dir_umask): New static var.
179 (Fmake_directory_internal): Use it.
180 (do_auto_save_make_dir): Set it, instead of invoking chmod after
181 creating the directory. The old code temporarily assigns
182 too-generous permissions to the directory.
183 (do_auto_save_eh): Clear it.
184 (Fdo_auto_save): Catch all errors, not just file errors, so
185 that the var is always cleared.
187 2012-01-07 Eli Zaretskii <eliz@gnu.org>
189 * search.c (scan_buffer): Pass character positions to
190 know_region_cache, not byte positions. (Bug#6540)
192 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
194 * w32.c (sys_rename): Report EXDEV when rename of a directory
195 fails because the target is on another logical disk. (Bug#10284)
197 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
199 * xterm.c (x_embed_request_focus): New function.
201 * xterm.h: Add prototype.
203 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
205 2012-01-05 Glenn Morris <rgm@gnu.org>
207 * emacs.c (emacs_copyright): Update short copyright year to 2012.
209 2012-01-01 Eli Zaretskii <eliz@gnu.org>
211 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
212 Load gnutls_transport_set_lowat only if GnuTLS version is below
214 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
215 GnuTLS versions below 2.11.1.
217 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
219 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
220 to the doc string advising against its use for altering the way
221 windows are scrolled.
223 2011-12-28 Kenichi Handa <handa@m17n.org>
225 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
226 coding-system ASCII compatible only when it does not produce BOM
227 on encoding (Bug#10383).
229 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
231 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
233 (create_and_show_popup_menu): Always use menu_position_func for
236 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
238 * callint.c (Fcall_interactively): Don't truncate prompt string.
240 2011-12-23 Eli Zaretskii <eliz@gnu.org>
242 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
243 property that ends at ZV, so that the bidi iteration could be
244 resumed from there (after widening). (Bug#10360)
246 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
248 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
250 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
252 * nsterm.m (x_free_frame_resources):
253 Release f->output_data.ns->miniimage.
254 (ns_index_color): Fix indentation. Do not retain
255 color_table->colors[i].
257 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
260 * nsfns.m (x_set_background_color): Assign return value from
261 ns_index_color to face-background instead of NSColor*.
262 (ns_implicitly_set_icon_type): Fix indentation.
263 Change assignment in for loop to comparison.
265 * emacs.c (ns_pool): New variable.
266 (main): Assign ns_pool.
267 (Fkill_emacs): Call ns_release_autorelease_pool.
269 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
270 autorelease fdesc, release fdAttrs and tdict.
271 (ns_get_covering_families): Release charset.
272 (ns_findfonts): Release NSFontDescriptor created with new.
273 (ns_uni_to_glyphs): Fix indentation.
274 (setString): Release attrStr before assigning new value.
276 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
278 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
280 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
281 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
283 2011-12-18 David Reitter <reitter@cmu.edu>
285 * nsterm.m (ns_term_init): Subscribe for notifications
286 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
287 to method trackingNotification in EmacsMenu.
289 * nsmenu.m (trackingMenu): New variable.
290 (trackingNotification): New method (from Aquamacs).
291 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
292 from Aquamacs (Bug#7030).
294 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
296 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
297 (symbol_to_nsstring): Fix indentation.
298 (ns_symbol_to_pb): New function.
299 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
300 (Fns_rotate_cut_buffers_internal): Removed.
301 (Fns_store_selection_internal): Renamed from
302 Fns_store_cut_buffer_internal.
303 (ns_get_foreign_selection, Fx_own_selection_internal)
304 (Fx_disown_selection_internal, Fx_selection_exists_p)
305 (Fns_get_selection_internal, Fns_store_selection_internal):
306 Use ns_symbol_to_pb and check if return value is nil.
307 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
308 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
309 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
310 renamed to Sns_store_selection_internal.
311 (ns_handle_selection_request): Move code to Fx_own_selection_internal
312 and remove this function.
313 (ns_handle_selection_clear): Remove, never used.
314 (Fx_own_selection_internal): Move code from ns_handle_selection_request
317 2011-12-17 Ken Brown <kbrown@cornell.edu>
319 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
320 GID is unknown (Bug#10257).
322 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
324 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
325 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
326 which caused a build failure on GNU/Linux IA-64. This problem was
327 introduced by my 2011-10-07 patch.
329 2011-12-15 Juri Linkov <juri@jurta.org>
331 * image.c (imagemagick_error): New function. (Bug#10112)
332 (imagemagick_load_image): Comment out `MagickSetResolution' call.
333 Use `imagemagick_error' where ImageMagick functions return
335 (Fimagemagick_types): Add `Fnreverse' to return the list in the
338 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
340 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
341 fill background (Bug#8992).
343 2011-12-13 Martin Rudalics <rudalics@gmx.at>
345 * window.c (Vwindow_combination_resize)
346 (Vwindow_combination_limit): Use t instead of non-nil in
348 (Vrecenter_redisplay): Add first sentence of doc-string on
350 (Frecenter): Fix doc-string typo.
352 2011-12-11 Kenichi Handa <handa@m17n.org>
354 * coding.c (Funencodable_char_position): Pay attention to the
355 buffer text relocation (Bug#9389).
357 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
359 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
360 gtk_init (Bug#10100).
362 2011-12-10 Eli Zaretskii <eliz@gnu.org>
364 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
365 IT->string is nil. (Bug#10263)
367 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
369 * nsterm.h (x_free_frame_resources): Declare.
371 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
372 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
374 * nsterm.h (ns_get_defaults_value): Declare.
376 * nsterm.m (ns_default): Call ns_get_defaults_value.
378 2011-12-09 Eli Zaretskii <eliz@gnu.org>
380 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
383 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
385 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
386 that where the value of an _OBJC_* symbol points to is in the .bss
389 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
391 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
392 after the loop to call ccl_driver at least once (Bug#8619).
394 2011-12-08 Kenichi Handa <handa@m17n.org>
396 * ftfont.c (get_adstyle_property): Fix previous change
399 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
401 * w32.c (init_environment): If no_site_lisp, remove site-lisp
402 dirs from the default value of EMACSLOADPATH (bug#10208).
404 2011-12-07 Glenn Morris <rgm@gnu.org>
406 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
407 installation and source directories as well. (Bug#10208)
409 2011-12-06 Chong Yidong <cyd@gnu.org>
411 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
413 2011-12-06 Glenn Morris <rgm@gnu.org>
415 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
416 as an error, not just -1. (Bug#10217)
418 2011-12-05 Chong Yidong <cyd@gnu.org>
420 * keyboard.c (process_special_events): New function.
421 (swallow_events, Finput_pending_p): Use it (Bug#10195).
423 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
425 * coding.c (encode_designation_at_bol): Don't use uninitialized
426 local variable (Bug#9318).
428 2011-12-05 Kenichi Handa <handa@m17n.org>
430 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
431 return Qnil (Bug#8046, Bug#10193).
433 2011-12-05 Kenichi Handa <handa@m17n.org>
435 * coding.c (encode_designation_at_bol): New args charbuf_end and
436 dst. Return the number of produced bytes. Callers changed.
437 (coding_set_source): Return how many bytes coding->source was
439 (coding_set_destination): Return how many bytes
440 coding->destination was relocated.
441 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
442 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
444 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
446 * coding.c (CODING_CHAR_CHARSET_P): New macro.
447 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
450 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
452 The following changes are to fix Bug#9318.
454 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
455 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
456 (encode_coding_iso_2022, encode_coding_sjis)
457 (encode_coding_big5, encode_coding_charset): Use the above macros.
459 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
461 * lisp.h (process_quit_flag): Fix external declaration.
463 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
465 Don't macro-inline non-performance-critical code.
466 * eval.c (process_quit_flag): New function.
467 * lisp.h (QUIT): Use it.
469 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
471 * nsfns.m (get_geometry_from_preferences): New function.
472 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
474 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
476 * emacs.c (Qkill_emacs): Define.
477 (syms_of_emacs): Initialize it.
478 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
479 Qquit_flag to `kill-emacs' instead.
480 (quit_throw_to_read_char): Add parameter `from_signal'.
481 All callers changed. Call Fkill_emacs if requested and safe.
482 * lisp.h (QUIT): Call Fkill_emacs if requested.
484 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
486 * widget.c (update_wm_hints): Return if wmshell is null.
487 (widget_update_wm_size_hints): New function.
489 * widget.h (widget_update_wm_size_hints): Declare.
491 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
492 widget_update_wm_size_hints (Bug#10104).
494 2011-12-03 Eli Zaretskii <eliz@gnu.org>
496 * xdisp.c (handle_invisible_prop): If the invisible text ends just
497 before a newline, prepare the bidi iterator for consuming the
498 newline, and keep the current paragraph direction. (Bug#10183)
499 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
501 2011-12-02 Juri Linkov <juri@jurta.org>
503 * search.c (Fword_search_regexp): New Lisp function created from
504 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
505 (Fword_search_backward, Fword_search_forward)
506 (Fword_search_backward_lax, Fword_search_forward_lax):
507 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
508 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
510 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
512 * fileio.c (Finsert_file_contents): Move after-change-function call
513 to before the "handled:" label, since all "goto handled" appear in
514 cases where the *-change-functions have already been properly called
517 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
519 * keyboard.c (interrupt_signal): Don't call kill-emacs when
520 waiting for input. (Bug#10169)
522 2011-11-30 Eli Zaretskii <eliz@gnu.org>
524 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
525 verifies glyph row's hash code--we have just reallocated the
526 glyphs, so their contents can be complete garbage. (Bug#10164)
528 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
530 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
532 2011-11-30 Eli Zaretskii <eliz@gnu.org>
534 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
535 attributes are tested _before_ calling verify_row_hash, to protect
536 against GCC re-ordering of the tests. (Bug#10164)
538 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
540 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
542 * xterm.c (handle_one_xevent): Only set async_visible and friends
543 if net_wm_state_hidden_seen is non-zero (Bug#10002)
544 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
545 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
547 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
549 Remove GCPRO-related macros that exist only to avoid shadowing locals.
550 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
551 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
552 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
553 All uses changed to use GCPRO1 etc.
554 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
555 Revert to old implementation (i.e., before 2011-03-11).
557 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
559 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
560 of scroll runs so as to avoid assigning disabled bogus rows and
561 unnecessary graphics copy operations.
563 2011-11-27 Eli Zaretskii <eliz@gnu.org>
565 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
566 (snprintf) [_MSC_VER]: Redirect to _snprintf.
567 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
568 (malloc, free, realloc, calloc): Redirect to e_* only when
571 * lisp.h (GCTYPEBITS): Move before first use.
572 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
573 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
574 this macro definition.
576 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
579 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
581 * gtkutil.c (xg_create_frame_widgets):
582 Call gtk_window_set_has_resize_grip (FALSE) if that function is
583 present with Gtk+ 2.0.
585 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
587 * fileio.c (Finsert_file_contents): Undo previous change; see
588 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
590 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
592 Rename locals to avoid shadowing.
593 * fileio.c (Finsert_file_contents):
594 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
595 * process.c (wait_reading_process_output):
596 Rename inner 'proc' to 'p' to avoid shadowing.
597 Indent for consistency with usual Emacs style.
599 2011-11-25 Eli Zaretskii <eliz@gnu.org>
601 * xdisp.c (redisplay_window): If cursor row is not fully visible
602 after recentering, and scroll-conservatively is set to a large
603 number, scroll window by a few more lines to make the cursor fully
604 visible and out of scroll-margin. (Bug#10105)
605 (start_display): Don't move to the next line if the display should
606 start at a newline that is part of a display vector or an overlay
609 2011-11-24 Juri Linkov <juri@jurta.org>
611 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
612 after the `MagickPingImage' call. (Bug#10112)
614 2011-11-23 Chong Yidong <cyd@gnu.org>
616 * window.c (Fcoordinates_in_window_p): Accept only live windows.
618 2011-11-23 Martin Rudalics <rudalics@gmx.at>
620 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
621 making another buffer current. (Bug#10114)
623 2011-11-23 Glenn Morris <rgm@gnu.org>
625 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
627 2011-11-23 Chong Yidong <cyd@gnu.org>
629 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
632 2011-11-22 Eli Zaretskii <eliz@gnu.org>
634 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
635 and header-lines, as they don't have one computed for them.
638 * .gdbinit (prow): Make displayed values more self-explaining.
641 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
643 * process.c (wait_reading_process_output): Fix asynchrounous
644 GnuTLS socket handling on some versions of the GnuTLS library.
645 (wait_reading_process_output): Add comment and URL.
647 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
649 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
651 2011-11-21 Chong Yidong <cyd@gnu.org>
653 * window.c (Fnext_window, Fprevious_window): Doc fix.
655 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
657 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
659 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
661 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
663 2011-11-20 Martin Rudalics <rudalics@gmx.at>
665 * window.c (Fset_window_combination_limit): Rename argument
667 (Vwindow_combination_limit): Remove "status" from doc-string.
669 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
671 * m/ibms390.h: Remove.
672 * m/ibms390x.h: Don't include "ibms390.h".
674 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
676 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
677 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
679 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
681 * casetab.c (Fset_case_table):
682 * charset.c (Fcharset_after): Fix typos.
684 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
686 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
687 Otherwise, valgrind does not work on some platforms.
688 Problem reported by Andreas Schwab in
689 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
690 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
691 is set, removing the need for VIRT_ADDRESS_VARIES.
692 (PURE_P): Use a more-efficient implementation that needs just one
693 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
694 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
695 to 4 (xorl, subq, cmpq, setbe).
696 * alloc.c (pure): Always extern now, since that's the
697 VIRT_ADDR_VARIES behavior.
698 (PURE_POINTER_P): Use a single comparison, not two, for
699 consistency with the new puresize.h.
700 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
701 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
702 Remove VIRT_ADDR_VARIES no longer needed.
704 2011-11-19 Eli Zaretskii <eliz@gnu.org>
706 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
707 (erase_phys_cursor, update_window_cursor, show_mouse_face)
708 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
709 behave as if the cursor position were at the window margin.
711 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
712 and the cursor position is out of bounds, behave as if the cursor
713 position were at the window margin. (Bug#10075)
715 2011-11-18 Chong Yidong <cyd@gnu.org>
717 * window.c (Fwindow_combination_limit): Make first argument
718 non-optional, since it is meaningless for live windows like the
721 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
723 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
725 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
727 * intervals.c: Fix grafting over the whole buffer (bug#10071).
728 (graft_intervals_into_buffer): Simplify.
730 2011-11-18 Eli Zaretskii <eliz@gnu.org>
732 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
733 hash values of the two rows.
734 (copy_row_except_pointers): Preserve the used[] arrays and the
735 hash values of the two rows. (Bug#10035)
736 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
738 * xdisp.c (row_hash): New function, body extracted from
739 compute_line_metrics.
740 (compute_line_metrics): Call row_hash, instead of computing the
743 * dispnew.c (verify_row_hash): Call row_hash for computing the
744 hash code of a row, instead of duplicating code from xdisp.c.
746 * dispextern.h (row_hash): Add prototype.
748 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
750 * frame.c (delete_frame): Don't delete the terminal when the last
751 X frame is closed if emacs is built with GTK toolkit.
753 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
755 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
757 2011-11-17 Martin Rudalics <rudalics@gmx.at>
759 * window.c (Vwindow_splits): Rename to
760 Vwindow_combination_resize. Suggested by Juri Linkov.
761 (Fsplit_window_internal): Use Vwindow_combination_resize instead
764 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
766 * nsfns.m (Fns_font_name):
767 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
769 2011-11-16 Martin Rudalics <rudalics@gmx.at>
771 * window.h (window): Rename slot "nest" to "combination_limit".
772 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
773 (Fset_window_nest): Rename to Fset_window_combination_limit.
774 (Vwindow_nest): Rename to Vwindow_combination_limit.
775 (recombine_windows, make_parent_window, make_window)
776 (Fsplit_window_internal, saved_window)
777 (Fset_window_configuration, save_window_save): Rename all
778 occurrences of window_nest to window_combination_limit.
780 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
782 * image.c (imagemagick_load_image): Fix typo.
784 2011-11-14 Eli Zaretskii <eliz@gnu.org>
786 * xdisp.c (display_line): Move the call to
787 highlight_trailing_whitespace before the call to
788 compute_line_metrics, since the latter needs to see the final
789 faces of all the glyphs to compute ROW's hash value.
790 Fixes assertion violations in row_equal_p. (Bug#10035)
792 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
794 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
795 just return (bug#10044).
797 2011-11-12 Eli Zaretskii <eliz@gnu.org>
799 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
800 with user-defined heap size. Bump the default size of the temacs
801 heap to 27MB, to avoid memory warning when running temacs.
802 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
804 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
805 current_matrix and desired_matrix. (Bug#9990)
806 (verify_row_hash) [XASSERTS]: New function.
807 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
808 that the hash value of glyph rows is correct.
810 2011-11-12 Martin Rudalics <rudalics@gmx.at>
812 * window.h (window): Remove splits slot.
813 * window.c (Fwindow_splits, Fset_window_splits): Remove.
814 (Fdelete_other_windows_internal, make_parent_window)
815 (make_window, Fsplit_window_internal, Fdelete_window_internal)
816 (Fset_window_configuration, save_window_save): Don't deal with
817 split status of windows.
818 (saved_window): Remove splits slot.
819 (Vwindow_splits): Rewrite doc-string.
821 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
823 * xfns.c (unwind_create_frame):
824 * nsfns.m (unwind_create_frame):
825 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
826 Vframe_list (Bug#9999).
828 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
830 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
832 2011-11-11 Kenichi Handa <handa@m17n.org>
834 * callproc.c (Fcall_process): Set the member dst_multibyte of
837 2011-11-11 Johan Bockgård <bojohan@gnu.org>
839 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
840 avoid a crash (bug#9496).
842 2011-11-09 Chong Yidong <cyd@gnu.org>
844 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
845 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
847 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
849 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
851 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
853 Avoid some portability problems by eschewing 'extern inline' functions.
854 The trivial performance wins aren't worth the portability hassles; see
855 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
857 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
858 (window_box_width, window_box_left, window_box_left_offset)
859 (window_box_right, window_box_right_offset): Undo previous change,
860 by removing the "extern"s.
861 * intervals.c (adjust_intervals_for_insertion)
862 (adjust_intervals_for_deletion): Undo previous change,
863 making these static again.
864 (offset_intervals, temp_set_point_both, temp_set_point)
865 (copy_intervals_to_string): No longer inline.
866 * xdisp.c (window_text_bottom_y, window_box_width)
867 (window_box_height, window_box_left_offset)
868 (window_box_right_offset, window_box_left, window_box_right)
869 (window_box): No longer inline.
871 2011-11-08 Chong Yidong <cyd@gnu.org>
873 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
874 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
875 Signal an error if not a live window.
876 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
877 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
879 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
881 * lisp.h (syms_of_abbrev): Remove declaration.
882 Reported by CHENG Gao <chenggao@royau.me>.
884 2011-11-07 Eli Zaretskii <eliz@gnu.org>
886 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
887 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
888 of temacs in GUI mode.
890 2011-11-07 Martin Rudalics <rudalics@gmx.at>
892 * window.h: Declare delete_all_child_windows instead of
893 delete_all_subwindows.
894 * window.c (Fwindow_nest, Fset_window_nest)
895 (Fset_window_new_total, Fset_window_new_normal)
896 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
897 (delete_all_subwindows): Rename to delete_all_child_windows.
898 (Fdelete_other_windows_internal, Fset_window_configuration):
899 Call delete_all_child_windows instead of delete_all_subwindows.
900 * frame.c (delete_frame): Call delete_all_child_windows instead
901 of delete_all_subwindows.
903 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
905 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
906 This is also needed for porting to any host where GC_MARK_STACK is
907 not GC_MAKE_GCPROS_NOOPS.
908 (which_symbols): Use it.
910 2011-11-07 Kenichi Handa <handa@m17n.org>
912 * coding.c (coding_set_destination): Check coding->src_pos only
913 when coding->src_object is a buffer (bug#9910).
915 * process.c (send_process): Set the member src_multibyte of coding
916 to 0 (bug#9911) when sending a unibyte text.
918 * callproc.c (Fcall_process): Set the member src_multibyte of
919 process_coding to 0 (bug#9912).
921 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
923 * xmenu.c (cleanup_widget_value_tree): New function.
924 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
925 calling free_menubar_widget_value_tree directly (Bug#9830).
927 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
929 Fix some portability problems with 'inline'.
930 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
931 (window_box_width, window_box_left, window_box_left_offset)
932 (window_box_right, window_box_right_offset): Declare extern.
933 Otherwise, these inline functions do not conform to C99 and
934 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
935 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
936 * intervals.c (adjust_intervals_for_insertion)
937 (adjust_intervals_for_deletion): Now extern, because otherwise the
938 extern inline functions 'offset_intervals' couldn't refer to it.
939 (static_offset_intervals): Remove.
940 (offset_intervals): Rewrite using the old contents of
941 static_offset_intervals. The old version didn't conform to C99
942 because an extern inline function contained a reference to an
943 identifier with static linkage.
945 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
947 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
950 2011-11-06 Eli Zaretskii <eliz@gnu.org>
952 * xdisp.c (init_iterator, reseat_to_string): Don't set the
953 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
954 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
955 return Qleft_to_right.
957 2011-11-06 Chong Yidong <cyd@gnu.org>
959 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
960 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
961 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
962 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
963 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
964 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
965 (Fwindow_vscroll): Doc fix.
966 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
967 argument, since it makes no sense to pass a live window and for
968 consistency with window-child.
970 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
972 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
975 2011-11-05 Jason Rumney <jasonr@gnu.org>
977 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
978 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
980 (add_font_entity_to_list): Fix logic errors in mixed boolean and
981 bitwise arithmetic preventing use of unicode-sip and non-truetype
984 2011-11-05 Eli Zaretskii <eliz@gnu.org>
986 * s/ms-w32.h (fstat, stat, utime): Move redirections to
989 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
990 initialization code to keep similarity to xfns.c after changes
993 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
995 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
996 (unwind_create_frame): New function (Bug#9943).
997 (Fx_create_frame): Restructure code to be more similar to the one in
998 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
999 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1000 Move terminal->reference_count++ just before making the frame official
1003 * nsterm.m (x_free_frame_resources): New function.
1004 (x_destroy_window): Move code to x_free_frame_resources.
1006 * xfns.c (unwind_create_frame): Fix comment.
1007 (Fx_create_frame, x_create_tip_frame):
1008 Move terminal->reference_count++ just before making the frame
1009 official. Move initialization of image_cache_refcount and
1010 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1012 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1014 Support MSVC build with newer versions of Visual Studio.
1015 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1016 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1019 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1020 which are not supported by MSVC.
1021 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1022 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1024 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1026 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1028 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1030 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1032 Support MSVC build with newer versions of Visual Studio.
1033 * w32.c: Don't include w32api.h for MSVC.
1034 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1036 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1037 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1038 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1039 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1041 (alloca) [_MSC_VER]: Define to _alloca.
1043 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1045 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1047 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1049 * xdisp.c (note_mouse_highlight): If either of
1050 previous/next-single-property-change returns nil, treat that as
1051 the beginning or the end of the buffer. (Bug#9955)
1053 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1055 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1056 label is not null (Bug#9951).
1057 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1060 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1062 * window.c (Fwindow_body_size): Mention in the doc string that the
1063 return value is in frame's canonical units. (Bug#9949)
1065 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1067 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1069 * w32fns.c (unwind_create_frame): If needed, free the glyph
1070 matrices of the partially constructed frame. (Bug#9943)
1071 * xfns.c (unwind_create_frame): Likewise.
1073 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1075 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1076 Don't stop backward scan on the continuation glyph, even though
1077 its CHARPOS is positive.
1078 (mouse_face_from_buffer_pos, note_mouse_highlight):
1079 Rename cover_string to disp_string.
1081 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1083 * window.c (temp_output_buffer_show): Don't use
1084 Vtemp_buffer_show_specifiers.
1085 (Vtemp_buffer_show_specifiers): Remove unused variable.
1087 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1089 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1090 past the beginning of the current glyph matrix.
1092 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1094 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1095 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1096 HAVE_GTK3 (Bug#9869).
1098 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1099 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1101 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1103 * xterm.c: Declare x_handle_net_wm_state to return int.
1104 (handle_one_xevent): Check if we are iconified but don't have
1105 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1106 (get_current_wm_state): Return non-zero if not hidden,
1107 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1108 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1109 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1110 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1112 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1114 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1115 so that this new function doesn't get optimized away by a
1116 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1118 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1120 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1122 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1124 Fix the `xbytecode' command.
1125 * .gdbinit (xprintbytestr): New command.
1126 (xwhichsymbols): Rename from `which'; all callers changed.
1127 (xbytecode): Print the byte-code string as well.
1129 2011-10-29 Kim Storm <storm@cua.dk>
1131 * alloc.c (which_symbols): New function.
1133 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1135 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1138 2011-10-29 Glenn Morris <rgm@gnu.org>
1140 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1141 Not clear what it was for, and it causes various bugs. (Bug#9839)
1143 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1145 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1146 possible random value that matches one of those tested as
1147 condition to clear the mouse face.
1149 2011-10-28 Chong Yidong <cyd@gnu.org>
1151 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1153 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1155 * window.c (make_window): Initialize phys_cursor_on_p.
1157 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1159 * lisp.h (struct Lisp_Symbol): Update comments.
1161 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1163 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1165 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1167 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1168 <oslsachem@gmail.com> for helping to debug this.
1170 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1171 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1172 (g_b_init_get_glyph_outline_w): New static variables.
1173 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1174 (GetGlyphOutlineW_Proc): New typedefs.
1175 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1176 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1178 (w32font_open_internal, compute_metrics):
1179 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1180 instead of calling the "wide" APIs directly.
1182 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1184 * w32.h (syms_of_w32font): Add prototype.
1186 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1188 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1189 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1190 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1191 (Fmove_to_window_line): Doc fix.
1193 2011-10-27 Chong Yidong <cyd@gnu.org>
1195 * process.c (make_process): Set gnutls_state to NULL.
1197 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1198 non-NULL, regardless of GNUTLS_INITSTAGE.
1199 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1200 an error. Set process slots as soon as we allocate them.
1202 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1204 2011-10-27 Chong Yidong <cyd@gnu.org>
1206 * gnutls.c (emacs_gnutls_deinit): New function.
1207 Deallocate credentials structures as well as calling gnutls_deinit.
1208 (Fgnutls_deinit, Fgnutls_boot): Use it.
1210 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1211 (deactivate_process): Call emacs_gnutls_deinit.
1213 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1215 * image.c (x_create_x_image_and_pixmap):
1216 * w32.c (sys_rename, w32_delayed_load):
1217 * w32font.c (fill_in_logfont):
1218 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1220 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1222 * w32fns.c (w32_default_color_map): New function,
1223 extracted from Fw32_default_color_map.
1224 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1226 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1228 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1230 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1232 * keyboard.c (test_undefined): New function (bug#9751).
1233 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1235 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1237 * sysdep.c (init_sys_modes): Fix the check for the controlling
1238 terminal (Bug#6649).
1240 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1242 * dispextern.h (struct bidi_it): New member next_en_type.
1244 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1245 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1246 current character, check also for next_en_type being WEAK_EN.
1247 (bidi_resolve_weak): Don't enter the expensive loop if the current
1248 position is before next_en_pos. Record the bidi type of the first
1249 non-ET, non-BN character we find, in addition to its position.
1250 (bidi_level_of_next_char): Invalidate next_en_type when
1251 next_en_pos is over-stepped.
1253 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1255 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1256 * editfns.c: Rewrite current-time-zone so that it invokes
1257 the equivalent of (format-time-string "%Z") to get the time zone name.
1258 This fixes a bug when the time zone name contains characters that
1259 need converting from the system time locale to Emacs internal format.
1260 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1261 that patch fixed format-time-string to do the conversion, but
1262 I forgot to fix current-time-zone.
1263 (format_time_string): New function, containing most of
1264 what Fformat_time_string used to contain.
1265 (Fformat_time_string): Rewrite in terms of format_time_string.
1266 This doesn't change this function's behavior.
1267 (current-time-zone): Rewrite to use format_time_string.
1268 This fixes the bug reported by Michael Schierl in
1269 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1270 Jason Rumney's 2007-06-07 change worked around this bug, but
1272 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1274 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1276 * xdisp.c (start_display): If the character at POS is displayed
1277 via a display vector, reset IT->current.dpvec_index to zero.
1278 (try_window_reusing_current_matrix): If a line ends in a display
1279 vector or the next line starts in a display vector, continue
1280 redrawing the window even though the character position of
1281 start_row was reached.
1284 2011-10-18 Chong Yidong <cyd@gnu.org>
1286 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1287 with nobreak-char-display too.
1289 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1291 Fix part 3 of bug#9771.
1292 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1293 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1294 non-neutral characters if the current character is a paragraph
1295 separator (a.k.a. Newline). This avoids running the same
1296 expensive loop twice, once when we consume the preceding newline
1297 and the other time when the line actually needs to be displayed.
1298 Avoid the loop when we see neutrals on the base embedding level
1299 following a character whose directionality is the same as the
1300 paragraph's. This avoids running the expensive loop when a line
1301 ends in a long sequence of neutrals, like control characters.
1302 Add assertion against STRONG_AL type. Slightly rearrange code
1303 that determines the type of a neutral given the first non-neutral
1305 (bidi_level_of_next_char): Set next_en_pos to zero when
1306 invalidating its info.
1308 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1310 * xdisp.c (push_display_prop): Determine whether to record string
1311 or buffer position by IT->string, not by IT->method. Allow
1312 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1313 (move_it_vertically_backward): Don't look for character position
1314 immediately after the newline when in a continuation line.
1317 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1319 * window.c (coordinates_in_window): Rewrite and delabelize
1320 vertical border check. (Bug#5357) (Bug#9618)
1322 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1324 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1325 errors in XSetWindowBorder (bug#9310).
1327 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1329 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1330 avoid crash when xmalloc overrun checking is enabled.
1332 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1334 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1335 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1336 cursor motion with <left> and <right> arrow keys.
1338 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1339 some callers set that themselves.
1341 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1343 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1344 display string and the previous row comes from the same string and
1345 is empty. (Bug#9739) (Bug#9738)
1347 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1349 * doc.c (get_doc_string): Encode file name (bug#9735).
1351 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1353 * bidi.c (bidi_level_of_next_char):
1354 * xdisp.c (get_visually_first_element): Remove old incorrect
1355 comments regarding the Unicode Line Separator character.
1357 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1359 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1361 * alloc.c (Fgc_status): Do not access beyond zombies array
1362 boundary if nzombies > MAX_ZOMBIES.
1363 * alloc.c (dump_zombies): Add missing format specifier.
1365 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1367 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1368 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1370 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1371 Some packages use them to denote characters with modifiers.
1373 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1375 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1376 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1377 matching a pp-number. Rename parameter var to var1.
1379 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1381 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1383 2011-10-08 Glenn Morris <rgm@gnu.org>
1385 * callint.c (Fcall_interactively): Give a more explicit error for the
1386 'c' case with a non-character input. (Bug#8479)
1388 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1390 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1392 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1393 lines that are hscrolled on the left.
1395 * dispnew.c (buffer_posn_from_coords): Account for a possible
1396 presence of header-line. (Bug#4426)
1398 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1400 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1401 Don't advertise functionality which we discourage or doesn't work.
1403 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1405 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1406 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1407 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1408 this makes Emacs dump core during garbage collection on rare
1409 occasions. sizeof is obviously inferior to offsetof here, so
1410 stick with offsetof.
1411 (GC_POINTER_ALIGNMENT): New macro.
1412 (mark_memory): Omit 3rd (offset) arg; caller changed.
1413 Don't assume EMACS_INT alignment is the same as pointer alignment.
1415 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1417 * keyboard.c (read_key_sequence_remapped): New var.
1418 (read_key_sequence): Compute remapping in the right buffer.
1419 (command_loop_1): Use read_key_sequence's remapping directly.
1421 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1423 * dired.c (file_name_completion): Don't expand file name.
1424 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1425 before checking file name handler.
1427 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1428 they've been requested explicitly (bug#9591).
1430 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1432 * keymap.c (Fsingle_key_description): Use make_specified_string
1433 instead of build_string to build string from push_key_description.
1436 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1438 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1439 This fixes a Y2038 bug on 64-bit hosts.
1440 * buffer.c (reset_buffer):
1441 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1442 (Fclear_buffer_auto_save_failure):
1443 Use 0, not -1, to represent an unset failure time, since time_t
1444 might not be signed.
1446 Remove dependency on glibc malloc internals.
1447 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1448 Move back here from lisp.h, but with their new implementations.
1449 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1450 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1451 * charset.c (charset_table_init): New static var.
1452 (syms_of_charset): Use it instead of xmalloc. This removes a
1453 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1454 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1455 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1456 Move back to alloc.c.
1457 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1458 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1460 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1462 * nsterm.m (windowDidResize): Call x_set_window_size only when
1463 ns_in_resize is true. Otherwise set pixelwidth/height and
1464 call change_frame_size (Bug#9628).
1466 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1468 Port --enable-checking=all to Fedora 14 x86-64.
1469 * charset.c (syms_of_charset): Also account for glibc malloc's
1470 internal overhead when calculating the initial malloc maximum.
1472 Port --enable-checking=all to Fedora 14 x86.
1473 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1475 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1476 (overrun_check_realloc, overrun_check_free):
1477 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1478 That way, xmalloc returns a properly-aligned pointer even if
1479 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1480 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1481 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1482 into account when calculating the initial malloc maximum.
1483 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1484 Move here from alloc.c, so that charset.c can use it too.
1485 Properly align; the old code wasn't right for common 32-bit hosts
1486 when configured with --enable-checking=all.
1487 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1488 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1490 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1492 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1495 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1497 * xdisp.c (compute_display_string_end): If there's no display
1498 string at CHARPOS, return -1.
1500 * bidi.c (bidi_fetch_char): When compute_display_string_end
1501 returns a negative value, treat the character as a normal
1502 character not covered by a display string. (Bug#9624)
1504 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1506 * lread.c (Fread_from_string): Fix typo in docstring.
1508 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1510 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1511 newline, reseat the iterator instead of bidi-iterating there one
1512 character at a time. (Bug#9610)
1513 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1514 TO_CHARPOS if the bidi iterator is at base embedding level.
1516 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1518 * lread.c (readevalloop): Use correct code for NBSP.
1519 (read1): Likewise. (Bug#9608)
1521 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1523 * dbusbind.c (Fdbus_register_signal): When service is not
1524 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1526 2011-09-25 Glenn Morris <rgm@gnu.org>
1528 * buffer.c (truncate-lines): Doc fix.
1530 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1532 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1533 (Fset_window_next_buffers): Doc fix.
1535 2011-09-24 Glenn Morris <rgm@gnu.org>
1537 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1539 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1541 Fix minor problems found by static checking.
1542 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1543 * indent.c (Fvertical_motion): Fix == vs = typo.
1545 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1547 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1548 Default value is now t. Doc fix.
1550 * indent.c (Fvertical_motion): Compute and apply the overshoot
1551 logic when moving up, not only when moving down. Fix the
1552 confusing name and values of the it_overshoot_expected variable;
1553 logic changes accordingly. (Bug#9254) (Bug#9549)
1555 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1556 CHARPOS is covered by a display string which includes newlines.
1557 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1558 is covered by a display string with embedded newlines.
1560 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1562 * dbusbind.c (Fdbus_register_signal): Add match rule to
1563 Vdbus_registered_objects_table. (Bug#9581)
1564 (Fdbus_register_method, Vdbus_registered_objects_table):
1567 2011-09-24 Jim Meyering <meyering@redhat.com>
1569 do not ignore write error for any output size
1570 The previous change was incomplete.
1571 While it makes emacs --batch detect the vast majority of stdout
1572 write failures, errors were still ignored whenever the output size is
1573 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1574 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1575 && echo FAIL: ignored write error
1576 FAIL: ignored write error
1577 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1578 && echo FAIL: ignored write error
1579 FAIL: ignored write error
1580 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1582 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1584 * emacs.c (Fkill_emacs): In noninteractive mode exit
1585 non-successfully if a write error occurred on stdout. (Bug#9574)
1587 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1589 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1592 * dispextern.h (struct it): Update the comment documenting what
1595 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1597 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1598 a display string, extend search for cursor position to end of row.
1599 (find_row_edges): If the row ends in a newline from a display
1600 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1601 Handle the case of a display string with multiple newlines.
1602 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1603 non-empty line. Fixes confusing cursor motion with arrow keys at
1604 the beginning of a line that starts with whitespace.
1606 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1608 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1611 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1613 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1616 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1618 * xdisp.c (display_line): Record maximum and minimum buffer
1619 positions even if no glyphs were produced (e.g., by a zero-width
1620 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1621 buffer positions that will be removed from the glyph row because
1623 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1624 column is beyond frame width: don't subtract 1 "pixel" when
1625 computing width of the stretch.
1626 (reseat_at_next_visible_line_start): Undo the change made on
1627 2011-09-17 that saved paragraph information and restored it after
1628 the call to `reseat'. (Bug#9545)
1630 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1632 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1633 and turn window cursor on if cleared (Bug#9415).
1635 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1637 * search.c (boyer_moore): Take unibyte characters from pattern
1638 literally. (Bug#9458)
1640 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1642 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1644 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1646 Fix minor problem found by static checking.
1647 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1648 initialized, to pacify gcc -Wuninitialized.
1650 * fileio.c: Report proper errno when syscall falls.
1651 (Finsert_file_contents): Save and restore errno,
1652 so that report_file_error outputs the correct diagnostic.
1653 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1655 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1657 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1659 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1661 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1662 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1664 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1666 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1667 about the current paragraph and restore it after the call to reseat.
1669 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1670 (bidi_find_paragraph_start): Search back for paragraph beginning
1671 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1672 (bidi_move_to_visually_next): Only trigger paragraph-related
1673 computations when the last character is a newline or at EOB, not
1674 just any NEUTRAL_B. (Bug#9470)
1676 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1677 truncated lines if point is covered by a display string. (Bug#9524)
1679 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1681 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1682 (cons_to_x_long): New function.
1683 (lisp_data_to_selection_data): Use it. Correct the test for
1684 short-versus-long data; it was negated. Break out of vector
1685 loop, for efficiency, when a long datum is discovered.
1687 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1689 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1691 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1693 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1694 GCC PR/17406) by declaring this function with external scope.
1696 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1698 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1699 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1701 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1703 * editfns.c (Fformat): Correctly handle text properties on "%%".
1705 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1707 * xterm.c (x_draw_composite_glyph_string_foreground):
1708 * w32term.c (x_draw_composite_glyph_string_foreground):
1709 * term.c (encode_terminal_code):
1710 * composite.c (composition_update_it, get_composition_id):
1711 * xdisp.c (get_next_display_element)
1712 (fill_composite_glyph_string): Add comments about special meaning
1713 of TAB characters in a composition.
1715 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1717 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1718 This occurs when processing a multibyte format.
1719 Problem reported by Wolfgang Jenker.
1721 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1723 * xdisp.c (try_cursor_movement): Only check for exact match if
1724 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1726 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1728 Remove unused external symbols.
1729 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1730 * xdisp.c (calc_pixel_width_or_height): Now static.
1731 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1732 * indent.c (check_display_width):
1733 * w32term.c: Fix comment to match code.
1734 * xterm.c, xterm.h (x_catching_errors): Remove.
1736 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1738 * xselect.c: Use signed conversions more consistently (Bug#9498).
1739 (selection_data_to_lisp_data): Assume incoming selection data are
1740 signed integers, not unsigned. This is to be consistent with
1741 outgoing selection data, which was modified to use signed integers
1742 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1743 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1744 expects long, not unsigned long.
1746 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1748 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1749 computation of loop end. Reported by Johan Bockgård
1752 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1754 * frame.c (Fother_visible_frames_p): Function deleted.
1756 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1758 * indent.c (compute_motion): Process display vector front to back
1759 rather than the other way around. (Bug#2496)
1761 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1763 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1765 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1767 * minibuf.c (Fread_from_minibuffer): Doc fix.
1769 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1771 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1772 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1774 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1776 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1777 value for non-existent files.
1779 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1781 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1782 set its "size" to -1. This will set the modtime_size field of
1783 the corresponding buffer to -1, which is what
1784 verify-visited-file-modtime expects for files that do not exist.
1787 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1789 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1791 * lisp.h: ... from here. push_key_description is no longer
1792 defined in keyboard.c, so its declaration should not be in
1793 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1794 logically belongs with push_key_description.
1796 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1798 * buffer.h: Include <sys/types.h> instead of <time.h>.
1799 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1800 Problem reported by Herbert J. Skuhra.
1802 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1804 * xml.c (parse_region): Make the parsing work for
1805 non-comment-starting XML files again (bug#9144).
1807 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1809 * image.c (gif_load): Fix calculation of bottom and right corner.
1812 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1814 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1815 redisplay in small windows.
1817 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1819 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1821 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1823 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1824 Operate on live windows only.
1826 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1828 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1830 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1832 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1833 only under bidi iteration.
1835 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1837 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1839 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1841 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1842 Without this fix, the command to link temacs failed due to an
1843 undefined symbol __builtin_isnan. This is because
1844 /usr/include/iso/math_c99.h #defines isnan(x) to
1845 __builtin_isnan(x), but the bundled gcc, which identifies itself
1846 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1848 * floatfns.c (isnan): #undef, and then #define to a clone of
1850 (Fisnan): Always define, since it's always available now.
1851 (syms_of_floatfns): Always define isnan at the Lisp level.
1853 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1855 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1857 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1859 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1860 The previous code assumed that file offsets (off_t values) fit in
1861 EMACS_INT variables, which is not true on typical 32-bit hosts.
1862 The code messed up by falsely reporting buffer overflow in cases
1863 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1864 when "big" contains more than 2**29 bytes, even though this
1865 inserts just one byte and does not overflow the buffer.
1866 (Finsert_file_contents): Store file offsets as off_t
1867 values, not as EMACS_INT values. Check for overflow when
1868 converting between EMACS_INT and off_t. When checking for
1869 buffer overflow or for overlap, take the offsets into account.
1870 Don't use EMACS_INT for small values where int suffices.
1871 When checking for overlap, fix a typo: ZV was used where
1872 ZV_BYTE was intended.
1873 (Fwrite_region): Don't assume off_t fits into 'long'.
1874 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1876 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1878 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1880 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1882 sprintf-related integer and memory overflow issues (Bug#9412).
1884 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1885 (esprintf, exprintf, evxprintf): New functions.
1886 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1887 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1888 (modify_event_symbol): Do not assume that the length of
1889 name_alist_or_stem is safe to alloca and fits in int.
1890 (Fexecute_extended_command): Likewise for function name and binding.
1891 (Frecursion_depth): Wrap around reliably on integer overflow.
1892 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1893 since some callers pass EMACS_INT values.
1894 (Fsingle_key_description): Don't crash if symbol name contains more
1895 than MAX_ALLOCA bytes.
1896 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1897 (get_minibuffer): Arg is now EMACS_INT, not int.
1898 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1899 (esprintf, exprintf, evxprintf): New decls.
1900 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1902 * dbusbind.c (signature_cat): New function.
1903 (xd_signature, Fdbus_register_signal):
1904 Do not overrun buffer; instead, report string overflow.
1906 * dispnew.c (add_window_display_history): Don't overrun buffer.
1907 Truncate instead; this is OK since it's just a log.
1909 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1910 even if the time zone offset is outlandishly large.
1911 Don't mishandle offset == INT_MIN.
1913 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1914 when creating daemon; the previous buffer-overflow check was incorrect.
1916 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1917 which has the guts of the old verror function.
1919 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1920 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1922 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1923 (font_unparse_xlfd): Don't blindly alloca long strings.
1924 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1925 fits in int, when using sprintf. Use single snprintf to count
1926 length of string rather than counting it via multiple sprintfs;
1927 that's simpler and more reliable.
1928 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1929 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1930 sprintf, in case result does not fit in int.
1932 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1933 (fontset_from_font): Print it.
1935 * frame.c (tty_frame_count): Now printmax_t, not int.
1936 (make_terminal_frame, set_term_frame_name): Print it.
1937 (x_report_frame_params): In X, window IDs are unsigned long,
1938 not signed long, so print them as unsigned.
1939 (validate_x_resource_name): Check for implausibly long names,
1940 and don't assume name length fits in 'int'.
1941 (x_get_resource_string): Don't blindly alloca invocation name;
1942 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1945 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1946 (xg_check_special_colors, xg_set_geometry):
1947 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1949 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1950 Use esprintf, not sprintf, in case result does not fit in int.
1952 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1953 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1954 it as a large positive number.
1955 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1956 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1958 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1959 in case result does not fit in int.
1961 * print.c (float_to_string): Detect width overflow more reliably.
1962 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1963 buffer overrun. Don't assume list length fits in 'int'. Treat
1964 print length of 0 as 0, not as infinity; to be consistent with other
1965 uses of print length in this function. Don't overflow print length
1966 index. Don't assume hash table size fits in 'long', or that
1967 vectorlike size fits in 'unsigned long'.
1969 * process.c (make_process): Use printmax_t, not int, to format
1970 process-name gensyms.
1972 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1974 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1975 to avoid potential buffer overrun.
1977 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1978 if X resource line is longer than 512 bytes.
1980 * xfns.c (x_window): Make sprintf buffer a bit bigger
1981 to avoid potential buffer overrun.
1983 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1985 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1987 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1989 Integer overflow fixes for scrolling, etc.
1990 Without these, Emacs silently mishandles large integers sometimes.
1991 For example, "C-u 4294967297 M-x recenter" was treated as if
1992 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1994 * xdisp.c (try_window_id): Check Emacs fixnum range before
1995 converting to 'int'.
1997 * window.c (window_scroll_line_based, Frecenter):
1998 Check that an Emacs fixnum is in range before assigning it to 'int'.
1999 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2000 values converted from Emacs fixnums.
2001 (Frecenter): Don't wrap around a line count if it is out of 'int'
2002 range; instead, treat it as an extreme value.
2003 (Fset_window_configuration, compare_window_configurations):
2004 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2006 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2007 that can exceed INT_MAX. Check that EMACS_INT value is in range
2008 before assigning it to the (possibly-narrower) index.
2009 (match_limit): Don't assume that a fixnum can fit in 'int'.
2011 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2014 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2015 (Fvertical_motion): Don't wrap around LINES values that don't fit
2016 in 'int'. Instead, treat them as extreme values. This is good
2017 enough for windows, which can't have more than INT_MAX lines anyway.
2019 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2021 * Require libxml/parser.h to avoid compilation warning.
2023 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2025 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2026 since this reportedly can destroy thread storage.
2028 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2030 * syntax.c (find_defun_start): Update all cache variables if
2031 exiting early (Bug#9401).
2033 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2035 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2037 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2038 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2039 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2041 * term.c (tty_append_glyph): New function.
2042 (produce_stretch_glyph): Static function and its prototype deleted.
2044 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2047 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2049 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2050 when checking :margin (Bug#9390).
2051 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2052 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2053 so that the name doesn't mislead. All uses changed.
2055 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2057 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2060 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2062 * xdisp.c (move_it_to): Don't bail out early when reaching
2063 position beyond to_charpos, if we are scanning backwards.
2064 (move_it_vertically_backward): When DY == 0, make sure we get to
2065 the first character in the line after the newline.
2067 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2069 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2070 (ccl_driver): Do not generate an out-of-range pointer.
2071 (Fccl_execute_on_string): Remove unnecessary check for
2072 integer overflow, noted by Stefan Monnier in
2073 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2074 Remove a FIXME that didn't need fixing.
2075 Simplify the newly-introduced buffer reallocation code.
2077 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2079 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2081 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2083 Integer and memory overflow issues (Bug#9196).
2085 * doc.c (get_doc_string): Rework so that
2086 get_doc_string_buffer_size is the actual buffer size, rather than
2087 being 1 less than the actual buffer size; this makes xpalloc more
2090 * image.c (x_allocate_bitmap_record, cache_image):
2091 * xselect.c (Fx_register_dnd_atom):
2092 Simplify previous changes by using xpalloc.
2094 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2095 since either will do and ptrdiff_t is convenient with xpalloc.
2097 * charset.c (charset_table_size)
2098 (struct charset_sort_data.priority): Now ptrdiff_t.
2099 (charset_compare): Don't overflow if priorities differ greatly.
2100 (Fsort_charsets): Don't assume list length fits in int.
2101 Check for size-calculation overflow when allocating sort data.
2102 (syms_of_charset): Allocate an initial charset table that is
2103 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2105 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2107 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2108 The actual value is always <= INT_MAX, and leaving it unsigned made
2109 overflow checking harder.
2111 * dispextern.h (struct glyph_matrix.rows_allocated)
2112 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2113 with xpalloc. The values are still always <= INT_MAX.
2115 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2117 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2118 (SAFE_NALLOCA): New macro.
2120 * region-cache.c (struct boundary.pos, find_cache_boundary)
2121 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2122 (set_cache_region, invalidate_region_cache)
2123 (revalidate_region_cache, know_region_cache, region_cache_forward)
2124 (region_cache_backward, pp_cache):
2125 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2126 so that ptrdiff_t * can be passed to xpalloc.
2127 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2128 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2129 (pp_cache): Don't assume cache_len fits in int.
2130 * region-cache.h: Adjust extern decls to match.
2132 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2133 EMACS_INT, since either will do, for xpalloc.
2135 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2136 (xnmalloc, xnrealloc, xpalloc): New functions.
2138 * bidi.c (bidi_shelve_header_size): New constant.
2139 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2140 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2142 * bidi.c (bidi_cache_shrink):
2143 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2145 Don't update size of array until after memory allocation succeeds,
2146 because xmalloc/xrealloc may not return.
2147 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2148 now that we have proper integer overflow checking.
2149 (record_overlay_string, overlay_strings): Catch overflows when
2150 calculating size of overlay_str_buf.
2152 * callproc.c (Fcall_process): Check for size overflow when
2153 calculating size of args2.
2154 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2155 Normally we prefer signed values, but sticking with ptrdiff_t would
2156 require adding more-complicated checks.
2158 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2159 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2160 Redo buffer-overflow calculations to avoid integer overflow.
2161 Add a FIXME comment where memory seems to be over-allocated.
2163 * character.c (Fstring): Check for size-calculation overflow.
2165 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2166 unnecessary integer overflow. Check for size overflow.
2167 (encode_coding_object): Don't update size until xmalloc succeeds.
2169 * composite.c (get_composition_id): Check for overflow in glyph
2170 length calculations.
2172 Integer and memory overflow fixes for display code.
2173 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2174 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2175 (scrolling_window): Check for overflow in size calculations.
2176 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2177 Don't assume glyph table len fits in int.
2178 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2179 (row_table_size): Now ptrdiff_t, not int.
2180 (scrolling_window): Avoid overflow in size calculations.
2181 Don't update size until allocation succeeds.
2182 * fns.c (concat): Check for overflow in size calculations.
2183 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2184 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2185 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2187 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2188 (get_doc_string): Check for size calculation overflow.
2189 Don't update size until allocation succeeds.
2190 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2191 EMACS_INT, where ptrdiff_t will do.
2192 (Fsubstitute_command_keys): Check for string overflow.
2194 * editfns.c (set_time_zone_rule): Don't assume environment length
2196 (message_length): Now ptrdiff_t, not int.
2197 (Fmessage_box): Don't update size until allocation succeeds.
2198 Don't assume message length fits in int.
2199 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2201 * emacs.c (main): Do not reallocate argv, since there is a null at
2202 the end that can be overwritten, and this way there's no need to
2203 worry about size-calculation overflow.
2204 (sort_args): Check for size-calculation overflow.
2206 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2208 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2210 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2211 (x_set_scroll_bar_width, x_figure_window_size):
2212 Check for integer overflow.
2213 (x_set_alpha): Do not assume XINT fits in int.
2215 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2216 This is for the members text_lines, text_cols, total_lines, total_cols,
2217 where the system imposes an 'int' limit.
2219 * fringe.c (Fdefine_fringe_bitmap):
2220 Don't update size until alloc works.
2222 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2223 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2225 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2226 Check for size-calculation overflow.
2227 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2228 do, as we prefer signed integers.
2229 (id_to_widget.max_size, id_to_widget.used)
2230 (xg_store_widget_in_map, xg_remove_widget_from_map)
2231 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2232 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2233 Use and return ptrdiff_t, not int.
2234 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2235 * gtkutil.h: Change prototypes to match the above.
2237 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2238 are duplicate now that they've been promoted to lisp.h.
2239 (x_allocate_bitmap_record, x_alloc_image_color)
2240 (make_image_cache, cache_image, xpm_load):
2241 Don't update size until alloc is done.
2242 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2244 Check for size calculation overflow.
2245 (ct_colors_allocated_max): New constant.
2246 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2249 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2250 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2251 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2252 Use ptrdiff_t, not int, to count maps.
2253 (read_char_minibuf_menu_prompt): Check for overflow in size
2254 calculations. Don't update size until allocation succeeds.
2255 Redo calculations to avoid overflow.
2256 * keyboard.h: Change prototypes to match the above.
2258 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2260 (current_minor_maps): Check for size calculation overflow.
2261 * keymap.h: Change prototypes to match the above.
2263 * lread.c (read1, init_obarray): Don't update size until alloc done.
2265 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2266 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2268 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2269 Now ptrdiff_t, not int.
2270 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2271 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2273 * process.c (Fnetwork_interface_list): Check for overflow
2274 in size calculation.
2276 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2278 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2279 overflow. Don't bother calling xmalloc when xrealloc will do.
2281 * search.c (Freplace_match): Check for size calculation overflow.
2282 (Fset_match_data): Don't assume list lengths fit in 'int'.
2284 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2285 for command line length. Do not attempt to address one before the
2286 beginning of an array, as that's not portable.
2288 * term.c (max_frame_lines): Remove; unused.
2289 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2291 (encode_terminal_code, calculate_costs): Check for size
2292 calculation overflow.
2293 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2294 table lengths and related sizes. Don't update size until alloc
2295 done. Redo calculations to avoid overflow.
2296 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2298 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2299 subtracting pointers.
2300 (gobble_line): Check for overflow more carefully. Don't update size
2303 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2304 Don't update size until alloc done.
2305 Redo size calculations to avoid overflow.
2306 Check for size calculation overflow.
2307 (main) [DEBUG]: Fix typo in invoking tparam1.
2309 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2310 Use ptrdiff_t, not int, for sizes.
2311 (store_mode_line_noprop_char): Don't update size until alloc done.
2313 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2314 Use ptrdiff_t, not int, for sizes.
2315 (Finternal_make_lisp_face, cache_face):
2316 Check for size calculation overflow.
2317 (cache_face): Treat size calculation overflows as if they were
2318 memory exhaustion (the usual treatment), rather than aborting.
2320 * xfns.c (x_encode_text, x_set_name_internal)
2321 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2322 sizes, since they can exceed INT_MAX in size. Check for size
2323 calculation overflow.
2325 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2326 (xg_select): Check for size calculation overflow.
2327 Don't update size until alloc done.
2329 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2330 as sprintf is limited to int lengths.
2332 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2333 (X_LONG_MIN): New macros.
2334 Use them to make the following changes clearer.
2335 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2336 This change doesn't affect the value now, but it may help remind
2337 future maintainers not to raise the value too much later.
2338 (SELECTION_QUANTUM): Remove, replacing with ...
2339 (selection_quantum): ... new function, which avoids overflow.
2341 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2342 assumption that selection length fits in 'int'.
2343 (x_reply_selection_request, x_handle_selection_request)
2344 (x_get_window_property, receive_incremental_selection)
2345 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2346 (lisp_data_to_selection_data, clean_local_selection_data):
2347 Use ptrdiff_t, not int, to record length of selection.
2348 (x_reply_selection_request, x_get_window_property)
2349 (receive_incremental_selection, x_property_data_to_lisp):
2350 Redo calculations to avoid overflow.
2351 (x_reply_selection_request): When sending hint, ceiling it at
2352 X_LONG_MAX rather than relying on wraparound overflow to send
2354 (x_get_window_property, receive_incremental_selection)
2355 (lisp_data_to_selection_data, x_property_data_to_lisp):
2356 Check for size-calculation overflow.
2357 (x_get_window_property, receive_incremental_selection)
2358 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2359 Don't store size until memory allocation succeeds.
2360 (x_get_window_property): Plug memory leak on memory exhaustion.
2361 Don't double-block input; malloc is safe here. Don't assume 2**34
2362 - 4 fits in unsigned long. Add an xassert to check
2363 XGetWindowProperty overflow. Be more careful about overflow
2364 calculations, and distinguish size from memory overflow better.
2365 (receive_incremental_selection): When tracing, don't assume
2366 unsigned int is less than INT_MAX.
2367 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2368 harmful) conversions of unsigned short to int.
2369 (lisp_data_to_selection_data): Don't assume that integers
2370 in the range -65535 through -1 fit in an X unsigned short.
2371 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2372 result parameters unless successful. Rely on cons_to_unsigned
2373 to report problems with elements; the old code wasn't right anyway.
2374 (x_check_property_data): Check for int overflow; we cannot use
2375 a wider type due to X limits.
2376 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2378 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2380 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2381 (x_term_init): Check for size calculation overflow.
2382 (x_color_cells): Don't store size until memory allocation succeeds.
2383 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2384 Don't assume alloca size is less than MAX_ALLOCA.
2385 (x_term_init): Don't assume length fits in int (sprintf is limited
2388 Use ptrdiff_t for composition IDs.
2389 * character.c (lisp_string_width):
2390 * composite.c (composition_table_size, n_compositions)
2391 (get_composition_id, composition_gstring_from_id):
2392 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2393 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2394 * window.c (Frecenter):
2395 Use ptrdiff_t, not int, for composition IDs.
2396 * composite.c (get_composition_id): Check for integer overflow.
2397 * composite.h: Adjust prototypes to match the above changes.
2399 Use ptrdiff_t for hash table indexes.
2400 * category.c (hash_get_category_set):
2401 * ccl.c (ccl_driver):
2402 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2403 * coding.c (coding_system_charset_list, detect_coding_system):
2404 * coding.h (struct coding_system.id):
2405 * composite.c (get_composition_id, gstring_lookup_cache):
2406 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2407 * image.c (xpm_get_color_table_h):
2408 * lisp.h (hash_lookup, hash_put):
2409 * minibuf.c (Ftest_completion):
2410 Use ptrdiff_t for hash table indexes, not int (which is too
2411 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2412 32-bit --with-wide-int hosts).
2414 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2415 Add a FIXME comment about memory leaks.
2416 (syms_of_charset): Don't assume xmalloc returns.
2418 Don't assume that stated character widths fit in int.
2419 * character.c (Fchar_width, c_string_width, lisp_string_width):
2420 * character.h (CHAR_WIDTH):
2421 * indent.c (MULTIBYTE_BYTES_WIDTH):
2422 Use sanitize_char_width to avoid undefined and/or bad behavior
2423 with outlandish widths.
2424 * character.h (sanitize_tab_width): Rename from sanitize_width,
2425 now that we have two such functions. All uses changed.
2426 (sanitize_char_width): New inline function.
2428 Don't assume that tab-width fits in int.
2429 * character.h (sanitize_width): New inline function.
2430 (SANE_TAB_WIDTH): New macro.
2431 (ASCII_CHAR_WIDTH): Use it.
2432 * indent.c (sane_tab_width): Remove. All uses replaced by
2433 SANE_TAB_WIDTH (current_buffer).
2434 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2436 * fileio.c: Integer overflow issues with file modes.
2437 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2439 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2440 Remove unreachable code.
2441 (read_hex, load_charset_map_from_file): Check for integer overflow.
2443 * xterm.c: Don't go over XClientMessageEvent limit.
2444 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2445 (x_send_scroll_bar_event): Likewise. Check that the size does not
2446 exceed limits imposed by XClientMessageEvent, as well as the usual
2447 ptrdiff_t and size_t limits.
2449 * keyboard.c: Overflow, signedness and related fixes.
2450 (make_lispy_movement): Use same integer type in forward decl
2451 that is used in the definition.
2452 (read_key_sequence, keyremap_step):
2453 Change bufsize argument back to int, undoing my 2011-03-30 change.
2454 We prefer signed types, and int is wide enough here.
2455 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2456 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2457 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2458 length, not size_t. Use ptrdiff_t for index, not int.
2459 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2460 possibility of integer overflow.
2462 Overflow, signedness and related fixes for images.
2464 * dispextern.h (struct it.stack[0].u.image.image_id)
2465 (struct_it.image_id, struct image.id, struct image_cache.size)
2466 (struct image_cache.used, struct image_cache.ref_count):
2467 * gtkutil.c (update_frame_tool_bar):
2468 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2469 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2470 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2471 * nsmenu.m (update_frame_tool_bar):
2472 * xdisp.c (calc_pixel_width_or_height):
2473 * xfns.c (image_cache_refcount):
2474 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2475 on typical 64-bit hosts.
2477 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2478 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2479 Omit unnecessary casts to int.
2480 (parse_image_spec): Check that integers fall into 'int' range
2481 when the callers expect that.
2482 (image_ascent): Redo ascent calculation to avoid int overflow.
2483 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2484 (lookup_image): Remove unnecessary tests.
2485 (xbm_image_p): Locals are now of int, not EMACS_INT,
2486 since parse_image_check makes sure they fit into int.
2487 (png_load, gif_load, svg_load_image):
2488 Prefer int to unsigned where either will do.
2489 (tiff_handler): New function, combining the cores of the
2490 old tiff_error_handler and tiff_warning_handler.
2491 This function is rewritten to use vsnprintf and thereby avoid
2492 stack buffer overflows. It uses only the features of vsnprintf
2493 that are common to both POSIX and native Microsoft.
2494 (tiff_error_handler, tiff_warning_handler): Use it.
2495 (tiff_load, gif_load, imagemagick_load_image):
2496 Don't assume :index value fits in 'int'.
2497 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2498 (imagemagick_load_image): Check that crop parameters fit into
2499 the integer types that MagickCropImage accepts. Don't assume
2500 Vimagemagick_render_type has a nonnegative value. Don't assume
2501 size_t fits in 'long'.
2502 (gs_load): Use printmax_t to print the widest integers possible.
2503 Check for integer overflow when computing image height and width.
2505 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2507 * xdisp.c (redisplay_window): Don't force window start if point
2508 will be invisible in the resulting window. (Bug#9324)
2510 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2512 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2513 the display spec is of the form `(space ...)'.
2514 (handle_display_spec): Return the value returned by
2515 handle_single_display_spec, not just 1 or zero.
2516 (handle_single_display_spec): If the display spec is of the form
2517 `(space ...)', and specifies display in the text area, return 2
2519 (try_cursor_movement): Check for the need to scroll more
2520 accurately, and prefer exact match for point under bidi.
2521 Don't advance `row' beyond the last row of the window.
2523 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2524 into disp_prop; all users changed.
2526 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2527 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2528 for the text covered by the display property.
2530 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2532 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2533 Change return value to nil.
2534 (Frecord_buffer): Delete unused function.
2536 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2538 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2539 buffers, return left-to-right.
2540 (set_cursor_from_row): Consider candidate row a win if its glyph
2541 represents a newline and point is on that newline. Fixes cursor
2542 positioning on the newline at EOL of R2L text within L2R
2543 paragraph, and vice versa.
2544 (try_cursor_movement): Check continued rows, in addition to
2545 continuation rows. Fixes unwarranted scroll when point enters a
2546 continued line of R2L text within an L2R paragraph, or vice versa.
2547 (cursor_row_p): Consider the case of point being equal to
2548 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2549 from the end of a short line to the beginning of a continued line
2550 of R2L text within L2R paragraph.
2551 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2552 composed characters.
2554 * bidi.c (bidi_check_type): Use xassert.
2555 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2558 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2560 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2563 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2565 * nsfont.m (ns_otf_to_script): Fix typo.
2567 2011-08-22 Kenichi Handa <handa@m17n.org>
2569 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2570 extra slot even if the purpose is char-code-property-table.
2572 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2574 * xdisp.c (redisplay_window): When computing centering_position,
2575 account for the height of the header line. (Bug#8874)
2577 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2578 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2579 candidate is selected by the mouse, and that candidate has a
2580 composed character under the mouse.
2582 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2583 coordinates reported by pos-visible-in-window-p for a composed
2584 character in column zero.
2586 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2588 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2590 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2592 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2593 consider it a hit if to_charpos is anywhere in the range of the
2594 composed buffer positions.
2596 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2598 * image.c (gif_load): Don't assume that each subimage has the same
2599 dimensions as the base image. Handle disposal method that is
2600 "undefined" by the gif spec (Bug#9335).
2602 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2604 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2605 (Fcondition_case): Document `debug' symbol in error handler.
2607 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2609 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2610 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2611 from an Org mode buffer to a Speedbar frame.
2613 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2614 a composition, take its buffer position from IT->cmp_it.charpos.
2615 Fixes cursor positioning at the beginning of a line that begins
2616 with a composed character.
2618 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2620 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2621 character bidirectional type, use STRONG_L instead. Fixes crashes
2622 in a buffer produced by `describe-categories'.
2624 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2625 members before the level stack, so they would be saved and
2626 restored when copying iterator state. Fixes incorrect reordering
2627 around TABs covered by display properties.
2629 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2631 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2633 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2635 * eval.c (internal_condition_case, internal_condition_case_1)
2636 (internal_condition_case_2, internal_condition_case_n):
2637 Remove unnecessary aborts (Bug#9081).
2639 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2641 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2642 has no `load' handler, try opening the file locally. (Bug#9311)
2644 2011-08-16 Ken Brown <kbrown@cornell.edu>
2646 * gmalloc.c: Expand comment.
2648 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2650 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2651 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2653 2011-08-16 Ken Brown <kbrown@cornell.edu>
2655 Fix memory allocation problems in Cygwin build (Bug#9273).
2657 * unexcw.c ( __malloc_initialized): Declare external variable.
2658 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2660 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2662 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2664 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2666 [CYGWIN] (special_realloc): New function.
2667 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2668 requests to realloc storage in the static heap.
2670 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2672 * bidi.c (bidi_initialize): Remove unused local.
2674 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2677 * biditype.h: Remove file.
2678 * makefile.w32-in ($(BLD)/bidi.$(O)):
2679 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2681 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2683 * chartab.c: Improve commentary for the uniprop_table API.
2685 * bidi.c (bidi_paragraph_init): Support zero value of
2686 bidi_ignore_explicit_marks_for_paragraph_level.
2687 (bidi_initialize): Use uniprop_table instead of including
2688 biditype.h and bidimirror.h.
2690 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2691 coordinates of the iterator when restoring from ppos_it.
2694 2011-08-14 Kenichi Handa <handa@m17n.org>
2696 * process.c (create_process): Call setup_process_coding_systems
2697 after the pid of the process is set to -1 (Bug#8162).
2699 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2701 * xdisp.c (move_it_in_display_line_to): Don't invoke
2702 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2703 ppos_it. Fixes vertical cursor motion when line beginning is
2704 covered by an image. (Bug#9296)
2706 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2708 * nsterm.h (ns_run_ascript): Declare.
2709 (NSAPP_DATA2_RUNASSCRIPT): Define.
2711 * nsfns.m (as_script, as_result, as_status): New static variables.
2712 (ns_run_ascript): New function.
2713 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2714 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2715 the event loop. Get status from as_status (Bug#7276).
2717 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2718 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2719 the event loop (Bug#7276).
2721 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2723 * gnutls.c (QCgnutls_bootprop_priority)
2724 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2725 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2726 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2727 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2728 (QCgnutls_bootprop_verify_hostname_error)
2729 (QCgnutls_bootprop_callbacks_verify): Rename from
2730 Qgnutls_bootprop_..., all uses changed.
2732 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2735 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2737 * xfaces.c (Qframe_set_background_mode): Now static.
2738 * dispextern.h (Qframe_set_background_mode): Remove decl.
2740 * process.c (Fnetwork_interface_info): Declare local only if needed.
2742 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2744 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2745 (Fnetwork_interface_list): Allocate in increments of bytes instead
2746 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2747 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2749 (struct ifflag_def): notrailers is smart on OSX.
2750 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2751 Get hardware address with getifaddrs if available.
2753 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2755 * xdisp.c (iterate_out_of_display_property): xassert that
2756 IT->position is set to within IT->object's boundaries. Break from
2757 the loop as soon as EOB is reached; avoids infloops in redisplay
2758 when IT->position is set up wrongly due to some bug.
2759 Set IT->current to match the bidi iterator unconditionally.
2760 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2761 entry. Force push_it to save on the stack the current
2762 buffer/string position, to be restored by pop_it. Fix flags in
2763 the iterator structure wrt the object coming from a display
2764 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2765 properties. (Bug#9284)
2767 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2769 * fontset.c (fontset_get_font_group): Add proper type checks.
2772 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2774 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2775 and LC_VERSION_MIN_MACOSX.
2776 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2777 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2779 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2781 * xdisp.c (forward_to_next_line_start): Allow to use the
2782 no-display-properties-and-no-overlays under bidi display.
2783 Set disp_pos in the bidi iterator to avoid searches for display
2784 properties and overlays.
2786 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2788 * editfns.c (Fset_time_zone_rule): Document relationship with the
2791 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2792 the font entity extracted from the cache (Bug#8109).
2794 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2796 * composite.c (autocmp_chars): Don't reset point. That is done by
2797 restore_point_unwind (Bug#5984).
2799 2011-08-07 Juri Linkov <juri@jurta.org>
2801 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2802 to show the arg `TIME' instead of `TIMEVAL'.
2804 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2806 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2807 display property strides EOL and includes a newline, as in
2808 longlines-mode. (Bug#9254)
2809 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2810 word-wrap under bidirectional display. (Bug#9224)
2812 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2813 is non-zero, even if the data buffer is NULL. Fixes a crash in
2814 vertical-motion with longlines-mode. (Bug#9254)
2816 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2818 * bidi.c <bidi_cache_total_alloc>: Now static.
2819 (bidi_initialize): Initialize bidi_cache_total_alloc.
2821 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2824 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2825 amount allocated this far in `bidi_cache_total_alloc'.
2826 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2827 non-zero, only free the data buffer without restoring the cache
2828 contents. All callers changed.
2830 * dispextern.h (bidi_unshelve_cache): Update prototype.
2832 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2833 (move_it_in_display_line, move_it_to)
2834 (move_it_vertically_backward, move_it_by_lines): Replace the call
2835 to xfree to an equivalent call to bidi_unshelve_cache.
2836 (move_it_in_display_line_to): Fix logic of returning
2837 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2839 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2841 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2842 came from a string character with a `cursor' property. (Bug#9229)
2844 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2846 * Makefile.in (LIB_PTHREAD): New variable.
2847 (LIBES): Add LIB_PTHREAD (Bug#9216).
2849 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2850 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2852 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2854 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2856 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2858 * xterm.c (x_find_topmost_parent): New function.
2859 (x_set_frame_alpha): Find topmost parent window with
2860 x_find_topmost_parent and set the property there also (bug#9181).
2861 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2863 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2865 * callproc.c (Fcall_process): Avoid vfork clobbering
2866 the local vars buffer, coding_systems, current_dir.
2868 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2870 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2872 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2874 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2875 so that it is not optimized away.
2877 * xdisp.c (compute_display_string_pos): Remove unused local.
2879 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2881 Fix slow cursor motion and scrolling in large buffers with
2882 selective display, like Org Mode buffers. (Bug#9218)
2884 * dispextern.h (struct bidi_it): New member disp_prop_p.
2886 * xdisp.c: Remove one-slot cache of display string positions.
2887 (compute_display_string_pos): Accept an additional argument
2888 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2889 for a display string or property. If found, set DISP_PROP_P
2892 * bidi.c (bidi_fetch_char): Accept an additional argument
2893 DISP_PROP_P, and pass it to compute_display_string_pos.
2894 Only handle text covered by a display string if DISP_PROP_P is returned
2895 non-zero. All callers of bidi_fetch_char changed.
2897 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2899 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2901 2010-12-03 Don March <don@ohspite.net>
2903 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2904 last character M-[char] is translated to ESC [char] (bug#7541).
2906 2011-08-02 Kenichi Handa <handa@m17n.org>
2908 * lisp.h (uniprop_table): Extern it.
2910 * chartab.c (uniprop_table): Make it non-static.
2912 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2914 * xdisp.c (forward_to_next_line_start): Accept additional argument
2915 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2917 (reseat_at_next_visible_line_start): Use the bidi iterator state
2918 returned by forward_to_next_line_start to restore the state of
2919 it->bidi_it after backing up to previous newline. (Bug#9212)
2921 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2923 * regex.c (re_comp): Protoize.
2924 (re_exec): Fix return type.
2925 (regexec): Fix type of `ret'. (Bug#9203)
2927 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2929 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2930 This is needed if max-image-size is a floating-point number.
2932 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2934 * print.c (print_object): Print empty symbol as ##.
2936 * lread.c (read1): Read ## as empty symbol.
2938 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2940 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2941 setting frame foreground color (Bug#9175).
2942 (x_set_background_color): Likewise.
2944 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2945 contents (Bug#9176).
2946 (EmacsTooltip -init): Remove bezels and add shadows to
2949 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2950 or scroll bar (Bug#8470).
2952 * nsfont.m (nsfont_open): Remove assignment to voffset and
2953 unnecessary vars hshink, expand, hd, full_height, min_height.
2954 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2956 * nsterm.h (nsfont_info): Remove voffset field.
2958 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2960 Implement strike-through and overline on NextStep (Bug#8863).
2962 * nsfont.m (nsfont_open): Use underline position provided by font,
2963 instead of hard-coded value of 2.
2964 (nsfont_draw): Call ns_draw_text_decoration instead.
2966 * nsterm.h: Add declaration for ns_draw_text_decoration.
2968 * nsterm.m (ns_draw_text_decoration): New function for drawing
2969 underline, overline, and strike-through.
2970 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2971 ns_draw_text_decoration. Change treatment of cursor drawing to
2972 accommodate underlining, etc.
2974 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2976 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2979 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2981 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2982 Without this fix, if a signal arrives just after memory fills up,
2983 'malloc' might be invoked reentrantly.
2985 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2986 In other words, assume that every image size is allowed, on non-X
2987 hosts. This assumption is probably wrong, but it lets Emacs compile.
2989 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2991 * regex.c (re_iswctype): Convert return values to boolean.
2993 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2995 * xdisp.c (compute_display_string_pos): Don't use cached display
2996 string position if the buffer had its restriction changed.
2999 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3001 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3003 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3005 Integer signedness and overflow and related fixes. (Bug#9079)
3007 * bidi.c: Integer size and overflow fixes.
3008 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3009 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3010 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3011 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3012 (bidi_find_other_level_edge):
3013 Use ptrdiff_t instead of EMACS_INT where either will do.
3014 This works better on 32-bit hosts configured --with-wide-int.
3015 (bidi_cache_ensure_space): Check for size-calculation overflow.
3016 Use % rather than repeated addition, for better worst-case speed.
3017 Don't set bidi_cache_size until after xrealloc returns, because it
3019 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3020 (bidi_cache_ensure_space): Also check that the bidi cache size
3021 does not exceed that of the largest Lisp string or buffer. See Eli
3022 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3024 * alloc.c (__malloc_size_t): Remove.
3025 All uses replaced by size_t. See Andreas Schwab's note
3026 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3028 * image.c: Improve checking for integer overflow.
3029 (check_image_size): Assume that f is nonnull, since
3030 it is always nonnull in practice. This is one less thing to
3031 worry about when checking for integer overflow later.
3032 (x_check_image_size): New function, which checks for integer
3033 overflow issues inside X.
3034 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3035 This removes the need for a memory_full check.
3036 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3037 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3038 (xbm_read_bitmap_data): Change locals back to 'int', since
3039 their values must fit in 'int'.
3040 (xpm_load_image, png_load, tiff_load):
3041 Invoke x_create_x_image_and_pixmap earlier,
3042 to avoid much needless work if the image is too large.
3043 (tiff_load): Treat overly large images as if
3044 x_create_x_image_and_pixmap failed, not as malloc failures.
3045 (gs_load): Use x_check_image_size.
3047 * gtkutil.c: Omit integer casts.
3048 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3049 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3051 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3053 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3054 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3055 would wrongly return t on a 64-bit host.
3057 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3058 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3059 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3060 and therefore cause GCC to emit a bogus diagnostic in some cases.
3062 * image.c: Integer signedness and overflow and related fixes.
3063 This is not an exhaustive set of fixes, but it's time to
3064 record what I've got.
3065 (lookup_pixel_color, check_image_size): Remove redundant decls.
3066 (check_image_size): Don't assume that arbitrary EMACS_INT values
3067 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3068 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3069 (tiff_load, imagemagick_load_image):
3070 Check for overflow in size calculations.
3071 (x_create_x_image_and_pixmap): Remove unnecessary test for
3072 xmalloc returning NULL; that can't happen.
3073 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3074 (xpm_color_bucket): Use better integer hashing function.
3075 (xpm_cache_color): Don't possibly over-allocate memory.
3076 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3077 (gif_memory_source):
3078 Use ptrdiff_t, not int or size_t, to record sizes.
3079 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3080 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3081 either works, as we prefer signed integers.
3082 (tiff_read_from_memory, tiff_write_from_memory):
3083 Return tsize_t, not size_t, since that's what the TIFF API wants.
3084 (tiff_read_from_memory): Don't fail simply because the read would
3085 go past EOF; instead, return a short read.
3086 (tiff_load): Omit no-longer-needed casts.
3087 (Fimagemagick_types): Don't assume size fits into 'int'.
3089 Improve hashing quality when configured --with-wide-int.
3090 * fns.c (hash_string): New function, taken from sxhash_string.
3091 Do not discard information about ASCII character case; this
3092 discarding is no longer needed.
3093 (sxhash-string): Use it. Change sig to match it. Caller changed.
3094 * lisp.h: Declare it.
3095 * lread.c (hash_string): Remove, since we now use fns.c's version.
3096 The fns.c version returns a wider integer if --with-wide-int is
3097 specified, so this should help the quality of the hashing a bit.
3099 * emacs.c: Integer overflow minor fix.
3100 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3101 Define only if GNU_LINUX.
3102 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3104 * dispnew.c: Integer signedness and overflow fixes.
3105 Remove unnecessary forward decls, that were a maintenance hassle.
3106 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3108 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3109 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3110 (prepare_desired_row, line_draw_cost):
3111 Use int, not unsigned, where either works.
3112 (save_current_matrix, restore_current_matrix):
3113 Use ptrdiff_t, not size_t, where either works.
3114 (init_display): Check for overflow more accurately, and without
3115 relying on undefined behavior.
3117 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3118 Remove, replacing with the new symbols in lisp.h. All uses changed.
3119 * fileio.c (make_temp_name):
3120 * filelock.c (lock_file_1, lock_file):
3121 * xdisp.c (message_dolog):
3122 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3123 Use pMd etc. instead.
3124 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3125 replacing the pWIDE etc. symbols removed from editfns.c.
3127 * keyboard.h (num_input_events): Now uintmax_t.
3128 This is (very slightly) less likely to mess up due to wraparound.
3131 * buffer.c: Integer signedness fixes.
3132 (alloc_buffer_text, enlarge_buffer_text):
3133 Use ptrdiff_t rather than size_t when either will do, as we prefer
3136 * alloc.c: Integer signedness and overflow fixes.
3137 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3138 (__malloc_size_t): Default to size_t, not to int.
3139 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3140 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3141 Prefer ptrdiff_t to size_t when either would do, as we prefer
3143 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3144 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3145 Now const. Initialize with values that are in range even if char
3147 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3148 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3149 These functions do the right thing with sizes > 2**32.
3150 (check_depth): Now ptrdiff_t, not int.
3151 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3152 Adjust to new way of storing sizes. Check for size overflow bugs
3154 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3155 slightly wrong anyway, as it missed one instance of
3156 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3157 (refill_memory_reserve): Omit needless cast to size_t.
3158 (mark_object_loop_halt): Mark as externally visible.
3160 * xselect.c: Integer signedness and overflow fixes.
3161 (Fx_register_dnd_atom, x_handle_dnd_message):
3162 Use ptrdiff_t, not size_t, since we prefer signed.
3163 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3164 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3165 x_dnd_atoms_size and x_dnd_atoms_length.
3167 * doprnt.c: Prefer signed to unsigned when either works.
3169 * doprnt.c (doprnt):
3171 * xdisp.c (vmessage):
3172 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3173 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3174 prefer signed arithmetic to avoid comparison confusion.
3175 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3176 but is a bit tricky.
3178 Assume freestanding C89 headers, string.h, stdlib.h.
3179 * data.c, doprnt.c, floatfns.c, print.c:
3180 Include float.h unconditionally.
3181 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3182 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3183 * regex.c: Likewise for stddef.h, string.h.
3184 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3185 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3186 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3187 (STDC_HEADERS): Remove obsolete defines.
3188 * sysdep.c: Include limits.h unconditionally.
3190 Assume support for memcmp, memcpy, memmove, memset.
3191 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3192 * regex.c (memcmp, memcpy):
3193 Remove; we assume C89 now.
3195 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3196 (__malloc_safe_bcopy): Remove; no longer needed.
3198 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3199 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3200 well either way, and we prefer signed to unsigned.
3202 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3204 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3205 closes the connection while we're reading (bug#9182).
3207 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3209 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3210 are specified (Bug#9168).
3212 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3214 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3215 Found by GCC static checking and --with-wide-int on a 32-bit host.
3217 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3219 * xdisp.c (compute_display_string_pos): Fix logic of caching
3220 previous display string position. Initialize cached_prev_pos to
3221 -1. Fixes slow-down at the beginning of a buffer.
3223 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3225 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3226 for attrs[LFACE_FONTSET_INDEX].
3228 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3230 * xml.c (parse_region): Remove unused local
3231 that was recently introduced.
3233 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3235 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3236 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3238 * xdisp.c (move_it_in_display_line_to): Record the best matching
3239 position for TO_CHARPOS while scanning the line, and restore it on
3240 exit if none of the characters scanned was an exact match.
3241 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3242 when exact match is impossible due to invisible text, and the
3243 lines are truncated.
3245 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3247 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3250 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3252 Fix a significant slow-down of cursor motion with C-n, C-p,
3253 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3254 auto-repeat under bidi redisplay in fontified buffers.
3255 * xdisp.c (compute_stop_pos_backwards): New function.
3256 (next_element_from_buffer): Call compute_stop_pos_backwards to
3257 find a suitable prev_stop when we find ourselves before
3259 (reseat): Don't look for prev_stop, as that could mean a very long
3261 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3262 <cached_disp_overlay_modiff>: Cache for last found display string
3264 (compute_display_string_pos): Return the cached position if asked
3265 about the same buffer in the same area of character positions, and
3266 the buffer wasn't changed since the time the display string
3267 position was cached.
3269 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3271 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3272 is an integer, which is important for empty lines. (Bug#9149)
3274 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3276 * frame.c (Fmodify_frame_parameters): In tty case, update the
3277 default face if necessary (Bug#4238).
3279 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3281 * editfns.c (Fstring_to_char): No need to explain what a character
3282 is in the docstring (Bug#6576).
3284 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3286 * xml.c (parse_region): Make sure we always return a tree.
3288 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3290 * xml.c (parse_region): If a document contains only comments,
3293 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3295 * xml.c (make_dom): Return comments, too.
3297 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3300 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3301 and the surrounding thread.
3302 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3303 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3304 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3306 * s/openbsd.h (BROKEN_SIGIO): Define.
3307 * unexelf.c (unexec) [__OpenBSD__]:
3308 Don't update the .mdebug section of the Alpha COFF symbol table.
3310 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3312 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3315 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3317 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3318 This fixes some race conditions on the permissions of any newly
3321 * alloc.c (valid_pointer_p): Use pipe, not open.
3322 This fixes some permissions issues when debugging.
3324 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3325 If fchown fails to set both uid and gid, try to set just gid,
3326 as that is sometimes allowed. Adjust the file's mode to eliminate
3327 setuid or setgid bits that are inappropriate if fchown fails.
3329 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3331 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3332 to compare Lisp_Objects.
3333 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3334 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3335 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3337 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3339 * lread.c (read_integer): Unread even EOF character.
3340 (read1): Likewise. Properly record start position of symbol.
3342 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3343 symbol character follows.
3345 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3347 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3348 This works around a problem with the previous change to Fcopy_file.
3349 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3350 and without this change, GCC might complain about discarding
3351 fchown's return value.
3353 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3355 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3357 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3359 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3361 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3363 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3364 it's used from the C level.
3366 * process.c: Use the same condition for POLL_FOR_INPUT in both
3367 keyboard.c and process.c (bug#1858).
3369 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3371 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3372 (Fgnutls_boot): Use it.
3374 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3376 * doc.c (Fsubstitute_command_keys): Revert last change.
3378 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3380 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3381 quotes the next character, and doesn't affect other longer
3382 sequences (bug#8935).
3384 * lread.c (syms_of_lread): Clarify that is isn't only
3385 `eval-buffer' and `eval-defun' that's affected by
3386 `lexical-binding' (bug#8460).
3388 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3390 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3391 bidi redisplay when a line includes both an image and is truncated.
3393 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3395 Fix minor problems found by static checking.
3396 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3397 (elsz): Now a signed constant, not a size_t var. We prefer signed
3398 types to unsigned, to avoid integer comparison confusion. Without
3399 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3400 "cannot optimize loop, the loop counter may overflow", a symptom
3402 * indent.c (Fvertical_motion): Mark locals as initialized.
3403 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3405 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3407 * search.c (Fre_search_backward): Mention `case-fold-search' in
3408 all the re_search_* functions (bug#8138).
3410 * keyboard.c (Fopen_dribble_file): Document when the file is
3413 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3415 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3418 Support bidi reordering of display and overlay strings.
3419 * xdisp.c (compute_display_string_pos)
3420 (compute_display_string_end): Accept additional argument STRING.
3421 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3422 (reseat_to_string): Initialize bidi_it->string.s and
3423 bidi_it->string.schars.
3424 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3425 NULL (avoids a crash in bidi_paragraph_init).
3426 Initialize itb.string.lstring.
3427 (init_iterator): Call bidi_init_it only of a valid
3428 buffer position was specified. Initialize paragraph_embedding to
3430 (reseat_to_string): Initialize the bidi iterator.
3431 (display_string): If we need to ignore text properties of
3432 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3433 original value of -1 will not work with bidi.)
3434 (compute_display_string_pos): First arg is now struct
3435 `text_pos *'; all callers changed. Support display properties on
3437 (compute_display_string_end): Support display properties on Lisp
3439 (init_iterator, reseat_1, reseat_to_string): Initialize the
3440 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3441 when iterating on a string not from display properties).
3442 (compute_display_string_pos, compute_display_string_end):
3443 Fix calculation of the object to scan. Fixes an error when using
3445 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3446 base_level_stop; instead, set base_level_stop to BEGV.
3447 Fixes crashes in vertical-motion.
3448 (next_element_from_buffer): Improve commentary for when
3449 the iterator is before prev_stop.
3450 (init_iterator): Initialize bidi_p from the default value of
3451 bidi-display-reordering, not from buffer-local value. Use the
3452 buffer-local value only if initializing for buffer iteration.
3453 (handle_invisible_prop): Support invisible properties on strings
3454 that are being bidi-reordered.
3455 (set_iterator_to_next): Support bidi reordering of C strings and
3457 (next_element_from_string): Support bidi reordering of Lisp
3459 (handle_stop_backwards): Support Lisp strings as well.
3460 (display_string): Support display of R2L glyph rows.
3461 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3462 (init_iterator): Don't initialize it->bidi_p for strings
3464 (reseat_to_string): Initialize it->bidi_p for strings here.
3465 (next_element_from_string, next_element_from_c_string)
3466 (next_element_from_buffer): Add xassert's for correspondence
3467 between IT's object being iterated and it->bidi_it.string
3469 (face_before_or_after_it_pos): Support bidi iteration.
3470 (next_element_from_c_string): Handle the case of the first string
3471 character that is not the first one in the visual order.
3472 (get_visually_first_element): New function, refactored from common
3473 parts of next_element_from_buffer, next_element_from_string, and
3474 next_element_from_c_string.
3475 (tool_bar_lines_needed, redisplay_tool_bar)
3476 (display_menu_bar): Force left-to-right direction. Add a FIXME
3477 comment for making that be controlled by a user option.
3478 (push_it, pop_it): Save and restore the state of the
3479 bidi iterator. Save and restore the bidi_p flag.
3480 (pop_it): Iterate out of display property for string iteration as
3482 (iterate_out_of_display_property): Support iteration over strings.
3483 (handle_single_display_spec): Set up it->bidi_it for iteration
3484 over a display string, and call bidi_init_it.
3485 (handle_single_display_spec, next_overlay_string)
3486 (get_overlay_strings_1, push_display_prop): Set up the bidi
3487 iterator for displaying display or overlay strings.
3488 (forward_to_next_line_start): Don't use the shortcut if
3490 (back_to_previous_visible_line_start): If handle_display_prop
3491 pushed the iterator stack, restore the internal state of the bidi
3492 iterator by calling bidi_pop_it same number of times.
3493 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3494 and we are bidi-iterating, don't decrement the iterator position;
3495 instead, set the first_elt flag in the bidi iterator, to produce
3497 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3498 (push_display_prop): xassert that we are iterating a buffer.
3499 (push_it, pop_it): Save and restore paragraph_embedding member.
3500 (handle_single_display_spec, next_overlay_string)
3501 (get_overlay_strings_1, reseat_1, reseat_to_string)
3502 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3503 correctly. Don't assume unibyte strings are not bidi-reordered.
3504 (compute_display_string_pos)
3505 (compute_display_string_end): Fix handling the case of C string.
3506 (push_it, pop_it): Save and restore from_disp_prop_p.
3507 (handle_single_display_spec, push_display_prop): Set the
3508 from_disp_prop_p flag.
3509 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3510 (pop_it): Call iterate_out_of_display_property only if we are
3511 popping after iteration over a string that came from a display
3512 property. Fix a typo in popping stretch info. Add an assertion
3513 for verifying that the iterator position is in sync with the bidi
3515 (handle_single_display_spec, get_overlay_strings_1)
3516 (push_display_prop): Fix initialization of paragraph direction for
3517 string when that of the parent object is not yet determined.
3518 (reseat_1): Call bidi_init_it to resync the bidi
3519 iterator with IT's position. (Bug#7616)
3520 (find_row_edges): If ROW->start.pos gives position
3521 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3522 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3523 Reset the from_disp_prop_p flag.
3524 (SAVE_IT, RESTORE_IT): New macros.
3525 (pos_visible_p, face_before_or_after_it_pos)
3526 (back_to_previous_visible_line_start)
3527 (move_it_in_display_line_to, move_it_in_display_line)
3528 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3529 (try_scrolling, redisplay_window, display_line): Use them when
3530 saving a temporary copy of the iterator and restoring it back.
3531 (back_to_previous_visible_line_start, reseat_1)
3532 (init_iterator): Empty the bidi cache "stack".
3533 (move_it_in_display_line_to): If iterator ended up at
3534 EOL, but we never saw any buffer positions smaller than
3535 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3536 motion in bidi-reordered lines.
3537 (move_it_in_display_line_to): Record prev_method and prev_pos
3538 immediately before the call to set_iterator_to_next. Fixes cursor
3539 motion in bidi-reordered lines with stretch glyphs and strings
3540 displayed in margins. (Bug#8133) (Bug#8867)
3541 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3543 (pos_visible_p): Support positions in bidi-reordered lines.
3544 Save and restore bidi cache.
3546 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3547 (bidi_paragraph_info): Delete unused struct.
3548 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3549 (bidi_cache_start): New variable.
3550 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3552 (bidi_cache_fetch_state, bidi_cache_search)
3553 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3554 (bidi_cache_find, bidi_peek_at_next_level)
3555 (bidi_level_of_next_char, bidi_find_other_level_edge)
3556 (bidi_move_to_visually_next): Compare cache index with
3557 bidi_cache_start rather than with zero.
3558 (bidi_fetch_char): Accept new argument STRING; all callers
3559 changed. Support iteration over a string. Support strings with
3560 display properties. Support unibyte strings. Fix the type of
3561 `len' according to what STRING_CHAR_AND_LENGTH expects.
3562 (bidi_paragraph_init, bidi_resolve_explicit_1)
3563 (bidi_resolve_explicit, bidi_resolve_weak)
3564 (bidi_level_of_next_char, bidi_move_to_visually_next):
3565 Support iteration over a string.
3566 (bidi_set_sor_type, bidi_resolve_explicit_1)
3567 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3568 can now be zero (for strings); special values 0 and -1 were
3569 changed to -1 and -2, respectively.
3570 (bidi_char_at_pos): New function.
3571 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3572 Call it instead of FETCH_MULTIBYTE_CHAR.
3573 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3574 initialized to valid values.
3575 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3577 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3578 the test for valid cached positions. Fix the logic for looking up
3579 the sentinel state in the cache. GCPRO the Lisp string we are
3581 (bidi_push_it, bidi_pop_it): New functions.
3582 (bidi_initialize): Initialize the bidi cache start stack pointer.
3583 (bidi_cache_ensure_space): New function, refactored from part of
3584 bidi_cache_iterator_state. Don't assume the required size is just
3585 one BIDI_CACHE_CHUNK away.
3586 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3587 (bidi_count_bytes, bidi_char_at_pos): New functions.
3588 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3589 always valid if bidi_cache_idx is valid.
3590 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3591 is valid if it's going to be used.
3592 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3593 (bidi_cache_fetch_state, bidi_cache_search)
3594 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3595 (bidi_cache_iterator_state, bidi_cache_find)
3596 (bidi_find_other_level_edge, bidi_cache_start_stack):
3597 All variables related to cache indices are now EMACS_INT.
3599 * dispextern.h (struct bidi_string_data): New structure.
3600 (struct bidi_it): New member `string'. Make flag members be 1-bit
3601 fields, and put them last in the struct.
3602 (compute_display_string_pos, compute_display_string_end):
3604 (bidi_push_it, bidi_pop_it): Add prototypes.
3605 (struct iterator_stack_entry): New members bidi_p,
3606 paragraph_embedding, and from_disp_prop_p.
3607 (struct it): Member bidi_p is now a bit field 1 bit wide.
3608 (bidi_shelve_cache, bidi_unshelve_cache):
3611 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3612 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3613 and vector-like objects.
3615 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3616 cache around display iteration.
3618 * window.c (Fwindow_end, window_scroll_pixel_based)
3619 (displayed_window_lines, Frecenter): Save and restore the bidi
3620 cache around display iteration.
3622 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3624 * editfns.c (Fdelete_region): Clarify the use of the named
3625 parameters (bug#6788).
3627 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3629 * indent.c (Fvertical_motion): Set and restore w->pointm when
3630 saving and restoring the window's buffer (Bug#9006).
3632 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3634 * editfns.c (Fstring_to_char): Clarify just what is returned
3635 (bug#6576). Text by Eli Zaretskii.
3637 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3639 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3641 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3643 * buffer.c (mmap_find): Fix a typo.
3645 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3647 Fix execution of x selection hooks.
3648 * xselect.c (Qx_lost_selection_functions)
3649 (Qx_sent_selection_functions): New vars.
3650 (syms_of_xselect): DEFSYM them.
3651 (x_handle_selection_request): Pass Qx_sent_selection_functions
3652 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3653 (x_handle_selection_clear,x_clear_frame_selections):
3654 Pass Qx_lost_selection_functions rather than
3655 Vx_lost_selection_functions to Frun_hook_with_args.
3657 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3659 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3660 The old code sometimes used this field without initializing it.
3662 * alloc.c (gc_sweep): Don't read past end of array.
3663 In theory, the old code could also have corrupted Emacs internals,
3664 though it'd be very unlikely.
3666 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3668 * character.c (Fcharacterp): Don't advertise optional ignored
3669 argument. (Bug#4026)
3671 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3673 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3676 * window.c (Fset_window_start): Doc fix (bug#4199).
3677 (Fset_window_hscroll): Ditto.
3679 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3681 Fix minor new problems caught by GCC 4.6.1.
3682 * term.c (init_tty): Remove unused local.
3683 * xsettings.c (store_monospaced_changed): Define this function only
3684 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3687 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3689 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3691 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3693 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3694 are the mini-buffer and the echo area (bug#3320).
3696 * term.c (init_tty): Remove support for supdup, c10 and perq
3697 terminals, which are no longer supported (bug#1482).
3699 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3701 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3703 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3705 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3706 for non-popups (Bug#3642).
3708 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3710 * alloc.c (reset_malloc_hooks): Protoize.
3711 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3712 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3713 * cm.c (losecursor): Likewise.
3714 * data.c (fmod): Likewise.
3715 * dispnew.c (swap_glyphs_in_rows): Likewise.
3716 * emacs.c (memory_warning_signal): Likewise.
3717 * floatfns.c (float_error): Likewise.
3718 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3719 (otf_open, font_otf_capability, generate_otf_features)
3720 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3722 * image.c (pbm_read_file): Likewise.
3723 * indent.c (string_display_width): Likewise.
3724 * intervals.c (check_for_interval, search_for_interval)
3725 (inc_interval_count, count_intervals, root_interval)
3726 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3727 * lread.c (defalias): Likewise.
3728 * ralloc.c (r_alloc_check): Likewise.
3729 * regex.c (set_image_of_range_1, set_image_of_range)
3730 (regex_grow_registers): Likewise.
3731 * sysdep.c (strerror): Likewise.
3732 * termcap.c (valid_filename_p, tprint, main): Likewise.
3733 * tparam.c (main): Likewise.
3734 * unexhp9k800.c (run_time_remap, save_data_space)
3735 (update_file_ptrs, read_header, write_header, calculate_checksum)
3736 (copy_file, copy_rest, display_header): Likewise.
3737 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3739 * xdisp.c (check_it): Likewise.
3740 * xfaces.c (register_color, unregister_color, unregister_colors):
3742 * xfns.c (print_fontset_result): Likewise.
3743 * xrdb.c (member, fatal, main): Likewise.
3745 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3747 Fix minor problems found by static checking (Bug#9031).
3748 * chartab.c (char_table_set_range, map_sub_char_table):
3749 Remove unused locals.
3750 (uniprop_table): Now static.
3751 * composite.c (_work_char): Remove unused static var.
3753 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3755 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3757 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3759 * gtkutil.c (qttip_cb): Remove code without function.
3761 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3763 * w32.c (pthread_sigmask): New stub.
3765 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3767 Use pthread_sigmask, not sigprocmask (Bug#9010).
3768 sigprocmask is portable only for single-threaded applications, and
3769 Emacs can be multi-threaded when it uses GTK.
3770 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3772 * callproc.c (Fcall_process):
3773 * process.c (create_process):
3774 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3775 Use pthread_sigmask, not sigprocmask.
3777 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3779 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3780 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3783 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3785 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3786 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3787 (xg_hide_tooltip): Fix comment.
3789 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3790 in registerServicesMenuSendTypes.
3791 (validRequestorForSendType): Don't check ns_return_types.
3793 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3796 2011-07-08 Jason Rumney <jasonr@gnu.org>
3798 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3799 SH_SHOW for hidden windows (Bug#5482).
3801 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3802 frame struct members of non-existent frames (Bug#6284).
3804 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3806 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3807 variable firstTime not needed on OSX >= 10.6.
3808 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3809 >= 10.5. Use setKnobProportion, setDoubleValue.
3811 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3812 (MAC_OS_X_VERSION_10_5): Define if not defined.
3813 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3814 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3815 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3817 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3818 cString and lossyCString on OSX >= 10.4
3820 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3821 sizeToFit on OSX >= 10.2.
3823 * nsimage.m (allocInitFromFile): Don't use deprecated method
3824 bestRepresentationForDevice on OSX >= 10.6.
3826 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3829 * emacs.c: Declare unexec_init_emacs_zone.
3831 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3833 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3835 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3836 on svcsMenu (Bug#8842).
3838 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3840 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3842 * nsterm.m (QUTF8_STRING): Declare.
3843 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3844 (validRequestorForSendType): Return type is (id).
3845 Change indexOfObjectIdenticalTo to indexOfObject.
3846 Check if we have local selection before returning self (Bug#8842).
3847 (writeSelectionToPasteboard): Put local selection into paste board
3848 if we have a local selection (Bug#8842).
3849 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3851 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3852 (ns_get_local_selection): Declare.
3854 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3856 * keymap.c (describe_map_tree): Don't insert a double newline at
3857 the end of the buffer (bug#1169) and return whether we inserted
3860 * callint.c (Fcall_interactively): Change "reading args" to
3861 "providing args" to try to clarify what it does (bug#1010).
3863 2011-07-07 Kenichi Handa <handa@m17n.org>
3865 * composite.c (composition_compute_stop_pos): Ignore a static
3866 composition starting before CHARPOS (Bug#8915).
3868 * xdisp.c (handle_composition_prop): Likewise.
3870 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3872 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3875 2011-07-07 Kenichi Handa <handa@m17n.org>
3877 * character.h (unicode_category_t): New enum type.
3879 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3880 (Qchar_code_property_table): New variable.
3881 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3882 (UNIPROP_COMPRESSED_FORM_P): New macros.
3883 (char_table_ascii): Uncompress the compressed values.
3884 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3885 Uncompress the compressed values.
3886 (sub_char_table_ref_and_range): Likewise.
3887 (char_table_ref_and_range): Uncompress the compressed values.
3888 (sub_char_table_set): New arg is_uniprop. Callers changed.
3889 Uncompress the compressed values.
3890 (sub_char_table_set_range): Args changed. Callers changed.
3891 (char_table_set_range): Adjuted for the above change.
3892 (map_sub_char_table): Delete args default_val and parent. Add arg
3893 top. Give decoded values to a Lisp function.
3894 (map_char_table): Adjust for the above change. Give decoded
3895 values to a Lisp function. Gcpro more variables.
3896 (uniprop_table_uncompress)
3897 (uniprop_decode_value_run_length): New functions.
3898 (uniprop_decoder, uniprop_decoder_count): New variables.
3899 (uniprop_get_decoder, uniprop_encode_value_character)
3900 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3902 (uniprop_encoder, uniprop_encoder_count): New variables.
3903 (uniprop_get_encoder, uniprop_table)
3904 (Funicode_property_table_internal, Fget_unicode_property_internal)
3905 (Fput_unicode_property_internal): New functions.
3906 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3907 Sunicode_property_table_internal, Sget_unicode_property_internal,
3908 and Sput_unicode_property_internal. Defvar_lisp
3909 char-code-property-alist.
3911 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3912 Vunicode_category_table.
3914 * font.c (font_range): Adjust for the change of
3915 Vunicode_category_table.
3917 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3919 * m/iris4d.h: Remove file, move contents ...
3920 * s/irix6-5.h: ... here.
3922 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3924 Remove unportable assumption about struct layout (Bug#8884).
3925 * alloc.c (mark_buffer):
3926 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3927 (clone_per_buffer_values): Don't assume that
3928 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3929 This isn't true in general, and it's particularly not true
3930 if Emacs is configured with --with-wide-int.
3931 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3932 New macros, used in the buffer.c change.
3934 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3936 * xsettings.c: Use both GConf and GSettings if both are available.
3937 (store_config_changed_event): Add comment.
3938 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3939 (store_tool_bar_style_changed): New functions.
3940 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3941 (struct xsettings): Move font inside HAVE_XFT.
3942 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3943 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3944 Move inside HAVE_XFT.
3945 (something_changed_gsettingsCB): Rename from something_changedCB.
3946 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3948 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3949 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3950 (something_changed_gconfCB): Rename from something_changedCB.
3951 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3952 (parse_settings): Move check for font inside HAVE_XFT.
3953 (read_settings, apply_xft_settings): Add comment.
3954 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3955 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3956 call store_font_name_changed.
3957 (xft_settings_event): Add comment.
3958 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3959 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3960 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3961 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3962 (xsettings_initialize): Call init_gsettings last.
3963 (xsettings_get_system_font, xsettings_get_system_normal_font):
3966 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3968 Random fixes. E.g., (random) never returned negative values.
3969 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3970 subseconds part to the entropy, as that's a bit more random.
3971 Prefer signed to unsigned, since the signedness doesn't matter and
3972 in general we prefer signed. When given a limit, use a
3973 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3974 latter isn't right if USE_2_TAGS_FOR_INTS.
3975 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3976 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3978 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3980 * textprop.c (text_property_stickiness):
3981 Obey Vtext_property_default_nonsticky.
3982 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3983 * w32fns.c (syms_of_w32fns):
3984 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3986 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3988 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3989 This is more efficient than Ffile_directory_p and avoids a minor race.
3991 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3993 * buffer.c (Foverlay_put): Say what the return value is
3996 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3997 is a directory before asking whether to use the file name
3999 (barf_or_query_if_file_exists): Make the "File is a directory"
4000 error be more correct.
4002 * fns.c (Frequire): Remove the mention of the .gz files, since
4003 that's installation-specific, but keep the mention of
4004 `get-load-suffixes'.
4006 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4008 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4009 Report string overflow if the output is too long.
4011 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4013 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4014 (syms_of_gnutls): Remove duplicate DEFSYM for
4015 Qgnutls_bootprop_verify_hostname_error, an error for
4016 Qgnutls_bootprop_verify_error (which is no longer used).
4018 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4019 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4020 Also (re)move comments that are misplaced or no longer relevant.
4022 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4024 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4026 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4028 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4029 and background color parameters if they have been changed.
4031 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4033 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4035 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4037 * xsettings.c (SYSTEM_FONT): Define only when used.
4038 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4040 * keymap.c (access_keymap_1): Now static.
4042 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4044 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4045 leave any prefix arg for the up event (Bug#1586).
4047 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4049 * lread.c (syms_of_lread): Mention single symbols defined by
4050 `defvar' or `defconst' (bug#7154).
4052 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4053 (Frequire): Mention get-load-suffixes.
4055 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4057 * window.h (window): Remove clone_number slot.
4058 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4060 (make_parent_window, make_window, saved_window)
4061 (Fset_window_configuration, save_window_save): Don't deal with
4063 * buffer.c (Qclone_number): Remove declaration.
4064 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4066 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4068 Add multiple inheritance to keymaps.
4069 * keymap.c (Fmake_composed_keymap): New function.
4070 (Fset_keymap_parent): Simplify.
4071 (fix_submap_inheritance): Remove.
4072 (access_keymap_1): New function extracted from access_keymap to handle
4073 embedded parents and handle lists of maps.
4074 (access_keymap): Use it.
4075 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4076 (Fcopy_keymap): Handle embedded parents.
4077 (Fcommand_remapping, define_as_prefix): Simplify.
4078 (Fkey_binding): Simplify.
4079 (syms_of_keymap): Move minibuffer-local-completion-map,
4080 minibuffer-local-filename-completion-map,
4081 minibuffer-local-must-match-map, and
4082 minibuffer-local-filename-must-match-map to Elisp.
4083 (syms_of_keymap): Defsubr make-composed-keymap.
4084 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4085 (parse_menu_item): Trivial simplification.
4087 2011-07-01 Glenn Morris <rgm@gnu.org>
4089 * Makefile.in (SETTINGS_LIBS): Fix typo.
4091 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4093 * coding.c (Fencode_coding_string): Record the last coding system
4094 used, as the function doc string says (bug#8738).
4096 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4098 * xsettings.c (store_monospaced_changed): Take new font as arg and
4099 check for change against current_mono_font.
4100 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4101 (emacs_settings_constructor, emacs_settings_get_property)
4102 (emacs_settings_set_property, emacs_settings_class_init)
4103 (emacs_settings_init, gsettings_obj): Remove.
4104 (something_changedCB): New function for HAVE_GSETTINGS.
4105 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4106 with value as argument.
4107 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4108 g_settings_new (Bug#8967). Do not create gsettings_obj.
4109 Remove calls to g_settings_bind. Connect something_changedCB to
4112 * xgselect.c: Add defined (HAVE_GSETTINGS).
4113 (xgselect_initialize): Ditto.
4115 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4116 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4119 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4121 * eval.c (struct backtrace): Simplify and port the data structure.
4122 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4123 signed bit field, as this assumption is not portable and it makes
4124 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4125 "char debug_on_exit : 1" as this is not portable either; instead,
4126 use the portable "unsigned int debug_on_exit : 1". Remove unused
4127 member evalargs. Remove obsolete comments about cc bombing out.
4129 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4131 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4132 Let HAVE_GSETTINGS override HAVE_GCONF.
4133 (store_monospaced_changed): New function.
4134 (EMACS_SETTINGS): A new type derived from GObject to handle
4135 GSettings notifications.
4136 (emacs_settings_constructor, emacs_settings_get_property)
4137 (emacs_settings_set_property, emacs_settings_class_init):
4139 (gsettings_client, gsettings_obj): New variables.
4140 (GSETTINGS_SCHEMA): New define.
4141 (something_changedCB): Call store_monospaced_changed.
4142 (init_gsettings): New function.
4143 (xsettings_initialize): Call init_gsettings.
4144 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4147 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4150 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4152 * window.c (resize_root_window, grow_mini_window)
4153 (shrink_mini_window): Rename Qresize_root_window to
4154 Qwindow_resize_root_window and Qresize_root_window_vertically to
4155 Qwindow_resize_root_window_vertically.
4157 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4159 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4161 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4163 * makefile.w32-in: Redesign dependencies so they reflect more
4164 clearly which files are directly included by each source file,
4165 and not through other includes.
4167 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4169 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4170 (sort_overlays, overlay_strings): When an overlay's clone number
4171 matches the window's clone number process the overlay even if
4172 the overlay's window property doesn't match the current window.
4174 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4175 (Fwindow_hchild): Rename to Fwindow_left_child.
4176 (Fwindow_next): Rename to Fwindow_next_sibling.
4177 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4178 (resize_window_check): Rename to window_resize_check.
4179 (resize_window_apply): Rename to window_resize_apply.
4180 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4181 (Fdelete_other_windows_internal, resize_frame_windows)
4182 (Fsplit_window_internal, Fdelete_window_internal)
4183 (grow_mini_window, shrink_mini_window)
4184 (Fresize_mini_window_internal): Fix callers accordingly.
4186 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4188 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4189 (emacs_fixed_set_min_size): Remove.
4190 (emacs_fixed_new): Take frame as argument.
4192 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4193 (_EmacsFixedPrivate): Remove minwidth/height.
4194 Add struct frame *f.
4195 (emacs_fixed_init): Initialize priv->f.
4196 (get_parent_class, emacs_fixed_set_min_size): Remove.
4197 (emacs_fixed_new): Set priv->f to argument.
4198 (emacs_fixed_get_preferred_width)
4199 (emacs_fixed_get_preferred_height): Use min_width/height from
4200 frames size_hint to set minimum and natural (Bug#8919).
4201 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4202 and use min_width/height from frames size_hint to set
4203 min_width/height (Bug#8919).
4205 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4206 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4209 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4211 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4212 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4215 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4217 * process.c (wait_reading_process_output): Bypass select if
4218 waiting for a cell while ignoring keyboard input, and input is
4219 pending. Suggested by Jan Djärv (Bug#8869).
4221 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4223 Use gnulib's dup2 module instead of rolling our own.
4224 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4226 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4228 * dispnew.c (scrolling_window): Before scrolling, turn off a
4229 mouse-highlight in the window being scrolled.
4231 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4233 Move DEFSYM to lisp.h and use everywhere.
4235 * character.h (DEFSYM): Move declaration...
4236 * lisp.h (DEFSYM): ...here.
4242 * w32select.c: Don't include character.h.
4244 * alloc.c (syms_of_alloc):
4245 * buffer.c (syms_of_buffer):
4246 * bytecode.c (syms_of_bytecode):
4247 * callint.c (syms_of_callint):
4248 * casefiddle.c (syms_of_casefiddle):
4249 * casetab.c (init_casetab_once):
4250 * category.c (init_category_once, syms_of_category):
4251 * ccl.c (syms_of_ccl):
4252 * cmds.c (syms_of_cmds):
4253 * composite.c (syms_of_composite):
4254 * dbusbind.c (syms_of_dbusbind):
4255 * dired.c (syms_of_dired):
4256 * dispnew.c (syms_of_display):
4257 * doc.c (syms_of_doc):
4258 * editfns.c (syms_of_editfns):
4259 * emacs.c (syms_of_emacs):
4260 * eval.c (syms_of_eval):
4261 * fileio.c (syms_of_fileio):
4262 * fns.c (syms_of_fns):
4263 * frame.c (syms_of_frame):
4264 * fringe.c (syms_of_fringe):
4265 * insdel.c (syms_of_insdel):
4266 * keymap.c (syms_of_keymap):
4267 * lread.c (init_obarray, syms_of_lread):
4268 * macros.c (syms_of_macros):
4269 * msdos.c (syms_of_msdos):
4270 * print.c (syms_of_print):
4271 * process.c (syms_of_process):
4272 * search.c (syms_of_search):
4273 * sound.c (syms_of_sound):
4274 * syntax.c (init_syntax_once, syms_of_syntax):
4275 * terminal.c (syms_of_terminal):
4276 * textprop.c (syms_of_textprop):
4277 * undo.c (syms_of_undo):
4278 * w32.c (globals_of_w32):
4279 * window.c (syms_of_window):
4280 * xdisp.c (syms_of_xdisp):
4281 * xfaces.c (syms_of_xfaces):
4282 * xfns.c (syms_of_xfns):
4283 * xmenu.c (syms_of_xmenu):
4284 * xsettings.c (syms_of_xsettings):
4285 * xterm.c (syms_of_xterm): Use DEFSYM.
4287 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4289 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4291 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4293 Integer and buffer overflow fixes (Bug#8873).
4295 * print.c (printchar, strout): Check for string overflow.
4296 (PRINTPREPARE, printchar, strout):
4297 Don't set size unless allocation succeeds.
4299 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4300 for sizes. Check for string overflow more accurately.
4301 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4303 * macros.c: Integer and buffer overflow fixes.
4304 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4305 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4306 Use ptrdiff_t, not int, for sizes.
4307 Don't increment bufsize until after realloc succeeds.
4308 Check for size-calculation overflow.
4309 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4311 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4313 * lread.c: Integer overflow fixes.
4314 (read_integer): Radix is now EMACS_INT, not int,
4315 to improve quality of diagnostics for out-of-range radices.
4316 Calculate buffer size correctly for out-of-range radices.
4317 (read1): Check for integer overflow in radices, and in
4318 read-circle numbers.
4319 (read_escape): Avoid int overflow.
4320 (Fload, openp, read_buffer_size, read1)
4321 (substitute_object_recurse, read_vector, read_list, map_obarray):
4322 Use ptrdiff_t, not int, for sizes.
4323 (read1): Use EMACS_INT, not int, for sizes.
4324 Check for size overflow.
4326 * image.c (cache_image): Check for size arithmetic overflow.
4328 * lread.c: Integer overflow issues.
4329 (saved_doc_string_size, saved_doc_string_length)
4330 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4331 Now ptrdiff_t, not int.
4332 (read1): Don't assume doc string length fits in int. Check for
4333 out-of-range doc string lengths.
4334 (read_list): Don't assume file position fits in int.
4335 (read_escape): Check for hex character overflow.
4337 2011-06-22 Leo Liu <sdl.web@gmail.com>
4339 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4340 Move to minibuffer.el.
4342 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4344 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4345 The following patches are for when GLYPH_DEBUG && !XASSERT.
4346 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4347 * dispnew.c (flush_stdout):
4348 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4349 Mark as externally visible.
4350 * dispnew.c (check_window_matrix_pointers): Now static.
4351 * dispnew.c (window_to_frame_vpos):
4352 * xfns.c (unwind_create_frame):
4353 * xterm.c (x_check_font): Remove unused local.
4354 * scroll.c (CHECK_BOUNDS):
4355 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4356 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4357 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4358 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4359 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4361 (debug_method_add): Use va_list and vsprintf rather than relying
4362 on undefined behavior with wrong number of arguments.
4363 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4364 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4365 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4366 since we're not interested in debugging glyphs with old libraries.
4367 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4368 GCC 4.6.0's static checking.
4370 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4372 Integer overflow and signedness fixes (Bug#8873).
4373 A few related buffer overrun fixes, too.
4375 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4377 * dispextern.h (struct face.stipple):
4378 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4379 (x_bitmap_mask, x_allocate_bitmap_record)
4380 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4381 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4382 (x_create_bitmap_from_xpm_data):
4383 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4384 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4386 * xfaces.c (load_pixmap):
4387 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4388 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4389 (.bitmaps_last, struct x_output.icon_bitmap):
4390 Use ptrdiff_t, not int, for bitmap indexes.
4391 (x_allocate_bitmap_record): Check for size overflow.
4392 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4394 Use ptrdiff_t, not int, for overlay counts.
4395 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4396 * editfns.c (overlays_around, get_pos_property):
4397 * textprop.c (get_char_property_and_overlay):
4398 * xdisp.c (next_overlay_change, note_mouse_highlight):
4399 * xfaces.c (face_at_buffer_position):
4400 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4401 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4402 (Fnext_overlay_change, Fprevious_overlay_change)
4403 (mouse_face_overlay_overlaps, Foverlays_in):
4404 Use ptrdiff_t, not int, for sizes.
4405 (overlays_at, overlays_in): Check for size-calculation overflow.
4407 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4409 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4410 (x_session_initialize): Do not assume string length fits in int.
4412 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4413 This is unlikely, but can occur if DPI is outlandish.
4415 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4416 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4418 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4419 * xrdb.c (magic_file_p, search_magic_path):
4420 Omit last arg SUFFIX; it was always 0. All callers changed.
4421 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4423 * xfont.c (xfont_match): Avoid need for strlen.
4425 * xfns.c: Don't assume strlen fits in int.
4426 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4428 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4429 not unsigned long, as we prefer signed integers. All callers changed.
4430 Detect integer overflow in repeat count.
4431 (message_dolog): Don't assume print length fits in 39 bytes.
4432 (display_mode_element): Don't assume strlen fits in int.
4434 * termcap.c: Don't assume sizes fit in int and never overflow.
4435 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4436 (gobble_line): Check for size-calculation overflow.
4438 * minibuf.c (Fread_buffer):
4439 * lread.c (intern, intern_c_string):
4440 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4441 Don't assume string length fits in int.
4443 * keyboard.c (parse_tool_bar_item):
4444 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4446 * font.c: Don't assume string length fits in int.
4447 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4448 Use ptrdiff_t, not int.
4449 (font_intern_prop): Don't assume string length fits in int.
4450 Don't assume integer property fits in fixnum.
4451 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4453 * filelock.c: Fix some buffer overrun and integer overflow issues.
4454 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4455 Reformulate so as not to need the command string.
4456 Invoke gzip -cd rather than gunzip, as it's more portable.
4457 (lock_info_type, lock_file_1, lock_file):
4458 Don't assume pid_t and time_t fit in unsigned long.
4459 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4460 (current_lock_owner): Prefer signed type for sizes.
4461 Use memcpy, not strncpy, where memcpy is what is really wanted.
4462 Don't assume (via atoi) that time_t and pid_t fit in int.
4463 Check for time_t and/or pid_t out of range, e.g., via a network share.
4464 Don't alloca where an auto var works fine.
4466 * fileio.c: Fix some integer overflow issues.
4467 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4468 Don't assume string length fits in int.
4469 (directory_file_name): Don't assume string length fits in long.
4470 (make_temp_name): Don't assume pid fits in int, or that its print
4471 length is less than 20.
4473 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4475 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4477 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4479 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4480 We prefer signed integers, even for size calculations.
4482 * emacs.c: Don't assume string length fits in 'int'.
4483 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4484 (main): Don't invoke strlen when not needed.
4486 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4487 (XD_DEBUG_MESSAGE): Don't waste a byte.
4489 * callproc.c (getenv_internal_1, getenv_internal)
4491 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4493 * lread.c (invalid_syntax): Omit length argument.
4494 All uses changed. This doesn't fix a bug, but it simplifies the
4495 code away from its former Hollerith-constant appearance, and it's
4496 one less 'int' to worry about when looking at integer-overflow issues.
4497 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4499 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4500 This didn't break anything, but it didn't help either.
4501 It's confusing to put a bogus integer in a place where the actual
4502 value does not matter.
4503 (LIST_END_P): Remove unused macro and its bogus comment.
4504 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4506 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4507 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4509 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4510 We prefer signed types, and the value cannot exceed the EMACS_INT
4511 range anyway (because otherwise the length would not be representable).
4512 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4513 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4514 This avoids a GCC warning when WIDE_EMACS_INT.
4516 * indent.c (sane_tab_width): New function.
4517 (current_column, scan_for_column, Findent_to, position_indentation)
4518 (compute_motion): Use it. This is just for clarity.
4519 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4521 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4523 * lisp.h (lint_assume): New macro.
4524 * composite.c (composition_gstring_put_cache):
4525 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4527 * editfns.c, insdel.c:
4528 Omit unnecessary forward decls, to simplify future changes.
4530 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4532 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4534 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4535 Use much-faster test for byte-length change.
4536 Don't assume string byte-length fits in 'int'.
4537 Check that character arg fits in 'int'.
4538 (mapcar1): Declare byte as byte, for clarity.
4540 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4542 * fns.c (concat): Catch string overflow earlier.
4543 Do not rely on integer wraparound.
4545 * dispextern.h (struct it.overlay_strings_charpos)
4546 (struct it.selective): Now EMACS_INT, not int.
4547 * xdisp.c (forward_to_next_line_start)
4548 (back_to_previous_visible_line_start)
4549 (reseat_at_next_visible_line_start, next_element_from_buffer):
4550 Don't arbitrarily truncate the value of 'selective' to int.
4552 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4554 * composite.c: Don't truncate sizes to 'int'.
4555 (composition_gstring_p, composition_reseat_it)
4556 (composition_adjust_point): Use EMACS_INT, not int.
4557 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4558 not EMACS_UINT, for indexes.
4560 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4562 * buffer.c: Include <verify.h>.
4563 (struct sortvec.priority, struct sortstr.priority):
4564 Now EMACS_INT, not int.
4565 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4566 (struct sortstr.size, record_overlay_string)
4567 (struct sortstrlist.size, struct sortlist.used):
4568 Don't truncate size to int.
4569 (record_overlay_string): Check for size-calculation overflow.
4570 (init_buffer_once): Check at compile-time, not run-time.
4572 2011-06-22 Jim Meyering <meyering@redhat.com>
4574 Don't leak an XBM-image-sized buffer
4575 * image.c (xbm_load): Free the image buffer after using it.
4577 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4580 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4581 that Sun C diagnosed.
4582 * fns.c (secure_hash): Fix pointer signedness issue.
4583 * intervals.c (static_offset_intervals): New function.
4584 (offset_intervals): Use it.
4586 2011-06-21 Leo Liu <sdl.web@gmail.com>
4589 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4592 * fns.c (secure_hash): Rename from crypto_hash_function and change
4593 the first arg to accept symbols.
4594 (Fsecure_hash): New primitive.
4595 (syms_of_fns): New symbols.
4597 2011-06-20 Deniz Dogan <deniz@dogan.se>
4599 * process.c (Fset_process_buffer): Clarify return value in
4602 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4604 * dispnew.c (add_window_display_history): Use BVAR.
4606 * xdisp.c (debug_method_add): Use BVAR.
4607 (check_window_end, dump_glyph_matrix, dump_glyph)
4608 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4610 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4613 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4614 check till after the cache is created in init_frame_faces.
4616 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4618 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4620 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4622 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4623 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4624 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4626 Improve buffer-overflow checking (Bug#8873).
4627 * fileio.c (Finsert_file_contents):
4628 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4629 Remove the old (too-loose) buffer overflow checks.
4630 They weren't needed, since make_gap checks for buffer overflow.
4631 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4632 The old code merely checked for Emacs fixnum overflow, and relied
4633 on undefined (wraparound) behavior. The new code avoids undefined
4634 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4636 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4637 Tune. Don't use wider integers than needed. Don't use alloca.
4638 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4640 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4642 * insdel.c, lisp.h (buffer_overflow): New function.
4643 (insert_from_buffer_1, replace_range, replace_range_2):
4644 * insdel.c (make_gap_larger):
4645 * editfns.c (Finsert_char):
4646 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4648 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4650 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4652 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4654 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4655 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4657 * fileio.c: Don't assume EMACS_INT fits in off_t.
4658 (emacs_lseek): New static function.
4659 (Finsert_file_contents, Fwrite_region): Use it.
4660 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4662 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4664 * fns.c: Don't overflow int when computing a list length.
4665 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4666 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4667 truncation on 64-bit hosts. Check for QUIT every
4668 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4669 faster and is responsive enough.
4670 (Flength): Report an error instead of overflowing an integer.
4671 (Fsafe_length): Return a float if the value is not representable
4672 as a fixnum. This shouldn't happen except in contrived situations.
4673 (Fnthcdr, Fsort): Don't assume list length fits in int.
4674 (Fcopy_sequence): Don't assume vector length fits in int.
4676 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4677 (header_size, word_size): New constants.
4678 (allocate_vectorlike): Don't check size overflow here.
4679 (allocate_vector): Check it here instead, since this is the only
4680 caller of allocate_vectorlike that could cause overflow.
4681 Check that the new vector's length is representable as a fixnum.
4683 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4684 The previous code was bogus. For example, next_almost_prime (32)
4685 returned 39, which is undesirable as it is a multiple of 3; and
4686 next_almost_prime (24) returned 25, which is a multiple of 5 so
4687 why was the code bothering to check for multiples of 7?
4689 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4691 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4693 Variadic C functions now count arguments with ptrdiff_t.
4694 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4695 Back then I didn't know that the Emacs coding style prefers signed int.
4696 Also, in the meantime I found a few more instances where arguments
4697 were being counted with int, which may truncate counts on 64-bit
4698 machines, or EMACS_INT, which may be unnecessarily wide.
4699 * lisp.h (struct Lisp_Subr.function.aMANY)
4700 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4701 Arg counts are now ptrdiff_t, not size_t.
4702 All variadic functions and their callers changed accordingly.
4703 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4704 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4705 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4706 * callint.c (Fcall_interactively): Check arg count for overflow,
4707 to avoid potential buffer overrun. Use signed char, not 'int',
4708 for 'varies' array, so that we needn't bother to check its size
4709 calculation for overflow.
4710 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4711 * eval.c (apply_lambda):
4712 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4713 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4714 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4716 * callint.c (Fcall_interactively): Don't use index var as event count.
4718 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4719 * mem-limits.h (SIZE): Remove; no longer used.
4721 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4723 Remove unnecessary casts.
4724 * xterm.c (x_term_init):
4725 * xfns.c (x_set_border_pixel):
4726 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4727 These aren't needed now that we assume ANSI C.
4729 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4730 It's more likely to cause problems (due to unsigned overflow)
4733 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4735 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4737 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4739 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4741 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4743 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4745 GLYPH_CODE_FACE returns EMACS_INT, not int.
4746 * dispextern.h (merge_faces):
4747 * xfaces.c (merge_faces):
4748 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4749 Don't assume EMACS_INT fits in int.
4751 * character.h (CHAR_VALID_P): Remove unused parameter.
4752 * fontset.c, lisp.h, xdisp.c: All uses changed.
4754 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4756 * fns.c (concat): Minor tuning based on overflow analysis.
4757 This doesn't fix any bugs. Use int to hold character, instead
4758 of constantly refetching from Emacs object. Use XFASTINT, not
4759 XINT, for value known to be a character. Don't bother comparing
4760 a single byte to 0400, as it's always less.
4762 * floatfns.c (Fexpt):
4763 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4765 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4768 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4770 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4771 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4772 incorrectly succeed when S was a string, because 4294967386 was
4773 truncated before it was used.
4775 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4776 Otherwise, an out-of-range integer could cause undefined behavior
4779 * composite.c: Use int, not EMACS_INT, for characters.
4780 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4781 EMACS_INT, for values that are known to be in character range.
4782 This doesn't fix any bugs but is the usual style inside Emacs and
4783 may generate better code on 32-bit machines.
4785 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4786 This is for reasons similar to the recent CHAR_STRING fix.
4787 * charset.c (Fencode_char): Check that character arg is actually
4788 a character. Pass an int to ENCODE_CHAR.
4789 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4790 wider than 'int', as a compile-time check to prevent future regressions
4793 * character.c (char_string): Remove unnecessary casts.
4795 Make sure a 64-bit char is never passed to CHAR_STRING.
4796 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4797 by silently ignoring the top 32 bits, allowing some values
4798 that were far too large to be valid characters.
4799 * character.h: Include <verify.h>.
4800 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4801 arguments are no wider than unsigned, as a compile-time check
4802 to prevent future regressions in this area.
4804 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4805 (Fsubst_char_in_region):
4807 * xdisp.c (decode_mode_spec_coding):
4808 Adjust to CHAR_STRING's new requirement.
4809 * editfns.c (Finsert_char, Fsubst_char_in_region):
4810 * fns.c (concat): Check that character args are actually
4811 characters. Without this test, these functions did the wrong
4812 thing with wildly out-of-range values on 64-bit hosts.
4814 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4815 These casts should not be needed on 32-bit hosts, either.
4816 * keyboard.c (read_char):
4817 * lread.c (Fload): Remove casts to unsigned.
4819 * lisp.h (UNSIGNED_CMP): New macro.
4820 This fixes comparison bugs on 64-bit hosts.
4821 (ASCII_CHAR_P): Use it.
4822 * casefiddle.c (casify_object):
4823 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4824 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4825 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4826 * dispextern.h (FACE_FROM_ID):
4827 * keyboard.c (read_char): Use UNSIGNED_CMP.
4829 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4830 not to EMACS_INT, to avoid GCC warning.
4832 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4834 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4835 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4836 isn't needed on 32-bit machines.
4838 * buffer.c (Fgenerate_new_buffer_name):
4839 Use EMACS_INT for count, not int.
4840 (advance_to_char_boundary): Return EMACS_INT, not int.
4842 * data.c (Qcompiled_function): Now static.
4844 * window.c (window_body_lines): Now static.
4846 * image.c (gif_load): Rename local to avoid shadowing.
4848 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4849 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4850 * alloc.c (make_save_value): Integer argument is now of type
4852 (mark_object): Use ptrdiff_t, not int.
4853 * lisp.h (pD): New macro.
4854 * print.c (print_object): Use it.
4856 * alloc.c: Use EMACS_INT, not int, to count objects.
4857 (total_conses, total_markers, total_symbols, total_vector_size)
4858 (total_free_conses, total_free_markers, total_free_symbols)
4859 (total_free_floats, total_floats, total_free_intervals)
4860 (total_intervals, total_strings, total_free_strings):
4861 Now EMACS_INT, not int. All uses changed.
4862 (Fgarbage_collect): Compute overall total using a double, so that
4863 integer overflow is less likely to be a problem. Check for overflow
4864 when converting back to an integer.
4865 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4866 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4867 These were 'int' variables that could overflow on 64-bit hosts;
4868 they were never used, so remove them instead of repairing them.
4869 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4870 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4871 Previously, this ceilinged at INT_MAX, but that doesn't work on
4873 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4875 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4876 (allocate_vectorlike): Check for ptrdiff_t overflow.
4877 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4878 when a (possibly-narrower) signed value would do just as well.
4879 We prefer using signed arithmetic, to avoid comparison confusion.
4881 * alloc.c: Catch some string size overflows that we were missing.
4882 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4883 for convenience in STRING_BYTES_MAX.
4884 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4885 The definition here is exact; the one in lisp.h was approximate.
4886 (allocate_string_data): Check for string overflow. This catches
4887 some instances we weren't catching before. Also, it catches
4888 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4889 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4890 and ptrdiff_t and EMACS_INT are both 64 bits.
4892 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4893 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4894 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4896 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4898 * alloc.c (Fmake_string): Check for out-of-range init.
4900 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4902 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4904 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4906 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4907 xg_get_default_scrollbar_width.
4909 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4910 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4911 (style_changed_cb): Call update_theme_scrollbar_width and call
4912 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4913 all frames (Bug#8505).
4914 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4915 Call gtk_window_set_resizable if HAVE_GTK3.
4916 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4917 and height if HAVE_GTK3 (Bug#8505).
4918 (scroll_bar_width_for_theme): New variable.
4919 (update_theme_scrollbar_width): New function.
4920 (xg_get_default_scrollbar_width): Move code to
4921 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4922 (xg_initialize): Call update_theme_scrollbar_width.
4924 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4926 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4928 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4930 * frame.c (make_frame): Call other_buffer_safely instead of
4933 * window.c (temp_output_buffer_show): Call display_buffer with
4934 second argument Vtemp_buffer_show_specifiers and reset latter
4935 immediately after the call.
4936 (Vtemp_buffer_show_specifiers): New variable.
4937 (auto_window_vscroll_p, next_screen_context_lines)
4938 (Vscroll_preserve_screen_position): Remove leading asterisks from
4941 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4943 Fix minor problems found by GCC 4.6.0 static checking.
4944 * buffer.c (Qclone_number): Remove for now, as it's unused.
4945 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4946 (record_buffer): Remove unused local.
4947 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4948 (set_frame_buffer_list): Remove; unused.
4949 * frame.h (other_visible_frames): Remove decl.
4950 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4951 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4952 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4954 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4955 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4956 Define only if HAVE_GPM.
4957 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4958 (update_hints_inhibit): Remove; never set. All uses removed.
4959 * widgetprv.h (emacsFrameClassRec): Remove decl.
4960 * window.c (delete_deletable_window): Now returns void, since it
4961 wasn't returning anything.
4962 (compare_window_configurations): Remove unused locals.
4963 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4964 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4965 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4966 the same widths as pointers. This follows up on the 2011-05-06 patch.
4967 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4968 * xterm.h: Likewise.
4969 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4971 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4973 * makefile.w32-in: Update dependencies.
4974 (LISP_H): Add lib/intprops.h.
4976 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4978 * image.c (gif_load): Add animation frame delay to the metadata.
4979 (syms_of_image): Use DEFSYM. New symbol `delay'.
4981 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4983 * window.c (delete_deletable_window): Re-add.
4984 (Fset_window_configuration): Rewrite to handle dead buffers and
4985 consequently deletable windows.
4986 (window_tree, Fwindow_tree): Remove. Supply functionality in
4988 (compare_window_configurations): Simplify code.
4990 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4992 * image.c (imagemagick_load_image): Fix type mismatch.
4993 (Fimagemagick_types): Likewise.
4995 * window.h (replace_buffer_in_windows): Declare.
4997 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4999 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5000 Qclone_number. Remove external declaration of Qdelete_window.
5001 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5003 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5004 Run Qbuffer_list_update_hook if allowed.
5005 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5006 buffer list implementation.
5007 (other_buffer_safely): New function.
5008 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5009 calls to replace_buffer_in_windows and
5010 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5012 (record_buffer): Inhibit quitting and rewrite using quittable
5013 functions. Run Qbuffer_list_update_hook if allowed.
5014 (Frecord_buffer, Funrecord_buffer): New functions.
5015 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5016 Move switch-to-buffer to window.el.
5017 (bury-buffer): Move to window.el.
5018 (Vbuffer_list_update_hook): New variable.
5020 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5023 * window.h (resize_frame_windows): Move up in code.
5024 (Fwindow_frame): Remove EXFUN.
5025 (replace_buffer_in_all_windows): Remove prototype.
5026 (replace_buffer_in_windows_safely): Add prototype.
5028 * window.c: Declare Qdelete_window static again. Move down
5029 declaration of select_count.
5030 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5031 (Fother_window): Move to window.el.
5032 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5033 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5034 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5036 (replace_buffer_in_windows): Implement by calling
5037 Qreplace_buffer_in_windows.
5038 (replace_buffer_in_all_windows): Remove with some functionality
5039 moved into replace_buffer_in_windows_safely.
5040 (replace_buffer_in_windows_safely): New function.
5041 (select_window_norecord, select_frame_norecord): Move in front
5042 of run_window_configuration_change_hook. Remove now obsolete
5044 (Fset_window_buffer): Rewrite doc-string.
5045 Call Qrecord_window_buffer.
5046 (keys_of_window): Move binding for other-window to window.el.
5048 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5050 * dispextern.h (struct image): Replace data member, whose int_val
5051 and ptr_val fields were not used by anything, with a single
5054 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5055 (gif_clear_image, gif_load, imagemagick_load_image)
5056 (gs_clear_image, gs_load): Callers changed.
5058 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5060 * buffer.h: Include <time.h>, for time_t.
5061 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5063 Fix minor problems found by static checking.
5065 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5067 Make identifiers static if they are not used in other modules.
5068 * data.c (Qcompiled_function, Qframe, Qvector):
5069 * image.c (QimageMagick, Qsvg):
5070 * minibuf.c (Qmetadata):
5071 * window.c (resize_window_check, resize_root_window): Now static.
5072 * window.h (resize_window_check, resize_root_window): Remove decls.
5074 * window.c (window_deletion_count, delete_deletable_window):
5076 (window_body_lines): Now static.
5077 (Fdelete_other_windows_internal): Mark vars as initialized.
5078 Make sure 'resize_failed' is initialized.
5079 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5080 (resize_window_apply): Remove unused local.
5081 * window.h (delete_deletable_window): Remove decl.
5083 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5084 (imagemagick_load_image): Fix pointer signedness problem by changing
5085 last arg from unsigned char * to char *. All uses changed.
5086 Also, fix a local for similar reasons.
5087 Remove unused locals. Remove locals to avoid shadowing.
5088 (fn_rsvg_handle_free): Remove; unused.
5089 (svg_load, svg_load_image): Fix pointer signedness problem.
5090 (imagemagick_load_image): Don't use garbage pointer image_wand.
5092 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5094 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5096 * image.c (gif_load): Fix omitted cast error introduced by
5099 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5101 * window.h (resize_proportionally, orig_total_lines)
5102 (orig_top_line): Remove from window structure.
5103 (set_window_height, set_window_width, change_window_heights)
5104 (Fdelete_window): Remove prototypes.
5105 (resize_frame_windows): Remove duplicate declaration.
5107 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5109 * window.h (resize_frame_windows, resize_window_check)
5110 (delete_deletable_window, resize_root_window)
5111 (resize_frame_windows): Declare prototypes.
5113 * window.c (resize_window_apply): Make definition be "static" to
5114 match the prototype.
5116 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5118 * window.c: Remove declarations of Qwindow_size_fixed,
5119 window_min_size_1, window_min_size_2, window_min_size,
5120 size_window, window_fixed_size_p, enlarge_window, delete_window.
5121 Remove static from declaration of Qdelete_window, it's
5122 temporarily needed by Fbury_buffer.
5123 (replace_window): Don't assign orig_top_line and
5125 (Fdelete_window, delete_window): Remove. Window deletion is
5126 handled by window.el.
5127 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5128 Replace Fdelete_window calls with calls to Qdelete_window.
5129 (Fdelete_other_windows): Remove. Deleting other windows is
5130 handled by window.el.
5131 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5132 handled in window.el.
5133 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5134 Window minimum sizes are handled in window.el.
5135 (shrink_windows, size_window, set_window_height)
5136 (set_window_width, change_window_heights, window_height)
5137 (window_width, CURBEG, CURSIZE, enlarge_window)
5138 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5139 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5140 handled in window.el.
5141 (make_dummy_parent): Rename to make_parent_window and give it a
5142 second argument horflag.
5143 (make_window): Don't set resize_proportionally any more.
5144 (Fsplit_window): Remove. Windows are split in window.el.
5145 (save_restore_action, save_restore_orig_size)
5146 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5147 Resize mini windows in window.el.
5148 (grow_mini_window, shrink_mini_window): Implement by calling
5149 Qresize_root_window_vertically, resize_window_check and
5150 resize_window_apply.
5151 (saved_window, Fset_window_configuration, save_window_save):
5152 Do not handle orig_top_line, orig_total_lines, and
5153 resize_proportionally.
5154 (window_min_height, window_min_width): Move to window.el.
5155 (keys_of_window): Move bindings for delete-other-windows,
5156 split-window, delete-window and enlarge-window to window.el.
5158 * buffer.c: Temporarily extern Qdelete_window.
5159 (Fbury_buffer): Temporarily call Qdelete_window instead of
5160 Fdelete_window (Fbury_buffer will move to window.el soon).
5162 * frame.c (set_menu_bar_lines_1): Remove code handling
5163 orig_top_line and orig_total_lines.
5165 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5166 set_window_height but set heights directly.
5167 (change_frame_size_1): Use resize_frame_windows.
5169 * xdisp.c (init_xdisp): Don't use set_window_height but set
5172 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5173 Use resize_frame_windows instead of change_window_heights and run
5174 run_window_configuration_change_hook.
5176 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5177 instead of change_window_heights and run
5178 run_window_configuration_change_hook.
5180 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5182 * window.c (replace_window): Rename second argument REPLACEMENT to
5183 NEW. New third argument SETFLAG. Rewrite.
5184 (delete_window, make_dummy_parent): Call replace_window with
5186 (window_list_1): Move down in code.
5187 (run_window_configuration_change_hook): Move set_buffer part
5188 before select_frame_norecord part in order to unwind correctly.
5189 Rename count1 to count.
5190 (recombine_windows, delete_deletable_window, resize_root_window)
5191 (Fdelete_other_windows_internal)
5192 (Frun_window_configuration_change_hook, make_parent_window)
5193 (resize_window_check, resize_window_apply, Fresize_window_apply)
5194 (resize_frame_windows, Fsplit_window_internal)
5195 (Fdelete_window_internal, Fresize_mini_window_internal):
5197 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5199 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5201 * window.h (window): Add some new members to window structure -
5202 normal_lines, normal_cols, new_total, new_normal, clone_number,
5203 splits, nest, prev_buffers, next_buffers.
5204 (WINDOW_TOTAL_SIZE): Move here from window.c.
5205 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5207 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5209 (make_dummy_parent): Set new members of windows structure.
5210 (make_window): Move down in code. Handle new members of window
5212 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5213 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5214 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5215 (Fset_window_prev_buffers, Fwindow_next_buffers)
5216 (Fset_window_next_buffers, Fset_window_clone_number):
5218 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5219 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5221 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5222 Argument WINDOW can be now internal window too.
5223 (Fwindow_use_time): Move up in code.
5224 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5226 (Fset_window_configuration, saved_window)
5227 (Fcurrent_window_configuration, save_window_save): Handle new
5228 members of window structure.
5229 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5230 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5231 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5232 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5233 Qget_mru_window, Qresize_root_window,
5234 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5235 Qauto_buffer_name; staticpro them.
5237 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5239 * window.c (Fwindow_total_size, Fwindow_left_column)
5240 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5241 (Fwindow_list_1): New functions.
5242 (window_box_text_cols): Replace with window_body_cols.
5243 (Fwindow_width, Fscroll_left, Fscroll_right):
5244 Use window_body_cols instead of window_box_text_cols.
5245 (delete_window, Fset_window_configuration):
5246 Call delete_all_subwindows with window as argument.
5247 (delete_all_subwindows): Take a window as argument and not a
5249 (window_loop): Remove handling of GET_LRU_WINDOW and
5251 (Fget_lru_window, Fget_largest_window): Move to window.el.
5253 * window.h: Extern window_body_cols instead of
5254 window_box_text_cols. delete_all_subwindows now takes a
5255 Lisp_Object as argument.
5257 * indent.c (compute_motion, Fcompute_motion):
5258 Use window_body_cols instead of window_box_text_cols.
5260 * frame.c (delete_frame): Call delete_all_subwindows with root
5263 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5265 * fns.c (Fputhash): Document return value.
5267 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5269 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5271 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5273 Cons<->int and similar integer overflow fixes (Bug#8794).
5275 Check for overflow when converting integer to cons and back.
5276 * charset.c (Fdefine_charset_internal, Fdecode_char):
5277 Use cons_to_unsigned to catch overflow.
5278 (Fencode_char): Use INTEGER_TO_CONS.
5279 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5280 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5281 * data.c (long_to_cons, cons_to_long): Remove.
5282 (cons_to_unsigned, cons_to_signed): New functions.
5283 These signal an error for invalid or out-of-range values.
5284 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5285 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5286 * font.c (Ffont_variation_glyphs):
5287 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5288 * lisp.h: Include <intprops.h>.
5289 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5290 (cons_to_signed, cons_to_unsigned): New decls.
5291 (long_to_cons, cons_to_long): Remove decls.
5292 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5293 (Fprimitive_undo): Use CONS_TO_INTEGER.
5294 * xfns.c (Fx_window_property): Likewise.
5295 * xselect.c: Include <limits.h>.
5296 (x_own_selection, selection_data_to_lisp_data):
5297 Use INTEGER_TO_CONS.
5298 (x_handle_selection_request, x_handle_selection_clear)
5299 (x_get_foreign_selection, Fx_disown_selection_internal)
5300 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5301 (lisp_data_to_selection_data): Use cons_to_unsigned.
5302 (x_fill_property_data): Use cons_to_signed.
5303 Report values out of range.
5305 Check for buffer and string overflow more precisely.
5306 * buffer.h (BUF_BYTES_MAX): New macro.
5307 * lisp.h (STRING_BYTES_MAX): New macro.
5308 * alloc.c (Fmake_string):
5309 * character.c (string_escape_byte8):
5310 * coding.c (coding_alloc_by_realloc):
5311 * doprnt.c (doprnt):
5312 * editfns.c (Fformat):
5314 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5315 since they may not be the same number.
5316 * editfns.c (Finsert_char):
5317 * fileio.c (Finsert_file_contents):
5318 Likewise for BUF_BYTES_MAX.
5320 * image.c: Use ptrdiff_t, not int, for sizes.
5321 (slurp_file): Switch from int to ptrdiff_t.
5323 (slurp_file): Check that file size fits in both size_t (for
5324 malloc) and ptrdiff_t (for sanity and safety).
5326 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5327 if b->modtime has its maximal value.
5329 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5331 Don't assume time_t can fit into int.
5332 * buffer.h (struct buffer.modtime): Now time_t, not int.
5333 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5334 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5336 Minor fixes for signed vs unsigned integers.
5337 * character.h (MAYBE_UNIFY_CHAR):
5338 * charset.c (maybe_unify_char):
5339 * keyboard.c (read_char, reorder_modifiers):
5340 XINT -> XFASTINT, since the integer must be nonnegative.
5341 * ftfont.c (ftfont_spec_pattern):
5342 * keymap.c (access_keymap, silly_event_symbol_error):
5343 XUINT -> XFASTINT, since the integer must be nonnegative.
5344 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5345 since it makes no difference and we prefer signed.
5346 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5347 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5350 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5352 * window.h (Fwindow_frame): Declare.
5354 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5356 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5357 (SPARE_MEMORY): Always define.
5358 (LARGE_REQUEST): Remove.
5359 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5361 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5363 * lisp.h: Move EXFUNS for Fframe_root_window,
5364 Fframe_first_window and Fset_frame_selected_window to window.h.
5366 * window.h: Move EXFUNS for Fframe_root_window,
5367 Fframe_first_window and Fset_frame_selected_window here from
5370 * frame.c (Fwindow_frame, Fframe_first_window)
5371 (Fframe_root_window, Fframe_selected_window)
5372 (Fset_frame_selected_window): Move to window.c.
5373 (Factive_minibuffer_window): Move to minibuf.c.
5374 (Fother_visible_frames_p): New function.
5376 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5378 * window.c (decode_window, decode_any_window): Move up in code.
5379 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5380 (inhibit_frame_unsplittable): Remove unused variable.
5381 (Fwindow_buffer): Move up and rewrite doc-string.
5382 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5383 (Fwindow_prev): New functions.
5384 (Fwindow_frame): Move here from frame.c. Accept any window as
5386 (Fframe_root_window, Fframe_first_window)
5387 (Fframe_selected_window): Move here from frame.c. Accept frame
5388 or arbitrary window as argument. Update doc-strings.
5389 (Fminibuffer_window): Move up in code.
5390 (Fwindow_minibuffer_p): Move up in code and simplify.
5391 (Fset_frame_selected_window): Move here from frame.c.
5393 (Fselected_window, select_window, Fselect_window): Move up in
5394 code. Minor doc-string fixes.
5396 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5398 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5399 Do not assume that spare memory exists; that assumption is valid
5400 only if SYSTEM_MALLOC.
5401 (LARGE_REQUEST): New macro, so that the issue of large requests
5402 is separated from the issue of spare memory.
5404 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5406 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5409 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5411 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5414 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5416 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5418 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5420 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5421 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5423 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5425 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5427 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5429 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5430 (x_clipboard_manager_save): Add return value.
5431 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5433 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5434 Obey Vx_select_enable_clipboard_manager. Catch errors in
5435 x_clipboard_manager_save (Bug#8779).
5436 (Vx_select_enable_clipboard_manager): New variable.
5437 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5439 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5441 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5443 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5445 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5446 in the current matrix if keep_current_p is non-zero.
5448 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5450 * bidi.c (bidi_level_of_next_char): Fix last change.
5452 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5454 Support bidi reordering of text covered by display properties.
5456 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5457 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5458 (bidi_cache_search, bidi_cache_iterator_state)
5459 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5460 (bidi_level_of_next_char, bidi_move_to_visually_next):
5461 Support character positions inside a run of characters covered by a
5463 (bidi_paragraph_init, bidi_resolve_explicit_1)
5464 (bidi_level_of_next_char): Call bidi_fetch_char and
5465 bidi_fetch_char_advance instead of FETCH_CHAR and
5467 (bidi_init_it): Initialize new members.
5468 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5470 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5471 instead of using explicit *_CHAR codes.
5472 (bidi_resolve_explicit, bidi_resolve_weak):
5473 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5474 bidirectional text is supported only in multibyte buffers.
5475 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5476 it to initialize the frame_window_p member of struct bidi_it.
5477 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5478 (bidi_resolve_explicit, bidi_resolve_weak)
5479 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5480 bidi_it->nchars is non-positive.
5481 (bidi_level_of_next_char): Don't try to lookup the cache for the
5482 next/previous character if nothing is cached there yet, or if we
5483 were just reseat()'ed to a new position.
5485 * xdisp.c (set_cursor_from_row): Set start and stop points
5486 according to the row's direction when priming the loop that looks
5487 for the glyph on which to display cursor.
5488 (single_display_spec_intangible_p): Function deleted.
5489 (display_prop_intangible_p): Reimplement to call
5490 handle_display_spec instead of single_display_spec_intangible_p.
5491 Accept 3 additional arguments needed by handle_display_spec.
5492 This fixes incorrect cursor motion across display property with complex
5493 values: lists, `(when COND...)' forms, etc.
5494 (single_display_spec_string_p): Support property values that are
5495 lists with the argument STRING its top-level element.
5496 (display_prop_string_p): Fix the condition for processing a
5497 property that is a list to be consistent with handle_display_spec.
5498 (handle_display_spec): New function, refactored from the
5499 last portion of handle_display_prop.
5500 (compute_display_string_pos): Accept additional argument
5501 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5502 value of a `display' property is a "replacing spec".
5503 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5504 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5505 the display property, but just return a value indicating whether
5506 the display property will replace the characters it covers.
5507 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5508 frame_window_p members of struct bidi_it.
5509 (compute_display_string_pos, compute_display_string_end):
5511 (push_it): Accept second argument POSITION, where pop_it should
5512 jump to continue iteration.
5513 (reseat_1): Initialize bidi_it.disp_pos.
5515 * keyboard.c (adjust_point_for_property): Adjust the call to
5516 display_prop_intangible_p to its new signature.
5518 * dispextern.h (struct bidi_it): New member frame_window_p.
5519 (bidi_init_it): Update prototypes.
5520 (display_prop_intangible_p): Update prototype.
5521 (compute_display_string_pos, compute_display_string_end):
5523 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5526 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5528 Malloc failure behavior now depends on size of allocation.
5529 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5530 * lisp.h: Change signatures accordingly.
5531 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5532 All callers changed. (Bug#8762)
5534 * gnutls.c: Use Emacs's memory allocators.
5535 Without this change, the gnutls library would invoke malloc etc.
5536 directly, which causes problems on non-SYNC_INPUT hosts, and which
5537 runs afoul of improving memory_full behavior. (Bug#8761)
5538 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5539 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5540 xfree instead of the default malloc, realloc, free.
5541 (Fgnutls_boot): No need to check for memory allocation failure,
5542 since xmalloc does that for us.
5544 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5545 * category.c (hash_get_category_set):
5546 * ccl.c (ccl_driver):
5547 * charset.c (Fdefine_charset_internal):
5548 * charset.h (struct charset.hash_index):
5549 * composite.c (get_composition_id, gstring_lookup_cache)
5550 (composition_gstring_put_cache):
5551 * composite.h (struct composition.hash_index):
5552 * dispextern.h (struct image.hash):
5553 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5554 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5555 (hashfn_equal, hashfn_user_defined, make_hash_table)
5556 (maybe_resize_hash_table, hash_lookup, hash_put)
5557 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5558 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5559 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5560 * image.c (make_image, search_image_cache, lookup_image)
5561 (xpm_put_color_table_h):
5562 * lisp.h (struct Lisp_Hash_Table):
5563 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5564 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5565 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5566 * alloc.c (allocate_vectorlike):
5567 Check for overflow in vector size calculations.
5568 * ccl.c (ccl_driver):
5569 Check for overflow when converting EMACS_INT to int.
5570 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5571 need to be updated by these changes.
5572 * fns.c (make_hash_table, maybe_resize_hash_table):
5573 Check for integer overflow with large hash tables.
5574 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5575 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5576 (SXHASH_REDUCE): New macro.
5577 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5578 Use it instead of discarding useful hash info with large hash values.
5579 (sxhash_float): New function.
5580 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5581 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5582 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5583 Rewrite to use FIXNUM_BITS, as this simplifies things.
5584 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5585 Adjust signatures to match updated version of code.
5586 (consing_since_gc): Now EMACS_INT, since a single hash table can
5587 use more than INT_MAX bytes.
5589 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5591 Make it possible to build with GCC-4.6+ -O2 -flto.
5593 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5595 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5597 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5598 Call minibuffer-inactive-mode.
5600 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5602 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5603 Update dependencies.
5605 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5607 * data.c (init_data): Remove code for UTS, this system is not
5610 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5612 Don't force ./temacs to start in terminal mode.
5614 * frame.c (make_initial_frame): Initialize faces in all cases, not
5615 only when CANNOT_DUMP is defined.
5616 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5618 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5620 * dispnew.c (add_window_display_history): Use const for the string
5621 pointer. Remove declaration, not needed.
5623 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5625 Use 'inline', not 'INLINE'.
5626 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5627 * alloc.c, fontset.c (INLINE): Remove.
5628 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5629 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5630 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5631 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5632 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5634 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5636 Make it possible to run ./temacs.
5638 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5639 syms_of_callproc does the same thing. Remove test for
5640 "initialized", do it in the caller.
5641 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5643 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5645 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5646 (read_minibuf): Use get_minibuffer.
5647 (syms_of_minibuf): Use DEFSYM.
5648 (Qmetadata): New var.
5649 * data.c (Qbuffer): Don't make it static.
5650 (syms_of_data): Use DEFSYM.
5652 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5654 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5655 (CCL_CODE_MIN): New macro.
5657 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5659 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5661 * eval.c (Qdebug): Now static.
5662 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5663 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5664 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5666 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5668 * image.c: Various fixes to ImageMagick code comments.
5669 (Fimagemagick_types): Doc fix.
5671 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5673 Minor fixes prompted by GCC 4.6.0 warnings.
5675 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5677 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5678 (x_clipboard_manager_save_all): Move extern decl to ...
5679 * xterm.h: ... here, so that it can be checked for consistency.
5681 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5683 * xselect.c (x_clipboard_manager_save_frame)
5684 (x_clipboard_manager_save_all): New functions.
5685 (Fx_clipboard_manager_save): Lisp function deleted.
5687 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5688 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5690 * xterm.h: Update prototype.
5692 2011-05-28 William Xu <william.xwl@gmail.com>
5694 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5697 2011-05-28 Jim Meyering <meyering@redhat.com>
5699 Avoid a sign-extension bug in crypto_hash_function.
5700 * fns.c (to_uchar): Define.
5701 (crypto_hash_function): Use it to convert some newly-signed
5702 variables to unsigned, to avoid sign-extension bugs. For example,
5703 without this change, (md5 "truc") would evaluate to
5704 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5705 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5706 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5708 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5710 Integer overflow fixes.
5712 * dbusbind.c: Serial number integer overflow fixes.
5713 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5714 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5715 to hold a serial number that is too large for a fixnum.
5716 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5717 Check for serial numbers out of range. Decode any serial number
5718 that was so large that it became a float. (Bug#8722)
5720 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5721 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5722 Use XFASTINT rather than XUINT when numbers are nonnegative.
5723 (xd_append_arg, Fdbus_method_return_internal):
5724 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5725 arguments, check that Lisp number is nonnegative, rather than
5726 silently wrapping negative numbers around. (Bug#8722)
5727 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5730 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5732 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5734 ccl: Add integer overflow checks.
5735 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5736 (IN_INT_RANGE): New macros.
5737 (ccl_driver): Use them to check for integer overflow when
5738 decoding a CCL program. Many of the new checks are whether XINT (x)
5739 fits in int; it doesn't always, on 64-bit hosts. The new version
5740 doesn't catch all possible integer overflows, but it's an
5741 improvement. (Bug#8719)
5743 * alloc.c (make_event_array): Use XINT, not XUINT.
5744 There's no need for unsigned here.
5746 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5747 This follows up to the 2011-05-06 change that substituted uintptr_t
5748 for EMACS_INT. This case wasn't caught back then.
5750 Rework Fformat to avoid integer overflow issues.
5751 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5752 now (part of C89). Include <verify.h>.
5753 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5754 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5755 (Fformat): Avoid the prepass trying to compute sizes; it was only
5756 approximate and thus did not catch overflow reliably. Instead, walk
5757 through the format just once, formatting and computing sizes as we go,
5758 checking for integer overflow at every step, and allocating a larger
5759 buffer as needed. Keep track separately whether the format is
5760 multibyte. Keep only the most-recently calculated precision, rather
5761 than them all. Record whether each argument has been converted to
5762 string. Use EMACS_INT, not int, for byte and char and arg counts.
5763 Support field widths and precisions larger than INT_MAX. Avoid
5764 sprintf's undefined behavior with conversion specifications such as %#d
5765 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5766 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5767 formatting out-of-range floating point numbers with int
5770 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5772 * data.c: Avoid integer truncation in expressions involving floats.
5773 * data.c: Include <intprops.h>.
5774 (arith_driver): When there's an integer overflow in an expression
5775 involving floating point, convert the integers to floating point
5776 so that the resulting value does not suffer from catastrophic
5777 integer truncation. For example, on a 64-bit host (* 4
5778 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5779 Do not rely on undefined behavior after integer overflow.
5781 merge count_size_as_multibyte, parse_str_to_multibyte
5782 * character.c, character.h (count_size_as_multibyte):
5783 Rename from parse_str_to_multibyte; all uses changed.
5784 Check for integer overflow.
5785 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5786 since it's now a duplicate of the other. This is more of
5787 a character than a buffer op, so better that it's in character.c.
5788 * fns.c, print.c: Adjust to above changes.
5790 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5792 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5794 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5796 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5797 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5798 (x_clipboard_manager_save): Now static.
5799 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5801 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5802 (crypto_hash_function): Now static.
5803 Fix pointer signedness problems. Avoid unnecessary initializations.
5805 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5807 * termhooks.h (Vselection_alist): Make it terminal-local.
5809 * terminal.c (create_terminal): Initialize it.
5811 * xselect.c: Support for clipboard managers.
5812 (Vselection_alist): Move to termhooks.h as terminal-local var.
5813 (LOCAL_SELECTION): New macro.
5814 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5815 (symbol_to_x_atom): Remove gratuitous arg.
5816 (x_handle_selection_request, lisp_data_to_selection_data)
5817 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5818 (x_own_selection, x_get_local_selection, x_convert_selection):
5819 New arg, specifying work frame. Use terminal-local Vselection_alist.
5820 (some_frame_on_display): Delete unused function.
5821 (Fx_own_selection_internal, Fx_get_selection_internal)
5822 (Fx_disown_selection_internal, Fx_selection_owner_p)
5823 (Fx_selection_exists_p): New optional frame arg.
5824 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5825 (x_handle_selection_clear): Don't treat other terminals with the
5826 same keyboard specially. Use the terminal-local Vselection_alist.
5827 (x_clear_frame_selections): Use Frun_hook_with_args.
5829 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5831 * xterm.h: Add support for those atoms.
5833 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5835 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5836 (converted_selections, conversion_fail_tag): New global variables.
5837 (x_selection_request_lisp_error): Free the above.
5838 (x_get_local_selection): Remove unnecessary code.
5839 (x_reply_selection_request): Args changed; handle arbitrary array
5840 of converted selections stored in converted_selections.
5841 Separate the XChangeProperty and SelectionNotify steps.
5842 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5843 (x_convert_selection): New function.
5844 (x_handle_selection_event): Simplify.
5845 (x_get_foreign_selection): Don't ignore incoming requests while
5846 waiting for an answer; this will fail when we implement
5847 SAVE_TARGETS, and seems unnecessary anyway.
5848 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5849 (Vx_sent_selection_functions): Doc fix.
5851 2011-05-26 Leo Liu <sdl.web@gmail.com>
5853 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5855 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5857 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5859 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5860 for fringe update if it has periodic bitmap.
5861 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5862 and fringe_bitmap_periodic_p.
5864 * fringe.c (get_fringe_bitmap_data): New function.
5865 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5866 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5867 row. Mark glyph row for fringe update if periodicity changed.
5869 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5870 for fringe update unless it has periodic bitmap.
5872 2011-05-25 Kenichi Handa <handa@m17n.org>
5874 * xdisp.c (get_next_display_element): Set correct it->face_id for
5875 a static composition.
5877 2011-05-24 Leo Liu <sdl.web@gmail.com>
5880 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5882 * fns.c (crypto_hash_function, Fsha1): New function.
5883 (Fmd5): Use crypto_hash_function.
5884 (syms_of_fns): Add Ssha1.
5886 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5888 * gnutls.c: Remove unused macros.
5889 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5890 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5891 Remove macros that are defined and never used.
5892 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5894 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5896 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5897 (Fx_get_selection_internal): Minor cleanup.
5898 (Fx_own_selection_internal): Rename arguments for consistency with
5901 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5903 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5905 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5907 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5909 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5911 * dispnew.c (scrolling_window): Don't exclude the case that the
5912 last enabled row in the desired matrix touches the bottom boundary.
5914 2011-05-21 Glenn Morris <rgm@gnu.org>
5916 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5917 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5918 and add some more files.
5920 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5922 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5923 report_file_error introduced by the change from 2011-05-07.
5925 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5927 * systime.h (Time): Define only if emacs is defined.
5928 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5929 where the include path doesn't have X11/X.h by default. See
5930 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5932 2011-05-20 Kenichi Handa <handa@m17n.org>
5934 * composite.c (find_automatic_composition): Fix previous change.
5936 2011-05-20 Glenn Morris <rgm@gnu.org>
5938 * lisp.mk: New file, split from Makefile.in.
5939 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5940 (shortlisp): Remove.
5941 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5943 2011-05-19 Glenn Morris <rgm@gnu.org>
5945 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5946 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5947 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5948 (lisp): Set the order to that of loadup.el.
5949 (shortlisp): Make it a copy of $lisp.
5950 (SOME_MACHINE_LISP): Remove.
5951 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5952 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5954 2011-05-18 Kenichi Handa <handa@m17n.org>
5956 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5957 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5958 (find_automatic_composition): Mostly rewrite for efficiency.
5960 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5962 * makefile.w32-in: Update dependencies.
5964 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5966 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5967 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5969 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5971 Fix some integer overflow issues, such as string length overflow.
5973 * insdel.c (count_size_as_multibyte): Check for string overflow.
5975 * character.c (lisp_string_width): Check for string overflow.
5976 Use EMACS_INT, not int, for string indexes and lengths; in
5977 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5978 the resulting string length overflows an EMACS_INT; instead,
5979 report a string overflow if no precision given. When checking for
5980 precision exhaustion, use a check that cannot possibly have
5981 integer overflow. (Bug#8675)
5982 * character.h (lisp_string_width): Adjust to new signature.
5984 * alloc.c (string_overflow): New function.
5985 (Fmake_string): Use it. This doesn't change behavior, but saves
5986 a few bytes and will simplify future changes.
5987 * character.c (string_escape_byte8): Likewise.
5988 * lisp.h (string_overflow): New decl.
5990 Fixups, following up to the user-interface timestamp change.
5991 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5992 for UI timestamps, instead of unsigned long.
5993 * msdos.c (mouse_get_pos): Likewise.
5994 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5995 * w32gui.h (Time): Define by including "systime.h" rather than by
5996 declaring it ourselves. (Bug#8664)
5998 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5999 * image.c (clear_image_cache): Likewise.
6001 * term.c (term_mouse_position): Don't assume time_t wraparound.
6003 Be more systematic about user-interface timestamps.
6004 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6005 and sometimes 'EMACS_UINT', to represent these timestamps.
6006 This change causes it to use 'Time' uniformly, as that's what X uses.
6007 This makes the code easier to follow, and makes it easier to catch
6008 integer overflow bugs such as Bug#8664.
6009 * frame.c (Fmouse_position, Fmouse_pixel_position):
6010 Use Time, not unsigned long, for user-interface timestamps.
6011 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6012 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6013 * keyboard.h (last_event_timestamp): Likewise.
6014 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6015 * menu.h (xmenu_show): Likewise.
6016 * term.c (term_mouse_position): Likewise.
6017 * termhooks.h (struct input_event.timestamp): Likewise.
6018 (struct terminal.mouse_position_hook): Likewise.
6019 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6020 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6021 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6022 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6024 * menu.h, termhooks.h: Include "systime.h", for Time.
6026 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6027 Don't assume that the difference between two unsigned long values
6028 can fit into an integer. At this point, we know button_down_time
6029 <= event->timestamp, so the difference must be nonnegative, so
6030 there's no need to cast the result if double-click-time is
6031 nonnegative, as it should be; check that it's nonnegative, just in
6032 case. This bug is triggered when events are more than 2**31 ms
6033 apart (about 25 days). (Bug#8664)
6035 * xselect.c (last_event_timestamp): Remove duplicate decl.
6036 (x_own_selection): Remove needless cast to unsigned long.
6038 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6039 that always fit in int. Use a sentinel instead of a counter, to
6040 avoid a temp and to allay GCC's concerns about possible int overflow.
6041 * frame.h (struct frame): Use int for menu_bar_items_used
6042 instead of EMACS_INT, since it always fits in int.
6044 * menu.c (grow_menu_items): Check for int overflow.
6046 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6048 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6049 Before, the code was not consistent. These values cannot exceed
6050 2**31 - 1 so there's no need to make them unsigned.
6051 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6052 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6053 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6055 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6057 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6058 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6059 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6060 presumably because the widths might not match.
6062 * window.c (size_window): Avoid needless test at loop start.
6064 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6066 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6068 2011-05-12 Drew Adams <drew.adams@oracle.com>
6070 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6072 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6074 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6075 `width' to `bar_area_x' and `bar_area_width', respectively.
6076 (x_scroll_run): Take account of fringe background extension.
6078 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6079 Rename local vars `left' and `width' to `bar_area_x' and
6080 `bar_area_width', respectively.
6081 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6082 background extension.
6084 2011-05-10 Jim Meyering <meyering@redhat.com>
6086 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6088 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6090 * image.c (Finit_image_library): Return t for built-in image types,
6091 like pbm and xbm. (Bug#8640)
6093 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6095 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6097 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6099 * w32console.c (Fset_screen_color): Doc fix.
6100 (Fget_screen_color): New function.
6101 (syms_of_ntterm): Defsubr it.
6103 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6104 unlink the temporary file if Fcall_process didn't create it in the
6106 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6107 child process will be redirected to a file specified with `:file'.
6108 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6109 cue to call_process_cleanup not to close that handle.
6111 2011-05-07 Ben Key <bkey76@gmail.com>
6113 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6114 one of two shell specific rules, either bootstrap-temacs-CMD or
6115 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6116 to the previous implementation of the bootstrap-temacs rule.
6117 The bootstrap-temacs-CMD rule is similar to the previous
6118 implementation of the bootstrap-temacs rule except that it
6119 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6122 These changes, along with some changes to nt/configure.bat,
6123 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6124 earlier fix to add support for --cflags and --ldflags options
6125 that include quotes so that it works whether make uses cmd or
6128 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6130 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6131 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6133 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6134 a string. Handle both cases.
6135 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6136 (Fdbus_register_method): Use Qinvalid_function.
6138 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6140 * makefile.w32-in: Update dependencies.
6141 (LISP_H): Add inttypes.h and stdin.h.
6142 (PROCESS_H): Add unistd.h.
6144 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6146 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6147 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6149 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6151 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6153 * term.c (vfatal): Remove stray call to va_end.
6154 It's not needed and the C Standard doesn't allow it here anyway.
6156 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6157 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6159 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6162 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6164 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6166 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6168 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6170 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6172 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6173 * charset.c (Fdefine_charset_internal): Don't initialize
6174 charset.code_space[15]. The value was garbage, on hosts with
6175 32-bit int (Bug#8600).
6177 * lread.c (read_integer): Be more consistent with string-to-number.
6178 Use string_to_number to do the actual conversion; this avoids
6179 rounding errors and fixes some other screwups. Without this fix,
6180 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6181 (digit_to_number): Move earlier, for benefit of read_integer.
6182 Return -1 if the digit is out of range for the base, -2 if it is
6183 not a digit in any supported base. (Bug#8602)
6185 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6187 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6188 to match comment at start of function. This also removes a
6189 GCC warning about overflow in a 32+64-bit port.
6191 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6193 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6194 Reported by Stefan Monnier in
6195 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6196 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6197 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6199 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6200 (EMACS_UINTPTR): Likewise, with uintptr_t.
6202 * lisp.h: Prefer 64-bit EMACS_INT if available.
6203 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6204 on 32-bit hosts that have 64-bit int, so that they can access
6206 However, temporarily disable this change unless the temporary
6207 symbol WIDE_EMACS_INT is defined.
6209 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6211 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6212 This removes an assumption that EMACS_INT and long are the same
6213 width as pointers. The assumption is true for Emacs porting targets
6214 now, but we want to make other targets possible.
6215 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6216 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6217 In the rest of the code, change types of integers that hold casted
6218 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6219 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6220 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6221 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6222 No need to cast type when ORing.
6223 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6224 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6225 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6226 assume EMACS_INT is the same width as char *.
6227 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6228 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6229 Remove no-longer-needed casts.
6230 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6231 (xg_tool_bar_help_callback, xg_make_tool_item):
6232 Use EMACS_INTPTR to hold an integer
6233 that will be cast to void *; this can avoid a GCC warning
6234 if EMACS_INT is not the same width as void *.
6235 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6236 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6237 (current_message_1, set_message_1):
6238 Use a local to convert to proper width without a cast.
6239 * xmenu.c (dialog_selection_callback): Likewise.
6241 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6242 Also, don't assume VALBITS / RAND_BITS is less than 5,
6243 and don't rely on undefined behavior when shifting a 1 left into
6245 * lisp.h (get_random): Change signature to match.
6247 * lread.c (hash_string): Use size_t, not int, for hash computation.
6248 Normally we prefer signed values; but hashing is special, because
6249 it's better to use unsigned division on hash table sizes so that
6250 the remainder is nonnegative. Also, size_t is the natural width
6251 for hashing into memory. The previous code used 'int', which doesn't
6252 retain enough info to hash well into very large tables.
6253 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6255 * dbusbind.c: Don't possibly lose pointer info when converting.
6256 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6257 Use XPNTR rather than XHASH, so that the high-order bits of
6258 the pointer aren't lost when converting through void *.
6260 * eval.c (Fautoload): Don't double-shift a pointer.
6262 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6264 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6266 * gnutls.c (DEF_GNUTLS_FN):
6267 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6269 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6271 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6274 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6276 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6277 New version that can reserve upto 2GB of heap space.
6279 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6281 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6283 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6285 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6286 `gnutls_certificate_set_x509_key_file'.
6288 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6290 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6291 Update dependencies.
6293 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6295 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6296 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6297 Remove unused parameter `fildes'.
6298 * process.c (read_process_output, send_process): Don't pass it.
6300 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6302 Fix previous change: the library cache is defined in w32.c.
6303 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6304 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6306 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6308 Implement dynamic loading of GnuTLS on Windows.
6310 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6311 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6312 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6315 * gnutls.c (Qgnutls_dll): Define.
6316 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6317 (gnutls_*): Declare function pointers.
6318 (init_gnutls_functions): New function to initialize function pointers.
6319 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6320 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6321 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6322 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6323 (emacs_gnutls_write, emacs_gnutls_read)
6324 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6325 (Fgnutls_available_p): New function.
6326 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6327 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6328 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6330 * image.c: Include w32.h.
6331 (Vimage_type_cache): Delete.
6332 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6333 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6334 (w32_delayed_load): Move to w32.c.
6336 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6338 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6339 (w32_delayed_load): Move from image.c. When loading a library, record
6340 its filename in the :loaded-from property of the library id.
6341 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6342 Initialize and staticpro them.
6343 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6345 * process.c: Include lisp.h before w32.h, not after.
6346 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6347 instead of gnutls_record_check_pending.
6349 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6351 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6353 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6354 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6357 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6359 * xterm.c (x_set_frame_alpha): Do not set property on anything
6360 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6362 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6364 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6366 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6368 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6369 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6370 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6371 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6372 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6373 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6374 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6375 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6376 (Qgnutls_bootprop_callbacks_verify): Make static.
6378 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6380 * callproc.c: Indentation fixup.
6382 * sysdep.c (wait_for_termination_1): Make static.
6383 (wait_for_termination, interruptible_wait_for_termination):
6384 Move after wait_for_termination_1.
6386 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6388 * sysdep.c (interruptible_wait_for_termination): New function
6389 which is like wait_for_termination, but allows keyboard
6392 * callproc.c (Fcall_process): Add (:file "file") as an option for
6394 (Fcall_process_region): Ditto.
6396 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6398 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6399 rather than `XVECTOR (FOO)->size'.
6401 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6402 inttypes.h, as a gnulib replacement is used if it not available in
6405 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6407 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6408 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6409 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6411 * coding.c (coding_alloc_by_realloc): Error out if destination
6412 will grow beyond MOST_POSITIVE_FIXNUM.
6413 (decode_coding_emacs_mule): Abort if there isn't enough place in
6414 charbuf for the composition carryover bytes. Reserve an extra
6415 space for up to 2 characters produced in a loop.
6416 (decode_coding_iso_2022): Abort if there isn't enough place in
6417 charbuf for the composition carryover bytes.
6419 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6421 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6422 aborting when %lld or %lll format is passed.
6423 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6424 %llo or %llx format is passed. (Bug#8545)
6426 * window.c (window_scroll_line_based): Use a marker instead of
6427 simple variables to record original value of point. (Bug#7952)
6429 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6430 produced by %s or %c overflows available buffer space. (Bug#8545)
6432 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6434 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6435 (SIZE_MAX): Move defn after all includes, as they might #define it.
6437 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6439 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6441 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6443 * keyboard.c (Qdelayed_warnings_hook): Define.
6444 (command_loop_1): Run `delayed-warnings-hook'
6445 if Vdelayed_warnings_list is non-nil.
6446 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6447 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6449 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6451 * doprnt.c (doprnt): Don't return value smaller than the buffer
6452 size if the message was truncated. (Bug#8545).
6454 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6456 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6457 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6459 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6461 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6463 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6465 * makefile.w32-in: Update dependencies.
6467 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6469 Improve `doprnt' and its usage. (Bug#8545)
6470 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6471 `format_end'. Remove support for %l as a conversion specifier.
6472 Don't use xrealloc. Improve diagnostics when the %l size modifier
6473 is used. Update the commentary.
6475 * eval.c (verror): Simplify calculation of size_t.
6477 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6480 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6482 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6485 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6487 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6488 This makes this file independent of the recent pseudovector change.
6490 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6492 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6494 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6495 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6496 Remove unused local.
6497 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6499 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6500 GCC 4.6.0 optimizes based on type-based alias analysis.
6501 For example, if b is of type struct buffer * and v of type struct
6502 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6503 != &v->size, and therefore "v->size = 1; b->size = 2; return
6504 v->size;" must therefore return 1. This assumption is incorrect
6505 for Emacs, since it type-puns struct Lisp_Vector * with many other
6506 types. To fix this problem, this patch adds a new type struct
6507 vectorlike_header that documents the constraints on layout of vectors
6508 and pseudovectors, and helps optimizing compilers not get fooled
6509 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6510 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6511 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6513 (XSETPVECTYPE): Rewrite in terms of new macro.
6514 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6515 This is a bit clearer, and further avoids the possibility of
6516 undesirable aliasing.
6517 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6518 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6519 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6520 since Lisp_Subr is a special case (no "next" field).
6521 (ASIZE): Now uses header.size rather than size.
6522 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6523 to avoid the hassle of writing XVECTOR (foo)->header.size.
6524 (struct vectorlike_header): New type.
6525 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6526 object, to help avoid aliasing.
6527 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6528 (SUBRP): Likewise, since Lisp_Subr is a special case.
6529 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6530 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6531 (struct Lisp_Hash_Table): Combine first two members into a single
6532 struct vectorlike_header member. All uses of "size" and "next" members
6533 changed to be "header.size" and "header.next".
6534 * buffer.h (struct buffer): Likewise.
6535 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6536 * frame.h (struct frame): Likewise.
6537 * process.h (struct Lisp_Process): Likewise.
6538 * termhooks.h (struct terminal): Likewise.
6539 * window.c (struct save_window_data, struct saved_window): Likewise.
6540 * window.h (struct window): Likewise.
6541 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6542 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6543 * buffer.c (init_buffer_once): Likewise.
6544 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6546 * process.c (Fformat_network_address): Use local var for size,
6549 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6551 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6552 * data.c (atof): Remove decl; no longer used or needed.
6553 (digit_to_number): Move to lread.c.
6554 (Fstring_to_number): Use new string_to_number function, to be
6555 consistent with how the Lisp reader treats infinities and NaNs.
6556 Do not assume that floating-point numbers represent EMACS_INT
6557 without losing information; this is not true on most 64-bit hosts.
6558 Avoid double-rounding errors, by insisting on integers when
6559 parsing non-base-10 numbers, as the documentation specifies.
6560 * lisp.h (string_to_number): New decl, replacing ...
6561 (isfloat_string): Remove.
6562 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6563 (read1): Do not accept +. and -. as integers; this
6564 appears to have been a coding error. Similarly, do not accept
6565 strings like +-1e0 as floating point numbers. Do not report
6566 overflow for integer overflows unless the base is not 10 which
6567 means we have no simple and reliable way to continue.
6568 Break out the floating-point parsing into a new
6569 function string_to_number, so that Fstring_to_number parses
6570 floating point numbers consistently with the Lisp reader.
6571 (digit_to_number): Move here from data.c. Make it static inline.
6572 (E_CHAR, EXP_INT): Remove, replacing with ...
6573 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6574 (string_to_number): New function, replacing isfloat_string.
6575 This function checks for valid syntax and produces the resulting
6576 Lisp float number too. Rework it so that string-to-number
6577 no longer mishandles examples like "1.0e+". Use strtoumax,
6578 so that overflow for non-base-10 numbers is reported only when
6579 there's no portable and simple way to convert to floating point.
6581 * textprop.c (set_text_properties_1): Rewrite for clarity,
6582 and to avoid GCC warning about integer overflow.
6584 * intervals.h (struct interval): Use EMACS_INT for members
6585 where EMACS_UINT might cause problems. See
6586 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6587 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6588 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6590 (offset_intervals): Tell GCC not to worry about length overflow
6591 when negating a negative length.
6593 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6594 (overrun_check_free): Likewise.
6596 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6597 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6600 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6601 (gnutls_make_error): Rename local to avoid shadowing.
6602 (gnutls_emacs_global_deinit): ifdef out; not used.
6603 (Fgnutls_boot): Use const for pointer to readonly storage.
6604 Comment out unused local. Fix pointer signedness problems.
6606 * lread.c (openp): Don't stuff size_t into an 'int'.
6607 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6608 about possible signed overflow.
6610 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6611 (GDK_KEY_g): Don't define if already defined.
6612 (xg_prepare_tooltip): Avoid pointer signedness problem.
6613 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6615 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6616 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6618 * xfns.c (Fx_window_property): Simplify a bit,
6619 to make a bit faster and to avoid GCC 4.6.0 warning.
6620 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6622 * fns.c (internal_equal): Don't assume size_t fits in int.
6624 * alloc.c (compact_small_strings): Tighten assertion a little.
6626 Replace pEd with more-general pI, and fix some printf arg casts.
6627 * lisp.h (pI): New macro, generalizing old pEd macro to other
6628 conversion specifiers. For example, use "...%"pI"d..." rather
6629 than "...%"pEd"...".
6630 (pEd): Remove. All uses replaced with similar uses of pI.
6631 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6632 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6633 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6634 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6635 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6636 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6637 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6639 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6640 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6641 * print.c (safe_debug_print, print_object): Likewise.
6642 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6644 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6645 avoiding the 0 flag, which is not portable.
6646 * process.c (Fmake_network_process): Use pI to avoid cast.
6647 * region-cache.c (pp_cache): Likewise.
6648 * xdisp.c (decode_mode_spec): Likewise.
6649 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6650 behavior on 64-bit hosts with printf arg.
6651 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6652 (x_stop_queuing_selection_requests): Likewise.
6653 (x_get_window_property): Don't truncate byte count to an 'int'
6656 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6657 here, since it parses constructs like leading '-' and spaces,
6658 which are not wanted; and it overflows with large numbers.
6659 Instead, simply match F[0-9]+, which is what is wanted anyway.
6661 * alloc.c: Remove unportable assumptions about struct layout.
6662 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6663 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6664 (allocate_vectorlike, make_pure_vector): Use the new macros,
6665 plus offsetof, to remove unportable assumptions about struct layout.
6666 These assumptions hold on all porting targets that I know of, but
6667 they are not guaranteed, they're easy to remove, and removing them
6668 makes further changes easier.
6670 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6671 This doesn't fix a bug but makes the code clearer.
6672 (string_overrun_cookie): Now const. Use initializers that
6673 don't formally overflow signed char, to avoid warnings.
6674 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6675 can cause Emacs to crash when string overrun checking is enabled.
6676 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6677 multiple of sizeof (EMACS_INT); it need not be, if
6678 alignof(EMACS_INT) < sizeof (EMACS_INT).
6679 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6681 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6683 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6685 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6687 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6688 supposed to be handshaking. (Bug#8556)
6689 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6691 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6693 * lisp.h (Qdebug): List symbol.
6694 * eval.c (Qdebug): Restore global linkage.
6695 * keyboard.c (debug-on-event): New variable.
6696 (handle_user_signal): Break into debugger when debug-on-event
6697 matches the current signal symbol.
6699 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6701 * alloc.c (check_sblock, check_string_bytes)
6702 (check_string_free_list): Convert to standard C.
6704 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6706 * w32.c (emacs_gnutls_push): Fix typo.
6708 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6710 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6711 "cast to pointer from integer of different size".
6713 Improve doprnt and its use in verror. (Bug#8545)
6714 * doprnt.c (doprnt): Document the set of format control sequences
6715 supported by the function. Use SAFE_ALLOCA instead of always
6718 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6719 is one byte too soon. Don't use xrealloc; instead xfree and
6722 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6724 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6727 * gnutls.c: Renamed global_initialized to
6728 gnutls_global_initialized. Added internals for the
6729 :verify-hostname-error, :verify-error, and :verify-flags
6730 parameters of `gnutls-boot' and documented those parameters in the
6731 docstring. Start callback support.
6732 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6733 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6734 on error. Return error code.
6735 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6736 (emacs_gnutls_read): Likewise.
6737 (Fgnutls_boot): Return handshake error code.
6738 (emacs_gnutls_handle_error): New function.
6739 (wsaerror_to_errno): Likewise.
6741 * w32.h (emacs_gnutls_pull): Add prototype.
6742 (emacs_gnutls_push): Likewise.
6744 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6745 (emacs_gnutls_push): Likewise.
6747 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6749 * process.c (wait_reading_process_output): Check if GnuTLS
6750 buffered some data internally if no FDs are set for TLS
6753 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6754 (LIBS): Link to USER_LIBS.
6755 ($(BLD)/gnutls.$(0)): New target.
6757 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6759 * xdisp.c (handle_single_display_spec): Rename the
6760 display_replaced_before_p argument into display_replaced_p, to
6761 make it consistent with the commentary. Fix typos in the
6764 * textprop.c (syms_of_textprop): Remove dead code.
6765 (copy_text_properties): Delete obsolete commentary about an
6766 interface that was deleted long ago. Fix typos in the description
6769 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6770 to changes in oldXMenu/XMenu.h from 2011-04-16.
6771 <menu_help_message, prev_menu_help_message>: Constify.
6772 (IT_menu_make_room): menu->help_text is now `const char **';
6775 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6776 to changes in oldXMenu/XMenu.h from 2011-04-16.
6777 (struct XMenu): Declare `help_text' `const char **'.
6779 * xfaces.c <Qunspecified>: Make extern again.
6781 * syntax.c: Include sys/types.h before including regex.h, as
6784 * doc.c (get_doc_string): Improve the format passed to `error'.
6786 * doprnt.c (doprnt): Improve commentary.
6788 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6790 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6793 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6794 changes in globals.h immediately force recompilation.
6795 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6796 $(CURDIR)/s/ms-w32.h.
6797 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6799 * character.c (Fchar_direction): Function deleted.
6800 (syms_of_character): Don't defsubr it.
6801 <char-direction-table>: Deleted.
6803 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6805 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6806 * doprnt.c: Include limits.h.
6807 (SIZE_MAX): New macro.
6808 (doprnt): Return a size_t value. 2nd arg is now size_t.
6809 Many local variables are now size_t instead of int or unsigned.
6810 Improve overflow protection. Support `l' modifier for integer
6811 conversions. Support %l conversion. Don't assume an EMACS_INT
6812 argument for integer conversions and for %c.
6814 * lisp.h (doprnt): Restore prototype.
6816 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6819 * Makefile.in (base_obj): Add back doprnt.o.
6821 * deps.mk (doprnt.o): Add back prerequisites.
6822 (callint.o): Depend on character.h.
6824 * eval.c (internal_lisp_condition_case): Include the handler
6825 representation in the error message.
6826 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6827 when breaking from the loop.
6829 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6831 * callint.c (Fcall_interactively): When displaying error message
6832 about invalid control letter, pass the character's codepoint, not
6833 a pointer to its multibyte form. Improve display of the character
6834 in octal and display also its hex code.
6836 * character.c (char_string): Use %x to display the (unsigned)
6837 codepoint of an invalid character, to avoid displaying a bogus
6840 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6841 `error', not SYMBOL_NAME itself.
6843 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6844 character arguments to `error'.
6846 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6847 to `error' in error message about FINAL_CHAR argument. Make sure
6848 FINAL_CHAR is a character, and use %c when it is passed as
6849 argument to `error'.
6851 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6853 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6855 * w32.c: Include <time.h>.
6856 (sys_localtime): New function.
6858 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6860 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6862 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6864 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6866 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6869 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6871 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6872 gl_state.e_property when gl_state.object is Qt.
6874 * insdel.c (make_gap_larger): Remove limitation of buffer size
6877 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6879 * xdisp.c (lookup_glyphless_char_display)
6880 (produce_glyphless_glyph): Handle cons cell entry in
6881 glyphless-char-display.
6882 (Vglyphless_char_display): Document it.
6884 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6885 glyphless-char-display.
6887 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6889 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6891 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6893 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6894 definition for no-X builds.
6896 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6898 Static checks with GCC 4.6.0 and non-default toolkits.
6900 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6902 * process.c (keyboard_bit_set): Define only if SIGIO.
6903 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6904 (send_process): Repair possible setjmp clobbering.
6906 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6908 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6910 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6912 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6913 Define only if needed.
6915 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6916 by pacifying GCC about it. Maybe it's time to retire it?
6917 * xfaces.c (USG, __TIMEVAL__): Likewise.
6919 * dispextern.h (struct redisplay_interface): Rename param
6921 * termhooks.h (struct terminal): Likewise.
6922 * xterm.c (xembed_send_message): Likewise.
6924 * insdel.c (make_gap_smaller): Define only if
6925 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6927 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6930 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6931 so that we aren't warned about unused symbols.
6933 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6935 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6937 * xfns.c (x_real_positions): Mark locals as initialized.
6939 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6941 * xterm.c: Fix problems found by static analysis with other toolkits.
6942 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6943 (x_dispatch_event): Declare static if USE_GTK, and
6944 define if USE_GTK || USE_X_TOOLKIT.
6945 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6946 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6947 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6948 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6950 * xmenu.c (menu_help_callback): Pointer type fixes.
6951 Use const pointers when pointing at readonly data. Avoid pointer
6953 (FALSE): Remove unused macro.
6954 (update_frame_menubar): Remove unused decl.
6956 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6958 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6959 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6960 (single_menu_item): Rename local to avoid shadowing.
6962 * keyboard.c (make_lispy_event): Remove unused local var.
6964 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6965 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6967 * bitmaps: Change bitmaps from unsigned char back to the X11
6968 compatible char. Avoid the old compiler warnings about
6969 out-of-range initializers by using, for example, '\xab' rather
6972 * xgselect.c (xgselect_initialize): Check vs interface
6973 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6975 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6977 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6978 to read-only memory.
6980 * fns.c (vector): Remove; this old hack is no longer needed.
6982 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6984 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6986 * xrdb.c (x_load_resources): Omit unused local.
6988 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6989 (x_window): Rename locals to avoid shadowing.
6990 (USG): Use the kludged USG macro, to pacify gcc.
6992 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6993 (x_term_init): Remove local to avoid shadowing.
6995 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6997 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6998 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7000 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7002 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7004 Fix regex.c, syntax.c and friends for buffers > 2GB.
7005 * syntax.h (struct gl_state_s): Declare character position members
7008 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7010 * textprop.c (verify_interval_modification, interval_of):
7011 Declare arguments EMACS_INT.
7013 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7016 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7018 * indent.c (Fvertical_motion): Local variable it_start is now
7021 * regex.c (re_match, re_match_2, re_match_2_internal)
7022 (bcmp_translate, regcomp, regexec, print_double_string)
7023 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7024 (re_compile_pattern, re_exec): Declare arguments and local
7025 variables `size_t' and `ssize_t' and return values `regoff_t', as
7027 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7028 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7029 <compile_stack_type>: `size' and `avail' are now `size_t'.
7031 * regex.h <regoff_t>: Use ssize_t, not int.
7032 (re_search, re_search_2, re_match, re_match_2): Arguments that
7033 specify buffer/string position and length are now ssize_t and
7034 size_t. Return type is regoff_t.
7036 2011-04-16 Ben Key <bkey76@gmail.com>
7038 * nsfont.m: Fixed bugs in ns_get_family and
7039 ns_descriptor_to_entity that were caused by using free to
7040 deallocate memory blocks that were allocated by xmalloc (via
7041 xstrdup). This caused Emacs to crash when compiled with
7042 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7043 --enable-checking=xmallocoverrun). xfree is now used to
7044 deallocate these memory blocks.
7046 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7048 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7050 emacs_write: Accept and return EMACS_INT for sizes.
7051 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7053 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7054 Accept and return EMACS_INT.
7055 (emacs_gnutls_write): Return the number of bytes written on
7057 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7058 (emacs_read, emacs_write): Remove check for negative size, as the
7059 Emacs source code has been audited now.
7060 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7061 (emacs_read, emacs_write): Use it.
7062 * process.c (send_process): Adjust to the new signatures of
7063 emacs_write and emacs_gnutls_write. Do not attempt to store
7064 a byte offset into an 'int'; it might overflow.
7065 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7067 * sound.c: Don't assume sizes fit in 'int'.
7068 (struct sound_device.period_size, alsa_period_size):
7069 Return EMACS_INT, not int.
7070 (struct sound_device.write, vox_write, alsa_write):
7071 Accept EMACS_INT, not int.
7072 (wav_play, au_play): Use EMACS_INT to store sizes and to
7073 record read return values.
7075 2011-04-15 Ben Key <bkey76@gmail.com>
7077 * keyboard.c (Qundefined): Don't declare static since it is used
7079 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7080 static since they are used in nsfont.m.
7082 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7084 * process.c (Qprocessp): Don't declare static.
7085 * lisp.h (Qprocessp): Declare again.
7087 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7089 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7091 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7093 Improve C-level modularity by making more things 'static'.
7095 Don't publish debugger-only interfaces to other modules.
7096 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7097 (verify_bytepos, count_markers): Move decls to the only modules
7099 * region-cache.h (pp_cache): Likewise.
7100 * window.h (check_all_windows): Likewise.
7101 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7103 * sysdep.c (croak): Now static, if
7104 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7105 * syssignal.h (croak): Declare only if not static.
7107 * alloc.c (refill_memory_reserve): Now static if
7108 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7109 * lisp.h (refill_memory_reserve): Declare only if not static.
7111 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7112 Define only if USE_LUCID.
7114 * xrdb.c (x_customization_string, x_rm_string): Now static.
7116 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7117 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7119 * xdisp.c (draw_row_with_mouse_face): Now static.
7120 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7122 * window.h (check_all_windows): Mark externally visible.
7124 * window.c (window_deletion_count): Now static.
7126 * undo.c: Make symbols static if they're not exported.
7127 (last_undo_buffer, last_boundary_position, pending_boundary):
7130 * textprop.c (interval_insert_behind_hooks): Now static.
7131 (interval_insert_in_front_hooks): Likewise.
7133 * term.c: Make symbols static if they're not exported.
7134 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7135 (max_frame_lines, tty_set_terminal_modes):
7136 (tty_reset_terminal_modes, tty_turn_off_highlight):
7137 (get_tty_terminal): Now static.
7138 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7139 * termhooks.h (term_mouse_moveto): Do not declare if
7141 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7142 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7144 * sysdep.c: Make symbols static if they're not exported.
7145 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7147 (sigprocmask_set, full_mask): Remove; unused.
7148 (wait_debugging): Mark as visible.
7149 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7150 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7152 * syntax.c (syntax_temp): Define only if !__GNUC__.
7154 * sound.c (current_sound_device, current_sound): Now static.
7156 * search.c (searchbufs, searchbuf_head): Now static.
7158 * scroll.c (scroll_cost): Remove; unused.
7159 * dispextern.h (scroll_cost): Remove decl.
7161 * region-cache.h (pp_cache): Mark as externally visible.
7163 * process.c: Make symbols static if they're not exported.
7164 (process_tick, update_tick, create_process, chan_process):
7165 (Vprocess_alist, proc_buffered_char, datagram_access):
7166 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7167 (deactivate_process): Mark defn as static, as well as decl.
7168 * lisp.h (create_process): Remove decl.
7169 * process.h (chan_process, Vprocess_alist): Remove decls.
7171 * print.c: Make symbols static if they're not exported.
7172 (print_depth, new_backquote_output, being_printed, print_buffer):
7173 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7174 (print_interval, print_number_index, initial_stderr_stream):
7176 * lisp.h (Fprinc): Remove decl.
7177 (debug_output_compilation_hack): Mark as externally visible.
7179 * sysdep.c (croak): Move decl from here to syssignal.h.
7180 * syssignal.h (croak): Put it here, so the API can be checked when
7181 'croak' is called from dissociate_if_controlling_tty.
7183 * minibuf.c: Make symbols static if they're not exported.
7184 (minibuf_save_list, choose_minibuf_frame): Now static.
7185 * lisp.h (choose_minibuf_frame): Remove decl.
7187 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7189 * lread.c: Make symbols static if they're not exported.
7190 (read_objects, initial_obarray, oblookup_last_bucket_number):
7192 (make_symbol): Remove; unused.
7193 * lisp.h (initial_obarray, make_symbol): Remove decls.
7195 * keyboard.c: Make symbols static if they're not exported.
7196 (single_kboard, recent_keys_index, total_keys, recent_keys):
7197 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7198 (this_single_command_key_start, echoing, last_auto_save):
7199 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7200 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7201 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7202 (Vlispy_mouse_stem, double_click_count):
7204 (force_auto_save_soon): Define only if SIGDANGER.
7205 (ignore_mouse_drag_p): Now static if
7206 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7207 (print_help): Remove; unused.
7208 (stop_character, last_timer_event): Mark as externally visible.
7209 * keyboard.h (ignore_mouse_drag_p): Declare only if
7210 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7211 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7212 * lisp.h (echoing): Remove decl.
7213 (force_auto_save_soon): Declare only if SIGDANGER.
7214 * xdisp.c (redisplay_window): Simplify code, to make it more
7215 obvious that ignore_mouse_drag_p is not accessed if !defined
7216 USE_GTK && !defined HAVE_NS.
7218 * intervals.c: Make symbols static if they're not exported.
7219 (merge_properties_sticky, merge_interval_right, delete_interval):
7221 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7223 * insdel.c: Make symbols static if they're not exported.
7224 However, leave prepare_to_modify_buffer alone. It's never
7225 called from outside this function, but that appears to be a bug.
7226 (combine_after_change_list, combine_after_change_buffer):
7227 (adjust_after_replace, signal_before_change): Now static.
7228 (adjust_after_replace_noundo): Remove; unused.
7229 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7230 (signal_before_change): Remove decls.
7232 * indent.c (val_compute_motion, val_vmotion): Now static.
7234 * image.c: Make symbols static if they're not exported.
7235 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7237 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7238 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7240 * fringe.c (standard_bitmaps): Now static.
7241 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7243 * frame.c: Make symbols static if they're not exported.
7244 (x_report_frame_params, make_terminal_frame): Now static.
7245 (get_frame_param): Now static, unless HAVE_NS.
7246 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7247 (x_get_resource_string): Remove; not used.
7248 * frame.h (make_terminal_frame, x_report_frame_params):
7249 (x_get_resource_string); Remove decls.
7250 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7251 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7253 * font.c, fontset.c: Make symbols static if they're not exported.
7254 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7255 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7256 * font.c (font_close_object): Now static.
7257 * font.h (font_close_object): Remove.
7258 * fontset.c (FONTSET_OBJLIST): Remove.
7259 (free_realized_fontset) #if-0 the body, which does nothing.
7260 (face_suitable_for_char_p): #if-0, as it's never called.
7261 * fontset.h (face_suitable_for_char_p): Remove decl.
7262 * xfaces.c (face_at_string_position):
7263 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7264 since 0 is always ASCII.
7266 * fns.c (weak_hash_tables): Now static.
7268 * fileio.c: Make symbols static if they're not exported.
7269 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7270 (Vwrite_region_annotation_buffers): Now static.
7272 * eval.c: Make symbols static if they're not exported.
7273 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7274 * lisp.h (backtrace_list): Remove decl.
7276 * emacs.c: Make symbols static if they're not exported.
7277 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7278 (fatal_error_code, fatal_error_signal_hook, standard_args):
7280 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7281 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7282 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7283 * lisp.h (fatal_error_signal_hook): Remove decl.
7284 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7286 * editfns.c: Move a (normally-unused) function to its only use.
7287 * editfns.c, lisp.h (get_operating_system_release): Remove.
7288 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7289 worth the hassle of breaking this out.
7291 * xterm.c: Make symbols static if they're not exported.
7292 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7293 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7294 (x_destroy_window, x_delete_display):
7296 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7297 (x_mouse_leave): Remove; unused.
7298 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7299 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7300 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7302 (x_mouse_leave): Declare only if WINDOWSNT.
7303 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7304 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7307 * ftxfont.c: Make symbols static if they're not exported.
7308 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7310 * font.h (ftxfont_driver): Likewise.
7312 * xfns.c: Make symbols static if they're not exported.
7313 (x_last_font_name, x_display_info_for_name):
7314 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7315 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7316 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7317 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7318 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7319 (last_show_tip_args): Now static.
7320 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7321 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7322 (x_screen_planes): Remove; unused.
7323 * dispextern.h (x_screen_planes): Remove decl.
7325 * dispnew.c: Make symbols static if they're not exported.
7326 * dispextern.h (redraw_garbaged_frames, scrolling):
7327 (increment_row_positions): Remove.
7328 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7329 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7331 (redraw_garbaged_frames): Remove; unused.
7333 * xfaces.c: Make symbols static if they're not exported.
7334 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7336 * xterm.h (defined_color): Remove decls.
7337 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7338 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7339 (menu_face_changed_default, defined_color, free_realized_face):
7340 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7341 (ascii_face_of_lisp_face): Remove; unused.
7343 * xdisp.c: Make symbols static if they're not exported.
7344 * dispextern.h (scratch_glyph_row, window_box_edges):
7345 (glyph_to_pixel_coords, set_cursor_from_row):
7346 (get_next_display_element, set_iterator_to_next):
7347 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7348 (show_mouse_face): Remove decls
7349 * frame.h (message_buf_print): Likewise.
7350 * lisp.h (pop_message, set_message, check_point_in_composition):
7352 * xterm.h (set_vertical_scroll_bar): Likewise.
7353 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7354 (message_buf_print, scratch_glyph_row, displayed_buffer):
7355 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7356 (get_next_display_element, show_mouse_face, window_box_edges):
7357 (frame_to_window_pixel_xy, check_point_in_composition):
7358 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7359 (glyph_to_pixel_coords): Remove; unused.
7361 * dired.c (file_name_completion): Now static.
7363 * dbusbind.c (xd_in_read_queued_messages): Now static.
7365 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7366 * data.c (circular_list_error): Remove.
7368 * commands.h (last_point_position, last_point_position_buffer):
7369 (last_point_position_window): Remove decls.
7370 * keyboard.c: Make these variables static.
7372 * coding.h (coding, code_convert_region, encode_coding_gap):
7374 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7375 (iso_code_class, detect_coding, code_convert_region): Now static.
7376 (encode_coding_gap): Remove; unused.
7378 * chartab.c (chartab_chars, chartab_bits): Now static.
7380 * charset.h (charset_iso_8859_1): Remove decl.
7381 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7384 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7385 * ccl.c (Vccl_program_table): Now static.
7386 (check_ccl_update): Remove; unused.
7388 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7389 * category.h: ... from here.
7390 * category.c (check_category_table, set_category_set): Now static.
7392 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7393 * lisp.h: Remove these decls.
7395 * buffer.c (buffer_count): Remove unused var.
7397 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7398 so that it's not optimized away.
7399 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7400 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7401 exported only to the debugger.
7403 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7404 * atimer.h (run_all_atimers): Remove; not exported.
7406 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7407 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7408 was inaccessible from Lisp.
7409 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7410 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7412 alloc.c: Import and export fewer symbols, and remove unused items.
7413 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7415 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7416 it's not optimized away by whole-program optimization.
7417 (message_enable_multibyte, free_misc): Remove.
7418 (catchlist, handlerlist, mark_backtrace):
7419 Declare only if BYTE_MARK_STACK.
7420 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7421 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7422 (message_enable_multibyte): Remove decl.
7423 (free_misc, interval_free_list, float_block, float_block_index):
7424 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7425 (cons_free_list, last_marked_index):
7427 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7428 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7429 (mark_backtrace): Define only if BYTE_MARK_STACK.
7430 * xdisp.c (message_enable_multibyte): Now static.
7432 Declare Lisp_Object Q* variables to be 'static' if not exported.
7433 This makes it easier for human readers (and static analyzers)
7434 to see whether these variables are used from other modules.
7435 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7436 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7437 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7438 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7439 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7440 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7441 * xmenu.c, xselect.c:
7442 Declare Q* vars static if they are not used in other modules.
7443 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7444 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7445 Remove decls of unexported vars.
7446 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7448 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7450 Make Emacs functions such as Fatom 'static' by default.
7451 This makes it easier for human readers (and static analyzers)
7452 to see whether these functions can be called from other modules.
7453 DEFUN now defines a static function. To make the function external
7454 so that it can be used in other C modules, use the new macro DEFUE.
7455 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7456 (Finit_image_library):
7457 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7458 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7459 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7460 Remove decls, since these functions are now static.
7461 (Funintern, Fget_internal_run_time): New decls, since these functions
7462 were already external.
7464 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7465 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7466 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7467 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7468 * keyboard.c, keymap.c, lread.c:
7469 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7470 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7471 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7472 Mark functions with DEFUE instead of DEFUN,
7473 if they are used in other modules.
7474 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7475 decls for now-static functions.
7476 * buffer.h (Fdelete_overlay): Remove decl.
7477 * callproc.c (Fgetenv_internal): Mark as internal.
7478 * composite.c (Fremove_list_of_text_properties): Remove decl.
7479 (Fcomposition_get_gstring): New forward static decl.
7480 * composite.h (Fcomposite_get_gstring): Remove decl.
7481 * dired.c (Ffile_attributes): New forward static decl.
7482 * doc.c (Fdocumntation_property): New forward static decl.
7483 * eval.c (Ffetch_bytecode): New forward static decl.
7484 (Funintern): Remove extern decl; now in .h file where it belongs.
7485 * fileio.c (Fmake_symbolic_link): New forward static decl.
7486 * image.c (Finit_image_library): New forward static decl.
7487 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7488 * intervals.h (Fprevious_property_change):
7489 (Fremove_list_of_text_properties): Remove decls.
7490 * keyboard.c (Fthis_command_keys): Remove decl.
7491 (Fcommand_execute): New forward static decl.
7492 * keymap.c (Flookup_key): New forward static decl.
7493 (Fcopy_keymap): Now static.
7494 * keymap.h (Flookup_key): Remove decl.
7495 * process.c (Fget_process): New forward static decl.
7496 (Fprocess_datagram_address): Mark as internal.
7497 * syntax.c (Fsyntax_table_p): New forward static decl.
7498 (skip_chars): Remove duplicate decl.
7499 * textprop.c (Fprevious_property_change): New forward static decl.
7500 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7502 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7503 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7505 * editfns.c (Fformat): Remove unreachable code.
7507 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7509 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7512 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7514 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7515 when at ZV. (Bug#8487)
7517 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7519 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7521 * keyboard.c (parse_tool_bar_item): Likewise.
7522 * sound.c (sound_cleanup, alsa_close): Likewise.
7523 * termcap.c (tgetent): Likewise.
7524 * xfns.c (x_default_font_parameter): Likewise.
7525 * xsettings.c (read_and_apply_settings): Likewise.
7527 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7528 (overrun_check_free): Protoize.
7530 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7532 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7533 since callers should never pass a negative size.
7534 Change the signature to match that of plain 'read' and 'write'; see
7535 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7536 * lisp.h: Update prototypes of emacs_write and emacs_read.
7538 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7540 * xdisp.c (redisplay_window): Don't try to determine the character
7541 position of the scroll margin if the window start point w->startp
7542 is outside the buffer's accessible region. (Bug#8468)
7544 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7546 Fix write-region and its subroutines for buffers > 2GB.
7547 * fileio.c (a_write, e_write): Modify declaration of arguments and
7548 local variables to support buffers larger than 2GB.
7549 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7551 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7552 argument, local variables, and return value.
7554 * lisp.h: Update prototypes of emacs_write and emacs_read.
7556 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7558 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7560 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7562 Fix more problems found by GCC 4.6.0's static checks.
7564 * xdisp.c (vmessage): Use a better test for character truncation.
7566 * charset.c (load_charset_map): <, not <=, for optimization,
7567 and to avoid potential problems with integer overflow.
7568 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7569 * casetab.c (set_identity, shuffle): Likewise.
7570 * editfns.c (Fformat): Likewise.
7571 * syntax.c (skip_chars): Likewise.
7573 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7574 This also lets GCC 4.6.0 generate slightly better loop code.
7576 * callint.c (Fcall_interactively): <, not <=, for optimization.
7577 (Fcall_interactively): Count the number of arguments produced,
7578 not the number of arguments given. This is simpler and lets GCC
7579 4.6.0 generate slightly better code.
7581 * ftfont.c: Distingish more carefully between FcChar8 and char.
7582 The previous code passed unsigned char * to a functions like
7583 strlen and xstrcasecmp that expect char *, which does not
7584 conform to the C standard.
7585 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7586 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7587 char * when the C standard requires it.
7589 * keyboard.c (read_char): Remove unused var.
7591 * eval.c: Port to Windows vsnprintf (Bug#8435).
7593 (SIZE_MAX): Define if the headers do not.
7594 (verror): Do not give up if vsnprintf returns a negative count.
7595 Instead, grow the buffer. This ports to Windows vsnprintf, which
7596 does not conform to C99. Problem reported by Eli Zaretskii.
7597 Also, simplify the allocation scheme, by avoiding the need for
7598 calling realloc, and removing the ALLOCATED variable.
7600 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7602 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7603 But keep the doprint source code for now, as we might revamp it
7604 and use it again (Bug#8435).
7605 * lisp.h (doprnt): Remove.
7606 * Makefile.in (base_obj): Remove doprnt.o.
7607 * deps.mk (doprnt.o): Remove.
7609 error: Print 32- and 64-bit integers portably (Bug#8435).
7610 Without this change, on typical 64-bit hosts error ("...%d...", N)
7611 was used to print both 32- and 64-bit integers N, which relied on
7613 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7615 * lisp.h (error, verror): Mark as printf-like functions.
7616 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7617 Report overflow in size calculations when allocating printf buffer.
7618 Do not truncate output string at its first null byte.
7619 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7620 Truncate the output at a character boundary, since vsnprintf does not
7622 * charset.c (check_iso_charset_parameter): Convert internal
7623 character to string before calling 'error', since %c now has the
7625 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7626 overflow when computing char to be passed to 'error'. Do not
7627 pass Lisp_Object to 'error'; pass the integer instead.
7628 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7629 formatted with plain %d.
7631 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7633 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7635 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7637 * xterm.c (x_catch_errors): Remove duplicate declaration.
7639 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7641 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7643 2011-04-10 Jim Meyering <meyering@redhat.com>
7645 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7646 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7647 return ssize_t not "int", and use size_t as the buffer length.
7648 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7649 * gnutls.h: Update declarations.
7650 * process.c (read_process_output): Use ssize_t, to match.
7651 (send_process): Likewise.
7653 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7655 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7657 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7659 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7660 Use unsigned char, to match FcChar8 type definition.
7662 * xterm.c (handle_one_xevent):
7663 * xmenu.c (create_and_show_popup_menu):
7664 * xselect.c (x_decline_selection_request)
7665 (x_reply_selection_request): Avoid type-punned deref of X events.
7667 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7669 Fix some uses of `int' instead of EMACS_INT.
7670 * search.c (string_match_1, fast_string_match)
7671 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7672 (scan_buffer, find_next_newline_no_quit)
7673 (find_before_next_newline, search_command, Freplace_match)
7674 (Fmatch_data): Make some `int' variables be EMACS_INT.
7676 * xdisp.c (display_count_lines): 3rd argument and return value now
7677 EMACS_INT. All callers changed.
7678 (pint2hrstr): Last argument is now EMACS_INT.
7680 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7681 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7682 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7683 (decode_coding_utf_16, decode_coding_emacs_mule)
7684 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7685 (decode_coding_ccl, decode_coding_charset)
7686 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7687 (decode_coding_iso_2022, decode_coding_emacs_mule)
7688 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7689 <char_offset, last_offset>: Declare EMACS_INT.
7690 (encode_coding_utf_8, encode_coding_utf_16)
7691 (encode_coding_emacs_mule, encode_invocation_designation)
7692 (encode_designation_at_bol, encode_coding_iso_2022)
7693 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7694 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7696 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7697 (encode_invocation_designation): Last argument P_NCHARS is now
7699 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7700 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7702 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7705 * ccl.c (Fccl_execute_on_string): Declare some variables
7708 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7710 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7712 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7714 * process.c (Fformat_network_address): Doc fix.
7716 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7718 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7720 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7722 * keyboard.c (read_char): Call Lisp function help-form-show,
7723 instead of using internal_with_output_to_temp_buffer.
7724 (Qhelp_form_show): New var.
7725 (syms_of_keyboard): Use DEFSYM macro.
7727 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7729 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7731 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7733 * process.c (Flist_processes): Remove to Lisp.
7734 (list_processes_1): Delete.
7736 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7738 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7740 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7742 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7744 Fix more problems found by GCC 4.6.0's static checks.
7746 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7748 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7750 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7752 * xdisp.c (vmessage): Mark as a printf-like function.
7754 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7756 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7758 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7759 printf-like functions.
7760 (tiff_load): Add casts to remove these marks before passing them
7761 to system-supplied API.
7763 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7765 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7766 This avoids several warnings with gcc -Wstrict-overflow.
7767 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7768 directly, rather than having caller test rule sign. This avoids
7769 some unnecessary tests.
7770 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7771 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7772 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7774 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7775 (xfont_open): Avoid unnecessary tests.
7777 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7779 * composite.h, composite.c (composition_gstring_put_cache):
7780 Use EMACS_INT, not int, for length.
7782 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7783 breaking out part of COMPOSITION_DECODE_RULE.
7784 (COMPOSITION_DECODE_RULE): Use it.
7785 * composite.c (get_composition_id): Remove unused local vars,
7786 by using the new macro.
7788 * textprop.c (set_text_properties_1): Change while to do-while,
7789 since the condition is always true at first.
7791 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7792 (interval_deletion_adjustment): Return unsigned value.
7795 * process.c (list_processes_1, create_pty, read_process_output):
7796 (exec_sentinel): Remove vars that were set but not used.
7797 (create_pty): Remove unnecessary "volatile"s.
7798 (Fnetwork_interface_info): Avoid possibility of int overflow.
7799 (read_process_output): Do adaptive read buffering even if carryover.
7800 (read_process_output): Simplify nbytes computation if buffered.
7802 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7804 * syntax.c (scan_words): Remove var that was set but not used.
7805 (update_syntax_table): Use unsigned instead of int.
7807 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7808 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7809 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7811 * print.c (print_error_message): Avoid int overflow.
7813 * font.c (font_list_entities): Redo for clarity,
7814 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7816 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7817 (font_score): Avoid potential overflow in diff calculation.
7819 * fns.c (substring_both): Remove var that is set but not used.
7820 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7822 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7824 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7825 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7826 can always succeed if overflow has undefined behavior.
7828 * search.c (boyer_moore, wordify): Remove vars set but not used.
7829 (wordify): Omit three unnecessary tests.
7831 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7832 All callers changed. This avoids the need for an unused var.
7834 * casefiddle.c (casify_region): Remove var that is set but not used.
7836 * dired.c (file_name_completion): Remove var that is set but not used.
7838 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7840 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7841 (Finsert_file_contents): Remove unnecessary code checking fd.
7843 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7844 Check for integer overflow on size calculations.
7846 * buffer.c (Fprevious_overlay_change): Remove var that is set
7849 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7850 Remove vars that are set but not used.
7851 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7852 (timer_check_2): Mark vars as initialized.
7854 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7856 * image.c (lookup_image): Remove var that is set but not used.
7857 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7859 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7860 that are set but not used.
7862 * xfns.c (make_invisible_cursor): Don't return garbage
7863 if XCreateBitmapFromData fails (Bug#8410).
7865 * xselect.c (x_get_local_selection, x_handle_property_notify):
7866 Remove vars that are set but not used.
7868 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7869 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7871 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7872 Remove var that is set but not used.
7873 (scroll_bar_windows_size): Now size_t, not int.
7874 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7877 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7878 (map_tty_color) [!defined MSDOS]: Likewise.
7880 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7882 * coding.c: Remove vars that are set but not used.
7883 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7884 All callers changed.
7885 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7886 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7887 (decode_coding_charset): Remove vars that are set but not used.
7889 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7890 that is set but not used.
7892 * print.c (print_object): Remove var that is set but not used.
7894 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7895 The gnulib version avoids calling malloc in the usual case,
7896 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7897 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7898 * filelock.c (current_lock_owner): Likewise.
7899 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7900 * sysdep.c: Include allocator.h, careadlinkat.h.
7901 (emacs_no_realloc_allocator): New static constant.
7902 (emacs_readlink): New function.
7903 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7904 ../lib/careadlinkat.h.
7906 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7908 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7909 first non-nil return value).
7911 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7913 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7914 if not defined (Bug#8403).
7916 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7918 * xdisp.c (display_count_lines): Remove parameter `start',
7919 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7920 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7921 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7922 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7923 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7924 and thereabouts. All callers changed.
7925 (get_per_char_metric): Remove parameter `f', unused since
7926 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7928 2011-04-02 Jim Meyering <meyering@redhat.com>
7930 do not dereference NULL upon failed strdup
7931 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7932 (ns_get_family): Likewise.
7934 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7936 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7938 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7940 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7943 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7945 Add lexical binding.
7947 * window.c (Ftemp_output_buffer_show): New fun.
7948 (Fsave_window_excursion):
7949 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7951 * lread.c (lisp_file_lexically_bound_p): New function.
7952 (Fload): Bind Qlexical_binding.
7953 (readevalloop): Remove `evalfun' arg.
7954 Bind Qinternal_interpreter_environment.
7955 (Feval_buffer): Bind Qlexical_binding.
7956 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7958 (syms_of_lread): Declare `lexical-binding'.
7960 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7962 * keyboard.c (eval_dyn): New fun.
7963 (menu_item_eval_property): Use it.
7965 * image.c (parse_image_spec): Use Ffunctionp.
7967 * fns.c (concat, mapcar1): Accept byte-code-functions.
7969 * eval.c (Fsetq): Handle lexical vars.
7970 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7971 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7972 (FletX, Flet): Obey lexical binding.
7973 (Fcommandp): Handle closures.
7974 (Feval): New `lexical' arg.
7975 (eval_sub): New function extracted from Feval. Use it almost
7976 everywhere where Feval was used. Look up vars in lexical env.
7978 (Ffunctionp): Move from subr.el.
7979 (Ffuncall): Handle closures.
7980 (apply_lambda): Remove `eval_flags'.
7981 (funcall_lambda): Handle closures and new byte-code-functions.
7982 (Fspecial_variable_p): New function.
7983 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7984 but without exporting it to Lisp.
7986 * doc.c (Fdocumentation, store_function_docstring):
7987 * data.c (Finteractive_form): Handle closures.
7989 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7992 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7994 (exec_byte_code): New function extracted from Fbyte_code to handle new
7995 calling convention for byte-code-functions. Add new byte-codes.
7997 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7999 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8001 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8003 * xdisp.c (redisplay_internal): Fix prototype.
8005 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8007 * xdisp.c (SCROLL_LIMIT): New macro.
8008 (try_scrolling): Use it when setting scroll_limit.
8009 Limit scrolling to 100 screen lines.
8010 (redisplay_window): Even when falling back on "recentering",
8011 position point in the window according to scroll-conservatively,
8012 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8014 (try_scrolling): When point is above the window, allow searching
8015 as far as scroll_max, or one screenful, to compute vertical
8016 distance from PT to the scroll margin position. This prevents
8017 try_scrolling from unnecessarily failing when
8018 scroll-conservatively is set to a value slightly larger than the
8019 window height. Clean up the case of PT below the margin at bottom
8020 of window: scroll_max can no longer be INT_MAX. When aggressive
8021 scrolling is in use, don't let point enter the opposite scroll
8022 margin as result of the scroll.
8023 (syms_of_xdisp) <scroll-conservatively>: Document the
8024 threshold of 100 lines for never-recentering scrolling.
8026 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8028 * dispextern.h (move_it_by_lines):
8029 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8030 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8031 (message_log_check_duplicate): Remove parameters `prev_bol' and
8032 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8033 (redisplay_internal): Remove parameter `preserve_echo_area',
8034 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8036 * indent.c (Fvertical_motion):
8037 * window.c (window_scroll_pixel_based, Frecenter):
8038 Don't pass `need_y_p' to `move_it_by_lines'.
8040 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8042 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8043 steal a few bits to be more compact.
8044 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8045 Remove unneeded casts.
8047 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8049 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8051 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8052 binding" message (bug#7967).
8054 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8056 Fix more problems found by GCC 4.6.0's static checks.
8058 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8059 Remove unused local var.
8061 * editfns.c (Fmessage_box): Remove unused local var.
8063 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8064 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8065 Omit unused local vars.
8066 * window.c (shrink_windows): Omit unused local var.
8067 * menu.c (digest_single_submenu): Omit unused local var.
8068 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8069 Omit unused local var.
8071 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8072 Don't assume string length fits in int.
8073 (keyremap_step, read_key_sequence): Use size_t for sizes.
8074 (read_key_sequence): Don't check last_real_key_start redundantly.
8076 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8077 instead of alloca (Bug#8344).
8079 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8080 (Fbacktrace_frame): Don't assume nframes fits in int.
8082 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8084 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8087 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8089 * cm.c (calccost): Turn while-do into do-while, for clarity.
8091 * keyboard.c (syms_of_keyboard): Use the same style as later
8092 in this function when indexing through an array. This also
8093 works around GCC bug 48267.
8095 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8097 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8099 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8100 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8102 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8103 This avoids undefined behavior on integer overflow, and is a bit
8104 more convenient anyway since it is compared to a size_t variable.
8106 Variadic C functions now count arguments with size_t, not int.
8107 This avoids an unnecessary limitation on 64-bit machines, which
8108 caused (substring ...) to crash on large vectors (Bug#8344).
8109 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8110 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8111 All variadic functions and their callers changed accordingly.
8112 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8113 * data.c (arith_driver, float_arith_driver): Likewise.
8114 * editfns.c (general_insert_function): Likewise.
8115 * eval.c (struct backtrace.nargs, interactive_p)
8116 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8117 (funcall_lambda, mark_backtrace): Likewise.
8118 * fns.c (concat): Likewise.
8119 * frame.c (x_set_frame_parameters): Likewise.
8120 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8121 0 if not found, not -1. All callers changed.
8123 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8124 (stack_copy_size): Now size_t, not int.
8125 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8127 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8129 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8130 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8131 All callers changed.
8133 * lisp.h (multibyte_char_to_unibyte):
8134 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8135 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8136 * character.h (CHAR_TO_BYTE8):
8137 * cmds.c (internal_self_insert):
8138 * editfns.c (general_insert_function):
8139 * keymap.c (push_key_description):
8140 * search.c (Freplace_match):
8141 * xdisp.c (message_dolog, set_message_1): All callers changed.
8143 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8145 * keyboard.c (safe_run_hook_funcall): New function.
8146 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8147 don't set the hook to nil, but remove the offending function instead.
8148 (Qcommand_hook_internal): Remove, unused.
8149 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8150 Vcommand_hook_internal.
8152 * eval.c (enum run_hooks_condition): Remove.
8153 (funcall_nil, funcall_not): New functions.
8154 (run_hook_with_args): Call each function through a `funcall' argument.
8155 Remove `cond' argument, now redundant.
8156 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8157 (Frun_hook_with_args_until_failure): Adjust accordingly.
8158 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8160 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8162 * dispextern.h (string_buffer_position): Remove declaration.
8164 * print.c (strout): Remove parameter `multibyte', unused since
8165 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8167 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8168 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8169 All callers changed.
8171 * w32.c (_wsa_errlist): Use braces for struct initializers.
8173 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8174 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8175 All callers changed.
8176 (string_buffer_position): Likewise. Also, make static (it's never
8177 used outside xdisp.c).
8178 (cursor_row_p): Remove parameter `w', unused since
8179 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8180 (decode_mode_spec): Remove parameter `precision', introduced during
8181 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8182 All callers changed.
8184 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8186 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8188 2011-03-27 Anders Lindgren <andlind@gmail.com>
8190 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8191 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8192 (ns_update_auto_hide_menu_bar): New functions.
8193 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8194 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8195 ns_constrain_all_frames.
8196 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8197 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8199 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8201 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8203 2011-03-27 Glenn Morris <rgm@gnu.org>
8205 * syssignal.h: Replace RETSIGTYPE with void.
8206 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8207 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8208 Replace SIGTYPE with void everywhere.
8209 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8210 * s/template.h (SIGTYPE): Remove commented out definition.
8212 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8214 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8215 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8217 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8219 * w32.c (read_unc_volume): Use parameter `henum', instead of
8220 global variable `wget_enum_handle'.
8222 * keymap.c (describe_vector): Remove parameters `indices' and
8223 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8224 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8226 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8228 * keyboard.c (timer_check): Remove parameter `do_it_now',
8229 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8230 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8231 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8233 * keyboard.c (read_char):
8234 * w32menu.c (w32_menu_display_help):
8235 * xmenu.c (show_help_event, menu_help_callback):
8236 Adjust calls to `show_help_echo'.
8238 * gtkutil.c (xg_maybe_add_timer):
8239 * keyboard.c (readable_events):
8240 * process.c (wait_reading_process_output):
8241 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8243 * insdel.c (adjust_markers_gap_motion):
8244 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8245 (gap_left, gap_right): Don't call it.
8247 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8249 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8250 incurred during fontification.
8252 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8254 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8255 (DEFVAR_PER_BUFFER): Don't pass it.
8257 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8258 (scrolling_window): Don't pass it.
8260 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8262 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8264 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8266 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8267 of variables specific to SELinux and computation of `encoded_absname'.
8269 * image.c (XPutPixel): Remove unused variable `height'.
8271 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8273 * unexw32.c (get_section_info): Remove unused variable `section'.
8275 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8276 (system_process_attributes): Remove unused variable `sess'.
8277 (sys_read): Remove unused variable `err'.
8279 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8280 (w32_wnd_proc): Remove unused variable `isdead'.
8281 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8282 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8283 (x_create_tip_frame): Remove unused variable `tem'.
8285 * w32inevt.c (w32_console_read_socket):
8286 Remove unused variable `no_events'.
8288 * w32term.c (x_draw_composite_glyph_string_foreground):
8289 Remove unused variable `width'.
8291 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8293 * w32term.c (x_set_glyph_string_clipping):
8294 Don't pass uninitialized region to CombineRgn.
8296 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8298 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8299 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8300 (Fx_close_connection): Remove unused variable `i'.
8302 * w32font.c (w32font_draw): Return number of glyphs.
8303 (w32font_open_internal): Remove unused variable `i'.
8304 (w32font_driver): Add missing initializer.
8306 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8307 (fill_in_menu): Remove unused variable `items_added'.
8309 * w32term.c (last_mouse_press_frame): Remove static global variable.
8310 (w32_clip_to_row): Remove unused variable `f'.
8311 (x_delete_terminal): Remove unused variable `i'.
8313 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8314 (NOTHING): Remove unused static global variable.
8315 (uniscribe_check_otf): Remove unused variable `table'.
8316 (uniscribe_font_driver): Add missing initializers.
8318 2011-03-23 Julien Danjou <julien@danjou.info>
8320 * term.c (Fsuspend_tty, Fresume_tty):
8321 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8322 * window.c (temp_output_buffer_show):
8323 * insdel.c (signal_before_change):
8324 * frame.c (Fhandle_switch_frame):
8325 * fileio.c (Fdo_auto_save):
8326 * emacs.c (Fkill_emacs):
8327 * editfns.c (save_excursion_restore):
8328 * cmds.c (internal_self_insert):
8329 * callint.c (Fcall_interactively):
8330 * buffer.c (Fkill_all_local_variables):
8331 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8333 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8334 unconditionally since it does the check itself.
8336 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8338 Fix more problems found by GCC 4.5.2's static checks.
8340 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8341 the first time through the loop, since we know p0 < p1 then.
8342 This also avoids a gcc -Wstrict-overflow warning.
8344 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8345 leading to a memory leak, possible in functions like
8346 load_charset_map_from_file that can allocate an unbounded number
8347 of objects (Bug#8318).
8349 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8350 that could (at least in theory) be that large.
8352 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8353 This is less likely to overflow, and avoids undefined behavior if
8354 overflow does occur. All callers changed. Use strtoul to scan
8355 for the unsigned long integer.
8356 (pint2hrstr): Simplify and tune code slightly.
8357 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8359 * scroll.c (do_scrolling): Work around GCC bug 48228.
8360 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8362 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8363 This also avoids a warning with gcc -Wstrict-overflow.
8364 (validate_x_resource_name): Simplify count usage.
8365 This also avoids a warning with gcc -Wstrict-overflow.
8367 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8370 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8372 * process.c (Fmake_network_process): Use socklen_t, not int,
8373 where POSIX says socklen_t is required in portable programs.
8374 This fixes a porting bug on hosts like 64-bit HP-UX, where
8375 socklen_t is wider than int (Bug#8277).
8376 (Fmake_network_process, server_accept_connection):
8377 (wait_reading_process_output, read_process_output):
8380 * process.c: Rename or move locals to avoid shadowing.
8381 (list_processes_1, Fmake_network_process):
8382 (read_process_output_error_handler, exec_sentinel_error_handler):
8383 Rename or move locals.
8384 (Fmake_network_process): Define label "retry_connect" only if needed.
8385 (Fnetwork_interface_info): Fix pointer signedness.
8386 (process_send_signal): Add cast to avoid pointer signedness problem.
8387 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8388 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8390 Make tparam.h and terminfo.c consistent.
8391 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8392 Include tparam.h instead, since it declares them.
8393 * cm.h (PC): Remove extern decl; tparam.h now does this.
8394 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8395 * terminfo.c: Include tparam.h, to check interfaces.
8396 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8397 (tparam): Adjust signature to match interface in tparam.h;
8398 this removes some undefined behavior. Check that outstring and len
8399 are zero, which they always are with Emacs.
8400 * tparam.h (PC, BC, UP): New extern decls.
8402 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8403 (xftfont_open): Rename locals to avoid shadowing.
8405 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8406 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8407 (OTF_TAG_SYM): Omit macro if not needed.
8408 (ftfont_list): Remove unused local.
8409 (get_adstyle_property, ftfont_pattern_entity):
8410 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8411 Rename locals to avoid shadowing.
8413 * xfont.c (xfont_list_family): Mark var as initialized.
8415 * xml.c (make_dom): Now static.
8417 * composite.c (composition_compute_stop_pos): Rename local to
8419 (composition_reseat_it): Remove unused locals.
8420 (find_automatic_composition, composition_adjust_point): Likewise.
8421 (composition_update_it): Mark var as initialized.
8422 (find_automatic_composition): Mark vars as initialized,
8423 with a FIXME (Bug#8290).
8425 character.h: Rename locals to avoid shadowing.
8426 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8427 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8428 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8429 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8432 * textprop.c (property_change_between_p): Remove; unused.
8434 * intervals.c (interval_start_pos): Now static.
8436 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8438 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8439 Rename locals to avoid shadowing.
8441 * sound.c (wav_play, au_play, Fplay_sound_internal):
8442 Fix pointer signedness.
8443 (alsa_choose_format): Remove unused local var.
8444 (wav_play): Initialize a variable to 0, to prevent undefined
8445 behavior (Bug#8278).
8447 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8449 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8451 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8452 clobbering (Bug#8298).
8453 * sysdep.c (sys_subshell): Likewise.
8454 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8456 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8457 This should get cleaned up, so that child_setup has the
8458 same signature on all platforms.
8460 * callproc.c (call_process_cleanup): Now static.
8461 (relocate_fd): Rename locals to avoid shadowing.
8463 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8465 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8466 not to be necessary, and produces flickering.
8468 2011-03-20 Glenn Morris <rgm@gnu.org>
8470 * config.in: Remove file.
8472 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8474 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8475 are now in src/globals.h.
8476 (syms_of_minibuf): Remove spurious & from previous change.
8478 2011-03-20 Leo Liu <sdl.web@gmail.com>
8480 * minibuf.c (completing-read-function): New variable.
8481 (completing-read-default): Rename from completing-read.
8482 (completing-read): Call completing-read-function.
8484 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8486 * xfaces.c (Fx_load_color_file):
8487 Read color file from absolute filename (bug#8250).
8489 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8491 * makefile.w32-in: Update dependencies.
8493 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8495 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8497 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8499 Fix more problems found by GCC 4.5.2's static checks.
8501 * process.c (make_serial_process_unwind, send_process_trap):
8502 (sigchld_handler): Now static.
8504 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8505 That way, the code declares only the vars that it needs.
8506 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8507 * s/cygwin.h (PTY_ITERATION): Likewise.
8508 * s/darwin.h (PTY_ITERATION): Likewise.
8509 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8511 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8512 * process.c (allocate_pty): Don't declare stb unless it's needed.
8514 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8515 (CONSTANTLIM): Remove; unused.
8516 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8517 Define only if needed.
8519 * unexelf.c (unexec): Name an expression,
8520 to avoid gcc -Wbad-function-cast warning.
8521 Use a different way to cause a compilation error if anyone uses
8522 n rather than nn, a way that does not involve shadowing.
8523 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8525 * deps.mk (unexalpha.o): Remove; unused.
8527 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8528 * unexec.h: New file.
8529 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8530 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8532 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8533 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8534 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8535 Change as necessary to match prototype in unexec.h.
8537 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8539 (back_comment, skip_chars): Mark vars as initialized.
8541 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8542 Rename locals to avoid shadowing.
8544 * lread.c (read1): Rewrite so as not to use empty "else".
8545 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8547 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8549 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8550 warning when compiling print.c.
8552 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8553 instead of using an uninitialized var.
8554 (font_sort_entities): Mark var as initialized.
8556 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8558 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8559 pointers to constants.
8560 (font_parse_fcname): Remove unused vars.
8561 (font_delete_unmatched): Now static.
8562 (font_get_spec): Remove; unused.
8563 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8564 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8565 Rename or move locals to avoid shadowing.
8567 * fns.c (require_nesting_list, require_unwind): Now static.
8568 (Ffillarray): Rename locals to avoid shadowing.
8570 * floatfns.c (domain_error2): Define only if needed.
8571 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8573 * alloc.c (mark_backtrace): Move decl from here ...
8574 * lisp.h: ... to here, so that it can be checked.
8576 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8577 (Fdefvar): Rewrite so as not to use empty "else".
8578 (lisp_indirect_variable): Name an expression,
8579 to avoid gcc -Wbad-function-cast warning.
8580 (Fdefvar): Rename locals to avoid shadowing.
8582 * callint.c (quotify_arg, quotify_args): Now static.
8583 (Fcall_interactively): Rename locals to avoid shadowing.
8584 Use const pointer when appropriate.
8586 * lisp.h (get_system_name, get_operating_system_release):
8587 Move decls here, to check interfaces.
8588 * process.c (get_operating_system_release): Move decl to lisp.h.
8589 * xrdb.c (get_system_name): Likewise.
8590 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8591 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8592 some of which prompt warnings from gcc -Wbad-function-cast.
8593 (Fformat_time_string, Fencode_time, Finsert_char):
8594 (Ftranslate_region_internal, Fformat):
8595 Rename or remove local vars to avoid shadowing.
8596 (Ftranslate_region_internal): Mark var as initialized.
8598 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8601 * lisp.h (eassert): Check that the argument compiles, even if
8602 ENABLE_CHECKING is not defined.
8604 * data.c (Findirect_variable): Name an expression, to avoid
8605 gcc -Wbad-function-cast warning.
8606 (default_value, arithcompare, arith_driver, arith_error): Now static.
8607 (store_symval_forwarding): Rename local to avoid shadowing.
8608 (Fmake_variable_buffer_local, Fmake_local_variable):
8609 Mark variables as initialized.
8610 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8612 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8613 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8614 Rename locals to avoid shadowing.
8615 (mark_stack): Move local variables into the #ifdef region where
8617 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8618 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8620 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8621 (GC_STRING_CHARS): Remove; not used.
8622 (Fmemory_limit): Cast sbrk's returned value to char *.
8624 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8625 avoids undefined behavior in theory.
8627 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8629 Use functions, not macros, for up- and down-casing (Bug#8254).
8630 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8631 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8632 to use the following functions instead of these macros.
8633 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8634 EMACS_INT, since callers assume the returned value fits in int.
8635 (upcase1): Likewise, for UPCASE_TABLE.
8636 (uppercasep, lowercasep, upcase): New static inline functions.
8637 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8638 the race-condition problem in the old DOWNCASE.
8640 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8641 Rename locals to avoid shadowing.
8642 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8643 (regex_compile, re_search_2, re_match_2_internal):
8644 Remove unused local vars.
8645 (FREE_VAR): Rewrite so as not to use empty "else",
8646 which gcc can warn about.
8647 (regex_compile, re_match_2_internal): Mark locals as initialized.
8648 (RETALLOC_IF): Define only if needed.
8649 (WORDCHAR_P): Likewise. This one is never needed, but is used
8650 only in a comment talking about a compiler bug, so put inside
8651 the #if 0 of that comment.
8652 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8653 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8656 * search.c (boyer_moore): Rename locals to avoid shadowing.
8657 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8658 (PREV_CHAR_BOUNDARY): Likewise.
8660 * search.c (simple_search): Remove unused var.
8662 * dired.c (compile_pattern): Move decl from here ...
8663 * lisp.h: ... to here, so that it can be checked.
8664 (struct re_registers): New forward decl.
8666 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8668 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8670 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8671 Rename locals to avoid shadowing.
8672 (Fvertical_motion): Mark locals as initialized.
8674 * casefiddle.c (casify_object, casify_region): Now static.
8675 (casify_region): Mark local as initialized.
8677 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8679 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8680 New macros, so that the caller can use some names other than
8681 gcpro1, gcpro2, etc.
8682 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8684 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8685 argument, for consistency with GCPRO2_VAR, etc: it is now the
8686 prefix of the variable, not the variable itself. All uses
8688 * dired.c (directory_files_internal, file_name_completion):
8689 Rename locals to avoid shadowing.
8691 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8692 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8693 dired.c's scmp function, had undefined behavior.
8694 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8695 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8696 * buffer.h: ... to here, because these macros use current_buffer,
8697 and the new implementation with inline functions needs to have
8698 current_buffer in scope now, rather than later when the macros
8700 (downcase, upcase1): New static inline functions.
8701 (DOWNCASE, UPCASE1): Reimplement using these functions.
8702 This avoids undefined behavior in expressions like
8703 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8704 from race conditions in accessing the global variables
8705 case_temp1 and case_temp2.
8706 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8707 * lisp.h (case_temp1, case_temp2): Remove their decls.
8708 * character.h (ASCII_CHAR_P): Move from here ...
8709 * lisp.h: ... to here, so that the inline functions mentioned
8712 * dired.c (directory_files_internal_unwind): Now static.
8714 * fileio.c (file_name_as_directory, directory_file_name):
8715 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8717 (file_name_as_directory): Use const pointers when appropriate.
8718 (Fexpand_file_name): Likewise. In particular, newdir might
8719 point at constant storage, so make it a const pointer.
8720 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8721 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8723 (Fset_file_times, Finsert_file_contents, auto_save_error):
8724 Rename locals to avoid shadowing.
8726 * minibuf.c (choose_minibuf_frame_1): Now static.
8727 (Ftry_completion, Fall_completions): Rename or remove locals
8730 * marker.c (bytepos_to_charpos): Remove; unused.
8732 * lisp.h (verify_bytepos, count_markers): New decls,
8733 so that gcc does not warn that these functions aren't declared.
8735 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8736 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8737 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8738 (copy_text): Remove unused local var.
8740 * filelock.c (within_one_second): Now static.
8741 (lock_file_1): Rename local to avoid shadowing.
8743 * buffer.c (fix_overlays_before): Mark locals as initialized.
8744 (fix_start_end_in_overlays): Likewise. This function should be
8745 simplified by using pointers-to-pointers, but that's a different
8747 (switch_to_buffer_1): Now static.
8748 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8749 (report_overlay_modification): Rename locals to avoid shadowing.
8751 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8752 Fix pointer signedness issue.
8753 (sys_subshell): Mark local as volatile if checking for lint,
8754 to suppress a gcc -Wclobbered warning that does not seem to be right.
8755 (MAXPATHLEN): Define only if needed.
8757 * process.c (serial_open, serial_configure): Move decls from here ...
8758 * systty.h: ... to here, so that they can be checked.
8760 * fns.c (get_random, seed_random): Move extern decls from here ...
8761 * lisp.h: ... to here, so that they can be checked.
8763 * sysdep.c (reset_io): Now static.
8764 (wait_for_termination_signal): Remove; unused.
8766 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8767 (copy_keymap_item, append_key, push_text_char_description):
8769 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8770 (DENSE_TABLE_SIZE): Remove; unused.
8771 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8772 (describe_map_tree):
8773 Rename locals to avoid shadowing.
8775 * keyboard.c: Declare functions static if they are not used elsewhere.
8776 (echo_char, echo_dash, cmd_error, top_level_2):
8777 (poll_for_input, handle_async_input): Now static.
8778 (read_char, kbd_buffer_get_event, make_lispy_position):
8779 (make_lispy_event, make_lispy_movement, apply_modifiers):
8780 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8781 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8782 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8783 (read_key_sequence, read_char): Mark locals as initialized.
8784 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8786 * keyboard.h (make_ctrl_char): New decl.
8787 (mark_kboards): Move decl here ...
8788 * alloc.c (mark_kboards): ... from here.
8790 * lisp.h (force_auto_save_soon): New decl.
8792 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8793 (DEFINE_DUMMY_FUNCTION): New macro.
8794 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8796 (main): Add casts to avoid warnings
8797 if GCC considers string literals to be constants.
8799 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8801 * dbusbind.c: Pointer signedness fixes.
8802 (xd_signature, xd_append_arg, xd_initialize):
8803 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8804 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8805 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8806 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8808 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8809 if GCC considers string literals to be constants.
8810 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8812 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8814 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8815 (print_preprocess, print_object): New macro to fix last change.
8817 * print.c (print_preprocess): Don't forget font objects.
8819 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8821 * emacs.c (USAGE3): Doc fixes.
8823 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8825 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8828 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8830 * lisp.h (VWindow_system, Qfile_name_history):
8831 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8832 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8833 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8835 * w32select.c: Don't #include "keyboard.h".
8836 (run_protected): Add extern declaration for waiting_for_input.
8838 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8839 * w32console.c (detect_input_pending, read_input_pending)
8840 (encode_terminal_code):
8841 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8842 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8843 (w32_system_caret_y, Qfile_name_history):
8844 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8845 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8846 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8847 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8848 * w32proc.c (Qlocal, report_file_error):
8849 * w32term.c (Vwindow_system, updating_frame):
8850 * w32uniscribe.c (initialized, uniscribe_font_driver):
8851 Remove unneeded extern declarations.
8853 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8855 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8857 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8859 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8860 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8861 These macros can no longer be used for assignment.
8863 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8864 Assign struct members directly, instead of using BUF_BEGV etc.
8865 (record_buffer_markers, fetch_buffer_markers): New functions for
8866 recording and fetching special buffer markers.
8867 (set_buffer_internal_1, set_buffer_temp): Use them.
8869 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8871 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8873 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8874 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8876 * xdisp.c (hscroll_window_tree):
8877 (reconsider_clip_changes): Use PT instead of BUF_PT.
8879 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8881 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8882 $(EMACS_ROOT)/lib/intprops.h.
8884 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8886 Fix more problems found by GCC 4.5.2's static checks.
8888 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8889 to unsigned char * to avoid compiler diagnostic.
8890 (xg_free_frame_widgets): Make it clear that a local variable is
8891 needed only if USE_GTK_TOOLTIP.
8892 (gdk_window_get_screen): Make it clear that this macro is needed
8893 only if USE_GTK_TOOLTIP.
8894 (int_gtk_range_get_value): New function, which avoids a diagnostic
8895 from gcc -Wbad-function-cast.
8896 (xg_set_toolkit_scroll_bar_thumb): Use it.
8897 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8898 diagnostic from gcc -Wbad-function-cast.
8899 (get_utf8_string, xg_get_file_with_chooser):
8900 Rename locals to avoid shadowing.
8901 (create_dialog): Move locals to avoid shadowing.
8903 * xgselect.c (xg_select): Remove unused var.
8905 * image.c (four_corners_best): Mark locals as initialized.
8906 (gif_load): Initialize transparent_p to zero (Bug#8238).
8907 Mark another local as initialized.
8908 (my_png_error, my_error_exit): Mark with NO_RETURN.
8910 * image.c (clear_image_cache): Now static.
8911 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8912 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8913 (x_edge_detection): Remove unnecessary cast that
8914 gcc -Wbad-function-cast diagnoses.
8915 (gif_load): Fix pointer signedness.
8916 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8917 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8919 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8921 Improve quality of tests for time stamp overflow.
8922 For example, without this patch (encode-time 0 0 0 1 1
8923 1152921504606846976) returns the obviously-bogus value (-948597
8924 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8925 reports time overflow. See
8926 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8927 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8928 * editfns.c: Include limits.h and intprops.h.
8929 (TIME_T_MIN, TIME_T_MAX): New macros.
8930 (time_overflow): Move earlier, to before first use.
8931 (hi_time, lo_time): New functions, for an accurate test for
8933 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8934 (Fget_internal_run_time): Don't assume time_t fits in int.
8935 (make_time): Use list2 instead of Fcons twice.
8936 (Fdecode_time): More accurate test for out-of-range times.
8937 (check_tm_member): New function.
8938 (Fencode_time): Use it, to test for out-of-range times.
8939 (lisp_time_argument): Don't rely on undefined left-shift and
8940 right-shift behavior when checking for time stamp overflow.
8942 * editfns.c (time_overflow): New function, refactoring common code.
8943 (Fformat_time_string, Fdecode_time, Fencode_time):
8944 (Fcurrent_time_string): Use it.
8946 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8947 * dired.c (make_time): Move to ...
8948 * editfns.c (make_time): ... here.
8949 * systime.h: Note the move.
8951 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8953 * fringe.c (update_window_fringes): Remove unused variables.
8955 * unexmacosx.c (copy_data_segment): Also copy __got section.
8958 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8960 * termcap.c [MSDOS]: Include "msdos.h".
8961 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8962 Constify `char *' arguments and their references according to
8963 prototypes in tparam.h.
8965 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8967 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8968 Adapt all references accordingly.
8970 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8972 2011-03-11 Tom Tromey <tromey@redhat.com>
8974 * buffer.c (syms_of_buffer): Remove obsolete comment.
8976 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8978 * termhooks.h (encode_terminal_code): Declare prototype.
8980 * msdos.c (encode_terminal_code): Don't declare prototype.
8982 * term.c (encode_terminal_code): Now external again, used by
8983 w32console.c and msdos.c.
8985 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8986 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8988 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8990 Fix some minor problems found by GCC 4.5.2's static checks.
8992 * fringe.c (update_window_fringes): Mark locals as initialized
8994 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8996 * alloc.c (mark_fringe_data): Move decl from here ...
8997 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8998 to check its interface.
8999 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9001 * fontset.c (free_realized_fontset): Now static.
9002 (Fset_fontset_font): Rename local to avoid shadowing.
9003 (fontset_font): Mark local as initialized.
9004 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9006 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9008 * xselect.c (x_disown_buffer_selections): Remove; not used.
9009 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9010 (x_own_selection, Fx_disown_selection_internal): Rename locals
9012 (x_handle_dnd_message): Remove local to avoid shadowing.
9014 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9015 so that the caller can use some name other than gcpro1.
9016 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9017 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9018 (Fx_backspace_delete_keys_p):
9019 Use them to avoid shadowing, and rename vars to avoid shadowing.
9020 (x_decode_color, x_set_name, x_window): Now static.
9021 (Fx_create_frame): Add braces to silence GCC warning.
9022 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9023 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9024 Remove unused locals.
9025 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9026 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9027 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9030 * xterm.h (x_mouse_leave): New decl.
9032 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9033 Remove unused functions.
9034 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9035 (x_calc_absolute_position): Now static.
9036 (XTread_socket): Don't define label "out" unless it's used.
9037 Don't declare local "event" unless it's used.
9038 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9039 unless they are used.
9040 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9041 (x_fatal_error_signal): Remove; not used.
9042 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9043 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9044 (x_error_catcher, x_connection_closed, x_error_handler):
9045 (x_error_quitter, xembed_send_message, x_iconify_frame):
9046 (my_log_handler): Rename locals to avoid shadowing.
9047 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9048 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9050 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9051 Rename or move locals to avoid shadowing.
9052 (tty_defined_color, merge_face_heights): Now static.
9053 (free_realized_faces_for_fontset): Remove; not used.
9054 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9055 does not deduce is never used uninitialized.
9056 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9057 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9059 * terminal.c (store_terminal_param): Now static.
9061 * xmenu.c (menu_highlight_callback): Now static.
9062 (set_frame_menubar): Remove unused local.
9063 (xmenu_show): Rename parameter to avoid shadowing.
9064 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9065 since they might point to immutable storage.
9066 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9067 since it's unused otherwise.
9069 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9070 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9071 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9072 avoids a gcc -Wuninitialized diagnostic.
9073 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9074 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9075 does not deduce are never used uninitialized.
9077 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9079 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9080 * window.c (window_loop, size_window):
9081 (run_window_configuration_change_hook, enlarge_window): Likewise.
9083 * window.c (display_buffer): Now static.
9084 (size_window): Mark variables that gcc -Wuninitialized
9085 does not deduce are never used uninitialized.
9086 * window.h (check_all_windows): New decl, to forestall
9087 gcc -Wmissing-prototypes diagnostic.
9088 * dispextern.h (bidi_dump_cached_states): Likewise.
9090 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9092 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9094 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9095 and to avoid gcc -Wuninitialized warning.
9096 (load_charset_map): Mark variables that gcc -Wuninitialized
9097 does not deduce are never used uninitialized.
9098 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9100 * coding.c (coding_set_source, coding_set_destination):
9101 Use "else { /* comment */ }" rather than "else /* comment */;"
9102 for clarity, and to avoid gcc -Wempty-body warning.
9103 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9104 a block, when the outer 'i' will do.
9105 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9106 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9107 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9108 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9109 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9110 Rename locals to avoid shadowing.
9111 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9112 * coding.c (emacs_mule_char, encode_invocation_designation):
9113 Now static, since they're not used elsewhere.
9114 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9115 (decode_coding_object, encode_coding_object, detect_coding_system):
9116 (decode_coding_emacs_mule): Mark variables that gcc
9117 -Wuninitialized does not deduce are never used uninitialized.
9118 (detect_coding_iso_2022): Initialize a local variable that might
9119 be used uninitialized. Leave a FIXME because it's not clear that
9120 this initialization is needed. (Bug#8211)
9121 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9122 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9123 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9124 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9125 Remove unused macros.
9127 * category.c (hash_get_category_set): Remove unused local var.
9128 (copy_category_table): Now static, since it's not used elsewhere.
9129 * character.c (string_count_byte8): Likewise.
9131 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9132 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9134 * chartab.c (copy_sub_char_table): Now static, since it's not used
9136 (sub_char_table_ref_and_range, char_table_ref_and_range):
9137 Rename locals to avoid shadowing.
9138 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9140 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9141 (BIDI_BOB): Remove unused macro.
9143 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9144 deduce are never used uninitialized.
9145 * term.c (encode_terminal_code): Likewise.
9147 * term.c (encode_terminal_code): Now static. Remove unused local.
9149 * tparam.h: New file.
9150 * term.c, tparam.h: Include it.
9151 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9152 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9153 Move these decls to tparam.h, and make them agree with what
9154 is actually in tparam.c. The previous trick of using incompatible
9155 decls in different modules does not conform to the C standard.
9156 All callers of tparam changed to use tparam's actual API.
9157 * tparam.c (tparam1, tparam, tgoto):
9158 Use const pointers where appropriate.
9160 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9161 * cm.h (struct cm): Likewise.
9162 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9163 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9164 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9165 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9166 (turn_on_face, init_tty): Likewise.
9167 * termchar.h (struct tty_display_info): Likewise.
9169 * term.c (term_mouse_position): Rename local to avoid shadowing.
9171 * alloc.c (mark_ttys): Move decl from here ...
9172 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9174 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9176 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9178 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9180 * search.c (compile_pattern_1): Remove argument regp, unused since
9181 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9182 (compile_pattern): Don't pass it.
9184 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9186 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9187 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9189 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9191 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9193 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9194 gdk_window_get_screen, gdk_window_get_geometry,
9195 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9196 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9197 (xg_get_pixbuf_from_pixmap): New function.
9198 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9199 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9200 Call xg_get_pixbuf_from_pixmap instead of
9201 gdk_pixbuf_get_from_drawable.
9202 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9203 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9204 (xg_check_special_colors): Use GtkStyleContext and its functions
9206 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9207 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9208 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9209 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9210 Call gtk_widget_get_preferred_size.
9211 (xg_frame_resized): gdk_window_get_geometry only takes 5
9213 (xg_win_to_widget, xg_event_is_for_menubar):
9214 Call gdk_x11_window_lookup_for_display.
9215 (xg_set_widget_bg): New function.
9216 (delete_cb): New function.
9217 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9218 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9219 (xg_set_background_color): Call xg_set_widget_bg.
9220 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9221 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9222 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9223 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9225 (update_frame_tool_bar): Call gtk_widget_hide.
9226 (xg_initialize): Use GDK_KEY_g.
9228 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9230 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9232 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9233 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9234 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9236 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9238 * w32xfns.c (select_palette): Check success of RealizePalette against
9239 GDI_ERROR, not zero.
9241 See ChangeLog.11 for earlier changes.
9247 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9249 This file is part of GNU Emacs.
9251 GNU Emacs is free software: you can redistribute it and/or modify
9252 it under the terms of the GNU General Public License as published by
9253 the Free Software Foundation, either version 3 of the License, or
9254 (at your option) any later version.
9256 GNU Emacs is distributed in the hope that it will be useful,
9257 but WITHOUT ANY WARRANTY; without even the implied warranty of
9258 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9259 GNU General Public License for more details.
9261 You should have received a copy of the GNU General Public License
9262 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.