1 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3 * xml.c (make_dom): Return comments, too.
5 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9 and the surrounding thread.
10 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
11 rather than fgets, and retry after EINTR. Otherwise, 'emacs
12 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
14 * s/openbsd.h (BROKEN_SIGIO): Define.
15 * unexelf.c (unexec) [__OpenBSD__]:
16 Don't update the .mdebug section of the Alpha COFF symbol table.
18 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
20 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
23 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
25 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
26 This fixes some race conditions on the permissions of any newly
29 * alloc.c (valid_pointer_p): Use pipe, not open.
30 This fixes some permissions issues when debugging.
32 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
33 If fchown fails to set both uid and gid, try to set just gid,
34 as that is sometimes allowed. Adjust the file's mode to eliminate
35 setuid or setgid bits that are inappropriate if fchown fails.
37 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
39 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
40 to compare Lisp_Objects.
41 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
42 global_gnutls_log_level, don't mistake it for a Lisp_Object.
43 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
45 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
47 * lread.c (read_integer): Unread even EOF character.
48 (read1): Likewise. Properly record start position of symbol.
50 * lread.c (read1): Read `#:' as empty uninterned symbol if no
51 symbol character follows.
53 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
55 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
56 This works around a problem with the previous change to Fcopy_file.
57 Recent glibc declares fchown with __attribute__((warn_unused_result)),
58 and without this change, GCC might complain about discarding
59 fchown's return value.
61 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
63 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
65 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
67 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
69 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
71 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
72 it's used from the C level.
74 * process.c: Use the same condition for POLL_FOR_INPUT in both
75 keyboard.c and process.c (bug#1858).
77 2011-07-09 Lawrence Mitchell <wence@gmx.li>
79 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
80 (Fgnutls_boot): Use it.
82 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
84 * doc.c (Fsubstitute_command_keys): Revert last change.
86 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
88 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
89 quotes the next character, and doesn't affect other longer
92 * lread.c (syms_of_lread): Clarify that is isn't only
93 `eval-buffer' and `eval-defun' that's affected by
94 `lexical-binding' (bug#8460).
96 2011-07-15 Eli Zaretskii <eliz@gnu.org>
98 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
99 bidi redisplay when a line includes both an image and is
102 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
104 Fix minor problems found by static checking.
105 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
106 (elsz): Now a signed constant, not a size_t var. We prefer signed
107 types to unsigned, to avoid integer comparison confusion. Without
108 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
109 "cannot optimize loop, the loop counter may overflow", a symptom
111 * indent.c (Fvertical_motion): Mark locals as initialized.
112 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
114 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
116 * search.c (Fre_search_backward): Mention `case-fold-search' in
117 all the re_search_* functions (bug#8138).
119 * keyboard.c (Fopen_dribble_file): Document when the file is
122 2011-07-14 Eli Zaretskii <eliz@gnu.org>
124 * bidi.c (bidi_dump_cached_states): Fix format of displaying
127 Support bidi reordering of display and overlay strings.
128 * xdisp.c (compute_display_string_pos)
129 (compute_display_string_end): Accept additional argument STRING.
130 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
131 (reseat_to_string): Initialize bidi_it->string.s and
132 bidi_it->string.schars.
133 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
134 NULL (avoids a crash in bidi_paragraph_init). Initialize
136 (init_iterator): Call bidi_init_it only of a valid
137 buffer position was specified. Initialize paragraph_embedding to
139 (reseat_to_string): Initialize the bidi iterator.
140 (display_string): If we need to ignore text properties of
141 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
142 original value of -1 will not work with bidi.)
143 (compute_display_string_pos): First arg is now struct
144 `text_pos *'; all callers changed. Support display properties on
146 (compute_display_string_end): Support display properties on Lisp
148 (init_iterator, reseat_1, reseat_to_string): Initialize the
149 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
150 when iterating on a string not from display properties).
151 (compute_display_string_pos, compute_display_string_end): Fix
152 calculation of the object to scan. Fixes an error when using
154 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
155 base_level_stop; instead, set base_level_stop to BEGV. Fixes
156 crashes in vertical-motion.
157 (next_element_from_buffer): Improve commentary for when
158 the iterator is before prev_stop.
159 (init_iterator): Initialize bidi_p from the default value of
160 bidi-display-reordering, not from buffer-local value. Use the
161 buffer-local value only if initializing for buffer iteration.
162 (handle_invisible_prop): Support invisible properties on strings
163 that are being bidi-reordered.
164 (set_iterator_to_next): Support bidi reordering of C strings and
166 (next_element_from_string): Support bidi reordering of Lisp
168 (handle_stop_backwards): Support Lisp strings as well.
169 (display_string): Support display of R2L glyph rows. Use
170 IT_STRING_CHARPOS when displaying from a Lisp string.
171 (init_iterator): Don't initialize it->bidi_p for strings
173 (reseat_to_string): Initialize it->bidi_p for strings here.
174 (next_element_from_string, next_element_from_c_string)
175 (next_element_from_buffer): Add xassert's for correspondence
176 between IT's object being iterated and it->bidi_it.string
178 (face_before_or_after_it_pos): Support bidi iteration.
179 (next_element_from_c_string): Handle the case of the first string
180 character that is not the first one in the visual order.
181 (get_visually_first_element): New function, refactored from common
182 parts of next_element_from_buffer, next_element_from_string, and
183 next_element_from_c_string.
184 (tool_bar_lines_needed, redisplay_tool_bar)
185 (display_menu_bar): Force left-to-right direction. Add a FIXME
186 comment for making that be controlled by a user option.
187 (push_it, pop_it): Save and restore the state of the
188 bidi iterator. Save and restore the bidi_p flag.
189 (pop_it): Iterate out of display property for string iteration as
191 (iterate_out_of_display_property): Support iteration over strings.
192 (handle_single_display_spec): Set up it->bidi_it for iteration
193 over a display string, and call bidi_init_it.
194 (handle_single_display_spec, next_overlay_string)
195 (get_overlay_strings_1, push_display_prop): Set up the bidi
196 iterator for displaying display or overlay strings.
197 (forward_to_next_line_start): Don't use the shortcut if
199 (back_to_previous_visible_line_start): If handle_display_prop
200 pushed the iterator stack, restore the internal state of the bidi
201 iterator by calling bidi_pop_it same number of times.
202 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
203 and we are bidi-iterating, don't decrement the iterator position;
204 instead, set the first_elt flag in the bidi iterator, to produce
206 (reseat_1): Remove redundant setting of string_from_display_prop_p.
207 (push_display_prop): xassert that we are iterating a buffer.
208 (push_it, pop_it): Save and restore paragraph_embedding member.
209 (handle_single_display_spec, next_overlay_string)
210 (get_overlay_strings_1, reseat_1, reseat_to_string)
211 (push_display_prop): Set up the `unibyte' member of bidi_it.string
212 correctly. Don't assume unibyte strings are not bidi-reordered.
213 (compute_display_string_pos)
214 (compute_display_string_end): Fix handling the case of C string.
215 (push_it, pop_it): Save and restore from_disp_prop_p.
216 (handle_single_display_spec, push_display_prop): Set the
217 from_disp_prop_p flag.
218 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
219 (pop_it): Call iterate_out_of_display_property only if we are
220 popping after iteration over a string that came from a display
221 property. Fix a typo in popping stretch info. Add an assertion
222 for verifying that the iterator position is in sync with the bidi
224 (handle_single_display_spec, get_overlay_strings_1)
225 (push_display_prop): Fix initialization of paragraph direction for
226 string when that of the parent object is not yet determined.
227 (reseat_1): Call bidi_init_it to resync the bidi
228 iterator with IT's position. (Bug#7616)
229 (find_row_edges): If ROW->start.pos gives position
230 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
231 (handle_stop, back_to_previous_visible_line_start, reseat_1):
232 Reset the from_disp_prop_p flag.
233 (SAVE_IT, RESTORE_IT): New macros.
234 (pos_visible_p, face_before_or_after_it_pos)
235 (back_to_previous_visible_line_start)
236 (move_it_in_display_line_to, move_it_in_display_line)
237 (move_it_to, move_it_vertically_backward, move_it_by_lines)
238 (try_scrolling, redisplay_window, display_line): Use them when
239 saving a temporary copy of the iterator and restoring it back.
240 (back_to_previous_visible_line_start, reseat_1)
241 (init_iterator): Empty the bidi cache "stack".
242 (move_it_in_display_line_to): If iterator ended up at
243 EOL, but we never saw any buffer positions smaller than
244 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
245 motion in bidi-reordered lines.
246 (move_it_in_display_line_to): Record prev_method and prev_pos
247 immediately before the call to set_iterator_to_next. Fixes cursor
248 motion in bidi-reordered lines with stretch glyphs and strings
249 displayed in margins. (Bug#8133) (Bug#8867)
250 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
252 (pos_visible_p): Support positions in bidi-reordered lines. Save
253 and restore bidi cache.
255 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
256 (bidi_paragraph_info): Delete unused struct.
257 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
258 (bidi_cache_start): New variable.
259 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
261 (bidi_cache_fetch_state, bidi_cache_search)
262 (bidi_cache_find_level_change, bidi_cache_iterator_state)
263 (bidi_cache_find, bidi_peek_at_next_level)
264 (bidi_level_of_next_char, bidi_find_other_level_edge)
265 (bidi_move_to_visually_next): Compare cache index with
266 bidi_cache_start rather than with zero.
267 (bidi_fetch_char): Accept new argument STRING; all callers
268 changed. Support iteration over a string. Support strings with
269 display properties. Support unibyte strings. Fix the type of
270 `len' according to what STRING_CHAR_AND_LENGTH expects.
271 (bidi_paragraph_init, bidi_resolve_explicit_1)
272 (bidi_resolve_explicit, bidi_resolve_weak)
273 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
274 iteration over a string.
275 (bidi_set_sor_type, bidi_resolve_explicit_1)
276 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
277 can now be zero (for strings); special values 0 and -1 were
278 changed to -1 and -2, respectively.
279 (bidi_char_at_pos): New function.
280 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
281 Call it instead of FETCH_MULTIBYTE_CHAR.
282 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
283 initialized to valid values.
284 (bidi_init_it): Don't initialize charpos and bytepos with invalid
286 (bidi_level_of_next_char): Allow the sentinel "position" to pass
287 the test for valid cached positions. Fix the logic for looking up
288 the sentinel state in the cache. GCPRO the Lisp string we are
290 (bidi_push_it, bidi_pop_it): New functions.
291 (bidi_initialize): Initialize the bidi cache start stack pointer.
292 (bidi_cache_ensure_space): New function, refactored from part of
293 bidi_cache_iterator_state. Don't assume the required size is just
294 one BIDI_CACHE_CHUNK away.
295 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
296 (bidi_count_bytes, bidi_char_at_pos): New functions.
297 (bidi_cache_search): Don't assume bidi_cache_last_idx is
298 always valid if bidi_cache_idx is valid.
299 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
300 is valid if it's going to be used.
301 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
302 (bidi_cache_fetch_state, bidi_cache_search)
303 (bidi_cache_find_level_change, bidi_cache_ensure_space)
304 (bidi_cache_iterator_state, bidi_cache_find)
305 (bidi_find_other_level_edge, bidi_cache_start_stack): All
306 variables related to cache indices are now EMACS_INT.
308 * dispextern.h (struct bidi_string_data): New structure.
309 (struct bidi_it): New member `string'. Make flag members be 1-bit
310 fields, and put them last in the struct.
311 (compute_display_string_pos, compute_display_string_end): Update
313 (bidi_push_it, bidi_pop_it): Add prototypes.
314 (struct iterator_stack_entry): New members bidi_p,
315 paragraph_embedding, and from_disp_prop_p.
316 (struct it): Member bidi_p is now a bit field 1 bit wide.
317 (bidi_shelve_cache, bidi_unshelve_cache): Declare
320 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
321 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
322 and vector-like objects.
324 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
325 cache around display iteration.
327 * window.c (Fwindow_end, window_scroll_pixel_based)
328 (displayed_window_lines, Frecenter): Save and restore the bidi
329 cache around display iteration.
331 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
333 * editfns.c (Fdelete_region): Clarify the use of the named
334 parameters (bug#6788).
336 2011-07-14 Martin Rudalics <rudalics@gmx.at>
338 * indent.c (Fvertical_motion): Set and restore w->pointm when
339 saving and restoring the window's buffer (Bug#9006).
341 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
343 * editfns.c (Fstring_to_char): Clarify just what is returned
344 (bug#6576). Text by Eli Zaretskii.
346 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
348 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
350 2011-07-13 Eli Zaretskii <eliz@gnu.org>
352 * buffer.c (mmap_find): Fix a typo.
354 2011-07-13 Johan Bockgård <bojohan@gnu.org>
356 Fix execution of x selection hooks.
357 * xselect.c (Qx_lost_selection_functions)
358 (Qx_sent_selection_functions): New vars.
359 (syms_of_xselect): DEFSYM them.
360 (x_handle_selection_request): Pass Qx_sent_selection_functions
361 rather than Vx_sent_selection_functions to Frun_hook_with_args.
362 (x_handle_selection_clear,x_clear_frame_selections):
363 Pass Qx_lost_selection_functions rather than
364 Vx_lost_selection_functions to Frun_hook_with_args.
366 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
368 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
369 The old code sometimes used this field without initializing it.
371 * alloc.c (gc_sweep): Don't read past end of array.
372 In theory, the old code could also have corrupted Emacs internals,
373 though it'd be very unlikely.
375 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
377 * character.c (Fcharacterp): Don't advertise optional ignored
380 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
382 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
385 * window.c (Fset_window_start): Doc fix (bug#4199).
386 (Fset_window_hscroll): Ditto.
388 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
390 Fix minor new problems caught by GCC 4.6.1.
391 * term.c (init_tty): Remove unused local.
392 * xsettings.c (store_monospaced_changed): Define this function only
393 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
396 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
398 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
400 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
402 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
403 are the mini-buffer and the echo area (bug#3320).
405 * term.c (init_tty): Remove support for supdup, c10 and perq
406 terminals, which are no longer supported (bug#1482).
408 2011-07-10 Johan Bockgård <bojohan@gnu.org>
410 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
412 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
414 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
415 for non-popups (Bug#3642).
417 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
419 * alloc.c (reset_malloc_hooks): Protoize.
420 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
421 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
422 * cm.c (losecursor): Likewise.
423 * data.c (fmod): Likewise.
424 * dispnew.c (swap_glyphs_in_rows): Likewise.
425 * emacs.c (memory_warning_signal): Likewise.
426 * floatfns.c (float_error): Likewise.
427 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
428 (otf_open, font_otf_capability, generate_otf_features)
429 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
431 * image.c (pbm_read_file): Likewise.
432 * indent.c (string_display_width): Likewise.
433 * intervals.c (check_for_interval, search_for_interval)
434 (inc_interval_count, count_intervals, root_interval)
435 (adjust_intervals_for_insertion, make_new_interval): Likewise.
436 * lread.c (defalias): Likewise.
437 * ralloc.c (r_alloc_check): Likewise.
438 * regex.c (set_image_of_range_1, set_image_of_range)
439 (regex_grow_registers): Likewise.
440 * sysdep.c (strerror): Likewise.
441 * termcap.c (valid_filename_p, tprint, main): Likewise.
442 * tparam.c (main): Likewise.
443 * unexhp9k800.c (run_time_remap, save_data_space)
444 (update_file_ptrs, read_header, write_header, calculate_checksum)
445 (copy_file, copy_rest, display_header): Likewise.
446 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
448 * xdisp.c (check_it): Likewise.
449 * xfaces.c (register_color, unregister_color, unregister_colors):
451 * xfns.c (print_fontset_result): Likewise.
452 * xrdb.c (member, fatal, main): Likewise.
454 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
456 Fix minor problems found by static checking (Bug#9031).
457 * chartab.c (char_table_set_range, map_sub_char_table):
458 Remove unused locals.
459 (uniprop_table): Now static.
460 * composite.c (_work_char): Remove unused static var.
462 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
464 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
466 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
468 * gtkutil.c (qttip_cb): Remove code without function.
470 2011-07-09 Eli Zaretskii <eliz@gnu.org>
472 * w32.c (pthread_sigmask): New stub.
474 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
476 Use pthread_sigmask, not sigprocmask (Bug#9010).
477 sigprocmask is portable only for single-threaded applications, and
478 Emacs can be multi-threaded when it uses GTK.
479 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
481 * callproc.c (Fcall_process):
482 * process.c (create_process):
483 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
484 Use pthread_sigmask, not sigprocmask.
486 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
488 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
489 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
492 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
494 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
495 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
496 (xg_hide_tooltip): Fix comment.
498 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
499 in registerServicesMenuSendTypes.
500 (validRequestorForSendType): Don't check ns_return_types.
502 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
505 2011-07-08 Jason Rumney <jasonr@gnu.org>
507 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
508 frame struct members of non-existent frames (Bug#6284).
510 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
512 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
513 variable firstTime not needed on OSX >= 10.6.
514 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
515 >= 10.5. Use setKnobProportion, setDoubleValue.
517 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
518 (MAC_OS_X_VERSION_10_5): Define if not defined.
519 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
520 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
521 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
523 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
524 cString and lossyCString on OSX >= 10.4
526 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
527 sizeToFit on OSX >= 10.2.
529 * nsimage.m (allocInitFromFile): Don't use deprecated method
530 bestRepresentationForDevice on OSX >= 10.6.
532 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
535 * emacs.c: Declare unexec_init_emacs_zone.
537 * nsgui.h: Fix compiler warning about gnulib redefining verify.
539 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
541 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
542 on svcsMenu (Bug#8842).
544 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
546 (Fns_list_services): Just return Qnil on 10.6, code not working there.
548 * nsterm.m (QUTF8_STRING): Declare.
549 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
550 (validRequestorForSendType): Return type is (id).
551 Change indexOfObjectIdenticalTo to indexOfObject.
552 Check if we have local selection before returning self (Bug#8842).
553 (writeSelectionToPasteboard): Put local selection into paste board
554 if we have a local selection (Bug#8842).
555 (syms_of_nsterm): DEFSYM QUTF8_STRING.
557 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
558 (ns_get_local_selection): Declare.
560 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
562 * keymap.c (describe_map_tree): Don't insert a double newline at
563 the end of the buffer (bug#1169) and return whether we inserted
566 * callint.c (Fcall_interactively): Change "reading args" to
567 "providing args" to try to clarify what it does (bug#1010).
569 2011-07-07 Kenichi Handa <handa@m17n.org>
571 * composite.c (composition_compute_stop_pos): Ignore a static
572 composition starting before CHARPOS (Bug#8915).
574 * xdisp.c (handle_composition_prop): Likewise.
576 2011-07-07 Eli Zaretskii <eliz@gnu.org>
578 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
581 2011-07-07 Kenichi Handa <handa@m17n.org>
583 * character.h (unicode_category_t): New enum type.
585 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
586 (Qchar_code_property_table): New variable.
587 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
588 (UNIPROP_COMPRESSED_FORM_P): New macros.
589 (char_table_ascii): Uncompress the compressed values.
590 (sub_char_table_ref): New arg is_uniprop. Callers changed.
591 Uncompress the compressed values.
592 (sub_char_table_ref_and_range): Likewise.
593 (char_table_ref_and_range): Uncompress the compressed values.
594 (sub_char_table_set): New arg is_uniprop. Callers changed.
595 Uncompress the compressed values.
596 (sub_char_table_set_range): Args changed. Callers changed.
597 (char_table_set_range): Adjuted for the above change.
598 (map_sub_char_table): Delete args default_val and parent. Add arg
599 top. Give decoded values to a Lisp function.
600 (map_char_table): Adjusted for the above change. Give decoded
601 values to a Lisp function. Gcpro more variables.
602 (uniprop_table_uncompress)
603 (uniprop_decode_value_run_length): New functions.
604 (uniprop_decoder, uniprop_decoder_count): New variables.
605 (uniprop_get_decoder, uniprop_encode_value_character)
606 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
608 (uniprop_encoder, uniprop_encoder_count): New variables.
609 (uniprop_get_encoder, uniprop_table)
610 (Funicode_property_table_internal, Fget_unicode_property_internal)
611 (Fput_unicode_property_internal): New functions.
612 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
613 Sunicode_property_table_internal, Sget_unicode_property_internal,
614 and Sput_unicode_property_internal. Defvar_lisp
615 char-code-property-alist.
617 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
618 Vunicode_category_table.
620 * font.c (font_range): Adjusted for the change of
621 Vunicode_category_table.
623 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
625 * m/iris4d.h: Remove file, move contents ...
626 * s/irix6-5.h: ... here.
628 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
630 Remove unportable assumption about struct layout (Bug#8884).
631 * alloc.c (mark_buffer):
632 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
633 (clone_per_buffer_values): Don't assume that
634 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
635 This isn't true in general, and it's particularly not true
636 if Emacs is configured with --with-wide-int.
637 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
638 New macros, used in the buffer.c change.
640 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
642 * xsettings.c: Use both GConf and GSettings if both are available.
643 (store_config_changed_event): Add comment.
644 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
645 (store_tool_bar_style_changed): New functions.
646 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
647 (struct xsettings): Move font inside HAVE_XFT.
648 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
649 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
650 Move inside HAVE_XFT.
651 (something_changed_gsettingsCB): Renamed from something_changedCB.
652 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
654 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
655 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
656 (something_changed_gconfCB): Renamed from something_changedCB.
657 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
658 (parse_settings): Move check for font inside HAVE_XFT.
659 (read_settings, apply_xft_settings): Add comment.
660 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
661 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
662 call store_font_name_changed.
663 (xft_settings_event): Add comment.
664 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
665 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
666 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
667 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
668 (xsettings_initialize): Call init_gsettings last.
669 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
672 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
674 Random fixes. E.g., (random) never returned negative values.
675 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
676 subseconds part to the entropy, as that's a bit more random.
677 Prefer signed to unsigned, since the signedness doesn't matter and
678 in general we prefer signed. When given a limit, use a
679 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
680 latter isn't right if USE_2_TAGS_FOR_INTS.
681 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
682 not 0..VALMASK. Don't discard "excess" bits that random () returns.
684 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
686 * textprop.c (text_property_stickiness):
687 Obey Vtext_property_default_nonsticky.
688 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
689 * w32fns.c (syms_of_w32fns):
690 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
692 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
694 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
695 This is more efficient than Ffile_directory_p and avoids a minor race.
697 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
699 * buffer.c (Foverlay_put): Say what the return value is
702 * fileio.c (barf_or_query_if_file_exists): Check first if the file
703 is a directory before asking whether to use the file name
705 (barf_or_query_if_file_exists): Make the "File is a directory"
706 error be more correct.
708 * fns.c (Frequire): Remove the mention of the .gz files, since
709 that's installation-specific, but keep the mention of
712 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
714 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
715 Report string overflow if the output is too long.
717 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
719 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
720 (syms_of_gnutls): Remove duplicate DEFSYM for
721 Qgnutls_bootprop_verify_hostname_error, an error for
722 Qgnutls_bootprop_verify_error (which is no longer used).
724 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
725 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
726 Also (re)move comments that are misplaced or no longer relevant.
728 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
730 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
732 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
734 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
735 and background color parameters if they have been changed.
737 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
739 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
741 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
743 * xsettings.c (SYSTEM_FONT): Define only when used.
744 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
746 * keymap.c (access_keymap_1): Now static.
748 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
750 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
751 leave any prefix arg for the up event (Bug#1586).
753 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
755 * lread.c (syms_of_lread): Mention single symbols defined by
756 `defvar' or `defconst' (bug#7154).
758 * fns.c (Frequire): Mention .el.gz files (bug#7314).
759 (Frequire): Mention get-load-suffixes.
761 2011-07-02 Martin Rudalics <rudalics@gmx.at>
763 * window.h (window): Remove clone_number slot.
764 * window.c (Fwindow_clone_number, Fset_window_clone_number):
766 (make_parent_window, make_window, saved_window)
767 (Fset_window_configuration, save_window_save): Don't deal with
769 * buffer.c (Qclone_number): Remove declaration.
770 (sort_overlays, overlay_strings): Don't deal with clone numbers.
772 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
774 Add multiple inheritance to keymaps.
775 * keymap.c (Fmake_composed_keymap): New function.
776 (Fset_keymap_parent): Simplify.
777 (fix_submap_inheritance): Remove.
778 (access_keymap_1): New function extracted from access_keymap to handle
779 embedded parents and handle lists of maps.
780 (access_keymap): Use it.
781 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
782 (Fcopy_keymap): Handle embedded parents.
783 (Fcommand_remapping, define_as_prefix): Simplify.
784 (Fkey_binding): Simplify.
785 (syms_of_keymap): Move minibuffer-local-completion-map,
786 minibuffer-local-filename-completion-map,
787 minibuffer-local-must-match-map, and
788 minibuffer-local-filename-must-match-map to Elisp.
789 (syms_of_keymap): Defsubr make-composed-keymap.
790 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
791 (parse_menu_item): Trivial simplification.
793 2011-07-01 Glenn Morris <rgm@gnu.org>
795 * Makefile.in (SETTINGS_LIBS): Fix typo.
797 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
799 * coding.c (Fencode_coding_string): Record the last coding system
800 used, as the function doc string says (bug#8738).
802 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
804 * xsettings.c (store_monospaced_changed): Take new font as arg and
805 check for change against current_mono_font.
806 (EMACS_TYPE_SETTINGS): Remove this and related defines.
807 (emacs_settings_constructor, emacs_settings_get_property)
808 (emacs_settings_set_property, emacs_settings_class_init)
809 (emacs_settings_init, gsettings_obj): Remove.
810 (something_changedCB): New function for HAVE_GSETTINGS.
811 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
812 with value as argument.
813 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
814 g_settings_new (Bug#8967). Do not create gsettings_obj.
815 Remove calls to g_settings_bind. Connect something_changedCB to
818 * xgselect.c: Add defined (HAVE_GSETTINGS).
819 (xgselect_initialize): Ditto.
821 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
822 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
825 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
827 * eval.c (struct backtrace): Simplify and port the data structure.
828 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
829 signed bit field, as this assumption is not portable and it makes
830 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
831 "char debug_on_exit : 1" as this is not portable either; instead,
832 use the portable "unsigned int debug_on_exit : 1". Remove unused
833 member evalargs. Remove obsolete comments about cc bombing out.
835 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
837 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
838 Let HAVE_GSETTINGS override HAVE_GCONF.
839 (store_monospaced_changed): New function.
840 (EMACS_SETTINGS): A new type derived from GObject to handle
841 GSettings notifications.
842 (emacs_settings_constructor, emacs_settings_get_property)
843 (emacs_settings_set_property, emacs_settings_class_init):
845 (gsettings_client, gsettings_obj): New variables.
846 (GSETTINGS_SCHEMA): New define.
847 (something_changedCB): Call store_monospaced_changed.
848 (init_gsettings): New function.
849 (xsettings_initialize): Call init_gsettings.
850 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
853 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
856 2011-06-29 Martin Rudalics <rudalics@gmx.at>
858 * window.c (resize_root_window, grow_mini_window)
859 (shrink_mini_window): Rename Qresize_root_window to
860 Qwindow_resize_root_window and Qresize_root_window_vertically to
861 Qwindow_resize_root_window_vertically.
863 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
865 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
867 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
869 * makefile.w32-in: Redesign dependencies so they reflect more
870 clearly which files are directly included by each source file,
871 and not through other includes.
873 2011-06-27 Martin Rudalics <rudalics@gmx.at>
875 * buffer.c (Qclone_number): Declare static and DEFSYM it.
876 (sort_overlays, overlay_strings): When an overlay's clone number
877 matches the window's clone number process the overlay even if
878 the overlay's window property doesn't match the current window.
880 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
881 (Fwindow_hchild): Rename to Fwindow_left_child.
882 (Fwindow_next): Rename to Fwindow_next_sibling.
883 (Fwindow_prev): Rename to Fwindow_prev_sibling.
884 (resize_window_check): Rename to window_resize_check.
885 (resize_window_apply): Rename to window_resize_apply.
886 (Fresize_window_apply): Rename to Fwindow_resize_apply.
887 (Fdelete_other_windows_internal, resize_frame_windows)
888 (Fsplit_window_internal, Fdelete_window_internal)
889 (grow_mini_window, shrink_mini_window)
890 (Fresize_mini_window_internal): Fix callers accordingly.
892 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
894 * emacsgtkfixed.h: State that this is only used with Gtk+3.
895 (emacs_fixed_set_min_size): Remove.
896 (emacs_fixed_new): Take frame as argument.
898 * emacsgtkfixed.c: State that this is only used with Gtk+3.
899 (_EmacsFixedPrivate): Remove minwidth/height.
901 (emacs_fixed_init): Initialize priv->f.
902 (get_parent_class, emacs_fixed_set_min_size): Remove.
903 (emacs_fixed_new): Set priv->f to argument.
904 (emacs_fixed_get_preferred_width)
905 (emacs_fixed_get_preferred_height): Use min_width/height from
906 frames size_hint to set minimum and natural (Bug#8919).
907 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
908 and use min_width/height from frames size_hint to set
909 min_width/height (Bug#8919).
911 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
912 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
915 2011-06-26 Eli Zaretskii <eliz@gnu.org>
917 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
918 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
921 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
923 * process.c (wait_reading_process_output): Bypass select if
924 waiting for a cell while ignoring keyboard input, and input is
925 pending. Suggested by Jan Djärv (Bug#8869).
927 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
929 Use gnulib's dup2 module instead of rolling our own.
930 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
932 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
934 * dispnew.c (scrolling_window): Before scrolling, turn off a
935 mouse-highlight in the window being scrolled.
937 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
939 Move DEFSYM to lisp.h and use everywhere.
941 * character.h (DEFSYM): Move declaration...
942 * lisp.h (DEFSYM): ...here.
948 * w32select.c: Don't include character.h.
950 * alloc.c (syms_of_alloc):
951 * buffer.c (syms_of_buffer):
952 * bytecode.c (syms_of_bytecode):
953 * callint.c (syms_of_callint):
954 * casefiddle.c (syms_of_casefiddle):
955 * casetab.c (init_casetab_once):
956 * category.c (init_category_once, syms_of_category):
957 * ccl.c (syms_of_ccl):
958 * cmds.c (syms_of_cmds):
959 * composite.c (syms_of_composite):
960 * dbusbind.c (syms_of_dbusbind):
961 * dired.c (syms_of_dired):
962 * dispnew.c (syms_of_display):
963 * doc.c (syms_of_doc):
964 * editfns.c (syms_of_editfns):
965 * emacs.c (syms_of_emacs):
966 * eval.c (syms_of_eval):
967 * fileio.c (syms_of_fileio):
968 * fns.c (syms_of_fns):
969 * frame.c (syms_of_frame):
970 * fringe.c (syms_of_fringe):
971 * insdel.c (syms_of_insdel):
972 * keymap.c (syms_of_keymap):
973 * lread.c (init_obarray, syms_of_lread):
974 * macros.c (syms_of_macros):
975 * msdos.c (syms_of_msdos):
976 * print.c (syms_of_print):
977 * process.c (syms_of_process):
978 * search.c (syms_of_search):
979 * sound.c (syms_of_sound):
980 * syntax.c (init_syntax_once, syms_of_syntax):
981 * terminal.c (syms_of_terminal):
982 * textprop.c (syms_of_textprop):
983 * undo.c (syms_of_undo):
984 * w32.c (globals_of_w32):
985 * window.c (syms_of_window):
986 * xdisp.c (syms_of_xdisp):
987 * xfaces.c (syms_of_xfaces):
988 * xfns.c (syms_of_xfns):
989 * xmenu.c (syms_of_xmenu):
990 * xsettings.c (syms_of_xsettings):
991 * xterm.c (syms_of_xterm): Use DEFSYM.
993 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
995 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
997 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
999 Integer and buffer overflow fixes (Bug#8873).
1001 * print.c (printchar, strout): Check for string overflow.
1002 (PRINTPREPARE, printchar, strout):
1003 Don't set size unless allocation succeeds.
1005 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1006 for sizes. Check for string overflow more accurately.
1007 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1009 * macros.c: Integer and buffer overflow fixes.
1010 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1011 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1012 Use ptrdiff_t, not int, for sizes.
1013 Don't increment bufsize until after realloc succeeds.
1014 Check for size-calculation overflow.
1015 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1017 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1019 * lread.c: Integer overflow fixes.
1020 (read_integer): Radix is now EMACS_INT, not int,
1021 to improve quality of diagnostics for out-of-range radices.
1022 Calculate buffer size correctly for out-of-range radices.
1023 (read1): Check for integer overflow in radices, and in
1024 read-circle numbers.
1025 (read_escape): Avoid int overflow.
1026 (Fload, openp, read_buffer_size, read1)
1027 (substitute_object_recurse, read_vector, read_list, map_obarray):
1028 Use ptrdiff_t, not int, for sizes.
1029 (read1): Use EMACS_INT, not int, for sizes.
1030 Check for size overflow.
1032 * image.c (cache_image): Check for size arithmetic overflow.
1034 * lread.c: Integer overflow issues.
1035 (saved_doc_string_size, saved_doc_string_length)
1036 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1037 Now ptrdiff_t, not int.
1038 (read1): Don't assume doc string length fits in int. Check for
1039 out-of-range doc string lengths.
1040 (read_list): Don't assume file position fits in int.
1041 (read_escape): Check for hex character overflow.
1043 2011-06-22 Leo Liu <sdl.web@gmail.com>
1045 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1046 Move to minibuffer.el.
1048 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1050 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1051 The following patches are for when GLYPH_DEBUG && !XASSERT.
1052 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1053 * dispnew.c (flush_stdout):
1054 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1055 Mark as externally visible.
1056 * dispnew.c (check_window_matrix_pointers): Now static.
1057 * dispnew.c (window_to_frame_vpos):
1058 * xfns.c (unwind_create_frame):
1059 * xterm.c (x_check_font): Remove unused local.
1060 * scroll.c (CHECK_BOUNDS):
1061 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1062 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1063 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1064 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1065 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1067 (debug_method_add): Use va_list and vsprintf rather than relying
1068 on undefined behavior with wrong number of arguments.
1069 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1070 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1071 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1072 since we're not interested in debugging glyphs with old libraries.
1073 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1074 GCC 4.6.0's static checking.
1076 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1078 Integer overflow and signedness fixes (Bug#8873).
1079 A few related buffer overrun fixes, too.
1081 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1083 * dispextern.h (struct face.stipple):
1084 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1085 (x_bitmap_mask, x_allocate_bitmap_record)
1086 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1087 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1088 (x_create_bitmap_from_xpm_data):
1089 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1090 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1092 * xfaces.c (load_pixmap):
1093 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1094 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1095 (.bitmaps_last, struct x_output.icon_bitmap):
1096 Use ptrdiff_t, not int, for bitmap indexes.
1097 (x_allocate_bitmap_record): Check for size overflow.
1098 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1100 Use ptrdiff_t, not int, for overlay counts.
1101 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1102 * editfns.c (overlays_around, get_pos_property):
1103 * textprop.c (get_char_property_and_overlay):
1104 * xdisp.c (next_overlay_change, note_mouse_highlight):
1105 * xfaces.c (face_at_buffer_position):
1106 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1107 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1108 (Fnext_overlay_change, Fprevious_overlay_change)
1109 (mouse_face_overlay_overlaps, Foverlays_in):
1110 Use ptrdiff_t, not int, for sizes.
1111 (overlays_at, overlays_in): Check for size-calculation overflow.
1113 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1115 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1116 (x_session_initialize): Do not assume string length fits in int.
1118 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1119 This is unlikely, but can occur if DPI is outlandish.
1121 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1122 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1124 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1125 * xrdb.c (magic_file_p, search_magic_path):
1126 Omit last arg SUFFIX; it was always 0. All callers changed.
1127 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1129 * xfont.c (xfont_match): Avoid need for strlen.
1131 * xfns.c: Don't assume strlen fits in int.
1132 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1134 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1135 not unsigned long, as we prefer signed integers. All callers changed.
1136 Detect integer overflow in repeat count.
1137 (message_dolog): Don't assume print length fits in 39 bytes.
1138 (display_mode_element): Don't assume strlen fits in int.
1140 * termcap.c: Don't assume sizes fit in int and never overflow.
1141 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1142 (gobble_line): Check for size-calculation overflow.
1144 * minibuf.c (Fread_buffer):
1145 * lread.c (intern, intern_c_string):
1146 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1147 Don't assume string length fits in int.
1149 * keyboard.c (parse_tool_bar_item):
1150 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1152 * font.c: Don't assume string length fits in int.
1153 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1154 Use ptrdiff_t, not int.
1155 (font_intern_prop): Don't assume string length fits in int.
1156 Don't assume integer property fits in fixnum.
1157 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1159 * filelock.c: Fix some buffer overrun and integer overflow issues.
1160 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1161 Reformulate so as not to need the command string.
1162 Invoke gzip -cd rather than gunzip, as it's more portable.
1163 (lock_info_type, lock_file_1, lock_file):
1164 Don't assume pid_t and time_t fit in unsigned long.
1165 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1166 (current_lock_owner): Prefer signed type for sizes.
1167 Use memcpy, not strncpy, where memcpy is what is really wanted.
1168 Don't assume (via atoi) that time_t and pid_t fit in int.
1169 Check for time_t and/or pid_t out of range, e.g., via a network share.
1170 Don't alloca where an auto var works fine.
1172 * fileio.c: Fix some integer overflow issues.
1173 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1174 Don't assume string length fits in int.
1175 (directory_file_name): Don't assume string length fits in long.
1176 (make_temp_name): Don't assume pid fits in int, or that its print
1177 length is less than 20.
1179 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1181 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1183 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1185 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1186 We prefer signed integers, even for size calculations.
1188 * emacs.c: Don't assume string length fits in 'int'.
1189 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1190 (main): Don't invoke strlen when not needed.
1192 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1193 (XD_DEBUG_MESSAGE): Don't waste a byte.
1195 * callproc.c (getenv_internal_1, getenv_internal)
1197 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1199 * lread.c (invalid_syntax): Omit length argument.
1200 All uses changed. This doesn't fix a bug, but it simplifies the
1201 code away from its former Hollerith-constant appearance, and it's
1202 one less 'int' to worry about when looking at integer-overflow issues.
1203 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1205 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1206 This didn't break anything, but it didn't help either.
1207 It's confusing to put a bogus integer in a place where the actual
1208 value does not matter.
1209 (LIST_END_P): Remove unused macro and its bogus comment.
1210 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1212 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1213 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1215 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1216 We prefer signed types, and the value cannot exceed the EMACS_INT
1217 range anyway (because otherwise the length would not be representable).
1218 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1219 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1220 This avoids a GCC warning when WIDE_EMACS_INT.
1222 * indent.c (sane_tab_width): New function.
1223 (current_column, scan_for_column, Findent_to, position_indentation)
1224 (compute_motion): Use it. This is just for clarity.
1225 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1227 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1229 * lisp.h (lint_assume): New macro.
1230 * composite.c (composition_gstring_put_cache):
1231 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1233 * editfns.c, insdel.c:
1234 Omit unnecessary forward decls, to simplify future changes.
1236 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1238 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1240 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1241 Use much-faster test for byte-length change.
1242 Don't assume string byte-length fits in 'int'.
1243 Check that character arg fits in 'int'.
1244 (mapcar1): Declare byte as byte, for clarity.
1246 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1248 * fns.c (concat): Catch string overflow earlier.
1249 Do not rely on integer wraparound.
1251 * dispextern.h (struct it.overlay_strings_charpos)
1252 (struct it.selective): Now EMACS_INT, not int.
1253 * xdisp.c (forward_to_next_line_start)
1254 (back_to_previous_visible_line_start)
1255 (reseat_at_next_visible_line_start, next_element_from_buffer):
1256 Don't arbitrarily truncate the value of 'selective' to int.
1258 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1260 * composite.c: Don't truncate sizes to 'int'.
1261 (composition_gstring_p, composition_reseat_it)
1262 (composition_adjust_point): Use EMACS_INT, not int.
1263 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1264 not EMACS_UINT, for indexes.
1266 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1268 * buffer.c: Include <verify.h>.
1269 (struct sortvec.priority, struct sortstr.priority):
1270 Now EMACS_INT, not int.
1271 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1272 (struct sortstr.size, record_overlay_string)
1273 (struct sortstrlist.size, struct sortlist.used):
1274 Don't truncate size to int.
1275 (record_overlay_string): Check for size-calculation overflow.
1276 (init_buffer_once): Check at compile-time, not run-time.
1278 2011-06-22 Jim Meyering <meyering@redhat.com>
1280 Don't leak an XBM-image-sized buffer
1281 * image.c (xbm_load): Free the image buffer after using it.
1283 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1286 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1287 that Sun C diagnosed.
1288 * fns.c (secure_hash): Fix pointer signedness issue.
1289 * intervals.c (static_offset_intervals): New function.
1290 (offset_intervals): Use it.
1292 2011-06-21 Leo Liu <sdl.web@gmail.com>
1295 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1298 * fns.c (secure_hash): Rename from crypto_hash_function and change
1299 the first arg to accept symbols.
1300 (Fsecure_hash): New primitive.
1301 (syms_of_fns): New symbols.
1303 2011-06-20 Deniz Dogan <deniz@dogan.se>
1305 * process.c (Fset_process_buffer): Clarify return value in
1308 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1310 * dispnew.c (add_window_display_history): Use BVAR.
1312 * xdisp.c (debug_method_add): Use BVAR.
1313 (check_window_end, dump_glyph_matrix, dump_glyph)
1314 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1316 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1319 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1320 check till after the cache is created in init_frame_faces.
1322 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1324 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1326 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1328 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1329 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1330 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1332 Improve buffer-overflow checking (Bug#8873).
1333 * fileio.c (Finsert_file_contents):
1334 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1335 Remove the old (too-loose) buffer overflow checks.
1336 They weren't needed, since make_gap checks for buffer overflow.
1337 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1338 The old code merely checked for Emacs fixnum overflow, and relied
1339 on undefined (wraparound) behavior. The new code avoids undefined
1340 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1342 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1343 Tune. Don't use wider integers than needed. Don't use alloca.
1344 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1346 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1348 * insdel.c, lisp.h (buffer_overflow): New function.
1349 (insert_from_buffer_1, replace_range, replace_range_2):
1350 * insdel.c (make_gap_larger):
1351 * editfns.c (Finsert_char):
1352 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1354 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1356 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1358 Integer overflow and signedness fixes (Bug#8873).
1360 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1361 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1363 * fileio.c: Don't assume EMACS_INT fits in off_t.
1364 (emacs_lseek): New static function.
1365 (Finsert_file_contents, Fwrite_region): Use it.
1366 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1368 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1370 * fns.c: Don't overflow int when computing a list length.
1371 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1372 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1373 truncation on 64-bit hosts. Check for QUIT every
1374 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1375 faster and is responsive enough.
1376 (Flength): Report an error instead of overflowing an integer.
1377 (Fsafe_length): Return a float if the value is not representable
1378 as a fixnum. This shouldn't happen except in contrived situations.
1379 (Fnthcdr, Fsort): Don't assume list length fits in int.
1380 (Fcopy_sequence): Don't assume vector length fits in int.
1382 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1383 (header_size, word_size): New constants.
1384 (allocate_vectorlike): Don't check size overflow here.
1385 (allocate_vector): Check it here instead, since this is the only
1386 caller of allocate_vectorlike that could cause overflow.
1387 Check that the new vector's length is representable as a fixnum.
1389 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1390 The previous code was bogus. For example, next_almost_prime (32)
1391 returned 39, which is undesirable as it is a multiple of 3; and
1392 next_almost_prime (24) returned 25, which is a multiple of 5 so
1393 why was the code bothering to check for multiples of 7?
1395 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1397 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1399 Variadic C functions now count arguments with ptrdiff_t.
1400 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1401 Back then I didn't know that the Emacs coding style prefers signed int.
1402 Also, in the meantime I found a few more instances where arguments
1403 were being counted with int, which may truncate counts on 64-bit
1404 machines, or EMACS_INT, which may be unnecessarily wide.
1405 * lisp.h (struct Lisp_Subr.function.aMANY)
1406 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1407 Arg counts are now ptrdiff_t, not size_t.
1408 All variadic functions and their callers changed accordingly.
1409 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1410 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1411 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1412 * callint.c (Fcall_interactively): Check arg count for overflow,
1413 to avoid potential buffer overrun. Use signed char, not 'int',
1414 for 'varies' array, so that we needn't bother to check its size
1415 calculation for overflow.
1416 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1417 * eval.c (apply_lambda):
1418 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1419 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1420 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1422 * callint.c (Fcall_interactively): Don't use index var as event count.
1424 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1425 * mem-limits.h (SIZE): Remove; no longer used.
1427 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1429 Remove unnecessary casts.
1430 * xterm.c (x_term_init):
1431 * xfns.c (x_set_border_pixel):
1432 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1433 These aren't needed now that we assume ANSI C.
1435 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1436 It's more likely to cause problems (due to unsigned overflow)
1439 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1441 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1443 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1445 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1447 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1449 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1451 GLYPH_CODE_FACE returns EMACS_INT, not int.
1452 * dispextern.h (merge_faces):
1453 * xfaces.c (merge_faces):
1454 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1455 Don't assume EMACS_INT fits in int.
1457 * character.h (CHAR_VALID_P): Remove unused parameter.
1458 * fontset.c, lisp.h, xdisp.c: All uses changed.
1460 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1462 * fns.c (concat): Minor tuning based on overflow analysis.
1463 This doesn't fix any bugs. Use int to hold character, instead
1464 of constantly refetching from Emacs object. Use XFASTINT, not
1465 XINT, for value known to be a character. Don't bother comparing
1466 a single byte to 0400, as it's always less.
1468 * floatfns.c (Fexpt):
1469 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1471 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1474 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1476 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1477 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1478 incorrectly succeed when S was a string, because 4294967386 was
1479 truncated before it was used.
1481 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1482 Otherwise, an out-of-range integer could cause undefined behavior
1485 * composite.c: Use int, not EMACS_INT, for characters.
1486 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1487 EMACS_INT, for values that are known to be in character range.
1488 This doesn't fix any bugs but is the usual style inside Emacs and
1489 may generate better code on 32-bit machines.
1491 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1492 This is for reasons similar to the recent CHAR_STRING fix.
1493 * charset.c (Fencode_char): Check that character arg is actually
1494 a character. Pass an int to ENCODE_CHAR.
1495 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1496 wider than 'int', as a compile-time check to prevent future regressions
1499 * character.c (char_string): Remove unnecessary casts.
1501 Make sure a 64-bit char is never passed to CHAR_STRING.
1502 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1503 by silently ignoring the top 32 bits, allowing some values
1504 that were far too large to be valid characters.
1505 * character.h: Include <verify.h>.
1506 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1507 arguments are no wider than unsigned, as a compile-time check
1508 to prevent future regressions in this area.
1510 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1511 (Fsubst_char_in_region):
1513 * xdisp.c (decode_mode_spec_coding):
1514 Adjust to CHAR_STRING's new requirement.
1515 * editfns.c (Finsert_char, Fsubst_char_in_region):
1516 * fns.c (concat): Check that character args are actually
1517 characters. Without this test, these functions did the wrong
1518 thing with wildly out-of-range values on 64-bit hosts.
1520 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1521 These casts should not be needed on 32-bit hosts, either.
1522 * keyboard.c (read_char):
1523 * lread.c (Fload): Remove casts to unsigned.
1525 * lisp.h (UNSIGNED_CMP): New macro.
1526 This fixes comparison bugs on 64-bit hosts.
1527 (ASCII_CHAR_P): Use it.
1528 * casefiddle.c (casify_object):
1529 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1530 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1531 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1532 * dispextern.h (FACE_FROM_ID):
1533 * keyboard.c (read_char): Use UNSIGNED_CMP.
1535 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1536 not to EMACS_INT, to avoid GCC warning.
1538 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1540 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1541 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1542 isn't needed on 32-bit machines.
1544 * buffer.c (Fgenerate_new_buffer_name):
1545 Use EMACS_INT for count, not int.
1546 (advance_to_char_boundary): Return EMACS_INT, not int.
1548 * data.c (Qcompiled_function): Now static.
1550 * window.c (window_body_lines): Now static.
1552 * image.c (gif_load): Rename local to avoid shadowing.
1554 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1555 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1556 * alloc.c (make_save_value): Integer argument is now of type
1558 (mark_object): Use ptrdiff_t, not int.
1559 * lisp.h (pD): New macro.
1560 * print.c (print_object): Use it.
1562 * alloc.c: Use EMACS_INT, not int, to count objects.
1563 (total_conses, total_markers, total_symbols, total_vector_size)
1564 (total_free_conses, total_free_markers, total_free_symbols)
1565 (total_free_floats, total_floats, total_free_intervals)
1566 (total_intervals, total_strings, total_free_strings):
1567 Now EMACS_INT, not int. All uses changed.
1568 (Fgarbage_collect): Compute overall total using a double, so that
1569 integer overflow is less likely to be a problem. Check for overflow
1570 when converting back to an integer.
1571 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1572 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1573 These were 'int' variables that could overflow on 64-bit hosts;
1574 they were never used, so remove them instead of repairing them.
1575 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1576 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1577 Previously, this ceilinged at INT_MAX, but that doesn't work on
1579 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1581 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1582 (allocate_vectorlike): Check for ptrdiff_t overflow.
1583 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1584 when a (possibly-narrower) signed value would do just as well.
1585 We prefer using signed arithmetic, to avoid comparison confusion.
1587 * alloc.c: Catch some string size overflows that we were missing.
1588 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1589 for convenience in STRING_BYTES_MAX.
1590 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1591 The definition here is exact; the one in lisp.h was approximate.
1592 (allocate_string_data): Check for string overflow. This catches
1593 some instances we weren't catching before. Also, it catches
1594 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1595 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1596 and ptrdiff_t and EMACS_INT are both 64 bits.
1598 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1599 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1600 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1602 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1604 * alloc.c (Fmake_string): Check for out-of-range init.
1606 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1608 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1610 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1612 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1613 xg_get_default_scrollbar_width.
1615 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1616 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1617 (style_changed_cb): Call update_theme_scrollbar_width and call
1618 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1619 all frames (Bug#8505).
1620 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1621 Call gtk_window_set_resizable if HAVE_GTK3.
1622 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1623 and height if HAVE_GTK3 (Bug#8505).
1624 (scroll_bar_width_for_theme): New variable.
1625 (update_theme_scrollbar_width): New function.
1626 (xg_get_default_scrollbar_width): Move code to
1627 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1628 (xg_initialize): Call update_theme_scrollbar_width.
1630 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1632 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1634 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1636 * frame.c (make_frame): Call other_buffer_safely instead of
1639 * window.c (temp_output_buffer_show): Call display_buffer with
1640 second argument Vtemp_buffer_show_specifiers and reset latter
1641 immediately after the call.
1642 (Vtemp_buffer_show_specifiers): New variable.
1643 (auto_window_vscroll_p, next_screen_context_lines)
1644 (Vscroll_preserve_screen_position): Remove leading asterisks from
1647 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1649 Fix minor problems found by GCC 4.6.0 static checking.
1650 * buffer.c (Qclone_number): Remove for now, as it's unused.
1651 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1652 (record_buffer): Remove unused local.
1653 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1654 (set_frame_buffer_list): Remove; unused.
1655 * frame.h (other_visible_frames): Remove decl.
1656 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1657 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1658 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1660 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1661 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1662 Define only if HAVE_GPM.
1663 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1664 (update_hints_inhibit): Remove; never set. All uses removed.
1665 * widgetprv.h (emacsFrameClassRec): Remove decl.
1666 * window.c (delete_deletable_window): Now returns void, since it
1667 wasn't returning anything.
1668 (compare_window_configurations): Remove unused locals.
1669 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1670 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1671 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1672 the same widths as pointers. This follows up on the 2011-05-06 patch.
1673 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1674 * xterm.h: Likewise.
1675 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1677 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1679 * makefile.w32-in: Update dependencies.
1680 (LISP_H): Add lib/intprops.h.
1682 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1684 * image.c (gif_load): Add animation frame delay to the metadata.
1685 (syms_of_image): Use DEFSYM. New symbol `delay'.
1687 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1689 * window.c (delete_deletable_window): Re-add.
1690 (Fset_window_configuration): Rewrite to handle dead buffers and
1691 consequently deletable windows.
1692 (window_tree, Fwindow_tree): Remove. Supply functionality in
1694 (compare_window_configurations): Simplify code.
1696 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1698 * image.c (imagemagick_load_image): Fix type mismatch.
1699 (Fimagemagick_types): Likewise.
1701 * window.h (replace_buffer_in_windows): Declare.
1703 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1705 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1706 Qclone_number. Remove external declaration of Qdelete_window.
1707 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1709 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1710 Qbuffer_list_update_hook if allowed.
1711 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1712 buffer list implementation.
1713 (other_buffer_safely): New function.
1714 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1715 calls to replace_buffer_in_windows and
1716 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1718 (record_buffer): Inhibit quitting and rewrite using quittable
1719 functions. Run Qbuffer_list_update_hook if allowed.
1720 (Frecord_buffer, Funrecord_buffer): New functions.
1721 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1722 switch-to-buffer to window.el.
1723 (bury-buffer): Move to window.el.
1724 (Vbuffer_list_update_hook): New variable.
1726 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1729 * window.h (resize_frame_windows): Move up in code.
1730 (Fwindow_frame): Remove EXFUN.
1731 (replace_buffer_in_all_windows): Remove prototype.
1732 (replace_buffer_in_windows_safely): Add prototype.
1734 * window.c: Declare Qdelete_window static again. Move down
1735 declaration of select_count.
1736 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1737 (Fother_window): Move to window.el.
1738 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1739 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1740 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1742 (replace_buffer_in_windows): Implement by calling
1743 Qreplace_buffer_in_windows.
1744 (replace_buffer_in_all_windows): Remove with some functionality
1745 moved into replace_buffer_in_windows_safely.
1746 (replace_buffer_in_windows_safely): New function.
1747 (select_window_norecord, select_frame_norecord): Move in front
1748 of run_window_configuration_change_hook. Remove now obsolete
1750 (Fset_window_buffer): Rewrite doc-string. Call
1751 Qrecord_window_buffer.
1752 (keys_of_window): Move binding for other-window to window.el.
1754 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1756 * dispextern.h (struct image): Replace data member, whose int_val
1757 and ptr_val fields were not used by anything, with a single
1760 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1761 (gif_clear_image, gif_load, imagemagick_load_image)
1762 (gs_clear_image, gs_load): Callers changed.
1764 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1766 * buffer.h: Include <time.h>, for time_t.
1767 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1769 Fix minor problems found by static checking.
1771 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1773 Make identifiers static if they are not used in other modules.
1774 * data.c (Qcompiled_function, Qframe, Qvector):
1775 * image.c (QimageMagick, Qsvg):
1776 * minibuf.c (Qmetadata):
1777 * window.c (resize_window_check, resize_root_window): Now static.
1778 * window.h (resize_window_check, resize_root_window): Remove decls.
1780 * window.c (window_deletion_count, delete_deletable_window):
1782 (window_body_lines): Now static.
1783 (Fdelete_other_windows_internal): Mark vars as initialized.
1784 Make sure 'resize_failed' is initialized.
1785 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1786 (resize_window_apply): Remove unused local.
1787 * window.h (delete_deletable_window): Remove decl.
1789 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1790 (imagemagick_load_image): Fix pointer signedness problem by changing
1791 last arg from unsigned char * to char *. All uses changed.
1792 Also, fix a local for similar reasons.
1793 Remove unused locals. Remove locals to avoid shadowing.
1794 (fn_rsvg_handle_free): Remove; unused.
1795 (svg_load, svg_load_image): Fix pointer signedness problem.
1796 (imagemagick_load_image): Don't use garbage pointer image_wand.
1798 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1800 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1802 * image.c (gif_load): Fix omitted cast error introduced by
1805 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1807 * window.h (resize_proportionally, orig_total_lines)
1808 (orig_top_line): Remove from window structure.
1809 (set_window_height, set_window_width, change_window_heights)
1810 (Fdelete_window): Remove prototypes.
1811 (resize_frame_windows): Remove duplicate declaration.
1813 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1815 * window.h (resize_frame_windows, resize_window_check)
1816 (delete_deletable_window, resize_root_window)
1817 (resize_frame_windows): Declare prototypes.
1819 * window.c (resize_window_apply): Make definition be "static" to
1820 match the prototype.
1822 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1824 * window.c: Remove declarations of Qwindow_size_fixed,
1825 window_min_size_1, window_min_size_2, window_min_size,
1826 size_window, window_fixed_size_p, enlarge_window, delete_window.
1827 Remove static from declaration of Qdelete_window, it's
1828 temporarily needed by Fbury_buffer.
1829 (replace_window): Don't assign orig_top_line and
1831 (Fdelete_window, delete_window): Remove. Window deletion is
1832 handled by window.el.
1833 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1834 Fdelete_window calls with calls to Qdelete_window.
1835 (Fdelete_other_windows): Remove. Deleting other windows is
1836 handled by window.el.
1837 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1838 handled in window.el.
1839 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1840 Window minimum sizes are handled in window.el.
1841 (shrink_windows, size_window, set_window_height)
1842 (set_window_width, change_window_heights, window_height)
1843 (window_width, CURBEG, CURSIZE, enlarge_window)
1844 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1845 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1846 handled in window.el.
1847 (make_dummy_parent): Rename to make_parent_window and give it a
1848 second argument horflag.
1849 (make_window): Don't set resize_proportionally any more.
1850 (Fsplit_window): Remove. Windows are split in window.el.
1851 (save_restore_action, save_restore_orig_size)
1852 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1853 Resize mini windows in window.el.
1854 (grow_mini_window, shrink_mini_window): Implement by calling
1855 Qresize_root_window_vertically, resize_window_check and
1856 resize_window_apply.
1857 (saved_window, Fset_window_configuration, save_window_save): Do
1858 not handle orig_top_line, orig_total_lines, and
1859 resize_proportionally.
1860 (window_min_height, window_min_width): Move to window.el.
1861 (keys_of_window): Move bindings for delete-other-windows,
1862 split-window, delete-window and enlarge-window to window.el.
1864 * buffer.c: Temporarily extern Qdelete_window.
1865 (Fbury_buffer): Temporarily call Qdelete_window instead of
1866 Fdelete_window (Fbury_buffer will move to window.el soon).
1868 * frame.c (set_menu_bar_lines_1): Remove code handling
1869 orig_top_line and orig_total_lines.
1871 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1872 set_window_height but set heights directly.
1873 (change_frame_size_1): Use resize_frame_windows.
1875 * xdisp.c (init_xdisp): Don't use set_window_height but set
1878 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1879 resize_frame_windows instead of change_window_heights and run
1880 run_window_configuration_change_hook.
1882 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1883 instead of change_window_heights and run
1884 run_window_configuration_change_hook.
1886 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1888 * window.c (replace_window): Rename second argument REPLACEMENT to
1889 NEW. New third argument SETFLAG. Rewrite.
1890 (delete_window, make_dummy_parent): Call replace_window with
1892 (window_list_1): Move down in code.
1893 (run_window_configuration_change_hook): Move set_buffer part
1894 before select_frame_norecord part in order to unwind correctly.
1895 Rename count1 to count.
1896 (recombine_windows, delete_deletable_window, resize_root_window)
1897 (Fdelete_other_windows_internal)
1898 (Frun_window_configuration_change_hook, make_parent_window)
1899 (resize_window_check, resize_window_apply, Fresize_window_apply)
1900 (resize_frame_windows, Fsplit_window_internal)
1901 (Fdelete_window_internal, Fresize_mini_window_internal): New
1903 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1905 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1907 * window.h (window): Add some new members to window structure -
1908 normal_lines, normal_cols, new_total, new_normal, clone_number,
1909 splits, nest, prev_buffers, next_buffers.
1910 (WINDOW_TOTAL_SIZE): Move here from window.c.
1911 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1913 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1915 (make_dummy_parent): Set new members of windows structure.
1916 (make_window): Move down in code. Handle new members of window
1918 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1919 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1920 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1921 (Fset_window_prev_buffers, Fwindow_next_buffers)
1922 (Fset_window_next_buffers, Fset_window_clone_number): New
1924 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1925 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1927 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1928 Argument WINDOW can be now internal window too.
1929 (Fwindow_use_time): Move up in code.
1930 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1932 (Fset_window_configuration, saved_window)
1933 (Fcurrent_window_configuration, save_window_save): Handle new
1934 members of window structure.
1935 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1936 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1937 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1938 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1939 Qget_mru_window, Qresize_root_window,
1940 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1941 Qauto_buffer_name; staticpro them.
1943 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1945 * window.c (Fwindow_total_size, Fwindow_left_column)
1946 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1947 (Fwindow_list_1): New functions.
1948 (window_box_text_cols): Replace with window_body_cols.
1949 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1950 window_body_cols instead of window_box_text_cols.
1951 (delete_window, Fset_window_configuration): Call
1952 delete_all_subwindows with window as argument.
1953 (delete_all_subwindows): Take a window as argument and not a
1955 (window_loop): Remove handling of GET_LRU_WINDOW and
1957 (Fget_lru_window, Fget_largest_window): Move to window.el.
1959 * window.h: Extern window_body_cols instead of
1960 window_box_text_cols. delete_all_subwindows now takes a
1961 Lisp_Object as argument.
1963 * indent.c (compute_motion, Fcompute_motion): Use
1964 window_body_cols instead of window_box_text_cols.
1966 * frame.c (delete_frame): Call delete_all_subwindows with root
1969 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1971 * fns.c (Fputhash): Document return value.
1973 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1975 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1977 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1979 Cons<->int and similar integer overflow fixes (Bug#8794).
1981 Check for overflow when converting integer to cons and back.
1982 * charset.c (Fdefine_charset_internal, Fdecode_char):
1983 Use cons_to_unsigned to catch overflow.
1984 (Fencode_char): Use INTEGER_TO_CONS.
1985 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1986 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1987 * data.c (long_to_cons, cons_to_long): Remove.
1988 (cons_to_unsigned, cons_to_signed): New functions.
1989 These signal an error for invalid or out-of-range values.
1990 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1991 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1992 * font.c (Ffont_variation_glyphs):
1993 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1994 * lisp.h: Include <intprops.h>.
1995 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1996 (cons_to_signed, cons_to_unsigned): New decls.
1997 (long_to_cons, cons_to_long): Remove decls.
1998 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1999 (Fprimitive_undo): Use CONS_TO_INTEGER.
2000 * xfns.c (Fx_window_property): Likewise.
2001 * xselect.c: Include <limits.h>.
2002 (x_own_selection, selection_data_to_lisp_data):
2003 Use INTEGER_TO_CONS.
2004 (x_handle_selection_request, x_handle_selection_clear)
2005 (x_get_foreign_selection, Fx_disown_selection_internal)
2006 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2007 (lisp_data_to_selection_data): Use cons_to_unsigned.
2008 (x_fill_property_data): Use cons_to_signed.
2009 Report values out of range.
2011 Check for buffer and string overflow more precisely.
2012 * buffer.h (BUF_BYTES_MAX): New macro.
2013 * lisp.h (STRING_BYTES_MAX): New macro.
2014 * alloc.c (Fmake_string):
2015 * character.c (string_escape_byte8):
2016 * coding.c (coding_alloc_by_realloc):
2017 * doprnt.c (doprnt):
2018 * editfns.c (Fformat):
2020 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2021 since they may not be the same number.
2022 * editfns.c (Finsert_char):
2023 * fileio.c (Finsert_file_contents):
2024 Likewise for BUF_BYTES_MAX.
2026 * image.c: Use ptrdiff_t, not int, for sizes.
2027 (slurp_file): Switch from int to ptrdiff_t.
2029 (slurp_file): Check that file size fits in both size_t (for
2030 malloc) and ptrdiff_t (for sanity and safety).
2032 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2033 if b->modtime has its maximal value.
2035 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2037 Don't assume time_t can fit into int.
2038 * buffer.h (struct buffer.modtime): Now time_t, not int.
2039 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2040 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2042 Minor fixes for signed vs unsigned integers.
2043 * character.h (MAYBE_UNIFY_CHAR):
2044 * charset.c (maybe_unify_char):
2045 * keyboard.c (read_char, reorder_modifiers):
2046 XINT -> XFASTINT, since the integer must be nonnegative.
2047 * ftfont.c (ftfont_spec_pattern):
2048 * keymap.c (access_keymap, silly_event_symbol_error):
2049 XUINT -> XFASTINT, since the integer must be nonnegative.
2050 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2051 since it makes no difference and we prefer signed.
2052 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2053 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2056 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2058 * window.h (Fwindow_frame): Declare.
2060 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2062 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2063 (SPARE_MEMORY): Always define.
2064 (LARGE_REQUEST): Remove.
2065 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2067 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2069 * lisp.h: Move EXFUNS for Fframe_root_window,
2070 Fframe_first_window and Fset_frame_selected_window to window.h.
2072 * window.h: Move EXFUNS for Fframe_root_window,
2073 Fframe_first_window and Fset_frame_selected_window here from
2076 * frame.c (Fwindow_frame, Fframe_first_window)
2077 (Fframe_root_window, Fframe_selected_window)
2078 (Fset_frame_selected_window): Move to window.c.
2079 (Factive_minibuffer_window): Move to minibuf.c.
2080 (Fother_visible_frames_p): New function.
2082 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2084 * window.c (decode_window, decode_any_window): Move up in code.
2085 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2086 (inhibit_frame_unsplittable): Remove unused variable.
2087 (Fwindow_buffer): Move up and rewrite doc-string.
2088 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2089 (Fwindow_prev): New functions.
2090 (Fwindow_frame): Move here from frame.c. Accept any window as
2092 (Fframe_root_window, Fframe_first_window)
2093 (Fframe_selected_window): Move here from frame.c. Accept frame
2094 or arbitrary window as argument. Update doc-strings.
2095 (Fminibuffer_window): Move up in code.
2096 (Fwindow_minibuffer_p): Move up in code and simplify.
2097 (Fset_frame_selected_window): Move here from frame.c.
2099 (Fselected_window, select_window, Fselect_window): Move up in
2100 code. Minor doc-string fixes.
2102 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2104 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2105 Do not assume that spare memory exists; that assumption is valid
2106 only if SYSTEM_MALLOC.
2107 (LARGE_REQUEST): New macro, so that the issue of large requests
2108 is separated from the issue of spare memory.
2110 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2112 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2115 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2117 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2120 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2122 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2124 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2126 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2127 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2129 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2131 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2133 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2135 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2136 (x_clipboard_manager_save): Add return value.
2137 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2139 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2140 Obey Vx_select_enable_clipboard_manager. Catch errors in
2141 x_clipboard_manager_save (Bug#8779).
2142 (Vx_select_enable_clipboard_manager): New variable.
2143 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2145 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2147 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2149 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2151 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2152 in the current matrix if keep_current_p is non-zero.
2154 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2156 * bidi.c (bidi_level_of_next_char): Fix last change.
2158 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2160 Support bidi reordering of text covered by display properties.
2162 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2163 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2164 (bidi_cache_search, bidi_cache_iterator_state)
2165 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2166 (bidi_level_of_next_char, bidi_move_to_visually_next):
2167 Support character positions inside a run of characters covered by a
2169 (bidi_paragraph_init, bidi_resolve_explicit_1)
2170 (bidi_level_of_next_char): Call bidi_fetch_char and
2171 bidi_fetch_char_advance instead of FETCH_CHAR and
2173 (bidi_init_it): Initialize new members.
2174 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2176 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2177 instead of using explicit *_CHAR codes.
2178 (bidi_resolve_explicit, bidi_resolve_weak):
2179 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2180 bidirectional text is supported only in multibyte buffers.
2181 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2182 it to initialize the frame_window_p member of struct bidi_it.
2183 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2184 (bidi_resolve_explicit, bidi_resolve_weak)
2185 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2186 bidi_it->nchars is non-positive.
2187 (bidi_level_of_next_char): Don't try to lookup the cache for the
2188 next/previous character if nothing is cached there yet, or if we
2189 were just reseat()'ed to a new position.
2191 * xdisp.c (set_cursor_from_row): Set start and stop points
2192 according to the row's direction when priming the loop that looks
2193 for the glyph on which to display cursor.
2194 (single_display_spec_intangible_p): Function deleted.
2195 (display_prop_intangible_p): Reimplement to call
2196 handle_display_spec instead of single_display_spec_intangible_p.
2197 Accept 3 additional arguments needed by handle_display_spec.
2198 This fixes incorrect cursor motion across display property with complex
2199 values: lists, `(when COND...)' forms, etc.
2200 (single_display_spec_string_p): Support property values that are
2201 lists with the argument STRING its top-level element.
2202 (display_prop_string_p): Fix the condition for processing a
2203 property that is a list to be consistent with handle_display_spec.
2204 (handle_display_spec): New function, refactored from the
2205 last portion of handle_display_prop.
2206 (compute_display_string_pos): Accept additional argument
2207 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2208 value of a `display' property is a "replacing spec".
2209 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2210 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2211 the display property, but just return a value indicating whether
2212 the display property will replace the characters it covers.
2213 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2214 frame_window_p members of struct bidi_it.
2215 (compute_display_string_pos, compute_display_string_end):
2217 (push_it): Accept second argument POSITION, where pop_it should
2218 jump to continue iteration.
2219 (reseat_1): Initialize bidi_it.disp_pos.
2221 * keyboard.c (adjust_point_for_property): Adjust the call to
2222 display_prop_intangible_p to its new signature.
2224 * dispextern.h (struct bidi_it): New member frame_window_p.
2225 (bidi_init_it): Update prototypes.
2226 (display_prop_intangible_p): Update prototype.
2227 (compute_display_string_pos, compute_display_string_end):
2229 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2232 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2234 Malloc failure behavior now depends on size of allocation.
2235 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2236 * lisp.h: Change signatures accordingly.
2237 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2238 All callers changed. (Bug#8762)
2240 * gnutls.c: Use Emacs's memory allocators.
2241 Without this change, the gnutls library would invoke malloc etc.
2242 directly, which causes problems on non-SYNC_INPUT hosts, and which
2243 runs afoul of improving memory_full behavior. (Bug#8761)
2244 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2245 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2246 xfree instead of the default malloc, realloc, free.
2247 (Fgnutls_boot): No need to check for memory allocation failure,
2248 since xmalloc does that for us.
2250 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2251 * category.c (hash_get_category_set):
2252 * ccl.c (ccl_driver):
2253 * charset.c (Fdefine_charset_internal):
2254 * charset.h (struct charset.hash_index):
2255 * composite.c (get_composition_id, gstring_lookup_cache)
2256 (composition_gstring_put_cache):
2257 * composite.h (struct composition.hash_index):
2258 * dispextern.h (struct image.hash):
2259 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2260 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2261 (hashfn_equal, hashfn_user_defined, make_hash_table)
2262 (maybe_resize_hash_table, hash_lookup, hash_put)
2263 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2264 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2265 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2266 * image.c (make_image, search_image_cache, lookup_image)
2267 (xpm_put_color_table_h):
2268 * lisp.h (struct Lisp_Hash_Table):
2269 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2270 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2271 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2272 * alloc.c (allocate_vectorlike):
2273 Check for overflow in vector size calculations.
2274 * ccl.c (ccl_driver):
2275 Check for overflow when converting EMACS_INT to int.
2276 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2277 need to be updated by these changes.
2278 * fns.c (make_hash_table, maybe_resize_hash_table):
2279 Check for integer overflow with large hash tables.
2280 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2281 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2282 (SXHASH_REDUCE): New macro.
2283 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2284 Use it instead of discarding useful hash info with large hash values.
2285 (sxhash_float): New function.
2286 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2287 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2288 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2289 Rewrite to use FIXNUM_BITS, as this simplifies things.
2290 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2291 Adjust signatures to match updated version of code.
2292 (consing_since_gc): Now EMACS_INT, since a single hash table can
2293 use more than INT_MAX bytes.
2295 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2297 Make it possible to build with GCC-4.6+ -O2 -flto.
2299 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2301 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2303 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2304 Call minibuffer-inactive-mode.
2306 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2308 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2309 Update dependencies.
2311 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2313 * data.c (init_data): Remove code for UTS, this system is not
2316 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2318 Don't force ./temacs to start in terminal mode.
2320 * frame.c (make_initial_frame): Initialize faces in all cases, not
2321 only when CANNOT_DUMP is defined.
2322 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2324 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2326 * dispnew.c (add_window_display_history): Use const for the string
2327 pointer. Remove declaration, not needed.
2329 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2331 Use 'inline', not 'INLINE'.
2332 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2333 * alloc.c, fontset.c (INLINE): Remove.
2334 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2335 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2336 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2337 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2338 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2340 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2342 Make it possible to run ./temacs.
2344 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2345 syms_of_callproc does the same thing. Remove test for
2346 "initialized", do it in the caller.
2347 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2349 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2351 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2352 (read_minibuf): Use get_minibuffer.
2353 (syms_of_minibuf): Use DEFSYM.
2354 (Qmetadata): New var.
2355 * data.c (Qbuffer): Don't make it static.
2356 (syms_of_data): Use DEFSYM.
2358 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2360 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2361 (CCL_CODE_MIN): New macro.
2363 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2365 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2367 * eval.c (Qdebug): Now static.
2368 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2369 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2370 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2372 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2374 * image.c: Various fixes to ImageMagick code comments.
2375 (Fimagemagick_types): Doc fix.
2377 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2379 Minor fixes prompted by GCC 4.6.0 warnings.
2381 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2383 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2384 (x_clipboard_manager_save_all): Move extern decl to ...
2385 * xterm.h: ... here, so that it can be checked for consistency.
2387 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2389 * xselect.c (x_clipboard_manager_save_frame)
2390 (x_clipboard_manager_save_all): New functions.
2391 (Fx_clipboard_manager_save): Lisp function deleted.
2393 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2394 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2396 * xterm.h: Update prototype.
2398 2011-05-28 William Xu <william.xwl@gmail.com>
2400 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2403 2011-05-28 Jim Meyering <meyering@redhat.com>
2405 Avoid a sign-extension bug in crypto_hash_function.
2406 * fns.c (to_uchar): Define.
2407 (crypto_hash_function): Use it to convert some newly-signed
2408 variables to unsigned, to avoid sign-extension bugs. For example,
2409 without this change, (md5 "truc") would evaluate to
2410 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2411 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2412 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2414 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2416 Integer overflow fixes.
2418 * dbusbind.c: Serial number integer overflow fixes.
2419 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2420 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2421 to hold a serial number that is too large for a fixnum.
2422 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2423 Check for serial numbers out of range. Decode any serial number
2424 that was so large that it became a float. (Bug#8722)
2426 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2427 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2428 Use XFASTINT rather than XUINT when numbers are nonnegative.
2429 (xd_append_arg, Fdbus_method_return_internal):
2430 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2431 arguments, check that Lisp number is nonnegative, rather than
2432 silently wrapping negative numbers around. (Bug#8722)
2433 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2436 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2438 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2440 ccl: add integer overflow checks
2441 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2442 (IN_INT_RANGE): New macros.
2443 (ccl_driver): Use them to check for integer overflow when
2444 decoding a CCL program. Many of the new checks are whether XINT (x)
2445 fits in int; it doesn't always, on 64-bit hosts. The new version
2446 doesn't catch all possible integer overflows, but it's an
2447 improvement. (Bug#8719)
2449 * alloc.c (make_event_array): Use XINT, not XUINT.
2450 There's no need for unsigned here.
2452 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2453 This follows up to the 2011-05-06 change that substituted uintptr_t
2454 for EMACS_INT. This case wasn't caught back then.
2456 Rework Fformat to avoid integer overflow issues.
2457 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2458 now (part of C89). Include <verify.h>.
2459 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2460 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2461 (Fformat): Avoid the prepass trying to compute sizes; it was only
2462 approximate and thus did not catch overflow reliably. Instead, walk
2463 through the format just once, formatting and computing sizes as we go,
2464 checking for integer overflow at every step, and allocating a larger
2465 buffer as needed. Keep track separately whether the format is
2466 multibyte. Keep only the most-recently calculated precision, rather
2467 than them all. Record whether each argument has been converted to
2468 string. Use EMACS_INT, not int, for byte and char and arg counts.
2469 Support field widths and precisions larger than INT_MAX. Avoid
2470 sprintf's undefined behavior with conversion specifications such as %#d
2471 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2472 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2473 formatting out-of-range floating point numbers with int
2476 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2478 * data.c: Avoid integer truncation in expressions involving floats.
2479 * data.c: Include <intprops.h>.
2480 (arith_driver): When there's an integer overflow in an expression
2481 involving floating point, convert the integers to floating point
2482 so that the resulting value does not suffer from catastrophic
2483 integer truncation. For example, on a 64-bit host (* 4
2484 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2485 Do not rely on undefined behavior after integer overflow.
2487 merge count_size_as_multibyte, parse_str_to_multibyte
2488 * character.c, character.h (count_size_as_multibyte):
2489 Rename from parse_str_to_multibyte; all uses changed.
2490 Check for integer overflow.
2491 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2492 since it's now a duplicate of the other. This is more of
2493 a character than a buffer op, so better that it's in character.c.
2494 * fns.c, print.c: Adjust to above changes.
2496 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2498 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2500 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2502 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2503 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2504 (x_clipboard_manager_save): Now static.
2505 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2507 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2508 (crypto_hash_function): Now static.
2509 Fix pointer signedness problems. Avoid unnecessary initializations.
2511 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2513 * termhooks.h (Vselection_alist): Make it terminal-local.
2515 * terminal.c (create_terminal): Initialize it.
2517 * xselect.c: Support for clipboard managers.
2518 (Vselection_alist): Move to termhooks.h as terminal-local var.
2519 (LOCAL_SELECTION): New macro.
2520 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2521 (symbol_to_x_atom): Remove gratuitous arg.
2522 (x_handle_selection_request, lisp_data_to_selection_data)
2523 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2524 (x_own_selection, x_get_local_selection, x_convert_selection):
2525 New arg, specifying work frame. Use terminal-local Vselection_alist.
2526 (some_frame_on_display): Delete unused function.
2527 (Fx_own_selection_internal, Fx_get_selection_internal)
2528 (Fx_disown_selection_internal, Fx_selection_owner_p)
2529 (Fx_selection_exists_p): New optional frame arg.
2530 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2531 (x_handle_selection_clear): Don't treat other terminals with the
2532 same keyboard specially. Use the terminal-local Vselection_alist.
2533 (x_clear_frame_selections): Use Frun_hook_with_args.
2535 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2537 * xterm.h: Add support for those atoms.
2539 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2541 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2542 (converted_selections, conversion_fail_tag): New global variables.
2543 (x_selection_request_lisp_error): Free the above.
2544 (x_get_local_selection): Remove unnecessary code.
2545 (x_reply_selection_request): Args changed; handle arbitrary array
2546 of converted selections stored in converted_selections.
2547 Separate the XChangeProperty and SelectionNotify steps.
2548 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2549 (x_convert_selection): New function.
2550 (x_handle_selection_event): Simplify.
2551 (x_get_foreign_selection): Don't ignore incoming requests while
2552 waiting for an answer; this will fail when we implement
2553 SAVE_TARGETS, and seems unnecessary anyway.
2554 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2555 (Vx_sent_selection_functions): Doc fix.
2557 2011-05-26 Leo Liu <sdl.web@gmail.com>
2559 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2561 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2563 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2565 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2566 for fringe update if it has periodic bitmap.
2567 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2568 and fringe_bitmap_periodic_p.
2570 * fringe.c (get_fringe_bitmap_data): New function.
2571 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2572 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2573 row. Mark glyph row for fringe update if periodicity changed.
2575 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2576 for fringe update unless it has periodic bitmap.
2578 2011-05-25 Kenichi Handa <handa@m17n.org>
2580 * xdisp.c (get_next_display_element): Set correct it->face_id for
2581 a static composition.
2583 2011-05-24 Leo Liu <sdl.web@gmail.com>
2586 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2588 * fns.c (crypto_hash_function, Fsha1): New function.
2589 (Fmd5): Use crypto_hash_function.
2590 (syms_of_fns): Add Ssha1.
2592 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2594 * gnutls.c: Remove unused macros.
2595 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2596 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2597 Remove macros that are defined and never used.
2598 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2600 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2602 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2603 (Fx_get_selection_internal): Minor cleanup.
2604 (Fx_own_selection_internal): Rename arguments for consistency with
2607 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2609 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2611 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2613 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2615 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2617 * dispnew.c (scrolling_window): Don't exclude the case that the
2618 last enabled row in the desired matrix touches the bottom boundary.
2620 2011-05-21 Glenn Morris <rgm@gnu.org>
2622 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2623 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2624 and add some more files.
2626 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2628 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2629 report_file_error introduced by the change from 2011-05-07.
2631 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2633 * systime.h (Time): Define only if emacs is defined.
2634 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2635 where the include path doesn't have X11/X.h by default. See
2636 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2638 2011-05-20 Kenichi Handa <handa@m17n.org>
2640 * composite.c (find_automatic_composition): Fix previous change.
2642 2011-05-20 Glenn Morris <rgm@gnu.org>
2644 * lisp.mk: New file, split from Makefile.in.
2645 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2646 (shortlisp): Remove.
2647 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2649 2011-05-19 Glenn Morris <rgm@gnu.org>
2651 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2652 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2653 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2654 (lisp): Set the order to that of loadup.el.
2655 (shortlisp): Make it a copy of $lisp.
2656 (SOME_MACHINE_LISP): Remove.
2657 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2658 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2660 2011-05-18 Kenichi Handa <handa@m17n.org>
2662 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2663 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2664 (find_automatic_composition): Mostly rewrite for efficiency.
2666 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2668 * makefile.w32-in: Update dependencies.
2670 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2672 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2673 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2675 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2677 Fix some integer overflow issues, such as string length overflow.
2679 * insdel.c (count_size_as_multibyte): Check for string overflow.
2681 * character.c (lisp_string_width): Check for string overflow.
2682 Use EMACS_INT, not int, for string indexes and lengths; in
2683 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2684 the resulting string length overflows an EMACS_INT; instead,
2685 report a string overflow if no precision given. When checking for
2686 precision exhaustion, use a check that cannot possibly have
2687 integer overflow. (Bug#8675)
2688 * character.h (lisp_string_width): Adjust to new signature.
2690 * alloc.c (string_overflow): New function.
2691 (Fmake_string): Use it. This doesn't change behavior, but saves
2692 a few bytes and will simplify future changes.
2693 * character.c (string_escape_byte8): Likewise.
2694 * lisp.h (string_overflow): New decl.
2696 Fixups, following up to the user-interface timestamp change.
2697 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2698 for UI timestamps, instead of unsigned long.
2699 * msdos.c (mouse_get_pos): Likewise.
2700 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2701 * w32gui.h (Time): Define by including "systime.h" rather than by
2702 declaring it ourselves. (Bug#8664)
2704 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2705 * image.c (clear_image_cache): Likewise.
2707 * term.c (term_mouse_position): Don't assume time_t wraparound.
2709 Be more systematic about user-interface timestamps.
2710 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2711 and sometimes 'EMACS_UINT', to represent these timestamps.
2712 This change causes it to use 'Time' uniformly, as that's what X uses.
2713 This makes the code easier to follow, and makes it easier to catch
2714 integer overflow bugs such as Bug#8664.
2715 * frame.c (Fmouse_position, Fmouse_pixel_position):
2716 Use Time, not unsigned long, for user-interface timestamps.
2717 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2718 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2719 * keyboard.h (last_event_timestamp): Likewise.
2720 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2721 * menu.h (xmenu_show): Likewise.
2722 * term.c (term_mouse_position): Likewise.
2723 * termhooks.h (struct input_event.timestamp): Likewise.
2724 (struct terminal.mouse_position_hook): Likewise.
2725 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2726 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2727 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2728 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2730 * menu.h, termhooks.h: Include "systime.h", for Time.
2732 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2733 Don't assume that the difference between two unsigned long values
2734 can fit into an integer. At this point, we know button_down_time
2735 <= event->timestamp, so the difference must be nonnegative, so
2736 there's no need to cast the result if double-click-time is
2737 nonnegative, as it should be; check that it's nonnegative, just in
2738 case. This bug is triggered when events are more than 2**31 ms
2739 apart (about 25 days). (Bug#8664)
2741 * xselect.c (last_event_timestamp): Remove duplicate decl.
2742 (x_own_selection): Remove needless cast to unsigned long.
2744 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2745 that always fit in int. Use a sentinel instead of a counter, to
2746 avoid a temp and to allay GCC's concerns about possible int overflow.
2747 * frame.h (struct frame): Use int for menu_bar_items_used
2748 instead of EMACS_INT, since it always fits in int.
2750 * menu.c (grow_menu_items): Check for int overflow.
2752 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2754 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2755 Before, the code was not consistent. These values cannot exceed
2756 2**31 - 1 so there's no need to make them unsigned.
2757 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2758 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2759 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2761 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2763 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2764 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2765 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2766 presumably because the widths might not match.
2768 * window.c (size_window): Avoid needless test at loop start.
2770 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2772 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2774 2011-05-12 Drew Adams <drew.adams@oracle.com>
2776 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2778 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2780 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2781 `width' to `bar_area_x' and `bar_area_width', respectively.
2782 (x_scroll_run): Take account of fringe background extension.
2784 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2785 Rename local vars `left' and `width' to `bar_area_x' and
2786 `bar_area_width', respectively.
2787 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2788 background extension.
2790 2011-05-10 Jim Meyering <meyering@redhat.com>
2792 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2794 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2796 * image.c (Finit_image_library): Return t for built-in image types,
2797 like pbm and xbm. (Bug#8640)
2799 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2801 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2803 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2805 * w32console.c (Fset_screen_color): Doc fix.
2806 (Fget_screen_color): New function.
2807 (syms_of_ntterm): Defsubr it.
2809 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2810 unlink the temporary file if Fcall_process didn't create it in the
2812 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2813 child process will be redirected to a file specified with `:file'.
2814 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2815 cue to call_process_cleanup not to close that handle.
2817 2011-05-07 Ben Key <bkey76@gmail.com>
2819 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2820 one of two shell specific rules, either bootstrap-temacs-CMD or
2821 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2822 to the previous implementation of the bootstrap-temacs rule.
2823 The bootstrap-temacs-CMD rule is similar to the previous
2824 implementation of the bootstrap-temacs rule except that it
2825 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2828 These changes, along with some changes to nt/configure.bat,
2829 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2830 earlier fix to add support for --cflags and --ldflags options
2831 that include quotes so that it works whether make uses cmd or
2834 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2836 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2837 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2839 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2840 a string. Handle both cases.
2841 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2842 (Fdbus_register_method): Use Qinvalid_function.
2844 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2846 * makefile.w32-in: Update dependencies.
2847 (LISP_H): Add inttypes.h and stdin.h.
2848 (PROCESS_H): Add unistd.h.
2850 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2852 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2853 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2855 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2857 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2859 * term.c (vfatal): Remove stray call to va_end.
2860 It's not needed and the C Standard doesn't allow it here anyway.
2862 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2863 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2865 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2868 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2870 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2872 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2874 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2876 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2878 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2879 * charset.c (Fdefine_charset_internal): Don't initialize
2880 charset.code_space[15]. The value was garbage, on hosts with
2881 32-bit int (Bug#8600).
2883 * lread.c (read_integer): Be more consistent with string-to-number.
2884 Use string_to_number to do the actual conversion; this avoids
2885 rounding errors and fixes some other screwups. Without this fix,
2886 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2887 (digit_to_number): Move earlier, for benefit of read_integer.
2888 Return -1 if the digit is out of range for the base, -2 if it is
2889 not a digit in any supported base. (Bug#8602)
2891 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2893 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2894 to match comment at start of function. This also removes a
2895 GCC warning about overflow in a 32+64-bit port.
2897 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2899 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2900 Reported by Stefan Monnier in
2901 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2902 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2903 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2905 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2906 (EMACS_UINTPTR): Likewise, with uintptr_t.
2908 * lisp.h: Prefer 64-bit EMACS_INT if available.
2909 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2910 on 32-bit hosts that have 64-bit int, so that they can access
2912 However, temporarily disable this change unless the temporary
2913 symbol WIDE_EMACS_INT is defined.
2915 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2917 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2918 This removes an assumption that EMACS_INT and long are the same
2919 width as pointers. The assumption is true for Emacs porting targets
2920 now, but we want to make other targets possible.
2921 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2922 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2923 In the rest of the code, change types of integers that hold casted
2924 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2925 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2926 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2927 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2928 No need to cast type when ORing.
2929 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2930 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2931 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2932 assume EMACS_INT is the same width as char *.
2933 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2934 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2935 Remove no-longer-needed casts.
2936 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2937 (xg_tool_bar_help_callback, xg_make_tool_item):
2938 Use EMACS_INTPTR to hold an integer
2939 that will be cast to void *; this can avoid a GCC warning
2940 if EMACS_INT is not the same width as void *.
2941 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2942 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2943 (current_message_1, set_message_1):
2944 Use a local to convert to proper width without a cast.
2945 * xmenu.c (dialog_selection_callback): Likewise.
2947 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2948 Also, don't assume VALBITS / RAND_BITS is less than 5,
2949 and don't rely on undefined behavior when shifting a 1 left into
2951 * lisp.h (get_random): Change signature to match.
2953 * lread.c (hash_string): Use size_t, not int, for hash computation.
2954 Normally we prefer signed values; but hashing is special, because
2955 it's better to use unsigned division on hash table sizes so that
2956 the remainder is nonnegative. Also, size_t is the natural width
2957 for hashing into memory. The previous code used 'int', which doesn't
2958 retain enough info to hash well into very large tables.
2959 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2961 * dbusbind.c: Don't possibly lose pointer info when converting.
2962 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2963 Use XPNTR rather than XHASH, so that the high-order bits of
2964 the pointer aren't lost when converting through void *.
2966 * eval.c (Fautoload): Don't double-shift a pointer.
2968 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2970 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2972 * gnutls.c (DEF_GNUTLS_FN):
2973 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2975 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2977 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2980 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2982 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2983 New version that can reserve upto 2GB of heap space.
2985 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2987 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2989 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2991 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2992 `gnutls_certificate_set_x509_key_file'.
2994 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2996 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2997 Update dependencies.
2999 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3001 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3002 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3003 Remove unused parameter `fildes'.
3004 * process.c (read_process_output, send_process): Don't pass it.
3006 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3008 Fix previous change: the library cache is defined in w32.c.
3009 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3010 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3012 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3014 Implement dynamic loading of GnuTLS on Windows.
3016 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3017 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3018 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3021 * gnutls.c (Qgnutls_dll): Define.
3022 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3023 (gnutls_*): Declare function pointers.
3024 (init_gnutls_functions): New function to initialize function pointers.
3025 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3026 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3027 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3028 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3029 (emacs_gnutls_write, emacs_gnutls_read)
3030 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3031 (Fgnutls_available_p): New function.
3032 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3033 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3034 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3036 * image.c: Include w32.h.
3037 (Vimage_type_cache): Delete.
3038 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3039 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3040 (w32_delayed_load): Move to w32.c.
3042 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3044 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3045 (w32_delayed_load): Move from image.c. When loading a library, record
3046 its filename in the :loaded-from property of the library id.
3047 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3048 Initialize and staticpro them.
3049 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3051 * process.c: Include lisp.h before w32.h, not after.
3052 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3053 instead of gnutls_record_check_pending.
3055 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3057 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3059 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3060 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3063 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3065 * xterm.c (x_set_frame_alpha): Do not set property on anything
3066 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3068 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3070 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3072 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3074 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3075 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3076 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3077 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3078 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3079 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3080 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3081 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3082 (Qgnutls_bootprop_callbacks_verify): Make static.
3084 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3086 * callproc.c: Indentation fixup.
3088 * sysdep.c (wait_for_termination_1): Make static.
3089 (wait_for_termination, interruptible_wait_for_termination):
3090 Move after wait_for_termination_1.
3092 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3094 * sysdep.c (interruptible_wait_for_termination): New function
3095 which is like wait_for_termination, but allows keyboard
3098 * callproc.c (Fcall_process): Add (:file "file") as an option for
3100 (Fcall_process_region): Ditto.
3102 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3104 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3105 rather than `XVECTOR (FOO)->size'.
3107 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3108 inttypes.h, as a gnulib replacement is used if it not available in
3111 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3113 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3114 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3115 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3117 * coding.c (coding_alloc_by_realloc): Error out if destination
3118 will grow beyond MOST_POSITIVE_FIXNUM.
3119 (decode_coding_emacs_mule): Abort if there isn't enough place in
3120 charbuf for the composition carryover bytes. Reserve an extra
3121 space for up to 2 characters produced in a loop.
3122 (decode_coding_iso_2022): Abort if there isn't enough place in
3123 charbuf for the composition carryover bytes.
3125 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3127 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3128 aborting when %lld or %lll format is passed.
3129 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3130 %llo or %llx format is passed. (Bug#8545)
3132 * window.c (window_scroll_line_based): Use a marker instead of
3133 simple variables to record original value of point. (Bug#7952)
3135 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3136 produced by %s or %c overflows available buffer space. (Bug#8545)
3138 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3140 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3141 (SIZE_MAX): Move defn after all includes, as they might #define it.
3143 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3145 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3147 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3149 * keyboard.c (Qdelayed_warnings_hook): Define.
3150 (command_loop_1): Run `delayed-warnings-hook'
3151 if Vdelayed_warnings_list is non-nil.
3152 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3153 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3155 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3157 * doprnt.c (doprnt): Don't return value smaller than the buffer
3158 size if the message was truncated. (Bug#8545).
3160 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3162 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3163 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3165 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3167 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3169 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3171 * makefile.w32-in: Update dependencies.
3173 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3175 Improve `doprnt' and its usage. (Bug#8545)
3176 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3177 `format_end'. Remove support for %l as a conversion specifier.
3178 Don't use xrealloc. Improve diagnostics when the %l size modifier
3179 is used. Update the commentary.
3181 * eval.c (verror): Simplify calculation of size_t.
3183 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3186 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3188 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3191 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3193 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3194 This makes this file independent of the recent pseudovector change.
3196 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3198 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3200 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3201 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3202 Remove unused local.
3203 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3205 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3206 GCC 4.6.0 optimizes based on type-based alias analysis.
3207 For example, if b is of type struct buffer * and v of type struct
3208 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3209 != &v->size, and therefore "v->size = 1; b->size = 2; return
3210 v->size;" must therefore return 1. This assumption is incorrect
3211 for Emacs, since it type-puns struct Lisp_Vector * with many other
3212 types. To fix this problem, this patch adds a new type struct
3213 vectorlike_header that documents the constraints on layout of vectors
3214 and pseudovectors, and helps optimizing compilers not get fooled
3215 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3216 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3217 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3219 (XSETPVECTYPE): Rewrite in terms of new macro.
3220 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3221 This is a bit clearer, and further avoids the possibility of
3222 undesirable aliasing.
3223 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3224 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3225 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3226 since Lisp_Subr is a special case (no "next" field).
3227 (ASIZE): Now uses header.size rather than size.
3228 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3229 to avoid the hassle of writing XVECTOR (foo)->header.size.
3230 (struct vectorlike_header): New type.
3231 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3232 object, to help avoid aliasing.
3233 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3234 (SUBRP): Likewise, since Lisp_Subr is a special case.
3235 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3236 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3237 (struct Lisp_Hash_Table): Combine first two members into a single
3238 struct vectorlike_header member. All uses of "size" and "next" members
3239 changed to be "header.size" and "header.next".
3240 * buffer.h (struct buffer): Likewise.
3241 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3242 * frame.h (struct frame): Likewise.
3243 * process.h (struct Lisp_Process): Likewise.
3244 * termhooks.h (struct terminal): Likewise.
3245 * window.c (struct save_window_data, struct saved_window): Likewise.
3246 * window.h (struct window): Likewise.
3247 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3248 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3249 * buffer.c (init_buffer_once): Likewise.
3250 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3252 * process.c (Fformat_network_address): Use local var for size,
3255 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3257 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3258 * data.c (atof): Remove decl; no longer used or needed.
3259 (digit_to_number): Move to lread.c.
3260 (Fstring_to_number): Use new string_to_number function, to be
3261 consistent with how the Lisp reader treats infinities and NaNs.
3262 Do not assume that floating-point numbers represent EMACS_INT
3263 without losing information; this is not true on most 64-bit hosts.
3264 Avoid double-rounding errors, by insisting on integers when
3265 parsing non-base-10 numbers, as the documentation specifies.
3266 * lisp.h (string_to_number): New decl, replacing ...
3267 (isfloat_string): Remove.
3268 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3269 (read1): Do not accept +. and -. as integers; this
3270 appears to have been a coding error. Similarly, do not accept
3271 strings like +-1e0 as floating point numbers. Do not report
3272 overflow for integer overflows unless the base is not 10 which
3273 means we have no simple and reliable way to continue.
3274 Break out the floating-point parsing into a new
3275 function string_to_number, so that Fstring_to_number parses
3276 floating point numbers consistently with the Lisp reader.
3277 (digit_to_number): Move here from data.c. Make it static inline.
3278 (E_CHAR, EXP_INT): Remove, replacing with ...
3279 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3280 (string_to_number): New function, replacing isfloat_string.
3281 This function checks for valid syntax and produces the resulting
3282 Lisp float number too. Rework it so that string-to-number
3283 no longer mishandles examples like "1.0e+". Use strtoumax,
3284 so that overflow for non-base-10 numbers is reported only when
3285 there's no portable and simple way to convert to floating point.
3287 * textprop.c (set_text_properties_1): Rewrite for clarity,
3288 and to avoid GCC warning about integer overflow.
3290 * intervals.h (struct interval): Use EMACS_INT for members
3291 where EMACS_UINT might cause problems. See
3292 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3293 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3294 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3296 (offset_intervals): Tell GCC not to worry about length overflow
3297 when negating a negative length.
3299 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3300 (overrun_check_free): Likewise.
3302 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3303 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3306 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3307 (gnutls_make_error): Rename local to avoid shadowing.
3308 (gnutls_emacs_global_deinit): ifdef out; not used.
3309 (Fgnutls_boot): Use const for pointer to readonly storage.
3310 Comment out unused local. Fix pointer signedness problems.
3312 * lread.c (openp): Don't stuff size_t into an 'int'.
3313 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3314 about possible signed overflow.
3316 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3317 (GDK_KEY_g): Don't define if already defined.
3318 (xg_prepare_tooltip): Avoid pointer signedness problem.
3319 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3321 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3322 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3324 * xfns.c (Fx_window_property): Simplify a bit,
3325 to make a bit faster and to avoid GCC 4.6.0 warning.
3326 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3328 * fns.c (internal_equal): Don't assume size_t fits in int.
3330 * alloc.c (compact_small_strings): Tighten assertion a little.
3332 Replace pEd with more-general pI, and fix some printf arg casts.
3333 * lisp.h (pI): New macro, generalizing old pEd macro to other
3334 conversion specifiers. For example, use "...%"pI"d..." rather
3335 than "...%"pEd"...".
3336 (pEd): Remove. All uses replaced with similar uses of pI.
3337 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3338 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3339 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3340 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3341 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3342 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3343 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3345 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3346 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3347 * print.c (safe_debug_print, print_object): Likewise.
3348 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3350 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3351 avoiding the 0 flag, which is not portable.
3352 * process.c (Fmake_network_process): Use pI to avoid cast.
3353 * region-cache.c (pp_cache): Likewise.
3354 * xdisp.c (decode_mode_spec): Likewise.
3355 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3356 behavior on 64-bit hosts with printf arg.
3357 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3358 (x_stop_queuing_selection_requests): Likewise.
3359 (x_get_window_property): Don't truncate byte count to an 'int'
3362 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3363 here, since it parses constructs like leading '-' and spaces,
3364 which are not wanted; and it overflows with large numbers.
3365 Instead, simply match F[0-9]+, which is what is wanted anyway.
3367 * alloc.c: Remove unportable assumptions about struct layout.
3368 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3369 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3370 (allocate_vectorlike, make_pure_vector): Use the new macros,
3371 plus offsetof, to remove unportable assumptions about struct layout.
3372 These assumptions hold on all porting targets that I know of, but
3373 they are not guaranteed, they're easy to remove, and removing them
3374 makes further changes easier.
3376 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3377 This doesn't fix a bug but makes the code clearer.
3378 (string_overrun_cookie): Now const. Use initializers that
3379 don't formally overflow signed char, to avoid warnings.
3380 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3381 can cause Emacs to crash when string overrun checking is enabled.
3382 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3383 multiple of sizeof (EMACS_INT); it need not be, if
3384 alignof(EMACS_INT) < sizeof (EMACS_INT).
3385 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3387 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3389 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3391 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3393 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3394 supposed to be handshaking. (Bug#8556)
3395 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3397 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3399 * lisp.h (Qdebug): List symbol.
3400 * eval.c (Qdebug): Restore global linkage.
3401 * keyboard.c (debug-on-event): New variable.
3402 (handle_user_signal): Break into debugger when debug-on-event
3403 matches the current signal symbol.
3405 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3407 * alloc.c (check_sblock, check_string_bytes)
3408 (check_string_free_list): Convert to standard C.
3410 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3412 * w32.c (emacs_gnutls_push): Fix typo.
3414 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3416 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3417 "cast to pointer from integer of different size".
3419 Improve doprnt and its use in verror. (Bug#8545)
3420 * doprnt.c (doprnt): Document the set of format control sequences
3421 supported by the function. Use SAFE_ALLOCA instead of always
3424 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3425 is one byte too soon. Don't use xrealloc; instead xfree and
3428 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3430 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3433 * gnutls.c: Renamed global_initialized to
3434 gnutls_global_initialized. Added internals for the
3435 :verify-hostname-error, :verify-error, and :verify-flags
3436 parameters of `gnutls-boot' and documented those parameters in the
3437 docstring. Start callback support.
3438 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3439 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3440 on error. Return error code.
3441 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3442 (emacs_gnutls_read): Likewise.
3443 (Fgnutls_boot): Return handshake error code.
3444 (emacs_gnutls_handle_error): New function.
3445 (wsaerror_to_errno): Likewise.
3447 * w32.h (emacs_gnutls_pull): Add prototype.
3448 (emacs_gnutls_push): Likewise.
3450 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3451 (emacs_gnutls_push): Likewise.
3453 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3455 * process.c (wait_reading_process_output): Check if GnuTLS
3456 buffered some data internally if no FDs are set for TLS
3459 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3460 (LIBS): Link to USER_LIBS.
3461 ($(BLD)/gnutls.$(0)): New target.
3463 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3465 * xdisp.c (handle_single_display_spec): Rename the
3466 display_replaced_before_p argument into display_replaced_p, to
3467 make it consistent with the commentary. Fix typos in the
3470 * textprop.c (syms_of_textprop): Remove dead code.
3471 (copy_text_properties): Delete obsolete commentary about an
3472 interface that was deleted long ago. Fix typos in the description
3475 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3476 to changes in oldXMenu/XMenu.h from 2011-04-16.
3477 <menu_help_message, prev_menu_help_message>: Constify.
3478 (IT_menu_make_room): menu->help_text is now `const char **';
3481 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3482 to changes in oldXMenu/XMenu.h from 2011-04-16.
3483 (struct XMenu): Declare `help_text' `const char **'.
3485 * xfaces.c <Qunspecified>: Make extern again.
3487 * syntax.c: Include sys/types.h before including regex.h, as
3490 * doc.c (get_doc_string): Improve the format passed to `error'.
3492 * doprnt.c (doprnt): Improve commentary.
3494 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3496 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3499 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3500 changes in globals.h immediately force recompilation.
3501 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3502 $(CURDIR)/s/ms-w32.h.
3503 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3505 * character.c (Fchar_direction): Function deleted.
3506 (syms_of_character): Don't defsubr it.
3507 <char-direction-table>: Deleted.
3509 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3511 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3512 * doprnt.c: Include limits.h.
3513 (SIZE_MAX): New macro.
3514 (doprnt): Return a size_t value. 2nd arg is now size_t.
3515 Many local variables are now size_t instead of int or unsigned.
3516 Improve overflow protection. Support `l' modifier for integer
3517 conversions. Support %l conversion. Don't assume an EMACS_INT
3518 argument for integer conversions and for %c.
3520 * lisp.h (doprnt): Restore prototype.
3522 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3525 * Makefile.in (base_obj): Add back doprnt.o.
3527 * deps.mk (doprnt.o): Add back prerequisites.
3528 (callint.o): Depend on character.h.
3530 * eval.c (internal_lisp_condition_case): Include the handler
3531 representation in the error message.
3532 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3533 when breaking from the loop.
3535 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3537 * callint.c (Fcall_interactively): When displaying error message
3538 about invalid control letter, pass the character's codepoint, not
3539 a pointer to its multibyte form. Improve display of the character
3540 in octal and display also its hex code.
3542 * character.c (char_string): Use %x to display the (unsigned)
3543 codepoint of an invalid character, to avoid displaying a bogus
3546 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3547 `error', not SYMBOL_NAME itself.
3549 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3550 character arguments to `error'.
3552 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3553 to `error' in error message about FINAL_CHAR argument. Make sure
3554 FINAL_CHAR is a character, and use %c when it is passed as
3555 argument to `error'.
3557 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3559 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3561 * w32.c: Include <time.h>.
3562 (sys_localtime): New function.
3564 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3566 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3568 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3570 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3572 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3575 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3577 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3578 gl_state.e_property when gl_state.object is Qt.
3580 * insdel.c (make_gap_larger): Remove limitation of buffer size
3583 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3585 * xdisp.c (lookup_glyphless_char_display)
3586 (produce_glyphless_glyph): Handle cons cell entry in
3587 glyphless-char-display.
3588 (Vglyphless_char_display): Document it.
3590 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3591 glyphless-char-display.
3593 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3595 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3597 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3599 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3600 definition for no-X builds.
3602 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3604 Static checks with GCC 4.6.0 and non-default toolkits.
3606 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3608 * process.c (keyboard_bit_set): Define only if SIGIO.
3609 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3610 (send_process): Repair possible setjmp clobbering.
3612 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3614 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3616 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3618 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3619 Define only if needed.
3621 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3622 by pacifying GCC about it. Maybe it's time to retire it?
3623 * xfaces.c (USG, __TIMEVAL__): Likewise.
3625 * dispextern.h (struct redisplay_interface): Rename param
3627 * termhooks.h (struct terminal): Likewise.
3628 * xterm.c (xembed_send_message): Likewise.
3630 * insdel.c (make_gap_smaller): Define only if
3631 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3633 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3636 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3637 so that we aren't warned about unused symbols.
3639 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3641 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3643 * xfns.c (x_real_positions): Mark locals as initialized.
3645 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3647 * xterm.c: Fix problems found by static analysis with other toolkits.
3648 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3649 (x_dispatch_event): Declare static if USE_GTK, and
3650 define if USE_GTK || USE_X_TOOLKIT.
3651 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3652 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3653 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3654 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3656 * xmenu.c (menu_help_callback): Pointer type fixes.
3657 Use const pointers when pointing at readonly data. Avoid pointer
3659 (FALSE): Remove unused macro.
3660 (update_frame_menubar): Remove unused decl.
3662 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3664 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3665 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3666 (single_menu_item): Rename local to avoid shadowing.
3668 * keyboard.c (make_lispy_event): Remove unused local var.
3670 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3671 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3673 * bitmaps: Change bitmaps from unsigned char back to the X11
3674 compatible char. Avoid the old compiler warnings about
3675 out-of-range initializers by using, for example, '\xab' rather
3678 * xgselect.c (xgselect_initialize): Check vs interface
3679 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3681 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3683 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3684 to read-only memory.
3686 * fns.c (vector): Remove; this old hack is no longer needed.
3688 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3690 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3692 * xrdb.c (x_load_resources): Omit unused local.
3694 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3695 (x_window): Rename locals to avoid shadowing.
3696 (USG): Use the kludged USG macro, to pacify gcc.
3698 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3699 (x_term_init): Remove local to avoid shadowing.
3701 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3703 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3704 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3706 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3708 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3710 Fix regex.c, syntax.c and friends for buffers > 2GB.
3711 * syntax.h (struct gl_state_s): Declare character position members
3714 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3716 * textprop.c (verify_interval_modification, interval_of):
3717 Declare arguments EMACS_INT.
3719 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3722 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3724 * indent.c (Fvertical_motion): Local variable it_start is now
3727 * regex.c (re_match, re_match_2, re_match_2_internal)
3728 (bcmp_translate, regcomp, regexec, print_double_string)
3729 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3730 (re_compile_pattern, re_exec): Declare arguments and local
3731 variables `size_t' and `ssize_t' and return values `regoff_t', as
3733 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3734 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3735 <compile_stack_type>: `size' and `avail' are now `size_t'.
3737 * regex.h <regoff_t>: Use ssize_t, not int.
3738 (re_search, re_search_2, re_match, re_match_2): Arguments that
3739 specify buffer/string position and length are now ssize_t and
3740 size_t. Return type is regoff_t.
3742 2011-04-16 Ben Key <bkey76@gmail.com>
3744 * nsfont.m: Fixed bugs in ns_get_family and
3745 ns_descriptor_to_entity that were caused by using free to
3746 deallocate memory blocks that were allocated by xmalloc (via
3747 xstrdup). This caused Emacs to crash when compiled with
3748 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3749 --enable-checking=xmallocoverrun). xfree is now used to
3750 deallocate these memory blocks.
3752 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3754 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3756 emacs_write: Accept and return EMACS_INT for sizes.
3757 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3759 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3760 Accept and return EMACS_INT.
3761 (emacs_gnutls_write): Return the number of bytes written on
3763 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3764 (emacs_read, emacs_write): Remove check for negative size, as the
3765 Emacs source code has been audited now.
3766 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3767 (emacs_read, emacs_write): Use it.
3768 * process.c (send_process): Adjust to the new signatures of
3769 emacs_write and emacs_gnutls_write. Do not attempt to store
3770 a byte offset into an 'int'; it might overflow.
3771 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3773 * sound.c: Don't assume sizes fit in 'int'.
3774 (struct sound_device.period_size, alsa_period_size):
3775 Return EMACS_INT, not int.
3776 (struct sound_device.write, vox_write, alsa_write):
3777 Accept EMACS_INT, not int.
3778 (wav_play, au_play): Use EMACS_INT to store sizes and to
3779 record read return values.
3781 2011-04-15 Ben Key <bkey76@gmail.com>
3783 * keyboard.c (Qundefined): Don't declare static since it is used
3785 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3786 static since they are used in nsfont.m.
3788 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3790 * process.c (Qprocessp): Don't declare static.
3791 * lisp.h (Qprocessp): Declare again.
3793 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3795 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3797 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3799 Improve C-level modularity by making more things 'static'.
3801 Don't publish debugger-only interfaces to other modules.
3802 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3803 (verify_bytepos, count_markers): Move decls to the only modules
3805 * region-cache.h (pp_cache): Likewise.
3806 * window.h (check_all_windows): Likewise.
3807 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3809 * sysdep.c (croak): Now static, if
3810 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3811 * syssignal.h (croak): Declare only if not static.
3813 * alloc.c (refill_memory_reserve): Now static if
3814 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3815 * lisp.h (refill_memory_reserve): Declare only if not static.
3817 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3818 Define only if USE_LUCID.
3820 * xrdb.c (x_customization_string, x_rm_string): Now static.
3822 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3823 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3825 * xdisp.c (draw_row_with_mouse_face): Now static.
3826 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3828 * window.h (check_all_windows): Mark externally visible.
3830 * window.c (window_deletion_count): Now static.
3832 * undo.c: Make symbols static if they're not exported.
3833 (last_undo_buffer, last_boundary_position, pending_boundary):
3836 * textprop.c (interval_insert_behind_hooks): Now static.
3837 (interval_insert_in_front_hooks): Likewise.
3839 * term.c: Make symbols static if they're not exported.
3840 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3841 (max_frame_lines, tty_set_terminal_modes):
3842 (tty_reset_terminal_modes, tty_turn_off_highlight):
3843 (get_tty_terminal): Now static.
3844 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3845 * termhooks.h (term_mouse_moveto): Do not declare if
3847 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3848 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3850 * sysdep.c: Make symbols static if they're not exported.
3851 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3853 (sigprocmask_set, full_mask): Remove; unused.
3854 (wait_debugging): Mark as visible.
3855 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3856 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3858 * syntax.c (syntax_temp): Define only if !__GNUC__.
3860 * sound.c (current_sound_device, current_sound): Now static.
3862 * search.c (searchbufs, searchbuf_head): Now static.
3864 * scroll.c (scroll_cost): Remove; unused.
3865 * dispextern.h (scroll_cost): Remove decl.
3867 * region-cache.h (pp_cache): Mark as externally visible.
3869 * process.c: Make symbols static if they're not exported.
3870 (process_tick, update_tick, create_process, chan_process):
3871 (Vprocess_alist, proc_buffered_char, datagram_access):
3872 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3873 (deactivate_process): Mark defn as static, as well as decl.
3874 * lisp.h (create_process): Remove decl.
3875 * process.h (chan_process, Vprocess_alist): Remove decls.
3877 * print.c: Make symbols static if they're not exported.
3878 (print_depth, new_backquote_output, being_printed, print_buffer):
3879 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3880 (print_interval, print_number_index, initial_stderr_stream):
3882 * lisp.h (Fprinc): Remove decl.
3883 (debug_output_compilation_hack): Mark as externally visible.
3885 * sysdep.c (croak): Move decl from here to syssignal.h.
3886 * syssignal.h (croak): Put it here, so the API can be checked when
3887 'croak' is called from dissociate_if_controlling_tty.
3889 * minibuf.c: Make symbols static if they're not exported.
3890 (minibuf_save_list, choose_minibuf_frame): Now static.
3891 * lisp.h (choose_minibuf_frame): Remove decl.
3893 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3895 * lread.c: Make symbols static if they're not exported.
3896 (read_objects, initial_obarray, oblookup_last_bucket_number):
3898 (make_symbol): Remove; unused.
3899 * lisp.h (initial_obarray, make_symbol): Remove decls.
3901 * keyboard.c: Make symbols static if they're not exported.
3902 (single_kboard, recent_keys_index, total_keys, recent_keys):
3903 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3904 (this_single_command_key_start, echoing, last_auto_save):
3905 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3906 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3907 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3908 (Vlispy_mouse_stem, double_click_count):
3910 (force_auto_save_soon): Define only if SIGDANGER.
3911 (ignore_mouse_drag_p): Now static if
3912 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3913 (print_help): Remove; unused.
3914 (stop_character, last_timer_event): Mark as externally visible.
3915 * keyboard.h (ignore_mouse_drag_p): Declare only if
3916 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3917 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3918 * lisp.h (echoing): Remove decl.
3919 (force_auto_save_soon): Declare only if SIGDANGER.
3920 * xdisp.c (redisplay_window): Simplify code, to make it more
3921 obvious that ignore_mouse_drag_p is not accessed if !defined
3922 USE_GTK && !defined HAVE_NS.
3924 * intervals.c: Make symbols static if they're not exported.
3925 (merge_properties_sticky, merge_interval_right, delete_interval):
3927 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3929 * insdel.c: Make symbols static if they're not exported.
3930 However, leave prepare_to_modify_buffer alone. It's never
3931 called from outside this function, but that appears to be a bug.
3932 (combine_after_change_list, combine_after_change_buffer):
3933 (adjust_after_replace, signal_before_change): Now static.
3934 (adjust_after_replace_noundo): Remove; unused.
3935 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3936 (signal_before_change): Remove decls.
3938 * indent.c (val_compute_motion, val_vmotion): Now static.
3940 * image.c: Make symbols static if they're not exported.
3941 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3943 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3944 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3946 * fringe.c (standard_bitmaps): Now static.
3947 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3949 * frame.c: Make symbols static if they're not exported.
3950 (x_report_frame_params, make_terminal_frame): Now static.
3951 (get_frame_param): Now static, unless HAVE_NS.
3952 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3953 (x_get_resource_string): Remove; not used.
3954 * frame.h (make_terminal_frame, x_report_frame_params):
3955 (x_get_resource_string); Remove decls.
3956 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3957 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3959 * font.c, fontset.c: Make symbols static if they're not exported.
3960 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3961 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3962 * font.c (font_close_object): Now static.
3963 * font.h (font_close_object): Remove.
3964 * fontset.c (FONTSET_OBJLIST): Remove.
3965 (free_realized_fontset) #if-0 the body, which does nothing.
3966 (face_suitable_for_char_p): #if-0, as it's never called.
3967 * fontset.h (face_suitable_for_char_p): Remove decl.
3968 * xfaces.c (face_at_string_position):
3969 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3970 since 0 is always ASCII.
3972 * fns.c (weak_hash_tables): Now static.
3974 * fileio.c: Make symbols static if they're not exported.
3975 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3976 (Vwrite_region_annotation_buffers): Now static.
3978 * eval.c: Make symbols static if they're not exported.
3979 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3980 * lisp.h (backtrace_list): Remove decl.
3982 * emacs.c: Make symbols static if they're not exported.
3983 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3984 (fatal_error_code, fatal_error_signal_hook, standard_args):
3986 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3987 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3988 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3989 * lisp.h (fatal_error_signal_hook): Remove decl.
3990 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3992 * editfns.c: Move a (normally-unused) function to its only use.
3993 * editfns.c, lisp.h (get_operating_system_release): Remove.
3994 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3995 worth the hassle of breaking this out.
3997 * xterm.c: Make symbols static if they're not exported.
3998 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3999 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4000 (x_destroy_window, x_delete_display):
4002 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4003 (x_mouse_leave): Remove; unused.
4004 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4005 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4006 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4008 (x_mouse_leave): Declare only if WINDOWSNT.
4009 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4010 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4013 * ftxfont.c: Make symbols static if they're not exported.
4014 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4016 * font.h (ftxfont_driver): Likewise.
4018 * xfns.c: Make symbols static if they're not exported.
4019 (x_last_font_name, x_display_info_for_name):
4020 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4021 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4022 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4023 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4024 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4025 (last_show_tip_args): Now static.
4026 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4027 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4028 (x_screen_planes): Remove; unused.
4029 * dispextern.h (x_screen_planes): Remove decl.
4031 * dispnew.c: Make symbols static if they're not exported.
4032 * dispextern.h (redraw_garbaged_frames, scrolling):
4033 (increment_row_positions): Remove.
4034 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4035 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4037 (redraw_garbaged_frames): Remove; unused.
4039 * xfaces.c: Make symbols static if they're not exported.
4040 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4042 * xterm.h (defined_color): Remove decls.
4043 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4044 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4045 (menu_face_changed_default, defined_color, free_realized_face):
4046 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4047 (ascii_face_of_lisp_face): Remove; unused.
4049 * xdisp.c: Make symbols static if they're not exported.
4050 * dispextern.h (scratch_glyph_row, window_box_edges):
4051 (glyph_to_pixel_coords, set_cursor_from_row):
4052 (get_next_display_element, set_iterator_to_next):
4053 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4054 (show_mouse_face): Remove decls
4055 * frame.h (message_buf_print): Likewise.
4056 * lisp.h (pop_message, set_message, check_point_in_composition):
4058 * xterm.h (set_vertical_scroll_bar): Likewise.
4059 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4060 (message_buf_print, scratch_glyph_row, displayed_buffer):
4061 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4062 (get_next_display_element, show_mouse_face, window_box_edges):
4063 (frame_to_window_pixel_xy, check_point_in_composition):
4064 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4065 (glyph_to_pixel_coords): Remove; unused.
4067 * dired.c (file_name_completion): Now static.
4069 * dbusbind.c (xd_in_read_queued_messages): Now static.
4071 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4072 * data.c (circular_list_error): Remove.
4074 * commands.h (last_point_position, last_point_position_buffer):
4075 (last_point_position_window): Remove decls.
4076 * keyboard.c: Make these variables static.
4078 * coding.h (coding, code_convert_region, encode_coding_gap):
4080 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4081 (iso_code_class, detect_coding, code_convert_region): Now static.
4082 (encode_coding_gap): Remove; unused.
4084 * chartab.c (chartab_chars, chartab_bits): Now static.
4086 * charset.h (charset_iso_8859_1): Remove decl.
4087 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4090 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4091 * ccl.c (Vccl_program_table): Now static.
4092 (check_ccl_update): Remove; unused.
4094 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4095 * category.h: ... from here.
4096 * category.c (check_category_table, set_category_set): Now static.
4098 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4099 * lisp.h: Remove these decls.
4101 * buffer.c (buffer_count): Remove unused var.
4103 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4104 so that it's not optimized away.
4105 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4106 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4107 exported only to the debugger.
4109 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4110 * atimer.h (run_all_atimers): Remove; not exported.
4112 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4113 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4114 was inaccessible from Lisp.
4115 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4116 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4118 alloc.c: Import and export fewer symbols, and remove unused items.
4119 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4121 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4122 it's not optimized away by whole-program optimization.
4123 (message_enable_multibyte, free_misc): Remove.
4124 (catchlist, handlerlist, mark_backtrace):
4125 Declare only if BYTE_MARK_STACK.
4126 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4127 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4128 (message_enable_multibyte): Remove decl.
4129 (free_misc, interval_free_list, float_block, float_block_index):
4130 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4131 (cons_free_list, last_marked_index):
4133 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4134 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4135 (mark_backtrace): Define only if BYTE_MARK_STACK.
4136 * xdisp.c (message_enable_multibyte): Now static.
4138 Declare Lisp_Object Q* variables to be 'static' if not exported.
4139 This makes it easier for human readers (and static analyzers)
4140 to see whether these variables are used from other modules.
4141 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4142 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4143 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4144 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4145 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4146 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4147 * xmenu.c, xselect.c:
4148 Declare Q* vars static if they are not used in other modules.
4149 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4150 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4151 Remove decls of unexported vars.
4152 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4154 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4156 Make Emacs functions such as Fatom 'static' by default.
4157 This makes it easier for human readers (and static analyzers)
4158 to see whether these functions can be called from other modules.
4159 DEFUN now defines a static function. To make the function external
4160 so that it can be used in other C modules, use the new macro DEFUE.
4161 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4162 (Finit_image_library):
4163 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4164 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4165 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4166 Remove decls, since these functions are now static.
4167 (Funintern, Fget_internal_run_time): New decls, since these functions
4168 were already external.
4170 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4171 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4172 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4173 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4174 * keyboard.c, keymap.c, lread.c:
4175 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4176 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4177 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4178 Mark functions with DEFUE instead of DEFUN,
4179 if they are used in other modules.
4180 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4181 decls for now-static functions.
4182 * buffer.h (Fdelete_overlay): Remove decl.
4183 * callproc.c (Fgetenv_internal): Mark as internal.
4184 * composite.c (Fremove_list_of_text_properties): Remove decl.
4185 (Fcomposition_get_gstring): New forward static decl.
4186 * composite.h (Fcomposite_get_gstring): Remove decl.
4187 * dired.c (Ffile_attributes): New forward static decl.
4188 * doc.c (Fdocumntation_property): New forward static decl.
4189 * eval.c (Ffetch_bytecode): New forward static decl.
4190 (Funintern): Remove extern decl; now in .h file where it belongs.
4191 * fileio.c (Fmake_symbolic_link): New forward static decl.
4192 * image.c (Finit_image_library): New forward static decl.
4193 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4194 * intervals.h (Fprevious_property_change):
4195 (Fremove_list_of_text_properties): Remove decls.
4196 * keyboard.c (Fthis_command_keys): Remove decl.
4197 (Fcommand_execute): New forward static decl.
4198 * keymap.c (Flookup_key): New forward static decl.
4199 (Fcopy_keymap): Now static.
4200 * keymap.h (Flookup_key): Remove decl.
4201 * process.c (Fget_process): New forward static decl.
4202 (Fprocess_datagram_address): Mark as internal.
4203 * syntax.c (Fsyntax_table_p): New forward static decl.
4204 (skip_chars): Remove duplicate decl.
4205 * textprop.c (Fprevious_property_change): New forward static decl.
4206 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4208 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4209 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4211 * editfns.c (Fformat): Remove unreachable code.
4213 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4215 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4218 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4220 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4221 when at ZV. (Bug#8487)
4223 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4225 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4227 * keyboard.c (parse_tool_bar_item): Likewise.
4228 * sound.c (sound_cleanup, alsa_close): Likewise.
4229 * termcap.c (tgetent): Likewise.
4230 * xfns.c (x_default_font_parameter): Likewise.
4231 * xsettings.c (read_and_apply_settings): Likewise.
4233 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4234 (overrun_check_free): Protoize.
4236 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4238 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4239 since callers should never pass a negative size.
4240 Change the signature to match that of plain 'read' and 'write'; see
4241 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4242 * lisp.h: Update prototypes of emacs_write and emacs_read.
4244 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4246 * xdisp.c (redisplay_window): Don't try to determine the character
4247 position of the scroll margin if the window start point w->startp
4248 is outside the buffer's accessible region. (Bug#8468)
4250 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4252 Fix write-region and its subroutines for buffers > 2GB.
4253 * fileio.c (a_write, e_write): Modify declaration of arguments and
4254 local variables to support buffers larger than 2GB.
4255 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4257 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4258 argument, local variables, and return value.
4260 * lisp.h: Update prototypes of emacs_write and emacs_read.
4262 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4264 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4266 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4268 Fix more problems found by GCC 4.6.0's static checks.
4270 * xdisp.c (vmessage): Use a better test for character truncation.
4272 * charset.c (load_charset_map): <, not <=, for optimization,
4273 and to avoid potential problems with integer overflow.
4274 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4275 * casetab.c (set_identity, shuffle): Likewise.
4276 * editfns.c (Fformat): Likewise.
4277 * syntax.c (skip_chars): Likewise.
4279 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4280 This also lets GCC 4.6.0 generate slightly better loop code.
4282 * callint.c (Fcall_interactively): <, not <=, for optimization.
4283 (Fcall_interactively): Count the number of arguments produced,
4284 not the number of arguments given. This is simpler and lets GCC
4285 4.6.0 generate slightly better code.
4287 * ftfont.c: Distingish more carefully between FcChar8 and char.
4288 The previous code passed unsigned char * to a functions like
4289 strlen and xstrcasecmp that expect char *, which does not
4290 conform to the C standard.
4291 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4292 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4293 char * when the C standard requires it.
4295 * keyboard.c (read_char): Remove unused var.
4297 * eval.c: Port to Windows vsnprintf (Bug#8435).
4299 (SIZE_MAX): Define if the headers do not.
4300 (verror): Do not give up if vsnprintf returns a negative count.
4301 Instead, grow the buffer. This ports to Windows vsnprintf, which
4302 does not conform to C99. Problem reported by Eli Zaretskii.
4303 Also, simplify the allocation scheme, by avoiding the need for
4304 calling realloc, and removing the ALLOCATED variable.
4306 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4308 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4309 But keep the doprint source code for now, as we might revamp it
4310 and use it again (Bug#8435).
4311 * lisp.h (doprnt): Remove.
4312 * Makefile.in (base_obj): Remove doprnt.o.
4313 * deps.mk (doprnt.o): Remove.
4315 error: Print 32- and 64-bit integers portably (Bug#8435).
4316 Without this change, on typical 64-bit hosts error ("...%d...", N)
4317 was used to print both 32- and 64-bit integers N, which relied on
4319 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4321 * lisp.h (error, verror): Mark as printf-like functions.
4322 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4323 Report overflow in size calculations when allocating printf buffer.
4324 Do not truncate output string at its first null byte.
4325 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4326 Truncate the output at a character boundary, since vsnprintf does not
4328 * charset.c (check_iso_charset_parameter): Convert internal
4329 character to string before calling 'error', since %c now has the
4331 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4332 overflow when computing char to be passed to 'error'. Do not
4333 pass Lisp_Object to 'error'; pass the integer instead.
4334 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4335 formatted with plain %d.
4337 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4339 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4341 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4343 * xterm.c (x_catch_errors): Remove duplicate declaration.
4345 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4347 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4349 2011-04-10 Jim Meyering <meyering@redhat.com>
4351 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4352 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4353 return ssize_t not "int", and use size_t as the buffer length.
4354 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4355 * gnutls.h: Update declarations.
4356 * process.c (read_process_output): Use ssize_t, to match.
4357 (send_process): Likewise.
4359 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4361 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4363 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4365 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4366 Use unsigned char, to match FcChar8 type definition.
4368 * xterm.c (handle_one_xevent):
4369 * xmenu.c (create_and_show_popup_menu):
4370 * xselect.c (x_decline_selection_request)
4371 (x_reply_selection_request): Avoid type-punned deref of X events.
4373 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4375 Fix some uses of `int' instead of EMACS_INT.
4376 * search.c (string_match_1, fast_string_match)
4377 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4378 (scan_buffer, find_next_newline_no_quit)
4379 (find_before_next_newline, search_command, Freplace_match)
4380 (Fmatch_data): Make some `int' variables be EMACS_INT.
4382 * xdisp.c (display_count_lines): 3rd argument and return value now
4383 EMACS_INT. All callers changed.
4384 (pint2hrstr): Last argument is now EMACS_INT.
4386 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4387 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4388 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4389 (decode_coding_utf_16, decode_coding_emacs_mule)
4390 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4391 (decode_coding_ccl, decode_coding_charset)
4392 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4393 (decode_coding_iso_2022, decode_coding_emacs_mule)
4394 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4395 <char_offset, last_offset>: Declare EMACS_INT.
4396 (encode_coding_utf_8, encode_coding_utf_16)
4397 (encode_coding_emacs_mule, encode_invocation_designation)
4398 (encode_designation_at_bol, encode_coding_iso_2022)
4399 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4400 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4402 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4403 (encode_invocation_designation): Last argument P_NCHARS is now
4405 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4406 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4408 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4411 * ccl.c (Fccl_execute_on_string): Declare some variables
4414 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4416 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4418 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4420 * process.c (Fformat_network_address): Doc fix.
4422 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4424 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4426 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4428 * keyboard.c (read_char): Call Lisp function help-form-show,
4429 instead of using internal_with_output_to_temp_buffer.
4430 (Qhelp_form_show): New var.
4431 (syms_of_keyboard): Use DEFSYM macro.
4433 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4435 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4437 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4439 * process.c (Flist_processes): Remove to Lisp.
4440 (list_processes_1): Delete.
4442 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4444 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4446 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4448 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4450 Fix more problems found by GCC 4.6.0's static checks.
4452 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4454 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4456 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4458 * xdisp.c (vmessage): Mark as a printf-like function.
4460 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4462 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4464 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4465 printf-like functions.
4466 (tiff_load): Add casts to remove these marks before passing them
4467 to system-supplied API.
4469 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4471 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4472 This avoids several warnings with gcc -Wstrict-overflow.
4473 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4474 directly, rather than having caller test rule sign. This avoids
4475 some unnecessary tests.
4476 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4477 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4478 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4480 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4481 (xfont_open): Avoid unnecessary tests.
4483 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4485 * composite.h, composite.c (composition_gstring_put_cache):
4486 Use EMACS_INT, not int, for length.
4488 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4489 breaking out part of COMPOSITION_DECODE_RULE.
4490 (COMPOSITION_DECODE_RULE): Use it.
4491 * composite.c (get_composition_id): Remove unused local vars,
4492 by using the new macro.
4494 * textprop.c (set_text_properties_1): Change while to do-while,
4495 since the condition is always true at first.
4497 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4498 (interval_deletion_adjustment): Return unsigned value.
4501 * process.c (list_processes_1, create_pty, read_process_output):
4502 (exec_sentinel): Remove vars that were set but not used.
4503 (create_pty): Remove unnecessary "volatile"s.
4504 (Fnetwork_interface_info): Avoid possibility of int overflow.
4505 (read_process_output): Do adaptive read buffering even if carryover.
4506 (read_process_output): Simplify nbytes computation if buffered.
4508 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4510 * syntax.c (scan_words): Remove var that was set but not used.
4511 (update_syntax_table): Use unsigned instead of int.
4513 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4514 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4515 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4517 * print.c (print_error_message): Avoid int overflow.
4519 * font.c (font_list_entities): Redo for clarity,
4520 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4522 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4523 (font_score): Avoid potential overflow in diff calculation.
4525 * fns.c (substring_both): Remove var that is set but not used.
4526 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4528 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4530 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4531 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4532 can always succeed if overflow has undefined behavior.
4534 * search.c (boyer_moore, wordify): Remove vars set but not used.
4535 (wordify): Omit three unnecessary tests.
4537 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4538 All callers changed. This avoids the need for an unused var.
4540 * casefiddle.c (casify_region): Remove var that is set but not used.
4542 * dired.c (file_name_completion): Remove var that is set but not used.
4544 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4546 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4547 (Finsert_file_contents): Remove unnecessary code checking fd.
4549 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4550 Check for integer overflow on size calculations.
4552 * buffer.c (Fprevious_overlay_change): Remove var that is set
4555 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4556 Remove vars that are set but not used.
4557 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4558 (timer_check_2): Mark vars as initialized.
4560 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4562 * image.c (lookup_image): Remove var that is set but not used.
4563 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4565 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4566 that are set but not used.
4568 * xfns.c (make_invisible_cursor): Don't return garbage
4569 if XCreateBitmapFromData fails (Bug#8410).
4571 * xselect.c (x_get_local_selection, x_handle_property_notify):
4572 Remove vars that are set but not used.
4574 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4575 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4577 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4578 Remove var that is set but not used.
4579 (scroll_bar_windows_size): Now size_t, not int.
4580 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4583 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4584 (map_tty_color) [!defined MSDOS]: Likewise.
4586 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4588 * coding.c: Remove vars that are set but not used.
4589 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4590 All callers changed.
4591 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4592 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4593 (decode_coding_charset): Remove vars that are set but not used.
4595 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4596 that is set but not used.
4598 * print.c (print_object): Remove var that is set but not used.
4600 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4601 The gnulib version avoids calling malloc in the usual case,
4602 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4603 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4604 * filelock.c (current_lock_owner): Likewise.
4605 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4606 * sysdep.c: Include allocator.h, careadlinkat.h.
4607 (emacs_no_realloc_allocator): New static constant.
4608 (emacs_readlink): New function.
4609 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4610 ../lib/careadlinkat.h.
4612 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4614 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4615 first non-nil return value).
4617 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4619 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4620 if not defined (Bug#8403).
4622 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4624 * xdisp.c (display_count_lines): Remove parameter `start',
4625 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4626 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4627 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4628 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4629 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4630 and thereabouts. All callers changed.
4631 (get_per_char_metric): Remove parameter `f', unused since
4632 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4634 2011-04-02 Jim Meyering <meyering@redhat.com>
4636 do not dereference NULL upon failed strdup
4637 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4638 (ns_get_family): Likewise.
4640 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4642 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4644 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4646 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4649 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4651 Add lexical binding.
4653 * window.c (Ftemp_output_buffer_show): New fun.
4654 (Fsave_window_excursion):
4655 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4657 * lread.c (lisp_file_lexically_bound_p): New function.
4658 (Fload): Bind Qlexical_binding.
4659 (readevalloop): Remove `evalfun' arg.
4660 Bind Qinternal_interpreter_environment.
4661 (Feval_buffer): Bind Qlexical_binding.
4662 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4664 (syms_of_lread): Declare `lexical-binding'.
4666 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4668 * keyboard.c (eval_dyn): New fun.
4669 (menu_item_eval_property): Use it.
4671 * image.c (parse_image_spec): Use Ffunctionp.
4673 * fns.c (concat, mapcar1): Accept byte-code-functions.
4675 * eval.c (Fsetq): Handle lexical vars.
4676 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4677 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4678 (FletX, Flet): Obey lexical binding.
4679 (Fcommandp): Handle closures.
4680 (Feval): New `lexical' arg.
4681 (eval_sub): New function extracted from Feval. Use it almost
4682 everywhere where Feval was used. Look up vars in lexical env.
4684 (Ffunctionp): Move from subr.el.
4685 (Ffuncall): Handle closures.
4686 (apply_lambda): Remove `eval_flags'.
4687 (funcall_lambda): Handle closures and new byte-code-functions.
4688 (Fspecial_variable_p): New function.
4689 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4690 but without exporting it to Lisp.
4692 * doc.c (Fdocumentation, store_function_docstring):
4693 * data.c (Finteractive_form): Handle closures.
4695 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4698 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4700 (exec_byte_code): New function extracted from Fbyte_code to handle new
4701 calling convention for byte-code-functions. Add new byte-codes.
4703 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4705 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4707 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4709 * xdisp.c (redisplay_internal): Fix prototype.
4711 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4713 * xdisp.c (SCROLL_LIMIT): New macro.
4714 (try_scrolling): Use it when setting scroll_limit.
4715 Limit scrolling to 100 screen lines.
4716 (redisplay_window): Even when falling back on "recentering",
4717 position point in the window according to scroll-conservatively,
4718 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4720 (try_scrolling): When point is above the window, allow searching
4721 as far as scroll_max, or one screenful, to compute vertical
4722 distance from PT to the scroll margin position. This prevents
4723 try_scrolling from unnecessarily failing when
4724 scroll-conservatively is set to a value slightly larger than the
4725 window height. Clean up the case of PT below the margin at bottom
4726 of window: scroll_max can no longer be INT_MAX. When aggressive
4727 scrolling is in use, don't let point enter the opposite scroll
4728 margin as result of the scroll.
4729 (syms_of_xdisp) <scroll-conservatively>: Document the
4730 threshold of 100 lines for never-recentering scrolling.
4732 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4734 * dispextern.h (move_it_by_lines):
4735 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4736 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4737 (message_log_check_duplicate): Remove parameters `prev_bol' and
4738 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4739 (redisplay_internal): Remove parameter `preserve_echo_area',
4740 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4742 * indent.c (Fvertical_motion):
4743 * window.c (window_scroll_pixel_based, Frecenter):
4744 Don't pass `need_y_p' to `move_it_by_lines'.
4746 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4748 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4749 steal a few bits to be more compact.
4750 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4751 Remove unneeded casts.
4753 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4755 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4757 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4758 binding" message (bug#7967).
4760 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4762 Fix more problems found by GCC 4.6.0's static checks.
4764 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4765 Remove unused local var.
4767 * editfns.c (Fmessage_box): Remove unused local var.
4769 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4770 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4771 Omit unused local vars.
4772 * window.c (shrink_windows): Omit unused local var.
4773 * menu.c (digest_single_submenu): Omit unused local var.
4774 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4775 Omit unused local var.
4777 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4778 Don't assume string length fits in int.
4779 (keyremap_step, read_key_sequence): Use size_t for sizes.
4780 (read_key_sequence): Don't check last_real_key_start redundantly.
4782 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4783 instead of alloca (Bug#8344).
4785 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4786 (Fbacktrace_frame): Don't assume nframes fits in int.
4788 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4790 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4793 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4795 * cm.c (calccost): Turn while-do into do-while, for clarity.
4797 * keyboard.c (syms_of_keyboard): Use the same style as later
4798 in this function when indexing through an array. This also
4799 works around GCC bug 48267.
4801 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4803 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4805 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4806 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4808 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4809 This avoids undefined behavior on integer overflow, and is a bit
4810 more convenient anyway since it is compared to a size_t variable.
4812 Variadic C functions now count arguments with size_t, not int.
4813 This avoids an unnecessary limitation on 64-bit machines, which
4814 caused (substring ...) to crash on large vectors (Bug#8344).
4815 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4816 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4817 All variadic functions and their callers changed accordingly.
4818 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4819 * data.c (arith_driver, float_arith_driver): Likewise.
4820 * editfns.c (general_insert_function): Likewise.
4821 * eval.c (struct backtrace.nargs, interactive_p)
4822 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4823 (funcall_lambda, mark_backtrace): Likewise.
4824 * fns.c (concat): Likewise.
4825 * frame.c (x_set_frame_parameters): Likewise.
4826 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4827 0 if not found, not -1. All callers changed.
4829 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4830 (stack_copy_size): Now size_t, not int.
4831 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4833 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4835 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4836 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4837 All callers changed.
4839 * lisp.h (multibyte_char_to_unibyte):
4840 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4841 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4842 * character.h (CHAR_TO_BYTE8):
4843 * cmds.c (internal_self_insert):
4844 * editfns.c (general_insert_function):
4845 * keymap.c (push_key_description):
4846 * search.c (Freplace_match):
4847 * xdisp.c (message_dolog, set_message_1): All callers changed.
4849 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4851 * keyboard.c (safe_run_hook_funcall): New function.
4852 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4853 don't set the hook to nil, but remove the offending function instead.
4854 (Qcommand_hook_internal): Remove, unused.
4855 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4856 Vcommand_hook_internal.
4858 * eval.c (enum run_hooks_condition): Remove.
4859 (funcall_nil, funcall_not): New functions.
4860 (run_hook_with_args): Call each function through a `funcall' argument.
4861 Remove `cond' argument, now redundant.
4862 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4863 (Frun_hook_with_args_until_failure): Adjust accordingly.
4864 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4866 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4868 * dispextern.h (string_buffer_position): Remove declaration.
4870 * print.c (strout): Remove parameter `multibyte', unused since
4871 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4873 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4874 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4875 All callers changed.
4877 * w32.c (_wsa_errlist): Use braces for struct initializers.
4879 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4880 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4881 All callers changed.
4882 (string_buffer_position): Likewise. Also, make static (it's never
4883 used outside xdisp.c).
4884 (cursor_row_p): Remove parameter `w', unused since
4885 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4886 (decode_mode_spec): Remove parameter `precision', introduced during
4887 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4888 All callers changed.
4890 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4892 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4894 2011-03-27 Anders Lindgren <andlind@gmail.com>
4896 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4897 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4898 (ns_update_auto_hide_menu_bar): New functions.
4899 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4900 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4901 ns_constrain_all_frames.
4902 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4903 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4905 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4907 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4909 2011-03-27 Glenn Morris <rgm@gnu.org>
4911 * syssignal.h: Replace RETSIGTYPE with void.
4912 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4913 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4914 Replace SIGTYPE with void everywhere.
4915 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4916 * s/template.h (SIGTYPE): Remove commented out definition.
4918 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4920 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4921 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4923 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4925 * w32.c (read_unc_volume): Use parameter `henum', instead of
4926 global variable `wget_enum_handle'.
4928 * keymap.c (describe_vector): Remove parameters `indices' and
4929 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4930 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4932 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4934 * keyboard.c (timer_check): Remove parameter `do_it_now',
4935 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4936 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4937 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4939 * keyboard.c (read_char):
4940 * w32menu.c (w32_menu_display_help):
4941 * xmenu.c (show_help_event, menu_help_callback):
4942 Adjust calls to `show_help_echo'.
4944 * gtkutil.c (xg_maybe_add_timer):
4945 * keyboard.c (readable_events):
4946 * process.c (wait_reading_process_output):
4947 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4949 * insdel.c (adjust_markers_gap_motion):
4950 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4951 (gap_left, gap_right): Don't call it.
4953 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4955 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4956 incurred during fontification.
4958 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4960 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4961 (DEFVAR_PER_BUFFER): Don't pass it.
4963 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4964 (scrolling_window): Don't pass it.
4966 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4968 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4970 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4972 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4973 of variables specific to SELinux and computation of `encoded_absname'.
4975 * image.c (XPutPixel): Remove unused variable `height'.
4977 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4979 * unexw32.c (get_section_info): Remove unused variable `section'.
4981 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4982 (system_process_attributes): Remove unused variable `sess'.
4983 (sys_read): Remove unused variable `err'.
4985 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4986 (w32_wnd_proc): Remove unused variable `isdead'.
4987 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4988 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4989 (x_create_tip_frame): Remove unused variable `tem'.
4991 * w32inevt.c (w32_console_read_socket):
4992 Remove unused variable `no_events'.
4994 * w32term.c (x_draw_composite_glyph_string_foreground):
4995 Remove unused variable `width'.
4997 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4999 * w32term.c (x_set_glyph_string_clipping):
5000 Don't pass uninitialized region to CombineRgn.
5002 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5004 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5005 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5006 (Fx_close_connection): Remove unused variable `i'.
5008 * w32font.c (w32font_draw): Return number of glyphs.
5009 (w32font_open_internal): Remove unused variable `i'.
5010 (w32font_driver): Add missing initializer.
5012 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5013 (fill_in_menu): Remove unused variable `items_added'.
5015 * w32term.c (last_mouse_press_frame): Remove static global variable.
5016 (w32_clip_to_row): Remove unused variable `f'.
5017 (x_delete_terminal): Remove unused variable `i'.
5019 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5020 (NOTHING): Remove unused static global variable.
5021 (uniscribe_check_otf): Remove unused variable `table'.
5022 (uniscribe_font_driver): Add missing initializers.
5024 2011-03-23 Julien Danjou <julien@danjou.info>
5026 * term.c (Fsuspend_tty, Fresume_tty):
5027 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5028 * window.c (temp_output_buffer_show):
5029 * insdel.c (signal_before_change):
5030 * frame.c (Fhandle_switch_frame):
5031 * fileio.c (Fdo_auto_save):
5032 * emacs.c (Fkill_emacs):
5033 * editfns.c (save_excursion_restore):
5034 * cmds.c (internal_self_insert):
5035 * callint.c (Fcall_interactively):
5036 * buffer.c (Fkill_all_local_variables):
5037 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5039 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5040 unconditionnaly since it does the check itself.
5042 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5044 Fix more problems found by GCC 4.5.2's static checks.
5046 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5047 the first time through the loop, since we know p0 < p1 then.
5048 This also avoids a gcc -Wstrict-overflow warning.
5050 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5051 leading to a memory leak, possible in functions like
5052 load_charset_map_from_file that can allocate an unbounded number
5053 of objects (Bug#8318).
5055 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5056 that could (at least in theory) be that large.
5058 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5059 This is less likely to overflow, and avoids undefined behavior if
5060 overflow does occur. All callers changed. Use strtoul to scan
5061 for the unsigned long integer.
5062 (pint2hrstr): Simplify and tune code slightly.
5063 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5065 * scroll.c (do_scrolling): Work around GCC bug 48228.
5066 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5068 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5069 This also avoids a warning with gcc -Wstrict-overflow.
5070 (validate_x_resource_name): Simplify count usage.
5071 This also avoids a warning with gcc -Wstrict-overflow.
5073 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5076 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5078 * process.c (Fmake_network_process): Use socklen_t, not int,
5079 where POSIX says socklen_t is required in portable programs.
5080 This fixes a porting bug on hosts like 64-bit HP-UX, where
5081 socklen_t is wider than int (Bug#8277).
5082 (Fmake_network_process, server_accept_connection):
5083 (wait_reading_process_output, read_process_output):
5086 * process.c: Rename or move locals to avoid shadowing.
5087 (list_processes_1, Fmake_network_process):
5088 (read_process_output_error_handler, exec_sentinel_error_handler):
5089 Rename or move locals.
5090 (Fmake_network_process): Define label "retry_connect" only if needed.
5091 (Fnetwork_interface_info): Fix pointer signedness.
5092 (process_send_signal): Add cast to avoid pointer signedness problem.
5093 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5094 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5096 Make tparam.h and terminfo.c consistent.
5097 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5098 Include tparam.h instead, since it declares them.
5099 * cm.h (PC): Remove extern decl; tparam.h now does this.
5100 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5101 * terminfo.c: Include tparam.h, to check interfaces.
5102 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5103 (tparam): Adjust signature to match interface in tparam.h;
5104 this removes some undefined behavior. Check that outstring and len
5105 are zero, which they always are with Emacs.
5106 * tparam.h (PC, BC, UP): New extern decls.
5108 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5109 (xftfont_open): Rename locals to avoid shadowing.
5111 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5112 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5113 (OTF_TAG_SYM): Omit macro if not needed.
5114 (ftfont_list): Remove unused local.
5115 (get_adstyle_property, ftfont_pattern_entity):
5116 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5117 Rename locals to avoid shadowing.
5119 * xfont.c (xfont_list_family): Mark var as initialized.
5121 * xml.c (make_dom): Now static.
5123 * composite.c (composition_compute_stop_pos): Rename local to
5125 (composition_reseat_it): Remove unused locals.
5126 (find_automatic_composition, composition_adjust_point): Likewise.
5127 (composition_update_it): Mark var as initialized.
5128 (find_automatic_composition): Mark vars as initialized,
5129 with a FIXME (Bug#8290).
5131 character.h: Rename locals to avoid shadowing.
5132 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5133 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5134 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5135 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5138 * textprop.c (property_change_between_p): Remove; unused.
5140 * intervals.c (interval_start_pos): Now static.
5142 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5144 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5145 Rename locals to avoid shadowing.
5147 * sound.c (wav_play, au_play, Fplay_sound_internal):
5148 Fix pointer signedness.
5149 (alsa_choose_format): Remove unused local var.
5150 (wav_play): Initialize a variable to 0, to prevent undefined
5151 behavior (Bug#8278).
5153 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5155 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5157 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5158 clobbering (Bug#8298).
5159 * sysdep.c (sys_subshell): Likewise.
5160 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5162 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5163 This should get cleaned up, so that child_setup has the
5164 same signature on all platforms.
5166 * callproc.c (call_process_cleanup): Now static.
5167 (relocate_fd): Rename locals to avoid shadowing.
5169 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5171 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5172 not to be necessary, and produces flickering.
5174 2011-03-20 Glenn Morris <rgm@gnu.org>
5176 * config.in: Remove file.
5178 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5180 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5181 are now in src/globals.h.
5182 (syms_of_minibuf): Remove spurious & from previous change.
5184 2011-03-20 Leo <sdl.web@gmail.com>
5186 * minibuf.c (completing-read-function): New variable.
5187 (completing-read-default): Rename from completing-read.
5188 (completing-read): Call completing-read-function.
5190 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5192 * xfaces.c (Fx_load_color_file):
5193 Read color file from absolute filename (bug#8250).
5195 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5197 * makefile.w32-in: Update dependencies.
5199 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5201 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5203 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5205 Fix more problems found by GCC 4.5.2's static checks.
5207 * process.c (make_serial_process_unwind, send_process_trap):
5208 (sigchld_handler): Now static.
5210 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5211 That way, the code declares only the vars that it needs.
5212 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5213 * s/cygwin.h (PTY_ITERATION): Likewise.
5214 * s/darwin.h (PTY_ITERATION): Likewise.
5215 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5217 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5218 * process.c (allocate_pty): Don't declare stb unless it's needed.
5220 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5221 (CONSTANTLIM): Remove; unused.
5222 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5223 Define only if needed.
5225 * unexelf.c (unexec): Name an expression,
5226 to avoid gcc -Wbad-function-cast warning.
5227 Use a different way to cause a compilation error if anyone uses
5228 n rather than nn, a way that does not involve shadowing.
5229 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5231 * deps.mk (unexalpha.o): Remove; unused.
5233 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5234 * unexec.h: New file.
5235 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5236 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5238 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5239 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5240 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5241 Change as necessary to match prototype in unexec.h.
5243 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5245 (back_comment, skip_chars): Mark vars as initialized.
5247 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5248 Rename locals to avoid shadowing.
5250 * lread.c (read1): Rewrite so as not to use empty "else".
5251 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5253 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5255 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5256 warning when compiling print.c.
5258 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5259 instead of using an uninitialized var.
5260 (font_sort_entities): Mark var as initialized.
5262 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5264 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5265 pointers to constants.
5266 (font_parse_fcname): Remove unused vars.
5267 (font_delete_unmatched): Now static.
5268 (font_get_spec): Remove; unused.
5269 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5270 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5271 Rename or move locals to avoid shadowing.
5273 * fns.c (require_nesting_list, require_unwind): Now static.
5274 (Ffillarray): Rename locals to avoid shadowing.
5276 * floatfns.c (domain_error2): Define only if needed.
5277 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5279 * alloc.c (mark_backtrace): Move decl from here ...
5280 * lisp.h: ... to here, so that it can be checked.
5282 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5283 (Fdefvar): Rewrite so as not to use empty "else".
5284 (lisp_indirect_variable): Name an expression,
5285 to avoid gcc -Wbad-function-cast warning.
5286 (Fdefvar): Rename locals to avoid shadowing.
5288 * callint.c (quotify_arg, quotify_args): Now static.
5289 (Fcall_interactively): Rename locals to avoid shadowing.
5290 Use const pointer when appropriate.
5292 * lisp.h (get_system_name, get_operating_system_release):
5293 Move decls here, to check interfaces.
5294 * process.c (get_operating_system_release): Move decl to lisp.h.
5295 * xrdb.c (get_system_name): Likewise.
5296 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5297 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5298 some of which prompt warnings from gcc -Wbad-function-cast.
5299 (Fformat_time_string, Fencode_time, Finsert_char):
5300 (Ftranslate_region_internal, Fformat):
5301 Rename or remove local vars to avoid shadowing.
5302 (Ftranslate_region_internal): Mark var as initialized.
5304 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5307 * lisp.h (eassert): Check that the argument compiles, even if
5308 ENABLE_CHECKING is not defined.
5310 * data.c (Findirect_variable): Name an expression, to avoid
5311 gcc -Wbad-function-cast warning.
5312 (default_value, arithcompare, arith_driver, arith_error): Now static.
5313 (store_symval_forwarding): Rename local to avoid shadowing.
5314 (Fmake_variable_buffer_local, Fmake_local_variable):
5315 Mark variables as initialized.
5316 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5318 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5319 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5320 Rename locals to avoid shadowing.
5321 (mark_stack): Move local variables into the #ifdef region where
5323 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5324 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5326 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5327 (GC_STRING_CHARS): Remove; not used.
5328 (Fmemory_limit): Cast sbrk's returned value to char *.
5330 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5331 avoids undefined behavior in theory.
5333 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5335 Use functions, not macros, for up- and down-casing (Bug#8254).
5336 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5337 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5338 to use the following functions instead of these macros.
5339 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5340 EMACS_INT, since callers assume the returned value fits in int.
5341 (upcase1): Likewise, for UPCASE_TABLE.
5342 (uppercasep, lowercasep, upcase): New static inline functions.
5343 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5344 the race-condition problem in the old DOWNCASE.
5346 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5347 Rename locals to avoid shadowing.
5348 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5349 (regex_compile, re_search_2, re_match_2_internal):
5350 Remove unused local vars.
5351 (FREE_VAR): Rewrite so as not to use empty "else",
5352 which gcc can warn about.
5353 (regex_compile, re_match_2_internal): Mark locals as initialized.
5354 (RETALLOC_IF): Define only if needed.
5355 (WORDCHAR_P): Likewise. This one is never needed, but is used
5356 only in a comment talking about a compiler bug, so put inside
5357 the #if 0 of that comment.
5358 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5359 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5362 * search.c (boyer_moore): Rename locals to avoid shadowing.
5363 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5364 (PREV_CHAR_BOUNDARY): Likewise.
5366 * search.c (simple_search): Remove unused var.
5368 * dired.c (compile_pattern): Move decl from here ...
5369 * lisp.h: ... to here, so that it can be checked.
5370 (struct re_registers): New forward decl.
5372 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5374 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5376 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5377 Rename locals to avoid shadowing.
5378 (Fvertical_motion): Mark locals as initialized.
5380 * casefiddle.c (casify_object, casify_region): Now static.
5381 (casify_region): Mark local as initialized.
5383 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5385 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5386 New macros, so that the caller can use some names other than
5387 gcpro1, gcpro2, etc.
5388 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5390 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5391 argument, for consistency with GCPRO2_VAR, etc: it is now the
5392 prefix of the variable, not the variable itself. All uses
5394 * dired.c (directory_files_internal, file_name_completion):
5395 Rename locals to avoid shadowing.
5397 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5398 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5399 dired.c's scmp function, had undefined behavior.
5400 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5401 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5402 * buffer.h: ... to here, because these macros use current_buffer,
5403 and the new implementation with inline functions needs to have
5404 current_buffer in scope now, rather than later when the macros
5406 (downcase, upcase1): New static inline functions.
5407 (DOWNCASE, UPCASE1): Reimplement using these functions.
5408 This avoids undefined behavior in expressions like
5409 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5410 from race conditions in accessing the global variables
5411 case_temp1 and case_temp2.
5412 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5413 * lisp.h (case_temp1, case_temp2): Remove their decls.
5414 * character.h (ASCII_CHAR_P): Move from here ...
5415 * lisp.h: ... to here, so that the inline functions mentioned
5418 * dired.c (directory_files_internal_unwind): Now static.
5420 * fileio.c (file_name_as_directory, directory_file_name):
5421 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5423 (file_name_as_directory): Use const pointers when appropriate.
5424 (Fexpand_file_name): Likewise. In particular, newdir might
5425 point at constant storage, so make it a const pointer.
5426 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5427 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5429 (Fset_file_times, Finsert_file_contents, auto_save_error):
5430 Rename locals to avoid shadowing.
5432 * minibuf.c (choose_minibuf_frame_1): Now static.
5433 (Ftry_completion, Fall_completions): Rename or remove locals
5436 * marker.c (bytepos_to_charpos): Remove; unused.
5438 * lisp.h (verify_bytepos, count_markers): New decls,
5439 so that gcc does not warn that these functions aren't declared.
5441 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5442 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5443 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5444 (copy_text): Remove unused local var.
5446 * filelock.c (within_one_second): Now static.
5447 (lock_file_1): Rename local to avoid shadowing.
5449 * buffer.c (fix_overlays_before): Mark locals as initialized.
5450 (fix_start_end_in_overlays): Likewise. This function should be
5451 simplified by using pointers-to-pointers, but that's a different
5453 (switch_to_buffer_1): Now static.
5454 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5455 (report_overlay_modification): Rename locals to avoid shadowing.
5457 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5458 Fix pointer signedness issue.
5459 (sys_subshell): Mark local as volatile if checking for lint,
5460 to suppress a gcc -Wclobbered warning that does not seem to be right.
5461 (MAXPATHLEN): Define only if needed.
5463 * process.c (serial_open, serial_configure): Move decls from here ...
5464 * systty.h: ... to here, so that they can be checked.
5466 * fns.c (get_random, seed_random): Move extern decls from here ...
5467 * lisp.h: ... to here, so that they can be checked.
5469 * sysdep.c (reset_io): Now static.
5470 (wait_for_termination_signal): Remove; unused.
5472 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5473 (copy_keymap_item, append_key, push_text_char_description):
5475 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5476 (DENSE_TABLE_SIZE): Remove; unused.
5477 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5478 (describe_map_tree):
5479 Rename locals to avoid shadowing.
5481 * keyboard.c: Declare functions static if they are not used elsewhere.
5482 (echo_char, echo_dash, cmd_error, top_level_2):
5483 (poll_for_input, handle_async_input): Now static.
5484 (read_char, kbd_buffer_get_event, make_lispy_position):
5485 (make_lispy_event, make_lispy_movement, apply_modifiers):
5486 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5487 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5488 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5489 (read_key_sequence, read_char): Mark locals as initialized.
5490 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5492 * keyboard.h (make_ctrl_char): New decl.
5493 (mark_kboards): Move decl here ...
5494 * alloc.c (mark_kboards): ... from here.
5496 * lisp.h (force_auto_save_soon): New decl.
5498 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5499 (DEFINE_DUMMY_FUNCTION): New macro.
5500 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5502 (main): Add casts to avoid warnings
5503 if GCC considers string literals to be constants.
5505 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5507 * dbusbind.c: Pointer signedness fixes.
5508 (xd_signature, xd_append_arg, xd_initialize):
5509 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5510 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5511 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5512 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5514 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5515 if GCC considers string literals to be constants.
5516 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5518 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5520 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5521 (print_preprocess, print_object): New macro to fix last change.
5523 * print.c (print_preprocess): Don't forget font objects.
5525 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5527 * emacs.c (USAGE3): Doc fixes.
5529 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5531 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5534 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5536 * lisp.h (VWindow_system, Qfile_name_history):
5537 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5538 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5539 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5541 * w32select.c: Don't #include "keyboard.h".
5542 (run_protected): Add extern declaration for waiting_for_input.
5544 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5545 * w32console.c (detect_input_pending, read_input_pending)
5546 (encode_terminal_code):
5547 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5548 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5549 (w32_system_caret_y, Qfile_name_history):
5550 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5551 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5552 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5553 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5554 * w32proc.c (Qlocal, report_file_error):
5555 * w32term.c (Vwindow_system, updating_frame):
5556 * w32uniscribe.c (initialized, uniscribe_font_driver):
5557 Remove unneeded extern declarations.
5559 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5561 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5563 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5565 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5566 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5567 These macros can no longer be used for assignment.
5569 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5570 Assign struct members directly, instead of using BUF_BEGV etc.
5571 (record_buffer_markers, fetch_buffer_markers): New functions for
5572 recording and fetching special buffer markers.
5573 (set_buffer_internal_1, set_buffer_temp): Use them.
5575 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5577 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5579 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5580 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5582 * xdisp.c (hscroll_window_tree):
5583 (reconsider_clip_changes): Use PT instead of BUF_PT.
5585 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5587 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5588 $(EMACS_ROOT)/lib/intprops.h.
5590 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5592 Fix more problems found by GCC 4.5.2's static checks.
5594 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5595 to unsigned char * to avoid compiler diagnostic.
5596 (xg_free_frame_widgets): Make it clear that a local variable is
5597 needed only if USE_GTK_TOOLTIP.
5598 (gdk_window_get_screen): Make it clear that this macro is needed
5599 only if USE_GTK_TOOLTIP.
5600 (int_gtk_range_get_value): New function, which avoids a diagnostic
5601 from gcc -Wbad-function-cast.
5602 (xg_set_toolkit_scroll_bar_thumb): Use it.
5603 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5604 diagnostic from gcc -Wbad-function-cast.
5605 (get_utf8_string, xg_get_file_with_chooser):
5606 Rename locals to avoid shadowing.
5607 (create_dialog): Move locals to avoid shadowing.
5609 * xgselect.c (xg_select): Remove unused var.
5611 * image.c (four_corners_best): Mark locals as initialized.
5612 (gif_load): Initialize transparent_p to zero (Bug#8238).
5613 Mark another local as initialized.
5614 (my_png_error, my_error_exit): Mark with NO_RETURN.
5616 * image.c (clear_image_cache): Now static.
5617 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5618 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5619 (x_edge_detection): Remove unnecessary cast that
5620 gcc -Wbad-function-cast diagnoses.
5621 (gif_load): Fix pointer signedness.
5622 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5623 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5625 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5627 Improve quality of tests for time stamp overflow.
5628 For example, without this patch (encode-time 0 0 0 1 1
5629 1152921504606846976) returns the obviously-bogus value (-948597
5630 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5631 reports time overflow. See
5632 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5633 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5634 * editfns.c: Include limits.h and intprops.h.
5635 (TIME_T_MIN, TIME_T_MAX): New macros.
5636 (time_overflow): Move earlier, to before first use.
5637 (hi_time, lo_time): New functions, for an accurate test for
5639 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5640 (Fget_internal_run_time): Don't assume time_t fits in int.
5641 (make_time): Use list2 instead of Fcons twice.
5642 (Fdecode_time): More accurate test for out-of-range times.
5643 (check_tm_member): New function.
5644 (Fencode_time): Use it, to test for out-of-range times.
5645 (lisp_time_argument): Don't rely on undefined left-shift and
5646 right-shift behavior when checking for time stamp overflow.
5648 * editfns.c (time_overflow): New function, refactoring common code.
5649 (Fformat_time_string, Fdecode_time, Fencode_time):
5650 (Fcurrent_time_string): Use it.
5652 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5653 * dired.c (make_time): Move to ...
5654 * editfns.c (make_time): ... here.
5655 * systime.h: Note the move.
5657 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5659 * fringe.c (update_window_fringes): Remove unused variables.
5661 * unexmacosx.c (copy_data_segment): Also copy __got section.
5664 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5666 * termcap.c [MSDOS]: Include "msdos.h".
5667 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5668 Constify `char *' arguments and their references according to
5669 prototypes in tparam.h.
5671 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5673 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5674 Adapt all references accordingly.
5676 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5678 2011-03-11 Tom Tromey <tromey@redhat.com>
5680 * buffer.c (syms_of_buffer): Remove obsolete comment.
5682 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5684 * termhooks.h (encode_terminal_code): Declare prototype.
5686 * msdos.c (encode_terminal_code): Don't declare prototype.
5688 * term.c (encode_terminal_code): Now external again, used by
5689 w32console.c and msdos.c.
5691 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5692 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5694 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5696 Fix some minor problems found by GCC 4.5.2's static checks.
5698 * fringe.c (update_window_fringes): Mark locals as initialized
5700 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5702 * alloc.c (mark_fringe_data): Move decl from here ...
5703 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5704 to check its interface.
5705 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5707 * fontset.c (free_realized_fontset): Now static.
5708 (Fset_fontset_font): Rename local to avoid shadowing.
5709 (fontset_font): Mark local as initialized.
5710 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5712 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5714 * xselect.c (x_disown_buffer_selections): Remove; not used.
5715 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5716 (x_own_selection, Fx_disown_selection_internal): Rename locals
5718 (x_handle_dnd_message): Remove local to avoid shadowing.
5720 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5721 so that the caller can use some name other than gcpro1.
5722 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5723 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5724 (Fx_backspace_delete_keys_p):
5725 Use them to avoid shadowing, and rename vars to avoid shadowing.
5726 (x_decode_color, x_set_name, x_window): Now static.
5727 (Fx_create_frame): Add braces to silence GCC warning.
5728 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5729 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5730 Remove unused locals.
5731 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5732 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5733 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5736 * xterm.h (x_mouse_leave): New decl.
5738 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5739 Remove unused functions.
5740 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5741 (x_calc_absolute_position): Now static.
5742 (XTread_socket): Don't define label "out" unless it's used.
5743 Don't declare local "event" unless it's used.
5744 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5745 unless they are used.
5746 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5747 (x_fatal_error_signal): Remove; not used.
5748 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5749 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5750 (x_error_catcher, x_connection_closed, x_error_handler):
5751 (x_error_quitter, xembed_send_message, x_iconify_frame):
5752 (my_log_handler): Rename locals to avoid shadowing.
5753 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5754 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5756 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5757 Rename or move locals to avoid shadowing.
5758 (tty_defined_color, merge_face_heights): Now static.
5759 (free_realized_faces_for_fontset): Remove; not used.
5760 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5761 does not deduce is never used uninitialized.
5762 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5763 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5765 * terminal.c (store_terminal_param): Now static.
5767 * xmenu.c (menu_highlight_callback): Now static.
5768 (set_frame_menubar): Remove unused local.
5769 (xmenu_show): Rename parameter to avoid shadowing.
5770 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5771 since they might point to immutable storage.
5772 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5773 since it's unused otherwise.
5775 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5776 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5777 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5778 avoids a gcc -Wuninitialized diagnostic.
5779 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5780 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5781 does not deduce are never used uninitialized.
5783 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5785 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5786 * window.c (window_loop, size_window):
5787 (run_window_configuration_change_hook, enlarge_window): Likewise.
5789 * window.c (display_buffer): Now static.
5790 (size_window): Mark variables that gcc -Wuninitialized
5791 does not deduce are never used uninitialized.
5792 * window.h (check_all_windows): New decl, to forestall
5793 gcc -Wmissing-prototypes diagnostic.
5794 * dispextern.h (bidi_dump_cached_states): Likewise.
5796 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5798 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5800 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5801 and to avoid gcc -Wuninitialized warning.
5802 (load_charset_map): Mark variables that gcc -Wuninitialized
5803 does not deduce are never used uninitialized.
5804 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5806 * coding.c (coding_set_source, coding_set_destination):
5807 Use "else { /* comment */ }" rather than "else /* comment */;"
5808 for clarity, and to avoid gcc -Wempty-body warning.
5809 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5810 a block, when the outer 'i' will do.
5811 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5812 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5813 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5814 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5815 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5816 Rename locals to avoid shadowing.
5817 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5818 * coding.c (emacs_mule_char, encode_invocation_designation):
5819 Now static, since they're not used elsewhere.
5820 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5821 (decode_coding_object, encode_coding_object, detect_coding_system):
5822 (decode_coding_emacs_mule): Mark variables that gcc
5823 -Wuninitialized does not deduce are never used uninitialized.
5824 (detect_coding_iso_2022): Initialize a local variable that might
5825 be used uninitialized. Leave a FIXME because it's not clear that
5826 this initialization is needed. (Bug#8211)
5827 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5828 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5829 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5830 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5831 Remove unused macros.
5833 * category.c (hash_get_category_set): Remove unused local var.
5834 (copy_category_table): Now static, since it's not used elsewhere.
5835 * character.c (string_count_byte8): Likewise.
5837 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5838 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5840 * chartab.c (copy_sub_char_table): Now static, since it's not used
5842 (sub_char_table_ref_and_range, char_table_ref_and_range):
5843 Rename locals to avoid shadowing.
5844 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5846 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5847 (BIDI_BOB): Remove unused macro.
5849 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5850 deduce are never used uninitialized.
5851 * term.c (encode_terminal_code): Likewise.
5853 * term.c (encode_terminal_code): Now static. Remove unused local.
5855 * tparam.h: New file.
5856 * term.c, tparam.h: Include it.
5857 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5858 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5859 Move these decls to tparam.h, and make them agree with what
5860 is actually in tparam.c. The previous trick of using incompatible
5861 decls in different modules does not conform to the C standard.
5862 All callers of tparam changed to use tparam's actual API.
5863 * tparam.c (tparam1, tparam, tgoto):
5864 Use const pointers where appropriate.
5866 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5867 * cm.h (struct cm): Likewise.
5868 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5869 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5870 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5871 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5872 (turn_on_face, init_tty): Likewise.
5873 * termchar.h (struct tty_display_info): Likewise.
5875 * term.c (term_mouse_position): Rename local to avoid shadowing.
5877 * alloc.c (mark_ttys): Move decl from here ...
5878 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5880 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5882 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5884 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5886 * search.c (compile_pattern_1): Remove argument regp, unused since
5887 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5888 (compile_pattern): Don't pass it.
5890 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5892 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5893 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5895 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5897 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5899 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5900 gdk_window_get_screen, gdk_window_get_geometry,
5901 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5902 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5903 (xg_get_pixbuf_from_pixmap): New function.
5904 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5905 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5906 Call xg_get_pixbuf_from_pixmap instead of
5907 gdk_pixbuf_get_from_drawable.
5908 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5909 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5910 (xg_check_special_colors): Use GtkStyleContext and its functions
5912 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5913 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5914 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5915 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5916 Call gtk_widget_get_preferred_size.
5917 (xg_frame_resized): gdk_window_get_geometry only takes 5
5919 (xg_win_to_widget, xg_event_is_for_menubar):
5920 Call gdk_x11_window_lookup_for_display.
5921 (xg_set_widget_bg): New function.
5922 (delete_cb): New function.
5923 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5924 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5925 (xg_set_background_color): Call xg_set_widget_bg.
5926 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5927 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5928 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5929 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5931 (update_frame_tool_bar): Call gtk_widget_hide.
5932 (xg_initialize): Use GDK_KEY_g.
5934 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5936 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5938 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5939 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5940 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5942 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5944 * w32xfns.c (select_palette): Check success of RealizePalette against
5945 GDI_ERROR, not zero.
5947 See ChangeLog.11 for earlier changes.
5953 Copyright (C) 2011 Free Software Foundation, Inc.
5955 This file is part of GNU Emacs.
5957 GNU Emacs is free software: you can redistribute it and/or modify
5958 it under the terms of the GNU General Public License as published by
5959 the Free Software Foundation, either version 3 of the License, or
5960 (at your option) any later version.
5962 GNU Emacs is distributed in the hope that it will be useful,
5963 but WITHOUT ANY WARRANTY; without even the implied warranty of
5964 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5965 GNU General Public License for more details.
5967 You should have received a copy of the GNU General Public License
5968 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.