1 2012-03-10 Chong Yidong <cyd@gnu.org>
3 * frame.c (other_visible_frames): Don't assume the selected frame
4 is visible (Bug#10955).
6 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
8 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
10 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
12 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
13 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
16 2012-03-03 Glenn Morris <rgm@gnu.org>
18 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
20 2012-03-02 Eli Zaretskii <eliz@gnu.org>
22 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
23 position past the first glyph_row that ends at ZV. (Bug#10902)
24 (redisplay_window, next_element_from_string): Fix typos in
26 (redisplay_window): Pass to move_it_vertically the margin in
27 pixels, not in screen lines.
29 2012-03-02 Glenn Morris <rgm@gnu.org>
31 * buffer.c (buffer-list-update-hook): Doc fix.
33 2012-02-29 Eli Zaretskii <eliz@gnu.org>
35 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
36 push_it before setting up the iterator for the first overlay
37 string, even if we have an empty string loaded.
38 (next_overlay_string): If there's an empty string on the iterator
39 stack, pop the stack. (Bug#10903)
41 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
43 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
44 Suggested by Stefan Monnier in
45 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
46 * alloc.c (widen_to_Lisp_Object): New static function.
47 (mark_memory): Also mark Lisp_Objects by fetching pointer words
48 and widening them to Lisp_Objects. This would work even if
49 USE_LSB_TAG is defined and wide integers are used, which might
50 happen in a future version of Emacs.
52 2012-02-25 Chong Yidong <cyd@gnu.org>
54 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
57 * xselect.c (Fx_selection_exists_p): Doc fix.
58 (x_clipboard_manager_save_all): Print an informative message
59 before saving to clipboard manager.
61 2012-02-24 Chong Yidong <cyd@gnu.org>
63 * keyboard.c (process_special_events): Handle all X selection
64 requests in kbd_buffer, not just the next one (Bug#8869).
66 2012-02-23 Chong Yidong <cyd@gnu.org>
68 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
69 call when setting menu-bar-lines and tool-bar-lines parameters.
70 (unwind_create_frame_1): New helper function.
72 * window.c (inhibit_window_configuration_change_hook): New var.
73 (run_window_configuration_change_hook): Obey it.
74 (syms_of_window): Initialize it.
76 2012-02-22 Chong Yidong <cyd@gnu.org>
78 * xterm.c (x_draw_image_relief): Add missing type check for
79 Vtool_bar_button_margin (Bug#10743).
81 2012-02-21 Chong Yidong <cyd@gnu.org>
83 * fileio.c (Vfile_name_handler_alist): Doc fix.
85 * buffer.c (Fget_file_buffer): Protect against invalid file
88 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
90 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
91 when computing $valmask.
93 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
94 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
95 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
96 It's useless in that case, and it can cause problems on hosts
97 that allocate halves of EMACS_INT values separately.
98 Reported by Dan Horák. Diagnosed by Andreas Schwab in
99 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
100 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
101 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
102 it avoids undefined behavior on hosts where shifting right by more
103 than the word width has undefined behavior.
105 2012-02-19 Chong Yidong <cyd@gnu.org>
107 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
108 (Funhandled_file_name_directory, Ffile_name_as_directory)
109 (Fdirectory_file_name, Fexpand_file_name)
110 (Fsubstitute_in_file_name): Protect against invalid file handler
111 return values (Bug#10845).
113 2012-02-18 Eli Zaretskii <eliz@gnu.org>
115 * .gdbinit (pitx): Fix incorrect references to fields of the
118 2012-02-17 Chong Yidong <cyd@gnu.org>
120 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
122 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
124 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
125 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
127 2012-02-15 Chong Yidong <cyd@gnu.org>
129 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
130 marked as special. Also, starting docstrings with * is obsolete.
132 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
134 * gnutls.c (emacs_gnutls_write): Fix last change.
136 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
138 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
141 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
143 * keymap.c (Fsingle_key_description): Handle char ranges.
145 2012-02-12 Chong Yidong <cyd@gnu.org>
147 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
148 as that creates a dangerous corner case.
150 * window.c (Fdelete_window_internal): Invalidate the mouse
151 highlight (Bug#9904).
153 2012-02-12 Glenn Morris <rgm@gnu.org>
155 * xselect.c (Fx_own_selection_internal)
156 (Fx_get_selection_internal, Fx_disown_selection_internal)
157 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
158 * nsselect.m (Fx_own_selection_internal)
159 (Fx_disown_selection_internal, Fx_selection_exists_p)
160 (Fx_selection_owner_p, Fx_get_selection_internal):
161 Sync docs and argument specs with the xselect.c versions.
163 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
165 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
167 2012-02-11 Eli Zaretskii <eliz@gnu.org>
169 * w32select.c (Fx_selection_exists_p): Sync doc string and
170 argument list with xselect.c. (Bug#10783)
172 * w16select.c (Fx_selection_exists_p): Sync doc string and
173 argument list with xselect.c. (Bug#10783)
175 2012-02-10 Glenn Morris <rgm@gnu.org>
177 * fns.c (Fsecure_hash): Doc fix.
179 2012-02-09 Kenichi Handa <handa@m17n.org>
181 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
183 2012-02-07 Chong Yidong <cyd@gnu.org>
185 * buffer.c (Fbuffer_local_variables)
186 (buffer_lisp_local_variables): Handle unbound vars correctly;
187 don't let Qunbound leak into Lisp.
189 2012-02-07 Glenn Morris <rgm@gnu.org>
191 * image.c (Fimagemagick_types): Doc fix.
193 * image.c (imagemagick-render-type): Change it from a lisp object
194 to an integer. Move the doc here from the lisp manual.
195 Treat all values not equal to 0 the same.
197 2012-02-06 Chong Yidong <cyd@gnu.org>
199 * doc.c (store_function_docstring): Avoid applying docstring of
200 alias to base function (Bug#2603).
202 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
204 * .gdbinit (pp1, pv1): Remove redundant defines.
207 2012-02-04 Chong Yidong <cyd@gnu.org>
209 * nsterm.m: Declare a global (Bug#10694).
211 2012-02-04 Eli Zaretskii <eliz@gnu.org>
213 * w32.c (get_emacs_configuration_options):
214 Include --enable-checking, if specified, in the return value.
216 2012-02-04 Martin Rudalics <rudalics@gmx.at>
218 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
219 after rounding frame sizes. (Bug#9723)
221 2012-02-04 Eli Zaretskii <eliz@gnu.org>
223 * keyboard.c (adjust_point_for_property): Don't position point
224 before BEGV. (Bug#10696)
226 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
228 Handle overflow when computing char display width (Bug#9496).
229 * character.c (char_width): Return EMACS_INT, not int.
230 (char_width, c_string_width): Check for overflow when
231 computing the width; this is possible now that individual
232 characters can have unbounded width. Problem introduced
233 by merge from Emacs 23 on 2012-01-19.
235 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
237 * dbusbind.c (Fdbus_register_method): Mention the return value
238 :ignore in the docstring.
240 2012-02-02 Glenn Morris <rgm@gnu.org>
242 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
244 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
245 Unconditionally set to t. (Bug#10673)
246 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
247 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
248 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
250 2012-02-02 Kenichi Handa <handa@m17n.org>
252 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
253 0, do not call append_composite_glyph.
255 2012-02-02 Kenichi Handa <handa@m17n.org>
257 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
259 (x_produce_glyphs): If the component of a composition is a null
260 string, set it->pixel_width to 1 to avoid zero-width glyph.
262 2012-02-01 Eli Zaretskii <eliz@gnu.org>
264 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
265 first 2 arguments are identical. This makes inserting large
266 output from a subprocess an order of magnitude faster on
267 MS-Windows, where all sbrk'ed memory is always contiguous.
269 2012-01-31 Glenn Morris <rgm@gnu.org>
271 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
272 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
273 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
275 2012-01-29 Glenn Morris <rgm@gnu.org>
277 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
279 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
281 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
283 2012-01-28 Chong Yidong <cyd@gnu.org>
285 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
287 2012-01-26 Chong Yidong <cyd@gnu.org>
289 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
291 * search.c (Fsearch_forward, Fsearch_backward): Document negative
292 repeat counts (Bug#10507).
294 2012-01-26 Glenn Morris <rgm@gnu.org>
296 * lread.c (syms_of_lread): Doc fix.
298 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
300 * coding.c (encode_designation_at_bol): Change return value to
303 2012-01-25 Chong Yidong <cyd@gnu.org>
305 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
307 2012-01-21 Chong Yidong <cyd@gnu.org>
309 * floatfns.c (Fcopysign): Make the second argument non-optional,
310 since nil is not allowed anyway.
312 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
314 * process.c (read_process_output): Use p instead of XPROCESS (proc).
315 (send_process): Likewise.
317 2012-01-19 Martin Rudalics <rudalics@gmx.at>
319 * window.c (save_window_save, Fcurrent_window_configuration)
320 (Vwindow_persistent_parameters): Do not use Qstate.
323 2012-01-19 Kenichi Handa <handa@m17n.org>
325 * character.c (char_width): New function.
326 (Fchar_width, c_string_width, lisp_string_width):
327 Use char_width (Bug#9496).
329 2012-01-16 Martin Rudalics <rudalics@gmx.at>
331 * window.c (Vwindow_persistent_parameters): New variable.
332 (Fset_window_configuration, save_window_save): Handle persistent
335 2012-01-14 Eli Zaretskii <eliz@gnu.org>
337 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
338 thrashing the stack of the thread. (Bug#9087)
340 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
342 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
344 2012-01-11 Eli Zaretskii <eliz@gnu.org>
346 * xdisp.c (rows_from_pos_range): Handle the case where the
347 highlight ends on a newline. (Bug#10464)
348 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
349 he end column for display of highlight that ends on a newline
352 2012-01-11 Glenn Morris <rgm@gnu.org>
354 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
355 from load-path also when installation-directory is nil. (Bug#10208)
357 2012-01-10 Glenn Morris <rgm@gnu.org>
359 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
361 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
362 Update template values to be closer to their typical values these days.
364 2012-01-09 Eli Zaretskii <eliz@gnu.org>
366 * xdisp.c (rows_from_pos_range): Accept additional argument
367 DISP_STRING, and accept any glyph in a row whose object is that
368 string as eligible for mouse highlight. Fixes mouse highlight of
369 display strings from overlays. (Bug#10464)
371 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
373 emacs: fix an auto-save permissions race condition (Bug#10400)
374 * fileio.c (auto_saving_dir_umask): New static var.
375 (Fmake_directory_internal): Use it.
376 (do_auto_save_make_dir): Set it, instead of invoking chmod after
377 creating the directory. The old code temporarily assigns
378 too-generous permissions to the directory.
379 (do_auto_save_eh): Clear it.
380 (Fdo_auto_save): Catch all errors, not just file errors, so
381 that the var is always cleared.
383 2012-01-07 Eli Zaretskii <eliz@gnu.org>
385 * search.c (scan_buffer): Pass character positions to
386 know_region_cache, not byte positions. (Bug#6540)
388 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
390 * w32.c (sys_rename): Report EXDEV when rename of a directory
391 fails because the target is on another logical disk. (Bug#10284)
393 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
395 * xterm.c (x_embed_request_focus): New function.
397 * xterm.h: Add prototype.
399 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
401 2012-01-05 Glenn Morris <rgm@gnu.org>
403 * emacs.c (emacs_copyright): Update short copyright year to 2012.
405 2012-01-01 Eli Zaretskii <eliz@gnu.org>
407 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
408 Load gnutls_transport_set_lowat only if GnuTLS version is below
410 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
411 GnuTLS versions below 2.11.1.
413 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
415 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
416 to the doc string advising against its use for altering the way
417 windows are scrolled.
419 2011-12-28 Kenichi Handa <handa@m17n.org>
421 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
422 coding-system ASCII compatible only when it does not produce BOM
423 on encoding (Bug#10383).
425 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
427 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
429 (create_and_show_popup_menu): Always use menu_position_func for
432 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
434 * callint.c (Fcall_interactively): Don't truncate prompt string.
436 2011-12-23 Eli Zaretskii <eliz@gnu.org>
438 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
439 property that ends at ZV, so that the bidi iteration could be
440 resumed from there (after widening). (Bug#10360)
442 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
444 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
446 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
448 * nsterm.m (x_free_frame_resources):
449 Release f->output_data.ns->miniimage.
450 (ns_index_color): Fix indentation. Do not retain
451 color_table->colors[i].
453 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
456 * nsfns.m (x_set_background_color): Assign return value from
457 ns_index_color to face-background instead of NSColor*.
458 (ns_implicitly_set_icon_type): Fix indentation.
459 Change assignment in for loop to comparison.
461 * emacs.c (ns_pool): New variable.
462 (main): Assign ns_pool.
463 (Fkill_emacs): Call ns_release_autorelease_pool.
465 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
466 autorelease fdesc, release fdAttrs and tdict.
467 (ns_get_covering_families): Release charset.
468 (ns_findfonts): Release NSFontDescriptor created with new.
469 (ns_uni_to_glyphs): Fix indentation.
470 (setString): Release attrStr before assigning new value.
472 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
474 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
476 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
477 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
479 2011-12-18 David Reitter <reitter@cmu.edu>
481 * nsterm.m (ns_term_init): Subscribe for notifications
482 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
483 to method trackingNotification in EmacsMenu.
485 * nsmenu.m (trackingMenu): New variable.
486 (trackingNotification): New method (from Aquamacs).
487 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
488 from Aquamacs (Bug#7030).
490 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
492 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
493 (symbol_to_nsstring): Fix indentation.
494 (ns_symbol_to_pb): New function.
495 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
496 (Fns_rotate_cut_buffers_internal): Remove.
497 (Fns_store_selection_internal): Rename from
498 Fns_store_cut_buffer_internal.
499 (ns_get_foreign_selection, Fx_own_selection_internal)
500 (Fx_disown_selection_internal, Fx_selection_exists_p)
501 (Fns_get_selection_internal, Fns_store_selection_internal):
502 Use ns_symbol_to_pb and check if return value is nil.
503 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
504 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
505 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
506 renamed to Sns_store_selection_internal.
507 (ns_handle_selection_request): Move code to Fx_own_selection_internal
508 and remove this function.
509 (ns_handle_selection_clear): Remove, never used.
510 (Fx_own_selection_internal): Move code from ns_handle_selection_request
513 2011-12-17 Ken Brown <kbrown@cornell.edu>
515 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
516 GID is unknown (Bug#10257).
518 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
520 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
521 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
522 which caused a build failure on GNU/Linux IA-64. This problem was
523 introduced by my 2011-10-07 patch.
525 2011-12-15 Juri Linkov <juri@jurta.org>
527 * image.c (imagemagick_error): New function. (Bug#10112)
528 (imagemagick_load_image): Comment out `MagickSetResolution' call.
529 Use `imagemagick_error' where ImageMagick functions return
531 (Fimagemagick_types): Add `Fnreverse' to return the list in the
534 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
536 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
537 fill background (Bug#8992).
539 2011-12-13 Martin Rudalics <rudalics@gmx.at>
541 * window.c (Vwindow_combination_resize)
542 (Vwindow_combination_limit): Use t instead of non-nil in
544 (Vrecenter_redisplay): Add first sentence of doc-string on
546 (Frecenter): Fix doc-string typo.
548 2011-12-11 Kenichi Handa <handa@m17n.org>
550 * coding.c (Funencodable_char_position): Pay attention to the
551 buffer text relocation (Bug#9389).
553 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
555 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
556 gtk_init (Bug#10100).
558 2011-12-10 Eli Zaretskii <eliz@gnu.org>
560 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
561 IT->string is nil. (Bug#10263)
563 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
565 * nsterm.h (x_free_frame_resources): Declare.
567 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
568 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
570 * nsterm.h (ns_get_defaults_value): Declare.
572 * nsterm.m (ns_default): Call ns_get_defaults_value.
574 2011-12-09 Eli Zaretskii <eliz@gnu.org>
576 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
579 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
581 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
582 that where the value of an _OBJC_* symbol points to is in the .bss
585 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
587 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
588 after the loop to call ccl_driver at least once (Bug#8619).
590 2011-12-08 Kenichi Handa <handa@m17n.org>
592 * ftfont.c (get_adstyle_property): Fix previous change
595 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
597 * w32.c (init_environment): If no_site_lisp, remove site-lisp
598 dirs from the default value of EMACSLOADPATH (bug#10208).
600 2011-12-07 Glenn Morris <rgm@gnu.org>
602 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
603 installation and source directories as well. (Bug#10208)
605 2011-12-06 Chong Yidong <cyd@gnu.org>
607 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
609 2011-12-06 Glenn Morris <rgm@gnu.org>
611 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
612 as an error, not just -1. (Bug#10217)
614 2011-12-05 Chong Yidong <cyd@gnu.org>
616 * keyboard.c (process_special_events): New function.
617 (swallow_events, Finput_pending_p): Use it (Bug#10195).
619 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
621 * coding.c (encode_designation_at_bol): Don't use uninitialized
622 local variable (Bug#9318).
624 2011-12-05 Kenichi Handa <handa@m17n.org>
626 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
627 return Qnil (Bug#8046, Bug#10193).
629 2011-12-05 Kenichi Handa <handa@m17n.org>
631 * coding.c (encode_designation_at_bol): New args charbuf_end and
632 dst. Return the number of produced bytes. Callers changed.
633 (coding_set_source): Return how many bytes coding->source was
635 (coding_set_destination): Return how many bytes
636 coding->destination was relocated.
637 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
638 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
640 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
642 * coding.c (CODING_CHAR_CHARSET_P): New macro.
643 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
646 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
648 The following changes are to fix Bug#9318.
650 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
651 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
652 (encode_coding_iso_2022, encode_coding_sjis)
653 (encode_coding_big5, encode_coding_charset): Use the above macros.
655 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
657 * lisp.h (process_quit_flag): Fix external declaration.
659 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
661 Don't macro-inline non-performance-critical code.
662 * eval.c (process_quit_flag): New function.
663 * lisp.h (QUIT): Use it.
665 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
667 * nsfns.m (get_geometry_from_preferences): New function.
668 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
670 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
672 * emacs.c (Qkill_emacs): Define.
673 (syms_of_emacs): Initialize it.
674 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
675 Qquit_flag to `kill-emacs' instead.
676 (quit_throw_to_read_char): Add parameter `from_signal'.
677 All callers changed. Call Fkill_emacs if requested and safe.
678 * lisp.h (QUIT): Call Fkill_emacs if requested.
680 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
682 * widget.c (update_wm_hints): Return if wmshell is null.
683 (widget_update_wm_size_hints): New function.
685 * widget.h (widget_update_wm_size_hints): Declare.
687 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
688 widget_update_wm_size_hints (Bug#10104).
690 2011-12-03 Eli Zaretskii <eliz@gnu.org>
692 * xdisp.c (handle_invisible_prop): If the invisible text ends just
693 before a newline, prepare the bidi iterator for consuming the
694 newline, and keep the current paragraph direction. (Bug#10183)
695 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
697 2011-12-02 Juri Linkov <juri@jurta.org>
699 * search.c (Fword_search_regexp): New Lisp function created from
700 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
701 (Fword_search_backward, Fword_search_forward)
702 (Fword_search_backward_lax, Fword_search_forward_lax):
703 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
704 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
706 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
708 * fileio.c (Finsert_file_contents): Move after-change-function call
709 to before the "handled:" label, since all "goto handled" appear in
710 cases where the *-change-functions have already been properly called
713 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
715 * keyboard.c (interrupt_signal): Don't call kill-emacs when
716 waiting for input. (Bug#10169)
718 2011-11-30 Eli Zaretskii <eliz@gnu.org>
720 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
721 verifies glyph row's hash code--we have just reallocated the
722 glyphs, so their contents can be complete garbage. (Bug#10164)
724 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
726 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
728 2011-11-30 Eli Zaretskii <eliz@gnu.org>
730 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
731 attributes are tested _before_ calling verify_row_hash, to protect
732 against GCC re-ordering of the tests. (Bug#10164)
734 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
736 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
738 * xterm.c (handle_one_xevent): Only set async_visible and friends
739 if net_wm_state_hidden_seen is non-zero (Bug#10002)
740 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
741 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
743 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
745 Remove GCPRO-related macros that exist only to avoid shadowing locals.
746 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
747 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
748 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
749 All uses changed to use GCPRO1 etc.
750 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
751 Revert to old implementation (i.e., before 2011-03-11).
753 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
755 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
756 of scroll runs so as to avoid assigning disabled bogus rows and
757 unnecessary graphics copy operations.
759 2011-11-27 Eli Zaretskii <eliz@gnu.org>
761 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
762 (snprintf) [_MSC_VER]: Redirect to _snprintf.
763 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
764 (malloc, free, realloc, calloc): Redirect to e_* only when
767 * lisp.h (GCTYPEBITS): Move before first use.
768 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
769 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
770 this macro definition.
772 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
775 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
777 * gtkutil.c (xg_create_frame_widgets):
778 Call gtk_window_set_has_resize_grip (FALSE) if that function is
779 present with Gtk+ 2.0.
781 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
783 * fileio.c (Finsert_file_contents): Undo previous change; see
784 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
786 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
788 Rename locals to avoid shadowing.
789 * fileio.c (Finsert_file_contents):
790 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
791 * process.c (wait_reading_process_output):
792 Rename inner 'proc' to 'p' to avoid shadowing.
793 Indent for consistency with usual Emacs style.
795 2011-11-25 Eli Zaretskii <eliz@gnu.org>
797 * xdisp.c (redisplay_window): If cursor row is not fully visible
798 after recentering, and scroll-conservatively is set to a large
799 number, scroll window by a few more lines to make the cursor fully
800 visible and out of scroll-margin. (Bug#10105)
801 (start_display): Don't move to the next line if the display should
802 start at a newline that is part of a display vector or an overlay
805 2011-11-24 Juri Linkov <juri@jurta.org>
807 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
808 after the `MagickPingImage' call. (Bug#10112)
810 2011-11-23 Chong Yidong <cyd@gnu.org>
812 * window.c (Fcoordinates_in_window_p): Accept only live windows.
814 2011-11-23 Martin Rudalics <rudalics@gmx.at>
816 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
817 making another buffer current. (Bug#10114)
819 2011-11-23 Glenn Morris <rgm@gnu.org>
821 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
823 2011-11-23 Chong Yidong <cyd@gnu.org>
825 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
828 2011-11-22 Eli Zaretskii <eliz@gnu.org>
830 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
831 and header-lines, as they don't have one computed for them.
834 * .gdbinit (prow): Make displayed values more self-explaining.
837 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
839 * process.c (wait_reading_process_output): Fix asynchrounous
840 GnuTLS socket handling on some versions of the GnuTLS library.
841 (wait_reading_process_output): Add comment and URL.
843 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
845 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
847 2011-11-21 Chong Yidong <cyd@gnu.org>
849 * window.c (Fnext_window, Fprevious_window): Doc fix.
851 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
853 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
855 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
857 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
859 2011-11-20 Martin Rudalics <rudalics@gmx.at>
861 * window.c (Fset_window_combination_limit): Rename argument
863 (Vwindow_combination_limit): Remove "status" from doc-string.
865 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
867 * m/ibms390.h: Remove.
868 * m/ibms390x.h: Don't include "ibms390.h".
870 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
872 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
873 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
875 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
877 * casetab.c (Fset_case_table):
878 * charset.c (Fcharset_after): Fix typos.
880 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
882 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
883 Otherwise, valgrind does not work on some platforms.
884 Problem reported by Andreas Schwab in
885 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
886 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
887 is set, removing the need for VIRT_ADDRESS_VARIES.
888 (PURE_P): Use a more-efficient implementation that needs just one
889 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
890 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
891 to 4 (xorl, subq, cmpq, setbe).
892 * alloc.c (pure): Always extern now, since that's the
893 VIRT_ADDR_VARIES behavior.
894 (PURE_POINTER_P): Use a single comparison, not two, for
895 consistency with the new puresize.h.
896 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
897 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
898 Remove VIRT_ADDR_VARIES no longer needed.
900 2011-11-19 Eli Zaretskii <eliz@gnu.org>
902 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
903 (erase_phys_cursor, update_window_cursor, show_mouse_face)
904 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
905 behave as if the cursor position were at the window margin.
907 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
908 and the cursor position is out of bounds, behave as if the cursor
909 position were at the window margin. (Bug#10075)
911 2011-11-18 Chong Yidong <cyd@gnu.org>
913 * window.c (Fwindow_combination_limit): Make first argument
914 non-optional, since it is meaningless for live windows like the
917 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
919 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
921 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
923 * intervals.c: Fix grafting over the whole buffer (bug#10071).
924 (graft_intervals_into_buffer): Simplify.
926 2011-11-18 Eli Zaretskii <eliz@gnu.org>
928 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
929 hash values of the two rows.
930 (copy_row_except_pointers): Preserve the used[] arrays and the
931 hash values of the two rows. (Bug#10035)
932 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
934 * xdisp.c (row_hash): New function, body extracted from
935 compute_line_metrics.
936 (compute_line_metrics): Call row_hash, instead of computing the
939 * dispnew.c (verify_row_hash): Call row_hash for computing the
940 hash code of a row, instead of duplicating code from xdisp.c.
942 * dispextern.h (row_hash): Add prototype.
944 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
946 * frame.c (delete_frame): Don't delete the terminal when the last
947 X frame is closed if emacs is built with GTK toolkit.
949 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
951 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
953 2011-11-17 Martin Rudalics <rudalics@gmx.at>
955 * window.c (Vwindow_splits): Rename to
956 Vwindow_combination_resize. Suggested by Juri Linkov.
957 (Fsplit_window_internal): Use Vwindow_combination_resize instead
960 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
962 * nsfns.m (Fns_font_name):
963 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
965 2011-11-16 Martin Rudalics <rudalics@gmx.at>
967 * window.h (window): Rename slot "nest" to "combination_limit".
968 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
969 (Fset_window_nest): Rename to Fset_window_combination_limit.
970 (Vwindow_nest): Rename to Vwindow_combination_limit.
971 (recombine_windows, make_parent_window, make_window)
972 (Fsplit_window_internal, saved_window)
973 (Fset_window_configuration, save_window_save): Rename all
974 occurrences of window_nest to window_combination_limit.
976 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
978 * image.c (imagemagick_load_image): Fix typo.
980 2011-11-14 Eli Zaretskii <eliz@gnu.org>
982 * xdisp.c (display_line): Move the call to
983 highlight_trailing_whitespace before the call to
984 compute_line_metrics, since the latter needs to see the final
985 faces of all the glyphs to compute ROW's hash value.
986 Fixes assertion violations in row_equal_p. (Bug#10035)
988 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
990 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
991 just return (bug#10044).
993 2011-11-12 Eli Zaretskii <eliz@gnu.org>
995 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
996 with user-defined heap size. Bump the default size of the temacs
997 heap to 27MB, to avoid memory warning when running temacs.
998 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1000 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1001 current_matrix and desired_matrix. (Bug#9990)
1002 (verify_row_hash) [XASSERTS]: New function.
1003 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1004 that the hash value of glyph rows is correct.
1006 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1008 * window.h (window): Remove splits slot.
1009 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1010 (Fdelete_other_windows_internal, make_parent_window)
1011 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1012 (Fset_window_configuration, save_window_save): Don't deal with
1013 split status of windows.
1014 (saved_window): Remove splits slot.
1015 (Vwindow_splits): Rewrite doc-string.
1017 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1019 * xfns.c (unwind_create_frame):
1020 * nsfns.m (unwind_create_frame):
1021 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1022 Vframe_list (Bug#9999).
1024 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1026 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1028 2011-11-11 Kenichi Handa <handa@m17n.org>
1030 * callproc.c (Fcall_process): Set the member dst_multibyte of
1033 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1035 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1036 avoid a crash (bug#9496).
1038 2011-11-09 Chong Yidong <cyd@gnu.org>
1040 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1041 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1043 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1045 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1047 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1049 Avoid some portability problems by eschewing 'extern inline' functions.
1050 The trivial performance wins aren't worth the portability hassles; see
1051 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1053 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1054 (window_box_width, window_box_left, window_box_left_offset)
1055 (window_box_right, window_box_right_offset): Undo previous change,
1056 by removing the "extern"s.
1057 * intervals.c (adjust_intervals_for_insertion)
1058 (adjust_intervals_for_deletion): Undo previous change,
1059 making these static again.
1060 (offset_intervals, temp_set_point_both, temp_set_point)
1061 (copy_intervals_to_string): No longer inline.
1062 * xdisp.c (window_text_bottom_y, window_box_width)
1063 (window_box_height, window_box_left_offset)
1064 (window_box_right_offset, window_box_left, window_box_right)
1065 (window_box): No longer inline.
1067 2011-11-08 Chong Yidong <cyd@gnu.org>
1069 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1070 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1071 Signal an error if not a live window.
1072 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1073 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1075 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1077 * lisp.h (syms_of_abbrev): Remove declaration.
1078 Reported by CHENG Gao <chenggao@royau.me>.
1080 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1082 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1083 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1084 of temacs in GUI mode.
1086 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1088 * window.h: Declare delete_all_child_windows instead of
1089 delete_all_subwindows.
1090 * window.c (Fwindow_nest, Fset_window_nest)
1091 (Fset_window_new_total, Fset_window_new_normal)
1092 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1093 (delete_all_subwindows): Rename to delete_all_child_windows.
1094 (Fdelete_other_windows_internal, Fset_window_configuration):
1095 Call delete_all_child_windows instead of delete_all_subwindows.
1096 * frame.c (delete_frame): Call delete_all_child_windows instead
1097 of delete_all_subwindows.
1099 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1101 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1102 This is also needed for porting to any host where GC_MARK_STACK is
1103 not GC_MAKE_GCPROS_NOOPS.
1104 (which_symbols): Use it.
1106 2011-11-07 Kenichi Handa <handa@m17n.org>
1108 * coding.c (coding_set_destination): Check coding->src_pos only
1109 when coding->src_object is a buffer (bug#9910).
1111 * process.c (send_process): Set the member src_multibyte of coding
1112 to 0 (bug#9911) when sending a unibyte text.
1114 * callproc.c (Fcall_process): Set the member src_multibyte of
1115 process_coding to 0 (bug#9912).
1117 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1119 * xmenu.c (cleanup_widget_value_tree): New function.
1120 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1121 calling free_menubar_widget_value_tree directly (Bug#9830).
1123 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1125 Fix some portability problems with 'inline'.
1126 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1127 (window_box_width, window_box_left, window_box_left_offset)
1128 (window_box_right, window_box_right_offset): Declare extern.
1129 Otherwise, these inline functions do not conform to C99 and
1130 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1131 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1132 * intervals.c (adjust_intervals_for_insertion)
1133 (adjust_intervals_for_deletion): Now extern, because otherwise the
1134 extern inline functions 'offset_intervals' couldn't refer to it.
1135 (static_offset_intervals): Remove.
1136 (offset_intervals): Rewrite using the old contents of
1137 static_offset_intervals. The old version didn't conform to C99
1138 because an extern inline function contained a reference to an
1139 identifier with static linkage.
1141 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1143 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1146 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1148 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1149 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1150 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1151 return Qleft_to_right.
1153 2011-11-06 Chong Yidong <cyd@gnu.org>
1155 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1156 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1157 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1158 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1159 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1160 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1161 (Fwindow_vscroll): Doc fix.
1162 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1163 argument, since it makes no sense to pass a live window and for
1164 consistency with window-child.
1166 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1168 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1171 2011-11-05 Jason Rumney <jasonr@gnu.org>
1173 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1174 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1176 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1177 bitwise arithmetic preventing use of unicode-sip and non-truetype
1180 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1182 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1185 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1186 initialization code to keep similarity to xfns.c after changes
1189 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1191 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1192 (unwind_create_frame): New function (Bug#9943).
1193 (Fx_create_frame): Restructure code to be more similar to the one in
1194 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1195 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1196 Move terminal->reference_count++ just before making the frame official
1199 * nsterm.m (x_free_frame_resources): New function.
1200 (x_destroy_window): Move code to x_free_frame_resources.
1202 * xfns.c (unwind_create_frame): Fix comment.
1203 (Fx_create_frame, x_create_tip_frame):
1204 Move terminal->reference_count++ just before making the frame
1205 official. Move initialization of image_cache_refcount and
1206 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1208 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1210 Support MSVC build with newer versions of Visual Studio.
1211 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1212 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1215 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1216 which are not supported by MSVC.
1217 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1218 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1220 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1222 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1224 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1226 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1228 Support MSVC build with newer versions of Visual Studio.
1229 * w32.c: Don't include w32api.h for MSVC.
1230 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1232 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1233 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1234 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1235 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1237 (alloca) [_MSC_VER]: Define to _alloca.
1239 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1241 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1243 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1245 * xdisp.c (note_mouse_highlight): If either of
1246 previous/next-single-property-change returns nil, treat that as
1247 the beginning or the end of the buffer. (Bug#9955)
1249 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1251 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1252 label is not null (Bug#9951).
1253 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1256 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1258 * window.c (Fwindow_body_size): Mention in the doc string that the
1259 return value is in frame's canonical units. (Bug#9949)
1261 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1263 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1265 * w32fns.c (unwind_create_frame): If needed, free the glyph
1266 matrices of the partially constructed frame. (Bug#9943)
1267 * xfns.c (unwind_create_frame): Likewise.
1269 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1271 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1272 Don't stop backward scan on the continuation glyph, even though
1273 its CHARPOS is positive.
1274 (mouse_face_from_buffer_pos, note_mouse_highlight):
1275 Rename cover_string to disp_string.
1277 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1279 * window.c (temp_output_buffer_show): Don't use
1280 Vtemp_buffer_show_specifiers.
1281 (Vtemp_buffer_show_specifiers): Remove unused variable.
1283 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1285 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1286 past the beginning of the current glyph matrix.
1288 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1290 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1291 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1292 HAVE_GTK3 (Bug#9869).
1294 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1295 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1297 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1299 * xterm.c: Declare x_handle_net_wm_state to return int.
1300 (handle_one_xevent): Check if we are iconified but don't have
1301 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1302 (get_current_wm_state): Return non-zero if not hidden,
1303 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1304 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1305 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1306 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1308 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1310 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1311 so that this new function doesn't get optimized away by a
1312 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1314 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1316 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1318 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1320 Fix the `xbytecode' command.
1321 * .gdbinit (xprintbytestr): New command.
1322 (xwhichsymbols): Rename from `which'; all callers changed.
1323 (xbytecode): Print the byte-code string as well.
1325 2011-10-29 Kim Storm <storm@cua.dk>
1327 * alloc.c (which_symbols): New function.
1329 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1331 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1334 2011-10-29 Glenn Morris <rgm@gnu.org>
1336 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1337 Not clear what it was for, and it causes various bugs. (Bug#9839)
1339 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1341 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1342 possible random value that matches one of those tested as
1343 condition to clear the mouse face.
1345 2011-10-28 Chong Yidong <cyd@gnu.org>
1347 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1349 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1351 * window.c (make_window): Initialize phys_cursor_on_p.
1353 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1355 * lisp.h (struct Lisp_Symbol): Update comments.
1357 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1359 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1361 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1363 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1364 <oslsachem@gmail.com> for helping to debug this.
1366 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1367 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1368 (g_b_init_get_glyph_outline_w): New static variables.
1369 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1370 (GetGlyphOutlineW_Proc): New typedefs.
1371 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1372 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1374 (w32font_open_internal, compute_metrics):
1375 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1376 instead of calling the "wide" APIs directly.
1378 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1380 * w32.h (syms_of_w32font): Add prototype.
1382 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1384 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1385 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1386 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1387 (Fmove_to_window_line): Doc fix.
1389 2011-10-27 Chong Yidong <cyd@gnu.org>
1391 * process.c (make_process): Set gnutls_state to NULL.
1393 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1394 non-NULL, regardless of GNUTLS_INITSTAGE.
1395 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1396 an error. Set process slots as soon as we allocate them.
1398 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1400 2011-10-27 Chong Yidong <cyd@gnu.org>
1402 * gnutls.c (emacs_gnutls_deinit): New function.
1403 Deallocate credentials structures as well as calling gnutls_deinit.
1404 (Fgnutls_deinit, Fgnutls_boot): Use it.
1406 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1407 (deactivate_process): Call emacs_gnutls_deinit.
1409 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1411 * image.c (x_create_x_image_and_pixmap):
1412 * w32.c (sys_rename, w32_delayed_load):
1413 * w32font.c (fill_in_logfont):
1414 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1416 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1418 * w32fns.c (w32_default_color_map): New function,
1419 extracted from Fw32_default_color_map.
1420 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1422 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1424 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1426 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1428 * keyboard.c (test_undefined): New function (bug#9751).
1429 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1431 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1433 * sysdep.c (init_sys_modes): Fix the check for the controlling
1434 terminal (Bug#6649).
1436 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1438 * dispextern.h (struct bidi_it): New member next_en_type.
1440 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1441 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1442 current character, check also for next_en_type being WEAK_EN.
1443 (bidi_resolve_weak): Don't enter the expensive loop if the current
1444 position is before next_en_pos. Record the bidi type of the first
1445 non-ET, non-BN character we find, in addition to its position.
1446 (bidi_level_of_next_char): Invalidate next_en_type when
1447 next_en_pos is over-stepped.
1449 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1451 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1452 * editfns.c: Rewrite current-time-zone so that it invokes
1453 the equivalent of (format-time-string "%Z") to get the time zone name.
1454 This fixes a bug when the time zone name contains characters that
1455 need converting from the system time locale to Emacs internal format.
1456 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1457 that patch fixed format-time-string to do the conversion, but
1458 I forgot to fix current-time-zone.
1459 (format_time_string): New function, containing most of
1460 what Fformat_time_string used to contain.
1461 (Fformat_time_string): Rewrite in terms of format_time_string.
1462 This doesn't change this function's behavior.
1463 (current-time-zone): Rewrite to use format_time_string.
1464 This fixes the bug reported by Michael Schierl in
1465 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1466 Jason Rumney's 2007-06-07 change worked around this bug, but
1468 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1470 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1472 * xdisp.c (start_display): If the character at POS is displayed
1473 via a display vector, reset IT->current.dpvec_index to zero.
1474 (try_window_reusing_current_matrix): If a line ends in a display
1475 vector or the next line starts in a display vector, continue
1476 redrawing the window even though the character position of
1477 start_row was reached.
1480 2011-10-18 Chong Yidong <cyd@gnu.org>
1482 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1483 with nobreak-char-display too.
1485 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1487 Fix part 3 of bug#9771.
1488 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1489 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1490 non-neutral characters if the current character is a paragraph
1491 separator (a.k.a. Newline). This avoids running the same
1492 expensive loop twice, once when we consume the preceding newline
1493 and the other time when the line actually needs to be displayed.
1494 Avoid the loop when we see neutrals on the base embedding level
1495 following a character whose directionality is the same as the
1496 paragraph's. This avoids running the expensive loop when a line
1497 ends in a long sequence of neutrals, like control characters.
1498 Add assertion against STRONG_AL type. Slightly rearrange code
1499 that determines the type of a neutral given the first non-neutral
1501 (bidi_level_of_next_char): Set next_en_pos to zero when
1502 invalidating its info.
1504 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1506 * xdisp.c (push_display_prop): Determine whether to record string
1507 or buffer position by IT->string, not by IT->method. Allow
1508 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1509 (move_it_vertically_backward): Don't look for character position
1510 immediately after the newline when in a continuation line.
1513 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1515 * window.c (coordinates_in_window): Rewrite and delabelize
1516 vertical border check. (Bug#5357) (Bug#9618)
1518 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1520 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1521 errors in XSetWindowBorder (bug#9310).
1523 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1525 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1526 avoid crash when xmalloc overrun checking is enabled.
1528 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1530 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1531 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1532 cursor motion with <left> and <right> arrow keys.
1534 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1535 some callers set that themselves.
1537 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1539 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1540 display string and the previous row comes from the same string and
1541 is empty. (Bug#9739) (Bug#9738)
1543 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1545 * doc.c (get_doc_string): Encode file name (bug#9735).
1547 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1549 * bidi.c (bidi_level_of_next_char):
1550 * xdisp.c (get_visually_first_element): Remove old incorrect
1551 comments regarding the Unicode Line Separator character.
1553 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1555 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1557 * alloc.c (Fgc_status): Do not access beyond zombies array
1558 boundary if nzombies > MAX_ZOMBIES.
1559 * alloc.c (dump_zombies): Add missing format specifier.
1561 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1563 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1564 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1566 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1567 Some packages use them to denote characters with modifiers.
1569 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1571 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1572 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1573 matching a pp-number. Rename parameter var to var1.
1575 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1577 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1579 2011-10-08 Glenn Morris <rgm@gnu.org>
1581 * callint.c (Fcall_interactively): Give a more explicit error for the
1582 'c' case with a non-character input. (Bug#8479)
1584 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1586 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1588 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1589 lines that are hscrolled on the left.
1591 * dispnew.c (buffer_posn_from_coords): Account for a possible
1592 presence of header-line. (Bug#4426)
1594 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1596 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1597 Don't advertise functionality which we discourage or doesn't work.
1599 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1601 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1602 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1603 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1604 this makes Emacs dump core during garbage collection on rare
1605 occasions. sizeof is obviously inferior to offsetof here, so
1606 stick with offsetof.
1607 (GC_POINTER_ALIGNMENT): New macro.
1608 (mark_memory): Omit 3rd (offset) arg; caller changed.
1609 Don't assume EMACS_INT alignment is the same as pointer alignment.
1611 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1613 * keyboard.c (read_key_sequence_remapped): New var.
1614 (read_key_sequence): Compute remapping in the right buffer.
1615 (command_loop_1): Use read_key_sequence's remapping directly.
1617 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1619 * dired.c (file_name_completion): Don't expand file name.
1620 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1621 before checking file name handler.
1623 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1624 they've been requested explicitly (bug#9591).
1626 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1628 * keymap.c (Fsingle_key_description): Use make_specified_string
1629 instead of build_string to build string from push_key_description.
1632 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1634 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1635 This fixes a Y2038 bug on 64-bit hosts.
1636 * buffer.c (reset_buffer):
1637 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1638 (Fclear_buffer_auto_save_failure):
1639 Use 0, not -1, to represent an unset failure time, since time_t
1640 might not be signed.
1642 Remove dependency on glibc malloc internals.
1643 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1644 Move back here from lisp.h, but with their new implementations.
1645 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1646 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1647 * charset.c (charset_table_init): New static var.
1648 (syms_of_charset): Use it instead of xmalloc. This removes a
1649 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1650 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1651 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1652 Move back to alloc.c.
1653 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1654 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1656 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1658 * nsterm.m (windowDidResize): Call x_set_window_size only when
1659 ns_in_resize is true. Otherwise set pixelwidth/height and
1660 call change_frame_size (Bug#9628).
1662 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1664 Port --enable-checking=all to Fedora 14 x86-64.
1665 * charset.c (syms_of_charset): Also account for glibc malloc's
1666 internal overhead when calculating the initial malloc maximum.
1668 Port --enable-checking=all to Fedora 14 x86.
1669 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1671 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1672 (overrun_check_realloc, overrun_check_free):
1673 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1674 That way, xmalloc returns a properly-aligned pointer even if
1675 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1676 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1677 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1678 into account when calculating the initial malloc maximum.
1679 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1680 Move here from alloc.c, so that charset.c can use it too.
1681 Properly align; the old code wasn't right for common 32-bit hosts
1682 when configured with --enable-checking=all.
1683 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1684 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1686 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1688 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1691 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1693 * xdisp.c (compute_display_string_end): If there's no display
1694 string at CHARPOS, return -1.
1696 * bidi.c (bidi_fetch_char): When compute_display_string_end
1697 returns a negative value, treat the character as a normal
1698 character not covered by a display string. (Bug#9624)
1700 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1702 * lread.c (Fread_from_string): Fix typo in docstring.
1704 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1706 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1707 newline, reseat the iterator instead of bidi-iterating there one
1708 character at a time. (Bug#9610)
1709 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1710 TO_CHARPOS if the bidi iterator is at base embedding level.
1712 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1714 * lread.c (readevalloop): Use correct code for NBSP.
1715 (read1): Likewise. (Bug#9608)
1717 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1719 * dbusbind.c (Fdbus_register_signal): When service is not
1720 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1722 2011-09-25 Glenn Morris <rgm@gnu.org>
1724 * buffer.c (truncate-lines): Doc fix.
1726 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1728 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1729 (Fset_window_next_buffers): Doc fix.
1731 2011-09-24 Glenn Morris <rgm@gnu.org>
1733 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1735 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1737 Fix minor problems found by static checking.
1738 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1739 * indent.c (Fvertical_motion): Fix == vs = typo.
1741 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1743 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1744 Default value is now t. Doc fix.
1746 * indent.c (Fvertical_motion): Compute and apply the overshoot
1747 logic when moving up, not only when moving down. Fix the
1748 confusing name and values of the it_overshoot_expected variable;
1749 logic changes accordingly. (Bug#9254) (Bug#9549)
1751 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1752 CHARPOS is covered by a display string which includes newlines.
1753 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1754 is covered by a display string with embedded newlines.
1756 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1758 * dbusbind.c (Fdbus_register_signal): Add match rule to
1759 Vdbus_registered_objects_table. (Bug#9581)
1760 (Fdbus_register_method, Vdbus_registered_objects_table):
1763 2011-09-24 Jim Meyering <meyering@redhat.com>
1765 do not ignore write error for any output size
1766 The previous change was incomplete.
1767 While it makes emacs --batch detect the vast majority of stdout
1768 write failures, errors were still ignored whenever the output size is
1769 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1770 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1771 && echo FAIL: ignored write error
1772 FAIL: ignored write error
1773 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1774 && echo FAIL: ignored write error
1775 FAIL: ignored write error
1776 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1778 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1780 * emacs.c (Fkill_emacs): In noninteractive mode exit
1781 non-successfully if a write error occurred on stdout. (Bug#9574)
1783 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1785 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1788 * dispextern.h (struct it): Update the comment documenting what
1791 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1793 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1794 a display string, extend search for cursor position to end of row.
1795 (find_row_edges): If the row ends in a newline from a display
1796 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1797 Handle the case of a display string with multiple newlines.
1798 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1799 non-empty line. Fixes confusing cursor motion with arrow keys at
1800 the beginning of a line that starts with whitespace.
1802 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1804 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1807 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1809 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1812 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1814 * xdisp.c (display_line): Record maximum and minimum buffer
1815 positions even if no glyphs were produced (e.g., by a zero-width
1816 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1817 buffer positions that will be removed from the glyph row because
1819 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1820 column is beyond frame width: don't subtract 1 "pixel" when
1821 computing width of the stretch.
1822 (reseat_at_next_visible_line_start): Undo the change made on
1823 2011-09-17 that saved paragraph information and restored it after
1824 the call to `reseat'. (Bug#9545)
1826 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1828 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1829 and turn window cursor on if cleared (Bug#9415).
1831 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1833 * search.c (boyer_moore): Take unibyte characters from pattern
1834 literally. (Bug#9458)
1836 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1838 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1840 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1842 Fix minor problem found by static checking.
1843 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1844 initialized, to pacify gcc -Wuninitialized.
1846 * fileio.c: Report proper errno when syscall falls.
1847 (Finsert_file_contents): Save and restore errno,
1848 so that report_file_error outputs the correct diagnostic.
1849 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1851 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1853 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1855 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1857 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1858 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1860 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1862 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1863 about the current paragraph and restore it after the call to reseat.
1865 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1866 (bidi_find_paragraph_start): Search back for paragraph beginning
1867 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1868 (bidi_move_to_visually_next): Only trigger paragraph-related
1869 computations when the last character is a newline or at EOB, not
1870 just any NEUTRAL_B. (Bug#9470)
1872 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1873 truncated lines if point is covered by a display string. (Bug#9524)
1875 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1877 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1878 (cons_to_x_long): New function.
1879 (lisp_data_to_selection_data): Use it. Correct the test for
1880 short-versus-long data; it was negated. Break out of vector
1881 loop, for efficiency, when a long datum is discovered.
1883 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1885 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1887 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1889 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1890 GCC PR/17406) by declaring this function with external scope.
1892 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1894 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1895 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1897 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1899 * editfns.c (Fformat): Correctly handle text properties on "%%".
1901 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1903 * xterm.c (x_draw_composite_glyph_string_foreground):
1904 * w32term.c (x_draw_composite_glyph_string_foreground):
1905 * term.c (encode_terminal_code):
1906 * composite.c (composition_update_it, get_composition_id):
1907 * xdisp.c (get_next_display_element)
1908 (fill_composite_glyph_string): Add comments about special meaning
1909 of TAB characters in a composition.
1911 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1913 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1914 This occurs when processing a multibyte format.
1915 Problem reported by Wolfgang Jenker.
1917 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1919 * xdisp.c (try_cursor_movement): Only check for exact match if
1920 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1922 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1924 Remove unused external symbols.
1925 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1926 * xdisp.c (calc_pixel_width_or_height): Now static.
1927 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1928 * indent.c (check_display_width):
1929 * w32term.c: Fix comment to match code.
1930 * xterm.c, xterm.h (x_catching_errors): Remove.
1932 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1934 * xselect.c: Use signed conversions more consistently (Bug#9498).
1935 (selection_data_to_lisp_data): Assume incoming selection data are
1936 signed integers, not unsigned. This is to be consistent with
1937 outgoing selection data, which was modified to use signed integers
1938 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1939 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1940 expects long, not unsigned long.
1942 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1944 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1945 computation of loop end. Reported by Johan Bockgård
1948 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1950 * frame.c (Fother_visible_frames_p): Function deleted.
1952 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1954 * indent.c (compute_motion): Process display vector front to back
1955 rather than the other way around. (Bug#2496)
1957 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1959 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1961 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1963 * minibuf.c (Fread_from_minibuffer): Doc fix.
1965 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1967 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1968 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1970 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1972 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1973 value for non-existent files.
1975 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1977 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1978 set its "size" to -1. This will set the modtime_size field of
1979 the corresponding buffer to -1, which is what
1980 verify-visited-file-modtime expects for files that do not exist.
1983 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1985 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1987 * lisp.h: ... from here. push_key_description is no longer
1988 defined in keyboard.c, so its declaration should not be in
1989 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1990 logically belongs with push_key_description.
1992 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1994 * buffer.h: Include <sys/types.h> instead of <time.h>.
1995 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1996 Problem reported by Herbert J. Skuhra.
1998 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2000 * xml.c (parse_region): Make the parsing work for
2001 non-comment-starting XML files again (bug#9144).
2003 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2005 * image.c (gif_load): Fix calculation of bottom and right corner.
2008 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2010 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2011 redisplay in small windows.
2013 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2015 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2017 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2019 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2020 Operate on live windows only.
2022 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2024 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2026 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2028 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2029 only under bidi iteration.
2031 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2033 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2035 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2037 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2038 Without this fix, the command to link temacs failed due to an
2039 undefined symbol __builtin_isnan. This is because
2040 /usr/include/iso/math_c99.h #defines isnan(x) to
2041 __builtin_isnan(x), but the bundled gcc, which identifies itself
2042 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2044 * floatfns.c (isnan): #undef, and then #define to a clone of
2046 (Fisnan): Always define, since it's always available now.
2047 (syms_of_floatfns): Always define isnan at the Lisp level.
2049 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2051 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2053 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2055 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2056 The previous code assumed that file offsets (off_t values) fit in
2057 EMACS_INT variables, which is not true on typical 32-bit hosts.
2058 The code messed up by falsely reporting buffer overflow in cases
2059 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2060 when "big" contains more than 2**29 bytes, even though this
2061 inserts just one byte and does not overflow the buffer.
2062 (Finsert_file_contents): Store file offsets as off_t
2063 values, not as EMACS_INT values. Check for overflow when
2064 converting between EMACS_INT and off_t. When checking for
2065 buffer overflow or for overlap, take the offsets into account.
2066 Don't use EMACS_INT for small values where int suffices.
2067 When checking for overlap, fix a typo: ZV was used where
2068 ZV_BYTE was intended.
2069 (Fwrite_region): Don't assume off_t fits into 'long'.
2070 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2072 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2074 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2076 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2078 sprintf-related integer and memory overflow issues (Bug#9412).
2080 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2081 (esprintf, exprintf, evxprintf): New functions.
2082 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2083 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2084 (modify_event_symbol): Do not assume that the length of
2085 name_alist_or_stem is safe to alloca and fits in int.
2086 (Fexecute_extended_command): Likewise for function name and binding.
2087 (Frecursion_depth): Wrap around reliably on integer overflow.
2088 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2089 since some callers pass EMACS_INT values.
2090 (Fsingle_key_description): Don't crash if symbol name contains more
2091 than MAX_ALLOCA bytes.
2092 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2093 (get_minibuffer): Arg is now EMACS_INT, not int.
2094 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2095 (esprintf, exprintf, evxprintf): New decls.
2096 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2098 * dbusbind.c (signature_cat): New function.
2099 (xd_signature, Fdbus_register_signal):
2100 Do not overrun buffer; instead, report string overflow.
2102 * dispnew.c (add_window_display_history): Don't overrun buffer.
2103 Truncate instead; this is OK since it's just a log.
2105 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2106 even if the time zone offset is outlandishly large.
2107 Don't mishandle offset == INT_MIN.
2109 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2110 when creating daemon; the previous buffer-overflow check was incorrect.
2112 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2113 which has the guts of the old verror function.
2115 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2116 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2118 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2119 (font_unparse_xlfd): Don't blindly alloca long strings.
2120 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2121 fits in int, when using sprintf. Use single snprintf to count
2122 length of string rather than counting it via multiple sprintfs;
2123 that's simpler and more reliable.
2124 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2125 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2126 sprintf, in case result does not fit in int.
2128 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2129 (fontset_from_font): Print it.
2131 * frame.c (tty_frame_count): Now printmax_t, not int.
2132 (make_terminal_frame, set_term_frame_name): Print it.
2133 (x_report_frame_params): In X, window IDs are unsigned long,
2134 not signed long, so print them as unsigned.
2135 (validate_x_resource_name): Check for implausibly long names,
2136 and don't assume name length fits in 'int'.
2137 (x_get_resource_string): Don't blindly alloca invocation name;
2138 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2141 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2142 (xg_check_special_colors, xg_set_geometry):
2143 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2145 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2146 Use esprintf, not sprintf, in case result does not fit in int.
2148 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2149 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2150 it as a large positive number.
2151 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2152 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2154 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2155 in case result does not fit in int.
2157 * print.c (float_to_string): Detect width overflow more reliably.
2158 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2159 buffer overrun. Don't assume list length fits in 'int'. Treat
2160 print length of 0 as 0, not as infinity; to be consistent with other
2161 uses of print length in this function. Don't overflow print length
2162 index. Don't assume hash table size fits in 'long', or that
2163 vectorlike size fits in 'unsigned long'.
2165 * process.c (make_process): Use printmax_t, not int, to format
2166 process-name gensyms.
2168 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2170 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2171 to avoid potential buffer overrun.
2173 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2174 if X resource line is longer than 512 bytes.
2176 * xfns.c (x_window): Make sprintf buffer a bit bigger
2177 to avoid potential buffer overrun.
2179 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2181 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2183 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2185 Integer overflow fixes for scrolling, etc.
2186 Without these, Emacs silently mishandles large integers sometimes.
2187 For example, "C-u 4294967297 M-x recenter" was treated as if
2188 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2190 * xdisp.c (try_window_id): Check Emacs fixnum range before
2191 converting to 'int'.
2193 * window.c (window_scroll_line_based, Frecenter):
2194 Check that an Emacs fixnum is in range before assigning it to 'int'.
2195 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2196 values converted from Emacs fixnums.
2197 (Frecenter): Don't wrap around a line count if it is out of 'int'
2198 range; instead, treat it as an extreme value.
2199 (Fset_window_configuration, compare_window_configurations):
2200 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2202 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2203 that can exceed INT_MAX. Check that EMACS_INT value is in range
2204 before assigning it to the (possibly-narrower) index.
2205 (match_limit): Don't assume that a fixnum can fit in 'int'.
2207 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2210 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2211 (Fvertical_motion): Don't wrap around LINES values that don't fit
2212 in 'int'. Instead, treat them as extreme values. This is good
2213 enough for windows, which can't have more than INT_MAX lines anyway.
2215 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2217 * Require libxml/parser.h to avoid compilation warning.
2219 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2221 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2222 since this reportedly can destroy thread storage.
2224 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2226 * syntax.c (find_defun_start): Update all cache variables if
2227 exiting early (Bug#9401).
2229 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2231 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2233 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2234 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2235 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2237 * term.c (tty_append_glyph): New function.
2238 (produce_stretch_glyph): Static function and its prototype deleted.
2240 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2243 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2245 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2246 when checking :margin (Bug#9390).
2247 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2248 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2249 so that the name doesn't mislead. All uses changed.
2251 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2253 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2256 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2258 * xdisp.c (move_it_to): Don't bail out early when reaching
2259 position beyond to_charpos, if we are scanning backwards.
2260 (move_it_vertically_backward): When DY == 0, make sure we get to
2261 the first character in the line after the newline.
2263 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2265 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2266 (ccl_driver): Do not generate an out-of-range pointer.
2267 (Fccl_execute_on_string): Remove unnecessary check for
2268 integer overflow, noted by Stefan Monnier in
2269 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2270 Remove a FIXME that didn't need fixing.
2271 Simplify the newly-introduced buffer reallocation code.
2273 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2275 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2277 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2279 Integer and memory overflow issues (Bug#9196).
2281 * doc.c (get_doc_string): Rework so that
2282 get_doc_string_buffer_size is the actual buffer size, rather than
2283 being 1 less than the actual buffer size; this makes xpalloc more
2286 * image.c (x_allocate_bitmap_record, cache_image):
2287 * xselect.c (Fx_register_dnd_atom):
2288 Simplify previous changes by using xpalloc.
2290 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2291 since either will do and ptrdiff_t is convenient with xpalloc.
2293 * charset.c (charset_table_size)
2294 (struct charset_sort_data.priority): Now ptrdiff_t.
2295 (charset_compare): Don't overflow if priorities differ greatly.
2296 (Fsort_charsets): Don't assume list length fits in int.
2297 Check for size-calculation overflow when allocating sort data.
2298 (syms_of_charset): Allocate an initial charset table that is
2299 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2301 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2303 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2304 The actual value is always <= INT_MAX, and leaving it unsigned made
2305 overflow checking harder.
2307 * dispextern.h (struct glyph_matrix.rows_allocated)
2308 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2309 with xpalloc. The values are still always <= INT_MAX.
2311 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2313 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2314 (SAFE_NALLOCA): New macro.
2316 * region-cache.c (struct boundary.pos, find_cache_boundary)
2317 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2318 (set_cache_region, invalidate_region_cache)
2319 (revalidate_region_cache, know_region_cache, region_cache_forward)
2320 (region_cache_backward, pp_cache):
2321 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2322 so that ptrdiff_t * can be passed to xpalloc.
2323 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2324 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2325 (pp_cache): Don't assume cache_len fits in int.
2326 * region-cache.h: Adjust extern decls to match.
2328 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2329 EMACS_INT, since either will do, for xpalloc.
2331 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2332 (xnmalloc, xnrealloc, xpalloc): New functions.
2334 * bidi.c (bidi_shelve_header_size): New constant.
2335 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2336 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2338 * bidi.c (bidi_cache_shrink):
2339 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2341 Don't update size of array until after memory allocation succeeds,
2342 because xmalloc/xrealloc may not return.
2343 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2344 now that we have proper integer overflow checking.
2345 (record_overlay_string, overlay_strings): Catch overflows when
2346 calculating size of overlay_str_buf.
2348 * callproc.c (Fcall_process): Check for size overflow when
2349 calculating size of args2.
2350 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2351 Normally we prefer signed values, but sticking with ptrdiff_t would
2352 require adding more-complicated checks.
2354 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2355 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2356 Redo buffer-overflow calculations to avoid integer overflow.
2357 Add a FIXME comment where memory seems to be over-allocated.
2359 * character.c (Fstring): Check for size-calculation overflow.
2361 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2362 unnecessary integer overflow. Check for size overflow.
2363 (encode_coding_object): Don't update size until xmalloc succeeds.
2365 * composite.c (get_composition_id): Check for overflow in glyph
2366 length calculations.
2368 Integer and memory overflow fixes for display code.
2369 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2370 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2371 (scrolling_window): Check for overflow in size calculations.
2372 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2373 Don't assume glyph table len fits in int.
2374 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2375 (row_table_size): Now ptrdiff_t, not int.
2376 (scrolling_window): Avoid overflow in size calculations.
2377 Don't update size until allocation succeeds.
2378 * fns.c (concat): Check for overflow in size calculations.
2379 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2380 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2381 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2383 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2384 (get_doc_string): Check for size calculation overflow.
2385 Don't update size until allocation succeeds.
2386 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2387 EMACS_INT, where ptrdiff_t will do.
2388 (Fsubstitute_command_keys): Check for string overflow.
2390 * editfns.c (set_time_zone_rule): Don't assume environment length
2392 (message_length): Now ptrdiff_t, not int.
2393 (Fmessage_box): Don't update size until allocation succeeds.
2394 Don't assume message length fits in int.
2395 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2397 * emacs.c (main): Do not reallocate argv, since there is a null at
2398 the end that can be overwritten, and this way there's no need to
2399 worry about size-calculation overflow.
2400 (sort_args): Check for size-calculation overflow.
2402 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2404 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2406 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2407 (x_set_scroll_bar_width, x_figure_window_size):
2408 Check for integer overflow.
2409 (x_set_alpha): Do not assume XINT fits in int.
2411 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2412 This is for the members text_lines, text_cols, total_lines, total_cols,
2413 where the system imposes an 'int' limit.
2415 * fringe.c (Fdefine_fringe_bitmap):
2416 Don't update size until alloc works.
2418 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2419 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2421 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2422 Check for size-calculation overflow.
2423 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2424 do, as we prefer signed integers.
2425 (id_to_widget.max_size, id_to_widget.used)
2426 (xg_store_widget_in_map, xg_remove_widget_from_map)
2427 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2428 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2429 Use and return ptrdiff_t, not int.
2430 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2431 * gtkutil.h: Change prototypes to match the above.
2433 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2434 are duplicate now that they've been promoted to lisp.h.
2435 (x_allocate_bitmap_record, x_alloc_image_color)
2436 (make_image_cache, cache_image, xpm_load):
2437 Don't update size until alloc is done.
2438 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2440 Check for size calculation overflow.
2441 (ct_colors_allocated_max): New constant.
2442 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2445 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2446 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2447 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2448 Use ptrdiff_t, not int, to count maps.
2449 (read_char_minibuf_menu_prompt): Check for overflow in size
2450 calculations. Don't update size until allocation succeeds.
2451 Redo calculations to avoid overflow.
2452 * keyboard.h: Change prototypes to match the above.
2454 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2456 (current_minor_maps): Check for size calculation overflow.
2457 * keymap.h: Change prototypes to match the above.
2459 * lread.c (read1, init_obarray): Don't update size until alloc done.
2461 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2462 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2464 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2465 Now ptrdiff_t, not int.
2466 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2467 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2469 * process.c (Fnetwork_interface_list): Check for overflow
2470 in size calculation.
2472 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2474 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2475 overflow. Don't bother calling xmalloc when xrealloc will do.
2477 * search.c (Freplace_match): Check for size calculation overflow.
2478 (Fset_match_data): Don't assume list lengths fit in 'int'.
2480 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2481 for command line length. Do not attempt to address one before the
2482 beginning of an array, as that's not portable.
2484 * term.c (max_frame_lines): Remove; unused.
2485 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2487 (encode_terminal_code, calculate_costs): Check for size
2488 calculation overflow.
2489 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2490 table lengths and related sizes. Don't update size until alloc
2491 done. Redo calculations to avoid overflow.
2492 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2494 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2495 subtracting pointers.
2496 (gobble_line): Check for overflow more carefully. Don't update size
2499 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2500 Don't update size until alloc done.
2501 Redo size calculations to avoid overflow.
2502 Check for size calculation overflow.
2503 (main) [DEBUG]: Fix typo in invoking tparam1.
2505 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2506 Use ptrdiff_t, not int, for sizes.
2507 (store_mode_line_noprop_char): Don't update size until alloc done.
2509 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2510 Use ptrdiff_t, not int, for sizes.
2511 (Finternal_make_lisp_face, cache_face):
2512 Check for size calculation overflow.
2513 (cache_face): Treat size calculation overflows as if they were
2514 memory exhaustion (the usual treatment), rather than aborting.
2516 * xfns.c (x_encode_text, x_set_name_internal)
2517 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2518 sizes, since they can exceed INT_MAX in size. Check for size
2519 calculation overflow.
2521 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2522 (xg_select): Check for size calculation overflow.
2523 Don't update size until alloc done.
2525 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2526 as sprintf is limited to int lengths.
2528 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2529 (X_LONG_MIN): New macros.
2530 Use them to make the following changes clearer.
2531 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2532 This change doesn't affect the value now, but it may help remind
2533 future maintainers not to raise the value too much later.
2534 (SELECTION_QUANTUM): Remove, replacing with ...
2535 (selection_quantum): ... new function, which avoids overflow.
2537 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2538 assumption that selection length fits in 'int'.
2539 (x_reply_selection_request, x_handle_selection_request)
2540 (x_get_window_property, receive_incremental_selection)
2541 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2542 (lisp_data_to_selection_data, clean_local_selection_data):
2543 Use ptrdiff_t, not int, to record length of selection.
2544 (x_reply_selection_request, x_get_window_property)
2545 (receive_incremental_selection, x_property_data_to_lisp):
2546 Redo calculations to avoid overflow.
2547 (x_reply_selection_request): When sending hint, ceiling it at
2548 X_LONG_MAX rather than relying on wraparound overflow to send
2550 (x_get_window_property, receive_incremental_selection)
2551 (lisp_data_to_selection_data, x_property_data_to_lisp):
2552 Check for size-calculation overflow.
2553 (x_get_window_property, receive_incremental_selection)
2554 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2555 Don't store size until memory allocation succeeds.
2556 (x_get_window_property): Plug memory leak on memory exhaustion.
2557 Don't double-block input; malloc is safe here. Don't assume 2**34
2558 - 4 fits in unsigned long. Add an xassert to check
2559 XGetWindowProperty overflow. Be more careful about overflow
2560 calculations, and distinguish size from memory overflow better.
2561 (receive_incremental_selection): When tracing, don't assume
2562 unsigned int is less than INT_MAX.
2563 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2564 harmful) conversions of unsigned short to int.
2565 (lisp_data_to_selection_data): Don't assume that integers
2566 in the range -65535 through -1 fit in an X unsigned short.
2567 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2568 result parameters unless successful. Rely on cons_to_unsigned
2569 to report problems with elements; the old code wasn't right anyway.
2570 (x_check_property_data): Check for int overflow; we cannot use
2571 a wider type due to X limits.
2572 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2574 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2576 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2577 (x_term_init): Check for size calculation overflow.
2578 (x_color_cells): Don't store size until memory allocation succeeds.
2579 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2580 Don't assume alloca size is less than MAX_ALLOCA.
2581 (x_term_init): Don't assume length fits in int (sprintf is limited
2584 Use ptrdiff_t for composition IDs.
2585 * character.c (lisp_string_width):
2586 * composite.c (composition_table_size, n_compositions)
2587 (get_composition_id, composition_gstring_from_id):
2588 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2589 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2590 * window.c (Frecenter):
2591 Use ptrdiff_t, not int, for composition IDs.
2592 * composite.c (get_composition_id): Check for integer overflow.
2593 * composite.h: Adjust prototypes to match the above changes.
2595 Use ptrdiff_t for hash table indexes.
2596 * category.c (hash_get_category_set):
2597 * ccl.c (ccl_driver):
2598 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2599 * coding.c (coding_system_charset_list, detect_coding_system):
2600 * coding.h (struct coding_system.id):
2601 * composite.c (get_composition_id, gstring_lookup_cache):
2602 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2603 * image.c (xpm_get_color_table_h):
2604 * lisp.h (hash_lookup, hash_put):
2605 * minibuf.c (Ftest_completion):
2606 Use ptrdiff_t for hash table indexes, not int (which is too
2607 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2608 32-bit --with-wide-int hosts).
2610 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2611 Add a FIXME comment about memory leaks.
2612 (syms_of_charset): Don't assume xmalloc returns.
2614 Don't assume that stated character widths fit in int.
2615 * character.c (Fchar_width, c_string_width, lisp_string_width):
2616 * character.h (CHAR_WIDTH):
2617 * indent.c (MULTIBYTE_BYTES_WIDTH):
2618 Use sanitize_char_width to avoid undefined and/or bad behavior
2619 with outlandish widths.
2620 * character.h (sanitize_tab_width): Rename from sanitize_width,
2621 now that we have two such functions. All uses changed.
2622 (sanitize_char_width): New inline function.
2624 Don't assume that tab-width fits in int.
2625 * character.h (sanitize_width): New inline function.
2626 (SANE_TAB_WIDTH): New macro.
2627 (ASCII_CHAR_WIDTH): Use it.
2628 * indent.c (sane_tab_width): Remove. All uses replaced by
2629 SANE_TAB_WIDTH (current_buffer).
2630 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2632 * fileio.c: Integer overflow issues with file modes.
2633 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2635 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2636 Remove unreachable code.
2637 (read_hex, load_charset_map_from_file): Check for integer overflow.
2639 * xterm.c: Don't go over XClientMessageEvent limit.
2640 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2641 (x_send_scroll_bar_event): Likewise. Check that the size does not
2642 exceed limits imposed by XClientMessageEvent, as well as the usual
2643 ptrdiff_t and size_t limits.
2645 * keyboard.c: Overflow, signedness and related fixes.
2646 (make_lispy_movement): Use same integer type in forward decl
2647 that is used in the definition.
2648 (read_key_sequence, keyremap_step):
2649 Change bufsize argument back to int, undoing my 2011-03-30 change.
2650 We prefer signed types, and int is wide enough here.
2651 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2652 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2653 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2654 length, not size_t. Use ptrdiff_t for index, not int.
2655 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2656 possibility of integer overflow.
2658 Overflow, signedness and related fixes for images.
2660 * dispextern.h (struct it.stack[0].u.image.image_id)
2661 (struct_it.image_id, struct image.id, struct image_cache.size)
2662 (struct image_cache.used, struct image_cache.ref_count):
2663 * gtkutil.c (update_frame_tool_bar):
2664 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2665 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2666 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2667 * nsmenu.m (update_frame_tool_bar):
2668 * xdisp.c (calc_pixel_width_or_height):
2669 * xfns.c (image_cache_refcount):
2670 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2671 on typical 64-bit hosts.
2673 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2674 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2675 Omit unnecessary casts to int.
2676 (parse_image_spec): Check that integers fall into 'int' range
2677 when the callers expect that.
2678 (image_ascent): Redo ascent calculation to avoid int overflow.
2679 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2680 (lookup_image): Remove unnecessary tests.
2681 (xbm_image_p): Locals are now of int, not EMACS_INT,
2682 since parse_image_check makes sure they fit into int.
2683 (png_load, gif_load, svg_load_image):
2684 Prefer int to unsigned where either will do.
2685 (tiff_handler): New function, combining the cores of the
2686 old tiff_error_handler and tiff_warning_handler.
2687 This function is rewritten to use vsnprintf and thereby avoid
2688 stack buffer overflows. It uses only the features of vsnprintf
2689 that are common to both POSIX and native Microsoft.
2690 (tiff_error_handler, tiff_warning_handler): Use it.
2691 (tiff_load, gif_load, imagemagick_load_image):
2692 Don't assume :index value fits in 'int'.
2693 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2694 (imagemagick_load_image): Check that crop parameters fit into
2695 the integer types that MagickCropImage accepts. Don't assume
2696 Vimagemagick_render_type has a nonnegative value. Don't assume
2697 size_t fits in 'long'.
2698 (gs_load): Use printmax_t to print the widest integers possible.
2699 Check for integer overflow when computing image height and width.
2701 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2703 * xdisp.c (redisplay_window): Don't force window start if point
2704 will be invisible in the resulting window. (Bug#9324)
2706 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2708 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2709 the display spec is of the form `(space ...)'.
2710 (handle_display_spec): Return the value returned by
2711 handle_single_display_spec, not just 1 or zero.
2712 (handle_single_display_spec): If the display spec is of the form
2713 `(space ...)', and specifies display in the text area, return 2
2715 (try_cursor_movement): Check for the need to scroll more
2716 accurately, and prefer exact match for point under bidi.
2717 Don't advance `row' beyond the last row of the window.
2719 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2720 into disp_prop; all users changed.
2722 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2723 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2724 for the text covered by the display property.
2726 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2728 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2729 Change return value to nil.
2730 (Frecord_buffer): Delete unused function.
2732 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2734 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2735 buffers, return left-to-right.
2736 (set_cursor_from_row): Consider candidate row a win if its glyph
2737 represents a newline and point is on that newline. Fixes cursor
2738 positioning on the newline at EOL of R2L text within L2R
2739 paragraph, and vice versa.
2740 (try_cursor_movement): Check continued rows, in addition to
2741 continuation rows. Fixes unwarranted scroll when point enters a
2742 continued line of R2L text within an L2R paragraph, or vice versa.
2743 (cursor_row_p): Consider the case of point being equal to
2744 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2745 from the end of a short line to the beginning of a continued line
2746 of R2L text within L2R paragraph.
2747 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2748 composed characters.
2750 * bidi.c (bidi_check_type): Use xassert.
2751 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2754 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2756 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2759 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2761 * nsfont.m (ns_otf_to_script): Fix typo.
2763 2011-08-22 Kenichi Handa <handa@m17n.org>
2765 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2766 extra slot even if the purpose is char-code-property-table.
2768 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2770 * xdisp.c (redisplay_window): When computing centering_position,
2771 account for the height of the header line. (Bug#8874)
2773 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2774 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2775 candidate is selected by the mouse, and that candidate has a
2776 composed character under the mouse.
2778 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2779 coordinates reported by pos-visible-in-window-p for a composed
2780 character in column zero.
2782 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2784 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2786 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2788 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2789 consider it a hit if to_charpos is anywhere in the range of the
2790 composed buffer positions.
2792 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2794 * image.c (gif_load): Don't assume that each subimage has the same
2795 dimensions as the base image. Handle disposal method that is
2796 "undefined" by the gif spec (Bug#9335).
2798 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2800 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2801 (Fcondition_case): Document `debug' symbol in error handler.
2803 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2805 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2806 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2807 from an Org mode buffer to a Speedbar frame.
2809 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2810 a composition, take its buffer position from IT->cmp_it.charpos.
2811 Fixes cursor positioning at the beginning of a line that begins
2812 with a composed character.
2814 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2816 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2817 character bidirectional type, use STRONG_L instead. Fixes crashes
2818 in a buffer produced by `describe-categories'.
2820 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2821 members before the level stack, so they would be saved and
2822 restored when copying iterator state. Fixes incorrect reordering
2823 around TABs covered by display properties.
2825 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2827 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2829 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2831 * eval.c (internal_condition_case, internal_condition_case_1)
2832 (internal_condition_case_2, internal_condition_case_n):
2833 Remove unnecessary aborts (Bug#9081).
2835 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2837 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2838 has no `load' handler, try opening the file locally. (Bug#9311)
2840 2011-08-16 Ken Brown <kbrown@cornell.edu>
2842 * gmalloc.c: Expand comment.
2844 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2846 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2847 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2849 2011-08-16 Ken Brown <kbrown@cornell.edu>
2851 Fix memory allocation problems in Cygwin build (Bug#9273).
2853 * unexcw.c ( __malloc_initialized): Declare external variable.
2854 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2856 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2858 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2860 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2862 [CYGWIN] (special_realloc): New function.
2863 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2864 requests to realloc storage in the static heap.
2866 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2868 * bidi.c (bidi_initialize): Remove unused local.
2870 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2873 * biditype.h: Remove file.
2874 * makefile.w32-in ($(BLD)/bidi.$(O)):
2875 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2877 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2879 * chartab.c: Improve commentary for the uniprop_table API.
2881 * bidi.c (bidi_paragraph_init): Support zero value of
2882 bidi_ignore_explicit_marks_for_paragraph_level.
2883 (bidi_initialize): Use uniprop_table instead of including
2884 biditype.h and bidimirror.h.
2886 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2887 coordinates of the iterator when restoring from ppos_it.
2890 2011-08-14 Kenichi Handa <handa@m17n.org>
2892 * process.c (create_process): Call setup_process_coding_systems
2893 after the pid of the process is set to -1 (Bug#8162).
2895 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2897 * xdisp.c (move_it_in_display_line_to): Don't invoke
2898 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2899 ppos_it. Fixes vertical cursor motion when line beginning is
2900 covered by an image. (Bug#9296)
2902 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2904 * nsterm.h (ns_run_ascript): Declare.
2905 (NSAPP_DATA2_RUNASSCRIPT): Define.
2907 * nsfns.m (as_script, as_result, as_status): New static variables.
2908 (ns_run_ascript): New function.
2909 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2910 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2911 the event loop. Get status from as_status (Bug#7276).
2913 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2914 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2915 the event loop (Bug#7276).
2917 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2919 * gnutls.c (QCgnutls_bootprop_priority)
2920 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2921 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2922 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2923 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2924 (QCgnutls_bootprop_verify_hostname_error)
2925 (QCgnutls_bootprop_callbacks_verify): Rename from
2926 Qgnutls_bootprop_..., all uses changed.
2928 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2931 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2933 * xfaces.c (Qframe_set_background_mode): Now static.
2934 * dispextern.h (Qframe_set_background_mode): Remove decl.
2936 * process.c (Fnetwork_interface_info): Declare local only if needed.
2938 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2940 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2941 (Fnetwork_interface_list): Allocate in increments of bytes instead
2942 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2943 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2945 (struct ifflag_def): notrailers is smart on OSX.
2946 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2947 Get hardware address with getifaddrs if available.
2949 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2951 * xdisp.c (iterate_out_of_display_property): xassert that
2952 IT->position is set to within IT->object's boundaries. Break from
2953 the loop as soon as EOB is reached; avoids infloops in redisplay
2954 when IT->position is set up wrongly due to some bug.
2955 Set IT->current to match the bidi iterator unconditionally.
2956 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2957 entry. Force push_it to save on the stack the current
2958 buffer/string position, to be restored by pop_it. Fix flags in
2959 the iterator structure wrt the object coming from a display
2960 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2961 properties. (Bug#9284)
2963 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2965 * fontset.c (fontset_get_font_group): Add proper type checks.
2968 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2970 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2971 and LC_VERSION_MIN_MACOSX.
2972 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2973 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2975 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2977 * xdisp.c (forward_to_next_line_start): Allow to use the
2978 no-display-properties-and-no-overlays under bidi display.
2979 Set disp_pos in the bidi iterator to avoid searches for display
2980 properties and overlays.
2982 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2984 * editfns.c (Fset_time_zone_rule): Document relationship with the
2987 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2988 the font entity extracted from the cache (Bug#8109).
2990 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2992 * composite.c (autocmp_chars): Don't reset point. That is done by
2993 restore_point_unwind (Bug#5984).
2995 2011-08-07 Juri Linkov <juri@jurta.org>
2997 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2998 to show the arg `TIME' instead of `TIMEVAL'.
3000 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3002 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3003 display property strides EOL and includes a newline, as in
3004 longlines-mode. (Bug#9254)
3005 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3006 word-wrap under bidirectional display. (Bug#9224)
3008 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3009 is non-zero, even if the data buffer is NULL. Fixes a crash in
3010 vertical-motion with longlines-mode. (Bug#9254)
3012 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3014 * bidi.c <bidi_cache_total_alloc>: Now static.
3015 (bidi_initialize): Initialize bidi_cache_total_alloc.
3017 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3020 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3021 amount allocated this far in `bidi_cache_total_alloc'.
3022 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3023 non-zero, only free the data buffer without restoring the cache
3024 contents. All callers changed.
3026 * dispextern.h (bidi_unshelve_cache): Update prototype.
3028 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3029 (move_it_in_display_line, move_it_to)
3030 (move_it_vertically_backward, move_it_by_lines): Replace the call
3031 to xfree to an equivalent call to bidi_unshelve_cache.
3032 (move_it_in_display_line_to): Fix logic of returning
3033 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3035 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3037 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3038 came from a string character with a `cursor' property. (Bug#9229)
3040 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3042 * Makefile.in (LIB_PTHREAD): New variable.
3043 (LIBES): Add LIB_PTHREAD (Bug#9216).
3045 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3046 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3048 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3050 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3052 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3054 * xterm.c (x_find_topmost_parent): New function.
3055 (x_set_frame_alpha): Find topmost parent window with
3056 x_find_topmost_parent and set the property there also (bug#9181).
3057 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3059 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3061 * callproc.c (Fcall_process): Avoid vfork clobbering
3062 the local vars buffer, coding_systems, current_dir.
3064 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3066 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3068 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3070 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3071 so that it is not optimized away.
3073 * xdisp.c (compute_display_string_pos): Remove unused local.
3075 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3077 Fix slow cursor motion and scrolling in large buffers with
3078 selective display, like Org Mode buffers. (Bug#9218)
3080 * dispextern.h (struct bidi_it): New member disp_prop_p.
3082 * xdisp.c: Remove one-slot cache of display string positions.
3083 (compute_display_string_pos): Accept an additional argument
3084 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3085 for a display string or property. If found, set DISP_PROP_P
3088 * bidi.c (bidi_fetch_char): Accept an additional argument
3089 DISP_PROP_P, and pass it to compute_display_string_pos.
3090 Only handle text covered by a display string if DISP_PROP_P is returned
3091 non-zero. All callers of bidi_fetch_char changed.
3093 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3095 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3097 2010-12-03 Don March <don@ohspite.net>
3099 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3100 last character M-[char] is translated to ESC [char] (bug#7541).
3102 2011-08-02 Kenichi Handa <handa@m17n.org>
3104 * lisp.h (uniprop_table): Extern it.
3106 * chartab.c (uniprop_table): Make it non-static.
3108 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3110 * xdisp.c (forward_to_next_line_start): Accept additional argument
3111 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3113 (reseat_at_next_visible_line_start): Use the bidi iterator state
3114 returned by forward_to_next_line_start to restore the state of
3115 it->bidi_it after backing up to previous newline. (Bug#9212)
3117 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3119 * regex.c (re_comp): Protoize.
3120 (re_exec): Fix return type.
3121 (regexec): Fix type of `ret'. (Bug#9203)
3123 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3125 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3126 This is needed if max-image-size is a floating-point number.
3128 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3130 * print.c (print_object): Print empty symbol as ##.
3132 * lread.c (read1): Read ## as empty symbol.
3134 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3136 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3137 setting frame foreground color (Bug#9175).
3138 (x_set_background_color): Likewise.
3140 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3141 contents (Bug#9176).
3142 (EmacsTooltip -init): Remove bezels and add shadows to
3145 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3146 or scroll bar (Bug#8470).
3148 * nsfont.m (nsfont_open): Remove assignment to voffset and
3149 unnecessary vars hshink, expand, hd, full_height, min_height.
3150 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3152 * nsterm.h (nsfont_info): Remove voffset field.
3154 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3156 Implement strike-through and overline on NextStep (Bug#8863).
3158 * nsfont.m (nsfont_open): Use underline position provided by font,
3159 instead of hard-coded value of 2.
3160 (nsfont_draw): Call ns_draw_text_decoration instead.
3162 * nsterm.h: Add declaration for ns_draw_text_decoration.
3164 * nsterm.m (ns_draw_text_decoration): New function for drawing
3165 underline, overline, and strike-through.
3166 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3167 ns_draw_text_decoration. Change treatment of cursor drawing to
3168 accommodate underlining, etc.
3170 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3172 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3175 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3177 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3178 Without this fix, if a signal arrives just after memory fills up,
3179 'malloc' might be invoked reentrantly.
3181 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3182 In other words, assume that every image size is allowed, on non-X
3183 hosts. This assumption is probably wrong, but it lets Emacs compile.
3185 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3187 * regex.c (re_iswctype): Convert return values to boolean.
3189 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3191 * xdisp.c (compute_display_string_pos): Don't use cached display
3192 string position if the buffer had its restriction changed.
3195 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3197 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3199 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3201 Integer signedness and overflow and related fixes. (Bug#9079)
3203 * bidi.c: Integer size and overflow fixes.
3204 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3205 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3206 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3207 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3208 (bidi_find_other_level_edge):
3209 Use ptrdiff_t instead of EMACS_INT where either will do.
3210 This works better on 32-bit hosts configured --with-wide-int.
3211 (bidi_cache_ensure_space): Check for size-calculation overflow.
3212 Use % rather than repeated addition, for better worst-case speed.
3213 Don't set bidi_cache_size until after xrealloc returns, because it
3215 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3216 (bidi_cache_ensure_space): Also check that the bidi cache size
3217 does not exceed that of the largest Lisp string or buffer. See Eli
3218 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3220 * alloc.c (__malloc_size_t): Remove.
3221 All uses replaced by size_t. See Andreas Schwab's note
3222 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3224 * image.c: Improve checking for integer overflow.
3225 (check_image_size): Assume that f is nonnull, since
3226 it is always nonnull in practice. This is one less thing to
3227 worry about when checking for integer overflow later.
3228 (x_check_image_size): New function, which checks for integer
3229 overflow issues inside X.
3230 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3231 This removes the need for a memory_full check.
3232 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3233 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3234 (xbm_read_bitmap_data): Change locals back to 'int', since
3235 their values must fit in 'int'.
3236 (xpm_load_image, png_load, tiff_load):
3237 Invoke x_create_x_image_and_pixmap earlier,
3238 to avoid much needless work if the image is too large.
3239 (tiff_load): Treat overly large images as if
3240 x_create_x_image_and_pixmap failed, not as malloc failures.
3241 (gs_load): Use x_check_image_size.
3243 * gtkutil.c: Omit integer casts.
3244 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3245 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3247 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3249 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3250 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3251 would wrongly return t on a 64-bit host.
3253 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3254 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3255 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3256 and therefore cause GCC to emit a bogus diagnostic in some cases.
3258 * image.c: Integer signedness and overflow and related fixes.
3259 This is not an exhaustive set of fixes, but it's time to
3260 record what I've got.
3261 (lookup_pixel_color, check_image_size): Remove redundant decls.
3262 (check_image_size): Don't assume that arbitrary EMACS_INT values
3263 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3264 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3265 (tiff_load, imagemagick_load_image):
3266 Check for overflow in size calculations.
3267 (x_create_x_image_and_pixmap): Remove unnecessary test for
3268 xmalloc returning NULL; that can't happen.
3269 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3270 (xpm_color_bucket): Use better integer hashing function.
3271 (xpm_cache_color): Don't possibly over-allocate memory.
3272 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3273 (gif_memory_source):
3274 Use ptrdiff_t, not int or size_t, to record sizes.
3275 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3276 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3277 either works, as we prefer signed integers.
3278 (tiff_read_from_memory, tiff_write_from_memory):
3279 Return tsize_t, not size_t, since that's what the TIFF API wants.
3280 (tiff_read_from_memory): Don't fail simply because the read would
3281 go past EOF; instead, return a short read.
3282 (tiff_load): Omit no-longer-needed casts.
3283 (Fimagemagick_types): Don't assume size fits into 'int'.
3285 Improve hashing quality when configured --with-wide-int.
3286 * fns.c (hash_string): New function, taken from sxhash_string.
3287 Do not discard information about ASCII character case; this
3288 discarding is no longer needed.
3289 (sxhash-string): Use it. Change sig to match it. Caller changed.
3290 * lisp.h: Declare it.
3291 * lread.c (hash_string): Remove, since we now use fns.c's version.
3292 The fns.c version returns a wider integer if --with-wide-int is
3293 specified, so this should help the quality of the hashing a bit.
3295 * emacs.c: Integer overflow minor fix.
3296 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3297 Define only if GNU_LINUX.
3298 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3300 * dispnew.c: Integer signedness and overflow fixes.
3301 Remove unnecessary forward decls, that were a maintenance hassle.
3302 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3304 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3305 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3306 (prepare_desired_row, line_draw_cost):
3307 Use int, not unsigned, where either works.
3308 (save_current_matrix, restore_current_matrix):
3309 Use ptrdiff_t, not size_t, where either works.
3310 (init_display): Check for overflow more accurately, and without
3311 relying on undefined behavior.
3313 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3314 Remove, replacing with the new symbols in lisp.h. All uses changed.
3315 * fileio.c (make_temp_name):
3316 * filelock.c (lock_file_1, lock_file):
3317 * xdisp.c (message_dolog):
3318 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3319 Use pMd etc. instead.
3320 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3321 replacing the pWIDE etc. symbols removed from editfns.c.
3323 * keyboard.h (num_input_events): Now uintmax_t.
3324 This is (very slightly) less likely to mess up due to wraparound.
3327 * buffer.c: Integer signedness fixes.
3328 (alloc_buffer_text, enlarge_buffer_text):
3329 Use ptrdiff_t rather than size_t when either will do, as we prefer
3332 * alloc.c: Integer signedness and overflow fixes.
3333 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3334 (__malloc_size_t): Default to size_t, not to int.
3335 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3336 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3337 Prefer ptrdiff_t to size_t when either would do, as we prefer
3339 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3340 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3341 Now const. Initialize with values that are in range even if char
3343 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3344 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3345 These functions do the right thing with sizes > 2**32.
3346 (check_depth): Now ptrdiff_t, not int.
3347 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3348 Adjust to new way of storing sizes. Check for size overflow bugs
3350 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3351 slightly wrong anyway, as it missed one instance of
3352 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3353 (refill_memory_reserve): Omit needless cast to size_t.
3354 (mark_object_loop_halt): Mark as externally visible.
3356 * xselect.c: Integer signedness and overflow fixes.
3357 (Fx_register_dnd_atom, x_handle_dnd_message):
3358 Use ptrdiff_t, not size_t, since we prefer signed.
3359 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3360 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3361 x_dnd_atoms_size and x_dnd_atoms_length.
3363 * doprnt.c: Prefer signed to unsigned when either works.
3365 * doprnt.c (doprnt):
3367 * xdisp.c (vmessage):
3368 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3369 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3370 prefer signed arithmetic to avoid comparison confusion.
3371 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3372 but is a bit tricky.
3374 Assume freestanding C89 headers, string.h, stdlib.h.
3375 * data.c, doprnt.c, floatfns.c, print.c:
3376 Include float.h unconditionally.
3377 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3378 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3379 * regex.c: Likewise for stddef.h, string.h.
3380 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3381 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3382 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3383 (STDC_HEADERS): Remove obsolete defines.
3384 * sysdep.c: Include limits.h unconditionally.
3386 Assume support for memcmp, memcpy, memmove, memset.
3387 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3388 * regex.c (memcmp, memcpy):
3389 Remove; we assume C89 now.
3391 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3392 (__malloc_safe_bcopy): Remove; no longer needed.
3394 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3395 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3396 well either way, and we prefer signed to unsigned.
3398 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3400 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3401 closes the connection while we're reading (bug#9182).
3403 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3405 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3406 are specified (Bug#9168).
3408 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3410 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3411 Found by GCC static checking and --with-wide-int on a 32-bit host.
3413 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3415 * xdisp.c (compute_display_string_pos): Fix logic of caching
3416 previous display string position. Initialize cached_prev_pos to
3417 -1. Fixes slow-down at the beginning of a buffer.
3419 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3421 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3422 for attrs[LFACE_FONTSET_INDEX].
3424 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3426 * xml.c (parse_region): Remove unused local
3427 that was recently introduced.
3429 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3431 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3432 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3434 * xdisp.c (move_it_in_display_line_to): Record the best matching
3435 position for TO_CHARPOS while scanning the line, and restore it on
3436 exit if none of the characters scanned was an exact match.
3437 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3438 when exact match is impossible due to invisible text, and the
3439 lines are truncated.
3441 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3443 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3446 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3448 Fix a significant slow-down of cursor motion with C-n, C-p,
3449 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3450 auto-repeat under bidi redisplay in fontified buffers.
3451 * xdisp.c (compute_stop_pos_backwards): New function.
3452 (next_element_from_buffer): Call compute_stop_pos_backwards to
3453 find a suitable prev_stop when we find ourselves before
3455 (reseat): Don't look for prev_stop, as that could mean a very long
3457 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3458 <cached_disp_overlay_modiff>: Cache for last found display string
3460 (compute_display_string_pos): Return the cached position if asked
3461 about the same buffer in the same area of character positions, and
3462 the buffer wasn't changed since the time the display string
3463 position was cached.
3465 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3467 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3468 is an integer, which is important for empty lines. (Bug#9149)
3470 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3472 * frame.c (Fmodify_frame_parameters): In tty case, update the
3473 default face if necessary (Bug#4238).
3475 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3477 * editfns.c (Fstring_to_char): No need to explain what a character
3478 is in the docstring (Bug#6576).
3480 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3482 * xml.c (parse_region): Make sure we always return a tree.
3484 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3486 * xml.c (parse_region): If a document contains only comments,
3489 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3491 * xml.c (make_dom): Return comments, too.
3493 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3496 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3497 and the surrounding thread.
3498 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3499 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3500 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3502 * s/openbsd.h (BROKEN_SIGIO): Define.
3503 * unexelf.c (unexec) [__OpenBSD__]:
3504 Don't update the .mdebug section of the Alpha COFF symbol table.
3506 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3508 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3511 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3513 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3514 This fixes some race conditions on the permissions of any newly
3517 * alloc.c (valid_pointer_p): Use pipe, not open.
3518 This fixes some permissions issues when debugging.
3520 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3521 If fchown fails to set both uid and gid, try to set just gid,
3522 as that is sometimes allowed. Adjust the file's mode to eliminate
3523 setuid or setgid bits that are inappropriate if fchown fails.
3525 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3527 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3528 to compare Lisp_Objects.
3529 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3530 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3531 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3533 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3535 * lread.c (read_integer): Unread even EOF character.
3536 (read1): Likewise. Properly record start position of symbol.
3538 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3539 symbol character follows.
3541 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3543 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3544 This works around a problem with the previous change to Fcopy_file.
3545 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3546 and without this change, GCC might complain about discarding
3547 fchown's return value.
3549 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3551 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3553 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3555 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3557 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3559 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3560 it's used from the C level.
3562 * process.c: Use the same condition for POLL_FOR_INPUT in both
3563 keyboard.c and process.c (bug#1858).
3565 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3567 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3568 (Fgnutls_boot): Use it.
3570 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3572 * doc.c (Fsubstitute_command_keys): Revert last change.
3574 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3576 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3577 quotes the next character, and doesn't affect other longer
3578 sequences (bug#8935).
3580 * lread.c (syms_of_lread): Clarify that is isn't only
3581 `eval-buffer' and `eval-defun' that's affected by
3582 `lexical-binding' (bug#8460).
3584 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3586 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3587 bidi redisplay when a line includes both an image and is truncated.
3589 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3591 Fix minor problems found by static checking.
3592 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3593 (elsz): Now a signed constant, not a size_t var. We prefer signed
3594 types to unsigned, to avoid integer comparison confusion. Without
3595 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3596 "cannot optimize loop, the loop counter may overflow", a symptom
3598 * indent.c (Fvertical_motion): Mark locals as initialized.
3599 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3601 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3603 * search.c (Fre_search_backward): Mention `case-fold-search' in
3604 all the re_search_* functions (bug#8138).
3606 * keyboard.c (Fopen_dribble_file): Document when the file is
3609 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3611 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3614 Support bidi reordering of display and overlay strings.
3615 * xdisp.c (compute_display_string_pos)
3616 (compute_display_string_end): Accept additional argument STRING.
3617 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3618 (reseat_to_string): Initialize bidi_it->string.s and
3619 bidi_it->string.schars.
3620 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3621 NULL (avoids a crash in bidi_paragraph_init).
3622 Initialize itb.string.lstring.
3623 (init_iterator): Call bidi_init_it only of a valid
3624 buffer position was specified. Initialize paragraph_embedding to
3626 (reseat_to_string): Initialize the bidi iterator.
3627 (display_string): If we need to ignore text properties of
3628 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3629 original value of -1 will not work with bidi.)
3630 (compute_display_string_pos): First arg is now struct
3631 `text_pos *'; all callers changed. Support display properties on
3633 (compute_display_string_end): Support display properties on Lisp
3635 (init_iterator, reseat_1, reseat_to_string): Initialize the
3636 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3637 when iterating on a string not from display properties).
3638 (compute_display_string_pos, compute_display_string_end):
3639 Fix calculation of the object to scan. Fixes an error when using
3641 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3642 base_level_stop; instead, set base_level_stop to BEGV.
3643 Fixes crashes in vertical-motion.
3644 (next_element_from_buffer): Improve commentary for when
3645 the iterator is before prev_stop.
3646 (init_iterator): Initialize bidi_p from the default value of
3647 bidi-display-reordering, not from buffer-local value. Use the
3648 buffer-local value only if initializing for buffer iteration.
3649 (handle_invisible_prop): Support invisible properties on strings
3650 that are being bidi-reordered.
3651 (set_iterator_to_next): Support bidi reordering of C strings and
3653 (next_element_from_string): Support bidi reordering of Lisp
3655 (handle_stop_backwards): Support Lisp strings as well.
3656 (display_string): Support display of R2L glyph rows.
3657 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3658 (init_iterator): Don't initialize it->bidi_p for strings
3660 (reseat_to_string): Initialize it->bidi_p for strings here.
3661 (next_element_from_string, next_element_from_c_string)
3662 (next_element_from_buffer): Add xassert's for correspondence
3663 between IT's object being iterated and it->bidi_it.string
3665 (face_before_or_after_it_pos): Support bidi iteration.
3666 (next_element_from_c_string): Handle the case of the first string
3667 character that is not the first one in the visual order.
3668 (get_visually_first_element): New function, refactored from common
3669 parts of next_element_from_buffer, next_element_from_string, and
3670 next_element_from_c_string.
3671 (tool_bar_lines_needed, redisplay_tool_bar)
3672 (display_menu_bar): Force left-to-right direction. Add a FIXME
3673 comment for making that be controlled by a user option.
3674 (push_it, pop_it): Save and restore the state of the
3675 bidi iterator. Save and restore the bidi_p flag.
3676 (pop_it): Iterate out of display property for string iteration as
3678 (iterate_out_of_display_property): Support iteration over strings.
3679 (handle_single_display_spec): Set up it->bidi_it for iteration
3680 over a display string, and call bidi_init_it.
3681 (handle_single_display_spec, next_overlay_string)
3682 (get_overlay_strings_1, push_display_prop): Set up the bidi
3683 iterator for displaying display or overlay strings.
3684 (forward_to_next_line_start): Don't use the shortcut if
3686 (back_to_previous_visible_line_start): If handle_display_prop
3687 pushed the iterator stack, restore the internal state of the bidi
3688 iterator by calling bidi_pop_it same number of times.
3689 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3690 and we are bidi-iterating, don't decrement the iterator position;
3691 instead, set the first_elt flag in the bidi iterator, to produce
3693 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3694 (push_display_prop): xassert that we are iterating a buffer.
3695 (push_it, pop_it): Save and restore paragraph_embedding member.
3696 (handle_single_display_spec, next_overlay_string)
3697 (get_overlay_strings_1, reseat_1, reseat_to_string)
3698 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3699 correctly. Don't assume unibyte strings are not bidi-reordered.
3700 (compute_display_string_pos)
3701 (compute_display_string_end): Fix handling the case of C string.
3702 (push_it, pop_it): Save and restore from_disp_prop_p.
3703 (handle_single_display_spec, push_display_prop): Set the
3704 from_disp_prop_p flag.
3705 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3706 (pop_it): Call iterate_out_of_display_property only if we are
3707 popping after iteration over a string that came from a display
3708 property. Fix a typo in popping stretch info. Add an assertion
3709 for verifying that the iterator position is in sync with the bidi
3711 (handle_single_display_spec, get_overlay_strings_1)
3712 (push_display_prop): Fix initialization of paragraph direction for
3713 string when that of the parent object is not yet determined.
3714 (reseat_1): Call bidi_init_it to resync the bidi
3715 iterator with IT's position. (Bug#7616)
3716 (find_row_edges): If ROW->start.pos gives position
3717 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3718 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3719 Reset the from_disp_prop_p flag.
3720 (SAVE_IT, RESTORE_IT): New macros.
3721 (pos_visible_p, face_before_or_after_it_pos)
3722 (back_to_previous_visible_line_start)
3723 (move_it_in_display_line_to, move_it_in_display_line)
3724 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3725 (try_scrolling, redisplay_window, display_line): Use them when
3726 saving a temporary copy of the iterator and restoring it back.
3727 (back_to_previous_visible_line_start, reseat_1)
3728 (init_iterator): Empty the bidi cache "stack".
3729 (move_it_in_display_line_to): If iterator ended up at
3730 EOL, but we never saw any buffer positions smaller than
3731 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3732 motion in bidi-reordered lines.
3733 (move_it_in_display_line_to): Record prev_method and prev_pos
3734 immediately before the call to set_iterator_to_next. Fixes cursor
3735 motion in bidi-reordered lines with stretch glyphs and strings
3736 displayed in margins. (Bug#8133) (Bug#8867)
3737 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3739 (pos_visible_p): Support positions in bidi-reordered lines.
3740 Save and restore bidi cache.
3742 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3743 (bidi_paragraph_info): Delete unused struct.
3744 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3745 (bidi_cache_start): New variable.
3746 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3748 (bidi_cache_fetch_state, bidi_cache_search)
3749 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3750 (bidi_cache_find, bidi_peek_at_next_level)
3751 (bidi_level_of_next_char, bidi_find_other_level_edge)
3752 (bidi_move_to_visually_next): Compare cache index with
3753 bidi_cache_start rather than with zero.
3754 (bidi_fetch_char): Accept new argument STRING; all callers
3755 changed. Support iteration over a string. Support strings with
3756 display properties. Support unibyte strings. Fix the type of
3757 `len' according to what STRING_CHAR_AND_LENGTH expects.
3758 (bidi_paragraph_init, bidi_resolve_explicit_1)
3759 (bidi_resolve_explicit, bidi_resolve_weak)
3760 (bidi_level_of_next_char, bidi_move_to_visually_next):
3761 Support iteration over a string.
3762 (bidi_set_sor_type, bidi_resolve_explicit_1)
3763 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3764 can now be zero (for strings); special values 0 and -1 were
3765 changed to -1 and -2, respectively.
3766 (bidi_char_at_pos): New function.
3767 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3768 Call it instead of FETCH_MULTIBYTE_CHAR.
3769 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3770 initialized to valid values.
3771 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3773 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3774 the test for valid cached positions. Fix the logic for looking up
3775 the sentinel state in the cache. GCPRO the Lisp string we are
3777 (bidi_push_it, bidi_pop_it): New functions.
3778 (bidi_initialize): Initialize the bidi cache start stack pointer.
3779 (bidi_cache_ensure_space): New function, refactored from part of
3780 bidi_cache_iterator_state. Don't assume the required size is just
3781 one BIDI_CACHE_CHUNK away.
3782 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3783 (bidi_count_bytes, bidi_char_at_pos): New functions.
3784 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3785 always valid if bidi_cache_idx is valid.
3786 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3787 is valid if it's going to be used.
3788 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3789 (bidi_cache_fetch_state, bidi_cache_search)
3790 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3791 (bidi_cache_iterator_state, bidi_cache_find)
3792 (bidi_find_other_level_edge, bidi_cache_start_stack):
3793 All variables related to cache indices are now EMACS_INT.
3795 * dispextern.h (struct bidi_string_data): New structure.
3796 (struct bidi_it): New member `string'. Make flag members be 1-bit
3797 fields, and put them last in the struct.
3798 (compute_display_string_pos, compute_display_string_end):
3800 (bidi_push_it, bidi_pop_it): Add prototypes.
3801 (struct iterator_stack_entry): New members bidi_p,
3802 paragraph_embedding, and from_disp_prop_p.
3803 (struct it): Member bidi_p is now a bit field 1 bit wide.
3804 (bidi_shelve_cache, bidi_unshelve_cache):
3807 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3808 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3809 and vector-like objects.
3811 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3812 cache around display iteration.
3814 * window.c (Fwindow_end, window_scroll_pixel_based)
3815 (displayed_window_lines, Frecenter): Save and restore the bidi
3816 cache around display iteration.
3818 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3820 * editfns.c (Fdelete_region): Clarify the use of the named
3821 parameters (bug#6788).
3823 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3825 * indent.c (Fvertical_motion): Set and restore w->pointm when
3826 saving and restoring the window's buffer (Bug#9006).
3828 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3830 * editfns.c (Fstring_to_char): Clarify just what is returned
3831 (bug#6576). Text by Eli Zaretskii.
3833 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3835 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3837 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3839 * buffer.c (mmap_find): Fix a typo.
3841 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3843 Fix execution of x selection hooks.
3844 * xselect.c (Qx_lost_selection_functions)
3845 (Qx_sent_selection_functions): New vars.
3846 (syms_of_xselect): DEFSYM them.
3847 (x_handle_selection_request): Pass Qx_sent_selection_functions
3848 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3849 (x_handle_selection_clear,x_clear_frame_selections):
3850 Pass Qx_lost_selection_functions rather than
3851 Vx_lost_selection_functions to Frun_hook_with_args.
3853 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3855 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3856 The old code sometimes used this field without initializing it.
3858 * alloc.c (gc_sweep): Don't read past end of array.
3859 In theory, the old code could also have corrupted Emacs internals,
3860 though it'd be very unlikely.
3862 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3864 * character.c (Fcharacterp): Don't advertise optional ignored
3865 argument. (Bug#4026)
3867 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3869 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3872 * window.c (Fset_window_start): Doc fix (bug#4199).
3873 (Fset_window_hscroll): Ditto.
3875 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3877 Fix minor new problems caught by GCC 4.6.1.
3878 * term.c (init_tty): Remove unused local.
3879 * xsettings.c (store_monospaced_changed): Define this function only
3880 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3883 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3885 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3887 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3889 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3890 are the mini-buffer and the echo area (bug#3320).
3892 * term.c (init_tty): Remove support for supdup, c10 and perq
3893 terminals, which are no longer supported (bug#1482).
3895 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3897 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3899 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3901 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3902 for non-popups (Bug#3642).
3904 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3906 * alloc.c (reset_malloc_hooks): Protoize.
3907 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3908 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3909 * cm.c (losecursor): Likewise.
3910 * data.c (fmod): Likewise.
3911 * dispnew.c (swap_glyphs_in_rows): Likewise.
3912 * emacs.c (memory_warning_signal): Likewise.
3913 * floatfns.c (float_error): Likewise.
3914 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3915 (otf_open, font_otf_capability, generate_otf_features)
3916 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3918 * image.c (pbm_read_file): Likewise.
3919 * indent.c (string_display_width): Likewise.
3920 * intervals.c (check_for_interval, search_for_interval)
3921 (inc_interval_count, count_intervals, root_interval)
3922 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3923 * lread.c (defalias): Likewise.
3924 * ralloc.c (r_alloc_check): Likewise.
3925 * regex.c (set_image_of_range_1, set_image_of_range)
3926 (regex_grow_registers): Likewise.
3927 * sysdep.c (strerror): Likewise.
3928 * termcap.c (valid_filename_p, tprint, main): Likewise.
3929 * tparam.c (main): Likewise.
3930 * unexhp9k800.c (run_time_remap, save_data_space)
3931 (update_file_ptrs, read_header, write_header, calculate_checksum)
3932 (copy_file, copy_rest, display_header): Likewise.
3933 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3935 * xdisp.c (check_it): Likewise.
3936 * xfaces.c (register_color, unregister_color, unregister_colors):
3938 * xfns.c (print_fontset_result): Likewise.
3939 * xrdb.c (member, fatal, main): Likewise.
3941 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3943 Fix minor problems found by static checking (Bug#9031).
3944 * chartab.c (char_table_set_range, map_sub_char_table):
3945 Remove unused locals.
3946 (uniprop_table): Now static.
3947 * composite.c (_work_char): Remove unused static var.
3949 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3951 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3953 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3955 * gtkutil.c (qttip_cb): Remove code without function.
3957 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3959 * w32.c (pthread_sigmask): New stub.
3961 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3963 Use pthread_sigmask, not sigprocmask (Bug#9010).
3964 sigprocmask is portable only for single-threaded applications, and
3965 Emacs can be multi-threaded when it uses GTK.
3966 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3968 * callproc.c (Fcall_process):
3969 * process.c (create_process):
3970 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3971 Use pthread_sigmask, not sigprocmask.
3973 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3975 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3976 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3979 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3981 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3982 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3983 (xg_hide_tooltip): Fix comment.
3985 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3986 in registerServicesMenuSendTypes.
3987 (validRequestorForSendType): Don't check ns_return_types.
3989 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3992 2011-07-08 Jason Rumney <jasonr@gnu.org>
3994 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3995 SH_SHOW for hidden windows (Bug#5482).
3997 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3998 frame struct members of non-existent frames (Bug#6284).
4000 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4002 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4003 variable firstTime not needed on OSX >= 10.6.
4004 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4005 >= 10.5. Use setKnobProportion, setDoubleValue.
4007 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4008 (MAC_OS_X_VERSION_10_5): Define if not defined.
4009 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4010 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4011 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4013 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4014 cString and lossyCString on OSX >= 10.4
4016 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4017 sizeToFit on OSX >= 10.2.
4019 * nsimage.m (allocInitFromFile): Don't use deprecated method
4020 bestRepresentationForDevice on OSX >= 10.6.
4022 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4025 * emacs.c: Declare unexec_init_emacs_zone.
4027 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4029 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4031 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4032 on svcsMenu (Bug#8842).
4034 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4036 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4038 * nsterm.m (QUTF8_STRING): Declare.
4039 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4040 (validRequestorForSendType): Return type is (id).
4041 Change indexOfObjectIdenticalTo to indexOfObject.
4042 Check if we have local selection before returning self (Bug#8842).
4043 (writeSelectionToPasteboard): Put local selection into paste board
4044 if we have a local selection (Bug#8842).
4045 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4047 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4048 (ns_get_local_selection): Declare.
4050 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4052 * keymap.c (describe_map_tree): Don't insert a double newline at
4053 the end of the buffer (bug#1169) and return whether we inserted
4056 * callint.c (Fcall_interactively): Change "reading args" to
4057 "providing args" to try to clarify what it does (bug#1010).
4059 2011-07-07 Kenichi Handa <handa@m17n.org>
4061 * composite.c (composition_compute_stop_pos): Ignore a static
4062 composition starting before CHARPOS (Bug#8915).
4064 * xdisp.c (handle_composition_prop): Likewise.
4066 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4068 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4071 2011-07-07 Kenichi Handa <handa@m17n.org>
4073 * character.h (unicode_category_t): New enum type.
4075 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4076 (Qchar_code_property_table): New variable.
4077 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4078 (UNIPROP_COMPRESSED_FORM_P): New macros.
4079 (char_table_ascii): Uncompress the compressed values.
4080 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4081 Uncompress the compressed values.
4082 (sub_char_table_ref_and_range): Likewise.
4083 (char_table_ref_and_range): Uncompress the compressed values.
4084 (sub_char_table_set): New arg is_uniprop. Callers changed.
4085 Uncompress the compressed values.
4086 (sub_char_table_set_range): Args changed. Callers changed.
4087 (char_table_set_range): Adjuted for the above change.
4088 (map_sub_char_table): Delete args default_val and parent. Add arg
4089 top. Give decoded values to a Lisp function.
4090 (map_char_table): Adjust for the above change. Give decoded
4091 values to a Lisp function. Gcpro more variables.
4092 (uniprop_table_uncompress)
4093 (uniprop_decode_value_run_length): New functions.
4094 (uniprop_decoder, uniprop_decoder_count): New variables.
4095 (uniprop_get_decoder, uniprop_encode_value_character)
4096 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4098 (uniprop_encoder, uniprop_encoder_count): New variables.
4099 (uniprop_get_encoder, uniprop_table)
4100 (Funicode_property_table_internal, Fget_unicode_property_internal)
4101 (Fput_unicode_property_internal): New functions.
4102 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4103 Sunicode_property_table_internal, Sget_unicode_property_internal,
4104 and Sput_unicode_property_internal. Defvar_lisp
4105 char-code-property-alist.
4107 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4108 Vunicode_category_table.
4110 * font.c (font_range): Adjust for the change of
4111 Vunicode_category_table.
4113 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4115 * m/iris4d.h: Remove file, move contents ...
4116 * s/irix6-5.h: ... here.
4118 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4120 Remove unportable assumption about struct layout (Bug#8884).
4121 * alloc.c (mark_buffer):
4122 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4123 (clone_per_buffer_values): Don't assume that
4124 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4125 This isn't true in general, and it's particularly not true
4126 if Emacs is configured with --with-wide-int.
4127 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4128 New macros, used in the buffer.c change.
4130 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4132 * xsettings.c: Use both GConf and GSettings if both are available.
4133 (store_config_changed_event): Add comment.
4134 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4135 (store_tool_bar_style_changed): New functions.
4136 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4137 (struct xsettings): Move font inside HAVE_XFT.
4138 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4139 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4140 Move inside HAVE_XFT.
4141 (something_changed_gsettingsCB): Rename from something_changedCB.
4142 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4144 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4145 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4146 (something_changed_gconfCB): Rename from something_changedCB.
4147 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4148 (parse_settings): Move check for font inside HAVE_XFT.
4149 (read_settings, apply_xft_settings): Add comment.
4150 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4151 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4152 call store_font_name_changed.
4153 (xft_settings_event): Add comment.
4154 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4155 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4156 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4157 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4158 (xsettings_initialize): Call init_gsettings last.
4159 (xsettings_get_system_font, xsettings_get_system_normal_font):
4162 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4164 Random fixes. E.g., (random) never returned negative values.
4165 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4166 subseconds part to the entropy, as that's a bit more random.
4167 Prefer signed to unsigned, since the signedness doesn't matter and
4168 in general we prefer signed. When given a limit, use a
4169 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4170 latter isn't right if USE_2_TAGS_FOR_INTS.
4171 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4172 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4174 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4176 * textprop.c (text_property_stickiness):
4177 Obey Vtext_property_default_nonsticky.
4178 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4179 * w32fns.c (syms_of_w32fns):
4180 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4182 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4184 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4185 This is more efficient than Ffile_directory_p and avoids a minor race.
4187 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4189 * buffer.c (Foverlay_put): Say what the return value is
4192 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4193 is a directory before asking whether to use the file name
4195 (barf_or_query_if_file_exists): Make the "File is a directory"
4196 error be more correct.
4198 * fns.c (Frequire): Remove the mention of the .gz files, since
4199 that's installation-specific, but keep the mention of
4200 `get-load-suffixes'.
4202 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4204 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4205 Report string overflow if the output is too long.
4207 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4209 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4210 (syms_of_gnutls): Remove duplicate DEFSYM for
4211 Qgnutls_bootprop_verify_hostname_error, an error for
4212 Qgnutls_bootprop_verify_error (which is no longer used).
4214 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4215 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4216 Also (re)move comments that are misplaced or no longer relevant.
4218 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4220 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4222 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4224 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4225 and background color parameters if they have been changed.
4227 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4229 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4231 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4233 * xsettings.c (SYSTEM_FONT): Define only when used.
4234 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4236 * keymap.c (access_keymap_1): Now static.
4238 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4240 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4241 leave any prefix arg for the up event (Bug#1586).
4243 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4245 * lread.c (syms_of_lread): Mention single symbols defined by
4246 `defvar' or `defconst' (bug#7154).
4248 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4249 (Frequire): Mention get-load-suffixes.
4251 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4253 * window.h (window): Remove clone_number slot.
4254 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4256 (make_parent_window, make_window, saved_window)
4257 (Fset_window_configuration, save_window_save): Don't deal with
4259 * buffer.c (Qclone_number): Remove declaration.
4260 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4262 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4264 Add multiple inheritance to keymaps.
4265 * keymap.c (Fmake_composed_keymap): New function.
4266 (Fset_keymap_parent): Simplify.
4267 (fix_submap_inheritance): Remove.
4268 (access_keymap_1): New function extracted from access_keymap to handle
4269 embedded parents and handle lists of maps.
4270 (access_keymap): Use it.
4271 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4272 (Fcopy_keymap): Handle embedded parents.
4273 (Fcommand_remapping, define_as_prefix): Simplify.
4274 (Fkey_binding): Simplify.
4275 (syms_of_keymap): Move minibuffer-local-completion-map,
4276 minibuffer-local-filename-completion-map,
4277 minibuffer-local-must-match-map, and
4278 minibuffer-local-filename-must-match-map to Elisp.
4279 (syms_of_keymap): Defsubr make-composed-keymap.
4280 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4281 (parse_menu_item): Trivial simplification.
4283 2011-07-01 Glenn Morris <rgm@gnu.org>
4285 * Makefile.in (SETTINGS_LIBS): Fix typo.
4287 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4289 * coding.c (Fencode_coding_string): Record the last coding system
4290 used, as the function doc string says (bug#8738).
4292 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4294 * xsettings.c (store_monospaced_changed): Take new font as arg and
4295 check for change against current_mono_font.
4296 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4297 (emacs_settings_constructor, emacs_settings_get_property)
4298 (emacs_settings_set_property, emacs_settings_class_init)
4299 (emacs_settings_init, gsettings_obj): Remove.
4300 (something_changedCB): New function for HAVE_GSETTINGS.
4301 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4302 with value as argument.
4303 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4304 g_settings_new (Bug#8967). Do not create gsettings_obj.
4305 Remove calls to g_settings_bind. Connect something_changedCB to
4308 * xgselect.c: Add defined (HAVE_GSETTINGS).
4309 (xgselect_initialize): Ditto.
4311 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4312 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4315 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4317 * eval.c (struct backtrace): Simplify and port the data structure.
4318 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4319 signed bit field, as this assumption is not portable and it makes
4320 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4321 "char debug_on_exit : 1" as this is not portable either; instead,
4322 use the portable "unsigned int debug_on_exit : 1". Remove unused
4323 member evalargs. Remove obsolete comments about cc bombing out.
4325 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4327 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4328 Let HAVE_GSETTINGS override HAVE_GCONF.
4329 (store_monospaced_changed): New function.
4330 (EMACS_SETTINGS): A new type derived from GObject to handle
4331 GSettings notifications.
4332 (emacs_settings_constructor, emacs_settings_get_property)
4333 (emacs_settings_set_property, emacs_settings_class_init):
4335 (gsettings_client, gsettings_obj): New variables.
4336 (GSETTINGS_SCHEMA): New define.
4337 (something_changedCB): Call store_monospaced_changed.
4338 (init_gsettings): New function.
4339 (xsettings_initialize): Call init_gsettings.
4340 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4343 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4346 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4348 * window.c (resize_root_window, grow_mini_window)
4349 (shrink_mini_window): Rename Qresize_root_window to
4350 Qwindow_resize_root_window and Qresize_root_window_vertically to
4351 Qwindow_resize_root_window_vertically.
4353 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4355 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4357 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4359 * makefile.w32-in: Redesign dependencies so they reflect more
4360 clearly which files are directly included by each source file,
4361 and not through other includes.
4363 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4365 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4366 (sort_overlays, overlay_strings): When an overlay's clone number
4367 matches the window's clone number process the overlay even if
4368 the overlay's window property doesn't match the current window.
4370 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4371 (Fwindow_hchild): Rename to Fwindow_left_child.
4372 (Fwindow_next): Rename to Fwindow_next_sibling.
4373 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4374 (resize_window_check): Rename to window_resize_check.
4375 (resize_window_apply): Rename to window_resize_apply.
4376 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4377 (Fdelete_other_windows_internal, resize_frame_windows)
4378 (Fsplit_window_internal, Fdelete_window_internal)
4379 (grow_mini_window, shrink_mini_window)
4380 (Fresize_mini_window_internal): Fix callers accordingly.
4382 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4384 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4385 (emacs_fixed_set_min_size): Remove.
4386 (emacs_fixed_new): Take frame as argument.
4388 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4389 (_EmacsFixedPrivate): Remove minwidth/height.
4390 Add struct frame *f.
4391 (emacs_fixed_init): Initialize priv->f.
4392 (get_parent_class, emacs_fixed_set_min_size): Remove.
4393 (emacs_fixed_new): Set priv->f to argument.
4394 (emacs_fixed_get_preferred_width)
4395 (emacs_fixed_get_preferred_height): Use min_width/height from
4396 frames size_hint to set minimum and natural (Bug#8919).
4397 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4398 and use min_width/height from frames size_hint to set
4399 min_width/height (Bug#8919).
4401 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4402 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4405 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4407 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4408 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4411 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4413 * process.c (wait_reading_process_output): Bypass select if
4414 waiting for a cell while ignoring keyboard input, and input is
4415 pending. Suggested by Jan Djärv (Bug#8869).
4417 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4419 Use gnulib's dup2 module instead of rolling our own.
4420 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4422 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4424 * dispnew.c (scrolling_window): Before scrolling, turn off a
4425 mouse-highlight in the window being scrolled.
4427 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4429 Move DEFSYM to lisp.h and use everywhere.
4431 * character.h (DEFSYM): Move declaration...
4432 * lisp.h (DEFSYM): ...here.
4438 * w32select.c: Don't include character.h.
4440 * alloc.c (syms_of_alloc):
4441 * buffer.c (syms_of_buffer):
4442 * bytecode.c (syms_of_bytecode):
4443 * callint.c (syms_of_callint):
4444 * casefiddle.c (syms_of_casefiddle):
4445 * casetab.c (init_casetab_once):
4446 * category.c (init_category_once, syms_of_category):
4447 * ccl.c (syms_of_ccl):
4448 * cmds.c (syms_of_cmds):
4449 * composite.c (syms_of_composite):
4450 * dbusbind.c (syms_of_dbusbind):
4451 * dired.c (syms_of_dired):
4452 * dispnew.c (syms_of_display):
4453 * doc.c (syms_of_doc):
4454 * editfns.c (syms_of_editfns):
4455 * emacs.c (syms_of_emacs):
4456 * eval.c (syms_of_eval):
4457 * fileio.c (syms_of_fileio):
4458 * fns.c (syms_of_fns):
4459 * frame.c (syms_of_frame):
4460 * fringe.c (syms_of_fringe):
4461 * insdel.c (syms_of_insdel):
4462 * keymap.c (syms_of_keymap):
4463 * lread.c (init_obarray, syms_of_lread):
4464 * macros.c (syms_of_macros):
4465 * msdos.c (syms_of_msdos):
4466 * print.c (syms_of_print):
4467 * process.c (syms_of_process):
4468 * search.c (syms_of_search):
4469 * sound.c (syms_of_sound):
4470 * syntax.c (init_syntax_once, syms_of_syntax):
4471 * terminal.c (syms_of_terminal):
4472 * textprop.c (syms_of_textprop):
4473 * undo.c (syms_of_undo):
4474 * w32.c (globals_of_w32):
4475 * window.c (syms_of_window):
4476 * xdisp.c (syms_of_xdisp):
4477 * xfaces.c (syms_of_xfaces):
4478 * xfns.c (syms_of_xfns):
4479 * xmenu.c (syms_of_xmenu):
4480 * xsettings.c (syms_of_xsettings):
4481 * xterm.c (syms_of_xterm): Use DEFSYM.
4483 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4485 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4487 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4489 Integer and buffer overflow fixes (Bug#8873).
4491 * print.c (printchar, strout): Check for string overflow.
4492 (PRINTPREPARE, printchar, strout):
4493 Don't set size unless allocation succeeds.
4495 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4496 for sizes. Check for string overflow more accurately.
4497 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4499 * macros.c: Integer and buffer overflow fixes.
4500 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4501 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4502 Use ptrdiff_t, not int, for sizes.
4503 Don't increment bufsize until after realloc succeeds.
4504 Check for size-calculation overflow.
4505 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4507 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4509 * lread.c: Integer overflow fixes.
4510 (read_integer): Radix is now EMACS_INT, not int,
4511 to improve quality of diagnostics for out-of-range radices.
4512 Calculate buffer size correctly for out-of-range radices.
4513 (read1): Check for integer overflow in radices, and in
4514 read-circle numbers.
4515 (read_escape): Avoid int overflow.
4516 (Fload, openp, read_buffer_size, read1)
4517 (substitute_object_recurse, read_vector, read_list, map_obarray):
4518 Use ptrdiff_t, not int, for sizes.
4519 (read1): Use EMACS_INT, not int, for sizes.
4520 Check for size overflow.
4522 * image.c (cache_image): Check for size arithmetic overflow.
4524 * lread.c: Integer overflow issues.
4525 (saved_doc_string_size, saved_doc_string_length)
4526 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4527 Now ptrdiff_t, not int.
4528 (read1): Don't assume doc string length fits in int. Check for
4529 out-of-range doc string lengths.
4530 (read_list): Don't assume file position fits in int.
4531 (read_escape): Check for hex character overflow.
4533 2011-06-22 Leo Liu <sdl.web@gmail.com>
4535 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4536 Move to minibuffer.el.
4538 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4540 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4541 The following patches are for when GLYPH_DEBUG && !XASSERT.
4542 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4543 * dispnew.c (flush_stdout):
4544 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4545 Mark as externally visible.
4546 * dispnew.c (check_window_matrix_pointers): Now static.
4547 * dispnew.c (window_to_frame_vpos):
4548 * xfns.c (unwind_create_frame):
4549 * xterm.c (x_check_font): Remove unused local.
4550 * scroll.c (CHECK_BOUNDS):
4551 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4552 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4553 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4554 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4555 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4557 (debug_method_add): Use va_list and vsprintf rather than relying
4558 on undefined behavior with wrong number of arguments.
4559 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4560 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4561 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4562 since we're not interested in debugging glyphs with old libraries.
4563 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4564 GCC 4.6.0's static checking.
4566 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4568 Integer overflow and signedness fixes (Bug#8873).
4569 A few related buffer overrun fixes, too.
4571 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4573 * dispextern.h (struct face.stipple):
4574 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4575 (x_bitmap_mask, x_allocate_bitmap_record)
4576 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4577 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4578 (x_create_bitmap_from_xpm_data):
4579 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4580 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4582 * xfaces.c (load_pixmap):
4583 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4584 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4585 (.bitmaps_last, struct x_output.icon_bitmap):
4586 Use ptrdiff_t, not int, for bitmap indexes.
4587 (x_allocate_bitmap_record): Check for size overflow.
4588 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4590 Use ptrdiff_t, not int, for overlay counts.
4591 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4592 * editfns.c (overlays_around, get_pos_property):
4593 * textprop.c (get_char_property_and_overlay):
4594 * xdisp.c (next_overlay_change, note_mouse_highlight):
4595 * xfaces.c (face_at_buffer_position):
4596 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4597 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4598 (Fnext_overlay_change, Fprevious_overlay_change)
4599 (mouse_face_overlay_overlaps, Foverlays_in):
4600 Use ptrdiff_t, not int, for sizes.
4601 (overlays_at, overlays_in): Check for size-calculation overflow.
4603 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4605 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4606 (x_session_initialize): Do not assume string length fits in int.
4608 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4609 This is unlikely, but can occur if DPI is outlandish.
4611 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4612 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4614 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4615 * xrdb.c (magic_file_p, search_magic_path):
4616 Omit last arg SUFFIX; it was always 0. All callers changed.
4617 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4619 * xfont.c (xfont_match): Avoid need for strlen.
4621 * xfns.c: Don't assume strlen fits in int.
4622 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4624 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4625 not unsigned long, as we prefer signed integers. All callers changed.
4626 Detect integer overflow in repeat count.
4627 (message_dolog): Don't assume print length fits in 39 bytes.
4628 (display_mode_element): Don't assume strlen fits in int.
4630 * termcap.c: Don't assume sizes fit in int and never overflow.
4631 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4632 (gobble_line): Check for size-calculation overflow.
4634 * minibuf.c (Fread_buffer):
4635 * lread.c (intern, intern_c_string):
4636 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4637 Don't assume string length fits in int.
4639 * keyboard.c (parse_tool_bar_item):
4640 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4642 * font.c: Don't assume string length fits in int.
4643 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4644 Use ptrdiff_t, not int.
4645 (font_intern_prop): Don't assume string length fits in int.
4646 Don't assume integer property fits in fixnum.
4647 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4649 * filelock.c: Fix some buffer overrun and integer overflow issues.
4650 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4651 Reformulate so as not to need the command string.
4652 Invoke gzip -cd rather than gunzip, as it's more portable.
4653 (lock_info_type, lock_file_1, lock_file):
4654 Don't assume pid_t and time_t fit in unsigned long.
4655 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4656 (current_lock_owner): Prefer signed type for sizes.
4657 Use memcpy, not strncpy, where memcpy is what is really wanted.
4658 Don't assume (via atoi) that time_t and pid_t fit in int.
4659 Check for time_t and/or pid_t out of range, e.g., via a network share.
4660 Don't alloca where an auto var works fine.
4662 * fileio.c: Fix some integer overflow issues.
4663 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4664 Don't assume string length fits in int.
4665 (directory_file_name): Don't assume string length fits in long.
4666 (make_temp_name): Don't assume pid fits in int, or that its print
4667 length is less than 20.
4669 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4671 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4673 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4675 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4676 We prefer signed integers, even for size calculations.
4678 * emacs.c: Don't assume string length fits in 'int'.
4679 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4680 (main): Don't invoke strlen when not needed.
4682 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4683 (XD_DEBUG_MESSAGE): Don't waste a byte.
4685 * callproc.c (getenv_internal_1, getenv_internal)
4687 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4689 * lread.c (invalid_syntax): Omit length argument.
4690 All uses changed. This doesn't fix a bug, but it simplifies the
4691 code away from its former Hollerith-constant appearance, and it's
4692 one less 'int' to worry about when looking at integer-overflow issues.
4693 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4695 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4696 This didn't break anything, but it didn't help either.
4697 It's confusing to put a bogus integer in a place where the actual
4698 value does not matter.
4699 (LIST_END_P): Remove unused macro and its bogus comment.
4700 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4702 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4703 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4705 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4706 We prefer signed types, and the value cannot exceed the EMACS_INT
4707 range anyway (because otherwise the length would not be representable).
4708 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4709 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4710 This avoids a GCC warning when WIDE_EMACS_INT.
4712 * indent.c (sane_tab_width): New function.
4713 (current_column, scan_for_column, Findent_to, position_indentation)
4714 (compute_motion): Use it. This is just for clarity.
4715 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4717 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4719 * lisp.h (lint_assume): New macro.
4720 * composite.c (composition_gstring_put_cache):
4721 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4723 * editfns.c, insdel.c:
4724 Omit unnecessary forward decls, to simplify future changes.
4726 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4728 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4730 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4731 Use much-faster test for byte-length change.
4732 Don't assume string byte-length fits in 'int'.
4733 Check that character arg fits in 'int'.
4734 (mapcar1): Declare byte as byte, for clarity.
4736 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4738 * fns.c (concat): Catch string overflow earlier.
4739 Do not rely on integer wraparound.
4741 * dispextern.h (struct it.overlay_strings_charpos)
4742 (struct it.selective): Now EMACS_INT, not int.
4743 * xdisp.c (forward_to_next_line_start)
4744 (back_to_previous_visible_line_start)
4745 (reseat_at_next_visible_line_start, next_element_from_buffer):
4746 Don't arbitrarily truncate the value of 'selective' to int.
4748 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4750 * composite.c: Don't truncate sizes to 'int'.
4751 (composition_gstring_p, composition_reseat_it)
4752 (composition_adjust_point): Use EMACS_INT, not int.
4753 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4754 not EMACS_UINT, for indexes.
4756 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4758 * buffer.c: Include <verify.h>.
4759 (struct sortvec.priority, struct sortstr.priority):
4760 Now EMACS_INT, not int.
4761 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4762 (struct sortstr.size, record_overlay_string)
4763 (struct sortstrlist.size, struct sortlist.used):
4764 Don't truncate size to int.
4765 (record_overlay_string): Check for size-calculation overflow.
4766 (init_buffer_once): Check at compile-time, not run-time.
4768 2011-06-22 Jim Meyering <meyering@redhat.com>
4770 Don't leak an XBM-image-sized buffer
4771 * image.c (xbm_load): Free the image buffer after using it.
4773 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4776 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4777 that Sun C diagnosed.
4778 * fns.c (secure_hash): Fix pointer signedness issue.
4779 * intervals.c (static_offset_intervals): New function.
4780 (offset_intervals): Use it.
4782 2011-06-21 Leo Liu <sdl.web@gmail.com>
4785 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4788 * fns.c (secure_hash): Rename from crypto_hash_function and change
4789 the first arg to accept symbols.
4790 (Fsecure_hash): New primitive.
4791 (syms_of_fns): New symbols.
4793 2011-06-20 Deniz Dogan <deniz@dogan.se>
4795 * process.c (Fset_process_buffer): Clarify return value in
4798 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4800 * dispnew.c (add_window_display_history): Use BVAR.
4802 * xdisp.c (debug_method_add): Use BVAR.
4803 (check_window_end, dump_glyph_matrix, dump_glyph)
4804 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4806 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4809 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4810 check till after the cache is created in init_frame_faces.
4812 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4814 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4816 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4818 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4819 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4820 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4822 Improve buffer-overflow checking (Bug#8873).
4823 * fileio.c (Finsert_file_contents):
4824 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4825 Remove the old (too-loose) buffer overflow checks.
4826 They weren't needed, since make_gap checks for buffer overflow.
4827 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4828 The old code merely checked for Emacs fixnum overflow, and relied
4829 on undefined (wraparound) behavior. The new code avoids undefined
4830 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4832 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4833 Tune. Don't use wider integers than needed. Don't use alloca.
4834 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4836 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4838 * insdel.c, lisp.h (buffer_overflow): New function.
4839 (insert_from_buffer_1, replace_range, replace_range_2):
4840 * insdel.c (make_gap_larger):
4841 * editfns.c (Finsert_char):
4842 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4844 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4846 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4848 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4850 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4851 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4853 * fileio.c: Don't assume EMACS_INT fits in off_t.
4854 (emacs_lseek): New static function.
4855 (Finsert_file_contents, Fwrite_region): Use it.
4856 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4858 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4860 * fns.c: Don't overflow int when computing a list length.
4861 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4862 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4863 truncation on 64-bit hosts. Check for QUIT every
4864 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4865 faster and is responsive enough.
4866 (Flength): Report an error instead of overflowing an integer.
4867 (Fsafe_length): Return a float if the value is not representable
4868 as a fixnum. This shouldn't happen except in contrived situations.
4869 (Fnthcdr, Fsort): Don't assume list length fits in int.
4870 (Fcopy_sequence): Don't assume vector length fits in int.
4872 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4873 (header_size, word_size): New constants.
4874 (allocate_vectorlike): Don't check size overflow here.
4875 (allocate_vector): Check it here instead, since this is the only
4876 caller of allocate_vectorlike that could cause overflow.
4877 Check that the new vector's length is representable as a fixnum.
4879 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4880 The previous code was bogus. For example, next_almost_prime (32)
4881 returned 39, which is undesirable as it is a multiple of 3; and
4882 next_almost_prime (24) returned 25, which is a multiple of 5 so
4883 why was the code bothering to check for multiples of 7?
4885 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4887 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4889 Variadic C functions now count arguments with ptrdiff_t.
4890 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4891 Back then I didn't know that the Emacs coding style prefers signed int.
4892 Also, in the meantime I found a few more instances where arguments
4893 were being counted with int, which may truncate counts on 64-bit
4894 machines, or EMACS_INT, which may be unnecessarily wide.
4895 * lisp.h (struct Lisp_Subr.function.aMANY)
4896 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4897 Arg counts are now ptrdiff_t, not size_t.
4898 All variadic functions and their callers changed accordingly.
4899 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4900 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4901 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4902 * callint.c (Fcall_interactively): Check arg count for overflow,
4903 to avoid potential buffer overrun. Use signed char, not 'int',
4904 for 'varies' array, so that we needn't bother to check its size
4905 calculation for overflow.
4906 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4907 * eval.c (apply_lambda):
4908 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4909 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4910 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4912 * callint.c (Fcall_interactively): Don't use index var as event count.
4914 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4915 * mem-limits.h (SIZE): Remove; no longer used.
4917 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4919 Remove unnecessary casts.
4920 * xterm.c (x_term_init):
4921 * xfns.c (x_set_border_pixel):
4922 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4923 These aren't needed now that we assume ANSI C.
4925 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4926 It's more likely to cause problems (due to unsigned overflow)
4929 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4931 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4933 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4935 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4937 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4939 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4941 GLYPH_CODE_FACE returns EMACS_INT, not int.
4942 * dispextern.h (merge_faces):
4943 * xfaces.c (merge_faces):
4944 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4945 Don't assume EMACS_INT fits in int.
4947 * character.h (CHAR_VALID_P): Remove unused parameter.
4948 * fontset.c, lisp.h, xdisp.c: All uses changed.
4950 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4952 * fns.c (concat): Minor tuning based on overflow analysis.
4953 This doesn't fix any bugs. Use int to hold character, instead
4954 of constantly refetching from Emacs object. Use XFASTINT, not
4955 XINT, for value known to be a character. Don't bother comparing
4956 a single byte to 0400, as it's always less.
4958 * floatfns.c (Fexpt):
4959 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4961 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4964 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4966 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4967 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4968 incorrectly succeed when S was a string, because 4294967386 was
4969 truncated before it was used.
4971 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4972 Otherwise, an out-of-range integer could cause undefined behavior
4975 * composite.c: Use int, not EMACS_INT, for characters.
4976 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4977 EMACS_INT, for values that are known to be in character range.
4978 This doesn't fix any bugs but is the usual style inside Emacs and
4979 may generate better code on 32-bit machines.
4981 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4982 This is for reasons similar to the recent CHAR_STRING fix.
4983 * charset.c (Fencode_char): Check that character arg is actually
4984 a character. Pass an int to ENCODE_CHAR.
4985 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4986 wider than 'int', as a compile-time check to prevent future regressions
4989 * character.c (char_string): Remove unnecessary casts.
4991 Make sure a 64-bit char is never passed to CHAR_STRING.
4992 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4993 by silently ignoring the top 32 bits, allowing some values
4994 that were far too large to be valid characters.
4995 * character.h: Include <verify.h>.
4996 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4997 arguments are no wider than unsigned, as a compile-time check
4998 to prevent future regressions in this area.
5000 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5001 (Fsubst_char_in_region):
5003 * xdisp.c (decode_mode_spec_coding):
5004 Adjust to CHAR_STRING's new requirement.
5005 * editfns.c (Finsert_char, Fsubst_char_in_region):
5006 * fns.c (concat): Check that character args are actually
5007 characters. Without this test, these functions did the wrong
5008 thing with wildly out-of-range values on 64-bit hosts.
5010 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5011 These casts should not be needed on 32-bit hosts, either.
5012 * keyboard.c (read_char):
5013 * lread.c (Fload): Remove casts to unsigned.
5015 * lisp.h (UNSIGNED_CMP): New macro.
5016 This fixes comparison bugs on 64-bit hosts.
5017 (ASCII_CHAR_P): Use it.
5018 * casefiddle.c (casify_object):
5019 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5020 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5021 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5022 * dispextern.h (FACE_FROM_ID):
5023 * keyboard.c (read_char): Use UNSIGNED_CMP.
5025 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5026 not to EMACS_INT, to avoid GCC warning.
5028 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5030 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5031 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5032 isn't needed on 32-bit machines.
5034 * buffer.c (Fgenerate_new_buffer_name):
5035 Use EMACS_INT for count, not int.
5036 (advance_to_char_boundary): Return EMACS_INT, not int.
5038 * data.c (Qcompiled_function): Now static.
5040 * window.c (window_body_lines): Now static.
5042 * image.c (gif_load): Rename local to avoid shadowing.
5044 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5045 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5046 * alloc.c (make_save_value): Integer argument is now of type
5048 (mark_object): Use ptrdiff_t, not int.
5049 * lisp.h (pD): New macro.
5050 * print.c (print_object): Use it.
5052 * alloc.c: Use EMACS_INT, not int, to count objects.
5053 (total_conses, total_markers, total_symbols, total_vector_size)
5054 (total_free_conses, total_free_markers, total_free_symbols)
5055 (total_free_floats, total_floats, total_free_intervals)
5056 (total_intervals, total_strings, total_free_strings):
5057 Now EMACS_INT, not int. All uses changed.
5058 (Fgarbage_collect): Compute overall total using a double, so that
5059 integer overflow is less likely to be a problem. Check for overflow
5060 when converting back to an integer.
5061 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5062 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5063 These were 'int' variables that could overflow on 64-bit hosts;
5064 they were never used, so remove them instead of repairing them.
5065 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5066 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5067 Previously, this ceilinged at INT_MAX, but that doesn't work on
5069 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5071 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5072 (allocate_vectorlike): Check for ptrdiff_t overflow.
5073 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5074 when a (possibly-narrower) signed value would do just as well.
5075 We prefer using signed arithmetic, to avoid comparison confusion.
5077 * alloc.c: Catch some string size overflows that we were missing.
5078 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5079 for convenience in STRING_BYTES_MAX.
5080 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5081 The definition here is exact; the one in lisp.h was approximate.
5082 (allocate_string_data): Check for string overflow. This catches
5083 some instances we weren't catching before. Also, it catches
5084 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5085 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5086 and ptrdiff_t and EMACS_INT are both 64 bits.
5088 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5089 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5090 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5092 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5094 * alloc.c (Fmake_string): Check for out-of-range init.
5096 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5098 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5100 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5102 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5103 xg_get_default_scrollbar_width.
5105 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5106 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5107 (style_changed_cb): Call update_theme_scrollbar_width and call
5108 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5109 all frames (Bug#8505).
5110 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5111 Call gtk_window_set_resizable if HAVE_GTK3.
5112 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5113 and height if HAVE_GTK3 (Bug#8505).
5114 (scroll_bar_width_for_theme): New variable.
5115 (update_theme_scrollbar_width): New function.
5116 (xg_get_default_scrollbar_width): Move code to
5117 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5118 (xg_initialize): Call update_theme_scrollbar_width.
5120 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5122 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5124 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5126 * frame.c (make_frame): Call other_buffer_safely instead of
5129 * window.c (temp_output_buffer_show): Call display_buffer with
5130 second argument Vtemp_buffer_show_specifiers and reset latter
5131 immediately after the call.
5132 (Vtemp_buffer_show_specifiers): New variable.
5133 (auto_window_vscroll_p, next_screen_context_lines)
5134 (Vscroll_preserve_screen_position): Remove leading asterisks from
5137 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5139 Fix minor problems found by GCC 4.6.0 static checking.
5140 * buffer.c (Qclone_number): Remove for now, as it's unused.
5141 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5142 (record_buffer): Remove unused local.
5143 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5144 (set_frame_buffer_list): Remove; unused.
5145 * frame.h (other_visible_frames): Remove decl.
5146 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5147 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5148 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5150 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5151 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5152 Define only if HAVE_GPM.
5153 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5154 (update_hints_inhibit): Remove; never set. All uses removed.
5155 * widgetprv.h (emacsFrameClassRec): Remove decl.
5156 * window.c (delete_deletable_window): Now returns void, since it
5157 wasn't returning anything.
5158 (compare_window_configurations): Remove unused locals.
5159 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5160 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5161 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5162 the same widths as pointers. This follows up on the 2011-05-06 patch.
5163 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5164 * xterm.h: Likewise.
5165 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5167 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5169 * makefile.w32-in: Update dependencies.
5170 (LISP_H): Add lib/intprops.h.
5172 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5174 * image.c (gif_load): Add animation frame delay to the metadata.
5175 (syms_of_image): Use DEFSYM. New symbol `delay'.
5177 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5179 * window.c (delete_deletable_window): Re-add.
5180 (Fset_window_configuration): Rewrite to handle dead buffers and
5181 consequently deletable windows.
5182 (window_tree, Fwindow_tree): Remove. Supply functionality in
5184 (compare_window_configurations): Simplify code.
5186 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5188 * image.c (imagemagick_load_image): Fix type mismatch.
5189 (Fimagemagick_types): Likewise.
5191 * window.h (replace_buffer_in_windows): Declare.
5193 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5195 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5196 Qclone_number. Remove external declaration of Qdelete_window.
5197 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5199 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5200 Run Qbuffer_list_update_hook if allowed.
5201 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5202 buffer list implementation.
5203 (other_buffer_safely): New function.
5204 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5205 calls to replace_buffer_in_windows and
5206 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5208 (record_buffer): Inhibit quitting and rewrite using quittable
5209 functions. Run Qbuffer_list_update_hook if allowed.
5210 (Frecord_buffer, Funrecord_buffer): New functions.
5211 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5212 Move switch-to-buffer to window.el.
5213 (bury-buffer): Move to window.el.
5214 (Vbuffer_list_update_hook): New variable.
5216 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5219 * window.h (resize_frame_windows): Move up in code.
5220 (Fwindow_frame): Remove EXFUN.
5221 (replace_buffer_in_all_windows): Remove prototype.
5222 (replace_buffer_in_windows_safely): Add prototype.
5224 * window.c: Declare Qdelete_window static again. Move down
5225 declaration of select_count.
5226 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5227 (Fother_window): Move to window.el.
5228 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5229 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5230 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5232 (replace_buffer_in_windows): Implement by calling
5233 Qreplace_buffer_in_windows.
5234 (replace_buffer_in_all_windows): Remove with some functionality
5235 moved into replace_buffer_in_windows_safely.
5236 (replace_buffer_in_windows_safely): New function.
5237 (select_window_norecord, select_frame_norecord): Move in front
5238 of run_window_configuration_change_hook. Remove now obsolete
5240 (Fset_window_buffer): Rewrite doc-string.
5241 Call Qrecord_window_buffer.
5242 (keys_of_window): Move binding for other-window to window.el.
5244 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5246 * dispextern.h (struct image): Replace data member, whose int_val
5247 and ptr_val fields were not used by anything, with a single
5250 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5251 (gif_clear_image, gif_load, imagemagick_load_image)
5252 (gs_clear_image, gs_load): Callers changed.
5254 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5256 * buffer.h: Include <time.h>, for time_t.
5257 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5259 Fix minor problems found by static checking.
5261 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5263 Make identifiers static if they are not used in other modules.
5264 * data.c (Qcompiled_function, Qframe, Qvector):
5265 * image.c (QimageMagick, Qsvg):
5266 * minibuf.c (Qmetadata):
5267 * window.c (resize_window_check, resize_root_window): Now static.
5268 * window.h (resize_window_check, resize_root_window): Remove decls.
5270 * window.c (window_deletion_count, delete_deletable_window):
5272 (window_body_lines): Now static.
5273 (Fdelete_other_windows_internal): Mark vars as initialized.
5274 Make sure 'resize_failed' is initialized.
5275 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5276 (resize_window_apply): Remove unused local.
5277 * window.h (delete_deletable_window): Remove decl.
5279 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5280 (imagemagick_load_image): Fix pointer signedness problem by changing
5281 last arg from unsigned char * to char *. All uses changed.
5282 Also, fix a local for similar reasons.
5283 Remove unused locals. Remove locals to avoid shadowing.
5284 (fn_rsvg_handle_free): Remove; unused.
5285 (svg_load, svg_load_image): Fix pointer signedness problem.
5286 (imagemagick_load_image): Don't use garbage pointer image_wand.
5288 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5290 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5292 * image.c (gif_load): Fix omitted cast error introduced by
5295 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5297 * window.h (resize_proportionally, orig_total_lines)
5298 (orig_top_line): Remove from window structure.
5299 (set_window_height, set_window_width, change_window_heights)
5300 (Fdelete_window): Remove prototypes.
5301 (resize_frame_windows): Remove duplicate declaration.
5303 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5305 * window.h (resize_frame_windows, resize_window_check)
5306 (delete_deletable_window, resize_root_window)
5307 (resize_frame_windows): Declare prototypes.
5309 * window.c (resize_window_apply): Make definition be "static" to
5310 match the prototype.
5312 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5314 * window.c: Remove declarations of Qwindow_size_fixed,
5315 window_min_size_1, window_min_size_2, window_min_size,
5316 size_window, window_fixed_size_p, enlarge_window, delete_window.
5317 Remove static from declaration of Qdelete_window, it's
5318 temporarily needed by Fbury_buffer.
5319 (replace_window): Don't assign orig_top_line and
5321 (Fdelete_window, delete_window): Remove. Window deletion is
5322 handled by window.el.
5323 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5324 Replace Fdelete_window calls with calls to Qdelete_window.
5325 (Fdelete_other_windows): Remove. Deleting other windows is
5326 handled by window.el.
5327 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5328 handled in window.el.
5329 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5330 Window minimum sizes are handled in window.el.
5331 (shrink_windows, size_window, set_window_height)
5332 (set_window_width, change_window_heights, window_height)
5333 (window_width, CURBEG, CURSIZE, enlarge_window)
5334 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5335 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5336 handled in window.el.
5337 (make_dummy_parent): Rename to make_parent_window and give it a
5338 second argument horflag.
5339 (make_window): Don't set resize_proportionally any more.
5340 (Fsplit_window): Remove. Windows are split in window.el.
5341 (save_restore_action, save_restore_orig_size)
5342 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5343 Resize mini windows in window.el.
5344 (grow_mini_window, shrink_mini_window): Implement by calling
5345 Qresize_root_window_vertically, resize_window_check and
5346 resize_window_apply.
5347 (saved_window, Fset_window_configuration, save_window_save):
5348 Do not handle orig_top_line, orig_total_lines, and
5349 resize_proportionally.
5350 (window_min_height, window_min_width): Move to window.el.
5351 (keys_of_window): Move bindings for delete-other-windows,
5352 split-window, delete-window and enlarge-window to window.el.
5354 * buffer.c: Temporarily extern Qdelete_window.
5355 (Fbury_buffer): Temporarily call Qdelete_window instead of
5356 Fdelete_window (Fbury_buffer will move to window.el soon).
5358 * frame.c (set_menu_bar_lines_1): Remove code handling
5359 orig_top_line and orig_total_lines.
5361 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5362 set_window_height but set heights directly.
5363 (change_frame_size_1): Use resize_frame_windows.
5365 * xdisp.c (init_xdisp): Don't use set_window_height but set
5368 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5369 Use resize_frame_windows instead of change_window_heights and run
5370 run_window_configuration_change_hook.
5372 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5373 instead of change_window_heights and run
5374 run_window_configuration_change_hook.
5376 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5378 * window.c (replace_window): Rename second argument REPLACEMENT to
5379 NEW. New third argument SETFLAG. Rewrite.
5380 (delete_window, make_dummy_parent): Call replace_window with
5382 (window_list_1): Move down in code.
5383 (run_window_configuration_change_hook): Move set_buffer part
5384 before select_frame_norecord part in order to unwind correctly.
5385 Rename count1 to count.
5386 (recombine_windows, delete_deletable_window, resize_root_window)
5387 (Fdelete_other_windows_internal)
5388 (Frun_window_configuration_change_hook, make_parent_window)
5389 (resize_window_check, resize_window_apply, Fresize_window_apply)
5390 (resize_frame_windows, Fsplit_window_internal)
5391 (Fdelete_window_internal, Fresize_mini_window_internal):
5393 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5395 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5397 * window.h (window): Add some new members to window structure -
5398 normal_lines, normal_cols, new_total, new_normal, clone_number,
5399 splits, nest, prev_buffers, next_buffers.
5400 (WINDOW_TOTAL_SIZE): Move here from window.c.
5401 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5403 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5405 (make_dummy_parent): Set new members of windows structure.
5406 (make_window): Move down in code. Handle new members of window
5408 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5409 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5410 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5411 (Fset_window_prev_buffers, Fwindow_next_buffers)
5412 (Fset_window_next_buffers, Fset_window_clone_number):
5414 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5415 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5417 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5418 Argument WINDOW can be now internal window too.
5419 (Fwindow_use_time): Move up in code.
5420 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5422 (Fset_window_configuration, saved_window)
5423 (Fcurrent_window_configuration, save_window_save): Handle new
5424 members of window structure.
5425 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5426 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5427 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5428 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5429 Qget_mru_window, Qresize_root_window,
5430 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5431 Qauto_buffer_name; staticpro them.
5433 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5435 * window.c (Fwindow_total_size, Fwindow_left_column)
5436 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5437 (Fwindow_list_1): New functions.
5438 (window_box_text_cols): Replace with window_body_cols.
5439 (Fwindow_width, Fscroll_left, Fscroll_right):
5440 Use window_body_cols instead of window_box_text_cols.
5441 (delete_window, Fset_window_configuration):
5442 Call delete_all_subwindows with window as argument.
5443 (delete_all_subwindows): Take a window as argument and not a
5445 (window_loop): Remove handling of GET_LRU_WINDOW and
5447 (Fget_lru_window, Fget_largest_window): Move to window.el.
5449 * window.h: Extern window_body_cols instead of
5450 window_box_text_cols. delete_all_subwindows now takes a
5451 Lisp_Object as argument.
5453 * indent.c (compute_motion, Fcompute_motion):
5454 Use window_body_cols instead of window_box_text_cols.
5456 * frame.c (delete_frame): Call delete_all_subwindows with root
5459 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5461 * fns.c (Fputhash): Document return value.
5463 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5465 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5467 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5469 Cons<->int and similar integer overflow fixes (Bug#8794).
5471 Check for overflow when converting integer to cons and back.
5472 * charset.c (Fdefine_charset_internal, Fdecode_char):
5473 Use cons_to_unsigned to catch overflow.
5474 (Fencode_char): Use INTEGER_TO_CONS.
5475 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5476 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5477 * data.c (long_to_cons, cons_to_long): Remove.
5478 (cons_to_unsigned, cons_to_signed): New functions.
5479 These signal an error for invalid or out-of-range values.
5480 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5481 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5482 * font.c (Ffont_variation_glyphs):
5483 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5484 * lisp.h: Include <intprops.h>.
5485 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5486 (cons_to_signed, cons_to_unsigned): New decls.
5487 (long_to_cons, cons_to_long): Remove decls.
5488 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5489 (Fprimitive_undo): Use CONS_TO_INTEGER.
5490 * xfns.c (Fx_window_property): Likewise.
5491 * xselect.c: Include <limits.h>.
5492 (x_own_selection, selection_data_to_lisp_data):
5493 Use INTEGER_TO_CONS.
5494 (x_handle_selection_request, x_handle_selection_clear)
5495 (x_get_foreign_selection, Fx_disown_selection_internal)
5496 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5497 (lisp_data_to_selection_data): Use cons_to_unsigned.
5498 (x_fill_property_data): Use cons_to_signed.
5499 Report values out of range.
5501 Check for buffer and string overflow more precisely.
5502 * buffer.h (BUF_BYTES_MAX): New macro.
5503 * lisp.h (STRING_BYTES_MAX): New macro.
5504 * alloc.c (Fmake_string):
5505 * character.c (string_escape_byte8):
5506 * coding.c (coding_alloc_by_realloc):
5507 * doprnt.c (doprnt):
5508 * editfns.c (Fformat):
5510 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5511 since they may not be the same number.
5512 * editfns.c (Finsert_char):
5513 * fileio.c (Finsert_file_contents):
5514 Likewise for BUF_BYTES_MAX.
5516 * image.c: Use ptrdiff_t, not int, for sizes.
5517 (slurp_file): Switch from int to ptrdiff_t.
5519 (slurp_file): Check that file size fits in both size_t (for
5520 malloc) and ptrdiff_t (for sanity and safety).
5522 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5523 if b->modtime has its maximal value.
5525 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5527 Don't assume time_t can fit into int.
5528 * buffer.h (struct buffer.modtime): Now time_t, not int.
5529 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5530 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5532 Minor fixes for signed vs unsigned integers.
5533 * character.h (MAYBE_UNIFY_CHAR):
5534 * charset.c (maybe_unify_char):
5535 * keyboard.c (read_char, reorder_modifiers):
5536 XINT -> XFASTINT, since the integer must be nonnegative.
5537 * ftfont.c (ftfont_spec_pattern):
5538 * keymap.c (access_keymap, silly_event_symbol_error):
5539 XUINT -> XFASTINT, since the integer must be nonnegative.
5540 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5541 since it makes no difference and we prefer signed.
5542 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5543 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5546 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5548 * window.h (Fwindow_frame): Declare.
5550 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5552 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5553 (SPARE_MEMORY): Always define.
5554 (LARGE_REQUEST): Remove.
5555 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5557 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5559 * lisp.h: Move EXFUNS for Fframe_root_window,
5560 Fframe_first_window and Fset_frame_selected_window to window.h.
5562 * window.h: Move EXFUNS for Fframe_root_window,
5563 Fframe_first_window and Fset_frame_selected_window here from
5566 * frame.c (Fwindow_frame, Fframe_first_window)
5567 (Fframe_root_window, Fframe_selected_window)
5568 (Fset_frame_selected_window): Move to window.c.
5569 (Factive_minibuffer_window): Move to minibuf.c.
5570 (Fother_visible_frames_p): New function.
5572 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5574 * window.c (decode_window, decode_any_window): Move up in code.
5575 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5576 (inhibit_frame_unsplittable): Remove unused variable.
5577 (Fwindow_buffer): Move up and rewrite doc-string.
5578 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5579 (Fwindow_prev): New functions.
5580 (Fwindow_frame): Move here from frame.c. Accept any window as
5582 (Fframe_root_window, Fframe_first_window)
5583 (Fframe_selected_window): Move here from frame.c. Accept frame
5584 or arbitrary window as argument. Update doc-strings.
5585 (Fminibuffer_window): Move up in code.
5586 (Fwindow_minibuffer_p): Move up in code and simplify.
5587 (Fset_frame_selected_window): Move here from frame.c.
5589 (Fselected_window, select_window, Fselect_window): Move up in
5590 code. Minor doc-string fixes.
5592 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5594 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5595 Do not assume that spare memory exists; that assumption is valid
5596 only if SYSTEM_MALLOC.
5597 (LARGE_REQUEST): New macro, so that the issue of large requests
5598 is separated from the issue of spare memory.
5600 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5602 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5605 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5607 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5610 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5612 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5614 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5616 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5617 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5619 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5621 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5623 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5625 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5626 (x_clipboard_manager_save): Add return value.
5627 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5629 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5630 Obey Vx_select_enable_clipboard_manager. Catch errors in
5631 x_clipboard_manager_save (Bug#8779).
5632 (Vx_select_enable_clipboard_manager): New variable.
5633 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5635 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5637 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5639 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5641 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5642 in the current matrix if keep_current_p is non-zero.
5644 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5646 * bidi.c (bidi_level_of_next_char): Fix last change.
5648 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5650 Support bidi reordering of text covered by display properties.
5652 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5653 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5654 (bidi_cache_search, bidi_cache_iterator_state)
5655 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5656 (bidi_level_of_next_char, bidi_move_to_visually_next):
5657 Support character positions inside a run of characters covered by a
5659 (bidi_paragraph_init, bidi_resolve_explicit_1)
5660 (bidi_level_of_next_char): Call bidi_fetch_char and
5661 bidi_fetch_char_advance instead of FETCH_CHAR and
5663 (bidi_init_it): Initialize new members.
5664 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5666 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5667 instead of using explicit *_CHAR codes.
5668 (bidi_resolve_explicit, bidi_resolve_weak):
5669 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5670 bidirectional text is supported only in multibyte buffers.
5671 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5672 it to initialize the frame_window_p member of struct bidi_it.
5673 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5674 (bidi_resolve_explicit, bidi_resolve_weak)
5675 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5676 bidi_it->nchars is non-positive.
5677 (bidi_level_of_next_char): Don't try to lookup the cache for the
5678 next/previous character if nothing is cached there yet, or if we
5679 were just reseat()'ed to a new position.
5681 * xdisp.c (set_cursor_from_row): Set start and stop points
5682 according to the row's direction when priming the loop that looks
5683 for the glyph on which to display cursor.
5684 (single_display_spec_intangible_p): Function deleted.
5685 (display_prop_intangible_p): Reimplement to call
5686 handle_display_spec instead of single_display_spec_intangible_p.
5687 Accept 3 additional arguments needed by handle_display_spec.
5688 This fixes incorrect cursor motion across display property with complex
5689 values: lists, `(when COND...)' forms, etc.
5690 (single_display_spec_string_p): Support property values that are
5691 lists with the argument STRING its top-level element.
5692 (display_prop_string_p): Fix the condition for processing a
5693 property that is a list to be consistent with handle_display_spec.
5694 (handle_display_spec): New function, refactored from the
5695 last portion of handle_display_prop.
5696 (compute_display_string_pos): Accept additional argument
5697 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5698 value of a `display' property is a "replacing spec".
5699 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5700 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5701 the display property, but just return a value indicating whether
5702 the display property will replace the characters it covers.
5703 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5704 frame_window_p members of struct bidi_it.
5705 (compute_display_string_pos, compute_display_string_end):
5707 (push_it): Accept second argument POSITION, where pop_it should
5708 jump to continue iteration.
5709 (reseat_1): Initialize bidi_it.disp_pos.
5711 * keyboard.c (adjust_point_for_property): Adjust the call to
5712 display_prop_intangible_p to its new signature.
5714 * dispextern.h (struct bidi_it): New member frame_window_p.
5715 (bidi_init_it): Update prototypes.
5716 (display_prop_intangible_p): Update prototype.
5717 (compute_display_string_pos, compute_display_string_end):
5719 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5722 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5724 Malloc failure behavior now depends on size of allocation.
5725 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5726 * lisp.h: Change signatures accordingly.
5727 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5728 All callers changed. (Bug#8762)
5730 * gnutls.c: Use Emacs's memory allocators.
5731 Without this change, the gnutls library would invoke malloc etc.
5732 directly, which causes problems on non-SYNC_INPUT hosts, and which
5733 runs afoul of improving memory_full behavior. (Bug#8761)
5734 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5735 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5736 xfree instead of the default malloc, realloc, free.
5737 (Fgnutls_boot): No need to check for memory allocation failure,
5738 since xmalloc does that for us.
5740 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5741 * category.c (hash_get_category_set):
5742 * ccl.c (ccl_driver):
5743 * charset.c (Fdefine_charset_internal):
5744 * charset.h (struct charset.hash_index):
5745 * composite.c (get_composition_id, gstring_lookup_cache)
5746 (composition_gstring_put_cache):
5747 * composite.h (struct composition.hash_index):
5748 * dispextern.h (struct image.hash):
5749 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5750 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5751 (hashfn_equal, hashfn_user_defined, make_hash_table)
5752 (maybe_resize_hash_table, hash_lookup, hash_put)
5753 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5754 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5755 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5756 * image.c (make_image, search_image_cache, lookup_image)
5757 (xpm_put_color_table_h):
5758 * lisp.h (struct Lisp_Hash_Table):
5759 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5760 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5761 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5762 * alloc.c (allocate_vectorlike):
5763 Check for overflow in vector size calculations.
5764 * ccl.c (ccl_driver):
5765 Check for overflow when converting EMACS_INT to int.
5766 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5767 need to be updated by these changes.
5768 * fns.c (make_hash_table, maybe_resize_hash_table):
5769 Check for integer overflow with large hash tables.
5770 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5771 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5772 (SXHASH_REDUCE): New macro.
5773 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5774 Use it instead of discarding useful hash info with large hash values.
5775 (sxhash_float): New function.
5776 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5777 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5778 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5779 Rewrite to use FIXNUM_BITS, as this simplifies things.
5780 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5781 Adjust signatures to match updated version of code.
5782 (consing_since_gc): Now EMACS_INT, since a single hash table can
5783 use more than INT_MAX bytes.
5785 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5787 Make it possible to build with GCC-4.6+ -O2 -flto.
5789 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5791 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5793 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5794 Call minibuffer-inactive-mode.
5796 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5798 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5799 Update dependencies.
5801 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5803 * data.c (init_data): Remove code for UTS, this system is not
5806 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5808 Don't force ./temacs to start in terminal mode.
5810 * frame.c (make_initial_frame): Initialize faces in all cases, not
5811 only when CANNOT_DUMP is defined.
5812 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5814 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5816 * dispnew.c (add_window_display_history): Use const for the string
5817 pointer. Remove declaration, not needed.
5819 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5821 Use 'inline', not 'INLINE'.
5822 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5823 * alloc.c, fontset.c (INLINE): Remove.
5824 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5825 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5826 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5827 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5828 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5830 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5832 Make it possible to run ./temacs.
5834 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5835 syms_of_callproc does the same thing. Remove test for
5836 "initialized", do it in the caller.
5837 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5839 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5841 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5842 (read_minibuf): Use get_minibuffer.
5843 (syms_of_minibuf): Use DEFSYM.
5844 (Qmetadata): New var.
5845 * data.c (Qbuffer): Don't make it static.
5846 (syms_of_data): Use DEFSYM.
5848 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5850 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5851 (CCL_CODE_MIN): New macro.
5853 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5855 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5857 * eval.c (Qdebug): Now static.
5858 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5859 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5860 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5862 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5864 * image.c: Various fixes to ImageMagick code comments.
5865 (Fimagemagick_types): Doc fix.
5867 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5869 Minor fixes prompted by GCC 4.6.0 warnings.
5871 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5873 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5874 (x_clipboard_manager_save_all): Move extern decl to ...
5875 * xterm.h: ... here, so that it can be checked for consistency.
5877 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5879 * xselect.c (x_clipboard_manager_save_frame)
5880 (x_clipboard_manager_save_all): New functions.
5881 (Fx_clipboard_manager_save): Lisp function deleted.
5883 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5884 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5886 * xterm.h: Update prototype.
5888 2011-05-28 William Xu <william.xwl@gmail.com>
5890 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5893 2011-05-28 Jim Meyering <meyering@redhat.com>
5895 Avoid a sign-extension bug in crypto_hash_function.
5896 * fns.c (to_uchar): Define.
5897 (crypto_hash_function): Use it to convert some newly-signed
5898 variables to unsigned, to avoid sign-extension bugs. For example,
5899 without this change, (md5 "truc") would evaluate to
5900 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5901 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5902 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5904 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5906 Integer overflow fixes.
5908 * dbusbind.c: Serial number integer overflow fixes.
5909 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5910 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5911 to hold a serial number that is too large for a fixnum.
5912 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5913 Check for serial numbers out of range. Decode any serial number
5914 that was so large that it became a float. (Bug#8722)
5916 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5917 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5918 Use XFASTINT rather than XUINT when numbers are nonnegative.
5919 (xd_append_arg, Fdbus_method_return_internal):
5920 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5921 arguments, check that Lisp number is nonnegative, rather than
5922 silently wrapping negative numbers around. (Bug#8722)
5923 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5926 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5928 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5930 ccl: Add integer overflow checks.
5931 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5932 (IN_INT_RANGE): New macros.
5933 (ccl_driver): Use them to check for integer overflow when
5934 decoding a CCL program. Many of the new checks are whether XINT (x)
5935 fits in int; it doesn't always, on 64-bit hosts. The new version
5936 doesn't catch all possible integer overflows, but it's an
5937 improvement. (Bug#8719)
5939 * alloc.c (make_event_array): Use XINT, not XUINT.
5940 There's no need for unsigned here.
5942 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5943 This follows up to the 2011-05-06 change that substituted uintptr_t
5944 for EMACS_INT. This case wasn't caught back then.
5946 Rework Fformat to avoid integer overflow issues.
5947 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5948 now (part of C89). Include <verify.h>.
5949 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5950 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5951 (Fformat): Avoid the prepass trying to compute sizes; it was only
5952 approximate and thus did not catch overflow reliably. Instead, walk
5953 through the format just once, formatting and computing sizes as we go,
5954 checking for integer overflow at every step, and allocating a larger
5955 buffer as needed. Keep track separately whether the format is
5956 multibyte. Keep only the most-recently calculated precision, rather
5957 than them all. Record whether each argument has been converted to
5958 string. Use EMACS_INT, not int, for byte and char and arg counts.
5959 Support field widths and precisions larger than INT_MAX. Avoid
5960 sprintf's undefined behavior with conversion specifications such as %#d
5961 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5962 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5963 formatting out-of-range floating point numbers with int
5966 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5968 * data.c: Avoid integer truncation in expressions involving floats.
5969 * data.c: Include <intprops.h>.
5970 (arith_driver): When there's an integer overflow in an expression
5971 involving floating point, convert the integers to floating point
5972 so that the resulting value does not suffer from catastrophic
5973 integer truncation. For example, on a 64-bit host (* 4
5974 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5975 Do not rely on undefined behavior after integer overflow.
5977 merge count_size_as_multibyte, parse_str_to_multibyte
5978 * character.c, character.h (count_size_as_multibyte):
5979 Rename from parse_str_to_multibyte; all uses changed.
5980 Check for integer overflow.
5981 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5982 since it's now a duplicate of the other. This is more of
5983 a character than a buffer op, so better that it's in character.c.
5984 * fns.c, print.c: Adjust to above changes.
5986 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5988 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5990 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5992 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5993 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5994 (x_clipboard_manager_save): Now static.
5995 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5997 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5998 (crypto_hash_function): Now static.
5999 Fix pointer signedness problems. Avoid unnecessary initializations.
6001 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6003 * termhooks.h (Vselection_alist): Make it terminal-local.
6005 * terminal.c (create_terminal): Initialize it.
6007 * xselect.c: Support for clipboard managers.
6008 (Vselection_alist): Move to termhooks.h as terminal-local var.
6009 (LOCAL_SELECTION): New macro.
6010 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6011 (symbol_to_x_atom): Remove gratuitous arg.
6012 (x_handle_selection_request, lisp_data_to_selection_data)
6013 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6014 (x_own_selection, x_get_local_selection, x_convert_selection):
6015 New arg, specifying work frame. Use terminal-local Vselection_alist.
6016 (some_frame_on_display): Delete unused function.
6017 (Fx_own_selection_internal, Fx_get_selection_internal)
6018 (Fx_disown_selection_internal, Fx_selection_owner_p)
6019 (Fx_selection_exists_p): New optional frame arg.
6020 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6021 (x_handle_selection_clear): Don't treat other terminals with the
6022 same keyboard specially. Use the terminal-local Vselection_alist.
6023 (x_clear_frame_selections): Use Frun_hook_with_args.
6025 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6027 * xterm.h: Add support for those atoms.
6029 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6031 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6032 (converted_selections, conversion_fail_tag): New global variables.
6033 (x_selection_request_lisp_error): Free the above.
6034 (x_get_local_selection): Remove unnecessary code.
6035 (x_reply_selection_request): Args changed; handle arbitrary array
6036 of converted selections stored in converted_selections.
6037 Separate the XChangeProperty and SelectionNotify steps.
6038 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6039 (x_convert_selection): New function.
6040 (x_handle_selection_event): Simplify.
6041 (x_get_foreign_selection): Don't ignore incoming requests while
6042 waiting for an answer; this will fail when we implement
6043 SAVE_TARGETS, and seems unnecessary anyway.
6044 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6045 (Vx_sent_selection_functions): Doc fix.
6047 2011-05-26 Leo Liu <sdl.web@gmail.com>
6049 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6051 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6053 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6055 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6056 for fringe update if it has periodic bitmap.
6057 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6058 and fringe_bitmap_periodic_p.
6060 * fringe.c (get_fringe_bitmap_data): New function.
6061 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6062 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6063 row. Mark glyph row for fringe update if periodicity changed.
6065 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6066 for fringe update unless it has periodic bitmap.
6068 2011-05-25 Kenichi Handa <handa@m17n.org>
6070 * xdisp.c (get_next_display_element): Set correct it->face_id for
6071 a static composition.
6073 2011-05-24 Leo Liu <sdl.web@gmail.com>
6076 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6078 * fns.c (crypto_hash_function, Fsha1): New function.
6079 (Fmd5): Use crypto_hash_function.
6080 (syms_of_fns): Add Ssha1.
6082 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6084 * gnutls.c: Remove unused macros.
6085 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6086 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6087 Remove macros that are defined and never used.
6088 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6090 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6092 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6093 (Fx_get_selection_internal): Minor cleanup.
6094 (Fx_own_selection_internal): Rename arguments for consistency with
6097 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6099 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6101 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6103 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6105 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6107 * dispnew.c (scrolling_window): Don't exclude the case that the
6108 last enabled row in the desired matrix touches the bottom boundary.
6110 2011-05-21 Glenn Morris <rgm@gnu.org>
6112 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6113 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6114 and add some more files.
6116 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6118 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6119 report_file_error introduced by the change from 2011-05-07.
6121 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6123 * systime.h (Time): Define only if emacs is defined.
6124 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6125 where the include path doesn't have X11/X.h by default. See
6126 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6128 2011-05-20 Kenichi Handa <handa@m17n.org>
6130 * composite.c (find_automatic_composition): Fix previous change.
6132 2011-05-20 Glenn Morris <rgm@gnu.org>
6134 * lisp.mk: New file, split from Makefile.in.
6135 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6136 (shortlisp): Remove.
6137 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6139 2011-05-19 Glenn Morris <rgm@gnu.org>
6141 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6142 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6143 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6144 (lisp): Set the order to that of loadup.el.
6145 (shortlisp): Make it a copy of $lisp.
6146 (SOME_MACHINE_LISP): Remove.
6147 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6148 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6150 2011-05-18 Kenichi Handa <handa@m17n.org>
6152 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6153 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6154 (find_automatic_composition): Mostly rewrite for efficiency.
6156 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6158 * makefile.w32-in: Update dependencies.
6160 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6162 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6163 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6165 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6167 Fix some integer overflow issues, such as string length overflow.
6169 * insdel.c (count_size_as_multibyte): Check for string overflow.
6171 * character.c (lisp_string_width): Check for string overflow.
6172 Use EMACS_INT, not int, for string indexes and lengths; in
6173 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6174 the resulting string length overflows an EMACS_INT; instead,
6175 report a string overflow if no precision given. When checking for
6176 precision exhaustion, use a check that cannot possibly have
6177 integer overflow. (Bug#8675)
6178 * character.h (lisp_string_width): Adjust to new signature.
6180 * alloc.c (string_overflow): New function.
6181 (Fmake_string): Use it. This doesn't change behavior, but saves
6182 a few bytes and will simplify future changes.
6183 * character.c (string_escape_byte8): Likewise.
6184 * lisp.h (string_overflow): New decl.
6186 Fixups, following up to the user-interface timestamp change.
6187 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6188 for UI timestamps, instead of unsigned long.
6189 * msdos.c (mouse_get_pos): Likewise.
6190 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6191 * w32gui.h (Time): Define by including "systime.h" rather than by
6192 declaring it ourselves. (Bug#8664)
6194 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6195 * image.c (clear_image_cache): Likewise.
6197 * term.c (term_mouse_position): Don't assume time_t wraparound.
6199 Be more systematic about user-interface timestamps.
6200 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6201 and sometimes 'EMACS_UINT', to represent these timestamps.
6202 This change causes it to use 'Time' uniformly, as that's what X uses.
6203 This makes the code easier to follow, and makes it easier to catch
6204 integer overflow bugs such as Bug#8664.
6205 * frame.c (Fmouse_position, Fmouse_pixel_position):
6206 Use Time, not unsigned long, for user-interface timestamps.
6207 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6208 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6209 * keyboard.h (last_event_timestamp): Likewise.
6210 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6211 * menu.h (xmenu_show): Likewise.
6212 * term.c (term_mouse_position): Likewise.
6213 * termhooks.h (struct input_event.timestamp): Likewise.
6214 (struct terminal.mouse_position_hook): Likewise.
6215 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6216 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6217 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6218 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6220 * menu.h, termhooks.h: Include "systime.h", for Time.
6222 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6223 Don't assume that the difference between two unsigned long values
6224 can fit into an integer. At this point, we know button_down_time
6225 <= event->timestamp, so the difference must be nonnegative, so
6226 there's no need to cast the result if double-click-time is
6227 nonnegative, as it should be; check that it's nonnegative, just in
6228 case. This bug is triggered when events are more than 2**31 ms
6229 apart (about 25 days). (Bug#8664)
6231 * xselect.c (last_event_timestamp): Remove duplicate decl.
6232 (x_own_selection): Remove needless cast to unsigned long.
6234 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6235 that always fit in int. Use a sentinel instead of a counter, to
6236 avoid a temp and to allay GCC's concerns about possible int overflow.
6237 * frame.h (struct frame): Use int for menu_bar_items_used
6238 instead of EMACS_INT, since it always fits in int.
6240 * menu.c (grow_menu_items): Check for int overflow.
6242 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6244 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6245 Before, the code was not consistent. These values cannot exceed
6246 2**31 - 1 so there's no need to make them unsigned.
6247 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6248 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6249 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6251 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6253 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6254 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6255 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6256 presumably because the widths might not match.
6258 * window.c (size_window): Avoid needless test at loop start.
6260 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6262 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6264 2011-05-12 Drew Adams <drew.adams@oracle.com>
6266 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6268 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6270 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6271 `width' to `bar_area_x' and `bar_area_width', respectively.
6272 (x_scroll_run): Take account of fringe background extension.
6274 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6275 Rename local vars `left' and `width' to `bar_area_x' and
6276 `bar_area_width', respectively.
6277 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6278 background extension.
6280 2011-05-10 Jim Meyering <meyering@redhat.com>
6282 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6284 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6286 * image.c (Finit_image_library): Return t for built-in image types,
6287 like pbm and xbm. (Bug#8640)
6289 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6291 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6293 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6295 * w32console.c (Fset_screen_color): Doc fix.
6296 (Fget_screen_color): New function.
6297 (syms_of_ntterm): Defsubr it.
6299 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6300 unlink the temporary file if Fcall_process didn't create it in the
6302 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6303 child process will be redirected to a file specified with `:file'.
6304 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6305 cue to call_process_cleanup not to close that handle.
6307 2011-05-07 Ben Key <bkey76@gmail.com>
6309 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6310 one of two shell specific rules, either bootstrap-temacs-CMD or
6311 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6312 to the previous implementation of the bootstrap-temacs rule.
6313 The bootstrap-temacs-CMD rule is similar to the previous
6314 implementation of the bootstrap-temacs rule except that it
6315 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6318 These changes, along with some changes to nt/configure.bat,
6319 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6320 earlier fix to add support for --cflags and --ldflags options
6321 that include quotes so that it works whether make uses cmd or
6324 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6326 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6327 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6329 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6330 a string. Handle both cases.
6331 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6332 (Fdbus_register_method): Use Qinvalid_function.
6334 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6336 * makefile.w32-in: Update dependencies.
6337 (LISP_H): Add inttypes.h and stdin.h.
6338 (PROCESS_H): Add unistd.h.
6340 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6342 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6343 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6345 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6347 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6349 * term.c (vfatal): Remove stray call to va_end.
6350 It's not needed and the C Standard doesn't allow it here anyway.
6352 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6353 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6355 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6358 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6360 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6362 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6364 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6366 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6368 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6369 * charset.c (Fdefine_charset_internal): Don't initialize
6370 charset.code_space[15]. The value was garbage, on hosts with
6371 32-bit int (Bug#8600).
6373 * lread.c (read_integer): Be more consistent with string-to-number.
6374 Use string_to_number to do the actual conversion; this avoids
6375 rounding errors and fixes some other screwups. Without this fix,
6376 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6377 (digit_to_number): Move earlier, for benefit of read_integer.
6378 Return -1 if the digit is out of range for the base, -2 if it is
6379 not a digit in any supported base. (Bug#8602)
6381 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6383 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6384 to match comment at start of function. This also removes a
6385 GCC warning about overflow in a 32+64-bit port.
6387 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6389 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6390 Reported by Stefan Monnier in
6391 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6392 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6393 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6395 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6396 (EMACS_UINTPTR): Likewise, with uintptr_t.
6398 * lisp.h: Prefer 64-bit EMACS_INT if available.
6399 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6400 on 32-bit hosts that have 64-bit int, so that they can access
6402 However, temporarily disable this change unless the temporary
6403 symbol WIDE_EMACS_INT is defined.
6405 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6407 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6408 This removes an assumption that EMACS_INT and long are the same
6409 width as pointers. The assumption is true for Emacs porting targets
6410 now, but we want to make other targets possible.
6411 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6412 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6413 In the rest of the code, change types of integers that hold casted
6414 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6415 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6416 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6417 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6418 No need to cast type when ORing.
6419 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6420 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6421 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6422 assume EMACS_INT is the same width as char *.
6423 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6424 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6425 Remove no-longer-needed casts.
6426 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6427 (xg_tool_bar_help_callback, xg_make_tool_item):
6428 Use EMACS_INTPTR to hold an integer
6429 that will be cast to void *; this can avoid a GCC warning
6430 if EMACS_INT is not the same width as void *.
6431 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6432 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6433 (current_message_1, set_message_1):
6434 Use a local to convert to proper width without a cast.
6435 * xmenu.c (dialog_selection_callback): Likewise.
6437 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6438 Also, don't assume VALBITS / RAND_BITS is less than 5,
6439 and don't rely on undefined behavior when shifting a 1 left into
6441 * lisp.h (get_random): Change signature to match.
6443 * lread.c (hash_string): Use size_t, not int, for hash computation.
6444 Normally we prefer signed values; but hashing is special, because
6445 it's better to use unsigned division on hash table sizes so that
6446 the remainder is nonnegative. Also, size_t is the natural width
6447 for hashing into memory. The previous code used 'int', which doesn't
6448 retain enough info to hash well into very large tables.
6449 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6451 * dbusbind.c: Don't possibly lose pointer info when converting.
6452 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6453 Use XPNTR rather than XHASH, so that the high-order bits of
6454 the pointer aren't lost when converting through void *.
6456 * eval.c (Fautoload): Don't double-shift a pointer.
6458 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6460 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6462 * gnutls.c (DEF_GNUTLS_FN):
6463 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6465 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6467 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6470 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6472 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6473 New version that can reserve upto 2GB of heap space.
6475 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6477 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6479 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6481 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6482 `gnutls_certificate_set_x509_key_file'.
6484 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6486 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6487 Update dependencies.
6489 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6491 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6492 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6493 Remove unused parameter `fildes'.
6494 * process.c (read_process_output, send_process): Don't pass it.
6496 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6498 Fix previous change: the library cache is defined in w32.c.
6499 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6500 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6502 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6504 Implement dynamic loading of GnuTLS on Windows.
6506 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6507 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6508 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6511 * gnutls.c (Qgnutls_dll): Define.
6512 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6513 (gnutls_*): Declare function pointers.
6514 (init_gnutls_functions): New function to initialize function pointers.
6515 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6516 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6517 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6518 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6519 (emacs_gnutls_write, emacs_gnutls_read)
6520 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6521 (Fgnutls_available_p): New function.
6522 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6523 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6524 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6526 * image.c: Include w32.h.
6527 (Vimage_type_cache): Delete.
6528 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6529 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6530 (w32_delayed_load): Move to w32.c.
6532 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6534 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6535 (w32_delayed_load): Move from image.c. When loading a library, record
6536 its filename in the :loaded-from property of the library id.
6537 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6538 Initialize and staticpro them.
6539 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6541 * process.c: Include lisp.h before w32.h, not after.
6542 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6543 instead of gnutls_record_check_pending.
6545 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6547 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6549 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6550 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6553 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6555 * xterm.c (x_set_frame_alpha): Do not set property on anything
6556 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6558 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6560 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6562 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6564 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6565 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6566 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6567 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6568 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6569 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6570 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6571 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6572 (Qgnutls_bootprop_callbacks_verify): Make static.
6574 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6576 * callproc.c: Indentation fixup.
6578 * sysdep.c (wait_for_termination_1): Make static.
6579 (wait_for_termination, interruptible_wait_for_termination):
6580 Move after wait_for_termination_1.
6582 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6584 * sysdep.c (interruptible_wait_for_termination): New function
6585 which is like wait_for_termination, but allows keyboard
6588 * callproc.c (Fcall_process): Add (:file "file") as an option for
6590 (Fcall_process_region): Ditto.
6592 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6594 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6595 rather than `XVECTOR (FOO)->size'.
6597 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6598 inttypes.h, as a gnulib replacement is used if it not available in
6601 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6603 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6604 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6605 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6607 * coding.c (coding_alloc_by_realloc): Error out if destination
6608 will grow beyond MOST_POSITIVE_FIXNUM.
6609 (decode_coding_emacs_mule): Abort if there isn't enough place in
6610 charbuf for the composition carryover bytes. Reserve an extra
6611 space for up to 2 characters produced in a loop.
6612 (decode_coding_iso_2022): Abort if there isn't enough place in
6613 charbuf for the composition carryover bytes.
6615 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6617 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6618 aborting when %lld or %lll format is passed.
6619 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6620 %llo or %llx format is passed. (Bug#8545)
6622 * window.c (window_scroll_line_based): Use a marker instead of
6623 simple variables to record original value of point. (Bug#7952)
6625 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6626 produced by %s or %c overflows available buffer space. (Bug#8545)
6628 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6630 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6631 (SIZE_MAX): Move defn after all includes, as they might #define it.
6633 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6635 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6637 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6639 * keyboard.c (Qdelayed_warnings_hook): Define.
6640 (command_loop_1): Run `delayed-warnings-hook'
6641 if Vdelayed_warnings_list is non-nil.
6642 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6643 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6645 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6647 * doprnt.c (doprnt): Don't return value smaller than the buffer
6648 size if the message was truncated. (Bug#8545).
6650 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6652 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6653 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6655 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6657 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6659 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6661 * makefile.w32-in: Update dependencies.
6663 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6665 Improve `doprnt' and its usage. (Bug#8545)
6666 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6667 `format_end'. Remove support for %l as a conversion specifier.
6668 Don't use xrealloc. Improve diagnostics when the %l size modifier
6669 is used. Update the commentary.
6671 * eval.c (verror): Simplify calculation of size_t.
6673 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6676 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6678 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6681 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6683 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6684 This makes this file independent of the recent pseudovector change.
6686 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6688 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6690 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6691 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6692 Remove unused local.
6693 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6695 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6696 GCC 4.6.0 optimizes based on type-based alias analysis.
6697 For example, if b is of type struct buffer * and v of type struct
6698 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6699 != &v->size, and therefore "v->size = 1; b->size = 2; return
6700 v->size;" must therefore return 1. This assumption is incorrect
6701 for Emacs, since it type-puns struct Lisp_Vector * with many other
6702 types. To fix this problem, this patch adds a new type struct
6703 vectorlike_header that documents the constraints on layout of vectors
6704 and pseudovectors, and helps optimizing compilers not get fooled
6705 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6706 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6707 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6709 (XSETPVECTYPE): Rewrite in terms of new macro.
6710 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6711 This is a bit clearer, and further avoids the possibility of
6712 undesirable aliasing.
6713 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6714 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6715 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6716 since Lisp_Subr is a special case (no "next" field).
6717 (ASIZE): Now uses header.size rather than size.
6718 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6719 to avoid the hassle of writing XVECTOR (foo)->header.size.
6720 (struct vectorlike_header): New type.
6721 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6722 object, to help avoid aliasing.
6723 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6724 (SUBRP): Likewise, since Lisp_Subr is a special case.
6725 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6726 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6727 (struct Lisp_Hash_Table): Combine first two members into a single
6728 struct vectorlike_header member. All uses of "size" and "next" members
6729 changed to be "header.size" and "header.next".
6730 * buffer.h (struct buffer): Likewise.
6731 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6732 * frame.h (struct frame): Likewise.
6733 * process.h (struct Lisp_Process): Likewise.
6734 * termhooks.h (struct terminal): Likewise.
6735 * window.c (struct save_window_data, struct saved_window): Likewise.
6736 * window.h (struct window): Likewise.
6737 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6738 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6739 * buffer.c (init_buffer_once): Likewise.
6740 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6742 * process.c (Fformat_network_address): Use local var for size,
6745 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6747 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6748 * data.c (atof): Remove decl; no longer used or needed.
6749 (digit_to_number): Move to lread.c.
6750 (Fstring_to_number): Use new string_to_number function, to be
6751 consistent with how the Lisp reader treats infinities and NaNs.
6752 Do not assume that floating-point numbers represent EMACS_INT
6753 without losing information; this is not true on most 64-bit hosts.
6754 Avoid double-rounding errors, by insisting on integers when
6755 parsing non-base-10 numbers, as the documentation specifies.
6756 * lisp.h (string_to_number): New decl, replacing ...
6757 (isfloat_string): Remove.
6758 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6759 (read1): Do not accept +. and -. as integers; this
6760 appears to have been a coding error. Similarly, do not accept
6761 strings like +-1e0 as floating point numbers. Do not report
6762 overflow for integer overflows unless the base is not 10 which
6763 means we have no simple and reliable way to continue.
6764 Break out the floating-point parsing into a new
6765 function string_to_number, so that Fstring_to_number parses
6766 floating point numbers consistently with the Lisp reader.
6767 (digit_to_number): Move here from data.c. Make it static inline.
6768 (E_CHAR, EXP_INT): Remove, replacing with ...
6769 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6770 (string_to_number): New function, replacing isfloat_string.
6771 This function checks for valid syntax and produces the resulting
6772 Lisp float number too. Rework it so that string-to-number
6773 no longer mishandles examples like "1.0e+". Use strtoumax,
6774 so that overflow for non-base-10 numbers is reported only when
6775 there's no portable and simple way to convert to floating point.
6777 * textprop.c (set_text_properties_1): Rewrite for clarity,
6778 and to avoid GCC warning about integer overflow.
6780 * intervals.h (struct interval): Use EMACS_INT for members
6781 where EMACS_UINT might cause problems. See
6782 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6783 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6784 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6786 (offset_intervals): Tell GCC not to worry about length overflow
6787 when negating a negative length.
6789 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6790 (overrun_check_free): Likewise.
6792 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6793 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6796 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6797 (gnutls_make_error): Rename local to avoid shadowing.
6798 (gnutls_emacs_global_deinit): ifdef out; not used.
6799 (Fgnutls_boot): Use const for pointer to readonly storage.
6800 Comment out unused local. Fix pointer signedness problems.
6802 * lread.c (openp): Don't stuff size_t into an 'int'.
6803 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6804 about possible signed overflow.
6806 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6807 (GDK_KEY_g): Don't define if already defined.
6808 (xg_prepare_tooltip): Avoid pointer signedness problem.
6809 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6811 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6812 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6814 * xfns.c (Fx_window_property): Simplify a bit,
6815 to make a bit faster and to avoid GCC 4.6.0 warning.
6816 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6818 * fns.c (internal_equal): Don't assume size_t fits in int.
6820 * alloc.c (compact_small_strings): Tighten assertion a little.
6822 Replace pEd with more-general pI, and fix some printf arg casts.
6823 * lisp.h (pI): New macro, generalizing old pEd macro to other
6824 conversion specifiers. For example, use "...%"pI"d..." rather
6825 than "...%"pEd"...".
6826 (pEd): Remove. All uses replaced with similar uses of pI.
6827 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6828 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6829 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6830 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6831 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6832 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6833 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6835 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6836 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6837 * print.c (safe_debug_print, print_object): Likewise.
6838 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6840 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6841 avoiding the 0 flag, which is not portable.
6842 * process.c (Fmake_network_process): Use pI to avoid cast.
6843 * region-cache.c (pp_cache): Likewise.
6844 * xdisp.c (decode_mode_spec): Likewise.
6845 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6846 behavior on 64-bit hosts with printf arg.
6847 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6848 (x_stop_queuing_selection_requests): Likewise.
6849 (x_get_window_property): Don't truncate byte count to an 'int'
6852 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6853 here, since it parses constructs like leading '-' and spaces,
6854 which are not wanted; and it overflows with large numbers.
6855 Instead, simply match F[0-9]+, which is what is wanted anyway.
6857 * alloc.c: Remove unportable assumptions about struct layout.
6858 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6859 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6860 (allocate_vectorlike, make_pure_vector): Use the new macros,
6861 plus offsetof, to remove unportable assumptions about struct layout.
6862 These assumptions hold on all porting targets that I know of, but
6863 they are not guaranteed, they're easy to remove, and removing them
6864 makes further changes easier.
6866 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6867 This doesn't fix a bug but makes the code clearer.
6868 (string_overrun_cookie): Now const. Use initializers that
6869 don't formally overflow signed char, to avoid warnings.
6870 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6871 can cause Emacs to crash when string overrun checking is enabled.
6872 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6873 multiple of sizeof (EMACS_INT); it need not be, if
6874 alignof(EMACS_INT) < sizeof (EMACS_INT).
6875 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6877 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6879 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6881 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6883 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6884 supposed to be handshaking. (Bug#8556)
6885 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6887 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6889 * lisp.h (Qdebug): List symbol.
6890 * eval.c (Qdebug): Restore global linkage.
6891 * keyboard.c (debug-on-event): New variable.
6892 (handle_user_signal): Break into debugger when debug-on-event
6893 matches the current signal symbol.
6895 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6897 * alloc.c (check_sblock, check_string_bytes)
6898 (check_string_free_list): Convert to standard C.
6900 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6902 * w32.c (emacs_gnutls_push): Fix typo.
6904 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6906 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6907 "cast to pointer from integer of different size".
6909 Improve doprnt and its use in verror. (Bug#8545)
6910 * doprnt.c (doprnt): Document the set of format control sequences
6911 supported by the function. Use SAFE_ALLOCA instead of always
6914 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6915 is one byte too soon. Don't use xrealloc; instead xfree and
6918 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6920 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6923 * gnutls.c: Renamed global_initialized to
6924 gnutls_global_initialized. Added internals for the
6925 :verify-hostname-error, :verify-error, and :verify-flags
6926 parameters of `gnutls-boot' and documented those parameters in the
6927 docstring. Start callback support.
6928 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6929 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6930 on error. Return error code.
6931 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6932 (emacs_gnutls_read): Likewise.
6933 (Fgnutls_boot): Return handshake error code.
6934 (emacs_gnutls_handle_error): New function.
6935 (wsaerror_to_errno): Likewise.
6937 * w32.h (emacs_gnutls_pull): Add prototype.
6938 (emacs_gnutls_push): Likewise.
6940 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6941 (emacs_gnutls_push): Likewise.
6943 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6945 * process.c (wait_reading_process_output): Check if GnuTLS
6946 buffered some data internally if no FDs are set for TLS
6949 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6950 (LIBS): Link to USER_LIBS.
6951 ($(BLD)/gnutls.$(0)): New target.
6953 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6955 * xdisp.c (handle_single_display_spec): Rename the
6956 display_replaced_before_p argument into display_replaced_p, to
6957 make it consistent with the commentary. Fix typos in the
6960 * textprop.c (syms_of_textprop): Remove dead code.
6961 (copy_text_properties): Delete obsolete commentary about an
6962 interface that was deleted long ago. Fix typos in the description
6965 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6966 to changes in oldXMenu/XMenu.h from 2011-04-16.
6967 <menu_help_message, prev_menu_help_message>: Constify.
6968 (IT_menu_make_room): menu->help_text is now `const char **';
6971 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6972 to changes in oldXMenu/XMenu.h from 2011-04-16.
6973 (struct XMenu): Declare `help_text' `const char **'.
6975 * xfaces.c <Qunspecified>: Make extern again.
6977 * syntax.c: Include sys/types.h before including regex.h, as
6980 * doc.c (get_doc_string): Improve the format passed to `error'.
6982 * doprnt.c (doprnt): Improve commentary.
6984 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6986 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6989 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6990 changes in globals.h immediately force recompilation.
6991 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6992 $(CURDIR)/s/ms-w32.h.
6993 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6995 * character.c (Fchar_direction): Function deleted.
6996 (syms_of_character): Don't defsubr it.
6997 <char-direction-table>: Deleted.
6999 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7001 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7002 * doprnt.c: Include limits.h.
7003 (SIZE_MAX): New macro.
7004 (doprnt): Return a size_t value. 2nd arg is now size_t.
7005 Many local variables are now size_t instead of int or unsigned.
7006 Improve overflow protection. Support `l' modifier for integer
7007 conversions. Support %l conversion. Don't assume an EMACS_INT
7008 argument for integer conversions and for %c.
7010 * lisp.h (doprnt): Restore prototype.
7012 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7015 * Makefile.in (base_obj): Add back doprnt.o.
7017 * deps.mk (doprnt.o): Add back prerequisites.
7018 (callint.o): Depend on character.h.
7020 * eval.c (internal_lisp_condition_case): Include the handler
7021 representation in the error message.
7022 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7023 when breaking from the loop.
7025 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7027 * callint.c (Fcall_interactively): When displaying error message
7028 about invalid control letter, pass the character's codepoint, not
7029 a pointer to its multibyte form. Improve display of the character
7030 in octal and display also its hex code.
7032 * character.c (char_string): Use %x to display the (unsigned)
7033 codepoint of an invalid character, to avoid displaying a bogus
7036 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7037 `error', not SYMBOL_NAME itself.
7039 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7040 character arguments to `error'.
7042 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7043 to `error' in error message about FINAL_CHAR argument. Make sure
7044 FINAL_CHAR is a character, and use %c when it is passed as
7045 argument to `error'.
7047 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7049 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7051 * w32.c: Include <time.h>.
7052 (sys_localtime): New function.
7054 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7056 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7058 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7060 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7062 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7065 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7067 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7068 gl_state.e_property when gl_state.object is Qt.
7070 * insdel.c (make_gap_larger): Remove limitation of buffer size
7073 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7075 * xdisp.c (lookup_glyphless_char_display)
7076 (produce_glyphless_glyph): Handle cons cell entry in
7077 glyphless-char-display.
7078 (Vglyphless_char_display): Document it.
7080 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7081 glyphless-char-display.
7083 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7085 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7087 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7089 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7090 definition for no-X builds.
7092 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7094 Static checks with GCC 4.6.0 and non-default toolkits.
7096 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7098 * process.c (keyboard_bit_set): Define only if SIGIO.
7099 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7100 (send_process): Repair possible setjmp clobbering.
7102 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7104 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7106 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7108 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7109 Define only if needed.
7111 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7112 by pacifying GCC about it. Maybe it's time to retire it?
7113 * xfaces.c (USG, __TIMEVAL__): Likewise.
7115 * dispextern.h (struct redisplay_interface): Rename param
7117 * termhooks.h (struct terminal): Likewise.
7118 * xterm.c (xembed_send_message): Likewise.
7120 * insdel.c (make_gap_smaller): Define only if
7121 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7123 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7126 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7127 so that we aren't warned about unused symbols.
7129 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7131 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7133 * xfns.c (x_real_positions): Mark locals as initialized.
7135 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7137 * xterm.c: Fix problems found by static analysis with other toolkits.
7138 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7139 (x_dispatch_event): Declare static if USE_GTK, and
7140 define if USE_GTK || USE_X_TOOLKIT.
7141 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7142 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7143 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7144 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7146 * xmenu.c (menu_help_callback): Pointer type fixes.
7147 Use const pointers when pointing at readonly data. Avoid pointer
7149 (FALSE): Remove unused macro.
7150 (update_frame_menubar): Remove unused decl.
7152 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7154 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7155 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7156 (single_menu_item): Rename local to avoid shadowing.
7158 * keyboard.c (make_lispy_event): Remove unused local var.
7160 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7161 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7163 * bitmaps: Change bitmaps from unsigned char back to the X11
7164 compatible char. Avoid the old compiler warnings about
7165 out-of-range initializers by using, for example, '\xab' rather
7168 * xgselect.c (xgselect_initialize): Check vs interface
7169 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7171 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7173 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7174 to read-only memory.
7176 * fns.c (vector): Remove; this old hack is no longer needed.
7178 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7180 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7182 * xrdb.c (x_load_resources): Omit unused local.
7184 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7185 (x_window): Rename locals to avoid shadowing.
7186 (USG): Use the kludged USG macro, to pacify gcc.
7188 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7189 (x_term_init): Remove local to avoid shadowing.
7191 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7193 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7194 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7196 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7198 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7200 Fix regex.c, syntax.c and friends for buffers > 2GB.
7201 * syntax.h (struct gl_state_s): Declare character position members
7204 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7206 * textprop.c (verify_interval_modification, interval_of):
7207 Declare arguments EMACS_INT.
7209 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7212 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7214 * indent.c (Fvertical_motion): Local variable it_start is now
7217 * regex.c (re_match, re_match_2, re_match_2_internal)
7218 (bcmp_translate, regcomp, regexec, print_double_string)
7219 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7220 (re_compile_pattern, re_exec): Declare arguments and local
7221 variables `size_t' and `ssize_t' and return values `regoff_t', as
7223 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7224 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7225 <compile_stack_type>: `size' and `avail' are now `size_t'.
7227 * regex.h <regoff_t>: Use ssize_t, not int.
7228 (re_search, re_search_2, re_match, re_match_2): Arguments that
7229 specify buffer/string position and length are now ssize_t and
7230 size_t. Return type is regoff_t.
7232 2011-04-16 Ben Key <bkey76@gmail.com>
7234 * nsfont.m: Fixed bugs in ns_get_family and
7235 ns_descriptor_to_entity that were caused by using free to
7236 deallocate memory blocks that were allocated by xmalloc (via
7237 xstrdup). This caused Emacs to crash when compiled with
7238 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7239 --enable-checking=xmallocoverrun). xfree is now used to
7240 deallocate these memory blocks.
7242 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7244 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7246 emacs_write: Accept and return EMACS_INT for sizes.
7247 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7249 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7250 Accept and return EMACS_INT.
7251 (emacs_gnutls_write): Return the number of bytes written on
7253 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7254 (emacs_read, emacs_write): Remove check for negative size, as the
7255 Emacs source code has been audited now.
7256 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7257 (emacs_read, emacs_write): Use it.
7258 * process.c (send_process): Adjust to the new signatures of
7259 emacs_write and emacs_gnutls_write. Do not attempt to store
7260 a byte offset into an 'int'; it might overflow.
7261 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7263 * sound.c: Don't assume sizes fit in 'int'.
7264 (struct sound_device.period_size, alsa_period_size):
7265 Return EMACS_INT, not int.
7266 (struct sound_device.write, vox_write, alsa_write):
7267 Accept EMACS_INT, not int.
7268 (wav_play, au_play): Use EMACS_INT to store sizes and to
7269 record read return values.
7271 2011-04-15 Ben Key <bkey76@gmail.com>
7273 * keyboard.c (Qundefined): Don't declare static since it is used
7275 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7276 static since they are used in nsfont.m.
7278 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7280 * process.c (Qprocessp): Don't declare static.
7281 * lisp.h (Qprocessp): Declare again.
7283 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7285 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7287 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7289 Improve C-level modularity by making more things 'static'.
7291 Don't publish debugger-only interfaces to other modules.
7292 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7293 (verify_bytepos, count_markers): Move decls to the only modules
7295 * region-cache.h (pp_cache): Likewise.
7296 * window.h (check_all_windows): Likewise.
7297 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7299 * sysdep.c (croak): Now static, if
7300 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7301 * syssignal.h (croak): Declare only if not static.
7303 * alloc.c (refill_memory_reserve): Now static if
7304 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7305 * lisp.h (refill_memory_reserve): Declare only if not static.
7307 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7308 Define only if USE_LUCID.
7310 * xrdb.c (x_customization_string, x_rm_string): Now static.
7312 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7313 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7315 * xdisp.c (draw_row_with_mouse_face): Now static.
7316 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7318 * window.h (check_all_windows): Mark externally visible.
7320 * window.c (window_deletion_count): Now static.
7322 * undo.c: Make symbols static if they're not exported.
7323 (last_undo_buffer, last_boundary_position, pending_boundary):
7326 * textprop.c (interval_insert_behind_hooks): Now static.
7327 (interval_insert_in_front_hooks): Likewise.
7329 * term.c: Make symbols static if they're not exported.
7330 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7331 (max_frame_lines, tty_set_terminal_modes):
7332 (tty_reset_terminal_modes, tty_turn_off_highlight):
7333 (get_tty_terminal): Now static.
7334 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7335 * termhooks.h (term_mouse_moveto): Do not declare if
7337 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7338 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7340 * sysdep.c: Make symbols static if they're not exported.
7341 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7343 (sigprocmask_set, full_mask): Remove; unused.
7344 (wait_debugging): Mark as visible.
7345 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7346 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7348 * syntax.c (syntax_temp): Define only if !__GNUC__.
7350 * sound.c (current_sound_device, current_sound): Now static.
7352 * search.c (searchbufs, searchbuf_head): Now static.
7354 * scroll.c (scroll_cost): Remove; unused.
7355 * dispextern.h (scroll_cost): Remove decl.
7357 * region-cache.h (pp_cache): Mark as externally visible.
7359 * process.c: Make symbols static if they're not exported.
7360 (process_tick, update_tick, create_process, chan_process):
7361 (Vprocess_alist, proc_buffered_char, datagram_access):
7362 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7363 (deactivate_process): Mark defn as static, as well as decl.
7364 * lisp.h (create_process): Remove decl.
7365 * process.h (chan_process, Vprocess_alist): Remove decls.
7367 * print.c: Make symbols static if they're not exported.
7368 (print_depth, new_backquote_output, being_printed, print_buffer):
7369 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7370 (print_interval, print_number_index, initial_stderr_stream):
7372 * lisp.h (Fprinc): Remove decl.
7373 (debug_output_compilation_hack): Mark as externally visible.
7375 * sysdep.c (croak): Move decl from here to syssignal.h.
7376 * syssignal.h (croak): Put it here, so the API can be checked when
7377 'croak' is called from dissociate_if_controlling_tty.
7379 * minibuf.c: Make symbols static if they're not exported.
7380 (minibuf_save_list, choose_minibuf_frame): Now static.
7381 * lisp.h (choose_minibuf_frame): Remove decl.
7383 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7385 * lread.c: Make symbols static if they're not exported.
7386 (read_objects, initial_obarray, oblookup_last_bucket_number):
7388 (make_symbol): Remove; unused.
7389 * lisp.h (initial_obarray, make_symbol): Remove decls.
7391 * keyboard.c: Make symbols static if they're not exported.
7392 (single_kboard, recent_keys_index, total_keys, recent_keys):
7393 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7394 (this_single_command_key_start, echoing, last_auto_save):
7395 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7396 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7397 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7398 (Vlispy_mouse_stem, double_click_count):
7400 (force_auto_save_soon): Define only if SIGDANGER.
7401 (ignore_mouse_drag_p): Now static if
7402 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7403 (print_help): Remove; unused.
7404 (stop_character, last_timer_event): Mark as externally visible.
7405 * keyboard.h (ignore_mouse_drag_p): Declare only if
7406 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7407 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7408 * lisp.h (echoing): Remove decl.
7409 (force_auto_save_soon): Declare only if SIGDANGER.
7410 * xdisp.c (redisplay_window): Simplify code, to make it more
7411 obvious that ignore_mouse_drag_p is not accessed if !defined
7412 USE_GTK && !defined HAVE_NS.
7414 * intervals.c: Make symbols static if they're not exported.
7415 (merge_properties_sticky, merge_interval_right, delete_interval):
7417 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7419 * insdel.c: Make symbols static if they're not exported.
7420 However, leave prepare_to_modify_buffer alone. It's never
7421 called from outside this function, but that appears to be a bug.
7422 (combine_after_change_list, combine_after_change_buffer):
7423 (adjust_after_replace, signal_before_change): Now static.
7424 (adjust_after_replace_noundo): Remove; unused.
7425 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7426 (signal_before_change): Remove decls.
7428 * indent.c (val_compute_motion, val_vmotion): Now static.
7430 * image.c: Make symbols static if they're not exported.
7431 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7433 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7434 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7436 * fringe.c (standard_bitmaps): Now static.
7437 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7439 * frame.c: Make symbols static if they're not exported.
7440 (x_report_frame_params, make_terminal_frame): Now static.
7441 (get_frame_param): Now static, unless HAVE_NS.
7442 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7443 (x_get_resource_string): Remove; not used.
7444 * frame.h (make_terminal_frame, x_report_frame_params):
7445 (x_get_resource_string); Remove decls.
7446 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7447 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7449 * font.c, fontset.c: Make symbols static if they're not exported.
7450 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7451 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7452 * font.c (font_close_object): Now static.
7453 * font.h (font_close_object): Remove.
7454 * fontset.c (FONTSET_OBJLIST): Remove.
7455 (free_realized_fontset) #if-0 the body, which does nothing.
7456 (face_suitable_for_char_p): #if-0, as it's never called.
7457 * fontset.h (face_suitable_for_char_p): Remove decl.
7458 * xfaces.c (face_at_string_position):
7459 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7460 since 0 is always ASCII.
7462 * fns.c (weak_hash_tables): Now static.
7464 * fileio.c: Make symbols static if they're not exported.
7465 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7466 (Vwrite_region_annotation_buffers): Now static.
7468 * eval.c: Make symbols static if they're not exported.
7469 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7470 * lisp.h (backtrace_list): Remove decl.
7472 * emacs.c: Make symbols static if they're not exported.
7473 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7474 (fatal_error_code, fatal_error_signal_hook, standard_args):
7476 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7477 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7478 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7479 * lisp.h (fatal_error_signal_hook): Remove decl.
7480 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7482 * editfns.c: Move a (normally-unused) function to its only use.
7483 * editfns.c, lisp.h (get_operating_system_release): Remove.
7484 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7485 worth the hassle of breaking this out.
7487 * xterm.c: Make symbols static if they're not exported.
7488 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7489 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7490 (x_destroy_window, x_delete_display):
7492 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7493 (x_mouse_leave): Remove; unused.
7494 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7495 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7496 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7498 (x_mouse_leave): Declare only if WINDOWSNT.
7499 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7500 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7503 * ftxfont.c: Make symbols static if they're not exported.
7504 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7506 * font.h (ftxfont_driver): Likewise.
7508 * xfns.c: Make symbols static if they're not exported.
7509 (x_last_font_name, x_display_info_for_name):
7510 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7511 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7512 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7513 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7514 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7515 (last_show_tip_args): Now static.
7516 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7517 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7518 (x_screen_planes): Remove; unused.
7519 * dispextern.h (x_screen_planes): Remove decl.
7521 * dispnew.c: Make symbols static if they're not exported.
7522 * dispextern.h (redraw_garbaged_frames, scrolling):
7523 (increment_row_positions): Remove.
7524 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7525 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7527 (redraw_garbaged_frames): Remove; unused.
7529 * xfaces.c: Make symbols static if they're not exported.
7530 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7532 * xterm.h (defined_color): Remove decls.
7533 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7534 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7535 (menu_face_changed_default, defined_color, free_realized_face):
7536 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7537 (ascii_face_of_lisp_face): Remove; unused.
7539 * xdisp.c: Make symbols static if they're not exported.
7540 * dispextern.h (scratch_glyph_row, window_box_edges):
7541 (glyph_to_pixel_coords, set_cursor_from_row):
7542 (get_next_display_element, set_iterator_to_next):
7543 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7544 (show_mouse_face): Remove decls
7545 * frame.h (message_buf_print): Likewise.
7546 * lisp.h (pop_message, set_message, check_point_in_composition):
7548 * xterm.h (set_vertical_scroll_bar): Likewise.
7549 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7550 (message_buf_print, scratch_glyph_row, displayed_buffer):
7551 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7552 (get_next_display_element, show_mouse_face, window_box_edges):
7553 (frame_to_window_pixel_xy, check_point_in_composition):
7554 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7555 (glyph_to_pixel_coords): Remove; unused.
7557 * dired.c (file_name_completion): Now static.
7559 * dbusbind.c (xd_in_read_queued_messages): Now static.
7561 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7562 * data.c (circular_list_error): Remove.
7564 * commands.h (last_point_position, last_point_position_buffer):
7565 (last_point_position_window): Remove decls.
7566 * keyboard.c: Make these variables static.
7568 * coding.h (coding, code_convert_region, encode_coding_gap):
7570 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7571 (iso_code_class, detect_coding, code_convert_region): Now static.
7572 (encode_coding_gap): Remove; unused.
7574 * chartab.c (chartab_chars, chartab_bits): Now static.
7576 * charset.h (charset_iso_8859_1): Remove decl.
7577 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7580 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7581 * ccl.c (Vccl_program_table): Now static.
7582 (check_ccl_update): Remove; unused.
7584 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7585 * category.h: ... from here.
7586 * category.c (check_category_table, set_category_set): Now static.
7588 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7589 * lisp.h: Remove these decls.
7591 * buffer.c (buffer_count): Remove unused var.
7593 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7594 so that it's not optimized away.
7595 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7596 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7597 exported only to the debugger.
7599 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7600 * atimer.h (run_all_atimers): Remove; not exported.
7602 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7603 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7604 was inaccessible from Lisp.
7605 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7606 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7608 alloc.c: Import and export fewer symbols, and remove unused items.
7609 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7611 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7612 it's not optimized away by whole-program optimization.
7613 (message_enable_multibyte, free_misc): Remove.
7614 (catchlist, handlerlist, mark_backtrace):
7615 Declare only if BYTE_MARK_STACK.
7616 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7617 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7618 (message_enable_multibyte): Remove decl.
7619 (free_misc, interval_free_list, float_block, float_block_index):
7620 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7621 (cons_free_list, last_marked_index):
7623 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7624 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7625 (mark_backtrace): Define only if BYTE_MARK_STACK.
7626 * xdisp.c (message_enable_multibyte): Now static.
7628 Declare Lisp_Object Q* variables to be 'static' if not exported.
7629 This makes it easier for human readers (and static analyzers)
7630 to see whether these variables are used from other modules.
7631 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7632 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7633 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7634 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7635 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7636 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7637 * xmenu.c, xselect.c:
7638 Declare Q* vars static if they are not used in other modules.
7639 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7640 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7641 Remove decls of unexported vars.
7642 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7644 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7646 Make Emacs functions such as Fatom 'static' by default.
7647 This makes it easier for human readers (and static analyzers)
7648 to see whether these functions can be called from other modules.
7649 DEFUN now defines a static function. To make the function external
7650 so that it can be used in other C modules, use the new macro DEFUE.
7651 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7652 (Finit_image_library):
7653 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7654 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7655 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7656 Remove decls, since these functions are now static.
7657 (Funintern, Fget_internal_run_time): New decls, since these functions
7658 were already external.
7660 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7661 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7662 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7663 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7664 * keyboard.c, keymap.c, lread.c:
7665 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7666 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7667 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7668 Mark functions with DEFUE instead of DEFUN,
7669 if they are used in other modules.
7670 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7671 decls for now-static functions.
7672 * buffer.h (Fdelete_overlay): Remove decl.
7673 * callproc.c (Fgetenv_internal): Mark as internal.
7674 * composite.c (Fremove_list_of_text_properties): Remove decl.
7675 (Fcomposition_get_gstring): New forward static decl.
7676 * composite.h (Fcomposite_get_gstring): Remove decl.
7677 * dired.c (Ffile_attributes): New forward static decl.
7678 * doc.c (Fdocumntation_property): New forward static decl.
7679 * eval.c (Ffetch_bytecode): New forward static decl.
7680 (Funintern): Remove extern decl; now in .h file where it belongs.
7681 * fileio.c (Fmake_symbolic_link): New forward static decl.
7682 * image.c (Finit_image_library): New forward static decl.
7683 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7684 * intervals.h (Fprevious_property_change):
7685 (Fremove_list_of_text_properties): Remove decls.
7686 * keyboard.c (Fthis_command_keys): Remove decl.
7687 (Fcommand_execute): New forward static decl.
7688 * keymap.c (Flookup_key): New forward static decl.
7689 (Fcopy_keymap): Now static.
7690 * keymap.h (Flookup_key): Remove decl.
7691 * process.c (Fget_process): New forward static decl.
7692 (Fprocess_datagram_address): Mark as internal.
7693 * syntax.c (Fsyntax_table_p): New forward static decl.
7694 (skip_chars): Remove duplicate decl.
7695 * textprop.c (Fprevious_property_change): New forward static decl.
7696 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7698 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7699 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7701 * editfns.c (Fformat): Remove unreachable code.
7703 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7705 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7708 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7710 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7711 when at ZV. (Bug#8487)
7713 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7715 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7717 * keyboard.c (parse_tool_bar_item): Likewise.
7718 * sound.c (sound_cleanup, alsa_close): Likewise.
7719 * termcap.c (tgetent): Likewise.
7720 * xfns.c (x_default_font_parameter): Likewise.
7721 * xsettings.c (read_and_apply_settings): Likewise.
7723 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7724 (overrun_check_free): Protoize.
7726 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7728 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7729 since callers should never pass a negative size.
7730 Change the signature to match that of plain 'read' and 'write'; see
7731 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7732 * lisp.h: Update prototypes of emacs_write and emacs_read.
7734 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7736 * xdisp.c (redisplay_window): Don't try to determine the character
7737 position of the scroll margin if the window start point w->startp
7738 is outside the buffer's accessible region. (Bug#8468)
7740 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7742 Fix write-region and its subroutines for buffers > 2GB.
7743 * fileio.c (a_write, e_write): Modify declaration of arguments and
7744 local variables to support buffers larger than 2GB.
7745 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7747 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7748 argument, local variables, and return value.
7750 * lisp.h: Update prototypes of emacs_write and emacs_read.
7752 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7754 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7756 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7758 Fix more problems found by GCC 4.6.0's static checks.
7760 * xdisp.c (vmessage): Use a better test for character truncation.
7762 * charset.c (load_charset_map): <, not <=, for optimization,
7763 and to avoid potential problems with integer overflow.
7764 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7765 * casetab.c (set_identity, shuffle): Likewise.
7766 * editfns.c (Fformat): Likewise.
7767 * syntax.c (skip_chars): Likewise.
7769 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7770 This also lets GCC 4.6.0 generate slightly better loop code.
7772 * callint.c (Fcall_interactively): <, not <=, for optimization.
7773 (Fcall_interactively): Count the number of arguments produced,
7774 not the number of arguments given. This is simpler and lets GCC
7775 4.6.0 generate slightly better code.
7777 * ftfont.c: Distingish more carefully between FcChar8 and char.
7778 The previous code passed unsigned char * to a functions like
7779 strlen and xstrcasecmp that expect char *, which does not
7780 conform to the C standard.
7781 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7782 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7783 char * when the C standard requires it.
7785 * keyboard.c (read_char): Remove unused var.
7787 * eval.c: Port to Windows vsnprintf (Bug#8435).
7789 (SIZE_MAX): Define if the headers do not.
7790 (verror): Do not give up if vsnprintf returns a negative count.
7791 Instead, grow the buffer. This ports to Windows vsnprintf, which
7792 does not conform to C99. Problem reported by Eli Zaretskii.
7793 Also, simplify the allocation scheme, by avoiding the need for
7794 calling realloc, and removing the ALLOCATED variable.
7796 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7798 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7799 But keep the doprint source code for now, as we might revamp it
7800 and use it again (Bug#8435).
7801 * lisp.h (doprnt): Remove.
7802 * Makefile.in (base_obj): Remove doprnt.o.
7803 * deps.mk (doprnt.o): Remove.
7805 error: Print 32- and 64-bit integers portably (Bug#8435).
7806 Without this change, on typical 64-bit hosts error ("...%d...", N)
7807 was used to print both 32- and 64-bit integers N, which relied on
7809 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7810 * lisp.h (error, verror): Mark as printf-like functions.
7811 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7812 Report overflow in size calculations when allocating printf buffer.
7813 Do not truncate output string at its first null byte.
7814 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7815 Truncate the output at a character boundary, since vsnprintf does not
7817 * charset.c (check_iso_charset_parameter): Convert internal
7818 character to string before calling 'error', since %c now has the
7820 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7821 overflow when computing char to be passed to 'error'. Do not
7822 pass Lisp_Object to 'error'; pass the integer instead.
7823 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7824 formatted with plain %d.
7826 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7828 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7830 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7832 * xterm.c (x_catch_errors): Remove duplicate declaration.
7834 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7836 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7838 2011-04-10 Jim Meyering <meyering@redhat.com>
7840 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7841 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7842 return ssize_t not "int", and use size_t as the buffer length.
7843 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7844 * gnutls.h: Update declarations.
7845 * process.c (read_process_output): Use ssize_t, to match.
7846 (send_process): Likewise.
7848 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7850 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7852 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7854 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7855 Use unsigned char, to match FcChar8 type definition.
7857 * xterm.c (handle_one_xevent):
7858 * xmenu.c (create_and_show_popup_menu):
7859 * xselect.c (x_decline_selection_request)
7860 (x_reply_selection_request): Avoid type-punned deref of X events.
7862 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7864 Fix some uses of `int' instead of EMACS_INT.
7865 * search.c (string_match_1, fast_string_match)
7866 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7867 (scan_buffer, find_next_newline_no_quit)
7868 (find_before_next_newline, search_command, Freplace_match)
7869 (Fmatch_data): Make some `int' variables be EMACS_INT.
7871 * xdisp.c (display_count_lines): 3rd argument and return value now
7872 EMACS_INT. All callers changed.
7873 (pint2hrstr): Last argument is now EMACS_INT.
7875 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7876 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7877 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7878 (decode_coding_utf_16, decode_coding_emacs_mule)
7879 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7880 (decode_coding_ccl, decode_coding_charset)
7881 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7882 (decode_coding_iso_2022, decode_coding_emacs_mule)
7883 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7884 <char_offset, last_offset>: Declare EMACS_INT.
7885 (encode_coding_utf_8, encode_coding_utf_16)
7886 (encode_coding_emacs_mule, encode_invocation_designation)
7887 (encode_designation_at_bol, encode_coding_iso_2022)
7888 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7889 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7891 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7892 (encode_invocation_designation): Last argument P_NCHARS is now
7894 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7895 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7897 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7900 * ccl.c (Fccl_execute_on_string): Declare some variables
7903 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7905 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7907 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7909 * process.c (Fformat_network_address): Doc fix.
7911 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7913 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7915 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7917 * keyboard.c (read_char): Call Lisp function help-form-show,
7918 instead of using internal_with_output_to_temp_buffer.
7919 (Qhelp_form_show): New var.
7920 (syms_of_keyboard): Use DEFSYM macro.
7922 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7924 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7926 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7928 * process.c (Flist_processes): Remove to Lisp.
7929 (list_processes_1): Delete.
7931 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7933 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7935 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7937 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7939 Fix more problems found by GCC 4.6.0's static checks.
7941 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7943 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7945 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7947 * xdisp.c (vmessage): Mark as a printf-like function.
7949 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7951 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7953 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7954 printf-like functions.
7955 (tiff_load): Add casts to remove these marks before passing them
7956 to system-supplied API.
7958 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7960 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7961 This avoids several warnings with gcc -Wstrict-overflow.
7962 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7963 directly, rather than having caller test rule sign. This avoids
7964 some unnecessary tests.
7965 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7966 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7967 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7969 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7970 (xfont_open): Avoid unnecessary tests.
7972 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7974 * composite.h, composite.c (composition_gstring_put_cache):
7975 Use EMACS_INT, not int, for length.
7977 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7978 breaking out part of COMPOSITION_DECODE_RULE.
7979 (COMPOSITION_DECODE_RULE): Use it.
7980 * composite.c (get_composition_id): Remove unused local vars,
7981 by using the new macro.
7983 * textprop.c (set_text_properties_1): Change while to do-while,
7984 since the condition is always true at first.
7986 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7987 (interval_deletion_adjustment): Return unsigned value.
7990 * process.c (list_processes_1, create_pty, read_process_output):
7991 (exec_sentinel): Remove vars that were set but not used.
7992 (create_pty): Remove unnecessary "volatile"s.
7993 (Fnetwork_interface_info): Avoid possibility of int overflow.
7994 (read_process_output): Do adaptive read buffering even if carryover.
7995 (read_process_output): Simplify nbytes computation if buffered.
7997 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7999 * syntax.c (scan_words): Remove var that was set but not used.
8000 (update_syntax_table): Use unsigned instead of int.
8002 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8003 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8004 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8006 * print.c (print_error_message): Avoid int overflow.
8008 * font.c (font_list_entities): Redo for clarity,
8009 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8011 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8012 (font_score): Avoid potential overflow in diff calculation.
8014 * fns.c (substring_both): Remove var that is set but not used.
8015 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8017 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8019 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8020 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8021 can always succeed if overflow has undefined behavior.
8023 * search.c (boyer_moore, wordify): Remove vars set but not used.
8024 (wordify): Omit three unnecessary tests.
8026 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8027 All callers changed. This avoids the need for an unused var.
8029 * casefiddle.c (casify_region): Remove var that is set but not used.
8031 * dired.c (file_name_completion): Remove var that is set but not used.
8033 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8035 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8036 (Finsert_file_contents): Remove unnecessary code checking fd.
8038 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8039 Check for integer overflow on size calculations.
8041 * buffer.c (Fprevious_overlay_change): Remove var that is set
8044 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8045 Remove vars that are set but not used.
8046 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8047 (timer_check_2): Mark vars as initialized.
8049 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8051 * image.c (lookup_image): Remove var that is set but not used.
8052 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8054 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8055 that are set but not used.
8057 * xfns.c (make_invisible_cursor): Don't return garbage
8058 if XCreateBitmapFromData fails (Bug#8410).
8060 * xselect.c (x_get_local_selection, x_handle_property_notify):
8061 Remove vars that are set but not used.
8063 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8064 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8066 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8067 Remove var that is set but not used.
8068 (scroll_bar_windows_size): Now size_t, not int.
8069 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8072 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8073 (map_tty_color) [!defined MSDOS]: Likewise.
8075 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8077 * coding.c: Remove vars that are set but not used.
8078 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8079 All callers changed.
8080 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8081 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8082 (decode_coding_charset): Remove vars that are set but not used.
8084 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8085 that is set but not used.
8087 * print.c (print_object): Remove var that is set but not used.
8089 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8090 The gnulib version avoids calling malloc in the usual case,
8091 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8092 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8093 * filelock.c (current_lock_owner): Likewise.
8094 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8095 * sysdep.c: Include allocator.h, careadlinkat.h.
8096 (emacs_no_realloc_allocator): New static constant.
8097 (emacs_readlink): New function.
8098 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8099 ../lib/careadlinkat.h.
8101 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8103 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8104 first non-nil return value).
8106 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8108 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8109 if not defined (Bug#8403).
8111 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8113 * xdisp.c (display_count_lines): Remove parameter `start',
8114 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8115 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8116 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8117 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8118 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8119 and thereabouts. All callers changed.
8120 (get_per_char_metric): Remove parameter `f', unused since
8121 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8123 2011-04-02 Jim Meyering <meyering@redhat.com>
8125 do not dereference NULL upon failed strdup
8126 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8127 (ns_get_family): Likewise.
8129 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8131 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8133 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8135 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8138 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8140 Add lexical binding.
8142 * window.c (Ftemp_output_buffer_show): New fun.
8143 (Fsave_window_excursion):
8144 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8146 * lread.c (lisp_file_lexically_bound_p): New function.
8147 (Fload): Bind Qlexical_binding.
8148 (readevalloop): Remove `evalfun' arg.
8149 Bind Qinternal_interpreter_environment.
8150 (Feval_buffer): Bind Qlexical_binding.
8151 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8153 (syms_of_lread): Declare `lexical-binding'.
8155 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8157 * keyboard.c (eval_dyn): New fun.
8158 (menu_item_eval_property): Use it.
8160 * image.c (parse_image_spec): Use Ffunctionp.
8162 * fns.c (concat, mapcar1): Accept byte-code-functions.
8164 * eval.c (Fsetq): Handle lexical vars.
8165 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8166 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8167 (FletX, Flet): Obey lexical binding.
8168 (Fcommandp): Handle closures.
8169 (Feval): New `lexical' arg.
8170 (eval_sub): New function extracted from Feval. Use it almost
8171 everywhere where Feval was used. Look up vars in lexical env.
8173 (Ffunctionp): Move from subr.el.
8174 (Ffuncall): Handle closures.
8175 (apply_lambda): Remove `eval_flags'.
8176 (funcall_lambda): Handle closures and new byte-code-functions.
8177 (Fspecial_variable_p): New function.
8178 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8179 but without exporting it to Lisp.
8181 * doc.c (Fdocumentation, store_function_docstring):
8182 * data.c (Finteractive_form): Handle closures.
8184 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8187 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8189 (exec_byte_code): New function extracted from Fbyte_code to handle new
8190 calling convention for byte-code-functions. Add new byte-codes.
8192 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8194 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8196 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8198 * xdisp.c (redisplay_internal): Fix prototype.
8200 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8202 * xdisp.c (SCROLL_LIMIT): New macro.
8203 (try_scrolling): Use it when setting scroll_limit.
8204 Limit scrolling to 100 screen lines.
8205 (redisplay_window): Even when falling back on "recentering",
8206 position point in the window according to scroll-conservatively,
8207 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8209 (try_scrolling): When point is above the window, allow searching
8210 as far as scroll_max, or one screenful, to compute vertical
8211 distance from PT to the scroll margin position. This prevents
8212 try_scrolling from unnecessarily failing when
8213 scroll-conservatively is set to a value slightly larger than the
8214 window height. Clean up the case of PT below the margin at bottom
8215 of window: scroll_max can no longer be INT_MAX. When aggressive
8216 scrolling is in use, don't let point enter the opposite scroll
8217 margin as result of the scroll.
8218 (syms_of_xdisp) <scroll-conservatively>: Document the
8219 threshold of 100 lines for never-recentering scrolling.
8221 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8223 * dispextern.h (move_it_by_lines):
8224 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8225 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8226 (message_log_check_duplicate): Remove parameters `prev_bol' and
8227 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8228 (redisplay_internal): Remove parameter `preserve_echo_area',
8229 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8231 * indent.c (Fvertical_motion):
8232 * window.c (window_scroll_pixel_based, Frecenter):
8233 Don't pass `need_y_p' to `move_it_by_lines'.
8235 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8237 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8238 steal a few bits to be more compact.
8239 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8240 Remove unneeded casts.
8242 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8244 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8246 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8247 binding" message (bug#7967).
8249 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8251 Fix more problems found by GCC 4.6.0's static checks.
8253 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8254 Remove unused local var.
8256 * editfns.c (Fmessage_box): Remove unused local var.
8258 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8259 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8260 Omit unused local vars.
8261 * window.c (shrink_windows): Omit unused local var.
8262 * menu.c (digest_single_submenu): Omit unused local var.
8263 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8264 Omit unused local var.
8266 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8267 Don't assume string length fits in int.
8268 (keyremap_step, read_key_sequence): Use size_t for sizes.
8269 (read_key_sequence): Don't check last_real_key_start redundantly.
8271 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8272 instead of alloca (Bug#8344).
8274 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8275 (Fbacktrace_frame): Don't assume nframes fits in int.
8277 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8279 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8282 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8284 * cm.c (calccost): Turn while-do into do-while, for clarity.
8286 * keyboard.c (syms_of_keyboard): Use the same style as later
8287 in this function when indexing through an array. This also
8288 works around GCC bug 48267.
8290 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8292 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8294 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8295 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8297 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8298 This avoids undefined behavior on integer overflow, and is a bit
8299 more convenient anyway since it is compared to a size_t variable.
8301 Variadic C functions now count arguments with size_t, not int.
8302 This avoids an unnecessary limitation on 64-bit machines, which
8303 caused (substring ...) to crash on large vectors (Bug#8344).
8304 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8305 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8306 All variadic functions and their callers changed accordingly.
8307 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8308 * data.c (arith_driver, float_arith_driver): Likewise.
8309 * editfns.c (general_insert_function): Likewise.
8310 * eval.c (struct backtrace.nargs, interactive_p)
8311 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8312 (funcall_lambda, mark_backtrace): Likewise.
8313 * fns.c (concat): Likewise.
8314 * frame.c (x_set_frame_parameters): Likewise.
8315 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8316 0 if not found, not -1. All callers changed.
8318 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8319 (stack_copy_size): Now size_t, not int.
8320 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8322 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8324 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8325 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8326 All callers changed.
8328 * lisp.h (multibyte_char_to_unibyte):
8329 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8330 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8331 * character.h (CHAR_TO_BYTE8):
8332 * cmds.c (internal_self_insert):
8333 * editfns.c (general_insert_function):
8334 * keymap.c (push_key_description):
8335 * search.c (Freplace_match):
8336 * xdisp.c (message_dolog, set_message_1): All callers changed.
8338 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8340 * keyboard.c (safe_run_hook_funcall): New function.
8341 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8342 don't set the hook to nil, but remove the offending function instead.
8343 (Qcommand_hook_internal): Remove, unused.
8344 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8345 Vcommand_hook_internal.
8347 * eval.c (enum run_hooks_condition): Remove.
8348 (funcall_nil, funcall_not): New functions.
8349 (run_hook_with_args): Call each function through a `funcall' argument.
8350 Remove `cond' argument, now redundant.
8351 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8352 (Frun_hook_with_args_until_failure): Adjust accordingly.
8353 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8355 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8357 * dispextern.h (string_buffer_position): Remove declaration.
8359 * print.c (strout): Remove parameter `multibyte', unused since
8360 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8362 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8363 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8364 All callers changed.
8366 * w32.c (_wsa_errlist): Use braces for struct initializers.
8368 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8369 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8370 All callers changed.
8371 (string_buffer_position): Likewise. Also, make static (it's never
8372 used outside xdisp.c).
8373 (cursor_row_p): Remove parameter `w', unused since
8374 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8375 (decode_mode_spec): Remove parameter `precision', introduced during
8376 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8377 All callers changed.
8379 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8381 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8383 2011-03-27 Anders Lindgren <andlind@gmail.com>
8385 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8386 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8387 (ns_update_auto_hide_menu_bar): New functions.
8388 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8389 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8390 ns_constrain_all_frames.
8391 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8392 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8394 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8396 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8398 2011-03-27 Glenn Morris <rgm@gnu.org>
8400 * syssignal.h: Replace RETSIGTYPE with void.
8401 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8402 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8403 Replace SIGTYPE with void everywhere.
8404 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8405 * s/template.h (SIGTYPE): Remove commented out definition.
8407 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8409 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8410 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8412 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8414 * w32.c (read_unc_volume): Use parameter `henum', instead of
8415 global variable `wget_enum_handle'.
8417 * keymap.c (describe_vector): Remove parameters `indices' and
8418 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8419 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8421 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8423 * keyboard.c (timer_check): Remove parameter `do_it_now',
8424 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8425 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8426 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8428 * keyboard.c (read_char):
8429 * w32menu.c (w32_menu_display_help):
8430 * xmenu.c (show_help_event, menu_help_callback):
8431 Adjust calls to `show_help_echo'.
8433 * gtkutil.c (xg_maybe_add_timer):
8434 * keyboard.c (readable_events):
8435 * process.c (wait_reading_process_output):
8436 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8438 * insdel.c (adjust_markers_gap_motion):
8439 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8440 (gap_left, gap_right): Don't call it.
8442 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8444 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8445 incurred during fontification.
8447 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8449 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8450 (DEFVAR_PER_BUFFER): Don't pass it.
8452 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8453 (scrolling_window): Don't pass it.
8455 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8457 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8459 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8461 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8462 of variables specific to SELinux and computation of `encoded_absname'.
8464 * image.c (XPutPixel): Remove unused variable `height'.
8466 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8468 * unexw32.c (get_section_info): Remove unused variable `section'.
8470 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8471 (system_process_attributes): Remove unused variable `sess'.
8472 (sys_read): Remove unused variable `err'.
8474 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8475 (w32_wnd_proc): Remove unused variable `isdead'.
8476 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8477 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8478 (x_create_tip_frame): Remove unused variable `tem'.
8480 * w32inevt.c (w32_console_read_socket):
8481 Remove unused variable `no_events'.
8483 * w32term.c (x_draw_composite_glyph_string_foreground):
8484 Remove unused variable `width'.
8486 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8488 * w32term.c (x_set_glyph_string_clipping):
8489 Don't pass uninitialized region to CombineRgn.
8491 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8493 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8494 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8495 (Fx_close_connection): Remove unused variable `i'.
8497 * w32font.c (w32font_draw): Return number of glyphs.
8498 (w32font_open_internal): Remove unused variable `i'.
8499 (w32font_driver): Add missing initializer.
8501 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8502 (fill_in_menu): Remove unused variable `items_added'.
8504 * w32term.c (last_mouse_press_frame): Remove static global variable.
8505 (w32_clip_to_row): Remove unused variable `f'.
8506 (x_delete_terminal): Remove unused variable `i'.
8508 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8509 (NOTHING): Remove unused static global variable.
8510 (uniscribe_check_otf): Remove unused variable `table'.
8511 (uniscribe_font_driver): Add missing initializers.
8513 2011-03-23 Julien Danjou <julien@danjou.info>
8515 * term.c (Fsuspend_tty, Fresume_tty):
8516 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8517 * window.c (temp_output_buffer_show):
8518 * insdel.c (signal_before_change):
8519 * frame.c (Fhandle_switch_frame):
8520 * fileio.c (Fdo_auto_save):
8521 * emacs.c (Fkill_emacs):
8522 * editfns.c (save_excursion_restore):
8523 * cmds.c (internal_self_insert):
8524 * callint.c (Fcall_interactively):
8525 * buffer.c (Fkill_all_local_variables):
8526 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8528 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8529 unconditionally since it does the check itself.
8531 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8533 Fix more problems found by GCC 4.5.2's static checks.
8535 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8536 the first time through the loop, since we know p0 < p1 then.
8537 This also avoids a gcc -Wstrict-overflow warning.
8539 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8540 leading to a memory leak, possible in functions like
8541 load_charset_map_from_file that can allocate an unbounded number
8542 of objects (Bug#8318).
8544 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8545 that could (at least in theory) be that large.
8547 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8548 This is less likely to overflow, and avoids undefined behavior if
8549 overflow does occur. All callers changed. Use strtoul to scan
8550 for the unsigned long integer.
8551 (pint2hrstr): Simplify and tune code slightly.
8552 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8554 * scroll.c (do_scrolling): Work around GCC bug 48228.
8555 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8557 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8558 This also avoids a warning with gcc -Wstrict-overflow.
8559 (validate_x_resource_name): Simplify count usage.
8560 This also avoids a warning with gcc -Wstrict-overflow.
8562 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8565 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8567 * process.c (Fmake_network_process): Use socklen_t, not int,
8568 where POSIX says socklen_t is required in portable programs.
8569 This fixes a porting bug on hosts like 64-bit HP-UX, where
8570 socklen_t is wider than int (Bug#8277).
8571 (Fmake_network_process, server_accept_connection):
8572 (wait_reading_process_output, read_process_output):
8575 * process.c: Rename or move locals to avoid shadowing.
8576 (list_processes_1, Fmake_network_process):
8577 (read_process_output_error_handler, exec_sentinel_error_handler):
8578 Rename or move locals.
8579 (Fmake_network_process): Define label "retry_connect" only if needed.
8580 (Fnetwork_interface_info): Fix pointer signedness.
8581 (process_send_signal): Add cast to avoid pointer signedness problem.
8582 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8583 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8585 Make tparam.h and terminfo.c consistent.
8586 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8587 Include tparam.h instead, since it declares them.
8588 * cm.h (PC): Remove extern decl; tparam.h now does this.
8589 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8590 * terminfo.c: Include tparam.h, to check interfaces.
8591 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8592 (tparam): Adjust signature to match interface in tparam.h;
8593 this removes some undefined behavior. Check that outstring and len
8594 are zero, which they always are with Emacs.
8595 * tparam.h (PC, BC, UP): New extern decls.
8597 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8598 (xftfont_open): Rename locals to avoid shadowing.
8600 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8601 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8602 (OTF_TAG_SYM): Omit macro if not needed.
8603 (ftfont_list): Remove unused local.
8604 (get_adstyle_property, ftfont_pattern_entity):
8605 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8606 Rename locals to avoid shadowing.
8608 * xfont.c (xfont_list_family): Mark var as initialized.
8610 * xml.c (make_dom): Now static.
8612 * composite.c (composition_compute_stop_pos): Rename local to
8614 (composition_reseat_it): Remove unused locals.
8615 (find_automatic_composition, composition_adjust_point): Likewise.
8616 (composition_update_it): Mark var as initialized.
8617 (find_automatic_composition): Mark vars as initialized,
8618 with a FIXME (Bug#8290).
8620 character.h: Rename locals to avoid shadowing.
8621 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8622 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8623 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8624 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8627 * textprop.c (property_change_between_p): Remove; unused.
8629 * intervals.c (interval_start_pos): Now static.
8631 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8633 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8634 Rename locals to avoid shadowing.
8636 * sound.c (wav_play, au_play, Fplay_sound_internal):
8637 Fix pointer signedness.
8638 (alsa_choose_format): Remove unused local var.
8639 (wav_play): Initialize a variable to 0, to prevent undefined
8640 behavior (Bug#8278).
8642 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8644 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8646 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8647 clobbering (Bug#8298).
8648 * sysdep.c (sys_subshell): Likewise.
8649 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8651 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8652 This should get cleaned up, so that child_setup has the
8653 same signature on all platforms.
8655 * callproc.c (call_process_cleanup): Now static.
8656 (relocate_fd): Rename locals to avoid shadowing.
8658 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8660 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8661 not to be necessary, and produces flickering.
8663 2011-03-20 Glenn Morris <rgm@gnu.org>
8665 * config.in: Remove file.
8667 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8669 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8670 are now in src/globals.h.
8671 (syms_of_minibuf): Remove spurious & from previous change.
8673 2011-03-20 Leo Liu <sdl.web@gmail.com>
8675 * minibuf.c (completing-read-function): New variable.
8676 (completing-read-default): Rename from completing-read.
8677 (completing-read): Call completing-read-function.
8679 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8681 * xfaces.c (Fx_load_color_file):
8682 Read color file from absolute filename (bug#8250).
8684 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8686 * makefile.w32-in: Update dependencies.
8688 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8690 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8692 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8694 Fix more problems found by GCC 4.5.2's static checks.
8696 * process.c (make_serial_process_unwind, send_process_trap):
8697 (sigchld_handler): Now static.
8699 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8700 That way, the code declares only the vars that it needs.
8701 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8702 * s/cygwin.h (PTY_ITERATION): Likewise.
8703 * s/darwin.h (PTY_ITERATION): Likewise.
8704 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8706 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8707 * process.c (allocate_pty): Don't declare stb unless it's needed.
8709 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8710 (CONSTANTLIM): Remove; unused.
8711 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8712 Define only if needed.
8714 * unexelf.c (unexec): Name an expression,
8715 to avoid gcc -Wbad-function-cast warning.
8716 Use a different way to cause a compilation error if anyone uses
8717 n rather than nn, a way that does not involve shadowing.
8718 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8720 * deps.mk (unexalpha.o): Remove; unused.
8722 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8723 * unexec.h: New file.
8724 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8725 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8727 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8728 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8729 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8730 Change as necessary to match prototype in unexec.h.
8732 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8734 (back_comment, skip_chars): Mark vars as initialized.
8736 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8737 Rename locals to avoid shadowing.
8739 * lread.c (read1): Rewrite so as not to use empty "else".
8740 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8742 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8744 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8745 warning when compiling print.c.
8747 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8748 instead of using an uninitialized var.
8749 (font_sort_entities): Mark var as initialized.
8751 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8753 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8754 pointers to constants.
8755 (font_parse_fcname): Remove unused vars.
8756 (font_delete_unmatched): Now static.
8757 (font_get_spec): Remove; unused.
8758 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8759 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8760 Rename or move locals to avoid shadowing.
8762 * fns.c (require_nesting_list, require_unwind): Now static.
8763 (Ffillarray): Rename locals to avoid shadowing.
8765 * floatfns.c (domain_error2): Define only if needed.
8766 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8768 * alloc.c (mark_backtrace): Move decl from here ...
8769 * lisp.h: ... to here, so that it can be checked.
8771 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8772 (Fdefvar): Rewrite so as not to use empty "else".
8773 (lisp_indirect_variable): Name an expression,
8774 to avoid gcc -Wbad-function-cast warning.
8775 (Fdefvar): Rename locals to avoid shadowing.
8777 * callint.c (quotify_arg, quotify_args): Now static.
8778 (Fcall_interactively): Rename locals to avoid shadowing.
8779 Use const pointer when appropriate.
8781 * lisp.h (get_system_name, get_operating_system_release):
8782 Move decls here, to check interfaces.
8783 * process.c (get_operating_system_release): Move decl to lisp.h.
8784 * xrdb.c (get_system_name): Likewise.
8785 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8786 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8787 some of which prompt warnings from gcc -Wbad-function-cast.
8788 (Fformat_time_string, Fencode_time, Finsert_char):
8789 (Ftranslate_region_internal, Fformat):
8790 Rename or remove local vars to avoid shadowing.
8791 (Ftranslate_region_internal): Mark var as initialized.
8793 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8796 * lisp.h (eassert): Check that the argument compiles, even if
8797 ENABLE_CHECKING is not defined.
8799 * data.c (Findirect_variable): Name an expression, to avoid
8800 gcc -Wbad-function-cast warning.
8801 (default_value, arithcompare, arith_driver, arith_error): Now static.
8802 (store_symval_forwarding): Rename local to avoid shadowing.
8803 (Fmake_variable_buffer_local, Fmake_local_variable):
8804 Mark variables as initialized.
8805 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8807 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8808 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8809 Rename locals to avoid shadowing.
8810 (mark_stack): Move local variables into the #ifdef region where
8812 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8813 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8815 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8816 (GC_STRING_CHARS): Remove; not used.
8817 (Fmemory_limit): Cast sbrk's returned value to char *.
8819 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8820 avoids undefined behavior in theory.
8822 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8824 Use functions, not macros, for up- and down-casing (Bug#8254).
8825 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8826 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8827 to use the following functions instead of these macros.
8828 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8829 EMACS_INT, since callers assume the returned value fits in int.
8830 (upcase1): Likewise, for UPCASE_TABLE.
8831 (uppercasep, lowercasep, upcase): New static inline functions.
8832 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8833 the race-condition problem in the old DOWNCASE.
8835 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8836 Rename locals to avoid shadowing.
8837 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8838 (regex_compile, re_search_2, re_match_2_internal):
8839 Remove unused local vars.
8840 (FREE_VAR): Rewrite so as not to use empty "else",
8841 which gcc can warn about.
8842 (regex_compile, re_match_2_internal): Mark locals as initialized.
8843 (RETALLOC_IF): Define only if needed.
8844 (WORDCHAR_P): Likewise. This one is never needed, but is used
8845 only in a comment talking about a compiler bug, so put inside
8846 the #if 0 of that comment.
8847 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8848 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8851 * search.c (boyer_moore): Rename locals to avoid shadowing.
8852 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8853 (PREV_CHAR_BOUNDARY): Likewise.
8855 * search.c (simple_search): Remove unused var.
8857 * dired.c (compile_pattern): Move decl from here ...
8858 * lisp.h: ... to here, so that it can be checked.
8859 (struct re_registers): New forward decl.
8861 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8863 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8865 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8866 Rename locals to avoid shadowing.
8867 (Fvertical_motion): Mark locals as initialized.
8869 * casefiddle.c (casify_object, casify_region): Now static.
8870 (casify_region): Mark local as initialized.
8872 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8874 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8875 New macros, so that the caller can use some names other than
8876 gcpro1, gcpro2, etc.
8877 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8879 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8880 argument, for consistency with GCPRO2_VAR, etc: it is now the
8881 prefix of the variable, not the variable itself. All uses
8883 * dired.c (directory_files_internal, file_name_completion):
8884 Rename locals to avoid shadowing.
8886 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8887 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8888 dired.c's scmp function, had undefined behavior.
8889 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8890 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8891 * buffer.h: ... to here, because these macros use current_buffer,
8892 and the new implementation with inline functions needs to have
8893 current_buffer in scope now, rather than later when the macros
8895 (downcase, upcase1): New static inline functions.
8896 (DOWNCASE, UPCASE1): Reimplement using these functions.
8897 This avoids undefined behavior in expressions like
8898 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8899 from race conditions in accessing the global variables
8900 case_temp1 and case_temp2.
8901 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8902 * lisp.h (case_temp1, case_temp2): Remove their decls.
8903 * character.h (ASCII_CHAR_P): Move from here ...
8904 * lisp.h: ... to here, so that the inline functions mentioned
8907 * dired.c (directory_files_internal_unwind): Now static.
8909 * fileio.c (file_name_as_directory, directory_file_name):
8910 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8912 (file_name_as_directory): Use const pointers when appropriate.
8913 (Fexpand_file_name): Likewise. In particular, newdir might
8914 point at constant storage, so make it a const pointer.
8915 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8916 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8918 (Fset_file_times, Finsert_file_contents, auto_save_error):
8919 Rename locals to avoid shadowing.
8921 * minibuf.c (choose_minibuf_frame_1): Now static.
8922 (Ftry_completion, Fall_completions): Rename or remove locals
8925 * marker.c (bytepos_to_charpos): Remove; unused.
8927 * lisp.h (verify_bytepos, count_markers): New decls,
8928 so that gcc does not warn that these functions aren't declared.
8930 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8931 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8932 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8933 (copy_text): Remove unused local var.
8935 * filelock.c (within_one_second): Now static.
8936 (lock_file_1): Rename local to avoid shadowing.
8938 * buffer.c (fix_overlays_before): Mark locals as initialized.
8939 (fix_start_end_in_overlays): Likewise. This function should be
8940 simplified by using pointers-to-pointers, but that's a different
8942 (switch_to_buffer_1): Now static.
8943 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8944 (report_overlay_modification): Rename locals to avoid shadowing.
8946 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8947 Fix pointer signedness issue.
8948 (sys_subshell): Mark local as volatile if checking for lint,
8949 to suppress a gcc -Wclobbered warning that does not seem to be right.
8950 (MAXPATHLEN): Define only if needed.
8952 * process.c (serial_open, serial_configure): Move decls from here ...
8953 * systty.h: ... to here, so that they can be checked.
8955 * fns.c (get_random, seed_random): Move extern decls from here ...
8956 * lisp.h: ... to here, so that they can be checked.
8958 * sysdep.c (reset_io): Now static.
8959 (wait_for_termination_signal): Remove; unused.
8961 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8962 (copy_keymap_item, append_key, push_text_char_description):
8964 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8965 (DENSE_TABLE_SIZE): Remove; unused.
8966 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8967 (describe_map_tree):
8968 Rename locals to avoid shadowing.
8970 * keyboard.c: Declare functions static if they are not used elsewhere.
8971 (echo_char, echo_dash, cmd_error, top_level_2):
8972 (poll_for_input, handle_async_input): Now static.
8973 (read_char, kbd_buffer_get_event, make_lispy_position):
8974 (make_lispy_event, make_lispy_movement, apply_modifiers):
8975 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8976 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8977 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8978 (read_key_sequence, read_char): Mark locals as initialized.
8979 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8981 * keyboard.h (make_ctrl_char): New decl.
8982 (mark_kboards): Move decl here ...
8983 * alloc.c (mark_kboards): ... from here.
8985 * lisp.h (force_auto_save_soon): New decl.
8987 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8988 (DEFINE_DUMMY_FUNCTION): New macro.
8989 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8991 (main): Add casts to avoid warnings
8992 if GCC considers string literals to be constants.
8994 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8996 * dbusbind.c: Pointer signedness fixes.
8997 (xd_signature, xd_append_arg, xd_initialize):
8998 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8999 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9000 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9001 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9003 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9004 if GCC considers string literals to be constants.
9005 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9007 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9009 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9010 (print_preprocess, print_object): New macro to fix last change.
9012 * print.c (print_preprocess): Don't forget font objects.
9014 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9016 * emacs.c (USAGE3): Doc fixes.
9018 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9020 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9023 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9025 * lisp.h (VWindow_system, Qfile_name_history):
9026 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9027 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9028 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9030 * w32select.c: Don't #include "keyboard.h".
9031 (run_protected): Add extern declaration for waiting_for_input.
9033 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9034 * w32console.c (detect_input_pending, read_input_pending)
9035 (encode_terminal_code):
9036 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9037 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9038 (w32_system_caret_y, Qfile_name_history):
9039 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9040 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9041 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9042 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9043 * w32proc.c (Qlocal, report_file_error):
9044 * w32term.c (Vwindow_system, updating_frame):
9045 * w32uniscribe.c (initialized, uniscribe_font_driver):
9046 Remove unneeded extern declarations.
9048 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9050 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9052 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9054 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9055 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9056 These macros can no longer be used for assignment.
9058 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9059 Assign struct members directly, instead of using BUF_BEGV etc.
9060 (record_buffer_markers, fetch_buffer_markers): New functions for
9061 recording and fetching special buffer markers.
9062 (set_buffer_internal_1, set_buffer_temp): Use them.
9064 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9066 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9068 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9069 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9071 * xdisp.c (hscroll_window_tree):
9072 (reconsider_clip_changes): Use PT instead of BUF_PT.
9074 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9076 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9077 $(EMACS_ROOT)/lib/intprops.h.
9079 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9081 Fix more problems found by GCC 4.5.2's static checks.
9083 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9084 to unsigned char * to avoid compiler diagnostic.
9085 (xg_free_frame_widgets): Make it clear that a local variable is
9086 needed only if USE_GTK_TOOLTIP.
9087 (gdk_window_get_screen): Make it clear that this macro is needed
9088 only if USE_GTK_TOOLTIP.
9089 (int_gtk_range_get_value): New function, which avoids a diagnostic
9090 from gcc -Wbad-function-cast.
9091 (xg_set_toolkit_scroll_bar_thumb): Use it.
9092 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9093 diagnostic from gcc -Wbad-function-cast.
9094 (get_utf8_string, xg_get_file_with_chooser):
9095 Rename locals to avoid shadowing.
9096 (create_dialog): Move locals to avoid shadowing.
9098 * xgselect.c (xg_select): Remove unused var.
9100 * image.c (four_corners_best): Mark locals as initialized.
9101 (gif_load): Initialize transparent_p to zero (Bug#8238).
9102 Mark another local as initialized.
9103 (my_png_error, my_error_exit): Mark with NO_RETURN.
9105 * image.c (clear_image_cache): Now static.
9106 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9107 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9108 (x_edge_detection): Remove unnecessary cast that
9109 gcc -Wbad-function-cast diagnoses.
9110 (gif_load): Fix pointer signedness.
9111 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9112 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9114 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9116 Improve quality of tests for time stamp overflow.
9117 For example, without this patch (encode-time 0 0 0 1 1
9118 1152921504606846976) returns the obviously-bogus value (-948597
9119 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9120 reports time overflow. See
9121 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9122 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9123 * editfns.c: Include limits.h and intprops.h.
9124 (TIME_T_MIN, TIME_T_MAX): New macros.
9125 (time_overflow): Move earlier, to before first use.
9126 (hi_time, lo_time): New functions, for an accurate test for
9128 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9129 (Fget_internal_run_time): Don't assume time_t fits in int.
9130 (make_time): Use list2 instead of Fcons twice.
9131 (Fdecode_time): More accurate test for out-of-range times.
9132 (check_tm_member): New function.
9133 (Fencode_time): Use it, to test for out-of-range times.
9134 (lisp_time_argument): Don't rely on undefined left-shift and
9135 right-shift behavior when checking for time stamp overflow.
9137 * editfns.c (time_overflow): New function, refactoring common code.
9138 (Fformat_time_string, Fdecode_time, Fencode_time):
9139 (Fcurrent_time_string): Use it.
9141 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9142 * dired.c (make_time): Move to ...
9143 * editfns.c (make_time): ... here.
9144 * systime.h: Note the move.
9146 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9148 * fringe.c (update_window_fringes): Remove unused variables.
9150 * unexmacosx.c (copy_data_segment): Also copy __got section.
9153 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9155 * termcap.c [MSDOS]: Include "msdos.h".
9156 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9157 Constify `char *' arguments and their references according to
9158 prototypes in tparam.h.
9160 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9162 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9163 Adapt all references accordingly.
9165 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9167 2011-03-11 Tom Tromey <tromey@redhat.com>
9169 * buffer.c (syms_of_buffer): Remove obsolete comment.
9171 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9173 * termhooks.h (encode_terminal_code): Declare prototype.
9175 * msdos.c (encode_terminal_code): Don't declare prototype.
9177 * term.c (encode_terminal_code): Now external again, used by
9178 w32console.c and msdos.c.
9180 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9181 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9183 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9185 Fix some minor problems found by GCC 4.5.2's static checks.
9187 * fringe.c (update_window_fringes): Mark locals as initialized
9189 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9191 * alloc.c (mark_fringe_data): Move decl from here ...
9192 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9193 to check its interface.
9194 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9196 * fontset.c (free_realized_fontset): Now static.
9197 (Fset_fontset_font): Rename local to avoid shadowing.
9198 (fontset_font): Mark local as initialized.
9199 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9201 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9203 * xselect.c (x_disown_buffer_selections): Remove; not used.
9204 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9205 (x_own_selection, Fx_disown_selection_internal): Rename locals
9207 (x_handle_dnd_message): Remove local to avoid shadowing.
9209 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9210 so that the caller can use some name other than gcpro1.
9211 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9212 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9213 (Fx_backspace_delete_keys_p):
9214 Use them to avoid shadowing, and rename vars to avoid shadowing.
9215 (x_decode_color, x_set_name, x_window): Now static.
9216 (Fx_create_frame): Add braces to silence GCC warning.
9217 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9218 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9219 Remove unused locals.
9220 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9221 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9222 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9225 * xterm.h (x_mouse_leave): New decl.
9227 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9228 Remove unused functions.
9229 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9230 (x_calc_absolute_position): Now static.
9231 (XTread_socket): Don't define label "out" unless it's used.
9232 Don't declare local "event" unless it's used.
9233 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9234 unless they are used.
9235 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9236 (x_fatal_error_signal): Remove; not used.
9237 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9238 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9239 (x_error_catcher, x_connection_closed, x_error_handler):
9240 (x_error_quitter, xembed_send_message, x_iconify_frame):
9241 (my_log_handler): Rename locals to avoid shadowing.
9242 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9243 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9245 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9246 Rename or move locals to avoid shadowing.
9247 (tty_defined_color, merge_face_heights): Now static.
9248 (free_realized_faces_for_fontset): Remove; not used.
9249 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9250 does not deduce is never used uninitialized.
9251 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9252 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9254 * terminal.c (store_terminal_param): Now static.
9256 * xmenu.c (menu_highlight_callback): Now static.
9257 (set_frame_menubar): Remove unused local.
9258 (xmenu_show): Rename parameter to avoid shadowing.
9259 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9260 since they might point to immutable storage.
9261 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9262 since it's unused otherwise.
9264 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9265 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9266 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9267 avoids a gcc -Wuninitialized diagnostic.
9268 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9269 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9270 does not deduce are never used uninitialized.
9272 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9274 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9275 * window.c (window_loop, size_window):
9276 (run_window_configuration_change_hook, enlarge_window): Likewise.
9278 * window.c (display_buffer): Now static.
9279 (size_window): Mark variables that gcc -Wuninitialized
9280 does not deduce are never used uninitialized.
9281 * window.h (check_all_windows): New decl, to forestall
9282 gcc -Wmissing-prototypes diagnostic.
9283 * dispextern.h (bidi_dump_cached_states): Likewise.
9285 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9287 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9289 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9290 and to avoid gcc -Wuninitialized warning.
9291 (load_charset_map): Mark variables that gcc -Wuninitialized
9292 does not deduce are never used uninitialized.
9293 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9295 * coding.c (coding_set_source, coding_set_destination):
9296 Use "else { /* comment */ }" rather than "else /* comment */;"
9297 for clarity, and to avoid gcc -Wempty-body warning.
9298 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9299 a block, when the outer 'i' will do.
9300 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9301 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9302 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9303 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9304 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9305 Rename locals to avoid shadowing.
9306 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9307 * coding.c (emacs_mule_char, encode_invocation_designation):
9308 Now static, since they're not used elsewhere.
9309 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9310 (decode_coding_object, encode_coding_object, detect_coding_system):
9311 (decode_coding_emacs_mule): Mark variables that gcc
9312 -Wuninitialized does not deduce are never used uninitialized.
9313 (detect_coding_iso_2022): Initialize a local variable that might
9314 be used uninitialized. Leave a FIXME because it's not clear that
9315 this initialization is needed. (Bug#8211)
9316 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9317 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9318 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9319 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9320 Remove unused macros.
9322 * category.c (hash_get_category_set): Remove unused local var.
9323 (copy_category_table): Now static, since it's not used elsewhere.
9324 * character.c (string_count_byte8): Likewise.
9326 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9327 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9329 * chartab.c (copy_sub_char_table): Now static, since it's not used
9331 (sub_char_table_ref_and_range, char_table_ref_and_range):
9332 Rename locals to avoid shadowing.
9333 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9335 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9336 (BIDI_BOB): Remove unused macro.
9338 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9339 deduce are never used uninitialized.
9340 * term.c (encode_terminal_code): Likewise.
9342 * term.c (encode_terminal_code): Now static. Remove unused local.
9344 * tparam.h: New file.
9345 * term.c, tparam.h: Include it.
9346 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9347 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9348 Move these decls to tparam.h, and make them agree with what
9349 is actually in tparam.c. The previous trick of using incompatible
9350 decls in different modules does not conform to the C standard.
9351 All callers of tparam changed to use tparam's actual API.
9352 * tparam.c (tparam1, tparam, tgoto):
9353 Use const pointers where appropriate.
9355 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9356 * cm.h (struct cm): Likewise.
9357 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9358 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9359 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9360 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9361 (turn_on_face, init_tty): Likewise.
9362 * termchar.h (struct tty_display_info): Likewise.
9364 * term.c (term_mouse_position): Rename local to avoid shadowing.
9366 * alloc.c (mark_ttys): Move decl from here ...
9367 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9369 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9371 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9373 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9375 * search.c (compile_pattern_1): Remove argument regp, unused since
9376 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9377 (compile_pattern): Don't pass it.
9379 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9381 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9382 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9384 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9386 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9388 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9389 gdk_window_get_screen, gdk_window_get_geometry,
9390 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9391 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9392 (xg_get_pixbuf_from_pixmap): New function.
9393 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9394 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9395 Call xg_get_pixbuf_from_pixmap instead of
9396 gdk_pixbuf_get_from_drawable.
9397 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9398 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9399 (xg_check_special_colors): Use GtkStyleContext and its functions
9401 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9402 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9403 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9404 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9405 Call gtk_widget_get_preferred_size.
9406 (xg_frame_resized): gdk_window_get_geometry only takes 5
9408 (xg_win_to_widget, xg_event_is_for_menubar):
9409 Call gdk_x11_window_lookup_for_display.
9410 (xg_set_widget_bg): New function.
9411 (delete_cb): New function.
9412 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9413 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9414 (xg_set_background_color): Call xg_set_widget_bg.
9415 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9416 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9417 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9418 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9420 (update_frame_tool_bar): Call gtk_widget_hide.
9421 (xg_initialize): Use GDK_KEY_g.
9423 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9425 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9427 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9428 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9429 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9431 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9433 * w32xfns.c (select_palette): Check success of RealizePalette against
9434 GDI_ERROR, not zero.
9436 See ChangeLog.11 for earlier changes.
9442 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9444 This file is part of GNU Emacs.
9446 GNU Emacs is free software: you can redistribute it and/or modify
9447 it under the terms of the GNU General Public License as published by
9448 the Free Software Foundation, either version 3 of the License, or
9449 (at your option) any later version.
9451 GNU Emacs is distributed in the hope that it will be useful,
9452 but WITHOUT ANY WARRANTY; without even the implied warranty of
9453 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9454 GNU General Public License for more details.
9456 You should have received a copy of the GNU General Public License
9457 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.