* scroll.c: Integer and memory overflow fixes.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * scroll.c: Integer and memory overflow fixes.
4 (do_line_insertion_deletion_costs): Check for size calculation overflow.
5 Don't bother calling xmalloc when xrealloc will do.
6
7 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8
9 * process.c (Fnetwork_interface_list): Check for overflow
10 in size calculation.
11
12 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
13 Now ptrdiff_t, not int.
14 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
15 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
16
17 * minibuf.c (read_minibuf_noninteractive): Don't leak memory
18 on memory overflow.
19
20 * macros.c: Integer and memory overflow fixes.
21 (Fstart_kbd_macro): Don't update size until alloc done.
22 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
23
24 * lread.c (read1, init_obarray): Don't update size until alloc done.
25
26 * keymap.c: Integer overflow fixes.
27 (cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
28 (current_minor_maps): Check for size calculation overflow.
29 * keymap.h: Change prototypes to match the above.
30
31 * keyboard.c: Integer and memory overflow fixes.
32 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
33 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
34 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
35 (read_char_minibuf_menu_prompt): Check for overflow in size
36 calculations. Don't update size until allocation succeeds. Redo
37 calculations to avoid overflow.
38 * keyboard.h: Change prototypes to match the above.
39
40 * image.c: Integer and memory overflow fixes.
41 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
42 now that they've been promoted to lisp.h.
43 (x_allocate_bitmap_record, x_alloc_image_color)
44 (make_image_cache, cache_image, xpm_load):
45 Don't update size until alloc is done.
46 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
47 (x_detect_edges):
48 Check for size calculation overflow.
49 (ct_colors_allocated_max): New constant.
50 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
51 overflow.
52
53 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
54
55 * gtkutil.c: Integer overflow fixes.
56 (get_utf8_string, xg_store_widget_in_map):
57 Check for size-calculation overflow.
58 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
59 do, as we prefer signed integers.
60 (id_to_widget.max_size, id_to_widget.used)
61 (xg_store_widget_in_map, xg_remove_widget_from_map)
62 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
63 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
64 Use and return ptrdiff_t, not int.
65 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
66 * gtkutil.h: Change prototypes to match the above.
67
68 * ftfont.c: Check for size overflow.
69 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
70 Check for integer overflow in size calculations.
71
72 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
73
74 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
75 This is for the members text_lines, text_cols, total_lines, total_cols,
76 where the system imposes an 'int' limit.
77
78 * frame.c: Integer overflow fixes.
79 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
80 (x_figure_window_size): Check for integer overflow.
81 (x_set_alpha): Do not assume XINT fits in int.
82
83 * eval.c: Integer and memory overflow fixes.
84 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
85 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
86
87 * emacs.c (main, sort_args): Check for size-calculation overflow.
88
89 * editfns.c: Integer and memory overflow fixes.
90 (set_time_zone_rule): Don't assume environment length fits in int.
91 (message_length): Now ptrdiff_t, not int.
92 (Fmessage_box): Don't update size until allocation succeeds.
93 Don't assume message length fits in int.
94 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
95
96 * doc.c: Integer and memory overflow fixes.
97 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
98 (get_doc_string): Check for size calculation overflow.
99 Don't update size until allocation succeeds.
100 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
101 EMACS_INT, where ptrdiff_t will do.
102 (Fsubstitute_command_keys): Check for string overflow.
103
104 Integer and memory overflow fixes for display code.
105 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
106 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
107 Check for overflow in size calculations.
108 (line_draw_cost, realloc_glyph_pool, add_row_entry):
109 Don't assume glyph table len fits in int.
110 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
111 (row_table_size): Now ptrdiff_t, not int.
112 (scrolling_window): Avoid overflow in size calculations.
113 Don't update size until allocation succeeds.
114 * fns.c (concat): Check for overflow in size calculations.
115 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
116 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
117 (NEXT_ALMOST_PRIME_LIMIT): New constant.
118
119 * composite.c: Integer overflow fixes.
120 (get_composition_id): Check for overflow in glyph length calculations.
121
122 * coding.c: Integer and memory overflow fixes.
123 (produce_chars): Redo buffer-overflow calculations to avoid
124 unnecessary integer overflow. Check for size overflow.
125 (encode_coding_object): Don't update size until xmalloc succeeds.
126
127 * character.c (Fstring): Check for size-calculation overflow.
128
129 * ccl.c: Integer and memory overflow fixes.
130 (Fccl_execute_on_string): Check for memory overflow.
131 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
132 Redo buffer-overflow calculations to avoid integer overflow.
133
134 * callproc.c (child_setup): Don't assume strlen fits in int.
135
136 * buffer.c: Memory overflow fixes.
137 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
138 Don't update size of array until after memory allocation succeeds,
139 because xmalloc/xrealloc may not return.
140
141 * bidi.c: Integer overflow fix.
142 (bidi_shelve_header_size): New constant.
143 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
144 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
145
146 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
147
148 Use ptrdiff_t for composition IDs.
149 * character.c (lisp_string_width):
150 * composite.c (composition_table_size, n_compositions)
151 (get_composition_id, composition_gstring_from_id):
152 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
153 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
154 * window.c (Frecenter):
155 Use ptrdiff_t, not int, for composition IDs.
156 * composite.c (get_composition_id): Check for integer overflow.
157 * composite.h: Adjust prototypes to match the above changes.
158
159 Use ptrdiff_t for hash table indexes.
160 * category.c (hash_get_category_set):
161 * ccl.c (ccl_driver):
162 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
163 * coding.c (coding_system_charset_list, detect_coding_system):
164 * coding.h (struct coding_system.id):
165 * composite.c (get_composition_id, gstring_lookup_cache):
166 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
167 * image.c (xpm_get_color_table_h):
168 * lisp.h (hash_lookup, hash_put):
169 * minibuf.c (Ftest_completion):
170 Use ptrdiff_t for hash table indexes, not int (which is too
171 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
172 32-bit --with-wide-int hosts).
173
174 * charset.c (Fdefine_charset_internal): Check for integer overflow.
175 Add a FIXME comment about memory leaks.
176 (syms_of_charset): Don't assume xmalloc returns.
177
178 Don't assume that stated character widths fit in int.
179 * character.c (Fchar_width, c_string_width, lisp_string_width):
180 * character.h (CHAR_WIDTH):
181 * indent.c (MULTIBYTE_BYTES_WIDTH):
182 Use sanitize_char_width to avoid undefined and/or bad behavior
183 with outlandish widths.
184 * character.h (sanitize_tab_width): Renamed from sanitize_width,
185 now that we have two such functions. All uses changed.
186 (sanitize_char_width): New inline function.
187
188 Don't assume that tab-width fits in int.
189 * character.h (sanitize_width): New inline function.
190 (SANE_TAB_WIDTH): New macro.
191 (ASCII_CHAR_WIDTH): Use it.
192 * indent.c (sane_tab_width): Remove. All uses replaced by
193 SANE_TAB_WIDTH (current_buffer).
194 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
195
196 * fileio.c: Integer overflow issues with file modes.
197 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
198
199 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
200 Remove unreachable code.
201 (read_hex, load_charset_map_from_file): Check for integer overflow.
202
203 * xterm.c: don't go over XClientMessageEvent limit
204 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
205 (x_send_scroll_bar_event): Likewise. Check that the size does not
206 exceed limits imposed by XClientMessageEvent, as well as the usual
207 ptrdiff_t and size_t limits.
208
209 * keyboard.c: Overflow, signedness and related fixes.
210 (make_lispy_movement): Use same integer type in forward decl
211 that is used in the definition.
212 (read_key_sequence, keyremap_step):
213 Change bufsize argument back to int, undoing my 2011-03-30 change.
214 We prefer signed types, and int is wide enough here.
215 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
216 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
217 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
218 length, not size_t. Use ptrdiff_t for index, not int.
219 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
220 possibility of integer overflow.
221
222 Overflow, signedness and related fixes for images.
223
224 * dispextern.h (struct it.stack[0].u.image.image_id)
225 (struct_it.image_id, struct image.id, struct image_cache.size)
226 (struct image_cache.used, struct image_cache.ref_count):
227 * gtkutil.c (update_frame_tool_bar):
228 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
229 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
230 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
231 * nsmenu.m (update_frame_tool_bar):
232 * xdisp.c (calc_pixel_width_or_height):
233 * xfns.c (image_cache_refcount):
234 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
235 on typical 64-bit hosts.
236
237 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
238 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
239 Omit unnecessary casts to int.
240 (parse_image_spec): Check that integers fall into 'int' range
241 when the callers expect that.
242 (image_ascent): Redo ascent calculation to avoid int overflow.
243 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
244 (lookup_image): Remove unnecessary tests.
245 (xbm_image_p): Locals are now of int, not EMACS_INT,
246 since parse_image_check makes sure they fit into int.
247 (png_load, gif_load, svg_load_image):
248 Prefer int to unsigned where either will do.
249 (tiff_handler): New function, combining the cores of the
250 old tiff_error_handler and tiff_warning_handler. This
251 function is rewritten to use vsnprintf and thereby avoid
252 stack buffer overflows. It uses only the features of vsnprintf
253 that are common to both POSIX and native Microsoft.
254 (tiff_error_handler, tiff_warning_handler): Use it.
255 (tiff_load, gif_load, imagemagick_load_image):
256 Don't assume :index value fits in 'int'.
257 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
258 (imagemagick_load_image): Check that crop parameters fit into
259 the integer types that MagickCropImage accepts. Don't assume
260 Vimagemagick_render_type has a nonnegative value. Don't assume
261 size_t fits in 'long'.
262 (gs_load): Use printmax_t to print the widest integers possible.
263 Check for integer overflow when computing image height and width.
264
265 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
266
267 Integer signedness and overflow and related fixes. (Bug#9079)
268
269 * bidi.c: Integer size and overflow fixes.
270 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
271 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
272 (bidi_cache_find_level_change, bidi_cache_ensure_space)
273 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
274 (bidi_find_other_level_edge):
275 Use ptrdiff_t instead of EMACS_INT where either will do.
276 This works better on 32-bit hosts configured --with-wide-int.
277 (bidi_cache_ensure_space): Check for size-calculation overflow.
278 Use % rather than repeated addition, for better worst-case speed.
279 Don't set bidi_cache_size until after xrealloc returns, because it
280 might not return.
281 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
282 (bidi_cache_ensure_space): Also check that the bidi cache size
283 does not exceed that of the largest Lisp string or buffer. See Eli
284 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
285
286 * alloc.c (__malloc_size_t): Remove.
287 All uses replaced by size_t. See Andreas Schwab's note
288 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
289
290 * image.c: Improve checking for integer overflow.
291 (check_image_size): Assume that f is nonnull, since
292 it is always nonnull in practice. This is one less thing to
293 worry about when checking for integer overflow later.
294 (x_check_image_size): New function, which checks for integer
295 overflow issues inside X.
296 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
297 This removes the need for a memory_full check.
298 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
299 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
300 (xbm_read_bitmap_data): Change locals back to 'int', since
301 their values must fit in 'int'.
302 (xpm_load_image, png_load, tiff_load):
303 Invoke x_create_x_image_and_pixmap earlier,
304 to avoid much needless work if the image is too large.
305 (tiff_load): Treat overly large images as if
306 x_create_x_image_and_pixmap failed, not as malloc failures.
307 (gs_load): Use x_check_image_size.
308
309 * gtkutil.c: Omit integer casts.
310 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
311 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
312
313 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
314
315 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
316 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
317 would wrongly return t on a 64-bit host.
318
319 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
320 The plain *_OVERFLOW macros run afoul of GCC bug 49705
321 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
322 and therefore cause GCC to emit a bogus diagnostic in some cases.
323
324 * image.c: Integer signedness and overflow and related fixes.
325 This is not an exhaustive set of fixes, but it's time to
326 record what I've got.
327 (lookup_pixel_color, check_image_size): Remove redundant decls.
328 (check_image_size): Don't assume that arbitrary EMACS_INT values
329 fit in 'int', or that arbitrary 'double' values fit in 'int'.
330 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
331 (tiff_load, imagemagick_load_image):
332 Check for overflow in size calculations.
333 (x_create_x_image_and_pixmap): Remove unnecessary test for
334 xmalloc returning NULL; that can't happen.
335 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
336 (xpm_color_bucket): Use better integer hashing function.
337 (xpm_cache_color): Don't possibly over-allocate memory.
338 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
339 (gif_memory_source):
340 Use ptrdiff_t, not int or size_t, to record sizes.
341 (png_load): Don't assume values greater than 2**31 fit in 'int'.
342 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
343 either works, as we prefer signed integers.
344 (tiff_read_from_memory, tiff_write_from_memory):
345 Return tsize_t, not size_t, since that's what the TIFF API wants.
346 (tiff_read_from_memory): Don't fail simply because the read would
347 go past EOF; instead, return a short read.
348 (tiff_load): Omit no-longer-needed casts.
349 (Fimagemagick_types): Don't assume size fits into 'int'.
350
351 Improve hashing quality when configured --with-wide-int.
352 * fns.c (hash_string): New function, taken from sxhash_string.
353 Do not discard information about ASCII character case; this
354 discarding is no longer needed.
355 (sxhash-string): Use it. Change sig to match it. Caller changed.
356 * lisp.h: Declare it.
357 * lread.c (hash_string): Remove, since we now use fns.c's version.
358 The fns.c version returns a wider integer if --with-wide-int is
359 specified, so this should help the quality of the hashing a bit.
360
361 * emacs.c: Integer overflow minor fix.
362 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
363 Define only if GNU_LINUX.
364 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
365
366 * dispnew.c: Integer signedness and overflow fixes.
367 Remove unnecessary forward decls, that were a maintenance hassle.
368 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
369 All uses changed.
370 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
371 (scrolling_window): Use ptrdiff_t, not int, for byte count.
372 (prepare_desired_row, line_draw_cost):
373 Use int, not unsigned, where either works.
374 (save_current_matrix, restore_current_matrix):
375 Use ptrdiff_t, not size_t, where either works.
376 (init_display): Check for overflow more accurately, and without
377 relying on undefined behavior.
378
379 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
380 Remove, replacing with the new symbols in lisp.h. All uses changed.
381 * fileio.c (make_temp_name):
382 * filelock.c (lock_file_1, lock_file):
383 * xdisp.c (message_dolog):
384 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
385 Use pMd etc. instead.
386 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
387 replacing the pWIDE etc. symbols removed from editfns.c.
388
389 * keyboard.h (num_input_events): Now uintmax_t.
390 This is (very slightly) less likely to mess up due to wraparound.
391 All uses changed.
392
393 * buffer.c: Integer signedness fixes.
394 (alloc_buffer_text, enlarge_buffer_text):
395 Use ptrdiff_t rather than size_t when either will do, as we prefer
396 signed integers.
397
398 * alloc.c: Integer signedness and overflow fixes.
399 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
400 (__malloc_size_t): Default to size_t, not to int.
401 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
402 (Fgarbage_collect, mark_object_loop_halt, mark_object):
403 Prefer ptrdiff_t to size_t when either would do, as we prefer
404 signed integers.
405 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
406 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
407 Now const. Initialize with values that are in range even if char
408 is signed.
409 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
410 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
411 These functions do the right thing with sizes > 2**32.
412 (check_depth): Now ptrdiff_t, not int.
413 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
414 Adjust to new way of storing sizes. Check for size overflow bugs
415 in rest of code.
416 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
417 slightly wrong anyway, as it missed one instance of
418 XMALLOC_OVERRUN_CHECK_OVERHEAD.
419 (refill_memory_reserve): Omit needless cast to size_t.
420 (mark_object_loop_halt): Mark as externally visible.
421
422 * xselect.c: Integer signedness and overflow fixes.
423 (Fx_register_dnd_atom, x_handle_dnd_message):
424 Use ptrdiff_t, not size_t, since we prefer signed.
425 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
426 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
427 x_dnd_atoms_size and x_dnd_atoms_length.
428
429 * doprnt.c: Prefer signed to unsigned when either works.
430 * eval.c (verror):
431 * doprnt.c (doprnt):
432 * lisp.h (doprnt):
433 * xdisp.c (vmessage):
434 Use ptrdiff_t, not size_t, when using or implementing doprnt,
435 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
436 prefer signed arithmetic to avoid comparison confusion.
437 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
438 but is a bit tricky.
439
440 Assume freestanding C89 headers, string.h, stdlib.h.
441 * data.c, doprnt.c, floatfns.c, print.c:
442 Include float.h unconditionally.
443 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
444 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
445 * regex.c: Likewise for stddef.h, string.h.
446 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
447 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
448 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
449 (STDC_HEADERS): Remove obsolete defines.
450 * sysdep.c: Include limits.h unconditionally.
451
452 Assume support for memcmp, memcpy, memmove, memset.
453 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
454 * regex.c (memcmp, memcpy):
455 Remove; we assume C89 now.
456
457 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
458 (__malloc_safe_bcopy): Remove; no longer needed.
459
460 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
461 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
462 well either way, and we prefer signed to unsigned.
463
464 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
465
466 Port to OpenBSD.
467 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
468 and the surrounding thread.
469 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
470 rather than fgets, and retry after EINTR. Otherwise, 'emacs
471 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
472 timer goes off.
473 * s/openbsd.h (BROKEN_SIGIO): Define.
474 * unexelf.c (unexec) [__OpenBSD__]:
475 Don't update the .mdebug section of the Alpha COFF symbol table.
476
477 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
478
479 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
480 (bug#8460).
481
482 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
483
484 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
485 This fixes some race conditions on the permissions of any newly
486 created file.
487
488 * alloc.c (valid_pointer_p): Use pipe, not open.
489 This fixes some permissions issues when debugging.
490
491 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
492 If fchown fails to set both uid and gid, try to set just gid,
493 as that is sometimes allowed. Adjust the file's mode to eliminate
494 setuid or setgid bits that are inappropriate if fchown fails.
495
496 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
497
498 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
499 to compare Lisp_Objects.
500 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
501 global_gnutls_log_level, don't mistake it for a Lisp_Object.
502 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
503
504 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
505
506 * lread.c (read_integer): Unread even EOF character.
507 (read1): Likewise. Properly record start position of symbol.
508
509 * lread.c (read1): Read `#:' as empty uninterned symbol if no
510 symbol character follows.
511
512 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
513
514 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
515 This works around a problem with the previous change to Fcopy_file.
516 Recent glibc declares fchown with __attribute__((warn_unused_result)),
517 and without this change, GCC might complain about discarding
518 fchown's return value.
519
520 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
521
522 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
523
524 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
525
526 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
527
528 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
529
530 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
531 it's used from the C level.
532
533 * process.c: Use the same condition for POLL_FOR_INPUT in both
534 keyboard.c and process.c (bug#1858).
535
536 2011-07-09 Lawrence Mitchell <wence@gmx.li>
537
538 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
539 (Fgnutls_boot): Use it.
540
541 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
542
543 * doc.c (Fsubstitute_command_keys): Revert last change.
544
545 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
546
547 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
548 quotes the next character, and doesn't affect other longer
549 sequences (bug#8935).
550
551 * lread.c (syms_of_lread): Clarify that is isn't only
552 `eval-buffer' and `eval-defun' that's affected by
553 `lexical-binding' (bug#8460).
554
555 2011-07-15 Eli Zaretskii <eliz@gnu.org>
556
557 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
558 bidi redisplay when a line includes both an image and is
559 truncated.
560
561 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
562
563 Fix minor problems found by static checking.
564 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
565 (elsz): Now a signed constant, not a size_t var. We prefer signed
566 types to unsigned, to avoid integer comparison confusion. Without
567 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
568 "cannot optimize loop, the loop counter may overflow", a symptom
569 of the confusion.
570 * indent.c (Fvertical_motion): Mark locals as initialized.
571 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
572
573 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
574
575 * search.c (Fre_search_backward): Mention `case-fold-search' in
576 all the re_search_* functions (bug#8138).
577
578 * keyboard.c (Fopen_dribble_file): Document when the file is
579 closed (bug#8056).
580
581 2011-07-14 Eli Zaretskii <eliz@gnu.org>
582
583 * bidi.c (bidi_dump_cached_states): Fix format of displaying
584 bidi_cache_idx.
585
586 Support bidi reordering of display and overlay strings.
587 * xdisp.c (compute_display_string_pos)
588 (compute_display_string_end): Accept additional argument STRING.
589 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
590 (reseat_to_string): Initialize bidi_it->string.s and
591 bidi_it->string.schars.
592 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
593 NULL (avoids a crash in bidi_paragraph_init). Initialize
594 itb.string.lstring.
595 (init_iterator): Call bidi_init_it only of a valid
596 buffer position was specified. Initialize paragraph_embedding to
597 L2R.
598 (reseat_to_string): Initialize the bidi iterator.
599 (display_string): If we need to ignore text properties of
600 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
601 original value of -1 will not work with bidi.)
602 (compute_display_string_pos): First arg is now struct
603 `text_pos *'; all callers changed. Support display properties on
604 Lisp strings.
605 (compute_display_string_end): Support display properties on Lisp
606 strings.
607 (init_iterator, reseat_1, reseat_to_string): Initialize the
608 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
609 when iterating on a string not from display properties).
610 (compute_display_string_pos, compute_display_string_end): Fix
611 calculation of the object to scan. Fixes an error when using
612 arrow keys.
613 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
614 base_level_stop; instead, set base_level_stop to BEGV. Fixes
615 crashes in vertical-motion.
616 (next_element_from_buffer): Improve commentary for when
617 the iterator is before prev_stop.
618 (init_iterator): Initialize bidi_p from the default value of
619 bidi-display-reordering, not from buffer-local value. Use the
620 buffer-local value only if initializing for buffer iteration.
621 (handle_invisible_prop): Support invisible properties on strings
622 that are being bidi-reordered.
623 (set_iterator_to_next): Support bidi reordering of C strings and
624 Lisp strings.
625 (next_element_from_string): Support bidi reordering of Lisp
626 strings.
627 (handle_stop_backwards): Support Lisp strings as well.
628 (display_string): Support display of R2L glyph rows. Use
629 IT_STRING_CHARPOS when displaying from a Lisp string.
630 (init_iterator): Don't initialize it->bidi_p for strings
631 here.
632 (reseat_to_string): Initialize it->bidi_p for strings here.
633 (next_element_from_string, next_element_from_c_string)
634 (next_element_from_buffer): Add xassert's for correspondence
635 between IT's object being iterated and it->bidi_it.string
636 structure.
637 (face_before_or_after_it_pos): Support bidi iteration.
638 (next_element_from_c_string): Handle the case of the first string
639 character that is not the first one in the visual order.
640 (get_visually_first_element): New function, refactored from common
641 parts of next_element_from_buffer, next_element_from_string, and
642 next_element_from_c_string.
643 (tool_bar_lines_needed, redisplay_tool_bar)
644 (display_menu_bar): Force left-to-right direction. Add a FIXME
645 comment for making that be controlled by a user option.
646 (push_it, pop_it): Save and restore the state of the
647 bidi iterator. Save and restore the bidi_p flag.
648 (pop_it): Iterate out of display property for string iteration as
649 well.
650 (iterate_out_of_display_property): Support iteration over strings.
651 (handle_single_display_spec): Set up it->bidi_it for iteration
652 over a display string, and call bidi_init_it.
653 (handle_single_display_spec, next_overlay_string)
654 (get_overlay_strings_1, push_display_prop): Set up the bidi
655 iterator for displaying display or overlay strings.
656 (forward_to_next_line_start): Don't use the shortcut if
657 bidi-iterating.
658 (back_to_previous_visible_line_start): If handle_display_prop
659 pushed the iterator stack, restore the internal state of the bidi
660 iterator by calling bidi_pop_it same number of times.
661 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
662 and we are bidi-iterating, don't decrement the iterator position;
663 instead, set the first_elt flag in the bidi iterator, to produce
664 the same effect.
665 (reseat_1): Remove redundant setting of string_from_display_prop_p.
666 (push_display_prop): xassert that we are iterating a buffer.
667 (push_it, pop_it): Save and restore paragraph_embedding member.
668 (handle_single_display_spec, next_overlay_string)
669 (get_overlay_strings_1, reseat_1, reseat_to_string)
670 (push_display_prop): Set up the `unibyte' member of bidi_it.string
671 correctly. Don't assume unibyte strings are not bidi-reordered.
672 (compute_display_string_pos)
673 (compute_display_string_end): Fix handling the case of C string.
674 (push_it, pop_it): Save and restore from_disp_prop_p.
675 (handle_single_display_spec, push_display_prop): Set the
676 from_disp_prop_p flag.
677 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
678 (pop_it): Call iterate_out_of_display_property only if we are
679 popping after iteration over a string that came from a display
680 property. Fix a typo in popping stretch info. Add an assertion
681 for verifying that the iterator position is in sync with the bidi
682 iterator.
683 (handle_single_display_spec, get_overlay_strings_1)
684 (push_display_prop): Fix initialization of paragraph direction for
685 string when that of the parent object is not yet determined.
686 (reseat_1): Call bidi_init_it to resync the bidi
687 iterator with IT's position. (Bug#7616)
688 (find_row_edges): If ROW->start.pos gives position
689 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
690 (handle_stop, back_to_previous_visible_line_start, reseat_1):
691 Reset the from_disp_prop_p flag.
692 (SAVE_IT, RESTORE_IT): New macros.
693 (pos_visible_p, face_before_or_after_it_pos)
694 (back_to_previous_visible_line_start)
695 (move_it_in_display_line_to, move_it_in_display_line)
696 (move_it_to, move_it_vertically_backward, move_it_by_lines)
697 (try_scrolling, redisplay_window, display_line): Use them when
698 saving a temporary copy of the iterator and restoring it back.
699 (back_to_previous_visible_line_start, reseat_1)
700 (init_iterator): Empty the bidi cache "stack".
701 (move_it_in_display_line_to): If iterator ended up at
702 EOL, but we never saw any buffer positions smaller than
703 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
704 motion in bidi-reordered lines.
705 (move_it_in_display_line_to): Record prev_method and prev_pos
706 immediately before the call to set_iterator_to_next. Fixes cursor
707 motion in bidi-reordered lines with stretch glyphs and strings
708 displayed in margins. (Bug#8133) (Bug#8867)
709 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
710 TO_CHARPOS.
711 (pos_visible_p): Support positions in bidi-reordered lines. Save
712 and restore bidi cache.
713
714 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
715 (bidi_paragraph_info): Delete unused struct.
716 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
717 (bidi_cache_start): New variable.
718 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
719 to zero.
720 (bidi_cache_fetch_state, bidi_cache_search)
721 (bidi_cache_find_level_change, bidi_cache_iterator_state)
722 (bidi_cache_find, bidi_peek_at_next_level)
723 (bidi_level_of_next_char, bidi_find_other_level_edge)
724 (bidi_move_to_visually_next): Compare cache index with
725 bidi_cache_start rather than with zero.
726 (bidi_fetch_char): Accept new argument STRING; all callers
727 changed. Support iteration over a string. Support strings with
728 display properties. Support unibyte strings. Fix the type of
729 `len' according to what STRING_CHAR_AND_LENGTH expects.
730 (bidi_paragraph_init, bidi_resolve_explicit_1)
731 (bidi_resolve_explicit, bidi_resolve_weak)
732 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
733 iteration over a string.
734 (bidi_set_sor_type, bidi_resolve_explicit_1)
735 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
736 can now be zero (for strings); special values 0 and -1 were
737 changed to -1 and -2, respectively.
738 (bidi_char_at_pos): New function.
739 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
740 Call it instead of FETCH_MULTIBYTE_CHAR.
741 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
742 initialized to valid values.
743 (bidi_init_it): Don't initialize charpos and bytepos with invalid
744 values.
745 (bidi_level_of_next_char): Allow the sentinel "position" to pass
746 the test for valid cached positions. Fix the logic for looking up
747 the sentinel state in the cache. GCPRO the Lisp string we are
748 iterating.
749 (bidi_push_it, bidi_pop_it): New functions.
750 (bidi_initialize): Initialize the bidi cache start stack pointer.
751 (bidi_cache_ensure_space): New function, refactored from part of
752 bidi_cache_iterator_state. Don't assume the required size is just
753 one BIDI_CACHE_CHUNK away.
754 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
755 (bidi_count_bytes, bidi_char_at_pos): New functions.
756 (bidi_cache_search): Don't assume bidi_cache_last_idx is
757 always valid if bidi_cache_idx is valid.
758 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
759 is valid if it's going to be used.
760 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
761 (bidi_cache_fetch_state, bidi_cache_search)
762 (bidi_cache_find_level_change, bidi_cache_ensure_space)
763 (bidi_cache_iterator_state, bidi_cache_find)
764 (bidi_find_other_level_edge, bidi_cache_start_stack): All
765 variables related to cache indices are now EMACS_INT.
766
767 * dispextern.h (struct bidi_string_data): New structure.
768 (struct bidi_it): New member `string'. Make flag members be 1-bit
769 fields, and put them last in the struct.
770 (compute_display_string_pos, compute_display_string_end): Update
771 prototypes.
772 (bidi_push_it, bidi_pop_it): Add prototypes.
773 (struct iterator_stack_entry): New members bidi_p,
774 paragraph_embedding, and from_disp_prop_p.
775 (struct it): Member bidi_p is now a bit field 1 bit wide.
776 (bidi_shelve_cache, bidi_unshelve_cache): Declare
777 prototypes.
778
779 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
780 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
781 and vector-like objects.
782
783 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
784 cache around display iteration.
785
786 * window.c (Fwindow_end, window_scroll_pixel_based)
787 (displayed_window_lines, Frecenter): Save and restore the bidi
788 cache around display iteration.
789
790 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
791
792 * editfns.c (Fdelete_region): Clarify the use of the named
793 parameters (bug#6788).
794
795 2011-07-14 Martin Rudalics <rudalics@gmx.at>
796
797 * indent.c (Fvertical_motion): Set and restore w->pointm when
798 saving and restoring the window's buffer (Bug#9006).
799
800 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
801
802 * editfns.c (Fstring_to_char): Clarify just what is returned
803 (bug#6576). Text by Eli Zaretskii.
804
805 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
806
807 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
808
809 2011-07-13 Eli Zaretskii <eliz@gnu.org>
810
811 * buffer.c (mmap_find): Fix a typo.
812
813 2011-07-13 Johan Bockgård <bojohan@gnu.org>
814
815 Fix execution of x selection hooks.
816 * xselect.c (Qx_lost_selection_functions)
817 (Qx_sent_selection_functions): New vars.
818 (syms_of_xselect): DEFSYM them.
819 (x_handle_selection_request): Pass Qx_sent_selection_functions
820 rather than Vx_sent_selection_functions to Frun_hook_with_args.
821 (x_handle_selection_clear,x_clear_frame_selections):
822 Pass Qx_lost_selection_functions rather than
823 Vx_lost_selection_functions to Frun_hook_with_args.
824
825 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
826
827 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
828 The old code sometimes used this field without initializing it.
829
830 * alloc.c (gc_sweep): Don't read past end of array.
831 In theory, the old code could also have corrupted Emacs internals,
832 though it'd be very unlikely.
833
834 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
835
836 * character.c (Fcharacterp): Don't advertise optional ignored
837 argument. (Bug#4026)
838
839 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
840
841 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
842 key" (bug#4257).
843
844 * window.c (Fset_window_start): Doc fix (bug#4199).
845 (Fset_window_hscroll): Ditto.
846
847 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
848
849 Fix minor new problems caught by GCC 4.6.1.
850 * term.c (init_tty): Remove unused local.
851 * xsettings.c (store_monospaced_changed): Define this function only
852 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
853 not used otherwise.
854
855 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
856
857 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
858
859 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
860
861 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
862 are the mini-buffer and the echo area (bug#3320).
863
864 * term.c (init_tty): Remove support for supdup, c10 and perq
865 terminals, which are no longer supported (bug#1482).
866
867 2011-07-10 Johan Bockgård <bojohan@gnu.org>
868
869 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
870
871 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
872
873 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
874 for non-popups (Bug#3642).
875
876 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
877
878 * alloc.c (reset_malloc_hooks): Protoize.
879 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
880 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
881 * cm.c (losecursor): Likewise.
882 * data.c (fmod): Likewise.
883 * dispnew.c (swap_glyphs_in_rows): Likewise.
884 * emacs.c (memory_warning_signal): Likewise.
885 * floatfns.c (float_error): Likewise.
886 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
887 (otf_open, font_otf_capability, generate_otf_features)
888 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
889 Likewise.
890 * image.c (pbm_read_file): Likewise.
891 * indent.c (string_display_width): Likewise.
892 * intervals.c (check_for_interval, search_for_interval)
893 (inc_interval_count, count_intervals, root_interval)
894 (adjust_intervals_for_insertion, make_new_interval): Likewise.
895 * lread.c (defalias): Likewise.
896 * ralloc.c (r_alloc_check): Likewise.
897 * regex.c (set_image_of_range_1, set_image_of_range)
898 (regex_grow_registers): Likewise.
899 * sysdep.c (strerror): Likewise.
900 * termcap.c (valid_filename_p, tprint, main): Likewise.
901 * tparam.c (main): Likewise.
902 * unexhp9k800.c (run_time_remap, save_data_space)
903 (update_file_ptrs, read_header, write_header, calculate_checksum)
904 (copy_file, copy_rest, display_header): Likewise.
905 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
906 Likewise.
907 * xdisp.c (check_it): Likewise.
908 * xfaces.c (register_color, unregister_color, unregister_colors):
909 Likewise.
910 * xfns.c (print_fontset_result): Likewise.
911 * xrdb.c (member, fatal, main): Likewise.
912
913 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
914
915 Fix minor problems found by static checking (Bug#9031).
916 * chartab.c (char_table_set_range, map_sub_char_table):
917 Remove unused locals.
918 (uniprop_table): Now static.
919 * composite.c (_work_char): Remove unused static var.
920
921 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
922
923 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
924
925 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
926
927 * gtkutil.c (qttip_cb): Remove code without function.
928
929 2011-07-09 Eli Zaretskii <eliz@gnu.org>
930
931 * w32.c (pthread_sigmask): New stub.
932
933 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
934
935 Use pthread_sigmask, not sigprocmask (Bug#9010).
936 sigprocmask is portable only for single-threaded applications, and
937 Emacs can be multi-threaded when it uses GTK.
938 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
939 (LIBES): Use it.
940 * callproc.c (Fcall_process):
941 * process.c (create_process):
942 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
943 Use pthread_sigmask, not sigprocmask.
944
945 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
946
947 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
948 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
949 wrong (Bug#8591).
950
951 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
952
953 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
954 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
955 (xg_hide_tooltip): Fix comment.
956
957 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
958 in registerServicesMenuSendTypes.
959 (validRequestorForSendType): Don't check ns_return_types.
960
961 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
962 ns_return_type.
963
964 2011-07-08 Jason Rumney <jasonr@gnu.org>
965
966 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
967 frame struct members of non-existent frames (Bug#6284).
968
969 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
970
971 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
972 variable firstTime not needed on OSX >= 10.6.
973 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
974 >= 10.5. Use setKnobProportion, setDoubleValue.
975
976 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
977 (MAC_OS_X_VERSION_10_5): Define if not defined.
978 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
979 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
980 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
981
982 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
983 cString and lossyCString on OSX >= 10.4
984
985 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
986 sizeToFit on OSX >= 10.2.
987
988 * nsimage.m (allocInitFromFile): Don't use deprecated method
989 bestRepresentationForDevice on OSX >= 10.6.
990
991 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
992 to avoid warning.
993
994 * emacs.c: Declare unexec_init_emacs_zone.
995
996 * nsgui.h: Fix compiler warning about gnulib redefining verify.
997
998 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
999
1000 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1001 on svcsMenu (Bug#8842).
1002
1003 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1004 ns_return_types.
1005 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1006
1007 * nsterm.m (QUTF8_STRING): Declare.
1008 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1009 (validRequestorForSendType): Return type is (id).
1010 Change indexOfObjectIdenticalTo to indexOfObject.
1011 Check if we have local selection before returning self (Bug#8842).
1012 (writeSelectionToPasteboard): Put local selection into paste board
1013 if we have a local selection (Bug#8842).
1014 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1015
1016 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1017 (ns_get_local_selection): Declare.
1018
1019 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1020
1021 * keymap.c (describe_map_tree): Don't insert a double newline at
1022 the end of the buffer (bug#1169) and return whether we inserted
1023 something.
1024
1025 * callint.c (Fcall_interactively): Change "reading args" to
1026 "providing args" to try to clarify what it does (bug#1010).
1027
1028 2011-07-07 Kenichi Handa <handa@m17n.org>
1029
1030 * composite.c (composition_compute_stop_pos): Ignore a static
1031 composition starting before CHARPOS (Bug#8915).
1032
1033 * xdisp.c (handle_composition_prop): Likewise.
1034
1035 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1036
1037 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1038 (Bug#9015)
1039
1040 2011-07-07 Kenichi Handa <handa@m17n.org>
1041
1042 * character.h (unicode_category_t): New enum type.
1043
1044 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1045 (Qchar_code_property_table): New variable.
1046 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1047 (UNIPROP_COMPRESSED_FORM_P): New macros.
1048 (char_table_ascii): Uncompress the compressed values.
1049 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1050 Uncompress the compressed values.
1051 (sub_char_table_ref_and_range): Likewise.
1052 (char_table_ref_and_range): Uncompress the compressed values.
1053 (sub_char_table_set): New arg is_uniprop. Callers changed.
1054 Uncompress the compressed values.
1055 (sub_char_table_set_range): Args changed. Callers changed.
1056 (char_table_set_range): Adjuted for the above change.
1057 (map_sub_char_table): Delete args default_val and parent. Add arg
1058 top. Give decoded values to a Lisp function.
1059 (map_char_table): Adjusted for the above change. Give decoded
1060 values to a Lisp function. Gcpro more variables.
1061 (uniprop_table_uncompress)
1062 (uniprop_decode_value_run_length): New functions.
1063 (uniprop_decoder, uniprop_decoder_count): New variables.
1064 (uniprop_get_decoder, uniprop_encode_value_character)
1065 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1066 New functions.
1067 (uniprop_encoder, uniprop_encoder_count): New variables.
1068 (uniprop_get_encoder, uniprop_table)
1069 (Funicode_property_table_internal, Fget_unicode_property_internal)
1070 (Fput_unicode_property_internal): New functions.
1071 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1072 Sunicode_property_table_internal, Sget_unicode_property_internal,
1073 and Sput_unicode_property_internal. Defvar_lisp
1074 char-code-property-alist.
1075
1076 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1077 Vunicode_category_table.
1078
1079 * font.c (font_range): Adjusted for the change of
1080 Vunicode_category_table.
1081
1082 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1083
1084 * m/iris4d.h: Remove file, move contents ...
1085 * s/irix6-5.h: ... here.
1086
1087 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1088
1089 Remove unportable assumption about struct layout (Bug#8884).
1090 * alloc.c (mark_buffer):
1091 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1092 (clone_per_buffer_values): Don't assume that
1093 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1094 This isn't true in general, and it's particularly not true
1095 if Emacs is configured with --with-wide-int.
1096 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1097 New macros, used in the buffer.c change.
1098
1099 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1100
1101 * xsettings.c: Use both GConf and GSettings if both are available.
1102 (store_config_changed_event): Add comment.
1103 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1104 (store_tool_bar_style_changed): New functions.
1105 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1106 (struct xsettings): Move font inside HAVE_XFT.
1107 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1108 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1109 Move inside HAVE_XFT.
1110 (something_changed_gsettingsCB): Renamed from something_changedCB.
1111 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1112 also.
1113 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1114 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1115 (something_changed_gconfCB): Renamed from something_changedCB.
1116 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1117 (parse_settings): Move check for font inside HAVE_XFT.
1118 (read_settings, apply_xft_settings): Add comment.
1119 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1120 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1121 call store_font_name_changed.
1122 (xft_settings_event): Add comment.
1123 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1124 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1125 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1126 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1127 (xsettings_initialize): Call init_gsettings last.
1128 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1129 comment.
1130
1131 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1132
1133 Random fixes. E.g., (random) never returned negative values.
1134 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1135 subseconds part to the entropy, as that's a bit more random.
1136 Prefer signed to unsigned, since the signedness doesn't matter and
1137 in general we prefer signed. When given a limit, use a
1138 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1139 latter isn't right if USE_2_TAGS_FOR_INTS.
1140 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1141 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1142
1143 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1144
1145 * textprop.c (text_property_stickiness):
1146 Obey Vtext_property_default_nonsticky.
1147 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1148 * w32fns.c (syms_of_w32fns):
1149 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1150
1151 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1152
1153 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1154 This is more efficient than Ffile_directory_p and avoids a minor race.
1155
1156 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1157
1158 * buffer.c (Foverlay_put): Say what the return value is
1159 (bug#7835).
1160
1161 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1162 is a directory before asking whether to use the file name
1163 (bug#7564).
1164 (barf_or_query_if_file_exists): Make the "File is a directory"
1165 error be more correct.
1166
1167 * fns.c (Frequire): Remove the mention of the .gz files, since
1168 that's installation-specific, but keep the mention of
1169 `get-load-suffixes'.
1170
1171 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1172
1173 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1174 Report string overflow if the output is too long.
1175
1176 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1177
1178 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1179 (syms_of_gnutls): Remove duplicate DEFSYM for
1180 Qgnutls_bootprop_verify_hostname_error, an error for
1181 Qgnutls_bootprop_verify_error (which is no longer used).
1182
1183 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1184 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1185 Also (re)move comments that are misplaced or no longer relevant.
1186
1187 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1188
1189 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1190
1191 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1192
1193 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1194 and background color parameters if they have been changed.
1195
1196 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1197
1198 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1199
1200 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1201
1202 * xsettings.c (SYSTEM_FONT): Define only when used.
1203 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1204
1205 * keymap.c (access_keymap_1): Now static.
1206
1207 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1208
1209 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1210 leave any prefix arg for the up event (Bug#1586).
1211
1212 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1213
1214 * lread.c (syms_of_lread): Mention single symbols defined by
1215 `defvar' or `defconst' (bug#7154).
1216
1217 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1218 (Frequire): Mention get-load-suffixes.
1219
1220 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1221
1222 * window.h (window): Remove clone_number slot.
1223 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1224 Remove.
1225 (make_parent_window, make_window, saved_window)
1226 (Fset_window_configuration, save_window_save): Don't deal with
1227 clone numbers.
1228 * buffer.c (Qclone_number): Remove declaration.
1229 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1230
1231 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1232
1233 Add multiple inheritance to keymaps.
1234 * keymap.c (Fmake_composed_keymap): New function.
1235 (Fset_keymap_parent): Simplify.
1236 (fix_submap_inheritance): Remove.
1237 (access_keymap_1): New function extracted from access_keymap to handle
1238 embedded parents and handle lists of maps.
1239 (access_keymap): Use it.
1240 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1241 (Fcopy_keymap): Handle embedded parents.
1242 (Fcommand_remapping, define_as_prefix): Simplify.
1243 (Fkey_binding): Simplify.
1244 (syms_of_keymap): Move minibuffer-local-completion-map,
1245 minibuffer-local-filename-completion-map,
1246 minibuffer-local-must-match-map, and
1247 minibuffer-local-filename-must-match-map to Elisp.
1248 (syms_of_keymap): Defsubr make-composed-keymap.
1249 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1250 (parse_menu_item): Trivial simplification.
1251
1252 2011-07-01 Glenn Morris <rgm@gnu.org>
1253
1254 * Makefile.in (SETTINGS_LIBS): Fix typo.
1255
1256 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1257
1258 * coding.c (Fencode_coding_string): Record the last coding system
1259 used, as the function doc string says (bug#8738).
1260
1261 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1262
1263 * xsettings.c (store_monospaced_changed): Take new font as arg and
1264 check for change against current_mono_font.
1265 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1266 (emacs_settings_constructor, emacs_settings_get_property)
1267 (emacs_settings_set_property, emacs_settings_class_init)
1268 (emacs_settings_init, gsettings_obj): Remove.
1269 (something_changedCB): New function for HAVE_GSETTINGS.
1270 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1271 with value as argument.
1272 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1273 g_settings_new (Bug#8967). Do not create gsettings_obj.
1274 Remove calls to g_settings_bind. Connect something_changedCB to
1275 "changed".
1276
1277 * xgselect.c: Add defined (HAVE_GSETTINGS).
1278 (xgselect_initialize): Ditto.
1279
1280 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1281 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1282 xg_select.
1283
1284 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 * eval.c (struct backtrace): Simplify and port the data structure.
1287 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1288 signed bit field, as this assumption is not portable and it makes
1289 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1290 "char debug_on_exit : 1" as this is not portable either; instead,
1291 use the portable "unsigned int debug_on_exit : 1". Remove unused
1292 member evalargs. Remove obsolete comments about cc bombing out.
1293
1294 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1295
1296 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1297 Let HAVE_GSETTINGS override HAVE_GCONF.
1298 (store_monospaced_changed): New function.
1299 (EMACS_SETTINGS): A new type derived from GObject to handle
1300 GSettings notifications.
1301 (emacs_settings_constructor, emacs_settings_get_property)
1302 (emacs_settings_set_property, emacs_settings_class_init):
1303 New functions.
1304 (gsettings_client, gsettings_obj): New variables.
1305 (GSETTINGS_SCHEMA): New define.
1306 (something_changedCB): Call store_monospaced_changed.
1307 (init_gsettings): New function.
1308 (xsettings_initialize): Call init_gsettings.
1309 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1310 to NULL.
1311
1312 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1313 GCONF_CFLAGS/LIBS.
1314
1315 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1316
1317 * window.c (resize_root_window, grow_mini_window)
1318 (shrink_mini_window): Rename Qresize_root_window to
1319 Qwindow_resize_root_window and Qresize_root_window_vertically to
1320 Qwindow_resize_root_window_vertically.
1321
1322 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1323
1324 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1325
1326 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1327
1328 * makefile.w32-in: Redesign dependencies so they reflect more
1329 clearly which files are directly included by each source file,
1330 and not through other includes.
1331
1332 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1333
1334 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1335 (sort_overlays, overlay_strings): When an overlay's clone number
1336 matches the window's clone number process the overlay even if
1337 the overlay's window property doesn't match the current window.
1338
1339 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1340 (Fwindow_hchild): Rename to Fwindow_left_child.
1341 (Fwindow_next): Rename to Fwindow_next_sibling.
1342 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1343 (resize_window_check): Rename to window_resize_check.
1344 (resize_window_apply): Rename to window_resize_apply.
1345 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1346 (Fdelete_other_windows_internal, resize_frame_windows)
1347 (Fsplit_window_internal, Fdelete_window_internal)
1348 (grow_mini_window, shrink_mini_window)
1349 (Fresize_mini_window_internal): Fix callers accordingly.
1350
1351 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1352
1353 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1354 (emacs_fixed_set_min_size): Remove.
1355 (emacs_fixed_new): Take frame as argument.
1356
1357 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1358 (_EmacsFixedPrivate): Remove minwidth/height.
1359 Add struct frame *f.
1360 (emacs_fixed_init): Initialize priv->f.
1361 (get_parent_class, emacs_fixed_set_min_size): Remove.
1362 (emacs_fixed_new): Set priv->f to argument.
1363 (emacs_fixed_get_preferred_width)
1364 (emacs_fixed_get_preferred_height): Use min_width/height from
1365 frames size_hint to set minimum and natural (Bug#8919).
1366 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1367 and use min_width/height from frames size_hint to set
1368 min_width/height (Bug#8919).
1369
1370 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1371 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1372 Fix indentation.
1373
1374 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1375
1376 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1377 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1378 called at ZV.
1379
1380 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1381
1382 * process.c (wait_reading_process_output): Bypass select if
1383 waiting for a cell while ignoring keyboard input, and input is
1384 pending. Suggested by Jan Djärv (Bug#8869).
1385
1386 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 Use gnulib's dup2 module instead of rolling our own.
1389 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1390
1391 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1392
1393 * dispnew.c (scrolling_window): Before scrolling, turn off a
1394 mouse-highlight in the window being scrolled.
1395
1396 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1397
1398 Move DEFSYM to lisp.h and use everywhere.
1399
1400 * character.h (DEFSYM): Move declaration...
1401 * lisp.h (DEFSYM): ...here.
1402
1403 * gnutls.c:
1404 * minibuf.c:
1405 * w32menu.c:
1406 * w32proc.c:
1407 * w32select.c: Don't include character.h.
1408
1409 * alloc.c (syms_of_alloc):
1410 * buffer.c (syms_of_buffer):
1411 * bytecode.c (syms_of_bytecode):
1412 * callint.c (syms_of_callint):
1413 * casefiddle.c (syms_of_casefiddle):
1414 * casetab.c (init_casetab_once):
1415 * category.c (init_category_once, syms_of_category):
1416 * ccl.c (syms_of_ccl):
1417 * cmds.c (syms_of_cmds):
1418 * composite.c (syms_of_composite):
1419 * dbusbind.c (syms_of_dbusbind):
1420 * dired.c (syms_of_dired):
1421 * dispnew.c (syms_of_display):
1422 * doc.c (syms_of_doc):
1423 * editfns.c (syms_of_editfns):
1424 * emacs.c (syms_of_emacs):
1425 * eval.c (syms_of_eval):
1426 * fileio.c (syms_of_fileio):
1427 * fns.c (syms_of_fns):
1428 * frame.c (syms_of_frame):
1429 * fringe.c (syms_of_fringe):
1430 * insdel.c (syms_of_insdel):
1431 * keymap.c (syms_of_keymap):
1432 * lread.c (init_obarray, syms_of_lread):
1433 * macros.c (syms_of_macros):
1434 * msdos.c (syms_of_msdos):
1435 * print.c (syms_of_print):
1436 * process.c (syms_of_process):
1437 * search.c (syms_of_search):
1438 * sound.c (syms_of_sound):
1439 * syntax.c (init_syntax_once, syms_of_syntax):
1440 * terminal.c (syms_of_terminal):
1441 * textprop.c (syms_of_textprop):
1442 * undo.c (syms_of_undo):
1443 * w32.c (globals_of_w32):
1444 * window.c (syms_of_window):
1445 * xdisp.c (syms_of_xdisp):
1446 * xfaces.c (syms_of_xfaces):
1447 * xfns.c (syms_of_xfns):
1448 * xmenu.c (syms_of_xmenu):
1449 * xsettings.c (syms_of_xsettings):
1450 * xterm.c (syms_of_xterm): Use DEFSYM.
1451
1452 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1453
1454 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1455
1456 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1457
1458 Integer and buffer overflow fixes (Bug#8873).
1459
1460 * print.c (printchar, strout): Check for string overflow.
1461 (PRINTPREPARE, printchar, strout):
1462 Don't set size unless allocation succeeds.
1463
1464 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1465 for sizes. Check for string overflow more accurately.
1466 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1467
1468 * macros.c: Integer and buffer overflow fixes.
1469 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1470 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1471 Use ptrdiff_t, not int, for sizes.
1472 Don't increment bufsize until after realloc succeeds.
1473 Check for size-calculation overflow.
1474 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1475
1476 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1477
1478 * lread.c: Integer overflow fixes.
1479 (read_integer): Radix is now EMACS_INT, not int,
1480 to improve quality of diagnostics for out-of-range radices.
1481 Calculate buffer size correctly for out-of-range radices.
1482 (read1): Check for integer overflow in radices, and in
1483 read-circle numbers.
1484 (read_escape): Avoid int overflow.
1485 (Fload, openp, read_buffer_size, read1)
1486 (substitute_object_recurse, read_vector, read_list, map_obarray):
1487 Use ptrdiff_t, not int, for sizes.
1488 (read1): Use EMACS_INT, not int, for sizes.
1489 Check for size overflow.
1490
1491 * image.c (cache_image): Check for size arithmetic overflow.
1492
1493 * lread.c: Integer overflow issues.
1494 (saved_doc_string_size, saved_doc_string_length)
1495 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1496 Now ptrdiff_t, not int.
1497 (read1): Don't assume doc string length fits in int. Check for
1498 out-of-range doc string lengths.
1499 (read_list): Don't assume file position fits in int.
1500 (read_escape): Check for hex character overflow.
1501
1502 2011-06-22 Leo Liu <sdl.web@gmail.com>
1503
1504 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1505 Move to minibuffer.el.
1506
1507 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1510 The following patches are for when GLYPH_DEBUG && !XASSERT.
1511 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1512 * dispnew.c (flush_stdout):
1513 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1514 Mark as externally visible.
1515 * dispnew.c (check_window_matrix_pointers): Now static.
1516 * dispnew.c (window_to_frame_vpos):
1517 * xfns.c (unwind_create_frame):
1518 * xterm.c (x_check_font): Remove unused local.
1519 * scroll.c (CHECK_BOUNDS):
1520 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1521 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1522 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1523 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1524 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1525 Now static.
1526 (debug_method_add): Use va_list and vsprintf rather than relying
1527 on undefined behavior with wrong number of arguments.
1528 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1529 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1530 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1531 since we're not interested in debugging glyphs with old libraries.
1532 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1533 GCC 4.6.0's static checking.
1534
1535 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1536
1537 Integer overflow and signedness fixes (Bug#8873).
1538 A few related buffer overrun fixes, too.
1539
1540 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1541
1542 * dispextern.h (struct face.stipple):
1543 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1544 (x_bitmap_mask, x_allocate_bitmap_record)
1545 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1546 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1547 (x_create_bitmap_from_xpm_data):
1548 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1549 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1550 (.bitmaps_last):
1551 * xfaces.c (load_pixmap):
1552 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1553 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1554 (.bitmaps_last, struct x_output.icon_bitmap):
1555 Use ptrdiff_t, not int, for bitmap indexes.
1556 (x_allocate_bitmap_record): Check for size overflow.
1557 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1558
1559 Use ptrdiff_t, not int, for overlay counts.
1560 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1561 * editfns.c (overlays_around, get_pos_property):
1562 * textprop.c (get_char_property_and_overlay):
1563 * xdisp.c (next_overlay_change, note_mouse_highlight):
1564 * xfaces.c (face_at_buffer_position):
1565 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1566 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1567 (Fnext_overlay_change, Fprevious_overlay_change)
1568 (mouse_face_overlay_overlaps, Foverlays_in):
1569 Use ptrdiff_t, not int, for sizes.
1570 (overlays_at, overlays_in): Check for size-calculation overflow.
1571
1572 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1573
1574 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1575 (x_session_initialize): Do not assume string length fits in int.
1576
1577 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1578 This is unlikely, but can occur if DPI is outlandish.
1579
1580 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1581 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1582
1583 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1584 * xrdb.c (magic_file_p, search_magic_path):
1585 Omit last arg SUFFIX; it was always 0. All callers changed.
1586 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1587
1588 * xfont.c (xfont_match): Avoid need for strlen.
1589
1590 * xfns.c: Don't assume strlen fits in int.
1591 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1592
1593 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1594 not unsigned long, as we prefer signed integers. All callers changed.
1595 Detect integer overflow in repeat count.
1596 (message_dolog): Don't assume print length fits in 39 bytes.
1597 (display_mode_element): Don't assume strlen fits in int.
1598
1599 * termcap.c: Don't assume sizes fit in int and never overflow.
1600 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1601 (gobble_line): Check for size-calculation overflow.
1602
1603 * minibuf.c (Fread_buffer):
1604 * lread.c (intern, intern_c_string):
1605 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1606 Don't assume string length fits in int.
1607
1608 * keyboard.c (parse_tool_bar_item):
1609 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1610
1611 * font.c: Don't assume string length fits in int.
1612 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1613 Use ptrdiff_t, not int.
1614 (font_intern_prop): Don't assume string length fits in int.
1615 Don't assume integer property fits in fixnum.
1616 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1617
1618 * filelock.c: Fix some buffer overrun and integer overflow issues.
1619 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1620 Reformulate so as not to need the command string.
1621 Invoke gzip -cd rather than gunzip, as it's more portable.
1622 (lock_info_type, lock_file_1, lock_file):
1623 Don't assume pid_t and time_t fit in unsigned long.
1624 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1625 (current_lock_owner): Prefer signed type for sizes.
1626 Use memcpy, not strncpy, where memcpy is what is really wanted.
1627 Don't assume (via atoi) that time_t and pid_t fit in int.
1628 Check for time_t and/or pid_t out of range, e.g., via a network share.
1629 Don't alloca where an auto var works fine.
1630
1631 * fileio.c: Fix some integer overflow issues.
1632 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1633 Don't assume string length fits in int.
1634 (directory_file_name): Don't assume string length fits in long.
1635 (make_temp_name): Don't assume pid fits in int, or that its print
1636 length is less than 20.
1637
1638 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1639
1640 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1641
1642 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1643
1644 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1645 We prefer signed integers, even for size calculations.
1646
1647 * emacs.c: Don't assume string length fits in 'int'.
1648 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1649 (main): Don't invoke strlen when not needed.
1650
1651 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1652 (XD_DEBUG_MESSAGE): Don't waste a byte.
1653
1654 * callproc.c (getenv_internal_1, getenv_internal)
1655 (Fgetenv_internal):
1656 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1657
1658 * lread.c (invalid_syntax): Omit length argument.
1659 All uses changed. This doesn't fix a bug, but it simplifies the
1660 code away from its former Hollerith-constant appearance, and it's
1661 one less 'int' to worry about when looking at integer-overflow issues.
1662 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1663
1664 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1665 This didn't break anything, but it didn't help either.
1666 It's confusing to put a bogus integer in a place where the actual
1667 value does not matter.
1668 (LIST_END_P): Remove unused macro and its bogus comment.
1669 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1670
1671 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1672 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1673 implementation.
1674 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1675 We prefer signed types, and the value cannot exceed the EMACS_INT
1676 range anyway (because otherwise the length would not be representable).
1677 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1678 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1679 This avoids a GCC warning when WIDE_EMACS_INT.
1680
1681 * indent.c (sane_tab_width): New function.
1682 (current_column, scan_for_column, Findent_to, position_indentation)
1683 (compute_motion): Use it. This is just for clarity.
1684 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1685
1686 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1687
1688 * lisp.h (lint_assume): New macro.
1689 * composite.c (composition_gstring_put_cache):
1690 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1691
1692 * editfns.c, insdel.c:
1693 Omit unnecessary forward decls, to simplify future changes.
1694
1695 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1696
1697 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1698
1699 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1700 Use much-faster test for byte-length change.
1701 Don't assume string byte-length fits in 'int'.
1702 Check that character arg fits in 'int'.
1703 (mapcar1): Declare byte as byte, for clarity.
1704
1705 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1706
1707 * fns.c (concat): Catch string overflow earlier.
1708 Do not rely on integer wraparound.
1709
1710 * dispextern.h (struct it.overlay_strings_charpos)
1711 (struct it.selective): Now EMACS_INT, not int.
1712 * xdisp.c (forward_to_next_line_start)
1713 (back_to_previous_visible_line_start)
1714 (reseat_at_next_visible_line_start, next_element_from_buffer):
1715 Don't arbitrarily truncate the value of 'selective' to int.
1716
1717 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1718
1719 * composite.c: Don't truncate sizes to 'int'.
1720 (composition_gstring_p, composition_reseat_it)
1721 (composition_adjust_point): Use EMACS_INT, not int.
1722 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1723 not EMACS_UINT, for indexes.
1724
1725 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1726
1727 * buffer.c: Include <verify.h>.
1728 (struct sortvec.priority, struct sortstr.priority):
1729 Now EMACS_INT, not int.
1730 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1731 (struct sortstr.size, record_overlay_string)
1732 (struct sortstrlist.size, struct sortlist.used):
1733 Don't truncate size to int.
1734 (record_overlay_string): Check for size-calculation overflow.
1735 (init_buffer_once): Check at compile-time, not run-time.
1736
1737 2011-06-22 Jim Meyering <meyering@redhat.com>
1738
1739 Don't leak an XBM-image-sized buffer
1740 * image.c (xbm_load): Free the image buffer after using it.
1741
1742 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1743
1744 Port to Sun C.
1745 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1746 that Sun C diagnosed.
1747 * fns.c (secure_hash): Fix pointer signedness issue.
1748 * intervals.c (static_offset_intervals): New function.
1749 (offset_intervals): Use it.
1750
1751 2011-06-21 Leo Liu <sdl.web@gmail.com>
1752
1753 * deps.mk (fns.o):
1754 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1755 sha512.h.
1756
1757 * fns.c (secure_hash): Rename from crypto_hash_function and change
1758 the first arg to accept symbols.
1759 (Fsecure_hash): New primitive.
1760 (syms_of_fns): New symbols.
1761
1762 2011-06-20 Deniz Dogan <deniz@dogan.se>
1763
1764 * process.c (Fset_process_buffer): Clarify return value in
1765 docstring.
1766
1767 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1768
1769 * dispnew.c (add_window_display_history): Use BVAR.
1770
1771 * xdisp.c (debug_method_add): Use BVAR.
1772 (check_window_end, dump_glyph_matrix, dump_glyph)
1773 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1774
1775 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1776 Likewise.
1777
1778 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1779 check till after the cache is created in init_frame_faces.
1780
1781 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1782
1783 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1784
1785 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1788 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1789 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1790
1791 Improve buffer-overflow checking (Bug#8873).
1792 * fileio.c (Finsert_file_contents):
1793 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1794 Remove the old (too-loose) buffer overflow checks.
1795 They weren't needed, since make_gap checks for buffer overflow.
1796 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1797 The old code merely checked for Emacs fixnum overflow, and relied
1798 on undefined (wraparound) behavior. The new code avoids undefined
1799 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1800
1801 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1802 Tune. Don't use wider integers than needed. Don't use alloca.
1803 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1804
1805 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1806
1807 * insdel.c, lisp.h (buffer_overflow): New function.
1808 (insert_from_buffer_1, replace_range, replace_range_2):
1809 * insdel.c (make_gap_larger):
1810 * editfns.c (Finsert_char):
1811 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1812
1813 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1814
1815 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 Integer overflow and signedness fixes (Bug#8873).
1818
1819 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1820 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1821
1822 * fileio.c: Don't assume EMACS_INT fits in off_t.
1823 (emacs_lseek): New static function.
1824 (Finsert_file_contents, Fwrite_region): Use it.
1825 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1826
1827 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1828
1829 * fns.c: Don't overflow int when computing a list length.
1830 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1831 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1832 truncation on 64-bit hosts. Check for QUIT every
1833 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1834 faster and is responsive enough.
1835 (Flength): Report an error instead of overflowing an integer.
1836 (Fsafe_length): Return a float if the value is not representable
1837 as a fixnum. This shouldn't happen except in contrived situations.
1838 (Fnthcdr, Fsort): Don't assume list length fits in int.
1839 (Fcopy_sequence): Don't assume vector length fits in int.
1840
1841 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1842 (header_size, word_size): New constants.
1843 (allocate_vectorlike): Don't check size overflow here.
1844 (allocate_vector): Check it here instead, since this is the only
1845 caller of allocate_vectorlike that could cause overflow.
1846 Check that the new vector's length is representable as a fixnum.
1847
1848 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1849 The previous code was bogus. For example, next_almost_prime (32)
1850 returned 39, which is undesirable as it is a multiple of 3; and
1851 next_almost_prime (24) returned 25, which is a multiple of 5 so
1852 why was the code bothering to check for multiples of 7?
1853
1854 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1855
1856 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1857
1858 Variadic C functions now count arguments with ptrdiff_t.
1859 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1860 Back then I didn't know that the Emacs coding style prefers signed int.
1861 Also, in the meantime I found a few more instances where arguments
1862 were being counted with int, which may truncate counts on 64-bit
1863 machines, or EMACS_INT, which may be unnecessarily wide.
1864 * lisp.h (struct Lisp_Subr.function.aMANY)
1865 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1866 Arg counts are now ptrdiff_t, not size_t.
1867 All variadic functions and their callers changed accordingly.
1868 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1869 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1870 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1871 * callint.c (Fcall_interactively): Check arg count for overflow,
1872 to avoid potential buffer overrun. Use signed char, not 'int',
1873 for 'varies' array, so that we needn't bother to check its size
1874 calculation for overflow.
1875 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1876 * eval.c (apply_lambda):
1877 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1878 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1879 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1880
1881 * callint.c (Fcall_interactively): Don't use index var as event count.
1882
1883 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1884 * mem-limits.h (SIZE): Remove; no longer used.
1885
1886 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1887
1888 Remove unnecessary casts.
1889 * xterm.c (x_term_init):
1890 * xfns.c (x_set_border_pixel):
1891 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1892 These aren't needed now that we assume ANSI C.
1893
1894 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1895 It's more likely to cause problems (due to unsigned overflow)
1896 than to cure them.
1897
1898 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1899
1900 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1901
1902 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1903
1904 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1905
1906 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1907
1908 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1909
1910 GLYPH_CODE_FACE returns EMACS_INT, not int.
1911 * dispextern.h (merge_faces):
1912 * xfaces.c (merge_faces):
1913 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1914 Don't assume EMACS_INT fits in int.
1915
1916 * character.h (CHAR_VALID_P): Remove unused parameter.
1917 * fontset.c, lisp.h, xdisp.c: All uses changed.
1918
1919 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1920
1921 * fns.c (concat): Minor tuning based on overflow analysis.
1922 This doesn't fix any bugs. Use int to hold character, instead
1923 of constantly refetching from Emacs object. Use XFASTINT, not
1924 XINT, for value known to be a character. Don't bother comparing
1925 a single byte to 0400, as it's always less.
1926
1927 * floatfns.c (Fexpt):
1928 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1929
1930 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1931 for characters.
1932
1933 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1934
1935 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1936 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1937 incorrectly succeed when S was a string, because 4294967386 was
1938 truncated before it was used.
1939
1940 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1941 Otherwise, an out-of-range integer could cause undefined behavior
1942 on a 64-bit host.
1943
1944 * composite.c: Use int, not EMACS_INT, for characters.
1945 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1946 EMACS_INT, for values that are known to be in character range.
1947 This doesn't fix any bugs but is the usual style inside Emacs and
1948 may generate better code on 32-bit machines.
1949
1950 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1951 This is for reasons similar to the recent CHAR_STRING fix.
1952 * charset.c (Fencode_char): Check that character arg is actually
1953 a character. Pass an int to ENCODE_CHAR.
1954 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1955 wider than 'int', as a compile-time check to prevent future regressions
1956 in this area.
1957
1958 * character.c (char_string): Remove unnecessary casts.
1959
1960 Make sure a 64-bit char is never passed to CHAR_STRING.
1961 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1962 by silently ignoring the top 32 bits, allowing some values
1963 that were far too large to be valid characters.
1964 * character.h: Include <verify.h>.
1965 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1966 arguments are no wider than unsigned, as a compile-time check
1967 to prevent future regressions in this area.
1968 * data.c (Faset):
1969 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1970 (Fsubst_char_in_region):
1971 * fns.c (concat):
1972 * xdisp.c (decode_mode_spec_coding):
1973 Adjust to CHAR_STRING's new requirement.
1974 * editfns.c (Finsert_char, Fsubst_char_in_region):
1975 * fns.c (concat): Check that character args are actually
1976 characters. Without this test, these functions did the wrong
1977 thing with wildly out-of-range values on 64-bit hosts.
1978
1979 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1980 These casts should not be needed on 32-bit hosts, either.
1981 * keyboard.c (read_char):
1982 * lread.c (Fload): Remove casts to unsigned.
1983
1984 * lisp.h (UNSIGNED_CMP): New macro.
1985 This fixes comparison bugs on 64-bit hosts.
1986 (ASCII_CHAR_P): Use it.
1987 * casefiddle.c (casify_object):
1988 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1989 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1990 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1991 * dispextern.h (FACE_FROM_ID):
1992 * keyboard.c (read_char): Use UNSIGNED_CMP.
1993
1994 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1995 not to EMACS_INT, to avoid GCC warning.
1996
1997 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1998
1999 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2000 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2001 isn't needed on 32-bit machines.
2002
2003 * buffer.c (Fgenerate_new_buffer_name):
2004 Use EMACS_INT for count, not int.
2005 (advance_to_char_boundary): Return EMACS_INT, not int.
2006
2007 * data.c (Qcompiled_function): Now static.
2008
2009 * window.c (window_body_lines): Now static.
2010
2011 * image.c (gif_load): Rename local to avoid shadowing.
2012
2013 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2014 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2015 * alloc.c (make_save_value): Integer argument is now of type
2016 ptrdiff_t, not int.
2017 (mark_object): Use ptrdiff_t, not int.
2018 * lisp.h (pD): New macro.
2019 * print.c (print_object): Use it.
2020
2021 * alloc.c: Use EMACS_INT, not int, to count objects.
2022 (total_conses, total_markers, total_symbols, total_vector_size)
2023 (total_free_conses, total_free_markers, total_free_symbols)
2024 (total_free_floats, total_floats, total_free_intervals)
2025 (total_intervals, total_strings, total_free_strings):
2026 Now EMACS_INT, not int. All uses changed.
2027 (Fgarbage_collect): Compute overall total using a double, so that
2028 integer overflow is less likely to be a problem. Check for overflow
2029 when converting back to an integer.
2030 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2031 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2032 These were 'int' variables that could overflow on 64-bit hosts;
2033 they were never used, so remove them instead of repairing them.
2034 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2035 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2036 Previously, this ceilinged at INT_MAX, but that doesn't work on
2037 64-bit machines.
2038 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2039
2040 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2041 (allocate_vectorlike): Check for ptrdiff_t overflow.
2042 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2043 when a (possibly-narrower) signed value would do just as well.
2044 We prefer using signed arithmetic, to avoid comparison confusion.
2045
2046 * alloc.c: Catch some string size overflows that we were missing.
2047 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2048 for convenience in STRING_BYTES_MAX.
2049 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2050 The definition here is exact; the one in lisp.h was approximate.
2051 (allocate_string_data): Check for string overflow. This catches
2052 some instances we weren't catching before. Also, it catches
2053 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2054 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2055 and ptrdiff_t and EMACS_INT are both 64 bits.
2056
2057 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2058 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2059 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2060
2061 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2062
2063 * alloc.c (Fmake_string): Check for out-of-range init.
2064
2065 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2066
2067 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2068
2069 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2070
2071 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2072 xg_get_default_scrollbar_width.
2073
2074 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2075 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2076 (style_changed_cb): Call update_theme_scrollbar_width and call
2077 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2078 all frames (Bug#8505).
2079 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2080 Call gtk_window_set_resizable if HAVE_GTK3.
2081 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2082 and height if HAVE_GTK3 (Bug#8505).
2083 (scroll_bar_width_for_theme): New variable.
2084 (update_theme_scrollbar_width): New function.
2085 (xg_get_default_scrollbar_width): Move code to
2086 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2087 (xg_initialize): Call update_theme_scrollbar_width.
2088
2089 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2090
2091 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2092
2093 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2094
2095 * frame.c (make_frame): Call other_buffer_safely instead of
2096 other_buffer.
2097
2098 * window.c (temp_output_buffer_show): Call display_buffer with
2099 second argument Vtemp_buffer_show_specifiers and reset latter
2100 immediately after the call.
2101 (Vtemp_buffer_show_specifiers): New variable.
2102 (auto_window_vscroll_p, next_screen_context_lines)
2103 (Vscroll_preserve_screen_position): Remove leading asterisks from
2104 doc-strings.
2105
2106 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2107
2108 Fix minor problems found by GCC 4.6.0 static checking.
2109 * buffer.c (Qclone_number): Remove for now, as it's unused.
2110 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2111 (record_buffer): Remove unused local.
2112 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2113 (set_frame_buffer_list): Remove; unused.
2114 * frame.h (other_visible_frames): Remove decl.
2115 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2116 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2117 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2118 if HAVE_GPM.
2119 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2120 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2121 Define only if HAVE_GPM.
2122 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2123 (update_hints_inhibit): Remove; never set. All uses removed.
2124 * widgetprv.h (emacsFrameClassRec): Remove decl.
2125 * window.c (delete_deletable_window): Now returns void, since it
2126 wasn't returning anything.
2127 (compare_window_configurations): Remove unused locals.
2128 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2129 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2130 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2131 the same widths as pointers. This follows up on the 2011-05-06 patch.
2132 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2133 * xterm.h: Likewise.
2134 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2135
2136 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2137
2138 * makefile.w32-in: Update dependencies.
2139 (LISP_H): Add lib/intprops.h.
2140
2141 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2142
2143 * image.c (gif_load): Add animation frame delay to the metadata.
2144 (syms_of_image): Use DEFSYM. New symbol `delay'.
2145
2146 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2147
2148 * window.c (delete_deletable_window): Re-add.
2149 (Fset_window_configuration): Rewrite to handle dead buffers and
2150 consequently deletable windows.
2151 (window_tree, Fwindow_tree): Remove. Supply functionality in
2152 window.el.
2153 (compare_window_configurations): Simplify code.
2154
2155 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2156
2157 * image.c (imagemagick_load_image): Fix type mismatch.
2158 (Fimagemagick_types): Likewise.
2159
2160 * window.h (replace_buffer_in_windows): Declare.
2161
2162 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2163
2164 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2165 Qclone_number. Remove external declaration of Qdelete_window.
2166 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2167 code.
2168 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2169 Qbuffer_list_update_hook if allowed.
2170 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2171 buffer list implementation.
2172 (other_buffer_safely): New function.
2173 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2174 calls to replace_buffer_in_windows and
2175 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2176 if allowed.
2177 (record_buffer): Inhibit quitting and rewrite using quittable
2178 functions. Run Qbuffer_list_update_hook if allowed.
2179 (Frecord_buffer, Funrecord_buffer): New functions.
2180 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2181 switch-to-buffer to window.el.
2182 (bury-buffer): Move to window.el.
2183 (Vbuffer_list_update_hook): New variable.
2184
2185 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2186 section.
2187
2188 * window.h (resize_frame_windows): Move up in code.
2189 (Fwindow_frame): Remove EXFUN.
2190 (replace_buffer_in_all_windows): Remove prototype.
2191 (replace_buffer_in_windows_safely): Add prototype.
2192
2193 * window.c: Declare Qdelete_window static again. Move down
2194 declaration of select_count.
2195 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2196 (Fother_window): Move to window.el.
2197 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2198 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2199 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2200 window.el.
2201 (replace_buffer_in_windows): Implement by calling
2202 Qreplace_buffer_in_windows.
2203 (replace_buffer_in_all_windows): Remove with some functionality
2204 moved into replace_buffer_in_windows_safely.
2205 (replace_buffer_in_windows_safely): New function.
2206 (select_window_norecord, select_frame_norecord): Move in front
2207 of run_window_configuration_change_hook. Remove now obsolete
2208 declarations.
2209 (Fset_window_buffer): Rewrite doc-string. Call
2210 Qrecord_window_buffer.
2211 (keys_of_window): Move binding for other-window to window.el.
2212
2213 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2214
2215 * dispextern.h (struct image): Replace data member, whose int_val
2216 and ptr_val fields were not used by anything, with a single
2217 lisp_val object.
2218
2219 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2220 (gif_clear_image, gif_load, imagemagick_load_image)
2221 (gs_clear_image, gs_load): Callers changed.
2222
2223 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2224
2225 * buffer.h: Include <time.h>, for time_t.
2226 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2227
2228 Fix minor problems found by static checking.
2229
2230 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2231
2232 Make identifiers static if they are not used in other modules.
2233 * data.c (Qcompiled_function, Qframe, Qvector):
2234 * image.c (QimageMagick, Qsvg):
2235 * minibuf.c (Qmetadata):
2236 * window.c (resize_window_check, resize_root_window): Now static.
2237 * window.h (resize_window_check, resize_root_window): Remove decls.
2238
2239 * window.c (window_deletion_count, delete_deletable_window):
2240 Remove; unused.
2241 (window_body_lines): Now static.
2242 (Fdelete_other_windows_internal): Mark vars as initialized.
2243 Make sure 'resize_failed' is initialized.
2244 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2245 (resize_window_apply): Remove unused local.
2246 * window.h (delete_deletable_window): Remove decl.
2247
2248 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2249 (imagemagick_load_image): Fix pointer signedness problem by changing
2250 last arg from unsigned char * to char *. All uses changed.
2251 Also, fix a local for similar reasons.
2252 Remove unused locals. Remove locals to avoid shadowing.
2253 (fn_rsvg_handle_free): Remove; unused.
2254 (svg_load, svg_load_image): Fix pointer signedness problem.
2255 (imagemagick_load_image): Don't use garbage pointer image_wand.
2256
2257 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2258
2259 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2260
2261 * image.c (gif_load): Fix omitted cast error introduced by
2262 2011-06-06 change.
2263
2264 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2265
2266 * window.h (resize_proportionally, orig_total_lines)
2267 (orig_top_line): Remove from window structure.
2268 (set_window_height, set_window_width, change_window_heights)
2269 (Fdelete_window): Remove prototypes.
2270 (resize_frame_windows): Remove duplicate declaration.
2271
2272 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2273
2274 * window.h (resize_frame_windows, resize_window_check)
2275 (delete_deletable_window, resize_root_window)
2276 (resize_frame_windows): Declare prototypes.
2277
2278 * window.c (resize_window_apply): Make definition be "static" to
2279 match the prototype.
2280
2281 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2282
2283 * window.c: Remove declarations of Qwindow_size_fixed,
2284 window_min_size_1, window_min_size_2, window_min_size,
2285 size_window, window_fixed_size_p, enlarge_window, delete_window.
2286 Remove static from declaration of Qdelete_window, it's
2287 temporarily needed by Fbury_buffer.
2288 (replace_window): Don't assign orig_top_line and
2289 orig_total_lines.
2290 (Fdelete_window, delete_window): Remove. Window deletion is
2291 handled by window.el.
2292 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2293 Fdelete_window calls with calls to Qdelete_window.
2294 (Fdelete_other_windows): Remove. Deleting other windows is
2295 handled by window.el.
2296 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2297 handled in window.el.
2298 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2299 Window minimum sizes are handled in window.el.
2300 (shrink_windows, size_window, set_window_height)
2301 (set_window_width, change_window_heights, window_height)
2302 (window_width, CURBEG, CURSIZE, enlarge_window)
2303 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2304 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2305 handled in window.el.
2306 (make_dummy_parent): Rename to make_parent_window and give it a
2307 second argument horflag.
2308 (make_window): Don't set resize_proportionally any more.
2309 (Fsplit_window): Remove. Windows are split in window.el.
2310 (save_restore_action, save_restore_orig_size)
2311 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2312 Resize mini windows in window.el.
2313 (grow_mini_window, shrink_mini_window): Implement by calling
2314 Qresize_root_window_vertically, resize_window_check and
2315 resize_window_apply.
2316 (saved_window, Fset_window_configuration, save_window_save): Do
2317 not handle orig_top_line, orig_total_lines, and
2318 resize_proportionally.
2319 (window_min_height, window_min_width): Move to window.el.
2320 (keys_of_window): Move bindings for delete-other-windows,
2321 split-window, delete-window and enlarge-window to window.el.
2322
2323 * buffer.c: Temporarily extern Qdelete_window.
2324 (Fbury_buffer): Temporarily call Qdelete_window instead of
2325 Fdelete_window (Fbury_buffer will move to window.el soon).
2326
2327 * frame.c (set_menu_bar_lines_1): Remove code handling
2328 orig_top_line and orig_total_lines.
2329
2330 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2331 set_window_height but set heights directly.
2332 (change_frame_size_1): Use resize_frame_windows.
2333
2334 * xdisp.c (init_xdisp): Don't use set_window_height but set
2335 heights directly.
2336
2337 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2338 resize_frame_windows instead of change_window_heights and run
2339 run_window_configuration_change_hook.
2340
2341 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2342 instead of change_window_heights and run
2343 run_window_configuration_change_hook.
2344
2345 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2346
2347 * window.c (replace_window): Rename second argument REPLACEMENT to
2348 NEW. New third argument SETFLAG. Rewrite.
2349 (delete_window, make_dummy_parent): Call replace_window with
2350 third argument 1.
2351 (window_list_1): Move down in code.
2352 (run_window_configuration_change_hook): Move set_buffer part
2353 before select_frame_norecord part in order to unwind correctly.
2354 Rename count1 to count.
2355 (recombine_windows, delete_deletable_window, resize_root_window)
2356 (Fdelete_other_windows_internal)
2357 (Frun_window_configuration_change_hook, make_parent_window)
2358 (resize_window_check, resize_window_apply, Fresize_window_apply)
2359 (resize_frame_windows, Fsplit_window_internal)
2360 (Fdelete_window_internal, Fresize_mini_window_internal): New
2361 functions.
2362 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2363
2364 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2365
2366 * window.h (window): Add some new members to window structure -
2367 normal_lines, normal_cols, new_total, new_normal, clone_number,
2368 splits, nest, prev_buffers, next_buffers.
2369 (WINDOW_TOTAL_SIZE): Move here from window.c.
2370 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2371
2372 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2373 Remove.
2374 (make_dummy_parent): Set new members of windows structure.
2375 (make_window): Move down in code. Handle new members of window
2376 structure.
2377 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2378 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2379 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2380 (Fset_window_prev_buffers, Fwindow_next_buffers)
2381 (Fset_window_next_buffers, Fset_window_clone_number): New
2382 functions.
2383 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2384 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2385 Doc-string fixes.
2386 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2387 Argument WINDOW can be now internal window too.
2388 (Fwindow_use_time): Move up in code.
2389 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2390 Rewrite doc-string.
2391 (Fset_window_configuration, saved_window)
2392 (Fcurrent_window_configuration, save_window_save): Handle new
2393 members of window structure.
2394 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2395 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2396 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2397 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2398 Qget_mru_window, Qresize_root_window,
2399 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2400 Qauto_buffer_name; staticpro them.
2401
2402 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2403
2404 * window.c (Fwindow_total_size, Fwindow_left_column)
2405 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2406 (Fwindow_list_1): New functions.
2407 (window_box_text_cols): Replace with window_body_cols.
2408 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2409 window_body_cols instead of window_box_text_cols.
2410 (delete_window, Fset_window_configuration): Call
2411 delete_all_subwindows with window as argument.
2412 (delete_all_subwindows): Take a window as argument and not a
2413 structure. Rewrite.
2414 (window_loop): Remove handling of GET_LRU_WINDOW and
2415 GET_LARGEST_WINDOW.
2416 (Fget_lru_window, Fget_largest_window): Move to window.el.
2417
2418 * window.h: Extern window_body_cols instead of
2419 window_box_text_cols. delete_all_subwindows now takes a
2420 Lisp_Object as argument.
2421
2422 * indent.c (compute_motion, Fcompute_motion): Use
2423 window_body_cols instead of window_box_text_cols.
2424
2425 * frame.c (delete_frame): Call delete_all_subwindows with root
2426 window as argument.
2427
2428 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2429
2430 * fns.c (Fputhash): Document return value.
2431
2432 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2433
2434 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2435
2436 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2437
2438 Cons<->int and similar integer overflow fixes (Bug#8794).
2439
2440 Check for overflow when converting integer to cons and back.
2441 * charset.c (Fdefine_charset_internal, Fdecode_char):
2442 Use cons_to_unsigned to catch overflow.
2443 (Fencode_char): Use INTEGER_TO_CONS.
2444 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2445 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2446 * data.c (long_to_cons, cons_to_long): Remove.
2447 (cons_to_unsigned, cons_to_signed): New functions.
2448 These signal an error for invalid or out-of-range values.
2449 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2450 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2451 * font.c (Ffont_variation_glyphs):
2452 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2453 * lisp.h: Include <intprops.h>.
2454 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2455 (cons_to_signed, cons_to_unsigned): New decls.
2456 (long_to_cons, cons_to_long): Remove decls.
2457 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2458 (Fprimitive_undo): Use CONS_TO_INTEGER.
2459 * xfns.c (Fx_window_property): Likewise.
2460 * xselect.c: Include <limits.h>.
2461 (x_own_selection, selection_data_to_lisp_data):
2462 Use INTEGER_TO_CONS.
2463 (x_handle_selection_request, x_handle_selection_clear)
2464 (x_get_foreign_selection, Fx_disown_selection_internal)
2465 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2466 (lisp_data_to_selection_data): Use cons_to_unsigned.
2467 (x_fill_property_data): Use cons_to_signed.
2468 Report values out of range.
2469
2470 Check for buffer and string overflow more precisely.
2471 * buffer.h (BUF_BYTES_MAX): New macro.
2472 * lisp.h (STRING_BYTES_MAX): New macro.
2473 * alloc.c (Fmake_string):
2474 * character.c (string_escape_byte8):
2475 * coding.c (coding_alloc_by_realloc):
2476 * doprnt.c (doprnt):
2477 * editfns.c (Fformat):
2478 * eval.c (verror):
2479 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2480 since they may not be the same number.
2481 * editfns.c (Finsert_char):
2482 * fileio.c (Finsert_file_contents):
2483 Likewise for BUF_BYTES_MAX.
2484
2485 * image.c: Use ptrdiff_t, not int, for sizes.
2486 (slurp_file): Switch from int to ptrdiff_t.
2487 All uses changed.
2488 (slurp_file): Check that file size fits in both size_t (for
2489 malloc) and ptrdiff_t (for sanity and safety).
2490
2491 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2492 if b->modtime has its maximal value.
2493
2494 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2495
2496 Don't assume time_t can fit into int.
2497 * buffer.h (struct buffer.modtime): Now time_t, not int.
2498 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2499 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2500
2501 Minor fixes for signed vs unsigned integers.
2502 * character.h (MAYBE_UNIFY_CHAR):
2503 * charset.c (maybe_unify_char):
2504 * keyboard.c (read_char, reorder_modifiers):
2505 XINT -> XFASTINT, since the integer must be nonnegative.
2506 * ftfont.c (ftfont_spec_pattern):
2507 * keymap.c (access_keymap, silly_event_symbol_error):
2508 XUINT -> XFASTINT, since the integer must be nonnegative.
2509 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2510 since it makes no difference and we prefer signed.
2511 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2512 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2513 nonnegative.
2514
2515 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2516
2517 * window.h (Fwindow_frame): Declare.
2518
2519 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2520
2521 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2522 (SPARE_MEMORY): Always define.
2523 (LARGE_REQUEST): Remove.
2524 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2525
2526 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2527
2528 * lisp.h: Move EXFUNS for Fframe_root_window,
2529 Fframe_first_window and Fset_frame_selected_window to window.h.
2530
2531 * window.h: Move EXFUNS for Fframe_root_window,
2532 Fframe_first_window and Fset_frame_selected_window here from
2533 lisp.h.
2534
2535 * frame.c (Fwindow_frame, Fframe_first_window)
2536 (Fframe_root_window, Fframe_selected_window)
2537 (Fset_frame_selected_window): Move to window.c.
2538 (Factive_minibuffer_window): Move to minibuf.c.
2539 (Fother_visible_frames_p): New function.
2540
2541 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2542
2543 * window.c (decode_window, decode_any_window): Move up in code.
2544 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2545 (inhibit_frame_unsplittable): Remove unused variable.
2546 (Fwindow_buffer): Move up and rewrite doc-string.
2547 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2548 (Fwindow_prev): New functions.
2549 (Fwindow_frame): Move here from frame.c. Accept any window as
2550 argument.
2551 (Fframe_root_window, Fframe_first_window)
2552 (Fframe_selected_window): Move here from frame.c. Accept frame
2553 or arbitrary window as argument. Update doc-strings.
2554 (Fminibuffer_window): Move up in code.
2555 (Fwindow_minibuffer_p): Move up in code and simplify.
2556 (Fset_frame_selected_window): Move here from frame.c.
2557 Marginal rewrite.
2558 (Fselected_window, select_window, Fselect_window): Move up in
2559 code. Minor doc-string fixes.
2560
2561 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2562
2563 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2564 Do not assume that spare memory exists; that assumption is valid
2565 only if SYSTEM_MALLOC.
2566 (LARGE_REQUEST): New macro, so that the issue of large requests
2567 is separated from the issue of spare memory.
2568
2569 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2570
2571 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2572 format. (Bug#8806)
2573
2574 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2575
2576 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2577 before statements.
2578
2579 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2580
2581 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2582
2583 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2584
2585 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2586 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2587
2588 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2589
2590 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2591
2592 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2593
2594 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2595 (x_clipboard_manager_save): Add return value.
2596 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2597 New error handlers.
2598 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2599 Obey Vx_select_enable_clipboard_manager. Catch errors in
2600 x_clipboard_manager_save (Bug#8779).
2601 (Vx_select_enable_clipboard_manager): New variable.
2602 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2603
2604 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2605
2606 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2607
2608 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2609
2610 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2611 in the current matrix if keep_current_p is non-zero.
2612
2613 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2614
2615 * bidi.c (bidi_level_of_next_char): Fix last change.
2616
2617 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2618
2619 Support bidi reordering of text covered by display properties.
2620
2621 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2622 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2623 (bidi_cache_search, bidi_cache_iterator_state)
2624 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2625 (bidi_level_of_next_char, bidi_move_to_visually_next):
2626 Support character positions inside a run of characters covered by a
2627 display string.
2628 (bidi_paragraph_init, bidi_resolve_explicit_1)
2629 (bidi_level_of_next_char): Call bidi_fetch_char and
2630 bidi_fetch_char_advance instead of FETCH_CHAR and
2631 FETCH_CHAR_ADVANCE.
2632 (bidi_init_it): Initialize new members.
2633 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2634 definitions.
2635 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2636 instead of using explicit *_CHAR codes.
2637 (bidi_resolve_explicit, bidi_resolve_weak):
2638 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2639 bidirectional text is supported only in multibyte buffers.
2640 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2641 it to initialize the frame_window_p member of struct bidi_it.
2642 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2643 (bidi_resolve_explicit, bidi_resolve_weak)
2644 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2645 bidi_it->nchars is non-positive.
2646 (bidi_level_of_next_char): Don't try to lookup the cache for the
2647 next/previous character if nothing is cached there yet, or if we
2648 were just reseat()'ed to a new position.
2649
2650 * xdisp.c (set_cursor_from_row): Set start and stop points
2651 according to the row's direction when priming the loop that looks
2652 for the glyph on which to display cursor.
2653 (single_display_spec_intangible_p): Function deleted.
2654 (display_prop_intangible_p): Reimplement to call
2655 handle_display_spec instead of single_display_spec_intangible_p.
2656 Accept 3 additional arguments needed by handle_display_spec.
2657 This fixes incorrect cursor motion across display property with complex
2658 values: lists, `(when COND...)' forms, etc.
2659 (single_display_spec_string_p): Support property values that are
2660 lists with the argument STRING its top-level element.
2661 (display_prop_string_p): Fix the condition for processing a
2662 property that is a list to be consistent with handle_display_spec.
2663 (handle_display_spec): New function, refactored from the
2664 last portion of handle_display_prop.
2665 (compute_display_string_pos): Accept additional argument
2666 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2667 value of a `display' property is a "replacing spec".
2668 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2669 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2670 the display property, but just return a value indicating whether
2671 the display property will replace the characters it covers.
2672 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2673 frame_window_p members of struct bidi_it.
2674 (compute_display_string_pos, compute_display_string_end):
2675 New functions.
2676 (push_it): Accept second argument POSITION, where pop_it should
2677 jump to continue iteration.
2678 (reseat_1): Initialize bidi_it.disp_pos.
2679
2680 * keyboard.c (adjust_point_for_property): Adjust the call to
2681 display_prop_intangible_p to its new signature.
2682
2683 * dispextern.h (struct bidi_it): New member frame_window_p.
2684 (bidi_init_it): Update prototypes.
2685 (display_prop_intangible_p): Update prototype.
2686 (compute_display_string_pos, compute_display_string_end):
2687 Declare prototypes.
2688 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2689 EMACS_INT.
2690
2691 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 Malloc failure behavior now depends on size of allocation.
2694 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2695 * lisp.h: Change signatures accordingly.
2696 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2697 All callers changed. (Bug#8762)
2698
2699 * gnutls.c: Use Emacs's memory allocators.
2700 Without this change, the gnutls library would invoke malloc etc.
2701 directly, which causes problems on non-SYNC_INPUT hosts, and which
2702 runs afoul of improving memory_full behavior. (Bug#8761)
2703 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2704 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2705 xfree instead of the default malloc, realloc, free.
2706 (Fgnutls_boot): No need to check for memory allocation failure,
2707 since xmalloc does that for us.
2708
2709 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2710 * category.c (hash_get_category_set):
2711 * ccl.c (ccl_driver):
2712 * charset.c (Fdefine_charset_internal):
2713 * charset.h (struct charset.hash_index):
2714 * composite.c (get_composition_id, gstring_lookup_cache)
2715 (composition_gstring_put_cache):
2716 * composite.h (struct composition.hash_index):
2717 * dispextern.h (struct image.hash):
2718 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2719 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2720 (hashfn_equal, hashfn_user_defined, make_hash_table)
2721 (maybe_resize_hash_table, hash_lookup, hash_put)
2722 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2723 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2724 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2725 * image.c (make_image, search_image_cache, lookup_image)
2726 (xpm_put_color_table_h):
2727 * lisp.h (struct Lisp_Hash_Table):
2728 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2729 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2730 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2731 * alloc.c (allocate_vectorlike):
2732 Check for overflow in vector size calculations.
2733 * ccl.c (ccl_driver):
2734 Check for overflow when converting EMACS_INT to int.
2735 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2736 need to be updated by these changes.
2737 * fns.c (make_hash_table, maybe_resize_hash_table):
2738 Check for integer overflow with large hash tables.
2739 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2740 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2741 (SXHASH_REDUCE): New macro.
2742 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2743 Use it instead of discarding useful hash info with large hash values.
2744 (sxhash_float): New function.
2745 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2746 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2747 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2748 Rewrite to use FIXNUM_BITS, as this simplifies things.
2749 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2750 Adjust signatures to match updated version of code.
2751 (consing_since_gc): Now EMACS_INT, since a single hash table can
2752 use more than INT_MAX bytes.
2753
2754 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2755
2756 Make it possible to build with GCC-4.6+ -O2 -flto.
2757
2758 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2759
2760 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2761
2762 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2763 Call minibuffer-inactive-mode.
2764
2765 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2766
2767 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2768 Update dependencies.
2769
2770 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2771
2772 * data.c (init_data): Remove code for UTS, this system is not
2773 supported anymore.
2774
2775 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2776
2777 Don't force ./temacs to start in terminal mode.
2778
2779 * frame.c (make_initial_frame): Initialize faces in all cases, not
2780 only when CANNOT_DUMP is defined.
2781 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2782
2783 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2784
2785 * dispnew.c (add_window_display_history): Use const for the string
2786 pointer. Remove declaration, not needed.
2787
2788 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2789
2790 Use 'inline', not 'INLINE'.
2791 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2792 * alloc.c, fontset.c (INLINE): Remove.
2793 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2794 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2795 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2796 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2797 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2798
2799 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2800
2801 Make it possible to run ./temacs.
2802
2803 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2804 syms_of_callproc does the same thing. Remove test for
2805 "initialized", do it in the caller.
2806 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2807
2808 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2809
2810 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2811 (read_minibuf): Use get_minibuffer.
2812 (syms_of_minibuf): Use DEFSYM.
2813 (Qmetadata): New var.
2814 * data.c (Qbuffer): Don't make it static.
2815 (syms_of_data): Use DEFSYM.
2816
2817 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2818
2819 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2820 (CCL_CODE_MIN): New macro.
2821
2822 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2823
2824 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2825
2826 * eval.c (Qdebug): Now static.
2827 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2828 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2829 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2830
2831 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2832
2833 * image.c: Various fixes to ImageMagick code comments.
2834 (Fimagemagick_types): Doc fix.
2835
2836 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2837
2838 Minor fixes prompted by GCC 4.6.0 warnings.
2839
2840 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2841
2842 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2843 (x_clipboard_manager_save_all): Move extern decl to ...
2844 * xterm.h: ... here, so that it can be checked for consistency.
2845
2846 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2847
2848 * xselect.c (x_clipboard_manager_save_frame)
2849 (x_clipboard_manager_save_all): New functions.
2850 (Fx_clipboard_manager_save): Lisp function deleted.
2851
2852 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2853 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2854
2855 * xterm.h: Update prototype.
2856
2857 2011-05-28 William Xu <william.xwl@gmail.com>
2858
2859 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2860 exiting (Bug#8239).
2861
2862 2011-05-28 Jim Meyering <meyering@redhat.com>
2863
2864 Avoid a sign-extension bug in crypto_hash_function.
2865 * fns.c (to_uchar): Define.
2866 (crypto_hash_function): Use it to convert some newly-signed
2867 variables to unsigned, to avoid sign-extension bugs. For example,
2868 without this change, (md5 "truc") would evaluate to
2869 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2870 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2871 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2872
2873 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2874
2875 Integer overflow fixes.
2876
2877 * dbusbind.c: Serial number integer overflow fixes.
2878 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2879 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2880 to hold a serial number that is too large for a fixnum.
2881 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2882 Check for serial numbers out of range. Decode any serial number
2883 that was so large that it became a float. (Bug#8722)
2884
2885 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2886 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2887 Use XFASTINT rather than XUINT when numbers are nonnegative.
2888 (xd_append_arg, Fdbus_method_return_internal):
2889 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2890 arguments, check that Lisp number is nonnegative, rather than
2891 silently wrapping negative numbers around. (Bug#8722)
2892 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2893 (Bug#8722)
2894
2895 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2896
2897 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2898
2899 ccl: add integer overflow checks
2900 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2901 (IN_INT_RANGE): New macros.
2902 (ccl_driver): Use them to check for integer overflow when
2903 decoding a CCL program. Many of the new checks are whether XINT (x)
2904 fits in int; it doesn't always, on 64-bit hosts. The new version
2905 doesn't catch all possible integer overflows, but it's an
2906 improvement. (Bug#8719)
2907
2908 * alloc.c (make_event_array): Use XINT, not XUINT.
2909 There's no need for unsigned here.
2910
2911 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2912 This follows up to the 2011-05-06 change that substituted uintptr_t
2913 for EMACS_INT. This case wasn't caught back then.
2914
2915 Rework Fformat to avoid integer overflow issues.
2916 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2917 now (part of C89). Include <verify.h>.
2918 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2919 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2920 (Fformat): Avoid the prepass trying to compute sizes; it was only
2921 approximate and thus did not catch overflow reliably. Instead, walk
2922 through the format just once, formatting and computing sizes as we go,
2923 checking for integer overflow at every step, and allocating a larger
2924 buffer as needed. Keep track separately whether the format is
2925 multibyte. Keep only the most-recently calculated precision, rather
2926 than them all. Record whether each argument has been converted to
2927 string. Use EMACS_INT, not int, for byte and char and arg counts.
2928 Support field widths and precisions larger than INT_MAX. Avoid
2929 sprintf's undefined behavior with conversion specifications such as %#d
2930 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2931 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2932 formatting out-of-range floating point numbers with int
2933 formats. (Bug#8668)
2934
2935 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2936
2937 * data.c: Avoid integer truncation in expressions involving floats.
2938 * data.c: Include <intprops.h>.
2939 (arith_driver): When there's an integer overflow in an expression
2940 involving floating point, convert the integers to floating point
2941 so that the resulting value does not suffer from catastrophic
2942 integer truncation. For example, on a 64-bit host (* 4
2943 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2944 Do not rely on undefined behavior after integer overflow.
2945
2946 merge count_size_as_multibyte, parse_str_to_multibyte
2947 * character.c, character.h (count_size_as_multibyte):
2948 Rename from parse_str_to_multibyte; all uses changed.
2949 Check for integer overflow.
2950 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2951 since it's now a duplicate of the other. This is more of
2952 a character than a buffer op, so better that it's in character.c.
2953 * fns.c, print.c: Adjust to above changes.
2954
2955 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2956
2957 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2958
2959 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2960
2961 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2962 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2963 (x_clipboard_manager_save): Now static.
2964 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2965
2966 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2967 (crypto_hash_function): Now static.
2968 Fix pointer signedness problems. Avoid unnecessary initializations.
2969
2970 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2971
2972 * termhooks.h (Vselection_alist): Make it terminal-local.
2973
2974 * terminal.c (create_terminal): Initialize it.
2975
2976 * xselect.c: Support for clipboard managers.
2977 (Vselection_alist): Move to termhooks.h as terminal-local var.
2978 (LOCAL_SELECTION): New macro.
2979 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2980 (symbol_to_x_atom): Remove gratuitous arg.
2981 (x_handle_selection_request, lisp_data_to_selection_data)
2982 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2983 (x_own_selection, x_get_local_selection, x_convert_selection):
2984 New arg, specifying work frame. Use terminal-local Vselection_alist.
2985 (some_frame_on_display): Delete unused function.
2986 (Fx_own_selection_internal, Fx_get_selection_internal)
2987 (Fx_disown_selection_internal, Fx_selection_owner_p)
2988 (Fx_selection_exists_p): New optional frame arg.
2989 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2990 (x_handle_selection_clear): Don't treat other terminals with the
2991 same keyboard specially. Use the terminal-local Vselection_alist.
2992 (x_clear_frame_selections): Use Frun_hook_with_args.
2993
2994 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2995
2996 * xterm.h: Add support for those atoms.
2997
2998 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2999
3000 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3001 (converted_selections, conversion_fail_tag): New global variables.
3002 (x_selection_request_lisp_error): Free the above.
3003 (x_get_local_selection): Remove unnecessary code.
3004 (x_reply_selection_request): Args changed; handle arbitrary array
3005 of converted selections stored in converted_selections.
3006 Separate the XChangeProperty and SelectionNotify steps.
3007 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3008 (x_convert_selection): New function.
3009 (x_handle_selection_event): Simplify.
3010 (x_get_foreign_selection): Don't ignore incoming requests while
3011 waiting for an answer; this will fail when we implement
3012 SAVE_TARGETS, and seems unnecessary anyway.
3013 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3014 (Vx_sent_selection_functions): Doc fix.
3015
3016 2011-05-26 Leo Liu <sdl.web@gmail.com>
3017
3018 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3019
3020 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3021
3022 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3023
3024 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3025 for fringe update if it has periodic bitmap.
3026 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3027 and fringe_bitmap_periodic_p.
3028
3029 * fringe.c (get_fringe_bitmap_data): New function.
3030 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3031 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3032 row. Mark glyph row for fringe update if periodicity changed.
3033
3034 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3035 for fringe update unless it has periodic bitmap.
3036
3037 2011-05-25 Kenichi Handa <handa@m17n.org>
3038
3039 * xdisp.c (get_next_display_element): Set correct it->face_id for
3040 a static composition.
3041
3042 2011-05-24 Leo Liu <sdl.web@gmail.com>
3043
3044 * deps.mk (fns.o):
3045 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3046
3047 * fns.c (crypto_hash_function, Fsha1): New function.
3048 (Fmd5): Use crypto_hash_function.
3049 (syms_of_fns): Add Ssha1.
3050
3051 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3052
3053 * gnutls.c: Remove unused macros.
3054 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3055 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3056 Remove macros that are defined and never used.
3057 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3058
3059 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3060
3061 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3062 (Fx_get_selection_internal): Minor cleanup.
3063 (Fx_own_selection_internal): Rename arguments for consistency with
3064 select.el.
3065
3066 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3069
3070 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3071
3072 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3073
3074 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3075
3076 * dispnew.c (scrolling_window): Don't exclude the case that the
3077 last enabled row in the desired matrix touches the bottom boundary.
3078
3079 2011-05-21 Glenn Morris <rgm@gnu.org>
3080
3081 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3082 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3083 and add some more files.
3084
3085 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3086
3087 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3088 report_file_error introduced by the change from 2011-05-07.
3089
3090 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 * systime.h (Time): Define only if emacs is defined.
3093 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3094 where the include path doesn't have X11/X.h by default. See
3095 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3096
3097 2011-05-20 Kenichi Handa <handa@m17n.org>
3098
3099 * composite.c (find_automatic_composition): Fix previous change.
3100
3101 2011-05-20 Glenn Morris <rgm@gnu.org>
3102
3103 * lisp.mk: New file, split from Makefile.in.
3104 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3105 (shortlisp): Remove.
3106 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3107
3108 2011-05-19 Glenn Morris <rgm@gnu.org>
3109
3110 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3111 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3112 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3113 (lisp): Set the order to that of loadup.el.
3114 (shortlisp): Make it a copy of $lisp.
3115 (SOME_MACHINE_LISP): Remove.
3116 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3117 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3118
3119 2011-05-18 Kenichi Handa <handa@m17n.org>
3120
3121 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3122 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3123 (find_automatic_composition): Mostly rewrite for efficiency.
3124
3125 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3126
3127 * makefile.w32-in: Update dependencies.
3128
3129 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3130
3131 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3132 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3133
3134 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3135
3136 Fix some integer overflow issues, such as string length overflow.
3137
3138 * insdel.c (count_size_as_multibyte): Check for string overflow.
3139
3140 * character.c (lisp_string_width): Check for string overflow.
3141 Use EMACS_INT, not int, for string indexes and lengths; in
3142 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3143 the resulting string length overflows an EMACS_INT; instead,
3144 report a string overflow if no precision given. When checking for
3145 precision exhaustion, use a check that cannot possibly have
3146 integer overflow. (Bug#8675)
3147 * character.h (lisp_string_width): Adjust to new signature.
3148
3149 * alloc.c (string_overflow): New function.
3150 (Fmake_string): Use it. This doesn't change behavior, but saves
3151 a few bytes and will simplify future changes.
3152 * character.c (string_escape_byte8): Likewise.
3153 * lisp.h (string_overflow): New decl.
3154
3155 Fixups, following up to the user-interface timestamp change.
3156 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3157 for UI timestamps, instead of unsigned long.
3158 * msdos.c (mouse_get_pos): Likewise.
3159 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3160 * w32gui.h (Time): Define by including "systime.h" rather than by
3161 declaring it ourselves. (Bug#8664)
3162
3163 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3164 * image.c (clear_image_cache): Likewise.
3165
3166 * term.c (term_mouse_position): Don't assume time_t wraparound.
3167
3168 Be more systematic about user-interface timestamps.
3169 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3170 and sometimes 'EMACS_UINT', to represent these timestamps.
3171 This change causes it to use 'Time' uniformly, as that's what X uses.
3172 This makes the code easier to follow, and makes it easier to catch
3173 integer overflow bugs such as Bug#8664.
3174 * frame.c (Fmouse_position, Fmouse_pixel_position):
3175 Use Time, not unsigned long, for user-interface timestamps.
3176 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3177 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3178 * keyboard.h (last_event_timestamp): Likewise.
3179 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3180 * menu.h (xmenu_show): Likewise.
3181 * term.c (term_mouse_position): Likewise.
3182 * termhooks.h (struct input_event.timestamp): Likewise.
3183 (struct terminal.mouse_position_hook): Likewise.
3184 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3185 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3186 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3187 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3188 what it was before.
3189 * menu.h, termhooks.h: Include "systime.h", for Time.
3190
3191 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3192 Don't assume that the difference between two unsigned long values
3193 can fit into an integer. At this point, we know button_down_time
3194 <= event->timestamp, so the difference must be nonnegative, so
3195 there's no need to cast the result if double-click-time is
3196 nonnegative, as it should be; check that it's nonnegative, just in
3197 case. This bug is triggered when events are more than 2**31 ms
3198 apart (about 25 days). (Bug#8664)
3199
3200 * xselect.c (last_event_timestamp): Remove duplicate decl.
3201 (x_own_selection): Remove needless cast to unsigned long.
3202
3203 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3204 that always fit in int. Use a sentinel instead of a counter, to
3205 avoid a temp and to allay GCC's concerns about possible int overflow.
3206 * frame.h (struct frame): Use int for menu_bar_items_used
3207 instead of EMACS_INT, since it always fits in int.
3208
3209 * menu.c (grow_menu_items): Check for int overflow.
3210
3211 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3212
3213 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3214 Before, the code was not consistent. These values cannot exceed
3215 2**31 - 1 so there's no need to make them unsigned.
3216 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3217 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3218 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3219 as modifiers.
3220 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3221
3222 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3223 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3224 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3225 presumably because the widths might not match.
3226
3227 * window.c (size_window): Avoid needless test at loop start.
3228
3229 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3230
3231 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3232
3233 2011-05-12 Drew Adams <drew.adams@oracle.com>
3234
3235 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3236
3237 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3238
3239 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3240 `width' to `bar_area_x' and `bar_area_width', respectively.
3241 (x_scroll_run): Take account of fringe background extension.
3242
3243 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3244 Rename local vars `left' and `width' to `bar_area_x' and
3245 `bar_area_width', respectively.
3246 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3247 background extension.
3248
3249 2011-05-10 Jim Meyering <meyering@redhat.com>
3250
3251 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3252
3253 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3254
3255 * image.c (Finit_image_library): Return t for built-in image types,
3256 like pbm and xbm. (Bug#8640)
3257
3258 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3259
3260 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3261
3262 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3263
3264 * w32console.c (Fset_screen_color): Doc fix.
3265 (Fget_screen_color): New function.
3266 (syms_of_ntterm): Defsubr it.
3267
3268 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3269 unlink the temporary file if Fcall_process didn't create it in the
3270 first place.
3271 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3272 child process will be redirected to a file specified with `:file'.
3273 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3274 cue to call_process_cleanup not to close that handle.
3275
3276 2011-05-07 Ben Key <bkey76@gmail.com>
3277
3278 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3279 one of two shell specific rules, either bootstrap-temacs-CMD or
3280 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3281 to the previous implementation of the bootstrap-temacs rule.
3282 The bootstrap-temacs-CMD rule is similar to the previous
3283 implementation of the bootstrap-temacs rule except that it
3284 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3285 variable.
3286
3287 These changes, along with some changes to nt/configure.bat,
3288 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3289 earlier fix to add support for --cflags and --ldflags options
3290 that include quotes so that it works whether make uses cmd or
3291 sh as the shell.
3292
3293 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3294
3295 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3296 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3297 is a constant.
3298 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3299 a string. Handle both cases.
3300 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3301 (Fdbus_register_method): Use Qinvalid_function.
3302
3303 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3304
3305 * makefile.w32-in: Update dependencies.
3306 (LISP_H): Add inttypes.h and stdin.h.
3307 (PROCESS_H): Add unistd.h.
3308
3309 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3310
3311 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3312 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3313
3314 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3315
3316 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3317
3318 * term.c (vfatal): Remove stray call to va_end.
3319 It's not needed and the C Standard doesn't allow it here anyway.
3320
3321 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3322 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3323
3324 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3325 bytes.
3326
3327 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3328
3329 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3330
3331 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3332
3333 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3334
3335 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3336
3337 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3338 * charset.c (Fdefine_charset_internal): Don't initialize
3339 charset.code_space[15]. The value was garbage, on hosts with
3340 32-bit int (Bug#8600).
3341
3342 * lread.c (read_integer): Be more consistent with string-to-number.
3343 Use string_to_number to do the actual conversion; this avoids
3344 rounding errors and fixes some other screwups. Without this fix,
3345 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3346 (digit_to_number): Move earlier, for benefit of read_integer.
3347 Return -1 if the digit is out of range for the base, -2 if it is
3348 not a digit in any supported base. (Bug#8602)
3349
3350 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3351
3352 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3353 to match comment at start of function. This also removes a
3354 GCC warning about overflow in a 32+64-bit port.
3355
3356 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3357
3358 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3359 Reported by Stefan Monnier in
3360 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3361 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3362 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3363
3364 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3365 (EMACS_UINTPTR): Likewise, with uintptr_t.
3366
3367 * lisp.h: Prefer 64-bit EMACS_INT if available.
3368 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3369 on 32-bit hosts that have 64-bit int, so that they can access
3370 large files.
3371 However, temporarily disable this change unless the temporary
3372 symbol WIDE_EMACS_INT is defined.
3373
3374 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3375
3376 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3377 This removes an assumption that EMACS_INT and long are the same
3378 width as pointers. The assumption is true for Emacs porting targets
3379 now, but we want to make other targets possible.
3380 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3381 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3382 In the rest of the code, change types of integers that hold casted
3383 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3384 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3385 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3386 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3387 No need to cast type when ORing.
3388 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3389 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3390 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3391 assume EMACS_INT is the same width as char *.
3392 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3393 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3394 Remove no-longer-needed casts.
3395 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3396 (xg_tool_bar_help_callback, xg_make_tool_item):
3397 Use EMACS_INTPTR to hold an integer
3398 that will be cast to void *; this can avoid a GCC warning
3399 if EMACS_INT is not the same width as void *.
3400 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3401 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3402 (current_message_1, set_message_1):
3403 Use a local to convert to proper width without a cast.
3404 * xmenu.c (dialog_selection_callback): Likewise.
3405
3406 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3407 Also, don't assume VALBITS / RAND_BITS is less than 5,
3408 and don't rely on undefined behavior when shifting a 1 left into
3409 the sign bit.
3410 * lisp.h (get_random): Change signature to match.
3411
3412 * lread.c (hash_string): Use size_t, not int, for hash computation.
3413 Normally we prefer signed values; but hashing is special, because
3414 it's better to use unsigned division on hash table sizes so that
3415 the remainder is nonnegative. Also, size_t is the natural width
3416 for hashing into memory. The previous code used 'int', which doesn't
3417 retain enough info to hash well into very large tables.
3418 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3419
3420 * dbusbind.c: Don't possibly lose pointer info when converting.
3421 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3422 Use XPNTR rather than XHASH, so that the high-order bits of
3423 the pointer aren't lost when converting through void *.
3424
3425 * eval.c (Fautoload): Don't double-shift a pointer.
3426
3427 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3428
3429 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3430
3431 * gnutls.c (DEF_GNUTLS_FN):
3432 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3433
3434 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3435
3436 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3437 marker. (Bug#8610)
3438
3439 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3440
3441 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3442 New version that can reserve upto 2GB of heap space.
3443
3444 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3445
3446 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3447
3448 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3449
3450 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3451 `gnutls_certificate_set_x509_key_file'.
3452
3453 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3454
3455 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3456 Update dependencies.
3457
3458 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3459
3460 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3461 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3462 Remove unused parameter `fildes'.
3463 * process.c (read_process_output, send_process): Don't pass it.
3464
3465 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3466
3467 Fix previous change: the library cache is defined in w32.c.
3468 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3469 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3470
3471 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3472
3473 Implement dynamic loading of GnuTLS on Windows.
3474
3475 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3476 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3477 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3478 Declare.
3479
3480 * gnutls.c (Qgnutls_dll): Define.
3481 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3482 (gnutls_*): Declare function pointers.
3483 (init_gnutls_functions): New function to initialize function pointers.
3484 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3485 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3486 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3487 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3488 (emacs_gnutls_write, emacs_gnutls_read)
3489 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3490 (Fgnutls_available_p): New function.
3491 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3492 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3493 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3494
3495 * image.c: Include w32.h.
3496 (Vimage_type_cache): Delete.
3497 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3498 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3499 (w32_delayed_load): Move to w32.c.
3500
3501 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3502
3503 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3504 (w32_delayed_load): Move from image.c. When loading a library, record
3505 its filename in the :loaded-from property of the library id.
3506 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3507 Initialize and staticpro them.
3508 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3509
3510 * process.c: Include lisp.h before w32.h, not after.
3511 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3512 instead of gnutls_record_check_pending.
3513
3514 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3515
3516 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3517
3518 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3519 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3520 as passed in.
3521
3522 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3523
3524 * xterm.c (x_set_frame_alpha): Do not set property on anything
3525 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3526
3527 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3530
3531 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3532
3533 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3534 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3535 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3536 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3537 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3538 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3539 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3540 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3541 (Qgnutls_bootprop_callbacks_verify): Make static.
3542
3543 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3544
3545 * callproc.c: Indentation fixup.
3546
3547 * sysdep.c (wait_for_termination_1): Make static.
3548 (wait_for_termination, interruptible_wait_for_termination):
3549 Move after wait_for_termination_1.
3550
3551 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3552
3553 * sysdep.c (interruptible_wait_for_termination): New function
3554 which is like wait_for_termination, but allows keyboard
3555 interruptions.
3556
3557 * callproc.c (Fcall_process): Add (:file "file") as an option for
3558 the STDOUT buffer.
3559 (Fcall_process_region): Ditto.
3560
3561 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3562
3563 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3564 rather than `XVECTOR (FOO)->size'.
3565
3566 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3567 inttypes.h, as a gnulib replacement is used if it not available in
3568 system headers.
3569
3570 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3571
3572 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3573 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3574 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3575
3576 * coding.c (coding_alloc_by_realloc): Error out if destination
3577 will grow beyond MOST_POSITIVE_FIXNUM.
3578 (decode_coding_emacs_mule): Abort if there isn't enough place in
3579 charbuf for the composition carryover bytes. Reserve an extra
3580 space for up to 2 characters produced in a loop.
3581 (decode_coding_iso_2022): Abort if there isn't enough place in
3582 charbuf for the composition carryover bytes.
3583
3584 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3585
3586 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3587 aborting when %lld or %lll format is passed.
3588 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3589 %llo or %llx format is passed. (Bug#8545)
3590
3591 * window.c (window_scroll_line_based): Use a marker instead of
3592 simple variables to record original value of point. (Bug#7952)
3593
3594 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3595 produced by %s or %c overflows available buffer space. (Bug#8545)
3596
3597 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3598
3599 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3600 (SIZE_MAX): Move defn after all includes, as they might #define it.
3601
3602 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3603
3604 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3605
3606 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3607
3608 * keyboard.c (Qdelayed_warnings_hook): Define.
3609 (command_loop_1): Run `delayed-warnings-hook'
3610 if Vdelayed_warnings_list is non-nil.
3611 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3612 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3613
3614 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3615
3616 * doprnt.c (doprnt): Don't return value smaller than the buffer
3617 size if the message was truncated. (Bug#8545).
3618
3619 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3620
3621 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3622 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3623
3624 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3625
3626 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3627
3628 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3629
3630 * makefile.w32-in: Update dependencies.
3631
3632 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3633
3634 Improve `doprnt' and its usage. (Bug#8545)
3635 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3636 `format_end'. Remove support for %l as a conversion specifier.
3637 Don't use xrealloc. Improve diagnostics when the %l size modifier
3638 is used. Update the commentary.
3639
3640 * eval.c (verror): Simplify calculation of size_t.
3641
3642 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3643 messages.
3644
3645 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3646
3647 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3648 change.
3649
3650 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3651
3652 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3653 This makes this file independent of the recent pseudovector change.
3654
3655 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3658
3659 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3660 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3661 Remove unused local.
3662 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3663
3664 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3665 GCC 4.6.0 optimizes based on type-based alias analysis.
3666 For example, if b is of type struct buffer * and v of type struct
3667 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3668 != &v->size, and therefore "v->size = 1; b->size = 2; return
3669 v->size;" must therefore return 1. This assumption is incorrect
3670 for Emacs, since it type-puns struct Lisp_Vector * with many other
3671 types. To fix this problem, this patch adds a new type struct
3672 vectorlike_header that documents the constraints on layout of vectors
3673 and pseudovectors, and helps optimizing compilers not get fooled
3674 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3675 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3676 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3677 the size member.
3678 (XSETPVECTYPE): Rewrite in terms of new macro.
3679 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3680 This is a bit clearer, and further avoids the possibility of
3681 undesirable aliasing.
3682 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3683 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3684 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3685 since Lisp_Subr is a special case (no "next" field).
3686 (ASIZE): Now uses header.size rather than size.
3687 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3688 to avoid the hassle of writing XVECTOR (foo)->header.size.
3689 (struct vectorlike_header): New type.
3690 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3691 object, to help avoid aliasing.
3692 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3693 (SUBRP): Likewise, since Lisp_Subr is a special case.
3694 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3695 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3696 (struct Lisp_Hash_Table): Combine first two members into a single
3697 struct vectorlike_header member. All uses of "size" and "next" members
3698 changed to be "header.size" and "header.next".
3699 * buffer.h (struct buffer): Likewise.
3700 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3701 * frame.h (struct frame): Likewise.
3702 * process.h (struct Lisp_Process): Likewise.
3703 * termhooks.h (struct terminal): Likewise.
3704 * window.c (struct save_window_data, struct saved_window): Likewise.
3705 * window.h (struct window): Likewise.
3706 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3707 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3708 * buffer.c (init_buffer_once): Likewise.
3709 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3710 special case.
3711 * process.c (Fformat_network_address): Use local var for size,
3712 for brevity.
3713
3714 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3715
3716 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3717 * data.c (atof): Remove decl; no longer used or needed.
3718 (digit_to_number): Move to lread.c.
3719 (Fstring_to_number): Use new string_to_number function, to be
3720 consistent with how the Lisp reader treats infinities and NaNs.
3721 Do not assume that floating-point numbers represent EMACS_INT
3722 without losing information; this is not true on most 64-bit hosts.
3723 Avoid double-rounding errors, by insisting on integers when
3724 parsing non-base-10 numbers, as the documentation specifies.
3725 * lisp.h (string_to_number): New decl, replacing ...
3726 (isfloat_string): Remove.
3727 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3728 (read1): Do not accept +. and -. as integers; this
3729 appears to have been a coding error. Similarly, do not accept
3730 strings like +-1e0 as floating point numbers. Do not report
3731 overflow for integer overflows unless the base is not 10 which
3732 means we have no simple and reliable way to continue.
3733 Break out the floating-point parsing into a new
3734 function string_to_number, so that Fstring_to_number parses
3735 floating point numbers consistently with the Lisp reader.
3736 (digit_to_number): Move here from data.c. Make it static inline.
3737 (E_CHAR, EXP_INT): Remove, replacing with ...
3738 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3739 (string_to_number): New function, replacing isfloat_string.
3740 This function checks for valid syntax and produces the resulting
3741 Lisp float number too. Rework it so that string-to-number
3742 no longer mishandles examples like "1.0e+". Use strtoumax,
3743 so that overflow for non-base-10 numbers is reported only when
3744 there's no portable and simple way to convert to floating point.
3745
3746 * textprop.c (set_text_properties_1): Rewrite for clarity,
3747 and to avoid GCC warning about integer overflow.
3748
3749 * intervals.h (struct interval): Use EMACS_INT for members
3750 where EMACS_UINT might cause problems. See
3751 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3752 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3753 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3754 All uses changed.
3755 (offset_intervals): Tell GCC not to worry about length overflow
3756 when negating a negative length.
3757
3758 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3759 (overrun_check_free): Likewise.
3760
3761 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3762 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3763 word size.
3764
3765 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3766 (gnutls_make_error): Rename local to avoid shadowing.
3767 (gnutls_emacs_global_deinit): ifdef out; not used.
3768 (Fgnutls_boot): Use const for pointer to readonly storage.
3769 Comment out unused local. Fix pointer signedness problems.
3770
3771 * lread.c (openp): Don't stuff size_t into an 'int'.
3772 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3773 about possible signed overflow.
3774
3775 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3776 (GDK_KEY_g): Don't define if already defined.
3777 (xg_prepare_tooltip): Avoid pointer signedness problem.
3778 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3779
3780 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3781 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3782
3783 * xfns.c (Fx_window_property): Simplify a bit,
3784 to make a bit faster and to avoid GCC 4.6.0 warning.
3785 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3786
3787 * fns.c (internal_equal): Don't assume size_t fits in int.
3788
3789 * alloc.c (compact_small_strings): Tighten assertion a little.
3790
3791 Replace pEd with more-general pI, and fix some printf arg casts.
3792 * lisp.h (pI): New macro, generalizing old pEd macro to other
3793 conversion specifiers. For example, use "...%"pI"d..." rather
3794 than "...%"pEd"...".
3795 (pEd): Remove. All uses replaced with similar uses of pI.
3796 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3797 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3798 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3799 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3800 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3801 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3802 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3803 64-bit hosts.
3804 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3805 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3806 * print.c (safe_debug_print, print_object): Likewise.
3807 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3808 to int.
3809 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3810 avoiding the 0 flag, which is not portable.
3811 * process.c (Fmake_network_process): Use pI to avoid cast.
3812 * region-cache.c (pp_cache): Likewise.
3813 * xdisp.c (decode_mode_spec): Likewise.
3814 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3815 behavior on 64-bit hosts with printf arg.
3816 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3817 (x_stop_queuing_selection_requests): Likewise.
3818 (x_get_window_property): Don't truncate byte count to an 'int'
3819 when tracing.
3820
3821 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3822 here, since it parses constructs like leading '-' and spaces,
3823 which are not wanted; and it overflows with large numbers.
3824 Instead, simply match F[0-9]+, which is what is wanted anyway.
3825
3826 * alloc.c: Remove unportable assumptions about struct layout.
3827 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3828 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3829 (allocate_vectorlike, make_pure_vector): Use the new macros,
3830 plus offsetof, to remove unportable assumptions about struct layout.
3831 These assumptions hold on all porting targets that I know of, but
3832 they are not guaranteed, they're easy to remove, and removing them
3833 makes further changes easier.
3834
3835 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3836 This doesn't fix a bug but makes the code clearer.
3837 (string_overrun_cookie): Now const. Use initializers that
3838 don't formally overflow signed char, to avoid warnings.
3839 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3840 can cause Emacs to crash when string overrun checking is enabled.
3841 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3842 multiple of sizeof (EMACS_INT); it need not be, if
3843 alignof(EMACS_INT) < sizeof (EMACS_INT).
3844 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3845
3846 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3847
3848 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3849
3850 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3851
3852 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3853 supposed to be handshaking. (Bug#8556)
3854 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3855
3856 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3857
3858 * lisp.h (Qdebug): List symbol.
3859 * eval.c (Qdebug): Restore global linkage.
3860 * keyboard.c (debug-on-event): New variable.
3861 (handle_user_signal): Break into debugger when debug-on-event
3862 matches the current signal symbol.
3863
3864 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3865
3866 * alloc.c (check_sblock, check_string_bytes)
3867 (check_string_free_list): Convert to standard C.
3868
3869 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3870
3871 * w32.c (emacs_gnutls_push): Fix typo.
3872
3873 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3874
3875 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3876 "cast to pointer from integer of different size".
3877
3878 Improve doprnt and its use in verror. (Bug#8545)
3879 * doprnt.c (doprnt): Document the set of format control sequences
3880 supported by the function. Use SAFE_ALLOCA instead of always
3881 using `alloca'.
3882
3883 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3884 is one byte too soon. Don't use xrealloc; instead xfree and
3885 xmalloc anew.
3886
3887 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3888
3889 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3890 callbacks stage.
3891
3892 * gnutls.c: Renamed global_initialized to
3893 gnutls_global_initialized. Added internals for the
3894 :verify-hostname-error, :verify-error, and :verify-flags
3895 parameters of `gnutls-boot' and documented those parameters in the
3896 docstring. Start callback support.
3897 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3898 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3899 on error. Return error code.
3900 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3901 (emacs_gnutls_read): Likewise.
3902 (Fgnutls_boot): Return handshake error code.
3903 (emacs_gnutls_handle_error): New function.
3904 (wsaerror_to_errno): Likewise.
3905
3906 * w32.h (emacs_gnutls_pull): Add prototype.
3907 (emacs_gnutls_push): Likewise.
3908
3909 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3910 (emacs_gnutls_push): Likewise.
3911
3912 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3913
3914 * process.c (wait_reading_process_output): Check if GnuTLS
3915 buffered some data internally if no FDs are set for TLS
3916 connections.
3917
3918 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3919 (LIBS): Link to USER_LIBS.
3920 ($(BLD)/gnutls.$(0)): New target.
3921
3922 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3923
3924 * xdisp.c (handle_single_display_spec): Rename the
3925 display_replaced_before_p argument into display_replaced_p, to
3926 make it consistent with the commentary. Fix typos in the
3927 commentary.
3928
3929 * textprop.c (syms_of_textprop): Remove dead code.
3930 (copy_text_properties): Delete obsolete commentary about an
3931 interface that was deleted long ago. Fix typos in the description
3932 of arguments.
3933
3934 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3935 to changes in oldXMenu/XMenu.h from 2011-04-16.
3936 <menu_help_message, prev_menu_help_message>: Constify.
3937 (IT_menu_make_room): menu->help_text is now `const char **';
3938 adjust.
3939
3940 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3941 to changes in oldXMenu/XMenu.h from 2011-04-16.
3942 (struct XMenu): Declare `help_text' `const char **'.
3943
3944 * xfaces.c <Qunspecified>: Make extern again.
3945
3946 * syntax.c: Include sys/types.h before including regex.h, as
3947 required by Posix.
3948
3949 * doc.c (get_doc_string): Improve the format passed to `error'.
3950
3951 * doprnt.c (doprnt): Improve commentary.
3952
3953 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3954
3955 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3956 them with etags.
3957
3958 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3959 changes in globals.h immediately force recompilation.
3960 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3961 $(CURDIR)/s/ms-w32.h.
3962 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3963
3964 * character.c (Fchar_direction): Function deleted.
3965 (syms_of_character): Don't defsubr it.
3966 <char-direction-table>: Deleted.
3967
3968 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3969
3970 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3971 * doprnt.c: Include limits.h.
3972 (SIZE_MAX): New macro.
3973 (doprnt): Return a size_t value. 2nd arg is now size_t.
3974 Many local variables are now size_t instead of int or unsigned.
3975 Improve overflow protection. Support `l' modifier for integer
3976 conversions. Support %l conversion. Don't assume an EMACS_INT
3977 argument for integer conversions and for %c.
3978
3979 * lisp.h (doprnt): Restore prototype.
3980
3981 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3982 $(SRC)/character.h.
3983
3984 * Makefile.in (base_obj): Add back doprnt.o.
3985
3986 * deps.mk (doprnt.o): Add back prerequisites.
3987 (callint.o): Depend on character.h.
3988
3989 * eval.c (internal_lisp_condition_case): Include the handler
3990 representation in the error message.
3991 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3992 when breaking from the loop.
3993
3994 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3995
3996 * callint.c (Fcall_interactively): When displaying error message
3997 about invalid control letter, pass the character's codepoint, not
3998 a pointer to its multibyte form. Improve display of the character
3999 in octal and display also its hex code.
4000
4001 * character.c (char_string): Use %x to display the (unsigned)
4002 codepoint of an invalid character, to avoid displaying a bogus
4003 negative value.
4004
4005 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4006 `error', not SYMBOL_NAME itself.
4007
4008 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4009 character arguments to `error'.
4010
4011 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4012 to `error' in error message about FINAL_CHAR argument. Make sure
4013 FINAL_CHAR is a character, and use %c when it is passed as
4014 argument to `error'.
4015
4016 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4017
4018 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4019
4020 * w32.c: Include <time.h>.
4021 (sys_localtime): New function.
4022
4023 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4024
4025 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4026
4027 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4028
4029 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4030
4031 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4032 zombies (Bug#8467).
4033
4034 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4035
4036 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4037 gl_state.e_property when gl_state.object is Qt.
4038
4039 * insdel.c (make_gap_larger): Remove limitation of buffer size
4040 to <= INT_MAX.
4041
4042 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4043
4044 * xdisp.c (lookup_glyphless_char_display)
4045 (produce_glyphless_glyph): Handle cons cell entry in
4046 glyphless-char-display.
4047 (Vglyphless_char_display): Document it.
4048
4049 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4050 glyphless-char-display.
4051
4052 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4053
4054 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4055
4056 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4057
4058 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4059 definition for no-X builds.
4060
4061 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4062
4063 Static checks with GCC 4.6.0 and non-default toolkits.
4064
4065 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4066
4067 * process.c (keyboard_bit_set): Define only if SIGIO.
4068 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4069 (send_process): Repair possible setjmp clobbering.
4070
4071 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4072
4073 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4074
4075 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4076
4077 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4078 Define only if needed.
4079
4080 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4081 by pacifying GCC about it. Maybe it's time to retire it?
4082 * xfaces.c (USG, __TIMEVAL__): Likewise.
4083
4084 * dispextern.h (struct redisplay_interface): Rename param
4085 to avoid shadowing.
4086 * termhooks.h (struct terminal): Likewise.
4087 * xterm.c (xembed_send_message): Likewise.
4088
4089 * insdel.c (make_gap_smaller): Define only if
4090 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4091
4092 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4093 it.
4094
4095 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4096 so that we aren't warned about unused symbols.
4097
4098 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4099
4100 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4101
4102 * xfns.c (x_real_positions): Mark locals as initialized.
4103
4104 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4105
4106 * xterm.c: Fix problems found by static analysis with other toolkits.
4107 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4108 (x_dispatch_event): Declare static if USE_GTK, and
4109 define if USE_GTK || USE_X_TOOLKIT.
4110 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4111 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4112 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4113 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4114
4115 * xmenu.c (menu_help_callback): Pointer type fixes.
4116 Use const pointers when pointing at readonly data. Avoid pointer
4117 signedness clashes.
4118 (FALSE): Remove unused macro.
4119 (update_frame_menubar): Remove unused decl.
4120
4121 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4122
4123 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4124 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4125 (single_menu_item): Rename local to avoid shadowing.
4126
4127 * keyboard.c (make_lispy_event): Remove unused local var.
4128
4129 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4130 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4131
4132 * bitmaps: Change bitmaps from unsigned char back to the X11
4133 compatible char. Avoid the old compiler warnings about
4134 out-of-range initializers by using, for example, '\xab' rather
4135 than 0xab.
4136
4137 * xgselect.c (xgselect_initialize): Check vs interface
4138 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4139
4140 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4141
4142 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4143 to read-only memory.
4144
4145 * fns.c (vector): Remove; this old hack is no longer needed.
4146
4147 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4148 Remove unused var.
4149 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4150
4151 * xrdb.c (x_load_resources): Omit unused local.
4152
4153 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4154 (x_window): Rename locals to avoid shadowing.
4155 (USG): Use the kludged USG macro, to pacify gcc.
4156
4157 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4158 (x_term_init): Remove local to avoid shadowing.
4159
4160 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4161
4162 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4163 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4164
4165 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4166
4167 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4168
4169 Fix regex.c, syntax.c and friends for buffers > 2GB.
4170 * syntax.h (struct gl_state_s): Declare character position members
4171 EMACS_INT.
4172
4173 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4174
4175 * textprop.c (verify_interval_modification, interval_of):
4176 Declare arguments EMACS_INT.
4177
4178 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4179 EMACS_INT.
4180
4181 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4182
4183 * indent.c (Fvertical_motion): Local variable it_start is now
4184 EMACS_INT.
4185
4186 * regex.c (re_match, re_match_2, re_match_2_internal)
4187 (bcmp_translate, regcomp, regexec, print_double_string)
4188 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4189 (re_compile_pattern, re_exec): Declare arguments and local
4190 variables `size_t' and `ssize_t' and return values `regoff_t', as
4191 appropriate.
4192 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4193 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4194 <compile_stack_type>: `size' and `avail' are now `size_t'.
4195
4196 * regex.h <regoff_t>: Use ssize_t, not int.
4197 (re_search, re_search_2, re_match, re_match_2): Arguments that
4198 specify buffer/string position and length are now ssize_t and
4199 size_t. Return type is regoff_t.
4200
4201 2011-04-16 Ben Key <bkey76@gmail.com>
4202
4203 * nsfont.m: Fixed bugs in ns_get_family and
4204 ns_descriptor_to_entity that were caused by using free to
4205 deallocate memory blocks that were allocated by xmalloc (via
4206 xstrdup). This caused Emacs to crash when compiled with
4207 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4208 --enable-checking=xmallocoverrun). xfree is now used to
4209 deallocate these memory blocks.
4210
4211 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4214
4215 emacs_write: Accept and return EMACS_INT for sizes.
4216 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4217 et seq.
4218 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4219 Accept and return EMACS_INT.
4220 (emacs_gnutls_write): Return the number of bytes written on
4221 partial writes.
4222 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4223 (emacs_read, emacs_write): Remove check for negative size, as the
4224 Emacs source code has been audited now.
4225 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4226 (emacs_read, emacs_write): Use it.
4227 * process.c (send_process): Adjust to the new signatures of
4228 emacs_write and emacs_gnutls_write. Do not attempt to store
4229 a byte offset into an 'int'; it might overflow.
4230 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4231
4232 * sound.c: Don't assume sizes fit in 'int'.
4233 (struct sound_device.period_size, alsa_period_size):
4234 Return EMACS_INT, not int.
4235 (struct sound_device.write, vox_write, alsa_write):
4236 Accept EMACS_INT, not int.
4237 (wav_play, au_play): Use EMACS_INT to store sizes and to
4238 record read return values.
4239
4240 2011-04-15 Ben Key <bkey76@gmail.com>
4241
4242 * keyboard.c (Qundefined): Don't declare static since it is used
4243 in nsfns.m.
4244 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4245 static since they are used in nsfont.m.
4246
4247 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4248
4249 * process.c (Qprocessp): Don't declare static.
4250 * lisp.h (Qprocessp): Declare again.
4251
4252 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4253
4254 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4255
4256 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4257
4258 Improve C-level modularity by making more things 'static'.
4259
4260 Don't publish debugger-only interfaces to other modules.
4261 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4262 (verify_bytepos, count_markers): Move decls to the only modules
4263 that need them.
4264 * region-cache.h (pp_cache): Likewise.
4265 * window.h (check_all_windows): Likewise.
4266 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4267
4268 * sysdep.c (croak): Now static, if
4269 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4270 * syssignal.h (croak): Declare only if not static.
4271
4272 * alloc.c (refill_memory_reserve): Now static if
4273 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4274 * lisp.h (refill_memory_reserve): Declare only if not static.
4275
4276 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4277 Define only if USE_LUCID.
4278
4279 * xrdb.c (x_customization_string, x_rm_string): Now static.
4280
4281 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4282 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4283
4284 * xdisp.c (draw_row_with_mouse_face): Now static.
4285 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4286
4287 * window.h (check_all_windows): Mark externally visible.
4288
4289 * window.c (window_deletion_count): Now static.
4290
4291 * undo.c: Make symbols static if they're not exported.
4292 (last_undo_buffer, last_boundary_position, pending_boundary):
4293 Now static.
4294
4295 * textprop.c (interval_insert_behind_hooks): Now static.
4296 (interval_insert_in_front_hooks): Likewise.
4297
4298 * term.c: Make symbols static if they're not exported.
4299 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4300 (max_frame_lines, tty_set_terminal_modes):
4301 (tty_reset_terminal_modes, tty_turn_off_highlight):
4302 (get_tty_terminal): Now static.
4303 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4304 * termhooks.h (term_mouse_moveto): Do not declare if
4305 HAVE_WINDOW_SYSTEM.
4306 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4307 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4308
4309 * sysdep.c: Make symbols static if they're not exported.
4310 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4311 Now static.
4312 (sigprocmask_set, full_mask): Remove; unused.
4313 (wait_debugging): Mark as visible.
4314 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4315 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4316
4317 * syntax.c (syntax_temp): Define only if !__GNUC__.
4318
4319 * sound.c (current_sound_device, current_sound): Now static.
4320
4321 * search.c (searchbufs, searchbuf_head): Now static.
4322
4323 * scroll.c (scroll_cost): Remove; unused.
4324 * dispextern.h (scroll_cost): Remove decl.
4325
4326 * region-cache.h (pp_cache): Mark as externally visible.
4327
4328 * process.c: Make symbols static if they're not exported.
4329 (process_tick, update_tick, create_process, chan_process):
4330 (Vprocess_alist, proc_buffered_char, datagram_access):
4331 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4332 (deactivate_process): Mark defn as static, as well as decl.
4333 * lisp.h (create_process): Remove decl.
4334 * process.h (chan_process, Vprocess_alist): Remove decls.
4335
4336 * print.c: Make symbols static if they're not exported.
4337 (print_depth, new_backquote_output, being_printed, print_buffer):
4338 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4339 (print_interval, print_number_index, initial_stderr_stream):
4340 Now static.
4341 * lisp.h (Fprinc): Remove decl.
4342 (debug_output_compilation_hack): Mark as externally visible.
4343
4344 * sysdep.c (croak): Move decl from here to syssignal.h.
4345 * syssignal.h (croak): Put it here, so the API can be checked when
4346 'croak' is called from dissociate_if_controlling_tty.
4347
4348 * minibuf.c: Make symbols static if they're not exported.
4349 (minibuf_save_list, choose_minibuf_frame): Now static.
4350 * lisp.h (choose_minibuf_frame): Remove decl.
4351
4352 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4353
4354 * lread.c: Make symbols static if they're not exported.
4355 (read_objects, initial_obarray, oblookup_last_bucket_number):
4356 Now static.
4357 (make_symbol): Remove; unused.
4358 * lisp.h (initial_obarray, make_symbol): Remove decls.
4359
4360 * keyboard.c: Make symbols static if they're not exported.
4361 (single_kboard, recent_keys_index, total_keys, recent_keys):
4362 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4363 (this_single_command_key_start, echoing, last_auto_save):
4364 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4365 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4366 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4367 (Vlispy_mouse_stem, double_click_count):
4368 Now static.
4369 (force_auto_save_soon): Define only if SIGDANGER.
4370 (ignore_mouse_drag_p): Now static if
4371 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4372 (print_help): Remove; unused.
4373 (stop_character, last_timer_event): Mark as externally visible.
4374 * keyboard.h (ignore_mouse_drag_p): Declare only if
4375 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4376 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4377 * lisp.h (echoing): Remove decl.
4378 (force_auto_save_soon): Declare only if SIGDANGER.
4379 * xdisp.c (redisplay_window): Simplify code, to make it more
4380 obvious that ignore_mouse_drag_p is not accessed if !defined
4381 USE_GTK && !defined HAVE_NS.
4382
4383 * intervals.c: Make symbols static if they're not exported.
4384 (merge_properties_sticky, merge_interval_right, delete_interval):
4385 Now static.
4386 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4387
4388 * insdel.c: Make symbols static if they're not exported.
4389 However, leave prepare_to_modify_buffer alone. It's never
4390 called from outside this function, but that appears to be a bug.
4391 (combine_after_change_list, combine_after_change_buffer):
4392 (adjust_after_replace, signal_before_change): Now static.
4393 (adjust_after_replace_noundo): Remove; unused.
4394 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4395 (signal_before_change): Remove decls.
4396
4397 * indent.c (val_compute_motion, val_vmotion): Now static.
4398
4399 * image.c: Make symbols static if they're not exported.
4400 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4401 if USE_GTK.
4402 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4403 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4404
4405 * fringe.c (standard_bitmaps): Now static.
4406 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4407
4408 * frame.c: Make symbols static if they're not exported.
4409 (x_report_frame_params, make_terminal_frame): Now static.
4410 (get_frame_param): Now static, unless HAVE_NS.
4411 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4412 (x_get_resource_string): Remove; not used.
4413 * frame.h (make_terminal_frame, x_report_frame_params):
4414 (x_get_resource_string); Remove decls.
4415 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4416 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4417
4418 * font.c, fontset.c: Make symbols static if they're not exported.
4419 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4420 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4421 * font.c (font_close_object): Now static.
4422 * font.h (font_close_object): Remove.
4423 * fontset.c (FONTSET_OBJLIST): Remove.
4424 (free_realized_fontset) #if-0 the body, which does nothing.
4425 (face_suitable_for_char_p): #if-0, as it's never called.
4426 * fontset.h (face_suitable_for_char_p): Remove decl.
4427 * xfaces.c (face_at_string_position):
4428 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4429 since 0 is always ASCII.
4430
4431 * fns.c (weak_hash_tables): Now static.
4432
4433 * fileio.c: Make symbols static if they're not exported.
4434 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4435 (Vwrite_region_annotation_buffers): Now static.
4436
4437 * eval.c: Make symbols static if they're not exported.
4438 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4439 * lisp.h (backtrace_list): Remove decl.
4440
4441 * emacs.c: Make symbols static if they're not exported.
4442 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4443 (fatal_error_code, fatal_error_signal_hook, standard_args):
4444 Now static.
4445 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4446 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4447 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4448 * lisp.h (fatal_error_signal_hook): Remove decl.
4449 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4450
4451 * editfns.c: Move a (normally-unused) function to its only use.
4452 * editfns.c, lisp.h (get_operating_system_release): Remove.
4453 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4454 worth the hassle of breaking this out.
4455
4456 * xterm.c: Make symbols static if they're not exported.
4457 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4458 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4459 (x_destroy_window, x_delete_display):
4460 Now static.
4461 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4462 (x_mouse_leave): Remove; unused.
4463 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4464 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4465 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4466 Remove decls.
4467 (x_mouse_leave): Declare only if WINDOWSNT.
4468 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4469 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4470 USE_X_TOOLKIT.
4471
4472 * ftxfont.c: Make symbols static if they're not exported.
4473 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4474 HAVE_FREETYPE.
4475 * font.h (ftxfont_driver): Likewise.
4476
4477 * xfns.c: Make symbols static if they're not exported.
4478 (x_last_font_name, x_display_info_for_name):
4479 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4480 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4481 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4482 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4483 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4484 (last_show_tip_args): Now static.
4485 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4486 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4487 (x_screen_planes): Remove; unused.
4488 * dispextern.h (x_screen_planes): Remove decl.
4489
4490 * dispnew.c: Make symbols static if they're not exported.
4491 * dispextern.h (redraw_garbaged_frames, scrolling):
4492 (increment_row_positions): Remove.
4493 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4494 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4495 Now static.
4496 (redraw_garbaged_frames): Remove; unused.
4497
4498 * xfaces.c: Make symbols static if they're not exported.
4499 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4500 Remove decls.
4501 * xterm.h (defined_color): Remove decls.
4502 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4503 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4504 (menu_face_changed_default, defined_color, free_realized_face):
4505 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4506 (ascii_face_of_lisp_face): Remove; unused.
4507
4508 * xdisp.c: Make symbols static if they're not exported.
4509 * dispextern.h (scratch_glyph_row, window_box_edges):
4510 (glyph_to_pixel_coords, set_cursor_from_row):
4511 (get_next_display_element, set_iterator_to_next):
4512 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4513 (show_mouse_face): Remove decls
4514 * frame.h (message_buf_print): Likewise.
4515 * lisp.h (pop_message, set_message, check_point_in_composition):
4516 Likewise.
4517 * xterm.h (set_vertical_scroll_bar): Likewise.
4518 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4519 (message_buf_print, scratch_glyph_row, displayed_buffer):
4520 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4521 (get_next_display_element, show_mouse_face, window_box_edges):
4522 (frame_to_window_pixel_xy, check_point_in_composition):
4523 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4524 (glyph_to_pixel_coords): Remove; unused.
4525
4526 * dired.c (file_name_completion): Now static.
4527
4528 * dbusbind.c (xd_in_read_queued_messages): Now static.
4529
4530 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4531 * data.c (circular_list_error): Remove.
4532
4533 * commands.h (last_point_position, last_point_position_buffer):
4534 (last_point_position_window): Remove decls.
4535 * keyboard.c: Make these variables static.
4536
4537 * coding.h (coding, code_convert_region, encode_coding_gap):
4538 Remove decls.
4539 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4540 (iso_code_class, detect_coding, code_convert_region): Now static.
4541 (encode_coding_gap): Remove; unused.
4542
4543 * chartab.c (chartab_chars, chartab_bits): Now static.
4544
4545 * charset.h (charset_iso_8859_1): Remove decl.
4546 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4547 Now static.
4548
4549 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4550 * ccl.c (Vccl_program_table): Now static.
4551 (check_ccl_update): Remove; unused.
4552
4553 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4554 * category.h: ... from here.
4555 * category.c (check_category_table, set_category_set): Now static.
4556
4557 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4558 * lisp.h: Remove these decls.
4559
4560 * buffer.c (buffer_count): Remove unused var.
4561
4562 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4563 so that it's not optimized away.
4564 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4565 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4566 exported only to the debugger.
4567
4568 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4569 * atimer.h (run_all_atimers): Remove; not exported.
4570
4571 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4572 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4573 was inaccessible from Lisp.
4574 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4575 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4576
4577 alloc.c: Import and export fewer symbols, and remove unused items.
4578 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4579 is defined.
4580 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4581 it's not optimized away by whole-program optimization.
4582 (message_enable_multibyte, free_misc): Remove.
4583 (catchlist, handlerlist, mark_backtrace):
4584 Declare only if BYTE_MARK_STACK.
4585 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4586 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4587 (message_enable_multibyte): Remove decl.
4588 (free_misc, interval_free_list, float_block, float_block_index):
4589 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4590 (cons_free_list, last_marked_index):
4591 Now static.
4592 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4593 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4594 (mark_backtrace): Define only if BYTE_MARK_STACK.
4595 * xdisp.c (message_enable_multibyte): Now static.
4596
4597 Declare Lisp_Object Q* variables to be 'static' if not exported.
4598 This makes it easier for human readers (and static analyzers)
4599 to see whether these variables are used from other modules.
4600 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4601 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4602 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4603 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4604 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4605 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4606 * xmenu.c, xselect.c:
4607 Declare Q* vars static if they are not used in other modules.
4608 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4609 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4610 Remove decls of unexported vars.
4611 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4612
4613 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4614
4615 Make Emacs functions such as Fatom 'static' by default.
4616 This makes it easier for human readers (and static analyzers)
4617 to see whether these functions can be called from other modules.
4618 DEFUN now defines a static function. To make the function external
4619 so that it can be used in other C modules, use the new macro DEFUE.
4620 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4621 (Finit_image_library):
4622 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4623 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4624 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4625 Remove decls, since these functions are now static.
4626 (Funintern, Fget_internal_run_time): New decls, since these functions
4627 were already external.
4628
4629 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4630 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4631 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4632 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4633 * keyboard.c, keymap.c, lread.c:
4634 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4635 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4636 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4637 Mark functions with DEFUE instead of DEFUN,
4638 if they are used in other modules.
4639 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4640 decls for now-static functions.
4641 * buffer.h (Fdelete_overlay): Remove decl.
4642 * callproc.c (Fgetenv_internal): Mark as internal.
4643 * composite.c (Fremove_list_of_text_properties): Remove decl.
4644 (Fcomposition_get_gstring): New forward static decl.
4645 * composite.h (Fcomposite_get_gstring): Remove decl.
4646 * dired.c (Ffile_attributes): New forward static decl.
4647 * doc.c (Fdocumntation_property): New forward static decl.
4648 * eval.c (Ffetch_bytecode): New forward static decl.
4649 (Funintern): Remove extern decl; now in .h file where it belongs.
4650 * fileio.c (Fmake_symbolic_link): New forward static decl.
4651 * image.c (Finit_image_library): New forward static decl.
4652 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4653 * intervals.h (Fprevious_property_change):
4654 (Fremove_list_of_text_properties): Remove decls.
4655 * keyboard.c (Fthis_command_keys): Remove decl.
4656 (Fcommand_execute): New forward static decl.
4657 * keymap.c (Flookup_key): New forward static decl.
4658 (Fcopy_keymap): Now static.
4659 * keymap.h (Flookup_key): Remove decl.
4660 * process.c (Fget_process): New forward static decl.
4661 (Fprocess_datagram_address): Mark as internal.
4662 * syntax.c (Fsyntax_table_p): New forward static decl.
4663 (skip_chars): Remove duplicate decl.
4664 * textprop.c (Fprevious_property_change): New forward static decl.
4665 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4666 Now internal.
4667 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4668 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4669
4670 * editfns.c (Fformat): Remove unreachable code.
4671
4672 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4673
4674 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4675 change. (Bug#8496)
4676
4677 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4678
4679 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4680 when at ZV. (Bug#8487)
4681
4682 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4683
4684 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4685 (Bug#8437)
4686 * keyboard.c (parse_tool_bar_item): Likewise.
4687 * sound.c (sound_cleanup, alsa_close): Likewise.
4688 * termcap.c (tgetent): Likewise.
4689 * xfns.c (x_default_font_parameter): Likewise.
4690 * xsettings.c (read_and_apply_settings): Likewise.
4691
4692 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4693 (overrun_check_free): Protoize.
4694
4695 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4696
4697 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4698 since callers should never pass a negative size.
4699 Change the signature to match that of plain 'read' and 'write'; see
4700 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4701 * lisp.h: Update prototypes of emacs_write and emacs_read.
4702
4703 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4704
4705 * xdisp.c (redisplay_window): Don't try to determine the character
4706 position of the scroll margin if the window start point w->startp
4707 is outside the buffer's accessible region. (Bug#8468)
4708
4709 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4710
4711 Fix write-region and its subroutines for buffers > 2GB.
4712 * fileio.c (a_write, e_write): Modify declaration of arguments and
4713 local variables to support buffers larger than 2GB.
4714 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4715
4716 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4717 argument, local variables, and return value.
4718
4719 * lisp.h: Update prototypes of emacs_write and emacs_read.
4720
4721 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4722
4723 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4724
4725 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4726
4727 Fix more problems found by GCC 4.6.0's static checks.
4728
4729 * xdisp.c (vmessage): Use a better test for character truncation.
4730
4731 * charset.c (load_charset_map): <, not <=, for optimization,
4732 and to avoid potential problems with integer overflow.
4733 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4734 * casetab.c (set_identity, shuffle): Likewise.
4735 * editfns.c (Fformat): Likewise.
4736 * syntax.c (skip_chars): Likewise.
4737
4738 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4739 This also lets GCC 4.6.0 generate slightly better loop code.
4740
4741 * callint.c (Fcall_interactively): <, not <=, for optimization.
4742 (Fcall_interactively): Count the number of arguments produced,
4743 not the number of arguments given. This is simpler and lets GCC
4744 4.6.0 generate slightly better code.
4745
4746 * ftfont.c: Distingish more carefully between FcChar8 and char.
4747 The previous code passed unsigned char * to a functions like
4748 strlen and xstrcasecmp that expect char *, which does not
4749 conform to the C standard.
4750 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4751 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4752 char * when the C standard requires it.
4753
4754 * keyboard.c (read_char): Remove unused var.
4755
4756 * eval.c: Port to Windows vsnprintf (Bug#8435).
4757 Include <limits.h>.
4758 (SIZE_MAX): Define if the headers do not.
4759 (verror): Do not give up if vsnprintf returns a negative count.
4760 Instead, grow the buffer. This ports to Windows vsnprintf, which
4761 does not conform to C99. Problem reported by Eli Zaretskii.
4762 Also, simplify the allocation scheme, by avoiding the need for
4763 calling realloc, and removing the ALLOCATED variable.
4764
4765 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4766
4767 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4768 But keep the doprint source code for now, as we might revamp it
4769 and use it again (Bug#8435).
4770 * lisp.h (doprnt): Remove.
4771 * Makefile.in (base_obj): Remove doprnt.o.
4772 * deps.mk (doprnt.o): Remove.
4773
4774 error: Print 32- and 64-bit integers portably (Bug#8435).
4775 Without this change, on typical 64-bit hosts error ("...%d...", N)
4776 was used to print both 32- and 64-bit integers N, which relied on
4777 undefined behavior.
4778 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4779 New macro.
4780 * lisp.h (error, verror): Mark as printf-like functions.
4781 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4782 Report overflow in size calculations when allocating printf buffer.
4783 Do not truncate output string at its first null byte.
4784 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4785 Truncate the output at a character boundary, since vsnprintf does not
4786 do that.
4787 * charset.c (check_iso_charset_parameter): Convert internal
4788 character to string before calling 'error', since %c now has the
4789 printf meaning.
4790 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4791 overflow when computing char to be passed to 'error'. Do not
4792 pass Lisp_Object to 'error'; pass the integer instead.
4793 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4794 formatted with plain %d.
4795
4796 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4797
4798 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4799
4800 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4801
4802 * xterm.c (x_catch_errors): Remove duplicate declaration.
4803
4804 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4805
4806 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4807
4808 2011-04-10 Jim Meyering <meyering@redhat.com>
4809
4810 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4811 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4812 return ssize_t not "int", and use size_t as the buffer length.
4813 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4814 * gnutls.h: Update declarations.
4815 * process.c (read_process_output): Use ssize_t, to match.
4816 (send_process): Likewise.
4817
4818 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4819
4820 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4821
4822 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4823
4824 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4825 Use unsigned char, to match FcChar8 type definition.
4826
4827 * xterm.c (handle_one_xevent):
4828 * xmenu.c (create_and_show_popup_menu):
4829 * xselect.c (x_decline_selection_request)
4830 (x_reply_selection_request): Avoid type-punned deref of X events.
4831
4832 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4833
4834 Fix some uses of `int' instead of EMACS_INT.
4835 * search.c (string_match_1, fast_string_match)
4836 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4837 (scan_buffer, find_next_newline_no_quit)
4838 (find_before_next_newline, search_command, Freplace_match)
4839 (Fmatch_data): Make some `int' variables be EMACS_INT.
4840
4841 * xdisp.c (display_count_lines): 3rd argument and return value now
4842 EMACS_INT. All callers changed.
4843 (pint2hrstr): Last argument is now EMACS_INT.
4844
4845 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4846 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4847 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4848 (decode_coding_utf_16, decode_coding_emacs_mule)
4849 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4850 (decode_coding_ccl, decode_coding_charset)
4851 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4852 (decode_coding_iso_2022, decode_coding_emacs_mule)
4853 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4854 <char_offset, last_offset>: Declare EMACS_INT.
4855 (encode_coding_utf_8, encode_coding_utf_16)
4856 (encode_coding_emacs_mule, encode_invocation_designation)
4857 (encode_designation_at_bol, encode_coding_iso_2022)
4858 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4859 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4860 Declare EMACS_INT.
4861 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4862 (encode_invocation_designation): Last argument P_NCHARS is now
4863 EMACS_INT.
4864 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4865 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4866
4867 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4868 All users changed.
4869
4870 * ccl.c (Fccl_execute_on_string): Declare some variables
4871 EMACS_INT.
4872
4873 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4874
4875 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4876
4877 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4878
4879 * process.c (Fformat_network_address): Doc fix.
4880
4881 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4882
4883 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4884
4885 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4886
4887 * keyboard.c (read_char): Call Lisp function help-form-show,
4888 instead of using internal_with_output_to_temp_buffer.
4889 (Qhelp_form_show): New var.
4890 (syms_of_keyboard): Use DEFSYM macro.
4891
4892 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4893
4894 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4895
4896 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4897
4898 * process.c (Flist_processes): Remove to Lisp.
4899 (list_processes_1): Delete.
4900
4901 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4902
4903 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4904
4905 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4906
4907 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4908
4909 Fix more problems found by GCC 4.6.0's static checks.
4910
4911 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4912
4913 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4914
4915 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4916
4917 * xdisp.c (vmessage): Mark as a printf-like function.
4918
4919 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4920
4921 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4922
4923 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4924 printf-like functions.
4925 (tiff_load): Add casts to remove these marks before passing them
4926 to system-supplied API.
4927
4928 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4929
4930 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4931 This avoids several warnings with gcc -Wstrict-overflow.
4932 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4933 directly, rather than having caller test rule sign. This avoids
4934 some unnecessary tests.
4935 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4936 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4937 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4938
4939 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4940 (xfont_open): Avoid unnecessary tests.
4941
4942 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4943
4944 * composite.h, composite.c (composition_gstring_put_cache):
4945 Use EMACS_INT, not int, for length.
4946
4947 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4948 breaking out part of COMPOSITION_DECODE_RULE.
4949 (COMPOSITION_DECODE_RULE): Use it.
4950 * composite.c (get_composition_id): Remove unused local vars,
4951 by using the new macro.
4952
4953 * textprop.c (set_text_properties_1): Change while to do-while,
4954 since the condition is always true at first.
4955
4956 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4957 (interval_deletion_adjustment): Return unsigned value.
4958 All uses changed.
4959
4960 * process.c (list_processes_1, create_pty, read_process_output):
4961 (exec_sentinel): Remove vars that were set but not used.
4962 (create_pty): Remove unnecessary "volatile"s.
4963 (Fnetwork_interface_info): Avoid possibility of int overflow.
4964 (read_process_output): Do adaptive read buffering even if carryover.
4965 (read_process_output): Simplify nbytes computation if buffered.
4966
4967 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4968
4969 * syntax.c (scan_words): Remove var that was set but not used.
4970 (update_syntax_table): Use unsigned instead of int.
4971
4972 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4973 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4974 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4975
4976 * print.c (print_error_message): Avoid int overflow.
4977
4978 * font.c (font_list_entities): Redo for clarity,
4979 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4980
4981 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4982 (font_score): Avoid potential overflow in diff calculation.
4983
4984 * fns.c (substring_both): Remove var that is set but not used.
4985 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4986
4987 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4988
4989 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4990 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4991 can always succeed if overflow has undefined behavior.
4992
4993 * search.c (boyer_moore, wordify): Remove vars set but not used.
4994 (wordify): Omit three unnecessary tests.
4995
4996 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4997 All callers changed. This avoids the need for an unused var.
4998
4999 * casefiddle.c (casify_region): Remove var that is set but not used.
5000
5001 * dired.c (file_name_completion): Remove var that is set but not used.
5002
5003 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5004
5005 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5006 (Finsert_file_contents): Remove unnecessary code checking fd.
5007
5008 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5009 Check for integer overflow on size calculations.
5010
5011 * buffer.c (Fprevious_overlay_change): Remove var that is set
5012 but not used.
5013
5014 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5015 Remove vars that are set but not used.
5016 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5017 (timer_check_2): Mark vars as initialized.
5018
5019 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5020
5021 * image.c (lookup_image): Remove var that is set but not used.
5022 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5023
5024 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5025 that are set but not used.
5026
5027 * xfns.c (make_invisible_cursor): Don't return garbage
5028 if XCreateBitmapFromData fails (Bug#8410).
5029
5030 * xselect.c (x_get_local_selection, x_handle_property_notify):
5031 Remove vars that are set but not used.
5032
5033 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5034 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5035
5036 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5037 Remove var that is set but not used.
5038 (scroll_bar_windows_size): Now size_t, not int.
5039 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5040 Check for overflow.
5041
5042 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5043 (map_tty_color) [!defined MSDOS]: Likewise.
5044
5045 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5046
5047 * coding.c: Remove vars that are set but not used.
5048 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5049 All callers changed.
5050 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5051 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5052 (decode_coding_charset): Remove vars that are set but not used.
5053
5054 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5055 that is set but not used.
5056
5057 * print.c (print_object): Remove var that is set but not used.
5058
5059 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5060 The gnulib version avoids calling malloc in the usual case,
5061 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5062 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5063 * filelock.c (current_lock_owner): Likewise.
5064 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5065 * sysdep.c: Include allocator.h, careadlinkat.h.
5066 (emacs_no_realloc_allocator): New static constant.
5067 (emacs_readlink): New function.
5068 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5069 ../lib/careadlinkat.h.
5070
5071 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5072
5073 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5074 first non-nil return value).
5075
5076 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5077
5078 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5079 if not defined (Bug#8403).
5080
5081 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5082
5083 * xdisp.c (display_count_lines): Remove parameter `start',
5084 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5085 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5086 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5087 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5088 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5089 and thereabouts. All callers changed.
5090 (get_per_char_metric): Remove parameter `f', unused since
5091 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5092
5093 2011-04-02 Jim Meyering <meyering@redhat.com>
5094
5095 do not dereference NULL upon failed strdup
5096 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5097 (ns_get_family): Likewise.
5098
5099 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5100
5101 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5102
5103 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5104
5105 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5106 later (Bug#8403).
5107
5108 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5109
5110 Add lexical binding.
5111
5112 * window.c (Ftemp_output_buffer_show): New fun.
5113 (Fsave_window_excursion):
5114 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5115
5116 * lread.c (lisp_file_lexically_bound_p): New function.
5117 (Fload): Bind Qlexical_binding.
5118 (readevalloop): Remove `evalfun' arg.
5119 Bind Qinternal_interpreter_environment.
5120 (Feval_buffer): Bind Qlexical_binding.
5121 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5122 Mark as dynamic.
5123 (syms_of_lread): Declare `lexical-binding'.
5124
5125 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5126
5127 * keyboard.c (eval_dyn): New fun.
5128 (menu_item_eval_property): Use it.
5129
5130 * image.c (parse_image_spec): Use Ffunctionp.
5131
5132 * fns.c (concat, mapcar1): Accept byte-code-functions.
5133
5134 * eval.c (Fsetq): Handle lexical vars.
5135 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5136 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5137 (FletX, Flet): Obey lexical binding.
5138 (Fcommandp): Handle closures.
5139 (Feval): New `lexical' arg.
5140 (eval_sub): New function extracted from Feval. Use it almost
5141 everywhere where Feval was used. Look up vars in lexical env.
5142 Handle closures.
5143 (Ffunctionp): Move from subr.el.
5144 (Ffuncall): Handle closures.
5145 (apply_lambda): Remove `eval_flags'.
5146 (funcall_lambda): Handle closures and new byte-code-functions.
5147 (Fspecial_variable_p): New function.
5148 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5149 but without exporting it to Lisp.
5150
5151 * doc.c (Fdocumentation, store_function_docstring):
5152 * data.c (Finteractive_form): Handle closures.
5153
5154 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5155 interactive spec.
5156
5157 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5158 New byte-codes.
5159 (exec_byte_code): New function extracted from Fbyte_code to handle new
5160 calling convention for byte-code-functions. Add new byte-codes.
5161
5162 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5163
5164 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5165
5166 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5167
5168 * xdisp.c (redisplay_internal): Fix prototype.
5169
5170 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5171
5172 * xdisp.c (SCROLL_LIMIT): New macro.
5173 (try_scrolling): Use it when setting scroll_limit.
5174 Limit scrolling to 100 screen lines.
5175 (redisplay_window): Even when falling back on "recentering",
5176 position point in the window according to scroll-conservatively,
5177 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5178
5179 (try_scrolling): When point is above the window, allow searching
5180 as far as scroll_max, or one screenful, to compute vertical
5181 distance from PT to the scroll margin position. This prevents
5182 try_scrolling from unnecessarily failing when
5183 scroll-conservatively is set to a value slightly larger than the
5184 window height. Clean up the case of PT below the margin at bottom
5185 of window: scroll_max can no longer be INT_MAX. When aggressive
5186 scrolling is in use, don't let point enter the opposite scroll
5187 margin as result of the scroll.
5188 (syms_of_xdisp) <scroll-conservatively>: Document the
5189 threshold of 100 lines for never-recentering scrolling.
5190
5191 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5192
5193 * dispextern.h (move_it_by_lines):
5194 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5195 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5196 (message_log_check_duplicate): Remove parameters `prev_bol' and
5197 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5198 (redisplay_internal): Remove parameter `preserve_echo_area',
5199 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5200
5201 * indent.c (Fvertical_motion):
5202 * window.c (window_scroll_pixel_based, Frecenter):
5203 Don't pass `need_y_p' to `move_it_by_lines'.
5204
5205 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5206
5207 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5208 steal a few bits to be more compact.
5209 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5210 Remove unneeded casts.
5211
5212 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5213
5214 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5215
5216 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5217 binding" message (bug#7967).
5218
5219 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5220
5221 Fix more problems found by GCC 4.6.0's static checks.
5222
5223 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5224 Remove unused local var.
5225
5226 * editfns.c (Fmessage_box): Remove unused local var.
5227
5228 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5229 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5230 Omit unused local vars.
5231 * window.c (shrink_windows): Omit unused local var.
5232 * menu.c (digest_single_submenu): Omit unused local var.
5233 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5234 Omit unused local var.
5235
5236 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5237 Don't assume string length fits in int.
5238 (keyremap_step, read_key_sequence): Use size_t for sizes.
5239 (read_key_sequence): Don't check last_real_key_start redundantly.
5240
5241 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5242 instead of alloca (Bug#8344).
5243
5244 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5245 (Fbacktrace_frame): Don't assume nframes fits in int.
5246
5247 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5248
5249 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5250 concerns.
5251
5252 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5253
5254 * cm.c (calccost): Turn while-do into do-while, for clarity.
5255
5256 * keyboard.c (syms_of_keyboard): Use the same style as later
5257 in this function when indexing through an array. This also
5258 works around GCC bug 48267.
5259
5260 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5261
5262 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5263
5264 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5265 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5266
5267 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5268 This avoids undefined behavior on integer overflow, and is a bit
5269 more convenient anyway since it is compared to a size_t variable.
5270
5271 Variadic C functions now count arguments with size_t, not int.
5272 This avoids an unnecessary limitation on 64-bit machines, which
5273 caused (substring ...) to crash on large vectors (Bug#8344).
5274 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5275 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5276 All variadic functions and their callers changed accordingly.
5277 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5278 * data.c (arith_driver, float_arith_driver): Likewise.
5279 * editfns.c (general_insert_function): Likewise.
5280 * eval.c (struct backtrace.nargs, interactive_p)
5281 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5282 (funcall_lambda, mark_backtrace): Likewise.
5283 * fns.c (concat): Likewise.
5284 * frame.c (x_set_frame_parameters): Likewise.
5285 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5286 0 if not found, not -1. All callers changed.
5287
5288 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5289 (stack_copy_size): Now size_t, not int.
5290 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5291
5292 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5293
5294 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5295 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5296 All callers changed.
5297
5298 * lisp.h (multibyte_char_to_unibyte):
5299 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5300 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5301 * character.h (CHAR_TO_BYTE8):
5302 * cmds.c (internal_self_insert):
5303 * editfns.c (general_insert_function):
5304 * keymap.c (push_key_description):
5305 * search.c (Freplace_match):
5306 * xdisp.c (message_dolog, set_message_1): All callers changed.
5307
5308 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5309
5310 * keyboard.c (safe_run_hook_funcall): New function.
5311 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5312 don't set the hook to nil, but remove the offending function instead.
5313 (Qcommand_hook_internal): Remove, unused.
5314 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5315 Vcommand_hook_internal.
5316
5317 * eval.c (enum run_hooks_condition): Remove.
5318 (funcall_nil, funcall_not): New functions.
5319 (run_hook_with_args): Call each function through a `funcall' argument.
5320 Remove `cond' argument, now redundant.
5321 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5322 (Frun_hook_with_args_until_failure): Adjust accordingly.
5323 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5324
5325 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5326
5327 * dispextern.h (string_buffer_position): Remove declaration.
5328
5329 * print.c (strout): Remove parameter `multibyte', unused since
5330 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5331
5332 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5333 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5334 All callers changed.
5335
5336 * w32.c (_wsa_errlist): Use braces for struct initializers.
5337
5338 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5339 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5340 All callers changed.
5341 (string_buffer_position): Likewise. Also, make static (it's never
5342 used outside xdisp.c).
5343 (cursor_row_p): Remove parameter `w', unused since
5344 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5345 (decode_mode_spec): Remove parameter `precision', introduced during
5346 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5347 All callers changed.
5348
5349 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5350
5351 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5352
5353 2011-03-27 Anders Lindgren <andlind@gmail.com>
5354
5355 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5356 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5357 (ns_update_auto_hide_menu_bar): New functions.
5358 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5359 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5360 ns_constrain_all_frames.
5361 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5362 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5363
5364 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5365
5366 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5367
5368 2011-03-27 Glenn Morris <rgm@gnu.org>
5369
5370 * syssignal.h: Replace RETSIGTYPE with void.
5371 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5372 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5373 Replace SIGTYPE with void everywhere.
5374 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5375 * s/template.h (SIGTYPE): Remove commented out definition.
5376
5377 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5378
5379 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5380 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5381
5382 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5383
5384 * w32.c (read_unc_volume): Use parameter `henum', instead of
5385 global variable `wget_enum_handle'.
5386
5387 * keymap.c (describe_vector): Remove parameters `indices' and
5388 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5389 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5390
5391 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5392
5393 * keyboard.c (timer_check): Remove parameter `do_it_now',
5394 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5395 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5396 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5397
5398 * keyboard.c (read_char):
5399 * w32menu.c (w32_menu_display_help):
5400 * xmenu.c (show_help_event, menu_help_callback):
5401 Adjust calls to `show_help_echo'.
5402
5403 * gtkutil.c (xg_maybe_add_timer):
5404 * keyboard.c (readable_events):
5405 * process.c (wait_reading_process_output):
5406 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5407
5408 * insdel.c (adjust_markers_gap_motion):
5409 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5410 (gap_left, gap_right): Don't call it.
5411
5412 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5413
5414 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5415 incurred during fontification.
5416
5417 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5418
5419 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5420 (DEFVAR_PER_BUFFER): Don't pass it.
5421
5422 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5423 (scrolling_window): Don't pass it.
5424
5425 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5426
5427 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5428
5429 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5430 and `suffix'.
5431 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5432 of variables specific to SELinux and computation of `encoded_absname'.
5433
5434 * image.c (XPutPixel): Remove unused variable `height'.
5435
5436 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5437
5438 * unexw32.c (get_section_info): Remove unused variable `section'.
5439
5440 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5441 (system_process_attributes): Remove unused variable `sess'.
5442 (sys_read): Remove unused variable `err'.
5443
5444 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5445 (w32_wnd_proc): Remove unused variable `isdead'.
5446 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5447 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5448 (x_create_tip_frame): Remove unused variable `tem'.
5449
5450 * w32inevt.c (w32_console_read_socket):
5451 Remove unused variable `no_events'.
5452
5453 * w32term.c (x_draw_composite_glyph_string_foreground):
5454 Remove unused variable `width'.
5455
5456 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5457
5458 * w32term.c (x_set_glyph_string_clipping):
5459 Don't pass uninitialized region to CombineRgn.
5460
5461 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5462
5463 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5464 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5465 (Fx_close_connection): Remove unused variable `i'.
5466
5467 * w32font.c (w32font_draw): Return number of glyphs.
5468 (w32font_open_internal): Remove unused variable `i'.
5469 (w32font_driver): Add missing initializer.
5470
5471 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5472 (fill_in_menu): Remove unused variable `items_added'.
5473
5474 * w32term.c (last_mouse_press_frame): Remove static global variable.
5475 (w32_clip_to_row): Remove unused variable `f'.
5476 (x_delete_terminal): Remove unused variable `i'.
5477
5478 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5479 (NOTHING): Remove unused static global variable.
5480 (uniscribe_check_otf): Remove unused variable `table'.
5481 (uniscribe_font_driver): Add missing initializers.
5482
5483 2011-03-23 Julien Danjou <julien@danjou.info>
5484
5485 * term.c (Fsuspend_tty, Fresume_tty):
5486 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5487 * window.c (temp_output_buffer_show):
5488 * insdel.c (signal_before_change):
5489 * frame.c (Fhandle_switch_frame):
5490 * fileio.c (Fdo_auto_save):
5491 * emacs.c (Fkill_emacs):
5492 * editfns.c (save_excursion_restore):
5493 * cmds.c (internal_self_insert):
5494 * callint.c (Fcall_interactively):
5495 * buffer.c (Fkill_all_local_variables):
5496 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5497 Use Frun_hooks.
5498 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5499 unconditionnaly since it does the check itself.
5500
5501 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5502
5503 Fix more problems found by GCC 4.5.2's static checks.
5504
5505 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5506 the first time through the loop, since we know p0 < p1 then.
5507 This also avoids a gcc -Wstrict-overflow warning.
5508
5509 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5510 leading to a memory leak, possible in functions like
5511 load_charset_map_from_file that can allocate an unbounded number
5512 of objects (Bug#8318).
5513
5514 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5515 that could (at least in theory) be that large.
5516
5517 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5518 This is less likely to overflow, and avoids undefined behavior if
5519 overflow does occur. All callers changed. Use strtoul to scan
5520 for the unsigned long integer.
5521 (pint2hrstr): Simplify and tune code slightly.
5522 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5523
5524 * scroll.c (do_scrolling): Work around GCC bug 48228.
5525 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5526
5527 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5528 This also avoids a warning with gcc -Wstrict-overflow.
5529 (validate_x_resource_name): Simplify count usage.
5530 This also avoids a warning with gcc -Wstrict-overflow.
5531
5532 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5533 fail (Bug#8306).
5534
5535 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5536
5537 * process.c (Fmake_network_process): Use socklen_t, not int,
5538 where POSIX says socklen_t is required in portable programs.
5539 This fixes a porting bug on hosts like 64-bit HP-UX, where
5540 socklen_t is wider than int (Bug#8277).
5541 (Fmake_network_process, server_accept_connection):
5542 (wait_reading_process_output, read_process_output):
5543 Likewise.
5544
5545 * process.c: Rename or move locals to avoid shadowing.
5546 (list_processes_1, Fmake_network_process):
5547 (read_process_output_error_handler, exec_sentinel_error_handler):
5548 Rename or move locals.
5549 (Fmake_network_process): Define label "retry_connect" only if needed.
5550 (Fnetwork_interface_info): Fix pointer signedness.
5551 (process_send_signal): Add cast to avoid pointer signedness problem.
5552 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5553 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5554
5555 Make tparam.h and terminfo.c consistent.
5556 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5557 Include tparam.h instead, since it declares them.
5558 * cm.h (PC): Remove extern decl; tparam.h now does this.
5559 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5560 * terminfo.c: Include tparam.h, to check interfaces.
5561 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5562 (tparam): Adjust signature to match interface in tparam.h;
5563 this removes some undefined behavior. Check that outstring and len
5564 are zero, which they always are with Emacs.
5565 * tparam.h (PC, BC, UP): New extern decls.
5566
5567 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5568 (xftfont_open): Rename locals to avoid shadowing.
5569
5570 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5571 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5572 (OTF_TAG_SYM): Omit macro if not needed.
5573 (ftfont_list): Remove unused local.
5574 (get_adstyle_property, ftfont_pattern_entity):
5575 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5576 Rename locals to avoid shadowing.
5577
5578 * xfont.c (xfont_list_family): Mark var as initialized.
5579
5580 * xml.c (make_dom): Now static.
5581
5582 * composite.c (composition_compute_stop_pos): Rename local to
5583 avoid shadowing.
5584 (composition_reseat_it): Remove unused locals.
5585 (find_automatic_composition, composition_adjust_point): Likewise.
5586 (composition_update_it): Mark var as initialized.
5587 (find_automatic_composition): Mark vars as initialized,
5588 with a FIXME (Bug#8290).
5589
5590 character.h: Rename locals to avoid shadowing.
5591 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5592 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5593 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5594 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5595 to avoid shadowing.
5596
5597 * textprop.c (property_change_between_p): Remove; unused.
5598
5599 * intervals.c (interval_start_pos): Now static.
5600
5601 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5602
5603 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5604 Rename locals to avoid shadowing.
5605
5606 * sound.c (wav_play, au_play, Fplay_sound_internal):
5607 Fix pointer signedness.
5608 (alsa_choose_format): Remove unused local var.
5609 (wav_play): Initialize a variable to 0, to prevent undefined
5610 behavior (Bug#8278).
5611
5612 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5613
5614 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5615
5616 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5617 clobbering (Bug#8298).
5618 * sysdep.c (sys_subshell): Likewise.
5619 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5620
5621 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5622 This should get cleaned up, so that child_setup has the
5623 same signature on all platforms.
5624
5625 * callproc.c (call_process_cleanup): Now static.
5626 (relocate_fd): Rename locals to avoid shadowing.
5627
5628 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5629
5630 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5631 not to be necessary, and produces flickering.
5632
5633 2011-03-20 Glenn Morris <rgm@gnu.org>
5634
5635 * config.in: Remove file.
5636
5637 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5638
5639 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5640 are now in src/globals.h.
5641 (syms_of_minibuf): Remove spurious & from previous change.
5642
5643 2011-03-20 Leo <sdl.web@gmail.com>
5644
5645 * minibuf.c (completing-read-function): New variable.
5646 (completing-read-default): Rename from completing-read.
5647 (completing-read): Call completing-read-function.
5648
5649 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5650
5651 * xfaces.c (Fx_load_color_file):
5652 Read color file from absolute filename (bug#8250).
5653
5654 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5655
5656 * makefile.w32-in: Update dependencies.
5657
5658 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5659
5660 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5661
5662 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5663
5664 Fix more problems found by GCC 4.5.2's static checks.
5665
5666 * process.c (make_serial_process_unwind, send_process_trap):
5667 (sigchld_handler): Now static.
5668
5669 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5670 That way, the code declares only the vars that it needs.
5671 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5672 * s/cygwin.h (PTY_ITERATION): Likewise.
5673 * s/darwin.h (PTY_ITERATION): Likewise.
5674 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5675
5676 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5677 * process.c (allocate_pty): Don't declare stb unless it's needed.
5678
5679 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5680 (CONSTANTLIM): Remove; unused.
5681 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5682 Define only if needed.
5683
5684 * unexelf.c (unexec): Name an expression,
5685 to avoid gcc -Wbad-function-cast warning.
5686 Use a different way to cause a compilation error if anyone uses
5687 n rather than nn, a way that does not involve shadowing.
5688 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5689
5690 * deps.mk (unexalpha.o): Remove; unused.
5691
5692 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5693 * unexec.h: New file.
5694 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5695 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5696 Depend on unexec.h.
5697 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5698 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5699 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5700 Change as necessary to match prototype in unexec.h.
5701
5702 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5703 shadowing.
5704 (back_comment, skip_chars): Mark vars as initialized.
5705
5706 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5707 Rename locals to avoid shadowing.
5708
5709 * lread.c (read1): Rewrite so as not to use empty "else".
5710 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5711
5712 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5713
5714 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5715 warning when compiling print.c.
5716
5717 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5718 instead of using an uninitialized var.
5719 (font_sort_entities): Mark var as initialized.
5720
5721 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5722
5723 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5724 pointers to constants.
5725 (font_parse_fcname): Remove unused vars.
5726 (font_delete_unmatched): Now static.
5727 (font_get_spec): Remove; unused.
5728 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5729 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5730 Rename or move locals to avoid shadowing.
5731
5732 * fns.c (require_nesting_list, require_unwind): Now static.
5733 (Ffillarray): Rename locals to avoid shadowing.
5734
5735 * floatfns.c (domain_error2): Define only if needed.
5736 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5737
5738 * alloc.c (mark_backtrace): Move decl from here ...
5739 * lisp.h: ... to here, so that it can be checked.
5740
5741 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5742 (Fdefvar): Rewrite so as not to use empty "else".
5743 (lisp_indirect_variable): Name an expression,
5744 to avoid gcc -Wbad-function-cast warning.
5745 (Fdefvar): Rename locals to avoid shadowing.
5746
5747 * callint.c (quotify_arg, quotify_args): Now static.
5748 (Fcall_interactively): Rename locals to avoid shadowing.
5749 Use const pointer when appropriate.
5750
5751 * lisp.h (get_system_name, get_operating_system_release):
5752 Move decls here, to check interfaces.
5753 * process.c (get_operating_system_release): Move decl to lisp.h.
5754 * xrdb.c (get_system_name): Likewise.
5755 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5756 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5757 some of which prompt warnings from gcc -Wbad-function-cast.
5758 (Fformat_time_string, Fencode_time, Finsert_char):
5759 (Ftranslate_region_internal, Fformat):
5760 Rename or remove local vars to avoid shadowing.
5761 (Ftranslate_region_internal): Mark var as initialized.
5762
5763 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5764 avoid shadowing.
5765
5766 * lisp.h (eassert): Check that the argument compiles, even if
5767 ENABLE_CHECKING is not defined.
5768
5769 * data.c (Findirect_variable): Name an expression, to avoid
5770 gcc -Wbad-function-cast warning.
5771 (default_value, arithcompare, arith_driver, arith_error): Now static.
5772 (store_symval_forwarding): Rename local to avoid shadowing.
5773 (Fmake_variable_buffer_local, Fmake_local_variable):
5774 Mark variables as initialized.
5775 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5776
5777 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5778 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5779 Rename locals to avoid shadowing.
5780 (mark_stack): Move local variables into the #ifdef region where
5781 they're used.
5782 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5783 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5784 needed otherwise.
5785 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5786 (GC_STRING_CHARS): Remove; not used.
5787 (Fmemory_limit): Cast sbrk's returned value to char *.
5788
5789 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5790 avoids undefined behavior in theory.
5791
5792 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5793
5794 Use functions, not macros, for up- and down-casing (Bug#8254).
5795 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5796 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5797 to use the following functions instead of these macros.
5798 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5799 EMACS_INT, since callers assume the returned value fits in int.
5800 (upcase1): Likewise, for UPCASE_TABLE.
5801 (uppercasep, lowercasep, upcase): New static inline functions.
5802 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5803 the race-condition problem in the old DOWNCASE.
5804
5805 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5806 Rename locals to avoid shadowing.
5807 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5808 (regex_compile, re_search_2, re_match_2_internal):
5809 Remove unused local vars.
5810 (FREE_VAR): Rewrite so as not to use empty "else",
5811 which gcc can warn about.
5812 (regex_compile, re_match_2_internal): Mark locals as initialized.
5813 (RETALLOC_IF): Define only if needed.
5814 (WORDCHAR_P): Likewise. This one is never needed, but is used
5815 only in a comment talking about a compiler bug, so put inside
5816 the #if 0 of that comment.
5817 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5818 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5819 Remove; unused.
5820
5821 * search.c (boyer_moore): Rename locals to avoid shadowing.
5822 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5823 (PREV_CHAR_BOUNDARY): Likewise.
5824
5825 * search.c (simple_search): Remove unused var.
5826
5827 * dired.c (compile_pattern): Move decl from here ...
5828 * lisp.h: ... to here, so that it can be checked.
5829 (struct re_registers): New forward decl.
5830
5831 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5832
5833 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5834 All uses changed.
5835 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5836 Rename locals to avoid shadowing.
5837 (Fvertical_motion): Mark locals as initialized.
5838
5839 * casefiddle.c (casify_object, casify_region): Now static.
5840 (casify_region): Mark local as initialized.
5841
5842 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5843
5844 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5845 New macros, so that the caller can use some names other than
5846 gcpro1, gcpro2, etc.
5847 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5848 of the new macros.
5849 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5850 argument, for consistency with GCPRO2_VAR, etc: it is now the
5851 prefix of the variable, not the variable itself. All uses
5852 changed.
5853 * dired.c (directory_files_internal, file_name_completion):
5854 Rename locals to avoid shadowing.
5855
5856 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5857 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5858 dired.c's scmp function, had undefined behavior.
5859 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5860 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5861 * buffer.h: ... to here, because these macros use current_buffer,
5862 and the new implementation with inline functions needs to have
5863 current_buffer in scope now, rather than later when the macros
5864 are used.
5865 (downcase, upcase1): New static inline functions.
5866 (DOWNCASE, UPCASE1): Reimplement using these functions.
5867 This avoids undefined behavior in expressions like
5868 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5869 from race conditions in accessing the global variables
5870 case_temp1 and case_temp2.
5871 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5872 * lisp.h (case_temp1, case_temp2): Remove their decls.
5873 * character.h (ASCII_CHAR_P): Move from here ...
5874 * lisp.h: ... to here, so that the inline functions mentioned
5875 above can use them.
5876
5877 * dired.c (directory_files_internal_unwind): Now static.
5878
5879 * fileio.c (file_name_as_directory, directory_file_name):
5880 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5881 Now static.
5882 (file_name_as_directory): Use const pointers when appropriate.
5883 (Fexpand_file_name): Likewise. In particular, newdir might
5884 point at constant storage, so make it a const pointer.
5885 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5886 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5887 signedness issues.
5888 (Fset_file_times, Finsert_file_contents, auto_save_error):
5889 Rename locals to avoid shadowing.
5890
5891 * minibuf.c (choose_minibuf_frame_1): Now static.
5892 (Ftry_completion, Fall_completions): Rename or remove locals
5893 to avoid shadowing.
5894
5895 * marker.c (bytepos_to_charpos): Remove; unused.
5896
5897 * lisp.h (verify_bytepos, count_markers): New decls,
5898 so that gcc does not warn that these functions aren't declared.
5899
5900 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5901 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5902 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5903 (copy_text): Remove unused local var.
5904
5905 * filelock.c (within_one_second): Now static.
5906 (lock_file_1): Rename local to avoid shadowing.
5907
5908 * buffer.c (fix_overlays_before): Mark locals as initialized.
5909 (fix_start_end_in_overlays): Likewise. This function should be
5910 simplified by using pointers-to-pointers, but that's a different
5911 matter.
5912 (switch_to_buffer_1): Now static.
5913 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5914 (report_overlay_modification): Rename locals to avoid shadowing.
5915
5916 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5917 Fix pointer signedness issue.
5918 (sys_subshell): Mark local as volatile if checking for lint,
5919 to suppress a gcc -Wclobbered warning that does not seem to be right.
5920 (MAXPATHLEN): Define only if needed.
5921
5922 * process.c (serial_open, serial_configure): Move decls from here ...
5923 * systty.h: ... to here, so that they can be checked.
5924
5925 * fns.c (get_random, seed_random): Move extern decls from here ...
5926 * lisp.h: ... to here, so that they can be checked.
5927
5928 * sysdep.c (reset_io): Now static.
5929 (wait_for_termination_signal): Remove; unused.
5930
5931 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5932 (copy_keymap_item, append_key, push_text_char_description):
5933 Now static.
5934 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5935 (DENSE_TABLE_SIZE): Remove; unused.
5936 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5937 (describe_map_tree):
5938 Rename locals to avoid shadowing.
5939
5940 * keyboard.c: Declare functions static if they are not used elsewhere.
5941 (echo_char, echo_dash, cmd_error, top_level_2):
5942 (poll_for_input, handle_async_input): Now static.
5943 (read_char, kbd_buffer_get_event, make_lispy_position):
5944 (make_lispy_event, make_lispy_movement, apply_modifiers):
5945 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5946 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5947 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5948 (read_key_sequence, read_char): Mark locals as initialized.
5949 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5950
5951 * keyboard.h (make_ctrl_char): New decl.
5952 (mark_kboards): Move decl here ...
5953 * alloc.c (mark_kboards): ... from here.
5954
5955 * lisp.h (force_auto_save_soon): New decl.
5956
5957 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5958 (DEFINE_DUMMY_FUNCTION): New macro.
5959 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5960 Use it.
5961 (main): Add casts to avoid warnings
5962 if GCC considers string literals to be constants.
5963
5964 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5965
5966 * dbusbind.c: Pointer signedness fixes.
5967 (xd_signature, xd_append_arg, xd_initialize):
5968 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5969 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5970 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5971 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5972
5973 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5974 if GCC considers string literals to be constants.
5975 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5976
5977 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5978
5979 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5980 (print_preprocess, print_object): New macro to fix last change.
5981
5982 * print.c (print_preprocess): Don't forget font objects.
5983
5984 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5985
5986 * emacs.c (USAGE3): Doc fixes.
5987
5988 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5989
5990 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5991 structure.
5992
5993 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5994
5995 * lisp.h (VWindow_system, Qfile_name_history):
5996 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5997 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5998 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5999
6000 * w32select.c: Don't #include "keyboard.h".
6001 (run_protected): Add extern declaration for waiting_for_input.
6002
6003 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6004 * w32console.c (detect_input_pending, read_input_pending)
6005 (encode_terminal_code):
6006 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6007 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6008 (w32_system_caret_y, Qfile_name_history):
6009 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6010 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6011 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6012 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6013 * w32proc.c (Qlocal, report_file_error):
6014 * w32term.c (Vwindow_system, updating_frame):
6015 * w32uniscribe.c (initialized, uniscribe_font_driver):
6016 Remove unneeded extern declarations.
6017
6018 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6019
6020 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6021
6022 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6023
6024 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6025 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6026 These macros can no longer be used for assignment.
6027
6028 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6029 Assign struct members directly, instead of using BUF_BEGV etc.
6030 (record_buffer_markers, fetch_buffer_markers): New functions for
6031 recording and fetching special buffer markers.
6032 (set_buffer_internal_1, set_buffer_temp): Use them.
6033
6034 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6035
6036 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6037
6038 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6039 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6040
6041 * xdisp.c (hscroll_window_tree):
6042 (reconsider_clip_changes): Use PT instead of BUF_PT.
6043
6044 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6045
6046 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6047 $(EMACS_ROOT)/lib/intprops.h.
6048
6049 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6050
6051 Fix more problems found by GCC 4.5.2's static checks.
6052
6053 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6054 to unsigned char * to avoid compiler diagnostic.
6055 (xg_free_frame_widgets): Make it clear that a local variable is
6056 needed only if USE_GTK_TOOLTIP.
6057 (gdk_window_get_screen): Make it clear that this macro is needed
6058 only if USE_GTK_TOOLTIP.
6059 (int_gtk_range_get_value): New function, which avoids a diagnostic
6060 from gcc -Wbad-function-cast.
6061 (xg_set_toolkit_scroll_bar_thumb): Use it.
6062 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6063 diagnostic from gcc -Wbad-function-cast.
6064 (get_utf8_string, xg_get_file_with_chooser):
6065 Rename locals to avoid shadowing.
6066 (create_dialog): Move locals to avoid shadowing.
6067
6068 * xgselect.c (xg_select): Remove unused var.
6069
6070 * image.c (four_corners_best): Mark locals as initialized.
6071 (gif_load): Initialize transparent_p to zero (Bug#8238).
6072 Mark another local as initialized.
6073 (my_png_error, my_error_exit): Mark with NO_RETURN.
6074
6075 * image.c (clear_image_cache): Now static.
6076 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6077 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6078 (x_edge_detection): Remove unnecessary cast that
6079 gcc -Wbad-function-cast diagnoses.
6080 (gif_load): Fix pointer signedness.
6081 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6082 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6083
6084 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6085
6086 Improve quality of tests for time stamp overflow.
6087 For example, without this patch (encode-time 0 0 0 1 1
6088 1152921504606846976) returns the obviously-bogus value (-948597
6089 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6090 reports time overflow. See
6091 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6092 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6093 * editfns.c: Include limits.h and intprops.h.
6094 (TIME_T_MIN, TIME_T_MAX): New macros.
6095 (time_overflow): Move earlier, to before first use.
6096 (hi_time, lo_time): New functions, for an accurate test for
6097 out-of-range times.
6098 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6099 (Fget_internal_run_time): Don't assume time_t fits in int.
6100 (make_time): Use list2 instead of Fcons twice.
6101 (Fdecode_time): More accurate test for out-of-range times.
6102 (check_tm_member): New function.
6103 (Fencode_time): Use it, to test for out-of-range times.
6104 (lisp_time_argument): Don't rely on undefined left-shift and
6105 right-shift behavior when checking for time stamp overflow.
6106
6107 * editfns.c (time_overflow): New function, refactoring common code.
6108 (Fformat_time_string, Fdecode_time, Fencode_time):
6109 (Fcurrent_time_string): Use it.
6110
6111 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6112 * dired.c (make_time): Move to ...
6113 * editfns.c (make_time): ... here.
6114 * systime.h: Note the move.
6115
6116 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6117
6118 * fringe.c (update_window_fringes): Remove unused variables.
6119
6120 * unexmacosx.c (copy_data_segment): Also copy __got section.
6121 (Bug#8223)
6122
6123 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6124
6125 * termcap.c [MSDOS]: Include "msdos.h".
6126 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6127 Constify `char *' arguments and their references according to
6128 prototypes in tparam.h.
6129
6130 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6131
6132 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6133 Adapt all references accordingly.
6134
6135 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6136
6137 2011-03-11 Tom Tromey <tromey@redhat.com>
6138
6139 * buffer.c (syms_of_buffer): Remove obsolete comment.
6140
6141 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6142
6143 * termhooks.h (encode_terminal_code): Declare prototype.
6144
6145 * msdos.c (encode_terminal_code): Don't declare prototype.
6146
6147 * term.c (encode_terminal_code): Now external again, used by
6148 w32console.c and msdos.c.
6149
6150 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6151 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6152
6153 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6154
6155 Fix some minor problems found by GCC 4.5.2's static checks.
6156
6157 * fringe.c (update_window_fringes): Mark locals as initialized
6158 (Bug#8227).
6159 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6160
6161 * alloc.c (mark_fringe_data): Move decl from here ...
6162 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6163 to check its interface.
6164 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6165
6166 * fontset.c (free_realized_fontset): Now static.
6167 (Fset_fontset_font): Rename local to avoid shadowing.
6168 (fontset_font): Mark local as initialized.
6169 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6170
6171 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6172
6173 * xselect.c (x_disown_buffer_selections): Remove; not used.
6174 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6175 (x_own_selection, Fx_disown_selection_internal): Rename locals
6176 to avoid shadowing.
6177 (x_handle_dnd_message): Remove local to avoid shadowing.
6178
6179 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6180 so that the caller can use some name other than gcpro1.
6181 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6182 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6183 (Fx_backspace_delete_keys_p):
6184 Use them to avoid shadowing, and rename vars to avoid shadowing.
6185 (x_decode_color, x_set_name, x_window): Now static.
6186 (Fx_create_frame): Add braces to silence GCC warning.
6187 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6188 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6189 Remove unused locals.
6190 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6191 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6192 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6193 macros.
6194
6195 * xterm.h (x_mouse_leave): New decl.
6196
6197 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6198 Remove unused functions.
6199 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6200 (x_calc_absolute_position): Now static.
6201 (XTread_socket): Don't define label "out" unless it's used.
6202 Don't declare local "event" unless it's used.
6203 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6204 unless they are used.
6205 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6206 (x_fatal_error_signal): Remove; not used.
6207 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6208 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6209 (x_error_catcher, x_connection_closed, x_error_handler):
6210 (x_error_quitter, xembed_send_message, x_iconify_frame):
6211 (my_log_handler): Rename locals to avoid shadowing.
6212 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6213 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6214
6215 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6216 Rename or move locals to avoid shadowing.
6217 (tty_defined_color, merge_face_heights): Now static.
6218 (free_realized_faces_for_fontset): Remove; not used.
6219 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6220 does not deduce is never used uninitialized.
6221 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6222 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6223
6224 * terminal.c (store_terminal_param): Now static.
6225
6226 * xmenu.c (menu_highlight_callback): Now static.
6227 (set_frame_menubar): Remove unused local.
6228 (xmenu_show): Rename parameter to avoid shadowing.
6229 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6230 since they might point to immutable storage.
6231 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6232 since it's unused otherwise.
6233
6234 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6235 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6236 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6237 avoids a gcc -Wuninitialized diagnostic.
6238 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6239 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6240 does not deduce are never used uninitialized.
6241
6242 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6243
6244 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6245 * window.c (window_loop, size_window):
6246 (run_window_configuration_change_hook, enlarge_window): Likewise.
6247
6248 * window.c (display_buffer): Now static.
6249 (size_window): Mark variables that gcc -Wuninitialized
6250 does not deduce are never used uninitialized.
6251 * window.h (check_all_windows): New decl, to forestall
6252 gcc -Wmissing-prototypes diagnostic.
6253 * dispextern.h (bidi_dump_cached_states): Likewise.
6254
6255 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6256 shadowing.
6257 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6258 Include <limits.h>.
6259 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6260 and to avoid gcc -Wuninitialized warning.
6261 (load_charset_map): Mark variables that gcc -Wuninitialized
6262 does not deduce are never used uninitialized.
6263 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6264
6265 * coding.c (coding_set_source, coding_set_destination):
6266 Use "else { /* comment */ }" rather than "else /* comment */;"
6267 for clarity, and to avoid gcc -Wempty-body warning.
6268 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6269 a block, when the outer 'i' will do.
6270 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6271 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6272 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6273 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6274 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6275 Rename locals to avoid shadowing.
6276 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6277 * coding.c (emacs_mule_char, encode_invocation_designation):
6278 Now static, since they're not used elsewhere.
6279 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6280 (decode_coding_object, encode_coding_object, detect_coding_system):
6281 (decode_coding_emacs_mule): Mark variables that gcc
6282 -Wuninitialized does not deduce are never used uninitialized.
6283 (detect_coding_iso_2022): Initialize a local variable that might
6284 be used uninitialized. Leave a FIXME because it's not clear that
6285 this initialization is needed. (Bug#8211)
6286 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6287 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6288 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6289 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6290 Remove unused macros.
6291
6292 * category.c (hash_get_category_set): Remove unused local var.
6293 (copy_category_table): Now static, since it's not used elsewhere.
6294 * character.c (string_count_byte8): Likewise.
6295
6296 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6297 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6298
6299 * chartab.c (copy_sub_char_table): Now static, since it's not used
6300 elsewhere.
6301 (sub_char_table_ref_and_range, char_table_ref_and_range):
6302 Rename locals to avoid shadowing.
6303 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6304
6305 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6306 (BIDI_BOB): Remove unused macro.
6307
6308 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6309 deduce are never used uninitialized.
6310 * term.c (encode_terminal_code): Likewise.
6311
6312 * term.c (encode_terminal_code): Now static. Remove unused local.
6313
6314 * tparam.h: New file.
6315 * term.c, tparam.h: Include it.
6316 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6317 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6318 Move these decls to tparam.h, and make them agree with what
6319 is actually in tparam.c. The previous trick of using incompatible
6320 decls in different modules does not conform to the C standard.
6321 All callers of tparam changed to use tparam's actual API.
6322 * tparam.c (tparam1, tparam, tgoto):
6323 Use const pointers where appropriate.
6324
6325 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6326 * cm.h (struct cm): Likewise.
6327 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6328 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6329 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6330 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6331 (turn_on_face, init_tty): Likewise.
6332 * termchar.h (struct tty_display_info): Likewise.
6333
6334 * term.c (term_mouse_position): Rename local to avoid shadowing.
6335
6336 * alloc.c (mark_ttys): Move decl from here ...
6337 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6338
6339 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6340
6341 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6342
6343 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6344
6345 * search.c (compile_pattern_1): Remove argument regp, unused since
6346 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6347 (compile_pattern): Don't pass it.
6348
6349 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6350
6351 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6352 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6353 for ! HAVE_GTK3.
6354 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6355
6356 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6357
6358 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6359 gdk_window_get_screen, gdk_window_get_geometry,
6360 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6361 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6362 (xg_get_pixbuf_from_pixmap): New function.
6363 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6364 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6365 Call xg_get_pixbuf_from_pixmap instead of
6366 gdk_pixbuf_get_from_drawable.
6367 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6368 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6369 (xg_check_special_colors): Use GtkStyleContext and its functions
6370 for HAVE_GTK3.
6371 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6372 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6373 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6374 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6375 Call gtk_widget_get_preferred_size.
6376 (xg_frame_resized): gdk_window_get_geometry only takes 5
6377 parameters.
6378 (xg_win_to_widget, xg_event_is_for_menubar):
6379 Call gdk_x11_window_lookup_for_display.
6380 (xg_set_widget_bg): New function.
6381 (delete_cb): New function.
6382 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6383 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6384 (xg_set_background_color): Call xg_set_widget_bg.
6385 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6386 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6387 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6388 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6389 if ! HAVE_GTK3.
6390 (update_frame_tool_bar): Call gtk_widget_hide.
6391 (xg_initialize): Use GDK_KEY_g.
6392
6393 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6394 if ! HAVE_GTK3
6395 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6396
6397 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6398 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6399 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6400
6401 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6402
6403 * w32xfns.c (select_palette): Check success of RealizePalette against
6404 GDI_ERROR, not zero.
6405
6406 See ChangeLog.11 for earlier changes.
6407
6408 ;; Local Variables:
6409 ;; coding: utf-8
6410 ;; End:
6411
6412 Copyright (C) 2011 Free Software Foundation, Inc.
6413
6414 This file is part of GNU Emacs.
6415
6416 GNU Emacs is free software: you can redistribute it and/or modify
6417 it under the terms of the GNU General Public License as published by
6418 the Free Software Foundation, either version 3 of the License, or
6419 (at your option) any later version.
6420
6421 GNU Emacs is distributed in the hope that it will be useful,
6422 but WITHOUT ANY WARRANTY; without even the implied warranty of
6423 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6424 GNU General Public License for more details.
6425
6426 You should have received a copy of the GNU General Public License
6427 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.