Repair the MSDOS build following latest changes.
[bpt/emacs.git] / src / ChangeLog
1 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2
3 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4 to changes in oldXMenu/XMenu.h from 2011-04-16.
5 <menu_help_message, prev_menu_help_message>: Constify.
6 (IT_menu_make_room): menu->help_text is now `const char **';
7 adjust.
8
9 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10 to changes in oldXMenu/XMenu.h from 2011-04-16.
11 (struct XMenu): Declare `help_text' `const char **'.
12
13 * xfaces.c <Qunspecified>: Make extern again.
14
15 * syntax.c: Include sys/types.h before including regex.h, as
16 required by Posix.
17
18 * doc.c (get_doc_string): Improve the format passed to `error'.
19
20 * doprnt.c (doprnt): Improve commentary.
21
22 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
23
24 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
25 them with etags.
26
27 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
28 changes in globals.h immediately force recompilation.
29 (TAGS): Depend on $(CURDIR)/m/intel386.h and
30 $(CURDIR)/s/ms-w32.h.
31 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
32
33 * character.c (Fchar_direction): Function deleted.
34 (syms_of_character): Don't defsubr it.
35 <char-direction-table>: Deleted.
36
37 2011-04-23 Eli Zaretskii <eliz@gnu.org>
38
39 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
40 * doprnt.c: Include limits.h.
41 (SIZE_MAX): New macro.
42 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
43 local variables are now size_t instead of int or unsigned.
44 Improve overflow protection. Support `l' modifier for integer
45 conversions. Support %l conversion. Don't assume an EMACS_INT
46 argument for integer conversions and for %c.
47
48 * lisp.h (doprnt): Restore prototype.
49
50 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
51 $(SRC)/character.h.
52
53 * Makefile.in (base_obj): Add back doprnt.o.
54
55 * deps.mk (doprnt.o): Add back prerequisites.
56 (callint.o): Depend on character.h.
57
58 * eval.c (internal_lisp_condition_case): Include the handler
59 representation in the error message.
60 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
61 when breaking from the loop.
62
63 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
64
65 * callint.c (Fcall_interactively): When displaying error message
66 about invalid control letter, pass the character's codepoint, not
67 a pointer to its multibyte form. Improve display of the character
68 in octal and display also its hex code.
69
70 * character.c (char_string): Use %x to display the (unsigned)
71 codepoint of an invalid character, to avoid displaying a bogus
72 negative value.
73
74 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
75 `error', not SYMBOL_NAME itself.
76
77 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
78 character arguments to `error'.
79
80 * charset.c (check_iso_charset_parameter): Fix incorrect argument
81 to `error' in error message about FINAL_CHAR argument. Make sure
82 FINAL_CHAR is a character, and use %c when it is passed as
83 argument to `error'.
84
85 2011-04-23 Eli Zaretskii <eliz@gnu.org>
86
87 * s/ms-w32.h (localtime): Redirect to sys_localtime.
88
89 * w32.c: Include <time.h>.
90 (sys_localtime): New function.
91
92 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
93
94 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
95
96 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
97
98 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
99
100 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
101 zombies (Bug#8467).
102
103 2011-04-19 Eli Zaretskii <eliz@gnu.org>
104
105 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
106 gl_state.e_property when gl_state.object is Qt.
107
108 * insdel.c (make_gap_larger): Remove limitation of buffer size
109 to <= INT_MAX.
110
111 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
112
113 * xdisp.c (lookup_glyphless_char_display)
114 (produce_glyphless_glyph): Handle cons cell entry in
115 glyphless-char-display.
116 (Vglyphless_char_display): Document it.
117
118 * term.c (produce_glyphless_glyph): Handle cons cell entry in
119 glyphless-char-display.
120
121 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
122
123 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
124
125 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
126
127 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
128 definition for no-X builds.
129
130 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
131
132 Static checks with GCC 4.6.0 and non-default toolkits.
133
134 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
135
136 * process.c (keyboard_bit_set): Define only if SIGIO.
137 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
138 (send_process): Repair possible setjmp clobbering.
139
140 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
141
142 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
143
144 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
145
146 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
147 Define only if needed.
148
149 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
150 by pacifying GCC about it. Maybe it's time to retire it?
151 * xfaces.c (USG, __TIMEVAL__): Likewise.
152
153 * dispextern.h (struct redisplay_interface): Rename param
154 to avoid shadowing.
155 * termhooks.h (struct terminal): Likewise.
156 * xterm.c (xembed_send_message): Likewise.
157
158 * insdel.c (make_gap_smaller): Define only if
159 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
160
161 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
162 it.
163
164 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
165 so that we aren't warned about unused symbols.
166
167 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
168
169 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
170
171 * xfns.c (x_real_positions): Mark locals as initialized.
172
173 * xmenu.c (xmenu_show): Don't use uninitialized vars.
174
175 * xterm.c: Fix problems found by static analysis with other toolkits.
176 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
177 (x_dispatch_event): Declare static if USE_GTK, and
178 define if USE_GTK || USE_X_TOOLKIT.
179 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
180 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
181 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
182 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
183
184 * xmenu.c (menu_help_callback): Pointer type fixes.
185 Use const pointers when pointing at readonly data. Avoid pointer
186 signedness clashes.
187 (FALSE): Remove unused macro.
188 (update_frame_menubar): Remove unused decl.
189
190 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
191
192 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
193 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
194 (single_menu_item): Rename local to avoid shadowing.
195
196 * keyboard.c (make_lispy_event): Remove unused local var.
197
198 * frame.c, frame.h (x_get_resource_string): Bring this back, but
199 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
200
201 * bitmaps: Change bitmaps from unsigned char back to the X11
202 compatible char. Avoid the old compiler warnings about
203 out-of-range initializers by using, for example, '\xab' rather
204 than 0xab.
205
206 * xgselect.c (xgselect_initialize): Check vs interface
207 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
208
209 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
210
211 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
212 to read-only memory.
213
214 * fns.c (vector): Remove; this old hack is no longer needed.
215
216 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
217 Remove unused var.
218 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
219
220 * xrdb.c (x_load_resources): Omit unused local.
221
222 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
223 (x_window): Rename locals to avoid shadowing.
224 (USG): Use the kludged USG macro, to pacify gcc.
225
226 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
227 (x_term_init): Remove local to avoid shadowing.
228
229 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
230
231 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
232 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
233
234 2011-04-16 Eli Zaretskii <eliz@gnu.org>
235
236 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
237
238 Fix regex.c, syntax.c and friends for buffers > 2GB.
239 * syntax.h (struct gl_state_s): Declare character position members
240 EMACS_INT.
241
242 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
243
244 * textprop.c (verify_interval_modification, interval_of): Declare
245 arguments EMACS_INT.
246
247 * intervals.c (adjust_intervals_for_insertion): Declare arguments
248 EMACS_INT.
249
250 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
251
252 * indent.c (Fvertical_motion): Local variable it_start is now
253 EMACS_INT.
254
255 * regex.c (re_match, re_match_2, re_match_2_internal)
256 (bcmp_translate, regcomp, regexec, print_double_string)
257 (group_in_compile_stack, re_search, re_search_2, regex_compile)
258 (re_compile_pattern, re_exec): Declare arguments and local
259 variables `size_t' and `ssize_t' and return values `regoff_t', as
260 appropriate.
261 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
262 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
263 <compile_stack_type>: `size' and `avail' are now `size_t'.
264
265 * regex.h <regoff_t>: Use ssize_t, not int.
266 (re_search, re_search_2, re_match, re_match_2): Arguments that
267 specify buffer/string position and length are now ssize_t and
268 size_t. Return type is regoff_t.
269
270 2011-04-16 Ben Key <bkey76@gmail.com>
271
272 * nsfont.m: Fixed bugs in ns_get_family and
273 ns_descriptor_to_entity that were caused by using free to
274 deallocate memory blocks that were allocated by xmalloc (via
275 xstrdup). This caused Emacs to crash when compiled with
276 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
277 --enable-checking=xmallocoverrun). xfree is now used to
278 deallocate these memory blocks.
279
280 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
281
282 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
283
284 emacs_write: Accept and return EMACS_INT for sizes.
285 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
286 et seq.
287 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
288 Accept and return EMACS_INT.
289 (emacs_gnutls_write): Return the number of bytes written on
290 partial writes.
291 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
292 (emacs_read, emacs_write): Remove check for negative size, as the
293 Emacs source code has been audited now.
294 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
295 (emacs_read, emacs_write): Use it.
296 * process.c (send_process): Adjust to the new signatures of
297 emacs_write and emacs_gnutls_write. Do not attempt to store
298 a byte offset into an 'int'; it might overflow.
299 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
300
301 * sound.c: Don't assume sizes fit in 'int'.
302 (struct sound_device.period_size, alsa_period_size):
303 Return EMACS_INT, not int.
304 (struct sound_device.write, vox_write, alsa_write):
305 Accept EMACS_INT, not int.
306 (wav_play, au_play): Use EMACS_INT to store sizes and to
307 record read return values.
308
309 2011-04-15 Ben Key <bkey76@gmail.com>
310
311 * keyboard.c (Qundefined): Don't declare static since it is used
312 in nsfns.m.
313 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
314 static since they are used in nsfont.m.
315
316 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
317
318 * process.c (Qprocessp): Don't declare static.
319 * lisp.h (Qprocessp): Declare again.
320
321 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
322
323 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
324
325 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
326
327 Improve C-level modularity by making more things 'static'.
328
329 Don't publish debugger-only interfaces to other modules.
330 * lisp.h (safe_debug_print, debug_output_compilation_hack):
331 (verify_bytepos, count_markers): Move decls to the only modules
332 that need them.
333 * region-cache.h (pp_cache): Likewise.
334 * window.h (check_all_windows): Likewise.
335 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
336
337 * sysdep.c (croak): Now static, if
338 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
339 * syssignal.h (croak): Declare only if not static.
340
341 * alloc.c (refill_memory_reserve): Now static if
342 !defined REL_ALLOC || defined SYSTEM_MALLOC.
343 * lisp.h (refill_memory_reserve): Declare only if not static.
344
345 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
346 Define only if USE_LUCID.
347
348 * xrdb.c (x_customization_string, x_rm_string): Now static.
349
350 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
351 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
352
353 * xdisp.c (draw_row_with_mouse_face): Now static.
354 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
355
356 * window.h (check_all_windows): Mark externally visible.
357
358 * window.c (window_deletion_count): Now static.
359
360 * undo.c: Make symbols static if they're not exported.
361 (last_undo_buffer, last_boundary_position, pending_boundary):
362 Now static.
363
364 * textprop.c (interval_insert_behind_hooks): Now static.
365 (interval_insert_in_front_hooks): Likewise.
366
367 * term.c: Make symbols static if they're not exported.
368 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
369 (max_frame_lines, tty_set_terminal_modes):
370 (tty_reset_terminal_modes, tty_turn_off_highlight):
371 (get_tty_terminal): Now static.
372 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
373 * termhooks.h (term_mouse_moveto): Do not declare if
374 HAVE_WINDOW_SYSTEM.
375 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
376 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
377
378 * sysdep.c: Make symbols static if they're not exported.
379 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
380 Now static.
381 (sigprocmask_set, full_mask): Remove; unused.
382 (wait_debugging): Mark as visible.
383 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
384 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
385
386 * syntax.c (syntax_temp): Define only if !__GNUC__.
387
388 * sound.c (current_sound_device, current_sound): Now static.
389
390 * search.c (searchbufs, searchbuf_head): Now static.
391
392 * scroll.c (scroll_cost): Remove; unused.
393 * dispextern.h (scroll_cost): Remove decl.
394
395 * region-cache.h (pp_cache): Mark as externally visible.
396
397 * process.c: Make symbols static if they're not exported.
398 (process_tick, update_tick, create_process, chan_process):
399 (Vprocess_alist, proc_buffered_char, datagram_access):
400 (fd_callback_data, send_process_frame, process_sent_to): Now static.
401 (deactivate_process): Mark defn as static, as well as decl.
402 * lisp.h (create_process): Remove decl.
403 * process.h (chan_process, Vprocess_alist): Remove decls.
404
405 * print.c: Make symbols static if they're not exported.
406 (print_depth, new_backquote_output, being_printed, print_buffer):
407 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
408 (print_interval, print_number_index, initial_stderr_stream):
409 Now static.
410 * lisp.h (Fprinc): Remove decl.
411 (debug_output_compilation_hack): Mark as externally visible.
412
413 * sysdep.c (croak): Move decl from here to syssignal.h.
414 * syssignal.h (croak): Put it here, so the API can be checked when
415 'croak' is called from dissociate_if_controlling_tty.
416
417 * minibuf.c: Make symbols static if they're not exported.
418 (minibuf_save_list, choose_minibuf_frame): Now static.
419 * lisp.h (choose_minibuf_frame): Remove decl.
420
421 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
422
423 * lread.c: Make symbols static if they're not exported.
424 (read_objects, initial_obarray, oblookup_last_bucket_number):
425 Now static.
426 (make_symbol): Remove; unused.
427 * lisp.h (initial_obarray, make_symbol): Remove decls.
428
429 * keyboard.c: Make symbols static if they're not exported.
430 (single_kboard, recent_keys_index, total_keys, recent_keys):
431 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
432 (this_single_command_key_start, echoing, last_auto_save):
433 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
434 (command_loop, echo_now, keyboard_init_hook, help_char_p):
435 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
436 (Vlispy_mouse_stem, double_click_count):
437 Now static.
438 (force_auto_save_soon): Define only if SIGDANGER.
439 (ignore_mouse_drag_p): Now static if
440 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
441 (print_help): Remove; unused.
442 (stop_character, last_timer_event): Mark as externally visible.
443 * keyboard.h (ignore_mouse_drag_p): Declare only if
444 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
445 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
446 * lisp.h (echoing): Remove decl.
447 (force_auto_save_soon): Declare only if SIGDANGER.
448 * xdisp.c (redisplay_window): Simplify code, to make it more
449 obvious that ignore_mouse_drag_p is not accessed if !defined
450 USE_GTK && !defined HAVE_NS.
451
452 * intervals.c: Make symbols static if they're not exported.
453 (merge_properties_sticky, merge_interval_right, delete_interval):
454 Now static.
455 * intervals.h (merge_interval_right, delete_interval): Remove decls.
456
457 * insdel.c: Make symbols static if they're not exported.
458 However, leave prepare_to_modify_buffer alone. It's never
459 called from outside this function, but that appears to be a bug.
460 (combine_after_change_list, combine_after_change_buffer):
461 (adjust_after_replace, signal_before_change): Now static.
462 (adjust_after_replace_noundo): Remove; unused.
463 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
464 (signal_before_change): Remove decls.
465
466 * indent.c (val_compute_motion, val_vmotion): Now static.
467
468 * image.c: Make symbols static if they're not exported.
469 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
470 if USE_GTK.
471 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
472 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
473
474 * fringe.c (standard_bitmaps): Now static.
475 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
476
477 * frame.c: Make symbols static if they're not exported.
478 (x_report_frame_params, make_terminal_frame): Now static.
479 (get_frame_param): Now static, unless HAVE_NS.
480 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
481 (x_get_resource_string): Remove; not used.
482 * frame.h (make_terminal_frame, x_report_frame_params):
483 (x_get_resource_string); Remove decls.
484 (x_fullscreen_adjust): Declare only if WINDOWSNT.
485 * lisp.h (get_frame_param): Declare only if HAVE_NS.
486
487 * font.c, fontset.c: Make symbols static if they're not exported.
488 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
489 (FACE_SUITABLE_FOR_CHAR_P): Use it.
490 * font.c (font_close_object): Now static.
491 * font.h (font_close_object): Remove.
492 * fontset.c (FONTSET_OBJLIST): Remove.
493 (free_realized_fontset) #if-0 the body, which does nothing.
494 (face_suitable_for_char_p): #if-0, as it's never called.
495 * fontset.h (face_suitable_for_char_p): Remove decl.
496 * xfaces.c (face_at_string_position): Use
497 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
498 since 0 is always ASCII.
499
500 * fns.c (weak_hash_tables): Now static.
501
502 * fileio.c: Make symbols static if they're not exported.
503 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
504 (Vwrite_region_annotation_buffers): Now static.
505
506 * eval.c: Make symbols static if they're not exported.
507 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
508 * lisp.h (backtrace_list): Remove decl.
509
510 * emacs.c: Make symbols static if they're not exported.
511 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
512 (fatal_error_code, fatal_error_signal_hook, standard_args):
513 Now static.
514 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
515 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
516 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
517 * lisp.h (fatal_error_signal_hook): Remove decl.
518 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
519
520 * editfns.c: Move a (normally-unused) function to its only use.
521 * editfns.c, lisp.h (get_operating_system_release): Remove.
522 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
523 worth the hassle of breaking this out.
524
525 * xterm.c: Make symbols static if they're not exported.
526 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
527 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
528 (x_destroy_window, x_delete_display):
529 Now static.
530 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
531 (x_mouse_leave): Remove; unused.
532 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
533 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
534 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
535 Remove decls.
536 (x_mouse_leave): Declare only if WINDOWSNT.
537 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
538 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
539 USE_X_TOOLKIT.
540
541 * ftxfont.c: Make symbols static if they're not exported.
542 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
543 HAVE_FREETYPE.
544 * font.h (ftxfont_driver): Likewise.
545
546 * xfns.c: Make symbols static if they're not exported.
547 (x_last_font_name, x_display_info_for_name):
548 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
549 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
550 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
551 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
552 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
553 (last_show_tip_args): Now static.
554 (xic_defaut_fontset, xic_create_fontsetname): Define only if
555 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
556 (x_screen_planes): Remove; unused.
557 * dispextern.h (x_screen_planes): Remove decl.
558
559 * dispnew.c: Make symbols static if they're not exported.
560 * dispextern.h (redraw_garbaged_frames, scrolling):
561 (increment_row_positions): Remove.
562 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
563 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
564 Now static.
565 (redraw_garbaged_frames): Remove; unused.
566
567 * xfaces.c: Make symbols static if they're not exported.
568 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
569 Remove decls.
570 * xterm.h (defined_color): Remove decls.
571 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
572 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
573 (menu_face_changed_default, defined_color, free_realized_face):
574 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
575 (ascii_face_of_lisp_face): Remove; unused.
576
577 * xdisp.c: Make symbols static if they're not exported.
578 * dispextern.h (scratch_glyph_row, window_box_edges):
579 (glyph_to_pixel_coords, set_cursor_from_row):
580 (get_next_display_element, set_iterator_to_next):
581 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
582 (show_mouse_face): Remove decls
583 * frame.h (message_buf_print): Likewise.
584 * lisp.h (pop_message, set_message, check_point_in_composition):
585 Likewise.
586 * xterm.h (set_vertical_scroll_bar): Likewise.
587 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
588 (message_buf_print, scratch_glyph_row, displayed_buffer):
589 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
590 (get_next_display_element, show_mouse_face, window_box_edges):
591 (frame_to_window_pixel_xy, check_point_in_composition):
592 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
593 (glyph_to_pixel_coords): Remove; unused.
594
595 * dired.c (file_name_completion): Now static.
596
597 * dbusbind.c (xd_in_read_queued_messages): Now static.
598
599 * lisp.h (circular_list_error, FOREACH): Remove; unused.
600 * data.c (circular_list_error): Remove.
601
602 * commands.h (last_point_position, last_point_position_buffer):
603 (last_point_position_window): Remove decls.
604 * keyboard.c: Make these variables static.
605
606 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
607 decls.
608 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
609 (iso_code_class, detect_coding, code_convert_region): Now static.
610 (encode_coding_gap): Remove; unused.
611
612 * chartab.c (chartab_chars, chartab_bits): Now static.
613
614 * charset.h (charset_iso_8859_1): Remove decl.
615 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
616 Now static.
617
618 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
619 * ccl.c (Vccl_program_table): Now static.
620 (check_ccl_update): Remove; unused.
621
622 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
623 * category.h: ... from here.
624 * category.c (check_category_table, set_category_set): Now static.
625
626 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
627 * lisp.h: Remove these decls.
628
629 * buffer.c (buffer_count): Remove unused var.
630
631 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
632 so that it's not optimized away.
633 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
634 * dispextern.h (bidi_dump_cached_states): Remove, since it's
635 exported only to the debugger.
636
637 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
638 * atimer.h (run_all_atimers): Removed; not exported.
639
640 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
641 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
642 was inaccessible from Lisp.
643 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
644 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
645
646 alloc.c: Import and export fewer symbols, and remove unused items.
647 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
648 is defined.
649 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
650 it's not optimized away by whole-program optimization.
651 (message_enable_multibyte, free_misc): Remove.
652 (catchlist, handlerlist, mark_backtrace):
653 Declare only if BYTE_MARK_STACK.
654 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
655 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
656 (message_enable_multibyte): Remove decl.
657 (free_misc, interval_free_list, float_block, float_block_index):
658 (n_float_blocks, float_free_list, cons_block, cons_block_index):
659 (cons_free_list, last_marked_index):
660 Now static.
661 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
662 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
663 (mark_backtrace): Define only if BYTE_MARK_STACK.
664 * xdisp.c (message_enable_multibyte): Now static.
665
666 Declare Lisp_Object Q* variables to be 'static' if not exported.
667 This makes it easier for human readers (and static analyzers)
668 to see whether these variables are used from other modules.
669 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
670 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
671 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
672 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
673 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
674 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
675 * xmenu.c, xselect.c:
676 Declare Q* vars static if they are not used in other modules.
677 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
678 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
679 Remove decls of unexported vars.
680 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
681
682 * lisp.h (DEFINE_FUNC): Make sname 'static'.
683
684 Make Emacs functions such as Fatom 'static' by default.
685 This makes it easier for human readers (and static analyzers)
686 to see whether these functions can be called from other modules.
687 DEFUN now defines a static function. To make the function external
688 so that it can be used in other C modules, use the new macro DEFUE.
689 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
690 (Finit_image_library):
691 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
692 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
693 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
694 Remove decls, since these functions are now static.
695 (Funintern, Fget_internal_run_time): New decls, since these functions
696 were already external.
697
698 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
699 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
700 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
701 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
702 * keyboard.c, keymap.c, lread.c:
703 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
704 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
705 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
706 Mark functions with DEFUE instead of DEFUN,
707 if they are used in other modules.
708 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
709 decls for now-static functions.
710 * buffer.h (Fdelete_overlay): Remove decl.
711 * callproc.c (Fgetenv_internal): Mark as internal.
712 * composite.c (Fremove_list_of_text_properties): Remove decl.
713 (Fcomposition_get_gstring): New forward static decl.
714 * composite.h (Fcomposite_get_gstring): Remove decl.
715 * dired.c (Ffile_attributes): New forward static decl.
716 * doc.c (Fdocumntation_property): New forward static decl.
717 * eval.c (Ffetch_bytecode): New forward static decl.
718 (Funintern): Remove extern decl; now in .h file where it belongs.
719 * fileio.c (Fmake_symbolic_link): New forward static decl.
720 * image.c (Finit_image_library): New forward static decl.
721 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
722 * intervals.h (Fprevious_property_change):
723 (Fremove_list_of_text_properties): Remove decls.
724 * keyboard.c (Fthis_command_keys): Remove decl.
725 (Fcommand_execute): New forward static decl.
726 * keymap.c (Flookup_key): New forward static decl.
727 (Fcopy_keymap): Now static.
728 * keymap.h (Flookup_key): Remove decl.
729 * process.c (Fget_process): New forward static decl.
730 (Fprocess_datagram_address): Mark as internal.
731 * syntax.c (Fsyntax_table_p): New forward static decl.
732 (skip_chars): Remove duplicate decl.
733 * textprop.c (Fprevious_property_change): New forward static decl.
734 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
735 Now internal.
736 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
737 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
738
739 * editfns.c (Fformat): Remove unreachable code.
740
741 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
742
743 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
744 change. (Bug#8496)
745
746 2011-04-13 Eli Zaretskii <eliz@gnu.org>
747
748 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
749 when at ZV. (Bug#8487)
750
751 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
752
753 * charset.c (Fclear_charset_maps): Use xfree instead of free.
754 (Bug#8437)
755 * keyboard.c (parse_tool_bar_item): Likewise.
756 * sound.c (sound_cleanup, alsa_close): Likewise.
757 * termcap.c (tgetent): Likewise.
758 * xfns.c (x_default_font_parameter): Likewise.
759 * xsettings.c (read_and_apply_settings): Likewise.
760
761 * alloc.c (overrun_check_malloc, overrun_check_realloc)
762 (overrun_check_free): Protoize.
763
764 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
765
766 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
767 since callers should never pass a negative size.
768 Change the signature to match that of plain 'read' and 'write'; see
769 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
770 * lisp.h: Update prototypes of emacs_write and emacs_read.
771
772 2011-04-11 Eli Zaretskii <eliz@gnu.org>
773
774 * xdisp.c (redisplay_window): Don't try to determine the character
775 position of the scroll margin if the window start point w->startp
776 is outside the buffer's accessible region. (Bug#8468)
777
778 2011-04-10 Eli Zaretskii <eliz@gnu.org>
779
780 Fix write-region and its subroutines for buffers > 2GB.
781 * fileio.c (a_write, e_write): Modify declaration of arguments and
782 local variables to support buffers larger than 2GB.
783 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
784
785 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
786 argument, local variables, and return value.
787
788 * lisp.h: Update prototypes of emacs_write and emacs_read.
789
790 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
791
792 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
793
794 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
795
796 Fix more problems found by GCC 4.6.0's static checks.
797
798 * xdisp.c (vmessage): Use a better test for character truncation.
799
800 * charset.c (load_charset_map): <, not <=, for optimization,
801 and to avoid potential problems with integer overflow.
802 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
803 * casetab.c (set_identity, shuffle): Likewise.
804 * editfns.c (Fformat): Likewise.
805 * syntax.c (skip_chars): Likewise.
806
807 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
808 This also lets GCC 4.6.0 generate slightly better loop code.
809
810 * callint.c (Fcall_interactively): <, not <=, for optimization.
811 (Fcall_interactively): Count the number of arguments produced,
812 not the number of arguments given. This is simpler and lets GCC
813 4.6.0 generate slightly better code.
814
815 * ftfont.c: Distingish more carefully between FcChar8 and char.
816 The previous code passed unsigned char * to a functions like
817 strlen and xstrcasecmp that expect char *, which does not
818 conform to the C standard.
819 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
820 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
821 char * when the C standard requires it.
822
823 * keyboard.c (read_char): Remove unused var.
824
825 * eval.c: Port to Windows vsnprintf (Bug#8435).
826 Include <limits.h>.
827 (SIZE_MAX): Define if the headers do not.
828 (verror): Do not give up if vsnprintf returns a negative count.
829 Instead, grow the buffer. This ports to Windows vsnprintf, which
830 does not conform to C99. Problem reported by Eli Zaretskii.
831 Also, simplify the allocation scheme, by avoiding the need for
832 calling realloc, and removing the ALLOCATED variable.
833
834 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
835
836 Remove invocations of doprnt, as Emacs now uses vsnprintf.
837 But keep the doprint source code for now, as we might revamp it
838 and use it again (Bug#8435).
839 * lisp.h (doprnt): Remove.
840 * Makefile.in (base_obj): Remove doprnt.o.
841 * deps.mk (doprnt.o): Remove.
842
843 error: Print 32- and 64-bit integers portably (Bug#8435).
844 Without this change, on typical 64-bit hosts error ("...%d...", N)
845 was used to print both 32- and 64-bit integers N, which relied on
846 undefined behavior.
847 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
848 New macro.
849 * lisp.h (error, verror): Mark as printf-like functions.
850 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
851 Report overflow in size calculations when allocating printf buffer.
852 Do not truncate output string at its first null byte.
853 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
854 Truncate the output at a character boundary, since vsnprintf does not
855 do that.
856 * charset.c (check_iso_charset_parameter): Convert internal
857 character to string before calling 'error', since %c now has the
858 printf meaning.
859 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
860 overflow when computing char to be passed to 'error'. Do not
861 pass Lisp_Object to 'error'; pass the integer instead.
862 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
863 formatted with plain %d.
864
865 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
866
867 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
868
869 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
870
871 * xterm.c (x_catch_errors): Remove duplicate declaration.
872
873 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
874
875 * xdisp.c, lisp.h (message_nolog): Remove; unused.
876
877 2011-04-10 Jim Meyering <meyering@redhat.com>
878
879 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
880 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
881 return ssize_t not "int", and use size_t as the buffer length.
882 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
883 * gnutls.h: Update declarations.
884 * process.c (read_process_output): Use ssize_t, to match.
885 (send_process): Likewise.
886
887 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
888
889 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
890
891 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
892
893 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
894 unsigned char, to match FcChar8 type definition.
895
896 * xterm.c (handle_one_xevent):
897 * xmenu.c (create_and_show_popup_menu):
898 * xselect.c (x_decline_selection_request)
899 (x_reply_selection_request): Avoid type-punned deref of X events.
900
901 2011-04-09 Eli Zaretskii <eliz@gnu.org>
902
903 Fix some uses of `int' instead of EMACS_INT.
904 * search.c (string_match_1, fast_string_match)
905 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
906 (scan_buffer, find_next_newline_no_quit)
907 (find_before_next_newline, search_command, Freplace_match)
908 (Fmatch_data): Make some `int' variables be EMACS_INT.
909
910 * xdisp.c (display_count_lines): 3rd argument and return value now
911 EMACS_INT. All callers changed.
912 (pint2hrstr): Last argument is now EMACS_INT.
913
914 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
915 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
916 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
917 (decode_coding_utf_16, decode_coding_emacs_mule)
918 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
919 (decode_coding_ccl, decode_coding_charset)
920 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
921 (decode_coding_iso_2022, decode_coding_emacs_mule)
922 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
923 <char_offset, last_offset>: Declare EMACS_INT.
924 (encode_coding_utf_8, encode_coding_utf_16)
925 (encode_coding_emacs_mule, encode_invocation_designation)
926 (encode_designation_at_bol, encode_coding_iso_2022)
927 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
928 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
929 Declare EMACS_INT.
930 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
931 (encode_invocation_designation): Last argument P_NCHARS is now
932 EMACS_INT.
933 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
934 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
935
936 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
937 All users changed.
938
939 * ccl.c (Fccl_execute_on_string): Declare some variables
940 EMACS_INT.
941
942 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
943
944 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
945
946 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
947
948 * process.c (Fformat_network_address): Doc fix.
949
950 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
951
952 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
953
954 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
955
956 * keyboard.c (read_char): Call Lisp function help-form-show,
957 instead of using internal_with_output_to_temp_buffer.
958 (Qhelp_form_show): New var.
959 (syms_of_keyboard): Use DEFSYM macro.
960
961 * print.c (internal_with_output_to_temp_buffer): Function deleted.
962
963 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
964
965 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
966
967 * process.c (Flist_processes): Removed to Lisp.
968 (list_processes_1): Deleted.
969
970 2011-04-06 Eli Zaretskii <eliz@gnu.org>
971
972 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
973
974 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
975
976 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
977
978 Fix more problems found by GCC 4.6.0's static checks.
979
980 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
981
982 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
983
984 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
985
986 * xdisp.c (vmessage): Mark as a printf-like function.
987
988 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
989
990 * sound.c (sound_warning): Don't crash if arg contains a printf format.
991
992 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
993 printf-like functions.
994 (tiff_load): Add casts to remove these marks before passing them
995 to system-supplied API.
996
997 * eval.c (Fsignal): Remove excess argument to 'fatal'.
998
999 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1000 This avoids several warnings with gcc -Wstrict-overflow.
1001 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1002 directly, rather than having caller test rule sign. This avoids
1003 some unnecessary tests.
1004 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1005 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1006 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1007
1008 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1009 (xfont_open): Avoid unnecessary tests.
1010
1011 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1012
1013 * composite.h, composite.c (composition_gstring_put_cache):
1014 Use EMACS_INT, not int, for length.
1015
1016 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1017 breaking out part of COMPOSITION_DECODE_RULE.
1018 (COMPOSITION_DECODE_RULE): Use it.
1019 * composite.c (get_composition_id): Remove unused local vars,
1020 by using the new macro.
1021
1022 * textprop.c (set_text_properties_1): Change while to do-while,
1023 since the condition is always true at first.
1024
1025 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1026 (interval_deletion_adjustment): Return unsigned value.
1027 All uses changed.
1028
1029 * process.c (list_processes_1, create_pty, read_process_output):
1030 (exec_sentinel): Remove vars that were set but not used.
1031 (create_pty): Remove unnecessary "volatile"s.
1032 (Fnetwork_interface_info): Avoid possibility of int overflow.
1033 (read_process_output): Do adaptive read buffering even if carryover.
1034 (read_process_output): Simplify nbytes computation if buffered.
1035
1036 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1037
1038 * syntax.c (scan_words): Remove var that was set but not used.
1039 (update_syntax_table): Use unsigned instead of int.
1040
1041 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1042 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1043 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1044
1045 * print.c (print_error_message): Avoid int overflow.
1046
1047 * font.c (font_list_entities): Redo for clarity,
1048 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1049
1050 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1051 (font_score): Avoid potential overflow in diff calculation.
1052
1053 * fns.c (substring_both): Remove var that is set but not used.
1054 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1055
1056 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1057
1058 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1059 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1060 can always succeed if overflow has undefined behavior.
1061
1062 * search.c (boyer_moore, wordify): Remove vars set but not used.
1063 (wordify): Omit three unnecessary tests.
1064
1065 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1066 All callers changed. This avoids the need for an unused var.
1067
1068 * casefiddle.c (casify_region): Remove var that is set but not used.
1069
1070 * dired.c (file_name_completion): Remove var that is set but not used.
1071
1072 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1073
1074 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1075 (Finsert_file_contents): Remove unnecessary code checking fd.
1076
1077 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1078 Check for integer overflow on size calculations.
1079
1080 * buffer.c (Fprevious_overlay_change): Remove var that is set
1081 but not used.
1082
1083 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1084 Remove vars that are set but not used.
1085 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1086 (timer_check_2): Mark vars as initialized.
1087
1088 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1089
1090 * image.c (lookup_image): Remove var that is set but not used.
1091 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1092
1093 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1094 that are set but not used.
1095
1096 * xfns.c (make_invisible_cursor): Don't return garbage
1097 if XCreateBitmapFromData fails (Bug#8410).
1098
1099 * xselect.c (x_get_local_selection, x_handle_property_notify):
1100 Remove vars that are set but not used.
1101
1102 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1103 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1104
1105 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1106 Remove var that is set but not used.
1107 (scroll_bar_windows_size): Now size_t, not int.
1108 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1109 Check for overflow.
1110
1111 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1112 (map_tty_color) [!defined MSDOS]: Likewise.
1113
1114 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1115
1116 * coding.c: Remove vars that are set but not used.
1117 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1118 All callers changed.
1119 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1120 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1121 (decode_coding_charset): Remove vars that are set but not used.
1122
1123 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1124 that is set but not used.
1125
1126 * print.c (print_object): Remove var that is set but not used.
1127
1128 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1129 The gnulib version avoids calling malloc in the usual case,
1130 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1131 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1132 * filelock.c (current_lock_owner): Likewise.
1133 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1134 * sysdep.c: Include allocator.h, careadlinkat.h.
1135 (emacs_no_realloc_allocator): New static constant.
1136 (emacs_readlink): New function.
1137 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1138 ../lib/careadlinkat.h.
1139
1140 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1141
1142 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1143 first non-nil return value).
1144
1145 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1146
1147 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1148 if not defined (Bug#8403).
1149
1150 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1151
1152 * xdisp.c (display_count_lines): Remove parameter `start',
1153 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1154 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1155 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1156 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1157 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1158 and thereabouts. All callers changed.
1159 (get_per_char_metric): Remove parameter `f', unused since
1160 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1161
1162 2011-04-02 Jim Meyering <meyering@redhat.com>
1163
1164 do not dereference NULL upon failed strdup
1165 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1166 (ns_get_family): Likewise.
1167
1168 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1169
1170 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1171
1172 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1173
1174 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1175 later (Bug#8403).
1176
1177 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1178
1179 Add lexical binding.
1180
1181 * window.c (Ftemp_output_buffer_show): New fun.
1182 (Fsave_window_excursion):
1183 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1184
1185 * lread.c (lisp_file_lexically_bound_p): New function.
1186 (Fload): Bind Qlexical_binding.
1187 (readevalloop): Remove `evalfun' arg.
1188 Bind Qinternal_interpreter_environment.
1189 (Feval_buffer): Bind Qlexical_binding.
1190 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1191 Mark as dynamic.
1192 (syms_of_lread): Declare `lexical-binding'.
1193
1194 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1195
1196 * keyboard.c (eval_dyn): New fun.
1197 (menu_item_eval_property): Use it.
1198
1199 * image.c (parse_image_spec): Use Ffunctionp.
1200
1201 * fns.c (concat, mapcar1): Accept byte-code-functions.
1202
1203 * eval.c (Fsetq): Handle lexical vars.
1204 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1205 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1206 (FletX, Flet): Obey lexical binding.
1207 (Fcommandp): Handle closures.
1208 (Feval): New `lexical' arg.
1209 (eval_sub): New function extracted from Feval. Use it almost
1210 everywhere where Feval was used. Look up vars in lexical env.
1211 Handle closures.
1212 (Ffunctionp): Move from subr.el.
1213 (Ffuncall): Handle closures.
1214 (apply_lambda): Remove `eval_flags'.
1215 (funcall_lambda): Handle closures and new byte-code-functions.
1216 (Fspecial_variable_p): New function.
1217 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1218 but without exporting it to Lisp.
1219
1220 * doc.c (Fdocumentation, store_function_docstring):
1221 * data.c (Finteractive_form): Handle closures.
1222
1223 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1224 interactive spec.
1225
1226 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1227 byte-codes.
1228 (exec_byte_code): New function extracted from Fbyte_code to handle new
1229 calling convention for byte-code-functions. Add new byte-codes.
1230
1231 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1232
1233 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1234
1235 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1236
1237 * xdisp.c (redisplay_internal): Fix prototype.
1238
1239 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1240
1241 * xdisp.c (SCROLL_LIMIT): New macro.
1242 (try_scrolling): Use it when setting scroll_limit. Limit
1243 scrolling to 100 screen lines.
1244 (redisplay_window): Even when falling back on "recentering",
1245 position point in the window according to scroll-conservatively,
1246 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1247
1248 (try_scrolling): When point is above the window, allow searching
1249 as far as scroll_max, or one screenful, to compute vertical
1250 distance from PT to the scroll margin position. This prevents
1251 try_scrolling from unnecessarily failing when
1252 scroll-conservatively is set to a value slightly larger than the
1253 window height. Clean up the case of PT below the margin at bottom
1254 of window: scroll_max can no longer be INT_MAX. When aggressive
1255 scrolling is in use, don't let point enter the opposite scroll
1256 margin as result of the scroll.
1257 (syms_of_xdisp) <scroll-conservatively>: Document the
1258 threshold of 100 lines for never-recentering scrolling.
1259
1260 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1261
1262 * dispextern.h (move_it_by_lines):
1263 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1264 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1265 (message_log_check_duplicate): Remove parameters `prev_bol' and
1266 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1267 (redisplay_internal): Remove parameter `preserve_echo_area',
1268 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1269
1270 * indent.c (Fvertical_motion):
1271 * window.c (window_scroll_pixel_based, Frecenter):
1272 Don't pass `need_y_p' to `move_it_by_lines'.
1273
1274 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1275
1276 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1277 steal a few bits to be more compact.
1278 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1279 Remove unneeded casts.
1280
1281 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1282
1283 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1284
1285 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1286 binding" message (bug#7967).
1287
1288 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 Fix more problems found by GCC 4.6.0's static checks.
1291
1292 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1293 Remove unused local var.
1294
1295 * editfns.c (Fmessage_box): Remove unused local var.
1296
1297 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1298 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1299 Omit unused local vars.
1300 * window.c (shrink_windows): Omit unused local var.
1301 * menu.c (digest_single_submenu): Omit unused local var.
1302 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1303 Omit unused local var.
1304
1305 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1306 Don't assume string length fits in int.
1307 (keyremap_step, read_key_sequence): Use size_t for sizes.
1308 (read_key_sequence): Don't check last_real_key_start redundantly.
1309
1310 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1311 instead of alloca (Bug#8344).
1312
1313 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1314 (Fbacktrace_frame): Don't assume nframes fits in int.
1315
1316 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1317
1318 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1319 concerns.
1320
1321 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1322
1323 * cm.c (calccost): Turn while-do into do-while, for clarity.
1324
1325 * keyboard.c (syms_of_keyboard): Use the same style as later
1326 in this function when indexing through an array. This also
1327 works around GCC bug 48267.
1328
1329 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1330
1331 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1332
1333 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1334 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1335
1336 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1337 This avoids undefined behavior on integer overflow, and is a bit
1338 more convenient anyway since it is compared to a size_t variable.
1339
1340 Variadic C functions now count arguments with size_t, not int.
1341 This avoids an unnecessary limitation on 64-bit machines, which
1342 caused (substring ...) to crash on large vectors (Bug#8344).
1343 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1344 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1345 All variadic functions and their callers changed accordingly.
1346 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1347 * data.c (arith_driver, float_arith_driver): Likewise.
1348 * editfns.c (general_insert_function): Likewise.
1349 * eval.c (struct backtrace.nargs, interactive_p)
1350 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1351 (funcall_lambda, mark_backtrace): Likewise.
1352 * fns.c (concat): Likewise.
1353 * frame.c (x_set_frame_parameters): Likewise.
1354 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1355 0 if not found, not -1. All callers changed.
1356
1357 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1358 (stack_copy_size): Now size_t, not int.
1359 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1360
1361 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1362
1363 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1364 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1365 All callers changed.
1366
1367 * lisp.h (multibyte_char_to_unibyte):
1368 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1369 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1370 * character.h (CHAR_TO_BYTE8):
1371 * cmds.c (internal_self_insert):
1372 * editfns.c (general_insert_function):
1373 * keymap.c (push_key_description):
1374 * search.c (Freplace_match):
1375 * xdisp.c (message_dolog, set_message_1): All callers changed.
1376
1377 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1378
1379 * keyboard.c (safe_run_hook_funcall): New function.
1380 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1381 don't set the hook to nil, but remove the offending function instead.
1382 (Qcommand_hook_internal): Remove, unused.
1383 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1384 Vcommand_hook_internal.
1385
1386 * eval.c (enum run_hooks_condition): Remove.
1387 (funcall_nil, funcall_not): New functions.
1388 (run_hook_with_args): Call each function through a `funcall' argument.
1389 Remove `cond' argument, now redundant.
1390 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1391 (Frun_hook_with_args_until_failure): Adjust accordingly.
1392 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1393
1394 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * dispextern.h (string_buffer_position): Remove declaration.
1397
1398 * print.c (strout): Remove parameter `multibyte', unused since
1399 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1400
1401 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1402 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1403 All callers changed.
1404
1405 * w32.c (_wsa_errlist): Use braces for struct initializers.
1406
1407 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1408 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1409 All callers changed.
1410 (string_buffer_position): Likewise. Also, make static (it's never
1411 used outside xdisp.c).
1412 (cursor_row_p): Remove parameter `w', unused since
1413 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1414 (decode_mode_spec): Remove parameter `precision', introduced during
1415 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1416 All callers changed.
1417
1418 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1419
1420 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1421
1422 2011-03-27 Anders Lindgren <andlind@gmail.com>
1423
1424 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1425 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1426 (ns_update_auto_hide_menu_bar): New functions.
1427 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1428 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1429 ns_constrain_all_frames.
1430 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1431 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1432
1433 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1434
1435 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1436
1437 2011-03-27 Glenn Morris <rgm@gnu.org>
1438
1439 * syssignal.h: Replace RETSIGTYPE with void.
1440 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1441 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1442 Replace SIGTYPE with void everywhere.
1443 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1444 * s/template.h (SIGTYPE): Remove commented out definition.
1445
1446 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1447
1448 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1449 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1450
1451 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1452
1453 * w32.c (read_unc_volume): Use parameter `henum', instead of
1454 global variable `wget_enum_handle'.
1455
1456 * keymap.c (describe_vector): Remove parameters `indices' and
1457 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1458 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1459
1460 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1461
1462 * keyboard.c (timer_check): Remove parameter `do_it_now',
1463 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1464 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1465 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1466
1467 * keyboard.c (read_char):
1468 * w32menu.c (w32_menu_display_help):
1469 * xmenu.c (show_help_event, menu_help_callback):
1470 Adjust calls to `show_help_echo'.
1471
1472 * gtkutil.c (xg_maybe_add_timer):
1473 * keyboard.c (readable_events):
1474 * process.c (wait_reading_process_output):
1475 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1476
1477 * insdel.c (adjust_markers_gap_motion):
1478 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1479 (gap_left, gap_right): Don't call it.
1480
1481 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1482
1483 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1484 incurred during fontification.
1485
1486 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1487
1488 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1489 (DEFVAR_PER_BUFFER): Don't pass it.
1490
1491 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1492 (scrolling_window): Don't pass it.
1493
1494 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1495
1496 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1497
1498 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1499 and `suffix'.
1500 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1501 of variables specific to SELinux and computation of `encoded_absname'.
1502
1503 * image.c (XPutPixel): Remove unused variable `height'.
1504
1505 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1506
1507 * unexw32.c (get_section_info): Remove unused variable `section'.
1508
1509 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1510 (system_process_attributes): Remove unused variable `sess'.
1511 (sys_read): Remove unused variable `err'.
1512
1513 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1514 (w32_wnd_proc): Remove unused variable `isdead'.
1515 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1516 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1517 (x_create_tip_frame): Remove unused variable `tem'.
1518
1519 * w32inevt.c (w32_console_read_socket):
1520 Remove unused variable `no_events'.
1521
1522 * w32term.c (x_draw_composite_glyph_string_foreground):
1523 Remove unused variable `width'.
1524
1525 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1526
1527 * w32term.c (x_set_glyph_string_clipping):
1528 Don't pass uninitialized region to CombineRgn.
1529
1530 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1531
1532 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1533 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1534 (Fx_close_connection): Remove unused variable `i'.
1535
1536 * w32font.c (w32font_draw): Return number of glyphs.
1537 (w32font_open_internal): Remove unused variable `i'.
1538 (w32font_driver): Add missing initializer.
1539
1540 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1541 (fill_in_menu): Remove unused variable `items_added'.
1542
1543 * w32term.c (last_mouse_press_frame): Remove static global variable.
1544 (w32_clip_to_row): Remove unused variable `f'.
1545 (x_delete_terminal): Remove unused variable `i'.
1546
1547 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1548 (NOTHING): Remove unused static global variable.
1549 (uniscribe_check_otf): Remove unused variable `table'.
1550 (uniscribe_font_driver): Add missing initializers.
1551
1552 2011-03-23 Julien Danjou <julien@danjou.info>
1553
1554 * term.c (Fsuspend_tty, Fresume_tty):
1555 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1556 * window.c (temp_output_buffer_show):
1557 * insdel.c (signal_before_change):
1558 * frame.c (Fhandle_switch_frame):
1559 * fileio.c (Fdo_auto_save):
1560 * emacs.c (Fkill_emacs):
1561 * editfns.c (save_excursion_restore):
1562 * cmds.c (internal_self_insert):
1563 * callint.c (Fcall_interactively):
1564 * buffer.c (Fkill_all_local_variables):
1565 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1566 Use Frun_hooks.
1567 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1568 unconditionnaly since it does the check itself.
1569
1570 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1571
1572 Fix more problems found by GCC 4.5.2's static checks.
1573
1574 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1575 the first time through the loop, since we know p0 < p1 then.
1576 This also avoids a gcc -Wstrict-overflow warning.
1577
1578 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1579 leading to a memory leak, possible in functions like
1580 load_charset_map_from_file that can allocate an unbounded number
1581 of objects (Bug#8318).
1582
1583 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1584 that could (at least in theory) be that large.
1585
1586 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1587 This is less likely to overflow, and avoids undefined behavior if
1588 overflow does occur. All callers changed. Use strtoul to scan
1589 for the unsigned long integer.
1590 (pint2hrstr): Simplify and tune code slightly.
1591 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1592
1593 * scroll.c (do_scrolling): Work around GCC bug 48228.
1594 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1595
1596 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1597 This also avoids a warning with gcc -Wstrict-overflow.
1598 (validate_x_resource_name): Simplify count usage.
1599 This also avoids a warning with gcc -Wstrict-overflow.
1600
1601 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1602 fail (Bug#8306).
1603
1604 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1605
1606 * process.c (Fmake_network_process): Use socklen_t, not int,
1607 where POSIX says socklen_t is required in portable programs.
1608 This fixes a porting bug on hosts like 64-bit HP-UX, where
1609 socklen_t is wider than int (Bug#8277).
1610 (Fmake_network_process, server_accept_connection):
1611 (wait_reading_process_output, read_process_output):
1612 Likewise.
1613
1614 * process.c: Rename or move locals to avoid shadowing.
1615 (list_processes_1, Fmake_network_process):
1616 (read_process_output_error_handler, exec_sentinel_error_handler):
1617 Rename or move locals.
1618 (Fmake_network_process): Define label "retry_connect" only if needed.
1619 (Fnetwork_interface_info): Fix pointer signedness.
1620 (process_send_signal): Add cast to avoid pointer signedness problem.
1621 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1622 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1623
1624 Make tparam.h and terminfo.c consistent.
1625 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1626 Include tparam.h instead, since it declares them.
1627 * cm.h (PC): Remove extern decl; tparam.h now does this.
1628 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1629 * terminfo.c: Include tparam.h, to check interfaces.
1630 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1631 (tparam): Adjust signature to match interface in tparam.h;
1632 this removes some undefined behavior. Check that outstring and len
1633 are zero, which they always are with Emacs.
1634 * tparam.h (PC, BC, UP): New extern decls.
1635
1636 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1637 (xftfont_open): Rename locals to avoid shadowing.
1638
1639 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1640 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1641 (OTF_TAG_SYM): Omit macro if not needed.
1642 (ftfont_list): Remove unused local.
1643 (get_adstyle_property, ftfont_pattern_entity):
1644 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1645 Rename locals to avoid shadowing.
1646
1647 * xfont.c (xfont_list_family): Mark var as initialized.
1648
1649 * xml.c (make_dom): Now static.
1650
1651 * composite.c (composition_compute_stop_pos): Rename local to
1652 avoid shadowing.
1653 (composition_reseat_it): Remove unused locals.
1654 (find_automatic_composition, composition_adjust_point): Likewise.
1655 (composition_update_it): Mark var as initialized.
1656 (find_automatic_composition): Mark vars as initialized,
1657 with a FIXME (Bug#8290).
1658
1659 character.h: Rename locals to avoid shadowing.
1660 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1661 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1662 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1663 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1664 to avoid shadowing.
1665
1666 * textprop.c (property_change_between_p): Remove; unused.
1667
1668 * intervals.c (interval_start_pos): Now static.
1669
1670 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1671
1672 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1673 Rename locals to avoid shadowing.
1674
1675 * sound.c (wav_play, au_play, Fplay_sound_internal):
1676 Fix pointer signedness.
1677 (alsa_choose_format): Remove unused local var.
1678 (wav_play): Initialize a variable to 0, to prevent undefined
1679 behavior (Bug#8278).
1680
1681 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1682
1683 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1684
1685 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1686 clobbering (Bug#8298).
1687 * sysdep.c (sys_subshell): Likewise.
1688 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1689
1690 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1691 This should get cleaned up, so that child_setup has the
1692 same signature on all platforms.
1693
1694 * callproc.c (call_process_cleanup): Now static.
1695 (relocate_fd): Rename locals to avoid shadowing.
1696
1697 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1698
1699 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1700 not to be necessary, and produces flickering.
1701
1702 2011-03-20 Glenn Morris <rgm@gnu.org>
1703
1704 * config.in: Remove file.
1705
1706 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1707
1708 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1709 are now in src/globals.h.
1710 (syms_of_minibuf): Remove spurious & from previous change.
1711
1712 2011-03-20 Leo <sdl.web@gmail.com>
1713
1714 * minibuf.c (completing-read-function): New variable.
1715 (completing-read-default): Rename from completing-read.
1716 (completing-read): Call completing-read-function.
1717
1718 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1719
1720 * xfaces.c (Fx_load_color_file):
1721 Read color file from absolute filename (bug#8250).
1722
1723 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1724
1725 * makefile.w32-in: Update dependencies.
1726
1727 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1728
1729 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1730
1731 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1732
1733 Fix more problems found by GCC 4.5.2's static checks.
1734
1735 * process.c (make_serial_process_unwind, send_process_trap):
1736 (sigchld_handler): Now static.
1737
1738 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1739 That way, the code declares only the vars that it needs.
1740 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1741 * s/cygwin.h (PTY_ITERATION): Likewise.
1742 * s/darwin.h (PTY_ITERATION): Likewise.
1743 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1744
1745 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1746 * process.c (allocate_pty): Don't declare stb unless it's needed.
1747
1748 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1749 (CONSTANTLIM): Remove; unused.
1750 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1751 Define only if needed.
1752
1753 * unexelf.c (unexec): Name an expression,
1754 to avoid gcc -Wbad-function-cast warning.
1755 Use a different way to cause a compilation error if anyone uses
1756 n rather than nn, a way that does not involve shadowing.
1757 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1758
1759 * deps.mk (unexalpha.o): Remove; unused.
1760
1761 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1762 * unexec.h: New file.
1763 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1764 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1765 Depend on unexec.h.
1766 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1767 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1768 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1769 Change as necessary to match prototype in unexec.h.
1770
1771 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1772 shadowing.
1773 (back_comment, skip_chars): Mark vars as initialized.
1774
1775 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1776 Rename locals to avoid shadowing.
1777
1778 * lread.c (read1): Rewrite so as not to use empty "else".
1779 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1780
1781 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1782
1783 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1784 warning when compiling print.c.
1785
1786 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1787 instead of using an uninitialized var.
1788 (font_sort_entities): Mark var as initialized.
1789
1790 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1791
1792 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1793 pointers to constants.
1794 (font_parse_fcname): Remove unused vars.
1795 (font_delete_unmatched): Now static.
1796 (font_get_spec): Remove; unused.
1797 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1798 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1799 Rename or move locals to avoid shadowing.
1800
1801 * fns.c (require_nesting_list, require_unwind): Now static.
1802 (Ffillarray): Rename locals to avoid shadowing.
1803
1804 * floatfns.c (domain_error2): Define only if needed.
1805 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1806
1807 * alloc.c (mark_backtrace): Move decl from here ...
1808 * lisp.h: ... to here, so that it can be checked.
1809
1810 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1811 (Fdefvar): Rewrite so as not to use empty "else".
1812 (lisp_indirect_variable): Name an expression,
1813 to avoid gcc -Wbad-function-cast warning.
1814 (Fdefvar): Rename locals to avoid shadowing.
1815
1816 * callint.c (quotify_arg, quotify_args): Now static.
1817 (Fcall_interactively): Rename locals to avoid shadowing.
1818 Use const pointer when appropriate.
1819
1820 * lisp.h (get_system_name, get_operating_system_release):
1821 Move decls here, to check interfaces.
1822 * process.c (get_operating_system_release): Move decl to lisp.h.
1823 * xrdb.c (get_system_name): Likewise.
1824 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1825 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1826 some of which prompt warnings from gcc -Wbad-function-cast.
1827 (Fformat_time_string, Fencode_time, Finsert_char):
1828 (Ftranslate_region_internal, Fformat):
1829 Rename or remove local vars to avoid shadowing.
1830 (Ftranslate_region_internal): Mark var as initialized.
1831
1832 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1833 avoid shadowing.
1834
1835 * lisp.h (eassert): Check that the argument compiles, even if
1836 ENABLE_CHECKING is not defined.
1837
1838 * data.c (Findirect_variable): Name an expression, to avoid
1839 gcc -Wbad-function-cast warning.
1840 (default_value, arithcompare, arith_driver, arith_error): Now static.
1841 (store_symval_forwarding): Rename local to avoid shadowing.
1842 (Fmake_variable_buffer_local, Fmake_local_variable):
1843 Mark variables as initialized.
1844 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1845
1846 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1847 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1848 Rename locals to avoid shadowing.
1849 (mark_stack): Move local variables into the #ifdef region where
1850 they're used.
1851 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1852 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1853 needed otherwise.
1854 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1855 (GC_STRING_CHARS): Remove; not used.
1856 (Fmemory_limit): Cast sbrk's returned value to char *.
1857
1858 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1859 avoids undefined behavior in theory.
1860
1861 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1862
1863 Use functions, not macros, for up- and down-casing (Bug#8254).
1864 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1865 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1866 to use the following functions instead of these macros.
1867 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1868 EMACS_INT, since callers assume the returned value fits in int.
1869 (upcase1): Likewise, for UPCASE_TABLE.
1870 (uppercasep, lowercasep, upcase): New static inline functions.
1871 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1872 the race-condition problem in the old DOWNCASE.
1873
1874 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1875 Rename locals to avoid shadowing.
1876 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1877 (regex_compile, re_search_2, re_match_2_internal):
1878 Remove unused local vars.
1879 (FREE_VAR): Rewrite so as not to use empty "else",
1880 which gcc can warn about.
1881 (regex_compile, re_match_2_internal): Mark locals as initialized.
1882 (RETALLOC_IF): Define only if needed.
1883 (WORDCHAR_P): Likewise. This one is never needed, but is used
1884 only in a comment talking about a compiler bug, so put inside
1885 the #if 0 of that comment.
1886 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1887 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1888 Remove; unused.
1889
1890 * search.c (boyer_moore): Rename locals to avoid shadowing.
1891 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1892 (PREV_CHAR_BOUNDARY): Likewise.
1893
1894 * search.c (simple_search): Remove unused var.
1895
1896 * dired.c (compile_pattern): Move decl from here ...
1897 * lisp.h: ... to here, so that it can be checked.
1898 (struct re_registers): New forward decl.
1899
1900 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1901
1902 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1903 All uses changed.
1904 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1905 Rename locals to avoid shadowing.
1906 (Fvertical_motion): Mark locals as initialized.
1907
1908 * casefiddle.c (casify_object, casify_region): Now static.
1909 (casify_region): Mark local as initialized.
1910
1911 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1912
1913 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1914 New macros, so that the caller can use some names other than
1915 gcpro1, gcpro2, etc.
1916 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1917 of the new macros.
1918 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1919 argument, for consistency with GCPRO2_VAR, etc: it is now the
1920 prefix of the variable, not the variable itself. All uses
1921 changed.
1922 * dired.c (directory_files_internal, file_name_completion):
1923 Rename locals to avoid shadowing.
1924
1925 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1926 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1927 dired.c's scmp function, had undefined behavior.
1928 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1929 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1930 * buffer.h: ... to here, because these macros use current_buffer,
1931 and the new implementation with inline functions needs to have
1932 current_buffer in scope now, rather than later when the macros
1933 are used.
1934 (downcase, upcase1): New static inline functions.
1935 (DOWNCASE, UPCASE1): Reimplement using these functions.
1936 This avoids undefined behavior in expressions like
1937 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1938 from race conditions in accessing the global variables
1939 case_temp1 and case_temp2.
1940 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1941 * lisp.h (case_temp1, case_temp2): Remove their decls.
1942 * character.h (ASCII_CHAR_P): Move from here ...
1943 * lisp.h: ... to here, so that the inline functions mentioned
1944 above can use them.
1945
1946 * dired.c (directory_files_internal_unwind): Now static.
1947
1948 * fileio.c (file_name_as_directory, directory_file_name):
1949 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1950 Now static.
1951 (file_name_as_directory): Use const pointers when appropriate.
1952 (Fexpand_file_name): Likewise. In particular, newdir might
1953 point at constant storage, so make it a const pointer.
1954 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1955 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1956 signedness issues.
1957 (Fset_file_times, Finsert_file_contents, auto_save_error):
1958 Rename locals to avoid shadowing.
1959
1960 * minibuf.c (choose_minibuf_frame_1): Now static.
1961 (Ftry_completion, Fall_completions): Rename or remove locals
1962 to avoid shadowing.
1963
1964 * marker.c (bytepos_to_charpos): Remove; unused.
1965
1966 * lisp.h (verify_bytepos, count_markers): New decls,
1967 so that gcc does not warn that these functions aren't declared.
1968
1969 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1970 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1971 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1972 (copy_text): Remove unused local var.
1973
1974 * filelock.c (within_one_second): Now static.
1975 (lock_file_1): Rename local to avoid shadowing.
1976
1977 * buffer.c (fix_overlays_before): Mark locals as initialized.
1978 (fix_start_end_in_overlays): Likewise. This function should be
1979 simplified by using pointers-to-pointers, but that's a different
1980 matter.
1981 (switch_to_buffer_1): Now static.
1982 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1983 (report_overlay_modification): Rename locals to avoid shadowing.
1984
1985 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1986 Fix pointer signedness issue.
1987 (sys_subshell): Mark local as volatile if checking for lint,
1988 to suppress a gcc -Wclobbered warning that does not seem to be right.
1989 (MAXPATHLEN): Define only if needed.
1990
1991 * process.c (serial_open, serial_configure): Move decls from here ...
1992 * systty.h: ... to here, so that they can be checked.
1993
1994 * fns.c (get_random, seed_random): Move extern decls from here ...
1995 * lisp.h: ... to here, so that they can be checked.
1996
1997 * sysdep.c (reset_io): Now static.
1998 (wait_for_termination_signal): Remove; unused.
1999
2000 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2001 (copy_keymap_item, append_key, push_text_char_description):
2002 Now static.
2003 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2004 (DENSE_TABLE_SIZE): Remove; unused.
2005 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2006 (describe_map_tree):
2007 Rename locals to avoid shadowing.
2008
2009 * keyboard.c: Declare functions static if they are not used elsewhere.
2010 (echo_char, echo_dash, cmd_error, top_level_2):
2011 (poll_for_input, handle_async_input): Now static.
2012 (read_char, kbd_buffer_get_event, make_lispy_position):
2013 (make_lispy_event, make_lispy_movement, apply_modifiers):
2014 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2015 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2016 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2017 (read_key_sequence, read_char): Mark locals as initialized.
2018 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2019
2020 * keyboard.h (make_ctrl_char): New decl.
2021 (mark_kboards): Move decl here ...
2022 * alloc.c (mark_kboards): ... from here.
2023
2024 * lisp.h (force_auto_save_soon): New decl.
2025
2026 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2027 (DEFINE_DUMMY_FUNCTION): New macro.
2028 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2029 Use it.
2030 (main): Add casts to avoid warnings
2031 if GCC considers string literals to be constants.
2032
2033 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2034
2035 * dbusbind.c: Pointer signedness fixes.
2036 (xd_signature, xd_append_arg, xd_initialize):
2037 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2038 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2039 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2040 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2041
2042 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2043 if GCC considers string literals to be constants.
2044 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2045
2046 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2047
2048 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2049 (print_preprocess, print_object): New macro to fix last change.
2050
2051 * print.c (print_preprocess): Don't forget font objects.
2052
2053 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2054
2055 * emacs.c (USAGE3): Doc fixes.
2056
2057 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2058
2059 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2060 structure.
2061
2062 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2063
2064 * lisp.h (VWindow_system, Qfile_name_history):
2065 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2066 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2067 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2068
2069 * w32select.c: Don't #include "keyboard.h".
2070 (run_protected): Add extern declaration for waiting_for_input.
2071
2072 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2073 * w32console.c (detect_input_pending, read_input_pending)
2074 (encode_terminal_code):
2075 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2076 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2077 (w32_system_caret_y, Qfile_name_history):
2078 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2079 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2080 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2081 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2082 * w32proc.c (Qlocal, report_file_error):
2083 * w32term.c (Vwindow_system, updating_frame):
2084 * w32uniscribe.c (initialized, uniscribe_font_driver):
2085 Remove unneeded extern declarations.
2086
2087 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2088
2089 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2090
2091 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2092
2093 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2094 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2095 These macros can no longer be used for assignment.
2096
2097 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2098 Assign struct members directly, instead of using BUF_BEGV etc.
2099 (record_buffer_markers, fetch_buffer_markers): New functions for
2100 recording and fetching special buffer markers.
2101 (set_buffer_internal_1, set_buffer_temp): Use them.
2102
2103 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2104
2105 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2106
2107 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2108 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2109
2110 * xdisp.c (hscroll_window_tree):
2111 (reconsider_clip_changes): Use PT instead of BUF_PT.
2112
2113 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2114
2115 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2116 $(EMACS_ROOT)/lib/intprops.h.
2117
2118 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 Fix more problems found by GCC 4.5.2's static checks.
2121
2122 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2123 to unsigned char * to avoid compiler diagnostic.
2124 (xg_free_frame_widgets): Make it clear that a local variable is
2125 needed only if USE_GTK_TOOLTIP.
2126 (gdk_window_get_screen): Make it clear that this macro is needed
2127 only if USE_GTK_TOOLTIP.
2128 (int_gtk_range_get_value): New function, which avoids a diagnostic
2129 from gcc -Wbad-function-cast.
2130 (xg_set_toolkit_scroll_bar_thumb): Use it.
2131 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2132 diagnostic from gcc -Wbad-function-cast.
2133 (get_utf8_string, xg_get_file_with_chooser):
2134 Rename locals to avoid shadowing.
2135 (create_dialog): Move locals to avoid shadowing.
2136
2137 * xgselect.c (xg_select): Remove unused var.
2138
2139 * image.c (four_corners_best): Mark locals as initialized.
2140 (gif_load): Initialize transparent_p to zero (Bug#8238).
2141 Mark another local as initialized.
2142 (my_png_error, my_error_exit): Mark with NO_RETURN.
2143
2144 * image.c (clear_image_cache): Now static.
2145 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2146 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2147 (x_edge_detection): Remove unnecessary cast that
2148 gcc -Wbad-function-cast diagnoses.
2149 (gif_load): Fix pointer signedness.
2150 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2151 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2152
2153 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2154
2155 Improve quality of tests for time stamp overflow.
2156 For example, without this patch (encode-time 0 0 0 1 1
2157 1152921504606846976) returns the obviously-bogus value (-948597
2158 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2159 reports time overflow. See
2160 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2161 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2162 * editfns.c: Include limits.h and intprops.h.
2163 (TIME_T_MIN, TIME_T_MAX): New macros.
2164 (time_overflow): Move earlier, to before first use.
2165 (hi_time, lo_time): New functions, for an accurate test for
2166 out-of-range times.
2167 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2168 (Fget_internal_run_time): Don't assume time_t fits in int.
2169 (make_time): Use list2 instead of Fcons twice.
2170 (Fdecode_time): More accurate test for out-of-range times.
2171 (check_tm_member): New function.
2172 (Fencode_time): Use it, to test for out-of-range times.
2173 (lisp_time_argument): Don't rely on undefined left-shift and
2174 right-shift behavior when checking for time stamp overflow.
2175
2176 * editfns.c (time_overflow): New function, refactoring common code.
2177 (Fformat_time_string, Fdecode_time, Fencode_time):
2178 (Fcurrent_time_string): Use it.
2179
2180 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2181 * dired.c (make_time): Move to ...
2182 * editfns.c (make_time): ... here.
2183 * systime.h: Note the move.
2184
2185 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2186
2187 * fringe.c (update_window_fringes): Remove unused variables.
2188
2189 * unexmacosx.c (copy_data_segment): Also copy __got section.
2190 (Bug#8223)
2191
2192 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2193
2194 * termcap.c [MSDOS]: Include "msdos.h".
2195 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2196 Constify `char *' arguments and their references according to
2197 prototypes in tparam.h.
2198
2199 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2200
2201 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2202 Adapt all references accordingly.
2203
2204 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2205
2206 2011-03-11 Tom Tromey <tromey@redhat.com>
2207
2208 * buffer.c (syms_of_buffer): Remove obsolete comment.
2209
2210 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2211
2212 * termhooks.h (encode_terminal_code): Declare prototype.
2213
2214 * msdos.c (encode_terminal_code): Don't declare prototype.
2215
2216 * term.c (encode_terminal_code): Now external again, used by
2217 w32console.c and msdos.c.
2218
2219 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2220 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2221
2222 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2223
2224 Fix some minor problems found by GCC 4.5.2's static checks.
2225
2226 * fringe.c (update_window_fringes): Mark locals as initialized
2227 (Bug#8227).
2228 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2229
2230 * alloc.c (mark_fringe_data): Move decl from here ...
2231 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2232 to check its interface.
2233 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2234
2235 * fontset.c (free_realized_fontset): Now static.
2236 (Fset_fontset_font): Rename local to avoid shadowing.
2237 (fontset_font): Mark local as initialized.
2238 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2239
2240 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2241
2242 * xselect.c (x_disown_buffer_selections): Remove; not used.
2243 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2244 (x_own_selection, Fx_disown_selection_internal): Rename locals
2245 to avoid shadowing.
2246 (x_handle_dnd_message): Remove local to avoid shadowing.
2247
2248 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2249 so that the caller can use some name other than gcpro1.
2250 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2251 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2252 (Fx_backspace_delete_keys_p):
2253 Use them to avoid shadowing, and rename vars to avoid shadowing.
2254 (x_decode_color, x_set_name, x_window): Now static.
2255 (Fx_create_frame): Add braces to silence GCC warning.
2256 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2257 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2258 Remove unused locals.
2259 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2260 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2261 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2262 macros.
2263
2264 * xterm.h (x_mouse_leave): New decl.
2265
2266 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2267 Remove unused functions.
2268 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2269 (x_calc_absolute_position): Now static.
2270 (XTread_socket): Don't define label "out" unless it's used.
2271 Don't declare local "event" unless it's used.
2272 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2273 unless they are used.
2274 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2275 (x_fatal_error_signal): Remove; not used.
2276 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2277 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2278 (x_error_catcher, x_connection_closed, x_error_handler):
2279 (x_error_quitter, xembed_send_message, x_iconify_frame):
2280 (my_log_handler): Rename locals to avoid shadowing.
2281 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2282 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2283
2284 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2285 Rename or move locals to avoid shadowing.
2286 (tty_defined_color, merge_face_heights): Now static.
2287 (free_realized_faces_for_fontset): Remove; not used.
2288 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2289 does not deduce is never used uninitialized.
2290 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2291 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2292
2293 * terminal.c (store_terminal_param): Now static.
2294
2295 * xmenu.c (menu_highlight_callback): Now static.
2296 (set_frame_menubar): Remove unused local.
2297 (xmenu_show): Rename parameter to avoid shadowing.
2298 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2299 since they might point to immutable storage.
2300 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2301 since it's unused otherwise.
2302
2303 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2304 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2305 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2306 avoids a gcc -Wuninitialized diagnostic.
2307 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2308 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2309 does not deduce are never used uninitialized.
2310
2311 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2312
2313 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2314 * window.c (window_loop, size_window):
2315 (run_window_configuration_change_hook, enlarge_window): Likewise.
2316
2317 * window.c (display_buffer): Now static.
2318 (size_window): Mark variables that gcc -Wuninitialized
2319 does not deduce are never used uninitialized.
2320 * window.h (check_all_windows): New decl, to forestall
2321 gcc -Wmissing-prototypes diagnostic.
2322 * dispextern.h (bidi_dump_cached_states): Likewise.
2323
2324 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2325 shadowing.
2326 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2327 Include <limits.h>.
2328 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2329 and to avoid gcc -Wuninitialized warning.
2330 (load_charset_map): Mark variables that gcc -Wuninitialized
2331 does not deduce are never used uninitialized.
2332 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2333
2334 * coding.c (coding_set_source, coding_set_destination):
2335 Use "else { /* comment */ }" rather than "else /* comment */;"
2336 for clarity, and to avoid gcc -Wempty-body warning.
2337 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2338 a block, when the outer 'i' will do.
2339 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2340 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2341 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2342 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2343 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2344 Rename locals to avoid shadowing.
2345 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2346 * coding.c (emacs_mule_char, encode_invocation_designation):
2347 Now static, since they're not used elsewhere.
2348 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2349 (decode_coding_object, encode_coding_object, detect_coding_system):
2350 (decode_coding_emacs_mule): Mark variables that gcc
2351 -Wuninitialized does not deduce are never used uninitialized.
2352 (detect_coding_iso_2022): Initialize a local variable that might
2353 be used uninitialized. Leave a FIXME because it's not clear that
2354 this initialization is needed. (Bug#8211)
2355 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2356 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2357 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2358 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2359 Remove unused macros.
2360
2361 * category.c (hash_get_category_set): Remove unused local var.
2362 (copy_category_table): Now static, since it's not used elsewhere.
2363 * character.c (string_count_byte8): Likewise.
2364
2365 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2366 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2367
2368 * chartab.c (copy_sub_char_table): Now static, since it's not used
2369 elsewhere.
2370 (sub_char_table_ref_and_range, char_table_ref_and_range):
2371 Rename locals to avoid shadowing.
2372 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2373
2374 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2375 (BIDI_BOB): Remove unused macro.
2376
2377 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2378 deduce are never used uninitialized.
2379 * term.c (encode_terminal_code): Likewise.
2380
2381 * term.c (encode_terminal_code): Now static. Remove unused local.
2382
2383 * tparam.h: New file.
2384 * term.c, tparam.h: Include it.
2385 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2386 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2387 Move these decls to tparam.h, and make them agree with what
2388 is actually in tparam.c. The previous trick of using incompatible
2389 decls in different modules does not conform to the C standard.
2390 All callers of tparam changed to use tparam's actual API.
2391 * tparam.c (tparam1, tparam, tgoto):
2392 Use const pointers where appropriate.
2393
2394 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2395 * cm.h (struct cm): Likewise.
2396 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2397 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2398 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2399 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2400 (turn_on_face, init_tty): Likewise.
2401 * termchar.h (struct tty_display_info): Likewise.
2402
2403 * term.c (term_mouse_position): Rename local to avoid shadowing.
2404
2405 * alloc.c (mark_ttys): Move decl from here ...
2406 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2407
2408 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2409
2410 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2411
2412 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2413
2414 * search.c (compile_pattern_1): Remove argument regp, unused since
2415 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2416 (compile_pattern): Don't pass it.
2417
2418 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2419
2420 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2421 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2422 for ! HAVE_GTK3.
2423 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2424
2425 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2426
2427 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2428 gdk_window_get_screen, gdk_window_get_geometry,
2429 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2430 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2431 (xg_get_pixbuf_from_pixmap): New function.
2432 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2433 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2434 Call xg_get_pixbuf_from_pixmap instead of
2435 gdk_pixbuf_get_from_drawable.
2436 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2437 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2438 (xg_check_special_colors): Use GtkStyleContext and its functions
2439 for HAVE_GTK3.
2440 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2441 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2442 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2443 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2444 Call gtk_widget_get_preferred_size.
2445 (xg_frame_resized): gdk_window_get_geometry only takes 5
2446 parameters.
2447 (xg_win_to_widget, xg_event_is_for_menubar):
2448 Call gdk_x11_window_lookup_for_display.
2449 (xg_set_widget_bg): New function.
2450 (delete_cb): New function.
2451 (xg_create_frame_widgets): connect delete-event to delete_cb.
2452 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2453 (xg_set_background_color): Call xg_set_widget_bg.
2454 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2455 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2456 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2457 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2458 if ! HAVE_GTK3.
2459 (update_frame_tool_bar): Call gtk_widget_hide.
2460 (xg_initialize): Use GDK_KEY_g.
2461
2462 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2463 if ! HAVE_GTK3
2464 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2465
2466 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2467 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2468 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2469
2470 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2471
2472 * w32xfns.c (select_palette): Check success of RealizePalette against
2473 GDI_ERROR, not zero.
2474
2475 See ChangeLog.11 for earlier changes.
2476
2477 ;; Local Variables:
2478 ;; coding: utf-8
2479 ;; End:
2480
2481 Copyright (C) 2011 Free Software Foundation, Inc.
2482
2483 This file is part of GNU Emacs.
2484
2485 GNU Emacs is free software: you can redistribute it and/or modify
2486 it under the terms of the GNU General Public License as published by
2487 the Free Software Foundation, either version 3 of the License, or
2488 (at your option) any later version.
2489
2490 GNU Emacs is distributed in the hope that it will be useful,
2491 but WITHOUT ANY WARRANTY; without even the implied warranty of
2492 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2493 GNU General Public License for more details.
2494
2495 You should have received a copy of the GNU General Public License
2496 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.