Get rid of compiler warnings on Cygwin.
[bpt/emacs.git] / src / ChangeLog
1 2012-05-20 Ken Brown <kbrown@cornell.edu>
2
3 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
5
6 2012-05-19 Ken Brown <kbrown@cornell.edu>
7
8 * xfns.c (x_in_use): Remove `static' qualifier.
9 * xterm.h (x_in_use): Declare.
10 * xgselect.c: Include xterm.h.
11 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
12 and `display_arg' (bug#9754).
13
14 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
15
16 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
17
18 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
19 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
20
21 2012-05-18 Eli Zaretskii <eliz@gnu.org>
22
23 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
24
25 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
26 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
27
28 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
29 reference to image_cache->refcount.
30 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
31
32 2012-05-17 Juri Linkov <juri@jurta.org>
33
34 * search.c (Fword_search_regexp, Fword_search_backward)
35 (Fword_search_forward, Fword_search_backward_lax)
36 (Fword_search_forward_lax): Move functions to isearch.el
37 (bug#10145, bug#11381).
38
39 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
40
41 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
42
43 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
44
45 * lread.c (init_obarray): Declare Qt and Qnil as special.
46
47 2012-05-14 Glenn Morris <rgm@gnu.org>
48
49 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
50 Put "libexec" before "bin", for the sake of init_callproc_1.
51
52 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
53
54 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
55
56 * unexaix.c: Port to more-recent AIX compilers.
57 (report_error, report_error_1, make_hdr, copy_sym)
58 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
59 Make arguments const char *, not char *, to avoid violations of C
60 standard and to fix some AIX warnings reported by Gilles Pion.
61
62 2012-05-14 Eli Zaretskii <eliz@gnu.org>
63
64 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
65 already have overlays loaded.
66 (handle_single_display_spec): Before returning without displaying
67 fringe bitmap, synchronize the bidi iterator with the main display
68 iterator, by calling iterate_out_of_display_property.
69 (iterate_out_of_display_property): Detect buffer iteration by
70 testing that it->string is a Lisp string.
71 (get_next_display_element): When the current object is exhausted,
72 and there's something on it->stack, call set_iterator_to_next to
73 proceed with what's on the stack, instead of returning zero.
74 (set_iterator_to_next): If called at the end of a Lisp string,
75 proceed to consider_string_end without incrementing string
76 position. Don't increment display vector index past the end of
77 the display vector. (Bug#11417)
78 (pos_visible_p): Don't report a position visible when move_it_to
79 stopped at the last line of window, which happens to be scanned
80 backwards by the bidi iteration. (Bug#11464)
81
82 2012-05-14 Eli Zaretskii <eliz@gnu.org>
83
84 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
85 and right-margin display specs even if the spec is invalid or we
86 are on a TTY, and thus unable to display on the fringes. That's
87 because the text with the property will not be displayed anyway,
88 so we need to signal to the caller that this is a "replacing"
89 display spec. This fixes display when the spec is invalid or we
90 are on a TTY.
91
92 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
93
94 * unexaix.c (make_hdr): Fix typo in prototype.
95 This bug broke the build on AIX. Problem reported by Gilles Pion.
96
97 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
98
99 * keyboard.c (kbd_buffer_get_event): Read special events also in
100 batch mode. (Bug#11415)
101
102 2012-05-12 Glenn Morris <rgm@gnu.org>
103
104 * ns.mk: Update for ns_appbindir no longer having trailing "/".
105
106 2012-05-12 Eli Zaretskii <eliz@gnu.org>
107
108 * lisp.mk (lisp): Add newcomment.elc.
109
110 2012-05-12 Glenn Morris <rgm@gnu.org>
111
112 * Makefile.in (MKDIR_P): New, set by configure.
113 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
114
115 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
116
117 Remove unused function hourglass_started.
118 * dispextern.h (hourglass_started):
119 * w32fns.c (hourglass_started):
120 * xdisp.c (hourglass_started): Remove.
121
122 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
123
124 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
125 Update dependencies.
126
127 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
128
129 * xgselect.c (xg_select): Put maxfds+1 into a var.
130 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
131
132 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
133
134 2012-05-10 Dave Abrahams <dave@boostpro.com>
135
136 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
137 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
138
139 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
140
141 * dbusbind.c (xd_registered_buses): New internal Lisp object.
142 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
143 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
144 Initialize xd_registered_buses.
145
146 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
147
148 Untag more efficiently if USE_LSB_TAG.
149 This is based on a proposal by YAMAMOTO Mitsuharu in
150 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
151 For an admittedly artificial (nth 8000 longlist) benchmark on
152 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
153 Emacs's overall text size by 1%.
154 * lisp.h (XUNTAG): New macro.
155 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
156 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
157 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
158 * eval.c (Fautoload):
159 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
160 * frame.h (XFRAME): Use XUNTAG.
161
162 Port recent dbusbind.c changes to 32-bit --with-wide-int.
163 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
164 Remove unportable assumptions about print widths of types like
165 dbus_uint32_t.
166 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
167 intptr_t when converting between pointer and integer, to avoid GCC
168 warnings about wrong width.
169
170 2012-05-09 Eli Zaretskii <eliz@gnu.org>
171
172 * w32proc.c (new_child): Force Windows to reserve only 64KB of
173 stack for each reader_thread, instead of defaulting to 8MB
174 determined by the linker. This avoids failures in creating
175 subprocesses on Windows 7, see the discussion in this thread:
176 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
177
178 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
179
180 Fix up display of the *Minibuf-0* buffer in the mini window.
181 * keyboard.c (read_char): Don't clear the echo area if there's no
182 message to clear.
183 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
184 contents of *Minibuf-0*) if there's no message displayed in its stead.
185
186 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
187
188 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
189 batch mode.
190
191 2012-05-06 Chong Yidong <cyd@gnu.org>
192
193 * lisp.mk (lisp): Update.
194
195 2012-05-05 Jim Meyering <meyering@redhat.com>
196
197 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
198
199 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
200
201 * data.c (PUT_ERROR): New macro.
202 (syms_of_data): Use it. Add new error type `user-error'.
203 * undo.c (user_error): New function.
204 (Fprimitive_undo): Use it.
205 * print.c (print_error_message): Adjust print style for `user-error'.
206 * keyboard.c (user_error): New function.
207 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
208
209 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
210
211 Do not limit current-time-string to years 1000..9999.
212 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
213 (Fcurrent_time_string): Support any year that is supported by the
214 underlying localtime representation. Don't use asctime, as it
215 has undefined behavior for years outside the range -999..9999.
216
217 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
218
219 Fix race conditions involving setenv, gmtime, localtime, asctime.
220 Without this fix, interrupts could mess up code that uses these
221 nonreentrant functions, since setting TZ invalidates existing
222 tm_zone or tzname values, and since most of these functions return
223 pointers to static storage.
224 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
225 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
226 Grow the critical sections to include not just invoking
227 localtime/gmtime, but also accessing these functions' results
228 including their tm_zone values if any, and any related TZ setting.
229 (format_time_string): Last arg is now struct tm *, not struct tm **,
230 so that the struct tm is saved in the critical section.
231 All callers changed. Simplify allocation of initial buffer, partly
232 motivated by the fact that memory allocation needs to be outside
233 the critical section.
234
235 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
236
237 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
238 with RESET_INTERVAL.
239
240 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
241 Remove duplicated buffer name initialization.
242
243 2012-05-02 Jim Meyering <jim@meyering.net>
244
245 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
246
247 * xfns.c (x_window): Use xstrdup (Bug#11375).
248
249 2012-05-02 Eli Zaretskii <eliz@gnu.org>
250
251 * xdisp.c (pos_visible_p): If already at a newline from the
252 display string before the 'while' loop, don't walk back the glyphs
253 from it3.glyph_row. Solves assertion violation when the display
254 string begins with a newline (egg.el). (Bug#11367)
255
256 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
257
258 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
259 Move to simple.el.
260
261 2012-05-01 Glenn Morris <rgm@gnu.org>
262
263 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
264 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
265 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
266 All were removed before 23.1.
267
268 * dispnew.c: Remove HAVE_LIBNCURSES test;
269 it is always true on relevant platforms.
270
271 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
272 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
273
274 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
275
276 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
277
278 * .gdbinit (xpr): Remove checks for no longer existing misc types.
279 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
280 Remove.
281
282 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
283
284 Do not avoid creating empty evaporating overlays (Bug#9642).
285 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
286 That is, do not delete an evaporating overlay if it becomes
287 empty after its bounds are adjusted to fit within its buffer.
288 This fix caused other problems, and I'm reverting it until we get
289 to the bottom of them.
290
291 2012-04-27 Chong Yidong <cyd@gnu.org>
292
293 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
294
295 2012-04-27 Eli Zaretskii <eliz@gnu.org>
296
297 * xdisp.c (pos_visible_p): If the window start position is beyond
298 ZV, start the display from buffer beginning. Prevents assertion
299 violation in init_iterator when the minibuffer window is scrolled
300 via the scroll bar.
301
302 * window.c (window_scroll_pixel_based): Likewise.
303
304 2012-04-27 Chong Yidong <cyd@gnu.org>
305
306 * keymap.c (where_is_internal): Doc fix (Bug#10872).
307
308 2012-04-27 Glenn Morris <rgm@gnu.org>
309
310 * fileio.c (Fcopy_file, Fset_file_selinux_context):
311 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
312
313 2012-04-27 Eli Zaretskii <eliz@gnu.org>
314
315 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
316 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
317
318 2012-04-26 Eli Zaretskii <eliz@gnu.org>
319
320 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
321 display element, check also the underlying string or buffer
322 character. (Bug#11341)
323
324 * w32menu.c: Include w32heap.h.
325 (add_menu_item): If the call to AppendMenuW (via
326 unicode_append_menu) fails, disable Unicode menus only if we are
327 running on Windows 9X/Me.
328
329 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
330
331 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
332 (xgetint): Add missing shift for LSB tags.
333
334 2012-04-24 Martin Rudalics <rudalics@gmx.at>
335
336 * keyboard.c (read_char): Don't wipe echo area for select window
337 events: These might get delayed via `mouse-autoselect-window'
338 (Bug#11304).
339
340 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
341
342 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
343 manipulation of :loaded-from data.
344
345 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
346
347 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
348 now a cons (bug#11311).
349
350 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
351
352 Do not create empty overlays with the evaporate property (Bug#9642).
353 * buffer.c (Fmove_overlay): Delete an evaporating overlay
354 if it becomes empty after its bounds are adjusted to fit within
355 its buffer. Without this fix, in a nonempty buffer (let ((o
356 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
357 yields an empty overlay that has the evaporate property, which is
358 not supposed to happen.
359
360 Fix minor GTK3 problems found by static checking.
361 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
362 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
363 (struct _EmacsFixedClass, emacs_fixed_get_type):
364 Move decls here from emacsgtkfixed.h, since they needn't be public.
365 (emacs_fixed_get_type): Now static.
366 (emacs_fixed_class_init): Omit unused local.
367 (emacs_fixed_child_type): Remove; unused.
368 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
369 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
370 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
371 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
372 (EMACS_FIXED_GET_CLASS): Remove; unused.
373 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
374
375 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
376 Problem reported by Juanma Barranquero for Windows -Wunused-function.
377
378 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
379
380 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
381 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
382 (__malloc_size_t, __malloc_ptrdiff_t):
383 Remove. All uses removed, replaced by the definiens if needed,
384 since we can assume C89 or better now.
385 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
386 (protect_malloc_state, align, get_contiguous_space)
387 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
388 (malloc_atfork_handler_child, malloc_enable_thread)
389 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
390 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
391 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
392 (special_realloc, _realloc_internal_nolock, _realloc_internal)
393 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
394 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
395 Define using prototypes, not old style.
396 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
397 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
398 (align): Don't assume that signed integer overflow wraps around.
399 Omit unused local var.
400 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
401 (_free_internal_nolock, memalign, mallochook, reallochook):
402 Omit no-longer-needed casts.
403 (valloc): Use getpagesize, not __getpagesize.
404 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
405 (struct hdr): The 'magic' member is now size_t, not unsigned long.
406
407 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
408
409 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
410
411 Move functions from C to Lisp. Make non-blocking method calls
412 the default. Implement further D-Bus standard interfaces.
413
414 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
415 (QCdbus_request_name_allow_replacement)
416 (QCdbus_request_name_replace_existing)
417 (QCdbus_request_name_do_not_queue)
418 (QCdbus_request_name_reply_primary_owner)
419 (QCdbus_request_name_reply_in_queue)
420 (QCdbus_request_name_reply_exists)
421 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
422 (QCdbus_registered_serial, QCdbus_registered_method)
423 (QCdbus_registered_signal): New Lisp objects.
424 (XD_DEBUG_MESSAGE): Use sizeof.
425 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
426 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
427 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
428 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
429 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
430 (xd_signature, xd_append_arg): Allow float for integer types.
431 (xd_get_connection_references): New function.
432 (xd_get_connection_address): Rename from xd_initialize.
433 Return cached address.
434 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
435 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
436 level.
437 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
438 Return number of refcounts.
439 (Fdbus_get_unique_name): Make stronger parameter check.
440 (Fdbus_message_internal): New defun.
441 (Fdbus_call_method, Fdbus_call_method_asynchronously)
442 (Fdbus_method_return_internal, Fdbus_method_error_internal)
443 (Fdbus_send_signal, Fdbus_register_service)
444 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
445 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
446 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
447 (Vdbus_compiled_version, Vdbus_runtime_version)
448 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
449 (Vdbus_message_type_method_return, Vdbus_message_type_error)
450 (Vdbus_message_type_signal): New defvars.
451 (Vdbus_registered_buses, Vdbus_registered_objects_table):
452 Adapt docstring.
453
454 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
455
456 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
457 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
458 Do not assume ptrdiff_t is the same width as 'int'.
459
460 * alloc.c: Handle unusual debugging option combinations.
461 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
462 since the two debugging options are incompatible.
463 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
464 is defined.
465 (mem_init, mem_insert, mem_insert_fixup):
466 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
467 (NEED_MEM_INSERT): Remove; no longer needed.
468
469 2012-04-22 Leo Liu <sdl.web@gmail.com>
470
471 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
472
473 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
474
475 * sysdep.c [__FreeBSD__]: Minor cleanups.
476 (list_system_processes, system_process_attributes) [__FreeBSD__]:
477 Use Emacs indenting style more consistently. Avoid some casts.
478 Use 'double' consistently rather than mixing 'float' and 'double'.
479
480 2012-04-21 Eduard Wiebe <usenet@pusto.de>
481
482 * sysdep.c (list_system_processes, system_process_attributes):
483 Add implementation for FreeBSD (Bug#5243).
484
485 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
486
487 * lisp.mk (lisp): Update.
488
489 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
490
491 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
492 It is never used otherwise.
493
494 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
495
496 * print.c (print_preprocess): Only check print_depth if print-circle
497 is nil.
498 (print_object): Check for cycles even when print-circle is nil and
499 print-gensym is t, but only check print_depth if print-circle is nil.
500
501 2012-04-20 Chong Yidong <cyd@gnu.org>
502
503 * process.c (wait_reading_process_output): If EIO occurs on a pty,
504 set the status to "failed" and ensure that sentinel is run.
505
506 2012-04-20 Glenn Morris <rgm@gnu.org>
507
508 * process.c (Fset_process_inherit_coding_system_flag)
509 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
510 (Fmake_network_process, Fmake_serial_process): Doc fix.
511
512 2012-04-20 Eli Zaretskii <eliz@gnu.org>
513
514 * xdisp.c (string_buffer_position_lim): Limit starting position to
515 BEGV.
516 (set_cursor_from_row): If called for a mode-line or header-line
517 row, return zero immediately.
518 (try_cursor_movement): If inside continuation line, don't back up
519 farther than the first row after the header line, if any.
520 Don't consider the header-line row as "partially visible", even if
521 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
522
523 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
524
525 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
526 (bug#11238).
527
528 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
529 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
530
531 configure: new option --enable-gcc-warnings (Bug#11207)
532 * Makefile.in (C_WARNINGS_SWITCH): Remove.
533 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
534 (ALL_CFLAGS): Use new macros rather than old.
535 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
536 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
537 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
538 -Wunused-result, -Wunused-variable. This should go away once
539 the Emacs and Gnulib regex code is merged.
540 (xmalloc, xrealloc): Now static.
541
542 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
543
544 * dired.c (Fsystem_groups): Remove unused local.
545
546 2012-04-17 Glenn Morris <rgm@gnu.org>
547
548 * dired.c (Fsystem_users): Doc fix.
549
550 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
551
552 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
553 (syms_of_dired): Add them.
554
555 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
556
557 Fix minor alloc.c problems found by static checking.
558 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
559 New extern decls, to avoid calling undeclared functions.
560 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
561 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
562 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
563 (NEED_MEM_INSERT): New macro.
564 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
565 Remove one incorrect comment and fix another.
566
567 Fix minor ralloc.c problems found by static checking.
568 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
569 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
570 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
571 (r_alloc_sbrk): Now static.
572
573 Improve ralloc.c interface checking.
574 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
575 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
576 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
577 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
578 [REL_ALLOC]: ... to here, to check interface.
579 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
580 Remove decls. This fixes an "It stinks!".
581
582 * alloc.c (which_symbols): Fix alignment issue / type clash.
583
584 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
585
586 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
587 (struct Lisp_Misc_Any): Likewise.
588 (struct Lisp_Free): Likewise.
589 * alloc.c (union aligned_Lisp_Symbol): Define.
590 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
591 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
592 (union aligned_Lisp_Misc): Define.
593 (MARKER_BLOCK_SIZE, struct marker_block): Use union
594 aligned_Lisp_Misc instead of union Lisp_Misc.
595 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
596
597 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
598
599 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
600 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
601 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
602 * s/netbsd.h, s/sol2-6.h:
603 Remove definition of GC_MARK_STACK, since the default now works.
604 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
605 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
606 no longer the default.
607 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
608
609 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
610
611 * lread.c (lisp_file_lexically_bound_p):
612 Fix hang at ";-*-\n" (bug#11238).
613
614 2012-04-14 Eli Zaretskii <eliz@gnu.org>
615
616 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
617 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
618
619 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
620
621 * nsterm.m (constrainFrameRect): Always constrain when there is only
622 one screen (Bug#10962).
623
624 2012-04-13 Ken Brown <kbrown@cornell.edu>
625
626 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
627
628 2012-04-13 Reuben Thomas <rrt@sc3d.org>
629
630 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
631
632 2012-04-11 Daniel Colascione <dancol@dancol.org>
633
634 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
635 against is gone. It's better to use vfork now so that when Cygwin
636 gains a new, working vfork, we use it automatically (bug#10398).
637
638 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
639
640 * window.c (save_window_save): Obey window-point-insertion-type.
641
642 2012-04-11 Glenn Morris <rgm@gnu.org>
643
644 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
645
646 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
647
648 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
649
650 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
651
652 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
653 (force_quit_count): New var.
654 (handle_interrupt): Use it.
655
656 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
657
658 * w32.c (w32_delayed_load): Record the full path of the library
659 being loaded (bug#10424).
660
661 2012-04-09 Glenn Morris <rgm@gnu.org>
662
663 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
664 not just in the obarray, before snarfing them. (Bug#11036)
665
666 * Makefile.in ($(leimdir)/leim-list.el):
667 Pass EMACS rather than BUILT_EMACS.
668
669 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
670
671 * process.c (make_process):
672 * process.h: Add integer `gnutls_handshakes_tried' member to
673 process struct.
674
675 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
676 Add convenience `GNUTLS_LOG2i' macro.
677
678 * gnutls.c (gnutls_log_function2i): Convenience log function.
679 (emacs_gnutls_read): Use new log functions,
680 `gnutls_handshakes_tried' process member, and
681 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
682 attempts per process (connection).
683
684 2012-04-09 Chong Yidong <cyd@gnu.org>
685
686 * eval.c (Fuser_variable_p, user_variable_p_eh)
687 (lisp_indirect_variable): Functions deleted.
688 (Fdefvar): Caller changed.
689
690 * callint.c (Finteractive, Fcall_interactively):
691 * minibuf.c (Fread_variable): Callers changed.
692
693 2012-04-09 Eli Zaretskii <eliz@gnu.org>
694
695 * xdisp.c (set_cursor_from_row): If the display string appears in
696 the buffer at position that is closer to point than the position
697 after the display string, display the cursor on the first glyph of
698 the display string. Fixes cursor display when a 'display' text
699 property immediately follows invisible text. (Bug#11094)
700
701 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
702
703 composite.c: use 'double' consistently
704 * composite.c (get_composition_id): Use 'double' consistently
705 instead of converting 'float' to 'double' and vice versa; this is
706 easier to understand and avoids a GCC warning.
707
708 2012-04-09 Glenn Morris <rgm@gnu.org>
709
710 * Makefile.in: Generate leim-list with bootstrap-emacs, in
711 preparation for dumping it with emacs. (Bug#4789)
712 (leimdir): New variable.
713 ($(leimdir)/leim-list.el): New rule.
714 (emacs$(EXEEXT)): Depend on leim-list.el.
715
716 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
717 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
718 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
719
720 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
721
722 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
723 proper alignment.
724
725 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
726
727 * xml.c (init_libxml2_functions) [WINDOWSNT]:
728 Remove unused local variable.
729
730 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
731
732 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
733 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
734 (mark_memory): Mark Lisp_Objects only if pointers might hide in
735 objects, as mark_maybe_pointer will catch them otherwise.
736 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
737 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
738
739 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
740
741 Fix typo that broke non-Windows builds.
742 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
743
744 2012-04-07 Eli Zaretskii <eliz@gnu.org>
745
746 Support building on MS-Windows with libxml2.
747
748 * makefile.w32-in (OBJ2): Add xml.$(O).
749 (GLOBAL_SOURCES): Add xml.c.
750 ($(BLD)/xml.$(O)): New dependency list.
751
752 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
753 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
754 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
755 [!WINDOWSNT]: New macros.
756 (init_libxml2_functions, libxml2_loaded_p): New functions.
757 (parse_region): Call fn_xmlCheckVersion instead of using the macro
758 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
759 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
760 Calls xmlCleanupParser only if libxml2 was loaded (or statically
761 linked in).
762 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
763 Call init_libxml2_functions before calling libxml2 functions.
764 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
765
766 * emacs.c: Don't include libxml/parser.h.
767 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
768 xmlCleanupParser directly.
769
770 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
771
772 2012-04-07 Eli Zaretskii <eliz@gnu.org>
773
774 * indent.c (Fvertical_motion): If there is a display string at
775 point, use it.vpos to compute how many lines to backtrack after
776 move_it_to point. (Bug#11133)
777
778 2012-04-06 Eli Zaretskii <eliz@gnu.org>
779
780 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
781 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
782 about subtle differences between FETCH_CHAR* and STRING_CHAR*
783 macros related to unification of CJK characters. For the details,
784 see the discussion following the message here:
785 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
786
787 2012-04-04 Chong Yidong <cyd@gnu.org>
788
789 * keyboard.c (Vdelayed_warnings_list): Doc fix.
790
791 2012-04-01 Eli Zaretskii <eliz@gnu.org>
792
793 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
794 instead of alloca. (Bug#11138)
795
796 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
797
798 * w32menu.c (is_simple_dialog): Properly check lisp types.
799 (Bug#11141)
800
801 2012-03-31 Eli Zaretskii <eliz@gnu.org>
802
803 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
804 position we get to after a call to move_it_to fails the
805 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
806 only if we wind up in a string from display property. (Bug#11063)
807
808 * window.c (Fdelete_other_windows_internal): Invalidate the row
809 and column information about mouse highlight, so that redisplay
810 restores it after reallocating the glyph matrices. (Bug#7464)
811
812 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
813 string comes from a `display' text property, use the buffer
814 position of that property as if we actually saw that position in
815 the row's glyphs.
816 (move_it_by_lines): Remove the assertion that
817 "it->current_x == 0 && it->hpos == 0" which can be legitimately
818 violated when there's a before-string at the beginning of a line.
819 (Bug#11063)
820
821 2012-03-30 Eli Zaretskii <eliz@gnu.org>
822
823 * xdisp.c (append_space_for_newline): If the default face was
824 remapped, use the remapped face for the appended newline.
825 (extend_face_to_end_of_line): Use the remapped default face for
826 extending the face to the end of the line.
827 (display_line): Call extend_face_to_end_of_line when the default
828 face was remapped. (Bug#11068)
829
830 2012-03-29 Eli Zaretskii <eliz@gnu.org>
831
832 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
833
834 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
835
836 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
837
838 2012-03-27 Glenn Morris <rgm@gnu.org>
839
840 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
841 Doc fixes.
842
843 2012-03-26 Kenichi Handa <handa@m17n.org>
844
845 * dispextern.h (struct glyph): Fix previous change. Change the
846 bit length of glyphless.ch to 25 (Bug#11082).
847
848 2012-03-26 Chong Yidong <cyd@gnu.org>
849
850 * keyboard.c (Vselection_inhibit_update_commands): New variable.
851 (command_loop_1): Use it; inhibit selection update for
852 handle-select-window too (Bug#8996).
853
854 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
855
856 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
857
858 2012-03-25 Kenichi Handa <handa@m17n.org>
859
860 * dispextern.h (struct glyph): Change the bit length of
861 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
862
863 2012-03-24 Eli Zaretskii <eliz@gnu.org>
864
865 * s/ms-w32.h (tzname): Include time.h before redirecting to
866 _tzname. Fixes the MSVC build. (Bug#9960)
867
868 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
869
870 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
871 characters.
872
873 * xterm.c (XTread_socket): Only modify handling_signal if
874 !SYNC_INPUT. (Bug#11080)
875
876 2012-03-23 Eli Zaretskii <eliz@gnu.org>
877
878 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
879 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
880 when fetching a multibyte character consumes more bytes than
881 CHAR_BYTES returns, due to unification of CJK characters in
882 string_char. (Bug#11073)
883
884 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
885
886 * process.c (wait_reading_process_output): Handle pty disconnect
887 by refraining from sending oneself a SIGCHLD (bug#10933).
888
889 2012-03-22 Chong Yidong <cyd@gnu.org>
890
891 * dispextern.h (struct it): New member string_from_prefix_prop_p.
892
893 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
894 Mark string as coming from a prefix property.
895 (handle_face_prop): Use default face for prefix strings (Bug#4281).
896 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
897
898 2012-03-21 Chong Yidong <cyd@gnu.org>
899
900 * xfaces.c (Vface_remapping_alist): Doc fix.
901
902 2012-03-20 Eli Zaretskii <eliz@gnu.org>
903
904 * w32proc.c (Fw32_set_console_codepage)
905 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
906 Doc fixes.
907
908 2012-03-20 Chong Yidong <cyd@gnu.org>
909
910 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
911 to reflect default non-nil value of redisplay-dont-pause.
912
913 2012-03-19 Kenichi Handa <handa@m17n.org>
914
915 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
916 it fit in a valid range (Bug#11003).
917
918 2012-03-18 Eli Zaretskii <eliz@gnu.org>
919
920 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
921 that is not from display property, accept the row as a "cursor
922 row" if one of the string's character has a non-nil `cursor'
923 property. Fixes cursor positioning when there are newlines in
924 overlay strings, e.g. in icomplete.el. (Bug#11035)
925
926 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
927
928 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
929
930 2012-03-12 Chong Yidong <cyd@gnu.org>
931
932 * eval.c (inhibit_lisp_code): Rename from
933 inhibit_window_configuration_change_hook; move from window.c.
934
935 * xfns.c (unwind_create_frame_1, Fx_create_frame):
936 * window.c (run_window_configuration_change_hook)
937 (syms_of_window): Callers changed.
938
939 2012-03-11 Chong Yidong <cyd@gnu.org>
940
941 * keymap.c (Fkey_description): Doc fix (Bug#9700).
942
943 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
944
945 2012-03-10 Chong Yidong <cyd@gnu.org>
946
947 * frame.c (other_visible_frames): Don't assume the selected frame
948 is visible (Bug#10955).
949
950 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
951
952 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
953
954 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
955
956 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
957 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
958 zero (Bug#10954).
959
960 2012-03-03 Glenn Morris <rgm@gnu.org>
961
962 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
963
964 2012-03-02 Eli Zaretskii <eliz@gnu.org>
965
966 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
967 position past the first glyph_row that ends at ZV. (Bug#10902)
968 (redisplay_window, next_element_from_string): Fix typos in
969 comments.
970 (redisplay_window): Pass to move_it_vertically the margin in
971 pixels, not in screen lines.
972
973 2012-03-02 Glenn Morris <rgm@gnu.org>
974
975 * buffer.c (buffer-list-update-hook): Doc fix.
976
977 2012-02-29 Eli Zaretskii <eliz@gnu.org>
978
979 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
980 push_it before setting up the iterator for the first overlay
981 string, even if we have an empty string loaded.
982 (next_overlay_string): If there's an empty string on the iterator
983 stack, pop the stack. (Bug#10903)
984
985 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
986
987 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
988 Suggested by Stefan Monnier in
989 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
990 * alloc.c (widen_to_Lisp_Object): New static function.
991 (mark_memory): Also mark Lisp_Objects by fetching pointer words
992 and widening them to Lisp_Objects. This would work even if
993 USE_LSB_TAG is defined and wide integers are used, which might
994 happen in a future version of Emacs.
995
996 2012-02-25 Chong Yidong <cyd@gnu.org>
997
998 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
999 Doc fix.
1000
1001 * xselect.c (Fx_selection_exists_p): Doc fix.
1002 (x_clipboard_manager_save_all): Print an informative message
1003 before saving to clipboard manager.
1004
1005 2012-02-24 Chong Yidong <cyd@gnu.org>
1006
1007 * keyboard.c (process_special_events): Handle all X selection
1008 requests in kbd_buffer, not just the next one (Bug#8869).
1009
1010 2012-02-23 Chong Yidong <cyd@gnu.org>
1011
1012 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1013 call when setting menu-bar-lines and tool-bar-lines parameters.
1014 (unwind_create_frame_1): New helper function.
1015
1016 * window.c (inhibit_window_configuration_change_hook): New var.
1017 (run_window_configuration_change_hook): Obey it.
1018 (syms_of_window): Initialize it.
1019
1020 2012-02-22 Chong Yidong <cyd@gnu.org>
1021
1022 * xterm.c (x_draw_image_relief): Add missing type check for
1023 Vtool_bar_button_margin (Bug#10743).
1024
1025 2012-02-21 Chong Yidong <cyd@gnu.org>
1026
1027 * fileio.c (Vfile_name_handler_alist): Doc fix.
1028
1029 * buffer.c (Fget_file_buffer): Protect against invalid file
1030 handler return value.
1031
1032 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1033
1034 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1035 when computing $valmask.
1036
1037 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1038 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1039 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1040 It's useless in that case, and it can cause problems on hosts
1041 that allocate halves of EMACS_INT values separately.
1042 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1043 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1044 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1045 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1046 it avoids undefined behavior on hosts where shifting right by more
1047 than the word width has undefined behavior.
1048
1049 2012-02-19 Chong Yidong <cyd@gnu.org>
1050
1051 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1052 (Funhandled_file_name_directory, Ffile_name_as_directory)
1053 (Fdirectory_file_name, Fexpand_file_name)
1054 (Fsubstitute_in_file_name): Protect against invalid file handler
1055 return values (Bug#10845).
1056
1057 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1058
1059 * .gdbinit (pitx): Fix incorrect references to fields of the
1060 iterator stack.
1061
1062 2012-02-17 Chong Yidong <cyd@gnu.org>
1063
1064 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1065
1066 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1067
1068 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1069 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1070
1071 2012-02-15 Chong Yidong <cyd@gnu.org>
1072
1073 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1074 marked as special. Also, starting docstrings with * is obsolete.
1075
1076 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1077
1078 * gnutls.c (emacs_gnutls_write): Fix last change.
1079
1080 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1081
1082 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1083 send_process.
1084
1085 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1086
1087 * keymap.c (Fsingle_key_description): Handle char ranges.
1088
1089 2012-02-12 Chong Yidong <cyd@gnu.org>
1090
1091 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1092 as that creates a dangerous corner case.
1093
1094 * window.c (Fdelete_window_internal): Invalidate the mouse
1095 highlight (Bug#9904).
1096
1097 2012-02-12 Glenn Morris <rgm@gnu.org>
1098
1099 * xselect.c (Fx_own_selection_internal)
1100 (Fx_get_selection_internal, Fx_disown_selection_internal)
1101 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1102 * nsselect.m (Fx_own_selection_internal)
1103 (Fx_disown_selection_internal, Fx_selection_exists_p)
1104 (Fx_selection_owner_p, Fx_get_selection_internal):
1105 Sync docs and argument specs with the xselect.c versions.
1106
1107 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1108
1109 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1110
1111 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1112
1113 * w32select.c (Fx_selection_exists_p): Sync doc string and
1114 argument list with xselect.c. (Bug#10783)
1115
1116 * w16select.c (Fx_selection_exists_p): Sync doc string and
1117 argument list with xselect.c. (Bug#10783)
1118
1119 2012-02-10 Glenn Morris <rgm@gnu.org>
1120
1121 * fns.c (Fsecure_hash): Doc fix.
1122
1123 2012-02-09 Kenichi Handa <handa@m17n.org>
1124
1125 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1126
1127 2012-02-07 Chong Yidong <cyd@gnu.org>
1128
1129 * buffer.c (Fbuffer_local_variables)
1130 (buffer_lisp_local_variables): Handle unbound vars correctly;
1131 don't let Qunbound leak into Lisp.
1132
1133 2012-02-07 Glenn Morris <rgm@gnu.org>
1134
1135 * image.c (Fimagemagick_types): Doc fix.
1136
1137 * image.c (imagemagick-render-type): Change it from a lisp object
1138 to an integer. Move the doc here from the lisp manual.
1139 Treat all values not equal to 0 the same.
1140
1141 2012-02-06 Chong Yidong <cyd@gnu.org>
1142
1143 * doc.c (store_function_docstring): Avoid applying docstring of
1144 alias to base function (Bug#2603).
1145
1146 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1147
1148 * .gdbinit (pp1, pv1): Remove redundant defines.
1149 (pr): Use pp.
1150
1151 2012-02-04 Chong Yidong <cyd@gnu.org>
1152
1153 * nsterm.m: Declare a global (Bug#10694).
1154
1155 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1156
1157 * w32.c (get_emacs_configuration_options):
1158 Include --enable-checking, if specified, in the return value.
1159
1160 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1161
1162 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1163 after rounding frame sizes. (Bug#9723)
1164
1165 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1166
1167 * keyboard.c (adjust_point_for_property): Don't position point
1168 before BEGV. (Bug#10696)
1169
1170 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 Handle overflow when computing char display width (Bug#9496).
1173 * character.c (char_width): Return EMACS_INT, not int.
1174 (char_width, c_string_width): Check for overflow when
1175 computing the width; this is possible now that individual
1176 characters can have unbounded width. Problem introduced
1177 by merge from Emacs 23 on 2012-01-19.
1178
1179 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1180
1181 * dbusbind.c (Fdbus_register_method): Mention the return value
1182 :ignore in the docstring.
1183
1184 2012-02-02 Glenn Morris <rgm@gnu.org>
1185
1186 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1187
1188 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1189 Unconditionally set to t. (Bug#10673)
1190 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1191 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1192 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1193
1194 2012-02-02 Kenichi Handa <handa@m17n.org>
1195
1196 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1197 0, do not call append_composite_glyph.
1198
1199 2012-02-02 Kenichi Handa <handa@m17n.org>
1200
1201 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1202 NULL (Bug#6988).
1203 (x_produce_glyphs): If the component of a composition is a null
1204 string, set it->pixel_width to 1 to avoid zero-width glyph.
1205
1206 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1207
1208 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1209 first 2 arguments are identical. This makes inserting large
1210 output from a subprocess an order of magnitude faster on
1211 MS-Windows, where all sbrk'ed memory is always contiguous.
1212
1213 2012-01-31 Glenn Morris <rgm@gnu.org>
1214
1215 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1216 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1217 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1218
1219 2012-01-29 Glenn Morris <rgm@gnu.org>
1220
1221 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1222
1223 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1224
1225 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1226
1227 2012-01-28 Chong Yidong <cyd@gnu.org>
1228
1229 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1230
1231 2012-01-26 Chong Yidong <cyd@gnu.org>
1232
1233 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1234
1235 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1236 repeat counts (Bug#10507).
1237
1238 2012-01-26 Glenn Morris <rgm@gnu.org>
1239
1240 * lread.c (syms_of_lread): Doc fix.
1241
1242 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1243
1244 * coding.c (encode_designation_at_bol): Change return value to
1245 EMACS_INT.
1246
1247 2012-01-25 Chong Yidong <cyd@gnu.org>
1248
1249 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1250
1251 2012-01-21 Chong Yidong <cyd@gnu.org>
1252
1253 * floatfns.c (Fcopysign): Make the second argument non-optional,
1254 since nil is not allowed anyway.
1255
1256 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1257
1258 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1259 (send_process): Likewise.
1260
1261 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1262
1263 * window.c (save_window_save, Fcurrent_window_configuration)
1264 (Vwindow_persistent_parameters): Do not use Qstate.
1265 Rewrite doc-strings.
1266
1267 2012-01-19 Kenichi Handa <handa@m17n.org>
1268
1269 * character.c (char_width): New function.
1270 (Fchar_width, c_string_width, lisp_string_width):
1271 Use char_width (Bug#9496).
1272
1273 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1274
1275 * window.c (Vwindow_persistent_parameters): New variable.
1276 (Fset_window_configuration, save_window_save): Handle persistent
1277 window parameters.
1278
1279 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1280
1281 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1282 thrashing the stack of the thread. (Bug#9087)
1283
1284 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1287
1288 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1289
1290 * xdisp.c (rows_from_pos_range): Handle the case where the
1291 highlight ends on a newline. (Bug#10464)
1292 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1293 he end column for display of highlight that ends on a newline
1294 before a R2L line.
1295
1296 2012-01-11 Glenn Morris <rgm@gnu.org>
1297
1298 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1299 from load-path also when installation-directory is nil. (Bug#10208)
1300
1301 2012-01-10 Glenn Morris <rgm@gnu.org>
1302
1303 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1304
1305 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1306 Update template values to be closer to their typical values these days.
1307
1308 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1309
1310 * xdisp.c (rows_from_pos_range): Accept additional argument
1311 DISP_STRING, and accept any glyph in a row whose object is that
1312 string as eligible for mouse highlight. Fixes mouse highlight of
1313 display strings from overlays. (Bug#10464)
1314
1315 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 emacs: fix an auto-save permissions race condition (Bug#10400)
1318 * fileio.c (auto_saving_dir_umask): New static var.
1319 (Fmake_directory_internal): Use it.
1320 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1321 creating the directory. The old code temporarily assigns
1322 too-generous permissions to the directory.
1323 (do_auto_save_eh): Clear it.
1324 (Fdo_auto_save): Catch all errors, not just file errors, so
1325 that the var is always cleared.
1326
1327 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1328
1329 * search.c (scan_buffer): Pass character positions to
1330 know_region_cache, not byte positions. (Bug#6540)
1331
1332 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1333
1334 * w32.c (sys_rename): Report EXDEV when rename of a directory
1335 fails because the target is on another logical disk. (Bug#10284)
1336
1337 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1338
1339 * xterm.c (x_embed_request_focus): New function.
1340
1341 * xterm.h: Add prototype.
1342
1343 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1344
1345 2012-01-05 Glenn Morris <rgm@gnu.org>
1346
1347 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1348
1349 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1350
1351 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1352 Load gnutls_transport_set_lowat only if GnuTLS version is below
1353 2.11.1.
1354 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1355 GnuTLS versions below 2.11.1.
1356
1357 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1358
1359 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1360 to the doc string advising against its use for altering the way
1361 windows are scrolled.
1362
1363 2011-12-28 Kenichi Handa <handa@m17n.org>
1364
1365 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1366 coding-system ASCII compatible only when it does not produce BOM
1367 on encoding (Bug#10383).
1368
1369 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1370
1371 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1372 can scroll.
1373 (create_and_show_popup_menu): Always use menu_position_func for
1374 Gtk3 (Bug#10361).
1375
1376 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1377
1378 * callint.c (Fcall_interactively): Don't truncate prompt string.
1379
1380 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1381
1382 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1383 property that ends at ZV, so that the bidi iteration could be
1384 resumed from there (after widening). (Bug#10360)
1385
1386 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1387
1388 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1389
1390 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1391
1392 * nsterm.m (x_free_frame_resources):
1393 Release f->output_data.ns->miniimage.
1394 (ns_index_color): Fix indentation. Do not retain
1395 color_table->colors[i].
1396
1397 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1398 before returning.
1399
1400 * nsfns.m (x_set_background_color): Assign return value from
1401 ns_index_color to face-background instead of NSColor*.
1402 (ns_implicitly_set_icon_type): Fix indentation.
1403 Change assignment in for loop to comparison.
1404
1405 * emacs.c (ns_pool): New variable.
1406 (main): Assign ns_pool.
1407 (Fkill_emacs): Call ns_release_autorelease_pool.
1408
1409 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1410 autorelease fdesc, release fdAttrs and tdict.
1411 (ns_get_covering_families): Release charset.
1412 (ns_findfonts): Release NSFontDescriptor created with new.
1413 (ns_uni_to_glyphs): Fix indentation.
1414 (setString): Release attrStr before assigning new value.
1415
1416 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1417
1418 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1419 and NS_IMPL_COCOA.
1420 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1421 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1422
1423 2011-12-18 David Reitter <reitter@cmu.edu>
1424
1425 * nsterm.m (ns_term_init): Subscribe for notifications
1426 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1427 to method trackingNotification in EmacsMenu.
1428
1429 * nsmenu.m (trackingMenu): New variable.
1430 (trackingNotification): New method (from Aquamacs).
1431 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1432 from Aquamacs (Bug#7030).
1433
1434 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1435
1436 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1437 (symbol_to_nsstring): Fix indentation.
1438 (ns_symbol_to_pb): New function.
1439 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1440 (Fns_rotate_cut_buffers_internal): Remove.
1441 (Fns_store_selection_internal): Rename from
1442 Fns_store_cut_buffer_internal.
1443 (ns_get_foreign_selection, Fx_own_selection_internal)
1444 (Fx_disown_selection_internal, Fx_selection_exists_p)
1445 (Fns_get_selection_internal, Fns_store_selection_internal):
1446 Use ns_symbol_to_pb and check if return value is nil.
1447 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1448 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1449 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1450 renamed to Sns_store_selection_internal.
1451 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1452 and remove this function.
1453 (ns_handle_selection_clear): Remove, never used.
1454 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1455 here.
1456
1457 2011-12-17 Ken Brown <kbrown@cornell.edu>
1458
1459 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1460 GID is unknown (Bug#10257).
1461
1462 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1463
1464 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1465 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1466 which caused a build failure on GNU/Linux IA-64. This problem was
1467 introduced by my 2011-10-07 patch.
1468
1469 2011-12-15 Juri Linkov <juri@jurta.org>
1470
1471 * image.c (imagemagick_error): New function. (Bug#10112)
1472 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1473 Use `imagemagick_error' where ImageMagick functions return
1474 `MagickFalse'.
1475 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1476 proper order.
1477
1478 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1479
1480 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1481 fill background (Bug#8992).
1482
1483 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1484
1485 * window.c (Vwindow_combination_resize)
1486 (Vwindow_combination_limit): Use t instead of non-nil in
1487 doc-strings.
1488 (Vrecenter_redisplay): Add first sentence of doc-string on
1489 separate line.
1490 (Frecenter): Fix doc-string typo.
1491
1492 2011-12-11 Kenichi Handa <handa@m17n.org>
1493
1494 * coding.c (Funencodable_char_position): Pay attention to the
1495 buffer text relocation (Bug#9389).
1496
1497 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1498
1499 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1500 gtk_init (Bug#10100).
1501
1502 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1503
1504 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1505 IT->string is nil. (Bug#10263)
1506
1507 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1508
1509 * nsterm.h (x_free_frame_resources): Declare.
1510
1511 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1512 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1513
1514 * nsterm.h (ns_get_defaults_value): Declare.
1515
1516 * nsterm.m (ns_default): Call ns_get_defaults_value.
1517
1518 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1519
1520 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1521 (Bug#10170)
1522
1523 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1524
1525 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1526 that where the value of an _OBJC_* symbol points to is in the .bss
1527 section (Bug#10240).
1528
1529 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1530
1531 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1532 after the loop to call ccl_driver at least once (Bug#8619).
1533
1534 2011-12-08 Kenichi Handa <handa@m17n.org>
1535
1536 * ftfont.c (get_adstyle_property): Fix previous change
1537 (Bug#10233).
1538
1539 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1540
1541 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1542 dirs from the default value of EMACSLOADPATH (bug#10208).
1543
1544 2011-12-07 Glenn Morris <rgm@gnu.org>
1545
1546 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1547 installation and source directories as well. (Bug#10208)
1548
1549 2011-12-06 Chong Yidong <cyd@gnu.org>
1550
1551 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1552
1553 2011-12-06 Glenn Morris <rgm@gnu.org>
1554
1555 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1556 as an error, not just -1. (Bug#10217)
1557
1558 2011-12-05 Chong Yidong <cyd@gnu.org>
1559
1560 * keyboard.c (process_special_events): New function.
1561 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1562
1563 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1564
1565 * coding.c (encode_designation_at_bol): Don't use uninitialized
1566 local variable (Bug#9318).
1567
1568 2011-12-05 Kenichi Handa <handa@m17n.org>
1569
1570 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1571 return Qnil (Bug#8046, Bug#10193).
1572
1573 2011-12-05 Kenichi Handa <handa@m17n.org>
1574
1575 * coding.c (encode_designation_at_bol): New args charbuf_end and
1576 dst. Return the number of produced bytes. Callers changed.
1577 (coding_set_source): Return how many bytes coding->source was
1578 relocated.
1579 (coding_set_destination): Return how many bytes
1580 coding->destination was relocated.
1581 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1582 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1583
1584 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1585
1586 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1587 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1588 macro (Bug#9318).
1589
1590 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1591
1592 The following changes are to fix Bug#9318.
1593
1594 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1595 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1596 (encode_coding_iso_2022, encode_coding_sjis)
1597 (encode_coding_big5, encode_coding_charset): Use the above macros.
1598
1599 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1600
1601 * lisp.h (process_quit_flag): Fix external declaration.
1602
1603 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1604
1605 Don't macro-inline non-performance-critical code.
1606 * eval.c (process_quit_flag): New function.
1607 * lisp.h (QUIT): Use it.
1608
1609 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1610
1611 * nsfns.m (get_geometry_from_preferences): New function.
1612 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1613
1614 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1615
1616 * emacs.c (Qkill_emacs): Define.
1617 (syms_of_emacs): Initialize it.
1618 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1619 Qquit_flag to `kill-emacs' instead.
1620 (quit_throw_to_read_char): Add parameter `from_signal'.
1621 All callers changed. Call Fkill_emacs if requested and safe.
1622 * lisp.h (QUIT): Call Fkill_emacs if requested.
1623
1624 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1625
1626 * widget.c (update_wm_hints): Return if wmshell is null.
1627 (widget_update_wm_size_hints): New function.
1628
1629 * widget.h (widget_update_wm_size_hints): Declare.
1630
1631 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1632 widget_update_wm_size_hints (Bug#10104).
1633
1634 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1635
1636 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1637 before a newline, prepare the bidi iterator for consuming the
1638 newline, and keep the current paragraph direction. (Bug#10183)
1639 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1640
1641 2011-12-02 Juri Linkov <juri@jurta.org>
1642
1643 * search.c (Fword_search_regexp): New Lisp function created from
1644 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1645 (Fword_search_backward, Fword_search_forward)
1646 (Fword_search_backward_lax, Fword_search_forward_lax):
1647 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1648 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1649
1650 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1651
1652 * fileio.c (Finsert_file_contents): Move after-change-function call
1653 to before the "handled:" label, since all "goto handled" appear in
1654 cases where the *-change-functions have already been properly called
1655 (bug#10117).
1656
1657 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1658
1659 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1660 waiting for input. (Bug#10169)
1661
1662 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1663
1664 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1665 verifies glyph row's hash code--we have just reallocated the
1666 glyphs, so their contents can be complete garbage. (Bug#10164)
1667
1668 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1669
1670 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1671
1672 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1673
1674 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1675 attributes are tested _before_ calling verify_row_hash, to protect
1676 against GCC re-ordering of the tests. (Bug#10164)
1677
1678 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1679
1680 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1681
1682 * xterm.c (handle_one_xevent): Only set async_visible and friends
1683 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1684 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1685 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1686
1687 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1690 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1691 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1692 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1693 All uses changed to use GCPRO1 etc.
1694 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1695 Revert to old implementation (i.e., before 2011-03-11).
1696
1697 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1698
1699 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1700 of scroll runs so as to avoid assigning disabled bogus rows and
1701 unnecessary graphics copy operations.
1702
1703 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1704
1705 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1706 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1707 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1708 (malloc, free, realloc, calloc): Redirect to e_* only when
1709 compiling Emacs.
1710
1711 * lisp.h (GCTYPEBITS): Move before first use.
1712 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1713 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1714 this macro definition.
1715
1716 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1717 _MSC_VER.
1718
1719 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1720
1721 * gtkutil.c (xg_create_frame_widgets):
1722 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1723 present with Gtk+ 2.0.
1724
1725 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1726
1727 * fileio.c (Finsert_file_contents): Undo previous change; see
1728 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1729
1730 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 Rename locals to avoid shadowing.
1733 * fileio.c (Finsert_file_contents):
1734 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1735 * process.c (wait_reading_process_output):
1736 Rename inner 'proc' to 'p' to avoid shadowing.
1737 Indent for consistency with usual Emacs style.
1738
1739 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1740
1741 * xdisp.c (redisplay_window): If cursor row is not fully visible
1742 after recentering, and scroll-conservatively is set to a large
1743 number, scroll window by a few more lines to make the cursor fully
1744 visible and out of scroll-margin. (Bug#10105)
1745 (start_display): Don't move to the next line if the display should
1746 start at a newline that is part of a display vector or an overlay
1747 string. (Bug#10119)
1748
1749 2011-11-24 Juri Linkov <juri@jurta.org>
1750
1751 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1752 after the `MagickPingImage' call. (Bug#10112)
1753
1754 2011-11-23 Chong Yidong <cyd@gnu.org>
1755
1756 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1757
1758 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1759
1760 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1761 making another buffer current. (Bug#10114)
1762
1763 2011-11-23 Glenn Morris <rgm@gnu.org>
1764
1765 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1766
1767 2011-11-23 Chong Yidong <cyd@gnu.org>
1768
1769 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1770 using it (Bug#5984).
1771
1772 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1773
1774 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1775 and header-lines, as they don't have one computed for them.
1776 (Bug#10098)
1777
1778 * .gdbinit (prow): Make displayed values more self-explaining.
1779 Add row's hash code.
1780
1781 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1782
1783 * process.c (wait_reading_process_output): Fix asynchrounous
1784 GnuTLS socket handling on some versions of the GnuTLS library.
1785 (wait_reading_process_output): Add comment and URL.
1786
1787 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1788
1789 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1790
1791 2011-11-21 Chong Yidong <cyd@gnu.org>
1792
1793 * window.c (Fnext_window, Fprevious_window): Doc fix.
1794
1795 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1796
1797 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1798
1799 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1800
1801 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1802
1803 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1804
1805 * window.c (Fset_window_combination_limit): Rename argument
1806 STATUS to LIMIT.
1807 (Vwindow_combination_limit): Remove "status" from doc-string.
1808
1809 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1810
1811 * m/ibms390.h: Remove.
1812 * m/ibms390x.h: Don't include "ibms390.h".
1813
1814 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1815
1816 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1817 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1818
1819 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1820
1821 * casetab.c (Fset_case_table):
1822 * charset.c (Fcharset_after): Fix typos.
1823
1824 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1827 Otherwise, valgrind does not work on some platforms.
1828 Problem reported by Andreas Schwab in
1829 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1830 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1831 is set, removing the need for VIRT_ADDRESS_VARIES.
1832 (PURE_P): Use a more-efficient implementation that needs just one
1833 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1834 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1835 to 4 (xorl, subq, cmpq, setbe).
1836 * alloc.c (pure): Always extern now, since that's the
1837 VIRT_ADDR_VARIES behavior.
1838 (PURE_POINTER_P): Use a single comparison, not two, for
1839 consistency with the new puresize.h.
1840 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1841 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1842 Remove VIRT_ADDR_VARIES no longer needed.
1843
1844 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1845
1846 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1847 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1848 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1849 behave as if the cursor position were at the window margin.
1850
1851 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1852 and the cursor position is out of bounds, behave as if the cursor
1853 position were at the window margin. (Bug#10075)
1854
1855 2011-11-18 Chong Yidong <cyd@gnu.org>
1856
1857 * window.c (Fwindow_combination_limit): Make first argument
1858 non-optional, since it is meaningless for live windows like the
1859 selected window.
1860
1861 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1862
1863 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1864
1865 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1866
1867 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1868 (graft_intervals_into_buffer): Simplify.
1869
1870 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1871
1872 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1873 hash values of the two rows.
1874 (copy_row_except_pointers): Preserve the used[] arrays and the
1875 hash values of the two rows. (Bug#10035)
1876 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1877
1878 * xdisp.c (row_hash): New function, body extracted from
1879 compute_line_metrics.
1880 (compute_line_metrics): Call row_hash, instead of computing the
1881 hash code inline.
1882
1883 * dispnew.c (verify_row_hash): Call row_hash for computing the
1884 hash code of a row, instead of duplicating code from xdisp.c.
1885
1886 * dispextern.h (row_hash): Add prototype.
1887
1888 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1889
1890 * frame.c (delete_frame): Don't delete the terminal when the last
1891 X frame is closed if emacs is built with GTK toolkit.
1892
1893 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1894
1895 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1896
1897 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1898
1899 * window.c (Vwindow_splits): Rename to
1900 Vwindow_combination_resize. Suggested by Juri Linkov.
1901 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1902 of Vwindow_splits.
1903
1904 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1905
1906 * nsfns.m (Fns_font_name):
1907 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1908
1909 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1910
1911 * window.h (window): Rename slot "nest" to "combination_limit".
1912 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1913 (Fset_window_nest): Rename to Fset_window_combination_limit.
1914 (Vwindow_nest): Rename to Vwindow_combination_limit.
1915 (recombine_windows, make_parent_window, make_window)
1916 (Fsplit_window_internal, saved_window)
1917 (Fset_window_configuration, save_window_save): Rename all
1918 occurrences of window_nest to window_combination_limit.
1919
1920 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1921
1922 * image.c (imagemagick_load_image): Fix typo.
1923
1924 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1925
1926 * xdisp.c (display_line): Move the call to
1927 highlight_trailing_whitespace before the call to
1928 compute_line_metrics, since the latter needs to see the final
1929 faces of all the glyphs to compute ROW's hash value.
1930 Fixes assertion violations in row_equal_p. (Bug#10035)
1931
1932 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1933
1934 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1935 just return (bug#10044).
1936
1937 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1938
1939 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1940 with user-defined heap size. Bump the default size of the temacs
1941 heap to 27MB, to avoid memory warning when running temacs.
1942 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1943
1944 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1945 current_matrix and desired_matrix. (Bug#9990)
1946 (verify_row_hash) [XASSERTS]: New function.
1947 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1948 that the hash value of glyph rows is correct.
1949
1950 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1951
1952 * window.h (window): Remove splits slot.
1953 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1954 (Fdelete_other_windows_internal, make_parent_window)
1955 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1956 (Fset_window_configuration, save_window_save): Don't deal with
1957 split status of windows.
1958 (saved_window): Remove splits slot.
1959 (Vwindow_splits): Rewrite doc-string.
1960
1961 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1962
1963 * xfns.c (unwind_create_frame):
1964 * nsfns.m (unwind_create_frame):
1965 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1966 Vframe_list (Bug#9999).
1967
1968 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1969
1970 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1971
1972 2011-11-11 Kenichi Handa <handa@m17n.org>
1973
1974 * callproc.c (Fcall_process): Set the member dst_multibyte of
1975 process_coding.
1976
1977 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1978
1979 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1980 avoid a crash (bug#9496).
1981
1982 2011-11-09 Chong Yidong <cyd@gnu.org>
1983
1984 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1985 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1986
1987 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1990
1991 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1992
1993 Avoid some portability problems by eschewing 'extern inline' functions.
1994 The trivial performance wins aren't worth the portability hassles; see
1995 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1996 et seq.
1997 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1998 (window_box_width, window_box_left, window_box_left_offset)
1999 (window_box_right, window_box_right_offset): Undo previous change,
2000 by removing the "extern"s.
2001 * intervals.c (adjust_intervals_for_insertion)
2002 (adjust_intervals_for_deletion): Undo previous change,
2003 making these static again.
2004 (offset_intervals, temp_set_point_both, temp_set_point)
2005 (copy_intervals_to_string): No longer inline.
2006 * xdisp.c (window_text_bottom_y, window_box_width)
2007 (window_box_height, window_box_left_offset)
2008 (window_box_right_offset, window_box_left, window_box_right)
2009 (window_box): No longer inline.
2010
2011 2011-11-08 Chong Yidong <cyd@gnu.org>
2012
2013 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2014 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2015 Signal an error if not a live window.
2016 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2017 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2018
2019 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2020
2021 * lisp.h (syms_of_abbrev): Remove declaration.
2022 Reported by CHENG Gao <chenggao@royau.me>.
2023
2024 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2025
2026 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2027 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2028 of temacs in GUI mode.
2029
2030 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2031
2032 * window.h: Declare delete_all_child_windows instead of
2033 delete_all_subwindows.
2034 * window.c (Fwindow_nest, Fset_window_nest)
2035 (Fset_window_new_total, Fset_window_new_normal)
2036 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2037 (delete_all_subwindows): Rename to delete_all_child_windows.
2038 (Fdelete_other_windows_internal, Fset_window_configuration):
2039 Call delete_all_child_windows instead of delete_all_subwindows.
2040 * frame.c (delete_frame): Call delete_all_child_windows instead
2041 of delete_all_subwindows.
2042
2043 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2046 This is also needed for porting to any host where GC_MARK_STACK is
2047 not GC_MAKE_GCPROS_NOOPS.
2048 (which_symbols): Use it.
2049
2050 2011-11-07 Kenichi Handa <handa@m17n.org>
2051
2052 * coding.c (coding_set_destination): Check coding->src_pos only
2053 when coding->src_object is a buffer (bug#9910).
2054
2055 * process.c (send_process): Set the member src_multibyte of coding
2056 to 0 (bug#9911) when sending a unibyte text.
2057
2058 * callproc.c (Fcall_process): Set the member src_multibyte of
2059 process_coding to 0 (bug#9912).
2060
2061 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2062
2063 * xmenu.c (cleanup_widget_value_tree): New function.
2064 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2065 calling free_menubar_widget_value_tree directly (Bug#9830).
2066
2067 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2068
2069 Fix some portability problems with 'inline'.
2070 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2071 (window_box_width, window_box_left, window_box_left_offset)
2072 (window_box_right, window_box_right_offset): Declare extern.
2073 Otherwise, these inline functions do not conform to C99 and
2074 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2075 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2076 * intervals.c (adjust_intervals_for_insertion)
2077 (adjust_intervals_for_deletion): Now extern, because otherwise the
2078 extern inline functions 'offset_intervals' couldn't refer to it.
2079 (static_offset_intervals): Remove.
2080 (offset_intervals): Rewrite using the old contents of
2081 static_offset_intervals. The old version didn't conform to C99
2082 because an extern inline function contained a reference to an
2083 identifier with static linkage.
2084
2085 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2086
2087 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2088 GC.
2089
2090 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2091
2092 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2093 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2094 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2095 return Qleft_to_right.
2096
2097 2011-11-06 Chong Yidong <cyd@gnu.org>
2098
2099 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2100 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2101 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2102 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2103 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2104 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2105 (Fwindow_vscroll): Doc fix.
2106 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2107 argument, since it makes no sense to pass a live window and for
2108 consistency with window-child.
2109
2110 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2111
2112 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2113 support MSVC.
2114
2115 2011-11-05 Jason Rumney <jasonr@gnu.org>
2116
2117 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2118 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2119 fonts (Bug#6029).
2120 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2121 bitwise arithmetic preventing use of unicode-sip and non-truetype
2122 opentype fonts.
2123
2124 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2125
2126 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2127 "emacs"-only part.
2128
2129 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2130 initialization code to keep similarity to xfns.c after changes
2131 from 2011-11-05.
2132
2133 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2134
2135 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2136 (unwind_create_frame): New function (Bug#9943).
2137 (Fx_create_frame): Restructure code to be more similar to the one in
2138 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2139 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2140 Move terminal->reference_count++ just before making the frame official
2141 (Bug#9943).
2142
2143 * nsterm.m (x_free_frame_resources): New function.
2144 (x_destroy_window): Move code to x_free_frame_resources.
2145
2146 * xfns.c (unwind_create_frame): Fix comment.
2147 (Fx_create_frame, x_create_tip_frame):
2148 Move terminal->reference_count++ just before making the frame
2149 official. Move initialization of image_cache_refcount and
2150 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2151
2152 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2153
2154 Support MSVC build with newer versions of Visual Studio.
2155 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2156 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2157 nt/gmake.defs.
2158
2159 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2160 which are not supported by MSVC.
2161 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2162 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2163 bitfields.
2164 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2165 types in bitfields.
2166 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2167
2168 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2169
2170 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2171
2172 Support MSVC build with newer versions of Visual Studio.
2173 * w32.c: Don't include w32api.h for MSVC.
2174 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2175
2176 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2177 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2178 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2179 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2180 e_* cousins.
2181 (alloca) [_MSC_VER]: Define to _alloca.
2182
2183 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2184
2185 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2186
2187 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2188
2189 * xdisp.c (note_mouse_highlight): If either of
2190 previous/next-single-property-change returns nil, treat that as
2191 the beginning or the end of the buffer. (Bug#9955)
2192
2193 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2194
2195 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2196 label is not null (Bug#9951).
2197 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2198 may be NULL.
2199
2200 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2201
2202 * window.c (Fwindow_body_size): Mention in the doc string that the
2203 return value is in frame's canonical units. (Bug#9949)
2204
2205 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2206
2207 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2208
2209 * w32fns.c (unwind_create_frame): If needed, free the glyph
2210 matrices of the partially constructed frame. (Bug#9943)
2211 * xfns.c (unwind_create_frame): Likewise.
2212
2213 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2214
2215 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2216 Don't stop backward scan on the continuation glyph, even though
2217 its CHARPOS is positive.
2218 (mouse_face_from_buffer_pos, note_mouse_highlight):
2219 Rename cover_string to disp_string.
2220
2221 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2222
2223 * window.c (temp_output_buffer_show): Don't use
2224 Vtemp_buffer_show_specifiers.
2225 (Vtemp_buffer_show_specifiers): Remove unused variable.
2226
2227 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2228
2229 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2230 past the beginning of the current glyph matrix.
2231
2232 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2233
2234 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2235 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2236 HAVE_GTK3 (Bug#9869).
2237
2238 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2239 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2240
2241 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2242
2243 * xterm.c: Declare x_handle_net_wm_state to return int.
2244 (handle_one_xevent): Check if we are iconified but don't have
2245 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2246 (get_current_wm_state): Return non-zero if not hidden,
2247 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2248 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2249 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2250 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2251
2252 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2253
2254 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2255 so that this new function doesn't get optimized away by a
2256 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2257
2258 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2259
2260 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2261
2262 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2263
2264 Fix the `xbytecode' command.
2265 * .gdbinit (xprintbytestr): New command.
2266 (xwhichsymbols): Rename from `which'; all callers changed.
2267 (xbytecode): Print the byte-code string as well.
2268
2269 2011-10-29 Kim Storm <storm@cua.dk>
2270
2271 * alloc.c (which_symbols): New function.
2272
2273 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2274
2275 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2276 line. (Bug#9903)
2277
2278 2011-10-29 Glenn Morris <rgm@gnu.org>
2279
2280 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2281 Not clear what it was for, and it causes various bugs. (Bug#9839)
2282
2283 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2284
2285 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2286 possible random value that matches one of those tested as
2287 condition to clear the mouse face.
2288
2289 2011-10-28 Chong Yidong <cyd@gnu.org>
2290
2291 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2292
2293 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2294
2295 * window.c (make_window): Initialize phys_cursor_on_p.
2296
2297 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2298
2299 * lisp.h (struct Lisp_Symbol): Update comments.
2300
2301 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2302
2303 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2304
2305 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2306
2307 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2308 <oslsachem@gmail.com> for helping to debug this.
2309
2310 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2311 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2312 (g_b_init_get_glyph_outline_w): New static variables.
2313 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2314 (GetGlyphOutlineW_Proc): New typedefs.
2315 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2316 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2317 New functions.
2318 (w32font_open_internal, compute_metrics):
2319 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2320 instead of calling the "wide" APIs directly.
2321
2322 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2323
2324 * w32.h (syms_of_w32font): Add prototype.
2325
2326 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2327
2328 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2329 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2330 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2331 (Fmove_to_window_line): Doc fix.
2332
2333 2011-10-27 Chong Yidong <cyd@gnu.org>
2334
2335 * process.c (make_process): Set gnutls_state to NULL.
2336
2337 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2338 non-NULL, regardless of GNUTLS_INITSTAGE.
2339 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2340 an error. Set process slots as soon as we allocate them.
2341
2342 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2343
2344 2011-10-27 Chong Yidong <cyd@gnu.org>
2345
2346 * gnutls.c (emacs_gnutls_deinit): New function.
2347 Deallocate credentials structures as well as calling gnutls_deinit.
2348 (Fgnutls_deinit, Fgnutls_boot): Use it.
2349
2350 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2351 (deactivate_process): Call emacs_gnutls_deinit.
2352
2353 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2354
2355 * image.c (x_create_x_image_and_pixmap):
2356 * w32.c (sys_rename, w32_delayed_load):
2357 * w32font.c (fill_in_logfont):
2358 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2359
2360 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2361
2362 * w32fns.c (w32_default_color_map): New function,
2363 extracted from Fw32_default_color_map.
2364 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2365
2366 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2367
2368 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2369
2370 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2371
2372 * keyboard.c (test_undefined): New function (bug#9751).
2373 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2374
2375 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2376
2377 * sysdep.c (init_sys_modes): Fix the check for the controlling
2378 terminal (Bug#6649).
2379
2380 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2381
2382 * dispextern.h (struct bidi_it): New member next_en_type.
2383
2384 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2385 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2386 current character, check also for next_en_type being WEAK_EN.
2387 (bidi_resolve_weak): Don't enter the expensive loop if the current
2388 position is before next_en_pos. Record the bidi type of the first
2389 non-ET, non-BN character we find, in addition to its position.
2390 (bidi_level_of_next_char): Invalidate next_en_type when
2391 next_en_pos is over-stepped.
2392
2393 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2394
2395 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2396 * editfns.c: Rewrite current-time-zone so that it invokes
2397 the equivalent of (format-time-string "%Z") to get the time zone name.
2398 This fixes a bug when the time zone name contains characters that
2399 need converting from the system time locale to Emacs internal format.
2400 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2401 that patch fixed format-time-string to do the conversion, but
2402 I forgot to fix current-time-zone.
2403 (format_time_string): New function, containing most of
2404 what Fformat_time_string used to contain.
2405 (Fformat_time_string): Rewrite in terms of format_time_string.
2406 This doesn't change this function's behavior.
2407 (current-time-zone): Rewrite to use format_time_string.
2408 This fixes the bug reported by Michael Schierl in
2409 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2410 Jason Rumney's 2007-06-07 change worked around this bug, but
2411 didn't fix it.
2412 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2413
2414 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2415
2416 * xdisp.c (start_display): If the character at POS is displayed
2417 via a display vector, reset IT->current.dpvec_index to zero.
2418 (try_window_reusing_current_matrix): If a line ends in a display
2419 vector or the next line starts in a display vector, continue
2420 redrawing the window even though the character position of
2421 start_row was reached.
2422 (Bug#9771, part 2)
2423
2424 2011-10-18 Chong Yidong <cyd@gnu.org>
2425
2426 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2427 with nobreak-char-display too.
2428
2429 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2430
2431 Fix part 3 of bug#9771.
2432 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2433 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2434 non-neutral characters if the current character is a paragraph
2435 separator (a.k.a. Newline). This avoids running the same
2436 expensive loop twice, once when we consume the preceding newline
2437 and the other time when the line actually needs to be displayed.
2438 Avoid the loop when we see neutrals on the base embedding level
2439 following a character whose directionality is the same as the
2440 paragraph's. This avoids running the expensive loop when a line
2441 ends in a long sequence of neutrals, like control characters.
2442 Add assertion against STRONG_AL type. Slightly rearrange code
2443 that determines the type of a neutral given the first non-neutral
2444 that follows it.
2445 (bidi_level_of_next_char): Set next_en_pos to zero when
2446 invalidating its info.
2447
2448 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2449
2450 * xdisp.c (push_display_prop): Determine whether to record string
2451 or buffer position by IT->string, not by IT->method. Allow
2452 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2453 (move_it_vertically_backward): Don't look for character position
2454 immediately after the newline when in a continuation line.
2455 (Bug#9771, part 1)
2456
2457 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2458
2459 * window.c (coordinates_in_window): Rewrite and delabelize
2460 vertical border check. (Bug#5357) (Bug#9618)
2461
2462 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2463
2464 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2465 errors in XSetWindowBorder (bug#9310).
2466
2467 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2468
2469 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2470 avoid crash when xmalloc overrun checking is enabled.
2471
2472 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2473
2474 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2475 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2476 cursor motion with <left> and <right> arrow keys.
2477
2478 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2479 some callers set that themselves.
2480
2481 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2482
2483 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2484 display string and the previous row comes from the same string and
2485 is empty. (Bug#9739) (Bug#9738)
2486
2487 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2488
2489 * doc.c (get_doc_string): Encode file name (bug#9735).
2490
2491 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2492
2493 * bidi.c (bidi_level_of_next_char):
2494 * xdisp.c (get_visually_first_element): Remove old incorrect
2495 comments regarding the Unicode Line Separator character.
2496
2497 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2498
2499 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2500
2501 * alloc.c (Fgc_status): Do not access beyond zombies array
2502 boundary if nzombies > MAX_ZOMBIES.
2503 * alloc.c (dump_zombies): Add missing format specifier.
2504
2505 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2506
2507 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2508 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2509
2510 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2511 Some packages use them to denote characters with modifiers.
2512
2513 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2514
2515 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2516 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2517 matching a pp-number. Rename parameter var to var1.
2518
2519 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2520
2521 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2522
2523 2011-10-08 Glenn Morris <rgm@gnu.org>
2524
2525 * callint.c (Fcall_interactively): Give a more explicit error for the
2526 'c' case with a non-character input. (Bug#8479)
2527
2528 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2529
2530 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2531 lines.
2532 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2533 lines that are hscrolled on the left.
2534
2535 * dispnew.c (buffer_posn_from_coords): Account for a possible
2536 presence of header-line. (Bug#4426)
2537
2538 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2539
2540 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2541 Don't advertise functionality which we discourage or doesn't work.
2542
2543 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2544
2545 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2546 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2547 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2548 this makes Emacs dump core during garbage collection on rare
2549 occasions. sizeof is obviously inferior to offsetof here, so
2550 stick with offsetof.
2551 (GC_POINTER_ALIGNMENT): New macro.
2552 (mark_memory): Omit 3rd (offset) arg; caller changed.
2553 Don't assume EMACS_INT alignment is the same as pointer alignment.
2554
2555 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2556
2557 * keyboard.c (read_key_sequence_remapped): New var.
2558 (read_key_sequence): Compute remapping in the right buffer.
2559 (command_loop_1): Use read_key_sequence's remapping directly.
2560
2561 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2562
2563 * dired.c (file_name_completion): Don't expand file name.
2564 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2565 before checking file name handler.
2566
2567 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2568 they've been requested explicitly (bug#9591).
2569
2570 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2571
2572 * keymap.c (Fsingle_key_description): Use make_specified_string
2573 instead of build_string to build string from push_key_description.
2574 (Bug#5193)
2575
2576 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2577
2578 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2579 This fixes a Y2038 bug on 64-bit hosts.
2580 * buffer.c (reset_buffer):
2581 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2582 (Fclear_buffer_auto_save_failure):
2583 Use 0, not -1, to represent an unset failure time, since time_t
2584 might not be signed.
2585
2586 Remove dependency on glibc malloc internals.
2587 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2588 Move back here from lisp.h, but with their new implementations.
2589 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2590 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2591 * charset.c (charset_table_init): New static var.
2592 (syms_of_charset): Use it instead of xmalloc. This removes a
2593 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2594 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2595 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2596 Move back to alloc.c.
2597 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2598 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2599
2600 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2601
2602 * nsterm.m (windowDidResize): Call x_set_window_size only when
2603 ns_in_resize is true. Otherwise set pixelwidth/height and
2604 call change_frame_size (Bug#9628).
2605
2606 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 Port --enable-checking=all to Fedora 14 x86-64.
2609 * charset.c (syms_of_charset): Also account for glibc malloc's
2610 internal overhead when calculating the initial malloc maximum.
2611
2612 Port --enable-checking=all to Fedora 14 x86.
2613 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2614 Move to lisp.h.
2615 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2616 (overrun_check_realloc, overrun_check_free):
2617 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2618 That way, xmalloc returns a properly-aligned pointer even if
2619 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2620 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2621 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2622 into account when calculating the initial malloc maximum.
2623 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2624 Move here from alloc.c, so that charset.c can use it too.
2625 Properly align; the old code wasn't right for common 32-bit hosts
2626 when configured with --enable-checking=all.
2627 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2628 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2629
2630 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2631
2632 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2633 use EDOM.
2634
2635 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2636
2637 * xdisp.c (compute_display_string_end): If there's no display
2638 string at CHARPOS, return -1.
2639
2640 * bidi.c (bidi_fetch_char): When compute_display_string_end
2641 returns a negative value, treat the character as a normal
2642 character not covered by a display string. (Bug#9624)
2643
2644 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2645
2646 * lread.c (Fread_from_string): Fix typo in docstring.
2647
2648 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2649
2650 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2651 newline, reseat the iterator instead of bidi-iterating there one
2652 character at a time. (Bug#9610)
2653 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2654 TO_CHARPOS if the bidi iterator is at base embedding level.
2655
2656 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2657
2658 * lread.c (readevalloop): Use correct code for NBSP.
2659 (read1): Likewise. (Bug#9608)
2660
2661 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2662
2663 * dbusbind.c (Fdbus_register_signal): When service is not
2664 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2665
2666 2011-09-25 Glenn Morris <rgm@gnu.org>
2667
2668 * buffer.c (truncate-lines): Doc fix.
2669
2670 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2671
2672 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2673 (Fset_window_next_buffers): Doc fix.
2674
2675 2011-09-24 Glenn Morris <rgm@gnu.org>
2676
2677 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2678
2679 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 Fix minor problems found by static checking.
2682 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2683 * indent.c (Fvertical_motion): Fix == vs = typo.
2684
2685 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2686
2687 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2688 Default value is now t. Doc fix.
2689
2690 * indent.c (Fvertical_motion): Compute and apply the overshoot
2691 logic when moving up, not only when moving down. Fix the
2692 confusing name and values of the it_overshoot_expected variable;
2693 logic changes accordingly. (Bug#9254) (Bug#9549)
2694
2695 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2696 CHARPOS is covered by a display string which includes newlines.
2697 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2698 is covered by a display string with embedded newlines.
2699
2700 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2701
2702 * dbusbind.c (Fdbus_register_signal): Add match rule to
2703 Vdbus_registered_objects_table. (Bug#9581)
2704 (Fdbus_register_method, Vdbus_registered_objects_table):
2705 Fix docstring.
2706
2707 2011-09-24 Jim Meyering <meyering@redhat.com>
2708
2709 do not ignore write error for any output size
2710 The previous change was incomplete.
2711 While it makes emacs --batch detect the vast majority of stdout
2712 write failures, errors were still ignored whenever the output size is
2713 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2714 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2715 && echo FAIL: ignored write error
2716 FAIL: ignored write error
2717 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2718 && echo FAIL: ignored write error
2719 FAIL: ignored write error
2720 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2721
2722 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2723
2724 * emacs.c (Fkill_emacs): In noninteractive mode exit
2725 non-successfully if a write error occurred on stdout. (Bug#9574)
2726
2727 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2728
2729 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2730 the xassert test.
2731
2732 * dispextern.h (struct it): Update the comment documenting what
2733 can it->OBJECT be.
2734
2735 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2736
2737 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2738 a display string, extend search for cursor position to end of row.
2739 (find_row_edges): If the row ends in a newline from a display
2740 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2741 Handle the case of a display string with multiple newlines.
2742 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2743 non-empty line. Fixes confusing cursor motion with arrow keys at
2744 the beginning of a line that starts with whitespace.
2745
2746 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2747
2748 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2749 (bug#9493).
2750
2751 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2752
2753 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2754 boolean (Bug#9154).
2755
2756 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2757
2758 * xdisp.c (display_line): Record maximum and minimum buffer
2759 positions even if no glyphs were produced (e.g., by a zero-width
2760 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2761 buffer positions that will be removed from the glyph row because
2762 they don't fit.
2763 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2764 column is beyond frame width: don't subtract 1 "pixel" when
2765 computing width of the stretch.
2766 (reseat_at_next_visible_line_start): Undo the change made on
2767 2011-09-17 that saved paragraph information and restored it after
2768 the call to `reseat'. (Bug#9545)
2769
2770 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2771
2772 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2773 and turn window cursor on if cleared (Bug#9415).
2774
2775 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2776
2777 * search.c (boyer_moore): Take unibyte characters from pattern
2778 literally. (Bug#9458)
2779
2780 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2781
2782 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2783
2784 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 Fix minor problem found by static checking.
2787 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2788 initialized, to pacify gcc -Wuninitialized.
2789
2790 * fileio.c: Report proper errno when syscall falls.
2791 (Finsert_file_contents): Save and restore errno,
2792 so that report_file_error outputs the correct diagnostic.
2793 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2794
2795 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2796
2797 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2798
2799 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2800
2801 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2802 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2803
2804 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2805
2806 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2807 about the current paragraph and restore it after the call to reseat.
2808
2809 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2810 (bidi_find_paragraph_start): Search back for paragraph beginning
2811 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2812 (bidi_move_to_visually_next): Only trigger paragraph-related
2813 computations when the last character is a newline or at EOB, not
2814 just any NEUTRAL_B. (Bug#9470)
2815
2816 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2817 truncated lines if point is covered by a display string. (Bug#9524)
2818
2819 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2820
2821 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2822 (cons_to_x_long): New function.
2823 (lisp_data_to_selection_data): Use it. Correct the test for
2824 short-versus-long data; it was negated. Break out of vector
2825 loop, for efficiency, when a long datum is discovered.
2826
2827 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2828
2829 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2830
2831 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2832
2833 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2834 GCC PR/17406) by declaring this function with external scope.
2835
2836 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2837
2838 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2839 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2840
2841 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2842
2843 * editfns.c (Fformat): Correctly handle text properties on "%%".
2844
2845 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2846
2847 * xterm.c (x_draw_composite_glyph_string_foreground):
2848 * w32term.c (x_draw_composite_glyph_string_foreground):
2849 * term.c (encode_terminal_code):
2850 * composite.c (composition_update_it, get_composition_id):
2851 * xdisp.c (get_next_display_element)
2852 (fill_composite_glyph_string): Add comments about special meaning
2853 of TAB characters in a composition.
2854
2855 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2856
2857 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2858 This occurs when processing a multibyte format.
2859 Problem reported by Wolfgang Jenker.
2860
2861 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2862
2863 * xdisp.c (try_cursor_movement): Only check for exact match if
2864 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2865
2866 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 Remove unused external symbols.
2869 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2870 * xdisp.c (calc_pixel_width_or_height): Now static.
2871 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2872 * indent.c (check_display_width):
2873 * w32term.c: Fix comment to match code.
2874 * xterm.c, xterm.h (x_catching_errors): Remove.
2875
2876 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2877
2878 * xselect.c: Use signed conversions more consistently (Bug#9498).
2879 (selection_data_to_lisp_data): Assume incoming selection data are
2880 signed integers, not unsigned. This is to be consistent with
2881 outgoing selection data, which was modified to use signed integers
2882 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2883 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2884 expects long, not unsigned long.
2885
2886 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2887
2888 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2889 computation of loop end. Reported by Johan Bockgård
2890 <bojohan@gnu.org>.
2891
2892 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2893
2894 * frame.c (Fother_visible_frames_p): Function deleted.
2895
2896 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2897
2898 * indent.c (compute_motion): Process display vector front to back
2899 rather than the other way around. (Bug#2496)
2900
2901 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2902
2903 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2904
2905 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2906
2907 * minibuf.c (Fread_from_minibuffer): Doc fix.
2908
2909 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2910
2911 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2912 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2913
2914 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2915
2916 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2917 value for non-existent files.
2918
2919 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2920
2921 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2922 set its "size" to -1. This will set the modtime_size field of
2923 the corresponding buffer to -1, which is what
2924 verify-visited-file-modtime expects for files that do not exist.
2925 (Bug#9139)
2926
2927 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2928
2929 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2930 here ...
2931 * lisp.h: ... from here. push_key_description is no longer
2932 defined in keyboard.c, so its declaration should not be in
2933 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2934 logically belongs with push_key_description.
2935
2936 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 * buffer.h: Include <sys/types.h> instead of <time.h>.
2939 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2940 Problem reported by Herbert J. Skuhra.
2941
2942 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2943
2944 * xml.c (parse_region): Make the parsing work for
2945 non-comment-starting XML files again (bug#9144).
2946
2947 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2948
2949 * image.c (gif_load): Fix calculation of bottom and right corner.
2950 (Bug#9468)
2951
2952 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2953
2954 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2955 redisplay in small windows.
2956
2957 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2958
2959 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2960
2961 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2962
2963 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2964 Operate on live windows only.
2965
2966 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2967
2968 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2969
2970 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2971
2972 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2973 only under bidi iteration.
2974
2975 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2976
2977 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2978
2979 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2980
2981 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2982 Without this fix, the command to link temacs failed due to an
2983 undefined symbol __builtin_isnan. This is because
2984 /usr/include/iso/math_c99.h #defines isnan(x) to
2985 __builtin_isnan(x), but the bundled gcc, which identifies itself
2986 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2987 a __builtin_isnan.
2988 * floatfns.c (isnan): #undef, and then #define to a clone of
2989 what's in data.c.
2990 (Fisnan): Always define, since it's always available now.
2991 (syms_of_floatfns): Always define isnan at the Lisp level.
2992
2993 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2994
2995 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2996
2997 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3000 The previous code assumed that file offsets (off_t values) fit in
3001 EMACS_INT variables, which is not true on typical 32-bit hosts.
3002 The code messed up by falsely reporting buffer overflow in cases
3003 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3004 when "big" contains more than 2**29 bytes, even though this
3005 inserts just one byte and does not overflow the buffer.
3006 (Finsert_file_contents): Store file offsets as off_t
3007 values, not as EMACS_INT values. Check for overflow when
3008 converting between EMACS_INT and off_t. When checking for
3009 buffer overflow or for overlap, take the offsets into account.
3010 Don't use EMACS_INT for small values where int suffices.
3011 When checking for overlap, fix a typo: ZV was used where
3012 ZV_BYTE was intended.
3013 (Fwrite_region): Don't assume off_t fits into 'long'.
3014 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3015
3016 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3017
3018 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3019
3020 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3021
3022 sprintf-related integer and memory overflow issues (Bug#9412).
3023
3024 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3025 (esprintf, exprintf, evxprintf): New functions.
3026 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3027 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3028 (modify_event_symbol): Do not assume that the length of
3029 name_alist_or_stem is safe to alloca and fits in int.
3030 (Fexecute_extended_command): Likewise for function name and binding.
3031 (Frecursion_depth): Wrap around reliably on integer overflow.
3032 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3033 since some callers pass EMACS_INT values.
3034 (Fsingle_key_description): Don't crash if symbol name contains more
3035 than MAX_ALLOCA bytes.
3036 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3037 (get_minibuffer): Arg is now EMACS_INT, not int.
3038 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
3039 (esprintf, exprintf, evxprintf): New decls.
3040 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3041
3042 * dbusbind.c (signature_cat): New function.
3043 (xd_signature, Fdbus_register_signal):
3044 Do not overrun buffer; instead, report string overflow.
3045
3046 * dispnew.c (add_window_display_history): Don't overrun buffer.
3047 Truncate instead; this is OK since it's just a log.
3048
3049 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3050 even if the time zone offset is outlandishly large.
3051 Don't mishandle offset == INT_MIN.
3052
3053 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3054 when creating daemon; the previous buffer-overflow check was incorrect.
3055
3056 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3057 which has the guts of the old verror function.
3058
3059 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3060 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3061
3062 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3063 (font_unparse_xlfd): Don't blindly alloca long strings.
3064 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3065 fits in int, when using sprintf. Use single snprintf to count
3066 length of string rather than counting it via multiple sprintfs;
3067 that's simpler and more reliable.
3068 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3069 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3070 sprintf, in case result does not fit in int.
3071
3072 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3073 (fontset_from_font): Print it.
3074
3075 * frame.c (tty_frame_count): Now printmax_t, not int.
3076 (make_terminal_frame, set_term_frame_name): Print it.
3077 (x_report_frame_params): In X, window IDs are unsigned long,
3078 not signed long, so print them as unsigned.
3079 (validate_x_resource_name): Check for implausibly long names,
3080 and don't assume name length fits in 'int'.
3081 (x_get_resource_string): Don't blindly alloca invocation name;
3082 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3083 not fit in int.
3084
3085 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3086 (xg_check_special_colors, xg_set_geometry):
3087 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3088
3089 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3090 Use esprintf, not sprintf, in case result does not fit in int.
3091
3092 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3093 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3094 it as a large positive number.
3095 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3096 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3097
3098 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3099 in case result does not fit in int.
3100
3101 * print.c (float_to_string): Detect width overflow more reliably.
3102 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3103 buffer overrun. Don't assume list length fits in 'int'. Treat
3104 print length of 0 as 0, not as infinity; to be consistent with other
3105 uses of print length in this function. Don't overflow print length
3106 index. Don't assume hash table size fits in 'long', or that
3107 vectorlike size fits in 'unsigned long'.
3108
3109 * process.c (make_process): Use printmax_t, not int, to format
3110 process-name gensyms.
3111
3112 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3113
3114 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3115 to avoid potential buffer overrun.
3116
3117 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3118 if X resource line is longer than 512 bytes.
3119
3120 * xfns.c (x_window): Make sprintf buffer a bit bigger
3121 to avoid potential buffer overrun.
3122
3123 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3124
3125 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3126
3127 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3128
3129 Integer overflow fixes for scrolling, etc.
3130 Without these, Emacs silently mishandles large integers sometimes.
3131 For example, "C-u 4294967297 M-x recenter" was treated as if
3132 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3133
3134 * xdisp.c (try_window_id): Check Emacs fixnum range before
3135 converting to 'int'.
3136
3137 * window.c (window_scroll_line_based, Frecenter):
3138 Check that an Emacs fixnum is in range before assigning it to 'int'.
3139 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3140 values converted from Emacs fixnums.
3141 (Frecenter): Don't wrap around a line count if it is out of 'int'
3142 range; instead, treat it as an extreme value.
3143 (Fset_window_configuration, compare_window_configurations):
3144 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3145
3146 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3147 that can exceed INT_MAX. Check that EMACS_INT value is in range
3148 before assigning it to the (possibly-narrower) index.
3149 (match_limit): Don't assume that a fixnum can fit in 'int'.
3150
3151 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3152 exceed INT_MAX.
3153
3154 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3155 (Fvertical_motion): Don't wrap around LINES values that don't fit
3156 in 'int'. Instead, treat them as extreme values. This is good
3157 enough for windows, which can't have more than INT_MAX lines anyway.
3158
3159 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3160
3161 * Require libxml/parser.h to avoid compilation warning.
3162
3163 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3164
3165 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3166 since this reportedly can destroy thread storage.
3167
3168 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3169
3170 * syntax.c (find_defun_start): Update all cache variables if
3171 exiting early (Bug#9401).
3172
3173 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3174
3175 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3176
3177 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3178 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3179 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3180
3181 * term.c (tty_append_glyph): New function.
3182 (produce_stretch_glyph): Static function and its prototype deleted.
3183
3184 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3185 Add prototypes.
3186
3187 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3188
3189 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3190 when checking :margin (Bug#9390).
3191 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3192 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3193 so that the name doesn't mislead. All uses changed.
3194
3195 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3196
3197 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3198 set_tty_hooks.
3199
3200 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3201
3202 * xdisp.c (move_it_to): Don't bail out early when reaching
3203 position beyond to_charpos, if we are scanning backwards.
3204 (move_it_vertically_backward): When DY == 0, make sure we get to
3205 the first character in the line after the newline.
3206
3207 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3208
3209 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3210 (ccl_driver): Do not generate an out-of-range pointer.
3211 (Fccl_execute_on_string): Remove unnecessary check for
3212 integer overflow, noted by Stefan Monnier in
3213 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3214 Remove a FIXME that didn't need fixing.
3215 Simplify the newly-introduced buffer reallocation code.
3216
3217 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3218
3219 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3220
3221 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3222
3223 Integer and memory overflow issues (Bug#9196).
3224
3225 * doc.c (get_doc_string): Rework so that
3226 get_doc_string_buffer_size is the actual buffer size, rather than
3227 being 1 less than the actual buffer size; this makes xpalloc more
3228 convenient.
3229
3230 * image.c (x_allocate_bitmap_record, cache_image):
3231 * xselect.c (Fx_register_dnd_atom):
3232 Simplify previous changes by using xpalloc.
3233
3234 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3235 since either will do and ptrdiff_t is convenient with xpalloc.
3236
3237 * charset.c (charset_table_size)
3238 (struct charset_sort_data.priority): Now ptrdiff_t.
3239 (charset_compare): Don't overflow if priorities differ greatly.
3240 (Fsort_charsets): Don't assume list length fits in int.
3241 Check for size-calculation overflow when allocating sort data.
3242 (syms_of_charset): Allocate an initial charset table that is
3243 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3244
3245 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3246
3247 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3248 The actual value is always <= INT_MAX, and leaving it unsigned made
3249 overflow checking harder.
3250
3251 * dispextern.h (struct glyph_matrix.rows_allocated)
3252 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3253 with xpalloc. The values are still always <= INT_MAX.
3254
3255 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3256
3257 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3258 (SAFE_NALLOCA): New macro.
3259
3260 * region-cache.c (struct boundary.pos, find_cache_boundary)
3261 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3262 (set_cache_region, invalidate_region_cache)
3263 (revalidate_region_cache, know_region_cache, region_cache_forward)
3264 (region_cache_backward, pp_cache):
3265 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3266 so that ptrdiff_t * can be passed to xpalloc.
3267 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3268 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3269 (pp_cache): Don't assume cache_len fits in int.
3270 * region-cache.h: Adjust extern decls to match.
3271
3272 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3273 EMACS_INT, since either will do, for xpalloc.
3274
3275 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3276 (xnmalloc, xnrealloc, xpalloc): New functions.
3277
3278 * bidi.c (bidi_shelve_header_size): New constant.
3279 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3280 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3281
3282 * bidi.c (bidi_cache_shrink):
3283 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3284 (overlay_strings):
3285 Don't update size of array until after memory allocation succeeds,
3286 because xmalloc/xrealloc may not return.
3287 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3288 now that we have proper integer overflow checking.
3289 (record_overlay_string, overlay_strings): Catch overflows when
3290 calculating size of overlay_str_buf.
3291
3292 * callproc.c (Fcall_process): Check for size overflow when
3293 calculating size of args2.
3294 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3295 Normally we prefer signed values, but sticking with ptrdiff_t would
3296 require adding more-complicated checks.
3297
3298 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3299 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3300 Redo buffer-overflow calculations to avoid integer overflow.
3301 Add a FIXME comment where memory seems to be over-allocated.
3302
3303 * character.c (Fstring): Check for size-calculation overflow.
3304
3305 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3306 unnecessary integer overflow. Check for size overflow.
3307 (encode_coding_object): Don't update size until xmalloc succeeds.
3308
3309 * composite.c (get_composition_id): Check for overflow in glyph
3310 length calculations.
3311
3312 Integer and memory overflow fixes for display code.
3313 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3314 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3315 (scrolling_window): Check for overflow in size calculations.
3316 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3317 Don't assume glyph table len fits in int.
3318 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3319 (row_table_size): Now ptrdiff_t, not int.
3320 (scrolling_window): Avoid overflow in size calculations.
3321 Don't update size until allocation succeeds.
3322 * fns.c (concat): Check for overflow in size calculations.
3323 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3324 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3325 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3326
3327 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3328 (get_doc_string): Check for size calculation overflow.
3329 Don't update size until allocation succeeds.
3330 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3331 EMACS_INT, where ptrdiff_t will do.
3332 (Fsubstitute_command_keys): Check for string overflow.
3333
3334 * editfns.c (set_time_zone_rule): Don't assume environment length
3335 fits in int.
3336 (message_length): Now ptrdiff_t, not int.
3337 (Fmessage_box): Don't update size until allocation succeeds.
3338 Don't assume message length fits in int.
3339 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3340
3341 * emacs.c (main): Do not reallocate argv, since there is a null at
3342 the end that can be overwritten, and this way there's no need to
3343 worry about size-calculation overflow.
3344 (sort_args): Check for size-calculation overflow.
3345
3346 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3347 alloc succeeds.
3348 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3349
3350 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3351 (x_set_scroll_bar_width, x_figure_window_size):
3352 Check for integer overflow.
3353 (x_set_alpha): Do not assume XINT fits in int.
3354
3355 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3356 This is for the members text_lines, text_cols, total_lines, total_cols,
3357 where the system imposes an 'int' limit.
3358
3359 * fringe.c (Fdefine_fringe_bitmap):
3360 Don't update size until alloc works.
3361
3362 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3363 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3364
3365 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3366 Check for size-calculation overflow.
3367 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3368 do, as we prefer signed integers.
3369 (id_to_widget.max_size, id_to_widget.used)
3370 (xg_store_widget_in_map, xg_remove_widget_from_map)
3371 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3372 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3373 Use and return ptrdiff_t, not int.
3374 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3375 * gtkutil.h: Change prototypes to match the above.
3376
3377 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3378 are duplicate now that they've been promoted to lisp.h.
3379 (x_allocate_bitmap_record, x_alloc_image_color)
3380 (make_image_cache, cache_image, xpm_load):
3381 Don't update size until alloc is done.
3382 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3383 (x_detect_edges):
3384 Check for size calculation overflow.
3385 (ct_colors_allocated_max): New constant.
3386 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3387 overflow.
3388
3389 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3390 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3391 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3392 Use ptrdiff_t, not int, to count maps.
3393 (read_char_minibuf_menu_prompt): Check for overflow in size
3394 calculations. Don't update size until allocation succeeds.
3395 Redo calculations to avoid overflow.
3396 * keyboard.h: Change prototypes to match the above.
3397
3398 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3399 to count maps.
3400 (current_minor_maps): Check for size calculation overflow.
3401 * keymap.h: Change prototypes to match the above.
3402
3403 * lread.c (read1, init_obarray): Don't update size until alloc done.
3404
3405 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3406 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3407
3408 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3409 Now ptrdiff_t, not int.
3410 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3411 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3412
3413 * process.c (Fnetwork_interface_list): Check for overflow
3414 in size calculation.
3415
3416 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3417
3418 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3419 overflow. Don't bother calling xmalloc when xrealloc will do.
3420
3421 * search.c (Freplace_match): Check for size calculation overflow.
3422 (Fset_match_data): Don't assume list lengths fit in 'int'.
3423
3424 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3425 for command line length. Do not attempt to address one before the
3426 beginning of an array, as that's not portable.
3427
3428 * term.c (max_frame_lines): Remove; unused.
3429 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3430 not int.
3431 (encode_terminal_code, calculate_costs): Check for size
3432 calculation overflow.
3433 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3434 table lengths and related sizes. Don't update size until alloc
3435 done. Redo calculations to avoid overflow.
3436 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3437
3438 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3439 subtracting pointers.
3440 (gobble_line): Check for overflow more carefully. Don't update size
3441 until alloc done.
3442
3443 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3444 Don't update size until alloc done.
3445 Redo size calculations to avoid overflow.
3446 Check for size calculation overflow.
3447 (main) [DEBUG]: Fix typo in invoking tparam1.
3448
3449 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3450 Use ptrdiff_t, not int, for sizes.
3451 (store_mode_line_noprop_char): Don't update size until alloc done.
3452
3453 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3454 Use ptrdiff_t, not int, for sizes.
3455 (Finternal_make_lisp_face, cache_face):
3456 Check for size calculation overflow.
3457 (cache_face): Treat size calculation overflows as if they were
3458 memory exhaustion (the usual treatment), rather than aborting.
3459
3460 * xfns.c (x_encode_text, x_set_name_internal)
3461 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3462 sizes, since they can exceed INT_MAX in size. Check for size
3463 calculation overflow.
3464
3465 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3466 (xg_select): Check for size calculation overflow.
3467 Don't update size until alloc done.
3468
3469 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3470 as sprintf is limited to int lengths.
3471
3472 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3473 (X_LONG_MIN): New macros.
3474 Use them to make the following changes clearer.
3475 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3476 This change doesn't affect the value now, but it may help remind
3477 future maintainers not to raise the value too much later.
3478 (SELECTION_QUANTUM): Remove, replacing with ...
3479 (selection_quantum): ... new function, which avoids overflow.
3480 All uses changed.
3481 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3482 assumption that selection length fits in 'int'.
3483 (x_reply_selection_request, x_handle_selection_request)
3484 (x_get_window_property, receive_incremental_selection)
3485 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3486 (lisp_data_to_selection_data, clean_local_selection_data):
3487 Use ptrdiff_t, not int, to record length of selection.
3488 (x_reply_selection_request, x_get_window_property)
3489 (receive_incremental_selection, x_property_data_to_lisp):
3490 Redo calculations to avoid overflow.
3491 (x_reply_selection_request): When sending hint, ceiling it at
3492 X_LONG_MAX rather than relying on wraparound overflow to send
3493 something.
3494 (x_get_window_property, receive_incremental_selection)
3495 (lisp_data_to_selection_data, x_property_data_to_lisp):
3496 Check for size-calculation overflow.
3497 (x_get_window_property, receive_incremental_selection)
3498 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3499 Don't store size until memory allocation succeeds.
3500 (x_get_window_property): Plug memory leak on memory exhaustion.
3501 Don't double-block input; malloc is safe here. Don't assume 2**34
3502 - 4 fits in unsigned long. Add an xassert to check
3503 XGetWindowProperty overflow. Be more careful about overflow
3504 calculations, and distinguish size from memory overflow better.
3505 (receive_incremental_selection): When tracing, don't assume
3506 unsigned int is less than INT_MAX.
3507 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3508 harmful) conversions of unsigned short to int.
3509 (lisp_data_to_selection_data): Don't assume that integers
3510 in the range -65535 through -1 fit in an X unsigned short.
3511 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3512 result parameters unless successful. Rely on cons_to_unsigned
3513 to report problems with elements; the old code wasn't right anyway.
3514 (x_check_property_data): Check for int overflow; we cannot use
3515 a wider type due to X limits.
3516 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3517
3518 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3519
3520 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3521 (x_term_init): Check for size calculation overflow.
3522 (x_color_cells): Don't store size until memory allocation succeeds.
3523 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3524 Don't assume alloca size is less than MAX_ALLOCA.
3525 (x_term_init): Don't assume length fits in int (sprintf is limited
3526 to int size).
3527
3528 Use ptrdiff_t for composition IDs.
3529 * character.c (lisp_string_width):
3530 * composite.c (composition_table_size, n_compositions)
3531 (get_composition_id, composition_gstring_from_id):
3532 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3533 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3534 * window.c (Frecenter):
3535 Use ptrdiff_t, not int, for composition IDs.
3536 * composite.c (get_composition_id): Check for integer overflow.
3537 * composite.h: Adjust prototypes to match the above changes.
3538
3539 Use ptrdiff_t for hash table indexes.
3540 * category.c (hash_get_category_set):
3541 * ccl.c (ccl_driver):
3542 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3543 * coding.c (coding_system_charset_list, detect_coding_system):
3544 * coding.h (struct coding_system.id):
3545 * composite.c (get_composition_id, gstring_lookup_cache):
3546 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3547 * image.c (xpm_get_color_table_h):
3548 * lisp.h (hash_lookup, hash_put):
3549 * minibuf.c (Ftest_completion):
3550 Use ptrdiff_t for hash table indexes, not int (which is too
3551 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3552 32-bit --with-wide-int hosts).
3553
3554 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3555 Add a FIXME comment about memory leaks.
3556 (syms_of_charset): Don't assume xmalloc returns.
3557
3558 Don't assume that stated character widths fit in int.
3559 * character.c (Fchar_width, c_string_width, lisp_string_width):
3560 * character.h (CHAR_WIDTH):
3561 * indent.c (MULTIBYTE_BYTES_WIDTH):
3562 Use sanitize_char_width to avoid undefined and/or bad behavior
3563 with outlandish widths.
3564 * character.h (sanitize_tab_width): Rename from sanitize_width,
3565 now that we have two such functions. All uses changed.
3566 (sanitize_char_width): New inline function.
3567
3568 Don't assume that tab-width fits in int.
3569 * character.h (sanitize_width): New inline function.
3570 (SANE_TAB_WIDTH): New macro.
3571 (ASCII_CHAR_WIDTH): Use it.
3572 * indent.c (sane_tab_width): Remove. All uses replaced by
3573 SANE_TAB_WIDTH (current_buffer).
3574 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3575
3576 * fileio.c: Integer overflow issues with file modes.
3577 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3578
3579 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3580 Remove unreachable code.
3581 (read_hex, load_charset_map_from_file): Check for integer overflow.
3582
3583 * xterm.c: Don't go over XClientMessageEvent limit.
3584 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3585 (x_send_scroll_bar_event): Likewise. Check that the size does not
3586 exceed limits imposed by XClientMessageEvent, as well as the usual
3587 ptrdiff_t and size_t limits.
3588
3589 * keyboard.c: Overflow, signedness and related fixes.
3590 (make_lispy_movement): Use same integer type in forward decl
3591 that is used in the definition.
3592 (read_key_sequence, keyremap_step):
3593 Change bufsize argument back to int, undoing my 2011-03-30 change.
3594 We prefer signed types, and int is wide enough here.
3595 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3596 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3597 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3598 length, not size_t. Use ptrdiff_t for index, not int.
3599 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3600 possibility of integer overflow.
3601
3602 Overflow, signedness and related fixes for images.
3603
3604 * dispextern.h (struct it.stack[0].u.image.image_id)
3605 (struct_it.image_id, struct image.id, struct image_cache.size)
3606 (struct image_cache.used, struct image_cache.ref_count):
3607 * gtkutil.c (update_frame_tool_bar):
3608 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3609 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3610 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3611 * nsmenu.m (update_frame_tool_bar):
3612 * xdisp.c (calc_pixel_width_or_height):
3613 * xfns.c (image_cache_refcount):
3614 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3615 on typical 64-bit hosts.
3616
3617 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3618 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3619 Omit unnecessary casts to int.
3620 (parse_image_spec): Check that integers fall into 'int' range
3621 when the callers expect that.
3622 (image_ascent): Redo ascent calculation to avoid int overflow.
3623 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3624 (lookup_image): Remove unnecessary tests.
3625 (xbm_image_p): Locals are now of int, not EMACS_INT,
3626 since parse_image_check makes sure they fit into int.
3627 (png_load, gif_load, svg_load_image):
3628 Prefer int to unsigned where either will do.
3629 (tiff_handler): New function, combining the cores of the
3630 old tiff_error_handler and tiff_warning_handler.
3631 This function is rewritten to use vsnprintf and thereby avoid
3632 stack buffer overflows. It uses only the features of vsnprintf
3633 that are common to both POSIX and native Microsoft.
3634 (tiff_error_handler, tiff_warning_handler): Use it.
3635 (tiff_load, gif_load, imagemagick_load_image):
3636 Don't assume :index value fits in 'int'.
3637 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3638 (imagemagick_load_image): Check that crop parameters fit into
3639 the integer types that MagickCropImage accepts. Don't assume
3640 Vimagemagick_render_type has a nonnegative value. Don't assume
3641 size_t fits in 'long'.
3642 (gs_load): Use printmax_t to print the widest integers possible.
3643 Check for integer overflow when computing image height and width.
3644
3645 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3646
3647 * xdisp.c (redisplay_window): Don't force window start if point
3648 will be invisible in the resulting window. (Bug#9324)
3649
3650 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3651
3652 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3653 the display spec is of the form `(space ...)'.
3654 (handle_display_spec): Return the value returned by
3655 handle_single_display_spec, not just 1 or zero.
3656 (handle_single_display_spec): If the display spec is of the form
3657 `(space ...)', and specifies display in the text area, return 2
3658 rather than 1.
3659 (try_cursor_movement): Check for the need to scroll more
3660 accurately, and prefer exact match for point under bidi.
3661 Don't advance `row' beyond the last row of the window.
3662
3663 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3664 into disp_prop; all users changed.
3665
3666 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3667 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3668 for the text covered by the display property.
3669
3670 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3671
3672 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3673 Change return value to nil.
3674 (Frecord_buffer): Delete unused function.
3675
3676 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3677
3678 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3679 buffers, return left-to-right.
3680 (set_cursor_from_row): Consider candidate row a win if its glyph
3681 represents a newline and point is on that newline. Fixes cursor
3682 positioning on the newline at EOL of R2L text within L2R
3683 paragraph, and vice versa.
3684 (try_cursor_movement): Check continued rows, in addition to
3685 continuation rows. Fixes unwarranted scroll when point enters a
3686 continued line of R2L text within an L2R paragraph, or vice versa.
3687 (cursor_row_p): Consider the case of point being equal to
3688 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3689 from the end of a short line to the beginning of a continued line
3690 of R2L text within L2R paragraph.
3691 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3692 composed characters.
3693
3694 * bidi.c (bidi_check_type): Use xassert.
3695 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3696 members.
3697
3698 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3699
3700 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3701 a character.
3702
3703 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3704
3705 * nsfont.m (ns_otf_to_script): Fix typo.
3706
3707 2011-08-22 Kenichi Handa <handa@m17n.org>
3708
3709 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3710 extra slot even if the purpose is char-code-property-table.
3711
3712 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3713
3714 * xdisp.c (redisplay_window): When computing centering_position,
3715 account for the height of the header line. (Bug#8874)
3716
3717 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3718 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3719 candidate is selected by the mouse, and that candidate has a
3720 composed character under the mouse.
3721
3722 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3723 coordinates reported by pos-visible-in-window-p for a composed
3724 character in column zero.
3725
3726 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3727
3728 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3729
3730 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3731
3732 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3733 consider it a hit if to_charpos is anywhere in the range of the
3734 composed buffer positions.
3735
3736 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3737
3738 * image.c (gif_load): Don't assume that each subimage has the same
3739 dimensions as the base image. Handle disposal method that is
3740 "undefined" by the gif spec (Bug#9335).
3741
3742 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3743
3744 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3745 (Fcondition_case): Document `debug' symbol in error handler.
3746
3747 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3748
3749 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3750 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3751 from an Org mode buffer to a Speedbar frame.
3752
3753 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3754 a composition, take its buffer position from IT->cmp_it.charpos.
3755 Fixes cursor positioning at the beginning of a line that begins
3756 with a composed character.
3757
3758 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3759
3760 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3761 character bidirectional type, use STRONG_L instead. Fixes crashes
3762 in a buffer produced by `describe-categories'.
3763
3764 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3765 members before the level stack, so they would be saved and
3766 restored when copying iterator state. Fixes incorrect reordering
3767 around TABs covered by display properties.
3768
3769 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3770
3771 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3772
3773 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3774
3775 * eval.c (internal_condition_case, internal_condition_case_1)
3776 (internal_condition_case_2, internal_condition_case_n):
3777 Remove unnecessary aborts (Bug#9081).
3778
3779 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3780
3781 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3782 has no `load' handler, try opening the file locally. (Bug#9311)
3783
3784 2011-08-16 Ken Brown <kbrown@cornell.edu>
3785
3786 * gmalloc.c: Expand comment.
3787
3788 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3789
3790 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3791 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3792
3793 2011-08-16 Ken Brown <kbrown@cornell.edu>
3794
3795 Fix memory allocation problems in Cygwin build (Bug#9273).
3796
3797 * unexcw.c ( __malloc_initialized): Declare external variable.
3798 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3799
3800 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3801 New variables.
3802 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3803 dumped emacs.
3804 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3805 in the static heap.
3806 [CYGWIN] (special_realloc): New function.
3807 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3808 requests to realloc storage in the static heap.
3809
3810 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 * bidi.c (bidi_initialize): Remove unused local.
3813
3814 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3815
3816 * bidimirror.h:
3817 * biditype.h: Remove file.
3818 * makefile.w32-in ($(BLD)/bidi.$(O)):
3819 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3820
3821 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3822
3823 * chartab.c: Improve commentary for the uniprop_table API.
3824
3825 * bidi.c (bidi_paragraph_init): Support zero value of
3826 bidi_ignore_explicit_marks_for_paragraph_level.
3827 (bidi_initialize): Use uniprop_table instead of including
3828 biditype.h and bidimirror.h.
3829
3830 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3831 coordinates of the iterator when restoring from ppos_it.
3832 (Bug#9296)
3833
3834 2011-08-14 Kenichi Handa <handa@m17n.org>
3835
3836 * process.c (create_process): Call setup_process_coding_systems
3837 after the pid of the process is set to -1 (Bug#8162).
3838
3839 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3840
3841 * xdisp.c (move_it_in_display_line_to): Don't invoke
3842 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3843 ppos_it. Fixes vertical cursor motion when line beginning is
3844 covered by an image. (Bug#9296)
3845
3846 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3847
3848 * nsterm.h (ns_run_ascript): Declare.
3849 (NSAPP_DATA2_RUNASSCRIPT): Define.
3850
3851 * nsfns.m (as_script, as_result, as_status): New static variables.
3852 (ns_run_ascript): New function.
3853 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3854 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3855 the event loop. Get status from as_status (Bug#7276).
3856
3857 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3858 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3859 the event loop (Bug#7276).
3860
3861 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3862
3863 * gnutls.c (QCgnutls_bootprop_priority)
3864 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3865 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3866 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3867 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3868 (QCgnutls_bootprop_verify_hostname_error)
3869 (QCgnutls_bootprop_callbacks_verify): Rename from
3870 Qgnutls_bootprop_..., all uses changed.
3871
3872 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3873 uses changed.
3874
3875 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3876
3877 * xfaces.c (Qframe_set_background_mode): Now static.
3878 * dispextern.h (Qframe_set_background_mode): Remove decl.
3879
3880 * process.c (Fnetwork_interface_info): Declare local only if needed.
3881
3882 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3883
3884 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3885 (Fnetwork_interface_list): Allocate in increments of bytes instead
3886 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3887 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3888 sockaddr.
3889 (struct ifflag_def): notrailers is smart on OSX.
3890 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3891 Get hardware address with getifaddrs if available.
3892
3893 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3894
3895 * xdisp.c (iterate_out_of_display_property): xassert that
3896 IT->position is set to within IT->object's boundaries. Break from
3897 the loop as soon as EOB is reached; avoids infloops in redisplay
3898 when IT->position is set up wrongly due to some bug.
3899 Set IT->current to match the bidi iterator unconditionally.
3900 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3901 entry. Force push_it to save on the stack the current
3902 buffer/string position, to be restored by pop_it. Fix flags in
3903 the iterator structure wrt the object coming from a display
3904 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3905 properties. (Bug#9284)
3906
3907 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3908
3909 * fontset.c (fontset_get_font_group): Add proper type checks.
3910 (Bug#9172)
3911
3912 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3913
3914 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3915 and LC_VERSION_MIN_MACOSX.
3916 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3917 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3918
3919 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3920
3921 * xdisp.c (forward_to_next_line_start): Allow to use the
3922 no-display-properties-and-no-overlays under bidi display.
3923 Set disp_pos in the bidi iterator to avoid searches for display
3924 properties and overlays.
3925
3926 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3927
3928 * editfns.c (Fset_time_zone_rule): Document relationship with the
3929 setenv function.
3930
3931 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3932 the font entity extracted from the cache (Bug#8109).
3933
3934 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3935
3936 * composite.c (autocmp_chars): Don't reset point. That is done by
3937 restore_point_unwind (Bug#5984).
3938
3939 2011-08-07 Juri Linkov <juri@jurta.org>
3940
3941 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3942 to show the arg `TIME' instead of `TIMEVAL'.
3943
3944 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3945
3946 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3947 display property strides EOL and includes a newline, as in
3948 longlines-mode. (Bug#9254)
3949 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3950 word-wrap under bidirectional display. (Bug#9224)
3951
3952 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3953 is non-zero, even if the data buffer is NULL. Fixes a crash in
3954 vertical-motion with longlines-mode. (Bug#9254)
3955
3956 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3957
3958 * bidi.c <bidi_cache_total_alloc>: Now static.
3959 (bidi_initialize): Initialize bidi_cache_total_alloc.
3960
3961 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3962 cache. (Bug#9221)
3963
3964 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3965 amount allocated this far in `bidi_cache_total_alloc'.
3966 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3967 non-zero, only free the data buffer without restoring the cache
3968 contents. All callers changed.
3969
3970 * dispextern.h (bidi_unshelve_cache): Update prototype.
3971
3972 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3973 (move_it_in_display_line, move_it_to)
3974 (move_it_vertically_backward, move_it_by_lines): Replace the call
3975 to xfree to an equivalent call to bidi_unshelve_cache.
3976 (move_it_in_display_line_to): Fix logic of returning
3977 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3978
3979 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3980
3981 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3982 came from a string character with a `cursor' property. (Bug#9229)
3983
3984 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3985
3986 * Makefile.in (LIB_PTHREAD): New variable.
3987 (LIBES): Add LIB_PTHREAD (Bug#9216).
3988
3989 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3990 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3991
3992 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3993
3994 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3995
3996 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3997
3998 * xterm.c (x_find_topmost_parent): New function.
3999 (x_set_frame_alpha): Find topmost parent window with
4000 x_find_topmost_parent and set the property there also (bug#9181).
4001 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4002
4003 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4004
4005 * callproc.c (Fcall_process): Avoid vfork clobbering
4006 the local vars buffer, coding_systems, current_dir.
4007
4008 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4009
4010 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4011
4012 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4013
4014 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4015 so that it is not optimized away.
4016
4017 * xdisp.c (compute_display_string_pos): Remove unused local.
4018
4019 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4020
4021 Fix slow cursor motion and scrolling in large buffers with
4022 selective display, like Org Mode buffers. (Bug#9218)
4023
4024 * dispextern.h (struct bidi_it): New member disp_prop_p.
4025
4026 * xdisp.c: Remove one-slot cache of display string positions.
4027 (compute_display_string_pos): Accept an additional argument
4028 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4029 for a display string or property. If found, set DISP_PROP_P
4030 non-zero.
4031
4032 * bidi.c (bidi_fetch_char): Accept an additional argument
4033 DISP_PROP_P, and pass it to compute_display_string_pos.
4034 Only handle text covered by a display string if DISP_PROP_P is returned
4035 non-zero. All callers of bidi_fetch_char changed.
4036
4037 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4038
4039 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4040
4041 2010-12-03 Don March <don@ohspite.net>
4042
4043 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4044 last character M-[char] is translated to ESC [char] (bug#7541).
4045
4046 2011-08-02 Kenichi Handa <handa@m17n.org>
4047
4048 * lisp.h (uniprop_table): Extern it.
4049
4050 * chartab.c (uniprop_table): Make it non-static.
4051
4052 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4053
4054 * xdisp.c (forward_to_next_line_start): Accept additional argument
4055 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4056 on the newline.
4057 (reseat_at_next_visible_line_start): Use the bidi iterator state
4058 returned by forward_to_next_line_start to restore the state of
4059 it->bidi_it after backing up to previous newline. (Bug#9212)
4060
4061 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4062
4063 * regex.c (re_comp): Protoize.
4064 (re_exec): Fix return type.
4065 (regexec): Fix type of `ret'. (Bug#9203)
4066
4067 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4070 This is needed if max-image-size is a floating-point number.
4071
4072 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4073
4074 * print.c (print_object): Print empty symbol as ##.
4075
4076 * lread.c (read1): Read ## as empty symbol.
4077
4078 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4079
4080 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4081 setting frame foreground color (Bug#9175).
4082 (x_set_background_color): Likewise.
4083
4084 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4085 contents (Bug#9176).
4086 (EmacsTooltip -init): Remove bezels and add shadows to
4087 tooltip windows.
4088
4089 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4090 or scroll bar (Bug#8470).
4091
4092 * nsfont.m (nsfont_open): Remove assignment to voffset and
4093 unnecessary vars hshink, expand, hd, full_height, min_height.
4094 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4095
4096 * nsterm.h (nsfont_info): Remove voffset field.
4097
4098 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4099
4100 Implement strike-through and overline on NextStep (Bug#8863).
4101
4102 * nsfont.m (nsfont_open): Use underline position provided by font,
4103 instead of hard-coded value of 2.
4104 (nsfont_draw): Call ns_draw_text_decoration instead.
4105
4106 * nsterm.h: Add declaration for ns_draw_text_decoration.
4107
4108 * nsterm.m (ns_draw_text_decoration): New function for drawing
4109 underline, overline, and strike-through.
4110 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4111 ns_draw_text_decoration. Change treatment of cursor drawing to
4112 accommodate underlining, etc.
4113
4114 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4115
4116 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4117 default.
4118
4119 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4120
4121 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4122 Without this fix, if a signal arrives just after memory fills up,
4123 'malloc' might be invoked reentrantly.
4124
4125 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4126 In other words, assume that every image size is allowed, on non-X
4127 hosts. This assumption is probably wrong, but it lets Emacs compile.
4128
4129 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4130
4131 * regex.c (re_iswctype): Convert return values to boolean.
4132
4133 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4134
4135 * xdisp.c (compute_display_string_pos): Don't use cached display
4136 string position if the buffer had its restriction changed.
4137 (Bug#9184)
4138
4139 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4140
4141 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4142
4143 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4144
4145 Integer signedness and overflow and related fixes. (Bug#9079)
4146
4147 * bidi.c: Integer size and overflow fixes.
4148 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4149 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4150 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4151 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4152 (bidi_find_other_level_edge):
4153 Use ptrdiff_t instead of EMACS_INT where either will do.
4154 This works better on 32-bit hosts configured --with-wide-int.
4155 (bidi_cache_ensure_space): Check for size-calculation overflow.
4156 Use % rather than repeated addition, for better worst-case speed.
4157 Don't set bidi_cache_size until after xrealloc returns, because it
4158 might not return.
4159 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4160 (bidi_cache_ensure_space): Also check that the bidi cache size
4161 does not exceed that of the largest Lisp string or buffer. See Eli
4162 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4163
4164 * alloc.c (__malloc_size_t): Remove.
4165 All uses replaced by size_t. See Andreas Schwab's note
4166 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4167
4168 * image.c: Improve checking for integer overflow.
4169 (check_image_size): Assume that f is nonnull, since
4170 it is always nonnull in practice. This is one less thing to
4171 worry about when checking for integer overflow later.
4172 (x_check_image_size): New function, which checks for integer
4173 overflow issues inside X.
4174 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4175 This removes the need for a memory_full check.
4176 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4177 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4178 (xbm_read_bitmap_data): Change locals back to 'int', since
4179 their values must fit in 'int'.
4180 (xpm_load_image, png_load, tiff_load):
4181 Invoke x_create_x_image_and_pixmap earlier,
4182 to avoid much needless work if the image is too large.
4183 (tiff_load): Treat overly large images as if
4184 x_create_x_image_and_pixmap failed, not as malloc failures.
4185 (gs_load): Use x_check_image_size.
4186
4187 * gtkutil.c: Omit integer casts.
4188 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4189 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4190
4191 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4192
4193 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4194 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4195 would wrongly return t on a 64-bit host.
4196
4197 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4198 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4199 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4200 and therefore cause GCC to emit a bogus diagnostic in some cases.
4201
4202 * image.c: Integer signedness and overflow and related fixes.
4203 This is not an exhaustive set of fixes, but it's time to
4204 record what I've got.
4205 (lookup_pixel_color, check_image_size): Remove redundant decls.
4206 (check_image_size): Don't assume that arbitrary EMACS_INT values
4207 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4208 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4209 (tiff_load, imagemagick_load_image):
4210 Check for overflow in size calculations.
4211 (x_create_x_image_and_pixmap): Remove unnecessary test for
4212 xmalloc returning NULL; that can't happen.
4213 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4214 (xpm_color_bucket): Use better integer hashing function.
4215 (xpm_cache_color): Don't possibly over-allocate memory.
4216 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4217 (gif_memory_source):
4218 Use ptrdiff_t, not int or size_t, to record sizes.
4219 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4220 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4221 either works, as we prefer signed integers.
4222 (tiff_read_from_memory, tiff_write_from_memory):
4223 Return tsize_t, not size_t, since that's what the TIFF API wants.
4224 (tiff_read_from_memory): Don't fail simply because the read would
4225 go past EOF; instead, return a short read.
4226 (tiff_load): Omit no-longer-needed casts.
4227 (Fimagemagick_types): Don't assume size fits into 'int'.
4228
4229 Improve hashing quality when configured --with-wide-int.
4230 * fns.c (hash_string): New function, taken from sxhash_string.
4231 Do not discard information about ASCII character case; this
4232 discarding is no longer needed.
4233 (sxhash-string): Use it. Change sig to match it. Caller changed.
4234 * lisp.h: Declare it.
4235 * lread.c (hash_string): Remove, since we now use fns.c's version.
4236 The fns.c version returns a wider integer if --with-wide-int is
4237 specified, so this should help the quality of the hashing a bit.
4238
4239 * emacs.c: Integer overflow minor fix.
4240 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4241 Define only if GNU_LINUX.
4242 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4243
4244 * dispnew.c: Integer signedness and overflow fixes.
4245 Remove unnecessary forward decls, that were a maintenance hassle.
4246 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4247 All uses changed.
4248 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4249 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4250 (prepare_desired_row, line_draw_cost):
4251 Use int, not unsigned, where either works.
4252 (save_current_matrix, restore_current_matrix):
4253 Use ptrdiff_t, not size_t, where either works.
4254 (init_display): Check for overflow more accurately, and without
4255 relying on undefined behavior.
4256
4257 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4258 Remove, replacing with the new symbols in lisp.h. All uses changed.
4259 * fileio.c (make_temp_name):
4260 * filelock.c (lock_file_1, lock_file):
4261 * xdisp.c (message_dolog):
4262 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4263 Use pMd etc. instead.
4264 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4265 replacing the pWIDE etc. symbols removed from editfns.c.
4266
4267 * keyboard.h (num_input_events): Now uintmax_t.
4268 This is (very slightly) less likely to mess up due to wraparound.
4269 All uses changed.
4270
4271 * buffer.c: Integer signedness fixes.
4272 (alloc_buffer_text, enlarge_buffer_text):
4273 Use ptrdiff_t rather than size_t when either will do, as we prefer
4274 signed integers.
4275
4276 * alloc.c: Integer signedness and overflow fixes.
4277 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4278 (__malloc_size_t): Default to size_t, not to int.
4279 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4280 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4281 Prefer ptrdiff_t to size_t when either would do, as we prefer
4282 signed integers.
4283 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4284 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4285 Now const. Initialize with values that are in range even if char
4286 is signed.
4287 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4288 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4289 These functions do the right thing with sizes > 2**32.
4290 (check_depth): Now ptrdiff_t, not int.
4291 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4292 Adjust to new way of storing sizes. Check for size overflow bugs
4293 in rest of code.
4294 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4295 slightly wrong anyway, as it missed one instance of
4296 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4297 (refill_memory_reserve): Omit needless cast to size_t.
4298 (mark_object_loop_halt): Mark as externally visible.
4299
4300 * xselect.c: Integer signedness and overflow fixes.
4301 (Fx_register_dnd_atom, x_handle_dnd_message):
4302 Use ptrdiff_t, not size_t, since we prefer signed.
4303 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4304 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4305 x_dnd_atoms_size and x_dnd_atoms_length.
4306
4307 * doprnt.c: Prefer signed to unsigned when either works.
4308 * eval.c (verror):
4309 * doprnt.c (doprnt):
4310 * lisp.h (doprnt):
4311 * xdisp.c (vmessage):
4312 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4313 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4314 prefer signed arithmetic to avoid comparison confusion.
4315 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4316 but is a bit tricky.
4317
4318 Assume freestanding C89 headers, string.h, stdlib.h.
4319 * data.c, doprnt.c, floatfns.c, print.c:
4320 Include float.h unconditionally.
4321 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4322 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4323 * regex.c: Likewise for stddef.h, string.h.
4324 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4325 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4326 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4327 (STDC_HEADERS): Remove obsolete defines.
4328 * sysdep.c: Include limits.h unconditionally.
4329
4330 Assume support for memcmp, memcpy, memmove, memset.
4331 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4332 * regex.c (memcmp, memcpy):
4333 Remove; we assume C89 now.
4334
4335 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4336 (__malloc_safe_bcopy): Remove; no longer needed.
4337
4338 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4339 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4340 well either way, and we prefer signed to unsigned.
4341
4342 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4343
4344 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4345 closes the connection while we're reading (bug#9182).
4346
4347 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4348
4349 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4350 are specified (Bug#9168).
4351
4352 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4353
4354 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4355 Found by GCC static checking and --with-wide-int on a 32-bit host.
4356
4357 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4358
4359 * xdisp.c (compute_display_string_pos): Fix logic of caching
4360 previous display string position. Initialize cached_prev_pos to
4361 -1. Fixes slow-down at the beginning of a buffer.
4362
4363 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4364
4365 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4366 for attrs[LFACE_FONTSET_INDEX].
4367
4368 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4369
4370 * xml.c (parse_region): Remove unused local
4371 that was recently introduced.
4372
4373 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4374
4375 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4376 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4377
4378 * xdisp.c (move_it_in_display_line_to): Record the best matching
4379 position for TO_CHARPOS while scanning the line, and restore it on
4380 exit if none of the characters scanned was an exact match.
4381 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4382 when exact match is impossible due to invisible text, and the
4383 lines are truncated.
4384
4385 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4386
4387 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4388 for OSX >= 10.7.
4389
4390 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4391
4392 Fix a significant slow-down of cursor motion with C-n, C-p,
4393 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4394 auto-repeat under bidi redisplay in fontified buffers.
4395 * xdisp.c (compute_stop_pos_backwards): New function.
4396 (next_element_from_buffer): Call compute_stop_pos_backwards to
4397 find a suitable prev_stop when we find ourselves before
4398 base_level_stop.
4399 (reseat): Don't look for prev_stop, as that could mean a very long
4400 run.
4401 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4402 <cached_disp_overlay_modiff>: Cache for last found display string
4403 position.
4404 (compute_display_string_pos): Return the cached position if asked
4405 about the same buffer in the same area of character positions, and
4406 the buffer wasn't changed since the time the display string
4407 position was cached.
4408
4409 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4410
4411 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4412 is an integer, which is important for empty lines. (Bug#9149)
4413
4414 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4415
4416 * frame.c (Fmodify_frame_parameters): In tty case, update the
4417 default face if necessary (Bug#4238).
4418
4419 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4420
4421 * editfns.c (Fstring_to_char): No need to explain what a character
4422 is in the docstring (Bug#6576).
4423
4424 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4425
4426 * xml.c (parse_region): Make sure we always return a tree.
4427
4428 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4429
4430 * xml.c (parse_region): If a document contains only comments,
4431 return that, too.
4432
4433 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4434
4435 * xml.c (make_dom): Return comments, too.
4436
4437 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4438
4439 Port to OpenBSD.
4440 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4441 and the surrounding thread.
4442 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4443 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4444 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4445 timer goes off.
4446 * s/openbsd.h (BROKEN_SIGIO): Define.
4447 * unexelf.c (unexec) [__OpenBSD__]:
4448 Don't update the .mdebug section of the Alpha COFF symbol table.
4449
4450 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4451
4452 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4453 (bug#8460).
4454
4455 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4456
4457 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4458 This fixes some race conditions on the permissions of any newly
4459 created file.
4460
4461 * alloc.c (valid_pointer_p): Use pipe, not open.
4462 This fixes some permissions issues when debugging.
4463
4464 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4465 If fchown fails to set both uid and gid, try to set just gid,
4466 as that is sometimes allowed. Adjust the file's mode to eliminate
4467 setuid or setgid bits that are inappropriate if fchown fails.
4468
4469 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4470
4471 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4472 to compare Lisp_Objects.
4473 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4474 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4475 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4476
4477 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4478
4479 * lread.c (read_integer): Unread even EOF character.
4480 (read1): Likewise. Properly record start position of symbol.
4481
4482 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4483 symbol character follows.
4484
4485 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4486
4487 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4488 This works around a problem with the previous change to Fcopy_file.
4489 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4490 and without this change, GCC might complain about discarding
4491 fchown's return value.
4492
4493 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4494
4495 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4496
4497 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4498
4499 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4500
4501 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4502
4503 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4504 it's used from the C level.
4505
4506 * process.c: Use the same condition for POLL_FOR_INPUT in both
4507 keyboard.c and process.c (bug#1858).
4508
4509 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4510
4511 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4512 (Fgnutls_boot): Use it.
4513
4514 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4515
4516 * doc.c (Fsubstitute_command_keys): Revert last change.
4517
4518 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4519
4520 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4521 quotes the next character, and doesn't affect other longer
4522 sequences (bug#8935).
4523
4524 * lread.c (syms_of_lread): Clarify that is isn't only
4525 `eval-buffer' and `eval-defun' that's affected by
4526 `lexical-binding' (bug#8460).
4527
4528 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4529
4530 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4531 bidi redisplay when a line includes both an image and is truncated.
4532
4533 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4534
4535 Fix minor problems found by static checking.
4536 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4537 (elsz): Now a signed constant, not a size_t var. We prefer signed
4538 types to unsigned, to avoid integer comparison confusion. Without
4539 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4540 "cannot optimize loop, the loop counter may overflow", a symptom
4541 of the confusion.
4542 * indent.c (Fvertical_motion): Mark locals as initialized.
4543 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4544
4545 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4546
4547 * search.c (Fre_search_backward): Mention `case-fold-search' in
4548 all the re_search_* functions (bug#8138).
4549
4550 * keyboard.c (Fopen_dribble_file): Document when the file is
4551 closed (bug#8056).
4552
4553 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4554
4555 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4556 bidi_cache_idx.
4557
4558 Support bidi reordering of display and overlay strings.
4559 * xdisp.c (compute_display_string_pos)
4560 (compute_display_string_end): Accept additional argument STRING.
4561 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4562 (reseat_to_string): Initialize bidi_it->string.s and
4563 bidi_it->string.schars.
4564 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4565 NULL (avoids a crash in bidi_paragraph_init).
4566 Initialize itb.string.lstring.
4567 (init_iterator): Call bidi_init_it only of a valid
4568 buffer position was specified. Initialize paragraph_embedding to
4569 L2R.
4570 (reseat_to_string): Initialize the bidi iterator.
4571 (display_string): If we need to ignore text properties of
4572 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4573 original value of -1 will not work with bidi.)
4574 (compute_display_string_pos): First arg is now struct
4575 `text_pos *'; all callers changed. Support display properties on
4576 Lisp strings.
4577 (compute_display_string_end): Support display properties on Lisp
4578 strings.
4579 (init_iterator, reseat_1, reseat_to_string): Initialize the
4580 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4581 when iterating on a string not from display properties).
4582 (compute_display_string_pos, compute_display_string_end):
4583 Fix calculation of the object to scan. Fixes an error when using
4584 arrow keys.
4585 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4586 base_level_stop; instead, set base_level_stop to BEGV.
4587 Fixes crashes in vertical-motion.
4588 (next_element_from_buffer): Improve commentary for when
4589 the iterator is before prev_stop.
4590 (init_iterator): Initialize bidi_p from the default value of
4591 bidi-display-reordering, not from buffer-local value. Use the
4592 buffer-local value only if initializing for buffer iteration.
4593 (handle_invisible_prop): Support invisible properties on strings
4594 that are being bidi-reordered.
4595 (set_iterator_to_next): Support bidi reordering of C strings and
4596 Lisp strings.
4597 (next_element_from_string): Support bidi reordering of Lisp
4598 strings.
4599 (handle_stop_backwards): Support Lisp strings as well.
4600 (display_string): Support display of R2L glyph rows.
4601 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4602 (init_iterator): Don't initialize it->bidi_p for strings
4603 here.
4604 (reseat_to_string): Initialize it->bidi_p for strings here.
4605 (next_element_from_string, next_element_from_c_string)
4606 (next_element_from_buffer): Add xassert's for correspondence
4607 between IT's object being iterated and it->bidi_it.string
4608 structure.
4609 (face_before_or_after_it_pos): Support bidi iteration.
4610 (next_element_from_c_string): Handle the case of the first string
4611 character that is not the first one in the visual order.
4612 (get_visually_first_element): New function, refactored from common
4613 parts of next_element_from_buffer, next_element_from_string, and
4614 next_element_from_c_string.
4615 (tool_bar_lines_needed, redisplay_tool_bar)
4616 (display_menu_bar): Force left-to-right direction. Add a FIXME
4617 comment for making that be controlled by a user option.
4618 (push_it, pop_it): Save and restore the state of the
4619 bidi iterator. Save and restore the bidi_p flag.
4620 (pop_it): Iterate out of display property for string iteration as
4621 well.
4622 (iterate_out_of_display_property): Support iteration over strings.
4623 (handle_single_display_spec): Set up it->bidi_it for iteration
4624 over a display string, and call bidi_init_it.
4625 (handle_single_display_spec, next_overlay_string)
4626 (get_overlay_strings_1, push_display_prop): Set up the bidi
4627 iterator for displaying display or overlay strings.
4628 (forward_to_next_line_start): Don't use the shortcut if
4629 bidi-iterating.
4630 (back_to_previous_visible_line_start): If handle_display_prop
4631 pushed the iterator stack, restore the internal state of the bidi
4632 iterator by calling bidi_pop_it same number of times.
4633 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4634 and we are bidi-iterating, don't decrement the iterator position;
4635 instead, set the first_elt flag in the bidi iterator, to produce
4636 the same effect.
4637 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4638 (push_display_prop): xassert that we are iterating a buffer.
4639 (push_it, pop_it): Save and restore paragraph_embedding member.
4640 (handle_single_display_spec, next_overlay_string)
4641 (get_overlay_strings_1, reseat_1, reseat_to_string)
4642 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4643 correctly. Don't assume unibyte strings are not bidi-reordered.
4644 (compute_display_string_pos)
4645 (compute_display_string_end): Fix handling the case of C string.
4646 (push_it, pop_it): Save and restore from_disp_prop_p.
4647 (handle_single_display_spec, push_display_prop): Set the
4648 from_disp_prop_p flag.
4649 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4650 (pop_it): Call iterate_out_of_display_property only if we are
4651 popping after iteration over a string that came from a display
4652 property. Fix a typo in popping stretch info. Add an assertion
4653 for verifying that the iterator position is in sync with the bidi
4654 iterator.
4655 (handle_single_display_spec, get_overlay_strings_1)
4656 (push_display_prop): Fix initialization of paragraph direction for
4657 string when that of the parent object is not yet determined.
4658 (reseat_1): Call bidi_init_it to resync the bidi
4659 iterator with IT's position. (Bug#7616)
4660 (find_row_edges): If ROW->start.pos gives position
4661 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4662 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4663 Reset the from_disp_prop_p flag.
4664 (SAVE_IT, RESTORE_IT): New macros.
4665 (pos_visible_p, face_before_or_after_it_pos)
4666 (back_to_previous_visible_line_start)
4667 (move_it_in_display_line_to, move_it_in_display_line)
4668 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4669 (try_scrolling, redisplay_window, display_line): Use them when
4670 saving a temporary copy of the iterator and restoring it back.
4671 (back_to_previous_visible_line_start, reseat_1)
4672 (init_iterator): Empty the bidi cache "stack".
4673 (move_it_in_display_line_to): If iterator ended up at
4674 EOL, but we never saw any buffer positions smaller than
4675 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4676 motion in bidi-reordered lines.
4677 (move_it_in_display_line_to): Record prev_method and prev_pos
4678 immediately before the call to set_iterator_to_next. Fixes cursor
4679 motion in bidi-reordered lines with stretch glyphs and strings
4680 displayed in margins. (Bug#8133) (Bug#8867)
4681 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4682 TO_CHARPOS.
4683 (pos_visible_p): Support positions in bidi-reordered lines.
4684 Save and restore bidi cache.
4685
4686 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4687 (bidi_paragraph_info): Delete unused struct.
4688 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4689 (bidi_cache_start): New variable.
4690 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4691 to zero.
4692 (bidi_cache_fetch_state, bidi_cache_search)
4693 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4694 (bidi_cache_find, bidi_peek_at_next_level)
4695 (bidi_level_of_next_char, bidi_find_other_level_edge)
4696 (bidi_move_to_visually_next): Compare cache index with
4697 bidi_cache_start rather than with zero.
4698 (bidi_fetch_char): Accept new argument STRING; all callers
4699 changed. Support iteration over a string. Support strings with
4700 display properties. Support unibyte strings. Fix the type of
4701 `len' according to what STRING_CHAR_AND_LENGTH expects.
4702 (bidi_paragraph_init, bidi_resolve_explicit_1)
4703 (bidi_resolve_explicit, bidi_resolve_weak)
4704 (bidi_level_of_next_char, bidi_move_to_visually_next):
4705 Support iteration over a string.
4706 (bidi_set_sor_type, bidi_resolve_explicit_1)
4707 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4708 can now be zero (for strings); special values 0 and -1 were
4709 changed to -1 and -2, respectively.
4710 (bidi_char_at_pos): New function.
4711 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4712 Call it instead of FETCH_MULTIBYTE_CHAR.
4713 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4714 initialized to valid values.
4715 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4716 values.
4717 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4718 the test for valid cached positions. Fix the logic for looking up
4719 the sentinel state in the cache. GCPRO the Lisp string we are
4720 iterating.
4721 (bidi_push_it, bidi_pop_it): New functions.
4722 (bidi_initialize): Initialize the bidi cache start stack pointer.
4723 (bidi_cache_ensure_space): New function, refactored from part of
4724 bidi_cache_iterator_state. Don't assume the required size is just
4725 one BIDI_CACHE_CHUNK away.
4726 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4727 (bidi_count_bytes, bidi_char_at_pos): New functions.
4728 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4729 always valid if bidi_cache_idx is valid.
4730 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4731 is valid if it's going to be used.
4732 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4733 (bidi_cache_fetch_state, bidi_cache_search)
4734 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4735 (bidi_cache_iterator_state, bidi_cache_find)
4736 (bidi_find_other_level_edge, bidi_cache_start_stack):
4737 All variables related to cache indices are now EMACS_INT.
4738
4739 * dispextern.h (struct bidi_string_data): New structure.
4740 (struct bidi_it): New member `string'. Make flag members be 1-bit
4741 fields, and put them last in the struct.
4742 (compute_display_string_pos, compute_display_string_end):
4743 Update prototypes.
4744 (bidi_push_it, bidi_pop_it): Add prototypes.
4745 (struct iterator_stack_entry): New members bidi_p,
4746 paragraph_embedding, and from_disp_prop_p.
4747 (struct it): Member bidi_p is now a bit field 1 bit wide.
4748 (bidi_shelve_cache, bidi_unshelve_cache):
4749 Declare prototypes.
4750
4751 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4752 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4753 and vector-like objects.
4754
4755 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4756 cache around display iteration.
4757
4758 * window.c (Fwindow_end, window_scroll_pixel_based)
4759 (displayed_window_lines, Frecenter): Save and restore the bidi
4760 cache around display iteration.
4761
4762 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4763
4764 * editfns.c (Fdelete_region): Clarify the use of the named
4765 parameters (bug#6788).
4766
4767 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4768
4769 * indent.c (Fvertical_motion): Set and restore w->pointm when
4770 saving and restoring the window's buffer (Bug#9006).
4771
4772 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4773
4774 * editfns.c (Fstring_to_char): Clarify just what is returned
4775 (bug#6576). Text by Eli Zaretskii.
4776
4777 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4778
4779 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4780
4781 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4782
4783 * buffer.c (mmap_find): Fix a typo.
4784
4785 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4786
4787 Fix execution of x selection hooks.
4788 * xselect.c (Qx_lost_selection_functions)
4789 (Qx_sent_selection_functions): New vars.
4790 (syms_of_xselect): DEFSYM them.
4791 (x_handle_selection_request): Pass Qx_sent_selection_functions
4792 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4793 (x_handle_selection_clear,x_clear_frame_selections):
4794 Pass Qx_lost_selection_functions rather than
4795 Vx_lost_selection_functions to Frun_hook_with_args.
4796
4797 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4798
4799 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4800 The old code sometimes used this field without initializing it.
4801
4802 * alloc.c (gc_sweep): Don't read past end of array.
4803 In theory, the old code could also have corrupted Emacs internals,
4804 though it'd be very unlikely.
4805
4806 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4807
4808 * character.c (Fcharacterp): Don't advertise optional ignored
4809 argument. (Bug#4026)
4810
4811 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4812
4813 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4814 key" (bug#4257).
4815
4816 * window.c (Fset_window_start): Doc fix (bug#4199).
4817 (Fset_window_hscroll): Ditto.
4818
4819 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4820
4821 Fix minor new problems caught by GCC 4.6.1.
4822 * term.c (init_tty): Remove unused local.
4823 * xsettings.c (store_monospaced_changed): Define this function only
4824 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4825 not used otherwise.
4826
4827 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4828
4829 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4830
4831 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4832
4833 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4834 are the mini-buffer and the echo area (bug#3320).
4835
4836 * term.c (init_tty): Remove support for supdup, c10 and perq
4837 terminals, which are no longer supported (bug#1482).
4838
4839 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4840
4841 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4842
4843 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4844
4845 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4846 for non-popups (Bug#3642).
4847
4848 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4849
4850 * alloc.c (reset_malloc_hooks): Protoize.
4851 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4852 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4853 * cm.c (losecursor): Likewise.
4854 * data.c (fmod): Likewise.
4855 * dispnew.c (swap_glyphs_in_rows): Likewise.
4856 * emacs.c (memory_warning_signal): Likewise.
4857 * floatfns.c (float_error): Likewise.
4858 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4859 (otf_open, font_otf_capability, generate_otf_features)
4860 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4861 Likewise.
4862 * image.c (pbm_read_file): Likewise.
4863 * indent.c (string_display_width): Likewise.
4864 * intervals.c (check_for_interval, search_for_interval)
4865 (inc_interval_count, count_intervals, root_interval)
4866 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4867 * lread.c (defalias): Likewise.
4868 * ralloc.c (r_alloc_check): Likewise.
4869 * regex.c (set_image_of_range_1, set_image_of_range)
4870 (regex_grow_registers): Likewise.
4871 * sysdep.c (strerror): Likewise.
4872 * termcap.c (valid_filename_p, tprint, main): Likewise.
4873 * tparam.c (main): Likewise.
4874 * unexhp9k800.c (run_time_remap, save_data_space)
4875 (update_file_ptrs, read_header, write_header, calculate_checksum)
4876 (copy_file, copy_rest, display_header): Likewise.
4877 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4878 Likewise.
4879 * xdisp.c (check_it): Likewise.
4880 * xfaces.c (register_color, unregister_color, unregister_colors):
4881 Likewise.
4882 * xfns.c (print_fontset_result): Likewise.
4883 * xrdb.c (member, fatal, main): Likewise.
4884
4885 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4886
4887 Fix minor problems found by static checking (Bug#9031).
4888 * chartab.c (char_table_set_range, map_sub_char_table):
4889 Remove unused locals.
4890 (uniprop_table): Now static.
4891 * composite.c (_work_char): Remove unused static var.
4892
4893 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4894
4895 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4896
4897 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4898
4899 * gtkutil.c (qttip_cb): Remove code without function.
4900
4901 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4902
4903 * w32.c (pthread_sigmask): New stub.
4904
4905 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4906
4907 Use pthread_sigmask, not sigprocmask (Bug#9010).
4908 sigprocmask is portable only for single-threaded applications, and
4909 Emacs can be multi-threaded when it uses GTK.
4910 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4911 (LIBES): Use it.
4912 * callproc.c (Fcall_process):
4913 * process.c (create_process):
4914 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4915 Use pthread_sigmask, not sigprocmask.
4916
4917 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4918
4919 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4920 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4921 wrong (Bug#8591).
4922
4923 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4924
4925 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4926 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4927 (xg_hide_tooltip): Fix comment.
4928
4929 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4930 in registerServicesMenuSendTypes.
4931 (validRequestorForSendType): Don't check ns_return_types.
4932
4933 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4934 ns_return_type.
4935
4936 2011-07-08 Jason Rumney <jasonr@gnu.org>
4937
4938 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4939 SH_SHOW for hidden windows (Bug#5482).
4940
4941 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4942 frame struct members of non-existent frames (Bug#6284).
4943
4944 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4945
4946 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4947 variable firstTime not needed on OSX >= 10.6.
4948 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4949 >= 10.5. Use setKnobProportion, setDoubleValue.
4950
4951 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4952 (MAC_OS_X_VERSION_10_5): Define if not defined.
4953 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4954 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4955 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4956
4957 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4958 cString and lossyCString on OSX >= 10.4
4959
4960 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4961 sizeToFit on OSX >= 10.2.
4962
4963 * nsimage.m (allocInitFromFile): Don't use deprecated method
4964 bestRepresentationForDevice on OSX >= 10.6.
4965
4966 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4967 to avoid warning.
4968
4969 * emacs.c: Declare unexec_init_emacs_zone.
4970
4971 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4972
4973 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4974
4975 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4976 on svcsMenu (Bug#8842).
4977
4978 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4979 ns_return_types.
4980 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4981
4982 * nsterm.m (QUTF8_STRING): Declare.
4983 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4984 (validRequestorForSendType): Return type is (id).
4985 Change indexOfObjectIdenticalTo to indexOfObject.
4986 Check if we have local selection before returning self (Bug#8842).
4987 (writeSelectionToPasteboard): Put local selection into paste board
4988 if we have a local selection (Bug#8842).
4989 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4990
4991 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4992 (ns_get_local_selection): Declare.
4993
4994 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4995
4996 * keymap.c (describe_map_tree): Don't insert a double newline at
4997 the end of the buffer (bug#1169) and return whether we inserted
4998 something.
4999
5000 * callint.c (Fcall_interactively): Change "reading args" to
5001 "providing args" to try to clarify what it does (bug#1010).
5002
5003 2011-07-07 Kenichi Handa <handa@m17n.org>
5004
5005 * composite.c (composition_compute_stop_pos): Ignore a static
5006 composition starting before CHARPOS (Bug#8915).
5007
5008 * xdisp.c (handle_composition_prop): Likewise.
5009
5010 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5011
5012 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5013 (Bug#9015)
5014
5015 2011-07-07 Kenichi Handa <handa@m17n.org>
5016
5017 * character.h (unicode_category_t): New enum type.
5018
5019 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5020 (Qchar_code_property_table): New variable.
5021 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5022 (UNIPROP_COMPRESSED_FORM_P): New macros.
5023 (char_table_ascii): Uncompress the compressed values.
5024 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5025 Uncompress the compressed values.
5026 (sub_char_table_ref_and_range): Likewise.
5027 (char_table_ref_and_range): Uncompress the compressed values.
5028 (sub_char_table_set): New arg is_uniprop. Callers changed.
5029 Uncompress the compressed values.
5030 (sub_char_table_set_range): Args changed. Callers changed.
5031 (char_table_set_range): Adjuted for the above change.
5032 (map_sub_char_table): Delete args default_val and parent. Add arg
5033 top. Give decoded values to a Lisp function.
5034 (map_char_table): Adjust for the above change. Give decoded
5035 values to a Lisp function. Gcpro more variables.
5036 (uniprop_table_uncompress)
5037 (uniprop_decode_value_run_length): New functions.
5038 (uniprop_decoder, uniprop_decoder_count): New variables.
5039 (uniprop_get_decoder, uniprop_encode_value_character)
5040 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5041 New functions.
5042 (uniprop_encoder, uniprop_encoder_count): New variables.
5043 (uniprop_get_encoder, uniprop_table)
5044 (Funicode_property_table_internal, Fget_unicode_property_internal)
5045 (Fput_unicode_property_internal): New functions.
5046 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5047 Sunicode_property_table_internal, Sget_unicode_property_internal,
5048 and Sput_unicode_property_internal. Defvar_lisp
5049 char-code-property-alist.
5050
5051 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5052 Vunicode_category_table.
5053
5054 * font.c (font_range): Adjust for the change of
5055 Vunicode_category_table.
5056
5057 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5058
5059 * m/iris4d.h: Remove file, move contents ...
5060 * s/irix6-5.h: ... here.
5061
5062 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5063
5064 Remove unportable assumption about struct layout (Bug#8884).
5065 * alloc.c (mark_buffer):
5066 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5067 (clone_per_buffer_values): Don't assume that
5068 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5069 This isn't true in general, and it's particularly not true
5070 if Emacs is configured with --with-wide-int.
5071 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5072 New macros, used in the buffer.c change.
5073
5074 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5075
5076 * xsettings.c: Use both GConf and GSettings if both are available.
5077 (store_config_changed_event): Add comment.
5078 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5079 (store_tool_bar_style_changed): New functions.
5080 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5081 (struct xsettings): Move font inside HAVE_XFT.
5082 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5083 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5084 Move inside HAVE_XFT.
5085 (something_changed_gsettingsCB): Rename from something_changedCB.
5086 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5087 also.
5088 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5089 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5090 (something_changed_gconfCB): Rename from something_changedCB.
5091 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5092 (parse_settings): Move check for font inside HAVE_XFT.
5093 (read_settings, apply_xft_settings): Add comment.
5094 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5095 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5096 call store_font_name_changed.
5097 (xft_settings_event): Add comment.
5098 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5099 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5100 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5101 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5102 (xsettings_initialize): Call init_gsettings last.
5103 (xsettings_get_system_font, xsettings_get_system_normal_font):
5104 Add comment.
5105
5106 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5107
5108 Random fixes. E.g., (random) never returned negative values.
5109 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5110 subseconds part to the entropy, as that's a bit more random.
5111 Prefer signed to unsigned, since the signedness doesn't matter and
5112 in general we prefer signed. When given a limit, use a
5113 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5114 latter isn't right if USE_2_TAGS_FOR_INTS.
5115 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5116 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5117
5118 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5119
5120 * textprop.c (text_property_stickiness):
5121 Obey Vtext_property_default_nonsticky.
5122 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5123 * w32fns.c (syms_of_w32fns):
5124 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5125
5126 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5127
5128 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5129 This is more efficient than Ffile_directory_p and avoids a minor race.
5130
5131 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5132
5133 * buffer.c (Foverlay_put): Say what the return value is
5134 (bug#7835).
5135
5136 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5137 is a directory before asking whether to use the file name
5138 (bug#7564).
5139 (barf_or_query_if_file_exists): Make the "File is a directory"
5140 error be more correct.
5141
5142 * fns.c (Frequire): Remove the mention of the .gz files, since
5143 that's installation-specific, but keep the mention of
5144 `get-load-suffixes'.
5145
5146 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5147
5148 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5149 Report string overflow if the output is too long.
5150
5151 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
5152
5153 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5154 (syms_of_gnutls): Remove duplicate DEFSYM for
5155 Qgnutls_bootprop_verify_hostname_error, an error for
5156 Qgnutls_bootprop_verify_error (which is no longer used).
5157
5158 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5159 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5160 Also (re)move comments that are misplaced or no longer relevant.
5161
5162 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5163
5164 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5165
5166 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5167
5168 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5169 and background color parameters if they have been changed.
5170
5171 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5172
5173 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5174
5175 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5176
5177 * xsettings.c (SYSTEM_FONT): Define only when used.
5178 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5179
5180 * keymap.c (access_keymap_1): Now static.
5181
5182 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5183
5184 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5185 leave any prefix arg for the up event (Bug#1586).
5186
5187 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5188
5189 * lread.c (syms_of_lread): Mention single symbols defined by
5190 `defvar' or `defconst' (bug#7154).
5191
5192 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5193 (Frequire): Mention get-load-suffixes.
5194
5195 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5196
5197 * window.h (window): Remove clone_number slot.
5198 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5199 Remove.
5200 (make_parent_window, make_window, saved_window)
5201 (Fset_window_configuration, save_window_save): Don't deal with
5202 clone numbers.
5203 * buffer.c (Qclone_number): Remove declaration.
5204 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5205
5206 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5207
5208 Add multiple inheritance to keymaps.
5209 * keymap.c (Fmake_composed_keymap): New function.
5210 (Fset_keymap_parent): Simplify.
5211 (fix_submap_inheritance): Remove.
5212 (access_keymap_1): New function extracted from access_keymap to handle
5213 embedded parents and handle lists of maps.
5214 (access_keymap): Use it.
5215 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5216 (Fcopy_keymap): Handle embedded parents.
5217 (Fcommand_remapping, define_as_prefix): Simplify.
5218 (Fkey_binding): Simplify.
5219 (syms_of_keymap): Move minibuffer-local-completion-map,
5220 minibuffer-local-filename-completion-map,
5221 minibuffer-local-must-match-map, and
5222 minibuffer-local-filename-must-match-map to Elisp.
5223 (syms_of_keymap): Defsubr make-composed-keymap.
5224 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5225 (parse_menu_item): Trivial simplification.
5226
5227 2011-07-01 Glenn Morris <rgm@gnu.org>
5228
5229 * Makefile.in (SETTINGS_LIBS): Fix typo.
5230
5231 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5232
5233 * coding.c (Fencode_coding_string): Record the last coding system
5234 used, as the function doc string says (bug#8738).
5235
5236 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5237
5238 * xsettings.c (store_monospaced_changed): Take new font as arg and
5239 check for change against current_mono_font.
5240 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5241 (emacs_settings_constructor, emacs_settings_get_property)
5242 (emacs_settings_set_property, emacs_settings_class_init)
5243 (emacs_settings_init, gsettings_obj): Remove.
5244 (something_changedCB): New function for HAVE_GSETTINGS.
5245 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5246 with value as argument.
5247 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5248 g_settings_new (Bug#8967). Do not create gsettings_obj.
5249 Remove calls to g_settings_bind. Connect something_changedCB to
5250 "changed".
5251
5252 * xgselect.c: Add defined (HAVE_GSETTINGS).
5253 (xgselect_initialize): Ditto.
5254
5255 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5256 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5257 xg_select.
5258
5259 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5260
5261 * eval.c (struct backtrace): Simplify and port the data structure.
5262 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5263 signed bit field, as this assumption is not portable and it makes
5264 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5265 "char debug_on_exit : 1" as this is not portable either; instead,
5266 use the portable "unsigned int debug_on_exit : 1". Remove unused
5267 member evalargs. Remove obsolete comments about cc bombing out.
5268
5269 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5270
5271 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5272 Let HAVE_GSETTINGS override HAVE_GCONF.
5273 (store_monospaced_changed): New function.
5274 (EMACS_SETTINGS): A new type derived from GObject to handle
5275 GSettings notifications.
5276 (emacs_settings_constructor, emacs_settings_get_property)
5277 (emacs_settings_set_property, emacs_settings_class_init):
5278 New functions.
5279 (gsettings_client, gsettings_obj): New variables.
5280 (GSETTINGS_SCHEMA): New define.
5281 (something_changedCB): Call store_monospaced_changed.
5282 (init_gsettings): New function.
5283 (xsettings_initialize): Call init_gsettings.
5284 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5285 to NULL.
5286
5287 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5288 GCONF_CFLAGS/LIBS.
5289
5290 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5291
5292 * window.c (resize_root_window, grow_mini_window)
5293 (shrink_mini_window): Rename Qresize_root_window to
5294 Qwindow_resize_root_window and Qresize_root_window_vertically to
5295 Qwindow_resize_root_window_vertically.
5296
5297 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5298
5299 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5300
5301 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5302
5303 * makefile.w32-in: Redesign dependencies so they reflect more
5304 clearly which files are directly included by each source file,
5305 and not through other includes.
5306
5307 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5308
5309 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5310 (sort_overlays, overlay_strings): When an overlay's clone number
5311 matches the window's clone number process the overlay even if
5312 the overlay's window property doesn't match the current window.
5313
5314 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5315 (Fwindow_hchild): Rename to Fwindow_left_child.
5316 (Fwindow_next): Rename to Fwindow_next_sibling.
5317 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5318 (resize_window_check): Rename to window_resize_check.
5319 (resize_window_apply): Rename to window_resize_apply.
5320 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5321 (Fdelete_other_windows_internal, resize_frame_windows)
5322 (Fsplit_window_internal, Fdelete_window_internal)
5323 (grow_mini_window, shrink_mini_window)
5324 (Fresize_mini_window_internal): Fix callers accordingly.
5325
5326 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5327
5328 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5329 (emacs_fixed_set_min_size): Remove.
5330 (emacs_fixed_new): Take frame as argument.
5331
5332 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5333 (_EmacsFixedPrivate): Remove minwidth/height.
5334 Add struct frame *f.
5335 (emacs_fixed_init): Initialize priv->f.
5336 (get_parent_class, emacs_fixed_set_min_size): Remove.
5337 (emacs_fixed_new): Set priv->f to argument.
5338 (emacs_fixed_get_preferred_width)
5339 (emacs_fixed_get_preferred_height): Use min_width/height from
5340 frames size_hint to set minimum and natural (Bug#8919).
5341 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5342 and use min_width/height from frames size_hint to set
5343 min_width/height (Bug#8919).
5344
5345 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5346 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5347 Fix indentation.
5348
5349 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5350
5351 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5352 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5353 called at ZV.
5354
5355 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5356
5357 * process.c (wait_reading_process_output): Bypass select if
5358 waiting for a cell while ignoring keyboard input, and input is
5359 pending. Suggested by Jan Djärv (Bug#8869).
5360
5361 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5362
5363 Use gnulib's dup2 module instead of rolling our own.
5364 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5365
5366 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5367
5368 * dispnew.c (scrolling_window): Before scrolling, turn off a
5369 mouse-highlight in the window being scrolled.
5370
5371 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5372
5373 Move DEFSYM to lisp.h and use everywhere.
5374
5375 * character.h (DEFSYM): Move declaration...
5376 * lisp.h (DEFSYM): ...here.
5377
5378 * gnutls.c:
5379 * minibuf.c:
5380 * w32menu.c:
5381 * w32proc.c:
5382 * w32select.c: Don't include character.h.
5383
5384 * alloc.c (syms_of_alloc):
5385 * buffer.c (syms_of_buffer):
5386 * bytecode.c (syms_of_bytecode):
5387 * callint.c (syms_of_callint):
5388 * casefiddle.c (syms_of_casefiddle):
5389 * casetab.c (init_casetab_once):
5390 * category.c (init_category_once, syms_of_category):
5391 * ccl.c (syms_of_ccl):
5392 * cmds.c (syms_of_cmds):
5393 * composite.c (syms_of_composite):
5394 * dbusbind.c (syms_of_dbusbind):
5395 * dired.c (syms_of_dired):
5396 * dispnew.c (syms_of_display):
5397 * doc.c (syms_of_doc):
5398 * editfns.c (syms_of_editfns):
5399 * emacs.c (syms_of_emacs):
5400 * eval.c (syms_of_eval):
5401 * fileio.c (syms_of_fileio):
5402 * fns.c (syms_of_fns):
5403 * frame.c (syms_of_frame):
5404 * fringe.c (syms_of_fringe):
5405 * insdel.c (syms_of_insdel):
5406 * keymap.c (syms_of_keymap):
5407 * lread.c (init_obarray, syms_of_lread):
5408 * macros.c (syms_of_macros):
5409 * msdos.c (syms_of_msdos):
5410 * print.c (syms_of_print):
5411 * process.c (syms_of_process):
5412 * search.c (syms_of_search):
5413 * sound.c (syms_of_sound):
5414 * syntax.c (init_syntax_once, syms_of_syntax):
5415 * terminal.c (syms_of_terminal):
5416 * textprop.c (syms_of_textprop):
5417 * undo.c (syms_of_undo):
5418 * w32.c (globals_of_w32):
5419 * window.c (syms_of_window):
5420 * xdisp.c (syms_of_xdisp):
5421 * xfaces.c (syms_of_xfaces):
5422 * xfns.c (syms_of_xfns):
5423 * xmenu.c (syms_of_xmenu):
5424 * xsettings.c (syms_of_xsettings):
5425 * xterm.c (syms_of_xterm): Use DEFSYM.
5426
5427 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5428
5429 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5430
5431 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5432
5433 Integer and buffer overflow fixes (Bug#8873).
5434
5435 * print.c (printchar, strout): Check for string overflow.
5436 (PRINTPREPARE, printchar, strout):
5437 Don't set size unless allocation succeeds.
5438
5439 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5440 for sizes. Check for string overflow more accurately.
5441 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5442
5443 * macros.c: Integer and buffer overflow fixes.
5444 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5445 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5446 Use ptrdiff_t, not int, for sizes.
5447 Don't increment bufsize until after realloc succeeds.
5448 Check for size-calculation overflow.
5449 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5450
5451 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5452
5453 * lread.c: Integer overflow fixes.
5454 (read_integer): Radix is now EMACS_INT, not int,
5455 to improve quality of diagnostics for out-of-range radices.
5456 Calculate buffer size correctly for out-of-range radices.
5457 (read1): Check for integer overflow in radices, and in
5458 read-circle numbers.
5459 (read_escape): Avoid int overflow.
5460 (Fload, openp, read_buffer_size, read1)
5461 (substitute_object_recurse, read_vector, read_list, map_obarray):
5462 Use ptrdiff_t, not int, for sizes.
5463 (read1): Use EMACS_INT, not int, for sizes.
5464 Check for size overflow.
5465
5466 * image.c (cache_image): Check for size arithmetic overflow.
5467
5468 * lread.c: Integer overflow issues.
5469 (saved_doc_string_size, saved_doc_string_length)
5470 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5471 Now ptrdiff_t, not int.
5472 (read1): Don't assume doc string length fits in int. Check for
5473 out-of-range doc string lengths.
5474 (read_list): Don't assume file position fits in int.
5475 (read_escape): Check for hex character overflow.
5476
5477 2011-06-22 Leo Liu <sdl.web@gmail.com>
5478
5479 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5480 Move to minibuffer.el.
5481
5482 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5483
5484 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5485 The following patches are for when GLYPH_DEBUG && !XASSERT.
5486 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5487 * dispnew.c (flush_stdout):
5488 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5489 Mark as externally visible.
5490 * dispnew.c (check_window_matrix_pointers): Now static.
5491 * dispnew.c (window_to_frame_vpos):
5492 * xfns.c (unwind_create_frame):
5493 * xterm.c (x_check_font): Remove unused local.
5494 * scroll.c (CHECK_BOUNDS):
5495 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5496 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5497 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5498 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5499 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5500 Now static.
5501 (debug_method_add): Use va_list and vsprintf rather than relying
5502 on undefined behavior with wrong number of arguments.
5503 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5504 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5505 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5506 since we're not interested in debugging glyphs with old libraries.
5507 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5508 GCC 4.6.0's static checking.
5509
5510 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5511
5512 Integer overflow and signedness fixes (Bug#8873).
5513 A few related buffer overrun fixes, too.
5514
5515 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5516
5517 * dispextern.h (struct face.stipple):
5518 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5519 (x_bitmap_mask, x_allocate_bitmap_record)
5520 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5521 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5522 (x_create_bitmap_from_xpm_data):
5523 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5524 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5525 (.bitmaps_last):
5526 * xfaces.c (load_pixmap):
5527 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5528 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5529 (.bitmaps_last, struct x_output.icon_bitmap):
5530 Use ptrdiff_t, not int, for bitmap indexes.
5531 (x_allocate_bitmap_record): Check for size overflow.
5532 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5533
5534 Use ptrdiff_t, not int, for overlay counts.
5535 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5536 * editfns.c (overlays_around, get_pos_property):
5537 * textprop.c (get_char_property_and_overlay):
5538 * xdisp.c (next_overlay_change, note_mouse_highlight):
5539 * xfaces.c (face_at_buffer_position):
5540 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5541 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5542 (Fnext_overlay_change, Fprevious_overlay_change)
5543 (mouse_face_overlay_overlaps, Foverlays_in):
5544 Use ptrdiff_t, not int, for sizes.
5545 (overlays_at, overlays_in): Check for size-calculation overflow.
5546
5547 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5548
5549 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5550 (x_session_initialize): Do not assume string length fits in int.
5551
5552 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5553 This is unlikely, but can occur if DPI is outlandish.
5554
5555 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5556 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5557
5558 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5559 * xrdb.c (magic_file_p, search_magic_path):
5560 Omit last arg SUFFIX; it was always 0. All callers changed.
5561 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5562
5563 * xfont.c (xfont_match): Avoid need for strlen.
5564
5565 * xfns.c: Don't assume strlen fits in int.
5566 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5567
5568 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5569 not unsigned long, as we prefer signed integers. All callers changed.
5570 Detect integer overflow in repeat count.
5571 (message_dolog): Don't assume print length fits in 39 bytes.
5572 (display_mode_element): Don't assume strlen fits in int.
5573
5574 * termcap.c: Don't assume sizes fit in int and never overflow.
5575 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5576 (gobble_line): Check for size-calculation overflow.
5577
5578 * minibuf.c (Fread_buffer):
5579 * lread.c (intern, intern_c_string):
5580 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5581 Don't assume string length fits in int.
5582
5583 * keyboard.c (parse_tool_bar_item):
5584 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5585
5586 * font.c: Don't assume string length fits in int.
5587 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5588 Use ptrdiff_t, not int.
5589 (font_intern_prop): Don't assume string length fits in int.
5590 Don't assume integer property fits in fixnum.
5591 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5592
5593 * filelock.c: Fix some buffer overrun and integer overflow issues.
5594 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5595 Reformulate so as not to need the command string.
5596 Invoke gzip -cd rather than gunzip, as it's more portable.
5597 (lock_info_type, lock_file_1, lock_file):
5598 Don't assume pid_t and time_t fit in unsigned long.
5599 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5600 (current_lock_owner): Prefer signed type for sizes.
5601 Use memcpy, not strncpy, where memcpy is what is really wanted.
5602 Don't assume (via atoi) that time_t and pid_t fit in int.
5603 Check for time_t and/or pid_t out of range, e.g., via a network share.
5604 Don't alloca where an auto var works fine.
5605
5606 * fileio.c: Fix some integer overflow issues.
5607 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5608 Don't assume string length fits in int.
5609 (directory_file_name): Don't assume string length fits in long.
5610 (make_temp_name): Don't assume pid fits in int, or that its print
5611 length is less than 20.
5612
5613 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5614
5615 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5616
5617 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5618
5619 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5620 We prefer signed integers, even for size calculations.
5621
5622 * emacs.c: Don't assume string length fits in 'int'.
5623 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5624 (main): Don't invoke strlen when not needed.
5625
5626 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5627 (XD_DEBUG_MESSAGE): Don't waste a byte.
5628
5629 * callproc.c (getenv_internal_1, getenv_internal)
5630 (Fgetenv_internal):
5631 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5632
5633 * lread.c (invalid_syntax): Omit length argument.
5634 All uses changed. This doesn't fix a bug, but it simplifies the
5635 code away from its former Hollerith-constant appearance, and it's
5636 one less 'int' to worry about when looking at integer-overflow issues.
5637 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5638
5639 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5640 This didn't break anything, but it didn't help either.
5641 It's confusing to put a bogus integer in a place where the actual
5642 value does not matter.
5643 (LIST_END_P): Remove unused macro and its bogus comment.
5644 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5645
5646 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5647 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5648 implementation.
5649 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5650 We prefer signed types, and the value cannot exceed the EMACS_INT
5651 range anyway (because otherwise the length would not be representable).
5652 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5653 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5654 This avoids a GCC warning when WIDE_EMACS_INT.
5655
5656 * indent.c (sane_tab_width): New function.
5657 (current_column, scan_for_column, Findent_to, position_indentation)
5658 (compute_motion): Use it. This is just for clarity.
5659 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5660
5661 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5662
5663 * lisp.h (lint_assume): New macro.
5664 * composite.c (composition_gstring_put_cache):
5665 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5666
5667 * editfns.c, insdel.c:
5668 Omit unnecessary forward decls, to simplify future changes.
5669
5670 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5671
5672 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5673
5674 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5675 Use much-faster test for byte-length change.
5676 Don't assume string byte-length fits in 'int'.
5677 Check that character arg fits in 'int'.
5678 (mapcar1): Declare byte as byte, for clarity.
5679
5680 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5681
5682 * fns.c (concat): Catch string overflow earlier.
5683 Do not rely on integer wraparound.
5684
5685 * dispextern.h (struct it.overlay_strings_charpos)
5686 (struct it.selective): Now EMACS_INT, not int.
5687 * xdisp.c (forward_to_next_line_start)
5688 (back_to_previous_visible_line_start)
5689 (reseat_at_next_visible_line_start, next_element_from_buffer):
5690 Don't arbitrarily truncate the value of 'selective' to int.
5691
5692 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5693
5694 * composite.c: Don't truncate sizes to 'int'.
5695 (composition_gstring_p, composition_reseat_it)
5696 (composition_adjust_point): Use EMACS_INT, not int.
5697 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5698 not EMACS_UINT, for indexes.
5699
5700 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5701
5702 * buffer.c: Include <verify.h>.
5703 (struct sortvec.priority, struct sortstr.priority):
5704 Now EMACS_INT, not int.
5705 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5706 (struct sortstr.size, record_overlay_string)
5707 (struct sortstrlist.size, struct sortlist.used):
5708 Don't truncate size to int.
5709 (record_overlay_string): Check for size-calculation overflow.
5710 (init_buffer_once): Check at compile-time, not run-time.
5711
5712 2011-06-22 Jim Meyering <meyering@redhat.com>
5713
5714 Don't leak an XBM-image-sized buffer
5715 * image.c (xbm_load): Free the image buffer after using it.
5716
5717 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5718
5719 Port to Sun C.
5720 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5721 that Sun C diagnosed.
5722 * fns.c (secure_hash): Fix pointer signedness issue.
5723 * intervals.c (static_offset_intervals): New function.
5724 (offset_intervals): Use it.
5725
5726 2011-06-21 Leo Liu <sdl.web@gmail.com>
5727
5728 * deps.mk (fns.o):
5729 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5730 sha512.h.
5731
5732 * fns.c (secure_hash): Rename from crypto_hash_function and change
5733 the first arg to accept symbols.
5734 (Fsecure_hash): New primitive.
5735 (syms_of_fns): New symbols.
5736
5737 2011-06-20 Deniz Dogan <deniz@dogan.se>
5738
5739 * process.c (Fset_process_buffer): Clarify return value in
5740 docstring.
5741
5742 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5743
5744 * dispnew.c (add_window_display_history): Use BVAR.
5745
5746 * xdisp.c (debug_method_add): Use BVAR.
5747 (check_window_end, dump_glyph_matrix, dump_glyph)
5748 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5749
5750 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5751 Likewise.
5752
5753 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5754 check till after the cache is created in init_frame_faces.
5755
5756 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5757
5758 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5759
5760 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5761
5762 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5763 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5764 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5765
5766 Improve buffer-overflow checking (Bug#8873).
5767 * fileio.c (Finsert_file_contents):
5768 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5769 Remove the old (too-loose) buffer overflow checks.
5770 They weren't needed, since make_gap checks for buffer overflow.
5771 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5772 The old code merely checked for Emacs fixnum overflow, and relied
5773 on undefined (wraparound) behavior. The new code avoids undefined
5774 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5775
5776 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5777 Tune. Don't use wider integers than needed. Don't use alloca.
5778 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5779
5780 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5781
5782 * insdel.c, lisp.h (buffer_overflow): New function.
5783 (insert_from_buffer_1, replace_range, replace_range_2):
5784 * insdel.c (make_gap_larger):
5785 * editfns.c (Finsert_char):
5786 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5787
5788 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5789
5790 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5791
5792 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5793
5794 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5795 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5796
5797 * fileio.c: Don't assume EMACS_INT fits in off_t.
5798 (emacs_lseek): New static function.
5799 (Finsert_file_contents, Fwrite_region): Use it.
5800 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5801
5802 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5803
5804 * fns.c: Don't overflow int when computing a list length.
5805 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5806 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5807 truncation on 64-bit hosts. Check for QUIT every
5808 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5809 faster and is responsive enough.
5810 (Flength): Report an error instead of overflowing an integer.
5811 (Fsafe_length): Return a float if the value is not representable
5812 as a fixnum. This shouldn't happen except in contrived situations.
5813 (Fnthcdr, Fsort): Don't assume list length fits in int.
5814 (Fcopy_sequence): Don't assume vector length fits in int.
5815
5816 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5817 (header_size, word_size): New constants.
5818 (allocate_vectorlike): Don't check size overflow here.
5819 (allocate_vector): Check it here instead, since this is the only
5820 caller of allocate_vectorlike that could cause overflow.
5821 Check that the new vector's length is representable as a fixnum.
5822
5823 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5824 The previous code was bogus. For example, next_almost_prime (32)
5825 returned 39, which is undesirable as it is a multiple of 3; and
5826 next_almost_prime (24) returned 25, which is a multiple of 5 so
5827 why was the code bothering to check for multiples of 7?
5828
5829 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5830
5831 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5832
5833 Variadic C functions now count arguments with ptrdiff_t.
5834 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5835 Back then I didn't know that the Emacs coding style prefers signed int.
5836 Also, in the meantime I found a few more instances where arguments
5837 were being counted with int, which may truncate counts on 64-bit
5838 machines, or EMACS_INT, which may be unnecessarily wide.
5839 * lisp.h (struct Lisp_Subr.function.aMANY)
5840 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5841 Arg counts are now ptrdiff_t, not size_t.
5842 All variadic functions and their callers changed accordingly.
5843 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5844 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5845 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5846 * callint.c (Fcall_interactively): Check arg count for overflow,
5847 to avoid potential buffer overrun. Use signed char, not 'int',
5848 for 'varies' array, so that we needn't bother to check its size
5849 calculation for overflow.
5850 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5851 * eval.c (apply_lambda):
5852 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5853 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5854 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5855
5856 * callint.c (Fcall_interactively): Don't use index var as event count.
5857
5858 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5859 * mem-limits.h (SIZE): Remove; no longer used.
5860
5861 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5862
5863 Remove unnecessary casts.
5864 * xterm.c (x_term_init):
5865 * xfns.c (x_set_border_pixel):
5866 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5867 These aren't needed now that we assume ANSI C.
5868
5869 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5870 It's more likely to cause problems (due to unsigned overflow)
5871 than to cure them.
5872
5873 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5874
5875 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5876
5877 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5878
5879 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5880
5881 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5882
5883 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5884
5885 GLYPH_CODE_FACE returns EMACS_INT, not int.
5886 * dispextern.h (merge_faces):
5887 * xfaces.c (merge_faces):
5888 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5889 Don't assume EMACS_INT fits in int.
5890
5891 * character.h (CHAR_VALID_P): Remove unused parameter.
5892 * fontset.c, lisp.h, xdisp.c: All uses changed.
5893
5894 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5895
5896 * fns.c (concat): Minor tuning based on overflow analysis.
5897 This doesn't fix any bugs. Use int to hold character, instead
5898 of constantly refetching from Emacs object. Use XFASTINT, not
5899 XINT, for value known to be a character. Don't bother comparing
5900 a single byte to 0400, as it's always less.
5901
5902 * floatfns.c (Fexpt):
5903 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5904
5905 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5906 for characters.
5907
5908 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5909
5910 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5911 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5912 incorrectly succeed when S was a string, because 4294967386 was
5913 truncated before it was used.
5914
5915 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5916 Otherwise, an out-of-range integer could cause undefined behavior
5917 on a 64-bit host.
5918
5919 * composite.c: Use int, not EMACS_INT, for characters.
5920 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5921 EMACS_INT, for values that are known to be in character range.
5922 This doesn't fix any bugs but is the usual style inside Emacs and
5923 may generate better code on 32-bit machines.
5924
5925 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5926 This is for reasons similar to the recent CHAR_STRING fix.
5927 * charset.c (Fencode_char): Check that character arg is actually
5928 a character. Pass an int to ENCODE_CHAR.
5929 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5930 wider than 'int', as a compile-time check to prevent future regressions
5931 in this area.
5932
5933 * character.c (char_string): Remove unnecessary casts.
5934
5935 Make sure a 64-bit char is never passed to CHAR_STRING.
5936 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5937 by silently ignoring the top 32 bits, allowing some values
5938 that were far too large to be valid characters.
5939 * character.h: Include <verify.h>.
5940 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5941 arguments are no wider than unsigned, as a compile-time check
5942 to prevent future regressions in this area.
5943 * data.c (Faset):
5944 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5945 (Fsubst_char_in_region):
5946 * fns.c (concat):
5947 * xdisp.c (decode_mode_spec_coding):
5948 Adjust to CHAR_STRING's new requirement.
5949 * editfns.c (Finsert_char, Fsubst_char_in_region):
5950 * fns.c (concat): Check that character args are actually
5951 characters. Without this test, these functions did the wrong
5952 thing with wildly out-of-range values on 64-bit hosts.
5953
5954 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5955 These casts should not be needed on 32-bit hosts, either.
5956 * keyboard.c (read_char):
5957 * lread.c (Fload): Remove casts to unsigned.
5958
5959 * lisp.h (UNSIGNED_CMP): New macro.
5960 This fixes comparison bugs on 64-bit hosts.
5961 (ASCII_CHAR_P): Use it.
5962 * casefiddle.c (casify_object):
5963 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5964 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5965 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5966 * dispextern.h (FACE_FROM_ID):
5967 * keyboard.c (read_char): Use UNSIGNED_CMP.
5968
5969 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5970 not to EMACS_INT, to avoid GCC warning.
5971
5972 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5973
5974 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5975 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5976 isn't needed on 32-bit machines.
5977
5978 * buffer.c (Fgenerate_new_buffer_name):
5979 Use EMACS_INT for count, not int.
5980 (advance_to_char_boundary): Return EMACS_INT, not int.
5981
5982 * data.c (Qcompiled_function): Now static.
5983
5984 * window.c (window_body_lines): Now static.
5985
5986 * image.c (gif_load): Rename local to avoid shadowing.
5987
5988 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5989 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5990 * alloc.c (make_save_value): Integer argument is now of type
5991 ptrdiff_t, not int.
5992 (mark_object): Use ptrdiff_t, not int.
5993 * lisp.h (pD): New macro.
5994 * print.c (print_object): Use it.
5995
5996 * alloc.c: Use EMACS_INT, not int, to count objects.
5997 (total_conses, total_markers, total_symbols, total_vector_size)
5998 (total_free_conses, total_free_markers, total_free_symbols)
5999 (total_free_floats, total_floats, total_free_intervals)
6000 (total_intervals, total_strings, total_free_strings):
6001 Now EMACS_INT, not int. All uses changed.
6002 (Fgarbage_collect): Compute overall total using a double, so that
6003 integer overflow is less likely to be a problem. Check for overflow
6004 when converting back to an integer.
6005 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6006 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6007 These were 'int' variables that could overflow on 64-bit hosts;
6008 they were never used, so remove them instead of repairing them.
6009 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6010 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6011 Previously, this ceilinged at INT_MAX, but that doesn't work on
6012 64-bit machines.
6013 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6014
6015 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6016 (allocate_vectorlike): Check for ptrdiff_t overflow.
6017 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6018 when a (possibly-narrower) signed value would do just as well.
6019 We prefer using signed arithmetic, to avoid comparison confusion.
6020
6021 * alloc.c: Catch some string size overflows that we were missing.
6022 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6023 for convenience in STRING_BYTES_MAX.
6024 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6025 The definition here is exact; the one in lisp.h was approximate.
6026 (allocate_string_data): Check for string overflow. This catches
6027 some instances we weren't catching before. Also, it catches
6028 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6029 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6030 and ptrdiff_t and EMACS_INT are both 64 bits.
6031
6032 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6033 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6034 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
6035
6036 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6037
6038 * alloc.c (Fmake_string): Check for out-of-range init.
6039
6040 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6041
6042 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6043
6044 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6045
6046 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6047 xg_get_default_scrollbar_width.
6048
6049 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6050 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6051 (style_changed_cb): Call update_theme_scrollbar_width and call
6052 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6053 all frames (Bug#8505).
6054 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6055 Call gtk_window_set_resizable if HAVE_GTK3.
6056 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6057 and height if HAVE_GTK3 (Bug#8505).
6058 (scroll_bar_width_for_theme): New variable.
6059 (update_theme_scrollbar_width): New function.
6060 (xg_get_default_scrollbar_width): Move code to
6061 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6062 (xg_initialize): Call update_theme_scrollbar_width.
6063
6064 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6065
6066 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6067
6068 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6069
6070 * frame.c (make_frame): Call other_buffer_safely instead of
6071 other_buffer.
6072
6073 * window.c (temp_output_buffer_show): Call display_buffer with
6074 second argument Vtemp_buffer_show_specifiers and reset latter
6075 immediately after the call.
6076 (Vtemp_buffer_show_specifiers): New variable.
6077 (auto_window_vscroll_p, next_screen_context_lines)
6078 (Vscroll_preserve_screen_position): Remove leading asterisks from
6079 doc-strings.
6080
6081 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6082
6083 Fix minor problems found by GCC 4.6.0 static checking.
6084 * buffer.c (Qclone_number): Remove for now, as it's unused.
6085 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6086 (record_buffer): Remove unused local.
6087 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6088 (set_frame_buffer_list): Remove; unused.
6089 * frame.h (other_visible_frames): Remove decl.
6090 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6091 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6092 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6093 if HAVE_GPM.
6094 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6095 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6096 Define only if HAVE_GPM.
6097 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6098 (update_hints_inhibit): Remove; never set. All uses removed.
6099 * widgetprv.h (emacsFrameClassRec): Remove decl.
6100 * window.c (delete_deletable_window): Now returns void, since it
6101 wasn't returning anything.
6102 (compare_window_configurations): Remove unused locals.
6103 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6104 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6105 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6106 the same widths as pointers. This follows up on the 2011-05-06 patch.
6107 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6108 * xterm.h: Likewise.
6109 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6110
6111 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6112
6113 * makefile.w32-in: Update dependencies.
6114 (LISP_H): Add lib/intprops.h.
6115
6116 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6117
6118 * image.c (gif_load): Add animation frame delay to the metadata.
6119 (syms_of_image): Use DEFSYM. New symbol `delay'.
6120
6121 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6122
6123 * window.c (delete_deletable_window): Re-add.
6124 (Fset_window_configuration): Rewrite to handle dead buffers and
6125 consequently deletable windows.
6126 (window_tree, Fwindow_tree): Remove. Supply functionality in
6127 window.el.
6128 (compare_window_configurations): Simplify code.
6129
6130 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6131
6132 * image.c (imagemagick_load_image): Fix type mismatch.
6133 (Fimagemagick_types): Likewise.
6134
6135 * window.h (replace_buffer_in_windows): Declare.
6136
6137 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6138
6139 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6140 Qclone_number. Remove external declaration of Qdelete_window.
6141 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6142 code.
6143 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6144 Run Qbuffer_list_update_hook if allowed.
6145 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6146 buffer list implementation.
6147 (other_buffer_safely): New function.
6148 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6149 calls to replace_buffer_in_windows and
6150 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6151 if allowed.
6152 (record_buffer): Inhibit quitting and rewrite using quittable
6153 functions. Run Qbuffer_list_update_hook if allowed.
6154 (Frecord_buffer, Funrecord_buffer): New functions.
6155 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6156 Move switch-to-buffer to window.el.
6157 (bury-buffer): Move to window.el.
6158 (Vbuffer_list_update_hook): New variable.
6159
6160 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6161 section.
6162
6163 * window.h (resize_frame_windows): Move up in code.
6164 (Fwindow_frame): Remove EXFUN.
6165 (replace_buffer_in_all_windows): Remove prototype.
6166 (replace_buffer_in_windows_safely): Add prototype.
6167
6168 * window.c: Declare Qdelete_window static again. Move down
6169 declaration of select_count.
6170 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6171 (Fother_window): Move to window.el.
6172 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6173 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6174 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6175 window.el.
6176 (replace_buffer_in_windows): Implement by calling
6177 Qreplace_buffer_in_windows.
6178 (replace_buffer_in_all_windows): Remove with some functionality
6179 moved into replace_buffer_in_windows_safely.
6180 (replace_buffer_in_windows_safely): New function.
6181 (select_window_norecord, select_frame_norecord): Move in front
6182 of run_window_configuration_change_hook. Remove now obsolete
6183 declarations.
6184 (Fset_window_buffer): Rewrite doc-string.
6185 Call Qrecord_window_buffer.
6186 (keys_of_window): Move binding for other-window to window.el.
6187
6188 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6189
6190 * dispextern.h (struct image): Replace data member, whose int_val
6191 and ptr_val fields were not used by anything, with a single
6192 lisp_val object.
6193
6194 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6195 (gif_clear_image, gif_load, imagemagick_load_image)
6196 (gs_clear_image, gs_load): Callers changed.
6197
6198 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6199
6200 * buffer.h: Include <time.h>, for time_t.
6201 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6202
6203 Fix minor problems found by static checking.
6204
6205 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6206
6207 Make identifiers static if they are not used in other modules.
6208 * data.c (Qcompiled_function, Qframe, Qvector):
6209 * image.c (QimageMagick, Qsvg):
6210 * minibuf.c (Qmetadata):
6211 * window.c (resize_window_check, resize_root_window): Now static.
6212 * window.h (resize_window_check, resize_root_window): Remove decls.
6213
6214 * window.c (window_deletion_count, delete_deletable_window):
6215 Remove; unused.
6216 (window_body_lines): Now static.
6217 (Fdelete_other_windows_internal): Mark vars as initialized.
6218 Make sure 'resize_failed' is initialized.
6219 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6220 (resize_window_apply): Remove unused local.
6221 * window.h (delete_deletable_window): Remove decl.
6222
6223 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6224 (imagemagick_load_image): Fix pointer signedness problem by changing
6225 last arg from unsigned char * to char *. All uses changed.
6226 Also, fix a local for similar reasons.
6227 Remove unused locals. Remove locals to avoid shadowing.
6228 (fn_rsvg_handle_free): Remove; unused.
6229 (svg_load, svg_load_image): Fix pointer signedness problem.
6230 (imagemagick_load_image): Don't use garbage pointer image_wand.
6231
6232 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6233
6234 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6235
6236 * image.c (gif_load): Fix omitted cast error introduced by
6237 2011-06-06 change.
6238
6239 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6240
6241 * window.h (resize_proportionally, orig_total_lines)
6242 (orig_top_line): Remove from window structure.
6243 (set_window_height, set_window_width, change_window_heights)
6244 (Fdelete_window): Remove prototypes.
6245 (resize_frame_windows): Remove duplicate declaration.
6246
6247 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6248
6249 * window.h (resize_frame_windows, resize_window_check)
6250 (delete_deletable_window, resize_root_window)
6251 (resize_frame_windows): Declare prototypes.
6252
6253 * window.c (resize_window_apply): Make definition be "static" to
6254 match the prototype.
6255
6256 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6257
6258 * window.c: Remove declarations of Qwindow_size_fixed,
6259 window_min_size_1, window_min_size_2, window_min_size,
6260 size_window, window_fixed_size_p, enlarge_window, delete_window.
6261 Remove static from declaration of Qdelete_window, it's
6262 temporarily needed by Fbury_buffer.
6263 (replace_window): Don't assign orig_top_line and
6264 orig_total_lines.
6265 (Fdelete_window, delete_window): Remove. Window deletion is
6266 handled by window.el.
6267 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6268 Replace Fdelete_window calls with calls to Qdelete_window.
6269 (Fdelete_other_windows): Remove. Deleting other windows is
6270 handled by window.el.
6271 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6272 handled in window.el.
6273 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6274 Window minimum sizes are handled in window.el.
6275 (shrink_windows, size_window, set_window_height)
6276 (set_window_width, change_window_heights, window_height)
6277 (window_width, CURBEG, CURSIZE, enlarge_window)
6278 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6279 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6280 handled in window.el.
6281 (make_dummy_parent): Rename to make_parent_window and give it a
6282 second argument horflag.
6283 (make_window): Don't set resize_proportionally any more.
6284 (Fsplit_window): Remove. Windows are split in window.el.
6285 (save_restore_action, save_restore_orig_size)
6286 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6287 Resize mini windows in window.el.
6288 (grow_mini_window, shrink_mini_window): Implement by calling
6289 Qresize_root_window_vertically, resize_window_check and
6290 resize_window_apply.
6291 (saved_window, Fset_window_configuration, save_window_save):
6292 Do not handle orig_top_line, orig_total_lines, and
6293 resize_proportionally.
6294 (window_min_height, window_min_width): Move to window.el.
6295 (keys_of_window): Move bindings for delete-other-windows,
6296 split-window, delete-window and enlarge-window to window.el.
6297
6298 * buffer.c: Temporarily extern Qdelete_window.
6299 (Fbury_buffer): Temporarily call Qdelete_window instead of
6300 Fdelete_window (Fbury_buffer will move to window.el soon).
6301
6302 * frame.c (set_menu_bar_lines_1): Remove code handling
6303 orig_top_line and orig_total_lines.
6304
6305 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6306 set_window_height but set heights directly.
6307 (change_frame_size_1): Use resize_frame_windows.
6308
6309 * xdisp.c (init_xdisp): Don't use set_window_height but set
6310 heights directly.
6311
6312 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6313 Use resize_frame_windows instead of change_window_heights and run
6314 run_window_configuration_change_hook.
6315
6316 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6317 instead of change_window_heights and run
6318 run_window_configuration_change_hook.
6319
6320 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6321
6322 * window.c (replace_window): Rename second argument REPLACEMENT to
6323 NEW. New third argument SETFLAG. Rewrite.
6324 (delete_window, make_dummy_parent): Call replace_window with
6325 third argument 1.
6326 (window_list_1): Move down in code.
6327 (run_window_configuration_change_hook): Move set_buffer part
6328 before select_frame_norecord part in order to unwind correctly.
6329 Rename count1 to count.
6330 (recombine_windows, delete_deletable_window, resize_root_window)
6331 (Fdelete_other_windows_internal)
6332 (Frun_window_configuration_change_hook, make_parent_window)
6333 (resize_window_check, resize_window_apply, Fresize_window_apply)
6334 (resize_frame_windows, Fsplit_window_internal)
6335 (Fdelete_window_internal, Fresize_mini_window_internal):
6336 New functions.
6337 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6338
6339 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6340
6341 * window.h (window): Add some new members to window structure -
6342 normal_lines, normal_cols, new_total, new_normal, clone_number,
6343 splits, nest, prev_buffers, next_buffers.
6344 (WINDOW_TOTAL_SIZE): Move here from window.c.
6345 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6346
6347 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6348 Remove.
6349 (make_dummy_parent): Set new members of windows structure.
6350 (make_window): Move down in code. Handle new members of window
6351 structure.
6352 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6353 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6354 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6355 (Fset_window_prev_buffers, Fwindow_next_buffers)
6356 (Fset_window_next_buffers, Fset_window_clone_number):
6357 New functions.
6358 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6359 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6360 Doc-string fixes.
6361 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6362 Argument WINDOW can be now internal window too.
6363 (Fwindow_use_time): Move up in code.
6364 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6365 Rewrite doc-string.
6366 (Fset_window_configuration, saved_window)
6367 (Fcurrent_window_configuration, save_window_save): Handle new
6368 members of window structure.
6369 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6370 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6371 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6372 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6373 Qget_mru_window, Qresize_root_window,
6374 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6375 Qauto_buffer_name; staticpro them.
6376
6377 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6378
6379 * window.c (Fwindow_total_size, Fwindow_left_column)
6380 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6381 (Fwindow_list_1): New functions.
6382 (window_box_text_cols): Replace with window_body_cols.
6383 (Fwindow_width, Fscroll_left, Fscroll_right):
6384 Use window_body_cols instead of window_box_text_cols.
6385 (delete_window, Fset_window_configuration):
6386 Call delete_all_subwindows with window as argument.
6387 (delete_all_subwindows): Take a window as argument and not a
6388 structure. Rewrite.
6389 (window_loop): Remove handling of GET_LRU_WINDOW and
6390 GET_LARGEST_WINDOW.
6391 (Fget_lru_window, Fget_largest_window): Move to window.el.
6392
6393 * window.h: Extern window_body_cols instead of
6394 window_box_text_cols. delete_all_subwindows now takes a
6395 Lisp_Object as argument.
6396
6397 * indent.c (compute_motion, Fcompute_motion):
6398 Use window_body_cols instead of window_box_text_cols.
6399
6400 * frame.c (delete_frame): Call delete_all_subwindows with root
6401 window as argument.
6402
6403 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6404
6405 * fns.c (Fputhash): Document return value.
6406
6407 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6408
6409 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6410
6411 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6412
6413 Cons<->int and similar integer overflow fixes (Bug#8794).
6414
6415 Check for overflow when converting integer to cons and back.
6416 * charset.c (Fdefine_charset_internal, Fdecode_char):
6417 Use cons_to_unsigned to catch overflow.
6418 (Fencode_char): Use INTEGER_TO_CONS.
6419 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6420 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6421 * data.c (long_to_cons, cons_to_long): Remove.
6422 (cons_to_unsigned, cons_to_signed): New functions.
6423 These signal an error for invalid or out-of-range values.
6424 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6425 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6426 * font.c (Ffont_variation_glyphs):
6427 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6428 * lisp.h: Include <intprops.h>.
6429 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6430 (cons_to_signed, cons_to_unsigned): New decls.
6431 (long_to_cons, cons_to_long): Remove decls.
6432 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6433 (Fprimitive_undo): Use CONS_TO_INTEGER.
6434 * xfns.c (Fx_window_property): Likewise.
6435 * xselect.c: Include <limits.h>.
6436 (x_own_selection, selection_data_to_lisp_data):
6437 Use INTEGER_TO_CONS.
6438 (x_handle_selection_request, x_handle_selection_clear)
6439 (x_get_foreign_selection, Fx_disown_selection_internal)
6440 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6441 (lisp_data_to_selection_data): Use cons_to_unsigned.
6442 (x_fill_property_data): Use cons_to_signed.
6443 Report values out of range.
6444
6445 Check for buffer and string overflow more precisely.
6446 * buffer.h (BUF_BYTES_MAX): New macro.
6447 * lisp.h (STRING_BYTES_MAX): New macro.
6448 * alloc.c (Fmake_string):
6449 * character.c (string_escape_byte8):
6450 * coding.c (coding_alloc_by_realloc):
6451 * doprnt.c (doprnt):
6452 * editfns.c (Fformat):
6453 * eval.c (verror):
6454 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6455 since they may not be the same number.
6456 * editfns.c (Finsert_char):
6457 * fileio.c (Finsert_file_contents):
6458 Likewise for BUF_BYTES_MAX.
6459
6460 * image.c: Use ptrdiff_t, not int, for sizes.
6461 (slurp_file): Switch from int to ptrdiff_t.
6462 All uses changed.
6463 (slurp_file): Check that file size fits in both size_t (for
6464 malloc) and ptrdiff_t (for sanity and safety).
6465
6466 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6467 if b->modtime has its maximal value.
6468
6469 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6470
6471 Don't assume time_t can fit into int.
6472 * buffer.h (struct buffer.modtime): Now time_t, not int.
6473 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6474 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6475
6476 Minor fixes for signed vs unsigned integers.
6477 * character.h (MAYBE_UNIFY_CHAR):
6478 * charset.c (maybe_unify_char):
6479 * keyboard.c (read_char, reorder_modifiers):
6480 XINT -> XFASTINT, since the integer must be nonnegative.
6481 * ftfont.c (ftfont_spec_pattern):
6482 * keymap.c (access_keymap, silly_event_symbol_error):
6483 XUINT -> XFASTINT, since the integer must be nonnegative.
6484 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6485 since it makes no difference and we prefer signed.
6486 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6487 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6488 nonnegative.
6489
6490 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6491
6492 * window.h (Fwindow_frame): Declare.
6493
6494 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6495
6496 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6497 (SPARE_MEMORY): Always define.
6498 (LARGE_REQUEST): Remove.
6499 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6500
6501 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6502
6503 * lisp.h: Move EXFUNS for Fframe_root_window,
6504 Fframe_first_window and Fset_frame_selected_window to window.h.
6505
6506 * window.h: Move EXFUNS for Fframe_root_window,
6507 Fframe_first_window and Fset_frame_selected_window here from
6508 lisp.h.
6509
6510 * frame.c (Fwindow_frame, Fframe_first_window)
6511 (Fframe_root_window, Fframe_selected_window)
6512 (Fset_frame_selected_window): Move to window.c.
6513 (Factive_minibuffer_window): Move to minibuf.c.
6514 (Fother_visible_frames_p): New function.
6515
6516 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6517
6518 * window.c (decode_window, decode_any_window): Move up in code.
6519 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6520 (inhibit_frame_unsplittable): Remove unused variable.
6521 (Fwindow_buffer): Move up and rewrite doc-string.
6522 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6523 (Fwindow_prev): New functions.
6524 (Fwindow_frame): Move here from frame.c. Accept any window as
6525 argument.
6526 (Fframe_root_window, Fframe_first_window)
6527 (Fframe_selected_window): Move here from frame.c. Accept frame
6528 or arbitrary window as argument. Update doc-strings.
6529 (Fminibuffer_window): Move up in code.
6530 (Fwindow_minibuffer_p): Move up in code and simplify.
6531 (Fset_frame_selected_window): Move here from frame.c.
6532 Marginal rewrite.
6533 (Fselected_window, select_window, Fselect_window): Move up in
6534 code. Minor doc-string fixes.
6535
6536 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6537
6538 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6539 Do not assume that spare memory exists; that assumption is valid
6540 only if SYSTEM_MALLOC.
6541 (LARGE_REQUEST): New macro, so that the issue of large requests
6542 is separated from the issue of spare memory.
6543
6544 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6545
6546 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6547 format. (Bug#8806)
6548
6549 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6550
6551 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6552 before statements.
6553
6554 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6555
6556 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6557
6558 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6559
6560 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6561 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6562
6563 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6564
6565 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6566
6567 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6568
6569 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6570 (x_clipboard_manager_save): Add return value.
6571 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6572 New error handlers.
6573 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6574 Obey Vx_select_enable_clipboard_manager. Catch errors in
6575 x_clipboard_manager_save (Bug#8779).
6576 (Vx_select_enable_clipboard_manager): New variable.
6577 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6578
6579 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6580
6581 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6582
6583 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6584
6585 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6586 in the current matrix if keep_current_p is non-zero.
6587
6588 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6589
6590 * bidi.c (bidi_level_of_next_char): Fix last change.
6591
6592 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6593
6594 Support bidi reordering of text covered by display properties.
6595
6596 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6597 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6598 (bidi_cache_search, bidi_cache_iterator_state)
6599 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6600 (bidi_level_of_next_char, bidi_move_to_visually_next):
6601 Support character positions inside a run of characters covered by a
6602 display string.
6603 (bidi_paragraph_init, bidi_resolve_explicit_1)
6604 (bidi_level_of_next_char): Call bidi_fetch_char and
6605 bidi_fetch_char_advance instead of FETCH_CHAR and
6606 FETCH_CHAR_ADVANCE.
6607 (bidi_init_it): Initialize new members.
6608 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6609 definitions.
6610 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6611 instead of using explicit *_CHAR codes.
6612 (bidi_resolve_explicit, bidi_resolve_weak):
6613 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6614 bidirectional text is supported only in multibyte buffers.
6615 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6616 it to initialize the frame_window_p member of struct bidi_it.
6617 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6618 (bidi_resolve_explicit, bidi_resolve_weak)
6619 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6620 bidi_it->nchars is non-positive.
6621 (bidi_level_of_next_char): Don't try to lookup the cache for the
6622 next/previous character if nothing is cached there yet, or if we
6623 were just reseat()'ed to a new position.
6624
6625 * xdisp.c (set_cursor_from_row): Set start and stop points
6626 according to the row's direction when priming the loop that looks
6627 for the glyph on which to display cursor.
6628 (single_display_spec_intangible_p): Function deleted.
6629 (display_prop_intangible_p): Reimplement to call
6630 handle_display_spec instead of single_display_spec_intangible_p.
6631 Accept 3 additional arguments needed by handle_display_spec.
6632 This fixes incorrect cursor motion across display property with complex
6633 values: lists, `(when COND...)' forms, etc.
6634 (single_display_spec_string_p): Support property values that are
6635 lists with the argument STRING its top-level element.
6636 (display_prop_string_p): Fix the condition for processing a
6637 property that is a list to be consistent with handle_display_spec.
6638 (handle_display_spec): New function, refactored from the
6639 last portion of handle_display_prop.
6640 (compute_display_string_pos): Accept additional argument
6641 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6642 value of a `display' property is a "replacing spec".
6643 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6644 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6645 the display property, but just return a value indicating whether
6646 the display property will replace the characters it covers.
6647 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6648 frame_window_p members of struct bidi_it.
6649 (compute_display_string_pos, compute_display_string_end):
6650 New functions.
6651 (push_it): Accept second argument POSITION, where pop_it should
6652 jump to continue iteration.
6653 (reseat_1): Initialize bidi_it.disp_pos.
6654
6655 * keyboard.c (adjust_point_for_property): Adjust the call to
6656 display_prop_intangible_p to its new signature.
6657
6658 * dispextern.h (struct bidi_it): New member frame_window_p.
6659 (bidi_init_it): Update prototypes.
6660 (display_prop_intangible_p): Update prototype.
6661 (compute_display_string_pos, compute_display_string_end):
6662 Declare prototypes.
6663 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6664 EMACS_INT.
6665
6666 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6667
6668 Malloc failure behavior now depends on size of allocation.
6669 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6670 * lisp.h: Change signatures accordingly.
6671 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6672 All callers changed. (Bug#8762)
6673
6674 * gnutls.c: Use Emacs's memory allocators.
6675 Without this change, the gnutls library would invoke malloc etc.
6676 directly, which causes problems on non-SYNC_INPUT hosts, and which
6677 runs afoul of improving memory_full behavior. (Bug#8761)
6678 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6679 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6680 xfree instead of the default malloc, realloc, free.
6681 (Fgnutls_boot): No need to check for memory allocation failure,
6682 since xmalloc does that for us.
6683
6684 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6685 * category.c (hash_get_category_set):
6686 * ccl.c (ccl_driver):
6687 * charset.c (Fdefine_charset_internal):
6688 * charset.h (struct charset.hash_index):
6689 * composite.c (get_composition_id, gstring_lookup_cache)
6690 (composition_gstring_put_cache):
6691 * composite.h (struct composition.hash_index):
6692 * dispextern.h (struct image.hash):
6693 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6694 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6695 (hashfn_equal, hashfn_user_defined, make_hash_table)
6696 (maybe_resize_hash_table, hash_lookup, hash_put)
6697 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6698 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6699 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6700 * image.c (make_image, search_image_cache, lookup_image)
6701 (xpm_put_color_table_h):
6702 * lisp.h (struct Lisp_Hash_Table):
6703 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6704 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6705 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6706 * alloc.c (allocate_vectorlike):
6707 Check for overflow in vector size calculations.
6708 * ccl.c (ccl_driver):
6709 Check for overflow when converting EMACS_INT to int.
6710 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6711 need to be updated by these changes.
6712 * fns.c (make_hash_table, maybe_resize_hash_table):
6713 Check for integer overflow with large hash tables.
6714 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6715 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6716 (SXHASH_REDUCE): New macro.
6717 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6718 Use it instead of discarding useful hash info with large hash values.
6719 (sxhash_float): New function.
6720 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6721 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6722 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6723 Rewrite to use FIXNUM_BITS, as this simplifies things.
6724 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6725 Adjust signatures to match updated version of code.
6726 (consing_since_gc): Now EMACS_INT, since a single hash table can
6727 use more than INT_MAX bytes.
6728
6729 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6730
6731 Make it possible to build with GCC-4.6+ -O2 -flto.
6732
6733 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6734
6735 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6736
6737 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6738 Call minibuffer-inactive-mode.
6739
6740 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6741
6742 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6743 Update dependencies.
6744
6745 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6746
6747 * data.c (init_data): Remove code for UTS, this system is not
6748 supported anymore.
6749
6750 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6751
6752 Don't force ./temacs to start in terminal mode.
6753
6754 * frame.c (make_initial_frame): Initialize faces in all cases, not
6755 only when CANNOT_DUMP is defined.
6756 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6757
6758 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6759
6760 * dispnew.c (add_window_display_history): Use const for the string
6761 pointer. Remove declaration, not needed.
6762
6763 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6764
6765 Use 'inline', not 'INLINE'.
6766 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6767 * alloc.c, fontset.c (INLINE): Remove.
6768 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6769 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6770 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6771 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6772 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6773
6774 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6775
6776 Make it possible to run ./temacs.
6777
6778 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6779 syms_of_callproc does the same thing. Remove test for
6780 "initialized", do it in the caller.
6781 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6782
6783 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6784
6785 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6786 (read_minibuf): Use get_minibuffer.
6787 (syms_of_minibuf): Use DEFSYM.
6788 (Qmetadata): New var.
6789 * data.c (Qbuffer): Don't make it static.
6790 (syms_of_data): Use DEFSYM.
6791
6792 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6793
6794 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6795 (CCL_CODE_MIN): New macro.
6796
6797 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6798
6799 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6800
6801 * eval.c (Qdebug): Now static.
6802 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6803 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6804 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6805
6806 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6807
6808 * image.c: Various fixes to ImageMagick code comments.
6809 (Fimagemagick_types): Doc fix.
6810
6811 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6812
6813 Minor fixes prompted by GCC 4.6.0 warnings.
6814
6815 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6816
6817 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6818 (x_clipboard_manager_save_all): Move extern decl to ...
6819 * xterm.h: ... here, so that it can be checked for consistency.
6820
6821 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6822
6823 * xselect.c (x_clipboard_manager_save_frame)
6824 (x_clipboard_manager_save_all): New functions.
6825 (Fx_clipboard_manager_save): Lisp function deleted.
6826
6827 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6828 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6829
6830 * xterm.h: Update prototype.
6831
6832 2011-05-28 William Xu <william.xwl@gmail.com>
6833
6834 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6835 exiting (Bug#8239).
6836
6837 2011-05-28 Jim Meyering <meyering@redhat.com>
6838
6839 Avoid a sign-extension bug in crypto_hash_function.
6840 * fns.c (to_uchar): Define.
6841 (crypto_hash_function): Use it to convert some newly-signed
6842 variables to unsigned, to avoid sign-extension bugs. For example,
6843 without this change, (md5 "truc") would evaluate to
6844 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6845 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6846 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6847
6848 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6849
6850 Integer overflow fixes.
6851
6852 * dbusbind.c: Serial number integer overflow fixes.
6853 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6854 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6855 to hold a serial number that is too large for a fixnum.
6856 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6857 Check for serial numbers out of range. Decode any serial number
6858 that was so large that it became a float. (Bug#8722)
6859
6860 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6861 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6862 Use XFASTINT rather than XUINT when numbers are nonnegative.
6863 (xd_append_arg, Fdbus_method_return_internal):
6864 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6865 arguments, check that Lisp number is nonnegative, rather than
6866 silently wrapping negative numbers around. (Bug#8722)
6867 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6868 (Bug#8722)
6869
6870 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6871
6872 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6873
6874 ccl: Add integer overflow checks.
6875 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6876 (IN_INT_RANGE): New macros.
6877 (ccl_driver): Use them to check for integer overflow when
6878 decoding a CCL program. Many of the new checks are whether XINT (x)
6879 fits in int; it doesn't always, on 64-bit hosts. The new version
6880 doesn't catch all possible integer overflows, but it's an
6881 improvement. (Bug#8719)
6882
6883 * alloc.c (make_event_array): Use XINT, not XUINT.
6884 There's no need for unsigned here.
6885
6886 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6887 This follows up to the 2011-05-06 change that substituted uintptr_t
6888 for EMACS_INT. This case wasn't caught back then.
6889
6890 Rework Fformat to avoid integer overflow issues.
6891 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6892 now (part of C89). Include <verify.h>.
6893 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6894 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6895 (Fformat): Avoid the prepass trying to compute sizes; it was only
6896 approximate and thus did not catch overflow reliably. Instead, walk
6897 through the format just once, formatting and computing sizes as we go,
6898 checking for integer overflow at every step, and allocating a larger
6899 buffer as needed. Keep track separately whether the format is
6900 multibyte. Keep only the most-recently calculated precision, rather
6901 than them all. Record whether each argument has been converted to
6902 string. Use EMACS_INT, not int, for byte and char and arg counts.
6903 Support field widths and precisions larger than INT_MAX. Avoid
6904 sprintf's undefined behavior with conversion specifications such as %#d
6905 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6906 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6907 formatting out-of-range floating point numbers with int
6908 formats. (Bug#8668)
6909
6910 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6911
6912 * data.c: Avoid integer truncation in expressions involving floats.
6913 * data.c: Include <intprops.h>.
6914 (arith_driver): When there's an integer overflow in an expression
6915 involving floating point, convert the integers to floating point
6916 so that the resulting value does not suffer from catastrophic
6917 integer truncation. For example, on a 64-bit host (* 4
6918 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6919 Do not rely on undefined behavior after integer overflow.
6920
6921 merge count_size_as_multibyte, parse_str_to_multibyte
6922 * character.c, character.h (count_size_as_multibyte):
6923 Rename from parse_str_to_multibyte; all uses changed.
6924 Check for integer overflow.
6925 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6926 since it's now a duplicate of the other. This is more of
6927 a character than a buffer op, so better that it's in character.c.
6928 * fns.c, print.c: Adjust to above changes.
6929
6930 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6931
6932 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6933
6934 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6935
6936 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6937 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6938 (x_clipboard_manager_save): Now static.
6939 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6940
6941 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6942 (crypto_hash_function): Now static.
6943 Fix pointer signedness problems. Avoid unnecessary initializations.
6944
6945 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6946
6947 * termhooks.h (Vselection_alist): Make it terminal-local.
6948
6949 * terminal.c (create_terminal): Initialize it.
6950
6951 * xselect.c: Support for clipboard managers.
6952 (Vselection_alist): Move to termhooks.h as terminal-local var.
6953 (LOCAL_SELECTION): New macro.
6954 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6955 (symbol_to_x_atom): Remove gratuitous arg.
6956 (x_handle_selection_request, lisp_data_to_selection_data)
6957 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6958 (x_own_selection, x_get_local_selection, x_convert_selection):
6959 New arg, specifying work frame. Use terminal-local Vselection_alist.
6960 (some_frame_on_display): Delete unused function.
6961 (Fx_own_selection_internal, Fx_get_selection_internal)
6962 (Fx_disown_selection_internal, Fx_selection_owner_p)
6963 (Fx_selection_exists_p): New optional frame arg.
6964 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6965 (x_handle_selection_clear): Don't treat other terminals with the
6966 same keyboard specially. Use the terminal-local Vselection_alist.
6967 (x_clear_frame_selections): Use Frun_hook_with_args.
6968
6969 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6970
6971 * xterm.h: Add support for those atoms.
6972
6973 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6974
6975 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6976 (converted_selections, conversion_fail_tag): New global variables.
6977 (x_selection_request_lisp_error): Free the above.
6978 (x_get_local_selection): Remove unnecessary code.
6979 (x_reply_selection_request): Args changed; handle arbitrary array
6980 of converted selections stored in converted_selections.
6981 Separate the XChangeProperty and SelectionNotify steps.
6982 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6983 (x_convert_selection): New function.
6984 (x_handle_selection_event): Simplify.
6985 (x_get_foreign_selection): Don't ignore incoming requests while
6986 waiting for an answer; this will fail when we implement
6987 SAVE_TARGETS, and seems unnecessary anyway.
6988 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6989 (Vx_sent_selection_functions): Doc fix.
6990
6991 2011-05-26 Leo Liu <sdl.web@gmail.com>
6992
6993 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6994
6995 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6996
6997 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6998
6999 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7000 for fringe update if it has periodic bitmap.
7001 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7002 and fringe_bitmap_periodic_p.
7003
7004 * fringe.c (get_fringe_bitmap_data): New function.
7005 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7006 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7007 row. Mark glyph row for fringe update if periodicity changed.
7008
7009 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7010 for fringe update unless it has periodic bitmap.
7011
7012 2011-05-25 Kenichi Handa <handa@m17n.org>
7013
7014 * xdisp.c (get_next_display_element): Set correct it->face_id for
7015 a static composition.
7016
7017 2011-05-24 Leo Liu <sdl.web@gmail.com>
7018
7019 * deps.mk (fns.o):
7020 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7021
7022 * fns.c (crypto_hash_function, Fsha1): New function.
7023 (Fmd5): Use crypto_hash_function.
7024 (syms_of_fns): Add Ssha1.
7025
7026 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7027
7028 * gnutls.c: Remove unused macros.
7029 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7030 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7031 Remove macros that are defined and never used.
7032 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7033
7034 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7035
7036 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7037 (Fx_get_selection_internal): Minor cleanup.
7038 (Fx_own_selection_internal): Rename arguments for consistency with
7039 select.el.
7040
7041 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7042
7043 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7044
7045 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7046
7047 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7048
7049 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7050
7051 * dispnew.c (scrolling_window): Don't exclude the case that the
7052 last enabled row in the desired matrix touches the bottom boundary.
7053
7054 2011-05-21 Glenn Morris <rgm@gnu.org>
7055
7056 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7057 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7058 and add some more files.
7059
7060 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7061
7062 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7063 report_file_error introduced by the change from 2011-05-07.
7064
7065 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7066
7067 * systime.h (Time): Define only if emacs is defined.
7068 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7069 where the include path doesn't have X11/X.h by default. See
7070 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7071
7072 2011-05-20 Kenichi Handa <handa@m17n.org>
7073
7074 * composite.c (find_automatic_composition): Fix previous change.
7075
7076 2011-05-20 Glenn Morris <rgm@gnu.org>
7077
7078 * lisp.mk: New file, split from Makefile.in.
7079 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7080 (shortlisp): Remove.
7081 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7082
7083 2011-05-19 Glenn Morris <rgm@gnu.org>
7084
7085 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7086 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7087 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7088 (lisp): Set the order to that of loadup.el.
7089 (shortlisp): Make it a copy of $lisp.
7090 (SOME_MACHINE_LISP): Remove.
7091 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7092 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7093
7094 2011-05-18 Kenichi Handa <handa@m17n.org>
7095
7096 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7097 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7098 (find_automatic_composition): Mostly rewrite for efficiency.
7099
7100 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7101
7102 * makefile.w32-in: Update dependencies.
7103
7104 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7105
7106 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7107 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7108
7109 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7110
7111 Fix some integer overflow issues, such as string length overflow.
7112
7113 * insdel.c (count_size_as_multibyte): Check for string overflow.
7114
7115 * character.c (lisp_string_width): Check for string overflow.
7116 Use EMACS_INT, not int, for string indexes and lengths; in
7117 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7118 the resulting string length overflows an EMACS_INT; instead,
7119 report a string overflow if no precision given. When checking for
7120 precision exhaustion, use a check that cannot possibly have
7121 integer overflow. (Bug#8675)
7122 * character.h (lisp_string_width): Adjust to new signature.
7123
7124 * alloc.c (string_overflow): New function.
7125 (Fmake_string): Use it. This doesn't change behavior, but saves
7126 a few bytes and will simplify future changes.
7127 * character.c (string_escape_byte8): Likewise.
7128 * lisp.h (string_overflow): New decl.
7129
7130 Fixups, following up to the user-interface timestamp change.
7131 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7132 for UI timestamps, instead of unsigned long.
7133 * msdos.c (mouse_get_pos): Likewise.
7134 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
7135 * w32gui.h (Time): Define by including "systime.h" rather than by
7136 declaring it ourselves. (Bug#8664)
7137
7138 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7139 * image.c (clear_image_cache): Likewise.
7140
7141 * term.c (term_mouse_position): Don't assume time_t wraparound.
7142
7143 Be more systematic about user-interface timestamps.
7144 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7145 and sometimes 'EMACS_UINT', to represent these timestamps.
7146 This change causes it to use 'Time' uniformly, as that's what X uses.
7147 This makes the code easier to follow, and makes it easier to catch
7148 integer overflow bugs such as Bug#8664.
7149 * frame.c (Fmouse_position, Fmouse_pixel_position):
7150 Use Time, not unsigned long, for user-interface timestamps.
7151 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7152 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7153 * keyboard.h (last_event_timestamp): Likewise.
7154 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7155 * menu.h (xmenu_show): Likewise.
7156 * term.c (term_mouse_position): Likewise.
7157 * termhooks.h (struct input_event.timestamp): Likewise.
7158 (struct terminal.mouse_position_hook): Likewise.
7159 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7160 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7161 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7162 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7163 what it was before.
7164 * menu.h, termhooks.h: Include "systime.h", for Time.
7165
7166 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7167 Don't assume that the difference between two unsigned long values
7168 can fit into an integer. At this point, we know button_down_time
7169 <= event->timestamp, so the difference must be nonnegative, so
7170 there's no need to cast the result if double-click-time is
7171 nonnegative, as it should be; check that it's nonnegative, just in
7172 case. This bug is triggered when events are more than 2**31 ms
7173 apart (about 25 days). (Bug#8664)
7174
7175 * xselect.c (last_event_timestamp): Remove duplicate decl.
7176 (x_own_selection): Remove needless cast to unsigned long.
7177
7178 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7179 that always fit in int. Use a sentinel instead of a counter, to
7180 avoid a temp and to allay GCC's concerns about possible int overflow.
7181 * frame.h (struct frame): Use int for menu_bar_items_used
7182 instead of EMACS_INT, since it always fits in int.
7183
7184 * menu.c (grow_menu_items): Check for int overflow.
7185
7186 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7187
7188 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7189 Before, the code was not consistent. These values cannot exceed
7190 2**31 - 1 so there's no need to make them unsigned.
7191 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7192 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7193 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7194 as modifiers.
7195 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7196
7197 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7198 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7199 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7200 presumably because the widths might not match.
7201
7202 * window.c (size_window): Avoid needless test at loop start.
7203
7204 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7205
7206 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7207
7208 2011-05-12 Drew Adams <drew.adams@oracle.com>
7209
7210 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7211
7212 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7213
7214 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7215 `width' to `bar_area_x' and `bar_area_width', respectively.
7216 (x_scroll_run): Take account of fringe background extension.
7217
7218 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7219 Rename local vars `left' and `width' to `bar_area_x' and
7220 `bar_area_width', respectively.
7221 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7222 background extension.
7223
7224 2011-05-10 Jim Meyering <meyering@redhat.com>
7225
7226 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7227
7228 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7229
7230 * image.c (Finit_image_library): Return t for built-in image types,
7231 like pbm and xbm. (Bug#8640)
7232
7233 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7234
7235 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7236
7237 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7238
7239 * w32console.c (Fset_screen_color): Doc fix.
7240 (Fget_screen_color): New function.
7241 (syms_of_ntterm): Defsubr it.
7242
7243 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7244 unlink the temporary file if Fcall_process didn't create it in the
7245 first place.
7246 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7247 child process will be redirected to a file specified with `:file'.
7248 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7249 cue to call_process_cleanup not to close that handle.
7250
7251 2011-05-07 Ben Key <bkey76@gmail.com>
7252
7253 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7254 one of two shell specific rules, either bootstrap-temacs-CMD or
7255 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7256 to the previous implementation of the bootstrap-temacs rule.
7257 The bootstrap-temacs-CMD rule is similar to the previous
7258 implementation of the bootstrap-temacs rule except that it
7259 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7260 variable.
7261
7262 These changes, along with some changes to nt/configure.bat,
7263 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7264 earlier fix to add support for --cflags and --ldflags options
7265 that include quotes so that it works whether make uses cmd or
7266 sh as the shell.
7267
7268 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7269
7270 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7271 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7272 is a constant.
7273 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7274 a string. Handle both cases.
7275 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7276 (Fdbus_register_method): Use Qinvalid_function.
7277
7278 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7279
7280 * makefile.w32-in: Update dependencies.
7281 (LISP_H): Add inttypes.h and stdin.h.
7282 (PROCESS_H): Add unistd.h.
7283
7284 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7285
7286 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7287 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7288
7289 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7290
7291 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7292
7293 * term.c (vfatal): Remove stray call to va_end.
7294 It's not needed and the C Standard doesn't allow it here anyway.
7295
7296 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7297 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7298
7299 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7300 bytes.
7301
7302 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7303
7304 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7305
7306 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7307
7308 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7309
7310 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7311
7312 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7313 * charset.c (Fdefine_charset_internal): Don't initialize
7314 charset.code_space[15]. The value was garbage, on hosts with
7315 32-bit int (Bug#8600).
7316
7317 * lread.c (read_integer): Be more consistent with string-to-number.
7318 Use string_to_number to do the actual conversion; this avoids
7319 rounding errors and fixes some other screwups. Without this fix,
7320 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7321 (digit_to_number): Move earlier, for benefit of read_integer.
7322 Return -1 if the digit is out of range for the base, -2 if it is
7323 not a digit in any supported base. (Bug#8602)
7324
7325 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7326
7327 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7328 to match comment at start of function. This also removes a
7329 GCC warning about overflow in a 32+64-bit port.
7330
7331 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7332
7333 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7334 Reported by Stefan Monnier in
7335 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7336 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7337 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7338
7339 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7340 (EMACS_UINTPTR): Likewise, with uintptr_t.
7341
7342 * lisp.h: Prefer 64-bit EMACS_INT if available.
7343 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7344 on 32-bit hosts that have 64-bit int, so that they can access
7345 large files.
7346 However, temporarily disable this change unless the temporary
7347 symbol WIDE_EMACS_INT is defined.
7348
7349 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7350
7351 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7352 This removes an assumption that EMACS_INT and long are the same
7353 width as pointers. The assumption is true for Emacs porting targets
7354 now, but we want to make other targets possible.
7355 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7356 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7357 In the rest of the code, change types of integers that hold casted
7358 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7359 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7360 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7361 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7362 No need to cast type when ORing.
7363 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7364 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7365 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7366 assume EMACS_INT is the same width as char *.
7367 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7368 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7369 Remove no-longer-needed casts.
7370 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7371 (xg_tool_bar_help_callback, xg_make_tool_item):
7372 Use EMACS_INTPTR to hold an integer
7373 that will be cast to void *; this can avoid a GCC warning
7374 if EMACS_INT is not the same width as void *.
7375 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7376 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7377 (current_message_1, set_message_1):
7378 Use a local to convert to proper width without a cast.
7379 * xmenu.c (dialog_selection_callback): Likewise.
7380
7381 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7382 Also, don't assume VALBITS / RAND_BITS is less than 5,
7383 and don't rely on undefined behavior when shifting a 1 left into
7384 the sign bit.
7385 * lisp.h (get_random): Change signature to match.
7386
7387 * lread.c (hash_string): Use size_t, not int, for hash computation.
7388 Normally we prefer signed values; but hashing is special, because
7389 it's better to use unsigned division on hash table sizes so that
7390 the remainder is nonnegative. Also, size_t is the natural width
7391 for hashing into memory. The previous code used 'int', which doesn't
7392 retain enough info to hash well into very large tables.
7393 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7394
7395 * dbusbind.c: Don't possibly lose pointer info when converting.
7396 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7397 Use XPNTR rather than XHASH, so that the high-order bits of
7398 the pointer aren't lost when converting through void *.
7399
7400 * eval.c (Fautoload): Don't double-shift a pointer.
7401
7402 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7403
7404 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7405
7406 * gnutls.c (DEF_GNUTLS_FN):
7407 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7408
7409 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7410
7411 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7412 marker. (Bug#8610)
7413
7414 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7415
7416 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7417 New version that can reserve upto 2GB of heap space.
7418
7419 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7420
7421 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7422
7423 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7424
7425 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7426 `gnutls_certificate_set_x509_key_file'.
7427
7428 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7429
7430 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7431 Update dependencies.
7432
7433 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7434
7435 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7436 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7437 Remove unused parameter `fildes'.
7438 * process.c (read_process_output, send_process): Don't pass it.
7439
7440 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7441
7442 Fix previous change: the library cache is defined in w32.c.
7443 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7444 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7445
7446 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7447
7448 Implement dynamic loading of GnuTLS on Windows.
7449
7450 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7451 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7452 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7453 Declare.
7454
7455 * gnutls.c (Qgnutls_dll): Define.
7456 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7457 (gnutls_*): Declare function pointers.
7458 (init_gnutls_functions): New function to initialize function pointers.
7459 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7460 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7461 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7462 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7463 (emacs_gnutls_write, emacs_gnutls_read)
7464 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7465 (Fgnutls_available_p): New function.
7466 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7467 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7468 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7469
7470 * image.c: Include w32.h.
7471 (Vimage_type_cache): Delete.
7472 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7473 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7474 (w32_delayed_load): Move to w32.c.
7475
7476 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7477
7478 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7479 (w32_delayed_load): Move from image.c. When loading a library, record
7480 its filename in the :loaded-from property of the library id.
7481 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7482 Initialize and staticpro them.
7483 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7484
7485 * process.c: Include lisp.h before w32.h, not after.
7486 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7487 instead of gnutls_record_check_pending.
7488
7489 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7490
7491 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7492
7493 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7494 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7495 as passed in.
7496
7497 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7498
7499 * xterm.c (x_set_frame_alpha): Do not set property on anything
7500 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7501
7502 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7503
7504 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7505
7506 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7507
7508 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7509 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7510 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7511 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7512 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7513 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7514 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7515 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7516 (Qgnutls_bootprop_callbacks_verify): Make static.
7517
7518 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7519
7520 * callproc.c: Indentation fixup.
7521
7522 * sysdep.c (wait_for_termination_1): Make static.
7523 (wait_for_termination, interruptible_wait_for_termination):
7524 Move after wait_for_termination_1.
7525
7526 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7527
7528 * sysdep.c (interruptible_wait_for_termination): New function
7529 which is like wait_for_termination, but allows keyboard
7530 interruptions.
7531
7532 * callproc.c (Fcall_process): Add (:file "file") as an option for
7533 the STDOUT buffer.
7534 (Fcall_process_region): Ditto.
7535
7536 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7537
7538 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7539 rather than `XVECTOR (FOO)->size'.
7540
7541 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7542 inttypes.h, as a gnulib replacement is used if it not available in
7543 system headers.
7544
7545 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7546
7547 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7548 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7549 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7550
7551 * coding.c (coding_alloc_by_realloc): Error out if destination
7552 will grow beyond MOST_POSITIVE_FIXNUM.
7553 (decode_coding_emacs_mule): Abort if there isn't enough place in
7554 charbuf for the composition carryover bytes. Reserve an extra
7555 space for up to 2 characters produced in a loop.
7556 (decode_coding_iso_2022): Abort if there isn't enough place in
7557 charbuf for the composition carryover bytes.
7558
7559 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7560
7561 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7562 aborting when %lld or %lll format is passed.
7563 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7564 %llo or %llx format is passed. (Bug#8545)
7565
7566 * window.c (window_scroll_line_based): Use a marker instead of
7567 simple variables to record original value of point. (Bug#7952)
7568
7569 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7570 produced by %s or %c overflows available buffer space. (Bug#8545)
7571
7572 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7573
7574 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7575 (SIZE_MAX): Move defn after all includes, as they might #define it.
7576
7577 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7578
7579 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7580
7581 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7582
7583 * keyboard.c (Qdelayed_warnings_hook): Define.
7584 (command_loop_1): Run `delayed-warnings-hook'
7585 if Vdelayed_warnings_list is non-nil.
7586 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7587 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7588
7589 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7590
7591 * doprnt.c (doprnt): Don't return value smaller than the buffer
7592 size if the message was truncated. (Bug#8545).
7593
7594 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7595
7596 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7597 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7598
7599 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7600
7601 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7602
7603 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7604
7605 * makefile.w32-in: Update dependencies.
7606
7607 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7608
7609 Improve `doprnt' and its usage. (Bug#8545)
7610 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7611 `format_end'. Remove support for %l as a conversion specifier.
7612 Don't use xrealloc. Improve diagnostics when the %l size modifier
7613 is used. Update the commentary.
7614
7615 * eval.c (verror): Simplify calculation of size_t.
7616
7617 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7618 messages.
7619
7620 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7621
7622 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7623 change.
7624
7625 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7626
7627 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7628 This makes this file independent of the recent pseudovector change.
7629
7630 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7631
7632 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7633
7634 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7635 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7636 Remove unused local.
7637 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7638
7639 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7640 GCC 4.6.0 optimizes based on type-based alias analysis.
7641 For example, if b is of type struct buffer * and v of type struct
7642 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7643 != &v->size, and therefore "v->size = 1; b->size = 2; return
7644 v->size;" must therefore return 1. This assumption is incorrect
7645 for Emacs, since it type-puns struct Lisp_Vector * with many other
7646 types. To fix this problem, this patch adds a new type struct
7647 vectorlike_header that documents the constraints on layout of vectors
7648 and pseudovectors, and helps optimizing compilers not get fooled
7649 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7650 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7651 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7652 the size member.
7653 (XSETPVECTYPE): Rewrite in terms of new macro.
7654 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7655 This is a bit clearer, and further avoids the possibility of
7656 undesirable aliasing.
7657 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7658 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7659 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7660 since Lisp_Subr is a special case (no "next" field).
7661 (ASIZE): Now uses header.size rather than size.
7662 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7663 to avoid the hassle of writing XVECTOR (foo)->header.size.
7664 (struct vectorlike_header): New type.
7665 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7666 object, to help avoid aliasing.
7667 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7668 (SUBRP): Likewise, since Lisp_Subr is a special case.
7669 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7670 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7671 (struct Lisp_Hash_Table): Combine first two members into a single
7672 struct vectorlike_header member. All uses of "size" and "next" members
7673 changed to be "header.size" and "header.next".
7674 * buffer.h (struct buffer): Likewise.
7675 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7676 * frame.h (struct frame): Likewise.
7677 * process.h (struct Lisp_Process): Likewise.
7678 * termhooks.h (struct terminal): Likewise.
7679 * window.c (struct save_window_data, struct saved_window): Likewise.
7680 * window.h (struct window): Likewise.
7681 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7682 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7683 * buffer.c (init_buffer_once): Likewise.
7684 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7685 special case.
7686 * process.c (Fformat_network_address): Use local var for size,
7687 for brevity.
7688
7689 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7690
7691 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7692 * data.c (atof): Remove decl; no longer used or needed.
7693 (digit_to_number): Move to lread.c.
7694 (Fstring_to_number): Use new string_to_number function, to be
7695 consistent with how the Lisp reader treats infinities and NaNs.
7696 Do not assume that floating-point numbers represent EMACS_INT
7697 without losing information; this is not true on most 64-bit hosts.
7698 Avoid double-rounding errors, by insisting on integers when
7699 parsing non-base-10 numbers, as the documentation specifies.
7700 * lisp.h (string_to_number): New decl, replacing ...
7701 (isfloat_string): Remove.
7702 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7703 (read1): Do not accept +. and -. as integers; this
7704 appears to have been a coding error. Similarly, do not accept
7705 strings like +-1e0 as floating point numbers. Do not report
7706 overflow for integer overflows unless the base is not 10 which
7707 means we have no simple and reliable way to continue.
7708 Break out the floating-point parsing into a new
7709 function string_to_number, so that Fstring_to_number parses
7710 floating point numbers consistently with the Lisp reader.
7711 (digit_to_number): Move here from data.c. Make it static inline.
7712 (E_CHAR, EXP_INT): Remove, replacing with ...
7713 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7714 (string_to_number): New function, replacing isfloat_string.
7715 This function checks for valid syntax and produces the resulting
7716 Lisp float number too. Rework it so that string-to-number
7717 no longer mishandles examples like "1.0e+". Use strtoumax,
7718 so that overflow for non-base-10 numbers is reported only when
7719 there's no portable and simple way to convert to floating point.
7720
7721 * textprop.c (set_text_properties_1): Rewrite for clarity,
7722 and to avoid GCC warning about integer overflow.
7723
7724 * intervals.h (struct interval): Use EMACS_INT for members
7725 where EMACS_UINT might cause problems. See
7726 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7727 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7728 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7729 All uses changed.
7730 (offset_intervals): Tell GCC not to worry about length overflow
7731 when negating a negative length.
7732
7733 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7734 (overrun_check_free): Likewise.
7735
7736 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7737 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7738 word size.
7739
7740 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7741 (gnutls_make_error): Rename local to avoid shadowing.
7742 (gnutls_emacs_global_deinit): ifdef out; not used.
7743 (Fgnutls_boot): Use const for pointer to readonly storage.
7744 Comment out unused local. Fix pointer signedness problems.
7745
7746 * lread.c (openp): Don't stuff size_t into an 'int'.
7747 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7748 about possible signed overflow.
7749
7750 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7751 (GDK_KEY_g): Don't define if already defined.
7752 (xg_prepare_tooltip): Avoid pointer signedness problem.
7753 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7754
7755 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7756 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7757
7758 * xfns.c (Fx_window_property): Simplify a bit,
7759 to make a bit faster and to avoid GCC 4.6.0 warning.
7760 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7761
7762 * fns.c (internal_equal): Don't assume size_t fits in int.
7763
7764 * alloc.c (compact_small_strings): Tighten assertion a little.
7765
7766 Replace pEd with more-general pI, and fix some printf arg casts.
7767 * lisp.h (pI): New macro, generalizing old pEd macro to other
7768 conversion specifiers. For example, use "...%"pI"d..." rather
7769 than "...%"pEd"...".
7770 (pEd): Remove. All uses replaced with similar uses of pI.
7771 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7772 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7773 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7774 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7775 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7776 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7777 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7778 64-bit hosts.
7779 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7780 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7781 * print.c (safe_debug_print, print_object): Likewise.
7782 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7783 to int.
7784 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7785 avoiding the 0 flag, which is not portable.
7786 * process.c (Fmake_network_process): Use pI to avoid cast.
7787 * region-cache.c (pp_cache): Likewise.
7788 * xdisp.c (decode_mode_spec): Likewise.
7789 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7790 behavior on 64-bit hosts with printf arg.
7791 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7792 (x_stop_queuing_selection_requests): Likewise.
7793 (x_get_window_property): Don't truncate byte count to an 'int'
7794 when tracing.
7795
7796 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7797 here, since it parses constructs like leading '-' and spaces,
7798 which are not wanted; and it overflows with large numbers.
7799 Instead, simply match F[0-9]+, which is what is wanted anyway.
7800
7801 * alloc.c: Remove unportable assumptions about struct layout.
7802 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7803 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7804 (allocate_vectorlike, make_pure_vector): Use the new macros,
7805 plus offsetof, to remove unportable assumptions about struct layout.
7806 These assumptions hold on all porting targets that I know of, but
7807 they are not guaranteed, they're easy to remove, and removing them
7808 makes further changes easier.
7809
7810 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7811 This doesn't fix a bug but makes the code clearer.
7812 (string_overrun_cookie): Now const. Use initializers that
7813 don't formally overflow signed char, to avoid warnings.
7814 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7815 can cause Emacs to crash when string overrun checking is enabled.
7816 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7817 multiple of sizeof (EMACS_INT); it need not be, if
7818 alignof(EMACS_INT) < sizeof (EMACS_INT).
7819 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7820
7821 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7822
7823 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7824
7825 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7826
7827 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7828 supposed to be handshaking. (Bug#8556)
7829 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7830
7831 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7832
7833 * lisp.h (Qdebug): List symbol.
7834 * eval.c (Qdebug): Restore global linkage.
7835 * keyboard.c (debug-on-event): New variable.
7836 (handle_user_signal): Break into debugger when debug-on-event
7837 matches the current signal symbol.
7838
7839 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7840
7841 * alloc.c (check_sblock, check_string_bytes)
7842 (check_string_free_list): Convert to standard C.
7843
7844 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7845
7846 * w32.c (emacs_gnutls_push): Fix typo.
7847
7848 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7849
7850 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7851 "cast to pointer from integer of different size".
7852
7853 Improve doprnt and its use in verror. (Bug#8545)
7854 * doprnt.c (doprnt): Document the set of format control sequences
7855 supported by the function. Use SAFE_ALLOCA instead of always
7856 using `alloca'.
7857
7858 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7859 is one byte too soon. Don't use xrealloc; instead xfree and
7860 xmalloc anew.
7861
7862 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7863
7864 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7865 callbacks stage.
7866
7867 * gnutls.c: Renamed global_initialized to
7868 gnutls_global_initialized. Added internals for the
7869 :verify-hostname-error, :verify-error, and :verify-flags
7870 parameters of `gnutls-boot' and documented those parameters in the
7871 docstring. Start callback support.
7872 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7873 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7874 on error. Return error code.
7875 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7876 (emacs_gnutls_read): Likewise.
7877 (Fgnutls_boot): Return handshake error code.
7878 (emacs_gnutls_handle_error): New function.
7879 (wsaerror_to_errno): Likewise.
7880
7881 * w32.h (emacs_gnutls_pull): Add prototype.
7882 (emacs_gnutls_push): Likewise.
7883
7884 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7885 (emacs_gnutls_push): Likewise.
7886
7887 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7888
7889 * process.c (wait_reading_process_output): Check if GnuTLS
7890 buffered some data internally if no FDs are set for TLS
7891 connections.
7892
7893 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7894 (LIBS): Link to USER_LIBS.
7895 ($(BLD)/gnutls.$(0)): New target.
7896
7897 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7898
7899 * xdisp.c (handle_single_display_spec): Rename the
7900 display_replaced_before_p argument into display_replaced_p, to
7901 make it consistent with the commentary. Fix typos in the
7902 commentary.
7903
7904 * textprop.c (syms_of_textprop): Remove dead code.
7905 (copy_text_properties): Delete obsolete commentary about an
7906 interface that was deleted long ago. Fix typos in the description
7907 of arguments.
7908
7909 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7910 to changes in oldXMenu/XMenu.h from 2011-04-16.
7911 <menu_help_message, prev_menu_help_message>: Constify.
7912 (IT_menu_make_room): menu->help_text is now `const char **';
7913 adjust.
7914
7915 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7916 to changes in oldXMenu/XMenu.h from 2011-04-16.
7917 (struct XMenu): Declare `help_text' `const char **'.
7918
7919 * xfaces.c <Qunspecified>: Make extern again.
7920
7921 * syntax.c: Include sys/types.h before including regex.h, as
7922 required by POSIX.
7923
7924 * doc.c (get_doc_string): Improve the format passed to `error'.
7925
7926 * doprnt.c (doprnt): Improve commentary.
7927
7928 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7929
7930 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7931 them with etags.
7932
7933 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7934 changes in globals.h immediately force recompilation.
7935 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7936 $(CURDIR)/s/ms-w32.h.
7937 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7938
7939 * character.c (Fchar_direction): Function deleted.
7940 (syms_of_character): Don't defsubr it.
7941 <char-direction-table>: Deleted.
7942
7943 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7944
7945 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7946 * doprnt.c: Include limits.h.
7947 (SIZE_MAX): New macro.
7948 (doprnt): Return a size_t value. 2nd arg is now size_t.
7949 Many local variables are now size_t instead of int or unsigned.
7950 Improve overflow protection. Support `l' modifier for integer
7951 conversions. Support %l conversion. Don't assume an EMACS_INT
7952 argument for integer conversions and for %c.
7953
7954 * lisp.h (doprnt): Restore prototype.
7955
7956 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7957 $(SRC)/character.h.
7958
7959 * Makefile.in (base_obj): Add back doprnt.o.
7960
7961 * deps.mk (doprnt.o): Add back prerequisites.
7962 (callint.o): Depend on character.h.
7963
7964 * eval.c (internal_lisp_condition_case): Include the handler
7965 representation in the error message.
7966 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7967 when breaking from the loop.
7968
7969 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7970
7971 * callint.c (Fcall_interactively): When displaying error message
7972 about invalid control letter, pass the character's codepoint, not
7973 a pointer to its multibyte form. Improve display of the character
7974 in octal and display also its hex code.
7975
7976 * character.c (char_string): Use %x to display the (unsigned)
7977 codepoint of an invalid character, to avoid displaying a bogus
7978 negative value.
7979
7980 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7981 `error', not SYMBOL_NAME itself.
7982
7983 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7984 character arguments to `error'.
7985
7986 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7987 to `error' in error message about FINAL_CHAR argument. Make sure
7988 FINAL_CHAR is a character, and use %c when it is passed as
7989 argument to `error'.
7990
7991 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7992
7993 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7994
7995 * w32.c: Include <time.h>.
7996 (sys_localtime): New function.
7997
7998 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7999
8000 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8001
8002 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8003
8004 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8005
8006 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8007 zombies (Bug#8467).
8008
8009 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8010
8011 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8012 gl_state.e_property when gl_state.object is Qt.
8013
8014 * insdel.c (make_gap_larger): Remove limitation of buffer size
8015 to <= INT_MAX.
8016
8017 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8018
8019 * xdisp.c (lookup_glyphless_char_display)
8020 (produce_glyphless_glyph): Handle cons cell entry in
8021 glyphless-char-display.
8022 (Vglyphless_char_display): Document it.
8023
8024 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8025 glyphless-char-display.
8026
8027 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8028
8029 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8030
8031 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8032
8033 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8034 definition for no-X builds.
8035
8036 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
8037
8038 Static checks with GCC 4.6.0 and non-default toolkits.
8039
8040 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8041
8042 * process.c (keyboard_bit_set): Define only if SIGIO.
8043 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8044 (send_process): Repair possible setjmp clobbering.
8045
8046 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8047
8048 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8049
8050 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8051
8052 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8053 Define only if needed.
8054
8055 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8056 by pacifying GCC about it. Maybe it's time to retire it?
8057 * xfaces.c (USG, __TIMEVAL__): Likewise.
8058
8059 * dispextern.h (struct redisplay_interface): Rename param
8060 to avoid shadowing.
8061 * termhooks.h (struct terminal): Likewise.
8062 * xterm.c (xembed_send_message): Likewise.
8063
8064 * insdel.c (make_gap_smaller): Define only if
8065 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8066
8067 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8068 it.
8069
8070 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8071 so that we aren't warned about unused symbols.
8072
8073 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8074
8075 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8076
8077 * xfns.c (x_real_positions): Mark locals as initialized.
8078
8079 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8080
8081 * xterm.c: Fix problems found by static analysis with other toolkits.
8082 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8083 (x_dispatch_event): Declare static if USE_GTK, and
8084 define if USE_GTK || USE_X_TOOLKIT.
8085 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8086 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8087 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8088 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8089
8090 * xmenu.c (menu_help_callback): Pointer type fixes.
8091 Use const pointers when pointing at readonly data. Avoid pointer
8092 signedness clashes.
8093 (FALSE): Remove unused macro.
8094 (update_frame_menubar): Remove unused decl.
8095
8096 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8097
8098 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8099 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8100 (single_menu_item): Rename local to avoid shadowing.
8101
8102 * keyboard.c (make_lispy_event): Remove unused local var.
8103
8104 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8105 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8106
8107 * bitmaps: Change bitmaps from unsigned char back to the X11
8108 compatible char. Avoid the old compiler warnings about
8109 out-of-range initializers by using, for example, '\xab' rather
8110 than 0xab.
8111
8112 * xgselect.c (xgselect_initialize): Check vs interface
8113 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8114
8115 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8116
8117 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8118 to read-only memory.
8119
8120 * fns.c (vector): Remove; this old hack is no longer needed.
8121
8122 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
8123 Remove unused var.
8124 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
8125
8126 * xrdb.c (x_load_resources): Omit unused local.
8127
8128 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8129 (x_window): Rename locals to avoid shadowing.
8130 (USG): Use the kludged USG macro, to pacify gcc.
8131
8132 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
8133 (x_term_init): Remove local to avoid shadowing.
8134
8135 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
8136
8137 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8138 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8139
8140 2011-04-16 Eli Zaretskii <eliz@gnu.org>
8141
8142 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8143
8144 Fix regex.c, syntax.c and friends for buffers > 2GB.
8145 * syntax.h (struct gl_state_s): Declare character position members
8146 EMACS_INT.
8147
8148 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8149
8150 * textprop.c (verify_interval_modification, interval_of):
8151 Declare arguments EMACS_INT.
8152
8153 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8154 EMACS_INT.
8155
8156 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8157
8158 * indent.c (Fvertical_motion): Local variable it_start is now
8159 EMACS_INT.
8160
8161 * regex.c (re_match, re_match_2, re_match_2_internal)
8162 (bcmp_translate, regcomp, regexec, print_double_string)
8163 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8164 (re_compile_pattern, re_exec): Declare arguments and local
8165 variables `size_t' and `ssize_t' and return values `regoff_t', as
8166 appropriate.
8167 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8168 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8169 <compile_stack_type>: `size' and `avail' are now `size_t'.
8170
8171 * regex.h <regoff_t>: Use ssize_t, not int.
8172 (re_search, re_search_2, re_match, re_match_2): Arguments that
8173 specify buffer/string position and length are now ssize_t and
8174 size_t. Return type is regoff_t.
8175
8176 2011-04-16 Ben Key <bkey76@gmail.com>
8177
8178 * nsfont.m: Fixed bugs in ns_get_family and
8179 ns_descriptor_to_entity that were caused by using free to
8180 deallocate memory blocks that were allocated by xmalloc (via
8181 xstrdup). This caused Emacs to crash when compiled with
8182 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8183 --enable-checking=xmallocoverrun). xfree is now used to
8184 deallocate these memory blocks.
8185
8186 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8187
8188 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8189
8190 emacs_write: Accept and return EMACS_INT for sizes.
8191 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8192 et seq.
8193 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8194 Accept and return EMACS_INT.
8195 (emacs_gnutls_write): Return the number of bytes written on
8196 partial writes.
8197 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8198 (emacs_read, emacs_write): Remove check for negative size, as the
8199 Emacs source code has been audited now.
8200 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8201 (emacs_read, emacs_write): Use it.
8202 * process.c (send_process): Adjust to the new signatures of
8203 emacs_write and emacs_gnutls_write. Do not attempt to store
8204 a byte offset into an 'int'; it might overflow.
8205 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8206
8207 * sound.c: Don't assume sizes fit in 'int'.
8208 (struct sound_device.period_size, alsa_period_size):
8209 Return EMACS_INT, not int.
8210 (struct sound_device.write, vox_write, alsa_write):
8211 Accept EMACS_INT, not int.
8212 (wav_play, au_play): Use EMACS_INT to store sizes and to
8213 record read return values.
8214
8215 2011-04-15 Ben Key <bkey76@gmail.com>
8216
8217 * keyboard.c (Qundefined): Don't declare static since it is used
8218 in nsfns.m.
8219 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8220 static since they are used in nsfont.m.
8221
8222 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8223
8224 * process.c (Qprocessp): Don't declare static.
8225 * lisp.h (Qprocessp): Declare again.
8226
8227 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8228
8229 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8230
8231 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8232
8233 Improve C-level modularity by making more things 'static'.
8234
8235 Don't publish debugger-only interfaces to other modules.
8236 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8237 (verify_bytepos, count_markers): Move decls to the only modules
8238 that need them.
8239 * region-cache.h (pp_cache): Likewise.
8240 * window.h (check_all_windows): Likewise.
8241 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8242
8243 * sysdep.c (croak): Now static, if
8244 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8245 * syssignal.h (croak): Declare only if not static.
8246
8247 * alloc.c (refill_memory_reserve): Now static if
8248 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8249 * lisp.h (refill_memory_reserve): Declare only if not static.
8250
8251 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8252 Define only if USE_LUCID.
8253
8254 * xrdb.c (x_customization_string, x_rm_string): Now static.
8255
8256 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8257 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8258
8259 * xdisp.c (draw_row_with_mouse_face): Now static.
8260 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8261
8262 * window.h (check_all_windows): Mark externally visible.
8263
8264 * window.c (window_deletion_count): Now static.
8265
8266 * undo.c: Make symbols static if they're not exported.
8267 (last_undo_buffer, last_boundary_position, pending_boundary):
8268 Now static.
8269
8270 * textprop.c (interval_insert_behind_hooks): Now static.
8271 (interval_insert_in_front_hooks): Likewise.
8272
8273 * term.c: Make symbols static if they're not exported.
8274 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8275 (max_frame_lines, tty_set_terminal_modes):
8276 (tty_reset_terminal_modes, tty_turn_off_highlight):
8277 (get_tty_terminal): Now static.
8278 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8279 * termhooks.h (term_mouse_moveto): Do not declare if
8280 HAVE_WINDOW_SYSTEM.
8281 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8282 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8283
8284 * sysdep.c: Make symbols static if they're not exported.
8285 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8286 Now static.
8287 (sigprocmask_set, full_mask): Remove; unused.
8288 (wait_debugging): Mark as visible.
8289 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8290 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8291
8292 * syntax.c (syntax_temp): Define only if !__GNUC__.
8293
8294 * sound.c (current_sound_device, current_sound): Now static.
8295
8296 * search.c (searchbufs, searchbuf_head): Now static.
8297
8298 * scroll.c (scroll_cost): Remove; unused.
8299 * dispextern.h (scroll_cost): Remove decl.
8300
8301 * region-cache.h (pp_cache): Mark as externally visible.
8302
8303 * process.c: Make symbols static if they're not exported.
8304 (process_tick, update_tick, create_process, chan_process):
8305 (Vprocess_alist, proc_buffered_char, datagram_access):
8306 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8307 (deactivate_process): Mark defn as static, as well as decl.
8308 * lisp.h (create_process): Remove decl.
8309 * process.h (chan_process, Vprocess_alist): Remove decls.
8310
8311 * print.c: Make symbols static if they're not exported.
8312 (print_depth, new_backquote_output, being_printed, print_buffer):
8313 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8314 (print_interval, print_number_index, initial_stderr_stream):
8315 Now static.
8316 * lisp.h (Fprinc): Remove decl.
8317 (debug_output_compilation_hack): Mark as externally visible.
8318
8319 * sysdep.c (croak): Move decl from here to syssignal.h.
8320 * syssignal.h (croak): Put it here, so the API can be checked when
8321 'croak' is called from dissociate_if_controlling_tty.
8322
8323 * minibuf.c: Make symbols static if they're not exported.
8324 (minibuf_save_list, choose_minibuf_frame): Now static.
8325 * lisp.h (choose_minibuf_frame): Remove decl.
8326
8327 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8328
8329 * lread.c: Make symbols static if they're not exported.
8330 (read_objects, initial_obarray, oblookup_last_bucket_number):
8331 Now static.
8332 (make_symbol): Remove; unused.
8333 * lisp.h (initial_obarray, make_symbol): Remove decls.
8334
8335 * keyboard.c: Make symbols static if they're not exported.
8336 (single_kboard, recent_keys_index, total_keys, recent_keys):
8337 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8338 (this_single_command_key_start, echoing, last_auto_save):
8339 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8340 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8341 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8342 (Vlispy_mouse_stem, double_click_count):
8343 Now static.
8344 (force_auto_save_soon): Define only if SIGDANGER.
8345 (ignore_mouse_drag_p): Now static if
8346 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8347 (print_help): Remove; unused.
8348 (stop_character, last_timer_event): Mark as externally visible.
8349 * keyboard.h (ignore_mouse_drag_p): Declare only if
8350 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8351 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8352 * lisp.h (echoing): Remove decl.
8353 (force_auto_save_soon): Declare only if SIGDANGER.
8354 * xdisp.c (redisplay_window): Simplify code, to make it more
8355 obvious that ignore_mouse_drag_p is not accessed if !defined
8356 USE_GTK && !defined HAVE_NS.
8357
8358 * intervals.c: Make symbols static if they're not exported.
8359 (merge_properties_sticky, merge_interval_right, delete_interval):
8360 Now static.
8361 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8362
8363 * insdel.c: Make symbols static if they're not exported.
8364 However, leave prepare_to_modify_buffer alone. It's never
8365 called from outside this function, but that appears to be a bug.
8366 (combine_after_change_list, combine_after_change_buffer):
8367 (adjust_after_replace, signal_before_change): Now static.
8368 (adjust_after_replace_noundo): Remove; unused.
8369 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8370 (signal_before_change): Remove decls.
8371
8372 * indent.c (val_compute_motion, val_vmotion): Now static.
8373
8374 * image.c: Make symbols static if they're not exported.
8375 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8376 if USE_GTK.
8377 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8378 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8379
8380 * fringe.c (standard_bitmaps): Now static.
8381 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8382
8383 * frame.c: Make symbols static if they're not exported.
8384 (x_report_frame_params, make_terminal_frame): Now static.
8385 (get_frame_param): Now static, unless HAVE_NS.
8386 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8387 (x_get_resource_string): Remove; not used.
8388 * frame.h (make_terminal_frame, x_report_frame_params):
8389 (x_get_resource_string); Remove decls.
8390 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8391 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8392
8393 * font.c, fontset.c: Make symbols static if they're not exported.
8394 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8395 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8396 * font.c (font_close_object): Now static.
8397 * font.h (font_close_object): Remove.
8398 * fontset.c (FONTSET_OBJLIST): Remove.
8399 (free_realized_fontset) #if-0 the body, which does nothing.
8400 (face_suitable_for_char_p): #if-0, as it's never called.
8401 * fontset.h (face_suitable_for_char_p): Remove decl.
8402 * xfaces.c (face_at_string_position):
8403 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8404 since 0 is always ASCII.
8405
8406 * fns.c (weak_hash_tables): Now static.
8407
8408 * fileio.c: Make symbols static if they're not exported.
8409 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8410 (Vwrite_region_annotation_buffers): Now static.
8411
8412 * eval.c: Make symbols static if they're not exported.
8413 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8414 * lisp.h (backtrace_list): Remove decl.
8415
8416 * emacs.c: Make symbols static if they're not exported.
8417 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8418 (fatal_error_code, fatal_error_signal_hook, standard_args):
8419 Now static.
8420 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8421 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8422 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8423 * lisp.h (fatal_error_signal_hook): Remove decl.
8424 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8425
8426 * editfns.c: Move a (normally-unused) function to its only use.
8427 * editfns.c, lisp.h (get_operating_system_release): Remove.
8428 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8429 worth the hassle of breaking this out.
8430
8431 * xterm.c: Make symbols static if they're not exported.
8432 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8433 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8434 (x_destroy_window, x_delete_display):
8435 Now static.
8436 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8437 (x_mouse_leave): Remove; unused.
8438 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8439 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8440 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8441 Remove decls.
8442 (x_mouse_leave): Declare only if WINDOWSNT.
8443 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8444 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8445 USE_X_TOOLKIT.
8446
8447 * ftxfont.c: Make symbols static if they're not exported.
8448 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8449 HAVE_FREETYPE.
8450 * font.h (ftxfont_driver): Likewise.
8451
8452 * xfns.c: Make symbols static if they're not exported.
8453 (x_last_font_name, x_display_info_for_name):
8454 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8455 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8456 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8457 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8458 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8459 (last_show_tip_args): Now static.
8460 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8461 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8462 (x_screen_planes): Remove; unused.
8463 * dispextern.h (x_screen_planes): Remove decl.
8464
8465 * dispnew.c: Make symbols static if they're not exported.
8466 * dispextern.h (redraw_garbaged_frames, scrolling):
8467 (increment_row_positions): Remove.
8468 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8469 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8470 Now static.
8471 (redraw_garbaged_frames): Remove; unused.
8472
8473 * xfaces.c: Make symbols static if they're not exported.
8474 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8475 Remove decls.
8476 * xterm.h (defined_color): Remove decls.
8477 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8478 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8479 (menu_face_changed_default, defined_color, free_realized_face):
8480 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8481 (ascii_face_of_lisp_face): Remove; unused.
8482
8483 * xdisp.c: Make symbols static if they're not exported.
8484 * dispextern.h (scratch_glyph_row, window_box_edges):
8485 (glyph_to_pixel_coords, set_cursor_from_row):
8486 (get_next_display_element, set_iterator_to_next):
8487 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8488 (show_mouse_face): Remove decls
8489 * frame.h (message_buf_print): Likewise.
8490 * lisp.h (pop_message, set_message, check_point_in_composition):
8491 Likewise.
8492 * xterm.h (set_vertical_scroll_bar): Likewise.
8493 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8494 (message_buf_print, scratch_glyph_row, displayed_buffer):
8495 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8496 (get_next_display_element, show_mouse_face, window_box_edges):
8497 (frame_to_window_pixel_xy, check_point_in_composition):
8498 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8499 (glyph_to_pixel_coords): Remove; unused.
8500
8501 * dired.c (file_name_completion): Now static.
8502
8503 * dbusbind.c (xd_in_read_queued_messages): Now static.
8504
8505 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8506 * data.c (circular_list_error): Remove.
8507
8508 * commands.h (last_point_position, last_point_position_buffer):
8509 (last_point_position_window): Remove decls.
8510 * keyboard.c: Make these variables static.
8511
8512 * coding.h (coding, code_convert_region, encode_coding_gap):
8513 Remove decls.
8514 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8515 (iso_code_class, detect_coding, code_convert_region): Now static.
8516 (encode_coding_gap): Remove; unused.
8517
8518 * chartab.c (chartab_chars, chartab_bits): Now static.
8519
8520 * charset.h (charset_iso_8859_1): Remove decl.
8521 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8522 Now static.
8523
8524 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8525 * ccl.c (Vccl_program_table): Now static.
8526 (check_ccl_update): Remove; unused.
8527
8528 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8529 * category.h: ... from here.
8530 * category.c (check_category_table, set_category_set): Now static.
8531
8532 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8533 * lisp.h: Remove these decls.
8534
8535 * buffer.c (buffer_count): Remove unused var.
8536
8537 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8538 so that it's not optimized away.
8539 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8540 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8541 exported only to the debugger.
8542
8543 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8544 * atimer.h (run_all_atimers): Remove; not exported.
8545
8546 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8547 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8548 was inaccessible from Lisp.
8549 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8550 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8551
8552 alloc.c: Import and export fewer symbols, and remove unused items.
8553 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8554 is defined.
8555 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8556 it's not optimized away by whole-program optimization.
8557 (message_enable_multibyte, free_misc): Remove.
8558 (catchlist, handlerlist, mark_backtrace):
8559 Declare only if BYTE_MARK_STACK.
8560 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8561 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8562 (message_enable_multibyte): Remove decl.
8563 (free_misc, interval_free_list, float_block, float_block_index):
8564 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8565 (cons_free_list, last_marked_index):
8566 Now static.
8567 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8568 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8569 (mark_backtrace): Define only if BYTE_MARK_STACK.
8570 * xdisp.c (message_enable_multibyte): Now static.
8571
8572 Declare Lisp_Object Q* variables to be 'static' if not exported.
8573 This makes it easier for human readers (and static analyzers)
8574 to see whether these variables are used from other modules.
8575 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8576 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8577 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8578 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8579 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8580 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8581 * xmenu.c, xselect.c:
8582 Declare Q* vars static if they are not used in other modules.
8583 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8584 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8585 Remove decls of unexported vars.
8586 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8587
8588 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8589
8590 Make Emacs functions such as Fatom 'static' by default.
8591 This makes it easier for human readers (and static analyzers)
8592 to see whether these functions can be called from other modules.
8593 DEFUN now defines a static function. To make the function external
8594 so that it can be used in other C modules, use the new macro DEFUE.
8595 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8596 (Finit_image_library):
8597 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8598 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8599 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8600 Remove decls, since these functions are now static.
8601 (Funintern, Fget_internal_run_time): New decls, since these functions
8602 were already external.
8603
8604 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8605 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8606 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8607 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8608 * keyboard.c, keymap.c, lread.c:
8609 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8610 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8611 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8612 Mark functions with DEFUE instead of DEFUN,
8613 if they are used in other modules.
8614 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8615 decls for now-static functions.
8616 * buffer.h (Fdelete_overlay): Remove decl.
8617 * callproc.c (Fgetenv_internal): Mark as internal.
8618 * composite.c (Fremove_list_of_text_properties): Remove decl.
8619 (Fcomposition_get_gstring): New forward static decl.
8620 * composite.h (Fcomposite_get_gstring): Remove decl.
8621 * dired.c (Ffile_attributes): New forward static decl.
8622 * doc.c (Fdocumntation_property): New forward static decl.
8623 * eval.c (Ffetch_bytecode): New forward static decl.
8624 (Funintern): Remove extern decl; now in .h file where it belongs.
8625 * fileio.c (Fmake_symbolic_link): New forward static decl.
8626 * image.c (Finit_image_library): New forward static decl.
8627 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8628 * intervals.h (Fprevious_property_change):
8629 (Fremove_list_of_text_properties): Remove decls.
8630 * keyboard.c (Fthis_command_keys): Remove decl.
8631 (Fcommand_execute): New forward static decl.
8632 * keymap.c (Flookup_key): New forward static decl.
8633 (Fcopy_keymap): Now static.
8634 * keymap.h (Flookup_key): Remove decl.
8635 * process.c (Fget_process): New forward static decl.
8636 (Fprocess_datagram_address): Mark as internal.
8637 * syntax.c (Fsyntax_table_p): New forward static decl.
8638 (skip_chars): Remove duplicate decl.
8639 * textprop.c (Fprevious_property_change): New forward static decl.
8640 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8641 Now internal.
8642 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8643 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8644
8645 * editfns.c (Fformat): Remove unreachable code.
8646
8647 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8648
8649 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8650 change. (Bug#8496)
8651
8652 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8653
8654 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8655 when at ZV. (Bug#8487)
8656
8657 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8658
8659 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8660 (Bug#8437)
8661 * keyboard.c (parse_tool_bar_item): Likewise.
8662 * sound.c (sound_cleanup, alsa_close): Likewise.
8663 * termcap.c (tgetent): Likewise.
8664 * xfns.c (x_default_font_parameter): Likewise.
8665 * xsettings.c (read_and_apply_settings): Likewise.
8666
8667 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8668 (overrun_check_free): Protoize.
8669
8670 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8671
8672 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8673 since callers should never pass a negative size.
8674 Change the signature to match that of plain 'read' and 'write'; see
8675 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8676 * lisp.h: Update prototypes of emacs_write and emacs_read.
8677
8678 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8679
8680 * xdisp.c (redisplay_window): Don't try to determine the character
8681 position of the scroll margin if the window start point w->startp
8682 is outside the buffer's accessible region. (Bug#8468)
8683
8684 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8685
8686 Fix write-region and its subroutines for buffers > 2GB.
8687 * fileio.c (a_write, e_write): Modify declaration of arguments and
8688 local variables to support buffers larger than 2GB.
8689 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8690
8691 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8692 argument, local variables, and return value.
8693
8694 * lisp.h: Update prototypes of emacs_write and emacs_read.
8695
8696 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8697
8698 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8699
8700 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8701
8702 Fix more problems found by GCC 4.6.0's static checks.
8703
8704 * xdisp.c (vmessage): Use a better test for character truncation.
8705
8706 * charset.c (load_charset_map): <, not <=, for optimization,
8707 and to avoid potential problems with integer overflow.
8708 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8709 * casetab.c (set_identity, shuffle): Likewise.
8710 * editfns.c (Fformat): Likewise.
8711 * syntax.c (skip_chars): Likewise.
8712
8713 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8714 This also lets GCC 4.6.0 generate slightly better loop code.
8715
8716 * callint.c (Fcall_interactively): <, not <=, for optimization.
8717 (Fcall_interactively): Count the number of arguments produced,
8718 not the number of arguments given. This is simpler and lets GCC
8719 4.6.0 generate slightly better code.
8720
8721 * ftfont.c: Distingish more carefully between FcChar8 and char.
8722 The previous code passed unsigned char * to a functions like
8723 strlen and xstrcasecmp that expect char *, which does not
8724 conform to the C standard.
8725 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8726 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8727 char * when the C standard requires it.
8728
8729 * keyboard.c (read_char): Remove unused var.
8730
8731 * eval.c: Port to Windows vsnprintf (Bug#8435).
8732 Include <limits.h>.
8733 (SIZE_MAX): Define if the headers do not.
8734 (verror): Do not give up if vsnprintf returns a negative count.
8735 Instead, grow the buffer. This ports to Windows vsnprintf, which
8736 does not conform to C99. Problem reported by Eli Zaretskii.
8737 Also, simplify the allocation scheme, by avoiding the need for
8738 calling realloc, and removing the ALLOCATED variable.
8739
8740 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8741
8742 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8743 But keep the doprint source code for now, as we might revamp it
8744 and use it again (Bug#8435).
8745 * lisp.h (doprnt): Remove.
8746 * Makefile.in (base_obj): Remove doprnt.o.
8747 * deps.mk (doprnt.o): Remove.
8748
8749 error: Print 32- and 64-bit integers portably (Bug#8435).
8750 Without this change, on typical 64-bit hosts error ("...%d...", N)
8751 was used to print both 32- and 64-bit integers N, which relied on
8752 undefined behavior.
8753 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8754 * lisp.h (error, verror): Mark as printf-like functions.
8755 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8756 Report overflow in size calculations when allocating printf buffer.
8757 Do not truncate output string at its first null byte.
8758 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8759 Truncate the output at a character boundary, since vsnprintf does not
8760 do that.
8761 * charset.c (check_iso_charset_parameter): Convert internal
8762 character to string before calling 'error', since %c now has the
8763 printf meaning.
8764 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8765 overflow when computing char to be passed to 'error'. Do not
8766 pass Lisp_Object to 'error'; pass the integer instead.
8767 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8768 formatted with plain %d.
8769
8770 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8771
8772 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8773
8774 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8775
8776 * xterm.c (x_catch_errors): Remove duplicate declaration.
8777
8778 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8779
8780 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8781
8782 2011-04-10 Jim Meyering <meyering@redhat.com>
8783
8784 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8785 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8786 return ssize_t not "int", and use size_t as the buffer length.
8787 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8788 * gnutls.h: Update declarations.
8789 * process.c (read_process_output): Use ssize_t, to match.
8790 (send_process): Likewise.
8791
8792 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8793
8794 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8795
8796 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8797
8798 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8799 Use unsigned char, to match FcChar8 type definition.
8800
8801 * xterm.c (handle_one_xevent):
8802 * xmenu.c (create_and_show_popup_menu):
8803 * xselect.c (x_decline_selection_request)
8804 (x_reply_selection_request): Avoid type-punned deref of X events.
8805
8806 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8807
8808 Fix some uses of `int' instead of EMACS_INT.
8809 * search.c (string_match_1, fast_string_match)
8810 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8811 (scan_buffer, find_next_newline_no_quit)
8812 (find_before_next_newline, search_command, Freplace_match)
8813 (Fmatch_data): Make some `int' variables be EMACS_INT.
8814
8815 * xdisp.c (display_count_lines): 3rd argument and return value now
8816 EMACS_INT. All callers changed.
8817 (pint2hrstr): Last argument is now EMACS_INT.
8818
8819 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8820 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8821 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8822 (decode_coding_utf_16, decode_coding_emacs_mule)
8823 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8824 (decode_coding_ccl, decode_coding_charset)
8825 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8826 (decode_coding_iso_2022, decode_coding_emacs_mule)
8827 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8828 <char_offset, last_offset>: Declare EMACS_INT.
8829 (encode_coding_utf_8, encode_coding_utf_16)
8830 (encode_coding_emacs_mule, encode_invocation_designation)
8831 (encode_designation_at_bol, encode_coding_iso_2022)
8832 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8833 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8834 Declare EMACS_INT.
8835 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8836 (encode_invocation_designation): Last argument P_NCHARS is now
8837 EMACS_INT.
8838 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8839 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8840
8841 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8842 All users changed.
8843
8844 * ccl.c (Fccl_execute_on_string): Declare some variables
8845 EMACS_INT.
8846
8847 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8848
8849 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8850
8851 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8852
8853 * process.c (Fformat_network_address): Doc fix.
8854
8855 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8856
8857 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8858
8859 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8860
8861 * keyboard.c (read_char): Call Lisp function help-form-show,
8862 instead of using internal_with_output_to_temp_buffer.
8863 (Qhelp_form_show): New var.
8864 (syms_of_keyboard): Use DEFSYM macro.
8865
8866 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8867
8868 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8869
8870 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8871
8872 * process.c (Flist_processes): Remove to Lisp.
8873 (list_processes_1): Delete.
8874
8875 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8876
8877 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8878
8879 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8880
8881 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8882
8883 Fix more problems found by GCC 4.6.0's static checks.
8884
8885 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8886
8887 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8888
8889 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8890
8891 * xdisp.c (vmessage): Mark as a printf-like function.
8892
8893 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8894
8895 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8896
8897 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8898 printf-like functions.
8899 (tiff_load): Add casts to remove these marks before passing them
8900 to system-supplied API.
8901
8902 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8903
8904 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8905 This avoids several warnings with gcc -Wstrict-overflow.
8906 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8907 directly, rather than having caller test rule sign. This avoids
8908 some unnecessary tests.
8909 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8910 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8911 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8912
8913 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8914 (xfont_open): Avoid unnecessary tests.
8915
8916 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8917
8918 * composite.h, composite.c (composition_gstring_put_cache):
8919 Use EMACS_INT, not int, for length.
8920
8921 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8922 breaking out part of COMPOSITION_DECODE_RULE.
8923 (COMPOSITION_DECODE_RULE): Use it.
8924 * composite.c (get_composition_id): Remove unused local vars,
8925 by using the new macro.
8926
8927 * textprop.c (set_text_properties_1): Change while to do-while,
8928 since the condition is always true at first.
8929
8930 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8931 (interval_deletion_adjustment): Return unsigned value.
8932 All uses changed.
8933
8934 * process.c (list_processes_1, create_pty, read_process_output):
8935 (exec_sentinel): Remove vars that were set but not used.
8936 (create_pty): Remove unnecessary "volatile"s.
8937 (Fnetwork_interface_info): Avoid possibility of int overflow.
8938 (read_process_output): Do adaptive read buffering even if carryover.
8939 (read_process_output): Simplify nbytes computation if buffered.
8940
8941 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8942
8943 * syntax.c (scan_words): Remove var that was set but not used.
8944 (update_syntax_table): Use unsigned instead of int.
8945
8946 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8947 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8948 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8949
8950 * print.c (print_error_message): Avoid int overflow.
8951
8952 * font.c (font_list_entities): Redo for clarity,
8953 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8954
8955 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8956 (font_score): Avoid potential overflow in diff calculation.
8957
8958 * fns.c (substring_both): Remove var that is set but not used.
8959 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8960
8961 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8962
8963 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8964 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8965 can always succeed if overflow has undefined behavior.
8966
8967 * search.c (boyer_moore, wordify): Remove vars set but not used.
8968 (wordify): Omit three unnecessary tests.
8969
8970 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8971 All callers changed. This avoids the need for an unused var.
8972
8973 * casefiddle.c (casify_region): Remove var that is set but not used.
8974
8975 * dired.c (file_name_completion): Remove var that is set but not used.
8976
8977 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8978
8979 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8980 (Finsert_file_contents): Remove unnecessary code checking fd.
8981
8982 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8983 Check for integer overflow on size calculations.
8984
8985 * buffer.c (Fprevious_overlay_change): Remove var that is set
8986 but not used.
8987
8988 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8989 Remove vars that are set but not used.
8990 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8991 (timer_check_2): Mark vars as initialized.
8992
8993 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8994
8995 * image.c (lookup_image): Remove var that is set but not used.
8996 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8997
8998 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8999 that are set but not used.
9000
9001 * xfns.c (make_invisible_cursor): Don't return garbage
9002 if XCreateBitmapFromData fails (Bug#8410).
9003
9004 * xselect.c (x_get_local_selection, x_handle_property_notify):
9005 Remove vars that are set but not used.
9006
9007 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9008 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9009
9010 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9011 Remove var that is set but not used.
9012 (scroll_bar_windows_size): Now size_t, not int.
9013 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9014 Check for overflow.
9015
9016 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9017 (map_tty_color) [!defined MSDOS]: Likewise.
9018
9019 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9020
9021 * coding.c: Remove vars that are set but not used.
9022 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9023 All callers changed.
9024 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9025 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9026 (decode_coding_charset): Remove vars that are set but not used.
9027
9028 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9029 that is set but not used.
9030
9031 * print.c (print_object): Remove var that is set but not used.
9032
9033 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9034 The gnulib version avoids calling malloc in the usual case,
9035 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9036 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9037 * filelock.c (current_lock_owner): Likewise.
9038 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9039 * sysdep.c: Include allocator.h, careadlinkat.h.
9040 (emacs_no_realloc_allocator): New static constant.
9041 (emacs_readlink): New function.
9042 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9043 ../lib/careadlinkat.h.
9044
9045 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9046
9047 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9048 first non-nil return value).
9049
9050 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9051
9052 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9053 if not defined (Bug#8403).
9054
9055 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9056
9057 * xdisp.c (display_count_lines): Remove parameter `start',
9058 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9059 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9060 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9061 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9062 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9063 and thereabouts. All callers changed.
9064 (get_per_char_metric): Remove parameter `f', unused since
9065 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9066
9067 2011-04-02 Jim Meyering <meyering@redhat.com>
9068
9069 do not dereference NULL upon failed strdup
9070 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9071 (ns_get_family): Likewise.
9072
9073 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9074
9075 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9076
9077 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9078
9079 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9080 later (Bug#8403).
9081
9082 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9083
9084 Add lexical binding.
9085
9086 * window.c (Ftemp_output_buffer_show): New fun.
9087 (Fsave_window_excursion):
9088 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9089
9090 * lread.c (lisp_file_lexically_bound_p): New function.
9091 (Fload): Bind Qlexical_binding.
9092 (readevalloop): Remove `evalfun' arg.
9093 Bind Qinternal_interpreter_environment.
9094 (Feval_buffer): Bind Qlexical_binding.
9095 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9096 Mark as dynamic.
9097 (syms_of_lread): Declare `lexical-binding'.
9098
9099 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9100
9101 * keyboard.c (eval_dyn): New fun.
9102 (menu_item_eval_property): Use it.
9103
9104 * image.c (parse_image_spec): Use Ffunctionp.
9105
9106 * fns.c (concat, mapcar1): Accept byte-code-functions.
9107
9108 * eval.c (Fsetq): Handle lexical vars.
9109 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9110 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9111 (FletX, Flet): Obey lexical binding.
9112 (Fcommandp): Handle closures.
9113 (Feval): New `lexical' arg.
9114 (eval_sub): New function extracted from Feval. Use it almost
9115 everywhere where Feval was used. Look up vars in lexical env.
9116 Handle closures.
9117 (Ffunctionp): Move from subr.el.
9118 (Ffuncall): Handle closures.
9119 (apply_lambda): Remove `eval_flags'.
9120 (funcall_lambda): Handle closures and new byte-code-functions.
9121 (Fspecial_variable_p): New function.
9122 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9123 but without exporting it to Lisp.
9124
9125 * doc.c (Fdocumentation, store_function_docstring):
9126 * data.c (Finteractive_form): Handle closures.
9127
9128 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9129 interactive spec.
9130
9131 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9132 New byte-codes.
9133 (exec_byte_code): New function extracted from Fbyte_code to handle new
9134 calling convention for byte-code-functions. Add new byte-codes.
9135
9136 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
9137
9138 * alloc.c (Fmake_symbol): Init new `declared_special' field.
9139
9140 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9141
9142 * xdisp.c (redisplay_internal): Fix prototype.
9143
9144 2011-03-31 Eli Zaretskii <eliz@gnu.org>
9145
9146 * xdisp.c (SCROLL_LIMIT): New macro.
9147 (try_scrolling): Use it when setting scroll_limit.
9148 Limit scrolling to 100 screen lines.
9149 (redisplay_window): Even when falling back on "recentering",
9150 position point in the window according to scroll-conservatively,
9151 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9152
9153 (try_scrolling): When point is above the window, allow searching
9154 as far as scroll_max, or one screenful, to compute vertical
9155 distance from PT to the scroll margin position. This prevents
9156 try_scrolling from unnecessarily failing when
9157 scroll-conservatively is set to a value slightly larger than the
9158 window height. Clean up the case of PT below the margin at bottom
9159 of window: scroll_max can no longer be INT_MAX. When aggressive
9160 scrolling is in use, don't let point enter the opposite scroll
9161 margin as result of the scroll.
9162 (syms_of_xdisp) <scroll-conservatively>: Document the
9163 threshold of 100 lines for never-recentering scrolling.
9164
9165 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9166
9167 * dispextern.h (move_it_by_lines):
9168 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9169 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9170 (message_log_check_duplicate): Remove parameters `prev_bol' and
9171 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9172 (redisplay_internal): Remove parameter `preserve_echo_area',
9173 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9174
9175 * indent.c (Fvertical_motion):
9176 * window.c (window_scroll_pixel_based, Frecenter):
9177 Don't pass `need_y_p' to `move_it_by_lines'.
9178
9179 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9180
9181 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9182 steal a few bits to be more compact.
9183 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9184 Remove unneeded casts.
9185
9186 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9187
9188 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9189
9190 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9191 binding" message (bug#7967).
9192
9193 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9194
9195 Fix more problems found by GCC 4.6.0's static checks.
9196
9197 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9198 Remove unused local var.
9199
9200 * editfns.c (Fmessage_box): Remove unused local var.
9201
9202 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9203 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9204 Omit unused local vars.
9205 * window.c (shrink_windows): Omit unused local var.
9206 * menu.c (digest_single_submenu): Omit unused local var.
9207 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9208 Omit unused local var.
9209
9210 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9211 Don't assume string length fits in int.
9212 (keyremap_step, read_key_sequence): Use size_t for sizes.
9213 (read_key_sequence): Don't check last_real_key_start redundantly.
9214
9215 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9216 instead of alloca (Bug#8344).
9217
9218 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9219 (Fbacktrace_frame): Don't assume nframes fits in int.
9220
9221 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9222
9223 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9224 concerns.
9225
9226 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9227
9228 * cm.c (calccost): Turn while-do into do-while, for clarity.
9229
9230 * keyboard.c (syms_of_keyboard): Use the same style as later
9231 in this function when indexing through an array. This also
9232 works around GCC bug 48267.
9233
9234 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9235
9236 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9237
9238 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9239 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9240
9241 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9242 This avoids undefined behavior on integer overflow, and is a bit
9243 more convenient anyway since it is compared to a size_t variable.
9244
9245 Variadic C functions now count arguments with size_t, not int.
9246 This avoids an unnecessary limitation on 64-bit machines, which
9247 caused (substring ...) to crash on large vectors (Bug#8344).
9248 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9249 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9250 All variadic functions and their callers changed accordingly.
9251 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9252 * data.c (arith_driver, float_arith_driver): Likewise.
9253 * editfns.c (general_insert_function): Likewise.
9254 * eval.c (struct backtrace.nargs, interactive_p)
9255 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9256 (funcall_lambda, mark_backtrace): Likewise.
9257 * fns.c (concat): Likewise.
9258 * frame.c (x_set_frame_parameters): Likewise.
9259 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9260 0 if not found, not -1. All callers changed.
9261
9262 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9263 (stack_copy_size): Now size_t, not int.
9264 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9265
9266 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9267
9268 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9269 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9270 All callers changed.
9271
9272 * lisp.h (multibyte_char_to_unibyte):
9273 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9274 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9275 * character.h (CHAR_TO_BYTE8):
9276 * cmds.c (internal_self_insert):
9277 * editfns.c (general_insert_function):
9278 * keymap.c (push_key_description):
9279 * search.c (Freplace_match):
9280 * xdisp.c (message_dolog, set_message_1): All callers changed.
9281
9282 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9283
9284 * keyboard.c (safe_run_hook_funcall): New function.
9285 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9286 don't set the hook to nil, but remove the offending function instead.
9287 (Qcommand_hook_internal): Remove, unused.
9288 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9289 Vcommand_hook_internal.
9290
9291 * eval.c (enum run_hooks_condition): Remove.
9292 (funcall_nil, funcall_not): New functions.
9293 (run_hook_with_args): Call each function through a `funcall' argument.
9294 Remove `cond' argument, now redundant.
9295 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9296 (Frun_hook_with_args_until_failure): Adjust accordingly.
9297 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9298
9299 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9300
9301 * dispextern.h (string_buffer_position): Remove declaration.
9302
9303 * print.c (strout): Remove parameter `multibyte', unused since
9304 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9305
9306 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9307 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9308 All callers changed.
9309
9310 * w32.c (_wsa_errlist): Use braces for struct initializers.
9311
9312 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9313 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9314 All callers changed.
9315 (string_buffer_position): Likewise. Also, make static (it's never
9316 used outside xdisp.c).
9317 (cursor_row_p): Remove parameter `w', unused since
9318 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9319 (decode_mode_spec): Remove parameter `precision', introduced during
9320 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9321 All callers changed.
9322
9323 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9324
9325 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9326
9327 2011-03-27 Anders Lindgren <andlind@gmail.com>
9328
9329 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9330 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9331 (ns_update_auto_hide_menu_bar): New functions.
9332 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9333 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9334 ns_constrain_all_frames.
9335 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9336 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9337
9338 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9339
9340 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9341
9342 2011-03-27 Glenn Morris <rgm@gnu.org>
9343
9344 * syssignal.h: Replace RETSIGTYPE with void.
9345 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9346 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9347 Replace SIGTYPE with void everywhere.
9348 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9349 * s/template.h (SIGTYPE): Remove commented out definition.
9350
9351 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9352
9353 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9354 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9355
9356 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9357
9358 * w32.c (read_unc_volume): Use parameter `henum', instead of
9359 global variable `wget_enum_handle'.
9360
9361 * keymap.c (describe_vector): Remove parameters `indices' and
9362 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9363 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9364
9365 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9366
9367 * keyboard.c (timer_check): Remove parameter `do_it_now',
9368 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9369 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9370 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9371
9372 * keyboard.c (read_char):
9373 * w32menu.c (w32_menu_display_help):
9374 * xmenu.c (show_help_event, menu_help_callback):
9375 Adjust calls to `show_help_echo'.
9376
9377 * gtkutil.c (xg_maybe_add_timer):
9378 * keyboard.c (readable_events):
9379 * process.c (wait_reading_process_output):
9380 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9381
9382 * insdel.c (adjust_markers_gap_motion):
9383 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9384 (gap_left, gap_right): Don't call it.
9385
9386 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9387
9388 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9389 incurred during fontification.
9390
9391 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9392
9393 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9394 (DEFVAR_PER_BUFFER): Don't pass it.
9395
9396 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9397 (scrolling_window): Don't pass it.
9398
9399 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9400
9401 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9402
9403 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9404 and `suffix'.
9405 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9406 of variables specific to SELinux and computation of `encoded_absname'.
9407
9408 * image.c (XPutPixel): Remove unused variable `height'.
9409
9410 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9411
9412 * unexw32.c (get_section_info): Remove unused variable `section'.
9413
9414 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9415 (system_process_attributes): Remove unused variable `sess'.
9416 (sys_read): Remove unused variable `err'.
9417
9418 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9419 (w32_wnd_proc): Remove unused variable `isdead'.
9420 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9421 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9422 (x_create_tip_frame): Remove unused variable `tem'.
9423
9424 * w32inevt.c (w32_console_read_socket):
9425 Remove unused variable `no_events'.
9426
9427 * w32term.c (x_draw_composite_glyph_string_foreground):
9428 Remove unused variable `width'.
9429
9430 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9431
9432 * w32term.c (x_set_glyph_string_clipping):
9433 Don't pass uninitialized region to CombineRgn.
9434
9435 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9436
9437 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9438 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9439 (Fx_close_connection): Remove unused variable `i'.
9440
9441 * w32font.c (w32font_draw): Return number of glyphs.
9442 (w32font_open_internal): Remove unused variable `i'.
9443 (w32font_driver): Add missing initializer.
9444
9445 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9446 (fill_in_menu): Remove unused variable `items_added'.
9447
9448 * w32term.c (last_mouse_press_frame): Remove static global variable.
9449 (w32_clip_to_row): Remove unused variable `f'.
9450 (x_delete_terminal): Remove unused variable `i'.
9451
9452 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9453 (NOTHING): Remove unused static global variable.
9454 (uniscribe_check_otf): Remove unused variable `table'.
9455 (uniscribe_font_driver): Add missing initializers.
9456
9457 2011-03-23 Julien Danjou <julien@danjou.info>
9458
9459 * term.c (Fsuspend_tty, Fresume_tty):
9460 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9461 * window.c (temp_output_buffer_show):
9462 * insdel.c (signal_before_change):
9463 * frame.c (Fhandle_switch_frame):
9464 * fileio.c (Fdo_auto_save):
9465 * emacs.c (Fkill_emacs):
9466 * editfns.c (save_excursion_restore):
9467 * cmds.c (internal_self_insert):
9468 * callint.c (Fcall_interactively):
9469 * buffer.c (Fkill_all_local_variables):
9470 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9471 Use Frun_hooks.
9472 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9473 unconditionally since it does the check itself.
9474
9475 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9476
9477 Fix more problems found by GCC 4.5.2's static checks.
9478
9479 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9480 the first time through the loop, since we know p0 < p1 then.
9481 This also avoids a gcc -Wstrict-overflow warning.
9482
9483 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9484 leading to a memory leak, possible in functions like
9485 load_charset_map_from_file that can allocate an unbounded number
9486 of objects (Bug#8318).
9487
9488 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9489 that could (at least in theory) be that large.
9490
9491 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9492 This is less likely to overflow, and avoids undefined behavior if
9493 overflow does occur. All callers changed. Use strtoul to scan
9494 for the unsigned long integer.
9495 (pint2hrstr): Simplify and tune code slightly.
9496 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9497
9498 * scroll.c (do_scrolling): Work around GCC bug 48228.
9499 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9500
9501 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9502 This also avoids a warning with gcc -Wstrict-overflow.
9503 (validate_x_resource_name): Simplify count usage.
9504 This also avoids a warning with gcc -Wstrict-overflow.
9505
9506 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9507 fail (Bug#8306).
9508
9509 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9510
9511 * process.c (Fmake_network_process): Use socklen_t, not int,
9512 where POSIX says socklen_t is required in portable programs.
9513 This fixes a porting bug on hosts like 64-bit HP-UX, where
9514 socklen_t is wider than int (Bug#8277).
9515 (Fmake_network_process, server_accept_connection):
9516 (wait_reading_process_output, read_process_output):
9517 Likewise.
9518
9519 * process.c: Rename or move locals to avoid shadowing.
9520 (list_processes_1, Fmake_network_process):
9521 (read_process_output_error_handler, exec_sentinel_error_handler):
9522 Rename or move locals.
9523 (Fmake_network_process): Define label "retry_connect" only if needed.
9524 (Fnetwork_interface_info): Fix pointer signedness.
9525 (process_send_signal): Add cast to avoid pointer signedness problem.
9526 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9527 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9528
9529 Make tparam.h and terminfo.c consistent.
9530 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9531 Include tparam.h instead, since it declares them.
9532 * cm.h (PC): Remove extern decl; tparam.h now does this.
9533 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9534 * terminfo.c: Include tparam.h, to check interfaces.
9535 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9536 (tparam): Adjust signature to match interface in tparam.h;
9537 this removes some undefined behavior. Check that outstring and len
9538 are zero, which they always are with Emacs.
9539 * tparam.h (PC, BC, UP): New extern decls.
9540
9541 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9542 (xftfont_open): Rename locals to avoid shadowing.
9543
9544 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9545 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9546 (OTF_TAG_SYM): Omit macro if not needed.
9547 (ftfont_list): Remove unused local.
9548 (get_adstyle_property, ftfont_pattern_entity):
9549 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9550 Rename locals to avoid shadowing.
9551
9552 * xfont.c (xfont_list_family): Mark var as initialized.
9553
9554 * xml.c (make_dom): Now static.
9555
9556 * composite.c (composition_compute_stop_pos): Rename local to
9557 avoid shadowing.
9558 (composition_reseat_it): Remove unused locals.
9559 (find_automatic_composition, composition_adjust_point): Likewise.
9560 (composition_update_it): Mark var as initialized.
9561 (find_automatic_composition): Mark vars as initialized,
9562 with a FIXME (Bug#8290).
9563
9564 character.h: Rename locals to avoid shadowing.
9565 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9566 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9567 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9568 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9569 to avoid shadowing.
9570
9571 * textprop.c (property_change_between_p): Remove; unused.
9572
9573 * intervals.c (interval_start_pos): Now static.
9574
9575 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9576
9577 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9578 Rename locals to avoid shadowing.
9579
9580 * sound.c (wav_play, au_play, Fplay_sound_internal):
9581 Fix pointer signedness.
9582 (alsa_choose_format): Remove unused local var.
9583 (wav_play): Initialize a variable to 0, to prevent undefined
9584 behavior (Bug#8278).
9585
9586 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9587
9588 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9589
9590 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9591 clobbering (Bug#8298).
9592 * sysdep.c (sys_subshell): Likewise.
9593 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9594
9595 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9596 This should get cleaned up, so that child_setup has the
9597 same signature on all platforms.
9598
9599 * callproc.c (call_process_cleanup): Now static.
9600 (relocate_fd): Rename locals to avoid shadowing.
9601
9602 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9603
9604 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9605 not to be necessary, and produces flickering.
9606
9607 2011-03-20 Glenn Morris <rgm@gnu.org>
9608
9609 * config.in: Remove file.
9610
9611 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9612
9613 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9614 are now in src/globals.h.
9615 (syms_of_minibuf): Remove spurious & from previous change.
9616
9617 2011-03-20 Leo Liu <sdl.web@gmail.com>
9618
9619 * minibuf.c (completing-read-function): New variable.
9620 (completing-read-default): Rename from completing-read.
9621 (completing-read): Call completing-read-function.
9622
9623 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9624
9625 * xfaces.c (Fx_load_color_file):
9626 Read color file from absolute filename (bug#8250).
9627
9628 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9629
9630 * makefile.w32-in: Update dependencies.
9631
9632 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9633
9634 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9635
9636 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9637
9638 Fix more problems found by GCC 4.5.2's static checks.
9639
9640 * process.c (make_serial_process_unwind, send_process_trap):
9641 (sigchld_handler): Now static.
9642
9643 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9644 That way, the code declares only the vars that it needs.
9645 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9646 * s/cygwin.h (PTY_ITERATION): Likewise.
9647 * s/darwin.h (PTY_ITERATION): Likewise.
9648 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9649
9650 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9651 * process.c (allocate_pty): Don't declare stb unless it's needed.
9652
9653 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9654 (CONSTANTLIM): Remove; unused.
9655 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9656 Define only if needed.
9657
9658 * unexelf.c (unexec): Name an expression,
9659 to avoid gcc -Wbad-function-cast warning.
9660 Use a different way to cause a compilation error if anyone uses
9661 n rather than nn, a way that does not involve shadowing.
9662 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9663
9664 * deps.mk (unexalpha.o): Remove; unused.
9665
9666 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9667 * unexec.h: New file.
9668 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9669 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9670 Depend on unexec.h.
9671 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9672 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9673 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9674 Change as necessary to match prototype in unexec.h.
9675
9676 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9677 shadowing.
9678 (back_comment, skip_chars): Mark vars as initialized.
9679
9680 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9681 Rename locals to avoid shadowing.
9682
9683 * lread.c (read1): Rewrite so as not to use empty "else".
9684 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9685
9686 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9687
9688 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9689 warning when compiling print.c.
9690
9691 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9692 instead of using an uninitialized var.
9693 (font_sort_entities): Mark var as initialized.
9694
9695 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9696
9697 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9698 pointers to constants.
9699 (font_parse_fcname): Remove unused vars.
9700 (font_delete_unmatched): Now static.
9701 (font_get_spec): Remove; unused.
9702 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9703 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9704 Rename or move locals to avoid shadowing.
9705
9706 * fns.c (require_nesting_list, require_unwind): Now static.
9707 (Ffillarray): Rename locals to avoid shadowing.
9708
9709 * floatfns.c (domain_error2): Define only if needed.
9710 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9711
9712 * alloc.c (mark_backtrace): Move decl from here ...
9713 * lisp.h: ... to here, so that it can be checked.
9714
9715 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9716 (Fdefvar): Rewrite so as not to use empty "else".
9717 (lisp_indirect_variable): Name an expression,
9718 to avoid gcc -Wbad-function-cast warning.
9719 (Fdefvar): Rename locals to avoid shadowing.
9720
9721 * callint.c (quotify_arg, quotify_args): Now static.
9722 (Fcall_interactively): Rename locals to avoid shadowing.
9723 Use const pointer when appropriate.
9724
9725 * lisp.h (get_system_name, get_operating_system_release):
9726 Move decls here, to check interfaces.
9727 * process.c (get_operating_system_release): Move decl to lisp.h.
9728 * xrdb.c (get_system_name): Likewise.
9729 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9730 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9731 some of which prompt warnings from gcc -Wbad-function-cast.
9732 (Fformat_time_string, Fencode_time, Finsert_char):
9733 (Ftranslate_region_internal, Fformat):
9734 Rename or remove local vars to avoid shadowing.
9735 (Ftranslate_region_internal): Mark var as initialized.
9736
9737 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9738 avoid shadowing.
9739
9740 * lisp.h (eassert): Check that the argument compiles, even if
9741 ENABLE_CHECKING is not defined.
9742
9743 * data.c (Findirect_variable): Name an expression, to avoid
9744 gcc -Wbad-function-cast warning.
9745 (default_value, arithcompare, arith_driver, arith_error): Now static.
9746 (store_symval_forwarding): Rename local to avoid shadowing.
9747 (Fmake_variable_buffer_local, Fmake_local_variable):
9748 Mark variables as initialized.
9749 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9750
9751 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9752 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9753 Rename locals to avoid shadowing.
9754 (mark_stack): Move local variables into the #ifdef region where
9755 they're used.
9756 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9757 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9758 needed otherwise.
9759 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9760 (GC_STRING_CHARS): Remove; not used.
9761 (Fmemory_limit): Cast sbrk's returned value to char *.
9762
9763 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9764 avoids undefined behavior in theory.
9765
9766 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9767
9768 Use functions, not macros, for up- and down-casing (Bug#8254).
9769 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9770 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9771 to use the following functions instead of these macros.
9772 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9773 EMACS_INT, since callers assume the returned value fits in int.
9774 (upcase1): Likewise, for UPCASE_TABLE.
9775 (uppercasep, lowercasep, upcase): New static inline functions.
9776 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9777 the race-condition problem in the old DOWNCASE.
9778
9779 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9780 Rename locals to avoid shadowing.
9781 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9782 (regex_compile, re_search_2, re_match_2_internal):
9783 Remove unused local vars.
9784 (FREE_VAR): Rewrite so as not to use empty "else",
9785 which gcc can warn about.
9786 (regex_compile, re_match_2_internal): Mark locals as initialized.
9787 (RETALLOC_IF): Define only if needed.
9788 (WORDCHAR_P): Likewise. This one is never needed, but is used
9789 only in a comment talking about a compiler bug, so put inside
9790 the #if 0 of that comment.
9791 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9792 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9793 Remove; unused.
9794
9795 * search.c (boyer_moore): Rename locals to avoid shadowing.
9796 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9797 (PREV_CHAR_BOUNDARY): Likewise.
9798
9799 * search.c (simple_search): Remove unused var.
9800
9801 * dired.c (compile_pattern): Move decl from here ...
9802 * lisp.h: ... to here, so that it can be checked.
9803 (struct re_registers): New forward decl.
9804
9805 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9806
9807 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9808 All uses changed.
9809 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9810 Rename locals to avoid shadowing.
9811 (Fvertical_motion): Mark locals as initialized.
9812
9813 * casefiddle.c (casify_object, casify_region): Now static.
9814 (casify_region): Mark local as initialized.
9815
9816 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9817
9818 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9819 New macros, so that the caller can use some names other than
9820 gcpro1, gcpro2, etc.
9821 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9822 of the new macros.
9823 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9824 argument, for consistency with GCPRO2_VAR, etc: it is now the
9825 prefix of the variable, not the variable itself. All uses
9826 changed.
9827 * dired.c (directory_files_internal, file_name_completion):
9828 Rename locals to avoid shadowing.
9829
9830 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9831 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9832 dired.c's scmp function, had undefined behavior.
9833 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9834 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9835 * buffer.h: ... to here, because these macros use current_buffer,
9836 and the new implementation with inline functions needs to have
9837 current_buffer in scope now, rather than later when the macros
9838 are used.
9839 (downcase, upcase1): New static inline functions.
9840 (DOWNCASE, UPCASE1): Reimplement using these functions.
9841 This avoids undefined behavior in expressions like
9842 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9843 from race conditions in accessing the global variables
9844 case_temp1 and case_temp2.
9845 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9846 * lisp.h (case_temp1, case_temp2): Remove their decls.
9847 * character.h (ASCII_CHAR_P): Move from here ...
9848 * lisp.h: ... to here, so that the inline functions mentioned
9849 above can use them.
9850
9851 * dired.c (directory_files_internal_unwind): Now static.
9852
9853 * fileio.c (file_name_as_directory, directory_file_name):
9854 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9855 Now static.
9856 (file_name_as_directory): Use const pointers when appropriate.
9857 (Fexpand_file_name): Likewise. In particular, newdir might
9858 point at constant storage, so make it a const pointer.
9859 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9860 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9861 signedness issues.
9862 (Fset_file_times, Finsert_file_contents, auto_save_error):
9863 Rename locals to avoid shadowing.
9864
9865 * minibuf.c (choose_minibuf_frame_1): Now static.
9866 (Ftry_completion, Fall_completions): Rename or remove locals
9867 to avoid shadowing.
9868
9869 * marker.c (bytepos_to_charpos): Remove; unused.
9870
9871 * lisp.h (verify_bytepos, count_markers): New decls,
9872 so that gcc does not warn that these functions aren't declared.
9873
9874 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9875 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9876 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9877 (copy_text): Remove unused local var.
9878
9879 * filelock.c (within_one_second): Now static.
9880 (lock_file_1): Rename local to avoid shadowing.
9881
9882 * buffer.c (fix_overlays_before): Mark locals as initialized.
9883 (fix_start_end_in_overlays): Likewise. This function should be
9884 simplified by using pointers-to-pointers, but that's a different
9885 matter.
9886 (switch_to_buffer_1): Now static.
9887 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9888 (report_overlay_modification): Rename locals to avoid shadowing.
9889
9890 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9891 Fix pointer signedness issue.
9892 (sys_subshell): Mark local as volatile if checking for lint,
9893 to suppress a gcc -Wclobbered warning that does not seem to be right.
9894 (MAXPATHLEN): Define only if needed.
9895
9896 * process.c (serial_open, serial_configure): Move decls from here ...
9897 * systty.h: ... to here, so that they can be checked.
9898
9899 * fns.c (get_random, seed_random): Move extern decls from here ...
9900 * lisp.h: ... to here, so that they can be checked.
9901
9902 * sysdep.c (reset_io): Now static.
9903 (wait_for_termination_signal): Remove; unused.
9904
9905 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9906 (copy_keymap_item, append_key, push_text_char_description):
9907 Now static.
9908 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9909 (DENSE_TABLE_SIZE): Remove; unused.
9910 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9911 (describe_map_tree):
9912 Rename locals to avoid shadowing.
9913
9914 * keyboard.c: Declare functions static if they are not used elsewhere.
9915 (echo_char, echo_dash, cmd_error, top_level_2):
9916 (poll_for_input, handle_async_input): Now static.
9917 (read_char, kbd_buffer_get_event, make_lispy_position):
9918 (make_lispy_event, make_lispy_movement, apply_modifiers):
9919 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9920 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9921 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9922 (read_key_sequence, read_char): Mark locals as initialized.
9923 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9924
9925 * keyboard.h (make_ctrl_char): New decl.
9926 (mark_kboards): Move decl here ...
9927 * alloc.c (mark_kboards): ... from here.
9928
9929 * lisp.h (force_auto_save_soon): New decl.
9930
9931 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9932 (DEFINE_DUMMY_FUNCTION): New macro.
9933 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9934 Use it.
9935 (main): Add casts to avoid warnings
9936 if GCC considers string literals to be constants.
9937
9938 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9939
9940 * dbusbind.c: Pointer signedness fixes.
9941 (xd_signature, xd_append_arg, xd_initialize):
9942 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9943 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9944 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9945 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9946
9947 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9948 if GCC considers string literals to be constants.
9949 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9950
9951 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9952
9953 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9954 (print_preprocess, print_object): New macro to fix last change.
9955
9956 * print.c (print_preprocess): Don't forget font objects.
9957
9958 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9959
9960 * emacs.c (USAGE3): Doc fixes.
9961
9962 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9963
9964 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9965 structure.
9966
9967 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9968
9969 * lisp.h (VWindow_system, Qfile_name_history):
9970 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9971 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9972 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9973
9974 * w32select.c: Don't #include "keyboard.h".
9975 (run_protected): Add extern declaration for waiting_for_input.
9976
9977 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9978 * w32console.c (detect_input_pending, read_input_pending)
9979 (encode_terminal_code):
9980 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9981 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9982 (w32_system_caret_y, Qfile_name_history):
9983 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9984 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9985 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9986 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9987 * w32proc.c (Qlocal, report_file_error):
9988 * w32term.c (Vwindow_system, updating_frame):
9989 * w32uniscribe.c (initialized, uniscribe_font_driver):
9990 Remove unneeded extern declarations.
9991
9992 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9993
9994 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9995
9996 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9997
9998 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9999 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10000 These macros can no longer be used for assignment.
10001
10002 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10003 Assign struct members directly, instead of using BUF_BEGV etc.
10004 (record_buffer_markers, fetch_buffer_markers): New functions for
10005 recording and fetching special buffer markers.
10006 (set_buffer_internal_1, set_buffer_temp): Use them.
10007
10008 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10009
10010 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10011
10012 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10013 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10014
10015 * xdisp.c (hscroll_window_tree):
10016 (reconsider_clip_changes): Use PT instead of BUF_PT.
10017
10018 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10019
10020 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10021 $(EMACS_ROOT)/lib/intprops.h.
10022
10023 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10024
10025 Fix more problems found by GCC 4.5.2's static checks.
10026
10027 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10028 to unsigned char * to avoid compiler diagnostic.
10029 (xg_free_frame_widgets): Make it clear that a local variable is
10030 needed only if USE_GTK_TOOLTIP.
10031 (gdk_window_get_screen): Make it clear that this macro is needed
10032 only if USE_GTK_TOOLTIP.
10033 (int_gtk_range_get_value): New function, which avoids a diagnostic
10034 from gcc -Wbad-function-cast.
10035 (xg_set_toolkit_scroll_bar_thumb): Use it.
10036 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10037 diagnostic from gcc -Wbad-function-cast.
10038 (get_utf8_string, xg_get_file_with_chooser):
10039 Rename locals to avoid shadowing.
10040 (create_dialog): Move locals to avoid shadowing.
10041
10042 * xgselect.c (xg_select): Remove unused var.
10043
10044 * image.c (four_corners_best): Mark locals as initialized.
10045 (gif_load): Initialize transparent_p to zero (Bug#8238).
10046 Mark another local as initialized.
10047 (my_png_error, my_error_exit): Mark with NO_RETURN.
10048
10049 * image.c (clear_image_cache): Now static.
10050 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10051 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10052 (x_edge_detection): Remove unnecessary cast that
10053 gcc -Wbad-function-cast diagnoses.
10054 (gif_load): Fix pointer signedness.
10055 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10056 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10057
10058 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10059
10060 Improve quality of tests for time stamp overflow.
10061 For example, without this patch (encode-time 0 0 0 1 1
10062 1152921504606846976) returns the obviously-bogus value (-948597
10063 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10064 reports time overflow. See
10065 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10066 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10067 * editfns.c: Include limits.h and intprops.h.
10068 (TIME_T_MIN, TIME_T_MAX): New macros.
10069 (time_overflow): Move earlier, to before first use.
10070 (hi_time, lo_time): New functions, for an accurate test for
10071 out-of-range times.
10072 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10073 (Fget_internal_run_time): Don't assume time_t fits in int.
10074 (make_time): Use list2 instead of Fcons twice.
10075 (Fdecode_time): More accurate test for out-of-range times.
10076 (check_tm_member): New function.
10077 (Fencode_time): Use it, to test for out-of-range times.
10078 (lisp_time_argument): Don't rely on undefined left-shift and
10079 right-shift behavior when checking for time stamp overflow.
10080
10081 * editfns.c (time_overflow): New function, refactoring common code.
10082 (Fformat_time_string, Fdecode_time, Fencode_time):
10083 (Fcurrent_time_string): Use it.
10084
10085 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10086 * dired.c (make_time): Move to ...
10087 * editfns.c (make_time): ... here.
10088 * systime.h: Note the move.
10089
10090 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10091
10092 * fringe.c (update_window_fringes): Remove unused variables.
10093
10094 * unexmacosx.c (copy_data_segment): Also copy __got section.
10095 (Bug#8223)
10096
10097 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10098
10099 * termcap.c [MSDOS]: Include "msdos.h".
10100 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10101 Constify `char *' arguments and their references according to
10102 prototypes in tparam.h.
10103
10104 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10105
10106 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10107 Adapt all references accordingly.
10108
10109 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10110
10111 2011-03-11 Tom Tromey <tromey@redhat.com>
10112
10113 * buffer.c (syms_of_buffer): Remove obsolete comment.
10114
10115 2011-03-11 Eli Zaretskii <eliz@gnu.org>
10116
10117 * termhooks.h (encode_terminal_code): Declare prototype.
10118
10119 * msdos.c (encode_terminal_code): Don't declare prototype.
10120
10121 * term.c (encode_terminal_code): Now external again, used by
10122 w32console.c and msdos.c.
10123
10124 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10125 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
10126
10127 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
10128
10129 Fix some minor problems found by GCC 4.5.2's static checks.
10130
10131 * fringe.c (update_window_fringes): Mark locals as initialized
10132 (Bug#8227).
10133 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
10134
10135 * alloc.c (mark_fringe_data): Move decl from here ...
10136 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10137 to check its interface.
10138 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10139
10140 * fontset.c (free_realized_fontset): Now static.
10141 (Fset_fontset_font): Rename local to avoid shadowing.
10142 (fontset_font): Mark local as initialized.
10143 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10144
10145 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10146
10147 * xselect.c (x_disown_buffer_selections): Remove; not used.
10148 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10149 (x_own_selection, Fx_disown_selection_internal): Rename locals
10150 to avoid shadowing.
10151 (x_handle_dnd_message): Remove local to avoid shadowing.
10152
10153 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10154 so that the caller can use some name other than gcpro1.
10155 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10156 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10157 (Fx_backspace_delete_keys_p):
10158 Use them to avoid shadowing, and rename vars to avoid shadowing.
10159 (x_decode_color, x_set_name, x_window): Now static.
10160 (Fx_create_frame): Add braces to silence GCC warning.
10161 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10162 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10163 Remove unused locals.
10164 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10165 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10166 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10167 macros.
10168
10169 * xterm.h (x_mouse_leave): New decl.
10170
10171 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10172 Remove unused functions.
10173 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10174 (x_calc_absolute_position): Now static.
10175 (XTread_socket): Don't define label "out" unless it's used.
10176 Don't declare local "event" unless it's used.
10177 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10178 unless they are used.
10179 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10180 (x_fatal_error_signal): Remove; not used.
10181 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10182 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10183 (x_error_catcher, x_connection_closed, x_error_handler):
10184 (x_error_quitter, xembed_send_message, x_iconify_frame):
10185 (my_log_handler): Rename locals to avoid shadowing.
10186 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10187 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10188
10189 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10190 Rename or move locals to avoid shadowing.
10191 (tty_defined_color, merge_face_heights): Now static.
10192 (free_realized_faces_for_fontset): Remove; not used.
10193 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10194 does not deduce is never used uninitialized.
10195 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10196 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10197
10198 * terminal.c (store_terminal_param): Now static.
10199
10200 * xmenu.c (menu_highlight_callback): Now static.
10201 (set_frame_menubar): Remove unused local.
10202 (xmenu_show): Rename parameter to avoid shadowing.
10203 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10204 since they might point to immutable storage.
10205 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10206 since it's unused otherwise.
10207
10208 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10209 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10210 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10211 avoids a gcc -Wuninitialized diagnostic.
10212 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10213 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10214 does not deduce are never used uninitialized.
10215
10216 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10217
10218 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10219 * window.c (window_loop, size_window):
10220 (run_window_configuration_change_hook, enlarge_window): Likewise.
10221
10222 * window.c (display_buffer): Now static.
10223 (size_window): Mark variables that gcc -Wuninitialized
10224 does not deduce are never used uninitialized.
10225 * window.h (check_all_windows): New decl, to forestall
10226 gcc -Wmissing-prototypes diagnostic.
10227 * dispextern.h (bidi_dump_cached_states): Likewise.
10228
10229 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10230 shadowing.
10231 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10232 Include <limits.h>.
10233 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10234 and to avoid gcc -Wuninitialized warning.
10235 (load_charset_map): Mark variables that gcc -Wuninitialized
10236 does not deduce are never used uninitialized.
10237 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10238
10239 * coding.c (coding_set_source, coding_set_destination):
10240 Use "else { /* comment */ }" rather than "else /* comment */;"
10241 for clarity, and to avoid gcc -Wempty-body warning.
10242 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10243 a block, when the outer 'i' will do.
10244 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10245 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10246 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10247 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10248 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10249 Rename locals to avoid shadowing.
10250 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10251 * coding.c (emacs_mule_char, encode_invocation_designation):
10252 Now static, since they're not used elsewhere.
10253 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10254 (decode_coding_object, encode_coding_object, detect_coding_system):
10255 (decode_coding_emacs_mule): Mark variables that gcc
10256 -Wuninitialized does not deduce are never used uninitialized.
10257 (detect_coding_iso_2022): Initialize a local variable that might
10258 be used uninitialized. Leave a FIXME because it's not clear that
10259 this initialization is needed. (Bug#8211)
10260 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10261 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10262 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10263 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10264 Remove unused macros.
10265
10266 * category.c (hash_get_category_set): Remove unused local var.
10267 (copy_category_table): Now static, since it's not used elsewhere.
10268 * character.c (string_count_byte8): Likewise.
10269
10270 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10271 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10272
10273 * chartab.c (copy_sub_char_table): Now static, since it's not used
10274 elsewhere.
10275 (sub_char_table_ref_and_range, char_table_ref_and_range):
10276 Rename locals to avoid shadowing.
10277 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10278
10279 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10280 (BIDI_BOB): Remove unused macro.
10281
10282 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10283 deduce are never used uninitialized.
10284 * term.c (encode_terminal_code): Likewise.
10285
10286 * term.c (encode_terminal_code): Now static. Remove unused local.
10287
10288 * tparam.h: New file.
10289 * term.c, tparam.h: Include it.
10290 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10291 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10292 Move these decls to tparam.h, and make them agree with what
10293 is actually in tparam.c. The previous trick of using incompatible
10294 decls in different modules does not conform to the C standard.
10295 All callers of tparam changed to use tparam's actual API.
10296 * tparam.c (tparam1, tparam, tgoto):
10297 Use const pointers where appropriate.
10298
10299 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10300 * cm.h (struct cm): Likewise.
10301 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10302 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10303 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10304 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10305 (turn_on_face, init_tty): Likewise.
10306 * termchar.h (struct tty_display_info): Likewise.
10307
10308 * term.c (term_mouse_position): Rename local to avoid shadowing.
10309
10310 * alloc.c (mark_ttys): Move decl from here ...
10311 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10312
10313 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10314
10315 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10316
10317 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10318
10319 * search.c (compile_pattern_1): Remove argument regp, unused since
10320 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10321 (compile_pattern): Don't pass it.
10322
10323 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10324
10325 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10326 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10327 for ! HAVE_GTK3.
10328 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10329
10330 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10331
10332 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10333 gdk_window_get_screen, gdk_window_get_geometry,
10334 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10335 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10336 (xg_get_pixbuf_from_pixmap): New function.
10337 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10338 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10339 Call xg_get_pixbuf_from_pixmap instead of
10340 gdk_pixbuf_get_from_drawable.
10341 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10342 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10343 (xg_check_special_colors): Use GtkStyleContext and its functions
10344 for HAVE_GTK3.
10345 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10346 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10347 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10348 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10349 Call gtk_widget_get_preferred_size.
10350 (xg_frame_resized): gdk_window_get_geometry only takes 5
10351 parameters.
10352 (xg_win_to_widget, xg_event_is_for_menubar):
10353 Call gdk_x11_window_lookup_for_display.
10354 (xg_set_widget_bg): New function.
10355 (delete_cb): New function.
10356 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10357 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10358 (xg_set_background_color): Call xg_set_widget_bg.
10359 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10360 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10361 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10362 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10363 if ! HAVE_GTK3.
10364 (update_frame_tool_bar): Call gtk_widget_hide.
10365 (xg_initialize): Use GDK_KEY_g.
10366
10367 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10368 if ! HAVE_GTK3
10369 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10370
10371 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10372 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10373 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10374
10375 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10376
10377 * w32xfns.c (select_palette): Check success of RealizePalette against
10378 GDI_ERROR, not zero.
10379
10380 See ChangeLog.11 for earlier changes.
10381
10382 ;; Local Variables:
10383 ;; coding: utf-8
10384 ;; End:
10385
10386 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10387
10388 This file is part of GNU Emacs.
10389
10390 GNU Emacs is free software: you can redistribute it and/or modify
10391 it under the terms of the GNU General Public License as published by
10392 the Free Software Foundation, either version 3 of the License, or
10393 (at your option) any later version.
10394
10395 GNU Emacs is distributed in the hope that it will be useful,
10396 but WITHOUT ANY WARRANTY; without even the implied warranty of
10397 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10398 GNU General Public License for more details.
10399
10400 You should have received a copy of the GNU General Public License
10401 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.