* character.c (Fstring): Check for size-calculation overflow.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 * character.c (Fstring): Check for size-calculation overflow.
4
5 * ccl.c: Integer and memory overflow fixes.
6 (Fccl_execute_on_string): Check for memory overflow.
7 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8 Redo buffer-overflow calculations to avoid integer overflow.
9
10 * callproc.c (child_setup): Don't assume strlen fits in int.
11
12 * buffer.c: Memory overflow fixes.
13 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
14 Don't update size of array until after memory allocation succeeds,
15 because xmalloc/xrealloc may not return.
16
17 * bidi.c: Integer overflow fix.
18 (bidi_shelve_header_size): New constant.
19 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
20 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
21
22 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
23
24 Use ptrdiff_t for composition IDs.
25 * character.c (lisp_string_width):
26 * composite.c (composition_table_size, n_compositions)
27 (get_composition_id, composition_gstring_from_id):
28 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
29 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
30 * window.c (Frecenter):
31 Use ptrdiff_t, not int, for composition IDs.
32 * composite.c (get_composition_id): Check for integer overflow.
33 * composite.h: Adjust prototypes to match the above changes.
34
35 Use ptrdiff_t for hash table indexes.
36 * category.c (hash_get_category_set):
37 * ccl.c (ccl_driver):
38 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
39 * coding.c (coding_system_charset_list, detect_coding_system):
40 * coding.h (struct coding_system.id):
41 * composite.c (get_composition_id, gstring_lookup_cache):
42 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
43 * image.c (xpm_get_color_table_h):
44 * lisp.h (hash_lookup, hash_put):
45 * minibuf.c (Ftest_completion):
46 Use ptrdiff_t for hash table indexes, not int (which is too
47 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
48 32-bit --with-wide-int hosts).
49
50 * charset.c (Fdefine_charset_internal): Check for integer overflow.
51 Add a FIXME comment about memory leaks.
52 (syms_of_charset): Don't assume xmalloc returns.
53
54 Don't assume that stated character widths fit in int.
55 * character.c (Fchar_width, c_string_width, lisp_string_width):
56 * character.h (CHAR_WIDTH):
57 * indent.c (MULTIBYTE_BYTES_WIDTH):
58 Use sanitize_char_width to avoid undefined and/or bad behavior
59 with outlandish widths.
60 * character.h (sanitize_tab_width): Renamed from sanitize_width,
61 now that we have two such functions. All uses changed.
62 (sanitize_char_width): New inline function.
63
64 Don't assume that tab-width fits in int.
65 * character.h (sanitize_width): New inline function.
66 (SANE_TAB_WIDTH): New macro.
67 (ASCII_CHAR_WIDTH): Use it.
68 * indent.c (sane_tab_width): Remove. All uses replaced by
69 SANE_TAB_WIDTH (current_buffer).
70 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
71
72 * fileio.c: Integer overflow issues with file modes.
73 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
74
75 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
76 Remove unreachable code.
77 (read_hex, load_charset_map_from_file): Check for integer overflow.
78
79 * xterm.c: don't go over XClientMessageEvent limit
80 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
81 (x_send_scroll_bar_event): Likewise. Check that the size does not
82 exceed limits imposed by XClientMessageEvent, as well as the usual
83 ptrdiff_t and size_t limits.
84
85 * keyboard.c: Overflow, signedness and related fixes.
86 (make_lispy_movement): Use same integer type in forward decl
87 that is used in the definition.
88 (read_key_sequence, keyremap_step):
89 Change bufsize argument back to int, undoing my 2011-03-30 change.
90 We prefer signed types, and int is wide enough here.
91 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
92 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
93 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
94 length, not size_t. Use ptrdiff_t for index, not int.
95 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
96 possibility of integer overflow.
97
98 Overflow, signedness and related fixes for images.
99
100 * dispextern.h (struct it.stack[0].u.image.image_id)
101 (struct_it.image_id, struct image.id, struct image_cache.size)
102 (struct image_cache.used, struct image_cache.ref_count):
103 * gtkutil.c (update_frame_tool_bar):
104 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
105 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
106 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
107 * nsmenu.m (update_frame_tool_bar):
108 * xdisp.c (calc_pixel_width_or_height):
109 * xfns.c (image_cache_refcount):
110 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
111 on typical 64-bit hosts.
112
113 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
114 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
115 Omit unnecessary casts to int.
116 (parse_image_spec): Check that integers fall into 'int' range
117 when the callers expect that.
118 (image_ascent): Redo ascent calculation to avoid int overflow.
119 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
120 (lookup_image): Remove unnecessary tests.
121 (xbm_image_p): Locals are now of int, not EMACS_INT,
122 since parse_image_check makes sure they fit into int.
123 (png_load, gif_load, svg_load_image):
124 Prefer int to unsigned where either will do.
125 (tiff_handler): New function, combining the cores of the
126 old tiff_error_handler and tiff_warning_handler. This
127 function is rewritten to use vsnprintf and thereby avoid
128 stack buffer overflows. It uses only the features of vsnprintf
129 that are common to both POSIX and native Microsoft.
130 (tiff_error_handler, tiff_warning_handler): Use it.
131 (tiff_load, gif_load, imagemagick_load_image):
132 Don't assume :index value fits in 'int'.
133 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
134 (imagemagick_load_image): Check that crop parameters fit into
135 the integer types that MagickCropImage accepts. Don't assume
136 Vimagemagick_render_type has a nonnegative value. Don't assume
137 size_t fits in 'long'.
138 (gs_load): Use printmax_t to print the widest integers possible.
139 Check for integer overflow when computing image height and width.
140
141 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
142
143 Integer signedness and overflow and related fixes. (Bug#9079)
144
145 * bidi.c: Integer size and overflow fixes.
146 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
147 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
148 (bidi_cache_find_level_change, bidi_cache_ensure_space)
149 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
150 (bidi_find_other_level_edge):
151 Use ptrdiff_t instead of EMACS_INT where either will do.
152 This works better on 32-bit hosts configured --with-wide-int.
153 (bidi_cache_ensure_space): Check for size-calculation overflow.
154 Use % rather than repeated addition, for better worst-case speed.
155 Don't set bidi_cache_size until after xrealloc returns, because it
156 might not return.
157 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
158 (bidi_cache_ensure_space): Also check that the bidi cache size
159 does not exceed that of the largest Lisp string or buffer. See Eli
160 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
161
162 * alloc.c (__malloc_size_t): Remove.
163 All uses replaced by size_t. See Andreas Schwab's note
164 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
165
166 * image.c: Improve checking for integer overflow.
167 (check_image_size): Assume that f is nonnull, since
168 it is always nonnull in practice. This is one less thing to
169 worry about when checking for integer overflow later.
170 (x_check_image_size): New function, which checks for integer
171 overflow issues inside X.
172 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
173 This removes the need for a memory_full check.
174 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
175 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
176 (xbm_read_bitmap_data): Change locals back to 'int', since
177 their values must fit in 'int'.
178 (xpm_load_image, png_load, tiff_load):
179 Invoke x_create_x_image_and_pixmap earlier,
180 to avoid much needless work if the image is too large.
181 (tiff_load): Treat overly large images as if
182 x_create_x_image_and_pixmap failed, not as malloc failures.
183 (gs_load): Use x_check_image_size.
184
185 * gtkutil.c: Omit integer casts.
186 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
187 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
188
189 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
190
191 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
192 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
193 would wrongly return t on a 64-bit host.
194
195 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
196 The plain *_OVERFLOW macros run afoul of GCC bug 49705
197 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
198 and therefore cause GCC to emit a bogus diagnostic in some cases.
199
200 * image.c: Integer signedness and overflow and related fixes.
201 This is not an exhaustive set of fixes, but it's time to
202 record what I've got.
203 (lookup_pixel_color, check_image_size): Remove redundant decls.
204 (check_image_size): Don't assume that arbitrary EMACS_INT values
205 fit in 'int', or that arbitrary 'double' values fit in 'int'.
206 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
207 (tiff_load, imagemagick_load_image):
208 Check for overflow in size calculations.
209 (x_create_x_image_and_pixmap): Remove unnecessary test for
210 xmalloc returning NULL; that can't happen.
211 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
212 (xpm_color_bucket): Use better integer hashing function.
213 (xpm_cache_color): Don't possibly over-allocate memory.
214 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
215 (gif_memory_source):
216 Use ptrdiff_t, not int or size_t, to record sizes.
217 (png_load): Don't assume values greater than 2**31 fit in 'int'.
218 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
219 either works, as we prefer signed integers.
220 (tiff_read_from_memory, tiff_write_from_memory):
221 Return tsize_t, not size_t, since that's what the TIFF API wants.
222 (tiff_read_from_memory): Don't fail simply because the read would
223 go past EOF; instead, return a short read.
224 (tiff_load): Omit no-longer-needed casts.
225 (Fimagemagick_types): Don't assume size fits into 'int'.
226
227 Improve hashing quality when configured --with-wide-int.
228 * fns.c (hash_string): New function, taken from sxhash_string.
229 Do not discard information about ASCII character case; this
230 discarding is no longer needed.
231 (sxhash-string): Use it. Change sig to match it. Caller changed.
232 * lisp.h: Declare it.
233 * lread.c (hash_string): Remove, since we now use fns.c's version.
234 The fns.c version returns a wider integer if --with-wide-int is
235 specified, so this should help the quality of the hashing a bit.
236
237 * emacs.c: Integer overflow minor fix.
238 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
239 Define only if GNU_LINUX.
240 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
241
242 * dispnew.c: Integer signedness and overflow fixes.
243 Remove unnecessary forward decls, that were a maintenance hassle.
244 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
245 All uses changed.
246 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
247 (scrolling_window): Use ptrdiff_t, not int, for byte count.
248 (prepare_desired_row, line_draw_cost):
249 Use int, not unsigned, where either works.
250 (save_current_matrix, restore_current_matrix):
251 Use ptrdiff_t, not size_t, where either works.
252 (init_display): Check for overflow more accurately, and without
253 relying on undefined behavior.
254
255 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
256 Remove, replacing with the new symbols in lisp.h. All uses changed.
257 * fileio.c (make_temp_name):
258 * filelock.c (lock_file_1, lock_file):
259 * xdisp.c (message_dolog):
260 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
261 Use pMd etc. instead.
262 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
263 replacing the pWIDE etc. symbols removed from editfns.c.
264
265 * keyboard.h (num_input_events): Now uintmax_t.
266 This is (very slightly) less likely to mess up due to wraparound.
267 All uses changed.
268
269 * buffer.c: Integer signedness fixes.
270 (alloc_buffer_text, enlarge_buffer_text):
271 Use ptrdiff_t rather than size_t when either will do, as we prefer
272 signed integers.
273
274 * alloc.c: Integer signedness and overflow fixes.
275 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
276 (__malloc_size_t): Default to size_t, not to int.
277 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
278 (Fgarbage_collect, mark_object_loop_halt, mark_object):
279 Prefer ptrdiff_t to size_t when either would do, as we prefer
280 signed integers.
281 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
282 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
283 Now const. Initialize with values that are in range even if char
284 is signed.
285 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
286 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
287 These functions do the right thing with sizes > 2**32.
288 (check_depth): Now ptrdiff_t, not int.
289 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
290 Adjust to new way of storing sizes. Check for size overflow bugs
291 in rest of code.
292 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
293 slightly wrong anyway, as it missed one instance of
294 XMALLOC_OVERRUN_CHECK_OVERHEAD.
295 (refill_memory_reserve): Omit needless cast to size_t.
296 (mark_object_loop_halt): Mark as externally visible.
297
298 * xselect.c: Integer signedness and overflow fixes.
299 (Fx_register_dnd_atom, x_handle_dnd_message):
300 Use ptrdiff_t, not size_t, since we prefer signed.
301 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
302 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
303 x_dnd_atoms_size and x_dnd_atoms_length.
304
305 * doprnt.c: Prefer signed to unsigned when either works.
306 * eval.c (verror):
307 * doprnt.c (doprnt):
308 * lisp.h (doprnt):
309 * xdisp.c (vmessage):
310 Use ptrdiff_t, not size_t, when using or implementing doprnt,
311 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
312 prefer signed arithmetic to avoid comparison confusion.
313 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
314 but is a bit tricky.
315
316 Assume freestanding C89 headers, string.h, stdlib.h.
317 * data.c, doprnt.c, floatfns.c, print.c:
318 Include float.h unconditionally.
319 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
320 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
321 * regex.c: Likewise for stddef.h, string.h.
322 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
323 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
324 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
325 (STDC_HEADERS): Remove obsolete defines.
326 * sysdep.c: Include limits.h unconditionally.
327
328 Assume support for memcmp, memcpy, memmove, memset.
329 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
330 * regex.c (memcmp, memcpy):
331 Remove; we assume C89 now.
332
333 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
334 (__malloc_safe_bcopy): Remove; no longer needed.
335
336 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
337 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
338 well either way, and we prefer signed to unsigned.
339
340 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
341
342 Port to OpenBSD.
343 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
344 and the surrounding thread.
345 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
346 rather than fgets, and retry after EINTR. Otherwise, 'emacs
347 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
348 timer goes off.
349 * s/openbsd.h (BROKEN_SIGIO): Define.
350 * unexelf.c (unexec) [__OpenBSD__]:
351 Don't update the .mdebug section of the Alpha COFF symbol table.
352
353 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
354
355 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
356 (bug#8460).
357
358 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
359
360 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
361 This fixes some race conditions on the permissions of any newly
362 created file.
363
364 * alloc.c (valid_pointer_p): Use pipe, not open.
365 This fixes some permissions issues when debugging.
366
367 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
368 If fchown fails to set both uid and gid, try to set just gid,
369 as that is sometimes allowed. Adjust the file's mode to eliminate
370 setuid or setgid bits that are inappropriate if fchown fails.
371
372 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
373
374 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
375 to compare Lisp_Objects.
376 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
377 global_gnutls_log_level, don't mistake it for a Lisp_Object.
378 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
379
380 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
381
382 * lread.c (read_integer): Unread even EOF character.
383 (read1): Likewise. Properly record start position of symbol.
384
385 * lread.c (read1): Read `#:' as empty uninterned symbol if no
386 symbol character follows.
387
388 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
389
390 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
391 This works around a problem with the previous change to Fcopy_file.
392 Recent glibc declares fchown with __attribute__((warn_unused_result)),
393 and without this change, GCC might complain about discarding
394 fchown's return value.
395
396 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
397
398 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
399
400 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
401
402 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
403
404 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
405
406 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
407 it's used from the C level.
408
409 * process.c: Use the same condition for POLL_FOR_INPUT in both
410 keyboard.c and process.c (bug#1858).
411
412 2011-07-09 Lawrence Mitchell <wence@gmx.li>
413
414 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
415 (Fgnutls_boot): Use it.
416
417 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
418
419 * doc.c (Fsubstitute_command_keys): Revert last change.
420
421 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
422
423 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
424 quotes the next character, and doesn't affect other longer
425 sequences (bug#8935).
426
427 * lread.c (syms_of_lread): Clarify that is isn't only
428 `eval-buffer' and `eval-defun' that's affected by
429 `lexical-binding' (bug#8460).
430
431 2011-07-15 Eli Zaretskii <eliz@gnu.org>
432
433 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
434 bidi redisplay when a line includes both an image and is
435 truncated.
436
437 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
438
439 Fix minor problems found by static checking.
440 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
441 (elsz): Now a signed constant, not a size_t var. We prefer signed
442 types to unsigned, to avoid integer comparison confusion. Without
443 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
444 "cannot optimize loop, the loop counter may overflow", a symptom
445 of the confusion.
446 * indent.c (Fvertical_motion): Mark locals as initialized.
447 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
448
449 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
450
451 * search.c (Fre_search_backward): Mention `case-fold-search' in
452 all the re_search_* functions (bug#8138).
453
454 * keyboard.c (Fopen_dribble_file): Document when the file is
455 closed (bug#8056).
456
457 2011-07-14 Eli Zaretskii <eliz@gnu.org>
458
459 * bidi.c (bidi_dump_cached_states): Fix format of displaying
460 bidi_cache_idx.
461
462 Support bidi reordering of display and overlay strings.
463 * xdisp.c (compute_display_string_pos)
464 (compute_display_string_end): Accept additional argument STRING.
465 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
466 (reseat_to_string): Initialize bidi_it->string.s and
467 bidi_it->string.schars.
468 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
469 NULL (avoids a crash in bidi_paragraph_init). Initialize
470 itb.string.lstring.
471 (init_iterator): Call bidi_init_it only of a valid
472 buffer position was specified. Initialize paragraph_embedding to
473 L2R.
474 (reseat_to_string): Initialize the bidi iterator.
475 (display_string): If we need to ignore text properties of
476 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
477 original value of -1 will not work with bidi.)
478 (compute_display_string_pos): First arg is now struct
479 `text_pos *'; all callers changed. Support display properties on
480 Lisp strings.
481 (compute_display_string_end): Support display properties on Lisp
482 strings.
483 (init_iterator, reseat_1, reseat_to_string): Initialize the
484 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
485 when iterating on a string not from display properties).
486 (compute_display_string_pos, compute_display_string_end): Fix
487 calculation of the object to scan. Fixes an error when using
488 arrow keys.
489 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
490 base_level_stop; instead, set base_level_stop to BEGV. Fixes
491 crashes in vertical-motion.
492 (next_element_from_buffer): Improve commentary for when
493 the iterator is before prev_stop.
494 (init_iterator): Initialize bidi_p from the default value of
495 bidi-display-reordering, not from buffer-local value. Use the
496 buffer-local value only if initializing for buffer iteration.
497 (handle_invisible_prop): Support invisible properties on strings
498 that are being bidi-reordered.
499 (set_iterator_to_next): Support bidi reordering of C strings and
500 Lisp strings.
501 (next_element_from_string): Support bidi reordering of Lisp
502 strings.
503 (handle_stop_backwards): Support Lisp strings as well.
504 (display_string): Support display of R2L glyph rows. Use
505 IT_STRING_CHARPOS when displaying from a Lisp string.
506 (init_iterator): Don't initialize it->bidi_p for strings
507 here.
508 (reseat_to_string): Initialize it->bidi_p for strings here.
509 (next_element_from_string, next_element_from_c_string)
510 (next_element_from_buffer): Add xassert's for correspondence
511 between IT's object being iterated and it->bidi_it.string
512 structure.
513 (face_before_or_after_it_pos): Support bidi iteration.
514 (next_element_from_c_string): Handle the case of the first string
515 character that is not the first one in the visual order.
516 (get_visually_first_element): New function, refactored from common
517 parts of next_element_from_buffer, next_element_from_string, and
518 next_element_from_c_string.
519 (tool_bar_lines_needed, redisplay_tool_bar)
520 (display_menu_bar): Force left-to-right direction. Add a FIXME
521 comment for making that be controlled by a user option.
522 (push_it, pop_it): Save and restore the state of the
523 bidi iterator. Save and restore the bidi_p flag.
524 (pop_it): Iterate out of display property for string iteration as
525 well.
526 (iterate_out_of_display_property): Support iteration over strings.
527 (handle_single_display_spec): Set up it->bidi_it for iteration
528 over a display string, and call bidi_init_it.
529 (handle_single_display_spec, next_overlay_string)
530 (get_overlay_strings_1, push_display_prop): Set up the bidi
531 iterator for displaying display or overlay strings.
532 (forward_to_next_line_start): Don't use the shortcut if
533 bidi-iterating.
534 (back_to_previous_visible_line_start): If handle_display_prop
535 pushed the iterator stack, restore the internal state of the bidi
536 iterator by calling bidi_pop_it same number of times.
537 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
538 and we are bidi-iterating, don't decrement the iterator position;
539 instead, set the first_elt flag in the bidi iterator, to produce
540 the same effect.
541 (reseat_1): Remove redundant setting of string_from_display_prop_p.
542 (push_display_prop): xassert that we are iterating a buffer.
543 (push_it, pop_it): Save and restore paragraph_embedding member.
544 (handle_single_display_spec, next_overlay_string)
545 (get_overlay_strings_1, reseat_1, reseat_to_string)
546 (push_display_prop): Set up the `unibyte' member of bidi_it.string
547 correctly. Don't assume unibyte strings are not bidi-reordered.
548 (compute_display_string_pos)
549 (compute_display_string_end): Fix handling the case of C string.
550 (push_it, pop_it): Save and restore from_disp_prop_p.
551 (handle_single_display_spec, push_display_prop): Set the
552 from_disp_prop_p flag.
553 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
554 (pop_it): Call iterate_out_of_display_property only if we are
555 popping after iteration over a string that came from a display
556 property. Fix a typo in popping stretch info. Add an assertion
557 for verifying that the iterator position is in sync with the bidi
558 iterator.
559 (handle_single_display_spec, get_overlay_strings_1)
560 (push_display_prop): Fix initialization of paragraph direction for
561 string when that of the parent object is not yet determined.
562 (reseat_1): Call bidi_init_it to resync the bidi
563 iterator with IT's position. (Bug#7616)
564 (find_row_edges): If ROW->start.pos gives position
565 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
566 (handle_stop, back_to_previous_visible_line_start, reseat_1):
567 Reset the from_disp_prop_p flag.
568 (SAVE_IT, RESTORE_IT): New macros.
569 (pos_visible_p, face_before_or_after_it_pos)
570 (back_to_previous_visible_line_start)
571 (move_it_in_display_line_to, move_it_in_display_line)
572 (move_it_to, move_it_vertically_backward, move_it_by_lines)
573 (try_scrolling, redisplay_window, display_line): Use them when
574 saving a temporary copy of the iterator and restoring it back.
575 (back_to_previous_visible_line_start, reseat_1)
576 (init_iterator): Empty the bidi cache "stack".
577 (move_it_in_display_line_to): If iterator ended up at
578 EOL, but we never saw any buffer positions smaller than
579 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
580 motion in bidi-reordered lines.
581 (move_it_in_display_line_to): Record prev_method and prev_pos
582 immediately before the call to set_iterator_to_next. Fixes cursor
583 motion in bidi-reordered lines with stretch glyphs and strings
584 displayed in margins. (Bug#8133) (Bug#8867)
585 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
586 TO_CHARPOS.
587 (pos_visible_p): Support positions in bidi-reordered lines. Save
588 and restore bidi cache.
589
590 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
591 (bidi_paragraph_info): Delete unused struct.
592 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
593 (bidi_cache_start): New variable.
594 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
595 to zero.
596 (bidi_cache_fetch_state, bidi_cache_search)
597 (bidi_cache_find_level_change, bidi_cache_iterator_state)
598 (bidi_cache_find, bidi_peek_at_next_level)
599 (bidi_level_of_next_char, bidi_find_other_level_edge)
600 (bidi_move_to_visually_next): Compare cache index with
601 bidi_cache_start rather than with zero.
602 (bidi_fetch_char): Accept new argument STRING; all callers
603 changed. Support iteration over a string. Support strings with
604 display properties. Support unibyte strings. Fix the type of
605 `len' according to what STRING_CHAR_AND_LENGTH expects.
606 (bidi_paragraph_init, bidi_resolve_explicit_1)
607 (bidi_resolve_explicit, bidi_resolve_weak)
608 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
609 iteration over a string.
610 (bidi_set_sor_type, bidi_resolve_explicit_1)
611 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
612 can now be zero (for strings); special values 0 and -1 were
613 changed to -1 and -2, respectively.
614 (bidi_char_at_pos): New function.
615 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
616 Call it instead of FETCH_MULTIBYTE_CHAR.
617 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
618 initialized to valid values.
619 (bidi_init_it): Don't initialize charpos and bytepos with invalid
620 values.
621 (bidi_level_of_next_char): Allow the sentinel "position" to pass
622 the test for valid cached positions. Fix the logic for looking up
623 the sentinel state in the cache. GCPRO the Lisp string we are
624 iterating.
625 (bidi_push_it, bidi_pop_it): New functions.
626 (bidi_initialize): Initialize the bidi cache start stack pointer.
627 (bidi_cache_ensure_space): New function, refactored from part of
628 bidi_cache_iterator_state. Don't assume the required size is just
629 one BIDI_CACHE_CHUNK away.
630 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
631 (bidi_count_bytes, bidi_char_at_pos): New functions.
632 (bidi_cache_search): Don't assume bidi_cache_last_idx is
633 always valid if bidi_cache_idx is valid.
634 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
635 is valid if it's going to be used.
636 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
637 (bidi_cache_fetch_state, bidi_cache_search)
638 (bidi_cache_find_level_change, bidi_cache_ensure_space)
639 (bidi_cache_iterator_state, bidi_cache_find)
640 (bidi_find_other_level_edge, bidi_cache_start_stack): All
641 variables related to cache indices are now EMACS_INT.
642
643 * dispextern.h (struct bidi_string_data): New structure.
644 (struct bidi_it): New member `string'. Make flag members be 1-bit
645 fields, and put them last in the struct.
646 (compute_display_string_pos, compute_display_string_end): Update
647 prototypes.
648 (bidi_push_it, bidi_pop_it): Add prototypes.
649 (struct iterator_stack_entry): New members bidi_p,
650 paragraph_embedding, and from_disp_prop_p.
651 (struct it): Member bidi_p is now a bit field 1 bit wide.
652 (bidi_shelve_cache, bidi_unshelve_cache): Declare
653 prototypes.
654
655 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
656 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
657 and vector-like objects.
658
659 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
660 cache around display iteration.
661
662 * window.c (Fwindow_end, window_scroll_pixel_based)
663 (displayed_window_lines, Frecenter): Save and restore the bidi
664 cache around display iteration.
665
666 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
667
668 * editfns.c (Fdelete_region): Clarify the use of the named
669 parameters (bug#6788).
670
671 2011-07-14 Martin Rudalics <rudalics@gmx.at>
672
673 * indent.c (Fvertical_motion): Set and restore w->pointm when
674 saving and restoring the window's buffer (Bug#9006).
675
676 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
677
678 * editfns.c (Fstring_to_char): Clarify just what is returned
679 (bug#6576). Text by Eli Zaretskii.
680
681 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
682
683 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
684
685 2011-07-13 Eli Zaretskii <eliz@gnu.org>
686
687 * buffer.c (mmap_find): Fix a typo.
688
689 2011-07-13 Johan Bockgård <bojohan@gnu.org>
690
691 Fix execution of x selection hooks.
692 * xselect.c (Qx_lost_selection_functions)
693 (Qx_sent_selection_functions): New vars.
694 (syms_of_xselect): DEFSYM them.
695 (x_handle_selection_request): Pass Qx_sent_selection_functions
696 rather than Vx_sent_selection_functions to Frun_hook_with_args.
697 (x_handle_selection_clear,x_clear_frame_selections):
698 Pass Qx_lost_selection_functions rather than
699 Vx_lost_selection_functions to Frun_hook_with_args.
700
701 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
702
703 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
704 The old code sometimes used this field without initializing it.
705
706 * alloc.c (gc_sweep): Don't read past end of array.
707 In theory, the old code could also have corrupted Emacs internals,
708 though it'd be very unlikely.
709
710 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
711
712 * character.c (Fcharacterp): Don't advertise optional ignored
713 argument. (Bug#4026)
714
715 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
716
717 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
718 key" (bug#4257).
719
720 * window.c (Fset_window_start): Doc fix (bug#4199).
721 (Fset_window_hscroll): Ditto.
722
723 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
724
725 Fix minor new problems caught by GCC 4.6.1.
726 * term.c (init_tty): Remove unused local.
727 * xsettings.c (store_monospaced_changed): Define this function only
728 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
729 not used otherwise.
730
731 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
732
733 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
734
735 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
736
737 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
738 are the mini-buffer and the echo area (bug#3320).
739
740 * term.c (init_tty): Remove support for supdup, c10 and perq
741 terminals, which are no longer supported (bug#1482).
742
743 2011-07-10 Johan Bockgård <bojohan@gnu.org>
744
745 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
746
747 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
748
749 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
750 for non-popups (Bug#3642).
751
752 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
753
754 * alloc.c (reset_malloc_hooks): Protoize.
755 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
756 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
757 * cm.c (losecursor): Likewise.
758 * data.c (fmod): Likewise.
759 * dispnew.c (swap_glyphs_in_rows): Likewise.
760 * emacs.c (memory_warning_signal): Likewise.
761 * floatfns.c (float_error): Likewise.
762 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
763 (otf_open, font_otf_capability, generate_otf_features)
764 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
765 Likewise.
766 * image.c (pbm_read_file): Likewise.
767 * indent.c (string_display_width): Likewise.
768 * intervals.c (check_for_interval, search_for_interval)
769 (inc_interval_count, count_intervals, root_interval)
770 (adjust_intervals_for_insertion, make_new_interval): Likewise.
771 * lread.c (defalias): Likewise.
772 * ralloc.c (r_alloc_check): Likewise.
773 * regex.c (set_image_of_range_1, set_image_of_range)
774 (regex_grow_registers): Likewise.
775 * sysdep.c (strerror): Likewise.
776 * termcap.c (valid_filename_p, tprint, main): Likewise.
777 * tparam.c (main): Likewise.
778 * unexhp9k800.c (run_time_remap, save_data_space)
779 (update_file_ptrs, read_header, write_header, calculate_checksum)
780 (copy_file, copy_rest, display_header): Likewise.
781 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
782 Likewise.
783 * xdisp.c (check_it): Likewise.
784 * xfaces.c (register_color, unregister_color, unregister_colors):
785 Likewise.
786 * xfns.c (print_fontset_result): Likewise.
787 * xrdb.c (member, fatal, main): Likewise.
788
789 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
790
791 Fix minor problems found by static checking (Bug#9031).
792 * chartab.c (char_table_set_range, map_sub_char_table):
793 Remove unused locals.
794 (uniprop_table): Now static.
795 * composite.c (_work_char): Remove unused static var.
796
797 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
798
799 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
800
801 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
802
803 * gtkutil.c (qttip_cb): Remove code without function.
804
805 2011-07-09 Eli Zaretskii <eliz@gnu.org>
806
807 * w32.c (pthread_sigmask): New stub.
808
809 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
810
811 Use pthread_sigmask, not sigprocmask (Bug#9010).
812 sigprocmask is portable only for single-threaded applications, and
813 Emacs can be multi-threaded when it uses GTK.
814 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
815 (LIBES): Use it.
816 * callproc.c (Fcall_process):
817 * process.c (create_process):
818 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
819 Use pthread_sigmask, not sigprocmask.
820
821 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
822
823 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
824 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
825 wrong (Bug#8591).
826
827 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
828
829 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
830 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
831 (xg_hide_tooltip): Fix comment.
832
833 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
834 in registerServicesMenuSendTypes.
835 (validRequestorForSendType): Don't check ns_return_types.
836
837 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
838 ns_return_type.
839
840 2011-07-08 Jason Rumney <jasonr@gnu.org>
841
842 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
843 frame struct members of non-existent frames (Bug#6284).
844
845 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
846
847 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
848 variable firstTime not needed on OSX >= 10.6.
849 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
850 >= 10.5. Use setKnobProportion, setDoubleValue.
851
852 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
853 (MAC_OS_X_VERSION_10_5): Define if not defined.
854 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
855 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
856 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
857
858 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
859 cString and lossyCString on OSX >= 10.4
860
861 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
862 sizeToFit on OSX >= 10.2.
863
864 * nsimage.m (allocInitFromFile): Don't use deprecated method
865 bestRepresentationForDevice on OSX >= 10.6.
866
867 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
868 to avoid warning.
869
870 * emacs.c: Declare unexec_init_emacs_zone.
871
872 * nsgui.h: Fix compiler warning about gnulib redefining verify.
873
874 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
875
876 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
877 on svcsMenu (Bug#8842).
878
879 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
880 ns_return_types.
881 (Fns_list_services): Just return Qnil on 10.6, code not working there.
882
883 * nsterm.m (QUTF8_STRING): Declare.
884 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
885 (validRequestorForSendType): Return type is (id).
886 Change indexOfObjectIdenticalTo to indexOfObject.
887 Check if we have local selection before returning self (Bug#8842).
888 (writeSelectionToPasteboard): Put local selection into paste board
889 if we have a local selection (Bug#8842).
890 (syms_of_nsterm): DEFSYM QUTF8_STRING.
891
892 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
893 (ns_get_local_selection): Declare.
894
895 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
896
897 * keymap.c (describe_map_tree): Don't insert a double newline at
898 the end of the buffer (bug#1169) and return whether we inserted
899 something.
900
901 * callint.c (Fcall_interactively): Change "reading args" to
902 "providing args" to try to clarify what it does (bug#1010).
903
904 2011-07-07 Kenichi Handa <handa@m17n.org>
905
906 * composite.c (composition_compute_stop_pos): Ignore a static
907 composition starting before CHARPOS (Bug#8915).
908
909 * xdisp.c (handle_composition_prop): Likewise.
910
911 2011-07-07 Eli Zaretskii <eliz@gnu.org>
912
913 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
914 (Bug#9015)
915
916 2011-07-07 Kenichi Handa <handa@m17n.org>
917
918 * character.h (unicode_category_t): New enum type.
919
920 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
921 (Qchar_code_property_table): New variable.
922 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
923 (UNIPROP_COMPRESSED_FORM_P): New macros.
924 (char_table_ascii): Uncompress the compressed values.
925 (sub_char_table_ref): New arg is_uniprop. Callers changed.
926 Uncompress the compressed values.
927 (sub_char_table_ref_and_range): Likewise.
928 (char_table_ref_and_range): Uncompress the compressed values.
929 (sub_char_table_set): New arg is_uniprop. Callers changed.
930 Uncompress the compressed values.
931 (sub_char_table_set_range): Args changed. Callers changed.
932 (char_table_set_range): Adjuted for the above change.
933 (map_sub_char_table): Delete args default_val and parent. Add arg
934 top. Give decoded values to a Lisp function.
935 (map_char_table): Adjusted for the above change. Give decoded
936 values to a Lisp function. Gcpro more variables.
937 (uniprop_table_uncompress)
938 (uniprop_decode_value_run_length): New functions.
939 (uniprop_decoder, uniprop_decoder_count): New variables.
940 (uniprop_get_decoder, uniprop_encode_value_character)
941 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
942 New functions.
943 (uniprop_encoder, uniprop_encoder_count): New variables.
944 (uniprop_get_encoder, uniprop_table)
945 (Funicode_property_table_internal, Fget_unicode_property_internal)
946 (Fput_unicode_property_internal): New functions.
947 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
948 Sunicode_property_table_internal, Sget_unicode_property_internal,
949 and Sput_unicode_property_internal. Defvar_lisp
950 char-code-property-alist.
951
952 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
953 Vunicode_category_table.
954
955 * font.c (font_range): Adjusted for the change of
956 Vunicode_category_table.
957
958 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
959
960 * m/iris4d.h: Remove file, move contents ...
961 * s/irix6-5.h: ... here.
962
963 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
964
965 Remove unportable assumption about struct layout (Bug#8884).
966 * alloc.c (mark_buffer):
967 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
968 (clone_per_buffer_values): Don't assume that
969 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
970 This isn't true in general, and it's particularly not true
971 if Emacs is configured with --with-wide-int.
972 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
973 New macros, used in the buffer.c change.
974
975 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
976
977 * xsettings.c: Use both GConf and GSettings if both are available.
978 (store_config_changed_event): Add comment.
979 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
980 (store_tool_bar_style_changed): New functions.
981 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
982 (struct xsettings): Move font inside HAVE_XFT.
983 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
984 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
985 Move inside HAVE_XFT.
986 (something_changed_gsettingsCB): Renamed from something_changedCB.
987 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
988 also.
989 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
990 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
991 (something_changed_gconfCB): Renamed from something_changedCB.
992 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
993 (parse_settings): Move check for font inside HAVE_XFT.
994 (read_settings, apply_xft_settings): Add comment.
995 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
996 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
997 call store_font_name_changed.
998 (xft_settings_event): Add comment.
999 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1000 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1001 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1002 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1003 (xsettings_initialize): Call init_gsettings last.
1004 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1005 comment.
1006
1007 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 Random fixes. E.g., (random) never returned negative values.
1010 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1011 subseconds part to the entropy, as that's a bit more random.
1012 Prefer signed to unsigned, since the signedness doesn't matter and
1013 in general we prefer signed. When given a limit, use a
1014 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1015 latter isn't right if USE_2_TAGS_FOR_INTS.
1016 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1017 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1018
1019 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1020
1021 * textprop.c (text_property_stickiness):
1022 Obey Vtext_property_default_nonsticky.
1023 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1024 * w32fns.c (syms_of_w32fns):
1025 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1026
1027 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1028
1029 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1030 This is more efficient than Ffile_directory_p and avoids a minor race.
1031
1032 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1033
1034 * buffer.c (Foverlay_put): Say what the return value is
1035 (bug#7835).
1036
1037 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1038 is a directory before asking whether to use the file name
1039 (bug#7564).
1040 (barf_or_query_if_file_exists): Make the "File is a directory"
1041 error be more correct.
1042
1043 * fns.c (Frequire): Remove the mention of the .gz files, since
1044 that's installation-specific, but keep the mention of
1045 `get-load-suffixes'.
1046
1047 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1050 Report string overflow if the output is too long.
1051
1052 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1053
1054 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1055 (syms_of_gnutls): Remove duplicate DEFSYM for
1056 Qgnutls_bootprop_verify_hostname_error, an error for
1057 Qgnutls_bootprop_verify_error (which is no longer used).
1058
1059 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1060 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1061 Also (re)move comments that are misplaced or no longer relevant.
1062
1063 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1064
1065 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1066
1067 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1068
1069 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1070 and background color parameters if they have been changed.
1071
1072 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1073
1074 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1075
1076 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 * xsettings.c (SYSTEM_FONT): Define only when used.
1079 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1080
1081 * keymap.c (access_keymap_1): Now static.
1082
1083 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1084
1085 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1086 leave any prefix arg for the up event (Bug#1586).
1087
1088 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1089
1090 * lread.c (syms_of_lread): Mention single symbols defined by
1091 `defvar' or `defconst' (bug#7154).
1092
1093 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1094 (Frequire): Mention get-load-suffixes.
1095
1096 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1097
1098 * window.h (window): Remove clone_number slot.
1099 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1100 Remove.
1101 (make_parent_window, make_window, saved_window)
1102 (Fset_window_configuration, save_window_save): Don't deal with
1103 clone numbers.
1104 * buffer.c (Qclone_number): Remove declaration.
1105 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1106
1107 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1108
1109 Add multiple inheritance to keymaps.
1110 * keymap.c (Fmake_composed_keymap): New function.
1111 (Fset_keymap_parent): Simplify.
1112 (fix_submap_inheritance): Remove.
1113 (access_keymap_1): New function extracted from access_keymap to handle
1114 embedded parents and handle lists of maps.
1115 (access_keymap): Use it.
1116 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1117 (Fcopy_keymap): Handle embedded parents.
1118 (Fcommand_remapping, define_as_prefix): Simplify.
1119 (Fkey_binding): Simplify.
1120 (syms_of_keymap): Move minibuffer-local-completion-map,
1121 minibuffer-local-filename-completion-map,
1122 minibuffer-local-must-match-map, and
1123 minibuffer-local-filename-must-match-map to Elisp.
1124 (syms_of_keymap): Defsubr make-composed-keymap.
1125 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1126 (parse_menu_item): Trivial simplification.
1127
1128 2011-07-01 Glenn Morris <rgm@gnu.org>
1129
1130 * Makefile.in (SETTINGS_LIBS): Fix typo.
1131
1132 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1133
1134 * coding.c (Fencode_coding_string): Record the last coding system
1135 used, as the function doc string says (bug#8738).
1136
1137 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1138
1139 * xsettings.c (store_monospaced_changed): Take new font as arg and
1140 check for change against current_mono_font.
1141 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1142 (emacs_settings_constructor, emacs_settings_get_property)
1143 (emacs_settings_set_property, emacs_settings_class_init)
1144 (emacs_settings_init, gsettings_obj): Remove.
1145 (something_changedCB): New function for HAVE_GSETTINGS.
1146 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1147 with value as argument.
1148 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1149 g_settings_new (Bug#8967). Do not create gsettings_obj.
1150 Remove calls to g_settings_bind. Connect something_changedCB to
1151 "changed".
1152
1153 * xgselect.c: Add defined (HAVE_GSETTINGS).
1154 (xgselect_initialize): Ditto.
1155
1156 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1157 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1158 xg_select.
1159
1160 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1161
1162 * eval.c (struct backtrace): Simplify and port the data structure.
1163 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1164 signed bit field, as this assumption is not portable and it makes
1165 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1166 "char debug_on_exit : 1" as this is not portable either; instead,
1167 use the portable "unsigned int debug_on_exit : 1". Remove unused
1168 member evalargs. Remove obsolete comments about cc bombing out.
1169
1170 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1171
1172 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1173 Let HAVE_GSETTINGS override HAVE_GCONF.
1174 (store_monospaced_changed): New function.
1175 (EMACS_SETTINGS): A new type derived from GObject to handle
1176 GSettings notifications.
1177 (emacs_settings_constructor, emacs_settings_get_property)
1178 (emacs_settings_set_property, emacs_settings_class_init):
1179 New functions.
1180 (gsettings_client, gsettings_obj): New variables.
1181 (GSETTINGS_SCHEMA): New define.
1182 (something_changedCB): Call store_monospaced_changed.
1183 (init_gsettings): New function.
1184 (xsettings_initialize): Call init_gsettings.
1185 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1186 to NULL.
1187
1188 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1189 GCONF_CFLAGS/LIBS.
1190
1191 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1192
1193 * window.c (resize_root_window, grow_mini_window)
1194 (shrink_mini_window): Rename Qresize_root_window to
1195 Qwindow_resize_root_window and Qresize_root_window_vertically to
1196 Qwindow_resize_root_window_vertically.
1197
1198 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1201
1202 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1203
1204 * makefile.w32-in: Redesign dependencies so they reflect more
1205 clearly which files are directly included by each source file,
1206 and not through other includes.
1207
1208 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1209
1210 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1211 (sort_overlays, overlay_strings): When an overlay's clone number
1212 matches the window's clone number process the overlay even if
1213 the overlay's window property doesn't match the current window.
1214
1215 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1216 (Fwindow_hchild): Rename to Fwindow_left_child.
1217 (Fwindow_next): Rename to Fwindow_next_sibling.
1218 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1219 (resize_window_check): Rename to window_resize_check.
1220 (resize_window_apply): Rename to window_resize_apply.
1221 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1222 (Fdelete_other_windows_internal, resize_frame_windows)
1223 (Fsplit_window_internal, Fdelete_window_internal)
1224 (grow_mini_window, shrink_mini_window)
1225 (Fresize_mini_window_internal): Fix callers accordingly.
1226
1227 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1228
1229 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1230 (emacs_fixed_set_min_size): Remove.
1231 (emacs_fixed_new): Take frame as argument.
1232
1233 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1234 (_EmacsFixedPrivate): Remove minwidth/height.
1235 Add struct frame *f.
1236 (emacs_fixed_init): Initialize priv->f.
1237 (get_parent_class, emacs_fixed_set_min_size): Remove.
1238 (emacs_fixed_new): Set priv->f to argument.
1239 (emacs_fixed_get_preferred_width)
1240 (emacs_fixed_get_preferred_height): Use min_width/height from
1241 frames size_hint to set minimum and natural (Bug#8919).
1242 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1243 and use min_width/height from frames size_hint to set
1244 min_width/height (Bug#8919).
1245
1246 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1247 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1248 Fix indentation.
1249
1250 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1251
1252 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1253 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1254 called at ZV.
1255
1256 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1257
1258 * process.c (wait_reading_process_output): Bypass select if
1259 waiting for a cell while ignoring keyboard input, and input is
1260 pending. Suggested by Jan Djärv (Bug#8869).
1261
1262 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 Use gnulib's dup2 module instead of rolling our own.
1265 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1266
1267 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1268
1269 * dispnew.c (scrolling_window): Before scrolling, turn off a
1270 mouse-highlight in the window being scrolled.
1271
1272 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1273
1274 Move DEFSYM to lisp.h and use everywhere.
1275
1276 * character.h (DEFSYM): Move declaration...
1277 * lisp.h (DEFSYM): ...here.
1278
1279 * gnutls.c:
1280 * minibuf.c:
1281 * w32menu.c:
1282 * w32proc.c:
1283 * w32select.c: Don't include character.h.
1284
1285 * alloc.c (syms_of_alloc):
1286 * buffer.c (syms_of_buffer):
1287 * bytecode.c (syms_of_bytecode):
1288 * callint.c (syms_of_callint):
1289 * casefiddle.c (syms_of_casefiddle):
1290 * casetab.c (init_casetab_once):
1291 * category.c (init_category_once, syms_of_category):
1292 * ccl.c (syms_of_ccl):
1293 * cmds.c (syms_of_cmds):
1294 * composite.c (syms_of_composite):
1295 * dbusbind.c (syms_of_dbusbind):
1296 * dired.c (syms_of_dired):
1297 * dispnew.c (syms_of_display):
1298 * doc.c (syms_of_doc):
1299 * editfns.c (syms_of_editfns):
1300 * emacs.c (syms_of_emacs):
1301 * eval.c (syms_of_eval):
1302 * fileio.c (syms_of_fileio):
1303 * fns.c (syms_of_fns):
1304 * frame.c (syms_of_frame):
1305 * fringe.c (syms_of_fringe):
1306 * insdel.c (syms_of_insdel):
1307 * keymap.c (syms_of_keymap):
1308 * lread.c (init_obarray, syms_of_lread):
1309 * macros.c (syms_of_macros):
1310 * msdos.c (syms_of_msdos):
1311 * print.c (syms_of_print):
1312 * process.c (syms_of_process):
1313 * search.c (syms_of_search):
1314 * sound.c (syms_of_sound):
1315 * syntax.c (init_syntax_once, syms_of_syntax):
1316 * terminal.c (syms_of_terminal):
1317 * textprop.c (syms_of_textprop):
1318 * undo.c (syms_of_undo):
1319 * w32.c (globals_of_w32):
1320 * window.c (syms_of_window):
1321 * xdisp.c (syms_of_xdisp):
1322 * xfaces.c (syms_of_xfaces):
1323 * xfns.c (syms_of_xfns):
1324 * xmenu.c (syms_of_xmenu):
1325 * xsettings.c (syms_of_xsettings):
1326 * xterm.c (syms_of_xterm): Use DEFSYM.
1327
1328 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1329
1330 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1331
1332 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 Integer and buffer overflow fixes (Bug#8873).
1335
1336 * print.c (printchar, strout): Check for string overflow.
1337 (PRINTPREPARE, printchar, strout):
1338 Don't set size unless allocation succeeds.
1339
1340 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1341 for sizes. Check for string overflow more accurately.
1342 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1343
1344 * macros.c: Integer and buffer overflow fixes.
1345 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1346 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1347 Use ptrdiff_t, not int, for sizes.
1348 Don't increment bufsize until after realloc succeeds.
1349 Check for size-calculation overflow.
1350 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1351
1352 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1353
1354 * lread.c: Integer overflow fixes.
1355 (read_integer): Radix is now EMACS_INT, not int,
1356 to improve quality of diagnostics for out-of-range radices.
1357 Calculate buffer size correctly for out-of-range radices.
1358 (read1): Check for integer overflow in radices, and in
1359 read-circle numbers.
1360 (read_escape): Avoid int overflow.
1361 (Fload, openp, read_buffer_size, read1)
1362 (substitute_object_recurse, read_vector, read_list, map_obarray):
1363 Use ptrdiff_t, not int, for sizes.
1364 (read1): Use EMACS_INT, not int, for sizes.
1365 Check for size overflow.
1366
1367 * image.c (cache_image): Check for size arithmetic overflow.
1368
1369 * lread.c: Integer overflow issues.
1370 (saved_doc_string_size, saved_doc_string_length)
1371 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1372 Now ptrdiff_t, not int.
1373 (read1): Don't assume doc string length fits in int. Check for
1374 out-of-range doc string lengths.
1375 (read_list): Don't assume file position fits in int.
1376 (read_escape): Check for hex character overflow.
1377
1378 2011-06-22 Leo Liu <sdl.web@gmail.com>
1379
1380 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1381 Move to minibuffer.el.
1382
1383 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1384
1385 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1386 The following patches are for when GLYPH_DEBUG && !XASSERT.
1387 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1388 * dispnew.c (flush_stdout):
1389 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1390 Mark as externally visible.
1391 * dispnew.c (check_window_matrix_pointers): Now static.
1392 * dispnew.c (window_to_frame_vpos):
1393 * xfns.c (unwind_create_frame):
1394 * xterm.c (x_check_font): Remove unused local.
1395 * scroll.c (CHECK_BOUNDS):
1396 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1397 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1398 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1399 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1400 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1401 Now static.
1402 (debug_method_add): Use va_list and vsprintf rather than relying
1403 on undefined behavior with wrong number of arguments.
1404 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1405 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1406 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1407 since we're not interested in debugging glyphs with old libraries.
1408 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1409 GCC 4.6.0's static checking.
1410
1411 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 Integer overflow and signedness fixes (Bug#8873).
1414 A few related buffer overrun fixes, too.
1415
1416 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1417
1418 * dispextern.h (struct face.stipple):
1419 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1420 (x_bitmap_mask, x_allocate_bitmap_record)
1421 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1422 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1423 (x_create_bitmap_from_xpm_data):
1424 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1425 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1426 (.bitmaps_last):
1427 * xfaces.c (load_pixmap):
1428 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1429 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1430 (.bitmaps_last, struct x_output.icon_bitmap):
1431 Use ptrdiff_t, not int, for bitmap indexes.
1432 (x_allocate_bitmap_record): Check for size overflow.
1433 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1434
1435 Use ptrdiff_t, not int, for overlay counts.
1436 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1437 * editfns.c (overlays_around, get_pos_property):
1438 * textprop.c (get_char_property_and_overlay):
1439 * xdisp.c (next_overlay_change, note_mouse_highlight):
1440 * xfaces.c (face_at_buffer_position):
1441 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1442 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1443 (Fnext_overlay_change, Fprevious_overlay_change)
1444 (mouse_face_overlay_overlaps, Foverlays_in):
1445 Use ptrdiff_t, not int, for sizes.
1446 (overlays_at, overlays_in): Check for size-calculation overflow.
1447
1448 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1449
1450 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1451 (x_session_initialize): Do not assume string length fits in int.
1452
1453 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1454 This is unlikely, but can occur if DPI is outlandish.
1455
1456 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1457 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1458
1459 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1460 * xrdb.c (magic_file_p, search_magic_path):
1461 Omit last arg SUFFIX; it was always 0. All callers changed.
1462 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1463
1464 * xfont.c (xfont_match): Avoid need for strlen.
1465
1466 * xfns.c: Don't assume strlen fits in int.
1467 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1468
1469 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1470 not unsigned long, as we prefer signed integers. All callers changed.
1471 Detect integer overflow in repeat count.
1472 (message_dolog): Don't assume print length fits in 39 bytes.
1473 (display_mode_element): Don't assume strlen fits in int.
1474
1475 * termcap.c: Don't assume sizes fit in int and never overflow.
1476 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1477 (gobble_line): Check for size-calculation overflow.
1478
1479 * minibuf.c (Fread_buffer):
1480 * lread.c (intern, intern_c_string):
1481 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1482 Don't assume string length fits in int.
1483
1484 * keyboard.c (parse_tool_bar_item):
1485 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1486
1487 * font.c: Don't assume string length fits in int.
1488 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1489 Use ptrdiff_t, not int.
1490 (font_intern_prop): Don't assume string length fits in int.
1491 Don't assume integer property fits in fixnum.
1492 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1493
1494 * filelock.c: Fix some buffer overrun and integer overflow issues.
1495 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1496 Reformulate so as not to need the command string.
1497 Invoke gzip -cd rather than gunzip, as it's more portable.
1498 (lock_info_type, lock_file_1, lock_file):
1499 Don't assume pid_t and time_t fit in unsigned long.
1500 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1501 (current_lock_owner): Prefer signed type for sizes.
1502 Use memcpy, not strncpy, where memcpy is what is really wanted.
1503 Don't assume (via atoi) that time_t and pid_t fit in int.
1504 Check for time_t and/or pid_t out of range, e.g., via a network share.
1505 Don't alloca where an auto var works fine.
1506
1507 * fileio.c: Fix some integer overflow issues.
1508 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1509 Don't assume string length fits in int.
1510 (directory_file_name): Don't assume string length fits in long.
1511 (make_temp_name): Don't assume pid fits in int, or that its print
1512 length is less than 20.
1513
1514 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1515
1516 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1517
1518 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1519
1520 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1521 We prefer signed integers, even for size calculations.
1522
1523 * emacs.c: Don't assume string length fits in 'int'.
1524 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1525 (main): Don't invoke strlen when not needed.
1526
1527 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1528 (XD_DEBUG_MESSAGE): Don't waste a byte.
1529
1530 * callproc.c (getenv_internal_1, getenv_internal)
1531 (Fgetenv_internal):
1532 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1533
1534 * lread.c (invalid_syntax): Omit length argument.
1535 All uses changed. This doesn't fix a bug, but it simplifies the
1536 code away from its former Hollerith-constant appearance, and it's
1537 one less 'int' to worry about when looking at integer-overflow issues.
1538 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1539
1540 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1541 This didn't break anything, but it didn't help either.
1542 It's confusing to put a bogus integer in a place where the actual
1543 value does not matter.
1544 (LIST_END_P): Remove unused macro and its bogus comment.
1545 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1546
1547 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1548 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1549 implementation.
1550 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1551 We prefer signed types, and the value cannot exceed the EMACS_INT
1552 range anyway (because otherwise the length would not be representable).
1553 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1554 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1555 This avoids a GCC warning when WIDE_EMACS_INT.
1556
1557 * indent.c (sane_tab_width): New function.
1558 (current_column, scan_for_column, Findent_to, position_indentation)
1559 (compute_motion): Use it. This is just for clarity.
1560 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1561
1562 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1563
1564 * lisp.h (lint_assume): New macro.
1565 * composite.c (composition_gstring_put_cache):
1566 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1567
1568 * editfns.c, insdel.c:
1569 Omit unnecessary forward decls, to simplify future changes.
1570
1571 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1572
1573 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1574
1575 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1576 Use much-faster test for byte-length change.
1577 Don't assume string byte-length fits in 'int'.
1578 Check that character arg fits in 'int'.
1579 (mapcar1): Declare byte as byte, for clarity.
1580
1581 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1582
1583 * fns.c (concat): Catch string overflow earlier.
1584 Do not rely on integer wraparound.
1585
1586 * dispextern.h (struct it.overlay_strings_charpos)
1587 (struct it.selective): Now EMACS_INT, not int.
1588 * xdisp.c (forward_to_next_line_start)
1589 (back_to_previous_visible_line_start)
1590 (reseat_at_next_visible_line_start, next_element_from_buffer):
1591 Don't arbitrarily truncate the value of 'selective' to int.
1592
1593 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1594
1595 * composite.c: Don't truncate sizes to 'int'.
1596 (composition_gstring_p, composition_reseat_it)
1597 (composition_adjust_point): Use EMACS_INT, not int.
1598 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1599 not EMACS_UINT, for indexes.
1600
1601 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1602
1603 * buffer.c: Include <verify.h>.
1604 (struct sortvec.priority, struct sortstr.priority):
1605 Now EMACS_INT, not int.
1606 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1607 (struct sortstr.size, record_overlay_string)
1608 (struct sortstrlist.size, struct sortlist.used):
1609 Don't truncate size to int.
1610 (record_overlay_string): Check for size-calculation overflow.
1611 (init_buffer_once): Check at compile-time, not run-time.
1612
1613 2011-06-22 Jim Meyering <meyering@redhat.com>
1614
1615 Don't leak an XBM-image-sized buffer
1616 * image.c (xbm_load): Free the image buffer after using it.
1617
1618 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 Port to Sun C.
1621 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1622 that Sun C diagnosed.
1623 * fns.c (secure_hash): Fix pointer signedness issue.
1624 * intervals.c (static_offset_intervals): New function.
1625 (offset_intervals): Use it.
1626
1627 2011-06-21 Leo Liu <sdl.web@gmail.com>
1628
1629 * deps.mk (fns.o):
1630 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1631 sha512.h.
1632
1633 * fns.c (secure_hash): Rename from crypto_hash_function and change
1634 the first arg to accept symbols.
1635 (Fsecure_hash): New primitive.
1636 (syms_of_fns): New symbols.
1637
1638 2011-06-20 Deniz Dogan <deniz@dogan.se>
1639
1640 * process.c (Fset_process_buffer): Clarify return value in
1641 docstring.
1642
1643 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1644
1645 * dispnew.c (add_window_display_history): Use BVAR.
1646
1647 * xdisp.c (debug_method_add): Use BVAR.
1648 (check_window_end, dump_glyph_matrix, dump_glyph)
1649 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1650
1651 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1652 Likewise.
1653
1654 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1655 check till after the cache is created in init_frame_faces.
1656
1657 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1658
1659 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1660
1661 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1662
1663 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1664 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1665 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1666
1667 Improve buffer-overflow checking (Bug#8873).
1668 * fileio.c (Finsert_file_contents):
1669 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1670 Remove the old (too-loose) buffer overflow checks.
1671 They weren't needed, since make_gap checks for buffer overflow.
1672 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1673 The old code merely checked for Emacs fixnum overflow, and relied
1674 on undefined (wraparound) behavior. The new code avoids undefined
1675 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1676
1677 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1678 Tune. Don't use wider integers than needed. Don't use alloca.
1679 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1680
1681 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1682
1683 * insdel.c, lisp.h (buffer_overflow): New function.
1684 (insert_from_buffer_1, replace_range, replace_range_2):
1685 * insdel.c (make_gap_larger):
1686 * editfns.c (Finsert_char):
1687 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1688
1689 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1690
1691 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1692
1693 Integer overflow and signedness fixes (Bug#8873).
1694
1695 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1696 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1697
1698 * fileio.c: Don't assume EMACS_INT fits in off_t.
1699 (emacs_lseek): New static function.
1700 (Finsert_file_contents, Fwrite_region): Use it.
1701 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1702
1703 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1704
1705 * fns.c: Don't overflow int when computing a list length.
1706 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1707 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1708 truncation on 64-bit hosts. Check for QUIT every
1709 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1710 faster and is responsive enough.
1711 (Flength): Report an error instead of overflowing an integer.
1712 (Fsafe_length): Return a float if the value is not representable
1713 as a fixnum. This shouldn't happen except in contrived situations.
1714 (Fnthcdr, Fsort): Don't assume list length fits in int.
1715 (Fcopy_sequence): Don't assume vector length fits in int.
1716
1717 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1718 (header_size, word_size): New constants.
1719 (allocate_vectorlike): Don't check size overflow here.
1720 (allocate_vector): Check it here instead, since this is the only
1721 caller of allocate_vectorlike that could cause overflow.
1722 Check that the new vector's length is representable as a fixnum.
1723
1724 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1725 The previous code was bogus. For example, next_almost_prime (32)
1726 returned 39, which is undesirable as it is a multiple of 3; and
1727 next_almost_prime (24) returned 25, which is a multiple of 5 so
1728 why was the code bothering to check for multiples of 7?
1729
1730 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1731
1732 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1733
1734 Variadic C functions now count arguments with ptrdiff_t.
1735 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1736 Back then I didn't know that the Emacs coding style prefers signed int.
1737 Also, in the meantime I found a few more instances where arguments
1738 were being counted with int, which may truncate counts on 64-bit
1739 machines, or EMACS_INT, which may be unnecessarily wide.
1740 * lisp.h (struct Lisp_Subr.function.aMANY)
1741 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1742 Arg counts are now ptrdiff_t, not size_t.
1743 All variadic functions and their callers changed accordingly.
1744 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1745 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1746 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1747 * callint.c (Fcall_interactively): Check arg count for overflow,
1748 to avoid potential buffer overrun. Use signed char, not 'int',
1749 for 'varies' array, so that we needn't bother to check its size
1750 calculation for overflow.
1751 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1752 * eval.c (apply_lambda):
1753 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1754 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1755 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1756
1757 * callint.c (Fcall_interactively): Don't use index var as event count.
1758
1759 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1760 * mem-limits.h (SIZE): Remove; no longer used.
1761
1762 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1763
1764 Remove unnecessary casts.
1765 * xterm.c (x_term_init):
1766 * xfns.c (x_set_border_pixel):
1767 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1768 These aren't needed now that we assume ANSI C.
1769
1770 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1771 It's more likely to cause problems (due to unsigned overflow)
1772 than to cure them.
1773
1774 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1775
1776 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1777
1778 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1779
1780 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1781
1782 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1783
1784 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1785
1786 GLYPH_CODE_FACE returns EMACS_INT, not int.
1787 * dispextern.h (merge_faces):
1788 * xfaces.c (merge_faces):
1789 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1790 Don't assume EMACS_INT fits in int.
1791
1792 * character.h (CHAR_VALID_P): Remove unused parameter.
1793 * fontset.c, lisp.h, xdisp.c: All uses changed.
1794
1795 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1796
1797 * fns.c (concat): Minor tuning based on overflow analysis.
1798 This doesn't fix any bugs. Use int to hold character, instead
1799 of constantly refetching from Emacs object. Use XFASTINT, not
1800 XINT, for value known to be a character. Don't bother comparing
1801 a single byte to 0400, as it's always less.
1802
1803 * floatfns.c (Fexpt):
1804 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1805
1806 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1807 for characters.
1808
1809 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1810
1811 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1812 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1813 incorrectly succeed when S was a string, because 4294967386 was
1814 truncated before it was used.
1815
1816 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1817 Otherwise, an out-of-range integer could cause undefined behavior
1818 on a 64-bit host.
1819
1820 * composite.c: Use int, not EMACS_INT, for characters.
1821 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1822 EMACS_INT, for values that are known to be in character range.
1823 This doesn't fix any bugs but is the usual style inside Emacs and
1824 may generate better code on 32-bit machines.
1825
1826 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1827 This is for reasons similar to the recent CHAR_STRING fix.
1828 * charset.c (Fencode_char): Check that character arg is actually
1829 a character. Pass an int to ENCODE_CHAR.
1830 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1831 wider than 'int', as a compile-time check to prevent future regressions
1832 in this area.
1833
1834 * character.c (char_string): Remove unnecessary casts.
1835
1836 Make sure a 64-bit char is never passed to CHAR_STRING.
1837 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1838 by silently ignoring the top 32 bits, allowing some values
1839 that were far too large to be valid characters.
1840 * character.h: Include <verify.h>.
1841 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1842 arguments are no wider than unsigned, as a compile-time check
1843 to prevent future regressions in this area.
1844 * data.c (Faset):
1845 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1846 (Fsubst_char_in_region):
1847 * fns.c (concat):
1848 * xdisp.c (decode_mode_spec_coding):
1849 Adjust to CHAR_STRING's new requirement.
1850 * editfns.c (Finsert_char, Fsubst_char_in_region):
1851 * fns.c (concat): Check that character args are actually
1852 characters. Without this test, these functions did the wrong
1853 thing with wildly out-of-range values on 64-bit hosts.
1854
1855 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1856 These casts should not be needed on 32-bit hosts, either.
1857 * keyboard.c (read_char):
1858 * lread.c (Fload): Remove casts to unsigned.
1859
1860 * lisp.h (UNSIGNED_CMP): New macro.
1861 This fixes comparison bugs on 64-bit hosts.
1862 (ASCII_CHAR_P): Use it.
1863 * casefiddle.c (casify_object):
1864 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1865 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1866 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1867 * dispextern.h (FACE_FROM_ID):
1868 * keyboard.c (read_char): Use UNSIGNED_CMP.
1869
1870 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1871 not to EMACS_INT, to avoid GCC warning.
1872
1873 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1874
1875 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1876 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1877 isn't needed on 32-bit machines.
1878
1879 * buffer.c (Fgenerate_new_buffer_name):
1880 Use EMACS_INT for count, not int.
1881 (advance_to_char_boundary): Return EMACS_INT, not int.
1882
1883 * data.c (Qcompiled_function): Now static.
1884
1885 * window.c (window_body_lines): Now static.
1886
1887 * image.c (gif_load): Rename local to avoid shadowing.
1888
1889 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1890 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1891 * alloc.c (make_save_value): Integer argument is now of type
1892 ptrdiff_t, not int.
1893 (mark_object): Use ptrdiff_t, not int.
1894 * lisp.h (pD): New macro.
1895 * print.c (print_object): Use it.
1896
1897 * alloc.c: Use EMACS_INT, not int, to count objects.
1898 (total_conses, total_markers, total_symbols, total_vector_size)
1899 (total_free_conses, total_free_markers, total_free_symbols)
1900 (total_free_floats, total_floats, total_free_intervals)
1901 (total_intervals, total_strings, total_free_strings):
1902 Now EMACS_INT, not int. All uses changed.
1903 (Fgarbage_collect): Compute overall total using a double, so that
1904 integer overflow is less likely to be a problem. Check for overflow
1905 when converting back to an integer.
1906 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1907 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1908 These were 'int' variables that could overflow on 64-bit hosts;
1909 they were never used, so remove them instead of repairing them.
1910 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1911 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1912 Previously, this ceilinged at INT_MAX, but that doesn't work on
1913 64-bit machines.
1914 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1915
1916 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1917 (allocate_vectorlike): Check for ptrdiff_t overflow.
1918 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1919 when a (possibly-narrower) signed value would do just as well.
1920 We prefer using signed arithmetic, to avoid comparison confusion.
1921
1922 * alloc.c: Catch some string size overflows that we were missing.
1923 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1924 for convenience in STRING_BYTES_MAX.
1925 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1926 The definition here is exact; the one in lisp.h was approximate.
1927 (allocate_string_data): Check for string overflow. This catches
1928 some instances we weren't catching before. Also, it catches
1929 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1930 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1931 and ptrdiff_t and EMACS_INT are both 64 bits.
1932
1933 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1934 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1935 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1936
1937 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1938
1939 * alloc.c (Fmake_string): Check for out-of-range init.
1940
1941 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1942
1943 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1944
1945 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1946
1947 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1948 xg_get_default_scrollbar_width.
1949
1950 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1951 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1952 (style_changed_cb): Call update_theme_scrollbar_width and call
1953 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1954 all frames (Bug#8505).
1955 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1956 Call gtk_window_set_resizable if HAVE_GTK3.
1957 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1958 and height if HAVE_GTK3 (Bug#8505).
1959 (scroll_bar_width_for_theme): New variable.
1960 (update_theme_scrollbar_width): New function.
1961 (xg_get_default_scrollbar_width): Move code to
1962 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1963 (xg_initialize): Call update_theme_scrollbar_width.
1964
1965 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1966
1967 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1968
1969 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1970
1971 * frame.c (make_frame): Call other_buffer_safely instead of
1972 other_buffer.
1973
1974 * window.c (temp_output_buffer_show): Call display_buffer with
1975 second argument Vtemp_buffer_show_specifiers and reset latter
1976 immediately after the call.
1977 (Vtemp_buffer_show_specifiers): New variable.
1978 (auto_window_vscroll_p, next_screen_context_lines)
1979 (Vscroll_preserve_screen_position): Remove leading asterisks from
1980 doc-strings.
1981
1982 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1983
1984 Fix minor problems found by GCC 4.6.0 static checking.
1985 * buffer.c (Qclone_number): Remove for now, as it's unused.
1986 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1987 (record_buffer): Remove unused local.
1988 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1989 (set_frame_buffer_list): Remove; unused.
1990 * frame.h (other_visible_frames): Remove decl.
1991 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1992 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1993 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1994 if HAVE_GPM.
1995 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1996 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1997 Define only if HAVE_GPM.
1998 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1999 (update_hints_inhibit): Remove; never set. All uses removed.
2000 * widgetprv.h (emacsFrameClassRec): Remove decl.
2001 * window.c (delete_deletable_window): Now returns void, since it
2002 wasn't returning anything.
2003 (compare_window_configurations): Remove unused locals.
2004 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2005 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2006 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2007 the same widths as pointers. This follows up on the 2011-05-06 patch.
2008 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2009 * xterm.h: Likewise.
2010 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2011
2012 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2013
2014 * makefile.w32-in: Update dependencies.
2015 (LISP_H): Add lib/intprops.h.
2016
2017 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2018
2019 * image.c (gif_load): Add animation frame delay to the metadata.
2020 (syms_of_image): Use DEFSYM. New symbol `delay'.
2021
2022 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2023
2024 * window.c (delete_deletable_window): Re-add.
2025 (Fset_window_configuration): Rewrite to handle dead buffers and
2026 consequently deletable windows.
2027 (window_tree, Fwindow_tree): Remove. Supply functionality in
2028 window.el.
2029 (compare_window_configurations): Simplify code.
2030
2031 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2032
2033 * image.c (imagemagick_load_image): Fix type mismatch.
2034 (Fimagemagick_types): Likewise.
2035
2036 * window.h (replace_buffer_in_windows): Declare.
2037
2038 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2039
2040 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2041 Qclone_number. Remove external declaration of Qdelete_window.
2042 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2043 code.
2044 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2045 Qbuffer_list_update_hook if allowed.
2046 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2047 buffer list implementation.
2048 (other_buffer_safely): New function.
2049 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2050 calls to replace_buffer_in_windows and
2051 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2052 if allowed.
2053 (record_buffer): Inhibit quitting and rewrite using quittable
2054 functions. Run Qbuffer_list_update_hook if allowed.
2055 (Frecord_buffer, Funrecord_buffer): New functions.
2056 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2057 switch-to-buffer to window.el.
2058 (bury-buffer): Move to window.el.
2059 (Vbuffer_list_update_hook): New variable.
2060
2061 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2062 section.
2063
2064 * window.h (resize_frame_windows): Move up in code.
2065 (Fwindow_frame): Remove EXFUN.
2066 (replace_buffer_in_all_windows): Remove prototype.
2067 (replace_buffer_in_windows_safely): Add prototype.
2068
2069 * window.c: Declare Qdelete_window static again. Move down
2070 declaration of select_count.
2071 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2072 (Fother_window): Move to window.el.
2073 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2074 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2075 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2076 window.el.
2077 (replace_buffer_in_windows): Implement by calling
2078 Qreplace_buffer_in_windows.
2079 (replace_buffer_in_all_windows): Remove with some functionality
2080 moved into replace_buffer_in_windows_safely.
2081 (replace_buffer_in_windows_safely): New function.
2082 (select_window_norecord, select_frame_norecord): Move in front
2083 of run_window_configuration_change_hook. Remove now obsolete
2084 declarations.
2085 (Fset_window_buffer): Rewrite doc-string. Call
2086 Qrecord_window_buffer.
2087 (keys_of_window): Move binding for other-window to window.el.
2088
2089 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2090
2091 * dispextern.h (struct image): Replace data member, whose int_val
2092 and ptr_val fields were not used by anything, with a single
2093 lisp_val object.
2094
2095 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2096 (gif_clear_image, gif_load, imagemagick_load_image)
2097 (gs_clear_image, gs_load): Callers changed.
2098
2099 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2100
2101 * buffer.h: Include <time.h>, for time_t.
2102 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2103
2104 Fix minor problems found by static checking.
2105
2106 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2107
2108 Make identifiers static if they are not used in other modules.
2109 * data.c (Qcompiled_function, Qframe, Qvector):
2110 * image.c (QimageMagick, Qsvg):
2111 * minibuf.c (Qmetadata):
2112 * window.c (resize_window_check, resize_root_window): Now static.
2113 * window.h (resize_window_check, resize_root_window): Remove decls.
2114
2115 * window.c (window_deletion_count, delete_deletable_window):
2116 Remove; unused.
2117 (window_body_lines): Now static.
2118 (Fdelete_other_windows_internal): Mark vars as initialized.
2119 Make sure 'resize_failed' is initialized.
2120 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2121 (resize_window_apply): Remove unused local.
2122 * window.h (delete_deletable_window): Remove decl.
2123
2124 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2125 (imagemagick_load_image): Fix pointer signedness problem by changing
2126 last arg from unsigned char * to char *. All uses changed.
2127 Also, fix a local for similar reasons.
2128 Remove unused locals. Remove locals to avoid shadowing.
2129 (fn_rsvg_handle_free): Remove; unused.
2130 (svg_load, svg_load_image): Fix pointer signedness problem.
2131 (imagemagick_load_image): Don't use garbage pointer image_wand.
2132
2133 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2134
2135 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2136
2137 * image.c (gif_load): Fix omitted cast error introduced by
2138 2011-06-06 change.
2139
2140 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2141
2142 * window.h (resize_proportionally, orig_total_lines)
2143 (orig_top_line): Remove from window structure.
2144 (set_window_height, set_window_width, change_window_heights)
2145 (Fdelete_window): Remove prototypes.
2146 (resize_frame_windows): Remove duplicate declaration.
2147
2148 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2149
2150 * window.h (resize_frame_windows, resize_window_check)
2151 (delete_deletable_window, resize_root_window)
2152 (resize_frame_windows): Declare prototypes.
2153
2154 * window.c (resize_window_apply): Make definition be "static" to
2155 match the prototype.
2156
2157 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2158
2159 * window.c: Remove declarations of Qwindow_size_fixed,
2160 window_min_size_1, window_min_size_2, window_min_size,
2161 size_window, window_fixed_size_p, enlarge_window, delete_window.
2162 Remove static from declaration of Qdelete_window, it's
2163 temporarily needed by Fbury_buffer.
2164 (replace_window): Don't assign orig_top_line and
2165 orig_total_lines.
2166 (Fdelete_window, delete_window): Remove. Window deletion is
2167 handled by window.el.
2168 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2169 Fdelete_window calls with calls to Qdelete_window.
2170 (Fdelete_other_windows): Remove. Deleting other windows is
2171 handled by window.el.
2172 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2173 handled in window.el.
2174 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2175 Window minimum sizes are handled in window.el.
2176 (shrink_windows, size_window, set_window_height)
2177 (set_window_width, change_window_heights, window_height)
2178 (window_width, CURBEG, CURSIZE, enlarge_window)
2179 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2180 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2181 handled in window.el.
2182 (make_dummy_parent): Rename to make_parent_window and give it a
2183 second argument horflag.
2184 (make_window): Don't set resize_proportionally any more.
2185 (Fsplit_window): Remove. Windows are split in window.el.
2186 (save_restore_action, save_restore_orig_size)
2187 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2188 Resize mini windows in window.el.
2189 (grow_mini_window, shrink_mini_window): Implement by calling
2190 Qresize_root_window_vertically, resize_window_check and
2191 resize_window_apply.
2192 (saved_window, Fset_window_configuration, save_window_save): Do
2193 not handle orig_top_line, orig_total_lines, and
2194 resize_proportionally.
2195 (window_min_height, window_min_width): Move to window.el.
2196 (keys_of_window): Move bindings for delete-other-windows,
2197 split-window, delete-window and enlarge-window to window.el.
2198
2199 * buffer.c: Temporarily extern Qdelete_window.
2200 (Fbury_buffer): Temporarily call Qdelete_window instead of
2201 Fdelete_window (Fbury_buffer will move to window.el soon).
2202
2203 * frame.c (set_menu_bar_lines_1): Remove code handling
2204 orig_top_line and orig_total_lines.
2205
2206 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2207 set_window_height but set heights directly.
2208 (change_frame_size_1): Use resize_frame_windows.
2209
2210 * xdisp.c (init_xdisp): Don't use set_window_height but set
2211 heights directly.
2212
2213 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2214 resize_frame_windows instead of change_window_heights and run
2215 run_window_configuration_change_hook.
2216
2217 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2218 instead of change_window_heights and run
2219 run_window_configuration_change_hook.
2220
2221 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2222
2223 * window.c (replace_window): Rename second argument REPLACEMENT to
2224 NEW. New third argument SETFLAG. Rewrite.
2225 (delete_window, make_dummy_parent): Call replace_window with
2226 third argument 1.
2227 (window_list_1): Move down in code.
2228 (run_window_configuration_change_hook): Move set_buffer part
2229 before select_frame_norecord part in order to unwind correctly.
2230 Rename count1 to count.
2231 (recombine_windows, delete_deletable_window, resize_root_window)
2232 (Fdelete_other_windows_internal)
2233 (Frun_window_configuration_change_hook, make_parent_window)
2234 (resize_window_check, resize_window_apply, Fresize_window_apply)
2235 (resize_frame_windows, Fsplit_window_internal)
2236 (Fdelete_window_internal, Fresize_mini_window_internal): New
2237 functions.
2238 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2239
2240 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2241
2242 * window.h (window): Add some new members to window structure -
2243 normal_lines, normal_cols, new_total, new_normal, clone_number,
2244 splits, nest, prev_buffers, next_buffers.
2245 (WINDOW_TOTAL_SIZE): Move here from window.c.
2246 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2247
2248 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2249 Remove.
2250 (make_dummy_parent): Set new members of windows structure.
2251 (make_window): Move down in code. Handle new members of window
2252 structure.
2253 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2254 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2255 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2256 (Fset_window_prev_buffers, Fwindow_next_buffers)
2257 (Fset_window_next_buffers, Fset_window_clone_number): New
2258 functions.
2259 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2260 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2261 Doc-string fixes.
2262 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2263 Argument WINDOW can be now internal window too.
2264 (Fwindow_use_time): Move up in code.
2265 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2266 Rewrite doc-string.
2267 (Fset_window_configuration, saved_window)
2268 (Fcurrent_window_configuration, save_window_save): Handle new
2269 members of window structure.
2270 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2271 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2272 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2273 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2274 Qget_mru_window, Qresize_root_window,
2275 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2276 Qauto_buffer_name; staticpro them.
2277
2278 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2279
2280 * window.c (Fwindow_total_size, Fwindow_left_column)
2281 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2282 (Fwindow_list_1): New functions.
2283 (window_box_text_cols): Replace with window_body_cols.
2284 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2285 window_body_cols instead of window_box_text_cols.
2286 (delete_window, Fset_window_configuration): Call
2287 delete_all_subwindows with window as argument.
2288 (delete_all_subwindows): Take a window as argument and not a
2289 structure. Rewrite.
2290 (window_loop): Remove handling of GET_LRU_WINDOW and
2291 GET_LARGEST_WINDOW.
2292 (Fget_lru_window, Fget_largest_window): Move to window.el.
2293
2294 * window.h: Extern window_body_cols instead of
2295 window_box_text_cols. delete_all_subwindows now takes a
2296 Lisp_Object as argument.
2297
2298 * indent.c (compute_motion, Fcompute_motion): Use
2299 window_body_cols instead of window_box_text_cols.
2300
2301 * frame.c (delete_frame): Call delete_all_subwindows with root
2302 window as argument.
2303
2304 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2305
2306 * fns.c (Fputhash): Document return value.
2307
2308 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2309
2310 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2311
2312 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2313
2314 Cons<->int and similar integer overflow fixes (Bug#8794).
2315
2316 Check for overflow when converting integer to cons and back.
2317 * charset.c (Fdefine_charset_internal, Fdecode_char):
2318 Use cons_to_unsigned to catch overflow.
2319 (Fencode_char): Use INTEGER_TO_CONS.
2320 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2321 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2322 * data.c (long_to_cons, cons_to_long): Remove.
2323 (cons_to_unsigned, cons_to_signed): New functions.
2324 These signal an error for invalid or out-of-range values.
2325 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2326 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2327 * font.c (Ffont_variation_glyphs):
2328 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2329 * lisp.h: Include <intprops.h>.
2330 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2331 (cons_to_signed, cons_to_unsigned): New decls.
2332 (long_to_cons, cons_to_long): Remove decls.
2333 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2334 (Fprimitive_undo): Use CONS_TO_INTEGER.
2335 * xfns.c (Fx_window_property): Likewise.
2336 * xselect.c: Include <limits.h>.
2337 (x_own_selection, selection_data_to_lisp_data):
2338 Use INTEGER_TO_CONS.
2339 (x_handle_selection_request, x_handle_selection_clear)
2340 (x_get_foreign_selection, Fx_disown_selection_internal)
2341 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2342 (lisp_data_to_selection_data): Use cons_to_unsigned.
2343 (x_fill_property_data): Use cons_to_signed.
2344 Report values out of range.
2345
2346 Check for buffer and string overflow more precisely.
2347 * buffer.h (BUF_BYTES_MAX): New macro.
2348 * lisp.h (STRING_BYTES_MAX): New macro.
2349 * alloc.c (Fmake_string):
2350 * character.c (string_escape_byte8):
2351 * coding.c (coding_alloc_by_realloc):
2352 * doprnt.c (doprnt):
2353 * editfns.c (Fformat):
2354 * eval.c (verror):
2355 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2356 since they may not be the same number.
2357 * editfns.c (Finsert_char):
2358 * fileio.c (Finsert_file_contents):
2359 Likewise for BUF_BYTES_MAX.
2360
2361 * image.c: Use ptrdiff_t, not int, for sizes.
2362 (slurp_file): Switch from int to ptrdiff_t.
2363 All uses changed.
2364 (slurp_file): Check that file size fits in both size_t (for
2365 malloc) and ptrdiff_t (for sanity and safety).
2366
2367 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2368 if b->modtime has its maximal value.
2369
2370 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2371
2372 Don't assume time_t can fit into int.
2373 * buffer.h (struct buffer.modtime): Now time_t, not int.
2374 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2375 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2376
2377 Minor fixes for signed vs unsigned integers.
2378 * character.h (MAYBE_UNIFY_CHAR):
2379 * charset.c (maybe_unify_char):
2380 * keyboard.c (read_char, reorder_modifiers):
2381 XINT -> XFASTINT, since the integer must be nonnegative.
2382 * ftfont.c (ftfont_spec_pattern):
2383 * keymap.c (access_keymap, silly_event_symbol_error):
2384 XUINT -> XFASTINT, since the integer must be nonnegative.
2385 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2386 since it makes no difference and we prefer signed.
2387 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2388 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2389 nonnegative.
2390
2391 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2392
2393 * window.h (Fwindow_frame): Declare.
2394
2395 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2398 (SPARE_MEMORY): Always define.
2399 (LARGE_REQUEST): Remove.
2400 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2401
2402 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2403
2404 * lisp.h: Move EXFUNS for Fframe_root_window,
2405 Fframe_first_window and Fset_frame_selected_window to window.h.
2406
2407 * window.h: Move EXFUNS for Fframe_root_window,
2408 Fframe_first_window and Fset_frame_selected_window here from
2409 lisp.h.
2410
2411 * frame.c (Fwindow_frame, Fframe_first_window)
2412 (Fframe_root_window, Fframe_selected_window)
2413 (Fset_frame_selected_window): Move to window.c.
2414 (Factive_minibuffer_window): Move to minibuf.c.
2415 (Fother_visible_frames_p): New function.
2416
2417 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2418
2419 * window.c (decode_window, decode_any_window): Move up in code.
2420 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2421 (inhibit_frame_unsplittable): Remove unused variable.
2422 (Fwindow_buffer): Move up and rewrite doc-string.
2423 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2424 (Fwindow_prev): New functions.
2425 (Fwindow_frame): Move here from frame.c. Accept any window as
2426 argument.
2427 (Fframe_root_window, Fframe_first_window)
2428 (Fframe_selected_window): Move here from frame.c. Accept frame
2429 or arbitrary window as argument. Update doc-strings.
2430 (Fminibuffer_window): Move up in code.
2431 (Fwindow_minibuffer_p): Move up in code and simplify.
2432 (Fset_frame_selected_window): Move here from frame.c.
2433 Marginal rewrite.
2434 (Fselected_window, select_window, Fselect_window): Move up in
2435 code. Minor doc-string fixes.
2436
2437 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2440 Do not assume that spare memory exists; that assumption is valid
2441 only if SYSTEM_MALLOC.
2442 (LARGE_REQUEST): New macro, so that the issue of large requests
2443 is separated from the issue of spare memory.
2444
2445 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2446
2447 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2448 format. (Bug#8806)
2449
2450 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2451
2452 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2453 before statements.
2454
2455 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2456
2457 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2458
2459 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2460
2461 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2462 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2463
2464 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2465
2466 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2467
2468 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2469
2470 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2471 (x_clipboard_manager_save): Add return value.
2472 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2473 New error handlers.
2474 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2475 Obey Vx_select_enable_clipboard_manager. Catch errors in
2476 x_clipboard_manager_save (Bug#8779).
2477 (Vx_select_enable_clipboard_manager): New variable.
2478 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2479
2480 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2481
2482 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2483
2484 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2485
2486 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2487 in the current matrix if keep_current_p is non-zero.
2488
2489 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2490
2491 * bidi.c (bidi_level_of_next_char): Fix last change.
2492
2493 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2494
2495 Support bidi reordering of text covered by display properties.
2496
2497 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2498 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2499 (bidi_cache_search, bidi_cache_iterator_state)
2500 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2501 (bidi_level_of_next_char, bidi_move_to_visually_next):
2502 Support character positions inside a run of characters covered by a
2503 display string.
2504 (bidi_paragraph_init, bidi_resolve_explicit_1)
2505 (bidi_level_of_next_char): Call bidi_fetch_char and
2506 bidi_fetch_char_advance instead of FETCH_CHAR and
2507 FETCH_CHAR_ADVANCE.
2508 (bidi_init_it): Initialize new members.
2509 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2510 definitions.
2511 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2512 instead of using explicit *_CHAR codes.
2513 (bidi_resolve_explicit, bidi_resolve_weak):
2514 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2515 bidirectional text is supported only in multibyte buffers.
2516 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2517 it to initialize the frame_window_p member of struct bidi_it.
2518 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2519 (bidi_resolve_explicit, bidi_resolve_weak)
2520 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2521 bidi_it->nchars is non-positive.
2522 (bidi_level_of_next_char): Don't try to lookup the cache for the
2523 next/previous character if nothing is cached there yet, or if we
2524 were just reseat()'ed to a new position.
2525
2526 * xdisp.c (set_cursor_from_row): Set start and stop points
2527 according to the row's direction when priming the loop that looks
2528 for the glyph on which to display cursor.
2529 (single_display_spec_intangible_p): Function deleted.
2530 (display_prop_intangible_p): Reimplement to call
2531 handle_display_spec instead of single_display_spec_intangible_p.
2532 Accept 3 additional arguments needed by handle_display_spec.
2533 This fixes incorrect cursor motion across display property with complex
2534 values: lists, `(when COND...)' forms, etc.
2535 (single_display_spec_string_p): Support property values that are
2536 lists with the argument STRING its top-level element.
2537 (display_prop_string_p): Fix the condition for processing a
2538 property that is a list to be consistent with handle_display_spec.
2539 (handle_display_spec): New function, refactored from the
2540 last portion of handle_display_prop.
2541 (compute_display_string_pos): Accept additional argument
2542 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2543 value of a `display' property is a "replacing spec".
2544 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2545 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2546 the display property, but just return a value indicating whether
2547 the display property will replace the characters it covers.
2548 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2549 frame_window_p members of struct bidi_it.
2550 (compute_display_string_pos, compute_display_string_end):
2551 New functions.
2552 (push_it): Accept second argument POSITION, where pop_it should
2553 jump to continue iteration.
2554 (reseat_1): Initialize bidi_it.disp_pos.
2555
2556 * keyboard.c (adjust_point_for_property): Adjust the call to
2557 display_prop_intangible_p to its new signature.
2558
2559 * dispextern.h (struct bidi_it): New member frame_window_p.
2560 (bidi_init_it): Update prototypes.
2561 (display_prop_intangible_p): Update prototype.
2562 (compute_display_string_pos, compute_display_string_end):
2563 Declare prototypes.
2564 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2565 EMACS_INT.
2566
2567 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2568
2569 Malloc failure behavior now depends on size of allocation.
2570 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2571 * lisp.h: Change signatures accordingly.
2572 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2573 All callers changed. (Bug#8762)
2574
2575 * gnutls.c: Use Emacs's memory allocators.
2576 Without this change, the gnutls library would invoke malloc etc.
2577 directly, which causes problems on non-SYNC_INPUT hosts, and which
2578 runs afoul of improving memory_full behavior. (Bug#8761)
2579 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2580 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2581 xfree instead of the default malloc, realloc, free.
2582 (Fgnutls_boot): No need to check for memory allocation failure,
2583 since xmalloc does that for us.
2584
2585 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2586 * category.c (hash_get_category_set):
2587 * ccl.c (ccl_driver):
2588 * charset.c (Fdefine_charset_internal):
2589 * charset.h (struct charset.hash_index):
2590 * composite.c (get_composition_id, gstring_lookup_cache)
2591 (composition_gstring_put_cache):
2592 * composite.h (struct composition.hash_index):
2593 * dispextern.h (struct image.hash):
2594 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2595 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2596 (hashfn_equal, hashfn_user_defined, make_hash_table)
2597 (maybe_resize_hash_table, hash_lookup, hash_put)
2598 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2599 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2600 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2601 * image.c (make_image, search_image_cache, lookup_image)
2602 (xpm_put_color_table_h):
2603 * lisp.h (struct Lisp_Hash_Table):
2604 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2605 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2606 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2607 * alloc.c (allocate_vectorlike):
2608 Check for overflow in vector size calculations.
2609 * ccl.c (ccl_driver):
2610 Check for overflow when converting EMACS_INT to int.
2611 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2612 need to be updated by these changes.
2613 * fns.c (make_hash_table, maybe_resize_hash_table):
2614 Check for integer overflow with large hash tables.
2615 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2616 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2617 (SXHASH_REDUCE): New macro.
2618 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2619 Use it instead of discarding useful hash info with large hash values.
2620 (sxhash_float): New function.
2621 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2622 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2623 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2624 Rewrite to use FIXNUM_BITS, as this simplifies things.
2625 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2626 Adjust signatures to match updated version of code.
2627 (consing_since_gc): Now EMACS_INT, since a single hash table can
2628 use more than INT_MAX bytes.
2629
2630 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2631
2632 Make it possible to build with GCC-4.6+ -O2 -flto.
2633
2634 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2635
2636 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2637
2638 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2639 Call minibuffer-inactive-mode.
2640
2641 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2642
2643 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2644 Update dependencies.
2645
2646 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2647
2648 * data.c (init_data): Remove code for UTS, this system is not
2649 supported anymore.
2650
2651 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2652
2653 Don't force ./temacs to start in terminal mode.
2654
2655 * frame.c (make_initial_frame): Initialize faces in all cases, not
2656 only when CANNOT_DUMP is defined.
2657 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2658
2659 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2660
2661 * dispnew.c (add_window_display_history): Use const for the string
2662 pointer. Remove declaration, not needed.
2663
2664 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2665
2666 Use 'inline', not 'INLINE'.
2667 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2668 * alloc.c, fontset.c (INLINE): Remove.
2669 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2670 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2671 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2672 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2673 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2674
2675 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2676
2677 Make it possible to run ./temacs.
2678
2679 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2680 syms_of_callproc does the same thing. Remove test for
2681 "initialized", do it in the caller.
2682 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2683
2684 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2685
2686 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2687 (read_minibuf): Use get_minibuffer.
2688 (syms_of_minibuf): Use DEFSYM.
2689 (Qmetadata): New var.
2690 * data.c (Qbuffer): Don't make it static.
2691 (syms_of_data): Use DEFSYM.
2692
2693 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2694
2695 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2696 (CCL_CODE_MIN): New macro.
2697
2698 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2699
2700 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2701
2702 * eval.c (Qdebug): Now static.
2703 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2704 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2705 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2706
2707 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2708
2709 * image.c: Various fixes to ImageMagick code comments.
2710 (Fimagemagick_types): Doc fix.
2711
2712 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2713
2714 Minor fixes prompted by GCC 4.6.0 warnings.
2715
2716 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2717
2718 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2719 (x_clipboard_manager_save_all): Move extern decl to ...
2720 * xterm.h: ... here, so that it can be checked for consistency.
2721
2722 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2723
2724 * xselect.c (x_clipboard_manager_save_frame)
2725 (x_clipboard_manager_save_all): New functions.
2726 (Fx_clipboard_manager_save): Lisp function deleted.
2727
2728 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2729 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2730
2731 * xterm.h: Update prototype.
2732
2733 2011-05-28 William Xu <william.xwl@gmail.com>
2734
2735 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2736 exiting (Bug#8239).
2737
2738 2011-05-28 Jim Meyering <meyering@redhat.com>
2739
2740 Avoid a sign-extension bug in crypto_hash_function.
2741 * fns.c (to_uchar): Define.
2742 (crypto_hash_function): Use it to convert some newly-signed
2743 variables to unsigned, to avoid sign-extension bugs. For example,
2744 without this change, (md5 "truc") would evaluate to
2745 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2746 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2747 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2748
2749 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2750
2751 Integer overflow fixes.
2752
2753 * dbusbind.c: Serial number integer overflow fixes.
2754 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2755 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2756 to hold a serial number that is too large for a fixnum.
2757 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2758 Check for serial numbers out of range. Decode any serial number
2759 that was so large that it became a float. (Bug#8722)
2760
2761 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2762 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2763 Use XFASTINT rather than XUINT when numbers are nonnegative.
2764 (xd_append_arg, Fdbus_method_return_internal):
2765 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2766 arguments, check that Lisp number is nonnegative, rather than
2767 silently wrapping negative numbers around. (Bug#8722)
2768 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2769 (Bug#8722)
2770
2771 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2772
2773 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2774
2775 ccl: add integer overflow checks
2776 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2777 (IN_INT_RANGE): New macros.
2778 (ccl_driver): Use them to check for integer overflow when
2779 decoding a CCL program. Many of the new checks are whether XINT (x)
2780 fits in int; it doesn't always, on 64-bit hosts. The new version
2781 doesn't catch all possible integer overflows, but it's an
2782 improvement. (Bug#8719)
2783
2784 * alloc.c (make_event_array): Use XINT, not XUINT.
2785 There's no need for unsigned here.
2786
2787 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2788 This follows up to the 2011-05-06 change that substituted uintptr_t
2789 for EMACS_INT. This case wasn't caught back then.
2790
2791 Rework Fformat to avoid integer overflow issues.
2792 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2793 now (part of C89). Include <verify.h>.
2794 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2795 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2796 (Fformat): Avoid the prepass trying to compute sizes; it was only
2797 approximate and thus did not catch overflow reliably. Instead, walk
2798 through the format just once, formatting and computing sizes as we go,
2799 checking for integer overflow at every step, and allocating a larger
2800 buffer as needed. Keep track separately whether the format is
2801 multibyte. Keep only the most-recently calculated precision, rather
2802 than them all. Record whether each argument has been converted to
2803 string. Use EMACS_INT, not int, for byte and char and arg counts.
2804 Support field widths and precisions larger than INT_MAX. Avoid
2805 sprintf's undefined behavior with conversion specifications such as %#d
2806 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2807 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2808 formatting out-of-range floating point numbers with int
2809 formats. (Bug#8668)
2810
2811 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2812
2813 * data.c: Avoid integer truncation in expressions involving floats.
2814 * data.c: Include <intprops.h>.
2815 (arith_driver): When there's an integer overflow in an expression
2816 involving floating point, convert the integers to floating point
2817 so that the resulting value does not suffer from catastrophic
2818 integer truncation. For example, on a 64-bit host (* 4
2819 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2820 Do not rely on undefined behavior after integer overflow.
2821
2822 merge count_size_as_multibyte, parse_str_to_multibyte
2823 * character.c, character.h (count_size_as_multibyte):
2824 Rename from parse_str_to_multibyte; all uses changed.
2825 Check for integer overflow.
2826 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2827 since it's now a duplicate of the other. This is more of
2828 a character than a buffer op, so better that it's in character.c.
2829 * fns.c, print.c: Adjust to above changes.
2830
2831 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2832
2833 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2834
2835 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2838 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2839 (x_clipboard_manager_save): Now static.
2840 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2841
2842 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2843 (crypto_hash_function): Now static.
2844 Fix pointer signedness problems. Avoid unnecessary initializations.
2845
2846 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2847
2848 * termhooks.h (Vselection_alist): Make it terminal-local.
2849
2850 * terminal.c (create_terminal): Initialize it.
2851
2852 * xselect.c: Support for clipboard managers.
2853 (Vselection_alist): Move to termhooks.h as terminal-local var.
2854 (LOCAL_SELECTION): New macro.
2855 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2856 (symbol_to_x_atom): Remove gratuitous arg.
2857 (x_handle_selection_request, lisp_data_to_selection_data)
2858 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2859 (x_own_selection, x_get_local_selection, x_convert_selection):
2860 New arg, specifying work frame. Use terminal-local Vselection_alist.
2861 (some_frame_on_display): Delete unused function.
2862 (Fx_own_selection_internal, Fx_get_selection_internal)
2863 (Fx_disown_selection_internal, Fx_selection_owner_p)
2864 (Fx_selection_exists_p): New optional frame arg.
2865 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2866 (x_handle_selection_clear): Don't treat other terminals with the
2867 same keyboard specially. Use the terminal-local Vselection_alist.
2868 (x_clear_frame_selections): Use Frun_hook_with_args.
2869
2870 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2871
2872 * xterm.h: Add support for those atoms.
2873
2874 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2875
2876 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2877 (converted_selections, conversion_fail_tag): New global variables.
2878 (x_selection_request_lisp_error): Free the above.
2879 (x_get_local_selection): Remove unnecessary code.
2880 (x_reply_selection_request): Args changed; handle arbitrary array
2881 of converted selections stored in converted_selections.
2882 Separate the XChangeProperty and SelectionNotify steps.
2883 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2884 (x_convert_selection): New function.
2885 (x_handle_selection_event): Simplify.
2886 (x_get_foreign_selection): Don't ignore incoming requests while
2887 waiting for an answer; this will fail when we implement
2888 SAVE_TARGETS, and seems unnecessary anyway.
2889 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2890 (Vx_sent_selection_functions): Doc fix.
2891
2892 2011-05-26 Leo Liu <sdl.web@gmail.com>
2893
2894 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2895
2896 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2897
2898 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2899
2900 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2901 for fringe update if it has periodic bitmap.
2902 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2903 and fringe_bitmap_periodic_p.
2904
2905 * fringe.c (get_fringe_bitmap_data): New function.
2906 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2907 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2908 row. Mark glyph row for fringe update if periodicity changed.
2909
2910 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2911 for fringe update unless it has periodic bitmap.
2912
2913 2011-05-25 Kenichi Handa <handa@m17n.org>
2914
2915 * xdisp.c (get_next_display_element): Set correct it->face_id for
2916 a static composition.
2917
2918 2011-05-24 Leo Liu <sdl.web@gmail.com>
2919
2920 * deps.mk (fns.o):
2921 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2922
2923 * fns.c (crypto_hash_function, Fsha1): New function.
2924 (Fmd5): Use crypto_hash_function.
2925 (syms_of_fns): Add Ssha1.
2926
2927 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2928
2929 * gnutls.c: Remove unused macros.
2930 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2931 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2932 Remove macros that are defined and never used.
2933 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2934
2935 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2936
2937 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2938 (Fx_get_selection_internal): Minor cleanup.
2939 (Fx_own_selection_internal): Rename arguments for consistency with
2940 select.el.
2941
2942 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2945
2946 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2947
2948 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2949
2950 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2951
2952 * dispnew.c (scrolling_window): Don't exclude the case that the
2953 last enabled row in the desired matrix touches the bottom boundary.
2954
2955 2011-05-21 Glenn Morris <rgm@gnu.org>
2956
2957 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2958 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2959 and add some more files.
2960
2961 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2962
2963 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2964 report_file_error introduced by the change from 2011-05-07.
2965
2966 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 * systime.h (Time): Define only if emacs is defined.
2969 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2970 where the include path doesn't have X11/X.h by default. See
2971 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2972
2973 2011-05-20 Kenichi Handa <handa@m17n.org>
2974
2975 * composite.c (find_automatic_composition): Fix previous change.
2976
2977 2011-05-20 Glenn Morris <rgm@gnu.org>
2978
2979 * lisp.mk: New file, split from Makefile.in.
2980 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2981 (shortlisp): Remove.
2982 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2983
2984 2011-05-19 Glenn Morris <rgm@gnu.org>
2985
2986 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2987 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2988 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2989 (lisp): Set the order to that of loadup.el.
2990 (shortlisp): Make it a copy of $lisp.
2991 (SOME_MACHINE_LISP): Remove.
2992 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2993 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2994
2995 2011-05-18 Kenichi Handa <handa@m17n.org>
2996
2997 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2998 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2999 (find_automatic_composition): Mostly rewrite for efficiency.
3000
3001 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3002
3003 * makefile.w32-in: Update dependencies.
3004
3005 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3006
3007 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3008 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3009
3010 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3011
3012 Fix some integer overflow issues, such as string length overflow.
3013
3014 * insdel.c (count_size_as_multibyte): Check for string overflow.
3015
3016 * character.c (lisp_string_width): Check for string overflow.
3017 Use EMACS_INT, not int, for string indexes and lengths; in
3018 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3019 the resulting string length overflows an EMACS_INT; instead,
3020 report a string overflow if no precision given. When checking for
3021 precision exhaustion, use a check that cannot possibly have
3022 integer overflow. (Bug#8675)
3023 * character.h (lisp_string_width): Adjust to new signature.
3024
3025 * alloc.c (string_overflow): New function.
3026 (Fmake_string): Use it. This doesn't change behavior, but saves
3027 a few bytes and will simplify future changes.
3028 * character.c (string_escape_byte8): Likewise.
3029 * lisp.h (string_overflow): New decl.
3030
3031 Fixups, following up to the user-interface timestamp change.
3032 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3033 for UI timestamps, instead of unsigned long.
3034 * msdos.c (mouse_get_pos): Likewise.
3035 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3036 * w32gui.h (Time): Define by including "systime.h" rather than by
3037 declaring it ourselves. (Bug#8664)
3038
3039 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3040 * image.c (clear_image_cache): Likewise.
3041
3042 * term.c (term_mouse_position): Don't assume time_t wraparound.
3043
3044 Be more systematic about user-interface timestamps.
3045 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3046 and sometimes 'EMACS_UINT', to represent these timestamps.
3047 This change causes it to use 'Time' uniformly, as that's what X uses.
3048 This makes the code easier to follow, and makes it easier to catch
3049 integer overflow bugs such as Bug#8664.
3050 * frame.c (Fmouse_position, Fmouse_pixel_position):
3051 Use Time, not unsigned long, for user-interface timestamps.
3052 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3053 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3054 * keyboard.h (last_event_timestamp): Likewise.
3055 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3056 * menu.h (xmenu_show): Likewise.
3057 * term.c (term_mouse_position): Likewise.
3058 * termhooks.h (struct input_event.timestamp): Likewise.
3059 (struct terminal.mouse_position_hook): Likewise.
3060 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3061 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3062 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3063 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3064 what it was before.
3065 * menu.h, termhooks.h: Include "systime.h", for Time.
3066
3067 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3068 Don't assume that the difference between two unsigned long values
3069 can fit into an integer. At this point, we know button_down_time
3070 <= event->timestamp, so the difference must be nonnegative, so
3071 there's no need to cast the result if double-click-time is
3072 nonnegative, as it should be; check that it's nonnegative, just in
3073 case. This bug is triggered when events are more than 2**31 ms
3074 apart (about 25 days). (Bug#8664)
3075
3076 * xselect.c (last_event_timestamp): Remove duplicate decl.
3077 (x_own_selection): Remove needless cast to unsigned long.
3078
3079 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3080 that always fit in int. Use a sentinel instead of a counter, to
3081 avoid a temp and to allay GCC's concerns about possible int overflow.
3082 * frame.h (struct frame): Use int for menu_bar_items_used
3083 instead of EMACS_INT, since it always fits in int.
3084
3085 * menu.c (grow_menu_items): Check for int overflow.
3086
3087 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3088
3089 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3090 Before, the code was not consistent. These values cannot exceed
3091 2**31 - 1 so there's no need to make them unsigned.
3092 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3093 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3094 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3095 as modifiers.
3096 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3097
3098 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3099 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3100 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3101 presumably because the widths might not match.
3102
3103 * window.c (size_window): Avoid needless test at loop start.
3104
3105 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3106
3107 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3108
3109 2011-05-12 Drew Adams <drew.adams@oracle.com>
3110
3111 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3112
3113 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3114
3115 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3116 `width' to `bar_area_x' and `bar_area_width', respectively.
3117 (x_scroll_run): Take account of fringe background extension.
3118
3119 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3120 Rename local vars `left' and `width' to `bar_area_x' and
3121 `bar_area_width', respectively.
3122 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3123 background extension.
3124
3125 2011-05-10 Jim Meyering <meyering@redhat.com>
3126
3127 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3128
3129 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3130
3131 * image.c (Finit_image_library): Return t for built-in image types,
3132 like pbm and xbm. (Bug#8640)
3133
3134 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3135
3136 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3137
3138 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3139
3140 * w32console.c (Fset_screen_color): Doc fix.
3141 (Fget_screen_color): New function.
3142 (syms_of_ntterm): Defsubr it.
3143
3144 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3145 unlink the temporary file if Fcall_process didn't create it in the
3146 first place.
3147 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3148 child process will be redirected to a file specified with `:file'.
3149 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3150 cue to call_process_cleanup not to close that handle.
3151
3152 2011-05-07 Ben Key <bkey76@gmail.com>
3153
3154 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3155 one of two shell specific rules, either bootstrap-temacs-CMD or
3156 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3157 to the previous implementation of the bootstrap-temacs rule.
3158 The bootstrap-temacs-CMD rule is similar to the previous
3159 implementation of the bootstrap-temacs rule except that it
3160 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3161 variable.
3162
3163 These changes, along with some changes to nt/configure.bat,
3164 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3165 earlier fix to add support for --cflags and --ldflags options
3166 that include quotes so that it works whether make uses cmd or
3167 sh as the shell.
3168
3169 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3170
3171 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3172 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3173 is a constant.
3174 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3175 a string. Handle both cases.
3176 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3177 (Fdbus_register_method): Use Qinvalid_function.
3178
3179 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3180
3181 * makefile.w32-in: Update dependencies.
3182 (LISP_H): Add inttypes.h and stdin.h.
3183 (PROCESS_H): Add unistd.h.
3184
3185 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3186
3187 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3188 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3189
3190 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3191
3192 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3193
3194 * term.c (vfatal): Remove stray call to va_end.
3195 It's not needed and the C Standard doesn't allow it here anyway.
3196
3197 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3198 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3199
3200 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3201 bytes.
3202
3203 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3204
3205 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3206
3207 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3208
3209 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3210
3211 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3212
3213 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3214 * charset.c (Fdefine_charset_internal): Don't initialize
3215 charset.code_space[15]. The value was garbage, on hosts with
3216 32-bit int (Bug#8600).
3217
3218 * lread.c (read_integer): Be more consistent with string-to-number.
3219 Use string_to_number to do the actual conversion; this avoids
3220 rounding errors and fixes some other screwups. Without this fix,
3221 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3222 (digit_to_number): Move earlier, for benefit of read_integer.
3223 Return -1 if the digit is out of range for the base, -2 if it is
3224 not a digit in any supported base. (Bug#8602)
3225
3226 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3227
3228 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3229 to match comment at start of function. This also removes a
3230 GCC warning about overflow in a 32+64-bit port.
3231
3232 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3233
3234 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3235 Reported by Stefan Monnier in
3236 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3237 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3238 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3239
3240 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3241 (EMACS_UINTPTR): Likewise, with uintptr_t.
3242
3243 * lisp.h: Prefer 64-bit EMACS_INT if available.
3244 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3245 on 32-bit hosts that have 64-bit int, so that they can access
3246 large files.
3247 However, temporarily disable this change unless the temporary
3248 symbol WIDE_EMACS_INT is defined.
3249
3250 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3251
3252 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3253 This removes an assumption that EMACS_INT and long are the same
3254 width as pointers. The assumption is true for Emacs porting targets
3255 now, but we want to make other targets possible.
3256 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3257 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3258 In the rest of the code, change types of integers that hold casted
3259 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3260 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3261 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3262 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3263 No need to cast type when ORing.
3264 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3265 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3266 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3267 assume EMACS_INT is the same width as char *.
3268 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3269 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3270 Remove no-longer-needed casts.
3271 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3272 (xg_tool_bar_help_callback, xg_make_tool_item):
3273 Use EMACS_INTPTR to hold an integer
3274 that will be cast to void *; this can avoid a GCC warning
3275 if EMACS_INT is not the same width as void *.
3276 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3277 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3278 (current_message_1, set_message_1):
3279 Use a local to convert to proper width without a cast.
3280 * xmenu.c (dialog_selection_callback): Likewise.
3281
3282 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3283 Also, don't assume VALBITS / RAND_BITS is less than 5,
3284 and don't rely on undefined behavior when shifting a 1 left into
3285 the sign bit.
3286 * lisp.h (get_random): Change signature to match.
3287
3288 * lread.c (hash_string): Use size_t, not int, for hash computation.
3289 Normally we prefer signed values; but hashing is special, because
3290 it's better to use unsigned division on hash table sizes so that
3291 the remainder is nonnegative. Also, size_t is the natural width
3292 for hashing into memory. The previous code used 'int', which doesn't
3293 retain enough info to hash well into very large tables.
3294 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3295
3296 * dbusbind.c: Don't possibly lose pointer info when converting.
3297 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3298 Use XPNTR rather than XHASH, so that the high-order bits of
3299 the pointer aren't lost when converting through void *.
3300
3301 * eval.c (Fautoload): Don't double-shift a pointer.
3302
3303 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3304
3305 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3306
3307 * gnutls.c (DEF_GNUTLS_FN):
3308 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3309
3310 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3311
3312 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3313 marker. (Bug#8610)
3314
3315 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3316
3317 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3318 New version that can reserve upto 2GB of heap space.
3319
3320 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3321
3322 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3323
3324 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3325
3326 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3327 `gnutls_certificate_set_x509_key_file'.
3328
3329 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3330
3331 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3332 Update dependencies.
3333
3334 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3335
3336 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3337 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3338 Remove unused parameter `fildes'.
3339 * process.c (read_process_output, send_process): Don't pass it.
3340
3341 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3342
3343 Fix previous change: the library cache is defined in w32.c.
3344 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3345 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3346
3347 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3348
3349 Implement dynamic loading of GnuTLS on Windows.
3350
3351 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3352 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3353 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3354 Declare.
3355
3356 * gnutls.c (Qgnutls_dll): Define.
3357 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3358 (gnutls_*): Declare function pointers.
3359 (init_gnutls_functions): New function to initialize function pointers.
3360 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3361 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3362 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3363 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3364 (emacs_gnutls_write, emacs_gnutls_read)
3365 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3366 (Fgnutls_available_p): New function.
3367 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3368 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3369 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3370
3371 * image.c: Include w32.h.
3372 (Vimage_type_cache): Delete.
3373 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3374 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3375 (w32_delayed_load): Move to w32.c.
3376
3377 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3378
3379 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3380 (w32_delayed_load): Move from image.c. When loading a library, record
3381 its filename in the :loaded-from property of the library id.
3382 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3383 Initialize and staticpro them.
3384 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3385
3386 * process.c: Include lisp.h before w32.h, not after.
3387 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3388 instead of gnutls_record_check_pending.
3389
3390 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3391
3392 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3393
3394 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3395 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3396 as passed in.
3397
3398 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3399
3400 * xterm.c (x_set_frame_alpha): Do not set property on anything
3401 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3402
3403 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3404
3405 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3406
3407 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3408
3409 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3410 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3411 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3412 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3413 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3414 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3415 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3416 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3417 (Qgnutls_bootprop_callbacks_verify): Make static.
3418
3419 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3420
3421 * callproc.c: Indentation fixup.
3422
3423 * sysdep.c (wait_for_termination_1): Make static.
3424 (wait_for_termination, interruptible_wait_for_termination):
3425 Move after wait_for_termination_1.
3426
3427 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3428
3429 * sysdep.c (interruptible_wait_for_termination): New function
3430 which is like wait_for_termination, but allows keyboard
3431 interruptions.
3432
3433 * callproc.c (Fcall_process): Add (:file "file") as an option for
3434 the STDOUT buffer.
3435 (Fcall_process_region): Ditto.
3436
3437 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3438
3439 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3440 rather than `XVECTOR (FOO)->size'.
3441
3442 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3443 inttypes.h, as a gnulib replacement is used if it not available in
3444 system headers.
3445
3446 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3447
3448 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3449 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3450 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3451
3452 * coding.c (coding_alloc_by_realloc): Error out if destination
3453 will grow beyond MOST_POSITIVE_FIXNUM.
3454 (decode_coding_emacs_mule): Abort if there isn't enough place in
3455 charbuf for the composition carryover bytes. Reserve an extra
3456 space for up to 2 characters produced in a loop.
3457 (decode_coding_iso_2022): Abort if there isn't enough place in
3458 charbuf for the composition carryover bytes.
3459
3460 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3461
3462 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3463 aborting when %lld or %lll format is passed.
3464 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3465 %llo or %llx format is passed. (Bug#8545)
3466
3467 * window.c (window_scroll_line_based): Use a marker instead of
3468 simple variables to record original value of point. (Bug#7952)
3469
3470 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3471 produced by %s or %c overflows available buffer space. (Bug#8545)
3472
3473 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3474
3475 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3476 (SIZE_MAX): Move defn after all includes, as they might #define it.
3477
3478 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3479
3480 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3481
3482 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3483
3484 * keyboard.c (Qdelayed_warnings_hook): Define.
3485 (command_loop_1): Run `delayed-warnings-hook'
3486 if Vdelayed_warnings_list is non-nil.
3487 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3488 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3489
3490 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3491
3492 * doprnt.c (doprnt): Don't return value smaller than the buffer
3493 size if the message was truncated. (Bug#8545).
3494
3495 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3496
3497 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3498 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3499
3500 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3501
3502 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3503
3504 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * makefile.w32-in: Update dependencies.
3507
3508 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3509
3510 Improve `doprnt' and its usage. (Bug#8545)
3511 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3512 `format_end'. Remove support for %l as a conversion specifier.
3513 Don't use xrealloc. Improve diagnostics when the %l size modifier
3514 is used. Update the commentary.
3515
3516 * eval.c (verror): Simplify calculation of size_t.
3517
3518 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3519 messages.
3520
3521 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3522
3523 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3524 change.
3525
3526 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3527
3528 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3529 This makes this file independent of the recent pseudovector change.
3530
3531 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3532
3533 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3534
3535 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3536 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3537 Remove unused local.
3538 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3539
3540 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3541 GCC 4.6.0 optimizes based on type-based alias analysis.
3542 For example, if b is of type struct buffer * and v of type struct
3543 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3544 != &v->size, and therefore "v->size = 1; b->size = 2; return
3545 v->size;" must therefore return 1. This assumption is incorrect
3546 for Emacs, since it type-puns struct Lisp_Vector * with many other
3547 types. To fix this problem, this patch adds a new type struct
3548 vectorlike_header that documents the constraints on layout of vectors
3549 and pseudovectors, and helps optimizing compilers not get fooled
3550 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3551 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3552 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3553 the size member.
3554 (XSETPVECTYPE): Rewrite in terms of new macro.
3555 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3556 This is a bit clearer, and further avoids the possibility of
3557 undesirable aliasing.
3558 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3559 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3560 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3561 since Lisp_Subr is a special case (no "next" field).
3562 (ASIZE): Now uses header.size rather than size.
3563 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3564 to avoid the hassle of writing XVECTOR (foo)->header.size.
3565 (struct vectorlike_header): New type.
3566 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3567 object, to help avoid aliasing.
3568 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3569 (SUBRP): Likewise, since Lisp_Subr is a special case.
3570 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3571 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3572 (struct Lisp_Hash_Table): Combine first two members into a single
3573 struct vectorlike_header member. All uses of "size" and "next" members
3574 changed to be "header.size" and "header.next".
3575 * buffer.h (struct buffer): Likewise.
3576 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3577 * frame.h (struct frame): Likewise.
3578 * process.h (struct Lisp_Process): Likewise.
3579 * termhooks.h (struct terminal): Likewise.
3580 * window.c (struct save_window_data, struct saved_window): Likewise.
3581 * window.h (struct window): Likewise.
3582 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3583 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3584 * buffer.c (init_buffer_once): Likewise.
3585 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3586 special case.
3587 * process.c (Fformat_network_address): Use local var for size,
3588 for brevity.
3589
3590 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3591
3592 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3593 * data.c (atof): Remove decl; no longer used or needed.
3594 (digit_to_number): Move to lread.c.
3595 (Fstring_to_number): Use new string_to_number function, to be
3596 consistent with how the Lisp reader treats infinities and NaNs.
3597 Do not assume that floating-point numbers represent EMACS_INT
3598 without losing information; this is not true on most 64-bit hosts.
3599 Avoid double-rounding errors, by insisting on integers when
3600 parsing non-base-10 numbers, as the documentation specifies.
3601 * lisp.h (string_to_number): New decl, replacing ...
3602 (isfloat_string): Remove.
3603 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3604 (read1): Do not accept +. and -. as integers; this
3605 appears to have been a coding error. Similarly, do not accept
3606 strings like +-1e0 as floating point numbers. Do not report
3607 overflow for integer overflows unless the base is not 10 which
3608 means we have no simple and reliable way to continue.
3609 Break out the floating-point parsing into a new
3610 function string_to_number, so that Fstring_to_number parses
3611 floating point numbers consistently with the Lisp reader.
3612 (digit_to_number): Move here from data.c. Make it static inline.
3613 (E_CHAR, EXP_INT): Remove, replacing with ...
3614 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3615 (string_to_number): New function, replacing isfloat_string.
3616 This function checks for valid syntax and produces the resulting
3617 Lisp float number too. Rework it so that string-to-number
3618 no longer mishandles examples like "1.0e+". Use strtoumax,
3619 so that overflow for non-base-10 numbers is reported only when
3620 there's no portable and simple way to convert to floating point.
3621
3622 * textprop.c (set_text_properties_1): Rewrite for clarity,
3623 and to avoid GCC warning about integer overflow.
3624
3625 * intervals.h (struct interval): Use EMACS_INT for members
3626 where EMACS_UINT might cause problems. See
3627 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3628 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3629 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3630 All uses changed.
3631 (offset_intervals): Tell GCC not to worry about length overflow
3632 when negating a negative length.
3633
3634 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3635 (overrun_check_free): Likewise.
3636
3637 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3638 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3639 word size.
3640
3641 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3642 (gnutls_make_error): Rename local to avoid shadowing.
3643 (gnutls_emacs_global_deinit): ifdef out; not used.
3644 (Fgnutls_boot): Use const for pointer to readonly storage.
3645 Comment out unused local. Fix pointer signedness problems.
3646
3647 * lread.c (openp): Don't stuff size_t into an 'int'.
3648 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3649 about possible signed overflow.
3650
3651 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3652 (GDK_KEY_g): Don't define if already defined.
3653 (xg_prepare_tooltip): Avoid pointer signedness problem.
3654 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3655
3656 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3657 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3658
3659 * xfns.c (Fx_window_property): Simplify a bit,
3660 to make a bit faster and to avoid GCC 4.6.0 warning.
3661 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3662
3663 * fns.c (internal_equal): Don't assume size_t fits in int.
3664
3665 * alloc.c (compact_small_strings): Tighten assertion a little.
3666
3667 Replace pEd with more-general pI, and fix some printf arg casts.
3668 * lisp.h (pI): New macro, generalizing old pEd macro to other
3669 conversion specifiers. For example, use "...%"pI"d..." rather
3670 than "...%"pEd"...".
3671 (pEd): Remove. All uses replaced with similar uses of pI.
3672 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3673 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3674 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3675 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3676 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3677 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3678 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3679 64-bit hosts.
3680 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3681 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3682 * print.c (safe_debug_print, print_object): Likewise.
3683 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3684 to int.
3685 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3686 avoiding the 0 flag, which is not portable.
3687 * process.c (Fmake_network_process): Use pI to avoid cast.
3688 * region-cache.c (pp_cache): Likewise.
3689 * xdisp.c (decode_mode_spec): Likewise.
3690 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3691 behavior on 64-bit hosts with printf arg.
3692 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3693 (x_stop_queuing_selection_requests): Likewise.
3694 (x_get_window_property): Don't truncate byte count to an 'int'
3695 when tracing.
3696
3697 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3698 here, since it parses constructs like leading '-' and spaces,
3699 which are not wanted; and it overflows with large numbers.
3700 Instead, simply match F[0-9]+, which is what is wanted anyway.
3701
3702 * alloc.c: Remove unportable assumptions about struct layout.
3703 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3704 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3705 (allocate_vectorlike, make_pure_vector): Use the new macros,
3706 plus offsetof, to remove unportable assumptions about struct layout.
3707 These assumptions hold on all porting targets that I know of, but
3708 they are not guaranteed, they're easy to remove, and removing them
3709 makes further changes easier.
3710
3711 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3712 This doesn't fix a bug but makes the code clearer.
3713 (string_overrun_cookie): Now const. Use initializers that
3714 don't formally overflow signed char, to avoid warnings.
3715 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3716 can cause Emacs to crash when string overrun checking is enabled.
3717 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3718 multiple of sizeof (EMACS_INT); it need not be, if
3719 alignof(EMACS_INT) < sizeof (EMACS_INT).
3720 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3721
3722 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3723
3724 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3725
3726 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3727
3728 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3729 supposed to be handshaking. (Bug#8556)
3730 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3731
3732 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3733
3734 * lisp.h (Qdebug): List symbol.
3735 * eval.c (Qdebug): Restore global linkage.
3736 * keyboard.c (debug-on-event): New variable.
3737 (handle_user_signal): Break into debugger when debug-on-event
3738 matches the current signal symbol.
3739
3740 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3741
3742 * alloc.c (check_sblock, check_string_bytes)
3743 (check_string_free_list): Convert to standard C.
3744
3745 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3746
3747 * w32.c (emacs_gnutls_push): Fix typo.
3748
3749 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3750
3751 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3752 "cast to pointer from integer of different size".
3753
3754 Improve doprnt and its use in verror. (Bug#8545)
3755 * doprnt.c (doprnt): Document the set of format control sequences
3756 supported by the function. Use SAFE_ALLOCA instead of always
3757 using `alloca'.
3758
3759 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3760 is one byte too soon. Don't use xrealloc; instead xfree and
3761 xmalloc anew.
3762
3763 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3764
3765 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3766 callbacks stage.
3767
3768 * gnutls.c: Renamed global_initialized to
3769 gnutls_global_initialized. Added internals for the
3770 :verify-hostname-error, :verify-error, and :verify-flags
3771 parameters of `gnutls-boot' and documented those parameters in the
3772 docstring. Start callback support.
3773 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3774 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3775 on error. Return error code.
3776 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3777 (emacs_gnutls_read): Likewise.
3778 (Fgnutls_boot): Return handshake error code.
3779 (emacs_gnutls_handle_error): New function.
3780 (wsaerror_to_errno): Likewise.
3781
3782 * w32.h (emacs_gnutls_pull): Add prototype.
3783 (emacs_gnutls_push): Likewise.
3784
3785 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3786 (emacs_gnutls_push): Likewise.
3787
3788 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3789
3790 * process.c (wait_reading_process_output): Check if GnuTLS
3791 buffered some data internally if no FDs are set for TLS
3792 connections.
3793
3794 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3795 (LIBS): Link to USER_LIBS.
3796 ($(BLD)/gnutls.$(0)): New target.
3797
3798 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3799
3800 * xdisp.c (handle_single_display_spec): Rename the
3801 display_replaced_before_p argument into display_replaced_p, to
3802 make it consistent with the commentary. Fix typos in the
3803 commentary.
3804
3805 * textprop.c (syms_of_textprop): Remove dead code.
3806 (copy_text_properties): Delete obsolete commentary about an
3807 interface that was deleted long ago. Fix typos in the description
3808 of arguments.
3809
3810 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3811 to changes in oldXMenu/XMenu.h from 2011-04-16.
3812 <menu_help_message, prev_menu_help_message>: Constify.
3813 (IT_menu_make_room): menu->help_text is now `const char **';
3814 adjust.
3815
3816 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3817 to changes in oldXMenu/XMenu.h from 2011-04-16.
3818 (struct XMenu): Declare `help_text' `const char **'.
3819
3820 * xfaces.c <Qunspecified>: Make extern again.
3821
3822 * syntax.c: Include sys/types.h before including regex.h, as
3823 required by Posix.
3824
3825 * doc.c (get_doc_string): Improve the format passed to `error'.
3826
3827 * doprnt.c (doprnt): Improve commentary.
3828
3829 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3830
3831 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3832 them with etags.
3833
3834 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3835 changes in globals.h immediately force recompilation.
3836 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3837 $(CURDIR)/s/ms-w32.h.
3838 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3839
3840 * character.c (Fchar_direction): Function deleted.
3841 (syms_of_character): Don't defsubr it.
3842 <char-direction-table>: Deleted.
3843
3844 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3845
3846 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3847 * doprnt.c: Include limits.h.
3848 (SIZE_MAX): New macro.
3849 (doprnt): Return a size_t value. 2nd arg is now size_t.
3850 Many local variables are now size_t instead of int or unsigned.
3851 Improve overflow protection. Support `l' modifier for integer
3852 conversions. Support %l conversion. Don't assume an EMACS_INT
3853 argument for integer conversions and for %c.
3854
3855 * lisp.h (doprnt): Restore prototype.
3856
3857 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3858 $(SRC)/character.h.
3859
3860 * Makefile.in (base_obj): Add back doprnt.o.
3861
3862 * deps.mk (doprnt.o): Add back prerequisites.
3863 (callint.o): Depend on character.h.
3864
3865 * eval.c (internal_lisp_condition_case): Include the handler
3866 representation in the error message.
3867 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3868 when breaking from the loop.
3869
3870 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3871
3872 * callint.c (Fcall_interactively): When displaying error message
3873 about invalid control letter, pass the character's codepoint, not
3874 a pointer to its multibyte form. Improve display of the character
3875 in octal and display also its hex code.
3876
3877 * character.c (char_string): Use %x to display the (unsigned)
3878 codepoint of an invalid character, to avoid displaying a bogus
3879 negative value.
3880
3881 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3882 `error', not SYMBOL_NAME itself.
3883
3884 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3885 character arguments to `error'.
3886
3887 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3888 to `error' in error message about FINAL_CHAR argument. Make sure
3889 FINAL_CHAR is a character, and use %c when it is passed as
3890 argument to `error'.
3891
3892 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3893
3894 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3895
3896 * w32.c: Include <time.h>.
3897 (sys_localtime): New function.
3898
3899 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3900
3901 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3902
3903 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3904
3905 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3906
3907 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3908 zombies (Bug#8467).
3909
3910 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3911
3912 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3913 gl_state.e_property when gl_state.object is Qt.
3914
3915 * insdel.c (make_gap_larger): Remove limitation of buffer size
3916 to <= INT_MAX.
3917
3918 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3919
3920 * xdisp.c (lookup_glyphless_char_display)
3921 (produce_glyphless_glyph): Handle cons cell entry in
3922 glyphless-char-display.
3923 (Vglyphless_char_display): Document it.
3924
3925 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3926 glyphless-char-display.
3927
3928 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3929
3930 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3931
3932 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3933
3934 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3935 definition for no-X builds.
3936
3937 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3938
3939 Static checks with GCC 4.6.0 and non-default toolkits.
3940
3941 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3942
3943 * process.c (keyboard_bit_set): Define only if SIGIO.
3944 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3945 (send_process): Repair possible setjmp clobbering.
3946
3947 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3948
3949 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3950
3951 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3952
3953 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3954 Define only if needed.
3955
3956 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3957 by pacifying GCC about it. Maybe it's time to retire it?
3958 * xfaces.c (USG, __TIMEVAL__): Likewise.
3959
3960 * dispextern.h (struct redisplay_interface): Rename param
3961 to avoid shadowing.
3962 * termhooks.h (struct terminal): Likewise.
3963 * xterm.c (xembed_send_message): Likewise.
3964
3965 * insdel.c (make_gap_smaller): Define only if
3966 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3967
3968 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3969 it.
3970
3971 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3972 so that we aren't warned about unused symbols.
3973
3974 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3975
3976 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3977
3978 * xfns.c (x_real_positions): Mark locals as initialized.
3979
3980 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3981
3982 * xterm.c: Fix problems found by static analysis with other toolkits.
3983 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3984 (x_dispatch_event): Declare static if USE_GTK, and
3985 define if USE_GTK || USE_X_TOOLKIT.
3986 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3987 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3988 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3989 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3990
3991 * xmenu.c (menu_help_callback): Pointer type fixes.
3992 Use const pointers when pointing at readonly data. Avoid pointer
3993 signedness clashes.
3994 (FALSE): Remove unused macro.
3995 (update_frame_menubar): Remove unused decl.
3996
3997 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3998
3999 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4000 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4001 (single_menu_item): Rename local to avoid shadowing.
4002
4003 * keyboard.c (make_lispy_event): Remove unused local var.
4004
4005 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4006 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4007
4008 * bitmaps: Change bitmaps from unsigned char back to the X11
4009 compatible char. Avoid the old compiler warnings about
4010 out-of-range initializers by using, for example, '\xab' rather
4011 than 0xab.
4012
4013 * xgselect.c (xgselect_initialize): Check vs interface
4014 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4015
4016 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4017
4018 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4019 to read-only memory.
4020
4021 * fns.c (vector): Remove; this old hack is no longer needed.
4022
4023 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4024 Remove unused var.
4025 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4026
4027 * xrdb.c (x_load_resources): Omit unused local.
4028
4029 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4030 (x_window): Rename locals to avoid shadowing.
4031 (USG): Use the kludged USG macro, to pacify gcc.
4032
4033 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4034 (x_term_init): Remove local to avoid shadowing.
4035
4036 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4037
4038 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4039 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4040
4041 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4042
4043 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4044
4045 Fix regex.c, syntax.c and friends for buffers > 2GB.
4046 * syntax.h (struct gl_state_s): Declare character position members
4047 EMACS_INT.
4048
4049 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4050
4051 * textprop.c (verify_interval_modification, interval_of):
4052 Declare arguments EMACS_INT.
4053
4054 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4055 EMACS_INT.
4056
4057 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4058
4059 * indent.c (Fvertical_motion): Local variable it_start is now
4060 EMACS_INT.
4061
4062 * regex.c (re_match, re_match_2, re_match_2_internal)
4063 (bcmp_translate, regcomp, regexec, print_double_string)
4064 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4065 (re_compile_pattern, re_exec): Declare arguments and local
4066 variables `size_t' and `ssize_t' and return values `regoff_t', as
4067 appropriate.
4068 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4069 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4070 <compile_stack_type>: `size' and `avail' are now `size_t'.
4071
4072 * regex.h <regoff_t>: Use ssize_t, not int.
4073 (re_search, re_search_2, re_match, re_match_2): Arguments that
4074 specify buffer/string position and length are now ssize_t and
4075 size_t. Return type is regoff_t.
4076
4077 2011-04-16 Ben Key <bkey76@gmail.com>
4078
4079 * nsfont.m: Fixed bugs in ns_get_family and
4080 ns_descriptor_to_entity that were caused by using free to
4081 deallocate memory blocks that were allocated by xmalloc (via
4082 xstrdup). This caused Emacs to crash when compiled with
4083 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4084 --enable-checking=xmallocoverrun). xfree is now used to
4085 deallocate these memory blocks.
4086
4087 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4090
4091 emacs_write: Accept and return EMACS_INT for sizes.
4092 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4093 et seq.
4094 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4095 Accept and return EMACS_INT.
4096 (emacs_gnutls_write): Return the number of bytes written on
4097 partial writes.
4098 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4099 (emacs_read, emacs_write): Remove check for negative size, as the
4100 Emacs source code has been audited now.
4101 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4102 (emacs_read, emacs_write): Use it.
4103 * process.c (send_process): Adjust to the new signatures of
4104 emacs_write and emacs_gnutls_write. Do not attempt to store
4105 a byte offset into an 'int'; it might overflow.
4106 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4107
4108 * sound.c: Don't assume sizes fit in 'int'.
4109 (struct sound_device.period_size, alsa_period_size):
4110 Return EMACS_INT, not int.
4111 (struct sound_device.write, vox_write, alsa_write):
4112 Accept EMACS_INT, not int.
4113 (wav_play, au_play): Use EMACS_INT to store sizes and to
4114 record read return values.
4115
4116 2011-04-15 Ben Key <bkey76@gmail.com>
4117
4118 * keyboard.c (Qundefined): Don't declare static since it is used
4119 in nsfns.m.
4120 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4121 static since they are used in nsfont.m.
4122
4123 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4124
4125 * process.c (Qprocessp): Don't declare static.
4126 * lisp.h (Qprocessp): Declare again.
4127
4128 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4129
4130 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4131
4132 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4133
4134 Improve C-level modularity by making more things 'static'.
4135
4136 Don't publish debugger-only interfaces to other modules.
4137 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4138 (verify_bytepos, count_markers): Move decls to the only modules
4139 that need them.
4140 * region-cache.h (pp_cache): Likewise.
4141 * window.h (check_all_windows): Likewise.
4142 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4143
4144 * sysdep.c (croak): Now static, if
4145 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4146 * syssignal.h (croak): Declare only if not static.
4147
4148 * alloc.c (refill_memory_reserve): Now static if
4149 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4150 * lisp.h (refill_memory_reserve): Declare only if not static.
4151
4152 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4153 Define only if USE_LUCID.
4154
4155 * xrdb.c (x_customization_string, x_rm_string): Now static.
4156
4157 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4158 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4159
4160 * xdisp.c (draw_row_with_mouse_face): Now static.
4161 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4162
4163 * window.h (check_all_windows): Mark externally visible.
4164
4165 * window.c (window_deletion_count): Now static.
4166
4167 * undo.c: Make symbols static if they're not exported.
4168 (last_undo_buffer, last_boundary_position, pending_boundary):
4169 Now static.
4170
4171 * textprop.c (interval_insert_behind_hooks): Now static.
4172 (interval_insert_in_front_hooks): Likewise.
4173
4174 * term.c: Make symbols static if they're not exported.
4175 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4176 (max_frame_lines, tty_set_terminal_modes):
4177 (tty_reset_terminal_modes, tty_turn_off_highlight):
4178 (get_tty_terminal): Now static.
4179 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4180 * termhooks.h (term_mouse_moveto): Do not declare if
4181 HAVE_WINDOW_SYSTEM.
4182 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4183 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4184
4185 * sysdep.c: Make symbols static if they're not exported.
4186 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4187 Now static.
4188 (sigprocmask_set, full_mask): Remove; unused.
4189 (wait_debugging): Mark as visible.
4190 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4191 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4192
4193 * syntax.c (syntax_temp): Define only if !__GNUC__.
4194
4195 * sound.c (current_sound_device, current_sound): Now static.
4196
4197 * search.c (searchbufs, searchbuf_head): Now static.
4198
4199 * scroll.c (scroll_cost): Remove; unused.
4200 * dispextern.h (scroll_cost): Remove decl.
4201
4202 * region-cache.h (pp_cache): Mark as externally visible.
4203
4204 * process.c: Make symbols static if they're not exported.
4205 (process_tick, update_tick, create_process, chan_process):
4206 (Vprocess_alist, proc_buffered_char, datagram_access):
4207 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4208 (deactivate_process): Mark defn as static, as well as decl.
4209 * lisp.h (create_process): Remove decl.
4210 * process.h (chan_process, Vprocess_alist): Remove decls.
4211
4212 * print.c: Make symbols static if they're not exported.
4213 (print_depth, new_backquote_output, being_printed, print_buffer):
4214 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4215 (print_interval, print_number_index, initial_stderr_stream):
4216 Now static.
4217 * lisp.h (Fprinc): Remove decl.
4218 (debug_output_compilation_hack): Mark as externally visible.
4219
4220 * sysdep.c (croak): Move decl from here to syssignal.h.
4221 * syssignal.h (croak): Put it here, so the API can be checked when
4222 'croak' is called from dissociate_if_controlling_tty.
4223
4224 * minibuf.c: Make symbols static if they're not exported.
4225 (minibuf_save_list, choose_minibuf_frame): Now static.
4226 * lisp.h (choose_minibuf_frame): Remove decl.
4227
4228 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4229
4230 * lread.c: Make symbols static if they're not exported.
4231 (read_objects, initial_obarray, oblookup_last_bucket_number):
4232 Now static.
4233 (make_symbol): Remove; unused.
4234 * lisp.h (initial_obarray, make_symbol): Remove decls.
4235
4236 * keyboard.c: Make symbols static if they're not exported.
4237 (single_kboard, recent_keys_index, total_keys, recent_keys):
4238 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4239 (this_single_command_key_start, echoing, last_auto_save):
4240 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4241 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4242 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4243 (Vlispy_mouse_stem, double_click_count):
4244 Now static.
4245 (force_auto_save_soon): Define only if SIGDANGER.
4246 (ignore_mouse_drag_p): Now static if
4247 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4248 (print_help): Remove; unused.
4249 (stop_character, last_timer_event): Mark as externally visible.
4250 * keyboard.h (ignore_mouse_drag_p): Declare only if
4251 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4252 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4253 * lisp.h (echoing): Remove decl.
4254 (force_auto_save_soon): Declare only if SIGDANGER.
4255 * xdisp.c (redisplay_window): Simplify code, to make it more
4256 obvious that ignore_mouse_drag_p is not accessed if !defined
4257 USE_GTK && !defined HAVE_NS.
4258
4259 * intervals.c: Make symbols static if they're not exported.
4260 (merge_properties_sticky, merge_interval_right, delete_interval):
4261 Now static.
4262 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4263
4264 * insdel.c: Make symbols static if they're not exported.
4265 However, leave prepare_to_modify_buffer alone. It's never
4266 called from outside this function, but that appears to be a bug.
4267 (combine_after_change_list, combine_after_change_buffer):
4268 (adjust_after_replace, signal_before_change): Now static.
4269 (adjust_after_replace_noundo): Remove; unused.
4270 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4271 (signal_before_change): Remove decls.
4272
4273 * indent.c (val_compute_motion, val_vmotion): Now static.
4274
4275 * image.c: Make symbols static if they're not exported.
4276 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4277 if USE_GTK.
4278 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4279 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4280
4281 * fringe.c (standard_bitmaps): Now static.
4282 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4283
4284 * frame.c: Make symbols static if they're not exported.
4285 (x_report_frame_params, make_terminal_frame): Now static.
4286 (get_frame_param): Now static, unless HAVE_NS.
4287 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4288 (x_get_resource_string): Remove; not used.
4289 * frame.h (make_terminal_frame, x_report_frame_params):
4290 (x_get_resource_string); Remove decls.
4291 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4292 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4293
4294 * font.c, fontset.c: Make symbols static if they're not exported.
4295 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4296 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4297 * font.c (font_close_object): Now static.
4298 * font.h (font_close_object): Remove.
4299 * fontset.c (FONTSET_OBJLIST): Remove.
4300 (free_realized_fontset) #if-0 the body, which does nothing.
4301 (face_suitable_for_char_p): #if-0, as it's never called.
4302 * fontset.h (face_suitable_for_char_p): Remove decl.
4303 * xfaces.c (face_at_string_position):
4304 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4305 since 0 is always ASCII.
4306
4307 * fns.c (weak_hash_tables): Now static.
4308
4309 * fileio.c: Make symbols static if they're not exported.
4310 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4311 (Vwrite_region_annotation_buffers): Now static.
4312
4313 * eval.c: Make symbols static if they're not exported.
4314 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4315 * lisp.h (backtrace_list): Remove decl.
4316
4317 * emacs.c: Make symbols static if they're not exported.
4318 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4319 (fatal_error_code, fatal_error_signal_hook, standard_args):
4320 Now static.
4321 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4322 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4323 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4324 * lisp.h (fatal_error_signal_hook): Remove decl.
4325 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4326
4327 * editfns.c: Move a (normally-unused) function to its only use.
4328 * editfns.c, lisp.h (get_operating_system_release): Remove.
4329 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4330 worth the hassle of breaking this out.
4331
4332 * xterm.c: Make symbols static if they're not exported.
4333 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4334 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4335 (x_destroy_window, x_delete_display):
4336 Now static.
4337 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4338 (x_mouse_leave): Remove; unused.
4339 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4340 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4341 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4342 Remove decls.
4343 (x_mouse_leave): Declare only if WINDOWSNT.
4344 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4345 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4346 USE_X_TOOLKIT.
4347
4348 * ftxfont.c: Make symbols static if they're not exported.
4349 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4350 HAVE_FREETYPE.
4351 * font.h (ftxfont_driver): Likewise.
4352
4353 * xfns.c: Make symbols static if they're not exported.
4354 (x_last_font_name, x_display_info_for_name):
4355 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4356 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4357 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4358 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4359 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4360 (last_show_tip_args): Now static.
4361 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4362 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4363 (x_screen_planes): Remove; unused.
4364 * dispextern.h (x_screen_planes): Remove decl.
4365
4366 * dispnew.c: Make symbols static if they're not exported.
4367 * dispextern.h (redraw_garbaged_frames, scrolling):
4368 (increment_row_positions): Remove.
4369 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4370 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4371 Now static.
4372 (redraw_garbaged_frames): Remove; unused.
4373
4374 * xfaces.c: Make symbols static if they're not exported.
4375 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4376 Remove decls.
4377 * xterm.h (defined_color): Remove decls.
4378 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4379 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4380 (menu_face_changed_default, defined_color, free_realized_face):
4381 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4382 (ascii_face_of_lisp_face): Remove; unused.
4383
4384 * xdisp.c: Make symbols static if they're not exported.
4385 * dispextern.h (scratch_glyph_row, window_box_edges):
4386 (glyph_to_pixel_coords, set_cursor_from_row):
4387 (get_next_display_element, set_iterator_to_next):
4388 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4389 (show_mouse_face): Remove decls
4390 * frame.h (message_buf_print): Likewise.
4391 * lisp.h (pop_message, set_message, check_point_in_composition):
4392 Likewise.
4393 * xterm.h (set_vertical_scroll_bar): Likewise.
4394 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4395 (message_buf_print, scratch_glyph_row, displayed_buffer):
4396 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4397 (get_next_display_element, show_mouse_face, window_box_edges):
4398 (frame_to_window_pixel_xy, check_point_in_composition):
4399 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4400 (glyph_to_pixel_coords): Remove; unused.
4401
4402 * dired.c (file_name_completion): Now static.
4403
4404 * dbusbind.c (xd_in_read_queued_messages): Now static.
4405
4406 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4407 * data.c (circular_list_error): Remove.
4408
4409 * commands.h (last_point_position, last_point_position_buffer):
4410 (last_point_position_window): Remove decls.
4411 * keyboard.c: Make these variables static.
4412
4413 * coding.h (coding, code_convert_region, encode_coding_gap):
4414 Remove decls.
4415 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4416 (iso_code_class, detect_coding, code_convert_region): Now static.
4417 (encode_coding_gap): Remove; unused.
4418
4419 * chartab.c (chartab_chars, chartab_bits): Now static.
4420
4421 * charset.h (charset_iso_8859_1): Remove decl.
4422 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4423 Now static.
4424
4425 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4426 * ccl.c (Vccl_program_table): Now static.
4427 (check_ccl_update): Remove; unused.
4428
4429 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4430 * category.h: ... from here.
4431 * category.c (check_category_table, set_category_set): Now static.
4432
4433 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4434 * lisp.h: Remove these decls.
4435
4436 * buffer.c (buffer_count): Remove unused var.
4437
4438 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4439 so that it's not optimized away.
4440 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4441 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4442 exported only to the debugger.
4443
4444 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4445 * atimer.h (run_all_atimers): Remove; not exported.
4446
4447 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4448 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4449 was inaccessible from Lisp.
4450 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4451 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4452
4453 alloc.c: Import and export fewer symbols, and remove unused items.
4454 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4455 is defined.
4456 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4457 it's not optimized away by whole-program optimization.
4458 (message_enable_multibyte, free_misc): Remove.
4459 (catchlist, handlerlist, mark_backtrace):
4460 Declare only if BYTE_MARK_STACK.
4461 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4462 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4463 (message_enable_multibyte): Remove decl.
4464 (free_misc, interval_free_list, float_block, float_block_index):
4465 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4466 (cons_free_list, last_marked_index):
4467 Now static.
4468 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4469 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4470 (mark_backtrace): Define only if BYTE_MARK_STACK.
4471 * xdisp.c (message_enable_multibyte): Now static.
4472
4473 Declare Lisp_Object Q* variables to be 'static' if not exported.
4474 This makes it easier for human readers (and static analyzers)
4475 to see whether these variables are used from other modules.
4476 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4477 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4478 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4479 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4480 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4481 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4482 * xmenu.c, xselect.c:
4483 Declare Q* vars static if they are not used in other modules.
4484 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4485 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4486 Remove decls of unexported vars.
4487 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4488
4489 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4490
4491 Make Emacs functions such as Fatom 'static' by default.
4492 This makes it easier for human readers (and static analyzers)
4493 to see whether these functions can be called from other modules.
4494 DEFUN now defines a static function. To make the function external
4495 so that it can be used in other C modules, use the new macro DEFUE.
4496 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4497 (Finit_image_library):
4498 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4499 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4500 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4501 Remove decls, since these functions are now static.
4502 (Funintern, Fget_internal_run_time): New decls, since these functions
4503 were already external.
4504
4505 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4506 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4507 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4508 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4509 * keyboard.c, keymap.c, lread.c:
4510 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4511 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4512 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4513 Mark functions with DEFUE instead of DEFUN,
4514 if they are used in other modules.
4515 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4516 decls for now-static functions.
4517 * buffer.h (Fdelete_overlay): Remove decl.
4518 * callproc.c (Fgetenv_internal): Mark as internal.
4519 * composite.c (Fremove_list_of_text_properties): Remove decl.
4520 (Fcomposition_get_gstring): New forward static decl.
4521 * composite.h (Fcomposite_get_gstring): Remove decl.
4522 * dired.c (Ffile_attributes): New forward static decl.
4523 * doc.c (Fdocumntation_property): New forward static decl.
4524 * eval.c (Ffetch_bytecode): New forward static decl.
4525 (Funintern): Remove extern decl; now in .h file where it belongs.
4526 * fileio.c (Fmake_symbolic_link): New forward static decl.
4527 * image.c (Finit_image_library): New forward static decl.
4528 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4529 * intervals.h (Fprevious_property_change):
4530 (Fremove_list_of_text_properties): Remove decls.
4531 * keyboard.c (Fthis_command_keys): Remove decl.
4532 (Fcommand_execute): New forward static decl.
4533 * keymap.c (Flookup_key): New forward static decl.
4534 (Fcopy_keymap): Now static.
4535 * keymap.h (Flookup_key): Remove decl.
4536 * process.c (Fget_process): New forward static decl.
4537 (Fprocess_datagram_address): Mark as internal.
4538 * syntax.c (Fsyntax_table_p): New forward static decl.
4539 (skip_chars): Remove duplicate decl.
4540 * textprop.c (Fprevious_property_change): New forward static decl.
4541 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4542 Now internal.
4543 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4544 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4545
4546 * editfns.c (Fformat): Remove unreachable code.
4547
4548 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4549
4550 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4551 change. (Bug#8496)
4552
4553 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4554
4555 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4556 when at ZV. (Bug#8487)
4557
4558 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4559
4560 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4561 (Bug#8437)
4562 * keyboard.c (parse_tool_bar_item): Likewise.
4563 * sound.c (sound_cleanup, alsa_close): Likewise.
4564 * termcap.c (tgetent): Likewise.
4565 * xfns.c (x_default_font_parameter): Likewise.
4566 * xsettings.c (read_and_apply_settings): Likewise.
4567
4568 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4569 (overrun_check_free): Protoize.
4570
4571 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4572
4573 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4574 since callers should never pass a negative size.
4575 Change the signature to match that of plain 'read' and 'write'; see
4576 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4577 * lisp.h: Update prototypes of emacs_write and emacs_read.
4578
4579 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4580
4581 * xdisp.c (redisplay_window): Don't try to determine the character
4582 position of the scroll margin if the window start point w->startp
4583 is outside the buffer's accessible region. (Bug#8468)
4584
4585 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4586
4587 Fix write-region and its subroutines for buffers > 2GB.
4588 * fileio.c (a_write, e_write): Modify declaration of arguments and
4589 local variables to support buffers larger than 2GB.
4590 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4591
4592 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4593 argument, local variables, and return value.
4594
4595 * lisp.h: Update prototypes of emacs_write and emacs_read.
4596
4597 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4598
4599 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4600
4601 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4602
4603 Fix more problems found by GCC 4.6.0's static checks.
4604
4605 * xdisp.c (vmessage): Use a better test for character truncation.
4606
4607 * charset.c (load_charset_map): <, not <=, for optimization,
4608 and to avoid potential problems with integer overflow.
4609 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4610 * casetab.c (set_identity, shuffle): Likewise.
4611 * editfns.c (Fformat): Likewise.
4612 * syntax.c (skip_chars): Likewise.
4613
4614 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4615 This also lets GCC 4.6.0 generate slightly better loop code.
4616
4617 * callint.c (Fcall_interactively): <, not <=, for optimization.
4618 (Fcall_interactively): Count the number of arguments produced,
4619 not the number of arguments given. This is simpler and lets GCC
4620 4.6.0 generate slightly better code.
4621
4622 * ftfont.c: Distingish more carefully between FcChar8 and char.
4623 The previous code passed unsigned char * to a functions like
4624 strlen and xstrcasecmp that expect char *, which does not
4625 conform to the C standard.
4626 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4627 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4628 char * when the C standard requires it.
4629
4630 * keyboard.c (read_char): Remove unused var.
4631
4632 * eval.c: Port to Windows vsnprintf (Bug#8435).
4633 Include <limits.h>.
4634 (SIZE_MAX): Define if the headers do not.
4635 (verror): Do not give up if vsnprintf returns a negative count.
4636 Instead, grow the buffer. This ports to Windows vsnprintf, which
4637 does not conform to C99. Problem reported by Eli Zaretskii.
4638 Also, simplify the allocation scheme, by avoiding the need for
4639 calling realloc, and removing the ALLOCATED variable.
4640
4641 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4642
4643 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4644 But keep the doprint source code for now, as we might revamp it
4645 and use it again (Bug#8435).
4646 * lisp.h (doprnt): Remove.
4647 * Makefile.in (base_obj): Remove doprnt.o.
4648 * deps.mk (doprnt.o): Remove.
4649
4650 error: Print 32- and 64-bit integers portably (Bug#8435).
4651 Without this change, on typical 64-bit hosts error ("...%d...", N)
4652 was used to print both 32- and 64-bit integers N, which relied on
4653 undefined behavior.
4654 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4655 New macro.
4656 * lisp.h (error, verror): Mark as printf-like functions.
4657 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4658 Report overflow in size calculations when allocating printf buffer.
4659 Do not truncate output string at its first null byte.
4660 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4661 Truncate the output at a character boundary, since vsnprintf does not
4662 do that.
4663 * charset.c (check_iso_charset_parameter): Convert internal
4664 character to string before calling 'error', since %c now has the
4665 printf meaning.
4666 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4667 overflow when computing char to be passed to 'error'. Do not
4668 pass Lisp_Object to 'error'; pass the integer instead.
4669 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4670 formatted with plain %d.
4671
4672 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4673
4674 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4675
4676 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4677
4678 * xterm.c (x_catch_errors): Remove duplicate declaration.
4679
4680 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4681
4682 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4683
4684 2011-04-10 Jim Meyering <meyering@redhat.com>
4685
4686 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4687 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4688 return ssize_t not "int", and use size_t as the buffer length.
4689 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4690 * gnutls.h: Update declarations.
4691 * process.c (read_process_output): Use ssize_t, to match.
4692 (send_process): Likewise.
4693
4694 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4695
4696 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4697
4698 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4699
4700 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4701 Use unsigned char, to match FcChar8 type definition.
4702
4703 * xterm.c (handle_one_xevent):
4704 * xmenu.c (create_and_show_popup_menu):
4705 * xselect.c (x_decline_selection_request)
4706 (x_reply_selection_request): Avoid type-punned deref of X events.
4707
4708 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4709
4710 Fix some uses of `int' instead of EMACS_INT.
4711 * search.c (string_match_1, fast_string_match)
4712 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4713 (scan_buffer, find_next_newline_no_quit)
4714 (find_before_next_newline, search_command, Freplace_match)
4715 (Fmatch_data): Make some `int' variables be EMACS_INT.
4716
4717 * xdisp.c (display_count_lines): 3rd argument and return value now
4718 EMACS_INT. All callers changed.
4719 (pint2hrstr): Last argument is now EMACS_INT.
4720
4721 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4722 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4723 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4724 (decode_coding_utf_16, decode_coding_emacs_mule)
4725 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4726 (decode_coding_ccl, decode_coding_charset)
4727 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4728 (decode_coding_iso_2022, decode_coding_emacs_mule)
4729 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4730 <char_offset, last_offset>: Declare EMACS_INT.
4731 (encode_coding_utf_8, encode_coding_utf_16)
4732 (encode_coding_emacs_mule, encode_invocation_designation)
4733 (encode_designation_at_bol, encode_coding_iso_2022)
4734 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4735 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4736 Declare EMACS_INT.
4737 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4738 (encode_invocation_designation): Last argument P_NCHARS is now
4739 EMACS_INT.
4740 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4741 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4742
4743 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4744 All users changed.
4745
4746 * ccl.c (Fccl_execute_on_string): Declare some variables
4747 EMACS_INT.
4748
4749 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4750
4751 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4752
4753 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4754
4755 * process.c (Fformat_network_address): Doc fix.
4756
4757 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4758
4759 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4760
4761 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4762
4763 * keyboard.c (read_char): Call Lisp function help-form-show,
4764 instead of using internal_with_output_to_temp_buffer.
4765 (Qhelp_form_show): New var.
4766 (syms_of_keyboard): Use DEFSYM macro.
4767
4768 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4769
4770 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4771
4772 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4773
4774 * process.c (Flist_processes): Remove to Lisp.
4775 (list_processes_1): Delete.
4776
4777 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4778
4779 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4780
4781 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4782
4783 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4784
4785 Fix more problems found by GCC 4.6.0's static checks.
4786
4787 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4788
4789 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4790
4791 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4792
4793 * xdisp.c (vmessage): Mark as a printf-like function.
4794
4795 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4796
4797 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4798
4799 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4800 printf-like functions.
4801 (tiff_load): Add casts to remove these marks before passing them
4802 to system-supplied API.
4803
4804 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4805
4806 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4807 This avoids several warnings with gcc -Wstrict-overflow.
4808 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4809 directly, rather than having caller test rule sign. This avoids
4810 some unnecessary tests.
4811 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4812 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4813 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4814
4815 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4816 (xfont_open): Avoid unnecessary tests.
4817
4818 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4819
4820 * composite.h, composite.c (composition_gstring_put_cache):
4821 Use EMACS_INT, not int, for length.
4822
4823 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4824 breaking out part of COMPOSITION_DECODE_RULE.
4825 (COMPOSITION_DECODE_RULE): Use it.
4826 * composite.c (get_composition_id): Remove unused local vars,
4827 by using the new macro.
4828
4829 * textprop.c (set_text_properties_1): Change while to do-while,
4830 since the condition is always true at first.
4831
4832 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4833 (interval_deletion_adjustment): Return unsigned value.
4834 All uses changed.
4835
4836 * process.c (list_processes_1, create_pty, read_process_output):
4837 (exec_sentinel): Remove vars that were set but not used.
4838 (create_pty): Remove unnecessary "volatile"s.
4839 (Fnetwork_interface_info): Avoid possibility of int overflow.
4840 (read_process_output): Do adaptive read buffering even if carryover.
4841 (read_process_output): Simplify nbytes computation if buffered.
4842
4843 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4844
4845 * syntax.c (scan_words): Remove var that was set but not used.
4846 (update_syntax_table): Use unsigned instead of int.
4847
4848 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4849 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4850 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4851
4852 * print.c (print_error_message): Avoid int overflow.
4853
4854 * font.c (font_list_entities): Redo for clarity,
4855 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4856
4857 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4858 (font_score): Avoid potential overflow in diff calculation.
4859
4860 * fns.c (substring_both): Remove var that is set but not used.
4861 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4862
4863 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4864
4865 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4866 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4867 can always succeed if overflow has undefined behavior.
4868
4869 * search.c (boyer_moore, wordify): Remove vars set but not used.
4870 (wordify): Omit three unnecessary tests.
4871
4872 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4873 All callers changed. This avoids the need for an unused var.
4874
4875 * casefiddle.c (casify_region): Remove var that is set but not used.
4876
4877 * dired.c (file_name_completion): Remove var that is set but not used.
4878
4879 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4880
4881 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4882 (Finsert_file_contents): Remove unnecessary code checking fd.
4883
4884 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4885 Check for integer overflow on size calculations.
4886
4887 * buffer.c (Fprevious_overlay_change): Remove var that is set
4888 but not used.
4889
4890 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4891 Remove vars that are set but not used.
4892 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4893 (timer_check_2): Mark vars as initialized.
4894
4895 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4896
4897 * image.c (lookup_image): Remove var that is set but not used.
4898 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4899
4900 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4901 that are set but not used.
4902
4903 * xfns.c (make_invisible_cursor): Don't return garbage
4904 if XCreateBitmapFromData fails (Bug#8410).
4905
4906 * xselect.c (x_get_local_selection, x_handle_property_notify):
4907 Remove vars that are set but not used.
4908
4909 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4910 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4911
4912 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4913 Remove var that is set but not used.
4914 (scroll_bar_windows_size): Now size_t, not int.
4915 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4916 Check for overflow.
4917
4918 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4919 (map_tty_color) [!defined MSDOS]: Likewise.
4920
4921 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4922
4923 * coding.c: Remove vars that are set but not used.
4924 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4925 All callers changed.
4926 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4927 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4928 (decode_coding_charset): Remove vars that are set but not used.
4929
4930 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4931 that is set but not used.
4932
4933 * print.c (print_object): Remove var that is set but not used.
4934
4935 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4936 The gnulib version avoids calling malloc in the usual case,
4937 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4938 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4939 * filelock.c (current_lock_owner): Likewise.
4940 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4941 * sysdep.c: Include allocator.h, careadlinkat.h.
4942 (emacs_no_realloc_allocator): New static constant.
4943 (emacs_readlink): New function.
4944 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4945 ../lib/careadlinkat.h.
4946
4947 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4948
4949 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4950 first non-nil return value).
4951
4952 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4953
4954 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4955 if not defined (Bug#8403).
4956
4957 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4958
4959 * xdisp.c (display_count_lines): Remove parameter `start',
4960 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4961 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4962 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4963 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4964 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4965 and thereabouts. All callers changed.
4966 (get_per_char_metric): Remove parameter `f', unused since
4967 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4968
4969 2011-04-02 Jim Meyering <meyering@redhat.com>
4970
4971 do not dereference NULL upon failed strdup
4972 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4973 (ns_get_family): Likewise.
4974
4975 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4976
4977 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4978
4979 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4980
4981 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4982 later (Bug#8403).
4983
4984 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4985
4986 Add lexical binding.
4987
4988 * window.c (Ftemp_output_buffer_show): New fun.
4989 (Fsave_window_excursion):
4990 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4991
4992 * lread.c (lisp_file_lexically_bound_p): New function.
4993 (Fload): Bind Qlexical_binding.
4994 (readevalloop): Remove `evalfun' arg.
4995 Bind Qinternal_interpreter_environment.
4996 (Feval_buffer): Bind Qlexical_binding.
4997 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4998 Mark as dynamic.
4999 (syms_of_lread): Declare `lexical-binding'.
5000
5001 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5002
5003 * keyboard.c (eval_dyn): New fun.
5004 (menu_item_eval_property): Use it.
5005
5006 * image.c (parse_image_spec): Use Ffunctionp.
5007
5008 * fns.c (concat, mapcar1): Accept byte-code-functions.
5009
5010 * eval.c (Fsetq): Handle lexical vars.
5011 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5012 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5013 (FletX, Flet): Obey lexical binding.
5014 (Fcommandp): Handle closures.
5015 (Feval): New `lexical' arg.
5016 (eval_sub): New function extracted from Feval. Use it almost
5017 everywhere where Feval was used. Look up vars in lexical env.
5018 Handle closures.
5019 (Ffunctionp): Move from subr.el.
5020 (Ffuncall): Handle closures.
5021 (apply_lambda): Remove `eval_flags'.
5022 (funcall_lambda): Handle closures and new byte-code-functions.
5023 (Fspecial_variable_p): New function.
5024 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5025 but without exporting it to Lisp.
5026
5027 * doc.c (Fdocumentation, store_function_docstring):
5028 * data.c (Finteractive_form): Handle closures.
5029
5030 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5031 interactive spec.
5032
5033 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5034 New byte-codes.
5035 (exec_byte_code): New function extracted from Fbyte_code to handle new
5036 calling convention for byte-code-functions. Add new byte-codes.
5037
5038 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5039
5040 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5041
5042 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5043
5044 * xdisp.c (redisplay_internal): Fix prototype.
5045
5046 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5047
5048 * xdisp.c (SCROLL_LIMIT): New macro.
5049 (try_scrolling): Use it when setting scroll_limit.
5050 Limit scrolling to 100 screen lines.
5051 (redisplay_window): Even when falling back on "recentering",
5052 position point in the window according to scroll-conservatively,
5053 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5054
5055 (try_scrolling): When point is above the window, allow searching
5056 as far as scroll_max, or one screenful, to compute vertical
5057 distance from PT to the scroll margin position. This prevents
5058 try_scrolling from unnecessarily failing when
5059 scroll-conservatively is set to a value slightly larger than the
5060 window height. Clean up the case of PT below the margin at bottom
5061 of window: scroll_max can no longer be INT_MAX. When aggressive
5062 scrolling is in use, don't let point enter the opposite scroll
5063 margin as result of the scroll.
5064 (syms_of_xdisp) <scroll-conservatively>: Document the
5065 threshold of 100 lines for never-recentering scrolling.
5066
5067 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5068
5069 * dispextern.h (move_it_by_lines):
5070 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5071 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5072 (message_log_check_duplicate): Remove parameters `prev_bol' and
5073 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5074 (redisplay_internal): Remove parameter `preserve_echo_area',
5075 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5076
5077 * indent.c (Fvertical_motion):
5078 * window.c (window_scroll_pixel_based, Frecenter):
5079 Don't pass `need_y_p' to `move_it_by_lines'.
5080
5081 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5082
5083 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5084 steal a few bits to be more compact.
5085 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5086 Remove unneeded casts.
5087
5088 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5089
5090 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5091
5092 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5093 binding" message (bug#7967).
5094
5095 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5096
5097 Fix more problems found by GCC 4.6.0's static checks.
5098
5099 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5100 Remove unused local var.
5101
5102 * editfns.c (Fmessage_box): Remove unused local var.
5103
5104 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5105 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5106 Omit unused local vars.
5107 * window.c (shrink_windows): Omit unused local var.
5108 * menu.c (digest_single_submenu): Omit unused local var.
5109 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5110 Omit unused local var.
5111
5112 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5113 Don't assume string length fits in int.
5114 (keyremap_step, read_key_sequence): Use size_t for sizes.
5115 (read_key_sequence): Don't check last_real_key_start redundantly.
5116
5117 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5118 instead of alloca (Bug#8344).
5119
5120 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5121 (Fbacktrace_frame): Don't assume nframes fits in int.
5122
5123 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5124
5125 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5126 concerns.
5127
5128 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5129
5130 * cm.c (calccost): Turn while-do into do-while, for clarity.
5131
5132 * keyboard.c (syms_of_keyboard): Use the same style as later
5133 in this function when indexing through an array. This also
5134 works around GCC bug 48267.
5135
5136 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5137
5138 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5139
5140 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5141 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5142
5143 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5144 This avoids undefined behavior on integer overflow, and is a bit
5145 more convenient anyway since it is compared to a size_t variable.
5146
5147 Variadic C functions now count arguments with size_t, not int.
5148 This avoids an unnecessary limitation on 64-bit machines, which
5149 caused (substring ...) to crash on large vectors (Bug#8344).
5150 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5151 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5152 All variadic functions and their callers changed accordingly.
5153 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5154 * data.c (arith_driver, float_arith_driver): Likewise.
5155 * editfns.c (general_insert_function): Likewise.
5156 * eval.c (struct backtrace.nargs, interactive_p)
5157 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5158 (funcall_lambda, mark_backtrace): Likewise.
5159 * fns.c (concat): Likewise.
5160 * frame.c (x_set_frame_parameters): Likewise.
5161 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5162 0 if not found, not -1. All callers changed.
5163
5164 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5165 (stack_copy_size): Now size_t, not int.
5166 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5167
5168 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5171 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5172 All callers changed.
5173
5174 * lisp.h (multibyte_char_to_unibyte):
5175 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5176 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5177 * character.h (CHAR_TO_BYTE8):
5178 * cmds.c (internal_self_insert):
5179 * editfns.c (general_insert_function):
5180 * keymap.c (push_key_description):
5181 * search.c (Freplace_match):
5182 * xdisp.c (message_dolog, set_message_1): All callers changed.
5183
5184 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5185
5186 * keyboard.c (safe_run_hook_funcall): New function.
5187 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5188 don't set the hook to nil, but remove the offending function instead.
5189 (Qcommand_hook_internal): Remove, unused.
5190 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5191 Vcommand_hook_internal.
5192
5193 * eval.c (enum run_hooks_condition): Remove.
5194 (funcall_nil, funcall_not): New functions.
5195 (run_hook_with_args): Call each function through a `funcall' argument.
5196 Remove `cond' argument, now redundant.
5197 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5198 (Frun_hook_with_args_until_failure): Adjust accordingly.
5199 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5200
5201 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5202
5203 * dispextern.h (string_buffer_position): Remove declaration.
5204
5205 * print.c (strout): Remove parameter `multibyte', unused since
5206 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5207
5208 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5209 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5210 All callers changed.
5211
5212 * w32.c (_wsa_errlist): Use braces for struct initializers.
5213
5214 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5215 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5216 All callers changed.
5217 (string_buffer_position): Likewise. Also, make static (it's never
5218 used outside xdisp.c).
5219 (cursor_row_p): Remove parameter `w', unused since
5220 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5221 (decode_mode_spec): Remove parameter `precision', introduced during
5222 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5223 All callers changed.
5224
5225 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5226
5227 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5228
5229 2011-03-27 Anders Lindgren <andlind@gmail.com>
5230
5231 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5232 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5233 (ns_update_auto_hide_menu_bar): New functions.
5234 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5235 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5236 ns_constrain_all_frames.
5237 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5238 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5239
5240 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5241
5242 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5243
5244 2011-03-27 Glenn Morris <rgm@gnu.org>
5245
5246 * syssignal.h: Replace RETSIGTYPE with void.
5247 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5248 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5249 Replace SIGTYPE with void everywhere.
5250 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5251 * s/template.h (SIGTYPE): Remove commented out definition.
5252
5253 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5254
5255 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5256 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5257
5258 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5259
5260 * w32.c (read_unc_volume): Use parameter `henum', instead of
5261 global variable `wget_enum_handle'.
5262
5263 * keymap.c (describe_vector): Remove parameters `indices' and
5264 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5265 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5266
5267 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5268
5269 * keyboard.c (timer_check): Remove parameter `do_it_now',
5270 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5271 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5272 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5273
5274 * keyboard.c (read_char):
5275 * w32menu.c (w32_menu_display_help):
5276 * xmenu.c (show_help_event, menu_help_callback):
5277 Adjust calls to `show_help_echo'.
5278
5279 * gtkutil.c (xg_maybe_add_timer):
5280 * keyboard.c (readable_events):
5281 * process.c (wait_reading_process_output):
5282 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5283
5284 * insdel.c (adjust_markers_gap_motion):
5285 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5286 (gap_left, gap_right): Don't call it.
5287
5288 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5289
5290 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5291 incurred during fontification.
5292
5293 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5294
5295 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5296 (DEFVAR_PER_BUFFER): Don't pass it.
5297
5298 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5299 (scrolling_window): Don't pass it.
5300
5301 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5302
5303 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5304
5305 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5306 and `suffix'.
5307 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5308 of variables specific to SELinux and computation of `encoded_absname'.
5309
5310 * image.c (XPutPixel): Remove unused variable `height'.
5311
5312 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5313
5314 * unexw32.c (get_section_info): Remove unused variable `section'.
5315
5316 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5317 (system_process_attributes): Remove unused variable `sess'.
5318 (sys_read): Remove unused variable `err'.
5319
5320 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5321 (w32_wnd_proc): Remove unused variable `isdead'.
5322 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5323 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5324 (x_create_tip_frame): Remove unused variable `tem'.
5325
5326 * w32inevt.c (w32_console_read_socket):
5327 Remove unused variable `no_events'.
5328
5329 * w32term.c (x_draw_composite_glyph_string_foreground):
5330 Remove unused variable `width'.
5331
5332 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5333
5334 * w32term.c (x_set_glyph_string_clipping):
5335 Don't pass uninitialized region to CombineRgn.
5336
5337 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5338
5339 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5340 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5341 (Fx_close_connection): Remove unused variable `i'.
5342
5343 * w32font.c (w32font_draw): Return number of glyphs.
5344 (w32font_open_internal): Remove unused variable `i'.
5345 (w32font_driver): Add missing initializer.
5346
5347 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5348 (fill_in_menu): Remove unused variable `items_added'.
5349
5350 * w32term.c (last_mouse_press_frame): Remove static global variable.
5351 (w32_clip_to_row): Remove unused variable `f'.
5352 (x_delete_terminal): Remove unused variable `i'.
5353
5354 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5355 (NOTHING): Remove unused static global variable.
5356 (uniscribe_check_otf): Remove unused variable `table'.
5357 (uniscribe_font_driver): Add missing initializers.
5358
5359 2011-03-23 Julien Danjou <julien@danjou.info>
5360
5361 * term.c (Fsuspend_tty, Fresume_tty):
5362 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5363 * window.c (temp_output_buffer_show):
5364 * insdel.c (signal_before_change):
5365 * frame.c (Fhandle_switch_frame):
5366 * fileio.c (Fdo_auto_save):
5367 * emacs.c (Fkill_emacs):
5368 * editfns.c (save_excursion_restore):
5369 * cmds.c (internal_self_insert):
5370 * callint.c (Fcall_interactively):
5371 * buffer.c (Fkill_all_local_variables):
5372 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5373 Use Frun_hooks.
5374 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5375 unconditionnaly since it does the check itself.
5376
5377 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5378
5379 Fix more problems found by GCC 4.5.2's static checks.
5380
5381 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5382 the first time through the loop, since we know p0 < p1 then.
5383 This also avoids a gcc -Wstrict-overflow warning.
5384
5385 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5386 leading to a memory leak, possible in functions like
5387 load_charset_map_from_file that can allocate an unbounded number
5388 of objects (Bug#8318).
5389
5390 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5391 that could (at least in theory) be that large.
5392
5393 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5394 This is less likely to overflow, and avoids undefined behavior if
5395 overflow does occur. All callers changed. Use strtoul to scan
5396 for the unsigned long integer.
5397 (pint2hrstr): Simplify and tune code slightly.
5398 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5399
5400 * scroll.c (do_scrolling): Work around GCC bug 48228.
5401 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5402
5403 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5404 This also avoids a warning with gcc -Wstrict-overflow.
5405 (validate_x_resource_name): Simplify count usage.
5406 This also avoids a warning with gcc -Wstrict-overflow.
5407
5408 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5409 fail (Bug#8306).
5410
5411 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5412
5413 * process.c (Fmake_network_process): Use socklen_t, not int,
5414 where POSIX says socklen_t is required in portable programs.
5415 This fixes a porting bug on hosts like 64-bit HP-UX, where
5416 socklen_t is wider than int (Bug#8277).
5417 (Fmake_network_process, server_accept_connection):
5418 (wait_reading_process_output, read_process_output):
5419 Likewise.
5420
5421 * process.c: Rename or move locals to avoid shadowing.
5422 (list_processes_1, Fmake_network_process):
5423 (read_process_output_error_handler, exec_sentinel_error_handler):
5424 Rename or move locals.
5425 (Fmake_network_process): Define label "retry_connect" only if needed.
5426 (Fnetwork_interface_info): Fix pointer signedness.
5427 (process_send_signal): Add cast to avoid pointer signedness problem.
5428 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5429 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5430
5431 Make tparam.h and terminfo.c consistent.
5432 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5433 Include tparam.h instead, since it declares them.
5434 * cm.h (PC): Remove extern decl; tparam.h now does this.
5435 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5436 * terminfo.c: Include tparam.h, to check interfaces.
5437 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5438 (tparam): Adjust signature to match interface in tparam.h;
5439 this removes some undefined behavior. Check that outstring and len
5440 are zero, which they always are with Emacs.
5441 * tparam.h (PC, BC, UP): New extern decls.
5442
5443 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5444 (xftfont_open): Rename locals to avoid shadowing.
5445
5446 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5447 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5448 (OTF_TAG_SYM): Omit macro if not needed.
5449 (ftfont_list): Remove unused local.
5450 (get_adstyle_property, ftfont_pattern_entity):
5451 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5452 Rename locals to avoid shadowing.
5453
5454 * xfont.c (xfont_list_family): Mark var as initialized.
5455
5456 * xml.c (make_dom): Now static.
5457
5458 * composite.c (composition_compute_stop_pos): Rename local to
5459 avoid shadowing.
5460 (composition_reseat_it): Remove unused locals.
5461 (find_automatic_composition, composition_adjust_point): Likewise.
5462 (composition_update_it): Mark var as initialized.
5463 (find_automatic_composition): Mark vars as initialized,
5464 with a FIXME (Bug#8290).
5465
5466 character.h: Rename locals to avoid shadowing.
5467 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5468 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5469 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5470 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5471 to avoid shadowing.
5472
5473 * textprop.c (property_change_between_p): Remove; unused.
5474
5475 * intervals.c (interval_start_pos): Now static.
5476
5477 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5478
5479 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5480 Rename locals to avoid shadowing.
5481
5482 * sound.c (wav_play, au_play, Fplay_sound_internal):
5483 Fix pointer signedness.
5484 (alsa_choose_format): Remove unused local var.
5485 (wav_play): Initialize a variable to 0, to prevent undefined
5486 behavior (Bug#8278).
5487
5488 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5489
5490 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5491
5492 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5493 clobbering (Bug#8298).
5494 * sysdep.c (sys_subshell): Likewise.
5495 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5496
5497 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5498 This should get cleaned up, so that child_setup has the
5499 same signature on all platforms.
5500
5501 * callproc.c (call_process_cleanup): Now static.
5502 (relocate_fd): Rename locals to avoid shadowing.
5503
5504 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5505
5506 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5507 not to be necessary, and produces flickering.
5508
5509 2011-03-20 Glenn Morris <rgm@gnu.org>
5510
5511 * config.in: Remove file.
5512
5513 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5514
5515 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5516 are now in src/globals.h.
5517 (syms_of_minibuf): Remove spurious & from previous change.
5518
5519 2011-03-20 Leo <sdl.web@gmail.com>
5520
5521 * minibuf.c (completing-read-function): New variable.
5522 (completing-read-default): Rename from completing-read.
5523 (completing-read): Call completing-read-function.
5524
5525 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5526
5527 * xfaces.c (Fx_load_color_file):
5528 Read color file from absolute filename (bug#8250).
5529
5530 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5531
5532 * makefile.w32-in: Update dependencies.
5533
5534 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5535
5536 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5537
5538 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5539
5540 Fix more problems found by GCC 4.5.2's static checks.
5541
5542 * process.c (make_serial_process_unwind, send_process_trap):
5543 (sigchld_handler): Now static.
5544
5545 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5546 That way, the code declares only the vars that it needs.
5547 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5548 * s/cygwin.h (PTY_ITERATION): Likewise.
5549 * s/darwin.h (PTY_ITERATION): Likewise.
5550 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5551
5552 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5553 * process.c (allocate_pty): Don't declare stb unless it's needed.
5554
5555 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5556 (CONSTANTLIM): Remove; unused.
5557 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5558 Define only if needed.
5559
5560 * unexelf.c (unexec): Name an expression,
5561 to avoid gcc -Wbad-function-cast warning.
5562 Use a different way to cause a compilation error if anyone uses
5563 n rather than nn, a way that does not involve shadowing.
5564 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5565
5566 * deps.mk (unexalpha.o): Remove; unused.
5567
5568 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5569 * unexec.h: New file.
5570 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5571 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5572 Depend on unexec.h.
5573 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5574 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5575 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5576 Change as necessary to match prototype in unexec.h.
5577
5578 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5579 shadowing.
5580 (back_comment, skip_chars): Mark vars as initialized.
5581
5582 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5583 Rename locals to avoid shadowing.
5584
5585 * lread.c (read1): Rewrite so as not to use empty "else".
5586 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5587
5588 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5589
5590 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5591 warning when compiling print.c.
5592
5593 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5594 instead of using an uninitialized var.
5595 (font_sort_entities): Mark var as initialized.
5596
5597 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5598
5599 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5600 pointers to constants.
5601 (font_parse_fcname): Remove unused vars.
5602 (font_delete_unmatched): Now static.
5603 (font_get_spec): Remove; unused.
5604 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5605 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5606 Rename or move locals to avoid shadowing.
5607
5608 * fns.c (require_nesting_list, require_unwind): Now static.
5609 (Ffillarray): Rename locals to avoid shadowing.
5610
5611 * floatfns.c (domain_error2): Define only if needed.
5612 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5613
5614 * alloc.c (mark_backtrace): Move decl from here ...
5615 * lisp.h: ... to here, so that it can be checked.
5616
5617 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5618 (Fdefvar): Rewrite so as not to use empty "else".
5619 (lisp_indirect_variable): Name an expression,
5620 to avoid gcc -Wbad-function-cast warning.
5621 (Fdefvar): Rename locals to avoid shadowing.
5622
5623 * callint.c (quotify_arg, quotify_args): Now static.
5624 (Fcall_interactively): Rename locals to avoid shadowing.
5625 Use const pointer when appropriate.
5626
5627 * lisp.h (get_system_name, get_operating_system_release):
5628 Move decls here, to check interfaces.
5629 * process.c (get_operating_system_release): Move decl to lisp.h.
5630 * xrdb.c (get_system_name): Likewise.
5631 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5632 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5633 some of which prompt warnings from gcc -Wbad-function-cast.
5634 (Fformat_time_string, Fencode_time, Finsert_char):
5635 (Ftranslate_region_internal, Fformat):
5636 Rename or remove local vars to avoid shadowing.
5637 (Ftranslate_region_internal): Mark var as initialized.
5638
5639 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5640 avoid shadowing.
5641
5642 * lisp.h (eassert): Check that the argument compiles, even if
5643 ENABLE_CHECKING is not defined.
5644
5645 * data.c (Findirect_variable): Name an expression, to avoid
5646 gcc -Wbad-function-cast warning.
5647 (default_value, arithcompare, arith_driver, arith_error): Now static.
5648 (store_symval_forwarding): Rename local to avoid shadowing.
5649 (Fmake_variable_buffer_local, Fmake_local_variable):
5650 Mark variables as initialized.
5651 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5652
5653 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5654 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5655 Rename locals to avoid shadowing.
5656 (mark_stack): Move local variables into the #ifdef region where
5657 they're used.
5658 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5659 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5660 needed otherwise.
5661 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5662 (GC_STRING_CHARS): Remove; not used.
5663 (Fmemory_limit): Cast sbrk's returned value to char *.
5664
5665 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5666 avoids undefined behavior in theory.
5667
5668 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5669
5670 Use functions, not macros, for up- and down-casing (Bug#8254).
5671 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5672 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5673 to use the following functions instead of these macros.
5674 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5675 EMACS_INT, since callers assume the returned value fits in int.
5676 (upcase1): Likewise, for UPCASE_TABLE.
5677 (uppercasep, lowercasep, upcase): New static inline functions.
5678 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5679 the race-condition problem in the old DOWNCASE.
5680
5681 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5682 Rename locals to avoid shadowing.
5683 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5684 (regex_compile, re_search_2, re_match_2_internal):
5685 Remove unused local vars.
5686 (FREE_VAR): Rewrite so as not to use empty "else",
5687 which gcc can warn about.
5688 (regex_compile, re_match_2_internal): Mark locals as initialized.
5689 (RETALLOC_IF): Define only if needed.
5690 (WORDCHAR_P): Likewise. This one is never needed, but is used
5691 only in a comment talking about a compiler bug, so put inside
5692 the #if 0 of that comment.
5693 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5694 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5695 Remove; unused.
5696
5697 * search.c (boyer_moore): Rename locals to avoid shadowing.
5698 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5699 (PREV_CHAR_BOUNDARY): Likewise.
5700
5701 * search.c (simple_search): Remove unused var.
5702
5703 * dired.c (compile_pattern): Move decl from here ...
5704 * lisp.h: ... to here, so that it can be checked.
5705 (struct re_registers): New forward decl.
5706
5707 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5708
5709 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5710 All uses changed.
5711 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5712 Rename locals to avoid shadowing.
5713 (Fvertical_motion): Mark locals as initialized.
5714
5715 * casefiddle.c (casify_object, casify_region): Now static.
5716 (casify_region): Mark local as initialized.
5717
5718 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5719
5720 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5721 New macros, so that the caller can use some names other than
5722 gcpro1, gcpro2, etc.
5723 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5724 of the new macros.
5725 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5726 argument, for consistency with GCPRO2_VAR, etc: it is now the
5727 prefix of the variable, not the variable itself. All uses
5728 changed.
5729 * dired.c (directory_files_internal, file_name_completion):
5730 Rename locals to avoid shadowing.
5731
5732 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5733 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5734 dired.c's scmp function, had undefined behavior.
5735 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5736 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5737 * buffer.h: ... to here, because these macros use current_buffer,
5738 and the new implementation with inline functions needs to have
5739 current_buffer in scope now, rather than later when the macros
5740 are used.
5741 (downcase, upcase1): New static inline functions.
5742 (DOWNCASE, UPCASE1): Reimplement using these functions.
5743 This avoids undefined behavior in expressions like
5744 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5745 from race conditions in accessing the global variables
5746 case_temp1 and case_temp2.
5747 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5748 * lisp.h (case_temp1, case_temp2): Remove their decls.
5749 * character.h (ASCII_CHAR_P): Move from here ...
5750 * lisp.h: ... to here, so that the inline functions mentioned
5751 above can use them.
5752
5753 * dired.c (directory_files_internal_unwind): Now static.
5754
5755 * fileio.c (file_name_as_directory, directory_file_name):
5756 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5757 Now static.
5758 (file_name_as_directory): Use const pointers when appropriate.
5759 (Fexpand_file_name): Likewise. In particular, newdir might
5760 point at constant storage, so make it a const pointer.
5761 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5762 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5763 signedness issues.
5764 (Fset_file_times, Finsert_file_contents, auto_save_error):
5765 Rename locals to avoid shadowing.
5766
5767 * minibuf.c (choose_minibuf_frame_1): Now static.
5768 (Ftry_completion, Fall_completions): Rename or remove locals
5769 to avoid shadowing.
5770
5771 * marker.c (bytepos_to_charpos): Remove; unused.
5772
5773 * lisp.h (verify_bytepos, count_markers): New decls,
5774 so that gcc does not warn that these functions aren't declared.
5775
5776 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5777 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5778 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5779 (copy_text): Remove unused local var.
5780
5781 * filelock.c (within_one_second): Now static.
5782 (lock_file_1): Rename local to avoid shadowing.
5783
5784 * buffer.c (fix_overlays_before): Mark locals as initialized.
5785 (fix_start_end_in_overlays): Likewise. This function should be
5786 simplified by using pointers-to-pointers, but that's a different
5787 matter.
5788 (switch_to_buffer_1): Now static.
5789 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5790 (report_overlay_modification): Rename locals to avoid shadowing.
5791
5792 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5793 Fix pointer signedness issue.
5794 (sys_subshell): Mark local as volatile if checking for lint,
5795 to suppress a gcc -Wclobbered warning that does not seem to be right.
5796 (MAXPATHLEN): Define only if needed.
5797
5798 * process.c (serial_open, serial_configure): Move decls from here ...
5799 * systty.h: ... to here, so that they can be checked.
5800
5801 * fns.c (get_random, seed_random): Move extern decls from here ...
5802 * lisp.h: ... to here, so that they can be checked.
5803
5804 * sysdep.c (reset_io): Now static.
5805 (wait_for_termination_signal): Remove; unused.
5806
5807 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5808 (copy_keymap_item, append_key, push_text_char_description):
5809 Now static.
5810 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5811 (DENSE_TABLE_SIZE): Remove; unused.
5812 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5813 (describe_map_tree):
5814 Rename locals to avoid shadowing.
5815
5816 * keyboard.c: Declare functions static if they are not used elsewhere.
5817 (echo_char, echo_dash, cmd_error, top_level_2):
5818 (poll_for_input, handle_async_input): Now static.
5819 (read_char, kbd_buffer_get_event, make_lispy_position):
5820 (make_lispy_event, make_lispy_movement, apply_modifiers):
5821 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5822 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5823 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5824 (read_key_sequence, read_char): Mark locals as initialized.
5825 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5826
5827 * keyboard.h (make_ctrl_char): New decl.
5828 (mark_kboards): Move decl here ...
5829 * alloc.c (mark_kboards): ... from here.
5830
5831 * lisp.h (force_auto_save_soon): New decl.
5832
5833 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5834 (DEFINE_DUMMY_FUNCTION): New macro.
5835 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5836 Use it.
5837 (main): Add casts to avoid warnings
5838 if GCC considers string literals to be constants.
5839
5840 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5841
5842 * dbusbind.c: Pointer signedness fixes.
5843 (xd_signature, xd_append_arg, xd_initialize):
5844 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5845 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5846 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5847 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5848
5849 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5850 if GCC considers string literals to be constants.
5851 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5852
5853 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5854
5855 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5856 (print_preprocess, print_object): New macro to fix last change.
5857
5858 * print.c (print_preprocess): Don't forget font objects.
5859
5860 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5861
5862 * emacs.c (USAGE3): Doc fixes.
5863
5864 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5865
5866 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5867 structure.
5868
5869 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5870
5871 * lisp.h (VWindow_system, Qfile_name_history):
5872 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5873 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5874 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5875
5876 * w32select.c: Don't #include "keyboard.h".
5877 (run_protected): Add extern declaration for waiting_for_input.
5878
5879 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5880 * w32console.c (detect_input_pending, read_input_pending)
5881 (encode_terminal_code):
5882 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5883 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5884 (w32_system_caret_y, Qfile_name_history):
5885 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5886 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5887 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5888 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5889 * w32proc.c (Qlocal, report_file_error):
5890 * w32term.c (Vwindow_system, updating_frame):
5891 * w32uniscribe.c (initialized, uniscribe_font_driver):
5892 Remove unneeded extern declarations.
5893
5894 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5895
5896 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5897
5898 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5899
5900 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5901 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5902 These macros can no longer be used for assignment.
5903
5904 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5905 Assign struct members directly, instead of using BUF_BEGV etc.
5906 (record_buffer_markers, fetch_buffer_markers): New functions for
5907 recording and fetching special buffer markers.
5908 (set_buffer_internal_1, set_buffer_temp): Use them.
5909
5910 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5911
5912 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5913
5914 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5915 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5916
5917 * xdisp.c (hscroll_window_tree):
5918 (reconsider_clip_changes): Use PT instead of BUF_PT.
5919
5920 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5921
5922 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5923 $(EMACS_ROOT)/lib/intprops.h.
5924
5925 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5926
5927 Fix more problems found by GCC 4.5.2's static checks.
5928
5929 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5930 to unsigned char * to avoid compiler diagnostic.
5931 (xg_free_frame_widgets): Make it clear that a local variable is
5932 needed only if USE_GTK_TOOLTIP.
5933 (gdk_window_get_screen): Make it clear that this macro is needed
5934 only if USE_GTK_TOOLTIP.
5935 (int_gtk_range_get_value): New function, which avoids a diagnostic
5936 from gcc -Wbad-function-cast.
5937 (xg_set_toolkit_scroll_bar_thumb): Use it.
5938 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5939 diagnostic from gcc -Wbad-function-cast.
5940 (get_utf8_string, xg_get_file_with_chooser):
5941 Rename locals to avoid shadowing.
5942 (create_dialog): Move locals to avoid shadowing.
5943
5944 * xgselect.c (xg_select): Remove unused var.
5945
5946 * image.c (four_corners_best): Mark locals as initialized.
5947 (gif_load): Initialize transparent_p to zero (Bug#8238).
5948 Mark another local as initialized.
5949 (my_png_error, my_error_exit): Mark with NO_RETURN.
5950
5951 * image.c (clear_image_cache): Now static.
5952 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5953 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5954 (x_edge_detection): Remove unnecessary cast that
5955 gcc -Wbad-function-cast diagnoses.
5956 (gif_load): Fix pointer signedness.
5957 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5958 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5959
5960 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5961
5962 Improve quality of tests for time stamp overflow.
5963 For example, without this patch (encode-time 0 0 0 1 1
5964 1152921504606846976) returns the obviously-bogus value (-948597
5965 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5966 reports time overflow. See
5967 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5968 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5969 * editfns.c: Include limits.h and intprops.h.
5970 (TIME_T_MIN, TIME_T_MAX): New macros.
5971 (time_overflow): Move earlier, to before first use.
5972 (hi_time, lo_time): New functions, for an accurate test for
5973 out-of-range times.
5974 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5975 (Fget_internal_run_time): Don't assume time_t fits in int.
5976 (make_time): Use list2 instead of Fcons twice.
5977 (Fdecode_time): More accurate test for out-of-range times.
5978 (check_tm_member): New function.
5979 (Fencode_time): Use it, to test for out-of-range times.
5980 (lisp_time_argument): Don't rely on undefined left-shift and
5981 right-shift behavior when checking for time stamp overflow.
5982
5983 * editfns.c (time_overflow): New function, refactoring common code.
5984 (Fformat_time_string, Fdecode_time, Fencode_time):
5985 (Fcurrent_time_string): Use it.
5986
5987 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5988 * dired.c (make_time): Move to ...
5989 * editfns.c (make_time): ... here.
5990 * systime.h: Note the move.
5991
5992 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5993
5994 * fringe.c (update_window_fringes): Remove unused variables.
5995
5996 * unexmacosx.c (copy_data_segment): Also copy __got section.
5997 (Bug#8223)
5998
5999 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6000
6001 * termcap.c [MSDOS]: Include "msdos.h".
6002 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6003 Constify `char *' arguments and their references according to
6004 prototypes in tparam.h.
6005
6006 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6007
6008 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6009 Adapt all references accordingly.
6010
6011 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6012
6013 2011-03-11 Tom Tromey <tromey@redhat.com>
6014
6015 * buffer.c (syms_of_buffer): Remove obsolete comment.
6016
6017 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6018
6019 * termhooks.h (encode_terminal_code): Declare prototype.
6020
6021 * msdos.c (encode_terminal_code): Don't declare prototype.
6022
6023 * term.c (encode_terminal_code): Now external again, used by
6024 w32console.c and msdos.c.
6025
6026 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6027 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6028
6029 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6030
6031 Fix some minor problems found by GCC 4.5.2's static checks.
6032
6033 * fringe.c (update_window_fringes): Mark locals as initialized
6034 (Bug#8227).
6035 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6036
6037 * alloc.c (mark_fringe_data): Move decl from here ...
6038 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6039 to check its interface.
6040 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6041
6042 * fontset.c (free_realized_fontset): Now static.
6043 (Fset_fontset_font): Rename local to avoid shadowing.
6044 (fontset_font): Mark local as initialized.
6045 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6046
6047 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6048
6049 * xselect.c (x_disown_buffer_selections): Remove; not used.
6050 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6051 (x_own_selection, Fx_disown_selection_internal): Rename locals
6052 to avoid shadowing.
6053 (x_handle_dnd_message): Remove local to avoid shadowing.
6054
6055 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6056 so that the caller can use some name other than gcpro1.
6057 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6058 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6059 (Fx_backspace_delete_keys_p):
6060 Use them to avoid shadowing, and rename vars to avoid shadowing.
6061 (x_decode_color, x_set_name, x_window): Now static.
6062 (Fx_create_frame): Add braces to silence GCC warning.
6063 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6064 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6065 Remove unused locals.
6066 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6067 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6068 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6069 macros.
6070
6071 * xterm.h (x_mouse_leave): New decl.
6072
6073 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6074 Remove unused functions.
6075 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6076 (x_calc_absolute_position): Now static.
6077 (XTread_socket): Don't define label "out" unless it's used.
6078 Don't declare local "event" unless it's used.
6079 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6080 unless they are used.
6081 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6082 (x_fatal_error_signal): Remove; not used.
6083 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6084 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6085 (x_error_catcher, x_connection_closed, x_error_handler):
6086 (x_error_quitter, xembed_send_message, x_iconify_frame):
6087 (my_log_handler): Rename locals to avoid shadowing.
6088 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6089 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6090
6091 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6092 Rename or move locals to avoid shadowing.
6093 (tty_defined_color, merge_face_heights): Now static.
6094 (free_realized_faces_for_fontset): Remove; not used.
6095 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6096 does not deduce is never used uninitialized.
6097 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6098 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6099
6100 * terminal.c (store_terminal_param): Now static.
6101
6102 * xmenu.c (menu_highlight_callback): Now static.
6103 (set_frame_menubar): Remove unused local.
6104 (xmenu_show): Rename parameter to avoid shadowing.
6105 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6106 since they might point to immutable storage.
6107 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6108 since it's unused otherwise.
6109
6110 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6111 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6112 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6113 avoids a gcc -Wuninitialized diagnostic.
6114 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6115 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6116 does not deduce are never used uninitialized.
6117
6118 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6119
6120 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6121 * window.c (window_loop, size_window):
6122 (run_window_configuration_change_hook, enlarge_window): Likewise.
6123
6124 * window.c (display_buffer): Now static.
6125 (size_window): Mark variables that gcc -Wuninitialized
6126 does not deduce are never used uninitialized.
6127 * window.h (check_all_windows): New decl, to forestall
6128 gcc -Wmissing-prototypes diagnostic.
6129 * dispextern.h (bidi_dump_cached_states): Likewise.
6130
6131 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6132 shadowing.
6133 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6134 Include <limits.h>.
6135 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6136 and to avoid gcc -Wuninitialized warning.
6137 (load_charset_map): Mark variables that gcc -Wuninitialized
6138 does not deduce are never used uninitialized.
6139 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6140
6141 * coding.c (coding_set_source, coding_set_destination):
6142 Use "else { /* comment */ }" rather than "else /* comment */;"
6143 for clarity, and to avoid gcc -Wempty-body warning.
6144 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6145 a block, when the outer 'i' will do.
6146 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6147 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6148 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6149 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6150 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6151 Rename locals to avoid shadowing.
6152 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6153 * coding.c (emacs_mule_char, encode_invocation_designation):
6154 Now static, since they're not used elsewhere.
6155 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6156 (decode_coding_object, encode_coding_object, detect_coding_system):
6157 (decode_coding_emacs_mule): Mark variables that gcc
6158 -Wuninitialized does not deduce are never used uninitialized.
6159 (detect_coding_iso_2022): Initialize a local variable that might
6160 be used uninitialized. Leave a FIXME because it's not clear that
6161 this initialization is needed. (Bug#8211)
6162 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6163 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6164 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6165 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6166 Remove unused macros.
6167
6168 * category.c (hash_get_category_set): Remove unused local var.
6169 (copy_category_table): Now static, since it's not used elsewhere.
6170 * character.c (string_count_byte8): Likewise.
6171
6172 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6173 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6174
6175 * chartab.c (copy_sub_char_table): Now static, since it's not used
6176 elsewhere.
6177 (sub_char_table_ref_and_range, char_table_ref_and_range):
6178 Rename locals to avoid shadowing.
6179 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6180
6181 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6182 (BIDI_BOB): Remove unused macro.
6183
6184 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6185 deduce are never used uninitialized.
6186 * term.c (encode_terminal_code): Likewise.
6187
6188 * term.c (encode_terminal_code): Now static. Remove unused local.
6189
6190 * tparam.h: New file.
6191 * term.c, tparam.h: Include it.
6192 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6193 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6194 Move these decls to tparam.h, and make them agree with what
6195 is actually in tparam.c. The previous trick of using incompatible
6196 decls in different modules does not conform to the C standard.
6197 All callers of tparam changed to use tparam's actual API.
6198 * tparam.c (tparam1, tparam, tgoto):
6199 Use const pointers where appropriate.
6200
6201 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6202 * cm.h (struct cm): Likewise.
6203 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6204 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6205 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6206 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6207 (turn_on_face, init_tty): Likewise.
6208 * termchar.h (struct tty_display_info): Likewise.
6209
6210 * term.c (term_mouse_position): Rename local to avoid shadowing.
6211
6212 * alloc.c (mark_ttys): Move decl from here ...
6213 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6214
6215 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6216
6217 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6218
6219 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6220
6221 * search.c (compile_pattern_1): Remove argument regp, unused since
6222 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6223 (compile_pattern): Don't pass it.
6224
6225 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6226
6227 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6228 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6229 for ! HAVE_GTK3.
6230 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6231
6232 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6233
6234 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6235 gdk_window_get_screen, gdk_window_get_geometry,
6236 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6237 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6238 (xg_get_pixbuf_from_pixmap): New function.
6239 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6240 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6241 Call xg_get_pixbuf_from_pixmap instead of
6242 gdk_pixbuf_get_from_drawable.
6243 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6244 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6245 (xg_check_special_colors): Use GtkStyleContext and its functions
6246 for HAVE_GTK3.
6247 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6248 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6249 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6250 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6251 Call gtk_widget_get_preferred_size.
6252 (xg_frame_resized): gdk_window_get_geometry only takes 5
6253 parameters.
6254 (xg_win_to_widget, xg_event_is_for_menubar):
6255 Call gdk_x11_window_lookup_for_display.
6256 (xg_set_widget_bg): New function.
6257 (delete_cb): New function.
6258 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6259 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6260 (xg_set_background_color): Call xg_set_widget_bg.
6261 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6262 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6263 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6264 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6265 if ! HAVE_GTK3.
6266 (update_frame_tool_bar): Call gtk_widget_hide.
6267 (xg_initialize): Use GDK_KEY_g.
6268
6269 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6270 if ! HAVE_GTK3
6271 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6272
6273 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6274 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6275 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6276
6277 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6278
6279 * w32xfns.c (select_palette): Check success of RealizePalette against
6280 GDI_ERROR, not zero.
6281
6282 See ChangeLog.11 for earlier changes.
6283
6284 ;; Local Variables:
6285 ;; coding: utf-8
6286 ;; End:
6287
6288 Copyright (C) 2011 Free Software Foundation, Inc.
6289
6290 This file is part of GNU Emacs.
6291
6292 GNU Emacs is free software: you can redistribute it and/or modify
6293 it under the terms of the GNU General Public License as published by
6294 the Free Software Foundation, either version 3 of the License, or
6295 (at your option) any later version.
6296
6297 GNU Emacs is distributed in the hope that it will be useful,
6298 but WITHOUT ANY WARRANTY; without even the implied warranty of
6299 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6300 GNU General Public License for more details.
6301
6302 You should have received a copy of the GNU General Public License
6303 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.