1 2011-04-11 Paul Eggert <eggert@cs.ucla.edu>
3 Make Emacs functions such as Fatom 'static' by default.
4 This makes it easier for human readers (and static analyzers)
5 to see whether these functions can be called from other modules.
6 DEFUN now defines a static function. To make the function external
7 so that it can be used in other C modules, use the new macro DEFUE.
8 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
9 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
10 static function definition. Use DEFUE if you want an extern one.
11 (DEFUE, INFUN): New macros.
12 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
13 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
14 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
15 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
16 Remove decls, since these functions are now static.
17 (Funintern, Fget_internal_run_time): New decls, since these functions
18 were already external.
19 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
20 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
21 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
22 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
23 * keyboard.c, keymap.c, lread.c:
24 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
25 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
26 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
27 Mark functions with DEFUE instead of DEFUN,
28 if they are used in other modules.
29 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
30 decls for now-static functions.
31 * buffer.h (Fdelete_overlay): Remove decl.
32 * callproc.c (Fgetenv_internal): Mark as internal.
33 * composite.c (Fremove_list_of_text_properties): Remove decl.
34 (Fcomposition_get_gstring): New forward static decl.
35 * composite.h (Fcomposite_get_gstring): Remove decl.
36 * dired.c (Ffile_attributes): New forward static decl.
37 * doc.c (Fdocumntation_property): New forward static decl.
38 * eval.c (Ffetch_bytecode): New forward static decl.
39 (Funintern): Remove extern decl; now in .h file where it belongs.
40 * fileio.c (Fmake_symbolic_link): New forward static decl.
41 * image.c (Finit_image_library): New forward static decl.
42 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
43 * intervals.h (Fprevious_property_change):
44 (Fremove_list_of_text_properties): Remove decls.
45 * keyboard.c (Fthis_command_keys): Remove decl.
46 (Fcommand_execute): New forward static decl.
47 * keymap.c (Flookup_key): New forward static decl.
48 (Fcopy_keymap): Now static.
49 * keymap.h (Flookup_key): Remove decl.
50 * process.c (Fget_process): New forward static decl.
51 (Fprocess_datagram_address): Mark as internal.
52 * syntax.c (Fsyntax_table_p): New forward static decl.
53 (skip_chars): Remove duplicate decl.
54 * textprop.c (Fprevious_property_change): New forward static decl.
55 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
57 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
58 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
60 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
62 * editfns.c (Fformat): Remove unreachable code.
64 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
66 Fix more problems found by GCC 4.6.0's static checks.
68 * xdisp.c (vmessage): Use a better test for character truncation.
70 * charset.c (load_charset_map): <, not <=, for optimization,
71 and to avoid potential problems with integer overflow.
72 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
73 * casetab.c (set_identity, shuffle): Likewise.
74 * editfns.c (Fformat): Likewise.
75 * syntax.c (skip_chars): Likewise.
77 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
78 This also lets GCC 4.6.0 generate slightly better loop code.
80 * callint.c (Fcall_interactively): <, not <=, for optimization.
81 (Fcall_interactively): Count the number of arguments produced,
82 not the number of arguments given. This is simpler and lets GCC
83 4.6.0 generate slightly better code.
85 * ftfont.c: Distingish more carefully between FcChar8 and char.
86 The previous code passed unsigned char * to a functions like
87 strlen and xstrcasecmp that expect char *, which does not
88 conform to the C standard.
89 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
90 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
91 char * when the C standard requires it.
93 * keyboard.c (read_char): Remove unused var.
95 * eval.c: Port to Windows vsnprintf (Bug#8435).
97 (SIZE_MAX): Define if the headers do not.
98 (verror): Do not give up if vsnprintf returns a negative count.
99 Instead, grow the buffer. This ports to Windows vsnprintf, which
100 does not conform to C99. Problem reported by Eli Zaretskii.
101 Also, simplify the allocation scheme, by avoiding the need for
102 calling realloc, and removing the ALLOCATED variable.
104 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
106 Remove invocations of doprnt, as Emacs now uses vsnprintf.
107 But keep the doprint source code for now, as we might revamp it
108 and use it again (Bug#8435).
109 * lisp.h (doprnt): Remove.
110 * Makefile.in (base_obj): Remove doprnt.o.
111 * deps.mk (doprnt.o): Remove.
113 error: Print 32- and 64-bit integers portably (Bug#8435).
114 Without this change, on typical 64-bit hosts error ("...%d...", N)
115 was used to print both 32- and 64-bit integers N, which relied on
117 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
119 * lisp.h (error, verror): Mark as printf-like functions.
120 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
121 Report overflow in size calculations when allocating printf buffer.
122 Do not truncate output string at its first null byte.
123 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
124 Truncate the output at a character boundary, since vsnprintf does not
126 * charset.c (check_iso_charset_parameter): Convert internal
127 character to string before calling 'error', since %c now has the
129 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
130 overflow when computing char to be passed to 'error'. Do not
131 pass Lisp_Object to 'error'; pass the integer instead.
132 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
133 formatted with plain %d.
135 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
137 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
139 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
141 * xterm.c (x_catch_errors): Remove duplicate declaration.
143 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
145 * xdisp.c, lisp.h (message_nolog): Remove; unused.
147 2011-04-10 Jim Meyering <meyering@redhat.com>
149 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
150 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
151 return ssize_t not "int", and use size_t as the buffer length.
152 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
153 * gnutls.h: Update declarations.
154 * process.c (read_process_output): Use ssize_t, to match.
155 (send_process): Likewise.
157 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
159 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
161 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
163 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
164 unsigned char, to match FcChar8 type definition.
166 * xterm.c (handle_one_xevent):
167 * xmenu.c (create_and_show_popup_menu):
168 * xselect.c (x_decline_selection_request)
169 (x_reply_selection_request): Avoid type-punned deref of X events.
171 2011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
173 Fix some uses of `int' instead of EMACS_INT.
174 * search.c (string_match_1, fast_string_match)
175 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
176 (scan_buffer, find_next_newline_no_quit)
177 (find_before_next_newline, search_command, Freplace_match)
178 (Fmatch_data): Make some `int' variables be EMACS_INT.
180 * xdisp.c (display_count_lines): 3rd argument and return value now
181 EMACS_INT. All callers changed.
182 (pint2hrstr): Last argument is now EMACS_INT.
184 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
185 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
186 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
187 (decode_coding_utf_16, decode_coding_emacs_mule)
188 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
189 (decode_coding_ccl, decode_coding_charset)
190 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
191 (decode_coding_iso_2022, decode_coding_emacs_mule)
192 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
193 <char_offset, last_offset>: Declare EMACS_INT.
194 (encode_coding_utf_8, encode_coding_utf_16)
195 (encode_coding_emacs_mule, encode_invocation_designation)
196 (encode_designation_at_bol, encode_coding_iso_2022)
197 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
198 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
200 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
201 (encode_invocation_designation): Last argument P_NCHARS is now
203 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
204 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
206 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
209 * ccl.c (Fccl_execute_on_string): Declare some variables
212 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
214 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
216 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
218 * process.c (Fformat_network_address): Doc fix.
220 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
222 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
224 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
226 * keyboard.c (read_char): Call Lisp function help-form-show,
227 instead of using internal_with_output_to_temp_buffer.
228 (Qhelp_form_show): New var.
229 (syms_of_keyboard): Use DEFSYM macro.
231 * print.c (internal_with_output_to_temp_buffer): Function deleted.
233 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
235 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
237 * process.c (Flist_processes): Removed to Lisp.
238 (list_processes_1): Deleted.
240 2011-04-06 Eli Zaretskii <eliz@gnu.org>
242 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
244 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
246 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
248 Fix more problems found by GCC 4.6.0's static checks.
250 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
252 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
254 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
256 * xdisp.c (vmessage): Mark as a printf-like function.
258 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
260 * sound.c (sound_warning): Don't crash if arg contains a printf format.
262 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
263 printf-like functions.
264 (tiff_load): Add casts to remove these marks before passing them
265 to system-supplied API.
267 * eval.c (Fsignal): Remove excess argument to 'fatal'.
269 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
270 This avoids several warnings with gcc -Wstrict-overflow.
271 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
272 directly, rather than having caller test rule sign. This avoids
273 some unnecessary tests.
274 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
275 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
276 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
278 * xfont.c (xfont_text_extents): Remove var that was set but not used.
279 (xfont_open): Avoid unnecessary tests.
281 * composite.c (composition_gstring_put_cache): Use unsigned integer.
283 * composite.h, composite.c (composition_gstring_put_cache):
284 Use EMACS_INT, not int, for length.
286 * composite.h (COMPOSITION_DECODE_REFS): New macro,
287 breaking out part of COMPOSITION_DECODE_RULE.
288 (COMPOSITION_DECODE_RULE): Use it.
289 * composite.c (get_composition_id): Remove unused local vars,
290 by using the new macro.
292 * textprop.c (set_text_properties_1): Change while to do-while,
293 since the condition is always true at first.
295 * intervals.c (graft_intervals_into_buffer): Mark var as used.
296 (interval_deletion_adjustment): Return unsigned value.
299 * process.c (list_processes_1, create_pty, read_process_output):
300 (exec_sentinel): Remove vars that were set but not used.
301 (create_pty): Remove unnecessary "volatile"s.
302 (Fnetwork_interface_info): Avoid possibility of int overflow.
303 (read_process_output): Do adaptive read buffering even if carryover.
304 (read_process_output): Simplify nbytes computation if buffered.
306 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
308 * syntax.c (scan_words): Remove var that was set but not used.
309 (update_syntax_table): Use unsigned instead of int.
311 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
312 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
313 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
315 * print.c (print_error_message): Avoid int overflow.
317 * font.c (font_list_entities): Redo for clarity,
318 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
320 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
321 (font_score): Avoid potential overflow in diff calculation.
323 * fns.c (substring_both): Remove var that is set but not used.
324 (sxhash): Redo loop for clarity and to avoid wraparound warning.
326 * eval.c (funcall_lambda): Rename local to avoid shadowing.
328 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
329 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
330 can always succeed if overflow has undefined behavior.
332 * search.c (boyer_moore, wordify): Remove vars set but not used.
333 (wordify): Omit three unnecessary tests.
335 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
336 All callers changed. This avoids the need for an unused var.
338 * casefiddle.c (casify_region): Remove var that is set but not used.
340 * dired.c (file_name_completion): Remove var that is set but not used.
342 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
344 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
345 (Finsert_file_contents): Remove unnecessary code checking fd.
347 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
348 Check for integer overflow on size calculations.
350 * buffer.c (Fprevious_overlay_change): Remove var that is set
353 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
354 Remove vars that are set but not used.
355 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
356 (timer_check_2): Mark vars as initialized.
358 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
360 * image.c (lookup_image): Remove var that is set but not used.
361 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
363 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
364 that are set but not used.
366 * xfns.c (make_invisible_cursor): Don't return garbage
367 if XCreateBitmapFromData fails (Bug#8410).
369 * xselect.c (x_get_local_selection, x_handle_property_notify):
370 Remove vars that are set but not used.
372 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
373 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
375 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
376 Remove var that is set but not used.
377 (scroll_bar_windows_size): Now size_t, not int.
378 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
381 * xfaces.c (realize_named_face): Remove vars that are set but not used.
382 (map_tty_color) [!defined MSDOS]: Likewise.
384 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
386 * coding.c: Remove vars that are set but not used.
387 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
389 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
390 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
391 (decode_coding_charset): Remove vars that are set but not used.
393 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
394 that is set but not used.
396 * print.c (print_object): Remove var that is set but not used.
398 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
399 The gnulib version avoids calling malloc in the usual case,
400 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
401 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
402 * filelock.c (current_lock_owner): Likewise.
403 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
404 * sysdep.c: Include allocator.h, careadlinkat.h.
405 (emacs_no_realloc_allocator): New static constant.
406 (emacs_readlink): New function.
407 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
408 ../lib/careadlinkat.h.
410 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
412 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
413 first non-nil return value).
415 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
417 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
418 if not defined (Bug#8403).
420 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
422 * xdisp.c (display_count_lines): Remove parameter `start',
423 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
424 (get_char_face_and_encoding): Remove parameter `multibyte_p',
425 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
426 (fill_stretch_glyph_string): Remove parameters `row' and `area',
427 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
428 and thereabouts. All callers changed.
429 (get_per_char_metric): Remove parameter `f', unused since
430 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
432 2011-04-02 Jim Meyering <meyering@redhat.com>
434 do not dereference NULL upon failed strdup
435 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
436 (ns_get_family): Likewise.
438 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
440 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
442 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
444 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
447 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
451 * window.c (Ftemp_output_buffer_show): New fun.
452 (Fsave_window_excursion):
453 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
455 * lread.c (lisp_file_lexically_bound_p): New function.
456 (Fload): Bind Qlexical_binding.
457 (readevalloop): Remove `evalfun' arg.
458 Bind Qinternal_interpreter_environment.
459 (Feval_buffer): Bind Qlexical_binding.
460 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
462 (syms_of_lread): Declare `lexical-binding'.
464 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
466 * keyboard.c (eval_dyn): New fun.
467 (menu_item_eval_property): Use it.
469 * image.c (parse_image_spec): Use Ffunctionp.
471 * fns.c (concat, mapcar1): Accept byte-code-functions.
473 * eval.c (Fsetq): Handle lexical vars.
474 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
475 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
476 (FletX, Flet): Obey lexical binding.
477 (Fcommandp): Handle closures.
478 (Feval): New `lexical' arg.
479 (eval_sub): New function extracted from Feval. Use it almost
480 everywhere where Feval was used. Look up vars in lexical env.
482 (Ffunctionp): Move from subr.el.
483 (Ffuncall): Handle closures.
484 (apply_lambda): Remove `eval_flags'.
485 (funcall_lambda): Handle closures and new byte-code-functions.
486 (Fspecial_variable_p): New function.
487 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
488 but without exporting it to Lisp.
490 * doc.c (Fdocumentation, store_function_docstring):
491 * data.c (Finteractive_form): Handle closures.
493 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
496 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
498 (exec_byte_code): New function extracted from Fbyte_code to handle new
499 calling convention for byte-code-functions. Add new byte-codes.
501 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
503 * alloc.c (Fmake_symbol): Init new `declared_special' field.
505 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
507 * xdisp.c (redisplay_internal): Fix prototype.
509 2011-03-31 Eli Zaretskii <eliz@gnu.org>
511 * xdisp.c (SCROLL_LIMIT): New macro.
512 (try_scrolling): Use it when setting scroll_limit. Limit
513 scrolling to 100 screen lines.
514 (redisplay_window): Even when falling back on "recentering",
515 position point in the window according to scroll-conservatively,
516 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
518 (try_scrolling): When point is above the window, allow searching
519 as far as scroll_max, or one screenful, to compute vertical
520 distance from PT to the scroll margin position. This prevents
521 try_scrolling from unnecessarily failing when
522 scroll-conservatively is set to a value slightly larger than the
523 window height. Clean up the case of PT below the margin at bottom
524 of window: scroll_max can no longer be INT_MAX. When aggressive
525 scrolling is in use, don't let point enter the opposite scroll
526 margin as result of the scroll.
527 (syms_of_xdisp) <scroll-conservatively>: Document the
528 threshold of 100 lines for never-recentering scrolling.
530 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
532 * dispextern.h (move_it_by_lines):
533 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
534 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
535 (message_log_check_duplicate): Remove parameters `prev_bol' and
536 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
537 (redisplay_internal): Remove parameter `preserve_echo_area',
538 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
540 * indent.c (Fvertical_motion):
541 * window.c (window_scroll_pixel_based, Frecenter):
542 Don't pass `need_y_p' to `move_it_by_lines'.
544 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
546 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
547 steal a few bits to be more compact.
548 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
549 Remove unneeded casts.
551 * bytecode.c (Fbyte_code): CAR and CDR can GC.
553 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
555 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
556 binding" message (bug#7967).
558 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
560 Fix more problems found by GCC 4.6.0's static checks.
562 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
563 Remove unused local var.
565 * editfns.c (Fmessage_box): Remove unused local var.
567 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
568 (note_mode_line_or_margin_highlight, note_mouse_highlight):
569 Omit unused local vars.
570 * window.c (shrink_windows): Omit unused local var.
571 * menu.c (digest_single_submenu): Omit unused local var.
572 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
573 Omit unused local var.
575 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
576 Don't assume string length fits in int.
577 (keyremap_step, read_key_sequence): Use size_t for sizes.
578 (read_key_sequence): Don't check last_real_key_start redundantly.
580 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
581 instead of alloca (Bug#8344).
583 * eval.c (Fbacktrace): Don't assume nargs fits in int.
584 (Fbacktrace_frame): Don't assume nframes fits in int.
586 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
588 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
591 * term.c (produce_glyphless_glyph): Remove unnecessary test.
593 * cm.c (calccost): Turn while-do into do-while, for clarity.
595 * keyboard.c (syms_of_keyboard): Use the same style as later
596 in this function when indexing through an array. This also
597 works around GCC bug 48267.
599 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
601 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
603 * chartab.c (sub_char_table_ref_and_range): Redo for slight
604 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
606 * keyboard.c, keyboard.h (num_input_events): Now size_t.
607 This avoids undefined behavior on integer overflow, and is a bit
608 more convenient anyway since it is compared to a size_t variable.
610 Variadic C functions now count arguments with size_t, not int.
611 This avoids an unnecessary limitation on 64-bit machines, which
612 caused (substring ...) to crash on large vectors (Bug#8344).
613 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
614 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
615 All variadic functions and their callers changed accordingly.
616 (struct gcpro.nvars): Now size_t, not int. All uses changed.
617 * data.c (arith_driver, float_arith_driver): Likewise.
618 * editfns.c (general_insert_function): Likewise.
619 * eval.c (struct backtrace.nargs, interactive_p)
620 (internal_condition_case_n, run_hook_with_args, apply_lambda)
621 (funcall_lambda, mark_backtrace): Likewise.
622 * fns.c (concat): Likewise.
623 * frame.c (x_set_frame_parameters): Likewise.
624 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
625 0 if not found, not -1. All callers changed.
627 * alloc.c (garbage_collect): Don't assume stack size fits in int.
628 (stack_copy_size): Now size_t, not int.
629 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
631 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
633 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
634 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
637 * lisp.h (multibyte_char_to_unibyte):
638 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
639 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
640 * character.h (CHAR_TO_BYTE8):
641 * cmds.c (internal_self_insert):
642 * editfns.c (general_insert_function):
643 * keymap.c (push_key_description):
644 * search.c (Freplace_match):
645 * xdisp.c (message_dolog, set_message_1): All callers changed.
647 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
649 * keyboard.c (safe_run_hook_funcall): New function.
650 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
651 don't set the hook to nil, but remove the offending function instead.
652 (Qcommand_hook_internal): Remove, unused.
653 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
654 Vcommand_hook_internal.
656 * eval.c (enum run_hooks_condition): Remove.
657 (funcall_nil, funcall_not): New functions.
658 (run_hook_with_args): Call each function through a `funcall' argument.
659 Remove `cond' argument, now redundant.
660 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
661 (Frun_hook_with_args_until_failure): Adjust accordingly.
662 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
664 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
666 * dispextern.h (string_buffer_position): Remove declaration.
668 * print.c (strout): Remove parameter `multibyte', unused since
669 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
671 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
672 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
675 * w32.c (_wsa_errlist): Use braces for struct initializers.
677 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
678 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
680 (string_buffer_position): Likewise. Also, make static (it's never
681 used outside xdisp.c).
682 (cursor_row_p): Remove parameter `w', unused since
683 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
684 (decode_mode_spec): Remove parameter `precision', introduced during
685 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
688 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
690 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
692 2011-03-27 Anders Lindgren <andlind@gmail.com>
694 * nsterm.m (ns_menu_bar_is_hidden): New variable.
695 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
696 (ns_update_auto_hide_menu_bar): New functions.
697 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
698 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
699 ns_constrain_all_frames.
700 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
701 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
703 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
705 * nsmenu.m (runDialogAt): Remove argument to timer_check.
707 2011-03-27 Glenn Morris <rgm@gnu.org>
709 * syssignal.h: Replace RETSIGTYPE with void.
710 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
711 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
712 Replace SIGTYPE with void everywhere.
713 * s/usg5-4-common.h (SIGTYPE): Remove definition.
714 * s/template.h (SIGTYPE): Remove commented out definition.
716 2011-03-26 Eli Zaretskii <eliz@gnu.org>
718 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
719 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
721 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
723 * w32.c (read_unc_volume): Use parameter `henum', instead of
724 global variable `wget_enum_handle'.
726 * keymap.c (describe_vector): Remove parameters `indices' and
727 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
728 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
730 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
732 * keyboard.c (timer_check): Remove parameter `do_it_now',
733 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
734 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
735 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
737 * keyboard.c (read_char):
738 * w32menu.c (w32_menu_display_help):
739 * xmenu.c (show_help_event, menu_help_callback):
740 Adjust calls to `show_help_echo'.
742 * gtkutil.c (xg_maybe_add_timer):
743 * keyboard.c (readable_events):
744 * process.c (wait_reading_process_output):
745 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
747 * insdel.c (adjust_markers_gap_motion):
748 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
749 (gap_left, gap_right): Don't call it.
751 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
753 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
754 incurred during fontification.
756 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
758 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
759 (DEFVAR_PER_BUFFER): Don't pass it.
761 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
762 (scrolling_window): Don't pass it.
764 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
766 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
768 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
770 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
771 of variables specific to SELinux and computation of `encoded_absname'.
773 * image.c (XPutPixel): Remove unused variable `height'.
775 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
777 * unexw32.c (get_section_info): Remove unused variable `section'.
779 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
780 (system_process_attributes): Remove unused variable `sess'.
781 (sys_read): Remove unused variable `err'.
783 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
784 (w32_wnd_proc): Remove unused variable `isdead'.
785 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
786 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
787 (x_create_tip_frame): Remove unused variable `tem'.
789 * w32inevt.c (w32_console_read_socket):
790 Remove unused variable `no_events'.
792 * w32term.c (x_draw_composite_glyph_string_foreground):
793 Remove unused variable `width'.
795 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
797 * w32term.c (x_set_glyph_string_clipping):
798 Don't pass uninitialized region to CombineRgn.
800 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
802 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
803 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
804 (Fx_close_connection): Remove unused variable `i'.
806 * w32font.c (w32font_draw): Return number of glyphs.
807 (w32font_open_internal): Remove unused variable `i'.
808 (w32font_driver): Add missing initializer.
810 * w32menu.c (utf8to16): Remove unused variable `utf16'.
811 (fill_in_menu): Remove unused variable `items_added'.
813 * w32term.c (last_mouse_press_frame): Remove static global variable.
814 (w32_clip_to_row): Remove unused variable `f'.
815 (x_delete_terminal): Remove unused variable `i'.
817 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
818 (NOTHING): Remove unused static global variable.
819 (uniscribe_check_otf): Remove unused variable `table'.
820 (uniscribe_font_driver): Add missing initializers.
822 2011-03-23 Julien Danjou <julien@danjou.info>
824 * term.c (Fsuspend_tty, Fresume_tty):
825 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
826 * window.c (temp_output_buffer_show):
827 * insdel.c (signal_before_change):
828 * frame.c (Fhandle_switch_frame):
829 * fileio.c (Fdo_auto_save):
830 * emacs.c (Fkill_emacs):
831 * editfns.c (save_excursion_restore):
832 * cmds.c (internal_self_insert):
833 * callint.c (Fcall_interactively):
834 * buffer.c (Fkill_all_local_variables):
835 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
837 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
838 unconditionnaly since it does the check itself.
840 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
842 Fix more problems found by GCC 4.5.2's static checks.
844 * coding.c (encode_coding_raw_text): Avoid unnecessary test
845 the first time through the loop, since we know p0 < p1 then.
846 This also avoids a gcc -Wstrict-overflow warning.
848 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
849 leading to a memory leak, possible in functions like
850 load_charset_map_from_file that can allocate an unbounded number
851 of objects (Bug#8318).
853 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
854 that could (at least in theory) be that large.
856 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
857 This is less likely to overflow, and avoids undefined behavior if
858 overflow does occur. All callers changed. Use strtoul to scan
859 for the unsigned long integer.
860 (pint2hrstr): Simplify and tune code slightly.
861 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
863 * scroll.c (do_scrolling): Work around GCC bug 48228.
864 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
866 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
867 This also avoids a warning with gcc -Wstrict-overflow.
868 (validate_x_resource_name): Simplify count usage.
869 This also avoids a warning with gcc -Wstrict-overflow.
871 * fileio.c (Fcopy_file): Report error if fchown or fchmod
874 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
876 * process.c (Fmake_network_process): Use socklen_t, not int,
877 where POSIX says socklen_t is required in portable programs.
878 This fixes a porting bug on hosts like 64-bit HP-UX, where
879 socklen_t is wider than int (Bug#8277).
880 (Fmake_network_process, server_accept_connection):
881 (wait_reading_process_output, read_process_output):
884 * process.c: Rename or move locals to avoid shadowing.
885 (list_processes_1, Fmake_network_process):
886 (read_process_output_error_handler, exec_sentinel_error_handler):
887 Rename or move locals.
888 (Fmake_network_process): Define label "retry_connect" only if needed.
889 (Fnetwork_interface_info): Fix pointer signedness.
890 (process_send_signal): Add cast to avoid pointer signedness problem.
891 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
892 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
894 Make tparam.h and terminfo.c consistent.
895 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
896 Include tparam.h instead, since it declares them.
897 * cm.h (PC): Remove extern decl; tparam.h now does this.
898 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
899 * terminfo.c: Include tparam.h, to check interfaces.
900 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
901 (tparam): Adjust signature to match interface in tparam.h;
902 this removes some undefined behavior. Check that outstring and len
903 are zero, which they always are with Emacs.
904 * tparam.h (PC, BC, UP): New extern decls.
906 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
907 (xftfont_open): Rename locals to avoid shadowing.
909 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
910 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
911 (OTF_TAG_SYM): Omit macro if not needed.
912 (ftfont_list): Remove unused local.
913 (get_adstyle_property, ftfont_pattern_entity):
914 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
915 Rename locals to avoid shadowing.
917 * xfont.c (xfont_list_family): Mark var as initialized.
919 * xml.c (make_dom): Now static.
921 * composite.c (composition_compute_stop_pos): Rename local to
923 (composition_reseat_it): Remove unused locals.
924 (find_automatic_composition, composition_adjust_point): Likewise.
925 (composition_update_it): Mark var as initialized.
926 (find_automatic_composition): Mark vars as initialized,
927 with a FIXME (Bug#8290).
929 character.h: Rename locals to avoid shadowing.
930 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
931 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
932 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
933 (BUF_DEC_POS): Be more systematic about renaming local temporaries
936 * textprop.c (property_change_between_p): Remove; unused.
938 * intervals.c (interval_start_pos): Now static.
940 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
942 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
943 Rename locals to avoid shadowing.
945 * sound.c (wav_play, au_play, Fplay_sound_internal):
946 Fix pointer signedness.
947 (alsa_choose_format): Remove unused local var.
948 (wav_play): Initialize a variable to 0, to prevent undefined
951 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
953 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
955 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
956 clobbering (Bug#8298).
957 * sysdep.c (sys_subshell): Likewise.
958 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
960 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
961 This should get cleaned up, so that child_setup has the
962 same signature on all platforms.
964 * callproc.c (call_process_cleanup): Now static.
965 (relocate_fd): Rename locals to avoid shadowing.
967 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
969 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
970 not to be necessary, and produces flickering.
972 2011-03-20 Glenn Morris <rgm@gnu.org>
974 * config.in: Remove file.
976 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
978 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
979 are now in src/globals.h.
980 (syms_of_minibuf): Remove spurious & from previous change.
982 2011-03-20 Leo <sdl.web@gmail.com>
984 * minibuf.c (completing-read-function): New variable.
985 (completing-read-default): Rename from completing-read.
986 (completing-read): Call completing-read-function.
988 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
990 * xfaces.c (Fx_load_color_file):
991 Read color file from absolute filename (bug#8250).
993 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
995 * makefile.w32-in: Update dependencies.
997 2011-03-17 Eli Zaretskii <eliz@gnu.org>
999 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1001 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1003 Fix more problems found by GCC 4.5.2's static checks.
1005 * process.c (make_serial_process_unwind, send_process_trap):
1006 (sigchld_handler): Now static.
1008 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1009 That way, the code declares only the vars that it needs.
1010 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1011 * s/cygwin.h (PTY_ITERATION): Likewise.
1012 * s/darwin.h (PTY_ITERATION): Likewise.
1013 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1015 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1016 * process.c (allocate_pty): Don't declare stb unless it's needed.
1018 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1019 (CONSTANTLIM): Remove; unused.
1020 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1021 Define only if needed.
1023 * unexelf.c (unexec): Name an expression,
1024 to avoid gcc -Wbad-function-cast warning.
1025 Use a different way to cause a compilation error if anyone uses
1026 n rather than nn, a way that does not involve shadowing.
1027 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1029 * deps.mk (unexalpha.o): Remove; unused.
1031 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1032 * unexec.h: New file.
1033 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1034 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1036 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1037 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1038 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1039 Change as necessary to match prototype in unexec.h.
1041 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1043 (back_comment, skip_chars): Mark vars as initialized.
1045 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1046 Rename locals to avoid shadowing.
1048 * lread.c (read1): Rewrite so as not to use empty "else".
1049 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1051 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1053 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1054 warning when compiling print.c.
1056 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1057 instead of using an uninitialized var.
1058 (font_sort_entities): Mark var as initialized.
1060 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1062 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1063 pointers to constants.
1064 (font_parse_fcname): Remove unused vars.
1065 (font_delete_unmatched): Now static.
1066 (font_get_spec): Remove; unused.
1067 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1068 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1069 Rename or move locals to avoid shadowing.
1071 * fns.c (require_nesting_list, require_unwind): Now static.
1072 (Ffillarray): Rename locals to avoid shadowing.
1074 * floatfns.c (domain_error2): Define only if needed.
1075 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1077 * alloc.c (mark_backtrace): Move decl from here ...
1078 * lisp.h: ... to here, so that it can be checked.
1080 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1081 (Fdefvar): Rewrite so as not to use empty "else".
1082 (lisp_indirect_variable): Name an expression,
1083 to avoid gcc -Wbad-function-cast warning.
1084 (Fdefvar): Rename locals to avoid shadowing.
1086 * callint.c (quotify_arg, quotify_args): Now static.
1087 (Fcall_interactively): Rename locals to avoid shadowing.
1088 Use const pointer when appropriate.
1090 * lisp.h (get_system_name, get_operating_system_release):
1091 Move decls here, to check interfaces.
1092 * process.c (get_operating_system_release): Move decl to lisp.h.
1093 * xrdb.c (get_system_name): Likewise.
1094 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1095 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1096 some of which prompt warnings from gcc -Wbad-function-cast.
1097 (Fformat_time_string, Fencode_time, Finsert_char):
1098 (Ftranslate_region_internal, Fformat):
1099 Rename or remove local vars to avoid shadowing.
1100 (Ftranslate_region_internal): Mark var as initialized.
1102 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1105 * lisp.h (eassert): Check that the argument compiles, even if
1106 ENABLE_CHECKING is not defined.
1108 * data.c (Findirect_variable): Name an expression, to avoid
1109 gcc -Wbad-function-cast warning.
1110 (default_value, arithcompare, arith_driver, arith_error): Now static.
1111 (store_symval_forwarding): Rename local to avoid shadowing.
1112 (Fmake_variable_buffer_local, Fmake_local_variable):
1113 Mark variables as initialized.
1114 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1116 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1117 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1118 Rename locals to avoid shadowing.
1119 (mark_stack): Move local variables into the #ifdef region where
1121 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1122 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1124 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1125 (GC_STRING_CHARS): Remove; not used.
1126 (Fmemory_limit): Cast sbrk's returned value to char *.
1128 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1129 avoids undefined behavior in theory.
1131 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1133 Use functions, not macros, for up- and down-casing (Bug#8254).
1134 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1135 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1136 to use the following functions instead of these macros.
1137 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1138 EMACS_INT, since callers assume the returned value fits in int.
1139 (upcase1): Likewise, for UPCASE_TABLE.
1140 (uppercasep, lowercasep, upcase): New static inline functions.
1141 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1142 the race-condition problem in the old DOWNCASE.
1144 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1145 Rename locals to avoid shadowing.
1146 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1147 (regex_compile, re_search_2, re_match_2_internal):
1148 Remove unused local vars.
1149 (FREE_VAR): Rewrite so as not to use empty "else",
1150 which gcc can warn about.
1151 (regex_compile, re_match_2_internal): Mark locals as initialized.
1152 (RETALLOC_IF): Define only if needed.
1153 (WORDCHAR_P): Likewise. This one is never needed, but is used
1154 only in a comment talking about a compiler bug, so put inside
1155 the #if 0 of that comment.
1156 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1157 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1160 * search.c (boyer_moore): Rename locals to avoid shadowing.
1161 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1162 (PREV_CHAR_BOUNDARY): Likewise.
1164 * search.c (simple_search): Remove unused var.
1166 * dired.c (compile_pattern): Move decl from here ...
1167 * lisp.h: ... to here, so that it can be checked.
1168 (struct re_registers): New forward decl.
1170 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1172 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1174 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1175 Rename locals to avoid shadowing.
1176 (Fvertical_motion): Mark locals as initialized.
1178 * casefiddle.c (casify_object, casify_region): Now static.
1179 (casify_region): Mark local as initialized.
1181 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1183 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1184 New macros, so that the caller can use some names other than
1185 gcpro1, gcpro2, etc.
1186 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1188 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1189 argument, for consistency with GCPRO2_VAR, etc: it is now the
1190 prefix of the variable, not the variable itself. All uses
1192 * dired.c (directory_files_internal, file_name_completion):
1193 Rename locals to avoid shadowing.
1195 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1196 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1197 dired.c's scmp function, had undefined behavior.
1198 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1199 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1200 * buffer.h: ... to here, because these macros use current_buffer,
1201 and the new implementation with inline functions needs to have
1202 current_buffer in scope now, rather than later when the macros
1204 (downcase, upcase1): New static inline functions.
1205 (DOWNCASE, UPCASE1): Reimplement using these functions.
1206 This avoids undefined behavior in expressions like
1207 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1208 from race conditions in accessing the global variables
1209 case_temp1 and case_temp2.
1210 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1211 * lisp.h (case_temp1, case_temp2): Remove their decls.
1212 * character.h (ASCII_CHAR_P): Move from here ...
1213 * lisp.h: ... to here, so that the inline functions mentioned
1216 * dired.c (directory_files_internal_unwind): Now static.
1218 * fileio.c (file_name_as_directory, directory_file_name):
1219 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1221 (file_name_as_directory): Use const pointers when appropriate.
1222 (Fexpand_file_name): Likewise. In particular, newdir might
1223 point at constant storage, so make it a const pointer.
1224 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1225 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1227 (Fset_file_times, Finsert_file_contents, auto_save_error):
1228 Rename locals to avoid shadowing.
1230 * minibuf.c (choose_minibuf_frame_1): Now static.
1231 (Ftry_completion, Fall_completions): Rename or remove locals
1234 * marker.c (bytepos_to_charpos): Remove; unused.
1236 * lisp.h (verify_bytepos, count_markers): New decls,
1237 so that gcc does not warn that these functions aren't declared.
1239 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1240 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1241 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1242 (copy_text): Remove unused local var.
1244 * filelock.c (within_one_second): Now static.
1245 (lock_file_1): Rename local to avoid shadowing.
1247 * buffer.c (fix_overlays_before): Mark locals as initialized.
1248 (fix_start_end_in_overlays): Likewise. This function should be
1249 simplified by using pointers-to-pointers, but that's a different
1251 (switch_to_buffer_1): Now static.
1252 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1253 (report_overlay_modification): Rename locals to avoid shadowing.
1255 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1256 Fix pointer signedness issue.
1257 (sys_subshell): Mark local as volatile if checking for lint,
1258 to suppress a gcc -Wclobbered warning that does not seem to be right.
1259 (MAXPATHLEN): Define only if needed.
1261 * process.c (serial_open, serial_configure): Move decls from here ...
1262 * systty.h: ... to here, so that they can be checked.
1264 * fns.c (get_random, seed_random): Move extern decls from here ...
1265 * lisp.h: ... to here, so that they can be checked.
1267 * sysdep.c (reset_io): Now static.
1268 (wait_for_termination_signal): Remove; unused.
1270 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1271 (copy_keymap_item, append_key, push_text_char_description):
1273 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1274 (DENSE_TABLE_SIZE): Remove; unused.
1275 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1276 (describe_map_tree):
1277 Rename locals to avoid shadowing.
1279 * keyboard.c: Declare functions static if they are not used elsewhere.
1280 (echo_char, echo_dash, cmd_error, top_level_2):
1281 (poll_for_input, handle_async_input): Now static.
1282 (read_char, kbd_buffer_get_event, make_lispy_position):
1283 (make_lispy_event, make_lispy_movement, apply_modifiers):
1284 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1285 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1286 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1287 (read_key_sequence, read_char): Mark locals as initialized.
1288 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1290 * keyboard.h (make_ctrl_char): New decl.
1291 (mark_kboards): Move decl here ...
1292 * alloc.c (mark_kboards): ... from here.
1294 * lisp.h (force_auto_save_soon): New decl.
1296 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1297 (DEFINE_DUMMY_FUNCTION): New macro.
1298 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1300 (main): Add casts to avoid warnings
1301 if GCC considers string literals to be constants.
1303 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1305 * dbusbind.c: Pointer signedness fixes.
1306 (xd_signature, xd_append_arg, xd_initialize):
1307 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1308 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1309 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1310 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1312 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1313 if GCC considers string literals to be constants.
1314 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1316 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1318 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1319 (print_preprocess, print_object): New macro to fix last change.
1321 * print.c (print_preprocess): Don't forget font objects.
1323 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1325 * emacs.c (USAGE3): Doc fixes.
1327 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1329 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1332 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1334 * lisp.h (VWindow_system, Qfile_name_history):
1335 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1336 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1337 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1339 * w32select.c: Don't #include "keyboard.h".
1340 (run_protected): Add extern declaration for waiting_for_input.
1342 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1343 * w32console.c (detect_input_pending, read_input_pending)
1344 (encode_terminal_code):
1345 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1346 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1347 (w32_system_caret_y, Qfile_name_history):
1348 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1349 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1350 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1351 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1352 * w32proc.c (Qlocal, report_file_error):
1353 * w32term.c (Vwindow_system, updating_frame):
1354 * w32uniscribe.c (initialized, uniscribe_font_driver):
1355 Remove unneeded extern declarations.
1357 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1359 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1361 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1363 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1364 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1365 These macros can no longer be used for assignment.
1367 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1368 Assign struct members directly, instead of using BUF_BEGV etc.
1369 (record_buffer_markers, fetch_buffer_markers): New functions for
1370 recording and fetching special buffer markers.
1371 (set_buffer_internal_1, set_buffer_temp): Use them.
1373 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1375 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1377 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1378 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1380 * xdisp.c (hscroll_window_tree):
1381 (reconsider_clip_changes): Use PT instead of BUF_PT.
1383 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1385 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1386 $(EMACS_ROOT)/lib/intprops.h.
1388 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1390 Fix more problems found by GCC 4.5.2's static checks.
1392 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1393 to unsigned char * to avoid compiler diagnostic.
1394 (xg_free_frame_widgets): Make it clear that a local variable is
1395 needed only if USE_GTK_TOOLTIP.
1396 (gdk_window_get_screen): Make it clear that this macro is needed
1397 only if USE_GTK_TOOLTIP.
1398 (int_gtk_range_get_value): New function, which avoids a diagnostic
1399 from gcc -Wbad-function-cast.
1400 (xg_set_toolkit_scroll_bar_thumb): Use it.
1401 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1402 diagnostic from gcc -Wbad-function-cast.
1403 (get_utf8_string, xg_get_file_with_chooser):
1404 Rename locals to avoid shadowing.
1405 (create_dialog): Move locals to avoid shadowing.
1407 * xgselect.c (xg_select): Remove unused var.
1409 * image.c (four_corners_best): Mark locals as initialized.
1410 (gif_load): Initialize transparent_p to zero (Bug#8238).
1411 Mark another local as initialized.
1412 (my_png_error, my_error_exit): Mark with NO_RETURN.
1414 * image.c (clear_image_cache): Now static.
1415 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1416 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1417 (x_edge_detection): Remove unnecessary cast that
1418 gcc -Wbad-function-cast diagnoses.
1419 (gif_load): Fix pointer signedness.
1420 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1421 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1423 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1425 Improve quality of tests for time stamp overflow.
1426 For example, without this patch (encode-time 0 0 0 1 1
1427 1152921504606846976) returns the obviously-bogus value (-948597
1428 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1429 reports time overflow. See
1430 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1431 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1432 * editfns.c: Include limits.h and intprops.h.
1433 (TIME_T_MIN, TIME_T_MAX): New macros.
1434 (time_overflow): Move earlier, to before first use.
1435 (hi_time, lo_time): New functions, for an accurate test for
1437 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1438 (Fget_internal_run_time): Don't assume time_t fits in int.
1439 (make_time): Use list2 instead of Fcons twice.
1440 (Fdecode_time): More accurate test for out-of-range times.
1441 (check_tm_member): New function.
1442 (Fencode_time): Use it, to test for out-of-range times.
1443 (lisp_time_argument): Don't rely on undefined left-shift and
1444 right-shift behavior when checking for time stamp overflow.
1446 * editfns.c (time_overflow): New function, refactoring common code.
1447 (Fformat_time_string, Fdecode_time, Fencode_time):
1448 (Fcurrent_time_string): Use it.
1450 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1451 * dired.c (make_time): Move to ...
1452 * editfns.c (make_time): ... here.
1453 * systime.h: Note the move.
1455 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1457 * fringe.c (update_window_fringes): Remove unused variables.
1459 * unexmacosx.c (copy_data_segment): Also copy __got section.
1462 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1464 * termcap.c [MSDOS]: Include "msdos.h".
1465 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1466 Constify `char *' arguments and their references according to
1467 prototypes in tparam.h.
1469 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1471 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1472 Adapt all references accordingly.
1474 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1476 2011-03-11 Tom Tromey <tromey@redhat.com>
1478 * buffer.c (syms_of_buffer): Remove obsolete comment.
1480 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1482 * termhooks.h (encode_terminal_code): Declare prototype.
1484 * msdos.c (encode_terminal_code): Don't declare prototype.
1486 * term.c (encode_terminal_code): Now external again, used by
1487 w32console.c and msdos.c.
1489 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1490 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1492 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1494 Fix some minor problems found by GCC 4.5.2's static checks.
1496 * fringe.c (update_window_fringes): Mark locals as initialized
1498 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1500 * alloc.c (mark_fringe_data): Move decl from here ...
1501 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1502 to check its interface.
1503 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1505 * fontset.c (free_realized_fontset): Now static.
1506 (Fset_fontset_font): Rename local to avoid shadowing.
1507 (fontset_font): Mark local as initialized.
1508 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1510 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1512 * xselect.c (x_disown_buffer_selections): Remove; not used.
1513 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1514 (x_own_selection, Fx_disown_selection_internal): Rename locals
1516 (x_handle_dnd_message): Remove local to avoid shadowing.
1518 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1519 so that the caller can use some name other than gcpro1.
1520 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1521 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1522 (Fx_backspace_delete_keys_p):
1523 Use them to avoid shadowing, and rename vars to avoid shadowing.
1524 (x_decode_color, x_set_name, x_window): Now static.
1525 (Fx_create_frame): Add braces to silence GCC warning.
1526 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1527 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1528 Remove unused locals.
1529 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1530 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1531 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1534 * xterm.h (x_mouse_leave): New decl.
1536 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1537 Remove unused functions.
1538 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1539 (x_calc_absolute_position): Now static.
1540 (XTread_socket): Don't define label "out" unless it's used.
1541 Don't declare local "event" unless it's used.
1542 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1543 unless they are used.
1544 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1545 (x_fatal_error_signal): Remove; not used.
1546 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1547 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1548 (x_error_catcher, x_connection_closed, x_error_handler):
1549 (x_error_quitter, xembed_send_message, x_iconify_frame):
1550 (my_log_handler): Rename locals to avoid shadowing.
1551 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1552 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1554 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1555 Rename or move locals to avoid shadowing.
1556 (tty_defined_color, merge_face_heights): Now static.
1557 (free_realized_faces_for_fontset): Remove; not used.
1558 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1559 does not deduce is never used uninitialized.
1560 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1561 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1563 * terminal.c (store_terminal_param): Now static.
1565 * xmenu.c (menu_highlight_callback): Now static.
1566 (set_frame_menubar): Remove unused local.
1567 (xmenu_show): Rename parameter to avoid shadowing.
1568 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1569 since they might point to immutable storage.
1570 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1571 since it's unused otherwise.
1573 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1574 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1575 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1576 avoids a gcc -Wuninitialized diagnostic.
1577 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1578 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1579 does not deduce are never used uninitialized.
1581 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1583 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1584 * window.c (window_loop, size_window):
1585 (run_window_configuration_change_hook, enlarge_window): Likewise.
1587 * window.c (display_buffer): Now static.
1588 (size_window): Mark variables that gcc -Wuninitialized
1589 does not deduce are never used uninitialized.
1590 * window.h (check_all_windows): New decl, to forestall
1591 gcc -Wmissing-prototypes diagnostic.
1592 * dispextern.h (bidi_dump_cached_states): Likewise.
1594 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1596 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1598 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1599 and to avoid gcc -Wuninitialized warning.
1600 (load_charset_map): Mark variables that gcc -Wuninitialized
1601 does not deduce are never used uninitialized.
1602 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1604 * coding.c (coding_set_source, coding_set_destination):
1605 Use "else { /* comment */ }" rather than "else /* comment */;"
1606 for clarity, and to avoid gcc -Wempty-body warning.
1607 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1608 a block, when the outer 'i' will do.
1609 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1610 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1611 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1612 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1613 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1614 Rename locals to avoid shadowing.
1615 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1616 * coding.c (emacs_mule_char, encode_invocation_designation):
1617 Now static, since they're not used elsewhere.
1618 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1619 (decode_coding_object, encode_coding_object, detect_coding_system):
1620 (decode_coding_emacs_mule): Mark variables that gcc
1621 -Wuninitialized does not deduce are never used uninitialized.
1622 (detect_coding_iso_2022): Initialize a local variable that might
1623 be used uninitialized. Leave a FIXME because it's not clear that
1624 this initialization is needed. (Bug#8211)
1625 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1626 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1627 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1628 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1629 Remove unused macros.
1631 * category.c (hash_get_category_set): Remove unused local var.
1632 (copy_category_table): Now static, since it's not used elsewhere.
1633 * character.c (string_count_byte8): Likewise.
1635 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1636 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1638 * chartab.c (copy_sub_char_table): Now static, since it's not used
1640 (sub_char_table_ref_and_range, char_table_ref_and_range):
1641 Rename locals to avoid shadowing.
1642 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1644 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1645 (BIDI_BOB): Remove unused macro.
1647 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1648 deduce are never used uninitialized.
1649 * term.c (encode_terminal_code): Likewise.
1651 * term.c (encode_terminal_code): Now static. Remove unused local.
1653 * tparam.h: New file.
1654 * term.c, tparam.h: Include it.
1655 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1656 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1657 Move these decls to tparam.h, and make them agree with what
1658 is actually in tparam.c. The previous trick of using incompatible
1659 decls in different modules does not conform to the C standard.
1660 All callers of tparam changed to use tparam's actual API.
1661 * tparam.c (tparam1, tparam, tgoto):
1662 Use const pointers where appropriate.
1664 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1665 * cm.h (struct cm): Likewise.
1666 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1667 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1668 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1669 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1670 (turn_on_face, init_tty): Likewise.
1671 * termchar.h (struct tty_display_info): Likewise.
1673 * term.c (term_mouse_position): Rename local to avoid shadowing.
1675 * alloc.c (mark_ttys): Move decl from here ...
1676 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1678 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1680 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1682 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1684 * search.c (compile_pattern_1): Remove argument regp, unused since
1685 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1686 (compile_pattern): Don't pass it.
1688 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1690 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1691 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1693 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1695 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1697 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1698 gdk_window_get_screen, gdk_window_get_geometry,
1699 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1700 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1701 (xg_get_pixbuf_from_pixmap): New function.
1702 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1703 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1704 Call xg_get_pixbuf_from_pixmap instead of
1705 gdk_pixbuf_get_from_drawable.
1706 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1707 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1708 (xg_check_special_colors): Use GtkStyleContext and its functions
1710 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1711 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1712 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1713 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1714 Call gtk_widget_get_preferred_size.
1715 (xg_frame_resized): gdk_window_get_geometry only takes 5
1717 (xg_win_to_widget, xg_event_is_for_menubar):
1718 Call gdk_x11_window_lookup_for_display.
1719 (xg_set_widget_bg): New function.
1720 (delete_cb): New function.
1721 (xg_create_frame_widgets): connect delete-event to delete_cb.
1722 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1723 (xg_set_background_color): Call xg_set_widget_bg.
1724 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1725 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1726 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1727 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1729 (update_frame_tool_bar): Call gtk_widget_hide.
1730 (xg_initialize): Use GDK_KEY_g.
1732 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1734 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1736 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1737 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1738 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1740 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1742 * w32xfns.c (select_palette): Check success of RealizePalette against
1743 GDI_ERROR, not zero.
1745 See ChangeLog.11 for earlier changes.
1751 Copyright (C) 2011 Free Software Foundation, Inc.
1753 This file is part of GNU Emacs.
1755 GNU Emacs is free software: you can redistribute it and/or modify
1756 it under the terms of the GNU General Public License as published by
1757 the Free Software Foundation, either version 3 of the License, or
1758 (at your option) any later version.
1760 GNU Emacs is distributed in the hope that it will be useful,
1761 but WITHOUT ANY WARRANTY; without even the implied warranty of
1762 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1763 GNU General Public License for more details.
1765 You should have received a copy of the GNU General Public License
1766 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.