1 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3 * process.c (Fnetwork_interface_list): Correctly determine buffer
6 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8 * eval.c (internal_condition_case, internal_condition_case_1)
9 (internal_condition_case_2, internal_condition_case_n): Remove
10 unnecessary aborts (Bug#9081).
12 2011-08-17 Eli Zaretskii <eliz@gnu.org>
14 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
15 has no `load' handler, try opening the file locally. (Bug#9311)
17 2011-08-16 Ken Brown <kbrown@cornell.edu>
19 * gmalloc.c: Expand comment.
21 2011-08-16 Eli Zaretskii <eliz@gnu.org>
23 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
24 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
26 2011-08-16 Ken Brown <kbrown@cornell.edu>
28 Fix memory allocation problems in Cygwin build (Bug#9273).
30 * unexcw.c ( __malloc_initialized): Declare external variable.
31 (fixup_executable): Force the dumped emacs to reinitialize malloc.
33 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
35 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
37 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
39 [CYGWIN] (special_realloc): New function.
40 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
41 requests to realloc storage in the static heap.
43 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
45 * bidi.c (bidi_initialize): Remove unused local.
47 2011-08-15 Eli Zaretskii <eliz@gnu.org>
49 * biditype.h: File removed.
51 * bidimirror.h: File removed.
53 * deps.mk (bidi.o): Remove biditype.h and
56 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
59 * dispextern.h: Fix a typo in the comment to bidi_type_t.
61 * chartab.c: Improve commentary for the uniprop_table API.
63 * bidi.c (bidi_paragraph_init): Support zero value of
64 bidi_ignore_explicit_marks_for_paragraph_level.
65 (bidi_initialize): Use uniprop_table instead of including
66 biditype.h and bidimirror.h.
68 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
69 coordinates of the iterator when restoring from ppos_it.
72 2011-08-14 Kenichi Handa <handa@m17n.org>
74 * process.c (create_process): Call setup_process_coding_systems
75 after the pid of the process is set to -1 (Bug#8162).
77 2011-08-14 Eli Zaretskii <eliz@gnu.org>
79 * xdisp.c (move_it_in_display_line_to): Don't invoke
80 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
81 ppos_it. Fixes vertical cursor motion when line beginning is
82 covered by an image. (Bug#9296)
84 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
86 * nsterm.h (ns_run_ascript): Declare.
87 (NSAPP_DATA2_RUNASSCRIPT): Define.
89 * nsfns.m (as_script, as_result, as_status): New static variables.
90 (ns_run_ascript): New function.
91 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
92 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
93 the event loop. Get status from as_status (Bug#7276).
95 * nsterm.m (sendEvent): If event is NSApplicationDefined and
96 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
97 the event loop (Bug#7276).
99 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
101 * gnutls.c (QCgnutls_bootprop_priority)
102 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
103 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
104 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
105 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
106 (QCgnutls_bootprop_verify_hostname_error)
107 (QCgnutls_bootprop_callbacks_verify): Rename from
108 Qgnutls_bootprop_..., all uses changed.
110 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
113 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
115 * xfaces.c (Qframe_set_background_mode): Now static.
116 * dispextern.h (Qframe_set_background_mode): Remove decl.
118 * process.c (Fnetwork_interface_info): Declare local only if needed.
120 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
122 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
123 (Fnetwork_interface_list): Allocate in increments of bytes instead
124 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
125 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
127 (struct ifflag_def): notrailers is smart on OSX.
128 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
129 Get hardware address with getifaddrs if available.
131 2011-08-12 Eli Zaretskii <eliz@gnu.org>
133 * xdisp.c (iterate_out_of_display_property): xassert that
134 IT->position is set to within IT->object's boundaries. Break from
135 the loop as soon as EOB is reached; avoids infloops in redisplay
136 when IT->position is set up wrongly due to some bug. Set
137 IT->current to match the bidi iterator unconditionally.
138 (push_display_prop): Allow GET_FROM_STRING as IT->method on
139 entry. Force push_it to save on the stack the current
140 buffer/string position, to be restored by pop_it. Fix flags in
141 the iterator structure wrt the object coming from a display
142 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
143 properties. (Bug#9284)
145 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
147 * fontset.c (fontset_get_font_group): Add proper type checks.
150 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
152 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
153 and LC_VERSION_MIN_MACOSX.
154 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
155 (dump_it) [LC_FUNCTION_STARTS]: Use it.
157 2011-08-08 Eli Zaretskii <eliz@gnu.org>
159 * xdisp.c (forward_to_next_line_start): Allow to use the
160 no-display-properties-and-no-overlays under bidi display. Set
161 disp_pos in the bidi iterator to avoid searches for display
162 properties and overlays.
164 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
166 * editfns.c (Fset_time_zone_rule): Document relationship with the
169 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
170 the font entity extracted from the cache (Bug#8109).
172 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
174 * composite.c (autocmp_chars): Don't reset point. That is done by
175 restore_point_unwind (Bug#5984).
177 2011-08-07 Juri Linkov <juri@jurta.org>
179 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
180 to show the arg `TIME' instead of `TIMEVAL'.
182 2011-08-06 Eli Zaretskii <eliz@gnu.org>
184 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
185 display property strides EOL and includes a newline, as in
186 longlines-mode. (Bug#9254)
187 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
188 word-wrap under bidirectional display. (Bug#9224)
190 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
191 is non-zero, even if the data buffer is NULL. Fixes a crash in
192 vertical-motion with longlines-mode. (Bug#9254)
194 2011-08-05 Eli Zaretskii <eliz@gnu.org>
196 * bidi.c <bidi_cache_total_alloc>: Now static.
197 (bidi_initialize): Initialize bidi_cache_total_alloc.
199 *xdisp.c (display_line): Release buffer allocated for shelved bidi
202 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
203 amount allocated this far in `bidi_cache_total_alloc'.
204 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
205 non-zero, only free the data buffer without restoring the cache
206 contents. All callers changed.
208 * dispextern.h (bidi_unshelve_cache): Update prototype.
210 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
211 (move_it_in_display_line, move_it_to)
212 (move_it_vertically_backward, move_it_by_lines): Replace the call
213 to xfree to an equivalent call to bidi_unshelve_cache.
214 (move_it_in_display_line_to): Fix logic of returning
215 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
217 2011-08-05 Eli Zaretskii <eliz@gnu.org>
219 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
220 came from a string character with a `cursor' property. (Bug#9229)
222 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
224 * Makefile.in (LIB_PTHREAD): New variable.
225 (LIBES): Add LIB_PTHREAD (Bug#9216).
227 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
228 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
230 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
232 * regex.c (re_iswctype): Remove some redundant boolean
235 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
237 * xterm.c (x_find_topmost_parent): New function.
238 (x_set_frame_alpha): Find topmost parent window with
239 x_find_topmost_parent and set the property there also (bug#9181).
240 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
242 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
244 * callproc.c (Fcall_process): Avoid vfork clobbering
245 the local vars buffer, coding_systems, current_dir.
247 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
249 * keymap.c (Fmake_composed_keymap): Move to subr.el.
251 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
253 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
254 so that it is not optimized away.
256 * xdisp.c (compute_display_string_pos): Remove unused local.
258 2011-08-02 Eli Zaretskii <eliz@gnu.org>
260 Fix slow cursor motion and scrolling in large buffers with
261 selective display, like Org Mode buffers. (Bug#9218)
263 * dispextern.h (struct bidi_it): New member disp_prop_p.
265 * xdisp.c: Remove one-slot cache of display string positions.
266 (compute_display_string_pos): Accept an additional argument
267 DISP_PROP_P; callers changed. Scan at most 5K characters forward
268 for a display string or property. If found, set DISP_PROP_P
271 * bidi.c (bidi_fetch_char): Accept an additional argument
272 DISP_PROP_P, and pass it to compute_display_string_pos.
273 Only handle text covered by a display string if DISP_PROP_P is returned
274 non-zero. All callers of bidi_fetch_char changed.
276 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
278 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
280 2010-12-03 Don March <don@ohspite.net>
282 * keymap.c (Fdefine_key): Fix non-prefix key error message when
283 last character M-[char] is translated to ESC [char] (bug#7541).
285 2011-08-02 Kenichi Handa <handa@m17n.org>
287 * lisp.h (uniprop_table): Extern it.
289 * chartab.c (uniprop_table): Make it non-static.
291 2011-08-01 Eli Zaretskii <eliz@gnu.org>
293 * xdisp.c (forward_to_next_line_start): Accept additional argument
294 BIDI_IT_PREV, and store into it the state of the bidi iterator had
296 (reseat_at_next_visible_line_start): Use the bidi iterator state
297 returned by forward_to_next_line_start to restore the state of
298 it->bidi_it after backing up to previous newline. (Bug#9212)
300 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
302 * regex.c (re_comp): Protoize.
303 (re_exec): Fix return type.
304 (regexec): Fix type of `ret'. (Bug#9203)
306 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
308 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
309 This is needed if max-image-size is a floating-point number.
311 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
313 * print.c (print_object): Print empty symbol as ##.
315 * lread.c (read1): Read ## as empty symbol.
317 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
319 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
320 setting frame foreground color (Bug#9175).
321 (x_set_background_color): Likewise.
323 * nsmenu.m (-setText): Size tooltip dimensions precisely to
325 (EmacsTooltip -init): Remove bezels and add shadows to
328 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
329 or scroll bar (Bug#8470).
331 * nsfont.m (nsfont_open): Remove assignment to voffset and
332 unnecessary vars hshink, expand, hd, full_height, min_height.
333 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
335 * nsterm.h (nsfont_info): Remove voffset field.
337 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
339 Implement strike-through and overline on NextStep (Bug#8863).
341 * nsfont.m (nsfont_open): Use underline position provided by font,
342 instead of hard-coded value of 2.
343 (nsfont_draw): Call ns_draw_text_decoration instead.
345 * nsterm.h: Add declaration for ns_draw_text_decoration.
347 * nsterm.m (ns_draw_text_decoration): New function for drawing
348 underline, overline, and strike-through.
349 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
350 ns_draw_text_decoration. Change treatment of cursor drawing to
351 accomodate underlining, etc.
353 2011-07-28 Eli Zaretskii <eliz@gnu.org>
355 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
358 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
360 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
361 Without this fix, if a signal arrives just after memory fills up,
362 'malloc' might be invoked reentrantly.
364 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
365 In other words, assume that every image size is allowed, on non-X
366 hosts. This assumption is probably wrong, but it lets Emacs compile.
368 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
370 * regex.c (re_iswctype): Convert return values to boolean.
372 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
374 * xdisp.c (compute_display_string_pos): Don't use cached display
375 string position if the buffer had its restriction changed.
378 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
380 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
382 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
384 Integer signedness and overflow and related fixes. (Bug#9079)
386 * bidi.c: Integer size and overflow fixes.
387 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
388 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
389 (bidi_cache_find_level_change, bidi_cache_ensure_space)
390 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
391 (bidi_find_other_level_edge):
392 Use ptrdiff_t instead of EMACS_INT where either will do.
393 This works better on 32-bit hosts configured --with-wide-int.
394 (bidi_cache_ensure_space): Check for size-calculation overflow.
395 Use % rather than repeated addition, for better worst-case speed.
396 Don't set bidi_cache_size until after xrealloc returns, because it
398 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
399 (bidi_cache_ensure_space): Also check that the bidi cache size
400 does not exceed that of the largest Lisp string or buffer. See Eli
401 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
403 * alloc.c (__malloc_size_t): Remove.
404 All uses replaced by size_t. See Andreas Schwab's note
405 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
407 * image.c: Improve checking for integer overflow.
408 (check_image_size): Assume that f is nonnull, since
409 it is always nonnull in practice. This is one less thing to
410 worry about when checking for integer overflow later.
411 (x_check_image_size): New function, which checks for integer
412 overflow issues inside X.
413 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
414 This removes the need for a memory_full check.
415 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
416 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
417 (xbm_read_bitmap_data): Change locals back to 'int', since
418 their values must fit in 'int'.
419 (xpm_load_image, png_load, tiff_load):
420 Invoke x_create_x_image_and_pixmap earlier,
421 to avoid much needless work if the image is too large.
422 (tiff_load): Treat overly large images as if
423 x_create_x_image_and_pixmap failed, not as malloc failures.
424 (gs_load): Use x_check_image_size.
426 * gtkutil.c: Omit integer casts.
427 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
428 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
430 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
432 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
433 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
434 would wrongly return t on a 64-bit host.
436 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
437 The plain *_OVERFLOW macros run afoul of GCC bug 49705
438 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
439 and therefore cause GCC to emit a bogus diagnostic in some cases.
441 * image.c: Integer signedness and overflow and related fixes.
442 This is not an exhaustive set of fixes, but it's time to
443 record what I've got.
444 (lookup_pixel_color, check_image_size): Remove redundant decls.
445 (check_image_size): Don't assume that arbitrary EMACS_INT values
446 fit in 'int', or that arbitrary 'double' values fit in 'int'.
447 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
448 (tiff_load, imagemagick_load_image):
449 Check for overflow in size calculations.
450 (x_create_x_image_and_pixmap): Remove unnecessary test for
451 xmalloc returning NULL; that can't happen.
452 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
453 (xpm_color_bucket): Use better integer hashing function.
454 (xpm_cache_color): Don't possibly over-allocate memory.
455 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
457 Use ptrdiff_t, not int or size_t, to record sizes.
458 (png_load): Don't assume values greater than 2**31 fit in 'int'.
459 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
460 either works, as we prefer signed integers.
461 (tiff_read_from_memory, tiff_write_from_memory):
462 Return tsize_t, not size_t, since that's what the TIFF API wants.
463 (tiff_read_from_memory): Don't fail simply because the read would
464 go past EOF; instead, return a short read.
465 (tiff_load): Omit no-longer-needed casts.
466 (Fimagemagick_types): Don't assume size fits into 'int'.
468 Improve hashing quality when configured --with-wide-int.
469 * fns.c (hash_string): New function, taken from sxhash_string.
470 Do not discard information about ASCII character case; this
471 discarding is no longer needed.
472 (sxhash-string): Use it. Change sig to match it. Caller changed.
473 * lisp.h: Declare it.
474 * lread.c (hash_string): Remove, since we now use fns.c's version.
475 The fns.c version returns a wider integer if --with-wide-int is
476 specified, so this should help the quality of the hashing a bit.
478 * emacs.c: Integer overflow minor fix.
479 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
480 Define only if GNU_LINUX.
481 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
483 * dispnew.c: Integer signedness and overflow fixes.
484 Remove unnecessary forward decls, that were a maintenance hassle.
485 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
487 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
488 (scrolling_window): Use ptrdiff_t, not int, for byte count.
489 (prepare_desired_row, line_draw_cost):
490 Use int, not unsigned, where either works.
491 (save_current_matrix, restore_current_matrix):
492 Use ptrdiff_t, not size_t, where either works.
493 (init_display): Check for overflow more accurately, and without
494 relying on undefined behavior.
496 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
497 Remove, replacing with the new symbols in lisp.h. All uses changed.
498 * fileio.c (make_temp_name):
499 * filelock.c (lock_file_1, lock_file):
500 * xdisp.c (message_dolog):
501 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
502 Use pMd etc. instead.
503 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
504 replacing the pWIDE etc. symbols removed from editfns.c.
506 * keyboard.h (num_input_events): Now uintmax_t.
507 This is (very slightly) less likely to mess up due to wraparound.
510 * buffer.c: Integer signedness fixes.
511 (alloc_buffer_text, enlarge_buffer_text):
512 Use ptrdiff_t rather than size_t when either will do, as we prefer
515 * alloc.c: Integer signedness and overflow fixes.
516 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
517 (__malloc_size_t): Default to size_t, not to int.
518 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
519 (Fgarbage_collect, mark_object_loop_halt, mark_object):
520 Prefer ptrdiff_t to size_t when either would do, as we prefer
522 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
523 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
524 Now const. Initialize with values that are in range even if char
526 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
527 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
528 These functions do the right thing with sizes > 2**32.
529 (check_depth): Now ptrdiff_t, not int.
530 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
531 Adjust to new way of storing sizes. Check for size overflow bugs
533 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
534 slightly wrong anyway, as it missed one instance of
535 XMALLOC_OVERRUN_CHECK_OVERHEAD.
536 (refill_memory_reserve): Omit needless cast to size_t.
537 (mark_object_loop_halt): Mark as externally visible.
539 * xselect.c: Integer signedness and overflow fixes.
540 (Fx_register_dnd_atom, x_handle_dnd_message):
541 Use ptrdiff_t, not size_t, since we prefer signed.
542 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
543 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
544 x_dnd_atoms_size and x_dnd_atoms_length.
546 * doprnt.c: Prefer signed to unsigned when either works.
550 * xdisp.c (vmessage):
551 Use ptrdiff_t, not size_t, when using or implementing doprnt,
552 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
553 prefer signed arithmetic to avoid comparison confusion.
554 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
557 Assume freestanding C89 headers, string.h, stdlib.h.
558 * data.c, doprnt.c, floatfns.c, print.c:
559 Include float.h unconditionally.
560 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
561 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
562 * regex.c: Likewise for stddef.h, string.h.
563 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
564 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
565 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
566 (STDC_HEADERS): Remove obsolete defines.
567 * sysdep.c: Include limits.h unconditionally.
569 Assume support for memcmp, memcpy, memmove, memset.
570 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
571 * regex.c (memcmp, memcpy):
572 Remove; we assume C89 now.
574 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
575 (__malloc_safe_bcopy): Remove; no longer needed.
577 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
578 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
579 well either way, and we prefer signed to unsigned.
581 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
583 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
584 closes the connection while we're reading (bug#9182).
586 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
588 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
589 are specified (Bug#9168).
591 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
593 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
594 Found by GCC static checking and --with-wide-int on a 32-bit host.
596 2011-07-25 Eli Zaretskii <eliz@gnu.org>
598 * xdisp.c (compute_display_string_pos): Fix logic of caching
599 previous display string position. Initialize cached_prev_pos to
600 -1. Fixes slow-down at the beginning of a buffer.
602 2011-07-24 Eli Zaretskii <eliz@gnu.org>
604 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
605 for attrs[LFACE_FONTSET_INDEX].
607 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
609 * xml.c (parse_region): Remove unused local
610 that was recently introduced.
612 2011-07-23 Eli Zaretskii <eliz@gnu.org>
614 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
615 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
617 * xdisp.c (move_it_in_display_line_to): Record the best matching
618 position for TO_CHARPOS while scanning the line, and restore it on
619 exit if none of the characters scanned was an exact match.
620 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
621 when exact match is impossible due to invisible text, and the
624 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
626 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
629 2011-07-22 Eli Zaretskii <eliz@gnu.org>
631 Fix a significant slow-down of cursor motion with C-n, C-p,
632 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
633 auto-repeat under bidi redisplay in fontified buffers.
634 * xdisp.c (compute_stop_pos_backwards): New function.
635 (next_element_from_buffer): Call compute_stop_pos_backwards to
636 find a suitable prev_stop when we find ourselves before
638 (reseat): Don't look for prev_stop, as that could mean a very long
640 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
641 <cached_disp_overlay_modiff>: Cache for last found display string
643 (compute_display_string_pos): Return the cached position if asked
644 about the same buffer in the same area of character positions, and
645 the buffer wasn't changed since the time the display string
648 2011-07-22 Eli Zaretskii <eliz@gnu.org>
650 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
651 is an integer, which is important for empty lines. (Bug#9149)
653 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
655 * frame.c (Fmodify_frame_parameters): In tty case, update the
656 default face if necessary (Bug#4238).
658 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
660 * editfns.c (Fstring_to_char): No need to explain what a character
661 is in the docstring (Bug#6576).
663 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
665 * xml.c (parse_region): Make sure we always return a tree.
667 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
669 * xml.c (parse_region): If a document contains only comments,
672 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
674 * xml.c (make_dom): Return comments, too.
676 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
679 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
680 and the surrounding thread.
681 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
682 rather than fgets, and retry after EINTR. Otherwise, 'emacs
683 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
685 * s/openbsd.h (BROKEN_SIGIO): Define.
686 * unexelf.c (unexec) [__OpenBSD__]:
687 Don't update the .mdebug section of the Alpha COFF symbol table.
689 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
691 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
694 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
696 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
697 This fixes some race conditions on the permissions of any newly
700 * alloc.c (valid_pointer_p): Use pipe, not open.
701 This fixes some permissions issues when debugging.
703 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
704 If fchown fails to set both uid and gid, try to set just gid,
705 as that is sometimes allowed. Adjust the file's mode to eliminate
706 setuid or setgid bits that are inappropriate if fchown fails.
708 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
710 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
711 to compare Lisp_Objects.
712 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
713 global_gnutls_log_level, don't mistake it for a Lisp_Object.
714 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
716 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
718 * lread.c (read_integer): Unread even EOF character.
719 (read1): Likewise. Properly record start position of symbol.
721 * lread.c (read1): Read `#:' as empty uninterned symbol if no
722 symbol character follows.
724 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
726 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
727 This works around a problem with the previous change to Fcopy_file.
728 Recent glibc declares fchown with __attribute__((warn_unused_result)),
729 and without this change, GCC might complain about discarding
730 fchown's return value.
732 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
734 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
736 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
738 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
740 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
742 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
743 it's used from the C level.
745 * process.c: Use the same condition for POLL_FOR_INPUT in both
746 keyboard.c and process.c (bug#1858).
748 2011-07-09 Lawrence Mitchell <wence@gmx.li>
750 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
751 (Fgnutls_boot): Use it.
753 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
755 * doc.c (Fsubstitute_command_keys): Revert last change.
757 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
759 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
760 quotes the next character, and doesn't affect other longer
761 sequences (bug#8935).
763 * lread.c (syms_of_lread): Clarify that is isn't only
764 `eval-buffer' and `eval-defun' that's affected by
765 `lexical-binding' (bug#8460).
767 2011-07-15 Eli Zaretskii <eliz@gnu.org>
769 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
770 bidi redisplay when a line includes both an image and is
773 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
775 Fix minor problems found by static checking.
776 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
777 (elsz): Now a signed constant, not a size_t var. We prefer signed
778 types to unsigned, to avoid integer comparison confusion. Without
779 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
780 "cannot optimize loop, the loop counter may overflow", a symptom
782 * indent.c (Fvertical_motion): Mark locals as initialized.
783 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
785 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
787 * search.c (Fre_search_backward): Mention `case-fold-search' in
788 all the re_search_* functions (bug#8138).
790 * keyboard.c (Fopen_dribble_file): Document when the file is
793 2011-07-14 Eli Zaretskii <eliz@gnu.org>
795 * bidi.c (bidi_dump_cached_states): Fix format of displaying
798 Support bidi reordering of display and overlay strings.
799 * xdisp.c (compute_display_string_pos)
800 (compute_display_string_end): Accept additional argument STRING.
801 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
802 (reseat_to_string): Initialize bidi_it->string.s and
803 bidi_it->string.schars.
804 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
805 NULL (avoids a crash in bidi_paragraph_init).
806 Initialize itb.string.lstring.
807 (init_iterator): Call bidi_init_it only of a valid
808 buffer position was specified. Initialize paragraph_embedding to
810 (reseat_to_string): Initialize the bidi iterator.
811 (display_string): If we need to ignore text properties of
812 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
813 original value of -1 will not work with bidi.)
814 (compute_display_string_pos): First arg is now struct
815 `text_pos *'; all callers changed. Support display properties on
817 (compute_display_string_end): Support display properties on Lisp
819 (init_iterator, reseat_1, reseat_to_string): Initialize the
820 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
821 when iterating on a string not from display properties).
822 (compute_display_string_pos, compute_display_string_end):
823 Fix calculation of the object to scan. Fixes an error when using
825 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
826 base_level_stop; instead, set base_level_stop to BEGV.
827 Fixes crashes in vertical-motion.
828 (next_element_from_buffer): Improve commentary for when
829 the iterator is before prev_stop.
830 (init_iterator): Initialize bidi_p from the default value of
831 bidi-display-reordering, not from buffer-local value. Use the
832 buffer-local value only if initializing for buffer iteration.
833 (handle_invisible_prop): Support invisible properties on strings
834 that are being bidi-reordered.
835 (set_iterator_to_next): Support bidi reordering of C strings and
837 (next_element_from_string): Support bidi reordering of Lisp
839 (handle_stop_backwards): Support Lisp strings as well.
840 (display_string): Support display of R2L glyph rows.
841 Use IT_STRING_CHARPOS when displaying from a Lisp string.
842 (init_iterator): Don't initialize it->bidi_p for strings
844 (reseat_to_string): Initialize it->bidi_p for strings here.
845 (next_element_from_string, next_element_from_c_string)
846 (next_element_from_buffer): Add xassert's for correspondence
847 between IT's object being iterated and it->bidi_it.string
849 (face_before_or_after_it_pos): Support bidi iteration.
850 (next_element_from_c_string): Handle the case of the first string
851 character that is not the first one in the visual order.
852 (get_visually_first_element): New function, refactored from common
853 parts of next_element_from_buffer, next_element_from_string, and
854 next_element_from_c_string.
855 (tool_bar_lines_needed, redisplay_tool_bar)
856 (display_menu_bar): Force left-to-right direction. Add a FIXME
857 comment for making that be controlled by a user option.
858 (push_it, pop_it): Save and restore the state of the
859 bidi iterator. Save and restore the bidi_p flag.
860 (pop_it): Iterate out of display property for string iteration as
862 (iterate_out_of_display_property): Support iteration over strings.
863 (handle_single_display_spec): Set up it->bidi_it for iteration
864 over a display string, and call bidi_init_it.
865 (handle_single_display_spec, next_overlay_string)
866 (get_overlay_strings_1, push_display_prop): Set up the bidi
867 iterator for displaying display or overlay strings.
868 (forward_to_next_line_start): Don't use the shortcut if
870 (back_to_previous_visible_line_start): If handle_display_prop
871 pushed the iterator stack, restore the internal state of the bidi
872 iterator by calling bidi_pop_it same number of times.
873 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
874 and we are bidi-iterating, don't decrement the iterator position;
875 instead, set the first_elt flag in the bidi iterator, to produce
877 (reseat_1): Remove redundant setting of string_from_display_prop_p.
878 (push_display_prop): xassert that we are iterating a buffer.
879 (push_it, pop_it): Save and restore paragraph_embedding member.
880 (handle_single_display_spec, next_overlay_string)
881 (get_overlay_strings_1, reseat_1, reseat_to_string)
882 (push_display_prop): Set up the `unibyte' member of bidi_it.string
883 correctly. Don't assume unibyte strings are not bidi-reordered.
884 (compute_display_string_pos)
885 (compute_display_string_end): Fix handling the case of C string.
886 (push_it, pop_it): Save and restore from_disp_prop_p.
887 (handle_single_display_spec, push_display_prop): Set the
888 from_disp_prop_p flag.
889 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
890 (pop_it): Call iterate_out_of_display_property only if we are
891 popping after iteration over a string that came from a display
892 property. Fix a typo in popping stretch info. Add an assertion
893 for verifying that the iterator position is in sync with the bidi
895 (handle_single_display_spec, get_overlay_strings_1)
896 (push_display_prop): Fix initialization of paragraph direction for
897 string when that of the parent object is not yet determined.
898 (reseat_1): Call bidi_init_it to resync the bidi
899 iterator with IT's position. (Bug#7616)
900 (find_row_edges): If ROW->start.pos gives position
901 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
902 (handle_stop, back_to_previous_visible_line_start, reseat_1):
903 Reset the from_disp_prop_p flag.
904 (SAVE_IT, RESTORE_IT): New macros.
905 (pos_visible_p, face_before_or_after_it_pos)
906 (back_to_previous_visible_line_start)
907 (move_it_in_display_line_to, move_it_in_display_line)
908 (move_it_to, move_it_vertically_backward, move_it_by_lines)
909 (try_scrolling, redisplay_window, display_line): Use them when
910 saving a temporary copy of the iterator and restoring it back.
911 (back_to_previous_visible_line_start, reseat_1)
912 (init_iterator): Empty the bidi cache "stack".
913 (move_it_in_display_line_to): If iterator ended up at
914 EOL, but we never saw any buffer positions smaller than
915 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
916 motion in bidi-reordered lines.
917 (move_it_in_display_line_to): Record prev_method and prev_pos
918 immediately before the call to set_iterator_to_next. Fixes cursor
919 motion in bidi-reordered lines with stretch glyphs and strings
920 displayed in margins. (Bug#8133) (Bug#8867)
921 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
923 (pos_visible_p): Support positions in bidi-reordered lines.
924 Save and restore bidi cache.
926 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
927 (bidi_paragraph_info): Delete unused struct.
928 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
929 (bidi_cache_start): New variable.
930 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
932 (bidi_cache_fetch_state, bidi_cache_search)
933 (bidi_cache_find_level_change, bidi_cache_iterator_state)
934 (bidi_cache_find, bidi_peek_at_next_level)
935 (bidi_level_of_next_char, bidi_find_other_level_edge)
936 (bidi_move_to_visually_next): Compare cache index with
937 bidi_cache_start rather than with zero.
938 (bidi_fetch_char): Accept new argument STRING; all callers
939 changed. Support iteration over a string. Support strings with
940 display properties. Support unibyte strings. Fix the type of
941 `len' according to what STRING_CHAR_AND_LENGTH expects.
942 (bidi_paragraph_init, bidi_resolve_explicit_1)
943 (bidi_resolve_explicit, bidi_resolve_weak)
944 (bidi_level_of_next_char, bidi_move_to_visually_next):
945 Support iteration over a string.
946 (bidi_set_sor_type, bidi_resolve_explicit_1)
947 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
948 can now be zero (for strings); special values 0 and -1 were
949 changed to -1 and -2, respectively.
950 (bidi_char_at_pos): New function.
951 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
952 Call it instead of FETCH_MULTIBYTE_CHAR.
953 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
954 initialized to valid values.
955 (bidi_init_it): Don't initialize charpos and bytepos with invalid
957 (bidi_level_of_next_char): Allow the sentinel "position" to pass
958 the test for valid cached positions. Fix the logic for looking up
959 the sentinel state in the cache. GCPRO the Lisp string we are
961 (bidi_push_it, bidi_pop_it): New functions.
962 (bidi_initialize): Initialize the bidi cache start stack pointer.
963 (bidi_cache_ensure_space): New function, refactored from part of
964 bidi_cache_iterator_state. Don't assume the required size is just
965 one BIDI_CACHE_CHUNK away.
966 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
967 (bidi_count_bytes, bidi_char_at_pos): New functions.
968 (bidi_cache_search): Don't assume bidi_cache_last_idx is
969 always valid if bidi_cache_idx is valid.
970 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
971 is valid if it's going to be used.
972 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
973 (bidi_cache_fetch_state, bidi_cache_search)
974 (bidi_cache_find_level_change, bidi_cache_ensure_space)
975 (bidi_cache_iterator_state, bidi_cache_find)
976 (bidi_find_other_level_edge, bidi_cache_start_stack):
977 All variables related to cache indices are now EMACS_INT.
979 * dispextern.h (struct bidi_string_data): New structure.
980 (struct bidi_it): New member `string'. Make flag members be 1-bit
981 fields, and put them last in the struct.
982 (compute_display_string_pos, compute_display_string_end):
984 (bidi_push_it, bidi_pop_it): Add prototypes.
985 (struct iterator_stack_entry): New members bidi_p,
986 paragraph_embedding, and from_disp_prop_p.
987 (struct it): Member bidi_p is now a bit field 1 bit wide.
988 (bidi_shelve_cache, bidi_unshelve_cache):
991 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
992 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
993 and vector-like objects.
995 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
996 cache around display iteration.
998 * window.c (Fwindow_end, window_scroll_pixel_based)
999 (displayed_window_lines, Frecenter): Save and restore the bidi
1000 cache around display iteration.
1002 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1004 * editfns.c (Fdelete_region): Clarify the use of the named
1005 parameters (bug#6788).
1007 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1009 * indent.c (Fvertical_motion): Set and restore w->pointm when
1010 saving and restoring the window's buffer (Bug#9006).
1012 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1014 * editfns.c (Fstring_to_char): Clarify just what is returned
1015 (bug#6576). Text by Eli Zaretskii.
1017 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1019 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1021 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1023 * buffer.c (mmap_find): Fix a typo.
1025 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1027 Fix execution of x selection hooks.
1028 * xselect.c (Qx_lost_selection_functions)
1029 (Qx_sent_selection_functions): New vars.
1030 (syms_of_xselect): DEFSYM them.
1031 (x_handle_selection_request): Pass Qx_sent_selection_functions
1032 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1033 (x_handle_selection_clear,x_clear_frame_selections):
1034 Pass Qx_lost_selection_functions rather than
1035 Vx_lost_selection_functions to Frun_hook_with_args.
1037 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1039 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1040 The old code sometimes used this field without initializing it.
1042 * alloc.c (gc_sweep): Don't read past end of array.
1043 In theory, the old code could also have corrupted Emacs internals,
1044 though it'd be very unlikely.
1046 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1048 * character.c (Fcharacterp): Don't advertise optional ignored
1049 argument. (Bug#4026)
1051 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1053 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1056 * window.c (Fset_window_start): Doc fix (bug#4199).
1057 (Fset_window_hscroll): Ditto.
1059 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1061 Fix minor new problems caught by GCC 4.6.1.
1062 * term.c (init_tty): Remove unused local.
1063 * xsettings.c (store_monospaced_changed): Define this function only
1064 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1067 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1069 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1071 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1073 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1074 are the mini-buffer and the echo area (bug#3320).
1076 * term.c (init_tty): Remove support for supdup, c10 and perq
1077 terminals, which are no longer supported (bug#1482).
1079 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1081 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1083 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1085 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1086 for non-popups (Bug#3642).
1088 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1090 * alloc.c (reset_malloc_hooks): Protoize.
1091 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1092 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1093 * cm.c (losecursor): Likewise.
1094 * data.c (fmod): Likewise.
1095 * dispnew.c (swap_glyphs_in_rows): Likewise.
1096 * emacs.c (memory_warning_signal): Likewise.
1097 * floatfns.c (float_error): Likewise.
1098 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1099 (otf_open, font_otf_capability, generate_otf_features)
1100 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1102 * image.c (pbm_read_file): Likewise.
1103 * indent.c (string_display_width): Likewise.
1104 * intervals.c (check_for_interval, search_for_interval)
1105 (inc_interval_count, count_intervals, root_interval)
1106 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1107 * lread.c (defalias): Likewise.
1108 * ralloc.c (r_alloc_check): Likewise.
1109 * regex.c (set_image_of_range_1, set_image_of_range)
1110 (regex_grow_registers): Likewise.
1111 * sysdep.c (strerror): Likewise.
1112 * termcap.c (valid_filename_p, tprint, main): Likewise.
1113 * tparam.c (main): Likewise.
1114 * unexhp9k800.c (run_time_remap, save_data_space)
1115 (update_file_ptrs, read_header, write_header, calculate_checksum)
1116 (copy_file, copy_rest, display_header): Likewise.
1117 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1119 * xdisp.c (check_it): Likewise.
1120 * xfaces.c (register_color, unregister_color, unregister_colors):
1122 * xfns.c (print_fontset_result): Likewise.
1123 * xrdb.c (member, fatal, main): Likewise.
1125 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1127 Fix minor problems found by static checking (Bug#9031).
1128 * chartab.c (char_table_set_range, map_sub_char_table):
1129 Remove unused locals.
1130 (uniprop_table): Now static.
1131 * composite.c (_work_char): Remove unused static var.
1133 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1135 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1137 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1139 * gtkutil.c (qttip_cb): Remove code without function.
1141 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1143 * w32.c (pthread_sigmask): New stub.
1145 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1147 Use pthread_sigmask, not sigprocmask (Bug#9010).
1148 sigprocmask is portable only for single-threaded applications, and
1149 Emacs can be multi-threaded when it uses GTK.
1150 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1152 * callproc.c (Fcall_process):
1153 * process.c (create_process):
1154 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1155 Use pthread_sigmask, not sigprocmask.
1157 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1159 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1160 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1163 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1165 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1166 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1167 (xg_hide_tooltip): Fix comment.
1169 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1170 in registerServicesMenuSendTypes.
1171 (validRequestorForSendType): Don't check ns_return_types.
1173 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1176 2011-07-08 Jason Rumney <jasonr@gnu.org>
1178 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1179 frame struct members of non-existent frames (Bug#6284).
1181 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1183 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1184 variable firstTime not needed on OSX >= 10.6.
1185 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1186 >= 10.5. Use setKnobProportion, setDoubleValue.
1188 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1189 (MAC_OS_X_VERSION_10_5): Define if not defined.
1190 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1191 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1192 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1194 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1195 cString and lossyCString on OSX >= 10.4
1197 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1198 sizeToFit on OSX >= 10.2.
1200 * nsimage.m (allocInitFromFile): Don't use deprecated method
1201 bestRepresentationForDevice on OSX >= 10.6.
1203 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1206 * emacs.c: Declare unexec_init_emacs_zone.
1208 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1210 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1212 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1213 on svcsMenu (Bug#8842).
1215 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1217 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1219 * nsterm.m (QUTF8_STRING): Declare.
1220 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1221 (validRequestorForSendType): Return type is (id).
1222 Change indexOfObjectIdenticalTo to indexOfObject.
1223 Check if we have local selection before returning self (Bug#8842).
1224 (writeSelectionToPasteboard): Put local selection into paste board
1225 if we have a local selection (Bug#8842).
1226 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1228 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1229 (ns_get_local_selection): Declare.
1231 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1233 * keymap.c (describe_map_tree): Don't insert a double newline at
1234 the end of the buffer (bug#1169) and return whether we inserted
1237 * callint.c (Fcall_interactively): Change "reading args" to
1238 "providing args" to try to clarify what it does (bug#1010).
1240 2011-07-07 Kenichi Handa <handa@m17n.org>
1242 * composite.c (composition_compute_stop_pos): Ignore a static
1243 composition starting before CHARPOS (Bug#8915).
1245 * xdisp.c (handle_composition_prop): Likewise.
1247 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1249 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1252 2011-07-07 Kenichi Handa <handa@m17n.org>
1254 * character.h (unicode_category_t): New enum type.
1256 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1257 (Qchar_code_property_table): New variable.
1258 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1259 (UNIPROP_COMPRESSED_FORM_P): New macros.
1260 (char_table_ascii): Uncompress the compressed values.
1261 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1262 Uncompress the compressed values.
1263 (sub_char_table_ref_and_range): Likewise.
1264 (char_table_ref_and_range): Uncompress the compressed values.
1265 (sub_char_table_set): New arg is_uniprop. Callers changed.
1266 Uncompress the compressed values.
1267 (sub_char_table_set_range): Args changed. Callers changed.
1268 (char_table_set_range): Adjuted for the above change.
1269 (map_sub_char_table): Delete args default_val and parent. Add arg
1270 top. Give decoded values to a Lisp function.
1271 (map_char_table): Adjust for the above change. Give decoded
1272 values to a Lisp function. Gcpro more variables.
1273 (uniprop_table_uncompress)
1274 (uniprop_decode_value_run_length): New functions.
1275 (uniprop_decoder, uniprop_decoder_count): New variables.
1276 (uniprop_get_decoder, uniprop_encode_value_character)
1277 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1279 (uniprop_encoder, uniprop_encoder_count): New variables.
1280 (uniprop_get_encoder, uniprop_table)
1281 (Funicode_property_table_internal, Fget_unicode_property_internal)
1282 (Fput_unicode_property_internal): New functions.
1283 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1284 Sunicode_property_table_internal, Sget_unicode_property_internal,
1285 and Sput_unicode_property_internal. Defvar_lisp
1286 char-code-property-alist.
1288 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1289 Vunicode_category_table.
1291 * font.c (font_range): Adjust for the change of
1292 Vunicode_category_table.
1294 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1296 * m/iris4d.h: Remove file, move contents ...
1297 * s/irix6-5.h: ... here.
1299 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1301 Remove unportable assumption about struct layout (Bug#8884).
1302 * alloc.c (mark_buffer):
1303 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1304 (clone_per_buffer_values): Don't assume that
1305 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1306 This isn't true in general, and it's particularly not true
1307 if Emacs is configured with --with-wide-int.
1308 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1309 New macros, used in the buffer.c change.
1311 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1313 * xsettings.c: Use both GConf and GSettings if both are available.
1314 (store_config_changed_event): Add comment.
1315 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1316 (store_tool_bar_style_changed): New functions.
1317 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1318 (struct xsettings): Move font inside HAVE_XFT.
1319 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1320 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1321 Move inside HAVE_XFT.
1322 (something_changed_gsettingsCB): Rename from something_changedCB.
1323 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1325 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1326 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1327 (something_changed_gconfCB): Rename from something_changedCB.
1328 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1329 (parse_settings): Move check for font inside HAVE_XFT.
1330 (read_settings, apply_xft_settings): Add comment.
1331 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1332 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1333 call store_font_name_changed.
1334 (xft_settings_event): Add comment.
1335 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1336 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1337 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1338 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1339 (xsettings_initialize): Call init_gsettings last.
1340 (xsettings_get_system_font, xsettings_get_system_normal_font):
1343 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1345 Random fixes. E.g., (random) never returned negative values.
1346 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1347 subseconds part to the entropy, as that's a bit more random.
1348 Prefer signed to unsigned, since the signedness doesn't matter and
1349 in general we prefer signed. When given a limit, use a
1350 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1351 latter isn't right if USE_2_TAGS_FOR_INTS.
1352 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1353 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1355 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1357 * textprop.c (text_property_stickiness):
1358 Obey Vtext_property_default_nonsticky.
1359 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1360 * w32fns.c (syms_of_w32fns):
1361 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1363 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1365 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1366 This is more efficient than Ffile_directory_p and avoids a minor race.
1368 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1370 * buffer.c (Foverlay_put): Say what the return value is
1373 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1374 is a directory before asking whether to use the file name
1376 (barf_or_query_if_file_exists): Make the "File is a directory"
1377 error be more correct.
1379 * fns.c (Frequire): Remove the mention of the .gz files, since
1380 that's installation-specific, but keep the mention of
1381 `get-load-suffixes'.
1383 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1385 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1386 Report string overflow if the output is too long.
1388 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1390 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1391 (syms_of_gnutls): Remove duplicate DEFSYM for
1392 Qgnutls_bootprop_verify_hostname_error, an error for
1393 Qgnutls_bootprop_verify_error (which is no longer used).
1395 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1396 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1397 Also (re)move comments that are misplaced or no longer relevant.
1399 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1401 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1403 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1405 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1406 and background color parameters if they have been changed.
1408 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1410 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1412 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1414 * xsettings.c (SYSTEM_FONT): Define only when used.
1415 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1417 * keymap.c (access_keymap_1): Now static.
1419 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1421 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1422 leave any prefix arg for the up event (Bug#1586).
1424 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1426 * lread.c (syms_of_lread): Mention single symbols defined by
1427 `defvar' or `defconst' (bug#7154).
1429 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1430 (Frequire): Mention get-load-suffixes.
1432 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1434 * window.h (window): Remove clone_number slot.
1435 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1437 (make_parent_window, make_window, saved_window)
1438 (Fset_window_configuration, save_window_save): Don't deal with
1440 * buffer.c (Qclone_number): Remove declaration.
1441 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1443 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1445 Add multiple inheritance to keymaps.
1446 * keymap.c (Fmake_composed_keymap): New function.
1447 (Fset_keymap_parent): Simplify.
1448 (fix_submap_inheritance): Remove.
1449 (access_keymap_1): New function extracted from access_keymap to handle
1450 embedded parents and handle lists of maps.
1451 (access_keymap): Use it.
1452 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1453 (Fcopy_keymap): Handle embedded parents.
1454 (Fcommand_remapping, define_as_prefix): Simplify.
1455 (Fkey_binding): Simplify.
1456 (syms_of_keymap): Move minibuffer-local-completion-map,
1457 minibuffer-local-filename-completion-map,
1458 minibuffer-local-must-match-map, and
1459 minibuffer-local-filename-must-match-map to Elisp.
1460 (syms_of_keymap): Defsubr make-composed-keymap.
1461 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1462 (parse_menu_item): Trivial simplification.
1464 2011-07-01 Glenn Morris <rgm@gnu.org>
1466 * Makefile.in (SETTINGS_LIBS): Fix typo.
1468 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1470 * coding.c (Fencode_coding_string): Record the last coding system
1471 used, as the function doc string says (bug#8738).
1473 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1475 * xsettings.c (store_monospaced_changed): Take new font as arg and
1476 check for change against current_mono_font.
1477 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1478 (emacs_settings_constructor, emacs_settings_get_property)
1479 (emacs_settings_set_property, emacs_settings_class_init)
1480 (emacs_settings_init, gsettings_obj): Remove.
1481 (something_changedCB): New function for HAVE_GSETTINGS.
1482 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1483 with value as argument.
1484 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1485 g_settings_new (Bug#8967). Do not create gsettings_obj.
1486 Remove calls to g_settings_bind. Connect something_changedCB to
1489 * xgselect.c: Add defined (HAVE_GSETTINGS).
1490 (xgselect_initialize): Ditto.
1492 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1493 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1496 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1498 * eval.c (struct backtrace): Simplify and port the data structure.
1499 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1500 signed bit field, as this assumption is not portable and it makes
1501 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1502 "char debug_on_exit : 1" as this is not portable either; instead,
1503 use the portable "unsigned int debug_on_exit : 1". Remove unused
1504 member evalargs. Remove obsolete comments about cc bombing out.
1506 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1508 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1509 Let HAVE_GSETTINGS override HAVE_GCONF.
1510 (store_monospaced_changed): New function.
1511 (EMACS_SETTINGS): A new type derived from GObject to handle
1512 GSettings notifications.
1513 (emacs_settings_constructor, emacs_settings_get_property)
1514 (emacs_settings_set_property, emacs_settings_class_init):
1516 (gsettings_client, gsettings_obj): New variables.
1517 (GSETTINGS_SCHEMA): New define.
1518 (something_changedCB): Call store_monospaced_changed.
1519 (init_gsettings): New function.
1520 (xsettings_initialize): Call init_gsettings.
1521 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1524 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1527 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1529 * window.c (resize_root_window, grow_mini_window)
1530 (shrink_mini_window): Rename Qresize_root_window to
1531 Qwindow_resize_root_window and Qresize_root_window_vertically to
1532 Qwindow_resize_root_window_vertically.
1534 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1536 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1538 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1540 * makefile.w32-in: Redesign dependencies so they reflect more
1541 clearly which files are directly included by each source file,
1542 and not through other includes.
1544 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1546 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1547 (sort_overlays, overlay_strings): When an overlay's clone number
1548 matches the window's clone number process the overlay even if
1549 the overlay's window property doesn't match the current window.
1551 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1552 (Fwindow_hchild): Rename to Fwindow_left_child.
1553 (Fwindow_next): Rename to Fwindow_next_sibling.
1554 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1555 (resize_window_check): Rename to window_resize_check.
1556 (resize_window_apply): Rename to window_resize_apply.
1557 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1558 (Fdelete_other_windows_internal, resize_frame_windows)
1559 (Fsplit_window_internal, Fdelete_window_internal)
1560 (grow_mini_window, shrink_mini_window)
1561 (Fresize_mini_window_internal): Fix callers accordingly.
1563 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1565 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1566 (emacs_fixed_set_min_size): Remove.
1567 (emacs_fixed_new): Take frame as argument.
1569 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1570 (_EmacsFixedPrivate): Remove minwidth/height.
1571 Add struct frame *f.
1572 (emacs_fixed_init): Initialize priv->f.
1573 (get_parent_class, emacs_fixed_set_min_size): Remove.
1574 (emacs_fixed_new): Set priv->f to argument.
1575 (emacs_fixed_get_preferred_width)
1576 (emacs_fixed_get_preferred_height): Use min_width/height from
1577 frames size_hint to set minimum and natural (Bug#8919).
1578 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1579 and use min_width/height from frames size_hint to set
1580 min_width/height (Bug#8919).
1582 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1583 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1586 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1588 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1589 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1592 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1594 * process.c (wait_reading_process_output): Bypass select if
1595 waiting for a cell while ignoring keyboard input, and input is
1596 pending. Suggested by Jan Djärv (Bug#8869).
1598 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1600 Use gnulib's dup2 module instead of rolling our own.
1601 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1603 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1605 * dispnew.c (scrolling_window): Before scrolling, turn off a
1606 mouse-highlight in the window being scrolled.
1608 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1610 Move DEFSYM to lisp.h and use everywhere.
1612 * character.h (DEFSYM): Move declaration...
1613 * lisp.h (DEFSYM): ...here.
1619 * w32select.c: Don't include character.h.
1621 * alloc.c (syms_of_alloc):
1622 * buffer.c (syms_of_buffer):
1623 * bytecode.c (syms_of_bytecode):
1624 * callint.c (syms_of_callint):
1625 * casefiddle.c (syms_of_casefiddle):
1626 * casetab.c (init_casetab_once):
1627 * category.c (init_category_once, syms_of_category):
1628 * ccl.c (syms_of_ccl):
1629 * cmds.c (syms_of_cmds):
1630 * composite.c (syms_of_composite):
1631 * dbusbind.c (syms_of_dbusbind):
1632 * dired.c (syms_of_dired):
1633 * dispnew.c (syms_of_display):
1634 * doc.c (syms_of_doc):
1635 * editfns.c (syms_of_editfns):
1636 * emacs.c (syms_of_emacs):
1637 * eval.c (syms_of_eval):
1638 * fileio.c (syms_of_fileio):
1639 * fns.c (syms_of_fns):
1640 * frame.c (syms_of_frame):
1641 * fringe.c (syms_of_fringe):
1642 * insdel.c (syms_of_insdel):
1643 * keymap.c (syms_of_keymap):
1644 * lread.c (init_obarray, syms_of_lread):
1645 * macros.c (syms_of_macros):
1646 * msdos.c (syms_of_msdos):
1647 * print.c (syms_of_print):
1648 * process.c (syms_of_process):
1649 * search.c (syms_of_search):
1650 * sound.c (syms_of_sound):
1651 * syntax.c (init_syntax_once, syms_of_syntax):
1652 * terminal.c (syms_of_terminal):
1653 * textprop.c (syms_of_textprop):
1654 * undo.c (syms_of_undo):
1655 * w32.c (globals_of_w32):
1656 * window.c (syms_of_window):
1657 * xdisp.c (syms_of_xdisp):
1658 * xfaces.c (syms_of_xfaces):
1659 * xfns.c (syms_of_xfns):
1660 * xmenu.c (syms_of_xmenu):
1661 * xsettings.c (syms_of_xsettings):
1662 * xterm.c (syms_of_xterm): Use DEFSYM.
1664 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1666 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1668 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1670 Integer and buffer overflow fixes (Bug#8873).
1672 * print.c (printchar, strout): Check for string overflow.
1673 (PRINTPREPARE, printchar, strout):
1674 Don't set size unless allocation succeeds.
1676 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1677 for sizes. Check for string overflow more accurately.
1678 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1680 * macros.c: Integer and buffer overflow fixes.
1681 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1682 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1683 Use ptrdiff_t, not int, for sizes.
1684 Don't increment bufsize until after realloc succeeds.
1685 Check for size-calculation overflow.
1686 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1688 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1690 * lread.c: Integer overflow fixes.
1691 (read_integer): Radix is now EMACS_INT, not int,
1692 to improve quality of diagnostics for out-of-range radices.
1693 Calculate buffer size correctly for out-of-range radices.
1694 (read1): Check for integer overflow in radices, and in
1695 read-circle numbers.
1696 (read_escape): Avoid int overflow.
1697 (Fload, openp, read_buffer_size, read1)
1698 (substitute_object_recurse, read_vector, read_list, map_obarray):
1699 Use ptrdiff_t, not int, for sizes.
1700 (read1): Use EMACS_INT, not int, for sizes.
1701 Check for size overflow.
1703 * image.c (cache_image): Check for size arithmetic overflow.
1705 * lread.c: Integer overflow issues.
1706 (saved_doc_string_size, saved_doc_string_length)
1707 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1708 Now ptrdiff_t, not int.
1709 (read1): Don't assume doc string length fits in int. Check for
1710 out-of-range doc string lengths.
1711 (read_list): Don't assume file position fits in int.
1712 (read_escape): Check for hex character overflow.
1714 2011-06-22 Leo Liu <sdl.web@gmail.com>
1716 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1717 Move to minibuffer.el.
1719 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1721 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1722 The following patches are for when GLYPH_DEBUG && !XASSERT.
1723 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1724 * dispnew.c (flush_stdout):
1725 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1726 Mark as externally visible.
1727 * dispnew.c (check_window_matrix_pointers): Now static.
1728 * dispnew.c (window_to_frame_vpos):
1729 * xfns.c (unwind_create_frame):
1730 * xterm.c (x_check_font): Remove unused local.
1731 * scroll.c (CHECK_BOUNDS):
1732 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1733 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1734 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1735 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1736 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1738 (debug_method_add): Use va_list and vsprintf rather than relying
1739 on undefined behavior with wrong number of arguments.
1740 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1741 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1742 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1743 since we're not interested in debugging glyphs with old libraries.
1744 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1745 GCC 4.6.0's static checking.
1747 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1749 Integer overflow and signedness fixes (Bug#8873).
1750 A few related buffer overrun fixes, too.
1752 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1754 * dispextern.h (struct face.stipple):
1755 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1756 (x_bitmap_mask, x_allocate_bitmap_record)
1757 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1758 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1759 (x_create_bitmap_from_xpm_data):
1760 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1761 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1763 * xfaces.c (load_pixmap):
1764 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1765 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1766 (.bitmaps_last, struct x_output.icon_bitmap):
1767 Use ptrdiff_t, not int, for bitmap indexes.
1768 (x_allocate_bitmap_record): Check for size overflow.
1769 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1771 Use ptrdiff_t, not int, for overlay counts.
1772 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1773 * editfns.c (overlays_around, get_pos_property):
1774 * textprop.c (get_char_property_and_overlay):
1775 * xdisp.c (next_overlay_change, note_mouse_highlight):
1776 * xfaces.c (face_at_buffer_position):
1777 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1778 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1779 (Fnext_overlay_change, Fprevious_overlay_change)
1780 (mouse_face_overlay_overlaps, Foverlays_in):
1781 Use ptrdiff_t, not int, for sizes.
1782 (overlays_at, overlays_in): Check for size-calculation overflow.
1784 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1786 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1787 (x_session_initialize): Do not assume string length fits in int.
1789 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1790 This is unlikely, but can occur if DPI is outlandish.
1792 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1793 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1795 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1796 * xrdb.c (magic_file_p, search_magic_path):
1797 Omit last arg SUFFIX; it was always 0. All callers changed.
1798 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1800 * xfont.c (xfont_match): Avoid need for strlen.
1802 * xfns.c: Don't assume strlen fits in int.
1803 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1805 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1806 not unsigned long, as we prefer signed integers. All callers changed.
1807 Detect integer overflow in repeat count.
1808 (message_dolog): Don't assume print length fits in 39 bytes.
1809 (display_mode_element): Don't assume strlen fits in int.
1811 * termcap.c: Don't assume sizes fit in int and never overflow.
1812 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1813 (gobble_line): Check for size-calculation overflow.
1815 * minibuf.c (Fread_buffer):
1816 * lread.c (intern, intern_c_string):
1817 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1818 Don't assume string length fits in int.
1820 * keyboard.c (parse_tool_bar_item):
1821 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1823 * font.c: Don't assume string length fits in int.
1824 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1825 Use ptrdiff_t, not int.
1826 (font_intern_prop): Don't assume string length fits in int.
1827 Don't assume integer property fits in fixnum.
1828 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1830 * filelock.c: Fix some buffer overrun and integer overflow issues.
1831 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1832 Reformulate so as not to need the command string.
1833 Invoke gzip -cd rather than gunzip, as it's more portable.
1834 (lock_info_type, lock_file_1, lock_file):
1835 Don't assume pid_t and time_t fit in unsigned long.
1836 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1837 (current_lock_owner): Prefer signed type for sizes.
1838 Use memcpy, not strncpy, where memcpy is what is really wanted.
1839 Don't assume (via atoi) that time_t and pid_t fit in int.
1840 Check for time_t and/or pid_t out of range, e.g., via a network share.
1841 Don't alloca where an auto var works fine.
1843 * fileio.c: Fix some integer overflow issues.
1844 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1845 Don't assume string length fits in int.
1846 (directory_file_name): Don't assume string length fits in long.
1847 (make_temp_name): Don't assume pid fits in int, or that its print
1848 length is less than 20.
1850 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1852 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1854 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1856 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1857 We prefer signed integers, even for size calculations.
1859 * emacs.c: Don't assume string length fits in 'int'.
1860 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1861 (main): Don't invoke strlen when not needed.
1863 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1864 (XD_DEBUG_MESSAGE): Don't waste a byte.
1866 * callproc.c (getenv_internal_1, getenv_internal)
1868 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1870 * lread.c (invalid_syntax): Omit length argument.
1871 All uses changed. This doesn't fix a bug, but it simplifies the
1872 code away from its former Hollerith-constant appearance, and it's
1873 one less 'int' to worry about when looking at integer-overflow issues.
1874 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1876 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1877 This didn't break anything, but it didn't help either.
1878 It's confusing to put a bogus integer in a place where the actual
1879 value does not matter.
1880 (LIST_END_P): Remove unused macro and its bogus comment.
1881 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1883 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1884 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1886 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1887 We prefer signed types, and the value cannot exceed the EMACS_INT
1888 range anyway (because otherwise the length would not be representable).
1889 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1890 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1891 This avoids a GCC warning when WIDE_EMACS_INT.
1893 * indent.c (sane_tab_width): New function.
1894 (current_column, scan_for_column, Findent_to, position_indentation)
1895 (compute_motion): Use it. This is just for clarity.
1896 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1898 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1900 * lisp.h (lint_assume): New macro.
1901 * composite.c (composition_gstring_put_cache):
1902 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1904 * editfns.c, insdel.c:
1905 Omit unnecessary forward decls, to simplify future changes.
1907 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1909 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1911 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1912 Use much-faster test for byte-length change.
1913 Don't assume string byte-length fits in 'int'.
1914 Check that character arg fits in 'int'.
1915 (mapcar1): Declare byte as byte, for clarity.
1917 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1919 * fns.c (concat): Catch string overflow earlier.
1920 Do not rely on integer wraparound.
1922 * dispextern.h (struct it.overlay_strings_charpos)
1923 (struct it.selective): Now EMACS_INT, not int.
1924 * xdisp.c (forward_to_next_line_start)
1925 (back_to_previous_visible_line_start)
1926 (reseat_at_next_visible_line_start, next_element_from_buffer):
1927 Don't arbitrarily truncate the value of 'selective' to int.
1929 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1931 * composite.c: Don't truncate sizes to 'int'.
1932 (composition_gstring_p, composition_reseat_it)
1933 (composition_adjust_point): Use EMACS_INT, not int.
1934 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1935 not EMACS_UINT, for indexes.
1937 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1939 * buffer.c: Include <verify.h>.
1940 (struct sortvec.priority, struct sortstr.priority):
1941 Now EMACS_INT, not int.
1942 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1943 (struct sortstr.size, record_overlay_string)
1944 (struct sortstrlist.size, struct sortlist.used):
1945 Don't truncate size to int.
1946 (record_overlay_string): Check for size-calculation overflow.
1947 (init_buffer_once): Check at compile-time, not run-time.
1949 2011-06-22 Jim Meyering <meyering@redhat.com>
1951 Don't leak an XBM-image-sized buffer
1952 * image.c (xbm_load): Free the image buffer after using it.
1954 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1957 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1958 that Sun C diagnosed.
1959 * fns.c (secure_hash): Fix pointer signedness issue.
1960 * intervals.c (static_offset_intervals): New function.
1961 (offset_intervals): Use it.
1963 2011-06-21 Leo Liu <sdl.web@gmail.com>
1966 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1969 * fns.c (secure_hash): Rename from crypto_hash_function and change
1970 the first arg to accept symbols.
1971 (Fsecure_hash): New primitive.
1972 (syms_of_fns): New symbols.
1974 2011-06-20 Deniz Dogan <deniz@dogan.se>
1976 * process.c (Fset_process_buffer): Clarify return value in
1979 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1981 * dispnew.c (add_window_display_history): Use BVAR.
1983 * xdisp.c (debug_method_add): Use BVAR.
1984 (check_window_end, dump_glyph_matrix, dump_glyph)
1985 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1987 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1990 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1991 check till after the cache is created in init_frame_faces.
1993 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1995 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1997 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1999 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2000 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2001 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2003 Improve buffer-overflow checking (Bug#8873).
2004 * fileio.c (Finsert_file_contents):
2005 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2006 Remove the old (too-loose) buffer overflow checks.
2007 They weren't needed, since make_gap checks for buffer overflow.
2008 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2009 The old code merely checked for Emacs fixnum overflow, and relied
2010 on undefined (wraparound) behavior. The new code avoids undefined
2011 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2013 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2014 Tune. Don't use wider integers than needed. Don't use alloca.
2015 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2017 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2019 * insdel.c, lisp.h (buffer_overflow): New function.
2020 (insert_from_buffer_1, replace_range, replace_range_2):
2021 * insdel.c (make_gap_larger):
2022 * editfns.c (Finsert_char):
2023 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2025 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2027 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2029 Integer overflow and signedness fixes (Bug#8873).
2031 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2032 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2034 * fileio.c: Don't assume EMACS_INT fits in off_t.
2035 (emacs_lseek): New static function.
2036 (Finsert_file_contents, Fwrite_region): Use it.
2037 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2039 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2041 * fns.c: Don't overflow int when computing a list length.
2042 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2043 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2044 truncation on 64-bit hosts. Check for QUIT every
2045 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2046 faster and is responsive enough.
2047 (Flength): Report an error instead of overflowing an integer.
2048 (Fsafe_length): Return a float if the value is not representable
2049 as a fixnum. This shouldn't happen except in contrived situations.
2050 (Fnthcdr, Fsort): Don't assume list length fits in int.
2051 (Fcopy_sequence): Don't assume vector length fits in int.
2053 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2054 (header_size, word_size): New constants.
2055 (allocate_vectorlike): Don't check size overflow here.
2056 (allocate_vector): Check it here instead, since this is the only
2057 caller of allocate_vectorlike that could cause overflow.
2058 Check that the new vector's length is representable as a fixnum.
2060 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2061 The previous code was bogus. For example, next_almost_prime (32)
2062 returned 39, which is undesirable as it is a multiple of 3; and
2063 next_almost_prime (24) returned 25, which is a multiple of 5 so
2064 why was the code bothering to check for multiples of 7?
2066 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2068 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2070 Variadic C functions now count arguments with ptrdiff_t.
2071 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2072 Back then I didn't know that the Emacs coding style prefers signed int.
2073 Also, in the meantime I found a few more instances where arguments
2074 were being counted with int, which may truncate counts on 64-bit
2075 machines, or EMACS_INT, which may be unnecessarily wide.
2076 * lisp.h (struct Lisp_Subr.function.aMANY)
2077 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2078 Arg counts are now ptrdiff_t, not size_t.
2079 All variadic functions and their callers changed accordingly.
2080 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2081 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2082 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2083 * callint.c (Fcall_interactively): Check arg count for overflow,
2084 to avoid potential buffer overrun. Use signed char, not 'int',
2085 for 'varies' array, so that we needn't bother to check its size
2086 calculation for overflow.
2087 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2088 * eval.c (apply_lambda):
2089 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2090 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2091 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2093 * callint.c (Fcall_interactively): Don't use index var as event count.
2095 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2096 * mem-limits.h (SIZE): Remove; no longer used.
2098 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2100 Remove unnecessary casts.
2101 * xterm.c (x_term_init):
2102 * xfns.c (x_set_border_pixel):
2103 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2104 These aren't needed now that we assume ANSI C.
2106 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2107 It's more likely to cause problems (due to unsigned overflow)
2110 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2112 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2114 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2116 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2118 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2120 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2122 GLYPH_CODE_FACE returns EMACS_INT, not int.
2123 * dispextern.h (merge_faces):
2124 * xfaces.c (merge_faces):
2125 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2126 Don't assume EMACS_INT fits in int.
2128 * character.h (CHAR_VALID_P): Remove unused parameter.
2129 * fontset.c, lisp.h, xdisp.c: All uses changed.
2131 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2133 * fns.c (concat): Minor tuning based on overflow analysis.
2134 This doesn't fix any bugs. Use int to hold character, instead
2135 of constantly refetching from Emacs object. Use XFASTINT, not
2136 XINT, for value known to be a character. Don't bother comparing
2137 a single byte to 0400, as it's always less.
2139 * floatfns.c (Fexpt):
2140 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2142 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2145 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2147 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2148 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2149 incorrectly succeed when S was a string, because 4294967386 was
2150 truncated before it was used.
2152 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2153 Otherwise, an out-of-range integer could cause undefined behavior
2156 * composite.c: Use int, not EMACS_INT, for characters.
2157 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2158 EMACS_INT, for values that are known to be in character range.
2159 This doesn't fix any bugs but is the usual style inside Emacs and
2160 may generate better code on 32-bit machines.
2162 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2163 This is for reasons similar to the recent CHAR_STRING fix.
2164 * charset.c (Fencode_char): Check that character arg is actually
2165 a character. Pass an int to ENCODE_CHAR.
2166 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2167 wider than 'int', as a compile-time check to prevent future regressions
2170 * character.c (char_string): Remove unnecessary casts.
2172 Make sure a 64-bit char is never passed to CHAR_STRING.
2173 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2174 by silently ignoring the top 32 bits, allowing some values
2175 that were far too large to be valid characters.
2176 * character.h: Include <verify.h>.
2177 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2178 arguments are no wider than unsigned, as a compile-time check
2179 to prevent future regressions in this area.
2181 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2182 (Fsubst_char_in_region):
2184 * xdisp.c (decode_mode_spec_coding):
2185 Adjust to CHAR_STRING's new requirement.
2186 * editfns.c (Finsert_char, Fsubst_char_in_region):
2187 * fns.c (concat): Check that character args are actually
2188 characters. Without this test, these functions did the wrong
2189 thing with wildly out-of-range values on 64-bit hosts.
2191 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2192 These casts should not be needed on 32-bit hosts, either.
2193 * keyboard.c (read_char):
2194 * lread.c (Fload): Remove casts to unsigned.
2196 * lisp.h (UNSIGNED_CMP): New macro.
2197 This fixes comparison bugs on 64-bit hosts.
2198 (ASCII_CHAR_P): Use it.
2199 * casefiddle.c (casify_object):
2200 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2201 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2202 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2203 * dispextern.h (FACE_FROM_ID):
2204 * keyboard.c (read_char): Use UNSIGNED_CMP.
2206 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2207 not to EMACS_INT, to avoid GCC warning.
2209 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2211 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2212 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2213 isn't needed on 32-bit machines.
2215 * buffer.c (Fgenerate_new_buffer_name):
2216 Use EMACS_INT for count, not int.
2217 (advance_to_char_boundary): Return EMACS_INT, not int.
2219 * data.c (Qcompiled_function): Now static.
2221 * window.c (window_body_lines): Now static.
2223 * image.c (gif_load): Rename local to avoid shadowing.
2225 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2226 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2227 * alloc.c (make_save_value): Integer argument is now of type
2229 (mark_object): Use ptrdiff_t, not int.
2230 * lisp.h (pD): New macro.
2231 * print.c (print_object): Use it.
2233 * alloc.c: Use EMACS_INT, not int, to count objects.
2234 (total_conses, total_markers, total_symbols, total_vector_size)
2235 (total_free_conses, total_free_markers, total_free_symbols)
2236 (total_free_floats, total_floats, total_free_intervals)
2237 (total_intervals, total_strings, total_free_strings):
2238 Now EMACS_INT, not int. All uses changed.
2239 (Fgarbage_collect): Compute overall total using a double, so that
2240 integer overflow is less likely to be a problem. Check for overflow
2241 when converting back to an integer.
2242 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2243 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2244 These were 'int' variables that could overflow on 64-bit hosts;
2245 they were never used, so remove them instead of repairing them.
2246 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2247 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2248 Previously, this ceilinged at INT_MAX, but that doesn't work on
2250 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2252 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2253 (allocate_vectorlike): Check for ptrdiff_t overflow.
2254 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2255 when a (possibly-narrower) signed value would do just as well.
2256 We prefer using signed arithmetic, to avoid comparison confusion.
2258 * alloc.c: Catch some string size overflows that we were missing.
2259 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2260 for convenience in STRING_BYTES_MAX.
2261 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2262 The definition here is exact; the one in lisp.h was approximate.
2263 (allocate_string_data): Check for string overflow. This catches
2264 some instances we weren't catching before. Also, it catches
2265 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2266 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2267 and ptrdiff_t and EMACS_INT are both 64 bits.
2269 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2270 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2271 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2273 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2275 * alloc.c (Fmake_string): Check for out-of-range init.
2277 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2279 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2281 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2283 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2284 xg_get_default_scrollbar_width.
2286 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2287 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2288 (style_changed_cb): Call update_theme_scrollbar_width and call
2289 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2290 all frames (Bug#8505).
2291 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2292 Call gtk_window_set_resizable if HAVE_GTK3.
2293 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2294 and height if HAVE_GTK3 (Bug#8505).
2295 (scroll_bar_width_for_theme): New variable.
2296 (update_theme_scrollbar_width): New function.
2297 (xg_get_default_scrollbar_width): Move code to
2298 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2299 (xg_initialize): Call update_theme_scrollbar_width.
2301 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2303 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2305 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2307 * frame.c (make_frame): Call other_buffer_safely instead of
2310 * window.c (temp_output_buffer_show): Call display_buffer with
2311 second argument Vtemp_buffer_show_specifiers and reset latter
2312 immediately after the call.
2313 (Vtemp_buffer_show_specifiers): New variable.
2314 (auto_window_vscroll_p, next_screen_context_lines)
2315 (Vscroll_preserve_screen_position): Remove leading asterisks from
2318 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2320 Fix minor problems found by GCC 4.6.0 static checking.
2321 * buffer.c (Qclone_number): Remove for now, as it's unused.
2322 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2323 (record_buffer): Remove unused local.
2324 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2325 (set_frame_buffer_list): Remove; unused.
2326 * frame.h (other_visible_frames): Remove decl.
2327 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2328 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2329 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2331 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2332 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2333 Define only if HAVE_GPM.
2334 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2335 (update_hints_inhibit): Remove; never set. All uses removed.
2336 * widgetprv.h (emacsFrameClassRec): Remove decl.
2337 * window.c (delete_deletable_window): Now returns void, since it
2338 wasn't returning anything.
2339 (compare_window_configurations): Remove unused locals.
2340 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2341 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2342 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2343 the same widths as pointers. This follows up on the 2011-05-06 patch.
2344 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2345 * xterm.h: Likewise.
2346 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2348 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2350 * makefile.w32-in: Update dependencies.
2351 (LISP_H): Add lib/intprops.h.
2353 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2355 * image.c (gif_load): Add animation frame delay to the metadata.
2356 (syms_of_image): Use DEFSYM. New symbol `delay'.
2358 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2360 * window.c (delete_deletable_window): Re-add.
2361 (Fset_window_configuration): Rewrite to handle dead buffers and
2362 consequently deletable windows.
2363 (window_tree, Fwindow_tree): Remove. Supply functionality in
2365 (compare_window_configurations): Simplify code.
2367 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2369 * image.c (imagemagick_load_image): Fix type mismatch.
2370 (Fimagemagick_types): Likewise.
2372 * window.h (replace_buffer_in_windows): Declare.
2374 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2376 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2377 Qclone_number. Remove external declaration of Qdelete_window.
2378 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2380 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2381 Run Qbuffer_list_update_hook if allowed.
2382 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2383 buffer list implementation.
2384 (other_buffer_safely): New function.
2385 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2386 calls to replace_buffer_in_windows and
2387 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2389 (record_buffer): Inhibit quitting and rewrite using quittable
2390 functions. Run Qbuffer_list_update_hook if allowed.
2391 (Frecord_buffer, Funrecord_buffer): New functions.
2392 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2393 Move switch-to-buffer to window.el.
2394 (bury-buffer): Move to window.el.
2395 (Vbuffer_list_update_hook): New variable.
2397 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2400 * window.h (resize_frame_windows): Move up in code.
2401 (Fwindow_frame): Remove EXFUN.
2402 (replace_buffer_in_all_windows): Remove prototype.
2403 (replace_buffer_in_windows_safely): Add prototype.
2405 * window.c: Declare Qdelete_window static again. Move down
2406 declaration of select_count.
2407 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2408 (Fother_window): Move to window.el.
2409 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2410 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2411 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2413 (replace_buffer_in_windows): Implement by calling
2414 Qreplace_buffer_in_windows.
2415 (replace_buffer_in_all_windows): Remove with some functionality
2416 moved into replace_buffer_in_windows_safely.
2417 (replace_buffer_in_windows_safely): New function.
2418 (select_window_norecord, select_frame_norecord): Move in front
2419 of run_window_configuration_change_hook. Remove now obsolete
2421 (Fset_window_buffer): Rewrite doc-string.
2422 Call Qrecord_window_buffer.
2423 (keys_of_window): Move binding for other-window to window.el.
2425 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2427 * dispextern.h (struct image): Replace data member, whose int_val
2428 and ptr_val fields were not used by anything, with a single
2431 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2432 (gif_clear_image, gif_load, imagemagick_load_image)
2433 (gs_clear_image, gs_load): Callers changed.
2435 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2437 * buffer.h: Include <time.h>, for time_t.
2438 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2440 Fix minor problems found by static checking.
2442 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2444 Make identifiers static if they are not used in other modules.
2445 * data.c (Qcompiled_function, Qframe, Qvector):
2446 * image.c (QimageMagick, Qsvg):
2447 * minibuf.c (Qmetadata):
2448 * window.c (resize_window_check, resize_root_window): Now static.
2449 * window.h (resize_window_check, resize_root_window): Remove decls.
2451 * window.c (window_deletion_count, delete_deletable_window):
2453 (window_body_lines): Now static.
2454 (Fdelete_other_windows_internal): Mark vars as initialized.
2455 Make sure 'resize_failed' is initialized.
2456 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2457 (resize_window_apply): Remove unused local.
2458 * window.h (delete_deletable_window): Remove decl.
2460 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2461 (imagemagick_load_image): Fix pointer signedness problem by changing
2462 last arg from unsigned char * to char *. All uses changed.
2463 Also, fix a local for similar reasons.
2464 Remove unused locals. Remove locals to avoid shadowing.
2465 (fn_rsvg_handle_free): Remove; unused.
2466 (svg_load, svg_load_image): Fix pointer signedness problem.
2467 (imagemagick_load_image): Don't use garbage pointer image_wand.
2469 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2471 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2473 * image.c (gif_load): Fix omitted cast error introduced by
2476 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2478 * window.h (resize_proportionally, orig_total_lines)
2479 (orig_top_line): Remove from window structure.
2480 (set_window_height, set_window_width, change_window_heights)
2481 (Fdelete_window): Remove prototypes.
2482 (resize_frame_windows): Remove duplicate declaration.
2484 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2486 * window.h (resize_frame_windows, resize_window_check)
2487 (delete_deletable_window, resize_root_window)
2488 (resize_frame_windows): Declare prototypes.
2490 * window.c (resize_window_apply): Make definition be "static" to
2491 match the prototype.
2493 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2495 * window.c: Remove declarations of Qwindow_size_fixed,
2496 window_min_size_1, window_min_size_2, window_min_size,
2497 size_window, window_fixed_size_p, enlarge_window, delete_window.
2498 Remove static from declaration of Qdelete_window, it's
2499 temporarily needed by Fbury_buffer.
2500 (replace_window): Don't assign orig_top_line and
2502 (Fdelete_window, delete_window): Remove. Window deletion is
2503 handled by window.el.
2504 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2505 Replace Fdelete_window calls with calls to Qdelete_window.
2506 (Fdelete_other_windows): Remove. Deleting other windows is
2507 handled by window.el.
2508 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2509 handled in window.el.
2510 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2511 Window minimum sizes are handled in window.el.
2512 (shrink_windows, size_window, set_window_height)
2513 (set_window_width, change_window_heights, window_height)
2514 (window_width, CURBEG, CURSIZE, enlarge_window)
2515 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2516 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2517 handled in window.el.
2518 (make_dummy_parent): Rename to make_parent_window and give it a
2519 second argument horflag.
2520 (make_window): Don't set resize_proportionally any more.
2521 (Fsplit_window): Remove. Windows are split in window.el.
2522 (save_restore_action, save_restore_orig_size)
2523 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2524 Resize mini windows in window.el.
2525 (grow_mini_window, shrink_mini_window): Implement by calling
2526 Qresize_root_window_vertically, resize_window_check and
2527 resize_window_apply.
2528 (saved_window, Fset_window_configuration, save_window_save):
2529 Do not handle orig_top_line, orig_total_lines, and
2530 resize_proportionally.
2531 (window_min_height, window_min_width): Move to window.el.
2532 (keys_of_window): Move bindings for delete-other-windows,
2533 split-window, delete-window and enlarge-window to window.el.
2535 * buffer.c: Temporarily extern Qdelete_window.
2536 (Fbury_buffer): Temporarily call Qdelete_window instead of
2537 Fdelete_window (Fbury_buffer will move to window.el soon).
2539 * frame.c (set_menu_bar_lines_1): Remove code handling
2540 orig_top_line and orig_total_lines.
2542 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2543 set_window_height but set heights directly.
2544 (change_frame_size_1): Use resize_frame_windows.
2546 * xdisp.c (init_xdisp): Don't use set_window_height but set
2549 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2550 Use resize_frame_windows instead of change_window_heights and run
2551 run_window_configuration_change_hook.
2553 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2554 instead of change_window_heights and run
2555 run_window_configuration_change_hook.
2557 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2559 * window.c (replace_window): Rename second argument REPLACEMENT to
2560 NEW. New third argument SETFLAG. Rewrite.
2561 (delete_window, make_dummy_parent): Call replace_window with
2563 (window_list_1): Move down in code.
2564 (run_window_configuration_change_hook): Move set_buffer part
2565 before select_frame_norecord part in order to unwind correctly.
2566 Rename count1 to count.
2567 (recombine_windows, delete_deletable_window, resize_root_window)
2568 (Fdelete_other_windows_internal)
2569 (Frun_window_configuration_change_hook, make_parent_window)
2570 (resize_window_check, resize_window_apply, Fresize_window_apply)
2571 (resize_frame_windows, Fsplit_window_internal)
2572 (Fdelete_window_internal, Fresize_mini_window_internal):
2574 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2576 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2578 * window.h (window): Add some new members to window structure -
2579 normal_lines, normal_cols, new_total, new_normal, clone_number,
2580 splits, nest, prev_buffers, next_buffers.
2581 (WINDOW_TOTAL_SIZE): Move here from window.c.
2582 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2584 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2586 (make_dummy_parent): Set new members of windows structure.
2587 (make_window): Move down in code. Handle new members of window
2589 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2590 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2591 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2592 (Fset_window_prev_buffers, Fwindow_next_buffers)
2593 (Fset_window_next_buffers, Fset_window_clone_number):
2595 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2596 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2598 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2599 Argument WINDOW can be now internal window too.
2600 (Fwindow_use_time): Move up in code.
2601 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2603 (Fset_window_configuration, saved_window)
2604 (Fcurrent_window_configuration, save_window_save): Handle new
2605 members of window structure.
2606 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2607 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2608 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2609 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2610 Qget_mru_window, Qresize_root_window,
2611 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2612 Qauto_buffer_name; staticpro them.
2614 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2616 * window.c (Fwindow_total_size, Fwindow_left_column)
2617 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2618 (Fwindow_list_1): New functions.
2619 (window_box_text_cols): Replace with window_body_cols.
2620 (Fwindow_width, Fscroll_left, Fscroll_right):
2621 Use window_body_cols instead of window_box_text_cols.
2622 (delete_window, Fset_window_configuration):
2623 Call delete_all_subwindows with window as argument.
2624 (delete_all_subwindows): Take a window as argument and not a
2626 (window_loop): Remove handling of GET_LRU_WINDOW and
2628 (Fget_lru_window, Fget_largest_window): Move to window.el.
2630 * window.h: Extern window_body_cols instead of
2631 window_box_text_cols. delete_all_subwindows now takes a
2632 Lisp_Object as argument.
2634 * indent.c (compute_motion, Fcompute_motion):
2635 Use window_body_cols instead of window_box_text_cols.
2637 * frame.c (delete_frame): Call delete_all_subwindows with root
2640 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2642 * fns.c (Fputhash): Document return value.
2644 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2646 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2648 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2650 Cons<->int and similar integer overflow fixes (Bug#8794).
2652 Check for overflow when converting integer to cons and back.
2653 * charset.c (Fdefine_charset_internal, Fdecode_char):
2654 Use cons_to_unsigned to catch overflow.
2655 (Fencode_char): Use INTEGER_TO_CONS.
2656 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2657 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2658 * data.c (long_to_cons, cons_to_long): Remove.
2659 (cons_to_unsigned, cons_to_signed): New functions.
2660 These signal an error for invalid or out-of-range values.
2661 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2662 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2663 * font.c (Ffont_variation_glyphs):
2664 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2665 * lisp.h: Include <intprops.h>.
2666 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2667 (cons_to_signed, cons_to_unsigned): New decls.
2668 (long_to_cons, cons_to_long): Remove decls.
2669 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2670 (Fprimitive_undo): Use CONS_TO_INTEGER.
2671 * xfns.c (Fx_window_property): Likewise.
2672 * xselect.c: Include <limits.h>.
2673 (x_own_selection, selection_data_to_lisp_data):
2674 Use INTEGER_TO_CONS.
2675 (x_handle_selection_request, x_handle_selection_clear)
2676 (x_get_foreign_selection, Fx_disown_selection_internal)
2677 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2678 (lisp_data_to_selection_data): Use cons_to_unsigned.
2679 (x_fill_property_data): Use cons_to_signed.
2680 Report values out of range.
2682 Check for buffer and string overflow more precisely.
2683 * buffer.h (BUF_BYTES_MAX): New macro.
2684 * lisp.h (STRING_BYTES_MAX): New macro.
2685 * alloc.c (Fmake_string):
2686 * character.c (string_escape_byte8):
2687 * coding.c (coding_alloc_by_realloc):
2688 * doprnt.c (doprnt):
2689 * editfns.c (Fformat):
2691 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2692 since they may not be the same number.
2693 * editfns.c (Finsert_char):
2694 * fileio.c (Finsert_file_contents):
2695 Likewise for BUF_BYTES_MAX.
2697 * image.c: Use ptrdiff_t, not int, for sizes.
2698 (slurp_file): Switch from int to ptrdiff_t.
2700 (slurp_file): Check that file size fits in both size_t (for
2701 malloc) and ptrdiff_t (for sanity and safety).
2703 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2704 if b->modtime has its maximal value.
2706 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2708 Don't assume time_t can fit into int.
2709 * buffer.h (struct buffer.modtime): Now time_t, not int.
2710 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2711 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2713 Minor fixes for signed vs unsigned integers.
2714 * character.h (MAYBE_UNIFY_CHAR):
2715 * charset.c (maybe_unify_char):
2716 * keyboard.c (read_char, reorder_modifiers):
2717 XINT -> XFASTINT, since the integer must be nonnegative.
2718 * ftfont.c (ftfont_spec_pattern):
2719 * keymap.c (access_keymap, silly_event_symbol_error):
2720 XUINT -> XFASTINT, since the integer must be nonnegative.
2721 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2722 since it makes no difference and we prefer signed.
2723 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2724 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2727 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2729 * window.h (Fwindow_frame): Declare.
2731 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2733 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2734 (SPARE_MEMORY): Always define.
2735 (LARGE_REQUEST): Remove.
2736 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2738 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2740 * lisp.h: Move EXFUNS for Fframe_root_window,
2741 Fframe_first_window and Fset_frame_selected_window to window.h.
2743 * window.h: Move EXFUNS for Fframe_root_window,
2744 Fframe_first_window and Fset_frame_selected_window here from
2747 * frame.c (Fwindow_frame, Fframe_first_window)
2748 (Fframe_root_window, Fframe_selected_window)
2749 (Fset_frame_selected_window): Move to window.c.
2750 (Factive_minibuffer_window): Move to minibuf.c.
2751 (Fother_visible_frames_p): New function.
2753 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2755 * window.c (decode_window, decode_any_window): Move up in code.
2756 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2757 (inhibit_frame_unsplittable): Remove unused variable.
2758 (Fwindow_buffer): Move up and rewrite doc-string.
2759 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2760 (Fwindow_prev): New functions.
2761 (Fwindow_frame): Move here from frame.c. Accept any window as
2763 (Fframe_root_window, Fframe_first_window)
2764 (Fframe_selected_window): Move here from frame.c. Accept frame
2765 or arbitrary window as argument. Update doc-strings.
2766 (Fminibuffer_window): Move up in code.
2767 (Fwindow_minibuffer_p): Move up in code and simplify.
2768 (Fset_frame_selected_window): Move here from frame.c.
2770 (Fselected_window, select_window, Fselect_window): Move up in
2771 code. Minor doc-string fixes.
2773 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2775 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2776 Do not assume that spare memory exists; that assumption is valid
2777 only if SYSTEM_MALLOC.
2778 (LARGE_REQUEST): New macro, so that the issue of large requests
2779 is separated from the issue of spare memory.
2781 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2783 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2786 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2788 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2791 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2793 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2795 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2797 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2798 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2800 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2802 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2804 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2806 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2807 (x_clipboard_manager_save): Add return value.
2808 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2810 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2811 Obey Vx_select_enable_clipboard_manager. Catch errors in
2812 x_clipboard_manager_save (Bug#8779).
2813 (Vx_select_enable_clipboard_manager): New variable.
2814 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2816 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2818 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2820 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2822 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2823 in the current matrix if keep_current_p is non-zero.
2825 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2827 * bidi.c (bidi_level_of_next_char): Fix last change.
2829 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2831 Support bidi reordering of text covered by display properties.
2833 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2834 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2835 (bidi_cache_search, bidi_cache_iterator_state)
2836 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2837 (bidi_level_of_next_char, bidi_move_to_visually_next):
2838 Support character positions inside a run of characters covered by a
2840 (bidi_paragraph_init, bidi_resolve_explicit_1)
2841 (bidi_level_of_next_char): Call bidi_fetch_char and
2842 bidi_fetch_char_advance instead of FETCH_CHAR and
2844 (bidi_init_it): Initialize new members.
2845 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2847 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2848 instead of using explicit *_CHAR codes.
2849 (bidi_resolve_explicit, bidi_resolve_weak):
2850 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2851 bidirectional text is supported only in multibyte buffers.
2852 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2853 it to initialize the frame_window_p member of struct bidi_it.
2854 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2855 (bidi_resolve_explicit, bidi_resolve_weak)
2856 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2857 bidi_it->nchars is non-positive.
2858 (bidi_level_of_next_char): Don't try to lookup the cache for the
2859 next/previous character if nothing is cached there yet, or if we
2860 were just reseat()'ed to a new position.
2862 * xdisp.c (set_cursor_from_row): Set start and stop points
2863 according to the row's direction when priming the loop that looks
2864 for the glyph on which to display cursor.
2865 (single_display_spec_intangible_p): Function deleted.
2866 (display_prop_intangible_p): Reimplement to call
2867 handle_display_spec instead of single_display_spec_intangible_p.
2868 Accept 3 additional arguments needed by handle_display_spec.
2869 This fixes incorrect cursor motion across display property with complex
2870 values: lists, `(when COND...)' forms, etc.
2871 (single_display_spec_string_p): Support property values that are
2872 lists with the argument STRING its top-level element.
2873 (display_prop_string_p): Fix the condition for processing a
2874 property that is a list to be consistent with handle_display_spec.
2875 (handle_display_spec): New function, refactored from the
2876 last portion of handle_display_prop.
2877 (compute_display_string_pos): Accept additional argument
2878 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2879 value of a `display' property is a "replacing spec".
2880 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2881 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2882 the display property, but just return a value indicating whether
2883 the display property will replace the characters it covers.
2884 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2885 frame_window_p members of struct bidi_it.
2886 (compute_display_string_pos, compute_display_string_end):
2888 (push_it): Accept second argument POSITION, where pop_it should
2889 jump to continue iteration.
2890 (reseat_1): Initialize bidi_it.disp_pos.
2892 * keyboard.c (adjust_point_for_property): Adjust the call to
2893 display_prop_intangible_p to its new signature.
2895 * dispextern.h (struct bidi_it): New member frame_window_p.
2896 (bidi_init_it): Update prototypes.
2897 (display_prop_intangible_p): Update prototype.
2898 (compute_display_string_pos, compute_display_string_end):
2900 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2903 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2905 Malloc failure behavior now depends on size of allocation.
2906 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2907 * lisp.h: Change signatures accordingly.
2908 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2909 All callers changed. (Bug#8762)
2911 * gnutls.c: Use Emacs's memory allocators.
2912 Without this change, the gnutls library would invoke malloc etc.
2913 directly, which causes problems on non-SYNC_INPUT hosts, and which
2914 runs afoul of improving memory_full behavior. (Bug#8761)
2915 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2916 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2917 xfree instead of the default malloc, realloc, free.
2918 (Fgnutls_boot): No need to check for memory allocation failure,
2919 since xmalloc does that for us.
2921 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2922 * category.c (hash_get_category_set):
2923 * ccl.c (ccl_driver):
2924 * charset.c (Fdefine_charset_internal):
2925 * charset.h (struct charset.hash_index):
2926 * composite.c (get_composition_id, gstring_lookup_cache)
2927 (composition_gstring_put_cache):
2928 * composite.h (struct composition.hash_index):
2929 * dispextern.h (struct image.hash):
2930 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2931 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2932 (hashfn_equal, hashfn_user_defined, make_hash_table)
2933 (maybe_resize_hash_table, hash_lookup, hash_put)
2934 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2935 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2936 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2937 * image.c (make_image, search_image_cache, lookup_image)
2938 (xpm_put_color_table_h):
2939 * lisp.h (struct Lisp_Hash_Table):
2940 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2941 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2942 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2943 * alloc.c (allocate_vectorlike):
2944 Check for overflow in vector size calculations.
2945 * ccl.c (ccl_driver):
2946 Check for overflow when converting EMACS_INT to int.
2947 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2948 need to be updated by these changes.
2949 * fns.c (make_hash_table, maybe_resize_hash_table):
2950 Check for integer overflow with large hash tables.
2951 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2952 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2953 (SXHASH_REDUCE): New macro.
2954 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2955 Use it instead of discarding useful hash info with large hash values.
2956 (sxhash_float): New function.
2957 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2958 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2959 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2960 Rewrite to use FIXNUM_BITS, as this simplifies things.
2961 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2962 Adjust signatures to match updated version of code.
2963 (consing_since_gc): Now EMACS_INT, since a single hash table can
2964 use more than INT_MAX bytes.
2966 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2968 Make it possible to build with GCC-4.6+ -O2 -flto.
2970 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2972 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2974 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2975 Call minibuffer-inactive-mode.
2977 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2979 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2980 Update dependencies.
2982 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2984 * data.c (init_data): Remove code for UTS, this system is not
2987 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2989 Don't force ./temacs to start in terminal mode.
2991 * frame.c (make_initial_frame): Initialize faces in all cases, not
2992 only when CANNOT_DUMP is defined.
2993 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2995 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2997 * dispnew.c (add_window_display_history): Use const for the string
2998 pointer. Remove declaration, not needed.
3000 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3002 Use 'inline', not 'INLINE'.
3003 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3004 * alloc.c, fontset.c (INLINE): Remove.
3005 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3006 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3007 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3008 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3009 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3011 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3013 Make it possible to run ./temacs.
3015 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3016 syms_of_callproc does the same thing. Remove test for
3017 "initialized", do it in the caller.
3018 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3020 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3022 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3023 (read_minibuf): Use get_minibuffer.
3024 (syms_of_minibuf): Use DEFSYM.
3025 (Qmetadata): New var.
3026 * data.c (Qbuffer): Don't make it static.
3027 (syms_of_data): Use DEFSYM.
3029 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3031 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3032 (CCL_CODE_MIN): New macro.
3034 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3036 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3038 * eval.c (Qdebug): Now static.
3039 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3040 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3041 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3043 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3045 * image.c: Various fixes to ImageMagick code comments.
3046 (Fimagemagick_types): Doc fix.
3048 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3050 Minor fixes prompted by GCC 4.6.0 warnings.
3052 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3054 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3055 (x_clipboard_manager_save_all): Move extern decl to ...
3056 * xterm.h: ... here, so that it can be checked for consistency.
3058 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3060 * xselect.c (x_clipboard_manager_save_frame)
3061 (x_clipboard_manager_save_all): New functions.
3062 (Fx_clipboard_manager_save): Lisp function deleted.
3064 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3065 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3067 * xterm.h: Update prototype.
3069 2011-05-28 William Xu <william.xwl@gmail.com>
3071 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3074 2011-05-28 Jim Meyering <meyering@redhat.com>
3076 Avoid a sign-extension bug in crypto_hash_function.
3077 * fns.c (to_uchar): Define.
3078 (crypto_hash_function): Use it to convert some newly-signed
3079 variables to unsigned, to avoid sign-extension bugs. For example,
3080 without this change, (md5 "truc") would evaluate to
3081 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3082 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3083 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3085 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3087 Integer overflow fixes.
3089 * dbusbind.c: Serial number integer overflow fixes.
3090 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3091 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3092 to hold a serial number that is too large for a fixnum.
3093 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3094 Check for serial numbers out of range. Decode any serial number
3095 that was so large that it became a float. (Bug#8722)
3097 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3098 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3099 Use XFASTINT rather than XUINT when numbers are nonnegative.
3100 (xd_append_arg, Fdbus_method_return_internal):
3101 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3102 arguments, check that Lisp number is nonnegative, rather than
3103 silently wrapping negative numbers around. (Bug#8722)
3104 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3107 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3109 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3111 ccl: add integer overflow checks
3112 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3113 (IN_INT_RANGE): New macros.
3114 (ccl_driver): Use them to check for integer overflow when
3115 decoding a CCL program. Many of the new checks are whether XINT (x)
3116 fits in int; it doesn't always, on 64-bit hosts. The new version
3117 doesn't catch all possible integer overflows, but it's an
3118 improvement. (Bug#8719)
3120 * alloc.c (make_event_array): Use XINT, not XUINT.
3121 There's no need for unsigned here.
3123 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3124 This follows up to the 2011-05-06 change that substituted uintptr_t
3125 for EMACS_INT. This case wasn't caught back then.
3127 Rework Fformat to avoid integer overflow issues.
3128 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3129 now (part of C89). Include <verify.h>.
3130 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3131 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3132 (Fformat): Avoid the prepass trying to compute sizes; it was only
3133 approximate and thus did not catch overflow reliably. Instead, walk
3134 through the format just once, formatting and computing sizes as we go,
3135 checking for integer overflow at every step, and allocating a larger
3136 buffer as needed. Keep track separately whether the format is
3137 multibyte. Keep only the most-recently calculated precision, rather
3138 than them all. Record whether each argument has been converted to
3139 string. Use EMACS_INT, not int, for byte and char and arg counts.
3140 Support field widths and precisions larger than INT_MAX. Avoid
3141 sprintf's undefined behavior with conversion specifications such as %#d
3142 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3143 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3144 formatting out-of-range floating point numbers with int
3147 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3149 * data.c: Avoid integer truncation in expressions involving floats.
3150 * data.c: Include <intprops.h>.
3151 (arith_driver): When there's an integer overflow in an expression
3152 involving floating point, convert the integers to floating point
3153 so that the resulting value does not suffer from catastrophic
3154 integer truncation. For example, on a 64-bit host (* 4
3155 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3156 Do not rely on undefined behavior after integer overflow.
3158 merge count_size_as_multibyte, parse_str_to_multibyte
3159 * character.c, character.h (count_size_as_multibyte):
3160 Rename from parse_str_to_multibyte; all uses changed.
3161 Check for integer overflow.
3162 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3163 since it's now a duplicate of the other. This is more of
3164 a character than a buffer op, so better that it's in character.c.
3165 * fns.c, print.c: Adjust to above changes.
3167 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3169 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3171 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3173 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3174 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3175 (x_clipboard_manager_save): Now static.
3176 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3178 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3179 (crypto_hash_function): Now static.
3180 Fix pointer signedness problems. Avoid unnecessary initializations.
3182 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3184 * termhooks.h (Vselection_alist): Make it terminal-local.
3186 * terminal.c (create_terminal): Initialize it.
3188 * xselect.c: Support for clipboard managers.
3189 (Vselection_alist): Move to termhooks.h as terminal-local var.
3190 (LOCAL_SELECTION): New macro.
3191 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3192 (symbol_to_x_atom): Remove gratuitous arg.
3193 (x_handle_selection_request, lisp_data_to_selection_data)
3194 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3195 (x_own_selection, x_get_local_selection, x_convert_selection):
3196 New arg, specifying work frame. Use terminal-local Vselection_alist.
3197 (some_frame_on_display): Delete unused function.
3198 (Fx_own_selection_internal, Fx_get_selection_internal)
3199 (Fx_disown_selection_internal, Fx_selection_owner_p)
3200 (Fx_selection_exists_p): New optional frame arg.
3201 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3202 (x_handle_selection_clear): Don't treat other terminals with the
3203 same keyboard specially. Use the terminal-local Vselection_alist.
3204 (x_clear_frame_selections): Use Frun_hook_with_args.
3206 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3208 * xterm.h: Add support for those atoms.
3210 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3212 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3213 (converted_selections, conversion_fail_tag): New global variables.
3214 (x_selection_request_lisp_error): Free the above.
3215 (x_get_local_selection): Remove unnecessary code.
3216 (x_reply_selection_request): Args changed; handle arbitrary array
3217 of converted selections stored in converted_selections.
3218 Separate the XChangeProperty and SelectionNotify steps.
3219 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3220 (x_convert_selection): New function.
3221 (x_handle_selection_event): Simplify.
3222 (x_get_foreign_selection): Don't ignore incoming requests while
3223 waiting for an answer; this will fail when we implement
3224 SAVE_TARGETS, and seems unnecessary anyway.
3225 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3226 (Vx_sent_selection_functions): Doc fix.
3228 2011-05-26 Leo Liu <sdl.web@gmail.com>
3230 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3232 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3234 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3236 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3237 for fringe update if it has periodic bitmap.
3238 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3239 and fringe_bitmap_periodic_p.
3241 * fringe.c (get_fringe_bitmap_data): New function.
3242 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3243 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3244 row. Mark glyph row for fringe update if periodicity changed.
3246 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3247 for fringe update unless it has periodic bitmap.
3249 2011-05-25 Kenichi Handa <handa@m17n.org>
3251 * xdisp.c (get_next_display_element): Set correct it->face_id for
3252 a static composition.
3254 2011-05-24 Leo Liu <sdl.web@gmail.com>
3257 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3259 * fns.c (crypto_hash_function, Fsha1): New function.
3260 (Fmd5): Use crypto_hash_function.
3261 (syms_of_fns): Add Ssha1.
3263 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3265 * gnutls.c: Remove unused macros.
3266 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3267 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3268 Remove macros that are defined and never used.
3269 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3271 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3273 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3274 (Fx_get_selection_internal): Minor cleanup.
3275 (Fx_own_selection_internal): Rename arguments for consistency with
3278 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3280 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3282 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3284 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3286 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3288 * dispnew.c (scrolling_window): Don't exclude the case that the
3289 last enabled row in the desired matrix touches the bottom boundary.
3291 2011-05-21 Glenn Morris <rgm@gnu.org>
3293 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3294 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3295 and add some more files.
3297 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3299 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3300 report_file_error introduced by the change from 2011-05-07.
3302 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3304 * systime.h (Time): Define only if emacs is defined.
3305 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3306 where the include path doesn't have X11/X.h by default. See
3307 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3309 2011-05-20 Kenichi Handa <handa@m17n.org>
3311 * composite.c (find_automatic_composition): Fix previous change.
3313 2011-05-20 Glenn Morris <rgm@gnu.org>
3315 * lisp.mk: New file, split from Makefile.in.
3316 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3317 (shortlisp): Remove.
3318 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3320 2011-05-19 Glenn Morris <rgm@gnu.org>
3322 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3323 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3324 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3325 (lisp): Set the order to that of loadup.el.
3326 (shortlisp): Make it a copy of $lisp.
3327 (SOME_MACHINE_LISP): Remove.
3328 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3329 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3331 2011-05-18 Kenichi Handa <handa@m17n.org>
3333 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3334 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3335 (find_automatic_composition): Mostly rewrite for efficiency.
3337 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3339 * makefile.w32-in: Update dependencies.
3341 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3343 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3344 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3346 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3348 Fix some integer overflow issues, such as string length overflow.
3350 * insdel.c (count_size_as_multibyte): Check for string overflow.
3352 * character.c (lisp_string_width): Check for string overflow.
3353 Use EMACS_INT, not int, for string indexes and lengths; in
3354 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3355 the resulting string length overflows an EMACS_INT; instead,
3356 report a string overflow if no precision given. When checking for
3357 precision exhaustion, use a check that cannot possibly have
3358 integer overflow. (Bug#8675)
3359 * character.h (lisp_string_width): Adjust to new signature.
3361 * alloc.c (string_overflow): New function.
3362 (Fmake_string): Use it. This doesn't change behavior, but saves
3363 a few bytes and will simplify future changes.
3364 * character.c (string_escape_byte8): Likewise.
3365 * lisp.h (string_overflow): New decl.
3367 Fixups, following up to the user-interface timestamp change.
3368 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3369 for UI timestamps, instead of unsigned long.
3370 * msdos.c (mouse_get_pos): Likewise.
3371 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3372 * w32gui.h (Time): Define by including "systime.h" rather than by
3373 declaring it ourselves. (Bug#8664)
3375 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3376 * image.c (clear_image_cache): Likewise.
3378 * term.c (term_mouse_position): Don't assume time_t wraparound.
3380 Be more systematic about user-interface timestamps.
3381 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3382 and sometimes 'EMACS_UINT', to represent these timestamps.
3383 This change causes it to use 'Time' uniformly, as that's what X uses.
3384 This makes the code easier to follow, and makes it easier to catch
3385 integer overflow bugs such as Bug#8664.
3386 * frame.c (Fmouse_position, Fmouse_pixel_position):
3387 Use Time, not unsigned long, for user-interface timestamps.
3388 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3389 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3390 * keyboard.h (last_event_timestamp): Likewise.
3391 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3392 * menu.h (xmenu_show): Likewise.
3393 * term.c (term_mouse_position): Likewise.
3394 * termhooks.h (struct input_event.timestamp): Likewise.
3395 (struct terminal.mouse_position_hook): Likewise.
3396 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3397 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3398 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3399 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3401 * menu.h, termhooks.h: Include "systime.h", for Time.
3403 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3404 Don't assume that the difference between two unsigned long values
3405 can fit into an integer. At this point, we know button_down_time
3406 <= event->timestamp, so the difference must be nonnegative, so
3407 there's no need to cast the result if double-click-time is
3408 nonnegative, as it should be; check that it's nonnegative, just in
3409 case. This bug is triggered when events are more than 2**31 ms
3410 apart (about 25 days). (Bug#8664)
3412 * xselect.c (last_event_timestamp): Remove duplicate decl.
3413 (x_own_selection): Remove needless cast to unsigned long.
3415 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3416 that always fit in int. Use a sentinel instead of a counter, to
3417 avoid a temp and to allay GCC's concerns about possible int overflow.
3418 * frame.h (struct frame): Use int for menu_bar_items_used
3419 instead of EMACS_INT, since it always fits in int.
3421 * menu.c (grow_menu_items): Check for int overflow.
3423 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3425 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3426 Before, the code was not consistent. These values cannot exceed
3427 2**31 - 1 so there's no need to make them unsigned.
3428 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3429 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3430 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3432 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3434 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3435 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3436 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3437 presumably because the widths might not match.
3439 * window.c (size_window): Avoid needless test at loop start.
3441 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3443 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3445 2011-05-12 Drew Adams <drew.adams@oracle.com>
3447 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3449 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3451 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3452 `width' to `bar_area_x' and `bar_area_width', respectively.
3453 (x_scroll_run): Take account of fringe background extension.
3455 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3456 Rename local vars `left' and `width' to `bar_area_x' and
3457 `bar_area_width', respectively.
3458 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3459 background extension.
3461 2011-05-10 Jim Meyering <meyering@redhat.com>
3463 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3465 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3467 * image.c (Finit_image_library): Return t for built-in image types,
3468 like pbm and xbm. (Bug#8640)
3470 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3472 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3474 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3476 * w32console.c (Fset_screen_color): Doc fix.
3477 (Fget_screen_color): New function.
3478 (syms_of_ntterm): Defsubr it.
3480 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3481 unlink the temporary file if Fcall_process didn't create it in the
3483 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3484 child process will be redirected to a file specified with `:file'.
3485 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3486 cue to call_process_cleanup not to close that handle.
3488 2011-05-07 Ben Key <bkey76@gmail.com>
3490 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3491 one of two shell specific rules, either bootstrap-temacs-CMD or
3492 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3493 to the previous implementation of the bootstrap-temacs rule.
3494 The bootstrap-temacs-CMD rule is similar to the previous
3495 implementation of the bootstrap-temacs rule except that it
3496 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3499 These changes, along with some changes to nt/configure.bat,
3500 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3501 earlier fix to add support for --cflags and --ldflags options
3502 that include quotes so that it works whether make uses cmd or
3505 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3507 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3508 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3510 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3511 a string. Handle both cases.
3512 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3513 (Fdbus_register_method): Use Qinvalid_function.
3515 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3517 * makefile.w32-in: Update dependencies.
3518 (LISP_H): Add inttypes.h and stdin.h.
3519 (PROCESS_H): Add unistd.h.
3521 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3523 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3524 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3526 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3528 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3530 * term.c (vfatal): Remove stray call to va_end.
3531 It's not needed and the C Standard doesn't allow it here anyway.
3533 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3534 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3536 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3539 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3541 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3543 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3545 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3547 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3549 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3550 * charset.c (Fdefine_charset_internal): Don't initialize
3551 charset.code_space[15]. The value was garbage, on hosts with
3552 32-bit int (Bug#8600).
3554 * lread.c (read_integer): Be more consistent with string-to-number.
3555 Use string_to_number to do the actual conversion; this avoids
3556 rounding errors and fixes some other screwups. Without this fix,
3557 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3558 (digit_to_number): Move earlier, for benefit of read_integer.
3559 Return -1 if the digit is out of range for the base, -2 if it is
3560 not a digit in any supported base. (Bug#8602)
3562 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3564 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3565 to match comment at start of function. This also removes a
3566 GCC warning about overflow in a 32+64-bit port.
3568 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3570 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3571 Reported by Stefan Monnier in
3572 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3573 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3574 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3576 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3577 (EMACS_UINTPTR): Likewise, with uintptr_t.
3579 * lisp.h: Prefer 64-bit EMACS_INT if available.
3580 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3581 on 32-bit hosts that have 64-bit int, so that they can access
3583 However, temporarily disable this change unless the temporary
3584 symbol WIDE_EMACS_INT is defined.
3586 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3588 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3589 This removes an assumption that EMACS_INT and long are the same
3590 width as pointers. The assumption is true for Emacs porting targets
3591 now, but we want to make other targets possible.
3592 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3593 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3594 In the rest of the code, change types of integers that hold casted
3595 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3596 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3597 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3598 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3599 No need to cast type when ORing.
3600 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3601 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3602 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3603 assume EMACS_INT is the same width as char *.
3604 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3605 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3606 Remove no-longer-needed casts.
3607 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3608 (xg_tool_bar_help_callback, xg_make_tool_item):
3609 Use EMACS_INTPTR to hold an integer
3610 that will be cast to void *; this can avoid a GCC warning
3611 if EMACS_INT is not the same width as void *.
3612 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3613 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3614 (current_message_1, set_message_1):
3615 Use a local to convert to proper width without a cast.
3616 * xmenu.c (dialog_selection_callback): Likewise.
3618 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3619 Also, don't assume VALBITS / RAND_BITS is less than 5,
3620 and don't rely on undefined behavior when shifting a 1 left into
3622 * lisp.h (get_random): Change signature to match.
3624 * lread.c (hash_string): Use size_t, not int, for hash computation.
3625 Normally we prefer signed values; but hashing is special, because
3626 it's better to use unsigned division on hash table sizes so that
3627 the remainder is nonnegative. Also, size_t is the natural width
3628 for hashing into memory. The previous code used 'int', which doesn't
3629 retain enough info to hash well into very large tables.
3630 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3632 * dbusbind.c: Don't possibly lose pointer info when converting.
3633 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3634 Use XPNTR rather than XHASH, so that the high-order bits of
3635 the pointer aren't lost when converting through void *.
3637 * eval.c (Fautoload): Don't double-shift a pointer.
3639 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3641 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3643 * gnutls.c (DEF_GNUTLS_FN):
3644 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3646 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3648 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3651 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3653 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3654 New version that can reserve upto 2GB of heap space.
3656 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3658 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3660 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3662 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3663 `gnutls_certificate_set_x509_key_file'.
3665 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3667 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3668 Update dependencies.
3670 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3672 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3673 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3674 Remove unused parameter `fildes'.
3675 * process.c (read_process_output, send_process): Don't pass it.
3677 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3679 Fix previous change: the library cache is defined in w32.c.
3680 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3681 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3683 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3685 Implement dynamic loading of GnuTLS on Windows.
3687 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3688 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3689 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3692 * gnutls.c (Qgnutls_dll): Define.
3693 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3694 (gnutls_*): Declare function pointers.
3695 (init_gnutls_functions): New function to initialize function pointers.
3696 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3697 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3698 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3699 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3700 (emacs_gnutls_write, emacs_gnutls_read)
3701 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3702 (Fgnutls_available_p): New function.
3703 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3704 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3705 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3707 * image.c: Include w32.h.
3708 (Vimage_type_cache): Delete.
3709 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3710 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3711 (w32_delayed_load): Move to w32.c.
3713 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3715 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3716 (w32_delayed_load): Move from image.c. When loading a library, record
3717 its filename in the :loaded-from property of the library id.
3718 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3719 Initialize and staticpro them.
3720 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3722 * process.c: Include lisp.h before w32.h, not after.
3723 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3724 instead of gnutls_record_check_pending.
3726 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3728 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3730 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3731 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3734 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3736 * xterm.c (x_set_frame_alpha): Do not set property on anything
3737 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3739 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3741 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3743 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3745 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3746 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3747 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3748 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3749 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3750 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3751 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3752 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3753 (Qgnutls_bootprop_callbacks_verify): Make static.
3755 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3757 * callproc.c: Indentation fixup.
3759 * sysdep.c (wait_for_termination_1): Make static.
3760 (wait_for_termination, interruptible_wait_for_termination):
3761 Move after wait_for_termination_1.
3763 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3765 * sysdep.c (interruptible_wait_for_termination): New function
3766 which is like wait_for_termination, but allows keyboard
3769 * callproc.c (Fcall_process): Add (:file "file") as an option for
3771 (Fcall_process_region): Ditto.
3773 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3775 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3776 rather than `XVECTOR (FOO)->size'.
3778 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3779 inttypes.h, as a gnulib replacement is used if it not available in
3782 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3784 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3785 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3786 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3788 * coding.c (coding_alloc_by_realloc): Error out if destination
3789 will grow beyond MOST_POSITIVE_FIXNUM.
3790 (decode_coding_emacs_mule): Abort if there isn't enough place in
3791 charbuf for the composition carryover bytes. Reserve an extra
3792 space for up to 2 characters produced in a loop.
3793 (decode_coding_iso_2022): Abort if there isn't enough place in
3794 charbuf for the composition carryover bytes.
3796 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3798 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3799 aborting when %lld or %lll format is passed.
3800 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3801 %llo or %llx format is passed. (Bug#8545)
3803 * window.c (window_scroll_line_based): Use a marker instead of
3804 simple variables to record original value of point. (Bug#7952)
3806 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3807 produced by %s or %c overflows available buffer space. (Bug#8545)
3809 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3811 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3812 (SIZE_MAX): Move defn after all includes, as they might #define it.
3814 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3816 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3818 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3820 * keyboard.c (Qdelayed_warnings_hook): Define.
3821 (command_loop_1): Run `delayed-warnings-hook'
3822 if Vdelayed_warnings_list is non-nil.
3823 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3824 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3826 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3828 * doprnt.c (doprnt): Don't return value smaller than the buffer
3829 size if the message was truncated. (Bug#8545).
3831 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3833 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3834 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3836 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3838 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3840 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3842 * makefile.w32-in: Update dependencies.
3844 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3846 Improve `doprnt' and its usage. (Bug#8545)
3847 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3848 `format_end'. Remove support for %l as a conversion specifier.
3849 Don't use xrealloc. Improve diagnostics when the %l size modifier
3850 is used. Update the commentary.
3852 * eval.c (verror): Simplify calculation of size_t.
3854 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3857 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3859 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3862 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3864 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3865 This makes this file independent of the recent pseudovector change.
3867 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3869 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3871 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3872 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3873 Remove unused local.
3874 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3876 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3877 GCC 4.6.0 optimizes based on type-based alias analysis.
3878 For example, if b is of type struct buffer * and v of type struct
3879 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3880 != &v->size, and therefore "v->size = 1; b->size = 2; return
3881 v->size;" must therefore return 1. This assumption is incorrect
3882 for Emacs, since it type-puns struct Lisp_Vector * with many other
3883 types. To fix this problem, this patch adds a new type struct
3884 vectorlike_header that documents the constraints on layout of vectors
3885 and pseudovectors, and helps optimizing compilers not get fooled
3886 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3887 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3888 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3890 (XSETPVECTYPE): Rewrite in terms of new macro.
3891 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3892 This is a bit clearer, and further avoids the possibility of
3893 undesirable aliasing.
3894 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3895 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3896 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3897 since Lisp_Subr is a special case (no "next" field).
3898 (ASIZE): Now uses header.size rather than size.
3899 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3900 to avoid the hassle of writing XVECTOR (foo)->header.size.
3901 (struct vectorlike_header): New type.
3902 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3903 object, to help avoid aliasing.
3904 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3905 (SUBRP): Likewise, since Lisp_Subr is a special case.
3906 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3907 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3908 (struct Lisp_Hash_Table): Combine first two members into a single
3909 struct vectorlike_header member. All uses of "size" and "next" members
3910 changed to be "header.size" and "header.next".
3911 * buffer.h (struct buffer): Likewise.
3912 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3913 * frame.h (struct frame): Likewise.
3914 * process.h (struct Lisp_Process): Likewise.
3915 * termhooks.h (struct terminal): Likewise.
3916 * window.c (struct save_window_data, struct saved_window): Likewise.
3917 * window.h (struct window): Likewise.
3918 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3919 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3920 * buffer.c (init_buffer_once): Likewise.
3921 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3923 * process.c (Fformat_network_address): Use local var for size,
3926 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3928 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3929 * data.c (atof): Remove decl; no longer used or needed.
3930 (digit_to_number): Move to lread.c.
3931 (Fstring_to_number): Use new string_to_number function, to be
3932 consistent with how the Lisp reader treats infinities and NaNs.
3933 Do not assume that floating-point numbers represent EMACS_INT
3934 without losing information; this is not true on most 64-bit hosts.
3935 Avoid double-rounding errors, by insisting on integers when
3936 parsing non-base-10 numbers, as the documentation specifies.
3937 * lisp.h (string_to_number): New decl, replacing ...
3938 (isfloat_string): Remove.
3939 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3940 (read1): Do not accept +. and -. as integers; this
3941 appears to have been a coding error. Similarly, do not accept
3942 strings like +-1e0 as floating point numbers. Do not report
3943 overflow for integer overflows unless the base is not 10 which
3944 means we have no simple and reliable way to continue.
3945 Break out the floating-point parsing into a new
3946 function string_to_number, so that Fstring_to_number parses
3947 floating point numbers consistently with the Lisp reader.
3948 (digit_to_number): Move here from data.c. Make it static inline.
3949 (E_CHAR, EXP_INT): Remove, replacing with ...
3950 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3951 (string_to_number): New function, replacing isfloat_string.
3952 This function checks for valid syntax and produces the resulting
3953 Lisp float number too. Rework it so that string-to-number
3954 no longer mishandles examples like "1.0e+". Use strtoumax,
3955 so that overflow for non-base-10 numbers is reported only when
3956 there's no portable and simple way to convert to floating point.
3958 * textprop.c (set_text_properties_1): Rewrite for clarity,
3959 and to avoid GCC warning about integer overflow.
3961 * intervals.h (struct interval): Use EMACS_INT for members
3962 where EMACS_UINT might cause problems. See
3963 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3964 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3965 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3967 (offset_intervals): Tell GCC not to worry about length overflow
3968 when negating a negative length.
3970 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3971 (overrun_check_free): Likewise.
3973 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3974 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3977 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3978 (gnutls_make_error): Rename local to avoid shadowing.
3979 (gnutls_emacs_global_deinit): ifdef out; not used.
3980 (Fgnutls_boot): Use const for pointer to readonly storage.
3981 Comment out unused local. Fix pointer signedness problems.
3983 * lread.c (openp): Don't stuff size_t into an 'int'.
3984 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3985 about possible signed overflow.
3987 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3988 (GDK_KEY_g): Don't define if already defined.
3989 (xg_prepare_tooltip): Avoid pointer signedness problem.
3990 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3992 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3993 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3995 * xfns.c (Fx_window_property): Simplify a bit,
3996 to make a bit faster and to avoid GCC 4.6.0 warning.
3997 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3999 * fns.c (internal_equal): Don't assume size_t fits in int.
4001 * alloc.c (compact_small_strings): Tighten assertion a little.
4003 Replace pEd with more-general pI, and fix some printf arg casts.
4004 * lisp.h (pI): New macro, generalizing old pEd macro to other
4005 conversion specifiers. For example, use "...%"pI"d..." rather
4006 than "...%"pEd"...".
4007 (pEd): Remove. All uses replaced with similar uses of pI.
4008 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4009 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4010 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4011 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4012 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4013 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4014 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4016 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4017 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4018 * print.c (safe_debug_print, print_object): Likewise.
4019 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4021 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4022 avoiding the 0 flag, which is not portable.
4023 * process.c (Fmake_network_process): Use pI to avoid cast.
4024 * region-cache.c (pp_cache): Likewise.
4025 * xdisp.c (decode_mode_spec): Likewise.
4026 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4027 behavior on 64-bit hosts with printf arg.
4028 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4029 (x_stop_queuing_selection_requests): Likewise.
4030 (x_get_window_property): Don't truncate byte count to an 'int'
4033 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4034 here, since it parses constructs like leading '-' and spaces,
4035 which are not wanted; and it overflows with large numbers.
4036 Instead, simply match F[0-9]+, which is what is wanted anyway.
4038 * alloc.c: Remove unportable assumptions about struct layout.
4039 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4040 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4041 (allocate_vectorlike, make_pure_vector): Use the new macros,
4042 plus offsetof, to remove unportable assumptions about struct layout.
4043 These assumptions hold on all porting targets that I know of, but
4044 they are not guaranteed, they're easy to remove, and removing them
4045 makes further changes easier.
4047 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4048 This doesn't fix a bug but makes the code clearer.
4049 (string_overrun_cookie): Now const. Use initializers that
4050 don't formally overflow signed char, to avoid warnings.
4051 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4052 can cause Emacs to crash when string overrun checking is enabled.
4053 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4054 multiple of sizeof (EMACS_INT); it need not be, if
4055 alignof(EMACS_INT) < sizeof (EMACS_INT).
4056 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4058 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4060 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4062 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4064 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4065 supposed to be handshaking. (Bug#8556)
4066 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4068 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4070 * lisp.h (Qdebug): List symbol.
4071 * eval.c (Qdebug): Restore global linkage.
4072 * keyboard.c (debug-on-event): New variable.
4073 (handle_user_signal): Break into debugger when debug-on-event
4074 matches the current signal symbol.
4076 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4078 * alloc.c (check_sblock, check_string_bytes)
4079 (check_string_free_list): Convert to standard C.
4081 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4083 * w32.c (emacs_gnutls_push): Fix typo.
4085 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4087 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4088 "cast to pointer from integer of different size".
4090 Improve doprnt and its use in verror. (Bug#8545)
4091 * doprnt.c (doprnt): Document the set of format control sequences
4092 supported by the function. Use SAFE_ALLOCA instead of always
4095 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4096 is one byte too soon. Don't use xrealloc; instead xfree and
4099 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4101 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4104 * gnutls.c: Renamed global_initialized to
4105 gnutls_global_initialized. Added internals for the
4106 :verify-hostname-error, :verify-error, and :verify-flags
4107 parameters of `gnutls-boot' and documented those parameters in the
4108 docstring. Start callback support.
4109 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4110 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4111 on error. Return error code.
4112 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4113 (emacs_gnutls_read): Likewise.
4114 (Fgnutls_boot): Return handshake error code.
4115 (emacs_gnutls_handle_error): New function.
4116 (wsaerror_to_errno): Likewise.
4118 * w32.h (emacs_gnutls_pull): Add prototype.
4119 (emacs_gnutls_push): Likewise.
4121 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4122 (emacs_gnutls_push): Likewise.
4124 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4126 * process.c (wait_reading_process_output): Check if GnuTLS
4127 buffered some data internally if no FDs are set for TLS
4130 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4131 (LIBS): Link to USER_LIBS.
4132 ($(BLD)/gnutls.$(0)): New target.
4134 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4136 * xdisp.c (handle_single_display_spec): Rename the
4137 display_replaced_before_p argument into display_replaced_p, to
4138 make it consistent with the commentary. Fix typos in the
4141 * textprop.c (syms_of_textprop): Remove dead code.
4142 (copy_text_properties): Delete obsolete commentary about an
4143 interface that was deleted long ago. Fix typos in the description
4146 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4147 to changes in oldXMenu/XMenu.h from 2011-04-16.
4148 <menu_help_message, prev_menu_help_message>: Constify.
4149 (IT_menu_make_room): menu->help_text is now `const char **';
4152 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4153 to changes in oldXMenu/XMenu.h from 2011-04-16.
4154 (struct XMenu): Declare `help_text' `const char **'.
4156 * xfaces.c <Qunspecified>: Make extern again.
4158 * syntax.c: Include sys/types.h before including regex.h, as
4161 * doc.c (get_doc_string): Improve the format passed to `error'.
4163 * doprnt.c (doprnt): Improve commentary.
4165 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4167 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4170 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4171 changes in globals.h immediately force recompilation.
4172 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4173 $(CURDIR)/s/ms-w32.h.
4174 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4176 * character.c (Fchar_direction): Function deleted.
4177 (syms_of_character): Don't defsubr it.
4178 <char-direction-table>: Deleted.
4180 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4182 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4183 * doprnt.c: Include limits.h.
4184 (SIZE_MAX): New macro.
4185 (doprnt): Return a size_t value. 2nd arg is now size_t.
4186 Many local variables are now size_t instead of int or unsigned.
4187 Improve overflow protection. Support `l' modifier for integer
4188 conversions. Support %l conversion. Don't assume an EMACS_INT
4189 argument for integer conversions and for %c.
4191 * lisp.h (doprnt): Restore prototype.
4193 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4196 * Makefile.in (base_obj): Add back doprnt.o.
4198 * deps.mk (doprnt.o): Add back prerequisites.
4199 (callint.o): Depend on character.h.
4201 * eval.c (internal_lisp_condition_case): Include the handler
4202 representation in the error message.
4203 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4204 when breaking from the loop.
4206 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4208 * callint.c (Fcall_interactively): When displaying error message
4209 about invalid control letter, pass the character's codepoint, not
4210 a pointer to its multibyte form. Improve display of the character
4211 in octal and display also its hex code.
4213 * character.c (char_string): Use %x to display the (unsigned)
4214 codepoint of an invalid character, to avoid displaying a bogus
4217 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4218 `error', not SYMBOL_NAME itself.
4220 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4221 character arguments to `error'.
4223 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4224 to `error' in error message about FINAL_CHAR argument. Make sure
4225 FINAL_CHAR is a character, and use %c when it is passed as
4226 argument to `error'.
4228 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4230 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4232 * w32.c: Include <time.h>.
4233 (sys_localtime): New function.
4235 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4237 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4239 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4241 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4243 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4246 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4248 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4249 gl_state.e_property when gl_state.object is Qt.
4251 * insdel.c (make_gap_larger): Remove limitation of buffer size
4254 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4256 * xdisp.c (lookup_glyphless_char_display)
4257 (produce_glyphless_glyph): Handle cons cell entry in
4258 glyphless-char-display.
4259 (Vglyphless_char_display): Document it.
4261 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4262 glyphless-char-display.
4264 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4266 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4268 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4270 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4271 definition for no-X builds.
4273 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4275 Static checks with GCC 4.6.0 and non-default toolkits.
4277 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4279 * process.c (keyboard_bit_set): Define only if SIGIO.
4280 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4281 (send_process): Repair possible setjmp clobbering.
4283 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4285 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4287 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4289 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4290 Define only if needed.
4292 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4293 by pacifying GCC about it. Maybe it's time to retire it?
4294 * xfaces.c (USG, __TIMEVAL__): Likewise.
4296 * dispextern.h (struct redisplay_interface): Rename param
4298 * termhooks.h (struct terminal): Likewise.
4299 * xterm.c (xembed_send_message): Likewise.
4301 * insdel.c (make_gap_smaller): Define only if
4302 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4304 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4307 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4308 so that we aren't warned about unused symbols.
4310 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4312 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4314 * xfns.c (x_real_positions): Mark locals as initialized.
4316 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4318 * xterm.c: Fix problems found by static analysis with other toolkits.
4319 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4320 (x_dispatch_event): Declare static if USE_GTK, and
4321 define if USE_GTK || USE_X_TOOLKIT.
4322 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4323 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4324 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4325 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4327 * xmenu.c (menu_help_callback): Pointer type fixes.
4328 Use const pointers when pointing at readonly data. Avoid pointer
4330 (FALSE): Remove unused macro.
4331 (update_frame_menubar): Remove unused decl.
4333 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4335 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4336 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4337 (single_menu_item): Rename local to avoid shadowing.
4339 * keyboard.c (make_lispy_event): Remove unused local var.
4341 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4342 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4344 * bitmaps: Change bitmaps from unsigned char back to the X11
4345 compatible char. Avoid the old compiler warnings about
4346 out-of-range initializers by using, for example, '\xab' rather
4349 * xgselect.c (xgselect_initialize): Check vs interface
4350 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4352 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4354 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4355 to read-only memory.
4357 * fns.c (vector): Remove; this old hack is no longer needed.
4359 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4361 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4363 * xrdb.c (x_load_resources): Omit unused local.
4365 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4366 (x_window): Rename locals to avoid shadowing.
4367 (USG): Use the kludged USG macro, to pacify gcc.
4369 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4370 (x_term_init): Remove local to avoid shadowing.
4372 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4374 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4375 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4377 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4379 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4381 Fix regex.c, syntax.c and friends for buffers > 2GB.
4382 * syntax.h (struct gl_state_s): Declare character position members
4385 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4387 * textprop.c (verify_interval_modification, interval_of):
4388 Declare arguments EMACS_INT.
4390 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4393 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4395 * indent.c (Fvertical_motion): Local variable it_start is now
4398 * regex.c (re_match, re_match_2, re_match_2_internal)
4399 (bcmp_translate, regcomp, regexec, print_double_string)
4400 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4401 (re_compile_pattern, re_exec): Declare arguments and local
4402 variables `size_t' and `ssize_t' and return values `regoff_t', as
4404 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4405 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4406 <compile_stack_type>: `size' and `avail' are now `size_t'.
4408 * regex.h <regoff_t>: Use ssize_t, not int.
4409 (re_search, re_search_2, re_match, re_match_2): Arguments that
4410 specify buffer/string position and length are now ssize_t and
4411 size_t. Return type is regoff_t.
4413 2011-04-16 Ben Key <bkey76@gmail.com>
4415 * nsfont.m: Fixed bugs in ns_get_family and
4416 ns_descriptor_to_entity that were caused by using free to
4417 deallocate memory blocks that were allocated by xmalloc (via
4418 xstrdup). This caused Emacs to crash when compiled with
4419 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4420 --enable-checking=xmallocoverrun). xfree is now used to
4421 deallocate these memory blocks.
4423 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4425 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4427 emacs_write: Accept and return EMACS_INT for sizes.
4428 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4430 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4431 Accept and return EMACS_INT.
4432 (emacs_gnutls_write): Return the number of bytes written on
4434 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4435 (emacs_read, emacs_write): Remove check for negative size, as the
4436 Emacs source code has been audited now.
4437 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4438 (emacs_read, emacs_write): Use it.
4439 * process.c (send_process): Adjust to the new signatures of
4440 emacs_write and emacs_gnutls_write. Do not attempt to store
4441 a byte offset into an 'int'; it might overflow.
4442 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4444 * sound.c: Don't assume sizes fit in 'int'.
4445 (struct sound_device.period_size, alsa_period_size):
4446 Return EMACS_INT, not int.
4447 (struct sound_device.write, vox_write, alsa_write):
4448 Accept EMACS_INT, not int.
4449 (wav_play, au_play): Use EMACS_INT to store sizes and to
4450 record read return values.
4452 2011-04-15 Ben Key <bkey76@gmail.com>
4454 * keyboard.c (Qundefined): Don't declare static since it is used
4456 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4457 static since they are used in nsfont.m.
4459 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4461 * process.c (Qprocessp): Don't declare static.
4462 * lisp.h (Qprocessp): Declare again.
4464 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4466 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4468 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4470 Improve C-level modularity by making more things 'static'.
4472 Don't publish debugger-only interfaces to other modules.
4473 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4474 (verify_bytepos, count_markers): Move decls to the only modules
4476 * region-cache.h (pp_cache): Likewise.
4477 * window.h (check_all_windows): Likewise.
4478 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4480 * sysdep.c (croak): Now static, if
4481 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4482 * syssignal.h (croak): Declare only if not static.
4484 * alloc.c (refill_memory_reserve): Now static if
4485 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4486 * lisp.h (refill_memory_reserve): Declare only if not static.
4488 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4489 Define only if USE_LUCID.
4491 * xrdb.c (x_customization_string, x_rm_string): Now static.
4493 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4494 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4496 * xdisp.c (draw_row_with_mouse_face): Now static.
4497 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4499 * window.h (check_all_windows): Mark externally visible.
4501 * window.c (window_deletion_count): Now static.
4503 * undo.c: Make symbols static if they're not exported.
4504 (last_undo_buffer, last_boundary_position, pending_boundary):
4507 * textprop.c (interval_insert_behind_hooks): Now static.
4508 (interval_insert_in_front_hooks): Likewise.
4510 * term.c: Make symbols static if they're not exported.
4511 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4512 (max_frame_lines, tty_set_terminal_modes):
4513 (tty_reset_terminal_modes, tty_turn_off_highlight):
4514 (get_tty_terminal): Now static.
4515 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4516 * termhooks.h (term_mouse_moveto): Do not declare if
4518 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4519 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4521 * sysdep.c: Make symbols static if they're not exported.
4522 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4524 (sigprocmask_set, full_mask): Remove; unused.
4525 (wait_debugging): Mark as visible.
4526 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4527 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4529 * syntax.c (syntax_temp): Define only if !__GNUC__.
4531 * sound.c (current_sound_device, current_sound): Now static.
4533 * search.c (searchbufs, searchbuf_head): Now static.
4535 * scroll.c (scroll_cost): Remove; unused.
4536 * dispextern.h (scroll_cost): Remove decl.
4538 * region-cache.h (pp_cache): Mark as externally visible.
4540 * process.c: Make symbols static if they're not exported.
4541 (process_tick, update_tick, create_process, chan_process):
4542 (Vprocess_alist, proc_buffered_char, datagram_access):
4543 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4544 (deactivate_process): Mark defn as static, as well as decl.
4545 * lisp.h (create_process): Remove decl.
4546 * process.h (chan_process, Vprocess_alist): Remove decls.
4548 * print.c: Make symbols static if they're not exported.
4549 (print_depth, new_backquote_output, being_printed, print_buffer):
4550 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4551 (print_interval, print_number_index, initial_stderr_stream):
4553 * lisp.h (Fprinc): Remove decl.
4554 (debug_output_compilation_hack): Mark as externally visible.
4556 * sysdep.c (croak): Move decl from here to syssignal.h.
4557 * syssignal.h (croak): Put it here, so the API can be checked when
4558 'croak' is called from dissociate_if_controlling_tty.
4560 * minibuf.c: Make symbols static if they're not exported.
4561 (minibuf_save_list, choose_minibuf_frame): Now static.
4562 * lisp.h (choose_minibuf_frame): Remove decl.
4564 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4566 * lread.c: Make symbols static if they're not exported.
4567 (read_objects, initial_obarray, oblookup_last_bucket_number):
4569 (make_symbol): Remove; unused.
4570 * lisp.h (initial_obarray, make_symbol): Remove decls.
4572 * keyboard.c: Make symbols static if they're not exported.
4573 (single_kboard, recent_keys_index, total_keys, recent_keys):
4574 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4575 (this_single_command_key_start, echoing, last_auto_save):
4576 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4577 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4578 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4579 (Vlispy_mouse_stem, double_click_count):
4581 (force_auto_save_soon): Define only if SIGDANGER.
4582 (ignore_mouse_drag_p): Now static if
4583 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4584 (print_help): Remove; unused.
4585 (stop_character, last_timer_event): Mark as externally visible.
4586 * keyboard.h (ignore_mouse_drag_p): Declare only if
4587 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4588 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4589 * lisp.h (echoing): Remove decl.
4590 (force_auto_save_soon): Declare only if SIGDANGER.
4591 * xdisp.c (redisplay_window): Simplify code, to make it more
4592 obvious that ignore_mouse_drag_p is not accessed if !defined
4593 USE_GTK && !defined HAVE_NS.
4595 * intervals.c: Make symbols static if they're not exported.
4596 (merge_properties_sticky, merge_interval_right, delete_interval):
4598 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4600 * insdel.c: Make symbols static if they're not exported.
4601 However, leave prepare_to_modify_buffer alone. It's never
4602 called from outside this function, but that appears to be a bug.
4603 (combine_after_change_list, combine_after_change_buffer):
4604 (adjust_after_replace, signal_before_change): Now static.
4605 (adjust_after_replace_noundo): Remove; unused.
4606 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4607 (signal_before_change): Remove decls.
4609 * indent.c (val_compute_motion, val_vmotion): Now static.
4611 * image.c: Make symbols static if they're not exported.
4612 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4614 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4615 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4617 * fringe.c (standard_bitmaps): Now static.
4618 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4620 * frame.c: Make symbols static if they're not exported.
4621 (x_report_frame_params, make_terminal_frame): Now static.
4622 (get_frame_param): Now static, unless HAVE_NS.
4623 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4624 (x_get_resource_string): Remove; not used.
4625 * frame.h (make_terminal_frame, x_report_frame_params):
4626 (x_get_resource_string); Remove decls.
4627 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4628 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4630 * font.c, fontset.c: Make symbols static if they're not exported.
4631 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4632 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4633 * font.c (font_close_object): Now static.
4634 * font.h (font_close_object): Remove.
4635 * fontset.c (FONTSET_OBJLIST): Remove.
4636 (free_realized_fontset) #if-0 the body, which does nothing.
4637 (face_suitable_for_char_p): #if-0, as it's never called.
4638 * fontset.h (face_suitable_for_char_p): Remove decl.
4639 * xfaces.c (face_at_string_position):
4640 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4641 since 0 is always ASCII.
4643 * fns.c (weak_hash_tables): Now static.
4645 * fileio.c: Make symbols static if they're not exported.
4646 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4647 (Vwrite_region_annotation_buffers): Now static.
4649 * eval.c: Make symbols static if they're not exported.
4650 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4651 * lisp.h (backtrace_list): Remove decl.
4653 * emacs.c: Make symbols static if they're not exported.
4654 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4655 (fatal_error_code, fatal_error_signal_hook, standard_args):
4657 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4658 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4659 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4660 * lisp.h (fatal_error_signal_hook): Remove decl.
4661 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4663 * editfns.c: Move a (normally-unused) function to its only use.
4664 * editfns.c, lisp.h (get_operating_system_release): Remove.
4665 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4666 worth the hassle of breaking this out.
4668 * xterm.c: Make symbols static if they're not exported.
4669 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4670 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4671 (x_destroy_window, x_delete_display):
4673 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4674 (x_mouse_leave): Remove; unused.
4675 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4676 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4677 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4679 (x_mouse_leave): Declare only if WINDOWSNT.
4680 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4681 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4684 * ftxfont.c: Make symbols static if they're not exported.
4685 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4687 * font.h (ftxfont_driver): Likewise.
4689 * xfns.c: Make symbols static if they're not exported.
4690 (x_last_font_name, x_display_info_for_name):
4691 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4692 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4693 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4694 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4695 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4696 (last_show_tip_args): Now static.
4697 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4698 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4699 (x_screen_planes): Remove; unused.
4700 * dispextern.h (x_screen_planes): Remove decl.
4702 * dispnew.c: Make symbols static if they're not exported.
4703 * dispextern.h (redraw_garbaged_frames, scrolling):
4704 (increment_row_positions): Remove.
4705 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4706 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4708 (redraw_garbaged_frames): Remove; unused.
4710 * xfaces.c: Make symbols static if they're not exported.
4711 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4713 * xterm.h (defined_color): Remove decls.
4714 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4715 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4716 (menu_face_changed_default, defined_color, free_realized_face):
4717 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4718 (ascii_face_of_lisp_face): Remove; unused.
4720 * xdisp.c: Make symbols static if they're not exported.
4721 * dispextern.h (scratch_glyph_row, window_box_edges):
4722 (glyph_to_pixel_coords, set_cursor_from_row):
4723 (get_next_display_element, set_iterator_to_next):
4724 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4725 (show_mouse_face): Remove decls
4726 * frame.h (message_buf_print): Likewise.
4727 * lisp.h (pop_message, set_message, check_point_in_composition):
4729 * xterm.h (set_vertical_scroll_bar): Likewise.
4730 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4731 (message_buf_print, scratch_glyph_row, displayed_buffer):
4732 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4733 (get_next_display_element, show_mouse_face, window_box_edges):
4734 (frame_to_window_pixel_xy, check_point_in_composition):
4735 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4736 (glyph_to_pixel_coords): Remove; unused.
4738 * dired.c (file_name_completion): Now static.
4740 * dbusbind.c (xd_in_read_queued_messages): Now static.
4742 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4743 * data.c (circular_list_error): Remove.
4745 * commands.h (last_point_position, last_point_position_buffer):
4746 (last_point_position_window): Remove decls.
4747 * keyboard.c: Make these variables static.
4749 * coding.h (coding, code_convert_region, encode_coding_gap):
4751 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4752 (iso_code_class, detect_coding, code_convert_region): Now static.
4753 (encode_coding_gap): Remove; unused.
4755 * chartab.c (chartab_chars, chartab_bits): Now static.
4757 * charset.h (charset_iso_8859_1): Remove decl.
4758 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4761 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4762 * ccl.c (Vccl_program_table): Now static.
4763 (check_ccl_update): Remove; unused.
4765 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4766 * category.h: ... from here.
4767 * category.c (check_category_table, set_category_set): Now static.
4769 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4770 * lisp.h: Remove these decls.
4772 * buffer.c (buffer_count): Remove unused var.
4774 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4775 so that it's not optimized away.
4776 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4777 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4778 exported only to the debugger.
4780 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4781 * atimer.h (run_all_atimers): Remove; not exported.
4783 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4784 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4785 was inaccessible from Lisp.
4786 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4787 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4789 alloc.c: Import and export fewer symbols, and remove unused items.
4790 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4792 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4793 it's not optimized away by whole-program optimization.
4794 (message_enable_multibyte, free_misc): Remove.
4795 (catchlist, handlerlist, mark_backtrace):
4796 Declare only if BYTE_MARK_STACK.
4797 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4798 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4799 (message_enable_multibyte): Remove decl.
4800 (free_misc, interval_free_list, float_block, float_block_index):
4801 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4802 (cons_free_list, last_marked_index):
4804 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4805 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4806 (mark_backtrace): Define only if BYTE_MARK_STACK.
4807 * xdisp.c (message_enable_multibyte): Now static.
4809 Declare Lisp_Object Q* variables to be 'static' if not exported.
4810 This makes it easier for human readers (and static analyzers)
4811 to see whether these variables are used from other modules.
4812 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4813 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4814 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4815 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4816 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4817 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4818 * xmenu.c, xselect.c:
4819 Declare Q* vars static if they are not used in other modules.
4820 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4821 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4822 Remove decls of unexported vars.
4823 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4825 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4827 Make Emacs functions such as Fatom 'static' by default.
4828 This makes it easier for human readers (and static analyzers)
4829 to see whether these functions can be called from other modules.
4830 DEFUN now defines a static function. To make the function external
4831 so that it can be used in other C modules, use the new macro DEFUE.
4832 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4833 (Finit_image_library):
4834 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4835 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4836 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4837 Remove decls, since these functions are now static.
4838 (Funintern, Fget_internal_run_time): New decls, since these functions
4839 were already external.
4841 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4842 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4843 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4844 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4845 * keyboard.c, keymap.c, lread.c:
4846 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4847 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4848 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4849 Mark functions with DEFUE instead of DEFUN,
4850 if they are used in other modules.
4851 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4852 decls for now-static functions.
4853 * buffer.h (Fdelete_overlay): Remove decl.
4854 * callproc.c (Fgetenv_internal): Mark as internal.
4855 * composite.c (Fremove_list_of_text_properties): Remove decl.
4856 (Fcomposition_get_gstring): New forward static decl.
4857 * composite.h (Fcomposite_get_gstring): Remove decl.
4858 * dired.c (Ffile_attributes): New forward static decl.
4859 * doc.c (Fdocumntation_property): New forward static decl.
4860 * eval.c (Ffetch_bytecode): New forward static decl.
4861 (Funintern): Remove extern decl; now in .h file where it belongs.
4862 * fileio.c (Fmake_symbolic_link): New forward static decl.
4863 * image.c (Finit_image_library): New forward static decl.
4864 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4865 * intervals.h (Fprevious_property_change):
4866 (Fremove_list_of_text_properties): Remove decls.
4867 * keyboard.c (Fthis_command_keys): Remove decl.
4868 (Fcommand_execute): New forward static decl.
4869 * keymap.c (Flookup_key): New forward static decl.
4870 (Fcopy_keymap): Now static.
4871 * keymap.h (Flookup_key): Remove decl.
4872 * process.c (Fget_process): New forward static decl.
4873 (Fprocess_datagram_address): Mark as internal.
4874 * syntax.c (Fsyntax_table_p): New forward static decl.
4875 (skip_chars): Remove duplicate decl.
4876 * textprop.c (Fprevious_property_change): New forward static decl.
4877 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4879 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4880 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4882 * editfns.c (Fformat): Remove unreachable code.
4884 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4886 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4889 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4891 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4892 when at ZV. (Bug#8487)
4894 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4896 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4898 * keyboard.c (parse_tool_bar_item): Likewise.
4899 * sound.c (sound_cleanup, alsa_close): Likewise.
4900 * termcap.c (tgetent): Likewise.
4901 * xfns.c (x_default_font_parameter): Likewise.
4902 * xsettings.c (read_and_apply_settings): Likewise.
4904 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4905 (overrun_check_free): Protoize.
4907 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4909 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4910 since callers should never pass a negative size.
4911 Change the signature to match that of plain 'read' and 'write'; see
4912 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4913 * lisp.h: Update prototypes of emacs_write and emacs_read.
4915 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4917 * xdisp.c (redisplay_window): Don't try to determine the character
4918 position of the scroll margin if the window start point w->startp
4919 is outside the buffer's accessible region. (Bug#8468)
4921 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4923 Fix write-region and its subroutines for buffers > 2GB.
4924 * fileio.c (a_write, e_write): Modify declaration of arguments and
4925 local variables to support buffers larger than 2GB.
4926 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4928 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4929 argument, local variables, and return value.
4931 * lisp.h: Update prototypes of emacs_write and emacs_read.
4933 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4935 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4937 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4939 Fix more problems found by GCC 4.6.0's static checks.
4941 * xdisp.c (vmessage): Use a better test for character truncation.
4943 * charset.c (load_charset_map): <, not <=, for optimization,
4944 and to avoid potential problems with integer overflow.
4945 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4946 * casetab.c (set_identity, shuffle): Likewise.
4947 * editfns.c (Fformat): Likewise.
4948 * syntax.c (skip_chars): Likewise.
4950 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4951 This also lets GCC 4.6.0 generate slightly better loop code.
4953 * callint.c (Fcall_interactively): <, not <=, for optimization.
4954 (Fcall_interactively): Count the number of arguments produced,
4955 not the number of arguments given. This is simpler and lets GCC
4956 4.6.0 generate slightly better code.
4958 * ftfont.c: Distingish more carefully between FcChar8 and char.
4959 The previous code passed unsigned char * to a functions like
4960 strlen and xstrcasecmp that expect char *, which does not
4961 conform to the C standard.
4962 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4963 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4964 char * when the C standard requires it.
4966 * keyboard.c (read_char): Remove unused var.
4968 * eval.c: Port to Windows vsnprintf (Bug#8435).
4970 (SIZE_MAX): Define if the headers do not.
4971 (verror): Do not give up if vsnprintf returns a negative count.
4972 Instead, grow the buffer. This ports to Windows vsnprintf, which
4973 does not conform to C99. Problem reported by Eli Zaretskii.
4974 Also, simplify the allocation scheme, by avoiding the need for
4975 calling realloc, and removing the ALLOCATED variable.
4977 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4979 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4980 But keep the doprint source code for now, as we might revamp it
4981 and use it again (Bug#8435).
4982 * lisp.h (doprnt): Remove.
4983 * Makefile.in (base_obj): Remove doprnt.o.
4984 * deps.mk (doprnt.o): Remove.
4986 error: Print 32- and 64-bit integers portably (Bug#8435).
4987 Without this change, on typical 64-bit hosts error ("...%d...", N)
4988 was used to print both 32- and 64-bit integers N, which relied on
4990 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4992 * lisp.h (error, verror): Mark as printf-like functions.
4993 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4994 Report overflow in size calculations when allocating printf buffer.
4995 Do not truncate output string at its first null byte.
4996 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4997 Truncate the output at a character boundary, since vsnprintf does not
4999 * charset.c (check_iso_charset_parameter): Convert internal
5000 character to string before calling 'error', since %c now has the
5002 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5003 overflow when computing char to be passed to 'error'. Do not
5004 pass Lisp_Object to 'error'; pass the integer instead.
5005 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5006 formatted with plain %d.
5008 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5010 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5012 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5014 * xterm.c (x_catch_errors): Remove duplicate declaration.
5016 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5018 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5020 2011-04-10 Jim Meyering <meyering@redhat.com>
5022 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5023 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5024 return ssize_t not "int", and use size_t as the buffer length.
5025 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5026 * gnutls.h: Update declarations.
5027 * process.c (read_process_output): Use ssize_t, to match.
5028 (send_process): Likewise.
5030 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5032 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5034 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5036 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5037 Use unsigned char, to match FcChar8 type definition.
5039 * xterm.c (handle_one_xevent):
5040 * xmenu.c (create_and_show_popup_menu):
5041 * xselect.c (x_decline_selection_request)
5042 (x_reply_selection_request): Avoid type-punned deref of X events.
5044 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5046 Fix some uses of `int' instead of EMACS_INT.
5047 * search.c (string_match_1, fast_string_match)
5048 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5049 (scan_buffer, find_next_newline_no_quit)
5050 (find_before_next_newline, search_command, Freplace_match)
5051 (Fmatch_data): Make some `int' variables be EMACS_INT.
5053 * xdisp.c (display_count_lines): 3rd argument and return value now
5054 EMACS_INT. All callers changed.
5055 (pint2hrstr): Last argument is now EMACS_INT.
5057 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5058 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5059 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5060 (decode_coding_utf_16, decode_coding_emacs_mule)
5061 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5062 (decode_coding_ccl, decode_coding_charset)
5063 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5064 (decode_coding_iso_2022, decode_coding_emacs_mule)
5065 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5066 <char_offset, last_offset>: Declare EMACS_INT.
5067 (encode_coding_utf_8, encode_coding_utf_16)
5068 (encode_coding_emacs_mule, encode_invocation_designation)
5069 (encode_designation_at_bol, encode_coding_iso_2022)
5070 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5071 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5073 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5074 (encode_invocation_designation): Last argument P_NCHARS is now
5076 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5077 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5079 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5082 * ccl.c (Fccl_execute_on_string): Declare some variables
5085 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5087 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5089 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5091 * process.c (Fformat_network_address): Doc fix.
5093 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5095 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5097 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5099 * keyboard.c (read_char): Call Lisp function help-form-show,
5100 instead of using internal_with_output_to_temp_buffer.
5101 (Qhelp_form_show): New var.
5102 (syms_of_keyboard): Use DEFSYM macro.
5104 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5106 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5108 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5110 * process.c (Flist_processes): Remove to Lisp.
5111 (list_processes_1): Delete.
5113 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5115 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5117 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5119 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5121 Fix more problems found by GCC 4.6.0's static checks.
5123 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5125 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5127 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5129 * xdisp.c (vmessage): Mark as a printf-like function.
5131 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5133 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5135 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5136 printf-like functions.
5137 (tiff_load): Add casts to remove these marks before passing them
5138 to system-supplied API.
5140 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5142 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5143 This avoids several warnings with gcc -Wstrict-overflow.
5144 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5145 directly, rather than having caller test rule sign. This avoids
5146 some unnecessary tests.
5147 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5148 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5149 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5151 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5152 (xfont_open): Avoid unnecessary tests.
5154 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5156 * composite.h, composite.c (composition_gstring_put_cache):
5157 Use EMACS_INT, not int, for length.
5159 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5160 breaking out part of COMPOSITION_DECODE_RULE.
5161 (COMPOSITION_DECODE_RULE): Use it.
5162 * composite.c (get_composition_id): Remove unused local vars,
5163 by using the new macro.
5165 * textprop.c (set_text_properties_1): Change while to do-while,
5166 since the condition is always true at first.
5168 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5169 (interval_deletion_adjustment): Return unsigned value.
5172 * process.c (list_processes_1, create_pty, read_process_output):
5173 (exec_sentinel): Remove vars that were set but not used.
5174 (create_pty): Remove unnecessary "volatile"s.
5175 (Fnetwork_interface_info): Avoid possibility of int overflow.
5176 (read_process_output): Do adaptive read buffering even if carryover.
5177 (read_process_output): Simplify nbytes computation if buffered.
5179 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5181 * syntax.c (scan_words): Remove var that was set but not used.
5182 (update_syntax_table): Use unsigned instead of int.
5184 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5185 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5186 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5188 * print.c (print_error_message): Avoid int overflow.
5190 * font.c (font_list_entities): Redo for clarity,
5191 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5193 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5194 (font_score): Avoid potential overflow in diff calculation.
5196 * fns.c (substring_both): Remove var that is set but not used.
5197 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5199 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5201 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5202 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5203 can always succeed if overflow has undefined behavior.
5205 * search.c (boyer_moore, wordify): Remove vars set but not used.
5206 (wordify): Omit three unnecessary tests.
5208 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5209 All callers changed. This avoids the need for an unused var.
5211 * casefiddle.c (casify_region): Remove var that is set but not used.
5213 * dired.c (file_name_completion): Remove var that is set but not used.
5215 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5217 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5218 (Finsert_file_contents): Remove unnecessary code checking fd.
5220 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5221 Check for integer overflow on size calculations.
5223 * buffer.c (Fprevious_overlay_change): Remove var that is set
5226 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5227 Remove vars that are set but not used.
5228 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5229 (timer_check_2): Mark vars as initialized.
5231 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5233 * image.c (lookup_image): Remove var that is set but not used.
5234 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5236 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5237 that are set but not used.
5239 * xfns.c (make_invisible_cursor): Don't return garbage
5240 if XCreateBitmapFromData fails (Bug#8410).
5242 * xselect.c (x_get_local_selection, x_handle_property_notify):
5243 Remove vars that are set but not used.
5245 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5246 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5248 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5249 Remove var that is set but not used.
5250 (scroll_bar_windows_size): Now size_t, not int.
5251 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5254 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5255 (map_tty_color) [!defined MSDOS]: Likewise.
5257 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5259 * coding.c: Remove vars that are set but not used.
5260 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5261 All callers changed.
5262 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5263 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5264 (decode_coding_charset): Remove vars that are set but not used.
5266 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5267 that is set but not used.
5269 * print.c (print_object): Remove var that is set but not used.
5271 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5272 The gnulib version avoids calling malloc in the usual case,
5273 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5274 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5275 * filelock.c (current_lock_owner): Likewise.
5276 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5277 * sysdep.c: Include allocator.h, careadlinkat.h.
5278 (emacs_no_realloc_allocator): New static constant.
5279 (emacs_readlink): New function.
5280 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5281 ../lib/careadlinkat.h.
5283 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5285 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5286 first non-nil return value).
5288 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5290 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5291 if not defined (Bug#8403).
5293 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5295 * xdisp.c (display_count_lines): Remove parameter `start',
5296 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5297 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5298 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5299 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5300 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5301 and thereabouts. All callers changed.
5302 (get_per_char_metric): Remove parameter `f', unused since
5303 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5305 2011-04-02 Jim Meyering <meyering@redhat.com>
5307 do not dereference NULL upon failed strdup
5308 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5309 (ns_get_family): Likewise.
5311 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5313 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5315 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5317 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5320 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5322 Add lexical binding.
5324 * window.c (Ftemp_output_buffer_show): New fun.
5325 (Fsave_window_excursion):
5326 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5328 * lread.c (lisp_file_lexically_bound_p): New function.
5329 (Fload): Bind Qlexical_binding.
5330 (readevalloop): Remove `evalfun' arg.
5331 Bind Qinternal_interpreter_environment.
5332 (Feval_buffer): Bind Qlexical_binding.
5333 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5335 (syms_of_lread): Declare `lexical-binding'.
5337 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5339 * keyboard.c (eval_dyn): New fun.
5340 (menu_item_eval_property): Use it.
5342 * image.c (parse_image_spec): Use Ffunctionp.
5344 * fns.c (concat, mapcar1): Accept byte-code-functions.
5346 * eval.c (Fsetq): Handle lexical vars.
5347 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5348 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5349 (FletX, Flet): Obey lexical binding.
5350 (Fcommandp): Handle closures.
5351 (Feval): New `lexical' arg.
5352 (eval_sub): New function extracted from Feval. Use it almost
5353 everywhere where Feval was used. Look up vars in lexical env.
5355 (Ffunctionp): Move from subr.el.
5356 (Ffuncall): Handle closures.
5357 (apply_lambda): Remove `eval_flags'.
5358 (funcall_lambda): Handle closures and new byte-code-functions.
5359 (Fspecial_variable_p): New function.
5360 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5361 but without exporting it to Lisp.
5363 * doc.c (Fdocumentation, store_function_docstring):
5364 * data.c (Finteractive_form): Handle closures.
5366 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5369 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5371 (exec_byte_code): New function extracted from Fbyte_code to handle new
5372 calling convention for byte-code-functions. Add new byte-codes.
5374 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5376 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5378 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5380 * xdisp.c (redisplay_internal): Fix prototype.
5382 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5384 * xdisp.c (SCROLL_LIMIT): New macro.
5385 (try_scrolling): Use it when setting scroll_limit.
5386 Limit scrolling to 100 screen lines.
5387 (redisplay_window): Even when falling back on "recentering",
5388 position point in the window according to scroll-conservatively,
5389 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5391 (try_scrolling): When point is above the window, allow searching
5392 as far as scroll_max, or one screenful, to compute vertical
5393 distance from PT to the scroll margin position. This prevents
5394 try_scrolling from unnecessarily failing when
5395 scroll-conservatively is set to a value slightly larger than the
5396 window height. Clean up the case of PT below the margin at bottom
5397 of window: scroll_max can no longer be INT_MAX. When aggressive
5398 scrolling is in use, don't let point enter the opposite scroll
5399 margin as result of the scroll.
5400 (syms_of_xdisp) <scroll-conservatively>: Document the
5401 threshold of 100 lines for never-recentering scrolling.
5403 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5405 * dispextern.h (move_it_by_lines):
5406 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5407 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5408 (message_log_check_duplicate): Remove parameters `prev_bol' and
5409 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5410 (redisplay_internal): Remove parameter `preserve_echo_area',
5411 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5413 * indent.c (Fvertical_motion):
5414 * window.c (window_scroll_pixel_based, Frecenter):
5415 Don't pass `need_y_p' to `move_it_by_lines'.
5417 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5419 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5420 steal a few bits to be more compact.
5421 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5422 Remove unneeded casts.
5424 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5426 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5428 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5429 binding" message (bug#7967).
5431 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5433 Fix more problems found by GCC 4.6.0's static checks.
5435 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5436 Remove unused local var.
5438 * editfns.c (Fmessage_box): Remove unused local var.
5440 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5441 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5442 Omit unused local vars.
5443 * window.c (shrink_windows): Omit unused local var.
5444 * menu.c (digest_single_submenu): Omit unused local var.
5445 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5446 Omit unused local var.
5448 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5449 Don't assume string length fits in int.
5450 (keyremap_step, read_key_sequence): Use size_t for sizes.
5451 (read_key_sequence): Don't check last_real_key_start redundantly.
5453 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5454 instead of alloca (Bug#8344).
5456 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5457 (Fbacktrace_frame): Don't assume nframes fits in int.
5459 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5461 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5464 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5466 * cm.c (calccost): Turn while-do into do-while, for clarity.
5468 * keyboard.c (syms_of_keyboard): Use the same style as later
5469 in this function when indexing through an array. This also
5470 works around GCC bug 48267.
5472 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5474 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5476 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5477 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5479 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5480 This avoids undefined behavior on integer overflow, and is a bit
5481 more convenient anyway since it is compared to a size_t variable.
5483 Variadic C functions now count arguments with size_t, not int.
5484 This avoids an unnecessary limitation on 64-bit machines, which
5485 caused (substring ...) to crash on large vectors (Bug#8344).
5486 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5487 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5488 All variadic functions and their callers changed accordingly.
5489 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5490 * data.c (arith_driver, float_arith_driver): Likewise.
5491 * editfns.c (general_insert_function): Likewise.
5492 * eval.c (struct backtrace.nargs, interactive_p)
5493 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5494 (funcall_lambda, mark_backtrace): Likewise.
5495 * fns.c (concat): Likewise.
5496 * frame.c (x_set_frame_parameters): Likewise.
5497 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5498 0 if not found, not -1. All callers changed.
5500 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5501 (stack_copy_size): Now size_t, not int.
5502 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5504 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5506 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5507 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5508 All callers changed.
5510 * lisp.h (multibyte_char_to_unibyte):
5511 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5512 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5513 * character.h (CHAR_TO_BYTE8):
5514 * cmds.c (internal_self_insert):
5515 * editfns.c (general_insert_function):
5516 * keymap.c (push_key_description):
5517 * search.c (Freplace_match):
5518 * xdisp.c (message_dolog, set_message_1): All callers changed.
5520 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5522 * keyboard.c (safe_run_hook_funcall): New function.
5523 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5524 don't set the hook to nil, but remove the offending function instead.
5525 (Qcommand_hook_internal): Remove, unused.
5526 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5527 Vcommand_hook_internal.
5529 * eval.c (enum run_hooks_condition): Remove.
5530 (funcall_nil, funcall_not): New functions.
5531 (run_hook_with_args): Call each function through a `funcall' argument.
5532 Remove `cond' argument, now redundant.
5533 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5534 (Frun_hook_with_args_until_failure): Adjust accordingly.
5535 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5537 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5539 * dispextern.h (string_buffer_position): Remove declaration.
5541 * print.c (strout): Remove parameter `multibyte', unused since
5542 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5544 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5545 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5546 All callers changed.
5548 * w32.c (_wsa_errlist): Use braces for struct initializers.
5550 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5551 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5552 All callers changed.
5553 (string_buffer_position): Likewise. Also, make static (it's never
5554 used outside xdisp.c).
5555 (cursor_row_p): Remove parameter `w', unused since
5556 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5557 (decode_mode_spec): Remove parameter `precision', introduced during
5558 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5559 All callers changed.
5561 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5563 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5565 2011-03-27 Anders Lindgren <andlind@gmail.com>
5567 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5568 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5569 (ns_update_auto_hide_menu_bar): New functions.
5570 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5571 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5572 ns_constrain_all_frames.
5573 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5574 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5576 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5578 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5580 2011-03-27 Glenn Morris <rgm@gnu.org>
5582 * syssignal.h: Replace RETSIGTYPE with void.
5583 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5584 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5585 Replace SIGTYPE with void everywhere.
5586 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5587 * s/template.h (SIGTYPE): Remove commented out definition.
5589 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5591 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5592 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5594 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5596 * w32.c (read_unc_volume): Use parameter `henum', instead of
5597 global variable `wget_enum_handle'.
5599 * keymap.c (describe_vector): Remove parameters `indices' and
5600 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5601 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5603 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5605 * keyboard.c (timer_check): Remove parameter `do_it_now',
5606 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5607 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5608 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5610 * keyboard.c (read_char):
5611 * w32menu.c (w32_menu_display_help):
5612 * xmenu.c (show_help_event, menu_help_callback):
5613 Adjust calls to `show_help_echo'.
5615 * gtkutil.c (xg_maybe_add_timer):
5616 * keyboard.c (readable_events):
5617 * process.c (wait_reading_process_output):
5618 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5620 * insdel.c (adjust_markers_gap_motion):
5621 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5622 (gap_left, gap_right): Don't call it.
5624 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5626 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5627 incurred during fontification.
5629 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5631 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5632 (DEFVAR_PER_BUFFER): Don't pass it.
5634 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5635 (scrolling_window): Don't pass it.
5637 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5639 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5641 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5643 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5644 of variables specific to SELinux and computation of `encoded_absname'.
5646 * image.c (XPutPixel): Remove unused variable `height'.
5648 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5650 * unexw32.c (get_section_info): Remove unused variable `section'.
5652 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5653 (system_process_attributes): Remove unused variable `sess'.
5654 (sys_read): Remove unused variable `err'.
5656 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5657 (w32_wnd_proc): Remove unused variable `isdead'.
5658 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5659 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5660 (x_create_tip_frame): Remove unused variable `tem'.
5662 * w32inevt.c (w32_console_read_socket):
5663 Remove unused variable `no_events'.
5665 * w32term.c (x_draw_composite_glyph_string_foreground):
5666 Remove unused variable `width'.
5668 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5670 * w32term.c (x_set_glyph_string_clipping):
5671 Don't pass uninitialized region to CombineRgn.
5673 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5675 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5676 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5677 (Fx_close_connection): Remove unused variable `i'.
5679 * w32font.c (w32font_draw): Return number of glyphs.
5680 (w32font_open_internal): Remove unused variable `i'.
5681 (w32font_driver): Add missing initializer.
5683 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5684 (fill_in_menu): Remove unused variable `items_added'.
5686 * w32term.c (last_mouse_press_frame): Remove static global variable.
5687 (w32_clip_to_row): Remove unused variable `f'.
5688 (x_delete_terminal): Remove unused variable `i'.
5690 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5691 (NOTHING): Remove unused static global variable.
5692 (uniscribe_check_otf): Remove unused variable `table'.
5693 (uniscribe_font_driver): Add missing initializers.
5695 2011-03-23 Julien Danjou <julien@danjou.info>
5697 * term.c (Fsuspend_tty, Fresume_tty):
5698 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5699 * window.c (temp_output_buffer_show):
5700 * insdel.c (signal_before_change):
5701 * frame.c (Fhandle_switch_frame):
5702 * fileio.c (Fdo_auto_save):
5703 * emacs.c (Fkill_emacs):
5704 * editfns.c (save_excursion_restore):
5705 * cmds.c (internal_self_insert):
5706 * callint.c (Fcall_interactively):
5707 * buffer.c (Fkill_all_local_variables):
5708 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5710 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5711 unconditionnaly since it does the check itself.
5713 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5715 Fix more problems found by GCC 4.5.2's static checks.
5717 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5718 the first time through the loop, since we know p0 < p1 then.
5719 This also avoids a gcc -Wstrict-overflow warning.
5721 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5722 leading to a memory leak, possible in functions like
5723 load_charset_map_from_file that can allocate an unbounded number
5724 of objects (Bug#8318).
5726 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5727 that could (at least in theory) be that large.
5729 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5730 This is less likely to overflow, and avoids undefined behavior if
5731 overflow does occur. All callers changed. Use strtoul to scan
5732 for the unsigned long integer.
5733 (pint2hrstr): Simplify and tune code slightly.
5734 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5736 * scroll.c (do_scrolling): Work around GCC bug 48228.
5737 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5739 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5740 This also avoids a warning with gcc -Wstrict-overflow.
5741 (validate_x_resource_name): Simplify count usage.
5742 This also avoids a warning with gcc -Wstrict-overflow.
5744 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5747 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5749 * process.c (Fmake_network_process): Use socklen_t, not int,
5750 where POSIX says socklen_t is required in portable programs.
5751 This fixes a porting bug on hosts like 64-bit HP-UX, where
5752 socklen_t is wider than int (Bug#8277).
5753 (Fmake_network_process, server_accept_connection):
5754 (wait_reading_process_output, read_process_output):
5757 * process.c: Rename or move locals to avoid shadowing.
5758 (list_processes_1, Fmake_network_process):
5759 (read_process_output_error_handler, exec_sentinel_error_handler):
5760 Rename or move locals.
5761 (Fmake_network_process): Define label "retry_connect" only if needed.
5762 (Fnetwork_interface_info): Fix pointer signedness.
5763 (process_send_signal): Add cast to avoid pointer signedness problem.
5764 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5765 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5767 Make tparam.h and terminfo.c consistent.
5768 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5769 Include tparam.h instead, since it declares them.
5770 * cm.h (PC): Remove extern decl; tparam.h now does this.
5771 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5772 * terminfo.c: Include tparam.h, to check interfaces.
5773 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5774 (tparam): Adjust signature to match interface in tparam.h;
5775 this removes some undefined behavior. Check that outstring and len
5776 are zero, which they always are with Emacs.
5777 * tparam.h (PC, BC, UP): New extern decls.
5779 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5780 (xftfont_open): Rename locals to avoid shadowing.
5782 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5783 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5784 (OTF_TAG_SYM): Omit macro if not needed.
5785 (ftfont_list): Remove unused local.
5786 (get_adstyle_property, ftfont_pattern_entity):
5787 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5788 Rename locals to avoid shadowing.
5790 * xfont.c (xfont_list_family): Mark var as initialized.
5792 * xml.c (make_dom): Now static.
5794 * composite.c (composition_compute_stop_pos): Rename local to
5796 (composition_reseat_it): Remove unused locals.
5797 (find_automatic_composition, composition_adjust_point): Likewise.
5798 (composition_update_it): Mark var as initialized.
5799 (find_automatic_composition): Mark vars as initialized,
5800 with a FIXME (Bug#8290).
5802 character.h: Rename locals to avoid shadowing.
5803 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5804 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5805 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5806 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5809 * textprop.c (property_change_between_p): Remove; unused.
5811 * intervals.c (interval_start_pos): Now static.
5813 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5815 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5816 Rename locals to avoid shadowing.
5818 * sound.c (wav_play, au_play, Fplay_sound_internal):
5819 Fix pointer signedness.
5820 (alsa_choose_format): Remove unused local var.
5821 (wav_play): Initialize a variable to 0, to prevent undefined
5822 behavior (Bug#8278).
5824 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5826 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5828 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5829 clobbering (Bug#8298).
5830 * sysdep.c (sys_subshell): Likewise.
5831 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5833 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5834 This should get cleaned up, so that child_setup has the
5835 same signature on all platforms.
5837 * callproc.c (call_process_cleanup): Now static.
5838 (relocate_fd): Rename locals to avoid shadowing.
5840 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5842 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5843 not to be necessary, and produces flickering.
5845 2011-03-20 Glenn Morris <rgm@gnu.org>
5847 * config.in: Remove file.
5849 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5851 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5852 are now in src/globals.h.
5853 (syms_of_minibuf): Remove spurious & from previous change.
5855 2011-03-20 Leo <sdl.web@gmail.com>
5857 * minibuf.c (completing-read-function): New variable.
5858 (completing-read-default): Rename from completing-read.
5859 (completing-read): Call completing-read-function.
5861 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5863 * xfaces.c (Fx_load_color_file):
5864 Read color file from absolute filename (bug#8250).
5866 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5868 * makefile.w32-in: Update dependencies.
5870 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5872 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5874 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5876 Fix more problems found by GCC 4.5.2's static checks.
5878 * process.c (make_serial_process_unwind, send_process_trap):
5879 (sigchld_handler): Now static.
5881 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5882 That way, the code declares only the vars that it needs.
5883 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5884 * s/cygwin.h (PTY_ITERATION): Likewise.
5885 * s/darwin.h (PTY_ITERATION): Likewise.
5886 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5888 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5889 * process.c (allocate_pty): Don't declare stb unless it's needed.
5891 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5892 (CONSTANTLIM): Remove; unused.
5893 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5894 Define only if needed.
5896 * unexelf.c (unexec): Name an expression,
5897 to avoid gcc -Wbad-function-cast warning.
5898 Use a different way to cause a compilation error if anyone uses
5899 n rather than nn, a way that does not involve shadowing.
5900 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5902 * deps.mk (unexalpha.o): Remove; unused.
5904 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5905 * unexec.h: New file.
5906 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5907 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5909 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5910 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5911 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5912 Change as necessary to match prototype in unexec.h.
5914 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5916 (back_comment, skip_chars): Mark vars as initialized.
5918 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5919 Rename locals to avoid shadowing.
5921 * lread.c (read1): Rewrite so as not to use empty "else".
5922 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5924 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5926 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5927 warning when compiling print.c.
5929 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5930 instead of using an uninitialized var.
5931 (font_sort_entities): Mark var as initialized.
5933 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5935 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5936 pointers to constants.
5937 (font_parse_fcname): Remove unused vars.
5938 (font_delete_unmatched): Now static.
5939 (font_get_spec): Remove; unused.
5940 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5941 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5942 Rename or move locals to avoid shadowing.
5944 * fns.c (require_nesting_list, require_unwind): Now static.
5945 (Ffillarray): Rename locals to avoid shadowing.
5947 * floatfns.c (domain_error2): Define only if needed.
5948 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5950 * alloc.c (mark_backtrace): Move decl from here ...
5951 * lisp.h: ... to here, so that it can be checked.
5953 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5954 (Fdefvar): Rewrite so as not to use empty "else".
5955 (lisp_indirect_variable): Name an expression,
5956 to avoid gcc -Wbad-function-cast warning.
5957 (Fdefvar): Rename locals to avoid shadowing.
5959 * callint.c (quotify_arg, quotify_args): Now static.
5960 (Fcall_interactively): Rename locals to avoid shadowing.
5961 Use const pointer when appropriate.
5963 * lisp.h (get_system_name, get_operating_system_release):
5964 Move decls here, to check interfaces.
5965 * process.c (get_operating_system_release): Move decl to lisp.h.
5966 * xrdb.c (get_system_name): Likewise.
5967 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5968 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5969 some of which prompt warnings from gcc -Wbad-function-cast.
5970 (Fformat_time_string, Fencode_time, Finsert_char):
5971 (Ftranslate_region_internal, Fformat):
5972 Rename or remove local vars to avoid shadowing.
5973 (Ftranslate_region_internal): Mark var as initialized.
5975 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5978 * lisp.h (eassert): Check that the argument compiles, even if
5979 ENABLE_CHECKING is not defined.
5981 * data.c (Findirect_variable): Name an expression, to avoid
5982 gcc -Wbad-function-cast warning.
5983 (default_value, arithcompare, arith_driver, arith_error): Now static.
5984 (store_symval_forwarding): Rename local to avoid shadowing.
5985 (Fmake_variable_buffer_local, Fmake_local_variable):
5986 Mark variables as initialized.
5987 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5989 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5990 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5991 Rename locals to avoid shadowing.
5992 (mark_stack): Move local variables into the #ifdef region where
5994 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5995 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5997 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5998 (GC_STRING_CHARS): Remove; not used.
5999 (Fmemory_limit): Cast sbrk's returned value to char *.
6001 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6002 avoids undefined behavior in theory.
6004 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6006 Use functions, not macros, for up- and down-casing (Bug#8254).
6007 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6008 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6009 to use the following functions instead of these macros.
6010 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6011 EMACS_INT, since callers assume the returned value fits in int.
6012 (upcase1): Likewise, for UPCASE_TABLE.
6013 (uppercasep, lowercasep, upcase): New static inline functions.
6014 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6015 the race-condition problem in the old DOWNCASE.
6017 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6018 Rename locals to avoid shadowing.
6019 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6020 (regex_compile, re_search_2, re_match_2_internal):
6021 Remove unused local vars.
6022 (FREE_VAR): Rewrite so as not to use empty "else",
6023 which gcc can warn about.
6024 (regex_compile, re_match_2_internal): Mark locals as initialized.
6025 (RETALLOC_IF): Define only if needed.
6026 (WORDCHAR_P): Likewise. This one is never needed, but is used
6027 only in a comment talking about a compiler bug, so put inside
6028 the #if 0 of that comment.
6029 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6030 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6033 * search.c (boyer_moore): Rename locals to avoid shadowing.
6034 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6035 (PREV_CHAR_BOUNDARY): Likewise.
6037 * search.c (simple_search): Remove unused var.
6039 * dired.c (compile_pattern): Move decl from here ...
6040 * lisp.h: ... to here, so that it can be checked.
6041 (struct re_registers): New forward decl.
6043 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6045 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6047 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6048 Rename locals to avoid shadowing.
6049 (Fvertical_motion): Mark locals as initialized.
6051 * casefiddle.c (casify_object, casify_region): Now static.
6052 (casify_region): Mark local as initialized.
6054 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6056 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6057 New macros, so that the caller can use some names other than
6058 gcpro1, gcpro2, etc.
6059 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6061 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6062 argument, for consistency with GCPRO2_VAR, etc: it is now the
6063 prefix of the variable, not the variable itself. All uses
6065 * dired.c (directory_files_internal, file_name_completion):
6066 Rename locals to avoid shadowing.
6068 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6069 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6070 dired.c's scmp function, had undefined behavior.
6071 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6072 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6073 * buffer.h: ... to here, because these macros use current_buffer,
6074 and the new implementation with inline functions needs to have
6075 current_buffer in scope now, rather than later when the macros
6077 (downcase, upcase1): New static inline functions.
6078 (DOWNCASE, UPCASE1): Reimplement using these functions.
6079 This avoids undefined behavior in expressions like
6080 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6081 from race conditions in accessing the global variables
6082 case_temp1 and case_temp2.
6083 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6084 * lisp.h (case_temp1, case_temp2): Remove their decls.
6085 * character.h (ASCII_CHAR_P): Move from here ...
6086 * lisp.h: ... to here, so that the inline functions mentioned
6089 * dired.c (directory_files_internal_unwind): Now static.
6091 * fileio.c (file_name_as_directory, directory_file_name):
6092 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6094 (file_name_as_directory): Use const pointers when appropriate.
6095 (Fexpand_file_name): Likewise. In particular, newdir might
6096 point at constant storage, so make it a const pointer.
6097 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6098 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6100 (Fset_file_times, Finsert_file_contents, auto_save_error):
6101 Rename locals to avoid shadowing.
6103 * minibuf.c (choose_minibuf_frame_1): Now static.
6104 (Ftry_completion, Fall_completions): Rename or remove locals
6107 * marker.c (bytepos_to_charpos): Remove; unused.
6109 * lisp.h (verify_bytepos, count_markers): New decls,
6110 so that gcc does not warn that these functions aren't declared.
6112 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6113 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6114 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6115 (copy_text): Remove unused local var.
6117 * filelock.c (within_one_second): Now static.
6118 (lock_file_1): Rename local to avoid shadowing.
6120 * buffer.c (fix_overlays_before): Mark locals as initialized.
6121 (fix_start_end_in_overlays): Likewise. This function should be
6122 simplified by using pointers-to-pointers, but that's a different
6124 (switch_to_buffer_1): Now static.
6125 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6126 (report_overlay_modification): Rename locals to avoid shadowing.
6128 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6129 Fix pointer signedness issue.
6130 (sys_subshell): Mark local as volatile if checking for lint,
6131 to suppress a gcc -Wclobbered warning that does not seem to be right.
6132 (MAXPATHLEN): Define only if needed.
6134 * process.c (serial_open, serial_configure): Move decls from here ...
6135 * systty.h: ... to here, so that they can be checked.
6137 * fns.c (get_random, seed_random): Move extern decls from here ...
6138 * lisp.h: ... to here, so that they can be checked.
6140 * sysdep.c (reset_io): Now static.
6141 (wait_for_termination_signal): Remove; unused.
6143 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6144 (copy_keymap_item, append_key, push_text_char_description):
6146 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6147 (DENSE_TABLE_SIZE): Remove; unused.
6148 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6149 (describe_map_tree):
6150 Rename locals to avoid shadowing.
6152 * keyboard.c: Declare functions static if they are not used elsewhere.
6153 (echo_char, echo_dash, cmd_error, top_level_2):
6154 (poll_for_input, handle_async_input): Now static.
6155 (read_char, kbd_buffer_get_event, make_lispy_position):
6156 (make_lispy_event, make_lispy_movement, apply_modifiers):
6157 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6158 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6159 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6160 (read_key_sequence, read_char): Mark locals as initialized.
6161 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6163 * keyboard.h (make_ctrl_char): New decl.
6164 (mark_kboards): Move decl here ...
6165 * alloc.c (mark_kboards): ... from here.
6167 * lisp.h (force_auto_save_soon): New decl.
6169 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6170 (DEFINE_DUMMY_FUNCTION): New macro.
6171 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6173 (main): Add casts to avoid warnings
6174 if GCC considers string literals to be constants.
6176 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6178 * dbusbind.c: Pointer signedness fixes.
6179 (xd_signature, xd_append_arg, xd_initialize):
6180 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6181 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6182 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6183 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6185 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6186 if GCC considers string literals to be constants.
6187 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6189 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6191 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6192 (print_preprocess, print_object): New macro to fix last change.
6194 * print.c (print_preprocess): Don't forget font objects.
6196 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6198 * emacs.c (USAGE3): Doc fixes.
6200 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6202 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6205 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6207 * lisp.h (VWindow_system, Qfile_name_history):
6208 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6209 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6210 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6212 * w32select.c: Don't #include "keyboard.h".
6213 (run_protected): Add extern declaration for waiting_for_input.
6215 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6216 * w32console.c (detect_input_pending, read_input_pending)
6217 (encode_terminal_code):
6218 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6219 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6220 (w32_system_caret_y, Qfile_name_history):
6221 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6222 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6223 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6224 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6225 * w32proc.c (Qlocal, report_file_error):
6226 * w32term.c (Vwindow_system, updating_frame):
6227 * w32uniscribe.c (initialized, uniscribe_font_driver):
6228 Remove unneeded extern declarations.
6230 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6232 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6234 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6236 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6237 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6238 These macros can no longer be used for assignment.
6240 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6241 Assign struct members directly, instead of using BUF_BEGV etc.
6242 (record_buffer_markers, fetch_buffer_markers): New functions for
6243 recording and fetching special buffer markers.
6244 (set_buffer_internal_1, set_buffer_temp): Use them.
6246 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6248 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6250 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6251 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6253 * xdisp.c (hscroll_window_tree):
6254 (reconsider_clip_changes): Use PT instead of BUF_PT.
6256 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6258 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6259 $(EMACS_ROOT)/lib/intprops.h.
6261 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6263 Fix more problems found by GCC 4.5.2's static checks.
6265 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6266 to unsigned char * to avoid compiler diagnostic.
6267 (xg_free_frame_widgets): Make it clear that a local variable is
6268 needed only if USE_GTK_TOOLTIP.
6269 (gdk_window_get_screen): Make it clear that this macro is needed
6270 only if USE_GTK_TOOLTIP.
6271 (int_gtk_range_get_value): New function, which avoids a diagnostic
6272 from gcc -Wbad-function-cast.
6273 (xg_set_toolkit_scroll_bar_thumb): Use it.
6274 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6275 diagnostic from gcc -Wbad-function-cast.
6276 (get_utf8_string, xg_get_file_with_chooser):
6277 Rename locals to avoid shadowing.
6278 (create_dialog): Move locals to avoid shadowing.
6280 * xgselect.c (xg_select): Remove unused var.
6282 * image.c (four_corners_best): Mark locals as initialized.
6283 (gif_load): Initialize transparent_p to zero (Bug#8238).
6284 Mark another local as initialized.
6285 (my_png_error, my_error_exit): Mark with NO_RETURN.
6287 * image.c (clear_image_cache): Now static.
6288 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6289 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6290 (x_edge_detection): Remove unnecessary cast that
6291 gcc -Wbad-function-cast diagnoses.
6292 (gif_load): Fix pointer signedness.
6293 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6294 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6296 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6298 Improve quality of tests for time stamp overflow.
6299 For example, without this patch (encode-time 0 0 0 1 1
6300 1152921504606846976) returns the obviously-bogus value (-948597
6301 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6302 reports time overflow. See
6303 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6304 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6305 * editfns.c: Include limits.h and intprops.h.
6306 (TIME_T_MIN, TIME_T_MAX): New macros.
6307 (time_overflow): Move earlier, to before first use.
6308 (hi_time, lo_time): New functions, for an accurate test for
6310 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6311 (Fget_internal_run_time): Don't assume time_t fits in int.
6312 (make_time): Use list2 instead of Fcons twice.
6313 (Fdecode_time): More accurate test for out-of-range times.
6314 (check_tm_member): New function.
6315 (Fencode_time): Use it, to test for out-of-range times.
6316 (lisp_time_argument): Don't rely on undefined left-shift and
6317 right-shift behavior when checking for time stamp overflow.
6319 * editfns.c (time_overflow): New function, refactoring common code.
6320 (Fformat_time_string, Fdecode_time, Fencode_time):
6321 (Fcurrent_time_string): Use it.
6323 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6324 * dired.c (make_time): Move to ...
6325 * editfns.c (make_time): ... here.
6326 * systime.h: Note the move.
6328 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6330 * fringe.c (update_window_fringes): Remove unused variables.
6332 * unexmacosx.c (copy_data_segment): Also copy __got section.
6335 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6337 * termcap.c [MSDOS]: Include "msdos.h".
6338 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6339 Constify `char *' arguments and their references according to
6340 prototypes in tparam.h.
6342 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6344 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6345 Adapt all references accordingly.
6347 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6349 2011-03-11 Tom Tromey <tromey@redhat.com>
6351 * buffer.c (syms_of_buffer): Remove obsolete comment.
6353 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6355 * termhooks.h (encode_terminal_code): Declare prototype.
6357 * msdos.c (encode_terminal_code): Don't declare prototype.
6359 * term.c (encode_terminal_code): Now external again, used by
6360 w32console.c and msdos.c.
6362 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6363 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6365 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6367 Fix some minor problems found by GCC 4.5.2's static checks.
6369 * fringe.c (update_window_fringes): Mark locals as initialized
6371 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6373 * alloc.c (mark_fringe_data): Move decl from here ...
6374 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6375 to check its interface.
6376 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6378 * fontset.c (free_realized_fontset): Now static.
6379 (Fset_fontset_font): Rename local to avoid shadowing.
6380 (fontset_font): Mark local as initialized.
6381 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6383 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6385 * xselect.c (x_disown_buffer_selections): Remove; not used.
6386 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6387 (x_own_selection, Fx_disown_selection_internal): Rename locals
6389 (x_handle_dnd_message): Remove local to avoid shadowing.
6391 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6392 so that the caller can use some name other than gcpro1.
6393 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6394 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6395 (Fx_backspace_delete_keys_p):
6396 Use them to avoid shadowing, and rename vars to avoid shadowing.
6397 (x_decode_color, x_set_name, x_window): Now static.
6398 (Fx_create_frame): Add braces to silence GCC warning.
6399 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6400 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6401 Remove unused locals.
6402 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6403 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6404 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6407 * xterm.h (x_mouse_leave): New decl.
6409 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6410 Remove unused functions.
6411 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6412 (x_calc_absolute_position): Now static.
6413 (XTread_socket): Don't define label "out" unless it's used.
6414 Don't declare local "event" unless it's used.
6415 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6416 unless they are used.
6417 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6418 (x_fatal_error_signal): Remove; not used.
6419 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6420 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6421 (x_error_catcher, x_connection_closed, x_error_handler):
6422 (x_error_quitter, xembed_send_message, x_iconify_frame):
6423 (my_log_handler): Rename locals to avoid shadowing.
6424 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6425 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6427 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6428 Rename or move locals to avoid shadowing.
6429 (tty_defined_color, merge_face_heights): Now static.
6430 (free_realized_faces_for_fontset): Remove; not used.
6431 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6432 does not deduce is never used uninitialized.
6433 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6434 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6436 * terminal.c (store_terminal_param): Now static.
6438 * xmenu.c (menu_highlight_callback): Now static.
6439 (set_frame_menubar): Remove unused local.
6440 (xmenu_show): Rename parameter to avoid shadowing.
6441 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6442 since they might point to immutable storage.
6443 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6444 since it's unused otherwise.
6446 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6447 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6448 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6449 avoids a gcc -Wuninitialized diagnostic.
6450 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6451 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6452 does not deduce are never used uninitialized.
6454 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6456 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6457 * window.c (window_loop, size_window):
6458 (run_window_configuration_change_hook, enlarge_window): Likewise.
6460 * window.c (display_buffer): Now static.
6461 (size_window): Mark variables that gcc -Wuninitialized
6462 does not deduce are never used uninitialized.
6463 * window.h (check_all_windows): New decl, to forestall
6464 gcc -Wmissing-prototypes diagnostic.
6465 * dispextern.h (bidi_dump_cached_states): Likewise.
6467 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6469 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6471 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6472 and to avoid gcc -Wuninitialized warning.
6473 (load_charset_map): Mark variables that gcc -Wuninitialized
6474 does not deduce are never used uninitialized.
6475 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6477 * coding.c (coding_set_source, coding_set_destination):
6478 Use "else { /* comment */ }" rather than "else /* comment */;"
6479 for clarity, and to avoid gcc -Wempty-body warning.
6480 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6481 a block, when the outer 'i' will do.
6482 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6483 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6484 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6485 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6486 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6487 Rename locals to avoid shadowing.
6488 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6489 * coding.c (emacs_mule_char, encode_invocation_designation):
6490 Now static, since they're not used elsewhere.
6491 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6492 (decode_coding_object, encode_coding_object, detect_coding_system):
6493 (decode_coding_emacs_mule): Mark variables that gcc
6494 -Wuninitialized does not deduce are never used uninitialized.
6495 (detect_coding_iso_2022): Initialize a local variable that might
6496 be used uninitialized. Leave a FIXME because it's not clear that
6497 this initialization is needed. (Bug#8211)
6498 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6499 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6500 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6501 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6502 Remove unused macros.
6504 * category.c (hash_get_category_set): Remove unused local var.
6505 (copy_category_table): Now static, since it's not used elsewhere.
6506 * character.c (string_count_byte8): Likewise.
6508 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6509 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6511 * chartab.c (copy_sub_char_table): Now static, since it's not used
6513 (sub_char_table_ref_and_range, char_table_ref_and_range):
6514 Rename locals to avoid shadowing.
6515 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6517 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6518 (BIDI_BOB): Remove unused macro.
6520 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6521 deduce are never used uninitialized.
6522 * term.c (encode_terminal_code): Likewise.
6524 * term.c (encode_terminal_code): Now static. Remove unused local.
6526 * tparam.h: New file.
6527 * term.c, tparam.h: Include it.
6528 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6529 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6530 Move these decls to tparam.h, and make them agree with what
6531 is actually in tparam.c. The previous trick of using incompatible
6532 decls in different modules does not conform to the C standard.
6533 All callers of tparam changed to use tparam's actual API.
6534 * tparam.c (tparam1, tparam, tgoto):
6535 Use const pointers where appropriate.
6537 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6538 * cm.h (struct cm): Likewise.
6539 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6540 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6541 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6542 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6543 (turn_on_face, init_tty): Likewise.
6544 * termchar.h (struct tty_display_info): Likewise.
6546 * term.c (term_mouse_position): Rename local to avoid shadowing.
6548 * alloc.c (mark_ttys): Move decl from here ...
6549 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6551 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6553 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6555 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6557 * search.c (compile_pattern_1): Remove argument regp, unused since
6558 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6559 (compile_pattern): Don't pass it.
6561 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6563 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6564 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6566 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6568 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6570 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6571 gdk_window_get_screen, gdk_window_get_geometry,
6572 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6573 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6574 (xg_get_pixbuf_from_pixmap): New function.
6575 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6576 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6577 Call xg_get_pixbuf_from_pixmap instead of
6578 gdk_pixbuf_get_from_drawable.
6579 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6580 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6581 (xg_check_special_colors): Use GtkStyleContext and its functions
6583 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6584 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6585 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6586 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6587 Call gtk_widget_get_preferred_size.
6588 (xg_frame_resized): gdk_window_get_geometry only takes 5
6590 (xg_win_to_widget, xg_event_is_for_menubar):
6591 Call gdk_x11_window_lookup_for_display.
6592 (xg_set_widget_bg): New function.
6593 (delete_cb): New function.
6594 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6595 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6596 (xg_set_background_color): Call xg_set_widget_bg.
6597 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6598 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6599 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6600 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6602 (update_frame_tool_bar): Call gtk_widget_hide.
6603 (xg_initialize): Use GDK_KEY_g.
6605 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6607 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6609 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6610 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6611 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6613 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6615 * w32xfns.c (select_palette): Check success of RealizePalette against
6616 GDI_ERROR, not zero.
6618 See ChangeLog.11 for earlier changes.
6624 Copyright (C) 2011 Free Software Foundation, Inc.
6626 This file is part of GNU Emacs.
6628 GNU Emacs is free software: you can redistribute it and/or modify
6629 it under the terms of the GNU General Public License as published by
6630 the Free Software Foundation, either version 3 of the License, or
6631 (at your option) any later version.
6633 GNU Emacs is distributed in the hope that it will be useful,
6634 but WITHOUT ANY WARRANTY; without even the implied warranty of
6635 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6636 GNU General Public License for more details.
6638 You should have received a copy of the GNU General Public License
6639 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.