Fix how custom themes handle faces, so the multi-tty/multi-frame case works.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2
3 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4 and background color parameters if they have been changed.
5
6 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7
8 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9
10 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
11
12 * xsettings.c (SYSTEM_FONT): Define only when used.
13 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
14
15 * keymap.c (access_keymap_1): Now static.
16
17 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
18
19 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
20 leave any prefix arg for the up event (Bug#1586).
21
22 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
23
24 * lread.c (syms_of_lread): Mention single symbols defined by
25 `defvar' or `defconst' (bug#7154).
26
27 * fns.c (Frequire): Mention .el.gz files (bug#7314).
28 (Frequire): Mention get-load-suffixes.
29
30 2011-07-02 Martin Rudalics <rudalics@gmx.at>
31
32 * window.h (window): Remove clone_number slot.
33 * window.c (Fwindow_clone_number, Fset_window_clone_number):
34 Remove.
35 (make_parent_window, make_window, saved_window)
36 (Fset_window_configuration, save_window_save): Don't deal with
37 clone numbers.
38 * buffer.c (Qclone_number): Remove declaration.
39 (sort_overlays, overlay_strings): Don't deal with clone numbers.
40
41 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
42
43 Add multiple inheritance to keymaps.
44 * keymap.c (Fmake_composed_keymap): New function.
45 (Fset_keymap_parent): Simplify.
46 (fix_submap_inheritance): Remove.
47 (access_keymap_1): New function extracted from access_keymap to handle
48 embedded parents and handle lists of maps.
49 (access_keymap): Use it.
50 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
51 (Fcopy_keymap): Handle embedded parents.
52 (Fcommand_remapping, define_as_prefix): Simplify.
53 (Fkey_binding): Simplify.
54 (syms_of_keymap): Move minibuffer-local-completion-map,
55 minibuffer-local-filename-completion-map,
56 minibuffer-local-must-match-map, and
57 minibuffer-local-filename-must-match-map to Elisp.
58 (syms_of_keymap): Defsubr make-composed-keymap.
59 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
60 (parse_menu_item): Trivial simplification.
61
62 2011-07-01 Glenn Morris <rgm@gnu.org>
63
64 * Makefile.in (SETTINGS_LIBS): Fix typo.
65
66 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
67
68 * coding.c (Fencode_coding_string): Record the last coding system
69 used, as the function doc string says (bug#8738).
70
71 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
72
73 * xsettings.c (store_monospaced_changed): Take new font as arg and
74 check for change against current_mono_font.
75 (EMACS_TYPE_SETTINGS): Remove this and related defines.
76 (emacs_settings_constructor, emacs_settings_get_property)
77 (emacs_settings_set_property, emacs_settings_class_init)
78 (emacs_settings_init, gsettings_obj): Remove.
79 (something_changedCB): New function for HAVE_GSETTINGS.
80 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
81 with value as argument.
82 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
83 g_settings_new (Bug#8967). Do not create gsettings_obj.
84 Remove calls to g_settings_bind. Connect something_changedCB to
85 "changed".
86
87 * xgselect.c: Add defined (HAVE_GSETTINGS).
88 (xgselect_initialize): Ditto.
89
90 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
91 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
92 xg_select.
93
94 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
95
96 * eval.c (struct backtrace): Simplify and port the data structure.
97 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
98 signed bit field, as this assumption is not portable and it makes
99 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
100 "char debug_on_exit : 1" as this is not portable either; instead,
101 use the portable "unsigned int debug_on_exit : 1". Remove unused
102 member evalargs. Remove obsolete comments about cc bombing out.
103
104 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
105
106 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
107 Let HAVE_GSETTINGS override HAVE_GCONF.
108 (store_monospaced_changed): New function.
109 (EMACS_SETTINGS): A new type derived from GObject to handle
110 GSettings notifications.
111 (emacs_settings_constructor, emacs_settings_get_property)
112 (emacs_settings_set_property, emacs_settings_class_init):
113 New functions.
114 (gsettings_client, gsettings_obj): New variables.
115 (GSETTINGS_SCHEMA): New define.
116 (something_changedCB): Call store_monospaced_changed.
117 (init_gsettings): New function.
118 (xsettings_initialize): Call init_gsettings.
119 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
120 to NULL.
121
122 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
123 GCONF_CFLAGS/LIBS.
124
125 2011-06-29 Martin Rudalics <rudalics@gmx.at>
126
127 * window.c (resize_root_window, grow_mini_window)
128 (shrink_mini_window): Rename Qresize_root_window to
129 Qwindow_resize_root_window and Qresize_root_window_vertically to
130 Qwindow_resize_root_window_vertically.
131
132 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
133
134 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
135
136 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
137
138 * makefile.w32-in: Redesign dependencies so they reflect more
139 clearly which files are directly included by each source file,
140 and not through other includes.
141
142 2011-06-27 Martin Rudalics <rudalics@gmx.at>
143
144 * buffer.c (Qclone_number): Declare static and DEFSYM it.
145 (sort_overlays, overlay_strings): When an overlay's clone number
146 matches the window's clone number process the overlay even if
147 the overlay's window property doesn't match the current window.
148
149 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
150 (Fwindow_hchild): Rename to Fwindow_left_child.
151 (Fwindow_next): Rename to Fwindow_next_sibling.
152 (Fwindow_prev): Rename to Fwindow_prev_sibling.
153 (resize_window_check): Rename to window_resize_check.
154 (resize_window_apply): Rename to window_resize_apply.
155 (Fresize_window_apply): Rename to Fwindow_resize_apply.
156 (Fdelete_other_windows_internal, resize_frame_windows)
157 (Fsplit_window_internal, Fdelete_window_internal)
158 (grow_mini_window, shrink_mini_window)
159 (Fresize_mini_window_internal): Fix callers accordingly.
160
161 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
162
163 * emacsgtkfixed.h: State that this is only used with Gtk+3.
164 (emacs_fixed_set_min_size): Remove.
165 (emacs_fixed_new): Take frame as argument.
166
167 * emacsgtkfixed.c: State that this is only used with Gtk+3.
168 (_EmacsFixedPrivate): Remove minwidth/height.
169 Add struct frame *f.
170 (emacs_fixed_init): Initialize priv->f.
171 (get_parent_class, emacs_fixed_set_min_size): Remove.
172 (emacs_fixed_new): Set priv->f to argument.
173 (emacs_fixed_get_preferred_width)
174 (emacs_fixed_get_preferred_height): Use min_width/height from
175 frames size_hint to set minimum and natural (Bug#8919).
176 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
177 and use min_width/height from frames size_hint to set
178 min_width/height (Bug#8919).
179
180 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
181 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
182 indentation.
183
184 2011-06-26 Eli Zaretskii <eliz@gnu.org>
185
186 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
187 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
188 called at ZV.
189
190 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
191
192 * process.c (wait_reading_process_output): Bypass select if
193 waiting for a cell while ignoring keyboard input, and input is
194 pending. Suggested by Jan Djärv (Bug#8869).
195
196 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
197
198 Use gnulib's dup2 module instead of rolling our own.
199 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
200
201 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
202
203 * dispnew.c (scrolling_window): Before scrolling, turn off a
204 mouse-highlight in the window being scrolled.
205
206 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
207
208 Move DEFSYM to lisp.h and use everywhere.
209
210 * character.h (DEFSYM): Move declaration...
211 * lisp.h (DEFSYM): ...here.
212
213 * gnutls.c:
214 * minibuf.c:
215 * w32menu.c:
216 * w32proc.c:
217 * w32select.c: Don't include character.h.
218
219 * alloc.c (syms_of_alloc):
220 * buffer.c (syms_of_buffer):
221 * bytecode.c (syms_of_bytecode):
222 * callint.c (syms_of_callint):
223 * casefiddle.c (syms_of_casefiddle):
224 * casetab.c (init_casetab_once):
225 * category.c (init_category_once, syms_of_category):
226 * ccl.c (syms_of_ccl):
227 * cmds.c (syms_of_cmds):
228 * composite.c (syms_of_composite):
229 * dbusbind.c (syms_of_dbusbind):
230 * dired.c (syms_of_dired):
231 * dispnew.c (syms_of_display):
232 * doc.c (syms_of_doc):
233 * editfns.c (syms_of_editfns):
234 * emacs.c (syms_of_emacs):
235 * eval.c (syms_of_eval):
236 * fileio.c (syms_of_fileio):
237 * fns.c (syms_of_fns):
238 * frame.c (syms_of_frame):
239 * fringe.c (syms_of_fringe):
240 * insdel.c (syms_of_insdel):
241 * keymap.c (syms_of_keymap):
242 * lread.c (init_obarray, syms_of_lread):
243 * macros.c (syms_of_macros):
244 * msdos.c (syms_of_msdos):
245 * print.c (syms_of_print):
246 * process.c (syms_of_process):
247 * search.c (syms_of_search):
248 * sound.c (syms_of_sound):
249 * syntax.c (init_syntax_once, syms_of_syntax):
250 * terminal.c (syms_of_terminal):
251 * textprop.c (syms_of_textprop):
252 * undo.c (syms_of_undo):
253 * w32.c (globals_of_w32):
254 * window.c (syms_of_window):
255 * xdisp.c (syms_of_xdisp):
256 * xfaces.c (syms_of_xfaces):
257 * xfns.c (syms_of_xfns):
258 * xmenu.c (syms_of_xmenu):
259 * xsettings.c (syms_of_xsettings):
260 * xterm.c (syms_of_xterm): Use DEFSYM.
261
262 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
263
264 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
265
266 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
267
268 Integer and buffer overflow fixes (Bug#8873).
269
270 * print.c (printchar, strout): Check for string overflow.
271 (PRINTPREPARE, printchar, strout):
272 Don't set size unless allocation succeeds.
273
274 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
275 for sizes. Check for string overflow more accurately.
276 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
277
278 * macros.c: Integer and buffer overflow fixes.
279 * keyboard.h (struct keyboard.kbd_macro_bufsize):
280 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
281 Use ptrdiff_t, not int, for sizes.
282 Don't increment bufsize until after realloc succeeds.
283 Check for size-calculation overflow.
284 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
285
286 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
287
288 * lread.c: Integer overflow fixes.
289 (read_integer): Radix is now EMACS_INT, not int,
290 to improve quality of diagnostics for out-of-range radices.
291 Calculate buffer size correctly for out-of-range radices.
292 (read1): Check for integer overflow in radices, and in
293 read-circle numbers.
294 (read_escape): Avoid int overflow.
295 (Fload, openp, read_buffer_size, read1)
296 (substitute_object_recurse, read_vector, read_list, map_obarray):
297 Use ptrdiff_t, not int, for sizes.
298 (read1): Use EMACS_INT, not int, for sizes.
299 Check for size overflow.
300
301 * image.c (cache_image): Check for size arithmetic overflow.
302
303 * lread.c: Integer overflow issues.
304 (saved_doc_string_size, saved_doc_string_length)
305 (prev_saved_doc_string_size, prev_saved_doc_string_length):
306 Now ptrdiff_t, not int.
307 (read1): Don't assume doc string length fits in int. Check for
308 out-of-range doc string lengths.
309 (read_list): Don't assume file position fits in int.
310 (read_escape): Check for hex character overflow.
311
312 2011-06-22 Leo Liu <sdl.web@gmail.com>
313
314 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
315 Move to minibuffer.el.
316
317 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
318
319 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
320 The following patches are for when GLYPH_DEBUG && !XASSERT.
321 * dispextern.h (trace_redisplay_p, dump_glyph_string):
322 * dispnew.c (flush_stdout):
323 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
324 Mark as externally visible.
325 * dispnew.c (check_window_matrix_pointers): Now static.
326 * dispnew.c (window_to_frame_vpos):
327 * xfns.c (unwind_create_frame):
328 * xterm.c (x_check_font): Remove unused local.
329 * scroll.c (CHECK_BOUNDS):
330 * xfaces.c (cache_fache): Rename local to avoid shadowing.
331 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
332 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
333 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
334 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
335 Now static.
336 (debug_method_add): Use va_list and vsprintf rather than relying
337 on undefined behavior with wrong number of arguments.
338 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
339 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
340 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
341 since we're not interested in debugging glyphs with old libraries.
342 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
343 GCC 4.6.0's static checking.
344
345 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
346
347 Integer overflow and signedness fixes (Bug#8873).
348 A few related buffer overrun fixes, too.
349
350 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
351
352 * dispextern.h (struct face.stipple):
353 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
354 (x_bitmap_mask, x_allocate_bitmap_record)
355 (x_create_bitmap_from_data, x_create_bitmap_from_file)
356 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
357 (x_create_bitmap_from_xpm_data):
358 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
359 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
360 (.bitmaps_last):
361 * xfaces.c (load_pixmap):
362 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
363 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
364 (.bitmaps_last, struct x_output.icon_bitmap):
365 Use ptrdiff_t, not int, for bitmap indexes.
366 (x_allocate_bitmap_record): Check for size overflow.
367 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
368
369 Use ptrdiff_t, not int, for overlay counts.
370 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
371 * editfns.c (overlays_around, get_pos_property):
372 * textprop.c (get_char_property_and_overlay):
373 * xdisp.c (next_overlay_change, note_mouse_highlight):
374 * xfaces.c (face_at_buffer_position):
375 * buffer.c (OVERLAY_COUNT_MAX): New macro.
376 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
377 (Fnext_overlay_change, Fprevious_overlay_change)
378 (mouse_face_overlay_overlaps, Foverlays_in):
379 Use ptrdiff_t, not int, for sizes.
380 (overlays_at, overlays_in): Check for size-calculation overflow.
381
382 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
383
384 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
385 (x_session_initialize): Do not assume string length fits in int.
386
387 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
388 This is unlikely, but can occur if DPI is outlandish.
389
390 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
391 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
392
393 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
394 * xrdb.c (magic_file_p, search_magic_path):
395 Omit last arg SUFFIX; it was always 0. All callers changed.
396 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
397
398 * xfont.c (xfont_match): Avoid need for strlen.
399
400 * xfns.c: Don't assume strlen fits in int.
401 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
402
403 * xdisp.c (message_log_check_duplicate): Return intmax_t,
404 not unsigned long, as we prefer signed integers. All callers changed.
405 Detect integer overflow in repeat count.
406 (message_dolog): Don't assume print length fits in 39 bytes.
407 (display_mode_element): Don't assume strlen fits in int.
408
409 * termcap.c: Don't assume sizes fit in int and never overflow.
410 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
411 (gobble_line): Check for size-calculation overflow.
412
413 * minibuf.c (Fread_buffer):
414 * lread.c (intern, intern_c_string):
415 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
416 Don't assume string length fits in int.
417
418 * keyboard.c (parse_tool_bar_item):
419 * gtkutil.c (style_changed_cb): Avoid need for strlen.
420
421 * font.c: Don't assume string length fits in int.
422 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
423 Use ptrdiff_t, not int.
424 (font_intern_prop): Don't assume string length fits in int.
425 Don't assume integer property fits in fixnum.
426 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
427
428 * filelock.c: Fix some buffer overrun and integer overflow issues.
429 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
430 Reformulate so as not to need the command string.
431 Invoke gzip -cd rather than gunzip, as it's more portable.
432 (lock_info_type, lock_file_1, lock_file):
433 Don't assume pid_t and time_t fit in unsigned long.
434 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
435 (current_lock_owner): Prefer signed type for sizes.
436 Use memcpy, not strncpy, where memcpy is what is really wanted.
437 Don't assume (via atoi) that time_t and pid_t fit in int.
438 Check for time_t and/or pid_t out of range, e.g., via a network share.
439 Don't alloca where an auto var works fine.
440
441 * fileio.c: Fix some integer overflow issues.
442 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
443 Don't assume string length fits in int.
444 (directory_file_name): Don't assume string length fits in long.
445 (make_temp_name): Don't assume pid fits in int, or that its print
446 length is less than 20.
447
448 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
449
450 * coding.c (make_subsidiaries): Don't assume string length fits in int.
451
452 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
453
454 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
455 We prefer signed integers, even for size calculations.
456
457 * emacs.c: Don't assume string length fits in 'int'.
458 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
459 (main): Don't invoke strlen when not needed.
460
461 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
462 (XD_DEBUG_MESSAGE): Don't waste a byte.
463
464 * callproc.c (getenv_internal_1, getenv_internal)
465 (Fgetenv_internal):
466 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
467
468 * lread.c (invalid_syntax): Omit length argument.
469 All uses changed. This doesn't fix a bug, but it simplifies the
470 code away from its former Hollerith-constant appearance, and it's
471 one less 'int' to worry about when looking at integer-overflow issues.
472 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
473
474 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
475 This didn't break anything, but it didn't help either.
476 It's confusing to put a bogus integer in a place where the actual
477 value does not matter.
478 (LIST_END_P): Remove unused macro and its bogus comment.
479 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
480
481 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
482 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
483 implementation.
484 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
485 We prefer signed types, and the value cannot exceed the EMACS_INT
486 range anyway (because otherwise the length would not be representable).
487 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
488 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
489 This avoids a GCC warning when WIDE_EMACS_INT.
490
491 * indent.c (sane_tab_width): New function.
492 (current_column, scan_for_column, Findent_to, position_indentation)
493 (compute_motion): Use it. This is just for clarity.
494 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
495
496 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
497
498 * lisp.h (lint_assume): New macro.
499 * composite.c (composition_gstring_put_cache):
500 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
501
502 * editfns.c, insdel.c:
503 Omit unnecessary forward decls, to simplify future changes.
504
505 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
506
507 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
508
509 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
510 Use much-faster test for byte-length change.
511 Don't assume string byte-length fits in 'int'.
512 Check that character arg fits in 'int'.
513 (mapcar1): Declare byte as byte, for clarity.
514
515 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
516
517 * fns.c (concat): Catch string overflow earlier.
518 Do not rely on integer wraparound.
519
520 * dispextern.h (struct it.overlay_strings_charpos)
521 (struct it.selective): Now EMACS_INT, not int.
522 * xdisp.c (forward_to_next_line_start)
523 (back_to_previous_visible_line_start)
524 (reseat_at_next_visible_line_start, next_element_from_buffer):
525 Don't arbitrarily truncate the value of 'selective' to int.
526
527 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
528
529 * composite.c: Don't truncate sizes to 'int'.
530 (composition_gstring_p, composition_reseat_it)
531 (composition_adjust_point): Use EMACS_INT, not int.
532 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
533 not EMACS_UINT, for indexes.
534
535 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
536
537 * buffer.c: Include <verify.h>.
538 (struct sortvec.priority, struct sortstr.priority):
539 Now EMACS_INT, not int.
540 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
541 (struct sortstr.size, record_overlay_string)
542 (struct sortstrlist.size, struct sortlist.used):
543 Don't truncate size to int.
544 (record_overlay_string): Check for size-calculation overflow.
545 (init_buffer_once): Check at compile-time, not run-time.
546
547 2011-06-22 Jim Meyering <meyering@redhat.com>
548
549 Don't leak an XBM-image-sized buffer
550 * image.c (xbm_load): Free the image buffer after using it.
551
552 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
553
554 Port to Sun C.
555 * composite.c (find_automatic_composition): Omit needless 'return 0;'
556 that Sun C diagnosed.
557 * fns.c (secure_hash): Fix pointer signedness issue.
558 * intervals.c (static_offset_intervals): New function.
559 (offset_intervals): Use it.
560
561 2011-06-21 Leo Liu <sdl.web@gmail.com>
562
563 * deps.mk (fns.o):
564 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
565 sha512.h.
566
567 * fns.c (secure_hash): Rename from crypto_hash_function and change
568 the first arg to accept symbols.
569 (Fsecure_hash): New primitive.
570 (syms_of_fns): New symbols.
571
572 2011-06-20 Deniz Dogan <deniz@dogan.se>
573
574 * process.c (Fset_process_buffer): Clarify return value in
575 docstring.
576
577 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
578
579 * dispnew.c (add_window_display_history): Use BVAR.
580
581 * xdisp.c (debug_method_add): Use BVAR.
582 (check_window_end, dump_glyph_matrix, dump_glyph)
583 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
584
585 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
586 Likewise.
587
588 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
589 check till after the cache is created in init_frame_faces.
590
591 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
592
593 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
594
595 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
596
597 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
598 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
599 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
600
601 Improve buffer-overflow checking (Bug#8873).
602 * fileio.c (Finsert_file_contents):
603 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
604 Remove the old (too-loose) buffer overflow checks.
605 They weren't needed, since make_gap checks for buffer overflow.
606 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
607 The old code merely checked for Emacs fixnum overflow, and relied
608 on undefined (wraparound) behavior. The new code avoids undefined
609 behavior, and also checks for ptrdiff_t and/or size_t overflow.
610
611 * editfns.c (Finsert_char): Don't dump core with very negative counts.
612 Tune. Don't use wider integers than needed. Don't use alloca.
613 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
614
615 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
616
617 * insdel.c, lisp.h (buffer_overflow): New function.
618 (insert_from_buffer_1, replace_range, replace_range_2):
619 * insdel.c (make_gap_larger):
620 * editfns.c (Finsert_char):
621 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
622
623 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
624
625 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
626
627 Integer overflow and signedness fixes (Bug#8873).
628
629 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
630 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
631
632 * fileio.c: Don't assume EMACS_INT fits in off_t.
633 (emacs_lseek): New static function.
634 (Finsert_file_contents, Fwrite_region): Use it.
635 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
636
637 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
638
639 * fns.c: Don't overflow int when computing a list length.
640 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
641 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
642 truncation on 64-bit hosts. Check for QUIT every
643 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
644 faster and is responsive enough.
645 (Flength): Report an error instead of overflowing an integer.
646 (Fsafe_length): Return a float if the value is not representable
647 as a fixnum. This shouldn't happen except in contrived situations.
648 (Fnthcdr, Fsort): Don't assume list length fits in int.
649 (Fcopy_sequence): Don't assume vector length fits in int.
650
651 * alloc.c: Check that resized vectors' lengths fit in fixnums.
652 (header_size, word_size): New constants.
653 (allocate_vectorlike): Don't check size overflow here.
654 (allocate_vector): Check it here instead, since this is the only
655 caller of allocate_vectorlike that could cause overflow.
656 Check that the new vector's length is representable as a fixnum.
657
658 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
659 The previous code was bogus. For example, next_almost_prime (32)
660 returned 39, which is undesirable as it is a multiple of 3; and
661 next_almost_prime (24) returned 25, which is a multiple of 5 so
662 why was the code bothering to check for multiples of 7?
663
664 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
665
666 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
667
668 Variadic C functions now count arguments with ptrdiff_t.
669 This partly undoes my 2011-03-30 change, which replaced int with size_t.
670 Back then I didn't know that the Emacs coding style prefers signed int.
671 Also, in the meantime I found a few more instances where arguments
672 were being counted with int, which may truncate counts on 64-bit
673 machines, or EMACS_INT, which may be unnecessarily wide.
674 * lisp.h (struct Lisp_Subr.function.aMANY)
675 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
676 Arg counts are now ptrdiff_t, not size_t.
677 All variadic functions and their callers changed accordingly.
678 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
679 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
680 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
681 * callint.c (Fcall_interactively): Check arg count for overflow,
682 to avoid potential buffer overrun. Use signed char, not 'int',
683 for 'varies' array, so that we needn't bother to check its size
684 calculation for overflow.
685 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
686 * eval.c (apply_lambda):
687 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
688 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
689 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
690
691 * callint.c (Fcall_interactively): Don't use index var as event count.
692
693 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
694 * mem-limits.h (SIZE): Remove; no longer used.
695
696 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
697
698 Remove unnecessary casts.
699 * xterm.c (x_term_init):
700 * xfns.c (x_set_border_pixel):
701 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
702 These aren't needed now that we assume ANSI C.
703
704 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
705 It's more likely to cause problems (due to unsigned overflow)
706 than to cure them.
707
708 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
709
710 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
711
712 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
713
714 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
715
716 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
717
718 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
719
720 GLYPH_CODE_FACE returns EMACS_INT, not int.
721 * dispextern.h (merge_faces):
722 * xfaces.c (merge_faces):
723 * xdisp.c (get_next_display_element, next_element_from_display_vector):
724 Don't assume EMACS_INT fits in int.
725
726 * character.h (CHAR_VALID_P): Remove unused parameter.
727 * fontset.c, lisp.h, xdisp.c: All uses changed.
728
729 * editfns.c (Ftranslate_region_internal): Omit redundant test.
730
731 * fns.c (concat): Minor tuning based on overflow analysis.
732 This doesn't fix any bugs. Use int to hold character, instead
733 of constantly refetching from Emacs object. Use XFASTINT, not
734 XINT, for value known to be a character. Don't bother comparing
735 a single byte to 0400, as it's always less.
736
737 * floatfns.c (Fexpt):
738 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
739
740 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
741 for characters.
742
743 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
744
745 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
746 Without this fix, on a 64-bit host (aset S 0 4294967386) would
747 incorrectly succeed when S was a string, because 4294967386 was
748 truncated before it was used.
749
750 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
751 Otherwise, an out-of-range integer could cause undefined behavior
752 on a 64-bit host.
753
754 * composite.c: Use int, not EMACS_INT, for characters.
755 (fill_gstring_body, composition_compute_stop_pos): Use int, not
756 EMACS_INT, for values that are known to be in character range.
757 This doesn't fix any bugs but is the usual style inside Emacs and
758 may generate better code on 32-bit machines.
759
760 Make sure a 64-bit char is never passed to ENCODE_CHAR.
761 This is for reasons similar to the recent CHAR_STRING fix.
762 * charset.c (Fencode_char): Check that character arg is actually
763 a character. Pass an int to ENCODE_CHAR.
764 * charset.h (ENCODE_CHAR): Verify that the character argument is no
765 wider than 'int', as a compile-time check to prevent future regressions
766 in this area.
767
768 * character.c (char_string): Remove unnecessary casts.
769
770 Make sure a 64-bit char is never passed to CHAR_STRING.
771 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
772 by silently ignoring the top 32 bits, allowing some values
773 that were far too large to be valid characters.
774 * character.h: Include <verify.h>.
775 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
776 arguments are no wider than unsigned, as a compile-time check
777 to prevent future regressions in this area.
778 * data.c (Faset):
779 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
780 (Fsubst_char_in_region):
781 * fns.c (concat):
782 * xdisp.c (decode_mode_spec_coding):
783 Adjust to CHAR_STRING's new requirement.
784 * editfns.c (Finsert_char, Fsubst_char_in_region):
785 * fns.c (concat): Check that character args are actually
786 characters. Without this test, these functions did the wrong
787 thing with wildly out-of-range values on 64-bit hosts.
788
789 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
790 These casts should not be needed on 32-bit hosts, either.
791 * keyboard.c (read_char):
792 * lread.c (Fload): Remove casts to unsigned.
793
794 * lisp.h (UNSIGNED_CMP): New macro.
795 This fixes comparison bugs on 64-bit hosts.
796 (ASCII_CHAR_P): Use it.
797 * casefiddle.c (casify_object):
798 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
799 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
800 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
801 * dispextern.h (FACE_FROM_ID):
802 * keyboard.c (read_char): Use UNSIGNED_CMP.
803
804 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
805 not to EMACS_INT, to avoid GCC warning.
806
807 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
808
809 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
810 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
811 isn't needed on 32-bit machines.
812
813 * buffer.c (Fgenerate_new_buffer_name):
814 Use EMACS_INT for count, not int.
815 (advance_to_char_boundary): Return EMACS_INT, not int.
816
817 * data.c (Qcompiled_function): Now static.
818
819 * window.c (window_body_lines): Now static.
820
821 * image.c (gif_load): Rename local to avoid shadowing.
822
823 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
824 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
825 * alloc.c (make_save_value): Integer argument is now of type
826 ptrdiff_t, not int.
827 (mark_object): Use ptrdiff_t, not int.
828 * lisp.h (pD): New macro.
829 * print.c (print_object): Use it.
830
831 * alloc.c: Use EMACS_INT, not int, to count objects.
832 (total_conses, total_markers, total_symbols, total_vector_size)
833 (total_free_conses, total_free_markers, total_free_symbols)
834 (total_free_floats, total_floats, total_free_intervals)
835 (total_intervals, total_strings, total_free_strings):
836 Now EMACS_INT, not int. All uses changed.
837 (Fgarbage_collect): Compute overall total using a double, so that
838 integer overflow is less likely to be a problem. Check for overflow
839 when converting back to an integer.
840 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
841 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
842 These were 'int' variables that could overflow on 64-bit hosts;
843 they were never used, so remove them instead of repairing them.
844 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
845 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
846 Previously, this ceilinged at INT_MAX, but that doesn't work on
847 64-bit machines.
848 (allocate_pseudovector): Don't use EMACS_INT when int would do.
849
850 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
851 (allocate_vectorlike): Check for ptrdiff_t overflow.
852 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
853 when a (possibly-narrower) signed value would do just as well.
854 We prefer using signed arithmetic, to avoid comparison confusion.
855
856 * alloc.c: Catch some string size overflows that we were missing.
857 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
858 for convenience in STRING_BYTES_MAX.
859 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
860 The definition here is exact; the one in lisp.h was approximate.
861 (allocate_string_data): Check for string overflow. This catches
862 some instances we weren't catching before. Also, it catches
863 size_t overflow on (unusual) hosts where SIZE_MAX <= min
864 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
865 and ptrdiff_t and EMACS_INT are both 64 bits.
866
867 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
868 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
869 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
870
871 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
872
873 * alloc.c (Fmake_string): Check for out-of-range init.
874
875 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
876
877 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
878
879 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
880
881 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
882 xg_get_default_scrollbar_width.
883
884 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
885 (int_gtk_range_get_value): Move to the scroll bar part of the file.
886 (style_changed_cb): Call update_theme_scrollbar_width and call
887 x_set_scroll_bar_default_width and xg_frame_set_char_size for
888 all frames (Bug#8505).
889 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
890 Call gtk_window_set_resizable if HAVE_GTK3.
891 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
892 and height if HAVE_GTK3 (Bug#8505).
893 (scroll_bar_width_for_theme): New variable.
894 (update_theme_scrollbar_width): New function.
895 (xg_get_default_scrollbar_width): Move code to
896 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
897 (xg_initialize): Call update_theme_scrollbar_width.
898
899 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
900
901 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
902
903 2011-06-12 Martin Rudalics <rudalics@gmx.at>
904
905 * frame.c (make_frame): Call other_buffer_safely instead of
906 other_buffer.
907
908 * window.c (temp_output_buffer_show): Call display_buffer with
909 second argument Vtemp_buffer_show_specifiers and reset latter
910 immediately after the call.
911 (Vtemp_buffer_show_specifiers): New variable.
912 (auto_window_vscroll_p, next_screen_context_lines)
913 (Vscroll_preserve_screen_position): Remove leading asterisks from
914 doc-strings.
915
916 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
917
918 Fix minor problems found by GCC 4.6.0 static checking.
919 * buffer.c (Qclone_number): Remove for now, as it's unused.
920 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
921 (record_buffer): Remove unused local.
922 * frame.c (other_visible_frames, frame_buffer_list): Now static.
923 (set_frame_buffer_list): Remove; unused.
924 * frame.h (other_visible_frames): Remove decl.
925 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
926 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
927 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
928 if HAVE_GPM.
929 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
930 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
931 Define only if HAVE_GPM.
932 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
933 (update_hints_inhibit): Remove; never set. All uses removed.
934 * widgetprv.h (emacsFrameClassRec): Remove decl.
935 * window.c (delete_deletable_window): Now returns void, since it
936 wasn't returning anything.
937 (compare_window_configurations): Remove unused locals.
938 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
939 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
940 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
941 the same widths as pointers. This follows up on the 2011-05-06 patch.
942 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
943 * xterm.h: Likewise.
944 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
945
946 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
947
948 * makefile.w32-in: Update dependencies.
949 (LISP_H): Add lib/intprops.h.
950
951 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
952
953 * image.c (gif_load): Add animation frame delay to the metadata.
954 (syms_of_image): Use DEFSYM. New symbol `delay'.
955
956 2011-06-11 Martin Rudalics <rudalics@gmx.at>
957
958 * window.c (delete_deletable_window): Re-add.
959 (Fset_window_configuration): Rewrite to handle dead buffers and
960 consequently deletable windows.
961 (window_tree, Fwindow_tree): Remove. Supply functionality in
962 window.el.
963 (compare_window_configurations): Simplify code.
964
965 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
966
967 * image.c (imagemagick_load_image): Fix type mismatch.
968 (Fimagemagick_types): Likewise.
969
970 * window.h (replace_buffer_in_windows): Declare.
971
972 2011-06-11 Martin Rudalics <rudalics@gmx.at>
973
974 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
975 Qclone_number. Remove external declaration of Qdelete_window.
976 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
977 code.
978 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
979 Qbuffer_list_update_hook if allowed.
980 (Fother_buffer): Rewrite doc-string. Major rewrite for new
981 buffer list implementation.
982 (other_buffer_safely): New function.
983 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
984 calls to replace_buffer_in_windows and
985 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
986 if allowed.
987 (record_buffer): Inhibit quitting and rewrite using quittable
988 functions. Run Qbuffer_list_update_hook if allowed.
989 (Frecord_buffer, Funrecord_buffer): New functions.
990 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
991 switch-to-buffer to window.el.
992 (bury-buffer): Move to window.el.
993 (Vbuffer_list_update_hook): New variable.
994
995 * lisp.h (other_buffer_safely): Add prototype in buffer.c
996 section.
997
998 * window.h (resize_frame_windows): Move up in code.
999 (Fwindow_frame): Remove EXFUN.
1000 (replace_buffer_in_all_windows): Remove prototype.
1001 (replace_buffer_in_windows_safely): Add prototype.
1002
1003 * window.c: Declare Qdelete_window static again. Move down
1004 declaration of select_count.
1005 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1006 (Fother_window): Move to window.el.
1007 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1008 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1009 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1010 window.el.
1011 (replace_buffer_in_windows): Implement by calling
1012 Qreplace_buffer_in_windows.
1013 (replace_buffer_in_all_windows): Remove with some functionality
1014 moved into replace_buffer_in_windows_safely.
1015 (replace_buffer_in_windows_safely): New function.
1016 (select_window_norecord, select_frame_norecord): Move in front
1017 of run_window_configuration_change_hook. Remove now obsolete
1018 declarations.
1019 (Fset_window_buffer): Rewrite doc-string. Call
1020 Qrecord_window_buffer.
1021 (keys_of_window): Move binding for other-window to window.el.
1022
1023 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1024
1025 * dispextern.h (struct image): Replace data member, whose int_val
1026 and ptr_val fields were not used by anything, with a single
1027 lisp_val object.
1028
1029 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1030 (gif_clear_image, gif_load, imagemagick_load_image)
1031 (gs_clear_image, gs_load): Callers changed.
1032
1033 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * buffer.h: Include <time.h>, for time_t.
1036 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1037
1038 Fix minor problems found by static checking.
1039
1040 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1041
1042 Make identifiers static if they are not used in other modules.
1043 * data.c (Qcompiled_function, Qframe, Qvector):
1044 * image.c (QimageMagick, Qsvg):
1045 * minibuf.c (Qmetadata):
1046 * window.c (resize_window_check, resize_root_window): Now static.
1047 * window.h (resize_window_check, resize_root_window): Remove decls.
1048
1049 * window.c (window_deletion_count, delete_deletable_window):
1050 Remove; unused.
1051 (window_body_lines): Now static.
1052 (Fdelete_other_windows_internal): Mark vars as initialized.
1053 Make sure 'resize_failed' is initialized.
1054 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1055 (resize_window_apply): Remove unused local.
1056 * window.h (delete_deletable_window): Remove decl.
1057
1058 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1059 (imagemagick_load_image): Fix pointer signedness problem by changing
1060 last arg from unsigned char * to char *. All uses changed.
1061 Also, fix a local for similar reasons.
1062 Remove unused locals. Remove locals to avoid shadowing.
1063 (fn_rsvg_handle_free): Remove; unused.
1064 (svg_load, svg_load_image): Fix pointer signedness problem.
1065 (imagemagick_load_image): Don't use garbage pointer image_wand.
1066
1067 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1068
1069 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1070
1071 * image.c (gif_load): Fix omitted cast error introduced by
1072 2011-06-06 change.
1073
1074 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1075
1076 * window.h (resize_proportionally, orig_total_lines)
1077 (orig_top_line): Remove from window structure.
1078 (set_window_height, set_window_width, change_window_heights)
1079 (Fdelete_window): Remove prototypes.
1080 (resize_frame_windows): Remove duplicate declaration.
1081
1082 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1083
1084 * window.h (resize_frame_windows, resize_window_check)
1085 (delete_deletable_window, resize_root_window)
1086 (resize_frame_windows): Declare prototypes.
1087
1088 * window.c (resize_window_apply): Make definition be "static" to
1089 match the prototype.
1090
1091 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1092
1093 * window.c: Remove declarations of Qwindow_size_fixed,
1094 window_min_size_1, window_min_size_2, window_min_size,
1095 size_window, window_fixed_size_p, enlarge_window, delete_window.
1096 Remove static from declaration of Qdelete_window, it's
1097 temporarily needed by Fbury_buffer.
1098 (replace_window): Don't assign orig_top_line and
1099 orig_total_lines.
1100 (Fdelete_window, delete_window): Remove. Window deletion is
1101 handled by window.el.
1102 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1103 Fdelete_window calls with calls to Qdelete_window.
1104 (Fdelete_other_windows): Remove. Deleting other windows is
1105 handled by window.el.
1106 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1107 handled in window.el.
1108 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1109 Window minimum sizes are handled in window.el.
1110 (shrink_windows, size_window, set_window_height)
1111 (set_window_width, change_window_heights, window_height)
1112 (window_width, CURBEG, CURSIZE, enlarge_window)
1113 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1114 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1115 handled in window.el.
1116 (make_dummy_parent): Rename to make_parent_window and give it a
1117 second argument horflag.
1118 (make_window): Don't set resize_proportionally any more.
1119 (Fsplit_window): Remove. Windows are split in window.el.
1120 (save_restore_action, save_restore_orig_size)
1121 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1122 Resize mini windows in window.el.
1123 (grow_mini_window, shrink_mini_window): Implement by calling
1124 Qresize_root_window_vertically, resize_window_check and
1125 resize_window_apply.
1126 (saved_window, Fset_window_configuration, save_window_save): Do
1127 not handle orig_top_line, orig_total_lines, and
1128 resize_proportionally.
1129 (window_min_height, window_min_width): Move to window.el.
1130 (keys_of_window): Move bindings for delete-other-windows,
1131 split-window, delete-window and enlarge-window to window.el.
1132
1133 * buffer.c: Temporarily extern Qdelete_window.
1134 (Fbury_buffer): Temporarily call Qdelete_window instead of
1135 Fdelete_window (Fbury_buffer will move to window.el soon).
1136
1137 * frame.c (set_menu_bar_lines_1): Remove code handling
1138 orig_top_line and orig_total_lines.
1139
1140 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1141 set_window_height but set heights directly.
1142 (change_frame_size_1): Use resize_frame_windows.
1143
1144 * xdisp.c (init_xdisp): Don't use set_window_height but set
1145 heights directly.
1146
1147 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1148 resize_frame_windows instead of change_window_heights and run
1149 run_window_configuration_change_hook.
1150
1151 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1152 instead of change_window_heights and run
1153 run_window_configuration_change_hook.
1154
1155 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1156
1157 * window.c (replace_window): Rename second argument REPLACEMENT to
1158 NEW. New third argument SETFLAG. Rewrite.
1159 (delete_window, make_dummy_parent): Call replace_window with
1160 third argument 1.
1161 (window_list_1): Move down in code.
1162 (run_window_configuration_change_hook): Move set_buffer part
1163 before select_frame_norecord part in order to unwind correctly.
1164 Rename count1 to count.
1165 (recombine_windows, delete_deletable_window, resize_root_window)
1166 (Fdelete_other_windows_internal)
1167 (Frun_window_configuration_change_hook, make_parent_window)
1168 (resize_window_check, resize_window_apply, Fresize_window_apply)
1169 (resize_frame_windows, Fsplit_window_internal)
1170 (Fdelete_window_internal, Fresize_mini_window_internal): New
1171 functions.
1172 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1173
1174 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1175
1176 * window.h (window): Add some new members to window structure -
1177 normal_lines, normal_cols, new_total, new_normal, clone_number,
1178 splits, nest, prev_buffers, next_buffers.
1179 (WINDOW_TOTAL_SIZE): Move here from window.c.
1180 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1181
1182 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1183 Remove.
1184 (make_dummy_parent): Set new members of windows structure.
1185 (make_window): Move down in code. Handle new members of window
1186 structure.
1187 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1188 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1189 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1190 (Fset_window_prev_buffers, Fwindow_next_buffers)
1191 (Fset_window_next_buffers, Fset_window_clone_number): New
1192 functions.
1193 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1194 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1195 Doc-string fixes.
1196 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1197 Argument WINDOW can be now internal window too.
1198 (Fwindow_use_time): Move up in code.
1199 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1200 Rewrite doc-string.
1201 (Fset_window_configuration, saved_window)
1202 (Fcurrent_window_configuration, save_window_save): Handle new
1203 members of window structure.
1204 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1205 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1206 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1207 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1208 Qget_mru_window, Qresize_root_window,
1209 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1210 Qauto_buffer_name; staticpro them.
1211
1212 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1213
1214 * window.c (Fwindow_total_size, Fwindow_left_column)
1215 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1216 (Fwindow_list_1): New functions.
1217 (window_box_text_cols): Replace with window_body_cols.
1218 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1219 window_body_cols instead of window_box_text_cols.
1220 (delete_window, Fset_window_configuration): Call
1221 delete_all_subwindows with window as argument.
1222 (delete_all_subwindows): Take a window as argument and not a
1223 structure. Rewrite.
1224 (window_loop): Remove handling of GET_LRU_WINDOW and
1225 GET_LARGEST_WINDOW.
1226 (Fget_lru_window, Fget_largest_window): Move to window.el.
1227
1228 * window.h: Extern window_body_cols instead of
1229 window_box_text_cols. delete_all_subwindows now takes a
1230 Lisp_Object as argument.
1231
1232 * indent.c (compute_motion, Fcompute_motion): Use
1233 window_body_cols instead of window_box_text_cols.
1234
1235 * frame.c (delete_frame): Call delete_all_subwindows with root
1236 window as argument.
1237
1238 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1239
1240 * fns.c (Fputhash): Document return value.
1241
1242 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1243
1244 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1245
1246 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1247
1248 Cons<->int and similar integer overflow fixes (Bug#8794).
1249
1250 Check for overflow when converting integer to cons and back.
1251 * charset.c (Fdefine_charset_internal, Fdecode_char):
1252 Use cons_to_unsigned to catch overflow.
1253 (Fencode_char): Use INTEGER_TO_CONS.
1254 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1255 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1256 * data.c (long_to_cons, cons_to_long): Remove.
1257 (cons_to_unsigned, cons_to_signed): New functions.
1258 These signal an error for invalid or out-of-range values.
1259 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1260 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1261 * font.c (Ffont_variation_glyphs):
1262 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1263 * lisp.h: Include <intprops.h>.
1264 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1265 (cons_to_signed, cons_to_unsigned): New decls.
1266 (long_to_cons, cons_to_long): Remove decls.
1267 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1268 (Fprimitive_undo): Use CONS_TO_INTEGER.
1269 * xfns.c (Fx_window_property): Likewise.
1270 * xselect.c: Include <limits.h>.
1271 (x_own_selection, selection_data_to_lisp_data):
1272 Use INTEGER_TO_CONS.
1273 (x_handle_selection_request, x_handle_selection_clear)
1274 (x_get_foreign_selection, Fx_disown_selection_internal)
1275 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1276 (lisp_data_to_selection_data): Use cons_to_unsigned.
1277 (x_fill_property_data): Use cons_to_signed.
1278 Report values out of range.
1279
1280 Check for buffer and string overflow more precisely.
1281 * buffer.h (BUF_BYTES_MAX): New macro.
1282 * lisp.h (STRING_BYTES_MAX): New macro.
1283 * alloc.c (Fmake_string):
1284 * character.c (string_escape_byte8):
1285 * coding.c (coding_alloc_by_realloc):
1286 * doprnt.c (doprnt):
1287 * editfns.c (Fformat):
1288 * eval.c (verror):
1289 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1290 since they may not be the same number.
1291 * editfns.c (Finsert_char):
1292 * fileio.c (Finsert_file_contents):
1293 Likewise for BUF_BYTES_MAX.
1294
1295 * image.c: Use ptrdiff_t, not int, for sizes.
1296 (slurp_file): Switch from int to ptrdiff_t.
1297 All uses changed.
1298 (slurp_file): Check that file size fits in both size_t (for
1299 malloc) and ptrdiff_t (for sanity and safety).
1300
1301 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1302 if b->modtime has its maximal value.
1303
1304 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1305
1306 Don't assume time_t can fit into int.
1307 * buffer.h (struct buffer.modtime): Now time_t, not int.
1308 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1309 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1310
1311 Minor fixes for signed vs unsigned integers.
1312 * character.h (MAYBE_UNIFY_CHAR):
1313 * charset.c (maybe_unify_char):
1314 * keyboard.c (read_char, reorder_modifiers):
1315 XINT -> XFASTINT, since the integer must be nonnegative.
1316 * ftfont.c (ftfont_spec_pattern):
1317 * keymap.c (access_keymap, silly_event_symbol_error):
1318 XUINT -> XFASTINT, since the integer must be nonnegative.
1319 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1320 since it makes no difference and we prefer signed.
1321 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1322 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1323 nonnegative.
1324
1325 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1326
1327 * window.h (Fwindow_frame): Declare.
1328
1329 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1330
1331 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1332 (SPARE_MEMORY): Always define.
1333 (LARGE_REQUEST): Remove.
1334 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1335
1336 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1337
1338 * lisp.h: Move EXFUNS for Fframe_root_window,
1339 Fframe_first_window and Fset_frame_selected_window to window.h.
1340
1341 * window.h: Move EXFUNS for Fframe_root_window,
1342 Fframe_first_window and Fset_frame_selected_window here from
1343 lisp.h.
1344
1345 * frame.c (Fwindow_frame, Fframe_first_window)
1346 (Fframe_root_window, Fframe_selected_window)
1347 (Fset_frame_selected_window): Move to window.c.
1348 (Factive_minibuffer_window): Move to minibuf.c.
1349 (Fother_visible_frames_p): New function.
1350
1351 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1352
1353 * window.c (decode_window, decode_any_window): Move up in code.
1354 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1355 (inhibit_frame_unsplittable): Remove unused variable.
1356 (Fwindow_buffer): Move up and rewrite doc-string.
1357 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1358 (Fwindow_prev): New functions.
1359 (Fwindow_frame): Move here from frame.c. Accept any window as
1360 argument.
1361 (Fframe_root_window, Fframe_first_window)
1362 (Fframe_selected_window): Move here from frame.c. Accept frame
1363 or arbitrary window as argument. Update doc-strings.
1364 (Fminibuffer_window): Move up in code.
1365 (Fwindow_minibuffer_p): Move up in code and simplify.
1366 (Fset_frame_selected_window): Move here from frame.c.
1367 Marginal rewrite.
1368 (Fselected_window, select_window, Fselect_window): Move up in
1369 code. Minor doc-string fixes.
1370
1371 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1372
1373 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1374 Do not assume that spare memory exists; that assumption is valid
1375 only if SYSTEM_MALLOC.
1376 (LARGE_REQUEST): New macro, so that the issue of large requests
1377 is separated from the issue of spare memory.
1378
1379 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1380
1381 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1382 format. (Bug#8806)
1383
1384 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1385
1386 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1387 before statements.
1388
1389 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1390
1391 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1392
1393 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1394
1395 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1396 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1397
1398 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1399
1400 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1401
1402 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1403
1404 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1405 (x_clipboard_manager_save): Add return value.
1406 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1407 New error handlers.
1408 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1409 Obey Vx_select_enable_clipboard_manager. Catch errors in
1410 x_clipboard_manager_save (Bug#8779).
1411 (Vx_select_enable_clipboard_manager): New variable.
1412 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1413
1414 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1415
1416 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1417
1418 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1419
1420 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1421 in the current matrix if keep_current_p is non-zero.
1422
1423 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1424
1425 * bidi.c (bidi_level_of_next_char): Fix last change.
1426
1427 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1428
1429 Support bidi reordering of text covered by display properties.
1430
1431 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1432 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1433 (bidi_cache_search, bidi_cache_iterator_state)
1434 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1435 (bidi_level_of_next_char, bidi_move_to_visually_next):
1436 Support character positions inside a run of characters covered by a
1437 display string.
1438 (bidi_paragraph_init, bidi_resolve_explicit_1)
1439 (bidi_level_of_next_char): Call bidi_fetch_char and
1440 bidi_fetch_char_advance instead of FETCH_CHAR and
1441 FETCH_CHAR_ADVANCE.
1442 (bidi_init_it): Initialize new members.
1443 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1444 definitions.
1445 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1446 instead of using explicit *_CHAR codes.
1447 (bidi_resolve_explicit, bidi_resolve_weak):
1448 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1449 bidirectional text is supported only in multibyte buffers.
1450 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1451 it to initialize the frame_window_p member of struct bidi_it.
1452 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1453 (bidi_resolve_explicit, bidi_resolve_weak)
1454 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1455 bidi_it->nchars is non-positive.
1456 (bidi_level_of_next_char): Don't try to lookup the cache for the
1457 next/previous character if nothing is cached there yet, or if we
1458 were just reseat()'ed to a new position.
1459
1460 * xdisp.c (set_cursor_from_row): Set start and stop points
1461 according to the row's direction when priming the loop that looks
1462 for the glyph on which to display cursor.
1463 (single_display_spec_intangible_p): Function deleted.
1464 (display_prop_intangible_p): Reimplement to call
1465 handle_display_spec instead of single_display_spec_intangible_p.
1466 Accept 3 additional arguments needed by handle_display_spec.
1467 This fixes incorrect cursor motion across display property with complex
1468 values: lists, `(when COND...)' forms, etc.
1469 (single_display_spec_string_p): Support property values that are
1470 lists with the argument STRING its top-level element.
1471 (display_prop_string_p): Fix the condition for processing a
1472 property that is a list to be consistent with handle_display_spec.
1473 (handle_display_spec): New function, refactored from the
1474 last portion of handle_display_prop.
1475 (compute_display_string_pos): Accept additional argument
1476 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1477 value of a `display' property is a "replacing spec".
1478 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1479 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1480 the display property, but just return a value indicating whether
1481 the display property will replace the characters it covers.
1482 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1483 frame_window_p members of struct bidi_it.
1484 (compute_display_string_pos, compute_display_string_end):
1485 New functions.
1486 (push_it): Accept second argument POSITION, where pop_it should
1487 jump to continue iteration.
1488 (reseat_1): Initialize bidi_it.disp_pos.
1489
1490 * keyboard.c (adjust_point_for_property): Adjust the call to
1491 display_prop_intangible_p to its new signature.
1492
1493 * dispextern.h (struct bidi_it): New member frame_window_p.
1494 (bidi_init_it): Update prototypes.
1495 (display_prop_intangible_p): Update prototype.
1496 (compute_display_string_pos, compute_display_string_end):
1497 Declare prototypes.
1498 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1499 EMACS_INT.
1500
1501 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 Malloc failure behavior now depends on size of allocation.
1504 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1505 * lisp.h: Change signatures accordingly.
1506 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1507 All callers changed. (Bug#8762)
1508
1509 * gnutls.c: Use Emacs's memory allocators.
1510 Without this change, the gnutls library would invoke malloc etc.
1511 directly, which causes problems on non-SYNC_INPUT hosts, and which
1512 runs afoul of improving memory_full behavior. (Bug#8761)
1513 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1514 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1515 xfree instead of the default malloc, realloc, free.
1516 (Fgnutls_boot): No need to check for memory allocation failure,
1517 since xmalloc does that for us.
1518
1519 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1520 * category.c (hash_get_category_set):
1521 * ccl.c (ccl_driver):
1522 * charset.c (Fdefine_charset_internal):
1523 * charset.h (struct charset.hash_index):
1524 * composite.c (get_composition_id, gstring_lookup_cache)
1525 (composition_gstring_put_cache):
1526 * composite.h (struct composition.hash_index):
1527 * dispextern.h (struct image.hash):
1528 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1529 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1530 (hashfn_equal, hashfn_user_defined, make_hash_table)
1531 (maybe_resize_hash_table, hash_lookup, hash_put)
1532 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1533 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1534 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1535 * image.c (make_image, search_image_cache, lookup_image)
1536 (xpm_put_color_table_h):
1537 * lisp.h (struct Lisp_Hash_Table):
1538 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1539 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1540 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1541 * alloc.c (allocate_vectorlike):
1542 Check for overflow in vector size calculations.
1543 * ccl.c (ccl_driver):
1544 Check for overflow when converting EMACS_INT to int.
1545 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1546 need to be updated by these changes.
1547 * fns.c (make_hash_table, maybe_resize_hash_table):
1548 Check for integer overflow with large hash tables.
1549 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1550 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1551 (SXHASH_REDUCE): New macro.
1552 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1553 Use it instead of discarding useful hash info with large hash values.
1554 (sxhash_float): New function.
1555 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1556 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1557 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1558 Rewrite to use FIXNUM_BITS, as this simplifies things.
1559 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1560 Adjust signatures to match updated version of code.
1561 (consing_since_gc): Now EMACS_INT, since a single hash table can
1562 use more than INT_MAX bytes.
1563
1564 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1565
1566 Make it possible to build with GCC-4.6+ -O2 -flto.
1567
1568 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1569
1570 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1571
1572 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1573 Call minibuffer-inactive-mode.
1574
1575 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1576
1577 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1578 Update dependencies.
1579
1580 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1581
1582 * data.c (init_data): Remove code for UTS, this system is not
1583 supported anymore.
1584
1585 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1586
1587 Don't force ./temacs to start in terminal mode.
1588
1589 * frame.c (make_initial_frame): Initialize faces in all cases, not
1590 only when CANNOT_DUMP is defined.
1591 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1592
1593 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1594
1595 * dispnew.c (add_window_display_history): Use const for the string
1596 pointer. Remove declaration, not needed.
1597
1598 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 Use 'inline', not 'INLINE'.
1601 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1602 * alloc.c, fontset.c (INLINE): Remove.
1603 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1604 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1605 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1606 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1607 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1608
1609 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1610
1611 Make it possible to run ./temacs.
1612
1613 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1614 syms_of_callproc does the same thing. Remove test for
1615 "initialized", do it in the caller.
1616 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1617
1618 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1619
1620 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1621 (read_minibuf): Use get_minibuffer.
1622 (syms_of_minibuf): Use DEFSYM.
1623 (Qmetadata): New var.
1624 * data.c (Qbuffer): Don't make it static.
1625 (syms_of_data): Use DEFSYM.
1626
1627 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1628
1629 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1630 (CCL_CODE_MIN): New macro.
1631
1632 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1635
1636 * eval.c (Qdebug): Now static.
1637 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1638 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1639 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1640
1641 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1642
1643 * image.c: Various fixes to ImageMagick code comments.
1644 (Fimagemagick_types): Doc fix.
1645
1646 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1647
1648 Minor fixes prompted by GCC 4.6.0 warnings.
1649
1650 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1651
1652 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1653 (x_clipboard_manager_save_all): Move extern decl to ...
1654 * xterm.h: ... here, so that it can be checked for consistency.
1655
1656 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1657
1658 * xselect.c (x_clipboard_manager_save_frame)
1659 (x_clipboard_manager_save_all): New functions.
1660 (Fx_clipboard_manager_save): Lisp function deleted.
1661
1662 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1663 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1664
1665 * xterm.h: Update prototype.
1666
1667 2011-05-28 William Xu <william.xwl@gmail.com>
1668
1669 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1670 exiting (Bug#8239).
1671
1672 2011-05-28 Jim Meyering <meyering@redhat.com>
1673
1674 Avoid a sign-extension bug in crypto_hash_function.
1675 * fns.c (to_uchar): Define.
1676 (crypto_hash_function): Use it to convert some newly-signed
1677 variables to unsigned, to avoid sign-extension bugs. For example,
1678 without this change, (md5 "truc") would evaluate to
1679 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1680 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1681 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1682
1683 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 Integer overflow fixes.
1686
1687 * dbusbind.c: Serial number integer overflow fixes.
1688 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1689 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1690 to hold a serial number that is too large for a fixnum.
1691 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1692 Check for serial numbers out of range. Decode any serial number
1693 that was so large that it became a float. (Bug#8722)
1694
1695 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1696 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1697 Use XFASTINT rather than XUINT when numbers are nonnegative.
1698 (xd_append_arg, Fdbus_method_return_internal):
1699 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1700 arguments, check that Lisp number is nonnegative, rather than
1701 silently wrapping negative numbers around. (Bug#8722)
1702 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1703 (Bug#8722)
1704
1705 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1706
1707 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1708
1709 ccl: add integer overflow checks
1710 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1711 (IN_INT_RANGE): New macros.
1712 (ccl_driver): Use them to check for integer overflow when
1713 decoding a CCL program. Many of the new checks are whether XINT (x)
1714 fits in int; it doesn't always, on 64-bit hosts. The new version
1715 doesn't catch all possible integer overflows, but it's an
1716 improvement. (Bug#8719)
1717
1718 * alloc.c (make_event_array): Use XINT, not XUINT.
1719 There's no need for unsigned here.
1720
1721 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1722 This follows up to the 2011-05-06 change that substituted uintptr_t
1723 for EMACS_INT. This case wasn't caught back then.
1724
1725 Rework Fformat to avoid integer overflow issues.
1726 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1727 now (part of C89). Include <verify.h>.
1728 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1729 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1730 (Fformat): Avoid the prepass trying to compute sizes; it was only
1731 approximate and thus did not catch overflow reliably. Instead, walk
1732 through the format just once, formatting and computing sizes as we go,
1733 checking for integer overflow at every step, and allocating a larger
1734 buffer as needed. Keep track separately whether the format is
1735 multibyte. Keep only the most-recently calculated precision, rather
1736 than them all. Record whether each argument has been converted to
1737 string. Use EMACS_INT, not int, for byte and char and arg counts.
1738 Support field widths and precisions larger than INT_MAX. Avoid
1739 sprintf's undefined behavior with conversion specifications such as %#d
1740 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1741 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1742 formatting out-of-range floating point numbers with int
1743 formats. (Bug#8668)
1744
1745 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1746
1747 * data.c: Avoid integer truncation in expressions involving floats.
1748 * data.c: Include <intprops.h>.
1749 (arith_driver): When there's an integer overflow in an expression
1750 involving floating point, convert the integers to floating point
1751 so that the resulting value does not suffer from catastrophic
1752 integer truncation. For example, on a 64-bit host (* 4
1753 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1754 Do not rely on undefined behavior after integer overflow.
1755
1756 merge count_size_as_multibyte, parse_str_to_multibyte
1757 * character.c, character.h (count_size_as_multibyte):
1758 Rename from parse_str_to_multibyte; all uses changed.
1759 Check for integer overflow.
1760 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1761 since it's now a duplicate of the other. This is more of
1762 a character than a buffer op, so better that it's in character.c.
1763 * fns.c, print.c: Adjust to above changes.
1764
1765 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1766
1767 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1768
1769 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1770
1771 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1772 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1773 (x_clipboard_manager_save): Now static.
1774 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1775
1776 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1777 (crypto_hash_function): Now static.
1778 Fix pointer signedness problems. Avoid unnecessary initializations.
1779
1780 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1781
1782 * termhooks.h (Vselection_alist): Make it terminal-local.
1783
1784 * terminal.c (create_terminal): Initialize it.
1785
1786 * xselect.c: Support for clipboard managers.
1787 (Vselection_alist): Move to termhooks.h as terminal-local var.
1788 (LOCAL_SELECTION): New macro.
1789 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1790 (symbol_to_x_atom): Remove gratuitous arg.
1791 (x_handle_selection_request, lisp_data_to_selection_data)
1792 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1793 (x_own_selection, x_get_local_selection, x_convert_selection):
1794 New arg, specifying work frame. Use terminal-local Vselection_alist.
1795 (some_frame_on_display): Delete unused function.
1796 (Fx_own_selection_internal, Fx_get_selection_internal)
1797 (Fx_disown_selection_internal, Fx_selection_owner_p)
1798 (Fx_selection_exists_p): New optional frame arg.
1799 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1800 (x_handle_selection_clear): Don't treat other terminals with the
1801 same keyboard specially. Use the terminal-local Vselection_alist.
1802 (x_clear_frame_selections): Use Frun_hook_with_args.
1803
1804 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1805
1806 * xterm.h: Add support for those atoms.
1807
1808 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1809
1810 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1811 (converted_selections, conversion_fail_tag): New global variables.
1812 (x_selection_request_lisp_error): Free the above.
1813 (x_get_local_selection): Remove unnecessary code.
1814 (x_reply_selection_request): Args changed; handle arbitrary array
1815 of converted selections stored in converted_selections.
1816 Separate the XChangeProperty and SelectionNotify steps.
1817 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1818 (x_convert_selection): New function.
1819 (x_handle_selection_event): Simplify.
1820 (x_get_foreign_selection): Don't ignore incoming requests while
1821 waiting for an answer; this will fail when we implement
1822 SAVE_TARGETS, and seems unnecessary anyway.
1823 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1824 (Vx_sent_selection_functions): Doc fix.
1825
1826 2011-05-26 Leo Liu <sdl.web@gmail.com>
1827
1828 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1829
1830 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1831
1832 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1833
1834 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1835 for fringe update if it has periodic bitmap.
1836 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1837 and fringe_bitmap_periodic_p.
1838
1839 * fringe.c (get_fringe_bitmap_data): New function.
1840 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1841 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1842 row. Mark glyph row for fringe update if periodicity changed.
1843
1844 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1845 for fringe update unless it has periodic bitmap.
1846
1847 2011-05-25 Kenichi Handa <handa@m17n.org>
1848
1849 * xdisp.c (get_next_display_element): Set correct it->face_id for
1850 a static composition.
1851
1852 2011-05-24 Leo Liu <sdl.web@gmail.com>
1853
1854 * deps.mk (fns.o):
1855 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1856
1857 * fns.c (crypto_hash_function, Fsha1): New function.
1858 (Fmd5): Use crypto_hash_function.
1859 (syms_of_fns): Add Ssha1.
1860
1861 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 * gnutls.c: Remove unused macros.
1864 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1865 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1866 Remove macros that are defined and never used.
1867 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1868
1869 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1870
1871 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1872 (Fx_get_selection_internal): Minor cleanup.
1873 (Fx_own_selection_internal): Rename arguments for consistency with
1874 select.el.
1875
1876 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1877
1878 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1879
1880 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1881
1882 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1883
1884 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1885
1886 * dispnew.c (scrolling_window): Don't exclude the case that the
1887 last enabled row in the desired matrix touches the bottom boundary.
1888
1889 2011-05-21 Glenn Morris <rgm@gnu.org>
1890
1891 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1892 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1893 and add some more files.
1894
1895 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1896
1897 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1898 report_file_error introduced by the change from 2011-05-07.
1899
1900 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 * systime.h (Time): Define only if emacs is defined.
1903 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1904 where the include path doesn't have X11/X.h by default. See
1905 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1906
1907 2011-05-20 Kenichi Handa <handa@m17n.org>
1908
1909 * composite.c (find_automatic_composition): Fix previous change.
1910
1911 2011-05-20 Glenn Morris <rgm@gnu.org>
1912
1913 * lisp.mk: New file, split from Makefile.in.
1914 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1915 (shortlisp): Remove.
1916 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1917
1918 2011-05-19 Glenn Morris <rgm@gnu.org>
1919
1920 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1921 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1922 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1923 (lisp): Set the order to that of loadup.el.
1924 (shortlisp): Make it a copy of $lisp.
1925 (SOME_MACHINE_LISP): Remove.
1926 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1927 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1928
1929 2011-05-18 Kenichi Handa <handa@m17n.org>
1930
1931 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1932 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1933 (find_automatic_composition): Mostly rewrite for efficiency.
1934
1935 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1936
1937 * makefile.w32-in: Update dependencies.
1938
1939 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1940
1941 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1942 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1943
1944 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1945
1946 Fix some integer overflow issues, such as string length overflow.
1947
1948 * insdel.c (count_size_as_multibyte): Check for string overflow.
1949
1950 * character.c (lisp_string_width): Check for string overflow.
1951 Use EMACS_INT, not int, for string indexes and lengths; in
1952 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1953 the resulting string length overflows an EMACS_INT; instead,
1954 report a string overflow if no precision given. When checking for
1955 precision exhaustion, use a check that cannot possibly have
1956 integer overflow. (Bug#8675)
1957 * character.h (lisp_string_width): Adjust to new signature.
1958
1959 * alloc.c (string_overflow): New function.
1960 (Fmake_string): Use it. This doesn't change behavior, but saves
1961 a few bytes and will simplify future changes.
1962 * character.c (string_escape_byte8): Likewise.
1963 * lisp.h (string_overflow): New decl.
1964
1965 Fixups, following up to the user-interface timestamp change.
1966 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1967 for UI timestamps, instead of unsigned long.
1968 * msdos.c (mouse_get_pos): Likewise.
1969 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1970 * w32gui.h (Time): Define by including "systime.h" rather than by
1971 declaring it ourselves. (Bug#8664)
1972
1973 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1974 * image.c (clear_image_cache): Likewise.
1975
1976 * term.c (term_mouse_position): Don't assume time_t wraparound.
1977
1978 Be more systematic about user-interface timestamps.
1979 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1980 and sometimes 'EMACS_UINT', to represent these timestamps.
1981 This change causes it to use 'Time' uniformly, as that's what X uses.
1982 This makes the code easier to follow, and makes it easier to catch
1983 integer overflow bugs such as Bug#8664.
1984 * frame.c (Fmouse_position, Fmouse_pixel_position):
1985 Use Time, not unsigned long, for user-interface timestamps.
1986 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1987 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1988 * keyboard.h (last_event_timestamp): Likewise.
1989 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1990 * menu.h (xmenu_show): Likewise.
1991 * term.c (term_mouse_position): Likewise.
1992 * termhooks.h (struct input_event.timestamp): Likewise.
1993 (struct terminal.mouse_position_hook): Likewise.
1994 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1995 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1996 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1997 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1998 what it was before.
1999 * menu.h, termhooks.h: Include "systime.h", for Time.
2000
2001 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2002 Don't assume that the difference between two unsigned long values
2003 can fit into an integer. At this point, we know button_down_time
2004 <= event->timestamp, so the difference must be nonnegative, so
2005 there's no need to cast the result if double-click-time is
2006 nonnegative, as it should be; check that it's nonnegative, just in
2007 case. This bug is triggered when events are more than 2**31 ms
2008 apart (about 25 days). (Bug#8664)
2009
2010 * xselect.c (last_event_timestamp): Remove duplicate decl.
2011 (x_own_selection): Remove needless cast to unsigned long.
2012
2013 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2014 that always fit in int. Use a sentinel instead of a counter, to
2015 avoid a temp and to allay GCC's concerns about possible int overflow.
2016 * frame.h (struct frame): Use int for menu_bar_items_used
2017 instead of EMACS_INT, since it always fits in int.
2018
2019 * menu.c (grow_menu_items): Check for int overflow.
2020
2021 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2022
2023 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2024 Before, the code was not consistent. These values cannot exceed
2025 2**31 - 1 so there's no need to make them unsigned.
2026 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2027 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2028 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2029 as modifiers.
2030 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2031
2032 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2033 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2034 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2035 presumably because the widths might not match.
2036
2037 * window.c (size_window): Avoid needless test at loop start.
2038
2039 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2040
2041 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2042
2043 2011-05-12 Drew Adams <drew.adams@oracle.com>
2044
2045 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2046
2047 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2048
2049 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2050 `width' to `bar_area_x' and `bar_area_width', respectively.
2051 (x_scroll_run): Take account of fringe background extension.
2052
2053 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2054 Rename local vars `left' and `width' to `bar_area_x' and
2055 `bar_area_width', respectively.
2056 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2057 background extension.
2058
2059 2011-05-10 Jim Meyering <meyering@redhat.com>
2060
2061 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2062
2063 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2064
2065 * image.c (Finit_image_library): Return t for built-in image types,
2066 like pbm and xbm. (Bug#8640)
2067
2068 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2069
2070 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2071
2072 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2073
2074 * w32console.c (Fset_screen_color): Doc fix.
2075 (Fget_screen_color): New function.
2076 (syms_of_ntterm): Defsubr it.
2077
2078 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2079 unlink the temporary file if Fcall_process didn't create it in the
2080 first place.
2081 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2082 child process will be redirected to a file specified with `:file'.
2083 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2084 cue to call_process_cleanup not to close that handle.
2085
2086 2011-05-07 Ben Key <bkey76@gmail.com>
2087
2088 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2089 one of two shell specific rules, either bootstrap-temacs-CMD or
2090 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2091 to the previous implementation of the bootstrap-temacs rule.
2092 The bootstrap-temacs-CMD rule is similar to the previous
2093 implementation of the bootstrap-temacs rule except that it
2094 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2095 variable.
2096
2097 These changes, along with some changes to nt/configure.bat,
2098 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2099 earlier fix to add support for --cflags and --ldflags options
2100 that include quotes so that it works whether make uses cmd or
2101 sh as the shell.
2102
2103 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2104
2105 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2106 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2107 is a constant.
2108 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2109 a string. Handle both cases.
2110 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2111 (Fdbus_register_method): Use Qinvalid_function.
2112
2113 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2114
2115 * makefile.w32-in: Update dependencies.
2116 (LISP_H): Add inttypes.h and stdin.h.
2117 (PROCESS_H): Add unistd.h.
2118
2119 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2120
2121 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2122 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2123
2124 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2125
2126 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2127
2128 * term.c (vfatal): Remove stray call to va_end.
2129 It's not needed and the C Standard doesn't allow it here anyway.
2130
2131 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2132 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2133
2134 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2135 bytes.
2136
2137 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2138
2139 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2140
2141 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2142
2143 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2144
2145 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2146
2147 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2148 * charset.c (Fdefine_charset_internal): Don't initialize
2149 charset.code_space[15]. The value was garbage, on hosts with
2150 32-bit int (Bug#8600).
2151
2152 * lread.c (read_integer): Be more consistent with string-to-number.
2153 Use string_to_number to do the actual conversion; this avoids
2154 rounding errors and fixes some other screwups. Without this fix,
2155 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2156 (digit_to_number): Move earlier, for benefit of read_integer.
2157 Return -1 if the digit is out of range for the base, -2 if it is
2158 not a digit in any supported base. (Bug#8602)
2159
2160 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2161
2162 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2163 to match comment at start of function. This also removes a
2164 GCC warning about overflow in a 32+64-bit port.
2165
2166 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2167
2168 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2169 Reported by Stefan Monnier in
2170 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2171 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2172 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2173
2174 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2175 (EMACS_UINTPTR): Likewise, with uintptr_t.
2176
2177 * lisp.h: Prefer 64-bit EMACS_INT if available.
2178 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2179 on 32-bit hosts that have 64-bit int, so that they can access
2180 large files.
2181 However, temporarily disable this change unless the temporary
2182 symbol WIDE_EMACS_INT is defined.
2183
2184 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2185
2186 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2187 This removes an assumption that EMACS_INT and long are the same
2188 width as pointers. The assumption is true for Emacs porting targets
2189 now, but we want to make other targets possible.
2190 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2191 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2192 In the rest of the code, change types of integers that hold casted
2193 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2194 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2195 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2196 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2197 No need to cast type when ORing.
2198 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2199 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2200 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2201 assume EMACS_INT is the same width as char *.
2202 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2203 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2204 Remove no-longer-needed casts.
2205 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2206 (xg_tool_bar_help_callback, xg_make_tool_item):
2207 Use EMACS_INTPTR to hold an integer
2208 that will be cast to void *; this can avoid a GCC warning
2209 if EMACS_INT is not the same width as void *.
2210 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2211 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2212 (current_message_1, set_message_1):
2213 Use a local to convert to proper width without a cast.
2214 * xmenu.c (dialog_selection_callback): Likewise.
2215
2216 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2217 Also, don't assume VALBITS / RAND_BITS is less than 5,
2218 and don't rely on undefined behavior when shifting a 1 left into
2219 the sign bit.
2220 * lisp.h (get_random): Change signature to match.
2221
2222 * lread.c (hash_string): Use size_t, not int, for hash computation.
2223 Normally we prefer signed values; but hashing is special, because
2224 it's better to use unsigned division on hash table sizes so that
2225 the remainder is nonnegative. Also, size_t is the natural width
2226 for hashing into memory. The previous code used 'int', which doesn't
2227 retain enough info to hash well into very large tables.
2228 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2229
2230 * dbusbind.c: Don't possibly lose pointer info when converting.
2231 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2232 Use XPNTR rather than XHASH, so that the high-order bits of
2233 the pointer aren't lost when converting through void *.
2234
2235 * eval.c (Fautoload): Don't double-shift a pointer.
2236
2237 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2238
2239 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2240
2241 * gnutls.c (DEF_GNUTLS_FN):
2242 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2243
2244 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2245
2246 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2247 marker. (Bug#8610)
2248
2249 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2250
2251 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2252 New version that can reserve upto 2GB of heap space.
2253
2254 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2255
2256 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2257
2258 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2259
2260 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2261 `gnutls_certificate_set_x509_key_file'.
2262
2263 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2264
2265 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2266 Update dependencies.
2267
2268 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2269
2270 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2271 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2272 Remove unused parameter `fildes'.
2273 * process.c (read_process_output, send_process): Don't pass it.
2274
2275 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2276
2277 Fix previous change: the library cache is defined in w32.c.
2278 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2279 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2280
2281 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2282
2283 Implement dynamic loading of GnuTLS on Windows.
2284
2285 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2286 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2287 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2288 Declare.
2289
2290 * gnutls.c (Qgnutls_dll): Define.
2291 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2292 (gnutls_*): Declare function pointers.
2293 (init_gnutls_functions): New function to initialize function pointers.
2294 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2295 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2296 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2297 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2298 (emacs_gnutls_write, emacs_gnutls_read)
2299 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2300 (Fgnutls_available_p): New function.
2301 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2302 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2303 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2304
2305 * image.c: Include w32.h.
2306 (Vimage_type_cache): Delete.
2307 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2308 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2309 (w32_delayed_load): Move to w32.c.
2310
2311 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2312
2313 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2314 (w32_delayed_load): Move from image.c. When loading a library, record
2315 its filename in the :loaded-from property of the library id.
2316 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2317 Initialize and staticpro them.
2318 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2319
2320 * process.c: Include lisp.h before w32.h, not after.
2321 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2322 instead of gnutls_record_check_pending.
2323
2324 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2325
2326 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2327
2328 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2329 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2330 as passed in.
2331
2332 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2333
2334 * xterm.c (x_set_frame_alpha): Do not set property on anything
2335 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2336
2337 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2338
2339 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2340
2341 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2342
2343 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2344 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2345 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2346 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2347 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2348 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2349 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2350 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2351 (Qgnutls_bootprop_callbacks_verify): Make static.
2352
2353 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2354
2355 * callproc.c: Indentation fixup.
2356
2357 * sysdep.c (wait_for_termination_1): Make static.
2358 (wait_for_termination, interruptible_wait_for_termination):
2359 Move after wait_for_termination_1.
2360
2361 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2362
2363 * sysdep.c (interruptible_wait_for_termination): New function
2364 which is like wait_for_termination, but allows keyboard
2365 interruptions.
2366
2367 * callproc.c (Fcall_process): Add (:file "file") as an option for
2368 the STDOUT buffer.
2369 (Fcall_process_region): Ditto.
2370
2371 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2372
2373 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2374 rather than `XVECTOR (FOO)->size'.
2375
2376 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2377 inttypes.h, as a gnulib replacement is used if it not available in
2378 system headers.
2379
2380 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2381
2382 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2383 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2384 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2385
2386 * coding.c (coding_alloc_by_realloc): Error out if destination
2387 will grow beyond MOST_POSITIVE_FIXNUM.
2388 (decode_coding_emacs_mule): Abort if there isn't enough place in
2389 charbuf for the composition carryover bytes. Reserve an extra
2390 space for up to 2 characters produced in a loop.
2391 (decode_coding_iso_2022): Abort if there isn't enough place in
2392 charbuf for the composition carryover bytes.
2393
2394 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2395
2396 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2397 aborting when %lld or %lll format is passed.
2398 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2399 %llo or %llx format is passed. (Bug#8545)
2400
2401 * window.c (window_scroll_line_based): Use a marker instead of
2402 simple variables to record original value of point. (Bug#7952)
2403
2404 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2405 produced by %s or %c overflows available buffer space. (Bug#8545)
2406
2407 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2408
2409 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2410 (SIZE_MAX): Move defn after all includes, as they might #define it.
2411
2412 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2413
2414 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2415
2416 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2417
2418 * keyboard.c (Qdelayed_warnings_hook): Define.
2419 (command_loop_1): Run `delayed-warnings-hook'
2420 if Vdelayed_warnings_list is non-nil.
2421 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2422 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2423
2424 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2425
2426 * doprnt.c (doprnt): Don't return value smaller than the buffer
2427 size if the message was truncated. (Bug#8545).
2428
2429 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2430
2431 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2432 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2433
2434 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2437
2438 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2439
2440 * makefile.w32-in: Update dependencies.
2441
2442 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2443
2444 Improve `doprnt' and its usage. (Bug#8545)
2445 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2446 `format_end'. Remove support for %l as a conversion specifier.
2447 Don't use xrealloc. Improve diagnostics when the %l size modifier
2448 is used. Update the commentary.
2449
2450 * eval.c (verror): Simplify calculation of size_t.
2451
2452 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2453 messages.
2454
2455 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2456
2457 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2458 change.
2459
2460 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2463 This makes this file independent of the recent pseudovector change.
2464
2465 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2466
2467 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2468
2469 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2470 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2471 Remove unused local.
2472 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2473
2474 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2475 GCC 4.6.0 optimizes based on type-based alias analysis.
2476 For example, if b is of type struct buffer * and v of type struct
2477 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2478 != &v->size, and therefore "v->size = 1; b->size = 2; return
2479 v->size;" must therefore return 1. This assumption is incorrect
2480 for Emacs, since it type-puns struct Lisp_Vector * with many other
2481 types. To fix this problem, this patch adds a new type struct
2482 vectorlike_header that documents the constraints on layout of vectors
2483 and pseudovectors, and helps optimizing compilers not get fooled
2484 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2485 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2486 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2487 the size member.
2488 (XSETPVECTYPE): Rewrite in terms of new macro.
2489 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2490 This is a bit clearer, and further avoids the possibility of
2491 undesirable aliasing.
2492 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2493 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2494 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2495 since Lisp_Subr is a special case (no "next" field).
2496 (ASIZE): Now uses header.size rather than size.
2497 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2498 to avoid the hassle of writing XVECTOR (foo)->header.size.
2499 (struct vectorlike_header): New type.
2500 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2501 object, to help avoid aliasing.
2502 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2503 (SUBRP): Likewise, since Lisp_Subr is a special case.
2504 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2505 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2506 (struct Lisp_Hash_Table): Combine first two members into a single
2507 struct vectorlike_header member. All uses of "size" and "next" members
2508 changed to be "header.size" and "header.next".
2509 * buffer.h (struct buffer): Likewise.
2510 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2511 * frame.h (struct frame): Likewise.
2512 * process.h (struct Lisp_Process): Likewise.
2513 * termhooks.h (struct terminal): Likewise.
2514 * window.c (struct save_window_data, struct saved_window): Likewise.
2515 * window.h (struct window): Likewise.
2516 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2517 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2518 * buffer.c (init_buffer_once): Likewise.
2519 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2520 special case.
2521 * process.c (Fformat_network_address): Use local var for size,
2522 for brevity.
2523
2524 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2525
2526 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2527 * data.c (atof): Remove decl; no longer used or needed.
2528 (digit_to_number): Move to lread.c.
2529 (Fstring_to_number): Use new string_to_number function, to be
2530 consistent with how the Lisp reader treats infinities and NaNs.
2531 Do not assume that floating-point numbers represent EMACS_INT
2532 without losing information; this is not true on most 64-bit hosts.
2533 Avoid double-rounding errors, by insisting on integers when
2534 parsing non-base-10 numbers, as the documentation specifies.
2535 * lisp.h (string_to_number): New decl, replacing ...
2536 (isfloat_string): Remove.
2537 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2538 (read1): Do not accept +. and -. as integers; this
2539 appears to have been a coding error. Similarly, do not accept
2540 strings like +-1e0 as floating point numbers. Do not report
2541 overflow for integer overflows unless the base is not 10 which
2542 means we have no simple and reliable way to continue.
2543 Break out the floating-point parsing into a new
2544 function string_to_number, so that Fstring_to_number parses
2545 floating point numbers consistently with the Lisp reader.
2546 (digit_to_number): Move here from data.c. Make it static inline.
2547 (E_CHAR, EXP_INT): Remove, replacing with ...
2548 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2549 (string_to_number): New function, replacing isfloat_string.
2550 This function checks for valid syntax and produces the resulting
2551 Lisp float number too. Rework it so that string-to-number
2552 no longer mishandles examples like "1.0e+". Use strtoumax,
2553 so that overflow for non-base-10 numbers is reported only when
2554 there's no portable and simple way to convert to floating point.
2555
2556 * textprop.c (set_text_properties_1): Rewrite for clarity,
2557 and to avoid GCC warning about integer overflow.
2558
2559 * intervals.h (struct interval): Use EMACS_INT for members
2560 where EMACS_UINT might cause problems. See
2561 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2562 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2563 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2564 All uses changed.
2565 (offset_intervals): Tell GCC not to worry about length overflow
2566 when negating a negative length.
2567
2568 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2569 (overrun_check_free): Likewise.
2570
2571 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2572 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2573 word size.
2574
2575 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2576 (gnutls_make_error): Rename local to avoid shadowing.
2577 (gnutls_emacs_global_deinit): ifdef out; not used.
2578 (Fgnutls_boot): Use const for pointer to readonly storage.
2579 Comment out unused local. Fix pointer signedness problems.
2580
2581 * lread.c (openp): Don't stuff size_t into an 'int'.
2582 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2583 about possible signed overflow.
2584
2585 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2586 (GDK_KEY_g): Don't define if already defined.
2587 (xg_prepare_tooltip): Avoid pointer signedness problem.
2588 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2589
2590 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2591 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2592
2593 * xfns.c (Fx_window_property): Simplify a bit,
2594 to make a bit faster and to avoid GCC 4.6.0 warning.
2595 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2596
2597 * fns.c (internal_equal): Don't assume size_t fits in int.
2598
2599 * alloc.c (compact_small_strings): Tighten assertion a little.
2600
2601 Replace pEd with more-general pI, and fix some printf arg casts.
2602 * lisp.h (pI): New macro, generalizing old pEd macro to other
2603 conversion specifiers. For example, use "...%"pI"d..." rather
2604 than "...%"pEd"...".
2605 (pEd): Remove. All uses replaced with similar uses of pI.
2606 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2607 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2608 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2609 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2610 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2611 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2612 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2613 64-bit hosts.
2614 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2615 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2616 * print.c (safe_debug_print, print_object): Likewise.
2617 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2618 to int.
2619 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2620 avoiding the 0 flag, which is not portable.
2621 * process.c (Fmake_network_process): Use pI to avoid cast.
2622 * region-cache.c (pp_cache): Likewise.
2623 * xdisp.c (decode_mode_spec): Likewise.
2624 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2625 behavior on 64-bit hosts with printf arg.
2626 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2627 (x_stop_queuing_selection_requests): Likewise.
2628 (x_get_window_property): Don't truncate byte count to an 'int'
2629 when tracing.
2630
2631 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2632 here, since it parses constructs like leading '-' and spaces,
2633 which are not wanted; and it overflows with large numbers.
2634 Instead, simply match F[0-9]+, which is what is wanted anyway.
2635
2636 * alloc.c: Remove unportable assumptions about struct layout.
2637 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2638 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2639 (allocate_vectorlike, make_pure_vector): Use the new macros,
2640 plus offsetof, to remove unportable assumptions about struct layout.
2641 These assumptions hold on all porting targets that I know of, but
2642 they are not guaranteed, they're easy to remove, and removing them
2643 makes further changes easier.
2644
2645 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2646 This doesn't fix a bug but makes the code clearer.
2647 (string_overrun_cookie): Now const. Use initializers that
2648 don't formally overflow signed char, to avoid warnings.
2649 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2650 can cause Emacs to crash when string overrun checking is enabled.
2651 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2652 multiple of sizeof (EMACS_INT); it need not be, if
2653 alignof(EMACS_INT) < sizeof (EMACS_INT).
2654 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2655
2656 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2657
2658 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2659
2660 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2661
2662 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2663 supposed to be handshaking. (Bug#8556)
2664 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2665
2666 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2667
2668 * lisp.h (Qdebug): List symbol.
2669 * eval.c (Qdebug): Restore global linkage.
2670 * keyboard.c (debug-on-event): New variable.
2671 (handle_user_signal): Break into debugger when debug-on-event
2672 matches the current signal symbol.
2673
2674 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2675
2676 * alloc.c (check_sblock, check_string_bytes)
2677 (check_string_free_list): Convert to standard C.
2678
2679 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2680
2681 * w32.c (emacs_gnutls_push): Fix typo.
2682
2683 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2684
2685 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2686 "cast to pointer from integer of different size".
2687
2688 Improve doprnt and its use in verror. (Bug#8545)
2689 * doprnt.c (doprnt): Document the set of format control sequences
2690 supported by the function. Use SAFE_ALLOCA instead of always
2691 using `alloca'.
2692
2693 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2694 is one byte too soon. Don't use xrealloc; instead xfree and
2695 xmalloc anew.
2696
2697 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2698
2699 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2700 callbacks stage.
2701
2702 * gnutls.c: Renamed global_initialized to
2703 gnutls_global_initialized. Added internals for the
2704 :verify-hostname-error, :verify-error, and :verify-flags
2705 parameters of `gnutls-boot' and documented those parameters in the
2706 docstring. Start callback support.
2707 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2708 unless a fatal error occured. Call gnutls_alert_send_appropriate
2709 on error. Return error code.
2710 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2711 (emacs_gnutls_read): Likewise.
2712 (Fgnutls_boot): Return handshake error code.
2713 (emacs_gnutls_handle_error): New function.
2714 (wsaerror_to_errno): Likewise.
2715
2716 * w32.h (emacs_gnutls_pull): Add prototype.
2717 (emacs_gnutls_push): Likewise.
2718
2719 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2720 (emacs_gnutls_push): Likewise.
2721
2722 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2723
2724 * process.c (wait_reading_process_output): Check if GnuTLS
2725 buffered some data internally if no FDs are set for TLS
2726 connections.
2727
2728 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2729 (LIBS): Link to USER_LIBS.
2730 ($(BLD)/gnutls.$(0)): New target.
2731
2732 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2733
2734 * xdisp.c (handle_single_display_spec): Rename the
2735 display_replaced_before_p argument into display_replaced_p, to
2736 make it consistent with the commentary. Fix typos in the
2737 commentary.
2738
2739 * textprop.c (syms_of_textprop): Remove dead code.
2740 (copy_text_properties): Delete obsolete commentary about an
2741 interface that was deleted long ago. Fix typos in the description
2742 of arguments.
2743
2744 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2745 to changes in oldXMenu/XMenu.h from 2011-04-16.
2746 <menu_help_message, prev_menu_help_message>: Constify.
2747 (IT_menu_make_room): menu->help_text is now `const char **';
2748 adjust.
2749
2750 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2751 to changes in oldXMenu/XMenu.h from 2011-04-16.
2752 (struct XMenu): Declare `help_text' `const char **'.
2753
2754 * xfaces.c <Qunspecified>: Make extern again.
2755
2756 * syntax.c: Include sys/types.h before including regex.h, as
2757 required by Posix.
2758
2759 * doc.c (get_doc_string): Improve the format passed to `error'.
2760
2761 * doprnt.c (doprnt): Improve commentary.
2762
2763 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2764
2765 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2766 them with etags.
2767
2768 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2769 changes in globals.h immediately force recompilation.
2770 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2771 $(CURDIR)/s/ms-w32.h.
2772 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2773
2774 * character.c (Fchar_direction): Function deleted.
2775 (syms_of_character): Don't defsubr it.
2776 <char-direction-table>: Deleted.
2777
2778 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2779
2780 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2781 * doprnt.c: Include limits.h.
2782 (SIZE_MAX): New macro.
2783 (doprnt): Return a size_t value. 2nd arg is now size_t.
2784 Many local variables are now size_t instead of int or unsigned.
2785 Improve overflow protection. Support `l' modifier for integer
2786 conversions. Support %l conversion. Don't assume an EMACS_INT
2787 argument for integer conversions and for %c.
2788
2789 * lisp.h (doprnt): Restore prototype.
2790
2791 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2792 $(SRC)/character.h.
2793
2794 * Makefile.in (base_obj): Add back doprnt.o.
2795
2796 * deps.mk (doprnt.o): Add back prerequisites.
2797 (callint.o): Depend on character.h.
2798
2799 * eval.c (internal_lisp_condition_case): Include the handler
2800 representation in the error message.
2801 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2802 when breaking from the loop.
2803
2804 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2805
2806 * callint.c (Fcall_interactively): When displaying error message
2807 about invalid control letter, pass the character's codepoint, not
2808 a pointer to its multibyte form. Improve display of the character
2809 in octal and display also its hex code.
2810
2811 * character.c (char_string): Use %x to display the (unsigned)
2812 codepoint of an invalid character, to avoid displaying a bogus
2813 negative value.
2814
2815 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2816 `error', not SYMBOL_NAME itself.
2817
2818 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2819 character arguments to `error'.
2820
2821 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2822 to `error' in error message about FINAL_CHAR argument. Make sure
2823 FINAL_CHAR is a character, and use %c when it is passed as
2824 argument to `error'.
2825
2826 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2827
2828 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2829
2830 * w32.c: Include <time.h>.
2831 (sys_localtime): New function.
2832
2833 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2834
2835 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2836
2837 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2838
2839 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2840
2841 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2842 zombies (Bug#8467).
2843
2844 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2845
2846 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2847 gl_state.e_property when gl_state.object is Qt.
2848
2849 * insdel.c (make_gap_larger): Remove limitation of buffer size
2850 to <= INT_MAX.
2851
2852 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2853
2854 * xdisp.c (lookup_glyphless_char_display)
2855 (produce_glyphless_glyph): Handle cons cell entry in
2856 glyphless-char-display.
2857 (Vglyphless_char_display): Document it.
2858
2859 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2860 glyphless-char-display.
2861
2862 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2863
2864 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2865
2866 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2867
2868 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2869 definition for no-X builds.
2870
2871 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 Static checks with GCC 4.6.0 and non-default toolkits.
2874
2875 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2876
2877 * process.c (keyboard_bit_set): Define only if SIGIO.
2878 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2879 (send_process): Repair possible setjmp clobbering.
2880
2881 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2882
2883 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2884
2885 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2886
2887 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2888 Define only if needed.
2889
2890 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2891 by pacifying GCC about it. Maybe it's time to retire it?
2892 * xfaces.c (USG, __TIMEVAL__): Likewise.
2893
2894 * dispextern.h (struct redisplay_interface): Rename param
2895 to avoid shadowing.
2896 * termhooks.h (struct terminal): Likewise.
2897 * xterm.c (xembed_send_message): Likewise.
2898
2899 * insdel.c (make_gap_smaller): Define only if
2900 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2901
2902 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2903 it.
2904
2905 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2906 so that we aren't warned about unused symbols.
2907
2908 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2909
2910 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2911
2912 * xfns.c (x_real_positions): Mark locals as initialized.
2913
2914 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2915
2916 * xterm.c: Fix problems found by static analysis with other toolkits.
2917 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2918 (x_dispatch_event): Declare static if USE_GTK, and
2919 define if USE_GTK || USE_X_TOOLKIT.
2920 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2921 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2922 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2923 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2924
2925 * xmenu.c (menu_help_callback): Pointer type fixes.
2926 Use const pointers when pointing at readonly data. Avoid pointer
2927 signedness clashes.
2928 (FALSE): Remove unused macro.
2929 (update_frame_menubar): Remove unused decl.
2930
2931 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2932
2933 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2934 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2935 (single_menu_item): Rename local to avoid shadowing.
2936
2937 * keyboard.c (make_lispy_event): Remove unused local var.
2938
2939 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2940 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2941
2942 * bitmaps: Change bitmaps from unsigned char back to the X11
2943 compatible char. Avoid the old compiler warnings about
2944 out-of-range initializers by using, for example, '\xab' rather
2945 than 0xab.
2946
2947 * xgselect.c (xgselect_initialize): Check vs interface
2948 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2949
2950 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2951
2952 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2953 to read-only memory.
2954
2955 * fns.c (vector): Remove; this old hack is no longer needed.
2956
2957 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2958 Remove unused var.
2959 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2960
2961 * xrdb.c (x_load_resources): Omit unused local.
2962
2963 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2964 (x_window): Rename locals to avoid shadowing.
2965 (USG): Use the kludged USG macro, to pacify gcc.
2966
2967 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2968 (x_term_init): Remove local to avoid shadowing.
2969
2970 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2971
2972 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2973 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2974
2975 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2976
2977 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2978
2979 Fix regex.c, syntax.c and friends for buffers > 2GB.
2980 * syntax.h (struct gl_state_s): Declare character position members
2981 EMACS_INT.
2982
2983 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2984
2985 * textprop.c (verify_interval_modification, interval_of):
2986 Declare arguments EMACS_INT.
2987
2988 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2989 EMACS_INT.
2990
2991 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2992
2993 * indent.c (Fvertical_motion): Local variable it_start is now
2994 EMACS_INT.
2995
2996 * regex.c (re_match, re_match_2, re_match_2_internal)
2997 (bcmp_translate, regcomp, regexec, print_double_string)
2998 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2999 (re_compile_pattern, re_exec): Declare arguments and local
3000 variables `size_t' and `ssize_t' and return values `regoff_t', as
3001 appropriate.
3002 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3003 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3004 <compile_stack_type>: `size' and `avail' are now `size_t'.
3005
3006 * regex.h <regoff_t>: Use ssize_t, not int.
3007 (re_search, re_search_2, re_match, re_match_2): Arguments that
3008 specify buffer/string position and length are now ssize_t and
3009 size_t. Return type is regoff_t.
3010
3011 2011-04-16 Ben Key <bkey76@gmail.com>
3012
3013 * nsfont.m: Fixed bugs in ns_get_family and
3014 ns_descriptor_to_entity that were caused by using free to
3015 deallocate memory blocks that were allocated by xmalloc (via
3016 xstrdup). This caused Emacs to crash when compiled with
3017 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3018 --enable-checking=xmallocoverrun). xfree is now used to
3019 deallocate these memory blocks.
3020
3021 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3022
3023 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3024
3025 emacs_write: Accept and return EMACS_INT for sizes.
3026 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3027 et seq.
3028 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3029 Accept and return EMACS_INT.
3030 (emacs_gnutls_write): Return the number of bytes written on
3031 partial writes.
3032 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3033 (emacs_read, emacs_write): Remove check for negative size, as the
3034 Emacs source code has been audited now.
3035 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3036 (emacs_read, emacs_write): Use it.
3037 * process.c (send_process): Adjust to the new signatures of
3038 emacs_write and emacs_gnutls_write. Do not attempt to store
3039 a byte offset into an 'int'; it might overflow.
3040 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3041
3042 * sound.c: Don't assume sizes fit in 'int'.
3043 (struct sound_device.period_size, alsa_period_size):
3044 Return EMACS_INT, not int.
3045 (struct sound_device.write, vox_write, alsa_write):
3046 Accept EMACS_INT, not int.
3047 (wav_play, au_play): Use EMACS_INT to store sizes and to
3048 record read return values.
3049
3050 2011-04-15 Ben Key <bkey76@gmail.com>
3051
3052 * keyboard.c (Qundefined): Don't declare static since it is used
3053 in nsfns.m.
3054 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3055 static since they are used in nsfont.m.
3056
3057 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3058
3059 * process.c (Qprocessp): Don't declare static.
3060 * lisp.h (Qprocessp): Declare again.
3061
3062 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3063
3064 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3065
3066 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 Improve C-level modularity by making more things 'static'.
3069
3070 Don't publish debugger-only interfaces to other modules.
3071 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3072 (verify_bytepos, count_markers): Move decls to the only modules
3073 that need them.
3074 * region-cache.h (pp_cache): Likewise.
3075 * window.h (check_all_windows): Likewise.
3076 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3077
3078 * sysdep.c (croak): Now static, if
3079 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3080 * syssignal.h (croak): Declare only if not static.
3081
3082 * alloc.c (refill_memory_reserve): Now static if
3083 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3084 * lisp.h (refill_memory_reserve): Declare only if not static.
3085
3086 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3087 Define only if USE_LUCID.
3088
3089 * xrdb.c (x_customization_string, x_rm_string): Now static.
3090
3091 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3092 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3093
3094 * xdisp.c (draw_row_with_mouse_face): Now static.
3095 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3096
3097 * window.h (check_all_windows): Mark externally visible.
3098
3099 * window.c (window_deletion_count): Now static.
3100
3101 * undo.c: Make symbols static if they're not exported.
3102 (last_undo_buffer, last_boundary_position, pending_boundary):
3103 Now static.
3104
3105 * textprop.c (interval_insert_behind_hooks): Now static.
3106 (interval_insert_in_front_hooks): Likewise.
3107
3108 * term.c: Make symbols static if they're not exported.
3109 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3110 (max_frame_lines, tty_set_terminal_modes):
3111 (tty_reset_terminal_modes, tty_turn_off_highlight):
3112 (get_tty_terminal): Now static.
3113 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3114 * termhooks.h (term_mouse_moveto): Do not declare if
3115 HAVE_WINDOW_SYSTEM.
3116 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3117 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3118
3119 * sysdep.c: Make symbols static if they're not exported.
3120 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3121 Now static.
3122 (sigprocmask_set, full_mask): Remove; unused.
3123 (wait_debugging): Mark as visible.
3124 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3125 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3126
3127 * syntax.c (syntax_temp): Define only if !__GNUC__.
3128
3129 * sound.c (current_sound_device, current_sound): Now static.
3130
3131 * search.c (searchbufs, searchbuf_head): Now static.
3132
3133 * scroll.c (scroll_cost): Remove; unused.
3134 * dispextern.h (scroll_cost): Remove decl.
3135
3136 * region-cache.h (pp_cache): Mark as externally visible.
3137
3138 * process.c: Make symbols static if they're not exported.
3139 (process_tick, update_tick, create_process, chan_process):
3140 (Vprocess_alist, proc_buffered_char, datagram_access):
3141 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3142 (deactivate_process): Mark defn as static, as well as decl.
3143 * lisp.h (create_process): Remove decl.
3144 * process.h (chan_process, Vprocess_alist): Remove decls.
3145
3146 * print.c: Make symbols static if they're not exported.
3147 (print_depth, new_backquote_output, being_printed, print_buffer):
3148 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3149 (print_interval, print_number_index, initial_stderr_stream):
3150 Now static.
3151 * lisp.h (Fprinc): Remove decl.
3152 (debug_output_compilation_hack): Mark as externally visible.
3153
3154 * sysdep.c (croak): Move decl from here to syssignal.h.
3155 * syssignal.h (croak): Put it here, so the API can be checked when
3156 'croak' is called from dissociate_if_controlling_tty.
3157
3158 * minibuf.c: Make symbols static if they're not exported.
3159 (minibuf_save_list, choose_minibuf_frame): Now static.
3160 * lisp.h (choose_minibuf_frame): Remove decl.
3161
3162 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3163
3164 * lread.c: Make symbols static if they're not exported.
3165 (read_objects, initial_obarray, oblookup_last_bucket_number):
3166 Now static.
3167 (make_symbol): Remove; unused.
3168 * lisp.h (initial_obarray, make_symbol): Remove decls.
3169
3170 * keyboard.c: Make symbols static if they're not exported.
3171 (single_kboard, recent_keys_index, total_keys, recent_keys):
3172 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3173 (this_single_command_key_start, echoing, last_auto_save):
3174 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3175 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3176 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3177 (Vlispy_mouse_stem, double_click_count):
3178 Now static.
3179 (force_auto_save_soon): Define only if SIGDANGER.
3180 (ignore_mouse_drag_p): Now static if
3181 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3182 (print_help): Remove; unused.
3183 (stop_character, last_timer_event): Mark as externally visible.
3184 * keyboard.h (ignore_mouse_drag_p): Declare only if
3185 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3186 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3187 * lisp.h (echoing): Remove decl.
3188 (force_auto_save_soon): Declare only if SIGDANGER.
3189 * xdisp.c (redisplay_window): Simplify code, to make it more
3190 obvious that ignore_mouse_drag_p is not accessed if !defined
3191 USE_GTK && !defined HAVE_NS.
3192
3193 * intervals.c: Make symbols static if they're not exported.
3194 (merge_properties_sticky, merge_interval_right, delete_interval):
3195 Now static.
3196 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3197
3198 * insdel.c: Make symbols static if they're not exported.
3199 However, leave prepare_to_modify_buffer alone. It's never
3200 called from outside this function, but that appears to be a bug.
3201 (combine_after_change_list, combine_after_change_buffer):
3202 (adjust_after_replace, signal_before_change): Now static.
3203 (adjust_after_replace_noundo): Remove; unused.
3204 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3205 (signal_before_change): Remove decls.
3206
3207 * indent.c (val_compute_motion, val_vmotion): Now static.
3208
3209 * image.c: Make symbols static if they're not exported.
3210 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3211 if USE_GTK.
3212 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3213 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3214
3215 * fringe.c (standard_bitmaps): Now static.
3216 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3217
3218 * frame.c: Make symbols static if they're not exported.
3219 (x_report_frame_params, make_terminal_frame): Now static.
3220 (get_frame_param): Now static, unless HAVE_NS.
3221 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3222 (x_get_resource_string): Remove; not used.
3223 * frame.h (make_terminal_frame, x_report_frame_params):
3224 (x_get_resource_string); Remove decls.
3225 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3226 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3227
3228 * font.c, fontset.c: Make symbols static if they're not exported.
3229 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3230 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3231 * font.c (font_close_object): Now static.
3232 * font.h (font_close_object): Remove.
3233 * fontset.c (FONTSET_OBJLIST): Remove.
3234 (free_realized_fontset) #if-0 the body, which does nothing.
3235 (face_suitable_for_char_p): #if-0, as it's never called.
3236 * fontset.h (face_suitable_for_char_p): Remove decl.
3237 * xfaces.c (face_at_string_position):
3238 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3239 since 0 is always ASCII.
3240
3241 * fns.c (weak_hash_tables): Now static.
3242
3243 * fileio.c: Make symbols static if they're not exported.
3244 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3245 (Vwrite_region_annotation_buffers): Now static.
3246
3247 * eval.c: Make symbols static if they're not exported.
3248 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3249 * lisp.h (backtrace_list): Remove decl.
3250
3251 * emacs.c: Make symbols static if they're not exported.
3252 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3253 (fatal_error_code, fatal_error_signal_hook, standard_args):
3254 Now static.
3255 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3256 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3257 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3258 * lisp.h (fatal_error_signal_hook): Remove decl.
3259 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3260
3261 * editfns.c: Move a (normally-unused) function to its only use.
3262 * editfns.c, lisp.h (get_operating_system_release): Remove.
3263 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3264 worth the hassle of breaking this out.
3265
3266 * xterm.c: Make symbols static if they're not exported.
3267 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3268 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3269 (x_destroy_window, x_delete_display):
3270 Now static.
3271 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3272 (x_mouse_leave): Remove; unused.
3273 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3274 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3275 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3276 Remove decls.
3277 (x_mouse_leave): Declare only if WINDOWSNT.
3278 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3279 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3280 USE_X_TOOLKIT.
3281
3282 * ftxfont.c: Make symbols static if they're not exported.
3283 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3284 HAVE_FREETYPE.
3285 * font.h (ftxfont_driver): Likewise.
3286
3287 * xfns.c: Make symbols static if they're not exported.
3288 (x_last_font_name, x_display_info_for_name):
3289 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3290 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3291 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3292 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3293 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3294 (last_show_tip_args): Now static.
3295 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3296 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3297 (x_screen_planes): Remove; unused.
3298 * dispextern.h (x_screen_planes): Remove decl.
3299
3300 * dispnew.c: Make symbols static if they're not exported.
3301 * dispextern.h (redraw_garbaged_frames, scrolling):
3302 (increment_row_positions): Remove.
3303 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3304 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3305 Now static.
3306 (redraw_garbaged_frames): Remove; unused.
3307
3308 * xfaces.c: Make symbols static if they're not exported.
3309 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3310 Remove decls.
3311 * xterm.h (defined_color): Remove decls.
3312 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3313 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3314 (menu_face_changed_default, defined_color, free_realized_face):
3315 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3316 (ascii_face_of_lisp_face): Remove; unused.
3317
3318 * xdisp.c: Make symbols static if they're not exported.
3319 * dispextern.h (scratch_glyph_row, window_box_edges):
3320 (glyph_to_pixel_coords, set_cursor_from_row):
3321 (get_next_display_element, set_iterator_to_next):
3322 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3323 (show_mouse_face): Remove decls
3324 * frame.h (message_buf_print): Likewise.
3325 * lisp.h (pop_message, set_message, check_point_in_composition):
3326 Likewise.
3327 * xterm.h (set_vertical_scroll_bar): Likewise.
3328 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3329 (message_buf_print, scratch_glyph_row, displayed_buffer):
3330 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3331 (get_next_display_element, show_mouse_face, window_box_edges):
3332 (frame_to_window_pixel_xy, check_point_in_composition):
3333 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3334 (glyph_to_pixel_coords): Remove; unused.
3335
3336 * dired.c (file_name_completion): Now static.
3337
3338 * dbusbind.c (xd_in_read_queued_messages): Now static.
3339
3340 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3341 * data.c (circular_list_error): Remove.
3342
3343 * commands.h (last_point_position, last_point_position_buffer):
3344 (last_point_position_window): Remove decls.
3345 * keyboard.c: Make these variables static.
3346
3347 * coding.h (coding, code_convert_region, encode_coding_gap):
3348 Remove decls.
3349 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3350 (iso_code_class, detect_coding, code_convert_region): Now static.
3351 (encode_coding_gap): Remove; unused.
3352
3353 * chartab.c (chartab_chars, chartab_bits): Now static.
3354
3355 * charset.h (charset_iso_8859_1): Remove decl.
3356 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3357 Now static.
3358
3359 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3360 * ccl.c (Vccl_program_table): Now static.
3361 (check_ccl_update): Remove; unused.
3362
3363 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3364 * category.h: ... from here.
3365 * category.c (check_category_table, set_category_set): Now static.
3366
3367 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3368 * lisp.h: Remove these decls.
3369
3370 * buffer.c (buffer_count): Remove unused var.
3371
3372 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3373 so that it's not optimized away.
3374 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3375 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3376 exported only to the debugger.
3377
3378 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3379 * atimer.h (run_all_atimers): Remove; not exported.
3380
3381 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3382 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3383 was inaccessible from Lisp.
3384 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3385 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3386
3387 alloc.c: Import and export fewer symbols, and remove unused items.
3388 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3389 is defined.
3390 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3391 it's not optimized away by whole-program optimization.
3392 (message_enable_multibyte, free_misc): Remove.
3393 (catchlist, handlerlist, mark_backtrace):
3394 Declare only if BYTE_MARK_STACK.
3395 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3396 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3397 (message_enable_multibyte): Remove decl.
3398 (free_misc, interval_free_list, float_block, float_block_index):
3399 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3400 (cons_free_list, last_marked_index):
3401 Now static.
3402 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3403 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3404 (mark_backtrace): Define only if BYTE_MARK_STACK.
3405 * xdisp.c (message_enable_multibyte): Now static.
3406
3407 Declare Lisp_Object Q* variables to be 'static' if not exported.
3408 This makes it easier for human readers (and static analyzers)
3409 to see whether these variables are used from other modules.
3410 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3411 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3412 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3413 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3414 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3415 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3416 * xmenu.c, xselect.c:
3417 Declare Q* vars static if they are not used in other modules.
3418 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3419 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3420 Remove decls of unexported vars.
3421 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3422
3423 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3424
3425 Make Emacs functions such as Fatom 'static' by default.
3426 This makes it easier for human readers (and static analyzers)
3427 to see whether these functions can be called from other modules.
3428 DEFUN now defines a static function. To make the function external
3429 so that it can be used in other C modules, use the new macro DEFUE.
3430 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3431 (Finit_image_library):
3432 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3433 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3434 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3435 Remove decls, since these functions are now static.
3436 (Funintern, Fget_internal_run_time): New decls, since these functions
3437 were already external.
3438
3439 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3440 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3441 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3442 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3443 * keyboard.c, keymap.c, lread.c:
3444 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3445 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3446 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3447 Mark functions with DEFUE instead of DEFUN,
3448 if they are used in other modules.
3449 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3450 decls for now-static functions.
3451 * buffer.h (Fdelete_overlay): Remove decl.
3452 * callproc.c (Fgetenv_internal): Mark as internal.
3453 * composite.c (Fremove_list_of_text_properties): Remove decl.
3454 (Fcomposition_get_gstring): New forward static decl.
3455 * composite.h (Fcomposite_get_gstring): Remove decl.
3456 * dired.c (Ffile_attributes): New forward static decl.
3457 * doc.c (Fdocumntation_property): New forward static decl.
3458 * eval.c (Ffetch_bytecode): New forward static decl.
3459 (Funintern): Remove extern decl; now in .h file where it belongs.
3460 * fileio.c (Fmake_symbolic_link): New forward static decl.
3461 * image.c (Finit_image_library): New forward static decl.
3462 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3463 * intervals.h (Fprevious_property_change):
3464 (Fremove_list_of_text_properties): Remove decls.
3465 * keyboard.c (Fthis_command_keys): Remove decl.
3466 (Fcommand_execute): New forward static decl.
3467 * keymap.c (Flookup_key): New forward static decl.
3468 (Fcopy_keymap): Now static.
3469 * keymap.h (Flookup_key): Remove decl.
3470 * process.c (Fget_process): New forward static decl.
3471 (Fprocess_datagram_address): Mark as internal.
3472 * syntax.c (Fsyntax_table_p): New forward static decl.
3473 (skip_chars): Remove duplicate decl.
3474 * textprop.c (Fprevious_property_change): New forward static decl.
3475 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3476 Now internal.
3477 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3478 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3479
3480 * editfns.c (Fformat): Remove unreachable code.
3481
3482 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3483
3484 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3485 change. (Bug#8496)
3486
3487 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3488
3489 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3490 when at ZV. (Bug#8487)
3491
3492 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3493
3494 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3495 (Bug#8437)
3496 * keyboard.c (parse_tool_bar_item): Likewise.
3497 * sound.c (sound_cleanup, alsa_close): Likewise.
3498 * termcap.c (tgetent): Likewise.
3499 * xfns.c (x_default_font_parameter): Likewise.
3500 * xsettings.c (read_and_apply_settings): Likewise.
3501
3502 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3503 (overrun_check_free): Protoize.
3504
3505 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3506
3507 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3508 since callers should never pass a negative size.
3509 Change the signature to match that of plain 'read' and 'write'; see
3510 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3511 * lisp.h: Update prototypes of emacs_write and emacs_read.
3512
3513 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3514
3515 * xdisp.c (redisplay_window): Don't try to determine the character
3516 position of the scroll margin if the window start point w->startp
3517 is outside the buffer's accessible region. (Bug#8468)
3518
3519 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3520
3521 Fix write-region and its subroutines for buffers > 2GB.
3522 * fileio.c (a_write, e_write): Modify declaration of arguments and
3523 local variables to support buffers larger than 2GB.
3524 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3525
3526 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3527 argument, local variables, and return value.
3528
3529 * lisp.h: Update prototypes of emacs_write and emacs_read.
3530
3531 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3532
3533 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3534
3535 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3536
3537 Fix more problems found by GCC 4.6.0's static checks.
3538
3539 * xdisp.c (vmessage): Use a better test for character truncation.
3540
3541 * charset.c (load_charset_map): <, not <=, for optimization,
3542 and to avoid potential problems with integer overflow.
3543 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3544 * casetab.c (set_identity, shuffle): Likewise.
3545 * editfns.c (Fformat): Likewise.
3546 * syntax.c (skip_chars): Likewise.
3547
3548 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3549 This also lets GCC 4.6.0 generate slightly better loop code.
3550
3551 * callint.c (Fcall_interactively): <, not <=, for optimization.
3552 (Fcall_interactively): Count the number of arguments produced,
3553 not the number of arguments given. This is simpler and lets GCC
3554 4.6.0 generate slightly better code.
3555
3556 * ftfont.c: Distingish more carefully between FcChar8 and char.
3557 The previous code passed unsigned char * to a functions like
3558 strlen and xstrcasecmp that expect char *, which does not
3559 conform to the C standard.
3560 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3561 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3562 char * when the C standard requires it.
3563
3564 * keyboard.c (read_char): Remove unused var.
3565
3566 * eval.c: Port to Windows vsnprintf (Bug#8435).
3567 Include <limits.h>.
3568 (SIZE_MAX): Define if the headers do not.
3569 (verror): Do not give up if vsnprintf returns a negative count.
3570 Instead, grow the buffer. This ports to Windows vsnprintf, which
3571 does not conform to C99. Problem reported by Eli Zaretskii.
3572 Also, simplify the allocation scheme, by avoiding the need for
3573 calling realloc, and removing the ALLOCATED variable.
3574
3575 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3576
3577 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3578 But keep the doprint source code for now, as we might revamp it
3579 and use it again (Bug#8435).
3580 * lisp.h (doprnt): Remove.
3581 * Makefile.in (base_obj): Remove doprnt.o.
3582 * deps.mk (doprnt.o): Remove.
3583
3584 error: Print 32- and 64-bit integers portably (Bug#8435).
3585 Without this change, on typical 64-bit hosts error ("...%d...", N)
3586 was used to print both 32- and 64-bit integers N, which relied on
3587 undefined behavior.
3588 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3589 New macro.
3590 * lisp.h (error, verror): Mark as printf-like functions.
3591 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3592 Report overflow in size calculations when allocating printf buffer.
3593 Do not truncate output string at its first null byte.
3594 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3595 Truncate the output at a character boundary, since vsnprintf does not
3596 do that.
3597 * charset.c (check_iso_charset_parameter): Convert internal
3598 character to string before calling 'error', since %c now has the
3599 printf meaning.
3600 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3601 overflow when computing char to be passed to 'error'. Do not
3602 pass Lisp_Object to 'error'; pass the integer instead.
3603 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3604 formatted with plain %d.
3605
3606 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3607
3608 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3609
3610 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3611
3612 * xterm.c (x_catch_errors): Remove duplicate declaration.
3613
3614 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3615
3616 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3617
3618 2011-04-10 Jim Meyering <meyering@redhat.com>
3619
3620 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3621 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3622 return ssize_t not "int", and use size_t as the buffer length.
3623 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3624 * gnutls.h: Update declarations.
3625 * process.c (read_process_output): Use ssize_t, to match.
3626 (send_process): Likewise.
3627
3628 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3629
3630 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3631
3632 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3633
3634 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3635 Use unsigned char, to match FcChar8 type definition.
3636
3637 * xterm.c (handle_one_xevent):
3638 * xmenu.c (create_and_show_popup_menu):
3639 * xselect.c (x_decline_selection_request)
3640 (x_reply_selection_request): Avoid type-punned deref of X events.
3641
3642 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3643
3644 Fix some uses of `int' instead of EMACS_INT.
3645 * search.c (string_match_1, fast_string_match)
3646 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3647 (scan_buffer, find_next_newline_no_quit)
3648 (find_before_next_newline, search_command, Freplace_match)
3649 (Fmatch_data): Make some `int' variables be EMACS_INT.
3650
3651 * xdisp.c (display_count_lines): 3rd argument and return value now
3652 EMACS_INT. All callers changed.
3653 (pint2hrstr): Last argument is now EMACS_INT.
3654
3655 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3656 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3657 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3658 (decode_coding_utf_16, decode_coding_emacs_mule)
3659 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3660 (decode_coding_ccl, decode_coding_charset)
3661 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3662 (decode_coding_iso_2022, decode_coding_emacs_mule)
3663 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3664 <char_offset, last_offset>: Declare EMACS_INT.
3665 (encode_coding_utf_8, encode_coding_utf_16)
3666 (encode_coding_emacs_mule, encode_invocation_designation)
3667 (encode_designation_at_bol, encode_coding_iso_2022)
3668 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3669 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3670 Declare EMACS_INT.
3671 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3672 (encode_invocation_designation): Last argument P_NCHARS is now
3673 EMACS_INT.
3674 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3675 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3676
3677 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3678 All users changed.
3679
3680 * ccl.c (Fccl_execute_on_string): Declare some variables
3681 EMACS_INT.
3682
3683 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3684
3685 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3686
3687 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3688
3689 * process.c (Fformat_network_address): Doc fix.
3690
3691 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3692
3693 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3694
3695 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3696
3697 * keyboard.c (read_char): Call Lisp function help-form-show,
3698 instead of using internal_with_output_to_temp_buffer.
3699 (Qhelp_form_show): New var.
3700 (syms_of_keyboard): Use DEFSYM macro.
3701
3702 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3703
3704 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3705
3706 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3707
3708 * process.c (Flist_processes): Remove to Lisp.
3709 (list_processes_1): Delete.
3710
3711 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3712
3713 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3714
3715 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3716
3717 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3718
3719 Fix more problems found by GCC 4.6.0's static checks.
3720
3721 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3722
3723 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3724
3725 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3726
3727 * xdisp.c (vmessage): Mark as a printf-like function.
3728
3729 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3730
3731 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3732
3733 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3734 printf-like functions.
3735 (tiff_load): Add casts to remove these marks before passing them
3736 to system-supplied API.
3737
3738 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3739
3740 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3741 This avoids several warnings with gcc -Wstrict-overflow.
3742 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3743 directly, rather than having caller test rule sign. This avoids
3744 some unnecessary tests.
3745 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3746 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3747 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3748
3749 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3750 (xfont_open): Avoid unnecessary tests.
3751
3752 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3753
3754 * composite.h, composite.c (composition_gstring_put_cache):
3755 Use EMACS_INT, not int, for length.
3756
3757 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3758 breaking out part of COMPOSITION_DECODE_RULE.
3759 (COMPOSITION_DECODE_RULE): Use it.
3760 * composite.c (get_composition_id): Remove unused local vars,
3761 by using the new macro.
3762
3763 * textprop.c (set_text_properties_1): Change while to do-while,
3764 since the condition is always true at first.
3765
3766 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3767 (interval_deletion_adjustment): Return unsigned value.
3768 All uses changed.
3769
3770 * process.c (list_processes_1, create_pty, read_process_output):
3771 (exec_sentinel): Remove vars that were set but not used.
3772 (create_pty): Remove unnecessary "volatile"s.
3773 (Fnetwork_interface_info): Avoid possibility of int overflow.
3774 (read_process_output): Do adaptive read buffering even if carryover.
3775 (read_process_output): Simplify nbytes computation if buffered.
3776
3777 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3778
3779 * syntax.c (scan_words): Remove var that was set but not used.
3780 (update_syntax_table): Use unsigned instead of int.
3781
3782 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3783 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3784 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3785
3786 * print.c (print_error_message): Avoid int overflow.
3787
3788 * font.c (font_list_entities): Redo for clarity,
3789 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3790
3791 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3792 (font_score): Avoid potential overflow in diff calculation.
3793
3794 * fns.c (substring_both): Remove var that is set but not used.
3795 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3796
3797 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3798
3799 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3800 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3801 can always succeed if overflow has undefined behavior.
3802
3803 * search.c (boyer_moore, wordify): Remove vars set but not used.
3804 (wordify): Omit three unnecessary tests.
3805
3806 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3807 All callers changed. This avoids the need for an unused var.
3808
3809 * casefiddle.c (casify_region): Remove var that is set but not used.
3810
3811 * dired.c (file_name_completion): Remove var that is set but not used.
3812
3813 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3814
3815 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3816 (Finsert_file_contents): Remove unnecessary code checking fd.
3817
3818 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3819 Check for integer overflow on size calculations.
3820
3821 * buffer.c (Fprevious_overlay_change): Remove var that is set
3822 but not used.
3823
3824 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3825 Remove vars that are set but not used.
3826 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3827 (timer_check_2): Mark vars as initialized.
3828
3829 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3830
3831 * image.c (lookup_image): Remove var that is set but not used.
3832 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3833
3834 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3835 that are set but not used.
3836
3837 * xfns.c (make_invisible_cursor): Don't return garbage
3838 if XCreateBitmapFromData fails (Bug#8410).
3839
3840 * xselect.c (x_get_local_selection, x_handle_property_notify):
3841 Remove vars that are set but not used.
3842
3843 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3844 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3845
3846 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3847 Remove var that is set but not used.
3848 (scroll_bar_windows_size): Now size_t, not int.
3849 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3850 Check for overflow.
3851
3852 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3853 (map_tty_color) [!defined MSDOS]: Likewise.
3854
3855 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3856
3857 * coding.c: Remove vars that are set but not used.
3858 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3859 All callers changed.
3860 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3861 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3862 (decode_coding_charset): Remove vars that are set but not used.
3863
3864 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3865 that is set but not used.
3866
3867 * print.c (print_object): Remove var that is set but not used.
3868
3869 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3870 The gnulib version avoids calling malloc in the usual case,
3871 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3872 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3873 * filelock.c (current_lock_owner): Likewise.
3874 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3875 * sysdep.c: Include allocator.h, careadlinkat.h.
3876 (emacs_no_realloc_allocator): New static constant.
3877 (emacs_readlink): New function.
3878 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3879 ../lib/careadlinkat.h.
3880
3881 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3882
3883 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3884 first non-nil return value).
3885
3886 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3887
3888 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3889 if not defined (Bug#8403).
3890
3891 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3892
3893 * xdisp.c (display_count_lines): Remove parameter `start',
3894 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3895 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3896 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3897 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3898 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3899 and thereabouts. All callers changed.
3900 (get_per_char_metric): Remove parameter `f', unused since
3901 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3902
3903 2011-04-02 Jim Meyering <meyering@redhat.com>
3904
3905 do not dereference NULL upon failed strdup
3906 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3907 (ns_get_family): Likewise.
3908
3909 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3910
3911 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3912
3913 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3914
3915 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3916 later (Bug#8403).
3917
3918 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3919
3920 Add lexical binding.
3921
3922 * window.c (Ftemp_output_buffer_show): New fun.
3923 (Fsave_window_excursion):
3924 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3925
3926 * lread.c (lisp_file_lexically_bound_p): New function.
3927 (Fload): Bind Qlexical_binding.
3928 (readevalloop): Remove `evalfun' arg.
3929 Bind Qinternal_interpreter_environment.
3930 (Feval_buffer): Bind Qlexical_binding.
3931 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3932 Mark as dynamic.
3933 (syms_of_lread): Declare `lexical-binding'.
3934
3935 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3936
3937 * keyboard.c (eval_dyn): New fun.
3938 (menu_item_eval_property): Use it.
3939
3940 * image.c (parse_image_spec): Use Ffunctionp.
3941
3942 * fns.c (concat, mapcar1): Accept byte-code-functions.
3943
3944 * eval.c (Fsetq): Handle lexical vars.
3945 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3946 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3947 (FletX, Flet): Obey lexical binding.
3948 (Fcommandp): Handle closures.
3949 (Feval): New `lexical' arg.
3950 (eval_sub): New function extracted from Feval. Use it almost
3951 everywhere where Feval was used. Look up vars in lexical env.
3952 Handle closures.
3953 (Ffunctionp): Move from subr.el.
3954 (Ffuncall): Handle closures.
3955 (apply_lambda): Remove `eval_flags'.
3956 (funcall_lambda): Handle closures and new byte-code-functions.
3957 (Fspecial_variable_p): New function.
3958 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3959 but without exporting it to Lisp.
3960
3961 * doc.c (Fdocumentation, store_function_docstring):
3962 * data.c (Finteractive_form): Handle closures.
3963
3964 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3965 interactive spec.
3966
3967 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3968 New byte-codes.
3969 (exec_byte_code): New function extracted from Fbyte_code to handle new
3970 calling convention for byte-code-functions. Add new byte-codes.
3971
3972 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3973
3974 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3975
3976 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3977
3978 * xdisp.c (redisplay_internal): Fix prototype.
3979
3980 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3981
3982 * xdisp.c (SCROLL_LIMIT): New macro.
3983 (try_scrolling): Use it when setting scroll_limit.
3984 Limit scrolling to 100 screen lines.
3985 (redisplay_window): Even when falling back on "recentering",
3986 position point in the window according to scroll-conservatively,
3987 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3988
3989 (try_scrolling): When point is above the window, allow searching
3990 as far as scroll_max, or one screenful, to compute vertical
3991 distance from PT to the scroll margin position. This prevents
3992 try_scrolling from unnecessarily failing when
3993 scroll-conservatively is set to a value slightly larger than the
3994 window height. Clean up the case of PT below the margin at bottom
3995 of window: scroll_max can no longer be INT_MAX. When aggressive
3996 scrolling is in use, don't let point enter the opposite scroll
3997 margin as result of the scroll.
3998 (syms_of_xdisp) <scroll-conservatively>: Document the
3999 threshold of 100 lines for never-recentering scrolling.
4000
4001 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4002
4003 * dispextern.h (move_it_by_lines):
4004 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4005 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4006 (message_log_check_duplicate): Remove parameters `prev_bol' and
4007 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4008 (redisplay_internal): Remove parameter `preserve_echo_area',
4009 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4010
4011 * indent.c (Fvertical_motion):
4012 * window.c (window_scroll_pixel_based, Frecenter):
4013 Don't pass `need_y_p' to `move_it_by_lines'.
4014
4015 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4016
4017 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4018 steal a few bits to be more compact.
4019 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4020 Remove unneeded casts.
4021
4022 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4023
4024 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4025
4026 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4027 binding" message (bug#7967).
4028
4029 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4030
4031 Fix more problems found by GCC 4.6.0's static checks.
4032
4033 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4034 Remove unused local var.
4035
4036 * editfns.c (Fmessage_box): Remove unused local var.
4037
4038 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4039 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4040 Omit unused local vars.
4041 * window.c (shrink_windows): Omit unused local var.
4042 * menu.c (digest_single_submenu): Omit unused local var.
4043 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4044 Omit unused local var.
4045
4046 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4047 Don't assume string length fits in int.
4048 (keyremap_step, read_key_sequence): Use size_t for sizes.
4049 (read_key_sequence): Don't check last_real_key_start redundantly.
4050
4051 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4052 instead of alloca (Bug#8344).
4053
4054 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4055 (Fbacktrace_frame): Don't assume nframes fits in int.
4056
4057 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4058
4059 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4060 concerns.
4061
4062 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4063
4064 * cm.c (calccost): Turn while-do into do-while, for clarity.
4065
4066 * keyboard.c (syms_of_keyboard): Use the same style as later
4067 in this function when indexing through an array. This also
4068 works around GCC bug 48267.
4069
4070 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4071
4072 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4073
4074 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4075 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4076
4077 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4078 This avoids undefined behavior on integer overflow, and is a bit
4079 more convenient anyway since it is compared to a size_t variable.
4080
4081 Variadic C functions now count arguments with size_t, not int.
4082 This avoids an unnecessary limitation on 64-bit machines, which
4083 caused (substring ...) to crash on large vectors (Bug#8344).
4084 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4085 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4086 All variadic functions and their callers changed accordingly.
4087 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4088 * data.c (arith_driver, float_arith_driver): Likewise.
4089 * editfns.c (general_insert_function): Likewise.
4090 * eval.c (struct backtrace.nargs, interactive_p)
4091 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4092 (funcall_lambda, mark_backtrace): Likewise.
4093 * fns.c (concat): Likewise.
4094 * frame.c (x_set_frame_parameters): Likewise.
4095 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4096 0 if not found, not -1. All callers changed.
4097
4098 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4099 (stack_copy_size): Now size_t, not int.
4100 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4101
4102 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4103
4104 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4105 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4106 All callers changed.
4107
4108 * lisp.h (multibyte_char_to_unibyte):
4109 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4110 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4111 * character.h (CHAR_TO_BYTE8):
4112 * cmds.c (internal_self_insert):
4113 * editfns.c (general_insert_function):
4114 * keymap.c (push_key_description):
4115 * search.c (Freplace_match):
4116 * xdisp.c (message_dolog, set_message_1): All callers changed.
4117
4118 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4119
4120 * keyboard.c (safe_run_hook_funcall): New function.
4121 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4122 don't set the hook to nil, but remove the offending function instead.
4123 (Qcommand_hook_internal): Remove, unused.
4124 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4125 Vcommand_hook_internal.
4126
4127 * eval.c (enum run_hooks_condition): Remove.
4128 (funcall_nil, funcall_not): New functions.
4129 (run_hook_with_args): Call each function through a `funcall' argument.
4130 Remove `cond' argument, now redundant.
4131 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4132 (Frun_hook_with_args_until_failure): Adjust accordingly.
4133 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4134
4135 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4136
4137 * dispextern.h (string_buffer_position): Remove declaration.
4138
4139 * print.c (strout): Remove parameter `multibyte', unused since
4140 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4141
4142 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4143 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4144 All callers changed.
4145
4146 * w32.c (_wsa_errlist): Use braces for struct initializers.
4147
4148 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4149 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4150 All callers changed.
4151 (string_buffer_position): Likewise. Also, make static (it's never
4152 used outside xdisp.c).
4153 (cursor_row_p): Remove parameter `w', unused since
4154 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4155 (decode_mode_spec): Remove parameter `precision', introduced during
4156 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4157 All callers changed.
4158
4159 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4160
4161 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4162
4163 2011-03-27 Anders Lindgren <andlind@gmail.com>
4164
4165 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4166 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4167 (ns_update_auto_hide_menu_bar): New functions.
4168 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4169 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4170 ns_constrain_all_frames.
4171 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4172 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4173
4174 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4175
4176 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4177
4178 2011-03-27 Glenn Morris <rgm@gnu.org>
4179
4180 * syssignal.h: Replace RETSIGTYPE with void.
4181 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4182 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4183 Replace SIGTYPE with void everywhere.
4184 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4185 * s/template.h (SIGTYPE): Remove commented out definition.
4186
4187 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4188
4189 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4190 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4191
4192 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4193
4194 * w32.c (read_unc_volume): Use parameter `henum', instead of
4195 global variable `wget_enum_handle'.
4196
4197 * keymap.c (describe_vector): Remove parameters `indices' and
4198 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4199 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4200
4201 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4202
4203 * keyboard.c (timer_check): Remove parameter `do_it_now',
4204 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4205 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4206 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4207
4208 * keyboard.c (read_char):
4209 * w32menu.c (w32_menu_display_help):
4210 * xmenu.c (show_help_event, menu_help_callback):
4211 Adjust calls to `show_help_echo'.
4212
4213 * gtkutil.c (xg_maybe_add_timer):
4214 * keyboard.c (readable_events):
4215 * process.c (wait_reading_process_output):
4216 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4217
4218 * insdel.c (adjust_markers_gap_motion):
4219 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4220 (gap_left, gap_right): Don't call it.
4221
4222 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4223
4224 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4225 incurred during fontification.
4226
4227 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4228
4229 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4230 (DEFVAR_PER_BUFFER): Don't pass it.
4231
4232 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4233 (scrolling_window): Don't pass it.
4234
4235 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4236
4237 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4238
4239 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4240 and `suffix'.
4241 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4242 of variables specific to SELinux and computation of `encoded_absname'.
4243
4244 * image.c (XPutPixel): Remove unused variable `height'.
4245
4246 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4247
4248 * unexw32.c (get_section_info): Remove unused variable `section'.
4249
4250 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4251 (system_process_attributes): Remove unused variable `sess'.
4252 (sys_read): Remove unused variable `err'.
4253
4254 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4255 (w32_wnd_proc): Remove unused variable `isdead'.
4256 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4257 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4258 (x_create_tip_frame): Remove unused variable `tem'.
4259
4260 * w32inevt.c (w32_console_read_socket):
4261 Remove unused variable `no_events'.
4262
4263 * w32term.c (x_draw_composite_glyph_string_foreground):
4264 Remove unused variable `width'.
4265
4266 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * w32term.c (x_set_glyph_string_clipping):
4269 Don't pass uninitialized region to CombineRgn.
4270
4271 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4272
4273 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4274 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4275 (Fx_close_connection): Remove unused variable `i'.
4276
4277 * w32font.c (w32font_draw): Return number of glyphs.
4278 (w32font_open_internal): Remove unused variable `i'.
4279 (w32font_driver): Add missing initializer.
4280
4281 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4282 (fill_in_menu): Remove unused variable `items_added'.
4283
4284 * w32term.c (last_mouse_press_frame): Remove static global variable.
4285 (w32_clip_to_row): Remove unused variable `f'.
4286 (x_delete_terminal): Remove unused variable `i'.
4287
4288 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4289 (NOTHING): Remove unused static global variable.
4290 (uniscribe_check_otf): Remove unused variable `table'.
4291 (uniscribe_font_driver): Add missing initializers.
4292
4293 2011-03-23 Julien Danjou <julien@danjou.info>
4294
4295 * term.c (Fsuspend_tty, Fresume_tty):
4296 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4297 * window.c (temp_output_buffer_show):
4298 * insdel.c (signal_before_change):
4299 * frame.c (Fhandle_switch_frame):
4300 * fileio.c (Fdo_auto_save):
4301 * emacs.c (Fkill_emacs):
4302 * editfns.c (save_excursion_restore):
4303 * cmds.c (internal_self_insert):
4304 * callint.c (Fcall_interactively):
4305 * buffer.c (Fkill_all_local_variables):
4306 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4307 Use Frun_hooks.
4308 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4309 unconditionnaly since it does the check itself.
4310
4311 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4312
4313 Fix more problems found by GCC 4.5.2's static checks.
4314
4315 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4316 the first time through the loop, since we know p0 < p1 then.
4317 This also avoids a gcc -Wstrict-overflow warning.
4318
4319 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4320 leading to a memory leak, possible in functions like
4321 load_charset_map_from_file that can allocate an unbounded number
4322 of objects (Bug#8318).
4323
4324 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4325 that could (at least in theory) be that large.
4326
4327 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4328 This is less likely to overflow, and avoids undefined behavior if
4329 overflow does occur. All callers changed. Use strtoul to scan
4330 for the unsigned long integer.
4331 (pint2hrstr): Simplify and tune code slightly.
4332 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4333
4334 * scroll.c (do_scrolling): Work around GCC bug 48228.
4335 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4336
4337 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4338 This also avoids a warning with gcc -Wstrict-overflow.
4339 (validate_x_resource_name): Simplify count usage.
4340 This also avoids a warning with gcc -Wstrict-overflow.
4341
4342 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4343 fail (Bug#8306).
4344
4345 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4346
4347 * process.c (Fmake_network_process): Use socklen_t, not int,
4348 where POSIX says socklen_t is required in portable programs.
4349 This fixes a porting bug on hosts like 64-bit HP-UX, where
4350 socklen_t is wider than int (Bug#8277).
4351 (Fmake_network_process, server_accept_connection):
4352 (wait_reading_process_output, read_process_output):
4353 Likewise.
4354
4355 * process.c: Rename or move locals to avoid shadowing.
4356 (list_processes_1, Fmake_network_process):
4357 (read_process_output_error_handler, exec_sentinel_error_handler):
4358 Rename or move locals.
4359 (Fmake_network_process): Define label "retry_connect" only if needed.
4360 (Fnetwork_interface_info): Fix pointer signedness.
4361 (process_send_signal): Add cast to avoid pointer signedness problem.
4362 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4363 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4364
4365 Make tparam.h and terminfo.c consistent.
4366 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4367 Include tparam.h instead, since it declares them.
4368 * cm.h (PC): Remove extern decl; tparam.h now does this.
4369 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4370 * terminfo.c: Include tparam.h, to check interfaces.
4371 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4372 (tparam): Adjust signature to match interface in tparam.h;
4373 this removes some undefined behavior. Check that outstring and len
4374 are zero, which they always are with Emacs.
4375 * tparam.h (PC, BC, UP): New extern decls.
4376
4377 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4378 (xftfont_open): Rename locals to avoid shadowing.
4379
4380 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4381 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4382 (OTF_TAG_SYM): Omit macro if not needed.
4383 (ftfont_list): Remove unused local.
4384 (get_adstyle_property, ftfont_pattern_entity):
4385 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4386 Rename locals to avoid shadowing.
4387
4388 * xfont.c (xfont_list_family): Mark var as initialized.
4389
4390 * xml.c (make_dom): Now static.
4391
4392 * composite.c (composition_compute_stop_pos): Rename local to
4393 avoid shadowing.
4394 (composition_reseat_it): Remove unused locals.
4395 (find_automatic_composition, composition_adjust_point): Likewise.
4396 (composition_update_it): Mark var as initialized.
4397 (find_automatic_composition): Mark vars as initialized,
4398 with a FIXME (Bug#8290).
4399
4400 character.h: Rename locals to avoid shadowing.
4401 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4402 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4403 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4404 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4405 to avoid shadowing.
4406
4407 * textprop.c (property_change_between_p): Remove; unused.
4408
4409 * intervals.c (interval_start_pos): Now static.
4410
4411 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4412
4413 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4414 Rename locals to avoid shadowing.
4415
4416 * sound.c (wav_play, au_play, Fplay_sound_internal):
4417 Fix pointer signedness.
4418 (alsa_choose_format): Remove unused local var.
4419 (wav_play): Initialize a variable to 0, to prevent undefined
4420 behavior (Bug#8278).
4421
4422 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4423
4424 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4425
4426 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4427 clobbering (Bug#8298).
4428 * sysdep.c (sys_subshell): Likewise.
4429 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4430
4431 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4432 This should get cleaned up, so that child_setup has the
4433 same signature on all platforms.
4434
4435 * callproc.c (call_process_cleanup): Now static.
4436 (relocate_fd): Rename locals to avoid shadowing.
4437
4438 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4439
4440 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4441 not to be necessary, and produces flickering.
4442
4443 2011-03-20 Glenn Morris <rgm@gnu.org>
4444
4445 * config.in: Remove file.
4446
4447 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4448
4449 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4450 are now in src/globals.h.
4451 (syms_of_minibuf): Remove spurious & from previous change.
4452
4453 2011-03-20 Leo <sdl.web@gmail.com>
4454
4455 * minibuf.c (completing-read-function): New variable.
4456 (completing-read-default): Rename from completing-read.
4457 (completing-read): Call completing-read-function.
4458
4459 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4460
4461 * xfaces.c (Fx_load_color_file):
4462 Read color file from absolute filename (bug#8250).
4463
4464 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4465
4466 * makefile.w32-in: Update dependencies.
4467
4468 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4469
4470 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4471
4472 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4473
4474 Fix more problems found by GCC 4.5.2's static checks.
4475
4476 * process.c (make_serial_process_unwind, send_process_trap):
4477 (sigchld_handler): Now static.
4478
4479 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4480 That way, the code declares only the vars that it needs.
4481 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4482 * s/cygwin.h (PTY_ITERATION): Likewise.
4483 * s/darwin.h (PTY_ITERATION): Likewise.
4484 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4485
4486 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4487 * process.c (allocate_pty): Don't declare stb unless it's needed.
4488
4489 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4490 (CONSTANTLIM): Remove; unused.
4491 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4492 Define only if needed.
4493
4494 * unexelf.c (unexec): Name an expression,
4495 to avoid gcc -Wbad-function-cast warning.
4496 Use a different way to cause a compilation error if anyone uses
4497 n rather than nn, a way that does not involve shadowing.
4498 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4499
4500 * deps.mk (unexalpha.o): Remove; unused.
4501
4502 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4503 * unexec.h: New file.
4504 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4505 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4506 Depend on unexec.h.
4507 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4508 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4509 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4510 Change as necessary to match prototype in unexec.h.
4511
4512 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4513 shadowing.
4514 (back_comment, skip_chars): Mark vars as initialized.
4515
4516 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4517 Rename locals to avoid shadowing.
4518
4519 * lread.c (read1): Rewrite so as not to use empty "else".
4520 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4521
4522 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4523
4524 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4525 warning when compiling print.c.
4526
4527 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4528 instead of using an uninitialized var.
4529 (font_sort_entities): Mark var as initialized.
4530
4531 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4532
4533 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4534 pointers to constants.
4535 (font_parse_fcname): Remove unused vars.
4536 (font_delete_unmatched): Now static.
4537 (font_get_spec): Remove; unused.
4538 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4539 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4540 Rename or move locals to avoid shadowing.
4541
4542 * fns.c (require_nesting_list, require_unwind): Now static.
4543 (Ffillarray): Rename locals to avoid shadowing.
4544
4545 * floatfns.c (domain_error2): Define only if needed.
4546 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4547
4548 * alloc.c (mark_backtrace): Move decl from here ...
4549 * lisp.h: ... to here, so that it can be checked.
4550
4551 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4552 (Fdefvar): Rewrite so as not to use empty "else".
4553 (lisp_indirect_variable): Name an expression,
4554 to avoid gcc -Wbad-function-cast warning.
4555 (Fdefvar): Rename locals to avoid shadowing.
4556
4557 * callint.c (quotify_arg, quotify_args): Now static.
4558 (Fcall_interactively): Rename locals to avoid shadowing.
4559 Use const pointer when appropriate.
4560
4561 * lisp.h (get_system_name, get_operating_system_release):
4562 Move decls here, to check interfaces.
4563 * process.c (get_operating_system_release): Move decl to lisp.h.
4564 * xrdb.c (get_system_name): Likewise.
4565 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4566 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4567 some of which prompt warnings from gcc -Wbad-function-cast.
4568 (Fformat_time_string, Fencode_time, Finsert_char):
4569 (Ftranslate_region_internal, Fformat):
4570 Rename or remove local vars to avoid shadowing.
4571 (Ftranslate_region_internal): Mark var as initialized.
4572
4573 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4574 avoid shadowing.
4575
4576 * lisp.h (eassert): Check that the argument compiles, even if
4577 ENABLE_CHECKING is not defined.
4578
4579 * data.c (Findirect_variable): Name an expression, to avoid
4580 gcc -Wbad-function-cast warning.
4581 (default_value, arithcompare, arith_driver, arith_error): Now static.
4582 (store_symval_forwarding): Rename local to avoid shadowing.
4583 (Fmake_variable_buffer_local, Fmake_local_variable):
4584 Mark variables as initialized.
4585 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4586
4587 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4588 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4589 Rename locals to avoid shadowing.
4590 (mark_stack): Move local variables into the #ifdef region where
4591 they're used.
4592 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4593 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4594 needed otherwise.
4595 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4596 (GC_STRING_CHARS): Remove; not used.
4597 (Fmemory_limit): Cast sbrk's returned value to char *.
4598
4599 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4600 avoids undefined behavior in theory.
4601
4602 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4603
4604 Use functions, not macros, for up- and down-casing (Bug#8254).
4605 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4606 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4607 to use the following functions instead of these macros.
4608 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4609 EMACS_INT, since callers assume the returned value fits in int.
4610 (upcase1): Likewise, for UPCASE_TABLE.
4611 (uppercasep, lowercasep, upcase): New static inline functions.
4612 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4613 the race-condition problem in the old DOWNCASE.
4614
4615 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4616 Rename locals to avoid shadowing.
4617 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4618 (regex_compile, re_search_2, re_match_2_internal):
4619 Remove unused local vars.
4620 (FREE_VAR): Rewrite so as not to use empty "else",
4621 which gcc can warn about.
4622 (regex_compile, re_match_2_internal): Mark locals as initialized.
4623 (RETALLOC_IF): Define only if needed.
4624 (WORDCHAR_P): Likewise. This one is never needed, but is used
4625 only in a comment talking about a compiler bug, so put inside
4626 the #if 0 of that comment.
4627 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4628 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4629 Remove; unused.
4630
4631 * search.c (boyer_moore): Rename locals to avoid shadowing.
4632 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4633 (PREV_CHAR_BOUNDARY): Likewise.
4634
4635 * search.c (simple_search): Remove unused var.
4636
4637 * dired.c (compile_pattern): Move decl from here ...
4638 * lisp.h: ... to here, so that it can be checked.
4639 (struct re_registers): New forward decl.
4640
4641 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4642
4643 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4644 All uses changed.
4645 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4646 Rename locals to avoid shadowing.
4647 (Fvertical_motion): Mark locals as initialized.
4648
4649 * casefiddle.c (casify_object, casify_region): Now static.
4650 (casify_region): Mark local as initialized.
4651
4652 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4653
4654 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4655 New macros, so that the caller can use some names other than
4656 gcpro1, gcpro2, etc.
4657 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4658 of the new macros.
4659 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4660 argument, for consistency with GCPRO2_VAR, etc: it is now the
4661 prefix of the variable, not the variable itself. All uses
4662 changed.
4663 * dired.c (directory_files_internal, file_name_completion):
4664 Rename locals to avoid shadowing.
4665
4666 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4667 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4668 dired.c's scmp function, had undefined behavior.
4669 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4670 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4671 * buffer.h: ... to here, because these macros use current_buffer,
4672 and the new implementation with inline functions needs to have
4673 current_buffer in scope now, rather than later when the macros
4674 are used.
4675 (downcase, upcase1): New static inline functions.
4676 (DOWNCASE, UPCASE1): Reimplement using these functions.
4677 This avoids undefined behavior in expressions like
4678 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4679 from race conditions in accessing the global variables
4680 case_temp1 and case_temp2.
4681 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4682 * lisp.h (case_temp1, case_temp2): Remove their decls.
4683 * character.h (ASCII_CHAR_P): Move from here ...
4684 * lisp.h: ... to here, so that the inline functions mentioned
4685 above can use them.
4686
4687 * dired.c (directory_files_internal_unwind): Now static.
4688
4689 * fileio.c (file_name_as_directory, directory_file_name):
4690 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4691 Now static.
4692 (file_name_as_directory): Use const pointers when appropriate.
4693 (Fexpand_file_name): Likewise. In particular, newdir might
4694 point at constant storage, so make it a const pointer.
4695 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4696 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4697 signedness issues.
4698 (Fset_file_times, Finsert_file_contents, auto_save_error):
4699 Rename locals to avoid shadowing.
4700
4701 * minibuf.c (choose_minibuf_frame_1): Now static.
4702 (Ftry_completion, Fall_completions): Rename or remove locals
4703 to avoid shadowing.
4704
4705 * marker.c (bytepos_to_charpos): Remove; unused.
4706
4707 * lisp.h (verify_bytepos, count_markers): New decls,
4708 so that gcc does not warn that these functions aren't declared.
4709
4710 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4711 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4712 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4713 (copy_text): Remove unused local var.
4714
4715 * filelock.c (within_one_second): Now static.
4716 (lock_file_1): Rename local to avoid shadowing.
4717
4718 * buffer.c (fix_overlays_before): Mark locals as initialized.
4719 (fix_start_end_in_overlays): Likewise. This function should be
4720 simplified by using pointers-to-pointers, but that's a different
4721 matter.
4722 (switch_to_buffer_1): Now static.
4723 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4724 (report_overlay_modification): Rename locals to avoid shadowing.
4725
4726 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4727 Fix pointer signedness issue.
4728 (sys_subshell): Mark local as volatile if checking for lint,
4729 to suppress a gcc -Wclobbered warning that does not seem to be right.
4730 (MAXPATHLEN): Define only if needed.
4731
4732 * process.c (serial_open, serial_configure): Move decls from here ...
4733 * systty.h: ... to here, so that they can be checked.
4734
4735 * fns.c (get_random, seed_random): Move extern decls from here ...
4736 * lisp.h: ... to here, so that they can be checked.
4737
4738 * sysdep.c (reset_io): Now static.
4739 (wait_for_termination_signal): Remove; unused.
4740
4741 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4742 (copy_keymap_item, append_key, push_text_char_description):
4743 Now static.
4744 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4745 (DENSE_TABLE_SIZE): Remove; unused.
4746 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4747 (describe_map_tree):
4748 Rename locals to avoid shadowing.
4749
4750 * keyboard.c: Declare functions static if they are not used elsewhere.
4751 (echo_char, echo_dash, cmd_error, top_level_2):
4752 (poll_for_input, handle_async_input): Now static.
4753 (read_char, kbd_buffer_get_event, make_lispy_position):
4754 (make_lispy_event, make_lispy_movement, apply_modifiers):
4755 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4756 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4757 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4758 (read_key_sequence, read_char): Mark locals as initialized.
4759 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4760
4761 * keyboard.h (make_ctrl_char): New decl.
4762 (mark_kboards): Move decl here ...
4763 * alloc.c (mark_kboards): ... from here.
4764
4765 * lisp.h (force_auto_save_soon): New decl.
4766
4767 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4768 (DEFINE_DUMMY_FUNCTION): New macro.
4769 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4770 Use it.
4771 (main): Add casts to avoid warnings
4772 if GCC considers string literals to be constants.
4773
4774 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4775
4776 * dbusbind.c: Pointer signedness fixes.
4777 (xd_signature, xd_append_arg, xd_initialize):
4778 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4779 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4780 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4781 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4782
4783 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4784 if GCC considers string literals to be constants.
4785 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4786
4787 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4788
4789 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4790 (print_preprocess, print_object): New macro to fix last change.
4791
4792 * print.c (print_preprocess): Don't forget font objects.
4793
4794 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4795
4796 * emacs.c (USAGE3): Doc fixes.
4797
4798 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4799
4800 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4801 structure.
4802
4803 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4804
4805 * lisp.h (VWindow_system, Qfile_name_history):
4806 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4807 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4808 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4809
4810 * w32select.c: Don't #include "keyboard.h".
4811 (run_protected): Add extern declaration for waiting_for_input.
4812
4813 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4814 * w32console.c (detect_input_pending, read_input_pending)
4815 (encode_terminal_code):
4816 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4817 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4818 (w32_system_caret_y, Qfile_name_history):
4819 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4820 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4821 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4822 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4823 * w32proc.c (Qlocal, report_file_error):
4824 * w32term.c (Vwindow_system, updating_frame):
4825 * w32uniscribe.c (initialized, uniscribe_font_driver):
4826 Remove unneeded extern declarations.
4827
4828 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4829
4830 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4831
4832 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4833
4834 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4835 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4836 These macros can no longer be used for assignment.
4837
4838 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4839 Assign struct members directly, instead of using BUF_BEGV etc.
4840 (record_buffer_markers, fetch_buffer_markers): New functions for
4841 recording and fetching special buffer markers.
4842 (set_buffer_internal_1, set_buffer_temp): Use them.
4843
4844 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4845
4846 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4847
4848 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4849 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4850
4851 * xdisp.c (hscroll_window_tree):
4852 (reconsider_clip_changes): Use PT instead of BUF_PT.
4853
4854 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4855
4856 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4857 $(EMACS_ROOT)/lib/intprops.h.
4858
4859 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4860
4861 Fix more problems found by GCC 4.5.2's static checks.
4862
4863 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4864 to unsigned char * to avoid compiler diagnostic.
4865 (xg_free_frame_widgets): Make it clear that a local variable is
4866 needed only if USE_GTK_TOOLTIP.
4867 (gdk_window_get_screen): Make it clear that this macro is needed
4868 only if USE_GTK_TOOLTIP.
4869 (int_gtk_range_get_value): New function, which avoids a diagnostic
4870 from gcc -Wbad-function-cast.
4871 (xg_set_toolkit_scroll_bar_thumb): Use it.
4872 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4873 diagnostic from gcc -Wbad-function-cast.
4874 (get_utf8_string, xg_get_file_with_chooser):
4875 Rename locals to avoid shadowing.
4876 (create_dialog): Move locals to avoid shadowing.
4877
4878 * xgselect.c (xg_select): Remove unused var.
4879
4880 * image.c (four_corners_best): Mark locals as initialized.
4881 (gif_load): Initialize transparent_p to zero (Bug#8238).
4882 Mark another local as initialized.
4883 (my_png_error, my_error_exit): Mark with NO_RETURN.
4884
4885 * image.c (clear_image_cache): Now static.
4886 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4887 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4888 (x_edge_detection): Remove unnecessary cast that
4889 gcc -Wbad-function-cast diagnoses.
4890 (gif_load): Fix pointer signedness.
4891 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4892 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4893
4894 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4895
4896 Improve quality of tests for time stamp overflow.
4897 For example, without this patch (encode-time 0 0 0 1 1
4898 1152921504606846976) returns the obviously-bogus value (-948597
4899 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4900 reports time overflow. See
4901 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4902 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4903 * editfns.c: Include limits.h and intprops.h.
4904 (TIME_T_MIN, TIME_T_MAX): New macros.
4905 (time_overflow): Move earlier, to before first use.
4906 (hi_time, lo_time): New functions, for an accurate test for
4907 out-of-range times.
4908 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4909 (Fget_internal_run_time): Don't assume time_t fits in int.
4910 (make_time): Use list2 instead of Fcons twice.
4911 (Fdecode_time): More accurate test for out-of-range times.
4912 (check_tm_member): New function.
4913 (Fencode_time): Use it, to test for out-of-range times.
4914 (lisp_time_argument): Don't rely on undefined left-shift and
4915 right-shift behavior when checking for time stamp overflow.
4916
4917 * editfns.c (time_overflow): New function, refactoring common code.
4918 (Fformat_time_string, Fdecode_time, Fencode_time):
4919 (Fcurrent_time_string): Use it.
4920
4921 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4922 * dired.c (make_time): Move to ...
4923 * editfns.c (make_time): ... here.
4924 * systime.h: Note the move.
4925
4926 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4927
4928 * fringe.c (update_window_fringes): Remove unused variables.
4929
4930 * unexmacosx.c (copy_data_segment): Also copy __got section.
4931 (Bug#8223)
4932
4933 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4934
4935 * termcap.c [MSDOS]: Include "msdos.h".
4936 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4937 Constify `char *' arguments and their references according to
4938 prototypes in tparam.h.
4939
4940 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4941
4942 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4943 Adapt all references accordingly.
4944
4945 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4946
4947 2011-03-11 Tom Tromey <tromey@redhat.com>
4948
4949 * buffer.c (syms_of_buffer): Remove obsolete comment.
4950
4951 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4952
4953 * termhooks.h (encode_terminal_code): Declare prototype.
4954
4955 * msdos.c (encode_terminal_code): Don't declare prototype.
4956
4957 * term.c (encode_terminal_code): Now external again, used by
4958 w32console.c and msdos.c.
4959
4960 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4961 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4962
4963 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4964
4965 Fix some minor problems found by GCC 4.5.2's static checks.
4966
4967 * fringe.c (update_window_fringes): Mark locals as initialized
4968 (Bug#8227).
4969 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4970
4971 * alloc.c (mark_fringe_data): Move decl from here ...
4972 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4973 to check its interface.
4974 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4975
4976 * fontset.c (free_realized_fontset): Now static.
4977 (Fset_fontset_font): Rename local to avoid shadowing.
4978 (fontset_font): Mark local as initialized.
4979 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4980
4981 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4982
4983 * xselect.c (x_disown_buffer_selections): Remove; not used.
4984 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4985 (x_own_selection, Fx_disown_selection_internal): Rename locals
4986 to avoid shadowing.
4987 (x_handle_dnd_message): Remove local to avoid shadowing.
4988
4989 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4990 so that the caller can use some name other than gcpro1.
4991 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4992 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4993 (Fx_backspace_delete_keys_p):
4994 Use them to avoid shadowing, and rename vars to avoid shadowing.
4995 (x_decode_color, x_set_name, x_window): Now static.
4996 (Fx_create_frame): Add braces to silence GCC warning.
4997 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4998 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4999 Remove unused locals.
5000 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5001 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5002 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5003 macros.
5004
5005 * xterm.h (x_mouse_leave): New decl.
5006
5007 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5008 Remove unused functions.
5009 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5010 (x_calc_absolute_position): Now static.
5011 (XTread_socket): Don't define label "out" unless it's used.
5012 Don't declare local "event" unless it's used.
5013 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5014 unless they are used.
5015 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5016 (x_fatal_error_signal): Remove; not used.
5017 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5018 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5019 (x_error_catcher, x_connection_closed, x_error_handler):
5020 (x_error_quitter, xembed_send_message, x_iconify_frame):
5021 (my_log_handler): Rename locals to avoid shadowing.
5022 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5023 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5024
5025 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5026 Rename or move locals to avoid shadowing.
5027 (tty_defined_color, merge_face_heights): Now static.
5028 (free_realized_faces_for_fontset): Remove; not used.
5029 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5030 does not deduce is never used uninitialized.
5031 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5032 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5033
5034 * terminal.c (store_terminal_param): Now static.
5035
5036 * xmenu.c (menu_highlight_callback): Now static.
5037 (set_frame_menubar): Remove unused local.
5038 (xmenu_show): Rename parameter to avoid shadowing.
5039 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5040 since they might point to immutable storage.
5041 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5042 since it's unused otherwise.
5043
5044 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5045 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5046 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5047 avoids a gcc -Wuninitialized diagnostic.
5048 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5049 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5050 does not deduce are never used uninitialized.
5051
5052 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5053
5054 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5055 * window.c (window_loop, size_window):
5056 (run_window_configuration_change_hook, enlarge_window): Likewise.
5057
5058 * window.c (display_buffer): Now static.
5059 (size_window): Mark variables that gcc -Wuninitialized
5060 does not deduce are never used uninitialized.
5061 * window.h (check_all_windows): New decl, to forestall
5062 gcc -Wmissing-prototypes diagnostic.
5063 * dispextern.h (bidi_dump_cached_states): Likewise.
5064
5065 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5066 shadowing.
5067 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5068 Include <limits.h>.
5069 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5070 and to avoid gcc -Wuninitialized warning.
5071 (load_charset_map): Mark variables that gcc -Wuninitialized
5072 does not deduce are never used uninitialized.
5073 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5074
5075 * coding.c (coding_set_source, coding_set_destination):
5076 Use "else { /* comment */ }" rather than "else /* comment */;"
5077 for clarity, and to avoid gcc -Wempty-body warning.
5078 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5079 a block, when the outer 'i' will do.
5080 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5081 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5082 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5083 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5084 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5085 Rename locals to avoid shadowing.
5086 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5087 * coding.c (emacs_mule_char, encode_invocation_designation):
5088 Now static, since they're not used elsewhere.
5089 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5090 (decode_coding_object, encode_coding_object, detect_coding_system):
5091 (decode_coding_emacs_mule): Mark variables that gcc
5092 -Wuninitialized does not deduce are never used uninitialized.
5093 (detect_coding_iso_2022): Initialize a local variable that might
5094 be used uninitialized. Leave a FIXME because it's not clear that
5095 this initialization is needed. (Bug#8211)
5096 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5097 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5098 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5099 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5100 Remove unused macros.
5101
5102 * category.c (hash_get_category_set): Remove unused local var.
5103 (copy_category_table): Now static, since it's not used elsewhere.
5104 * character.c (string_count_byte8): Likewise.
5105
5106 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5107 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5108
5109 * chartab.c (copy_sub_char_table): Now static, since it's not used
5110 elsewhere.
5111 (sub_char_table_ref_and_range, char_table_ref_and_range):
5112 Rename locals to avoid shadowing.
5113 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5114
5115 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5116 (BIDI_BOB): Remove unused macro.
5117
5118 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5119 deduce are never used uninitialized.
5120 * term.c (encode_terminal_code): Likewise.
5121
5122 * term.c (encode_terminal_code): Now static. Remove unused local.
5123
5124 * tparam.h: New file.
5125 * term.c, tparam.h: Include it.
5126 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5127 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5128 Move these decls to tparam.h, and make them agree with what
5129 is actually in tparam.c. The previous trick of using incompatible
5130 decls in different modules does not conform to the C standard.
5131 All callers of tparam changed to use tparam's actual API.
5132 * tparam.c (tparam1, tparam, tgoto):
5133 Use const pointers where appropriate.
5134
5135 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5136 * cm.h (struct cm): Likewise.
5137 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5138 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5139 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5140 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5141 (turn_on_face, init_tty): Likewise.
5142 * termchar.h (struct tty_display_info): Likewise.
5143
5144 * term.c (term_mouse_position): Rename local to avoid shadowing.
5145
5146 * alloc.c (mark_ttys): Move decl from here ...
5147 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5148
5149 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5150
5151 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5152
5153 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5154
5155 * search.c (compile_pattern_1): Remove argument regp, unused since
5156 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5157 (compile_pattern): Don't pass it.
5158
5159 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5160
5161 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5162 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5163 for ! HAVE_GTK3.
5164 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5165
5166 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5167
5168 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5169 gdk_window_get_screen, gdk_window_get_geometry,
5170 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5171 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5172 (xg_get_pixbuf_from_pixmap): New function.
5173 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5174 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5175 Call xg_get_pixbuf_from_pixmap instead of
5176 gdk_pixbuf_get_from_drawable.
5177 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5178 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5179 (xg_check_special_colors): Use GtkStyleContext and its functions
5180 for HAVE_GTK3.
5181 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5182 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5183 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5184 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5185 Call gtk_widget_get_preferred_size.
5186 (xg_frame_resized): gdk_window_get_geometry only takes 5
5187 parameters.
5188 (xg_win_to_widget, xg_event_is_for_menubar):
5189 Call gdk_x11_window_lookup_for_display.
5190 (xg_set_widget_bg): New function.
5191 (delete_cb): New function.
5192 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5193 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5194 (xg_set_background_color): Call xg_set_widget_bg.
5195 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5196 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5197 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5198 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5199 if ! HAVE_GTK3.
5200 (update_frame_tool_bar): Call gtk_widget_hide.
5201 (xg_initialize): Use GDK_KEY_g.
5202
5203 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5204 if ! HAVE_GTK3
5205 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5206
5207 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5208 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5209 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5210
5211 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5212
5213 * w32xfns.c (select_palette): Check success of RealizePalette against
5214 GDI_ERROR, not zero.
5215
5216 See ChangeLog.11 for earlier changes.
5217
5218 ;; Local Variables:
5219 ;; coding: utf-8
5220 ;; End:
5221
5222 Copyright (C) 2011 Free Software Foundation, Inc.
5223
5224 This file is part of GNU Emacs.
5225
5226 GNU Emacs is free software: you can redistribute it and/or modify
5227 it under the terms of the GNU General Public License as published by
5228 the Free Software Foundation, either version 3 of the License, or
5229 (at your option) any later version.
5230
5231 GNU Emacs is distributed in the hope that it will be useful,
5232 but WITHOUT ANY WARRANTY; without even the implied warranty of
5233 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5234 GNU General Public License for more details.
5235
5236 You should have received a copy of the GNU General Public License
5237 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.