1 2012-03-21 Chong Yidong <cyd@gnu.org>
3 * xfaces.c (Vface_remapping_alist): Doc fix.
5 2012-03-20 Eli Zaretskii <eliz@gnu.org>
7 * w32proc.c (Fw32_set_console_codepage)
8 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset): Doc
11 2012-03-20 Chong Yidong <cyd@gnu.org>
13 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
14 to reflect default non-nil value of redisplay-dont-pause.
16 2012-03-19 Kenichi Handa <handa@m17n.org>
18 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
19 it fit in a valid range (Bug#11003).
21 2012-03-18 Eli Zaretskii <eliz@gnu.org>
23 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
24 that is not from display property, accept the row as a "cursor
25 row" if one of the string's character has a non-nil `cursor'
26 property. Fixes cursor positioning when there are newlines in
27 overlay strings, e.g. in icomplete.el. (Bug#11035)
29 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
31 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
33 2012-03-12 Chong Yidong <cyd@gnu.org>
35 * eval.c (inhibit_lisp_code): Rename from
36 inhibit_window_configuration_change_hook; move from window.c.
38 * xfns.c (unwind_create_frame_1, Fx_create_frame):
39 * window.c (run_window_configuration_change_hook)
40 (syms_of_window): Callers changed.
42 2012-03-11 Chong Yidong <cyd@gnu.org>
44 * keymap.c (Fkey_description): Doc fix (Bug#9700).
46 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
48 2012-03-10 Chong Yidong <cyd@gnu.org>
50 * frame.c (other_visible_frames): Don't assume the selected frame
51 is visible (Bug#10955).
53 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
55 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
57 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
59 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
60 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
63 2012-03-03 Glenn Morris <rgm@gnu.org>
65 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
67 2012-03-02 Eli Zaretskii <eliz@gnu.org>
69 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
70 position past the first glyph_row that ends at ZV. (Bug#10902)
71 (redisplay_window, next_element_from_string): Fix typos in
73 (redisplay_window): Pass to move_it_vertically the margin in
74 pixels, not in screen lines.
76 2012-03-02 Glenn Morris <rgm@gnu.org>
78 * buffer.c (buffer-list-update-hook): Doc fix.
80 2012-02-29 Eli Zaretskii <eliz@gnu.org>
82 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
83 push_it before setting up the iterator for the first overlay
84 string, even if we have an empty string loaded.
85 (next_overlay_string): If there's an empty string on the iterator
86 stack, pop the stack. (Bug#10903)
88 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
90 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
91 Suggested by Stefan Monnier in
92 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
93 * alloc.c (widen_to_Lisp_Object): New static function.
94 (mark_memory): Also mark Lisp_Objects by fetching pointer words
95 and widening them to Lisp_Objects. This would work even if
96 USE_LSB_TAG is defined and wide integers are used, which might
97 happen in a future version of Emacs.
99 2012-02-25 Chong Yidong <cyd@gnu.org>
101 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
104 * xselect.c (Fx_selection_exists_p): Doc fix.
105 (x_clipboard_manager_save_all): Print an informative message
106 before saving to clipboard manager.
108 2012-02-24 Chong Yidong <cyd@gnu.org>
110 * keyboard.c (process_special_events): Handle all X selection
111 requests in kbd_buffer, not just the next one (Bug#8869).
113 2012-02-23 Chong Yidong <cyd@gnu.org>
115 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
116 call when setting menu-bar-lines and tool-bar-lines parameters.
117 (unwind_create_frame_1): New helper function.
119 * window.c (inhibit_window_configuration_change_hook): New var.
120 (run_window_configuration_change_hook): Obey it.
121 (syms_of_window): Initialize it.
123 2012-02-22 Chong Yidong <cyd@gnu.org>
125 * xterm.c (x_draw_image_relief): Add missing type check for
126 Vtool_bar_button_margin (Bug#10743).
128 2012-02-21 Chong Yidong <cyd@gnu.org>
130 * fileio.c (Vfile_name_handler_alist): Doc fix.
132 * buffer.c (Fget_file_buffer): Protect against invalid file
133 handler return value.
135 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
137 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
138 when computing $valmask.
140 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
141 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
142 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
143 It's useless in that case, and it can cause problems on hosts
144 that allocate halves of EMACS_INT values separately.
145 Reported by Dan Horák. Diagnosed by Andreas Schwab in
146 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
147 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
148 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
149 it avoids undefined behavior on hosts where shifting right by more
150 than the word width has undefined behavior.
152 2012-02-19 Chong Yidong <cyd@gnu.org>
154 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
155 (Funhandled_file_name_directory, Ffile_name_as_directory)
156 (Fdirectory_file_name, Fexpand_file_name)
157 (Fsubstitute_in_file_name): Protect against invalid file handler
158 return values (Bug#10845).
160 2012-02-18 Eli Zaretskii <eliz@gnu.org>
162 * .gdbinit (pitx): Fix incorrect references to fields of the
165 2012-02-17 Chong Yidong <cyd@gnu.org>
167 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
169 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
171 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
172 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
174 2012-02-15 Chong Yidong <cyd@gnu.org>
176 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
177 marked as special. Also, starting docstrings with * is obsolete.
179 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
181 * gnutls.c (emacs_gnutls_write): Fix last change.
183 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
185 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
188 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
190 * keymap.c (Fsingle_key_description): Handle char ranges.
192 2012-02-12 Chong Yidong <cyd@gnu.org>
194 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
195 as that creates a dangerous corner case.
197 * window.c (Fdelete_window_internal): Invalidate the mouse
198 highlight (Bug#9904).
200 2012-02-12 Glenn Morris <rgm@gnu.org>
202 * xselect.c (Fx_own_selection_internal)
203 (Fx_get_selection_internal, Fx_disown_selection_internal)
204 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
205 * nsselect.m (Fx_own_selection_internal)
206 (Fx_disown_selection_internal, Fx_selection_exists_p)
207 (Fx_selection_owner_p, Fx_get_selection_internal):
208 Sync docs and argument specs with the xselect.c versions.
210 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
212 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
214 2012-02-11 Eli Zaretskii <eliz@gnu.org>
216 * w32select.c (Fx_selection_exists_p): Sync doc string and
217 argument list with xselect.c. (Bug#10783)
219 * w16select.c (Fx_selection_exists_p): Sync doc string and
220 argument list with xselect.c. (Bug#10783)
222 2012-02-10 Glenn Morris <rgm@gnu.org>
224 * fns.c (Fsecure_hash): Doc fix.
226 2012-02-09 Kenichi Handa <handa@m17n.org>
228 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
230 2012-02-07 Chong Yidong <cyd@gnu.org>
232 * buffer.c (Fbuffer_local_variables)
233 (buffer_lisp_local_variables): Handle unbound vars correctly;
234 don't let Qunbound leak into Lisp.
236 2012-02-07 Glenn Morris <rgm@gnu.org>
238 * image.c (Fimagemagick_types): Doc fix.
240 * image.c (imagemagick-render-type): Change it from a lisp object
241 to an integer. Move the doc here from the lisp manual.
242 Treat all values not equal to 0 the same.
244 2012-02-06 Chong Yidong <cyd@gnu.org>
246 * doc.c (store_function_docstring): Avoid applying docstring of
247 alias to base function (Bug#2603).
249 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
251 * .gdbinit (pp1, pv1): Remove redundant defines.
254 2012-02-04 Chong Yidong <cyd@gnu.org>
256 * nsterm.m: Declare a global (Bug#10694).
258 2012-02-04 Eli Zaretskii <eliz@gnu.org>
260 * w32.c (get_emacs_configuration_options):
261 Include --enable-checking, if specified, in the return value.
263 2012-02-04 Martin Rudalics <rudalics@gmx.at>
265 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
266 after rounding frame sizes. (Bug#9723)
268 2012-02-04 Eli Zaretskii <eliz@gnu.org>
270 * keyboard.c (adjust_point_for_property): Don't position point
271 before BEGV. (Bug#10696)
273 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
275 Handle overflow when computing char display width (Bug#9496).
276 * character.c (char_width): Return EMACS_INT, not int.
277 (char_width, c_string_width): Check for overflow when
278 computing the width; this is possible now that individual
279 characters can have unbounded width. Problem introduced
280 by merge from Emacs 23 on 2012-01-19.
282 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
284 * dbusbind.c (Fdbus_register_method): Mention the return value
285 :ignore in the docstring.
287 2012-02-02 Glenn Morris <rgm@gnu.org>
289 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
291 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
292 Unconditionally set to t. (Bug#10673)
293 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
294 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
295 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
297 2012-02-02 Kenichi Handa <handa@m17n.org>
299 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
300 0, do not call append_composite_glyph.
302 2012-02-02 Kenichi Handa <handa@m17n.org>
304 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
306 (x_produce_glyphs): If the component of a composition is a null
307 string, set it->pixel_width to 1 to avoid zero-width glyph.
309 2012-02-01 Eli Zaretskii <eliz@gnu.org>
311 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
312 first 2 arguments are identical. This makes inserting large
313 output from a subprocess an order of magnitude faster on
314 MS-Windows, where all sbrk'ed memory is always contiguous.
316 2012-01-31 Glenn Morris <rgm@gnu.org>
318 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
319 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
320 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
322 2012-01-29 Glenn Morris <rgm@gnu.org>
324 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
326 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
328 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
330 2012-01-28 Chong Yidong <cyd@gnu.org>
332 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
334 2012-01-26 Chong Yidong <cyd@gnu.org>
336 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
338 * search.c (Fsearch_forward, Fsearch_backward): Document negative
339 repeat counts (Bug#10507).
341 2012-01-26 Glenn Morris <rgm@gnu.org>
343 * lread.c (syms_of_lread): Doc fix.
345 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
347 * coding.c (encode_designation_at_bol): Change return value to
350 2012-01-25 Chong Yidong <cyd@gnu.org>
352 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
354 2012-01-21 Chong Yidong <cyd@gnu.org>
356 * floatfns.c (Fcopysign): Make the second argument non-optional,
357 since nil is not allowed anyway.
359 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
361 * process.c (read_process_output): Use p instead of XPROCESS (proc).
362 (send_process): Likewise.
364 2012-01-19 Martin Rudalics <rudalics@gmx.at>
366 * window.c (save_window_save, Fcurrent_window_configuration)
367 (Vwindow_persistent_parameters): Do not use Qstate.
370 2012-01-19 Kenichi Handa <handa@m17n.org>
372 * character.c (char_width): New function.
373 (Fchar_width, c_string_width, lisp_string_width):
374 Use char_width (Bug#9496).
376 2012-01-16 Martin Rudalics <rudalics@gmx.at>
378 * window.c (Vwindow_persistent_parameters): New variable.
379 (Fset_window_configuration, save_window_save): Handle persistent
382 2012-01-14 Eli Zaretskii <eliz@gnu.org>
384 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
385 thrashing the stack of the thread. (Bug#9087)
387 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
389 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
391 2012-01-11 Eli Zaretskii <eliz@gnu.org>
393 * xdisp.c (rows_from_pos_range): Handle the case where the
394 highlight ends on a newline. (Bug#10464)
395 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
396 he end column for display of highlight that ends on a newline
399 2012-01-11 Glenn Morris <rgm@gnu.org>
401 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
402 from load-path also when installation-directory is nil. (Bug#10208)
404 2012-01-10 Glenn Morris <rgm@gnu.org>
406 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
408 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
409 Update template values to be closer to their typical values these days.
411 2012-01-09 Eli Zaretskii <eliz@gnu.org>
413 * xdisp.c (rows_from_pos_range): Accept additional argument
414 DISP_STRING, and accept any glyph in a row whose object is that
415 string as eligible for mouse highlight. Fixes mouse highlight of
416 display strings from overlays. (Bug#10464)
418 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
420 emacs: fix an auto-save permissions race condition (Bug#10400)
421 * fileio.c (auto_saving_dir_umask): New static var.
422 (Fmake_directory_internal): Use it.
423 (do_auto_save_make_dir): Set it, instead of invoking chmod after
424 creating the directory. The old code temporarily assigns
425 too-generous permissions to the directory.
426 (do_auto_save_eh): Clear it.
427 (Fdo_auto_save): Catch all errors, not just file errors, so
428 that the var is always cleared.
430 2012-01-07 Eli Zaretskii <eliz@gnu.org>
432 * search.c (scan_buffer): Pass character positions to
433 know_region_cache, not byte positions. (Bug#6540)
435 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
437 * w32.c (sys_rename): Report EXDEV when rename of a directory
438 fails because the target is on another logical disk. (Bug#10284)
440 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
442 * xterm.c (x_embed_request_focus): New function.
444 * xterm.h: Add prototype.
446 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
448 2012-01-05 Glenn Morris <rgm@gnu.org>
450 * emacs.c (emacs_copyright): Update short copyright year to 2012.
452 2012-01-01 Eli Zaretskii <eliz@gnu.org>
454 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
455 Load gnutls_transport_set_lowat only if GnuTLS version is below
457 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
458 GnuTLS versions below 2.11.1.
460 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
462 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
463 to the doc string advising against its use for altering the way
464 windows are scrolled.
466 2011-12-28 Kenichi Handa <handa@m17n.org>
468 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
469 coding-system ASCII compatible only when it does not produce BOM
470 on encoding (Bug#10383).
472 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
474 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
476 (create_and_show_popup_menu): Always use menu_position_func for
479 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
481 * callint.c (Fcall_interactively): Don't truncate prompt string.
483 2011-12-23 Eli Zaretskii <eliz@gnu.org>
485 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
486 property that ends at ZV, so that the bidi iteration could be
487 resumed from there (after widening). (Bug#10360)
489 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
491 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
493 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
495 * nsterm.m (x_free_frame_resources):
496 Release f->output_data.ns->miniimage.
497 (ns_index_color): Fix indentation. Do not retain
498 color_table->colors[i].
500 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
503 * nsfns.m (x_set_background_color): Assign return value from
504 ns_index_color to face-background instead of NSColor*.
505 (ns_implicitly_set_icon_type): Fix indentation.
506 Change assignment in for loop to comparison.
508 * emacs.c (ns_pool): New variable.
509 (main): Assign ns_pool.
510 (Fkill_emacs): Call ns_release_autorelease_pool.
512 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
513 autorelease fdesc, release fdAttrs and tdict.
514 (ns_get_covering_families): Release charset.
515 (ns_findfonts): Release NSFontDescriptor created with new.
516 (ns_uni_to_glyphs): Fix indentation.
517 (setString): Release attrStr before assigning new value.
519 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
521 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
523 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
524 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
526 2011-12-18 David Reitter <reitter@cmu.edu>
528 * nsterm.m (ns_term_init): Subscribe for notifications
529 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
530 to method trackingNotification in EmacsMenu.
532 * nsmenu.m (trackingMenu): New variable.
533 (trackingNotification): New method (from Aquamacs).
534 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
535 from Aquamacs (Bug#7030).
537 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
539 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
540 (symbol_to_nsstring): Fix indentation.
541 (ns_symbol_to_pb): New function.
542 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
543 (Fns_rotate_cut_buffers_internal): Remove.
544 (Fns_store_selection_internal): Rename from
545 Fns_store_cut_buffer_internal.
546 (ns_get_foreign_selection, Fx_own_selection_internal)
547 (Fx_disown_selection_internal, Fx_selection_exists_p)
548 (Fns_get_selection_internal, Fns_store_selection_internal):
549 Use ns_symbol_to_pb and check if return value is nil.
550 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
551 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
552 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
553 renamed to Sns_store_selection_internal.
554 (ns_handle_selection_request): Move code to Fx_own_selection_internal
555 and remove this function.
556 (ns_handle_selection_clear): Remove, never used.
557 (Fx_own_selection_internal): Move code from ns_handle_selection_request
560 2011-12-17 Ken Brown <kbrown@cornell.edu>
562 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
563 GID is unknown (Bug#10257).
565 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
567 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
568 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
569 which caused a build failure on GNU/Linux IA-64. This problem was
570 introduced by my 2011-10-07 patch.
572 2011-12-15 Juri Linkov <juri@jurta.org>
574 * image.c (imagemagick_error): New function. (Bug#10112)
575 (imagemagick_load_image): Comment out `MagickSetResolution' call.
576 Use `imagemagick_error' where ImageMagick functions return
578 (Fimagemagick_types): Add `Fnreverse' to return the list in the
581 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
583 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
584 fill background (Bug#8992).
586 2011-12-13 Martin Rudalics <rudalics@gmx.at>
588 * window.c (Vwindow_combination_resize)
589 (Vwindow_combination_limit): Use t instead of non-nil in
591 (Vrecenter_redisplay): Add first sentence of doc-string on
593 (Frecenter): Fix doc-string typo.
595 2011-12-11 Kenichi Handa <handa@m17n.org>
597 * coding.c (Funencodable_char_position): Pay attention to the
598 buffer text relocation (Bug#9389).
600 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
602 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
603 gtk_init (Bug#10100).
605 2011-12-10 Eli Zaretskii <eliz@gnu.org>
607 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
608 IT->string is nil. (Bug#10263)
610 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
612 * nsterm.h (x_free_frame_resources): Declare.
614 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
615 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
617 * nsterm.h (ns_get_defaults_value): Declare.
619 * nsterm.m (ns_default): Call ns_get_defaults_value.
621 2011-12-09 Eli Zaretskii <eliz@gnu.org>
623 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
626 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
628 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
629 that where the value of an _OBJC_* symbol points to is in the .bss
632 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
634 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
635 after the loop to call ccl_driver at least once (Bug#8619).
637 2011-12-08 Kenichi Handa <handa@m17n.org>
639 * ftfont.c (get_adstyle_property): Fix previous change
642 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
644 * w32.c (init_environment): If no_site_lisp, remove site-lisp
645 dirs from the default value of EMACSLOADPATH (bug#10208).
647 2011-12-07 Glenn Morris <rgm@gnu.org>
649 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
650 installation and source directories as well. (Bug#10208)
652 2011-12-06 Chong Yidong <cyd@gnu.org>
654 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
656 2011-12-06 Glenn Morris <rgm@gnu.org>
658 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
659 as an error, not just -1. (Bug#10217)
661 2011-12-05 Chong Yidong <cyd@gnu.org>
663 * keyboard.c (process_special_events): New function.
664 (swallow_events, Finput_pending_p): Use it (Bug#10195).
666 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
668 * coding.c (encode_designation_at_bol): Don't use uninitialized
669 local variable (Bug#9318).
671 2011-12-05 Kenichi Handa <handa@m17n.org>
673 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
674 return Qnil (Bug#8046, Bug#10193).
676 2011-12-05 Kenichi Handa <handa@m17n.org>
678 * coding.c (encode_designation_at_bol): New args charbuf_end and
679 dst. Return the number of produced bytes. Callers changed.
680 (coding_set_source): Return how many bytes coding->source was
682 (coding_set_destination): Return how many bytes
683 coding->destination was relocated.
684 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
685 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
687 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
689 * coding.c (CODING_CHAR_CHARSET_P): New macro.
690 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
693 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
695 The following changes are to fix Bug#9318.
697 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
698 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
699 (encode_coding_iso_2022, encode_coding_sjis)
700 (encode_coding_big5, encode_coding_charset): Use the above macros.
702 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
704 * lisp.h (process_quit_flag): Fix external declaration.
706 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
708 Don't macro-inline non-performance-critical code.
709 * eval.c (process_quit_flag): New function.
710 * lisp.h (QUIT): Use it.
712 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
714 * nsfns.m (get_geometry_from_preferences): New function.
715 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
717 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
719 * emacs.c (Qkill_emacs): Define.
720 (syms_of_emacs): Initialize it.
721 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
722 Qquit_flag to `kill-emacs' instead.
723 (quit_throw_to_read_char): Add parameter `from_signal'.
724 All callers changed. Call Fkill_emacs if requested and safe.
725 * lisp.h (QUIT): Call Fkill_emacs if requested.
727 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
729 * widget.c (update_wm_hints): Return if wmshell is null.
730 (widget_update_wm_size_hints): New function.
732 * widget.h (widget_update_wm_size_hints): Declare.
734 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
735 widget_update_wm_size_hints (Bug#10104).
737 2011-12-03 Eli Zaretskii <eliz@gnu.org>
739 * xdisp.c (handle_invisible_prop): If the invisible text ends just
740 before a newline, prepare the bidi iterator for consuming the
741 newline, and keep the current paragraph direction. (Bug#10183)
742 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
744 2011-12-02 Juri Linkov <juri@jurta.org>
746 * search.c (Fword_search_regexp): New Lisp function created from
747 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
748 (Fword_search_backward, Fword_search_forward)
749 (Fword_search_backward_lax, Fword_search_forward_lax):
750 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
751 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
753 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
755 * fileio.c (Finsert_file_contents): Move after-change-function call
756 to before the "handled:" label, since all "goto handled" appear in
757 cases where the *-change-functions have already been properly called
760 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
762 * keyboard.c (interrupt_signal): Don't call kill-emacs when
763 waiting for input. (Bug#10169)
765 2011-11-30 Eli Zaretskii <eliz@gnu.org>
767 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
768 verifies glyph row's hash code--we have just reallocated the
769 glyphs, so their contents can be complete garbage. (Bug#10164)
771 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
773 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
775 2011-11-30 Eli Zaretskii <eliz@gnu.org>
777 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
778 attributes are tested _before_ calling verify_row_hash, to protect
779 against GCC re-ordering of the tests. (Bug#10164)
781 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
783 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
785 * xterm.c (handle_one_xevent): Only set async_visible and friends
786 if net_wm_state_hidden_seen is non-zero (Bug#10002)
787 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
788 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
790 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
792 Remove GCPRO-related macros that exist only to avoid shadowing locals.
793 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
794 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
795 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
796 All uses changed to use GCPRO1 etc.
797 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
798 Revert to old implementation (i.e., before 2011-03-11).
800 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
802 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
803 of scroll runs so as to avoid assigning disabled bogus rows and
804 unnecessary graphics copy operations.
806 2011-11-27 Eli Zaretskii <eliz@gnu.org>
808 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
809 (snprintf) [_MSC_VER]: Redirect to _snprintf.
810 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
811 (malloc, free, realloc, calloc): Redirect to e_* only when
814 * lisp.h (GCTYPEBITS): Move before first use.
815 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
816 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
817 this macro definition.
819 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
822 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
824 * gtkutil.c (xg_create_frame_widgets):
825 Call gtk_window_set_has_resize_grip (FALSE) if that function is
826 present with Gtk+ 2.0.
828 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
830 * fileio.c (Finsert_file_contents): Undo previous change; see
831 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
833 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
835 Rename locals to avoid shadowing.
836 * fileio.c (Finsert_file_contents):
837 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
838 * process.c (wait_reading_process_output):
839 Rename inner 'proc' to 'p' to avoid shadowing.
840 Indent for consistency with usual Emacs style.
842 2011-11-25 Eli Zaretskii <eliz@gnu.org>
844 * xdisp.c (redisplay_window): If cursor row is not fully visible
845 after recentering, and scroll-conservatively is set to a large
846 number, scroll window by a few more lines to make the cursor fully
847 visible and out of scroll-margin. (Bug#10105)
848 (start_display): Don't move to the next line if the display should
849 start at a newline that is part of a display vector or an overlay
852 2011-11-24 Juri Linkov <juri@jurta.org>
854 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
855 after the `MagickPingImage' call. (Bug#10112)
857 2011-11-23 Chong Yidong <cyd@gnu.org>
859 * window.c (Fcoordinates_in_window_p): Accept only live windows.
861 2011-11-23 Martin Rudalics <rudalics@gmx.at>
863 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
864 making another buffer current. (Bug#10114)
866 2011-11-23 Glenn Morris <rgm@gnu.org>
868 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
870 2011-11-23 Chong Yidong <cyd@gnu.org>
872 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
875 2011-11-22 Eli Zaretskii <eliz@gnu.org>
877 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
878 and header-lines, as they don't have one computed for them.
881 * .gdbinit (prow): Make displayed values more self-explaining.
884 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
886 * process.c (wait_reading_process_output): Fix asynchrounous
887 GnuTLS socket handling on some versions of the GnuTLS library.
888 (wait_reading_process_output): Add comment and URL.
890 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
892 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
894 2011-11-21 Chong Yidong <cyd@gnu.org>
896 * window.c (Fnext_window, Fprevious_window): Doc fix.
898 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
900 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
902 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
904 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
906 2011-11-20 Martin Rudalics <rudalics@gmx.at>
908 * window.c (Fset_window_combination_limit): Rename argument
910 (Vwindow_combination_limit): Remove "status" from doc-string.
912 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
914 * m/ibms390.h: Remove.
915 * m/ibms390x.h: Don't include "ibms390.h".
917 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
919 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
920 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
922 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
924 * casetab.c (Fset_case_table):
925 * charset.c (Fcharset_after): Fix typos.
927 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
929 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
930 Otherwise, valgrind does not work on some platforms.
931 Problem reported by Andreas Schwab in
932 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
933 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
934 is set, removing the need for VIRT_ADDRESS_VARIES.
935 (PURE_P): Use a more-efficient implementation that needs just one
936 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
937 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
938 to 4 (xorl, subq, cmpq, setbe).
939 * alloc.c (pure): Always extern now, since that's the
940 VIRT_ADDR_VARIES behavior.
941 (PURE_POINTER_P): Use a single comparison, not two, for
942 consistency with the new puresize.h.
943 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
944 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
945 Remove VIRT_ADDR_VARIES no longer needed.
947 2011-11-19 Eli Zaretskii <eliz@gnu.org>
949 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
950 (erase_phys_cursor, update_window_cursor, show_mouse_face)
951 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
952 behave as if the cursor position were at the window margin.
954 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
955 and the cursor position is out of bounds, behave as if the cursor
956 position were at the window margin. (Bug#10075)
958 2011-11-18 Chong Yidong <cyd@gnu.org>
960 * window.c (Fwindow_combination_limit): Make first argument
961 non-optional, since it is meaningless for live windows like the
964 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
966 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
968 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
970 * intervals.c: Fix grafting over the whole buffer (bug#10071).
971 (graft_intervals_into_buffer): Simplify.
973 2011-11-18 Eli Zaretskii <eliz@gnu.org>
975 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
976 hash values of the two rows.
977 (copy_row_except_pointers): Preserve the used[] arrays and the
978 hash values of the two rows. (Bug#10035)
979 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
981 * xdisp.c (row_hash): New function, body extracted from
982 compute_line_metrics.
983 (compute_line_metrics): Call row_hash, instead of computing the
986 * dispnew.c (verify_row_hash): Call row_hash for computing the
987 hash code of a row, instead of duplicating code from xdisp.c.
989 * dispextern.h (row_hash): Add prototype.
991 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
993 * frame.c (delete_frame): Don't delete the terminal when the last
994 X frame is closed if emacs is built with GTK toolkit.
996 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
998 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1000 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1002 * window.c (Vwindow_splits): Rename to
1003 Vwindow_combination_resize. Suggested by Juri Linkov.
1004 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1007 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1009 * nsfns.m (Fns_font_name):
1010 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1012 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1014 * window.h (window): Rename slot "nest" to "combination_limit".
1015 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1016 (Fset_window_nest): Rename to Fset_window_combination_limit.
1017 (Vwindow_nest): Rename to Vwindow_combination_limit.
1018 (recombine_windows, make_parent_window, make_window)
1019 (Fsplit_window_internal, saved_window)
1020 (Fset_window_configuration, save_window_save): Rename all
1021 occurrences of window_nest to window_combination_limit.
1023 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1025 * image.c (imagemagick_load_image): Fix typo.
1027 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1029 * xdisp.c (display_line): Move the call to
1030 highlight_trailing_whitespace before the call to
1031 compute_line_metrics, since the latter needs to see the final
1032 faces of all the glyphs to compute ROW's hash value.
1033 Fixes assertion violations in row_equal_p. (Bug#10035)
1035 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1037 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1038 just return (bug#10044).
1040 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1042 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1043 with user-defined heap size. Bump the default size of the temacs
1044 heap to 27MB, to avoid memory warning when running temacs.
1045 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1047 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1048 current_matrix and desired_matrix. (Bug#9990)
1049 (verify_row_hash) [XASSERTS]: New function.
1050 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1051 that the hash value of glyph rows is correct.
1053 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1055 * window.h (window): Remove splits slot.
1056 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1057 (Fdelete_other_windows_internal, make_parent_window)
1058 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1059 (Fset_window_configuration, save_window_save): Don't deal with
1060 split status of windows.
1061 (saved_window): Remove splits slot.
1062 (Vwindow_splits): Rewrite doc-string.
1064 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1066 * xfns.c (unwind_create_frame):
1067 * nsfns.m (unwind_create_frame):
1068 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1069 Vframe_list (Bug#9999).
1071 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1073 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1075 2011-11-11 Kenichi Handa <handa@m17n.org>
1077 * callproc.c (Fcall_process): Set the member dst_multibyte of
1080 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1082 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1083 avoid a crash (bug#9496).
1085 2011-11-09 Chong Yidong <cyd@gnu.org>
1087 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1088 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1090 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1092 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1094 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1096 Avoid some portability problems by eschewing 'extern inline' functions.
1097 The trivial performance wins aren't worth the portability hassles; see
1098 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1100 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1101 (window_box_width, window_box_left, window_box_left_offset)
1102 (window_box_right, window_box_right_offset): Undo previous change,
1103 by removing the "extern"s.
1104 * intervals.c (adjust_intervals_for_insertion)
1105 (adjust_intervals_for_deletion): Undo previous change,
1106 making these static again.
1107 (offset_intervals, temp_set_point_both, temp_set_point)
1108 (copy_intervals_to_string): No longer inline.
1109 * xdisp.c (window_text_bottom_y, window_box_width)
1110 (window_box_height, window_box_left_offset)
1111 (window_box_right_offset, window_box_left, window_box_right)
1112 (window_box): No longer inline.
1114 2011-11-08 Chong Yidong <cyd@gnu.org>
1116 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1117 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1118 Signal an error if not a live window.
1119 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1120 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1122 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1124 * lisp.h (syms_of_abbrev): Remove declaration.
1125 Reported by CHENG Gao <chenggao@royau.me>.
1127 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1129 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1130 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1131 of temacs in GUI mode.
1133 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1135 * window.h: Declare delete_all_child_windows instead of
1136 delete_all_subwindows.
1137 * window.c (Fwindow_nest, Fset_window_nest)
1138 (Fset_window_new_total, Fset_window_new_normal)
1139 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1140 (delete_all_subwindows): Rename to delete_all_child_windows.
1141 (Fdelete_other_windows_internal, Fset_window_configuration):
1142 Call delete_all_child_windows instead of delete_all_subwindows.
1143 * frame.c (delete_frame): Call delete_all_child_windows instead
1144 of delete_all_subwindows.
1146 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1148 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1149 This is also needed for porting to any host where GC_MARK_STACK is
1150 not GC_MAKE_GCPROS_NOOPS.
1151 (which_symbols): Use it.
1153 2011-11-07 Kenichi Handa <handa@m17n.org>
1155 * coding.c (coding_set_destination): Check coding->src_pos only
1156 when coding->src_object is a buffer (bug#9910).
1158 * process.c (send_process): Set the member src_multibyte of coding
1159 to 0 (bug#9911) when sending a unibyte text.
1161 * callproc.c (Fcall_process): Set the member src_multibyte of
1162 process_coding to 0 (bug#9912).
1164 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1166 * xmenu.c (cleanup_widget_value_tree): New function.
1167 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1168 calling free_menubar_widget_value_tree directly (Bug#9830).
1170 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1172 Fix some portability problems with 'inline'.
1173 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1174 (window_box_width, window_box_left, window_box_left_offset)
1175 (window_box_right, window_box_right_offset): Declare extern.
1176 Otherwise, these inline functions do not conform to C99 and
1177 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1178 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1179 * intervals.c (adjust_intervals_for_insertion)
1180 (adjust_intervals_for_deletion): Now extern, because otherwise the
1181 extern inline functions 'offset_intervals' couldn't refer to it.
1182 (static_offset_intervals): Remove.
1183 (offset_intervals): Rewrite using the old contents of
1184 static_offset_intervals. The old version didn't conform to C99
1185 because an extern inline function contained a reference to an
1186 identifier with static linkage.
1188 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1190 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1193 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1195 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1196 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1197 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1198 return Qleft_to_right.
1200 2011-11-06 Chong Yidong <cyd@gnu.org>
1202 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1203 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1204 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1205 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1206 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1207 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1208 (Fwindow_vscroll): Doc fix.
1209 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1210 argument, since it makes no sense to pass a live window and for
1211 consistency with window-child.
1213 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1215 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1218 2011-11-05 Jason Rumney <jasonr@gnu.org>
1220 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1221 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1223 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1224 bitwise arithmetic preventing use of unicode-sip and non-truetype
1227 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1229 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1232 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1233 initialization code to keep similarity to xfns.c after changes
1236 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1238 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1239 (unwind_create_frame): New function (Bug#9943).
1240 (Fx_create_frame): Restructure code to be more similar to the one in
1241 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1242 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1243 Move terminal->reference_count++ just before making the frame official
1246 * nsterm.m (x_free_frame_resources): New function.
1247 (x_destroy_window): Move code to x_free_frame_resources.
1249 * xfns.c (unwind_create_frame): Fix comment.
1250 (Fx_create_frame, x_create_tip_frame):
1251 Move terminal->reference_count++ just before making the frame
1252 official. Move initialization of image_cache_refcount and
1253 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1255 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1257 Support MSVC build with newer versions of Visual Studio.
1258 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1259 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1262 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1263 which are not supported by MSVC.
1264 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1265 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1267 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1269 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1271 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1273 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1275 Support MSVC build with newer versions of Visual Studio.
1276 * w32.c: Don't include w32api.h for MSVC.
1277 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1279 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1280 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1281 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1282 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1284 (alloca) [_MSC_VER]: Define to _alloca.
1286 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1288 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1290 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1292 * xdisp.c (note_mouse_highlight): If either of
1293 previous/next-single-property-change returns nil, treat that as
1294 the beginning or the end of the buffer. (Bug#9955)
1296 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1298 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1299 label is not null (Bug#9951).
1300 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1303 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1305 * window.c (Fwindow_body_size): Mention in the doc string that the
1306 return value is in frame's canonical units. (Bug#9949)
1308 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1310 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1312 * w32fns.c (unwind_create_frame): If needed, free the glyph
1313 matrices of the partially constructed frame. (Bug#9943)
1314 * xfns.c (unwind_create_frame): Likewise.
1316 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1318 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1319 Don't stop backward scan on the continuation glyph, even though
1320 its CHARPOS is positive.
1321 (mouse_face_from_buffer_pos, note_mouse_highlight):
1322 Rename cover_string to disp_string.
1324 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1326 * window.c (temp_output_buffer_show): Don't use
1327 Vtemp_buffer_show_specifiers.
1328 (Vtemp_buffer_show_specifiers): Remove unused variable.
1330 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1332 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1333 past the beginning of the current glyph matrix.
1335 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1337 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1338 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1339 HAVE_GTK3 (Bug#9869).
1341 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1342 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1344 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1346 * xterm.c: Declare x_handle_net_wm_state to return int.
1347 (handle_one_xevent): Check if we are iconified but don't have
1348 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1349 (get_current_wm_state): Return non-zero if not hidden,
1350 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1351 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1352 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1353 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1355 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1357 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1358 so that this new function doesn't get optimized away by a
1359 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1361 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1363 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1365 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1367 Fix the `xbytecode' command.
1368 * .gdbinit (xprintbytestr): New command.
1369 (xwhichsymbols): Rename from `which'; all callers changed.
1370 (xbytecode): Print the byte-code string as well.
1372 2011-10-29 Kim Storm <storm@cua.dk>
1374 * alloc.c (which_symbols): New function.
1376 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1378 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1381 2011-10-29 Glenn Morris <rgm@gnu.org>
1383 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1384 Not clear what it was for, and it causes various bugs. (Bug#9839)
1386 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1388 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1389 possible random value that matches one of those tested as
1390 condition to clear the mouse face.
1392 2011-10-28 Chong Yidong <cyd@gnu.org>
1394 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1396 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1398 * window.c (make_window): Initialize phys_cursor_on_p.
1400 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1402 * lisp.h (struct Lisp_Symbol): Update comments.
1404 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1406 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1408 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1410 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1411 <oslsachem@gmail.com> for helping to debug this.
1413 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1414 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1415 (g_b_init_get_glyph_outline_w): New static variables.
1416 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1417 (GetGlyphOutlineW_Proc): New typedefs.
1418 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1419 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1421 (w32font_open_internal, compute_metrics):
1422 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1423 instead of calling the "wide" APIs directly.
1425 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1427 * w32.h (syms_of_w32font): Add prototype.
1429 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1431 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1432 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1433 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1434 (Fmove_to_window_line): Doc fix.
1436 2011-10-27 Chong Yidong <cyd@gnu.org>
1438 * process.c (make_process): Set gnutls_state to NULL.
1440 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1441 non-NULL, regardless of GNUTLS_INITSTAGE.
1442 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1443 an error. Set process slots as soon as we allocate them.
1445 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1447 2011-10-27 Chong Yidong <cyd@gnu.org>
1449 * gnutls.c (emacs_gnutls_deinit): New function.
1450 Deallocate credentials structures as well as calling gnutls_deinit.
1451 (Fgnutls_deinit, Fgnutls_boot): Use it.
1453 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1454 (deactivate_process): Call emacs_gnutls_deinit.
1456 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1458 * image.c (x_create_x_image_and_pixmap):
1459 * w32.c (sys_rename, w32_delayed_load):
1460 * w32font.c (fill_in_logfont):
1461 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1463 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1465 * w32fns.c (w32_default_color_map): New function,
1466 extracted from Fw32_default_color_map.
1467 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1469 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1471 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1473 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1475 * keyboard.c (test_undefined): New function (bug#9751).
1476 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1478 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1480 * sysdep.c (init_sys_modes): Fix the check for the controlling
1481 terminal (Bug#6649).
1483 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1485 * dispextern.h (struct bidi_it): New member next_en_type.
1487 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1488 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1489 current character, check also for next_en_type being WEAK_EN.
1490 (bidi_resolve_weak): Don't enter the expensive loop if the current
1491 position is before next_en_pos. Record the bidi type of the first
1492 non-ET, non-BN character we find, in addition to its position.
1493 (bidi_level_of_next_char): Invalidate next_en_type when
1494 next_en_pos is over-stepped.
1496 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1498 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1499 * editfns.c: Rewrite current-time-zone so that it invokes
1500 the equivalent of (format-time-string "%Z") to get the time zone name.
1501 This fixes a bug when the time zone name contains characters that
1502 need converting from the system time locale to Emacs internal format.
1503 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1504 that patch fixed format-time-string to do the conversion, but
1505 I forgot to fix current-time-zone.
1506 (format_time_string): New function, containing most of
1507 what Fformat_time_string used to contain.
1508 (Fformat_time_string): Rewrite in terms of format_time_string.
1509 This doesn't change this function's behavior.
1510 (current-time-zone): Rewrite to use format_time_string.
1511 This fixes the bug reported by Michael Schierl in
1512 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1513 Jason Rumney's 2007-06-07 change worked around this bug, but
1515 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1517 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1519 * xdisp.c (start_display): If the character at POS is displayed
1520 via a display vector, reset IT->current.dpvec_index to zero.
1521 (try_window_reusing_current_matrix): If a line ends in a display
1522 vector or the next line starts in a display vector, continue
1523 redrawing the window even though the character position of
1524 start_row was reached.
1527 2011-10-18 Chong Yidong <cyd@gnu.org>
1529 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1530 with nobreak-char-display too.
1532 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1534 Fix part 3 of bug#9771.
1535 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1536 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1537 non-neutral characters if the current character is a paragraph
1538 separator (a.k.a. Newline). This avoids running the same
1539 expensive loop twice, once when we consume the preceding newline
1540 and the other time when the line actually needs to be displayed.
1541 Avoid the loop when we see neutrals on the base embedding level
1542 following a character whose directionality is the same as the
1543 paragraph's. This avoids running the expensive loop when a line
1544 ends in a long sequence of neutrals, like control characters.
1545 Add assertion against STRONG_AL type. Slightly rearrange code
1546 that determines the type of a neutral given the first non-neutral
1548 (bidi_level_of_next_char): Set next_en_pos to zero when
1549 invalidating its info.
1551 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1553 * xdisp.c (push_display_prop): Determine whether to record string
1554 or buffer position by IT->string, not by IT->method. Allow
1555 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1556 (move_it_vertically_backward): Don't look for character position
1557 immediately after the newline when in a continuation line.
1560 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1562 * window.c (coordinates_in_window): Rewrite and delabelize
1563 vertical border check. (Bug#5357) (Bug#9618)
1565 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1567 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1568 errors in XSetWindowBorder (bug#9310).
1570 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1572 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1573 avoid crash when xmalloc overrun checking is enabled.
1575 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1577 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1578 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1579 cursor motion with <left> and <right> arrow keys.
1581 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1582 some callers set that themselves.
1584 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1586 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1587 display string and the previous row comes from the same string and
1588 is empty. (Bug#9739) (Bug#9738)
1590 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1592 * doc.c (get_doc_string): Encode file name (bug#9735).
1594 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1596 * bidi.c (bidi_level_of_next_char):
1597 * xdisp.c (get_visually_first_element): Remove old incorrect
1598 comments regarding the Unicode Line Separator character.
1600 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1602 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1604 * alloc.c (Fgc_status): Do not access beyond zombies array
1605 boundary if nzombies > MAX_ZOMBIES.
1606 * alloc.c (dump_zombies): Add missing format specifier.
1608 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1610 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1611 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1613 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1614 Some packages use them to denote characters with modifiers.
1616 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1618 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1619 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1620 matching a pp-number. Rename parameter var to var1.
1622 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1624 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1626 2011-10-08 Glenn Morris <rgm@gnu.org>
1628 * callint.c (Fcall_interactively): Give a more explicit error for the
1629 'c' case with a non-character input. (Bug#8479)
1631 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1633 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1635 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1636 lines that are hscrolled on the left.
1638 * dispnew.c (buffer_posn_from_coords): Account for a possible
1639 presence of header-line. (Bug#4426)
1641 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1643 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1644 Don't advertise functionality which we discourage or doesn't work.
1646 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1648 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1649 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1650 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1651 this makes Emacs dump core during garbage collection on rare
1652 occasions. sizeof is obviously inferior to offsetof here, so
1653 stick with offsetof.
1654 (GC_POINTER_ALIGNMENT): New macro.
1655 (mark_memory): Omit 3rd (offset) arg; caller changed.
1656 Don't assume EMACS_INT alignment is the same as pointer alignment.
1658 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1660 * keyboard.c (read_key_sequence_remapped): New var.
1661 (read_key_sequence): Compute remapping in the right buffer.
1662 (command_loop_1): Use read_key_sequence's remapping directly.
1664 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1666 * dired.c (file_name_completion): Don't expand file name.
1667 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1668 before checking file name handler.
1670 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1671 they've been requested explicitly (bug#9591).
1673 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1675 * keymap.c (Fsingle_key_description): Use make_specified_string
1676 instead of build_string to build string from push_key_description.
1679 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1681 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1682 This fixes a Y2038 bug on 64-bit hosts.
1683 * buffer.c (reset_buffer):
1684 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1685 (Fclear_buffer_auto_save_failure):
1686 Use 0, not -1, to represent an unset failure time, since time_t
1687 might not be signed.
1689 Remove dependency on glibc malloc internals.
1690 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1691 Move back here from lisp.h, but with their new implementations.
1692 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1693 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1694 * charset.c (charset_table_init): New static var.
1695 (syms_of_charset): Use it instead of xmalloc. This removes a
1696 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1697 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1698 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1699 Move back to alloc.c.
1700 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1701 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1703 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1705 * nsterm.m (windowDidResize): Call x_set_window_size only when
1706 ns_in_resize is true. Otherwise set pixelwidth/height and
1707 call change_frame_size (Bug#9628).
1709 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1711 Port --enable-checking=all to Fedora 14 x86-64.
1712 * charset.c (syms_of_charset): Also account for glibc malloc's
1713 internal overhead when calculating the initial malloc maximum.
1715 Port --enable-checking=all to Fedora 14 x86.
1716 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1718 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1719 (overrun_check_realloc, overrun_check_free):
1720 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1721 That way, xmalloc returns a properly-aligned pointer even if
1722 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1723 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1724 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1725 into account when calculating the initial malloc maximum.
1726 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1727 Move here from alloc.c, so that charset.c can use it too.
1728 Properly align; the old code wasn't right for common 32-bit hosts
1729 when configured with --enable-checking=all.
1730 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1731 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1733 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1735 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1738 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1740 * xdisp.c (compute_display_string_end): If there's no display
1741 string at CHARPOS, return -1.
1743 * bidi.c (bidi_fetch_char): When compute_display_string_end
1744 returns a negative value, treat the character as a normal
1745 character not covered by a display string. (Bug#9624)
1747 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1749 * lread.c (Fread_from_string): Fix typo in docstring.
1751 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1753 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1754 newline, reseat the iterator instead of bidi-iterating there one
1755 character at a time. (Bug#9610)
1756 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1757 TO_CHARPOS if the bidi iterator is at base embedding level.
1759 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1761 * lread.c (readevalloop): Use correct code for NBSP.
1762 (read1): Likewise. (Bug#9608)
1764 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1766 * dbusbind.c (Fdbus_register_signal): When service is not
1767 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1769 2011-09-25 Glenn Morris <rgm@gnu.org>
1771 * buffer.c (truncate-lines): Doc fix.
1773 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1775 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1776 (Fset_window_next_buffers): Doc fix.
1778 2011-09-24 Glenn Morris <rgm@gnu.org>
1780 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1782 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1784 Fix minor problems found by static checking.
1785 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1786 * indent.c (Fvertical_motion): Fix == vs = typo.
1788 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1790 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1791 Default value is now t. Doc fix.
1793 * indent.c (Fvertical_motion): Compute and apply the overshoot
1794 logic when moving up, not only when moving down. Fix the
1795 confusing name and values of the it_overshoot_expected variable;
1796 logic changes accordingly. (Bug#9254) (Bug#9549)
1798 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1799 CHARPOS is covered by a display string which includes newlines.
1800 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1801 is covered by a display string with embedded newlines.
1803 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1805 * dbusbind.c (Fdbus_register_signal): Add match rule to
1806 Vdbus_registered_objects_table. (Bug#9581)
1807 (Fdbus_register_method, Vdbus_registered_objects_table):
1810 2011-09-24 Jim Meyering <meyering@redhat.com>
1812 do not ignore write error for any output size
1813 The previous change was incomplete.
1814 While it makes emacs --batch detect the vast majority of stdout
1815 write failures, errors were still ignored whenever the output size is
1816 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1817 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1818 && echo FAIL: ignored write error
1819 FAIL: ignored write error
1820 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1821 && echo FAIL: ignored write error
1822 FAIL: ignored write error
1823 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1825 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1827 * emacs.c (Fkill_emacs): In noninteractive mode exit
1828 non-successfully if a write error occurred on stdout. (Bug#9574)
1830 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1832 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1835 * dispextern.h (struct it): Update the comment documenting what
1838 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1840 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1841 a display string, extend search for cursor position to end of row.
1842 (find_row_edges): If the row ends in a newline from a display
1843 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1844 Handle the case of a display string with multiple newlines.
1845 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1846 non-empty line. Fixes confusing cursor motion with arrow keys at
1847 the beginning of a line that starts with whitespace.
1849 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1851 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1854 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1856 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1859 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1861 * xdisp.c (display_line): Record maximum and minimum buffer
1862 positions even if no glyphs were produced (e.g., by a zero-width
1863 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1864 buffer positions that will be removed from the glyph row because
1866 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1867 column is beyond frame width: don't subtract 1 "pixel" when
1868 computing width of the stretch.
1869 (reseat_at_next_visible_line_start): Undo the change made on
1870 2011-09-17 that saved paragraph information and restored it after
1871 the call to `reseat'. (Bug#9545)
1873 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1875 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1876 and turn window cursor on if cleared (Bug#9415).
1878 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1880 * search.c (boyer_moore): Take unibyte characters from pattern
1881 literally. (Bug#9458)
1883 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1885 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1887 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1889 Fix minor problem found by static checking.
1890 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1891 initialized, to pacify gcc -Wuninitialized.
1893 * fileio.c: Report proper errno when syscall falls.
1894 (Finsert_file_contents): Save and restore errno,
1895 so that report_file_error outputs the correct diagnostic.
1896 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1898 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1900 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1902 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1904 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1905 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1907 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1909 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1910 about the current paragraph and restore it after the call to reseat.
1912 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1913 (bidi_find_paragraph_start): Search back for paragraph beginning
1914 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1915 (bidi_move_to_visually_next): Only trigger paragraph-related
1916 computations when the last character is a newline or at EOB, not
1917 just any NEUTRAL_B. (Bug#9470)
1919 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1920 truncated lines if point is covered by a display string. (Bug#9524)
1922 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1924 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1925 (cons_to_x_long): New function.
1926 (lisp_data_to_selection_data): Use it. Correct the test for
1927 short-versus-long data; it was negated. Break out of vector
1928 loop, for efficiency, when a long datum is discovered.
1930 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1932 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1934 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1936 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1937 GCC PR/17406) by declaring this function with external scope.
1939 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1941 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1942 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1944 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1946 * editfns.c (Fformat): Correctly handle text properties on "%%".
1948 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1950 * xterm.c (x_draw_composite_glyph_string_foreground):
1951 * w32term.c (x_draw_composite_glyph_string_foreground):
1952 * term.c (encode_terminal_code):
1953 * composite.c (composition_update_it, get_composition_id):
1954 * xdisp.c (get_next_display_element)
1955 (fill_composite_glyph_string): Add comments about special meaning
1956 of TAB characters in a composition.
1958 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1960 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1961 This occurs when processing a multibyte format.
1962 Problem reported by Wolfgang Jenker.
1964 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1966 * xdisp.c (try_cursor_movement): Only check for exact match if
1967 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1969 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1971 Remove unused external symbols.
1972 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1973 * xdisp.c (calc_pixel_width_or_height): Now static.
1974 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1975 * indent.c (check_display_width):
1976 * w32term.c: Fix comment to match code.
1977 * xterm.c, xterm.h (x_catching_errors): Remove.
1979 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1981 * xselect.c: Use signed conversions more consistently (Bug#9498).
1982 (selection_data_to_lisp_data): Assume incoming selection data are
1983 signed integers, not unsigned. This is to be consistent with
1984 outgoing selection data, which was modified to use signed integers
1985 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1986 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1987 expects long, not unsigned long.
1989 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1991 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1992 computation of loop end. Reported by Johan Bockgård
1995 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1997 * frame.c (Fother_visible_frames_p): Function deleted.
1999 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2001 * indent.c (compute_motion): Process display vector front to back
2002 rather than the other way around. (Bug#2496)
2004 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2006 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2008 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2010 * minibuf.c (Fread_from_minibuffer): Doc fix.
2012 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2014 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2015 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2017 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2019 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2020 value for non-existent files.
2022 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2024 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2025 set its "size" to -1. This will set the modtime_size field of
2026 the corresponding buffer to -1, which is what
2027 verify-visited-file-modtime expects for files that do not exist.
2030 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2032 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2034 * lisp.h: ... from here. push_key_description is no longer
2035 defined in keyboard.c, so its declaration should not be in
2036 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2037 logically belongs with push_key_description.
2039 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2041 * buffer.h: Include <sys/types.h> instead of <time.h>.
2042 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2043 Problem reported by Herbert J. Skuhra.
2045 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2047 * xml.c (parse_region): Make the parsing work for
2048 non-comment-starting XML files again (bug#9144).
2050 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2052 * image.c (gif_load): Fix calculation of bottom and right corner.
2055 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2057 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2058 redisplay in small windows.
2060 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2062 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2064 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2066 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2067 Operate on live windows only.
2069 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2071 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2073 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2075 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2076 only under bidi iteration.
2078 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2080 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2082 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2084 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2085 Without this fix, the command to link temacs failed due to an
2086 undefined symbol __builtin_isnan. This is because
2087 /usr/include/iso/math_c99.h #defines isnan(x) to
2088 __builtin_isnan(x), but the bundled gcc, which identifies itself
2089 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2091 * floatfns.c (isnan): #undef, and then #define to a clone of
2093 (Fisnan): Always define, since it's always available now.
2094 (syms_of_floatfns): Always define isnan at the Lisp level.
2096 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2098 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2100 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2102 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2103 The previous code assumed that file offsets (off_t values) fit in
2104 EMACS_INT variables, which is not true on typical 32-bit hosts.
2105 The code messed up by falsely reporting buffer overflow in cases
2106 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2107 when "big" contains more than 2**29 bytes, even though this
2108 inserts just one byte and does not overflow the buffer.
2109 (Finsert_file_contents): Store file offsets as off_t
2110 values, not as EMACS_INT values. Check for overflow when
2111 converting between EMACS_INT and off_t. When checking for
2112 buffer overflow or for overlap, take the offsets into account.
2113 Don't use EMACS_INT for small values where int suffices.
2114 When checking for overlap, fix a typo: ZV was used where
2115 ZV_BYTE was intended.
2116 (Fwrite_region): Don't assume off_t fits into 'long'.
2117 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2119 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2121 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2123 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2125 sprintf-related integer and memory overflow issues (Bug#9412).
2127 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2128 (esprintf, exprintf, evxprintf): New functions.
2129 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2130 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2131 (modify_event_symbol): Do not assume that the length of
2132 name_alist_or_stem is safe to alloca and fits in int.
2133 (Fexecute_extended_command): Likewise for function name and binding.
2134 (Frecursion_depth): Wrap around reliably on integer overflow.
2135 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2136 since some callers pass EMACS_INT values.
2137 (Fsingle_key_description): Don't crash if symbol name contains more
2138 than MAX_ALLOCA bytes.
2139 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2140 (get_minibuffer): Arg is now EMACS_INT, not int.
2141 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2142 (esprintf, exprintf, evxprintf): New decls.
2143 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2145 * dbusbind.c (signature_cat): New function.
2146 (xd_signature, Fdbus_register_signal):
2147 Do not overrun buffer; instead, report string overflow.
2149 * dispnew.c (add_window_display_history): Don't overrun buffer.
2150 Truncate instead; this is OK since it's just a log.
2152 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2153 even if the time zone offset is outlandishly large.
2154 Don't mishandle offset == INT_MIN.
2156 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2157 when creating daemon; the previous buffer-overflow check was incorrect.
2159 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2160 which has the guts of the old verror function.
2162 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2163 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2165 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2166 (font_unparse_xlfd): Don't blindly alloca long strings.
2167 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2168 fits in int, when using sprintf. Use single snprintf to count
2169 length of string rather than counting it via multiple sprintfs;
2170 that's simpler and more reliable.
2171 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2172 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2173 sprintf, in case result does not fit in int.
2175 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2176 (fontset_from_font): Print it.
2178 * frame.c (tty_frame_count): Now printmax_t, not int.
2179 (make_terminal_frame, set_term_frame_name): Print it.
2180 (x_report_frame_params): In X, window IDs are unsigned long,
2181 not signed long, so print them as unsigned.
2182 (validate_x_resource_name): Check for implausibly long names,
2183 and don't assume name length fits in 'int'.
2184 (x_get_resource_string): Don't blindly alloca invocation name;
2185 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2188 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2189 (xg_check_special_colors, xg_set_geometry):
2190 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2192 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2193 Use esprintf, not sprintf, in case result does not fit in int.
2195 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2196 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2197 it as a large positive number.
2198 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2199 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2201 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2202 in case result does not fit in int.
2204 * print.c (float_to_string): Detect width overflow more reliably.
2205 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2206 buffer overrun. Don't assume list length fits in 'int'. Treat
2207 print length of 0 as 0, not as infinity; to be consistent with other
2208 uses of print length in this function. Don't overflow print length
2209 index. Don't assume hash table size fits in 'long', or that
2210 vectorlike size fits in 'unsigned long'.
2212 * process.c (make_process): Use printmax_t, not int, to format
2213 process-name gensyms.
2215 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2217 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2218 to avoid potential buffer overrun.
2220 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2221 if X resource line is longer than 512 bytes.
2223 * xfns.c (x_window): Make sprintf buffer a bit bigger
2224 to avoid potential buffer overrun.
2226 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2228 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2230 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2232 Integer overflow fixes for scrolling, etc.
2233 Without these, Emacs silently mishandles large integers sometimes.
2234 For example, "C-u 4294967297 M-x recenter" was treated as if
2235 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2237 * xdisp.c (try_window_id): Check Emacs fixnum range before
2238 converting to 'int'.
2240 * window.c (window_scroll_line_based, Frecenter):
2241 Check that an Emacs fixnum is in range before assigning it to 'int'.
2242 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2243 values converted from Emacs fixnums.
2244 (Frecenter): Don't wrap around a line count if it is out of 'int'
2245 range; instead, treat it as an extreme value.
2246 (Fset_window_configuration, compare_window_configurations):
2247 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2249 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2250 that can exceed INT_MAX. Check that EMACS_INT value is in range
2251 before assigning it to the (possibly-narrower) index.
2252 (match_limit): Don't assume that a fixnum can fit in 'int'.
2254 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2257 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2258 (Fvertical_motion): Don't wrap around LINES values that don't fit
2259 in 'int'. Instead, treat them as extreme values. This is good
2260 enough for windows, which can't have more than INT_MAX lines anyway.
2262 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2264 * Require libxml/parser.h to avoid compilation warning.
2266 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2268 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2269 since this reportedly can destroy thread storage.
2271 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2273 * syntax.c (find_defun_start): Update all cache variables if
2274 exiting early (Bug#9401).
2276 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2278 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2280 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2281 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2282 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2284 * term.c (tty_append_glyph): New function.
2285 (produce_stretch_glyph): Static function and its prototype deleted.
2287 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2290 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2292 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2293 when checking :margin (Bug#9390).
2294 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2295 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2296 so that the name doesn't mislead. All uses changed.
2298 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2300 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2303 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2305 * xdisp.c (move_it_to): Don't bail out early when reaching
2306 position beyond to_charpos, if we are scanning backwards.
2307 (move_it_vertically_backward): When DY == 0, make sure we get to
2308 the first character in the line after the newline.
2310 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2312 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2313 (ccl_driver): Do not generate an out-of-range pointer.
2314 (Fccl_execute_on_string): Remove unnecessary check for
2315 integer overflow, noted by Stefan Monnier in
2316 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2317 Remove a FIXME that didn't need fixing.
2318 Simplify the newly-introduced buffer reallocation code.
2320 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2322 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2324 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2326 Integer and memory overflow issues (Bug#9196).
2328 * doc.c (get_doc_string): Rework so that
2329 get_doc_string_buffer_size is the actual buffer size, rather than
2330 being 1 less than the actual buffer size; this makes xpalloc more
2333 * image.c (x_allocate_bitmap_record, cache_image):
2334 * xselect.c (Fx_register_dnd_atom):
2335 Simplify previous changes by using xpalloc.
2337 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2338 since either will do and ptrdiff_t is convenient with xpalloc.
2340 * charset.c (charset_table_size)
2341 (struct charset_sort_data.priority): Now ptrdiff_t.
2342 (charset_compare): Don't overflow if priorities differ greatly.
2343 (Fsort_charsets): Don't assume list length fits in int.
2344 Check for size-calculation overflow when allocating sort data.
2345 (syms_of_charset): Allocate an initial charset table that is
2346 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2348 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2350 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2351 The actual value is always <= INT_MAX, and leaving it unsigned made
2352 overflow checking harder.
2354 * dispextern.h (struct glyph_matrix.rows_allocated)
2355 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2356 with xpalloc. The values are still always <= INT_MAX.
2358 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2360 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2361 (SAFE_NALLOCA): New macro.
2363 * region-cache.c (struct boundary.pos, find_cache_boundary)
2364 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2365 (set_cache_region, invalidate_region_cache)
2366 (revalidate_region_cache, know_region_cache, region_cache_forward)
2367 (region_cache_backward, pp_cache):
2368 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2369 so that ptrdiff_t * can be passed to xpalloc.
2370 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2371 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2372 (pp_cache): Don't assume cache_len fits in int.
2373 * region-cache.h: Adjust extern decls to match.
2375 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2376 EMACS_INT, since either will do, for xpalloc.
2378 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2379 (xnmalloc, xnrealloc, xpalloc): New functions.
2381 * bidi.c (bidi_shelve_header_size): New constant.
2382 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2383 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2385 * bidi.c (bidi_cache_shrink):
2386 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2388 Don't update size of array until after memory allocation succeeds,
2389 because xmalloc/xrealloc may not return.
2390 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2391 now that we have proper integer overflow checking.
2392 (record_overlay_string, overlay_strings): Catch overflows when
2393 calculating size of overlay_str_buf.
2395 * callproc.c (Fcall_process): Check for size overflow when
2396 calculating size of args2.
2397 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2398 Normally we prefer signed values, but sticking with ptrdiff_t would
2399 require adding more-complicated checks.
2401 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2402 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2403 Redo buffer-overflow calculations to avoid integer overflow.
2404 Add a FIXME comment where memory seems to be over-allocated.
2406 * character.c (Fstring): Check for size-calculation overflow.
2408 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2409 unnecessary integer overflow. Check for size overflow.
2410 (encode_coding_object): Don't update size until xmalloc succeeds.
2412 * composite.c (get_composition_id): Check for overflow in glyph
2413 length calculations.
2415 Integer and memory overflow fixes for display code.
2416 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2417 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2418 (scrolling_window): Check for overflow in size calculations.
2419 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2420 Don't assume glyph table len fits in int.
2421 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2422 (row_table_size): Now ptrdiff_t, not int.
2423 (scrolling_window): Avoid overflow in size calculations.
2424 Don't update size until allocation succeeds.
2425 * fns.c (concat): Check for overflow in size calculations.
2426 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2427 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2428 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2430 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2431 (get_doc_string): Check for size calculation overflow.
2432 Don't update size until allocation succeeds.
2433 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2434 EMACS_INT, where ptrdiff_t will do.
2435 (Fsubstitute_command_keys): Check for string overflow.
2437 * editfns.c (set_time_zone_rule): Don't assume environment length
2439 (message_length): Now ptrdiff_t, not int.
2440 (Fmessage_box): Don't update size until allocation succeeds.
2441 Don't assume message length fits in int.
2442 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2444 * emacs.c (main): Do not reallocate argv, since there is a null at
2445 the end that can be overwritten, and this way there's no need to
2446 worry about size-calculation overflow.
2447 (sort_args): Check for size-calculation overflow.
2449 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2451 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2453 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2454 (x_set_scroll_bar_width, x_figure_window_size):
2455 Check for integer overflow.
2456 (x_set_alpha): Do not assume XINT fits in int.
2458 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2459 This is for the members text_lines, text_cols, total_lines, total_cols,
2460 where the system imposes an 'int' limit.
2462 * fringe.c (Fdefine_fringe_bitmap):
2463 Don't update size until alloc works.
2465 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2466 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2468 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2469 Check for size-calculation overflow.
2470 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2471 do, as we prefer signed integers.
2472 (id_to_widget.max_size, id_to_widget.used)
2473 (xg_store_widget_in_map, xg_remove_widget_from_map)
2474 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2475 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2476 Use and return ptrdiff_t, not int.
2477 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2478 * gtkutil.h: Change prototypes to match the above.
2480 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2481 are duplicate now that they've been promoted to lisp.h.
2482 (x_allocate_bitmap_record, x_alloc_image_color)
2483 (make_image_cache, cache_image, xpm_load):
2484 Don't update size until alloc is done.
2485 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2487 Check for size calculation overflow.
2488 (ct_colors_allocated_max): New constant.
2489 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2492 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2493 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2494 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2495 Use ptrdiff_t, not int, to count maps.
2496 (read_char_minibuf_menu_prompt): Check for overflow in size
2497 calculations. Don't update size until allocation succeeds.
2498 Redo calculations to avoid overflow.
2499 * keyboard.h: Change prototypes to match the above.
2501 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2503 (current_minor_maps): Check for size calculation overflow.
2504 * keymap.h: Change prototypes to match the above.
2506 * lread.c (read1, init_obarray): Don't update size until alloc done.
2508 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2509 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2511 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2512 Now ptrdiff_t, not int.
2513 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2514 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2516 * process.c (Fnetwork_interface_list): Check for overflow
2517 in size calculation.
2519 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2521 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2522 overflow. Don't bother calling xmalloc when xrealloc will do.
2524 * search.c (Freplace_match): Check for size calculation overflow.
2525 (Fset_match_data): Don't assume list lengths fit in 'int'.
2527 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2528 for command line length. Do not attempt to address one before the
2529 beginning of an array, as that's not portable.
2531 * term.c (max_frame_lines): Remove; unused.
2532 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2534 (encode_terminal_code, calculate_costs): Check for size
2535 calculation overflow.
2536 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2537 table lengths and related sizes. Don't update size until alloc
2538 done. Redo calculations to avoid overflow.
2539 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2541 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2542 subtracting pointers.
2543 (gobble_line): Check for overflow more carefully. Don't update size
2546 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2547 Don't update size until alloc done.
2548 Redo size calculations to avoid overflow.
2549 Check for size calculation overflow.
2550 (main) [DEBUG]: Fix typo in invoking tparam1.
2552 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2553 Use ptrdiff_t, not int, for sizes.
2554 (store_mode_line_noprop_char): Don't update size until alloc done.
2556 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2557 Use ptrdiff_t, not int, for sizes.
2558 (Finternal_make_lisp_face, cache_face):
2559 Check for size calculation overflow.
2560 (cache_face): Treat size calculation overflows as if they were
2561 memory exhaustion (the usual treatment), rather than aborting.
2563 * xfns.c (x_encode_text, x_set_name_internal)
2564 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2565 sizes, since they can exceed INT_MAX in size. Check for size
2566 calculation overflow.
2568 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2569 (xg_select): Check for size calculation overflow.
2570 Don't update size until alloc done.
2572 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2573 as sprintf is limited to int lengths.
2575 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2576 (X_LONG_MIN): New macros.
2577 Use them to make the following changes clearer.
2578 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2579 This change doesn't affect the value now, but it may help remind
2580 future maintainers not to raise the value too much later.
2581 (SELECTION_QUANTUM): Remove, replacing with ...
2582 (selection_quantum): ... new function, which avoids overflow.
2584 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2585 assumption that selection length fits in 'int'.
2586 (x_reply_selection_request, x_handle_selection_request)
2587 (x_get_window_property, receive_incremental_selection)
2588 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2589 (lisp_data_to_selection_data, clean_local_selection_data):
2590 Use ptrdiff_t, not int, to record length of selection.
2591 (x_reply_selection_request, x_get_window_property)
2592 (receive_incremental_selection, x_property_data_to_lisp):
2593 Redo calculations to avoid overflow.
2594 (x_reply_selection_request): When sending hint, ceiling it at
2595 X_LONG_MAX rather than relying on wraparound overflow to send
2597 (x_get_window_property, receive_incremental_selection)
2598 (lisp_data_to_selection_data, x_property_data_to_lisp):
2599 Check for size-calculation overflow.
2600 (x_get_window_property, receive_incremental_selection)
2601 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2602 Don't store size until memory allocation succeeds.
2603 (x_get_window_property): Plug memory leak on memory exhaustion.
2604 Don't double-block input; malloc is safe here. Don't assume 2**34
2605 - 4 fits in unsigned long. Add an xassert to check
2606 XGetWindowProperty overflow. Be more careful about overflow
2607 calculations, and distinguish size from memory overflow better.
2608 (receive_incremental_selection): When tracing, don't assume
2609 unsigned int is less than INT_MAX.
2610 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2611 harmful) conversions of unsigned short to int.
2612 (lisp_data_to_selection_data): Don't assume that integers
2613 in the range -65535 through -1 fit in an X unsigned short.
2614 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2615 result parameters unless successful. Rely on cons_to_unsigned
2616 to report problems with elements; the old code wasn't right anyway.
2617 (x_check_property_data): Check for int overflow; we cannot use
2618 a wider type due to X limits.
2619 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2621 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2623 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2624 (x_term_init): Check for size calculation overflow.
2625 (x_color_cells): Don't store size until memory allocation succeeds.
2626 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2627 Don't assume alloca size is less than MAX_ALLOCA.
2628 (x_term_init): Don't assume length fits in int (sprintf is limited
2631 Use ptrdiff_t for composition IDs.
2632 * character.c (lisp_string_width):
2633 * composite.c (composition_table_size, n_compositions)
2634 (get_composition_id, composition_gstring_from_id):
2635 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2636 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2637 * window.c (Frecenter):
2638 Use ptrdiff_t, not int, for composition IDs.
2639 * composite.c (get_composition_id): Check for integer overflow.
2640 * composite.h: Adjust prototypes to match the above changes.
2642 Use ptrdiff_t for hash table indexes.
2643 * category.c (hash_get_category_set):
2644 * ccl.c (ccl_driver):
2645 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2646 * coding.c (coding_system_charset_list, detect_coding_system):
2647 * coding.h (struct coding_system.id):
2648 * composite.c (get_composition_id, gstring_lookup_cache):
2649 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2650 * image.c (xpm_get_color_table_h):
2651 * lisp.h (hash_lookup, hash_put):
2652 * minibuf.c (Ftest_completion):
2653 Use ptrdiff_t for hash table indexes, not int (which is too
2654 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2655 32-bit --with-wide-int hosts).
2657 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2658 Add a FIXME comment about memory leaks.
2659 (syms_of_charset): Don't assume xmalloc returns.
2661 Don't assume that stated character widths fit in int.
2662 * character.c (Fchar_width, c_string_width, lisp_string_width):
2663 * character.h (CHAR_WIDTH):
2664 * indent.c (MULTIBYTE_BYTES_WIDTH):
2665 Use sanitize_char_width to avoid undefined and/or bad behavior
2666 with outlandish widths.
2667 * character.h (sanitize_tab_width): Rename from sanitize_width,
2668 now that we have two such functions. All uses changed.
2669 (sanitize_char_width): New inline function.
2671 Don't assume that tab-width fits in int.
2672 * character.h (sanitize_width): New inline function.
2673 (SANE_TAB_WIDTH): New macro.
2674 (ASCII_CHAR_WIDTH): Use it.
2675 * indent.c (sane_tab_width): Remove. All uses replaced by
2676 SANE_TAB_WIDTH (current_buffer).
2677 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2679 * fileio.c: Integer overflow issues with file modes.
2680 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2682 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2683 Remove unreachable code.
2684 (read_hex, load_charset_map_from_file): Check for integer overflow.
2686 * xterm.c: Don't go over XClientMessageEvent limit.
2687 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2688 (x_send_scroll_bar_event): Likewise. Check that the size does not
2689 exceed limits imposed by XClientMessageEvent, as well as the usual
2690 ptrdiff_t and size_t limits.
2692 * keyboard.c: Overflow, signedness and related fixes.
2693 (make_lispy_movement): Use same integer type in forward decl
2694 that is used in the definition.
2695 (read_key_sequence, keyremap_step):
2696 Change bufsize argument back to int, undoing my 2011-03-30 change.
2697 We prefer signed types, and int is wide enough here.
2698 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2699 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2700 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2701 length, not size_t. Use ptrdiff_t for index, not int.
2702 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2703 possibility of integer overflow.
2705 Overflow, signedness and related fixes for images.
2707 * dispextern.h (struct it.stack[0].u.image.image_id)
2708 (struct_it.image_id, struct image.id, struct image_cache.size)
2709 (struct image_cache.used, struct image_cache.ref_count):
2710 * gtkutil.c (update_frame_tool_bar):
2711 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2712 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2713 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2714 * nsmenu.m (update_frame_tool_bar):
2715 * xdisp.c (calc_pixel_width_or_height):
2716 * xfns.c (image_cache_refcount):
2717 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2718 on typical 64-bit hosts.
2720 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2721 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2722 Omit unnecessary casts to int.
2723 (parse_image_spec): Check that integers fall into 'int' range
2724 when the callers expect that.
2725 (image_ascent): Redo ascent calculation to avoid int overflow.
2726 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2727 (lookup_image): Remove unnecessary tests.
2728 (xbm_image_p): Locals are now of int, not EMACS_INT,
2729 since parse_image_check makes sure they fit into int.
2730 (png_load, gif_load, svg_load_image):
2731 Prefer int to unsigned where either will do.
2732 (tiff_handler): New function, combining the cores of the
2733 old tiff_error_handler and tiff_warning_handler.
2734 This function is rewritten to use vsnprintf and thereby avoid
2735 stack buffer overflows. It uses only the features of vsnprintf
2736 that are common to both POSIX and native Microsoft.
2737 (tiff_error_handler, tiff_warning_handler): Use it.
2738 (tiff_load, gif_load, imagemagick_load_image):
2739 Don't assume :index value fits in 'int'.
2740 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2741 (imagemagick_load_image): Check that crop parameters fit into
2742 the integer types that MagickCropImage accepts. Don't assume
2743 Vimagemagick_render_type has a nonnegative value. Don't assume
2744 size_t fits in 'long'.
2745 (gs_load): Use printmax_t to print the widest integers possible.
2746 Check for integer overflow when computing image height and width.
2748 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2750 * xdisp.c (redisplay_window): Don't force window start if point
2751 will be invisible in the resulting window. (Bug#9324)
2753 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2755 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2756 the display spec is of the form `(space ...)'.
2757 (handle_display_spec): Return the value returned by
2758 handle_single_display_spec, not just 1 or zero.
2759 (handle_single_display_spec): If the display spec is of the form
2760 `(space ...)', and specifies display in the text area, return 2
2762 (try_cursor_movement): Check for the need to scroll more
2763 accurately, and prefer exact match for point under bidi.
2764 Don't advance `row' beyond the last row of the window.
2766 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2767 into disp_prop; all users changed.
2769 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2770 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2771 for the text covered by the display property.
2773 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2775 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2776 Change return value to nil.
2777 (Frecord_buffer): Delete unused function.
2779 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2781 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2782 buffers, return left-to-right.
2783 (set_cursor_from_row): Consider candidate row a win if its glyph
2784 represents a newline and point is on that newline. Fixes cursor
2785 positioning on the newline at EOL of R2L text within L2R
2786 paragraph, and vice versa.
2787 (try_cursor_movement): Check continued rows, in addition to
2788 continuation rows. Fixes unwarranted scroll when point enters a
2789 continued line of R2L text within an L2R paragraph, or vice versa.
2790 (cursor_row_p): Consider the case of point being equal to
2791 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2792 from the end of a short line to the beginning of a continued line
2793 of R2L text within L2R paragraph.
2794 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2795 composed characters.
2797 * bidi.c (bidi_check_type): Use xassert.
2798 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2801 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2803 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2806 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2808 * nsfont.m (ns_otf_to_script): Fix typo.
2810 2011-08-22 Kenichi Handa <handa@m17n.org>
2812 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2813 extra slot even if the purpose is char-code-property-table.
2815 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2817 * xdisp.c (redisplay_window): When computing centering_position,
2818 account for the height of the header line. (Bug#8874)
2820 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2821 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2822 candidate is selected by the mouse, and that candidate has a
2823 composed character under the mouse.
2825 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2826 coordinates reported by pos-visible-in-window-p for a composed
2827 character in column zero.
2829 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2831 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2833 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2835 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2836 consider it a hit if to_charpos is anywhere in the range of the
2837 composed buffer positions.
2839 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2841 * image.c (gif_load): Don't assume that each subimage has the same
2842 dimensions as the base image. Handle disposal method that is
2843 "undefined" by the gif spec (Bug#9335).
2845 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2847 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2848 (Fcondition_case): Document `debug' symbol in error handler.
2850 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2852 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2853 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2854 from an Org mode buffer to a Speedbar frame.
2856 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2857 a composition, take its buffer position from IT->cmp_it.charpos.
2858 Fixes cursor positioning at the beginning of a line that begins
2859 with a composed character.
2861 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2863 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2864 character bidirectional type, use STRONG_L instead. Fixes crashes
2865 in a buffer produced by `describe-categories'.
2867 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2868 members before the level stack, so they would be saved and
2869 restored when copying iterator state. Fixes incorrect reordering
2870 around TABs covered by display properties.
2872 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2874 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2876 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2878 * eval.c (internal_condition_case, internal_condition_case_1)
2879 (internal_condition_case_2, internal_condition_case_n):
2880 Remove unnecessary aborts (Bug#9081).
2882 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2884 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2885 has no `load' handler, try opening the file locally. (Bug#9311)
2887 2011-08-16 Ken Brown <kbrown@cornell.edu>
2889 * gmalloc.c: Expand comment.
2891 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2893 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2894 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2896 2011-08-16 Ken Brown <kbrown@cornell.edu>
2898 Fix memory allocation problems in Cygwin build (Bug#9273).
2900 * unexcw.c ( __malloc_initialized): Declare external variable.
2901 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2903 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2905 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2907 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2909 [CYGWIN] (special_realloc): New function.
2910 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2911 requests to realloc storage in the static heap.
2913 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2915 * bidi.c (bidi_initialize): Remove unused local.
2917 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2920 * biditype.h: Remove file.
2921 * makefile.w32-in ($(BLD)/bidi.$(O)):
2922 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2924 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2926 * chartab.c: Improve commentary for the uniprop_table API.
2928 * bidi.c (bidi_paragraph_init): Support zero value of
2929 bidi_ignore_explicit_marks_for_paragraph_level.
2930 (bidi_initialize): Use uniprop_table instead of including
2931 biditype.h and bidimirror.h.
2933 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2934 coordinates of the iterator when restoring from ppos_it.
2937 2011-08-14 Kenichi Handa <handa@m17n.org>
2939 * process.c (create_process): Call setup_process_coding_systems
2940 after the pid of the process is set to -1 (Bug#8162).
2942 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2944 * xdisp.c (move_it_in_display_line_to): Don't invoke
2945 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2946 ppos_it. Fixes vertical cursor motion when line beginning is
2947 covered by an image. (Bug#9296)
2949 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2951 * nsterm.h (ns_run_ascript): Declare.
2952 (NSAPP_DATA2_RUNASSCRIPT): Define.
2954 * nsfns.m (as_script, as_result, as_status): New static variables.
2955 (ns_run_ascript): New function.
2956 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2957 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2958 the event loop. Get status from as_status (Bug#7276).
2960 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2961 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2962 the event loop (Bug#7276).
2964 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2966 * gnutls.c (QCgnutls_bootprop_priority)
2967 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2968 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2969 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2970 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2971 (QCgnutls_bootprop_verify_hostname_error)
2972 (QCgnutls_bootprop_callbacks_verify): Rename from
2973 Qgnutls_bootprop_..., all uses changed.
2975 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2978 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2980 * xfaces.c (Qframe_set_background_mode): Now static.
2981 * dispextern.h (Qframe_set_background_mode): Remove decl.
2983 * process.c (Fnetwork_interface_info): Declare local only if needed.
2985 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2987 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2988 (Fnetwork_interface_list): Allocate in increments of bytes instead
2989 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2990 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2992 (struct ifflag_def): notrailers is smart on OSX.
2993 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2994 Get hardware address with getifaddrs if available.
2996 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2998 * xdisp.c (iterate_out_of_display_property): xassert that
2999 IT->position is set to within IT->object's boundaries. Break from
3000 the loop as soon as EOB is reached; avoids infloops in redisplay
3001 when IT->position is set up wrongly due to some bug.
3002 Set IT->current to match the bidi iterator unconditionally.
3003 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3004 entry. Force push_it to save on the stack the current
3005 buffer/string position, to be restored by pop_it. Fix flags in
3006 the iterator structure wrt the object coming from a display
3007 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3008 properties. (Bug#9284)
3010 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3012 * fontset.c (fontset_get_font_group): Add proper type checks.
3015 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3017 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3018 and LC_VERSION_MIN_MACOSX.
3019 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3020 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3022 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3024 * xdisp.c (forward_to_next_line_start): Allow to use the
3025 no-display-properties-and-no-overlays under bidi display.
3026 Set disp_pos in the bidi iterator to avoid searches for display
3027 properties and overlays.
3029 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3031 * editfns.c (Fset_time_zone_rule): Document relationship with the
3034 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3035 the font entity extracted from the cache (Bug#8109).
3037 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3039 * composite.c (autocmp_chars): Don't reset point. That is done by
3040 restore_point_unwind (Bug#5984).
3042 2011-08-07 Juri Linkov <juri@jurta.org>
3044 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3045 to show the arg `TIME' instead of `TIMEVAL'.
3047 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3049 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3050 display property strides EOL and includes a newline, as in
3051 longlines-mode. (Bug#9254)
3052 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3053 word-wrap under bidirectional display. (Bug#9224)
3055 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3056 is non-zero, even if the data buffer is NULL. Fixes a crash in
3057 vertical-motion with longlines-mode. (Bug#9254)
3059 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3061 * bidi.c <bidi_cache_total_alloc>: Now static.
3062 (bidi_initialize): Initialize bidi_cache_total_alloc.
3064 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3067 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3068 amount allocated this far in `bidi_cache_total_alloc'.
3069 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3070 non-zero, only free the data buffer without restoring the cache
3071 contents. All callers changed.
3073 * dispextern.h (bidi_unshelve_cache): Update prototype.
3075 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3076 (move_it_in_display_line, move_it_to)
3077 (move_it_vertically_backward, move_it_by_lines): Replace the call
3078 to xfree to an equivalent call to bidi_unshelve_cache.
3079 (move_it_in_display_line_to): Fix logic of returning
3080 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3082 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3084 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3085 came from a string character with a `cursor' property. (Bug#9229)
3087 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3089 * Makefile.in (LIB_PTHREAD): New variable.
3090 (LIBES): Add LIB_PTHREAD (Bug#9216).
3092 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3093 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3095 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3097 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3099 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3101 * xterm.c (x_find_topmost_parent): New function.
3102 (x_set_frame_alpha): Find topmost parent window with
3103 x_find_topmost_parent and set the property there also (bug#9181).
3104 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3106 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3108 * callproc.c (Fcall_process): Avoid vfork clobbering
3109 the local vars buffer, coding_systems, current_dir.
3111 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3113 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3115 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3117 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3118 so that it is not optimized away.
3120 * xdisp.c (compute_display_string_pos): Remove unused local.
3122 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3124 Fix slow cursor motion and scrolling in large buffers with
3125 selective display, like Org Mode buffers. (Bug#9218)
3127 * dispextern.h (struct bidi_it): New member disp_prop_p.
3129 * xdisp.c: Remove one-slot cache of display string positions.
3130 (compute_display_string_pos): Accept an additional argument
3131 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3132 for a display string or property. If found, set DISP_PROP_P
3135 * bidi.c (bidi_fetch_char): Accept an additional argument
3136 DISP_PROP_P, and pass it to compute_display_string_pos.
3137 Only handle text covered by a display string if DISP_PROP_P is returned
3138 non-zero. All callers of bidi_fetch_char changed.
3140 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3142 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3144 2010-12-03 Don March <don@ohspite.net>
3146 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3147 last character M-[char] is translated to ESC [char] (bug#7541).
3149 2011-08-02 Kenichi Handa <handa@m17n.org>
3151 * lisp.h (uniprop_table): Extern it.
3153 * chartab.c (uniprop_table): Make it non-static.
3155 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3157 * xdisp.c (forward_to_next_line_start): Accept additional argument
3158 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3160 (reseat_at_next_visible_line_start): Use the bidi iterator state
3161 returned by forward_to_next_line_start to restore the state of
3162 it->bidi_it after backing up to previous newline. (Bug#9212)
3164 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3166 * regex.c (re_comp): Protoize.
3167 (re_exec): Fix return type.
3168 (regexec): Fix type of `ret'. (Bug#9203)
3170 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3172 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3173 This is needed if max-image-size is a floating-point number.
3175 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3177 * print.c (print_object): Print empty symbol as ##.
3179 * lread.c (read1): Read ## as empty symbol.
3181 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3183 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3184 setting frame foreground color (Bug#9175).
3185 (x_set_background_color): Likewise.
3187 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3188 contents (Bug#9176).
3189 (EmacsTooltip -init): Remove bezels and add shadows to
3192 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3193 or scroll bar (Bug#8470).
3195 * nsfont.m (nsfont_open): Remove assignment to voffset and
3196 unnecessary vars hshink, expand, hd, full_height, min_height.
3197 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3199 * nsterm.h (nsfont_info): Remove voffset field.
3201 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3203 Implement strike-through and overline on NextStep (Bug#8863).
3205 * nsfont.m (nsfont_open): Use underline position provided by font,
3206 instead of hard-coded value of 2.
3207 (nsfont_draw): Call ns_draw_text_decoration instead.
3209 * nsterm.h: Add declaration for ns_draw_text_decoration.
3211 * nsterm.m (ns_draw_text_decoration): New function for drawing
3212 underline, overline, and strike-through.
3213 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3214 ns_draw_text_decoration. Change treatment of cursor drawing to
3215 accommodate underlining, etc.
3217 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3219 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3222 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3224 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3225 Without this fix, if a signal arrives just after memory fills up,
3226 'malloc' might be invoked reentrantly.
3228 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3229 In other words, assume that every image size is allowed, on non-X
3230 hosts. This assumption is probably wrong, but it lets Emacs compile.
3232 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3234 * regex.c (re_iswctype): Convert return values to boolean.
3236 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3238 * xdisp.c (compute_display_string_pos): Don't use cached display
3239 string position if the buffer had its restriction changed.
3242 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3244 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3246 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3248 Integer signedness and overflow and related fixes. (Bug#9079)
3250 * bidi.c: Integer size and overflow fixes.
3251 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3252 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3253 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3254 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3255 (bidi_find_other_level_edge):
3256 Use ptrdiff_t instead of EMACS_INT where either will do.
3257 This works better on 32-bit hosts configured --with-wide-int.
3258 (bidi_cache_ensure_space): Check for size-calculation overflow.
3259 Use % rather than repeated addition, for better worst-case speed.
3260 Don't set bidi_cache_size until after xrealloc returns, because it
3262 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3263 (bidi_cache_ensure_space): Also check that the bidi cache size
3264 does not exceed that of the largest Lisp string or buffer. See Eli
3265 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3267 * alloc.c (__malloc_size_t): Remove.
3268 All uses replaced by size_t. See Andreas Schwab's note
3269 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3271 * image.c: Improve checking for integer overflow.
3272 (check_image_size): Assume that f is nonnull, since
3273 it is always nonnull in practice. This is one less thing to
3274 worry about when checking for integer overflow later.
3275 (x_check_image_size): New function, which checks for integer
3276 overflow issues inside X.
3277 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3278 This removes the need for a memory_full check.
3279 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3280 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3281 (xbm_read_bitmap_data): Change locals back to 'int', since
3282 their values must fit in 'int'.
3283 (xpm_load_image, png_load, tiff_load):
3284 Invoke x_create_x_image_and_pixmap earlier,
3285 to avoid much needless work if the image is too large.
3286 (tiff_load): Treat overly large images as if
3287 x_create_x_image_and_pixmap failed, not as malloc failures.
3288 (gs_load): Use x_check_image_size.
3290 * gtkutil.c: Omit integer casts.
3291 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3292 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3294 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3296 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3297 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3298 would wrongly return t on a 64-bit host.
3300 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3301 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3302 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3303 and therefore cause GCC to emit a bogus diagnostic in some cases.
3305 * image.c: Integer signedness and overflow and related fixes.
3306 This is not an exhaustive set of fixes, but it's time to
3307 record what I've got.
3308 (lookup_pixel_color, check_image_size): Remove redundant decls.
3309 (check_image_size): Don't assume that arbitrary EMACS_INT values
3310 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3311 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3312 (tiff_load, imagemagick_load_image):
3313 Check for overflow in size calculations.
3314 (x_create_x_image_and_pixmap): Remove unnecessary test for
3315 xmalloc returning NULL; that can't happen.
3316 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3317 (xpm_color_bucket): Use better integer hashing function.
3318 (xpm_cache_color): Don't possibly over-allocate memory.
3319 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3320 (gif_memory_source):
3321 Use ptrdiff_t, not int or size_t, to record sizes.
3322 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3323 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3324 either works, as we prefer signed integers.
3325 (tiff_read_from_memory, tiff_write_from_memory):
3326 Return tsize_t, not size_t, since that's what the TIFF API wants.
3327 (tiff_read_from_memory): Don't fail simply because the read would
3328 go past EOF; instead, return a short read.
3329 (tiff_load): Omit no-longer-needed casts.
3330 (Fimagemagick_types): Don't assume size fits into 'int'.
3332 Improve hashing quality when configured --with-wide-int.
3333 * fns.c (hash_string): New function, taken from sxhash_string.
3334 Do not discard information about ASCII character case; this
3335 discarding is no longer needed.
3336 (sxhash-string): Use it. Change sig to match it. Caller changed.
3337 * lisp.h: Declare it.
3338 * lread.c (hash_string): Remove, since we now use fns.c's version.
3339 The fns.c version returns a wider integer if --with-wide-int is
3340 specified, so this should help the quality of the hashing a bit.
3342 * emacs.c: Integer overflow minor fix.
3343 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3344 Define only if GNU_LINUX.
3345 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3347 * dispnew.c: Integer signedness and overflow fixes.
3348 Remove unnecessary forward decls, that were a maintenance hassle.
3349 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3351 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3352 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3353 (prepare_desired_row, line_draw_cost):
3354 Use int, not unsigned, where either works.
3355 (save_current_matrix, restore_current_matrix):
3356 Use ptrdiff_t, not size_t, where either works.
3357 (init_display): Check for overflow more accurately, and without
3358 relying on undefined behavior.
3360 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3361 Remove, replacing with the new symbols in lisp.h. All uses changed.
3362 * fileio.c (make_temp_name):
3363 * filelock.c (lock_file_1, lock_file):
3364 * xdisp.c (message_dolog):
3365 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3366 Use pMd etc. instead.
3367 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3368 replacing the pWIDE etc. symbols removed from editfns.c.
3370 * keyboard.h (num_input_events): Now uintmax_t.
3371 This is (very slightly) less likely to mess up due to wraparound.
3374 * buffer.c: Integer signedness fixes.
3375 (alloc_buffer_text, enlarge_buffer_text):
3376 Use ptrdiff_t rather than size_t when either will do, as we prefer
3379 * alloc.c: Integer signedness and overflow fixes.
3380 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3381 (__malloc_size_t): Default to size_t, not to int.
3382 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3383 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3384 Prefer ptrdiff_t to size_t when either would do, as we prefer
3386 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3387 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3388 Now const. Initialize with values that are in range even if char
3390 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3391 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3392 These functions do the right thing with sizes > 2**32.
3393 (check_depth): Now ptrdiff_t, not int.
3394 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3395 Adjust to new way of storing sizes. Check for size overflow bugs
3397 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3398 slightly wrong anyway, as it missed one instance of
3399 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3400 (refill_memory_reserve): Omit needless cast to size_t.
3401 (mark_object_loop_halt): Mark as externally visible.
3403 * xselect.c: Integer signedness and overflow fixes.
3404 (Fx_register_dnd_atom, x_handle_dnd_message):
3405 Use ptrdiff_t, not size_t, since we prefer signed.
3406 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3407 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3408 x_dnd_atoms_size and x_dnd_atoms_length.
3410 * doprnt.c: Prefer signed to unsigned when either works.
3412 * doprnt.c (doprnt):
3414 * xdisp.c (vmessage):
3415 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3416 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3417 prefer signed arithmetic to avoid comparison confusion.
3418 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3419 but is a bit tricky.
3421 Assume freestanding C89 headers, string.h, stdlib.h.
3422 * data.c, doprnt.c, floatfns.c, print.c:
3423 Include float.h unconditionally.
3424 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3425 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3426 * regex.c: Likewise for stddef.h, string.h.
3427 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3428 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3429 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3430 (STDC_HEADERS): Remove obsolete defines.
3431 * sysdep.c: Include limits.h unconditionally.
3433 Assume support for memcmp, memcpy, memmove, memset.
3434 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3435 * regex.c (memcmp, memcpy):
3436 Remove; we assume C89 now.
3438 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3439 (__malloc_safe_bcopy): Remove; no longer needed.
3441 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3442 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3443 well either way, and we prefer signed to unsigned.
3445 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3447 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3448 closes the connection while we're reading (bug#9182).
3450 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3452 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3453 are specified (Bug#9168).
3455 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3457 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3458 Found by GCC static checking and --with-wide-int on a 32-bit host.
3460 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3462 * xdisp.c (compute_display_string_pos): Fix logic of caching
3463 previous display string position. Initialize cached_prev_pos to
3464 -1. Fixes slow-down at the beginning of a buffer.
3466 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3468 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3469 for attrs[LFACE_FONTSET_INDEX].
3471 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3473 * xml.c (parse_region): Remove unused local
3474 that was recently introduced.
3476 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3478 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3479 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3481 * xdisp.c (move_it_in_display_line_to): Record the best matching
3482 position for TO_CHARPOS while scanning the line, and restore it on
3483 exit if none of the characters scanned was an exact match.
3484 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3485 when exact match is impossible due to invisible text, and the
3486 lines are truncated.
3488 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3490 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3493 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3495 Fix a significant slow-down of cursor motion with C-n, C-p,
3496 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3497 auto-repeat under bidi redisplay in fontified buffers.
3498 * xdisp.c (compute_stop_pos_backwards): New function.
3499 (next_element_from_buffer): Call compute_stop_pos_backwards to
3500 find a suitable prev_stop when we find ourselves before
3502 (reseat): Don't look for prev_stop, as that could mean a very long
3504 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3505 <cached_disp_overlay_modiff>: Cache for last found display string
3507 (compute_display_string_pos): Return the cached position if asked
3508 about the same buffer in the same area of character positions, and
3509 the buffer wasn't changed since the time the display string
3510 position was cached.
3512 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3514 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3515 is an integer, which is important for empty lines. (Bug#9149)
3517 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3519 * frame.c (Fmodify_frame_parameters): In tty case, update the
3520 default face if necessary (Bug#4238).
3522 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3524 * editfns.c (Fstring_to_char): No need to explain what a character
3525 is in the docstring (Bug#6576).
3527 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3529 * xml.c (parse_region): Make sure we always return a tree.
3531 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3533 * xml.c (parse_region): If a document contains only comments,
3536 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3538 * xml.c (make_dom): Return comments, too.
3540 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3543 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3544 and the surrounding thread.
3545 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3546 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3547 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3549 * s/openbsd.h (BROKEN_SIGIO): Define.
3550 * unexelf.c (unexec) [__OpenBSD__]:
3551 Don't update the .mdebug section of the Alpha COFF symbol table.
3553 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3555 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3558 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3560 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3561 This fixes some race conditions on the permissions of any newly
3564 * alloc.c (valid_pointer_p): Use pipe, not open.
3565 This fixes some permissions issues when debugging.
3567 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3568 If fchown fails to set both uid and gid, try to set just gid,
3569 as that is sometimes allowed. Adjust the file's mode to eliminate
3570 setuid or setgid bits that are inappropriate if fchown fails.
3572 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3574 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3575 to compare Lisp_Objects.
3576 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3577 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3578 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3580 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3582 * lread.c (read_integer): Unread even EOF character.
3583 (read1): Likewise. Properly record start position of symbol.
3585 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3586 symbol character follows.
3588 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3590 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3591 This works around a problem with the previous change to Fcopy_file.
3592 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3593 and without this change, GCC might complain about discarding
3594 fchown's return value.
3596 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3598 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3600 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3602 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3604 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3606 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3607 it's used from the C level.
3609 * process.c: Use the same condition for POLL_FOR_INPUT in both
3610 keyboard.c and process.c (bug#1858).
3612 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3614 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3615 (Fgnutls_boot): Use it.
3617 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3619 * doc.c (Fsubstitute_command_keys): Revert last change.
3621 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3623 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3624 quotes the next character, and doesn't affect other longer
3625 sequences (bug#8935).
3627 * lread.c (syms_of_lread): Clarify that is isn't only
3628 `eval-buffer' and `eval-defun' that's affected by
3629 `lexical-binding' (bug#8460).
3631 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3633 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3634 bidi redisplay when a line includes both an image and is truncated.
3636 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3638 Fix minor problems found by static checking.
3639 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3640 (elsz): Now a signed constant, not a size_t var. We prefer signed
3641 types to unsigned, to avoid integer comparison confusion. Without
3642 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3643 "cannot optimize loop, the loop counter may overflow", a symptom
3645 * indent.c (Fvertical_motion): Mark locals as initialized.
3646 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3648 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3650 * search.c (Fre_search_backward): Mention `case-fold-search' in
3651 all the re_search_* functions (bug#8138).
3653 * keyboard.c (Fopen_dribble_file): Document when the file is
3656 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3658 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3661 Support bidi reordering of display and overlay strings.
3662 * xdisp.c (compute_display_string_pos)
3663 (compute_display_string_end): Accept additional argument STRING.
3664 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3665 (reseat_to_string): Initialize bidi_it->string.s and
3666 bidi_it->string.schars.
3667 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3668 NULL (avoids a crash in bidi_paragraph_init).
3669 Initialize itb.string.lstring.
3670 (init_iterator): Call bidi_init_it only of a valid
3671 buffer position was specified. Initialize paragraph_embedding to
3673 (reseat_to_string): Initialize the bidi iterator.
3674 (display_string): If we need to ignore text properties of
3675 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3676 original value of -1 will not work with bidi.)
3677 (compute_display_string_pos): First arg is now struct
3678 `text_pos *'; all callers changed. Support display properties on
3680 (compute_display_string_end): Support display properties on Lisp
3682 (init_iterator, reseat_1, reseat_to_string): Initialize the
3683 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3684 when iterating on a string not from display properties).
3685 (compute_display_string_pos, compute_display_string_end):
3686 Fix calculation of the object to scan. Fixes an error when using
3688 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3689 base_level_stop; instead, set base_level_stop to BEGV.
3690 Fixes crashes in vertical-motion.
3691 (next_element_from_buffer): Improve commentary for when
3692 the iterator is before prev_stop.
3693 (init_iterator): Initialize bidi_p from the default value of
3694 bidi-display-reordering, not from buffer-local value. Use the
3695 buffer-local value only if initializing for buffer iteration.
3696 (handle_invisible_prop): Support invisible properties on strings
3697 that are being bidi-reordered.
3698 (set_iterator_to_next): Support bidi reordering of C strings and
3700 (next_element_from_string): Support bidi reordering of Lisp
3702 (handle_stop_backwards): Support Lisp strings as well.
3703 (display_string): Support display of R2L glyph rows.
3704 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3705 (init_iterator): Don't initialize it->bidi_p for strings
3707 (reseat_to_string): Initialize it->bidi_p for strings here.
3708 (next_element_from_string, next_element_from_c_string)
3709 (next_element_from_buffer): Add xassert's for correspondence
3710 between IT's object being iterated and it->bidi_it.string
3712 (face_before_or_after_it_pos): Support bidi iteration.
3713 (next_element_from_c_string): Handle the case of the first string
3714 character that is not the first one in the visual order.
3715 (get_visually_first_element): New function, refactored from common
3716 parts of next_element_from_buffer, next_element_from_string, and
3717 next_element_from_c_string.
3718 (tool_bar_lines_needed, redisplay_tool_bar)
3719 (display_menu_bar): Force left-to-right direction. Add a FIXME
3720 comment for making that be controlled by a user option.
3721 (push_it, pop_it): Save and restore the state of the
3722 bidi iterator. Save and restore the bidi_p flag.
3723 (pop_it): Iterate out of display property for string iteration as
3725 (iterate_out_of_display_property): Support iteration over strings.
3726 (handle_single_display_spec): Set up it->bidi_it for iteration
3727 over a display string, and call bidi_init_it.
3728 (handle_single_display_spec, next_overlay_string)
3729 (get_overlay_strings_1, push_display_prop): Set up the bidi
3730 iterator for displaying display or overlay strings.
3731 (forward_to_next_line_start): Don't use the shortcut if
3733 (back_to_previous_visible_line_start): If handle_display_prop
3734 pushed the iterator stack, restore the internal state of the bidi
3735 iterator by calling bidi_pop_it same number of times.
3736 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3737 and we are bidi-iterating, don't decrement the iterator position;
3738 instead, set the first_elt flag in the bidi iterator, to produce
3740 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3741 (push_display_prop): xassert that we are iterating a buffer.
3742 (push_it, pop_it): Save and restore paragraph_embedding member.
3743 (handle_single_display_spec, next_overlay_string)
3744 (get_overlay_strings_1, reseat_1, reseat_to_string)
3745 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3746 correctly. Don't assume unibyte strings are not bidi-reordered.
3747 (compute_display_string_pos)
3748 (compute_display_string_end): Fix handling the case of C string.
3749 (push_it, pop_it): Save and restore from_disp_prop_p.
3750 (handle_single_display_spec, push_display_prop): Set the
3751 from_disp_prop_p flag.
3752 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3753 (pop_it): Call iterate_out_of_display_property only if we are
3754 popping after iteration over a string that came from a display
3755 property. Fix a typo in popping stretch info. Add an assertion
3756 for verifying that the iterator position is in sync with the bidi
3758 (handle_single_display_spec, get_overlay_strings_1)
3759 (push_display_prop): Fix initialization of paragraph direction for
3760 string when that of the parent object is not yet determined.
3761 (reseat_1): Call bidi_init_it to resync the bidi
3762 iterator with IT's position. (Bug#7616)
3763 (find_row_edges): If ROW->start.pos gives position
3764 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3765 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3766 Reset the from_disp_prop_p flag.
3767 (SAVE_IT, RESTORE_IT): New macros.
3768 (pos_visible_p, face_before_or_after_it_pos)
3769 (back_to_previous_visible_line_start)
3770 (move_it_in_display_line_to, move_it_in_display_line)
3771 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3772 (try_scrolling, redisplay_window, display_line): Use them when
3773 saving a temporary copy of the iterator and restoring it back.
3774 (back_to_previous_visible_line_start, reseat_1)
3775 (init_iterator): Empty the bidi cache "stack".
3776 (move_it_in_display_line_to): If iterator ended up at
3777 EOL, but we never saw any buffer positions smaller than
3778 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3779 motion in bidi-reordered lines.
3780 (move_it_in_display_line_to): Record prev_method and prev_pos
3781 immediately before the call to set_iterator_to_next. Fixes cursor
3782 motion in bidi-reordered lines with stretch glyphs and strings
3783 displayed in margins. (Bug#8133) (Bug#8867)
3784 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3786 (pos_visible_p): Support positions in bidi-reordered lines.
3787 Save and restore bidi cache.
3789 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3790 (bidi_paragraph_info): Delete unused struct.
3791 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3792 (bidi_cache_start): New variable.
3793 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3795 (bidi_cache_fetch_state, bidi_cache_search)
3796 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3797 (bidi_cache_find, bidi_peek_at_next_level)
3798 (bidi_level_of_next_char, bidi_find_other_level_edge)
3799 (bidi_move_to_visually_next): Compare cache index with
3800 bidi_cache_start rather than with zero.
3801 (bidi_fetch_char): Accept new argument STRING; all callers
3802 changed. Support iteration over a string. Support strings with
3803 display properties. Support unibyte strings. Fix the type of
3804 `len' according to what STRING_CHAR_AND_LENGTH expects.
3805 (bidi_paragraph_init, bidi_resolve_explicit_1)
3806 (bidi_resolve_explicit, bidi_resolve_weak)
3807 (bidi_level_of_next_char, bidi_move_to_visually_next):
3808 Support iteration over a string.
3809 (bidi_set_sor_type, bidi_resolve_explicit_1)
3810 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3811 can now be zero (for strings); special values 0 and -1 were
3812 changed to -1 and -2, respectively.
3813 (bidi_char_at_pos): New function.
3814 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3815 Call it instead of FETCH_MULTIBYTE_CHAR.
3816 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3817 initialized to valid values.
3818 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3820 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3821 the test for valid cached positions. Fix the logic for looking up
3822 the sentinel state in the cache. GCPRO the Lisp string we are
3824 (bidi_push_it, bidi_pop_it): New functions.
3825 (bidi_initialize): Initialize the bidi cache start stack pointer.
3826 (bidi_cache_ensure_space): New function, refactored from part of
3827 bidi_cache_iterator_state. Don't assume the required size is just
3828 one BIDI_CACHE_CHUNK away.
3829 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3830 (bidi_count_bytes, bidi_char_at_pos): New functions.
3831 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3832 always valid if bidi_cache_idx is valid.
3833 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3834 is valid if it's going to be used.
3835 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3836 (bidi_cache_fetch_state, bidi_cache_search)
3837 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3838 (bidi_cache_iterator_state, bidi_cache_find)
3839 (bidi_find_other_level_edge, bidi_cache_start_stack):
3840 All variables related to cache indices are now EMACS_INT.
3842 * dispextern.h (struct bidi_string_data): New structure.
3843 (struct bidi_it): New member `string'. Make flag members be 1-bit
3844 fields, and put them last in the struct.
3845 (compute_display_string_pos, compute_display_string_end):
3847 (bidi_push_it, bidi_pop_it): Add prototypes.
3848 (struct iterator_stack_entry): New members bidi_p,
3849 paragraph_embedding, and from_disp_prop_p.
3850 (struct it): Member bidi_p is now a bit field 1 bit wide.
3851 (bidi_shelve_cache, bidi_unshelve_cache):
3854 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3855 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3856 and vector-like objects.
3858 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3859 cache around display iteration.
3861 * window.c (Fwindow_end, window_scroll_pixel_based)
3862 (displayed_window_lines, Frecenter): Save and restore the bidi
3863 cache around display iteration.
3865 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3867 * editfns.c (Fdelete_region): Clarify the use of the named
3868 parameters (bug#6788).
3870 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3872 * indent.c (Fvertical_motion): Set and restore w->pointm when
3873 saving and restoring the window's buffer (Bug#9006).
3875 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3877 * editfns.c (Fstring_to_char): Clarify just what is returned
3878 (bug#6576). Text by Eli Zaretskii.
3880 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3882 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3884 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3886 * buffer.c (mmap_find): Fix a typo.
3888 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3890 Fix execution of x selection hooks.
3891 * xselect.c (Qx_lost_selection_functions)
3892 (Qx_sent_selection_functions): New vars.
3893 (syms_of_xselect): DEFSYM them.
3894 (x_handle_selection_request): Pass Qx_sent_selection_functions
3895 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3896 (x_handle_selection_clear,x_clear_frame_selections):
3897 Pass Qx_lost_selection_functions rather than
3898 Vx_lost_selection_functions to Frun_hook_with_args.
3900 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3902 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3903 The old code sometimes used this field without initializing it.
3905 * alloc.c (gc_sweep): Don't read past end of array.
3906 In theory, the old code could also have corrupted Emacs internals,
3907 though it'd be very unlikely.
3909 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3911 * character.c (Fcharacterp): Don't advertise optional ignored
3912 argument. (Bug#4026)
3914 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3916 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3919 * window.c (Fset_window_start): Doc fix (bug#4199).
3920 (Fset_window_hscroll): Ditto.
3922 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3924 Fix minor new problems caught by GCC 4.6.1.
3925 * term.c (init_tty): Remove unused local.
3926 * xsettings.c (store_monospaced_changed): Define this function only
3927 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3930 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3932 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3934 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3936 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3937 are the mini-buffer and the echo area (bug#3320).
3939 * term.c (init_tty): Remove support for supdup, c10 and perq
3940 terminals, which are no longer supported (bug#1482).
3942 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3944 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3946 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3948 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3949 for non-popups (Bug#3642).
3951 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3953 * alloc.c (reset_malloc_hooks): Protoize.
3954 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3955 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3956 * cm.c (losecursor): Likewise.
3957 * data.c (fmod): Likewise.
3958 * dispnew.c (swap_glyphs_in_rows): Likewise.
3959 * emacs.c (memory_warning_signal): Likewise.
3960 * floatfns.c (float_error): Likewise.
3961 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3962 (otf_open, font_otf_capability, generate_otf_features)
3963 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3965 * image.c (pbm_read_file): Likewise.
3966 * indent.c (string_display_width): Likewise.
3967 * intervals.c (check_for_interval, search_for_interval)
3968 (inc_interval_count, count_intervals, root_interval)
3969 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3970 * lread.c (defalias): Likewise.
3971 * ralloc.c (r_alloc_check): Likewise.
3972 * regex.c (set_image_of_range_1, set_image_of_range)
3973 (regex_grow_registers): Likewise.
3974 * sysdep.c (strerror): Likewise.
3975 * termcap.c (valid_filename_p, tprint, main): Likewise.
3976 * tparam.c (main): Likewise.
3977 * unexhp9k800.c (run_time_remap, save_data_space)
3978 (update_file_ptrs, read_header, write_header, calculate_checksum)
3979 (copy_file, copy_rest, display_header): Likewise.
3980 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3982 * xdisp.c (check_it): Likewise.
3983 * xfaces.c (register_color, unregister_color, unregister_colors):
3985 * xfns.c (print_fontset_result): Likewise.
3986 * xrdb.c (member, fatal, main): Likewise.
3988 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3990 Fix minor problems found by static checking (Bug#9031).
3991 * chartab.c (char_table_set_range, map_sub_char_table):
3992 Remove unused locals.
3993 (uniprop_table): Now static.
3994 * composite.c (_work_char): Remove unused static var.
3996 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3998 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4000 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4002 * gtkutil.c (qttip_cb): Remove code without function.
4004 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4006 * w32.c (pthread_sigmask): New stub.
4008 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4010 Use pthread_sigmask, not sigprocmask (Bug#9010).
4011 sigprocmask is portable only for single-threaded applications, and
4012 Emacs can be multi-threaded when it uses GTK.
4013 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4015 * callproc.c (Fcall_process):
4016 * process.c (create_process):
4017 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4018 Use pthread_sigmask, not sigprocmask.
4020 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4022 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4023 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4026 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4028 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4029 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4030 (xg_hide_tooltip): Fix comment.
4032 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4033 in registerServicesMenuSendTypes.
4034 (validRequestorForSendType): Don't check ns_return_types.
4036 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4039 2011-07-08 Jason Rumney <jasonr@gnu.org>
4041 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4042 SH_SHOW for hidden windows (Bug#5482).
4044 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4045 frame struct members of non-existent frames (Bug#6284).
4047 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4049 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4050 variable firstTime not needed on OSX >= 10.6.
4051 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4052 >= 10.5. Use setKnobProportion, setDoubleValue.
4054 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4055 (MAC_OS_X_VERSION_10_5): Define if not defined.
4056 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4057 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4058 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4060 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4061 cString and lossyCString on OSX >= 10.4
4063 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4064 sizeToFit on OSX >= 10.2.
4066 * nsimage.m (allocInitFromFile): Don't use deprecated method
4067 bestRepresentationForDevice on OSX >= 10.6.
4069 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4072 * emacs.c: Declare unexec_init_emacs_zone.
4074 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4076 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4078 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4079 on svcsMenu (Bug#8842).
4081 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4083 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4085 * nsterm.m (QUTF8_STRING): Declare.
4086 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4087 (validRequestorForSendType): Return type is (id).
4088 Change indexOfObjectIdenticalTo to indexOfObject.
4089 Check if we have local selection before returning self (Bug#8842).
4090 (writeSelectionToPasteboard): Put local selection into paste board
4091 if we have a local selection (Bug#8842).
4092 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4094 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4095 (ns_get_local_selection): Declare.
4097 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4099 * keymap.c (describe_map_tree): Don't insert a double newline at
4100 the end of the buffer (bug#1169) and return whether we inserted
4103 * callint.c (Fcall_interactively): Change "reading args" to
4104 "providing args" to try to clarify what it does (bug#1010).
4106 2011-07-07 Kenichi Handa <handa@m17n.org>
4108 * composite.c (composition_compute_stop_pos): Ignore a static
4109 composition starting before CHARPOS (Bug#8915).
4111 * xdisp.c (handle_composition_prop): Likewise.
4113 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4115 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4118 2011-07-07 Kenichi Handa <handa@m17n.org>
4120 * character.h (unicode_category_t): New enum type.
4122 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4123 (Qchar_code_property_table): New variable.
4124 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4125 (UNIPROP_COMPRESSED_FORM_P): New macros.
4126 (char_table_ascii): Uncompress the compressed values.
4127 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4128 Uncompress the compressed values.
4129 (sub_char_table_ref_and_range): Likewise.
4130 (char_table_ref_and_range): Uncompress the compressed values.
4131 (sub_char_table_set): New arg is_uniprop. Callers changed.
4132 Uncompress the compressed values.
4133 (sub_char_table_set_range): Args changed. Callers changed.
4134 (char_table_set_range): Adjuted for the above change.
4135 (map_sub_char_table): Delete args default_val and parent. Add arg
4136 top. Give decoded values to a Lisp function.
4137 (map_char_table): Adjust for the above change. Give decoded
4138 values to a Lisp function. Gcpro more variables.
4139 (uniprop_table_uncompress)
4140 (uniprop_decode_value_run_length): New functions.
4141 (uniprop_decoder, uniprop_decoder_count): New variables.
4142 (uniprop_get_decoder, uniprop_encode_value_character)
4143 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4145 (uniprop_encoder, uniprop_encoder_count): New variables.
4146 (uniprop_get_encoder, uniprop_table)
4147 (Funicode_property_table_internal, Fget_unicode_property_internal)
4148 (Fput_unicode_property_internal): New functions.
4149 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4150 Sunicode_property_table_internal, Sget_unicode_property_internal,
4151 and Sput_unicode_property_internal. Defvar_lisp
4152 char-code-property-alist.
4154 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4155 Vunicode_category_table.
4157 * font.c (font_range): Adjust for the change of
4158 Vunicode_category_table.
4160 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4162 * m/iris4d.h: Remove file, move contents ...
4163 * s/irix6-5.h: ... here.
4165 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4167 Remove unportable assumption about struct layout (Bug#8884).
4168 * alloc.c (mark_buffer):
4169 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4170 (clone_per_buffer_values): Don't assume that
4171 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4172 This isn't true in general, and it's particularly not true
4173 if Emacs is configured with --with-wide-int.
4174 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4175 New macros, used in the buffer.c change.
4177 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4179 * xsettings.c: Use both GConf and GSettings if both are available.
4180 (store_config_changed_event): Add comment.
4181 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4182 (store_tool_bar_style_changed): New functions.
4183 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4184 (struct xsettings): Move font inside HAVE_XFT.
4185 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4186 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4187 Move inside HAVE_XFT.
4188 (something_changed_gsettingsCB): Rename from something_changedCB.
4189 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4191 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4192 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4193 (something_changed_gconfCB): Rename from something_changedCB.
4194 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4195 (parse_settings): Move check for font inside HAVE_XFT.
4196 (read_settings, apply_xft_settings): Add comment.
4197 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4198 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4199 call store_font_name_changed.
4200 (xft_settings_event): Add comment.
4201 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4202 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4203 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4204 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4205 (xsettings_initialize): Call init_gsettings last.
4206 (xsettings_get_system_font, xsettings_get_system_normal_font):
4209 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4211 Random fixes. E.g., (random) never returned negative values.
4212 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4213 subseconds part to the entropy, as that's a bit more random.
4214 Prefer signed to unsigned, since the signedness doesn't matter and
4215 in general we prefer signed. When given a limit, use a
4216 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4217 latter isn't right if USE_2_TAGS_FOR_INTS.
4218 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4219 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4221 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4223 * textprop.c (text_property_stickiness):
4224 Obey Vtext_property_default_nonsticky.
4225 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4226 * w32fns.c (syms_of_w32fns):
4227 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4229 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4231 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4232 This is more efficient than Ffile_directory_p and avoids a minor race.
4234 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4236 * buffer.c (Foverlay_put): Say what the return value is
4239 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4240 is a directory before asking whether to use the file name
4242 (barf_or_query_if_file_exists): Make the "File is a directory"
4243 error be more correct.
4245 * fns.c (Frequire): Remove the mention of the .gz files, since
4246 that's installation-specific, but keep the mention of
4247 `get-load-suffixes'.
4249 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4251 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4252 Report string overflow if the output is too long.
4254 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4256 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4257 (syms_of_gnutls): Remove duplicate DEFSYM for
4258 Qgnutls_bootprop_verify_hostname_error, an error for
4259 Qgnutls_bootprop_verify_error (which is no longer used).
4261 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4262 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4263 Also (re)move comments that are misplaced or no longer relevant.
4265 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4267 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4269 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4271 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4272 and background color parameters if they have been changed.
4274 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4276 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4278 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4280 * xsettings.c (SYSTEM_FONT): Define only when used.
4281 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4283 * keymap.c (access_keymap_1): Now static.
4285 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4287 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4288 leave any prefix arg for the up event (Bug#1586).
4290 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4292 * lread.c (syms_of_lread): Mention single symbols defined by
4293 `defvar' or `defconst' (bug#7154).
4295 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4296 (Frequire): Mention get-load-suffixes.
4298 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4300 * window.h (window): Remove clone_number slot.
4301 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4303 (make_parent_window, make_window, saved_window)
4304 (Fset_window_configuration, save_window_save): Don't deal with
4306 * buffer.c (Qclone_number): Remove declaration.
4307 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4309 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4311 Add multiple inheritance to keymaps.
4312 * keymap.c (Fmake_composed_keymap): New function.
4313 (Fset_keymap_parent): Simplify.
4314 (fix_submap_inheritance): Remove.
4315 (access_keymap_1): New function extracted from access_keymap to handle
4316 embedded parents and handle lists of maps.
4317 (access_keymap): Use it.
4318 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4319 (Fcopy_keymap): Handle embedded parents.
4320 (Fcommand_remapping, define_as_prefix): Simplify.
4321 (Fkey_binding): Simplify.
4322 (syms_of_keymap): Move minibuffer-local-completion-map,
4323 minibuffer-local-filename-completion-map,
4324 minibuffer-local-must-match-map, and
4325 minibuffer-local-filename-must-match-map to Elisp.
4326 (syms_of_keymap): Defsubr make-composed-keymap.
4327 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4328 (parse_menu_item): Trivial simplification.
4330 2011-07-01 Glenn Morris <rgm@gnu.org>
4332 * Makefile.in (SETTINGS_LIBS): Fix typo.
4334 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4336 * coding.c (Fencode_coding_string): Record the last coding system
4337 used, as the function doc string says (bug#8738).
4339 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4341 * xsettings.c (store_monospaced_changed): Take new font as arg and
4342 check for change against current_mono_font.
4343 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4344 (emacs_settings_constructor, emacs_settings_get_property)
4345 (emacs_settings_set_property, emacs_settings_class_init)
4346 (emacs_settings_init, gsettings_obj): Remove.
4347 (something_changedCB): New function for HAVE_GSETTINGS.
4348 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4349 with value as argument.
4350 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4351 g_settings_new (Bug#8967). Do not create gsettings_obj.
4352 Remove calls to g_settings_bind. Connect something_changedCB to
4355 * xgselect.c: Add defined (HAVE_GSETTINGS).
4356 (xgselect_initialize): Ditto.
4358 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4359 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4362 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4364 * eval.c (struct backtrace): Simplify and port the data structure.
4365 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4366 signed bit field, as this assumption is not portable and it makes
4367 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4368 "char debug_on_exit : 1" as this is not portable either; instead,
4369 use the portable "unsigned int debug_on_exit : 1". Remove unused
4370 member evalargs. Remove obsolete comments about cc bombing out.
4372 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4374 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4375 Let HAVE_GSETTINGS override HAVE_GCONF.
4376 (store_monospaced_changed): New function.
4377 (EMACS_SETTINGS): A new type derived from GObject to handle
4378 GSettings notifications.
4379 (emacs_settings_constructor, emacs_settings_get_property)
4380 (emacs_settings_set_property, emacs_settings_class_init):
4382 (gsettings_client, gsettings_obj): New variables.
4383 (GSETTINGS_SCHEMA): New define.
4384 (something_changedCB): Call store_monospaced_changed.
4385 (init_gsettings): New function.
4386 (xsettings_initialize): Call init_gsettings.
4387 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4390 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4393 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4395 * window.c (resize_root_window, grow_mini_window)
4396 (shrink_mini_window): Rename Qresize_root_window to
4397 Qwindow_resize_root_window and Qresize_root_window_vertically to
4398 Qwindow_resize_root_window_vertically.
4400 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4402 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4404 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4406 * makefile.w32-in: Redesign dependencies so they reflect more
4407 clearly which files are directly included by each source file,
4408 and not through other includes.
4410 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4412 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4413 (sort_overlays, overlay_strings): When an overlay's clone number
4414 matches the window's clone number process the overlay even if
4415 the overlay's window property doesn't match the current window.
4417 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4418 (Fwindow_hchild): Rename to Fwindow_left_child.
4419 (Fwindow_next): Rename to Fwindow_next_sibling.
4420 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4421 (resize_window_check): Rename to window_resize_check.
4422 (resize_window_apply): Rename to window_resize_apply.
4423 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4424 (Fdelete_other_windows_internal, resize_frame_windows)
4425 (Fsplit_window_internal, Fdelete_window_internal)
4426 (grow_mini_window, shrink_mini_window)
4427 (Fresize_mini_window_internal): Fix callers accordingly.
4429 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4431 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4432 (emacs_fixed_set_min_size): Remove.
4433 (emacs_fixed_new): Take frame as argument.
4435 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4436 (_EmacsFixedPrivate): Remove minwidth/height.
4437 Add struct frame *f.
4438 (emacs_fixed_init): Initialize priv->f.
4439 (get_parent_class, emacs_fixed_set_min_size): Remove.
4440 (emacs_fixed_new): Set priv->f to argument.
4441 (emacs_fixed_get_preferred_width)
4442 (emacs_fixed_get_preferred_height): Use min_width/height from
4443 frames size_hint to set minimum and natural (Bug#8919).
4444 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4445 and use min_width/height from frames size_hint to set
4446 min_width/height (Bug#8919).
4448 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4449 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4452 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4454 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4455 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4458 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4460 * process.c (wait_reading_process_output): Bypass select if
4461 waiting for a cell while ignoring keyboard input, and input is
4462 pending. Suggested by Jan Djärv (Bug#8869).
4464 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4466 Use gnulib's dup2 module instead of rolling our own.
4467 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4469 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4471 * dispnew.c (scrolling_window): Before scrolling, turn off a
4472 mouse-highlight in the window being scrolled.
4474 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4476 Move DEFSYM to lisp.h and use everywhere.
4478 * character.h (DEFSYM): Move declaration...
4479 * lisp.h (DEFSYM): ...here.
4485 * w32select.c: Don't include character.h.
4487 * alloc.c (syms_of_alloc):
4488 * buffer.c (syms_of_buffer):
4489 * bytecode.c (syms_of_bytecode):
4490 * callint.c (syms_of_callint):
4491 * casefiddle.c (syms_of_casefiddle):
4492 * casetab.c (init_casetab_once):
4493 * category.c (init_category_once, syms_of_category):
4494 * ccl.c (syms_of_ccl):
4495 * cmds.c (syms_of_cmds):
4496 * composite.c (syms_of_composite):
4497 * dbusbind.c (syms_of_dbusbind):
4498 * dired.c (syms_of_dired):
4499 * dispnew.c (syms_of_display):
4500 * doc.c (syms_of_doc):
4501 * editfns.c (syms_of_editfns):
4502 * emacs.c (syms_of_emacs):
4503 * eval.c (syms_of_eval):
4504 * fileio.c (syms_of_fileio):
4505 * fns.c (syms_of_fns):
4506 * frame.c (syms_of_frame):
4507 * fringe.c (syms_of_fringe):
4508 * insdel.c (syms_of_insdel):
4509 * keymap.c (syms_of_keymap):
4510 * lread.c (init_obarray, syms_of_lread):
4511 * macros.c (syms_of_macros):
4512 * msdos.c (syms_of_msdos):
4513 * print.c (syms_of_print):
4514 * process.c (syms_of_process):
4515 * search.c (syms_of_search):
4516 * sound.c (syms_of_sound):
4517 * syntax.c (init_syntax_once, syms_of_syntax):
4518 * terminal.c (syms_of_terminal):
4519 * textprop.c (syms_of_textprop):
4520 * undo.c (syms_of_undo):
4521 * w32.c (globals_of_w32):
4522 * window.c (syms_of_window):
4523 * xdisp.c (syms_of_xdisp):
4524 * xfaces.c (syms_of_xfaces):
4525 * xfns.c (syms_of_xfns):
4526 * xmenu.c (syms_of_xmenu):
4527 * xsettings.c (syms_of_xsettings):
4528 * xterm.c (syms_of_xterm): Use DEFSYM.
4530 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4532 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4534 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4536 Integer and buffer overflow fixes (Bug#8873).
4538 * print.c (printchar, strout): Check for string overflow.
4539 (PRINTPREPARE, printchar, strout):
4540 Don't set size unless allocation succeeds.
4542 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4543 for sizes. Check for string overflow more accurately.
4544 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4546 * macros.c: Integer and buffer overflow fixes.
4547 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4548 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4549 Use ptrdiff_t, not int, for sizes.
4550 Don't increment bufsize until after realloc succeeds.
4551 Check for size-calculation overflow.
4552 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4554 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4556 * lread.c: Integer overflow fixes.
4557 (read_integer): Radix is now EMACS_INT, not int,
4558 to improve quality of diagnostics for out-of-range radices.
4559 Calculate buffer size correctly for out-of-range radices.
4560 (read1): Check for integer overflow in radices, and in
4561 read-circle numbers.
4562 (read_escape): Avoid int overflow.
4563 (Fload, openp, read_buffer_size, read1)
4564 (substitute_object_recurse, read_vector, read_list, map_obarray):
4565 Use ptrdiff_t, not int, for sizes.
4566 (read1): Use EMACS_INT, not int, for sizes.
4567 Check for size overflow.
4569 * image.c (cache_image): Check for size arithmetic overflow.
4571 * lread.c: Integer overflow issues.
4572 (saved_doc_string_size, saved_doc_string_length)
4573 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4574 Now ptrdiff_t, not int.
4575 (read1): Don't assume doc string length fits in int. Check for
4576 out-of-range doc string lengths.
4577 (read_list): Don't assume file position fits in int.
4578 (read_escape): Check for hex character overflow.
4580 2011-06-22 Leo Liu <sdl.web@gmail.com>
4582 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4583 Move to minibuffer.el.
4585 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4587 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4588 The following patches are for when GLYPH_DEBUG && !XASSERT.
4589 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4590 * dispnew.c (flush_stdout):
4591 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4592 Mark as externally visible.
4593 * dispnew.c (check_window_matrix_pointers): Now static.
4594 * dispnew.c (window_to_frame_vpos):
4595 * xfns.c (unwind_create_frame):
4596 * xterm.c (x_check_font): Remove unused local.
4597 * scroll.c (CHECK_BOUNDS):
4598 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4599 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4600 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4601 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4602 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4604 (debug_method_add): Use va_list and vsprintf rather than relying
4605 on undefined behavior with wrong number of arguments.
4606 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4607 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4608 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4609 since we're not interested in debugging glyphs with old libraries.
4610 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4611 GCC 4.6.0's static checking.
4613 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4615 Integer overflow and signedness fixes (Bug#8873).
4616 A few related buffer overrun fixes, too.
4618 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4620 * dispextern.h (struct face.stipple):
4621 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4622 (x_bitmap_mask, x_allocate_bitmap_record)
4623 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4624 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4625 (x_create_bitmap_from_xpm_data):
4626 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4627 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4629 * xfaces.c (load_pixmap):
4630 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4631 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4632 (.bitmaps_last, struct x_output.icon_bitmap):
4633 Use ptrdiff_t, not int, for bitmap indexes.
4634 (x_allocate_bitmap_record): Check for size overflow.
4635 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4637 Use ptrdiff_t, not int, for overlay counts.
4638 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4639 * editfns.c (overlays_around, get_pos_property):
4640 * textprop.c (get_char_property_and_overlay):
4641 * xdisp.c (next_overlay_change, note_mouse_highlight):
4642 * xfaces.c (face_at_buffer_position):
4643 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4644 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4645 (Fnext_overlay_change, Fprevious_overlay_change)
4646 (mouse_face_overlay_overlaps, Foverlays_in):
4647 Use ptrdiff_t, not int, for sizes.
4648 (overlays_at, overlays_in): Check for size-calculation overflow.
4650 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4652 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4653 (x_session_initialize): Do not assume string length fits in int.
4655 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4656 This is unlikely, but can occur if DPI is outlandish.
4658 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4659 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4661 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4662 * xrdb.c (magic_file_p, search_magic_path):
4663 Omit last arg SUFFIX; it was always 0. All callers changed.
4664 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4666 * xfont.c (xfont_match): Avoid need for strlen.
4668 * xfns.c: Don't assume strlen fits in int.
4669 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4671 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4672 not unsigned long, as we prefer signed integers. All callers changed.
4673 Detect integer overflow in repeat count.
4674 (message_dolog): Don't assume print length fits in 39 bytes.
4675 (display_mode_element): Don't assume strlen fits in int.
4677 * termcap.c: Don't assume sizes fit in int and never overflow.
4678 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4679 (gobble_line): Check for size-calculation overflow.
4681 * minibuf.c (Fread_buffer):
4682 * lread.c (intern, intern_c_string):
4683 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4684 Don't assume string length fits in int.
4686 * keyboard.c (parse_tool_bar_item):
4687 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4689 * font.c: Don't assume string length fits in int.
4690 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4691 Use ptrdiff_t, not int.
4692 (font_intern_prop): Don't assume string length fits in int.
4693 Don't assume integer property fits in fixnum.
4694 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4696 * filelock.c: Fix some buffer overrun and integer overflow issues.
4697 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4698 Reformulate so as not to need the command string.
4699 Invoke gzip -cd rather than gunzip, as it's more portable.
4700 (lock_info_type, lock_file_1, lock_file):
4701 Don't assume pid_t and time_t fit in unsigned long.
4702 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4703 (current_lock_owner): Prefer signed type for sizes.
4704 Use memcpy, not strncpy, where memcpy is what is really wanted.
4705 Don't assume (via atoi) that time_t and pid_t fit in int.
4706 Check for time_t and/or pid_t out of range, e.g., via a network share.
4707 Don't alloca where an auto var works fine.
4709 * fileio.c: Fix some integer overflow issues.
4710 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4711 Don't assume string length fits in int.
4712 (directory_file_name): Don't assume string length fits in long.
4713 (make_temp_name): Don't assume pid fits in int, or that its print
4714 length is less than 20.
4716 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4718 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4720 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4722 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4723 We prefer signed integers, even for size calculations.
4725 * emacs.c: Don't assume string length fits in 'int'.
4726 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4727 (main): Don't invoke strlen when not needed.
4729 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4730 (XD_DEBUG_MESSAGE): Don't waste a byte.
4732 * callproc.c (getenv_internal_1, getenv_internal)
4734 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4736 * lread.c (invalid_syntax): Omit length argument.
4737 All uses changed. This doesn't fix a bug, but it simplifies the
4738 code away from its former Hollerith-constant appearance, and it's
4739 one less 'int' to worry about when looking at integer-overflow issues.
4740 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4742 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4743 This didn't break anything, but it didn't help either.
4744 It's confusing to put a bogus integer in a place where the actual
4745 value does not matter.
4746 (LIST_END_P): Remove unused macro and its bogus comment.
4747 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4749 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4750 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4752 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4753 We prefer signed types, and the value cannot exceed the EMACS_INT
4754 range anyway (because otherwise the length would not be representable).
4755 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4756 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4757 This avoids a GCC warning when WIDE_EMACS_INT.
4759 * indent.c (sane_tab_width): New function.
4760 (current_column, scan_for_column, Findent_to, position_indentation)
4761 (compute_motion): Use it. This is just for clarity.
4762 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4764 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4766 * lisp.h (lint_assume): New macro.
4767 * composite.c (composition_gstring_put_cache):
4768 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4770 * editfns.c, insdel.c:
4771 Omit unnecessary forward decls, to simplify future changes.
4773 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4775 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4777 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4778 Use much-faster test for byte-length change.
4779 Don't assume string byte-length fits in 'int'.
4780 Check that character arg fits in 'int'.
4781 (mapcar1): Declare byte as byte, for clarity.
4783 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4785 * fns.c (concat): Catch string overflow earlier.
4786 Do not rely on integer wraparound.
4788 * dispextern.h (struct it.overlay_strings_charpos)
4789 (struct it.selective): Now EMACS_INT, not int.
4790 * xdisp.c (forward_to_next_line_start)
4791 (back_to_previous_visible_line_start)
4792 (reseat_at_next_visible_line_start, next_element_from_buffer):
4793 Don't arbitrarily truncate the value of 'selective' to int.
4795 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4797 * composite.c: Don't truncate sizes to 'int'.
4798 (composition_gstring_p, composition_reseat_it)
4799 (composition_adjust_point): Use EMACS_INT, not int.
4800 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4801 not EMACS_UINT, for indexes.
4803 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4805 * buffer.c: Include <verify.h>.
4806 (struct sortvec.priority, struct sortstr.priority):
4807 Now EMACS_INT, not int.
4808 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4809 (struct sortstr.size, record_overlay_string)
4810 (struct sortstrlist.size, struct sortlist.used):
4811 Don't truncate size to int.
4812 (record_overlay_string): Check for size-calculation overflow.
4813 (init_buffer_once): Check at compile-time, not run-time.
4815 2011-06-22 Jim Meyering <meyering@redhat.com>
4817 Don't leak an XBM-image-sized buffer
4818 * image.c (xbm_load): Free the image buffer after using it.
4820 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4823 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4824 that Sun C diagnosed.
4825 * fns.c (secure_hash): Fix pointer signedness issue.
4826 * intervals.c (static_offset_intervals): New function.
4827 (offset_intervals): Use it.
4829 2011-06-21 Leo Liu <sdl.web@gmail.com>
4832 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4835 * fns.c (secure_hash): Rename from crypto_hash_function and change
4836 the first arg to accept symbols.
4837 (Fsecure_hash): New primitive.
4838 (syms_of_fns): New symbols.
4840 2011-06-20 Deniz Dogan <deniz@dogan.se>
4842 * process.c (Fset_process_buffer): Clarify return value in
4845 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4847 * dispnew.c (add_window_display_history): Use BVAR.
4849 * xdisp.c (debug_method_add): Use BVAR.
4850 (check_window_end, dump_glyph_matrix, dump_glyph)
4851 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4853 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4856 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4857 check till after the cache is created in init_frame_faces.
4859 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4861 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4863 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4865 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4866 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4867 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4869 Improve buffer-overflow checking (Bug#8873).
4870 * fileio.c (Finsert_file_contents):
4871 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4872 Remove the old (too-loose) buffer overflow checks.
4873 They weren't needed, since make_gap checks for buffer overflow.
4874 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4875 The old code merely checked for Emacs fixnum overflow, and relied
4876 on undefined (wraparound) behavior. The new code avoids undefined
4877 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4879 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4880 Tune. Don't use wider integers than needed. Don't use alloca.
4881 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4883 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4885 * insdel.c, lisp.h (buffer_overflow): New function.
4886 (insert_from_buffer_1, replace_range, replace_range_2):
4887 * insdel.c (make_gap_larger):
4888 * editfns.c (Finsert_char):
4889 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4891 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4893 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4895 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4897 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4898 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4900 * fileio.c: Don't assume EMACS_INT fits in off_t.
4901 (emacs_lseek): New static function.
4902 (Finsert_file_contents, Fwrite_region): Use it.
4903 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4905 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4907 * fns.c: Don't overflow int when computing a list length.
4908 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4909 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4910 truncation on 64-bit hosts. Check for QUIT every
4911 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4912 faster and is responsive enough.
4913 (Flength): Report an error instead of overflowing an integer.
4914 (Fsafe_length): Return a float if the value is not representable
4915 as a fixnum. This shouldn't happen except in contrived situations.
4916 (Fnthcdr, Fsort): Don't assume list length fits in int.
4917 (Fcopy_sequence): Don't assume vector length fits in int.
4919 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4920 (header_size, word_size): New constants.
4921 (allocate_vectorlike): Don't check size overflow here.
4922 (allocate_vector): Check it here instead, since this is the only
4923 caller of allocate_vectorlike that could cause overflow.
4924 Check that the new vector's length is representable as a fixnum.
4926 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4927 The previous code was bogus. For example, next_almost_prime (32)
4928 returned 39, which is undesirable as it is a multiple of 3; and
4929 next_almost_prime (24) returned 25, which is a multiple of 5 so
4930 why was the code bothering to check for multiples of 7?
4932 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4934 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4936 Variadic C functions now count arguments with ptrdiff_t.
4937 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4938 Back then I didn't know that the Emacs coding style prefers signed int.
4939 Also, in the meantime I found a few more instances where arguments
4940 were being counted with int, which may truncate counts on 64-bit
4941 machines, or EMACS_INT, which may be unnecessarily wide.
4942 * lisp.h (struct Lisp_Subr.function.aMANY)
4943 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4944 Arg counts are now ptrdiff_t, not size_t.
4945 All variadic functions and their callers changed accordingly.
4946 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4947 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4948 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4949 * callint.c (Fcall_interactively): Check arg count for overflow,
4950 to avoid potential buffer overrun. Use signed char, not 'int',
4951 for 'varies' array, so that we needn't bother to check its size
4952 calculation for overflow.
4953 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4954 * eval.c (apply_lambda):
4955 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4956 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4957 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4959 * callint.c (Fcall_interactively): Don't use index var as event count.
4961 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4962 * mem-limits.h (SIZE): Remove; no longer used.
4964 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4966 Remove unnecessary casts.
4967 * xterm.c (x_term_init):
4968 * xfns.c (x_set_border_pixel):
4969 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4970 These aren't needed now that we assume ANSI C.
4972 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4973 It's more likely to cause problems (due to unsigned overflow)
4976 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4978 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4980 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4982 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4984 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4986 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4988 GLYPH_CODE_FACE returns EMACS_INT, not int.
4989 * dispextern.h (merge_faces):
4990 * xfaces.c (merge_faces):
4991 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4992 Don't assume EMACS_INT fits in int.
4994 * character.h (CHAR_VALID_P): Remove unused parameter.
4995 * fontset.c, lisp.h, xdisp.c: All uses changed.
4997 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4999 * fns.c (concat): Minor tuning based on overflow analysis.
5000 This doesn't fix any bugs. Use int to hold character, instead
5001 of constantly refetching from Emacs object. Use XFASTINT, not
5002 XINT, for value known to be a character. Don't bother comparing
5003 a single byte to 0400, as it's always less.
5005 * floatfns.c (Fexpt):
5006 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5008 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5011 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5013 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5014 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5015 incorrectly succeed when S was a string, because 4294967386 was
5016 truncated before it was used.
5018 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5019 Otherwise, an out-of-range integer could cause undefined behavior
5022 * composite.c: Use int, not EMACS_INT, for characters.
5023 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5024 EMACS_INT, for values that are known to be in character range.
5025 This doesn't fix any bugs but is the usual style inside Emacs and
5026 may generate better code on 32-bit machines.
5028 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5029 This is for reasons similar to the recent CHAR_STRING fix.
5030 * charset.c (Fencode_char): Check that character arg is actually
5031 a character. Pass an int to ENCODE_CHAR.
5032 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5033 wider than 'int', as a compile-time check to prevent future regressions
5036 * character.c (char_string): Remove unnecessary casts.
5038 Make sure a 64-bit char is never passed to CHAR_STRING.
5039 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5040 by silently ignoring the top 32 bits, allowing some values
5041 that were far too large to be valid characters.
5042 * character.h: Include <verify.h>.
5043 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5044 arguments are no wider than unsigned, as a compile-time check
5045 to prevent future regressions in this area.
5047 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5048 (Fsubst_char_in_region):
5050 * xdisp.c (decode_mode_spec_coding):
5051 Adjust to CHAR_STRING's new requirement.
5052 * editfns.c (Finsert_char, Fsubst_char_in_region):
5053 * fns.c (concat): Check that character args are actually
5054 characters. Without this test, these functions did the wrong
5055 thing with wildly out-of-range values on 64-bit hosts.
5057 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5058 These casts should not be needed on 32-bit hosts, either.
5059 * keyboard.c (read_char):
5060 * lread.c (Fload): Remove casts to unsigned.
5062 * lisp.h (UNSIGNED_CMP): New macro.
5063 This fixes comparison bugs on 64-bit hosts.
5064 (ASCII_CHAR_P): Use it.
5065 * casefiddle.c (casify_object):
5066 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5067 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5068 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5069 * dispextern.h (FACE_FROM_ID):
5070 * keyboard.c (read_char): Use UNSIGNED_CMP.
5072 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5073 not to EMACS_INT, to avoid GCC warning.
5075 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5077 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5078 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5079 isn't needed on 32-bit machines.
5081 * buffer.c (Fgenerate_new_buffer_name):
5082 Use EMACS_INT for count, not int.
5083 (advance_to_char_boundary): Return EMACS_INT, not int.
5085 * data.c (Qcompiled_function): Now static.
5087 * window.c (window_body_lines): Now static.
5089 * image.c (gif_load): Rename local to avoid shadowing.
5091 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5092 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5093 * alloc.c (make_save_value): Integer argument is now of type
5095 (mark_object): Use ptrdiff_t, not int.
5096 * lisp.h (pD): New macro.
5097 * print.c (print_object): Use it.
5099 * alloc.c: Use EMACS_INT, not int, to count objects.
5100 (total_conses, total_markers, total_symbols, total_vector_size)
5101 (total_free_conses, total_free_markers, total_free_symbols)
5102 (total_free_floats, total_floats, total_free_intervals)
5103 (total_intervals, total_strings, total_free_strings):
5104 Now EMACS_INT, not int. All uses changed.
5105 (Fgarbage_collect): Compute overall total using a double, so that
5106 integer overflow is less likely to be a problem. Check for overflow
5107 when converting back to an integer.
5108 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5109 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5110 These were 'int' variables that could overflow on 64-bit hosts;
5111 they were never used, so remove them instead of repairing them.
5112 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5113 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5114 Previously, this ceilinged at INT_MAX, but that doesn't work on
5116 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5118 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5119 (allocate_vectorlike): Check for ptrdiff_t overflow.
5120 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5121 when a (possibly-narrower) signed value would do just as well.
5122 We prefer using signed arithmetic, to avoid comparison confusion.
5124 * alloc.c: Catch some string size overflows that we were missing.
5125 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5126 for convenience in STRING_BYTES_MAX.
5127 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5128 The definition here is exact; the one in lisp.h was approximate.
5129 (allocate_string_data): Check for string overflow. This catches
5130 some instances we weren't catching before. Also, it catches
5131 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5132 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5133 and ptrdiff_t and EMACS_INT are both 64 bits.
5135 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5136 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5137 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5139 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5141 * alloc.c (Fmake_string): Check for out-of-range init.
5143 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5145 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5147 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5149 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5150 xg_get_default_scrollbar_width.
5152 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5153 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5154 (style_changed_cb): Call update_theme_scrollbar_width and call
5155 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5156 all frames (Bug#8505).
5157 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5158 Call gtk_window_set_resizable if HAVE_GTK3.
5159 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5160 and height if HAVE_GTK3 (Bug#8505).
5161 (scroll_bar_width_for_theme): New variable.
5162 (update_theme_scrollbar_width): New function.
5163 (xg_get_default_scrollbar_width): Move code to
5164 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5165 (xg_initialize): Call update_theme_scrollbar_width.
5167 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5169 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5171 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5173 * frame.c (make_frame): Call other_buffer_safely instead of
5176 * window.c (temp_output_buffer_show): Call display_buffer with
5177 second argument Vtemp_buffer_show_specifiers and reset latter
5178 immediately after the call.
5179 (Vtemp_buffer_show_specifiers): New variable.
5180 (auto_window_vscroll_p, next_screen_context_lines)
5181 (Vscroll_preserve_screen_position): Remove leading asterisks from
5184 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5186 Fix minor problems found by GCC 4.6.0 static checking.
5187 * buffer.c (Qclone_number): Remove for now, as it's unused.
5188 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5189 (record_buffer): Remove unused local.
5190 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5191 (set_frame_buffer_list): Remove; unused.
5192 * frame.h (other_visible_frames): Remove decl.
5193 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5194 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5195 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5197 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5198 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5199 Define only if HAVE_GPM.
5200 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5201 (update_hints_inhibit): Remove; never set. All uses removed.
5202 * widgetprv.h (emacsFrameClassRec): Remove decl.
5203 * window.c (delete_deletable_window): Now returns void, since it
5204 wasn't returning anything.
5205 (compare_window_configurations): Remove unused locals.
5206 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5207 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5208 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5209 the same widths as pointers. This follows up on the 2011-05-06 patch.
5210 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5211 * xterm.h: Likewise.
5212 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5214 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5216 * makefile.w32-in: Update dependencies.
5217 (LISP_H): Add lib/intprops.h.
5219 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5221 * image.c (gif_load): Add animation frame delay to the metadata.
5222 (syms_of_image): Use DEFSYM. New symbol `delay'.
5224 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5226 * window.c (delete_deletable_window): Re-add.
5227 (Fset_window_configuration): Rewrite to handle dead buffers and
5228 consequently deletable windows.
5229 (window_tree, Fwindow_tree): Remove. Supply functionality in
5231 (compare_window_configurations): Simplify code.
5233 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5235 * image.c (imagemagick_load_image): Fix type mismatch.
5236 (Fimagemagick_types): Likewise.
5238 * window.h (replace_buffer_in_windows): Declare.
5240 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5242 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5243 Qclone_number. Remove external declaration of Qdelete_window.
5244 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5246 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5247 Run Qbuffer_list_update_hook if allowed.
5248 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5249 buffer list implementation.
5250 (other_buffer_safely): New function.
5251 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5252 calls to replace_buffer_in_windows and
5253 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5255 (record_buffer): Inhibit quitting and rewrite using quittable
5256 functions. Run Qbuffer_list_update_hook if allowed.
5257 (Frecord_buffer, Funrecord_buffer): New functions.
5258 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5259 Move switch-to-buffer to window.el.
5260 (bury-buffer): Move to window.el.
5261 (Vbuffer_list_update_hook): New variable.
5263 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5266 * window.h (resize_frame_windows): Move up in code.
5267 (Fwindow_frame): Remove EXFUN.
5268 (replace_buffer_in_all_windows): Remove prototype.
5269 (replace_buffer_in_windows_safely): Add prototype.
5271 * window.c: Declare Qdelete_window static again. Move down
5272 declaration of select_count.
5273 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5274 (Fother_window): Move to window.el.
5275 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5276 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5277 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5279 (replace_buffer_in_windows): Implement by calling
5280 Qreplace_buffer_in_windows.
5281 (replace_buffer_in_all_windows): Remove with some functionality
5282 moved into replace_buffer_in_windows_safely.
5283 (replace_buffer_in_windows_safely): New function.
5284 (select_window_norecord, select_frame_norecord): Move in front
5285 of run_window_configuration_change_hook. Remove now obsolete
5287 (Fset_window_buffer): Rewrite doc-string.
5288 Call Qrecord_window_buffer.
5289 (keys_of_window): Move binding for other-window to window.el.
5291 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5293 * dispextern.h (struct image): Replace data member, whose int_val
5294 and ptr_val fields were not used by anything, with a single
5297 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5298 (gif_clear_image, gif_load, imagemagick_load_image)
5299 (gs_clear_image, gs_load): Callers changed.
5301 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5303 * buffer.h: Include <time.h>, for time_t.
5304 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5306 Fix minor problems found by static checking.
5308 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5310 Make identifiers static if they are not used in other modules.
5311 * data.c (Qcompiled_function, Qframe, Qvector):
5312 * image.c (QimageMagick, Qsvg):
5313 * minibuf.c (Qmetadata):
5314 * window.c (resize_window_check, resize_root_window): Now static.
5315 * window.h (resize_window_check, resize_root_window): Remove decls.
5317 * window.c (window_deletion_count, delete_deletable_window):
5319 (window_body_lines): Now static.
5320 (Fdelete_other_windows_internal): Mark vars as initialized.
5321 Make sure 'resize_failed' is initialized.
5322 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5323 (resize_window_apply): Remove unused local.
5324 * window.h (delete_deletable_window): Remove decl.
5326 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5327 (imagemagick_load_image): Fix pointer signedness problem by changing
5328 last arg from unsigned char * to char *. All uses changed.
5329 Also, fix a local for similar reasons.
5330 Remove unused locals. Remove locals to avoid shadowing.
5331 (fn_rsvg_handle_free): Remove; unused.
5332 (svg_load, svg_load_image): Fix pointer signedness problem.
5333 (imagemagick_load_image): Don't use garbage pointer image_wand.
5335 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5337 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5339 * image.c (gif_load): Fix omitted cast error introduced by
5342 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5344 * window.h (resize_proportionally, orig_total_lines)
5345 (orig_top_line): Remove from window structure.
5346 (set_window_height, set_window_width, change_window_heights)
5347 (Fdelete_window): Remove prototypes.
5348 (resize_frame_windows): Remove duplicate declaration.
5350 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5352 * window.h (resize_frame_windows, resize_window_check)
5353 (delete_deletable_window, resize_root_window)
5354 (resize_frame_windows): Declare prototypes.
5356 * window.c (resize_window_apply): Make definition be "static" to
5357 match the prototype.
5359 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5361 * window.c: Remove declarations of Qwindow_size_fixed,
5362 window_min_size_1, window_min_size_2, window_min_size,
5363 size_window, window_fixed_size_p, enlarge_window, delete_window.
5364 Remove static from declaration of Qdelete_window, it's
5365 temporarily needed by Fbury_buffer.
5366 (replace_window): Don't assign orig_top_line and
5368 (Fdelete_window, delete_window): Remove. Window deletion is
5369 handled by window.el.
5370 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5371 Replace Fdelete_window calls with calls to Qdelete_window.
5372 (Fdelete_other_windows): Remove. Deleting other windows is
5373 handled by window.el.
5374 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5375 handled in window.el.
5376 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5377 Window minimum sizes are handled in window.el.
5378 (shrink_windows, size_window, set_window_height)
5379 (set_window_width, change_window_heights, window_height)
5380 (window_width, CURBEG, CURSIZE, enlarge_window)
5381 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5382 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5383 handled in window.el.
5384 (make_dummy_parent): Rename to make_parent_window and give it a
5385 second argument horflag.
5386 (make_window): Don't set resize_proportionally any more.
5387 (Fsplit_window): Remove. Windows are split in window.el.
5388 (save_restore_action, save_restore_orig_size)
5389 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5390 Resize mini windows in window.el.
5391 (grow_mini_window, shrink_mini_window): Implement by calling
5392 Qresize_root_window_vertically, resize_window_check and
5393 resize_window_apply.
5394 (saved_window, Fset_window_configuration, save_window_save):
5395 Do not handle orig_top_line, orig_total_lines, and
5396 resize_proportionally.
5397 (window_min_height, window_min_width): Move to window.el.
5398 (keys_of_window): Move bindings for delete-other-windows,
5399 split-window, delete-window and enlarge-window to window.el.
5401 * buffer.c: Temporarily extern Qdelete_window.
5402 (Fbury_buffer): Temporarily call Qdelete_window instead of
5403 Fdelete_window (Fbury_buffer will move to window.el soon).
5405 * frame.c (set_menu_bar_lines_1): Remove code handling
5406 orig_top_line and orig_total_lines.
5408 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5409 set_window_height but set heights directly.
5410 (change_frame_size_1): Use resize_frame_windows.
5412 * xdisp.c (init_xdisp): Don't use set_window_height but set
5415 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5416 Use resize_frame_windows instead of change_window_heights and run
5417 run_window_configuration_change_hook.
5419 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5420 instead of change_window_heights and run
5421 run_window_configuration_change_hook.
5423 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5425 * window.c (replace_window): Rename second argument REPLACEMENT to
5426 NEW. New third argument SETFLAG. Rewrite.
5427 (delete_window, make_dummy_parent): Call replace_window with
5429 (window_list_1): Move down in code.
5430 (run_window_configuration_change_hook): Move set_buffer part
5431 before select_frame_norecord part in order to unwind correctly.
5432 Rename count1 to count.
5433 (recombine_windows, delete_deletable_window, resize_root_window)
5434 (Fdelete_other_windows_internal)
5435 (Frun_window_configuration_change_hook, make_parent_window)
5436 (resize_window_check, resize_window_apply, Fresize_window_apply)
5437 (resize_frame_windows, Fsplit_window_internal)
5438 (Fdelete_window_internal, Fresize_mini_window_internal):
5440 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5442 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5444 * window.h (window): Add some new members to window structure -
5445 normal_lines, normal_cols, new_total, new_normal, clone_number,
5446 splits, nest, prev_buffers, next_buffers.
5447 (WINDOW_TOTAL_SIZE): Move here from window.c.
5448 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5450 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5452 (make_dummy_parent): Set new members of windows structure.
5453 (make_window): Move down in code. Handle new members of window
5455 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5456 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5457 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5458 (Fset_window_prev_buffers, Fwindow_next_buffers)
5459 (Fset_window_next_buffers, Fset_window_clone_number):
5461 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5462 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5464 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5465 Argument WINDOW can be now internal window too.
5466 (Fwindow_use_time): Move up in code.
5467 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5469 (Fset_window_configuration, saved_window)
5470 (Fcurrent_window_configuration, save_window_save): Handle new
5471 members of window structure.
5472 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5473 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5474 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5475 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5476 Qget_mru_window, Qresize_root_window,
5477 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5478 Qauto_buffer_name; staticpro them.
5480 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5482 * window.c (Fwindow_total_size, Fwindow_left_column)
5483 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5484 (Fwindow_list_1): New functions.
5485 (window_box_text_cols): Replace with window_body_cols.
5486 (Fwindow_width, Fscroll_left, Fscroll_right):
5487 Use window_body_cols instead of window_box_text_cols.
5488 (delete_window, Fset_window_configuration):
5489 Call delete_all_subwindows with window as argument.
5490 (delete_all_subwindows): Take a window as argument and not a
5492 (window_loop): Remove handling of GET_LRU_WINDOW and
5494 (Fget_lru_window, Fget_largest_window): Move to window.el.
5496 * window.h: Extern window_body_cols instead of
5497 window_box_text_cols. delete_all_subwindows now takes a
5498 Lisp_Object as argument.
5500 * indent.c (compute_motion, Fcompute_motion):
5501 Use window_body_cols instead of window_box_text_cols.
5503 * frame.c (delete_frame): Call delete_all_subwindows with root
5506 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5508 * fns.c (Fputhash): Document return value.
5510 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5512 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5514 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5516 Cons<->int and similar integer overflow fixes (Bug#8794).
5518 Check for overflow when converting integer to cons and back.
5519 * charset.c (Fdefine_charset_internal, Fdecode_char):
5520 Use cons_to_unsigned to catch overflow.
5521 (Fencode_char): Use INTEGER_TO_CONS.
5522 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5523 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5524 * data.c (long_to_cons, cons_to_long): Remove.
5525 (cons_to_unsigned, cons_to_signed): New functions.
5526 These signal an error for invalid or out-of-range values.
5527 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5528 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5529 * font.c (Ffont_variation_glyphs):
5530 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5531 * lisp.h: Include <intprops.h>.
5532 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5533 (cons_to_signed, cons_to_unsigned): New decls.
5534 (long_to_cons, cons_to_long): Remove decls.
5535 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5536 (Fprimitive_undo): Use CONS_TO_INTEGER.
5537 * xfns.c (Fx_window_property): Likewise.
5538 * xselect.c: Include <limits.h>.
5539 (x_own_selection, selection_data_to_lisp_data):
5540 Use INTEGER_TO_CONS.
5541 (x_handle_selection_request, x_handle_selection_clear)
5542 (x_get_foreign_selection, Fx_disown_selection_internal)
5543 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5544 (lisp_data_to_selection_data): Use cons_to_unsigned.
5545 (x_fill_property_data): Use cons_to_signed.
5546 Report values out of range.
5548 Check for buffer and string overflow more precisely.
5549 * buffer.h (BUF_BYTES_MAX): New macro.
5550 * lisp.h (STRING_BYTES_MAX): New macro.
5551 * alloc.c (Fmake_string):
5552 * character.c (string_escape_byte8):
5553 * coding.c (coding_alloc_by_realloc):
5554 * doprnt.c (doprnt):
5555 * editfns.c (Fformat):
5557 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5558 since they may not be the same number.
5559 * editfns.c (Finsert_char):
5560 * fileio.c (Finsert_file_contents):
5561 Likewise for BUF_BYTES_MAX.
5563 * image.c: Use ptrdiff_t, not int, for sizes.
5564 (slurp_file): Switch from int to ptrdiff_t.
5566 (slurp_file): Check that file size fits in both size_t (for
5567 malloc) and ptrdiff_t (for sanity and safety).
5569 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5570 if b->modtime has its maximal value.
5572 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5574 Don't assume time_t can fit into int.
5575 * buffer.h (struct buffer.modtime): Now time_t, not int.
5576 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5577 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5579 Minor fixes for signed vs unsigned integers.
5580 * character.h (MAYBE_UNIFY_CHAR):
5581 * charset.c (maybe_unify_char):
5582 * keyboard.c (read_char, reorder_modifiers):
5583 XINT -> XFASTINT, since the integer must be nonnegative.
5584 * ftfont.c (ftfont_spec_pattern):
5585 * keymap.c (access_keymap, silly_event_symbol_error):
5586 XUINT -> XFASTINT, since the integer must be nonnegative.
5587 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5588 since it makes no difference and we prefer signed.
5589 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5590 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5593 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5595 * window.h (Fwindow_frame): Declare.
5597 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5599 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5600 (SPARE_MEMORY): Always define.
5601 (LARGE_REQUEST): Remove.
5602 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5604 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5606 * lisp.h: Move EXFUNS for Fframe_root_window,
5607 Fframe_first_window and Fset_frame_selected_window to window.h.
5609 * window.h: Move EXFUNS for Fframe_root_window,
5610 Fframe_first_window and Fset_frame_selected_window here from
5613 * frame.c (Fwindow_frame, Fframe_first_window)
5614 (Fframe_root_window, Fframe_selected_window)
5615 (Fset_frame_selected_window): Move to window.c.
5616 (Factive_minibuffer_window): Move to minibuf.c.
5617 (Fother_visible_frames_p): New function.
5619 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5621 * window.c (decode_window, decode_any_window): Move up in code.
5622 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5623 (inhibit_frame_unsplittable): Remove unused variable.
5624 (Fwindow_buffer): Move up and rewrite doc-string.
5625 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5626 (Fwindow_prev): New functions.
5627 (Fwindow_frame): Move here from frame.c. Accept any window as
5629 (Fframe_root_window, Fframe_first_window)
5630 (Fframe_selected_window): Move here from frame.c. Accept frame
5631 or arbitrary window as argument. Update doc-strings.
5632 (Fminibuffer_window): Move up in code.
5633 (Fwindow_minibuffer_p): Move up in code and simplify.
5634 (Fset_frame_selected_window): Move here from frame.c.
5636 (Fselected_window, select_window, Fselect_window): Move up in
5637 code. Minor doc-string fixes.
5639 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5641 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5642 Do not assume that spare memory exists; that assumption is valid
5643 only if SYSTEM_MALLOC.
5644 (LARGE_REQUEST): New macro, so that the issue of large requests
5645 is separated from the issue of spare memory.
5647 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5649 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5652 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5654 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5657 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5659 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5661 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5663 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5664 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5666 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5668 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5670 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5672 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5673 (x_clipboard_manager_save): Add return value.
5674 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5676 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5677 Obey Vx_select_enable_clipboard_manager. Catch errors in
5678 x_clipboard_manager_save (Bug#8779).
5679 (Vx_select_enable_clipboard_manager): New variable.
5680 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5682 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5684 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5686 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5688 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5689 in the current matrix if keep_current_p is non-zero.
5691 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5693 * bidi.c (bidi_level_of_next_char): Fix last change.
5695 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5697 Support bidi reordering of text covered by display properties.
5699 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5700 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5701 (bidi_cache_search, bidi_cache_iterator_state)
5702 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5703 (bidi_level_of_next_char, bidi_move_to_visually_next):
5704 Support character positions inside a run of characters covered by a
5706 (bidi_paragraph_init, bidi_resolve_explicit_1)
5707 (bidi_level_of_next_char): Call bidi_fetch_char and
5708 bidi_fetch_char_advance instead of FETCH_CHAR and
5710 (bidi_init_it): Initialize new members.
5711 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5713 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5714 instead of using explicit *_CHAR codes.
5715 (bidi_resolve_explicit, bidi_resolve_weak):
5716 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5717 bidirectional text is supported only in multibyte buffers.
5718 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5719 it to initialize the frame_window_p member of struct bidi_it.
5720 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5721 (bidi_resolve_explicit, bidi_resolve_weak)
5722 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5723 bidi_it->nchars is non-positive.
5724 (bidi_level_of_next_char): Don't try to lookup the cache for the
5725 next/previous character if nothing is cached there yet, or if we
5726 were just reseat()'ed to a new position.
5728 * xdisp.c (set_cursor_from_row): Set start and stop points
5729 according to the row's direction when priming the loop that looks
5730 for the glyph on which to display cursor.
5731 (single_display_spec_intangible_p): Function deleted.
5732 (display_prop_intangible_p): Reimplement to call
5733 handle_display_spec instead of single_display_spec_intangible_p.
5734 Accept 3 additional arguments needed by handle_display_spec.
5735 This fixes incorrect cursor motion across display property with complex
5736 values: lists, `(when COND...)' forms, etc.
5737 (single_display_spec_string_p): Support property values that are
5738 lists with the argument STRING its top-level element.
5739 (display_prop_string_p): Fix the condition for processing a
5740 property that is a list to be consistent with handle_display_spec.
5741 (handle_display_spec): New function, refactored from the
5742 last portion of handle_display_prop.
5743 (compute_display_string_pos): Accept additional argument
5744 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5745 value of a `display' property is a "replacing spec".
5746 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5747 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5748 the display property, but just return a value indicating whether
5749 the display property will replace the characters it covers.
5750 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5751 frame_window_p members of struct bidi_it.
5752 (compute_display_string_pos, compute_display_string_end):
5754 (push_it): Accept second argument POSITION, where pop_it should
5755 jump to continue iteration.
5756 (reseat_1): Initialize bidi_it.disp_pos.
5758 * keyboard.c (adjust_point_for_property): Adjust the call to
5759 display_prop_intangible_p to its new signature.
5761 * dispextern.h (struct bidi_it): New member frame_window_p.
5762 (bidi_init_it): Update prototypes.
5763 (display_prop_intangible_p): Update prototype.
5764 (compute_display_string_pos, compute_display_string_end):
5766 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5769 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5771 Malloc failure behavior now depends on size of allocation.
5772 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5773 * lisp.h: Change signatures accordingly.
5774 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5775 All callers changed. (Bug#8762)
5777 * gnutls.c: Use Emacs's memory allocators.
5778 Without this change, the gnutls library would invoke malloc etc.
5779 directly, which causes problems on non-SYNC_INPUT hosts, and which
5780 runs afoul of improving memory_full behavior. (Bug#8761)
5781 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5782 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5783 xfree instead of the default malloc, realloc, free.
5784 (Fgnutls_boot): No need to check for memory allocation failure,
5785 since xmalloc does that for us.
5787 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5788 * category.c (hash_get_category_set):
5789 * ccl.c (ccl_driver):
5790 * charset.c (Fdefine_charset_internal):
5791 * charset.h (struct charset.hash_index):
5792 * composite.c (get_composition_id, gstring_lookup_cache)
5793 (composition_gstring_put_cache):
5794 * composite.h (struct composition.hash_index):
5795 * dispextern.h (struct image.hash):
5796 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5797 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5798 (hashfn_equal, hashfn_user_defined, make_hash_table)
5799 (maybe_resize_hash_table, hash_lookup, hash_put)
5800 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5801 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5802 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5803 * image.c (make_image, search_image_cache, lookup_image)
5804 (xpm_put_color_table_h):
5805 * lisp.h (struct Lisp_Hash_Table):
5806 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5807 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5808 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5809 * alloc.c (allocate_vectorlike):
5810 Check for overflow in vector size calculations.
5811 * ccl.c (ccl_driver):
5812 Check for overflow when converting EMACS_INT to int.
5813 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5814 need to be updated by these changes.
5815 * fns.c (make_hash_table, maybe_resize_hash_table):
5816 Check for integer overflow with large hash tables.
5817 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5818 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5819 (SXHASH_REDUCE): New macro.
5820 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5821 Use it instead of discarding useful hash info with large hash values.
5822 (sxhash_float): New function.
5823 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5824 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5825 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5826 Rewrite to use FIXNUM_BITS, as this simplifies things.
5827 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5828 Adjust signatures to match updated version of code.
5829 (consing_since_gc): Now EMACS_INT, since a single hash table can
5830 use more than INT_MAX bytes.
5832 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5834 Make it possible to build with GCC-4.6+ -O2 -flto.
5836 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5838 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5840 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5841 Call minibuffer-inactive-mode.
5843 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5845 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5846 Update dependencies.
5848 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5850 * data.c (init_data): Remove code for UTS, this system is not
5853 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5855 Don't force ./temacs to start in terminal mode.
5857 * frame.c (make_initial_frame): Initialize faces in all cases, not
5858 only when CANNOT_DUMP is defined.
5859 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5861 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5863 * dispnew.c (add_window_display_history): Use const for the string
5864 pointer. Remove declaration, not needed.
5866 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5868 Use 'inline', not 'INLINE'.
5869 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5870 * alloc.c, fontset.c (INLINE): Remove.
5871 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5872 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5873 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5874 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5875 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5877 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5879 Make it possible to run ./temacs.
5881 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5882 syms_of_callproc does the same thing. Remove test for
5883 "initialized", do it in the caller.
5884 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5886 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5888 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5889 (read_minibuf): Use get_minibuffer.
5890 (syms_of_minibuf): Use DEFSYM.
5891 (Qmetadata): New var.
5892 * data.c (Qbuffer): Don't make it static.
5893 (syms_of_data): Use DEFSYM.
5895 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5897 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5898 (CCL_CODE_MIN): New macro.
5900 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5902 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5904 * eval.c (Qdebug): Now static.
5905 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5906 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5907 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5909 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5911 * image.c: Various fixes to ImageMagick code comments.
5912 (Fimagemagick_types): Doc fix.
5914 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5916 Minor fixes prompted by GCC 4.6.0 warnings.
5918 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5920 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5921 (x_clipboard_manager_save_all): Move extern decl to ...
5922 * xterm.h: ... here, so that it can be checked for consistency.
5924 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5926 * xselect.c (x_clipboard_manager_save_frame)
5927 (x_clipboard_manager_save_all): New functions.
5928 (Fx_clipboard_manager_save): Lisp function deleted.
5930 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5931 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5933 * xterm.h: Update prototype.
5935 2011-05-28 William Xu <william.xwl@gmail.com>
5937 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5940 2011-05-28 Jim Meyering <meyering@redhat.com>
5942 Avoid a sign-extension bug in crypto_hash_function.
5943 * fns.c (to_uchar): Define.
5944 (crypto_hash_function): Use it to convert some newly-signed
5945 variables to unsigned, to avoid sign-extension bugs. For example,
5946 without this change, (md5 "truc") would evaluate to
5947 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5948 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5949 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5951 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5953 Integer overflow fixes.
5955 * dbusbind.c: Serial number integer overflow fixes.
5956 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5957 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5958 to hold a serial number that is too large for a fixnum.
5959 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5960 Check for serial numbers out of range. Decode any serial number
5961 that was so large that it became a float. (Bug#8722)
5963 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5964 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5965 Use XFASTINT rather than XUINT when numbers are nonnegative.
5966 (xd_append_arg, Fdbus_method_return_internal):
5967 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5968 arguments, check that Lisp number is nonnegative, rather than
5969 silently wrapping negative numbers around. (Bug#8722)
5970 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5973 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5975 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5977 ccl: Add integer overflow checks.
5978 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5979 (IN_INT_RANGE): New macros.
5980 (ccl_driver): Use them to check for integer overflow when
5981 decoding a CCL program. Many of the new checks are whether XINT (x)
5982 fits in int; it doesn't always, on 64-bit hosts. The new version
5983 doesn't catch all possible integer overflows, but it's an
5984 improvement. (Bug#8719)
5986 * alloc.c (make_event_array): Use XINT, not XUINT.
5987 There's no need for unsigned here.
5989 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5990 This follows up to the 2011-05-06 change that substituted uintptr_t
5991 for EMACS_INT. This case wasn't caught back then.
5993 Rework Fformat to avoid integer overflow issues.
5994 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5995 now (part of C89). Include <verify.h>.
5996 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5997 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5998 (Fformat): Avoid the prepass trying to compute sizes; it was only
5999 approximate and thus did not catch overflow reliably. Instead, walk
6000 through the format just once, formatting and computing sizes as we go,
6001 checking for integer overflow at every step, and allocating a larger
6002 buffer as needed. Keep track separately whether the format is
6003 multibyte. Keep only the most-recently calculated precision, rather
6004 than them all. Record whether each argument has been converted to
6005 string. Use EMACS_INT, not int, for byte and char and arg counts.
6006 Support field widths and precisions larger than INT_MAX. Avoid
6007 sprintf's undefined behavior with conversion specifications such as %#d
6008 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6009 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6010 formatting out-of-range floating point numbers with int
6013 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6015 * data.c: Avoid integer truncation in expressions involving floats.
6016 * data.c: Include <intprops.h>.
6017 (arith_driver): When there's an integer overflow in an expression
6018 involving floating point, convert the integers to floating point
6019 so that the resulting value does not suffer from catastrophic
6020 integer truncation. For example, on a 64-bit host (* 4
6021 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6022 Do not rely on undefined behavior after integer overflow.
6024 merge count_size_as_multibyte, parse_str_to_multibyte
6025 * character.c, character.h (count_size_as_multibyte):
6026 Rename from parse_str_to_multibyte; all uses changed.
6027 Check for integer overflow.
6028 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6029 since it's now a duplicate of the other. This is more of
6030 a character than a buffer op, so better that it's in character.c.
6031 * fns.c, print.c: Adjust to above changes.
6033 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6035 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6037 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6039 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6040 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6041 (x_clipboard_manager_save): Now static.
6042 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6044 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6045 (crypto_hash_function): Now static.
6046 Fix pointer signedness problems. Avoid unnecessary initializations.
6048 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6050 * termhooks.h (Vselection_alist): Make it terminal-local.
6052 * terminal.c (create_terminal): Initialize it.
6054 * xselect.c: Support for clipboard managers.
6055 (Vselection_alist): Move to termhooks.h as terminal-local var.
6056 (LOCAL_SELECTION): New macro.
6057 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6058 (symbol_to_x_atom): Remove gratuitous arg.
6059 (x_handle_selection_request, lisp_data_to_selection_data)
6060 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6061 (x_own_selection, x_get_local_selection, x_convert_selection):
6062 New arg, specifying work frame. Use terminal-local Vselection_alist.
6063 (some_frame_on_display): Delete unused function.
6064 (Fx_own_selection_internal, Fx_get_selection_internal)
6065 (Fx_disown_selection_internal, Fx_selection_owner_p)
6066 (Fx_selection_exists_p): New optional frame arg.
6067 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6068 (x_handle_selection_clear): Don't treat other terminals with the
6069 same keyboard specially. Use the terminal-local Vselection_alist.
6070 (x_clear_frame_selections): Use Frun_hook_with_args.
6072 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6074 * xterm.h: Add support for those atoms.
6076 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6078 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6079 (converted_selections, conversion_fail_tag): New global variables.
6080 (x_selection_request_lisp_error): Free the above.
6081 (x_get_local_selection): Remove unnecessary code.
6082 (x_reply_selection_request): Args changed; handle arbitrary array
6083 of converted selections stored in converted_selections.
6084 Separate the XChangeProperty and SelectionNotify steps.
6085 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6086 (x_convert_selection): New function.
6087 (x_handle_selection_event): Simplify.
6088 (x_get_foreign_selection): Don't ignore incoming requests while
6089 waiting for an answer; this will fail when we implement
6090 SAVE_TARGETS, and seems unnecessary anyway.
6091 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6092 (Vx_sent_selection_functions): Doc fix.
6094 2011-05-26 Leo Liu <sdl.web@gmail.com>
6096 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6098 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6100 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6102 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6103 for fringe update if it has periodic bitmap.
6104 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6105 and fringe_bitmap_periodic_p.
6107 * fringe.c (get_fringe_bitmap_data): New function.
6108 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6109 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6110 row. Mark glyph row for fringe update if periodicity changed.
6112 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6113 for fringe update unless it has periodic bitmap.
6115 2011-05-25 Kenichi Handa <handa@m17n.org>
6117 * xdisp.c (get_next_display_element): Set correct it->face_id for
6118 a static composition.
6120 2011-05-24 Leo Liu <sdl.web@gmail.com>
6123 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6125 * fns.c (crypto_hash_function, Fsha1): New function.
6126 (Fmd5): Use crypto_hash_function.
6127 (syms_of_fns): Add Ssha1.
6129 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6131 * gnutls.c: Remove unused macros.
6132 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6133 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6134 Remove macros that are defined and never used.
6135 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6137 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6139 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6140 (Fx_get_selection_internal): Minor cleanup.
6141 (Fx_own_selection_internal): Rename arguments for consistency with
6144 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6146 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6148 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6150 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6152 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6154 * dispnew.c (scrolling_window): Don't exclude the case that the
6155 last enabled row in the desired matrix touches the bottom boundary.
6157 2011-05-21 Glenn Morris <rgm@gnu.org>
6159 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6160 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6161 and add some more files.
6163 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6165 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6166 report_file_error introduced by the change from 2011-05-07.
6168 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6170 * systime.h (Time): Define only if emacs is defined.
6171 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6172 where the include path doesn't have X11/X.h by default. See
6173 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6175 2011-05-20 Kenichi Handa <handa@m17n.org>
6177 * composite.c (find_automatic_composition): Fix previous change.
6179 2011-05-20 Glenn Morris <rgm@gnu.org>
6181 * lisp.mk: New file, split from Makefile.in.
6182 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6183 (shortlisp): Remove.
6184 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6186 2011-05-19 Glenn Morris <rgm@gnu.org>
6188 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6189 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6190 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6191 (lisp): Set the order to that of loadup.el.
6192 (shortlisp): Make it a copy of $lisp.
6193 (SOME_MACHINE_LISP): Remove.
6194 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6195 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6197 2011-05-18 Kenichi Handa <handa@m17n.org>
6199 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6200 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6201 (find_automatic_composition): Mostly rewrite for efficiency.
6203 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6205 * makefile.w32-in: Update dependencies.
6207 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6209 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6210 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6212 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6214 Fix some integer overflow issues, such as string length overflow.
6216 * insdel.c (count_size_as_multibyte): Check for string overflow.
6218 * character.c (lisp_string_width): Check for string overflow.
6219 Use EMACS_INT, not int, for string indexes and lengths; in
6220 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6221 the resulting string length overflows an EMACS_INT; instead,
6222 report a string overflow if no precision given. When checking for
6223 precision exhaustion, use a check that cannot possibly have
6224 integer overflow. (Bug#8675)
6225 * character.h (lisp_string_width): Adjust to new signature.
6227 * alloc.c (string_overflow): New function.
6228 (Fmake_string): Use it. This doesn't change behavior, but saves
6229 a few bytes and will simplify future changes.
6230 * character.c (string_escape_byte8): Likewise.
6231 * lisp.h (string_overflow): New decl.
6233 Fixups, following up to the user-interface timestamp change.
6234 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6235 for UI timestamps, instead of unsigned long.
6236 * msdos.c (mouse_get_pos): Likewise.
6237 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6238 * w32gui.h (Time): Define by including "systime.h" rather than by
6239 declaring it ourselves. (Bug#8664)
6241 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6242 * image.c (clear_image_cache): Likewise.
6244 * term.c (term_mouse_position): Don't assume time_t wraparound.
6246 Be more systematic about user-interface timestamps.
6247 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6248 and sometimes 'EMACS_UINT', to represent these timestamps.
6249 This change causes it to use 'Time' uniformly, as that's what X uses.
6250 This makes the code easier to follow, and makes it easier to catch
6251 integer overflow bugs such as Bug#8664.
6252 * frame.c (Fmouse_position, Fmouse_pixel_position):
6253 Use Time, not unsigned long, for user-interface timestamps.
6254 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6255 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6256 * keyboard.h (last_event_timestamp): Likewise.
6257 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6258 * menu.h (xmenu_show): Likewise.
6259 * term.c (term_mouse_position): Likewise.
6260 * termhooks.h (struct input_event.timestamp): Likewise.
6261 (struct terminal.mouse_position_hook): Likewise.
6262 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6263 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6264 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6265 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6267 * menu.h, termhooks.h: Include "systime.h", for Time.
6269 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6270 Don't assume that the difference between two unsigned long values
6271 can fit into an integer. At this point, we know button_down_time
6272 <= event->timestamp, so the difference must be nonnegative, so
6273 there's no need to cast the result if double-click-time is
6274 nonnegative, as it should be; check that it's nonnegative, just in
6275 case. This bug is triggered when events are more than 2**31 ms
6276 apart (about 25 days). (Bug#8664)
6278 * xselect.c (last_event_timestamp): Remove duplicate decl.
6279 (x_own_selection): Remove needless cast to unsigned long.
6281 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6282 that always fit in int. Use a sentinel instead of a counter, to
6283 avoid a temp and to allay GCC's concerns about possible int overflow.
6284 * frame.h (struct frame): Use int for menu_bar_items_used
6285 instead of EMACS_INT, since it always fits in int.
6287 * menu.c (grow_menu_items): Check for int overflow.
6289 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6291 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6292 Before, the code was not consistent. These values cannot exceed
6293 2**31 - 1 so there's no need to make them unsigned.
6294 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6295 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6296 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6298 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6300 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6301 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6302 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6303 presumably because the widths might not match.
6305 * window.c (size_window): Avoid needless test at loop start.
6307 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6309 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6311 2011-05-12 Drew Adams <drew.adams@oracle.com>
6313 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6315 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6317 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6318 `width' to `bar_area_x' and `bar_area_width', respectively.
6319 (x_scroll_run): Take account of fringe background extension.
6321 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6322 Rename local vars `left' and `width' to `bar_area_x' and
6323 `bar_area_width', respectively.
6324 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6325 background extension.
6327 2011-05-10 Jim Meyering <meyering@redhat.com>
6329 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6331 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6333 * image.c (Finit_image_library): Return t for built-in image types,
6334 like pbm and xbm. (Bug#8640)
6336 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6338 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6340 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6342 * w32console.c (Fset_screen_color): Doc fix.
6343 (Fget_screen_color): New function.
6344 (syms_of_ntterm): Defsubr it.
6346 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6347 unlink the temporary file if Fcall_process didn't create it in the
6349 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6350 child process will be redirected to a file specified with `:file'.
6351 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6352 cue to call_process_cleanup not to close that handle.
6354 2011-05-07 Ben Key <bkey76@gmail.com>
6356 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6357 one of two shell specific rules, either bootstrap-temacs-CMD or
6358 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6359 to the previous implementation of the bootstrap-temacs rule.
6360 The bootstrap-temacs-CMD rule is similar to the previous
6361 implementation of the bootstrap-temacs rule except that it
6362 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6365 These changes, along with some changes to nt/configure.bat,
6366 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6367 earlier fix to add support for --cflags and --ldflags options
6368 that include quotes so that it works whether make uses cmd or
6371 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6373 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6374 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6376 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6377 a string. Handle both cases.
6378 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6379 (Fdbus_register_method): Use Qinvalid_function.
6381 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6383 * makefile.w32-in: Update dependencies.
6384 (LISP_H): Add inttypes.h and stdin.h.
6385 (PROCESS_H): Add unistd.h.
6387 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6389 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6390 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6392 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6394 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6396 * term.c (vfatal): Remove stray call to va_end.
6397 It's not needed and the C Standard doesn't allow it here anyway.
6399 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6400 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6402 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6405 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6407 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6409 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6411 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6413 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6415 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6416 * charset.c (Fdefine_charset_internal): Don't initialize
6417 charset.code_space[15]. The value was garbage, on hosts with
6418 32-bit int (Bug#8600).
6420 * lread.c (read_integer): Be more consistent with string-to-number.
6421 Use string_to_number to do the actual conversion; this avoids
6422 rounding errors and fixes some other screwups. Without this fix,
6423 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6424 (digit_to_number): Move earlier, for benefit of read_integer.
6425 Return -1 if the digit is out of range for the base, -2 if it is
6426 not a digit in any supported base. (Bug#8602)
6428 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6430 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6431 to match comment at start of function. This also removes a
6432 GCC warning about overflow in a 32+64-bit port.
6434 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6436 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6437 Reported by Stefan Monnier in
6438 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6439 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6440 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6442 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6443 (EMACS_UINTPTR): Likewise, with uintptr_t.
6445 * lisp.h: Prefer 64-bit EMACS_INT if available.
6446 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6447 on 32-bit hosts that have 64-bit int, so that they can access
6449 However, temporarily disable this change unless the temporary
6450 symbol WIDE_EMACS_INT is defined.
6452 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6454 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6455 This removes an assumption that EMACS_INT and long are the same
6456 width as pointers. The assumption is true for Emacs porting targets
6457 now, but we want to make other targets possible.
6458 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6459 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6460 In the rest of the code, change types of integers that hold casted
6461 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6462 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6463 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6464 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6465 No need to cast type when ORing.
6466 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6467 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6468 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6469 assume EMACS_INT is the same width as char *.
6470 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6471 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6472 Remove no-longer-needed casts.
6473 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6474 (xg_tool_bar_help_callback, xg_make_tool_item):
6475 Use EMACS_INTPTR to hold an integer
6476 that will be cast to void *; this can avoid a GCC warning
6477 if EMACS_INT is not the same width as void *.
6478 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6479 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6480 (current_message_1, set_message_1):
6481 Use a local to convert to proper width without a cast.
6482 * xmenu.c (dialog_selection_callback): Likewise.
6484 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6485 Also, don't assume VALBITS / RAND_BITS is less than 5,
6486 and don't rely on undefined behavior when shifting a 1 left into
6488 * lisp.h (get_random): Change signature to match.
6490 * lread.c (hash_string): Use size_t, not int, for hash computation.
6491 Normally we prefer signed values; but hashing is special, because
6492 it's better to use unsigned division on hash table sizes so that
6493 the remainder is nonnegative. Also, size_t is the natural width
6494 for hashing into memory. The previous code used 'int', which doesn't
6495 retain enough info to hash well into very large tables.
6496 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6498 * dbusbind.c: Don't possibly lose pointer info when converting.
6499 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6500 Use XPNTR rather than XHASH, so that the high-order bits of
6501 the pointer aren't lost when converting through void *.
6503 * eval.c (Fautoload): Don't double-shift a pointer.
6505 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6507 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6509 * gnutls.c (DEF_GNUTLS_FN):
6510 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6512 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6514 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6517 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6519 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6520 New version that can reserve upto 2GB of heap space.
6522 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6524 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6526 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6528 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6529 `gnutls_certificate_set_x509_key_file'.
6531 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6533 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6534 Update dependencies.
6536 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6538 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6539 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6540 Remove unused parameter `fildes'.
6541 * process.c (read_process_output, send_process): Don't pass it.
6543 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6545 Fix previous change: the library cache is defined in w32.c.
6546 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6547 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6549 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6551 Implement dynamic loading of GnuTLS on Windows.
6553 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6554 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6555 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6558 * gnutls.c (Qgnutls_dll): Define.
6559 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6560 (gnutls_*): Declare function pointers.
6561 (init_gnutls_functions): New function to initialize function pointers.
6562 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6563 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6564 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6565 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6566 (emacs_gnutls_write, emacs_gnutls_read)
6567 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6568 (Fgnutls_available_p): New function.
6569 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6570 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6571 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6573 * image.c: Include w32.h.
6574 (Vimage_type_cache): Delete.
6575 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6576 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6577 (w32_delayed_load): Move to w32.c.
6579 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6581 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6582 (w32_delayed_load): Move from image.c. When loading a library, record
6583 its filename in the :loaded-from property of the library id.
6584 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6585 Initialize and staticpro them.
6586 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6588 * process.c: Include lisp.h before w32.h, not after.
6589 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6590 instead of gnutls_record_check_pending.
6592 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6594 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6596 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6597 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6600 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6602 * xterm.c (x_set_frame_alpha): Do not set property on anything
6603 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6605 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6607 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6609 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6611 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6612 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6613 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6614 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6615 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6616 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6617 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6618 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6619 (Qgnutls_bootprop_callbacks_verify): Make static.
6621 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6623 * callproc.c: Indentation fixup.
6625 * sysdep.c (wait_for_termination_1): Make static.
6626 (wait_for_termination, interruptible_wait_for_termination):
6627 Move after wait_for_termination_1.
6629 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6631 * sysdep.c (interruptible_wait_for_termination): New function
6632 which is like wait_for_termination, but allows keyboard
6635 * callproc.c (Fcall_process): Add (:file "file") as an option for
6637 (Fcall_process_region): Ditto.
6639 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6641 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6642 rather than `XVECTOR (FOO)->size'.
6644 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6645 inttypes.h, as a gnulib replacement is used if it not available in
6648 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6650 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6651 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6652 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6654 * coding.c (coding_alloc_by_realloc): Error out if destination
6655 will grow beyond MOST_POSITIVE_FIXNUM.
6656 (decode_coding_emacs_mule): Abort if there isn't enough place in
6657 charbuf for the composition carryover bytes. Reserve an extra
6658 space for up to 2 characters produced in a loop.
6659 (decode_coding_iso_2022): Abort if there isn't enough place in
6660 charbuf for the composition carryover bytes.
6662 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6664 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6665 aborting when %lld or %lll format is passed.
6666 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6667 %llo or %llx format is passed. (Bug#8545)
6669 * window.c (window_scroll_line_based): Use a marker instead of
6670 simple variables to record original value of point. (Bug#7952)
6672 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6673 produced by %s or %c overflows available buffer space. (Bug#8545)
6675 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6677 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6678 (SIZE_MAX): Move defn after all includes, as they might #define it.
6680 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6682 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6684 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6686 * keyboard.c (Qdelayed_warnings_hook): Define.
6687 (command_loop_1): Run `delayed-warnings-hook'
6688 if Vdelayed_warnings_list is non-nil.
6689 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6690 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6692 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6694 * doprnt.c (doprnt): Don't return value smaller than the buffer
6695 size if the message was truncated. (Bug#8545).
6697 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6699 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6700 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6702 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6704 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6706 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6708 * makefile.w32-in: Update dependencies.
6710 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6712 Improve `doprnt' and its usage. (Bug#8545)
6713 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6714 `format_end'. Remove support for %l as a conversion specifier.
6715 Don't use xrealloc. Improve diagnostics when the %l size modifier
6716 is used. Update the commentary.
6718 * eval.c (verror): Simplify calculation of size_t.
6720 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6723 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6725 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6728 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6730 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6731 This makes this file independent of the recent pseudovector change.
6733 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6735 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6737 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6738 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6739 Remove unused local.
6740 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6742 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6743 GCC 4.6.0 optimizes based on type-based alias analysis.
6744 For example, if b is of type struct buffer * and v of type struct
6745 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6746 != &v->size, and therefore "v->size = 1; b->size = 2; return
6747 v->size;" must therefore return 1. This assumption is incorrect
6748 for Emacs, since it type-puns struct Lisp_Vector * with many other
6749 types. To fix this problem, this patch adds a new type struct
6750 vectorlike_header that documents the constraints on layout of vectors
6751 and pseudovectors, and helps optimizing compilers not get fooled
6752 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6753 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6754 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6756 (XSETPVECTYPE): Rewrite in terms of new macro.
6757 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6758 This is a bit clearer, and further avoids the possibility of
6759 undesirable aliasing.
6760 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6761 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6762 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6763 since Lisp_Subr is a special case (no "next" field).
6764 (ASIZE): Now uses header.size rather than size.
6765 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6766 to avoid the hassle of writing XVECTOR (foo)->header.size.
6767 (struct vectorlike_header): New type.
6768 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6769 object, to help avoid aliasing.
6770 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6771 (SUBRP): Likewise, since Lisp_Subr is a special case.
6772 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6773 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6774 (struct Lisp_Hash_Table): Combine first two members into a single
6775 struct vectorlike_header member. All uses of "size" and "next" members
6776 changed to be "header.size" and "header.next".
6777 * buffer.h (struct buffer): Likewise.
6778 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6779 * frame.h (struct frame): Likewise.
6780 * process.h (struct Lisp_Process): Likewise.
6781 * termhooks.h (struct terminal): Likewise.
6782 * window.c (struct save_window_data, struct saved_window): Likewise.
6783 * window.h (struct window): Likewise.
6784 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6785 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6786 * buffer.c (init_buffer_once): Likewise.
6787 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6789 * process.c (Fformat_network_address): Use local var for size,
6792 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6794 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6795 * data.c (atof): Remove decl; no longer used or needed.
6796 (digit_to_number): Move to lread.c.
6797 (Fstring_to_number): Use new string_to_number function, to be
6798 consistent with how the Lisp reader treats infinities and NaNs.
6799 Do not assume that floating-point numbers represent EMACS_INT
6800 without losing information; this is not true on most 64-bit hosts.
6801 Avoid double-rounding errors, by insisting on integers when
6802 parsing non-base-10 numbers, as the documentation specifies.
6803 * lisp.h (string_to_number): New decl, replacing ...
6804 (isfloat_string): Remove.
6805 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6806 (read1): Do not accept +. and -. as integers; this
6807 appears to have been a coding error. Similarly, do not accept
6808 strings like +-1e0 as floating point numbers. Do not report
6809 overflow for integer overflows unless the base is not 10 which
6810 means we have no simple and reliable way to continue.
6811 Break out the floating-point parsing into a new
6812 function string_to_number, so that Fstring_to_number parses
6813 floating point numbers consistently with the Lisp reader.
6814 (digit_to_number): Move here from data.c. Make it static inline.
6815 (E_CHAR, EXP_INT): Remove, replacing with ...
6816 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6817 (string_to_number): New function, replacing isfloat_string.
6818 This function checks for valid syntax and produces the resulting
6819 Lisp float number too. Rework it so that string-to-number
6820 no longer mishandles examples like "1.0e+". Use strtoumax,
6821 so that overflow for non-base-10 numbers is reported only when
6822 there's no portable and simple way to convert to floating point.
6824 * textprop.c (set_text_properties_1): Rewrite for clarity,
6825 and to avoid GCC warning about integer overflow.
6827 * intervals.h (struct interval): Use EMACS_INT for members
6828 where EMACS_UINT might cause problems. See
6829 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6830 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6831 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6833 (offset_intervals): Tell GCC not to worry about length overflow
6834 when negating a negative length.
6836 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6837 (overrun_check_free): Likewise.
6839 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6840 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6843 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6844 (gnutls_make_error): Rename local to avoid shadowing.
6845 (gnutls_emacs_global_deinit): ifdef out; not used.
6846 (Fgnutls_boot): Use const for pointer to readonly storage.
6847 Comment out unused local. Fix pointer signedness problems.
6849 * lread.c (openp): Don't stuff size_t into an 'int'.
6850 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6851 about possible signed overflow.
6853 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6854 (GDK_KEY_g): Don't define if already defined.
6855 (xg_prepare_tooltip): Avoid pointer signedness problem.
6856 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6858 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6859 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6861 * xfns.c (Fx_window_property): Simplify a bit,
6862 to make a bit faster and to avoid GCC 4.6.0 warning.
6863 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6865 * fns.c (internal_equal): Don't assume size_t fits in int.
6867 * alloc.c (compact_small_strings): Tighten assertion a little.
6869 Replace pEd with more-general pI, and fix some printf arg casts.
6870 * lisp.h (pI): New macro, generalizing old pEd macro to other
6871 conversion specifiers. For example, use "...%"pI"d..." rather
6872 than "...%"pEd"...".
6873 (pEd): Remove. All uses replaced with similar uses of pI.
6874 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6875 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6876 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6877 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6878 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6879 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6880 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6882 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6883 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6884 * print.c (safe_debug_print, print_object): Likewise.
6885 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6887 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6888 avoiding the 0 flag, which is not portable.
6889 * process.c (Fmake_network_process): Use pI to avoid cast.
6890 * region-cache.c (pp_cache): Likewise.
6891 * xdisp.c (decode_mode_spec): Likewise.
6892 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6893 behavior on 64-bit hosts with printf arg.
6894 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6895 (x_stop_queuing_selection_requests): Likewise.
6896 (x_get_window_property): Don't truncate byte count to an 'int'
6899 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6900 here, since it parses constructs like leading '-' and spaces,
6901 which are not wanted; and it overflows with large numbers.
6902 Instead, simply match F[0-9]+, which is what is wanted anyway.
6904 * alloc.c: Remove unportable assumptions about struct layout.
6905 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6906 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6907 (allocate_vectorlike, make_pure_vector): Use the new macros,
6908 plus offsetof, to remove unportable assumptions about struct layout.
6909 These assumptions hold on all porting targets that I know of, but
6910 they are not guaranteed, they're easy to remove, and removing them
6911 makes further changes easier.
6913 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6914 This doesn't fix a bug but makes the code clearer.
6915 (string_overrun_cookie): Now const. Use initializers that
6916 don't formally overflow signed char, to avoid warnings.
6917 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6918 can cause Emacs to crash when string overrun checking is enabled.
6919 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6920 multiple of sizeof (EMACS_INT); it need not be, if
6921 alignof(EMACS_INT) < sizeof (EMACS_INT).
6922 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6924 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6926 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6928 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6930 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6931 supposed to be handshaking. (Bug#8556)
6932 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6934 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6936 * lisp.h (Qdebug): List symbol.
6937 * eval.c (Qdebug): Restore global linkage.
6938 * keyboard.c (debug-on-event): New variable.
6939 (handle_user_signal): Break into debugger when debug-on-event
6940 matches the current signal symbol.
6942 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6944 * alloc.c (check_sblock, check_string_bytes)
6945 (check_string_free_list): Convert to standard C.
6947 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6949 * w32.c (emacs_gnutls_push): Fix typo.
6951 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6953 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6954 "cast to pointer from integer of different size".
6956 Improve doprnt and its use in verror. (Bug#8545)
6957 * doprnt.c (doprnt): Document the set of format control sequences
6958 supported by the function. Use SAFE_ALLOCA instead of always
6961 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6962 is one byte too soon. Don't use xrealloc; instead xfree and
6965 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6967 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6970 * gnutls.c: Renamed global_initialized to
6971 gnutls_global_initialized. Added internals for the
6972 :verify-hostname-error, :verify-error, and :verify-flags
6973 parameters of `gnutls-boot' and documented those parameters in the
6974 docstring. Start callback support.
6975 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6976 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6977 on error. Return error code.
6978 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6979 (emacs_gnutls_read): Likewise.
6980 (Fgnutls_boot): Return handshake error code.
6981 (emacs_gnutls_handle_error): New function.
6982 (wsaerror_to_errno): Likewise.
6984 * w32.h (emacs_gnutls_pull): Add prototype.
6985 (emacs_gnutls_push): Likewise.
6987 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6988 (emacs_gnutls_push): Likewise.
6990 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6992 * process.c (wait_reading_process_output): Check if GnuTLS
6993 buffered some data internally if no FDs are set for TLS
6996 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6997 (LIBS): Link to USER_LIBS.
6998 ($(BLD)/gnutls.$(0)): New target.
7000 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7002 * xdisp.c (handle_single_display_spec): Rename the
7003 display_replaced_before_p argument into display_replaced_p, to
7004 make it consistent with the commentary. Fix typos in the
7007 * textprop.c (syms_of_textprop): Remove dead code.
7008 (copy_text_properties): Delete obsolete commentary about an
7009 interface that was deleted long ago. Fix typos in the description
7012 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7013 to changes in oldXMenu/XMenu.h from 2011-04-16.
7014 <menu_help_message, prev_menu_help_message>: Constify.
7015 (IT_menu_make_room): menu->help_text is now `const char **';
7018 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7019 to changes in oldXMenu/XMenu.h from 2011-04-16.
7020 (struct XMenu): Declare `help_text' `const char **'.
7022 * xfaces.c <Qunspecified>: Make extern again.
7024 * syntax.c: Include sys/types.h before including regex.h, as
7027 * doc.c (get_doc_string): Improve the format passed to `error'.
7029 * doprnt.c (doprnt): Improve commentary.
7031 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7033 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7036 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7037 changes in globals.h immediately force recompilation.
7038 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7039 $(CURDIR)/s/ms-w32.h.
7040 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7042 * character.c (Fchar_direction): Function deleted.
7043 (syms_of_character): Don't defsubr it.
7044 <char-direction-table>: Deleted.
7046 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7048 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7049 * doprnt.c: Include limits.h.
7050 (SIZE_MAX): New macro.
7051 (doprnt): Return a size_t value. 2nd arg is now size_t.
7052 Many local variables are now size_t instead of int or unsigned.
7053 Improve overflow protection. Support `l' modifier for integer
7054 conversions. Support %l conversion. Don't assume an EMACS_INT
7055 argument for integer conversions and for %c.
7057 * lisp.h (doprnt): Restore prototype.
7059 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7062 * Makefile.in (base_obj): Add back doprnt.o.
7064 * deps.mk (doprnt.o): Add back prerequisites.
7065 (callint.o): Depend on character.h.
7067 * eval.c (internal_lisp_condition_case): Include the handler
7068 representation in the error message.
7069 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7070 when breaking from the loop.
7072 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7074 * callint.c (Fcall_interactively): When displaying error message
7075 about invalid control letter, pass the character's codepoint, not
7076 a pointer to its multibyte form. Improve display of the character
7077 in octal and display also its hex code.
7079 * character.c (char_string): Use %x to display the (unsigned)
7080 codepoint of an invalid character, to avoid displaying a bogus
7083 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7084 `error', not SYMBOL_NAME itself.
7086 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7087 character arguments to `error'.
7089 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7090 to `error' in error message about FINAL_CHAR argument. Make sure
7091 FINAL_CHAR is a character, and use %c when it is passed as
7092 argument to `error'.
7094 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7096 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7098 * w32.c: Include <time.h>.
7099 (sys_localtime): New function.
7101 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7103 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7105 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7107 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7109 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7112 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7114 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7115 gl_state.e_property when gl_state.object is Qt.
7117 * insdel.c (make_gap_larger): Remove limitation of buffer size
7120 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7122 * xdisp.c (lookup_glyphless_char_display)
7123 (produce_glyphless_glyph): Handle cons cell entry in
7124 glyphless-char-display.
7125 (Vglyphless_char_display): Document it.
7127 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7128 glyphless-char-display.
7130 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7132 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7134 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7136 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7137 definition for no-X builds.
7139 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7141 Static checks with GCC 4.6.0 and non-default toolkits.
7143 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7145 * process.c (keyboard_bit_set): Define only if SIGIO.
7146 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7147 (send_process): Repair possible setjmp clobbering.
7149 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7151 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7153 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7155 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7156 Define only if needed.
7158 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7159 by pacifying GCC about it. Maybe it's time to retire it?
7160 * xfaces.c (USG, __TIMEVAL__): Likewise.
7162 * dispextern.h (struct redisplay_interface): Rename param
7164 * termhooks.h (struct terminal): Likewise.
7165 * xterm.c (xembed_send_message): Likewise.
7167 * insdel.c (make_gap_smaller): Define only if
7168 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7170 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7173 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7174 so that we aren't warned about unused symbols.
7176 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7178 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7180 * xfns.c (x_real_positions): Mark locals as initialized.
7182 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7184 * xterm.c: Fix problems found by static analysis with other toolkits.
7185 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7186 (x_dispatch_event): Declare static if USE_GTK, and
7187 define if USE_GTK || USE_X_TOOLKIT.
7188 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7189 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7190 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7191 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7193 * xmenu.c (menu_help_callback): Pointer type fixes.
7194 Use const pointers when pointing at readonly data. Avoid pointer
7196 (FALSE): Remove unused macro.
7197 (update_frame_menubar): Remove unused decl.
7199 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7201 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7202 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7203 (single_menu_item): Rename local to avoid shadowing.
7205 * keyboard.c (make_lispy_event): Remove unused local var.
7207 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7208 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7210 * bitmaps: Change bitmaps from unsigned char back to the X11
7211 compatible char. Avoid the old compiler warnings about
7212 out-of-range initializers by using, for example, '\xab' rather
7215 * xgselect.c (xgselect_initialize): Check vs interface
7216 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7218 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7220 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7221 to read-only memory.
7223 * fns.c (vector): Remove; this old hack is no longer needed.
7225 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7227 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7229 * xrdb.c (x_load_resources): Omit unused local.
7231 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7232 (x_window): Rename locals to avoid shadowing.
7233 (USG): Use the kludged USG macro, to pacify gcc.
7235 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7236 (x_term_init): Remove local to avoid shadowing.
7238 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7240 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7241 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7243 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7245 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7247 Fix regex.c, syntax.c and friends for buffers > 2GB.
7248 * syntax.h (struct gl_state_s): Declare character position members
7251 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7253 * textprop.c (verify_interval_modification, interval_of):
7254 Declare arguments EMACS_INT.
7256 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7259 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7261 * indent.c (Fvertical_motion): Local variable it_start is now
7264 * regex.c (re_match, re_match_2, re_match_2_internal)
7265 (bcmp_translate, regcomp, regexec, print_double_string)
7266 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7267 (re_compile_pattern, re_exec): Declare arguments and local
7268 variables `size_t' and `ssize_t' and return values `regoff_t', as
7270 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7271 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7272 <compile_stack_type>: `size' and `avail' are now `size_t'.
7274 * regex.h <regoff_t>: Use ssize_t, not int.
7275 (re_search, re_search_2, re_match, re_match_2): Arguments that
7276 specify buffer/string position and length are now ssize_t and
7277 size_t. Return type is regoff_t.
7279 2011-04-16 Ben Key <bkey76@gmail.com>
7281 * nsfont.m: Fixed bugs in ns_get_family and
7282 ns_descriptor_to_entity that were caused by using free to
7283 deallocate memory blocks that were allocated by xmalloc (via
7284 xstrdup). This caused Emacs to crash when compiled with
7285 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7286 --enable-checking=xmallocoverrun). xfree is now used to
7287 deallocate these memory blocks.
7289 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7291 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7293 emacs_write: Accept and return EMACS_INT for sizes.
7294 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7296 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7297 Accept and return EMACS_INT.
7298 (emacs_gnutls_write): Return the number of bytes written on
7300 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7301 (emacs_read, emacs_write): Remove check for negative size, as the
7302 Emacs source code has been audited now.
7303 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7304 (emacs_read, emacs_write): Use it.
7305 * process.c (send_process): Adjust to the new signatures of
7306 emacs_write and emacs_gnutls_write. Do not attempt to store
7307 a byte offset into an 'int'; it might overflow.
7308 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7310 * sound.c: Don't assume sizes fit in 'int'.
7311 (struct sound_device.period_size, alsa_period_size):
7312 Return EMACS_INT, not int.
7313 (struct sound_device.write, vox_write, alsa_write):
7314 Accept EMACS_INT, not int.
7315 (wav_play, au_play): Use EMACS_INT to store sizes and to
7316 record read return values.
7318 2011-04-15 Ben Key <bkey76@gmail.com>
7320 * keyboard.c (Qundefined): Don't declare static since it is used
7322 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7323 static since they are used in nsfont.m.
7325 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7327 * process.c (Qprocessp): Don't declare static.
7328 * lisp.h (Qprocessp): Declare again.
7330 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7332 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7334 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7336 Improve C-level modularity by making more things 'static'.
7338 Don't publish debugger-only interfaces to other modules.
7339 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7340 (verify_bytepos, count_markers): Move decls to the only modules
7342 * region-cache.h (pp_cache): Likewise.
7343 * window.h (check_all_windows): Likewise.
7344 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7346 * sysdep.c (croak): Now static, if
7347 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7348 * syssignal.h (croak): Declare only if not static.
7350 * alloc.c (refill_memory_reserve): Now static if
7351 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7352 * lisp.h (refill_memory_reserve): Declare only if not static.
7354 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7355 Define only if USE_LUCID.
7357 * xrdb.c (x_customization_string, x_rm_string): Now static.
7359 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7360 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7362 * xdisp.c (draw_row_with_mouse_face): Now static.
7363 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7365 * window.h (check_all_windows): Mark externally visible.
7367 * window.c (window_deletion_count): Now static.
7369 * undo.c: Make symbols static if they're not exported.
7370 (last_undo_buffer, last_boundary_position, pending_boundary):
7373 * textprop.c (interval_insert_behind_hooks): Now static.
7374 (interval_insert_in_front_hooks): Likewise.
7376 * term.c: Make symbols static if they're not exported.
7377 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7378 (max_frame_lines, tty_set_terminal_modes):
7379 (tty_reset_terminal_modes, tty_turn_off_highlight):
7380 (get_tty_terminal): Now static.
7381 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7382 * termhooks.h (term_mouse_moveto): Do not declare if
7384 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7385 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7387 * sysdep.c: Make symbols static if they're not exported.
7388 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7390 (sigprocmask_set, full_mask): Remove; unused.
7391 (wait_debugging): Mark as visible.
7392 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7393 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7395 * syntax.c (syntax_temp): Define only if !__GNUC__.
7397 * sound.c (current_sound_device, current_sound): Now static.
7399 * search.c (searchbufs, searchbuf_head): Now static.
7401 * scroll.c (scroll_cost): Remove; unused.
7402 * dispextern.h (scroll_cost): Remove decl.
7404 * region-cache.h (pp_cache): Mark as externally visible.
7406 * process.c: Make symbols static if they're not exported.
7407 (process_tick, update_tick, create_process, chan_process):
7408 (Vprocess_alist, proc_buffered_char, datagram_access):
7409 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7410 (deactivate_process): Mark defn as static, as well as decl.
7411 * lisp.h (create_process): Remove decl.
7412 * process.h (chan_process, Vprocess_alist): Remove decls.
7414 * print.c: Make symbols static if they're not exported.
7415 (print_depth, new_backquote_output, being_printed, print_buffer):
7416 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7417 (print_interval, print_number_index, initial_stderr_stream):
7419 * lisp.h (Fprinc): Remove decl.
7420 (debug_output_compilation_hack): Mark as externally visible.
7422 * sysdep.c (croak): Move decl from here to syssignal.h.
7423 * syssignal.h (croak): Put it here, so the API can be checked when
7424 'croak' is called from dissociate_if_controlling_tty.
7426 * minibuf.c: Make symbols static if they're not exported.
7427 (minibuf_save_list, choose_minibuf_frame): Now static.
7428 * lisp.h (choose_minibuf_frame): Remove decl.
7430 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7432 * lread.c: Make symbols static if they're not exported.
7433 (read_objects, initial_obarray, oblookup_last_bucket_number):
7435 (make_symbol): Remove; unused.
7436 * lisp.h (initial_obarray, make_symbol): Remove decls.
7438 * keyboard.c: Make symbols static if they're not exported.
7439 (single_kboard, recent_keys_index, total_keys, recent_keys):
7440 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7441 (this_single_command_key_start, echoing, last_auto_save):
7442 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7443 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7444 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7445 (Vlispy_mouse_stem, double_click_count):
7447 (force_auto_save_soon): Define only if SIGDANGER.
7448 (ignore_mouse_drag_p): Now static if
7449 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7450 (print_help): Remove; unused.
7451 (stop_character, last_timer_event): Mark as externally visible.
7452 * keyboard.h (ignore_mouse_drag_p): Declare only if
7453 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7454 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7455 * lisp.h (echoing): Remove decl.
7456 (force_auto_save_soon): Declare only if SIGDANGER.
7457 * xdisp.c (redisplay_window): Simplify code, to make it more
7458 obvious that ignore_mouse_drag_p is not accessed if !defined
7459 USE_GTK && !defined HAVE_NS.
7461 * intervals.c: Make symbols static if they're not exported.
7462 (merge_properties_sticky, merge_interval_right, delete_interval):
7464 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7466 * insdel.c: Make symbols static if they're not exported.
7467 However, leave prepare_to_modify_buffer alone. It's never
7468 called from outside this function, but that appears to be a bug.
7469 (combine_after_change_list, combine_after_change_buffer):
7470 (adjust_after_replace, signal_before_change): Now static.
7471 (adjust_after_replace_noundo): Remove; unused.
7472 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7473 (signal_before_change): Remove decls.
7475 * indent.c (val_compute_motion, val_vmotion): Now static.
7477 * image.c: Make symbols static if they're not exported.
7478 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7480 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7481 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7483 * fringe.c (standard_bitmaps): Now static.
7484 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7486 * frame.c: Make symbols static if they're not exported.
7487 (x_report_frame_params, make_terminal_frame): Now static.
7488 (get_frame_param): Now static, unless HAVE_NS.
7489 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7490 (x_get_resource_string): Remove; not used.
7491 * frame.h (make_terminal_frame, x_report_frame_params):
7492 (x_get_resource_string); Remove decls.
7493 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7494 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7496 * font.c, fontset.c: Make symbols static if they're not exported.
7497 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7498 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7499 * font.c (font_close_object): Now static.
7500 * font.h (font_close_object): Remove.
7501 * fontset.c (FONTSET_OBJLIST): Remove.
7502 (free_realized_fontset) #if-0 the body, which does nothing.
7503 (face_suitable_for_char_p): #if-0, as it's never called.
7504 * fontset.h (face_suitable_for_char_p): Remove decl.
7505 * xfaces.c (face_at_string_position):
7506 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7507 since 0 is always ASCII.
7509 * fns.c (weak_hash_tables): Now static.
7511 * fileio.c: Make symbols static if they're not exported.
7512 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7513 (Vwrite_region_annotation_buffers): Now static.
7515 * eval.c: Make symbols static if they're not exported.
7516 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7517 * lisp.h (backtrace_list): Remove decl.
7519 * emacs.c: Make symbols static if they're not exported.
7520 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7521 (fatal_error_code, fatal_error_signal_hook, standard_args):
7523 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7524 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7525 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7526 * lisp.h (fatal_error_signal_hook): Remove decl.
7527 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7529 * editfns.c: Move a (normally-unused) function to its only use.
7530 * editfns.c, lisp.h (get_operating_system_release): Remove.
7531 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7532 worth the hassle of breaking this out.
7534 * xterm.c: Make symbols static if they're not exported.
7535 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7536 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7537 (x_destroy_window, x_delete_display):
7539 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7540 (x_mouse_leave): Remove; unused.
7541 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7542 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7543 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7545 (x_mouse_leave): Declare only if WINDOWSNT.
7546 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7547 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7550 * ftxfont.c: Make symbols static if they're not exported.
7551 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7553 * font.h (ftxfont_driver): Likewise.
7555 * xfns.c: Make symbols static if they're not exported.
7556 (x_last_font_name, x_display_info_for_name):
7557 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7558 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7559 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7560 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7561 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7562 (last_show_tip_args): Now static.
7563 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7564 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7565 (x_screen_planes): Remove; unused.
7566 * dispextern.h (x_screen_planes): Remove decl.
7568 * dispnew.c: Make symbols static if they're not exported.
7569 * dispextern.h (redraw_garbaged_frames, scrolling):
7570 (increment_row_positions): Remove.
7571 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7572 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7574 (redraw_garbaged_frames): Remove; unused.
7576 * xfaces.c: Make symbols static if they're not exported.
7577 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7579 * xterm.h (defined_color): Remove decls.
7580 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7581 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7582 (menu_face_changed_default, defined_color, free_realized_face):
7583 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7584 (ascii_face_of_lisp_face): Remove; unused.
7586 * xdisp.c: Make symbols static if they're not exported.
7587 * dispextern.h (scratch_glyph_row, window_box_edges):
7588 (glyph_to_pixel_coords, set_cursor_from_row):
7589 (get_next_display_element, set_iterator_to_next):
7590 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7591 (show_mouse_face): Remove decls
7592 * frame.h (message_buf_print): Likewise.
7593 * lisp.h (pop_message, set_message, check_point_in_composition):
7595 * xterm.h (set_vertical_scroll_bar): Likewise.
7596 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7597 (message_buf_print, scratch_glyph_row, displayed_buffer):
7598 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7599 (get_next_display_element, show_mouse_face, window_box_edges):
7600 (frame_to_window_pixel_xy, check_point_in_composition):
7601 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7602 (glyph_to_pixel_coords): Remove; unused.
7604 * dired.c (file_name_completion): Now static.
7606 * dbusbind.c (xd_in_read_queued_messages): Now static.
7608 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7609 * data.c (circular_list_error): Remove.
7611 * commands.h (last_point_position, last_point_position_buffer):
7612 (last_point_position_window): Remove decls.
7613 * keyboard.c: Make these variables static.
7615 * coding.h (coding, code_convert_region, encode_coding_gap):
7617 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7618 (iso_code_class, detect_coding, code_convert_region): Now static.
7619 (encode_coding_gap): Remove; unused.
7621 * chartab.c (chartab_chars, chartab_bits): Now static.
7623 * charset.h (charset_iso_8859_1): Remove decl.
7624 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7627 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7628 * ccl.c (Vccl_program_table): Now static.
7629 (check_ccl_update): Remove; unused.
7631 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7632 * category.h: ... from here.
7633 * category.c (check_category_table, set_category_set): Now static.
7635 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7636 * lisp.h: Remove these decls.
7638 * buffer.c (buffer_count): Remove unused var.
7640 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7641 so that it's not optimized away.
7642 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7643 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7644 exported only to the debugger.
7646 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7647 * atimer.h (run_all_atimers): Remove; not exported.
7649 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7650 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7651 was inaccessible from Lisp.
7652 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7653 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7655 alloc.c: Import and export fewer symbols, and remove unused items.
7656 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7658 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7659 it's not optimized away by whole-program optimization.
7660 (message_enable_multibyte, free_misc): Remove.
7661 (catchlist, handlerlist, mark_backtrace):
7662 Declare only if BYTE_MARK_STACK.
7663 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7664 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7665 (message_enable_multibyte): Remove decl.
7666 (free_misc, interval_free_list, float_block, float_block_index):
7667 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7668 (cons_free_list, last_marked_index):
7670 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7671 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7672 (mark_backtrace): Define only if BYTE_MARK_STACK.
7673 * xdisp.c (message_enable_multibyte): Now static.
7675 Declare Lisp_Object Q* variables to be 'static' if not exported.
7676 This makes it easier for human readers (and static analyzers)
7677 to see whether these variables are used from other modules.
7678 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7679 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7680 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7681 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7682 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7683 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7684 * xmenu.c, xselect.c:
7685 Declare Q* vars static if they are not used in other modules.
7686 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7687 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7688 Remove decls of unexported vars.
7689 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7691 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7693 Make Emacs functions such as Fatom 'static' by default.
7694 This makes it easier for human readers (and static analyzers)
7695 to see whether these functions can be called from other modules.
7696 DEFUN now defines a static function. To make the function external
7697 so that it can be used in other C modules, use the new macro DEFUE.
7698 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7699 (Finit_image_library):
7700 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7701 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7702 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7703 Remove decls, since these functions are now static.
7704 (Funintern, Fget_internal_run_time): New decls, since these functions
7705 were already external.
7707 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7708 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7709 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7710 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7711 * keyboard.c, keymap.c, lread.c:
7712 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7713 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7714 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7715 Mark functions with DEFUE instead of DEFUN,
7716 if they are used in other modules.
7717 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7718 decls for now-static functions.
7719 * buffer.h (Fdelete_overlay): Remove decl.
7720 * callproc.c (Fgetenv_internal): Mark as internal.
7721 * composite.c (Fremove_list_of_text_properties): Remove decl.
7722 (Fcomposition_get_gstring): New forward static decl.
7723 * composite.h (Fcomposite_get_gstring): Remove decl.
7724 * dired.c (Ffile_attributes): New forward static decl.
7725 * doc.c (Fdocumntation_property): New forward static decl.
7726 * eval.c (Ffetch_bytecode): New forward static decl.
7727 (Funintern): Remove extern decl; now in .h file where it belongs.
7728 * fileio.c (Fmake_symbolic_link): New forward static decl.
7729 * image.c (Finit_image_library): New forward static decl.
7730 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7731 * intervals.h (Fprevious_property_change):
7732 (Fremove_list_of_text_properties): Remove decls.
7733 * keyboard.c (Fthis_command_keys): Remove decl.
7734 (Fcommand_execute): New forward static decl.
7735 * keymap.c (Flookup_key): New forward static decl.
7736 (Fcopy_keymap): Now static.
7737 * keymap.h (Flookup_key): Remove decl.
7738 * process.c (Fget_process): New forward static decl.
7739 (Fprocess_datagram_address): Mark as internal.
7740 * syntax.c (Fsyntax_table_p): New forward static decl.
7741 (skip_chars): Remove duplicate decl.
7742 * textprop.c (Fprevious_property_change): New forward static decl.
7743 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7745 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7746 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7748 * editfns.c (Fformat): Remove unreachable code.
7750 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7752 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7755 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7757 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7758 when at ZV. (Bug#8487)
7760 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7762 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7764 * keyboard.c (parse_tool_bar_item): Likewise.
7765 * sound.c (sound_cleanup, alsa_close): Likewise.
7766 * termcap.c (tgetent): Likewise.
7767 * xfns.c (x_default_font_parameter): Likewise.
7768 * xsettings.c (read_and_apply_settings): Likewise.
7770 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7771 (overrun_check_free): Protoize.
7773 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7775 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7776 since callers should never pass a negative size.
7777 Change the signature to match that of plain 'read' and 'write'; see
7778 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7779 * lisp.h: Update prototypes of emacs_write and emacs_read.
7781 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7783 * xdisp.c (redisplay_window): Don't try to determine the character
7784 position of the scroll margin if the window start point w->startp
7785 is outside the buffer's accessible region. (Bug#8468)
7787 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7789 Fix write-region and its subroutines for buffers > 2GB.
7790 * fileio.c (a_write, e_write): Modify declaration of arguments and
7791 local variables to support buffers larger than 2GB.
7792 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7794 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7795 argument, local variables, and return value.
7797 * lisp.h: Update prototypes of emacs_write and emacs_read.
7799 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7801 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7803 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7805 Fix more problems found by GCC 4.6.0's static checks.
7807 * xdisp.c (vmessage): Use a better test for character truncation.
7809 * charset.c (load_charset_map): <, not <=, for optimization,
7810 and to avoid potential problems with integer overflow.
7811 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7812 * casetab.c (set_identity, shuffle): Likewise.
7813 * editfns.c (Fformat): Likewise.
7814 * syntax.c (skip_chars): Likewise.
7816 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7817 This also lets GCC 4.6.0 generate slightly better loop code.
7819 * callint.c (Fcall_interactively): <, not <=, for optimization.
7820 (Fcall_interactively): Count the number of arguments produced,
7821 not the number of arguments given. This is simpler and lets GCC
7822 4.6.0 generate slightly better code.
7824 * ftfont.c: Distingish more carefully between FcChar8 and char.
7825 The previous code passed unsigned char * to a functions like
7826 strlen and xstrcasecmp that expect char *, which does not
7827 conform to the C standard.
7828 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7829 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7830 char * when the C standard requires it.
7832 * keyboard.c (read_char): Remove unused var.
7834 * eval.c: Port to Windows vsnprintf (Bug#8435).
7836 (SIZE_MAX): Define if the headers do not.
7837 (verror): Do not give up if vsnprintf returns a negative count.
7838 Instead, grow the buffer. This ports to Windows vsnprintf, which
7839 does not conform to C99. Problem reported by Eli Zaretskii.
7840 Also, simplify the allocation scheme, by avoiding the need for
7841 calling realloc, and removing the ALLOCATED variable.
7843 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7845 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7846 But keep the doprint source code for now, as we might revamp it
7847 and use it again (Bug#8435).
7848 * lisp.h (doprnt): Remove.
7849 * Makefile.in (base_obj): Remove doprnt.o.
7850 * deps.mk (doprnt.o): Remove.
7852 error: Print 32- and 64-bit integers portably (Bug#8435).
7853 Without this change, on typical 64-bit hosts error ("...%d...", N)
7854 was used to print both 32- and 64-bit integers N, which relied on
7856 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7857 * lisp.h (error, verror): Mark as printf-like functions.
7858 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7859 Report overflow in size calculations when allocating printf buffer.
7860 Do not truncate output string at its first null byte.
7861 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7862 Truncate the output at a character boundary, since vsnprintf does not
7864 * charset.c (check_iso_charset_parameter): Convert internal
7865 character to string before calling 'error', since %c now has the
7867 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7868 overflow when computing char to be passed to 'error'. Do not
7869 pass Lisp_Object to 'error'; pass the integer instead.
7870 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7871 formatted with plain %d.
7873 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7875 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7877 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7879 * xterm.c (x_catch_errors): Remove duplicate declaration.
7881 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7883 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7885 2011-04-10 Jim Meyering <meyering@redhat.com>
7887 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7888 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7889 return ssize_t not "int", and use size_t as the buffer length.
7890 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7891 * gnutls.h: Update declarations.
7892 * process.c (read_process_output): Use ssize_t, to match.
7893 (send_process): Likewise.
7895 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7897 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7899 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7901 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7902 Use unsigned char, to match FcChar8 type definition.
7904 * xterm.c (handle_one_xevent):
7905 * xmenu.c (create_and_show_popup_menu):
7906 * xselect.c (x_decline_selection_request)
7907 (x_reply_selection_request): Avoid type-punned deref of X events.
7909 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7911 Fix some uses of `int' instead of EMACS_INT.
7912 * search.c (string_match_1, fast_string_match)
7913 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7914 (scan_buffer, find_next_newline_no_quit)
7915 (find_before_next_newline, search_command, Freplace_match)
7916 (Fmatch_data): Make some `int' variables be EMACS_INT.
7918 * xdisp.c (display_count_lines): 3rd argument and return value now
7919 EMACS_INT. All callers changed.
7920 (pint2hrstr): Last argument is now EMACS_INT.
7922 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7923 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7924 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7925 (decode_coding_utf_16, decode_coding_emacs_mule)
7926 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7927 (decode_coding_ccl, decode_coding_charset)
7928 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7929 (decode_coding_iso_2022, decode_coding_emacs_mule)
7930 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7931 <char_offset, last_offset>: Declare EMACS_INT.
7932 (encode_coding_utf_8, encode_coding_utf_16)
7933 (encode_coding_emacs_mule, encode_invocation_designation)
7934 (encode_designation_at_bol, encode_coding_iso_2022)
7935 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7936 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7938 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7939 (encode_invocation_designation): Last argument P_NCHARS is now
7941 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7942 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7944 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7947 * ccl.c (Fccl_execute_on_string): Declare some variables
7950 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7952 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7954 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7956 * process.c (Fformat_network_address): Doc fix.
7958 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7960 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7962 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7964 * keyboard.c (read_char): Call Lisp function help-form-show,
7965 instead of using internal_with_output_to_temp_buffer.
7966 (Qhelp_form_show): New var.
7967 (syms_of_keyboard): Use DEFSYM macro.
7969 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7971 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7973 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7975 * process.c (Flist_processes): Remove to Lisp.
7976 (list_processes_1): Delete.
7978 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7980 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7982 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7984 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7986 Fix more problems found by GCC 4.6.0's static checks.
7988 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7990 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7992 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7994 * xdisp.c (vmessage): Mark as a printf-like function.
7996 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7998 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8000 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8001 printf-like functions.
8002 (tiff_load): Add casts to remove these marks before passing them
8003 to system-supplied API.
8005 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8007 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8008 This avoids several warnings with gcc -Wstrict-overflow.
8009 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8010 directly, rather than having caller test rule sign. This avoids
8011 some unnecessary tests.
8012 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8013 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8014 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8016 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8017 (xfont_open): Avoid unnecessary tests.
8019 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8021 * composite.h, composite.c (composition_gstring_put_cache):
8022 Use EMACS_INT, not int, for length.
8024 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8025 breaking out part of COMPOSITION_DECODE_RULE.
8026 (COMPOSITION_DECODE_RULE): Use it.
8027 * composite.c (get_composition_id): Remove unused local vars,
8028 by using the new macro.
8030 * textprop.c (set_text_properties_1): Change while to do-while,
8031 since the condition is always true at first.
8033 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8034 (interval_deletion_adjustment): Return unsigned value.
8037 * process.c (list_processes_1, create_pty, read_process_output):
8038 (exec_sentinel): Remove vars that were set but not used.
8039 (create_pty): Remove unnecessary "volatile"s.
8040 (Fnetwork_interface_info): Avoid possibility of int overflow.
8041 (read_process_output): Do adaptive read buffering even if carryover.
8042 (read_process_output): Simplify nbytes computation if buffered.
8044 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8046 * syntax.c (scan_words): Remove var that was set but not used.
8047 (update_syntax_table): Use unsigned instead of int.
8049 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8050 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8051 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8053 * print.c (print_error_message): Avoid int overflow.
8055 * font.c (font_list_entities): Redo for clarity,
8056 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8058 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8059 (font_score): Avoid potential overflow in diff calculation.
8061 * fns.c (substring_both): Remove var that is set but not used.
8062 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8064 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8066 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8067 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8068 can always succeed if overflow has undefined behavior.
8070 * search.c (boyer_moore, wordify): Remove vars set but not used.
8071 (wordify): Omit three unnecessary tests.
8073 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8074 All callers changed. This avoids the need for an unused var.
8076 * casefiddle.c (casify_region): Remove var that is set but not used.
8078 * dired.c (file_name_completion): Remove var that is set but not used.
8080 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8082 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8083 (Finsert_file_contents): Remove unnecessary code checking fd.
8085 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8086 Check for integer overflow on size calculations.
8088 * buffer.c (Fprevious_overlay_change): Remove var that is set
8091 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8092 Remove vars that are set but not used.
8093 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8094 (timer_check_2): Mark vars as initialized.
8096 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8098 * image.c (lookup_image): Remove var that is set but not used.
8099 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8101 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8102 that are set but not used.
8104 * xfns.c (make_invisible_cursor): Don't return garbage
8105 if XCreateBitmapFromData fails (Bug#8410).
8107 * xselect.c (x_get_local_selection, x_handle_property_notify):
8108 Remove vars that are set but not used.
8110 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8111 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8113 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8114 Remove var that is set but not used.
8115 (scroll_bar_windows_size): Now size_t, not int.
8116 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8119 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8120 (map_tty_color) [!defined MSDOS]: Likewise.
8122 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8124 * coding.c: Remove vars that are set but not used.
8125 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8126 All callers changed.
8127 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8128 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8129 (decode_coding_charset): Remove vars that are set but not used.
8131 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8132 that is set but not used.
8134 * print.c (print_object): Remove var that is set but not used.
8136 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8137 The gnulib version avoids calling malloc in the usual case,
8138 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8139 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8140 * filelock.c (current_lock_owner): Likewise.
8141 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8142 * sysdep.c: Include allocator.h, careadlinkat.h.
8143 (emacs_no_realloc_allocator): New static constant.
8144 (emacs_readlink): New function.
8145 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8146 ../lib/careadlinkat.h.
8148 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8150 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8151 first non-nil return value).
8153 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8155 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8156 if not defined (Bug#8403).
8158 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8160 * xdisp.c (display_count_lines): Remove parameter `start',
8161 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8162 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8163 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8164 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8165 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8166 and thereabouts. All callers changed.
8167 (get_per_char_metric): Remove parameter `f', unused since
8168 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8170 2011-04-02 Jim Meyering <meyering@redhat.com>
8172 do not dereference NULL upon failed strdup
8173 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8174 (ns_get_family): Likewise.
8176 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8178 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8180 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8182 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8185 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8187 Add lexical binding.
8189 * window.c (Ftemp_output_buffer_show): New fun.
8190 (Fsave_window_excursion):
8191 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8193 * lread.c (lisp_file_lexically_bound_p): New function.
8194 (Fload): Bind Qlexical_binding.
8195 (readevalloop): Remove `evalfun' arg.
8196 Bind Qinternal_interpreter_environment.
8197 (Feval_buffer): Bind Qlexical_binding.
8198 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8200 (syms_of_lread): Declare `lexical-binding'.
8202 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8204 * keyboard.c (eval_dyn): New fun.
8205 (menu_item_eval_property): Use it.
8207 * image.c (parse_image_spec): Use Ffunctionp.
8209 * fns.c (concat, mapcar1): Accept byte-code-functions.
8211 * eval.c (Fsetq): Handle lexical vars.
8212 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8213 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8214 (FletX, Flet): Obey lexical binding.
8215 (Fcommandp): Handle closures.
8216 (Feval): New `lexical' arg.
8217 (eval_sub): New function extracted from Feval. Use it almost
8218 everywhere where Feval was used. Look up vars in lexical env.
8220 (Ffunctionp): Move from subr.el.
8221 (Ffuncall): Handle closures.
8222 (apply_lambda): Remove `eval_flags'.
8223 (funcall_lambda): Handle closures and new byte-code-functions.
8224 (Fspecial_variable_p): New function.
8225 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8226 but without exporting it to Lisp.
8228 * doc.c (Fdocumentation, store_function_docstring):
8229 * data.c (Finteractive_form): Handle closures.
8231 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8234 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8236 (exec_byte_code): New function extracted from Fbyte_code to handle new
8237 calling convention for byte-code-functions. Add new byte-codes.
8239 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8241 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8243 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8245 * xdisp.c (redisplay_internal): Fix prototype.
8247 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8249 * xdisp.c (SCROLL_LIMIT): New macro.
8250 (try_scrolling): Use it when setting scroll_limit.
8251 Limit scrolling to 100 screen lines.
8252 (redisplay_window): Even when falling back on "recentering",
8253 position point in the window according to scroll-conservatively,
8254 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8256 (try_scrolling): When point is above the window, allow searching
8257 as far as scroll_max, or one screenful, to compute vertical
8258 distance from PT to the scroll margin position. This prevents
8259 try_scrolling from unnecessarily failing when
8260 scroll-conservatively is set to a value slightly larger than the
8261 window height. Clean up the case of PT below the margin at bottom
8262 of window: scroll_max can no longer be INT_MAX. When aggressive
8263 scrolling is in use, don't let point enter the opposite scroll
8264 margin as result of the scroll.
8265 (syms_of_xdisp) <scroll-conservatively>: Document the
8266 threshold of 100 lines for never-recentering scrolling.
8268 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8270 * dispextern.h (move_it_by_lines):
8271 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8272 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8273 (message_log_check_duplicate): Remove parameters `prev_bol' and
8274 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8275 (redisplay_internal): Remove parameter `preserve_echo_area',
8276 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8278 * indent.c (Fvertical_motion):
8279 * window.c (window_scroll_pixel_based, Frecenter):
8280 Don't pass `need_y_p' to `move_it_by_lines'.
8282 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8284 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8285 steal a few bits to be more compact.
8286 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8287 Remove unneeded casts.
8289 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8291 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8293 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8294 binding" message (bug#7967).
8296 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8298 Fix more problems found by GCC 4.6.0's static checks.
8300 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8301 Remove unused local var.
8303 * editfns.c (Fmessage_box): Remove unused local var.
8305 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8306 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8307 Omit unused local vars.
8308 * window.c (shrink_windows): Omit unused local var.
8309 * menu.c (digest_single_submenu): Omit unused local var.
8310 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8311 Omit unused local var.
8313 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8314 Don't assume string length fits in int.
8315 (keyremap_step, read_key_sequence): Use size_t for sizes.
8316 (read_key_sequence): Don't check last_real_key_start redundantly.
8318 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8319 instead of alloca (Bug#8344).
8321 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8322 (Fbacktrace_frame): Don't assume nframes fits in int.
8324 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8326 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8329 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8331 * cm.c (calccost): Turn while-do into do-while, for clarity.
8333 * keyboard.c (syms_of_keyboard): Use the same style as later
8334 in this function when indexing through an array. This also
8335 works around GCC bug 48267.
8337 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8339 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8341 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8342 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8344 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8345 This avoids undefined behavior on integer overflow, and is a bit
8346 more convenient anyway since it is compared to a size_t variable.
8348 Variadic C functions now count arguments with size_t, not int.
8349 This avoids an unnecessary limitation on 64-bit machines, which
8350 caused (substring ...) to crash on large vectors (Bug#8344).
8351 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8352 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8353 All variadic functions and their callers changed accordingly.
8354 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8355 * data.c (arith_driver, float_arith_driver): Likewise.
8356 * editfns.c (general_insert_function): Likewise.
8357 * eval.c (struct backtrace.nargs, interactive_p)
8358 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8359 (funcall_lambda, mark_backtrace): Likewise.
8360 * fns.c (concat): Likewise.
8361 * frame.c (x_set_frame_parameters): Likewise.
8362 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8363 0 if not found, not -1. All callers changed.
8365 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8366 (stack_copy_size): Now size_t, not int.
8367 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8369 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8371 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8372 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8373 All callers changed.
8375 * lisp.h (multibyte_char_to_unibyte):
8376 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8377 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8378 * character.h (CHAR_TO_BYTE8):
8379 * cmds.c (internal_self_insert):
8380 * editfns.c (general_insert_function):
8381 * keymap.c (push_key_description):
8382 * search.c (Freplace_match):
8383 * xdisp.c (message_dolog, set_message_1): All callers changed.
8385 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8387 * keyboard.c (safe_run_hook_funcall): New function.
8388 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8389 don't set the hook to nil, but remove the offending function instead.
8390 (Qcommand_hook_internal): Remove, unused.
8391 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8392 Vcommand_hook_internal.
8394 * eval.c (enum run_hooks_condition): Remove.
8395 (funcall_nil, funcall_not): New functions.
8396 (run_hook_with_args): Call each function through a `funcall' argument.
8397 Remove `cond' argument, now redundant.
8398 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8399 (Frun_hook_with_args_until_failure): Adjust accordingly.
8400 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8402 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8404 * dispextern.h (string_buffer_position): Remove declaration.
8406 * print.c (strout): Remove parameter `multibyte', unused since
8407 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8409 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8410 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8411 All callers changed.
8413 * w32.c (_wsa_errlist): Use braces for struct initializers.
8415 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8416 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8417 All callers changed.
8418 (string_buffer_position): Likewise. Also, make static (it's never
8419 used outside xdisp.c).
8420 (cursor_row_p): Remove parameter `w', unused since
8421 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8422 (decode_mode_spec): Remove parameter `precision', introduced during
8423 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8424 All callers changed.
8426 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8428 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8430 2011-03-27 Anders Lindgren <andlind@gmail.com>
8432 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8433 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8434 (ns_update_auto_hide_menu_bar): New functions.
8435 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8436 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8437 ns_constrain_all_frames.
8438 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8439 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8441 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8443 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8445 2011-03-27 Glenn Morris <rgm@gnu.org>
8447 * syssignal.h: Replace RETSIGTYPE with void.
8448 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8449 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8450 Replace SIGTYPE with void everywhere.
8451 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8452 * s/template.h (SIGTYPE): Remove commented out definition.
8454 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8456 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8457 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8459 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8461 * w32.c (read_unc_volume): Use parameter `henum', instead of
8462 global variable `wget_enum_handle'.
8464 * keymap.c (describe_vector): Remove parameters `indices' and
8465 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8466 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8468 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8470 * keyboard.c (timer_check): Remove parameter `do_it_now',
8471 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8472 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8473 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8475 * keyboard.c (read_char):
8476 * w32menu.c (w32_menu_display_help):
8477 * xmenu.c (show_help_event, menu_help_callback):
8478 Adjust calls to `show_help_echo'.
8480 * gtkutil.c (xg_maybe_add_timer):
8481 * keyboard.c (readable_events):
8482 * process.c (wait_reading_process_output):
8483 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8485 * insdel.c (adjust_markers_gap_motion):
8486 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8487 (gap_left, gap_right): Don't call it.
8489 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8491 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8492 incurred during fontification.
8494 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8496 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8497 (DEFVAR_PER_BUFFER): Don't pass it.
8499 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8500 (scrolling_window): Don't pass it.
8502 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8504 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8506 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8508 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8509 of variables specific to SELinux and computation of `encoded_absname'.
8511 * image.c (XPutPixel): Remove unused variable `height'.
8513 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8515 * unexw32.c (get_section_info): Remove unused variable `section'.
8517 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8518 (system_process_attributes): Remove unused variable `sess'.
8519 (sys_read): Remove unused variable `err'.
8521 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8522 (w32_wnd_proc): Remove unused variable `isdead'.
8523 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8524 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8525 (x_create_tip_frame): Remove unused variable `tem'.
8527 * w32inevt.c (w32_console_read_socket):
8528 Remove unused variable `no_events'.
8530 * w32term.c (x_draw_composite_glyph_string_foreground):
8531 Remove unused variable `width'.
8533 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8535 * w32term.c (x_set_glyph_string_clipping):
8536 Don't pass uninitialized region to CombineRgn.
8538 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8540 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8541 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8542 (Fx_close_connection): Remove unused variable `i'.
8544 * w32font.c (w32font_draw): Return number of glyphs.
8545 (w32font_open_internal): Remove unused variable `i'.
8546 (w32font_driver): Add missing initializer.
8548 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8549 (fill_in_menu): Remove unused variable `items_added'.
8551 * w32term.c (last_mouse_press_frame): Remove static global variable.
8552 (w32_clip_to_row): Remove unused variable `f'.
8553 (x_delete_terminal): Remove unused variable `i'.
8555 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8556 (NOTHING): Remove unused static global variable.
8557 (uniscribe_check_otf): Remove unused variable `table'.
8558 (uniscribe_font_driver): Add missing initializers.
8560 2011-03-23 Julien Danjou <julien@danjou.info>
8562 * term.c (Fsuspend_tty, Fresume_tty):
8563 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8564 * window.c (temp_output_buffer_show):
8565 * insdel.c (signal_before_change):
8566 * frame.c (Fhandle_switch_frame):
8567 * fileio.c (Fdo_auto_save):
8568 * emacs.c (Fkill_emacs):
8569 * editfns.c (save_excursion_restore):
8570 * cmds.c (internal_self_insert):
8571 * callint.c (Fcall_interactively):
8572 * buffer.c (Fkill_all_local_variables):
8573 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8575 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8576 unconditionally since it does the check itself.
8578 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8580 Fix more problems found by GCC 4.5.2's static checks.
8582 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8583 the first time through the loop, since we know p0 < p1 then.
8584 This also avoids a gcc -Wstrict-overflow warning.
8586 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8587 leading to a memory leak, possible in functions like
8588 load_charset_map_from_file that can allocate an unbounded number
8589 of objects (Bug#8318).
8591 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8592 that could (at least in theory) be that large.
8594 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8595 This is less likely to overflow, and avoids undefined behavior if
8596 overflow does occur. All callers changed. Use strtoul to scan
8597 for the unsigned long integer.
8598 (pint2hrstr): Simplify and tune code slightly.
8599 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8601 * scroll.c (do_scrolling): Work around GCC bug 48228.
8602 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8604 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8605 This also avoids a warning with gcc -Wstrict-overflow.
8606 (validate_x_resource_name): Simplify count usage.
8607 This also avoids a warning with gcc -Wstrict-overflow.
8609 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8612 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8614 * process.c (Fmake_network_process): Use socklen_t, not int,
8615 where POSIX says socklen_t is required in portable programs.
8616 This fixes a porting bug on hosts like 64-bit HP-UX, where
8617 socklen_t is wider than int (Bug#8277).
8618 (Fmake_network_process, server_accept_connection):
8619 (wait_reading_process_output, read_process_output):
8622 * process.c: Rename or move locals to avoid shadowing.
8623 (list_processes_1, Fmake_network_process):
8624 (read_process_output_error_handler, exec_sentinel_error_handler):
8625 Rename or move locals.
8626 (Fmake_network_process): Define label "retry_connect" only if needed.
8627 (Fnetwork_interface_info): Fix pointer signedness.
8628 (process_send_signal): Add cast to avoid pointer signedness problem.
8629 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8630 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8632 Make tparam.h and terminfo.c consistent.
8633 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8634 Include tparam.h instead, since it declares them.
8635 * cm.h (PC): Remove extern decl; tparam.h now does this.
8636 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8637 * terminfo.c: Include tparam.h, to check interfaces.
8638 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8639 (tparam): Adjust signature to match interface in tparam.h;
8640 this removes some undefined behavior. Check that outstring and len
8641 are zero, which they always are with Emacs.
8642 * tparam.h (PC, BC, UP): New extern decls.
8644 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8645 (xftfont_open): Rename locals to avoid shadowing.
8647 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8648 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8649 (OTF_TAG_SYM): Omit macro if not needed.
8650 (ftfont_list): Remove unused local.
8651 (get_adstyle_property, ftfont_pattern_entity):
8652 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8653 Rename locals to avoid shadowing.
8655 * xfont.c (xfont_list_family): Mark var as initialized.
8657 * xml.c (make_dom): Now static.
8659 * composite.c (composition_compute_stop_pos): Rename local to
8661 (composition_reseat_it): Remove unused locals.
8662 (find_automatic_composition, composition_adjust_point): Likewise.
8663 (composition_update_it): Mark var as initialized.
8664 (find_automatic_composition): Mark vars as initialized,
8665 with a FIXME (Bug#8290).
8667 character.h: Rename locals to avoid shadowing.
8668 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8669 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8670 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8671 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8674 * textprop.c (property_change_between_p): Remove; unused.
8676 * intervals.c (interval_start_pos): Now static.
8678 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8680 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8681 Rename locals to avoid shadowing.
8683 * sound.c (wav_play, au_play, Fplay_sound_internal):
8684 Fix pointer signedness.
8685 (alsa_choose_format): Remove unused local var.
8686 (wav_play): Initialize a variable to 0, to prevent undefined
8687 behavior (Bug#8278).
8689 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8691 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8693 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8694 clobbering (Bug#8298).
8695 * sysdep.c (sys_subshell): Likewise.
8696 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8698 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8699 This should get cleaned up, so that child_setup has the
8700 same signature on all platforms.
8702 * callproc.c (call_process_cleanup): Now static.
8703 (relocate_fd): Rename locals to avoid shadowing.
8705 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8707 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8708 not to be necessary, and produces flickering.
8710 2011-03-20 Glenn Morris <rgm@gnu.org>
8712 * config.in: Remove file.
8714 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8716 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8717 are now in src/globals.h.
8718 (syms_of_minibuf): Remove spurious & from previous change.
8720 2011-03-20 Leo Liu <sdl.web@gmail.com>
8722 * minibuf.c (completing-read-function): New variable.
8723 (completing-read-default): Rename from completing-read.
8724 (completing-read): Call completing-read-function.
8726 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8728 * xfaces.c (Fx_load_color_file):
8729 Read color file from absolute filename (bug#8250).
8731 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8733 * makefile.w32-in: Update dependencies.
8735 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8737 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8739 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8741 Fix more problems found by GCC 4.5.2's static checks.
8743 * process.c (make_serial_process_unwind, send_process_trap):
8744 (sigchld_handler): Now static.
8746 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8747 That way, the code declares only the vars that it needs.
8748 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8749 * s/cygwin.h (PTY_ITERATION): Likewise.
8750 * s/darwin.h (PTY_ITERATION): Likewise.
8751 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8753 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8754 * process.c (allocate_pty): Don't declare stb unless it's needed.
8756 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8757 (CONSTANTLIM): Remove; unused.
8758 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8759 Define only if needed.
8761 * unexelf.c (unexec): Name an expression,
8762 to avoid gcc -Wbad-function-cast warning.
8763 Use a different way to cause a compilation error if anyone uses
8764 n rather than nn, a way that does not involve shadowing.
8765 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8767 * deps.mk (unexalpha.o): Remove; unused.
8769 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8770 * unexec.h: New file.
8771 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8772 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8774 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8775 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8776 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8777 Change as necessary to match prototype in unexec.h.
8779 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8781 (back_comment, skip_chars): Mark vars as initialized.
8783 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8784 Rename locals to avoid shadowing.
8786 * lread.c (read1): Rewrite so as not to use empty "else".
8787 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8789 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8791 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8792 warning when compiling print.c.
8794 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8795 instead of using an uninitialized var.
8796 (font_sort_entities): Mark var as initialized.
8798 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8800 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8801 pointers to constants.
8802 (font_parse_fcname): Remove unused vars.
8803 (font_delete_unmatched): Now static.
8804 (font_get_spec): Remove; unused.
8805 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8806 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8807 Rename or move locals to avoid shadowing.
8809 * fns.c (require_nesting_list, require_unwind): Now static.
8810 (Ffillarray): Rename locals to avoid shadowing.
8812 * floatfns.c (domain_error2): Define only if needed.
8813 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8815 * alloc.c (mark_backtrace): Move decl from here ...
8816 * lisp.h: ... to here, so that it can be checked.
8818 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8819 (Fdefvar): Rewrite so as not to use empty "else".
8820 (lisp_indirect_variable): Name an expression,
8821 to avoid gcc -Wbad-function-cast warning.
8822 (Fdefvar): Rename locals to avoid shadowing.
8824 * callint.c (quotify_arg, quotify_args): Now static.
8825 (Fcall_interactively): Rename locals to avoid shadowing.
8826 Use const pointer when appropriate.
8828 * lisp.h (get_system_name, get_operating_system_release):
8829 Move decls here, to check interfaces.
8830 * process.c (get_operating_system_release): Move decl to lisp.h.
8831 * xrdb.c (get_system_name): Likewise.
8832 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8833 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8834 some of which prompt warnings from gcc -Wbad-function-cast.
8835 (Fformat_time_string, Fencode_time, Finsert_char):
8836 (Ftranslate_region_internal, Fformat):
8837 Rename or remove local vars to avoid shadowing.
8838 (Ftranslate_region_internal): Mark var as initialized.
8840 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8843 * lisp.h (eassert): Check that the argument compiles, even if
8844 ENABLE_CHECKING is not defined.
8846 * data.c (Findirect_variable): Name an expression, to avoid
8847 gcc -Wbad-function-cast warning.
8848 (default_value, arithcompare, arith_driver, arith_error): Now static.
8849 (store_symval_forwarding): Rename local to avoid shadowing.
8850 (Fmake_variable_buffer_local, Fmake_local_variable):
8851 Mark variables as initialized.
8852 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8854 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8855 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8856 Rename locals to avoid shadowing.
8857 (mark_stack): Move local variables into the #ifdef region where
8859 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8860 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8862 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8863 (GC_STRING_CHARS): Remove; not used.
8864 (Fmemory_limit): Cast sbrk's returned value to char *.
8866 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8867 avoids undefined behavior in theory.
8869 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8871 Use functions, not macros, for up- and down-casing (Bug#8254).
8872 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8873 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8874 to use the following functions instead of these macros.
8875 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8876 EMACS_INT, since callers assume the returned value fits in int.
8877 (upcase1): Likewise, for UPCASE_TABLE.
8878 (uppercasep, lowercasep, upcase): New static inline functions.
8879 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8880 the race-condition problem in the old DOWNCASE.
8882 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8883 Rename locals to avoid shadowing.
8884 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8885 (regex_compile, re_search_2, re_match_2_internal):
8886 Remove unused local vars.
8887 (FREE_VAR): Rewrite so as not to use empty "else",
8888 which gcc can warn about.
8889 (regex_compile, re_match_2_internal): Mark locals as initialized.
8890 (RETALLOC_IF): Define only if needed.
8891 (WORDCHAR_P): Likewise. This one is never needed, but is used
8892 only in a comment talking about a compiler bug, so put inside
8893 the #if 0 of that comment.
8894 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8895 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8898 * search.c (boyer_moore): Rename locals to avoid shadowing.
8899 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8900 (PREV_CHAR_BOUNDARY): Likewise.
8902 * search.c (simple_search): Remove unused var.
8904 * dired.c (compile_pattern): Move decl from here ...
8905 * lisp.h: ... to here, so that it can be checked.
8906 (struct re_registers): New forward decl.
8908 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8910 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8912 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8913 Rename locals to avoid shadowing.
8914 (Fvertical_motion): Mark locals as initialized.
8916 * casefiddle.c (casify_object, casify_region): Now static.
8917 (casify_region): Mark local as initialized.
8919 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8921 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8922 New macros, so that the caller can use some names other than
8923 gcpro1, gcpro2, etc.
8924 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8926 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8927 argument, for consistency with GCPRO2_VAR, etc: it is now the
8928 prefix of the variable, not the variable itself. All uses
8930 * dired.c (directory_files_internal, file_name_completion):
8931 Rename locals to avoid shadowing.
8933 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8934 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8935 dired.c's scmp function, had undefined behavior.
8936 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8937 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8938 * buffer.h: ... to here, because these macros use current_buffer,
8939 and the new implementation with inline functions needs to have
8940 current_buffer in scope now, rather than later when the macros
8942 (downcase, upcase1): New static inline functions.
8943 (DOWNCASE, UPCASE1): Reimplement using these functions.
8944 This avoids undefined behavior in expressions like
8945 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8946 from race conditions in accessing the global variables
8947 case_temp1 and case_temp2.
8948 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8949 * lisp.h (case_temp1, case_temp2): Remove their decls.
8950 * character.h (ASCII_CHAR_P): Move from here ...
8951 * lisp.h: ... to here, so that the inline functions mentioned
8954 * dired.c (directory_files_internal_unwind): Now static.
8956 * fileio.c (file_name_as_directory, directory_file_name):
8957 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8959 (file_name_as_directory): Use const pointers when appropriate.
8960 (Fexpand_file_name): Likewise. In particular, newdir might
8961 point at constant storage, so make it a const pointer.
8962 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8963 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8965 (Fset_file_times, Finsert_file_contents, auto_save_error):
8966 Rename locals to avoid shadowing.
8968 * minibuf.c (choose_minibuf_frame_1): Now static.
8969 (Ftry_completion, Fall_completions): Rename or remove locals
8972 * marker.c (bytepos_to_charpos): Remove; unused.
8974 * lisp.h (verify_bytepos, count_markers): New decls,
8975 so that gcc does not warn that these functions aren't declared.
8977 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8978 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8979 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8980 (copy_text): Remove unused local var.
8982 * filelock.c (within_one_second): Now static.
8983 (lock_file_1): Rename local to avoid shadowing.
8985 * buffer.c (fix_overlays_before): Mark locals as initialized.
8986 (fix_start_end_in_overlays): Likewise. This function should be
8987 simplified by using pointers-to-pointers, but that's a different
8989 (switch_to_buffer_1): Now static.
8990 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8991 (report_overlay_modification): Rename locals to avoid shadowing.
8993 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8994 Fix pointer signedness issue.
8995 (sys_subshell): Mark local as volatile if checking for lint,
8996 to suppress a gcc -Wclobbered warning that does not seem to be right.
8997 (MAXPATHLEN): Define only if needed.
8999 * process.c (serial_open, serial_configure): Move decls from here ...
9000 * systty.h: ... to here, so that they can be checked.
9002 * fns.c (get_random, seed_random): Move extern decls from here ...
9003 * lisp.h: ... to here, so that they can be checked.
9005 * sysdep.c (reset_io): Now static.
9006 (wait_for_termination_signal): Remove; unused.
9008 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9009 (copy_keymap_item, append_key, push_text_char_description):
9011 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9012 (DENSE_TABLE_SIZE): Remove; unused.
9013 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9014 (describe_map_tree):
9015 Rename locals to avoid shadowing.
9017 * keyboard.c: Declare functions static if they are not used elsewhere.
9018 (echo_char, echo_dash, cmd_error, top_level_2):
9019 (poll_for_input, handle_async_input): Now static.
9020 (read_char, kbd_buffer_get_event, make_lispy_position):
9021 (make_lispy_event, make_lispy_movement, apply_modifiers):
9022 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9023 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9024 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9025 (read_key_sequence, read_char): Mark locals as initialized.
9026 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9028 * keyboard.h (make_ctrl_char): New decl.
9029 (mark_kboards): Move decl here ...
9030 * alloc.c (mark_kboards): ... from here.
9032 * lisp.h (force_auto_save_soon): New decl.
9034 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9035 (DEFINE_DUMMY_FUNCTION): New macro.
9036 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9038 (main): Add casts to avoid warnings
9039 if GCC considers string literals to be constants.
9041 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9043 * dbusbind.c: Pointer signedness fixes.
9044 (xd_signature, xd_append_arg, xd_initialize):
9045 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9046 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9047 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9048 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9050 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9051 if GCC considers string literals to be constants.
9052 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9054 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9056 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9057 (print_preprocess, print_object): New macro to fix last change.
9059 * print.c (print_preprocess): Don't forget font objects.
9061 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9063 * emacs.c (USAGE3): Doc fixes.
9065 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9067 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9070 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9072 * lisp.h (VWindow_system, Qfile_name_history):
9073 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9074 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9075 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9077 * w32select.c: Don't #include "keyboard.h".
9078 (run_protected): Add extern declaration for waiting_for_input.
9080 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9081 * w32console.c (detect_input_pending, read_input_pending)
9082 (encode_terminal_code):
9083 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9084 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9085 (w32_system_caret_y, Qfile_name_history):
9086 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9087 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9088 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9089 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9090 * w32proc.c (Qlocal, report_file_error):
9091 * w32term.c (Vwindow_system, updating_frame):
9092 * w32uniscribe.c (initialized, uniscribe_font_driver):
9093 Remove unneeded extern declarations.
9095 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9097 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9099 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9101 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9102 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9103 These macros can no longer be used for assignment.
9105 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9106 Assign struct members directly, instead of using BUF_BEGV etc.
9107 (record_buffer_markers, fetch_buffer_markers): New functions for
9108 recording and fetching special buffer markers.
9109 (set_buffer_internal_1, set_buffer_temp): Use them.
9111 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9113 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9115 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9116 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9118 * xdisp.c (hscroll_window_tree):
9119 (reconsider_clip_changes): Use PT instead of BUF_PT.
9121 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9123 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9124 $(EMACS_ROOT)/lib/intprops.h.
9126 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9128 Fix more problems found by GCC 4.5.2's static checks.
9130 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9131 to unsigned char * to avoid compiler diagnostic.
9132 (xg_free_frame_widgets): Make it clear that a local variable is
9133 needed only if USE_GTK_TOOLTIP.
9134 (gdk_window_get_screen): Make it clear that this macro is needed
9135 only if USE_GTK_TOOLTIP.
9136 (int_gtk_range_get_value): New function, which avoids a diagnostic
9137 from gcc -Wbad-function-cast.
9138 (xg_set_toolkit_scroll_bar_thumb): Use it.
9139 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9140 diagnostic from gcc -Wbad-function-cast.
9141 (get_utf8_string, xg_get_file_with_chooser):
9142 Rename locals to avoid shadowing.
9143 (create_dialog): Move locals to avoid shadowing.
9145 * xgselect.c (xg_select): Remove unused var.
9147 * image.c (four_corners_best): Mark locals as initialized.
9148 (gif_load): Initialize transparent_p to zero (Bug#8238).
9149 Mark another local as initialized.
9150 (my_png_error, my_error_exit): Mark with NO_RETURN.
9152 * image.c (clear_image_cache): Now static.
9153 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9154 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9155 (x_edge_detection): Remove unnecessary cast that
9156 gcc -Wbad-function-cast diagnoses.
9157 (gif_load): Fix pointer signedness.
9158 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9159 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9161 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9163 Improve quality of tests for time stamp overflow.
9164 For example, without this patch (encode-time 0 0 0 1 1
9165 1152921504606846976) returns the obviously-bogus value (-948597
9166 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9167 reports time overflow. See
9168 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9169 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9170 * editfns.c: Include limits.h and intprops.h.
9171 (TIME_T_MIN, TIME_T_MAX): New macros.
9172 (time_overflow): Move earlier, to before first use.
9173 (hi_time, lo_time): New functions, for an accurate test for
9175 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9176 (Fget_internal_run_time): Don't assume time_t fits in int.
9177 (make_time): Use list2 instead of Fcons twice.
9178 (Fdecode_time): More accurate test for out-of-range times.
9179 (check_tm_member): New function.
9180 (Fencode_time): Use it, to test for out-of-range times.
9181 (lisp_time_argument): Don't rely on undefined left-shift and
9182 right-shift behavior when checking for time stamp overflow.
9184 * editfns.c (time_overflow): New function, refactoring common code.
9185 (Fformat_time_string, Fdecode_time, Fencode_time):
9186 (Fcurrent_time_string): Use it.
9188 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9189 * dired.c (make_time): Move to ...
9190 * editfns.c (make_time): ... here.
9191 * systime.h: Note the move.
9193 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9195 * fringe.c (update_window_fringes): Remove unused variables.
9197 * unexmacosx.c (copy_data_segment): Also copy __got section.
9200 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9202 * termcap.c [MSDOS]: Include "msdos.h".
9203 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9204 Constify `char *' arguments and their references according to
9205 prototypes in tparam.h.
9207 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9209 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9210 Adapt all references accordingly.
9212 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9214 2011-03-11 Tom Tromey <tromey@redhat.com>
9216 * buffer.c (syms_of_buffer): Remove obsolete comment.
9218 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9220 * termhooks.h (encode_terminal_code): Declare prototype.
9222 * msdos.c (encode_terminal_code): Don't declare prototype.
9224 * term.c (encode_terminal_code): Now external again, used by
9225 w32console.c and msdos.c.
9227 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9228 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9230 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9232 Fix some minor problems found by GCC 4.5.2's static checks.
9234 * fringe.c (update_window_fringes): Mark locals as initialized
9236 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9238 * alloc.c (mark_fringe_data): Move decl from here ...
9239 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9240 to check its interface.
9241 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9243 * fontset.c (free_realized_fontset): Now static.
9244 (Fset_fontset_font): Rename local to avoid shadowing.
9245 (fontset_font): Mark local as initialized.
9246 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9248 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9250 * xselect.c (x_disown_buffer_selections): Remove; not used.
9251 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9252 (x_own_selection, Fx_disown_selection_internal): Rename locals
9254 (x_handle_dnd_message): Remove local to avoid shadowing.
9256 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9257 so that the caller can use some name other than gcpro1.
9258 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9259 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9260 (Fx_backspace_delete_keys_p):
9261 Use them to avoid shadowing, and rename vars to avoid shadowing.
9262 (x_decode_color, x_set_name, x_window): Now static.
9263 (Fx_create_frame): Add braces to silence GCC warning.
9264 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9265 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9266 Remove unused locals.
9267 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9268 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9269 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9272 * xterm.h (x_mouse_leave): New decl.
9274 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9275 Remove unused functions.
9276 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9277 (x_calc_absolute_position): Now static.
9278 (XTread_socket): Don't define label "out" unless it's used.
9279 Don't declare local "event" unless it's used.
9280 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9281 unless they are used.
9282 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9283 (x_fatal_error_signal): Remove; not used.
9284 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9285 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9286 (x_error_catcher, x_connection_closed, x_error_handler):
9287 (x_error_quitter, xembed_send_message, x_iconify_frame):
9288 (my_log_handler): Rename locals to avoid shadowing.
9289 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9290 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9292 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9293 Rename or move locals to avoid shadowing.
9294 (tty_defined_color, merge_face_heights): Now static.
9295 (free_realized_faces_for_fontset): Remove; not used.
9296 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9297 does not deduce is never used uninitialized.
9298 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9299 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9301 * terminal.c (store_terminal_param): Now static.
9303 * xmenu.c (menu_highlight_callback): Now static.
9304 (set_frame_menubar): Remove unused local.
9305 (xmenu_show): Rename parameter to avoid shadowing.
9306 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9307 since they might point to immutable storage.
9308 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9309 since it's unused otherwise.
9311 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9312 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9313 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9314 avoids a gcc -Wuninitialized diagnostic.
9315 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9316 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9317 does not deduce are never used uninitialized.
9319 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9321 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9322 * window.c (window_loop, size_window):
9323 (run_window_configuration_change_hook, enlarge_window): Likewise.
9325 * window.c (display_buffer): Now static.
9326 (size_window): Mark variables that gcc -Wuninitialized
9327 does not deduce are never used uninitialized.
9328 * window.h (check_all_windows): New decl, to forestall
9329 gcc -Wmissing-prototypes diagnostic.
9330 * dispextern.h (bidi_dump_cached_states): Likewise.
9332 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9334 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9336 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9337 and to avoid gcc -Wuninitialized warning.
9338 (load_charset_map): Mark variables that gcc -Wuninitialized
9339 does not deduce are never used uninitialized.
9340 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9342 * coding.c (coding_set_source, coding_set_destination):
9343 Use "else { /* comment */ }" rather than "else /* comment */;"
9344 for clarity, and to avoid gcc -Wempty-body warning.
9345 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9346 a block, when the outer 'i' will do.
9347 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9348 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9349 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9350 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9351 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9352 Rename locals to avoid shadowing.
9353 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9354 * coding.c (emacs_mule_char, encode_invocation_designation):
9355 Now static, since they're not used elsewhere.
9356 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9357 (decode_coding_object, encode_coding_object, detect_coding_system):
9358 (decode_coding_emacs_mule): Mark variables that gcc
9359 -Wuninitialized does not deduce are never used uninitialized.
9360 (detect_coding_iso_2022): Initialize a local variable that might
9361 be used uninitialized. Leave a FIXME because it's not clear that
9362 this initialization is needed. (Bug#8211)
9363 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9364 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9365 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9366 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9367 Remove unused macros.
9369 * category.c (hash_get_category_set): Remove unused local var.
9370 (copy_category_table): Now static, since it's not used elsewhere.
9371 * character.c (string_count_byte8): Likewise.
9373 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9374 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9376 * chartab.c (copy_sub_char_table): Now static, since it's not used
9378 (sub_char_table_ref_and_range, char_table_ref_and_range):
9379 Rename locals to avoid shadowing.
9380 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9382 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9383 (BIDI_BOB): Remove unused macro.
9385 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9386 deduce are never used uninitialized.
9387 * term.c (encode_terminal_code): Likewise.
9389 * term.c (encode_terminal_code): Now static. Remove unused local.
9391 * tparam.h: New file.
9392 * term.c, tparam.h: Include it.
9393 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9394 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9395 Move these decls to tparam.h, and make them agree with what
9396 is actually in tparam.c. The previous trick of using incompatible
9397 decls in different modules does not conform to the C standard.
9398 All callers of tparam changed to use tparam's actual API.
9399 * tparam.c (tparam1, tparam, tgoto):
9400 Use const pointers where appropriate.
9402 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9403 * cm.h (struct cm): Likewise.
9404 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9405 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9406 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9407 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9408 (turn_on_face, init_tty): Likewise.
9409 * termchar.h (struct tty_display_info): Likewise.
9411 * term.c (term_mouse_position): Rename local to avoid shadowing.
9413 * alloc.c (mark_ttys): Move decl from here ...
9414 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9416 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9418 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9420 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9422 * search.c (compile_pattern_1): Remove argument regp, unused since
9423 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9424 (compile_pattern): Don't pass it.
9426 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9428 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9429 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9431 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9433 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9435 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9436 gdk_window_get_screen, gdk_window_get_geometry,
9437 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9438 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9439 (xg_get_pixbuf_from_pixmap): New function.
9440 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9441 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9442 Call xg_get_pixbuf_from_pixmap instead of
9443 gdk_pixbuf_get_from_drawable.
9444 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9445 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9446 (xg_check_special_colors): Use GtkStyleContext and its functions
9448 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9449 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9450 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9451 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9452 Call gtk_widget_get_preferred_size.
9453 (xg_frame_resized): gdk_window_get_geometry only takes 5
9455 (xg_win_to_widget, xg_event_is_for_menubar):
9456 Call gdk_x11_window_lookup_for_display.
9457 (xg_set_widget_bg): New function.
9458 (delete_cb): New function.
9459 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9460 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9461 (xg_set_background_color): Call xg_set_widget_bg.
9462 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9463 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9464 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9465 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9467 (update_frame_tool_bar): Call gtk_widget_hide.
9468 (xg_initialize): Use GDK_KEY_g.
9470 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9472 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9474 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9475 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9476 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9478 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9480 * w32xfns.c (select_palette): Check success of RealizePalette against
9481 GDI_ERROR, not zero.
9483 See ChangeLog.11 for earlier changes.
9489 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9491 This file is part of GNU Emacs.
9493 GNU Emacs is free software: you can redistribute it and/or modify
9494 it under the terms of the GNU General Public License as published by
9495 the Free Software Foundation, either version 3 of the License, or
9496 (at your option) any later version.
9498 GNU Emacs is distributed in the hope that it will be useful,
9499 but WITHOUT ANY WARRANTY; without even the implied warranty of
9500 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9501 GNU General Public License for more details.
9503 You should have received a copy of the GNU General Public License
9504 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.