1 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3 * alloc.c: Remove build_string.
4 * lisp.h: Define build_string as static inline. This provides
5 a better opportunity to optimize away calls to strlen when the
6 function is called with compile-time constant argument.
7 * image.c (imagemagick_error): Convert to build_string.
8 * w32proc.c (sys_spawnve): Likewise.
9 * xterm.c (x_term_init): Likewise.
11 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
13 Use sprintf return value instead of invoking strlen on result.
14 In the old days this wasn't portable, since some sprintf
15 implementations returned char *. But they died out years ago and
16 Emacs already assumes sprintf returns int.
17 Similarly for float_to_string.
18 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
20 * character.c (string_escape_byte8):
21 * data.c (Fnumber_to_string):
23 * print.c (print_object):
24 * xdisp.c (message_dolog):
25 * xfns.c (syms_of_xfns):
26 Use sprintf or float_to_string result to avoid need to call strlen.
27 * data.c (Fnumber_to_string):
28 Use make_unibyte_string, since the string must be ASCII.
29 * lisp.h, print.c (float_to_string): Now returns int length.
30 * term.c (produce_glyphless_glyph):
31 Use sprintf result rather than recomputing it.
33 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
34 * Makefile.in (ALL_CFLAGS):
35 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
36 * gmalloc.c, regex.c: Include <config.h> unconditionally.
38 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
40 * dispextern.h (xstrcasecmp): Define to library function
41 strcasecmp if available.
42 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
44 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
46 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
48 * menu.c (push_submenu_start, push_submenu_end)
49 (push_left_right_boundary, push_menu_pane): Likewise.
50 * msdos.c (dos_rawgetc): Likewise.
52 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
54 * xfns.c (xic_create_fontsetname): Remove redundant calls
57 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
59 * gtkutil.c (get_utf8_string): Remove redundant assignment.
60 sprintf already null-terminates its output.
62 * xfns.c (x_window): Remove redundant cast.
64 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
66 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
67 `const char *' to `char *' to avoid compiler warning.
69 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
71 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
72 instead of truncating it to 63 (admittedly a generous limit).
74 * process.c: Fix spelling and caps in comments.
76 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
78 * emacs.c (setpgrp): Remove definition, unused.
79 * sysdep.c (setpgrp): Remove definition, not used in this file.
81 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
83 * makefile.w32-in: Update dependencies.
85 2012-06-24 Eli Zaretskii <eliz@gnu.org>
87 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
88 (SYSTIME_H): Add nt/inc/sys/time.h.
90 * systime.h [WINDOWSNT]: Include sys/time.h.
92 * s/ms-w32.h (struct timespec): Definition moved from
93 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
95 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
97 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
98 * buffer.h (buffer_slot_type_mismatch):
99 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
100 * eval.c (unwind_to_catch):
101 * image.c (my_png_error, my_error_exit):
102 * keyboard.c (quit_throw_to_read_char, user_error)
103 (Fexit_recursive_edit, Fabort_recursive_edit):
104 * lisp.h (die, args_out_of_range, args_out_of_range_3)
105 (wrong_type_argument, buffer_overflow, __executable_start)
106 (memory_full, buffer_memory_full, string_overflow, Fthrow)
107 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
108 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
110 (child_setup) [!DOS_NT]:
111 * lread.c (end_of_file_error, invalid_syntax):
112 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
113 * puresize.h (pure_write_error):
114 * search.c (matcher_overflow):
115 * sound.c (sound_perror, alsa_sound_perror):
116 * sysdep.c, syssignal.h (croak):
117 * term.c (maybe_fatal, vfatal):
118 * textprop.c (text_read_only):
119 * undo.c (user_error):
120 * unexmacosx.c (unexec_error):
121 * xterm.c (x_ins_del_lines, x_delete_glyphs):
122 Use _Noreturn rather than NO_RETURN.
123 No need for separate decl merely because of _Noreturn.
124 * sound.c (sound_warning, parse_sound):
125 Remove unnecessary forward decls.
127 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
129 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
130 * lisp.h (WAIT_READING_MAX): New macro.
131 * dispnew.c (Fsleep_for, sit_for):
132 * keyboard.c (kbd_buffer_get_event):
133 * process.c (Faccept_process_output):
134 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
135 This improves on the previous patch, which introduced a bug
136 when time_t is unsigned and as wide as intmax_t.
137 See <http://bugs.gnu.org/9000#51>.
139 2012-06-23 Eli Zaretskii <eliz@gnu.org>
141 * dispnew.c (sit_for, Fsleep_for):
142 * keyboard.c (kbd_buffer_get_event):
143 * process.c (Faccept_process_output): Avoid compiler warnings when
144 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
146 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
148 * makefile.w32-in: Update dependencies.
150 * w32.c (ltime): Add return type and declare static.
151 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
153 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
155 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
156 Privately reported by Herbert J. Skuhra.
157 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
159 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
160 not make_lisp_timeval, when the argument is of type EMACS_TIME.
162 2012-06-23 Eli Zaretskii <eliz@gnu.org>
164 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
165 last argument of make_unibyte_string.
167 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
168 language ID in the event parameters.
170 * w32term.c (w32_read_socket): Put the new keyboard codepage into
171 event.code, not the obscure "character set ID".
173 2012-06-23 Chong Yidong <cyd@gnu.org>
175 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
177 2012-06-23 Eli Zaretskii <eliz@gnu.org>
179 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
180 * w32.c (fdutimens): New function.
182 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
184 * s/ms-w32.h (pselect): Redirect to sys_select.
186 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
188 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
189 in the logic of incrementing and decrementing the value of
190 use_relocatable_buffers.
192 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
194 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
195 Privately reported by Herbert J. Skuhra.
196 [__FreeBSD__]: Remove "*/" typo after "#include".
197 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
198 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
199 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
200 Don't assume EMACS_TIME and struct timeval are the same type.
202 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
204 Support higher-resolution time stamps (Bug#9000).
205 The time stamps are only nanosecond-resolution at the C level,
206 since that's the best that any real-world system supports now.
207 But they are picosecond-resolution at the Lisp level, as that's
208 easy, and leaves room for future OS improvements.
210 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
213 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
214 Don't get current time unless it's needed.
216 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
217 now provides it if it's absent.
218 (start_atimer): Port to higher-res time stamps.
219 Check for time stamp overflow. Don't get current time more
220 often than is needed.
222 * buffer.h (struct buffer): Buffer modtime now has high resolution.
223 Include systime.h, not time.h.
224 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
226 * dired.c: Include stat-time.h.
227 (Ffile-attributes): File times now have higher resolution.
229 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
230 (struct image): Timestamp now has higher resolution.
232 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
233 has at least microseconds now. All uses removed.
234 (update_frame, update_single_window, update_window, update_frame_1)
235 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
237 * editfns.c (time_overflow): Now extern.
238 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
239 (float-time, Fformat_time_string, Fcurrent_time_string)
240 (Fcurrent_time_zone): Accept and generate higher-resolution
242 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
243 (decode_time_components, lisp_seconds_argument): New functions.
244 (make_time): Now static.
245 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
246 Report an error if the time is invalid, rather than having the caller
249 * fileio.c: Include <stat-time.h>
250 (Fcopy_file): Copy higher-resolution time stamps.
251 Prefer to set the time stamp via a file descriptor if that works.
252 (Fset_file_times, Finsert_file_contents, Fwrite_region)
253 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
254 (Fvisited_file_modtime, Fset_visited_file_modtime):
255 Support higher-resolution time stamps.
257 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
259 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
261 * image.c (prepare_image_for_display, clear_image_cache)
262 (lookup_image): Port to higer-resolution time stamps.
264 * keyboard.c (start_polling, bind_polling_period):
265 Check for time stamp overflow.
266 (read_char, kbd_buffer_get_event, timer_start_idle)
267 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
268 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
269 Port to higher-resolution time stamps. Do not assume time_t is signed.
270 (decode_timer): New function. Timers are now vectors of length 9,
271 not 8, to accommodate the picosecond component.
272 (timer_check_2): Use it.
274 * nsterm.m (select_timeout, timeval_subtract): Remove.
275 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
276 as they're a bit more accurate and handle overflow better.
277 (ns_select): Change prototype to be compatible with pselect.
278 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
279 * nsterm.h (ns_select): Adjust prototype.
281 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
282 us-resolution time stamps.
283 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
285 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
287 * lisp.h (time_overflow): New decl.
288 (wait_reading_process_output): First arg is now intmax_t, not int,
289 to accommodate larger waits.
291 * process.h (struct Lisp_Process.read_output_delay):
292 Now counts nanoseconds, not microseconds.
293 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
295 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
296 (wait_reading_process_output):
297 Port to ns-resolution time stamps.
298 (Faccept_process_output, wait_reading_process_output):
299 Check for time stamp overflow. Do not assume time_t is signed.
300 (select_wrapper): Remove; we now use pselect.
301 (Fprocess_attributes): Now generates ns-resolution time stamps.
303 * sysdep.c: Include utimens.h. Don't include utime.h
304 or worry about struct utimbuf; gnulib does that for us now.
305 (gettimeofday): Remove; gnulib provides a substitute.
306 (make_timeval): New function.
307 (set_file_times): Now sets ns-resolution time stamps.
308 New arg FD; all uses changed.
309 (time_from_jiffies, ltime_from_jiffies, get_up_time)
310 (system_process_attributes):
311 Now returns ns-resolution time stamp. All uses changed.
312 Check for time stamp overflow.
314 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
315 provides a substitute now.
317 * systime.h: Include timespec.h rather than sys/time.h and time.h,
318 since it guarantees struct timespec.
319 (EMACS_TIME): Now struct timespec, so that we can support
320 ns-resolution time stamps.
321 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
322 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
323 (EMACS_USECS): Remove.
324 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
325 so multiply the arg by 1000 before storing it.
326 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
328 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
329 Port to ns-resolution time stamps.
330 (EMACS_TIME_NEG_P): Remove; replaced by....
331 (EMACS_TIME_SIGN): New macro.
332 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
333 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
334 (set_file_times, make_time, lisp_time_argument): Adjust signature.
335 (make_timeval, make_lisp_time, decode_time_components): New decls.
336 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
337 that it mishandled time_t overflow. You can't compare by subtracting!
338 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
339 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
341 * term.c: Include <sys/time.h>.
342 (timeval_to_Time): New function, for proper overflow wraparound.
343 (term_mouse_position, term_mouse_click): Use it.
345 * undo.c (record_first_change): Support higher-resolution time stamps
347 (Fprimitive_undo): Use them when restoring time stamps.
349 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
350 (w32_get_internal_run_time):
351 Port to higher-resolution Emacs time stamps.
352 (ltime): Now accepts single 64-bit integer, as that's more convenient
355 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
357 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
358 for compatibility with pselect. Support ns-resolution time stamps.
360 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
362 * xselect.c (wait_for_property_change, x_get_foreign_selection):
363 Check for time stamp overflow, and support ns-resolution time stamps.
365 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
366 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
367 (timeval_subtract): Remove; no longer needed.
368 (XTflash, XTring_bell, x_wait_for_event):
369 Port to ns-resolution time stamps. Don't assume time_t is signed.
371 2012-06-22 Chong Yidong <cyd@gnu.org>
373 * xdisp.c (x_consider_frame_title): Revert last change.
375 2012-06-22 Eli Zaretskii <eliz@gnu.org>
377 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
378 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
379 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
380 staticidx goes up to 1597 out of 1600 = 0x640.)
382 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
384 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
385 Otherwise, the umask might be mistakenly 0 while handling input signals.
387 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
389 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
391 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
393 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
394 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
395 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
396 access to `contents' member of Lisp_Vector objects with AREF and ASET
399 2012-06-19 Chong Yidong <cyd@gnu.org>
401 * frame.c (delete_frame): When selecting a frame on a different
402 text terminal, do not alter the terminal's top-frame.
404 * xdisp.c (format_mode_line_unwind_data): Record the target
405 frame's selected window and its terminal's top-frame.
406 (unwind_format_mode_line): Restore them.
407 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
409 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
410 since tty frames can be explicitly named.
411 (prepare_menu_bars): Likewise.
413 * term.c (Ftty_top_frame): New function.
415 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
417 Port byte-code-meter to modern targets.
418 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
419 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
420 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
421 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
422 (METER_1, METER_2): Simplify.
424 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
426 * data.c (Fdefalias): Return `symbol' (bug#11686).
428 2012-06-18 Martin Rudalics <rudalics@gmx.at>
430 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
431 gets killed during executing of this function (Bug#11665).
432 Try to always return Qt when the buffer has been actually killed.
433 (Vkill_buffer_query_functions): In doc-string say that functions
434 run by this hook should not change the current buffer.
436 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
438 Fix recently-introduced process.c problems found by static checking.
439 * process.c (write_queue_push, write_queue_pop, send_process):
440 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
441 (write_queue_pop): Fix pointer signedness problem.
442 (send_process): Remove unused local.
444 2012-06-17 Chong Yidong <cyd@gnu.org>
446 * xdisp.c (redisplay_internal): No need to redisplay terminal
447 frames that are not on top.
449 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
451 * process.c (make_process): Initialize write_queue.
452 (write_queue_push, write_queue_pop): New functions.
453 (send_process): Use them to maintain correct ordering of process
456 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
458 * lisp.h (eassert): Assume C89 or later.
459 This removes the need for CHECK.
460 (CHECK): Remove. Its comments about always evaluating its
461 argument were confusing, as 'eassert' typically does not evaluate
464 * coding.c (produce_chars): Use ptrdiff_t, not int.
466 * xterm.c (x_draw_underwave): Check for integer overflow.
467 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
469 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
471 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
472 referenced (Bug#11583).
474 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
476 Implement wave-style variant of underlining.
477 * dispextern.h (face_underline_type): New enum.
478 (face): Add field for underline type.
479 * nsterm.m (ns_draw_underwave): New function.
480 (ns_draw_text_decoration): Use it.
481 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
483 (x_draw_glyph_string): Use them.
484 * xfaces.c (Qline, Qwave): New Lisp objects.
485 (check_lface_attrs, merge_face_ref)
486 (Finternal_set_lisp_face_attribute, realize_x_face):
487 Handle wave-style underline face attributes.
488 * xterm.c (x_draw_underwave): New function.
489 (x_draw_glyph_string): Use it.
491 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
493 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
494 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
495 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
496 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
497 ($(BLD)/w32select.$(O)): Update dependencies.
499 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
501 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
502 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
503 * character.c (_fetch_multibyte_char_p): Remove.
504 * alloc.c: Include "character.h" before "buffer.h".
506 * buffer.c: Likewise.
507 * bytecode.c: Likewise.
508 * callint.c: Likewise.
509 * callproc.c: Likewise.
510 * casefiddle.c: Likewise.
511 * casetab.c: Likewise.
512 * category.c: Likewise.
514 * coding.c: Likewise.
515 * composite.c: Likewise.
517 * dispnew.c: Likewise.
519 * dosfns.c: Likewise.
520 * editfns.c: Likewise.
522 * fileio.c: Likewise.
523 * filelock.c: Likewise.
525 * fontset.c: Likewise.
526 * fringe.c: Likewise.
527 * indent.c: Likewise.
528 * insdel.c: Likewise.
529 * intervals.c: Likewise.
530 * keyboard.c: Likewise.
531 * keymap.c: Likewise.
533 * macros.c: Likewise.
534 * marker.c: Likewise.
535 * minibuf.c: Likewise.
537 * nsmenu.m: Likewise.
539 * process.c: Likewise.
541 * region-cache.c: Likewise.
542 * search.c: Likewise.
543 * syntax.c: Likewise.
545 * textprop.c: Likewise.
547 * unexsol.c: Likewise.
548 * w16select.c: Likewise.
549 * w32fns.c: Likewise.
550 * w32menu.c: Likewise.
551 * window.c: Likewise.
556 * xselect.c: Likewise.
558 2012-06-16 Eli Zaretskii <eliz@gnu.org>
560 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
561 If all the glyphs of the glyph row came from strings, and we have no
562 cursor positioning clues, put the cursor on the first glyph of the
564 (handle_face_prop): Use chunk-relative overlay string index when
565 indexing into it->string_overlays array. (Bug#11653)
566 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
567 the rightmost. (Bug#11720)
569 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
571 * category.h (CHAR_HAS_CATEGORY): Define as inline.
572 (CATEGORY_MEMBER): Enforce 1/0 value.
573 * category.c (_temp_category_set): Remove.
575 2012-06-16 Eli Zaretskii <eliz@gnu.org>
577 * window.c (Fdelete_other_windows_internal)
578 (Fdelete_window_internal): Don't access frame's mouse highlight
579 info of the initial frame. (Bug#11677)
581 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
583 * .gdbinit (xgetint): Fix recently-introduced paren typo.
584 Assume USE_2_TAGS_FOR_INTS.
585 (xreload): Adjust $tagmask width to match recent lisp.h change.
587 Simplify lisp.h in minor ways that should not affect code.
588 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
589 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
590 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
591 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
592 (INTTYPEBITS): New macro, for clarity.
593 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
594 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
595 Simplify now that USE_LSB_TAG is always defined.
596 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
597 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
599 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
601 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
603 2012-06-13 Glenn Morris <rgm@gnu.org>
605 * s/bsd-common.h (BSD4_3):
606 * s/usg5-4-common.h (USG5_4): No longer define; unused.
608 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
610 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
613 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
615 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
616 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
617 * alloc.c (widen_to_Lisp_Object): Remove.
618 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
619 * frame.c (delete_frame): Remove outdated comment.
620 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
622 (Fw32_unregister_hot_key): Likewise.
623 (Fw32_toggle_lock_key): Likewise.
624 * w32menu.c (add_menu_item): Likewise.
625 (w32_menu_display_help): Use XIL instead of checking
627 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
628 (init_heap): Likewise.
629 * w32term.c (w32_read_socket): Update comment.
631 2012-06-13 Glenn Morris <rgm@gnu.org>
633 * s/usg5-4-common.h, src/s/unixware.h:
634 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
636 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
638 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
640 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
641 * alloc.c (make_number) [!defined make_number]:
642 Remove, as lisp.h always defines this now.
643 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
644 (roundup_size): Verify that it is a power of 2.
645 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
646 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
647 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
648 -DUSE_LSB_TAG=0, to override the automatically-selected default.
649 USE_LSB_TAG now is always defined to be either 0 or 1.
651 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
652 code works fine either way, and efficiency is not a concern here,
653 as the union type is for debugging, not for production.
654 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
655 Use an inline function on all platforms when using the union type,
656 since this is simpler and 'static inline' can be used portably
658 (LISP_INITIALLY_ZERO): New macro.
659 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
660 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
662 2012-06-12 Glenn Morris <rgm@gnu.org>
664 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
666 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
668 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
669 Move BROKEN_SIGIO to configure.
671 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
672 Move NO_TERMIO to configure.
674 2012-06-12 Chong Yidong <cyd@gnu.org>
676 * image.c (imagemagick_load_image): Use MagickFlattenImage if
677 MagickMergeImageLayers is undefined. Use pixel pusher loop if
678 MagickExportImagePixels is undefined.
680 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
682 * image.c (imagemagick_load_image): Remove unused label.
684 2012-06-11 Glenn Morris <rgm@gnu.org>
686 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
687 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
688 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
689 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
691 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
693 * alloc.c (make_byte_code): New function.
694 (Fmake_byte_code): Use it. Don't purify here.
695 * lread.c (read1): Use it as well to avoid extra allocation.
697 2012-06-11 Chong Yidong <cyd@gnu.org>
699 * image.c (imagemagick_load_image): Implement transparency.
701 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
703 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
704 account for preceding backslashes. (Bug#11663)
706 2012-06-09 Chong Yidong <cyd@gnu.org>
708 * term.c: Support italics in capable terminals (Bug#9652).
709 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
710 (turn_on_face): Output using TS_enter_italic_mode if available.
711 Don't handle unused blinking and alt-charset cases.
712 (turn_off_face): Handle italic case; discard unused tty_blinking_p
713 and tty_alt_charset_p cases.
714 (tty_capable_p, init_tty): Support italics.
716 * termchar.h (struct tty_display_info): Add field for italics.
717 Remove unused blink field.
719 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
722 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
723 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
724 tty_alt_charset_p. Add tty_italic_p.
726 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
728 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
729 dbus_type_is_basic if available.
730 (xd_extract_signed, xd_extract_unsigned): Rename from
731 extract_signed and extract_unsigned, respectively. Adapt callers.
733 2012-06-09 Chong Yidong <cyd@gnu.org>
735 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
737 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
740 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
742 * xdisp.c (vmessage): Treat frame message as multibyte.
743 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
744 would generate the diagnostic "Making \302\247 buffer-local while
747 2012-06-08 Eli Zaretskii <eliz@gnu.org>
749 * dispnew.c (showing_window_margins_p): Undo last change, which
750 was done due to an inadvertent commit.
751 (adjust_frame_glyphs_for_frame_redisplay): Do call
752 showing_window_margins_p.
754 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
756 * eval.c (Fmake_var_non_special): New primitive.
757 (syms_of_eval): Defsubr it.
758 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
760 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
762 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
763 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
765 2012-06-08 Eli Zaretskii <eliz@gnu.org>
767 * alloc.c (allocate_vectorlike): Fix last change.
769 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
771 Block-based vector allocation of small vectors.
772 * lisp.h (struct vectorlike_header): New field `nbytes',
773 adjust comment accordingly.
774 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
775 to denote vector blocks. Adjust users (live_vector_p,
776 mark_maybe_pointer, valid_lisp_object_p) accordingly.
777 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
778 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
779 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
780 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
781 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
782 (roundup_size): New constant.
783 (struct vector_block): New data type.
784 (vector_blocks, vector_free_lists, zero_vector): New variables.
785 (all_vectors): Rename to `large_vectors'.
786 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
787 (sweep_vectors): New functions.
788 (allocate_vectorlike): Return `zero_vector' as the only vector of
789 0 items. Allocate new vector from block if vector size is less than
790 or equal to VBLOCK_BYTES_MAX.
791 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
792 (init_alloc_once): Add call to init_vectors.
794 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
796 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
798 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
800 * doprnt.c (doprnt): Truncate multibyte char correctly.
801 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
802 would mishandle a string argument "Xc" if X was a multibyte
803 character of length 2: it would truncate after X's first byte
804 rather than including all of X.
806 2012-06-06 Chong Yidong <cyd@gnu.org>
808 * buffer.c (word_wrap): Doc fix.
810 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
812 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
814 2012-06-03 Glenn Morris <rgm@gnu.org>
816 * xdisp.c (tool-bar-style): Doc fix.
818 2012-06-03 Ulrich Müller <ulm@gentoo.org>
820 * Makefile.in (PAXCTL): Define.
821 (temacs$(EXEEXT)): Disable memory randomization for the temacs
822 binary via PaX flags if the paxctl utility is available.
823 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
824 Restore PaX flags to their default. (Bug#11398)
826 2012-06-03 Chong Yidong <cyd@gnu.org>
828 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
831 2012-06-03 Chong Yidong <cyd@gnu.org>
833 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
834 (note_mode_line_or_margin_highlight): If there is no help echo,
835 use mode-line-default-help-echo. Handle the case where the mouse
836 position is past the end of the mode line string.
838 * buffer.c (buffer_local_value_1): New function, split from
839 Fbuffer_local_value; can return Qunbound.
840 (Fbuffer_local_value): Use it.
841 (Vmode_line_format): Docstring tweaks.
843 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
845 * sysdep.c (system_process_attributes): Improve comment.
847 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
849 * keyboard.c: Export real-this-command to Elisp.
850 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
851 and DEFVAR it. Update all users.
853 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
855 * minibuf.c (Fassoc_string): Remove duplicate declaration.
857 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
858 Convert pctcpu and pctmem to Lisp float properly.
859 Let the compiler fold better, as 100.0/0x8000 is exact.
861 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
863 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
866 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
868 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
870 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
872 For a 'struct window', replace some Lisp_Object fields to
873 bitfields where appropriate, remove unused fields.
874 * window.h (struct window): Remove unused 'last_mark_x' and
875 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
876 change it's type from Lisp_Object to bitfield.
877 Change type of 'force_start', 'optional_new_start',
878 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
879 fields from Lisp_Object to bitfield. Adjust users accordingly.
881 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
883 Pacify gcc -Wdouble-precision when using Xaw.
884 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
885 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
886 Use 'float' consistently, rather than 'float' in most places
887 and 'double' in a couple of places.
889 2012-05-31 Eli Zaretskii <eliz@gnu.org>
891 * xdisp.c (handle_stop): Detect whether we have overlay strings
892 loaded by testing it->current.overlay_string_index to be
893 non-negative, instead of checking whether n_overlay_strings is
894 positive. (Bug#11587)
896 2012-05-31 Chong Yidong <cyd@gnu.org>
898 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
900 * doc.c (Fsubstitute_command_keys): Doc fix.
902 2012-05-31 Eli Zaretskii <eliz@gnu.org>
904 * search.c (search_buffer): Remove calls to
905 r_alloc_inhibit_buffer_relocation, as it is now called by
906 maybe_unify_char, which was the cause of relocation of buffer text
909 2012-05-31 Eli Zaretskii <eliz@gnu.org>
911 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
912 for the duration of call to load_charset, to avoid problems with
913 callers of maybe_unify_char that access buffer text through C
916 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
917 decrement the inhibition flag, instead of just setting or
920 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
922 Remove obsolete '#define static' cruft.
923 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
924 This #undef was "temporary" in 2000; it is no longer needed
925 now that '#define static' has gone away.
926 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
927 (gray_bitmap_bits): Remove; no longer needed.
928 All uses replaced with definiens.
929 * xterm.c: Include "bitmaps/gray.xbm".
931 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
933 Clean up __executable_start, monstartup when --enable-profiling.
934 The following changes affect the code only when profiling.
935 * dispnew.c (__executable_start): Rename from safe_bcopy.
936 Define only on platforms that need it.
937 * emacs.c: Include <sys/gmon.h> when profiling.
938 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
939 (__executable_start): Remove decl, since lisp.h does it now.
940 (safe_bcopy): Remove decl; no longer has that name.
941 (main): Coalesce #if into single bit of code, for simplicity.
942 Cast pointers to uintptr_t, since standard libraries want integers
944 * lisp.h (__executable_start): New decl.
946 2012-05-31 Glenn Morris <rgm@gnu.org>
948 * image.c (Fimagemagick_types): Doc fix.
950 2012-05-30 Jim Meyering <meyering@redhat.com>
952 * callproc.c (Fcall_process_region): Include directory component
953 in mkstemp error message (Bug#11586).
955 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
957 * alloc.c, lisp.h (make_pure_vector): Now static.
959 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
961 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
963 (Fautoload): Do the hash-doc more carefully.
964 * data.c (Fdefalias): Purify definition, except for keymaps.
965 (Qdefun): Move from eval.c.
966 * lisp.h (Qdefun): Remove.
967 * lread.c (read1): Tiny simplification.
969 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
971 Do not create empty overlays with the evaporate property (Bug#9642).
972 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
973 Bug#9642, but explicitly check that the buffer the overlay would
974 be moved to is live and rearrange lines to make sure that errors
975 will not put the overlay in an inconsistent state.
976 (Fdelete_overlay): Cosmetics.
978 2012-05-28 Eli Zaretskii <eliz@gnu.org>
980 * w32term.c (my_bring_window_to_top): New function.
981 (x_raise_frame): Use handle returned by DeferWindowPos, which
982 could be different from the original one.
983 Call my_bring_window_to_top instead of my_set_foreground_window.
986 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
987 by calling BringWindowToTop.
989 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
990 (WM_EMACS_END): Increase by one.
992 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
994 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
995 This avoids undefined behavior that might cause the eassert
996 to not catch an out-of-range value.
998 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1000 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1001 Update dependencies.
1003 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1005 * bidi.c (bidi_mirror_char): Fix last change.
1007 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1009 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1010 when referring to sectname field in printf format.
1012 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1014 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1015 Only r_alloc_inhibit_buffer_relocation needed to be added;
1016 the others were already declared.
1018 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1019 before checking whether it's out of range. Put the check inside
1021 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1023 2012-05-27 Ken Brown <kbrown@cornell.edu>
1025 * callproc.c (Fcall_process): Restore a line that was accidentally
1026 commented out in the 2011-02-13 change (bug#11547).
1028 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1030 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1031 defined on ralloc.c.
1033 * buffer.c [REL_ALLOC]: Remove prototypes of
1034 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1035 they are now on lisp.h.
1037 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1039 * search.c (search_buffer): Use it to inhibit relocation of buffer
1040 text while re_search_2 is doing its job, because re_search_2 is
1041 passed C pointers to buffer text. (Bug#11519)
1043 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1046 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1047 state after an additional call to move_it_in_display_line_to, keep
1048 the values of it->max_ascent and it->max_descent found for the
1050 (pos_visible_p): Revert the comparison against bottom_y to what it
1051 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1054 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1056 Fix coding-related core dumps with gcc -ftrapv.
1057 The code was computing A - B, where A and B are pointers, and B is
1058 random garbage. This can lead to core dumps on platforms that
1059 have special pointer registers, and it also leads to core dumps on
1060 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1061 A - B only when B is initialized properly.
1062 * coding.c (coding_set_source, coding_set_destination): Return void.
1063 (coding_change_source, coding_change_destinations): New functions,
1064 with the old behaviors of coding_set_source and coding_set_destination.
1065 All callers that need an offset changed to use these new functions.
1067 2012-05-26 Glenn Morris <rgm@gnu.org>
1069 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1071 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1073 Extend mouse support on W32 text-mode console.
1074 * xdisp.c (draw_row_with_mouse_face):
1075 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1077 * w32console.c: Include window.h.
1078 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1080 (initialize_w32_display): Initialize mouse-highlight data.
1082 * w32inevt.c: Include termchar.h and window.h.
1083 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1084 moves, call note_mouse_highlight. If help_echo changed, call
1085 gen_help_event to produce help-echo message in the echo area.
1086 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1089 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1091 * lread.c (read1): Simplify slightly to avoid an overflow warning
1092 with GCC 4.7.0 on x86-64.
1094 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1096 * bidi.c (bidi_mirror_char): Revert last change: an int is
1097 definitely wide enough here.
1099 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1101 Fix integer width and related bugs (Bug#9874).
1102 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1103 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1104 (string_bytes, check_sblock, allocate_string_data):
1105 (compact_small_strings, Fmake_bool_vector, make_string)
1106 (make_unibyte_string, make_multibyte_string)
1107 (make_string_from_bytes, make_specified_string)
1108 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1109 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1112 (allocate_pseudovector):
1113 Use int, not EMACS_INT, where int is wide enough.
1114 (inhibit_garbage_collection, Fgarbage_collect):
1115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1116 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1117 int might not be wide enough.
1118 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1119 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1120 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1121 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1122 (bidi_level_of_next_char, bidi_move_to_visually_next):
1123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1124 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1125 (Fkill_buffer, Fset_buffer_major_mode)
1126 (advance_to_char_boundary, Fbuffer_swap_text)
1127 (Fset_buffer_multibyte, overlays_at, overlays_in)
1128 (overlay_touches_p, struct sortvec, record_overlay_string)
1129 (overlay_strings, recenter_overlay_lists)
1130 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1131 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1132 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1133 (Foverlay_recenter, last_overlay_modification_hooks_used)
1134 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1136 (validate_region): Omit unnecessary test for b <= e,
1137 since that's guaranteed by the previous test.
1138 (adjust_overlays_for_delete): Avoid pos + length overflow.
1139 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1140 (report_overlay_modification):
1141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1142 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1143 Omit pointer cast, which isn't needed anyway, and doesn't work
1144 after the EMACS_INT -> ptrdiff_t change.
1145 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1146 * buffer.h: Adjust decls to match defn changes elsewhere.
1147 (struct buffer_text, struct buffer):
1148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1149 Use EMACS_INT, not int, where int might not be wide enough.
1150 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1151 not int, to avoid needless 32-bit limit on 64-bit hosts.
1152 (exec_byte_code): Use tighter memory-full test, one that checks
1153 for alloca overflow. Don't compute the address of the object just
1154 before an array, as that's not portable. Use EMACS_INT, not
1155 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1156 * callint.c (Fcall_interactively):
1157 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1158 * callproc.c (call_process_kill, Fcall_process):
1159 Don't assume pid_t fits into an Emacs fixnum.
1160 (call_process_cleanup, Fcall_process, child_setup):
1161 Don't assume pid_t fits into int.
1162 (call_process_cleanup, Fcall_process, delete_temp_file)
1163 (Fcall_process_region):
1164 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1165 (Fcall_process): Simplify handling of volatile integers.
1166 Use int, not EMACS_INT, where int will do.
1167 * casefiddle.c (casify_object, casify_region, operate_on_word)
1168 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1170 (casify_object): Avoid integer overflow when overallocating buffer.
1171 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1172 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1173 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1174 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1175 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1176 integers are now checked earlier. All uses replaced with XINT.
1178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1179 For CCL_MapSingle, check that content and value are in int range.
1180 (ccl_driver, Fregister_code_conversion_map):
1181 Check that Vcode_version_map_vector is a vector.
1182 (resolve_symbol_ccl_program): Check that vector header is in range.
1183 Always copy the vector, so that we can check its contents reliably
1184 now rather than having to recheck each instruction as it's being
1185 executed. Check that vector words fit in 'int'.
1186 (ccl_get_compiled_code, Fregister_ccl_program)
1187 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1188 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1189 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1190 contents are in range.
1191 (Fccl_execute_on_string): Check that status is in range.
1192 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1193 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1194 Accept and return EMACS_INT, not int, because callers can pass values
1196 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1197 (multibyte_chars_in_text, parse_str_as_multibyte)
1198 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1199 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1200 (string_escape_byte8, Fget_byte):
1201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1202 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1203 avoid mishandling large integers.
1204 * character.h: Adjust decls to match defn changes elsewhere.
1205 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1206 (Ffind_charset_region):
1207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1208 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1209 (load_charset_map_from_vector, Fdefine_charset_internal):
1210 Don't assume fixnum fits in int.
1211 (load_charset_map_from_vector, Fmap_charset_chars):
1212 Remove now-unnecessary CHECK_NATNUMs.
1213 (Fdefine_charset_internal): Check ranges here, more carefully.
1214 Don't rely on undefined behavior with signed left shift overflow.
1215 Don't assume unsigned int fits into fixnum, or that fixnum fits
1216 into unsigned int. Don't require max_code to be a valid fixnum;
1217 that's not true for gb10830 4-byte on a 32-bit host. Allow
1218 invalid_code to be a cons, for the same reason. Require code_offset
1219 to be a character. Avoid int overflow if max_char is close
1221 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1222 this is intended anyway and avoids some undefined behavior.
1223 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1224 INDEX_TO_CODE_POINT, as that's what it expects.
1225 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1226 * charset.h (DECODE_CHAR): Return int, not unsigned;
1227 this is what was intended anyway, and it avoids undefined behavior.
1228 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1229 integer-overflow issues.
1230 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1231 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1232 where the argument is EMACS_INT, and this behavior is not intended.
1233 * chartab.c (Fmake_char_table, Fset_char_table_range)
1234 (uniprop_get_decoder, uniprop_get_encoder):
1235 Don't assume fixnum fits in int.
1236 * cmds.c (move_point): New function, that does the gist of
1237 Fforward_char and Fbackward_char, but does so while checking
1238 for integer overflow more accurately.
1239 (Fforward_char, Fbackward_char): Use it.
1240 (Fforward_line, Fend_of_line, internal_self_insert)
1241 (internal_self_insert):
1242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1243 Fix a FIXME, by checking for integer overflow when calculating
1244 target_clm and actual_clm.
1245 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1246 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1247 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1248 (coding_alloc_by_making_gap, alloc_destination)
1249 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1250 (encode_coding_utf_16, detect_coding_emacs_mule)
1251 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1252 (detect_coding_iso_2022, decode_coding_iso_2022)
1253 (encode_invocation_designation, encode_designation_at_bol)
1254 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1255 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1256 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1257 (encode_coding_ccl, encode_coding_raw_text)
1258 (detect_coding_charset, decode_coding_charset)
1259 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1260 (produce_composition, produce_charset, produce_annotation)
1261 (decode_coding, handle_composition_annotation)
1262 (handle_charset_annotation, consume_chars, decode_coding_gap)
1263 (decode_coding_object, encode_coding_object, detect_coding_system)
1264 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1265 (code_convert_region, code_convert_string)
1266 (Fdefine_coding_system_internal)
1267 (coding_set_source, coding_set_destination):
1268 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1269 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1270 (Fdefine_coding_system_internal):
1271 Don't assume fixnums fit in int.
1272 (decode_coding_gap, decode_coding_object, encode_coding_object)
1273 (Fread_coding_system, Fdetect_coding_region)
1274 (Funencodable_char_position, Fcheck_coding_systems_region)
1275 (get_translation, handle_composition_annotation, consume_chars):
1276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1277 (consume_chars): Rewrite to not calculate an address outside buffer.
1278 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1279 Don't access memory outside of the args array.
1280 (Fdefine_coding_system_internal): Check for charset-id overflow.
1281 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1282 result of ENCODE_CHAR.
1283 * coding.h: Adjust decls to match defn changes elsewhere.
1284 (struct coding_system):
1285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1286 * composite.c (get_composition_id, find_composition)
1287 (run_composition_function, update_compositions)
1288 (compose_text, composition_gstring_put_cache)
1289 (composition_gstring_p, composition_gstring_width)
1290 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1291 (composition_compute_stop_pos, composition_reseat_it)
1292 (composition_update_it, struct position_record)
1293 (find_automatic_composition, composition_adjust_point)
1294 (Fcomposition_get_gstring, Ffind_composition_internal):
1295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1296 (update_compositions):
1297 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1298 * composite.h: Adjust decls to match defn changes elsewhere.
1299 (struct composition):
1300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1301 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1302 Do not attempt to compute the address of the object just before a
1303 buffer; this is not portable.
1305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1306 (Faset): Use int, not EMACS_INT, where int is wide enough.
1307 (Fstring_to_number): Don't assume fixnums fit in int.
1308 (Frem): Don't assume arg is nonnegative.
1309 * dbusbind.c (xd_append_arg): Check for integers out of range.
1310 (Fdbus_call_method): Don't overflow the timeout int.
1311 (extract_signed, extract_unsigned): New functions.
1312 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1313 (xd_get_connection_references): Return ptrdiff_t, not int.
1315 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1316 (xd_read_message_1):
1317 Use int, not unsigned, where the dbus API uses int.
1318 (Fdbus_message_internal): Don't overflow mtype.
1319 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1320 * dired.c (directory_files_internal, file_name_completion, scmp)
1321 (file_name_completion_stat):
1322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1323 (file_name_completion): Don't overflow matchcount.
1324 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1325 * dispextern.h: Adjust decls to match defn changes elsewhere.
1326 (struct text_pos, struct glyph, struct bidi_saved_info)
1327 (struct bidi_string_data, struct bidi_it, struct composition_it)
1329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1330 (struct display_pos, struct composition_it, struct it):
1331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1332 * dispnew.c (increment_matrix_positions)
1333 (increment_row_positions, mode_line_string)
1334 (marginal_area_string):
1335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1336 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1338 (duration_to_sec_usec): New function, to check for overflow better.
1339 (Fsleep_for, sit_for): Use it.
1340 * doc.c (get_doc_string, store_function_docstring):
1341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1342 (get_doc_string, Fsnarf_documentation):
1343 Use int, not EMACS_INT, where int is wide enough.
1345 Use SAFE_ALLOCA, not alloca.
1346 Check for overflow when converting EMACS_INT to off_t.
1347 * doprnt.c (doprnt):
1348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1349 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1350 Don't assume uid_t fits into fixnum.
1351 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1352 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1353 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1354 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1355 (general_insert_function)
1356 (Finsert_char, make_buffer_string, make_buffer_string_both)
1357 (update_buffer_properties, Fbuffer_substring)
1358 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1359 (Fsubst_char_in_region, check_translation)
1360 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1361 (transpose_markers, Ftranspose_regions):
1362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1363 (clip_to_bounds): Move to lisp.h as an inline function).
1364 (Fconstrain_to_field): Don't assume integers are nonnegative.
1365 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1366 (Fsubst_char_in_region, Fsave_restriction):
1367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1368 (Femacs_pid): Don't assume pid_t fits into fixnum.
1369 (lo_time): Use int, not EMACS_INT, when int suffices.
1370 (lisp_time_argument): Check for usec out of range.
1371 (Fencode_time): Don't assume fixnum fits in int.
1372 (Fuser_login_name, Fuser_full_name): Signal an error
1373 if a uid argument is out of range, rather than relying on
1375 (Fformat_time_string): Remove now-unnecessary check.
1376 lisp_time_argument checks for out-of-range usec now.
1377 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1378 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1379 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1380 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1381 (init_cmdargs, Fdump_emacs):
1382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1383 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1384 the bottom (typically) 32 bits of the fixnum.
1385 * eval.c (specpdl_size, call_debugger):
1386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1387 (when_entered_debugger, Fbacktrace_debug):
1388 Don't assume fixnum can fit in int.
1389 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1390 the object just before a buffer; this is not portable.
1391 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1392 (grow_specpdl, unbind_to):
1393 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1394 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1395 (grow_specpdl): Simplify allocation by using xpalloc.
1396 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1397 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1398 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1400 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1403 (Fcopy_file, non_regular_nbytes, read_non_regular)
1404 (Finsert_file_contents):
1405 Use int, not EMACS_INT, where int is wide enough.
1406 (READ_BUF_SIZE): Verify that it fits in int.
1407 (Finsert_file_contents): Check that counts are in proper range,
1408 rather than assuming fixnums fit into ptrdiff_t etc.
1409 Don't assume fixnums fit into int.
1410 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1411 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1412 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1413 (string_char_to_byte, string_byte_to_char)
1414 (string_make_multibyte, string_to_multibyte)
1415 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1416 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1417 (substring_both, Fdelete, internal_equal, Ffillarray)
1418 (Fclear_string, mapcar1)
1419 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1420 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1421 (larger_vector, make_hash_table, maybe_resize_hash_table)
1422 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1423 (Fmaphash, secure_hash):
1424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1425 (concat): Check for string index and length overflow.
1426 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1428 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1429 (larger_vector): New API (vec, incr_min, size_max) replaces old
1430 one (vec, new_size, init). This catches size overflow.
1431 INIT was removed because it was always Qnil.
1432 All callers changed.
1433 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1434 the upper bound on a hash table index size.
1435 (make_hash_table, maybe_resize_hash_table): Use it.
1436 (secure_hash): Computer start_byte and end_byte only after
1437 they're known to be in ptrdiff_t range.
1438 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1439 (Ffont_get_glyphs, Ffont_at):
1440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1441 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1442 (Flist_fonts, Fopen_font):
1443 Don't assume fixnum can fit in int.
1444 (check_gstring): Don't assume index can fit in int.
1445 (font_match_p): Check that fixnum is a character, not a nonnegative
1446 fixnum, since the later code needs to stuff it into an int.
1447 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1448 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1449 conversion overflow issues.
1450 (Fopen_font): Check for integer out of range.
1451 (Ffont_get_glyphs): Don't assume index can fit in int.
1452 * font.h: Adjust decls to match defn changes elsewhere.
1453 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1455 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1456 printmax_t, where ptrdiff_t is wide enough.
1457 (Finternal_char_font):
1458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1459 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1460 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1461 (Fset_frame_position, x_set_frame_parameters)
1462 (x_set_line_spacing, x_set_border_width)
1463 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1464 Check that fixnums are in proper range for system types.
1465 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1467 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1468 Use SAFE_ALLOCA_LISP, not alloca.
1469 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1470 intptr_t is wide enough.
1471 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1472 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1473 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1474 Check for fixnum out of range.
1475 * ftfont.c (ftfont_list): Don't assume index fits in int.
1476 Check that fixnums are in proper range for system types.
1477 (ftfont_shape_by_flt):
1478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1479 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1481 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1482 Check that fixnums are in proper range for system types.
1483 * gnutls.h: Adjust decls to match defn changes elsewhere.
1484 * gtkutil.c (xg_dialog_run):
1485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1486 (update_frame_tool_bar):
1487 Check that fixnums are in proper range for system types.
1488 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1489 (lookup_image): Check that fixnums are in range for system types.
1490 * indent.c (last_known_column, last_known_column_point):
1491 (current_column_bol_cache):
1492 (skip_invisible, current_column, check_display_width):
1493 (check_display_width, scan_for_column, current_column_1)
1494 (Findent_to, Fcurrent_indentation, position_indentation)
1495 (indented_beyond_p, Fmove_to_column, compute_motion):
1496 (Fcompute_motion, Fvertical_motion):
1497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1498 (last_known_column_modified): Use EMACS_INT, not int.
1499 (check_display_width):
1501 Check that fixnums and floats are in proper range for system types.
1502 (compute_motion): Don't assume index or fixnum fits in int.
1503 (compute_motion, Fcompute_motion):
1504 Use int, not EMACS_INT, when it is wide enough.
1505 (vmotion): Omit local var start_hpos that is always 0; that way
1506 we don't need to worry about overflow in expressions involving it.
1507 * indent.h: Adjust decls to match defn changes elsewhere.
1509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1510 Use int, not EMACS_INT, where int is wide enough.
1511 Remove unused members ovstring_chars_done and tab_offset;
1513 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1514 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1515 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1516 (make_gap, copy_text, insert, insert_and_inherit)
1517 (insert_before_markers, insert_before_markers_and_inherit)
1518 (insert_1, count_combining_before, count_combining_after)
1519 (insert_1_both, insert_from_string)
1520 (insert_from_string_before_markers, insert_from_string_1)
1521 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1522 (adjust_after_replace, adjust_after_insert, replace_range)
1523 (replace_range_2, del_range, del_range_1, del_range_byte)
1524 (del_range_both, del_range_2, modify_region)
1525 (prepare_to_modify_buffer, signal_before_change)
1526 (signal_after_change, Fcombine_after_change_execute):
1527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1528 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1529 (balance_an_interval, split_interval_right, split_interval_left)
1530 (find_interval, next_interval, update_interval)
1531 (adjust_intervals_for_insertion, delete_node, delete_interval)
1532 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1533 (static_offset_intervals, offset_intervals)
1534 (merge_interval_right, merge_interval_left, make_new_interval)
1535 (graft_intervals_into_buffer, temp_set_point_both)
1536 (temp_set_point, set_point, adjust_for_invis_intang)
1537 (set_point_both, move_if_not_intangible, get_property_and_range)
1538 (get_local_map, copy_intervals, copy_intervals_to_string)
1539 (compare_string_intervals, set_intervals_multibyte_1):
1540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1541 * intervals.h: Adjust decls to match defn changes elsewhere.
1543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1544 * keyboard.c (this_command_key_count, this_single_command_key_start)
1545 (before_command_key_count, before_command_echo_length, echo_now)
1546 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1547 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1548 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1549 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1551 (last_non_minibuf_size, last_point_position, echo_truncate)
1552 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1553 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1554 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1555 (stuff_buffered_input):
1556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1557 (last_auto_save, command_loop_1, read_char):
1558 Use EMACS_INT, not int, to avoid integer overflow.
1559 (record_char): Avoid overflow in total_keys computation.
1560 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1561 * keyboard.h: Adjust decls to match defn changes elsewhere.
1562 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1563 (Fkey_description, Fdescribe_vector, Flookup_key):
1564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1565 (click_position): New function, to check that positions are in range.
1566 (Fcurrent_active_maps):
1568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1569 (Faccessible_keymaps, Fkey_description):
1570 (preferred_sequence_p):
1571 Don't assume fixnum can fit into int.
1572 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1573 Check for integer overflow in size calculations.
1574 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1575 avoid mishandling large integers.
1576 * lisp.h: Adjust decls to match defn changes elsewhere.
1577 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1578 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1579 (struct Lisp_Marker):
1580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1581 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1582 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1583 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1584 All callers changed.
1585 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1586 Assume the arg has valid form, since it always does.
1587 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1588 unsigned integer system type.
1589 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1590 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1592 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1593 (duration_to_sec_usec): New decl.
1594 * lread.c (read_from_string_index, read_from_string_index_byte)
1595 (read_from_string_limit, readchar, unreadchar, openp)
1596 (read_internal_start, read1, oblookup):
1597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1598 (Fload, readevalloop, Feval_buffer, Feval_region):
1599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1600 (openp): Check for out-of-range argument to 'access'.
1601 (read1): Use int, not EMACS_INT, where int is wide enough.
1602 Don't assume fixnum fits into int.
1603 Fix off-by-one error that can read outside a buffer.
1604 (read_filtered_event): Use duration_to_sec_usec
1605 to do proper overflow checking on durations.
1606 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1607 in size calculation.
1608 (Fexecute_kbd_macro):
1609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1610 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1611 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1612 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1613 (set_marker_both, set_marker_restricted_both, marker_position)
1614 (marker_byte_position, Fbuffer_has_markers_at):
1615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1616 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1617 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1618 It now merely ensures that the menu is large enough, without
1619 necessarily growing it, as this avoids some integer overflow issues.
1620 All callers changed.
1621 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1623 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1624 Use SAFE_ALLOCA_LISP, not alloca.
1625 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1626 to EMACS_INT. Check that fixnums are in proper range for system types.
1627 * minibuf.c (minibuf_prompt_width, string_to_object)
1628 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1629 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1631 (get_minibuffer, read_minibuf_unwind):
1632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1633 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1634 this simplifies overflow checking. All callers changed.
1635 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1638 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1639 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1640 Check that fixnums are in proper range for system types.
1641 (Fx_create_frame, Fx_show_tip):
1642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1643 * nsfont.m (ns_findfonts, nsfont_list_family):
1644 Don't assume fixnum fits in long.
1645 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1647 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1649 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1651 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1652 (PRINTDECLARE, PRINTPREPARE):
1653 (strout, print_string):
1654 (print, print_preprocess, print_check_string_charset_prop)
1656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1658 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1660 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1661 (printchar, strout): Use xpalloc to catch size calculation overflow.
1662 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1663 (print_error_message): Use SAFE_ALLOCA, not alloca.
1664 (print_object): Use int, not EMACS_INT, where int is wide enough.
1665 (print_depth, new_backquote_output, print_number_index):
1666 Use ptrdiff_t, not int, where int might not be wide enough.
1667 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1668 (Fset_process_window_size, Fformat_network_address)
1669 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1671 Check that fixnums are in proper range for system types.
1672 (Fsignal_process): Simplify by avoiding a goto.
1673 Check for process-ids out of pid_t range rather than relying on
1675 (process_tick, update_tick): Use EMACS_INT, not int.
1676 (Fformat_network_address, read_process_output, send_process)
1677 (Fprocess_send_region, status_notify):
1678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1679 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1680 (wait_reading_process_output, read_process_output, exec_sentinel):
1681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1682 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1683 (Faccept_process_output): Use duration_to_sec_usec to do proper
1684 overflow checking on durations.
1685 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1686 Don't assume pid_t fits in int.
1687 * process.h (struct Lisp_Process): Members tick and update_tick
1688 are now of type EMACS_INT, not int.
1689 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1690 configured --with-wide-int.
1691 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1692 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1693 * search.c (looking_at_1, string_match_1):
1694 (fast_string_match, fast_c_string_match_ignore_case)
1695 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1696 (scan_newline, find_before_next_newline, search_command)
1697 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1698 (set_search_regs, wordify):
1701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1702 (string_match_1, search_buffer, set_search_regs):
1704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1705 (wordify): Check for overflow in size calculation.
1706 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1707 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1708 Check that fixnums are in proper range for system types.
1709 * sound.c (struct sound_device)
1710 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1712 (Fplay_sound_internal):
1713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1714 * syntax.c (struct lisp_parse_state, find_start_modiff)
1715 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1716 (Fparse_partial_sexp):
1717 Don't assume fixnums can fit in int.
1718 (struct lisp_parse_state, find_start_pos, find_start_value)
1719 (find_start_value_byte, find_start_begv)
1720 (update_syntax_table, char_quoted, dec_bytepos)
1721 (find_defun_start, prev_char_comend_first, back_comment):
1722 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1723 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1725 (Finternal_describe_syntax_value): Check that match_lisp is a
1726 character, not an integer, since the code stuffs it into int.
1727 (scan_words, scan_sexps_forward):
1728 Check that fixnums are in proper range for system types.
1730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1731 (scan_sexps_forward):
1732 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1733 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1734 * syntax.h: Adjust decls to match defn changes elsewhere.
1735 (struct gl_state_s):
1736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1737 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1738 MOST_POSITIVE_FIXNUM.
1739 * sysdep.c (wait_for_termination_1, wait_for_termination)
1740 (interruptible_wait_for_termination, mkdir):
1741 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1742 (emacs_read, emacs_write):
1743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1744 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1745 and double all fit in int.
1746 * term.c (set_tty_color_mode):
1747 Check that fixnums are in proper range for system types.
1748 * termhooks.h (struct input_event):
1749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1750 * textprop.c (validate_interval_range, interval_of)
1751 (Fadd_text_properties, set_text_properties_1)
1752 (Fremove_text_properties, Fremove_list_of_text_properties)
1753 (Ftext_property_any, Ftext_property_not_all)
1754 (copy_text_properties, text_property_list, extend_property_ranges)
1755 (verify_interval_modification):
1756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1757 (Fnext_single_char_property_change)
1758 (Fprevious_single_char_property_change):
1759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1760 (copy_text_properties):
1761 Check for integer overflow in index calculation.
1762 * undo.c (last_boundary_position, record_point, record_insert)
1763 (record_delete, record_marker_adjustment, record_change)
1764 (record_property_change):
1765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1766 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1768 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1769 (Fx_hide_tip, Fx_file_dialog):
1770 * w32menu.c (set_frame_menubar):
1771 Use ptrdiff_t, not int, for consistency with rest of code.
1772 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1773 (select_window, Fdelete_other_windows_internal)
1774 (window_scroll_pixel_based, window_scroll_line_based)
1775 (Frecenter, Fset_window_configuration):
1776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1777 (Fset_window_hscroll, run_window_configuration_change_hook)
1778 (set_window_buffer, temp_output_buffer_show, scroll_command)
1779 (Fscroll_other_window, Frecenter):
1780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1781 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1782 Don't assume fixnum fits in int.
1783 (Fset_window_scroll_bars):
1784 Check that fixnums are in proper range for system types.
1785 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1786 (string_pos, c_string_pos, number_of_chars, init_iterator)
1787 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1788 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1789 (compute_display_string_end, handle_face_prop)
1790 (face_before_or_after_it_pos, handle_invisible_prop)
1791 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1792 (display_prop_intangible_p, string_buffer_position_lim)
1793 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1794 (get_overlay_strings_1, get_overlay_strings)
1795 (iterate_out_of_display_property, forward_to_next_line_start)
1796 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1797 (get_next_display_element, set_iterator_to_next)
1798 (get_visually_first_element, compute_stop_pos_backwards)
1799 (handle_stop_backwards, next_element_from_buffer)
1800 (move_it_in_display_line_to, move_it_in_display_line)
1801 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1802 (add_to_log, message_dolog, message_log_check_duplicate)
1803 (message2, message2_nolog, message3, message3_nolog
1804 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1805 (current_message_1, truncate_echo_area, truncate_message_1)
1806 (set_message, set_message_1, store_mode_line_noprop)
1807 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1808 (text_outside_line_unchanged_p, check_point_in_composition)
1809 (reconsider_clip_changes)
1810 (redisplay_internal, set_cursor_from_row, try_scrolling)
1811 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1812 (redisplay_window, find_last_unchanged_at_beg_row)
1813 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1814 (trailing_whitespace_p, find_row_edges, display_line)
1815 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1816 (display_mode_element, store_mode_line_string)
1817 (pint2str, pint2hrstr, decode_mode_spec)
1818 (display_count_lines, display_string, draw_glyphs)
1819 (x_produce_glyphs, x_insert_glyphs)
1820 (rows_from_pos_range, mouse_face_from_buffer_pos)
1821 (fast_find_string_pos, mouse_face_from_string_pos)
1822 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1824 (safe_call, init_from_display_pos, handle_fontified_prop)
1825 (handle_single_display_spec, load_overlay_strings)
1826 (with_echo_area_buffer, setup_echo_area_for_printing)
1827 (display_echo_area, echo_area_display)
1828 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1829 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1830 (redisplay_window, dump_glyph_row, display_mode_line)
1831 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1832 (handle_display_spec, display_prop_string_p):
1833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1834 (handle_single_display_spec, build_desired_tool_bar_string)
1835 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1836 (get_specified_cursor_type):
1837 Check that fixnums are in proper range for system types.
1838 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1839 (Flookup_image_map):
1840 Don't assume fixnums fit in int.
1841 (compare_overlay_entries):
1842 Avoid mishandling comparisons due to subtraction overflow.
1843 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1844 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1845 (handle_tool_bar_click):
1846 Use int, not unsigned, since we prefer signed and the signedness
1847 doesn't matter here.
1848 (get_next_display_element, next_element_from_display_vector):
1849 Use int, not EMACS_INT, when int is wide enough.
1850 (start_hourglass): Use duration_to_sec_usec to do proper
1851 overflow checking on durations.
1852 * xfaces.c (Fbitmap_spec_p):
1853 Check that fixnums are in proper range for system types.
1854 (compare_fonts_by_sort_order):
1855 Avoid mishandling comparisons due to subtraction overflow.
1856 (Fx_family_fonts, realize_basic_faces):
1857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1859 Don't assume fixnum fits in int.
1860 Use SAFE_ALLOCA_LISP, not alloca.
1861 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1862 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1863 (face_at_buffer_position, face_for_overlay_string)
1864 (face_at_string_position):
1865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1866 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1867 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1869 Check that fixnums are in proper range for system types.
1870 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1871 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1873 (Fx_change_window_property): Don't assume fixnums fit in int.
1874 * xfont.c (xfont_chars_supported):
1875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1876 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1877 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1879 * xml.c (parse_region):
1880 * xrdb.c (magic_file_p):
1881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1882 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1883 (x_get_local_selection, x_reply_selection_request)
1884 (x_handle_selection_request, wait_for_property_change):
1885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1886 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1887 short is wide enough.
1888 (x_send_client_event): Don't assume fixnum fits in int.
1889 * xterm.c (x_x_to_emacs_modifiers):
1890 Don't assume EMACS_INT overflows nicely into int.
1891 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1893 (handle_one_xevent): NATNUMP can eval its arg twice.
1894 (x_connection_closed):
1895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1896 * xterm.h: Adjust decls to match defn changes elsewhere.
1897 (struct scroll_bar): Use struct vectorlike_header
1898 rather than rolling our own approximation.
1899 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1901 2012-05-25 Glenn Morris <rgm@gnu.org>
1903 * lisp.mk (lisp): Update for more files being compiled now.
1905 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1907 * lread.c: Remove `read_pure' which makes no difference.
1908 (read_pure): Remove var.
1909 (unreadpure): Remove function.
1910 (readevalloop): Don't call read_list with -1 flag.
1911 (read1, read_vector): Don't test read_pure any more.
1912 (read_list): Simplify.
1914 * fileio.c, character.h: Minor style tweaks.
1916 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1918 * window.h (clip_changed): Remove useless declaration.
1920 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1922 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1923 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1925 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1928 This directory predates autoconf and is no longer needed nowadays.
1929 Move its few remaining bits of functionality to where they're needed.
1930 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1931 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1932 * m/template.h: Remove.
1933 * Makefile.in (M_FILE): Remove. All uses removed.
1934 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1935 * lisp.h (USE_LSB_TAG):
1936 * mem-limits.h (EXCEEDS_LISP_PTR):
1937 Use VAL_MAX, not VALBITS, in #if.
1938 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1939 (EMACS_UINT): Define unconditionally now.
1940 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1941 (BITS_PER_EMACS_INT): New constants, replacing
1942 what used to be in config.h, but not useful in #if.
1943 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1944 define them any more.
1945 (VAL_MAX): New macro.
1947 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1948 BITS_PER_EMACS_INT, in #if.
1949 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1950 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1951 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1952 * s/ms-w32.h (DATA_START):
1953 Move here from removed file m/intel386.h.
1954 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1955 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1957 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1959 Assume C89 or later.
1960 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1961 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1963 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1964 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1965 * textprop.c, tparam.c (NULL): Remove.
1966 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1967 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1968 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1969 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1970 * xterm.c (input_signal_count): Assume volatile works.
1972 2012-05-21 Ken Brown <kbrown@cornell.edu>
1974 * xgselect.c (xg_select): Fix first argument in call to 'select'
1977 2012-05-20 Ken Brown <kbrown@cornell.edu>
1979 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1980 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1982 2012-05-19 Ken Brown <kbrown@cornell.edu>
1984 * xfns.c (x_in_use): Remove `static' qualifier.
1985 * xterm.h (x_in_use): Declare.
1986 * xgselect.c: Include xterm.h.
1987 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1988 and `display_arg' (bug#9754).
1990 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1992 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1994 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1995 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1997 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1999 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2001 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2002 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2004 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2005 reference to image_cache->refcount.
2006 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2008 2012-05-17 Juri Linkov <juri@jurta.org>
2010 * search.c (Fword_search_regexp, Fword_search_backward)
2011 (Fword_search_forward, Fword_search_backward_lax)
2012 (Fword_search_forward_lax): Move functions to isearch.el
2013 (bug#10145, bug#11381).
2015 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2017 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2019 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2021 * lread.c (init_obarray): Declare Qt and Qnil as special.
2023 2012-05-14 Glenn Morris <rgm@gnu.org>
2025 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2026 Put "libexec" before "bin", for the sake of init_callproc_1.
2028 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2030 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2032 * unexaix.c: Port to more-recent AIX compilers.
2033 (report_error, report_error_1, make_hdr, copy_sym)
2034 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2035 Make arguments const char *, not char *, to avoid violations of C
2036 standard and to fix some AIX warnings reported by Gilles Pion.
2038 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2040 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2041 already have overlays loaded.
2042 (handle_single_display_spec): Before returning without displaying
2043 fringe bitmap, synchronize the bidi iterator with the main display
2044 iterator, by calling iterate_out_of_display_property.
2045 (iterate_out_of_display_property): Detect buffer iteration by
2046 testing that it->string is a Lisp string.
2047 (get_next_display_element): When the current object is exhausted,
2048 and there's something on it->stack, call set_iterator_to_next to
2049 proceed with what's on the stack, instead of returning zero.
2050 (set_iterator_to_next): If called at the end of a Lisp string,
2051 proceed to consider_string_end without incrementing string
2052 position. Don't increment display vector index past the end of
2053 the display vector. (Bug#11417)
2054 (pos_visible_p): Don't report a position visible when move_it_to
2055 stopped at the last line of window, which happens to be scanned
2056 backwards by the bidi iteration. (Bug#11464)
2058 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2060 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2061 and right-margin display specs even if the spec is invalid or we
2062 are on a TTY, and thus unable to display on the fringes.
2063 That's because the text with the property will not be displayed anyway,
2064 so we need to signal to the caller that this is a "replacing"
2065 display spec. This fixes display when the spec is invalid or we
2068 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2070 * unexaix.c (make_hdr): Fix typo in prototype.
2071 This bug broke the build on AIX. Problem reported by Gilles Pion.
2073 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2075 * keyboard.c (kbd_buffer_get_event): Read special events also in
2076 batch mode. (Bug#11415)
2078 2012-05-12 Glenn Morris <rgm@gnu.org>
2080 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2082 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2084 * lisp.mk (lisp): Add newcomment.elc.
2086 2012-05-12 Glenn Morris <rgm@gnu.org>
2088 * Makefile.in (MKDIR_P): New, set by configure.
2089 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2091 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2093 Remove unused function hourglass_started.
2094 * dispextern.h (hourglass_started):
2095 * w32fns.c (hourglass_started):
2096 * xdisp.c (hourglass_started): Remove.
2098 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2100 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2101 Update dependencies.
2103 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2105 * xgselect.c (xg_select): Put maxfds+1 into a var.
2106 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2108 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2110 2012-05-10 Dave Abrahams <dave@boostpro.com>
2112 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2113 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2115 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2117 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2118 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2119 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2120 Initialize xd_registered_buses.
2122 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2124 Untag more efficiently if USE_LSB_TAG.
2125 This is based on a proposal by YAMAMOTO Mitsuharu in
2126 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2127 For an admittedly artificial (nth 8000 longlist) benchmark on
2128 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2129 Emacs's overall text size by 1%.
2130 * lisp.h (XUNTAG): New macro.
2131 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2132 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2133 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2134 * eval.c (Fautoload):
2135 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2136 * frame.h (XFRAME): Use XUNTAG.
2138 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2139 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2140 Remove unportable assumptions about print widths of types like
2142 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2143 intptr_t when converting between pointer and integer, to avoid GCC
2144 warnings about wrong width.
2146 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2148 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2149 stack for each reader_thread, instead of defaulting to 8MB
2150 determined by the linker. This avoids failures in creating
2151 subprocesses on Windows 7, see the discussion in this thread:
2152 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2154 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2156 Fix up display of the *Minibuf-0* buffer in the mini window.
2157 * keyboard.c (read_char): Don't clear the echo area if there's no
2159 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2160 contents of *Minibuf-0*) if there's no message displayed in its stead.
2162 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2164 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2167 2012-05-06 Chong Yidong <cyd@gnu.org>
2169 * lisp.mk (lisp): Update.
2171 2012-05-05 Jim Meyering <meyering@redhat.com>
2173 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2175 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2177 * data.c (PUT_ERROR): New macro.
2178 (syms_of_data): Use it. Add new error type `user-error'.
2179 * undo.c (user_error): New function.
2180 (Fprimitive_undo): Use it.
2181 * print.c (print_error_message): Adjust print style for `user-error'.
2182 * keyboard.c (user_error): New function.
2183 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2185 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2187 Do not limit current-time-string to years 1000..9999.
2188 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2189 (Fcurrent_time_string): Support any year that is supported by the
2190 underlying localtime representation. Don't use asctime, as it
2191 has undefined behavior for years outside the range -999..9999.
2193 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2195 Fix race conditions involving setenv, gmtime, localtime, asctime.
2196 Without this fix, interrupts could mess up code that uses these
2197 nonreentrant functions, since setting TZ invalidates existing
2198 tm_zone or tzname values, and since most of these functions return
2199 pointers to static storage.
2200 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2201 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2202 Grow the critical sections to include not just invoking
2203 localtime/gmtime, but also accessing these functions' results
2204 including their tm_zone values if any, and any related TZ setting.
2205 (format_time_string): Last arg is now struct tm *, not struct tm **,
2206 so that the struct tm is saved in the critical section.
2207 All callers changed. Simplify allocation of initial buffer, partly
2208 motivated by the fact that memory allocation needs to be outside
2209 the critical section.
2211 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2213 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2214 with RESET_INTERVAL.
2216 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2217 Remove duplicated buffer name initialization.
2219 2012-05-02 Jim Meyering <jim@meyering.net>
2221 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2223 * xfns.c (x_window): Use xstrdup (Bug#11375).
2225 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2227 * xdisp.c (pos_visible_p): If already at a newline from the
2228 display string before the 'while' loop, don't walk back the glyphs
2229 from it3.glyph_row. Solves assertion violation when the display
2230 string begins with a newline (egg.el). (Bug#11367)
2232 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2234 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2237 2012-05-01 Glenn Morris <rgm@gnu.org>
2239 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2240 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2241 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2242 All were removed before 23.1.
2244 * dispnew.c: Remove HAVE_LIBNCURSES test;
2245 it is always true on relevant platforms.
2247 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2248 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2250 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2252 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2254 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2255 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2258 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2260 Do not avoid creating empty evaporating overlays (Bug#9642).
2261 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2262 That is, do not delete an evaporating overlay if it becomes
2263 empty after its bounds are adjusted to fit within its buffer.
2264 This fix caused other problems, and I'm reverting it until we get
2265 to the bottom of them.
2267 2012-04-27 Chong Yidong <cyd@gnu.org>
2269 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2271 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2273 * xdisp.c (pos_visible_p): If the window start position is beyond
2274 ZV, start the display from buffer beginning. Prevents assertion
2275 violation in init_iterator when the minibuffer window is scrolled
2278 * window.c (window_scroll_pixel_based): Likewise.
2280 2012-04-27 Chong Yidong <cyd@gnu.org>
2282 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2284 2012-04-27 Glenn Morris <rgm@gnu.org>
2286 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2287 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2289 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2291 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2292 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2294 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2296 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2297 display element, check also the underlying string or buffer
2298 character. (Bug#11341)
2300 * w32menu.c: Include w32heap.h.
2301 (add_menu_item): If the call to AppendMenuW (via
2302 unicode_append_menu) fails, disable Unicode menus only if we are
2303 running on Windows 9X/Me.
2305 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2307 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2308 (xgetint): Add missing shift for LSB tags.
2310 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2312 * keyboard.c (read_char): Don't wipe echo area for select window
2313 events: These might get delayed via `mouse-autoselect-window'
2316 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2318 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2319 manipulation of :loaded-from data.
2321 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2323 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2324 now a cons (bug#11311).
2326 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2328 Do not create empty overlays with the evaporate property (Bug#9642).
2329 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2330 if it becomes empty after its bounds are adjusted to fit within
2331 its buffer. Without this fix, in a nonempty buffer (let ((o
2332 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2333 yields an empty overlay that has the evaporate property, which is
2334 not supposed to happen.
2336 Fix minor GTK3 problems found by static checking.
2337 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2338 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2339 (struct _EmacsFixedClass, emacs_fixed_get_type):
2340 Move decls here from emacsgtkfixed.h, since they needn't be public.
2341 (emacs_fixed_get_type): Now static.
2342 (emacs_fixed_class_init): Omit unused local.
2343 (emacs_fixed_child_type): Remove; unused.
2344 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2345 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2346 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2347 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2348 (EMACS_FIXED_GET_CLASS): Remove; unused.
2349 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2351 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2352 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2354 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2356 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2357 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2358 (__malloc_size_t, __malloc_ptrdiff_t):
2359 Remove. All uses removed, replaced by the definiens if needed,
2360 since we can assume C89 or better now.
2361 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2362 (protect_malloc_state, align, get_contiguous_space)
2363 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2364 (malloc_atfork_handler_child, malloc_enable_thread)
2365 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2366 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2367 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2368 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2369 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2370 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2371 Define using prototypes, not old style.
2372 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2373 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2374 (align): Don't assume that signed integer overflow wraps around.
2375 Omit unused local var.
2376 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2377 (_free_internal_nolock, memalign, mallochook, reallochook):
2378 Omit no-longer-needed casts.
2379 (valloc): Use getpagesize, not __getpagesize.
2380 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2381 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2383 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2385 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2387 Move functions from C to Lisp. Make non-blocking method calls
2388 the default. Implement further D-Bus standard interfaces.
2390 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2391 (QCdbus_request_name_allow_replacement)
2392 (QCdbus_request_name_replace_existing)
2393 (QCdbus_request_name_do_not_queue)
2394 (QCdbus_request_name_reply_primary_owner)
2395 (QCdbus_request_name_reply_in_queue)
2396 (QCdbus_request_name_reply_exists)
2397 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2398 (QCdbus_registered_serial, QCdbus_registered_method)
2399 (QCdbus_registered_signal): New Lisp objects.
2400 (XD_DEBUG_MESSAGE): Use sizeof.
2401 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2402 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2403 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2404 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2405 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2406 (xd_signature, xd_append_arg): Allow float for integer types.
2407 (xd_get_connection_references): New function.
2408 (xd_get_connection_address): Rename from xd_initialize.
2409 Return cached address.
2410 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2411 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2413 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2414 Return number of refcounts.
2415 (Fdbus_get_unique_name): Make stronger parameter check.
2416 (Fdbus_message_internal): New defun.
2417 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2418 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2419 (Fdbus_send_signal, Fdbus_register_service)
2420 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2421 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2422 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2423 (Vdbus_compiled_version, Vdbus_runtime_version)
2424 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2425 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2426 (Vdbus_message_type_signal): New defvars.
2427 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2430 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2432 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2433 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2434 Do not assume ptrdiff_t is the same width as 'int'.
2436 * alloc.c: Handle unusual debugging option combinations.
2437 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2438 since the two debugging options are incompatible.
2439 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2441 (mem_init, mem_insert, mem_insert_fixup):
2442 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2443 (NEED_MEM_INSERT): Remove; no longer needed.
2445 2012-04-22 Leo Liu <sdl.web@gmail.com>
2447 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2449 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2451 * sysdep.c [__FreeBSD__]: Minor cleanups.
2452 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2453 Use Emacs indenting style more consistently. Avoid some casts.
2454 Use 'double' consistently rather than mixing 'float' and 'double'.
2456 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2458 * sysdep.c (list_system_processes, system_process_attributes):
2459 Add implementation for FreeBSD (Bug#5243).
2461 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2463 * lisp.mk (lisp): Update.
2465 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2467 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2468 It is never used otherwise.
2470 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2472 * print.c (print_preprocess): Only check print_depth if print-circle
2474 (print_object): Check for cycles even when print-circle is nil and
2475 print-gensym is t, but only check print_depth if print-circle is nil.
2477 2012-04-20 Chong Yidong <cyd@gnu.org>
2479 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2480 set the status to "failed" and ensure that sentinel is run.
2482 2012-04-20 Glenn Morris <rgm@gnu.org>
2484 * process.c (Fset_process_inherit_coding_system_flag)
2485 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2486 (Fmake_network_process, Fmake_serial_process): Doc fix.
2488 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2490 * xdisp.c (string_buffer_position_lim): Limit starting position to
2492 (set_cursor_from_row): If called for a mode-line or header-line
2493 row, return zero immediately.
2494 (try_cursor_movement): If inside continuation line, don't back up
2495 farther than the first row after the header line, if any.
2496 Don't consider the header-line row as "partially visible", even if
2497 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2499 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2501 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2504 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2505 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2507 configure: new option --enable-gcc-warnings (Bug#11207)
2508 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2509 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2510 (ALL_CFLAGS): Use new macros rather than old.
2511 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2512 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2513 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2514 -Wunused-result, -Wunused-variable. This should go away once
2515 the Emacs and Gnulib regex code is merged.
2516 (xmalloc, xrealloc): Now static.
2518 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2520 * dired.c (Fsystem_groups): Remove unused local.
2522 2012-04-17 Glenn Morris <rgm@gnu.org>
2524 * dired.c (Fsystem_users): Doc fix.
2526 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2528 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2529 (syms_of_dired): Add them.
2531 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2533 Fix minor alloc.c problems found by static checking.
2534 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2535 New extern decls, to avoid calling undeclared functions.
2536 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2537 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2538 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2539 (NEED_MEM_INSERT): New macro.
2540 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2541 Remove one incorrect comment and fix another.
2543 Fix minor ralloc.c problems found by static checking.
2544 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2545 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2546 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2547 (r_alloc_sbrk): Now static.
2549 Improve ralloc.c interface checking.
2550 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2551 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2552 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2553 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2554 [REL_ALLOC]: ... to here, to check interface.
2555 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2556 Remove decls. This fixes an "It stinks!".
2558 * alloc.c (which_symbols): Fix alignment issue / type clash.
2560 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2562 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2563 (struct Lisp_Misc_Any): Likewise.
2564 (struct Lisp_Free): Likewise.
2565 * alloc.c (union aligned_Lisp_Symbol): Define.
2566 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2567 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2568 (union aligned_Lisp_Misc): Define.
2569 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2570 aligned_Lisp_Misc instead of union Lisp_Misc.
2571 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2573 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2575 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2576 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2577 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2578 * s/netbsd.h, s/sol2-6.h:
2579 Remove definition of GC_MARK_STACK, since the default now works.
2580 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2581 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2582 no longer the default.
2583 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2585 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2587 * lread.c (lisp_file_lexically_bound_p):
2588 Fix hang at ";-*-\n" (bug#11238).
2590 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2592 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2593 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2595 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2597 * nsterm.m (constrainFrameRect): Always constrain when there is only
2598 one screen (Bug#10962).
2600 2012-04-13 Ken Brown <kbrown@cornell.edu>
2602 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2604 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2606 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2608 2012-04-11 Daniel Colascione <dancol@dancol.org>
2610 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2611 against is gone. It's better to use vfork now so that when Cygwin
2612 gains a new, working vfork, we use it automatically (bug#10398).
2614 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2616 * window.c (save_window_save): Obey window-point-insertion-type.
2618 2012-04-11 Glenn Morris <rgm@gnu.org>
2620 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2622 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2624 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2626 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2628 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2629 (force_quit_count): New var.
2630 (handle_interrupt): Use it.
2632 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2634 * w32.c (w32_delayed_load): Record the full path of the library
2635 being loaded (bug#10424).
2637 2012-04-09 Glenn Morris <rgm@gnu.org>
2639 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2640 not just in the obarray, before snarfing them. (Bug#11036)
2642 * Makefile.in ($(leimdir)/leim-list.el):
2643 Pass EMACS rather than BUILT_EMACS.
2645 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2647 * process.c (make_process):
2648 * process.h: Add integer `gnutls_handshakes_tried' member to
2651 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2652 Add convenience `GNUTLS_LOG2i' macro.
2654 * gnutls.c (gnutls_log_function2i): Convenience log function.
2655 (emacs_gnutls_read): Use new log functions,
2656 `gnutls_handshakes_tried' process member, and
2657 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2658 attempts per process (connection).
2660 2012-04-09 Chong Yidong <cyd@gnu.org>
2662 * eval.c (Fuser_variable_p, user_variable_p_eh)
2663 (lisp_indirect_variable): Functions deleted.
2664 (Fdefvar): Caller changed.
2666 * callint.c (Finteractive, Fcall_interactively):
2667 * minibuf.c (Fread_variable): Callers changed.
2669 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2671 * xdisp.c (set_cursor_from_row): If the display string appears in
2672 the buffer at position that is closer to point than the position
2673 after the display string, display the cursor on the first glyph of
2674 the display string. Fixes cursor display when a 'display' text
2675 property immediately follows invisible text. (Bug#11094)
2677 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2679 composite.c: use 'double' consistently
2680 * composite.c (get_composition_id): Use 'double' consistently
2681 instead of converting 'float' to 'double' and vice versa; this is
2682 easier to understand and avoids a GCC warning.
2684 2012-04-09 Glenn Morris <rgm@gnu.org>
2686 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2687 preparation for dumping it with emacs. (Bug#4789)
2688 (leimdir): New variable.
2689 ($(leimdir)/leim-list.el): New rule.
2690 (emacs$(EXEEXT)): Depend on leim-list.el.
2692 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2693 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2694 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2696 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2698 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2701 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2703 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2704 Remove unused local variable.
2706 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2708 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2709 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2710 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2711 objects, as mark_maybe_pointer will catch them otherwise.
2712 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2713 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2715 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2717 Fix typo that broke non-Windows builds.
2718 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2720 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2722 Support building on MS-Windows with libxml2.
2724 * makefile.w32-in (OBJ2): Add xml.$(O).
2725 (GLOBAL_SOURCES): Add xml.c.
2726 ($(BLD)/xml.$(O)): New dependency list.
2728 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2729 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2730 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2731 [!WINDOWSNT]: New macros.
2732 (init_libxml2_functions, libxml2_loaded_p): New functions.
2733 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2734 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2735 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2736 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2738 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2739 Call init_libxml2_functions before calling libxml2 functions.
2740 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2742 * emacs.c: Don't include libxml/parser.h.
2743 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2744 xmlCleanupParser directly.
2746 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2748 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2750 * indent.c (Fvertical_motion): If there is a display string at
2751 point, use it.vpos to compute how many lines to backtrack after
2752 move_it_to point. (Bug#11133)
2754 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2756 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2757 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2758 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2759 macros related to unification of CJK characters. For the details,
2760 see the discussion following the message here:
2761 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2763 2012-04-04 Chong Yidong <cyd@gnu.org>
2765 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2767 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2769 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2770 instead of alloca. (Bug#11138)
2772 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2774 * w32menu.c (is_simple_dialog): Properly check lisp types.
2777 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2779 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2780 position we get to after a call to move_it_to fails the
2781 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2782 only if we wind up in a string from display property. (Bug#11063)
2784 * window.c (Fdelete_other_windows_internal): Invalidate the row
2785 and column information about mouse highlight, so that redisplay
2786 restores it after reallocating the glyph matrices. (Bug#7464)
2788 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2789 string comes from a `display' text property, use the buffer
2790 position of that property as if we actually saw that position in
2792 (move_it_by_lines): Remove the assertion that
2793 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2794 violated when there's a before-string at the beginning of a line.
2797 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2799 * xdisp.c (append_space_for_newline): If the default face was
2800 remapped, use the remapped face for the appended newline.
2801 (extend_face_to_end_of_line): Use the remapped default face for
2802 extending the face to the end of the line.
2803 (display_line): Call extend_face_to_end_of_line when the default
2804 face was remapped. (Bug#11068)
2806 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2808 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2810 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2812 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2814 2012-03-27 Glenn Morris <rgm@gnu.org>
2816 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2819 2012-03-26 Kenichi Handa <handa@m17n.org>
2821 * dispextern.h (struct glyph): Fix previous change. Change the
2822 bit length of glyphless.ch to 25 (Bug#11082).
2824 2012-03-26 Chong Yidong <cyd@gnu.org>
2826 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2827 (command_loop_1): Use it; inhibit selection update for
2828 handle-select-window too (Bug#8996).
2830 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2832 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2834 2012-03-25 Kenichi Handa <handa@m17n.org>
2836 * dispextern.h (struct glyph): Change the bit length of
2837 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2839 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2841 * s/ms-w32.h (tzname): Include time.h before redirecting to
2842 _tzname. Fixes the MSVC build. (Bug#9960)
2844 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2846 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2849 * xterm.c (XTread_socket): Only modify handling_signal if
2850 !SYNC_INPUT. (Bug#11080)
2852 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2854 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2855 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2856 when fetching a multibyte character consumes more bytes than
2857 CHAR_BYTES returns, due to unification of CJK characters in
2858 string_char. (Bug#11073)
2860 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2862 * process.c (wait_reading_process_output): Handle pty disconnect
2863 by refraining from sending oneself a SIGCHLD (bug#10933).
2865 2012-03-22 Chong Yidong <cyd@gnu.org>
2867 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2869 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2870 Mark string as coming from a prefix property.
2871 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2872 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2874 2012-03-21 Chong Yidong <cyd@gnu.org>
2876 * xfaces.c (Vface_remapping_alist): Doc fix.
2878 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2880 * w32proc.c (Fw32_set_console_codepage)
2881 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2884 2012-03-20 Chong Yidong <cyd@gnu.org>
2886 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2887 to reflect default non-nil value of redisplay-dont-pause.
2889 2012-03-19 Kenichi Handa <handa@m17n.org>
2891 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2892 it fit in a valid range (Bug#11003).
2894 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2896 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2897 that is not from display property, accept the row as a "cursor
2898 row" if one of the string's character has a non-nil `cursor'
2899 property. Fixes cursor positioning when there are newlines in
2900 overlay strings, e.g. in icomplete.el. (Bug#11035)
2902 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2904 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2906 2012-03-12 Chong Yidong <cyd@gnu.org>
2908 * eval.c (inhibit_lisp_code): Rename from
2909 inhibit_window_configuration_change_hook; move from window.c.
2911 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2912 * window.c (run_window_configuration_change_hook)
2913 (syms_of_window): Callers changed.
2915 2012-03-11 Chong Yidong <cyd@gnu.org>
2917 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2919 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2921 2012-03-10 Chong Yidong <cyd@gnu.org>
2923 * frame.c (other_visible_frames): Don't assume the selected frame
2924 is visible (Bug#10955).
2926 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2928 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2930 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2932 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2933 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2936 2012-03-03 Glenn Morris <rgm@gnu.org>
2938 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2940 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2942 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2943 position past the first glyph_row that ends at ZV. (Bug#10902)
2944 (redisplay_window, next_element_from_string): Fix typos in
2946 (redisplay_window): Pass to move_it_vertically the margin in
2947 pixels, not in screen lines.
2949 2012-03-02 Glenn Morris <rgm@gnu.org>
2951 * buffer.c (buffer-list-update-hook): Doc fix.
2953 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2955 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2956 push_it before setting up the iterator for the first overlay
2957 string, even if we have an empty string loaded.
2958 (next_overlay_string): If there's an empty string on the iterator
2959 stack, pop the stack. (Bug#10903)
2961 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2963 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2964 Suggested by Stefan Monnier in
2965 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2966 * alloc.c (widen_to_Lisp_Object): New static function.
2967 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2968 and widening them to Lisp_Objects. This would work even if
2969 USE_LSB_TAG is defined and wide integers are used, which might
2970 happen in a future version of Emacs.
2972 2012-02-25 Chong Yidong <cyd@gnu.org>
2974 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2977 * xselect.c (Fx_selection_exists_p): Doc fix.
2978 (x_clipboard_manager_save_all): Print an informative message
2979 before saving to clipboard manager.
2981 2012-02-24 Chong Yidong <cyd@gnu.org>
2983 * keyboard.c (process_special_events): Handle all X selection
2984 requests in kbd_buffer, not just the next one (Bug#8869).
2986 2012-02-23 Chong Yidong <cyd@gnu.org>
2988 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2989 call when setting menu-bar-lines and tool-bar-lines parameters.
2990 (unwind_create_frame_1): New helper function.
2992 * window.c (inhibit_window_configuration_change_hook): New var.
2993 (run_window_configuration_change_hook): Obey it.
2994 (syms_of_window): Initialize it.
2996 2012-02-22 Chong Yidong <cyd@gnu.org>
2998 * xterm.c (x_draw_image_relief): Add missing type check for
2999 Vtool_bar_button_margin (Bug#10743).
3001 2012-02-21 Chong Yidong <cyd@gnu.org>
3003 * fileio.c (Vfile_name_handler_alist): Doc fix.
3005 * buffer.c (Fget_file_buffer): Protect against invalid file
3006 handler return value.
3008 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3010 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3011 when computing $valmask.
3013 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3014 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3015 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3016 It's useless in that case, and it can cause problems on hosts
3017 that allocate halves of EMACS_INT values separately.
3018 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3019 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3020 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3021 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3022 it avoids undefined behavior on hosts where shifting right by more
3023 than the word width has undefined behavior.
3025 2012-02-19 Chong Yidong <cyd@gnu.org>
3027 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3028 (Funhandled_file_name_directory, Ffile_name_as_directory)
3029 (Fdirectory_file_name, Fexpand_file_name)
3030 (Fsubstitute_in_file_name): Protect against invalid file handler
3031 return values (Bug#10845).
3033 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3035 * .gdbinit (pitx): Fix incorrect references to fields of the
3038 2012-02-17 Chong Yidong <cyd@gnu.org>
3040 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3042 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3044 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3045 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3047 2012-02-15 Chong Yidong <cyd@gnu.org>
3049 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3050 marked as special. Also, starting docstrings with * is obsolete.
3052 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3054 * gnutls.c (emacs_gnutls_write): Fix last change.
3056 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3058 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3061 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3063 * keymap.c (Fsingle_key_description): Handle char ranges.
3065 2012-02-12 Chong Yidong <cyd@gnu.org>
3067 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3068 as that creates a dangerous corner case.
3070 * window.c (Fdelete_window_internal): Invalidate the mouse
3071 highlight (Bug#9904).
3073 2012-02-12 Glenn Morris <rgm@gnu.org>
3075 * xselect.c (Fx_own_selection_internal)
3076 (Fx_get_selection_internal, Fx_disown_selection_internal)
3077 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3078 * nsselect.m (Fx_own_selection_internal)
3079 (Fx_disown_selection_internal, Fx_selection_exists_p)
3080 (Fx_selection_owner_p, Fx_get_selection_internal):
3081 Sync docs and argument specs with the xselect.c versions.
3083 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3085 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3087 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3089 * w32select.c (Fx_selection_exists_p): Sync doc string and
3090 argument list with xselect.c. (Bug#10783)
3092 * w16select.c (Fx_selection_exists_p): Sync doc string and
3093 argument list with xselect.c. (Bug#10783)
3095 2012-02-10 Glenn Morris <rgm@gnu.org>
3097 * fns.c (Fsecure_hash): Doc fix.
3099 2012-02-09 Kenichi Handa <handa@m17n.org>
3101 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3103 2012-02-07 Chong Yidong <cyd@gnu.org>
3105 * buffer.c (Fbuffer_local_variables)
3106 (buffer_lisp_local_variables): Handle unbound vars correctly;
3107 don't let Qunbound leak into Lisp.
3109 2012-02-07 Glenn Morris <rgm@gnu.org>
3111 * image.c (Fimagemagick_types): Doc fix.
3113 * image.c (imagemagick-render-type): Change it from a lisp object
3114 to an integer. Move the doc here from the lisp manual.
3115 Treat all values not equal to 0 the same.
3117 2012-02-06 Chong Yidong <cyd@gnu.org>
3119 * doc.c (store_function_docstring): Avoid applying docstring of
3120 alias to base function (Bug#2603).
3122 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3124 * .gdbinit (pp1, pv1): Remove redundant defines.
3127 2012-02-04 Chong Yidong <cyd@gnu.org>
3129 * nsterm.m: Declare a global (Bug#10694).
3131 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3133 * w32.c (get_emacs_configuration_options):
3134 Include --enable-checking, if specified, in the return value.
3136 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3138 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3139 after rounding frame sizes. (Bug#9723)
3141 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3143 * keyboard.c (adjust_point_for_property): Don't position point
3144 before BEGV. (Bug#10696)
3146 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3148 Handle overflow when computing char display width (Bug#9496).
3149 * character.c (char_width): Return EMACS_INT, not int.
3150 (char_width, c_string_width): Check for overflow when
3151 computing the width; this is possible now that individual
3152 characters can have unbounded width. Problem introduced
3153 by merge from Emacs 23 on 2012-01-19.
3155 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3157 * dbusbind.c (Fdbus_register_method): Mention the return value
3158 :ignore in the docstring.
3160 2012-02-02 Glenn Morris <rgm@gnu.org>
3162 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3164 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3165 Unconditionally set to t. (Bug#10673)
3166 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3167 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3168 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3170 2012-02-02 Kenichi Handa <handa@m17n.org>
3172 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3173 0, do not call append_composite_glyph.
3175 2012-02-02 Kenichi Handa <handa@m17n.org>
3177 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3179 (x_produce_glyphs): If the component of a composition is a null
3180 string, set it->pixel_width to 1 to avoid zero-width glyph.
3182 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3184 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3185 first 2 arguments are identical. This makes inserting large
3186 output from a subprocess an order of magnitude faster on
3187 MS-Windows, where all sbrk'ed memory is always contiguous.
3189 2012-01-31 Glenn Morris <rgm@gnu.org>
3191 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3192 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3193 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3195 2012-01-29 Glenn Morris <rgm@gnu.org>
3197 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3199 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3201 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3203 2012-01-28 Chong Yidong <cyd@gnu.org>
3205 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3207 2012-01-26 Chong Yidong <cyd@gnu.org>
3209 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3211 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3212 repeat counts (Bug#10507).
3214 2012-01-26 Glenn Morris <rgm@gnu.org>
3216 * lread.c (syms_of_lread): Doc fix.
3218 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3220 * coding.c (encode_designation_at_bol): Change return value to
3223 2012-01-25 Chong Yidong <cyd@gnu.org>
3225 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3227 2012-01-21 Chong Yidong <cyd@gnu.org>
3229 * floatfns.c (Fcopysign): Make the second argument non-optional,
3230 since nil is not allowed anyway.
3232 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3234 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3235 (send_process): Likewise.
3237 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3239 * window.c (save_window_save, Fcurrent_window_configuration)
3240 (Vwindow_persistent_parameters): Do not use Qstate.
3241 Rewrite doc-strings.
3243 2012-01-19 Kenichi Handa <handa@m17n.org>
3245 * character.c (char_width): New function.
3246 (Fchar_width, c_string_width, lisp_string_width):
3247 Use char_width (Bug#9496).
3249 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3251 * window.c (Vwindow_persistent_parameters): New variable.
3252 (Fset_window_configuration, save_window_save): Handle persistent
3255 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3257 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3258 thrashing the stack of the thread. (Bug#9087)
3260 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3262 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3264 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3266 * xdisp.c (rows_from_pos_range): Handle the case where the
3267 highlight ends on a newline. (Bug#10464)
3268 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3269 he end column for display of highlight that ends on a newline
3272 2012-01-11 Glenn Morris <rgm@gnu.org>
3274 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3275 from load-path also when installation-directory is nil. (Bug#10208)
3277 2012-01-10 Glenn Morris <rgm@gnu.org>
3279 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3281 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3282 Update template values to be closer to their typical values these days.
3284 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3286 * xdisp.c (rows_from_pos_range): Accept additional argument
3287 DISP_STRING, and accept any glyph in a row whose object is that
3288 string as eligible for mouse highlight. Fixes mouse highlight of
3289 display strings from overlays. (Bug#10464)
3291 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3293 emacs: fix an auto-save permissions race condition (Bug#10400)
3294 * fileio.c (auto_saving_dir_umask): New static var.
3295 (Fmake_directory_internal): Use it.
3296 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3297 creating the directory. The old code temporarily assigns
3298 too-generous permissions to the directory.
3299 (do_auto_save_eh): Clear it.
3300 (Fdo_auto_save): Catch all errors, not just file errors, so
3301 that the var is always cleared.
3303 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3305 * search.c (scan_buffer): Pass character positions to
3306 know_region_cache, not byte positions. (Bug#6540)
3308 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3310 * w32.c (sys_rename): Report EXDEV when rename of a directory
3311 fails because the target is on another logical disk. (Bug#10284)
3313 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3315 * xterm.c (x_embed_request_focus): New function.
3317 * xterm.h: Add prototype.
3319 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3321 2012-01-05 Glenn Morris <rgm@gnu.org>
3323 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3325 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3327 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3328 Load gnutls_transport_set_lowat only if GnuTLS version is below
3330 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3331 GnuTLS versions below 2.11.1.
3333 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3335 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3336 to the doc string advising against its use for altering the way
3337 windows are scrolled.
3339 2011-12-28 Kenichi Handa <handa@m17n.org>
3341 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3342 coding-system ASCII compatible only when it does not produce BOM
3343 on encoding (Bug#10383).
3345 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3347 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3349 (create_and_show_popup_menu): Always use menu_position_func for
3352 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3354 * callint.c (Fcall_interactively): Don't truncate prompt string.
3356 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3358 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3359 property that ends at ZV, so that the bidi iteration could be
3360 resumed from there (after widening). (Bug#10360)
3362 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3364 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3366 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3368 * nsterm.m (x_free_frame_resources):
3369 Release f->output_data.ns->miniimage.
3370 (ns_index_color): Fix indentation. Do not retain
3371 color_table->colors[i].
3373 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3376 * nsfns.m (x_set_background_color): Assign return value from
3377 ns_index_color to face-background instead of NSColor*.
3378 (ns_implicitly_set_icon_type): Fix indentation.
3379 Change assignment in for loop to comparison.
3381 * emacs.c (ns_pool): New variable.
3382 (main): Assign ns_pool.
3383 (Fkill_emacs): Call ns_release_autorelease_pool.
3385 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3386 autorelease fdesc, release fdAttrs and tdict.
3387 (ns_get_covering_families): Release charset.
3388 (ns_findfonts): Release NSFontDescriptor created with new.
3389 (ns_uni_to_glyphs): Fix indentation.
3390 (setString): Release attrStr before assigning new value.
3392 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3394 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3396 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3397 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3399 2011-12-18 David Reitter <reitter@cmu.edu>
3401 * nsterm.m (ns_term_init): Subscribe for notifications
3402 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3403 to method trackingNotification in EmacsMenu.
3405 * nsmenu.m (trackingMenu): New variable.
3406 (trackingNotification): New method (from Aquamacs).
3407 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3408 from Aquamacs (Bug#7030).
3410 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3412 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3413 (symbol_to_nsstring): Fix indentation.
3414 (ns_symbol_to_pb): New function.
3415 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3416 (Fns_rotate_cut_buffers_internal): Remove.
3417 (Fns_store_selection_internal): Rename from
3418 Fns_store_cut_buffer_internal.
3419 (ns_get_foreign_selection, Fx_own_selection_internal)
3420 (Fx_disown_selection_internal, Fx_selection_exists_p)
3421 (Fns_get_selection_internal, Fns_store_selection_internal):
3422 Use ns_symbol_to_pb and check if return value is nil.
3423 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3424 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3425 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3426 renamed to Sns_store_selection_internal.
3427 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3428 and remove this function.
3429 (ns_handle_selection_clear): Remove, never used.
3430 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3433 2011-12-17 Ken Brown <kbrown@cornell.edu>
3435 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3436 GID is unknown (Bug#10257).
3438 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3440 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3441 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3442 which caused a build failure on GNU/Linux IA-64. This problem was
3443 introduced by my 2011-10-07 patch.
3445 2011-12-15 Juri Linkov <juri@jurta.org>
3447 * image.c (imagemagick_error): New function. (Bug#10112)
3448 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3449 Use `imagemagick_error' where ImageMagick functions return
3451 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3454 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3456 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3457 fill background (Bug#8992).
3459 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3461 * window.c (Vwindow_combination_resize)
3462 (Vwindow_combination_limit): Use t instead of non-nil in
3464 (Vrecenter_redisplay): Add first sentence of doc-string on
3466 (Frecenter): Fix doc-string typo.
3468 2011-12-11 Kenichi Handa <handa@m17n.org>
3470 * coding.c (Funencodable_char_position): Pay attention to the
3471 buffer text relocation (Bug#9389).
3473 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3475 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3476 gtk_init (Bug#10100).
3478 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3480 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3481 IT->string is nil. (Bug#10263)
3483 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3485 * nsterm.h (x_free_frame_resources): Declare.
3487 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3488 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3490 * nsterm.h (ns_get_defaults_value): Declare.
3492 * nsterm.m (ns_default): Call ns_get_defaults_value.
3494 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3496 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3499 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3501 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3502 that where the value of an _OBJC_* symbol points to is in the .bss
3503 section (Bug#10240).
3505 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3507 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3508 after the loop to call ccl_driver at least once (Bug#8619).
3510 2011-12-08 Kenichi Handa <handa@m17n.org>
3512 * ftfont.c (get_adstyle_property): Fix previous change
3515 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3517 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3518 dirs from the default value of EMACSLOADPATH (bug#10208).
3520 2011-12-07 Glenn Morris <rgm@gnu.org>
3522 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3523 installation and source directories as well. (Bug#10208)
3525 2011-12-06 Chong Yidong <cyd@gnu.org>
3527 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3529 2011-12-06 Glenn Morris <rgm@gnu.org>
3531 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3532 as an error, not just -1. (Bug#10217)
3534 2011-12-05 Chong Yidong <cyd@gnu.org>
3536 * keyboard.c (process_special_events): New function.
3537 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3539 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3541 * coding.c (encode_designation_at_bol): Don't use uninitialized
3542 local variable (Bug#9318).
3544 2011-12-05 Kenichi Handa <handa@m17n.org>
3546 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3547 return Qnil (Bug#8046, Bug#10193).
3549 2011-12-05 Kenichi Handa <handa@m17n.org>
3551 * coding.c (encode_designation_at_bol): New args charbuf_end and
3552 dst. Return the number of produced bytes. Callers changed.
3553 (coding_set_source): Return how many bytes coding->source was
3555 (coding_set_destination): Return how many bytes
3556 coding->destination was relocated.
3557 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3558 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3560 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3562 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3563 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3566 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3568 The following changes are to fix Bug#9318.
3570 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3571 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3572 (encode_coding_iso_2022, encode_coding_sjis)
3573 (encode_coding_big5, encode_coding_charset): Use the above macros.
3575 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3577 * lisp.h (process_quit_flag): Fix external declaration.
3579 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3581 Don't macro-inline non-performance-critical code.
3582 * eval.c (process_quit_flag): New function.
3583 * lisp.h (QUIT): Use it.
3585 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3587 * nsfns.m (get_geometry_from_preferences): New function.
3588 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3590 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3592 * emacs.c (Qkill_emacs): Define.
3593 (syms_of_emacs): Initialize it.
3594 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3595 Qquit_flag to `kill-emacs' instead.
3596 (quit_throw_to_read_char): Add parameter `from_signal'.
3597 All callers changed. Call Fkill_emacs if requested and safe.
3598 * lisp.h (QUIT): Call Fkill_emacs if requested.
3600 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3602 * widget.c (update_wm_hints): Return if wmshell is null.
3603 (widget_update_wm_size_hints): New function.
3605 * widget.h (widget_update_wm_size_hints): Declare.
3607 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3608 widget_update_wm_size_hints (Bug#10104).
3610 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3612 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3613 before a newline, prepare the bidi iterator for consuming the
3614 newline, and keep the current paragraph direction. (Bug#10183)
3615 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3617 2011-12-02 Juri Linkov <juri@jurta.org>
3619 * search.c (Fword_search_regexp): New Lisp function created from
3620 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3621 (Fword_search_backward, Fword_search_forward)
3622 (Fword_search_backward_lax, Fword_search_forward_lax):
3623 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3624 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3626 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3628 * fileio.c (Finsert_file_contents): Move after-change-function call
3629 to before the "handled:" label, since all "goto handled" appear in
3630 cases where the *-change-functions have already been properly called
3633 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3635 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3636 waiting for input. (Bug#10169)
3638 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3640 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3641 verifies glyph row's hash code--we have just reallocated the
3642 glyphs, so their contents can be complete garbage. (Bug#10164)
3644 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3646 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3648 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3650 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3651 attributes are tested _before_ calling verify_row_hash, to protect
3652 against GCC re-ordering of the tests. (Bug#10164)
3654 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3656 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3658 * xterm.c (handle_one_xevent): Only set async_visible and friends
3659 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3660 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3661 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3663 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3665 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3666 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3667 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3668 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3669 All uses changed to use GCPRO1 etc.
3670 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3671 Revert to old implementation (i.e., before 2011-03-11).
3673 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3675 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3676 of scroll runs so as to avoid assigning disabled bogus rows and
3677 unnecessary graphics copy operations.
3679 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3681 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3682 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3683 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3684 (malloc, free, realloc, calloc): Redirect to e_* only when
3687 * lisp.h (GCTYPEBITS): Move before first use.
3688 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3689 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3690 this macro definition.
3692 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3695 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3697 * gtkutil.c (xg_create_frame_widgets):
3698 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3699 present with Gtk+ 2.0.
3701 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3703 * fileio.c (Finsert_file_contents): Undo previous change; see
3704 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3706 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3708 Rename locals to avoid shadowing.
3709 * fileio.c (Finsert_file_contents):
3710 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3711 * process.c (wait_reading_process_output):
3712 Rename inner 'proc' to 'p' to avoid shadowing.
3713 Indent for consistency with usual Emacs style.
3715 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3717 * xdisp.c (redisplay_window): If cursor row is not fully visible
3718 after recentering, and scroll-conservatively is set to a large
3719 number, scroll window by a few more lines to make the cursor fully
3720 visible and out of scroll-margin. (Bug#10105)
3721 (start_display): Don't move to the next line if the display should
3722 start at a newline that is part of a display vector or an overlay
3725 2011-11-24 Juri Linkov <juri@jurta.org>
3727 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3728 after the `MagickPingImage' call. (Bug#10112)
3730 2011-11-23 Chong Yidong <cyd@gnu.org>
3732 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3734 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3736 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3737 making another buffer current. (Bug#10114)
3739 2011-11-23 Glenn Morris <rgm@gnu.org>
3741 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3743 2011-11-23 Chong Yidong <cyd@gnu.org>
3745 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3746 using it (Bug#5984).
3748 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3750 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3751 and header-lines, as they don't have one computed for them.
3754 * .gdbinit (prow): Make displayed values more self-explaining.
3755 Add row's hash code.
3757 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3759 * process.c (wait_reading_process_output): Fix asynchrounous
3760 GnuTLS socket handling on some versions of the GnuTLS library.
3761 (wait_reading_process_output): Add comment and URL.
3763 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3765 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3767 2011-11-21 Chong Yidong <cyd@gnu.org>
3769 * window.c (Fnext_window, Fprevious_window): Doc fix.
3771 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3773 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3775 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3777 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3779 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3781 * window.c (Fset_window_combination_limit): Rename argument
3783 (Vwindow_combination_limit): Remove "status" from doc-string.
3785 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3787 * m/ibms390.h: Remove.
3788 * m/ibms390x.h: Don't include "ibms390.h".
3790 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3792 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3793 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3795 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3797 * casetab.c (Fset_case_table):
3798 * charset.c (Fcharset_after): Fix typos.
3800 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3802 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3803 Otherwise, valgrind does not work on some platforms.
3804 Problem reported by Andreas Schwab in
3805 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3806 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3807 is set, removing the need for VIRT_ADDRESS_VARIES.
3808 (PURE_P): Use a more-efficient implementation that needs just one
3809 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3810 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3811 to 4 (xorl, subq, cmpq, setbe).
3812 * alloc.c (pure): Always extern now, since that's the
3813 VIRT_ADDR_VARIES behavior.
3814 (PURE_POINTER_P): Use a single comparison, not two, for
3815 consistency with the new puresize.h.
3816 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3817 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3818 Remove VIRT_ADDR_VARIES no longer needed.
3820 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3822 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3823 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3824 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3825 behave as if the cursor position were at the window margin.
3827 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3828 and the cursor position is out of bounds, behave as if the cursor
3829 position were at the window margin. (Bug#10075)
3831 2011-11-18 Chong Yidong <cyd@gnu.org>
3833 * window.c (Fwindow_combination_limit): Make first argument
3834 non-optional, since it is meaningless for live windows like the
3837 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3839 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3841 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3843 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3844 (graft_intervals_into_buffer): Simplify.
3846 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3848 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3849 hash values of the two rows.
3850 (copy_row_except_pointers): Preserve the used[] arrays and the
3851 hash values of the two rows. (Bug#10035)
3852 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3854 * xdisp.c (row_hash): New function, body extracted from
3855 compute_line_metrics.
3856 (compute_line_metrics): Call row_hash, instead of computing the
3859 * dispnew.c (verify_row_hash): Call row_hash for computing the
3860 hash code of a row, instead of duplicating code from xdisp.c.
3862 * dispextern.h (row_hash): Add prototype.
3864 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3866 * frame.c (delete_frame): Don't delete the terminal when the last
3867 X frame is closed if emacs is built with GTK toolkit.
3869 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3871 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3873 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3875 * window.c (Vwindow_splits): Rename to
3876 Vwindow_combination_resize. Suggested by Juri Linkov.
3877 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3880 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3882 * nsfns.m (Fns_font_name):
3883 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3885 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3887 * window.h (window): Rename slot "nest" to "combination_limit".
3888 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3889 (Fset_window_nest): Rename to Fset_window_combination_limit.
3890 (Vwindow_nest): Rename to Vwindow_combination_limit.
3891 (recombine_windows, make_parent_window, make_window)
3892 (Fsplit_window_internal, saved_window)
3893 (Fset_window_configuration, save_window_save): Rename all
3894 occurrences of window_nest to window_combination_limit.
3896 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3898 * image.c (imagemagick_load_image): Fix typo.
3900 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3902 * xdisp.c (display_line): Move the call to
3903 highlight_trailing_whitespace before the call to
3904 compute_line_metrics, since the latter needs to see the final
3905 faces of all the glyphs to compute ROW's hash value.
3906 Fixes assertion violations in row_equal_p. (Bug#10035)
3908 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3910 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3911 just return (bug#10044).
3913 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3915 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3916 with user-defined heap size. Bump the default size of the temacs
3917 heap to 27MB, to avoid memory warning when running temacs.
3918 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3920 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3921 current_matrix and desired_matrix. (Bug#9990)
3922 (verify_row_hash) [XASSERTS]: New function.
3923 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3924 that the hash value of glyph rows is correct.
3926 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3928 * window.h (window): Remove splits slot.
3929 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3930 (Fdelete_other_windows_internal, make_parent_window)
3931 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3932 (Fset_window_configuration, save_window_save): Don't deal with
3933 split status of windows.
3934 (saved_window): Remove splits slot.
3935 (Vwindow_splits): Rewrite doc-string.
3937 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3939 * xfns.c (unwind_create_frame):
3940 * nsfns.m (unwind_create_frame):
3941 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3942 Vframe_list (Bug#9999).
3944 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3946 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3948 2011-11-11 Kenichi Handa <handa@m17n.org>
3950 * callproc.c (Fcall_process): Set the member dst_multibyte of
3953 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3955 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3956 avoid a crash (bug#9496).
3958 2011-11-09 Chong Yidong <cyd@gnu.org>
3960 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3961 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3963 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3965 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3967 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3969 Avoid some portability problems by eschewing 'extern inline' functions.
3970 The trivial performance wins aren't worth the portability hassles; see
3971 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3973 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3974 (window_box_width, window_box_left, window_box_left_offset)
3975 (window_box_right, window_box_right_offset): Undo previous change,
3976 by removing the "extern"s.
3977 * intervals.c (adjust_intervals_for_insertion)
3978 (adjust_intervals_for_deletion): Undo previous change,
3979 making these static again.
3980 (offset_intervals, temp_set_point_both, temp_set_point)
3981 (copy_intervals_to_string): No longer inline.
3982 * xdisp.c (window_text_bottom_y, window_box_width)
3983 (window_box_height, window_box_left_offset)
3984 (window_box_right_offset, window_box_left, window_box_right)
3985 (window_box): No longer inline.
3987 2011-11-08 Chong Yidong <cyd@gnu.org>
3989 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3990 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3991 Signal an error if not a live window.
3992 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3993 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3995 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3997 * lisp.h (syms_of_abbrev): Remove declaration.
3998 Reported by CHENG Gao <chenggao@royau.me>.
4000 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4002 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4003 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4004 of temacs in GUI mode.
4006 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4008 * window.h: Declare delete_all_child_windows instead of
4009 delete_all_subwindows.
4010 * window.c (Fwindow_nest, Fset_window_nest)
4011 (Fset_window_new_total, Fset_window_new_normal)
4012 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4013 (delete_all_subwindows): Rename to delete_all_child_windows.
4014 (Fdelete_other_windows_internal, Fset_window_configuration):
4015 Call delete_all_child_windows instead of delete_all_subwindows.
4016 * frame.c (delete_frame): Call delete_all_child_windows instead
4017 of delete_all_subwindows.
4019 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4021 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4022 This is also needed for porting to any host where GC_MARK_STACK is
4023 not GC_MAKE_GCPROS_NOOPS.
4024 (which_symbols): Use it.
4026 2011-11-07 Kenichi Handa <handa@m17n.org>
4028 * coding.c (coding_set_destination): Check coding->src_pos only
4029 when coding->src_object is a buffer (bug#9910).
4031 * process.c (send_process): Set the member src_multibyte of coding
4032 to 0 (bug#9911) when sending a unibyte text.
4034 * callproc.c (Fcall_process): Set the member src_multibyte of
4035 process_coding to 0 (bug#9912).
4037 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4039 * xmenu.c (cleanup_widget_value_tree): New function.
4040 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4041 calling free_menubar_widget_value_tree directly (Bug#9830).
4043 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4045 Fix some portability problems with 'inline'.
4046 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4047 (window_box_width, window_box_left, window_box_left_offset)
4048 (window_box_right, window_box_right_offset): Declare extern.
4049 Otherwise, these inline functions do not conform to C99 and
4050 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4051 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4052 * intervals.c (adjust_intervals_for_insertion)
4053 (adjust_intervals_for_deletion): Now extern, because otherwise the
4054 extern inline functions 'offset_intervals' couldn't refer to it.
4055 (static_offset_intervals): Remove.
4056 (offset_intervals): Rewrite using the old contents of
4057 static_offset_intervals. The old version didn't conform to C99
4058 because an extern inline function contained a reference to an
4059 identifier with static linkage.
4061 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4063 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4066 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4068 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4069 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4070 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4071 return Qleft_to_right.
4073 2011-11-06 Chong Yidong <cyd@gnu.org>
4075 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4076 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4077 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4078 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4079 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4080 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4081 (Fwindow_vscroll): Doc fix.
4082 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4083 argument, since it makes no sense to pass a live window and for
4084 consistency with window-child.
4086 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4088 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4091 2011-11-05 Jason Rumney <jasonr@gnu.org>
4093 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4094 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4096 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4097 bitwise arithmetic preventing use of unicode-sip and non-truetype
4100 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4102 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4105 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4106 initialization code to keep similarity to xfns.c after changes
4109 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4111 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4112 (unwind_create_frame): New function (Bug#9943).
4113 (Fx_create_frame): Restructure code to be more similar to the one in
4114 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4115 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4116 Move terminal->reference_count++ just before making the frame official
4119 * nsterm.m (x_free_frame_resources): New function.
4120 (x_destroy_window): Move code to x_free_frame_resources.
4122 * xfns.c (unwind_create_frame): Fix comment.
4123 (Fx_create_frame, x_create_tip_frame):
4124 Move terminal->reference_count++ just before making the frame
4125 official. Move initialization of image_cache_refcount and
4126 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4128 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4130 Support MSVC build with newer versions of Visual Studio.
4131 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4132 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4135 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4136 which are not supported by MSVC.
4137 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4138 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4140 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4142 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4144 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4146 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4148 Support MSVC build with newer versions of Visual Studio.
4149 * w32.c: Don't include w32api.h for MSVC.
4150 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4152 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4153 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4154 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4155 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4157 (alloca) [_MSC_VER]: Define to _alloca.
4159 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4161 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4163 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4165 * xdisp.c (note_mouse_highlight): If either of
4166 previous/next-single-property-change returns nil, treat that as
4167 the beginning or the end of the buffer. (Bug#9955)
4169 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4171 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4172 label is not null (Bug#9951).
4173 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4176 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4178 * window.c (Fwindow_body_size): Mention in the doc string that the
4179 return value is in frame's canonical units. (Bug#9949)
4181 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4183 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4185 * w32fns.c (unwind_create_frame): If needed, free the glyph
4186 matrices of the partially constructed frame. (Bug#9943)
4187 * xfns.c (unwind_create_frame): Likewise.
4189 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4191 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4192 Don't stop backward scan on the continuation glyph, even though
4193 its CHARPOS is positive.
4194 (mouse_face_from_buffer_pos, note_mouse_highlight):
4195 Rename cover_string to disp_string.
4197 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4199 * window.c (temp_output_buffer_show): Don't use
4200 Vtemp_buffer_show_specifiers.
4201 (Vtemp_buffer_show_specifiers): Remove unused variable.
4203 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4205 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4206 past the beginning of the current glyph matrix.
4208 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4210 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4211 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4212 HAVE_GTK3 (Bug#9869).
4214 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4215 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4217 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4219 * xterm.c: Declare x_handle_net_wm_state to return int.
4220 (handle_one_xevent): Check if we are iconified but don't have
4221 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4222 (get_current_wm_state): Return non-zero if not hidden,
4223 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4224 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4225 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4226 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4228 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4230 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4231 so that this new function doesn't get optimized away by a
4232 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4234 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4236 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4238 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4240 Fix the `xbytecode' command.
4241 * .gdbinit (xprintbytestr): New command.
4242 (xwhichsymbols): Rename from `which'; all callers changed.
4243 (xbytecode): Print the byte-code string as well.
4245 2011-10-29 Kim Storm <storm@cua.dk>
4247 * alloc.c (which_symbols): New function.
4249 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4251 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4254 2011-10-29 Glenn Morris <rgm@gnu.org>
4256 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4257 Not clear what it was for, and it causes various bugs. (Bug#9839)
4259 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4261 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4262 possible random value that matches one of those tested as
4263 condition to clear the mouse face.
4265 2011-10-28 Chong Yidong <cyd@gnu.org>
4267 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4269 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4271 * window.c (make_window): Initialize phys_cursor_on_p.
4273 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4275 * lisp.h (struct Lisp_Symbol): Update comments.
4277 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4279 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4281 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4283 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4284 <oslsachem@gmail.com> for helping to debug this.
4286 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4287 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4288 (g_b_init_get_glyph_outline_w): New static variables.
4289 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4290 (GetGlyphOutlineW_Proc): New typedefs.
4291 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4292 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4294 (w32font_open_internal, compute_metrics):
4295 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4296 instead of calling the "wide" APIs directly.
4298 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4300 * w32.h (syms_of_w32font): Add prototype.
4302 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4304 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4305 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4306 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4307 (Fmove_to_window_line): Doc fix.
4309 2011-10-27 Chong Yidong <cyd@gnu.org>
4311 * process.c (make_process): Set gnutls_state to NULL.
4313 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4314 non-NULL, regardless of GNUTLS_INITSTAGE.
4315 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4316 an error. Set process slots as soon as we allocate them.
4318 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4320 2011-10-27 Chong Yidong <cyd@gnu.org>
4322 * gnutls.c (emacs_gnutls_deinit): New function.
4323 Deallocate credentials structures as well as calling gnutls_deinit.
4324 (Fgnutls_deinit, Fgnutls_boot): Use it.
4326 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4327 (deactivate_process): Call emacs_gnutls_deinit.
4329 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4331 * image.c (x_create_x_image_and_pixmap):
4332 * w32.c (sys_rename, w32_delayed_load):
4333 * w32font.c (fill_in_logfont):
4334 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4336 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4338 * w32fns.c (w32_default_color_map): New function,
4339 extracted from Fw32_default_color_map.
4340 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4342 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4344 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4346 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4348 * keyboard.c (test_undefined): New function (bug#9751).
4349 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4351 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4353 * sysdep.c (init_sys_modes): Fix the check for the controlling
4354 terminal (Bug#6649).
4356 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4358 * dispextern.h (struct bidi_it): New member next_en_type.
4360 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4361 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4362 current character, check also for next_en_type being WEAK_EN.
4363 (bidi_resolve_weak): Don't enter the expensive loop if the current
4364 position is before next_en_pos. Record the bidi type of the first
4365 non-ET, non-BN character we find, in addition to its position.
4366 (bidi_level_of_next_char): Invalidate next_en_type when
4367 next_en_pos is over-stepped.
4369 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4371 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4372 * editfns.c: Rewrite current-time-zone so that it invokes
4373 the equivalent of (format-time-string "%Z") to get the time zone name.
4374 This fixes a bug when the time zone name contains characters that
4375 need converting from the system time locale to Emacs internal format.
4376 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4377 that patch fixed format-time-string to do the conversion, but
4378 I forgot to fix current-time-zone.
4379 (format_time_string): New function, containing most of
4380 what Fformat_time_string used to contain.
4381 (Fformat_time_string): Rewrite in terms of format_time_string.
4382 This doesn't change this function's behavior.
4383 (current-time-zone): Rewrite to use format_time_string.
4384 This fixes the bug reported by Michael Schierl in
4385 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4386 Jason Rumney's 2007-06-07 change worked around this bug, but
4388 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4390 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4392 * xdisp.c (start_display): If the character at POS is displayed
4393 via a display vector, reset IT->current.dpvec_index to zero.
4394 (try_window_reusing_current_matrix): If a line ends in a display
4395 vector or the next line starts in a display vector, continue
4396 redrawing the window even though the character position of
4397 start_row was reached.
4400 2011-10-18 Chong Yidong <cyd@gnu.org>
4402 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4403 with nobreak-char-display too.
4405 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4407 Fix part 3 of bug#9771.
4408 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4409 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4410 non-neutral characters if the current character is a paragraph
4411 separator (a.k.a. Newline). This avoids running the same
4412 expensive loop twice, once when we consume the preceding newline
4413 and the other time when the line actually needs to be displayed.
4414 Avoid the loop when we see neutrals on the base embedding level
4415 following a character whose directionality is the same as the
4416 paragraph's. This avoids running the expensive loop when a line
4417 ends in a long sequence of neutrals, like control characters.
4418 Add assertion against STRONG_AL type. Slightly rearrange code
4419 that determines the type of a neutral given the first non-neutral
4421 (bidi_level_of_next_char): Set next_en_pos to zero when
4422 invalidating its info.
4424 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4426 * xdisp.c (push_display_prop): Determine whether to record string
4427 or buffer position by IT->string, not by IT->method. Allow
4428 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4429 (move_it_vertically_backward): Don't look for character position
4430 immediately after the newline when in a continuation line.
4433 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4435 * window.c (coordinates_in_window): Rewrite and delabelize
4436 vertical border check. (Bug#5357) (Bug#9618)
4438 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4440 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4441 errors in XSetWindowBorder (bug#9310).
4443 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4445 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4446 avoid crash when xmalloc overrun checking is enabled.
4448 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4450 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4451 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4452 cursor motion with <left> and <right> arrow keys.
4454 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4455 some callers set that themselves.
4457 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4459 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4460 display string and the previous row comes from the same string and
4461 is empty. (Bug#9739) (Bug#9738)
4463 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4465 * doc.c (get_doc_string): Encode file name (bug#9735).
4467 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4469 * bidi.c (bidi_level_of_next_char):
4470 * xdisp.c (get_visually_first_element): Remove old incorrect
4471 comments regarding the Unicode Line Separator character.
4473 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4475 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4477 * alloc.c (Fgc_status): Do not access beyond zombies array
4478 boundary if nzombies > MAX_ZOMBIES.
4479 * alloc.c (dump_zombies): Add missing format specifier.
4481 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4483 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4484 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4486 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4487 Some packages use them to denote characters with modifiers.
4489 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4491 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4492 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4493 matching a pp-number. Rename parameter var to var1.
4495 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4497 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4499 2011-10-08 Glenn Morris <rgm@gnu.org>
4501 * callint.c (Fcall_interactively): Give a more explicit error for the
4502 'c' case with a non-character input. (Bug#8479)
4504 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4506 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4508 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4509 lines that are hscrolled on the left.
4511 * dispnew.c (buffer_posn_from_coords): Account for a possible
4512 presence of header-line. (Bug#4426)
4514 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4516 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4517 Don't advertise functionality which we discourage or doesn't work.
4519 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4521 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4522 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4523 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4524 this makes Emacs dump core during garbage collection on rare
4525 occasions. sizeof is obviously inferior to offsetof here, so
4526 stick with offsetof.
4527 (GC_POINTER_ALIGNMENT): New macro.
4528 (mark_memory): Omit 3rd (offset) arg; caller changed.
4529 Don't assume EMACS_INT alignment is the same as pointer alignment.
4531 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4533 * keyboard.c (read_key_sequence_remapped): New var.
4534 (read_key_sequence): Compute remapping in the right buffer.
4535 (command_loop_1): Use read_key_sequence's remapping directly.
4537 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4539 * dired.c (file_name_completion): Don't expand file name.
4540 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4541 before checking file name handler.
4543 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4544 they've been requested explicitly (bug#9591).
4546 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4548 * keymap.c (Fsingle_key_description): Use make_specified_string
4549 instead of build_string to build string from push_key_description.
4552 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4554 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4555 This fixes a Y2038 bug on 64-bit hosts.
4556 * buffer.c (reset_buffer):
4557 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4558 (Fclear_buffer_auto_save_failure):
4559 Use 0, not -1, to represent an unset failure time, since time_t
4560 might not be signed.
4562 Remove dependency on glibc malloc internals.
4563 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4564 Move back here from lisp.h, but with their new implementations.
4565 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4566 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4567 * charset.c (charset_table_init): New static var.
4568 (syms_of_charset): Use it instead of xmalloc. This removes a
4569 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4570 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4571 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4572 Move back to alloc.c.
4573 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4574 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4576 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4578 * nsterm.m (windowDidResize): Call x_set_window_size only when
4579 ns_in_resize is true. Otherwise set pixelwidth/height and
4580 call change_frame_size (Bug#9628).
4582 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4584 Port --enable-checking=all to Fedora 14 x86-64.
4585 * charset.c (syms_of_charset): Also account for glibc malloc's
4586 internal overhead when calculating the initial malloc maximum.
4588 Port --enable-checking=all to Fedora 14 x86.
4589 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4591 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4592 (overrun_check_realloc, overrun_check_free):
4593 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4594 That way, xmalloc returns a properly-aligned pointer even if
4595 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4596 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4597 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4598 into account when calculating the initial malloc maximum.
4599 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4600 Move here from alloc.c, so that charset.c can use it too.
4601 Properly align; the old code wasn't right for common 32-bit hosts
4602 when configured with --enable-checking=all.
4603 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4604 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4606 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4608 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4611 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4613 * xdisp.c (compute_display_string_end): If there's no display
4614 string at CHARPOS, return -1.
4616 * bidi.c (bidi_fetch_char): When compute_display_string_end
4617 returns a negative value, treat the character as a normal
4618 character not covered by a display string. (Bug#9624)
4620 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4622 * lread.c (Fread_from_string): Fix typo in docstring.
4624 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4626 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4627 newline, reseat the iterator instead of bidi-iterating there one
4628 character at a time. (Bug#9610)
4629 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4630 TO_CHARPOS if the bidi iterator is at base embedding level.
4632 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4634 * lread.c (readevalloop): Use correct code for NBSP.
4635 (read1): Likewise. (Bug#9608)
4637 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4639 * dbusbind.c (Fdbus_register_signal): When service is not
4640 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4642 2011-09-25 Glenn Morris <rgm@gnu.org>
4644 * buffer.c (truncate-lines): Doc fix.
4646 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4648 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4649 (Fset_window_next_buffers): Doc fix.
4651 2011-09-24 Glenn Morris <rgm@gnu.org>
4653 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4655 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4657 Fix minor problems found by static checking.
4658 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4659 * indent.c (Fvertical_motion): Fix == vs = typo.
4661 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4663 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4664 Default value is now t. Doc fix.
4666 * indent.c (Fvertical_motion): Compute and apply the overshoot
4667 logic when moving up, not only when moving down. Fix the
4668 confusing name and values of the it_overshoot_expected variable;
4669 logic changes accordingly. (Bug#9254) (Bug#9549)
4671 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4672 CHARPOS is covered by a display string which includes newlines.
4673 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4674 is covered by a display string with embedded newlines.
4676 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4678 * dbusbind.c (Fdbus_register_signal): Add match rule to
4679 Vdbus_registered_objects_table. (Bug#9581)
4680 (Fdbus_register_method, Vdbus_registered_objects_table):
4683 2011-09-24 Jim Meyering <meyering@redhat.com>
4685 do not ignore write error for any output size
4686 The previous change was incomplete.
4687 While it makes emacs --batch detect the vast majority of stdout
4688 write failures, errors were still ignored whenever the output size is
4689 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4690 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4691 && echo FAIL: ignored write error
4692 FAIL: ignored write error
4693 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4694 && echo FAIL: ignored write error
4695 FAIL: ignored write error
4696 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4698 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4700 * emacs.c (Fkill_emacs): In noninteractive mode exit
4701 non-successfully if a write error occurred on stdout. (Bug#9574)
4703 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4705 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4708 * dispextern.h (struct it): Update the comment documenting what
4711 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4713 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4714 a display string, extend search for cursor position to end of row.
4715 (find_row_edges): If the row ends in a newline from a display
4716 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4717 Handle the case of a display string with multiple newlines.
4718 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4719 non-empty line. Fixes confusing cursor motion with arrow keys at
4720 the beginning of a line that starts with whitespace.
4722 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4724 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4727 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4729 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4732 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4734 * xdisp.c (display_line): Record maximum and minimum buffer
4735 positions even if no glyphs were produced (e.g., by a zero-width
4736 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4737 buffer positions that will be removed from the glyph row because
4739 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4740 column is beyond frame width: don't subtract 1 "pixel" when
4741 computing width of the stretch.
4742 (reseat_at_next_visible_line_start): Undo the change made on
4743 2011-09-17 that saved paragraph information and restored it after
4744 the call to `reseat'. (Bug#9545)
4746 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4748 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4749 and turn window cursor on if cleared (Bug#9415).
4751 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4753 * search.c (boyer_moore): Take unibyte characters from pattern
4754 literally. (Bug#9458)
4756 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4758 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4760 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4762 Fix minor problem found by static checking.
4763 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4764 initialized, to pacify gcc -Wuninitialized.
4766 * fileio.c: Report proper errno when syscall falls.
4767 (Finsert_file_contents): Save and restore errno,
4768 so that report_file_error outputs the correct diagnostic.
4769 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4771 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4773 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4775 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4777 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4778 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4780 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4782 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4783 about the current paragraph and restore it after the call to reseat.
4785 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4786 (bidi_find_paragraph_start): Search back for paragraph beginning
4787 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4788 (bidi_move_to_visually_next): Only trigger paragraph-related
4789 computations when the last character is a newline or at EOB, not
4790 just any NEUTRAL_B. (Bug#9470)
4792 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4793 truncated lines if point is covered by a display string. (Bug#9524)
4795 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4797 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4798 (cons_to_x_long): New function.
4799 (lisp_data_to_selection_data): Use it. Correct the test for
4800 short-versus-long data; it was negated. Break out of vector
4801 loop, for efficiency, when a long datum is discovered.
4803 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4805 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4807 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4809 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4810 GCC PR/17406) by declaring this function with external scope.
4812 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4814 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4815 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4817 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4819 * editfns.c (Fformat): Correctly handle text properties on "%%".
4821 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4823 * xterm.c (x_draw_composite_glyph_string_foreground):
4824 * w32term.c (x_draw_composite_glyph_string_foreground):
4825 * term.c (encode_terminal_code):
4826 * composite.c (composition_update_it, get_composition_id):
4827 * xdisp.c (get_next_display_element)
4828 (fill_composite_glyph_string): Add comments about special meaning
4829 of TAB characters in a composition.
4831 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4833 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4834 This occurs when processing a multibyte format.
4835 Problem reported by Wolfgang Jenker.
4837 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4839 * xdisp.c (try_cursor_movement): Only check for exact match if
4840 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4842 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4844 Remove unused external symbols.
4845 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4846 * xdisp.c (calc_pixel_width_or_height): Now static.
4847 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4848 * indent.c (check_display_width):
4849 * w32term.c: Fix comment to match code.
4850 * xterm.c, xterm.h (x_catching_errors): Remove.
4852 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4854 * xselect.c: Use signed conversions more consistently (Bug#9498).
4855 (selection_data_to_lisp_data): Assume incoming selection data are
4856 signed integers, not unsigned. This is to be consistent with
4857 outgoing selection data, which was modified to use signed integers
4858 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4859 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4860 expects long, not unsigned long.
4862 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4864 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4865 computation of loop end. Reported by Johan Bockgård
4868 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4870 * frame.c (Fother_visible_frames_p): Function deleted.
4872 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4874 * indent.c (compute_motion): Process display vector front to back
4875 rather than the other way around. (Bug#2496)
4877 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4879 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4881 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4883 * minibuf.c (Fread_from_minibuffer): Doc fix.
4885 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4887 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4888 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4890 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4892 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4893 value for non-existent files.
4895 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4897 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4898 set its "size" to -1. This will set the modtime_size field of
4899 the corresponding buffer to -1, which is what
4900 verify-visited-file-modtime expects for files that do not exist.
4903 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4905 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4907 * lisp.h: ... from here. push_key_description is no longer
4908 defined in keyboard.c, so its declaration should not be in
4909 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4910 logically belongs with push_key_description.
4912 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4914 * buffer.h: Include <sys/types.h> instead of <time.h>.
4915 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4916 Problem reported by Herbert J. Skuhra.
4918 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4920 * xml.c (parse_region): Make the parsing work for
4921 non-comment-starting XML files again (bug#9144).
4923 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4925 * image.c (gif_load): Fix calculation of bottom and right corner.
4928 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4930 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4931 redisplay in small windows.
4933 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4935 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4937 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4939 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4940 Operate on live windows only.
4942 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4944 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4946 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4948 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4949 only under bidi iteration.
4951 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4953 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4955 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4957 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4958 Without this fix, the command to link temacs failed due to an
4959 undefined symbol __builtin_isnan. This is because
4960 /usr/include/iso/math_c99.h #defines isnan(x) to
4961 __builtin_isnan(x), but the bundled gcc, which identifies itself
4962 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4964 * floatfns.c (isnan): #undef, and then #define to a clone of
4966 (Fisnan): Always define, since it's always available now.
4967 (syms_of_floatfns): Always define isnan at the Lisp level.
4969 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4971 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4973 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4975 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4976 The previous code assumed that file offsets (off_t values) fit in
4977 EMACS_INT variables, which is not true on typical 32-bit hosts.
4978 The code messed up by falsely reporting buffer overflow in cases
4979 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4980 when "big" contains more than 2**29 bytes, even though this
4981 inserts just one byte and does not overflow the buffer.
4982 (Finsert_file_contents): Store file offsets as off_t
4983 values, not as EMACS_INT values. Check for overflow when
4984 converting between EMACS_INT and off_t. When checking for
4985 buffer overflow or for overlap, take the offsets into account.
4986 Don't use EMACS_INT for small values where int suffices.
4987 When checking for overlap, fix a typo: ZV was used where
4988 ZV_BYTE was intended.
4989 (Fwrite_region): Don't assume off_t fits into 'long'.
4990 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4992 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4994 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4996 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4998 sprintf-related integer and memory overflow issues (Bug#9412).
5000 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5001 (esprintf, exprintf, evxprintf): New functions.
5002 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5003 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5004 (modify_event_symbol): Do not assume that the length of
5005 name_alist_or_stem is safe to alloca and fits in int.
5006 (Fexecute_extended_command): Likewise for function name and binding.
5007 (Frecursion_depth): Wrap around reliably on integer overflow.
5008 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5009 since some callers pass EMACS_INT values.
5010 (Fsingle_key_description): Don't crash if symbol name contains more
5011 than MAX_ALLOCA bytes.
5012 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5013 (get_minibuffer): Arg is now EMACS_INT, not int.
5014 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5015 (esprintf, exprintf, evxprintf): New decls.
5016 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5018 * dbusbind.c (signature_cat): New function.
5019 (xd_signature, Fdbus_register_signal):
5020 Do not overrun buffer; instead, report string overflow.
5022 * dispnew.c (add_window_display_history): Don't overrun buffer.
5023 Truncate instead; this is OK since it's just a log.
5025 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5026 even if the time zone offset is outlandishly large.
5027 Don't mishandle offset == INT_MIN.
5029 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5030 when creating daemon; the previous buffer-overflow check was incorrect.
5032 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5033 which has the guts of the old verror function.
5035 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5036 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5038 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5039 (font_unparse_xlfd): Don't blindly alloca long strings.
5040 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5041 fits in int, when using sprintf. Use single snprintf to count
5042 length of string rather than counting it via multiple sprintfs;
5043 that's simpler and more reliable.
5044 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5045 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5046 sprintf, in case result does not fit in int.
5048 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5049 (fontset_from_font): Print it.
5051 * frame.c (tty_frame_count): Now printmax_t, not int.
5052 (make_terminal_frame, set_term_frame_name): Print it.
5053 (x_report_frame_params): In X, window IDs are unsigned long,
5054 not signed long, so print them as unsigned.
5055 (validate_x_resource_name): Check for implausibly long names,
5056 and don't assume name length fits in 'int'.
5057 (x_get_resource_string): Don't blindly alloca invocation name;
5058 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5061 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5062 (xg_check_special_colors, xg_set_geometry):
5063 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5065 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5066 Use esprintf, not sprintf, in case result does not fit in int.
5068 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5069 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5070 it as a large positive number.
5071 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5072 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5074 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5075 in case result does not fit in int.
5077 * print.c (float_to_string): Detect width overflow more reliably.
5078 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5079 buffer overrun. Don't assume list length fits in 'int'. Treat
5080 print length of 0 as 0, not as infinity; to be consistent with other
5081 uses of print length in this function. Don't overflow print length
5082 index. Don't assume hash table size fits in 'long', or that
5083 vectorlike size fits in 'unsigned long'.
5085 * process.c (make_process): Use printmax_t, not int, to format
5086 process-name gensyms.
5088 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5090 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5091 to avoid potential buffer overrun.
5093 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5094 if X resource line is longer than 512 bytes.
5096 * xfns.c (x_window): Make sprintf buffer a bit bigger
5097 to avoid potential buffer overrun.
5099 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5101 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5103 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5105 Integer overflow fixes for scrolling, etc.
5106 Without these, Emacs silently mishandles large integers sometimes.
5107 For example, "C-u 4294967297 M-x recenter" was treated as if
5108 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5110 * xdisp.c (try_window_id): Check Emacs fixnum range before
5111 converting to 'int'.
5113 * window.c (window_scroll_line_based, Frecenter):
5114 Check that an Emacs fixnum is in range before assigning it to 'int'.
5115 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5116 values converted from Emacs fixnums.
5117 (Frecenter): Don't wrap around a line count if it is out of 'int'
5118 range; instead, treat it as an extreme value.
5119 (Fset_window_configuration, compare_window_configurations):
5120 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5122 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5123 that can exceed INT_MAX. Check that EMACS_INT value is in range
5124 before assigning it to the (possibly-narrower) index.
5125 (match_limit): Don't assume that a fixnum can fit in 'int'.
5127 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5130 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5131 (Fvertical_motion): Don't wrap around LINES values that don't fit
5132 in 'int'. Instead, treat them as extreme values. This is good
5133 enough for windows, which can't have more than INT_MAX lines anyway.
5135 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5137 * Require libxml/parser.h to avoid compilation warning.
5139 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5141 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5142 since this reportedly can destroy thread storage.
5144 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5146 * syntax.c (find_defun_start): Update all cache variables if
5147 exiting early (Bug#9401).
5149 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5151 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5153 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5154 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5155 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5157 * term.c (tty_append_glyph): New function.
5158 (produce_stretch_glyph): Static function and its prototype deleted.
5160 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5163 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5165 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5166 when checking :margin (Bug#9390).
5167 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5168 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5169 so that the name doesn't mislead. All uses changed.
5171 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5173 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5176 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5178 * xdisp.c (move_it_to): Don't bail out early when reaching
5179 position beyond to_charpos, if we are scanning backwards.
5180 (move_it_vertically_backward): When DY == 0, make sure we get to
5181 the first character in the line after the newline.
5183 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5185 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5186 (ccl_driver): Do not generate an out-of-range pointer.
5187 (Fccl_execute_on_string): Remove unnecessary check for
5188 integer overflow, noted by Stefan Monnier in
5189 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5190 Remove a FIXME that didn't need fixing.
5191 Simplify the newly-introduced buffer reallocation code.
5193 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5195 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5197 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5199 Integer and memory overflow issues (Bug#9196).
5201 * doc.c (get_doc_string): Rework so that
5202 get_doc_string_buffer_size is the actual buffer size, rather than
5203 being 1 less than the actual buffer size; this makes xpalloc more
5206 * image.c (x_allocate_bitmap_record, cache_image):
5207 * xselect.c (Fx_register_dnd_atom):
5208 Simplify previous changes by using xpalloc.
5210 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5211 since either will do and ptrdiff_t is convenient with xpalloc.
5213 * charset.c (charset_table_size)
5214 (struct charset_sort_data.priority): Now ptrdiff_t.
5215 (charset_compare): Don't overflow if priorities differ greatly.
5216 (Fsort_charsets): Don't assume list length fits in int.
5217 Check for size-calculation overflow when allocating sort data.
5218 (syms_of_charset): Allocate an initial charset table that is
5219 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5221 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5223 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5224 The actual value is always <= INT_MAX, and leaving it unsigned made
5225 overflow checking harder.
5227 * dispextern.h (struct glyph_matrix.rows_allocated)
5228 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5229 with xpalloc. The values are still always <= INT_MAX.
5231 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5233 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5234 (SAFE_NALLOCA): New macro.
5236 * region-cache.c (struct boundary.pos, find_cache_boundary)
5237 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5238 (set_cache_region, invalidate_region_cache)
5239 (revalidate_region_cache, know_region_cache, region_cache_forward)
5240 (region_cache_backward, pp_cache):
5241 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5242 so that ptrdiff_t * can be passed to xpalloc.
5243 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5244 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5245 (pp_cache): Don't assume cache_len fits in int.
5246 * region-cache.h: Adjust extern decls to match.
5248 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5249 EMACS_INT, since either will do, for xpalloc.
5251 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5252 (xnmalloc, xnrealloc, xpalloc): New functions.
5254 * bidi.c (bidi_shelve_header_size): New constant.
5255 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5256 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5258 * bidi.c (bidi_cache_shrink):
5259 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5261 Don't update size of array until after memory allocation succeeds,
5262 because xmalloc/xrealloc may not return.
5263 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5264 now that we have proper integer overflow checking.
5265 (record_overlay_string, overlay_strings): Catch overflows when
5266 calculating size of overlay_str_buf.
5268 * callproc.c (Fcall_process): Check for size overflow when
5269 calculating size of args2.
5270 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5271 Normally we prefer signed values, but sticking with ptrdiff_t would
5272 require adding more-complicated checks.
5274 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5275 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5276 Redo buffer-overflow calculations to avoid integer overflow.
5277 Add a FIXME comment where memory seems to be over-allocated.
5279 * character.c (Fstring): Check for size-calculation overflow.
5281 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5282 unnecessary integer overflow. Check for size overflow.
5283 (encode_coding_object): Don't update size until xmalloc succeeds.
5285 * composite.c (get_composition_id): Check for overflow in glyph
5286 length calculations.
5288 Integer and memory overflow fixes for display code.
5289 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5290 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5291 (scrolling_window): Check for overflow in size calculations.
5292 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5293 Don't assume glyph table len fits in int.
5294 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5295 (row_table_size): Now ptrdiff_t, not int.
5296 (scrolling_window): Avoid overflow in size calculations.
5297 Don't update size until allocation succeeds.
5298 * fns.c (concat): Check for overflow in size calculations.
5299 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5300 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5301 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5303 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5304 (get_doc_string): Check for size calculation overflow.
5305 Don't update size until allocation succeeds.
5306 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5307 EMACS_INT, where ptrdiff_t will do.
5308 (Fsubstitute_command_keys): Check for string overflow.
5310 * editfns.c (set_time_zone_rule): Don't assume environment length
5312 (message_length): Now ptrdiff_t, not int.
5313 (Fmessage_box): Don't update size until allocation succeeds.
5314 Don't assume message length fits in int.
5315 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5317 * emacs.c (main): Do not reallocate argv, since there is a null at
5318 the end that can be overwritten, and this way there's no need to
5319 worry about size-calculation overflow.
5320 (sort_args): Check for size-calculation overflow.
5322 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5324 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5326 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5327 (x_set_scroll_bar_width, x_figure_window_size):
5328 Check for integer overflow.
5329 (x_set_alpha): Do not assume XINT fits in int.
5331 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5332 This is for the members text_lines, text_cols, total_lines, total_cols,
5333 where the system imposes an 'int' limit.
5335 * fringe.c (Fdefine_fringe_bitmap):
5336 Don't update size until alloc works.
5338 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5339 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5341 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5342 Check for size-calculation overflow.
5343 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5344 do, as we prefer signed integers.
5345 (id_to_widget.max_size, id_to_widget.used)
5346 (xg_store_widget_in_map, xg_remove_widget_from_map)
5347 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5348 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5349 Use and return ptrdiff_t, not int.
5350 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5351 * gtkutil.h: Change prototypes to match the above.
5353 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5354 are duplicate now that they've been promoted to lisp.h.
5355 (x_allocate_bitmap_record, x_alloc_image_color)
5356 (make_image_cache, cache_image, xpm_load):
5357 Don't update size until alloc is done.
5358 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5360 Check for size calculation overflow.
5361 (ct_colors_allocated_max): New constant.
5362 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5365 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5366 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5367 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5368 Use ptrdiff_t, not int, to count maps.
5369 (read_char_minibuf_menu_prompt): Check for overflow in size
5370 calculations. Don't update size until allocation succeeds.
5371 Redo calculations to avoid overflow.
5372 * keyboard.h: Change prototypes to match the above.
5374 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5376 (current_minor_maps): Check for size calculation overflow.
5377 * keymap.h: Change prototypes to match the above.
5379 * lread.c (read1, init_obarray): Don't update size until alloc done.
5381 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5382 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5384 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5385 Now ptrdiff_t, not int.
5386 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5387 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5389 * process.c (Fnetwork_interface_list): Check for overflow
5390 in size calculation.
5392 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5394 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5395 overflow. Don't bother calling xmalloc when xrealloc will do.
5397 * search.c (Freplace_match): Check for size calculation overflow.
5398 (Fset_match_data): Don't assume list lengths fit in 'int'.
5400 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5401 for command line length. Do not attempt to address one before the
5402 beginning of an array, as that's not portable.
5404 * term.c (max_frame_lines): Remove; unused.
5405 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5407 (encode_terminal_code, calculate_costs): Check for size
5408 calculation overflow.
5409 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5410 table lengths and related sizes. Don't update size until alloc
5411 done. Redo calculations to avoid overflow.
5412 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5414 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5415 subtracting pointers.
5416 (gobble_line): Check for overflow more carefully. Don't update size
5419 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5420 Don't update size until alloc done.
5421 Redo size calculations to avoid overflow.
5422 Check for size calculation overflow.
5423 (main) [DEBUG]: Fix typo in invoking tparam1.
5425 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5426 Use ptrdiff_t, not int, for sizes.
5427 (store_mode_line_noprop_char): Don't update size until alloc done.
5429 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5430 Use ptrdiff_t, not int, for sizes.
5431 (Finternal_make_lisp_face, cache_face):
5432 Check for size calculation overflow.
5433 (cache_face): Treat size calculation overflows as if they were
5434 memory exhaustion (the usual treatment), rather than aborting.
5436 * xfns.c (x_encode_text, x_set_name_internal)
5437 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5438 sizes, since they can exceed INT_MAX in size. Check for size
5439 calculation overflow.
5441 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5442 (xg_select): Check for size calculation overflow.
5443 Don't update size until alloc done.
5445 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5446 as sprintf is limited to int lengths.
5448 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5449 (X_LONG_MIN): New macros.
5450 Use them to make the following changes clearer.
5451 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5452 This change doesn't affect the value now, but it may help remind
5453 future maintainers not to raise the value too much later.
5454 (SELECTION_QUANTUM): Remove, replacing with ...
5455 (selection_quantum): ... new function, which avoids overflow.
5457 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5458 assumption that selection length fits in 'int'.
5459 (x_reply_selection_request, x_handle_selection_request)
5460 (x_get_window_property, receive_incremental_selection)
5461 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5462 (lisp_data_to_selection_data, clean_local_selection_data):
5463 Use ptrdiff_t, not int, to record length of selection.
5464 (x_reply_selection_request, x_get_window_property)
5465 (receive_incremental_selection, x_property_data_to_lisp):
5466 Redo calculations to avoid overflow.
5467 (x_reply_selection_request): When sending hint, ceiling it at
5468 X_LONG_MAX rather than relying on wraparound overflow to send
5470 (x_get_window_property, receive_incremental_selection)
5471 (lisp_data_to_selection_data, x_property_data_to_lisp):
5472 Check for size-calculation overflow.
5473 (x_get_window_property, receive_incremental_selection)
5474 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5475 Don't store size until memory allocation succeeds.
5476 (x_get_window_property): Plug memory leak on memory exhaustion.
5477 Don't double-block input; malloc is safe here. Don't assume 2**34
5478 - 4 fits in unsigned long. Add an xassert to check
5479 XGetWindowProperty overflow. Be more careful about overflow
5480 calculations, and distinguish size from memory overflow better.
5481 (receive_incremental_selection): When tracing, don't assume
5482 unsigned int is less than INT_MAX.
5483 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5484 harmful) conversions of unsigned short to int.
5485 (lisp_data_to_selection_data): Don't assume that integers
5486 in the range -65535 through -1 fit in an X unsigned short.
5487 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5488 result parameters unless successful. Rely on cons_to_unsigned
5489 to report problems with elements; the old code wasn't right anyway.
5490 (x_check_property_data): Check for int overflow; we cannot use
5491 a wider type due to X limits.
5492 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5494 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5496 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5497 (x_term_init): Check for size calculation overflow.
5498 (x_color_cells): Don't store size until memory allocation succeeds.
5499 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5500 Don't assume alloca size is less than MAX_ALLOCA.
5501 (x_term_init): Don't assume length fits in int (sprintf is limited
5504 Use ptrdiff_t for composition IDs.
5505 * character.c (lisp_string_width):
5506 * composite.c (composition_table_size, n_compositions)
5507 (get_composition_id, composition_gstring_from_id):
5508 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5509 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5510 * window.c (Frecenter):
5511 Use ptrdiff_t, not int, for composition IDs.
5512 * composite.c (get_composition_id): Check for integer overflow.
5513 * composite.h: Adjust prototypes to match the above changes.
5515 Use ptrdiff_t for hash table indexes.
5516 * category.c (hash_get_category_set):
5517 * ccl.c (ccl_driver):
5518 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5519 * coding.c (coding_system_charset_list, detect_coding_system):
5520 * coding.h (struct coding_system.id):
5521 * composite.c (get_composition_id, gstring_lookup_cache):
5522 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5523 * image.c (xpm_get_color_table_h):
5524 * lisp.h (hash_lookup, hash_put):
5525 * minibuf.c (Ftest_completion):
5526 Use ptrdiff_t for hash table indexes, not int (which is too
5527 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5528 32-bit --with-wide-int hosts).
5530 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5531 Add a FIXME comment about memory leaks.
5532 (syms_of_charset): Don't assume xmalloc returns.
5534 Don't assume that stated character widths fit in int.
5535 * character.c (Fchar_width, c_string_width, lisp_string_width):
5536 * character.h (CHAR_WIDTH):
5537 * indent.c (MULTIBYTE_BYTES_WIDTH):
5538 Use sanitize_char_width to avoid undefined and/or bad behavior
5539 with outlandish widths.
5540 * character.h (sanitize_tab_width): Rename from sanitize_width,
5541 now that we have two such functions. All uses changed.
5542 (sanitize_char_width): New inline function.
5544 Don't assume that tab-width fits in int.
5545 * character.h (sanitize_width): New inline function.
5546 (SANE_TAB_WIDTH): New macro.
5547 (ASCII_CHAR_WIDTH): Use it.
5548 * indent.c (sane_tab_width): Remove. All uses replaced by
5549 SANE_TAB_WIDTH (current_buffer).
5550 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5552 * fileio.c: Integer overflow issues with file modes.
5553 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5555 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5556 Remove unreachable code.
5557 (read_hex, load_charset_map_from_file): Check for integer overflow.
5559 * xterm.c: Don't go over XClientMessageEvent limit.
5560 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5561 (x_send_scroll_bar_event): Likewise. Check that the size does not
5562 exceed limits imposed by XClientMessageEvent, as well as the usual
5563 ptrdiff_t and size_t limits.
5565 * keyboard.c: Overflow, signedness and related fixes.
5566 (make_lispy_movement): Use same integer type in forward decl
5567 that is used in the definition.
5568 (read_key_sequence, keyremap_step):
5569 Change bufsize argument back to int, undoing my 2011-03-30 change.
5570 We prefer signed types, and int is wide enough here.
5571 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5572 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5573 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5574 length, not size_t. Use ptrdiff_t for index, not int.
5575 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5576 possibility of integer overflow.
5578 Overflow, signedness and related fixes for images.
5580 * dispextern.h (struct it.stack[0].u.image.image_id)
5581 (struct_it.image_id, struct image.id, struct image_cache.size)
5582 (struct image_cache.used, struct image_cache.ref_count):
5583 * gtkutil.c (update_frame_tool_bar):
5584 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5585 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5586 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5587 * nsmenu.m (update_frame_tool_bar):
5588 * xdisp.c (calc_pixel_width_or_height):
5589 * xfns.c (image_cache_refcount):
5590 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5591 on typical 64-bit hosts.
5593 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5594 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5595 Omit unnecessary casts to int.
5596 (parse_image_spec): Check that integers fall into 'int' range
5597 when the callers expect that.
5598 (image_ascent): Redo ascent calculation to avoid int overflow.
5599 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5600 (lookup_image): Remove unnecessary tests.
5601 (xbm_image_p): Locals are now of int, not EMACS_INT,
5602 since parse_image_check makes sure they fit into int.
5603 (png_load, gif_load, svg_load_image):
5604 Prefer int to unsigned where either will do.
5605 (tiff_handler): New function, combining the cores of the
5606 old tiff_error_handler and tiff_warning_handler.
5607 This function is rewritten to use vsnprintf and thereby avoid
5608 stack buffer overflows. It uses only the features of vsnprintf
5609 that are common to both POSIX and native Microsoft.
5610 (tiff_error_handler, tiff_warning_handler): Use it.
5611 (tiff_load, gif_load, imagemagick_load_image):
5612 Don't assume :index value fits in 'int'.
5613 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5614 (imagemagick_load_image): Check that crop parameters fit into
5615 the integer types that MagickCropImage accepts. Don't assume
5616 Vimagemagick_render_type has a nonnegative value. Don't assume
5617 size_t fits in 'long'.
5618 (gs_load): Use printmax_t to print the widest integers possible.
5619 Check for integer overflow when computing image height and width.
5621 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5623 * xdisp.c (redisplay_window): Don't force window start if point
5624 will be invisible in the resulting window. (Bug#9324)
5626 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5628 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5629 the display spec is of the form `(space ...)'.
5630 (handle_display_spec): Return the value returned by
5631 handle_single_display_spec, not just 1 or zero.
5632 (handle_single_display_spec): If the display spec is of the form
5633 `(space ...)', and specifies display in the text area, return 2
5635 (try_cursor_movement): Check for the need to scroll more
5636 accurately, and prefer exact match for point under bidi.
5637 Don't advance `row' beyond the last row of the window.
5639 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5640 into disp_prop; all users changed.
5642 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5643 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5644 for the text covered by the display property.
5646 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5648 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5649 Change return value to nil.
5650 (Frecord_buffer): Delete unused function.
5652 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5654 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5655 buffers, return left-to-right.
5656 (set_cursor_from_row): Consider candidate row a win if its glyph
5657 represents a newline and point is on that newline. Fixes cursor
5658 positioning on the newline at EOL of R2L text within L2R
5659 paragraph, and vice versa.
5660 (try_cursor_movement): Check continued rows, in addition to
5661 continuation rows. Fixes unwarranted scroll when point enters a
5662 continued line of R2L text within an L2R paragraph, or vice versa.
5663 (cursor_row_p): Consider the case of point being equal to
5664 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5665 from the end of a short line to the beginning of a continued line
5666 of R2L text within L2R paragraph.
5667 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5668 composed characters.
5670 * bidi.c (bidi_check_type): Use xassert.
5671 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5674 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5676 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5679 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5681 * nsfont.m (ns_otf_to_script): Fix typo.
5683 2011-08-22 Kenichi Handa <handa@m17n.org>
5685 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5686 extra slot even if the purpose is char-code-property-table.
5688 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5690 * xdisp.c (redisplay_window): When computing centering_position,
5691 account for the height of the header line. (Bug#8874)
5693 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5694 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5695 candidate is selected by the mouse, and that candidate has a
5696 composed character under the mouse.
5698 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5699 coordinates reported by pos-visible-in-window-p for a composed
5700 character in column zero.
5702 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5704 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5706 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5708 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5709 consider it a hit if to_charpos is anywhere in the range of the
5710 composed buffer positions.
5712 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5714 * image.c (gif_load): Don't assume that each subimage has the same
5715 dimensions as the base image. Handle disposal method that is
5716 "undefined" by the gif spec (Bug#9335).
5718 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5720 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5721 (Fcondition_case): Document `debug' symbol in error handler.
5723 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5725 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5726 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5727 from an Org mode buffer to a Speedbar frame.
5729 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5730 a composition, take its buffer position from IT->cmp_it.charpos.
5731 Fixes cursor positioning at the beginning of a line that begins
5732 with a composed character.
5734 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5736 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5737 character bidirectional type, use STRONG_L instead. Fixes crashes
5738 in a buffer produced by `describe-categories'.
5740 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5741 members before the level stack, so they would be saved and
5742 restored when copying iterator state. Fixes incorrect reordering
5743 around TABs covered by display properties.
5745 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5747 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5749 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5751 * eval.c (internal_condition_case, internal_condition_case_1)
5752 (internal_condition_case_2, internal_condition_case_n):
5753 Remove unnecessary aborts (Bug#9081).
5755 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5757 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5758 has no `load' handler, try opening the file locally. (Bug#9311)
5760 2011-08-16 Ken Brown <kbrown@cornell.edu>
5762 * gmalloc.c: Expand comment.
5764 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5766 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5767 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5769 2011-08-16 Ken Brown <kbrown@cornell.edu>
5771 Fix memory allocation problems in Cygwin build (Bug#9273).
5773 * unexcw.c ( __malloc_initialized): Declare external variable.
5774 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5776 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5778 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5780 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5782 [CYGWIN] (special_realloc): New function.
5783 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5784 requests to realloc storage in the static heap.
5786 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5788 * bidi.c (bidi_initialize): Remove unused local.
5790 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5793 * biditype.h: Remove file.
5794 * makefile.w32-in ($(BLD)/bidi.$(O)):
5795 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5797 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5799 * chartab.c: Improve commentary for the uniprop_table API.
5801 * bidi.c (bidi_paragraph_init): Support zero value of
5802 bidi_ignore_explicit_marks_for_paragraph_level.
5803 (bidi_initialize): Use uniprop_table instead of including
5804 biditype.h and bidimirror.h.
5806 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5807 coordinates of the iterator when restoring from ppos_it.
5810 2011-08-14 Kenichi Handa <handa@m17n.org>
5812 * process.c (create_process): Call setup_process_coding_systems
5813 after the pid of the process is set to -1 (Bug#8162).
5815 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5817 * xdisp.c (move_it_in_display_line_to): Don't invoke
5818 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5819 ppos_it. Fixes vertical cursor motion when line beginning is
5820 covered by an image. (Bug#9296)
5822 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5824 * nsterm.h (ns_run_ascript): Declare.
5825 (NSAPP_DATA2_RUNASSCRIPT): Define.
5827 * nsfns.m (as_script, as_result, as_status): New static variables.
5828 (ns_run_ascript): New function.
5829 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5830 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5831 the event loop. Get status from as_status (Bug#7276).
5833 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5834 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5835 the event loop (Bug#7276).
5837 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5839 * gnutls.c (QCgnutls_bootprop_priority)
5840 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5841 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5842 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5843 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5844 (QCgnutls_bootprop_verify_hostname_error)
5845 (QCgnutls_bootprop_callbacks_verify): Rename from
5846 Qgnutls_bootprop_..., all uses changed.
5848 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5851 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5853 * xfaces.c (Qframe_set_background_mode): Now static.
5854 * dispextern.h (Qframe_set_background_mode): Remove decl.
5856 * process.c (Fnetwork_interface_info): Declare local only if needed.
5858 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5860 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5861 (Fnetwork_interface_list): Allocate in increments of bytes instead
5862 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5863 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5865 (struct ifflag_def): notrailers is smart on OSX.
5866 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5867 Get hardware address with getifaddrs if available.
5869 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5871 * xdisp.c (iterate_out_of_display_property): xassert that
5872 IT->position is set to within IT->object's boundaries. Break from
5873 the loop as soon as EOB is reached; avoids infloops in redisplay
5874 when IT->position is set up wrongly due to some bug.
5875 Set IT->current to match the bidi iterator unconditionally.
5876 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5877 entry. Force push_it to save on the stack the current
5878 buffer/string position, to be restored by pop_it. Fix flags in
5879 the iterator structure wrt the object coming from a display
5880 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5881 properties. (Bug#9284)
5883 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5885 * fontset.c (fontset_get_font_group): Add proper type checks.
5888 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5890 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5891 and LC_VERSION_MIN_MACOSX.
5892 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5893 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5895 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5897 * xdisp.c (forward_to_next_line_start): Allow to use the
5898 no-display-properties-and-no-overlays under bidi display.
5899 Set disp_pos in the bidi iterator to avoid searches for display
5900 properties and overlays.
5902 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5904 * editfns.c (Fset_time_zone_rule): Document relationship with the
5907 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5908 the font entity extracted from the cache (Bug#8109).
5910 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5912 * composite.c (autocmp_chars): Don't reset point. That is done by
5913 restore_point_unwind (Bug#5984).
5915 2011-08-07 Juri Linkov <juri@jurta.org>
5917 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5918 to show the arg `TIME' instead of `TIMEVAL'.
5920 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5922 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5923 display property strides EOL and includes a newline, as in
5924 longlines-mode. (Bug#9254)
5925 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5926 word-wrap under bidirectional display. (Bug#9224)
5928 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5929 is non-zero, even if the data buffer is NULL. Fixes a crash in
5930 vertical-motion with longlines-mode. (Bug#9254)
5932 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5934 * bidi.c <bidi_cache_total_alloc>: Now static.
5935 (bidi_initialize): Initialize bidi_cache_total_alloc.
5937 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5940 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5941 amount allocated this far in `bidi_cache_total_alloc'.
5942 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5943 non-zero, only free the data buffer without restoring the cache
5944 contents. All callers changed.
5946 * dispextern.h (bidi_unshelve_cache): Update prototype.
5948 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5949 (move_it_in_display_line, move_it_to)
5950 (move_it_vertically_backward, move_it_by_lines): Replace the call
5951 to xfree to an equivalent call to bidi_unshelve_cache.
5952 (move_it_in_display_line_to): Fix logic of returning
5953 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5955 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5957 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5958 came from a string character with a `cursor' property. (Bug#9229)
5960 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5962 * Makefile.in (LIB_PTHREAD): New variable.
5963 (LIBES): Add LIB_PTHREAD (Bug#9216).
5965 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5966 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5968 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5970 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5972 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5974 * xterm.c (x_find_topmost_parent): New function.
5975 (x_set_frame_alpha): Find topmost parent window with
5976 x_find_topmost_parent and set the property there also (bug#9181).
5977 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5979 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5981 * callproc.c (Fcall_process): Avoid vfork clobbering
5982 the local vars buffer, coding_systems, current_dir.
5984 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5986 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5988 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5990 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5991 so that it is not optimized away.
5993 * xdisp.c (compute_display_string_pos): Remove unused local.
5995 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5997 Fix slow cursor motion and scrolling in large buffers with
5998 selective display, like Org Mode buffers. (Bug#9218)
6000 * dispextern.h (struct bidi_it): New member disp_prop_p.
6002 * xdisp.c: Remove one-slot cache of display string positions.
6003 (compute_display_string_pos): Accept an additional argument
6004 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6005 for a display string or property. If found, set DISP_PROP_P
6008 * bidi.c (bidi_fetch_char): Accept an additional argument
6009 DISP_PROP_P, and pass it to compute_display_string_pos.
6010 Only handle text covered by a display string if DISP_PROP_P is returned
6011 non-zero. All callers of bidi_fetch_char changed.
6013 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6015 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6017 2010-12-03 Don March <don@ohspite.net>
6019 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6020 last character M-[char] is translated to ESC [char] (bug#7541).
6022 2011-08-02 Kenichi Handa <handa@m17n.org>
6024 * lisp.h (uniprop_table): Extern it.
6026 * chartab.c (uniprop_table): Make it non-static.
6028 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6030 * xdisp.c (forward_to_next_line_start): Accept additional argument
6031 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6033 (reseat_at_next_visible_line_start): Use the bidi iterator state
6034 returned by forward_to_next_line_start to restore the state of
6035 it->bidi_it after backing up to previous newline. (Bug#9212)
6037 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6039 * regex.c (re_comp): Protoize.
6040 (re_exec): Fix return type.
6041 (regexec): Fix type of `ret'. (Bug#9203)
6043 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6045 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6046 This is needed if max-image-size is a floating-point number.
6048 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6050 * print.c (print_object): Print empty symbol as ##.
6052 * lread.c (read1): Read ## as empty symbol.
6054 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6056 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6057 setting frame foreground color (Bug#9175).
6058 (x_set_background_color): Likewise.
6060 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6061 contents (Bug#9176).
6062 (EmacsTooltip -init): Remove bezels and add shadows to
6065 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6066 or scroll bar (Bug#8470).
6068 * nsfont.m (nsfont_open): Remove assignment to voffset and
6069 unnecessary vars hshink, expand, hd, full_height, min_height.
6070 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6072 * nsterm.h (nsfont_info): Remove voffset field.
6074 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6076 Implement strike-through and overline on NextStep (Bug#8863).
6078 * nsfont.m (nsfont_open): Use underline position provided by font,
6079 instead of hard-coded value of 2.
6080 (nsfont_draw): Call ns_draw_text_decoration instead.
6082 * nsterm.h: Add declaration for ns_draw_text_decoration.
6084 * nsterm.m (ns_draw_text_decoration): New function for drawing
6085 underline, overline, and strike-through.
6086 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6087 ns_draw_text_decoration. Change treatment of cursor drawing to
6088 accommodate underlining, etc.
6090 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6092 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6095 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6097 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6098 Without this fix, if a signal arrives just after memory fills up,
6099 'malloc' might be invoked reentrantly.
6101 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6102 In other words, assume that every image size is allowed, on non-X
6103 hosts. This assumption is probably wrong, but it lets Emacs compile.
6105 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6107 * regex.c (re_iswctype): Convert return values to boolean.
6109 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6111 * xdisp.c (compute_display_string_pos): Don't use cached display
6112 string position if the buffer had its restriction changed.
6115 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6117 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6119 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6121 Integer signedness and overflow and related fixes. (Bug#9079)
6123 * bidi.c: Integer size and overflow fixes.
6124 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6125 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6126 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6127 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6128 (bidi_find_other_level_edge):
6129 Use ptrdiff_t instead of EMACS_INT where either will do.
6130 This works better on 32-bit hosts configured --with-wide-int.
6131 (bidi_cache_ensure_space): Check for size-calculation overflow.
6132 Use % rather than repeated addition, for better worst-case speed.
6133 Don't set bidi_cache_size until after xrealloc returns, because it
6135 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6136 (bidi_cache_ensure_space): Also check that the bidi cache size
6137 does not exceed that of the largest Lisp string or buffer. See Eli
6138 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6140 * alloc.c (__malloc_size_t): Remove.
6141 All uses replaced by size_t. See Andreas Schwab's note
6142 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6144 * image.c: Improve checking for integer overflow.
6145 (check_image_size): Assume that f is nonnull, since
6146 it is always nonnull in practice. This is one less thing to
6147 worry about when checking for integer overflow later.
6148 (x_check_image_size): New function, which checks for integer
6149 overflow issues inside X.
6150 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6151 This removes the need for a memory_full check.
6152 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6153 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6154 (xbm_read_bitmap_data): Change locals back to 'int', since
6155 their values must fit in 'int'.
6156 (xpm_load_image, png_load, tiff_load):
6157 Invoke x_create_x_image_and_pixmap earlier,
6158 to avoid much needless work if the image is too large.
6159 (tiff_load): Treat overly large images as if
6160 x_create_x_image_and_pixmap failed, not as malloc failures.
6161 (gs_load): Use x_check_image_size.
6163 * gtkutil.c: Omit integer casts.
6164 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6165 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6167 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6169 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6170 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6171 would wrongly return t on a 64-bit host.
6173 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6174 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6175 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6176 and therefore cause GCC to emit a bogus diagnostic in some cases.
6178 * image.c: Integer signedness and overflow and related fixes.
6179 This is not an exhaustive set of fixes, but it's time to
6180 record what I've got.
6181 (lookup_pixel_color, check_image_size): Remove redundant decls.
6182 (check_image_size): Don't assume that arbitrary EMACS_INT values
6183 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6184 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6185 (tiff_load, imagemagick_load_image):
6186 Check for overflow in size calculations.
6187 (x_create_x_image_and_pixmap): Remove unnecessary test for
6188 xmalloc returning NULL; that can't happen.
6189 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6190 (xpm_color_bucket): Use better integer hashing function.
6191 (xpm_cache_color): Don't possibly over-allocate memory.
6192 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6193 (gif_memory_source):
6194 Use ptrdiff_t, not int or size_t, to record sizes.
6195 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6196 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6197 either works, as we prefer signed integers.
6198 (tiff_read_from_memory, tiff_write_from_memory):
6199 Return tsize_t, not size_t, since that's what the TIFF API wants.
6200 (tiff_read_from_memory): Don't fail simply because the read would
6201 go past EOF; instead, return a short read.
6202 (tiff_load): Omit no-longer-needed casts.
6203 (Fimagemagick_types): Don't assume size fits into 'int'.
6205 Improve hashing quality when configured --with-wide-int.
6206 * fns.c (hash_string): New function, taken from sxhash_string.
6207 Do not discard information about ASCII character case; this
6208 discarding is no longer needed.
6209 (sxhash-string): Use it. Change sig to match it. Caller changed.
6210 * lisp.h: Declare it.
6211 * lread.c (hash_string): Remove, since we now use fns.c's version.
6212 The fns.c version returns a wider integer if --with-wide-int is
6213 specified, so this should help the quality of the hashing a bit.
6215 * emacs.c: Integer overflow minor fix.
6216 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6217 Define only if GNU_LINUX.
6218 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6220 * dispnew.c: Integer signedness and overflow fixes.
6221 Remove unnecessary forward decls, that were a maintenance hassle.
6222 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6224 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6225 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6226 (prepare_desired_row, line_draw_cost):
6227 Use int, not unsigned, where either works.
6228 (save_current_matrix, restore_current_matrix):
6229 Use ptrdiff_t, not size_t, where either works.
6230 (init_display): Check for overflow more accurately, and without
6231 relying on undefined behavior.
6233 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6234 Remove, replacing with the new symbols in lisp.h. All uses changed.
6235 * fileio.c (make_temp_name):
6236 * filelock.c (lock_file_1, lock_file):
6237 * xdisp.c (message_dolog):
6238 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6239 Use pMd etc. instead.
6240 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6241 replacing the pWIDE etc. symbols removed from editfns.c.
6243 * keyboard.h (num_input_events): Now uintmax_t.
6244 This is (very slightly) less likely to mess up due to wraparound.
6247 * buffer.c: Integer signedness fixes.
6248 (alloc_buffer_text, enlarge_buffer_text):
6249 Use ptrdiff_t rather than size_t when either will do, as we prefer
6252 * alloc.c: Integer signedness and overflow fixes.
6253 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6254 (__malloc_size_t): Default to size_t, not to int.
6255 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6256 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6257 Prefer ptrdiff_t to size_t when either would do, as we prefer
6259 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6260 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6261 Now const. Initialize with values that are in range even if char
6263 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6264 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6265 These functions do the right thing with sizes > 2**32.
6266 (check_depth): Now ptrdiff_t, not int.
6267 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6268 Adjust to new way of storing sizes. Check for size overflow bugs
6270 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6271 slightly wrong anyway, as it missed one instance of
6272 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6273 (refill_memory_reserve): Omit needless cast to size_t.
6274 (mark_object_loop_halt): Mark as externally visible.
6276 * xselect.c: Integer signedness and overflow fixes.
6277 (Fx_register_dnd_atom, x_handle_dnd_message):
6278 Use ptrdiff_t, not size_t, since we prefer signed.
6279 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6280 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6281 x_dnd_atoms_size and x_dnd_atoms_length.
6283 * doprnt.c: Prefer signed to unsigned when either works.
6285 * doprnt.c (doprnt):
6287 * xdisp.c (vmessage):
6288 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6289 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6290 prefer signed arithmetic to avoid comparison confusion.
6291 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6292 but is a bit tricky.
6294 Assume freestanding C89 headers, string.h, stdlib.h.
6295 * data.c, doprnt.c, floatfns.c, print.c:
6296 Include float.h unconditionally.
6297 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6298 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6299 * regex.c: Likewise for stddef.h, string.h.
6300 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6301 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6302 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6303 (STDC_HEADERS): Remove obsolete defines.
6304 * sysdep.c: Include limits.h unconditionally.
6306 Assume support for memcmp, memcpy, memmove, memset.
6307 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6308 * regex.c (memcmp, memcpy):
6309 Remove; we assume C89 now.
6311 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6312 (__malloc_safe_bcopy): Remove; no longer needed.
6314 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6315 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6316 well either way, and we prefer signed to unsigned.
6318 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6320 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6321 closes the connection while we're reading (bug#9182).
6323 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6325 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6326 are specified (Bug#9168).
6328 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6330 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6331 Found by GCC static checking and --with-wide-int on a 32-bit host.
6333 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6335 * xdisp.c (compute_display_string_pos): Fix logic of caching
6336 previous display string position. Initialize cached_prev_pos to
6337 -1. Fixes slow-down at the beginning of a buffer.
6339 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6341 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6342 for attrs[LFACE_FONTSET_INDEX].
6344 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6346 * xml.c (parse_region): Remove unused local
6347 that was recently introduced.
6349 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6351 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6352 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6354 * xdisp.c (move_it_in_display_line_to): Record the best matching
6355 position for TO_CHARPOS while scanning the line, and restore it on
6356 exit if none of the characters scanned was an exact match.
6357 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6358 when exact match is impossible due to invisible text, and the
6359 lines are truncated.
6361 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6363 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6366 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6368 Fix a significant slow-down of cursor motion with C-n, C-p,
6369 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6370 auto-repeat under bidi redisplay in fontified buffers.
6371 * xdisp.c (compute_stop_pos_backwards): New function.
6372 (next_element_from_buffer): Call compute_stop_pos_backwards to
6373 find a suitable prev_stop when we find ourselves before
6375 (reseat): Don't look for prev_stop, as that could mean a very long
6377 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6378 <cached_disp_overlay_modiff>: Cache for last found display string
6380 (compute_display_string_pos): Return the cached position if asked
6381 about the same buffer in the same area of character positions, and
6382 the buffer wasn't changed since the time the display string
6383 position was cached.
6385 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6387 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6388 is an integer, which is important for empty lines. (Bug#9149)
6390 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6392 * frame.c (Fmodify_frame_parameters): In tty case, update the
6393 default face if necessary (Bug#4238).
6395 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6397 * editfns.c (Fstring_to_char): No need to explain what a character
6398 is in the docstring (Bug#6576).
6400 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6402 * xml.c (parse_region): Make sure we always return a tree.
6404 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6406 * xml.c (parse_region): If a document contains only comments,
6409 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6411 * xml.c (make_dom): Return comments, too.
6413 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6416 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6417 and the surrounding thread.
6418 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6419 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6420 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6422 * s/openbsd.h (BROKEN_SIGIO): Define.
6423 * unexelf.c (unexec) [__OpenBSD__]:
6424 Don't update the .mdebug section of the Alpha COFF symbol table.
6426 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6428 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6431 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6433 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6434 This fixes some race conditions on the permissions of any newly
6437 * alloc.c (valid_pointer_p): Use pipe, not open.
6438 This fixes some permissions issues when debugging.
6440 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6441 If fchown fails to set both uid and gid, try to set just gid,
6442 as that is sometimes allowed. Adjust the file's mode to eliminate
6443 setuid or setgid bits that are inappropriate if fchown fails.
6445 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6447 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6448 to compare Lisp_Objects.
6449 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6450 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6451 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6453 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6455 * lread.c (read_integer): Unread even EOF character.
6456 (read1): Likewise. Properly record start position of symbol.
6458 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6459 symbol character follows.
6461 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6463 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6464 This works around a problem with the previous change to Fcopy_file.
6465 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6466 and without this change, GCC might complain about discarding
6467 fchown's return value.
6469 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6471 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6473 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6475 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6477 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6479 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6480 it's used from the C level.
6482 * process.c: Use the same condition for POLL_FOR_INPUT in both
6483 keyboard.c and process.c (bug#1858).
6485 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6487 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6488 (Fgnutls_boot): Use it.
6490 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6492 * doc.c (Fsubstitute_command_keys): Revert last change.
6494 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6496 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6497 quotes the next character, and doesn't affect other longer
6498 sequences (bug#8935).
6500 * lread.c (syms_of_lread): Clarify that is isn't only
6501 `eval-buffer' and `eval-defun' that's affected by
6502 `lexical-binding' (bug#8460).
6504 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6506 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6507 bidi redisplay when a line includes both an image and is truncated.
6509 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6511 Fix minor problems found by static checking.
6512 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6513 (elsz): Now a signed constant, not a size_t var. We prefer signed
6514 types to unsigned, to avoid integer comparison confusion. Without
6515 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6516 "cannot optimize loop, the loop counter may overflow", a symptom
6518 * indent.c (Fvertical_motion): Mark locals as initialized.
6519 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6521 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6523 * search.c (Fre_search_backward): Mention `case-fold-search' in
6524 all the re_search_* functions (bug#8138).
6526 * keyboard.c (Fopen_dribble_file): Document when the file is
6529 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6531 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6534 Support bidi reordering of display and overlay strings.
6535 * xdisp.c (compute_display_string_pos)
6536 (compute_display_string_end): Accept additional argument STRING.
6537 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6538 (reseat_to_string): Initialize bidi_it->string.s and
6539 bidi_it->string.schars.
6540 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6541 NULL (avoids a crash in bidi_paragraph_init).
6542 Initialize itb.string.lstring.
6543 (init_iterator): Call bidi_init_it only of a valid
6544 buffer position was specified. Initialize paragraph_embedding to
6546 (reseat_to_string): Initialize the bidi iterator.
6547 (display_string): If we need to ignore text properties of
6548 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6549 original value of -1 will not work with bidi.)
6550 (compute_display_string_pos): First arg is now struct
6551 `text_pos *'; all callers changed. Support display properties on
6553 (compute_display_string_end): Support display properties on Lisp
6555 (init_iterator, reseat_1, reseat_to_string): Initialize the
6556 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6557 when iterating on a string not from display properties).
6558 (compute_display_string_pos, compute_display_string_end):
6559 Fix calculation of the object to scan. Fixes an error when using
6561 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6562 base_level_stop; instead, set base_level_stop to BEGV.
6563 Fixes crashes in vertical-motion.
6564 (next_element_from_buffer): Improve commentary for when
6565 the iterator is before prev_stop.
6566 (init_iterator): Initialize bidi_p from the default value of
6567 bidi-display-reordering, not from buffer-local value. Use the
6568 buffer-local value only if initializing for buffer iteration.
6569 (handle_invisible_prop): Support invisible properties on strings
6570 that are being bidi-reordered.
6571 (set_iterator_to_next): Support bidi reordering of C strings and
6573 (next_element_from_string): Support bidi reordering of Lisp
6575 (handle_stop_backwards): Support Lisp strings as well.
6576 (display_string): Support display of R2L glyph rows.
6577 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6578 (init_iterator): Don't initialize it->bidi_p for strings
6580 (reseat_to_string): Initialize it->bidi_p for strings here.
6581 (next_element_from_string, next_element_from_c_string)
6582 (next_element_from_buffer): Add xassert's for correspondence
6583 between IT's object being iterated and it->bidi_it.string
6585 (face_before_or_after_it_pos): Support bidi iteration.
6586 (next_element_from_c_string): Handle the case of the first string
6587 character that is not the first one in the visual order.
6588 (get_visually_first_element): New function, refactored from common
6589 parts of next_element_from_buffer, next_element_from_string, and
6590 next_element_from_c_string.
6591 (tool_bar_lines_needed, redisplay_tool_bar)
6592 (display_menu_bar): Force left-to-right direction. Add a FIXME
6593 comment for making that be controlled by a user option.
6594 (push_it, pop_it): Save and restore the state of the
6595 bidi iterator. Save and restore the bidi_p flag.
6596 (pop_it): Iterate out of display property for string iteration as
6598 (iterate_out_of_display_property): Support iteration over strings.
6599 (handle_single_display_spec): Set up it->bidi_it for iteration
6600 over a display string, and call bidi_init_it.
6601 (handle_single_display_spec, next_overlay_string)
6602 (get_overlay_strings_1, push_display_prop): Set up the bidi
6603 iterator for displaying display or overlay strings.
6604 (forward_to_next_line_start): Don't use the shortcut if
6606 (back_to_previous_visible_line_start): If handle_display_prop
6607 pushed the iterator stack, restore the internal state of the bidi
6608 iterator by calling bidi_pop_it same number of times.
6609 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6610 and we are bidi-iterating, don't decrement the iterator position;
6611 instead, set the first_elt flag in the bidi iterator, to produce
6613 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6614 (push_display_prop): xassert that we are iterating a buffer.
6615 (push_it, pop_it): Save and restore paragraph_embedding member.
6616 (handle_single_display_spec, next_overlay_string)
6617 (get_overlay_strings_1, reseat_1, reseat_to_string)
6618 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6619 correctly. Don't assume unibyte strings are not bidi-reordered.
6620 (compute_display_string_pos)
6621 (compute_display_string_end): Fix handling the case of C string.
6622 (push_it, pop_it): Save and restore from_disp_prop_p.
6623 (handle_single_display_spec, push_display_prop): Set the
6624 from_disp_prop_p flag.
6625 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6626 (pop_it): Call iterate_out_of_display_property only if we are
6627 popping after iteration over a string that came from a display
6628 property. Fix a typo in popping stretch info. Add an assertion
6629 for verifying that the iterator position is in sync with the bidi
6631 (handle_single_display_spec, get_overlay_strings_1)
6632 (push_display_prop): Fix initialization of paragraph direction for
6633 string when that of the parent object is not yet determined.
6634 (reseat_1): Call bidi_init_it to resync the bidi
6635 iterator with IT's position. (Bug#7616)
6636 (find_row_edges): If ROW->start.pos gives position
6637 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6638 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6639 Reset the from_disp_prop_p flag.
6640 (SAVE_IT, RESTORE_IT): New macros.
6641 (pos_visible_p, face_before_or_after_it_pos)
6642 (back_to_previous_visible_line_start)
6643 (move_it_in_display_line_to, move_it_in_display_line)
6644 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6645 (try_scrolling, redisplay_window, display_line): Use them when
6646 saving a temporary copy of the iterator and restoring it back.
6647 (back_to_previous_visible_line_start, reseat_1)
6648 (init_iterator): Empty the bidi cache "stack".
6649 (move_it_in_display_line_to): If iterator ended up at
6650 EOL, but we never saw any buffer positions smaller than
6651 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6652 motion in bidi-reordered lines.
6653 (move_it_in_display_line_to): Record prev_method and prev_pos
6654 immediately before the call to set_iterator_to_next. Fixes cursor
6655 motion in bidi-reordered lines with stretch glyphs and strings
6656 displayed in margins. (Bug#8133) (Bug#8867)
6657 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6659 (pos_visible_p): Support positions in bidi-reordered lines.
6660 Save and restore bidi cache.
6662 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6663 (bidi_paragraph_info): Delete unused struct.
6664 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6665 (bidi_cache_start): New variable.
6666 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6668 (bidi_cache_fetch_state, bidi_cache_search)
6669 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6670 (bidi_cache_find, bidi_peek_at_next_level)
6671 (bidi_level_of_next_char, bidi_find_other_level_edge)
6672 (bidi_move_to_visually_next): Compare cache index with
6673 bidi_cache_start rather than with zero.
6674 (bidi_fetch_char): Accept new argument STRING; all callers
6675 changed. Support iteration over a string. Support strings with
6676 display properties. Support unibyte strings. Fix the type of
6677 `len' according to what STRING_CHAR_AND_LENGTH expects.
6678 (bidi_paragraph_init, bidi_resolve_explicit_1)
6679 (bidi_resolve_explicit, bidi_resolve_weak)
6680 (bidi_level_of_next_char, bidi_move_to_visually_next):
6681 Support iteration over a string.
6682 (bidi_set_sor_type, bidi_resolve_explicit_1)
6683 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6684 can now be zero (for strings); special values 0 and -1 were
6685 changed to -1 and -2, respectively.
6686 (bidi_char_at_pos): New function.
6687 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6688 Call it instead of FETCH_MULTIBYTE_CHAR.
6689 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6690 initialized to valid values.
6691 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6693 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6694 the test for valid cached positions. Fix the logic for looking up
6695 the sentinel state in the cache. GCPRO the Lisp string we are
6697 (bidi_push_it, bidi_pop_it): New functions.
6698 (bidi_initialize): Initialize the bidi cache start stack pointer.
6699 (bidi_cache_ensure_space): New function, refactored from part of
6700 bidi_cache_iterator_state. Don't assume the required size is just
6701 one BIDI_CACHE_CHUNK away.
6702 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6703 (bidi_count_bytes, bidi_char_at_pos): New functions.
6704 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6705 always valid if bidi_cache_idx is valid.
6706 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6707 is valid if it's going to be used.
6708 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6709 (bidi_cache_fetch_state, bidi_cache_search)
6710 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6711 (bidi_cache_iterator_state, bidi_cache_find)
6712 (bidi_find_other_level_edge, bidi_cache_start_stack):
6713 All variables related to cache indices are now EMACS_INT.
6715 * dispextern.h (struct bidi_string_data): New structure.
6716 (struct bidi_it): New member `string'. Make flag members be 1-bit
6717 fields, and put them last in the struct.
6718 (compute_display_string_pos, compute_display_string_end):
6720 (bidi_push_it, bidi_pop_it): Add prototypes.
6721 (struct iterator_stack_entry): New members bidi_p,
6722 paragraph_embedding, and from_disp_prop_p.
6723 (struct it): Member bidi_p is now a bit field 1 bit wide.
6724 (bidi_shelve_cache, bidi_unshelve_cache):
6727 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6728 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6729 and vector-like objects.
6731 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6732 cache around display iteration.
6734 * window.c (Fwindow_end, window_scroll_pixel_based)
6735 (displayed_window_lines, Frecenter): Save and restore the bidi
6736 cache around display iteration.
6738 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6740 * editfns.c (Fdelete_region): Clarify the use of the named
6741 parameters (bug#6788).
6743 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6745 * indent.c (Fvertical_motion): Set and restore w->pointm when
6746 saving and restoring the window's buffer (Bug#9006).
6748 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6750 * editfns.c (Fstring_to_char): Clarify just what is returned
6751 (bug#6576). Text by Eli Zaretskii.
6753 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6755 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6757 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6759 * buffer.c (mmap_find): Fix a typo.
6761 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6763 Fix execution of x selection hooks.
6764 * xselect.c (Qx_lost_selection_functions)
6765 (Qx_sent_selection_functions): New vars.
6766 (syms_of_xselect): DEFSYM them.
6767 (x_handle_selection_request): Pass Qx_sent_selection_functions
6768 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6769 (x_handle_selection_clear,x_clear_frame_selections):
6770 Pass Qx_lost_selection_functions rather than
6771 Vx_lost_selection_functions to Frun_hook_with_args.
6773 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6775 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6776 The old code sometimes used this field without initializing it.
6778 * alloc.c (gc_sweep): Don't read past end of array.
6779 In theory, the old code could also have corrupted Emacs internals,
6780 though it'd be very unlikely.
6782 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6784 * character.c (Fcharacterp): Don't advertise optional ignored
6785 argument. (Bug#4026)
6787 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6789 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6792 * window.c (Fset_window_start): Doc fix (bug#4199).
6793 (Fset_window_hscroll): Ditto.
6795 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6797 Fix minor new problems caught by GCC 4.6.1.
6798 * term.c (init_tty): Remove unused local.
6799 * xsettings.c (store_monospaced_changed): Define this function only
6800 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6803 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6805 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6807 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6809 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6810 are the mini-buffer and the echo area (bug#3320).
6812 * term.c (init_tty): Remove support for supdup, c10 and perq
6813 terminals, which are no longer supported (bug#1482).
6815 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6817 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6819 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6821 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6822 for non-popups (Bug#3642).
6824 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6826 * alloc.c (reset_malloc_hooks): Protoize.
6827 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6828 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6829 * cm.c (losecursor): Likewise.
6830 * data.c (fmod): Likewise.
6831 * dispnew.c (swap_glyphs_in_rows): Likewise.
6832 * emacs.c (memory_warning_signal): Likewise.
6833 * floatfns.c (float_error): Likewise.
6834 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6835 (otf_open, font_otf_capability, generate_otf_features)
6836 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6838 * image.c (pbm_read_file): Likewise.
6839 * indent.c (string_display_width): Likewise.
6840 * intervals.c (check_for_interval, search_for_interval)
6841 (inc_interval_count, count_intervals, root_interval)
6842 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6843 * lread.c (defalias): Likewise.
6844 * ralloc.c (r_alloc_check): Likewise.
6845 * regex.c (set_image_of_range_1, set_image_of_range)
6846 (regex_grow_registers): Likewise.
6847 * sysdep.c (strerror): Likewise.
6848 * termcap.c (valid_filename_p, tprint, main): Likewise.
6849 * tparam.c (main): Likewise.
6850 * unexhp9k800.c (run_time_remap, save_data_space)
6851 (update_file_ptrs, read_header, write_header, calculate_checksum)
6852 (copy_file, copy_rest, display_header): Likewise.
6853 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6855 * xdisp.c (check_it): Likewise.
6856 * xfaces.c (register_color, unregister_color, unregister_colors):
6858 * xfns.c (print_fontset_result): Likewise.
6859 * xrdb.c (member, fatal, main): Likewise.
6861 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6863 Fix minor problems found by static checking (Bug#9031).
6864 * chartab.c (char_table_set_range, map_sub_char_table):
6865 Remove unused locals.
6866 (uniprop_table): Now static.
6867 * composite.c (_work_char): Remove unused static var.
6869 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6871 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6873 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6875 * gtkutil.c (qttip_cb): Remove code without function.
6877 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6879 * w32.c (pthread_sigmask): New stub.
6881 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6883 Use pthread_sigmask, not sigprocmask (Bug#9010).
6884 sigprocmask is portable only for single-threaded applications, and
6885 Emacs can be multi-threaded when it uses GTK.
6886 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6888 * callproc.c (Fcall_process):
6889 * process.c (create_process):
6890 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6891 Use pthread_sigmask, not sigprocmask.
6893 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6895 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6896 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6899 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6901 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6902 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6903 (xg_hide_tooltip): Fix comment.
6905 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6906 in registerServicesMenuSendTypes.
6907 (validRequestorForSendType): Don't check ns_return_types.
6909 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6912 2011-07-08 Jason Rumney <jasonr@gnu.org>
6914 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6915 SH_SHOW for hidden windows (Bug#5482).
6917 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6918 frame struct members of non-existent frames (Bug#6284).
6920 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6922 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6923 variable firstTime not needed on OSX >= 10.6.
6924 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6925 >= 10.5. Use setKnobProportion, setDoubleValue.
6927 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6928 (MAC_OS_X_VERSION_10_5): Define if not defined.
6929 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6930 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6931 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6933 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6934 cString and lossyCString on OSX >= 10.4
6936 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6937 sizeToFit on OSX >= 10.2.
6939 * nsimage.m (allocInitFromFile): Don't use deprecated method
6940 bestRepresentationForDevice on OSX >= 10.6.
6942 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6945 * emacs.c: Declare unexec_init_emacs_zone.
6947 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6949 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6951 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6952 on svcsMenu (Bug#8842).
6954 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6956 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6958 * nsterm.m (QUTF8_STRING): Declare.
6959 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6960 (validRequestorForSendType): Return type is (id).
6961 Change indexOfObjectIdenticalTo to indexOfObject.
6962 Check if we have local selection before returning self (Bug#8842).
6963 (writeSelectionToPasteboard): Put local selection into paste board
6964 if we have a local selection (Bug#8842).
6965 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6967 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6968 (ns_get_local_selection): Declare.
6970 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6972 * keymap.c (describe_map_tree): Don't insert a double newline at
6973 the end of the buffer (bug#1169) and return whether we inserted
6976 * callint.c (Fcall_interactively): Change "reading args" to
6977 "providing args" to try to clarify what it does (bug#1010).
6979 2011-07-07 Kenichi Handa <handa@m17n.org>
6981 * composite.c (composition_compute_stop_pos): Ignore a static
6982 composition starting before CHARPOS (Bug#8915).
6984 * xdisp.c (handle_composition_prop): Likewise.
6986 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6988 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6991 2011-07-07 Kenichi Handa <handa@m17n.org>
6993 * character.h (unicode_category_t): New enum type.
6995 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6996 (Qchar_code_property_table): New variable.
6997 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6998 (UNIPROP_COMPRESSED_FORM_P): New macros.
6999 (char_table_ascii): Uncompress the compressed values.
7000 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7001 Uncompress the compressed values.
7002 (sub_char_table_ref_and_range): Likewise.
7003 (char_table_ref_and_range): Uncompress the compressed values.
7004 (sub_char_table_set): New arg is_uniprop. Callers changed.
7005 Uncompress the compressed values.
7006 (sub_char_table_set_range): Args changed. Callers changed.
7007 (char_table_set_range): Adjuted for the above change.
7008 (map_sub_char_table): Delete args default_val and parent. Add arg
7009 top. Give decoded values to a Lisp function.
7010 (map_char_table): Adjust for the above change. Give decoded
7011 values to a Lisp function. Gcpro more variables.
7012 (uniprop_table_uncompress)
7013 (uniprop_decode_value_run_length): New functions.
7014 (uniprop_decoder, uniprop_decoder_count): New variables.
7015 (uniprop_get_decoder, uniprop_encode_value_character)
7016 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7018 (uniprop_encoder, uniprop_encoder_count): New variables.
7019 (uniprop_get_encoder, uniprop_table)
7020 (Funicode_property_table_internal, Fget_unicode_property_internal)
7021 (Fput_unicode_property_internal): New functions.
7022 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7023 Sunicode_property_table_internal, Sget_unicode_property_internal,
7024 and Sput_unicode_property_internal. Defvar_lisp
7025 char-code-property-alist.
7027 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7028 Vunicode_category_table.
7030 * font.c (font_range): Adjust for the change of
7031 Vunicode_category_table.
7033 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7035 * m/iris4d.h: Remove file, move contents ...
7036 * s/irix6-5.h: ... here.
7038 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7040 Remove unportable assumption about struct layout (Bug#8884).
7041 * alloc.c (mark_buffer):
7042 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7043 (clone_per_buffer_values): Don't assume that
7044 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7045 This isn't true in general, and it's particularly not true
7046 if Emacs is configured with --with-wide-int.
7047 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7048 New macros, used in the buffer.c change.
7050 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7052 * xsettings.c: Use both GConf and GSettings if both are available.
7053 (store_config_changed_event): Add comment.
7054 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7055 (store_tool_bar_style_changed): New functions.
7056 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7057 (struct xsettings): Move font inside HAVE_XFT.
7058 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7059 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7060 Move inside HAVE_XFT.
7061 (something_changed_gsettingsCB): Rename from something_changedCB.
7062 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7064 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7065 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7066 (something_changed_gconfCB): Rename from something_changedCB.
7067 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7068 (parse_settings): Move check for font inside HAVE_XFT.
7069 (read_settings, apply_xft_settings): Add comment.
7070 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7071 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7072 call store_font_name_changed.
7073 (xft_settings_event): Add comment.
7074 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7075 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7076 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7077 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7078 (xsettings_initialize): Call init_gsettings last.
7079 (xsettings_get_system_font, xsettings_get_system_normal_font):
7082 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7084 Random fixes. E.g., (random) never returned negative values.
7085 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7086 subseconds part to the entropy, as that's a bit more random.
7087 Prefer signed to unsigned, since the signedness doesn't matter and
7088 in general we prefer signed. When given a limit, use a
7089 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7090 latter isn't right if USE_2_TAGS_FOR_INTS.
7091 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7092 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7094 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7096 * textprop.c (text_property_stickiness):
7097 Obey Vtext_property_default_nonsticky.
7098 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7099 * w32fns.c (syms_of_w32fns):
7100 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7102 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7104 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7105 This is more efficient than Ffile_directory_p and avoids a minor race.
7107 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7109 * buffer.c (Foverlay_put): Say what the return value is
7112 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7113 is a directory before asking whether to use the file name
7115 (barf_or_query_if_file_exists): Make the "File is a directory"
7116 error be more correct.
7118 * fns.c (Frequire): Remove the mention of the .gz files, since
7119 that's installation-specific, but keep the mention of
7120 `get-load-suffixes'.
7122 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7124 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7125 Report string overflow if the output is too long.
7127 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7129 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7130 (syms_of_gnutls): Remove duplicate DEFSYM for
7131 Qgnutls_bootprop_verify_hostname_error, an error for
7132 Qgnutls_bootprop_verify_error (which is no longer used).
7134 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7135 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7136 Also (re)move comments that are misplaced or no longer relevant.
7138 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7140 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7142 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7144 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7145 and background color parameters if they have been changed.
7147 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7149 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7151 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7153 * xsettings.c (SYSTEM_FONT): Define only when used.
7154 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7156 * keymap.c (access_keymap_1): Now static.
7158 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7160 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7161 leave any prefix arg for the up event (Bug#1586).
7163 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7165 * lread.c (syms_of_lread): Mention single symbols defined by
7166 `defvar' or `defconst' (bug#7154).
7168 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7169 (Frequire): Mention get-load-suffixes.
7171 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7173 * window.h (window): Remove clone_number slot.
7174 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7176 (make_parent_window, make_window, saved_window)
7177 (Fset_window_configuration, save_window_save): Don't deal with
7179 * buffer.c (Qclone_number): Remove declaration.
7180 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7182 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7184 Add multiple inheritance to keymaps.
7185 * keymap.c (Fmake_composed_keymap): New function.
7186 (Fset_keymap_parent): Simplify.
7187 (fix_submap_inheritance): Remove.
7188 (access_keymap_1): New function extracted from access_keymap to handle
7189 embedded parents and handle lists of maps.
7190 (access_keymap): Use it.
7191 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7192 (Fcopy_keymap): Handle embedded parents.
7193 (Fcommand_remapping, define_as_prefix): Simplify.
7194 (Fkey_binding): Simplify.
7195 (syms_of_keymap): Move minibuffer-local-completion-map,
7196 minibuffer-local-filename-completion-map,
7197 minibuffer-local-must-match-map, and
7198 minibuffer-local-filename-must-match-map to Elisp.
7199 (syms_of_keymap): Defsubr make-composed-keymap.
7200 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7201 (parse_menu_item): Trivial simplification.
7203 2011-07-01 Glenn Morris <rgm@gnu.org>
7205 * Makefile.in (SETTINGS_LIBS): Fix typo.
7207 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7209 * coding.c (Fencode_coding_string): Record the last coding system
7210 used, as the function doc string says (bug#8738).
7212 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7214 * xsettings.c (store_monospaced_changed): Take new font as arg and
7215 check for change against current_mono_font.
7216 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7217 (emacs_settings_constructor, emacs_settings_get_property)
7218 (emacs_settings_set_property, emacs_settings_class_init)
7219 (emacs_settings_init, gsettings_obj): Remove.
7220 (something_changedCB): New function for HAVE_GSETTINGS.
7221 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7222 with value as argument.
7223 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7224 g_settings_new (Bug#8967). Do not create gsettings_obj.
7225 Remove calls to g_settings_bind. Connect something_changedCB to
7228 * xgselect.c: Add defined (HAVE_GSETTINGS).
7229 (xgselect_initialize): Ditto.
7231 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7232 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7235 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7237 * eval.c (struct backtrace): Simplify and port the data structure.
7238 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7239 signed bit field, as this assumption is not portable and it makes
7240 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7241 "char debug_on_exit : 1" as this is not portable either; instead,
7242 use the portable "unsigned int debug_on_exit : 1". Remove unused
7243 member evalargs. Remove obsolete comments about cc bombing out.
7245 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7247 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7248 Let HAVE_GSETTINGS override HAVE_GCONF.
7249 (store_monospaced_changed): New function.
7250 (EMACS_SETTINGS): A new type derived from GObject to handle
7251 GSettings notifications.
7252 (emacs_settings_constructor, emacs_settings_get_property)
7253 (emacs_settings_set_property, emacs_settings_class_init):
7255 (gsettings_client, gsettings_obj): New variables.
7256 (GSETTINGS_SCHEMA): New define.
7257 (something_changedCB): Call store_monospaced_changed.
7258 (init_gsettings): New function.
7259 (xsettings_initialize): Call init_gsettings.
7260 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7263 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7266 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7268 * window.c (resize_root_window, grow_mini_window)
7269 (shrink_mini_window): Rename Qresize_root_window to
7270 Qwindow_resize_root_window and Qresize_root_window_vertically to
7271 Qwindow_resize_root_window_vertically.
7273 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7275 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7277 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7279 * makefile.w32-in: Redesign dependencies so they reflect more
7280 clearly which files are directly included by each source file,
7281 and not through other includes.
7283 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7285 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7286 (sort_overlays, overlay_strings): When an overlay's clone number
7287 matches the window's clone number process the overlay even if
7288 the overlay's window property doesn't match the current window.
7290 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7291 (Fwindow_hchild): Rename to Fwindow_left_child.
7292 (Fwindow_next): Rename to Fwindow_next_sibling.
7293 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7294 (resize_window_check): Rename to window_resize_check.
7295 (resize_window_apply): Rename to window_resize_apply.
7296 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7297 (Fdelete_other_windows_internal, resize_frame_windows)
7298 (Fsplit_window_internal, Fdelete_window_internal)
7299 (grow_mini_window, shrink_mini_window)
7300 (Fresize_mini_window_internal): Fix callers accordingly.
7302 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7304 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7305 (emacs_fixed_set_min_size): Remove.
7306 (emacs_fixed_new): Take frame as argument.
7308 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7309 (_EmacsFixedPrivate): Remove minwidth/height.
7310 Add struct frame *f.
7311 (emacs_fixed_init): Initialize priv->f.
7312 (get_parent_class, emacs_fixed_set_min_size): Remove.
7313 (emacs_fixed_new): Set priv->f to argument.
7314 (emacs_fixed_get_preferred_width)
7315 (emacs_fixed_get_preferred_height): Use min_width/height from
7316 frames size_hint to set minimum and natural (Bug#8919).
7317 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7318 and use min_width/height from frames size_hint to set
7319 min_width/height (Bug#8919).
7321 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7322 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7325 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7327 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7328 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7331 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7333 * process.c (wait_reading_process_output): Bypass select if
7334 waiting for a cell while ignoring keyboard input, and input is
7335 pending. Suggested by Jan Djärv (Bug#8869).
7337 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7339 Use gnulib's dup2 module instead of rolling our own.
7340 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7342 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7344 * dispnew.c (scrolling_window): Before scrolling, turn off a
7345 mouse-highlight in the window being scrolled.
7347 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7349 Move DEFSYM to lisp.h and use everywhere.
7351 * character.h (DEFSYM): Move declaration...
7352 * lisp.h (DEFSYM): ...here.
7358 * w32select.c: Don't include character.h.
7360 * alloc.c (syms_of_alloc):
7361 * buffer.c (syms_of_buffer):
7362 * bytecode.c (syms_of_bytecode):
7363 * callint.c (syms_of_callint):
7364 * casefiddle.c (syms_of_casefiddle):
7365 * casetab.c (init_casetab_once):
7366 * category.c (init_category_once, syms_of_category):
7367 * ccl.c (syms_of_ccl):
7368 * cmds.c (syms_of_cmds):
7369 * composite.c (syms_of_composite):
7370 * dbusbind.c (syms_of_dbusbind):
7371 * dired.c (syms_of_dired):
7372 * dispnew.c (syms_of_display):
7373 * doc.c (syms_of_doc):
7374 * editfns.c (syms_of_editfns):
7375 * emacs.c (syms_of_emacs):
7376 * eval.c (syms_of_eval):
7377 * fileio.c (syms_of_fileio):
7378 * fns.c (syms_of_fns):
7379 * frame.c (syms_of_frame):
7380 * fringe.c (syms_of_fringe):
7381 * insdel.c (syms_of_insdel):
7382 * keymap.c (syms_of_keymap):
7383 * lread.c (init_obarray, syms_of_lread):
7384 * macros.c (syms_of_macros):
7385 * msdos.c (syms_of_msdos):
7386 * print.c (syms_of_print):
7387 * process.c (syms_of_process):
7388 * search.c (syms_of_search):
7389 * sound.c (syms_of_sound):
7390 * syntax.c (init_syntax_once, syms_of_syntax):
7391 * terminal.c (syms_of_terminal):
7392 * textprop.c (syms_of_textprop):
7393 * undo.c (syms_of_undo):
7394 * w32.c (globals_of_w32):
7395 * window.c (syms_of_window):
7396 * xdisp.c (syms_of_xdisp):
7397 * xfaces.c (syms_of_xfaces):
7398 * xfns.c (syms_of_xfns):
7399 * xmenu.c (syms_of_xmenu):
7400 * xsettings.c (syms_of_xsettings):
7401 * xterm.c (syms_of_xterm): Use DEFSYM.
7403 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7405 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7407 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7409 Integer and buffer overflow fixes (Bug#8873).
7411 * print.c (printchar, strout): Check for string overflow.
7412 (PRINTPREPARE, printchar, strout):
7413 Don't set size unless allocation succeeds.
7415 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7416 for sizes. Check for string overflow more accurately.
7417 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7419 * macros.c: Integer and buffer overflow fixes.
7420 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7421 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7422 Use ptrdiff_t, not int, for sizes.
7423 Don't increment bufsize until after realloc succeeds.
7424 Check for size-calculation overflow.
7425 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7427 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7429 * lread.c: Integer overflow fixes.
7430 (read_integer): Radix is now EMACS_INT, not int,
7431 to improve quality of diagnostics for out-of-range radices.
7432 Calculate buffer size correctly for out-of-range radices.
7433 (read1): Check for integer overflow in radices, and in
7434 read-circle numbers.
7435 (read_escape): Avoid int overflow.
7436 (Fload, openp, read_buffer_size, read1)
7437 (substitute_object_recurse, read_vector, read_list, map_obarray):
7438 Use ptrdiff_t, not int, for sizes.
7439 (read1): Use EMACS_INT, not int, for sizes.
7440 Check for size overflow.
7442 * image.c (cache_image): Check for size arithmetic overflow.
7444 * lread.c: Integer overflow issues.
7445 (saved_doc_string_size, saved_doc_string_length)
7446 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7447 Now ptrdiff_t, not int.
7448 (read1): Don't assume doc string length fits in int. Check for
7449 out-of-range doc string lengths.
7450 (read_list): Don't assume file position fits in int.
7451 (read_escape): Check for hex character overflow.
7453 2011-06-22 Leo Liu <sdl.web@gmail.com>
7455 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7456 Move to minibuffer.el.
7458 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7460 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7461 The following patches are for when GLYPH_DEBUG && !XASSERT.
7462 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7463 * dispnew.c (flush_stdout):
7464 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7465 Mark as externally visible.
7466 * dispnew.c (check_window_matrix_pointers): Now static.
7467 * dispnew.c (window_to_frame_vpos):
7468 * xfns.c (unwind_create_frame):
7469 * xterm.c (x_check_font): Remove unused local.
7470 * scroll.c (CHECK_BOUNDS):
7471 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7472 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7473 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7474 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7475 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7477 (debug_method_add): Use va_list and vsprintf rather than relying
7478 on undefined behavior with wrong number of arguments.
7479 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7480 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7481 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7482 since we're not interested in debugging glyphs with old libraries.
7483 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7484 GCC 4.6.0's static checking.
7486 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7488 Integer overflow and signedness fixes (Bug#8873).
7489 A few related buffer overrun fixes, too.
7491 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7493 * dispextern.h (struct face.stipple):
7494 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7495 (x_bitmap_mask, x_allocate_bitmap_record)
7496 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7497 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7498 (x_create_bitmap_from_xpm_data):
7499 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7500 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7502 * xfaces.c (load_pixmap):
7503 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7504 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7505 (.bitmaps_last, struct x_output.icon_bitmap):
7506 Use ptrdiff_t, not int, for bitmap indexes.
7507 (x_allocate_bitmap_record): Check for size overflow.
7508 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7510 Use ptrdiff_t, not int, for overlay counts.
7511 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7512 * editfns.c (overlays_around, get_pos_property):
7513 * textprop.c (get_char_property_and_overlay):
7514 * xdisp.c (next_overlay_change, note_mouse_highlight):
7515 * xfaces.c (face_at_buffer_position):
7516 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7517 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7518 (Fnext_overlay_change, Fprevious_overlay_change)
7519 (mouse_face_overlay_overlaps, Foverlays_in):
7520 Use ptrdiff_t, not int, for sizes.
7521 (overlays_at, overlays_in): Check for size-calculation overflow.
7523 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7525 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7526 (x_session_initialize): Do not assume string length fits in int.
7528 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7529 This is unlikely, but can occur if DPI is outlandish.
7531 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7532 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7534 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7535 * xrdb.c (magic_file_p, search_magic_path):
7536 Omit last arg SUFFIX; it was always 0. All callers changed.
7537 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7539 * xfont.c (xfont_match): Avoid need for strlen.
7541 * xfns.c: Don't assume strlen fits in int.
7542 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7544 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7545 not unsigned long, as we prefer signed integers. All callers changed.
7546 Detect integer overflow in repeat count.
7547 (message_dolog): Don't assume print length fits in 39 bytes.
7548 (display_mode_element): Don't assume strlen fits in int.
7550 * termcap.c: Don't assume sizes fit in int and never overflow.
7551 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7552 (gobble_line): Check for size-calculation overflow.
7554 * minibuf.c (Fread_buffer):
7555 * lread.c (intern, intern_c_string):
7556 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7557 Don't assume string length fits in int.
7559 * keyboard.c (parse_tool_bar_item):
7560 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7562 * font.c: Don't assume string length fits in int.
7563 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7564 Use ptrdiff_t, not int.
7565 (font_intern_prop): Don't assume string length fits in int.
7566 Don't assume integer property fits in fixnum.
7567 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7569 * filelock.c: Fix some buffer overrun and integer overflow issues.
7570 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7571 Reformulate so as not to need the command string.
7572 Invoke gzip -cd rather than gunzip, as it's more portable.
7573 (lock_info_type, lock_file_1, lock_file):
7574 Don't assume pid_t and time_t fit in unsigned long.
7575 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7576 (current_lock_owner): Prefer signed type for sizes.
7577 Use memcpy, not strncpy, where memcpy is what is really wanted.
7578 Don't assume (via atoi) that time_t and pid_t fit in int.
7579 Check for time_t and/or pid_t out of range, e.g., via a network share.
7580 Don't alloca where an auto var works fine.
7582 * fileio.c: Fix some integer overflow issues.
7583 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7584 Don't assume string length fits in int.
7585 (directory_file_name): Don't assume string length fits in long.
7586 (make_temp_name): Don't assume pid fits in int, or that its print
7587 length is less than 20.
7589 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7591 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7593 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7595 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7596 We prefer signed integers, even for size calculations.
7598 * emacs.c: Don't assume string length fits in 'int'.
7599 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7600 (main): Don't invoke strlen when not needed.
7602 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7603 (XD_DEBUG_MESSAGE): Don't waste a byte.
7605 * callproc.c (getenv_internal_1, getenv_internal)
7607 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7609 * lread.c (invalid_syntax): Omit length argument.
7610 All uses changed. This doesn't fix a bug, but it simplifies the
7611 code away from its former Hollerith-constant appearance, and it's
7612 one less 'int' to worry about when looking at integer-overflow issues.
7613 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7615 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7616 This didn't break anything, but it didn't help either.
7617 It's confusing to put a bogus integer in a place where the actual
7618 value does not matter.
7619 (LIST_END_P): Remove unused macro and its bogus comment.
7620 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7622 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7623 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7625 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7626 We prefer signed types, and the value cannot exceed the EMACS_INT
7627 range anyway (because otherwise the length would not be representable).
7628 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7629 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7630 This avoids a GCC warning when WIDE_EMACS_INT.
7632 * indent.c (sane_tab_width): New function.
7633 (current_column, scan_for_column, Findent_to, position_indentation)
7634 (compute_motion): Use it. This is just for clarity.
7635 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7637 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7639 * lisp.h (lint_assume): New macro.
7640 * composite.c (composition_gstring_put_cache):
7641 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7643 * editfns.c, insdel.c:
7644 Omit unnecessary forward decls, to simplify future changes.
7646 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7648 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7650 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7651 Use much-faster test for byte-length change.
7652 Don't assume string byte-length fits in 'int'.
7653 Check that character arg fits in 'int'.
7654 (mapcar1): Declare byte as byte, for clarity.
7656 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7658 * fns.c (concat): Catch string overflow earlier.
7659 Do not rely on integer wraparound.
7661 * dispextern.h (struct it.overlay_strings_charpos)
7662 (struct it.selective): Now EMACS_INT, not int.
7663 * xdisp.c (forward_to_next_line_start)
7664 (back_to_previous_visible_line_start)
7665 (reseat_at_next_visible_line_start, next_element_from_buffer):
7666 Don't arbitrarily truncate the value of 'selective' to int.
7668 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7670 * composite.c: Don't truncate sizes to 'int'.
7671 (composition_gstring_p, composition_reseat_it)
7672 (composition_adjust_point): Use EMACS_INT, not int.
7673 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7674 not EMACS_UINT, for indexes.
7676 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7678 * buffer.c: Include <verify.h>.
7679 (struct sortvec.priority, struct sortstr.priority):
7680 Now EMACS_INT, not int.
7681 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7682 (struct sortstr.size, record_overlay_string)
7683 (struct sortstrlist.size, struct sortlist.used):
7684 Don't truncate size to int.
7685 (record_overlay_string): Check for size-calculation overflow.
7686 (init_buffer_once): Check at compile-time, not run-time.
7688 2011-06-22 Jim Meyering <meyering@redhat.com>
7690 Don't leak an XBM-image-sized buffer
7691 * image.c (xbm_load): Free the image buffer after using it.
7693 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7696 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7697 that Sun C diagnosed.
7698 * fns.c (secure_hash): Fix pointer signedness issue.
7699 * intervals.c (static_offset_intervals): New function.
7700 (offset_intervals): Use it.
7702 2011-06-21 Leo Liu <sdl.web@gmail.com>
7705 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7708 * fns.c (secure_hash): Rename from crypto_hash_function and change
7709 the first arg to accept symbols.
7710 (Fsecure_hash): New primitive.
7711 (syms_of_fns): New symbols.
7713 2011-06-20 Deniz Dogan <deniz@dogan.se>
7715 * process.c (Fset_process_buffer): Clarify return value in
7718 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7720 * dispnew.c (add_window_display_history): Use BVAR.
7722 * xdisp.c (debug_method_add): Use BVAR.
7723 (check_window_end, dump_glyph_matrix, dump_glyph)
7724 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7726 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7729 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7730 check till after the cache is created in init_frame_faces.
7732 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7734 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7736 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7738 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7739 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7740 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7742 Improve buffer-overflow checking (Bug#8873).
7743 * fileio.c (Finsert_file_contents):
7744 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7745 Remove the old (too-loose) buffer overflow checks.
7746 They weren't needed, since make_gap checks for buffer overflow.
7747 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7748 The old code merely checked for Emacs fixnum overflow, and relied
7749 on undefined (wraparound) behavior. The new code avoids undefined
7750 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7752 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7753 Tune. Don't use wider integers than needed. Don't use alloca.
7754 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7756 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7758 * insdel.c, lisp.h (buffer_overflow): New function.
7759 (insert_from_buffer_1, replace_range, replace_range_2):
7760 * insdel.c (make_gap_larger):
7761 * editfns.c (Finsert_char):
7762 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7764 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7766 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7768 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7770 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7771 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7773 * fileio.c: Don't assume EMACS_INT fits in off_t.
7774 (emacs_lseek): New static function.
7775 (Finsert_file_contents, Fwrite_region): Use it.
7776 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7778 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7780 * fns.c: Don't overflow int when computing a list length.
7781 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7782 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7783 truncation on 64-bit hosts. Check for QUIT every
7784 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7785 faster and is responsive enough.
7786 (Flength): Report an error instead of overflowing an integer.
7787 (Fsafe_length): Return a float if the value is not representable
7788 as a fixnum. This shouldn't happen except in contrived situations.
7789 (Fnthcdr, Fsort): Don't assume list length fits in int.
7790 (Fcopy_sequence): Don't assume vector length fits in int.
7792 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7793 (header_size, word_size): New constants.
7794 (allocate_vectorlike): Don't check size overflow here.
7795 (allocate_vector): Check it here instead, since this is the only
7796 caller of allocate_vectorlike that could cause overflow.
7797 Check that the new vector's length is representable as a fixnum.
7799 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7800 The previous code was bogus. For example, next_almost_prime (32)
7801 returned 39, which is undesirable as it is a multiple of 3; and
7802 next_almost_prime (24) returned 25, which is a multiple of 5 so
7803 why was the code bothering to check for multiples of 7?
7805 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7807 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7809 Variadic C functions now count arguments with ptrdiff_t.
7810 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7811 Back then I didn't know that the Emacs coding style prefers signed int.
7812 Also, in the meantime I found a few more instances where arguments
7813 were being counted with int, which may truncate counts on 64-bit
7814 machines, or EMACS_INT, which may be unnecessarily wide.
7815 * lisp.h (struct Lisp_Subr.function.aMANY)
7816 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7817 Arg counts are now ptrdiff_t, not size_t.
7818 All variadic functions and their callers changed accordingly.
7819 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7820 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7821 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7822 * callint.c (Fcall_interactively): Check arg count for overflow,
7823 to avoid potential buffer overrun. Use signed char, not 'int',
7824 for 'varies' array, so that we needn't bother to check its size
7825 calculation for overflow.
7826 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7827 * eval.c (apply_lambda):
7828 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7829 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7830 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7832 * callint.c (Fcall_interactively): Don't use index var as event count.
7834 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7835 * mem-limits.h (SIZE): Remove; no longer used.
7837 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7839 Remove unnecessary casts.
7840 * xterm.c (x_term_init):
7841 * xfns.c (x_set_border_pixel):
7842 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7843 These aren't needed now that we assume ANSI C.
7845 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7846 It's more likely to cause problems (due to unsigned overflow)
7849 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7851 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7853 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7855 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7857 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7859 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7861 GLYPH_CODE_FACE returns EMACS_INT, not int.
7862 * dispextern.h (merge_faces):
7863 * xfaces.c (merge_faces):
7864 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7865 Don't assume EMACS_INT fits in int.
7867 * character.h (CHAR_VALID_P): Remove unused parameter.
7868 * fontset.c, lisp.h, xdisp.c: All uses changed.
7870 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7872 * fns.c (concat): Minor tuning based on overflow analysis.
7873 This doesn't fix any bugs. Use int to hold character, instead
7874 of constantly refetching from Emacs object. Use XFASTINT, not
7875 XINT, for value known to be a character. Don't bother comparing
7876 a single byte to 0400, as it's always less.
7878 * floatfns.c (Fexpt):
7879 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7881 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7884 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7886 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7887 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7888 incorrectly succeed when S was a string, because 4294967386 was
7889 truncated before it was used.
7891 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7892 Otherwise, an out-of-range integer could cause undefined behavior
7895 * composite.c: Use int, not EMACS_INT, for characters.
7896 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7897 EMACS_INT, for values that are known to be in character range.
7898 This doesn't fix any bugs but is the usual style inside Emacs and
7899 may generate better code on 32-bit machines.
7901 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7902 This is for reasons similar to the recent CHAR_STRING fix.
7903 * charset.c (Fencode_char): Check that character arg is actually
7904 a character. Pass an int to ENCODE_CHAR.
7905 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7906 wider than 'int', as a compile-time check to prevent future regressions
7909 * character.c (char_string): Remove unnecessary casts.
7911 Make sure a 64-bit char is never passed to CHAR_STRING.
7912 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7913 by silently ignoring the top 32 bits, allowing some values
7914 that were far too large to be valid characters.
7915 * character.h: Include <verify.h>.
7916 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7917 arguments are no wider than unsigned, as a compile-time check
7918 to prevent future regressions in this area.
7920 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7921 (Fsubst_char_in_region):
7923 * xdisp.c (decode_mode_spec_coding):
7924 Adjust to CHAR_STRING's new requirement.
7925 * editfns.c (Finsert_char, Fsubst_char_in_region):
7926 * fns.c (concat): Check that character args are actually
7927 characters. Without this test, these functions did the wrong
7928 thing with wildly out-of-range values on 64-bit hosts.
7930 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7931 These casts should not be needed on 32-bit hosts, either.
7932 * keyboard.c (read_char):
7933 * lread.c (Fload): Remove casts to unsigned.
7935 * lisp.h (UNSIGNED_CMP): New macro.
7936 This fixes comparison bugs on 64-bit hosts.
7937 (ASCII_CHAR_P): Use it.
7938 * casefiddle.c (casify_object):
7939 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7940 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7941 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7942 * dispextern.h (FACE_FROM_ID):
7943 * keyboard.c (read_char): Use UNSIGNED_CMP.
7945 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7946 not to EMACS_INT, to avoid GCC warning.
7948 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7950 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7951 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7952 isn't needed on 32-bit machines.
7954 * buffer.c (Fgenerate_new_buffer_name):
7955 Use EMACS_INT for count, not int.
7956 (advance_to_char_boundary): Return EMACS_INT, not int.
7958 * data.c (Qcompiled_function): Now static.
7960 * window.c (window_body_lines): Now static.
7962 * image.c (gif_load): Rename local to avoid shadowing.
7964 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7965 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7966 * alloc.c (make_save_value): Integer argument is now of type
7968 (mark_object): Use ptrdiff_t, not int.
7969 * lisp.h (pD): New macro.
7970 * print.c (print_object): Use it.
7972 * alloc.c: Use EMACS_INT, not int, to count objects.
7973 (total_conses, total_markers, total_symbols, total_vector_size)
7974 (total_free_conses, total_free_markers, total_free_symbols)
7975 (total_free_floats, total_floats, total_free_intervals)
7976 (total_intervals, total_strings, total_free_strings):
7977 Now EMACS_INT, not int. All uses changed.
7978 (Fgarbage_collect): Compute overall total using a double, so that
7979 integer overflow is less likely to be a problem. Check for overflow
7980 when converting back to an integer.
7981 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7982 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7983 These were 'int' variables that could overflow on 64-bit hosts;
7984 they were never used, so remove them instead of repairing them.
7985 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7986 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7987 Previously, this ceilinged at INT_MAX, but that doesn't work on
7989 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7991 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7992 (allocate_vectorlike): Check for ptrdiff_t overflow.
7993 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7994 when a (possibly-narrower) signed value would do just as well.
7995 We prefer using signed arithmetic, to avoid comparison confusion.
7997 * alloc.c: Catch some string size overflows that we were missing.
7998 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7999 for convenience in STRING_BYTES_MAX.
8000 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8001 The definition here is exact; the one in lisp.h was approximate.
8002 (allocate_string_data): Check for string overflow. This catches
8003 some instances we weren't catching before. Also, it catches
8004 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8005 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8006 and ptrdiff_t and EMACS_INT are both 64 bits.
8008 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8009 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8010 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8012 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8014 * alloc.c (Fmake_string): Check for out-of-range init.
8016 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8018 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8020 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8022 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8023 xg_get_default_scrollbar_width.
8025 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8026 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8027 (style_changed_cb): Call update_theme_scrollbar_width and call
8028 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8029 all frames (Bug#8505).
8030 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8031 Call gtk_window_set_resizable if HAVE_GTK3.
8032 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8033 and height if HAVE_GTK3 (Bug#8505).
8034 (scroll_bar_width_for_theme): New variable.
8035 (update_theme_scrollbar_width): New function.
8036 (xg_get_default_scrollbar_width): Move code to
8037 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8038 (xg_initialize): Call update_theme_scrollbar_width.
8040 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8042 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8044 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8046 * frame.c (make_frame): Call other_buffer_safely instead of
8049 * window.c (temp_output_buffer_show): Call display_buffer with
8050 second argument Vtemp_buffer_show_specifiers and reset latter
8051 immediately after the call.
8052 (Vtemp_buffer_show_specifiers): New variable.
8053 (auto_window_vscroll_p, next_screen_context_lines)
8054 (Vscroll_preserve_screen_position): Remove leading asterisks from
8057 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8059 Fix minor problems found by GCC 4.6.0 static checking.
8060 * buffer.c (Qclone_number): Remove for now, as it's unused.
8061 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8062 (record_buffer): Remove unused local.
8063 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8064 (set_frame_buffer_list): Remove; unused.
8065 * frame.h (other_visible_frames): Remove decl.
8066 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8067 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8068 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8070 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8071 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8072 Define only if HAVE_GPM.
8073 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8074 (update_hints_inhibit): Remove; never set. All uses removed.
8075 * widgetprv.h (emacsFrameClassRec): Remove decl.
8076 * window.c (delete_deletable_window): Now returns void, since it
8077 wasn't returning anything.
8078 (compare_window_configurations): Remove unused locals.
8079 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8080 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8081 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8082 the same widths as pointers. This follows up on the 2011-05-06 patch.
8083 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8084 * xterm.h: Likewise.
8085 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8087 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8089 * makefile.w32-in: Update dependencies.
8090 (LISP_H): Add lib/intprops.h.
8092 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8094 * image.c (gif_load): Add animation frame delay to the metadata.
8095 (syms_of_image): Use DEFSYM. New symbol `delay'.
8097 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8099 * window.c (delete_deletable_window): Re-add.
8100 (Fset_window_configuration): Rewrite to handle dead buffers and
8101 consequently deletable windows.
8102 (window_tree, Fwindow_tree): Remove. Supply functionality in
8104 (compare_window_configurations): Simplify code.
8106 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8108 * image.c (imagemagick_load_image): Fix type mismatch.
8109 (Fimagemagick_types): Likewise.
8111 * window.h (replace_buffer_in_windows): Declare.
8113 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8115 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8116 Qclone_number. Remove external declaration of Qdelete_window.
8117 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8119 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8120 Run Qbuffer_list_update_hook if allowed.
8121 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8122 buffer list implementation.
8123 (other_buffer_safely): New function.
8124 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8125 calls to replace_buffer_in_windows and
8126 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8128 (record_buffer): Inhibit quitting and rewrite using quittable
8129 functions. Run Qbuffer_list_update_hook if allowed.
8130 (Frecord_buffer, Funrecord_buffer): New functions.
8131 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8132 Move switch-to-buffer to window.el.
8133 (bury-buffer): Move to window.el.
8134 (Vbuffer_list_update_hook): New variable.
8136 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8139 * window.h (resize_frame_windows): Move up in code.
8140 (Fwindow_frame): Remove EXFUN.
8141 (replace_buffer_in_all_windows): Remove prototype.
8142 (replace_buffer_in_windows_safely): Add prototype.
8144 * window.c: Declare Qdelete_window static again. Move down
8145 declaration of select_count.
8146 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8147 (Fother_window): Move to window.el.
8148 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8149 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8150 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8152 (replace_buffer_in_windows): Implement by calling
8153 Qreplace_buffer_in_windows.
8154 (replace_buffer_in_all_windows): Remove with some functionality
8155 moved into replace_buffer_in_windows_safely.
8156 (replace_buffer_in_windows_safely): New function.
8157 (select_window_norecord, select_frame_norecord): Move in front
8158 of run_window_configuration_change_hook. Remove now obsolete
8160 (Fset_window_buffer): Rewrite doc-string.
8161 Call Qrecord_window_buffer.
8162 (keys_of_window): Move binding for other-window to window.el.
8164 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8166 * dispextern.h (struct image): Replace data member, whose int_val
8167 and ptr_val fields were not used by anything, with a single
8170 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8171 (gif_clear_image, gif_load, imagemagick_load_image)
8172 (gs_clear_image, gs_load): Callers changed.
8174 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8176 * buffer.h: Include <time.h>, for time_t.
8177 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8179 Fix minor problems found by static checking.
8181 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8183 Make identifiers static if they are not used in other modules.
8184 * data.c (Qcompiled_function, Qframe, Qvector):
8185 * image.c (QimageMagick, Qsvg):
8186 * minibuf.c (Qmetadata):
8187 * window.c (resize_window_check, resize_root_window): Now static.
8188 * window.h (resize_window_check, resize_root_window): Remove decls.
8190 * window.c (window_deletion_count, delete_deletable_window):
8192 (window_body_lines): Now static.
8193 (Fdelete_other_windows_internal): Mark vars as initialized.
8194 Make sure 'resize_failed' is initialized.
8195 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8196 (resize_window_apply): Remove unused local.
8197 * window.h (delete_deletable_window): Remove decl.
8199 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8200 (imagemagick_load_image): Fix pointer signedness problem by changing
8201 last arg from unsigned char * to char *. All uses changed.
8202 Also, fix a local for similar reasons.
8203 Remove unused locals. Remove locals to avoid shadowing.
8204 (fn_rsvg_handle_free): Remove; unused.
8205 (svg_load, svg_load_image): Fix pointer signedness problem.
8206 (imagemagick_load_image): Don't use garbage pointer image_wand.
8208 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8210 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8212 * image.c (gif_load): Fix omitted cast error introduced by
8215 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8217 * window.h (resize_proportionally, orig_total_lines)
8218 (orig_top_line): Remove from window structure.
8219 (set_window_height, set_window_width, change_window_heights)
8220 (Fdelete_window): Remove prototypes.
8221 (resize_frame_windows): Remove duplicate declaration.
8223 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8225 * window.h (resize_frame_windows, resize_window_check)
8226 (delete_deletable_window, resize_root_window)
8227 (resize_frame_windows): Declare prototypes.
8229 * window.c (resize_window_apply): Make definition be "static" to
8230 match the prototype.
8232 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8234 * window.c: Remove declarations of Qwindow_size_fixed,
8235 window_min_size_1, window_min_size_2, window_min_size,
8236 size_window, window_fixed_size_p, enlarge_window, delete_window.
8237 Remove static from declaration of Qdelete_window, it's
8238 temporarily needed by Fbury_buffer.
8239 (replace_window): Don't assign orig_top_line and
8241 (Fdelete_window, delete_window): Remove. Window deletion is
8242 handled by window.el.
8243 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8244 Replace Fdelete_window calls with calls to Qdelete_window.
8245 (Fdelete_other_windows): Remove. Deleting other windows is
8246 handled by window.el.
8247 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8248 handled in window.el.
8249 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8250 Window minimum sizes are handled in window.el.
8251 (shrink_windows, size_window, set_window_height)
8252 (set_window_width, change_window_heights, window_height)
8253 (window_width, CURBEG, CURSIZE, enlarge_window)
8254 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8255 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8256 handled in window.el.
8257 (make_dummy_parent): Rename to make_parent_window and give it a
8258 second argument horflag.
8259 (make_window): Don't set resize_proportionally any more.
8260 (Fsplit_window): Remove. Windows are split in window.el.
8261 (save_restore_action, save_restore_orig_size)
8262 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8263 Resize mini windows in window.el.
8264 (grow_mini_window, shrink_mini_window): Implement by calling
8265 Qresize_root_window_vertically, resize_window_check and
8266 resize_window_apply.
8267 (saved_window, Fset_window_configuration, save_window_save):
8268 Do not handle orig_top_line, orig_total_lines, and
8269 resize_proportionally.
8270 (window_min_height, window_min_width): Move to window.el.
8271 (keys_of_window): Move bindings for delete-other-windows,
8272 split-window, delete-window and enlarge-window to window.el.
8274 * buffer.c: Temporarily extern Qdelete_window.
8275 (Fbury_buffer): Temporarily call Qdelete_window instead of
8276 Fdelete_window (Fbury_buffer will move to window.el soon).
8278 * frame.c (set_menu_bar_lines_1): Remove code handling
8279 orig_top_line and orig_total_lines.
8281 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8282 set_window_height but set heights directly.
8283 (change_frame_size_1): Use resize_frame_windows.
8285 * xdisp.c (init_xdisp): Don't use set_window_height but set
8288 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8289 Use resize_frame_windows instead of change_window_heights and run
8290 run_window_configuration_change_hook.
8292 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8293 instead of change_window_heights and run
8294 run_window_configuration_change_hook.
8296 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8298 * window.c (replace_window): Rename second argument REPLACEMENT to
8299 NEW. New third argument SETFLAG. Rewrite.
8300 (delete_window, make_dummy_parent): Call replace_window with
8302 (window_list_1): Move down in code.
8303 (run_window_configuration_change_hook): Move set_buffer part
8304 before select_frame_norecord part in order to unwind correctly.
8305 Rename count1 to count.
8306 (recombine_windows, delete_deletable_window, resize_root_window)
8307 (Fdelete_other_windows_internal)
8308 (Frun_window_configuration_change_hook, make_parent_window)
8309 (resize_window_check, resize_window_apply, Fresize_window_apply)
8310 (resize_frame_windows, Fsplit_window_internal)
8311 (Fdelete_window_internal, Fresize_mini_window_internal):
8313 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8315 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8317 * window.h (window): Add some new members to window structure -
8318 normal_lines, normal_cols, new_total, new_normal, clone_number,
8319 splits, nest, prev_buffers, next_buffers.
8320 (WINDOW_TOTAL_SIZE): Move here from window.c.
8321 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8323 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8325 (make_dummy_parent): Set new members of windows structure.
8326 (make_window): Move down in code. Handle new members of window
8328 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8329 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8330 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8331 (Fset_window_prev_buffers, Fwindow_next_buffers)
8332 (Fset_window_next_buffers, Fset_window_clone_number):
8334 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8335 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8337 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8338 Argument WINDOW can be now internal window too.
8339 (Fwindow_use_time): Move up in code.
8340 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8342 (Fset_window_configuration, saved_window)
8343 (Fcurrent_window_configuration, save_window_save): Handle new
8344 members of window structure.
8345 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8346 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8347 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8348 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8349 Qget_mru_window, Qresize_root_window,
8350 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8351 Qauto_buffer_name; staticpro them.
8353 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8355 * window.c (Fwindow_total_size, Fwindow_left_column)
8356 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8357 (Fwindow_list_1): New functions.
8358 (window_box_text_cols): Replace with window_body_cols.
8359 (Fwindow_width, Fscroll_left, Fscroll_right):
8360 Use window_body_cols instead of window_box_text_cols.
8361 (delete_window, Fset_window_configuration):
8362 Call delete_all_subwindows with window as argument.
8363 (delete_all_subwindows): Take a window as argument and not a
8365 (window_loop): Remove handling of GET_LRU_WINDOW and
8367 (Fget_lru_window, Fget_largest_window): Move to window.el.
8369 * window.h: Extern window_body_cols instead of
8370 window_box_text_cols. delete_all_subwindows now takes a
8371 Lisp_Object as argument.
8373 * indent.c (compute_motion, Fcompute_motion):
8374 Use window_body_cols instead of window_box_text_cols.
8376 * frame.c (delete_frame): Call delete_all_subwindows with root
8379 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8381 * fns.c (Fputhash): Document return value.
8383 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8385 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8387 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8389 Cons<->int and similar integer overflow fixes (Bug#8794).
8391 Check for overflow when converting integer to cons and back.
8392 * charset.c (Fdefine_charset_internal, Fdecode_char):
8393 Use cons_to_unsigned to catch overflow.
8394 (Fencode_char): Use INTEGER_TO_CONS.
8395 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8396 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8397 * data.c (long_to_cons, cons_to_long): Remove.
8398 (cons_to_unsigned, cons_to_signed): New functions.
8399 These signal an error for invalid or out-of-range values.
8400 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8401 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8402 * font.c (Ffont_variation_glyphs):
8403 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8404 * lisp.h: Include <intprops.h>.
8405 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8406 (cons_to_signed, cons_to_unsigned): New decls.
8407 (long_to_cons, cons_to_long): Remove decls.
8408 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8409 (Fprimitive_undo): Use CONS_TO_INTEGER.
8410 * xfns.c (Fx_window_property): Likewise.
8411 * xselect.c: Include <limits.h>.
8412 (x_own_selection, selection_data_to_lisp_data):
8413 Use INTEGER_TO_CONS.
8414 (x_handle_selection_request, x_handle_selection_clear)
8415 (x_get_foreign_selection, Fx_disown_selection_internal)
8416 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8417 (lisp_data_to_selection_data): Use cons_to_unsigned.
8418 (x_fill_property_data): Use cons_to_signed.
8419 Report values out of range.
8421 Check for buffer and string overflow more precisely.
8422 * buffer.h (BUF_BYTES_MAX): New macro.
8423 * lisp.h (STRING_BYTES_MAX): New macro.
8424 * alloc.c (Fmake_string):
8425 * character.c (string_escape_byte8):
8426 * coding.c (coding_alloc_by_realloc):
8427 * doprnt.c (doprnt):
8428 * editfns.c (Fformat):
8430 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8431 since they may not be the same number.
8432 * editfns.c (Finsert_char):
8433 * fileio.c (Finsert_file_contents):
8434 Likewise for BUF_BYTES_MAX.
8436 * image.c: Use ptrdiff_t, not int, for sizes.
8437 (slurp_file): Switch from int to ptrdiff_t.
8439 (slurp_file): Check that file size fits in both size_t (for
8440 malloc) and ptrdiff_t (for sanity and safety).
8442 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8443 if b->modtime has its maximal value.
8445 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8447 Don't assume time_t can fit into int.
8448 * buffer.h (struct buffer.modtime): Now time_t, not int.
8449 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8450 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8452 Minor fixes for signed vs unsigned integers.
8453 * character.h (MAYBE_UNIFY_CHAR):
8454 * charset.c (maybe_unify_char):
8455 * keyboard.c (read_char, reorder_modifiers):
8456 XINT -> XFASTINT, since the integer must be nonnegative.
8457 * ftfont.c (ftfont_spec_pattern):
8458 * keymap.c (access_keymap, silly_event_symbol_error):
8459 XUINT -> XFASTINT, since the integer must be nonnegative.
8460 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8461 since it makes no difference and we prefer signed.
8462 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8463 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8466 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8468 * window.h (Fwindow_frame): Declare.
8470 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8472 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8473 (SPARE_MEMORY): Always define.
8474 (LARGE_REQUEST): Remove.
8475 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8477 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8479 * lisp.h: Move EXFUNS for Fframe_root_window,
8480 Fframe_first_window and Fset_frame_selected_window to window.h.
8482 * window.h: Move EXFUNS for Fframe_root_window,
8483 Fframe_first_window and Fset_frame_selected_window here from
8486 * frame.c (Fwindow_frame, Fframe_first_window)
8487 (Fframe_root_window, Fframe_selected_window)
8488 (Fset_frame_selected_window): Move to window.c.
8489 (Factive_minibuffer_window): Move to minibuf.c.
8490 (Fother_visible_frames_p): New function.
8492 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8494 * window.c (decode_window, decode_any_window): Move up in code.
8495 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8496 (inhibit_frame_unsplittable): Remove unused variable.
8497 (Fwindow_buffer): Move up and rewrite doc-string.
8498 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8499 (Fwindow_prev): New functions.
8500 (Fwindow_frame): Move here from frame.c. Accept any window as
8502 (Fframe_root_window, Fframe_first_window)
8503 (Fframe_selected_window): Move here from frame.c. Accept frame
8504 or arbitrary window as argument. Update doc-strings.
8505 (Fminibuffer_window): Move up in code.
8506 (Fwindow_minibuffer_p): Move up in code and simplify.
8507 (Fset_frame_selected_window): Move here from frame.c.
8509 (Fselected_window, select_window, Fselect_window): Move up in
8510 code. Minor doc-string fixes.
8512 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8514 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8515 Do not assume that spare memory exists; that assumption is valid
8516 only if SYSTEM_MALLOC.
8517 (LARGE_REQUEST): New macro, so that the issue of large requests
8518 is separated from the issue of spare memory.
8520 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8522 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8525 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8527 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8530 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8532 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8534 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8536 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8537 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8539 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8541 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8543 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8545 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8546 (x_clipboard_manager_save): Add return value.
8547 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8549 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8550 Obey Vx_select_enable_clipboard_manager. Catch errors in
8551 x_clipboard_manager_save (Bug#8779).
8552 (Vx_select_enable_clipboard_manager): New variable.
8553 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8555 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8557 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8559 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8561 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8562 in the current matrix if keep_current_p is non-zero.
8564 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8566 * bidi.c (bidi_level_of_next_char): Fix last change.
8568 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8570 Support bidi reordering of text covered by display properties.
8572 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8573 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8574 (bidi_cache_search, bidi_cache_iterator_state)
8575 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8576 (bidi_level_of_next_char, bidi_move_to_visually_next):
8577 Support character positions inside a run of characters covered by a
8579 (bidi_paragraph_init, bidi_resolve_explicit_1)
8580 (bidi_level_of_next_char): Call bidi_fetch_char and
8581 bidi_fetch_char_advance instead of FETCH_CHAR and
8583 (bidi_init_it): Initialize new members.
8584 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8586 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8587 instead of using explicit *_CHAR codes.
8588 (bidi_resolve_explicit, bidi_resolve_weak):
8589 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8590 bidirectional text is supported only in multibyte buffers.
8591 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8592 it to initialize the frame_window_p member of struct bidi_it.
8593 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8594 (bidi_resolve_explicit, bidi_resolve_weak)
8595 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8596 bidi_it->nchars is non-positive.
8597 (bidi_level_of_next_char): Don't try to lookup the cache for the
8598 next/previous character if nothing is cached there yet, or if we
8599 were just reseat()'ed to a new position.
8601 * xdisp.c (set_cursor_from_row): Set start and stop points
8602 according to the row's direction when priming the loop that looks
8603 for the glyph on which to display cursor.
8604 (single_display_spec_intangible_p): Function deleted.
8605 (display_prop_intangible_p): Reimplement to call
8606 handle_display_spec instead of single_display_spec_intangible_p.
8607 Accept 3 additional arguments needed by handle_display_spec.
8608 This fixes incorrect cursor motion across display property with complex
8609 values: lists, `(when COND...)' forms, etc.
8610 (single_display_spec_string_p): Support property values that are
8611 lists with the argument STRING its top-level element.
8612 (display_prop_string_p): Fix the condition for processing a
8613 property that is a list to be consistent with handle_display_spec.
8614 (handle_display_spec): New function, refactored from the
8615 last portion of handle_display_prop.
8616 (compute_display_string_pos): Accept additional argument
8617 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8618 value of a `display' property is a "replacing spec".
8619 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8620 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8621 the display property, but just return a value indicating whether
8622 the display property will replace the characters it covers.
8623 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8624 frame_window_p members of struct bidi_it.
8625 (compute_display_string_pos, compute_display_string_end):
8627 (push_it): Accept second argument POSITION, where pop_it should
8628 jump to continue iteration.
8629 (reseat_1): Initialize bidi_it.disp_pos.
8631 * keyboard.c (adjust_point_for_property): Adjust the call to
8632 display_prop_intangible_p to its new signature.
8634 * dispextern.h (struct bidi_it): New member frame_window_p.
8635 (bidi_init_it): Update prototypes.
8636 (display_prop_intangible_p): Update prototype.
8637 (compute_display_string_pos, compute_display_string_end):
8639 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8642 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8644 Malloc failure behavior now depends on size of allocation.
8645 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8646 * lisp.h: Change signatures accordingly.
8647 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8648 All callers changed. (Bug#8762)
8650 * gnutls.c: Use Emacs's memory allocators.
8651 Without this change, the gnutls library would invoke malloc etc.
8652 directly, which causes problems on non-SYNC_INPUT hosts, and which
8653 runs afoul of improving memory_full behavior. (Bug#8761)
8654 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8655 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8656 xfree instead of the default malloc, realloc, free.
8657 (Fgnutls_boot): No need to check for memory allocation failure,
8658 since xmalloc does that for us.
8660 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8661 * category.c (hash_get_category_set):
8662 * ccl.c (ccl_driver):
8663 * charset.c (Fdefine_charset_internal):
8664 * charset.h (struct charset.hash_index):
8665 * composite.c (get_composition_id, gstring_lookup_cache)
8666 (composition_gstring_put_cache):
8667 * composite.h (struct composition.hash_index):
8668 * dispextern.h (struct image.hash):
8669 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8670 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8671 (hashfn_equal, hashfn_user_defined, make_hash_table)
8672 (maybe_resize_hash_table, hash_lookup, hash_put)
8673 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8674 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8675 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8676 * image.c (make_image, search_image_cache, lookup_image)
8677 (xpm_put_color_table_h):
8678 * lisp.h (struct Lisp_Hash_Table):
8679 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8680 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8681 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8682 * alloc.c (allocate_vectorlike):
8683 Check for overflow in vector size calculations.
8684 * ccl.c (ccl_driver):
8685 Check for overflow when converting EMACS_INT to int.
8686 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8687 need to be updated by these changes.
8688 * fns.c (make_hash_table, maybe_resize_hash_table):
8689 Check for integer overflow with large hash tables.
8690 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8691 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8692 (SXHASH_REDUCE): New macro.
8693 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8694 Use it instead of discarding useful hash info with large hash values.
8695 (sxhash_float): New function.
8696 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8697 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8698 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8699 Rewrite to use FIXNUM_BITS, as this simplifies things.
8700 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8701 Adjust signatures to match updated version of code.
8702 (consing_since_gc): Now EMACS_INT, since a single hash table can
8703 use more than INT_MAX bytes.
8705 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8707 Make it possible to build with GCC-4.6+ -O2 -flto.
8709 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8711 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8713 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8714 Call minibuffer-inactive-mode.
8716 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8718 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8719 Update dependencies.
8721 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8723 * data.c (init_data): Remove code for UTS, this system is not
8726 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8728 Don't force ./temacs to start in terminal mode.
8730 * frame.c (make_initial_frame): Initialize faces in all cases, not
8731 only when CANNOT_DUMP is defined.
8732 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8734 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8736 * dispnew.c (add_window_display_history): Use const for the string
8737 pointer. Remove declaration, not needed.
8739 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8741 Use 'inline', not 'INLINE'.
8742 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8743 * alloc.c, fontset.c (INLINE): Remove.
8744 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8745 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8746 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8747 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8748 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8750 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8752 Make it possible to run ./temacs.
8754 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8755 syms_of_callproc does the same thing. Remove test for
8756 "initialized", do it in the caller.
8757 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8759 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8761 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8762 (read_minibuf): Use get_minibuffer.
8763 (syms_of_minibuf): Use DEFSYM.
8764 (Qmetadata): New var.
8765 * data.c (Qbuffer): Don't make it static.
8766 (syms_of_data): Use DEFSYM.
8768 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8770 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8771 (CCL_CODE_MIN): New macro.
8773 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8775 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8777 * eval.c (Qdebug): Now static.
8778 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8779 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8780 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8782 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8784 * image.c: Various fixes to ImageMagick code comments.
8785 (Fimagemagick_types): Doc fix.
8787 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8789 Minor fixes prompted by GCC 4.6.0 warnings.
8791 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8793 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8794 (x_clipboard_manager_save_all): Move extern decl to ...
8795 * xterm.h: ... here, so that it can be checked for consistency.
8797 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8799 * xselect.c (x_clipboard_manager_save_frame)
8800 (x_clipboard_manager_save_all): New functions.
8801 (Fx_clipboard_manager_save): Lisp function deleted.
8803 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8804 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8806 * xterm.h: Update prototype.
8808 2011-05-28 William Xu <william.xwl@gmail.com>
8810 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8813 2011-05-28 Jim Meyering <meyering@redhat.com>
8815 Avoid a sign-extension bug in crypto_hash_function.
8816 * fns.c (to_uchar): Define.
8817 (crypto_hash_function): Use it to convert some newly-signed
8818 variables to unsigned, to avoid sign-extension bugs. For example,
8819 without this change, (md5 "truc") would evaluate to
8820 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8821 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8822 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8824 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8826 Integer overflow fixes.
8828 * dbusbind.c: Serial number integer overflow fixes.
8829 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8830 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8831 to hold a serial number that is too large for a fixnum.
8832 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8833 Check for serial numbers out of range. Decode any serial number
8834 that was so large that it became a float. (Bug#8722)
8836 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8837 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8838 Use XFASTINT rather than XUINT when numbers are nonnegative.
8839 (xd_append_arg, Fdbus_method_return_internal):
8840 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8841 arguments, check that Lisp number is nonnegative, rather than
8842 silently wrapping negative numbers around. (Bug#8722)
8843 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8846 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8848 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8850 ccl: Add integer overflow checks.
8851 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8852 (IN_INT_RANGE): New macros.
8853 (ccl_driver): Use them to check for integer overflow when
8854 decoding a CCL program. Many of the new checks are whether XINT (x)
8855 fits in int; it doesn't always, on 64-bit hosts. The new version
8856 doesn't catch all possible integer overflows, but it's an
8857 improvement. (Bug#8719)
8859 * alloc.c (make_event_array): Use XINT, not XUINT.
8860 There's no need for unsigned here.
8862 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8863 This follows up to the 2011-05-06 change that substituted uintptr_t
8864 for EMACS_INT. This case wasn't caught back then.
8866 Rework Fformat to avoid integer overflow issues.
8867 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8868 now (part of C89). Include <verify.h>.
8869 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8870 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8871 (Fformat): Avoid the prepass trying to compute sizes; it was only
8872 approximate and thus did not catch overflow reliably. Instead, walk
8873 through the format just once, formatting and computing sizes as we go,
8874 checking for integer overflow at every step, and allocating a larger
8875 buffer as needed. Keep track separately whether the format is
8876 multibyte. Keep only the most-recently calculated precision, rather
8877 than them all. Record whether each argument has been converted to
8878 string. Use EMACS_INT, not int, for byte and char and arg counts.
8879 Support field widths and precisions larger than INT_MAX. Avoid
8880 sprintf's undefined behavior with conversion specifications such as %#d
8881 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8882 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8883 formatting out-of-range floating point numbers with int
8886 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8888 * data.c: Avoid integer truncation in expressions involving floats.
8889 * data.c: Include <intprops.h>.
8890 (arith_driver): When there's an integer overflow in an expression
8891 involving floating point, convert the integers to floating point
8892 so that the resulting value does not suffer from catastrophic
8893 integer truncation. For example, on a 64-bit host (* 4
8894 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8895 Do not rely on undefined behavior after integer overflow.
8897 merge count_size_as_multibyte, parse_str_to_multibyte
8898 * character.c, character.h (count_size_as_multibyte):
8899 Rename from parse_str_to_multibyte; all uses changed.
8900 Check for integer overflow.
8901 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8902 since it's now a duplicate of the other. This is more of
8903 a character than a buffer op, so better that it's in character.c.
8904 * fns.c, print.c: Adjust to above changes.
8906 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8908 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8910 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8912 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8913 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8914 (x_clipboard_manager_save): Now static.
8915 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8917 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8918 (crypto_hash_function): Now static.
8919 Fix pointer signedness problems. Avoid unnecessary initializations.
8921 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8923 * termhooks.h (Vselection_alist): Make it terminal-local.
8925 * terminal.c (create_terminal): Initialize it.
8927 * xselect.c: Support for clipboard managers.
8928 (Vselection_alist): Move to termhooks.h as terminal-local var.
8929 (LOCAL_SELECTION): New macro.
8930 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8931 (symbol_to_x_atom): Remove gratuitous arg.
8932 (x_handle_selection_request, lisp_data_to_selection_data)
8933 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8934 (x_own_selection, x_get_local_selection, x_convert_selection):
8935 New arg, specifying work frame. Use terminal-local Vselection_alist.
8936 (some_frame_on_display): Delete unused function.
8937 (Fx_own_selection_internal, Fx_get_selection_internal)
8938 (Fx_disown_selection_internal, Fx_selection_owner_p)
8939 (Fx_selection_exists_p): New optional frame arg.
8940 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8941 (x_handle_selection_clear): Don't treat other terminals with the
8942 same keyboard specially. Use the terminal-local Vselection_alist.
8943 (x_clear_frame_selections): Use Frun_hook_with_args.
8945 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8947 * xterm.h: Add support for those atoms.
8949 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8951 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8952 (converted_selections, conversion_fail_tag): New global variables.
8953 (x_selection_request_lisp_error): Free the above.
8954 (x_get_local_selection): Remove unnecessary code.
8955 (x_reply_selection_request): Args changed; handle arbitrary array
8956 of converted selections stored in converted_selections.
8957 Separate the XChangeProperty and SelectionNotify steps.
8958 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8959 (x_convert_selection): New function.
8960 (x_handle_selection_event): Simplify.
8961 (x_get_foreign_selection): Don't ignore incoming requests while
8962 waiting for an answer; this will fail when we implement
8963 SAVE_TARGETS, and seems unnecessary anyway.
8964 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8965 (Vx_sent_selection_functions): Doc fix.
8967 2011-05-26 Leo Liu <sdl.web@gmail.com>
8969 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8971 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8973 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8975 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8976 for fringe update if it has periodic bitmap.
8977 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8978 and fringe_bitmap_periodic_p.
8980 * fringe.c (get_fringe_bitmap_data): New function.
8981 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8982 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8983 row. Mark glyph row for fringe update if periodicity changed.
8985 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8986 for fringe update unless it has periodic bitmap.
8988 2011-05-25 Kenichi Handa <handa@m17n.org>
8990 * xdisp.c (get_next_display_element): Set correct it->face_id for
8991 a static composition.
8993 2011-05-24 Leo Liu <sdl.web@gmail.com>
8996 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8998 * fns.c (crypto_hash_function, Fsha1): New function.
8999 (Fmd5): Use crypto_hash_function.
9000 (syms_of_fns): Add Ssha1.
9002 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9004 * gnutls.c: Remove unused macros.
9005 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9006 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9007 Remove macros that are defined and never used.
9008 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9010 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9012 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9013 (Fx_get_selection_internal): Minor cleanup.
9014 (Fx_own_selection_internal): Rename arguments for consistency with
9017 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9019 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9021 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9023 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9025 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9027 * dispnew.c (scrolling_window): Don't exclude the case that the
9028 last enabled row in the desired matrix touches the bottom boundary.
9030 2011-05-21 Glenn Morris <rgm@gnu.org>
9032 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9033 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9034 and add some more files.
9036 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9038 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9039 report_file_error introduced by the change from 2011-05-07.
9041 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9043 * systime.h (Time): Define only if emacs is defined.
9044 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9045 where the include path doesn't have X11/X.h by default. See
9046 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9048 2011-05-20 Kenichi Handa <handa@m17n.org>
9050 * composite.c (find_automatic_composition): Fix previous change.
9052 2011-05-20 Glenn Morris <rgm@gnu.org>
9054 * lisp.mk: New file, split from Makefile.in.
9055 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9056 (shortlisp): Remove.
9057 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9059 2011-05-19 Glenn Morris <rgm@gnu.org>
9061 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9062 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9063 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9064 (lisp): Set the order to that of loadup.el.
9065 (shortlisp): Make it a copy of $lisp.
9066 (SOME_MACHINE_LISP): Remove.
9067 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9068 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9070 2011-05-18 Kenichi Handa <handa@m17n.org>
9072 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9073 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9074 (find_automatic_composition): Mostly rewrite for efficiency.
9076 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9078 * makefile.w32-in: Update dependencies.
9080 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9082 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9083 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9085 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9087 Fix some integer overflow issues, such as string length overflow.
9089 * insdel.c (count_size_as_multibyte): Check for string overflow.
9091 * character.c (lisp_string_width): Check for string overflow.
9092 Use EMACS_INT, not int, for string indexes and lengths; in
9093 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9094 the resulting string length overflows an EMACS_INT; instead,
9095 report a string overflow if no precision given. When checking for
9096 precision exhaustion, use a check that cannot possibly have
9097 integer overflow. (Bug#8675)
9098 * character.h (lisp_string_width): Adjust to new signature.
9100 * alloc.c (string_overflow): New function.
9101 (Fmake_string): Use it. This doesn't change behavior, but saves
9102 a few bytes and will simplify future changes.
9103 * character.c (string_escape_byte8): Likewise.
9104 * lisp.h (string_overflow): New decl.
9106 Fixups, following up to the user-interface timestamp change.
9107 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9108 for UI timestamps, instead of unsigned long.
9109 * msdos.c (mouse_get_pos): Likewise.
9110 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9111 * w32gui.h (Time): Define by including "systime.h" rather than by
9112 declaring it ourselves. (Bug#8664)
9114 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9115 * image.c (clear_image_cache): Likewise.
9117 * term.c (term_mouse_position): Don't assume time_t wraparound.
9119 Be more systematic about user-interface timestamps.
9120 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9121 and sometimes 'EMACS_UINT', to represent these timestamps.
9122 This change causes it to use 'Time' uniformly, as that's what X uses.
9123 This makes the code easier to follow, and makes it easier to catch
9124 integer overflow bugs such as Bug#8664.
9125 * frame.c (Fmouse_position, Fmouse_pixel_position):
9126 Use Time, not unsigned long, for user-interface timestamps.
9127 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9128 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9129 * keyboard.h (last_event_timestamp): Likewise.
9130 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9131 * menu.h (xmenu_show): Likewise.
9132 * term.c (term_mouse_position): Likewise.
9133 * termhooks.h (struct input_event.timestamp): Likewise.
9134 (struct terminal.mouse_position_hook): Likewise.
9135 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9136 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9137 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9138 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9140 * menu.h, termhooks.h: Include "systime.h", for Time.
9142 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9143 Don't assume that the difference between two unsigned long values
9144 can fit into an integer. At this point, we know button_down_time
9145 <= event->timestamp, so the difference must be nonnegative, so
9146 there's no need to cast the result if double-click-time is
9147 nonnegative, as it should be; check that it's nonnegative, just in
9148 case. This bug is triggered when events are more than 2**31 ms
9149 apart (about 25 days). (Bug#8664)
9151 * xselect.c (last_event_timestamp): Remove duplicate decl.
9152 (x_own_selection): Remove needless cast to unsigned long.
9154 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9155 that always fit in int. Use a sentinel instead of a counter, to
9156 avoid a temp and to allay GCC's concerns about possible int overflow.
9157 * frame.h (struct frame): Use int for menu_bar_items_used
9158 instead of EMACS_INT, since it always fits in int.
9160 * menu.c (grow_menu_items): Check for int overflow.
9162 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9164 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9165 Before, the code was not consistent. These values cannot exceed
9166 2**31 - 1 so there's no need to make them unsigned.
9167 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9168 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9169 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9171 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9173 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9174 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9175 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9176 presumably because the widths might not match.
9178 * window.c (size_window): Avoid needless test at loop start.
9180 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9182 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9184 2011-05-12 Drew Adams <drew.adams@oracle.com>
9186 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9188 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9190 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9191 `width' to `bar_area_x' and `bar_area_width', respectively.
9192 (x_scroll_run): Take account of fringe background extension.
9194 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9195 Rename local vars `left' and `width' to `bar_area_x' and
9196 `bar_area_width', respectively.
9197 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9198 background extension.
9200 2011-05-10 Jim Meyering <meyering@redhat.com>
9202 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9204 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9206 * image.c (Finit_image_library): Return t for built-in image types,
9207 like pbm and xbm. (Bug#8640)
9209 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9211 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9213 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9215 * w32console.c (Fset_screen_color): Doc fix.
9216 (Fget_screen_color): New function.
9217 (syms_of_ntterm): Defsubr it.
9219 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9220 unlink the temporary file if Fcall_process didn't create it in the
9222 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9223 child process will be redirected to a file specified with `:file'.
9224 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9225 cue to call_process_cleanup not to close that handle.
9227 2011-05-07 Ben Key <bkey76@gmail.com>
9229 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9230 one of two shell specific rules, either bootstrap-temacs-CMD or
9231 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9232 to the previous implementation of the bootstrap-temacs rule.
9233 The bootstrap-temacs-CMD rule is similar to the previous
9234 implementation of the bootstrap-temacs rule except that it
9235 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9238 These changes, along with some changes to nt/configure.bat,
9239 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9240 earlier fix to add support for --cflags and --ldflags options
9241 that include quotes so that it works whether make uses cmd or
9244 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9246 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9247 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9249 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9250 a string. Handle both cases.
9251 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9252 (Fdbus_register_method): Use Qinvalid_function.
9254 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9256 * makefile.w32-in: Update dependencies.
9257 (LISP_H): Add inttypes.h and stdin.h.
9258 (PROCESS_H): Add unistd.h.
9260 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9262 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9263 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9265 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9267 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9269 * term.c (vfatal): Remove stray call to va_end.
9270 It's not needed and the C Standard doesn't allow it here anyway.
9272 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9273 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9275 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9278 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9280 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9282 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9284 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9286 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9288 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9289 * charset.c (Fdefine_charset_internal): Don't initialize
9290 charset.code_space[15]. The value was garbage, on hosts with
9291 32-bit int (Bug#8600).
9293 * lread.c (read_integer): Be more consistent with string-to-number.
9294 Use string_to_number to do the actual conversion; this avoids
9295 rounding errors and fixes some other screwups. Without this fix,
9296 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9297 (digit_to_number): Move earlier, for benefit of read_integer.
9298 Return -1 if the digit is out of range for the base, -2 if it is
9299 not a digit in any supported base. (Bug#8602)
9301 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9303 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9304 to match comment at start of function. This also removes a
9305 GCC warning about overflow in a 32+64-bit port.
9307 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9309 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9310 Reported by Stefan Monnier in
9311 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9312 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9313 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9315 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9316 (EMACS_UINTPTR): Likewise, with uintptr_t.
9318 * lisp.h: Prefer 64-bit EMACS_INT if available.
9319 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9320 on 32-bit hosts that have 64-bit int, so that they can access
9322 However, temporarily disable this change unless the temporary
9323 symbol WIDE_EMACS_INT is defined.
9325 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9327 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9328 This removes an assumption that EMACS_INT and long are the same
9329 width as pointers. The assumption is true for Emacs porting targets
9330 now, but we want to make other targets possible.
9331 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9332 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9333 In the rest of the code, change types of integers that hold casted
9334 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9335 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9336 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9337 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9338 No need to cast type when ORing.
9339 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9340 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9341 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9342 assume EMACS_INT is the same width as char *.
9343 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9344 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9345 Remove no-longer-needed casts.
9346 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9347 (xg_tool_bar_help_callback, xg_make_tool_item):
9348 Use EMACS_INTPTR to hold an integer
9349 that will be cast to void *; this can avoid a GCC warning
9350 if EMACS_INT is not the same width as void *.
9351 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9352 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9353 (current_message_1, set_message_1):
9354 Use a local to convert to proper width without a cast.
9355 * xmenu.c (dialog_selection_callback): Likewise.
9357 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9358 Also, don't assume VALBITS / RAND_BITS is less than 5,
9359 and don't rely on undefined behavior when shifting a 1 left into
9361 * lisp.h (get_random): Change signature to match.
9363 * lread.c (hash_string): Use size_t, not int, for hash computation.
9364 Normally we prefer signed values; but hashing is special, because
9365 it's better to use unsigned division on hash table sizes so that
9366 the remainder is nonnegative. Also, size_t is the natural width
9367 for hashing into memory. The previous code used 'int', which doesn't
9368 retain enough info to hash well into very large tables.
9369 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9371 * dbusbind.c: Don't possibly lose pointer info when converting.
9372 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9373 Use XPNTR rather than XHASH, so that the high-order bits of
9374 the pointer aren't lost when converting through void *.
9376 * eval.c (Fautoload): Don't double-shift a pointer.
9378 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9380 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9382 * gnutls.c (DEF_GNUTLS_FN):
9383 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9385 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9387 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9390 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9392 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9393 New version that can reserve upto 2GB of heap space.
9395 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9397 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9399 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9401 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9402 `gnutls_certificate_set_x509_key_file'.
9404 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9406 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9407 Update dependencies.
9409 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9411 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9412 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9413 Remove unused parameter `fildes'.
9414 * process.c (read_process_output, send_process): Don't pass it.
9416 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9418 Fix previous change: the library cache is defined in w32.c.
9419 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9420 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9422 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9424 Implement dynamic loading of GnuTLS on Windows.
9426 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9427 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9428 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9431 * gnutls.c (Qgnutls_dll): Define.
9432 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9433 (gnutls_*): Declare function pointers.
9434 (init_gnutls_functions): New function to initialize function pointers.
9435 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9436 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9437 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9438 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9439 (emacs_gnutls_write, emacs_gnutls_read)
9440 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9441 (Fgnutls_available_p): New function.
9442 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9443 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9444 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9446 * image.c: Include w32.h.
9447 (Vimage_type_cache): Delete.
9448 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9449 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9450 (w32_delayed_load): Move to w32.c.
9452 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9454 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9455 (w32_delayed_load): Move from image.c. When loading a library, record
9456 its filename in the :loaded-from property of the library id.
9457 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9458 Initialize and staticpro them.
9459 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9461 * process.c: Include lisp.h before w32.h, not after.
9462 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9463 instead of gnutls_record_check_pending.
9465 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9467 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9469 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9470 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9473 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9475 * xterm.c (x_set_frame_alpha): Do not set property on anything
9476 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9478 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9480 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9482 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9484 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9485 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9486 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9487 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9488 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9489 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9490 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9491 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9492 (Qgnutls_bootprop_callbacks_verify): Make static.
9494 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9496 * callproc.c: Indentation fixup.
9498 * sysdep.c (wait_for_termination_1): Make static.
9499 (wait_for_termination, interruptible_wait_for_termination):
9500 Move after wait_for_termination_1.
9502 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9504 * sysdep.c (interruptible_wait_for_termination): New function
9505 which is like wait_for_termination, but allows keyboard
9508 * callproc.c (Fcall_process): Add (:file "file") as an option for
9510 (Fcall_process_region): Ditto.
9512 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9514 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9515 rather than `XVECTOR (FOO)->size'.
9517 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9518 inttypes.h, as a gnulib replacement is used if it not available in
9521 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9523 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9524 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9525 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9527 * coding.c (coding_alloc_by_realloc): Error out if destination
9528 will grow beyond MOST_POSITIVE_FIXNUM.
9529 (decode_coding_emacs_mule): Abort if there isn't enough place in
9530 charbuf for the composition carryover bytes. Reserve an extra
9531 space for up to 2 characters produced in a loop.
9532 (decode_coding_iso_2022): Abort if there isn't enough place in
9533 charbuf for the composition carryover bytes.
9535 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9537 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9538 aborting when %lld or %lll format is passed.
9539 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9540 %llo or %llx format is passed. (Bug#8545)
9542 * window.c (window_scroll_line_based): Use a marker instead of
9543 simple variables to record original value of point. (Bug#7952)
9545 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9546 produced by %s or %c overflows available buffer space. (Bug#8545)
9548 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9550 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9551 (SIZE_MAX): Move defn after all includes, as they might #define it.
9553 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9555 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9557 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9559 * keyboard.c (Qdelayed_warnings_hook): Define.
9560 (command_loop_1): Run `delayed-warnings-hook'
9561 if Vdelayed_warnings_list is non-nil.
9562 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9563 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9565 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9567 * doprnt.c (doprnt): Don't return value smaller than the buffer
9568 size if the message was truncated. (Bug#8545).
9570 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9572 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9573 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9575 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9577 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9579 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9581 * makefile.w32-in: Update dependencies.
9583 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9585 Improve `doprnt' and its usage. (Bug#8545)
9586 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9587 `format_end'. Remove support for %l as a conversion specifier.
9588 Don't use xrealloc. Improve diagnostics when the %l size modifier
9589 is used. Update the commentary.
9591 * eval.c (verror): Simplify calculation of size_t.
9593 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9596 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9598 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9601 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9603 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9604 This makes this file independent of the recent pseudovector change.
9606 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9608 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9610 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9611 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9612 Remove unused local.
9613 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9615 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9616 GCC 4.6.0 optimizes based on type-based alias analysis.
9617 For example, if b is of type struct buffer * and v of type struct
9618 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9619 != &v->size, and therefore "v->size = 1; b->size = 2; return
9620 v->size;" must therefore return 1. This assumption is incorrect
9621 for Emacs, since it type-puns struct Lisp_Vector * with many other
9622 types. To fix this problem, this patch adds a new type struct
9623 vectorlike_header that documents the constraints on layout of vectors
9624 and pseudovectors, and helps optimizing compilers not get fooled
9625 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9626 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9627 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9629 (XSETPVECTYPE): Rewrite in terms of new macro.
9630 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9631 This is a bit clearer, and further avoids the possibility of
9632 undesirable aliasing.
9633 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9634 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9635 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9636 since Lisp_Subr is a special case (no "next" field).
9637 (ASIZE): Now uses header.size rather than size.
9638 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9639 to avoid the hassle of writing XVECTOR (foo)->header.size.
9640 (struct vectorlike_header): New type.
9641 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9642 object, to help avoid aliasing.
9643 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9644 (SUBRP): Likewise, since Lisp_Subr is a special case.
9645 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9646 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9647 (struct Lisp_Hash_Table): Combine first two members into a single
9648 struct vectorlike_header member. All uses of "size" and "next" members
9649 changed to be "header.size" and "header.next".
9650 * buffer.h (struct buffer): Likewise.
9651 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9652 * frame.h (struct frame): Likewise.
9653 * process.h (struct Lisp_Process): Likewise.
9654 * termhooks.h (struct terminal): Likewise.
9655 * window.c (struct save_window_data, struct saved_window): Likewise.
9656 * window.h (struct window): Likewise.
9657 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9658 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9659 * buffer.c (init_buffer_once): Likewise.
9660 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9662 * process.c (Fformat_network_address): Use local var for size,
9665 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9667 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9668 * data.c (atof): Remove decl; no longer used or needed.
9669 (digit_to_number): Move to lread.c.
9670 (Fstring_to_number): Use new string_to_number function, to be
9671 consistent with how the Lisp reader treats infinities and NaNs.
9672 Do not assume that floating-point numbers represent EMACS_INT
9673 without losing information; this is not true on most 64-bit hosts.
9674 Avoid double-rounding errors, by insisting on integers when
9675 parsing non-base-10 numbers, as the documentation specifies.
9676 * lisp.h (string_to_number): New decl, replacing ...
9677 (isfloat_string): Remove.
9678 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9679 (read1): Do not accept +. and -. as integers; this
9680 appears to have been a coding error. Similarly, do not accept
9681 strings like +-1e0 as floating point numbers. Do not report
9682 overflow for integer overflows unless the base is not 10 which
9683 means we have no simple and reliable way to continue.
9684 Break out the floating-point parsing into a new
9685 function string_to_number, so that Fstring_to_number parses
9686 floating point numbers consistently with the Lisp reader.
9687 (digit_to_number): Move here from data.c. Make it static inline.
9688 (E_CHAR, EXP_INT): Remove, replacing with ...
9689 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9690 (string_to_number): New function, replacing isfloat_string.
9691 This function checks for valid syntax and produces the resulting
9692 Lisp float number too. Rework it so that string-to-number
9693 no longer mishandles examples like "1.0e+". Use strtoumax,
9694 so that overflow for non-base-10 numbers is reported only when
9695 there's no portable and simple way to convert to floating point.
9697 * textprop.c (set_text_properties_1): Rewrite for clarity,
9698 and to avoid GCC warning about integer overflow.
9700 * intervals.h (struct interval): Use EMACS_INT for members
9701 where EMACS_UINT might cause problems. See
9702 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9703 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9704 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9706 (offset_intervals): Tell GCC not to worry about length overflow
9707 when negating a negative length.
9709 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9710 (overrun_check_free): Likewise.
9712 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9713 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9716 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9717 (gnutls_make_error): Rename local to avoid shadowing.
9718 (gnutls_emacs_global_deinit): ifdef out; not used.
9719 (Fgnutls_boot): Use const for pointer to readonly storage.
9720 Comment out unused local. Fix pointer signedness problems.
9722 * lread.c (openp): Don't stuff size_t into an 'int'.
9723 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9724 about possible signed overflow.
9726 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9727 (GDK_KEY_g): Don't define if already defined.
9728 (xg_prepare_tooltip): Avoid pointer signedness problem.
9729 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9731 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9732 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9734 * xfns.c (Fx_window_property): Simplify a bit,
9735 to make a bit faster and to avoid GCC 4.6.0 warning.
9736 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9738 * fns.c (internal_equal): Don't assume size_t fits in int.
9740 * alloc.c (compact_small_strings): Tighten assertion a little.
9742 Replace pEd with more-general pI, and fix some printf arg casts.
9743 * lisp.h (pI): New macro, generalizing old pEd macro to other
9744 conversion specifiers. For example, use "...%"pI"d..." rather
9745 than "...%"pEd"...".
9746 (pEd): Remove. All uses replaced with similar uses of pI.
9747 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9748 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9749 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9750 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9751 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9752 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9753 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9755 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9756 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9757 * print.c (safe_debug_print, print_object): Likewise.
9758 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9760 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9761 avoiding the 0 flag, which is not portable.
9762 * process.c (Fmake_network_process): Use pI to avoid cast.
9763 * region-cache.c (pp_cache): Likewise.
9764 * xdisp.c (decode_mode_spec): Likewise.
9765 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9766 behavior on 64-bit hosts with printf arg.
9767 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9768 (x_stop_queuing_selection_requests): Likewise.
9769 (x_get_window_property): Don't truncate byte count to an 'int'
9772 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9773 here, since it parses constructs like leading '-' and spaces,
9774 which are not wanted; and it overflows with large numbers.
9775 Instead, simply match F[0-9]+, which is what is wanted anyway.
9777 * alloc.c: Remove unportable assumptions about struct layout.
9778 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9779 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9780 (allocate_vectorlike, make_pure_vector): Use the new macros,
9781 plus offsetof, to remove unportable assumptions about struct layout.
9782 These assumptions hold on all porting targets that I know of, but
9783 they are not guaranteed, they're easy to remove, and removing them
9784 makes further changes easier.
9786 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9787 This doesn't fix a bug but makes the code clearer.
9788 (string_overrun_cookie): Now const. Use initializers that
9789 don't formally overflow signed char, to avoid warnings.
9790 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9791 can cause Emacs to crash when string overrun checking is enabled.
9792 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9793 multiple of sizeof (EMACS_INT); it need not be, if
9794 alignof(EMACS_INT) < sizeof (EMACS_INT).
9795 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9797 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9799 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9801 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9803 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9804 supposed to be handshaking. (Bug#8556)
9805 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9807 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9809 * lisp.h (Qdebug): List symbol.
9810 * eval.c (Qdebug): Restore global linkage.
9811 * keyboard.c (debug-on-event): New variable.
9812 (handle_user_signal): Break into debugger when debug-on-event
9813 matches the current signal symbol.
9815 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9817 * alloc.c (check_sblock, check_string_bytes)
9818 (check_string_free_list): Convert to standard C.
9820 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9822 * w32.c (emacs_gnutls_push): Fix typo.
9824 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9826 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9827 "cast to pointer from integer of different size".
9829 Improve doprnt and its use in verror. (Bug#8545)
9830 * doprnt.c (doprnt): Document the set of format control sequences
9831 supported by the function. Use SAFE_ALLOCA instead of always
9834 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9835 is one byte too soon. Don't use xrealloc; instead xfree and
9838 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9840 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9843 * gnutls.c: Renamed global_initialized to
9844 gnutls_global_initialized. Added internals for the
9845 :verify-hostname-error, :verify-error, and :verify-flags
9846 parameters of `gnutls-boot' and documented those parameters in the
9847 docstring. Start callback support.
9848 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9849 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9850 on error. Return error code.
9851 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9852 (emacs_gnutls_read): Likewise.
9853 (Fgnutls_boot): Return handshake error code.
9854 (emacs_gnutls_handle_error): New function.
9855 (wsaerror_to_errno): Likewise.
9857 * w32.h (emacs_gnutls_pull): Add prototype.
9858 (emacs_gnutls_push): Likewise.
9860 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9861 (emacs_gnutls_push): Likewise.
9863 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9865 * process.c (wait_reading_process_output): Check if GnuTLS
9866 buffered some data internally if no FDs are set for TLS
9869 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9870 (LIBS): Link to USER_LIBS.
9871 ($(BLD)/gnutls.$(0)): New target.
9873 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9875 * xdisp.c (handle_single_display_spec): Rename the
9876 display_replaced_before_p argument into display_replaced_p, to
9877 make it consistent with the commentary. Fix typos in the
9880 * textprop.c (syms_of_textprop): Remove dead code.
9881 (copy_text_properties): Delete obsolete commentary about an
9882 interface that was deleted long ago. Fix typos in the description
9885 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9886 to changes in oldXMenu/XMenu.h from 2011-04-16.
9887 <menu_help_message, prev_menu_help_message>: Constify.
9888 (IT_menu_make_room): menu->help_text is now `const char **';
9891 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9892 to changes in oldXMenu/XMenu.h from 2011-04-16.
9893 (struct XMenu): Declare `help_text' `const char **'.
9895 * xfaces.c <Qunspecified>: Make extern again.
9897 * syntax.c: Include sys/types.h before including regex.h, as
9900 * doc.c (get_doc_string): Improve the format passed to `error'.
9902 * doprnt.c (doprnt): Improve commentary.
9904 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9906 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9909 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9910 changes in globals.h immediately force recompilation.
9911 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9912 $(CURDIR)/s/ms-w32.h.
9913 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9915 * character.c (Fchar_direction): Function deleted.
9916 (syms_of_character): Don't defsubr it.
9917 <char-direction-table>: Deleted.
9919 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9921 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9922 * doprnt.c: Include limits.h.
9923 (SIZE_MAX): New macro.
9924 (doprnt): Return a size_t value. 2nd arg is now size_t.
9925 Many local variables are now size_t instead of int or unsigned.
9926 Improve overflow protection. Support `l' modifier for integer
9927 conversions. Support %l conversion. Don't assume an EMACS_INT
9928 argument for integer conversions and for %c.
9930 * lisp.h (doprnt): Restore prototype.
9932 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9935 * Makefile.in (base_obj): Add back doprnt.o.
9937 * deps.mk (doprnt.o): Add back prerequisites.
9938 (callint.o): Depend on character.h.
9940 * eval.c (internal_lisp_condition_case): Include the handler
9941 representation in the error message.
9942 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9943 when breaking from the loop.
9945 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9947 * callint.c (Fcall_interactively): When displaying error message
9948 about invalid control letter, pass the character's codepoint, not
9949 a pointer to its multibyte form. Improve display of the character
9950 in octal and display also its hex code.
9952 * character.c (char_string): Use %x to display the (unsigned)
9953 codepoint of an invalid character, to avoid displaying a bogus
9956 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9957 `error', not SYMBOL_NAME itself.
9959 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9960 character arguments to `error'.
9962 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9963 to `error' in error message about FINAL_CHAR argument. Make sure
9964 FINAL_CHAR is a character, and use %c when it is passed as
9965 argument to `error'.
9967 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9969 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9971 * w32.c: Include <time.h>.
9972 (sys_localtime): New function.
9974 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9976 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9978 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9980 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9982 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9985 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9987 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9988 gl_state.e_property when gl_state.object is Qt.
9990 * insdel.c (make_gap_larger): Remove limitation of buffer size
9993 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9995 * xdisp.c (lookup_glyphless_char_display)
9996 (produce_glyphless_glyph): Handle cons cell entry in
9997 glyphless-char-display.
9998 (Vglyphless_char_display): Document it.
10000 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10001 glyphless-char-display.
10003 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10005 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10007 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10009 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10010 definition for no-X builds.
10012 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10014 Static checks with GCC 4.6.0 and non-default toolkits.
10016 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10018 * process.c (keyboard_bit_set): Define only if SIGIO.
10019 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10020 (send_process): Repair possible setjmp clobbering.
10022 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10024 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10026 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10028 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10029 Define only if needed.
10031 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10032 by pacifying GCC about it. Maybe it's time to retire it?
10033 * xfaces.c (USG, __TIMEVAL__): Likewise.
10035 * dispextern.h (struct redisplay_interface): Rename param
10036 to avoid shadowing.
10037 * termhooks.h (struct terminal): Likewise.
10038 * xterm.c (xembed_send_message): Likewise.
10040 * insdel.c (make_gap_smaller): Define only if
10041 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10043 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10046 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10047 so that we aren't warned about unused symbols.
10049 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10051 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10053 * xfns.c (x_real_positions): Mark locals as initialized.
10055 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10057 * xterm.c: Fix problems found by static analysis with other toolkits.
10058 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10059 (x_dispatch_event): Declare static if USE_GTK, and
10060 define if USE_GTK || USE_X_TOOLKIT.
10061 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10062 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10063 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10064 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10066 * xmenu.c (menu_help_callback): Pointer type fixes.
10067 Use const pointers when pointing at readonly data. Avoid pointer
10068 signedness clashes.
10069 (FALSE): Remove unused macro.
10070 (update_frame_menubar): Remove unused decl.
10072 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10074 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10075 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10076 (single_menu_item): Rename local to avoid shadowing.
10078 * keyboard.c (make_lispy_event): Remove unused local var.
10080 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10081 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10083 * bitmaps: Change bitmaps from unsigned char back to the X11
10084 compatible char. Avoid the old compiler warnings about
10085 out-of-range initializers by using, for example, '\xab' rather
10088 * xgselect.c (xgselect_initialize): Check vs interface
10089 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10091 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10093 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10094 to read-only memory.
10096 * fns.c (vector): Remove; this old hack is no longer needed.
10098 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10100 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10102 * xrdb.c (x_load_resources): Omit unused local.
10104 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10105 (x_window): Rename locals to avoid shadowing.
10106 (USG): Use the kludged USG macro, to pacify gcc.
10108 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10109 (x_term_init): Remove local to avoid shadowing.
10111 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10113 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10114 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10116 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10118 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10120 Fix regex.c, syntax.c and friends for buffers > 2GB.
10121 * syntax.h (struct gl_state_s): Declare character position members
10124 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10126 * textprop.c (verify_interval_modification, interval_of):
10127 Declare arguments EMACS_INT.
10129 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10132 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10134 * indent.c (Fvertical_motion): Local variable it_start is now
10137 * regex.c (re_match, re_match_2, re_match_2_internal)
10138 (bcmp_translate, regcomp, regexec, print_double_string)
10139 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10140 (re_compile_pattern, re_exec): Declare arguments and local
10141 variables `size_t' and `ssize_t' and return values `regoff_t', as
10143 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10144 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10145 <compile_stack_type>: `size' and `avail' are now `size_t'.
10147 * regex.h <regoff_t>: Use ssize_t, not int.
10148 (re_search, re_search_2, re_match, re_match_2): Arguments that
10149 specify buffer/string position and length are now ssize_t and
10150 size_t. Return type is regoff_t.
10152 2011-04-16 Ben Key <bkey76@gmail.com>
10154 * nsfont.m: Fixed bugs in ns_get_family and
10155 ns_descriptor_to_entity that were caused by using free to
10156 deallocate memory blocks that were allocated by xmalloc (via
10157 xstrdup). This caused Emacs to crash when compiled with
10158 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10159 --enable-checking=xmallocoverrun). xfree is now used to
10160 deallocate these memory blocks.
10162 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10164 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10166 emacs_write: Accept and return EMACS_INT for sizes.
10167 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10169 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10170 Accept and return EMACS_INT.
10171 (emacs_gnutls_write): Return the number of bytes written on
10173 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10174 (emacs_read, emacs_write): Remove check for negative size, as the
10175 Emacs source code has been audited now.
10176 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10177 (emacs_read, emacs_write): Use it.
10178 * process.c (send_process): Adjust to the new signatures of
10179 emacs_write and emacs_gnutls_write. Do not attempt to store
10180 a byte offset into an 'int'; it might overflow.
10181 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10183 * sound.c: Don't assume sizes fit in 'int'.
10184 (struct sound_device.period_size, alsa_period_size):
10185 Return EMACS_INT, not int.
10186 (struct sound_device.write, vox_write, alsa_write):
10187 Accept EMACS_INT, not int.
10188 (wav_play, au_play): Use EMACS_INT to store sizes and to
10189 record read return values.
10191 2011-04-15 Ben Key <bkey76@gmail.com>
10193 * keyboard.c (Qundefined): Don't declare static since it is used
10195 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10196 static since they are used in nsfont.m.
10198 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10200 * process.c (Qprocessp): Don't declare static.
10201 * lisp.h (Qprocessp): Declare again.
10203 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10205 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10207 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10209 Improve C-level modularity by making more things 'static'.
10211 Don't publish debugger-only interfaces to other modules.
10212 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10213 (verify_bytepos, count_markers): Move decls to the only modules
10215 * region-cache.h (pp_cache): Likewise.
10216 * window.h (check_all_windows): Likewise.
10217 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10219 * sysdep.c (croak): Now static, if
10220 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10221 * syssignal.h (croak): Declare only if not static.
10223 * alloc.c (refill_memory_reserve): Now static if
10224 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10225 * lisp.h (refill_memory_reserve): Declare only if not static.
10227 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10228 Define only if USE_LUCID.
10230 * xrdb.c (x_customization_string, x_rm_string): Now static.
10232 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10233 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10235 * xdisp.c (draw_row_with_mouse_face): Now static.
10236 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10238 * window.h (check_all_windows): Mark externally visible.
10240 * window.c (window_deletion_count): Now static.
10242 * undo.c: Make symbols static if they're not exported.
10243 (last_undo_buffer, last_boundary_position, pending_boundary):
10246 * textprop.c (interval_insert_behind_hooks): Now static.
10247 (interval_insert_in_front_hooks): Likewise.
10249 * term.c: Make symbols static if they're not exported.
10250 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10251 (max_frame_lines, tty_set_terminal_modes):
10252 (tty_reset_terminal_modes, tty_turn_off_highlight):
10253 (get_tty_terminal): Now static.
10254 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10255 * termhooks.h (term_mouse_moveto): Do not declare if
10256 HAVE_WINDOW_SYSTEM.
10257 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10258 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10260 * sysdep.c: Make symbols static if they're not exported.
10261 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10263 (sigprocmask_set, full_mask): Remove; unused.
10264 (wait_debugging): Mark as visible.
10265 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10266 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10268 * syntax.c (syntax_temp): Define only if !__GNUC__.
10270 * sound.c (current_sound_device, current_sound): Now static.
10272 * search.c (searchbufs, searchbuf_head): Now static.
10274 * scroll.c (scroll_cost): Remove; unused.
10275 * dispextern.h (scroll_cost): Remove decl.
10277 * region-cache.h (pp_cache): Mark as externally visible.
10279 * process.c: Make symbols static if they're not exported.
10280 (process_tick, update_tick, create_process, chan_process):
10281 (Vprocess_alist, proc_buffered_char, datagram_access):
10282 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10283 (deactivate_process): Mark defn as static, as well as decl.
10284 * lisp.h (create_process): Remove decl.
10285 * process.h (chan_process, Vprocess_alist): Remove decls.
10287 * print.c: Make symbols static if they're not exported.
10288 (print_depth, new_backquote_output, being_printed, print_buffer):
10289 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10290 (print_interval, print_number_index, initial_stderr_stream):
10292 * lisp.h (Fprinc): Remove decl.
10293 (debug_output_compilation_hack): Mark as externally visible.
10295 * sysdep.c (croak): Move decl from here to syssignal.h.
10296 * syssignal.h (croak): Put it here, so the API can be checked when
10297 'croak' is called from dissociate_if_controlling_tty.
10299 * minibuf.c: Make symbols static if they're not exported.
10300 (minibuf_save_list, choose_minibuf_frame): Now static.
10301 * lisp.h (choose_minibuf_frame): Remove decl.
10303 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10305 * lread.c: Make symbols static if they're not exported.
10306 (read_objects, initial_obarray, oblookup_last_bucket_number):
10308 (make_symbol): Remove; unused.
10309 * lisp.h (initial_obarray, make_symbol): Remove decls.
10311 * keyboard.c: Make symbols static if they're not exported.
10312 (single_kboard, recent_keys_index, total_keys, recent_keys):
10313 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10314 (this_single_command_key_start, echoing, last_auto_save):
10315 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10316 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10317 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10318 (Vlispy_mouse_stem, double_click_count):
10320 (force_auto_save_soon): Define only if SIGDANGER.
10321 (ignore_mouse_drag_p): Now static if
10322 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10323 (print_help): Remove; unused.
10324 (stop_character, last_timer_event): Mark as externally visible.
10325 * keyboard.h (ignore_mouse_drag_p): Declare only if
10326 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10327 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10328 * lisp.h (echoing): Remove decl.
10329 (force_auto_save_soon): Declare only if SIGDANGER.
10330 * xdisp.c (redisplay_window): Simplify code, to make it more
10331 obvious that ignore_mouse_drag_p is not accessed if !defined
10332 USE_GTK && !defined HAVE_NS.
10334 * intervals.c: Make symbols static if they're not exported.
10335 (merge_properties_sticky, merge_interval_right, delete_interval):
10337 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10339 * insdel.c: Make symbols static if they're not exported.
10340 However, leave prepare_to_modify_buffer alone. It's never
10341 called from outside this function, but that appears to be a bug.
10342 (combine_after_change_list, combine_after_change_buffer):
10343 (adjust_after_replace, signal_before_change): Now static.
10344 (adjust_after_replace_noundo): Remove; unused.
10345 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10346 (signal_before_change): Remove decls.
10348 * indent.c (val_compute_motion, val_vmotion): Now static.
10350 * image.c: Make symbols static if they're not exported.
10351 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10353 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10354 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10356 * fringe.c (standard_bitmaps): Now static.
10357 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10359 * frame.c: Make symbols static if they're not exported.
10360 (x_report_frame_params, make_terminal_frame): Now static.
10361 (get_frame_param): Now static, unless HAVE_NS.
10362 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10363 (x_get_resource_string): Remove; not used.
10364 * frame.h (make_terminal_frame, x_report_frame_params):
10365 (x_get_resource_string); Remove decls.
10366 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10367 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10369 * font.c, fontset.c: Make symbols static if they're not exported.
10370 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10371 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10372 * font.c (font_close_object): Now static.
10373 * font.h (font_close_object): Remove.
10374 * fontset.c (FONTSET_OBJLIST): Remove.
10375 (free_realized_fontset) #if-0 the body, which does nothing.
10376 (face_suitable_for_char_p): #if-0, as it's never called.
10377 * fontset.h (face_suitable_for_char_p): Remove decl.
10378 * xfaces.c (face_at_string_position):
10379 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10380 since 0 is always ASCII.
10382 * fns.c (weak_hash_tables): Now static.
10384 * fileio.c: Make symbols static if they're not exported.
10385 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10386 (Vwrite_region_annotation_buffers): Now static.
10388 * eval.c: Make symbols static if they're not exported.
10389 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10390 * lisp.h (backtrace_list): Remove decl.
10392 * emacs.c: Make symbols static if they're not exported.
10393 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10394 (fatal_error_code, fatal_error_signal_hook, standard_args):
10396 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10397 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10398 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10399 * lisp.h (fatal_error_signal_hook): Remove decl.
10400 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10402 * editfns.c: Move a (normally-unused) function to its only use.
10403 * editfns.c, lisp.h (get_operating_system_release): Remove.
10404 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10405 worth the hassle of breaking this out.
10407 * xterm.c: Make symbols static if they're not exported.
10408 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10409 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10410 (x_destroy_window, x_delete_display):
10412 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10413 (x_mouse_leave): Remove; unused.
10414 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10415 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10416 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10418 (x_mouse_leave): Declare only if WINDOWSNT.
10419 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10420 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10423 * ftxfont.c: Make symbols static if they're not exported.
10424 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10426 * font.h (ftxfont_driver): Likewise.
10428 * xfns.c: Make symbols static if they're not exported.
10429 (x_last_font_name, x_display_info_for_name):
10430 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10431 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10432 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10433 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10434 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10435 (last_show_tip_args): Now static.
10436 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10437 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10438 (x_screen_planes): Remove; unused.
10439 * dispextern.h (x_screen_planes): Remove decl.
10441 * dispnew.c: Make symbols static if they're not exported.
10442 * dispextern.h (redraw_garbaged_frames, scrolling):
10443 (increment_row_positions): Remove.
10444 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10445 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10447 (redraw_garbaged_frames): Remove; unused.
10449 * xfaces.c: Make symbols static if they're not exported.
10450 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10452 * xterm.h (defined_color): Remove decls.
10453 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10454 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10455 (menu_face_changed_default, defined_color, free_realized_face):
10456 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10457 (ascii_face_of_lisp_face): Remove; unused.
10459 * xdisp.c: Make symbols static if they're not exported.
10460 * dispextern.h (scratch_glyph_row, window_box_edges):
10461 (glyph_to_pixel_coords, set_cursor_from_row):
10462 (get_next_display_element, set_iterator_to_next):
10463 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10464 (show_mouse_face): Remove decls
10465 * frame.h (message_buf_print): Likewise.
10466 * lisp.h (pop_message, set_message, check_point_in_composition):
10468 * xterm.h (set_vertical_scroll_bar): Likewise.
10469 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10470 (message_buf_print, scratch_glyph_row, displayed_buffer):
10471 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10472 (get_next_display_element, show_mouse_face, window_box_edges):
10473 (frame_to_window_pixel_xy, check_point_in_composition):
10474 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10475 (glyph_to_pixel_coords): Remove; unused.
10477 * dired.c (file_name_completion): Now static.
10479 * dbusbind.c (xd_in_read_queued_messages): Now static.
10481 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10482 * data.c (circular_list_error): Remove.
10484 * commands.h (last_point_position, last_point_position_buffer):
10485 (last_point_position_window): Remove decls.
10486 * keyboard.c: Make these variables static.
10488 * coding.h (coding, code_convert_region, encode_coding_gap):
10490 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10491 (iso_code_class, detect_coding, code_convert_region): Now static.
10492 (encode_coding_gap): Remove; unused.
10494 * chartab.c (chartab_chars, chartab_bits): Now static.
10496 * charset.h (charset_iso_8859_1): Remove decl.
10497 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10500 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10501 * ccl.c (Vccl_program_table): Now static.
10502 (check_ccl_update): Remove; unused.
10504 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10505 * category.h: ... from here.
10506 * category.c (check_category_table, set_category_set): Now static.
10508 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10509 * lisp.h: Remove these decls.
10511 * buffer.c (buffer_count): Remove unused var.
10513 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10514 so that it's not optimized away.
10515 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10516 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10517 exported only to the debugger.
10519 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10520 * atimer.h (run_all_atimers): Remove; not exported.
10522 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10523 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10524 was inaccessible from Lisp.
10525 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10526 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10528 alloc.c: Import and export fewer symbols, and remove unused items.
10529 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10531 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10532 it's not optimized away by whole-program optimization.
10533 (message_enable_multibyte, free_misc): Remove.
10534 (catchlist, handlerlist, mark_backtrace):
10535 Declare only if BYTE_MARK_STACK.
10536 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10537 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10538 (message_enable_multibyte): Remove decl.
10539 (free_misc, interval_free_list, float_block, float_block_index):
10540 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10541 (cons_free_list, last_marked_index):
10543 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10544 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10545 (mark_backtrace): Define only if BYTE_MARK_STACK.
10546 * xdisp.c (message_enable_multibyte): Now static.
10548 Declare Lisp_Object Q* variables to be 'static' if not exported.
10549 This makes it easier for human readers (and static analyzers)
10550 to see whether these variables are used from other modules.
10551 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10552 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10553 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10554 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10555 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10556 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10557 * xmenu.c, xselect.c:
10558 Declare Q* vars static if they are not used in other modules.
10559 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10560 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10561 Remove decls of unexported vars.
10562 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10564 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10566 Make Emacs functions such as Fatom 'static' by default.
10567 This makes it easier for human readers (and static analyzers)
10568 to see whether these functions can be called from other modules.
10569 DEFUN now defines a static function. To make the function external
10570 so that it can be used in other C modules, use the new macro DEFUE.
10571 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10572 (Finit_image_library):
10573 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10574 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10575 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10576 Remove decls, since these functions are now static.
10577 (Funintern, Fget_internal_run_time): New decls, since these functions
10578 were already external.
10580 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10581 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10582 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10583 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10584 * keyboard.c, keymap.c, lread.c:
10585 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10586 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10587 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10588 Mark functions with DEFUE instead of DEFUN,
10589 if they are used in other modules.
10590 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10591 decls for now-static functions.
10592 * buffer.h (Fdelete_overlay): Remove decl.
10593 * callproc.c (Fgetenv_internal): Mark as internal.
10594 * composite.c (Fremove_list_of_text_properties): Remove decl.
10595 (Fcomposition_get_gstring): New forward static decl.
10596 * composite.h (Fcomposite_get_gstring): Remove decl.
10597 * dired.c (Ffile_attributes): New forward static decl.
10598 * doc.c (Fdocumntation_property): New forward static decl.
10599 * eval.c (Ffetch_bytecode): New forward static decl.
10600 (Funintern): Remove extern decl; now in .h file where it belongs.
10601 * fileio.c (Fmake_symbolic_link): New forward static decl.
10602 * image.c (Finit_image_library): New forward static decl.
10603 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10604 * intervals.h (Fprevious_property_change):
10605 (Fremove_list_of_text_properties): Remove decls.
10606 * keyboard.c (Fthis_command_keys): Remove decl.
10607 (Fcommand_execute): New forward static decl.
10608 * keymap.c (Flookup_key): New forward static decl.
10609 (Fcopy_keymap): Now static.
10610 * keymap.h (Flookup_key): Remove decl.
10611 * process.c (Fget_process): New forward static decl.
10612 (Fprocess_datagram_address): Mark as internal.
10613 * syntax.c (Fsyntax_table_p): New forward static decl.
10614 (skip_chars): Remove duplicate decl.
10615 * textprop.c (Fprevious_property_change): New forward static decl.
10616 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10618 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10619 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10621 * editfns.c (Fformat): Remove unreachable code.
10623 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10625 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10628 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10630 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10631 when at ZV. (Bug#8487)
10633 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10635 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10637 * keyboard.c (parse_tool_bar_item): Likewise.
10638 * sound.c (sound_cleanup, alsa_close): Likewise.
10639 * termcap.c (tgetent): Likewise.
10640 * xfns.c (x_default_font_parameter): Likewise.
10641 * xsettings.c (read_and_apply_settings): Likewise.
10643 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10644 (overrun_check_free): Protoize.
10646 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10648 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10649 since callers should never pass a negative size.
10650 Change the signature to match that of plain 'read' and 'write'; see
10651 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10652 * lisp.h: Update prototypes of emacs_write and emacs_read.
10654 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10656 * xdisp.c (redisplay_window): Don't try to determine the character
10657 position of the scroll margin if the window start point w->startp
10658 is outside the buffer's accessible region. (Bug#8468)
10660 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10662 Fix write-region and its subroutines for buffers > 2GB.
10663 * fileio.c (a_write, e_write): Modify declaration of arguments and
10664 local variables to support buffers larger than 2GB.
10665 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10667 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10668 argument, local variables, and return value.
10670 * lisp.h: Update prototypes of emacs_write and emacs_read.
10672 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10674 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10676 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10678 Fix more problems found by GCC 4.6.0's static checks.
10680 * xdisp.c (vmessage): Use a better test for character truncation.
10682 * charset.c (load_charset_map): <, not <=, for optimization,
10683 and to avoid potential problems with integer overflow.
10684 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10685 * casetab.c (set_identity, shuffle): Likewise.
10686 * editfns.c (Fformat): Likewise.
10687 * syntax.c (skip_chars): Likewise.
10689 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10690 This also lets GCC 4.6.0 generate slightly better loop code.
10692 * callint.c (Fcall_interactively): <, not <=, for optimization.
10693 (Fcall_interactively): Count the number of arguments produced,
10694 not the number of arguments given. This is simpler and lets GCC
10695 4.6.0 generate slightly better code.
10697 * ftfont.c: Distingish more carefully between FcChar8 and char.
10698 The previous code passed unsigned char * to a functions like
10699 strlen and xstrcasecmp that expect char *, which does not
10700 conform to the C standard.
10701 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10702 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10703 char * when the C standard requires it.
10705 * keyboard.c (read_char): Remove unused var.
10707 * eval.c: Port to Windows vsnprintf (Bug#8435).
10708 Include <limits.h>.
10709 (SIZE_MAX): Define if the headers do not.
10710 (verror): Do not give up if vsnprintf returns a negative count.
10711 Instead, grow the buffer. This ports to Windows vsnprintf, which
10712 does not conform to C99. Problem reported by Eli Zaretskii.
10713 Also, simplify the allocation scheme, by avoiding the need for
10714 calling realloc, and removing the ALLOCATED variable.
10716 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10718 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10719 But keep the doprint source code for now, as we might revamp it
10720 and use it again (Bug#8435).
10721 * lisp.h (doprnt): Remove.
10722 * Makefile.in (base_obj): Remove doprnt.o.
10723 * deps.mk (doprnt.o): Remove.
10725 error: Print 32- and 64-bit integers portably (Bug#8435).
10726 Without this change, on typical 64-bit hosts error ("...%d...", N)
10727 was used to print both 32- and 64-bit integers N, which relied on
10728 undefined behavior.
10729 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10730 * lisp.h (error, verror): Mark as printf-like functions.
10731 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10732 Report overflow in size calculations when allocating printf buffer.
10733 Do not truncate output string at its first null byte.
10734 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10735 Truncate the output at a character boundary, since vsnprintf does not
10737 * charset.c (check_iso_charset_parameter): Convert internal
10738 character to string before calling 'error', since %c now has the
10740 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10741 overflow when computing char to be passed to 'error'. Do not
10742 pass Lisp_Object to 'error'; pass the integer instead.
10743 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10744 formatted with plain %d.
10746 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10748 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10750 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10752 * xterm.c (x_catch_errors): Remove duplicate declaration.
10754 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10756 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10758 2011-04-10 Jim Meyering <meyering@redhat.com>
10760 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10761 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10762 return ssize_t not "int", and use size_t as the buffer length.
10763 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10764 * gnutls.h: Update declarations.
10765 * process.c (read_process_output): Use ssize_t, to match.
10766 (send_process): Likewise.
10768 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10770 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10772 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10774 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10775 Use unsigned char, to match FcChar8 type definition.
10777 * xterm.c (handle_one_xevent):
10778 * xmenu.c (create_and_show_popup_menu):
10779 * xselect.c (x_decline_selection_request)
10780 (x_reply_selection_request): Avoid type-punned deref of X events.
10782 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10784 Fix some uses of `int' instead of EMACS_INT.
10785 * search.c (string_match_1, fast_string_match)
10786 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10787 (scan_buffer, find_next_newline_no_quit)
10788 (find_before_next_newline, search_command, Freplace_match)
10789 (Fmatch_data): Make some `int' variables be EMACS_INT.
10791 * xdisp.c (display_count_lines): 3rd argument and return value now
10792 EMACS_INT. All callers changed.
10793 (pint2hrstr): Last argument is now EMACS_INT.
10795 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10796 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10797 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10798 (decode_coding_utf_16, decode_coding_emacs_mule)
10799 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10800 (decode_coding_ccl, decode_coding_charset)
10801 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10802 (decode_coding_iso_2022, decode_coding_emacs_mule)
10803 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10804 <char_offset, last_offset>: Declare EMACS_INT.
10805 (encode_coding_utf_8, encode_coding_utf_16)
10806 (encode_coding_emacs_mule, encode_invocation_designation)
10807 (encode_designation_at_bol, encode_coding_iso_2022)
10808 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10809 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10811 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10812 (encode_invocation_designation): Last argument P_NCHARS is now
10814 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10815 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10817 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10820 * ccl.c (Fccl_execute_on_string): Declare some variables
10823 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10825 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10827 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10829 * process.c (Fformat_network_address): Doc fix.
10831 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10833 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10835 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10837 * keyboard.c (read_char): Call Lisp function help-form-show,
10838 instead of using internal_with_output_to_temp_buffer.
10839 (Qhelp_form_show): New var.
10840 (syms_of_keyboard): Use DEFSYM macro.
10842 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10844 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10846 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10848 * process.c (Flist_processes): Remove to Lisp.
10849 (list_processes_1): Delete.
10851 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10853 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10855 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10857 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10859 Fix more problems found by GCC 4.6.0's static checks.
10861 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10863 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10865 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10867 * xdisp.c (vmessage): Mark as a printf-like function.
10869 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10871 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10873 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10874 printf-like functions.
10875 (tiff_load): Add casts to remove these marks before passing them
10876 to system-supplied API.
10878 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10880 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10881 This avoids several warnings with gcc -Wstrict-overflow.
10882 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10883 directly, rather than having caller test rule sign. This avoids
10884 some unnecessary tests.
10885 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10886 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10887 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10889 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10890 (xfont_open): Avoid unnecessary tests.
10892 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10894 * composite.h, composite.c (composition_gstring_put_cache):
10895 Use EMACS_INT, not int, for length.
10897 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10898 breaking out part of COMPOSITION_DECODE_RULE.
10899 (COMPOSITION_DECODE_RULE): Use it.
10900 * composite.c (get_composition_id): Remove unused local vars,
10901 by using the new macro.
10903 * textprop.c (set_text_properties_1): Change while to do-while,
10904 since the condition is always true at first.
10906 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10907 (interval_deletion_adjustment): Return unsigned value.
10910 * process.c (list_processes_1, create_pty, read_process_output):
10911 (exec_sentinel): Remove vars that were set but not used.
10912 (create_pty): Remove unnecessary "volatile"s.
10913 (Fnetwork_interface_info): Avoid possibility of int overflow.
10914 (read_process_output): Do adaptive read buffering even if carryover.
10915 (read_process_output): Simplify nbytes computation if buffered.
10917 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10919 * syntax.c (scan_words): Remove var that was set but not used.
10920 (update_syntax_table): Use unsigned instead of int.
10922 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10923 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10924 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10926 * print.c (print_error_message): Avoid int overflow.
10928 * font.c (font_list_entities): Redo for clarity,
10929 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10931 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10932 (font_score): Avoid potential overflow in diff calculation.
10934 * fns.c (substring_both): Remove var that is set but not used.
10935 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10937 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10939 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10940 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10941 can always succeed if overflow has undefined behavior.
10943 * search.c (boyer_moore, wordify): Remove vars set but not used.
10944 (wordify): Omit three unnecessary tests.
10946 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10947 All callers changed. This avoids the need for an unused var.
10949 * casefiddle.c (casify_region): Remove var that is set but not used.
10951 * dired.c (file_name_completion): Remove var that is set but not used.
10953 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10955 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10956 (Finsert_file_contents): Remove unnecessary code checking fd.
10958 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10959 Check for integer overflow on size calculations.
10961 * buffer.c (Fprevious_overlay_change): Remove var that is set
10964 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10965 Remove vars that are set but not used.
10966 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10967 (timer_check_2): Mark vars as initialized.
10969 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10971 * image.c (lookup_image): Remove var that is set but not used.
10972 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10974 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10975 that are set but not used.
10977 * xfns.c (make_invisible_cursor): Don't return garbage
10978 if XCreateBitmapFromData fails (Bug#8410).
10980 * xselect.c (x_get_local_selection, x_handle_property_notify):
10981 Remove vars that are set but not used.
10983 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10984 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10986 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10987 Remove var that is set but not used.
10988 (scroll_bar_windows_size): Now size_t, not int.
10989 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10990 Check for overflow.
10992 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10993 (map_tty_color) [!defined MSDOS]: Likewise.
10995 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10997 * coding.c: Remove vars that are set but not used.
10998 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10999 All callers changed.
11000 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11001 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11002 (decode_coding_charset): Remove vars that are set but not used.
11004 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11005 that is set but not used.
11007 * print.c (print_object): Remove var that is set but not used.
11009 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11010 The gnulib version avoids calling malloc in the usual case,
11011 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11012 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11013 * filelock.c (current_lock_owner): Likewise.
11014 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11015 * sysdep.c: Include allocator.h, careadlinkat.h.
11016 (emacs_no_realloc_allocator): New static constant.
11017 (emacs_readlink): New function.
11018 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11019 ../lib/careadlinkat.h.
11021 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11023 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11024 first non-nil return value).
11026 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11028 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11029 if not defined (Bug#8403).
11031 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11033 * xdisp.c (display_count_lines): Remove parameter `start',
11034 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11035 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11036 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11037 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11038 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11039 and thereabouts. All callers changed.
11040 (get_per_char_metric): Remove parameter `f', unused since
11041 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11043 2011-04-02 Jim Meyering <meyering@redhat.com>
11045 do not dereference NULL upon failed strdup
11046 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11047 (ns_get_family): Likewise.
11049 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11051 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11053 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11055 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11058 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11060 Add lexical binding.
11062 * window.c (Ftemp_output_buffer_show): New fun.
11063 (Fsave_window_excursion):
11064 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11066 * lread.c (lisp_file_lexically_bound_p): New function.
11067 (Fload): Bind Qlexical_binding.
11068 (readevalloop): Remove `evalfun' arg.
11069 Bind Qinternal_interpreter_environment.
11070 (Feval_buffer): Bind Qlexical_binding.
11071 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11073 (syms_of_lread): Declare `lexical-binding'.
11075 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11077 * keyboard.c (eval_dyn): New fun.
11078 (menu_item_eval_property): Use it.
11080 * image.c (parse_image_spec): Use Ffunctionp.
11082 * fns.c (concat, mapcar1): Accept byte-code-functions.
11084 * eval.c (Fsetq): Handle lexical vars.
11085 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11086 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11087 (FletX, Flet): Obey lexical binding.
11088 (Fcommandp): Handle closures.
11089 (Feval): New `lexical' arg.
11090 (eval_sub): New function extracted from Feval. Use it almost
11091 everywhere where Feval was used. Look up vars in lexical env.
11093 (Ffunctionp): Move from subr.el.
11094 (Ffuncall): Handle closures.
11095 (apply_lambda): Remove `eval_flags'.
11096 (funcall_lambda): Handle closures and new byte-code-functions.
11097 (Fspecial_variable_p): New function.
11098 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11099 but without exporting it to Lisp.
11101 * doc.c (Fdocumentation, store_function_docstring):
11102 * data.c (Finteractive_form): Handle closures.
11104 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11107 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11109 (exec_byte_code): New function extracted from Fbyte_code to handle new
11110 calling convention for byte-code-functions. Add new byte-codes.
11112 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11114 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11116 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11118 * xdisp.c (redisplay_internal): Fix prototype.
11120 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11122 * xdisp.c (SCROLL_LIMIT): New macro.
11123 (try_scrolling): Use it when setting scroll_limit.
11124 Limit scrolling to 100 screen lines.
11125 (redisplay_window): Even when falling back on "recentering",
11126 position point in the window according to scroll-conservatively,
11127 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11129 (try_scrolling): When point is above the window, allow searching
11130 as far as scroll_max, or one screenful, to compute vertical
11131 distance from PT to the scroll margin position. This prevents
11132 try_scrolling from unnecessarily failing when
11133 scroll-conservatively is set to a value slightly larger than the
11134 window height. Clean up the case of PT below the margin at bottom
11135 of window: scroll_max can no longer be INT_MAX. When aggressive
11136 scrolling is in use, don't let point enter the opposite scroll
11137 margin as result of the scroll.
11138 (syms_of_xdisp) <scroll-conservatively>: Document the
11139 threshold of 100 lines for never-recentering scrolling.
11141 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11143 * dispextern.h (move_it_by_lines):
11144 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11145 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11146 (message_log_check_duplicate): Remove parameters `prev_bol' and
11147 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11148 (redisplay_internal): Remove parameter `preserve_echo_area',
11149 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11151 * indent.c (Fvertical_motion):
11152 * window.c (window_scroll_pixel_based, Frecenter):
11153 Don't pass `need_y_p' to `move_it_by_lines'.
11155 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11157 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11158 steal a few bits to be more compact.
11159 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11160 Remove unneeded casts.
11162 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11164 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11166 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11167 binding" message (bug#7967).
11169 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11171 Fix more problems found by GCC 4.6.0's static checks.
11173 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11174 Remove unused local var.
11176 * editfns.c (Fmessage_box): Remove unused local var.
11178 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11179 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11180 Omit unused local vars.
11181 * window.c (shrink_windows): Omit unused local var.
11182 * menu.c (digest_single_submenu): Omit unused local var.
11183 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11184 Omit unused local var.
11186 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11187 Don't assume string length fits in int.
11188 (keyremap_step, read_key_sequence): Use size_t for sizes.
11189 (read_key_sequence): Don't check last_real_key_start redundantly.
11191 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11192 instead of alloca (Bug#8344).
11194 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11195 (Fbacktrace_frame): Don't assume nframes fits in int.
11197 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11199 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11202 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11204 * cm.c (calccost): Turn while-do into do-while, for clarity.
11206 * keyboard.c (syms_of_keyboard): Use the same style as later
11207 in this function when indexing through an array. This also
11208 works around GCC bug 48267.
11210 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11212 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11214 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11215 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11217 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11218 This avoids undefined behavior on integer overflow, and is a bit
11219 more convenient anyway since it is compared to a size_t variable.
11221 Variadic C functions now count arguments with size_t, not int.
11222 This avoids an unnecessary limitation on 64-bit machines, which
11223 caused (substring ...) to crash on large vectors (Bug#8344).
11224 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11225 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11226 All variadic functions and their callers changed accordingly.
11227 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11228 * data.c (arith_driver, float_arith_driver): Likewise.
11229 * editfns.c (general_insert_function): Likewise.
11230 * eval.c (struct backtrace.nargs, interactive_p)
11231 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11232 (funcall_lambda, mark_backtrace): Likewise.
11233 * fns.c (concat): Likewise.
11234 * frame.c (x_set_frame_parameters): Likewise.
11235 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11236 0 if not found, not -1. All callers changed.
11238 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11239 (stack_copy_size): Now size_t, not int.
11240 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11242 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11244 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11245 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11246 All callers changed.
11248 * lisp.h (multibyte_char_to_unibyte):
11249 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11250 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11251 * character.h (CHAR_TO_BYTE8):
11252 * cmds.c (internal_self_insert):
11253 * editfns.c (general_insert_function):
11254 * keymap.c (push_key_description):
11255 * search.c (Freplace_match):
11256 * xdisp.c (message_dolog, set_message_1): All callers changed.
11258 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11260 * keyboard.c (safe_run_hook_funcall): New function.
11261 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11262 don't set the hook to nil, but remove the offending function instead.
11263 (Qcommand_hook_internal): Remove, unused.
11264 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11265 Vcommand_hook_internal.
11267 * eval.c (enum run_hooks_condition): Remove.
11268 (funcall_nil, funcall_not): New functions.
11269 (run_hook_with_args): Call each function through a `funcall' argument.
11270 Remove `cond' argument, now redundant.
11271 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11272 (Frun_hook_with_args_until_failure): Adjust accordingly.
11273 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11275 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11277 * dispextern.h (string_buffer_position): Remove declaration.
11279 * print.c (strout): Remove parameter `multibyte', unused since
11280 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11282 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11283 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11284 All callers changed.
11286 * w32.c (_wsa_errlist): Use braces for struct initializers.
11288 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11289 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11290 All callers changed.
11291 (string_buffer_position): Likewise. Also, make static (it's never
11292 used outside xdisp.c).
11293 (cursor_row_p): Remove parameter `w', unused since
11294 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11295 (decode_mode_spec): Remove parameter `precision', introduced during
11296 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11297 All callers changed.
11299 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11301 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11303 2011-03-27 Anders Lindgren <andlind@gmail.com>
11305 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11306 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11307 (ns_update_auto_hide_menu_bar): New functions.
11308 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11309 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11310 ns_constrain_all_frames.
11311 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11312 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11314 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11316 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11318 2011-03-27 Glenn Morris <rgm@gnu.org>
11320 * syssignal.h: Replace RETSIGTYPE with void.
11321 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11322 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11323 Replace SIGTYPE with void everywhere.
11324 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11325 * s/template.h (SIGTYPE): Remove commented out definition.
11327 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11329 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11330 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11332 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11334 * w32.c (read_unc_volume): Use parameter `henum', instead of
11335 global variable `wget_enum_handle'.
11337 * keymap.c (describe_vector): Remove parameters `indices' and
11338 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11339 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11341 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11343 * keyboard.c (timer_check): Remove parameter `do_it_now',
11344 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11345 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11346 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11348 * keyboard.c (read_char):
11349 * w32menu.c (w32_menu_display_help):
11350 * xmenu.c (show_help_event, menu_help_callback):
11351 Adjust calls to `show_help_echo'.
11353 * gtkutil.c (xg_maybe_add_timer):
11354 * keyboard.c (readable_events):
11355 * process.c (wait_reading_process_output):
11356 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11358 * insdel.c (adjust_markers_gap_motion):
11359 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11360 (gap_left, gap_right): Don't call it.
11362 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11364 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11365 incurred during fontification.
11367 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11369 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11370 (DEFVAR_PER_BUFFER): Don't pass it.
11372 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11373 (scrolling_window): Don't pass it.
11375 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11377 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11379 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11381 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11382 of variables specific to SELinux and computation of `encoded_absname'.
11384 * image.c (XPutPixel): Remove unused variable `height'.
11386 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11388 * unexw32.c (get_section_info): Remove unused variable `section'.
11390 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11391 (system_process_attributes): Remove unused variable `sess'.
11392 (sys_read): Remove unused variable `err'.
11394 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11395 (w32_wnd_proc): Remove unused variable `isdead'.
11396 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11397 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11398 (x_create_tip_frame): Remove unused variable `tem'.
11400 * w32inevt.c (w32_console_read_socket):
11401 Remove unused variable `no_events'.
11403 * w32term.c (x_draw_composite_glyph_string_foreground):
11404 Remove unused variable `width'.
11406 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11408 * w32term.c (x_set_glyph_string_clipping):
11409 Don't pass uninitialized region to CombineRgn.
11411 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11413 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11414 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11415 (Fx_close_connection): Remove unused variable `i'.
11417 * w32font.c (w32font_draw): Return number of glyphs.
11418 (w32font_open_internal): Remove unused variable `i'.
11419 (w32font_driver): Add missing initializer.
11421 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11422 (fill_in_menu): Remove unused variable `items_added'.
11424 * w32term.c (last_mouse_press_frame): Remove static global variable.
11425 (w32_clip_to_row): Remove unused variable `f'.
11426 (x_delete_terminal): Remove unused variable `i'.
11428 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11429 (NOTHING): Remove unused static global variable.
11430 (uniscribe_check_otf): Remove unused variable `table'.
11431 (uniscribe_font_driver): Add missing initializers.
11433 2011-03-23 Julien Danjou <julien@danjou.info>
11435 * term.c (Fsuspend_tty, Fresume_tty):
11436 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11437 * window.c (temp_output_buffer_show):
11438 * insdel.c (signal_before_change):
11439 * frame.c (Fhandle_switch_frame):
11440 * fileio.c (Fdo_auto_save):
11441 * emacs.c (Fkill_emacs):
11442 * editfns.c (save_excursion_restore):
11443 * cmds.c (internal_self_insert):
11444 * callint.c (Fcall_interactively):
11445 * buffer.c (Fkill_all_local_variables):
11446 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11448 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11449 unconditionally since it does the check itself.
11451 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11453 Fix more problems found by GCC 4.5.2's static checks.
11455 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11456 the first time through the loop, since we know p0 < p1 then.
11457 This also avoids a gcc -Wstrict-overflow warning.
11459 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11460 leading to a memory leak, possible in functions like
11461 load_charset_map_from_file that can allocate an unbounded number
11462 of objects (Bug#8318).
11464 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11465 that could (at least in theory) be that large.
11467 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11468 This is less likely to overflow, and avoids undefined behavior if
11469 overflow does occur. All callers changed. Use strtoul to scan
11470 for the unsigned long integer.
11471 (pint2hrstr): Simplify and tune code slightly.
11472 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11474 * scroll.c (do_scrolling): Work around GCC bug 48228.
11475 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11477 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11478 This also avoids a warning with gcc -Wstrict-overflow.
11479 (validate_x_resource_name): Simplify count usage.
11480 This also avoids a warning with gcc -Wstrict-overflow.
11482 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11485 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11487 * process.c (Fmake_network_process): Use socklen_t, not int,
11488 where POSIX says socklen_t is required in portable programs.
11489 This fixes a porting bug on hosts like 64-bit HP-UX, where
11490 socklen_t is wider than int (Bug#8277).
11491 (Fmake_network_process, server_accept_connection):
11492 (wait_reading_process_output, read_process_output):
11495 * process.c: Rename or move locals to avoid shadowing.
11496 (list_processes_1, Fmake_network_process):
11497 (read_process_output_error_handler, exec_sentinel_error_handler):
11498 Rename or move locals.
11499 (Fmake_network_process): Define label "retry_connect" only if needed.
11500 (Fnetwork_interface_info): Fix pointer signedness.
11501 (process_send_signal): Add cast to avoid pointer signedness problem.
11502 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11503 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11505 Make tparam.h and terminfo.c consistent.
11506 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11507 Include tparam.h instead, since it declares them.
11508 * cm.h (PC): Remove extern decl; tparam.h now does this.
11509 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11510 * terminfo.c: Include tparam.h, to check interfaces.
11511 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11512 (tparam): Adjust signature to match interface in tparam.h;
11513 this removes some undefined behavior. Check that outstring and len
11514 are zero, which they always are with Emacs.
11515 * tparam.h (PC, BC, UP): New extern decls.
11517 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11518 (xftfont_open): Rename locals to avoid shadowing.
11520 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11521 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11522 (OTF_TAG_SYM): Omit macro if not needed.
11523 (ftfont_list): Remove unused local.
11524 (get_adstyle_property, ftfont_pattern_entity):
11525 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11526 Rename locals to avoid shadowing.
11528 * xfont.c (xfont_list_family): Mark var as initialized.
11530 * xml.c (make_dom): Now static.
11532 * composite.c (composition_compute_stop_pos): Rename local to
11534 (composition_reseat_it): Remove unused locals.
11535 (find_automatic_composition, composition_adjust_point): Likewise.
11536 (composition_update_it): Mark var as initialized.
11537 (find_automatic_composition): Mark vars as initialized,
11538 with a FIXME (Bug#8290).
11540 character.h: Rename locals to avoid shadowing.
11541 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11542 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11543 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11544 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11545 to avoid shadowing.
11547 * textprop.c (property_change_between_p): Remove; unused.
11549 * intervals.c (interval_start_pos): Now static.
11551 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11553 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11554 Rename locals to avoid shadowing.
11556 * sound.c (wav_play, au_play, Fplay_sound_internal):
11557 Fix pointer signedness.
11558 (alsa_choose_format): Remove unused local var.
11559 (wav_play): Initialize a variable to 0, to prevent undefined
11560 behavior (Bug#8278).
11562 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11564 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11566 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11567 clobbering (Bug#8298).
11568 * sysdep.c (sys_subshell): Likewise.
11569 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11571 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11572 This should get cleaned up, so that child_setup has the
11573 same signature on all platforms.
11575 * callproc.c (call_process_cleanup): Now static.
11576 (relocate_fd): Rename locals to avoid shadowing.
11578 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11580 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11581 not to be necessary, and produces flickering.
11583 2011-03-20 Glenn Morris <rgm@gnu.org>
11585 * config.in: Remove file.
11587 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11589 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11590 are now in src/globals.h.
11591 (syms_of_minibuf): Remove spurious & from previous change.
11593 2011-03-20 Leo Liu <sdl.web@gmail.com>
11595 * minibuf.c (completing-read-function): New variable.
11596 (completing-read-default): Rename from completing-read.
11597 (completing-read): Call completing-read-function.
11599 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11601 * xfaces.c (Fx_load_color_file):
11602 Read color file from absolute filename (bug#8250).
11604 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11606 * makefile.w32-in: Update dependencies.
11608 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11610 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11612 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11614 Fix more problems found by GCC 4.5.2's static checks.
11616 * process.c (make_serial_process_unwind, send_process_trap):
11617 (sigchld_handler): Now static.
11619 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11620 That way, the code declares only the vars that it needs.
11621 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11622 * s/cygwin.h (PTY_ITERATION): Likewise.
11623 * s/darwin.h (PTY_ITERATION): Likewise.
11624 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11626 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11627 * process.c (allocate_pty): Don't declare stb unless it's needed.
11629 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11630 (CONSTANTLIM): Remove; unused.
11631 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11632 Define only if needed.
11634 * unexelf.c (unexec): Name an expression,
11635 to avoid gcc -Wbad-function-cast warning.
11636 Use a different way to cause a compilation error if anyone uses
11637 n rather than nn, a way that does not involve shadowing.
11638 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11640 * deps.mk (unexalpha.o): Remove; unused.
11642 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11643 * unexec.h: New file.
11644 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11645 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11646 Depend on unexec.h.
11647 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11648 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11649 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11650 Change as necessary to match prototype in unexec.h.
11652 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11654 (back_comment, skip_chars): Mark vars as initialized.
11656 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11657 Rename locals to avoid shadowing.
11659 * lread.c (read1): Rewrite so as not to use empty "else".
11660 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11662 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11664 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11665 warning when compiling print.c.
11667 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11668 instead of using an uninitialized var.
11669 (font_sort_entities): Mark var as initialized.
11671 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11673 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11674 pointers to constants.
11675 (font_parse_fcname): Remove unused vars.
11676 (font_delete_unmatched): Now static.
11677 (font_get_spec): Remove; unused.
11678 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11679 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11680 Rename or move locals to avoid shadowing.
11682 * fns.c (require_nesting_list, require_unwind): Now static.
11683 (Ffillarray): Rename locals to avoid shadowing.
11685 * floatfns.c (domain_error2): Define only if needed.
11686 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11688 * alloc.c (mark_backtrace): Move decl from here ...
11689 * lisp.h: ... to here, so that it can be checked.
11691 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11692 (Fdefvar): Rewrite so as not to use empty "else".
11693 (lisp_indirect_variable): Name an expression,
11694 to avoid gcc -Wbad-function-cast warning.
11695 (Fdefvar): Rename locals to avoid shadowing.
11697 * callint.c (quotify_arg, quotify_args): Now static.
11698 (Fcall_interactively): Rename locals to avoid shadowing.
11699 Use const pointer when appropriate.
11701 * lisp.h (get_system_name, get_operating_system_release):
11702 Move decls here, to check interfaces.
11703 * process.c (get_operating_system_release): Move decl to lisp.h.
11704 * xrdb.c (get_system_name): Likewise.
11705 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11706 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11707 some of which prompt warnings from gcc -Wbad-function-cast.
11708 (Fformat_time_string, Fencode_time, Finsert_char):
11709 (Ftranslate_region_internal, Fformat):
11710 Rename or remove local vars to avoid shadowing.
11711 (Ftranslate_region_internal): Mark var as initialized.
11713 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11716 * lisp.h (eassert): Check that the argument compiles, even if
11717 ENABLE_CHECKING is not defined.
11719 * data.c (Findirect_variable): Name an expression, to avoid
11720 gcc -Wbad-function-cast warning.
11721 (default_value, arithcompare, arith_driver, arith_error): Now static.
11722 (store_symval_forwarding): Rename local to avoid shadowing.
11723 (Fmake_variable_buffer_local, Fmake_local_variable):
11724 Mark variables as initialized.
11725 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11727 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11728 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11729 Rename locals to avoid shadowing.
11730 (mark_stack): Move local variables into the #ifdef region where
11732 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11733 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11735 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11736 (GC_STRING_CHARS): Remove; not used.
11737 (Fmemory_limit): Cast sbrk's returned value to char *.
11739 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11740 avoids undefined behavior in theory.
11742 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11744 Use functions, not macros, for up- and down-casing (Bug#8254).
11745 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11746 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11747 to use the following functions instead of these macros.
11748 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11749 EMACS_INT, since callers assume the returned value fits in int.
11750 (upcase1): Likewise, for UPCASE_TABLE.
11751 (uppercasep, lowercasep, upcase): New static inline functions.
11752 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11753 the race-condition problem in the old DOWNCASE.
11755 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11756 Rename locals to avoid shadowing.
11757 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11758 (regex_compile, re_search_2, re_match_2_internal):
11759 Remove unused local vars.
11760 (FREE_VAR): Rewrite so as not to use empty "else",
11761 which gcc can warn about.
11762 (regex_compile, re_match_2_internal): Mark locals as initialized.
11763 (RETALLOC_IF): Define only if needed.
11764 (WORDCHAR_P): Likewise. This one is never needed, but is used
11765 only in a comment talking about a compiler bug, so put inside
11766 the #if 0 of that comment.
11767 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11768 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11771 * search.c (boyer_moore): Rename locals to avoid shadowing.
11772 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11773 (PREV_CHAR_BOUNDARY): Likewise.
11775 * search.c (simple_search): Remove unused var.
11777 * dired.c (compile_pattern): Move decl from here ...
11778 * lisp.h: ... to here, so that it can be checked.
11779 (struct re_registers): New forward decl.
11781 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11783 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11785 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11786 Rename locals to avoid shadowing.
11787 (Fvertical_motion): Mark locals as initialized.
11789 * casefiddle.c (casify_object, casify_region): Now static.
11790 (casify_region): Mark local as initialized.
11792 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11794 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11795 New macros, so that the caller can use some names other than
11796 gcpro1, gcpro2, etc.
11797 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11799 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11800 argument, for consistency with GCPRO2_VAR, etc: it is now the
11801 prefix of the variable, not the variable itself. All uses
11803 * dired.c (directory_files_internal, file_name_completion):
11804 Rename locals to avoid shadowing.
11806 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11807 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11808 dired.c's scmp function, had undefined behavior.
11809 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11810 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11811 * buffer.h: ... to here, because these macros use current_buffer,
11812 and the new implementation with inline functions needs to have
11813 current_buffer in scope now, rather than later when the macros
11815 (downcase, upcase1): New static inline functions.
11816 (DOWNCASE, UPCASE1): Reimplement using these functions.
11817 This avoids undefined behavior in expressions like
11818 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11819 from race conditions in accessing the global variables
11820 case_temp1 and case_temp2.
11821 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11822 * lisp.h (case_temp1, case_temp2): Remove their decls.
11823 * character.h (ASCII_CHAR_P): Move from here ...
11824 * lisp.h: ... to here, so that the inline functions mentioned
11825 above can use them.
11827 * dired.c (directory_files_internal_unwind): Now static.
11829 * fileio.c (file_name_as_directory, directory_file_name):
11830 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11832 (file_name_as_directory): Use const pointers when appropriate.
11833 (Fexpand_file_name): Likewise. In particular, newdir might
11834 point at constant storage, so make it a const pointer.
11835 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11836 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11838 (Fset_file_times, Finsert_file_contents, auto_save_error):
11839 Rename locals to avoid shadowing.
11841 * minibuf.c (choose_minibuf_frame_1): Now static.
11842 (Ftry_completion, Fall_completions): Rename or remove locals
11843 to avoid shadowing.
11845 * marker.c (bytepos_to_charpos): Remove; unused.
11847 * lisp.h (verify_bytepos, count_markers): New decls,
11848 so that gcc does not warn that these functions aren't declared.
11850 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11851 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11852 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11853 (copy_text): Remove unused local var.
11855 * filelock.c (within_one_second): Now static.
11856 (lock_file_1): Rename local to avoid shadowing.
11858 * buffer.c (fix_overlays_before): Mark locals as initialized.
11859 (fix_start_end_in_overlays): Likewise. This function should be
11860 simplified by using pointers-to-pointers, but that's a different
11862 (switch_to_buffer_1): Now static.
11863 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11864 (report_overlay_modification): Rename locals to avoid shadowing.
11866 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11867 Fix pointer signedness issue.
11868 (sys_subshell): Mark local as volatile if checking for lint,
11869 to suppress a gcc -Wclobbered warning that does not seem to be right.
11870 (MAXPATHLEN): Define only if needed.
11872 * process.c (serial_open, serial_configure): Move decls from here ...
11873 * systty.h: ... to here, so that they can be checked.
11875 * fns.c (get_random, seed_random): Move extern decls from here ...
11876 * lisp.h: ... to here, so that they can be checked.
11878 * sysdep.c (reset_io): Now static.
11879 (wait_for_termination_signal): Remove; unused.
11881 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11882 (copy_keymap_item, append_key, push_text_char_description):
11884 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11885 (DENSE_TABLE_SIZE): Remove; unused.
11886 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11887 (describe_map_tree):
11888 Rename locals to avoid shadowing.
11890 * keyboard.c: Declare functions static if they are not used elsewhere.
11891 (echo_char, echo_dash, cmd_error, top_level_2):
11892 (poll_for_input, handle_async_input): Now static.
11893 (read_char, kbd_buffer_get_event, make_lispy_position):
11894 (make_lispy_event, make_lispy_movement, apply_modifiers):
11895 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11896 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11897 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11898 (read_key_sequence, read_char): Mark locals as initialized.
11899 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11901 * keyboard.h (make_ctrl_char): New decl.
11902 (mark_kboards): Move decl here ...
11903 * alloc.c (mark_kboards): ... from here.
11905 * lisp.h (force_auto_save_soon): New decl.
11907 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11908 (DEFINE_DUMMY_FUNCTION): New macro.
11909 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11911 (main): Add casts to avoid warnings
11912 if GCC considers string literals to be constants.
11914 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11916 * dbusbind.c: Pointer signedness fixes.
11917 (xd_signature, xd_append_arg, xd_initialize):
11918 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11919 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11920 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11921 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11923 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11924 if GCC considers string literals to be constants.
11925 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11927 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11929 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11930 (print_preprocess, print_object): New macro to fix last change.
11932 * print.c (print_preprocess): Don't forget font objects.
11934 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11936 * emacs.c (USAGE3): Doc fixes.
11938 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11940 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11943 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11945 * lisp.h (VWindow_system, Qfile_name_history):
11946 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11947 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11948 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11950 * w32select.c: Don't #include "keyboard.h".
11951 (run_protected): Add extern declaration for waiting_for_input.
11953 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11954 * w32console.c (detect_input_pending, read_input_pending)
11955 (encode_terminal_code):
11956 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11957 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11958 (w32_system_caret_y, Qfile_name_history):
11959 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11960 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11961 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11962 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11963 * w32proc.c (Qlocal, report_file_error):
11964 * w32term.c (Vwindow_system, updating_frame):
11965 * w32uniscribe.c (initialized, uniscribe_font_driver):
11966 Remove unneeded extern declarations.
11968 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11970 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11972 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11974 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11975 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11976 These macros can no longer be used for assignment.
11978 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11979 Assign struct members directly, instead of using BUF_BEGV etc.
11980 (record_buffer_markers, fetch_buffer_markers): New functions for
11981 recording and fetching special buffer markers.
11982 (set_buffer_internal_1, set_buffer_temp): Use them.
11984 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11986 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11988 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11989 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11991 * xdisp.c (hscroll_window_tree):
11992 (reconsider_clip_changes): Use PT instead of BUF_PT.
11994 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11996 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11997 $(EMACS_ROOT)/lib/intprops.h.
11999 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12001 Fix more problems found by GCC 4.5.2's static checks.
12003 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12004 to unsigned char * to avoid compiler diagnostic.
12005 (xg_free_frame_widgets): Make it clear that a local variable is
12006 needed only if USE_GTK_TOOLTIP.
12007 (gdk_window_get_screen): Make it clear that this macro is needed
12008 only if USE_GTK_TOOLTIP.
12009 (int_gtk_range_get_value): New function, which avoids a diagnostic
12010 from gcc -Wbad-function-cast.
12011 (xg_set_toolkit_scroll_bar_thumb): Use it.
12012 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12013 diagnostic from gcc -Wbad-function-cast.
12014 (get_utf8_string, xg_get_file_with_chooser):
12015 Rename locals to avoid shadowing.
12016 (create_dialog): Move locals to avoid shadowing.
12018 * xgselect.c (xg_select): Remove unused var.
12020 * image.c (four_corners_best): Mark locals as initialized.
12021 (gif_load): Initialize transparent_p to zero (Bug#8238).
12022 Mark another local as initialized.
12023 (my_png_error, my_error_exit): Mark with NO_RETURN.
12025 * image.c (clear_image_cache): Now static.
12026 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12027 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12028 (x_edge_detection): Remove unnecessary cast that
12029 gcc -Wbad-function-cast diagnoses.
12030 (gif_load): Fix pointer signedness.
12031 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12032 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12034 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12036 Improve quality of tests for time stamp overflow.
12037 For example, without this patch (encode-time 0 0 0 1 1
12038 1152921504606846976) returns the obviously-bogus value (-948597
12039 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12040 reports time overflow. See
12041 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12042 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12043 * editfns.c: Include limits.h and intprops.h.
12044 (TIME_T_MIN, TIME_T_MAX): New macros.
12045 (time_overflow): Move earlier, to before first use.
12046 (hi_time, lo_time): New functions, for an accurate test for
12047 out-of-range times.
12048 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12049 (Fget_internal_run_time): Don't assume time_t fits in int.
12050 (make_time): Use list2 instead of Fcons twice.
12051 (Fdecode_time): More accurate test for out-of-range times.
12052 (check_tm_member): New function.
12053 (Fencode_time): Use it, to test for out-of-range times.
12054 (lisp_time_argument): Don't rely on undefined left-shift and
12055 right-shift behavior when checking for time stamp overflow.
12057 * editfns.c (time_overflow): New function, refactoring common code.
12058 (Fformat_time_string, Fdecode_time, Fencode_time):
12059 (Fcurrent_time_string): Use it.
12061 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12062 * dired.c (make_time): Move to ...
12063 * editfns.c (make_time): ... here.
12064 * systime.h: Note the move.
12066 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12068 * fringe.c (update_window_fringes): Remove unused variables.
12070 * unexmacosx.c (copy_data_segment): Also copy __got section.
12073 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12075 * termcap.c [MSDOS]: Include "msdos.h".
12076 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12077 Constify `char *' arguments and their references according to
12078 prototypes in tparam.h.
12080 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12082 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12083 Adapt all references accordingly.
12085 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12087 2011-03-11 Tom Tromey <tromey@redhat.com>
12089 * buffer.c (syms_of_buffer): Remove obsolete comment.
12091 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12093 * termhooks.h (encode_terminal_code): Declare prototype.
12095 * msdos.c (encode_terminal_code): Don't declare prototype.
12097 * term.c (encode_terminal_code): Now external again, used by
12098 w32console.c and msdos.c.
12100 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12101 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12103 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12105 Fix some minor problems found by GCC 4.5.2's static checks.
12107 * fringe.c (update_window_fringes): Mark locals as initialized
12109 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12111 * alloc.c (mark_fringe_data): Move decl from here ...
12112 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12113 to check its interface.
12114 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12116 * fontset.c (free_realized_fontset): Now static.
12117 (Fset_fontset_font): Rename local to avoid shadowing.
12118 (fontset_font): Mark local as initialized.
12119 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12121 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12123 * xselect.c (x_disown_buffer_selections): Remove; not used.
12124 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12125 (x_own_selection, Fx_disown_selection_internal): Rename locals
12126 to avoid shadowing.
12127 (x_handle_dnd_message): Remove local to avoid shadowing.
12129 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12130 so that the caller can use some name other than gcpro1.
12131 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12132 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12133 (Fx_backspace_delete_keys_p):
12134 Use them to avoid shadowing, and rename vars to avoid shadowing.
12135 (x_decode_color, x_set_name, x_window): Now static.
12136 (Fx_create_frame): Add braces to silence GCC warning.
12137 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12138 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12139 Remove unused locals.
12140 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12141 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12142 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12145 * xterm.h (x_mouse_leave): New decl.
12147 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12148 Remove unused functions.
12149 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12150 (x_calc_absolute_position): Now static.
12151 (XTread_socket): Don't define label "out" unless it's used.
12152 Don't declare local "event" unless it's used.
12153 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12154 unless they are used.
12155 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12156 (x_fatal_error_signal): Remove; not used.
12157 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12158 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12159 (x_error_catcher, x_connection_closed, x_error_handler):
12160 (x_error_quitter, xembed_send_message, x_iconify_frame):
12161 (my_log_handler): Rename locals to avoid shadowing.
12162 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12163 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12165 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12166 Rename or move locals to avoid shadowing.
12167 (tty_defined_color, merge_face_heights): Now static.
12168 (free_realized_faces_for_fontset): Remove; not used.
12169 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12170 does not deduce is never used uninitialized.
12171 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12172 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12174 * terminal.c (store_terminal_param): Now static.
12176 * xmenu.c (menu_highlight_callback): Now static.
12177 (set_frame_menubar): Remove unused local.
12178 (xmenu_show): Rename parameter to avoid shadowing.
12179 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12180 since they might point to immutable storage.
12181 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12182 since it's unused otherwise.
12184 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12185 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12186 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12187 avoids a gcc -Wuninitialized diagnostic.
12188 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12189 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12190 does not deduce are never used uninitialized.
12192 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12194 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12195 * window.c (window_loop, size_window):
12196 (run_window_configuration_change_hook, enlarge_window): Likewise.
12198 * window.c (display_buffer): Now static.
12199 (size_window): Mark variables that gcc -Wuninitialized
12200 does not deduce are never used uninitialized.
12201 * window.h (check_all_windows): New decl, to forestall
12202 gcc -Wmissing-prototypes diagnostic.
12203 * dispextern.h (bidi_dump_cached_states): Likewise.
12205 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12207 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12208 Include <limits.h>.
12209 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12210 and to avoid gcc -Wuninitialized warning.
12211 (load_charset_map): Mark variables that gcc -Wuninitialized
12212 does not deduce are never used uninitialized.
12213 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12215 * coding.c (coding_set_source, coding_set_destination):
12216 Use "else { /* comment */ }" rather than "else /* comment */;"
12217 for clarity, and to avoid gcc -Wempty-body warning.
12218 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12219 a block, when the outer 'i' will do.
12220 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12221 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12222 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12223 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12224 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12225 Rename locals to avoid shadowing.
12226 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12227 * coding.c (emacs_mule_char, encode_invocation_designation):
12228 Now static, since they're not used elsewhere.
12229 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12230 (decode_coding_object, encode_coding_object, detect_coding_system):
12231 (decode_coding_emacs_mule): Mark variables that gcc
12232 -Wuninitialized does not deduce are never used uninitialized.
12233 (detect_coding_iso_2022): Initialize a local variable that might
12234 be used uninitialized. Leave a FIXME because it's not clear that
12235 this initialization is needed. (Bug#8211)
12236 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12237 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12238 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12239 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12240 Remove unused macros.
12242 * category.c (hash_get_category_set): Remove unused local var.
12243 (copy_category_table): Now static, since it's not used elsewhere.
12244 * character.c (string_count_byte8): Likewise.
12246 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12247 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12249 * chartab.c (copy_sub_char_table): Now static, since it's not used
12251 (sub_char_table_ref_and_range, char_table_ref_and_range):
12252 Rename locals to avoid shadowing.
12253 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12255 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12256 (BIDI_BOB): Remove unused macro.
12258 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12259 deduce are never used uninitialized.
12260 * term.c (encode_terminal_code): Likewise.
12262 * term.c (encode_terminal_code): Now static. Remove unused local.
12264 * tparam.h: New file.
12265 * term.c, tparam.h: Include it.
12266 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12267 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12268 Move these decls to tparam.h, and make them agree with what
12269 is actually in tparam.c. The previous trick of using incompatible
12270 decls in different modules does not conform to the C standard.
12271 All callers of tparam changed to use tparam's actual API.
12272 * tparam.c (tparam1, tparam, tgoto):
12273 Use const pointers where appropriate.
12275 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12276 * cm.h (struct cm): Likewise.
12277 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12278 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12279 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12280 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12281 (turn_on_face, init_tty): Likewise.
12282 * termchar.h (struct tty_display_info): Likewise.
12284 * term.c (term_mouse_position): Rename local to avoid shadowing.
12286 * alloc.c (mark_ttys): Move decl from here ...
12287 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12289 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12291 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12293 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12295 * search.c (compile_pattern_1): Remove argument regp, unused since
12296 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12297 (compile_pattern): Don't pass it.
12299 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12301 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12302 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12304 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12306 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12308 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12309 gdk_window_get_screen, gdk_window_get_geometry,
12310 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12311 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12312 (xg_get_pixbuf_from_pixmap): New function.
12313 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12314 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12315 Call xg_get_pixbuf_from_pixmap instead of
12316 gdk_pixbuf_get_from_drawable.
12317 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12318 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12319 (xg_check_special_colors): Use GtkStyleContext and its functions
12321 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12322 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12323 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12324 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12325 Call gtk_widget_get_preferred_size.
12326 (xg_frame_resized): gdk_window_get_geometry only takes 5
12328 (xg_win_to_widget, xg_event_is_for_menubar):
12329 Call gdk_x11_window_lookup_for_display.
12330 (xg_set_widget_bg): New function.
12331 (delete_cb): New function.
12332 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12333 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12334 (xg_set_background_color): Call xg_set_widget_bg.
12335 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12336 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12337 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12338 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12340 (update_frame_tool_bar): Call gtk_widget_hide.
12341 (xg_initialize): Use GDK_KEY_g.
12343 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12345 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12347 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12348 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12349 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12351 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12353 * w32xfns.c (select_palette): Check success of RealizePalette against
12354 GDI_ERROR, not zero.
12356 See ChangeLog.11 for earlier changes.
12358 ;; Local Variables:
12362 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12364 This file is part of GNU Emacs.
12366 GNU Emacs is free software: you can redistribute it and/or modify
12367 it under the terms of the GNU General Public License as published by
12368 the Free Software Foundation, either version 3 of the License, or
12369 (at your option) any later version.
12371 GNU Emacs is distributed in the hope that it will be useful,
12372 but WITHOUT ANY WARRANTY; without even the implied warranty of
12373 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12374 GNU General Public License for more details.
12376 You should have received a copy of the GNU General Public License
12377 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.