1 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3 Fix minor GTK3 problems found by static checking.
4 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6 (struct _EmacsFixedClass, emacs_fixed_get_type):
7 Move decls here from emacsgtkfixed.h, since they needn't be public.
8 (emacs_fixed_get_type): Now static.
9 (emacs_fixed_class_init): Omit unused local.
10 (emacs_fixed_child_type): Remove; unused.
11 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
12 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
13 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
14 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
15 (EMACS_FIXED_GET_CLASS): Remove; unused.
16 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
18 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
19 Problem reported by Juanma Barranquero for Windows -Wunused-function.
21 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
23 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
24 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
25 (__malloc_size_t, __malloc_ptrdiff_t):
26 Remove. All uses removed, replaced by the definiens if needed,
27 since we can assume C89 or better now.
28 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
29 (protect_malloc_state, align, get_contiguous_space)
30 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
31 (malloc_atfork_handler_child, malloc_enable_thread)
32 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
33 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
34 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
35 (special_realloc, _realloc_internal_nolock, _realloc_internal)
36 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
37 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
38 Define using prototypes, not old style.
39 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
40 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
41 (align): Don't assume that signed integer overflow wraps around.
42 Omit unused local var.
43 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
44 (_free_internal_nolock, memalign, mallochook, reallochook):
45 Omit no-longer-needed casts.
46 (valloc): Use getpagesize, not __getpagesize.
47 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
48 (struct hdr): The 'magic' member is now size_t, not unsigned long.
50 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
52 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
54 Move functions from C to Lisp. Make non-blocking method calls
55 the default. Implement further D-Bus standard interfaces.
57 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
58 (QCdbus_request_name_allow_replacement)
59 (QCdbus_request_name_replace_existing)
60 (QCdbus_request_name_do_not_queue)
61 (QCdbus_request_name_reply_primary_owner)
62 (QCdbus_request_name_reply_in_queue)
63 (QCdbus_request_name_reply_exists)
64 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
65 (QCdbus_registered_serial, QCdbus_registered_method)
66 (QCdbus_registered_signal): New Lisp objects.
67 (XD_DEBUG_MESSAGE): Use sizeof.
68 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
69 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
70 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
71 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
72 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
73 (xd_signature, xd_append_arg): Allow float for integer types.
74 (xd_get_connection_references): New function.
75 (xd_get_connection_address): Rename from xd_initialize. Return
77 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
78 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
80 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
81 Return number of recounts.
82 (Fdbus_get_unique_name): Make stronger parameter check.
83 (Fdbus_message_internal): New defun.
84 (Fdbus_call_method, Fdbus_call_method_asynchronously)
85 (Fdbus_method_return_internal, Fdbus_method_error_internal)
86 (Fdbus_send_signal, Fdbus_register_service)
87 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
88 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
89 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
90 (Vdbus_compiled_version, Vdbus_runtime_version)
91 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
92 (Vdbus_message_type_method_return, Vdbus_message_type_error)
93 (Vdbus_message_type_signal): New defvars.
94 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
97 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
99 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
100 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
101 Do not assume ptrdiff_t is the same width as 'int'.
103 * alloc.c: Handle unusual debugging option combinations.
104 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
105 since the two debugging options are incompatible.
106 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
108 (mem_init, mem_insert, mem_insert_fixup):
109 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
110 (NEED_MEM_INSERT): Remove; no longer needed.
112 2012-04-22 Leo Liu <sdl.web@gmail.com>
114 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
116 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
118 * sysdep.c [__FreeBSD__]: Minor cleanups.
119 (list_system_processes, system_process_attributes) [__FreeBSD__]:
120 Use Emacs indenting style more consistently. Avoid some casts.
121 Use 'double' consistently rather than mixing 'float' and 'double'.
123 2012-04-21 Eduard Wiebe <usenet@pusto.de>
125 * sysdep.c (list_system_processes, system_process_attributes): Add
126 implementation for FreeBSD (Bug#5243).
128 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
130 * lisp.mk (lisp): Update.
132 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
134 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
135 It is never used otherwise.
137 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
139 * print.c (print_preprocess): Only check print_depth if print-circle
141 (print_object): Check for cycles even when print-circle is nil and
142 print-gensym is t, but only check print_depth if print-circle is nil.
144 2012-04-20 Chong Yidong <cyd@gnu.org>
146 * process.c (wait_reading_process_output): If EIO occurs on a pty,
147 set the status to "failed" and ensure that sentinel is run.
149 2012-04-20 Glenn Morris <rgm@gnu.org>
151 * process.c (Fset_process_inherit_coding_system_flag)
152 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
153 (Fmake_network_process, Fmake_serial_process): Doc fix.
155 2012-04-20 Eli Zaretskii <eliz@gnu.org>
157 * xdisp.c (string_buffer_position_lim): Limit starting position to
159 (set_cursor_from_row): If called for a mode-line or header-line
160 row, return zero immediately.
161 (try_cursor_movement): If inside continuation line, don't back up
162 farther than the first row after the header line, if any.
163 Don't consider the header-line row as "partially visible", even if
164 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
166 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
168 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
171 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
172 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
174 configure: new option --enable-gcc-warnings (Bug#11207)
175 * Makefile.in (C_WARNINGS_SWITCH): Remove.
176 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
177 (ALL_CFLAGS): Use new macros rather than old.
178 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
179 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
180 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
181 -Wunused-result, -Wunused-variable. This should go away once
182 the Emacs and Gnulib regex code is merged.
183 (xmalloc, xrealloc): Now static.
185 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
187 * dired.c (Fsystem_groups): Remove unused local.
189 2012-04-17 Glenn Morris <rgm@gnu.org>
191 * dired.c (Fsystem_users): Doc fix.
193 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
195 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
196 (syms_of_dired): Add them.
198 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
200 Fix minor alloc.c problems found by static checking.
201 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
202 New extern decls, to avoid calling undeclared functions.
203 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
204 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
205 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
206 (NEED_MEM_INSERT): New macro.
207 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
208 Remove one incorrect comment and fix another.
210 Fix minor ralloc.c problems found by static checking.
211 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
212 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
213 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
214 (r_alloc_sbrk): Now static.
216 Improve ralloc.c interface checking.
217 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
218 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
219 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
220 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
221 [REL_ALLOC]: ... to here, to check interface.
222 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
223 Remove decls. This fixes an "It stinks!".
225 * alloc.c (which_symbols): Fix alignment issue / type clash.
227 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
229 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
230 (struct Lisp_Misc_Any): Likewise.
231 (struct Lisp_Free): Likewise.
232 * alloc.c (union aligned_Lisp_Symbol): Define.
233 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
234 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
235 (union aligned_Lisp_Misc): Define.
236 (MARKER_BLOCK_SIZE, struct marker_block): Use union
237 aligned_Lisp_Misc instead of union Lisp_Misc.
238 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
240 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
242 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
243 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
244 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
245 * s/netbsd.h, s/sol2-6.h:
246 Remove definition of GC_MARK_STACK, since the default now works.
247 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
248 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
249 no longer the default.
250 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
252 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
254 * lread.c (lisp_file_lexically_bound_p):
255 Fix hang at ";-*-\n" (bug#11238).
257 2012-04-14 Eli Zaretskii <eliz@gnu.org>
259 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
260 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
262 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
264 * nsterm.m (constrainFrameRect): Always constrain when there is only
265 one screen (Bug#10962).
267 2012-04-13 Ken Brown <kbrown@cornell.edu>
269 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
271 2012-04-13 Reuben Thomas <rrt@sc3d.org>
273 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
275 2012-04-11 Daniel Colascione <dancol@dancol.org>
277 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
278 against is gone. It's better to use vfork now so that when Cygwin
279 gains a new, working vfork, we use it automatically (bug#10398).
281 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
283 * window.c (save_window_save): Obey window-point-insertion-type.
285 2012-04-11 Glenn Morris <rgm@gnu.org>
287 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
289 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
291 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
293 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
295 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
296 (force_quit_count): New var.
297 (handle_interrupt): Use it.
299 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
301 * w32.c (w32_delayed_load): Record the full path of the library
302 being loaded (bug#10424).
304 2012-04-09 Glenn Morris <rgm@gnu.org>
306 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
307 not just in the obarray, before snarfing them. (Bug#11036)
309 * Makefile.in ($(leimdir)/leim-list.el):
310 Pass EMACS rather than BUILT_EMACS.
312 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
314 * process.c (make_process):
315 * process.h: Add integer `gnutls_handshakes_tried' member to
318 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
319 Add convenience `GNUTLS_LOG2i' macro.
321 * gnutls.c (gnutls_log_function2i): Convenience log function.
322 (emacs_gnutls_read): Use new log functions,
323 `gnutls_handshakes_tried' process member, and
324 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
325 attempts per process (connection).
327 2012-04-09 Chong Yidong <cyd@gnu.org>
329 * eval.c (Fuser_variable_p, user_variable_p_eh)
330 (lisp_indirect_variable): Functions deleted.
331 (Fdefvar): Caller changed.
333 * callint.c (Finteractive, Fcall_interactively):
334 * minibuf.c (Fread_variable): Callers changed.
336 2012-04-09 Eli Zaretskii <eliz@gnu.org>
338 * xdisp.c (set_cursor_from_row): If the display string appears in
339 the buffer at position that is closer to point than the position
340 after the display string, display the cursor on the first glyph of
341 the display string. Fixes cursor display when a 'display' text
342 property immediately follows invisible text. (Bug#11094)
344 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
346 composite.c: use 'double' consistently
347 * composite.c (get_composition_id): Use 'double' consistently
348 instead of converting 'float' to 'double' and vice versa; this is
349 easier to understand and avoids a GCC warning.
351 2012-04-09 Glenn Morris <rgm@gnu.org>
353 * Makefile.in: Generate leim-list with bootstrap-emacs, in
354 preparation for dumping it with emacs. (Bug#4789)
355 (leimdir): New variable.
356 ($(leimdir)/leim-list.el): New rule.
357 (emacs$(EXEEXT)): Depend on leim-list.el.
359 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
360 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
361 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
363 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
365 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
368 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
370 * xml.c (init_libxml2_functions) [WINDOWSNT]:
371 Remove unused local variable.
373 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
375 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
376 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
377 (mark_memory): Mark Lisp_Objects only if pointers might hide in
378 objects, as mark_maybe_pointer will catch them otherwise.
379 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
380 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
382 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
384 Fix typo that broke non-Windows builds.
385 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
387 2012-04-07 Eli Zaretskii <eliz@gnu.org>
389 Support building on MS-Windows with libxml2.
391 * makefile.w32-in (OBJ2): Add xml.$(O).
392 (GLOBAL_SOURCES): Add xml.c.
393 ($(BLD)/xml.$(O)): New dependency list.
395 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
396 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
397 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
398 [!WINDOWSNT]: New macros.
399 (init_libxml2_functions, libxml2_loaded_p): New functions.
400 (parse_region): Call fn_xmlCheckVersion instead of using the macro
401 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
402 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
403 Calls xmlCleanupParser only if libxml2 was loaded (or statically
405 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
406 Call init_libxml2_functions before calling libxml2 functions.
407 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
409 * emacs.c: Don't include libxml/parser.h.
410 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
411 xmlCleanupParser directly.
413 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
415 2012-04-07 Eli Zaretskii <eliz@gnu.org>
417 * indent.c (Fvertical_motion): If there is a display string at
418 point, use it.vpos to compute how many lines to backtrack after
419 move_it_to point. (Bug#11133)
421 2012-04-06 Eli Zaretskii <eliz@gnu.org>
423 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
424 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
425 about subtle differences between FETCH_CHAR* and STRING_CHAR*
426 macros related to unification of CJK characters. For the details,
427 see the discussion following the message here:
428 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
430 2012-04-04 Chong Yidong <cyd@gnu.org>
432 * keyboard.c (Vdelayed_warnings_list): Doc fix.
434 2012-04-01 Eli Zaretskii <eliz@gnu.org>
436 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
437 instead of alloca. (Bug#11138)
439 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
441 * w32menu.c (is_simple_dialog): Properly check lisp types.
444 2012-03-31 Eli Zaretskii <eliz@gnu.org>
446 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
447 position we get to after a call to move_it_to fails the
448 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
449 only if we wind up in a string from display property. (Bug#11063)
451 * window.c (Fdelete_other_windows_internal): Invalidate the row
452 and column information about mouse highlight, so that redisplay
453 restores it after reallocating the glyph matrices. (Bug#7464)
455 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
456 string comes from a `display' text property, use the buffer
457 position of that property as if we actually saw that position in
459 (move_it_by_lines): Remove the assertion that
460 "it->current_x == 0 && it->hpos == 0" which can be legitimately
461 violated when there's a before-string at the beginning of a line.
464 2012-03-30 Eli Zaretskii <eliz@gnu.org>
466 * xdisp.c (append_space_for_newline): If the default face was
467 remapped, use the remapped face for the appended newline.
468 (extend_face_to_end_of_line): Use the remapped default face for
469 extending the face to the end of the line.
470 (display_line): Call extend_face_to_end_of_line when the default
471 face was remapped. (Bug#11068)
473 2012-03-29 Eli Zaretskii <eliz@gnu.org>
475 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
477 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
479 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
481 2012-03-27 Glenn Morris <rgm@gnu.org>
483 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
486 2012-03-26 Kenichi Handa <handa@m17n.org>
488 * dispextern.h (struct glyph): Fix previous change. Change the
489 bit length of glyphless.ch to 25 (Bug#11082).
491 2012-03-26 Chong Yidong <cyd@gnu.org>
493 * keyboard.c (Vselection_inhibit_update_commands): New variable.
494 (command_loop_1): Use it; inhibit selection update for
495 handle-select-window too (Bug#8996).
497 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
499 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
501 2012-03-25 Kenichi Handa <handa@m17n.org>
503 * dispextern.h (struct glyph): Change the bit length of
504 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
506 2012-03-24 Eli Zaretskii <eliz@gnu.org>
508 * s/ms-w32.h (tzname): Include time.h before redirecting to
509 _tzname. Fixes the MSVC build. (Bug#9960)
511 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
513 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
516 * xterm.c (XTread_socket): Only modify handling_signal if
517 !SYNC_INPUT. (Bug#11080)
519 2012-03-23 Eli Zaretskii <eliz@gnu.org>
521 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
522 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
523 when fetching a multibyte character consumes more bytes than
524 CHAR_BYTES returns, due to unification of CJK characters in
525 string_char. (Bug#11073)
527 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
529 * process.c (wait_reading_process_output): Handle pty disconnect
530 by refraining from sending oneself a SIGCHLD (bug#10933).
532 2012-03-22 Chong Yidong <cyd@gnu.org>
534 * dispextern.h (struct it): New member string_from_prefix_prop_p.
536 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
537 Mark string as coming from a prefix property.
538 (handle_face_prop): Use default face for prefix strings (Bug#4281).
539 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
541 2012-03-21 Chong Yidong <cyd@gnu.org>
543 * xfaces.c (Vface_remapping_alist): Doc fix.
545 2012-03-20 Eli Zaretskii <eliz@gnu.org>
547 * w32proc.c (Fw32_set_console_codepage)
548 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
551 2012-03-20 Chong Yidong <cyd@gnu.org>
553 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
554 to reflect default non-nil value of redisplay-dont-pause.
556 2012-03-19 Kenichi Handa <handa@m17n.org>
558 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
559 it fit in a valid range (Bug#11003).
561 2012-03-18 Eli Zaretskii <eliz@gnu.org>
563 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
564 that is not from display property, accept the row as a "cursor
565 row" if one of the string's character has a non-nil `cursor'
566 property. Fixes cursor positioning when there are newlines in
567 overlay strings, e.g. in icomplete.el. (Bug#11035)
569 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
571 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
573 2012-03-12 Chong Yidong <cyd@gnu.org>
575 * eval.c (inhibit_lisp_code): Rename from
576 inhibit_window_configuration_change_hook; move from window.c.
578 * xfns.c (unwind_create_frame_1, Fx_create_frame):
579 * window.c (run_window_configuration_change_hook)
580 (syms_of_window): Callers changed.
582 2012-03-11 Chong Yidong <cyd@gnu.org>
584 * keymap.c (Fkey_description): Doc fix (Bug#9700).
586 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
588 2012-03-10 Chong Yidong <cyd@gnu.org>
590 * frame.c (other_visible_frames): Don't assume the selected frame
591 is visible (Bug#10955).
593 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
595 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
597 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
599 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
600 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
603 2012-03-03 Glenn Morris <rgm@gnu.org>
605 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
607 2012-03-02 Eli Zaretskii <eliz@gnu.org>
609 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
610 position past the first glyph_row that ends at ZV. (Bug#10902)
611 (redisplay_window, next_element_from_string): Fix typos in
613 (redisplay_window): Pass to move_it_vertically the margin in
614 pixels, not in screen lines.
616 2012-03-02 Glenn Morris <rgm@gnu.org>
618 * buffer.c (buffer-list-update-hook): Doc fix.
620 2012-02-29 Eli Zaretskii <eliz@gnu.org>
622 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
623 push_it before setting up the iterator for the first overlay
624 string, even if we have an empty string loaded.
625 (next_overlay_string): If there's an empty string on the iterator
626 stack, pop the stack. (Bug#10903)
628 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
630 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
631 Suggested by Stefan Monnier in
632 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
633 * alloc.c (widen_to_Lisp_Object): New static function.
634 (mark_memory): Also mark Lisp_Objects by fetching pointer words
635 and widening them to Lisp_Objects. This would work even if
636 USE_LSB_TAG is defined and wide integers are used, which might
637 happen in a future version of Emacs.
639 2012-02-25 Chong Yidong <cyd@gnu.org>
641 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
644 * xselect.c (Fx_selection_exists_p): Doc fix.
645 (x_clipboard_manager_save_all): Print an informative message
646 before saving to clipboard manager.
648 2012-02-24 Chong Yidong <cyd@gnu.org>
650 * keyboard.c (process_special_events): Handle all X selection
651 requests in kbd_buffer, not just the next one (Bug#8869).
653 2012-02-23 Chong Yidong <cyd@gnu.org>
655 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
656 call when setting menu-bar-lines and tool-bar-lines parameters.
657 (unwind_create_frame_1): New helper function.
659 * window.c (inhibit_window_configuration_change_hook): New var.
660 (run_window_configuration_change_hook): Obey it.
661 (syms_of_window): Initialize it.
663 2012-02-22 Chong Yidong <cyd@gnu.org>
665 * xterm.c (x_draw_image_relief): Add missing type check for
666 Vtool_bar_button_margin (Bug#10743).
668 2012-02-21 Chong Yidong <cyd@gnu.org>
670 * fileio.c (Vfile_name_handler_alist): Doc fix.
672 * buffer.c (Fget_file_buffer): Protect against invalid file
673 handler return value.
675 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
677 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
678 when computing $valmask.
680 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
681 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
682 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
683 It's useless in that case, and it can cause problems on hosts
684 that allocate halves of EMACS_INT values separately.
685 Reported by Dan Horák. Diagnosed by Andreas Schwab in
686 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
687 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
688 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
689 it avoids undefined behavior on hosts where shifting right by more
690 than the word width has undefined behavior.
692 2012-02-19 Chong Yidong <cyd@gnu.org>
694 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
695 (Funhandled_file_name_directory, Ffile_name_as_directory)
696 (Fdirectory_file_name, Fexpand_file_name)
697 (Fsubstitute_in_file_name): Protect against invalid file handler
698 return values (Bug#10845).
700 2012-02-18 Eli Zaretskii <eliz@gnu.org>
702 * .gdbinit (pitx): Fix incorrect references to fields of the
705 2012-02-17 Chong Yidong <cyd@gnu.org>
707 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
709 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
711 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
712 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
714 2012-02-15 Chong Yidong <cyd@gnu.org>
716 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
717 marked as special. Also, starting docstrings with * is obsolete.
719 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
721 * gnutls.c (emacs_gnutls_write): Fix last change.
723 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
725 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
728 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
730 * keymap.c (Fsingle_key_description): Handle char ranges.
732 2012-02-12 Chong Yidong <cyd@gnu.org>
734 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
735 as that creates a dangerous corner case.
737 * window.c (Fdelete_window_internal): Invalidate the mouse
738 highlight (Bug#9904).
740 2012-02-12 Glenn Morris <rgm@gnu.org>
742 * xselect.c (Fx_own_selection_internal)
743 (Fx_get_selection_internal, Fx_disown_selection_internal)
744 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
745 * nsselect.m (Fx_own_selection_internal)
746 (Fx_disown_selection_internal, Fx_selection_exists_p)
747 (Fx_selection_owner_p, Fx_get_selection_internal):
748 Sync docs and argument specs with the xselect.c versions.
750 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
752 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
754 2012-02-11 Eli Zaretskii <eliz@gnu.org>
756 * w32select.c (Fx_selection_exists_p): Sync doc string and
757 argument list with xselect.c. (Bug#10783)
759 * w16select.c (Fx_selection_exists_p): Sync doc string and
760 argument list with xselect.c. (Bug#10783)
762 2012-02-10 Glenn Morris <rgm@gnu.org>
764 * fns.c (Fsecure_hash): Doc fix.
766 2012-02-09 Kenichi Handa <handa@m17n.org>
768 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
770 2012-02-07 Chong Yidong <cyd@gnu.org>
772 * buffer.c (Fbuffer_local_variables)
773 (buffer_lisp_local_variables): Handle unbound vars correctly;
774 don't let Qunbound leak into Lisp.
776 2012-02-07 Glenn Morris <rgm@gnu.org>
778 * image.c (Fimagemagick_types): Doc fix.
780 * image.c (imagemagick-render-type): Change it from a lisp object
781 to an integer. Move the doc here from the lisp manual.
782 Treat all values not equal to 0 the same.
784 2012-02-06 Chong Yidong <cyd@gnu.org>
786 * doc.c (store_function_docstring): Avoid applying docstring of
787 alias to base function (Bug#2603).
789 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
791 * .gdbinit (pp1, pv1): Remove redundant defines.
794 2012-02-04 Chong Yidong <cyd@gnu.org>
796 * nsterm.m: Declare a global (Bug#10694).
798 2012-02-04 Eli Zaretskii <eliz@gnu.org>
800 * w32.c (get_emacs_configuration_options):
801 Include --enable-checking, if specified, in the return value.
803 2012-02-04 Martin Rudalics <rudalics@gmx.at>
805 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
806 after rounding frame sizes. (Bug#9723)
808 2012-02-04 Eli Zaretskii <eliz@gnu.org>
810 * keyboard.c (adjust_point_for_property): Don't position point
811 before BEGV. (Bug#10696)
813 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
815 Handle overflow when computing char display width (Bug#9496).
816 * character.c (char_width): Return EMACS_INT, not int.
817 (char_width, c_string_width): Check for overflow when
818 computing the width; this is possible now that individual
819 characters can have unbounded width. Problem introduced
820 by merge from Emacs 23 on 2012-01-19.
822 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
824 * dbusbind.c (Fdbus_register_method): Mention the return value
825 :ignore in the docstring.
827 2012-02-02 Glenn Morris <rgm@gnu.org>
829 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
831 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
832 Unconditionally set to t. (Bug#10673)
833 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
834 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
835 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
837 2012-02-02 Kenichi Handa <handa@m17n.org>
839 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
840 0, do not call append_composite_glyph.
842 2012-02-02 Kenichi Handa <handa@m17n.org>
844 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
846 (x_produce_glyphs): If the component of a composition is a null
847 string, set it->pixel_width to 1 to avoid zero-width glyph.
849 2012-02-01 Eli Zaretskii <eliz@gnu.org>
851 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
852 first 2 arguments are identical. This makes inserting large
853 output from a subprocess an order of magnitude faster on
854 MS-Windows, where all sbrk'ed memory is always contiguous.
856 2012-01-31 Glenn Morris <rgm@gnu.org>
858 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
859 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
860 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
862 2012-01-29 Glenn Morris <rgm@gnu.org>
864 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
866 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
868 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
870 2012-01-28 Chong Yidong <cyd@gnu.org>
872 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
874 2012-01-26 Chong Yidong <cyd@gnu.org>
876 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
878 * search.c (Fsearch_forward, Fsearch_backward): Document negative
879 repeat counts (Bug#10507).
881 2012-01-26 Glenn Morris <rgm@gnu.org>
883 * lread.c (syms_of_lread): Doc fix.
885 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
887 * coding.c (encode_designation_at_bol): Change return value to
890 2012-01-25 Chong Yidong <cyd@gnu.org>
892 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
894 2012-01-21 Chong Yidong <cyd@gnu.org>
896 * floatfns.c (Fcopysign): Make the second argument non-optional,
897 since nil is not allowed anyway.
899 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
901 * process.c (read_process_output): Use p instead of XPROCESS (proc).
902 (send_process): Likewise.
904 2012-01-19 Martin Rudalics <rudalics@gmx.at>
906 * window.c (save_window_save, Fcurrent_window_configuration)
907 (Vwindow_persistent_parameters): Do not use Qstate.
910 2012-01-19 Kenichi Handa <handa@m17n.org>
912 * character.c (char_width): New function.
913 (Fchar_width, c_string_width, lisp_string_width):
914 Use char_width (Bug#9496).
916 2012-01-16 Martin Rudalics <rudalics@gmx.at>
918 * window.c (Vwindow_persistent_parameters): New variable.
919 (Fset_window_configuration, save_window_save): Handle persistent
922 2012-01-14 Eli Zaretskii <eliz@gnu.org>
924 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
925 thrashing the stack of the thread. (Bug#9087)
927 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
929 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
931 2012-01-11 Eli Zaretskii <eliz@gnu.org>
933 * xdisp.c (rows_from_pos_range): Handle the case where the
934 highlight ends on a newline. (Bug#10464)
935 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
936 he end column for display of highlight that ends on a newline
939 2012-01-11 Glenn Morris <rgm@gnu.org>
941 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
942 from load-path also when installation-directory is nil. (Bug#10208)
944 2012-01-10 Glenn Morris <rgm@gnu.org>
946 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
948 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
949 Update template values to be closer to their typical values these days.
951 2012-01-09 Eli Zaretskii <eliz@gnu.org>
953 * xdisp.c (rows_from_pos_range): Accept additional argument
954 DISP_STRING, and accept any glyph in a row whose object is that
955 string as eligible for mouse highlight. Fixes mouse highlight of
956 display strings from overlays. (Bug#10464)
958 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
960 emacs: fix an auto-save permissions race condition (Bug#10400)
961 * fileio.c (auto_saving_dir_umask): New static var.
962 (Fmake_directory_internal): Use it.
963 (do_auto_save_make_dir): Set it, instead of invoking chmod after
964 creating the directory. The old code temporarily assigns
965 too-generous permissions to the directory.
966 (do_auto_save_eh): Clear it.
967 (Fdo_auto_save): Catch all errors, not just file errors, so
968 that the var is always cleared.
970 2012-01-07 Eli Zaretskii <eliz@gnu.org>
972 * search.c (scan_buffer): Pass character positions to
973 know_region_cache, not byte positions. (Bug#6540)
975 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
977 * w32.c (sys_rename): Report EXDEV when rename of a directory
978 fails because the target is on another logical disk. (Bug#10284)
980 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
982 * xterm.c (x_embed_request_focus): New function.
984 * xterm.h: Add prototype.
986 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
988 2012-01-05 Glenn Morris <rgm@gnu.org>
990 * emacs.c (emacs_copyright): Update short copyright year to 2012.
992 2012-01-01 Eli Zaretskii <eliz@gnu.org>
994 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
995 Load gnutls_transport_set_lowat only if GnuTLS version is below
997 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
998 GnuTLS versions below 2.11.1.
1000 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1002 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1003 to the doc string advising against its use for altering the way
1004 windows are scrolled.
1006 2011-12-28 Kenichi Handa <handa@m17n.org>
1008 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1009 coding-system ASCII compatible only when it does not produce BOM
1010 on encoding (Bug#10383).
1012 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1014 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1016 (create_and_show_popup_menu): Always use menu_position_func for
1019 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1021 * callint.c (Fcall_interactively): Don't truncate prompt string.
1023 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1025 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1026 property that ends at ZV, so that the bidi iteration could be
1027 resumed from there (after widening). (Bug#10360)
1029 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1031 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1033 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1035 * nsterm.m (x_free_frame_resources):
1036 Release f->output_data.ns->miniimage.
1037 (ns_index_color): Fix indentation. Do not retain
1038 color_table->colors[i].
1040 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1043 * nsfns.m (x_set_background_color): Assign return value from
1044 ns_index_color to face-background instead of NSColor*.
1045 (ns_implicitly_set_icon_type): Fix indentation.
1046 Change assignment in for loop to comparison.
1048 * emacs.c (ns_pool): New variable.
1049 (main): Assign ns_pool.
1050 (Fkill_emacs): Call ns_release_autorelease_pool.
1052 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1053 autorelease fdesc, release fdAttrs and tdict.
1054 (ns_get_covering_families): Release charset.
1055 (ns_findfonts): Release NSFontDescriptor created with new.
1056 (ns_uni_to_glyphs): Fix indentation.
1057 (setString): Release attrStr before assigning new value.
1059 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1061 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1063 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1064 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1066 2011-12-18 David Reitter <reitter@cmu.edu>
1068 * nsterm.m (ns_term_init): Subscribe for notifications
1069 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1070 to method trackingNotification in EmacsMenu.
1072 * nsmenu.m (trackingMenu): New variable.
1073 (trackingNotification): New method (from Aquamacs).
1074 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1075 from Aquamacs (Bug#7030).
1077 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1079 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1080 (symbol_to_nsstring): Fix indentation.
1081 (ns_symbol_to_pb): New function.
1082 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1083 (Fns_rotate_cut_buffers_internal): Remove.
1084 (Fns_store_selection_internal): Rename from
1085 Fns_store_cut_buffer_internal.
1086 (ns_get_foreign_selection, Fx_own_selection_internal)
1087 (Fx_disown_selection_internal, Fx_selection_exists_p)
1088 (Fns_get_selection_internal, Fns_store_selection_internal):
1089 Use ns_symbol_to_pb and check if return value is nil.
1090 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1091 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1092 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1093 renamed to Sns_store_selection_internal.
1094 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1095 and remove this function.
1096 (ns_handle_selection_clear): Remove, never used.
1097 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1100 2011-12-17 Ken Brown <kbrown@cornell.edu>
1102 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1103 GID is unknown (Bug#10257).
1105 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1107 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1108 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1109 which caused a build failure on GNU/Linux IA-64. This problem was
1110 introduced by my 2011-10-07 patch.
1112 2011-12-15 Juri Linkov <juri@jurta.org>
1114 * image.c (imagemagick_error): New function. (Bug#10112)
1115 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1116 Use `imagemagick_error' where ImageMagick functions return
1118 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1121 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1123 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1124 fill background (Bug#8992).
1126 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1128 * window.c (Vwindow_combination_resize)
1129 (Vwindow_combination_limit): Use t instead of non-nil in
1131 (Vrecenter_redisplay): Add first sentence of doc-string on
1133 (Frecenter): Fix doc-string typo.
1135 2011-12-11 Kenichi Handa <handa@m17n.org>
1137 * coding.c (Funencodable_char_position): Pay attention to the
1138 buffer text relocation (Bug#9389).
1140 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1142 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1143 gtk_init (Bug#10100).
1145 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1147 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1148 IT->string is nil. (Bug#10263)
1150 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1152 * nsterm.h (x_free_frame_resources): Declare.
1154 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1155 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1157 * nsterm.h (ns_get_defaults_value): Declare.
1159 * nsterm.m (ns_default): Call ns_get_defaults_value.
1161 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1163 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1166 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1168 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1169 that where the value of an _OBJC_* symbol points to is in the .bss
1170 section (Bug#10240).
1172 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1174 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1175 after the loop to call ccl_driver at least once (Bug#8619).
1177 2011-12-08 Kenichi Handa <handa@m17n.org>
1179 * ftfont.c (get_adstyle_property): Fix previous change
1182 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1184 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1185 dirs from the default value of EMACSLOADPATH (bug#10208).
1187 2011-12-07 Glenn Morris <rgm@gnu.org>
1189 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1190 installation and source directories as well. (Bug#10208)
1192 2011-12-06 Chong Yidong <cyd@gnu.org>
1194 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1196 2011-12-06 Glenn Morris <rgm@gnu.org>
1198 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1199 as an error, not just -1. (Bug#10217)
1201 2011-12-05 Chong Yidong <cyd@gnu.org>
1203 * keyboard.c (process_special_events): New function.
1204 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1206 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1208 * coding.c (encode_designation_at_bol): Don't use uninitialized
1209 local variable (Bug#9318).
1211 2011-12-05 Kenichi Handa <handa@m17n.org>
1213 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1214 return Qnil (Bug#8046, Bug#10193).
1216 2011-12-05 Kenichi Handa <handa@m17n.org>
1218 * coding.c (encode_designation_at_bol): New args charbuf_end and
1219 dst. Return the number of produced bytes. Callers changed.
1220 (coding_set_source): Return how many bytes coding->source was
1222 (coding_set_destination): Return how many bytes
1223 coding->destination was relocated.
1224 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1225 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1227 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1229 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1230 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1233 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1235 The following changes are to fix Bug#9318.
1237 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1238 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1239 (encode_coding_iso_2022, encode_coding_sjis)
1240 (encode_coding_big5, encode_coding_charset): Use the above macros.
1242 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1244 * lisp.h (process_quit_flag): Fix external declaration.
1246 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1248 Don't macro-inline non-performance-critical code.
1249 * eval.c (process_quit_flag): New function.
1250 * lisp.h (QUIT): Use it.
1252 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1254 * nsfns.m (get_geometry_from_preferences): New function.
1255 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1257 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1259 * emacs.c (Qkill_emacs): Define.
1260 (syms_of_emacs): Initialize it.
1261 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1262 Qquit_flag to `kill-emacs' instead.
1263 (quit_throw_to_read_char): Add parameter `from_signal'.
1264 All callers changed. Call Fkill_emacs if requested and safe.
1265 * lisp.h (QUIT): Call Fkill_emacs if requested.
1267 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1269 * widget.c (update_wm_hints): Return if wmshell is null.
1270 (widget_update_wm_size_hints): New function.
1272 * widget.h (widget_update_wm_size_hints): Declare.
1274 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1275 widget_update_wm_size_hints (Bug#10104).
1277 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1279 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1280 before a newline, prepare the bidi iterator for consuming the
1281 newline, and keep the current paragraph direction. (Bug#10183)
1282 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1284 2011-12-02 Juri Linkov <juri@jurta.org>
1286 * search.c (Fword_search_regexp): New Lisp function created from
1287 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1288 (Fword_search_backward, Fword_search_forward)
1289 (Fword_search_backward_lax, Fword_search_forward_lax):
1290 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1291 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1293 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1295 * fileio.c (Finsert_file_contents): Move after-change-function call
1296 to before the "handled:" label, since all "goto handled" appear in
1297 cases where the *-change-functions have already been properly called
1300 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1302 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1303 waiting for input. (Bug#10169)
1305 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1307 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1308 verifies glyph row's hash code--we have just reallocated the
1309 glyphs, so their contents can be complete garbage. (Bug#10164)
1311 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1313 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1315 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1317 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1318 attributes are tested _before_ calling verify_row_hash, to protect
1319 against GCC re-ordering of the tests. (Bug#10164)
1321 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1323 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1325 * xterm.c (handle_one_xevent): Only set async_visible and friends
1326 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1327 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1328 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1330 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1332 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1333 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1334 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1335 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1336 All uses changed to use GCPRO1 etc.
1337 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1338 Revert to old implementation (i.e., before 2011-03-11).
1340 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1342 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1343 of scroll runs so as to avoid assigning disabled bogus rows and
1344 unnecessary graphics copy operations.
1346 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1348 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1349 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1350 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1351 (malloc, free, realloc, calloc): Redirect to e_* only when
1354 * lisp.h (GCTYPEBITS): Move before first use.
1355 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1356 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1357 this macro definition.
1359 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1362 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1364 * gtkutil.c (xg_create_frame_widgets):
1365 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1366 present with Gtk+ 2.0.
1368 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1370 * fileio.c (Finsert_file_contents): Undo previous change; see
1371 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1373 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1375 Rename locals to avoid shadowing.
1376 * fileio.c (Finsert_file_contents):
1377 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1378 * process.c (wait_reading_process_output):
1379 Rename inner 'proc' to 'p' to avoid shadowing.
1380 Indent for consistency with usual Emacs style.
1382 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1384 * xdisp.c (redisplay_window): If cursor row is not fully visible
1385 after recentering, and scroll-conservatively is set to a large
1386 number, scroll window by a few more lines to make the cursor fully
1387 visible and out of scroll-margin. (Bug#10105)
1388 (start_display): Don't move to the next line if the display should
1389 start at a newline that is part of a display vector or an overlay
1392 2011-11-24 Juri Linkov <juri@jurta.org>
1394 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1395 after the `MagickPingImage' call. (Bug#10112)
1397 2011-11-23 Chong Yidong <cyd@gnu.org>
1399 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1401 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1403 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1404 making another buffer current. (Bug#10114)
1406 2011-11-23 Glenn Morris <rgm@gnu.org>
1408 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1410 2011-11-23 Chong Yidong <cyd@gnu.org>
1412 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1413 using it (Bug#5984).
1415 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1417 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1418 and header-lines, as they don't have one computed for them.
1421 * .gdbinit (prow): Make displayed values more self-explaining.
1422 Add row's hash code.
1424 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1426 * process.c (wait_reading_process_output): Fix asynchrounous
1427 GnuTLS socket handling on some versions of the GnuTLS library.
1428 (wait_reading_process_output): Add comment and URL.
1430 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1432 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1434 2011-11-21 Chong Yidong <cyd@gnu.org>
1436 * window.c (Fnext_window, Fprevious_window): Doc fix.
1438 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1440 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1442 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1444 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1446 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1448 * window.c (Fset_window_combination_limit): Rename argument
1450 (Vwindow_combination_limit): Remove "status" from doc-string.
1452 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1454 * m/ibms390.h: Remove.
1455 * m/ibms390x.h: Don't include "ibms390.h".
1457 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1459 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1460 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1462 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1464 * casetab.c (Fset_case_table):
1465 * charset.c (Fcharset_after): Fix typos.
1467 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1469 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1470 Otherwise, valgrind does not work on some platforms.
1471 Problem reported by Andreas Schwab in
1472 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1473 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1474 is set, removing the need for VIRT_ADDRESS_VARIES.
1475 (PURE_P): Use a more-efficient implementation that needs just one
1476 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1477 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1478 to 4 (xorl, subq, cmpq, setbe).
1479 * alloc.c (pure): Always extern now, since that's the
1480 VIRT_ADDR_VARIES behavior.
1481 (PURE_POINTER_P): Use a single comparison, not two, for
1482 consistency with the new puresize.h.
1483 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1484 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1485 Remove VIRT_ADDR_VARIES no longer needed.
1487 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1489 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1490 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1491 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1492 behave as if the cursor position were at the window margin.
1494 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1495 and the cursor position is out of bounds, behave as if the cursor
1496 position were at the window margin. (Bug#10075)
1498 2011-11-18 Chong Yidong <cyd@gnu.org>
1500 * window.c (Fwindow_combination_limit): Make first argument
1501 non-optional, since it is meaningless for live windows like the
1504 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1506 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1508 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1510 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1511 (graft_intervals_into_buffer): Simplify.
1513 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1515 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1516 hash values of the two rows.
1517 (copy_row_except_pointers): Preserve the used[] arrays and the
1518 hash values of the two rows. (Bug#10035)
1519 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1521 * xdisp.c (row_hash): New function, body extracted from
1522 compute_line_metrics.
1523 (compute_line_metrics): Call row_hash, instead of computing the
1526 * dispnew.c (verify_row_hash): Call row_hash for computing the
1527 hash code of a row, instead of duplicating code from xdisp.c.
1529 * dispextern.h (row_hash): Add prototype.
1531 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1533 * frame.c (delete_frame): Don't delete the terminal when the last
1534 X frame is closed if emacs is built with GTK toolkit.
1536 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1538 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1540 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1542 * window.c (Vwindow_splits): Rename to
1543 Vwindow_combination_resize. Suggested by Juri Linkov.
1544 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1547 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1549 * nsfns.m (Fns_font_name):
1550 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1552 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1554 * window.h (window): Rename slot "nest" to "combination_limit".
1555 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1556 (Fset_window_nest): Rename to Fset_window_combination_limit.
1557 (Vwindow_nest): Rename to Vwindow_combination_limit.
1558 (recombine_windows, make_parent_window, make_window)
1559 (Fsplit_window_internal, saved_window)
1560 (Fset_window_configuration, save_window_save): Rename all
1561 occurrences of window_nest to window_combination_limit.
1563 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1565 * image.c (imagemagick_load_image): Fix typo.
1567 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1569 * xdisp.c (display_line): Move the call to
1570 highlight_trailing_whitespace before the call to
1571 compute_line_metrics, since the latter needs to see the final
1572 faces of all the glyphs to compute ROW's hash value.
1573 Fixes assertion violations in row_equal_p. (Bug#10035)
1575 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1577 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1578 just return (bug#10044).
1580 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1582 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1583 with user-defined heap size. Bump the default size of the temacs
1584 heap to 27MB, to avoid memory warning when running temacs.
1585 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1587 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1588 current_matrix and desired_matrix. (Bug#9990)
1589 (verify_row_hash) [XASSERTS]: New function.
1590 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1591 that the hash value of glyph rows is correct.
1593 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1595 * window.h (window): Remove splits slot.
1596 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1597 (Fdelete_other_windows_internal, make_parent_window)
1598 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1599 (Fset_window_configuration, save_window_save): Don't deal with
1600 split status of windows.
1601 (saved_window): Remove splits slot.
1602 (Vwindow_splits): Rewrite doc-string.
1604 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1606 * xfns.c (unwind_create_frame):
1607 * nsfns.m (unwind_create_frame):
1608 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1609 Vframe_list (Bug#9999).
1611 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1613 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1615 2011-11-11 Kenichi Handa <handa@m17n.org>
1617 * callproc.c (Fcall_process): Set the member dst_multibyte of
1620 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1622 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1623 avoid a crash (bug#9496).
1625 2011-11-09 Chong Yidong <cyd@gnu.org>
1627 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1628 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1630 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1632 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1634 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1636 Avoid some portability problems by eschewing 'extern inline' functions.
1637 The trivial performance wins aren't worth the portability hassles; see
1638 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1640 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1641 (window_box_width, window_box_left, window_box_left_offset)
1642 (window_box_right, window_box_right_offset): Undo previous change,
1643 by removing the "extern"s.
1644 * intervals.c (adjust_intervals_for_insertion)
1645 (adjust_intervals_for_deletion): Undo previous change,
1646 making these static again.
1647 (offset_intervals, temp_set_point_both, temp_set_point)
1648 (copy_intervals_to_string): No longer inline.
1649 * xdisp.c (window_text_bottom_y, window_box_width)
1650 (window_box_height, window_box_left_offset)
1651 (window_box_right_offset, window_box_left, window_box_right)
1652 (window_box): No longer inline.
1654 2011-11-08 Chong Yidong <cyd@gnu.org>
1656 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1657 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1658 Signal an error if not a live window.
1659 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1660 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1662 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1664 * lisp.h (syms_of_abbrev): Remove declaration.
1665 Reported by CHENG Gao <chenggao@royau.me>.
1667 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1669 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1670 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1671 of temacs in GUI mode.
1673 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1675 * window.h: Declare delete_all_child_windows instead of
1676 delete_all_subwindows.
1677 * window.c (Fwindow_nest, Fset_window_nest)
1678 (Fset_window_new_total, Fset_window_new_normal)
1679 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1680 (delete_all_subwindows): Rename to delete_all_child_windows.
1681 (Fdelete_other_windows_internal, Fset_window_configuration):
1682 Call delete_all_child_windows instead of delete_all_subwindows.
1683 * frame.c (delete_frame): Call delete_all_child_windows instead
1684 of delete_all_subwindows.
1686 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1688 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1689 This is also needed for porting to any host where GC_MARK_STACK is
1690 not GC_MAKE_GCPROS_NOOPS.
1691 (which_symbols): Use it.
1693 2011-11-07 Kenichi Handa <handa@m17n.org>
1695 * coding.c (coding_set_destination): Check coding->src_pos only
1696 when coding->src_object is a buffer (bug#9910).
1698 * process.c (send_process): Set the member src_multibyte of coding
1699 to 0 (bug#9911) when sending a unibyte text.
1701 * callproc.c (Fcall_process): Set the member src_multibyte of
1702 process_coding to 0 (bug#9912).
1704 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1706 * xmenu.c (cleanup_widget_value_tree): New function.
1707 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1708 calling free_menubar_widget_value_tree directly (Bug#9830).
1710 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1712 Fix some portability problems with 'inline'.
1713 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1714 (window_box_width, window_box_left, window_box_left_offset)
1715 (window_box_right, window_box_right_offset): Declare extern.
1716 Otherwise, these inline functions do not conform to C99 and
1717 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1718 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1719 * intervals.c (adjust_intervals_for_insertion)
1720 (adjust_intervals_for_deletion): Now extern, because otherwise the
1721 extern inline functions 'offset_intervals' couldn't refer to it.
1722 (static_offset_intervals): Remove.
1723 (offset_intervals): Rewrite using the old contents of
1724 static_offset_intervals. The old version didn't conform to C99
1725 because an extern inline function contained a reference to an
1726 identifier with static linkage.
1728 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1730 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1733 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1735 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1736 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1737 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1738 return Qleft_to_right.
1740 2011-11-06 Chong Yidong <cyd@gnu.org>
1742 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1743 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1744 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1745 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1746 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1747 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1748 (Fwindow_vscroll): Doc fix.
1749 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1750 argument, since it makes no sense to pass a live window and for
1751 consistency with window-child.
1753 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1755 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1758 2011-11-05 Jason Rumney <jasonr@gnu.org>
1760 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1761 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1763 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1764 bitwise arithmetic preventing use of unicode-sip and non-truetype
1767 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1769 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1772 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1773 initialization code to keep similarity to xfns.c after changes
1776 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1778 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1779 (unwind_create_frame): New function (Bug#9943).
1780 (Fx_create_frame): Restructure code to be more similar to the one in
1781 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1782 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1783 Move terminal->reference_count++ just before making the frame official
1786 * nsterm.m (x_free_frame_resources): New function.
1787 (x_destroy_window): Move code to x_free_frame_resources.
1789 * xfns.c (unwind_create_frame): Fix comment.
1790 (Fx_create_frame, x_create_tip_frame):
1791 Move terminal->reference_count++ just before making the frame
1792 official. Move initialization of image_cache_refcount and
1793 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1795 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1797 Support MSVC build with newer versions of Visual Studio.
1798 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1799 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1802 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1803 which are not supported by MSVC.
1804 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1805 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1807 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1809 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1811 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1813 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1815 Support MSVC build with newer versions of Visual Studio.
1816 * w32.c: Don't include w32api.h for MSVC.
1817 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1819 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1820 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1821 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1822 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1824 (alloca) [_MSC_VER]: Define to _alloca.
1826 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1828 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1830 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1832 * xdisp.c (note_mouse_highlight): If either of
1833 previous/next-single-property-change returns nil, treat that as
1834 the beginning or the end of the buffer. (Bug#9955)
1836 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1838 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1839 label is not null (Bug#9951).
1840 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1843 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1845 * window.c (Fwindow_body_size): Mention in the doc string that the
1846 return value is in frame's canonical units. (Bug#9949)
1848 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1850 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1852 * w32fns.c (unwind_create_frame): If needed, free the glyph
1853 matrices of the partially constructed frame. (Bug#9943)
1854 * xfns.c (unwind_create_frame): Likewise.
1856 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1858 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1859 Don't stop backward scan on the continuation glyph, even though
1860 its CHARPOS is positive.
1861 (mouse_face_from_buffer_pos, note_mouse_highlight):
1862 Rename cover_string to disp_string.
1864 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1866 * window.c (temp_output_buffer_show): Don't use
1867 Vtemp_buffer_show_specifiers.
1868 (Vtemp_buffer_show_specifiers): Remove unused variable.
1870 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1872 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1873 past the beginning of the current glyph matrix.
1875 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1877 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1878 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1879 HAVE_GTK3 (Bug#9869).
1881 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1882 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1884 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1886 * xterm.c: Declare x_handle_net_wm_state to return int.
1887 (handle_one_xevent): Check if we are iconified but don't have
1888 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1889 (get_current_wm_state): Return non-zero if not hidden,
1890 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1891 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1892 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1893 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1895 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1897 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1898 so that this new function doesn't get optimized away by a
1899 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1901 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1903 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1905 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1907 Fix the `xbytecode' command.
1908 * .gdbinit (xprintbytestr): New command.
1909 (xwhichsymbols): Rename from `which'; all callers changed.
1910 (xbytecode): Print the byte-code string as well.
1912 2011-10-29 Kim Storm <storm@cua.dk>
1914 * alloc.c (which_symbols): New function.
1916 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1918 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1921 2011-10-29 Glenn Morris <rgm@gnu.org>
1923 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1924 Not clear what it was for, and it causes various bugs. (Bug#9839)
1926 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1928 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1929 possible random value that matches one of those tested as
1930 condition to clear the mouse face.
1932 2011-10-28 Chong Yidong <cyd@gnu.org>
1934 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1936 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1938 * window.c (make_window): Initialize phys_cursor_on_p.
1940 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1942 * lisp.h (struct Lisp_Symbol): Update comments.
1944 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1946 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1948 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1950 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1951 <oslsachem@gmail.com> for helping to debug this.
1953 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1954 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1955 (g_b_init_get_glyph_outline_w): New static variables.
1956 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1957 (GetGlyphOutlineW_Proc): New typedefs.
1958 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1959 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1961 (w32font_open_internal, compute_metrics):
1962 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1963 instead of calling the "wide" APIs directly.
1965 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1967 * w32.h (syms_of_w32font): Add prototype.
1969 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1971 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1972 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1973 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1974 (Fmove_to_window_line): Doc fix.
1976 2011-10-27 Chong Yidong <cyd@gnu.org>
1978 * process.c (make_process): Set gnutls_state to NULL.
1980 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1981 non-NULL, regardless of GNUTLS_INITSTAGE.
1982 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1983 an error. Set process slots as soon as we allocate them.
1985 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1987 2011-10-27 Chong Yidong <cyd@gnu.org>
1989 * gnutls.c (emacs_gnutls_deinit): New function.
1990 Deallocate credentials structures as well as calling gnutls_deinit.
1991 (Fgnutls_deinit, Fgnutls_boot): Use it.
1993 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1994 (deactivate_process): Call emacs_gnutls_deinit.
1996 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1998 * image.c (x_create_x_image_and_pixmap):
1999 * w32.c (sys_rename, w32_delayed_load):
2000 * w32font.c (fill_in_logfont):
2001 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2003 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2005 * w32fns.c (w32_default_color_map): New function,
2006 extracted from Fw32_default_color_map.
2007 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2009 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2011 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2013 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2015 * keyboard.c (test_undefined): New function (bug#9751).
2016 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2018 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2020 * sysdep.c (init_sys_modes): Fix the check for the controlling
2021 terminal (Bug#6649).
2023 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2025 * dispextern.h (struct bidi_it): New member next_en_type.
2027 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2028 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2029 current character, check also for next_en_type being WEAK_EN.
2030 (bidi_resolve_weak): Don't enter the expensive loop if the current
2031 position is before next_en_pos. Record the bidi type of the first
2032 non-ET, non-BN character we find, in addition to its position.
2033 (bidi_level_of_next_char): Invalidate next_en_type when
2034 next_en_pos is over-stepped.
2036 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2038 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2039 * editfns.c: Rewrite current-time-zone so that it invokes
2040 the equivalent of (format-time-string "%Z") to get the time zone name.
2041 This fixes a bug when the time zone name contains characters that
2042 need converting from the system time locale to Emacs internal format.
2043 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2044 that patch fixed format-time-string to do the conversion, but
2045 I forgot to fix current-time-zone.
2046 (format_time_string): New function, containing most of
2047 what Fformat_time_string used to contain.
2048 (Fformat_time_string): Rewrite in terms of format_time_string.
2049 This doesn't change this function's behavior.
2050 (current-time-zone): Rewrite to use format_time_string.
2051 This fixes the bug reported by Michael Schierl in
2052 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2053 Jason Rumney's 2007-06-07 change worked around this bug, but
2055 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2057 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2059 * xdisp.c (start_display): If the character at POS is displayed
2060 via a display vector, reset IT->current.dpvec_index to zero.
2061 (try_window_reusing_current_matrix): If a line ends in a display
2062 vector or the next line starts in a display vector, continue
2063 redrawing the window even though the character position of
2064 start_row was reached.
2067 2011-10-18 Chong Yidong <cyd@gnu.org>
2069 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2070 with nobreak-char-display too.
2072 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2074 Fix part 3 of bug#9771.
2075 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2076 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2077 non-neutral characters if the current character is a paragraph
2078 separator (a.k.a. Newline). This avoids running the same
2079 expensive loop twice, once when we consume the preceding newline
2080 and the other time when the line actually needs to be displayed.
2081 Avoid the loop when we see neutrals on the base embedding level
2082 following a character whose directionality is the same as the
2083 paragraph's. This avoids running the expensive loop when a line
2084 ends in a long sequence of neutrals, like control characters.
2085 Add assertion against STRONG_AL type. Slightly rearrange code
2086 that determines the type of a neutral given the first non-neutral
2088 (bidi_level_of_next_char): Set next_en_pos to zero when
2089 invalidating its info.
2091 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2093 * xdisp.c (push_display_prop): Determine whether to record string
2094 or buffer position by IT->string, not by IT->method. Allow
2095 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2096 (move_it_vertically_backward): Don't look for character position
2097 immediately after the newline when in a continuation line.
2100 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2102 * window.c (coordinates_in_window): Rewrite and delabelize
2103 vertical border check. (Bug#5357) (Bug#9618)
2105 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2107 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2108 errors in XSetWindowBorder (bug#9310).
2110 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2112 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2113 avoid crash when xmalloc overrun checking is enabled.
2115 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2117 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2118 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2119 cursor motion with <left> and <right> arrow keys.
2121 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2122 some callers set that themselves.
2124 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2126 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2127 display string and the previous row comes from the same string and
2128 is empty. (Bug#9739) (Bug#9738)
2130 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2132 * doc.c (get_doc_string): Encode file name (bug#9735).
2134 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2136 * bidi.c (bidi_level_of_next_char):
2137 * xdisp.c (get_visually_first_element): Remove old incorrect
2138 comments regarding the Unicode Line Separator character.
2140 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2142 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2144 * alloc.c (Fgc_status): Do not access beyond zombies array
2145 boundary if nzombies > MAX_ZOMBIES.
2146 * alloc.c (dump_zombies): Add missing format specifier.
2148 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2150 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2151 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2153 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2154 Some packages use them to denote characters with modifiers.
2156 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2158 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2159 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2160 matching a pp-number. Rename parameter var to var1.
2162 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2164 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2166 2011-10-08 Glenn Morris <rgm@gnu.org>
2168 * callint.c (Fcall_interactively): Give a more explicit error for the
2169 'c' case with a non-character input. (Bug#8479)
2171 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2173 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2175 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2176 lines that are hscrolled on the left.
2178 * dispnew.c (buffer_posn_from_coords): Account for a possible
2179 presence of header-line. (Bug#4426)
2181 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2183 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2184 Don't advertise functionality which we discourage or doesn't work.
2186 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2188 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2189 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2190 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2191 this makes Emacs dump core during garbage collection on rare
2192 occasions. sizeof is obviously inferior to offsetof here, so
2193 stick with offsetof.
2194 (GC_POINTER_ALIGNMENT): New macro.
2195 (mark_memory): Omit 3rd (offset) arg; caller changed.
2196 Don't assume EMACS_INT alignment is the same as pointer alignment.
2198 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2200 * keyboard.c (read_key_sequence_remapped): New var.
2201 (read_key_sequence): Compute remapping in the right buffer.
2202 (command_loop_1): Use read_key_sequence's remapping directly.
2204 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2206 * dired.c (file_name_completion): Don't expand file name.
2207 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2208 before checking file name handler.
2210 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2211 they've been requested explicitly (bug#9591).
2213 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2215 * keymap.c (Fsingle_key_description): Use make_specified_string
2216 instead of build_string to build string from push_key_description.
2219 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2221 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2222 This fixes a Y2038 bug on 64-bit hosts.
2223 * buffer.c (reset_buffer):
2224 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2225 (Fclear_buffer_auto_save_failure):
2226 Use 0, not -1, to represent an unset failure time, since time_t
2227 might not be signed.
2229 Remove dependency on glibc malloc internals.
2230 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2231 Move back here from lisp.h, but with their new implementations.
2232 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2233 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2234 * charset.c (charset_table_init): New static var.
2235 (syms_of_charset): Use it instead of xmalloc. This removes a
2236 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2237 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2238 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2239 Move back to alloc.c.
2240 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2241 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2243 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2245 * nsterm.m (windowDidResize): Call x_set_window_size only when
2246 ns_in_resize is true. Otherwise set pixelwidth/height and
2247 call change_frame_size (Bug#9628).
2249 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2251 Port --enable-checking=all to Fedora 14 x86-64.
2252 * charset.c (syms_of_charset): Also account for glibc malloc's
2253 internal overhead when calculating the initial malloc maximum.
2255 Port --enable-checking=all to Fedora 14 x86.
2256 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2258 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2259 (overrun_check_realloc, overrun_check_free):
2260 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2261 That way, xmalloc returns a properly-aligned pointer even if
2262 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2263 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2264 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2265 into account when calculating the initial malloc maximum.
2266 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2267 Move here from alloc.c, so that charset.c can use it too.
2268 Properly align; the old code wasn't right for common 32-bit hosts
2269 when configured with --enable-checking=all.
2270 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2271 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2273 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2275 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2278 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2280 * xdisp.c (compute_display_string_end): If there's no display
2281 string at CHARPOS, return -1.
2283 * bidi.c (bidi_fetch_char): When compute_display_string_end
2284 returns a negative value, treat the character as a normal
2285 character not covered by a display string. (Bug#9624)
2287 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2289 * lread.c (Fread_from_string): Fix typo in docstring.
2291 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2293 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2294 newline, reseat the iterator instead of bidi-iterating there one
2295 character at a time. (Bug#9610)
2296 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2297 TO_CHARPOS if the bidi iterator is at base embedding level.
2299 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2301 * lread.c (readevalloop): Use correct code for NBSP.
2302 (read1): Likewise. (Bug#9608)
2304 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2306 * dbusbind.c (Fdbus_register_signal): When service is not
2307 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2309 2011-09-25 Glenn Morris <rgm@gnu.org>
2311 * buffer.c (truncate-lines): Doc fix.
2313 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2315 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2316 (Fset_window_next_buffers): Doc fix.
2318 2011-09-24 Glenn Morris <rgm@gnu.org>
2320 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2322 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2324 Fix minor problems found by static checking.
2325 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2326 * indent.c (Fvertical_motion): Fix == vs = typo.
2328 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2330 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2331 Default value is now t. Doc fix.
2333 * indent.c (Fvertical_motion): Compute and apply the overshoot
2334 logic when moving up, not only when moving down. Fix the
2335 confusing name and values of the it_overshoot_expected variable;
2336 logic changes accordingly. (Bug#9254) (Bug#9549)
2338 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2339 CHARPOS is covered by a display string which includes newlines.
2340 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2341 is covered by a display string with embedded newlines.
2343 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2345 * dbusbind.c (Fdbus_register_signal): Add match rule to
2346 Vdbus_registered_objects_table. (Bug#9581)
2347 (Fdbus_register_method, Vdbus_registered_objects_table):
2350 2011-09-24 Jim Meyering <meyering@redhat.com>
2352 do not ignore write error for any output size
2353 The previous change was incomplete.
2354 While it makes emacs --batch detect the vast majority of stdout
2355 write failures, errors were still ignored whenever the output size is
2356 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2357 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2358 && echo FAIL: ignored write error
2359 FAIL: ignored write error
2360 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2361 && echo FAIL: ignored write error
2362 FAIL: ignored write error
2363 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2365 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2367 * emacs.c (Fkill_emacs): In noninteractive mode exit
2368 non-successfully if a write error occurred on stdout. (Bug#9574)
2370 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2372 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2375 * dispextern.h (struct it): Update the comment documenting what
2378 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2380 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2381 a display string, extend search for cursor position to end of row.
2382 (find_row_edges): If the row ends in a newline from a display
2383 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2384 Handle the case of a display string with multiple newlines.
2385 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2386 non-empty line. Fixes confusing cursor motion with arrow keys at
2387 the beginning of a line that starts with whitespace.
2389 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2391 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2394 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2396 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2399 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2401 * xdisp.c (display_line): Record maximum and minimum buffer
2402 positions even if no glyphs were produced (e.g., by a zero-width
2403 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2404 buffer positions that will be removed from the glyph row because
2406 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2407 column is beyond frame width: don't subtract 1 "pixel" when
2408 computing width of the stretch.
2409 (reseat_at_next_visible_line_start): Undo the change made on
2410 2011-09-17 that saved paragraph information and restored it after
2411 the call to `reseat'. (Bug#9545)
2413 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2415 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2416 and turn window cursor on if cleared (Bug#9415).
2418 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2420 * search.c (boyer_moore): Take unibyte characters from pattern
2421 literally. (Bug#9458)
2423 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2425 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2427 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2429 Fix minor problem found by static checking.
2430 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2431 initialized, to pacify gcc -Wuninitialized.
2433 * fileio.c: Report proper errno when syscall falls.
2434 (Finsert_file_contents): Save and restore errno,
2435 so that report_file_error outputs the correct diagnostic.
2436 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2438 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2440 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2442 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2444 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2445 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2447 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2449 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2450 about the current paragraph and restore it after the call to reseat.
2452 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2453 (bidi_find_paragraph_start): Search back for paragraph beginning
2454 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2455 (bidi_move_to_visually_next): Only trigger paragraph-related
2456 computations when the last character is a newline or at EOB, not
2457 just any NEUTRAL_B. (Bug#9470)
2459 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2460 truncated lines if point is covered by a display string. (Bug#9524)
2462 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2464 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2465 (cons_to_x_long): New function.
2466 (lisp_data_to_selection_data): Use it. Correct the test for
2467 short-versus-long data; it was negated. Break out of vector
2468 loop, for efficiency, when a long datum is discovered.
2470 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2472 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2474 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2476 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2477 GCC PR/17406) by declaring this function with external scope.
2479 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2481 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2482 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2484 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2486 * editfns.c (Fformat): Correctly handle text properties on "%%".
2488 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2490 * xterm.c (x_draw_composite_glyph_string_foreground):
2491 * w32term.c (x_draw_composite_glyph_string_foreground):
2492 * term.c (encode_terminal_code):
2493 * composite.c (composition_update_it, get_composition_id):
2494 * xdisp.c (get_next_display_element)
2495 (fill_composite_glyph_string): Add comments about special meaning
2496 of TAB characters in a composition.
2498 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2500 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2501 This occurs when processing a multibyte format.
2502 Problem reported by Wolfgang Jenker.
2504 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2506 * xdisp.c (try_cursor_movement): Only check for exact match if
2507 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2509 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2511 Remove unused external symbols.
2512 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2513 * xdisp.c (calc_pixel_width_or_height): Now static.
2514 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2515 * indent.c (check_display_width):
2516 * w32term.c: Fix comment to match code.
2517 * xterm.c, xterm.h (x_catching_errors): Remove.
2519 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2521 * xselect.c: Use signed conversions more consistently (Bug#9498).
2522 (selection_data_to_lisp_data): Assume incoming selection data are
2523 signed integers, not unsigned. This is to be consistent with
2524 outgoing selection data, which was modified to use signed integers
2525 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2526 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2527 expects long, not unsigned long.
2529 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2531 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2532 computation of loop end. Reported by Johan Bockgård
2535 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2537 * frame.c (Fother_visible_frames_p): Function deleted.
2539 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2541 * indent.c (compute_motion): Process display vector front to back
2542 rather than the other way around. (Bug#2496)
2544 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2546 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2548 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2550 * minibuf.c (Fread_from_minibuffer): Doc fix.
2552 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2554 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2555 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2557 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2559 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2560 value for non-existent files.
2562 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2564 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2565 set its "size" to -1. This will set the modtime_size field of
2566 the corresponding buffer to -1, which is what
2567 verify-visited-file-modtime expects for files that do not exist.
2570 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2572 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2574 * lisp.h: ... from here. push_key_description is no longer
2575 defined in keyboard.c, so its declaration should not be in
2576 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2577 logically belongs with push_key_description.
2579 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2581 * buffer.h: Include <sys/types.h> instead of <time.h>.
2582 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2583 Problem reported by Herbert J. Skuhra.
2585 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2587 * xml.c (parse_region): Make the parsing work for
2588 non-comment-starting XML files again (bug#9144).
2590 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2592 * image.c (gif_load): Fix calculation of bottom and right corner.
2595 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2597 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2598 redisplay in small windows.
2600 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2602 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2604 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2606 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2607 Operate on live windows only.
2609 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2611 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2613 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2615 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2616 only under bidi iteration.
2618 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2620 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2622 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2624 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2625 Without this fix, the command to link temacs failed due to an
2626 undefined symbol __builtin_isnan. This is because
2627 /usr/include/iso/math_c99.h #defines isnan(x) to
2628 __builtin_isnan(x), but the bundled gcc, which identifies itself
2629 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2631 * floatfns.c (isnan): #undef, and then #define to a clone of
2633 (Fisnan): Always define, since it's always available now.
2634 (syms_of_floatfns): Always define isnan at the Lisp level.
2636 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2638 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2640 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2642 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2643 The previous code assumed that file offsets (off_t values) fit in
2644 EMACS_INT variables, which is not true on typical 32-bit hosts.
2645 The code messed up by falsely reporting buffer overflow in cases
2646 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2647 when "big" contains more than 2**29 bytes, even though this
2648 inserts just one byte and does not overflow the buffer.
2649 (Finsert_file_contents): Store file offsets as off_t
2650 values, not as EMACS_INT values. Check for overflow when
2651 converting between EMACS_INT and off_t. When checking for
2652 buffer overflow or for overlap, take the offsets into account.
2653 Don't use EMACS_INT for small values where int suffices.
2654 When checking for overlap, fix a typo: ZV was used where
2655 ZV_BYTE was intended.
2656 (Fwrite_region): Don't assume off_t fits into 'long'.
2657 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2659 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2661 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2663 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2665 sprintf-related integer and memory overflow issues (Bug#9412).
2667 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2668 (esprintf, exprintf, evxprintf): New functions.
2669 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2670 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2671 (modify_event_symbol): Do not assume that the length of
2672 name_alist_or_stem is safe to alloca and fits in int.
2673 (Fexecute_extended_command): Likewise for function name and binding.
2674 (Frecursion_depth): Wrap around reliably on integer overflow.
2675 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2676 since some callers pass EMACS_INT values.
2677 (Fsingle_key_description): Don't crash if symbol name contains more
2678 than MAX_ALLOCA bytes.
2679 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2680 (get_minibuffer): Arg is now EMACS_INT, not int.
2681 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2682 (esprintf, exprintf, evxprintf): New decls.
2683 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2685 * dbusbind.c (signature_cat): New function.
2686 (xd_signature, Fdbus_register_signal):
2687 Do not overrun buffer; instead, report string overflow.
2689 * dispnew.c (add_window_display_history): Don't overrun buffer.
2690 Truncate instead; this is OK since it's just a log.
2692 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2693 even if the time zone offset is outlandishly large.
2694 Don't mishandle offset == INT_MIN.
2696 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2697 when creating daemon; the previous buffer-overflow check was incorrect.
2699 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2700 which has the guts of the old verror function.
2702 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2703 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2705 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2706 (font_unparse_xlfd): Don't blindly alloca long strings.
2707 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2708 fits in int, when using sprintf. Use single snprintf to count
2709 length of string rather than counting it via multiple sprintfs;
2710 that's simpler and more reliable.
2711 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2712 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2713 sprintf, in case result does not fit in int.
2715 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2716 (fontset_from_font): Print it.
2718 * frame.c (tty_frame_count): Now printmax_t, not int.
2719 (make_terminal_frame, set_term_frame_name): Print it.
2720 (x_report_frame_params): In X, window IDs are unsigned long,
2721 not signed long, so print them as unsigned.
2722 (validate_x_resource_name): Check for implausibly long names,
2723 and don't assume name length fits in 'int'.
2724 (x_get_resource_string): Don't blindly alloca invocation name;
2725 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2728 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2729 (xg_check_special_colors, xg_set_geometry):
2730 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2732 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2733 Use esprintf, not sprintf, in case result does not fit in int.
2735 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2736 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2737 it as a large positive number.
2738 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2739 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2741 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2742 in case result does not fit in int.
2744 * print.c (float_to_string): Detect width overflow more reliably.
2745 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2746 buffer overrun. Don't assume list length fits in 'int'. Treat
2747 print length of 0 as 0, not as infinity; to be consistent with other
2748 uses of print length in this function. Don't overflow print length
2749 index. Don't assume hash table size fits in 'long', or that
2750 vectorlike size fits in 'unsigned long'.
2752 * process.c (make_process): Use printmax_t, not int, to format
2753 process-name gensyms.
2755 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2757 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2758 to avoid potential buffer overrun.
2760 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2761 if X resource line is longer than 512 bytes.
2763 * xfns.c (x_window): Make sprintf buffer a bit bigger
2764 to avoid potential buffer overrun.
2766 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2768 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2770 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2772 Integer overflow fixes for scrolling, etc.
2773 Without these, Emacs silently mishandles large integers sometimes.
2774 For example, "C-u 4294967297 M-x recenter" was treated as if
2775 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2777 * xdisp.c (try_window_id): Check Emacs fixnum range before
2778 converting to 'int'.
2780 * window.c (window_scroll_line_based, Frecenter):
2781 Check that an Emacs fixnum is in range before assigning it to 'int'.
2782 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2783 values converted from Emacs fixnums.
2784 (Frecenter): Don't wrap around a line count if it is out of 'int'
2785 range; instead, treat it as an extreme value.
2786 (Fset_window_configuration, compare_window_configurations):
2787 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2789 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2790 that can exceed INT_MAX. Check that EMACS_INT value is in range
2791 before assigning it to the (possibly-narrower) index.
2792 (match_limit): Don't assume that a fixnum can fit in 'int'.
2794 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2797 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2798 (Fvertical_motion): Don't wrap around LINES values that don't fit
2799 in 'int'. Instead, treat them as extreme values. This is good
2800 enough for windows, which can't have more than INT_MAX lines anyway.
2802 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2804 * Require libxml/parser.h to avoid compilation warning.
2806 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2808 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2809 since this reportedly can destroy thread storage.
2811 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2813 * syntax.c (find_defun_start): Update all cache variables if
2814 exiting early (Bug#9401).
2816 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2818 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2820 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2821 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2822 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2824 * term.c (tty_append_glyph): New function.
2825 (produce_stretch_glyph): Static function and its prototype deleted.
2827 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2830 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2832 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2833 when checking :margin (Bug#9390).
2834 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2835 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2836 so that the name doesn't mislead. All uses changed.
2838 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2840 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2843 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2845 * xdisp.c (move_it_to): Don't bail out early when reaching
2846 position beyond to_charpos, if we are scanning backwards.
2847 (move_it_vertically_backward): When DY == 0, make sure we get to
2848 the first character in the line after the newline.
2850 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2852 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2853 (ccl_driver): Do not generate an out-of-range pointer.
2854 (Fccl_execute_on_string): Remove unnecessary check for
2855 integer overflow, noted by Stefan Monnier in
2856 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2857 Remove a FIXME that didn't need fixing.
2858 Simplify the newly-introduced buffer reallocation code.
2860 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2862 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2864 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2866 Integer and memory overflow issues (Bug#9196).
2868 * doc.c (get_doc_string): Rework so that
2869 get_doc_string_buffer_size is the actual buffer size, rather than
2870 being 1 less than the actual buffer size; this makes xpalloc more
2873 * image.c (x_allocate_bitmap_record, cache_image):
2874 * xselect.c (Fx_register_dnd_atom):
2875 Simplify previous changes by using xpalloc.
2877 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2878 since either will do and ptrdiff_t is convenient with xpalloc.
2880 * charset.c (charset_table_size)
2881 (struct charset_sort_data.priority): Now ptrdiff_t.
2882 (charset_compare): Don't overflow if priorities differ greatly.
2883 (Fsort_charsets): Don't assume list length fits in int.
2884 Check for size-calculation overflow when allocating sort data.
2885 (syms_of_charset): Allocate an initial charset table that is
2886 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2888 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2890 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2891 The actual value is always <= INT_MAX, and leaving it unsigned made
2892 overflow checking harder.
2894 * dispextern.h (struct glyph_matrix.rows_allocated)
2895 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2896 with xpalloc. The values are still always <= INT_MAX.
2898 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2900 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2901 (SAFE_NALLOCA): New macro.
2903 * region-cache.c (struct boundary.pos, find_cache_boundary)
2904 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2905 (set_cache_region, invalidate_region_cache)
2906 (revalidate_region_cache, know_region_cache, region_cache_forward)
2907 (region_cache_backward, pp_cache):
2908 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2909 so that ptrdiff_t * can be passed to xpalloc.
2910 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2911 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2912 (pp_cache): Don't assume cache_len fits in int.
2913 * region-cache.h: Adjust extern decls to match.
2915 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2916 EMACS_INT, since either will do, for xpalloc.
2918 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2919 (xnmalloc, xnrealloc, xpalloc): New functions.
2921 * bidi.c (bidi_shelve_header_size): New constant.
2922 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2923 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2925 * bidi.c (bidi_cache_shrink):
2926 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2928 Don't update size of array until after memory allocation succeeds,
2929 because xmalloc/xrealloc may not return.
2930 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2931 now that we have proper integer overflow checking.
2932 (record_overlay_string, overlay_strings): Catch overflows when
2933 calculating size of overlay_str_buf.
2935 * callproc.c (Fcall_process): Check for size overflow when
2936 calculating size of args2.
2937 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2938 Normally we prefer signed values, but sticking with ptrdiff_t would
2939 require adding more-complicated checks.
2941 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2942 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2943 Redo buffer-overflow calculations to avoid integer overflow.
2944 Add a FIXME comment where memory seems to be over-allocated.
2946 * character.c (Fstring): Check for size-calculation overflow.
2948 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2949 unnecessary integer overflow. Check for size overflow.
2950 (encode_coding_object): Don't update size until xmalloc succeeds.
2952 * composite.c (get_composition_id): Check for overflow in glyph
2953 length calculations.
2955 Integer and memory overflow fixes for display code.
2956 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2957 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2958 (scrolling_window): Check for overflow in size calculations.
2959 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2960 Don't assume glyph table len fits in int.
2961 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2962 (row_table_size): Now ptrdiff_t, not int.
2963 (scrolling_window): Avoid overflow in size calculations.
2964 Don't update size until allocation succeeds.
2965 * fns.c (concat): Check for overflow in size calculations.
2966 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2967 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2968 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2970 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2971 (get_doc_string): Check for size calculation overflow.
2972 Don't update size until allocation succeeds.
2973 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2974 EMACS_INT, where ptrdiff_t will do.
2975 (Fsubstitute_command_keys): Check for string overflow.
2977 * editfns.c (set_time_zone_rule): Don't assume environment length
2979 (message_length): Now ptrdiff_t, not int.
2980 (Fmessage_box): Don't update size until allocation succeeds.
2981 Don't assume message length fits in int.
2982 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2984 * emacs.c (main): Do not reallocate argv, since there is a null at
2985 the end that can be overwritten, and this way there's no need to
2986 worry about size-calculation overflow.
2987 (sort_args): Check for size-calculation overflow.
2989 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2991 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2993 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2994 (x_set_scroll_bar_width, x_figure_window_size):
2995 Check for integer overflow.
2996 (x_set_alpha): Do not assume XINT fits in int.
2998 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2999 This is for the members text_lines, text_cols, total_lines, total_cols,
3000 where the system imposes an 'int' limit.
3002 * fringe.c (Fdefine_fringe_bitmap):
3003 Don't update size until alloc works.
3005 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3006 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3008 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3009 Check for size-calculation overflow.
3010 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3011 do, as we prefer signed integers.
3012 (id_to_widget.max_size, id_to_widget.used)
3013 (xg_store_widget_in_map, xg_remove_widget_from_map)
3014 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3015 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3016 Use and return ptrdiff_t, not int.
3017 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3018 * gtkutil.h: Change prototypes to match the above.
3020 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3021 are duplicate now that they've been promoted to lisp.h.
3022 (x_allocate_bitmap_record, x_alloc_image_color)
3023 (make_image_cache, cache_image, xpm_load):
3024 Don't update size until alloc is done.
3025 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3027 Check for size calculation overflow.
3028 (ct_colors_allocated_max): New constant.
3029 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3032 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3033 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3034 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3035 Use ptrdiff_t, not int, to count maps.
3036 (read_char_minibuf_menu_prompt): Check for overflow in size
3037 calculations. Don't update size until allocation succeeds.
3038 Redo calculations to avoid overflow.
3039 * keyboard.h: Change prototypes to match the above.
3041 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3043 (current_minor_maps): Check for size calculation overflow.
3044 * keymap.h: Change prototypes to match the above.
3046 * lread.c (read1, init_obarray): Don't update size until alloc done.
3048 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3049 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3051 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3052 Now ptrdiff_t, not int.
3053 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3054 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3056 * process.c (Fnetwork_interface_list): Check for overflow
3057 in size calculation.
3059 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3061 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3062 overflow. Don't bother calling xmalloc when xrealloc will do.
3064 * search.c (Freplace_match): Check for size calculation overflow.
3065 (Fset_match_data): Don't assume list lengths fit in 'int'.
3067 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3068 for command line length. Do not attempt to address one before the
3069 beginning of an array, as that's not portable.
3071 * term.c (max_frame_lines): Remove; unused.
3072 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3074 (encode_terminal_code, calculate_costs): Check for size
3075 calculation overflow.
3076 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3077 table lengths and related sizes. Don't update size until alloc
3078 done. Redo calculations to avoid overflow.
3079 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3081 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3082 subtracting pointers.
3083 (gobble_line): Check for overflow more carefully. Don't update size
3086 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3087 Don't update size until alloc done.
3088 Redo size calculations to avoid overflow.
3089 Check for size calculation overflow.
3090 (main) [DEBUG]: Fix typo in invoking tparam1.
3092 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3093 Use ptrdiff_t, not int, for sizes.
3094 (store_mode_line_noprop_char): Don't update size until alloc done.
3096 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3097 Use ptrdiff_t, not int, for sizes.
3098 (Finternal_make_lisp_face, cache_face):
3099 Check for size calculation overflow.
3100 (cache_face): Treat size calculation overflows as if they were
3101 memory exhaustion (the usual treatment), rather than aborting.
3103 * xfns.c (x_encode_text, x_set_name_internal)
3104 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3105 sizes, since they can exceed INT_MAX in size. Check for size
3106 calculation overflow.
3108 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3109 (xg_select): Check for size calculation overflow.
3110 Don't update size until alloc done.
3112 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3113 as sprintf is limited to int lengths.
3115 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3116 (X_LONG_MIN): New macros.
3117 Use them to make the following changes clearer.
3118 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3119 This change doesn't affect the value now, but it may help remind
3120 future maintainers not to raise the value too much later.
3121 (SELECTION_QUANTUM): Remove, replacing with ...
3122 (selection_quantum): ... new function, which avoids overflow.
3124 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3125 assumption that selection length fits in 'int'.
3126 (x_reply_selection_request, x_handle_selection_request)
3127 (x_get_window_property, receive_incremental_selection)
3128 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3129 (lisp_data_to_selection_data, clean_local_selection_data):
3130 Use ptrdiff_t, not int, to record length of selection.
3131 (x_reply_selection_request, x_get_window_property)
3132 (receive_incremental_selection, x_property_data_to_lisp):
3133 Redo calculations to avoid overflow.
3134 (x_reply_selection_request): When sending hint, ceiling it at
3135 X_LONG_MAX rather than relying on wraparound overflow to send
3137 (x_get_window_property, receive_incremental_selection)
3138 (lisp_data_to_selection_data, x_property_data_to_lisp):
3139 Check for size-calculation overflow.
3140 (x_get_window_property, receive_incremental_selection)
3141 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3142 Don't store size until memory allocation succeeds.
3143 (x_get_window_property): Plug memory leak on memory exhaustion.
3144 Don't double-block input; malloc is safe here. Don't assume 2**34
3145 - 4 fits in unsigned long. Add an xassert to check
3146 XGetWindowProperty overflow. Be more careful about overflow
3147 calculations, and distinguish size from memory overflow better.
3148 (receive_incremental_selection): When tracing, don't assume
3149 unsigned int is less than INT_MAX.
3150 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3151 harmful) conversions of unsigned short to int.
3152 (lisp_data_to_selection_data): Don't assume that integers
3153 in the range -65535 through -1 fit in an X unsigned short.
3154 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3155 result parameters unless successful. Rely on cons_to_unsigned
3156 to report problems with elements; the old code wasn't right anyway.
3157 (x_check_property_data): Check for int overflow; we cannot use
3158 a wider type due to X limits.
3159 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3161 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3163 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3164 (x_term_init): Check for size calculation overflow.
3165 (x_color_cells): Don't store size until memory allocation succeeds.
3166 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3167 Don't assume alloca size is less than MAX_ALLOCA.
3168 (x_term_init): Don't assume length fits in int (sprintf is limited
3171 Use ptrdiff_t for composition IDs.
3172 * character.c (lisp_string_width):
3173 * composite.c (composition_table_size, n_compositions)
3174 (get_composition_id, composition_gstring_from_id):
3175 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3176 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3177 * window.c (Frecenter):
3178 Use ptrdiff_t, not int, for composition IDs.
3179 * composite.c (get_composition_id): Check for integer overflow.
3180 * composite.h: Adjust prototypes to match the above changes.
3182 Use ptrdiff_t for hash table indexes.
3183 * category.c (hash_get_category_set):
3184 * ccl.c (ccl_driver):
3185 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3186 * coding.c (coding_system_charset_list, detect_coding_system):
3187 * coding.h (struct coding_system.id):
3188 * composite.c (get_composition_id, gstring_lookup_cache):
3189 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3190 * image.c (xpm_get_color_table_h):
3191 * lisp.h (hash_lookup, hash_put):
3192 * minibuf.c (Ftest_completion):
3193 Use ptrdiff_t for hash table indexes, not int (which is too
3194 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3195 32-bit --with-wide-int hosts).
3197 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3198 Add a FIXME comment about memory leaks.
3199 (syms_of_charset): Don't assume xmalloc returns.
3201 Don't assume that stated character widths fit in int.
3202 * character.c (Fchar_width, c_string_width, lisp_string_width):
3203 * character.h (CHAR_WIDTH):
3204 * indent.c (MULTIBYTE_BYTES_WIDTH):
3205 Use sanitize_char_width to avoid undefined and/or bad behavior
3206 with outlandish widths.
3207 * character.h (sanitize_tab_width): Rename from sanitize_width,
3208 now that we have two such functions. All uses changed.
3209 (sanitize_char_width): New inline function.
3211 Don't assume that tab-width fits in int.
3212 * character.h (sanitize_width): New inline function.
3213 (SANE_TAB_WIDTH): New macro.
3214 (ASCII_CHAR_WIDTH): Use it.
3215 * indent.c (sane_tab_width): Remove. All uses replaced by
3216 SANE_TAB_WIDTH (current_buffer).
3217 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3219 * fileio.c: Integer overflow issues with file modes.
3220 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3222 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3223 Remove unreachable code.
3224 (read_hex, load_charset_map_from_file): Check for integer overflow.
3226 * xterm.c: Don't go over XClientMessageEvent limit.
3227 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3228 (x_send_scroll_bar_event): Likewise. Check that the size does not
3229 exceed limits imposed by XClientMessageEvent, as well as the usual
3230 ptrdiff_t and size_t limits.
3232 * keyboard.c: Overflow, signedness and related fixes.
3233 (make_lispy_movement): Use same integer type in forward decl
3234 that is used in the definition.
3235 (read_key_sequence, keyremap_step):
3236 Change bufsize argument back to int, undoing my 2011-03-30 change.
3237 We prefer signed types, and int is wide enough here.
3238 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3239 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3240 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3241 length, not size_t. Use ptrdiff_t for index, not int.
3242 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3243 possibility of integer overflow.
3245 Overflow, signedness and related fixes for images.
3247 * dispextern.h (struct it.stack[0].u.image.image_id)
3248 (struct_it.image_id, struct image.id, struct image_cache.size)
3249 (struct image_cache.used, struct image_cache.ref_count):
3250 * gtkutil.c (update_frame_tool_bar):
3251 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3252 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3253 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3254 * nsmenu.m (update_frame_tool_bar):
3255 * xdisp.c (calc_pixel_width_or_height):
3256 * xfns.c (image_cache_refcount):
3257 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3258 on typical 64-bit hosts.
3260 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3261 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3262 Omit unnecessary casts to int.
3263 (parse_image_spec): Check that integers fall into 'int' range
3264 when the callers expect that.
3265 (image_ascent): Redo ascent calculation to avoid int overflow.
3266 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3267 (lookup_image): Remove unnecessary tests.
3268 (xbm_image_p): Locals are now of int, not EMACS_INT,
3269 since parse_image_check makes sure they fit into int.
3270 (png_load, gif_load, svg_load_image):
3271 Prefer int to unsigned where either will do.
3272 (tiff_handler): New function, combining the cores of the
3273 old tiff_error_handler and tiff_warning_handler.
3274 This function is rewritten to use vsnprintf and thereby avoid
3275 stack buffer overflows. It uses only the features of vsnprintf
3276 that are common to both POSIX and native Microsoft.
3277 (tiff_error_handler, tiff_warning_handler): Use it.
3278 (tiff_load, gif_load, imagemagick_load_image):
3279 Don't assume :index value fits in 'int'.
3280 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3281 (imagemagick_load_image): Check that crop parameters fit into
3282 the integer types that MagickCropImage accepts. Don't assume
3283 Vimagemagick_render_type has a nonnegative value. Don't assume
3284 size_t fits in 'long'.
3285 (gs_load): Use printmax_t to print the widest integers possible.
3286 Check for integer overflow when computing image height and width.
3288 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3290 * xdisp.c (redisplay_window): Don't force window start if point
3291 will be invisible in the resulting window. (Bug#9324)
3293 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3295 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3296 the display spec is of the form `(space ...)'.
3297 (handle_display_spec): Return the value returned by
3298 handle_single_display_spec, not just 1 or zero.
3299 (handle_single_display_spec): If the display spec is of the form
3300 `(space ...)', and specifies display in the text area, return 2
3302 (try_cursor_movement): Check for the need to scroll more
3303 accurately, and prefer exact match for point under bidi.
3304 Don't advance `row' beyond the last row of the window.
3306 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3307 into disp_prop; all users changed.
3309 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3310 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3311 for the text covered by the display property.
3313 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3315 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3316 Change return value to nil.
3317 (Frecord_buffer): Delete unused function.
3319 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3321 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3322 buffers, return left-to-right.
3323 (set_cursor_from_row): Consider candidate row a win if its glyph
3324 represents a newline and point is on that newline. Fixes cursor
3325 positioning on the newline at EOL of R2L text within L2R
3326 paragraph, and vice versa.
3327 (try_cursor_movement): Check continued rows, in addition to
3328 continuation rows. Fixes unwarranted scroll when point enters a
3329 continued line of R2L text within an L2R paragraph, or vice versa.
3330 (cursor_row_p): Consider the case of point being equal to
3331 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3332 from the end of a short line to the beginning of a continued line
3333 of R2L text within L2R paragraph.
3334 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3335 composed characters.
3337 * bidi.c (bidi_check_type): Use xassert.
3338 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3341 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3343 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3346 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3348 * nsfont.m (ns_otf_to_script): Fix typo.
3350 2011-08-22 Kenichi Handa <handa@m17n.org>
3352 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3353 extra slot even if the purpose is char-code-property-table.
3355 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3357 * xdisp.c (redisplay_window): When computing centering_position,
3358 account for the height of the header line. (Bug#8874)
3360 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3361 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3362 candidate is selected by the mouse, and that candidate has a
3363 composed character under the mouse.
3365 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3366 coordinates reported by pos-visible-in-window-p for a composed
3367 character in column zero.
3369 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3371 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3373 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3375 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3376 consider it a hit if to_charpos is anywhere in the range of the
3377 composed buffer positions.
3379 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3381 * image.c (gif_load): Don't assume that each subimage has the same
3382 dimensions as the base image. Handle disposal method that is
3383 "undefined" by the gif spec (Bug#9335).
3385 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3387 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3388 (Fcondition_case): Document `debug' symbol in error handler.
3390 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3392 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3393 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3394 from an Org mode buffer to a Speedbar frame.
3396 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3397 a composition, take its buffer position from IT->cmp_it.charpos.
3398 Fixes cursor positioning at the beginning of a line that begins
3399 with a composed character.
3401 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3403 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3404 character bidirectional type, use STRONG_L instead. Fixes crashes
3405 in a buffer produced by `describe-categories'.
3407 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3408 members before the level stack, so they would be saved and
3409 restored when copying iterator state. Fixes incorrect reordering
3410 around TABs covered by display properties.
3412 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3414 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3416 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3418 * eval.c (internal_condition_case, internal_condition_case_1)
3419 (internal_condition_case_2, internal_condition_case_n):
3420 Remove unnecessary aborts (Bug#9081).
3422 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3424 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3425 has no `load' handler, try opening the file locally. (Bug#9311)
3427 2011-08-16 Ken Brown <kbrown@cornell.edu>
3429 * gmalloc.c: Expand comment.
3431 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3433 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3434 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3436 2011-08-16 Ken Brown <kbrown@cornell.edu>
3438 Fix memory allocation problems in Cygwin build (Bug#9273).
3440 * unexcw.c ( __malloc_initialized): Declare external variable.
3441 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3443 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3445 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3447 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3449 [CYGWIN] (special_realloc): New function.
3450 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3451 requests to realloc storage in the static heap.
3453 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3455 * bidi.c (bidi_initialize): Remove unused local.
3457 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3460 * biditype.h: Remove file.
3461 * makefile.w32-in ($(BLD)/bidi.$(O)):
3462 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3464 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3466 * chartab.c: Improve commentary for the uniprop_table API.
3468 * bidi.c (bidi_paragraph_init): Support zero value of
3469 bidi_ignore_explicit_marks_for_paragraph_level.
3470 (bidi_initialize): Use uniprop_table instead of including
3471 biditype.h and bidimirror.h.
3473 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3474 coordinates of the iterator when restoring from ppos_it.
3477 2011-08-14 Kenichi Handa <handa@m17n.org>
3479 * process.c (create_process): Call setup_process_coding_systems
3480 after the pid of the process is set to -1 (Bug#8162).
3482 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3484 * xdisp.c (move_it_in_display_line_to): Don't invoke
3485 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3486 ppos_it. Fixes vertical cursor motion when line beginning is
3487 covered by an image. (Bug#9296)
3489 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3491 * nsterm.h (ns_run_ascript): Declare.
3492 (NSAPP_DATA2_RUNASSCRIPT): Define.
3494 * nsfns.m (as_script, as_result, as_status): New static variables.
3495 (ns_run_ascript): New function.
3496 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3497 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3498 the event loop. Get status from as_status (Bug#7276).
3500 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3501 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3502 the event loop (Bug#7276).
3504 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3506 * gnutls.c (QCgnutls_bootprop_priority)
3507 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3508 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3509 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3510 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3511 (QCgnutls_bootprop_verify_hostname_error)
3512 (QCgnutls_bootprop_callbacks_verify): Rename from
3513 Qgnutls_bootprop_..., all uses changed.
3515 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3518 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3520 * xfaces.c (Qframe_set_background_mode): Now static.
3521 * dispextern.h (Qframe_set_background_mode): Remove decl.
3523 * process.c (Fnetwork_interface_info): Declare local only if needed.
3525 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3527 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3528 (Fnetwork_interface_list): Allocate in increments of bytes instead
3529 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3530 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3532 (struct ifflag_def): notrailers is smart on OSX.
3533 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3534 Get hardware address with getifaddrs if available.
3536 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3538 * xdisp.c (iterate_out_of_display_property): xassert that
3539 IT->position is set to within IT->object's boundaries. Break from
3540 the loop as soon as EOB is reached; avoids infloops in redisplay
3541 when IT->position is set up wrongly due to some bug.
3542 Set IT->current to match the bidi iterator unconditionally.
3543 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3544 entry. Force push_it to save on the stack the current
3545 buffer/string position, to be restored by pop_it. Fix flags in
3546 the iterator structure wrt the object coming from a display
3547 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3548 properties. (Bug#9284)
3550 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3552 * fontset.c (fontset_get_font_group): Add proper type checks.
3555 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3557 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3558 and LC_VERSION_MIN_MACOSX.
3559 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3560 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3562 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3564 * xdisp.c (forward_to_next_line_start): Allow to use the
3565 no-display-properties-and-no-overlays under bidi display.
3566 Set disp_pos in the bidi iterator to avoid searches for display
3567 properties and overlays.
3569 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3571 * editfns.c (Fset_time_zone_rule): Document relationship with the
3574 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3575 the font entity extracted from the cache (Bug#8109).
3577 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3579 * composite.c (autocmp_chars): Don't reset point. That is done by
3580 restore_point_unwind (Bug#5984).
3582 2011-08-07 Juri Linkov <juri@jurta.org>
3584 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3585 to show the arg `TIME' instead of `TIMEVAL'.
3587 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3589 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3590 display property strides EOL and includes a newline, as in
3591 longlines-mode. (Bug#9254)
3592 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3593 word-wrap under bidirectional display. (Bug#9224)
3595 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3596 is non-zero, even if the data buffer is NULL. Fixes a crash in
3597 vertical-motion with longlines-mode. (Bug#9254)
3599 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3601 * bidi.c <bidi_cache_total_alloc>: Now static.
3602 (bidi_initialize): Initialize bidi_cache_total_alloc.
3604 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3607 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3608 amount allocated this far in `bidi_cache_total_alloc'.
3609 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3610 non-zero, only free the data buffer without restoring the cache
3611 contents. All callers changed.
3613 * dispextern.h (bidi_unshelve_cache): Update prototype.
3615 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3616 (move_it_in_display_line, move_it_to)
3617 (move_it_vertically_backward, move_it_by_lines): Replace the call
3618 to xfree to an equivalent call to bidi_unshelve_cache.
3619 (move_it_in_display_line_to): Fix logic of returning
3620 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3622 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3624 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3625 came from a string character with a `cursor' property. (Bug#9229)
3627 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3629 * Makefile.in (LIB_PTHREAD): New variable.
3630 (LIBES): Add LIB_PTHREAD (Bug#9216).
3632 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3633 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3635 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3637 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3639 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3641 * xterm.c (x_find_topmost_parent): New function.
3642 (x_set_frame_alpha): Find topmost parent window with
3643 x_find_topmost_parent and set the property there also (bug#9181).
3644 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3646 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3648 * callproc.c (Fcall_process): Avoid vfork clobbering
3649 the local vars buffer, coding_systems, current_dir.
3651 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3653 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3655 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3657 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3658 so that it is not optimized away.
3660 * xdisp.c (compute_display_string_pos): Remove unused local.
3662 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3664 Fix slow cursor motion and scrolling in large buffers with
3665 selective display, like Org Mode buffers. (Bug#9218)
3667 * dispextern.h (struct bidi_it): New member disp_prop_p.
3669 * xdisp.c: Remove one-slot cache of display string positions.
3670 (compute_display_string_pos): Accept an additional argument
3671 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3672 for a display string or property. If found, set DISP_PROP_P
3675 * bidi.c (bidi_fetch_char): Accept an additional argument
3676 DISP_PROP_P, and pass it to compute_display_string_pos.
3677 Only handle text covered by a display string if DISP_PROP_P is returned
3678 non-zero. All callers of bidi_fetch_char changed.
3680 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3682 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3684 2010-12-03 Don March <don@ohspite.net>
3686 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3687 last character M-[char] is translated to ESC [char] (bug#7541).
3689 2011-08-02 Kenichi Handa <handa@m17n.org>
3691 * lisp.h (uniprop_table): Extern it.
3693 * chartab.c (uniprop_table): Make it non-static.
3695 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3697 * xdisp.c (forward_to_next_line_start): Accept additional argument
3698 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3700 (reseat_at_next_visible_line_start): Use the bidi iterator state
3701 returned by forward_to_next_line_start to restore the state of
3702 it->bidi_it after backing up to previous newline. (Bug#9212)
3704 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3706 * regex.c (re_comp): Protoize.
3707 (re_exec): Fix return type.
3708 (regexec): Fix type of `ret'. (Bug#9203)
3710 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3712 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3713 This is needed if max-image-size is a floating-point number.
3715 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3717 * print.c (print_object): Print empty symbol as ##.
3719 * lread.c (read1): Read ## as empty symbol.
3721 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3723 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3724 setting frame foreground color (Bug#9175).
3725 (x_set_background_color): Likewise.
3727 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3728 contents (Bug#9176).
3729 (EmacsTooltip -init): Remove bezels and add shadows to
3732 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3733 or scroll bar (Bug#8470).
3735 * nsfont.m (nsfont_open): Remove assignment to voffset and
3736 unnecessary vars hshink, expand, hd, full_height, min_height.
3737 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3739 * nsterm.h (nsfont_info): Remove voffset field.
3741 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3743 Implement strike-through and overline on NextStep (Bug#8863).
3745 * nsfont.m (nsfont_open): Use underline position provided by font,
3746 instead of hard-coded value of 2.
3747 (nsfont_draw): Call ns_draw_text_decoration instead.
3749 * nsterm.h: Add declaration for ns_draw_text_decoration.
3751 * nsterm.m (ns_draw_text_decoration): New function for drawing
3752 underline, overline, and strike-through.
3753 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3754 ns_draw_text_decoration. Change treatment of cursor drawing to
3755 accommodate underlining, etc.
3757 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3759 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3762 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3764 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3765 Without this fix, if a signal arrives just after memory fills up,
3766 'malloc' might be invoked reentrantly.
3768 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3769 In other words, assume that every image size is allowed, on non-X
3770 hosts. This assumption is probably wrong, but it lets Emacs compile.
3772 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3774 * regex.c (re_iswctype): Convert return values to boolean.
3776 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3778 * xdisp.c (compute_display_string_pos): Don't use cached display
3779 string position if the buffer had its restriction changed.
3782 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3784 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3786 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3788 Integer signedness and overflow and related fixes. (Bug#9079)
3790 * bidi.c: Integer size and overflow fixes.
3791 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3792 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3793 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3794 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3795 (bidi_find_other_level_edge):
3796 Use ptrdiff_t instead of EMACS_INT where either will do.
3797 This works better on 32-bit hosts configured --with-wide-int.
3798 (bidi_cache_ensure_space): Check for size-calculation overflow.
3799 Use % rather than repeated addition, for better worst-case speed.
3800 Don't set bidi_cache_size until after xrealloc returns, because it
3802 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3803 (bidi_cache_ensure_space): Also check that the bidi cache size
3804 does not exceed that of the largest Lisp string or buffer. See Eli
3805 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3807 * alloc.c (__malloc_size_t): Remove.
3808 All uses replaced by size_t. See Andreas Schwab's note
3809 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3811 * image.c: Improve checking for integer overflow.
3812 (check_image_size): Assume that f is nonnull, since
3813 it is always nonnull in practice. This is one less thing to
3814 worry about when checking for integer overflow later.
3815 (x_check_image_size): New function, which checks for integer
3816 overflow issues inside X.
3817 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3818 This removes the need for a memory_full check.
3819 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3820 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3821 (xbm_read_bitmap_data): Change locals back to 'int', since
3822 their values must fit in 'int'.
3823 (xpm_load_image, png_load, tiff_load):
3824 Invoke x_create_x_image_and_pixmap earlier,
3825 to avoid much needless work if the image is too large.
3826 (tiff_load): Treat overly large images as if
3827 x_create_x_image_and_pixmap failed, not as malloc failures.
3828 (gs_load): Use x_check_image_size.
3830 * gtkutil.c: Omit integer casts.
3831 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3832 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3834 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3836 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3837 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3838 would wrongly return t on a 64-bit host.
3840 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3841 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3842 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3843 and therefore cause GCC to emit a bogus diagnostic in some cases.
3845 * image.c: Integer signedness and overflow and related fixes.
3846 This is not an exhaustive set of fixes, but it's time to
3847 record what I've got.
3848 (lookup_pixel_color, check_image_size): Remove redundant decls.
3849 (check_image_size): Don't assume that arbitrary EMACS_INT values
3850 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3851 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3852 (tiff_load, imagemagick_load_image):
3853 Check for overflow in size calculations.
3854 (x_create_x_image_and_pixmap): Remove unnecessary test for
3855 xmalloc returning NULL; that can't happen.
3856 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3857 (xpm_color_bucket): Use better integer hashing function.
3858 (xpm_cache_color): Don't possibly over-allocate memory.
3859 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3860 (gif_memory_source):
3861 Use ptrdiff_t, not int or size_t, to record sizes.
3862 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3863 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3864 either works, as we prefer signed integers.
3865 (tiff_read_from_memory, tiff_write_from_memory):
3866 Return tsize_t, not size_t, since that's what the TIFF API wants.
3867 (tiff_read_from_memory): Don't fail simply because the read would
3868 go past EOF; instead, return a short read.
3869 (tiff_load): Omit no-longer-needed casts.
3870 (Fimagemagick_types): Don't assume size fits into 'int'.
3872 Improve hashing quality when configured --with-wide-int.
3873 * fns.c (hash_string): New function, taken from sxhash_string.
3874 Do not discard information about ASCII character case; this
3875 discarding is no longer needed.
3876 (sxhash-string): Use it. Change sig to match it. Caller changed.
3877 * lisp.h: Declare it.
3878 * lread.c (hash_string): Remove, since we now use fns.c's version.
3879 The fns.c version returns a wider integer if --with-wide-int is
3880 specified, so this should help the quality of the hashing a bit.
3882 * emacs.c: Integer overflow minor fix.
3883 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3884 Define only if GNU_LINUX.
3885 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3887 * dispnew.c: Integer signedness and overflow fixes.
3888 Remove unnecessary forward decls, that were a maintenance hassle.
3889 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3891 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3892 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3893 (prepare_desired_row, line_draw_cost):
3894 Use int, not unsigned, where either works.
3895 (save_current_matrix, restore_current_matrix):
3896 Use ptrdiff_t, not size_t, where either works.
3897 (init_display): Check for overflow more accurately, and without
3898 relying on undefined behavior.
3900 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3901 Remove, replacing with the new symbols in lisp.h. All uses changed.
3902 * fileio.c (make_temp_name):
3903 * filelock.c (lock_file_1, lock_file):
3904 * xdisp.c (message_dolog):
3905 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3906 Use pMd etc. instead.
3907 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3908 replacing the pWIDE etc. symbols removed from editfns.c.
3910 * keyboard.h (num_input_events): Now uintmax_t.
3911 This is (very slightly) less likely to mess up due to wraparound.
3914 * buffer.c: Integer signedness fixes.
3915 (alloc_buffer_text, enlarge_buffer_text):
3916 Use ptrdiff_t rather than size_t when either will do, as we prefer
3919 * alloc.c: Integer signedness and overflow fixes.
3920 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3921 (__malloc_size_t): Default to size_t, not to int.
3922 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3923 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3924 Prefer ptrdiff_t to size_t when either would do, as we prefer
3926 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3927 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3928 Now const. Initialize with values that are in range even if char
3930 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3931 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3932 These functions do the right thing with sizes > 2**32.
3933 (check_depth): Now ptrdiff_t, not int.
3934 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3935 Adjust to new way of storing sizes. Check for size overflow bugs
3937 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3938 slightly wrong anyway, as it missed one instance of
3939 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3940 (refill_memory_reserve): Omit needless cast to size_t.
3941 (mark_object_loop_halt): Mark as externally visible.
3943 * xselect.c: Integer signedness and overflow fixes.
3944 (Fx_register_dnd_atom, x_handle_dnd_message):
3945 Use ptrdiff_t, not size_t, since we prefer signed.
3946 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3947 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3948 x_dnd_atoms_size and x_dnd_atoms_length.
3950 * doprnt.c: Prefer signed to unsigned when either works.
3952 * doprnt.c (doprnt):
3954 * xdisp.c (vmessage):
3955 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3956 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3957 prefer signed arithmetic to avoid comparison confusion.
3958 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3959 but is a bit tricky.
3961 Assume freestanding C89 headers, string.h, stdlib.h.
3962 * data.c, doprnt.c, floatfns.c, print.c:
3963 Include float.h unconditionally.
3964 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3965 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3966 * regex.c: Likewise for stddef.h, string.h.
3967 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3968 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3969 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3970 (STDC_HEADERS): Remove obsolete defines.
3971 * sysdep.c: Include limits.h unconditionally.
3973 Assume support for memcmp, memcpy, memmove, memset.
3974 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3975 * regex.c (memcmp, memcpy):
3976 Remove; we assume C89 now.
3978 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3979 (__malloc_safe_bcopy): Remove; no longer needed.
3981 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3982 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3983 well either way, and we prefer signed to unsigned.
3985 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3987 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3988 closes the connection while we're reading (bug#9182).
3990 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3992 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3993 are specified (Bug#9168).
3995 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3997 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3998 Found by GCC static checking and --with-wide-int on a 32-bit host.
4000 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4002 * xdisp.c (compute_display_string_pos): Fix logic of caching
4003 previous display string position. Initialize cached_prev_pos to
4004 -1. Fixes slow-down at the beginning of a buffer.
4006 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4008 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4009 for attrs[LFACE_FONTSET_INDEX].
4011 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4013 * xml.c (parse_region): Remove unused local
4014 that was recently introduced.
4016 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4018 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4019 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4021 * xdisp.c (move_it_in_display_line_to): Record the best matching
4022 position for TO_CHARPOS while scanning the line, and restore it on
4023 exit if none of the characters scanned was an exact match.
4024 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4025 when exact match is impossible due to invisible text, and the
4026 lines are truncated.
4028 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4030 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4033 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4035 Fix a significant slow-down of cursor motion with C-n, C-p,
4036 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4037 auto-repeat under bidi redisplay in fontified buffers.
4038 * xdisp.c (compute_stop_pos_backwards): New function.
4039 (next_element_from_buffer): Call compute_stop_pos_backwards to
4040 find a suitable prev_stop when we find ourselves before
4042 (reseat): Don't look for prev_stop, as that could mean a very long
4044 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4045 <cached_disp_overlay_modiff>: Cache for last found display string
4047 (compute_display_string_pos): Return the cached position if asked
4048 about the same buffer in the same area of character positions, and
4049 the buffer wasn't changed since the time the display string
4050 position was cached.
4052 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4054 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4055 is an integer, which is important for empty lines. (Bug#9149)
4057 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4059 * frame.c (Fmodify_frame_parameters): In tty case, update the
4060 default face if necessary (Bug#4238).
4062 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4064 * editfns.c (Fstring_to_char): No need to explain what a character
4065 is in the docstring (Bug#6576).
4067 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4069 * xml.c (parse_region): Make sure we always return a tree.
4071 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4073 * xml.c (parse_region): If a document contains only comments,
4076 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4078 * xml.c (make_dom): Return comments, too.
4080 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4083 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4084 and the surrounding thread.
4085 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4086 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4087 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4089 * s/openbsd.h (BROKEN_SIGIO): Define.
4090 * unexelf.c (unexec) [__OpenBSD__]:
4091 Don't update the .mdebug section of the Alpha COFF symbol table.
4093 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4095 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4098 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4100 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4101 This fixes some race conditions on the permissions of any newly
4104 * alloc.c (valid_pointer_p): Use pipe, not open.
4105 This fixes some permissions issues when debugging.
4107 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4108 If fchown fails to set both uid and gid, try to set just gid,
4109 as that is sometimes allowed. Adjust the file's mode to eliminate
4110 setuid or setgid bits that are inappropriate if fchown fails.
4112 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4114 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4115 to compare Lisp_Objects.
4116 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4117 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4118 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4120 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4122 * lread.c (read_integer): Unread even EOF character.
4123 (read1): Likewise. Properly record start position of symbol.
4125 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4126 symbol character follows.
4128 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4130 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4131 This works around a problem with the previous change to Fcopy_file.
4132 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4133 and without this change, GCC might complain about discarding
4134 fchown's return value.
4136 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4138 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4140 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4142 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4144 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4146 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4147 it's used from the C level.
4149 * process.c: Use the same condition for POLL_FOR_INPUT in both
4150 keyboard.c and process.c (bug#1858).
4152 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4154 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4155 (Fgnutls_boot): Use it.
4157 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4159 * doc.c (Fsubstitute_command_keys): Revert last change.
4161 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4163 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4164 quotes the next character, and doesn't affect other longer
4165 sequences (bug#8935).
4167 * lread.c (syms_of_lread): Clarify that is isn't only
4168 `eval-buffer' and `eval-defun' that's affected by
4169 `lexical-binding' (bug#8460).
4171 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4173 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4174 bidi redisplay when a line includes both an image and is truncated.
4176 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4178 Fix minor problems found by static checking.
4179 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4180 (elsz): Now a signed constant, not a size_t var. We prefer signed
4181 types to unsigned, to avoid integer comparison confusion. Without
4182 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4183 "cannot optimize loop, the loop counter may overflow", a symptom
4185 * indent.c (Fvertical_motion): Mark locals as initialized.
4186 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4188 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4190 * search.c (Fre_search_backward): Mention `case-fold-search' in
4191 all the re_search_* functions (bug#8138).
4193 * keyboard.c (Fopen_dribble_file): Document when the file is
4196 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4198 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4201 Support bidi reordering of display and overlay strings.
4202 * xdisp.c (compute_display_string_pos)
4203 (compute_display_string_end): Accept additional argument STRING.
4204 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4205 (reseat_to_string): Initialize bidi_it->string.s and
4206 bidi_it->string.schars.
4207 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4208 NULL (avoids a crash in bidi_paragraph_init).
4209 Initialize itb.string.lstring.
4210 (init_iterator): Call bidi_init_it only of a valid
4211 buffer position was specified. Initialize paragraph_embedding to
4213 (reseat_to_string): Initialize the bidi iterator.
4214 (display_string): If we need to ignore text properties of
4215 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4216 original value of -1 will not work with bidi.)
4217 (compute_display_string_pos): First arg is now struct
4218 `text_pos *'; all callers changed. Support display properties on
4220 (compute_display_string_end): Support display properties on Lisp
4222 (init_iterator, reseat_1, reseat_to_string): Initialize the
4223 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4224 when iterating on a string not from display properties).
4225 (compute_display_string_pos, compute_display_string_end):
4226 Fix calculation of the object to scan. Fixes an error when using
4228 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4229 base_level_stop; instead, set base_level_stop to BEGV.
4230 Fixes crashes in vertical-motion.
4231 (next_element_from_buffer): Improve commentary for when
4232 the iterator is before prev_stop.
4233 (init_iterator): Initialize bidi_p from the default value of
4234 bidi-display-reordering, not from buffer-local value. Use the
4235 buffer-local value only if initializing for buffer iteration.
4236 (handle_invisible_prop): Support invisible properties on strings
4237 that are being bidi-reordered.
4238 (set_iterator_to_next): Support bidi reordering of C strings and
4240 (next_element_from_string): Support bidi reordering of Lisp
4242 (handle_stop_backwards): Support Lisp strings as well.
4243 (display_string): Support display of R2L glyph rows.
4244 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4245 (init_iterator): Don't initialize it->bidi_p for strings
4247 (reseat_to_string): Initialize it->bidi_p for strings here.
4248 (next_element_from_string, next_element_from_c_string)
4249 (next_element_from_buffer): Add xassert's for correspondence
4250 between IT's object being iterated and it->bidi_it.string
4252 (face_before_or_after_it_pos): Support bidi iteration.
4253 (next_element_from_c_string): Handle the case of the first string
4254 character that is not the first one in the visual order.
4255 (get_visually_first_element): New function, refactored from common
4256 parts of next_element_from_buffer, next_element_from_string, and
4257 next_element_from_c_string.
4258 (tool_bar_lines_needed, redisplay_tool_bar)
4259 (display_menu_bar): Force left-to-right direction. Add a FIXME
4260 comment for making that be controlled by a user option.
4261 (push_it, pop_it): Save and restore the state of the
4262 bidi iterator. Save and restore the bidi_p flag.
4263 (pop_it): Iterate out of display property for string iteration as
4265 (iterate_out_of_display_property): Support iteration over strings.
4266 (handle_single_display_spec): Set up it->bidi_it for iteration
4267 over a display string, and call bidi_init_it.
4268 (handle_single_display_spec, next_overlay_string)
4269 (get_overlay_strings_1, push_display_prop): Set up the bidi
4270 iterator for displaying display or overlay strings.
4271 (forward_to_next_line_start): Don't use the shortcut if
4273 (back_to_previous_visible_line_start): If handle_display_prop
4274 pushed the iterator stack, restore the internal state of the bidi
4275 iterator by calling bidi_pop_it same number of times.
4276 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4277 and we are bidi-iterating, don't decrement the iterator position;
4278 instead, set the first_elt flag in the bidi iterator, to produce
4280 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4281 (push_display_prop): xassert that we are iterating a buffer.
4282 (push_it, pop_it): Save and restore paragraph_embedding member.
4283 (handle_single_display_spec, next_overlay_string)
4284 (get_overlay_strings_1, reseat_1, reseat_to_string)
4285 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4286 correctly. Don't assume unibyte strings are not bidi-reordered.
4287 (compute_display_string_pos)
4288 (compute_display_string_end): Fix handling the case of C string.
4289 (push_it, pop_it): Save and restore from_disp_prop_p.
4290 (handle_single_display_spec, push_display_prop): Set the
4291 from_disp_prop_p flag.
4292 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4293 (pop_it): Call iterate_out_of_display_property only if we are
4294 popping after iteration over a string that came from a display
4295 property. Fix a typo in popping stretch info. Add an assertion
4296 for verifying that the iterator position is in sync with the bidi
4298 (handle_single_display_spec, get_overlay_strings_1)
4299 (push_display_prop): Fix initialization of paragraph direction for
4300 string when that of the parent object is not yet determined.
4301 (reseat_1): Call bidi_init_it to resync the bidi
4302 iterator with IT's position. (Bug#7616)
4303 (find_row_edges): If ROW->start.pos gives position
4304 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4305 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4306 Reset the from_disp_prop_p flag.
4307 (SAVE_IT, RESTORE_IT): New macros.
4308 (pos_visible_p, face_before_or_after_it_pos)
4309 (back_to_previous_visible_line_start)
4310 (move_it_in_display_line_to, move_it_in_display_line)
4311 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4312 (try_scrolling, redisplay_window, display_line): Use them when
4313 saving a temporary copy of the iterator and restoring it back.
4314 (back_to_previous_visible_line_start, reseat_1)
4315 (init_iterator): Empty the bidi cache "stack".
4316 (move_it_in_display_line_to): If iterator ended up at
4317 EOL, but we never saw any buffer positions smaller than
4318 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4319 motion in bidi-reordered lines.
4320 (move_it_in_display_line_to): Record prev_method and prev_pos
4321 immediately before the call to set_iterator_to_next. Fixes cursor
4322 motion in bidi-reordered lines with stretch glyphs and strings
4323 displayed in margins. (Bug#8133) (Bug#8867)
4324 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4326 (pos_visible_p): Support positions in bidi-reordered lines.
4327 Save and restore bidi cache.
4329 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4330 (bidi_paragraph_info): Delete unused struct.
4331 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4332 (bidi_cache_start): New variable.
4333 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4335 (bidi_cache_fetch_state, bidi_cache_search)
4336 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4337 (bidi_cache_find, bidi_peek_at_next_level)
4338 (bidi_level_of_next_char, bidi_find_other_level_edge)
4339 (bidi_move_to_visually_next): Compare cache index with
4340 bidi_cache_start rather than with zero.
4341 (bidi_fetch_char): Accept new argument STRING; all callers
4342 changed. Support iteration over a string. Support strings with
4343 display properties. Support unibyte strings. Fix the type of
4344 `len' according to what STRING_CHAR_AND_LENGTH expects.
4345 (bidi_paragraph_init, bidi_resolve_explicit_1)
4346 (bidi_resolve_explicit, bidi_resolve_weak)
4347 (bidi_level_of_next_char, bidi_move_to_visually_next):
4348 Support iteration over a string.
4349 (bidi_set_sor_type, bidi_resolve_explicit_1)
4350 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4351 can now be zero (for strings); special values 0 and -1 were
4352 changed to -1 and -2, respectively.
4353 (bidi_char_at_pos): New function.
4354 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4355 Call it instead of FETCH_MULTIBYTE_CHAR.
4356 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4357 initialized to valid values.
4358 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4360 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4361 the test for valid cached positions. Fix the logic for looking up
4362 the sentinel state in the cache. GCPRO the Lisp string we are
4364 (bidi_push_it, bidi_pop_it): New functions.
4365 (bidi_initialize): Initialize the bidi cache start stack pointer.
4366 (bidi_cache_ensure_space): New function, refactored from part of
4367 bidi_cache_iterator_state. Don't assume the required size is just
4368 one BIDI_CACHE_CHUNK away.
4369 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4370 (bidi_count_bytes, bidi_char_at_pos): New functions.
4371 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4372 always valid if bidi_cache_idx is valid.
4373 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4374 is valid if it's going to be used.
4375 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4376 (bidi_cache_fetch_state, bidi_cache_search)
4377 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4378 (bidi_cache_iterator_state, bidi_cache_find)
4379 (bidi_find_other_level_edge, bidi_cache_start_stack):
4380 All variables related to cache indices are now EMACS_INT.
4382 * dispextern.h (struct bidi_string_data): New structure.
4383 (struct bidi_it): New member `string'. Make flag members be 1-bit
4384 fields, and put them last in the struct.
4385 (compute_display_string_pos, compute_display_string_end):
4387 (bidi_push_it, bidi_pop_it): Add prototypes.
4388 (struct iterator_stack_entry): New members bidi_p,
4389 paragraph_embedding, and from_disp_prop_p.
4390 (struct it): Member bidi_p is now a bit field 1 bit wide.
4391 (bidi_shelve_cache, bidi_unshelve_cache):
4394 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4395 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4396 and vector-like objects.
4398 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4399 cache around display iteration.
4401 * window.c (Fwindow_end, window_scroll_pixel_based)
4402 (displayed_window_lines, Frecenter): Save and restore the bidi
4403 cache around display iteration.
4405 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4407 * editfns.c (Fdelete_region): Clarify the use of the named
4408 parameters (bug#6788).
4410 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4412 * indent.c (Fvertical_motion): Set and restore w->pointm when
4413 saving and restoring the window's buffer (Bug#9006).
4415 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4417 * editfns.c (Fstring_to_char): Clarify just what is returned
4418 (bug#6576). Text by Eli Zaretskii.
4420 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4422 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4424 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4426 * buffer.c (mmap_find): Fix a typo.
4428 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4430 Fix execution of x selection hooks.
4431 * xselect.c (Qx_lost_selection_functions)
4432 (Qx_sent_selection_functions): New vars.
4433 (syms_of_xselect): DEFSYM them.
4434 (x_handle_selection_request): Pass Qx_sent_selection_functions
4435 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4436 (x_handle_selection_clear,x_clear_frame_selections):
4437 Pass Qx_lost_selection_functions rather than
4438 Vx_lost_selection_functions to Frun_hook_with_args.
4440 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4442 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4443 The old code sometimes used this field without initializing it.
4445 * alloc.c (gc_sweep): Don't read past end of array.
4446 In theory, the old code could also have corrupted Emacs internals,
4447 though it'd be very unlikely.
4449 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4451 * character.c (Fcharacterp): Don't advertise optional ignored
4452 argument. (Bug#4026)
4454 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4456 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4459 * window.c (Fset_window_start): Doc fix (bug#4199).
4460 (Fset_window_hscroll): Ditto.
4462 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4464 Fix minor new problems caught by GCC 4.6.1.
4465 * term.c (init_tty): Remove unused local.
4466 * xsettings.c (store_monospaced_changed): Define this function only
4467 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4470 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4472 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4474 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4476 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4477 are the mini-buffer and the echo area (bug#3320).
4479 * term.c (init_tty): Remove support for supdup, c10 and perq
4480 terminals, which are no longer supported (bug#1482).
4482 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4484 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4486 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4488 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4489 for non-popups (Bug#3642).
4491 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4493 * alloc.c (reset_malloc_hooks): Protoize.
4494 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4495 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4496 * cm.c (losecursor): Likewise.
4497 * data.c (fmod): Likewise.
4498 * dispnew.c (swap_glyphs_in_rows): Likewise.
4499 * emacs.c (memory_warning_signal): Likewise.
4500 * floatfns.c (float_error): Likewise.
4501 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4502 (otf_open, font_otf_capability, generate_otf_features)
4503 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4505 * image.c (pbm_read_file): Likewise.
4506 * indent.c (string_display_width): Likewise.
4507 * intervals.c (check_for_interval, search_for_interval)
4508 (inc_interval_count, count_intervals, root_interval)
4509 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4510 * lread.c (defalias): Likewise.
4511 * ralloc.c (r_alloc_check): Likewise.
4512 * regex.c (set_image_of_range_1, set_image_of_range)
4513 (regex_grow_registers): Likewise.
4514 * sysdep.c (strerror): Likewise.
4515 * termcap.c (valid_filename_p, tprint, main): Likewise.
4516 * tparam.c (main): Likewise.
4517 * unexhp9k800.c (run_time_remap, save_data_space)
4518 (update_file_ptrs, read_header, write_header, calculate_checksum)
4519 (copy_file, copy_rest, display_header): Likewise.
4520 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4522 * xdisp.c (check_it): Likewise.
4523 * xfaces.c (register_color, unregister_color, unregister_colors):
4525 * xfns.c (print_fontset_result): Likewise.
4526 * xrdb.c (member, fatal, main): Likewise.
4528 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4530 Fix minor problems found by static checking (Bug#9031).
4531 * chartab.c (char_table_set_range, map_sub_char_table):
4532 Remove unused locals.
4533 (uniprop_table): Now static.
4534 * composite.c (_work_char): Remove unused static var.
4536 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4538 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4540 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4542 * gtkutil.c (qttip_cb): Remove code without function.
4544 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4546 * w32.c (pthread_sigmask): New stub.
4548 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4550 Use pthread_sigmask, not sigprocmask (Bug#9010).
4551 sigprocmask is portable only for single-threaded applications, and
4552 Emacs can be multi-threaded when it uses GTK.
4553 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4555 * callproc.c (Fcall_process):
4556 * process.c (create_process):
4557 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4558 Use pthread_sigmask, not sigprocmask.
4560 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4562 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4563 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4566 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4568 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4569 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4570 (xg_hide_tooltip): Fix comment.
4572 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4573 in registerServicesMenuSendTypes.
4574 (validRequestorForSendType): Don't check ns_return_types.
4576 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4579 2011-07-08 Jason Rumney <jasonr@gnu.org>
4581 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4582 SH_SHOW for hidden windows (Bug#5482).
4584 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4585 frame struct members of non-existent frames (Bug#6284).
4587 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4589 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4590 variable firstTime not needed on OSX >= 10.6.
4591 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4592 >= 10.5. Use setKnobProportion, setDoubleValue.
4594 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4595 (MAC_OS_X_VERSION_10_5): Define if not defined.
4596 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4597 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4598 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4600 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4601 cString and lossyCString on OSX >= 10.4
4603 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4604 sizeToFit on OSX >= 10.2.
4606 * nsimage.m (allocInitFromFile): Don't use deprecated method
4607 bestRepresentationForDevice on OSX >= 10.6.
4609 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4612 * emacs.c: Declare unexec_init_emacs_zone.
4614 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4616 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4618 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4619 on svcsMenu (Bug#8842).
4621 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4623 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4625 * nsterm.m (QUTF8_STRING): Declare.
4626 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4627 (validRequestorForSendType): Return type is (id).
4628 Change indexOfObjectIdenticalTo to indexOfObject.
4629 Check if we have local selection before returning self (Bug#8842).
4630 (writeSelectionToPasteboard): Put local selection into paste board
4631 if we have a local selection (Bug#8842).
4632 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4634 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4635 (ns_get_local_selection): Declare.
4637 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4639 * keymap.c (describe_map_tree): Don't insert a double newline at
4640 the end of the buffer (bug#1169) and return whether we inserted
4643 * callint.c (Fcall_interactively): Change "reading args" to
4644 "providing args" to try to clarify what it does (bug#1010).
4646 2011-07-07 Kenichi Handa <handa@m17n.org>
4648 * composite.c (composition_compute_stop_pos): Ignore a static
4649 composition starting before CHARPOS (Bug#8915).
4651 * xdisp.c (handle_composition_prop): Likewise.
4653 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4655 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4658 2011-07-07 Kenichi Handa <handa@m17n.org>
4660 * character.h (unicode_category_t): New enum type.
4662 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4663 (Qchar_code_property_table): New variable.
4664 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4665 (UNIPROP_COMPRESSED_FORM_P): New macros.
4666 (char_table_ascii): Uncompress the compressed values.
4667 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4668 Uncompress the compressed values.
4669 (sub_char_table_ref_and_range): Likewise.
4670 (char_table_ref_and_range): Uncompress the compressed values.
4671 (sub_char_table_set): New arg is_uniprop. Callers changed.
4672 Uncompress the compressed values.
4673 (sub_char_table_set_range): Args changed. Callers changed.
4674 (char_table_set_range): Adjuted for the above change.
4675 (map_sub_char_table): Delete args default_val and parent. Add arg
4676 top. Give decoded values to a Lisp function.
4677 (map_char_table): Adjust for the above change. Give decoded
4678 values to a Lisp function. Gcpro more variables.
4679 (uniprop_table_uncompress)
4680 (uniprop_decode_value_run_length): New functions.
4681 (uniprop_decoder, uniprop_decoder_count): New variables.
4682 (uniprop_get_decoder, uniprop_encode_value_character)
4683 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4685 (uniprop_encoder, uniprop_encoder_count): New variables.
4686 (uniprop_get_encoder, uniprop_table)
4687 (Funicode_property_table_internal, Fget_unicode_property_internal)
4688 (Fput_unicode_property_internal): New functions.
4689 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4690 Sunicode_property_table_internal, Sget_unicode_property_internal,
4691 and Sput_unicode_property_internal. Defvar_lisp
4692 char-code-property-alist.
4694 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4695 Vunicode_category_table.
4697 * font.c (font_range): Adjust for the change of
4698 Vunicode_category_table.
4700 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4702 * m/iris4d.h: Remove file, move contents ...
4703 * s/irix6-5.h: ... here.
4705 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4707 Remove unportable assumption about struct layout (Bug#8884).
4708 * alloc.c (mark_buffer):
4709 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4710 (clone_per_buffer_values): Don't assume that
4711 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4712 This isn't true in general, and it's particularly not true
4713 if Emacs is configured with --with-wide-int.
4714 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4715 New macros, used in the buffer.c change.
4717 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4719 * xsettings.c: Use both GConf and GSettings if both are available.
4720 (store_config_changed_event): Add comment.
4721 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4722 (store_tool_bar_style_changed): New functions.
4723 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4724 (struct xsettings): Move font inside HAVE_XFT.
4725 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4726 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4727 Move inside HAVE_XFT.
4728 (something_changed_gsettingsCB): Rename from something_changedCB.
4729 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4731 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4732 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4733 (something_changed_gconfCB): Rename from something_changedCB.
4734 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4735 (parse_settings): Move check for font inside HAVE_XFT.
4736 (read_settings, apply_xft_settings): Add comment.
4737 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4738 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4739 call store_font_name_changed.
4740 (xft_settings_event): Add comment.
4741 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4742 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4743 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4744 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4745 (xsettings_initialize): Call init_gsettings last.
4746 (xsettings_get_system_font, xsettings_get_system_normal_font):
4749 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4751 Random fixes. E.g., (random) never returned negative values.
4752 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4753 subseconds part to the entropy, as that's a bit more random.
4754 Prefer signed to unsigned, since the signedness doesn't matter and
4755 in general we prefer signed. When given a limit, use a
4756 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4757 latter isn't right if USE_2_TAGS_FOR_INTS.
4758 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4759 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4761 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4763 * textprop.c (text_property_stickiness):
4764 Obey Vtext_property_default_nonsticky.
4765 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4766 * w32fns.c (syms_of_w32fns):
4767 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4769 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4771 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4772 This is more efficient than Ffile_directory_p and avoids a minor race.
4774 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4776 * buffer.c (Foverlay_put): Say what the return value is
4779 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4780 is a directory before asking whether to use the file name
4782 (barf_or_query_if_file_exists): Make the "File is a directory"
4783 error be more correct.
4785 * fns.c (Frequire): Remove the mention of the .gz files, since
4786 that's installation-specific, but keep the mention of
4787 `get-load-suffixes'.
4789 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4791 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4792 Report string overflow if the output is too long.
4794 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4796 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4797 (syms_of_gnutls): Remove duplicate DEFSYM for
4798 Qgnutls_bootprop_verify_hostname_error, an error for
4799 Qgnutls_bootprop_verify_error (which is no longer used).
4801 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4802 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4803 Also (re)move comments that are misplaced or no longer relevant.
4805 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4807 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4809 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4811 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4812 and background color parameters if they have been changed.
4814 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4816 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4818 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4820 * xsettings.c (SYSTEM_FONT): Define only when used.
4821 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4823 * keymap.c (access_keymap_1): Now static.
4825 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4827 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4828 leave any prefix arg for the up event (Bug#1586).
4830 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4832 * lread.c (syms_of_lread): Mention single symbols defined by
4833 `defvar' or `defconst' (bug#7154).
4835 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4836 (Frequire): Mention get-load-suffixes.
4838 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4840 * window.h (window): Remove clone_number slot.
4841 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4843 (make_parent_window, make_window, saved_window)
4844 (Fset_window_configuration, save_window_save): Don't deal with
4846 * buffer.c (Qclone_number): Remove declaration.
4847 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4849 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4851 Add multiple inheritance to keymaps.
4852 * keymap.c (Fmake_composed_keymap): New function.
4853 (Fset_keymap_parent): Simplify.
4854 (fix_submap_inheritance): Remove.
4855 (access_keymap_1): New function extracted from access_keymap to handle
4856 embedded parents and handle lists of maps.
4857 (access_keymap): Use it.
4858 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4859 (Fcopy_keymap): Handle embedded parents.
4860 (Fcommand_remapping, define_as_prefix): Simplify.
4861 (Fkey_binding): Simplify.
4862 (syms_of_keymap): Move minibuffer-local-completion-map,
4863 minibuffer-local-filename-completion-map,
4864 minibuffer-local-must-match-map, and
4865 minibuffer-local-filename-must-match-map to Elisp.
4866 (syms_of_keymap): Defsubr make-composed-keymap.
4867 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4868 (parse_menu_item): Trivial simplification.
4870 2011-07-01 Glenn Morris <rgm@gnu.org>
4872 * Makefile.in (SETTINGS_LIBS): Fix typo.
4874 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4876 * coding.c (Fencode_coding_string): Record the last coding system
4877 used, as the function doc string says (bug#8738).
4879 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4881 * xsettings.c (store_monospaced_changed): Take new font as arg and
4882 check for change against current_mono_font.
4883 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4884 (emacs_settings_constructor, emacs_settings_get_property)
4885 (emacs_settings_set_property, emacs_settings_class_init)
4886 (emacs_settings_init, gsettings_obj): Remove.
4887 (something_changedCB): New function for HAVE_GSETTINGS.
4888 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4889 with value as argument.
4890 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4891 g_settings_new (Bug#8967). Do not create gsettings_obj.
4892 Remove calls to g_settings_bind. Connect something_changedCB to
4895 * xgselect.c: Add defined (HAVE_GSETTINGS).
4896 (xgselect_initialize): Ditto.
4898 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4899 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4902 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4904 * eval.c (struct backtrace): Simplify and port the data structure.
4905 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4906 signed bit field, as this assumption is not portable and it makes
4907 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4908 "char debug_on_exit : 1" as this is not portable either; instead,
4909 use the portable "unsigned int debug_on_exit : 1". Remove unused
4910 member evalargs. Remove obsolete comments about cc bombing out.
4912 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4914 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4915 Let HAVE_GSETTINGS override HAVE_GCONF.
4916 (store_monospaced_changed): New function.
4917 (EMACS_SETTINGS): A new type derived from GObject to handle
4918 GSettings notifications.
4919 (emacs_settings_constructor, emacs_settings_get_property)
4920 (emacs_settings_set_property, emacs_settings_class_init):
4922 (gsettings_client, gsettings_obj): New variables.
4923 (GSETTINGS_SCHEMA): New define.
4924 (something_changedCB): Call store_monospaced_changed.
4925 (init_gsettings): New function.
4926 (xsettings_initialize): Call init_gsettings.
4927 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4930 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4933 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4935 * window.c (resize_root_window, grow_mini_window)
4936 (shrink_mini_window): Rename Qresize_root_window to
4937 Qwindow_resize_root_window and Qresize_root_window_vertically to
4938 Qwindow_resize_root_window_vertically.
4940 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4942 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4944 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4946 * makefile.w32-in: Redesign dependencies so they reflect more
4947 clearly which files are directly included by each source file,
4948 and not through other includes.
4950 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4952 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4953 (sort_overlays, overlay_strings): When an overlay's clone number
4954 matches the window's clone number process the overlay even if
4955 the overlay's window property doesn't match the current window.
4957 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4958 (Fwindow_hchild): Rename to Fwindow_left_child.
4959 (Fwindow_next): Rename to Fwindow_next_sibling.
4960 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4961 (resize_window_check): Rename to window_resize_check.
4962 (resize_window_apply): Rename to window_resize_apply.
4963 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4964 (Fdelete_other_windows_internal, resize_frame_windows)
4965 (Fsplit_window_internal, Fdelete_window_internal)
4966 (grow_mini_window, shrink_mini_window)
4967 (Fresize_mini_window_internal): Fix callers accordingly.
4969 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4971 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4972 (emacs_fixed_set_min_size): Remove.
4973 (emacs_fixed_new): Take frame as argument.
4975 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4976 (_EmacsFixedPrivate): Remove minwidth/height.
4977 Add struct frame *f.
4978 (emacs_fixed_init): Initialize priv->f.
4979 (get_parent_class, emacs_fixed_set_min_size): Remove.
4980 (emacs_fixed_new): Set priv->f to argument.
4981 (emacs_fixed_get_preferred_width)
4982 (emacs_fixed_get_preferred_height): Use min_width/height from
4983 frames size_hint to set minimum and natural (Bug#8919).
4984 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4985 and use min_width/height from frames size_hint to set
4986 min_width/height (Bug#8919).
4988 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4989 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4992 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4994 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4995 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4998 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5000 * process.c (wait_reading_process_output): Bypass select if
5001 waiting for a cell while ignoring keyboard input, and input is
5002 pending. Suggested by Jan Djärv (Bug#8869).
5004 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5006 Use gnulib's dup2 module instead of rolling our own.
5007 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5009 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5011 * dispnew.c (scrolling_window): Before scrolling, turn off a
5012 mouse-highlight in the window being scrolled.
5014 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5016 Move DEFSYM to lisp.h and use everywhere.
5018 * character.h (DEFSYM): Move declaration...
5019 * lisp.h (DEFSYM): ...here.
5025 * w32select.c: Don't include character.h.
5027 * alloc.c (syms_of_alloc):
5028 * buffer.c (syms_of_buffer):
5029 * bytecode.c (syms_of_bytecode):
5030 * callint.c (syms_of_callint):
5031 * casefiddle.c (syms_of_casefiddle):
5032 * casetab.c (init_casetab_once):
5033 * category.c (init_category_once, syms_of_category):
5034 * ccl.c (syms_of_ccl):
5035 * cmds.c (syms_of_cmds):
5036 * composite.c (syms_of_composite):
5037 * dbusbind.c (syms_of_dbusbind):
5038 * dired.c (syms_of_dired):
5039 * dispnew.c (syms_of_display):
5040 * doc.c (syms_of_doc):
5041 * editfns.c (syms_of_editfns):
5042 * emacs.c (syms_of_emacs):
5043 * eval.c (syms_of_eval):
5044 * fileio.c (syms_of_fileio):
5045 * fns.c (syms_of_fns):
5046 * frame.c (syms_of_frame):
5047 * fringe.c (syms_of_fringe):
5048 * insdel.c (syms_of_insdel):
5049 * keymap.c (syms_of_keymap):
5050 * lread.c (init_obarray, syms_of_lread):
5051 * macros.c (syms_of_macros):
5052 * msdos.c (syms_of_msdos):
5053 * print.c (syms_of_print):
5054 * process.c (syms_of_process):
5055 * search.c (syms_of_search):
5056 * sound.c (syms_of_sound):
5057 * syntax.c (init_syntax_once, syms_of_syntax):
5058 * terminal.c (syms_of_terminal):
5059 * textprop.c (syms_of_textprop):
5060 * undo.c (syms_of_undo):
5061 * w32.c (globals_of_w32):
5062 * window.c (syms_of_window):
5063 * xdisp.c (syms_of_xdisp):
5064 * xfaces.c (syms_of_xfaces):
5065 * xfns.c (syms_of_xfns):
5066 * xmenu.c (syms_of_xmenu):
5067 * xsettings.c (syms_of_xsettings):
5068 * xterm.c (syms_of_xterm): Use DEFSYM.
5070 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5072 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5074 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5076 Integer and buffer overflow fixes (Bug#8873).
5078 * print.c (printchar, strout): Check for string overflow.
5079 (PRINTPREPARE, printchar, strout):
5080 Don't set size unless allocation succeeds.
5082 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5083 for sizes. Check for string overflow more accurately.
5084 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5086 * macros.c: Integer and buffer overflow fixes.
5087 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5088 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5089 Use ptrdiff_t, not int, for sizes.
5090 Don't increment bufsize until after realloc succeeds.
5091 Check for size-calculation overflow.
5092 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5094 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5096 * lread.c: Integer overflow fixes.
5097 (read_integer): Radix is now EMACS_INT, not int,
5098 to improve quality of diagnostics for out-of-range radices.
5099 Calculate buffer size correctly for out-of-range radices.
5100 (read1): Check for integer overflow in radices, and in
5101 read-circle numbers.
5102 (read_escape): Avoid int overflow.
5103 (Fload, openp, read_buffer_size, read1)
5104 (substitute_object_recurse, read_vector, read_list, map_obarray):
5105 Use ptrdiff_t, not int, for sizes.
5106 (read1): Use EMACS_INT, not int, for sizes.
5107 Check for size overflow.
5109 * image.c (cache_image): Check for size arithmetic overflow.
5111 * lread.c: Integer overflow issues.
5112 (saved_doc_string_size, saved_doc_string_length)
5113 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5114 Now ptrdiff_t, not int.
5115 (read1): Don't assume doc string length fits in int. Check for
5116 out-of-range doc string lengths.
5117 (read_list): Don't assume file position fits in int.
5118 (read_escape): Check for hex character overflow.
5120 2011-06-22 Leo Liu <sdl.web@gmail.com>
5122 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5123 Move to minibuffer.el.
5125 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5127 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5128 The following patches are for when GLYPH_DEBUG && !XASSERT.
5129 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5130 * dispnew.c (flush_stdout):
5131 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5132 Mark as externally visible.
5133 * dispnew.c (check_window_matrix_pointers): Now static.
5134 * dispnew.c (window_to_frame_vpos):
5135 * xfns.c (unwind_create_frame):
5136 * xterm.c (x_check_font): Remove unused local.
5137 * scroll.c (CHECK_BOUNDS):
5138 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5139 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5140 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5141 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5142 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5144 (debug_method_add): Use va_list and vsprintf rather than relying
5145 on undefined behavior with wrong number of arguments.
5146 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5147 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5148 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5149 since we're not interested in debugging glyphs with old libraries.
5150 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5151 GCC 4.6.0's static checking.
5153 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5155 Integer overflow and signedness fixes (Bug#8873).
5156 A few related buffer overrun fixes, too.
5158 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5160 * dispextern.h (struct face.stipple):
5161 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5162 (x_bitmap_mask, x_allocate_bitmap_record)
5163 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5164 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5165 (x_create_bitmap_from_xpm_data):
5166 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5167 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5169 * xfaces.c (load_pixmap):
5170 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5171 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5172 (.bitmaps_last, struct x_output.icon_bitmap):
5173 Use ptrdiff_t, not int, for bitmap indexes.
5174 (x_allocate_bitmap_record): Check for size overflow.
5175 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5177 Use ptrdiff_t, not int, for overlay counts.
5178 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5179 * editfns.c (overlays_around, get_pos_property):
5180 * textprop.c (get_char_property_and_overlay):
5181 * xdisp.c (next_overlay_change, note_mouse_highlight):
5182 * xfaces.c (face_at_buffer_position):
5183 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5184 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5185 (Fnext_overlay_change, Fprevious_overlay_change)
5186 (mouse_face_overlay_overlaps, Foverlays_in):
5187 Use ptrdiff_t, not int, for sizes.
5188 (overlays_at, overlays_in): Check for size-calculation overflow.
5190 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5192 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5193 (x_session_initialize): Do not assume string length fits in int.
5195 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5196 This is unlikely, but can occur if DPI is outlandish.
5198 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5199 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5201 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5202 * xrdb.c (magic_file_p, search_magic_path):
5203 Omit last arg SUFFIX; it was always 0. All callers changed.
5204 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5206 * xfont.c (xfont_match): Avoid need for strlen.
5208 * xfns.c: Don't assume strlen fits in int.
5209 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5211 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5212 not unsigned long, as we prefer signed integers. All callers changed.
5213 Detect integer overflow in repeat count.
5214 (message_dolog): Don't assume print length fits in 39 bytes.
5215 (display_mode_element): Don't assume strlen fits in int.
5217 * termcap.c: Don't assume sizes fit in int and never overflow.
5218 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5219 (gobble_line): Check for size-calculation overflow.
5221 * minibuf.c (Fread_buffer):
5222 * lread.c (intern, intern_c_string):
5223 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5224 Don't assume string length fits in int.
5226 * keyboard.c (parse_tool_bar_item):
5227 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5229 * font.c: Don't assume string length fits in int.
5230 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5231 Use ptrdiff_t, not int.
5232 (font_intern_prop): Don't assume string length fits in int.
5233 Don't assume integer property fits in fixnum.
5234 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5236 * filelock.c: Fix some buffer overrun and integer overflow issues.
5237 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5238 Reformulate so as not to need the command string.
5239 Invoke gzip -cd rather than gunzip, as it's more portable.
5240 (lock_info_type, lock_file_1, lock_file):
5241 Don't assume pid_t and time_t fit in unsigned long.
5242 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5243 (current_lock_owner): Prefer signed type for sizes.
5244 Use memcpy, not strncpy, where memcpy is what is really wanted.
5245 Don't assume (via atoi) that time_t and pid_t fit in int.
5246 Check for time_t and/or pid_t out of range, e.g., via a network share.
5247 Don't alloca where an auto var works fine.
5249 * fileio.c: Fix some integer overflow issues.
5250 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5251 Don't assume string length fits in int.
5252 (directory_file_name): Don't assume string length fits in long.
5253 (make_temp_name): Don't assume pid fits in int, or that its print
5254 length is less than 20.
5256 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5258 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5260 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5262 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5263 We prefer signed integers, even for size calculations.
5265 * emacs.c: Don't assume string length fits in 'int'.
5266 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5267 (main): Don't invoke strlen when not needed.
5269 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5270 (XD_DEBUG_MESSAGE): Don't waste a byte.
5272 * callproc.c (getenv_internal_1, getenv_internal)
5274 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5276 * lread.c (invalid_syntax): Omit length argument.
5277 All uses changed. This doesn't fix a bug, but it simplifies the
5278 code away from its former Hollerith-constant appearance, and it's
5279 one less 'int' to worry about when looking at integer-overflow issues.
5280 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5282 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5283 This didn't break anything, but it didn't help either.
5284 It's confusing to put a bogus integer in a place where the actual
5285 value does not matter.
5286 (LIST_END_P): Remove unused macro and its bogus comment.
5287 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5289 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5290 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5292 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5293 We prefer signed types, and the value cannot exceed the EMACS_INT
5294 range anyway (because otherwise the length would not be representable).
5295 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5296 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5297 This avoids a GCC warning when WIDE_EMACS_INT.
5299 * indent.c (sane_tab_width): New function.
5300 (current_column, scan_for_column, Findent_to, position_indentation)
5301 (compute_motion): Use it. This is just for clarity.
5302 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5304 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5306 * lisp.h (lint_assume): New macro.
5307 * composite.c (composition_gstring_put_cache):
5308 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5310 * editfns.c, insdel.c:
5311 Omit unnecessary forward decls, to simplify future changes.
5313 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5315 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5317 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5318 Use much-faster test for byte-length change.
5319 Don't assume string byte-length fits in 'int'.
5320 Check that character arg fits in 'int'.
5321 (mapcar1): Declare byte as byte, for clarity.
5323 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5325 * fns.c (concat): Catch string overflow earlier.
5326 Do not rely on integer wraparound.
5328 * dispextern.h (struct it.overlay_strings_charpos)
5329 (struct it.selective): Now EMACS_INT, not int.
5330 * xdisp.c (forward_to_next_line_start)
5331 (back_to_previous_visible_line_start)
5332 (reseat_at_next_visible_line_start, next_element_from_buffer):
5333 Don't arbitrarily truncate the value of 'selective' to int.
5335 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5337 * composite.c: Don't truncate sizes to 'int'.
5338 (composition_gstring_p, composition_reseat_it)
5339 (composition_adjust_point): Use EMACS_INT, not int.
5340 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5341 not EMACS_UINT, for indexes.
5343 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5345 * buffer.c: Include <verify.h>.
5346 (struct sortvec.priority, struct sortstr.priority):
5347 Now EMACS_INT, not int.
5348 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5349 (struct sortstr.size, record_overlay_string)
5350 (struct sortstrlist.size, struct sortlist.used):
5351 Don't truncate size to int.
5352 (record_overlay_string): Check for size-calculation overflow.
5353 (init_buffer_once): Check at compile-time, not run-time.
5355 2011-06-22 Jim Meyering <meyering@redhat.com>
5357 Don't leak an XBM-image-sized buffer
5358 * image.c (xbm_load): Free the image buffer after using it.
5360 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5363 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5364 that Sun C diagnosed.
5365 * fns.c (secure_hash): Fix pointer signedness issue.
5366 * intervals.c (static_offset_intervals): New function.
5367 (offset_intervals): Use it.
5369 2011-06-21 Leo Liu <sdl.web@gmail.com>
5372 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5375 * fns.c (secure_hash): Rename from crypto_hash_function and change
5376 the first arg to accept symbols.
5377 (Fsecure_hash): New primitive.
5378 (syms_of_fns): New symbols.
5380 2011-06-20 Deniz Dogan <deniz@dogan.se>
5382 * process.c (Fset_process_buffer): Clarify return value in
5385 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5387 * dispnew.c (add_window_display_history): Use BVAR.
5389 * xdisp.c (debug_method_add): Use BVAR.
5390 (check_window_end, dump_glyph_matrix, dump_glyph)
5391 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5393 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5396 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5397 check till after the cache is created in init_frame_faces.
5399 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5401 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5403 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5405 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5406 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5407 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5409 Improve buffer-overflow checking (Bug#8873).
5410 * fileio.c (Finsert_file_contents):
5411 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5412 Remove the old (too-loose) buffer overflow checks.
5413 They weren't needed, since make_gap checks for buffer overflow.
5414 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5415 The old code merely checked for Emacs fixnum overflow, and relied
5416 on undefined (wraparound) behavior. The new code avoids undefined
5417 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5419 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5420 Tune. Don't use wider integers than needed. Don't use alloca.
5421 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5423 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5425 * insdel.c, lisp.h (buffer_overflow): New function.
5426 (insert_from_buffer_1, replace_range, replace_range_2):
5427 * insdel.c (make_gap_larger):
5428 * editfns.c (Finsert_char):
5429 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5431 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5433 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5435 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5437 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5438 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5440 * fileio.c: Don't assume EMACS_INT fits in off_t.
5441 (emacs_lseek): New static function.
5442 (Finsert_file_contents, Fwrite_region): Use it.
5443 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5445 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5447 * fns.c: Don't overflow int when computing a list length.
5448 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5449 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5450 truncation on 64-bit hosts. Check for QUIT every
5451 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5452 faster and is responsive enough.
5453 (Flength): Report an error instead of overflowing an integer.
5454 (Fsafe_length): Return a float if the value is not representable
5455 as a fixnum. This shouldn't happen except in contrived situations.
5456 (Fnthcdr, Fsort): Don't assume list length fits in int.
5457 (Fcopy_sequence): Don't assume vector length fits in int.
5459 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5460 (header_size, word_size): New constants.
5461 (allocate_vectorlike): Don't check size overflow here.
5462 (allocate_vector): Check it here instead, since this is the only
5463 caller of allocate_vectorlike that could cause overflow.
5464 Check that the new vector's length is representable as a fixnum.
5466 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5467 The previous code was bogus. For example, next_almost_prime (32)
5468 returned 39, which is undesirable as it is a multiple of 3; and
5469 next_almost_prime (24) returned 25, which is a multiple of 5 so
5470 why was the code bothering to check for multiples of 7?
5472 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5474 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5476 Variadic C functions now count arguments with ptrdiff_t.
5477 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5478 Back then I didn't know that the Emacs coding style prefers signed int.
5479 Also, in the meantime I found a few more instances where arguments
5480 were being counted with int, which may truncate counts on 64-bit
5481 machines, or EMACS_INT, which may be unnecessarily wide.
5482 * lisp.h (struct Lisp_Subr.function.aMANY)
5483 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5484 Arg counts are now ptrdiff_t, not size_t.
5485 All variadic functions and their callers changed accordingly.
5486 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5487 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5488 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5489 * callint.c (Fcall_interactively): Check arg count for overflow,
5490 to avoid potential buffer overrun. Use signed char, not 'int',
5491 for 'varies' array, so that we needn't bother to check its size
5492 calculation for overflow.
5493 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5494 * eval.c (apply_lambda):
5495 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5496 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5497 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5499 * callint.c (Fcall_interactively): Don't use index var as event count.
5501 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5502 * mem-limits.h (SIZE): Remove; no longer used.
5504 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5506 Remove unnecessary casts.
5507 * xterm.c (x_term_init):
5508 * xfns.c (x_set_border_pixel):
5509 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5510 These aren't needed now that we assume ANSI C.
5512 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5513 It's more likely to cause problems (due to unsigned overflow)
5516 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5518 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5520 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5522 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5524 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5526 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5528 GLYPH_CODE_FACE returns EMACS_INT, not int.
5529 * dispextern.h (merge_faces):
5530 * xfaces.c (merge_faces):
5531 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5532 Don't assume EMACS_INT fits in int.
5534 * character.h (CHAR_VALID_P): Remove unused parameter.
5535 * fontset.c, lisp.h, xdisp.c: All uses changed.
5537 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5539 * fns.c (concat): Minor tuning based on overflow analysis.
5540 This doesn't fix any bugs. Use int to hold character, instead
5541 of constantly refetching from Emacs object. Use XFASTINT, not
5542 XINT, for value known to be a character. Don't bother comparing
5543 a single byte to 0400, as it's always less.
5545 * floatfns.c (Fexpt):
5546 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5548 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5551 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5553 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5554 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5555 incorrectly succeed when S was a string, because 4294967386 was
5556 truncated before it was used.
5558 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5559 Otherwise, an out-of-range integer could cause undefined behavior
5562 * composite.c: Use int, not EMACS_INT, for characters.
5563 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5564 EMACS_INT, for values that are known to be in character range.
5565 This doesn't fix any bugs but is the usual style inside Emacs and
5566 may generate better code on 32-bit machines.
5568 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5569 This is for reasons similar to the recent CHAR_STRING fix.
5570 * charset.c (Fencode_char): Check that character arg is actually
5571 a character. Pass an int to ENCODE_CHAR.
5572 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5573 wider than 'int', as a compile-time check to prevent future regressions
5576 * character.c (char_string): Remove unnecessary casts.
5578 Make sure a 64-bit char is never passed to CHAR_STRING.
5579 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5580 by silently ignoring the top 32 bits, allowing some values
5581 that were far too large to be valid characters.
5582 * character.h: Include <verify.h>.
5583 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5584 arguments are no wider than unsigned, as a compile-time check
5585 to prevent future regressions in this area.
5587 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5588 (Fsubst_char_in_region):
5590 * xdisp.c (decode_mode_spec_coding):
5591 Adjust to CHAR_STRING's new requirement.
5592 * editfns.c (Finsert_char, Fsubst_char_in_region):
5593 * fns.c (concat): Check that character args are actually
5594 characters. Without this test, these functions did the wrong
5595 thing with wildly out-of-range values on 64-bit hosts.
5597 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5598 These casts should not be needed on 32-bit hosts, either.
5599 * keyboard.c (read_char):
5600 * lread.c (Fload): Remove casts to unsigned.
5602 * lisp.h (UNSIGNED_CMP): New macro.
5603 This fixes comparison bugs on 64-bit hosts.
5604 (ASCII_CHAR_P): Use it.
5605 * casefiddle.c (casify_object):
5606 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5607 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5608 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5609 * dispextern.h (FACE_FROM_ID):
5610 * keyboard.c (read_char): Use UNSIGNED_CMP.
5612 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5613 not to EMACS_INT, to avoid GCC warning.
5615 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5617 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5618 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5619 isn't needed on 32-bit machines.
5621 * buffer.c (Fgenerate_new_buffer_name):
5622 Use EMACS_INT for count, not int.
5623 (advance_to_char_boundary): Return EMACS_INT, not int.
5625 * data.c (Qcompiled_function): Now static.
5627 * window.c (window_body_lines): Now static.
5629 * image.c (gif_load): Rename local to avoid shadowing.
5631 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5632 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5633 * alloc.c (make_save_value): Integer argument is now of type
5635 (mark_object): Use ptrdiff_t, not int.
5636 * lisp.h (pD): New macro.
5637 * print.c (print_object): Use it.
5639 * alloc.c: Use EMACS_INT, not int, to count objects.
5640 (total_conses, total_markers, total_symbols, total_vector_size)
5641 (total_free_conses, total_free_markers, total_free_symbols)
5642 (total_free_floats, total_floats, total_free_intervals)
5643 (total_intervals, total_strings, total_free_strings):
5644 Now EMACS_INT, not int. All uses changed.
5645 (Fgarbage_collect): Compute overall total using a double, so that
5646 integer overflow is less likely to be a problem. Check for overflow
5647 when converting back to an integer.
5648 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5649 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5650 These were 'int' variables that could overflow on 64-bit hosts;
5651 they were never used, so remove them instead of repairing them.
5652 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5653 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5654 Previously, this ceilinged at INT_MAX, but that doesn't work on
5656 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5658 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5659 (allocate_vectorlike): Check for ptrdiff_t overflow.
5660 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5661 when a (possibly-narrower) signed value would do just as well.
5662 We prefer using signed arithmetic, to avoid comparison confusion.
5664 * alloc.c: Catch some string size overflows that we were missing.
5665 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5666 for convenience in STRING_BYTES_MAX.
5667 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5668 The definition here is exact; the one in lisp.h was approximate.
5669 (allocate_string_data): Check for string overflow. This catches
5670 some instances we weren't catching before. Also, it catches
5671 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5672 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5673 and ptrdiff_t and EMACS_INT are both 64 bits.
5675 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5676 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5677 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5679 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5681 * alloc.c (Fmake_string): Check for out-of-range init.
5683 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5685 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5687 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5689 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5690 xg_get_default_scrollbar_width.
5692 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5693 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5694 (style_changed_cb): Call update_theme_scrollbar_width and call
5695 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5696 all frames (Bug#8505).
5697 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5698 Call gtk_window_set_resizable if HAVE_GTK3.
5699 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5700 and height if HAVE_GTK3 (Bug#8505).
5701 (scroll_bar_width_for_theme): New variable.
5702 (update_theme_scrollbar_width): New function.
5703 (xg_get_default_scrollbar_width): Move code to
5704 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5705 (xg_initialize): Call update_theme_scrollbar_width.
5707 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5709 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5711 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5713 * frame.c (make_frame): Call other_buffer_safely instead of
5716 * window.c (temp_output_buffer_show): Call display_buffer with
5717 second argument Vtemp_buffer_show_specifiers and reset latter
5718 immediately after the call.
5719 (Vtemp_buffer_show_specifiers): New variable.
5720 (auto_window_vscroll_p, next_screen_context_lines)
5721 (Vscroll_preserve_screen_position): Remove leading asterisks from
5724 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5726 Fix minor problems found by GCC 4.6.0 static checking.
5727 * buffer.c (Qclone_number): Remove for now, as it's unused.
5728 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5729 (record_buffer): Remove unused local.
5730 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5731 (set_frame_buffer_list): Remove; unused.
5732 * frame.h (other_visible_frames): Remove decl.
5733 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5734 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5735 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5737 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5738 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5739 Define only if HAVE_GPM.
5740 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5741 (update_hints_inhibit): Remove; never set. All uses removed.
5742 * widgetprv.h (emacsFrameClassRec): Remove decl.
5743 * window.c (delete_deletable_window): Now returns void, since it
5744 wasn't returning anything.
5745 (compare_window_configurations): Remove unused locals.
5746 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5747 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5748 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5749 the same widths as pointers. This follows up on the 2011-05-06 patch.
5750 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5751 * xterm.h: Likewise.
5752 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5754 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5756 * makefile.w32-in: Update dependencies.
5757 (LISP_H): Add lib/intprops.h.
5759 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5761 * image.c (gif_load): Add animation frame delay to the metadata.
5762 (syms_of_image): Use DEFSYM. New symbol `delay'.
5764 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5766 * window.c (delete_deletable_window): Re-add.
5767 (Fset_window_configuration): Rewrite to handle dead buffers and
5768 consequently deletable windows.
5769 (window_tree, Fwindow_tree): Remove. Supply functionality in
5771 (compare_window_configurations): Simplify code.
5773 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5775 * image.c (imagemagick_load_image): Fix type mismatch.
5776 (Fimagemagick_types): Likewise.
5778 * window.h (replace_buffer_in_windows): Declare.
5780 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5782 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5783 Qclone_number. Remove external declaration of Qdelete_window.
5784 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5786 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5787 Run Qbuffer_list_update_hook if allowed.
5788 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5789 buffer list implementation.
5790 (other_buffer_safely): New function.
5791 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5792 calls to replace_buffer_in_windows and
5793 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5795 (record_buffer): Inhibit quitting and rewrite using quittable
5796 functions. Run Qbuffer_list_update_hook if allowed.
5797 (Frecord_buffer, Funrecord_buffer): New functions.
5798 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5799 Move switch-to-buffer to window.el.
5800 (bury-buffer): Move to window.el.
5801 (Vbuffer_list_update_hook): New variable.
5803 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5806 * window.h (resize_frame_windows): Move up in code.
5807 (Fwindow_frame): Remove EXFUN.
5808 (replace_buffer_in_all_windows): Remove prototype.
5809 (replace_buffer_in_windows_safely): Add prototype.
5811 * window.c: Declare Qdelete_window static again. Move down
5812 declaration of select_count.
5813 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5814 (Fother_window): Move to window.el.
5815 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5816 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5817 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5819 (replace_buffer_in_windows): Implement by calling
5820 Qreplace_buffer_in_windows.
5821 (replace_buffer_in_all_windows): Remove with some functionality
5822 moved into replace_buffer_in_windows_safely.
5823 (replace_buffer_in_windows_safely): New function.
5824 (select_window_norecord, select_frame_norecord): Move in front
5825 of run_window_configuration_change_hook. Remove now obsolete
5827 (Fset_window_buffer): Rewrite doc-string.
5828 Call Qrecord_window_buffer.
5829 (keys_of_window): Move binding for other-window to window.el.
5831 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5833 * dispextern.h (struct image): Replace data member, whose int_val
5834 and ptr_val fields were not used by anything, with a single
5837 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5838 (gif_clear_image, gif_load, imagemagick_load_image)
5839 (gs_clear_image, gs_load): Callers changed.
5841 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5843 * buffer.h: Include <time.h>, for time_t.
5844 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5846 Fix minor problems found by static checking.
5848 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5850 Make identifiers static if they are not used in other modules.
5851 * data.c (Qcompiled_function, Qframe, Qvector):
5852 * image.c (QimageMagick, Qsvg):
5853 * minibuf.c (Qmetadata):
5854 * window.c (resize_window_check, resize_root_window): Now static.
5855 * window.h (resize_window_check, resize_root_window): Remove decls.
5857 * window.c (window_deletion_count, delete_deletable_window):
5859 (window_body_lines): Now static.
5860 (Fdelete_other_windows_internal): Mark vars as initialized.
5861 Make sure 'resize_failed' is initialized.
5862 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5863 (resize_window_apply): Remove unused local.
5864 * window.h (delete_deletable_window): Remove decl.
5866 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5867 (imagemagick_load_image): Fix pointer signedness problem by changing
5868 last arg from unsigned char * to char *. All uses changed.
5869 Also, fix a local for similar reasons.
5870 Remove unused locals. Remove locals to avoid shadowing.
5871 (fn_rsvg_handle_free): Remove; unused.
5872 (svg_load, svg_load_image): Fix pointer signedness problem.
5873 (imagemagick_load_image): Don't use garbage pointer image_wand.
5875 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5877 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5879 * image.c (gif_load): Fix omitted cast error introduced by
5882 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5884 * window.h (resize_proportionally, orig_total_lines)
5885 (orig_top_line): Remove from window structure.
5886 (set_window_height, set_window_width, change_window_heights)
5887 (Fdelete_window): Remove prototypes.
5888 (resize_frame_windows): Remove duplicate declaration.
5890 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5892 * window.h (resize_frame_windows, resize_window_check)
5893 (delete_deletable_window, resize_root_window)
5894 (resize_frame_windows): Declare prototypes.
5896 * window.c (resize_window_apply): Make definition be "static" to
5897 match the prototype.
5899 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5901 * window.c: Remove declarations of Qwindow_size_fixed,
5902 window_min_size_1, window_min_size_2, window_min_size,
5903 size_window, window_fixed_size_p, enlarge_window, delete_window.
5904 Remove static from declaration of Qdelete_window, it's
5905 temporarily needed by Fbury_buffer.
5906 (replace_window): Don't assign orig_top_line and
5908 (Fdelete_window, delete_window): Remove. Window deletion is
5909 handled by window.el.
5910 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5911 Replace Fdelete_window calls with calls to Qdelete_window.
5912 (Fdelete_other_windows): Remove. Deleting other windows is
5913 handled by window.el.
5914 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5915 handled in window.el.
5916 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5917 Window minimum sizes are handled in window.el.
5918 (shrink_windows, size_window, set_window_height)
5919 (set_window_width, change_window_heights, window_height)
5920 (window_width, CURBEG, CURSIZE, enlarge_window)
5921 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5922 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5923 handled in window.el.
5924 (make_dummy_parent): Rename to make_parent_window and give it a
5925 second argument horflag.
5926 (make_window): Don't set resize_proportionally any more.
5927 (Fsplit_window): Remove. Windows are split in window.el.
5928 (save_restore_action, save_restore_orig_size)
5929 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5930 Resize mini windows in window.el.
5931 (grow_mini_window, shrink_mini_window): Implement by calling
5932 Qresize_root_window_vertically, resize_window_check and
5933 resize_window_apply.
5934 (saved_window, Fset_window_configuration, save_window_save):
5935 Do not handle orig_top_line, orig_total_lines, and
5936 resize_proportionally.
5937 (window_min_height, window_min_width): Move to window.el.
5938 (keys_of_window): Move bindings for delete-other-windows,
5939 split-window, delete-window and enlarge-window to window.el.
5941 * buffer.c: Temporarily extern Qdelete_window.
5942 (Fbury_buffer): Temporarily call Qdelete_window instead of
5943 Fdelete_window (Fbury_buffer will move to window.el soon).
5945 * frame.c (set_menu_bar_lines_1): Remove code handling
5946 orig_top_line and orig_total_lines.
5948 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5949 set_window_height but set heights directly.
5950 (change_frame_size_1): Use resize_frame_windows.
5952 * xdisp.c (init_xdisp): Don't use set_window_height but set
5955 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5956 Use resize_frame_windows instead of change_window_heights and run
5957 run_window_configuration_change_hook.
5959 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5960 instead of change_window_heights and run
5961 run_window_configuration_change_hook.
5963 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5965 * window.c (replace_window): Rename second argument REPLACEMENT to
5966 NEW. New third argument SETFLAG. Rewrite.
5967 (delete_window, make_dummy_parent): Call replace_window with
5969 (window_list_1): Move down in code.
5970 (run_window_configuration_change_hook): Move set_buffer part
5971 before select_frame_norecord part in order to unwind correctly.
5972 Rename count1 to count.
5973 (recombine_windows, delete_deletable_window, resize_root_window)
5974 (Fdelete_other_windows_internal)
5975 (Frun_window_configuration_change_hook, make_parent_window)
5976 (resize_window_check, resize_window_apply, Fresize_window_apply)
5977 (resize_frame_windows, Fsplit_window_internal)
5978 (Fdelete_window_internal, Fresize_mini_window_internal):
5980 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5982 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5984 * window.h (window): Add some new members to window structure -
5985 normal_lines, normal_cols, new_total, new_normal, clone_number,
5986 splits, nest, prev_buffers, next_buffers.
5987 (WINDOW_TOTAL_SIZE): Move here from window.c.
5988 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5990 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5992 (make_dummy_parent): Set new members of windows structure.
5993 (make_window): Move down in code. Handle new members of window
5995 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5996 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5997 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5998 (Fset_window_prev_buffers, Fwindow_next_buffers)
5999 (Fset_window_next_buffers, Fset_window_clone_number):
6001 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6002 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6004 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6005 Argument WINDOW can be now internal window too.
6006 (Fwindow_use_time): Move up in code.
6007 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6009 (Fset_window_configuration, saved_window)
6010 (Fcurrent_window_configuration, save_window_save): Handle new
6011 members of window structure.
6012 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6013 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6014 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6015 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6016 Qget_mru_window, Qresize_root_window,
6017 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6018 Qauto_buffer_name; staticpro them.
6020 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6022 * window.c (Fwindow_total_size, Fwindow_left_column)
6023 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6024 (Fwindow_list_1): New functions.
6025 (window_box_text_cols): Replace with window_body_cols.
6026 (Fwindow_width, Fscroll_left, Fscroll_right):
6027 Use window_body_cols instead of window_box_text_cols.
6028 (delete_window, Fset_window_configuration):
6029 Call delete_all_subwindows with window as argument.
6030 (delete_all_subwindows): Take a window as argument and not a
6032 (window_loop): Remove handling of GET_LRU_WINDOW and
6034 (Fget_lru_window, Fget_largest_window): Move to window.el.
6036 * window.h: Extern window_body_cols instead of
6037 window_box_text_cols. delete_all_subwindows now takes a
6038 Lisp_Object as argument.
6040 * indent.c (compute_motion, Fcompute_motion):
6041 Use window_body_cols instead of window_box_text_cols.
6043 * frame.c (delete_frame): Call delete_all_subwindows with root
6046 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6048 * fns.c (Fputhash): Document return value.
6050 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6052 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6054 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6056 Cons<->int and similar integer overflow fixes (Bug#8794).
6058 Check for overflow when converting integer to cons and back.
6059 * charset.c (Fdefine_charset_internal, Fdecode_char):
6060 Use cons_to_unsigned to catch overflow.
6061 (Fencode_char): Use INTEGER_TO_CONS.
6062 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6063 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6064 * data.c (long_to_cons, cons_to_long): Remove.
6065 (cons_to_unsigned, cons_to_signed): New functions.
6066 These signal an error for invalid or out-of-range values.
6067 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6068 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6069 * font.c (Ffont_variation_glyphs):
6070 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6071 * lisp.h: Include <intprops.h>.
6072 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6073 (cons_to_signed, cons_to_unsigned): New decls.
6074 (long_to_cons, cons_to_long): Remove decls.
6075 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6076 (Fprimitive_undo): Use CONS_TO_INTEGER.
6077 * xfns.c (Fx_window_property): Likewise.
6078 * xselect.c: Include <limits.h>.
6079 (x_own_selection, selection_data_to_lisp_data):
6080 Use INTEGER_TO_CONS.
6081 (x_handle_selection_request, x_handle_selection_clear)
6082 (x_get_foreign_selection, Fx_disown_selection_internal)
6083 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6084 (lisp_data_to_selection_data): Use cons_to_unsigned.
6085 (x_fill_property_data): Use cons_to_signed.
6086 Report values out of range.
6088 Check for buffer and string overflow more precisely.
6089 * buffer.h (BUF_BYTES_MAX): New macro.
6090 * lisp.h (STRING_BYTES_MAX): New macro.
6091 * alloc.c (Fmake_string):
6092 * character.c (string_escape_byte8):
6093 * coding.c (coding_alloc_by_realloc):
6094 * doprnt.c (doprnt):
6095 * editfns.c (Fformat):
6097 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6098 since they may not be the same number.
6099 * editfns.c (Finsert_char):
6100 * fileio.c (Finsert_file_contents):
6101 Likewise for BUF_BYTES_MAX.
6103 * image.c: Use ptrdiff_t, not int, for sizes.
6104 (slurp_file): Switch from int to ptrdiff_t.
6106 (slurp_file): Check that file size fits in both size_t (for
6107 malloc) and ptrdiff_t (for sanity and safety).
6109 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6110 if b->modtime has its maximal value.
6112 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6114 Don't assume time_t can fit into int.
6115 * buffer.h (struct buffer.modtime): Now time_t, not int.
6116 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6117 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6119 Minor fixes for signed vs unsigned integers.
6120 * character.h (MAYBE_UNIFY_CHAR):
6121 * charset.c (maybe_unify_char):
6122 * keyboard.c (read_char, reorder_modifiers):
6123 XINT -> XFASTINT, since the integer must be nonnegative.
6124 * ftfont.c (ftfont_spec_pattern):
6125 * keymap.c (access_keymap, silly_event_symbol_error):
6126 XUINT -> XFASTINT, since the integer must be nonnegative.
6127 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6128 since it makes no difference and we prefer signed.
6129 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6130 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6133 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6135 * window.h (Fwindow_frame): Declare.
6137 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6139 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6140 (SPARE_MEMORY): Always define.
6141 (LARGE_REQUEST): Remove.
6142 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6144 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6146 * lisp.h: Move EXFUNS for Fframe_root_window,
6147 Fframe_first_window and Fset_frame_selected_window to window.h.
6149 * window.h: Move EXFUNS for Fframe_root_window,
6150 Fframe_first_window and Fset_frame_selected_window here from
6153 * frame.c (Fwindow_frame, Fframe_first_window)
6154 (Fframe_root_window, Fframe_selected_window)
6155 (Fset_frame_selected_window): Move to window.c.
6156 (Factive_minibuffer_window): Move to minibuf.c.
6157 (Fother_visible_frames_p): New function.
6159 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6161 * window.c (decode_window, decode_any_window): Move up in code.
6162 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6163 (inhibit_frame_unsplittable): Remove unused variable.
6164 (Fwindow_buffer): Move up and rewrite doc-string.
6165 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6166 (Fwindow_prev): New functions.
6167 (Fwindow_frame): Move here from frame.c. Accept any window as
6169 (Fframe_root_window, Fframe_first_window)
6170 (Fframe_selected_window): Move here from frame.c. Accept frame
6171 or arbitrary window as argument. Update doc-strings.
6172 (Fminibuffer_window): Move up in code.
6173 (Fwindow_minibuffer_p): Move up in code and simplify.
6174 (Fset_frame_selected_window): Move here from frame.c.
6176 (Fselected_window, select_window, Fselect_window): Move up in
6177 code. Minor doc-string fixes.
6179 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6181 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6182 Do not assume that spare memory exists; that assumption is valid
6183 only if SYSTEM_MALLOC.
6184 (LARGE_REQUEST): New macro, so that the issue of large requests
6185 is separated from the issue of spare memory.
6187 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6189 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6192 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6194 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6197 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6199 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6201 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6203 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6204 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6206 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6208 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6210 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6212 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6213 (x_clipboard_manager_save): Add return value.
6214 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6216 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6217 Obey Vx_select_enable_clipboard_manager. Catch errors in
6218 x_clipboard_manager_save (Bug#8779).
6219 (Vx_select_enable_clipboard_manager): New variable.
6220 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6222 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6224 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6226 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6228 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6229 in the current matrix if keep_current_p is non-zero.
6231 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6233 * bidi.c (bidi_level_of_next_char): Fix last change.
6235 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6237 Support bidi reordering of text covered by display properties.
6239 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6240 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6241 (bidi_cache_search, bidi_cache_iterator_state)
6242 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6243 (bidi_level_of_next_char, bidi_move_to_visually_next):
6244 Support character positions inside a run of characters covered by a
6246 (bidi_paragraph_init, bidi_resolve_explicit_1)
6247 (bidi_level_of_next_char): Call bidi_fetch_char and
6248 bidi_fetch_char_advance instead of FETCH_CHAR and
6250 (bidi_init_it): Initialize new members.
6251 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6253 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6254 instead of using explicit *_CHAR codes.
6255 (bidi_resolve_explicit, bidi_resolve_weak):
6256 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6257 bidirectional text is supported only in multibyte buffers.
6258 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6259 it to initialize the frame_window_p member of struct bidi_it.
6260 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6261 (bidi_resolve_explicit, bidi_resolve_weak)
6262 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6263 bidi_it->nchars is non-positive.
6264 (bidi_level_of_next_char): Don't try to lookup the cache for the
6265 next/previous character if nothing is cached there yet, or if we
6266 were just reseat()'ed to a new position.
6268 * xdisp.c (set_cursor_from_row): Set start and stop points
6269 according to the row's direction when priming the loop that looks
6270 for the glyph on which to display cursor.
6271 (single_display_spec_intangible_p): Function deleted.
6272 (display_prop_intangible_p): Reimplement to call
6273 handle_display_spec instead of single_display_spec_intangible_p.
6274 Accept 3 additional arguments needed by handle_display_spec.
6275 This fixes incorrect cursor motion across display property with complex
6276 values: lists, `(when COND...)' forms, etc.
6277 (single_display_spec_string_p): Support property values that are
6278 lists with the argument STRING its top-level element.
6279 (display_prop_string_p): Fix the condition for processing a
6280 property that is a list to be consistent with handle_display_spec.
6281 (handle_display_spec): New function, refactored from the
6282 last portion of handle_display_prop.
6283 (compute_display_string_pos): Accept additional argument
6284 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6285 value of a `display' property is a "replacing spec".
6286 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6287 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6288 the display property, but just return a value indicating whether
6289 the display property will replace the characters it covers.
6290 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6291 frame_window_p members of struct bidi_it.
6292 (compute_display_string_pos, compute_display_string_end):
6294 (push_it): Accept second argument POSITION, where pop_it should
6295 jump to continue iteration.
6296 (reseat_1): Initialize bidi_it.disp_pos.
6298 * keyboard.c (adjust_point_for_property): Adjust the call to
6299 display_prop_intangible_p to its new signature.
6301 * dispextern.h (struct bidi_it): New member frame_window_p.
6302 (bidi_init_it): Update prototypes.
6303 (display_prop_intangible_p): Update prototype.
6304 (compute_display_string_pos, compute_display_string_end):
6306 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6309 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6311 Malloc failure behavior now depends on size of allocation.
6312 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6313 * lisp.h: Change signatures accordingly.
6314 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6315 All callers changed. (Bug#8762)
6317 * gnutls.c: Use Emacs's memory allocators.
6318 Without this change, the gnutls library would invoke malloc etc.
6319 directly, which causes problems on non-SYNC_INPUT hosts, and which
6320 runs afoul of improving memory_full behavior. (Bug#8761)
6321 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6322 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6323 xfree instead of the default malloc, realloc, free.
6324 (Fgnutls_boot): No need to check for memory allocation failure,
6325 since xmalloc does that for us.
6327 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6328 * category.c (hash_get_category_set):
6329 * ccl.c (ccl_driver):
6330 * charset.c (Fdefine_charset_internal):
6331 * charset.h (struct charset.hash_index):
6332 * composite.c (get_composition_id, gstring_lookup_cache)
6333 (composition_gstring_put_cache):
6334 * composite.h (struct composition.hash_index):
6335 * dispextern.h (struct image.hash):
6336 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6337 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6338 (hashfn_equal, hashfn_user_defined, make_hash_table)
6339 (maybe_resize_hash_table, hash_lookup, hash_put)
6340 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6341 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6342 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6343 * image.c (make_image, search_image_cache, lookup_image)
6344 (xpm_put_color_table_h):
6345 * lisp.h (struct Lisp_Hash_Table):
6346 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6347 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6348 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6349 * alloc.c (allocate_vectorlike):
6350 Check for overflow in vector size calculations.
6351 * ccl.c (ccl_driver):
6352 Check for overflow when converting EMACS_INT to int.
6353 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6354 need to be updated by these changes.
6355 * fns.c (make_hash_table, maybe_resize_hash_table):
6356 Check for integer overflow with large hash tables.
6357 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6358 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6359 (SXHASH_REDUCE): New macro.
6360 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6361 Use it instead of discarding useful hash info with large hash values.
6362 (sxhash_float): New function.
6363 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6364 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6365 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6366 Rewrite to use FIXNUM_BITS, as this simplifies things.
6367 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6368 Adjust signatures to match updated version of code.
6369 (consing_since_gc): Now EMACS_INT, since a single hash table can
6370 use more than INT_MAX bytes.
6372 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6374 Make it possible to build with GCC-4.6+ -O2 -flto.
6376 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6378 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6380 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6381 Call minibuffer-inactive-mode.
6383 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6385 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6386 Update dependencies.
6388 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6390 * data.c (init_data): Remove code for UTS, this system is not
6393 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6395 Don't force ./temacs to start in terminal mode.
6397 * frame.c (make_initial_frame): Initialize faces in all cases, not
6398 only when CANNOT_DUMP is defined.
6399 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6401 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6403 * dispnew.c (add_window_display_history): Use const for the string
6404 pointer. Remove declaration, not needed.
6406 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6408 Use 'inline', not 'INLINE'.
6409 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6410 * alloc.c, fontset.c (INLINE): Remove.
6411 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6412 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6413 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6414 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6415 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6417 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6419 Make it possible to run ./temacs.
6421 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6422 syms_of_callproc does the same thing. Remove test for
6423 "initialized", do it in the caller.
6424 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6426 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6428 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6429 (read_minibuf): Use get_minibuffer.
6430 (syms_of_minibuf): Use DEFSYM.
6431 (Qmetadata): New var.
6432 * data.c (Qbuffer): Don't make it static.
6433 (syms_of_data): Use DEFSYM.
6435 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6437 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6438 (CCL_CODE_MIN): New macro.
6440 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6442 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6444 * eval.c (Qdebug): Now static.
6445 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6446 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6447 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6449 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6451 * image.c: Various fixes to ImageMagick code comments.
6452 (Fimagemagick_types): Doc fix.
6454 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6456 Minor fixes prompted by GCC 4.6.0 warnings.
6458 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6460 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6461 (x_clipboard_manager_save_all): Move extern decl to ...
6462 * xterm.h: ... here, so that it can be checked for consistency.
6464 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6466 * xselect.c (x_clipboard_manager_save_frame)
6467 (x_clipboard_manager_save_all): New functions.
6468 (Fx_clipboard_manager_save): Lisp function deleted.
6470 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6471 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6473 * xterm.h: Update prototype.
6475 2011-05-28 William Xu <william.xwl@gmail.com>
6477 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6480 2011-05-28 Jim Meyering <meyering@redhat.com>
6482 Avoid a sign-extension bug in crypto_hash_function.
6483 * fns.c (to_uchar): Define.
6484 (crypto_hash_function): Use it to convert some newly-signed
6485 variables to unsigned, to avoid sign-extension bugs. For example,
6486 without this change, (md5 "truc") would evaluate to
6487 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6488 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6489 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6491 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6493 Integer overflow fixes.
6495 * dbusbind.c: Serial number integer overflow fixes.
6496 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6497 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6498 to hold a serial number that is too large for a fixnum.
6499 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6500 Check for serial numbers out of range. Decode any serial number
6501 that was so large that it became a float. (Bug#8722)
6503 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6504 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6505 Use XFASTINT rather than XUINT when numbers are nonnegative.
6506 (xd_append_arg, Fdbus_method_return_internal):
6507 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6508 arguments, check that Lisp number is nonnegative, rather than
6509 silently wrapping negative numbers around. (Bug#8722)
6510 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6513 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6515 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6517 ccl: Add integer overflow checks.
6518 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6519 (IN_INT_RANGE): New macros.
6520 (ccl_driver): Use them to check for integer overflow when
6521 decoding a CCL program. Many of the new checks are whether XINT (x)
6522 fits in int; it doesn't always, on 64-bit hosts. The new version
6523 doesn't catch all possible integer overflows, but it's an
6524 improvement. (Bug#8719)
6526 * alloc.c (make_event_array): Use XINT, not XUINT.
6527 There's no need for unsigned here.
6529 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6530 This follows up to the 2011-05-06 change that substituted uintptr_t
6531 for EMACS_INT. This case wasn't caught back then.
6533 Rework Fformat to avoid integer overflow issues.
6534 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6535 now (part of C89). Include <verify.h>.
6536 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6537 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6538 (Fformat): Avoid the prepass trying to compute sizes; it was only
6539 approximate and thus did not catch overflow reliably. Instead, walk
6540 through the format just once, formatting and computing sizes as we go,
6541 checking for integer overflow at every step, and allocating a larger
6542 buffer as needed. Keep track separately whether the format is
6543 multibyte. Keep only the most-recently calculated precision, rather
6544 than them all. Record whether each argument has been converted to
6545 string. Use EMACS_INT, not int, for byte and char and arg counts.
6546 Support field widths and precisions larger than INT_MAX. Avoid
6547 sprintf's undefined behavior with conversion specifications such as %#d
6548 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6549 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6550 formatting out-of-range floating point numbers with int
6553 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6555 * data.c: Avoid integer truncation in expressions involving floats.
6556 * data.c: Include <intprops.h>.
6557 (arith_driver): When there's an integer overflow in an expression
6558 involving floating point, convert the integers to floating point
6559 so that the resulting value does not suffer from catastrophic
6560 integer truncation. For example, on a 64-bit host (* 4
6561 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6562 Do not rely on undefined behavior after integer overflow.
6564 merge count_size_as_multibyte, parse_str_to_multibyte
6565 * character.c, character.h (count_size_as_multibyte):
6566 Rename from parse_str_to_multibyte; all uses changed.
6567 Check for integer overflow.
6568 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6569 since it's now a duplicate of the other. This is more of
6570 a character than a buffer op, so better that it's in character.c.
6571 * fns.c, print.c: Adjust to above changes.
6573 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6575 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6577 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6579 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6580 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6581 (x_clipboard_manager_save): Now static.
6582 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6584 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6585 (crypto_hash_function): Now static.
6586 Fix pointer signedness problems. Avoid unnecessary initializations.
6588 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6590 * termhooks.h (Vselection_alist): Make it terminal-local.
6592 * terminal.c (create_terminal): Initialize it.
6594 * xselect.c: Support for clipboard managers.
6595 (Vselection_alist): Move to termhooks.h as terminal-local var.
6596 (LOCAL_SELECTION): New macro.
6597 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6598 (symbol_to_x_atom): Remove gratuitous arg.
6599 (x_handle_selection_request, lisp_data_to_selection_data)
6600 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6601 (x_own_selection, x_get_local_selection, x_convert_selection):
6602 New arg, specifying work frame. Use terminal-local Vselection_alist.
6603 (some_frame_on_display): Delete unused function.
6604 (Fx_own_selection_internal, Fx_get_selection_internal)
6605 (Fx_disown_selection_internal, Fx_selection_owner_p)
6606 (Fx_selection_exists_p): New optional frame arg.
6607 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6608 (x_handle_selection_clear): Don't treat other terminals with the
6609 same keyboard specially. Use the terminal-local Vselection_alist.
6610 (x_clear_frame_selections): Use Frun_hook_with_args.
6612 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6614 * xterm.h: Add support for those atoms.
6616 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6618 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6619 (converted_selections, conversion_fail_tag): New global variables.
6620 (x_selection_request_lisp_error): Free the above.
6621 (x_get_local_selection): Remove unnecessary code.
6622 (x_reply_selection_request): Args changed; handle arbitrary array
6623 of converted selections stored in converted_selections.
6624 Separate the XChangeProperty and SelectionNotify steps.
6625 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6626 (x_convert_selection): New function.
6627 (x_handle_selection_event): Simplify.
6628 (x_get_foreign_selection): Don't ignore incoming requests while
6629 waiting for an answer; this will fail when we implement
6630 SAVE_TARGETS, and seems unnecessary anyway.
6631 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6632 (Vx_sent_selection_functions): Doc fix.
6634 2011-05-26 Leo Liu <sdl.web@gmail.com>
6636 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6638 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6640 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6642 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6643 for fringe update if it has periodic bitmap.
6644 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6645 and fringe_bitmap_periodic_p.
6647 * fringe.c (get_fringe_bitmap_data): New function.
6648 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6649 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6650 row. Mark glyph row for fringe update if periodicity changed.
6652 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6653 for fringe update unless it has periodic bitmap.
6655 2011-05-25 Kenichi Handa <handa@m17n.org>
6657 * xdisp.c (get_next_display_element): Set correct it->face_id for
6658 a static composition.
6660 2011-05-24 Leo Liu <sdl.web@gmail.com>
6663 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6665 * fns.c (crypto_hash_function, Fsha1): New function.
6666 (Fmd5): Use crypto_hash_function.
6667 (syms_of_fns): Add Ssha1.
6669 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6671 * gnutls.c: Remove unused macros.
6672 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6673 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6674 Remove macros that are defined and never used.
6675 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6677 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6679 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6680 (Fx_get_selection_internal): Minor cleanup.
6681 (Fx_own_selection_internal): Rename arguments for consistency with
6684 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6686 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6688 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6690 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6692 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6694 * dispnew.c (scrolling_window): Don't exclude the case that the
6695 last enabled row in the desired matrix touches the bottom boundary.
6697 2011-05-21 Glenn Morris <rgm@gnu.org>
6699 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6700 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6701 and add some more files.
6703 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6705 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6706 report_file_error introduced by the change from 2011-05-07.
6708 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6710 * systime.h (Time): Define only if emacs is defined.
6711 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6712 where the include path doesn't have X11/X.h by default. See
6713 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6715 2011-05-20 Kenichi Handa <handa@m17n.org>
6717 * composite.c (find_automatic_composition): Fix previous change.
6719 2011-05-20 Glenn Morris <rgm@gnu.org>
6721 * lisp.mk: New file, split from Makefile.in.
6722 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6723 (shortlisp): Remove.
6724 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6726 2011-05-19 Glenn Morris <rgm@gnu.org>
6728 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6729 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6730 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6731 (lisp): Set the order to that of loadup.el.
6732 (shortlisp): Make it a copy of $lisp.
6733 (SOME_MACHINE_LISP): Remove.
6734 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6735 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6737 2011-05-18 Kenichi Handa <handa@m17n.org>
6739 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6740 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6741 (find_automatic_composition): Mostly rewrite for efficiency.
6743 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6745 * makefile.w32-in: Update dependencies.
6747 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6749 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6750 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6752 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6754 Fix some integer overflow issues, such as string length overflow.
6756 * insdel.c (count_size_as_multibyte): Check for string overflow.
6758 * character.c (lisp_string_width): Check for string overflow.
6759 Use EMACS_INT, not int, for string indexes and lengths; in
6760 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6761 the resulting string length overflows an EMACS_INT; instead,
6762 report a string overflow if no precision given. When checking for
6763 precision exhaustion, use a check that cannot possibly have
6764 integer overflow. (Bug#8675)
6765 * character.h (lisp_string_width): Adjust to new signature.
6767 * alloc.c (string_overflow): New function.
6768 (Fmake_string): Use it. This doesn't change behavior, but saves
6769 a few bytes and will simplify future changes.
6770 * character.c (string_escape_byte8): Likewise.
6771 * lisp.h (string_overflow): New decl.
6773 Fixups, following up to the user-interface timestamp change.
6774 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6775 for UI timestamps, instead of unsigned long.
6776 * msdos.c (mouse_get_pos): Likewise.
6777 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6778 * w32gui.h (Time): Define by including "systime.h" rather than by
6779 declaring it ourselves. (Bug#8664)
6781 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6782 * image.c (clear_image_cache): Likewise.
6784 * term.c (term_mouse_position): Don't assume time_t wraparound.
6786 Be more systematic about user-interface timestamps.
6787 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6788 and sometimes 'EMACS_UINT', to represent these timestamps.
6789 This change causes it to use 'Time' uniformly, as that's what X uses.
6790 This makes the code easier to follow, and makes it easier to catch
6791 integer overflow bugs such as Bug#8664.
6792 * frame.c (Fmouse_position, Fmouse_pixel_position):
6793 Use Time, not unsigned long, for user-interface timestamps.
6794 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6795 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6796 * keyboard.h (last_event_timestamp): Likewise.
6797 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6798 * menu.h (xmenu_show): Likewise.
6799 * term.c (term_mouse_position): Likewise.
6800 * termhooks.h (struct input_event.timestamp): Likewise.
6801 (struct terminal.mouse_position_hook): Likewise.
6802 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6803 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6804 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6805 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6807 * menu.h, termhooks.h: Include "systime.h", for Time.
6809 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6810 Don't assume that the difference between two unsigned long values
6811 can fit into an integer. At this point, we know button_down_time
6812 <= event->timestamp, so the difference must be nonnegative, so
6813 there's no need to cast the result if double-click-time is
6814 nonnegative, as it should be; check that it's nonnegative, just in
6815 case. This bug is triggered when events are more than 2**31 ms
6816 apart (about 25 days). (Bug#8664)
6818 * xselect.c (last_event_timestamp): Remove duplicate decl.
6819 (x_own_selection): Remove needless cast to unsigned long.
6821 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6822 that always fit in int. Use a sentinel instead of a counter, to
6823 avoid a temp and to allay GCC's concerns about possible int overflow.
6824 * frame.h (struct frame): Use int for menu_bar_items_used
6825 instead of EMACS_INT, since it always fits in int.
6827 * menu.c (grow_menu_items): Check for int overflow.
6829 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6831 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6832 Before, the code was not consistent. These values cannot exceed
6833 2**31 - 1 so there's no need to make them unsigned.
6834 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6835 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6836 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6838 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6840 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6841 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6842 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6843 presumably because the widths might not match.
6845 * window.c (size_window): Avoid needless test at loop start.
6847 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6849 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6851 2011-05-12 Drew Adams <drew.adams@oracle.com>
6853 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6855 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6857 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6858 `width' to `bar_area_x' and `bar_area_width', respectively.
6859 (x_scroll_run): Take account of fringe background extension.
6861 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6862 Rename local vars `left' and `width' to `bar_area_x' and
6863 `bar_area_width', respectively.
6864 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6865 background extension.
6867 2011-05-10 Jim Meyering <meyering@redhat.com>
6869 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6871 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6873 * image.c (Finit_image_library): Return t for built-in image types,
6874 like pbm and xbm. (Bug#8640)
6876 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6878 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6880 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6882 * w32console.c (Fset_screen_color): Doc fix.
6883 (Fget_screen_color): New function.
6884 (syms_of_ntterm): Defsubr it.
6886 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6887 unlink the temporary file if Fcall_process didn't create it in the
6889 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6890 child process will be redirected to a file specified with `:file'.
6891 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6892 cue to call_process_cleanup not to close that handle.
6894 2011-05-07 Ben Key <bkey76@gmail.com>
6896 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6897 one of two shell specific rules, either bootstrap-temacs-CMD or
6898 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6899 to the previous implementation of the bootstrap-temacs rule.
6900 The bootstrap-temacs-CMD rule is similar to the previous
6901 implementation of the bootstrap-temacs rule except that it
6902 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6905 These changes, along with some changes to nt/configure.bat,
6906 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6907 earlier fix to add support for --cflags and --ldflags options
6908 that include quotes so that it works whether make uses cmd or
6911 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6913 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6914 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6916 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6917 a string. Handle both cases.
6918 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6919 (Fdbus_register_method): Use Qinvalid_function.
6921 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6923 * makefile.w32-in: Update dependencies.
6924 (LISP_H): Add inttypes.h and stdin.h.
6925 (PROCESS_H): Add unistd.h.
6927 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6929 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6930 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6932 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6934 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6936 * term.c (vfatal): Remove stray call to va_end.
6937 It's not needed and the C Standard doesn't allow it here anyway.
6939 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6940 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6942 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6945 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6947 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6949 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6951 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6953 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6955 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6956 * charset.c (Fdefine_charset_internal): Don't initialize
6957 charset.code_space[15]. The value was garbage, on hosts with
6958 32-bit int (Bug#8600).
6960 * lread.c (read_integer): Be more consistent with string-to-number.
6961 Use string_to_number to do the actual conversion; this avoids
6962 rounding errors and fixes some other screwups. Without this fix,
6963 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6964 (digit_to_number): Move earlier, for benefit of read_integer.
6965 Return -1 if the digit is out of range for the base, -2 if it is
6966 not a digit in any supported base. (Bug#8602)
6968 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6970 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6971 to match comment at start of function. This also removes a
6972 GCC warning about overflow in a 32+64-bit port.
6974 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6976 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6977 Reported by Stefan Monnier in
6978 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6979 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6980 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6982 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6983 (EMACS_UINTPTR): Likewise, with uintptr_t.
6985 * lisp.h: Prefer 64-bit EMACS_INT if available.
6986 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6987 on 32-bit hosts that have 64-bit int, so that they can access
6989 However, temporarily disable this change unless the temporary
6990 symbol WIDE_EMACS_INT is defined.
6992 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6994 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6995 This removes an assumption that EMACS_INT and long are the same
6996 width as pointers. The assumption is true for Emacs porting targets
6997 now, but we want to make other targets possible.
6998 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6999 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7000 In the rest of the code, change types of integers that hold casted
7001 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7002 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7003 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7004 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7005 No need to cast type when ORing.
7006 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7007 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7008 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7009 assume EMACS_INT is the same width as char *.
7010 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7011 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7012 Remove no-longer-needed casts.
7013 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7014 (xg_tool_bar_help_callback, xg_make_tool_item):
7015 Use EMACS_INTPTR to hold an integer
7016 that will be cast to void *; this can avoid a GCC warning
7017 if EMACS_INT is not the same width as void *.
7018 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7019 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7020 (current_message_1, set_message_1):
7021 Use a local to convert to proper width without a cast.
7022 * xmenu.c (dialog_selection_callback): Likewise.
7024 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7025 Also, don't assume VALBITS / RAND_BITS is less than 5,
7026 and don't rely on undefined behavior when shifting a 1 left into
7028 * lisp.h (get_random): Change signature to match.
7030 * lread.c (hash_string): Use size_t, not int, for hash computation.
7031 Normally we prefer signed values; but hashing is special, because
7032 it's better to use unsigned division on hash table sizes so that
7033 the remainder is nonnegative. Also, size_t is the natural width
7034 for hashing into memory. The previous code used 'int', which doesn't
7035 retain enough info to hash well into very large tables.
7036 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7038 * dbusbind.c: Don't possibly lose pointer info when converting.
7039 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7040 Use XPNTR rather than XHASH, so that the high-order bits of
7041 the pointer aren't lost when converting through void *.
7043 * eval.c (Fautoload): Don't double-shift a pointer.
7045 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7047 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7049 * gnutls.c (DEF_GNUTLS_FN):
7050 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7052 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7054 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7057 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7059 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7060 New version that can reserve upto 2GB of heap space.
7062 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7064 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7066 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7068 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7069 `gnutls_certificate_set_x509_key_file'.
7071 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7073 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7074 Update dependencies.
7076 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7078 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7079 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7080 Remove unused parameter `fildes'.
7081 * process.c (read_process_output, send_process): Don't pass it.
7083 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7085 Fix previous change: the library cache is defined in w32.c.
7086 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7087 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7089 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7091 Implement dynamic loading of GnuTLS on Windows.
7093 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7094 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7095 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7098 * gnutls.c (Qgnutls_dll): Define.
7099 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7100 (gnutls_*): Declare function pointers.
7101 (init_gnutls_functions): New function to initialize function pointers.
7102 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7103 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7104 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7105 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7106 (emacs_gnutls_write, emacs_gnutls_read)
7107 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7108 (Fgnutls_available_p): New function.
7109 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7110 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7111 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7113 * image.c: Include w32.h.
7114 (Vimage_type_cache): Delete.
7115 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7116 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7117 (w32_delayed_load): Move to w32.c.
7119 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7121 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7122 (w32_delayed_load): Move from image.c. When loading a library, record
7123 its filename in the :loaded-from property of the library id.
7124 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7125 Initialize and staticpro them.
7126 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7128 * process.c: Include lisp.h before w32.h, not after.
7129 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7130 instead of gnutls_record_check_pending.
7132 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7134 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7136 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7137 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7140 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7142 * xterm.c (x_set_frame_alpha): Do not set property on anything
7143 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7145 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7147 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7149 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7151 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7152 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7153 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7154 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7155 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7156 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7157 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7158 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7159 (Qgnutls_bootprop_callbacks_verify): Make static.
7161 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7163 * callproc.c: Indentation fixup.
7165 * sysdep.c (wait_for_termination_1): Make static.
7166 (wait_for_termination, interruptible_wait_for_termination):
7167 Move after wait_for_termination_1.
7169 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7171 * sysdep.c (interruptible_wait_for_termination): New function
7172 which is like wait_for_termination, but allows keyboard
7175 * callproc.c (Fcall_process): Add (:file "file") as an option for
7177 (Fcall_process_region): Ditto.
7179 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7181 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7182 rather than `XVECTOR (FOO)->size'.
7184 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7185 inttypes.h, as a gnulib replacement is used if it not available in
7188 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7190 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7191 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7192 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7194 * coding.c (coding_alloc_by_realloc): Error out if destination
7195 will grow beyond MOST_POSITIVE_FIXNUM.
7196 (decode_coding_emacs_mule): Abort if there isn't enough place in
7197 charbuf for the composition carryover bytes. Reserve an extra
7198 space for up to 2 characters produced in a loop.
7199 (decode_coding_iso_2022): Abort if there isn't enough place in
7200 charbuf for the composition carryover bytes.
7202 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7204 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7205 aborting when %lld or %lll format is passed.
7206 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7207 %llo or %llx format is passed. (Bug#8545)
7209 * window.c (window_scroll_line_based): Use a marker instead of
7210 simple variables to record original value of point. (Bug#7952)
7212 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7213 produced by %s or %c overflows available buffer space. (Bug#8545)
7215 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7217 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7218 (SIZE_MAX): Move defn after all includes, as they might #define it.
7220 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7222 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7224 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7226 * keyboard.c (Qdelayed_warnings_hook): Define.
7227 (command_loop_1): Run `delayed-warnings-hook'
7228 if Vdelayed_warnings_list is non-nil.
7229 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7230 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7232 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7234 * doprnt.c (doprnt): Don't return value smaller than the buffer
7235 size if the message was truncated. (Bug#8545).
7237 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7239 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7240 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7242 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7244 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7246 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7248 * makefile.w32-in: Update dependencies.
7250 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7252 Improve `doprnt' and its usage. (Bug#8545)
7253 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7254 `format_end'. Remove support for %l as a conversion specifier.
7255 Don't use xrealloc. Improve diagnostics when the %l size modifier
7256 is used. Update the commentary.
7258 * eval.c (verror): Simplify calculation of size_t.
7260 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7263 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7265 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7268 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7270 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7271 This makes this file independent of the recent pseudovector change.
7273 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7275 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7277 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7278 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7279 Remove unused local.
7280 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7282 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7283 GCC 4.6.0 optimizes based on type-based alias analysis.
7284 For example, if b is of type struct buffer * and v of type struct
7285 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7286 != &v->size, and therefore "v->size = 1; b->size = 2; return
7287 v->size;" must therefore return 1. This assumption is incorrect
7288 for Emacs, since it type-puns struct Lisp_Vector * with many other
7289 types. To fix this problem, this patch adds a new type struct
7290 vectorlike_header that documents the constraints on layout of vectors
7291 and pseudovectors, and helps optimizing compilers not get fooled
7292 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7293 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7294 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7296 (XSETPVECTYPE): Rewrite in terms of new macro.
7297 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7298 This is a bit clearer, and further avoids the possibility of
7299 undesirable aliasing.
7300 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7301 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7302 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7303 since Lisp_Subr is a special case (no "next" field).
7304 (ASIZE): Now uses header.size rather than size.
7305 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7306 to avoid the hassle of writing XVECTOR (foo)->header.size.
7307 (struct vectorlike_header): New type.
7308 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7309 object, to help avoid aliasing.
7310 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7311 (SUBRP): Likewise, since Lisp_Subr is a special case.
7312 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7313 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7314 (struct Lisp_Hash_Table): Combine first two members into a single
7315 struct vectorlike_header member. All uses of "size" and "next" members
7316 changed to be "header.size" and "header.next".
7317 * buffer.h (struct buffer): Likewise.
7318 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7319 * frame.h (struct frame): Likewise.
7320 * process.h (struct Lisp_Process): Likewise.
7321 * termhooks.h (struct terminal): Likewise.
7322 * window.c (struct save_window_data, struct saved_window): Likewise.
7323 * window.h (struct window): Likewise.
7324 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7325 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7326 * buffer.c (init_buffer_once): Likewise.
7327 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7329 * process.c (Fformat_network_address): Use local var for size,
7332 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7334 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7335 * data.c (atof): Remove decl; no longer used or needed.
7336 (digit_to_number): Move to lread.c.
7337 (Fstring_to_number): Use new string_to_number function, to be
7338 consistent with how the Lisp reader treats infinities and NaNs.
7339 Do not assume that floating-point numbers represent EMACS_INT
7340 without losing information; this is not true on most 64-bit hosts.
7341 Avoid double-rounding errors, by insisting on integers when
7342 parsing non-base-10 numbers, as the documentation specifies.
7343 * lisp.h (string_to_number): New decl, replacing ...
7344 (isfloat_string): Remove.
7345 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7346 (read1): Do not accept +. and -. as integers; this
7347 appears to have been a coding error. Similarly, do not accept
7348 strings like +-1e0 as floating point numbers. Do not report
7349 overflow for integer overflows unless the base is not 10 which
7350 means we have no simple and reliable way to continue.
7351 Break out the floating-point parsing into a new
7352 function string_to_number, so that Fstring_to_number parses
7353 floating point numbers consistently with the Lisp reader.
7354 (digit_to_number): Move here from data.c. Make it static inline.
7355 (E_CHAR, EXP_INT): Remove, replacing with ...
7356 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7357 (string_to_number): New function, replacing isfloat_string.
7358 This function checks for valid syntax and produces the resulting
7359 Lisp float number too. Rework it so that string-to-number
7360 no longer mishandles examples like "1.0e+". Use strtoumax,
7361 so that overflow for non-base-10 numbers is reported only when
7362 there's no portable and simple way to convert to floating point.
7364 * textprop.c (set_text_properties_1): Rewrite for clarity,
7365 and to avoid GCC warning about integer overflow.
7367 * intervals.h (struct interval): Use EMACS_INT for members
7368 where EMACS_UINT might cause problems. See
7369 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7370 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7371 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7373 (offset_intervals): Tell GCC not to worry about length overflow
7374 when negating a negative length.
7376 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7377 (overrun_check_free): Likewise.
7379 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7380 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7383 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7384 (gnutls_make_error): Rename local to avoid shadowing.
7385 (gnutls_emacs_global_deinit): ifdef out; not used.
7386 (Fgnutls_boot): Use const for pointer to readonly storage.
7387 Comment out unused local. Fix pointer signedness problems.
7389 * lread.c (openp): Don't stuff size_t into an 'int'.
7390 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7391 about possible signed overflow.
7393 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7394 (GDK_KEY_g): Don't define if already defined.
7395 (xg_prepare_tooltip): Avoid pointer signedness problem.
7396 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7398 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7399 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7401 * xfns.c (Fx_window_property): Simplify a bit,
7402 to make a bit faster and to avoid GCC 4.6.0 warning.
7403 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7405 * fns.c (internal_equal): Don't assume size_t fits in int.
7407 * alloc.c (compact_small_strings): Tighten assertion a little.
7409 Replace pEd with more-general pI, and fix some printf arg casts.
7410 * lisp.h (pI): New macro, generalizing old pEd macro to other
7411 conversion specifiers. For example, use "...%"pI"d..." rather
7412 than "...%"pEd"...".
7413 (pEd): Remove. All uses replaced with similar uses of pI.
7414 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7415 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7416 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7417 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7418 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7419 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7420 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7422 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7423 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7424 * print.c (safe_debug_print, print_object): Likewise.
7425 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7427 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7428 avoiding the 0 flag, which is not portable.
7429 * process.c (Fmake_network_process): Use pI to avoid cast.
7430 * region-cache.c (pp_cache): Likewise.
7431 * xdisp.c (decode_mode_spec): Likewise.
7432 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7433 behavior on 64-bit hosts with printf arg.
7434 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7435 (x_stop_queuing_selection_requests): Likewise.
7436 (x_get_window_property): Don't truncate byte count to an 'int'
7439 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7440 here, since it parses constructs like leading '-' and spaces,
7441 which are not wanted; and it overflows with large numbers.
7442 Instead, simply match F[0-9]+, which is what is wanted anyway.
7444 * alloc.c: Remove unportable assumptions about struct layout.
7445 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7446 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7447 (allocate_vectorlike, make_pure_vector): Use the new macros,
7448 plus offsetof, to remove unportable assumptions about struct layout.
7449 These assumptions hold on all porting targets that I know of, but
7450 they are not guaranteed, they're easy to remove, and removing them
7451 makes further changes easier.
7453 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7454 This doesn't fix a bug but makes the code clearer.
7455 (string_overrun_cookie): Now const. Use initializers that
7456 don't formally overflow signed char, to avoid warnings.
7457 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7458 can cause Emacs to crash when string overrun checking is enabled.
7459 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7460 multiple of sizeof (EMACS_INT); it need not be, if
7461 alignof(EMACS_INT) < sizeof (EMACS_INT).
7462 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7464 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7466 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7468 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7470 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7471 supposed to be handshaking. (Bug#8556)
7472 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7474 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7476 * lisp.h (Qdebug): List symbol.
7477 * eval.c (Qdebug): Restore global linkage.
7478 * keyboard.c (debug-on-event): New variable.
7479 (handle_user_signal): Break into debugger when debug-on-event
7480 matches the current signal symbol.
7482 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7484 * alloc.c (check_sblock, check_string_bytes)
7485 (check_string_free_list): Convert to standard C.
7487 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7489 * w32.c (emacs_gnutls_push): Fix typo.
7491 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7493 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7494 "cast to pointer from integer of different size".
7496 Improve doprnt and its use in verror. (Bug#8545)
7497 * doprnt.c (doprnt): Document the set of format control sequences
7498 supported by the function. Use SAFE_ALLOCA instead of always
7501 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7502 is one byte too soon. Don't use xrealloc; instead xfree and
7505 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7507 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7510 * gnutls.c: Renamed global_initialized to
7511 gnutls_global_initialized. Added internals for the
7512 :verify-hostname-error, :verify-error, and :verify-flags
7513 parameters of `gnutls-boot' and documented those parameters in the
7514 docstring. Start callback support.
7515 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7516 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7517 on error. Return error code.
7518 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7519 (emacs_gnutls_read): Likewise.
7520 (Fgnutls_boot): Return handshake error code.
7521 (emacs_gnutls_handle_error): New function.
7522 (wsaerror_to_errno): Likewise.
7524 * w32.h (emacs_gnutls_pull): Add prototype.
7525 (emacs_gnutls_push): Likewise.
7527 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7528 (emacs_gnutls_push): Likewise.
7530 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7532 * process.c (wait_reading_process_output): Check if GnuTLS
7533 buffered some data internally if no FDs are set for TLS
7536 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7537 (LIBS): Link to USER_LIBS.
7538 ($(BLD)/gnutls.$(0)): New target.
7540 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7542 * xdisp.c (handle_single_display_spec): Rename the
7543 display_replaced_before_p argument into display_replaced_p, to
7544 make it consistent with the commentary. Fix typos in the
7547 * textprop.c (syms_of_textprop): Remove dead code.
7548 (copy_text_properties): Delete obsolete commentary about an
7549 interface that was deleted long ago. Fix typos in the description
7552 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7553 to changes in oldXMenu/XMenu.h from 2011-04-16.
7554 <menu_help_message, prev_menu_help_message>: Constify.
7555 (IT_menu_make_room): menu->help_text is now `const char **';
7558 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7559 to changes in oldXMenu/XMenu.h from 2011-04-16.
7560 (struct XMenu): Declare `help_text' `const char **'.
7562 * xfaces.c <Qunspecified>: Make extern again.
7564 * syntax.c: Include sys/types.h before including regex.h, as
7567 * doc.c (get_doc_string): Improve the format passed to `error'.
7569 * doprnt.c (doprnt): Improve commentary.
7571 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7573 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7576 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7577 changes in globals.h immediately force recompilation.
7578 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7579 $(CURDIR)/s/ms-w32.h.
7580 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7582 * character.c (Fchar_direction): Function deleted.
7583 (syms_of_character): Don't defsubr it.
7584 <char-direction-table>: Deleted.
7586 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7588 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7589 * doprnt.c: Include limits.h.
7590 (SIZE_MAX): New macro.
7591 (doprnt): Return a size_t value. 2nd arg is now size_t.
7592 Many local variables are now size_t instead of int or unsigned.
7593 Improve overflow protection. Support `l' modifier for integer
7594 conversions. Support %l conversion. Don't assume an EMACS_INT
7595 argument for integer conversions and for %c.
7597 * lisp.h (doprnt): Restore prototype.
7599 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7602 * Makefile.in (base_obj): Add back doprnt.o.
7604 * deps.mk (doprnt.o): Add back prerequisites.
7605 (callint.o): Depend on character.h.
7607 * eval.c (internal_lisp_condition_case): Include the handler
7608 representation in the error message.
7609 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7610 when breaking from the loop.
7612 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7614 * callint.c (Fcall_interactively): When displaying error message
7615 about invalid control letter, pass the character's codepoint, not
7616 a pointer to its multibyte form. Improve display of the character
7617 in octal and display also its hex code.
7619 * character.c (char_string): Use %x to display the (unsigned)
7620 codepoint of an invalid character, to avoid displaying a bogus
7623 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7624 `error', not SYMBOL_NAME itself.
7626 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7627 character arguments to `error'.
7629 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7630 to `error' in error message about FINAL_CHAR argument. Make sure
7631 FINAL_CHAR is a character, and use %c when it is passed as
7632 argument to `error'.
7634 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7636 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7638 * w32.c: Include <time.h>.
7639 (sys_localtime): New function.
7641 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7643 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7645 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7647 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7649 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7652 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7654 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7655 gl_state.e_property when gl_state.object is Qt.
7657 * insdel.c (make_gap_larger): Remove limitation of buffer size
7660 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7662 * xdisp.c (lookup_glyphless_char_display)
7663 (produce_glyphless_glyph): Handle cons cell entry in
7664 glyphless-char-display.
7665 (Vglyphless_char_display): Document it.
7667 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7668 glyphless-char-display.
7670 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7672 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7674 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7676 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7677 definition for no-X builds.
7679 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7681 Static checks with GCC 4.6.0 and non-default toolkits.
7683 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7685 * process.c (keyboard_bit_set): Define only if SIGIO.
7686 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7687 (send_process): Repair possible setjmp clobbering.
7689 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7691 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7693 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7695 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7696 Define only if needed.
7698 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7699 by pacifying GCC about it. Maybe it's time to retire it?
7700 * xfaces.c (USG, __TIMEVAL__): Likewise.
7702 * dispextern.h (struct redisplay_interface): Rename param
7704 * termhooks.h (struct terminal): Likewise.
7705 * xterm.c (xembed_send_message): Likewise.
7707 * insdel.c (make_gap_smaller): Define only if
7708 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7710 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7713 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7714 so that we aren't warned about unused symbols.
7716 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7718 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7720 * xfns.c (x_real_positions): Mark locals as initialized.
7722 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7724 * xterm.c: Fix problems found by static analysis with other toolkits.
7725 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7726 (x_dispatch_event): Declare static if USE_GTK, and
7727 define if USE_GTK || USE_X_TOOLKIT.
7728 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7729 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7730 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7731 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7733 * xmenu.c (menu_help_callback): Pointer type fixes.
7734 Use const pointers when pointing at readonly data. Avoid pointer
7736 (FALSE): Remove unused macro.
7737 (update_frame_menubar): Remove unused decl.
7739 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7741 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7742 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7743 (single_menu_item): Rename local to avoid shadowing.
7745 * keyboard.c (make_lispy_event): Remove unused local var.
7747 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7748 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7750 * bitmaps: Change bitmaps from unsigned char back to the X11
7751 compatible char. Avoid the old compiler warnings about
7752 out-of-range initializers by using, for example, '\xab' rather
7755 * xgselect.c (xgselect_initialize): Check vs interface
7756 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7758 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7760 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7761 to read-only memory.
7763 * fns.c (vector): Remove; this old hack is no longer needed.
7765 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7767 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7769 * xrdb.c (x_load_resources): Omit unused local.
7771 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7772 (x_window): Rename locals to avoid shadowing.
7773 (USG): Use the kludged USG macro, to pacify gcc.
7775 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7776 (x_term_init): Remove local to avoid shadowing.
7778 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7780 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7781 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7783 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7785 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7787 Fix regex.c, syntax.c and friends for buffers > 2GB.
7788 * syntax.h (struct gl_state_s): Declare character position members
7791 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7793 * textprop.c (verify_interval_modification, interval_of):
7794 Declare arguments EMACS_INT.
7796 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7799 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7801 * indent.c (Fvertical_motion): Local variable it_start is now
7804 * regex.c (re_match, re_match_2, re_match_2_internal)
7805 (bcmp_translate, regcomp, regexec, print_double_string)
7806 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7807 (re_compile_pattern, re_exec): Declare arguments and local
7808 variables `size_t' and `ssize_t' and return values `regoff_t', as
7810 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7811 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7812 <compile_stack_type>: `size' and `avail' are now `size_t'.
7814 * regex.h <regoff_t>: Use ssize_t, not int.
7815 (re_search, re_search_2, re_match, re_match_2): Arguments that
7816 specify buffer/string position and length are now ssize_t and
7817 size_t. Return type is regoff_t.
7819 2011-04-16 Ben Key <bkey76@gmail.com>
7821 * nsfont.m: Fixed bugs in ns_get_family and
7822 ns_descriptor_to_entity that were caused by using free to
7823 deallocate memory blocks that were allocated by xmalloc (via
7824 xstrdup). This caused Emacs to crash when compiled with
7825 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7826 --enable-checking=xmallocoverrun). xfree is now used to
7827 deallocate these memory blocks.
7829 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7831 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7833 emacs_write: Accept and return EMACS_INT for sizes.
7834 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7836 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7837 Accept and return EMACS_INT.
7838 (emacs_gnutls_write): Return the number of bytes written on
7840 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7841 (emacs_read, emacs_write): Remove check for negative size, as the
7842 Emacs source code has been audited now.
7843 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7844 (emacs_read, emacs_write): Use it.
7845 * process.c (send_process): Adjust to the new signatures of
7846 emacs_write and emacs_gnutls_write. Do not attempt to store
7847 a byte offset into an 'int'; it might overflow.
7848 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7850 * sound.c: Don't assume sizes fit in 'int'.
7851 (struct sound_device.period_size, alsa_period_size):
7852 Return EMACS_INT, not int.
7853 (struct sound_device.write, vox_write, alsa_write):
7854 Accept EMACS_INT, not int.
7855 (wav_play, au_play): Use EMACS_INT to store sizes and to
7856 record read return values.
7858 2011-04-15 Ben Key <bkey76@gmail.com>
7860 * keyboard.c (Qundefined): Don't declare static since it is used
7862 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7863 static since they are used in nsfont.m.
7865 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7867 * process.c (Qprocessp): Don't declare static.
7868 * lisp.h (Qprocessp): Declare again.
7870 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7872 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7874 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7876 Improve C-level modularity by making more things 'static'.
7878 Don't publish debugger-only interfaces to other modules.
7879 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7880 (verify_bytepos, count_markers): Move decls to the only modules
7882 * region-cache.h (pp_cache): Likewise.
7883 * window.h (check_all_windows): Likewise.
7884 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7886 * sysdep.c (croak): Now static, if
7887 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7888 * syssignal.h (croak): Declare only if not static.
7890 * alloc.c (refill_memory_reserve): Now static if
7891 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7892 * lisp.h (refill_memory_reserve): Declare only if not static.
7894 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7895 Define only if USE_LUCID.
7897 * xrdb.c (x_customization_string, x_rm_string): Now static.
7899 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7900 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7902 * xdisp.c (draw_row_with_mouse_face): Now static.
7903 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7905 * window.h (check_all_windows): Mark externally visible.
7907 * window.c (window_deletion_count): Now static.
7909 * undo.c: Make symbols static if they're not exported.
7910 (last_undo_buffer, last_boundary_position, pending_boundary):
7913 * textprop.c (interval_insert_behind_hooks): Now static.
7914 (interval_insert_in_front_hooks): Likewise.
7916 * term.c: Make symbols static if they're not exported.
7917 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7918 (max_frame_lines, tty_set_terminal_modes):
7919 (tty_reset_terminal_modes, tty_turn_off_highlight):
7920 (get_tty_terminal): Now static.
7921 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7922 * termhooks.h (term_mouse_moveto): Do not declare if
7924 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7925 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7927 * sysdep.c: Make symbols static if they're not exported.
7928 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7930 (sigprocmask_set, full_mask): Remove; unused.
7931 (wait_debugging): Mark as visible.
7932 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7933 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7935 * syntax.c (syntax_temp): Define only if !__GNUC__.
7937 * sound.c (current_sound_device, current_sound): Now static.
7939 * search.c (searchbufs, searchbuf_head): Now static.
7941 * scroll.c (scroll_cost): Remove; unused.
7942 * dispextern.h (scroll_cost): Remove decl.
7944 * region-cache.h (pp_cache): Mark as externally visible.
7946 * process.c: Make symbols static if they're not exported.
7947 (process_tick, update_tick, create_process, chan_process):
7948 (Vprocess_alist, proc_buffered_char, datagram_access):
7949 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7950 (deactivate_process): Mark defn as static, as well as decl.
7951 * lisp.h (create_process): Remove decl.
7952 * process.h (chan_process, Vprocess_alist): Remove decls.
7954 * print.c: Make symbols static if they're not exported.
7955 (print_depth, new_backquote_output, being_printed, print_buffer):
7956 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7957 (print_interval, print_number_index, initial_stderr_stream):
7959 * lisp.h (Fprinc): Remove decl.
7960 (debug_output_compilation_hack): Mark as externally visible.
7962 * sysdep.c (croak): Move decl from here to syssignal.h.
7963 * syssignal.h (croak): Put it here, so the API can be checked when
7964 'croak' is called from dissociate_if_controlling_tty.
7966 * minibuf.c: Make symbols static if they're not exported.
7967 (minibuf_save_list, choose_minibuf_frame): Now static.
7968 * lisp.h (choose_minibuf_frame): Remove decl.
7970 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7972 * lread.c: Make symbols static if they're not exported.
7973 (read_objects, initial_obarray, oblookup_last_bucket_number):
7975 (make_symbol): Remove; unused.
7976 * lisp.h (initial_obarray, make_symbol): Remove decls.
7978 * keyboard.c: Make symbols static if they're not exported.
7979 (single_kboard, recent_keys_index, total_keys, recent_keys):
7980 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7981 (this_single_command_key_start, echoing, last_auto_save):
7982 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7983 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7984 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7985 (Vlispy_mouse_stem, double_click_count):
7987 (force_auto_save_soon): Define only if SIGDANGER.
7988 (ignore_mouse_drag_p): Now static if
7989 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7990 (print_help): Remove; unused.
7991 (stop_character, last_timer_event): Mark as externally visible.
7992 * keyboard.h (ignore_mouse_drag_p): Declare only if
7993 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7994 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7995 * lisp.h (echoing): Remove decl.
7996 (force_auto_save_soon): Declare only if SIGDANGER.
7997 * xdisp.c (redisplay_window): Simplify code, to make it more
7998 obvious that ignore_mouse_drag_p is not accessed if !defined
7999 USE_GTK && !defined HAVE_NS.
8001 * intervals.c: Make symbols static if they're not exported.
8002 (merge_properties_sticky, merge_interval_right, delete_interval):
8004 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8006 * insdel.c: Make symbols static if they're not exported.
8007 However, leave prepare_to_modify_buffer alone. It's never
8008 called from outside this function, but that appears to be a bug.
8009 (combine_after_change_list, combine_after_change_buffer):
8010 (adjust_after_replace, signal_before_change): Now static.
8011 (adjust_after_replace_noundo): Remove; unused.
8012 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8013 (signal_before_change): Remove decls.
8015 * indent.c (val_compute_motion, val_vmotion): Now static.
8017 * image.c: Make symbols static if they're not exported.
8018 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8020 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8021 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8023 * fringe.c (standard_bitmaps): Now static.
8024 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8026 * frame.c: Make symbols static if they're not exported.
8027 (x_report_frame_params, make_terminal_frame): Now static.
8028 (get_frame_param): Now static, unless HAVE_NS.
8029 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8030 (x_get_resource_string): Remove; not used.
8031 * frame.h (make_terminal_frame, x_report_frame_params):
8032 (x_get_resource_string); Remove decls.
8033 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8034 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8036 * font.c, fontset.c: Make symbols static if they're not exported.
8037 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8038 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8039 * font.c (font_close_object): Now static.
8040 * font.h (font_close_object): Remove.
8041 * fontset.c (FONTSET_OBJLIST): Remove.
8042 (free_realized_fontset) #if-0 the body, which does nothing.
8043 (face_suitable_for_char_p): #if-0, as it's never called.
8044 * fontset.h (face_suitable_for_char_p): Remove decl.
8045 * xfaces.c (face_at_string_position):
8046 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8047 since 0 is always ASCII.
8049 * fns.c (weak_hash_tables): Now static.
8051 * fileio.c: Make symbols static if they're not exported.
8052 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8053 (Vwrite_region_annotation_buffers): Now static.
8055 * eval.c: Make symbols static if they're not exported.
8056 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8057 * lisp.h (backtrace_list): Remove decl.
8059 * emacs.c: Make symbols static if they're not exported.
8060 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8061 (fatal_error_code, fatal_error_signal_hook, standard_args):
8063 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8064 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8065 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8066 * lisp.h (fatal_error_signal_hook): Remove decl.
8067 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8069 * editfns.c: Move a (normally-unused) function to its only use.
8070 * editfns.c, lisp.h (get_operating_system_release): Remove.
8071 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8072 worth the hassle of breaking this out.
8074 * xterm.c: Make symbols static if they're not exported.
8075 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8076 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8077 (x_destroy_window, x_delete_display):
8079 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8080 (x_mouse_leave): Remove; unused.
8081 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8082 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8083 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8085 (x_mouse_leave): Declare only if WINDOWSNT.
8086 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8087 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8090 * ftxfont.c: Make symbols static if they're not exported.
8091 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8093 * font.h (ftxfont_driver): Likewise.
8095 * xfns.c: Make symbols static if they're not exported.
8096 (x_last_font_name, x_display_info_for_name):
8097 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8098 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8099 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8100 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8101 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8102 (last_show_tip_args): Now static.
8103 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8104 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8105 (x_screen_planes): Remove; unused.
8106 * dispextern.h (x_screen_planes): Remove decl.
8108 * dispnew.c: Make symbols static if they're not exported.
8109 * dispextern.h (redraw_garbaged_frames, scrolling):
8110 (increment_row_positions): Remove.
8111 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8112 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8114 (redraw_garbaged_frames): Remove; unused.
8116 * xfaces.c: Make symbols static if they're not exported.
8117 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8119 * xterm.h (defined_color): Remove decls.
8120 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8121 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8122 (menu_face_changed_default, defined_color, free_realized_face):
8123 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8124 (ascii_face_of_lisp_face): Remove; unused.
8126 * xdisp.c: Make symbols static if they're not exported.
8127 * dispextern.h (scratch_glyph_row, window_box_edges):
8128 (glyph_to_pixel_coords, set_cursor_from_row):
8129 (get_next_display_element, set_iterator_to_next):
8130 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8131 (show_mouse_face): Remove decls
8132 * frame.h (message_buf_print): Likewise.
8133 * lisp.h (pop_message, set_message, check_point_in_composition):
8135 * xterm.h (set_vertical_scroll_bar): Likewise.
8136 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8137 (message_buf_print, scratch_glyph_row, displayed_buffer):
8138 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8139 (get_next_display_element, show_mouse_face, window_box_edges):
8140 (frame_to_window_pixel_xy, check_point_in_composition):
8141 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8142 (glyph_to_pixel_coords): Remove; unused.
8144 * dired.c (file_name_completion): Now static.
8146 * dbusbind.c (xd_in_read_queued_messages): Now static.
8148 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8149 * data.c (circular_list_error): Remove.
8151 * commands.h (last_point_position, last_point_position_buffer):
8152 (last_point_position_window): Remove decls.
8153 * keyboard.c: Make these variables static.
8155 * coding.h (coding, code_convert_region, encode_coding_gap):
8157 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8158 (iso_code_class, detect_coding, code_convert_region): Now static.
8159 (encode_coding_gap): Remove; unused.
8161 * chartab.c (chartab_chars, chartab_bits): Now static.
8163 * charset.h (charset_iso_8859_1): Remove decl.
8164 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8167 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8168 * ccl.c (Vccl_program_table): Now static.
8169 (check_ccl_update): Remove; unused.
8171 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8172 * category.h: ... from here.
8173 * category.c (check_category_table, set_category_set): Now static.
8175 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8176 * lisp.h: Remove these decls.
8178 * buffer.c (buffer_count): Remove unused var.
8180 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8181 so that it's not optimized away.
8182 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8183 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8184 exported only to the debugger.
8186 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8187 * atimer.h (run_all_atimers): Remove; not exported.
8189 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8190 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8191 was inaccessible from Lisp.
8192 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8193 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8195 alloc.c: Import and export fewer symbols, and remove unused items.
8196 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8198 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8199 it's not optimized away by whole-program optimization.
8200 (message_enable_multibyte, free_misc): Remove.
8201 (catchlist, handlerlist, mark_backtrace):
8202 Declare only if BYTE_MARK_STACK.
8203 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8204 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8205 (message_enable_multibyte): Remove decl.
8206 (free_misc, interval_free_list, float_block, float_block_index):
8207 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8208 (cons_free_list, last_marked_index):
8210 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8211 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8212 (mark_backtrace): Define only if BYTE_MARK_STACK.
8213 * xdisp.c (message_enable_multibyte): Now static.
8215 Declare Lisp_Object Q* variables to be 'static' if not exported.
8216 This makes it easier for human readers (and static analyzers)
8217 to see whether these variables are used from other modules.
8218 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8219 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8220 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8221 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8222 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8223 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8224 * xmenu.c, xselect.c:
8225 Declare Q* vars static if they are not used in other modules.
8226 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8227 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8228 Remove decls of unexported vars.
8229 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8231 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8233 Make Emacs functions such as Fatom 'static' by default.
8234 This makes it easier for human readers (and static analyzers)
8235 to see whether these functions can be called from other modules.
8236 DEFUN now defines a static function. To make the function external
8237 so that it can be used in other C modules, use the new macro DEFUE.
8238 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8239 (Finit_image_library):
8240 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8241 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8242 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8243 Remove decls, since these functions are now static.
8244 (Funintern, Fget_internal_run_time): New decls, since these functions
8245 were already external.
8247 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8248 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8249 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8250 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8251 * keyboard.c, keymap.c, lread.c:
8252 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8253 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8254 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8255 Mark functions with DEFUE instead of DEFUN,
8256 if they are used in other modules.
8257 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8258 decls for now-static functions.
8259 * buffer.h (Fdelete_overlay): Remove decl.
8260 * callproc.c (Fgetenv_internal): Mark as internal.
8261 * composite.c (Fremove_list_of_text_properties): Remove decl.
8262 (Fcomposition_get_gstring): New forward static decl.
8263 * composite.h (Fcomposite_get_gstring): Remove decl.
8264 * dired.c (Ffile_attributes): New forward static decl.
8265 * doc.c (Fdocumntation_property): New forward static decl.
8266 * eval.c (Ffetch_bytecode): New forward static decl.
8267 (Funintern): Remove extern decl; now in .h file where it belongs.
8268 * fileio.c (Fmake_symbolic_link): New forward static decl.
8269 * image.c (Finit_image_library): New forward static decl.
8270 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8271 * intervals.h (Fprevious_property_change):
8272 (Fremove_list_of_text_properties): Remove decls.
8273 * keyboard.c (Fthis_command_keys): Remove decl.
8274 (Fcommand_execute): New forward static decl.
8275 * keymap.c (Flookup_key): New forward static decl.
8276 (Fcopy_keymap): Now static.
8277 * keymap.h (Flookup_key): Remove decl.
8278 * process.c (Fget_process): New forward static decl.
8279 (Fprocess_datagram_address): Mark as internal.
8280 * syntax.c (Fsyntax_table_p): New forward static decl.
8281 (skip_chars): Remove duplicate decl.
8282 * textprop.c (Fprevious_property_change): New forward static decl.
8283 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8285 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8286 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8288 * editfns.c (Fformat): Remove unreachable code.
8290 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8292 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8295 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8297 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8298 when at ZV. (Bug#8487)
8300 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8302 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8304 * keyboard.c (parse_tool_bar_item): Likewise.
8305 * sound.c (sound_cleanup, alsa_close): Likewise.
8306 * termcap.c (tgetent): Likewise.
8307 * xfns.c (x_default_font_parameter): Likewise.
8308 * xsettings.c (read_and_apply_settings): Likewise.
8310 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8311 (overrun_check_free): Protoize.
8313 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8315 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8316 since callers should never pass a negative size.
8317 Change the signature to match that of plain 'read' and 'write'; see
8318 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8319 * lisp.h: Update prototypes of emacs_write and emacs_read.
8321 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8323 * xdisp.c (redisplay_window): Don't try to determine the character
8324 position of the scroll margin if the window start point w->startp
8325 is outside the buffer's accessible region. (Bug#8468)
8327 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8329 Fix write-region and its subroutines for buffers > 2GB.
8330 * fileio.c (a_write, e_write): Modify declaration of arguments and
8331 local variables to support buffers larger than 2GB.
8332 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8334 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8335 argument, local variables, and return value.
8337 * lisp.h: Update prototypes of emacs_write and emacs_read.
8339 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8341 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8343 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8345 Fix more problems found by GCC 4.6.0's static checks.
8347 * xdisp.c (vmessage): Use a better test for character truncation.
8349 * charset.c (load_charset_map): <, not <=, for optimization,
8350 and to avoid potential problems with integer overflow.
8351 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8352 * casetab.c (set_identity, shuffle): Likewise.
8353 * editfns.c (Fformat): Likewise.
8354 * syntax.c (skip_chars): Likewise.
8356 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8357 This also lets GCC 4.6.0 generate slightly better loop code.
8359 * callint.c (Fcall_interactively): <, not <=, for optimization.
8360 (Fcall_interactively): Count the number of arguments produced,
8361 not the number of arguments given. This is simpler and lets GCC
8362 4.6.0 generate slightly better code.
8364 * ftfont.c: Distingish more carefully between FcChar8 and char.
8365 The previous code passed unsigned char * to a functions like
8366 strlen and xstrcasecmp that expect char *, which does not
8367 conform to the C standard.
8368 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8369 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8370 char * when the C standard requires it.
8372 * keyboard.c (read_char): Remove unused var.
8374 * eval.c: Port to Windows vsnprintf (Bug#8435).
8376 (SIZE_MAX): Define if the headers do not.
8377 (verror): Do not give up if vsnprintf returns a negative count.
8378 Instead, grow the buffer. This ports to Windows vsnprintf, which
8379 does not conform to C99. Problem reported by Eli Zaretskii.
8380 Also, simplify the allocation scheme, by avoiding the need for
8381 calling realloc, and removing the ALLOCATED variable.
8383 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8385 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8386 But keep the doprint source code for now, as we might revamp it
8387 and use it again (Bug#8435).
8388 * lisp.h (doprnt): Remove.
8389 * Makefile.in (base_obj): Remove doprnt.o.
8390 * deps.mk (doprnt.o): Remove.
8392 error: Print 32- and 64-bit integers portably (Bug#8435).
8393 Without this change, on typical 64-bit hosts error ("...%d...", N)
8394 was used to print both 32- and 64-bit integers N, which relied on
8396 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8397 * lisp.h (error, verror): Mark as printf-like functions.
8398 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8399 Report overflow in size calculations when allocating printf buffer.
8400 Do not truncate output string at its first null byte.
8401 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8402 Truncate the output at a character boundary, since vsnprintf does not
8404 * charset.c (check_iso_charset_parameter): Convert internal
8405 character to string before calling 'error', since %c now has the
8407 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8408 overflow when computing char to be passed to 'error'. Do not
8409 pass Lisp_Object to 'error'; pass the integer instead.
8410 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8411 formatted with plain %d.
8413 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8415 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8417 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8419 * xterm.c (x_catch_errors): Remove duplicate declaration.
8421 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8423 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8425 2011-04-10 Jim Meyering <meyering@redhat.com>
8427 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8428 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8429 return ssize_t not "int", and use size_t as the buffer length.
8430 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8431 * gnutls.h: Update declarations.
8432 * process.c (read_process_output): Use ssize_t, to match.
8433 (send_process): Likewise.
8435 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8437 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8439 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8441 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8442 Use unsigned char, to match FcChar8 type definition.
8444 * xterm.c (handle_one_xevent):
8445 * xmenu.c (create_and_show_popup_menu):
8446 * xselect.c (x_decline_selection_request)
8447 (x_reply_selection_request): Avoid type-punned deref of X events.
8449 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8451 Fix some uses of `int' instead of EMACS_INT.
8452 * search.c (string_match_1, fast_string_match)
8453 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8454 (scan_buffer, find_next_newline_no_quit)
8455 (find_before_next_newline, search_command, Freplace_match)
8456 (Fmatch_data): Make some `int' variables be EMACS_INT.
8458 * xdisp.c (display_count_lines): 3rd argument and return value now
8459 EMACS_INT. All callers changed.
8460 (pint2hrstr): Last argument is now EMACS_INT.
8462 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8463 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8464 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8465 (decode_coding_utf_16, decode_coding_emacs_mule)
8466 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8467 (decode_coding_ccl, decode_coding_charset)
8468 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8469 (decode_coding_iso_2022, decode_coding_emacs_mule)
8470 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8471 <char_offset, last_offset>: Declare EMACS_INT.
8472 (encode_coding_utf_8, encode_coding_utf_16)
8473 (encode_coding_emacs_mule, encode_invocation_designation)
8474 (encode_designation_at_bol, encode_coding_iso_2022)
8475 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8476 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8478 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8479 (encode_invocation_designation): Last argument P_NCHARS is now
8481 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8482 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8484 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8487 * ccl.c (Fccl_execute_on_string): Declare some variables
8490 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8492 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8494 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8496 * process.c (Fformat_network_address): Doc fix.
8498 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8500 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8502 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8504 * keyboard.c (read_char): Call Lisp function help-form-show,
8505 instead of using internal_with_output_to_temp_buffer.
8506 (Qhelp_form_show): New var.
8507 (syms_of_keyboard): Use DEFSYM macro.
8509 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8511 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8513 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8515 * process.c (Flist_processes): Remove to Lisp.
8516 (list_processes_1): Delete.
8518 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8520 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8522 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8524 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8526 Fix more problems found by GCC 4.6.0's static checks.
8528 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8530 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8532 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8534 * xdisp.c (vmessage): Mark as a printf-like function.
8536 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8538 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8540 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8541 printf-like functions.
8542 (tiff_load): Add casts to remove these marks before passing them
8543 to system-supplied API.
8545 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8547 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8548 This avoids several warnings with gcc -Wstrict-overflow.
8549 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8550 directly, rather than having caller test rule sign. This avoids
8551 some unnecessary tests.
8552 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8553 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8554 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8556 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8557 (xfont_open): Avoid unnecessary tests.
8559 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8561 * composite.h, composite.c (composition_gstring_put_cache):
8562 Use EMACS_INT, not int, for length.
8564 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8565 breaking out part of COMPOSITION_DECODE_RULE.
8566 (COMPOSITION_DECODE_RULE): Use it.
8567 * composite.c (get_composition_id): Remove unused local vars,
8568 by using the new macro.
8570 * textprop.c (set_text_properties_1): Change while to do-while,
8571 since the condition is always true at first.
8573 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8574 (interval_deletion_adjustment): Return unsigned value.
8577 * process.c (list_processes_1, create_pty, read_process_output):
8578 (exec_sentinel): Remove vars that were set but not used.
8579 (create_pty): Remove unnecessary "volatile"s.
8580 (Fnetwork_interface_info): Avoid possibility of int overflow.
8581 (read_process_output): Do adaptive read buffering even if carryover.
8582 (read_process_output): Simplify nbytes computation if buffered.
8584 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8586 * syntax.c (scan_words): Remove var that was set but not used.
8587 (update_syntax_table): Use unsigned instead of int.
8589 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8590 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8591 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8593 * print.c (print_error_message): Avoid int overflow.
8595 * font.c (font_list_entities): Redo for clarity,
8596 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8598 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8599 (font_score): Avoid potential overflow in diff calculation.
8601 * fns.c (substring_both): Remove var that is set but not used.
8602 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8604 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8606 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8607 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8608 can always succeed if overflow has undefined behavior.
8610 * search.c (boyer_moore, wordify): Remove vars set but not used.
8611 (wordify): Omit three unnecessary tests.
8613 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8614 All callers changed. This avoids the need for an unused var.
8616 * casefiddle.c (casify_region): Remove var that is set but not used.
8618 * dired.c (file_name_completion): Remove var that is set but not used.
8620 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8622 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8623 (Finsert_file_contents): Remove unnecessary code checking fd.
8625 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8626 Check for integer overflow on size calculations.
8628 * buffer.c (Fprevious_overlay_change): Remove var that is set
8631 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8632 Remove vars that are set but not used.
8633 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8634 (timer_check_2): Mark vars as initialized.
8636 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8638 * image.c (lookup_image): Remove var that is set but not used.
8639 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8641 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8642 that are set but not used.
8644 * xfns.c (make_invisible_cursor): Don't return garbage
8645 if XCreateBitmapFromData fails (Bug#8410).
8647 * xselect.c (x_get_local_selection, x_handle_property_notify):
8648 Remove vars that are set but not used.
8650 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8651 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8653 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8654 Remove var that is set but not used.
8655 (scroll_bar_windows_size): Now size_t, not int.
8656 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8659 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8660 (map_tty_color) [!defined MSDOS]: Likewise.
8662 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8664 * coding.c: Remove vars that are set but not used.
8665 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8666 All callers changed.
8667 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8668 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8669 (decode_coding_charset): Remove vars that are set but not used.
8671 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8672 that is set but not used.
8674 * print.c (print_object): Remove var that is set but not used.
8676 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8677 The gnulib version avoids calling malloc in the usual case,
8678 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8679 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8680 * filelock.c (current_lock_owner): Likewise.
8681 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8682 * sysdep.c: Include allocator.h, careadlinkat.h.
8683 (emacs_no_realloc_allocator): New static constant.
8684 (emacs_readlink): New function.
8685 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8686 ../lib/careadlinkat.h.
8688 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8690 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8691 first non-nil return value).
8693 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8695 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8696 if not defined (Bug#8403).
8698 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8700 * xdisp.c (display_count_lines): Remove parameter `start',
8701 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8702 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8703 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8704 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8705 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8706 and thereabouts. All callers changed.
8707 (get_per_char_metric): Remove parameter `f', unused since
8708 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8710 2011-04-02 Jim Meyering <meyering@redhat.com>
8712 do not dereference NULL upon failed strdup
8713 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8714 (ns_get_family): Likewise.
8716 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8718 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8720 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8722 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8725 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8727 Add lexical binding.
8729 * window.c (Ftemp_output_buffer_show): New fun.
8730 (Fsave_window_excursion):
8731 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8733 * lread.c (lisp_file_lexically_bound_p): New function.
8734 (Fload): Bind Qlexical_binding.
8735 (readevalloop): Remove `evalfun' arg.
8736 Bind Qinternal_interpreter_environment.
8737 (Feval_buffer): Bind Qlexical_binding.
8738 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8740 (syms_of_lread): Declare `lexical-binding'.
8742 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8744 * keyboard.c (eval_dyn): New fun.
8745 (menu_item_eval_property): Use it.
8747 * image.c (parse_image_spec): Use Ffunctionp.
8749 * fns.c (concat, mapcar1): Accept byte-code-functions.
8751 * eval.c (Fsetq): Handle lexical vars.
8752 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8753 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8754 (FletX, Flet): Obey lexical binding.
8755 (Fcommandp): Handle closures.
8756 (Feval): New `lexical' arg.
8757 (eval_sub): New function extracted from Feval. Use it almost
8758 everywhere where Feval was used. Look up vars in lexical env.
8760 (Ffunctionp): Move from subr.el.
8761 (Ffuncall): Handle closures.
8762 (apply_lambda): Remove `eval_flags'.
8763 (funcall_lambda): Handle closures and new byte-code-functions.
8764 (Fspecial_variable_p): New function.
8765 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8766 but without exporting it to Lisp.
8768 * doc.c (Fdocumentation, store_function_docstring):
8769 * data.c (Finteractive_form): Handle closures.
8771 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8774 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8776 (exec_byte_code): New function extracted from Fbyte_code to handle new
8777 calling convention for byte-code-functions. Add new byte-codes.
8779 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8781 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8783 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8785 * xdisp.c (redisplay_internal): Fix prototype.
8787 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8789 * xdisp.c (SCROLL_LIMIT): New macro.
8790 (try_scrolling): Use it when setting scroll_limit.
8791 Limit scrolling to 100 screen lines.
8792 (redisplay_window): Even when falling back on "recentering",
8793 position point in the window according to scroll-conservatively,
8794 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8796 (try_scrolling): When point is above the window, allow searching
8797 as far as scroll_max, or one screenful, to compute vertical
8798 distance from PT to the scroll margin position. This prevents
8799 try_scrolling from unnecessarily failing when
8800 scroll-conservatively is set to a value slightly larger than the
8801 window height. Clean up the case of PT below the margin at bottom
8802 of window: scroll_max can no longer be INT_MAX. When aggressive
8803 scrolling is in use, don't let point enter the opposite scroll
8804 margin as result of the scroll.
8805 (syms_of_xdisp) <scroll-conservatively>: Document the
8806 threshold of 100 lines for never-recentering scrolling.
8808 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8810 * dispextern.h (move_it_by_lines):
8811 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8812 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8813 (message_log_check_duplicate): Remove parameters `prev_bol' and
8814 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8815 (redisplay_internal): Remove parameter `preserve_echo_area',
8816 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8818 * indent.c (Fvertical_motion):
8819 * window.c (window_scroll_pixel_based, Frecenter):
8820 Don't pass `need_y_p' to `move_it_by_lines'.
8822 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8824 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8825 steal a few bits to be more compact.
8826 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8827 Remove unneeded casts.
8829 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8831 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8833 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8834 binding" message (bug#7967).
8836 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8838 Fix more problems found by GCC 4.6.0's static checks.
8840 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8841 Remove unused local var.
8843 * editfns.c (Fmessage_box): Remove unused local var.
8845 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8846 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8847 Omit unused local vars.
8848 * window.c (shrink_windows): Omit unused local var.
8849 * menu.c (digest_single_submenu): Omit unused local var.
8850 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8851 Omit unused local var.
8853 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8854 Don't assume string length fits in int.
8855 (keyremap_step, read_key_sequence): Use size_t for sizes.
8856 (read_key_sequence): Don't check last_real_key_start redundantly.
8858 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8859 instead of alloca (Bug#8344).
8861 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8862 (Fbacktrace_frame): Don't assume nframes fits in int.
8864 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8866 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8869 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8871 * cm.c (calccost): Turn while-do into do-while, for clarity.
8873 * keyboard.c (syms_of_keyboard): Use the same style as later
8874 in this function when indexing through an array. This also
8875 works around GCC bug 48267.
8877 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8879 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8881 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8882 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8884 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8885 This avoids undefined behavior on integer overflow, and is a bit
8886 more convenient anyway since it is compared to a size_t variable.
8888 Variadic C functions now count arguments with size_t, not int.
8889 This avoids an unnecessary limitation on 64-bit machines, which
8890 caused (substring ...) to crash on large vectors (Bug#8344).
8891 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8892 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8893 All variadic functions and their callers changed accordingly.
8894 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8895 * data.c (arith_driver, float_arith_driver): Likewise.
8896 * editfns.c (general_insert_function): Likewise.
8897 * eval.c (struct backtrace.nargs, interactive_p)
8898 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8899 (funcall_lambda, mark_backtrace): Likewise.
8900 * fns.c (concat): Likewise.
8901 * frame.c (x_set_frame_parameters): Likewise.
8902 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8903 0 if not found, not -1. All callers changed.
8905 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8906 (stack_copy_size): Now size_t, not int.
8907 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8909 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8911 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8912 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8913 All callers changed.
8915 * lisp.h (multibyte_char_to_unibyte):
8916 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8917 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8918 * character.h (CHAR_TO_BYTE8):
8919 * cmds.c (internal_self_insert):
8920 * editfns.c (general_insert_function):
8921 * keymap.c (push_key_description):
8922 * search.c (Freplace_match):
8923 * xdisp.c (message_dolog, set_message_1): All callers changed.
8925 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8927 * keyboard.c (safe_run_hook_funcall): New function.
8928 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8929 don't set the hook to nil, but remove the offending function instead.
8930 (Qcommand_hook_internal): Remove, unused.
8931 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8932 Vcommand_hook_internal.
8934 * eval.c (enum run_hooks_condition): Remove.
8935 (funcall_nil, funcall_not): New functions.
8936 (run_hook_with_args): Call each function through a `funcall' argument.
8937 Remove `cond' argument, now redundant.
8938 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8939 (Frun_hook_with_args_until_failure): Adjust accordingly.
8940 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8942 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8944 * dispextern.h (string_buffer_position): Remove declaration.
8946 * print.c (strout): Remove parameter `multibyte', unused since
8947 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8949 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8950 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8951 All callers changed.
8953 * w32.c (_wsa_errlist): Use braces for struct initializers.
8955 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8956 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8957 All callers changed.
8958 (string_buffer_position): Likewise. Also, make static (it's never
8959 used outside xdisp.c).
8960 (cursor_row_p): Remove parameter `w', unused since
8961 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8962 (decode_mode_spec): Remove parameter `precision', introduced during
8963 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8964 All callers changed.
8966 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8968 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8970 2011-03-27 Anders Lindgren <andlind@gmail.com>
8972 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8973 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8974 (ns_update_auto_hide_menu_bar): New functions.
8975 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8976 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8977 ns_constrain_all_frames.
8978 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8979 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8981 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8983 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8985 2011-03-27 Glenn Morris <rgm@gnu.org>
8987 * syssignal.h: Replace RETSIGTYPE with void.
8988 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8989 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8990 Replace SIGTYPE with void everywhere.
8991 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8992 * s/template.h (SIGTYPE): Remove commented out definition.
8994 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8996 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8997 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8999 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9001 * w32.c (read_unc_volume): Use parameter `henum', instead of
9002 global variable `wget_enum_handle'.
9004 * keymap.c (describe_vector): Remove parameters `indices' and
9005 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9006 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9008 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9010 * keyboard.c (timer_check): Remove parameter `do_it_now',
9011 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9012 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9013 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9015 * keyboard.c (read_char):
9016 * w32menu.c (w32_menu_display_help):
9017 * xmenu.c (show_help_event, menu_help_callback):
9018 Adjust calls to `show_help_echo'.
9020 * gtkutil.c (xg_maybe_add_timer):
9021 * keyboard.c (readable_events):
9022 * process.c (wait_reading_process_output):
9023 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9025 * insdel.c (adjust_markers_gap_motion):
9026 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9027 (gap_left, gap_right): Don't call it.
9029 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9031 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9032 incurred during fontification.
9034 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9036 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9037 (DEFVAR_PER_BUFFER): Don't pass it.
9039 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9040 (scrolling_window): Don't pass it.
9042 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9044 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9046 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9048 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9049 of variables specific to SELinux and computation of `encoded_absname'.
9051 * image.c (XPutPixel): Remove unused variable `height'.
9053 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9055 * unexw32.c (get_section_info): Remove unused variable `section'.
9057 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9058 (system_process_attributes): Remove unused variable `sess'.
9059 (sys_read): Remove unused variable `err'.
9061 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9062 (w32_wnd_proc): Remove unused variable `isdead'.
9063 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9064 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9065 (x_create_tip_frame): Remove unused variable `tem'.
9067 * w32inevt.c (w32_console_read_socket):
9068 Remove unused variable `no_events'.
9070 * w32term.c (x_draw_composite_glyph_string_foreground):
9071 Remove unused variable `width'.
9073 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9075 * w32term.c (x_set_glyph_string_clipping):
9076 Don't pass uninitialized region to CombineRgn.
9078 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9080 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9081 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9082 (Fx_close_connection): Remove unused variable `i'.
9084 * w32font.c (w32font_draw): Return number of glyphs.
9085 (w32font_open_internal): Remove unused variable `i'.
9086 (w32font_driver): Add missing initializer.
9088 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9089 (fill_in_menu): Remove unused variable `items_added'.
9091 * w32term.c (last_mouse_press_frame): Remove static global variable.
9092 (w32_clip_to_row): Remove unused variable `f'.
9093 (x_delete_terminal): Remove unused variable `i'.
9095 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9096 (NOTHING): Remove unused static global variable.
9097 (uniscribe_check_otf): Remove unused variable `table'.
9098 (uniscribe_font_driver): Add missing initializers.
9100 2011-03-23 Julien Danjou <julien@danjou.info>
9102 * term.c (Fsuspend_tty, Fresume_tty):
9103 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9104 * window.c (temp_output_buffer_show):
9105 * insdel.c (signal_before_change):
9106 * frame.c (Fhandle_switch_frame):
9107 * fileio.c (Fdo_auto_save):
9108 * emacs.c (Fkill_emacs):
9109 * editfns.c (save_excursion_restore):
9110 * cmds.c (internal_self_insert):
9111 * callint.c (Fcall_interactively):
9112 * buffer.c (Fkill_all_local_variables):
9113 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9115 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9116 unconditionally since it does the check itself.
9118 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9120 Fix more problems found by GCC 4.5.2's static checks.
9122 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9123 the first time through the loop, since we know p0 < p1 then.
9124 This also avoids a gcc -Wstrict-overflow warning.
9126 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9127 leading to a memory leak, possible in functions like
9128 load_charset_map_from_file that can allocate an unbounded number
9129 of objects (Bug#8318).
9131 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9132 that could (at least in theory) be that large.
9134 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9135 This is less likely to overflow, and avoids undefined behavior if
9136 overflow does occur. All callers changed. Use strtoul to scan
9137 for the unsigned long integer.
9138 (pint2hrstr): Simplify and tune code slightly.
9139 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9141 * scroll.c (do_scrolling): Work around GCC bug 48228.
9142 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9144 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9145 This also avoids a warning with gcc -Wstrict-overflow.
9146 (validate_x_resource_name): Simplify count usage.
9147 This also avoids a warning with gcc -Wstrict-overflow.
9149 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9152 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9154 * process.c (Fmake_network_process): Use socklen_t, not int,
9155 where POSIX says socklen_t is required in portable programs.
9156 This fixes a porting bug on hosts like 64-bit HP-UX, where
9157 socklen_t is wider than int (Bug#8277).
9158 (Fmake_network_process, server_accept_connection):
9159 (wait_reading_process_output, read_process_output):
9162 * process.c: Rename or move locals to avoid shadowing.
9163 (list_processes_1, Fmake_network_process):
9164 (read_process_output_error_handler, exec_sentinel_error_handler):
9165 Rename or move locals.
9166 (Fmake_network_process): Define label "retry_connect" only if needed.
9167 (Fnetwork_interface_info): Fix pointer signedness.
9168 (process_send_signal): Add cast to avoid pointer signedness problem.
9169 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9170 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9172 Make tparam.h and terminfo.c consistent.
9173 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9174 Include tparam.h instead, since it declares them.
9175 * cm.h (PC): Remove extern decl; tparam.h now does this.
9176 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9177 * terminfo.c: Include tparam.h, to check interfaces.
9178 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9179 (tparam): Adjust signature to match interface in tparam.h;
9180 this removes some undefined behavior. Check that outstring and len
9181 are zero, which they always are with Emacs.
9182 * tparam.h (PC, BC, UP): New extern decls.
9184 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9185 (xftfont_open): Rename locals to avoid shadowing.
9187 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9188 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9189 (OTF_TAG_SYM): Omit macro if not needed.
9190 (ftfont_list): Remove unused local.
9191 (get_adstyle_property, ftfont_pattern_entity):
9192 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9193 Rename locals to avoid shadowing.
9195 * xfont.c (xfont_list_family): Mark var as initialized.
9197 * xml.c (make_dom): Now static.
9199 * composite.c (composition_compute_stop_pos): Rename local to
9201 (composition_reseat_it): Remove unused locals.
9202 (find_automatic_composition, composition_adjust_point): Likewise.
9203 (composition_update_it): Mark var as initialized.
9204 (find_automatic_composition): Mark vars as initialized,
9205 with a FIXME (Bug#8290).
9207 character.h: Rename locals to avoid shadowing.
9208 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9209 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9210 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9211 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9214 * textprop.c (property_change_between_p): Remove; unused.
9216 * intervals.c (interval_start_pos): Now static.
9218 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9220 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9221 Rename locals to avoid shadowing.
9223 * sound.c (wav_play, au_play, Fplay_sound_internal):
9224 Fix pointer signedness.
9225 (alsa_choose_format): Remove unused local var.
9226 (wav_play): Initialize a variable to 0, to prevent undefined
9227 behavior (Bug#8278).
9229 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9231 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9233 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9234 clobbering (Bug#8298).
9235 * sysdep.c (sys_subshell): Likewise.
9236 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9238 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9239 This should get cleaned up, so that child_setup has the
9240 same signature on all platforms.
9242 * callproc.c (call_process_cleanup): Now static.
9243 (relocate_fd): Rename locals to avoid shadowing.
9245 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9247 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9248 not to be necessary, and produces flickering.
9250 2011-03-20 Glenn Morris <rgm@gnu.org>
9252 * config.in: Remove file.
9254 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9256 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9257 are now in src/globals.h.
9258 (syms_of_minibuf): Remove spurious & from previous change.
9260 2011-03-20 Leo Liu <sdl.web@gmail.com>
9262 * minibuf.c (completing-read-function): New variable.
9263 (completing-read-default): Rename from completing-read.
9264 (completing-read): Call completing-read-function.
9266 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9268 * xfaces.c (Fx_load_color_file):
9269 Read color file from absolute filename (bug#8250).
9271 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9273 * makefile.w32-in: Update dependencies.
9275 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9277 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9279 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9281 Fix more problems found by GCC 4.5.2's static checks.
9283 * process.c (make_serial_process_unwind, send_process_trap):
9284 (sigchld_handler): Now static.
9286 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9287 That way, the code declares only the vars that it needs.
9288 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9289 * s/cygwin.h (PTY_ITERATION): Likewise.
9290 * s/darwin.h (PTY_ITERATION): Likewise.
9291 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9293 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9294 * process.c (allocate_pty): Don't declare stb unless it's needed.
9296 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9297 (CONSTANTLIM): Remove; unused.
9298 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9299 Define only if needed.
9301 * unexelf.c (unexec): Name an expression,
9302 to avoid gcc -Wbad-function-cast warning.
9303 Use a different way to cause a compilation error if anyone uses
9304 n rather than nn, a way that does not involve shadowing.
9305 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9307 * deps.mk (unexalpha.o): Remove; unused.
9309 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9310 * unexec.h: New file.
9311 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9312 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9314 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9315 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9316 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9317 Change as necessary to match prototype in unexec.h.
9319 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9321 (back_comment, skip_chars): Mark vars as initialized.
9323 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9324 Rename locals to avoid shadowing.
9326 * lread.c (read1): Rewrite so as not to use empty "else".
9327 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9329 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9331 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9332 warning when compiling print.c.
9334 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9335 instead of using an uninitialized var.
9336 (font_sort_entities): Mark var as initialized.
9338 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9340 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9341 pointers to constants.
9342 (font_parse_fcname): Remove unused vars.
9343 (font_delete_unmatched): Now static.
9344 (font_get_spec): Remove; unused.
9345 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9346 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9347 Rename or move locals to avoid shadowing.
9349 * fns.c (require_nesting_list, require_unwind): Now static.
9350 (Ffillarray): Rename locals to avoid shadowing.
9352 * floatfns.c (domain_error2): Define only if needed.
9353 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9355 * alloc.c (mark_backtrace): Move decl from here ...
9356 * lisp.h: ... to here, so that it can be checked.
9358 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9359 (Fdefvar): Rewrite so as not to use empty "else".
9360 (lisp_indirect_variable): Name an expression,
9361 to avoid gcc -Wbad-function-cast warning.
9362 (Fdefvar): Rename locals to avoid shadowing.
9364 * callint.c (quotify_arg, quotify_args): Now static.
9365 (Fcall_interactively): Rename locals to avoid shadowing.
9366 Use const pointer when appropriate.
9368 * lisp.h (get_system_name, get_operating_system_release):
9369 Move decls here, to check interfaces.
9370 * process.c (get_operating_system_release): Move decl to lisp.h.
9371 * xrdb.c (get_system_name): Likewise.
9372 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9373 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9374 some of which prompt warnings from gcc -Wbad-function-cast.
9375 (Fformat_time_string, Fencode_time, Finsert_char):
9376 (Ftranslate_region_internal, Fformat):
9377 Rename or remove local vars to avoid shadowing.
9378 (Ftranslate_region_internal): Mark var as initialized.
9380 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9383 * lisp.h (eassert): Check that the argument compiles, even if
9384 ENABLE_CHECKING is not defined.
9386 * data.c (Findirect_variable): Name an expression, to avoid
9387 gcc -Wbad-function-cast warning.
9388 (default_value, arithcompare, arith_driver, arith_error): Now static.
9389 (store_symval_forwarding): Rename local to avoid shadowing.
9390 (Fmake_variable_buffer_local, Fmake_local_variable):
9391 Mark variables as initialized.
9392 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9394 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9395 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9396 Rename locals to avoid shadowing.
9397 (mark_stack): Move local variables into the #ifdef region where
9399 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9400 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9402 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9403 (GC_STRING_CHARS): Remove; not used.
9404 (Fmemory_limit): Cast sbrk's returned value to char *.
9406 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9407 avoids undefined behavior in theory.
9409 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9411 Use functions, not macros, for up- and down-casing (Bug#8254).
9412 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9413 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9414 to use the following functions instead of these macros.
9415 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9416 EMACS_INT, since callers assume the returned value fits in int.
9417 (upcase1): Likewise, for UPCASE_TABLE.
9418 (uppercasep, lowercasep, upcase): New static inline functions.
9419 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9420 the race-condition problem in the old DOWNCASE.
9422 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9423 Rename locals to avoid shadowing.
9424 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9425 (regex_compile, re_search_2, re_match_2_internal):
9426 Remove unused local vars.
9427 (FREE_VAR): Rewrite so as not to use empty "else",
9428 which gcc can warn about.
9429 (regex_compile, re_match_2_internal): Mark locals as initialized.
9430 (RETALLOC_IF): Define only if needed.
9431 (WORDCHAR_P): Likewise. This one is never needed, but is used
9432 only in a comment talking about a compiler bug, so put inside
9433 the #if 0 of that comment.
9434 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9435 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9438 * search.c (boyer_moore): Rename locals to avoid shadowing.
9439 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9440 (PREV_CHAR_BOUNDARY): Likewise.
9442 * search.c (simple_search): Remove unused var.
9444 * dired.c (compile_pattern): Move decl from here ...
9445 * lisp.h: ... to here, so that it can be checked.
9446 (struct re_registers): New forward decl.
9448 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9450 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9452 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9453 Rename locals to avoid shadowing.
9454 (Fvertical_motion): Mark locals as initialized.
9456 * casefiddle.c (casify_object, casify_region): Now static.
9457 (casify_region): Mark local as initialized.
9459 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9461 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9462 New macros, so that the caller can use some names other than
9463 gcpro1, gcpro2, etc.
9464 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9466 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9467 argument, for consistency with GCPRO2_VAR, etc: it is now the
9468 prefix of the variable, not the variable itself. All uses
9470 * dired.c (directory_files_internal, file_name_completion):
9471 Rename locals to avoid shadowing.
9473 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9474 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9475 dired.c's scmp function, had undefined behavior.
9476 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9477 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9478 * buffer.h: ... to here, because these macros use current_buffer,
9479 and the new implementation with inline functions needs to have
9480 current_buffer in scope now, rather than later when the macros
9482 (downcase, upcase1): New static inline functions.
9483 (DOWNCASE, UPCASE1): Reimplement using these functions.
9484 This avoids undefined behavior in expressions like
9485 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9486 from race conditions in accessing the global variables
9487 case_temp1 and case_temp2.
9488 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9489 * lisp.h (case_temp1, case_temp2): Remove their decls.
9490 * character.h (ASCII_CHAR_P): Move from here ...
9491 * lisp.h: ... to here, so that the inline functions mentioned
9494 * dired.c (directory_files_internal_unwind): Now static.
9496 * fileio.c (file_name_as_directory, directory_file_name):
9497 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9499 (file_name_as_directory): Use const pointers when appropriate.
9500 (Fexpand_file_name): Likewise. In particular, newdir might
9501 point at constant storage, so make it a const pointer.
9502 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9503 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9505 (Fset_file_times, Finsert_file_contents, auto_save_error):
9506 Rename locals to avoid shadowing.
9508 * minibuf.c (choose_minibuf_frame_1): Now static.
9509 (Ftry_completion, Fall_completions): Rename or remove locals
9512 * marker.c (bytepos_to_charpos): Remove; unused.
9514 * lisp.h (verify_bytepos, count_markers): New decls,
9515 so that gcc does not warn that these functions aren't declared.
9517 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9518 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9519 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9520 (copy_text): Remove unused local var.
9522 * filelock.c (within_one_second): Now static.
9523 (lock_file_1): Rename local to avoid shadowing.
9525 * buffer.c (fix_overlays_before): Mark locals as initialized.
9526 (fix_start_end_in_overlays): Likewise. This function should be
9527 simplified by using pointers-to-pointers, but that's a different
9529 (switch_to_buffer_1): Now static.
9530 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9531 (report_overlay_modification): Rename locals to avoid shadowing.
9533 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9534 Fix pointer signedness issue.
9535 (sys_subshell): Mark local as volatile if checking for lint,
9536 to suppress a gcc -Wclobbered warning that does not seem to be right.
9537 (MAXPATHLEN): Define only if needed.
9539 * process.c (serial_open, serial_configure): Move decls from here ...
9540 * systty.h: ... to here, so that they can be checked.
9542 * fns.c (get_random, seed_random): Move extern decls from here ...
9543 * lisp.h: ... to here, so that they can be checked.
9545 * sysdep.c (reset_io): Now static.
9546 (wait_for_termination_signal): Remove; unused.
9548 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9549 (copy_keymap_item, append_key, push_text_char_description):
9551 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9552 (DENSE_TABLE_SIZE): Remove; unused.
9553 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9554 (describe_map_tree):
9555 Rename locals to avoid shadowing.
9557 * keyboard.c: Declare functions static if they are not used elsewhere.
9558 (echo_char, echo_dash, cmd_error, top_level_2):
9559 (poll_for_input, handle_async_input): Now static.
9560 (read_char, kbd_buffer_get_event, make_lispy_position):
9561 (make_lispy_event, make_lispy_movement, apply_modifiers):
9562 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9563 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9564 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9565 (read_key_sequence, read_char): Mark locals as initialized.
9566 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9568 * keyboard.h (make_ctrl_char): New decl.
9569 (mark_kboards): Move decl here ...
9570 * alloc.c (mark_kboards): ... from here.
9572 * lisp.h (force_auto_save_soon): New decl.
9574 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9575 (DEFINE_DUMMY_FUNCTION): New macro.
9576 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9578 (main): Add casts to avoid warnings
9579 if GCC considers string literals to be constants.
9581 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9583 * dbusbind.c: Pointer signedness fixes.
9584 (xd_signature, xd_append_arg, xd_initialize):
9585 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9586 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9587 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9588 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9590 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9591 if GCC considers string literals to be constants.
9592 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9594 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9596 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9597 (print_preprocess, print_object): New macro to fix last change.
9599 * print.c (print_preprocess): Don't forget font objects.
9601 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9603 * emacs.c (USAGE3): Doc fixes.
9605 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9607 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9610 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9612 * lisp.h (VWindow_system, Qfile_name_history):
9613 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9614 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9615 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9617 * w32select.c: Don't #include "keyboard.h".
9618 (run_protected): Add extern declaration for waiting_for_input.
9620 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9621 * w32console.c (detect_input_pending, read_input_pending)
9622 (encode_terminal_code):
9623 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9624 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9625 (w32_system_caret_y, Qfile_name_history):
9626 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9627 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9628 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9629 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9630 * w32proc.c (Qlocal, report_file_error):
9631 * w32term.c (Vwindow_system, updating_frame):
9632 * w32uniscribe.c (initialized, uniscribe_font_driver):
9633 Remove unneeded extern declarations.
9635 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9637 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9639 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9641 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9642 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9643 These macros can no longer be used for assignment.
9645 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9646 Assign struct members directly, instead of using BUF_BEGV etc.
9647 (record_buffer_markers, fetch_buffer_markers): New functions for
9648 recording and fetching special buffer markers.
9649 (set_buffer_internal_1, set_buffer_temp): Use them.
9651 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9653 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9655 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9656 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9658 * xdisp.c (hscroll_window_tree):
9659 (reconsider_clip_changes): Use PT instead of BUF_PT.
9661 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9663 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9664 $(EMACS_ROOT)/lib/intprops.h.
9666 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9668 Fix more problems found by GCC 4.5.2's static checks.
9670 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9671 to unsigned char * to avoid compiler diagnostic.
9672 (xg_free_frame_widgets): Make it clear that a local variable is
9673 needed only if USE_GTK_TOOLTIP.
9674 (gdk_window_get_screen): Make it clear that this macro is needed
9675 only if USE_GTK_TOOLTIP.
9676 (int_gtk_range_get_value): New function, which avoids a diagnostic
9677 from gcc -Wbad-function-cast.
9678 (xg_set_toolkit_scroll_bar_thumb): Use it.
9679 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9680 diagnostic from gcc -Wbad-function-cast.
9681 (get_utf8_string, xg_get_file_with_chooser):
9682 Rename locals to avoid shadowing.
9683 (create_dialog): Move locals to avoid shadowing.
9685 * xgselect.c (xg_select): Remove unused var.
9687 * image.c (four_corners_best): Mark locals as initialized.
9688 (gif_load): Initialize transparent_p to zero (Bug#8238).
9689 Mark another local as initialized.
9690 (my_png_error, my_error_exit): Mark with NO_RETURN.
9692 * image.c (clear_image_cache): Now static.
9693 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9694 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9695 (x_edge_detection): Remove unnecessary cast that
9696 gcc -Wbad-function-cast diagnoses.
9697 (gif_load): Fix pointer signedness.
9698 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9699 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9701 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9703 Improve quality of tests for time stamp overflow.
9704 For example, without this patch (encode-time 0 0 0 1 1
9705 1152921504606846976) returns the obviously-bogus value (-948597
9706 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9707 reports time overflow. See
9708 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9709 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9710 * editfns.c: Include limits.h and intprops.h.
9711 (TIME_T_MIN, TIME_T_MAX): New macros.
9712 (time_overflow): Move earlier, to before first use.
9713 (hi_time, lo_time): New functions, for an accurate test for
9715 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9716 (Fget_internal_run_time): Don't assume time_t fits in int.
9717 (make_time): Use list2 instead of Fcons twice.
9718 (Fdecode_time): More accurate test for out-of-range times.
9719 (check_tm_member): New function.
9720 (Fencode_time): Use it, to test for out-of-range times.
9721 (lisp_time_argument): Don't rely on undefined left-shift and
9722 right-shift behavior when checking for time stamp overflow.
9724 * editfns.c (time_overflow): New function, refactoring common code.
9725 (Fformat_time_string, Fdecode_time, Fencode_time):
9726 (Fcurrent_time_string): Use it.
9728 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9729 * dired.c (make_time): Move to ...
9730 * editfns.c (make_time): ... here.
9731 * systime.h: Note the move.
9733 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9735 * fringe.c (update_window_fringes): Remove unused variables.
9737 * unexmacosx.c (copy_data_segment): Also copy __got section.
9740 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9742 * termcap.c [MSDOS]: Include "msdos.h".
9743 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9744 Constify `char *' arguments and their references according to
9745 prototypes in tparam.h.
9747 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9749 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9750 Adapt all references accordingly.
9752 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9754 2011-03-11 Tom Tromey <tromey@redhat.com>
9756 * buffer.c (syms_of_buffer): Remove obsolete comment.
9758 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9760 * termhooks.h (encode_terminal_code): Declare prototype.
9762 * msdos.c (encode_terminal_code): Don't declare prototype.
9764 * term.c (encode_terminal_code): Now external again, used by
9765 w32console.c and msdos.c.
9767 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9768 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9770 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9772 Fix some minor problems found by GCC 4.5.2's static checks.
9774 * fringe.c (update_window_fringes): Mark locals as initialized
9776 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9778 * alloc.c (mark_fringe_data): Move decl from here ...
9779 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9780 to check its interface.
9781 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9783 * fontset.c (free_realized_fontset): Now static.
9784 (Fset_fontset_font): Rename local to avoid shadowing.
9785 (fontset_font): Mark local as initialized.
9786 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9788 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9790 * xselect.c (x_disown_buffer_selections): Remove; not used.
9791 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9792 (x_own_selection, Fx_disown_selection_internal): Rename locals
9794 (x_handle_dnd_message): Remove local to avoid shadowing.
9796 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9797 so that the caller can use some name other than gcpro1.
9798 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9799 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9800 (Fx_backspace_delete_keys_p):
9801 Use them to avoid shadowing, and rename vars to avoid shadowing.
9802 (x_decode_color, x_set_name, x_window): Now static.
9803 (Fx_create_frame): Add braces to silence GCC warning.
9804 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9805 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9806 Remove unused locals.
9807 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9808 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9809 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9812 * xterm.h (x_mouse_leave): New decl.
9814 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9815 Remove unused functions.
9816 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9817 (x_calc_absolute_position): Now static.
9818 (XTread_socket): Don't define label "out" unless it's used.
9819 Don't declare local "event" unless it's used.
9820 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9821 unless they are used.
9822 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9823 (x_fatal_error_signal): Remove; not used.
9824 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9825 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9826 (x_error_catcher, x_connection_closed, x_error_handler):
9827 (x_error_quitter, xembed_send_message, x_iconify_frame):
9828 (my_log_handler): Rename locals to avoid shadowing.
9829 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9830 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9832 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9833 Rename or move locals to avoid shadowing.
9834 (tty_defined_color, merge_face_heights): Now static.
9835 (free_realized_faces_for_fontset): Remove; not used.
9836 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9837 does not deduce is never used uninitialized.
9838 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9839 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9841 * terminal.c (store_terminal_param): Now static.
9843 * xmenu.c (menu_highlight_callback): Now static.
9844 (set_frame_menubar): Remove unused local.
9845 (xmenu_show): Rename parameter to avoid shadowing.
9846 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9847 since they might point to immutable storage.
9848 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9849 since it's unused otherwise.
9851 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9852 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9853 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9854 avoids a gcc -Wuninitialized diagnostic.
9855 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9856 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9857 does not deduce are never used uninitialized.
9859 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9861 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9862 * window.c (window_loop, size_window):
9863 (run_window_configuration_change_hook, enlarge_window): Likewise.
9865 * window.c (display_buffer): Now static.
9866 (size_window): Mark variables that gcc -Wuninitialized
9867 does not deduce are never used uninitialized.
9868 * window.h (check_all_windows): New decl, to forestall
9869 gcc -Wmissing-prototypes diagnostic.
9870 * dispextern.h (bidi_dump_cached_states): Likewise.
9872 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9874 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9876 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9877 and to avoid gcc -Wuninitialized warning.
9878 (load_charset_map): Mark variables that gcc -Wuninitialized
9879 does not deduce are never used uninitialized.
9880 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9882 * coding.c (coding_set_source, coding_set_destination):
9883 Use "else { /* comment */ }" rather than "else /* comment */;"
9884 for clarity, and to avoid gcc -Wempty-body warning.
9885 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9886 a block, when the outer 'i' will do.
9887 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9888 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9889 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9890 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9891 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9892 Rename locals to avoid shadowing.
9893 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9894 * coding.c (emacs_mule_char, encode_invocation_designation):
9895 Now static, since they're not used elsewhere.
9896 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9897 (decode_coding_object, encode_coding_object, detect_coding_system):
9898 (decode_coding_emacs_mule): Mark variables that gcc
9899 -Wuninitialized does not deduce are never used uninitialized.
9900 (detect_coding_iso_2022): Initialize a local variable that might
9901 be used uninitialized. Leave a FIXME because it's not clear that
9902 this initialization is needed. (Bug#8211)
9903 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9904 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9905 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9906 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9907 Remove unused macros.
9909 * category.c (hash_get_category_set): Remove unused local var.
9910 (copy_category_table): Now static, since it's not used elsewhere.
9911 * character.c (string_count_byte8): Likewise.
9913 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9914 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9916 * chartab.c (copy_sub_char_table): Now static, since it's not used
9918 (sub_char_table_ref_and_range, char_table_ref_and_range):
9919 Rename locals to avoid shadowing.
9920 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9922 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9923 (BIDI_BOB): Remove unused macro.
9925 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9926 deduce are never used uninitialized.
9927 * term.c (encode_terminal_code): Likewise.
9929 * term.c (encode_terminal_code): Now static. Remove unused local.
9931 * tparam.h: New file.
9932 * term.c, tparam.h: Include it.
9933 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9934 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9935 Move these decls to tparam.h, and make them agree with what
9936 is actually in tparam.c. The previous trick of using incompatible
9937 decls in different modules does not conform to the C standard.
9938 All callers of tparam changed to use tparam's actual API.
9939 * tparam.c (tparam1, tparam, tgoto):
9940 Use const pointers where appropriate.
9942 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9943 * cm.h (struct cm): Likewise.
9944 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9945 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9946 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9947 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9948 (turn_on_face, init_tty): Likewise.
9949 * termchar.h (struct tty_display_info): Likewise.
9951 * term.c (term_mouse_position): Rename local to avoid shadowing.
9953 * alloc.c (mark_ttys): Move decl from here ...
9954 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9956 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9958 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9960 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9962 * search.c (compile_pattern_1): Remove argument regp, unused since
9963 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9964 (compile_pattern): Don't pass it.
9966 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9968 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9969 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9971 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9973 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9975 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9976 gdk_window_get_screen, gdk_window_get_geometry,
9977 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9978 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9979 (xg_get_pixbuf_from_pixmap): New function.
9980 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9981 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9982 Call xg_get_pixbuf_from_pixmap instead of
9983 gdk_pixbuf_get_from_drawable.
9984 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9985 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9986 (xg_check_special_colors): Use GtkStyleContext and its functions
9988 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9989 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9990 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9991 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9992 Call gtk_widget_get_preferred_size.
9993 (xg_frame_resized): gdk_window_get_geometry only takes 5
9995 (xg_win_to_widget, xg_event_is_for_menubar):
9996 Call gdk_x11_window_lookup_for_display.
9997 (xg_set_widget_bg): New function.
9998 (delete_cb): New function.
9999 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10000 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10001 (xg_set_background_color): Call xg_set_widget_bg.
10002 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10003 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10004 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10005 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10007 (update_frame_tool_bar): Call gtk_widget_hide.
10008 (xg_initialize): Use GDK_KEY_g.
10010 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10012 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10014 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10015 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10016 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10018 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10020 * w32xfns.c (select_palette): Check success of RealizePalette against
10021 GDI_ERROR, not zero.
10023 See ChangeLog.11 for earlier changes.
10025 ;; Local Variables:
10029 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10031 This file is part of GNU Emacs.
10033 GNU Emacs is free software: you can redistribute it and/or modify
10034 it under the terms of the GNU General Public License as published by
10035 the Free Software Foundation, either version 3 of the License, or
10036 (at your option) any later version.
10038 GNU Emacs is distributed in the hope that it will be useful,
10039 but WITHOUT ANY WARRANTY; without even the implied warranty of
10040 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10041 GNU General Public License for more details.
10043 You should have received a copy of the GNU General Public License
10044 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.