Remove arbitrary limit of 2**31 entries in hash tables.
[bpt/emacs.git] / src / ChangeLog
1 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2
3 Remove arbitrary limit of 2**31 entries in hash tables.
4 * category.c (hash_get_category_set): Use 'EMACS_UINT' and 'EMACS_INT'
5 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6 * ccl.c (ccl_driver): Likewise.
7 * charset.c (Fdefine_charset_internal): Likewise.
8 * charset.h (struct charset.hash_index): Likewise.
9 * composite.c (get_composition_id, gstring_lookup_cache):
10 (composition_gstring_put_cache): Likewise.
11 * composite.h (struct composition.hash_index): Likewise.
12 * dispextern.h (struct image.hash): Likewise.
13 * fns.c (next_almost_prime, larger_vector, cmpfn_eql):
14 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql):
15 (hashfn_equal, hashfn_user_defined, make_hash_table):
16 (maybe_resize_hash_table, hash_lookup, hash_put):
17 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE):
18 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
19 (Fsxhash, Fgethash, Fputhash, Fmaphash): Likewise.
20 * image.c (make_image, search_image_cache, lookup_image):
21 (xpm_put_color_table_h): Likewise.
22 * lisp.h (struct Lisp_Hash_Table): Likewise, for 'count', 'cmpfn',
23 and 'hashfn' members.
24 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
25 Likewise.
26 * print.c (print): Likewise.
27 * alloc.c (allocate_vectorlike): Check for overflow in vector size
28 calculations.
29 * ccl.c (ccl_driver): Check for overflow when converting EMACS_INT
30 to int.
31 * fns.c, image.c: Remove unnecessary static decls that would otherwise
32 need to be updated by these changes.
33 * fns.c (make_hash_table, maybe_resize_hash_table): Check for integer
34 overflow with large hash tables.
35 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
36 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
37 (SXHASH_REDUCE): New macro.
38 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
39 Use it instead of discarding useful hash info with large hash values.
40 (sxhash_float): New function.
41 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
42 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
43 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK): Rewrite
44 to use FIXNUM_BITS, as this simplifies things.
45 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
46 Adjust signatures to match updated version of code.
47 (consing_since_gc): Now EMACS_INT, since a single hash table can
48 use more than INT_MAX bytes.
49
50 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
51
52 Use 'inline', not 'INLINE'.
53 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
54 * alloc.c, fontset.c (INLINE): Remove.
55 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
56 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
57 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
58 * gmalloc.c (register_heapinfo): Use inline unconditionally.
59 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
60
61 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
62
63 Make it possible to run ./temacs.
64
65 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
66 syms_of_callproc does the same thing. Remove test for
67 "initialized", do it in the caller.
68 * emacs.c (main): Avoid calling set_initial_environment when dumping.
69
70 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
71
72 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
73 (read_minibuf): Use get_minibuffer.
74 (syms_of_minibuf): Use DEFSYM.
75 (Qmetadata): New var.
76 * data.c (Qbuffer): Don't make it static.
77 (syms_of_data): Use DEFSYM.
78
79 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
80
81 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
82 (CCL_CODE_MIN): New macro.
83
84 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
85
86 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
87
88 * eval.c (Qdebug): Now static.
89 * lisp.h (Qdebug): Remove decl. This reverts a part of the
90 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
91 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
92
93 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
94
95 * image.c: Various fixes to ImageMagick code comments.
96 (Fimagemagick_types): Doc fix.
97
98 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
99
100 Minor fixes prompted by GCC 4.6.0 warnings.
101
102 * xselect.c (converted_selections, conversion_fail_tag): Now static.
103
104 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
105 (x_clipboard_manager_save_all): Move extern decl to ...
106 * xterm.h: ... here, so that it can be checked for consistency.
107
108 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
109
110 * xselect.c (x_clipboard_manager_save_frame)
111 (x_clipboard_manager_save_all): New functions.
112 (Fx_clipboard_manager_save): Lisp function deleted.
113
114 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
115 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
116
117 * xterm.h: Update prototype.
118
119 2011-05-28 William Xu <william.xwl@gmail.com>
120
121 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
122 exiting (Bug#8239).
123
124 2011-05-28 Jim Meyering <meyering@redhat.com>
125
126 Avoid a sign-extension bug in crypto_hash_function.
127 * fns.c (to_uchar): Define.
128 (crypto_hash_function): Use it to convert some newly-signed
129 variables to unsigned, to avoid sign-extension bugs. For example,
130 without this change, (md5 "truc") would evaluate to
131 45723a2aff78ff4fff7fff1114760e62 rather than the expected
132 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
133 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
134
135 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
136
137 Integer overflow fixes.
138
139 * dbusbind.c: Serial number integer overflow fixes.
140 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
141 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
142 to hold a serial number that is too large for a fixnum.
143 (Fdbus_method_return_internal, Fdbus_method_error_internal):
144 Check for serial numbers out of range. Decode any serial number
145 that was so large that it became a float. (Bug#8722)
146
147 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
148 (Fdbus_call_method, Fdbus_call_method_asynchronously):
149 Use XFASTINT rather than XUINT when numbers are nonnegative.
150 (xd_append_arg, Fdbus_method_return_internal):
151 (Fdbus_method_error_internal): Likewise. Also, for unsigned
152 arguments, check that Lisp number is nonnegative, rather than
153 silently wrapping negative numbers around. (Bug#8722)
154 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
155 (Bug#8722)
156
157 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
158
159 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
160
161 ccl: add integer overflow checks
162 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
163 (IN_INT_RANGE): New macros.
164 (ccl_driver): Use them to check for integer overflow when
165 decoding a CCL program. Many of the new checks are whether XINT (x)
166 fits in int; it doesn't always, on 64-bit hosts. The new version
167 doesn't catch all possible integer overflows, but it's an
168 improvement. (Bug#8719)
169
170 * alloc.c (make_event_array): Use XINT, not XUINT.
171 There's no need for unsigned here.
172
173 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
174 This follows up to the 2011-05-06 change that substituted uintptr_t
175 for EMACS_INT. This case wasn't caught back then.
176
177 Rework Fformat to avoid integer overflow issues.
178 * editfns.c: Include <float.h> unconditionally, as it's everywhere
179 now (part of C89). Include <verify.h>.
180 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
181 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
182 (Fformat): Avoid the prepass trying to compute sizes; it was only
183 approximate and thus did not catch overflow reliably. Instead, walk
184 through the format just once, formatting and computing sizes as we go,
185 checking for integer overflow at every step, and allocating a larger
186 buffer as needed. Keep track separately whether the format is
187 multibyte. Keep only the most-recently calculated precision, rather
188 than them all. Record whether each argument has been converted to
189 string. Use EMACS_INT, not int, for byte and char and arg counts.
190 Support field widths and precisions larger than INT_MAX. Avoid
191 sprintf's undefined behavior with conversion specifications such as %#d
192 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
193 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
194 formatting out-of-range floating point numbers with int
195 formats. (Bug#8668)
196
197 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
198
199 * data.c: Avoid integer truncation in expressions involving floats.
200 * data.c: Include <intprops.h>.
201 (arith_driver): When there's an integer overflow in an expression
202 involving floating point, convert the integers to floating point
203 so that the resulting value does not suffer from catastrophic
204 integer truncation. For example, on a 64-bit host (* 4
205 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
206 Do not rely on undefined behavior after integer overflow.
207
208 merge count_size_as_multibyte, parse_str_to_multibyte
209 * character.c, character.h (count_size_as_multibyte):
210 Renamed from parse_str_to_multibyte; all uses changed.
211 Check for integer overflow.
212 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
213 since it's now a duplicate of the other. This is more of
214 a character than a buffer op, so better that it's in character.c.
215 * fns.c, print.c: Adjust to above changes.
216
217 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
218
219 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
220
221 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
222
223 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
224 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
225 (x_clipboard_manager_save): Now static.
226 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
227
228 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
229 (crypto_hash_function): Now static.
230 Fix pointer signedness problems. Avoid unnecessary initializations.
231
232 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
233
234 * termhooks.h (Vselection_alist): Make it terminal-local.
235
236 * terminal.c (create_terminal): Initialize it.
237
238 * xselect.c: Support for clipboard managers.
239 (Vselection_alist): Move to termhooks.h as terminal-local var.
240 (LOCAL_SELECTION): New macro.
241 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
242 (symbol_to_x_atom): Remove gratuitous arg.
243 (x_handle_selection_request, lisp_data_to_selection_data)
244 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
245 (x_own_selection, x_get_local_selection, x_convert_selection):
246 New arg, specifying work frame. Use terminal-local Vselection_alist.
247 (some_frame_on_display): Delete unused function.
248 (Fx_own_selection_internal, Fx_get_selection_internal)
249 (Fx_disown_selection_internal, Fx_selection_owner_p)
250 (Fx_selection_exists_p): New optional frame arg.
251 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
252 (x_handle_selection_clear): Don't treat other terminals with the
253 same keyboard specially. Use the terminal-local Vselection_alist.
254 (x_clear_frame_selections): Use Frun_hook_with_args.
255
256 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
257
258 * xterm.h: Add support for those atoms.
259
260 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
261
262 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
263 (converted_selections, conversion_fail_tag): New global variables.
264 (x_selection_request_lisp_error): Free the above.
265 (x_get_local_selection): Remove unnecessary code.
266 (x_reply_selection_request): Args changed; handle arbitrary array
267 of converted selections stored in converted_selections.
268 Separate the XChangeProperty and SelectionNotify steps.
269 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
270 (x_convert_selection): New function.
271 (x_handle_selection_event): Simplify.
272 (x_get_foreign_selection): Don't ignore incoming requests while
273 waiting for an answer; this will fail when we implement
274 SAVE_TARGETS, and seems unnecessary anyway.
275 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
276 (Vx_sent_selection_functions): Doc fix.
277
278 2011-05-26 Leo Liu <sdl.web@gmail.com>
279
280 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
281
282 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
283
284 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
285
286 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
287 for fringe update if it has periodic bitmap.
288 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
289 and fringe_bitmap_periodic_p.
290
291 * fringe.c (get_fringe_bitmap_data): New function.
292 (draw_fringe_bitmap_1, update_window_fringes): Use it.
293 (update_window_fringes): Record periodicity of fringe bitmap in glyph
294 row. Mark glyph row for fringe update if periodicity changed.
295
296 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
297 for fringe update unless it has periodic bitmap.
298
299 2011-05-25 Kenichi Handa <handa@m17n.org>
300
301 * xdisp.c (get_next_display_element): Set correct it->face_id for
302 a static composition.
303
304 2011-05-24 Leo Liu <sdl.web@gmail.com>
305
306 * deps.mk (fns.o):
307 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
308
309 * fns.c (crypto_hash_function, Fsha1): New function.
310 (Fmd5): Use crypto_hash_function.
311 (syms_of_fns): Add Ssha1.
312
313 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
314
315 * gnutls.c: Remove unused macros.
316 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
317 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
318 Remove macros that are defined and never used.
319 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
320
321 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
322
323 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
324 (Fx_get_selection_internal): Minor cleanup.
325 (Fx_own_selection_internal): Rename arguments for consistency with
326 select.el.
327
328 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
329
330 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
331
332 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
333
334 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
335
336 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
337
338 * dispnew.c (scrolling_window): Don't exclude the case that the
339 last enabled row in the desired matrix touches the bottom boundary.
340
341 2011-05-21 Glenn Morris <rgm@gnu.org>
342
343 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
344 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
345 and add some more files.
346
347 2011-05-20 Eli Zaretskii <eliz@gnu.org>
348
349 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
350 report_file_error introduced by the change from 2011-05-07.
351
352 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
353
354 * systime.h (Time): Define only if emacs is defined.
355 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
356 where the include path doesn't have X11/X.h by default. See
357 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
358
359 2011-05-20 Kenichi Handa <handa@m17n.org>
360
361 * composite.c (find_automatic_composition): Fix previous change.
362
363 2011-05-20 Glenn Morris <rgm@gnu.org>
364
365 * lisp.mk: New file, split from Makefile.in.
366 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
367 (shortlisp): Remove.
368 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
369
370 2011-05-19 Glenn Morris <rgm@gnu.org>
371
372 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
373 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
374 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
375 (lisp): Set the order to that of loadup.el.
376 (shortlisp): Make it a copy of $lisp.
377 (SOME_MACHINE_LISP): Remove.
378 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
379 Use just $shortlisp, not $SOME_MACHINE_LISP too.
380
381 2011-05-18 Kenichi Handa <handa@m17n.org>
382
383 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
384 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
385 (find_automatic_composition): Mostly rewrite for efficiency.
386
387 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
388
389 * makefile.w32-in: Update dependencies.
390
391 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
392
393 * menu.c: Include limits.h (fixes the MS-Windows build broken by
394 revision 104625).
395
396 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
397
398 Fix some integer overflow issues, such as string length overflow.
399
400 * insdel.c (count_size_as_multibyte): Check for string overflow.
401
402 * character.c (lisp_string_width): Check for string overflow.
403 Use EMACS_INT, not int, for string indexes and lengths; in
404 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
405 the resulting string length overflows an EMACS_INT; instead,
406 report a string overflow if no precision given. When checking for
407 precision exhaustion, use a check that cannot possibly have
408 integer overflow. (Bug#8675)
409 * character.h (lisp_string_width): Adjust to new signature.
410
411 * alloc.c (string_overflow): New function.
412 (Fmake_string): Use it. This doesn't change behavior, but saves
413 a few bytes and will simplify future changes.
414 * character.c (string_escape_byte8): Likewise.
415 * lisp.h (string_overflow): New decl.
416
417 Fixups, following up to the user-interface timestamp change.
418 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
419 for UI timestamps, instead of unsigned long.
420 * msdos.c (mouse_get_pos): Likewise.
421 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
422 * w32gui.h (Time): Define by including "systime.h" rather than by
423 declaring it ourselves. (Bug#8664)
424
425 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
426 * image.c (clear_image_cache): Likewise.
427
428 * term.c (term_mouse_position): Don't assume time_t wraparound.
429
430 Be more systematic about user-interface timestamps.
431 Before, the code sometimes used 'Time', sometimes 'unsigned long',
432 and sometimes 'EMACS_UINT', to represent these timestamps.
433 This change causes it to use 'Time' uniformly, as that's what X uses.
434 This makes the code easier to follow, and makes it easier to catch
435 integer overflow bugs such as Bug#8664.
436 * frame.c (Fmouse_position, Fmouse_pixel_position):
437 Use Time, not unsigned long, for user-interface timestamps.
438 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
439 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
440 * keyboard.h (last_event_timestamp): Likewise.
441 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
442 * menu.h (xmenu_show): Likewise.
443 * term.c (term_mouse_position): Likewise.
444 * termhooks.h (struct input_event.timestamp): Likewise.
445 (struct terminal.mouse_position_hook): Likewise.
446 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
447 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
448 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
449 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
450 what it was before.
451 * menu.h, termhooks.h: Include "systime.h", for Time.
452
453 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
454 Don't assume that the difference between two unsigned long values
455 can fit into an integer. At this point, we know button_down_time
456 <= event->timestamp, so the difference must be nonnegative, so
457 there's no need to cast the result if double-click-time is
458 nonnegative, as it should be; check that it's nonnegative, just in
459 case. This bug is triggered when events are more than 2**31 ms
460 apart (about 25 days). (Bug#8664)
461
462 * xselect.c (last_event_timestamp): Remove duplicate decl.
463 (x_own_selection): Remove needless cast to unsigned long.
464
465 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
466 that always fit in int. Use a sentinel instead of a counter, to
467 avoid a temp and to allay GCC's concerns about possible int overflow.
468 * frame.h (struct frame): Use int for menu_bar_items_used
469 instead of EMACS_INT, since it always fits in int.
470
471 * menu.c (grow_menu_items): Check for int overflow.
472
473 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
474
475 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
476 Before, the code was not consistent. These values cannot exceed
477 2**31 - 1 so there's no need to make them unsigned.
478 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
479 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
480 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
481 as modifiers.
482 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
483
484 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
485 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
486 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
487 presumably because the widths might not match.
488
489 * window.c (size_window): Avoid needless test at loop start.
490
491 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
492
493 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
494
495 2011-05-12 Drew Adams <drew.adams@oracle.com>
496
497 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
498
499 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
500
501 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
502 `width' to `bar_area_x' and `bar_area_width', respectively.
503 (x_scroll_run): Take account of fringe background extension.
504
505 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
506 Rename local vars `left' and `width' to `bar_area_x' and
507 `bar_area_width', respectively.
508 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
509 background extension.
510
511 2011-05-10 Jim Meyering <meyering@redhat.com>
512
513 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
514
515 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
516
517 * image.c (Finit_image_library): Return t for built-in image types,
518 like pbm and xbm. (Bug#8640)
519
520 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
521
522 * w32menu.c (set_frame_menubar): Fix submenu allocation.
523
524 2011-05-07 Eli Zaretskii <eliz@gnu.org>
525
526 * w32console.c (Fset_screen_color): Doc fix.
527 (Fget_screen_color): New function.
528 (syms_of_ntterm): Defsubr it.
529
530 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
531 unlink the temporary file if Fcall_process didn't create it in the
532 first place.
533 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
534 child process will be redirected to a file specified with `:file'.
535 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
536 cue to call_process_cleanup not to close that handle.
537
538 2011-05-07 Ben Key <bkey76@gmail.com>
539
540 * makefile.w32-in: The bootstrap-temacs rule now makes use of
541 one of two shell specific rules, either bootstrap-temacs-CMD or
542 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
543 to the previous implementation of the bootstrap-temacs rule.
544 The bootstrap-temacs-CMD rule is similar to the previous
545 implementation of the bootstrap-temacs rule except that it
546 makes use of the ESC_CFLAGS variable instead of the CFLAGS
547 variable.
548
549 These changes, along with some changes to nt/configure.bat,
550 nt/gmake.defs, and nt/nmake.defs, are required to extend my
551 earlier fix to add support for --cflags and --ldflags options
552 that include quotes so that it works whether make uses cmd or
553 sh as the shell.
554
555 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
556
557 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
558 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
559 is a constant.
560 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
561 a string. Handle both cases.
562 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
563 (Fdbus_register_method): Use Qinvalid_function.
564
565 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
566
567 * makefile.w32-in: Update dependencies.
568 (LISP_H): Add inttypes.h and stdin.h.
569 (PROCESS_H): Add unistd.h.
570
571 2011-05-06 Eli Zaretskii <eliz@gnu.org>
572
573 * lread.c: Include limits.h (fixes the MS-Windows build broken by
574 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
575
576 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
577
578 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
579
580 * term.c (vfatal): Remove stray call to va_end.
581 It's not needed and the C Standard doesn't allow it here anyway.
582
583 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
584 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
585
586 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
587 bytes.
588
589 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
590
591 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
592
593 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
594
595 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
596
597 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
598
599 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
600 * charset.c (Fdefine_charset_internal): Don't initialize
601 charset.code_space[15]. The value was garbage, on hosts with
602 32-bit int (Bug#8600).
603
604 * lread.c (read_integer): Be more consistent with string-to-number.
605 Use string_to_number to do the actual conversion; this avoids
606 rounding errors and fixes some other screwups. Without this fix,
607 for example, #x1fffffffffffffff was misread as -2305843009213693952.
608 (digit_to_number): Move earlier, for benefit of read_integer.
609 Return -1 if the digit is out of range for the base, -2 if it is
610 not a digit in any supported base. (Bug#8602)
611
612 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
613
614 * dispnew.c (scrolling_window): Return 1 if we scrolled,
615 to match comment at start of function. This also removes a
616 GCC warning about overflow in a 32+64-bit port.
617
618 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
619
620 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
621 Reported by Stefan Monnier in
622 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
623 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
624 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
625
626 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
627 (EMACS_UINTPTR): Likewise, with uintptr_t.
628
629 * lisp.h: Prefer 64-bit EMACS_INT if available.
630 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
631 on 32-bit hosts that have 64-bit int, so that they can access
632 large files.
633 However, temporarily disable this change unless the temporary
634 symbol WIDE_EMACS_INT is defined.
635
636 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
637
638 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
639 This removes an assumption that EMACS_INT and long are the same
640 width as pointers. The assumption is true for Emacs porting targets
641 now, but we want to make other targets possible.
642 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
643 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
644 In the rest of the code, change types of integers that hold casted
645 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
646 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
647 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
648 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
649 No need to cast type when ORing.
650 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
651 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
652 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
653 assume EMACS_INT is the same width as char *.
654 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
655 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
656 Remove no-longer-needed casts.
657 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
658 (xg_tool_bar_help_callback, xg_make_tool_item):
659 Use EMACS_INTPTR to hold an integer
660 that will be cast to void *; this can avoid a GCC warning
661 if EMACS_INT is not the same width as void *.
662 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
663 * xdisp.c (display_echo_area_1, resize_mini_window_1):
664 (current_message_1, set_message_1):
665 Use a local to convert to proper width without a cast.
666 * xmenu.c (dialog_selection_callback): Likewise.
667
668 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
669 Also, don't assume VALBITS / RAND_BITS is less than 5,
670 and don't rely on undefined behavior when shifting a 1 left into
671 the sign bit.
672 * lisp.h (get_random): Change signature to match.
673
674 * lread.c (hash_string): Use size_t, not int, for hash computation.
675 Normally we prefer signed values; but hashing is special, because
676 it's better to use unsigned division on hash table sizes so that
677 the remainder is nonnegative. Also, size_t is the natural width
678 for hashing into memory. The previous code used 'int', which doesn't
679 retain enough info to hash well into very large tables.
680 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
681
682 * dbusbind.c: Don't possibly lose pointer info when converting.
683 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
684 Use XPNTR rather than XHASH, so that the high-order bits of
685 the pointer aren't lost when converting through void *.
686
687 * eval.c (Fautoload): Don't double-shift a pointer.
688
689 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
690
691 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
692
693 * gnutls.c (DEF_GNUTLS_FN):
694 * image.c (DEF_IMGLIB_FN): Make function pointers static.
695
696 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
697
698 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
699 marker. (Bug#8610)
700
701 2011-05-05 Eli Zaretskii <eliz@gnu.org>
702
703 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
704 New version that can reserve upto 2GB of heap space.
705
706 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
707
708 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
709
710 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
711
712 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
713 `gnutls_certificate_set_x509_key_file'.
714
715 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
716
717 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
718 Update dependencies.
719
720 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
721
722 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
723 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
724 Remove unused parameter `fildes'.
725 * process.c (read_process_output, send_process): Don't pass it.
726
727 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
728
729 Fix previous change: the library cache is defined in w32.c.
730 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
731 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
732
733 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
734
735 Implement dynamic loading of GnuTLS on Windows.
736
737 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
738 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
739 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
740 Declare.
741
742 * gnutls.c (Qgnutls_dll): Define.
743 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
744 (gnutls_*): Declare function pointers.
745 (init_gnutls_functions): New function to initialize function pointers.
746 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
747 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
748 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
749 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
750 (emacs_gnutls_write, emacs_gnutls_read)
751 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
752 (Fgnutls_available_p): New function.
753 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
754 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
755 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
756
757 * image.c: Include w32.h.
758 (Vimage_type_cache): Delete.
759 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
760 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
761 (w32_delayed_load): Move to w32.c.
762
763 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
764
765 * w32.c (QCloaded_from, Vlibrary_cache): Define.
766 (w32_delayed_load): Move from image.c. When loading a library, record
767 its filename in the :loaded-from property of the library id.
768 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
769 Initialize and staticpro them.
770 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
771
772 * process.c: Include lisp.h before w32.h, not after.
773 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
774 instead of gnutls_record_check_pending.
775
776 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
777
778 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
779
780 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
781 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
782 as passed in.
783
784 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
785
786 * xterm.c (x_set_frame_alpha): Do not set property on anything
787 else than FRAME_X_OUTER_WINDOW (Bug#8608).
788
789 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
790
791 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
792
793 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
794
795 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
796 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
797 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
798 (gnutls_global_initialized, Qgnutls_bootprop_priority)
799 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
800 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
801 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
802 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
803 (Qgnutls_bootprop_callbacks_verify): Make static.
804
805 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
806
807 * callproc.c: Indentation fixup.
808
809 * sysdep.c (wait_for_termination_1): Make static.
810 (wait_for_termination, interruptible_wait_for_termination):
811 Move after wait_for_termination_1.
812
813 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
814
815 * sysdep.c (interruptible_wait_for_termination): New function
816 which is like wait_for_termination, but allows keyboard
817 interruptions.
818
819 * callproc.c (Fcall_process): Add (:file "file") as an option for
820 the STDOUT buffer.
821 (Fcall_process_region): Ditto.
822
823 2011-04-30 Eli Zaretskii <eliz@gnu.org>
824
825 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
826 rather than `XVECTOR (FOO)->size'.
827
828 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
829 inttypes.h, as a gnulib replacement is used if it not available in
830 system headers.
831
832 2011-04-21 Eli Zaretskii <eliz@gnu.org>
833
834 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
835 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
836 of MOST_POSITIVE_FIXNUM. (Bug#8528)
837
838 * coding.c (coding_alloc_by_realloc): Error out if destination
839 will grow beyond MOST_POSITIVE_FIXNUM.
840 (decode_coding_emacs_mule): Abort if there isn't enough place in
841 charbuf for the composition carryover bytes. Reserve an extra
842 space for up to 2 characters produced in a loop.
843 (decode_coding_iso_2022): Abort if there isn't enough place in
844 charbuf for the composition carryover bytes.
845
846 2011-04-21 Eli Zaretskii <eliz@gnu.org>
847
848 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
849 aborting when %lld or %lll format is passed.
850 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
851 %llo or %llx format is passed. (Bug#8545)
852
853 * window.c (window_scroll_line_based): Use a marker instead of
854 simple variables to record original value of point. (Bug#7952)
855
856 * doprnt.c (doprnt): Fix the case where a multibyte sequence
857 produced by %s or %c overflows available buffer space. (Bug#8545)
858
859 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
860
861 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
862 (SIZE_MAX): Move defn after all includes, as they might #define it.
863
864 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
865
866 * w32.c (init_environment): Warn about defaulting HOME to C:\.
867
868 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
869
870 * keyboard.c (Qdelayed_warnings_hook): Define.
871 (command_loop_1): Run `delayed-warnings-hook'
872 if Vdelayed_warnings_list is non-nil.
873 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
874 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
875
876 2011-04-28 Eli Zaretskii <eliz@gnu.org>
877
878 * doprnt.c (doprnt): Don't return value smaller than the buffer
879 size if the message was truncated. (Bug#8545).
880
881 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
882
883 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
884 (Fx_window_property): #if-0 the whole functions, not just the bodies.
885
886 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
887
888 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
889
890 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
891
892 * makefile.w32-in: Update dependencies.
893
894 2011-04-27 Eli Zaretskii <eliz@gnu.org>
895
896 Improve `doprnt' and its usage. (Bug#8545)
897 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
898 `format_end'. Remove support for %l as a conversion specifier.
899 Don't use xrealloc. Improve diagnostics when the %l size modifier
900 is used. Update the commentary.
901
902 * eval.c (verror): Simplify calculation of size_t.
903
904 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
905 messages.
906
907 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
908
909 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
910 change.
911
912 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
913
914 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
915 This makes this file independent of the recent pseudovector change.
916
917 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
918
919 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
920
921 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
922 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
923 Remove unused local.
924 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
925
926 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
927 GCC 4.6.0 optimizes based on type-based alias analysis.
928 For example, if b is of type struct buffer * and v of type struct
929 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
930 != &v->size, and therefore "v->size = 1; b->size = 2; return
931 v->size;" must therefore return 1. This assumption is incorrect
932 for Emacs, since it type-puns struct Lisp_Vector * with many other
933 types. To fix this problem, this patch adds a new type struct
934 vectorlike_header that documents the constraints on layout of vectors
935 and pseudovectors, and helps optimizing compilers not get fooled
936 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
937 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
938 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
939 the size member.
940 (XSETPVECTYPE): Rewrite in terms of new macro.
941 (XSETPVECTYPESIZE): New macro, specifying both type and size.
942 This is a bit clearer, and further avoids the possibility of
943 undesirable aliasing.
944 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
945 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
946 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
947 since Lisp_Subr is a special case (no "next" field).
948 (ASIZE): Now uses header.size rather than size.
949 All previous uses of XVECTOR (foo)->size replaced to use this macro,
950 to avoid the hassle of writing XVECTOR (foo)->header.size.
951 (struct vectorlike_header): New type.
952 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
953 object, to help avoid aliasing.
954 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
955 (SUBRP): Likewise, since Lisp_Subr is a special case.
956 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
957 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
958 (struct Lisp_Hash_Table): Combine first two members into a single
959 struct vectorlike_header member. All uses of "size" and "next" members
960 changed to be "header.size" and "header.next".
961 * buffer.h (struct buffer): Likewise.
962 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
963 * frame.h (struct frame): Likewise.
964 * process.h (struct Lisp_Process): Likewise.
965 * termhooks.h (struct terminal): Likewise.
966 * window.c (struct save_window_data, struct saved_window): Likewise.
967 * window.h (struct window): Likewise.
968 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
969 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
970 * buffer.c (init_buffer_once): Likewise.
971 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
972 special case.
973 * process.c (Fformat_network_address): Use local var for size,
974 for brevity.
975
976 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
977
978 Make the Lisp reader and string-to-float more consistent (Bug#8525)
979 * data.c (atof): Remove decl; no longer used or needed.
980 (digit_to_number): Move to lread.c.
981 (Fstring_to_number): Use new string_to_number function, to be
982 consistent with how the Lisp reader treats infinities and NaNs.
983 Do not assume that floating-point numbers represent EMACS_INT
984 without losing information; this is not true on most 64-bit hosts.
985 Avoid double-rounding errors, by insisting on integers when
986 parsing non-base-10 numbers, as the documentation specifies.
987 * lisp.h (string_to_number): New decl, replacing ...
988 (isfloat_string): Remove.
989 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
990 (read1): Do not accept +. and -. as integers; this
991 appears to have been a coding error. Similarly, do not accept
992 strings like +-1e0 as floating point numbers. Do not report
993 overflow for integer overflows unless the base is not 10 which
994 means we have no simple and reliable way to continue.
995 Break out the floating-point parsing into a new
996 function string_to_number, so that Fstring_to_number parses
997 floating point numbers consistently with the Lisp reader.
998 (digit_to_number): Move here from data.c. Make it static inline.
999 (E_CHAR, EXP_INT): Remove, replacing with ...
1000 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1001 (string_to_number): New function, replacing isfloat_string.
1002 This function checks for valid syntax and produces the resulting
1003 Lisp float number too. Rework it so that string-to-number
1004 no longer mishandles examples like "1.0e+". Use strtoumax,
1005 so that overflow for non-base-10 numbers is reported only when
1006 there's no portable and simple way to convert to floating point.
1007
1008 * textprop.c (set_text_properties_1): Rewrite for clarity,
1009 and to avoid GCC warning about integer overflow.
1010
1011 * intervals.h (struct interval): Use EMACS_INT for members
1012 where EMACS_UINT might cause problems. See
1013 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1014 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1015 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1016 All uses changed.
1017 (offset_intervals): Tell GCC not to worry about length overflow
1018 when negating a negative length.
1019
1020 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1021 (overrun_check_free): Likewise.
1022
1023 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1024 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1025 word size.
1026
1027 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1028 (gnutls_make_error): Rename local to avoid shadowing.
1029 (gnutls_emacs_global_deinit): ifdef out; not used.
1030 (Fgnutls_boot): Use const for pointer to readonly storage.
1031 Comment out unused local. Fix pointer signedness problems.
1032
1033 * lread.c (openp): Don't stuff size_t into an 'int'.
1034 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1035 about possible signed overflow.
1036
1037 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1038 (GDK_KEY_g): Don't define if already defined.
1039 (xg_prepare_tooltip): Avoid pointer signedness problem.
1040 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1041
1042 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1043 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1044
1045 * xfns.c (Fx_window_property): Simplify a bit,
1046 to make a bit faster and to avoid GCC 4.6.0 warning.
1047 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1048
1049 * fns.c (internal_equal): Don't assume size_t fits in int.
1050
1051 * alloc.c (compact_small_strings): Tighten assertion a little.
1052
1053 Replace pEd with more-general pI, and fix some printf arg casts.
1054 * lisp.h (pI): New macro, generalizing old pEd macro to other
1055 conversion specifiers. For example, use "...%"pI"d..." rather
1056 than "...%"pEd"...".
1057 (pEd): Remove. All uses replaced with similar uses of pI.
1058 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1059 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1060 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1061 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1062 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1063 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1064 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1065 64-bit hosts.
1066 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1067 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1068 * print.c (safe_debug_print, print_object): Likewise.
1069 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1070 to int.
1071 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1072 avoiding the 0 flag, which is not portable.
1073 * process.c (Fmake_network_process): Use pI to avoid cast.
1074 * region-cache.c (pp_cache): Likewise.
1075 * xdisp.c (decode_mode_spec): Likewise.
1076 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1077 behavior on 64-bit hosts with printf arg.
1078 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1079 (x_stop_queuing_selection_requests): Likewise.
1080 (x_get_window_property): Don't truncate byte count to an 'int'
1081 when tracing.
1082
1083 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1084 here, since it parses constructs like leading '-' and spaces,
1085 which are not wanted; and it overflows with large numbers.
1086 Instead, simply match F[0-9]+, which is what is wanted anyway.
1087
1088 * alloc.c: Remove unportable assumptions about struct layout.
1089 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1090 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1091 (allocate_vectorlike, make_pure_vector): Use the new macros,
1092 plus offsetof, to remove unportable assumptions about struct layout.
1093 These assumptions hold on all porting targets that I know of, but
1094 they are not guaranteed, they're easy to remove, and removing them
1095 makes further changes easier.
1096
1097 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1098 This doesn't fix a bug but makes the code clearer.
1099 (string_overrun_cookie): Now const. Use initializers that
1100 don't formally overflow signed char, to avoid warnings.
1101 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1102 can cause Emacs to crash when string overrun checking is enabled.
1103 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1104 multiple of sizeof (EMACS_INT); it need not be, if
1105 alignof(EMACS_INT) < sizeof (EMACS_INT).
1106 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1107
1108 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1109
1110 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1111
1112 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1113
1114 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1115 supposed to be handshaking. (Bug#8556)
1116 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1117
1118 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1119
1120 * lisp.h (Qdebug): List symbol.
1121 * eval.c (Qdebug): Restore global linkage.
1122 * keyboard.c (debug-on-event): New variable.
1123 (handle_user_signal): Break into debugger when debug-on-event
1124 matches the current signal symbol.
1125
1126 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1127
1128 * alloc.c (check_sblock, check_string_bytes)
1129 (check_string_free_list): Convert to standard C.
1130
1131 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1132
1133 * w32.c (emacs_gnutls_push): Fix typo.
1134
1135 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1136
1137 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1138 "cast to pointer from integer of different size".
1139
1140 Improve doprnt and its use in verror. (Bug#8545)
1141 * doprnt.c (doprnt): Document the set of format control sequences
1142 supported by the function. Use SAFE_ALLOCA instead of always
1143 using `alloca'.
1144
1145 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1146 is one byte too soon. Don't use xrealloc; instead xfree and
1147 xmalloc anew.
1148
1149 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1150
1151 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1152 callbacks stage.
1153
1154 * gnutls.c: Renamed global_initialized to
1155 gnutls_global_initialized. Added internals for the
1156 :verify-hostname-error, :verify-error, and :verify-flags
1157 parameters of `gnutls-boot' and documented those parameters in the
1158 docstring. Start callback support.
1159 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1160 unless a fatal error occured. Call gnutls_alert_send_appropriate
1161 on error. Return error code.
1162 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1163 (emacs_gnutls_read): Likewise.
1164 (Fgnutls_boot): Return handshake error code.
1165 (emacs_gnutls_handle_error): New function.
1166 (wsaerror_to_errno): Likewise.
1167
1168 * w32.h (emacs_gnutls_pull): Add prototype.
1169 (emacs_gnutls_push): Likewise.
1170
1171 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1172 (emacs_gnutls_push): Likewise.
1173
1174 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1175
1176 * process.c (wait_reading_process_output): Check if GnuTLS
1177 buffered some data internally if no FDs are set for TLS
1178 connections.
1179
1180 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1181 (LIBS): Link to USER_LIBS.
1182 ($(BLD)/gnutls.$(0)): New target.
1183
1184 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1185
1186 * xdisp.c (handle_single_display_spec): Rename the
1187 display_replaced_before_p argument into display_replaced_p, to
1188 make it consistent with the commentary. Fix typos in the
1189 commentary.
1190
1191 * textprop.c (syms_of_textprop): Remove dead code.
1192 (copy_text_properties): Delete obsolete commentary about an
1193 interface that was deleted long ago. Fix typos in the description
1194 of arguments.
1195
1196 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1197 to changes in oldXMenu/XMenu.h from 2011-04-16.
1198 <menu_help_message, prev_menu_help_message>: Constify.
1199 (IT_menu_make_room): menu->help_text is now `const char **';
1200 adjust.
1201
1202 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1203 to changes in oldXMenu/XMenu.h from 2011-04-16.
1204 (struct XMenu): Declare `help_text' `const char **'.
1205
1206 * xfaces.c <Qunspecified>: Make extern again.
1207
1208 * syntax.c: Include sys/types.h before including regex.h, as
1209 required by Posix.
1210
1211 * doc.c (get_doc_string): Improve the format passed to `error'.
1212
1213 * doprnt.c (doprnt): Improve commentary.
1214
1215 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1216
1217 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1218 them with etags.
1219
1220 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1221 changes in globals.h immediately force recompilation.
1222 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1223 $(CURDIR)/s/ms-w32.h.
1224 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1225
1226 * character.c (Fchar_direction): Function deleted.
1227 (syms_of_character): Don't defsubr it.
1228 <char-direction-table>: Deleted.
1229
1230 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1231
1232 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1233 * doprnt.c: Include limits.h.
1234 (SIZE_MAX): New macro.
1235 (doprnt): Return a size_t value. 2nd arg is now size_t.
1236 Many local variables are now size_t instead of int or unsigned.
1237 Improve overflow protection. Support `l' modifier for integer
1238 conversions. Support %l conversion. Don't assume an EMACS_INT
1239 argument for integer conversions and for %c.
1240
1241 * lisp.h (doprnt): Restore prototype.
1242
1243 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1244 $(SRC)/character.h.
1245
1246 * Makefile.in (base_obj): Add back doprnt.o.
1247
1248 * deps.mk (doprnt.o): Add back prerequisites.
1249 (callint.o): Depend on character.h.
1250
1251 * eval.c (internal_lisp_condition_case): Include the handler
1252 representation in the error message.
1253 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1254 when breaking from the loop.
1255
1256 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1257
1258 * callint.c (Fcall_interactively): When displaying error message
1259 about invalid control letter, pass the character's codepoint, not
1260 a pointer to its multibyte form. Improve display of the character
1261 in octal and display also its hex code.
1262
1263 * character.c (char_string): Use %x to display the (unsigned)
1264 codepoint of an invalid character, to avoid displaying a bogus
1265 negative value.
1266
1267 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1268 `error', not SYMBOL_NAME itself.
1269
1270 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1271 character arguments to `error'.
1272
1273 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1274 to `error' in error message about FINAL_CHAR argument. Make sure
1275 FINAL_CHAR is a character, and use %c when it is passed as
1276 argument to `error'.
1277
1278 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1279
1280 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1281
1282 * w32.c: Include <time.h>.
1283 (sys_localtime): New function.
1284
1285 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1286
1287 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1288
1289 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1290
1291 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1292
1293 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1294 zombies (Bug#8467).
1295
1296 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1297
1298 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1299 gl_state.e_property when gl_state.object is Qt.
1300
1301 * insdel.c (make_gap_larger): Remove limitation of buffer size
1302 to <= INT_MAX.
1303
1304 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1305
1306 * xdisp.c (lookup_glyphless_char_display)
1307 (produce_glyphless_glyph): Handle cons cell entry in
1308 glyphless-char-display.
1309 (Vglyphless_char_display): Document it.
1310
1311 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1312 glyphless-char-display.
1313
1314 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1315
1316 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1317
1318 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1319
1320 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1321 definition for no-X builds.
1322
1323 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 Static checks with GCC 4.6.0 and non-default toolkits.
1326
1327 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1328
1329 * process.c (keyboard_bit_set): Define only if SIGIO.
1330 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1331 (send_process): Repair possible setjmp clobbering.
1332
1333 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1334
1335 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1336
1337 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1338
1339 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1340 Define only if needed.
1341
1342 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1343 by pacifying GCC about it. Maybe it's time to retire it?
1344 * xfaces.c (USG, __TIMEVAL__): Likewise.
1345
1346 * dispextern.h (struct redisplay_interface): Rename param
1347 to avoid shadowing.
1348 * termhooks.h (struct terminal): Likewise.
1349 * xterm.c (xembed_send_message): Likewise.
1350
1351 * insdel.c (make_gap_smaller): Define only if
1352 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1353
1354 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1355 it.
1356
1357 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1358 so that we aren't warned about unused symbols.
1359
1360 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1361
1362 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1363
1364 * xfns.c (x_real_positions): Mark locals as initialized.
1365
1366 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1367
1368 * xterm.c: Fix problems found by static analysis with other toolkits.
1369 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1370 (x_dispatch_event): Declare static if USE_GTK, and
1371 define if USE_GTK || USE_X_TOOLKIT.
1372 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1373 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1374 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1375 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1376
1377 * xmenu.c (menu_help_callback): Pointer type fixes.
1378 Use const pointers when pointing at readonly data. Avoid pointer
1379 signedness clashes.
1380 (FALSE): Remove unused macro.
1381 (update_frame_menubar): Remove unused decl.
1382
1383 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1384
1385 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1386 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1387 (single_menu_item): Rename local to avoid shadowing.
1388
1389 * keyboard.c (make_lispy_event): Remove unused local var.
1390
1391 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1392 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1393
1394 * bitmaps: Change bitmaps from unsigned char back to the X11
1395 compatible char. Avoid the old compiler warnings about
1396 out-of-range initializers by using, for example, '\xab' rather
1397 than 0xab.
1398
1399 * xgselect.c (xgselect_initialize): Check vs interface
1400 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1401
1402 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1403
1404 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1405 to read-only memory.
1406
1407 * fns.c (vector): Remove; this old hack is no longer needed.
1408
1409 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1410 Remove unused var.
1411 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1412
1413 * xrdb.c (x_load_resources): Omit unused local.
1414
1415 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1416 (x_window): Rename locals to avoid shadowing.
1417 (USG): Use the kludged USG macro, to pacify gcc.
1418
1419 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1420 (x_term_init): Remove local to avoid shadowing.
1421
1422 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1423
1424 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1425 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1426
1427 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1428
1429 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1430
1431 Fix regex.c, syntax.c and friends for buffers > 2GB.
1432 * syntax.h (struct gl_state_s): Declare character position members
1433 EMACS_INT.
1434
1435 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1436
1437 * textprop.c (verify_interval_modification, interval_of):
1438 Declare arguments EMACS_INT.
1439
1440 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1441 EMACS_INT.
1442
1443 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1444
1445 * indent.c (Fvertical_motion): Local variable it_start is now
1446 EMACS_INT.
1447
1448 * regex.c (re_match, re_match_2, re_match_2_internal)
1449 (bcmp_translate, regcomp, regexec, print_double_string)
1450 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1451 (re_compile_pattern, re_exec): Declare arguments and local
1452 variables `size_t' and `ssize_t' and return values `regoff_t', as
1453 appropriate.
1454 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1455 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1456 <compile_stack_type>: `size' and `avail' are now `size_t'.
1457
1458 * regex.h <regoff_t>: Use ssize_t, not int.
1459 (re_search, re_search_2, re_match, re_match_2): Arguments that
1460 specify buffer/string position and length are now ssize_t and
1461 size_t. Return type is regoff_t.
1462
1463 2011-04-16 Ben Key <bkey76@gmail.com>
1464
1465 * nsfont.m: Fixed bugs in ns_get_family and
1466 ns_descriptor_to_entity that were caused by using free to
1467 deallocate memory blocks that were allocated by xmalloc (via
1468 xstrdup). This caused Emacs to crash when compiled with
1469 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1470 --enable-checking=xmallocoverrun). xfree is now used to
1471 deallocate these memory blocks.
1472
1473 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1474
1475 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1476
1477 emacs_write: Accept and return EMACS_INT for sizes.
1478 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1479 et seq.
1480 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1481 Accept and return EMACS_INT.
1482 (emacs_gnutls_write): Return the number of bytes written on
1483 partial writes.
1484 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1485 (emacs_read, emacs_write): Remove check for negative size, as the
1486 Emacs source code has been audited now.
1487 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1488 (emacs_read, emacs_write): Use it.
1489 * process.c (send_process): Adjust to the new signatures of
1490 emacs_write and emacs_gnutls_write. Do not attempt to store
1491 a byte offset into an 'int'; it might overflow.
1492 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1493
1494 * sound.c: Don't assume sizes fit in 'int'.
1495 (struct sound_device.period_size, alsa_period_size):
1496 Return EMACS_INT, not int.
1497 (struct sound_device.write, vox_write, alsa_write):
1498 Accept EMACS_INT, not int.
1499 (wav_play, au_play): Use EMACS_INT to store sizes and to
1500 record read return values.
1501
1502 2011-04-15 Ben Key <bkey76@gmail.com>
1503
1504 * keyboard.c (Qundefined): Don't declare static since it is used
1505 in nsfns.m.
1506 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1507 static since they are used in nsfont.m.
1508
1509 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1510
1511 * process.c (Qprocessp): Don't declare static.
1512 * lisp.h (Qprocessp): Declare again.
1513
1514 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1515
1516 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1517
1518 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 Improve C-level modularity by making more things 'static'.
1521
1522 Don't publish debugger-only interfaces to other modules.
1523 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1524 (verify_bytepos, count_markers): Move decls to the only modules
1525 that need them.
1526 * region-cache.h (pp_cache): Likewise.
1527 * window.h (check_all_windows): Likewise.
1528 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1529
1530 * sysdep.c (croak): Now static, if
1531 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1532 * syssignal.h (croak): Declare only if not static.
1533
1534 * alloc.c (refill_memory_reserve): Now static if
1535 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1536 * lisp.h (refill_memory_reserve): Declare only if not static.
1537
1538 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1539 Define only if USE_LUCID.
1540
1541 * xrdb.c (x_customization_string, x_rm_string): Now static.
1542
1543 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1544 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1545
1546 * xdisp.c (draw_row_with_mouse_face): Now static.
1547 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1548
1549 * window.h (check_all_windows): Mark externally visible.
1550
1551 * window.c (window_deletion_count): Now static.
1552
1553 * undo.c: Make symbols static if they're not exported.
1554 (last_undo_buffer, last_boundary_position, pending_boundary):
1555 Now static.
1556
1557 * textprop.c (interval_insert_behind_hooks): Now static.
1558 (interval_insert_in_front_hooks): Likewise.
1559
1560 * term.c: Make symbols static if they're not exported.
1561 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1562 (max_frame_lines, tty_set_terminal_modes):
1563 (tty_reset_terminal_modes, tty_turn_off_highlight):
1564 (get_tty_terminal): Now static.
1565 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1566 * termhooks.h (term_mouse_moveto): Do not declare if
1567 HAVE_WINDOW_SYSTEM.
1568 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1569 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1570
1571 * sysdep.c: Make symbols static if they're not exported.
1572 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1573 Now static.
1574 (sigprocmask_set, full_mask): Remove; unused.
1575 (wait_debugging): Mark as visible.
1576 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1577 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1578
1579 * syntax.c (syntax_temp): Define only if !__GNUC__.
1580
1581 * sound.c (current_sound_device, current_sound): Now static.
1582
1583 * search.c (searchbufs, searchbuf_head): Now static.
1584
1585 * scroll.c (scroll_cost): Remove; unused.
1586 * dispextern.h (scroll_cost): Remove decl.
1587
1588 * region-cache.h (pp_cache): Mark as externally visible.
1589
1590 * process.c: Make symbols static if they're not exported.
1591 (process_tick, update_tick, create_process, chan_process):
1592 (Vprocess_alist, proc_buffered_char, datagram_access):
1593 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1594 (deactivate_process): Mark defn as static, as well as decl.
1595 * lisp.h (create_process): Remove decl.
1596 * process.h (chan_process, Vprocess_alist): Remove decls.
1597
1598 * print.c: Make symbols static if they're not exported.
1599 (print_depth, new_backquote_output, being_printed, print_buffer):
1600 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1601 (print_interval, print_number_index, initial_stderr_stream):
1602 Now static.
1603 * lisp.h (Fprinc): Remove decl.
1604 (debug_output_compilation_hack): Mark as externally visible.
1605
1606 * sysdep.c (croak): Move decl from here to syssignal.h.
1607 * syssignal.h (croak): Put it here, so the API can be checked when
1608 'croak' is called from dissociate_if_controlling_tty.
1609
1610 * minibuf.c: Make symbols static if they're not exported.
1611 (minibuf_save_list, choose_minibuf_frame): Now static.
1612 * lisp.h (choose_minibuf_frame): Remove decl.
1613
1614 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1615
1616 * lread.c: Make symbols static if they're not exported.
1617 (read_objects, initial_obarray, oblookup_last_bucket_number):
1618 Now static.
1619 (make_symbol): Remove; unused.
1620 * lisp.h (initial_obarray, make_symbol): Remove decls.
1621
1622 * keyboard.c: Make symbols static if they're not exported.
1623 (single_kboard, recent_keys_index, total_keys, recent_keys):
1624 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1625 (this_single_command_key_start, echoing, last_auto_save):
1626 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1627 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1628 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1629 (Vlispy_mouse_stem, double_click_count):
1630 Now static.
1631 (force_auto_save_soon): Define only if SIGDANGER.
1632 (ignore_mouse_drag_p): Now static if
1633 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1634 (print_help): Remove; unused.
1635 (stop_character, last_timer_event): Mark as externally visible.
1636 * keyboard.h (ignore_mouse_drag_p): Declare only if
1637 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1638 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1639 * lisp.h (echoing): Remove decl.
1640 (force_auto_save_soon): Declare only if SIGDANGER.
1641 * xdisp.c (redisplay_window): Simplify code, to make it more
1642 obvious that ignore_mouse_drag_p is not accessed if !defined
1643 USE_GTK && !defined HAVE_NS.
1644
1645 * intervals.c: Make symbols static if they're not exported.
1646 (merge_properties_sticky, merge_interval_right, delete_interval):
1647 Now static.
1648 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1649
1650 * insdel.c: Make symbols static if they're not exported.
1651 However, leave prepare_to_modify_buffer alone. It's never
1652 called from outside this function, but that appears to be a bug.
1653 (combine_after_change_list, combine_after_change_buffer):
1654 (adjust_after_replace, signal_before_change): Now static.
1655 (adjust_after_replace_noundo): Remove; unused.
1656 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1657 (signal_before_change): Remove decls.
1658
1659 * indent.c (val_compute_motion, val_vmotion): Now static.
1660
1661 * image.c: Make symbols static if they're not exported.
1662 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1663 if USE_GTK.
1664 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1665 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1666
1667 * fringe.c (standard_bitmaps): Now static.
1668 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1669
1670 * frame.c: Make symbols static if they're not exported.
1671 (x_report_frame_params, make_terminal_frame): Now static.
1672 (get_frame_param): Now static, unless HAVE_NS.
1673 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1674 (x_get_resource_string): Remove; not used.
1675 * frame.h (make_terminal_frame, x_report_frame_params):
1676 (x_get_resource_string); Remove decls.
1677 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1678 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1679
1680 * font.c, fontset.c: Make symbols static if they're not exported.
1681 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1682 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1683 * font.c (font_close_object): Now static.
1684 * font.h (font_close_object): Remove.
1685 * fontset.c (FONTSET_OBJLIST): Remove.
1686 (free_realized_fontset) #if-0 the body, which does nothing.
1687 (face_suitable_for_char_p): #if-0, as it's never called.
1688 * fontset.h (face_suitable_for_char_p): Remove decl.
1689 * xfaces.c (face_at_string_position):
1690 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1691 since 0 is always ASCII.
1692
1693 * fns.c (weak_hash_tables): Now static.
1694
1695 * fileio.c: Make symbols static if they're not exported.
1696 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1697 (Vwrite_region_annotation_buffers): Now static.
1698
1699 * eval.c: Make symbols static if they're not exported.
1700 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1701 * lisp.h (backtrace_list): Remove decl.
1702
1703 * emacs.c: Make symbols static if they're not exported.
1704 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1705 (fatal_error_code, fatal_error_signal_hook, standard_args):
1706 Now static.
1707 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1708 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1709 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1710 * lisp.h (fatal_error_signal_hook): Remove decl.
1711 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1712
1713 * editfns.c: Move a (normally-unused) function to its only use.
1714 * editfns.c, lisp.h (get_operating_system_release): Remove.
1715 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1716 worth the hassle of breaking this out.
1717
1718 * xterm.c: Make symbols static if they're not exported.
1719 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1720 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1721 (x_destroy_window, x_delete_display):
1722 Now static.
1723 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1724 (x_mouse_leave): Remove; unused.
1725 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1726 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1727 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1728 Remove decls.
1729 (x_mouse_leave): Declare only if WINDOWSNT.
1730 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1731 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1732 USE_X_TOOLKIT.
1733
1734 * ftxfont.c: Make symbols static if they're not exported.
1735 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1736 HAVE_FREETYPE.
1737 * font.h (ftxfont_driver): Likewise.
1738
1739 * xfns.c: Make symbols static if they're not exported.
1740 (x_last_font_name, x_display_info_for_name):
1741 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1742 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1743 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1744 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1745 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1746 (last_show_tip_args): Now static.
1747 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1748 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1749 (x_screen_planes): Remove; unused.
1750 * dispextern.h (x_screen_planes): Remove decl.
1751
1752 * dispnew.c: Make symbols static if they're not exported.
1753 * dispextern.h (redraw_garbaged_frames, scrolling):
1754 (increment_row_positions): Remove.
1755 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1756 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1757 Now static.
1758 (redraw_garbaged_frames): Remove; unused.
1759
1760 * xfaces.c: Make symbols static if they're not exported.
1761 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1762 Remove decls.
1763 * xterm.h (defined_color): Remove decls.
1764 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1765 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1766 (menu_face_changed_default, defined_color, free_realized_face):
1767 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1768 (ascii_face_of_lisp_face): Remove; unused.
1769
1770 * xdisp.c: Make symbols static if they're not exported.
1771 * dispextern.h (scratch_glyph_row, window_box_edges):
1772 (glyph_to_pixel_coords, set_cursor_from_row):
1773 (get_next_display_element, set_iterator_to_next):
1774 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1775 (show_mouse_face): Remove decls
1776 * frame.h (message_buf_print): Likewise.
1777 * lisp.h (pop_message, set_message, check_point_in_composition):
1778 Likewise.
1779 * xterm.h (set_vertical_scroll_bar): Likewise.
1780 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1781 (message_buf_print, scratch_glyph_row, displayed_buffer):
1782 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1783 (get_next_display_element, show_mouse_face, window_box_edges):
1784 (frame_to_window_pixel_xy, check_point_in_composition):
1785 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1786 (glyph_to_pixel_coords): Remove; unused.
1787
1788 * dired.c (file_name_completion): Now static.
1789
1790 * dbusbind.c (xd_in_read_queued_messages): Now static.
1791
1792 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1793 * data.c (circular_list_error): Remove.
1794
1795 * commands.h (last_point_position, last_point_position_buffer):
1796 (last_point_position_window): Remove decls.
1797 * keyboard.c: Make these variables static.
1798
1799 * coding.h (coding, code_convert_region, encode_coding_gap):
1800 Remove decls.
1801 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1802 (iso_code_class, detect_coding, code_convert_region): Now static.
1803 (encode_coding_gap): Remove; unused.
1804
1805 * chartab.c (chartab_chars, chartab_bits): Now static.
1806
1807 * charset.h (charset_iso_8859_1): Remove decl.
1808 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1809 Now static.
1810
1811 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1812 * ccl.c (Vccl_program_table): Now static.
1813 (check_ccl_update): Remove; unused.
1814
1815 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1816 * category.h: ... from here.
1817 * category.c (check_category_table, set_category_set): Now static.
1818
1819 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1820 * lisp.h: Remove these decls.
1821
1822 * buffer.c (buffer_count): Remove unused var.
1823
1824 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1825 so that it's not optimized away.
1826 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1827 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1828 exported only to the debugger.
1829
1830 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1831 * atimer.h (run_all_atimers): Remove; not exported.
1832
1833 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1834 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1835 was inaccessible from Lisp.
1836 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1837 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1838
1839 alloc.c: Import and export fewer symbols, and remove unused items.
1840 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1841 is defined.
1842 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1843 it's not optimized away by whole-program optimization.
1844 (message_enable_multibyte, free_misc): Remove.
1845 (catchlist, handlerlist, mark_backtrace):
1846 Declare only if BYTE_MARK_STACK.
1847 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1848 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1849 (message_enable_multibyte): Remove decl.
1850 (free_misc, interval_free_list, float_block, float_block_index):
1851 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1852 (cons_free_list, last_marked_index):
1853 Now static.
1854 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1855 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1856 (mark_backtrace): Define only if BYTE_MARK_STACK.
1857 * xdisp.c (message_enable_multibyte): Now static.
1858
1859 Declare Lisp_Object Q* variables to be 'static' if not exported.
1860 This makes it easier for human readers (and static analyzers)
1861 to see whether these variables are used from other modules.
1862 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1863 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1864 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1865 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1866 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1867 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1868 * xmenu.c, xselect.c:
1869 Declare Q* vars static if they are not used in other modules.
1870 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1871 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1872 Remove decls of unexported vars.
1873 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1874
1875 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1876
1877 Make Emacs functions such as Fatom 'static' by default.
1878 This makes it easier for human readers (and static analyzers)
1879 to see whether these functions can be called from other modules.
1880 DEFUN now defines a static function. To make the function external
1881 so that it can be used in other C modules, use the new macro DEFUE.
1882 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1883 (Finit_image_library):
1884 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1885 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1886 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1887 Remove decls, since these functions are now static.
1888 (Funintern, Fget_internal_run_time): New decls, since these functions
1889 were already external.
1890
1891 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1892 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1893 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1894 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1895 * keyboard.c, keymap.c, lread.c:
1896 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1897 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1898 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1899 Mark functions with DEFUE instead of DEFUN,
1900 if they are used in other modules.
1901 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1902 decls for now-static functions.
1903 * buffer.h (Fdelete_overlay): Remove decl.
1904 * callproc.c (Fgetenv_internal): Mark as internal.
1905 * composite.c (Fremove_list_of_text_properties): Remove decl.
1906 (Fcomposition_get_gstring): New forward static decl.
1907 * composite.h (Fcomposite_get_gstring): Remove decl.
1908 * dired.c (Ffile_attributes): New forward static decl.
1909 * doc.c (Fdocumntation_property): New forward static decl.
1910 * eval.c (Ffetch_bytecode): New forward static decl.
1911 (Funintern): Remove extern decl; now in .h file where it belongs.
1912 * fileio.c (Fmake_symbolic_link): New forward static decl.
1913 * image.c (Finit_image_library): New forward static decl.
1914 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1915 * intervals.h (Fprevious_property_change):
1916 (Fremove_list_of_text_properties): Remove decls.
1917 * keyboard.c (Fthis_command_keys): Remove decl.
1918 (Fcommand_execute): New forward static decl.
1919 * keymap.c (Flookup_key): New forward static decl.
1920 (Fcopy_keymap): Now static.
1921 * keymap.h (Flookup_key): Remove decl.
1922 * process.c (Fget_process): New forward static decl.
1923 (Fprocess_datagram_address): Mark as internal.
1924 * syntax.c (Fsyntax_table_p): New forward static decl.
1925 (skip_chars): Remove duplicate decl.
1926 * textprop.c (Fprevious_property_change): New forward static decl.
1927 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1928 Now internal.
1929 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1930 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1931
1932 * editfns.c (Fformat): Remove unreachable code.
1933
1934 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1935
1936 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1937 change. (Bug#8496)
1938
1939 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1940
1941 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1942 when at ZV. (Bug#8487)
1943
1944 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1945
1946 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1947 (Bug#8437)
1948 * keyboard.c (parse_tool_bar_item): Likewise.
1949 * sound.c (sound_cleanup, alsa_close): Likewise.
1950 * termcap.c (tgetent): Likewise.
1951 * xfns.c (x_default_font_parameter): Likewise.
1952 * xsettings.c (read_and_apply_settings): Likewise.
1953
1954 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1955 (overrun_check_free): Protoize.
1956
1957 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1958
1959 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1960 since callers should never pass a negative size.
1961 Change the signature to match that of plain 'read' and 'write'; see
1962 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1963 * lisp.h: Update prototypes of emacs_write and emacs_read.
1964
1965 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1966
1967 * xdisp.c (redisplay_window): Don't try to determine the character
1968 position of the scroll margin if the window start point w->startp
1969 is outside the buffer's accessible region. (Bug#8468)
1970
1971 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1972
1973 Fix write-region and its subroutines for buffers > 2GB.
1974 * fileio.c (a_write, e_write): Modify declaration of arguments and
1975 local variables to support buffers larger than 2GB.
1976 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1977
1978 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1979 argument, local variables, and return value.
1980
1981 * lisp.h: Update prototypes of emacs_write and emacs_read.
1982
1983 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1984
1985 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1988
1989 Fix more problems found by GCC 4.6.0's static checks.
1990
1991 * xdisp.c (vmessage): Use a better test for character truncation.
1992
1993 * charset.c (load_charset_map): <, not <=, for optimization,
1994 and to avoid potential problems with integer overflow.
1995 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1996 * casetab.c (set_identity, shuffle): Likewise.
1997 * editfns.c (Fformat): Likewise.
1998 * syntax.c (skip_chars): Likewise.
1999
2000 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2001 This also lets GCC 4.6.0 generate slightly better loop code.
2002
2003 * callint.c (Fcall_interactively): <, not <=, for optimization.
2004 (Fcall_interactively): Count the number of arguments produced,
2005 not the number of arguments given. This is simpler and lets GCC
2006 4.6.0 generate slightly better code.
2007
2008 * ftfont.c: Distingish more carefully between FcChar8 and char.
2009 The previous code passed unsigned char * to a functions like
2010 strlen and xstrcasecmp that expect char *, which does not
2011 conform to the C standard.
2012 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2013 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2014 char * when the C standard requires it.
2015
2016 * keyboard.c (read_char): Remove unused var.
2017
2018 * eval.c: Port to Windows vsnprintf (Bug#8435).
2019 Include <limits.h>.
2020 (SIZE_MAX): Define if the headers do not.
2021 (verror): Do not give up if vsnprintf returns a negative count.
2022 Instead, grow the buffer. This ports to Windows vsnprintf, which
2023 does not conform to C99. Problem reported by Eli Zaretskii.
2024 Also, simplify the allocation scheme, by avoiding the need for
2025 calling realloc, and removing the ALLOCATED variable.
2026
2027 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2028
2029 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2030 But keep the doprint source code for now, as we might revamp it
2031 and use it again (Bug#8435).
2032 * lisp.h (doprnt): Remove.
2033 * Makefile.in (base_obj): Remove doprnt.o.
2034 * deps.mk (doprnt.o): Remove.
2035
2036 error: Print 32- and 64-bit integers portably (Bug#8435).
2037 Without this change, on typical 64-bit hosts error ("...%d...", N)
2038 was used to print both 32- and 64-bit integers N, which relied on
2039 undefined behavior.
2040 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2041 New macro.
2042 * lisp.h (error, verror): Mark as printf-like functions.
2043 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2044 Report overflow in size calculations when allocating printf buffer.
2045 Do not truncate output string at its first null byte.
2046 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2047 Truncate the output at a character boundary, since vsnprintf does not
2048 do that.
2049 * charset.c (check_iso_charset_parameter): Convert internal
2050 character to string before calling 'error', since %c now has the
2051 printf meaning.
2052 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2053 overflow when computing char to be passed to 'error'. Do not
2054 pass Lisp_Object to 'error'; pass the integer instead.
2055 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2056 formatted with plain %d.
2057
2058 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2059
2060 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2061
2062 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2063
2064 * xterm.c (x_catch_errors): Remove duplicate declaration.
2065
2066 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2067
2068 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2069
2070 2011-04-10 Jim Meyering <meyering@redhat.com>
2071
2072 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2073 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2074 return ssize_t not "int", and use size_t as the buffer length.
2075 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2076 * gnutls.h: Update declarations.
2077 * process.c (read_process_output): Use ssize_t, to match.
2078 (send_process): Likewise.
2079
2080 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2081
2082 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2083
2084 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2085
2086 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2087 Use unsigned char, to match FcChar8 type definition.
2088
2089 * xterm.c (handle_one_xevent):
2090 * xmenu.c (create_and_show_popup_menu):
2091 * xselect.c (x_decline_selection_request)
2092 (x_reply_selection_request): Avoid type-punned deref of X events.
2093
2094 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2095
2096 Fix some uses of `int' instead of EMACS_INT.
2097 * search.c (string_match_1, fast_string_match)
2098 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2099 (scan_buffer, find_next_newline_no_quit)
2100 (find_before_next_newline, search_command, Freplace_match)
2101 (Fmatch_data): Make some `int' variables be EMACS_INT.
2102
2103 * xdisp.c (display_count_lines): 3rd argument and return value now
2104 EMACS_INT. All callers changed.
2105 (pint2hrstr): Last argument is now EMACS_INT.
2106
2107 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2108 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2109 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2110 (decode_coding_utf_16, decode_coding_emacs_mule)
2111 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2112 (decode_coding_ccl, decode_coding_charset)
2113 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2114 (decode_coding_iso_2022, decode_coding_emacs_mule)
2115 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2116 <char_offset, last_offset>: Declare EMACS_INT.
2117 (encode_coding_utf_8, encode_coding_utf_16)
2118 (encode_coding_emacs_mule, encode_invocation_designation)
2119 (encode_designation_at_bol, encode_coding_iso_2022)
2120 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2121 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2122 Declare EMACS_INT.
2123 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2124 (encode_invocation_designation): Last argument P_NCHARS is now
2125 EMACS_INT.
2126 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2127 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2128
2129 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2130 All users changed.
2131
2132 * ccl.c (Fccl_execute_on_string): Declare some variables
2133 EMACS_INT.
2134
2135 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2136
2137 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2138
2139 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2140
2141 * process.c (Fformat_network_address): Doc fix.
2142
2143 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2144
2145 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2146
2147 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2148
2149 * keyboard.c (read_char): Call Lisp function help-form-show,
2150 instead of using internal_with_output_to_temp_buffer.
2151 (Qhelp_form_show): New var.
2152 (syms_of_keyboard): Use DEFSYM macro.
2153
2154 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2155
2156 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2157
2158 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2159
2160 * process.c (Flist_processes): Remove to Lisp.
2161 (list_processes_1): Delete.
2162
2163 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2164
2165 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2166
2167 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2168
2169 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 Fix more problems found by GCC 4.6.0's static checks.
2172
2173 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2174
2175 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2176
2177 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2178
2179 * xdisp.c (vmessage): Mark as a printf-like function.
2180
2181 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2182
2183 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2184
2185 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2186 printf-like functions.
2187 (tiff_load): Add casts to remove these marks before passing them
2188 to system-supplied API.
2189
2190 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2191
2192 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2193 This avoids several warnings with gcc -Wstrict-overflow.
2194 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2195 directly, rather than having caller test rule sign. This avoids
2196 some unnecessary tests.
2197 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2198 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2199 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2200
2201 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2202 (xfont_open): Avoid unnecessary tests.
2203
2204 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2205
2206 * composite.h, composite.c (composition_gstring_put_cache):
2207 Use EMACS_INT, not int, for length.
2208
2209 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2210 breaking out part of COMPOSITION_DECODE_RULE.
2211 (COMPOSITION_DECODE_RULE): Use it.
2212 * composite.c (get_composition_id): Remove unused local vars,
2213 by using the new macro.
2214
2215 * textprop.c (set_text_properties_1): Change while to do-while,
2216 since the condition is always true at first.
2217
2218 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2219 (interval_deletion_adjustment): Return unsigned value.
2220 All uses changed.
2221
2222 * process.c (list_processes_1, create_pty, read_process_output):
2223 (exec_sentinel): Remove vars that were set but not used.
2224 (create_pty): Remove unnecessary "volatile"s.
2225 (Fnetwork_interface_info): Avoid possibility of int overflow.
2226 (read_process_output): Do adaptive read buffering even if carryover.
2227 (read_process_output): Simplify nbytes computation if buffered.
2228
2229 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2230
2231 * syntax.c (scan_words): Remove var that was set but not used.
2232 (update_syntax_table): Use unsigned instead of int.
2233
2234 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2235 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2236 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2237
2238 * print.c (print_error_message): Avoid int overflow.
2239
2240 * font.c (font_list_entities): Redo for clarity,
2241 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2242
2243 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2244 (font_score): Avoid potential overflow in diff calculation.
2245
2246 * fns.c (substring_both): Remove var that is set but not used.
2247 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2248
2249 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2250
2251 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2252 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2253 can always succeed if overflow has undefined behavior.
2254
2255 * search.c (boyer_moore, wordify): Remove vars set but not used.
2256 (wordify): Omit three unnecessary tests.
2257
2258 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2259 All callers changed. This avoids the need for an unused var.
2260
2261 * casefiddle.c (casify_region): Remove var that is set but not used.
2262
2263 * dired.c (file_name_completion): Remove var that is set but not used.
2264
2265 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2266
2267 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2268 (Finsert_file_contents): Remove unnecessary code checking fd.
2269
2270 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2271 Check for integer overflow on size calculations.
2272
2273 * buffer.c (Fprevious_overlay_change): Remove var that is set
2274 but not used.
2275
2276 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2277 Remove vars that are set but not used.
2278 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2279 (timer_check_2): Mark vars as initialized.
2280
2281 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2282
2283 * image.c (lookup_image): Remove var that is set but not used.
2284 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2285
2286 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2287 that are set but not used.
2288
2289 * xfns.c (make_invisible_cursor): Don't return garbage
2290 if XCreateBitmapFromData fails (Bug#8410).
2291
2292 * xselect.c (x_get_local_selection, x_handle_property_notify):
2293 Remove vars that are set but not used.
2294
2295 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2296 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2297
2298 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2299 Remove var that is set but not used.
2300 (scroll_bar_windows_size): Now size_t, not int.
2301 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2302 Check for overflow.
2303
2304 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2305 (map_tty_color) [!defined MSDOS]: Likewise.
2306
2307 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2308
2309 * coding.c: Remove vars that are set but not used.
2310 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2311 All callers changed.
2312 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2313 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2314 (decode_coding_charset): Remove vars that are set but not used.
2315
2316 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2317 that is set but not used.
2318
2319 * print.c (print_object): Remove var that is set but not used.
2320
2321 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2322 The gnulib version avoids calling malloc in the usual case,
2323 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2324 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2325 * filelock.c (current_lock_owner): Likewise.
2326 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2327 * sysdep.c: Include allocator.h, careadlinkat.h.
2328 (emacs_no_realloc_allocator): New static constant.
2329 (emacs_readlink): New function.
2330 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2331 ../lib/careadlinkat.h.
2332
2333 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2334
2335 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2336 first non-nil return value).
2337
2338 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2339
2340 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2341 if not defined (Bug#8403).
2342
2343 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2344
2345 * xdisp.c (display_count_lines): Remove parameter `start',
2346 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2347 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2348 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2349 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2350 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2351 and thereabouts. All callers changed.
2352 (get_per_char_metric): Remove parameter `f', unused since
2353 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2354
2355 2011-04-02 Jim Meyering <meyering@redhat.com>
2356
2357 do not dereference NULL upon failed strdup
2358 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2359 (ns_get_family): Likewise.
2360
2361 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2362
2363 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2364
2365 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2366
2367 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2368 later (Bug#8403).
2369
2370 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2371
2372 Add lexical binding.
2373
2374 * window.c (Ftemp_output_buffer_show): New fun.
2375 (Fsave_window_excursion):
2376 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2377
2378 * lread.c (lisp_file_lexically_bound_p): New function.
2379 (Fload): Bind Qlexical_binding.
2380 (readevalloop): Remove `evalfun' arg.
2381 Bind Qinternal_interpreter_environment.
2382 (Feval_buffer): Bind Qlexical_binding.
2383 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2384 Mark as dynamic.
2385 (syms_of_lread): Declare `lexical-binding'.
2386
2387 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2388
2389 * keyboard.c (eval_dyn): New fun.
2390 (menu_item_eval_property): Use it.
2391
2392 * image.c (parse_image_spec): Use Ffunctionp.
2393
2394 * fns.c (concat, mapcar1): Accept byte-code-functions.
2395
2396 * eval.c (Fsetq): Handle lexical vars.
2397 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2398 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2399 (FletX, Flet): Obey lexical binding.
2400 (Fcommandp): Handle closures.
2401 (Feval): New `lexical' arg.
2402 (eval_sub): New function extracted from Feval. Use it almost
2403 everywhere where Feval was used. Look up vars in lexical env.
2404 Handle closures.
2405 (Ffunctionp): Move from subr.el.
2406 (Ffuncall): Handle closures.
2407 (apply_lambda): Remove `eval_flags'.
2408 (funcall_lambda): Handle closures and new byte-code-functions.
2409 (Fspecial_variable_p): New function.
2410 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2411 but without exporting it to Lisp.
2412
2413 * doc.c (Fdocumentation, store_function_docstring):
2414 * data.c (Finteractive_form): Handle closures.
2415
2416 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2417 interactive spec.
2418
2419 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2420 New byte-codes.
2421 (exec_byte_code): New function extracted from Fbyte_code to handle new
2422 calling convention for byte-code-functions. Add new byte-codes.
2423
2424 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2425
2426 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2427
2428 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2429
2430 * xdisp.c (redisplay_internal): Fix prototype.
2431
2432 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2433
2434 * xdisp.c (SCROLL_LIMIT): New macro.
2435 (try_scrolling): Use it when setting scroll_limit.
2436 Limit scrolling to 100 screen lines.
2437 (redisplay_window): Even when falling back on "recentering",
2438 position point in the window according to scroll-conservatively,
2439 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2440
2441 (try_scrolling): When point is above the window, allow searching
2442 as far as scroll_max, or one screenful, to compute vertical
2443 distance from PT to the scroll margin position. This prevents
2444 try_scrolling from unnecessarily failing when
2445 scroll-conservatively is set to a value slightly larger than the
2446 window height. Clean up the case of PT below the margin at bottom
2447 of window: scroll_max can no longer be INT_MAX. When aggressive
2448 scrolling is in use, don't let point enter the opposite scroll
2449 margin as result of the scroll.
2450 (syms_of_xdisp) <scroll-conservatively>: Document the
2451 threshold of 100 lines for never-recentering scrolling.
2452
2453 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2454
2455 * dispextern.h (move_it_by_lines):
2456 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2457 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2458 (message_log_check_duplicate): Remove parameters `prev_bol' and
2459 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2460 (redisplay_internal): Remove parameter `preserve_echo_area',
2461 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2462
2463 * indent.c (Fvertical_motion):
2464 * window.c (window_scroll_pixel_based, Frecenter):
2465 Don't pass `need_y_p' to `move_it_by_lines'.
2466
2467 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2468
2469 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2470 steal a few bits to be more compact.
2471 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2472 Remove unneeded casts.
2473
2474 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2475
2476 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2477
2478 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2479 binding" message (bug#7967).
2480
2481 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2482
2483 Fix more problems found by GCC 4.6.0's static checks.
2484
2485 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2486 Remove unused local var.
2487
2488 * editfns.c (Fmessage_box): Remove unused local var.
2489
2490 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2491 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2492 Omit unused local vars.
2493 * window.c (shrink_windows): Omit unused local var.
2494 * menu.c (digest_single_submenu): Omit unused local var.
2495 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2496 Omit unused local var.
2497
2498 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2499 Don't assume string length fits in int.
2500 (keyremap_step, read_key_sequence): Use size_t for sizes.
2501 (read_key_sequence): Don't check last_real_key_start redundantly.
2502
2503 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2504 instead of alloca (Bug#8344).
2505
2506 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2507 (Fbacktrace_frame): Don't assume nframes fits in int.
2508
2509 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2510
2511 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2512 concerns.
2513
2514 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2515
2516 * cm.c (calccost): Turn while-do into do-while, for clarity.
2517
2518 * keyboard.c (syms_of_keyboard): Use the same style as later
2519 in this function when indexing through an array. This also
2520 works around GCC bug 48267.
2521
2522 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2523
2524 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2525
2526 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2527 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2528
2529 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2530 This avoids undefined behavior on integer overflow, and is a bit
2531 more convenient anyway since it is compared to a size_t variable.
2532
2533 Variadic C functions now count arguments with size_t, not int.
2534 This avoids an unnecessary limitation on 64-bit machines, which
2535 caused (substring ...) to crash on large vectors (Bug#8344).
2536 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2537 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2538 All variadic functions and their callers changed accordingly.
2539 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2540 * data.c (arith_driver, float_arith_driver): Likewise.
2541 * editfns.c (general_insert_function): Likewise.
2542 * eval.c (struct backtrace.nargs, interactive_p)
2543 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2544 (funcall_lambda, mark_backtrace): Likewise.
2545 * fns.c (concat): Likewise.
2546 * frame.c (x_set_frame_parameters): Likewise.
2547 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2548 0 if not found, not -1. All callers changed.
2549
2550 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2551 (stack_copy_size): Now size_t, not int.
2552 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2553
2554 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2555
2556 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2557 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2558 All callers changed.
2559
2560 * lisp.h (multibyte_char_to_unibyte):
2561 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2562 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2563 * character.h (CHAR_TO_BYTE8):
2564 * cmds.c (internal_self_insert):
2565 * editfns.c (general_insert_function):
2566 * keymap.c (push_key_description):
2567 * search.c (Freplace_match):
2568 * xdisp.c (message_dolog, set_message_1): All callers changed.
2569
2570 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2571
2572 * keyboard.c (safe_run_hook_funcall): New function.
2573 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2574 don't set the hook to nil, but remove the offending function instead.
2575 (Qcommand_hook_internal): Remove, unused.
2576 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2577 Vcommand_hook_internal.
2578
2579 * eval.c (enum run_hooks_condition): Remove.
2580 (funcall_nil, funcall_not): New functions.
2581 (run_hook_with_args): Call each function through a `funcall' argument.
2582 Remove `cond' argument, now redundant.
2583 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2584 (Frun_hook_with_args_until_failure): Adjust accordingly.
2585 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2586
2587 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2588
2589 * dispextern.h (string_buffer_position): Remove declaration.
2590
2591 * print.c (strout): Remove parameter `multibyte', unused since
2592 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2593
2594 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2595 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2596 All callers changed.
2597
2598 * w32.c (_wsa_errlist): Use braces for struct initializers.
2599
2600 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2601 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2602 All callers changed.
2603 (string_buffer_position): Likewise. Also, make static (it's never
2604 used outside xdisp.c).
2605 (cursor_row_p): Remove parameter `w', unused since
2606 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2607 (decode_mode_spec): Remove parameter `precision', introduced during
2608 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2609 All callers changed.
2610
2611 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2612
2613 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2614
2615 2011-03-27 Anders Lindgren <andlind@gmail.com>
2616
2617 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2618 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2619 (ns_update_auto_hide_menu_bar): New functions.
2620 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2621 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2622 ns_constrain_all_frames.
2623 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2624 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2625
2626 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2627
2628 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2629
2630 2011-03-27 Glenn Morris <rgm@gnu.org>
2631
2632 * syssignal.h: Replace RETSIGTYPE with void.
2633 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2634 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2635 Replace SIGTYPE with void everywhere.
2636 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2637 * s/template.h (SIGTYPE): Remove commented out definition.
2638
2639 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2640
2641 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2642 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2643
2644 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2645
2646 * w32.c (read_unc_volume): Use parameter `henum', instead of
2647 global variable `wget_enum_handle'.
2648
2649 * keymap.c (describe_vector): Remove parameters `indices' and
2650 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2651 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2652
2653 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2654
2655 * keyboard.c (timer_check): Remove parameter `do_it_now',
2656 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2657 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2658 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2659
2660 * keyboard.c (read_char):
2661 * w32menu.c (w32_menu_display_help):
2662 * xmenu.c (show_help_event, menu_help_callback):
2663 Adjust calls to `show_help_echo'.
2664
2665 * gtkutil.c (xg_maybe_add_timer):
2666 * keyboard.c (readable_events):
2667 * process.c (wait_reading_process_output):
2668 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2669
2670 * insdel.c (adjust_markers_gap_motion):
2671 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2672 (gap_left, gap_right): Don't call it.
2673
2674 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2675
2676 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2677 incurred during fontification.
2678
2679 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2680
2681 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2682 (DEFVAR_PER_BUFFER): Don't pass it.
2683
2684 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2685 (scrolling_window): Don't pass it.
2686
2687 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2688
2689 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2690
2691 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2692 and `suffix'.
2693 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2694 of variables specific to SELinux and computation of `encoded_absname'.
2695
2696 * image.c (XPutPixel): Remove unused variable `height'.
2697
2698 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2699
2700 * unexw32.c (get_section_info): Remove unused variable `section'.
2701
2702 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2703 (system_process_attributes): Remove unused variable `sess'.
2704 (sys_read): Remove unused variable `err'.
2705
2706 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2707 (w32_wnd_proc): Remove unused variable `isdead'.
2708 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2709 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2710 (x_create_tip_frame): Remove unused variable `tem'.
2711
2712 * w32inevt.c (w32_console_read_socket):
2713 Remove unused variable `no_events'.
2714
2715 * w32term.c (x_draw_composite_glyph_string_foreground):
2716 Remove unused variable `width'.
2717
2718 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2719
2720 * w32term.c (x_set_glyph_string_clipping):
2721 Don't pass uninitialized region to CombineRgn.
2722
2723 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2724
2725 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2726 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2727 (Fx_close_connection): Remove unused variable `i'.
2728
2729 * w32font.c (w32font_draw): Return number of glyphs.
2730 (w32font_open_internal): Remove unused variable `i'.
2731 (w32font_driver): Add missing initializer.
2732
2733 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2734 (fill_in_menu): Remove unused variable `items_added'.
2735
2736 * w32term.c (last_mouse_press_frame): Remove static global variable.
2737 (w32_clip_to_row): Remove unused variable `f'.
2738 (x_delete_terminal): Remove unused variable `i'.
2739
2740 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2741 (NOTHING): Remove unused static global variable.
2742 (uniscribe_check_otf): Remove unused variable `table'.
2743 (uniscribe_font_driver): Add missing initializers.
2744
2745 2011-03-23 Julien Danjou <julien@danjou.info>
2746
2747 * term.c (Fsuspend_tty, Fresume_tty):
2748 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2749 * window.c (temp_output_buffer_show):
2750 * insdel.c (signal_before_change):
2751 * frame.c (Fhandle_switch_frame):
2752 * fileio.c (Fdo_auto_save):
2753 * emacs.c (Fkill_emacs):
2754 * editfns.c (save_excursion_restore):
2755 * cmds.c (internal_self_insert):
2756 * callint.c (Fcall_interactively):
2757 * buffer.c (Fkill_all_local_variables):
2758 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2759 Use Frun_hooks.
2760 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2761 unconditionnaly since it does the check itself.
2762
2763 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2764
2765 Fix more problems found by GCC 4.5.2's static checks.
2766
2767 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2768 the first time through the loop, since we know p0 < p1 then.
2769 This also avoids a gcc -Wstrict-overflow warning.
2770
2771 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2772 leading to a memory leak, possible in functions like
2773 load_charset_map_from_file that can allocate an unbounded number
2774 of objects (Bug#8318).
2775
2776 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2777 that could (at least in theory) be that large.
2778
2779 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2780 This is less likely to overflow, and avoids undefined behavior if
2781 overflow does occur. All callers changed. Use strtoul to scan
2782 for the unsigned long integer.
2783 (pint2hrstr): Simplify and tune code slightly.
2784 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2785
2786 * scroll.c (do_scrolling): Work around GCC bug 48228.
2787 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2788
2789 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2790 This also avoids a warning with gcc -Wstrict-overflow.
2791 (validate_x_resource_name): Simplify count usage.
2792 This also avoids a warning with gcc -Wstrict-overflow.
2793
2794 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2795 fail (Bug#8306).
2796
2797 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2798
2799 * process.c (Fmake_network_process): Use socklen_t, not int,
2800 where POSIX says socklen_t is required in portable programs.
2801 This fixes a porting bug on hosts like 64-bit HP-UX, where
2802 socklen_t is wider than int (Bug#8277).
2803 (Fmake_network_process, server_accept_connection):
2804 (wait_reading_process_output, read_process_output):
2805 Likewise.
2806
2807 * process.c: Rename or move locals to avoid shadowing.
2808 (list_processes_1, Fmake_network_process):
2809 (read_process_output_error_handler, exec_sentinel_error_handler):
2810 Rename or move locals.
2811 (Fmake_network_process): Define label "retry_connect" only if needed.
2812 (Fnetwork_interface_info): Fix pointer signedness.
2813 (process_send_signal): Add cast to avoid pointer signedness problem.
2814 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2815 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2816
2817 Make tparam.h and terminfo.c consistent.
2818 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2819 Include tparam.h instead, since it declares them.
2820 * cm.h (PC): Remove extern decl; tparam.h now does this.
2821 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2822 * terminfo.c: Include tparam.h, to check interfaces.
2823 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2824 (tparam): Adjust signature to match interface in tparam.h;
2825 this removes some undefined behavior. Check that outstring and len
2826 are zero, which they always are with Emacs.
2827 * tparam.h (PC, BC, UP): New extern decls.
2828
2829 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2830 (xftfont_open): Rename locals to avoid shadowing.
2831
2832 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2833 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2834 (OTF_TAG_SYM): Omit macro if not needed.
2835 (ftfont_list): Remove unused local.
2836 (get_adstyle_property, ftfont_pattern_entity):
2837 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2838 Rename locals to avoid shadowing.
2839
2840 * xfont.c (xfont_list_family): Mark var as initialized.
2841
2842 * xml.c (make_dom): Now static.
2843
2844 * composite.c (composition_compute_stop_pos): Rename local to
2845 avoid shadowing.
2846 (composition_reseat_it): Remove unused locals.
2847 (find_automatic_composition, composition_adjust_point): Likewise.
2848 (composition_update_it): Mark var as initialized.
2849 (find_automatic_composition): Mark vars as initialized,
2850 with a FIXME (Bug#8290).
2851
2852 character.h: Rename locals to avoid shadowing.
2853 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2854 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2855 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2856 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2857 to avoid shadowing.
2858
2859 * textprop.c (property_change_between_p): Remove; unused.
2860
2861 * intervals.c (interval_start_pos): Now static.
2862
2863 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2864
2865 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2866 Rename locals to avoid shadowing.
2867
2868 * sound.c (wav_play, au_play, Fplay_sound_internal):
2869 Fix pointer signedness.
2870 (alsa_choose_format): Remove unused local var.
2871 (wav_play): Initialize a variable to 0, to prevent undefined
2872 behavior (Bug#8278).
2873
2874 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2875
2876 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2877
2878 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2879 clobbering (Bug#8298).
2880 * sysdep.c (sys_subshell): Likewise.
2881 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2882
2883 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2884 This should get cleaned up, so that child_setup has the
2885 same signature on all platforms.
2886
2887 * callproc.c (call_process_cleanup): Now static.
2888 (relocate_fd): Rename locals to avoid shadowing.
2889
2890 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2891
2892 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2893 not to be necessary, and produces flickering.
2894
2895 2011-03-20 Glenn Morris <rgm@gnu.org>
2896
2897 * config.in: Remove file.
2898
2899 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2900
2901 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2902 are now in src/globals.h.
2903 (syms_of_minibuf): Remove spurious & from previous change.
2904
2905 2011-03-20 Leo <sdl.web@gmail.com>
2906
2907 * minibuf.c (completing-read-function): New variable.
2908 (completing-read-default): Rename from completing-read.
2909 (completing-read): Call completing-read-function.
2910
2911 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2912
2913 * xfaces.c (Fx_load_color_file):
2914 Read color file from absolute filename (bug#8250).
2915
2916 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2917
2918 * makefile.w32-in: Update dependencies.
2919
2920 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2921
2922 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2923
2924 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2925
2926 Fix more problems found by GCC 4.5.2's static checks.
2927
2928 * process.c (make_serial_process_unwind, send_process_trap):
2929 (sigchld_handler): Now static.
2930
2931 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2932 That way, the code declares only the vars that it needs.
2933 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2934 * s/cygwin.h (PTY_ITERATION): Likewise.
2935 * s/darwin.h (PTY_ITERATION): Likewise.
2936 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2937
2938 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2939 * process.c (allocate_pty): Don't declare stb unless it's needed.
2940
2941 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2942 (CONSTANTLIM): Remove; unused.
2943 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2944 Define only if needed.
2945
2946 * unexelf.c (unexec): Name an expression,
2947 to avoid gcc -Wbad-function-cast warning.
2948 Use a different way to cause a compilation error if anyone uses
2949 n rather than nn, a way that does not involve shadowing.
2950 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2951
2952 * deps.mk (unexalpha.o): Remove; unused.
2953
2954 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2955 * unexec.h: New file.
2956 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2957 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2958 Depend on unexec.h.
2959 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2960 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2961 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2962 Change as necessary to match prototype in unexec.h.
2963
2964 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2965 shadowing.
2966 (back_comment, skip_chars): Mark vars as initialized.
2967
2968 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2969 Rename locals to avoid shadowing.
2970
2971 * lread.c (read1): Rewrite so as not to use empty "else".
2972 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2973
2974 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2975
2976 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2977 warning when compiling print.c.
2978
2979 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2980 instead of using an uninitialized var.
2981 (font_sort_entities): Mark var as initialized.
2982
2983 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2984
2985 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2986 pointers to constants.
2987 (font_parse_fcname): Remove unused vars.
2988 (font_delete_unmatched): Now static.
2989 (font_get_spec): Remove; unused.
2990 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2991 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2992 Rename or move locals to avoid shadowing.
2993
2994 * fns.c (require_nesting_list, require_unwind): Now static.
2995 (Ffillarray): Rename locals to avoid shadowing.
2996
2997 * floatfns.c (domain_error2): Define only if needed.
2998 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2999
3000 * alloc.c (mark_backtrace): Move decl from here ...
3001 * lisp.h: ... to here, so that it can be checked.
3002
3003 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3004 (Fdefvar): Rewrite so as not to use empty "else".
3005 (lisp_indirect_variable): Name an expression,
3006 to avoid gcc -Wbad-function-cast warning.
3007 (Fdefvar): Rename locals to avoid shadowing.
3008
3009 * callint.c (quotify_arg, quotify_args): Now static.
3010 (Fcall_interactively): Rename locals to avoid shadowing.
3011 Use const pointer when appropriate.
3012
3013 * lisp.h (get_system_name, get_operating_system_release):
3014 Move decls here, to check interfaces.
3015 * process.c (get_operating_system_release): Move decl to lisp.h.
3016 * xrdb.c (get_system_name): Likewise.
3017 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3018 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3019 some of which prompt warnings from gcc -Wbad-function-cast.
3020 (Fformat_time_string, Fencode_time, Finsert_char):
3021 (Ftranslate_region_internal, Fformat):
3022 Rename or remove local vars to avoid shadowing.
3023 (Ftranslate_region_internal): Mark var as initialized.
3024
3025 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3026 avoid shadowing.
3027
3028 * lisp.h (eassert): Check that the argument compiles, even if
3029 ENABLE_CHECKING is not defined.
3030
3031 * data.c (Findirect_variable): Name an expression, to avoid
3032 gcc -Wbad-function-cast warning.
3033 (default_value, arithcompare, arith_driver, arith_error): Now static.
3034 (store_symval_forwarding): Rename local to avoid shadowing.
3035 (Fmake_variable_buffer_local, Fmake_local_variable):
3036 Mark variables as initialized.
3037 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3038
3039 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3040 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3041 Rename locals to avoid shadowing.
3042 (mark_stack): Move local variables into the #ifdef region where
3043 they're used.
3044 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3045 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3046 needed otherwise.
3047 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3048 (GC_STRING_CHARS): Remove; not used.
3049 (Fmemory_limit): Cast sbrk's returned value to char *.
3050
3051 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3052 avoids undefined behavior in theory.
3053
3054 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3055
3056 Use functions, not macros, for up- and down-casing (Bug#8254).
3057 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3058 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3059 to use the following functions instead of these macros.
3060 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3061 EMACS_INT, since callers assume the returned value fits in int.
3062 (upcase1): Likewise, for UPCASE_TABLE.
3063 (uppercasep, lowercasep, upcase): New static inline functions.
3064 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3065 the race-condition problem in the old DOWNCASE.
3066
3067 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3068 Rename locals to avoid shadowing.
3069 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3070 (regex_compile, re_search_2, re_match_2_internal):
3071 Remove unused local vars.
3072 (FREE_VAR): Rewrite so as not to use empty "else",
3073 which gcc can warn about.
3074 (regex_compile, re_match_2_internal): Mark locals as initialized.
3075 (RETALLOC_IF): Define only if needed.
3076 (WORDCHAR_P): Likewise. This one is never needed, but is used
3077 only in a comment talking about a compiler bug, so put inside
3078 the #if 0 of that comment.
3079 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3080 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3081 Remove; unused.
3082
3083 * search.c (boyer_moore): Rename locals to avoid shadowing.
3084 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3085 (PREV_CHAR_BOUNDARY): Likewise.
3086
3087 * search.c (simple_search): Remove unused var.
3088
3089 * dired.c (compile_pattern): Move decl from here ...
3090 * lisp.h: ... to here, so that it can be checked.
3091 (struct re_registers): New forward decl.
3092
3093 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3094
3095 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3096 All uses changed.
3097 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3098 Rename locals to avoid shadowing.
3099 (Fvertical_motion): Mark locals as initialized.
3100
3101 * casefiddle.c (casify_object, casify_region): Now static.
3102 (casify_region): Mark local as initialized.
3103
3104 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3105
3106 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3107 New macros, so that the caller can use some names other than
3108 gcpro1, gcpro2, etc.
3109 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3110 of the new macros.
3111 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3112 argument, for consistency with GCPRO2_VAR, etc: it is now the
3113 prefix of the variable, not the variable itself. All uses
3114 changed.
3115 * dired.c (directory_files_internal, file_name_completion):
3116 Rename locals to avoid shadowing.
3117
3118 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3119 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3120 dired.c's scmp function, had undefined behavior.
3121 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3122 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3123 * buffer.h: ... to here, because these macros use current_buffer,
3124 and the new implementation with inline functions needs to have
3125 current_buffer in scope now, rather than later when the macros
3126 are used.
3127 (downcase, upcase1): New static inline functions.
3128 (DOWNCASE, UPCASE1): Reimplement using these functions.
3129 This avoids undefined behavior in expressions like
3130 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3131 from race conditions in accessing the global variables
3132 case_temp1 and case_temp2.
3133 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3134 * lisp.h (case_temp1, case_temp2): Remove their decls.
3135 * character.h (ASCII_CHAR_P): Move from here ...
3136 * lisp.h: ... to here, so that the inline functions mentioned
3137 above can use them.
3138
3139 * dired.c (directory_files_internal_unwind): Now static.
3140
3141 * fileio.c (file_name_as_directory, directory_file_name):
3142 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3143 Now static.
3144 (file_name_as_directory): Use const pointers when appropriate.
3145 (Fexpand_file_name): Likewise. In particular, newdir might
3146 point at constant storage, so make it a const pointer.
3147 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3148 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3149 signedness issues.
3150 (Fset_file_times, Finsert_file_contents, auto_save_error):
3151 Rename locals to avoid shadowing.
3152
3153 * minibuf.c (choose_minibuf_frame_1): Now static.
3154 (Ftry_completion, Fall_completions): Rename or remove locals
3155 to avoid shadowing.
3156
3157 * marker.c (bytepos_to_charpos): Remove; unused.
3158
3159 * lisp.h (verify_bytepos, count_markers): New decls,
3160 so that gcc does not warn that these functions aren't declared.
3161
3162 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3163 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3164 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3165 (copy_text): Remove unused local var.
3166
3167 * filelock.c (within_one_second): Now static.
3168 (lock_file_1): Rename local to avoid shadowing.
3169
3170 * buffer.c (fix_overlays_before): Mark locals as initialized.
3171 (fix_start_end_in_overlays): Likewise. This function should be
3172 simplified by using pointers-to-pointers, but that's a different
3173 matter.
3174 (switch_to_buffer_1): Now static.
3175 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3176 (report_overlay_modification): Rename locals to avoid shadowing.
3177
3178 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3179 Fix pointer signedness issue.
3180 (sys_subshell): Mark local as volatile if checking for lint,
3181 to suppress a gcc -Wclobbered warning that does not seem to be right.
3182 (MAXPATHLEN): Define only if needed.
3183
3184 * process.c (serial_open, serial_configure): Move decls from here ...
3185 * systty.h: ... to here, so that they can be checked.
3186
3187 * fns.c (get_random, seed_random): Move extern decls from here ...
3188 * lisp.h: ... to here, so that they can be checked.
3189
3190 * sysdep.c (reset_io): Now static.
3191 (wait_for_termination_signal): Remove; unused.
3192
3193 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3194 (copy_keymap_item, append_key, push_text_char_description):
3195 Now static.
3196 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3197 (DENSE_TABLE_SIZE): Remove; unused.
3198 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3199 (describe_map_tree):
3200 Rename locals to avoid shadowing.
3201
3202 * keyboard.c: Declare functions static if they are not used elsewhere.
3203 (echo_char, echo_dash, cmd_error, top_level_2):
3204 (poll_for_input, handle_async_input): Now static.
3205 (read_char, kbd_buffer_get_event, make_lispy_position):
3206 (make_lispy_event, make_lispy_movement, apply_modifiers):
3207 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3208 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3209 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3210 (read_key_sequence, read_char): Mark locals as initialized.
3211 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3212
3213 * keyboard.h (make_ctrl_char): New decl.
3214 (mark_kboards): Move decl here ...
3215 * alloc.c (mark_kboards): ... from here.
3216
3217 * lisp.h (force_auto_save_soon): New decl.
3218
3219 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3220 (DEFINE_DUMMY_FUNCTION): New macro.
3221 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3222 Use it.
3223 (main): Add casts to avoid warnings
3224 if GCC considers string literals to be constants.
3225
3226 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3227
3228 * dbusbind.c: Pointer signedness fixes.
3229 (xd_signature, xd_append_arg, xd_initialize):
3230 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3231 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3232 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3233 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3234
3235 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3236 if GCC considers string literals to be constants.
3237 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3238
3239 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3240
3241 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3242 (print_preprocess, print_object): New macro to fix last change.
3243
3244 * print.c (print_preprocess): Don't forget font objects.
3245
3246 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3247
3248 * emacs.c (USAGE3): Doc fixes.
3249
3250 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3251
3252 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3253 structure.
3254
3255 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3256
3257 * lisp.h (VWindow_system, Qfile_name_history):
3258 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3259 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3260 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3261
3262 * w32select.c: Don't #include "keyboard.h".
3263 (run_protected): Add extern declaration for waiting_for_input.
3264
3265 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3266 * w32console.c (detect_input_pending, read_input_pending)
3267 (encode_terminal_code):
3268 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3269 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3270 (w32_system_caret_y, Qfile_name_history):
3271 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3272 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3273 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3274 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3275 * w32proc.c (Qlocal, report_file_error):
3276 * w32term.c (Vwindow_system, updating_frame):
3277 * w32uniscribe.c (initialized, uniscribe_font_driver):
3278 Remove unneeded extern declarations.
3279
3280 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3281
3282 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3283
3284 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3285
3286 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3287 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3288 These macros can no longer be used for assignment.
3289
3290 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3291 Assign struct members directly, instead of using BUF_BEGV etc.
3292 (record_buffer_markers, fetch_buffer_markers): New functions for
3293 recording and fetching special buffer markers.
3294 (set_buffer_internal_1, set_buffer_temp): Use them.
3295
3296 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3297
3298 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3299
3300 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3301 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3302
3303 * xdisp.c (hscroll_window_tree):
3304 (reconsider_clip_changes): Use PT instead of BUF_PT.
3305
3306 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3307
3308 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3309 $(EMACS_ROOT)/lib/intprops.h.
3310
3311 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3312
3313 Fix more problems found by GCC 4.5.2's static checks.
3314
3315 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3316 to unsigned char * to avoid compiler diagnostic.
3317 (xg_free_frame_widgets): Make it clear that a local variable is
3318 needed only if USE_GTK_TOOLTIP.
3319 (gdk_window_get_screen): Make it clear that this macro is needed
3320 only if USE_GTK_TOOLTIP.
3321 (int_gtk_range_get_value): New function, which avoids a diagnostic
3322 from gcc -Wbad-function-cast.
3323 (xg_set_toolkit_scroll_bar_thumb): Use it.
3324 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3325 diagnostic from gcc -Wbad-function-cast.
3326 (get_utf8_string, xg_get_file_with_chooser):
3327 Rename locals to avoid shadowing.
3328 (create_dialog): Move locals to avoid shadowing.
3329
3330 * xgselect.c (xg_select): Remove unused var.
3331
3332 * image.c (four_corners_best): Mark locals as initialized.
3333 (gif_load): Initialize transparent_p to zero (Bug#8238).
3334 Mark another local as initialized.
3335 (my_png_error, my_error_exit): Mark with NO_RETURN.
3336
3337 * image.c (clear_image_cache): Now static.
3338 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3339 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3340 (x_edge_detection): Remove unnecessary cast that
3341 gcc -Wbad-function-cast diagnoses.
3342 (gif_load): Fix pointer signedness.
3343 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3344 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3345
3346 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3347
3348 Improve quality of tests for time stamp overflow.
3349 For example, without this patch (encode-time 0 0 0 1 1
3350 1152921504606846976) returns the obviously-bogus value (-948597
3351 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3352 reports time overflow. See
3353 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3354 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3355 * editfns.c: Include limits.h and intprops.h.
3356 (TIME_T_MIN, TIME_T_MAX): New macros.
3357 (time_overflow): Move earlier, to before first use.
3358 (hi_time, lo_time): New functions, for an accurate test for
3359 out-of-range times.
3360 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3361 (Fget_internal_run_time): Don't assume time_t fits in int.
3362 (make_time): Use list2 instead of Fcons twice.
3363 (Fdecode_time): More accurate test for out-of-range times.
3364 (check_tm_member): New function.
3365 (Fencode_time): Use it, to test for out-of-range times.
3366 (lisp_time_argument): Don't rely on undefined left-shift and
3367 right-shift behavior when checking for time stamp overflow.
3368
3369 * editfns.c (time_overflow): New function, refactoring common code.
3370 (Fformat_time_string, Fdecode_time, Fencode_time):
3371 (Fcurrent_time_string): Use it.
3372
3373 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3374 * dired.c (make_time): Move to ...
3375 * editfns.c (make_time): ... here.
3376 * systime.h: Note the move.
3377
3378 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3379
3380 * fringe.c (update_window_fringes): Remove unused variables.
3381
3382 * unexmacosx.c (copy_data_segment): Also copy __got section.
3383 (Bug#8223)
3384
3385 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3386
3387 * termcap.c [MSDOS]: Include "msdos.h".
3388 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3389 Constify `char *' arguments and their references according to
3390 prototypes in tparam.h.
3391
3392 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3393
3394 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3395 Adapt all references accordingly.
3396
3397 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3398
3399 2011-03-11 Tom Tromey <tromey@redhat.com>
3400
3401 * buffer.c (syms_of_buffer): Remove obsolete comment.
3402
3403 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3404
3405 * termhooks.h (encode_terminal_code): Declare prototype.
3406
3407 * msdos.c (encode_terminal_code): Don't declare prototype.
3408
3409 * term.c (encode_terminal_code): Now external again, used by
3410 w32console.c and msdos.c.
3411
3412 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3413 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3414
3415 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3416
3417 Fix some minor problems found by GCC 4.5.2's static checks.
3418
3419 * fringe.c (update_window_fringes): Mark locals as initialized
3420 (Bug#8227).
3421 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3422
3423 * alloc.c (mark_fringe_data): Move decl from here ...
3424 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3425 to check its interface.
3426 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3427
3428 * fontset.c (free_realized_fontset): Now static.
3429 (Fset_fontset_font): Rename local to avoid shadowing.
3430 (fontset_font): Mark local as initialized.
3431 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3432
3433 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3434
3435 * xselect.c (x_disown_buffer_selections): Remove; not used.
3436 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3437 (x_own_selection, Fx_disown_selection_internal): Rename locals
3438 to avoid shadowing.
3439 (x_handle_dnd_message): Remove local to avoid shadowing.
3440
3441 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3442 so that the caller can use some name other than gcpro1.
3443 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3444 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3445 (Fx_backspace_delete_keys_p):
3446 Use them to avoid shadowing, and rename vars to avoid shadowing.
3447 (x_decode_color, x_set_name, x_window): Now static.
3448 (Fx_create_frame): Add braces to silence GCC warning.
3449 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3450 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3451 Remove unused locals.
3452 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3453 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3454 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3455 macros.
3456
3457 * xterm.h (x_mouse_leave): New decl.
3458
3459 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3460 Remove unused functions.
3461 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3462 (x_calc_absolute_position): Now static.
3463 (XTread_socket): Don't define label "out" unless it's used.
3464 Don't declare local "event" unless it's used.
3465 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3466 unless they are used.
3467 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3468 (x_fatal_error_signal): Remove; not used.
3469 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3470 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3471 (x_error_catcher, x_connection_closed, x_error_handler):
3472 (x_error_quitter, xembed_send_message, x_iconify_frame):
3473 (my_log_handler): Rename locals to avoid shadowing.
3474 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3475 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3476
3477 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3478 Rename or move locals to avoid shadowing.
3479 (tty_defined_color, merge_face_heights): Now static.
3480 (free_realized_faces_for_fontset): Remove; not used.
3481 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3482 does not deduce is never used uninitialized.
3483 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3484 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3485
3486 * terminal.c (store_terminal_param): Now static.
3487
3488 * xmenu.c (menu_highlight_callback): Now static.
3489 (set_frame_menubar): Remove unused local.
3490 (xmenu_show): Rename parameter to avoid shadowing.
3491 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3492 since they might point to immutable storage.
3493 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3494 since it's unused otherwise.
3495
3496 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3497 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3498 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3499 avoids a gcc -Wuninitialized diagnostic.
3500 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3501 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3502 does not deduce are never used uninitialized.
3503
3504 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3505
3506 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3507 * window.c (window_loop, size_window):
3508 (run_window_configuration_change_hook, enlarge_window): Likewise.
3509
3510 * window.c (display_buffer): Now static.
3511 (size_window): Mark variables that gcc -Wuninitialized
3512 does not deduce are never used uninitialized.
3513 * window.h (check_all_windows): New decl, to forestall
3514 gcc -Wmissing-prototypes diagnostic.
3515 * dispextern.h (bidi_dump_cached_states): Likewise.
3516
3517 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3518 shadowing.
3519 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3520 Include <limits.h>.
3521 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3522 and to avoid gcc -Wuninitialized warning.
3523 (load_charset_map): Mark variables that gcc -Wuninitialized
3524 does not deduce are never used uninitialized.
3525 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3526
3527 * coding.c (coding_set_source, coding_set_destination):
3528 Use "else { /* comment */ }" rather than "else /* comment */;"
3529 for clarity, and to avoid gcc -Wempty-body warning.
3530 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3531 a block, when the outer 'i' will do.
3532 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3533 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3534 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3535 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3536 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3537 Rename locals to avoid shadowing.
3538 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3539 * coding.c (emacs_mule_char, encode_invocation_designation):
3540 Now static, since they're not used elsewhere.
3541 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3542 (decode_coding_object, encode_coding_object, detect_coding_system):
3543 (decode_coding_emacs_mule): Mark variables that gcc
3544 -Wuninitialized does not deduce are never used uninitialized.
3545 (detect_coding_iso_2022): Initialize a local variable that might
3546 be used uninitialized. Leave a FIXME because it's not clear that
3547 this initialization is needed. (Bug#8211)
3548 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3549 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3550 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3551 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3552 Remove unused macros.
3553
3554 * category.c (hash_get_category_set): Remove unused local var.
3555 (copy_category_table): Now static, since it's not used elsewhere.
3556 * character.c (string_count_byte8): Likewise.
3557
3558 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3559 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3560
3561 * chartab.c (copy_sub_char_table): Now static, since it's not used
3562 elsewhere.
3563 (sub_char_table_ref_and_range, char_table_ref_and_range):
3564 Rename locals to avoid shadowing.
3565 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3566
3567 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3568 (BIDI_BOB): Remove unused macro.
3569
3570 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3571 deduce are never used uninitialized.
3572 * term.c (encode_terminal_code): Likewise.
3573
3574 * term.c (encode_terminal_code): Now static. Remove unused local.
3575
3576 * tparam.h: New file.
3577 * term.c, tparam.h: Include it.
3578 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3579 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3580 Move these decls to tparam.h, and make them agree with what
3581 is actually in tparam.c. The previous trick of using incompatible
3582 decls in different modules does not conform to the C standard.
3583 All callers of tparam changed to use tparam's actual API.
3584 * tparam.c (tparam1, tparam, tgoto):
3585 Use const pointers where appropriate.
3586
3587 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3588 * cm.h (struct cm): Likewise.
3589 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3590 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3591 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3592 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3593 (turn_on_face, init_tty): Likewise.
3594 * termchar.h (struct tty_display_info): Likewise.
3595
3596 * term.c (term_mouse_position): Rename local to avoid shadowing.
3597
3598 * alloc.c (mark_ttys): Move decl from here ...
3599 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3600
3601 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3602
3603 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3604
3605 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * search.c (compile_pattern_1): Remove argument regp, unused since
3608 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3609 (compile_pattern): Don't pass it.
3610
3611 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3612
3613 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3614 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3615 for ! HAVE_GTK3.
3616 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3617
3618 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3619
3620 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3621 gdk_window_get_screen, gdk_window_get_geometry,
3622 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3623 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3624 (xg_get_pixbuf_from_pixmap): New function.
3625 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3626 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3627 Call xg_get_pixbuf_from_pixmap instead of
3628 gdk_pixbuf_get_from_drawable.
3629 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3630 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3631 (xg_check_special_colors): Use GtkStyleContext and its functions
3632 for HAVE_GTK3.
3633 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3634 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3635 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3636 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3637 Call gtk_widget_get_preferred_size.
3638 (xg_frame_resized): gdk_window_get_geometry only takes 5
3639 parameters.
3640 (xg_win_to_widget, xg_event_is_for_menubar):
3641 Call gdk_x11_window_lookup_for_display.
3642 (xg_set_widget_bg): New function.
3643 (delete_cb): New function.
3644 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3645 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3646 (xg_set_background_color): Call xg_set_widget_bg.
3647 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3648 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3649 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3650 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3651 if ! HAVE_GTK3.
3652 (update_frame_tool_bar): Call gtk_widget_hide.
3653 (xg_initialize): Use GDK_KEY_g.
3654
3655 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3656 if ! HAVE_GTK3
3657 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3658
3659 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3660 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3661 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3662
3663 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3664
3665 * w32xfns.c (select_palette): Check success of RealizePalette against
3666 GDI_ERROR, not zero.
3667
3668 See ChangeLog.11 for earlier changes.
3669
3670 ;; Local Variables:
3671 ;; coding: utf-8
3672 ;; End:
3673
3674 Copyright (C) 2011 Free Software Foundation, Inc.
3675
3676 This file is part of GNU Emacs.
3677
3678 GNU Emacs is free software: you can redistribute it and/or modify
3679 it under the terms of the GNU General Public License as published by
3680 the Free Software Foundation, either version 3 of the License, or
3681 (at your option) any later version.
3682
3683 GNU Emacs is distributed in the hope that it will be useful,
3684 but WITHOUT ANY WARRANTY; without even the implied warranty of
3685 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3686 GNU General Public License for more details.
3687
3688 You should have received a copy of the GNU General Public License
3689 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.