* termcap.c: Integer and memory overflow issues.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * termcap.c: Integer and memory overflow issues.
4 (tgetent): Use ptrdiff_t, not int, to record results of
5 subtracting pointers.
6 (gobble_line): Check for overflow more carefully. Don't update size
7 until alloc done.
8
9 * term.c: Integer and memory overflow issues.
10 (max_frame_lines): Remove; unused.
11 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
12 not int.
13 (encode_terminal_code, calculate_costs): Check for size
14 calculation overflow.
15 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
16 table lengths and related sizes. Don't update size until alloc
17 done. Redo calculations to avoid overflow.
18 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
19
20 * sysdep.c: Integer and memory overflow issues.
21 (system_process_attributes): Use ptrdiff_t, not int, for command
22 line length. Do not attempt to address one before the beginning
23 of an array, as that's not portable.
24
25 * search.c: Integer and memory overflow fixes.
26 (Freplace_match): Check for size calculation overflow.
27 (Fset_match_data): Don't assume list lengths fit in 'int'.
28
29 * scroll.c: Integer and memory overflow fixes.
30 (do_line_insertion_deletion_costs): Check for size calculation overflow.
31 Don't bother calling xmalloc when xrealloc will do.
32
33 * region-cache.c (move_cache_gap): Check for size calculation overflow.
34
35 * process.c (Fnetwork_interface_list): Check for overflow
36 in size calculation.
37
38 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
39 Now ptrdiff_t, not int.
40 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
41 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
42
43 * minibuf.c (read_minibuf_noninteractive): Don't leak memory
44 on memory overflow.
45
46 * macros.c: Integer and memory overflow fixes.
47 (Fstart_kbd_macro): Don't update size until alloc done.
48 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
49
50 * lread.c (read1, init_obarray): Don't update size until alloc done.
51
52 * keymap.c: Integer overflow fixes.
53 (cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
54 (current_minor_maps): Check for size calculation overflow.
55 * keymap.h: Change prototypes to match the above.
56
57 * keyboard.c: Integer and memory overflow fixes.
58 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
59 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
60 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
61 (read_char_minibuf_menu_prompt): Check for overflow in size
62 calculations. Don't update size until allocation succeeds. Redo
63 calculations to avoid overflow.
64 * keyboard.h: Change prototypes to match the above.
65
66 * image.c: Integer and memory overflow fixes.
67 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
68 now that they've been promoted to lisp.h.
69 (x_allocate_bitmap_record, x_alloc_image_color)
70 (make_image_cache, cache_image, xpm_load):
71 Don't update size until alloc is done.
72 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
73 (x_detect_edges):
74 Check for size calculation overflow.
75 (ct_colors_allocated_max): New constant.
76 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
77 overflow.
78
79 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
80
81 * gtkutil.c: Integer overflow fixes.
82 (get_utf8_string, xg_store_widget_in_map):
83 Check for size-calculation overflow.
84 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
85 do, as we prefer signed integers.
86 (id_to_widget.max_size, id_to_widget.used)
87 (xg_store_widget_in_map, xg_remove_widget_from_map)
88 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
89 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
90 Use and return ptrdiff_t, not int.
91 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
92 * gtkutil.h: Change prototypes to match the above.
93
94 * ftfont.c: Check for size overflow.
95 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
96 Check for integer overflow in size calculations.
97
98 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
99
100 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
101 This is for the members text_lines, text_cols, total_lines, total_cols,
102 where the system imposes an 'int' limit.
103
104 * frame.c: Integer overflow fixes.
105 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
106 (x_figure_window_size): Check for integer overflow.
107 (x_set_alpha): Do not assume XINT fits in int.
108
109 * eval.c: Integer and memory overflow fixes.
110 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
111 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
112
113 * emacs.c (main, sort_args): Check for size-calculation overflow.
114
115 * editfns.c: Integer and memory overflow fixes.
116 (set_time_zone_rule): Don't assume environment length fits in int.
117 (message_length): Now ptrdiff_t, not int.
118 (Fmessage_box): Don't update size until allocation succeeds.
119 Don't assume message length fits in int.
120 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
121
122 * doc.c: Integer and memory overflow fixes.
123 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
124 (get_doc_string): Check for size calculation overflow.
125 Don't update size until allocation succeeds.
126 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
127 EMACS_INT, where ptrdiff_t will do.
128 (Fsubstitute_command_keys): Check for string overflow.
129
130 Integer and memory overflow fixes for display code.
131 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
132 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
133 Check for overflow in size calculations.
134 (line_draw_cost, realloc_glyph_pool, add_row_entry):
135 Don't assume glyph table len fits in int.
136 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
137 (row_table_size): Now ptrdiff_t, not int.
138 (scrolling_window): Avoid overflow in size calculations.
139 Don't update size until allocation succeeds.
140 * fns.c (concat): Check for overflow in size calculations.
141 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
142 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
143 (NEXT_ALMOST_PRIME_LIMIT): New constant.
144
145 * composite.c: Integer overflow fixes.
146 (get_composition_id): Check for overflow in glyph length calculations.
147
148 * coding.c: Integer and memory overflow fixes.
149 (produce_chars): Redo buffer-overflow calculations to avoid
150 unnecessary integer overflow. Check for size overflow.
151 (encode_coding_object): Don't update size until xmalloc succeeds.
152
153 * character.c (Fstring): Check for size-calculation overflow.
154
155 * ccl.c: Integer and memory overflow fixes.
156 (Fccl_execute_on_string): Check for memory overflow.
157 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
158 Redo buffer-overflow calculations to avoid integer overflow.
159
160 * callproc.c (child_setup): Don't assume strlen fits in int.
161
162 * buffer.c: Memory overflow fixes.
163 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
164 Don't update size of array until after memory allocation succeeds,
165 because xmalloc/xrealloc may not return.
166
167 * bidi.c: Integer overflow fix.
168 (bidi_shelve_header_size): New constant.
169 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
170 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
171
172 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
173
174 Use ptrdiff_t for composition IDs.
175 * character.c (lisp_string_width):
176 * composite.c (composition_table_size, n_compositions)
177 (get_composition_id, composition_gstring_from_id):
178 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
179 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
180 * window.c (Frecenter):
181 Use ptrdiff_t, not int, for composition IDs.
182 * composite.c (get_composition_id): Check for integer overflow.
183 * composite.h: Adjust prototypes to match the above changes.
184
185 Use ptrdiff_t for hash table indexes.
186 * category.c (hash_get_category_set):
187 * ccl.c (ccl_driver):
188 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
189 * coding.c (coding_system_charset_list, detect_coding_system):
190 * coding.h (struct coding_system.id):
191 * composite.c (get_composition_id, gstring_lookup_cache):
192 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
193 * image.c (xpm_get_color_table_h):
194 * lisp.h (hash_lookup, hash_put):
195 * minibuf.c (Ftest_completion):
196 Use ptrdiff_t for hash table indexes, not int (which is too
197 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
198 32-bit --with-wide-int hosts).
199
200 * charset.c (Fdefine_charset_internal): Check for integer overflow.
201 Add a FIXME comment about memory leaks.
202 (syms_of_charset): Don't assume xmalloc returns.
203
204 Don't assume that stated character widths fit in int.
205 * character.c (Fchar_width, c_string_width, lisp_string_width):
206 * character.h (CHAR_WIDTH):
207 * indent.c (MULTIBYTE_BYTES_WIDTH):
208 Use sanitize_char_width to avoid undefined and/or bad behavior
209 with outlandish widths.
210 * character.h (sanitize_tab_width): Renamed from sanitize_width,
211 now that we have two such functions. All uses changed.
212 (sanitize_char_width): New inline function.
213
214 Don't assume that tab-width fits in int.
215 * character.h (sanitize_width): New inline function.
216 (SANE_TAB_WIDTH): New macro.
217 (ASCII_CHAR_WIDTH): Use it.
218 * indent.c (sane_tab_width): Remove. All uses replaced by
219 SANE_TAB_WIDTH (current_buffer).
220 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
221
222 * fileio.c: Integer overflow issues with file modes.
223 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
224
225 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
226 Remove unreachable code.
227 (read_hex, load_charset_map_from_file): Check for integer overflow.
228
229 * xterm.c: don't go over XClientMessageEvent limit
230 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
231 (x_send_scroll_bar_event): Likewise. Check that the size does not
232 exceed limits imposed by XClientMessageEvent, as well as the usual
233 ptrdiff_t and size_t limits.
234
235 * keyboard.c: Overflow, signedness and related fixes.
236 (make_lispy_movement): Use same integer type in forward decl
237 that is used in the definition.
238 (read_key_sequence, keyremap_step):
239 Change bufsize argument back to int, undoing my 2011-03-30 change.
240 We prefer signed types, and int is wide enough here.
241 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
242 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
243 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
244 length, not size_t. Use ptrdiff_t for index, not int.
245 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
246 possibility of integer overflow.
247
248 Overflow, signedness and related fixes for images.
249
250 * dispextern.h (struct it.stack[0].u.image.image_id)
251 (struct_it.image_id, struct image.id, struct image_cache.size)
252 (struct image_cache.used, struct image_cache.ref_count):
253 * gtkutil.c (update_frame_tool_bar):
254 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
255 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
256 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
257 * nsmenu.m (update_frame_tool_bar):
258 * xdisp.c (calc_pixel_width_or_height):
259 * xfns.c (image_cache_refcount):
260 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
261 on typical 64-bit hosts.
262
263 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
264 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
265 Omit unnecessary casts to int.
266 (parse_image_spec): Check that integers fall into 'int' range
267 when the callers expect that.
268 (image_ascent): Redo ascent calculation to avoid int overflow.
269 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
270 (lookup_image): Remove unnecessary tests.
271 (xbm_image_p): Locals are now of int, not EMACS_INT,
272 since parse_image_check makes sure they fit into int.
273 (png_load, gif_load, svg_load_image):
274 Prefer int to unsigned where either will do.
275 (tiff_handler): New function, combining the cores of the
276 old tiff_error_handler and tiff_warning_handler. This
277 function is rewritten to use vsnprintf and thereby avoid
278 stack buffer overflows. It uses only the features of vsnprintf
279 that are common to both POSIX and native Microsoft.
280 (tiff_error_handler, tiff_warning_handler): Use it.
281 (tiff_load, gif_load, imagemagick_load_image):
282 Don't assume :index value fits in 'int'.
283 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
284 (imagemagick_load_image): Check that crop parameters fit into
285 the integer types that MagickCropImage accepts. Don't assume
286 Vimagemagick_render_type has a nonnegative value. Don't assume
287 size_t fits in 'long'.
288 (gs_load): Use printmax_t to print the widest integers possible.
289 Check for integer overflow when computing image height and width.
290
291 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
292
293 Integer signedness and overflow and related fixes. (Bug#9079)
294
295 * bidi.c: Integer size and overflow fixes.
296 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
297 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
298 (bidi_cache_find_level_change, bidi_cache_ensure_space)
299 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
300 (bidi_find_other_level_edge):
301 Use ptrdiff_t instead of EMACS_INT where either will do.
302 This works better on 32-bit hosts configured --with-wide-int.
303 (bidi_cache_ensure_space): Check for size-calculation overflow.
304 Use % rather than repeated addition, for better worst-case speed.
305 Don't set bidi_cache_size until after xrealloc returns, because it
306 might not return.
307 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
308 (bidi_cache_ensure_space): Also check that the bidi cache size
309 does not exceed that of the largest Lisp string or buffer. See Eli
310 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
311
312 * alloc.c (__malloc_size_t): Remove.
313 All uses replaced by size_t. See Andreas Schwab's note
314 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
315
316 * image.c: Improve checking for integer overflow.
317 (check_image_size): Assume that f is nonnull, since
318 it is always nonnull in practice. This is one less thing to
319 worry about when checking for integer overflow later.
320 (x_check_image_size): New function, which checks for integer
321 overflow issues inside X.
322 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
323 This removes the need for a memory_full check.
324 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
325 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
326 (xbm_read_bitmap_data): Change locals back to 'int', since
327 their values must fit in 'int'.
328 (xpm_load_image, png_load, tiff_load):
329 Invoke x_create_x_image_and_pixmap earlier,
330 to avoid much needless work if the image is too large.
331 (tiff_load): Treat overly large images as if
332 x_create_x_image_and_pixmap failed, not as malloc failures.
333 (gs_load): Use x_check_image_size.
334
335 * gtkutil.c: Omit integer casts.
336 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
337 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
338
339 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
340
341 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
342 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
343 would wrongly return t on a 64-bit host.
344
345 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
346 The plain *_OVERFLOW macros run afoul of GCC bug 49705
347 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
348 and therefore cause GCC to emit a bogus diagnostic in some cases.
349
350 * image.c: Integer signedness and overflow and related fixes.
351 This is not an exhaustive set of fixes, but it's time to
352 record what I've got.
353 (lookup_pixel_color, check_image_size): Remove redundant decls.
354 (check_image_size): Don't assume that arbitrary EMACS_INT values
355 fit in 'int', or that arbitrary 'double' values fit in 'int'.
356 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
357 (tiff_load, imagemagick_load_image):
358 Check for overflow in size calculations.
359 (x_create_x_image_and_pixmap): Remove unnecessary test for
360 xmalloc returning NULL; that can't happen.
361 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
362 (xpm_color_bucket): Use better integer hashing function.
363 (xpm_cache_color): Don't possibly over-allocate memory.
364 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
365 (gif_memory_source):
366 Use ptrdiff_t, not int or size_t, to record sizes.
367 (png_load): Don't assume values greater than 2**31 fit in 'int'.
368 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
369 either works, as we prefer signed integers.
370 (tiff_read_from_memory, tiff_write_from_memory):
371 Return tsize_t, not size_t, since that's what the TIFF API wants.
372 (tiff_read_from_memory): Don't fail simply because the read would
373 go past EOF; instead, return a short read.
374 (tiff_load): Omit no-longer-needed casts.
375 (Fimagemagick_types): Don't assume size fits into 'int'.
376
377 Improve hashing quality when configured --with-wide-int.
378 * fns.c (hash_string): New function, taken from sxhash_string.
379 Do not discard information about ASCII character case; this
380 discarding is no longer needed.
381 (sxhash-string): Use it. Change sig to match it. Caller changed.
382 * lisp.h: Declare it.
383 * lread.c (hash_string): Remove, since we now use fns.c's version.
384 The fns.c version returns a wider integer if --with-wide-int is
385 specified, so this should help the quality of the hashing a bit.
386
387 * emacs.c: Integer overflow minor fix.
388 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
389 Define only if GNU_LINUX.
390 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
391
392 * dispnew.c: Integer signedness and overflow fixes.
393 Remove unnecessary forward decls, that were a maintenance hassle.
394 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
395 All uses changed.
396 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
397 (scrolling_window): Use ptrdiff_t, not int, for byte count.
398 (prepare_desired_row, line_draw_cost):
399 Use int, not unsigned, where either works.
400 (save_current_matrix, restore_current_matrix):
401 Use ptrdiff_t, not size_t, where either works.
402 (init_display): Check for overflow more accurately, and without
403 relying on undefined behavior.
404
405 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
406 Remove, replacing with the new symbols in lisp.h. All uses changed.
407 * fileio.c (make_temp_name):
408 * filelock.c (lock_file_1, lock_file):
409 * xdisp.c (message_dolog):
410 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
411 Use pMd etc. instead.
412 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
413 replacing the pWIDE etc. symbols removed from editfns.c.
414
415 * keyboard.h (num_input_events): Now uintmax_t.
416 This is (very slightly) less likely to mess up due to wraparound.
417 All uses changed.
418
419 * buffer.c: Integer signedness fixes.
420 (alloc_buffer_text, enlarge_buffer_text):
421 Use ptrdiff_t rather than size_t when either will do, as we prefer
422 signed integers.
423
424 * alloc.c: Integer signedness and overflow fixes.
425 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
426 (__malloc_size_t): Default to size_t, not to int.
427 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
428 (Fgarbage_collect, mark_object_loop_halt, mark_object):
429 Prefer ptrdiff_t to size_t when either would do, as we prefer
430 signed integers.
431 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
432 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
433 Now const. Initialize with values that are in range even if char
434 is signed.
435 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
436 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
437 These functions do the right thing with sizes > 2**32.
438 (check_depth): Now ptrdiff_t, not int.
439 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
440 Adjust to new way of storing sizes. Check for size overflow bugs
441 in rest of code.
442 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
443 slightly wrong anyway, as it missed one instance of
444 XMALLOC_OVERRUN_CHECK_OVERHEAD.
445 (refill_memory_reserve): Omit needless cast to size_t.
446 (mark_object_loop_halt): Mark as externally visible.
447
448 * xselect.c: Integer signedness and overflow fixes.
449 (Fx_register_dnd_atom, x_handle_dnd_message):
450 Use ptrdiff_t, not size_t, since we prefer signed.
451 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
452 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
453 x_dnd_atoms_size and x_dnd_atoms_length.
454
455 * doprnt.c: Prefer signed to unsigned when either works.
456 * eval.c (verror):
457 * doprnt.c (doprnt):
458 * lisp.h (doprnt):
459 * xdisp.c (vmessage):
460 Use ptrdiff_t, not size_t, when using or implementing doprnt,
461 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
462 prefer signed arithmetic to avoid comparison confusion.
463 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
464 but is a bit tricky.
465
466 Assume freestanding C89 headers, string.h, stdlib.h.
467 * data.c, doprnt.c, floatfns.c, print.c:
468 Include float.h unconditionally.
469 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
470 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
471 * regex.c: Likewise for stddef.h, string.h.
472 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
473 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
474 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
475 (STDC_HEADERS): Remove obsolete defines.
476 * sysdep.c: Include limits.h unconditionally.
477
478 Assume support for memcmp, memcpy, memmove, memset.
479 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
480 * regex.c (memcmp, memcpy):
481 Remove; we assume C89 now.
482
483 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
484 (__malloc_safe_bcopy): Remove; no longer needed.
485
486 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
487 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
488 well either way, and we prefer signed to unsigned.
489
490 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
491
492 Port to OpenBSD.
493 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
494 and the surrounding thread.
495 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
496 rather than fgets, and retry after EINTR. Otherwise, 'emacs
497 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
498 timer goes off.
499 * s/openbsd.h (BROKEN_SIGIO): Define.
500 * unexelf.c (unexec) [__OpenBSD__]:
501 Don't update the .mdebug section of the Alpha COFF symbol table.
502
503 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
504
505 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
506 (bug#8460).
507
508 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
509
510 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
511 This fixes some race conditions on the permissions of any newly
512 created file.
513
514 * alloc.c (valid_pointer_p): Use pipe, not open.
515 This fixes some permissions issues when debugging.
516
517 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
518 If fchown fails to set both uid and gid, try to set just gid,
519 as that is sometimes allowed. Adjust the file's mode to eliminate
520 setuid or setgid bits that are inappropriate if fchown fails.
521
522 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
523
524 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
525 to compare Lisp_Objects.
526 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
527 global_gnutls_log_level, don't mistake it for a Lisp_Object.
528 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
529
530 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
531
532 * lread.c (read_integer): Unread even EOF character.
533 (read1): Likewise. Properly record start position of symbol.
534
535 * lread.c (read1): Read `#:' as empty uninterned symbol if no
536 symbol character follows.
537
538 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
539
540 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
541 This works around a problem with the previous change to Fcopy_file.
542 Recent glibc declares fchown with __attribute__((warn_unused_result)),
543 and without this change, GCC might complain about discarding
544 fchown's return value.
545
546 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
547
548 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
549
550 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
551
552 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
553
554 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
555
556 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
557 it's used from the C level.
558
559 * process.c: Use the same condition for POLL_FOR_INPUT in both
560 keyboard.c and process.c (bug#1858).
561
562 2011-07-09 Lawrence Mitchell <wence@gmx.li>
563
564 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
565 (Fgnutls_boot): Use it.
566
567 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
568
569 * doc.c (Fsubstitute_command_keys): Revert last change.
570
571 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
572
573 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
574 quotes the next character, and doesn't affect other longer
575 sequences (bug#8935).
576
577 * lread.c (syms_of_lread): Clarify that is isn't only
578 `eval-buffer' and `eval-defun' that's affected by
579 `lexical-binding' (bug#8460).
580
581 2011-07-15 Eli Zaretskii <eliz@gnu.org>
582
583 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
584 bidi redisplay when a line includes both an image and is
585 truncated.
586
587 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
588
589 Fix minor problems found by static checking.
590 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
591 (elsz): Now a signed constant, not a size_t var. We prefer signed
592 types to unsigned, to avoid integer comparison confusion. Without
593 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
594 "cannot optimize loop, the loop counter may overflow", a symptom
595 of the confusion.
596 * indent.c (Fvertical_motion): Mark locals as initialized.
597 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
598
599 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
600
601 * search.c (Fre_search_backward): Mention `case-fold-search' in
602 all the re_search_* functions (bug#8138).
603
604 * keyboard.c (Fopen_dribble_file): Document when the file is
605 closed (bug#8056).
606
607 2011-07-14 Eli Zaretskii <eliz@gnu.org>
608
609 * bidi.c (bidi_dump_cached_states): Fix format of displaying
610 bidi_cache_idx.
611
612 Support bidi reordering of display and overlay strings.
613 * xdisp.c (compute_display_string_pos)
614 (compute_display_string_end): Accept additional argument STRING.
615 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
616 (reseat_to_string): Initialize bidi_it->string.s and
617 bidi_it->string.schars.
618 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
619 NULL (avoids a crash in bidi_paragraph_init). Initialize
620 itb.string.lstring.
621 (init_iterator): Call bidi_init_it only of a valid
622 buffer position was specified. Initialize paragraph_embedding to
623 L2R.
624 (reseat_to_string): Initialize the bidi iterator.
625 (display_string): If we need to ignore text properties of
626 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
627 original value of -1 will not work with bidi.)
628 (compute_display_string_pos): First arg is now struct
629 `text_pos *'; all callers changed. Support display properties on
630 Lisp strings.
631 (compute_display_string_end): Support display properties on Lisp
632 strings.
633 (init_iterator, reseat_1, reseat_to_string): Initialize the
634 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
635 when iterating on a string not from display properties).
636 (compute_display_string_pos, compute_display_string_end): Fix
637 calculation of the object to scan. Fixes an error when using
638 arrow keys.
639 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640 base_level_stop; instead, set base_level_stop to BEGV. Fixes
641 crashes in vertical-motion.
642 (next_element_from_buffer): Improve commentary for when
643 the iterator is before prev_stop.
644 (init_iterator): Initialize bidi_p from the default value of
645 bidi-display-reordering, not from buffer-local value. Use the
646 buffer-local value only if initializing for buffer iteration.
647 (handle_invisible_prop): Support invisible properties on strings
648 that are being bidi-reordered.
649 (set_iterator_to_next): Support bidi reordering of C strings and
650 Lisp strings.
651 (next_element_from_string): Support bidi reordering of Lisp
652 strings.
653 (handle_stop_backwards): Support Lisp strings as well.
654 (display_string): Support display of R2L glyph rows. Use
655 IT_STRING_CHARPOS when displaying from a Lisp string.
656 (init_iterator): Don't initialize it->bidi_p for strings
657 here.
658 (reseat_to_string): Initialize it->bidi_p for strings here.
659 (next_element_from_string, next_element_from_c_string)
660 (next_element_from_buffer): Add xassert's for correspondence
661 between IT's object being iterated and it->bidi_it.string
662 structure.
663 (face_before_or_after_it_pos): Support bidi iteration.
664 (next_element_from_c_string): Handle the case of the first string
665 character that is not the first one in the visual order.
666 (get_visually_first_element): New function, refactored from common
667 parts of next_element_from_buffer, next_element_from_string, and
668 next_element_from_c_string.
669 (tool_bar_lines_needed, redisplay_tool_bar)
670 (display_menu_bar): Force left-to-right direction. Add a FIXME
671 comment for making that be controlled by a user option.
672 (push_it, pop_it): Save and restore the state of the
673 bidi iterator. Save and restore the bidi_p flag.
674 (pop_it): Iterate out of display property for string iteration as
675 well.
676 (iterate_out_of_display_property): Support iteration over strings.
677 (handle_single_display_spec): Set up it->bidi_it for iteration
678 over a display string, and call bidi_init_it.
679 (handle_single_display_spec, next_overlay_string)
680 (get_overlay_strings_1, push_display_prop): Set up the bidi
681 iterator for displaying display or overlay strings.
682 (forward_to_next_line_start): Don't use the shortcut if
683 bidi-iterating.
684 (back_to_previous_visible_line_start): If handle_display_prop
685 pushed the iterator stack, restore the internal state of the bidi
686 iterator by calling bidi_pop_it same number of times.
687 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
688 and we are bidi-iterating, don't decrement the iterator position;
689 instead, set the first_elt flag in the bidi iterator, to produce
690 the same effect.
691 (reseat_1): Remove redundant setting of string_from_display_prop_p.
692 (push_display_prop): xassert that we are iterating a buffer.
693 (push_it, pop_it): Save and restore paragraph_embedding member.
694 (handle_single_display_spec, next_overlay_string)
695 (get_overlay_strings_1, reseat_1, reseat_to_string)
696 (push_display_prop): Set up the `unibyte' member of bidi_it.string
697 correctly. Don't assume unibyte strings are not bidi-reordered.
698 (compute_display_string_pos)
699 (compute_display_string_end): Fix handling the case of C string.
700 (push_it, pop_it): Save and restore from_disp_prop_p.
701 (handle_single_display_spec, push_display_prop): Set the
702 from_disp_prop_p flag.
703 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
704 (pop_it): Call iterate_out_of_display_property only if we are
705 popping after iteration over a string that came from a display
706 property. Fix a typo in popping stretch info. Add an assertion
707 for verifying that the iterator position is in sync with the bidi
708 iterator.
709 (handle_single_display_spec, get_overlay_strings_1)
710 (push_display_prop): Fix initialization of paragraph direction for
711 string when that of the parent object is not yet determined.
712 (reseat_1): Call bidi_init_it to resync the bidi
713 iterator with IT's position. (Bug#7616)
714 (find_row_edges): If ROW->start.pos gives position
715 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
716 (handle_stop, back_to_previous_visible_line_start, reseat_1):
717 Reset the from_disp_prop_p flag.
718 (SAVE_IT, RESTORE_IT): New macros.
719 (pos_visible_p, face_before_or_after_it_pos)
720 (back_to_previous_visible_line_start)
721 (move_it_in_display_line_to, move_it_in_display_line)
722 (move_it_to, move_it_vertically_backward, move_it_by_lines)
723 (try_scrolling, redisplay_window, display_line): Use them when
724 saving a temporary copy of the iterator and restoring it back.
725 (back_to_previous_visible_line_start, reseat_1)
726 (init_iterator): Empty the bidi cache "stack".
727 (move_it_in_display_line_to): If iterator ended up at
728 EOL, but we never saw any buffer positions smaller than
729 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
730 motion in bidi-reordered lines.
731 (move_it_in_display_line_to): Record prev_method and prev_pos
732 immediately before the call to set_iterator_to_next. Fixes cursor
733 motion in bidi-reordered lines with stretch glyphs and strings
734 displayed in margins. (Bug#8133) (Bug#8867)
735 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
736 TO_CHARPOS.
737 (pos_visible_p): Support positions in bidi-reordered lines. Save
738 and restore bidi cache.
739
740 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
741 (bidi_paragraph_info): Delete unused struct.
742 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
743 (bidi_cache_start): New variable.
744 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
745 to zero.
746 (bidi_cache_fetch_state, bidi_cache_search)
747 (bidi_cache_find_level_change, bidi_cache_iterator_state)
748 (bidi_cache_find, bidi_peek_at_next_level)
749 (bidi_level_of_next_char, bidi_find_other_level_edge)
750 (bidi_move_to_visually_next): Compare cache index with
751 bidi_cache_start rather than with zero.
752 (bidi_fetch_char): Accept new argument STRING; all callers
753 changed. Support iteration over a string. Support strings with
754 display properties. Support unibyte strings. Fix the type of
755 `len' according to what STRING_CHAR_AND_LENGTH expects.
756 (bidi_paragraph_init, bidi_resolve_explicit_1)
757 (bidi_resolve_explicit, bidi_resolve_weak)
758 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
759 iteration over a string.
760 (bidi_set_sor_type, bidi_resolve_explicit_1)
761 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
762 can now be zero (for strings); special values 0 and -1 were
763 changed to -1 and -2, respectively.
764 (bidi_char_at_pos): New function.
765 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
766 Call it instead of FETCH_MULTIBYTE_CHAR.
767 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
768 initialized to valid values.
769 (bidi_init_it): Don't initialize charpos and bytepos with invalid
770 values.
771 (bidi_level_of_next_char): Allow the sentinel "position" to pass
772 the test for valid cached positions. Fix the logic for looking up
773 the sentinel state in the cache. GCPRO the Lisp string we are
774 iterating.
775 (bidi_push_it, bidi_pop_it): New functions.
776 (bidi_initialize): Initialize the bidi cache start stack pointer.
777 (bidi_cache_ensure_space): New function, refactored from part of
778 bidi_cache_iterator_state. Don't assume the required size is just
779 one BIDI_CACHE_CHUNK away.
780 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
781 (bidi_count_bytes, bidi_char_at_pos): New functions.
782 (bidi_cache_search): Don't assume bidi_cache_last_idx is
783 always valid if bidi_cache_idx is valid.
784 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
785 is valid if it's going to be used.
786 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
787 (bidi_cache_fetch_state, bidi_cache_search)
788 (bidi_cache_find_level_change, bidi_cache_ensure_space)
789 (bidi_cache_iterator_state, bidi_cache_find)
790 (bidi_find_other_level_edge, bidi_cache_start_stack): All
791 variables related to cache indices are now EMACS_INT.
792
793 * dispextern.h (struct bidi_string_data): New structure.
794 (struct bidi_it): New member `string'. Make flag members be 1-bit
795 fields, and put them last in the struct.
796 (compute_display_string_pos, compute_display_string_end): Update
797 prototypes.
798 (bidi_push_it, bidi_pop_it): Add prototypes.
799 (struct iterator_stack_entry): New members bidi_p,
800 paragraph_embedding, and from_disp_prop_p.
801 (struct it): Member bidi_p is now a bit field 1 bit wide.
802 (bidi_shelve_cache, bidi_unshelve_cache): Declare
803 prototypes.
804
805 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
806 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
807 and vector-like objects.
808
809 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
810 cache around display iteration.
811
812 * window.c (Fwindow_end, window_scroll_pixel_based)
813 (displayed_window_lines, Frecenter): Save and restore the bidi
814 cache around display iteration.
815
816 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
817
818 * editfns.c (Fdelete_region): Clarify the use of the named
819 parameters (bug#6788).
820
821 2011-07-14 Martin Rudalics <rudalics@gmx.at>
822
823 * indent.c (Fvertical_motion): Set and restore w->pointm when
824 saving and restoring the window's buffer (Bug#9006).
825
826 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
827
828 * editfns.c (Fstring_to_char): Clarify just what is returned
829 (bug#6576). Text by Eli Zaretskii.
830
831 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
832
833 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
834
835 2011-07-13 Eli Zaretskii <eliz@gnu.org>
836
837 * buffer.c (mmap_find): Fix a typo.
838
839 2011-07-13 Johan Bockgård <bojohan@gnu.org>
840
841 Fix execution of x selection hooks.
842 * xselect.c (Qx_lost_selection_functions)
843 (Qx_sent_selection_functions): New vars.
844 (syms_of_xselect): DEFSYM them.
845 (x_handle_selection_request): Pass Qx_sent_selection_functions
846 rather than Vx_sent_selection_functions to Frun_hook_with_args.
847 (x_handle_selection_clear,x_clear_frame_selections):
848 Pass Qx_lost_selection_functions rather than
849 Vx_lost_selection_functions to Frun_hook_with_args.
850
851 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
852
853 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
854 The old code sometimes used this field without initializing it.
855
856 * alloc.c (gc_sweep): Don't read past end of array.
857 In theory, the old code could also have corrupted Emacs internals,
858 though it'd be very unlikely.
859
860 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
861
862 * character.c (Fcharacterp): Don't advertise optional ignored
863 argument. (Bug#4026)
864
865 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
866
867 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
868 key" (bug#4257).
869
870 * window.c (Fset_window_start): Doc fix (bug#4199).
871 (Fset_window_hscroll): Ditto.
872
873 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
874
875 Fix minor new problems caught by GCC 4.6.1.
876 * term.c (init_tty): Remove unused local.
877 * xsettings.c (store_monospaced_changed): Define this function only
878 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
879 not used otherwise.
880
881 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
882
883 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
884
885 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
886
887 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
888 are the mini-buffer and the echo area (bug#3320).
889
890 * term.c (init_tty): Remove support for supdup, c10 and perq
891 terminals, which are no longer supported (bug#1482).
892
893 2011-07-10 Johan Bockgård <bojohan@gnu.org>
894
895 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
896
897 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
898
899 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
900 for non-popups (Bug#3642).
901
902 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
903
904 * alloc.c (reset_malloc_hooks): Protoize.
905 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
906 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
907 * cm.c (losecursor): Likewise.
908 * data.c (fmod): Likewise.
909 * dispnew.c (swap_glyphs_in_rows): Likewise.
910 * emacs.c (memory_warning_signal): Likewise.
911 * floatfns.c (float_error): Likewise.
912 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
913 (otf_open, font_otf_capability, generate_otf_features)
914 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
915 Likewise.
916 * image.c (pbm_read_file): Likewise.
917 * indent.c (string_display_width): Likewise.
918 * intervals.c (check_for_interval, search_for_interval)
919 (inc_interval_count, count_intervals, root_interval)
920 (adjust_intervals_for_insertion, make_new_interval): Likewise.
921 * lread.c (defalias): Likewise.
922 * ralloc.c (r_alloc_check): Likewise.
923 * regex.c (set_image_of_range_1, set_image_of_range)
924 (regex_grow_registers): Likewise.
925 * sysdep.c (strerror): Likewise.
926 * termcap.c (valid_filename_p, tprint, main): Likewise.
927 * tparam.c (main): Likewise.
928 * unexhp9k800.c (run_time_remap, save_data_space)
929 (update_file_ptrs, read_header, write_header, calculate_checksum)
930 (copy_file, copy_rest, display_header): Likewise.
931 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
932 Likewise.
933 * xdisp.c (check_it): Likewise.
934 * xfaces.c (register_color, unregister_color, unregister_colors):
935 Likewise.
936 * xfns.c (print_fontset_result): Likewise.
937 * xrdb.c (member, fatal, main): Likewise.
938
939 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
940
941 Fix minor problems found by static checking (Bug#9031).
942 * chartab.c (char_table_set_range, map_sub_char_table):
943 Remove unused locals.
944 (uniprop_table): Now static.
945 * composite.c (_work_char): Remove unused static var.
946
947 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
948
949 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
950
951 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
952
953 * gtkutil.c (qttip_cb): Remove code without function.
954
955 2011-07-09 Eli Zaretskii <eliz@gnu.org>
956
957 * w32.c (pthread_sigmask): New stub.
958
959 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
960
961 Use pthread_sigmask, not sigprocmask (Bug#9010).
962 sigprocmask is portable only for single-threaded applications, and
963 Emacs can be multi-threaded when it uses GTK.
964 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
965 (LIBES): Use it.
966 * callproc.c (Fcall_process):
967 * process.c (create_process):
968 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
969 Use pthread_sigmask, not sigprocmask.
970
971 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
972
973 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
974 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
975 wrong (Bug#8591).
976
977 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
978
979 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
980 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
981 (xg_hide_tooltip): Fix comment.
982
983 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
984 in registerServicesMenuSendTypes.
985 (validRequestorForSendType): Don't check ns_return_types.
986
987 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
988 ns_return_type.
989
990 2011-07-08 Jason Rumney <jasonr@gnu.org>
991
992 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
993 frame struct members of non-existent frames (Bug#6284).
994
995 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
996
997 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
998 variable firstTime not needed on OSX >= 10.6.
999 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1000 >= 10.5. Use setKnobProportion, setDoubleValue.
1001
1002 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1003 (MAC_OS_X_VERSION_10_5): Define if not defined.
1004 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1005 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1006 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1007
1008 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1009 cString and lossyCString on OSX >= 10.4
1010
1011 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1012 sizeToFit on OSX >= 10.2.
1013
1014 * nsimage.m (allocInitFromFile): Don't use deprecated method
1015 bestRepresentationForDevice on OSX >= 10.6.
1016
1017 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1018 to avoid warning.
1019
1020 * emacs.c: Declare unexec_init_emacs_zone.
1021
1022 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1023
1024 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1025
1026 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1027 on svcsMenu (Bug#8842).
1028
1029 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1030 ns_return_types.
1031 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1032
1033 * nsterm.m (QUTF8_STRING): Declare.
1034 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1035 (validRequestorForSendType): Return type is (id).
1036 Change indexOfObjectIdenticalTo to indexOfObject.
1037 Check if we have local selection before returning self (Bug#8842).
1038 (writeSelectionToPasteboard): Put local selection into paste board
1039 if we have a local selection (Bug#8842).
1040 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1041
1042 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1043 (ns_get_local_selection): Declare.
1044
1045 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1046
1047 * keymap.c (describe_map_tree): Don't insert a double newline at
1048 the end of the buffer (bug#1169) and return whether we inserted
1049 something.
1050
1051 * callint.c (Fcall_interactively): Change "reading args" to
1052 "providing args" to try to clarify what it does (bug#1010).
1053
1054 2011-07-07 Kenichi Handa <handa@m17n.org>
1055
1056 * composite.c (composition_compute_stop_pos): Ignore a static
1057 composition starting before CHARPOS (Bug#8915).
1058
1059 * xdisp.c (handle_composition_prop): Likewise.
1060
1061 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1062
1063 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1064 (Bug#9015)
1065
1066 2011-07-07 Kenichi Handa <handa@m17n.org>
1067
1068 * character.h (unicode_category_t): New enum type.
1069
1070 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1071 (Qchar_code_property_table): New variable.
1072 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1073 (UNIPROP_COMPRESSED_FORM_P): New macros.
1074 (char_table_ascii): Uncompress the compressed values.
1075 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1076 Uncompress the compressed values.
1077 (sub_char_table_ref_and_range): Likewise.
1078 (char_table_ref_and_range): Uncompress the compressed values.
1079 (sub_char_table_set): New arg is_uniprop. Callers changed.
1080 Uncompress the compressed values.
1081 (sub_char_table_set_range): Args changed. Callers changed.
1082 (char_table_set_range): Adjuted for the above change.
1083 (map_sub_char_table): Delete args default_val and parent. Add arg
1084 top. Give decoded values to a Lisp function.
1085 (map_char_table): Adjusted for the above change. Give decoded
1086 values to a Lisp function. Gcpro more variables.
1087 (uniprop_table_uncompress)
1088 (uniprop_decode_value_run_length): New functions.
1089 (uniprop_decoder, uniprop_decoder_count): New variables.
1090 (uniprop_get_decoder, uniprop_encode_value_character)
1091 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1092 New functions.
1093 (uniprop_encoder, uniprop_encoder_count): New variables.
1094 (uniprop_get_encoder, uniprop_table)
1095 (Funicode_property_table_internal, Fget_unicode_property_internal)
1096 (Fput_unicode_property_internal): New functions.
1097 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1098 Sunicode_property_table_internal, Sget_unicode_property_internal,
1099 and Sput_unicode_property_internal. Defvar_lisp
1100 char-code-property-alist.
1101
1102 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1103 Vunicode_category_table.
1104
1105 * font.c (font_range): Adjusted for the change of
1106 Vunicode_category_table.
1107
1108 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1109
1110 * m/iris4d.h: Remove file, move contents ...
1111 * s/irix6-5.h: ... here.
1112
1113 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 Remove unportable assumption about struct layout (Bug#8884).
1116 * alloc.c (mark_buffer):
1117 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1118 (clone_per_buffer_values): Don't assume that
1119 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1120 This isn't true in general, and it's particularly not true
1121 if Emacs is configured with --with-wide-int.
1122 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1123 New macros, used in the buffer.c change.
1124
1125 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1126
1127 * xsettings.c: Use both GConf and GSettings if both are available.
1128 (store_config_changed_event): Add comment.
1129 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1130 (store_tool_bar_style_changed): New functions.
1131 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1132 (struct xsettings): Move font inside HAVE_XFT.
1133 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1134 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1135 Move inside HAVE_XFT.
1136 (something_changed_gsettingsCB): Renamed from something_changedCB.
1137 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1138 also.
1139 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1140 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1141 (something_changed_gconfCB): Renamed from something_changedCB.
1142 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1143 (parse_settings): Move check for font inside HAVE_XFT.
1144 (read_settings, apply_xft_settings): Add comment.
1145 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1146 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1147 call store_font_name_changed.
1148 (xft_settings_event): Add comment.
1149 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1150 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1151 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1152 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1153 (xsettings_initialize): Call init_gsettings last.
1154 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1155 comment.
1156
1157 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1158
1159 Random fixes. E.g., (random) never returned negative values.
1160 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1161 subseconds part to the entropy, as that's a bit more random.
1162 Prefer signed to unsigned, since the signedness doesn't matter and
1163 in general we prefer signed. When given a limit, use a
1164 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1165 latter isn't right if USE_2_TAGS_FOR_INTS.
1166 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1167 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1168
1169 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1170
1171 * textprop.c (text_property_stickiness):
1172 Obey Vtext_property_default_nonsticky.
1173 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1174 * w32fns.c (syms_of_w32fns):
1175 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1176
1177 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1180 This is more efficient than Ffile_directory_p and avoids a minor race.
1181
1182 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1183
1184 * buffer.c (Foverlay_put): Say what the return value is
1185 (bug#7835).
1186
1187 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1188 is a directory before asking whether to use the file name
1189 (bug#7564).
1190 (barf_or_query_if_file_exists): Make the "File is a directory"
1191 error be more correct.
1192
1193 * fns.c (Frequire): Remove the mention of the .gz files, since
1194 that's installation-specific, but keep the mention of
1195 `get-load-suffixes'.
1196
1197 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1198
1199 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1200 Report string overflow if the output is too long.
1201
1202 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1203
1204 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1205 (syms_of_gnutls): Remove duplicate DEFSYM for
1206 Qgnutls_bootprop_verify_hostname_error, an error for
1207 Qgnutls_bootprop_verify_error (which is no longer used).
1208
1209 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1210 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1211 Also (re)move comments that are misplaced or no longer relevant.
1212
1213 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1214
1215 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1216
1217 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1218
1219 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1220 and background color parameters if they have been changed.
1221
1222 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1223
1224 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1225
1226 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 * xsettings.c (SYSTEM_FONT): Define only when used.
1229 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1230
1231 * keymap.c (access_keymap_1): Now static.
1232
1233 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1234
1235 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1236 leave any prefix arg for the up event (Bug#1586).
1237
1238 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1239
1240 * lread.c (syms_of_lread): Mention single symbols defined by
1241 `defvar' or `defconst' (bug#7154).
1242
1243 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1244 (Frequire): Mention get-load-suffixes.
1245
1246 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1247
1248 * window.h (window): Remove clone_number slot.
1249 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1250 Remove.
1251 (make_parent_window, make_window, saved_window)
1252 (Fset_window_configuration, save_window_save): Don't deal with
1253 clone numbers.
1254 * buffer.c (Qclone_number): Remove declaration.
1255 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1256
1257 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1258
1259 Add multiple inheritance to keymaps.
1260 * keymap.c (Fmake_composed_keymap): New function.
1261 (Fset_keymap_parent): Simplify.
1262 (fix_submap_inheritance): Remove.
1263 (access_keymap_1): New function extracted from access_keymap to handle
1264 embedded parents and handle lists of maps.
1265 (access_keymap): Use it.
1266 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1267 (Fcopy_keymap): Handle embedded parents.
1268 (Fcommand_remapping, define_as_prefix): Simplify.
1269 (Fkey_binding): Simplify.
1270 (syms_of_keymap): Move minibuffer-local-completion-map,
1271 minibuffer-local-filename-completion-map,
1272 minibuffer-local-must-match-map, and
1273 minibuffer-local-filename-must-match-map to Elisp.
1274 (syms_of_keymap): Defsubr make-composed-keymap.
1275 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1276 (parse_menu_item): Trivial simplification.
1277
1278 2011-07-01 Glenn Morris <rgm@gnu.org>
1279
1280 * Makefile.in (SETTINGS_LIBS): Fix typo.
1281
1282 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1283
1284 * coding.c (Fencode_coding_string): Record the last coding system
1285 used, as the function doc string says (bug#8738).
1286
1287 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1288
1289 * xsettings.c (store_monospaced_changed): Take new font as arg and
1290 check for change against current_mono_font.
1291 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1292 (emacs_settings_constructor, emacs_settings_get_property)
1293 (emacs_settings_set_property, emacs_settings_class_init)
1294 (emacs_settings_init, gsettings_obj): Remove.
1295 (something_changedCB): New function for HAVE_GSETTINGS.
1296 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1297 with value as argument.
1298 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1299 g_settings_new (Bug#8967). Do not create gsettings_obj.
1300 Remove calls to g_settings_bind. Connect something_changedCB to
1301 "changed".
1302
1303 * xgselect.c: Add defined (HAVE_GSETTINGS).
1304 (xgselect_initialize): Ditto.
1305
1306 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1307 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1308 xg_select.
1309
1310 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1311
1312 * eval.c (struct backtrace): Simplify and port the data structure.
1313 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1314 signed bit field, as this assumption is not portable and it makes
1315 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1316 "char debug_on_exit : 1" as this is not portable either; instead,
1317 use the portable "unsigned int debug_on_exit : 1". Remove unused
1318 member evalargs. Remove obsolete comments about cc bombing out.
1319
1320 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1321
1322 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1323 Let HAVE_GSETTINGS override HAVE_GCONF.
1324 (store_monospaced_changed): New function.
1325 (EMACS_SETTINGS): A new type derived from GObject to handle
1326 GSettings notifications.
1327 (emacs_settings_constructor, emacs_settings_get_property)
1328 (emacs_settings_set_property, emacs_settings_class_init):
1329 New functions.
1330 (gsettings_client, gsettings_obj): New variables.
1331 (GSETTINGS_SCHEMA): New define.
1332 (something_changedCB): Call store_monospaced_changed.
1333 (init_gsettings): New function.
1334 (xsettings_initialize): Call init_gsettings.
1335 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1336 to NULL.
1337
1338 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1339 GCONF_CFLAGS/LIBS.
1340
1341 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1342
1343 * window.c (resize_root_window, grow_mini_window)
1344 (shrink_mini_window): Rename Qresize_root_window to
1345 Qwindow_resize_root_window and Qresize_root_window_vertically to
1346 Qwindow_resize_root_window_vertically.
1347
1348 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1351
1352 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1353
1354 * makefile.w32-in: Redesign dependencies so they reflect more
1355 clearly which files are directly included by each source file,
1356 and not through other includes.
1357
1358 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1359
1360 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1361 (sort_overlays, overlay_strings): When an overlay's clone number
1362 matches the window's clone number process the overlay even if
1363 the overlay's window property doesn't match the current window.
1364
1365 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1366 (Fwindow_hchild): Rename to Fwindow_left_child.
1367 (Fwindow_next): Rename to Fwindow_next_sibling.
1368 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1369 (resize_window_check): Rename to window_resize_check.
1370 (resize_window_apply): Rename to window_resize_apply.
1371 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1372 (Fdelete_other_windows_internal, resize_frame_windows)
1373 (Fsplit_window_internal, Fdelete_window_internal)
1374 (grow_mini_window, shrink_mini_window)
1375 (Fresize_mini_window_internal): Fix callers accordingly.
1376
1377 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1378
1379 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1380 (emacs_fixed_set_min_size): Remove.
1381 (emacs_fixed_new): Take frame as argument.
1382
1383 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1384 (_EmacsFixedPrivate): Remove minwidth/height.
1385 Add struct frame *f.
1386 (emacs_fixed_init): Initialize priv->f.
1387 (get_parent_class, emacs_fixed_set_min_size): Remove.
1388 (emacs_fixed_new): Set priv->f to argument.
1389 (emacs_fixed_get_preferred_width)
1390 (emacs_fixed_get_preferred_height): Use min_width/height from
1391 frames size_hint to set minimum and natural (Bug#8919).
1392 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1393 and use min_width/height from frames size_hint to set
1394 min_width/height (Bug#8919).
1395
1396 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1397 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1398 Fix indentation.
1399
1400 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1401
1402 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1403 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1404 called at ZV.
1405
1406 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1407
1408 * process.c (wait_reading_process_output): Bypass select if
1409 waiting for a cell while ignoring keyboard input, and input is
1410 pending. Suggested by Jan Djärv (Bug#8869).
1411
1412 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 Use gnulib's dup2 module instead of rolling our own.
1415 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1416
1417 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1418
1419 * dispnew.c (scrolling_window): Before scrolling, turn off a
1420 mouse-highlight in the window being scrolled.
1421
1422 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1423
1424 Move DEFSYM to lisp.h and use everywhere.
1425
1426 * character.h (DEFSYM): Move declaration...
1427 * lisp.h (DEFSYM): ...here.
1428
1429 * gnutls.c:
1430 * minibuf.c:
1431 * w32menu.c:
1432 * w32proc.c:
1433 * w32select.c: Don't include character.h.
1434
1435 * alloc.c (syms_of_alloc):
1436 * buffer.c (syms_of_buffer):
1437 * bytecode.c (syms_of_bytecode):
1438 * callint.c (syms_of_callint):
1439 * casefiddle.c (syms_of_casefiddle):
1440 * casetab.c (init_casetab_once):
1441 * category.c (init_category_once, syms_of_category):
1442 * ccl.c (syms_of_ccl):
1443 * cmds.c (syms_of_cmds):
1444 * composite.c (syms_of_composite):
1445 * dbusbind.c (syms_of_dbusbind):
1446 * dired.c (syms_of_dired):
1447 * dispnew.c (syms_of_display):
1448 * doc.c (syms_of_doc):
1449 * editfns.c (syms_of_editfns):
1450 * emacs.c (syms_of_emacs):
1451 * eval.c (syms_of_eval):
1452 * fileio.c (syms_of_fileio):
1453 * fns.c (syms_of_fns):
1454 * frame.c (syms_of_frame):
1455 * fringe.c (syms_of_fringe):
1456 * insdel.c (syms_of_insdel):
1457 * keymap.c (syms_of_keymap):
1458 * lread.c (init_obarray, syms_of_lread):
1459 * macros.c (syms_of_macros):
1460 * msdos.c (syms_of_msdos):
1461 * print.c (syms_of_print):
1462 * process.c (syms_of_process):
1463 * search.c (syms_of_search):
1464 * sound.c (syms_of_sound):
1465 * syntax.c (init_syntax_once, syms_of_syntax):
1466 * terminal.c (syms_of_terminal):
1467 * textprop.c (syms_of_textprop):
1468 * undo.c (syms_of_undo):
1469 * w32.c (globals_of_w32):
1470 * window.c (syms_of_window):
1471 * xdisp.c (syms_of_xdisp):
1472 * xfaces.c (syms_of_xfaces):
1473 * xfns.c (syms_of_xfns):
1474 * xmenu.c (syms_of_xmenu):
1475 * xsettings.c (syms_of_xsettings):
1476 * xterm.c (syms_of_xterm): Use DEFSYM.
1477
1478 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1479
1480 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1481
1482 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1483
1484 Integer and buffer overflow fixes (Bug#8873).
1485
1486 * print.c (printchar, strout): Check for string overflow.
1487 (PRINTPREPARE, printchar, strout):
1488 Don't set size unless allocation succeeds.
1489
1490 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1491 for sizes. Check for string overflow more accurately.
1492 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1493
1494 * macros.c: Integer and buffer overflow fixes.
1495 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1496 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1497 Use ptrdiff_t, not int, for sizes.
1498 Don't increment bufsize until after realloc succeeds.
1499 Check for size-calculation overflow.
1500 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1501
1502 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1503
1504 * lread.c: Integer overflow fixes.
1505 (read_integer): Radix is now EMACS_INT, not int,
1506 to improve quality of diagnostics for out-of-range radices.
1507 Calculate buffer size correctly for out-of-range radices.
1508 (read1): Check for integer overflow in radices, and in
1509 read-circle numbers.
1510 (read_escape): Avoid int overflow.
1511 (Fload, openp, read_buffer_size, read1)
1512 (substitute_object_recurse, read_vector, read_list, map_obarray):
1513 Use ptrdiff_t, not int, for sizes.
1514 (read1): Use EMACS_INT, not int, for sizes.
1515 Check for size overflow.
1516
1517 * image.c (cache_image): Check for size arithmetic overflow.
1518
1519 * lread.c: Integer overflow issues.
1520 (saved_doc_string_size, saved_doc_string_length)
1521 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1522 Now ptrdiff_t, not int.
1523 (read1): Don't assume doc string length fits in int. Check for
1524 out-of-range doc string lengths.
1525 (read_list): Don't assume file position fits in int.
1526 (read_escape): Check for hex character overflow.
1527
1528 2011-06-22 Leo Liu <sdl.web@gmail.com>
1529
1530 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1531 Move to minibuffer.el.
1532
1533 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1534
1535 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1536 The following patches are for when GLYPH_DEBUG && !XASSERT.
1537 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1538 * dispnew.c (flush_stdout):
1539 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1540 Mark as externally visible.
1541 * dispnew.c (check_window_matrix_pointers): Now static.
1542 * dispnew.c (window_to_frame_vpos):
1543 * xfns.c (unwind_create_frame):
1544 * xterm.c (x_check_font): Remove unused local.
1545 * scroll.c (CHECK_BOUNDS):
1546 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1547 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1548 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1549 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1550 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1551 Now static.
1552 (debug_method_add): Use va_list and vsprintf rather than relying
1553 on undefined behavior with wrong number of arguments.
1554 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1555 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1556 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1557 since we're not interested in debugging glyphs with old libraries.
1558 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1559 GCC 4.6.0's static checking.
1560
1561 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1562
1563 Integer overflow and signedness fixes (Bug#8873).
1564 A few related buffer overrun fixes, too.
1565
1566 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1567
1568 * dispextern.h (struct face.stipple):
1569 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1570 (x_bitmap_mask, x_allocate_bitmap_record)
1571 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1572 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1573 (x_create_bitmap_from_xpm_data):
1574 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1575 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1576 (.bitmaps_last):
1577 * xfaces.c (load_pixmap):
1578 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1579 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1580 (.bitmaps_last, struct x_output.icon_bitmap):
1581 Use ptrdiff_t, not int, for bitmap indexes.
1582 (x_allocate_bitmap_record): Check for size overflow.
1583 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1584
1585 Use ptrdiff_t, not int, for overlay counts.
1586 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1587 * editfns.c (overlays_around, get_pos_property):
1588 * textprop.c (get_char_property_and_overlay):
1589 * xdisp.c (next_overlay_change, note_mouse_highlight):
1590 * xfaces.c (face_at_buffer_position):
1591 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1592 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1593 (Fnext_overlay_change, Fprevious_overlay_change)
1594 (mouse_face_overlay_overlaps, Foverlays_in):
1595 Use ptrdiff_t, not int, for sizes.
1596 (overlays_at, overlays_in): Check for size-calculation overflow.
1597
1598 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1599
1600 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1601 (x_session_initialize): Do not assume string length fits in int.
1602
1603 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1604 This is unlikely, but can occur if DPI is outlandish.
1605
1606 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1607 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1608
1609 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1610 * xrdb.c (magic_file_p, search_magic_path):
1611 Omit last arg SUFFIX; it was always 0. All callers changed.
1612 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1613
1614 * xfont.c (xfont_match): Avoid need for strlen.
1615
1616 * xfns.c: Don't assume strlen fits in int.
1617 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1618
1619 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1620 not unsigned long, as we prefer signed integers. All callers changed.
1621 Detect integer overflow in repeat count.
1622 (message_dolog): Don't assume print length fits in 39 bytes.
1623 (display_mode_element): Don't assume strlen fits in int.
1624
1625 * termcap.c: Don't assume sizes fit in int and never overflow.
1626 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1627 (gobble_line): Check for size-calculation overflow.
1628
1629 * minibuf.c (Fread_buffer):
1630 * lread.c (intern, intern_c_string):
1631 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1632 Don't assume string length fits in int.
1633
1634 * keyboard.c (parse_tool_bar_item):
1635 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1636
1637 * font.c: Don't assume string length fits in int.
1638 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1639 Use ptrdiff_t, not int.
1640 (font_intern_prop): Don't assume string length fits in int.
1641 Don't assume integer property fits in fixnum.
1642 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1643
1644 * filelock.c: Fix some buffer overrun and integer overflow issues.
1645 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1646 Reformulate so as not to need the command string.
1647 Invoke gzip -cd rather than gunzip, as it's more portable.
1648 (lock_info_type, lock_file_1, lock_file):
1649 Don't assume pid_t and time_t fit in unsigned long.
1650 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1651 (current_lock_owner): Prefer signed type for sizes.
1652 Use memcpy, not strncpy, where memcpy is what is really wanted.
1653 Don't assume (via atoi) that time_t and pid_t fit in int.
1654 Check for time_t and/or pid_t out of range, e.g., via a network share.
1655 Don't alloca where an auto var works fine.
1656
1657 * fileio.c: Fix some integer overflow issues.
1658 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1659 Don't assume string length fits in int.
1660 (directory_file_name): Don't assume string length fits in long.
1661 (make_temp_name): Don't assume pid fits in int, or that its print
1662 length is less than 20.
1663
1664 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1665
1666 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1667
1668 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1669
1670 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1671 We prefer signed integers, even for size calculations.
1672
1673 * emacs.c: Don't assume string length fits in 'int'.
1674 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1675 (main): Don't invoke strlen when not needed.
1676
1677 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1678 (XD_DEBUG_MESSAGE): Don't waste a byte.
1679
1680 * callproc.c (getenv_internal_1, getenv_internal)
1681 (Fgetenv_internal):
1682 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1683
1684 * lread.c (invalid_syntax): Omit length argument.
1685 All uses changed. This doesn't fix a bug, but it simplifies the
1686 code away from its former Hollerith-constant appearance, and it's
1687 one less 'int' to worry about when looking at integer-overflow issues.
1688 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1689
1690 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1691 This didn't break anything, but it didn't help either.
1692 It's confusing to put a bogus integer in a place where the actual
1693 value does not matter.
1694 (LIST_END_P): Remove unused macro and its bogus comment.
1695 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1696
1697 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1698 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1699 implementation.
1700 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1701 We prefer signed types, and the value cannot exceed the EMACS_INT
1702 range anyway (because otherwise the length would not be representable).
1703 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1704 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1705 This avoids a GCC warning when WIDE_EMACS_INT.
1706
1707 * indent.c (sane_tab_width): New function.
1708 (current_column, scan_for_column, Findent_to, position_indentation)
1709 (compute_motion): Use it. This is just for clarity.
1710 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1711
1712 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1713
1714 * lisp.h (lint_assume): New macro.
1715 * composite.c (composition_gstring_put_cache):
1716 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1717
1718 * editfns.c, insdel.c:
1719 Omit unnecessary forward decls, to simplify future changes.
1720
1721 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1722
1723 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1724
1725 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1726 Use much-faster test for byte-length change.
1727 Don't assume string byte-length fits in 'int'.
1728 Check that character arg fits in 'int'.
1729 (mapcar1): Declare byte as byte, for clarity.
1730
1731 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1732
1733 * fns.c (concat): Catch string overflow earlier.
1734 Do not rely on integer wraparound.
1735
1736 * dispextern.h (struct it.overlay_strings_charpos)
1737 (struct it.selective): Now EMACS_INT, not int.
1738 * xdisp.c (forward_to_next_line_start)
1739 (back_to_previous_visible_line_start)
1740 (reseat_at_next_visible_line_start, next_element_from_buffer):
1741 Don't arbitrarily truncate the value of 'selective' to int.
1742
1743 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1744
1745 * composite.c: Don't truncate sizes to 'int'.
1746 (composition_gstring_p, composition_reseat_it)
1747 (composition_adjust_point): Use EMACS_INT, not int.
1748 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1749 not EMACS_UINT, for indexes.
1750
1751 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1752
1753 * buffer.c: Include <verify.h>.
1754 (struct sortvec.priority, struct sortstr.priority):
1755 Now EMACS_INT, not int.
1756 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1757 (struct sortstr.size, record_overlay_string)
1758 (struct sortstrlist.size, struct sortlist.used):
1759 Don't truncate size to int.
1760 (record_overlay_string): Check for size-calculation overflow.
1761 (init_buffer_once): Check at compile-time, not run-time.
1762
1763 2011-06-22 Jim Meyering <meyering@redhat.com>
1764
1765 Don't leak an XBM-image-sized buffer
1766 * image.c (xbm_load): Free the image buffer after using it.
1767
1768 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 Port to Sun C.
1771 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1772 that Sun C diagnosed.
1773 * fns.c (secure_hash): Fix pointer signedness issue.
1774 * intervals.c (static_offset_intervals): New function.
1775 (offset_intervals): Use it.
1776
1777 2011-06-21 Leo Liu <sdl.web@gmail.com>
1778
1779 * deps.mk (fns.o):
1780 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1781 sha512.h.
1782
1783 * fns.c (secure_hash): Rename from crypto_hash_function and change
1784 the first arg to accept symbols.
1785 (Fsecure_hash): New primitive.
1786 (syms_of_fns): New symbols.
1787
1788 2011-06-20 Deniz Dogan <deniz@dogan.se>
1789
1790 * process.c (Fset_process_buffer): Clarify return value in
1791 docstring.
1792
1793 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1794
1795 * dispnew.c (add_window_display_history): Use BVAR.
1796
1797 * xdisp.c (debug_method_add): Use BVAR.
1798 (check_window_end, dump_glyph_matrix, dump_glyph)
1799 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1800
1801 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1802 Likewise.
1803
1804 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1805 check till after the cache is created in init_frame_faces.
1806
1807 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1808
1809 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1810
1811 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1812
1813 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1814 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1815 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1816
1817 Improve buffer-overflow checking (Bug#8873).
1818 * fileio.c (Finsert_file_contents):
1819 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1820 Remove the old (too-loose) buffer overflow checks.
1821 They weren't needed, since make_gap checks for buffer overflow.
1822 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1823 The old code merely checked for Emacs fixnum overflow, and relied
1824 on undefined (wraparound) behavior. The new code avoids undefined
1825 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1826
1827 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1828 Tune. Don't use wider integers than needed. Don't use alloca.
1829 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1830
1831 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1832
1833 * insdel.c, lisp.h (buffer_overflow): New function.
1834 (insert_from_buffer_1, replace_range, replace_range_2):
1835 * insdel.c (make_gap_larger):
1836 * editfns.c (Finsert_char):
1837 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1838
1839 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1840
1841 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1842
1843 Integer overflow and signedness fixes (Bug#8873).
1844
1845 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1846 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1847
1848 * fileio.c: Don't assume EMACS_INT fits in off_t.
1849 (emacs_lseek): New static function.
1850 (Finsert_file_contents, Fwrite_region): Use it.
1851 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1852
1853 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1854
1855 * fns.c: Don't overflow int when computing a list length.
1856 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1857 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1858 truncation on 64-bit hosts. Check for QUIT every
1859 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1860 faster and is responsive enough.
1861 (Flength): Report an error instead of overflowing an integer.
1862 (Fsafe_length): Return a float if the value is not representable
1863 as a fixnum. This shouldn't happen except in contrived situations.
1864 (Fnthcdr, Fsort): Don't assume list length fits in int.
1865 (Fcopy_sequence): Don't assume vector length fits in int.
1866
1867 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1868 (header_size, word_size): New constants.
1869 (allocate_vectorlike): Don't check size overflow here.
1870 (allocate_vector): Check it here instead, since this is the only
1871 caller of allocate_vectorlike that could cause overflow.
1872 Check that the new vector's length is representable as a fixnum.
1873
1874 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1875 The previous code was bogus. For example, next_almost_prime (32)
1876 returned 39, which is undesirable as it is a multiple of 3; and
1877 next_almost_prime (24) returned 25, which is a multiple of 5 so
1878 why was the code bothering to check for multiples of 7?
1879
1880 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1881
1882 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1883
1884 Variadic C functions now count arguments with ptrdiff_t.
1885 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1886 Back then I didn't know that the Emacs coding style prefers signed int.
1887 Also, in the meantime I found a few more instances where arguments
1888 were being counted with int, which may truncate counts on 64-bit
1889 machines, or EMACS_INT, which may be unnecessarily wide.
1890 * lisp.h (struct Lisp_Subr.function.aMANY)
1891 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1892 Arg counts are now ptrdiff_t, not size_t.
1893 All variadic functions and their callers changed accordingly.
1894 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1895 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1896 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1897 * callint.c (Fcall_interactively): Check arg count for overflow,
1898 to avoid potential buffer overrun. Use signed char, not 'int',
1899 for 'varies' array, so that we needn't bother to check its size
1900 calculation for overflow.
1901 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1902 * eval.c (apply_lambda):
1903 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1904 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1905 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1906
1907 * callint.c (Fcall_interactively): Don't use index var as event count.
1908
1909 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1910 * mem-limits.h (SIZE): Remove; no longer used.
1911
1912 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1913
1914 Remove unnecessary casts.
1915 * xterm.c (x_term_init):
1916 * xfns.c (x_set_border_pixel):
1917 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1918 These aren't needed now that we assume ANSI C.
1919
1920 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1921 It's more likely to cause problems (due to unsigned overflow)
1922 than to cure them.
1923
1924 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1925
1926 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1927
1928 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1929
1930 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1931
1932 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1933
1934 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1935
1936 GLYPH_CODE_FACE returns EMACS_INT, not int.
1937 * dispextern.h (merge_faces):
1938 * xfaces.c (merge_faces):
1939 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1940 Don't assume EMACS_INT fits in int.
1941
1942 * character.h (CHAR_VALID_P): Remove unused parameter.
1943 * fontset.c, lisp.h, xdisp.c: All uses changed.
1944
1945 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1946
1947 * fns.c (concat): Minor tuning based on overflow analysis.
1948 This doesn't fix any bugs. Use int to hold character, instead
1949 of constantly refetching from Emacs object. Use XFASTINT, not
1950 XINT, for value known to be a character. Don't bother comparing
1951 a single byte to 0400, as it's always less.
1952
1953 * floatfns.c (Fexpt):
1954 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1955
1956 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1957 for characters.
1958
1959 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1960
1961 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1962 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1963 incorrectly succeed when S was a string, because 4294967386 was
1964 truncated before it was used.
1965
1966 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1967 Otherwise, an out-of-range integer could cause undefined behavior
1968 on a 64-bit host.
1969
1970 * composite.c: Use int, not EMACS_INT, for characters.
1971 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1972 EMACS_INT, for values that are known to be in character range.
1973 This doesn't fix any bugs but is the usual style inside Emacs and
1974 may generate better code on 32-bit machines.
1975
1976 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1977 This is for reasons similar to the recent CHAR_STRING fix.
1978 * charset.c (Fencode_char): Check that character arg is actually
1979 a character. Pass an int to ENCODE_CHAR.
1980 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1981 wider than 'int', as a compile-time check to prevent future regressions
1982 in this area.
1983
1984 * character.c (char_string): Remove unnecessary casts.
1985
1986 Make sure a 64-bit char is never passed to CHAR_STRING.
1987 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1988 by silently ignoring the top 32 bits, allowing some values
1989 that were far too large to be valid characters.
1990 * character.h: Include <verify.h>.
1991 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1992 arguments are no wider than unsigned, as a compile-time check
1993 to prevent future regressions in this area.
1994 * data.c (Faset):
1995 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1996 (Fsubst_char_in_region):
1997 * fns.c (concat):
1998 * xdisp.c (decode_mode_spec_coding):
1999 Adjust to CHAR_STRING's new requirement.
2000 * editfns.c (Finsert_char, Fsubst_char_in_region):
2001 * fns.c (concat): Check that character args are actually
2002 characters. Without this test, these functions did the wrong
2003 thing with wildly out-of-range values on 64-bit hosts.
2004
2005 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2006 These casts should not be needed on 32-bit hosts, either.
2007 * keyboard.c (read_char):
2008 * lread.c (Fload): Remove casts to unsigned.
2009
2010 * lisp.h (UNSIGNED_CMP): New macro.
2011 This fixes comparison bugs on 64-bit hosts.
2012 (ASCII_CHAR_P): Use it.
2013 * casefiddle.c (casify_object):
2014 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2015 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2016 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2017 * dispextern.h (FACE_FROM_ID):
2018 * keyboard.c (read_char): Use UNSIGNED_CMP.
2019
2020 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2021 not to EMACS_INT, to avoid GCC warning.
2022
2023 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2024
2025 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2026 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2027 isn't needed on 32-bit machines.
2028
2029 * buffer.c (Fgenerate_new_buffer_name):
2030 Use EMACS_INT for count, not int.
2031 (advance_to_char_boundary): Return EMACS_INT, not int.
2032
2033 * data.c (Qcompiled_function): Now static.
2034
2035 * window.c (window_body_lines): Now static.
2036
2037 * image.c (gif_load): Rename local to avoid shadowing.
2038
2039 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2040 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2041 * alloc.c (make_save_value): Integer argument is now of type
2042 ptrdiff_t, not int.
2043 (mark_object): Use ptrdiff_t, not int.
2044 * lisp.h (pD): New macro.
2045 * print.c (print_object): Use it.
2046
2047 * alloc.c: Use EMACS_INT, not int, to count objects.
2048 (total_conses, total_markers, total_symbols, total_vector_size)
2049 (total_free_conses, total_free_markers, total_free_symbols)
2050 (total_free_floats, total_floats, total_free_intervals)
2051 (total_intervals, total_strings, total_free_strings):
2052 Now EMACS_INT, not int. All uses changed.
2053 (Fgarbage_collect): Compute overall total using a double, so that
2054 integer overflow is less likely to be a problem. Check for overflow
2055 when converting back to an integer.
2056 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2057 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2058 These were 'int' variables that could overflow on 64-bit hosts;
2059 they were never used, so remove them instead of repairing them.
2060 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2061 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2062 Previously, this ceilinged at INT_MAX, but that doesn't work on
2063 64-bit machines.
2064 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2065
2066 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2067 (allocate_vectorlike): Check for ptrdiff_t overflow.
2068 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2069 when a (possibly-narrower) signed value would do just as well.
2070 We prefer using signed arithmetic, to avoid comparison confusion.
2071
2072 * alloc.c: Catch some string size overflows that we were missing.
2073 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2074 for convenience in STRING_BYTES_MAX.
2075 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2076 The definition here is exact; the one in lisp.h was approximate.
2077 (allocate_string_data): Check for string overflow. This catches
2078 some instances we weren't catching before. Also, it catches
2079 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2080 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2081 and ptrdiff_t and EMACS_INT are both 64 bits.
2082
2083 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2084 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2085 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2086
2087 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2088
2089 * alloc.c (Fmake_string): Check for out-of-range init.
2090
2091 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2092
2093 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2094
2095 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2096
2097 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2098 xg_get_default_scrollbar_width.
2099
2100 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2101 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2102 (style_changed_cb): Call update_theme_scrollbar_width and call
2103 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2104 all frames (Bug#8505).
2105 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2106 Call gtk_window_set_resizable if HAVE_GTK3.
2107 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2108 and height if HAVE_GTK3 (Bug#8505).
2109 (scroll_bar_width_for_theme): New variable.
2110 (update_theme_scrollbar_width): New function.
2111 (xg_get_default_scrollbar_width): Move code to
2112 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2113 (xg_initialize): Call update_theme_scrollbar_width.
2114
2115 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2116
2117 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2118
2119 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2120
2121 * frame.c (make_frame): Call other_buffer_safely instead of
2122 other_buffer.
2123
2124 * window.c (temp_output_buffer_show): Call display_buffer with
2125 second argument Vtemp_buffer_show_specifiers and reset latter
2126 immediately after the call.
2127 (Vtemp_buffer_show_specifiers): New variable.
2128 (auto_window_vscroll_p, next_screen_context_lines)
2129 (Vscroll_preserve_screen_position): Remove leading asterisks from
2130 doc-strings.
2131
2132 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 Fix minor problems found by GCC 4.6.0 static checking.
2135 * buffer.c (Qclone_number): Remove for now, as it's unused.
2136 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2137 (record_buffer): Remove unused local.
2138 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2139 (set_frame_buffer_list): Remove; unused.
2140 * frame.h (other_visible_frames): Remove decl.
2141 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2142 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2143 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2144 if HAVE_GPM.
2145 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2146 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2147 Define only if HAVE_GPM.
2148 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2149 (update_hints_inhibit): Remove; never set. All uses removed.
2150 * widgetprv.h (emacsFrameClassRec): Remove decl.
2151 * window.c (delete_deletable_window): Now returns void, since it
2152 wasn't returning anything.
2153 (compare_window_configurations): Remove unused locals.
2154 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2155 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2156 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2157 the same widths as pointers. This follows up on the 2011-05-06 patch.
2158 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2159 * xterm.h: Likewise.
2160 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2161
2162 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2163
2164 * makefile.w32-in: Update dependencies.
2165 (LISP_H): Add lib/intprops.h.
2166
2167 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2168
2169 * image.c (gif_load): Add animation frame delay to the metadata.
2170 (syms_of_image): Use DEFSYM. New symbol `delay'.
2171
2172 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2173
2174 * window.c (delete_deletable_window): Re-add.
2175 (Fset_window_configuration): Rewrite to handle dead buffers and
2176 consequently deletable windows.
2177 (window_tree, Fwindow_tree): Remove. Supply functionality in
2178 window.el.
2179 (compare_window_configurations): Simplify code.
2180
2181 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2182
2183 * image.c (imagemagick_load_image): Fix type mismatch.
2184 (Fimagemagick_types): Likewise.
2185
2186 * window.h (replace_buffer_in_windows): Declare.
2187
2188 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2189
2190 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2191 Qclone_number. Remove external declaration of Qdelete_window.
2192 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2193 code.
2194 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2195 Qbuffer_list_update_hook if allowed.
2196 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2197 buffer list implementation.
2198 (other_buffer_safely): New function.
2199 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2200 calls to replace_buffer_in_windows and
2201 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2202 if allowed.
2203 (record_buffer): Inhibit quitting and rewrite using quittable
2204 functions. Run Qbuffer_list_update_hook if allowed.
2205 (Frecord_buffer, Funrecord_buffer): New functions.
2206 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2207 switch-to-buffer to window.el.
2208 (bury-buffer): Move to window.el.
2209 (Vbuffer_list_update_hook): New variable.
2210
2211 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2212 section.
2213
2214 * window.h (resize_frame_windows): Move up in code.
2215 (Fwindow_frame): Remove EXFUN.
2216 (replace_buffer_in_all_windows): Remove prototype.
2217 (replace_buffer_in_windows_safely): Add prototype.
2218
2219 * window.c: Declare Qdelete_window static again. Move down
2220 declaration of select_count.
2221 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2222 (Fother_window): Move to window.el.
2223 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2224 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2225 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2226 window.el.
2227 (replace_buffer_in_windows): Implement by calling
2228 Qreplace_buffer_in_windows.
2229 (replace_buffer_in_all_windows): Remove with some functionality
2230 moved into replace_buffer_in_windows_safely.
2231 (replace_buffer_in_windows_safely): New function.
2232 (select_window_norecord, select_frame_norecord): Move in front
2233 of run_window_configuration_change_hook. Remove now obsolete
2234 declarations.
2235 (Fset_window_buffer): Rewrite doc-string. Call
2236 Qrecord_window_buffer.
2237 (keys_of_window): Move binding for other-window to window.el.
2238
2239 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2240
2241 * dispextern.h (struct image): Replace data member, whose int_val
2242 and ptr_val fields were not used by anything, with a single
2243 lisp_val object.
2244
2245 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2246 (gif_clear_image, gif_load, imagemagick_load_image)
2247 (gs_clear_image, gs_load): Callers changed.
2248
2249 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2250
2251 * buffer.h: Include <time.h>, for time_t.
2252 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2253
2254 Fix minor problems found by static checking.
2255
2256 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2257
2258 Make identifiers static if they are not used in other modules.
2259 * data.c (Qcompiled_function, Qframe, Qvector):
2260 * image.c (QimageMagick, Qsvg):
2261 * minibuf.c (Qmetadata):
2262 * window.c (resize_window_check, resize_root_window): Now static.
2263 * window.h (resize_window_check, resize_root_window): Remove decls.
2264
2265 * window.c (window_deletion_count, delete_deletable_window):
2266 Remove; unused.
2267 (window_body_lines): Now static.
2268 (Fdelete_other_windows_internal): Mark vars as initialized.
2269 Make sure 'resize_failed' is initialized.
2270 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2271 (resize_window_apply): Remove unused local.
2272 * window.h (delete_deletable_window): Remove decl.
2273
2274 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2275 (imagemagick_load_image): Fix pointer signedness problem by changing
2276 last arg from unsigned char * to char *. All uses changed.
2277 Also, fix a local for similar reasons.
2278 Remove unused locals. Remove locals to avoid shadowing.
2279 (fn_rsvg_handle_free): Remove; unused.
2280 (svg_load, svg_load_image): Fix pointer signedness problem.
2281 (imagemagick_load_image): Don't use garbage pointer image_wand.
2282
2283 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2284
2285 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2286
2287 * image.c (gif_load): Fix omitted cast error introduced by
2288 2011-06-06 change.
2289
2290 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2291
2292 * window.h (resize_proportionally, orig_total_lines)
2293 (orig_top_line): Remove from window structure.
2294 (set_window_height, set_window_width, change_window_heights)
2295 (Fdelete_window): Remove prototypes.
2296 (resize_frame_windows): Remove duplicate declaration.
2297
2298 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2299
2300 * window.h (resize_frame_windows, resize_window_check)
2301 (delete_deletable_window, resize_root_window)
2302 (resize_frame_windows): Declare prototypes.
2303
2304 * window.c (resize_window_apply): Make definition be "static" to
2305 match the prototype.
2306
2307 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2308
2309 * window.c: Remove declarations of Qwindow_size_fixed,
2310 window_min_size_1, window_min_size_2, window_min_size,
2311 size_window, window_fixed_size_p, enlarge_window, delete_window.
2312 Remove static from declaration of Qdelete_window, it's
2313 temporarily needed by Fbury_buffer.
2314 (replace_window): Don't assign orig_top_line and
2315 orig_total_lines.
2316 (Fdelete_window, delete_window): Remove. Window deletion is
2317 handled by window.el.
2318 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2319 Fdelete_window calls with calls to Qdelete_window.
2320 (Fdelete_other_windows): Remove. Deleting other windows is
2321 handled by window.el.
2322 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2323 handled in window.el.
2324 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2325 Window minimum sizes are handled in window.el.
2326 (shrink_windows, size_window, set_window_height)
2327 (set_window_width, change_window_heights, window_height)
2328 (window_width, CURBEG, CURSIZE, enlarge_window)
2329 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2330 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2331 handled in window.el.
2332 (make_dummy_parent): Rename to make_parent_window and give it a
2333 second argument horflag.
2334 (make_window): Don't set resize_proportionally any more.
2335 (Fsplit_window): Remove. Windows are split in window.el.
2336 (save_restore_action, save_restore_orig_size)
2337 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2338 Resize mini windows in window.el.
2339 (grow_mini_window, shrink_mini_window): Implement by calling
2340 Qresize_root_window_vertically, resize_window_check and
2341 resize_window_apply.
2342 (saved_window, Fset_window_configuration, save_window_save): Do
2343 not handle orig_top_line, orig_total_lines, and
2344 resize_proportionally.
2345 (window_min_height, window_min_width): Move to window.el.
2346 (keys_of_window): Move bindings for delete-other-windows,
2347 split-window, delete-window and enlarge-window to window.el.
2348
2349 * buffer.c: Temporarily extern Qdelete_window.
2350 (Fbury_buffer): Temporarily call Qdelete_window instead of
2351 Fdelete_window (Fbury_buffer will move to window.el soon).
2352
2353 * frame.c (set_menu_bar_lines_1): Remove code handling
2354 orig_top_line and orig_total_lines.
2355
2356 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2357 set_window_height but set heights directly.
2358 (change_frame_size_1): Use resize_frame_windows.
2359
2360 * xdisp.c (init_xdisp): Don't use set_window_height but set
2361 heights directly.
2362
2363 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2364 resize_frame_windows instead of change_window_heights and run
2365 run_window_configuration_change_hook.
2366
2367 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2368 instead of change_window_heights and run
2369 run_window_configuration_change_hook.
2370
2371 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2372
2373 * window.c (replace_window): Rename second argument REPLACEMENT to
2374 NEW. New third argument SETFLAG. Rewrite.
2375 (delete_window, make_dummy_parent): Call replace_window with
2376 third argument 1.
2377 (window_list_1): Move down in code.
2378 (run_window_configuration_change_hook): Move set_buffer part
2379 before select_frame_norecord part in order to unwind correctly.
2380 Rename count1 to count.
2381 (recombine_windows, delete_deletable_window, resize_root_window)
2382 (Fdelete_other_windows_internal)
2383 (Frun_window_configuration_change_hook, make_parent_window)
2384 (resize_window_check, resize_window_apply, Fresize_window_apply)
2385 (resize_frame_windows, Fsplit_window_internal)
2386 (Fdelete_window_internal, Fresize_mini_window_internal): New
2387 functions.
2388 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2389
2390 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2391
2392 * window.h (window): Add some new members to window structure -
2393 normal_lines, normal_cols, new_total, new_normal, clone_number,
2394 splits, nest, prev_buffers, next_buffers.
2395 (WINDOW_TOTAL_SIZE): Move here from window.c.
2396 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2397
2398 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2399 Remove.
2400 (make_dummy_parent): Set new members of windows structure.
2401 (make_window): Move down in code. Handle new members of window
2402 structure.
2403 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2404 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2405 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2406 (Fset_window_prev_buffers, Fwindow_next_buffers)
2407 (Fset_window_next_buffers, Fset_window_clone_number): New
2408 functions.
2409 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2410 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2411 Doc-string fixes.
2412 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2413 Argument WINDOW can be now internal window too.
2414 (Fwindow_use_time): Move up in code.
2415 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2416 Rewrite doc-string.
2417 (Fset_window_configuration, saved_window)
2418 (Fcurrent_window_configuration, save_window_save): Handle new
2419 members of window structure.
2420 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2421 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2422 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2423 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2424 Qget_mru_window, Qresize_root_window,
2425 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2426 Qauto_buffer_name; staticpro them.
2427
2428 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2429
2430 * window.c (Fwindow_total_size, Fwindow_left_column)
2431 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2432 (Fwindow_list_1): New functions.
2433 (window_box_text_cols): Replace with window_body_cols.
2434 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2435 window_body_cols instead of window_box_text_cols.
2436 (delete_window, Fset_window_configuration): Call
2437 delete_all_subwindows with window as argument.
2438 (delete_all_subwindows): Take a window as argument and not a
2439 structure. Rewrite.
2440 (window_loop): Remove handling of GET_LRU_WINDOW and
2441 GET_LARGEST_WINDOW.
2442 (Fget_lru_window, Fget_largest_window): Move to window.el.
2443
2444 * window.h: Extern window_body_cols instead of
2445 window_box_text_cols. delete_all_subwindows now takes a
2446 Lisp_Object as argument.
2447
2448 * indent.c (compute_motion, Fcompute_motion): Use
2449 window_body_cols instead of window_box_text_cols.
2450
2451 * frame.c (delete_frame): Call delete_all_subwindows with root
2452 window as argument.
2453
2454 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2455
2456 * fns.c (Fputhash): Document return value.
2457
2458 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2459
2460 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2461
2462 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 Cons<->int and similar integer overflow fixes (Bug#8794).
2465
2466 Check for overflow when converting integer to cons and back.
2467 * charset.c (Fdefine_charset_internal, Fdecode_char):
2468 Use cons_to_unsigned to catch overflow.
2469 (Fencode_char): Use INTEGER_TO_CONS.
2470 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2471 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2472 * data.c (long_to_cons, cons_to_long): Remove.
2473 (cons_to_unsigned, cons_to_signed): New functions.
2474 These signal an error for invalid or out-of-range values.
2475 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2476 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2477 * font.c (Ffont_variation_glyphs):
2478 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2479 * lisp.h: Include <intprops.h>.
2480 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2481 (cons_to_signed, cons_to_unsigned): New decls.
2482 (long_to_cons, cons_to_long): Remove decls.
2483 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2484 (Fprimitive_undo): Use CONS_TO_INTEGER.
2485 * xfns.c (Fx_window_property): Likewise.
2486 * xselect.c: Include <limits.h>.
2487 (x_own_selection, selection_data_to_lisp_data):
2488 Use INTEGER_TO_CONS.
2489 (x_handle_selection_request, x_handle_selection_clear)
2490 (x_get_foreign_selection, Fx_disown_selection_internal)
2491 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2492 (lisp_data_to_selection_data): Use cons_to_unsigned.
2493 (x_fill_property_data): Use cons_to_signed.
2494 Report values out of range.
2495
2496 Check for buffer and string overflow more precisely.
2497 * buffer.h (BUF_BYTES_MAX): New macro.
2498 * lisp.h (STRING_BYTES_MAX): New macro.
2499 * alloc.c (Fmake_string):
2500 * character.c (string_escape_byte8):
2501 * coding.c (coding_alloc_by_realloc):
2502 * doprnt.c (doprnt):
2503 * editfns.c (Fformat):
2504 * eval.c (verror):
2505 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2506 since they may not be the same number.
2507 * editfns.c (Finsert_char):
2508 * fileio.c (Finsert_file_contents):
2509 Likewise for BUF_BYTES_MAX.
2510
2511 * image.c: Use ptrdiff_t, not int, for sizes.
2512 (slurp_file): Switch from int to ptrdiff_t.
2513 All uses changed.
2514 (slurp_file): Check that file size fits in both size_t (for
2515 malloc) and ptrdiff_t (for sanity and safety).
2516
2517 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2518 if b->modtime has its maximal value.
2519
2520 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2521
2522 Don't assume time_t can fit into int.
2523 * buffer.h (struct buffer.modtime): Now time_t, not int.
2524 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2525 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2526
2527 Minor fixes for signed vs unsigned integers.
2528 * character.h (MAYBE_UNIFY_CHAR):
2529 * charset.c (maybe_unify_char):
2530 * keyboard.c (read_char, reorder_modifiers):
2531 XINT -> XFASTINT, since the integer must be nonnegative.
2532 * ftfont.c (ftfont_spec_pattern):
2533 * keymap.c (access_keymap, silly_event_symbol_error):
2534 XUINT -> XFASTINT, since the integer must be nonnegative.
2535 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2536 since it makes no difference and we prefer signed.
2537 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2538 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2539 nonnegative.
2540
2541 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2542
2543 * window.h (Fwindow_frame): Declare.
2544
2545 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2546
2547 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2548 (SPARE_MEMORY): Always define.
2549 (LARGE_REQUEST): Remove.
2550 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2551
2552 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2553
2554 * lisp.h: Move EXFUNS for Fframe_root_window,
2555 Fframe_first_window and Fset_frame_selected_window to window.h.
2556
2557 * window.h: Move EXFUNS for Fframe_root_window,
2558 Fframe_first_window and Fset_frame_selected_window here from
2559 lisp.h.
2560
2561 * frame.c (Fwindow_frame, Fframe_first_window)
2562 (Fframe_root_window, Fframe_selected_window)
2563 (Fset_frame_selected_window): Move to window.c.
2564 (Factive_minibuffer_window): Move to minibuf.c.
2565 (Fother_visible_frames_p): New function.
2566
2567 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2568
2569 * window.c (decode_window, decode_any_window): Move up in code.
2570 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2571 (inhibit_frame_unsplittable): Remove unused variable.
2572 (Fwindow_buffer): Move up and rewrite doc-string.
2573 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2574 (Fwindow_prev): New functions.
2575 (Fwindow_frame): Move here from frame.c. Accept any window as
2576 argument.
2577 (Fframe_root_window, Fframe_first_window)
2578 (Fframe_selected_window): Move here from frame.c. Accept frame
2579 or arbitrary window as argument. Update doc-strings.
2580 (Fminibuffer_window): Move up in code.
2581 (Fwindow_minibuffer_p): Move up in code and simplify.
2582 (Fset_frame_selected_window): Move here from frame.c.
2583 Marginal rewrite.
2584 (Fselected_window, select_window, Fselect_window): Move up in
2585 code. Minor doc-string fixes.
2586
2587 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2588
2589 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2590 Do not assume that spare memory exists; that assumption is valid
2591 only if SYSTEM_MALLOC.
2592 (LARGE_REQUEST): New macro, so that the issue of large requests
2593 is separated from the issue of spare memory.
2594
2595 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2596
2597 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2598 format. (Bug#8806)
2599
2600 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2601
2602 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2603 before statements.
2604
2605 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2606
2607 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2608
2609 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2610
2611 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2612 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2613
2614 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2615
2616 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2617
2618 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2619
2620 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2621 (x_clipboard_manager_save): Add return value.
2622 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2623 New error handlers.
2624 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2625 Obey Vx_select_enable_clipboard_manager. Catch errors in
2626 x_clipboard_manager_save (Bug#8779).
2627 (Vx_select_enable_clipboard_manager): New variable.
2628 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2629
2630 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2631
2632 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2633
2634 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2635
2636 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2637 in the current matrix if keep_current_p is non-zero.
2638
2639 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2640
2641 * bidi.c (bidi_level_of_next_char): Fix last change.
2642
2643 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2644
2645 Support bidi reordering of text covered by display properties.
2646
2647 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2648 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2649 (bidi_cache_search, bidi_cache_iterator_state)
2650 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2651 (bidi_level_of_next_char, bidi_move_to_visually_next):
2652 Support character positions inside a run of characters covered by a
2653 display string.
2654 (bidi_paragraph_init, bidi_resolve_explicit_1)
2655 (bidi_level_of_next_char): Call bidi_fetch_char and
2656 bidi_fetch_char_advance instead of FETCH_CHAR and
2657 FETCH_CHAR_ADVANCE.
2658 (bidi_init_it): Initialize new members.
2659 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2660 definitions.
2661 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2662 instead of using explicit *_CHAR codes.
2663 (bidi_resolve_explicit, bidi_resolve_weak):
2664 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2665 bidirectional text is supported only in multibyte buffers.
2666 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2667 it to initialize the frame_window_p member of struct bidi_it.
2668 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2669 (bidi_resolve_explicit, bidi_resolve_weak)
2670 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2671 bidi_it->nchars is non-positive.
2672 (bidi_level_of_next_char): Don't try to lookup the cache for the
2673 next/previous character if nothing is cached there yet, or if we
2674 were just reseat()'ed to a new position.
2675
2676 * xdisp.c (set_cursor_from_row): Set start and stop points
2677 according to the row's direction when priming the loop that looks
2678 for the glyph on which to display cursor.
2679 (single_display_spec_intangible_p): Function deleted.
2680 (display_prop_intangible_p): Reimplement to call
2681 handle_display_spec instead of single_display_spec_intangible_p.
2682 Accept 3 additional arguments needed by handle_display_spec.
2683 This fixes incorrect cursor motion across display property with complex
2684 values: lists, `(when COND...)' forms, etc.
2685 (single_display_spec_string_p): Support property values that are
2686 lists with the argument STRING its top-level element.
2687 (display_prop_string_p): Fix the condition for processing a
2688 property that is a list to be consistent with handle_display_spec.
2689 (handle_display_spec): New function, refactored from the
2690 last portion of handle_display_prop.
2691 (compute_display_string_pos): Accept additional argument
2692 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2693 value of a `display' property is a "replacing spec".
2694 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2695 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2696 the display property, but just return a value indicating whether
2697 the display property will replace the characters it covers.
2698 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2699 frame_window_p members of struct bidi_it.
2700 (compute_display_string_pos, compute_display_string_end):
2701 New functions.
2702 (push_it): Accept second argument POSITION, where pop_it should
2703 jump to continue iteration.
2704 (reseat_1): Initialize bidi_it.disp_pos.
2705
2706 * keyboard.c (adjust_point_for_property): Adjust the call to
2707 display_prop_intangible_p to its new signature.
2708
2709 * dispextern.h (struct bidi_it): New member frame_window_p.
2710 (bidi_init_it): Update prototypes.
2711 (display_prop_intangible_p): Update prototype.
2712 (compute_display_string_pos, compute_display_string_end):
2713 Declare prototypes.
2714 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2715 EMACS_INT.
2716
2717 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2718
2719 Malloc failure behavior now depends on size of allocation.
2720 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2721 * lisp.h: Change signatures accordingly.
2722 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2723 All callers changed. (Bug#8762)
2724
2725 * gnutls.c: Use Emacs's memory allocators.
2726 Without this change, the gnutls library would invoke malloc etc.
2727 directly, which causes problems on non-SYNC_INPUT hosts, and which
2728 runs afoul of improving memory_full behavior. (Bug#8761)
2729 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2730 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2731 xfree instead of the default malloc, realloc, free.
2732 (Fgnutls_boot): No need to check for memory allocation failure,
2733 since xmalloc does that for us.
2734
2735 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2736 * category.c (hash_get_category_set):
2737 * ccl.c (ccl_driver):
2738 * charset.c (Fdefine_charset_internal):
2739 * charset.h (struct charset.hash_index):
2740 * composite.c (get_composition_id, gstring_lookup_cache)
2741 (composition_gstring_put_cache):
2742 * composite.h (struct composition.hash_index):
2743 * dispextern.h (struct image.hash):
2744 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2745 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2746 (hashfn_equal, hashfn_user_defined, make_hash_table)
2747 (maybe_resize_hash_table, hash_lookup, hash_put)
2748 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2749 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2750 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2751 * image.c (make_image, search_image_cache, lookup_image)
2752 (xpm_put_color_table_h):
2753 * lisp.h (struct Lisp_Hash_Table):
2754 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2755 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2756 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2757 * alloc.c (allocate_vectorlike):
2758 Check for overflow in vector size calculations.
2759 * ccl.c (ccl_driver):
2760 Check for overflow when converting EMACS_INT to int.
2761 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2762 need to be updated by these changes.
2763 * fns.c (make_hash_table, maybe_resize_hash_table):
2764 Check for integer overflow with large hash tables.
2765 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2766 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2767 (SXHASH_REDUCE): New macro.
2768 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2769 Use it instead of discarding useful hash info with large hash values.
2770 (sxhash_float): New function.
2771 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2772 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2773 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2774 Rewrite to use FIXNUM_BITS, as this simplifies things.
2775 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2776 Adjust signatures to match updated version of code.
2777 (consing_since_gc): Now EMACS_INT, since a single hash table can
2778 use more than INT_MAX bytes.
2779
2780 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2781
2782 Make it possible to build with GCC-4.6+ -O2 -flto.
2783
2784 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2785
2786 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2787
2788 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2789 Call minibuffer-inactive-mode.
2790
2791 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2792
2793 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2794 Update dependencies.
2795
2796 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2797
2798 * data.c (init_data): Remove code for UTS, this system is not
2799 supported anymore.
2800
2801 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2802
2803 Don't force ./temacs to start in terminal mode.
2804
2805 * frame.c (make_initial_frame): Initialize faces in all cases, not
2806 only when CANNOT_DUMP is defined.
2807 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2808
2809 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2810
2811 * dispnew.c (add_window_display_history): Use const for the string
2812 pointer. Remove declaration, not needed.
2813
2814 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2815
2816 Use 'inline', not 'INLINE'.
2817 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2818 * alloc.c, fontset.c (INLINE): Remove.
2819 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2820 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2821 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2822 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2823 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2824
2825 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2826
2827 Make it possible to run ./temacs.
2828
2829 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2830 syms_of_callproc does the same thing. Remove test for
2831 "initialized", do it in the caller.
2832 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2833
2834 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2835
2836 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2837 (read_minibuf): Use get_minibuffer.
2838 (syms_of_minibuf): Use DEFSYM.
2839 (Qmetadata): New var.
2840 * data.c (Qbuffer): Don't make it static.
2841 (syms_of_data): Use DEFSYM.
2842
2843 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2844
2845 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2846 (CCL_CODE_MIN): New macro.
2847
2848 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2849
2850 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2851
2852 * eval.c (Qdebug): Now static.
2853 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2854 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2855 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2856
2857 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2858
2859 * image.c: Various fixes to ImageMagick code comments.
2860 (Fimagemagick_types): Doc fix.
2861
2862 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 Minor fixes prompted by GCC 4.6.0 warnings.
2865
2866 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2867
2868 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2869 (x_clipboard_manager_save_all): Move extern decl to ...
2870 * xterm.h: ... here, so that it can be checked for consistency.
2871
2872 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2873
2874 * xselect.c (x_clipboard_manager_save_frame)
2875 (x_clipboard_manager_save_all): New functions.
2876 (Fx_clipboard_manager_save): Lisp function deleted.
2877
2878 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2879 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2880
2881 * xterm.h: Update prototype.
2882
2883 2011-05-28 William Xu <william.xwl@gmail.com>
2884
2885 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2886 exiting (Bug#8239).
2887
2888 2011-05-28 Jim Meyering <meyering@redhat.com>
2889
2890 Avoid a sign-extension bug in crypto_hash_function.
2891 * fns.c (to_uchar): Define.
2892 (crypto_hash_function): Use it to convert some newly-signed
2893 variables to unsigned, to avoid sign-extension bugs. For example,
2894 without this change, (md5 "truc") would evaluate to
2895 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2896 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2897 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2898
2899 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2900
2901 Integer overflow fixes.
2902
2903 * dbusbind.c: Serial number integer overflow fixes.
2904 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2905 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2906 to hold a serial number that is too large for a fixnum.
2907 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2908 Check for serial numbers out of range. Decode any serial number
2909 that was so large that it became a float. (Bug#8722)
2910
2911 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2912 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2913 Use XFASTINT rather than XUINT when numbers are nonnegative.
2914 (xd_append_arg, Fdbus_method_return_internal):
2915 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2916 arguments, check that Lisp number is nonnegative, rather than
2917 silently wrapping negative numbers around. (Bug#8722)
2918 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2919 (Bug#8722)
2920
2921 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2922
2923 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2924
2925 ccl: add integer overflow checks
2926 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2927 (IN_INT_RANGE): New macros.
2928 (ccl_driver): Use them to check for integer overflow when
2929 decoding a CCL program. Many of the new checks are whether XINT (x)
2930 fits in int; it doesn't always, on 64-bit hosts. The new version
2931 doesn't catch all possible integer overflows, but it's an
2932 improvement. (Bug#8719)
2933
2934 * alloc.c (make_event_array): Use XINT, not XUINT.
2935 There's no need for unsigned here.
2936
2937 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2938 This follows up to the 2011-05-06 change that substituted uintptr_t
2939 for EMACS_INT. This case wasn't caught back then.
2940
2941 Rework Fformat to avoid integer overflow issues.
2942 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2943 now (part of C89). Include <verify.h>.
2944 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2945 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2946 (Fformat): Avoid the prepass trying to compute sizes; it was only
2947 approximate and thus did not catch overflow reliably. Instead, walk
2948 through the format just once, formatting and computing sizes as we go,
2949 checking for integer overflow at every step, and allocating a larger
2950 buffer as needed. Keep track separately whether the format is
2951 multibyte. Keep only the most-recently calculated precision, rather
2952 than them all. Record whether each argument has been converted to
2953 string. Use EMACS_INT, not int, for byte and char and arg counts.
2954 Support field widths and precisions larger than INT_MAX. Avoid
2955 sprintf's undefined behavior with conversion specifications such as %#d
2956 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2957 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2958 formatting out-of-range floating point numbers with int
2959 formats. (Bug#8668)
2960
2961 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2962
2963 * data.c: Avoid integer truncation in expressions involving floats.
2964 * data.c: Include <intprops.h>.
2965 (arith_driver): When there's an integer overflow in an expression
2966 involving floating point, convert the integers to floating point
2967 so that the resulting value does not suffer from catastrophic
2968 integer truncation. For example, on a 64-bit host (* 4
2969 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2970 Do not rely on undefined behavior after integer overflow.
2971
2972 merge count_size_as_multibyte, parse_str_to_multibyte
2973 * character.c, character.h (count_size_as_multibyte):
2974 Rename from parse_str_to_multibyte; all uses changed.
2975 Check for integer overflow.
2976 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2977 since it's now a duplicate of the other. This is more of
2978 a character than a buffer op, so better that it's in character.c.
2979 * fns.c, print.c: Adjust to above changes.
2980
2981 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2982
2983 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2984
2985 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2986
2987 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2988 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2989 (x_clipboard_manager_save): Now static.
2990 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2991
2992 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2993 (crypto_hash_function): Now static.
2994 Fix pointer signedness problems. Avoid unnecessary initializations.
2995
2996 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2997
2998 * termhooks.h (Vselection_alist): Make it terminal-local.
2999
3000 * terminal.c (create_terminal): Initialize it.
3001
3002 * xselect.c: Support for clipboard managers.
3003 (Vselection_alist): Move to termhooks.h as terminal-local var.
3004 (LOCAL_SELECTION): New macro.
3005 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3006 (symbol_to_x_atom): Remove gratuitous arg.
3007 (x_handle_selection_request, lisp_data_to_selection_data)
3008 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3009 (x_own_selection, x_get_local_selection, x_convert_selection):
3010 New arg, specifying work frame. Use terminal-local Vselection_alist.
3011 (some_frame_on_display): Delete unused function.
3012 (Fx_own_selection_internal, Fx_get_selection_internal)
3013 (Fx_disown_selection_internal, Fx_selection_owner_p)
3014 (Fx_selection_exists_p): New optional frame arg.
3015 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3016 (x_handle_selection_clear): Don't treat other terminals with the
3017 same keyboard specially. Use the terminal-local Vselection_alist.
3018 (x_clear_frame_selections): Use Frun_hook_with_args.
3019
3020 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3021
3022 * xterm.h: Add support for those atoms.
3023
3024 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3025
3026 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3027 (converted_selections, conversion_fail_tag): New global variables.
3028 (x_selection_request_lisp_error): Free the above.
3029 (x_get_local_selection): Remove unnecessary code.
3030 (x_reply_selection_request): Args changed; handle arbitrary array
3031 of converted selections stored in converted_selections.
3032 Separate the XChangeProperty and SelectionNotify steps.
3033 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3034 (x_convert_selection): New function.
3035 (x_handle_selection_event): Simplify.
3036 (x_get_foreign_selection): Don't ignore incoming requests while
3037 waiting for an answer; this will fail when we implement
3038 SAVE_TARGETS, and seems unnecessary anyway.
3039 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3040 (Vx_sent_selection_functions): Doc fix.
3041
3042 2011-05-26 Leo Liu <sdl.web@gmail.com>
3043
3044 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3045
3046 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3047
3048 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3049
3050 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3051 for fringe update if it has periodic bitmap.
3052 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3053 and fringe_bitmap_periodic_p.
3054
3055 * fringe.c (get_fringe_bitmap_data): New function.
3056 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3057 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3058 row. Mark glyph row for fringe update if periodicity changed.
3059
3060 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3061 for fringe update unless it has periodic bitmap.
3062
3063 2011-05-25 Kenichi Handa <handa@m17n.org>
3064
3065 * xdisp.c (get_next_display_element): Set correct it->face_id for
3066 a static composition.
3067
3068 2011-05-24 Leo Liu <sdl.web@gmail.com>
3069
3070 * deps.mk (fns.o):
3071 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3072
3073 * fns.c (crypto_hash_function, Fsha1): New function.
3074 (Fmd5): Use crypto_hash_function.
3075 (syms_of_fns): Add Ssha1.
3076
3077 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3078
3079 * gnutls.c: Remove unused macros.
3080 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3081 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3082 Remove macros that are defined and never used.
3083 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3084
3085 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3086
3087 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3088 (Fx_get_selection_internal): Minor cleanup.
3089 (Fx_own_selection_internal): Rename arguments for consistency with
3090 select.el.
3091
3092 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3093
3094 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3095
3096 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3097
3098 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3099
3100 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3101
3102 * dispnew.c (scrolling_window): Don't exclude the case that the
3103 last enabled row in the desired matrix touches the bottom boundary.
3104
3105 2011-05-21 Glenn Morris <rgm@gnu.org>
3106
3107 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3108 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3109 and add some more files.
3110
3111 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3112
3113 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3114 report_file_error introduced by the change from 2011-05-07.
3115
3116 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3117
3118 * systime.h (Time): Define only if emacs is defined.
3119 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3120 where the include path doesn't have X11/X.h by default. See
3121 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3122
3123 2011-05-20 Kenichi Handa <handa@m17n.org>
3124
3125 * composite.c (find_automatic_composition): Fix previous change.
3126
3127 2011-05-20 Glenn Morris <rgm@gnu.org>
3128
3129 * lisp.mk: New file, split from Makefile.in.
3130 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3131 (shortlisp): Remove.
3132 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3133
3134 2011-05-19 Glenn Morris <rgm@gnu.org>
3135
3136 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3137 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3138 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3139 (lisp): Set the order to that of loadup.el.
3140 (shortlisp): Make it a copy of $lisp.
3141 (SOME_MACHINE_LISP): Remove.
3142 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3143 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3144
3145 2011-05-18 Kenichi Handa <handa@m17n.org>
3146
3147 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3148 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3149 (find_automatic_composition): Mostly rewrite for efficiency.
3150
3151 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3152
3153 * makefile.w32-in: Update dependencies.
3154
3155 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3156
3157 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3158 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3159
3160 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3161
3162 Fix some integer overflow issues, such as string length overflow.
3163
3164 * insdel.c (count_size_as_multibyte): Check for string overflow.
3165
3166 * character.c (lisp_string_width): Check for string overflow.
3167 Use EMACS_INT, not int, for string indexes and lengths; in
3168 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3169 the resulting string length overflows an EMACS_INT; instead,
3170 report a string overflow if no precision given. When checking for
3171 precision exhaustion, use a check that cannot possibly have
3172 integer overflow. (Bug#8675)
3173 * character.h (lisp_string_width): Adjust to new signature.
3174
3175 * alloc.c (string_overflow): New function.
3176 (Fmake_string): Use it. This doesn't change behavior, but saves
3177 a few bytes and will simplify future changes.
3178 * character.c (string_escape_byte8): Likewise.
3179 * lisp.h (string_overflow): New decl.
3180
3181 Fixups, following up to the user-interface timestamp change.
3182 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3183 for UI timestamps, instead of unsigned long.
3184 * msdos.c (mouse_get_pos): Likewise.
3185 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3186 * w32gui.h (Time): Define by including "systime.h" rather than by
3187 declaring it ourselves. (Bug#8664)
3188
3189 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3190 * image.c (clear_image_cache): Likewise.
3191
3192 * term.c (term_mouse_position): Don't assume time_t wraparound.
3193
3194 Be more systematic about user-interface timestamps.
3195 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3196 and sometimes 'EMACS_UINT', to represent these timestamps.
3197 This change causes it to use 'Time' uniformly, as that's what X uses.
3198 This makes the code easier to follow, and makes it easier to catch
3199 integer overflow bugs such as Bug#8664.
3200 * frame.c (Fmouse_position, Fmouse_pixel_position):
3201 Use Time, not unsigned long, for user-interface timestamps.
3202 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3203 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3204 * keyboard.h (last_event_timestamp): Likewise.
3205 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3206 * menu.h (xmenu_show): Likewise.
3207 * term.c (term_mouse_position): Likewise.
3208 * termhooks.h (struct input_event.timestamp): Likewise.
3209 (struct terminal.mouse_position_hook): Likewise.
3210 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3211 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3212 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3213 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3214 what it was before.
3215 * menu.h, termhooks.h: Include "systime.h", for Time.
3216
3217 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3218 Don't assume that the difference between two unsigned long values
3219 can fit into an integer. At this point, we know button_down_time
3220 <= event->timestamp, so the difference must be nonnegative, so
3221 there's no need to cast the result if double-click-time is
3222 nonnegative, as it should be; check that it's nonnegative, just in
3223 case. This bug is triggered when events are more than 2**31 ms
3224 apart (about 25 days). (Bug#8664)
3225
3226 * xselect.c (last_event_timestamp): Remove duplicate decl.
3227 (x_own_selection): Remove needless cast to unsigned long.
3228
3229 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3230 that always fit in int. Use a sentinel instead of a counter, to
3231 avoid a temp and to allay GCC's concerns about possible int overflow.
3232 * frame.h (struct frame): Use int for menu_bar_items_used
3233 instead of EMACS_INT, since it always fits in int.
3234
3235 * menu.c (grow_menu_items): Check for int overflow.
3236
3237 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3238
3239 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3240 Before, the code was not consistent. These values cannot exceed
3241 2**31 - 1 so there's no need to make them unsigned.
3242 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3243 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3244 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3245 as modifiers.
3246 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3247
3248 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3249 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3250 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3251 presumably because the widths might not match.
3252
3253 * window.c (size_window): Avoid needless test at loop start.
3254
3255 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3256
3257 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3258
3259 2011-05-12 Drew Adams <drew.adams@oracle.com>
3260
3261 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3262
3263 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3264
3265 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3266 `width' to `bar_area_x' and `bar_area_width', respectively.
3267 (x_scroll_run): Take account of fringe background extension.
3268
3269 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3270 Rename local vars `left' and `width' to `bar_area_x' and
3271 `bar_area_width', respectively.
3272 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3273 background extension.
3274
3275 2011-05-10 Jim Meyering <meyering@redhat.com>
3276
3277 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3278
3279 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3280
3281 * image.c (Finit_image_library): Return t for built-in image types,
3282 like pbm and xbm. (Bug#8640)
3283
3284 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3285
3286 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3287
3288 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3289
3290 * w32console.c (Fset_screen_color): Doc fix.
3291 (Fget_screen_color): New function.
3292 (syms_of_ntterm): Defsubr it.
3293
3294 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3295 unlink the temporary file if Fcall_process didn't create it in the
3296 first place.
3297 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3298 child process will be redirected to a file specified with `:file'.
3299 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3300 cue to call_process_cleanup not to close that handle.
3301
3302 2011-05-07 Ben Key <bkey76@gmail.com>
3303
3304 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3305 one of two shell specific rules, either bootstrap-temacs-CMD or
3306 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3307 to the previous implementation of the bootstrap-temacs rule.
3308 The bootstrap-temacs-CMD rule is similar to the previous
3309 implementation of the bootstrap-temacs rule except that it
3310 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3311 variable.
3312
3313 These changes, along with some changes to nt/configure.bat,
3314 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3315 earlier fix to add support for --cflags and --ldflags options
3316 that include quotes so that it works whether make uses cmd or
3317 sh as the shell.
3318
3319 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3320
3321 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3322 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3323 is a constant.
3324 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3325 a string. Handle both cases.
3326 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3327 (Fdbus_register_method): Use Qinvalid_function.
3328
3329 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3330
3331 * makefile.w32-in: Update dependencies.
3332 (LISP_H): Add inttypes.h and stdin.h.
3333 (PROCESS_H): Add unistd.h.
3334
3335 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3336
3337 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3338 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3339
3340 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3343
3344 * term.c (vfatal): Remove stray call to va_end.
3345 It's not needed and the C Standard doesn't allow it here anyway.
3346
3347 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3348 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3349
3350 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3351 bytes.
3352
3353 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3354
3355 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3356
3357 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3358
3359 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3360
3361 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3362
3363 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3364 * charset.c (Fdefine_charset_internal): Don't initialize
3365 charset.code_space[15]. The value was garbage, on hosts with
3366 32-bit int (Bug#8600).
3367
3368 * lread.c (read_integer): Be more consistent with string-to-number.
3369 Use string_to_number to do the actual conversion; this avoids
3370 rounding errors and fixes some other screwups. Without this fix,
3371 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3372 (digit_to_number): Move earlier, for benefit of read_integer.
3373 Return -1 if the digit is out of range for the base, -2 if it is
3374 not a digit in any supported base. (Bug#8602)
3375
3376 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3377
3378 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3379 to match comment at start of function. This also removes a
3380 GCC warning about overflow in a 32+64-bit port.
3381
3382 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3383
3384 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3385 Reported by Stefan Monnier in
3386 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3387 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3388 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3389
3390 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3391 (EMACS_UINTPTR): Likewise, with uintptr_t.
3392
3393 * lisp.h: Prefer 64-bit EMACS_INT if available.
3394 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3395 on 32-bit hosts that have 64-bit int, so that they can access
3396 large files.
3397 However, temporarily disable this change unless the temporary
3398 symbol WIDE_EMACS_INT is defined.
3399
3400 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3401
3402 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3403 This removes an assumption that EMACS_INT and long are the same
3404 width as pointers. The assumption is true for Emacs porting targets
3405 now, but we want to make other targets possible.
3406 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3407 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3408 In the rest of the code, change types of integers that hold casted
3409 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3410 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3411 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3412 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3413 No need to cast type when ORing.
3414 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3415 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3416 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3417 assume EMACS_INT is the same width as char *.
3418 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3419 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3420 Remove no-longer-needed casts.
3421 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3422 (xg_tool_bar_help_callback, xg_make_tool_item):
3423 Use EMACS_INTPTR to hold an integer
3424 that will be cast to void *; this can avoid a GCC warning
3425 if EMACS_INT is not the same width as void *.
3426 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3427 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3428 (current_message_1, set_message_1):
3429 Use a local to convert to proper width without a cast.
3430 * xmenu.c (dialog_selection_callback): Likewise.
3431
3432 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3433 Also, don't assume VALBITS / RAND_BITS is less than 5,
3434 and don't rely on undefined behavior when shifting a 1 left into
3435 the sign bit.
3436 * lisp.h (get_random): Change signature to match.
3437
3438 * lread.c (hash_string): Use size_t, not int, for hash computation.
3439 Normally we prefer signed values; but hashing is special, because
3440 it's better to use unsigned division on hash table sizes so that
3441 the remainder is nonnegative. Also, size_t is the natural width
3442 for hashing into memory. The previous code used 'int', which doesn't
3443 retain enough info to hash well into very large tables.
3444 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3445
3446 * dbusbind.c: Don't possibly lose pointer info when converting.
3447 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3448 Use XPNTR rather than XHASH, so that the high-order bits of
3449 the pointer aren't lost when converting through void *.
3450
3451 * eval.c (Fautoload): Don't double-shift a pointer.
3452
3453 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3454
3455 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3456
3457 * gnutls.c (DEF_GNUTLS_FN):
3458 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3459
3460 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3461
3462 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3463 marker. (Bug#8610)
3464
3465 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3466
3467 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3468 New version that can reserve upto 2GB of heap space.
3469
3470 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3471
3472 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3473
3474 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3475
3476 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3477 `gnutls_certificate_set_x509_key_file'.
3478
3479 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3480
3481 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3482 Update dependencies.
3483
3484 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3485
3486 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3487 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3488 Remove unused parameter `fildes'.
3489 * process.c (read_process_output, send_process): Don't pass it.
3490
3491 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3492
3493 Fix previous change: the library cache is defined in w32.c.
3494 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3495 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3496
3497 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3498
3499 Implement dynamic loading of GnuTLS on Windows.
3500
3501 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3502 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3503 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3504 Declare.
3505
3506 * gnutls.c (Qgnutls_dll): Define.
3507 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3508 (gnutls_*): Declare function pointers.
3509 (init_gnutls_functions): New function to initialize function pointers.
3510 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3511 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3512 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3513 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3514 (emacs_gnutls_write, emacs_gnutls_read)
3515 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3516 (Fgnutls_available_p): New function.
3517 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3518 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3519 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3520
3521 * image.c: Include w32.h.
3522 (Vimage_type_cache): Delete.
3523 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3524 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3525 (w32_delayed_load): Move to w32.c.
3526
3527 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3528
3529 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3530 (w32_delayed_load): Move from image.c. When loading a library, record
3531 its filename in the :loaded-from property of the library id.
3532 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3533 Initialize and staticpro them.
3534 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3535
3536 * process.c: Include lisp.h before w32.h, not after.
3537 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3538 instead of gnutls_record_check_pending.
3539
3540 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3541
3542 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3543
3544 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3545 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3546 as passed in.
3547
3548 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3549
3550 * xterm.c (x_set_frame_alpha): Do not set property on anything
3551 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3552
3553 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3554
3555 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3556
3557 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3558
3559 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3560 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3561 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3562 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3563 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3564 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3565 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3566 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3567 (Qgnutls_bootprop_callbacks_verify): Make static.
3568
3569 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3570
3571 * callproc.c: Indentation fixup.
3572
3573 * sysdep.c (wait_for_termination_1): Make static.
3574 (wait_for_termination, interruptible_wait_for_termination):
3575 Move after wait_for_termination_1.
3576
3577 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3578
3579 * sysdep.c (interruptible_wait_for_termination): New function
3580 which is like wait_for_termination, but allows keyboard
3581 interruptions.
3582
3583 * callproc.c (Fcall_process): Add (:file "file") as an option for
3584 the STDOUT buffer.
3585 (Fcall_process_region): Ditto.
3586
3587 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3588
3589 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3590 rather than `XVECTOR (FOO)->size'.
3591
3592 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3593 inttypes.h, as a gnulib replacement is used if it not available in
3594 system headers.
3595
3596 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3597
3598 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3599 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3600 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3601
3602 * coding.c (coding_alloc_by_realloc): Error out if destination
3603 will grow beyond MOST_POSITIVE_FIXNUM.
3604 (decode_coding_emacs_mule): Abort if there isn't enough place in
3605 charbuf for the composition carryover bytes. Reserve an extra
3606 space for up to 2 characters produced in a loop.
3607 (decode_coding_iso_2022): Abort if there isn't enough place in
3608 charbuf for the composition carryover bytes.
3609
3610 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3611
3612 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3613 aborting when %lld or %lll format is passed.
3614 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3615 %llo or %llx format is passed. (Bug#8545)
3616
3617 * window.c (window_scroll_line_based): Use a marker instead of
3618 simple variables to record original value of point. (Bug#7952)
3619
3620 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3621 produced by %s or %c overflows available buffer space. (Bug#8545)
3622
3623 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3624
3625 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3626 (SIZE_MAX): Move defn after all includes, as they might #define it.
3627
3628 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3629
3630 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3631
3632 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3633
3634 * keyboard.c (Qdelayed_warnings_hook): Define.
3635 (command_loop_1): Run `delayed-warnings-hook'
3636 if Vdelayed_warnings_list is non-nil.
3637 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3638 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3639
3640 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3641
3642 * doprnt.c (doprnt): Don't return value smaller than the buffer
3643 size if the message was truncated. (Bug#8545).
3644
3645 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3646
3647 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3648 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3649
3650 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3651
3652 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3653
3654 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3655
3656 * makefile.w32-in: Update dependencies.
3657
3658 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3659
3660 Improve `doprnt' and its usage. (Bug#8545)
3661 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3662 `format_end'. Remove support for %l as a conversion specifier.
3663 Don't use xrealloc. Improve diagnostics when the %l size modifier
3664 is used. Update the commentary.
3665
3666 * eval.c (verror): Simplify calculation of size_t.
3667
3668 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3669 messages.
3670
3671 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3672
3673 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3674 change.
3675
3676 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3677
3678 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3679 This makes this file independent of the recent pseudovector change.
3680
3681 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3684
3685 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3686 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3687 Remove unused local.
3688 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3689
3690 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3691 GCC 4.6.0 optimizes based on type-based alias analysis.
3692 For example, if b is of type struct buffer * and v of type struct
3693 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3694 != &v->size, and therefore "v->size = 1; b->size = 2; return
3695 v->size;" must therefore return 1. This assumption is incorrect
3696 for Emacs, since it type-puns struct Lisp_Vector * with many other
3697 types. To fix this problem, this patch adds a new type struct
3698 vectorlike_header that documents the constraints on layout of vectors
3699 and pseudovectors, and helps optimizing compilers not get fooled
3700 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3701 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3702 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3703 the size member.
3704 (XSETPVECTYPE): Rewrite in terms of new macro.
3705 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3706 This is a bit clearer, and further avoids the possibility of
3707 undesirable aliasing.
3708 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3709 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3710 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3711 since Lisp_Subr is a special case (no "next" field).
3712 (ASIZE): Now uses header.size rather than size.
3713 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3714 to avoid the hassle of writing XVECTOR (foo)->header.size.
3715 (struct vectorlike_header): New type.
3716 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3717 object, to help avoid aliasing.
3718 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3719 (SUBRP): Likewise, since Lisp_Subr is a special case.
3720 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3721 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3722 (struct Lisp_Hash_Table): Combine first two members into a single
3723 struct vectorlike_header member. All uses of "size" and "next" members
3724 changed to be "header.size" and "header.next".
3725 * buffer.h (struct buffer): Likewise.
3726 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3727 * frame.h (struct frame): Likewise.
3728 * process.h (struct Lisp_Process): Likewise.
3729 * termhooks.h (struct terminal): Likewise.
3730 * window.c (struct save_window_data, struct saved_window): Likewise.
3731 * window.h (struct window): Likewise.
3732 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3733 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3734 * buffer.c (init_buffer_once): Likewise.
3735 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3736 special case.
3737 * process.c (Fformat_network_address): Use local var for size,
3738 for brevity.
3739
3740 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3741
3742 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3743 * data.c (atof): Remove decl; no longer used or needed.
3744 (digit_to_number): Move to lread.c.
3745 (Fstring_to_number): Use new string_to_number function, to be
3746 consistent with how the Lisp reader treats infinities and NaNs.
3747 Do not assume that floating-point numbers represent EMACS_INT
3748 without losing information; this is not true on most 64-bit hosts.
3749 Avoid double-rounding errors, by insisting on integers when
3750 parsing non-base-10 numbers, as the documentation specifies.
3751 * lisp.h (string_to_number): New decl, replacing ...
3752 (isfloat_string): Remove.
3753 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3754 (read1): Do not accept +. and -. as integers; this
3755 appears to have been a coding error. Similarly, do not accept
3756 strings like +-1e0 as floating point numbers. Do not report
3757 overflow for integer overflows unless the base is not 10 which
3758 means we have no simple and reliable way to continue.
3759 Break out the floating-point parsing into a new
3760 function string_to_number, so that Fstring_to_number parses
3761 floating point numbers consistently with the Lisp reader.
3762 (digit_to_number): Move here from data.c. Make it static inline.
3763 (E_CHAR, EXP_INT): Remove, replacing with ...
3764 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3765 (string_to_number): New function, replacing isfloat_string.
3766 This function checks for valid syntax and produces the resulting
3767 Lisp float number too. Rework it so that string-to-number
3768 no longer mishandles examples like "1.0e+". Use strtoumax,
3769 so that overflow for non-base-10 numbers is reported only when
3770 there's no portable and simple way to convert to floating point.
3771
3772 * textprop.c (set_text_properties_1): Rewrite for clarity,
3773 and to avoid GCC warning about integer overflow.
3774
3775 * intervals.h (struct interval): Use EMACS_INT for members
3776 where EMACS_UINT might cause problems. See
3777 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3778 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3779 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3780 All uses changed.
3781 (offset_intervals): Tell GCC not to worry about length overflow
3782 when negating a negative length.
3783
3784 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3785 (overrun_check_free): Likewise.
3786
3787 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3788 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3789 word size.
3790
3791 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3792 (gnutls_make_error): Rename local to avoid shadowing.
3793 (gnutls_emacs_global_deinit): ifdef out; not used.
3794 (Fgnutls_boot): Use const for pointer to readonly storage.
3795 Comment out unused local. Fix pointer signedness problems.
3796
3797 * lread.c (openp): Don't stuff size_t into an 'int'.
3798 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3799 about possible signed overflow.
3800
3801 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3802 (GDK_KEY_g): Don't define if already defined.
3803 (xg_prepare_tooltip): Avoid pointer signedness problem.
3804 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3805
3806 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3807 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3808
3809 * xfns.c (Fx_window_property): Simplify a bit,
3810 to make a bit faster and to avoid GCC 4.6.0 warning.
3811 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3812
3813 * fns.c (internal_equal): Don't assume size_t fits in int.
3814
3815 * alloc.c (compact_small_strings): Tighten assertion a little.
3816
3817 Replace pEd with more-general pI, and fix some printf arg casts.
3818 * lisp.h (pI): New macro, generalizing old pEd macro to other
3819 conversion specifiers. For example, use "...%"pI"d..." rather
3820 than "...%"pEd"...".
3821 (pEd): Remove. All uses replaced with similar uses of pI.
3822 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3823 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3824 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3825 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3826 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3827 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3828 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3829 64-bit hosts.
3830 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3831 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3832 * print.c (safe_debug_print, print_object): Likewise.
3833 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3834 to int.
3835 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3836 avoiding the 0 flag, which is not portable.
3837 * process.c (Fmake_network_process): Use pI to avoid cast.
3838 * region-cache.c (pp_cache): Likewise.
3839 * xdisp.c (decode_mode_spec): Likewise.
3840 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3841 behavior on 64-bit hosts with printf arg.
3842 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3843 (x_stop_queuing_selection_requests): Likewise.
3844 (x_get_window_property): Don't truncate byte count to an 'int'
3845 when tracing.
3846
3847 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3848 here, since it parses constructs like leading '-' and spaces,
3849 which are not wanted; and it overflows with large numbers.
3850 Instead, simply match F[0-9]+, which is what is wanted anyway.
3851
3852 * alloc.c: Remove unportable assumptions about struct layout.
3853 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3854 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3855 (allocate_vectorlike, make_pure_vector): Use the new macros,
3856 plus offsetof, to remove unportable assumptions about struct layout.
3857 These assumptions hold on all porting targets that I know of, but
3858 they are not guaranteed, they're easy to remove, and removing them
3859 makes further changes easier.
3860
3861 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3862 This doesn't fix a bug but makes the code clearer.
3863 (string_overrun_cookie): Now const. Use initializers that
3864 don't formally overflow signed char, to avoid warnings.
3865 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3866 can cause Emacs to crash when string overrun checking is enabled.
3867 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3868 multiple of sizeof (EMACS_INT); it need not be, if
3869 alignof(EMACS_INT) < sizeof (EMACS_INT).
3870 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3871
3872 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3873
3874 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3875
3876 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3877
3878 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3879 supposed to be handshaking. (Bug#8556)
3880 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3881
3882 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3883
3884 * lisp.h (Qdebug): List symbol.
3885 * eval.c (Qdebug): Restore global linkage.
3886 * keyboard.c (debug-on-event): New variable.
3887 (handle_user_signal): Break into debugger when debug-on-event
3888 matches the current signal symbol.
3889
3890 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3891
3892 * alloc.c (check_sblock, check_string_bytes)
3893 (check_string_free_list): Convert to standard C.
3894
3895 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3896
3897 * w32.c (emacs_gnutls_push): Fix typo.
3898
3899 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3900
3901 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3902 "cast to pointer from integer of different size".
3903
3904 Improve doprnt and its use in verror. (Bug#8545)
3905 * doprnt.c (doprnt): Document the set of format control sequences
3906 supported by the function. Use SAFE_ALLOCA instead of always
3907 using `alloca'.
3908
3909 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3910 is one byte too soon. Don't use xrealloc; instead xfree and
3911 xmalloc anew.
3912
3913 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3914
3915 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3916 callbacks stage.
3917
3918 * gnutls.c: Renamed global_initialized to
3919 gnutls_global_initialized. Added internals for the
3920 :verify-hostname-error, :verify-error, and :verify-flags
3921 parameters of `gnutls-boot' and documented those parameters in the
3922 docstring. Start callback support.
3923 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3924 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3925 on error. Return error code.
3926 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3927 (emacs_gnutls_read): Likewise.
3928 (Fgnutls_boot): Return handshake error code.
3929 (emacs_gnutls_handle_error): New function.
3930 (wsaerror_to_errno): Likewise.
3931
3932 * w32.h (emacs_gnutls_pull): Add prototype.
3933 (emacs_gnutls_push): Likewise.
3934
3935 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3936 (emacs_gnutls_push): Likewise.
3937
3938 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3939
3940 * process.c (wait_reading_process_output): Check if GnuTLS
3941 buffered some data internally if no FDs are set for TLS
3942 connections.
3943
3944 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3945 (LIBS): Link to USER_LIBS.
3946 ($(BLD)/gnutls.$(0)): New target.
3947
3948 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3949
3950 * xdisp.c (handle_single_display_spec): Rename the
3951 display_replaced_before_p argument into display_replaced_p, to
3952 make it consistent with the commentary. Fix typos in the
3953 commentary.
3954
3955 * textprop.c (syms_of_textprop): Remove dead code.
3956 (copy_text_properties): Delete obsolete commentary about an
3957 interface that was deleted long ago. Fix typos in the description
3958 of arguments.
3959
3960 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3961 to changes in oldXMenu/XMenu.h from 2011-04-16.
3962 <menu_help_message, prev_menu_help_message>: Constify.
3963 (IT_menu_make_room): menu->help_text is now `const char **';
3964 adjust.
3965
3966 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3967 to changes in oldXMenu/XMenu.h from 2011-04-16.
3968 (struct XMenu): Declare `help_text' `const char **'.
3969
3970 * xfaces.c <Qunspecified>: Make extern again.
3971
3972 * syntax.c: Include sys/types.h before including regex.h, as
3973 required by Posix.
3974
3975 * doc.c (get_doc_string): Improve the format passed to `error'.
3976
3977 * doprnt.c (doprnt): Improve commentary.
3978
3979 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3980
3981 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3982 them with etags.
3983
3984 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3985 changes in globals.h immediately force recompilation.
3986 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3987 $(CURDIR)/s/ms-w32.h.
3988 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3989
3990 * character.c (Fchar_direction): Function deleted.
3991 (syms_of_character): Don't defsubr it.
3992 <char-direction-table>: Deleted.
3993
3994 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3995
3996 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3997 * doprnt.c: Include limits.h.
3998 (SIZE_MAX): New macro.
3999 (doprnt): Return a size_t value. 2nd arg is now size_t.
4000 Many local variables are now size_t instead of int or unsigned.
4001 Improve overflow protection. Support `l' modifier for integer
4002 conversions. Support %l conversion. Don't assume an EMACS_INT
4003 argument for integer conversions and for %c.
4004
4005 * lisp.h (doprnt): Restore prototype.
4006
4007 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4008 $(SRC)/character.h.
4009
4010 * Makefile.in (base_obj): Add back doprnt.o.
4011
4012 * deps.mk (doprnt.o): Add back prerequisites.
4013 (callint.o): Depend on character.h.
4014
4015 * eval.c (internal_lisp_condition_case): Include the handler
4016 representation in the error message.
4017 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4018 when breaking from the loop.
4019
4020 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4021
4022 * callint.c (Fcall_interactively): When displaying error message
4023 about invalid control letter, pass the character's codepoint, not
4024 a pointer to its multibyte form. Improve display of the character
4025 in octal and display also its hex code.
4026
4027 * character.c (char_string): Use %x to display the (unsigned)
4028 codepoint of an invalid character, to avoid displaying a bogus
4029 negative value.
4030
4031 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4032 `error', not SYMBOL_NAME itself.
4033
4034 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4035 character arguments to `error'.
4036
4037 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4038 to `error' in error message about FINAL_CHAR argument. Make sure
4039 FINAL_CHAR is a character, and use %c when it is passed as
4040 argument to `error'.
4041
4042 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4043
4044 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4045
4046 * w32.c: Include <time.h>.
4047 (sys_localtime): New function.
4048
4049 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4050
4051 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4052
4053 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4054
4055 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4056
4057 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4058 zombies (Bug#8467).
4059
4060 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4061
4062 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4063 gl_state.e_property when gl_state.object is Qt.
4064
4065 * insdel.c (make_gap_larger): Remove limitation of buffer size
4066 to <= INT_MAX.
4067
4068 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4069
4070 * xdisp.c (lookup_glyphless_char_display)
4071 (produce_glyphless_glyph): Handle cons cell entry in
4072 glyphless-char-display.
4073 (Vglyphless_char_display): Document it.
4074
4075 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4076 glyphless-char-display.
4077
4078 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4079
4080 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4081
4082 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4083
4084 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4085 definition for no-X builds.
4086
4087 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 Static checks with GCC 4.6.0 and non-default toolkits.
4090
4091 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4092
4093 * process.c (keyboard_bit_set): Define only if SIGIO.
4094 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4095 (send_process): Repair possible setjmp clobbering.
4096
4097 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4098
4099 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4100
4101 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4102
4103 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4104 Define only if needed.
4105
4106 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4107 by pacifying GCC about it. Maybe it's time to retire it?
4108 * xfaces.c (USG, __TIMEVAL__): Likewise.
4109
4110 * dispextern.h (struct redisplay_interface): Rename param
4111 to avoid shadowing.
4112 * termhooks.h (struct terminal): Likewise.
4113 * xterm.c (xembed_send_message): Likewise.
4114
4115 * insdel.c (make_gap_smaller): Define only if
4116 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4117
4118 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4119 it.
4120
4121 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4122 so that we aren't warned about unused symbols.
4123
4124 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4125
4126 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4127
4128 * xfns.c (x_real_positions): Mark locals as initialized.
4129
4130 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4131
4132 * xterm.c: Fix problems found by static analysis with other toolkits.
4133 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4134 (x_dispatch_event): Declare static if USE_GTK, and
4135 define if USE_GTK || USE_X_TOOLKIT.
4136 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4137 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4138 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4139 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4140
4141 * xmenu.c (menu_help_callback): Pointer type fixes.
4142 Use const pointers when pointing at readonly data. Avoid pointer
4143 signedness clashes.
4144 (FALSE): Remove unused macro.
4145 (update_frame_menubar): Remove unused decl.
4146
4147 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4148
4149 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4150 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4151 (single_menu_item): Rename local to avoid shadowing.
4152
4153 * keyboard.c (make_lispy_event): Remove unused local var.
4154
4155 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4156 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4157
4158 * bitmaps: Change bitmaps from unsigned char back to the X11
4159 compatible char. Avoid the old compiler warnings about
4160 out-of-range initializers by using, for example, '\xab' rather
4161 than 0xab.
4162
4163 * xgselect.c (xgselect_initialize): Check vs interface
4164 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4165
4166 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4167
4168 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4169 to read-only memory.
4170
4171 * fns.c (vector): Remove; this old hack is no longer needed.
4172
4173 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4174 Remove unused var.
4175 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4176
4177 * xrdb.c (x_load_resources): Omit unused local.
4178
4179 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4180 (x_window): Rename locals to avoid shadowing.
4181 (USG): Use the kludged USG macro, to pacify gcc.
4182
4183 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4184 (x_term_init): Remove local to avoid shadowing.
4185
4186 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4187
4188 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4189 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4190
4191 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4192
4193 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4194
4195 Fix regex.c, syntax.c and friends for buffers > 2GB.
4196 * syntax.h (struct gl_state_s): Declare character position members
4197 EMACS_INT.
4198
4199 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4200
4201 * textprop.c (verify_interval_modification, interval_of):
4202 Declare arguments EMACS_INT.
4203
4204 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4205 EMACS_INT.
4206
4207 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4208
4209 * indent.c (Fvertical_motion): Local variable it_start is now
4210 EMACS_INT.
4211
4212 * regex.c (re_match, re_match_2, re_match_2_internal)
4213 (bcmp_translate, regcomp, regexec, print_double_string)
4214 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4215 (re_compile_pattern, re_exec): Declare arguments and local
4216 variables `size_t' and `ssize_t' and return values `regoff_t', as
4217 appropriate.
4218 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4219 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4220 <compile_stack_type>: `size' and `avail' are now `size_t'.
4221
4222 * regex.h <regoff_t>: Use ssize_t, not int.
4223 (re_search, re_search_2, re_match, re_match_2): Arguments that
4224 specify buffer/string position and length are now ssize_t and
4225 size_t. Return type is regoff_t.
4226
4227 2011-04-16 Ben Key <bkey76@gmail.com>
4228
4229 * nsfont.m: Fixed bugs in ns_get_family and
4230 ns_descriptor_to_entity that were caused by using free to
4231 deallocate memory blocks that were allocated by xmalloc (via
4232 xstrdup). This caused Emacs to crash when compiled with
4233 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4234 --enable-checking=xmallocoverrun). xfree is now used to
4235 deallocate these memory blocks.
4236
4237 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4238
4239 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4240
4241 emacs_write: Accept and return EMACS_INT for sizes.
4242 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4243 et seq.
4244 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4245 Accept and return EMACS_INT.
4246 (emacs_gnutls_write): Return the number of bytes written on
4247 partial writes.
4248 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4249 (emacs_read, emacs_write): Remove check for negative size, as the
4250 Emacs source code has been audited now.
4251 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4252 (emacs_read, emacs_write): Use it.
4253 * process.c (send_process): Adjust to the new signatures of
4254 emacs_write and emacs_gnutls_write. Do not attempt to store
4255 a byte offset into an 'int'; it might overflow.
4256 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4257
4258 * sound.c: Don't assume sizes fit in 'int'.
4259 (struct sound_device.period_size, alsa_period_size):
4260 Return EMACS_INT, not int.
4261 (struct sound_device.write, vox_write, alsa_write):
4262 Accept EMACS_INT, not int.
4263 (wav_play, au_play): Use EMACS_INT to store sizes and to
4264 record read return values.
4265
4266 2011-04-15 Ben Key <bkey76@gmail.com>
4267
4268 * keyboard.c (Qundefined): Don't declare static since it is used
4269 in nsfns.m.
4270 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4271 static since they are used in nsfont.m.
4272
4273 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4274
4275 * process.c (Qprocessp): Don't declare static.
4276 * lisp.h (Qprocessp): Declare again.
4277
4278 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4279
4280 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4281
4282 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4283
4284 Improve C-level modularity by making more things 'static'.
4285
4286 Don't publish debugger-only interfaces to other modules.
4287 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4288 (verify_bytepos, count_markers): Move decls to the only modules
4289 that need them.
4290 * region-cache.h (pp_cache): Likewise.
4291 * window.h (check_all_windows): Likewise.
4292 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4293
4294 * sysdep.c (croak): Now static, if
4295 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4296 * syssignal.h (croak): Declare only if not static.
4297
4298 * alloc.c (refill_memory_reserve): Now static if
4299 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4300 * lisp.h (refill_memory_reserve): Declare only if not static.
4301
4302 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4303 Define only if USE_LUCID.
4304
4305 * xrdb.c (x_customization_string, x_rm_string): Now static.
4306
4307 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4308 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4309
4310 * xdisp.c (draw_row_with_mouse_face): Now static.
4311 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4312
4313 * window.h (check_all_windows): Mark externally visible.
4314
4315 * window.c (window_deletion_count): Now static.
4316
4317 * undo.c: Make symbols static if they're not exported.
4318 (last_undo_buffer, last_boundary_position, pending_boundary):
4319 Now static.
4320
4321 * textprop.c (interval_insert_behind_hooks): Now static.
4322 (interval_insert_in_front_hooks): Likewise.
4323
4324 * term.c: Make symbols static if they're not exported.
4325 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4326 (max_frame_lines, tty_set_terminal_modes):
4327 (tty_reset_terminal_modes, tty_turn_off_highlight):
4328 (get_tty_terminal): Now static.
4329 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4330 * termhooks.h (term_mouse_moveto): Do not declare if
4331 HAVE_WINDOW_SYSTEM.
4332 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4333 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4334
4335 * sysdep.c: Make symbols static if they're not exported.
4336 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4337 Now static.
4338 (sigprocmask_set, full_mask): Remove; unused.
4339 (wait_debugging): Mark as visible.
4340 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4341 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4342
4343 * syntax.c (syntax_temp): Define only if !__GNUC__.
4344
4345 * sound.c (current_sound_device, current_sound): Now static.
4346
4347 * search.c (searchbufs, searchbuf_head): Now static.
4348
4349 * scroll.c (scroll_cost): Remove; unused.
4350 * dispextern.h (scroll_cost): Remove decl.
4351
4352 * region-cache.h (pp_cache): Mark as externally visible.
4353
4354 * process.c: Make symbols static if they're not exported.
4355 (process_tick, update_tick, create_process, chan_process):
4356 (Vprocess_alist, proc_buffered_char, datagram_access):
4357 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4358 (deactivate_process): Mark defn as static, as well as decl.
4359 * lisp.h (create_process): Remove decl.
4360 * process.h (chan_process, Vprocess_alist): Remove decls.
4361
4362 * print.c: Make symbols static if they're not exported.
4363 (print_depth, new_backquote_output, being_printed, print_buffer):
4364 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4365 (print_interval, print_number_index, initial_stderr_stream):
4366 Now static.
4367 * lisp.h (Fprinc): Remove decl.
4368 (debug_output_compilation_hack): Mark as externally visible.
4369
4370 * sysdep.c (croak): Move decl from here to syssignal.h.
4371 * syssignal.h (croak): Put it here, so the API can be checked when
4372 'croak' is called from dissociate_if_controlling_tty.
4373
4374 * minibuf.c: Make symbols static if they're not exported.
4375 (minibuf_save_list, choose_minibuf_frame): Now static.
4376 * lisp.h (choose_minibuf_frame): Remove decl.
4377
4378 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4379
4380 * lread.c: Make symbols static if they're not exported.
4381 (read_objects, initial_obarray, oblookup_last_bucket_number):
4382 Now static.
4383 (make_symbol): Remove; unused.
4384 * lisp.h (initial_obarray, make_symbol): Remove decls.
4385
4386 * keyboard.c: Make symbols static if they're not exported.
4387 (single_kboard, recent_keys_index, total_keys, recent_keys):
4388 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4389 (this_single_command_key_start, echoing, last_auto_save):
4390 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4391 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4392 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4393 (Vlispy_mouse_stem, double_click_count):
4394 Now static.
4395 (force_auto_save_soon): Define only if SIGDANGER.
4396 (ignore_mouse_drag_p): Now static if
4397 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4398 (print_help): Remove; unused.
4399 (stop_character, last_timer_event): Mark as externally visible.
4400 * keyboard.h (ignore_mouse_drag_p): Declare only if
4401 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4402 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4403 * lisp.h (echoing): Remove decl.
4404 (force_auto_save_soon): Declare only if SIGDANGER.
4405 * xdisp.c (redisplay_window): Simplify code, to make it more
4406 obvious that ignore_mouse_drag_p is not accessed if !defined
4407 USE_GTK && !defined HAVE_NS.
4408
4409 * intervals.c: Make symbols static if they're not exported.
4410 (merge_properties_sticky, merge_interval_right, delete_interval):
4411 Now static.
4412 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4413
4414 * insdel.c: Make symbols static if they're not exported.
4415 However, leave prepare_to_modify_buffer alone. It's never
4416 called from outside this function, but that appears to be a bug.
4417 (combine_after_change_list, combine_after_change_buffer):
4418 (adjust_after_replace, signal_before_change): Now static.
4419 (adjust_after_replace_noundo): Remove; unused.
4420 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4421 (signal_before_change): Remove decls.
4422
4423 * indent.c (val_compute_motion, val_vmotion): Now static.
4424
4425 * image.c: Make symbols static if they're not exported.
4426 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4427 if USE_GTK.
4428 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4429 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4430
4431 * fringe.c (standard_bitmaps): Now static.
4432 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4433
4434 * frame.c: Make symbols static if they're not exported.
4435 (x_report_frame_params, make_terminal_frame): Now static.
4436 (get_frame_param): Now static, unless HAVE_NS.
4437 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4438 (x_get_resource_string): Remove; not used.
4439 * frame.h (make_terminal_frame, x_report_frame_params):
4440 (x_get_resource_string); Remove decls.
4441 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4442 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4443
4444 * font.c, fontset.c: Make symbols static if they're not exported.
4445 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4446 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4447 * font.c (font_close_object): Now static.
4448 * font.h (font_close_object): Remove.
4449 * fontset.c (FONTSET_OBJLIST): Remove.
4450 (free_realized_fontset) #if-0 the body, which does nothing.
4451 (face_suitable_for_char_p): #if-0, as it's never called.
4452 * fontset.h (face_suitable_for_char_p): Remove decl.
4453 * xfaces.c (face_at_string_position):
4454 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4455 since 0 is always ASCII.
4456
4457 * fns.c (weak_hash_tables): Now static.
4458
4459 * fileio.c: Make symbols static if they're not exported.
4460 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4461 (Vwrite_region_annotation_buffers): Now static.
4462
4463 * eval.c: Make symbols static if they're not exported.
4464 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4465 * lisp.h (backtrace_list): Remove decl.
4466
4467 * emacs.c: Make symbols static if they're not exported.
4468 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4469 (fatal_error_code, fatal_error_signal_hook, standard_args):
4470 Now static.
4471 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4472 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4473 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4474 * lisp.h (fatal_error_signal_hook): Remove decl.
4475 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4476
4477 * editfns.c: Move a (normally-unused) function to its only use.
4478 * editfns.c, lisp.h (get_operating_system_release): Remove.
4479 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4480 worth the hassle of breaking this out.
4481
4482 * xterm.c: Make symbols static if they're not exported.
4483 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4484 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4485 (x_destroy_window, x_delete_display):
4486 Now static.
4487 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4488 (x_mouse_leave): Remove; unused.
4489 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4490 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4491 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4492 Remove decls.
4493 (x_mouse_leave): Declare only if WINDOWSNT.
4494 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4495 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4496 USE_X_TOOLKIT.
4497
4498 * ftxfont.c: Make symbols static if they're not exported.
4499 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4500 HAVE_FREETYPE.
4501 * font.h (ftxfont_driver): Likewise.
4502
4503 * xfns.c: Make symbols static if they're not exported.
4504 (x_last_font_name, x_display_info_for_name):
4505 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4506 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4507 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4508 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4509 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4510 (last_show_tip_args): Now static.
4511 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4512 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4513 (x_screen_planes): Remove; unused.
4514 * dispextern.h (x_screen_planes): Remove decl.
4515
4516 * dispnew.c: Make symbols static if they're not exported.
4517 * dispextern.h (redraw_garbaged_frames, scrolling):
4518 (increment_row_positions): Remove.
4519 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4520 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4521 Now static.
4522 (redraw_garbaged_frames): Remove; unused.
4523
4524 * xfaces.c: Make symbols static if they're not exported.
4525 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4526 Remove decls.
4527 * xterm.h (defined_color): Remove decls.
4528 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4529 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4530 (menu_face_changed_default, defined_color, free_realized_face):
4531 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4532 (ascii_face_of_lisp_face): Remove; unused.
4533
4534 * xdisp.c: Make symbols static if they're not exported.
4535 * dispextern.h (scratch_glyph_row, window_box_edges):
4536 (glyph_to_pixel_coords, set_cursor_from_row):
4537 (get_next_display_element, set_iterator_to_next):
4538 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4539 (show_mouse_face): Remove decls
4540 * frame.h (message_buf_print): Likewise.
4541 * lisp.h (pop_message, set_message, check_point_in_composition):
4542 Likewise.
4543 * xterm.h (set_vertical_scroll_bar): Likewise.
4544 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4545 (message_buf_print, scratch_glyph_row, displayed_buffer):
4546 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4547 (get_next_display_element, show_mouse_face, window_box_edges):
4548 (frame_to_window_pixel_xy, check_point_in_composition):
4549 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4550 (glyph_to_pixel_coords): Remove; unused.
4551
4552 * dired.c (file_name_completion): Now static.
4553
4554 * dbusbind.c (xd_in_read_queued_messages): Now static.
4555
4556 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4557 * data.c (circular_list_error): Remove.
4558
4559 * commands.h (last_point_position, last_point_position_buffer):
4560 (last_point_position_window): Remove decls.
4561 * keyboard.c: Make these variables static.
4562
4563 * coding.h (coding, code_convert_region, encode_coding_gap):
4564 Remove decls.
4565 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4566 (iso_code_class, detect_coding, code_convert_region): Now static.
4567 (encode_coding_gap): Remove; unused.
4568
4569 * chartab.c (chartab_chars, chartab_bits): Now static.
4570
4571 * charset.h (charset_iso_8859_1): Remove decl.
4572 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4573 Now static.
4574
4575 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4576 * ccl.c (Vccl_program_table): Now static.
4577 (check_ccl_update): Remove; unused.
4578
4579 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4580 * category.h: ... from here.
4581 * category.c (check_category_table, set_category_set): Now static.
4582
4583 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4584 * lisp.h: Remove these decls.
4585
4586 * buffer.c (buffer_count): Remove unused var.
4587
4588 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4589 so that it's not optimized away.
4590 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4591 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4592 exported only to the debugger.
4593
4594 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4595 * atimer.h (run_all_atimers): Remove; not exported.
4596
4597 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4598 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4599 was inaccessible from Lisp.
4600 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4601 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4602
4603 alloc.c: Import and export fewer symbols, and remove unused items.
4604 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4605 is defined.
4606 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4607 it's not optimized away by whole-program optimization.
4608 (message_enable_multibyte, free_misc): Remove.
4609 (catchlist, handlerlist, mark_backtrace):
4610 Declare only if BYTE_MARK_STACK.
4611 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4612 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4613 (message_enable_multibyte): Remove decl.
4614 (free_misc, interval_free_list, float_block, float_block_index):
4615 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4616 (cons_free_list, last_marked_index):
4617 Now static.
4618 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4619 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4620 (mark_backtrace): Define only if BYTE_MARK_STACK.
4621 * xdisp.c (message_enable_multibyte): Now static.
4622
4623 Declare Lisp_Object Q* variables to be 'static' if not exported.
4624 This makes it easier for human readers (and static analyzers)
4625 to see whether these variables are used from other modules.
4626 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4627 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4628 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4629 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4630 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4631 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4632 * xmenu.c, xselect.c:
4633 Declare Q* vars static if they are not used in other modules.
4634 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4635 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4636 Remove decls of unexported vars.
4637 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4638
4639 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4640
4641 Make Emacs functions such as Fatom 'static' by default.
4642 This makes it easier for human readers (and static analyzers)
4643 to see whether these functions can be called from other modules.
4644 DEFUN now defines a static function. To make the function external
4645 so that it can be used in other C modules, use the new macro DEFUE.
4646 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4647 (Finit_image_library):
4648 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4649 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4650 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4651 Remove decls, since these functions are now static.
4652 (Funintern, Fget_internal_run_time): New decls, since these functions
4653 were already external.
4654
4655 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4656 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4657 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4658 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4659 * keyboard.c, keymap.c, lread.c:
4660 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4661 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4662 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4663 Mark functions with DEFUE instead of DEFUN,
4664 if they are used in other modules.
4665 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4666 decls for now-static functions.
4667 * buffer.h (Fdelete_overlay): Remove decl.
4668 * callproc.c (Fgetenv_internal): Mark as internal.
4669 * composite.c (Fremove_list_of_text_properties): Remove decl.
4670 (Fcomposition_get_gstring): New forward static decl.
4671 * composite.h (Fcomposite_get_gstring): Remove decl.
4672 * dired.c (Ffile_attributes): New forward static decl.
4673 * doc.c (Fdocumntation_property): New forward static decl.
4674 * eval.c (Ffetch_bytecode): New forward static decl.
4675 (Funintern): Remove extern decl; now in .h file where it belongs.
4676 * fileio.c (Fmake_symbolic_link): New forward static decl.
4677 * image.c (Finit_image_library): New forward static decl.
4678 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4679 * intervals.h (Fprevious_property_change):
4680 (Fremove_list_of_text_properties): Remove decls.
4681 * keyboard.c (Fthis_command_keys): Remove decl.
4682 (Fcommand_execute): New forward static decl.
4683 * keymap.c (Flookup_key): New forward static decl.
4684 (Fcopy_keymap): Now static.
4685 * keymap.h (Flookup_key): Remove decl.
4686 * process.c (Fget_process): New forward static decl.
4687 (Fprocess_datagram_address): Mark as internal.
4688 * syntax.c (Fsyntax_table_p): New forward static decl.
4689 (skip_chars): Remove duplicate decl.
4690 * textprop.c (Fprevious_property_change): New forward static decl.
4691 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4692 Now internal.
4693 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4694 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4695
4696 * editfns.c (Fformat): Remove unreachable code.
4697
4698 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4699
4700 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4701 change. (Bug#8496)
4702
4703 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4704
4705 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4706 when at ZV. (Bug#8487)
4707
4708 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4709
4710 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4711 (Bug#8437)
4712 * keyboard.c (parse_tool_bar_item): Likewise.
4713 * sound.c (sound_cleanup, alsa_close): Likewise.
4714 * termcap.c (tgetent): Likewise.
4715 * xfns.c (x_default_font_parameter): Likewise.
4716 * xsettings.c (read_and_apply_settings): Likewise.
4717
4718 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4719 (overrun_check_free): Protoize.
4720
4721 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4722
4723 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4724 since callers should never pass a negative size.
4725 Change the signature to match that of plain 'read' and 'write'; see
4726 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4727 * lisp.h: Update prototypes of emacs_write and emacs_read.
4728
4729 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4730
4731 * xdisp.c (redisplay_window): Don't try to determine the character
4732 position of the scroll margin if the window start point w->startp
4733 is outside the buffer's accessible region. (Bug#8468)
4734
4735 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4736
4737 Fix write-region and its subroutines for buffers > 2GB.
4738 * fileio.c (a_write, e_write): Modify declaration of arguments and
4739 local variables to support buffers larger than 2GB.
4740 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4741
4742 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4743 argument, local variables, and return value.
4744
4745 * lisp.h: Update prototypes of emacs_write and emacs_read.
4746
4747 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4748
4749 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4750
4751 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4752
4753 Fix more problems found by GCC 4.6.0's static checks.
4754
4755 * xdisp.c (vmessage): Use a better test for character truncation.
4756
4757 * charset.c (load_charset_map): <, not <=, for optimization,
4758 and to avoid potential problems with integer overflow.
4759 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4760 * casetab.c (set_identity, shuffle): Likewise.
4761 * editfns.c (Fformat): Likewise.
4762 * syntax.c (skip_chars): Likewise.
4763
4764 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4765 This also lets GCC 4.6.0 generate slightly better loop code.
4766
4767 * callint.c (Fcall_interactively): <, not <=, for optimization.
4768 (Fcall_interactively): Count the number of arguments produced,
4769 not the number of arguments given. This is simpler and lets GCC
4770 4.6.0 generate slightly better code.
4771
4772 * ftfont.c: Distingish more carefully between FcChar8 and char.
4773 The previous code passed unsigned char * to a functions like
4774 strlen and xstrcasecmp that expect char *, which does not
4775 conform to the C standard.
4776 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4777 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4778 char * when the C standard requires it.
4779
4780 * keyboard.c (read_char): Remove unused var.
4781
4782 * eval.c: Port to Windows vsnprintf (Bug#8435).
4783 Include <limits.h>.
4784 (SIZE_MAX): Define if the headers do not.
4785 (verror): Do not give up if vsnprintf returns a negative count.
4786 Instead, grow the buffer. This ports to Windows vsnprintf, which
4787 does not conform to C99. Problem reported by Eli Zaretskii.
4788 Also, simplify the allocation scheme, by avoiding the need for
4789 calling realloc, and removing the ALLOCATED variable.
4790
4791 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4792
4793 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4794 But keep the doprint source code for now, as we might revamp it
4795 and use it again (Bug#8435).
4796 * lisp.h (doprnt): Remove.
4797 * Makefile.in (base_obj): Remove doprnt.o.
4798 * deps.mk (doprnt.o): Remove.
4799
4800 error: Print 32- and 64-bit integers portably (Bug#8435).
4801 Without this change, on typical 64-bit hosts error ("...%d...", N)
4802 was used to print both 32- and 64-bit integers N, which relied on
4803 undefined behavior.
4804 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4805 New macro.
4806 * lisp.h (error, verror): Mark as printf-like functions.
4807 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4808 Report overflow in size calculations when allocating printf buffer.
4809 Do not truncate output string at its first null byte.
4810 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4811 Truncate the output at a character boundary, since vsnprintf does not
4812 do that.
4813 * charset.c (check_iso_charset_parameter): Convert internal
4814 character to string before calling 'error', since %c now has the
4815 printf meaning.
4816 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4817 overflow when computing char to be passed to 'error'. Do not
4818 pass Lisp_Object to 'error'; pass the integer instead.
4819 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4820 formatted with plain %d.
4821
4822 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4823
4824 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4825
4826 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4827
4828 * xterm.c (x_catch_errors): Remove duplicate declaration.
4829
4830 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4831
4832 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4833
4834 2011-04-10 Jim Meyering <meyering@redhat.com>
4835
4836 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4837 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4838 return ssize_t not "int", and use size_t as the buffer length.
4839 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4840 * gnutls.h: Update declarations.
4841 * process.c (read_process_output): Use ssize_t, to match.
4842 (send_process): Likewise.
4843
4844 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4845
4846 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4847
4848 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4849
4850 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4851 Use unsigned char, to match FcChar8 type definition.
4852
4853 * xterm.c (handle_one_xevent):
4854 * xmenu.c (create_and_show_popup_menu):
4855 * xselect.c (x_decline_selection_request)
4856 (x_reply_selection_request): Avoid type-punned deref of X events.
4857
4858 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4859
4860 Fix some uses of `int' instead of EMACS_INT.
4861 * search.c (string_match_1, fast_string_match)
4862 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4863 (scan_buffer, find_next_newline_no_quit)
4864 (find_before_next_newline, search_command, Freplace_match)
4865 (Fmatch_data): Make some `int' variables be EMACS_INT.
4866
4867 * xdisp.c (display_count_lines): 3rd argument and return value now
4868 EMACS_INT. All callers changed.
4869 (pint2hrstr): Last argument is now EMACS_INT.
4870
4871 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4872 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4873 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4874 (decode_coding_utf_16, decode_coding_emacs_mule)
4875 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4876 (decode_coding_ccl, decode_coding_charset)
4877 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4878 (decode_coding_iso_2022, decode_coding_emacs_mule)
4879 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4880 <char_offset, last_offset>: Declare EMACS_INT.
4881 (encode_coding_utf_8, encode_coding_utf_16)
4882 (encode_coding_emacs_mule, encode_invocation_designation)
4883 (encode_designation_at_bol, encode_coding_iso_2022)
4884 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4885 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4886 Declare EMACS_INT.
4887 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4888 (encode_invocation_designation): Last argument P_NCHARS is now
4889 EMACS_INT.
4890 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4891 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4892
4893 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4894 All users changed.
4895
4896 * ccl.c (Fccl_execute_on_string): Declare some variables
4897 EMACS_INT.
4898
4899 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4900
4901 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4902
4903 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4904
4905 * process.c (Fformat_network_address): Doc fix.
4906
4907 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4908
4909 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4910
4911 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4912
4913 * keyboard.c (read_char): Call Lisp function help-form-show,
4914 instead of using internal_with_output_to_temp_buffer.
4915 (Qhelp_form_show): New var.
4916 (syms_of_keyboard): Use DEFSYM macro.
4917
4918 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4919
4920 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4921
4922 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4923
4924 * process.c (Flist_processes): Remove to Lisp.
4925 (list_processes_1): Delete.
4926
4927 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4928
4929 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4930
4931 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4932
4933 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4934
4935 Fix more problems found by GCC 4.6.0's static checks.
4936
4937 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4938
4939 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4940
4941 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4942
4943 * xdisp.c (vmessage): Mark as a printf-like function.
4944
4945 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4946
4947 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4948
4949 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4950 printf-like functions.
4951 (tiff_load): Add casts to remove these marks before passing them
4952 to system-supplied API.
4953
4954 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4955
4956 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4957 This avoids several warnings with gcc -Wstrict-overflow.
4958 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4959 directly, rather than having caller test rule sign. This avoids
4960 some unnecessary tests.
4961 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4962 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4963 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4964
4965 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4966 (xfont_open): Avoid unnecessary tests.
4967
4968 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4969
4970 * composite.h, composite.c (composition_gstring_put_cache):
4971 Use EMACS_INT, not int, for length.
4972
4973 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4974 breaking out part of COMPOSITION_DECODE_RULE.
4975 (COMPOSITION_DECODE_RULE): Use it.
4976 * composite.c (get_composition_id): Remove unused local vars,
4977 by using the new macro.
4978
4979 * textprop.c (set_text_properties_1): Change while to do-while,
4980 since the condition is always true at first.
4981
4982 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4983 (interval_deletion_adjustment): Return unsigned value.
4984 All uses changed.
4985
4986 * process.c (list_processes_1, create_pty, read_process_output):
4987 (exec_sentinel): Remove vars that were set but not used.
4988 (create_pty): Remove unnecessary "volatile"s.
4989 (Fnetwork_interface_info): Avoid possibility of int overflow.
4990 (read_process_output): Do adaptive read buffering even if carryover.
4991 (read_process_output): Simplify nbytes computation if buffered.
4992
4993 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4994
4995 * syntax.c (scan_words): Remove var that was set but not used.
4996 (update_syntax_table): Use unsigned instead of int.
4997
4998 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4999 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5000 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5001
5002 * print.c (print_error_message): Avoid int overflow.
5003
5004 * font.c (font_list_entities): Redo for clarity,
5005 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5006
5007 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5008 (font_score): Avoid potential overflow in diff calculation.
5009
5010 * fns.c (substring_both): Remove var that is set but not used.
5011 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5012
5013 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5014
5015 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5016 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5017 can always succeed if overflow has undefined behavior.
5018
5019 * search.c (boyer_moore, wordify): Remove vars set but not used.
5020 (wordify): Omit three unnecessary tests.
5021
5022 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5023 All callers changed. This avoids the need for an unused var.
5024
5025 * casefiddle.c (casify_region): Remove var that is set but not used.
5026
5027 * dired.c (file_name_completion): Remove var that is set but not used.
5028
5029 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5030
5031 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5032 (Finsert_file_contents): Remove unnecessary code checking fd.
5033
5034 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5035 Check for integer overflow on size calculations.
5036
5037 * buffer.c (Fprevious_overlay_change): Remove var that is set
5038 but not used.
5039
5040 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5041 Remove vars that are set but not used.
5042 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5043 (timer_check_2): Mark vars as initialized.
5044
5045 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5046
5047 * image.c (lookup_image): Remove var that is set but not used.
5048 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5049
5050 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5051 that are set but not used.
5052
5053 * xfns.c (make_invisible_cursor): Don't return garbage
5054 if XCreateBitmapFromData fails (Bug#8410).
5055
5056 * xselect.c (x_get_local_selection, x_handle_property_notify):
5057 Remove vars that are set but not used.
5058
5059 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5060 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5061
5062 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5063 Remove var that is set but not used.
5064 (scroll_bar_windows_size): Now size_t, not int.
5065 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5066 Check for overflow.
5067
5068 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5069 (map_tty_color) [!defined MSDOS]: Likewise.
5070
5071 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5072
5073 * coding.c: Remove vars that are set but not used.
5074 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5075 All callers changed.
5076 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5077 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5078 (decode_coding_charset): Remove vars that are set but not used.
5079
5080 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5081 that is set but not used.
5082
5083 * print.c (print_object): Remove var that is set but not used.
5084
5085 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5086 The gnulib version avoids calling malloc in the usual case,
5087 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5088 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5089 * filelock.c (current_lock_owner): Likewise.
5090 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5091 * sysdep.c: Include allocator.h, careadlinkat.h.
5092 (emacs_no_realloc_allocator): New static constant.
5093 (emacs_readlink): New function.
5094 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5095 ../lib/careadlinkat.h.
5096
5097 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5098
5099 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5100 first non-nil return value).
5101
5102 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5103
5104 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5105 if not defined (Bug#8403).
5106
5107 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5108
5109 * xdisp.c (display_count_lines): Remove parameter `start',
5110 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5111 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5112 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5113 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5114 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5115 and thereabouts. All callers changed.
5116 (get_per_char_metric): Remove parameter `f', unused since
5117 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5118
5119 2011-04-02 Jim Meyering <meyering@redhat.com>
5120
5121 do not dereference NULL upon failed strdup
5122 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5123 (ns_get_family): Likewise.
5124
5125 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5126
5127 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5128
5129 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5130
5131 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5132 later (Bug#8403).
5133
5134 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5135
5136 Add lexical binding.
5137
5138 * window.c (Ftemp_output_buffer_show): New fun.
5139 (Fsave_window_excursion):
5140 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5141
5142 * lread.c (lisp_file_lexically_bound_p): New function.
5143 (Fload): Bind Qlexical_binding.
5144 (readevalloop): Remove `evalfun' arg.
5145 Bind Qinternal_interpreter_environment.
5146 (Feval_buffer): Bind Qlexical_binding.
5147 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5148 Mark as dynamic.
5149 (syms_of_lread): Declare `lexical-binding'.
5150
5151 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5152
5153 * keyboard.c (eval_dyn): New fun.
5154 (menu_item_eval_property): Use it.
5155
5156 * image.c (parse_image_spec): Use Ffunctionp.
5157
5158 * fns.c (concat, mapcar1): Accept byte-code-functions.
5159
5160 * eval.c (Fsetq): Handle lexical vars.
5161 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5162 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5163 (FletX, Flet): Obey lexical binding.
5164 (Fcommandp): Handle closures.
5165 (Feval): New `lexical' arg.
5166 (eval_sub): New function extracted from Feval. Use it almost
5167 everywhere where Feval was used. Look up vars in lexical env.
5168 Handle closures.
5169 (Ffunctionp): Move from subr.el.
5170 (Ffuncall): Handle closures.
5171 (apply_lambda): Remove `eval_flags'.
5172 (funcall_lambda): Handle closures and new byte-code-functions.
5173 (Fspecial_variable_p): New function.
5174 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5175 but without exporting it to Lisp.
5176
5177 * doc.c (Fdocumentation, store_function_docstring):
5178 * data.c (Finteractive_form): Handle closures.
5179
5180 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5181 interactive spec.
5182
5183 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5184 New byte-codes.
5185 (exec_byte_code): New function extracted from Fbyte_code to handle new
5186 calling convention for byte-code-functions. Add new byte-codes.
5187
5188 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5189
5190 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5191
5192 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5193
5194 * xdisp.c (redisplay_internal): Fix prototype.
5195
5196 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5197
5198 * xdisp.c (SCROLL_LIMIT): New macro.
5199 (try_scrolling): Use it when setting scroll_limit.
5200 Limit scrolling to 100 screen lines.
5201 (redisplay_window): Even when falling back on "recentering",
5202 position point in the window according to scroll-conservatively,
5203 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5204
5205 (try_scrolling): When point is above the window, allow searching
5206 as far as scroll_max, or one screenful, to compute vertical
5207 distance from PT to the scroll margin position. This prevents
5208 try_scrolling from unnecessarily failing when
5209 scroll-conservatively is set to a value slightly larger than the
5210 window height. Clean up the case of PT below the margin at bottom
5211 of window: scroll_max can no longer be INT_MAX. When aggressive
5212 scrolling is in use, don't let point enter the opposite scroll
5213 margin as result of the scroll.
5214 (syms_of_xdisp) <scroll-conservatively>: Document the
5215 threshold of 100 lines for never-recentering scrolling.
5216
5217 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5218
5219 * dispextern.h (move_it_by_lines):
5220 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5221 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5222 (message_log_check_duplicate): Remove parameters `prev_bol' and
5223 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5224 (redisplay_internal): Remove parameter `preserve_echo_area',
5225 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5226
5227 * indent.c (Fvertical_motion):
5228 * window.c (window_scroll_pixel_based, Frecenter):
5229 Don't pass `need_y_p' to `move_it_by_lines'.
5230
5231 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5232
5233 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5234 steal a few bits to be more compact.
5235 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5236 Remove unneeded casts.
5237
5238 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5239
5240 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5241
5242 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5243 binding" message (bug#7967).
5244
5245 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 Fix more problems found by GCC 4.6.0's static checks.
5248
5249 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5250 Remove unused local var.
5251
5252 * editfns.c (Fmessage_box): Remove unused local var.
5253
5254 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5255 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5256 Omit unused local vars.
5257 * window.c (shrink_windows): Omit unused local var.
5258 * menu.c (digest_single_submenu): Omit unused local var.
5259 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5260 Omit unused local var.
5261
5262 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5263 Don't assume string length fits in int.
5264 (keyremap_step, read_key_sequence): Use size_t for sizes.
5265 (read_key_sequence): Don't check last_real_key_start redundantly.
5266
5267 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5268 instead of alloca (Bug#8344).
5269
5270 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5271 (Fbacktrace_frame): Don't assume nframes fits in int.
5272
5273 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5274
5275 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5276 concerns.
5277
5278 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5279
5280 * cm.c (calccost): Turn while-do into do-while, for clarity.
5281
5282 * keyboard.c (syms_of_keyboard): Use the same style as later
5283 in this function when indexing through an array. This also
5284 works around GCC bug 48267.
5285
5286 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5287
5288 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5289
5290 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5291 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5292
5293 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5294 This avoids undefined behavior on integer overflow, and is a bit
5295 more convenient anyway since it is compared to a size_t variable.
5296
5297 Variadic C functions now count arguments with size_t, not int.
5298 This avoids an unnecessary limitation on 64-bit machines, which
5299 caused (substring ...) to crash on large vectors (Bug#8344).
5300 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5301 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5302 All variadic functions and their callers changed accordingly.
5303 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5304 * data.c (arith_driver, float_arith_driver): Likewise.
5305 * editfns.c (general_insert_function): Likewise.
5306 * eval.c (struct backtrace.nargs, interactive_p)
5307 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5308 (funcall_lambda, mark_backtrace): Likewise.
5309 * fns.c (concat): Likewise.
5310 * frame.c (x_set_frame_parameters): Likewise.
5311 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5312 0 if not found, not -1. All callers changed.
5313
5314 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5315 (stack_copy_size): Now size_t, not int.
5316 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5317
5318 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5319
5320 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5321 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5322 All callers changed.
5323
5324 * lisp.h (multibyte_char_to_unibyte):
5325 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5326 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5327 * character.h (CHAR_TO_BYTE8):
5328 * cmds.c (internal_self_insert):
5329 * editfns.c (general_insert_function):
5330 * keymap.c (push_key_description):
5331 * search.c (Freplace_match):
5332 * xdisp.c (message_dolog, set_message_1): All callers changed.
5333
5334 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5335
5336 * keyboard.c (safe_run_hook_funcall): New function.
5337 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5338 don't set the hook to nil, but remove the offending function instead.
5339 (Qcommand_hook_internal): Remove, unused.
5340 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5341 Vcommand_hook_internal.
5342
5343 * eval.c (enum run_hooks_condition): Remove.
5344 (funcall_nil, funcall_not): New functions.
5345 (run_hook_with_args): Call each function through a `funcall' argument.
5346 Remove `cond' argument, now redundant.
5347 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5348 (Frun_hook_with_args_until_failure): Adjust accordingly.
5349 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5350
5351 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5352
5353 * dispextern.h (string_buffer_position): Remove declaration.
5354
5355 * print.c (strout): Remove parameter `multibyte', unused since
5356 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5357
5358 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5359 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5360 All callers changed.
5361
5362 * w32.c (_wsa_errlist): Use braces for struct initializers.
5363
5364 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5365 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5366 All callers changed.
5367 (string_buffer_position): Likewise. Also, make static (it's never
5368 used outside xdisp.c).
5369 (cursor_row_p): Remove parameter `w', unused since
5370 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5371 (decode_mode_spec): Remove parameter `precision', introduced during
5372 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5373 All callers changed.
5374
5375 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5376
5377 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5378
5379 2011-03-27 Anders Lindgren <andlind@gmail.com>
5380
5381 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5382 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5383 (ns_update_auto_hide_menu_bar): New functions.
5384 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5385 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5386 ns_constrain_all_frames.
5387 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5388 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5389
5390 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5391
5392 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5393
5394 2011-03-27 Glenn Morris <rgm@gnu.org>
5395
5396 * syssignal.h: Replace RETSIGTYPE with void.
5397 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5398 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5399 Replace SIGTYPE with void everywhere.
5400 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5401 * s/template.h (SIGTYPE): Remove commented out definition.
5402
5403 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5404
5405 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5406 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5407
5408 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5409
5410 * w32.c (read_unc_volume): Use parameter `henum', instead of
5411 global variable `wget_enum_handle'.
5412
5413 * keymap.c (describe_vector): Remove parameters `indices' and
5414 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5415 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5416
5417 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5418
5419 * keyboard.c (timer_check): Remove parameter `do_it_now',
5420 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5421 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5422 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5423
5424 * keyboard.c (read_char):
5425 * w32menu.c (w32_menu_display_help):
5426 * xmenu.c (show_help_event, menu_help_callback):
5427 Adjust calls to `show_help_echo'.
5428
5429 * gtkutil.c (xg_maybe_add_timer):
5430 * keyboard.c (readable_events):
5431 * process.c (wait_reading_process_output):
5432 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5433
5434 * insdel.c (adjust_markers_gap_motion):
5435 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5436 (gap_left, gap_right): Don't call it.
5437
5438 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5439
5440 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5441 incurred during fontification.
5442
5443 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5444
5445 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5446 (DEFVAR_PER_BUFFER): Don't pass it.
5447
5448 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5449 (scrolling_window): Don't pass it.
5450
5451 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5452
5453 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5454
5455 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5456 and `suffix'.
5457 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5458 of variables specific to SELinux and computation of `encoded_absname'.
5459
5460 * image.c (XPutPixel): Remove unused variable `height'.
5461
5462 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5463
5464 * unexw32.c (get_section_info): Remove unused variable `section'.
5465
5466 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5467 (system_process_attributes): Remove unused variable `sess'.
5468 (sys_read): Remove unused variable `err'.
5469
5470 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5471 (w32_wnd_proc): Remove unused variable `isdead'.
5472 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5473 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5474 (x_create_tip_frame): Remove unused variable `tem'.
5475
5476 * w32inevt.c (w32_console_read_socket):
5477 Remove unused variable `no_events'.
5478
5479 * w32term.c (x_draw_composite_glyph_string_foreground):
5480 Remove unused variable `width'.
5481
5482 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5483
5484 * w32term.c (x_set_glyph_string_clipping):
5485 Don't pass uninitialized region to CombineRgn.
5486
5487 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5488
5489 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5490 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5491 (Fx_close_connection): Remove unused variable `i'.
5492
5493 * w32font.c (w32font_draw): Return number of glyphs.
5494 (w32font_open_internal): Remove unused variable `i'.
5495 (w32font_driver): Add missing initializer.
5496
5497 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5498 (fill_in_menu): Remove unused variable `items_added'.
5499
5500 * w32term.c (last_mouse_press_frame): Remove static global variable.
5501 (w32_clip_to_row): Remove unused variable `f'.
5502 (x_delete_terminal): Remove unused variable `i'.
5503
5504 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5505 (NOTHING): Remove unused static global variable.
5506 (uniscribe_check_otf): Remove unused variable `table'.
5507 (uniscribe_font_driver): Add missing initializers.
5508
5509 2011-03-23 Julien Danjou <julien@danjou.info>
5510
5511 * term.c (Fsuspend_tty, Fresume_tty):
5512 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5513 * window.c (temp_output_buffer_show):
5514 * insdel.c (signal_before_change):
5515 * frame.c (Fhandle_switch_frame):
5516 * fileio.c (Fdo_auto_save):
5517 * emacs.c (Fkill_emacs):
5518 * editfns.c (save_excursion_restore):
5519 * cmds.c (internal_self_insert):
5520 * callint.c (Fcall_interactively):
5521 * buffer.c (Fkill_all_local_variables):
5522 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5523 Use Frun_hooks.
5524 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5525 unconditionnaly since it does the check itself.
5526
5527 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5528
5529 Fix more problems found by GCC 4.5.2's static checks.
5530
5531 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5532 the first time through the loop, since we know p0 < p1 then.
5533 This also avoids a gcc -Wstrict-overflow warning.
5534
5535 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5536 leading to a memory leak, possible in functions like
5537 load_charset_map_from_file that can allocate an unbounded number
5538 of objects (Bug#8318).
5539
5540 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5541 that could (at least in theory) be that large.
5542
5543 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5544 This is less likely to overflow, and avoids undefined behavior if
5545 overflow does occur. All callers changed. Use strtoul to scan
5546 for the unsigned long integer.
5547 (pint2hrstr): Simplify and tune code slightly.
5548 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5549
5550 * scroll.c (do_scrolling): Work around GCC bug 48228.
5551 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5552
5553 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5554 This also avoids a warning with gcc -Wstrict-overflow.
5555 (validate_x_resource_name): Simplify count usage.
5556 This also avoids a warning with gcc -Wstrict-overflow.
5557
5558 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5559 fail (Bug#8306).
5560
5561 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5562
5563 * process.c (Fmake_network_process): Use socklen_t, not int,
5564 where POSIX says socklen_t is required in portable programs.
5565 This fixes a porting bug on hosts like 64-bit HP-UX, where
5566 socklen_t is wider than int (Bug#8277).
5567 (Fmake_network_process, server_accept_connection):
5568 (wait_reading_process_output, read_process_output):
5569 Likewise.
5570
5571 * process.c: Rename or move locals to avoid shadowing.
5572 (list_processes_1, Fmake_network_process):
5573 (read_process_output_error_handler, exec_sentinel_error_handler):
5574 Rename or move locals.
5575 (Fmake_network_process): Define label "retry_connect" only if needed.
5576 (Fnetwork_interface_info): Fix pointer signedness.
5577 (process_send_signal): Add cast to avoid pointer signedness problem.
5578 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5579 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5580
5581 Make tparam.h and terminfo.c consistent.
5582 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5583 Include tparam.h instead, since it declares them.
5584 * cm.h (PC): Remove extern decl; tparam.h now does this.
5585 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5586 * terminfo.c: Include tparam.h, to check interfaces.
5587 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5588 (tparam): Adjust signature to match interface in tparam.h;
5589 this removes some undefined behavior. Check that outstring and len
5590 are zero, which they always are with Emacs.
5591 * tparam.h (PC, BC, UP): New extern decls.
5592
5593 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5594 (xftfont_open): Rename locals to avoid shadowing.
5595
5596 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5597 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5598 (OTF_TAG_SYM): Omit macro if not needed.
5599 (ftfont_list): Remove unused local.
5600 (get_adstyle_property, ftfont_pattern_entity):
5601 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5602 Rename locals to avoid shadowing.
5603
5604 * xfont.c (xfont_list_family): Mark var as initialized.
5605
5606 * xml.c (make_dom): Now static.
5607
5608 * composite.c (composition_compute_stop_pos): Rename local to
5609 avoid shadowing.
5610 (composition_reseat_it): Remove unused locals.
5611 (find_automatic_composition, composition_adjust_point): Likewise.
5612 (composition_update_it): Mark var as initialized.
5613 (find_automatic_composition): Mark vars as initialized,
5614 with a FIXME (Bug#8290).
5615
5616 character.h: Rename locals to avoid shadowing.
5617 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5618 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5619 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5620 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5621 to avoid shadowing.
5622
5623 * textprop.c (property_change_between_p): Remove; unused.
5624
5625 * intervals.c (interval_start_pos): Now static.
5626
5627 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5628
5629 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5630 Rename locals to avoid shadowing.
5631
5632 * sound.c (wav_play, au_play, Fplay_sound_internal):
5633 Fix pointer signedness.
5634 (alsa_choose_format): Remove unused local var.
5635 (wav_play): Initialize a variable to 0, to prevent undefined
5636 behavior (Bug#8278).
5637
5638 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5639
5640 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5641
5642 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5643 clobbering (Bug#8298).
5644 * sysdep.c (sys_subshell): Likewise.
5645 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5646
5647 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5648 This should get cleaned up, so that child_setup has the
5649 same signature on all platforms.
5650
5651 * callproc.c (call_process_cleanup): Now static.
5652 (relocate_fd): Rename locals to avoid shadowing.
5653
5654 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5655
5656 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5657 not to be necessary, and produces flickering.
5658
5659 2011-03-20 Glenn Morris <rgm@gnu.org>
5660
5661 * config.in: Remove file.
5662
5663 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5664
5665 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5666 are now in src/globals.h.
5667 (syms_of_minibuf): Remove spurious & from previous change.
5668
5669 2011-03-20 Leo <sdl.web@gmail.com>
5670
5671 * minibuf.c (completing-read-function): New variable.
5672 (completing-read-default): Rename from completing-read.
5673 (completing-read): Call completing-read-function.
5674
5675 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5676
5677 * xfaces.c (Fx_load_color_file):
5678 Read color file from absolute filename (bug#8250).
5679
5680 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5681
5682 * makefile.w32-in: Update dependencies.
5683
5684 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5685
5686 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5687
5688 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5689
5690 Fix more problems found by GCC 4.5.2's static checks.
5691
5692 * process.c (make_serial_process_unwind, send_process_trap):
5693 (sigchld_handler): Now static.
5694
5695 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5696 That way, the code declares only the vars that it needs.
5697 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5698 * s/cygwin.h (PTY_ITERATION): Likewise.
5699 * s/darwin.h (PTY_ITERATION): Likewise.
5700 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5701
5702 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5703 * process.c (allocate_pty): Don't declare stb unless it's needed.
5704
5705 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5706 (CONSTANTLIM): Remove; unused.
5707 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5708 Define only if needed.
5709
5710 * unexelf.c (unexec): Name an expression,
5711 to avoid gcc -Wbad-function-cast warning.
5712 Use a different way to cause a compilation error if anyone uses
5713 n rather than nn, a way that does not involve shadowing.
5714 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5715
5716 * deps.mk (unexalpha.o): Remove; unused.
5717
5718 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5719 * unexec.h: New file.
5720 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5721 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5722 Depend on unexec.h.
5723 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5724 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5725 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5726 Change as necessary to match prototype in unexec.h.
5727
5728 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5729 shadowing.
5730 (back_comment, skip_chars): Mark vars as initialized.
5731
5732 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5733 Rename locals to avoid shadowing.
5734
5735 * lread.c (read1): Rewrite so as not to use empty "else".
5736 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5737
5738 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5739
5740 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5741 warning when compiling print.c.
5742
5743 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5744 instead of using an uninitialized var.
5745 (font_sort_entities): Mark var as initialized.
5746
5747 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5748
5749 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5750 pointers to constants.
5751 (font_parse_fcname): Remove unused vars.
5752 (font_delete_unmatched): Now static.
5753 (font_get_spec): Remove; unused.
5754 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5755 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5756 Rename or move locals to avoid shadowing.
5757
5758 * fns.c (require_nesting_list, require_unwind): Now static.
5759 (Ffillarray): Rename locals to avoid shadowing.
5760
5761 * floatfns.c (domain_error2): Define only if needed.
5762 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5763
5764 * alloc.c (mark_backtrace): Move decl from here ...
5765 * lisp.h: ... to here, so that it can be checked.
5766
5767 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5768 (Fdefvar): Rewrite so as not to use empty "else".
5769 (lisp_indirect_variable): Name an expression,
5770 to avoid gcc -Wbad-function-cast warning.
5771 (Fdefvar): Rename locals to avoid shadowing.
5772
5773 * callint.c (quotify_arg, quotify_args): Now static.
5774 (Fcall_interactively): Rename locals to avoid shadowing.
5775 Use const pointer when appropriate.
5776
5777 * lisp.h (get_system_name, get_operating_system_release):
5778 Move decls here, to check interfaces.
5779 * process.c (get_operating_system_release): Move decl to lisp.h.
5780 * xrdb.c (get_system_name): Likewise.
5781 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5782 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5783 some of which prompt warnings from gcc -Wbad-function-cast.
5784 (Fformat_time_string, Fencode_time, Finsert_char):
5785 (Ftranslate_region_internal, Fformat):
5786 Rename or remove local vars to avoid shadowing.
5787 (Ftranslate_region_internal): Mark var as initialized.
5788
5789 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5790 avoid shadowing.
5791
5792 * lisp.h (eassert): Check that the argument compiles, even if
5793 ENABLE_CHECKING is not defined.
5794
5795 * data.c (Findirect_variable): Name an expression, to avoid
5796 gcc -Wbad-function-cast warning.
5797 (default_value, arithcompare, arith_driver, arith_error): Now static.
5798 (store_symval_forwarding): Rename local to avoid shadowing.
5799 (Fmake_variable_buffer_local, Fmake_local_variable):
5800 Mark variables as initialized.
5801 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5802
5803 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5804 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5805 Rename locals to avoid shadowing.
5806 (mark_stack): Move local variables into the #ifdef region where
5807 they're used.
5808 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5809 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5810 needed otherwise.
5811 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5812 (GC_STRING_CHARS): Remove; not used.
5813 (Fmemory_limit): Cast sbrk's returned value to char *.
5814
5815 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5816 avoids undefined behavior in theory.
5817
5818 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5819
5820 Use functions, not macros, for up- and down-casing (Bug#8254).
5821 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5822 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5823 to use the following functions instead of these macros.
5824 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5825 EMACS_INT, since callers assume the returned value fits in int.
5826 (upcase1): Likewise, for UPCASE_TABLE.
5827 (uppercasep, lowercasep, upcase): New static inline functions.
5828 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5829 the race-condition problem in the old DOWNCASE.
5830
5831 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5832 Rename locals to avoid shadowing.
5833 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5834 (regex_compile, re_search_2, re_match_2_internal):
5835 Remove unused local vars.
5836 (FREE_VAR): Rewrite so as not to use empty "else",
5837 which gcc can warn about.
5838 (regex_compile, re_match_2_internal): Mark locals as initialized.
5839 (RETALLOC_IF): Define only if needed.
5840 (WORDCHAR_P): Likewise. This one is never needed, but is used
5841 only in a comment talking about a compiler bug, so put inside
5842 the #if 0 of that comment.
5843 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5844 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5845 Remove; unused.
5846
5847 * search.c (boyer_moore): Rename locals to avoid shadowing.
5848 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5849 (PREV_CHAR_BOUNDARY): Likewise.
5850
5851 * search.c (simple_search): Remove unused var.
5852
5853 * dired.c (compile_pattern): Move decl from here ...
5854 * lisp.h: ... to here, so that it can be checked.
5855 (struct re_registers): New forward decl.
5856
5857 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5858
5859 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5860 All uses changed.
5861 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5862 Rename locals to avoid shadowing.
5863 (Fvertical_motion): Mark locals as initialized.
5864
5865 * casefiddle.c (casify_object, casify_region): Now static.
5866 (casify_region): Mark local as initialized.
5867
5868 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5869
5870 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5871 New macros, so that the caller can use some names other than
5872 gcpro1, gcpro2, etc.
5873 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5874 of the new macros.
5875 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5876 argument, for consistency with GCPRO2_VAR, etc: it is now the
5877 prefix of the variable, not the variable itself. All uses
5878 changed.
5879 * dired.c (directory_files_internal, file_name_completion):
5880 Rename locals to avoid shadowing.
5881
5882 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5883 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5884 dired.c's scmp function, had undefined behavior.
5885 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5886 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5887 * buffer.h: ... to here, because these macros use current_buffer,
5888 and the new implementation with inline functions needs to have
5889 current_buffer in scope now, rather than later when the macros
5890 are used.
5891 (downcase, upcase1): New static inline functions.
5892 (DOWNCASE, UPCASE1): Reimplement using these functions.
5893 This avoids undefined behavior in expressions like
5894 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5895 from race conditions in accessing the global variables
5896 case_temp1 and case_temp2.
5897 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5898 * lisp.h (case_temp1, case_temp2): Remove their decls.
5899 * character.h (ASCII_CHAR_P): Move from here ...
5900 * lisp.h: ... to here, so that the inline functions mentioned
5901 above can use them.
5902
5903 * dired.c (directory_files_internal_unwind): Now static.
5904
5905 * fileio.c (file_name_as_directory, directory_file_name):
5906 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5907 Now static.
5908 (file_name_as_directory): Use const pointers when appropriate.
5909 (Fexpand_file_name): Likewise. In particular, newdir might
5910 point at constant storage, so make it a const pointer.
5911 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5912 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5913 signedness issues.
5914 (Fset_file_times, Finsert_file_contents, auto_save_error):
5915 Rename locals to avoid shadowing.
5916
5917 * minibuf.c (choose_minibuf_frame_1): Now static.
5918 (Ftry_completion, Fall_completions): Rename or remove locals
5919 to avoid shadowing.
5920
5921 * marker.c (bytepos_to_charpos): Remove; unused.
5922
5923 * lisp.h (verify_bytepos, count_markers): New decls,
5924 so that gcc does not warn that these functions aren't declared.
5925
5926 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5927 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5928 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5929 (copy_text): Remove unused local var.
5930
5931 * filelock.c (within_one_second): Now static.
5932 (lock_file_1): Rename local to avoid shadowing.
5933
5934 * buffer.c (fix_overlays_before): Mark locals as initialized.
5935 (fix_start_end_in_overlays): Likewise. This function should be
5936 simplified by using pointers-to-pointers, but that's a different
5937 matter.
5938 (switch_to_buffer_1): Now static.
5939 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5940 (report_overlay_modification): Rename locals to avoid shadowing.
5941
5942 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5943 Fix pointer signedness issue.
5944 (sys_subshell): Mark local as volatile if checking for lint,
5945 to suppress a gcc -Wclobbered warning that does not seem to be right.
5946 (MAXPATHLEN): Define only if needed.
5947
5948 * process.c (serial_open, serial_configure): Move decls from here ...
5949 * systty.h: ... to here, so that they can be checked.
5950
5951 * fns.c (get_random, seed_random): Move extern decls from here ...
5952 * lisp.h: ... to here, so that they can be checked.
5953
5954 * sysdep.c (reset_io): Now static.
5955 (wait_for_termination_signal): Remove; unused.
5956
5957 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5958 (copy_keymap_item, append_key, push_text_char_description):
5959 Now static.
5960 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5961 (DENSE_TABLE_SIZE): Remove; unused.
5962 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5963 (describe_map_tree):
5964 Rename locals to avoid shadowing.
5965
5966 * keyboard.c: Declare functions static if they are not used elsewhere.
5967 (echo_char, echo_dash, cmd_error, top_level_2):
5968 (poll_for_input, handle_async_input): Now static.
5969 (read_char, kbd_buffer_get_event, make_lispy_position):
5970 (make_lispy_event, make_lispy_movement, apply_modifiers):
5971 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5972 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5973 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5974 (read_key_sequence, read_char): Mark locals as initialized.
5975 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5976
5977 * keyboard.h (make_ctrl_char): New decl.
5978 (mark_kboards): Move decl here ...
5979 * alloc.c (mark_kboards): ... from here.
5980
5981 * lisp.h (force_auto_save_soon): New decl.
5982
5983 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5984 (DEFINE_DUMMY_FUNCTION): New macro.
5985 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5986 Use it.
5987 (main): Add casts to avoid warnings
5988 if GCC considers string literals to be constants.
5989
5990 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5991
5992 * dbusbind.c: Pointer signedness fixes.
5993 (xd_signature, xd_append_arg, xd_initialize):
5994 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5995 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5996 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5997 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5998
5999 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6000 if GCC considers string literals to be constants.
6001 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6002
6003 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6004
6005 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6006 (print_preprocess, print_object): New macro to fix last change.
6007
6008 * print.c (print_preprocess): Don't forget font objects.
6009
6010 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6011
6012 * emacs.c (USAGE3): Doc fixes.
6013
6014 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6015
6016 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6017 structure.
6018
6019 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6020
6021 * lisp.h (VWindow_system, Qfile_name_history):
6022 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6023 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6024 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6025
6026 * w32select.c: Don't #include "keyboard.h".
6027 (run_protected): Add extern declaration for waiting_for_input.
6028
6029 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6030 * w32console.c (detect_input_pending, read_input_pending)
6031 (encode_terminal_code):
6032 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6033 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6034 (w32_system_caret_y, Qfile_name_history):
6035 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6036 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6037 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6038 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6039 * w32proc.c (Qlocal, report_file_error):
6040 * w32term.c (Vwindow_system, updating_frame):
6041 * w32uniscribe.c (initialized, uniscribe_font_driver):
6042 Remove unneeded extern declarations.
6043
6044 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6045
6046 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6047
6048 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6049
6050 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6051 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6052 These macros can no longer be used for assignment.
6053
6054 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6055 Assign struct members directly, instead of using BUF_BEGV etc.
6056 (record_buffer_markers, fetch_buffer_markers): New functions for
6057 recording and fetching special buffer markers.
6058 (set_buffer_internal_1, set_buffer_temp): Use them.
6059
6060 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6061
6062 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6063
6064 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6065 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6066
6067 * xdisp.c (hscroll_window_tree):
6068 (reconsider_clip_changes): Use PT instead of BUF_PT.
6069
6070 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6071
6072 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6073 $(EMACS_ROOT)/lib/intprops.h.
6074
6075 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6076
6077 Fix more problems found by GCC 4.5.2's static checks.
6078
6079 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6080 to unsigned char * to avoid compiler diagnostic.
6081 (xg_free_frame_widgets): Make it clear that a local variable is
6082 needed only if USE_GTK_TOOLTIP.
6083 (gdk_window_get_screen): Make it clear that this macro is needed
6084 only if USE_GTK_TOOLTIP.
6085 (int_gtk_range_get_value): New function, which avoids a diagnostic
6086 from gcc -Wbad-function-cast.
6087 (xg_set_toolkit_scroll_bar_thumb): Use it.
6088 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6089 diagnostic from gcc -Wbad-function-cast.
6090 (get_utf8_string, xg_get_file_with_chooser):
6091 Rename locals to avoid shadowing.
6092 (create_dialog): Move locals to avoid shadowing.
6093
6094 * xgselect.c (xg_select): Remove unused var.
6095
6096 * image.c (four_corners_best): Mark locals as initialized.
6097 (gif_load): Initialize transparent_p to zero (Bug#8238).
6098 Mark another local as initialized.
6099 (my_png_error, my_error_exit): Mark with NO_RETURN.
6100
6101 * image.c (clear_image_cache): Now static.
6102 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6103 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6104 (x_edge_detection): Remove unnecessary cast that
6105 gcc -Wbad-function-cast diagnoses.
6106 (gif_load): Fix pointer signedness.
6107 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6108 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6109
6110 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6111
6112 Improve quality of tests for time stamp overflow.
6113 For example, without this patch (encode-time 0 0 0 1 1
6114 1152921504606846976) returns the obviously-bogus value (-948597
6115 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6116 reports time overflow. See
6117 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6118 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6119 * editfns.c: Include limits.h and intprops.h.
6120 (TIME_T_MIN, TIME_T_MAX): New macros.
6121 (time_overflow): Move earlier, to before first use.
6122 (hi_time, lo_time): New functions, for an accurate test for
6123 out-of-range times.
6124 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6125 (Fget_internal_run_time): Don't assume time_t fits in int.
6126 (make_time): Use list2 instead of Fcons twice.
6127 (Fdecode_time): More accurate test for out-of-range times.
6128 (check_tm_member): New function.
6129 (Fencode_time): Use it, to test for out-of-range times.
6130 (lisp_time_argument): Don't rely on undefined left-shift and
6131 right-shift behavior when checking for time stamp overflow.
6132
6133 * editfns.c (time_overflow): New function, refactoring common code.
6134 (Fformat_time_string, Fdecode_time, Fencode_time):
6135 (Fcurrent_time_string): Use it.
6136
6137 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6138 * dired.c (make_time): Move to ...
6139 * editfns.c (make_time): ... here.
6140 * systime.h: Note the move.
6141
6142 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6143
6144 * fringe.c (update_window_fringes): Remove unused variables.
6145
6146 * unexmacosx.c (copy_data_segment): Also copy __got section.
6147 (Bug#8223)
6148
6149 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6150
6151 * termcap.c [MSDOS]: Include "msdos.h".
6152 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6153 Constify `char *' arguments and their references according to
6154 prototypes in tparam.h.
6155
6156 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6157
6158 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6159 Adapt all references accordingly.
6160
6161 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6162
6163 2011-03-11 Tom Tromey <tromey@redhat.com>
6164
6165 * buffer.c (syms_of_buffer): Remove obsolete comment.
6166
6167 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6168
6169 * termhooks.h (encode_terminal_code): Declare prototype.
6170
6171 * msdos.c (encode_terminal_code): Don't declare prototype.
6172
6173 * term.c (encode_terminal_code): Now external again, used by
6174 w32console.c and msdos.c.
6175
6176 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6177 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6178
6179 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6180
6181 Fix some minor problems found by GCC 4.5.2's static checks.
6182
6183 * fringe.c (update_window_fringes): Mark locals as initialized
6184 (Bug#8227).
6185 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6186
6187 * alloc.c (mark_fringe_data): Move decl from here ...
6188 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6189 to check its interface.
6190 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6191
6192 * fontset.c (free_realized_fontset): Now static.
6193 (Fset_fontset_font): Rename local to avoid shadowing.
6194 (fontset_font): Mark local as initialized.
6195 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6196
6197 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6198
6199 * xselect.c (x_disown_buffer_selections): Remove; not used.
6200 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6201 (x_own_selection, Fx_disown_selection_internal): Rename locals
6202 to avoid shadowing.
6203 (x_handle_dnd_message): Remove local to avoid shadowing.
6204
6205 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6206 so that the caller can use some name other than gcpro1.
6207 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6208 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6209 (Fx_backspace_delete_keys_p):
6210 Use them to avoid shadowing, and rename vars to avoid shadowing.
6211 (x_decode_color, x_set_name, x_window): Now static.
6212 (Fx_create_frame): Add braces to silence GCC warning.
6213 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6214 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6215 Remove unused locals.
6216 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6217 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6218 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6219 macros.
6220
6221 * xterm.h (x_mouse_leave): New decl.
6222
6223 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6224 Remove unused functions.
6225 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6226 (x_calc_absolute_position): Now static.
6227 (XTread_socket): Don't define label "out" unless it's used.
6228 Don't declare local "event" unless it's used.
6229 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6230 unless they are used.
6231 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6232 (x_fatal_error_signal): Remove; not used.
6233 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6234 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6235 (x_error_catcher, x_connection_closed, x_error_handler):
6236 (x_error_quitter, xembed_send_message, x_iconify_frame):
6237 (my_log_handler): Rename locals to avoid shadowing.
6238 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6239 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6240
6241 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6242 Rename or move locals to avoid shadowing.
6243 (tty_defined_color, merge_face_heights): Now static.
6244 (free_realized_faces_for_fontset): Remove; not used.
6245 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6246 does not deduce is never used uninitialized.
6247 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6248 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6249
6250 * terminal.c (store_terminal_param): Now static.
6251
6252 * xmenu.c (menu_highlight_callback): Now static.
6253 (set_frame_menubar): Remove unused local.
6254 (xmenu_show): Rename parameter to avoid shadowing.
6255 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6256 since they might point to immutable storage.
6257 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6258 since it's unused otherwise.
6259
6260 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6261 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6262 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6263 avoids a gcc -Wuninitialized diagnostic.
6264 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6265 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6266 does not deduce are never used uninitialized.
6267
6268 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6269
6270 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6271 * window.c (window_loop, size_window):
6272 (run_window_configuration_change_hook, enlarge_window): Likewise.
6273
6274 * window.c (display_buffer): Now static.
6275 (size_window): Mark variables that gcc -Wuninitialized
6276 does not deduce are never used uninitialized.
6277 * window.h (check_all_windows): New decl, to forestall
6278 gcc -Wmissing-prototypes diagnostic.
6279 * dispextern.h (bidi_dump_cached_states): Likewise.
6280
6281 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6282 shadowing.
6283 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6284 Include <limits.h>.
6285 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6286 and to avoid gcc -Wuninitialized warning.
6287 (load_charset_map): Mark variables that gcc -Wuninitialized
6288 does not deduce are never used uninitialized.
6289 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6290
6291 * coding.c (coding_set_source, coding_set_destination):
6292 Use "else { /* comment */ }" rather than "else /* comment */;"
6293 for clarity, and to avoid gcc -Wempty-body warning.
6294 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6295 a block, when the outer 'i' will do.
6296 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6297 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6298 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6299 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6300 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6301 Rename locals to avoid shadowing.
6302 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6303 * coding.c (emacs_mule_char, encode_invocation_designation):
6304 Now static, since they're not used elsewhere.
6305 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6306 (decode_coding_object, encode_coding_object, detect_coding_system):
6307 (decode_coding_emacs_mule): Mark variables that gcc
6308 -Wuninitialized does not deduce are never used uninitialized.
6309 (detect_coding_iso_2022): Initialize a local variable that might
6310 be used uninitialized. Leave a FIXME because it's not clear that
6311 this initialization is needed. (Bug#8211)
6312 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6313 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6314 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6315 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6316 Remove unused macros.
6317
6318 * category.c (hash_get_category_set): Remove unused local var.
6319 (copy_category_table): Now static, since it's not used elsewhere.
6320 * character.c (string_count_byte8): Likewise.
6321
6322 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6323 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6324
6325 * chartab.c (copy_sub_char_table): Now static, since it's not used
6326 elsewhere.
6327 (sub_char_table_ref_and_range, char_table_ref_and_range):
6328 Rename locals to avoid shadowing.
6329 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6330
6331 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6332 (BIDI_BOB): Remove unused macro.
6333
6334 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6335 deduce are never used uninitialized.
6336 * term.c (encode_terminal_code): Likewise.
6337
6338 * term.c (encode_terminal_code): Now static. Remove unused local.
6339
6340 * tparam.h: New file.
6341 * term.c, tparam.h: Include it.
6342 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6343 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6344 Move these decls to tparam.h, and make them agree with what
6345 is actually in tparam.c. The previous trick of using incompatible
6346 decls in different modules does not conform to the C standard.
6347 All callers of tparam changed to use tparam's actual API.
6348 * tparam.c (tparam1, tparam, tgoto):
6349 Use const pointers where appropriate.
6350
6351 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6352 * cm.h (struct cm): Likewise.
6353 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6354 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6355 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6356 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6357 (turn_on_face, init_tty): Likewise.
6358 * termchar.h (struct tty_display_info): Likewise.
6359
6360 * term.c (term_mouse_position): Rename local to avoid shadowing.
6361
6362 * alloc.c (mark_ttys): Move decl from here ...
6363 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6364
6365 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6366
6367 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6368
6369 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6370
6371 * search.c (compile_pattern_1): Remove argument regp, unused since
6372 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6373 (compile_pattern): Don't pass it.
6374
6375 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6376
6377 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6378 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6379 for ! HAVE_GTK3.
6380 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6381
6382 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6383
6384 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6385 gdk_window_get_screen, gdk_window_get_geometry,
6386 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6387 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6388 (xg_get_pixbuf_from_pixmap): New function.
6389 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6390 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6391 Call xg_get_pixbuf_from_pixmap instead of
6392 gdk_pixbuf_get_from_drawable.
6393 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6394 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6395 (xg_check_special_colors): Use GtkStyleContext and its functions
6396 for HAVE_GTK3.
6397 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6398 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6399 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6400 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6401 Call gtk_widget_get_preferred_size.
6402 (xg_frame_resized): gdk_window_get_geometry only takes 5
6403 parameters.
6404 (xg_win_to_widget, xg_event_is_for_menubar):
6405 Call gdk_x11_window_lookup_for_display.
6406 (xg_set_widget_bg): New function.
6407 (delete_cb): New function.
6408 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6409 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6410 (xg_set_background_color): Call xg_set_widget_bg.
6411 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6412 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6413 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6414 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6415 if ! HAVE_GTK3.
6416 (update_frame_tool_bar): Call gtk_widget_hide.
6417 (xg_initialize): Use GDK_KEY_g.
6418
6419 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6420 if ! HAVE_GTK3
6421 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6422
6423 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6424 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6425 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6426
6427 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6428
6429 * w32xfns.c (select_palette): Check success of RealizePalette against
6430 GDI_ERROR, not zero.
6431
6432 See ChangeLog.11 for earlier changes.
6433
6434 ;; Local Variables:
6435 ;; coding: utf-8
6436 ;; End:
6437
6438 Copyright (C) 2011 Free Software Foundation, Inc.
6439
6440 This file is part of GNU Emacs.
6441
6442 GNU Emacs is free software: you can redistribute it and/or modify
6443 it under the terms of the GNU General Public License as published by
6444 the Free Software Foundation, either version 3 of the License, or
6445 (at your option) any later version.
6446
6447 GNU Emacs is distributed in the hope that it will be useful,
6448 but WITHOUT ANY WARRANTY; without even the implied warranty of
6449 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6450 GNU General Public License for more details.
6451
6452 You should have received a copy of the GNU General Public License
6453 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.