Don't let Gtk+ linewrap tooltips.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2
3 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5 (xg_hide_tooltip): Fix comment.
6
7 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8 in registerServicesMenuSendTypes.
9 (validRequestorForSendType): Don't check ns_return_types.
10
11 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
12 ns_return_type.
13
14 2011-07-08 Jason Rumney <jasonr@gnu.org>
15
16 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
17 frame struct members of non-existent frames (Bug#6284).
18
19 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
20
21 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
22 variable firstTime not needed on OSX >= 10.6.
23 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
24 >= 10.5. Use setKnobProportion, setDoubleValue.
25
26 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
27 (MAC_OS_X_VERSION_10_5): Define if not defined.
28 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
29 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
30 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
31
32 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
33 cString and lossyCString on OSX >= 10.4
34
35 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
36 sizeToFit on OSX >= 10.2.
37
38 * nsimage.m (allocInitFromFile): Don't use deprecated method
39 bestRepresentationForDevice on OSX >= 10.6.
40
41 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
42 to avoid warning.
43
44 * emacs.c: Declare unexec_init_emacs_zone.
45
46 * nsgui.h: Fix compiler warning about gnulib redefining verify.
47
48 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
49
50 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
51 on svcsMenu (Bug#8842).
52
53 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
54 ns_return_types.
55 (Fns_list_services): Just return Qnil on 10.6, code not working there.
56
57 * nsterm.m (QUTF8_STRING): Declare.
58 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
59 (validRequestorForSendType): Return type is (id).
60 Change indexOfObjectIdenticalTo to indexOfObject.
61 Check if we have local selection before returning self (Bug#8842).
62 (writeSelectionToPasteboard): Put local selection into paste board
63 if we have a local selection (Bug#8842).
64 (syms_of_nsterm): DEFSYM QUTF8_STRING.
65
66 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
67 (ns_get_local_selection): Declare.
68
69 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
70
71 * keymap.c (describe_map_tree): Don't insert a double newline at
72 the end of the buffer (bug#1169) and return whether we inserted
73 something.
74
75 * callint.c (Fcall_interactively): Change "reading args" to
76 "providing args" to try to clarify what it does (bug#1010).
77
78 2011-07-07 Kenichi Handa <handa@m17n.org>
79
80 * composite.c (composition_compute_stop_pos): Ignore a static
81 composition starting before CHARPOS (Bug#8915).
82
83 * xdisp.c (handle_composition_prop): Likewise.
84
85 2011-07-07 Eli Zaretskii <eliz@gnu.org>
86
87 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
88 (Bug#9015)
89
90 2011-07-07 Kenichi Handa <handa@m17n.org>
91
92 * character.h (unicode_category_t): New enum type.
93
94 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
95 (Qchar_code_property_table): New variable.
96 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
97 (UNIPROP_COMPRESSED_FORM_P): New macros.
98 (char_table_ascii): Uncompress the compressed values.
99 (sub_char_table_ref): New arg is_uniprop. Callers changed.
100 Uncompress the compressed values.
101 (sub_char_table_ref_and_range): Likewise.
102 (char_table_ref_and_range): Uncompress the compressed values.
103 (sub_char_table_set): New arg is_uniprop. Callers changed.
104 Uncompress the compressed values.
105 (sub_char_table_set_range): Args changed. Callers changed.
106 (char_table_set_range): Adjuted for the above change.
107 (map_sub_char_table): Delete args default_val and parent. Add arg
108 top. Give decoded values to a Lisp function.
109 (map_char_table): Adjusted for the above change. Give decoded
110 values to a Lisp function. Gcpro more variables.
111 (uniprop_table_uncompress)
112 (uniprop_decode_value_run_length): New functions.
113 (uniprop_decoder, uniprop_decoder_count): New variables.
114 (uniprop_get_decoder, uniprop_encode_value_character)
115 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
116 New functions.
117 (uniprop_encoder, uniprop_encoder_count): New variables.
118 (uniprop_get_encoder, uniprop_table)
119 (Funicode_property_table_internal, Fget_unicode_property_internal)
120 (Fput_unicode_property_internal): New functions.
121 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
122 Sunicode_property_table_internal, Sget_unicode_property_internal,
123 and Sput_unicode_property_internal. Defvar_lisp
124 char-code-property-alist.
125
126 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
127 Vunicode_category_table.
128
129 * font.c (font_range): Adjusted for the change of
130 Vunicode_category_table.
131
132 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
133
134 * m/iris4d.h: Remove file, move contents ...
135 * s/irix6-5.h: ... here.
136
137 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
138
139 Remove unportable assumption about struct layout (Bug#8884).
140 * alloc.c (mark_buffer):
141 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
142 (clone_per_buffer_values): Don't assume that
143 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
144 This isn't true in general, and it's particularly not true
145 if Emacs is configured with --with-wide-int.
146 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
147 New macros, used in the buffer.c change.
148
149 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
150
151 * xsettings.c: Use both GConf and GSettings if both are available.
152 (store_config_changed_event): Add comment.
153 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
154 (store_tool_bar_style_changed): New functions.
155 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
156 (struct xsettings): Move font inside HAVE_XFT.
157 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
158 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
159 Move inside HAVE_XFT.
160 (something_changed_gsettingsCB): Renamed from something_changedCB.
161 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
162 also.
163 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
164 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
165 (something_changed_gconfCB): Renamed from something_changedCB.
166 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
167 (parse_settings): Move check for font inside HAVE_XFT.
168 (read_settings, apply_xft_settings): Add comment.
169 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
170 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
171 call store_font_name_changed.
172 (xft_settings_event): Add comment.
173 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
174 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
175 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
176 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
177 (xsettings_initialize): Call init_gsettings last.
178 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
179 comment.
180
181 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
182
183 Random fixes. E.g., (random) never returned negative values.
184 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
185 subseconds part to the entropy, as that's a bit more random.
186 Prefer signed to unsigned, since the signedness doesn't matter and
187 in general we prefer signed. When given a limit, use a
188 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
189 latter isn't right if USE_2_TAGS_FOR_INTS.
190 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
191 not 0..VALMASK. Don't discard "excess" bits that random () returns.
192
193 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
194
195 * textprop.c (text_property_stickiness):
196 Obey Vtext_property_default_nonsticky.
197 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
198 * w32fns.c (syms_of_w32fns):
199 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
200
201 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
202
203 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
204 This is more efficient than Ffile_directory_p and avoids a minor race.
205
206 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
207
208 * buffer.c (Foverlay_put): Say what the return value is
209 (bug#7835).
210
211 * fileio.c (barf_or_query_if_file_exists): Check first if the file
212 is a directory before asking whether to use the file name
213 (bug#7564).
214 (barf_or_query_if_file_exists): Make the "File is a directory"
215 error be more correct.
216
217 * fns.c (Frequire): Remove the mention of the .gz files, since
218 that's installation-specific, but keep the mention of
219 `get-load-suffixes'.
220
221 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
222
223 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
224 Report string overflow if the output is too long.
225
226 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
227
228 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
229 (syms_of_gnutls): Remove duplicate DEFSYM for
230 Qgnutls_bootprop_verify_hostname_error, an error for
231 Qgnutls_bootprop_verify_error (which is no longer used).
232
233 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
234 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
235 Also (re)move comments that are misplaced or no longer relevant.
236
237 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
238
239 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
240
241 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
242
243 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
244 and background color parameters if they have been changed.
245
246 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
247
248 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
249
250 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
251
252 * xsettings.c (SYSTEM_FONT): Define only when used.
253 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
254
255 * keymap.c (access_keymap_1): Now static.
256
257 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
258
259 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
260 leave any prefix arg for the up event (Bug#1586).
261
262 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
263
264 * lread.c (syms_of_lread): Mention single symbols defined by
265 `defvar' or `defconst' (bug#7154).
266
267 * fns.c (Frequire): Mention .el.gz files (bug#7314).
268 (Frequire): Mention get-load-suffixes.
269
270 2011-07-02 Martin Rudalics <rudalics@gmx.at>
271
272 * window.h (window): Remove clone_number slot.
273 * window.c (Fwindow_clone_number, Fset_window_clone_number):
274 Remove.
275 (make_parent_window, make_window, saved_window)
276 (Fset_window_configuration, save_window_save): Don't deal with
277 clone numbers.
278 * buffer.c (Qclone_number): Remove declaration.
279 (sort_overlays, overlay_strings): Don't deal with clone numbers.
280
281 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
282
283 Add multiple inheritance to keymaps.
284 * keymap.c (Fmake_composed_keymap): New function.
285 (Fset_keymap_parent): Simplify.
286 (fix_submap_inheritance): Remove.
287 (access_keymap_1): New function extracted from access_keymap to handle
288 embedded parents and handle lists of maps.
289 (access_keymap): Use it.
290 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
291 (Fcopy_keymap): Handle embedded parents.
292 (Fcommand_remapping, define_as_prefix): Simplify.
293 (Fkey_binding): Simplify.
294 (syms_of_keymap): Move minibuffer-local-completion-map,
295 minibuffer-local-filename-completion-map,
296 minibuffer-local-must-match-map, and
297 minibuffer-local-filename-must-match-map to Elisp.
298 (syms_of_keymap): Defsubr make-composed-keymap.
299 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
300 (parse_menu_item): Trivial simplification.
301
302 2011-07-01 Glenn Morris <rgm@gnu.org>
303
304 * Makefile.in (SETTINGS_LIBS): Fix typo.
305
306 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
307
308 * coding.c (Fencode_coding_string): Record the last coding system
309 used, as the function doc string says (bug#8738).
310
311 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
312
313 * xsettings.c (store_monospaced_changed): Take new font as arg and
314 check for change against current_mono_font.
315 (EMACS_TYPE_SETTINGS): Remove this and related defines.
316 (emacs_settings_constructor, emacs_settings_get_property)
317 (emacs_settings_set_property, emacs_settings_class_init)
318 (emacs_settings_init, gsettings_obj): Remove.
319 (something_changedCB): New function for HAVE_GSETTINGS.
320 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
321 with value as argument.
322 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
323 g_settings_new (Bug#8967). Do not create gsettings_obj.
324 Remove calls to g_settings_bind. Connect something_changedCB to
325 "changed".
326
327 * xgselect.c: Add defined (HAVE_GSETTINGS).
328 (xgselect_initialize): Ditto.
329
330 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
331 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
332 xg_select.
333
334 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
335
336 * eval.c (struct backtrace): Simplify and port the data structure.
337 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
338 signed bit field, as this assumption is not portable and it makes
339 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
340 "char debug_on_exit : 1" as this is not portable either; instead,
341 use the portable "unsigned int debug_on_exit : 1". Remove unused
342 member evalargs. Remove obsolete comments about cc bombing out.
343
344 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
345
346 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
347 Let HAVE_GSETTINGS override HAVE_GCONF.
348 (store_monospaced_changed): New function.
349 (EMACS_SETTINGS): A new type derived from GObject to handle
350 GSettings notifications.
351 (emacs_settings_constructor, emacs_settings_get_property)
352 (emacs_settings_set_property, emacs_settings_class_init):
353 New functions.
354 (gsettings_client, gsettings_obj): New variables.
355 (GSETTINGS_SCHEMA): New define.
356 (something_changedCB): Call store_monospaced_changed.
357 (init_gsettings): New function.
358 (xsettings_initialize): Call init_gsettings.
359 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
360 to NULL.
361
362 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
363 GCONF_CFLAGS/LIBS.
364
365 2011-06-29 Martin Rudalics <rudalics@gmx.at>
366
367 * window.c (resize_root_window, grow_mini_window)
368 (shrink_mini_window): Rename Qresize_root_window to
369 Qwindow_resize_root_window and Qresize_root_window_vertically to
370 Qwindow_resize_root_window_vertically.
371
372 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
373
374 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
375
376 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
377
378 * makefile.w32-in: Redesign dependencies so they reflect more
379 clearly which files are directly included by each source file,
380 and not through other includes.
381
382 2011-06-27 Martin Rudalics <rudalics@gmx.at>
383
384 * buffer.c (Qclone_number): Declare static and DEFSYM it.
385 (sort_overlays, overlay_strings): When an overlay's clone number
386 matches the window's clone number process the overlay even if
387 the overlay's window property doesn't match the current window.
388
389 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
390 (Fwindow_hchild): Rename to Fwindow_left_child.
391 (Fwindow_next): Rename to Fwindow_next_sibling.
392 (Fwindow_prev): Rename to Fwindow_prev_sibling.
393 (resize_window_check): Rename to window_resize_check.
394 (resize_window_apply): Rename to window_resize_apply.
395 (Fresize_window_apply): Rename to Fwindow_resize_apply.
396 (Fdelete_other_windows_internal, resize_frame_windows)
397 (Fsplit_window_internal, Fdelete_window_internal)
398 (grow_mini_window, shrink_mini_window)
399 (Fresize_mini_window_internal): Fix callers accordingly.
400
401 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
402
403 * emacsgtkfixed.h: State that this is only used with Gtk+3.
404 (emacs_fixed_set_min_size): Remove.
405 (emacs_fixed_new): Take frame as argument.
406
407 * emacsgtkfixed.c: State that this is only used with Gtk+3.
408 (_EmacsFixedPrivate): Remove minwidth/height.
409 Add struct frame *f.
410 (emacs_fixed_init): Initialize priv->f.
411 (get_parent_class, emacs_fixed_set_min_size): Remove.
412 (emacs_fixed_new): Set priv->f to argument.
413 (emacs_fixed_get_preferred_width)
414 (emacs_fixed_get_preferred_height): Use min_width/height from
415 frames size_hint to set minimum and natural (Bug#8919).
416 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
417 and use min_width/height from frames size_hint to set
418 min_width/height (Bug#8919).
419
420 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
421 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
422 Fix indentation.
423
424 2011-06-26 Eli Zaretskii <eliz@gnu.org>
425
426 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
427 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
428 called at ZV.
429
430 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
431
432 * process.c (wait_reading_process_output): Bypass select if
433 waiting for a cell while ignoring keyboard input, and input is
434 pending. Suggested by Jan Djärv (Bug#8869).
435
436 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
437
438 Use gnulib's dup2 module instead of rolling our own.
439 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
440
441 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
442
443 * dispnew.c (scrolling_window): Before scrolling, turn off a
444 mouse-highlight in the window being scrolled.
445
446 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
447
448 Move DEFSYM to lisp.h and use everywhere.
449
450 * character.h (DEFSYM): Move declaration...
451 * lisp.h (DEFSYM): ...here.
452
453 * gnutls.c:
454 * minibuf.c:
455 * w32menu.c:
456 * w32proc.c:
457 * w32select.c: Don't include character.h.
458
459 * alloc.c (syms_of_alloc):
460 * buffer.c (syms_of_buffer):
461 * bytecode.c (syms_of_bytecode):
462 * callint.c (syms_of_callint):
463 * casefiddle.c (syms_of_casefiddle):
464 * casetab.c (init_casetab_once):
465 * category.c (init_category_once, syms_of_category):
466 * ccl.c (syms_of_ccl):
467 * cmds.c (syms_of_cmds):
468 * composite.c (syms_of_composite):
469 * dbusbind.c (syms_of_dbusbind):
470 * dired.c (syms_of_dired):
471 * dispnew.c (syms_of_display):
472 * doc.c (syms_of_doc):
473 * editfns.c (syms_of_editfns):
474 * emacs.c (syms_of_emacs):
475 * eval.c (syms_of_eval):
476 * fileio.c (syms_of_fileio):
477 * fns.c (syms_of_fns):
478 * frame.c (syms_of_frame):
479 * fringe.c (syms_of_fringe):
480 * insdel.c (syms_of_insdel):
481 * keymap.c (syms_of_keymap):
482 * lread.c (init_obarray, syms_of_lread):
483 * macros.c (syms_of_macros):
484 * msdos.c (syms_of_msdos):
485 * print.c (syms_of_print):
486 * process.c (syms_of_process):
487 * search.c (syms_of_search):
488 * sound.c (syms_of_sound):
489 * syntax.c (init_syntax_once, syms_of_syntax):
490 * terminal.c (syms_of_terminal):
491 * textprop.c (syms_of_textprop):
492 * undo.c (syms_of_undo):
493 * w32.c (globals_of_w32):
494 * window.c (syms_of_window):
495 * xdisp.c (syms_of_xdisp):
496 * xfaces.c (syms_of_xfaces):
497 * xfns.c (syms_of_xfns):
498 * xmenu.c (syms_of_xmenu):
499 * xsettings.c (syms_of_xsettings):
500 * xterm.c (syms_of_xterm): Use DEFSYM.
501
502 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
503
504 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
505
506 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
507
508 Integer and buffer overflow fixes (Bug#8873).
509
510 * print.c (printchar, strout): Check for string overflow.
511 (PRINTPREPARE, printchar, strout):
512 Don't set size unless allocation succeeds.
513
514 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
515 for sizes. Check for string overflow more accurately.
516 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
517
518 * macros.c: Integer and buffer overflow fixes.
519 * keyboard.h (struct keyboard.kbd_macro_bufsize):
520 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
521 Use ptrdiff_t, not int, for sizes.
522 Don't increment bufsize until after realloc succeeds.
523 Check for size-calculation overflow.
524 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
525
526 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
527
528 * lread.c: Integer overflow fixes.
529 (read_integer): Radix is now EMACS_INT, not int,
530 to improve quality of diagnostics for out-of-range radices.
531 Calculate buffer size correctly for out-of-range radices.
532 (read1): Check for integer overflow in radices, and in
533 read-circle numbers.
534 (read_escape): Avoid int overflow.
535 (Fload, openp, read_buffer_size, read1)
536 (substitute_object_recurse, read_vector, read_list, map_obarray):
537 Use ptrdiff_t, not int, for sizes.
538 (read1): Use EMACS_INT, not int, for sizes.
539 Check for size overflow.
540
541 * image.c (cache_image): Check for size arithmetic overflow.
542
543 * lread.c: Integer overflow issues.
544 (saved_doc_string_size, saved_doc_string_length)
545 (prev_saved_doc_string_size, prev_saved_doc_string_length):
546 Now ptrdiff_t, not int.
547 (read1): Don't assume doc string length fits in int. Check for
548 out-of-range doc string lengths.
549 (read_list): Don't assume file position fits in int.
550 (read_escape): Check for hex character overflow.
551
552 2011-06-22 Leo Liu <sdl.web@gmail.com>
553
554 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
555 Move to minibuffer.el.
556
557 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
558
559 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
560 The following patches are for when GLYPH_DEBUG && !XASSERT.
561 * dispextern.h (trace_redisplay_p, dump_glyph_string):
562 * dispnew.c (flush_stdout):
563 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
564 Mark as externally visible.
565 * dispnew.c (check_window_matrix_pointers): Now static.
566 * dispnew.c (window_to_frame_vpos):
567 * xfns.c (unwind_create_frame):
568 * xterm.c (x_check_font): Remove unused local.
569 * scroll.c (CHECK_BOUNDS):
570 * xfaces.c (cache_fache): Rename local to avoid shadowing.
571 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
572 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
573 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
574 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
575 Now static.
576 (debug_method_add): Use va_list and vsprintf rather than relying
577 on undefined behavior with wrong number of arguments.
578 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
579 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
580 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
581 since we're not interested in debugging glyphs with old libraries.
582 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
583 GCC 4.6.0's static checking.
584
585 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
586
587 Integer overflow and signedness fixes (Bug#8873).
588 A few related buffer overrun fixes, too.
589
590 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
591
592 * dispextern.h (struct face.stipple):
593 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
594 (x_bitmap_mask, x_allocate_bitmap_record)
595 (x_create_bitmap_from_data, x_create_bitmap_from_file)
596 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
597 (x_create_bitmap_from_xpm_data):
598 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
599 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
600 (.bitmaps_last):
601 * xfaces.c (load_pixmap):
602 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
603 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
604 (.bitmaps_last, struct x_output.icon_bitmap):
605 Use ptrdiff_t, not int, for bitmap indexes.
606 (x_allocate_bitmap_record): Check for size overflow.
607 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
608
609 Use ptrdiff_t, not int, for overlay counts.
610 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
611 * editfns.c (overlays_around, get_pos_property):
612 * textprop.c (get_char_property_and_overlay):
613 * xdisp.c (next_overlay_change, note_mouse_highlight):
614 * xfaces.c (face_at_buffer_position):
615 * buffer.c (OVERLAY_COUNT_MAX): New macro.
616 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
617 (Fnext_overlay_change, Fprevious_overlay_change)
618 (mouse_face_overlay_overlaps, Foverlays_in):
619 Use ptrdiff_t, not int, for sizes.
620 (overlays_at, overlays_in): Check for size-calculation overflow.
621
622 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
623
624 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
625 (x_session_initialize): Do not assume string length fits in int.
626
627 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
628 This is unlikely, but can occur if DPI is outlandish.
629
630 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
631 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
632
633 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
634 * xrdb.c (magic_file_p, search_magic_path):
635 Omit last arg SUFFIX; it was always 0. All callers changed.
636 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
637
638 * xfont.c (xfont_match): Avoid need for strlen.
639
640 * xfns.c: Don't assume strlen fits in int.
641 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
642
643 * xdisp.c (message_log_check_duplicate): Return intmax_t,
644 not unsigned long, as we prefer signed integers. All callers changed.
645 Detect integer overflow in repeat count.
646 (message_dolog): Don't assume print length fits in 39 bytes.
647 (display_mode_element): Don't assume strlen fits in int.
648
649 * termcap.c: Don't assume sizes fit in int and never overflow.
650 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
651 (gobble_line): Check for size-calculation overflow.
652
653 * minibuf.c (Fread_buffer):
654 * lread.c (intern, intern_c_string):
655 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
656 Don't assume string length fits in int.
657
658 * keyboard.c (parse_tool_bar_item):
659 * gtkutil.c (style_changed_cb): Avoid need for strlen.
660
661 * font.c: Don't assume string length fits in int.
662 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
663 Use ptrdiff_t, not int.
664 (font_intern_prop): Don't assume string length fits in int.
665 Don't assume integer property fits in fixnum.
666 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
667
668 * filelock.c: Fix some buffer overrun and integer overflow issues.
669 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
670 Reformulate so as not to need the command string.
671 Invoke gzip -cd rather than gunzip, as it's more portable.
672 (lock_info_type, lock_file_1, lock_file):
673 Don't assume pid_t and time_t fit in unsigned long.
674 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
675 (current_lock_owner): Prefer signed type for sizes.
676 Use memcpy, not strncpy, where memcpy is what is really wanted.
677 Don't assume (via atoi) that time_t and pid_t fit in int.
678 Check for time_t and/or pid_t out of range, e.g., via a network share.
679 Don't alloca where an auto var works fine.
680
681 * fileio.c: Fix some integer overflow issues.
682 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
683 Don't assume string length fits in int.
684 (directory_file_name): Don't assume string length fits in long.
685 (make_temp_name): Don't assume pid fits in int, or that its print
686 length is less than 20.
687
688 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
689
690 * coding.c (make_subsidiaries): Don't assume string length fits in int.
691
692 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
693
694 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
695 We prefer signed integers, even for size calculations.
696
697 * emacs.c: Don't assume string length fits in 'int'.
698 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
699 (main): Don't invoke strlen when not needed.
700
701 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
702 (XD_DEBUG_MESSAGE): Don't waste a byte.
703
704 * callproc.c (getenv_internal_1, getenv_internal)
705 (Fgetenv_internal):
706 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
707
708 * lread.c (invalid_syntax): Omit length argument.
709 All uses changed. This doesn't fix a bug, but it simplifies the
710 code away from its former Hollerith-constant appearance, and it's
711 one less 'int' to worry about when looking at integer-overflow issues.
712 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
713
714 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
715 This didn't break anything, but it didn't help either.
716 It's confusing to put a bogus integer in a place where the actual
717 value does not matter.
718 (LIST_END_P): Remove unused macro and its bogus comment.
719 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
720
721 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
722 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
723 implementation.
724 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
725 We prefer signed types, and the value cannot exceed the EMACS_INT
726 range anyway (because otherwise the length would not be representable).
727 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
728 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
729 This avoids a GCC warning when WIDE_EMACS_INT.
730
731 * indent.c (sane_tab_width): New function.
732 (current_column, scan_for_column, Findent_to, position_indentation)
733 (compute_motion): Use it. This is just for clarity.
734 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
735
736 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
737
738 * lisp.h (lint_assume): New macro.
739 * composite.c (composition_gstring_put_cache):
740 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
741
742 * editfns.c, insdel.c:
743 Omit unnecessary forward decls, to simplify future changes.
744
745 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
746
747 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
748
749 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
750 Use much-faster test for byte-length change.
751 Don't assume string byte-length fits in 'int'.
752 Check that character arg fits in 'int'.
753 (mapcar1): Declare byte as byte, for clarity.
754
755 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
756
757 * fns.c (concat): Catch string overflow earlier.
758 Do not rely on integer wraparound.
759
760 * dispextern.h (struct it.overlay_strings_charpos)
761 (struct it.selective): Now EMACS_INT, not int.
762 * xdisp.c (forward_to_next_line_start)
763 (back_to_previous_visible_line_start)
764 (reseat_at_next_visible_line_start, next_element_from_buffer):
765 Don't arbitrarily truncate the value of 'selective' to int.
766
767 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
768
769 * composite.c: Don't truncate sizes to 'int'.
770 (composition_gstring_p, composition_reseat_it)
771 (composition_adjust_point): Use EMACS_INT, not int.
772 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
773 not EMACS_UINT, for indexes.
774
775 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
776
777 * buffer.c: Include <verify.h>.
778 (struct sortvec.priority, struct sortstr.priority):
779 Now EMACS_INT, not int.
780 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
781 (struct sortstr.size, record_overlay_string)
782 (struct sortstrlist.size, struct sortlist.used):
783 Don't truncate size to int.
784 (record_overlay_string): Check for size-calculation overflow.
785 (init_buffer_once): Check at compile-time, not run-time.
786
787 2011-06-22 Jim Meyering <meyering@redhat.com>
788
789 Don't leak an XBM-image-sized buffer
790 * image.c (xbm_load): Free the image buffer after using it.
791
792 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
793
794 Port to Sun C.
795 * composite.c (find_automatic_composition): Omit needless 'return 0;'
796 that Sun C diagnosed.
797 * fns.c (secure_hash): Fix pointer signedness issue.
798 * intervals.c (static_offset_intervals): New function.
799 (offset_intervals): Use it.
800
801 2011-06-21 Leo Liu <sdl.web@gmail.com>
802
803 * deps.mk (fns.o):
804 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
805 sha512.h.
806
807 * fns.c (secure_hash): Rename from crypto_hash_function and change
808 the first arg to accept symbols.
809 (Fsecure_hash): New primitive.
810 (syms_of_fns): New symbols.
811
812 2011-06-20 Deniz Dogan <deniz@dogan.se>
813
814 * process.c (Fset_process_buffer): Clarify return value in
815 docstring.
816
817 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
818
819 * dispnew.c (add_window_display_history): Use BVAR.
820
821 * xdisp.c (debug_method_add): Use BVAR.
822 (check_window_end, dump_glyph_matrix, dump_glyph)
823 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
824
825 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
826 Likewise.
827
828 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
829 check till after the cache is created in init_frame_faces.
830
831 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
832
833 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
834
835 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
836
837 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
838 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
839 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
840
841 Improve buffer-overflow checking (Bug#8873).
842 * fileio.c (Finsert_file_contents):
843 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
844 Remove the old (too-loose) buffer overflow checks.
845 They weren't needed, since make_gap checks for buffer overflow.
846 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
847 The old code merely checked for Emacs fixnum overflow, and relied
848 on undefined (wraparound) behavior. The new code avoids undefined
849 behavior, and also checks for ptrdiff_t and/or size_t overflow.
850
851 * editfns.c (Finsert_char): Don't dump core with very negative counts.
852 Tune. Don't use wider integers than needed. Don't use alloca.
853 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
854
855 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
856
857 * insdel.c, lisp.h (buffer_overflow): New function.
858 (insert_from_buffer_1, replace_range, replace_range_2):
859 * insdel.c (make_gap_larger):
860 * editfns.c (Finsert_char):
861 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
862
863 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
864
865 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
866
867 Integer overflow and signedness fixes (Bug#8873).
868
869 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
870 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
871
872 * fileio.c: Don't assume EMACS_INT fits in off_t.
873 (emacs_lseek): New static function.
874 (Finsert_file_contents, Fwrite_region): Use it.
875 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
876
877 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
878
879 * fns.c: Don't overflow int when computing a list length.
880 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
881 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
882 truncation on 64-bit hosts. Check for QUIT every
883 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
884 faster and is responsive enough.
885 (Flength): Report an error instead of overflowing an integer.
886 (Fsafe_length): Return a float if the value is not representable
887 as a fixnum. This shouldn't happen except in contrived situations.
888 (Fnthcdr, Fsort): Don't assume list length fits in int.
889 (Fcopy_sequence): Don't assume vector length fits in int.
890
891 * alloc.c: Check that resized vectors' lengths fit in fixnums.
892 (header_size, word_size): New constants.
893 (allocate_vectorlike): Don't check size overflow here.
894 (allocate_vector): Check it here instead, since this is the only
895 caller of allocate_vectorlike that could cause overflow.
896 Check that the new vector's length is representable as a fixnum.
897
898 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
899 The previous code was bogus. For example, next_almost_prime (32)
900 returned 39, which is undesirable as it is a multiple of 3; and
901 next_almost_prime (24) returned 25, which is a multiple of 5 so
902 why was the code bothering to check for multiples of 7?
903
904 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
905
906 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
907
908 Variadic C functions now count arguments with ptrdiff_t.
909 This partly undoes my 2011-03-30 change, which replaced int with size_t.
910 Back then I didn't know that the Emacs coding style prefers signed int.
911 Also, in the meantime I found a few more instances where arguments
912 were being counted with int, which may truncate counts on 64-bit
913 machines, or EMACS_INT, which may be unnecessarily wide.
914 * lisp.h (struct Lisp_Subr.function.aMANY)
915 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
916 Arg counts are now ptrdiff_t, not size_t.
917 All variadic functions and their callers changed accordingly.
918 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
919 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
920 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
921 * callint.c (Fcall_interactively): Check arg count for overflow,
922 to avoid potential buffer overrun. Use signed char, not 'int',
923 for 'varies' array, so that we needn't bother to check its size
924 calculation for overflow.
925 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
926 * eval.c (apply_lambda):
927 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
928 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
929 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
930
931 * callint.c (Fcall_interactively): Don't use index var as event count.
932
933 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
934 * mem-limits.h (SIZE): Remove; no longer used.
935
936 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
937
938 Remove unnecessary casts.
939 * xterm.c (x_term_init):
940 * xfns.c (x_set_border_pixel):
941 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
942 These aren't needed now that we assume ANSI C.
943
944 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
945 It's more likely to cause problems (due to unsigned overflow)
946 than to cure them.
947
948 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
949
950 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
951
952 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
953
954 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
955
956 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
957
958 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
959
960 GLYPH_CODE_FACE returns EMACS_INT, not int.
961 * dispextern.h (merge_faces):
962 * xfaces.c (merge_faces):
963 * xdisp.c (get_next_display_element, next_element_from_display_vector):
964 Don't assume EMACS_INT fits in int.
965
966 * character.h (CHAR_VALID_P): Remove unused parameter.
967 * fontset.c, lisp.h, xdisp.c: All uses changed.
968
969 * editfns.c (Ftranslate_region_internal): Omit redundant test.
970
971 * fns.c (concat): Minor tuning based on overflow analysis.
972 This doesn't fix any bugs. Use int to hold character, instead
973 of constantly refetching from Emacs object. Use XFASTINT, not
974 XINT, for value known to be a character. Don't bother comparing
975 a single byte to 0400, as it's always less.
976
977 * floatfns.c (Fexpt):
978 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
979
980 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
981 for characters.
982
983 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
984
985 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
986 Without this fix, on a 64-bit host (aset S 0 4294967386) would
987 incorrectly succeed when S was a string, because 4294967386 was
988 truncated before it was used.
989
990 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
991 Otherwise, an out-of-range integer could cause undefined behavior
992 on a 64-bit host.
993
994 * composite.c: Use int, not EMACS_INT, for characters.
995 (fill_gstring_body, composition_compute_stop_pos): Use int, not
996 EMACS_INT, for values that are known to be in character range.
997 This doesn't fix any bugs but is the usual style inside Emacs and
998 may generate better code on 32-bit machines.
999
1000 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1001 This is for reasons similar to the recent CHAR_STRING fix.
1002 * charset.c (Fencode_char): Check that character arg is actually
1003 a character. Pass an int to ENCODE_CHAR.
1004 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1005 wider than 'int', as a compile-time check to prevent future regressions
1006 in this area.
1007
1008 * character.c (char_string): Remove unnecessary casts.
1009
1010 Make sure a 64-bit char is never passed to CHAR_STRING.
1011 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1012 by silently ignoring the top 32 bits, allowing some values
1013 that were far too large to be valid characters.
1014 * character.h: Include <verify.h>.
1015 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1016 arguments are no wider than unsigned, as a compile-time check
1017 to prevent future regressions in this area.
1018 * data.c (Faset):
1019 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1020 (Fsubst_char_in_region):
1021 * fns.c (concat):
1022 * xdisp.c (decode_mode_spec_coding):
1023 Adjust to CHAR_STRING's new requirement.
1024 * editfns.c (Finsert_char, Fsubst_char_in_region):
1025 * fns.c (concat): Check that character args are actually
1026 characters. Without this test, these functions did the wrong
1027 thing with wildly out-of-range values on 64-bit hosts.
1028
1029 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1030 These casts should not be needed on 32-bit hosts, either.
1031 * keyboard.c (read_char):
1032 * lread.c (Fload): Remove casts to unsigned.
1033
1034 * lisp.h (UNSIGNED_CMP): New macro.
1035 This fixes comparison bugs on 64-bit hosts.
1036 (ASCII_CHAR_P): Use it.
1037 * casefiddle.c (casify_object):
1038 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1039 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1040 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1041 * dispextern.h (FACE_FROM_ID):
1042 * keyboard.c (read_char): Use UNSIGNED_CMP.
1043
1044 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1045 not to EMACS_INT, to avoid GCC warning.
1046
1047 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1048
1049 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1050 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1051 isn't needed on 32-bit machines.
1052
1053 * buffer.c (Fgenerate_new_buffer_name):
1054 Use EMACS_INT for count, not int.
1055 (advance_to_char_boundary): Return EMACS_INT, not int.
1056
1057 * data.c (Qcompiled_function): Now static.
1058
1059 * window.c (window_body_lines): Now static.
1060
1061 * image.c (gif_load): Rename local to avoid shadowing.
1062
1063 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1064 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1065 * alloc.c (make_save_value): Integer argument is now of type
1066 ptrdiff_t, not int.
1067 (mark_object): Use ptrdiff_t, not int.
1068 * lisp.h (pD): New macro.
1069 * print.c (print_object): Use it.
1070
1071 * alloc.c: Use EMACS_INT, not int, to count objects.
1072 (total_conses, total_markers, total_symbols, total_vector_size)
1073 (total_free_conses, total_free_markers, total_free_symbols)
1074 (total_free_floats, total_floats, total_free_intervals)
1075 (total_intervals, total_strings, total_free_strings):
1076 Now EMACS_INT, not int. All uses changed.
1077 (Fgarbage_collect): Compute overall total using a double, so that
1078 integer overflow is less likely to be a problem. Check for overflow
1079 when converting back to an integer.
1080 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1081 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1082 These were 'int' variables that could overflow on 64-bit hosts;
1083 they were never used, so remove them instead of repairing them.
1084 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1085 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1086 Previously, this ceilinged at INT_MAX, but that doesn't work on
1087 64-bit machines.
1088 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1089
1090 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1091 (allocate_vectorlike): Check for ptrdiff_t overflow.
1092 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1093 when a (possibly-narrower) signed value would do just as well.
1094 We prefer using signed arithmetic, to avoid comparison confusion.
1095
1096 * alloc.c: Catch some string size overflows that we were missing.
1097 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1098 for convenience in STRING_BYTES_MAX.
1099 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1100 The definition here is exact; the one in lisp.h was approximate.
1101 (allocate_string_data): Check for string overflow. This catches
1102 some instances we weren't catching before. Also, it catches
1103 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1104 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1105 and ptrdiff_t and EMACS_INT are both 64 bits.
1106
1107 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1108 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1109 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1110
1111 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1112
1113 * alloc.c (Fmake_string): Check for out-of-range init.
1114
1115 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1116
1117 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1118
1119 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1120
1121 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1122 xg_get_default_scrollbar_width.
1123
1124 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1125 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1126 (style_changed_cb): Call update_theme_scrollbar_width and call
1127 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1128 all frames (Bug#8505).
1129 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1130 Call gtk_window_set_resizable if HAVE_GTK3.
1131 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1132 and height if HAVE_GTK3 (Bug#8505).
1133 (scroll_bar_width_for_theme): New variable.
1134 (update_theme_scrollbar_width): New function.
1135 (xg_get_default_scrollbar_width): Move code to
1136 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1137 (xg_initialize): Call update_theme_scrollbar_width.
1138
1139 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1140
1141 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1142
1143 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1144
1145 * frame.c (make_frame): Call other_buffer_safely instead of
1146 other_buffer.
1147
1148 * window.c (temp_output_buffer_show): Call display_buffer with
1149 second argument Vtemp_buffer_show_specifiers and reset latter
1150 immediately after the call.
1151 (Vtemp_buffer_show_specifiers): New variable.
1152 (auto_window_vscroll_p, next_screen_context_lines)
1153 (Vscroll_preserve_screen_position): Remove leading asterisks from
1154 doc-strings.
1155
1156 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 Fix minor problems found by GCC 4.6.0 static checking.
1159 * buffer.c (Qclone_number): Remove for now, as it's unused.
1160 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1161 (record_buffer): Remove unused local.
1162 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1163 (set_frame_buffer_list): Remove; unused.
1164 * frame.h (other_visible_frames): Remove decl.
1165 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1166 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1167 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1168 if HAVE_GPM.
1169 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1170 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1171 Define only if HAVE_GPM.
1172 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1173 (update_hints_inhibit): Remove; never set. All uses removed.
1174 * widgetprv.h (emacsFrameClassRec): Remove decl.
1175 * window.c (delete_deletable_window): Now returns void, since it
1176 wasn't returning anything.
1177 (compare_window_configurations): Remove unused locals.
1178 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1179 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1180 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1181 the same widths as pointers. This follows up on the 2011-05-06 patch.
1182 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1183 * xterm.h: Likewise.
1184 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1185
1186 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1187
1188 * makefile.w32-in: Update dependencies.
1189 (LISP_H): Add lib/intprops.h.
1190
1191 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1192
1193 * image.c (gif_load): Add animation frame delay to the metadata.
1194 (syms_of_image): Use DEFSYM. New symbol `delay'.
1195
1196 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1197
1198 * window.c (delete_deletable_window): Re-add.
1199 (Fset_window_configuration): Rewrite to handle dead buffers and
1200 consequently deletable windows.
1201 (window_tree, Fwindow_tree): Remove. Supply functionality in
1202 window.el.
1203 (compare_window_configurations): Simplify code.
1204
1205 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1206
1207 * image.c (imagemagick_load_image): Fix type mismatch.
1208 (Fimagemagick_types): Likewise.
1209
1210 * window.h (replace_buffer_in_windows): Declare.
1211
1212 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1213
1214 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1215 Qclone_number. Remove external declaration of Qdelete_window.
1216 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1217 code.
1218 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1219 Qbuffer_list_update_hook if allowed.
1220 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1221 buffer list implementation.
1222 (other_buffer_safely): New function.
1223 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1224 calls to replace_buffer_in_windows and
1225 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1226 if allowed.
1227 (record_buffer): Inhibit quitting and rewrite using quittable
1228 functions. Run Qbuffer_list_update_hook if allowed.
1229 (Frecord_buffer, Funrecord_buffer): New functions.
1230 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1231 switch-to-buffer to window.el.
1232 (bury-buffer): Move to window.el.
1233 (Vbuffer_list_update_hook): New variable.
1234
1235 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1236 section.
1237
1238 * window.h (resize_frame_windows): Move up in code.
1239 (Fwindow_frame): Remove EXFUN.
1240 (replace_buffer_in_all_windows): Remove prototype.
1241 (replace_buffer_in_windows_safely): Add prototype.
1242
1243 * window.c: Declare Qdelete_window static again. Move down
1244 declaration of select_count.
1245 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1246 (Fother_window): Move to window.el.
1247 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1248 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1249 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1250 window.el.
1251 (replace_buffer_in_windows): Implement by calling
1252 Qreplace_buffer_in_windows.
1253 (replace_buffer_in_all_windows): Remove with some functionality
1254 moved into replace_buffer_in_windows_safely.
1255 (replace_buffer_in_windows_safely): New function.
1256 (select_window_norecord, select_frame_norecord): Move in front
1257 of run_window_configuration_change_hook. Remove now obsolete
1258 declarations.
1259 (Fset_window_buffer): Rewrite doc-string. Call
1260 Qrecord_window_buffer.
1261 (keys_of_window): Move binding for other-window to window.el.
1262
1263 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1264
1265 * dispextern.h (struct image): Replace data member, whose int_val
1266 and ptr_val fields were not used by anything, with a single
1267 lisp_val object.
1268
1269 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1270 (gif_clear_image, gif_load, imagemagick_load_image)
1271 (gs_clear_image, gs_load): Callers changed.
1272
1273 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1274
1275 * buffer.h: Include <time.h>, for time_t.
1276 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1277
1278 Fix minor problems found by static checking.
1279
1280 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1281
1282 Make identifiers static if they are not used in other modules.
1283 * data.c (Qcompiled_function, Qframe, Qvector):
1284 * image.c (QimageMagick, Qsvg):
1285 * minibuf.c (Qmetadata):
1286 * window.c (resize_window_check, resize_root_window): Now static.
1287 * window.h (resize_window_check, resize_root_window): Remove decls.
1288
1289 * window.c (window_deletion_count, delete_deletable_window):
1290 Remove; unused.
1291 (window_body_lines): Now static.
1292 (Fdelete_other_windows_internal): Mark vars as initialized.
1293 Make sure 'resize_failed' is initialized.
1294 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1295 (resize_window_apply): Remove unused local.
1296 * window.h (delete_deletable_window): Remove decl.
1297
1298 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1299 (imagemagick_load_image): Fix pointer signedness problem by changing
1300 last arg from unsigned char * to char *. All uses changed.
1301 Also, fix a local for similar reasons.
1302 Remove unused locals. Remove locals to avoid shadowing.
1303 (fn_rsvg_handle_free): Remove; unused.
1304 (svg_load, svg_load_image): Fix pointer signedness problem.
1305 (imagemagick_load_image): Don't use garbage pointer image_wand.
1306
1307 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1308
1309 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1310
1311 * image.c (gif_load): Fix omitted cast error introduced by
1312 2011-06-06 change.
1313
1314 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1315
1316 * window.h (resize_proportionally, orig_total_lines)
1317 (orig_top_line): Remove from window structure.
1318 (set_window_height, set_window_width, change_window_heights)
1319 (Fdelete_window): Remove prototypes.
1320 (resize_frame_windows): Remove duplicate declaration.
1321
1322 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1323
1324 * window.h (resize_frame_windows, resize_window_check)
1325 (delete_deletable_window, resize_root_window)
1326 (resize_frame_windows): Declare prototypes.
1327
1328 * window.c (resize_window_apply): Make definition be "static" to
1329 match the prototype.
1330
1331 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1332
1333 * window.c: Remove declarations of Qwindow_size_fixed,
1334 window_min_size_1, window_min_size_2, window_min_size,
1335 size_window, window_fixed_size_p, enlarge_window, delete_window.
1336 Remove static from declaration of Qdelete_window, it's
1337 temporarily needed by Fbury_buffer.
1338 (replace_window): Don't assign orig_top_line and
1339 orig_total_lines.
1340 (Fdelete_window, delete_window): Remove. Window deletion is
1341 handled by window.el.
1342 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1343 Fdelete_window calls with calls to Qdelete_window.
1344 (Fdelete_other_windows): Remove. Deleting other windows is
1345 handled by window.el.
1346 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1347 handled in window.el.
1348 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1349 Window minimum sizes are handled in window.el.
1350 (shrink_windows, size_window, set_window_height)
1351 (set_window_width, change_window_heights, window_height)
1352 (window_width, CURBEG, CURSIZE, enlarge_window)
1353 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1354 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1355 handled in window.el.
1356 (make_dummy_parent): Rename to make_parent_window and give it a
1357 second argument horflag.
1358 (make_window): Don't set resize_proportionally any more.
1359 (Fsplit_window): Remove. Windows are split in window.el.
1360 (save_restore_action, save_restore_orig_size)
1361 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1362 Resize mini windows in window.el.
1363 (grow_mini_window, shrink_mini_window): Implement by calling
1364 Qresize_root_window_vertically, resize_window_check and
1365 resize_window_apply.
1366 (saved_window, Fset_window_configuration, save_window_save): Do
1367 not handle orig_top_line, orig_total_lines, and
1368 resize_proportionally.
1369 (window_min_height, window_min_width): Move to window.el.
1370 (keys_of_window): Move bindings for delete-other-windows,
1371 split-window, delete-window and enlarge-window to window.el.
1372
1373 * buffer.c: Temporarily extern Qdelete_window.
1374 (Fbury_buffer): Temporarily call Qdelete_window instead of
1375 Fdelete_window (Fbury_buffer will move to window.el soon).
1376
1377 * frame.c (set_menu_bar_lines_1): Remove code handling
1378 orig_top_line and orig_total_lines.
1379
1380 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1381 set_window_height but set heights directly.
1382 (change_frame_size_1): Use resize_frame_windows.
1383
1384 * xdisp.c (init_xdisp): Don't use set_window_height but set
1385 heights directly.
1386
1387 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1388 resize_frame_windows instead of change_window_heights and run
1389 run_window_configuration_change_hook.
1390
1391 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1392 instead of change_window_heights and run
1393 run_window_configuration_change_hook.
1394
1395 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1396
1397 * window.c (replace_window): Rename second argument REPLACEMENT to
1398 NEW. New third argument SETFLAG. Rewrite.
1399 (delete_window, make_dummy_parent): Call replace_window with
1400 third argument 1.
1401 (window_list_1): Move down in code.
1402 (run_window_configuration_change_hook): Move set_buffer part
1403 before select_frame_norecord part in order to unwind correctly.
1404 Rename count1 to count.
1405 (recombine_windows, delete_deletable_window, resize_root_window)
1406 (Fdelete_other_windows_internal)
1407 (Frun_window_configuration_change_hook, make_parent_window)
1408 (resize_window_check, resize_window_apply, Fresize_window_apply)
1409 (resize_frame_windows, Fsplit_window_internal)
1410 (Fdelete_window_internal, Fresize_mini_window_internal): New
1411 functions.
1412 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1413
1414 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1415
1416 * window.h (window): Add some new members to window structure -
1417 normal_lines, normal_cols, new_total, new_normal, clone_number,
1418 splits, nest, prev_buffers, next_buffers.
1419 (WINDOW_TOTAL_SIZE): Move here from window.c.
1420 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1421
1422 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1423 Remove.
1424 (make_dummy_parent): Set new members of windows structure.
1425 (make_window): Move down in code. Handle new members of window
1426 structure.
1427 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1428 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1429 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1430 (Fset_window_prev_buffers, Fwindow_next_buffers)
1431 (Fset_window_next_buffers, Fset_window_clone_number): New
1432 functions.
1433 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1434 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1435 Doc-string fixes.
1436 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1437 Argument WINDOW can be now internal window too.
1438 (Fwindow_use_time): Move up in code.
1439 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1440 Rewrite doc-string.
1441 (Fset_window_configuration, saved_window)
1442 (Fcurrent_window_configuration, save_window_save): Handle new
1443 members of window structure.
1444 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1445 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1446 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1447 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1448 Qget_mru_window, Qresize_root_window,
1449 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1450 Qauto_buffer_name; staticpro them.
1451
1452 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1453
1454 * window.c (Fwindow_total_size, Fwindow_left_column)
1455 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1456 (Fwindow_list_1): New functions.
1457 (window_box_text_cols): Replace with window_body_cols.
1458 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1459 window_body_cols instead of window_box_text_cols.
1460 (delete_window, Fset_window_configuration): Call
1461 delete_all_subwindows with window as argument.
1462 (delete_all_subwindows): Take a window as argument and not a
1463 structure. Rewrite.
1464 (window_loop): Remove handling of GET_LRU_WINDOW and
1465 GET_LARGEST_WINDOW.
1466 (Fget_lru_window, Fget_largest_window): Move to window.el.
1467
1468 * window.h: Extern window_body_cols instead of
1469 window_box_text_cols. delete_all_subwindows now takes a
1470 Lisp_Object as argument.
1471
1472 * indent.c (compute_motion, Fcompute_motion): Use
1473 window_body_cols instead of window_box_text_cols.
1474
1475 * frame.c (delete_frame): Call delete_all_subwindows with root
1476 window as argument.
1477
1478 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1479
1480 * fns.c (Fputhash): Document return value.
1481
1482 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1483
1484 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1485
1486 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1487
1488 Cons<->int and similar integer overflow fixes (Bug#8794).
1489
1490 Check for overflow when converting integer to cons and back.
1491 * charset.c (Fdefine_charset_internal, Fdecode_char):
1492 Use cons_to_unsigned to catch overflow.
1493 (Fencode_char): Use INTEGER_TO_CONS.
1494 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1495 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1496 * data.c (long_to_cons, cons_to_long): Remove.
1497 (cons_to_unsigned, cons_to_signed): New functions.
1498 These signal an error for invalid or out-of-range values.
1499 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1500 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1501 * font.c (Ffont_variation_glyphs):
1502 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1503 * lisp.h: Include <intprops.h>.
1504 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1505 (cons_to_signed, cons_to_unsigned): New decls.
1506 (long_to_cons, cons_to_long): Remove decls.
1507 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1508 (Fprimitive_undo): Use CONS_TO_INTEGER.
1509 * xfns.c (Fx_window_property): Likewise.
1510 * xselect.c: Include <limits.h>.
1511 (x_own_selection, selection_data_to_lisp_data):
1512 Use INTEGER_TO_CONS.
1513 (x_handle_selection_request, x_handle_selection_clear)
1514 (x_get_foreign_selection, Fx_disown_selection_internal)
1515 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1516 (lisp_data_to_selection_data): Use cons_to_unsigned.
1517 (x_fill_property_data): Use cons_to_signed.
1518 Report values out of range.
1519
1520 Check for buffer and string overflow more precisely.
1521 * buffer.h (BUF_BYTES_MAX): New macro.
1522 * lisp.h (STRING_BYTES_MAX): New macro.
1523 * alloc.c (Fmake_string):
1524 * character.c (string_escape_byte8):
1525 * coding.c (coding_alloc_by_realloc):
1526 * doprnt.c (doprnt):
1527 * editfns.c (Fformat):
1528 * eval.c (verror):
1529 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1530 since they may not be the same number.
1531 * editfns.c (Finsert_char):
1532 * fileio.c (Finsert_file_contents):
1533 Likewise for BUF_BYTES_MAX.
1534
1535 * image.c: Use ptrdiff_t, not int, for sizes.
1536 (slurp_file): Switch from int to ptrdiff_t.
1537 All uses changed.
1538 (slurp_file): Check that file size fits in both size_t (for
1539 malloc) and ptrdiff_t (for sanity and safety).
1540
1541 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1542 if b->modtime has its maximal value.
1543
1544 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1545
1546 Don't assume time_t can fit into int.
1547 * buffer.h (struct buffer.modtime): Now time_t, not int.
1548 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1549 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1550
1551 Minor fixes for signed vs unsigned integers.
1552 * character.h (MAYBE_UNIFY_CHAR):
1553 * charset.c (maybe_unify_char):
1554 * keyboard.c (read_char, reorder_modifiers):
1555 XINT -> XFASTINT, since the integer must be nonnegative.
1556 * ftfont.c (ftfont_spec_pattern):
1557 * keymap.c (access_keymap, silly_event_symbol_error):
1558 XUINT -> XFASTINT, since the integer must be nonnegative.
1559 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1560 since it makes no difference and we prefer signed.
1561 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1562 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1563 nonnegative.
1564
1565 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1566
1567 * window.h (Fwindow_frame): Declare.
1568
1569 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1570
1571 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1572 (SPARE_MEMORY): Always define.
1573 (LARGE_REQUEST): Remove.
1574 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1575
1576 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1577
1578 * lisp.h: Move EXFUNS for Fframe_root_window,
1579 Fframe_first_window and Fset_frame_selected_window to window.h.
1580
1581 * window.h: Move EXFUNS for Fframe_root_window,
1582 Fframe_first_window and Fset_frame_selected_window here from
1583 lisp.h.
1584
1585 * frame.c (Fwindow_frame, Fframe_first_window)
1586 (Fframe_root_window, Fframe_selected_window)
1587 (Fset_frame_selected_window): Move to window.c.
1588 (Factive_minibuffer_window): Move to minibuf.c.
1589 (Fother_visible_frames_p): New function.
1590
1591 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1592
1593 * window.c (decode_window, decode_any_window): Move up in code.
1594 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1595 (inhibit_frame_unsplittable): Remove unused variable.
1596 (Fwindow_buffer): Move up and rewrite doc-string.
1597 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1598 (Fwindow_prev): New functions.
1599 (Fwindow_frame): Move here from frame.c. Accept any window as
1600 argument.
1601 (Fframe_root_window, Fframe_first_window)
1602 (Fframe_selected_window): Move here from frame.c. Accept frame
1603 or arbitrary window as argument. Update doc-strings.
1604 (Fminibuffer_window): Move up in code.
1605 (Fwindow_minibuffer_p): Move up in code and simplify.
1606 (Fset_frame_selected_window): Move here from frame.c.
1607 Marginal rewrite.
1608 (Fselected_window, select_window, Fselect_window): Move up in
1609 code. Minor doc-string fixes.
1610
1611 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1612
1613 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1614 Do not assume that spare memory exists; that assumption is valid
1615 only if SYSTEM_MALLOC.
1616 (LARGE_REQUEST): New macro, so that the issue of large requests
1617 is separated from the issue of spare memory.
1618
1619 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1620
1621 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1622 format. (Bug#8806)
1623
1624 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1625
1626 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1627 before statements.
1628
1629 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1630
1631 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1632
1633 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1634
1635 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1636 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1637
1638 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1639
1640 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1641
1642 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1643
1644 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1645 (x_clipboard_manager_save): Add return value.
1646 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1647 New error handlers.
1648 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1649 Obey Vx_select_enable_clipboard_manager. Catch errors in
1650 x_clipboard_manager_save (Bug#8779).
1651 (Vx_select_enable_clipboard_manager): New variable.
1652 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1653
1654 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1655
1656 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1657
1658 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1659
1660 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1661 in the current matrix if keep_current_p is non-zero.
1662
1663 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1664
1665 * bidi.c (bidi_level_of_next_char): Fix last change.
1666
1667 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1668
1669 Support bidi reordering of text covered by display properties.
1670
1671 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1672 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1673 (bidi_cache_search, bidi_cache_iterator_state)
1674 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1675 (bidi_level_of_next_char, bidi_move_to_visually_next):
1676 Support character positions inside a run of characters covered by a
1677 display string.
1678 (bidi_paragraph_init, bidi_resolve_explicit_1)
1679 (bidi_level_of_next_char): Call bidi_fetch_char and
1680 bidi_fetch_char_advance instead of FETCH_CHAR and
1681 FETCH_CHAR_ADVANCE.
1682 (bidi_init_it): Initialize new members.
1683 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1684 definitions.
1685 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1686 instead of using explicit *_CHAR codes.
1687 (bidi_resolve_explicit, bidi_resolve_weak):
1688 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1689 bidirectional text is supported only in multibyte buffers.
1690 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1691 it to initialize the frame_window_p member of struct bidi_it.
1692 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1693 (bidi_resolve_explicit, bidi_resolve_weak)
1694 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1695 bidi_it->nchars is non-positive.
1696 (bidi_level_of_next_char): Don't try to lookup the cache for the
1697 next/previous character if nothing is cached there yet, or if we
1698 were just reseat()'ed to a new position.
1699
1700 * xdisp.c (set_cursor_from_row): Set start and stop points
1701 according to the row's direction when priming the loop that looks
1702 for the glyph on which to display cursor.
1703 (single_display_spec_intangible_p): Function deleted.
1704 (display_prop_intangible_p): Reimplement to call
1705 handle_display_spec instead of single_display_spec_intangible_p.
1706 Accept 3 additional arguments needed by handle_display_spec.
1707 This fixes incorrect cursor motion across display property with complex
1708 values: lists, `(when COND...)' forms, etc.
1709 (single_display_spec_string_p): Support property values that are
1710 lists with the argument STRING its top-level element.
1711 (display_prop_string_p): Fix the condition for processing a
1712 property that is a list to be consistent with handle_display_spec.
1713 (handle_display_spec): New function, refactored from the
1714 last portion of handle_display_prop.
1715 (compute_display_string_pos): Accept additional argument
1716 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1717 value of a `display' property is a "replacing spec".
1718 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1719 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1720 the display property, but just return a value indicating whether
1721 the display property will replace the characters it covers.
1722 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1723 frame_window_p members of struct bidi_it.
1724 (compute_display_string_pos, compute_display_string_end):
1725 New functions.
1726 (push_it): Accept second argument POSITION, where pop_it should
1727 jump to continue iteration.
1728 (reseat_1): Initialize bidi_it.disp_pos.
1729
1730 * keyboard.c (adjust_point_for_property): Adjust the call to
1731 display_prop_intangible_p to its new signature.
1732
1733 * dispextern.h (struct bidi_it): New member frame_window_p.
1734 (bidi_init_it): Update prototypes.
1735 (display_prop_intangible_p): Update prototype.
1736 (compute_display_string_pos, compute_display_string_end):
1737 Declare prototypes.
1738 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1739 EMACS_INT.
1740
1741 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1742
1743 Malloc failure behavior now depends on size of allocation.
1744 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1745 * lisp.h: Change signatures accordingly.
1746 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1747 All callers changed. (Bug#8762)
1748
1749 * gnutls.c: Use Emacs's memory allocators.
1750 Without this change, the gnutls library would invoke malloc etc.
1751 directly, which causes problems on non-SYNC_INPUT hosts, and which
1752 runs afoul of improving memory_full behavior. (Bug#8761)
1753 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1754 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1755 xfree instead of the default malloc, realloc, free.
1756 (Fgnutls_boot): No need to check for memory allocation failure,
1757 since xmalloc does that for us.
1758
1759 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1760 * category.c (hash_get_category_set):
1761 * ccl.c (ccl_driver):
1762 * charset.c (Fdefine_charset_internal):
1763 * charset.h (struct charset.hash_index):
1764 * composite.c (get_composition_id, gstring_lookup_cache)
1765 (composition_gstring_put_cache):
1766 * composite.h (struct composition.hash_index):
1767 * dispextern.h (struct image.hash):
1768 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1769 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1770 (hashfn_equal, hashfn_user_defined, make_hash_table)
1771 (maybe_resize_hash_table, hash_lookup, hash_put)
1772 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1773 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1774 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1775 * image.c (make_image, search_image_cache, lookup_image)
1776 (xpm_put_color_table_h):
1777 * lisp.h (struct Lisp_Hash_Table):
1778 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1779 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1780 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1781 * alloc.c (allocate_vectorlike):
1782 Check for overflow in vector size calculations.
1783 * ccl.c (ccl_driver):
1784 Check for overflow when converting EMACS_INT to int.
1785 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1786 need to be updated by these changes.
1787 * fns.c (make_hash_table, maybe_resize_hash_table):
1788 Check for integer overflow with large hash tables.
1789 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1790 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1791 (SXHASH_REDUCE): New macro.
1792 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1793 Use it instead of discarding useful hash info with large hash values.
1794 (sxhash_float): New function.
1795 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1796 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1797 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1798 Rewrite to use FIXNUM_BITS, as this simplifies things.
1799 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1800 Adjust signatures to match updated version of code.
1801 (consing_since_gc): Now EMACS_INT, since a single hash table can
1802 use more than INT_MAX bytes.
1803
1804 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1805
1806 Make it possible to build with GCC-4.6+ -O2 -flto.
1807
1808 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1809
1810 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1811
1812 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1813 Call minibuffer-inactive-mode.
1814
1815 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1816
1817 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1818 Update dependencies.
1819
1820 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1821
1822 * data.c (init_data): Remove code for UTS, this system is not
1823 supported anymore.
1824
1825 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1826
1827 Don't force ./temacs to start in terminal mode.
1828
1829 * frame.c (make_initial_frame): Initialize faces in all cases, not
1830 only when CANNOT_DUMP is defined.
1831 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1832
1833 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1834
1835 * dispnew.c (add_window_display_history): Use const for the string
1836 pointer. Remove declaration, not needed.
1837
1838 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 Use 'inline', not 'INLINE'.
1841 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1842 * alloc.c, fontset.c (INLINE): Remove.
1843 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1844 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1845 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1846 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1847 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1848
1849 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1850
1851 Make it possible to run ./temacs.
1852
1853 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1854 syms_of_callproc does the same thing. Remove test for
1855 "initialized", do it in the caller.
1856 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1857
1858 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1859
1860 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1861 (read_minibuf): Use get_minibuffer.
1862 (syms_of_minibuf): Use DEFSYM.
1863 (Qmetadata): New var.
1864 * data.c (Qbuffer): Don't make it static.
1865 (syms_of_data): Use DEFSYM.
1866
1867 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1870 (CCL_CODE_MIN): New macro.
1871
1872 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1873
1874 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1875
1876 * eval.c (Qdebug): Now static.
1877 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1878 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1879 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1880
1881 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1882
1883 * image.c: Various fixes to ImageMagick code comments.
1884 (Fimagemagick_types): Doc fix.
1885
1886 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1887
1888 Minor fixes prompted by GCC 4.6.0 warnings.
1889
1890 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1891
1892 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1893 (x_clipboard_manager_save_all): Move extern decl to ...
1894 * xterm.h: ... here, so that it can be checked for consistency.
1895
1896 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1897
1898 * xselect.c (x_clipboard_manager_save_frame)
1899 (x_clipboard_manager_save_all): New functions.
1900 (Fx_clipboard_manager_save): Lisp function deleted.
1901
1902 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1903 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1904
1905 * xterm.h: Update prototype.
1906
1907 2011-05-28 William Xu <william.xwl@gmail.com>
1908
1909 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1910 exiting (Bug#8239).
1911
1912 2011-05-28 Jim Meyering <meyering@redhat.com>
1913
1914 Avoid a sign-extension bug in crypto_hash_function.
1915 * fns.c (to_uchar): Define.
1916 (crypto_hash_function): Use it to convert some newly-signed
1917 variables to unsigned, to avoid sign-extension bugs. For example,
1918 without this change, (md5 "truc") would evaluate to
1919 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1920 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1921 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1922
1923 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1924
1925 Integer overflow fixes.
1926
1927 * dbusbind.c: Serial number integer overflow fixes.
1928 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1929 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1930 to hold a serial number that is too large for a fixnum.
1931 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1932 Check for serial numbers out of range. Decode any serial number
1933 that was so large that it became a float. (Bug#8722)
1934
1935 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1936 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1937 Use XFASTINT rather than XUINT when numbers are nonnegative.
1938 (xd_append_arg, Fdbus_method_return_internal):
1939 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1940 arguments, check that Lisp number is nonnegative, rather than
1941 silently wrapping negative numbers around. (Bug#8722)
1942 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1943 (Bug#8722)
1944
1945 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1946
1947 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1948
1949 ccl: add integer overflow checks
1950 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1951 (IN_INT_RANGE): New macros.
1952 (ccl_driver): Use them to check for integer overflow when
1953 decoding a CCL program. Many of the new checks are whether XINT (x)
1954 fits in int; it doesn't always, on 64-bit hosts. The new version
1955 doesn't catch all possible integer overflows, but it's an
1956 improvement. (Bug#8719)
1957
1958 * alloc.c (make_event_array): Use XINT, not XUINT.
1959 There's no need for unsigned here.
1960
1961 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1962 This follows up to the 2011-05-06 change that substituted uintptr_t
1963 for EMACS_INT. This case wasn't caught back then.
1964
1965 Rework Fformat to avoid integer overflow issues.
1966 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1967 now (part of C89). Include <verify.h>.
1968 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1969 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1970 (Fformat): Avoid the prepass trying to compute sizes; it was only
1971 approximate and thus did not catch overflow reliably. Instead, walk
1972 through the format just once, formatting and computing sizes as we go,
1973 checking for integer overflow at every step, and allocating a larger
1974 buffer as needed. Keep track separately whether the format is
1975 multibyte. Keep only the most-recently calculated precision, rather
1976 than them all. Record whether each argument has been converted to
1977 string. Use EMACS_INT, not int, for byte and char and arg counts.
1978 Support field widths and precisions larger than INT_MAX. Avoid
1979 sprintf's undefined behavior with conversion specifications such as %#d
1980 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1981 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1982 formatting out-of-range floating point numbers with int
1983 formats. (Bug#8668)
1984
1985 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1986
1987 * data.c: Avoid integer truncation in expressions involving floats.
1988 * data.c: Include <intprops.h>.
1989 (arith_driver): When there's an integer overflow in an expression
1990 involving floating point, convert the integers to floating point
1991 so that the resulting value does not suffer from catastrophic
1992 integer truncation. For example, on a 64-bit host (* 4
1993 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1994 Do not rely on undefined behavior after integer overflow.
1995
1996 merge count_size_as_multibyte, parse_str_to_multibyte
1997 * character.c, character.h (count_size_as_multibyte):
1998 Rename from parse_str_to_multibyte; all uses changed.
1999 Check for integer overflow.
2000 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2001 since it's now a duplicate of the other. This is more of
2002 a character than a buffer op, so better that it's in character.c.
2003 * fns.c, print.c: Adjust to above changes.
2004
2005 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2006
2007 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2008
2009 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2012 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2013 (x_clipboard_manager_save): Now static.
2014 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2015
2016 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2017 (crypto_hash_function): Now static.
2018 Fix pointer signedness problems. Avoid unnecessary initializations.
2019
2020 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2021
2022 * termhooks.h (Vselection_alist): Make it terminal-local.
2023
2024 * terminal.c (create_terminal): Initialize it.
2025
2026 * xselect.c: Support for clipboard managers.
2027 (Vselection_alist): Move to termhooks.h as terminal-local var.
2028 (LOCAL_SELECTION): New macro.
2029 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2030 (symbol_to_x_atom): Remove gratuitous arg.
2031 (x_handle_selection_request, lisp_data_to_selection_data)
2032 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2033 (x_own_selection, x_get_local_selection, x_convert_selection):
2034 New arg, specifying work frame. Use terminal-local Vselection_alist.
2035 (some_frame_on_display): Delete unused function.
2036 (Fx_own_selection_internal, Fx_get_selection_internal)
2037 (Fx_disown_selection_internal, Fx_selection_owner_p)
2038 (Fx_selection_exists_p): New optional frame arg.
2039 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2040 (x_handle_selection_clear): Don't treat other terminals with the
2041 same keyboard specially. Use the terminal-local Vselection_alist.
2042 (x_clear_frame_selections): Use Frun_hook_with_args.
2043
2044 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2045
2046 * xterm.h: Add support for those atoms.
2047
2048 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2049
2050 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2051 (converted_selections, conversion_fail_tag): New global variables.
2052 (x_selection_request_lisp_error): Free the above.
2053 (x_get_local_selection): Remove unnecessary code.
2054 (x_reply_selection_request): Args changed; handle arbitrary array
2055 of converted selections stored in converted_selections.
2056 Separate the XChangeProperty and SelectionNotify steps.
2057 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2058 (x_convert_selection): New function.
2059 (x_handle_selection_event): Simplify.
2060 (x_get_foreign_selection): Don't ignore incoming requests while
2061 waiting for an answer; this will fail when we implement
2062 SAVE_TARGETS, and seems unnecessary anyway.
2063 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2064 (Vx_sent_selection_functions): Doc fix.
2065
2066 2011-05-26 Leo Liu <sdl.web@gmail.com>
2067
2068 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2069
2070 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2071
2072 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2073
2074 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2075 for fringe update if it has periodic bitmap.
2076 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2077 and fringe_bitmap_periodic_p.
2078
2079 * fringe.c (get_fringe_bitmap_data): New function.
2080 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2081 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2082 row. Mark glyph row for fringe update if periodicity changed.
2083
2084 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2085 for fringe update unless it has periodic bitmap.
2086
2087 2011-05-25 Kenichi Handa <handa@m17n.org>
2088
2089 * xdisp.c (get_next_display_element): Set correct it->face_id for
2090 a static composition.
2091
2092 2011-05-24 Leo Liu <sdl.web@gmail.com>
2093
2094 * deps.mk (fns.o):
2095 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2096
2097 * fns.c (crypto_hash_function, Fsha1): New function.
2098 (Fmd5): Use crypto_hash_function.
2099 (syms_of_fns): Add Ssha1.
2100
2101 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2102
2103 * gnutls.c: Remove unused macros.
2104 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2105 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2106 Remove macros that are defined and never used.
2107 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2108
2109 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2110
2111 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2112 (Fx_get_selection_internal): Minor cleanup.
2113 (Fx_own_selection_internal): Rename arguments for consistency with
2114 select.el.
2115
2116 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2117
2118 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2119
2120 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2121
2122 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2123
2124 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2125
2126 * dispnew.c (scrolling_window): Don't exclude the case that the
2127 last enabled row in the desired matrix touches the bottom boundary.
2128
2129 2011-05-21 Glenn Morris <rgm@gnu.org>
2130
2131 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2132 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2133 and add some more files.
2134
2135 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2136
2137 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2138 report_file_error introduced by the change from 2011-05-07.
2139
2140 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2141
2142 * systime.h (Time): Define only if emacs is defined.
2143 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2144 where the include path doesn't have X11/X.h by default. See
2145 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2146
2147 2011-05-20 Kenichi Handa <handa@m17n.org>
2148
2149 * composite.c (find_automatic_composition): Fix previous change.
2150
2151 2011-05-20 Glenn Morris <rgm@gnu.org>
2152
2153 * lisp.mk: New file, split from Makefile.in.
2154 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2155 (shortlisp): Remove.
2156 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2157
2158 2011-05-19 Glenn Morris <rgm@gnu.org>
2159
2160 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2161 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2162 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2163 (lisp): Set the order to that of loadup.el.
2164 (shortlisp): Make it a copy of $lisp.
2165 (SOME_MACHINE_LISP): Remove.
2166 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2167 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2168
2169 2011-05-18 Kenichi Handa <handa@m17n.org>
2170
2171 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2172 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2173 (find_automatic_composition): Mostly rewrite for efficiency.
2174
2175 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2176
2177 * makefile.w32-in: Update dependencies.
2178
2179 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2180
2181 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2182 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2183
2184 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 Fix some integer overflow issues, such as string length overflow.
2187
2188 * insdel.c (count_size_as_multibyte): Check for string overflow.
2189
2190 * character.c (lisp_string_width): Check for string overflow.
2191 Use EMACS_INT, not int, for string indexes and lengths; in
2192 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2193 the resulting string length overflows an EMACS_INT; instead,
2194 report a string overflow if no precision given. When checking for
2195 precision exhaustion, use a check that cannot possibly have
2196 integer overflow. (Bug#8675)
2197 * character.h (lisp_string_width): Adjust to new signature.
2198
2199 * alloc.c (string_overflow): New function.
2200 (Fmake_string): Use it. This doesn't change behavior, but saves
2201 a few bytes and will simplify future changes.
2202 * character.c (string_escape_byte8): Likewise.
2203 * lisp.h (string_overflow): New decl.
2204
2205 Fixups, following up to the user-interface timestamp change.
2206 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2207 for UI timestamps, instead of unsigned long.
2208 * msdos.c (mouse_get_pos): Likewise.
2209 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2210 * w32gui.h (Time): Define by including "systime.h" rather than by
2211 declaring it ourselves. (Bug#8664)
2212
2213 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2214 * image.c (clear_image_cache): Likewise.
2215
2216 * term.c (term_mouse_position): Don't assume time_t wraparound.
2217
2218 Be more systematic about user-interface timestamps.
2219 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2220 and sometimes 'EMACS_UINT', to represent these timestamps.
2221 This change causes it to use 'Time' uniformly, as that's what X uses.
2222 This makes the code easier to follow, and makes it easier to catch
2223 integer overflow bugs such as Bug#8664.
2224 * frame.c (Fmouse_position, Fmouse_pixel_position):
2225 Use Time, not unsigned long, for user-interface timestamps.
2226 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2227 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2228 * keyboard.h (last_event_timestamp): Likewise.
2229 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2230 * menu.h (xmenu_show): Likewise.
2231 * term.c (term_mouse_position): Likewise.
2232 * termhooks.h (struct input_event.timestamp): Likewise.
2233 (struct terminal.mouse_position_hook): Likewise.
2234 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2235 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2236 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2237 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2238 what it was before.
2239 * menu.h, termhooks.h: Include "systime.h", for Time.
2240
2241 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2242 Don't assume that the difference between two unsigned long values
2243 can fit into an integer. At this point, we know button_down_time
2244 <= event->timestamp, so the difference must be nonnegative, so
2245 there's no need to cast the result if double-click-time is
2246 nonnegative, as it should be; check that it's nonnegative, just in
2247 case. This bug is triggered when events are more than 2**31 ms
2248 apart (about 25 days). (Bug#8664)
2249
2250 * xselect.c (last_event_timestamp): Remove duplicate decl.
2251 (x_own_selection): Remove needless cast to unsigned long.
2252
2253 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2254 that always fit in int. Use a sentinel instead of a counter, to
2255 avoid a temp and to allay GCC's concerns about possible int overflow.
2256 * frame.h (struct frame): Use int for menu_bar_items_used
2257 instead of EMACS_INT, since it always fits in int.
2258
2259 * menu.c (grow_menu_items): Check for int overflow.
2260
2261 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2262
2263 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2264 Before, the code was not consistent. These values cannot exceed
2265 2**31 - 1 so there's no need to make them unsigned.
2266 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2267 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2268 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2269 as modifiers.
2270 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2271
2272 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2273 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2274 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2275 presumably because the widths might not match.
2276
2277 * window.c (size_window): Avoid needless test at loop start.
2278
2279 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2280
2281 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2282
2283 2011-05-12 Drew Adams <drew.adams@oracle.com>
2284
2285 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2286
2287 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2288
2289 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2290 `width' to `bar_area_x' and `bar_area_width', respectively.
2291 (x_scroll_run): Take account of fringe background extension.
2292
2293 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2294 Rename local vars `left' and `width' to `bar_area_x' and
2295 `bar_area_width', respectively.
2296 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2297 background extension.
2298
2299 2011-05-10 Jim Meyering <meyering@redhat.com>
2300
2301 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2302
2303 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2304
2305 * image.c (Finit_image_library): Return t for built-in image types,
2306 like pbm and xbm. (Bug#8640)
2307
2308 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2309
2310 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2311
2312 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2313
2314 * w32console.c (Fset_screen_color): Doc fix.
2315 (Fget_screen_color): New function.
2316 (syms_of_ntterm): Defsubr it.
2317
2318 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2319 unlink the temporary file if Fcall_process didn't create it in the
2320 first place.
2321 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2322 child process will be redirected to a file specified with `:file'.
2323 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2324 cue to call_process_cleanup not to close that handle.
2325
2326 2011-05-07 Ben Key <bkey76@gmail.com>
2327
2328 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2329 one of two shell specific rules, either bootstrap-temacs-CMD or
2330 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2331 to the previous implementation of the bootstrap-temacs rule.
2332 The bootstrap-temacs-CMD rule is similar to the previous
2333 implementation of the bootstrap-temacs rule except that it
2334 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2335 variable.
2336
2337 These changes, along with some changes to nt/configure.bat,
2338 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2339 earlier fix to add support for --cflags and --ldflags options
2340 that include quotes so that it works whether make uses cmd or
2341 sh as the shell.
2342
2343 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2344
2345 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2346 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2347 is a constant.
2348 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2349 a string. Handle both cases.
2350 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2351 (Fdbus_register_method): Use Qinvalid_function.
2352
2353 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2354
2355 * makefile.w32-in: Update dependencies.
2356 (LISP_H): Add inttypes.h and stdin.h.
2357 (PROCESS_H): Add unistd.h.
2358
2359 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2360
2361 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2362 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2363
2364 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2365
2366 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2367
2368 * term.c (vfatal): Remove stray call to va_end.
2369 It's not needed and the C Standard doesn't allow it here anyway.
2370
2371 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2372 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2373
2374 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2375 bytes.
2376
2377 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2378
2379 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2380
2381 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2382
2383 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2384
2385 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2386
2387 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2388 * charset.c (Fdefine_charset_internal): Don't initialize
2389 charset.code_space[15]. The value was garbage, on hosts with
2390 32-bit int (Bug#8600).
2391
2392 * lread.c (read_integer): Be more consistent with string-to-number.
2393 Use string_to_number to do the actual conversion; this avoids
2394 rounding errors and fixes some other screwups. Without this fix,
2395 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2396 (digit_to_number): Move earlier, for benefit of read_integer.
2397 Return -1 if the digit is out of range for the base, -2 if it is
2398 not a digit in any supported base. (Bug#8602)
2399
2400 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2401
2402 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2403 to match comment at start of function. This also removes a
2404 GCC warning about overflow in a 32+64-bit port.
2405
2406 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2407
2408 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2409 Reported by Stefan Monnier in
2410 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2411 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2412 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2413
2414 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2415 (EMACS_UINTPTR): Likewise, with uintptr_t.
2416
2417 * lisp.h: Prefer 64-bit EMACS_INT if available.
2418 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2419 on 32-bit hosts that have 64-bit int, so that they can access
2420 large files.
2421 However, temporarily disable this change unless the temporary
2422 symbol WIDE_EMACS_INT is defined.
2423
2424 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2425
2426 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2427 This removes an assumption that EMACS_INT and long are the same
2428 width as pointers. The assumption is true for Emacs porting targets
2429 now, but we want to make other targets possible.
2430 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2431 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2432 In the rest of the code, change types of integers that hold casted
2433 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2434 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2435 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2436 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2437 No need to cast type when ORing.
2438 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2439 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2440 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2441 assume EMACS_INT is the same width as char *.
2442 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2443 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2444 Remove no-longer-needed casts.
2445 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2446 (xg_tool_bar_help_callback, xg_make_tool_item):
2447 Use EMACS_INTPTR to hold an integer
2448 that will be cast to void *; this can avoid a GCC warning
2449 if EMACS_INT is not the same width as void *.
2450 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2451 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2452 (current_message_1, set_message_1):
2453 Use a local to convert to proper width without a cast.
2454 * xmenu.c (dialog_selection_callback): Likewise.
2455
2456 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2457 Also, don't assume VALBITS / RAND_BITS is less than 5,
2458 and don't rely on undefined behavior when shifting a 1 left into
2459 the sign bit.
2460 * lisp.h (get_random): Change signature to match.
2461
2462 * lread.c (hash_string): Use size_t, not int, for hash computation.
2463 Normally we prefer signed values; but hashing is special, because
2464 it's better to use unsigned division on hash table sizes so that
2465 the remainder is nonnegative. Also, size_t is the natural width
2466 for hashing into memory. The previous code used 'int', which doesn't
2467 retain enough info to hash well into very large tables.
2468 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2469
2470 * dbusbind.c: Don't possibly lose pointer info when converting.
2471 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2472 Use XPNTR rather than XHASH, so that the high-order bits of
2473 the pointer aren't lost when converting through void *.
2474
2475 * eval.c (Fautoload): Don't double-shift a pointer.
2476
2477 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2478
2479 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2480
2481 * gnutls.c (DEF_GNUTLS_FN):
2482 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2483
2484 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2485
2486 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2487 marker. (Bug#8610)
2488
2489 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2490
2491 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2492 New version that can reserve upto 2GB of heap space.
2493
2494 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2495
2496 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2497
2498 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2499
2500 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2501 `gnutls_certificate_set_x509_key_file'.
2502
2503 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2504
2505 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2506 Update dependencies.
2507
2508 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2509
2510 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2511 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2512 Remove unused parameter `fildes'.
2513 * process.c (read_process_output, send_process): Don't pass it.
2514
2515 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2516
2517 Fix previous change: the library cache is defined in w32.c.
2518 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2519 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2520
2521 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2522
2523 Implement dynamic loading of GnuTLS on Windows.
2524
2525 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2526 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2527 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2528 Declare.
2529
2530 * gnutls.c (Qgnutls_dll): Define.
2531 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2532 (gnutls_*): Declare function pointers.
2533 (init_gnutls_functions): New function to initialize function pointers.
2534 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2535 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2536 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2537 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2538 (emacs_gnutls_write, emacs_gnutls_read)
2539 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2540 (Fgnutls_available_p): New function.
2541 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2542 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2543 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2544
2545 * image.c: Include w32.h.
2546 (Vimage_type_cache): Delete.
2547 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2548 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2549 (w32_delayed_load): Move to w32.c.
2550
2551 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2552
2553 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2554 (w32_delayed_load): Move from image.c. When loading a library, record
2555 its filename in the :loaded-from property of the library id.
2556 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2557 Initialize and staticpro them.
2558 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2559
2560 * process.c: Include lisp.h before w32.h, not after.
2561 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2562 instead of gnutls_record_check_pending.
2563
2564 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2565
2566 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2567
2568 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2569 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2570 as passed in.
2571
2572 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2573
2574 * xterm.c (x_set_frame_alpha): Do not set property on anything
2575 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2576
2577 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2578
2579 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2580
2581 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2582
2583 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2584 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2585 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2586 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2587 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2588 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2589 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2590 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2591 (Qgnutls_bootprop_callbacks_verify): Make static.
2592
2593 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2594
2595 * callproc.c: Indentation fixup.
2596
2597 * sysdep.c (wait_for_termination_1): Make static.
2598 (wait_for_termination, interruptible_wait_for_termination):
2599 Move after wait_for_termination_1.
2600
2601 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2602
2603 * sysdep.c (interruptible_wait_for_termination): New function
2604 which is like wait_for_termination, but allows keyboard
2605 interruptions.
2606
2607 * callproc.c (Fcall_process): Add (:file "file") as an option for
2608 the STDOUT buffer.
2609 (Fcall_process_region): Ditto.
2610
2611 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2612
2613 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2614 rather than `XVECTOR (FOO)->size'.
2615
2616 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2617 inttypes.h, as a gnulib replacement is used if it not available in
2618 system headers.
2619
2620 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2621
2622 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2623 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2624 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2625
2626 * coding.c (coding_alloc_by_realloc): Error out if destination
2627 will grow beyond MOST_POSITIVE_FIXNUM.
2628 (decode_coding_emacs_mule): Abort if there isn't enough place in
2629 charbuf for the composition carryover bytes. Reserve an extra
2630 space for up to 2 characters produced in a loop.
2631 (decode_coding_iso_2022): Abort if there isn't enough place in
2632 charbuf for the composition carryover bytes.
2633
2634 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2635
2636 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2637 aborting when %lld or %lll format is passed.
2638 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2639 %llo or %llx format is passed. (Bug#8545)
2640
2641 * window.c (window_scroll_line_based): Use a marker instead of
2642 simple variables to record original value of point. (Bug#7952)
2643
2644 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2645 produced by %s or %c overflows available buffer space. (Bug#8545)
2646
2647 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2650 (SIZE_MAX): Move defn after all includes, as they might #define it.
2651
2652 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2653
2654 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2655
2656 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2657
2658 * keyboard.c (Qdelayed_warnings_hook): Define.
2659 (command_loop_1): Run `delayed-warnings-hook'
2660 if Vdelayed_warnings_list is non-nil.
2661 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2662 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2663
2664 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2665
2666 * doprnt.c (doprnt): Don't return value smaller than the buffer
2667 size if the message was truncated. (Bug#8545).
2668
2669 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2670
2671 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2672 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2673
2674 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2675
2676 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2677
2678 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2679
2680 * makefile.w32-in: Update dependencies.
2681
2682 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2683
2684 Improve `doprnt' and its usage. (Bug#8545)
2685 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2686 `format_end'. Remove support for %l as a conversion specifier.
2687 Don't use xrealloc. Improve diagnostics when the %l size modifier
2688 is used. Update the commentary.
2689
2690 * eval.c (verror): Simplify calculation of size_t.
2691
2692 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2693 messages.
2694
2695 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2696
2697 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2698 change.
2699
2700 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2701
2702 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2703 This makes this file independent of the recent pseudovector change.
2704
2705 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2706
2707 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2708
2709 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2710 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2711 Remove unused local.
2712 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2713
2714 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2715 GCC 4.6.0 optimizes based on type-based alias analysis.
2716 For example, if b is of type struct buffer * and v of type struct
2717 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2718 != &v->size, and therefore "v->size = 1; b->size = 2; return
2719 v->size;" must therefore return 1. This assumption is incorrect
2720 for Emacs, since it type-puns struct Lisp_Vector * with many other
2721 types. To fix this problem, this patch adds a new type struct
2722 vectorlike_header that documents the constraints on layout of vectors
2723 and pseudovectors, and helps optimizing compilers not get fooled
2724 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2725 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2726 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2727 the size member.
2728 (XSETPVECTYPE): Rewrite in terms of new macro.
2729 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2730 This is a bit clearer, and further avoids the possibility of
2731 undesirable aliasing.
2732 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2733 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2734 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2735 since Lisp_Subr is a special case (no "next" field).
2736 (ASIZE): Now uses header.size rather than size.
2737 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2738 to avoid the hassle of writing XVECTOR (foo)->header.size.
2739 (struct vectorlike_header): New type.
2740 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2741 object, to help avoid aliasing.
2742 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2743 (SUBRP): Likewise, since Lisp_Subr is a special case.
2744 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2745 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2746 (struct Lisp_Hash_Table): Combine first two members into a single
2747 struct vectorlike_header member. All uses of "size" and "next" members
2748 changed to be "header.size" and "header.next".
2749 * buffer.h (struct buffer): Likewise.
2750 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2751 * frame.h (struct frame): Likewise.
2752 * process.h (struct Lisp_Process): Likewise.
2753 * termhooks.h (struct terminal): Likewise.
2754 * window.c (struct save_window_data, struct saved_window): Likewise.
2755 * window.h (struct window): Likewise.
2756 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2757 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2758 * buffer.c (init_buffer_once): Likewise.
2759 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2760 special case.
2761 * process.c (Fformat_network_address): Use local var for size,
2762 for brevity.
2763
2764 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2765
2766 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2767 * data.c (atof): Remove decl; no longer used or needed.
2768 (digit_to_number): Move to lread.c.
2769 (Fstring_to_number): Use new string_to_number function, to be
2770 consistent with how the Lisp reader treats infinities and NaNs.
2771 Do not assume that floating-point numbers represent EMACS_INT
2772 without losing information; this is not true on most 64-bit hosts.
2773 Avoid double-rounding errors, by insisting on integers when
2774 parsing non-base-10 numbers, as the documentation specifies.
2775 * lisp.h (string_to_number): New decl, replacing ...
2776 (isfloat_string): Remove.
2777 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2778 (read1): Do not accept +. and -. as integers; this
2779 appears to have been a coding error. Similarly, do not accept
2780 strings like +-1e0 as floating point numbers. Do not report
2781 overflow for integer overflows unless the base is not 10 which
2782 means we have no simple and reliable way to continue.
2783 Break out the floating-point parsing into a new
2784 function string_to_number, so that Fstring_to_number parses
2785 floating point numbers consistently with the Lisp reader.
2786 (digit_to_number): Move here from data.c. Make it static inline.
2787 (E_CHAR, EXP_INT): Remove, replacing with ...
2788 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2789 (string_to_number): New function, replacing isfloat_string.
2790 This function checks for valid syntax and produces the resulting
2791 Lisp float number too. Rework it so that string-to-number
2792 no longer mishandles examples like "1.0e+". Use strtoumax,
2793 so that overflow for non-base-10 numbers is reported only when
2794 there's no portable and simple way to convert to floating point.
2795
2796 * textprop.c (set_text_properties_1): Rewrite for clarity,
2797 and to avoid GCC warning about integer overflow.
2798
2799 * intervals.h (struct interval): Use EMACS_INT for members
2800 where EMACS_UINT might cause problems. See
2801 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2802 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2803 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2804 All uses changed.
2805 (offset_intervals): Tell GCC not to worry about length overflow
2806 when negating a negative length.
2807
2808 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2809 (overrun_check_free): Likewise.
2810
2811 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2812 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2813 word size.
2814
2815 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2816 (gnutls_make_error): Rename local to avoid shadowing.
2817 (gnutls_emacs_global_deinit): ifdef out; not used.
2818 (Fgnutls_boot): Use const for pointer to readonly storage.
2819 Comment out unused local. Fix pointer signedness problems.
2820
2821 * lread.c (openp): Don't stuff size_t into an 'int'.
2822 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2823 about possible signed overflow.
2824
2825 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2826 (GDK_KEY_g): Don't define if already defined.
2827 (xg_prepare_tooltip): Avoid pointer signedness problem.
2828 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2829
2830 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2831 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2832
2833 * xfns.c (Fx_window_property): Simplify a bit,
2834 to make a bit faster and to avoid GCC 4.6.0 warning.
2835 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2836
2837 * fns.c (internal_equal): Don't assume size_t fits in int.
2838
2839 * alloc.c (compact_small_strings): Tighten assertion a little.
2840
2841 Replace pEd with more-general pI, and fix some printf arg casts.
2842 * lisp.h (pI): New macro, generalizing old pEd macro to other
2843 conversion specifiers. For example, use "...%"pI"d..." rather
2844 than "...%"pEd"...".
2845 (pEd): Remove. All uses replaced with similar uses of pI.
2846 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2847 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2848 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2849 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2850 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2851 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2852 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2853 64-bit hosts.
2854 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2855 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2856 * print.c (safe_debug_print, print_object): Likewise.
2857 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2858 to int.
2859 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2860 avoiding the 0 flag, which is not portable.
2861 * process.c (Fmake_network_process): Use pI to avoid cast.
2862 * region-cache.c (pp_cache): Likewise.
2863 * xdisp.c (decode_mode_spec): Likewise.
2864 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2865 behavior on 64-bit hosts with printf arg.
2866 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2867 (x_stop_queuing_selection_requests): Likewise.
2868 (x_get_window_property): Don't truncate byte count to an 'int'
2869 when tracing.
2870
2871 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2872 here, since it parses constructs like leading '-' and spaces,
2873 which are not wanted; and it overflows with large numbers.
2874 Instead, simply match F[0-9]+, which is what is wanted anyway.
2875
2876 * alloc.c: Remove unportable assumptions about struct layout.
2877 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2878 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2879 (allocate_vectorlike, make_pure_vector): Use the new macros,
2880 plus offsetof, to remove unportable assumptions about struct layout.
2881 These assumptions hold on all porting targets that I know of, but
2882 they are not guaranteed, they're easy to remove, and removing them
2883 makes further changes easier.
2884
2885 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2886 This doesn't fix a bug but makes the code clearer.
2887 (string_overrun_cookie): Now const. Use initializers that
2888 don't formally overflow signed char, to avoid warnings.
2889 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2890 can cause Emacs to crash when string overrun checking is enabled.
2891 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2892 multiple of sizeof (EMACS_INT); it need not be, if
2893 alignof(EMACS_INT) < sizeof (EMACS_INT).
2894 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2895
2896 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2897
2898 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2899
2900 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2901
2902 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2903 supposed to be handshaking. (Bug#8556)
2904 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2905
2906 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2907
2908 * lisp.h (Qdebug): List symbol.
2909 * eval.c (Qdebug): Restore global linkage.
2910 * keyboard.c (debug-on-event): New variable.
2911 (handle_user_signal): Break into debugger when debug-on-event
2912 matches the current signal symbol.
2913
2914 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2915
2916 * alloc.c (check_sblock, check_string_bytes)
2917 (check_string_free_list): Convert to standard C.
2918
2919 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2920
2921 * w32.c (emacs_gnutls_push): Fix typo.
2922
2923 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2924
2925 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2926 "cast to pointer from integer of different size".
2927
2928 Improve doprnt and its use in verror. (Bug#8545)
2929 * doprnt.c (doprnt): Document the set of format control sequences
2930 supported by the function. Use SAFE_ALLOCA instead of always
2931 using `alloca'.
2932
2933 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2934 is one byte too soon. Don't use xrealloc; instead xfree and
2935 xmalloc anew.
2936
2937 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2938
2939 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2940 callbacks stage.
2941
2942 * gnutls.c: Renamed global_initialized to
2943 gnutls_global_initialized. Added internals for the
2944 :verify-hostname-error, :verify-error, and :verify-flags
2945 parameters of `gnutls-boot' and documented those parameters in the
2946 docstring. Start callback support.
2947 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2948 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2949 on error. Return error code.
2950 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2951 (emacs_gnutls_read): Likewise.
2952 (Fgnutls_boot): Return handshake error code.
2953 (emacs_gnutls_handle_error): New function.
2954 (wsaerror_to_errno): Likewise.
2955
2956 * w32.h (emacs_gnutls_pull): Add prototype.
2957 (emacs_gnutls_push): Likewise.
2958
2959 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2960 (emacs_gnutls_push): Likewise.
2961
2962 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2963
2964 * process.c (wait_reading_process_output): Check if GnuTLS
2965 buffered some data internally if no FDs are set for TLS
2966 connections.
2967
2968 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2969 (LIBS): Link to USER_LIBS.
2970 ($(BLD)/gnutls.$(0)): New target.
2971
2972 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2973
2974 * xdisp.c (handle_single_display_spec): Rename the
2975 display_replaced_before_p argument into display_replaced_p, to
2976 make it consistent with the commentary. Fix typos in the
2977 commentary.
2978
2979 * textprop.c (syms_of_textprop): Remove dead code.
2980 (copy_text_properties): Delete obsolete commentary about an
2981 interface that was deleted long ago. Fix typos in the description
2982 of arguments.
2983
2984 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2985 to changes in oldXMenu/XMenu.h from 2011-04-16.
2986 <menu_help_message, prev_menu_help_message>: Constify.
2987 (IT_menu_make_room): menu->help_text is now `const char **';
2988 adjust.
2989
2990 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2991 to changes in oldXMenu/XMenu.h from 2011-04-16.
2992 (struct XMenu): Declare `help_text' `const char **'.
2993
2994 * xfaces.c <Qunspecified>: Make extern again.
2995
2996 * syntax.c: Include sys/types.h before including regex.h, as
2997 required by Posix.
2998
2999 * doc.c (get_doc_string): Improve the format passed to `error'.
3000
3001 * doprnt.c (doprnt): Improve commentary.
3002
3003 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3004
3005 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3006 them with etags.
3007
3008 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3009 changes in globals.h immediately force recompilation.
3010 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3011 $(CURDIR)/s/ms-w32.h.
3012 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3013
3014 * character.c (Fchar_direction): Function deleted.
3015 (syms_of_character): Don't defsubr it.
3016 <char-direction-table>: Deleted.
3017
3018 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3019
3020 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3021 * doprnt.c: Include limits.h.
3022 (SIZE_MAX): New macro.
3023 (doprnt): Return a size_t value. 2nd arg is now size_t.
3024 Many local variables are now size_t instead of int or unsigned.
3025 Improve overflow protection. Support `l' modifier for integer
3026 conversions. Support %l conversion. Don't assume an EMACS_INT
3027 argument for integer conversions and for %c.
3028
3029 * lisp.h (doprnt): Restore prototype.
3030
3031 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3032 $(SRC)/character.h.
3033
3034 * Makefile.in (base_obj): Add back doprnt.o.
3035
3036 * deps.mk (doprnt.o): Add back prerequisites.
3037 (callint.o): Depend on character.h.
3038
3039 * eval.c (internal_lisp_condition_case): Include the handler
3040 representation in the error message.
3041 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3042 when breaking from the loop.
3043
3044 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3045
3046 * callint.c (Fcall_interactively): When displaying error message
3047 about invalid control letter, pass the character's codepoint, not
3048 a pointer to its multibyte form. Improve display of the character
3049 in octal and display also its hex code.
3050
3051 * character.c (char_string): Use %x to display the (unsigned)
3052 codepoint of an invalid character, to avoid displaying a bogus
3053 negative value.
3054
3055 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3056 `error', not SYMBOL_NAME itself.
3057
3058 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3059 character arguments to `error'.
3060
3061 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3062 to `error' in error message about FINAL_CHAR argument. Make sure
3063 FINAL_CHAR is a character, and use %c when it is passed as
3064 argument to `error'.
3065
3066 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3067
3068 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3069
3070 * w32.c: Include <time.h>.
3071 (sys_localtime): New function.
3072
3073 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3074
3075 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3076
3077 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3078
3079 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3080
3081 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3082 zombies (Bug#8467).
3083
3084 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3085
3086 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3087 gl_state.e_property when gl_state.object is Qt.
3088
3089 * insdel.c (make_gap_larger): Remove limitation of buffer size
3090 to <= INT_MAX.
3091
3092 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3093
3094 * xdisp.c (lookup_glyphless_char_display)
3095 (produce_glyphless_glyph): Handle cons cell entry in
3096 glyphless-char-display.
3097 (Vglyphless_char_display): Document it.
3098
3099 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3100 glyphless-char-display.
3101
3102 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3103
3104 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3105
3106 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3107
3108 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3109 definition for no-X builds.
3110
3111 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3112
3113 Static checks with GCC 4.6.0 and non-default toolkits.
3114
3115 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3116
3117 * process.c (keyboard_bit_set): Define only if SIGIO.
3118 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3119 (send_process): Repair possible setjmp clobbering.
3120
3121 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3122
3123 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3124
3125 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3126
3127 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3128 Define only if needed.
3129
3130 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3131 by pacifying GCC about it. Maybe it's time to retire it?
3132 * xfaces.c (USG, __TIMEVAL__): Likewise.
3133
3134 * dispextern.h (struct redisplay_interface): Rename param
3135 to avoid shadowing.
3136 * termhooks.h (struct terminal): Likewise.
3137 * xterm.c (xembed_send_message): Likewise.
3138
3139 * insdel.c (make_gap_smaller): Define only if
3140 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3141
3142 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3143 it.
3144
3145 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3146 so that we aren't warned about unused symbols.
3147
3148 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3149
3150 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3151
3152 * xfns.c (x_real_positions): Mark locals as initialized.
3153
3154 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3155
3156 * xterm.c: Fix problems found by static analysis with other toolkits.
3157 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3158 (x_dispatch_event): Declare static if USE_GTK, and
3159 define if USE_GTK || USE_X_TOOLKIT.
3160 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3161 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3162 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3163 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3164
3165 * xmenu.c (menu_help_callback): Pointer type fixes.
3166 Use const pointers when pointing at readonly data. Avoid pointer
3167 signedness clashes.
3168 (FALSE): Remove unused macro.
3169 (update_frame_menubar): Remove unused decl.
3170
3171 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3172
3173 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3174 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3175 (single_menu_item): Rename local to avoid shadowing.
3176
3177 * keyboard.c (make_lispy_event): Remove unused local var.
3178
3179 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3180 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3181
3182 * bitmaps: Change bitmaps from unsigned char back to the X11
3183 compatible char. Avoid the old compiler warnings about
3184 out-of-range initializers by using, for example, '\xab' rather
3185 than 0xab.
3186
3187 * xgselect.c (xgselect_initialize): Check vs interface
3188 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3189
3190 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3191
3192 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3193 to read-only memory.
3194
3195 * fns.c (vector): Remove; this old hack is no longer needed.
3196
3197 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3198 Remove unused var.
3199 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3200
3201 * xrdb.c (x_load_resources): Omit unused local.
3202
3203 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3204 (x_window): Rename locals to avoid shadowing.
3205 (USG): Use the kludged USG macro, to pacify gcc.
3206
3207 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3208 (x_term_init): Remove local to avoid shadowing.
3209
3210 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3211
3212 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3213 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3214
3215 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3216
3217 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3218
3219 Fix regex.c, syntax.c and friends for buffers > 2GB.
3220 * syntax.h (struct gl_state_s): Declare character position members
3221 EMACS_INT.
3222
3223 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3224
3225 * textprop.c (verify_interval_modification, interval_of):
3226 Declare arguments EMACS_INT.
3227
3228 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3229 EMACS_INT.
3230
3231 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3232
3233 * indent.c (Fvertical_motion): Local variable it_start is now
3234 EMACS_INT.
3235
3236 * regex.c (re_match, re_match_2, re_match_2_internal)
3237 (bcmp_translate, regcomp, regexec, print_double_string)
3238 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3239 (re_compile_pattern, re_exec): Declare arguments and local
3240 variables `size_t' and `ssize_t' and return values `regoff_t', as
3241 appropriate.
3242 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3243 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3244 <compile_stack_type>: `size' and `avail' are now `size_t'.
3245
3246 * regex.h <regoff_t>: Use ssize_t, not int.
3247 (re_search, re_search_2, re_match, re_match_2): Arguments that
3248 specify buffer/string position and length are now ssize_t and
3249 size_t. Return type is regoff_t.
3250
3251 2011-04-16 Ben Key <bkey76@gmail.com>
3252
3253 * nsfont.m: Fixed bugs in ns_get_family and
3254 ns_descriptor_to_entity that were caused by using free to
3255 deallocate memory blocks that were allocated by xmalloc (via
3256 xstrdup). This caused Emacs to crash when compiled with
3257 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3258 --enable-checking=xmallocoverrun). xfree is now used to
3259 deallocate these memory blocks.
3260
3261 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3262
3263 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3264
3265 emacs_write: Accept and return EMACS_INT for sizes.
3266 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3267 et seq.
3268 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3269 Accept and return EMACS_INT.
3270 (emacs_gnutls_write): Return the number of bytes written on
3271 partial writes.
3272 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3273 (emacs_read, emacs_write): Remove check for negative size, as the
3274 Emacs source code has been audited now.
3275 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3276 (emacs_read, emacs_write): Use it.
3277 * process.c (send_process): Adjust to the new signatures of
3278 emacs_write and emacs_gnutls_write. Do not attempt to store
3279 a byte offset into an 'int'; it might overflow.
3280 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3281
3282 * sound.c: Don't assume sizes fit in 'int'.
3283 (struct sound_device.period_size, alsa_period_size):
3284 Return EMACS_INT, not int.
3285 (struct sound_device.write, vox_write, alsa_write):
3286 Accept EMACS_INT, not int.
3287 (wav_play, au_play): Use EMACS_INT to store sizes and to
3288 record read return values.
3289
3290 2011-04-15 Ben Key <bkey76@gmail.com>
3291
3292 * keyboard.c (Qundefined): Don't declare static since it is used
3293 in nsfns.m.
3294 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3295 static since they are used in nsfont.m.
3296
3297 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3298
3299 * process.c (Qprocessp): Don't declare static.
3300 * lisp.h (Qprocessp): Declare again.
3301
3302 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3303
3304 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3305
3306 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3307
3308 Improve C-level modularity by making more things 'static'.
3309
3310 Don't publish debugger-only interfaces to other modules.
3311 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3312 (verify_bytepos, count_markers): Move decls to the only modules
3313 that need them.
3314 * region-cache.h (pp_cache): Likewise.
3315 * window.h (check_all_windows): Likewise.
3316 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3317
3318 * sysdep.c (croak): Now static, if
3319 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3320 * syssignal.h (croak): Declare only if not static.
3321
3322 * alloc.c (refill_memory_reserve): Now static if
3323 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3324 * lisp.h (refill_memory_reserve): Declare only if not static.
3325
3326 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3327 Define only if USE_LUCID.
3328
3329 * xrdb.c (x_customization_string, x_rm_string): Now static.
3330
3331 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3332 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3333
3334 * xdisp.c (draw_row_with_mouse_face): Now static.
3335 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3336
3337 * window.h (check_all_windows): Mark externally visible.
3338
3339 * window.c (window_deletion_count): Now static.
3340
3341 * undo.c: Make symbols static if they're not exported.
3342 (last_undo_buffer, last_boundary_position, pending_boundary):
3343 Now static.
3344
3345 * textprop.c (interval_insert_behind_hooks): Now static.
3346 (interval_insert_in_front_hooks): Likewise.
3347
3348 * term.c: Make symbols static if they're not exported.
3349 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3350 (max_frame_lines, tty_set_terminal_modes):
3351 (tty_reset_terminal_modes, tty_turn_off_highlight):
3352 (get_tty_terminal): Now static.
3353 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3354 * termhooks.h (term_mouse_moveto): Do not declare if
3355 HAVE_WINDOW_SYSTEM.
3356 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3357 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3358
3359 * sysdep.c: Make symbols static if they're not exported.
3360 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3361 Now static.
3362 (sigprocmask_set, full_mask): Remove; unused.
3363 (wait_debugging): Mark as visible.
3364 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3365 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3366
3367 * syntax.c (syntax_temp): Define only if !__GNUC__.
3368
3369 * sound.c (current_sound_device, current_sound): Now static.
3370
3371 * search.c (searchbufs, searchbuf_head): Now static.
3372
3373 * scroll.c (scroll_cost): Remove; unused.
3374 * dispextern.h (scroll_cost): Remove decl.
3375
3376 * region-cache.h (pp_cache): Mark as externally visible.
3377
3378 * process.c: Make symbols static if they're not exported.
3379 (process_tick, update_tick, create_process, chan_process):
3380 (Vprocess_alist, proc_buffered_char, datagram_access):
3381 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3382 (deactivate_process): Mark defn as static, as well as decl.
3383 * lisp.h (create_process): Remove decl.
3384 * process.h (chan_process, Vprocess_alist): Remove decls.
3385
3386 * print.c: Make symbols static if they're not exported.
3387 (print_depth, new_backquote_output, being_printed, print_buffer):
3388 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3389 (print_interval, print_number_index, initial_stderr_stream):
3390 Now static.
3391 * lisp.h (Fprinc): Remove decl.
3392 (debug_output_compilation_hack): Mark as externally visible.
3393
3394 * sysdep.c (croak): Move decl from here to syssignal.h.
3395 * syssignal.h (croak): Put it here, so the API can be checked when
3396 'croak' is called from dissociate_if_controlling_tty.
3397
3398 * minibuf.c: Make symbols static if they're not exported.
3399 (minibuf_save_list, choose_minibuf_frame): Now static.
3400 * lisp.h (choose_minibuf_frame): Remove decl.
3401
3402 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3403
3404 * lread.c: Make symbols static if they're not exported.
3405 (read_objects, initial_obarray, oblookup_last_bucket_number):
3406 Now static.
3407 (make_symbol): Remove; unused.
3408 * lisp.h (initial_obarray, make_symbol): Remove decls.
3409
3410 * keyboard.c: Make symbols static if they're not exported.
3411 (single_kboard, recent_keys_index, total_keys, recent_keys):
3412 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3413 (this_single_command_key_start, echoing, last_auto_save):
3414 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3415 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3416 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3417 (Vlispy_mouse_stem, double_click_count):
3418 Now static.
3419 (force_auto_save_soon): Define only if SIGDANGER.
3420 (ignore_mouse_drag_p): Now static if
3421 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3422 (print_help): Remove; unused.
3423 (stop_character, last_timer_event): Mark as externally visible.
3424 * keyboard.h (ignore_mouse_drag_p): Declare only if
3425 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3426 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3427 * lisp.h (echoing): Remove decl.
3428 (force_auto_save_soon): Declare only if SIGDANGER.
3429 * xdisp.c (redisplay_window): Simplify code, to make it more
3430 obvious that ignore_mouse_drag_p is not accessed if !defined
3431 USE_GTK && !defined HAVE_NS.
3432
3433 * intervals.c: Make symbols static if they're not exported.
3434 (merge_properties_sticky, merge_interval_right, delete_interval):
3435 Now static.
3436 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3437
3438 * insdel.c: Make symbols static if they're not exported.
3439 However, leave prepare_to_modify_buffer alone. It's never
3440 called from outside this function, but that appears to be a bug.
3441 (combine_after_change_list, combine_after_change_buffer):
3442 (adjust_after_replace, signal_before_change): Now static.
3443 (adjust_after_replace_noundo): Remove; unused.
3444 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3445 (signal_before_change): Remove decls.
3446
3447 * indent.c (val_compute_motion, val_vmotion): Now static.
3448
3449 * image.c: Make symbols static if they're not exported.
3450 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3451 if USE_GTK.
3452 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3453 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3454
3455 * fringe.c (standard_bitmaps): Now static.
3456 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3457
3458 * frame.c: Make symbols static if they're not exported.
3459 (x_report_frame_params, make_terminal_frame): Now static.
3460 (get_frame_param): Now static, unless HAVE_NS.
3461 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3462 (x_get_resource_string): Remove; not used.
3463 * frame.h (make_terminal_frame, x_report_frame_params):
3464 (x_get_resource_string); Remove decls.
3465 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3466 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3467
3468 * font.c, fontset.c: Make symbols static if they're not exported.
3469 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3470 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3471 * font.c (font_close_object): Now static.
3472 * font.h (font_close_object): Remove.
3473 * fontset.c (FONTSET_OBJLIST): Remove.
3474 (free_realized_fontset) #if-0 the body, which does nothing.
3475 (face_suitable_for_char_p): #if-0, as it's never called.
3476 * fontset.h (face_suitable_for_char_p): Remove decl.
3477 * xfaces.c (face_at_string_position):
3478 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3479 since 0 is always ASCII.
3480
3481 * fns.c (weak_hash_tables): Now static.
3482
3483 * fileio.c: Make symbols static if they're not exported.
3484 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3485 (Vwrite_region_annotation_buffers): Now static.
3486
3487 * eval.c: Make symbols static if they're not exported.
3488 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3489 * lisp.h (backtrace_list): Remove decl.
3490
3491 * emacs.c: Make symbols static if they're not exported.
3492 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3493 (fatal_error_code, fatal_error_signal_hook, standard_args):
3494 Now static.
3495 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3496 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3497 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3498 * lisp.h (fatal_error_signal_hook): Remove decl.
3499 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3500
3501 * editfns.c: Move a (normally-unused) function to its only use.
3502 * editfns.c, lisp.h (get_operating_system_release): Remove.
3503 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3504 worth the hassle of breaking this out.
3505
3506 * xterm.c: Make symbols static if they're not exported.
3507 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3508 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3509 (x_destroy_window, x_delete_display):
3510 Now static.
3511 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3512 (x_mouse_leave): Remove; unused.
3513 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3514 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3515 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3516 Remove decls.
3517 (x_mouse_leave): Declare only if WINDOWSNT.
3518 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3519 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3520 USE_X_TOOLKIT.
3521
3522 * ftxfont.c: Make symbols static if they're not exported.
3523 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3524 HAVE_FREETYPE.
3525 * font.h (ftxfont_driver): Likewise.
3526
3527 * xfns.c: Make symbols static if they're not exported.
3528 (x_last_font_name, x_display_info_for_name):
3529 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3530 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3531 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3532 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3533 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3534 (last_show_tip_args): Now static.
3535 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3536 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3537 (x_screen_planes): Remove; unused.
3538 * dispextern.h (x_screen_planes): Remove decl.
3539
3540 * dispnew.c: Make symbols static if they're not exported.
3541 * dispextern.h (redraw_garbaged_frames, scrolling):
3542 (increment_row_positions): Remove.
3543 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3544 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3545 Now static.
3546 (redraw_garbaged_frames): Remove; unused.
3547
3548 * xfaces.c: Make symbols static if they're not exported.
3549 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3550 Remove decls.
3551 * xterm.h (defined_color): Remove decls.
3552 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3553 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3554 (menu_face_changed_default, defined_color, free_realized_face):
3555 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3556 (ascii_face_of_lisp_face): Remove; unused.
3557
3558 * xdisp.c: Make symbols static if they're not exported.
3559 * dispextern.h (scratch_glyph_row, window_box_edges):
3560 (glyph_to_pixel_coords, set_cursor_from_row):
3561 (get_next_display_element, set_iterator_to_next):
3562 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3563 (show_mouse_face): Remove decls
3564 * frame.h (message_buf_print): Likewise.
3565 * lisp.h (pop_message, set_message, check_point_in_composition):
3566 Likewise.
3567 * xterm.h (set_vertical_scroll_bar): Likewise.
3568 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3569 (message_buf_print, scratch_glyph_row, displayed_buffer):
3570 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3571 (get_next_display_element, show_mouse_face, window_box_edges):
3572 (frame_to_window_pixel_xy, check_point_in_composition):
3573 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3574 (glyph_to_pixel_coords): Remove; unused.
3575
3576 * dired.c (file_name_completion): Now static.
3577
3578 * dbusbind.c (xd_in_read_queued_messages): Now static.
3579
3580 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3581 * data.c (circular_list_error): Remove.
3582
3583 * commands.h (last_point_position, last_point_position_buffer):
3584 (last_point_position_window): Remove decls.
3585 * keyboard.c: Make these variables static.
3586
3587 * coding.h (coding, code_convert_region, encode_coding_gap):
3588 Remove decls.
3589 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3590 (iso_code_class, detect_coding, code_convert_region): Now static.
3591 (encode_coding_gap): Remove; unused.
3592
3593 * chartab.c (chartab_chars, chartab_bits): Now static.
3594
3595 * charset.h (charset_iso_8859_1): Remove decl.
3596 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3597 Now static.
3598
3599 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3600 * ccl.c (Vccl_program_table): Now static.
3601 (check_ccl_update): Remove; unused.
3602
3603 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3604 * category.h: ... from here.
3605 * category.c (check_category_table, set_category_set): Now static.
3606
3607 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3608 * lisp.h: Remove these decls.
3609
3610 * buffer.c (buffer_count): Remove unused var.
3611
3612 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3613 so that it's not optimized away.
3614 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3615 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3616 exported only to the debugger.
3617
3618 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3619 * atimer.h (run_all_atimers): Remove; not exported.
3620
3621 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3622 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3623 was inaccessible from Lisp.
3624 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3625 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3626
3627 alloc.c: Import and export fewer symbols, and remove unused items.
3628 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3629 is defined.
3630 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3631 it's not optimized away by whole-program optimization.
3632 (message_enable_multibyte, free_misc): Remove.
3633 (catchlist, handlerlist, mark_backtrace):
3634 Declare only if BYTE_MARK_STACK.
3635 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3636 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3637 (message_enable_multibyte): Remove decl.
3638 (free_misc, interval_free_list, float_block, float_block_index):
3639 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3640 (cons_free_list, last_marked_index):
3641 Now static.
3642 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3643 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3644 (mark_backtrace): Define only if BYTE_MARK_STACK.
3645 * xdisp.c (message_enable_multibyte): Now static.
3646
3647 Declare Lisp_Object Q* variables to be 'static' if not exported.
3648 This makes it easier for human readers (and static analyzers)
3649 to see whether these variables are used from other modules.
3650 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3651 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3652 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3653 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3654 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3655 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3656 * xmenu.c, xselect.c:
3657 Declare Q* vars static if they are not used in other modules.
3658 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3659 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3660 Remove decls of unexported vars.
3661 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3662
3663 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3664
3665 Make Emacs functions such as Fatom 'static' by default.
3666 This makes it easier for human readers (and static analyzers)
3667 to see whether these functions can be called from other modules.
3668 DEFUN now defines a static function. To make the function external
3669 so that it can be used in other C modules, use the new macro DEFUE.
3670 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3671 (Finit_image_library):
3672 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3673 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3674 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3675 Remove decls, since these functions are now static.
3676 (Funintern, Fget_internal_run_time): New decls, since these functions
3677 were already external.
3678
3679 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3680 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3681 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3682 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3683 * keyboard.c, keymap.c, lread.c:
3684 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3685 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3686 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3687 Mark functions with DEFUE instead of DEFUN,
3688 if they are used in other modules.
3689 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3690 decls for now-static functions.
3691 * buffer.h (Fdelete_overlay): Remove decl.
3692 * callproc.c (Fgetenv_internal): Mark as internal.
3693 * composite.c (Fremove_list_of_text_properties): Remove decl.
3694 (Fcomposition_get_gstring): New forward static decl.
3695 * composite.h (Fcomposite_get_gstring): Remove decl.
3696 * dired.c (Ffile_attributes): New forward static decl.
3697 * doc.c (Fdocumntation_property): New forward static decl.
3698 * eval.c (Ffetch_bytecode): New forward static decl.
3699 (Funintern): Remove extern decl; now in .h file where it belongs.
3700 * fileio.c (Fmake_symbolic_link): New forward static decl.
3701 * image.c (Finit_image_library): New forward static decl.
3702 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3703 * intervals.h (Fprevious_property_change):
3704 (Fremove_list_of_text_properties): Remove decls.
3705 * keyboard.c (Fthis_command_keys): Remove decl.
3706 (Fcommand_execute): New forward static decl.
3707 * keymap.c (Flookup_key): New forward static decl.
3708 (Fcopy_keymap): Now static.
3709 * keymap.h (Flookup_key): Remove decl.
3710 * process.c (Fget_process): New forward static decl.
3711 (Fprocess_datagram_address): Mark as internal.
3712 * syntax.c (Fsyntax_table_p): New forward static decl.
3713 (skip_chars): Remove duplicate decl.
3714 * textprop.c (Fprevious_property_change): New forward static decl.
3715 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3716 Now internal.
3717 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3718 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3719
3720 * editfns.c (Fformat): Remove unreachable code.
3721
3722 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3723
3724 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3725 change. (Bug#8496)
3726
3727 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3728
3729 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3730 when at ZV. (Bug#8487)
3731
3732 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3733
3734 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3735 (Bug#8437)
3736 * keyboard.c (parse_tool_bar_item): Likewise.
3737 * sound.c (sound_cleanup, alsa_close): Likewise.
3738 * termcap.c (tgetent): Likewise.
3739 * xfns.c (x_default_font_parameter): Likewise.
3740 * xsettings.c (read_and_apply_settings): Likewise.
3741
3742 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3743 (overrun_check_free): Protoize.
3744
3745 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3746
3747 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3748 since callers should never pass a negative size.
3749 Change the signature to match that of plain 'read' and 'write'; see
3750 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3751 * lisp.h: Update prototypes of emacs_write and emacs_read.
3752
3753 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3754
3755 * xdisp.c (redisplay_window): Don't try to determine the character
3756 position of the scroll margin if the window start point w->startp
3757 is outside the buffer's accessible region. (Bug#8468)
3758
3759 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3760
3761 Fix write-region and its subroutines for buffers > 2GB.
3762 * fileio.c (a_write, e_write): Modify declaration of arguments and
3763 local variables to support buffers larger than 2GB.
3764 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3765
3766 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3767 argument, local variables, and return value.
3768
3769 * lisp.h: Update prototypes of emacs_write and emacs_read.
3770
3771 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3772
3773 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3774
3775 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3776
3777 Fix more problems found by GCC 4.6.0's static checks.
3778
3779 * xdisp.c (vmessage): Use a better test for character truncation.
3780
3781 * charset.c (load_charset_map): <, not <=, for optimization,
3782 and to avoid potential problems with integer overflow.
3783 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3784 * casetab.c (set_identity, shuffle): Likewise.
3785 * editfns.c (Fformat): Likewise.
3786 * syntax.c (skip_chars): Likewise.
3787
3788 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3789 This also lets GCC 4.6.0 generate slightly better loop code.
3790
3791 * callint.c (Fcall_interactively): <, not <=, for optimization.
3792 (Fcall_interactively): Count the number of arguments produced,
3793 not the number of arguments given. This is simpler and lets GCC
3794 4.6.0 generate slightly better code.
3795
3796 * ftfont.c: Distingish more carefully between FcChar8 and char.
3797 The previous code passed unsigned char * to a functions like
3798 strlen and xstrcasecmp that expect char *, which does not
3799 conform to the C standard.
3800 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3801 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3802 char * when the C standard requires it.
3803
3804 * keyboard.c (read_char): Remove unused var.
3805
3806 * eval.c: Port to Windows vsnprintf (Bug#8435).
3807 Include <limits.h>.
3808 (SIZE_MAX): Define if the headers do not.
3809 (verror): Do not give up if vsnprintf returns a negative count.
3810 Instead, grow the buffer. This ports to Windows vsnprintf, which
3811 does not conform to C99. Problem reported by Eli Zaretskii.
3812 Also, simplify the allocation scheme, by avoiding the need for
3813 calling realloc, and removing the ALLOCATED variable.
3814
3815 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3816
3817 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3818 But keep the doprint source code for now, as we might revamp it
3819 and use it again (Bug#8435).
3820 * lisp.h (doprnt): Remove.
3821 * Makefile.in (base_obj): Remove doprnt.o.
3822 * deps.mk (doprnt.o): Remove.
3823
3824 error: Print 32- and 64-bit integers portably (Bug#8435).
3825 Without this change, on typical 64-bit hosts error ("...%d...", N)
3826 was used to print both 32- and 64-bit integers N, which relied on
3827 undefined behavior.
3828 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3829 New macro.
3830 * lisp.h (error, verror): Mark as printf-like functions.
3831 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3832 Report overflow in size calculations when allocating printf buffer.
3833 Do not truncate output string at its first null byte.
3834 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3835 Truncate the output at a character boundary, since vsnprintf does not
3836 do that.
3837 * charset.c (check_iso_charset_parameter): Convert internal
3838 character to string before calling 'error', since %c now has the
3839 printf meaning.
3840 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3841 overflow when computing char to be passed to 'error'. Do not
3842 pass Lisp_Object to 'error'; pass the integer instead.
3843 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3844 formatted with plain %d.
3845
3846 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3847
3848 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3849
3850 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3851
3852 * xterm.c (x_catch_errors): Remove duplicate declaration.
3853
3854 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3855
3856 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3857
3858 2011-04-10 Jim Meyering <meyering@redhat.com>
3859
3860 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3861 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3862 return ssize_t not "int", and use size_t as the buffer length.
3863 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3864 * gnutls.h: Update declarations.
3865 * process.c (read_process_output): Use ssize_t, to match.
3866 (send_process): Likewise.
3867
3868 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3869
3870 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3871
3872 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3873
3874 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3875 Use unsigned char, to match FcChar8 type definition.
3876
3877 * xterm.c (handle_one_xevent):
3878 * xmenu.c (create_and_show_popup_menu):
3879 * xselect.c (x_decline_selection_request)
3880 (x_reply_selection_request): Avoid type-punned deref of X events.
3881
3882 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3883
3884 Fix some uses of `int' instead of EMACS_INT.
3885 * search.c (string_match_1, fast_string_match)
3886 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3887 (scan_buffer, find_next_newline_no_quit)
3888 (find_before_next_newline, search_command, Freplace_match)
3889 (Fmatch_data): Make some `int' variables be EMACS_INT.
3890
3891 * xdisp.c (display_count_lines): 3rd argument and return value now
3892 EMACS_INT. All callers changed.
3893 (pint2hrstr): Last argument is now EMACS_INT.
3894
3895 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3896 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3897 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3898 (decode_coding_utf_16, decode_coding_emacs_mule)
3899 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3900 (decode_coding_ccl, decode_coding_charset)
3901 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3902 (decode_coding_iso_2022, decode_coding_emacs_mule)
3903 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3904 <char_offset, last_offset>: Declare EMACS_INT.
3905 (encode_coding_utf_8, encode_coding_utf_16)
3906 (encode_coding_emacs_mule, encode_invocation_designation)
3907 (encode_designation_at_bol, encode_coding_iso_2022)
3908 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3909 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3910 Declare EMACS_INT.
3911 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3912 (encode_invocation_designation): Last argument P_NCHARS is now
3913 EMACS_INT.
3914 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3915 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3916
3917 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3918 All users changed.
3919
3920 * ccl.c (Fccl_execute_on_string): Declare some variables
3921 EMACS_INT.
3922
3923 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3924
3925 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3926
3927 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3928
3929 * process.c (Fformat_network_address): Doc fix.
3930
3931 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3932
3933 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3934
3935 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3936
3937 * keyboard.c (read_char): Call Lisp function help-form-show,
3938 instead of using internal_with_output_to_temp_buffer.
3939 (Qhelp_form_show): New var.
3940 (syms_of_keyboard): Use DEFSYM macro.
3941
3942 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3943
3944 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3945
3946 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3947
3948 * process.c (Flist_processes): Remove to Lisp.
3949 (list_processes_1): Delete.
3950
3951 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3952
3953 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3954
3955 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3956
3957 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3958
3959 Fix more problems found by GCC 4.6.0's static checks.
3960
3961 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3962
3963 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3964
3965 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3966
3967 * xdisp.c (vmessage): Mark as a printf-like function.
3968
3969 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3970
3971 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3972
3973 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3974 printf-like functions.
3975 (tiff_load): Add casts to remove these marks before passing them
3976 to system-supplied API.
3977
3978 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3979
3980 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3981 This avoids several warnings with gcc -Wstrict-overflow.
3982 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3983 directly, rather than having caller test rule sign. This avoids
3984 some unnecessary tests.
3985 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3986 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3987 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3988
3989 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3990 (xfont_open): Avoid unnecessary tests.
3991
3992 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3993
3994 * composite.h, composite.c (composition_gstring_put_cache):
3995 Use EMACS_INT, not int, for length.
3996
3997 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3998 breaking out part of COMPOSITION_DECODE_RULE.
3999 (COMPOSITION_DECODE_RULE): Use it.
4000 * composite.c (get_composition_id): Remove unused local vars,
4001 by using the new macro.
4002
4003 * textprop.c (set_text_properties_1): Change while to do-while,
4004 since the condition is always true at first.
4005
4006 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4007 (interval_deletion_adjustment): Return unsigned value.
4008 All uses changed.
4009
4010 * process.c (list_processes_1, create_pty, read_process_output):
4011 (exec_sentinel): Remove vars that were set but not used.
4012 (create_pty): Remove unnecessary "volatile"s.
4013 (Fnetwork_interface_info): Avoid possibility of int overflow.
4014 (read_process_output): Do adaptive read buffering even if carryover.
4015 (read_process_output): Simplify nbytes computation if buffered.
4016
4017 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4018
4019 * syntax.c (scan_words): Remove var that was set but not used.
4020 (update_syntax_table): Use unsigned instead of int.
4021
4022 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4023 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4024 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4025
4026 * print.c (print_error_message): Avoid int overflow.
4027
4028 * font.c (font_list_entities): Redo for clarity,
4029 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4030
4031 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4032 (font_score): Avoid potential overflow in diff calculation.
4033
4034 * fns.c (substring_both): Remove var that is set but not used.
4035 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4036
4037 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4038
4039 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4040 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4041 can always succeed if overflow has undefined behavior.
4042
4043 * search.c (boyer_moore, wordify): Remove vars set but not used.
4044 (wordify): Omit three unnecessary tests.
4045
4046 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4047 All callers changed. This avoids the need for an unused var.
4048
4049 * casefiddle.c (casify_region): Remove var that is set but not used.
4050
4051 * dired.c (file_name_completion): Remove var that is set but not used.
4052
4053 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4054
4055 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4056 (Finsert_file_contents): Remove unnecessary code checking fd.
4057
4058 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4059 Check for integer overflow on size calculations.
4060
4061 * buffer.c (Fprevious_overlay_change): Remove var that is set
4062 but not used.
4063
4064 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4065 Remove vars that are set but not used.
4066 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4067 (timer_check_2): Mark vars as initialized.
4068
4069 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4070
4071 * image.c (lookup_image): Remove var that is set but not used.
4072 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4073
4074 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4075 that are set but not used.
4076
4077 * xfns.c (make_invisible_cursor): Don't return garbage
4078 if XCreateBitmapFromData fails (Bug#8410).
4079
4080 * xselect.c (x_get_local_selection, x_handle_property_notify):
4081 Remove vars that are set but not used.
4082
4083 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4084 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4085
4086 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4087 Remove var that is set but not used.
4088 (scroll_bar_windows_size): Now size_t, not int.
4089 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4090 Check for overflow.
4091
4092 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4093 (map_tty_color) [!defined MSDOS]: Likewise.
4094
4095 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4096
4097 * coding.c: Remove vars that are set but not used.
4098 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4099 All callers changed.
4100 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4101 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4102 (decode_coding_charset): Remove vars that are set but not used.
4103
4104 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4105 that is set but not used.
4106
4107 * print.c (print_object): Remove var that is set but not used.
4108
4109 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4110 The gnulib version avoids calling malloc in the usual case,
4111 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4112 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4113 * filelock.c (current_lock_owner): Likewise.
4114 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4115 * sysdep.c: Include allocator.h, careadlinkat.h.
4116 (emacs_no_realloc_allocator): New static constant.
4117 (emacs_readlink): New function.
4118 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4119 ../lib/careadlinkat.h.
4120
4121 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4122
4123 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4124 first non-nil return value).
4125
4126 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4127
4128 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4129 if not defined (Bug#8403).
4130
4131 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4132
4133 * xdisp.c (display_count_lines): Remove parameter `start',
4134 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4135 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4136 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4137 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4138 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4139 and thereabouts. All callers changed.
4140 (get_per_char_metric): Remove parameter `f', unused since
4141 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4142
4143 2011-04-02 Jim Meyering <meyering@redhat.com>
4144
4145 do not dereference NULL upon failed strdup
4146 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4147 (ns_get_family): Likewise.
4148
4149 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4150
4151 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4152
4153 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4154
4155 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4156 later (Bug#8403).
4157
4158 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4159
4160 Add lexical binding.
4161
4162 * window.c (Ftemp_output_buffer_show): New fun.
4163 (Fsave_window_excursion):
4164 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4165
4166 * lread.c (lisp_file_lexically_bound_p): New function.
4167 (Fload): Bind Qlexical_binding.
4168 (readevalloop): Remove `evalfun' arg.
4169 Bind Qinternal_interpreter_environment.
4170 (Feval_buffer): Bind Qlexical_binding.
4171 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4172 Mark as dynamic.
4173 (syms_of_lread): Declare `lexical-binding'.
4174
4175 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4176
4177 * keyboard.c (eval_dyn): New fun.
4178 (menu_item_eval_property): Use it.
4179
4180 * image.c (parse_image_spec): Use Ffunctionp.
4181
4182 * fns.c (concat, mapcar1): Accept byte-code-functions.
4183
4184 * eval.c (Fsetq): Handle lexical vars.
4185 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4186 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4187 (FletX, Flet): Obey lexical binding.
4188 (Fcommandp): Handle closures.
4189 (Feval): New `lexical' arg.
4190 (eval_sub): New function extracted from Feval. Use it almost
4191 everywhere where Feval was used. Look up vars in lexical env.
4192 Handle closures.
4193 (Ffunctionp): Move from subr.el.
4194 (Ffuncall): Handle closures.
4195 (apply_lambda): Remove `eval_flags'.
4196 (funcall_lambda): Handle closures and new byte-code-functions.
4197 (Fspecial_variable_p): New function.
4198 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4199 but without exporting it to Lisp.
4200
4201 * doc.c (Fdocumentation, store_function_docstring):
4202 * data.c (Finteractive_form): Handle closures.
4203
4204 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4205 interactive spec.
4206
4207 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4208 New byte-codes.
4209 (exec_byte_code): New function extracted from Fbyte_code to handle new
4210 calling convention for byte-code-functions. Add new byte-codes.
4211
4212 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4213
4214 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4215
4216 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4217
4218 * xdisp.c (redisplay_internal): Fix prototype.
4219
4220 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4221
4222 * xdisp.c (SCROLL_LIMIT): New macro.
4223 (try_scrolling): Use it when setting scroll_limit.
4224 Limit scrolling to 100 screen lines.
4225 (redisplay_window): Even when falling back on "recentering",
4226 position point in the window according to scroll-conservatively,
4227 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4228
4229 (try_scrolling): When point is above the window, allow searching
4230 as far as scroll_max, or one screenful, to compute vertical
4231 distance from PT to the scroll margin position. This prevents
4232 try_scrolling from unnecessarily failing when
4233 scroll-conservatively is set to a value slightly larger than the
4234 window height. Clean up the case of PT below the margin at bottom
4235 of window: scroll_max can no longer be INT_MAX. When aggressive
4236 scrolling is in use, don't let point enter the opposite scroll
4237 margin as result of the scroll.
4238 (syms_of_xdisp) <scroll-conservatively>: Document the
4239 threshold of 100 lines for never-recentering scrolling.
4240
4241 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4242
4243 * dispextern.h (move_it_by_lines):
4244 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4245 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4246 (message_log_check_duplicate): Remove parameters `prev_bol' and
4247 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4248 (redisplay_internal): Remove parameter `preserve_echo_area',
4249 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4250
4251 * indent.c (Fvertical_motion):
4252 * window.c (window_scroll_pixel_based, Frecenter):
4253 Don't pass `need_y_p' to `move_it_by_lines'.
4254
4255 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4256
4257 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4258 steal a few bits to be more compact.
4259 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4260 Remove unneeded casts.
4261
4262 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4263
4264 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4265
4266 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4267 binding" message (bug#7967).
4268
4269 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4270
4271 Fix more problems found by GCC 4.6.0's static checks.
4272
4273 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4274 Remove unused local var.
4275
4276 * editfns.c (Fmessage_box): Remove unused local var.
4277
4278 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4279 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4280 Omit unused local vars.
4281 * window.c (shrink_windows): Omit unused local var.
4282 * menu.c (digest_single_submenu): Omit unused local var.
4283 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4284 Omit unused local var.
4285
4286 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4287 Don't assume string length fits in int.
4288 (keyremap_step, read_key_sequence): Use size_t for sizes.
4289 (read_key_sequence): Don't check last_real_key_start redundantly.
4290
4291 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4292 instead of alloca (Bug#8344).
4293
4294 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4295 (Fbacktrace_frame): Don't assume nframes fits in int.
4296
4297 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4298
4299 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4300 concerns.
4301
4302 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4303
4304 * cm.c (calccost): Turn while-do into do-while, for clarity.
4305
4306 * keyboard.c (syms_of_keyboard): Use the same style as later
4307 in this function when indexing through an array. This also
4308 works around GCC bug 48267.
4309
4310 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4311
4312 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4313
4314 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4315 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4316
4317 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4318 This avoids undefined behavior on integer overflow, and is a bit
4319 more convenient anyway since it is compared to a size_t variable.
4320
4321 Variadic C functions now count arguments with size_t, not int.
4322 This avoids an unnecessary limitation on 64-bit machines, which
4323 caused (substring ...) to crash on large vectors (Bug#8344).
4324 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4325 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4326 All variadic functions and their callers changed accordingly.
4327 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4328 * data.c (arith_driver, float_arith_driver): Likewise.
4329 * editfns.c (general_insert_function): Likewise.
4330 * eval.c (struct backtrace.nargs, interactive_p)
4331 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4332 (funcall_lambda, mark_backtrace): Likewise.
4333 * fns.c (concat): Likewise.
4334 * frame.c (x_set_frame_parameters): Likewise.
4335 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4336 0 if not found, not -1. All callers changed.
4337
4338 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4339 (stack_copy_size): Now size_t, not int.
4340 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4341
4342 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4343
4344 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4345 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4346 All callers changed.
4347
4348 * lisp.h (multibyte_char_to_unibyte):
4349 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4350 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4351 * character.h (CHAR_TO_BYTE8):
4352 * cmds.c (internal_self_insert):
4353 * editfns.c (general_insert_function):
4354 * keymap.c (push_key_description):
4355 * search.c (Freplace_match):
4356 * xdisp.c (message_dolog, set_message_1): All callers changed.
4357
4358 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4359
4360 * keyboard.c (safe_run_hook_funcall): New function.
4361 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4362 don't set the hook to nil, but remove the offending function instead.
4363 (Qcommand_hook_internal): Remove, unused.
4364 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4365 Vcommand_hook_internal.
4366
4367 * eval.c (enum run_hooks_condition): Remove.
4368 (funcall_nil, funcall_not): New functions.
4369 (run_hook_with_args): Call each function through a `funcall' argument.
4370 Remove `cond' argument, now redundant.
4371 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4372 (Frun_hook_with_args_until_failure): Adjust accordingly.
4373 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4374
4375 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4376
4377 * dispextern.h (string_buffer_position): Remove declaration.
4378
4379 * print.c (strout): Remove parameter `multibyte', unused since
4380 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4381
4382 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4383 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4384 All callers changed.
4385
4386 * w32.c (_wsa_errlist): Use braces for struct initializers.
4387
4388 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4389 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4390 All callers changed.
4391 (string_buffer_position): Likewise. Also, make static (it's never
4392 used outside xdisp.c).
4393 (cursor_row_p): Remove parameter `w', unused since
4394 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4395 (decode_mode_spec): Remove parameter `precision', introduced during
4396 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4397 All callers changed.
4398
4399 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4400
4401 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4402
4403 2011-03-27 Anders Lindgren <andlind@gmail.com>
4404
4405 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4406 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4407 (ns_update_auto_hide_menu_bar): New functions.
4408 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4409 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4410 ns_constrain_all_frames.
4411 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4412 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4413
4414 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4415
4416 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4417
4418 2011-03-27 Glenn Morris <rgm@gnu.org>
4419
4420 * syssignal.h: Replace RETSIGTYPE with void.
4421 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4422 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4423 Replace SIGTYPE with void everywhere.
4424 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4425 * s/template.h (SIGTYPE): Remove commented out definition.
4426
4427 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4428
4429 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4430 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4431
4432 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4433
4434 * w32.c (read_unc_volume): Use parameter `henum', instead of
4435 global variable `wget_enum_handle'.
4436
4437 * keymap.c (describe_vector): Remove parameters `indices' and
4438 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4439 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4440
4441 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4442
4443 * keyboard.c (timer_check): Remove parameter `do_it_now',
4444 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4445 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4446 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4447
4448 * keyboard.c (read_char):
4449 * w32menu.c (w32_menu_display_help):
4450 * xmenu.c (show_help_event, menu_help_callback):
4451 Adjust calls to `show_help_echo'.
4452
4453 * gtkutil.c (xg_maybe_add_timer):
4454 * keyboard.c (readable_events):
4455 * process.c (wait_reading_process_output):
4456 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4457
4458 * insdel.c (adjust_markers_gap_motion):
4459 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4460 (gap_left, gap_right): Don't call it.
4461
4462 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4463
4464 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4465 incurred during fontification.
4466
4467 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4468
4469 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4470 (DEFVAR_PER_BUFFER): Don't pass it.
4471
4472 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4473 (scrolling_window): Don't pass it.
4474
4475 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4476
4477 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4478
4479 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4480 and `suffix'.
4481 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4482 of variables specific to SELinux and computation of `encoded_absname'.
4483
4484 * image.c (XPutPixel): Remove unused variable `height'.
4485
4486 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4487
4488 * unexw32.c (get_section_info): Remove unused variable `section'.
4489
4490 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4491 (system_process_attributes): Remove unused variable `sess'.
4492 (sys_read): Remove unused variable `err'.
4493
4494 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4495 (w32_wnd_proc): Remove unused variable `isdead'.
4496 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4497 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4498 (x_create_tip_frame): Remove unused variable `tem'.
4499
4500 * w32inevt.c (w32_console_read_socket):
4501 Remove unused variable `no_events'.
4502
4503 * w32term.c (x_draw_composite_glyph_string_foreground):
4504 Remove unused variable `width'.
4505
4506 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4507
4508 * w32term.c (x_set_glyph_string_clipping):
4509 Don't pass uninitialized region to CombineRgn.
4510
4511 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4512
4513 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4514 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4515 (Fx_close_connection): Remove unused variable `i'.
4516
4517 * w32font.c (w32font_draw): Return number of glyphs.
4518 (w32font_open_internal): Remove unused variable `i'.
4519 (w32font_driver): Add missing initializer.
4520
4521 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4522 (fill_in_menu): Remove unused variable `items_added'.
4523
4524 * w32term.c (last_mouse_press_frame): Remove static global variable.
4525 (w32_clip_to_row): Remove unused variable `f'.
4526 (x_delete_terminal): Remove unused variable `i'.
4527
4528 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4529 (NOTHING): Remove unused static global variable.
4530 (uniscribe_check_otf): Remove unused variable `table'.
4531 (uniscribe_font_driver): Add missing initializers.
4532
4533 2011-03-23 Julien Danjou <julien@danjou.info>
4534
4535 * term.c (Fsuspend_tty, Fresume_tty):
4536 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4537 * window.c (temp_output_buffer_show):
4538 * insdel.c (signal_before_change):
4539 * frame.c (Fhandle_switch_frame):
4540 * fileio.c (Fdo_auto_save):
4541 * emacs.c (Fkill_emacs):
4542 * editfns.c (save_excursion_restore):
4543 * cmds.c (internal_self_insert):
4544 * callint.c (Fcall_interactively):
4545 * buffer.c (Fkill_all_local_variables):
4546 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4547 Use Frun_hooks.
4548 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4549 unconditionnaly since it does the check itself.
4550
4551 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4552
4553 Fix more problems found by GCC 4.5.2's static checks.
4554
4555 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4556 the first time through the loop, since we know p0 < p1 then.
4557 This also avoids a gcc -Wstrict-overflow warning.
4558
4559 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4560 leading to a memory leak, possible in functions like
4561 load_charset_map_from_file that can allocate an unbounded number
4562 of objects (Bug#8318).
4563
4564 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4565 that could (at least in theory) be that large.
4566
4567 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4568 This is less likely to overflow, and avoids undefined behavior if
4569 overflow does occur. All callers changed. Use strtoul to scan
4570 for the unsigned long integer.
4571 (pint2hrstr): Simplify and tune code slightly.
4572 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4573
4574 * scroll.c (do_scrolling): Work around GCC bug 48228.
4575 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4576
4577 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4578 This also avoids a warning with gcc -Wstrict-overflow.
4579 (validate_x_resource_name): Simplify count usage.
4580 This also avoids a warning with gcc -Wstrict-overflow.
4581
4582 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4583 fail (Bug#8306).
4584
4585 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4586
4587 * process.c (Fmake_network_process): Use socklen_t, not int,
4588 where POSIX says socklen_t is required in portable programs.
4589 This fixes a porting bug on hosts like 64-bit HP-UX, where
4590 socklen_t is wider than int (Bug#8277).
4591 (Fmake_network_process, server_accept_connection):
4592 (wait_reading_process_output, read_process_output):
4593 Likewise.
4594
4595 * process.c: Rename or move locals to avoid shadowing.
4596 (list_processes_1, Fmake_network_process):
4597 (read_process_output_error_handler, exec_sentinel_error_handler):
4598 Rename or move locals.
4599 (Fmake_network_process): Define label "retry_connect" only if needed.
4600 (Fnetwork_interface_info): Fix pointer signedness.
4601 (process_send_signal): Add cast to avoid pointer signedness problem.
4602 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4603 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4604
4605 Make tparam.h and terminfo.c consistent.
4606 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4607 Include tparam.h instead, since it declares them.
4608 * cm.h (PC): Remove extern decl; tparam.h now does this.
4609 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4610 * terminfo.c: Include tparam.h, to check interfaces.
4611 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4612 (tparam): Adjust signature to match interface in tparam.h;
4613 this removes some undefined behavior. Check that outstring and len
4614 are zero, which they always are with Emacs.
4615 * tparam.h (PC, BC, UP): New extern decls.
4616
4617 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4618 (xftfont_open): Rename locals to avoid shadowing.
4619
4620 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4621 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4622 (OTF_TAG_SYM): Omit macro if not needed.
4623 (ftfont_list): Remove unused local.
4624 (get_adstyle_property, ftfont_pattern_entity):
4625 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4626 Rename locals to avoid shadowing.
4627
4628 * xfont.c (xfont_list_family): Mark var as initialized.
4629
4630 * xml.c (make_dom): Now static.
4631
4632 * composite.c (composition_compute_stop_pos): Rename local to
4633 avoid shadowing.
4634 (composition_reseat_it): Remove unused locals.
4635 (find_automatic_composition, composition_adjust_point): Likewise.
4636 (composition_update_it): Mark var as initialized.
4637 (find_automatic_composition): Mark vars as initialized,
4638 with a FIXME (Bug#8290).
4639
4640 character.h: Rename locals to avoid shadowing.
4641 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4642 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4643 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4644 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4645 to avoid shadowing.
4646
4647 * textprop.c (property_change_between_p): Remove; unused.
4648
4649 * intervals.c (interval_start_pos): Now static.
4650
4651 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4652
4653 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4654 Rename locals to avoid shadowing.
4655
4656 * sound.c (wav_play, au_play, Fplay_sound_internal):
4657 Fix pointer signedness.
4658 (alsa_choose_format): Remove unused local var.
4659 (wav_play): Initialize a variable to 0, to prevent undefined
4660 behavior (Bug#8278).
4661
4662 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4663
4664 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4665
4666 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4667 clobbering (Bug#8298).
4668 * sysdep.c (sys_subshell): Likewise.
4669 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4670
4671 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4672 This should get cleaned up, so that child_setup has the
4673 same signature on all platforms.
4674
4675 * callproc.c (call_process_cleanup): Now static.
4676 (relocate_fd): Rename locals to avoid shadowing.
4677
4678 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4679
4680 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4681 not to be necessary, and produces flickering.
4682
4683 2011-03-20 Glenn Morris <rgm@gnu.org>
4684
4685 * config.in: Remove file.
4686
4687 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4688
4689 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4690 are now in src/globals.h.
4691 (syms_of_minibuf): Remove spurious & from previous change.
4692
4693 2011-03-20 Leo <sdl.web@gmail.com>
4694
4695 * minibuf.c (completing-read-function): New variable.
4696 (completing-read-default): Rename from completing-read.
4697 (completing-read): Call completing-read-function.
4698
4699 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4700
4701 * xfaces.c (Fx_load_color_file):
4702 Read color file from absolute filename (bug#8250).
4703
4704 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4705
4706 * makefile.w32-in: Update dependencies.
4707
4708 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4709
4710 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4711
4712 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4713
4714 Fix more problems found by GCC 4.5.2's static checks.
4715
4716 * process.c (make_serial_process_unwind, send_process_trap):
4717 (sigchld_handler): Now static.
4718
4719 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4720 That way, the code declares only the vars that it needs.
4721 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4722 * s/cygwin.h (PTY_ITERATION): Likewise.
4723 * s/darwin.h (PTY_ITERATION): Likewise.
4724 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4725
4726 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4727 * process.c (allocate_pty): Don't declare stb unless it's needed.
4728
4729 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4730 (CONSTANTLIM): Remove; unused.
4731 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4732 Define only if needed.
4733
4734 * unexelf.c (unexec): Name an expression,
4735 to avoid gcc -Wbad-function-cast warning.
4736 Use a different way to cause a compilation error if anyone uses
4737 n rather than nn, a way that does not involve shadowing.
4738 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4739
4740 * deps.mk (unexalpha.o): Remove; unused.
4741
4742 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4743 * unexec.h: New file.
4744 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4745 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4746 Depend on unexec.h.
4747 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4748 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4749 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4750 Change as necessary to match prototype in unexec.h.
4751
4752 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4753 shadowing.
4754 (back_comment, skip_chars): Mark vars as initialized.
4755
4756 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4757 Rename locals to avoid shadowing.
4758
4759 * lread.c (read1): Rewrite so as not to use empty "else".
4760 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4761
4762 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4763
4764 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4765 warning when compiling print.c.
4766
4767 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4768 instead of using an uninitialized var.
4769 (font_sort_entities): Mark var as initialized.
4770
4771 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4772
4773 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4774 pointers to constants.
4775 (font_parse_fcname): Remove unused vars.
4776 (font_delete_unmatched): Now static.
4777 (font_get_spec): Remove; unused.
4778 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4779 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4780 Rename or move locals to avoid shadowing.
4781
4782 * fns.c (require_nesting_list, require_unwind): Now static.
4783 (Ffillarray): Rename locals to avoid shadowing.
4784
4785 * floatfns.c (domain_error2): Define only if needed.
4786 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4787
4788 * alloc.c (mark_backtrace): Move decl from here ...
4789 * lisp.h: ... to here, so that it can be checked.
4790
4791 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4792 (Fdefvar): Rewrite so as not to use empty "else".
4793 (lisp_indirect_variable): Name an expression,
4794 to avoid gcc -Wbad-function-cast warning.
4795 (Fdefvar): Rename locals to avoid shadowing.
4796
4797 * callint.c (quotify_arg, quotify_args): Now static.
4798 (Fcall_interactively): Rename locals to avoid shadowing.
4799 Use const pointer when appropriate.
4800
4801 * lisp.h (get_system_name, get_operating_system_release):
4802 Move decls here, to check interfaces.
4803 * process.c (get_operating_system_release): Move decl to lisp.h.
4804 * xrdb.c (get_system_name): Likewise.
4805 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4806 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4807 some of which prompt warnings from gcc -Wbad-function-cast.
4808 (Fformat_time_string, Fencode_time, Finsert_char):
4809 (Ftranslate_region_internal, Fformat):
4810 Rename or remove local vars to avoid shadowing.
4811 (Ftranslate_region_internal): Mark var as initialized.
4812
4813 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4814 avoid shadowing.
4815
4816 * lisp.h (eassert): Check that the argument compiles, even if
4817 ENABLE_CHECKING is not defined.
4818
4819 * data.c (Findirect_variable): Name an expression, to avoid
4820 gcc -Wbad-function-cast warning.
4821 (default_value, arithcompare, arith_driver, arith_error): Now static.
4822 (store_symval_forwarding): Rename local to avoid shadowing.
4823 (Fmake_variable_buffer_local, Fmake_local_variable):
4824 Mark variables as initialized.
4825 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4826
4827 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4828 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4829 Rename locals to avoid shadowing.
4830 (mark_stack): Move local variables into the #ifdef region where
4831 they're used.
4832 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4833 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4834 needed otherwise.
4835 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4836 (GC_STRING_CHARS): Remove; not used.
4837 (Fmemory_limit): Cast sbrk's returned value to char *.
4838
4839 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4840 avoids undefined behavior in theory.
4841
4842 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4843
4844 Use functions, not macros, for up- and down-casing (Bug#8254).
4845 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4846 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4847 to use the following functions instead of these macros.
4848 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4849 EMACS_INT, since callers assume the returned value fits in int.
4850 (upcase1): Likewise, for UPCASE_TABLE.
4851 (uppercasep, lowercasep, upcase): New static inline functions.
4852 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4853 the race-condition problem in the old DOWNCASE.
4854
4855 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4856 Rename locals to avoid shadowing.
4857 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4858 (regex_compile, re_search_2, re_match_2_internal):
4859 Remove unused local vars.
4860 (FREE_VAR): Rewrite so as not to use empty "else",
4861 which gcc can warn about.
4862 (regex_compile, re_match_2_internal): Mark locals as initialized.
4863 (RETALLOC_IF): Define only if needed.
4864 (WORDCHAR_P): Likewise. This one is never needed, but is used
4865 only in a comment talking about a compiler bug, so put inside
4866 the #if 0 of that comment.
4867 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4868 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4869 Remove; unused.
4870
4871 * search.c (boyer_moore): Rename locals to avoid shadowing.
4872 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4873 (PREV_CHAR_BOUNDARY): Likewise.
4874
4875 * search.c (simple_search): Remove unused var.
4876
4877 * dired.c (compile_pattern): Move decl from here ...
4878 * lisp.h: ... to here, so that it can be checked.
4879 (struct re_registers): New forward decl.
4880
4881 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4882
4883 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4884 All uses changed.
4885 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4886 Rename locals to avoid shadowing.
4887 (Fvertical_motion): Mark locals as initialized.
4888
4889 * casefiddle.c (casify_object, casify_region): Now static.
4890 (casify_region): Mark local as initialized.
4891
4892 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4893
4894 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4895 New macros, so that the caller can use some names other than
4896 gcpro1, gcpro2, etc.
4897 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4898 of the new macros.
4899 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4900 argument, for consistency with GCPRO2_VAR, etc: it is now the
4901 prefix of the variable, not the variable itself. All uses
4902 changed.
4903 * dired.c (directory_files_internal, file_name_completion):
4904 Rename locals to avoid shadowing.
4905
4906 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4907 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4908 dired.c's scmp function, had undefined behavior.
4909 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4910 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4911 * buffer.h: ... to here, because these macros use current_buffer,
4912 and the new implementation with inline functions needs to have
4913 current_buffer in scope now, rather than later when the macros
4914 are used.
4915 (downcase, upcase1): New static inline functions.
4916 (DOWNCASE, UPCASE1): Reimplement using these functions.
4917 This avoids undefined behavior in expressions like
4918 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4919 from race conditions in accessing the global variables
4920 case_temp1 and case_temp2.
4921 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4922 * lisp.h (case_temp1, case_temp2): Remove their decls.
4923 * character.h (ASCII_CHAR_P): Move from here ...
4924 * lisp.h: ... to here, so that the inline functions mentioned
4925 above can use them.
4926
4927 * dired.c (directory_files_internal_unwind): Now static.
4928
4929 * fileio.c (file_name_as_directory, directory_file_name):
4930 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4931 Now static.
4932 (file_name_as_directory): Use const pointers when appropriate.
4933 (Fexpand_file_name): Likewise. In particular, newdir might
4934 point at constant storage, so make it a const pointer.
4935 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4936 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4937 signedness issues.
4938 (Fset_file_times, Finsert_file_contents, auto_save_error):
4939 Rename locals to avoid shadowing.
4940
4941 * minibuf.c (choose_minibuf_frame_1): Now static.
4942 (Ftry_completion, Fall_completions): Rename or remove locals
4943 to avoid shadowing.
4944
4945 * marker.c (bytepos_to_charpos): Remove; unused.
4946
4947 * lisp.h (verify_bytepos, count_markers): New decls,
4948 so that gcc does not warn that these functions aren't declared.
4949
4950 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4951 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4952 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4953 (copy_text): Remove unused local var.
4954
4955 * filelock.c (within_one_second): Now static.
4956 (lock_file_1): Rename local to avoid shadowing.
4957
4958 * buffer.c (fix_overlays_before): Mark locals as initialized.
4959 (fix_start_end_in_overlays): Likewise. This function should be
4960 simplified by using pointers-to-pointers, but that's a different
4961 matter.
4962 (switch_to_buffer_1): Now static.
4963 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4964 (report_overlay_modification): Rename locals to avoid shadowing.
4965
4966 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4967 Fix pointer signedness issue.
4968 (sys_subshell): Mark local as volatile if checking for lint,
4969 to suppress a gcc -Wclobbered warning that does not seem to be right.
4970 (MAXPATHLEN): Define only if needed.
4971
4972 * process.c (serial_open, serial_configure): Move decls from here ...
4973 * systty.h: ... to here, so that they can be checked.
4974
4975 * fns.c (get_random, seed_random): Move extern decls from here ...
4976 * lisp.h: ... to here, so that they can be checked.
4977
4978 * sysdep.c (reset_io): Now static.
4979 (wait_for_termination_signal): Remove; unused.
4980
4981 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4982 (copy_keymap_item, append_key, push_text_char_description):
4983 Now static.
4984 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4985 (DENSE_TABLE_SIZE): Remove; unused.
4986 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4987 (describe_map_tree):
4988 Rename locals to avoid shadowing.
4989
4990 * keyboard.c: Declare functions static if they are not used elsewhere.
4991 (echo_char, echo_dash, cmd_error, top_level_2):
4992 (poll_for_input, handle_async_input): Now static.
4993 (read_char, kbd_buffer_get_event, make_lispy_position):
4994 (make_lispy_event, make_lispy_movement, apply_modifiers):
4995 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4996 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4997 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4998 (read_key_sequence, read_char): Mark locals as initialized.
4999 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5000
5001 * keyboard.h (make_ctrl_char): New decl.
5002 (mark_kboards): Move decl here ...
5003 * alloc.c (mark_kboards): ... from here.
5004
5005 * lisp.h (force_auto_save_soon): New decl.
5006
5007 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5008 (DEFINE_DUMMY_FUNCTION): New macro.
5009 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5010 Use it.
5011 (main): Add casts to avoid warnings
5012 if GCC considers string literals to be constants.
5013
5014 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5015
5016 * dbusbind.c: Pointer signedness fixes.
5017 (xd_signature, xd_append_arg, xd_initialize):
5018 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5019 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5020 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5021 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5022
5023 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5024 if GCC considers string literals to be constants.
5025 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5026
5027 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5028
5029 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5030 (print_preprocess, print_object): New macro to fix last change.
5031
5032 * print.c (print_preprocess): Don't forget font objects.
5033
5034 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5035
5036 * emacs.c (USAGE3): Doc fixes.
5037
5038 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5039
5040 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5041 structure.
5042
5043 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5044
5045 * lisp.h (VWindow_system, Qfile_name_history):
5046 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5047 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5048 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5049
5050 * w32select.c: Don't #include "keyboard.h".
5051 (run_protected): Add extern declaration for waiting_for_input.
5052
5053 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5054 * w32console.c (detect_input_pending, read_input_pending)
5055 (encode_terminal_code):
5056 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5057 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5058 (w32_system_caret_y, Qfile_name_history):
5059 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5060 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5061 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5062 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5063 * w32proc.c (Qlocal, report_file_error):
5064 * w32term.c (Vwindow_system, updating_frame):
5065 * w32uniscribe.c (initialized, uniscribe_font_driver):
5066 Remove unneeded extern declarations.
5067
5068 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5069
5070 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5071
5072 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5073
5074 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5075 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5076 These macros can no longer be used for assignment.
5077
5078 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5079 Assign struct members directly, instead of using BUF_BEGV etc.
5080 (record_buffer_markers, fetch_buffer_markers): New functions for
5081 recording and fetching special buffer markers.
5082 (set_buffer_internal_1, set_buffer_temp): Use them.
5083
5084 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5085
5086 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5087
5088 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5089 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5090
5091 * xdisp.c (hscroll_window_tree):
5092 (reconsider_clip_changes): Use PT instead of BUF_PT.
5093
5094 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5095
5096 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5097 $(EMACS_ROOT)/lib/intprops.h.
5098
5099 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5100
5101 Fix more problems found by GCC 4.5.2's static checks.
5102
5103 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5104 to unsigned char * to avoid compiler diagnostic.
5105 (xg_free_frame_widgets): Make it clear that a local variable is
5106 needed only if USE_GTK_TOOLTIP.
5107 (gdk_window_get_screen): Make it clear that this macro is needed
5108 only if USE_GTK_TOOLTIP.
5109 (int_gtk_range_get_value): New function, which avoids a diagnostic
5110 from gcc -Wbad-function-cast.
5111 (xg_set_toolkit_scroll_bar_thumb): Use it.
5112 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5113 diagnostic from gcc -Wbad-function-cast.
5114 (get_utf8_string, xg_get_file_with_chooser):
5115 Rename locals to avoid shadowing.
5116 (create_dialog): Move locals to avoid shadowing.
5117
5118 * xgselect.c (xg_select): Remove unused var.
5119
5120 * image.c (four_corners_best): Mark locals as initialized.
5121 (gif_load): Initialize transparent_p to zero (Bug#8238).
5122 Mark another local as initialized.
5123 (my_png_error, my_error_exit): Mark with NO_RETURN.
5124
5125 * image.c (clear_image_cache): Now static.
5126 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5127 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5128 (x_edge_detection): Remove unnecessary cast that
5129 gcc -Wbad-function-cast diagnoses.
5130 (gif_load): Fix pointer signedness.
5131 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5132 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5133
5134 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5135
5136 Improve quality of tests for time stamp overflow.
5137 For example, without this patch (encode-time 0 0 0 1 1
5138 1152921504606846976) returns the obviously-bogus value (-948597
5139 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5140 reports time overflow. See
5141 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5142 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5143 * editfns.c: Include limits.h and intprops.h.
5144 (TIME_T_MIN, TIME_T_MAX): New macros.
5145 (time_overflow): Move earlier, to before first use.
5146 (hi_time, lo_time): New functions, for an accurate test for
5147 out-of-range times.
5148 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5149 (Fget_internal_run_time): Don't assume time_t fits in int.
5150 (make_time): Use list2 instead of Fcons twice.
5151 (Fdecode_time): More accurate test for out-of-range times.
5152 (check_tm_member): New function.
5153 (Fencode_time): Use it, to test for out-of-range times.
5154 (lisp_time_argument): Don't rely on undefined left-shift and
5155 right-shift behavior when checking for time stamp overflow.
5156
5157 * editfns.c (time_overflow): New function, refactoring common code.
5158 (Fformat_time_string, Fdecode_time, Fencode_time):
5159 (Fcurrent_time_string): Use it.
5160
5161 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5162 * dired.c (make_time): Move to ...
5163 * editfns.c (make_time): ... here.
5164 * systime.h: Note the move.
5165
5166 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5167
5168 * fringe.c (update_window_fringes): Remove unused variables.
5169
5170 * unexmacosx.c (copy_data_segment): Also copy __got section.
5171 (Bug#8223)
5172
5173 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5174
5175 * termcap.c [MSDOS]: Include "msdos.h".
5176 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5177 Constify `char *' arguments and their references according to
5178 prototypes in tparam.h.
5179
5180 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5181
5182 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5183 Adapt all references accordingly.
5184
5185 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5186
5187 2011-03-11 Tom Tromey <tromey@redhat.com>
5188
5189 * buffer.c (syms_of_buffer): Remove obsolete comment.
5190
5191 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5192
5193 * termhooks.h (encode_terminal_code): Declare prototype.
5194
5195 * msdos.c (encode_terminal_code): Don't declare prototype.
5196
5197 * term.c (encode_terminal_code): Now external again, used by
5198 w32console.c and msdos.c.
5199
5200 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5201 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5202
5203 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5204
5205 Fix some minor problems found by GCC 4.5.2's static checks.
5206
5207 * fringe.c (update_window_fringes): Mark locals as initialized
5208 (Bug#8227).
5209 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5210
5211 * alloc.c (mark_fringe_data): Move decl from here ...
5212 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5213 to check its interface.
5214 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5215
5216 * fontset.c (free_realized_fontset): Now static.
5217 (Fset_fontset_font): Rename local to avoid shadowing.
5218 (fontset_font): Mark local as initialized.
5219 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5220
5221 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5222
5223 * xselect.c (x_disown_buffer_selections): Remove; not used.
5224 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5225 (x_own_selection, Fx_disown_selection_internal): Rename locals
5226 to avoid shadowing.
5227 (x_handle_dnd_message): Remove local to avoid shadowing.
5228
5229 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5230 so that the caller can use some name other than gcpro1.
5231 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5232 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5233 (Fx_backspace_delete_keys_p):
5234 Use them to avoid shadowing, and rename vars to avoid shadowing.
5235 (x_decode_color, x_set_name, x_window): Now static.
5236 (Fx_create_frame): Add braces to silence GCC warning.
5237 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5238 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5239 Remove unused locals.
5240 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5241 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5242 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5243 macros.
5244
5245 * xterm.h (x_mouse_leave): New decl.
5246
5247 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5248 Remove unused functions.
5249 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5250 (x_calc_absolute_position): Now static.
5251 (XTread_socket): Don't define label "out" unless it's used.
5252 Don't declare local "event" unless it's used.
5253 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5254 unless they are used.
5255 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5256 (x_fatal_error_signal): Remove; not used.
5257 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5258 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5259 (x_error_catcher, x_connection_closed, x_error_handler):
5260 (x_error_quitter, xembed_send_message, x_iconify_frame):
5261 (my_log_handler): Rename locals to avoid shadowing.
5262 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5263 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5264
5265 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5266 Rename or move locals to avoid shadowing.
5267 (tty_defined_color, merge_face_heights): Now static.
5268 (free_realized_faces_for_fontset): Remove; not used.
5269 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5270 does not deduce is never used uninitialized.
5271 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5272 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5273
5274 * terminal.c (store_terminal_param): Now static.
5275
5276 * xmenu.c (menu_highlight_callback): Now static.
5277 (set_frame_menubar): Remove unused local.
5278 (xmenu_show): Rename parameter to avoid shadowing.
5279 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5280 since they might point to immutable storage.
5281 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5282 since it's unused otherwise.
5283
5284 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5285 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5286 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5287 avoids a gcc -Wuninitialized diagnostic.
5288 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5289 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5290 does not deduce are never used uninitialized.
5291
5292 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5293
5294 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5295 * window.c (window_loop, size_window):
5296 (run_window_configuration_change_hook, enlarge_window): Likewise.
5297
5298 * window.c (display_buffer): Now static.
5299 (size_window): Mark variables that gcc -Wuninitialized
5300 does not deduce are never used uninitialized.
5301 * window.h (check_all_windows): New decl, to forestall
5302 gcc -Wmissing-prototypes diagnostic.
5303 * dispextern.h (bidi_dump_cached_states): Likewise.
5304
5305 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5306 shadowing.
5307 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5308 Include <limits.h>.
5309 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5310 and to avoid gcc -Wuninitialized warning.
5311 (load_charset_map): Mark variables that gcc -Wuninitialized
5312 does not deduce are never used uninitialized.
5313 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5314
5315 * coding.c (coding_set_source, coding_set_destination):
5316 Use "else { /* comment */ }" rather than "else /* comment */;"
5317 for clarity, and to avoid gcc -Wempty-body warning.
5318 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5319 a block, when the outer 'i' will do.
5320 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5321 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5322 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5323 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5324 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5325 Rename locals to avoid shadowing.
5326 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5327 * coding.c (emacs_mule_char, encode_invocation_designation):
5328 Now static, since they're not used elsewhere.
5329 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5330 (decode_coding_object, encode_coding_object, detect_coding_system):
5331 (decode_coding_emacs_mule): Mark variables that gcc
5332 -Wuninitialized does not deduce are never used uninitialized.
5333 (detect_coding_iso_2022): Initialize a local variable that might
5334 be used uninitialized. Leave a FIXME because it's not clear that
5335 this initialization is needed. (Bug#8211)
5336 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5337 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5338 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5339 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5340 Remove unused macros.
5341
5342 * category.c (hash_get_category_set): Remove unused local var.
5343 (copy_category_table): Now static, since it's not used elsewhere.
5344 * character.c (string_count_byte8): Likewise.
5345
5346 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5347 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5348
5349 * chartab.c (copy_sub_char_table): Now static, since it's not used
5350 elsewhere.
5351 (sub_char_table_ref_and_range, char_table_ref_and_range):
5352 Rename locals to avoid shadowing.
5353 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5354
5355 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5356 (BIDI_BOB): Remove unused macro.
5357
5358 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5359 deduce are never used uninitialized.
5360 * term.c (encode_terminal_code): Likewise.
5361
5362 * term.c (encode_terminal_code): Now static. Remove unused local.
5363
5364 * tparam.h: New file.
5365 * term.c, tparam.h: Include it.
5366 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5367 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5368 Move these decls to tparam.h, and make them agree with what
5369 is actually in tparam.c. The previous trick of using incompatible
5370 decls in different modules does not conform to the C standard.
5371 All callers of tparam changed to use tparam's actual API.
5372 * tparam.c (tparam1, tparam, tgoto):
5373 Use const pointers where appropriate.
5374
5375 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5376 * cm.h (struct cm): Likewise.
5377 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5378 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5379 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5380 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5381 (turn_on_face, init_tty): Likewise.
5382 * termchar.h (struct tty_display_info): Likewise.
5383
5384 * term.c (term_mouse_position): Rename local to avoid shadowing.
5385
5386 * alloc.c (mark_ttys): Move decl from here ...
5387 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5388
5389 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5390
5391 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5392
5393 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5394
5395 * search.c (compile_pattern_1): Remove argument regp, unused since
5396 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5397 (compile_pattern): Don't pass it.
5398
5399 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5400
5401 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5402 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5403 for ! HAVE_GTK3.
5404 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5405
5406 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5407
5408 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5409 gdk_window_get_screen, gdk_window_get_geometry,
5410 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5411 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5412 (xg_get_pixbuf_from_pixmap): New function.
5413 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5414 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5415 Call xg_get_pixbuf_from_pixmap instead of
5416 gdk_pixbuf_get_from_drawable.
5417 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5418 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5419 (xg_check_special_colors): Use GtkStyleContext and its functions
5420 for HAVE_GTK3.
5421 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5422 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5423 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5424 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5425 Call gtk_widget_get_preferred_size.
5426 (xg_frame_resized): gdk_window_get_geometry only takes 5
5427 parameters.
5428 (xg_win_to_widget, xg_event_is_for_menubar):
5429 Call gdk_x11_window_lookup_for_display.
5430 (xg_set_widget_bg): New function.
5431 (delete_cb): New function.
5432 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5433 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5434 (xg_set_background_color): Call xg_set_widget_bg.
5435 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5436 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5437 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5438 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5439 if ! HAVE_GTK3.
5440 (update_frame_tool_bar): Call gtk_widget_hide.
5441 (xg_initialize): Use GDK_KEY_g.
5442
5443 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5444 if ! HAVE_GTK3
5445 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5446
5447 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5448 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5449 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5450
5451 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5452
5453 * w32xfns.c (select_palette): Check success of RealizePalette against
5454 GDI_ERROR, not zero.
5455
5456 See ChangeLog.11 for earlier changes.
5457
5458 ;; Local Variables:
5459 ;; coding: utf-8
5460 ;; End:
5461
5462 Copyright (C) 2011 Free Software Foundation, Inc.
5463
5464 This file is part of GNU Emacs.
5465
5466 GNU Emacs is free software: you can redistribute it and/or modify
5467 it under the terms of the GNU General Public License as published by
5468 the Free Software Foundation, either version 3 of the License, or
5469 (at your option) any later version.
5470
5471 GNU Emacs is distributed in the hope that it will be useful,
5472 but WITHOUT ANY WARRANTY; without even the implied warranty of
5473 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5474 GNU General Public License for more details.
5475
5476 You should have received a copy of the GNU General Public License
5477 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.