1 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7 Integer and memory overflow issues (Bug#9196).
9 * doc.c (get_doc_string): Rework so that
10 get_doc_string_buffer_size is the actual buffer size, rather than
11 being 1 less than the actual buffer size; this makes xpalloc more
14 * image.c (x_allocate_bitmap_record, cache_image):
15 * xselect.c (Fx_register_dnd_atom):
16 Simplify previous changes by using xpalloc.
18 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
19 since either will do and ptrdiff_t is convenient with xpalloc.
21 * charset.c (charset_table_size)
22 (struct charset_sort_data.priority): Now ptrdiff_t.
23 (charset_compare): Don't overflow if priorities differ greatly.
24 (Fsort_charsets): Don't assume list length fits in int.
25 Check for size-calculation overflow when allocating sort data.
26 (syms_of_charset): Allocate an initial charset table that is
27 just under 64 KiB, to avoid problems with glibc malloc and mmap.
29 * cmds.c (internal_self_insert): Check for size-calculation overflow.
31 * composite.h (struct composition.glyph_len): Now int, not unsigned.
32 The actual value is always <= INT_MAX, and leaving it unsigned made
33 overflow checking harder.
35 * dispextern.h (struct glyph_matrix.rows_allocated)
36 (struct face_cache.size): Now ptrdiff_t, for convenience in use
37 with xpalloc. The values are still always <= INT_MAX.
39 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
41 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
42 (SAFE_NALLOCA): New macro.
44 * region-cache.c (struct boundary.pos, find_cache_boundary)
45 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
46 (set_cache_region, invalidate_region_cache)
47 (revalidate_region_cache, know_region_cache, region_cache_forward)
48 (region_cache_backward, pp_cache):
49 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
50 so that ptrdiff_t * can be passed to xpalloc.
51 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
52 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
53 (pp_cache): Don't assume cache_len fits in int.
54 * region-cache.h: Adjust extern decls to match.
56 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
57 EMACS_INT, since either will do, for xpalloc.
59 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
60 (xnmalloc, xnrealloc, xpalloc): New functions.
62 * bidi.c (bidi_shelve_header_size): New constant.
63 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
64 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
66 * bidi.c (bidi_cache_shrink):
67 * buffer.c (overlays_at, overlays_in, record_overlay_string)
69 Don't update size of array until after memory allocation succeeds,
70 because xmalloc/xrealloc may not return.
71 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
72 now that we have proper integer overflow checking.
73 (record_overlay_string, overlay_strings): Catch overflows when
74 calculating size of overlay_str_buf.
76 * callproc.c (Fcall_process): Check for size overflow when
77 calculating size of args2.
78 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
79 Normally we prefer signed values, but sticking with ptrdiff_t would
80 require adding more-complicated checks.
82 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
83 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
84 Redo buffer-overflow calculations to avoid integer overflow.
85 Add a FIXME comment where memory seems to be over-allocated.
87 * character.c (Fstring): Check for size-calculation overflow.
89 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
90 unnecessary integer overflow. Check for size overflow.
91 (encode_coding_object): Don't update size until xmalloc succeeds.
93 * composite.c (get_composition_id): Check for overflow in glyph
96 Integer and memory overflow fixes for display code.
97 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
98 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
99 (scrolling_window): Check for overflow in size calculations.
100 (line_draw_cost, realloc_glyph_pool, add_row_entry):
101 Don't assume glyph table len fits in int.
102 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
103 (row_table_size): Now ptrdiff_t, not int.
104 (scrolling_window): Avoid overflow in size calculations.
105 Don't update size until allocation succeeds.
106 * fns.c (concat): Check for overflow in size calculations.
107 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
108 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
109 (NEXT_ALMOST_PRIME_LIMIT): New constant.
111 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
112 (get_doc_string): Check for size calculation overflow.
113 Don't update size until allocation succeeds.
114 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
115 EMACS_INT, where ptrdiff_t will do.
116 (Fsubstitute_command_keys): Check for string overflow.
118 * editfns.c (set_time_zone_rule): Don't assume environment length
120 (message_length): Now ptrdiff_t, not int.
121 (Fmessage_box): Don't update size until allocation succeeds.
122 Don't assume message length fits in int.
123 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
125 * emacs.c (main): Do not reallocate argv, since there is a null at
126 the end that can be overwritten, and this way there's no need to
127 worry about size-calculation overflow.
128 (sort_args): Check for size-calculation overflow.
130 * eval.c (init_eval_once, grow_specpdl): Don't update size until
132 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
134 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
135 (x_set_scroll_bar_width, x_figure_window_size):
136 Check for integer overflow.
137 (x_set_alpha): Do not assume XINT fits in int.
139 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
140 This is for the members text_lines, text_cols, total_lines, total_cols,
141 where the system imposes an 'int' limit.
143 * fringe.c (Fdefine_fringe_bitmap):
144 Don't update size until alloc works.
146 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
147 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
149 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
150 Check for size-calculation overflow.
151 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
152 do, as we prefer signed integers.
153 (id_to_widget.max_size, id_to_widget.used)
154 (xg_store_widget_in_map, xg_remove_widget_from_map)
155 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
156 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
157 Use and return ptrdiff_t, not int.
158 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
159 * gtkutil.h: Change prototypes to match the above.
161 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
162 are duplicate now that they've been promoted to lisp.h.
163 (x_allocate_bitmap_record, x_alloc_image_color)
164 (make_image_cache, cache_image, xpm_load):
165 Don't update size until alloc is done.
166 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
168 Check for size calculation overflow.
169 (ct_colors_allocated_max): New constant.
170 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
173 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
174 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
175 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
176 Use ptrdiff_t, not int, to count maps.
177 (read_char_minibuf_menu_prompt): Check for overflow in size
178 calculations. Don't update size until allocation succeeds. Redo
179 calculations to avoid overflow.
180 * keyboard.h: Change prototypes to match the above.
182 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
184 (current_minor_maps): Check for size calculation overflow.
185 * keymap.h: Change prototypes to match the above.
187 * lread.c (read1, init_obarray): Don't update size until alloc done.
189 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
190 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
192 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
193 Now ptrdiff_t, not int.
194 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
195 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
197 * process.c (Fnetwork_interface_list): Check for overflow
200 * region-cache.c (move_cache_gap): Check for size calculation overflow.
202 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
203 overflow. Don't bother calling xmalloc when xrealloc will do.
205 * search.c (Freplace_match): Check for size calculation overflow.
206 (Fset_match_data): Don't assume list lengths fit in 'int'.
208 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
209 for command line length. Do not attempt to address one before the
210 beginning of an array, as that's not portable.
212 * term.c (max_frame_lines): Remove; unused.
213 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
215 (encode_terminal_code, calculate_costs): Check for size
216 calculation overflow.
217 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
218 table lengths and related sizes. Don't update size until alloc
219 done. Redo calculations to avoid overflow.
220 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
222 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
223 subtracting pointers.
224 (gobble_line): Check for overflow more carefully. Don't update size
227 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
228 Don't update size until alloc done.
229 Redo size calculations to avoid overflow.
230 Check for size calculation overflow.
231 (main) [DEBUG]: Fix typo in invoking tparam1.
233 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
234 Use ptrdiff_t, not int, for sizes.
235 (store_mode_line_noprop_char): Don't update size until alloc done.
237 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
238 Use ptrdiff_t, not int, for sizes.
239 (Finternal_make_lisp_face, cache_face):
240 Check for size calculation overflow.
241 (cache_face): Treat size calculation overflows as if they were
242 memory exhaustion (the usual treatment), rather than aborting.
244 * xfns.c (x_encode_text, x_set_name_internal)
245 (Fx_change_window_property): Use ptrdiff_t, not int, to count
246 sizes, since they can exceed INT_MAX in size. Check for size
247 calculation overflow.
249 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
250 (xg_select): Check for size calculation overflow.
251 Don't update size until alloc done.
253 * xrdb.c (get_environ_db): Don't assume path length fits in int,
254 as sprintf is limited to int lengths.
256 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
257 (X_LONG_MIN): New macros.
258 Use them to make the following changes clearer.
259 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
260 This change doesn't affect the value now, but it may help remind
261 future maintainers not to raise the value too much later.
262 (SELECTION_QUANTUM): Remove, replacing with ...
263 (selection_quantum): ... new function, which avoids overflow.
265 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
266 assumption that selection length fits in 'int'.
267 (x_reply_selection_request, x_handle_selection_request)
268 (x_get_window_property, receive_incremental_selection)
269 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
270 (lisp_data_to_selection_data, clean_local_selection_data):
271 Use ptrdiff_t, not int, to record length of selection.
272 (x_reply_selection_request, x_get_window_property)
273 (receive_incremental_selection, x_property_data_to_lisp):
274 Redo calculations to avoid overflow.
275 (x_reply_selection_request): When sending hint, ceiling it at
276 X_LONG_MAX rather than relying on wraparound overflow to send
278 (x_get_window_property, receive_incremental_selection)
279 (lisp_data_to_selection_data, x_property_data_to_lisp):
280 Check for size-calculation overflow.
281 (x_get_window_property, receive_incremental_selection)
282 (lisp_data_to_selection_data, Fx_register_dnd_atom):
283 Don't store size until memory allocation succeeds.
284 (x_get_window_property): Plug memory leak on memory exhaustion.
285 Don't double-block input; malloc is safe here. Don't assume 2**34
286 - 4 fits in unsigned long. Add an xassert to check
287 XGetWindowProperty overflow. Be more careful about overflow
288 calculations, and distinguish size from memory overflow better.
289 (receive_incremental_selection): When tracing, don't assume
290 unsigned int is less than INT_MAX.
291 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
292 harmful) conversions of unsigned short to int.
293 (lisp_data_to_selection_data): Don't assume that integers
294 in the range -65535 through -1 fit in an X unsigned short.
295 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
296 result parameters unless successful. Rely on cons_to_unsigned
297 to report problems with elements; the old code wasn't right anyway.
298 (x_check_property_data): Check for int overflow; we cannot use
299 a wider type due to X limits.
300 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
302 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
304 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
305 (x_term_init): Check for size calculation overflow.
306 (x_color_cells): Don't store size until memory allocation succeeds.
307 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
308 Don't assume alloca size is less than MAX_ALLOCA.
309 (x_term_init): Don't assume length fits in int (sprintf is limited
312 Use ptrdiff_t for composition IDs.
313 * character.c (lisp_string_width):
314 * composite.c (composition_table_size, n_compositions)
315 (get_composition_id, composition_gstring_from_id):
316 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
317 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
318 * window.c (Frecenter):
319 Use ptrdiff_t, not int, for composition IDs.
320 * composite.c (get_composition_id): Check for integer overflow.
321 * composite.h: Adjust prototypes to match the above changes.
323 Use ptrdiff_t for hash table indexes.
324 * category.c (hash_get_category_set):
325 * ccl.c (ccl_driver):
326 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
327 * coding.c (coding_system_charset_list, detect_coding_system):
328 * coding.h (struct coding_system.id):
329 * composite.c (get_composition_id, gstring_lookup_cache):
330 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
331 * image.c (xpm_get_color_table_h):
332 * lisp.h (hash_lookup, hash_put):
333 * minibuf.c (Ftest_completion):
334 Use ptrdiff_t for hash table indexes, not int (which is too
335 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
336 32-bit --with-wide-int hosts).
338 * charset.c (Fdefine_charset_internal): Check for integer overflow.
339 Add a FIXME comment about memory leaks.
340 (syms_of_charset): Don't assume xmalloc returns.
342 Don't assume that stated character widths fit in int.
343 * character.c (Fchar_width, c_string_width, lisp_string_width):
344 * character.h (CHAR_WIDTH):
345 * indent.c (MULTIBYTE_BYTES_WIDTH):
346 Use sanitize_char_width to avoid undefined and/or bad behavior
347 with outlandish widths.
348 * character.h (sanitize_tab_width): Renamed from sanitize_width,
349 now that we have two such functions. All uses changed.
350 (sanitize_char_width): New inline function.
352 Don't assume that tab-width fits in int.
353 * character.h (sanitize_width): New inline function.
354 (SANE_TAB_WIDTH): New macro.
355 (ASCII_CHAR_WIDTH): Use it.
356 * indent.c (sane_tab_width): Remove. All uses replaced by
357 SANE_TAB_WIDTH (current_buffer).
358 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
360 * fileio.c: Integer overflow issues with file modes.
361 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
363 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
364 Remove unreachable code.
365 (read_hex, load_charset_map_from_file): Check for integer overflow.
367 * xterm.c: don't go over XClientMessageEvent limit
368 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
369 (x_send_scroll_bar_event): Likewise. Check that the size does not
370 exceed limits imposed by XClientMessageEvent, as well as the usual
371 ptrdiff_t and size_t limits.
373 * keyboard.c: Overflow, signedness and related fixes.
374 (make_lispy_movement): Use same integer type in forward decl
375 that is used in the definition.
376 (read_key_sequence, keyremap_step):
377 Change bufsize argument back to int, undoing my 2011-03-30 change.
378 We prefer signed types, and int is wide enough here.
379 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
380 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
381 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
382 length, not size_t. Use ptrdiff_t for index, not int.
383 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
384 possibility of integer overflow.
386 Overflow, signedness and related fixes for images.
388 * dispextern.h (struct it.stack[0].u.image.image_id)
389 (struct_it.image_id, struct image.id, struct image_cache.size)
390 (struct image_cache.used, struct image_cache.ref_count):
391 * gtkutil.c (update_frame_tool_bar):
392 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
393 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
394 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
395 * nsmenu.m (update_frame_tool_bar):
396 * xdisp.c (calc_pixel_width_or_height):
397 * xfns.c (image_cache_refcount):
398 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
399 on typical 64-bit hosts.
401 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
402 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
403 Omit unnecessary casts to int.
404 (parse_image_spec): Check that integers fall into 'int' range
405 when the callers expect that.
406 (image_ascent): Redo ascent calculation to avoid int overflow.
407 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
408 (lookup_image): Remove unnecessary tests.
409 (xbm_image_p): Locals are now of int, not EMACS_INT,
410 since parse_image_check makes sure they fit into int.
411 (png_load, gif_load, svg_load_image):
412 Prefer int to unsigned where either will do.
413 (tiff_handler): New function, combining the cores of the
414 old tiff_error_handler and tiff_warning_handler. This
415 function is rewritten to use vsnprintf and thereby avoid
416 stack buffer overflows. It uses only the features of vsnprintf
417 that are common to both POSIX and native Microsoft.
418 (tiff_error_handler, tiff_warning_handler): Use it.
419 (tiff_load, gif_load, imagemagick_load_image):
420 Don't assume :index value fits in 'int'.
421 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
422 (imagemagick_load_image): Check that crop parameters fit into
423 the integer types that MagickCropImage accepts. Don't assume
424 Vimagemagick_render_type has a nonnegative value. Don't assume
425 size_t fits in 'long'.
426 (gs_load): Use printmax_t to print the widest integers possible.
427 Check for integer overflow when computing image height and width.
429 2011-08-26 Eli Zaretskii <eliz@gnu.org>
431 * xdisp.c (redisplay_window): Don't force window start if point
432 will be invisible in the resulting window. (Bug#9324)
434 2011-08-25 Eli Zaretskii <eliz@gnu.org>
436 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
437 the display spec is of the form `(space ...)'.
438 (handle_display_spec): Return the value returned by
439 handle_single_display_spec, not just 1 or zero.
440 (handle_single_display_spec): If the display spec is of the form
441 `(space ...)', and specifies display in the text area, return 2
443 (try_cursor_movement): Check for the need to scroll more
444 accurately, and prefer exact match for point under bidi. Don't
445 advance `row' beyond the last row of the window.
447 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
448 into disp_prop; all users changed.
450 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
451 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
452 for the text covered by the display property.
454 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
456 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
457 Change return value to nil.
458 (Frecord_buffer): Delete unused function.
460 2011-08-24 Eli Zaretskii <eliz@gnu.org>
462 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
463 buffers, return left-to-right.
464 (set_cursor_from_row): Consider candidate row a win if its glyph
465 represents a newline and point is on that newline. Fixes cursor
466 positioning on the newline at EOL of R2L text within L2R
467 paragraph, and vice versa.
468 (try_cursor_movement): Check continued rows, in addition to
469 continuation rows. Fixes unwarranted scroll when point enters a
470 continued line of R2L text within an L2R paragraph, or vice versa.
471 (cursor_row_p): Consider the case of point being equal to
472 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
473 from the end of a short line to the beginning of a continued line
474 of R2L text within L2R paragraph.
475 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
478 * bidi.c (bidi_check_type): Use xassert.
479 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
482 2011-08-23 Eli Zaretskii <eliz@gnu.org>
484 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
487 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
489 * nsfont.m (ns_otf_to_script): Fix typo.
491 2011-08-22 Kenichi Handa <handa@m17n.org>
493 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
494 extra slot even if the purpose is char-code-property-table.
496 2011-08-23 Eli Zaretskii <eliz@gnu.org>
498 * xdisp.c (redisplay_window): When computing centering_position,
499 account for the height of the header line. (Bug#8874)
501 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
502 instead of CHAR_TO_BYTE. Fixes a crash when a completion
503 candidate is selected by the mouse, and that candidate has a
504 composed character under the mouse.
506 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
507 coordinates reported by pos-visible-in-window-p for a composed
508 character in column zero.
510 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
512 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
514 2011-08-22 Eli Zaretskii <eliz@gnu.org>
516 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
517 consider it a hit if to_charpos is anywhere in the range of the
518 composed buffer positions.
520 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
522 * image.c (gif_load): Don't assume that each subimage has the same
523 dimensions as the base image. Handle disposal method that is
524 "undefined" by the gif spec (Bug#9335).
526 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
528 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
529 (Fcondition_case): Document `debug' symbol in error handler.
531 2011-08-19 Eli Zaretskii <eliz@gnu.org>
533 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
534 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
535 from an Org mode buffer to a Speedbar frame.
537 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
538 a composition, take its buffer position from IT->cmp_it.charpos.
539 Fixes cursor positioning at the beginning of a line that begins
540 with a composed character.
542 2011-08-18 Eli Zaretskii <eliz@gnu.org>
544 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
545 character bidirectional type, use STRONG_L instead. Fixes crashes
546 in a buffer produced by `describe-categories'.
548 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
549 members before the level stack, so they would be saved and
550 restored when copying iterator state. Fixes incorrect reordering
551 around TABs covered by display properties.
553 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
555 * process.c (Fnetwork_interface_list): Correctly determine buffer
558 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
560 * eval.c (internal_condition_case, internal_condition_case_1)
561 (internal_condition_case_2, internal_condition_case_n):
562 Remove unnecessary aborts (Bug#9081).
564 2011-08-17 Eli Zaretskii <eliz@gnu.org>
566 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
567 has no `load' handler, try opening the file locally. (Bug#9311)
569 2011-08-16 Ken Brown <kbrown@cornell.edu>
571 * gmalloc.c: Expand comment.
573 2011-08-16 Eli Zaretskii <eliz@gnu.org>
575 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
576 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
578 2011-08-16 Ken Brown <kbrown@cornell.edu>
580 Fix memory allocation problems in Cygwin build (Bug#9273).
582 * unexcw.c ( __malloc_initialized): Declare external variable.
583 (fixup_executable): Force the dumped emacs to reinitialize malloc.
585 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
587 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
589 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
591 [CYGWIN] (special_realloc): New function.
592 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
593 requests to realloc storage in the static heap.
595 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
597 * bidi.c (bidi_initialize): Remove unused local.
599 2011-08-15 Eli Zaretskii <eliz@gnu.org>
601 * biditype.h: File removed.
603 * bidimirror.h: File removed.
605 * deps.mk (bidi.o): Remove biditype.h and
608 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
611 * dispextern.h: Fix a typo in the comment to bidi_type_t.
613 * chartab.c: Improve commentary for the uniprop_table API.
615 * bidi.c (bidi_paragraph_init): Support zero value of
616 bidi_ignore_explicit_marks_for_paragraph_level.
617 (bidi_initialize): Use uniprop_table instead of including
618 biditype.h and bidimirror.h.
620 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
621 coordinates of the iterator when restoring from ppos_it.
624 2011-08-14 Kenichi Handa <handa@m17n.org>
626 * process.c (create_process): Call setup_process_coding_systems
627 after the pid of the process is set to -1 (Bug#8162).
629 2011-08-14 Eli Zaretskii <eliz@gnu.org>
631 * xdisp.c (move_it_in_display_line_to): Don't invoke
632 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
633 ppos_it. Fixes vertical cursor motion when line beginning is
634 covered by an image. (Bug#9296)
636 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
638 * nsterm.h (ns_run_ascript): Declare.
639 (NSAPP_DATA2_RUNASSCRIPT): Define.
641 * nsfns.m (as_script, as_result, as_status): New static variables.
642 (ns_run_ascript): New function.
643 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
644 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
645 the event loop. Get status from as_status (Bug#7276).
647 * nsterm.m (sendEvent): If event is NSApplicationDefined and
648 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
649 the event loop (Bug#7276).
651 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
653 * gnutls.c (QCgnutls_bootprop_priority)
654 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
655 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
656 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
657 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
658 (QCgnutls_bootprop_verify_hostname_error)
659 (QCgnutls_bootprop_callbacks_verify): Rename from
660 Qgnutls_bootprop_..., all uses changed.
662 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
665 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
667 * xfaces.c (Qframe_set_background_mode): Now static.
668 * dispextern.h (Qframe_set_background_mode): Remove decl.
670 * process.c (Fnetwork_interface_info): Declare local only if needed.
672 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
674 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
675 (Fnetwork_interface_list): Allocate in increments of bytes instead
676 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
677 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
679 (struct ifflag_def): notrailers is smart on OSX.
680 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
681 Get hardware address with getifaddrs if available.
683 2011-08-12 Eli Zaretskii <eliz@gnu.org>
685 * xdisp.c (iterate_out_of_display_property): xassert that
686 IT->position is set to within IT->object's boundaries. Break from
687 the loop as soon as EOB is reached; avoids infloops in redisplay
688 when IT->position is set up wrongly due to some bug.
689 Set IT->current to match the bidi iterator unconditionally.
690 (push_display_prop): Allow GET_FROM_STRING as IT->method on
691 entry. Force push_it to save on the stack the current
692 buffer/string position, to be restored by pop_it. Fix flags in
693 the iterator structure wrt the object coming from a display
694 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
695 properties. (Bug#9284)
697 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
699 * fontset.c (fontset_get_font_group): Add proper type checks.
702 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
704 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
705 and LC_VERSION_MIN_MACOSX.
706 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
707 (dump_it) [LC_FUNCTION_STARTS]: Use it.
709 2011-08-08 Eli Zaretskii <eliz@gnu.org>
711 * xdisp.c (forward_to_next_line_start): Allow to use the
712 no-display-properties-and-no-overlays under bidi display.
713 Set disp_pos in the bidi iterator to avoid searches for display
714 properties and overlays.
716 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
718 * editfns.c (Fset_time_zone_rule): Document relationship with the
721 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
722 the font entity extracted from the cache (Bug#8109).
724 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
726 * composite.c (autocmp_chars): Don't reset point. That is done by
727 restore_point_unwind (Bug#5984).
729 2011-08-07 Juri Linkov <juri@jurta.org>
731 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
732 to show the arg `TIME' instead of `TIMEVAL'.
734 2011-08-06 Eli Zaretskii <eliz@gnu.org>
736 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
737 display property strides EOL and includes a newline, as in
738 longlines-mode. (Bug#9254)
739 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
740 word-wrap under bidirectional display. (Bug#9224)
742 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
743 is non-zero, even if the data buffer is NULL. Fixes a crash in
744 vertical-motion with longlines-mode. (Bug#9254)
746 2011-08-05 Eli Zaretskii <eliz@gnu.org>
748 * bidi.c <bidi_cache_total_alloc>: Now static.
749 (bidi_initialize): Initialize bidi_cache_total_alloc.
751 * xdisp.c (display_line): Release buffer allocated for shelved bidi
754 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
755 amount allocated this far in `bidi_cache_total_alloc'.
756 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
757 non-zero, only free the data buffer without restoring the cache
758 contents. All callers changed.
760 * dispextern.h (bidi_unshelve_cache): Update prototype.
762 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
763 (move_it_in_display_line, move_it_to)
764 (move_it_vertically_backward, move_it_by_lines): Replace the call
765 to xfree to an equivalent call to bidi_unshelve_cache.
766 (move_it_in_display_line_to): Fix logic of returning
767 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
769 2011-08-05 Eli Zaretskii <eliz@gnu.org>
771 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
772 came from a string character with a `cursor' property. (Bug#9229)
774 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
776 * Makefile.in (LIB_PTHREAD): New variable.
777 (LIBES): Add LIB_PTHREAD (Bug#9216).
779 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
780 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
782 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
784 * regex.c (re_iswctype): Remove some redundant boolean
787 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
789 * xterm.c (x_find_topmost_parent): New function.
790 (x_set_frame_alpha): Find topmost parent window with
791 x_find_topmost_parent and set the property there also (bug#9181).
792 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
794 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
796 * callproc.c (Fcall_process): Avoid vfork clobbering
797 the local vars buffer, coding_systems, current_dir.
799 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
801 * keymap.c (Fmake_composed_keymap): Move to subr.el.
803 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
805 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
806 so that it is not optimized away.
808 * xdisp.c (compute_display_string_pos): Remove unused local.
810 2011-08-02 Eli Zaretskii <eliz@gnu.org>
812 Fix slow cursor motion and scrolling in large buffers with
813 selective display, like Org Mode buffers. (Bug#9218)
815 * dispextern.h (struct bidi_it): New member disp_prop_p.
817 * xdisp.c: Remove one-slot cache of display string positions.
818 (compute_display_string_pos): Accept an additional argument
819 DISP_PROP_P; callers changed. Scan at most 5K characters forward
820 for a display string or property. If found, set DISP_PROP_P
823 * bidi.c (bidi_fetch_char): Accept an additional argument
824 DISP_PROP_P, and pass it to compute_display_string_pos.
825 Only handle text covered by a display string if DISP_PROP_P is returned
826 non-zero. All callers of bidi_fetch_char changed.
828 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
830 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
832 2010-12-03 Don March <don@ohspite.net>
834 * keymap.c (Fdefine_key): Fix non-prefix key error message when
835 last character M-[char] is translated to ESC [char] (bug#7541).
837 2011-08-02 Kenichi Handa <handa@m17n.org>
839 * lisp.h (uniprop_table): Extern it.
841 * chartab.c (uniprop_table): Make it non-static.
843 2011-08-01 Eli Zaretskii <eliz@gnu.org>
845 * xdisp.c (forward_to_next_line_start): Accept additional argument
846 BIDI_IT_PREV, and store into it the state of the bidi iterator had
848 (reseat_at_next_visible_line_start): Use the bidi iterator state
849 returned by forward_to_next_line_start to restore the state of
850 it->bidi_it after backing up to previous newline. (Bug#9212)
852 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
854 * regex.c (re_comp): Protoize.
855 (re_exec): Fix return type.
856 (regexec): Fix type of `ret'. (Bug#9203)
858 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
860 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
861 This is needed if max-image-size is a floating-point number.
863 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
865 * print.c (print_object): Print empty symbol as ##.
867 * lread.c (read1): Read ## as empty symbol.
869 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
871 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
872 setting frame foreground color (Bug#9175).
873 (x_set_background_color): Likewise.
875 * nsmenu.m (-setText): Size tooltip dimensions precisely to
877 (EmacsTooltip -init): Remove bezels and add shadows to
880 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
881 or scroll bar (Bug#8470).
883 * nsfont.m (nsfont_open): Remove assignment to voffset and
884 unnecessary vars hshink, expand, hd, full_height, min_height.
885 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
887 * nsterm.h (nsfont_info): Remove voffset field.
889 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
891 Implement strike-through and overline on NextStep (Bug#8863).
893 * nsfont.m (nsfont_open): Use underline position provided by font,
894 instead of hard-coded value of 2.
895 (nsfont_draw): Call ns_draw_text_decoration instead.
897 * nsterm.h: Add declaration for ns_draw_text_decoration.
899 * nsterm.m (ns_draw_text_decoration): New function for drawing
900 underline, overline, and strike-through.
901 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
902 ns_draw_text_decoration. Change treatment of cursor drawing to
903 accomodate underlining, etc.
905 2011-07-28 Eli Zaretskii <eliz@gnu.org>
907 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
910 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
912 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
913 Without this fix, if a signal arrives just after memory fills up,
914 'malloc' might be invoked reentrantly.
916 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
917 In other words, assume that every image size is allowed, on non-X
918 hosts. This assumption is probably wrong, but it lets Emacs compile.
920 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
922 * regex.c (re_iswctype): Convert return values to boolean.
924 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
926 * xdisp.c (compute_display_string_pos): Don't use cached display
927 string position if the buffer had its restriction changed.
930 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
932 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
934 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
936 Integer signedness and overflow and related fixes. (Bug#9079)
938 * bidi.c: Integer size and overflow fixes.
939 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
940 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
941 (bidi_cache_find_level_change, bidi_cache_ensure_space)
942 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
943 (bidi_find_other_level_edge):
944 Use ptrdiff_t instead of EMACS_INT where either will do.
945 This works better on 32-bit hosts configured --with-wide-int.
946 (bidi_cache_ensure_space): Check for size-calculation overflow.
947 Use % rather than repeated addition, for better worst-case speed.
948 Don't set bidi_cache_size until after xrealloc returns, because it
950 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
951 (bidi_cache_ensure_space): Also check that the bidi cache size
952 does not exceed that of the largest Lisp string or buffer. See Eli
953 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
955 * alloc.c (__malloc_size_t): Remove.
956 All uses replaced by size_t. See Andreas Schwab's note
957 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
959 * image.c: Improve checking for integer overflow.
960 (check_image_size): Assume that f is nonnull, since
961 it is always nonnull in practice. This is one less thing to
962 worry about when checking for integer overflow later.
963 (x_check_image_size): New function, which checks for integer
964 overflow issues inside X.
965 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
966 This removes the need for a memory_full check.
967 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
968 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
969 (xbm_read_bitmap_data): Change locals back to 'int', since
970 their values must fit in 'int'.
971 (xpm_load_image, png_load, tiff_load):
972 Invoke x_create_x_image_and_pixmap earlier,
973 to avoid much needless work if the image is too large.
974 (tiff_load): Treat overly large images as if
975 x_create_x_image_and_pixmap failed, not as malloc failures.
976 (gs_load): Use x_check_image_size.
978 * gtkutil.c: Omit integer casts.
979 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
980 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
982 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
984 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
985 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
986 would wrongly return t on a 64-bit host.
988 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
989 The plain *_OVERFLOW macros run afoul of GCC bug 49705
990 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
991 and therefore cause GCC to emit a bogus diagnostic in some cases.
993 * image.c: Integer signedness and overflow and related fixes.
994 This is not an exhaustive set of fixes, but it's time to
995 record what I've got.
996 (lookup_pixel_color, check_image_size): Remove redundant decls.
997 (check_image_size): Don't assume that arbitrary EMACS_INT values
998 fit in 'int', or that arbitrary 'double' values fit in 'int'.
999 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1000 (tiff_load, imagemagick_load_image):
1001 Check for overflow in size calculations.
1002 (x_create_x_image_and_pixmap): Remove unnecessary test for
1003 xmalloc returning NULL; that can't happen.
1004 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1005 (xpm_color_bucket): Use better integer hashing function.
1006 (xpm_cache_color): Don't possibly over-allocate memory.
1007 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1008 (gif_memory_source):
1009 Use ptrdiff_t, not int or size_t, to record sizes.
1010 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1011 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1012 either works, as we prefer signed integers.
1013 (tiff_read_from_memory, tiff_write_from_memory):
1014 Return tsize_t, not size_t, since that's what the TIFF API wants.
1015 (tiff_read_from_memory): Don't fail simply because the read would
1016 go past EOF; instead, return a short read.
1017 (tiff_load): Omit no-longer-needed casts.
1018 (Fimagemagick_types): Don't assume size fits into 'int'.
1020 Improve hashing quality when configured --with-wide-int.
1021 * fns.c (hash_string): New function, taken from sxhash_string.
1022 Do not discard information about ASCII character case; this
1023 discarding is no longer needed.
1024 (sxhash-string): Use it. Change sig to match it. Caller changed.
1025 * lisp.h: Declare it.
1026 * lread.c (hash_string): Remove, since we now use fns.c's version.
1027 The fns.c version returns a wider integer if --with-wide-int is
1028 specified, so this should help the quality of the hashing a bit.
1030 * emacs.c: Integer overflow minor fix.
1031 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1032 Define only if GNU_LINUX.
1033 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1035 * dispnew.c: Integer signedness and overflow fixes.
1036 Remove unnecessary forward decls, that were a maintenance hassle.
1037 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1039 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1040 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1041 (prepare_desired_row, line_draw_cost):
1042 Use int, not unsigned, where either works.
1043 (save_current_matrix, restore_current_matrix):
1044 Use ptrdiff_t, not size_t, where either works.
1045 (init_display): Check for overflow more accurately, and without
1046 relying on undefined behavior.
1048 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1049 Remove, replacing with the new symbols in lisp.h. All uses changed.
1050 * fileio.c (make_temp_name):
1051 * filelock.c (lock_file_1, lock_file):
1052 * xdisp.c (message_dolog):
1053 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1054 Use pMd etc. instead.
1055 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1056 replacing the pWIDE etc. symbols removed from editfns.c.
1058 * keyboard.h (num_input_events): Now uintmax_t.
1059 This is (very slightly) less likely to mess up due to wraparound.
1062 * buffer.c: Integer signedness fixes.
1063 (alloc_buffer_text, enlarge_buffer_text):
1064 Use ptrdiff_t rather than size_t when either will do, as we prefer
1067 * alloc.c: Integer signedness and overflow fixes.
1068 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1069 (__malloc_size_t): Default to size_t, not to int.
1070 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1071 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1072 Prefer ptrdiff_t to size_t when either would do, as we prefer
1074 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1075 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1076 Now const. Initialize with values that are in range even if char
1078 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1079 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1080 These functions do the right thing with sizes > 2**32.
1081 (check_depth): Now ptrdiff_t, not int.
1082 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1083 Adjust to new way of storing sizes. Check for size overflow bugs
1085 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1086 slightly wrong anyway, as it missed one instance of
1087 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1088 (refill_memory_reserve): Omit needless cast to size_t.
1089 (mark_object_loop_halt): Mark as externally visible.
1091 * xselect.c: Integer signedness and overflow fixes.
1092 (Fx_register_dnd_atom, x_handle_dnd_message):
1093 Use ptrdiff_t, not size_t, since we prefer signed.
1094 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1095 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1096 x_dnd_atoms_size and x_dnd_atoms_length.
1098 * doprnt.c: Prefer signed to unsigned when either works.
1100 * doprnt.c (doprnt):
1102 * xdisp.c (vmessage):
1103 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1104 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1105 prefer signed arithmetic to avoid comparison confusion.
1106 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1107 but is a bit tricky.
1109 Assume freestanding C89 headers, string.h, stdlib.h.
1110 * data.c, doprnt.c, floatfns.c, print.c:
1111 Include float.h unconditionally.
1112 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1113 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1114 * regex.c: Likewise for stddef.h, string.h.
1115 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1116 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1117 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1118 (STDC_HEADERS): Remove obsolete defines.
1119 * sysdep.c: Include limits.h unconditionally.
1121 Assume support for memcmp, memcpy, memmove, memset.
1122 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1123 * regex.c (memcmp, memcpy):
1124 Remove; we assume C89 now.
1126 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1127 (__malloc_safe_bcopy): Remove; no longer needed.
1129 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1130 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1131 well either way, and we prefer signed to unsigned.
1133 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1135 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1136 closes the connection while we're reading (bug#9182).
1138 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1140 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1141 are specified (Bug#9168).
1143 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1145 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1146 Found by GCC static checking and --with-wide-int on a 32-bit host.
1148 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1150 * xdisp.c (compute_display_string_pos): Fix logic of caching
1151 previous display string position. Initialize cached_prev_pos to
1152 -1. Fixes slow-down at the beginning of a buffer.
1154 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1156 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1157 for attrs[LFACE_FONTSET_INDEX].
1159 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1161 * xml.c (parse_region): Remove unused local
1162 that was recently introduced.
1164 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1166 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1167 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1169 * xdisp.c (move_it_in_display_line_to): Record the best matching
1170 position for TO_CHARPOS while scanning the line, and restore it on
1171 exit if none of the characters scanned was an exact match.
1172 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1173 when exact match is impossible due to invisible text, and the
1174 lines are truncated.
1176 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1178 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1181 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1183 Fix a significant slow-down of cursor motion with C-n, C-p,
1184 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1185 auto-repeat under bidi redisplay in fontified buffers.
1186 * xdisp.c (compute_stop_pos_backwards): New function.
1187 (next_element_from_buffer): Call compute_stop_pos_backwards to
1188 find a suitable prev_stop when we find ourselves before
1190 (reseat): Don't look for prev_stop, as that could mean a very long
1192 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1193 <cached_disp_overlay_modiff>: Cache for last found display string
1195 (compute_display_string_pos): Return the cached position if asked
1196 about the same buffer in the same area of character positions, and
1197 the buffer wasn't changed since the time the display string
1198 position was cached.
1200 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1202 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1203 is an integer, which is important for empty lines. (Bug#9149)
1205 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1207 * frame.c (Fmodify_frame_parameters): In tty case, update the
1208 default face if necessary (Bug#4238).
1210 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1212 * editfns.c (Fstring_to_char): No need to explain what a character
1213 is in the docstring (Bug#6576).
1215 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1217 * xml.c (parse_region): Make sure we always return a tree.
1219 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1221 * xml.c (parse_region): If a document contains only comments,
1224 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1226 * xml.c (make_dom): Return comments, too.
1228 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1231 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1232 and the surrounding thread.
1233 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1234 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1235 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1237 * s/openbsd.h (BROKEN_SIGIO): Define.
1238 * unexelf.c (unexec) [__OpenBSD__]:
1239 Don't update the .mdebug section of the Alpha COFF symbol table.
1241 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1243 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1246 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1248 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1249 This fixes some race conditions on the permissions of any newly
1252 * alloc.c (valid_pointer_p): Use pipe, not open.
1253 This fixes some permissions issues when debugging.
1255 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1256 If fchown fails to set both uid and gid, try to set just gid,
1257 as that is sometimes allowed. Adjust the file's mode to eliminate
1258 setuid or setgid bits that are inappropriate if fchown fails.
1260 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1262 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1263 to compare Lisp_Objects.
1264 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1265 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1266 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1268 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1270 * lread.c (read_integer): Unread even EOF character.
1271 (read1): Likewise. Properly record start position of symbol.
1273 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1274 symbol character follows.
1276 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1278 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1279 This works around a problem with the previous change to Fcopy_file.
1280 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1281 and without this change, GCC might complain about discarding
1282 fchown's return value.
1284 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1286 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1288 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1290 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1292 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1294 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1295 it's used from the C level.
1297 * process.c: Use the same condition for POLL_FOR_INPUT in both
1298 keyboard.c and process.c (bug#1858).
1300 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1302 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1303 (Fgnutls_boot): Use it.
1305 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1307 * doc.c (Fsubstitute_command_keys): Revert last change.
1309 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1311 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1312 quotes the next character, and doesn't affect other longer
1313 sequences (bug#8935).
1315 * lread.c (syms_of_lread): Clarify that is isn't only
1316 `eval-buffer' and `eval-defun' that's affected by
1317 `lexical-binding' (bug#8460).
1319 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1321 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1322 bidi redisplay when a line includes both an image and is
1325 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1327 Fix minor problems found by static checking.
1328 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1329 (elsz): Now a signed constant, not a size_t var. We prefer signed
1330 types to unsigned, to avoid integer comparison confusion. Without
1331 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1332 "cannot optimize loop, the loop counter may overflow", a symptom
1334 * indent.c (Fvertical_motion): Mark locals as initialized.
1335 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1337 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1339 * search.c (Fre_search_backward): Mention `case-fold-search' in
1340 all the re_search_* functions (bug#8138).
1342 * keyboard.c (Fopen_dribble_file): Document when the file is
1345 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1347 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1350 Support bidi reordering of display and overlay strings.
1351 * xdisp.c (compute_display_string_pos)
1352 (compute_display_string_end): Accept additional argument STRING.
1353 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1354 (reseat_to_string): Initialize bidi_it->string.s and
1355 bidi_it->string.schars.
1356 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1357 NULL (avoids a crash in bidi_paragraph_init).
1358 Initialize itb.string.lstring.
1359 (init_iterator): Call bidi_init_it only of a valid
1360 buffer position was specified. Initialize paragraph_embedding to
1362 (reseat_to_string): Initialize the bidi iterator.
1363 (display_string): If we need to ignore text properties of
1364 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1365 original value of -1 will not work with bidi.)
1366 (compute_display_string_pos): First arg is now struct
1367 `text_pos *'; all callers changed. Support display properties on
1369 (compute_display_string_end): Support display properties on Lisp
1371 (init_iterator, reseat_1, reseat_to_string): Initialize the
1372 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1373 when iterating on a string not from display properties).
1374 (compute_display_string_pos, compute_display_string_end):
1375 Fix calculation of the object to scan. Fixes an error when using
1377 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1378 base_level_stop; instead, set base_level_stop to BEGV.
1379 Fixes crashes in vertical-motion.
1380 (next_element_from_buffer): Improve commentary for when
1381 the iterator is before prev_stop.
1382 (init_iterator): Initialize bidi_p from the default value of
1383 bidi-display-reordering, not from buffer-local value. Use the
1384 buffer-local value only if initializing for buffer iteration.
1385 (handle_invisible_prop): Support invisible properties on strings
1386 that are being bidi-reordered.
1387 (set_iterator_to_next): Support bidi reordering of C strings and
1389 (next_element_from_string): Support bidi reordering of Lisp
1391 (handle_stop_backwards): Support Lisp strings as well.
1392 (display_string): Support display of R2L glyph rows.
1393 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1394 (init_iterator): Don't initialize it->bidi_p for strings
1396 (reseat_to_string): Initialize it->bidi_p for strings here.
1397 (next_element_from_string, next_element_from_c_string)
1398 (next_element_from_buffer): Add xassert's for correspondence
1399 between IT's object being iterated and it->bidi_it.string
1401 (face_before_or_after_it_pos): Support bidi iteration.
1402 (next_element_from_c_string): Handle the case of the first string
1403 character that is not the first one in the visual order.
1404 (get_visually_first_element): New function, refactored from common
1405 parts of next_element_from_buffer, next_element_from_string, and
1406 next_element_from_c_string.
1407 (tool_bar_lines_needed, redisplay_tool_bar)
1408 (display_menu_bar): Force left-to-right direction. Add a FIXME
1409 comment for making that be controlled by a user option.
1410 (push_it, pop_it): Save and restore the state of the
1411 bidi iterator. Save and restore the bidi_p flag.
1412 (pop_it): Iterate out of display property for string iteration as
1414 (iterate_out_of_display_property): Support iteration over strings.
1415 (handle_single_display_spec): Set up it->bidi_it for iteration
1416 over a display string, and call bidi_init_it.
1417 (handle_single_display_spec, next_overlay_string)
1418 (get_overlay_strings_1, push_display_prop): Set up the bidi
1419 iterator for displaying display or overlay strings.
1420 (forward_to_next_line_start): Don't use the shortcut if
1422 (back_to_previous_visible_line_start): If handle_display_prop
1423 pushed the iterator stack, restore the internal state of the bidi
1424 iterator by calling bidi_pop_it same number of times.
1425 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1426 and we are bidi-iterating, don't decrement the iterator position;
1427 instead, set the first_elt flag in the bidi iterator, to produce
1429 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1430 (push_display_prop): xassert that we are iterating a buffer.
1431 (push_it, pop_it): Save and restore paragraph_embedding member.
1432 (handle_single_display_spec, next_overlay_string)
1433 (get_overlay_strings_1, reseat_1, reseat_to_string)
1434 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1435 correctly. Don't assume unibyte strings are not bidi-reordered.
1436 (compute_display_string_pos)
1437 (compute_display_string_end): Fix handling the case of C string.
1438 (push_it, pop_it): Save and restore from_disp_prop_p.
1439 (handle_single_display_spec, push_display_prop): Set the
1440 from_disp_prop_p flag.
1441 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1442 (pop_it): Call iterate_out_of_display_property only if we are
1443 popping after iteration over a string that came from a display
1444 property. Fix a typo in popping stretch info. Add an assertion
1445 for verifying that the iterator position is in sync with the bidi
1447 (handle_single_display_spec, get_overlay_strings_1)
1448 (push_display_prop): Fix initialization of paragraph direction for
1449 string when that of the parent object is not yet determined.
1450 (reseat_1): Call bidi_init_it to resync the bidi
1451 iterator with IT's position. (Bug#7616)
1452 (find_row_edges): If ROW->start.pos gives position
1453 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1454 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1455 Reset the from_disp_prop_p flag.
1456 (SAVE_IT, RESTORE_IT): New macros.
1457 (pos_visible_p, face_before_or_after_it_pos)
1458 (back_to_previous_visible_line_start)
1459 (move_it_in_display_line_to, move_it_in_display_line)
1460 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1461 (try_scrolling, redisplay_window, display_line): Use them when
1462 saving a temporary copy of the iterator and restoring it back.
1463 (back_to_previous_visible_line_start, reseat_1)
1464 (init_iterator): Empty the bidi cache "stack".
1465 (move_it_in_display_line_to): If iterator ended up at
1466 EOL, but we never saw any buffer positions smaller than
1467 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1468 motion in bidi-reordered lines.
1469 (move_it_in_display_line_to): Record prev_method and prev_pos
1470 immediately before the call to set_iterator_to_next. Fixes cursor
1471 motion in bidi-reordered lines with stretch glyphs and strings
1472 displayed in margins. (Bug#8133) (Bug#8867)
1473 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1475 (pos_visible_p): Support positions in bidi-reordered lines.
1476 Save and restore bidi cache.
1478 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1479 (bidi_paragraph_info): Delete unused struct.
1480 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1481 (bidi_cache_start): New variable.
1482 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1484 (bidi_cache_fetch_state, bidi_cache_search)
1485 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1486 (bidi_cache_find, bidi_peek_at_next_level)
1487 (bidi_level_of_next_char, bidi_find_other_level_edge)
1488 (bidi_move_to_visually_next): Compare cache index with
1489 bidi_cache_start rather than with zero.
1490 (bidi_fetch_char): Accept new argument STRING; all callers
1491 changed. Support iteration over a string. Support strings with
1492 display properties. Support unibyte strings. Fix the type of
1493 `len' according to what STRING_CHAR_AND_LENGTH expects.
1494 (bidi_paragraph_init, bidi_resolve_explicit_1)
1495 (bidi_resolve_explicit, bidi_resolve_weak)
1496 (bidi_level_of_next_char, bidi_move_to_visually_next):
1497 Support iteration over a string.
1498 (bidi_set_sor_type, bidi_resolve_explicit_1)
1499 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1500 can now be zero (for strings); special values 0 and -1 were
1501 changed to -1 and -2, respectively.
1502 (bidi_char_at_pos): New function.
1503 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1504 Call it instead of FETCH_MULTIBYTE_CHAR.
1505 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1506 initialized to valid values.
1507 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1509 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1510 the test for valid cached positions. Fix the logic for looking up
1511 the sentinel state in the cache. GCPRO the Lisp string we are
1513 (bidi_push_it, bidi_pop_it): New functions.
1514 (bidi_initialize): Initialize the bidi cache start stack pointer.
1515 (bidi_cache_ensure_space): New function, refactored from part of
1516 bidi_cache_iterator_state. Don't assume the required size is just
1517 one BIDI_CACHE_CHUNK away.
1518 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1519 (bidi_count_bytes, bidi_char_at_pos): New functions.
1520 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1521 always valid if bidi_cache_idx is valid.
1522 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1523 is valid if it's going to be used.
1524 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1525 (bidi_cache_fetch_state, bidi_cache_search)
1526 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1527 (bidi_cache_iterator_state, bidi_cache_find)
1528 (bidi_find_other_level_edge, bidi_cache_start_stack):
1529 All variables related to cache indices are now EMACS_INT.
1531 * dispextern.h (struct bidi_string_data): New structure.
1532 (struct bidi_it): New member `string'. Make flag members be 1-bit
1533 fields, and put them last in the struct.
1534 (compute_display_string_pos, compute_display_string_end):
1536 (bidi_push_it, bidi_pop_it): Add prototypes.
1537 (struct iterator_stack_entry): New members bidi_p,
1538 paragraph_embedding, and from_disp_prop_p.
1539 (struct it): Member bidi_p is now a bit field 1 bit wide.
1540 (bidi_shelve_cache, bidi_unshelve_cache):
1543 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1544 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1545 and vector-like objects.
1547 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1548 cache around display iteration.
1550 * window.c (Fwindow_end, window_scroll_pixel_based)
1551 (displayed_window_lines, Frecenter): Save and restore the bidi
1552 cache around display iteration.
1554 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1556 * editfns.c (Fdelete_region): Clarify the use of the named
1557 parameters (bug#6788).
1559 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1561 * indent.c (Fvertical_motion): Set and restore w->pointm when
1562 saving and restoring the window's buffer (Bug#9006).
1564 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1566 * editfns.c (Fstring_to_char): Clarify just what is returned
1567 (bug#6576). Text by Eli Zaretskii.
1569 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1571 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1573 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1575 * buffer.c (mmap_find): Fix a typo.
1577 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1579 Fix execution of x selection hooks.
1580 * xselect.c (Qx_lost_selection_functions)
1581 (Qx_sent_selection_functions): New vars.
1582 (syms_of_xselect): DEFSYM them.
1583 (x_handle_selection_request): Pass Qx_sent_selection_functions
1584 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1585 (x_handle_selection_clear,x_clear_frame_selections):
1586 Pass Qx_lost_selection_functions rather than
1587 Vx_lost_selection_functions to Frun_hook_with_args.
1589 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1591 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1592 The old code sometimes used this field without initializing it.
1594 * alloc.c (gc_sweep): Don't read past end of array.
1595 In theory, the old code could also have corrupted Emacs internals,
1596 though it'd be very unlikely.
1598 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1600 * character.c (Fcharacterp): Don't advertise optional ignored
1601 argument. (Bug#4026)
1603 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1605 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1608 * window.c (Fset_window_start): Doc fix (bug#4199).
1609 (Fset_window_hscroll): Ditto.
1611 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1613 Fix minor new problems caught by GCC 4.6.1.
1614 * term.c (init_tty): Remove unused local.
1615 * xsettings.c (store_monospaced_changed): Define this function only
1616 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1619 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1621 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1623 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1625 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1626 are the mini-buffer and the echo area (bug#3320).
1628 * term.c (init_tty): Remove support for supdup, c10 and perq
1629 terminals, which are no longer supported (bug#1482).
1631 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1633 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1635 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1637 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1638 for non-popups (Bug#3642).
1640 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1642 * alloc.c (reset_malloc_hooks): Protoize.
1643 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1644 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1645 * cm.c (losecursor): Likewise.
1646 * data.c (fmod): Likewise.
1647 * dispnew.c (swap_glyphs_in_rows): Likewise.
1648 * emacs.c (memory_warning_signal): Likewise.
1649 * floatfns.c (float_error): Likewise.
1650 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1651 (otf_open, font_otf_capability, generate_otf_features)
1652 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1654 * image.c (pbm_read_file): Likewise.
1655 * indent.c (string_display_width): Likewise.
1656 * intervals.c (check_for_interval, search_for_interval)
1657 (inc_interval_count, count_intervals, root_interval)
1658 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1659 * lread.c (defalias): Likewise.
1660 * ralloc.c (r_alloc_check): Likewise.
1661 * regex.c (set_image_of_range_1, set_image_of_range)
1662 (regex_grow_registers): Likewise.
1663 * sysdep.c (strerror): Likewise.
1664 * termcap.c (valid_filename_p, tprint, main): Likewise.
1665 * tparam.c (main): Likewise.
1666 * unexhp9k800.c (run_time_remap, save_data_space)
1667 (update_file_ptrs, read_header, write_header, calculate_checksum)
1668 (copy_file, copy_rest, display_header): Likewise.
1669 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1671 * xdisp.c (check_it): Likewise.
1672 * xfaces.c (register_color, unregister_color, unregister_colors):
1674 * xfns.c (print_fontset_result): Likewise.
1675 * xrdb.c (member, fatal, main): Likewise.
1677 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1679 Fix minor problems found by static checking (Bug#9031).
1680 * chartab.c (char_table_set_range, map_sub_char_table):
1681 Remove unused locals.
1682 (uniprop_table): Now static.
1683 * composite.c (_work_char): Remove unused static var.
1685 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1687 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1689 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1691 * gtkutil.c (qttip_cb): Remove code without function.
1693 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1695 * w32.c (pthread_sigmask): New stub.
1697 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1699 Use pthread_sigmask, not sigprocmask (Bug#9010).
1700 sigprocmask is portable only for single-threaded applications, and
1701 Emacs can be multi-threaded when it uses GTK.
1702 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1704 * callproc.c (Fcall_process):
1705 * process.c (create_process):
1706 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1707 Use pthread_sigmask, not sigprocmask.
1709 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1711 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1712 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1715 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1717 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1718 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1719 (xg_hide_tooltip): Fix comment.
1721 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1722 in registerServicesMenuSendTypes.
1723 (validRequestorForSendType): Don't check ns_return_types.
1725 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1728 2011-07-08 Jason Rumney <jasonr@gnu.org>
1730 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1731 frame struct members of non-existent frames (Bug#6284).
1733 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1735 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1736 variable firstTime not needed on OSX >= 10.6.
1737 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1738 >= 10.5. Use setKnobProportion, setDoubleValue.
1740 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1741 (MAC_OS_X_VERSION_10_5): Define if not defined.
1742 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1743 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1744 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1746 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1747 cString and lossyCString on OSX >= 10.4
1749 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1750 sizeToFit on OSX >= 10.2.
1752 * nsimage.m (allocInitFromFile): Don't use deprecated method
1753 bestRepresentationForDevice on OSX >= 10.6.
1755 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1758 * emacs.c: Declare unexec_init_emacs_zone.
1760 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1762 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1764 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1765 on svcsMenu (Bug#8842).
1767 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1769 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1771 * nsterm.m (QUTF8_STRING): Declare.
1772 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1773 (validRequestorForSendType): Return type is (id).
1774 Change indexOfObjectIdenticalTo to indexOfObject.
1775 Check if we have local selection before returning self (Bug#8842).
1776 (writeSelectionToPasteboard): Put local selection into paste board
1777 if we have a local selection (Bug#8842).
1778 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1780 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1781 (ns_get_local_selection): Declare.
1783 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1785 * keymap.c (describe_map_tree): Don't insert a double newline at
1786 the end of the buffer (bug#1169) and return whether we inserted
1789 * callint.c (Fcall_interactively): Change "reading args" to
1790 "providing args" to try to clarify what it does (bug#1010).
1792 2011-07-07 Kenichi Handa <handa@m17n.org>
1794 * composite.c (composition_compute_stop_pos): Ignore a static
1795 composition starting before CHARPOS (Bug#8915).
1797 * xdisp.c (handle_composition_prop): Likewise.
1799 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1801 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1804 2011-07-07 Kenichi Handa <handa@m17n.org>
1806 * character.h (unicode_category_t): New enum type.
1808 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1809 (Qchar_code_property_table): New variable.
1810 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1811 (UNIPROP_COMPRESSED_FORM_P): New macros.
1812 (char_table_ascii): Uncompress the compressed values.
1813 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1814 Uncompress the compressed values.
1815 (sub_char_table_ref_and_range): Likewise.
1816 (char_table_ref_and_range): Uncompress the compressed values.
1817 (sub_char_table_set): New arg is_uniprop. Callers changed.
1818 Uncompress the compressed values.
1819 (sub_char_table_set_range): Args changed. Callers changed.
1820 (char_table_set_range): Adjuted for the above change.
1821 (map_sub_char_table): Delete args default_val and parent. Add arg
1822 top. Give decoded values to a Lisp function.
1823 (map_char_table): Adjust for the above change. Give decoded
1824 values to a Lisp function. Gcpro more variables.
1825 (uniprop_table_uncompress)
1826 (uniprop_decode_value_run_length): New functions.
1827 (uniprop_decoder, uniprop_decoder_count): New variables.
1828 (uniprop_get_decoder, uniprop_encode_value_character)
1829 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1831 (uniprop_encoder, uniprop_encoder_count): New variables.
1832 (uniprop_get_encoder, uniprop_table)
1833 (Funicode_property_table_internal, Fget_unicode_property_internal)
1834 (Fput_unicode_property_internal): New functions.
1835 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1836 Sunicode_property_table_internal, Sget_unicode_property_internal,
1837 and Sput_unicode_property_internal. Defvar_lisp
1838 char-code-property-alist.
1840 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1841 Vunicode_category_table.
1843 * font.c (font_range): Adjust for the change of
1844 Vunicode_category_table.
1846 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1848 * m/iris4d.h: Remove file, move contents ...
1849 * s/irix6-5.h: ... here.
1851 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1853 Remove unportable assumption about struct layout (Bug#8884).
1854 * alloc.c (mark_buffer):
1855 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1856 (clone_per_buffer_values): Don't assume that
1857 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1858 This isn't true in general, and it's particularly not true
1859 if Emacs is configured with --with-wide-int.
1860 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1861 New macros, used in the buffer.c change.
1863 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1865 * xsettings.c: Use both GConf and GSettings if both are available.
1866 (store_config_changed_event): Add comment.
1867 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1868 (store_tool_bar_style_changed): New functions.
1869 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1870 (struct xsettings): Move font inside HAVE_XFT.
1871 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1872 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1873 Move inside HAVE_XFT.
1874 (something_changed_gsettingsCB): Rename from something_changedCB.
1875 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1877 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1878 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1879 (something_changed_gconfCB): Rename from something_changedCB.
1880 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1881 (parse_settings): Move check for font inside HAVE_XFT.
1882 (read_settings, apply_xft_settings): Add comment.
1883 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1884 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1885 call store_font_name_changed.
1886 (xft_settings_event): Add comment.
1887 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1888 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1889 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1890 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1891 (xsettings_initialize): Call init_gsettings last.
1892 (xsettings_get_system_font, xsettings_get_system_normal_font):
1895 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1897 Random fixes. E.g., (random) never returned negative values.
1898 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1899 subseconds part to the entropy, as that's a bit more random.
1900 Prefer signed to unsigned, since the signedness doesn't matter and
1901 in general we prefer signed. When given a limit, use a
1902 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1903 latter isn't right if USE_2_TAGS_FOR_INTS.
1904 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1905 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1907 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1909 * textprop.c (text_property_stickiness):
1910 Obey Vtext_property_default_nonsticky.
1911 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1912 * w32fns.c (syms_of_w32fns):
1913 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1915 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1917 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1918 This is more efficient than Ffile_directory_p and avoids a minor race.
1920 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1922 * buffer.c (Foverlay_put): Say what the return value is
1925 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1926 is a directory before asking whether to use the file name
1928 (barf_or_query_if_file_exists): Make the "File is a directory"
1929 error be more correct.
1931 * fns.c (Frequire): Remove the mention of the .gz files, since
1932 that's installation-specific, but keep the mention of
1933 `get-load-suffixes'.
1935 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1937 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1938 Report string overflow if the output is too long.
1940 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1942 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1943 (syms_of_gnutls): Remove duplicate DEFSYM for
1944 Qgnutls_bootprop_verify_hostname_error, an error for
1945 Qgnutls_bootprop_verify_error (which is no longer used).
1947 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1948 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1949 Also (re)move comments that are misplaced or no longer relevant.
1951 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1953 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1955 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1957 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1958 and background color parameters if they have been changed.
1960 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1962 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1964 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1966 * xsettings.c (SYSTEM_FONT): Define only when used.
1967 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1969 * keymap.c (access_keymap_1): Now static.
1971 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1973 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1974 leave any prefix arg for the up event (Bug#1586).
1976 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1978 * lread.c (syms_of_lread): Mention single symbols defined by
1979 `defvar' or `defconst' (bug#7154).
1981 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1982 (Frequire): Mention get-load-suffixes.
1984 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1986 * window.h (window): Remove clone_number slot.
1987 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1989 (make_parent_window, make_window, saved_window)
1990 (Fset_window_configuration, save_window_save): Don't deal with
1992 * buffer.c (Qclone_number): Remove declaration.
1993 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1995 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1997 Add multiple inheritance to keymaps.
1998 * keymap.c (Fmake_composed_keymap): New function.
1999 (Fset_keymap_parent): Simplify.
2000 (fix_submap_inheritance): Remove.
2001 (access_keymap_1): New function extracted from access_keymap to handle
2002 embedded parents and handle lists of maps.
2003 (access_keymap): Use it.
2004 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2005 (Fcopy_keymap): Handle embedded parents.
2006 (Fcommand_remapping, define_as_prefix): Simplify.
2007 (Fkey_binding): Simplify.
2008 (syms_of_keymap): Move minibuffer-local-completion-map,
2009 minibuffer-local-filename-completion-map,
2010 minibuffer-local-must-match-map, and
2011 minibuffer-local-filename-must-match-map to Elisp.
2012 (syms_of_keymap): Defsubr make-composed-keymap.
2013 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2014 (parse_menu_item): Trivial simplification.
2016 2011-07-01 Glenn Morris <rgm@gnu.org>
2018 * Makefile.in (SETTINGS_LIBS): Fix typo.
2020 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2022 * coding.c (Fencode_coding_string): Record the last coding system
2023 used, as the function doc string says (bug#8738).
2025 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2027 * xsettings.c (store_monospaced_changed): Take new font as arg and
2028 check for change against current_mono_font.
2029 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2030 (emacs_settings_constructor, emacs_settings_get_property)
2031 (emacs_settings_set_property, emacs_settings_class_init)
2032 (emacs_settings_init, gsettings_obj): Remove.
2033 (something_changedCB): New function for HAVE_GSETTINGS.
2034 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2035 with value as argument.
2036 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2037 g_settings_new (Bug#8967). Do not create gsettings_obj.
2038 Remove calls to g_settings_bind. Connect something_changedCB to
2041 * xgselect.c: Add defined (HAVE_GSETTINGS).
2042 (xgselect_initialize): Ditto.
2044 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2045 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2048 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2050 * eval.c (struct backtrace): Simplify and port the data structure.
2051 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2052 signed bit field, as this assumption is not portable and it makes
2053 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2054 "char debug_on_exit : 1" as this is not portable either; instead,
2055 use the portable "unsigned int debug_on_exit : 1". Remove unused
2056 member evalargs. Remove obsolete comments about cc bombing out.
2058 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2060 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2061 Let HAVE_GSETTINGS override HAVE_GCONF.
2062 (store_monospaced_changed): New function.
2063 (EMACS_SETTINGS): A new type derived from GObject to handle
2064 GSettings notifications.
2065 (emacs_settings_constructor, emacs_settings_get_property)
2066 (emacs_settings_set_property, emacs_settings_class_init):
2068 (gsettings_client, gsettings_obj): New variables.
2069 (GSETTINGS_SCHEMA): New define.
2070 (something_changedCB): Call store_monospaced_changed.
2071 (init_gsettings): New function.
2072 (xsettings_initialize): Call init_gsettings.
2073 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2076 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2079 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2081 * window.c (resize_root_window, grow_mini_window)
2082 (shrink_mini_window): Rename Qresize_root_window to
2083 Qwindow_resize_root_window and Qresize_root_window_vertically to
2084 Qwindow_resize_root_window_vertically.
2086 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2088 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2090 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2092 * makefile.w32-in: Redesign dependencies so they reflect more
2093 clearly which files are directly included by each source file,
2094 and not through other includes.
2096 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2098 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2099 (sort_overlays, overlay_strings): When an overlay's clone number
2100 matches the window's clone number process the overlay even if
2101 the overlay's window property doesn't match the current window.
2103 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2104 (Fwindow_hchild): Rename to Fwindow_left_child.
2105 (Fwindow_next): Rename to Fwindow_next_sibling.
2106 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2107 (resize_window_check): Rename to window_resize_check.
2108 (resize_window_apply): Rename to window_resize_apply.
2109 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2110 (Fdelete_other_windows_internal, resize_frame_windows)
2111 (Fsplit_window_internal, Fdelete_window_internal)
2112 (grow_mini_window, shrink_mini_window)
2113 (Fresize_mini_window_internal): Fix callers accordingly.
2115 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2117 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2118 (emacs_fixed_set_min_size): Remove.
2119 (emacs_fixed_new): Take frame as argument.
2121 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2122 (_EmacsFixedPrivate): Remove minwidth/height.
2123 Add struct frame *f.
2124 (emacs_fixed_init): Initialize priv->f.
2125 (get_parent_class, emacs_fixed_set_min_size): Remove.
2126 (emacs_fixed_new): Set priv->f to argument.
2127 (emacs_fixed_get_preferred_width)
2128 (emacs_fixed_get_preferred_height): Use min_width/height from
2129 frames size_hint to set minimum and natural (Bug#8919).
2130 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2131 and use min_width/height from frames size_hint to set
2132 min_width/height (Bug#8919).
2134 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2135 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2138 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2140 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2141 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2144 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2146 * process.c (wait_reading_process_output): Bypass select if
2147 waiting for a cell while ignoring keyboard input, and input is
2148 pending. Suggested by Jan Djärv (Bug#8869).
2150 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2152 Use gnulib's dup2 module instead of rolling our own.
2153 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2155 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2157 * dispnew.c (scrolling_window): Before scrolling, turn off a
2158 mouse-highlight in the window being scrolled.
2160 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2162 Move DEFSYM to lisp.h and use everywhere.
2164 * character.h (DEFSYM): Move declaration...
2165 * lisp.h (DEFSYM): ...here.
2171 * w32select.c: Don't include character.h.
2173 * alloc.c (syms_of_alloc):
2174 * buffer.c (syms_of_buffer):
2175 * bytecode.c (syms_of_bytecode):
2176 * callint.c (syms_of_callint):
2177 * casefiddle.c (syms_of_casefiddle):
2178 * casetab.c (init_casetab_once):
2179 * category.c (init_category_once, syms_of_category):
2180 * ccl.c (syms_of_ccl):
2181 * cmds.c (syms_of_cmds):
2182 * composite.c (syms_of_composite):
2183 * dbusbind.c (syms_of_dbusbind):
2184 * dired.c (syms_of_dired):
2185 * dispnew.c (syms_of_display):
2186 * doc.c (syms_of_doc):
2187 * editfns.c (syms_of_editfns):
2188 * emacs.c (syms_of_emacs):
2189 * eval.c (syms_of_eval):
2190 * fileio.c (syms_of_fileio):
2191 * fns.c (syms_of_fns):
2192 * frame.c (syms_of_frame):
2193 * fringe.c (syms_of_fringe):
2194 * insdel.c (syms_of_insdel):
2195 * keymap.c (syms_of_keymap):
2196 * lread.c (init_obarray, syms_of_lread):
2197 * macros.c (syms_of_macros):
2198 * msdos.c (syms_of_msdos):
2199 * print.c (syms_of_print):
2200 * process.c (syms_of_process):
2201 * search.c (syms_of_search):
2202 * sound.c (syms_of_sound):
2203 * syntax.c (init_syntax_once, syms_of_syntax):
2204 * terminal.c (syms_of_terminal):
2205 * textprop.c (syms_of_textprop):
2206 * undo.c (syms_of_undo):
2207 * w32.c (globals_of_w32):
2208 * window.c (syms_of_window):
2209 * xdisp.c (syms_of_xdisp):
2210 * xfaces.c (syms_of_xfaces):
2211 * xfns.c (syms_of_xfns):
2212 * xmenu.c (syms_of_xmenu):
2213 * xsettings.c (syms_of_xsettings):
2214 * xterm.c (syms_of_xterm): Use DEFSYM.
2216 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2218 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2220 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2222 Integer and buffer overflow fixes (Bug#8873).
2224 * print.c (printchar, strout): Check for string overflow.
2225 (PRINTPREPARE, printchar, strout):
2226 Don't set size unless allocation succeeds.
2228 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2229 for sizes. Check for string overflow more accurately.
2230 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2232 * macros.c: Integer and buffer overflow fixes.
2233 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2234 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2235 Use ptrdiff_t, not int, for sizes.
2236 Don't increment bufsize until after realloc succeeds.
2237 Check for size-calculation overflow.
2238 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2240 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2242 * lread.c: Integer overflow fixes.
2243 (read_integer): Radix is now EMACS_INT, not int,
2244 to improve quality of diagnostics for out-of-range radices.
2245 Calculate buffer size correctly for out-of-range radices.
2246 (read1): Check for integer overflow in radices, and in
2247 read-circle numbers.
2248 (read_escape): Avoid int overflow.
2249 (Fload, openp, read_buffer_size, read1)
2250 (substitute_object_recurse, read_vector, read_list, map_obarray):
2251 Use ptrdiff_t, not int, for sizes.
2252 (read1): Use EMACS_INT, not int, for sizes.
2253 Check for size overflow.
2255 * image.c (cache_image): Check for size arithmetic overflow.
2257 * lread.c: Integer overflow issues.
2258 (saved_doc_string_size, saved_doc_string_length)
2259 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2260 Now ptrdiff_t, not int.
2261 (read1): Don't assume doc string length fits in int. Check for
2262 out-of-range doc string lengths.
2263 (read_list): Don't assume file position fits in int.
2264 (read_escape): Check for hex character overflow.
2266 2011-06-22 Leo Liu <sdl.web@gmail.com>
2268 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2269 Move to minibuffer.el.
2271 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2273 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2274 The following patches are for when GLYPH_DEBUG && !XASSERT.
2275 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2276 * dispnew.c (flush_stdout):
2277 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2278 Mark as externally visible.
2279 * dispnew.c (check_window_matrix_pointers): Now static.
2280 * dispnew.c (window_to_frame_vpos):
2281 * xfns.c (unwind_create_frame):
2282 * xterm.c (x_check_font): Remove unused local.
2283 * scroll.c (CHECK_BOUNDS):
2284 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2285 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2286 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2287 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2288 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2290 (debug_method_add): Use va_list and vsprintf rather than relying
2291 on undefined behavior with wrong number of arguments.
2292 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2293 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2294 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2295 since we're not interested in debugging glyphs with old libraries.
2296 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2297 GCC 4.6.0's static checking.
2299 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2301 Integer overflow and signedness fixes (Bug#8873).
2302 A few related buffer overrun fixes, too.
2304 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2306 * dispextern.h (struct face.stipple):
2307 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2308 (x_bitmap_mask, x_allocate_bitmap_record)
2309 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2310 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2311 (x_create_bitmap_from_xpm_data):
2312 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2313 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2315 * xfaces.c (load_pixmap):
2316 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2317 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2318 (.bitmaps_last, struct x_output.icon_bitmap):
2319 Use ptrdiff_t, not int, for bitmap indexes.
2320 (x_allocate_bitmap_record): Check for size overflow.
2321 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2323 Use ptrdiff_t, not int, for overlay counts.
2324 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2325 * editfns.c (overlays_around, get_pos_property):
2326 * textprop.c (get_char_property_and_overlay):
2327 * xdisp.c (next_overlay_change, note_mouse_highlight):
2328 * xfaces.c (face_at_buffer_position):
2329 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2330 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2331 (Fnext_overlay_change, Fprevious_overlay_change)
2332 (mouse_face_overlay_overlaps, Foverlays_in):
2333 Use ptrdiff_t, not int, for sizes.
2334 (overlays_at, overlays_in): Check for size-calculation overflow.
2336 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2338 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2339 (x_session_initialize): Do not assume string length fits in int.
2341 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2342 This is unlikely, but can occur if DPI is outlandish.
2344 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2345 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2347 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2348 * xrdb.c (magic_file_p, search_magic_path):
2349 Omit last arg SUFFIX; it was always 0. All callers changed.
2350 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2352 * xfont.c (xfont_match): Avoid need for strlen.
2354 * xfns.c: Don't assume strlen fits in int.
2355 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2357 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2358 not unsigned long, as we prefer signed integers. All callers changed.
2359 Detect integer overflow in repeat count.
2360 (message_dolog): Don't assume print length fits in 39 bytes.
2361 (display_mode_element): Don't assume strlen fits in int.
2363 * termcap.c: Don't assume sizes fit in int and never overflow.
2364 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2365 (gobble_line): Check for size-calculation overflow.
2367 * minibuf.c (Fread_buffer):
2368 * lread.c (intern, intern_c_string):
2369 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2370 Don't assume string length fits in int.
2372 * keyboard.c (parse_tool_bar_item):
2373 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2375 * font.c: Don't assume string length fits in int.
2376 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2377 Use ptrdiff_t, not int.
2378 (font_intern_prop): Don't assume string length fits in int.
2379 Don't assume integer property fits in fixnum.
2380 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2382 * filelock.c: Fix some buffer overrun and integer overflow issues.
2383 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2384 Reformulate so as not to need the command string.
2385 Invoke gzip -cd rather than gunzip, as it's more portable.
2386 (lock_info_type, lock_file_1, lock_file):
2387 Don't assume pid_t and time_t fit in unsigned long.
2388 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2389 (current_lock_owner): Prefer signed type for sizes.
2390 Use memcpy, not strncpy, where memcpy is what is really wanted.
2391 Don't assume (via atoi) that time_t and pid_t fit in int.
2392 Check for time_t and/or pid_t out of range, e.g., via a network share.
2393 Don't alloca where an auto var works fine.
2395 * fileio.c: Fix some integer overflow issues.
2396 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2397 Don't assume string length fits in int.
2398 (directory_file_name): Don't assume string length fits in long.
2399 (make_temp_name): Don't assume pid fits in int, or that its print
2400 length is less than 20.
2402 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2404 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2406 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2408 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2409 We prefer signed integers, even for size calculations.
2411 * emacs.c: Don't assume string length fits in 'int'.
2412 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2413 (main): Don't invoke strlen when not needed.
2415 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2416 (XD_DEBUG_MESSAGE): Don't waste a byte.
2418 * callproc.c (getenv_internal_1, getenv_internal)
2420 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2422 * lread.c (invalid_syntax): Omit length argument.
2423 All uses changed. This doesn't fix a bug, but it simplifies the
2424 code away from its former Hollerith-constant appearance, and it's
2425 one less 'int' to worry about when looking at integer-overflow issues.
2426 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2428 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2429 This didn't break anything, but it didn't help either.
2430 It's confusing to put a bogus integer in a place where the actual
2431 value does not matter.
2432 (LIST_END_P): Remove unused macro and its bogus comment.
2433 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2435 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2436 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2438 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2439 We prefer signed types, and the value cannot exceed the EMACS_INT
2440 range anyway (because otherwise the length would not be representable).
2441 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2442 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2443 This avoids a GCC warning when WIDE_EMACS_INT.
2445 * indent.c (sane_tab_width): New function.
2446 (current_column, scan_for_column, Findent_to, position_indentation)
2447 (compute_motion): Use it. This is just for clarity.
2448 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2450 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2452 * lisp.h (lint_assume): New macro.
2453 * composite.c (composition_gstring_put_cache):
2454 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2456 * editfns.c, insdel.c:
2457 Omit unnecessary forward decls, to simplify future changes.
2459 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2461 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2463 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2464 Use much-faster test for byte-length change.
2465 Don't assume string byte-length fits in 'int'.
2466 Check that character arg fits in 'int'.
2467 (mapcar1): Declare byte as byte, for clarity.
2469 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2471 * fns.c (concat): Catch string overflow earlier.
2472 Do not rely on integer wraparound.
2474 * dispextern.h (struct it.overlay_strings_charpos)
2475 (struct it.selective): Now EMACS_INT, not int.
2476 * xdisp.c (forward_to_next_line_start)
2477 (back_to_previous_visible_line_start)
2478 (reseat_at_next_visible_line_start, next_element_from_buffer):
2479 Don't arbitrarily truncate the value of 'selective' to int.
2481 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2483 * composite.c: Don't truncate sizes to 'int'.
2484 (composition_gstring_p, composition_reseat_it)
2485 (composition_adjust_point): Use EMACS_INT, not int.
2486 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2487 not EMACS_UINT, for indexes.
2489 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2491 * buffer.c: Include <verify.h>.
2492 (struct sortvec.priority, struct sortstr.priority):
2493 Now EMACS_INT, not int.
2494 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2495 (struct sortstr.size, record_overlay_string)
2496 (struct sortstrlist.size, struct sortlist.used):
2497 Don't truncate size to int.
2498 (record_overlay_string): Check for size-calculation overflow.
2499 (init_buffer_once): Check at compile-time, not run-time.
2501 2011-06-22 Jim Meyering <meyering@redhat.com>
2503 Don't leak an XBM-image-sized buffer
2504 * image.c (xbm_load): Free the image buffer after using it.
2506 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2509 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2510 that Sun C diagnosed.
2511 * fns.c (secure_hash): Fix pointer signedness issue.
2512 * intervals.c (static_offset_intervals): New function.
2513 (offset_intervals): Use it.
2515 2011-06-21 Leo Liu <sdl.web@gmail.com>
2518 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2521 * fns.c (secure_hash): Rename from crypto_hash_function and change
2522 the first arg to accept symbols.
2523 (Fsecure_hash): New primitive.
2524 (syms_of_fns): New symbols.
2526 2011-06-20 Deniz Dogan <deniz@dogan.se>
2528 * process.c (Fset_process_buffer): Clarify return value in
2531 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2533 * dispnew.c (add_window_display_history): Use BVAR.
2535 * xdisp.c (debug_method_add): Use BVAR.
2536 (check_window_end, dump_glyph_matrix, dump_glyph)
2537 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2539 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2542 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2543 check till after the cache is created in init_frame_faces.
2545 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2547 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2549 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2551 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2552 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2553 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2555 Improve buffer-overflow checking (Bug#8873).
2556 * fileio.c (Finsert_file_contents):
2557 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2558 Remove the old (too-loose) buffer overflow checks.
2559 They weren't needed, since make_gap checks for buffer overflow.
2560 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2561 The old code merely checked for Emacs fixnum overflow, and relied
2562 on undefined (wraparound) behavior. The new code avoids undefined
2563 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2565 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2566 Tune. Don't use wider integers than needed. Don't use alloca.
2567 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2569 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2571 * insdel.c, lisp.h (buffer_overflow): New function.
2572 (insert_from_buffer_1, replace_range, replace_range_2):
2573 * insdel.c (make_gap_larger):
2574 * editfns.c (Finsert_char):
2575 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2577 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2579 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2581 Integer overflow and signedness fixes (Bug#8873).
2583 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2584 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2586 * fileio.c: Don't assume EMACS_INT fits in off_t.
2587 (emacs_lseek): New static function.
2588 (Finsert_file_contents, Fwrite_region): Use it.
2589 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2591 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2593 * fns.c: Don't overflow int when computing a list length.
2594 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2595 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2596 truncation on 64-bit hosts. Check for QUIT every
2597 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2598 faster and is responsive enough.
2599 (Flength): Report an error instead of overflowing an integer.
2600 (Fsafe_length): Return a float if the value is not representable
2601 as a fixnum. This shouldn't happen except in contrived situations.
2602 (Fnthcdr, Fsort): Don't assume list length fits in int.
2603 (Fcopy_sequence): Don't assume vector length fits in int.
2605 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2606 (header_size, word_size): New constants.
2607 (allocate_vectorlike): Don't check size overflow here.
2608 (allocate_vector): Check it here instead, since this is the only
2609 caller of allocate_vectorlike that could cause overflow.
2610 Check that the new vector's length is representable as a fixnum.
2612 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2613 The previous code was bogus. For example, next_almost_prime (32)
2614 returned 39, which is undesirable as it is a multiple of 3; and
2615 next_almost_prime (24) returned 25, which is a multiple of 5 so
2616 why was the code bothering to check for multiples of 7?
2618 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2620 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2622 Variadic C functions now count arguments with ptrdiff_t.
2623 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2624 Back then I didn't know that the Emacs coding style prefers signed int.
2625 Also, in the meantime I found a few more instances where arguments
2626 were being counted with int, which may truncate counts on 64-bit
2627 machines, or EMACS_INT, which may be unnecessarily wide.
2628 * lisp.h (struct Lisp_Subr.function.aMANY)
2629 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2630 Arg counts are now ptrdiff_t, not size_t.
2631 All variadic functions and their callers changed accordingly.
2632 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2633 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2634 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2635 * callint.c (Fcall_interactively): Check arg count for overflow,
2636 to avoid potential buffer overrun. Use signed char, not 'int',
2637 for 'varies' array, so that we needn't bother to check its size
2638 calculation for overflow.
2639 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2640 * eval.c (apply_lambda):
2641 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2642 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2643 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2645 * callint.c (Fcall_interactively): Don't use index var as event count.
2647 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2648 * mem-limits.h (SIZE): Remove; no longer used.
2650 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2652 Remove unnecessary casts.
2653 * xterm.c (x_term_init):
2654 * xfns.c (x_set_border_pixel):
2655 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2656 These aren't needed now that we assume ANSI C.
2658 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2659 It's more likely to cause problems (due to unsigned overflow)
2662 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2664 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2666 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2668 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2670 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2672 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2674 GLYPH_CODE_FACE returns EMACS_INT, not int.
2675 * dispextern.h (merge_faces):
2676 * xfaces.c (merge_faces):
2677 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2678 Don't assume EMACS_INT fits in int.
2680 * character.h (CHAR_VALID_P): Remove unused parameter.
2681 * fontset.c, lisp.h, xdisp.c: All uses changed.
2683 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2685 * fns.c (concat): Minor tuning based on overflow analysis.
2686 This doesn't fix any bugs. Use int to hold character, instead
2687 of constantly refetching from Emacs object. Use XFASTINT, not
2688 XINT, for value known to be a character. Don't bother comparing
2689 a single byte to 0400, as it's always less.
2691 * floatfns.c (Fexpt):
2692 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2694 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2697 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2699 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2700 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2701 incorrectly succeed when S was a string, because 4294967386 was
2702 truncated before it was used.
2704 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2705 Otherwise, an out-of-range integer could cause undefined behavior
2708 * composite.c: Use int, not EMACS_INT, for characters.
2709 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2710 EMACS_INT, for values that are known to be in character range.
2711 This doesn't fix any bugs but is the usual style inside Emacs and
2712 may generate better code on 32-bit machines.
2714 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2715 This is for reasons similar to the recent CHAR_STRING fix.
2716 * charset.c (Fencode_char): Check that character arg is actually
2717 a character. Pass an int to ENCODE_CHAR.
2718 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2719 wider than 'int', as a compile-time check to prevent future regressions
2722 * character.c (char_string): Remove unnecessary casts.
2724 Make sure a 64-bit char is never passed to CHAR_STRING.
2725 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2726 by silently ignoring the top 32 bits, allowing some values
2727 that were far too large to be valid characters.
2728 * character.h: Include <verify.h>.
2729 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2730 arguments are no wider than unsigned, as a compile-time check
2731 to prevent future regressions in this area.
2733 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2734 (Fsubst_char_in_region):
2736 * xdisp.c (decode_mode_spec_coding):
2737 Adjust to CHAR_STRING's new requirement.
2738 * editfns.c (Finsert_char, Fsubst_char_in_region):
2739 * fns.c (concat): Check that character args are actually
2740 characters. Without this test, these functions did the wrong
2741 thing with wildly out-of-range values on 64-bit hosts.
2743 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2744 These casts should not be needed on 32-bit hosts, either.
2745 * keyboard.c (read_char):
2746 * lread.c (Fload): Remove casts to unsigned.
2748 * lisp.h (UNSIGNED_CMP): New macro.
2749 This fixes comparison bugs on 64-bit hosts.
2750 (ASCII_CHAR_P): Use it.
2751 * casefiddle.c (casify_object):
2752 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2753 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2754 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2755 * dispextern.h (FACE_FROM_ID):
2756 * keyboard.c (read_char): Use UNSIGNED_CMP.
2758 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2759 not to EMACS_INT, to avoid GCC warning.
2761 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2763 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2764 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2765 isn't needed on 32-bit machines.
2767 * buffer.c (Fgenerate_new_buffer_name):
2768 Use EMACS_INT for count, not int.
2769 (advance_to_char_boundary): Return EMACS_INT, not int.
2771 * data.c (Qcompiled_function): Now static.
2773 * window.c (window_body_lines): Now static.
2775 * image.c (gif_load): Rename local to avoid shadowing.
2777 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2778 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2779 * alloc.c (make_save_value): Integer argument is now of type
2781 (mark_object): Use ptrdiff_t, not int.
2782 * lisp.h (pD): New macro.
2783 * print.c (print_object): Use it.
2785 * alloc.c: Use EMACS_INT, not int, to count objects.
2786 (total_conses, total_markers, total_symbols, total_vector_size)
2787 (total_free_conses, total_free_markers, total_free_symbols)
2788 (total_free_floats, total_floats, total_free_intervals)
2789 (total_intervals, total_strings, total_free_strings):
2790 Now EMACS_INT, not int. All uses changed.
2791 (Fgarbage_collect): Compute overall total using a double, so that
2792 integer overflow is less likely to be a problem. Check for overflow
2793 when converting back to an integer.
2794 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2795 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2796 These were 'int' variables that could overflow on 64-bit hosts;
2797 they were never used, so remove them instead of repairing them.
2798 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2799 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2800 Previously, this ceilinged at INT_MAX, but that doesn't work on
2802 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2804 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2805 (allocate_vectorlike): Check for ptrdiff_t overflow.
2806 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2807 when a (possibly-narrower) signed value would do just as well.
2808 We prefer using signed arithmetic, to avoid comparison confusion.
2810 * alloc.c: Catch some string size overflows that we were missing.
2811 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2812 for convenience in STRING_BYTES_MAX.
2813 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2814 The definition here is exact; the one in lisp.h was approximate.
2815 (allocate_string_data): Check for string overflow. This catches
2816 some instances we weren't catching before. Also, it catches
2817 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2818 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2819 and ptrdiff_t and EMACS_INT are both 64 bits.
2821 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2822 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2823 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2825 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2827 * alloc.c (Fmake_string): Check for out-of-range init.
2829 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2831 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2833 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2835 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2836 xg_get_default_scrollbar_width.
2838 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2839 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2840 (style_changed_cb): Call update_theme_scrollbar_width and call
2841 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2842 all frames (Bug#8505).
2843 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2844 Call gtk_window_set_resizable if HAVE_GTK3.
2845 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2846 and height if HAVE_GTK3 (Bug#8505).
2847 (scroll_bar_width_for_theme): New variable.
2848 (update_theme_scrollbar_width): New function.
2849 (xg_get_default_scrollbar_width): Move code to
2850 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2851 (xg_initialize): Call update_theme_scrollbar_width.
2853 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2855 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2857 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2859 * frame.c (make_frame): Call other_buffer_safely instead of
2862 * window.c (temp_output_buffer_show): Call display_buffer with
2863 second argument Vtemp_buffer_show_specifiers and reset latter
2864 immediately after the call.
2865 (Vtemp_buffer_show_specifiers): New variable.
2866 (auto_window_vscroll_p, next_screen_context_lines)
2867 (Vscroll_preserve_screen_position): Remove leading asterisks from
2870 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2872 Fix minor problems found by GCC 4.6.0 static checking.
2873 * buffer.c (Qclone_number): Remove for now, as it's unused.
2874 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2875 (record_buffer): Remove unused local.
2876 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2877 (set_frame_buffer_list): Remove; unused.
2878 * frame.h (other_visible_frames): Remove decl.
2879 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2880 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2881 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2883 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2884 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2885 Define only if HAVE_GPM.
2886 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2887 (update_hints_inhibit): Remove; never set. All uses removed.
2888 * widgetprv.h (emacsFrameClassRec): Remove decl.
2889 * window.c (delete_deletable_window): Now returns void, since it
2890 wasn't returning anything.
2891 (compare_window_configurations): Remove unused locals.
2892 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2893 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2894 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2895 the same widths as pointers. This follows up on the 2011-05-06 patch.
2896 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2897 * xterm.h: Likewise.
2898 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2900 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2902 * makefile.w32-in: Update dependencies.
2903 (LISP_H): Add lib/intprops.h.
2905 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2907 * image.c (gif_load): Add animation frame delay to the metadata.
2908 (syms_of_image): Use DEFSYM. New symbol `delay'.
2910 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2912 * window.c (delete_deletable_window): Re-add.
2913 (Fset_window_configuration): Rewrite to handle dead buffers and
2914 consequently deletable windows.
2915 (window_tree, Fwindow_tree): Remove. Supply functionality in
2917 (compare_window_configurations): Simplify code.
2919 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2921 * image.c (imagemagick_load_image): Fix type mismatch.
2922 (Fimagemagick_types): Likewise.
2924 * window.h (replace_buffer_in_windows): Declare.
2926 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2928 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2929 Qclone_number. Remove external declaration of Qdelete_window.
2930 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2932 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2933 Run Qbuffer_list_update_hook if allowed.
2934 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2935 buffer list implementation.
2936 (other_buffer_safely): New function.
2937 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2938 calls to replace_buffer_in_windows and
2939 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2941 (record_buffer): Inhibit quitting and rewrite using quittable
2942 functions. Run Qbuffer_list_update_hook if allowed.
2943 (Frecord_buffer, Funrecord_buffer): New functions.
2944 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2945 Move switch-to-buffer to window.el.
2946 (bury-buffer): Move to window.el.
2947 (Vbuffer_list_update_hook): New variable.
2949 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2952 * window.h (resize_frame_windows): Move up in code.
2953 (Fwindow_frame): Remove EXFUN.
2954 (replace_buffer_in_all_windows): Remove prototype.
2955 (replace_buffer_in_windows_safely): Add prototype.
2957 * window.c: Declare Qdelete_window static again. Move down
2958 declaration of select_count.
2959 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2960 (Fother_window): Move to window.el.
2961 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2962 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2963 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2965 (replace_buffer_in_windows): Implement by calling
2966 Qreplace_buffer_in_windows.
2967 (replace_buffer_in_all_windows): Remove with some functionality
2968 moved into replace_buffer_in_windows_safely.
2969 (replace_buffer_in_windows_safely): New function.
2970 (select_window_norecord, select_frame_norecord): Move in front
2971 of run_window_configuration_change_hook. Remove now obsolete
2973 (Fset_window_buffer): Rewrite doc-string.
2974 Call Qrecord_window_buffer.
2975 (keys_of_window): Move binding for other-window to window.el.
2977 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2979 * dispextern.h (struct image): Replace data member, whose int_val
2980 and ptr_val fields were not used by anything, with a single
2983 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2984 (gif_clear_image, gif_load, imagemagick_load_image)
2985 (gs_clear_image, gs_load): Callers changed.
2987 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2989 * buffer.h: Include <time.h>, for time_t.
2990 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2992 Fix minor problems found by static checking.
2994 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2996 Make identifiers static if they are not used in other modules.
2997 * data.c (Qcompiled_function, Qframe, Qvector):
2998 * image.c (QimageMagick, Qsvg):
2999 * minibuf.c (Qmetadata):
3000 * window.c (resize_window_check, resize_root_window): Now static.
3001 * window.h (resize_window_check, resize_root_window): Remove decls.
3003 * window.c (window_deletion_count, delete_deletable_window):
3005 (window_body_lines): Now static.
3006 (Fdelete_other_windows_internal): Mark vars as initialized.
3007 Make sure 'resize_failed' is initialized.
3008 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3009 (resize_window_apply): Remove unused local.
3010 * window.h (delete_deletable_window): Remove decl.
3012 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3013 (imagemagick_load_image): Fix pointer signedness problem by changing
3014 last arg from unsigned char * to char *. All uses changed.
3015 Also, fix a local for similar reasons.
3016 Remove unused locals. Remove locals to avoid shadowing.
3017 (fn_rsvg_handle_free): Remove; unused.
3018 (svg_load, svg_load_image): Fix pointer signedness problem.
3019 (imagemagick_load_image): Don't use garbage pointer image_wand.
3021 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3023 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3025 * image.c (gif_load): Fix omitted cast error introduced by
3028 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3030 * window.h (resize_proportionally, orig_total_lines)
3031 (orig_top_line): Remove from window structure.
3032 (set_window_height, set_window_width, change_window_heights)
3033 (Fdelete_window): Remove prototypes.
3034 (resize_frame_windows): Remove duplicate declaration.
3036 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3038 * window.h (resize_frame_windows, resize_window_check)
3039 (delete_deletable_window, resize_root_window)
3040 (resize_frame_windows): Declare prototypes.
3042 * window.c (resize_window_apply): Make definition be "static" to
3043 match the prototype.
3045 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3047 * window.c: Remove declarations of Qwindow_size_fixed,
3048 window_min_size_1, window_min_size_2, window_min_size,
3049 size_window, window_fixed_size_p, enlarge_window, delete_window.
3050 Remove static from declaration of Qdelete_window, it's
3051 temporarily needed by Fbury_buffer.
3052 (replace_window): Don't assign orig_top_line and
3054 (Fdelete_window, delete_window): Remove. Window deletion is
3055 handled by window.el.
3056 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3057 Replace Fdelete_window calls with calls to Qdelete_window.
3058 (Fdelete_other_windows): Remove. Deleting other windows is
3059 handled by window.el.
3060 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3061 handled in window.el.
3062 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3063 Window minimum sizes are handled in window.el.
3064 (shrink_windows, size_window, set_window_height)
3065 (set_window_width, change_window_heights, window_height)
3066 (window_width, CURBEG, CURSIZE, enlarge_window)
3067 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3068 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3069 handled in window.el.
3070 (make_dummy_parent): Rename to make_parent_window and give it a
3071 second argument horflag.
3072 (make_window): Don't set resize_proportionally any more.
3073 (Fsplit_window): Remove. Windows are split in window.el.
3074 (save_restore_action, save_restore_orig_size)
3075 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3076 Resize mini windows in window.el.
3077 (grow_mini_window, shrink_mini_window): Implement by calling
3078 Qresize_root_window_vertically, resize_window_check and
3079 resize_window_apply.
3080 (saved_window, Fset_window_configuration, save_window_save):
3081 Do not handle orig_top_line, orig_total_lines, and
3082 resize_proportionally.
3083 (window_min_height, window_min_width): Move to window.el.
3084 (keys_of_window): Move bindings for delete-other-windows,
3085 split-window, delete-window and enlarge-window to window.el.
3087 * buffer.c: Temporarily extern Qdelete_window.
3088 (Fbury_buffer): Temporarily call Qdelete_window instead of
3089 Fdelete_window (Fbury_buffer will move to window.el soon).
3091 * frame.c (set_menu_bar_lines_1): Remove code handling
3092 orig_top_line and orig_total_lines.
3094 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3095 set_window_height but set heights directly.
3096 (change_frame_size_1): Use resize_frame_windows.
3098 * xdisp.c (init_xdisp): Don't use set_window_height but set
3101 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3102 Use resize_frame_windows instead of change_window_heights and run
3103 run_window_configuration_change_hook.
3105 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3106 instead of change_window_heights and run
3107 run_window_configuration_change_hook.
3109 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3111 * window.c (replace_window): Rename second argument REPLACEMENT to
3112 NEW. New third argument SETFLAG. Rewrite.
3113 (delete_window, make_dummy_parent): Call replace_window with
3115 (window_list_1): Move down in code.
3116 (run_window_configuration_change_hook): Move set_buffer part
3117 before select_frame_norecord part in order to unwind correctly.
3118 Rename count1 to count.
3119 (recombine_windows, delete_deletable_window, resize_root_window)
3120 (Fdelete_other_windows_internal)
3121 (Frun_window_configuration_change_hook, make_parent_window)
3122 (resize_window_check, resize_window_apply, Fresize_window_apply)
3123 (resize_frame_windows, Fsplit_window_internal)
3124 (Fdelete_window_internal, Fresize_mini_window_internal):
3126 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3128 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3130 * window.h (window): Add some new members to window structure -
3131 normal_lines, normal_cols, new_total, new_normal, clone_number,
3132 splits, nest, prev_buffers, next_buffers.
3133 (WINDOW_TOTAL_SIZE): Move here from window.c.
3134 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3136 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3138 (make_dummy_parent): Set new members of windows structure.
3139 (make_window): Move down in code. Handle new members of window
3141 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3142 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3143 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3144 (Fset_window_prev_buffers, Fwindow_next_buffers)
3145 (Fset_window_next_buffers, Fset_window_clone_number):
3147 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3148 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3150 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3151 Argument WINDOW can be now internal window too.
3152 (Fwindow_use_time): Move up in code.
3153 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3155 (Fset_window_configuration, saved_window)
3156 (Fcurrent_window_configuration, save_window_save): Handle new
3157 members of window structure.
3158 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3159 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3160 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3161 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3162 Qget_mru_window, Qresize_root_window,
3163 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3164 Qauto_buffer_name; staticpro them.
3166 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3168 * window.c (Fwindow_total_size, Fwindow_left_column)
3169 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3170 (Fwindow_list_1): New functions.
3171 (window_box_text_cols): Replace with window_body_cols.
3172 (Fwindow_width, Fscroll_left, Fscroll_right):
3173 Use window_body_cols instead of window_box_text_cols.
3174 (delete_window, Fset_window_configuration):
3175 Call delete_all_subwindows with window as argument.
3176 (delete_all_subwindows): Take a window as argument and not a
3178 (window_loop): Remove handling of GET_LRU_WINDOW and
3180 (Fget_lru_window, Fget_largest_window): Move to window.el.
3182 * window.h: Extern window_body_cols instead of
3183 window_box_text_cols. delete_all_subwindows now takes a
3184 Lisp_Object as argument.
3186 * indent.c (compute_motion, Fcompute_motion):
3187 Use window_body_cols instead of window_box_text_cols.
3189 * frame.c (delete_frame): Call delete_all_subwindows with root
3192 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3194 * fns.c (Fputhash): Document return value.
3196 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3198 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3200 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3202 Cons<->int and similar integer overflow fixes (Bug#8794).
3204 Check for overflow when converting integer to cons and back.
3205 * charset.c (Fdefine_charset_internal, Fdecode_char):
3206 Use cons_to_unsigned to catch overflow.
3207 (Fencode_char): Use INTEGER_TO_CONS.
3208 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3209 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3210 * data.c (long_to_cons, cons_to_long): Remove.
3211 (cons_to_unsigned, cons_to_signed): New functions.
3212 These signal an error for invalid or out-of-range values.
3213 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3214 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3215 * font.c (Ffont_variation_glyphs):
3216 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3217 * lisp.h: Include <intprops.h>.
3218 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3219 (cons_to_signed, cons_to_unsigned): New decls.
3220 (long_to_cons, cons_to_long): Remove decls.
3221 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3222 (Fprimitive_undo): Use CONS_TO_INTEGER.
3223 * xfns.c (Fx_window_property): Likewise.
3224 * xselect.c: Include <limits.h>.
3225 (x_own_selection, selection_data_to_lisp_data):
3226 Use INTEGER_TO_CONS.
3227 (x_handle_selection_request, x_handle_selection_clear)
3228 (x_get_foreign_selection, Fx_disown_selection_internal)
3229 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3230 (lisp_data_to_selection_data): Use cons_to_unsigned.
3231 (x_fill_property_data): Use cons_to_signed.
3232 Report values out of range.
3234 Check for buffer and string overflow more precisely.
3235 * buffer.h (BUF_BYTES_MAX): New macro.
3236 * lisp.h (STRING_BYTES_MAX): New macro.
3237 * alloc.c (Fmake_string):
3238 * character.c (string_escape_byte8):
3239 * coding.c (coding_alloc_by_realloc):
3240 * doprnt.c (doprnt):
3241 * editfns.c (Fformat):
3243 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3244 since they may not be the same number.
3245 * editfns.c (Finsert_char):
3246 * fileio.c (Finsert_file_contents):
3247 Likewise for BUF_BYTES_MAX.
3249 * image.c: Use ptrdiff_t, not int, for sizes.
3250 (slurp_file): Switch from int to ptrdiff_t.
3252 (slurp_file): Check that file size fits in both size_t (for
3253 malloc) and ptrdiff_t (for sanity and safety).
3255 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3256 if b->modtime has its maximal value.
3258 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3260 Don't assume time_t can fit into int.
3261 * buffer.h (struct buffer.modtime): Now time_t, not int.
3262 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3263 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3265 Minor fixes for signed vs unsigned integers.
3266 * character.h (MAYBE_UNIFY_CHAR):
3267 * charset.c (maybe_unify_char):
3268 * keyboard.c (read_char, reorder_modifiers):
3269 XINT -> XFASTINT, since the integer must be nonnegative.
3270 * ftfont.c (ftfont_spec_pattern):
3271 * keymap.c (access_keymap, silly_event_symbol_error):
3272 XUINT -> XFASTINT, since the integer must be nonnegative.
3273 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3274 since it makes no difference and we prefer signed.
3275 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3276 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3279 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3281 * window.h (Fwindow_frame): Declare.
3283 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3285 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3286 (SPARE_MEMORY): Always define.
3287 (LARGE_REQUEST): Remove.
3288 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3290 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3292 * lisp.h: Move EXFUNS for Fframe_root_window,
3293 Fframe_first_window and Fset_frame_selected_window to window.h.
3295 * window.h: Move EXFUNS for Fframe_root_window,
3296 Fframe_first_window and Fset_frame_selected_window here from
3299 * frame.c (Fwindow_frame, Fframe_first_window)
3300 (Fframe_root_window, Fframe_selected_window)
3301 (Fset_frame_selected_window): Move to window.c.
3302 (Factive_minibuffer_window): Move to minibuf.c.
3303 (Fother_visible_frames_p): New function.
3305 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3307 * window.c (decode_window, decode_any_window): Move up in code.
3308 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3309 (inhibit_frame_unsplittable): Remove unused variable.
3310 (Fwindow_buffer): Move up and rewrite doc-string.
3311 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3312 (Fwindow_prev): New functions.
3313 (Fwindow_frame): Move here from frame.c. Accept any window as
3315 (Fframe_root_window, Fframe_first_window)
3316 (Fframe_selected_window): Move here from frame.c. Accept frame
3317 or arbitrary window as argument. Update doc-strings.
3318 (Fminibuffer_window): Move up in code.
3319 (Fwindow_minibuffer_p): Move up in code and simplify.
3320 (Fset_frame_selected_window): Move here from frame.c.
3322 (Fselected_window, select_window, Fselect_window): Move up in
3323 code. Minor doc-string fixes.
3325 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3327 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3328 Do not assume that spare memory exists; that assumption is valid
3329 only if SYSTEM_MALLOC.
3330 (LARGE_REQUEST): New macro, so that the issue of large requests
3331 is separated from the issue of spare memory.
3333 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3335 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3338 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3340 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3343 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3345 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3347 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3349 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3350 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3352 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3354 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3356 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3358 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3359 (x_clipboard_manager_save): Add return value.
3360 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3362 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3363 Obey Vx_select_enable_clipboard_manager. Catch errors in
3364 x_clipboard_manager_save (Bug#8779).
3365 (Vx_select_enable_clipboard_manager): New variable.
3366 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3368 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3370 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3372 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3374 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3375 in the current matrix if keep_current_p is non-zero.
3377 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3379 * bidi.c (bidi_level_of_next_char): Fix last change.
3381 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3383 Support bidi reordering of text covered by display properties.
3385 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3386 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3387 (bidi_cache_search, bidi_cache_iterator_state)
3388 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3389 (bidi_level_of_next_char, bidi_move_to_visually_next):
3390 Support character positions inside a run of characters covered by a
3392 (bidi_paragraph_init, bidi_resolve_explicit_1)
3393 (bidi_level_of_next_char): Call bidi_fetch_char and
3394 bidi_fetch_char_advance instead of FETCH_CHAR and
3396 (bidi_init_it): Initialize new members.
3397 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3399 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3400 instead of using explicit *_CHAR codes.
3401 (bidi_resolve_explicit, bidi_resolve_weak):
3402 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3403 bidirectional text is supported only in multibyte buffers.
3404 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3405 it to initialize the frame_window_p member of struct bidi_it.
3406 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3407 (bidi_resolve_explicit, bidi_resolve_weak)
3408 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3409 bidi_it->nchars is non-positive.
3410 (bidi_level_of_next_char): Don't try to lookup the cache for the
3411 next/previous character if nothing is cached there yet, or if we
3412 were just reseat()'ed to a new position.
3414 * xdisp.c (set_cursor_from_row): Set start and stop points
3415 according to the row's direction when priming the loop that looks
3416 for the glyph on which to display cursor.
3417 (single_display_spec_intangible_p): Function deleted.
3418 (display_prop_intangible_p): Reimplement to call
3419 handle_display_spec instead of single_display_spec_intangible_p.
3420 Accept 3 additional arguments needed by handle_display_spec.
3421 This fixes incorrect cursor motion across display property with complex
3422 values: lists, `(when COND...)' forms, etc.
3423 (single_display_spec_string_p): Support property values that are
3424 lists with the argument STRING its top-level element.
3425 (display_prop_string_p): Fix the condition for processing a
3426 property that is a list to be consistent with handle_display_spec.
3427 (handle_display_spec): New function, refactored from the
3428 last portion of handle_display_prop.
3429 (compute_display_string_pos): Accept additional argument
3430 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3431 value of a `display' property is a "replacing spec".
3432 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3433 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3434 the display property, but just return a value indicating whether
3435 the display property will replace the characters it covers.
3436 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3437 frame_window_p members of struct bidi_it.
3438 (compute_display_string_pos, compute_display_string_end):
3440 (push_it): Accept second argument POSITION, where pop_it should
3441 jump to continue iteration.
3442 (reseat_1): Initialize bidi_it.disp_pos.
3444 * keyboard.c (adjust_point_for_property): Adjust the call to
3445 display_prop_intangible_p to its new signature.
3447 * dispextern.h (struct bidi_it): New member frame_window_p.
3448 (bidi_init_it): Update prototypes.
3449 (display_prop_intangible_p): Update prototype.
3450 (compute_display_string_pos, compute_display_string_end):
3452 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3455 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3457 Malloc failure behavior now depends on size of allocation.
3458 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3459 * lisp.h: Change signatures accordingly.
3460 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3461 All callers changed. (Bug#8762)
3463 * gnutls.c: Use Emacs's memory allocators.
3464 Without this change, the gnutls library would invoke malloc etc.
3465 directly, which causes problems on non-SYNC_INPUT hosts, and which
3466 runs afoul of improving memory_full behavior. (Bug#8761)
3467 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3468 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3469 xfree instead of the default malloc, realloc, free.
3470 (Fgnutls_boot): No need to check for memory allocation failure,
3471 since xmalloc does that for us.
3473 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3474 * category.c (hash_get_category_set):
3475 * ccl.c (ccl_driver):
3476 * charset.c (Fdefine_charset_internal):
3477 * charset.h (struct charset.hash_index):
3478 * composite.c (get_composition_id, gstring_lookup_cache)
3479 (composition_gstring_put_cache):
3480 * composite.h (struct composition.hash_index):
3481 * dispextern.h (struct image.hash):
3482 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3483 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3484 (hashfn_equal, hashfn_user_defined, make_hash_table)
3485 (maybe_resize_hash_table, hash_lookup, hash_put)
3486 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3487 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3488 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3489 * image.c (make_image, search_image_cache, lookup_image)
3490 (xpm_put_color_table_h):
3491 * lisp.h (struct Lisp_Hash_Table):
3492 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3493 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3494 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3495 * alloc.c (allocate_vectorlike):
3496 Check for overflow in vector size calculations.
3497 * ccl.c (ccl_driver):
3498 Check for overflow when converting EMACS_INT to int.
3499 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3500 need to be updated by these changes.
3501 * fns.c (make_hash_table, maybe_resize_hash_table):
3502 Check for integer overflow with large hash tables.
3503 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3504 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3505 (SXHASH_REDUCE): New macro.
3506 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3507 Use it instead of discarding useful hash info with large hash values.
3508 (sxhash_float): New function.
3509 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3510 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3511 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3512 Rewrite to use FIXNUM_BITS, as this simplifies things.
3513 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3514 Adjust signatures to match updated version of code.
3515 (consing_since_gc): Now EMACS_INT, since a single hash table can
3516 use more than INT_MAX bytes.
3518 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3520 Make it possible to build with GCC-4.6+ -O2 -flto.
3522 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3524 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3526 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3527 Call minibuffer-inactive-mode.
3529 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3531 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3532 Update dependencies.
3534 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3536 * data.c (init_data): Remove code for UTS, this system is not
3539 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3541 Don't force ./temacs to start in terminal mode.
3543 * frame.c (make_initial_frame): Initialize faces in all cases, not
3544 only when CANNOT_DUMP is defined.
3545 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3547 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3549 * dispnew.c (add_window_display_history): Use const for the string
3550 pointer. Remove declaration, not needed.
3552 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3554 Use 'inline', not 'INLINE'.
3555 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3556 * alloc.c, fontset.c (INLINE): Remove.
3557 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3558 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3559 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3560 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3561 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3563 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3565 Make it possible to run ./temacs.
3567 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3568 syms_of_callproc does the same thing. Remove test for
3569 "initialized", do it in the caller.
3570 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3572 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3574 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3575 (read_minibuf): Use get_minibuffer.
3576 (syms_of_minibuf): Use DEFSYM.
3577 (Qmetadata): New var.
3578 * data.c (Qbuffer): Don't make it static.
3579 (syms_of_data): Use DEFSYM.
3581 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3583 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3584 (CCL_CODE_MIN): New macro.
3586 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3588 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3590 * eval.c (Qdebug): Now static.
3591 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3592 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3593 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3595 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3597 * image.c: Various fixes to ImageMagick code comments.
3598 (Fimagemagick_types): Doc fix.
3600 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3602 Minor fixes prompted by GCC 4.6.0 warnings.
3604 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3606 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3607 (x_clipboard_manager_save_all): Move extern decl to ...
3608 * xterm.h: ... here, so that it can be checked for consistency.
3610 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3612 * xselect.c (x_clipboard_manager_save_frame)
3613 (x_clipboard_manager_save_all): New functions.
3614 (Fx_clipboard_manager_save): Lisp function deleted.
3616 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3617 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3619 * xterm.h: Update prototype.
3621 2011-05-28 William Xu <william.xwl@gmail.com>
3623 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3626 2011-05-28 Jim Meyering <meyering@redhat.com>
3628 Avoid a sign-extension bug in crypto_hash_function.
3629 * fns.c (to_uchar): Define.
3630 (crypto_hash_function): Use it to convert some newly-signed
3631 variables to unsigned, to avoid sign-extension bugs. For example,
3632 without this change, (md5 "truc") would evaluate to
3633 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3634 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3635 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3637 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3639 Integer overflow fixes.
3641 * dbusbind.c: Serial number integer overflow fixes.
3642 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3643 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3644 to hold a serial number that is too large for a fixnum.
3645 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3646 Check for serial numbers out of range. Decode any serial number
3647 that was so large that it became a float. (Bug#8722)
3649 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3650 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3651 Use XFASTINT rather than XUINT when numbers are nonnegative.
3652 (xd_append_arg, Fdbus_method_return_internal):
3653 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3654 arguments, check that Lisp number is nonnegative, rather than
3655 silently wrapping negative numbers around. (Bug#8722)
3656 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3659 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3661 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3663 ccl: add integer overflow checks
3664 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3665 (IN_INT_RANGE): New macros.
3666 (ccl_driver): Use them to check for integer overflow when
3667 decoding a CCL program. Many of the new checks are whether XINT (x)
3668 fits in int; it doesn't always, on 64-bit hosts. The new version
3669 doesn't catch all possible integer overflows, but it's an
3670 improvement. (Bug#8719)
3672 * alloc.c (make_event_array): Use XINT, not XUINT.
3673 There's no need for unsigned here.
3675 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3676 This follows up to the 2011-05-06 change that substituted uintptr_t
3677 for EMACS_INT. This case wasn't caught back then.
3679 Rework Fformat to avoid integer overflow issues.
3680 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3681 now (part of C89). Include <verify.h>.
3682 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3683 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3684 (Fformat): Avoid the prepass trying to compute sizes; it was only
3685 approximate and thus did not catch overflow reliably. Instead, walk
3686 through the format just once, formatting and computing sizes as we go,
3687 checking for integer overflow at every step, and allocating a larger
3688 buffer as needed. Keep track separately whether the format is
3689 multibyte. Keep only the most-recently calculated precision, rather
3690 than them all. Record whether each argument has been converted to
3691 string. Use EMACS_INT, not int, for byte and char and arg counts.
3692 Support field widths and precisions larger than INT_MAX. Avoid
3693 sprintf's undefined behavior with conversion specifications such as %#d
3694 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3695 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3696 formatting out-of-range floating point numbers with int
3699 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3701 * data.c: Avoid integer truncation in expressions involving floats.
3702 * data.c: Include <intprops.h>.
3703 (arith_driver): When there's an integer overflow in an expression
3704 involving floating point, convert the integers to floating point
3705 so that the resulting value does not suffer from catastrophic
3706 integer truncation. For example, on a 64-bit host (* 4
3707 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3708 Do not rely on undefined behavior after integer overflow.
3710 merge count_size_as_multibyte, parse_str_to_multibyte
3711 * character.c, character.h (count_size_as_multibyte):
3712 Rename from parse_str_to_multibyte; all uses changed.
3713 Check for integer overflow.
3714 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3715 since it's now a duplicate of the other. This is more of
3716 a character than a buffer op, so better that it's in character.c.
3717 * fns.c, print.c: Adjust to above changes.
3719 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3721 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3723 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3725 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3726 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3727 (x_clipboard_manager_save): Now static.
3728 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3730 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3731 (crypto_hash_function): Now static.
3732 Fix pointer signedness problems. Avoid unnecessary initializations.
3734 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3736 * termhooks.h (Vselection_alist): Make it terminal-local.
3738 * terminal.c (create_terminal): Initialize it.
3740 * xselect.c: Support for clipboard managers.
3741 (Vselection_alist): Move to termhooks.h as terminal-local var.
3742 (LOCAL_SELECTION): New macro.
3743 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3744 (symbol_to_x_atom): Remove gratuitous arg.
3745 (x_handle_selection_request, lisp_data_to_selection_data)
3746 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3747 (x_own_selection, x_get_local_selection, x_convert_selection):
3748 New arg, specifying work frame. Use terminal-local Vselection_alist.
3749 (some_frame_on_display): Delete unused function.
3750 (Fx_own_selection_internal, Fx_get_selection_internal)
3751 (Fx_disown_selection_internal, Fx_selection_owner_p)
3752 (Fx_selection_exists_p): New optional frame arg.
3753 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3754 (x_handle_selection_clear): Don't treat other terminals with the
3755 same keyboard specially. Use the terminal-local Vselection_alist.
3756 (x_clear_frame_selections): Use Frun_hook_with_args.
3758 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3760 * xterm.h: Add support for those atoms.
3762 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3764 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3765 (converted_selections, conversion_fail_tag): New global variables.
3766 (x_selection_request_lisp_error): Free the above.
3767 (x_get_local_selection): Remove unnecessary code.
3768 (x_reply_selection_request): Args changed; handle arbitrary array
3769 of converted selections stored in converted_selections.
3770 Separate the XChangeProperty and SelectionNotify steps.
3771 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3772 (x_convert_selection): New function.
3773 (x_handle_selection_event): Simplify.
3774 (x_get_foreign_selection): Don't ignore incoming requests while
3775 waiting for an answer; this will fail when we implement
3776 SAVE_TARGETS, and seems unnecessary anyway.
3777 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3778 (Vx_sent_selection_functions): Doc fix.
3780 2011-05-26 Leo Liu <sdl.web@gmail.com>
3782 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3784 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3786 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3788 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3789 for fringe update if it has periodic bitmap.
3790 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3791 and fringe_bitmap_periodic_p.
3793 * fringe.c (get_fringe_bitmap_data): New function.
3794 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3795 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3796 row. Mark glyph row for fringe update if periodicity changed.
3798 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3799 for fringe update unless it has periodic bitmap.
3801 2011-05-25 Kenichi Handa <handa@m17n.org>
3803 * xdisp.c (get_next_display_element): Set correct it->face_id for
3804 a static composition.
3806 2011-05-24 Leo Liu <sdl.web@gmail.com>
3809 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3811 * fns.c (crypto_hash_function, Fsha1): New function.
3812 (Fmd5): Use crypto_hash_function.
3813 (syms_of_fns): Add Ssha1.
3815 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3817 * gnutls.c: Remove unused macros.
3818 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3819 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3820 Remove macros that are defined and never used.
3821 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3823 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3825 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3826 (Fx_get_selection_internal): Minor cleanup.
3827 (Fx_own_selection_internal): Rename arguments for consistency with
3830 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3832 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3834 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3836 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3838 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3840 * dispnew.c (scrolling_window): Don't exclude the case that the
3841 last enabled row in the desired matrix touches the bottom boundary.
3843 2011-05-21 Glenn Morris <rgm@gnu.org>
3845 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3846 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3847 and add some more files.
3849 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3851 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3852 report_file_error introduced by the change from 2011-05-07.
3854 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3856 * systime.h (Time): Define only if emacs is defined.
3857 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3858 where the include path doesn't have X11/X.h by default. See
3859 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3861 2011-05-20 Kenichi Handa <handa@m17n.org>
3863 * composite.c (find_automatic_composition): Fix previous change.
3865 2011-05-20 Glenn Morris <rgm@gnu.org>
3867 * lisp.mk: New file, split from Makefile.in.
3868 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3869 (shortlisp): Remove.
3870 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3872 2011-05-19 Glenn Morris <rgm@gnu.org>
3874 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3875 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3876 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3877 (lisp): Set the order to that of loadup.el.
3878 (shortlisp): Make it a copy of $lisp.
3879 (SOME_MACHINE_LISP): Remove.
3880 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3881 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3883 2011-05-18 Kenichi Handa <handa@m17n.org>
3885 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3886 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3887 (find_automatic_composition): Mostly rewrite for efficiency.
3889 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3891 * makefile.w32-in: Update dependencies.
3893 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3895 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3896 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3898 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3900 Fix some integer overflow issues, such as string length overflow.
3902 * insdel.c (count_size_as_multibyte): Check for string overflow.
3904 * character.c (lisp_string_width): Check for string overflow.
3905 Use EMACS_INT, not int, for string indexes and lengths; in
3906 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3907 the resulting string length overflows an EMACS_INT; instead,
3908 report a string overflow if no precision given. When checking for
3909 precision exhaustion, use a check that cannot possibly have
3910 integer overflow. (Bug#8675)
3911 * character.h (lisp_string_width): Adjust to new signature.
3913 * alloc.c (string_overflow): New function.
3914 (Fmake_string): Use it. This doesn't change behavior, but saves
3915 a few bytes and will simplify future changes.
3916 * character.c (string_escape_byte8): Likewise.
3917 * lisp.h (string_overflow): New decl.
3919 Fixups, following up to the user-interface timestamp change.
3920 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3921 for UI timestamps, instead of unsigned long.
3922 * msdos.c (mouse_get_pos): Likewise.
3923 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3924 * w32gui.h (Time): Define by including "systime.h" rather than by
3925 declaring it ourselves. (Bug#8664)
3927 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3928 * image.c (clear_image_cache): Likewise.
3930 * term.c (term_mouse_position): Don't assume time_t wraparound.
3932 Be more systematic about user-interface timestamps.
3933 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3934 and sometimes 'EMACS_UINT', to represent these timestamps.
3935 This change causes it to use 'Time' uniformly, as that's what X uses.
3936 This makes the code easier to follow, and makes it easier to catch
3937 integer overflow bugs such as Bug#8664.
3938 * frame.c (Fmouse_position, Fmouse_pixel_position):
3939 Use Time, not unsigned long, for user-interface timestamps.
3940 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3941 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3942 * keyboard.h (last_event_timestamp): Likewise.
3943 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3944 * menu.h (xmenu_show): Likewise.
3945 * term.c (term_mouse_position): Likewise.
3946 * termhooks.h (struct input_event.timestamp): Likewise.
3947 (struct terminal.mouse_position_hook): Likewise.
3948 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3949 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3950 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3951 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3953 * menu.h, termhooks.h: Include "systime.h", for Time.
3955 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3956 Don't assume that the difference between two unsigned long values
3957 can fit into an integer. At this point, we know button_down_time
3958 <= event->timestamp, so the difference must be nonnegative, so
3959 there's no need to cast the result if double-click-time is
3960 nonnegative, as it should be; check that it's nonnegative, just in
3961 case. This bug is triggered when events are more than 2**31 ms
3962 apart (about 25 days). (Bug#8664)
3964 * xselect.c (last_event_timestamp): Remove duplicate decl.
3965 (x_own_selection): Remove needless cast to unsigned long.
3967 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3968 that always fit in int. Use a sentinel instead of a counter, to
3969 avoid a temp and to allay GCC's concerns about possible int overflow.
3970 * frame.h (struct frame): Use int for menu_bar_items_used
3971 instead of EMACS_INT, since it always fits in int.
3973 * menu.c (grow_menu_items): Check for int overflow.
3975 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3977 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3978 Before, the code was not consistent. These values cannot exceed
3979 2**31 - 1 so there's no need to make them unsigned.
3980 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3981 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3982 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3984 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3986 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3987 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3988 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3989 presumably because the widths might not match.
3991 * window.c (size_window): Avoid needless test at loop start.
3993 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3995 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3997 2011-05-12 Drew Adams <drew.adams@oracle.com>
3999 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4001 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4003 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4004 `width' to `bar_area_x' and `bar_area_width', respectively.
4005 (x_scroll_run): Take account of fringe background extension.
4007 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4008 Rename local vars `left' and `width' to `bar_area_x' and
4009 `bar_area_width', respectively.
4010 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4011 background extension.
4013 2011-05-10 Jim Meyering <meyering@redhat.com>
4015 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4017 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4019 * image.c (Finit_image_library): Return t for built-in image types,
4020 like pbm and xbm. (Bug#8640)
4022 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4024 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4026 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4028 * w32console.c (Fset_screen_color): Doc fix.
4029 (Fget_screen_color): New function.
4030 (syms_of_ntterm): Defsubr it.
4032 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4033 unlink the temporary file if Fcall_process didn't create it in the
4035 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4036 child process will be redirected to a file specified with `:file'.
4037 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4038 cue to call_process_cleanup not to close that handle.
4040 2011-05-07 Ben Key <bkey76@gmail.com>
4042 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4043 one of two shell specific rules, either bootstrap-temacs-CMD or
4044 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4045 to the previous implementation of the bootstrap-temacs rule.
4046 The bootstrap-temacs-CMD rule is similar to the previous
4047 implementation of the bootstrap-temacs rule except that it
4048 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4051 These changes, along with some changes to nt/configure.bat,
4052 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4053 earlier fix to add support for --cflags and --ldflags options
4054 that include quotes so that it works whether make uses cmd or
4057 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4059 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4060 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4062 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4063 a string. Handle both cases.
4064 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4065 (Fdbus_register_method): Use Qinvalid_function.
4067 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4069 * makefile.w32-in: Update dependencies.
4070 (LISP_H): Add inttypes.h and stdin.h.
4071 (PROCESS_H): Add unistd.h.
4073 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4075 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4076 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4078 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4080 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4082 * term.c (vfatal): Remove stray call to va_end.
4083 It's not needed and the C Standard doesn't allow it here anyway.
4085 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4086 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4088 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4091 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4093 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4095 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4097 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4099 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4101 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4102 * charset.c (Fdefine_charset_internal): Don't initialize
4103 charset.code_space[15]. The value was garbage, on hosts with
4104 32-bit int (Bug#8600).
4106 * lread.c (read_integer): Be more consistent with string-to-number.
4107 Use string_to_number to do the actual conversion; this avoids
4108 rounding errors and fixes some other screwups. Without this fix,
4109 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4110 (digit_to_number): Move earlier, for benefit of read_integer.
4111 Return -1 if the digit is out of range for the base, -2 if it is
4112 not a digit in any supported base. (Bug#8602)
4114 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4116 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4117 to match comment at start of function. This also removes a
4118 GCC warning about overflow in a 32+64-bit port.
4120 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4122 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4123 Reported by Stefan Monnier in
4124 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4125 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4126 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4128 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4129 (EMACS_UINTPTR): Likewise, with uintptr_t.
4131 * lisp.h: Prefer 64-bit EMACS_INT if available.
4132 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4133 on 32-bit hosts that have 64-bit int, so that they can access
4135 However, temporarily disable this change unless the temporary
4136 symbol WIDE_EMACS_INT is defined.
4138 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4140 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4141 This removes an assumption that EMACS_INT and long are the same
4142 width as pointers. The assumption is true for Emacs porting targets
4143 now, but we want to make other targets possible.
4144 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4145 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4146 In the rest of the code, change types of integers that hold casted
4147 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4148 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4149 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4150 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4151 No need to cast type when ORing.
4152 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4153 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4154 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4155 assume EMACS_INT is the same width as char *.
4156 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4157 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4158 Remove no-longer-needed casts.
4159 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4160 (xg_tool_bar_help_callback, xg_make_tool_item):
4161 Use EMACS_INTPTR to hold an integer
4162 that will be cast to void *; this can avoid a GCC warning
4163 if EMACS_INT is not the same width as void *.
4164 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4165 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4166 (current_message_1, set_message_1):
4167 Use a local to convert to proper width without a cast.
4168 * xmenu.c (dialog_selection_callback): Likewise.
4170 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4171 Also, don't assume VALBITS / RAND_BITS is less than 5,
4172 and don't rely on undefined behavior when shifting a 1 left into
4174 * lisp.h (get_random): Change signature to match.
4176 * lread.c (hash_string): Use size_t, not int, for hash computation.
4177 Normally we prefer signed values; but hashing is special, because
4178 it's better to use unsigned division on hash table sizes so that
4179 the remainder is nonnegative. Also, size_t is the natural width
4180 for hashing into memory. The previous code used 'int', which doesn't
4181 retain enough info to hash well into very large tables.
4182 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4184 * dbusbind.c: Don't possibly lose pointer info when converting.
4185 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4186 Use XPNTR rather than XHASH, so that the high-order bits of
4187 the pointer aren't lost when converting through void *.
4189 * eval.c (Fautoload): Don't double-shift a pointer.
4191 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4193 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4195 * gnutls.c (DEF_GNUTLS_FN):
4196 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4198 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4200 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4203 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4205 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4206 New version that can reserve upto 2GB of heap space.
4208 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4210 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4212 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4214 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4215 `gnutls_certificate_set_x509_key_file'.
4217 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4219 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4220 Update dependencies.
4222 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4224 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4225 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4226 Remove unused parameter `fildes'.
4227 * process.c (read_process_output, send_process): Don't pass it.
4229 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4231 Fix previous change: the library cache is defined in w32.c.
4232 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4233 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4235 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4237 Implement dynamic loading of GnuTLS on Windows.
4239 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4240 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4241 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4244 * gnutls.c (Qgnutls_dll): Define.
4245 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4246 (gnutls_*): Declare function pointers.
4247 (init_gnutls_functions): New function to initialize function pointers.
4248 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4249 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4250 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4251 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4252 (emacs_gnutls_write, emacs_gnutls_read)
4253 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4254 (Fgnutls_available_p): New function.
4255 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4256 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4257 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4259 * image.c: Include w32.h.
4260 (Vimage_type_cache): Delete.
4261 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4262 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4263 (w32_delayed_load): Move to w32.c.
4265 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4267 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4268 (w32_delayed_load): Move from image.c. When loading a library, record
4269 its filename in the :loaded-from property of the library id.
4270 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4271 Initialize and staticpro them.
4272 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4274 * process.c: Include lisp.h before w32.h, not after.
4275 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4276 instead of gnutls_record_check_pending.
4278 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4280 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4282 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4283 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4286 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4288 * xterm.c (x_set_frame_alpha): Do not set property on anything
4289 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4291 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4293 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4295 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4297 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4298 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4299 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4300 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4301 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4302 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4303 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4304 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4305 (Qgnutls_bootprop_callbacks_verify): Make static.
4307 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4309 * callproc.c: Indentation fixup.
4311 * sysdep.c (wait_for_termination_1): Make static.
4312 (wait_for_termination, interruptible_wait_for_termination):
4313 Move after wait_for_termination_1.
4315 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4317 * sysdep.c (interruptible_wait_for_termination): New function
4318 which is like wait_for_termination, but allows keyboard
4321 * callproc.c (Fcall_process): Add (:file "file") as an option for
4323 (Fcall_process_region): Ditto.
4325 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4327 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4328 rather than `XVECTOR (FOO)->size'.
4330 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4331 inttypes.h, as a gnulib replacement is used if it not available in
4334 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4336 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4337 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4338 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4340 * coding.c (coding_alloc_by_realloc): Error out if destination
4341 will grow beyond MOST_POSITIVE_FIXNUM.
4342 (decode_coding_emacs_mule): Abort if there isn't enough place in
4343 charbuf for the composition carryover bytes. Reserve an extra
4344 space for up to 2 characters produced in a loop.
4345 (decode_coding_iso_2022): Abort if there isn't enough place in
4346 charbuf for the composition carryover bytes.
4348 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4350 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4351 aborting when %lld or %lll format is passed.
4352 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4353 %llo or %llx format is passed. (Bug#8545)
4355 * window.c (window_scroll_line_based): Use a marker instead of
4356 simple variables to record original value of point. (Bug#7952)
4358 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4359 produced by %s or %c overflows available buffer space. (Bug#8545)
4361 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4363 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4364 (SIZE_MAX): Move defn after all includes, as they might #define it.
4366 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4368 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4370 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4372 * keyboard.c (Qdelayed_warnings_hook): Define.
4373 (command_loop_1): Run `delayed-warnings-hook'
4374 if Vdelayed_warnings_list is non-nil.
4375 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4376 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4378 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4380 * doprnt.c (doprnt): Don't return value smaller than the buffer
4381 size if the message was truncated. (Bug#8545).
4383 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4385 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4386 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4388 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4390 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4392 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4394 * makefile.w32-in: Update dependencies.
4396 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4398 Improve `doprnt' and its usage. (Bug#8545)
4399 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4400 `format_end'. Remove support for %l as a conversion specifier.
4401 Don't use xrealloc. Improve diagnostics when the %l size modifier
4402 is used. Update the commentary.
4404 * eval.c (verror): Simplify calculation of size_t.
4406 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4409 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4411 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4414 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4416 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4417 This makes this file independent of the recent pseudovector change.
4419 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4421 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4423 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4424 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4425 Remove unused local.
4426 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4428 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4429 GCC 4.6.0 optimizes based on type-based alias analysis.
4430 For example, if b is of type struct buffer * and v of type struct
4431 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4432 != &v->size, and therefore "v->size = 1; b->size = 2; return
4433 v->size;" must therefore return 1. This assumption is incorrect
4434 for Emacs, since it type-puns struct Lisp_Vector * with many other
4435 types. To fix this problem, this patch adds a new type struct
4436 vectorlike_header that documents the constraints on layout of vectors
4437 and pseudovectors, and helps optimizing compilers not get fooled
4438 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4439 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4440 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4442 (XSETPVECTYPE): Rewrite in terms of new macro.
4443 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4444 This is a bit clearer, and further avoids the possibility of
4445 undesirable aliasing.
4446 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4447 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4448 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4449 since Lisp_Subr is a special case (no "next" field).
4450 (ASIZE): Now uses header.size rather than size.
4451 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4452 to avoid the hassle of writing XVECTOR (foo)->header.size.
4453 (struct vectorlike_header): New type.
4454 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4455 object, to help avoid aliasing.
4456 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4457 (SUBRP): Likewise, since Lisp_Subr is a special case.
4458 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4459 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4460 (struct Lisp_Hash_Table): Combine first two members into a single
4461 struct vectorlike_header member. All uses of "size" and "next" members
4462 changed to be "header.size" and "header.next".
4463 * buffer.h (struct buffer): Likewise.
4464 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4465 * frame.h (struct frame): Likewise.
4466 * process.h (struct Lisp_Process): Likewise.
4467 * termhooks.h (struct terminal): Likewise.
4468 * window.c (struct save_window_data, struct saved_window): Likewise.
4469 * window.h (struct window): Likewise.
4470 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4471 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4472 * buffer.c (init_buffer_once): Likewise.
4473 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4475 * process.c (Fformat_network_address): Use local var for size,
4478 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4480 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4481 * data.c (atof): Remove decl; no longer used or needed.
4482 (digit_to_number): Move to lread.c.
4483 (Fstring_to_number): Use new string_to_number function, to be
4484 consistent with how the Lisp reader treats infinities and NaNs.
4485 Do not assume that floating-point numbers represent EMACS_INT
4486 without losing information; this is not true on most 64-bit hosts.
4487 Avoid double-rounding errors, by insisting on integers when
4488 parsing non-base-10 numbers, as the documentation specifies.
4489 * lisp.h (string_to_number): New decl, replacing ...
4490 (isfloat_string): Remove.
4491 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4492 (read1): Do not accept +. and -. as integers; this
4493 appears to have been a coding error. Similarly, do not accept
4494 strings like +-1e0 as floating point numbers. Do not report
4495 overflow for integer overflows unless the base is not 10 which
4496 means we have no simple and reliable way to continue.
4497 Break out the floating-point parsing into a new
4498 function string_to_number, so that Fstring_to_number parses
4499 floating point numbers consistently with the Lisp reader.
4500 (digit_to_number): Move here from data.c. Make it static inline.
4501 (E_CHAR, EXP_INT): Remove, replacing with ...
4502 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4503 (string_to_number): New function, replacing isfloat_string.
4504 This function checks for valid syntax and produces the resulting
4505 Lisp float number too. Rework it so that string-to-number
4506 no longer mishandles examples like "1.0e+". Use strtoumax,
4507 so that overflow for non-base-10 numbers is reported only when
4508 there's no portable and simple way to convert to floating point.
4510 * textprop.c (set_text_properties_1): Rewrite for clarity,
4511 and to avoid GCC warning about integer overflow.
4513 * intervals.h (struct interval): Use EMACS_INT for members
4514 where EMACS_UINT might cause problems. See
4515 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4516 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4517 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4519 (offset_intervals): Tell GCC not to worry about length overflow
4520 when negating a negative length.
4522 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4523 (overrun_check_free): Likewise.
4525 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4526 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4529 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4530 (gnutls_make_error): Rename local to avoid shadowing.
4531 (gnutls_emacs_global_deinit): ifdef out; not used.
4532 (Fgnutls_boot): Use const for pointer to readonly storage.
4533 Comment out unused local. Fix pointer signedness problems.
4535 * lread.c (openp): Don't stuff size_t into an 'int'.
4536 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4537 about possible signed overflow.
4539 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4540 (GDK_KEY_g): Don't define if already defined.
4541 (xg_prepare_tooltip): Avoid pointer signedness problem.
4542 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4544 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4545 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4547 * xfns.c (Fx_window_property): Simplify a bit,
4548 to make a bit faster and to avoid GCC 4.6.0 warning.
4549 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4551 * fns.c (internal_equal): Don't assume size_t fits in int.
4553 * alloc.c (compact_small_strings): Tighten assertion a little.
4555 Replace pEd with more-general pI, and fix some printf arg casts.
4556 * lisp.h (pI): New macro, generalizing old pEd macro to other
4557 conversion specifiers. For example, use "...%"pI"d..." rather
4558 than "...%"pEd"...".
4559 (pEd): Remove. All uses replaced with similar uses of pI.
4560 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4561 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4562 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4563 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4564 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4565 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4566 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4568 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4569 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4570 * print.c (safe_debug_print, print_object): Likewise.
4571 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4573 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4574 avoiding the 0 flag, which is not portable.
4575 * process.c (Fmake_network_process): Use pI to avoid cast.
4576 * region-cache.c (pp_cache): Likewise.
4577 * xdisp.c (decode_mode_spec): Likewise.
4578 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4579 behavior on 64-bit hosts with printf arg.
4580 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4581 (x_stop_queuing_selection_requests): Likewise.
4582 (x_get_window_property): Don't truncate byte count to an 'int'
4585 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4586 here, since it parses constructs like leading '-' and spaces,
4587 which are not wanted; and it overflows with large numbers.
4588 Instead, simply match F[0-9]+, which is what is wanted anyway.
4590 * alloc.c: Remove unportable assumptions about struct layout.
4591 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4592 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4593 (allocate_vectorlike, make_pure_vector): Use the new macros,
4594 plus offsetof, to remove unportable assumptions about struct layout.
4595 These assumptions hold on all porting targets that I know of, but
4596 they are not guaranteed, they're easy to remove, and removing them
4597 makes further changes easier.
4599 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4600 This doesn't fix a bug but makes the code clearer.
4601 (string_overrun_cookie): Now const. Use initializers that
4602 don't formally overflow signed char, to avoid warnings.
4603 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4604 can cause Emacs to crash when string overrun checking is enabled.
4605 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4606 multiple of sizeof (EMACS_INT); it need not be, if
4607 alignof(EMACS_INT) < sizeof (EMACS_INT).
4608 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4610 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4612 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4614 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4616 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4617 supposed to be handshaking. (Bug#8556)
4618 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4620 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4622 * lisp.h (Qdebug): List symbol.
4623 * eval.c (Qdebug): Restore global linkage.
4624 * keyboard.c (debug-on-event): New variable.
4625 (handle_user_signal): Break into debugger when debug-on-event
4626 matches the current signal symbol.
4628 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4630 * alloc.c (check_sblock, check_string_bytes)
4631 (check_string_free_list): Convert to standard C.
4633 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4635 * w32.c (emacs_gnutls_push): Fix typo.
4637 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4639 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4640 "cast to pointer from integer of different size".
4642 Improve doprnt and its use in verror. (Bug#8545)
4643 * doprnt.c (doprnt): Document the set of format control sequences
4644 supported by the function. Use SAFE_ALLOCA instead of always
4647 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4648 is one byte too soon. Don't use xrealloc; instead xfree and
4651 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4653 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4656 * gnutls.c: Renamed global_initialized to
4657 gnutls_global_initialized. Added internals for the
4658 :verify-hostname-error, :verify-error, and :verify-flags
4659 parameters of `gnutls-boot' and documented those parameters in the
4660 docstring. Start callback support.
4661 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4662 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4663 on error. Return error code.
4664 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4665 (emacs_gnutls_read): Likewise.
4666 (Fgnutls_boot): Return handshake error code.
4667 (emacs_gnutls_handle_error): New function.
4668 (wsaerror_to_errno): Likewise.
4670 * w32.h (emacs_gnutls_pull): Add prototype.
4671 (emacs_gnutls_push): Likewise.
4673 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4674 (emacs_gnutls_push): Likewise.
4676 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4678 * process.c (wait_reading_process_output): Check if GnuTLS
4679 buffered some data internally if no FDs are set for TLS
4682 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4683 (LIBS): Link to USER_LIBS.
4684 ($(BLD)/gnutls.$(0)): New target.
4686 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4688 * xdisp.c (handle_single_display_spec): Rename the
4689 display_replaced_before_p argument into display_replaced_p, to
4690 make it consistent with the commentary. Fix typos in the
4693 * textprop.c (syms_of_textprop): Remove dead code.
4694 (copy_text_properties): Delete obsolete commentary about an
4695 interface that was deleted long ago. Fix typos in the description
4698 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4699 to changes in oldXMenu/XMenu.h from 2011-04-16.
4700 <menu_help_message, prev_menu_help_message>: Constify.
4701 (IT_menu_make_room): menu->help_text is now `const char **';
4704 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4705 to changes in oldXMenu/XMenu.h from 2011-04-16.
4706 (struct XMenu): Declare `help_text' `const char **'.
4708 * xfaces.c <Qunspecified>: Make extern again.
4710 * syntax.c: Include sys/types.h before including regex.h, as
4713 * doc.c (get_doc_string): Improve the format passed to `error'.
4715 * doprnt.c (doprnt): Improve commentary.
4717 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4719 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4722 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4723 changes in globals.h immediately force recompilation.
4724 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4725 $(CURDIR)/s/ms-w32.h.
4726 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4728 * character.c (Fchar_direction): Function deleted.
4729 (syms_of_character): Don't defsubr it.
4730 <char-direction-table>: Deleted.
4732 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4734 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4735 * doprnt.c: Include limits.h.
4736 (SIZE_MAX): New macro.
4737 (doprnt): Return a size_t value. 2nd arg is now size_t.
4738 Many local variables are now size_t instead of int or unsigned.
4739 Improve overflow protection. Support `l' modifier for integer
4740 conversions. Support %l conversion. Don't assume an EMACS_INT
4741 argument for integer conversions and for %c.
4743 * lisp.h (doprnt): Restore prototype.
4745 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4748 * Makefile.in (base_obj): Add back doprnt.o.
4750 * deps.mk (doprnt.o): Add back prerequisites.
4751 (callint.o): Depend on character.h.
4753 * eval.c (internal_lisp_condition_case): Include the handler
4754 representation in the error message.
4755 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4756 when breaking from the loop.
4758 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4760 * callint.c (Fcall_interactively): When displaying error message
4761 about invalid control letter, pass the character's codepoint, not
4762 a pointer to its multibyte form. Improve display of the character
4763 in octal and display also its hex code.
4765 * character.c (char_string): Use %x to display the (unsigned)
4766 codepoint of an invalid character, to avoid displaying a bogus
4769 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4770 `error', not SYMBOL_NAME itself.
4772 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4773 character arguments to `error'.
4775 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4776 to `error' in error message about FINAL_CHAR argument. Make sure
4777 FINAL_CHAR is a character, and use %c when it is passed as
4778 argument to `error'.
4780 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4782 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4784 * w32.c: Include <time.h>.
4785 (sys_localtime): New function.
4787 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4789 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4791 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4793 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4795 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4798 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4800 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4801 gl_state.e_property when gl_state.object is Qt.
4803 * insdel.c (make_gap_larger): Remove limitation of buffer size
4806 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4808 * xdisp.c (lookup_glyphless_char_display)
4809 (produce_glyphless_glyph): Handle cons cell entry in
4810 glyphless-char-display.
4811 (Vglyphless_char_display): Document it.
4813 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4814 glyphless-char-display.
4816 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4818 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4820 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4822 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4823 definition for no-X builds.
4825 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4827 Static checks with GCC 4.6.0 and non-default toolkits.
4829 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4831 * process.c (keyboard_bit_set): Define only if SIGIO.
4832 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4833 (send_process): Repair possible setjmp clobbering.
4835 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4837 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4839 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4841 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4842 Define only if needed.
4844 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4845 by pacifying GCC about it. Maybe it's time to retire it?
4846 * xfaces.c (USG, __TIMEVAL__): Likewise.
4848 * dispextern.h (struct redisplay_interface): Rename param
4850 * termhooks.h (struct terminal): Likewise.
4851 * xterm.c (xembed_send_message): Likewise.
4853 * insdel.c (make_gap_smaller): Define only if
4854 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4856 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4859 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4860 so that we aren't warned about unused symbols.
4862 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4864 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4866 * xfns.c (x_real_positions): Mark locals as initialized.
4868 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4870 * xterm.c: Fix problems found by static analysis with other toolkits.
4871 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4872 (x_dispatch_event): Declare static if USE_GTK, and
4873 define if USE_GTK || USE_X_TOOLKIT.
4874 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4875 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4876 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4877 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4879 * xmenu.c (menu_help_callback): Pointer type fixes.
4880 Use const pointers when pointing at readonly data. Avoid pointer
4882 (FALSE): Remove unused macro.
4883 (update_frame_menubar): Remove unused decl.
4885 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4887 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4888 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4889 (single_menu_item): Rename local to avoid shadowing.
4891 * keyboard.c (make_lispy_event): Remove unused local var.
4893 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4894 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4896 * bitmaps: Change bitmaps from unsigned char back to the X11
4897 compatible char. Avoid the old compiler warnings about
4898 out-of-range initializers by using, for example, '\xab' rather
4901 * xgselect.c (xgselect_initialize): Check vs interface
4902 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4904 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4906 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4907 to read-only memory.
4909 * fns.c (vector): Remove; this old hack is no longer needed.
4911 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4913 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4915 * xrdb.c (x_load_resources): Omit unused local.
4917 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4918 (x_window): Rename locals to avoid shadowing.
4919 (USG): Use the kludged USG macro, to pacify gcc.
4921 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4922 (x_term_init): Remove local to avoid shadowing.
4924 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4926 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4927 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4929 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4931 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4933 Fix regex.c, syntax.c and friends for buffers > 2GB.
4934 * syntax.h (struct gl_state_s): Declare character position members
4937 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4939 * textprop.c (verify_interval_modification, interval_of):
4940 Declare arguments EMACS_INT.
4942 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4945 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4947 * indent.c (Fvertical_motion): Local variable it_start is now
4950 * regex.c (re_match, re_match_2, re_match_2_internal)
4951 (bcmp_translate, regcomp, regexec, print_double_string)
4952 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4953 (re_compile_pattern, re_exec): Declare arguments and local
4954 variables `size_t' and `ssize_t' and return values `regoff_t', as
4956 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4957 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4958 <compile_stack_type>: `size' and `avail' are now `size_t'.
4960 * regex.h <regoff_t>: Use ssize_t, not int.
4961 (re_search, re_search_2, re_match, re_match_2): Arguments that
4962 specify buffer/string position and length are now ssize_t and
4963 size_t. Return type is regoff_t.
4965 2011-04-16 Ben Key <bkey76@gmail.com>
4967 * nsfont.m: Fixed bugs in ns_get_family and
4968 ns_descriptor_to_entity that were caused by using free to
4969 deallocate memory blocks that were allocated by xmalloc (via
4970 xstrdup). This caused Emacs to crash when compiled with
4971 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4972 --enable-checking=xmallocoverrun). xfree is now used to
4973 deallocate these memory blocks.
4975 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4977 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4979 emacs_write: Accept and return EMACS_INT for sizes.
4980 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4982 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4983 Accept and return EMACS_INT.
4984 (emacs_gnutls_write): Return the number of bytes written on
4986 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4987 (emacs_read, emacs_write): Remove check for negative size, as the
4988 Emacs source code has been audited now.
4989 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4990 (emacs_read, emacs_write): Use it.
4991 * process.c (send_process): Adjust to the new signatures of
4992 emacs_write and emacs_gnutls_write. Do not attempt to store
4993 a byte offset into an 'int'; it might overflow.
4994 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4996 * sound.c: Don't assume sizes fit in 'int'.
4997 (struct sound_device.period_size, alsa_period_size):
4998 Return EMACS_INT, not int.
4999 (struct sound_device.write, vox_write, alsa_write):
5000 Accept EMACS_INT, not int.
5001 (wav_play, au_play): Use EMACS_INT to store sizes and to
5002 record read return values.
5004 2011-04-15 Ben Key <bkey76@gmail.com>
5006 * keyboard.c (Qundefined): Don't declare static since it is used
5008 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5009 static since they are used in nsfont.m.
5011 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5013 * process.c (Qprocessp): Don't declare static.
5014 * lisp.h (Qprocessp): Declare again.
5016 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5018 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5020 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5022 Improve C-level modularity by making more things 'static'.
5024 Don't publish debugger-only interfaces to other modules.
5025 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5026 (verify_bytepos, count_markers): Move decls to the only modules
5028 * region-cache.h (pp_cache): Likewise.
5029 * window.h (check_all_windows): Likewise.
5030 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5032 * sysdep.c (croak): Now static, if
5033 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5034 * syssignal.h (croak): Declare only if not static.
5036 * alloc.c (refill_memory_reserve): Now static if
5037 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5038 * lisp.h (refill_memory_reserve): Declare only if not static.
5040 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5041 Define only if USE_LUCID.
5043 * xrdb.c (x_customization_string, x_rm_string): Now static.
5045 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5046 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5048 * xdisp.c (draw_row_with_mouse_face): Now static.
5049 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5051 * window.h (check_all_windows): Mark externally visible.
5053 * window.c (window_deletion_count): Now static.
5055 * undo.c: Make symbols static if they're not exported.
5056 (last_undo_buffer, last_boundary_position, pending_boundary):
5059 * textprop.c (interval_insert_behind_hooks): Now static.
5060 (interval_insert_in_front_hooks): Likewise.
5062 * term.c: Make symbols static if they're not exported.
5063 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5064 (max_frame_lines, tty_set_terminal_modes):
5065 (tty_reset_terminal_modes, tty_turn_off_highlight):
5066 (get_tty_terminal): Now static.
5067 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5068 * termhooks.h (term_mouse_moveto): Do not declare if
5070 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5071 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5073 * sysdep.c: Make symbols static if they're not exported.
5074 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5076 (sigprocmask_set, full_mask): Remove; unused.
5077 (wait_debugging): Mark as visible.
5078 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5079 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5081 * syntax.c (syntax_temp): Define only if !__GNUC__.
5083 * sound.c (current_sound_device, current_sound): Now static.
5085 * search.c (searchbufs, searchbuf_head): Now static.
5087 * scroll.c (scroll_cost): Remove; unused.
5088 * dispextern.h (scroll_cost): Remove decl.
5090 * region-cache.h (pp_cache): Mark as externally visible.
5092 * process.c: Make symbols static if they're not exported.
5093 (process_tick, update_tick, create_process, chan_process):
5094 (Vprocess_alist, proc_buffered_char, datagram_access):
5095 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5096 (deactivate_process): Mark defn as static, as well as decl.
5097 * lisp.h (create_process): Remove decl.
5098 * process.h (chan_process, Vprocess_alist): Remove decls.
5100 * print.c: Make symbols static if they're not exported.
5101 (print_depth, new_backquote_output, being_printed, print_buffer):
5102 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5103 (print_interval, print_number_index, initial_stderr_stream):
5105 * lisp.h (Fprinc): Remove decl.
5106 (debug_output_compilation_hack): Mark as externally visible.
5108 * sysdep.c (croak): Move decl from here to syssignal.h.
5109 * syssignal.h (croak): Put it here, so the API can be checked when
5110 'croak' is called from dissociate_if_controlling_tty.
5112 * minibuf.c: Make symbols static if they're not exported.
5113 (minibuf_save_list, choose_minibuf_frame): Now static.
5114 * lisp.h (choose_minibuf_frame): Remove decl.
5116 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5118 * lread.c: Make symbols static if they're not exported.
5119 (read_objects, initial_obarray, oblookup_last_bucket_number):
5121 (make_symbol): Remove; unused.
5122 * lisp.h (initial_obarray, make_symbol): Remove decls.
5124 * keyboard.c: Make symbols static if they're not exported.
5125 (single_kboard, recent_keys_index, total_keys, recent_keys):
5126 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5127 (this_single_command_key_start, echoing, last_auto_save):
5128 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5129 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5130 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5131 (Vlispy_mouse_stem, double_click_count):
5133 (force_auto_save_soon): Define only if SIGDANGER.
5134 (ignore_mouse_drag_p): Now static if
5135 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5136 (print_help): Remove; unused.
5137 (stop_character, last_timer_event): Mark as externally visible.
5138 * keyboard.h (ignore_mouse_drag_p): Declare only if
5139 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5140 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5141 * lisp.h (echoing): Remove decl.
5142 (force_auto_save_soon): Declare only if SIGDANGER.
5143 * xdisp.c (redisplay_window): Simplify code, to make it more
5144 obvious that ignore_mouse_drag_p is not accessed if !defined
5145 USE_GTK && !defined HAVE_NS.
5147 * intervals.c: Make symbols static if they're not exported.
5148 (merge_properties_sticky, merge_interval_right, delete_interval):
5150 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5152 * insdel.c: Make symbols static if they're not exported.
5153 However, leave prepare_to_modify_buffer alone. It's never
5154 called from outside this function, but that appears to be a bug.
5155 (combine_after_change_list, combine_after_change_buffer):
5156 (adjust_after_replace, signal_before_change): Now static.
5157 (adjust_after_replace_noundo): Remove; unused.
5158 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5159 (signal_before_change): Remove decls.
5161 * indent.c (val_compute_motion, val_vmotion): Now static.
5163 * image.c: Make symbols static if they're not exported.
5164 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5166 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5167 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5169 * fringe.c (standard_bitmaps): Now static.
5170 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5172 * frame.c: Make symbols static if they're not exported.
5173 (x_report_frame_params, make_terminal_frame): Now static.
5174 (get_frame_param): Now static, unless HAVE_NS.
5175 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5176 (x_get_resource_string): Remove; not used.
5177 * frame.h (make_terminal_frame, x_report_frame_params):
5178 (x_get_resource_string); Remove decls.
5179 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5180 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5182 * font.c, fontset.c: Make symbols static if they're not exported.
5183 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5184 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5185 * font.c (font_close_object): Now static.
5186 * font.h (font_close_object): Remove.
5187 * fontset.c (FONTSET_OBJLIST): Remove.
5188 (free_realized_fontset) #if-0 the body, which does nothing.
5189 (face_suitable_for_char_p): #if-0, as it's never called.
5190 * fontset.h (face_suitable_for_char_p): Remove decl.
5191 * xfaces.c (face_at_string_position):
5192 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5193 since 0 is always ASCII.
5195 * fns.c (weak_hash_tables): Now static.
5197 * fileio.c: Make symbols static if they're not exported.
5198 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5199 (Vwrite_region_annotation_buffers): Now static.
5201 * eval.c: Make symbols static if they're not exported.
5202 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5203 * lisp.h (backtrace_list): Remove decl.
5205 * emacs.c: Make symbols static if they're not exported.
5206 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5207 (fatal_error_code, fatal_error_signal_hook, standard_args):
5209 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5210 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5211 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5212 * lisp.h (fatal_error_signal_hook): Remove decl.
5213 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5215 * editfns.c: Move a (normally-unused) function to its only use.
5216 * editfns.c, lisp.h (get_operating_system_release): Remove.
5217 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5218 worth the hassle of breaking this out.
5220 * xterm.c: Make symbols static if they're not exported.
5221 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5222 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5223 (x_destroy_window, x_delete_display):
5225 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5226 (x_mouse_leave): Remove; unused.
5227 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5228 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5229 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5231 (x_mouse_leave): Declare only if WINDOWSNT.
5232 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5233 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5236 * ftxfont.c: Make symbols static if they're not exported.
5237 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5239 * font.h (ftxfont_driver): Likewise.
5241 * xfns.c: Make symbols static if they're not exported.
5242 (x_last_font_name, x_display_info_for_name):
5243 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5244 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5245 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5246 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5247 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5248 (last_show_tip_args): Now static.
5249 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5250 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5251 (x_screen_planes): Remove; unused.
5252 * dispextern.h (x_screen_planes): Remove decl.
5254 * dispnew.c: Make symbols static if they're not exported.
5255 * dispextern.h (redraw_garbaged_frames, scrolling):
5256 (increment_row_positions): Remove.
5257 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5258 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5260 (redraw_garbaged_frames): Remove; unused.
5262 * xfaces.c: Make symbols static if they're not exported.
5263 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5265 * xterm.h (defined_color): Remove decls.
5266 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5267 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5268 (menu_face_changed_default, defined_color, free_realized_face):
5269 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5270 (ascii_face_of_lisp_face): Remove; unused.
5272 * xdisp.c: Make symbols static if they're not exported.
5273 * dispextern.h (scratch_glyph_row, window_box_edges):
5274 (glyph_to_pixel_coords, set_cursor_from_row):
5275 (get_next_display_element, set_iterator_to_next):
5276 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5277 (show_mouse_face): Remove decls
5278 * frame.h (message_buf_print): Likewise.
5279 * lisp.h (pop_message, set_message, check_point_in_composition):
5281 * xterm.h (set_vertical_scroll_bar): Likewise.
5282 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5283 (message_buf_print, scratch_glyph_row, displayed_buffer):
5284 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5285 (get_next_display_element, show_mouse_face, window_box_edges):
5286 (frame_to_window_pixel_xy, check_point_in_composition):
5287 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5288 (glyph_to_pixel_coords): Remove; unused.
5290 * dired.c (file_name_completion): Now static.
5292 * dbusbind.c (xd_in_read_queued_messages): Now static.
5294 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5295 * data.c (circular_list_error): Remove.
5297 * commands.h (last_point_position, last_point_position_buffer):
5298 (last_point_position_window): Remove decls.
5299 * keyboard.c: Make these variables static.
5301 * coding.h (coding, code_convert_region, encode_coding_gap):
5303 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5304 (iso_code_class, detect_coding, code_convert_region): Now static.
5305 (encode_coding_gap): Remove; unused.
5307 * chartab.c (chartab_chars, chartab_bits): Now static.
5309 * charset.h (charset_iso_8859_1): Remove decl.
5310 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5313 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5314 * ccl.c (Vccl_program_table): Now static.
5315 (check_ccl_update): Remove; unused.
5317 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5318 * category.h: ... from here.
5319 * category.c (check_category_table, set_category_set): Now static.
5321 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5322 * lisp.h: Remove these decls.
5324 * buffer.c (buffer_count): Remove unused var.
5326 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5327 so that it's not optimized away.
5328 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5329 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5330 exported only to the debugger.
5332 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5333 * atimer.h (run_all_atimers): Remove; not exported.
5335 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5336 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5337 was inaccessible from Lisp.
5338 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5339 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5341 alloc.c: Import and export fewer symbols, and remove unused items.
5342 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5344 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5345 it's not optimized away by whole-program optimization.
5346 (message_enable_multibyte, free_misc): Remove.
5347 (catchlist, handlerlist, mark_backtrace):
5348 Declare only if BYTE_MARK_STACK.
5349 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5350 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5351 (message_enable_multibyte): Remove decl.
5352 (free_misc, interval_free_list, float_block, float_block_index):
5353 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5354 (cons_free_list, last_marked_index):
5356 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5357 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5358 (mark_backtrace): Define only if BYTE_MARK_STACK.
5359 * xdisp.c (message_enable_multibyte): Now static.
5361 Declare Lisp_Object Q* variables to be 'static' if not exported.
5362 This makes it easier for human readers (and static analyzers)
5363 to see whether these variables are used from other modules.
5364 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5365 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5366 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5367 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5368 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5369 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5370 * xmenu.c, xselect.c:
5371 Declare Q* vars static if they are not used in other modules.
5372 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5373 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5374 Remove decls of unexported vars.
5375 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5377 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5379 Make Emacs functions such as Fatom 'static' by default.
5380 This makes it easier for human readers (and static analyzers)
5381 to see whether these functions can be called from other modules.
5382 DEFUN now defines a static function. To make the function external
5383 so that it can be used in other C modules, use the new macro DEFUE.
5384 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5385 (Finit_image_library):
5386 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5387 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5388 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5389 Remove decls, since these functions are now static.
5390 (Funintern, Fget_internal_run_time): New decls, since these functions
5391 were already external.
5393 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5394 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5395 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5396 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5397 * keyboard.c, keymap.c, lread.c:
5398 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5399 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5400 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5401 Mark functions with DEFUE instead of DEFUN,
5402 if they are used in other modules.
5403 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5404 decls for now-static functions.
5405 * buffer.h (Fdelete_overlay): Remove decl.
5406 * callproc.c (Fgetenv_internal): Mark as internal.
5407 * composite.c (Fremove_list_of_text_properties): Remove decl.
5408 (Fcomposition_get_gstring): New forward static decl.
5409 * composite.h (Fcomposite_get_gstring): Remove decl.
5410 * dired.c (Ffile_attributes): New forward static decl.
5411 * doc.c (Fdocumntation_property): New forward static decl.
5412 * eval.c (Ffetch_bytecode): New forward static decl.
5413 (Funintern): Remove extern decl; now in .h file where it belongs.
5414 * fileio.c (Fmake_symbolic_link): New forward static decl.
5415 * image.c (Finit_image_library): New forward static decl.
5416 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5417 * intervals.h (Fprevious_property_change):
5418 (Fremove_list_of_text_properties): Remove decls.
5419 * keyboard.c (Fthis_command_keys): Remove decl.
5420 (Fcommand_execute): New forward static decl.
5421 * keymap.c (Flookup_key): New forward static decl.
5422 (Fcopy_keymap): Now static.
5423 * keymap.h (Flookup_key): Remove decl.
5424 * process.c (Fget_process): New forward static decl.
5425 (Fprocess_datagram_address): Mark as internal.
5426 * syntax.c (Fsyntax_table_p): New forward static decl.
5427 (skip_chars): Remove duplicate decl.
5428 * textprop.c (Fprevious_property_change): New forward static decl.
5429 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5431 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5432 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5434 * editfns.c (Fformat): Remove unreachable code.
5436 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5438 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5441 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5443 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5444 when at ZV. (Bug#8487)
5446 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5448 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5450 * keyboard.c (parse_tool_bar_item): Likewise.
5451 * sound.c (sound_cleanup, alsa_close): Likewise.
5452 * termcap.c (tgetent): Likewise.
5453 * xfns.c (x_default_font_parameter): Likewise.
5454 * xsettings.c (read_and_apply_settings): Likewise.
5456 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5457 (overrun_check_free): Protoize.
5459 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5461 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5462 since callers should never pass a negative size.
5463 Change the signature to match that of plain 'read' and 'write'; see
5464 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5465 * lisp.h: Update prototypes of emacs_write and emacs_read.
5467 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5469 * xdisp.c (redisplay_window): Don't try to determine the character
5470 position of the scroll margin if the window start point w->startp
5471 is outside the buffer's accessible region. (Bug#8468)
5473 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5475 Fix write-region and its subroutines for buffers > 2GB.
5476 * fileio.c (a_write, e_write): Modify declaration of arguments and
5477 local variables to support buffers larger than 2GB.
5478 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5480 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5481 argument, local variables, and return value.
5483 * lisp.h: Update prototypes of emacs_write and emacs_read.
5485 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5487 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5489 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5491 Fix more problems found by GCC 4.6.0's static checks.
5493 * xdisp.c (vmessage): Use a better test for character truncation.
5495 * charset.c (load_charset_map): <, not <=, for optimization,
5496 and to avoid potential problems with integer overflow.
5497 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5498 * casetab.c (set_identity, shuffle): Likewise.
5499 * editfns.c (Fformat): Likewise.
5500 * syntax.c (skip_chars): Likewise.
5502 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5503 This also lets GCC 4.6.0 generate slightly better loop code.
5505 * callint.c (Fcall_interactively): <, not <=, for optimization.
5506 (Fcall_interactively): Count the number of arguments produced,
5507 not the number of arguments given. This is simpler and lets GCC
5508 4.6.0 generate slightly better code.
5510 * ftfont.c: Distingish more carefully between FcChar8 and char.
5511 The previous code passed unsigned char * to a functions like
5512 strlen and xstrcasecmp that expect char *, which does not
5513 conform to the C standard.
5514 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5515 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5516 char * when the C standard requires it.
5518 * keyboard.c (read_char): Remove unused var.
5520 * eval.c: Port to Windows vsnprintf (Bug#8435).
5522 (SIZE_MAX): Define if the headers do not.
5523 (verror): Do not give up if vsnprintf returns a negative count.
5524 Instead, grow the buffer. This ports to Windows vsnprintf, which
5525 does not conform to C99. Problem reported by Eli Zaretskii.
5526 Also, simplify the allocation scheme, by avoiding the need for
5527 calling realloc, and removing the ALLOCATED variable.
5529 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5531 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5532 But keep the doprint source code for now, as we might revamp it
5533 and use it again (Bug#8435).
5534 * lisp.h (doprnt): Remove.
5535 * Makefile.in (base_obj): Remove doprnt.o.
5536 * deps.mk (doprnt.o): Remove.
5538 error: Print 32- and 64-bit integers portably (Bug#8435).
5539 Without this change, on typical 64-bit hosts error ("...%d...", N)
5540 was used to print both 32- and 64-bit integers N, which relied on
5542 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5544 * lisp.h (error, verror): Mark as printf-like functions.
5545 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5546 Report overflow in size calculations when allocating printf buffer.
5547 Do not truncate output string at its first null byte.
5548 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5549 Truncate the output at a character boundary, since vsnprintf does not
5551 * charset.c (check_iso_charset_parameter): Convert internal
5552 character to string before calling 'error', since %c now has the
5554 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5555 overflow when computing char to be passed to 'error'. Do not
5556 pass Lisp_Object to 'error'; pass the integer instead.
5557 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5558 formatted with plain %d.
5560 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5562 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5564 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5566 * xterm.c (x_catch_errors): Remove duplicate declaration.
5568 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5570 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5572 2011-04-10 Jim Meyering <meyering@redhat.com>
5574 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5575 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5576 return ssize_t not "int", and use size_t as the buffer length.
5577 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5578 * gnutls.h: Update declarations.
5579 * process.c (read_process_output): Use ssize_t, to match.
5580 (send_process): Likewise.
5582 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5584 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5586 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5588 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5589 Use unsigned char, to match FcChar8 type definition.
5591 * xterm.c (handle_one_xevent):
5592 * xmenu.c (create_and_show_popup_menu):
5593 * xselect.c (x_decline_selection_request)
5594 (x_reply_selection_request): Avoid type-punned deref of X events.
5596 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5598 Fix some uses of `int' instead of EMACS_INT.
5599 * search.c (string_match_1, fast_string_match)
5600 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5601 (scan_buffer, find_next_newline_no_quit)
5602 (find_before_next_newline, search_command, Freplace_match)
5603 (Fmatch_data): Make some `int' variables be EMACS_INT.
5605 * xdisp.c (display_count_lines): 3rd argument and return value now
5606 EMACS_INT. All callers changed.
5607 (pint2hrstr): Last argument is now EMACS_INT.
5609 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5610 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5611 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5612 (decode_coding_utf_16, decode_coding_emacs_mule)
5613 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5614 (decode_coding_ccl, decode_coding_charset)
5615 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5616 (decode_coding_iso_2022, decode_coding_emacs_mule)
5617 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5618 <char_offset, last_offset>: Declare EMACS_INT.
5619 (encode_coding_utf_8, encode_coding_utf_16)
5620 (encode_coding_emacs_mule, encode_invocation_designation)
5621 (encode_designation_at_bol, encode_coding_iso_2022)
5622 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5623 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5625 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5626 (encode_invocation_designation): Last argument P_NCHARS is now
5628 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5629 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5631 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5634 * ccl.c (Fccl_execute_on_string): Declare some variables
5637 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5639 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5641 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5643 * process.c (Fformat_network_address): Doc fix.
5645 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5647 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5649 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5651 * keyboard.c (read_char): Call Lisp function help-form-show,
5652 instead of using internal_with_output_to_temp_buffer.
5653 (Qhelp_form_show): New var.
5654 (syms_of_keyboard): Use DEFSYM macro.
5656 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5658 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5660 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5662 * process.c (Flist_processes): Remove to Lisp.
5663 (list_processes_1): Delete.
5665 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5667 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5669 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5671 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5673 Fix more problems found by GCC 4.6.0's static checks.
5675 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5677 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5679 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5681 * xdisp.c (vmessage): Mark as a printf-like function.
5683 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5685 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5687 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5688 printf-like functions.
5689 (tiff_load): Add casts to remove these marks before passing them
5690 to system-supplied API.
5692 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5694 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5695 This avoids several warnings with gcc -Wstrict-overflow.
5696 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5697 directly, rather than having caller test rule sign. This avoids
5698 some unnecessary tests.
5699 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5700 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5701 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5703 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5704 (xfont_open): Avoid unnecessary tests.
5706 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5708 * composite.h, composite.c (composition_gstring_put_cache):
5709 Use EMACS_INT, not int, for length.
5711 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5712 breaking out part of COMPOSITION_DECODE_RULE.
5713 (COMPOSITION_DECODE_RULE): Use it.
5714 * composite.c (get_composition_id): Remove unused local vars,
5715 by using the new macro.
5717 * textprop.c (set_text_properties_1): Change while to do-while,
5718 since the condition is always true at first.
5720 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5721 (interval_deletion_adjustment): Return unsigned value.
5724 * process.c (list_processes_1, create_pty, read_process_output):
5725 (exec_sentinel): Remove vars that were set but not used.
5726 (create_pty): Remove unnecessary "volatile"s.
5727 (Fnetwork_interface_info): Avoid possibility of int overflow.
5728 (read_process_output): Do adaptive read buffering even if carryover.
5729 (read_process_output): Simplify nbytes computation if buffered.
5731 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5733 * syntax.c (scan_words): Remove var that was set but not used.
5734 (update_syntax_table): Use unsigned instead of int.
5736 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5737 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5738 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5740 * print.c (print_error_message): Avoid int overflow.
5742 * font.c (font_list_entities): Redo for clarity,
5743 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5745 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5746 (font_score): Avoid potential overflow in diff calculation.
5748 * fns.c (substring_both): Remove var that is set but not used.
5749 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5751 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5753 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5754 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5755 can always succeed if overflow has undefined behavior.
5757 * search.c (boyer_moore, wordify): Remove vars set but not used.
5758 (wordify): Omit three unnecessary tests.
5760 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5761 All callers changed. This avoids the need for an unused var.
5763 * casefiddle.c (casify_region): Remove var that is set but not used.
5765 * dired.c (file_name_completion): Remove var that is set but not used.
5767 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5769 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5770 (Finsert_file_contents): Remove unnecessary code checking fd.
5772 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5773 Check for integer overflow on size calculations.
5775 * buffer.c (Fprevious_overlay_change): Remove var that is set
5778 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5779 Remove vars that are set but not used.
5780 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5781 (timer_check_2): Mark vars as initialized.
5783 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5785 * image.c (lookup_image): Remove var that is set but not used.
5786 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5788 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5789 that are set but not used.
5791 * xfns.c (make_invisible_cursor): Don't return garbage
5792 if XCreateBitmapFromData fails (Bug#8410).
5794 * xselect.c (x_get_local_selection, x_handle_property_notify):
5795 Remove vars that are set but not used.
5797 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5798 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5800 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5801 Remove var that is set but not used.
5802 (scroll_bar_windows_size): Now size_t, not int.
5803 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5806 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5807 (map_tty_color) [!defined MSDOS]: Likewise.
5809 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5811 * coding.c: Remove vars that are set but not used.
5812 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5813 All callers changed.
5814 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5815 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5816 (decode_coding_charset): Remove vars that are set but not used.
5818 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5819 that is set but not used.
5821 * print.c (print_object): Remove var that is set but not used.
5823 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5824 The gnulib version avoids calling malloc in the usual case,
5825 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5826 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5827 * filelock.c (current_lock_owner): Likewise.
5828 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5829 * sysdep.c: Include allocator.h, careadlinkat.h.
5830 (emacs_no_realloc_allocator): New static constant.
5831 (emacs_readlink): New function.
5832 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5833 ../lib/careadlinkat.h.
5835 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5837 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5838 first non-nil return value).
5840 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5842 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5843 if not defined (Bug#8403).
5845 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5847 * xdisp.c (display_count_lines): Remove parameter `start',
5848 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5849 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5850 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5851 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5852 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5853 and thereabouts. All callers changed.
5854 (get_per_char_metric): Remove parameter `f', unused since
5855 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5857 2011-04-02 Jim Meyering <meyering@redhat.com>
5859 do not dereference NULL upon failed strdup
5860 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5861 (ns_get_family): Likewise.
5863 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5865 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5867 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5869 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5872 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5874 Add lexical binding.
5876 * window.c (Ftemp_output_buffer_show): New fun.
5877 (Fsave_window_excursion):
5878 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5880 * lread.c (lisp_file_lexically_bound_p): New function.
5881 (Fload): Bind Qlexical_binding.
5882 (readevalloop): Remove `evalfun' arg.
5883 Bind Qinternal_interpreter_environment.
5884 (Feval_buffer): Bind Qlexical_binding.
5885 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5887 (syms_of_lread): Declare `lexical-binding'.
5889 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5891 * keyboard.c (eval_dyn): New fun.
5892 (menu_item_eval_property): Use it.
5894 * image.c (parse_image_spec): Use Ffunctionp.
5896 * fns.c (concat, mapcar1): Accept byte-code-functions.
5898 * eval.c (Fsetq): Handle lexical vars.
5899 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5900 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5901 (FletX, Flet): Obey lexical binding.
5902 (Fcommandp): Handle closures.
5903 (Feval): New `lexical' arg.
5904 (eval_sub): New function extracted from Feval. Use it almost
5905 everywhere where Feval was used. Look up vars in lexical env.
5907 (Ffunctionp): Move from subr.el.
5908 (Ffuncall): Handle closures.
5909 (apply_lambda): Remove `eval_flags'.
5910 (funcall_lambda): Handle closures and new byte-code-functions.
5911 (Fspecial_variable_p): New function.
5912 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5913 but without exporting it to Lisp.
5915 * doc.c (Fdocumentation, store_function_docstring):
5916 * data.c (Finteractive_form): Handle closures.
5918 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5921 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5923 (exec_byte_code): New function extracted from Fbyte_code to handle new
5924 calling convention for byte-code-functions. Add new byte-codes.
5926 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5928 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5930 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5932 * xdisp.c (redisplay_internal): Fix prototype.
5934 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5936 * xdisp.c (SCROLL_LIMIT): New macro.
5937 (try_scrolling): Use it when setting scroll_limit.
5938 Limit scrolling to 100 screen lines.
5939 (redisplay_window): Even when falling back on "recentering",
5940 position point in the window according to scroll-conservatively,
5941 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5943 (try_scrolling): When point is above the window, allow searching
5944 as far as scroll_max, or one screenful, to compute vertical
5945 distance from PT to the scroll margin position. This prevents
5946 try_scrolling from unnecessarily failing when
5947 scroll-conservatively is set to a value slightly larger than the
5948 window height. Clean up the case of PT below the margin at bottom
5949 of window: scroll_max can no longer be INT_MAX. When aggressive
5950 scrolling is in use, don't let point enter the opposite scroll
5951 margin as result of the scroll.
5952 (syms_of_xdisp) <scroll-conservatively>: Document the
5953 threshold of 100 lines for never-recentering scrolling.
5955 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5957 * dispextern.h (move_it_by_lines):
5958 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5959 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5960 (message_log_check_duplicate): Remove parameters `prev_bol' and
5961 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5962 (redisplay_internal): Remove parameter `preserve_echo_area',
5963 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5965 * indent.c (Fvertical_motion):
5966 * window.c (window_scroll_pixel_based, Frecenter):
5967 Don't pass `need_y_p' to `move_it_by_lines'.
5969 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5971 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5972 steal a few bits to be more compact.
5973 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5974 Remove unneeded casts.
5976 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5978 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5980 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5981 binding" message (bug#7967).
5983 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5985 Fix more problems found by GCC 4.6.0's static checks.
5987 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5988 Remove unused local var.
5990 * editfns.c (Fmessage_box): Remove unused local var.
5992 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5993 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5994 Omit unused local vars.
5995 * window.c (shrink_windows): Omit unused local var.
5996 * menu.c (digest_single_submenu): Omit unused local var.
5997 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5998 Omit unused local var.
6000 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6001 Don't assume string length fits in int.
6002 (keyremap_step, read_key_sequence): Use size_t for sizes.
6003 (read_key_sequence): Don't check last_real_key_start redundantly.
6005 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6006 instead of alloca (Bug#8344).
6008 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6009 (Fbacktrace_frame): Don't assume nframes fits in int.
6011 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6013 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6016 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6018 * cm.c (calccost): Turn while-do into do-while, for clarity.
6020 * keyboard.c (syms_of_keyboard): Use the same style as later
6021 in this function when indexing through an array. This also
6022 works around GCC bug 48267.
6024 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6026 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6028 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6029 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6031 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6032 This avoids undefined behavior on integer overflow, and is a bit
6033 more convenient anyway since it is compared to a size_t variable.
6035 Variadic C functions now count arguments with size_t, not int.
6036 This avoids an unnecessary limitation on 64-bit machines, which
6037 caused (substring ...) to crash on large vectors (Bug#8344).
6038 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6039 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6040 All variadic functions and their callers changed accordingly.
6041 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6042 * data.c (arith_driver, float_arith_driver): Likewise.
6043 * editfns.c (general_insert_function): Likewise.
6044 * eval.c (struct backtrace.nargs, interactive_p)
6045 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6046 (funcall_lambda, mark_backtrace): Likewise.
6047 * fns.c (concat): Likewise.
6048 * frame.c (x_set_frame_parameters): Likewise.
6049 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6050 0 if not found, not -1. All callers changed.
6052 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6053 (stack_copy_size): Now size_t, not int.
6054 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6056 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6058 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6059 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6060 All callers changed.
6062 * lisp.h (multibyte_char_to_unibyte):
6063 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6064 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6065 * character.h (CHAR_TO_BYTE8):
6066 * cmds.c (internal_self_insert):
6067 * editfns.c (general_insert_function):
6068 * keymap.c (push_key_description):
6069 * search.c (Freplace_match):
6070 * xdisp.c (message_dolog, set_message_1): All callers changed.
6072 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6074 * keyboard.c (safe_run_hook_funcall): New function.
6075 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6076 don't set the hook to nil, but remove the offending function instead.
6077 (Qcommand_hook_internal): Remove, unused.
6078 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6079 Vcommand_hook_internal.
6081 * eval.c (enum run_hooks_condition): Remove.
6082 (funcall_nil, funcall_not): New functions.
6083 (run_hook_with_args): Call each function through a `funcall' argument.
6084 Remove `cond' argument, now redundant.
6085 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6086 (Frun_hook_with_args_until_failure): Adjust accordingly.
6087 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6089 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6091 * dispextern.h (string_buffer_position): Remove declaration.
6093 * print.c (strout): Remove parameter `multibyte', unused since
6094 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6096 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6097 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6098 All callers changed.
6100 * w32.c (_wsa_errlist): Use braces for struct initializers.
6102 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6103 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6104 All callers changed.
6105 (string_buffer_position): Likewise. Also, make static (it's never
6106 used outside xdisp.c).
6107 (cursor_row_p): Remove parameter `w', unused since
6108 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6109 (decode_mode_spec): Remove parameter `precision', introduced during
6110 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6111 All callers changed.
6113 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6115 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6117 2011-03-27 Anders Lindgren <andlind@gmail.com>
6119 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6120 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6121 (ns_update_auto_hide_menu_bar): New functions.
6122 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6123 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6124 ns_constrain_all_frames.
6125 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6126 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6128 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6130 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6132 2011-03-27 Glenn Morris <rgm@gnu.org>
6134 * syssignal.h: Replace RETSIGTYPE with void.
6135 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6136 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6137 Replace SIGTYPE with void everywhere.
6138 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6139 * s/template.h (SIGTYPE): Remove commented out definition.
6141 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6143 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6144 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6146 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6148 * w32.c (read_unc_volume): Use parameter `henum', instead of
6149 global variable `wget_enum_handle'.
6151 * keymap.c (describe_vector): Remove parameters `indices' and
6152 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6153 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6155 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6157 * keyboard.c (timer_check): Remove parameter `do_it_now',
6158 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6159 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6160 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6162 * keyboard.c (read_char):
6163 * w32menu.c (w32_menu_display_help):
6164 * xmenu.c (show_help_event, menu_help_callback):
6165 Adjust calls to `show_help_echo'.
6167 * gtkutil.c (xg_maybe_add_timer):
6168 * keyboard.c (readable_events):
6169 * process.c (wait_reading_process_output):
6170 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6172 * insdel.c (adjust_markers_gap_motion):
6173 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6174 (gap_left, gap_right): Don't call it.
6176 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6178 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6179 incurred during fontification.
6181 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6183 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6184 (DEFVAR_PER_BUFFER): Don't pass it.
6186 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6187 (scrolling_window): Don't pass it.
6189 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6191 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6193 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6195 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6196 of variables specific to SELinux and computation of `encoded_absname'.
6198 * image.c (XPutPixel): Remove unused variable `height'.
6200 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6202 * unexw32.c (get_section_info): Remove unused variable `section'.
6204 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6205 (system_process_attributes): Remove unused variable `sess'.
6206 (sys_read): Remove unused variable `err'.
6208 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6209 (w32_wnd_proc): Remove unused variable `isdead'.
6210 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6211 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6212 (x_create_tip_frame): Remove unused variable `tem'.
6214 * w32inevt.c (w32_console_read_socket):
6215 Remove unused variable `no_events'.
6217 * w32term.c (x_draw_composite_glyph_string_foreground):
6218 Remove unused variable `width'.
6220 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6222 * w32term.c (x_set_glyph_string_clipping):
6223 Don't pass uninitialized region to CombineRgn.
6225 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6227 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6228 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6229 (Fx_close_connection): Remove unused variable `i'.
6231 * w32font.c (w32font_draw): Return number of glyphs.
6232 (w32font_open_internal): Remove unused variable `i'.
6233 (w32font_driver): Add missing initializer.
6235 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6236 (fill_in_menu): Remove unused variable `items_added'.
6238 * w32term.c (last_mouse_press_frame): Remove static global variable.
6239 (w32_clip_to_row): Remove unused variable `f'.
6240 (x_delete_terminal): Remove unused variable `i'.
6242 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6243 (NOTHING): Remove unused static global variable.
6244 (uniscribe_check_otf): Remove unused variable `table'.
6245 (uniscribe_font_driver): Add missing initializers.
6247 2011-03-23 Julien Danjou <julien@danjou.info>
6249 * term.c (Fsuspend_tty, Fresume_tty):
6250 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6251 * window.c (temp_output_buffer_show):
6252 * insdel.c (signal_before_change):
6253 * frame.c (Fhandle_switch_frame):
6254 * fileio.c (Fdo_auto_save):
6255 * emacs.c (Fkill_emacs):
6256 * editfns.c (save_excursion_restore):
6257 * cmds.c (internal_self_insert):
6258 * callint.c (Fcall_interactively):
6259 * buffer.c (Fkill_all_local_variables):
6260 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6262 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6263 unconditionnaly since it does the check itself.
6265 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6267 Fix more problems found by GCC 4.5.2's static checks.
6269 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6270 the first time through the loop, since we know p0 < p1 then.
6271 This also avoids a gcc -Wstrict-overflow warning.
6273 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6274 leading to a memory leak, possible in functions like
6275 load_charset_map_from_file that can allocate an unbounded number
6276 of objects (Bug#8318).
6278 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6279 that could (at least in theory) be that large.
6281 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6282 This is less likely to overflow, and avoids undefined behavior if
6283 overflow does occur. All callers changed. Use strtoul to scan
6284 for the unsigned long integer.
6285 (pint2hrstr): Simplify and tune code slightly.
6286 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6288 * scroll.c (do_scrolling): Work around GCC bug 48228.
6289 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6291 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6292 This also avoids a warning with gcc -Wstrict-overflow.
6293 (validate_x_resource_name): Simplify count usage.
6294 This also avoids a warning with gcc -Wstrict-overflow.
6296 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6299 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6301 * process.c (Fmake_network_process): Use socklen_t, not int,
6302 where POSIX says socklen_t is required in portable programs.
6303 This fixes a porting bug on hosts like 64-bit HP-UX, where
6304 socklen_t is wider than int (Bug#8277).
6305 (Fmake_network_process, server_accept_connection):
6306 (wait_reading_process_output, read_process_output):
6309 * process.c: Rename or move locals to avoid shadowing.
6310 (list_processes_1, Fmake_network_process):
6311 (read_process_output_error_handler, exec_sentinel_error_handler):
6312 Rename or move locals.
6313 (Fmake_network_process): Define label "retry_connect" only if needed.
6314 (Fnetwork_interface_info): Fix pointer signedness.
6315 (process_send_signal): Add cast to avoid pointer signedness problem.
6316 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6317 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6319 Make tparam.h and terminfo.c consistent.
6320 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6321 Include tparam.h instead, since it declares them.
6322 * cm.h (PC): Remove extern decl; tparam.h now does this.
6323 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6324 * terminfo.c: Include tparam.h, to check interfaces.
6325 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6326 (tparam): Adjust signature to match interface in tparam.h;
6327 this removes some undefined behavior. Check that outstring and len
6328 are zero, which they always are with Emacs.
6329 * tparam.h (PC, BC, UP): New extern decls.
6331 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6332 (xftfont_open): Rename locals to avoid shadowing.
6334 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6335 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6336 (OTF_TAG_SYM): Omit macro if not needed.
6337 (ftfont_list): Remove unused local.
6338 (get_adstyle_property, ftfont_pattern_entity):
6339 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6340 Rename locals to avoid shadowing.
6342 * xfont.c (xfont_list_family): Mark var as initialized.
6344 * xml.c (make_dom): Now static.
6346 * composite.c (composition_compute_stop_pos): Rename local to
6348 (composition_reseat_it): Remove unused locals.
6349 (find_automatic_composition, composition_adjust_point): Likewise.
6350 (composition_update_it): Mark var as initialized.
6351 (find_automatic_composition): Mark vars as initialized,
6352 with a FIXME (Bug#8290).
6354 character.h: Rename locals to avoid shadowing.
6355 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6356 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6357 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6358 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6361 * textprop.c (property_change_between_p): Remove; unused.
6363 * intervals.c (interval_start_pos): Now static.
6365 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6367 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6368 Rename locals to avoid shadowing.
6370 * sound.c (wav_play, au_play, Fplay_sound_internal):
6371 Fix pointer signedness.
6372 (alsa_choose_format): Remove unused local var.
6373 (wav_play): Initialize a variable to 0, to prevent undefined
6374 behavior (Bug#8278).
6376 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6378 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6380 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6381 clobbering (Bug#8298).
6382 * sysdep.c (sys_subshell): Likewise.
6383 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6385 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6386 This should get cleaned up, so that child_setup has the
6387 same signature on all platforms.
6389 * callproc.c (call_process_cleanup): Now static.
6390 (relocate_fd): Rename locals to avoid shadowing.
6392 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6394 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6395 not to be necessary, and produces flickering.
6397 2011-03-20 Glenn Morris <rgm@gnu.org>
6399 * config.in: Remove file.
6401 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6403 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6404 are now in src/globals.h.
6405 (syms_of_minibuf): Remove spurious & from previous change.
6407 2011-03-20 Leo <sdl.web@gmail.com>
6409 * minibuf.c (completing-read-function): New variable.
6410 (completing-read-default): Rename from completing-read.
6411 (completing-read): Call completing-read-function.
6413 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6415 * xfaces.c (Fx_load_color_file):
6416 Read color file from absolute filename (bug#8250).
6418 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6420 * makefile.w32-in: Update dependencies.
6422 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6424 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6426 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6428 Fix more problems found by GCC 4.5.2's static checks.
6430 * process.c (make_serial_process_unwind, send_process_trap):
6431 (sigchld_handler): Now static.
6433 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6434 That way, the code declares only the vars that it needs.
6435 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6436 * s/cygwin.h (PTY_ITERATION): Likewise.
6437 * s/darwin.h (PTY_ITERATION): Likewise.
6438 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6440 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6441 * process.c (allocate_pty): Don't declare stb unless it's needed.
6443 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6444 (CONSTANTLIM): Remove; unused.
6445 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6446 Define only if needed.
6448 * unexelf.c (unexec): Name an expression,
6449 to avoid gcc -Wbad-function-cast warning.
6450 Use a different way to cause a compilation error if anyone uses
6451 n rather than nn, a way that does not involve shadowing.
6452 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6454 * deps.mk (unexalpha.o): Remove; unused.
6456 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6457 * unexec.h: New file.
6458 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6459 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6461 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6462 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6463 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6464 Change as necessary to match prototype in unexec.h.
6466 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6468 (back_comment, skip_chars): Mark vars as initialized.
6470 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6471 Rename locals to avoid shadowing.
6473 * lread.c (read1): Rewrite so as not to use empty "else".
6474 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6476 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6478 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6479 warning when compiling print.c.
6481 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6482 instead of using an uninitialized var.
6483 (font_sort_entities): Mark var as initialized.
6485 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6487 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6488 pointers to constants.
6489 (font_parse_fcname): Remove unused vars.
6490 (font_delete_unmatched): Now static.
6491 (font_get_spec): Remove; unused.
6492 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6493 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6494 Rename or move locals to avoid shadowing.
6496 * fns.c (require_nesting_list, require_unwind): Now static.
6497 (Ffillarray): Rename locals to avoid shadowing.
6499 * floatfns.c (domain_error2): Define only if needed.
6500 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6502 * alloc.c (mark_backtrace): Move decl from here ...
6503 * lisp.h: ... to here, so that it can be checked.
6505 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6506 (Fdefvar): Rewrite so as not to use empty "else".
6507 (lisp_indirect_variable): Name an expression,
6508 to avoid gcc -Wbad-function-cast warning.
6509 (Fdefvar): Rename locals to avoid shadowing.
6511 * callint.c (quotify_arg, quotify_args): Now static.
6512 (Fcall_interactively): Rename locals to avoid shadowing.
6513 Use const pointer when appropriate.
6515 * lisp.h (get_system_name, get_operating_system_release):
6516 Move decls here, to check interfaces.
6517 * process.c (get_operating_system_release): Move decl to lisp.h.
6518 * xrdb.c (get_system_name): Likewise.
6519 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6520 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6521 some of which prompt warnings from gcc -Wbad-function-cast.
6522 (Fformat_time_string, Fencode_time, Finsert_char):
6523 (Ftranslate_region_internal, Fformat):
6524 Rename or remove local vars to avoid shadowing.
6525 (Ftranslate_region_internal): Mark var as initialized.
6527 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6530 * lisp.h (eassert): Check that the argument compiles, even if
6531 ENABLE_CHECKING is not defined.
6533 * data.c (Findirect_variable): Name an expression, to avoid
6534 gcc -Wbad-function-cast warning.
6535 (default_value, arithcompare, arith_driver, arith_error): Now static.
6536 (store_symval_forwarding): Rename local to avoid shadowing.
6537 (Fmake_variable_buffer_local, Fmake_local_variable):
6538 Mark variables as initialized.
6539 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6541 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6542 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6543 Rename locals to avoid shadowing.
6544 (mark_stack): Move local variables into the #ifdef region where
6546 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6547 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6549 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6550 (GC_STRING_CHARS): Remove; not used.
6551 (Fmemory_limit): Cast sbrk's returned value to char *.
6553 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6554 avoids undefined behavior in theory.
6556 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6558 Use functions, not macros, for up- and down-casing (Bug#8254).
6559 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6560 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6561 to use the following functions instead of these macros.
6562 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6563 EMACS_INT, since callers assume the returned value fits in int.
6564 (upcase1): Likewise, for UPCASE_TABLE.
6565 (uppercasep, lowercasep, upcase): New static inline functions.
6566 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6567 the race-condition problem in the old DOWNCASE.
6569 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6570 Rename locals to avoid shadowing.
6571 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6572 (regex_compile, re_search_2, re_match_2_internal):
6573 Remove unused local vars.
6574 (FREE_VAR): Rewrite so as not to use empty "else",
6575 which gcc can warn about.
6576 (regex_compile, re_match_2_internal): Mark locals as initialized.
6577 (RETALLOC_IF): Define only if needed.
6578 (WORDCHAR_P): Likewise. This one is never needed, but is used
6579 only in a comment talking about a compiler bug, so put inside
6580 the #if 0 of that comment.
6581 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6582 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6585 * search.c (boyer_moore): Rename locals to avoid shadowing.
6586 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6587 (PREV_CHAR_BOUNDARY): Likewise.
6589 * search.c (simple_search): Remove unused var.
6591 * dired.c (compile_pattern): Move decl from here ...
6592 * lisp.h: ... to here, so that it can be checked.
6593 (struct re_registers): New forward decl.
6595 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6597 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6599 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6600 Rename locals to avoid shadowing.
6601 (Fvertical_motion): Mark locals as initialized.
6603 * casefiddle.c (casify_object, casify_region): Now static.
6604 (casify_region): Mark local as initialized.
6606 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6608 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6609 New macros, so that the caller can use some names other than
6610 gcpro1, gcpro2, etc.
6611 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6613 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6614 argument, for consistency with GCPRO2_VAR, etc: it is now the
6615 prefix of the variable, not the variable itself. All uses
6617 * dired.c (directory_files_internal, file_name_completion):
6618 Rename locals to avoid shadowing.
6620 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6621 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6622 dired.c's scmp function, had undefined behavior.
6623 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6624 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6625 * buffer.h: ... to here, because these macros use current_buffer,
6626 and the new implementation with inline functions needs to have
6627 current_buffer in scope now, rather than later when the macros
6629 (downcase, upcase1): New static inline functions.
6630 (DOWNCASE, UPCASE1): Reimplement using these functions.
6631 This avoids undefined behavior in expressions like
6632 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6633 from race conditions in accessing the global variables
6634 case_temp1 and case_temp2.
6635 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6636 * lisp.h (case_temp1, case_temp2): Remove their decls.
6637 * character.h (ASCII_CHAR_P): Move from here ...
6638 * lisp.h: ... to here, so that the inline functions mentioned
6641 * dired.c (directory_files_internal_unwind): Now static.
6643 * fileio.c (file_name_as_directory, directory_file_name):
6644 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6646 (file_name_as_directory): Use const pointers when appropriate.
6647 (Fexpand_file_name): Likewise. In particular, newdir might
6648 point at constant storage, so make it a const pointer.
6649 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6650 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6652 (Fset_file_times, Finsert_file_contents, auto_save_error):
6653 Rename locals to avoid shadowing.
6655 * minibuf.c (choose_minibuf_frame_1): Now static.
6656 (Ftry_completion, Fall_completions): Rename or remove locals
6659 * marker.c (bytepos_to_charpos): Remove; unused.
6661 * lisp.h (verify_bytepos, count_markers): New decls,
6662 so that gcc does not warn that these functions aren't declared.
6664 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6665 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6666 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6667 (copy_text): Remove unused local var.
6669 * filelock.c (within_one_second): Now static.
6670 (lock_file_1): Rename local to avoid shadowing.
6672 * buffer.c (fix_overlays_before): Mark locals as initialized.
6673 (fix_start_end_in_overlays): Likewise. This function should be
6674 simplified by using pointers-to-pointers, but that's a different
6676 (switch_to_buffer_1): Now static.
6677 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6678 (report_overlay_modification): Rename locals to avoid shadowing.
6680 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6681 Fix pointer signedness issue.
6682 (sys_subshell): Mark local as volatile if checking for lint,
6683 to suppress a gcc -Wclobbered warning that does not seem to be right.
6684 (MAXPATHLEN): Define only if needed.
6686 * process.c (serial_open, serial_configure): Move decls from here ...
6687 * systty.h: ... to here, so that they can be checked.
6689 * fns.c (get_random, seed_random): Move extern decls from here ...
6690 * lisp.h: ... to here, so that they can be checked.
6692 * sysdep.c (reset_io): Now static.
6693 (wait_for_termination_signal): Remove; unused.
6695 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6696 (copy_keymap_item, append_key, push_text_char_description):
6698 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6699 (DENSE_TABLE_SIZE): Remove; unused.
6700 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6701 (describe_map_tree):
6702 Rename locals to avoid shadowing.
6704 * keyboard.c: Declare functions static if they are not used elsewhere.
6705 (echo_char, echo_dash, cmd_error, top_level_2):
6706 (poll_for_input, handle_async_input): Now static.
6707 (read_char, kbd_buffer_get_event, make_lispy_position):
6708 (make_lispy_event, make_lispy_movement, apply_modifiers):
6709 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6710 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6711 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6712 (read_key_sequence, read_char): Mark locals as initialized.
6713 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6715 * keyboard.h (make_ctrl_char): New decl.
6716 (mark_kboards): Move decl here ...
6717 * alloc.c (mark_kboards): ... from here.
6719 * lisp.h (force_auto_save_soon): New decl.
6721 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6722 (DEFINE_DUMMY_FUNCTION): New macro.
6723 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6725 (main): Add casts to avoid warnings
6726 if GCC considers string literals to be constants.
6728 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6730 * dbusbind.c: Pointer signedness fixes.
6731 (xd_signature, xd_append_arg, xd_initialize):
6732 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6733 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6734 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6735 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6737 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6738 if GCC considers string literals to be constants.
6739 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6741 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6743 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6744 (print_preprocess, print_object): New macro to fix last change.
6746 * print.c (print_preprocess): Don't forget font objects.
6748 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6750 * emacs.c (USAGE3): Doc fixes.
6752 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6754 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6757 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6759 * lisp.h (VWindow_system, Qfile_name_history):
6760 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6761 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6762 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6764 * w32select.c: Don't #include "keyboard.h".
6765 (run_protected): Add extern declaration for waiting_for_input.
6767 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6768 * w32console.c (detect_input_pending, read_input_pending)
6769 (encode_terminal_code):
6770 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6771 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6772 (w32_system_caret_y, Qfile_name_history):
6773 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6774 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6775 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6776 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6777 * w32proc.c (Qlocal, report_file_error):
6778 * w32term.c (Vwindow_system, updating_frame):
6779 * w32uniscribe.c (initialized, uniscribe_font_driver):
6780 Remove unneeded extern declarations.
6782 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6784 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6786 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6788 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6789 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6790 These macros can no longer be used for assignment.
6792 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6793 Assign struct members directly, instead of using BUF_BEGV etc.
6794 (record_buffer_markers, fetch_buffer_markers): New functions for
6795 recording and fetching special buffer markers.
6796 (set_buffer_internal_1, set_buffer_temp): Use them.
6798 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6800 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6802 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6803 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6805 * xdisp.c (hscroll_window_tree):
6806 (reconsider_clip_changes): Use PT instead of BUF_PT.
6808 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6810 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6811 $(EMACS_ROOT)/lib/intprops.h.
6813 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6815 Fix more problems found by GCC 4.5.2's static checks.
6817 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6818 to unsigned char * to avoid compiler diagnostic.
6819 (xg_free_frame_widgets): Make it clear that a local variable is
6820 needed only if USE_GTK_TOOLTIP.
6821 (gdk_window_get_screen): Make it clear that this macro is needed
6822 only if USE_GTK_TOOLTIP.
6823 (int_gtk_range_get_value): New function, which avoids a diagnostic
6824 from gcc -Wbad-function-cast.
6825 (xg_set_toolkit_scroll_bar_thumb): Use it.
6826 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6827 diagnostic from gcc -Wbad-function-cast.
6828 (get_utf8_string, xg_get_file_with_chooser):
6829 Rename locals to avoid shadowing.
6830 (create_dialog): Move locals to avoid shadowing.
6832 * xgselect.c (xg_select): Remove unused var.
6834 * image.c (four_corners_best): Mark locals as initialized.
6835 (gif_load): Initialize transparent_p to zero (Bug#8238).
6836 Mark another local as initialized.
6837 (my_png_error, my_error_exit): Mark with NO_RETURN.
6839 * image.c (clear_image_cache): Now static.
6840 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6841 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6842 (x_edge_detection): Remove unnecessary cast that
6843 gcc -Wbad-function-cast diagnoses.
6844 (gif_load): Fix pointer signedness.
6845 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6846 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6848 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6850 Improve quality of tests for time stamp overflow.
6851 For example, without this patch (encode-time 0 0 0 1 1
6852 1152921504606846976) returns the obviously-bogus value (-948597
6853 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6854 reports time overflow. See
6855 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6856 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6857 * editfns.c: Include limits.h and intprops.h.
6858 (TIME_T_MIN, TIME_T_MAX): New macros.
6859 (time_overflow): Move earlier, to before first use.
6860 (hi_time, lo_time): New functions, for an accurate test for
6862 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6863 (Fget_internal_run_time): Don't assume time_t fits in int.
6864 (make_time): Use list2 instead of Fcons twice.
6865 (Fdecode_time): More accurate test for out-of-range times.
6866 (check_tm_member): New function.
6867 (Fencode_time): Use it, to test for out-of-range times.
6868 (lisp_time_argument): Don't rely on undefined left-shift and
6869 right-shift behavior when checking for time stamp overflow.
6871 * editfns.c (time_overflow): New function, refactoring common code.
6872 (Fformat_time_string, Fdecode_time, Fencode_time):
6873 (Fcurrent_time_string): Use it.
6875 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6876 * dired.c (make_time): Move to ...
6877 * editfns.c (make_time): ... here.
6878 * systime.h: Note the move.
6880 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6882 * fringe.c (update_window_fringes): Remove unused variables.
6884 * unexmacosx.c (copy_data_segment): Also copy __got section.
6887 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6889 * termcap.c [MSDOS]: Include "msdos.h".
6890 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6891 Constify `char *' arguments and their references according to
6892 prototypes in tparam.h.
6894 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6896 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6897 Adapt all references accordingly.
6899 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6901 2011-03-11 Tom Tromey <tromey@redhat.com>
6903 * buffer.c (syms_of_buffer): Remove obsolete comment.
6905 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6907 * termhooks.h (encode_terminal_code): Declare prototype.
6909 * msdos.c (encode_terminal_code): Don't declare prototype.
6911 * term.c (encode_terminal_code): Now external again, used by
6912 w32console.c and msdos.c.
6914 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6915 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6917 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6919 Fix some minor problems found by GCC 4.5.2's static checks.
6921 * fringe.c (update_window_fringes): Mark locals as initialized
6923 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6925 * alloc.c (mark_fringe_data): Move decl from here ...
6926 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6927 to check its interface.
6928 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6930 * fontset.c (free_realized_fontset): Now static.
6931 (Fset_fontset_font): Rename local to avoid shadowing.
6932 (fontset_font): Mark local as initialized.
6933 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6935 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6937 * xselect.c (x_disown_buffer_selections): Remove; not used.
6938 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6939 (x_own_selection, Fx_disown_selection_internal): Rename locals
6941 (x_handle_dnd_message): Remove local to avoid shadowing.
6943 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6944 so that the caller can use some name other than gcpro1.
6945 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6946 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6947 (Fx_backspace_delete_keys_p):
6948 Use them to avoid shadowing, and rename vars to avoid shadowing.
6949 (x_decode_color, x_set_name, x_window): Now static.
6950 (Fx_create_frame): Add braces to silence GCC warning.
6951 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6952 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6953 Remove unused locals.
6954 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6955 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6956 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6959 * xterm.h (x_mouse_leave): New decl.
6961 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6962 Remove unused functions.
6963 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6964 (x_calc_absolute_position): Now static.
6965 (XTread_socket): Don't define label "out" unless it's used.
6966 Don't declare local "event" unless it's used.
6967 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6968 unless they are used.
6969 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6970 (x_fatal_error_signal): Remove; not used.
6971 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6972 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6973 (x_error_catcher, x_connection_closed, x_error_handler):
6974 (x_error_quitter, xembed_send_message, x_iconify_frame):
6975 (my_log_handler): Rename locals to avoid shadowing.
6976 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6977 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6979 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6980 Rename or move locals to avoid shadowing.
6981 (tty_defined_color, merge_face_heights): Now static.
6982 (free_realized_faces_for_fontset): Remove; not used.
6983 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6984 does not deduce is never used uninitialized.
6985 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6986 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6988 * terminal.c (store_terminal_param): Now static.
6990 * xmenu.c (menu_highlight_callback): Now static.
6991 (set_frame_menubar): Remove unused local.
6992 (xmenu_show): Rename parameter to avoid shadowing.
6993 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6994 since they might point to immutable storage.
6995 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6996 since it's unused otherwise.
6998 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6999 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7000 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7001 avoids a gcc -Wuninitialized diagnostic.
7002 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7003 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7004 does not deduce are never used uninitialized.
7006 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7008 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7009 * window.c (window_loop, size_window):
7010 (run_window_configuration_change_hook, enlarge_window): Likewise.
7012 * window.c (display_buffer): Now static.
7013 (size_window): Mark variables that gcc -Wuninitialized
7014 does not deduce are never used uninitialized.
7015 * window.h (check_all_windows): New decl, to forestall
7016 gcc -Wmissing-prototypes diagnostic.
7017 * dispextern.h (bidi_dump_cached_states): Likewise.
7019 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7021 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7023 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7024 and to avoid gcc -Wuninitialized warning.
7025 (load_charset_map): Mark variables that gcc -Wuninitialized
7026 does not deduce are never used uninitialized.
7027 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7029 * coding.c (coding_set_source, coding_set_destination):
7030 Use "else { /* comment */ }" rather than "else /* comment */;"
7031 for clarity, and to avoid gcc -Wempty-body warning.
7032 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7033 a block, when the outer 'i' will do.
7034 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7035 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7036 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7037 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7038 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7039 Rename locals to avoid shadowing.
7040 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7041 * coding.c (emacs_mule_char, encode_invocation_designation):
7042 Now static, since they're not used elsewhere.
7043 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7044 (decode_coding_object, encode_coding_object, detect_coding_system):
7045 (decode_coding_emacs_mule): Mark variables that gcc
7046 -Wuninitialized does not deduce are never used uninitialized.
7047 (detect_coding_iso_2022): Initialize a local variable that might
7048 be used uninitialized. Leave a FIXME because it's not clear that
7049 this initialization is needed. (Bug#8211)
7050 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7051 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7052 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7053 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7054 Remove unused macros.
7056 * category.c (hash_get_category_set): Remove unused local var.
7057 (copy_category_table): Now static, since it's not used elsewhere.
7058 * character.c (string_count_byte8): Likewise.
7060 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7061 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7063 * chartab.c (copy_sub_char_table): Now static, since it's not used
7065 (sub_char_table_ref_and_range, char_table_ref_and_range):
7066 Rename locals to avoid shadowing.
7067 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7069 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7070 (BIDI_BOB): Remove unused macro.
7072 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7073 deduce are never used uninitialized.
7074 * term.c (encode_terminal_code): Likewise.
7076 * term.c (encode_terminal_code): Now static. Remove unused local.
7078 * tparam.h: New file.
7079 * term.c, tparam.h: Include it.
7080 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7081 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7082 Move these decls to tparam.h, and make them agree with what
7083 is actually in tparam.c. The previous trick of using incompatible
7084 decls in different modules does not conform to the C standard.
7085 All callers of tparam changed to use tparam's actual API.
7086 * tparam.c (tparam1, tparam, tgoto):
7087 Use const pointers where appropriate.
7089 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7090 * cm.h (struct cm): Likewise.
7091 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7092 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7093 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7094 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7095 (turn_on_face, init_tty): Likewise.
7096 * termchar.h (struct tty_display_info): Likewise.
7098 * term.c (term_mouse_position): Rename local to avoid shadowing.
7100 * alloc.c (mark_ttys): Move decl from here ...
7101 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7103 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7105 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7107 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7109 * search.c (compile_pattern_1): Remove argument regp, unused since
7110 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7111 (compile_pattern): Don't pass it.
7113 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7115 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7116 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7118 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7120 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7122 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7123 gdk_window_get_screen, gdk_window_get_geometry,
7124 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7125 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7126 (xg_get_pixbuf_from_pixmap): New function.
7127 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7128 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7129 Call xg_get_pixbuf_from_pixmap instead of
7130 gdk_pixbuf_get_from_drawable.
7131 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7132 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7133 (xg_check_special_colors): Use GtkStyleContext and its functions
7135 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7136 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7137 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7138 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7139 Call gtk_widget_get_preferred_size.
7140 (xg_frame_resized): gdk_window_get_geometry only takes 5
7142 (xg_win_to_widget, xg_event_is_for_menubar):
7143 Call gdk_x11_window_lookup_for_display.
7144 (xg_set_widget_bg): New function.
7145 (delete_cb): New function.
7146 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7147 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7148 (xg_set_background_color): Call xg_set_widget_bg.
7149 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7150 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7151 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7152 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7154 (update_frame_tool_bar): Call gtk_widget_hide.
7155 (xg_initialize): Use GDK_KEY_g.
7157 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7159 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7161 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7162 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7163 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7165 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7167 * w32xfns.c (select_palette): Check success of RealizePalette against
7168 GDI_ERROR, not zero.
7170 See ChangeLog.11 for earlier changes.
7176 Copyright (C) 2011 Free Software Foundation, Inc.
7178 This file is part of GNU Emacs.
7180 GNU Emacs is free software: you can redistribute it and/or modify
7181 it under the terms of the GNU General Public License as published by
7182 the Free Software Foundation, either version 3 of the License, or
7183 (at your option) any later version.
7185 GNU Emacs is distributed in the hope that it will be useful,
7186 but WITHOUT ANY WARRANTY; without even the implied warranty of
7187 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7188 GNU General Public License for more details.
7190 You should have received a copy of the GNU General Public License
7191 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.