* gnutls.c (emacs_gnutls_write): Fix last change.
[bpt/emacs.git] / src / ChangeLog
1 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2
3 * gnutls.c (emacs_gnutls_write): Fix last change.
4
5 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6
7 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
8 send_process.
9
10 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
11
12 * keymap.c (Fsingle_key_description): Handle char ranges.
13
14 2012-02-12 Chong Yidong <cyd@gnu.org>
15
16 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
17 as that creates a dangerous corner case.
18
19 * window.c (Fdelete_window_internal): Invalidate the mouse
20 highlight (Bug#9904).
21
22 2012-02-12 Glenn Morris <rgm@gnu.org>
23
24 * xselect.c (Fx_own_selection_internal)
25 (Fx_get_selection_internal, Fx_disown_selection_internal)
26 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
27 * nsselect.m (Fx_own_selection_internal)
28 (Fx_disown_selection_internal, Fx_selection_exists_p)
29 (Fx_selection_owner_p, Fx_get_selection_internal):
30 Sync docs and argument specs with the xselect.c versions.
31
32 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
33
34 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
35
36 2012-02-11 Eli Zaretskii <eliz@gnu.org>
37
38 * w32select.c (Fx_selection_exists_p): Sync doc string and
39 argument list with xselect.c. (Bug#10783)
40
41 * w16select.c (Fx_selection_exists_p): Sync doc string and
42 argument list with xselect.c. (Bug#10783)
43
44 2012-02-10 Glenn Morris <rgm@gnu.org>
45
46 * fns.c (Fsecure_hash): Doc fix.
47
48 2012-02-09 Kenichi Handa <handa@m17n.org>
49
50 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
51
52 2012-02-07 Chong Yidong <cyd@gnu.org>
53
54 * buffer.c (Fbuffer_local_variables)
55 (buffer_lisp_local_variables): Handle unbound vars correctly;
56 don't let Qunbound leak into Lisp.
57
58 2012-02-07 Glenn Morris <rgm@gnu.org>
59
60 * image.c (Fimagemagick_types): Doc fix.
61
62 * image.c (imagemagick-render-type): Change it from a lisp object
63 to an integer. Move the doc here from the lisp manual.
64 Treat all values not equal to 0 the same.
65
66 2012-02-06 Chong Yidong <cyd@gnu.org>
67
68 * doc.c (store_function_docstring): Avoid applying docstring of
69 alias to base function (Bug#2603).
70
71 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
72
73 * .gdbinit (pp1, pv1): Remove redundant defines.
74 (pr): Use pp.
75
76 2012-02-04 Chong Yidong <cyd@gnu.org>
77
78 * nsterm.m: Declare a global (Bug#10694).
79
80 2012-02-04 Eli Zaretskii <eliz@gnu.org>
81
82 * w32.c (get_emacs_configuration_options): Include
83 --enable-checking, if specified, in the return value.
84
85 2012-02-04 Martin Rudalics <rudalics@gmx.at>
86
87 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
88 after rounding frame sizes. (Bug#9723)
89
90 2012-02-04 Eli Zaretskii <eliz@gnu.org>
91
92 * keyboard.c (adjust_point_for_property): Don't position point
93 before BEGV. (Bug#10696)
94
95 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
96
97 Handle overflow when computing char display width (Bug#9496).
98 * character.c (char_width): Return EMACS_INT, not int.
99 (char_width, c_string_width): Check for overflow when
100 computing the width; this is possible now that individual
101 characters can have unbounded width. Problem introduced
102 by merge from Emacs 23 on 2012-01-19.
103
104 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
105
106 * dbusbind.c (Fdbus_register_method): Mention the return value
107 :ignore in the docstring.
108
109 2012-02-02 Glenn Morris <rgm@gnu.org>
110
111 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
112
113 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
114 Unconditionally set to t. (Bug#10673)
115 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
116 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
117 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
118
119 2012-02-02 Kenichi Handa <handa@m17n.org>
120
121 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
122 0, do not call append_composite_glyph.
123
124 2012-02-02 Kenichi Handa <handa@m17n.org>
125
126 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
127 NULL (Bug#6988).
128 (x_produce_glyphs): If the component of a composition is a null
129 string, set it->pixel_width to 1 to avoid zero-width glyph.
130
131 2012-02-01 Eli Zaretskii <eliz@gnu.org>
132
133 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
134 first 2 arguments are identical. This makes inserting large
135 output from a subprocess an order of magnitude faster on
136 MS-Windows, where all sbrk'ed memory is always contiguous.
137
138 2012-01-31 Glenn Morris <rgm@gnu.org>
139
140 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
141 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
142 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
143
144 2012-01-29 Glenn Morris <rgm@gnu.org>
145
146 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
147
148 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
149
150 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
151
152 2012-01-28 Chong Yidong <cyd@gnu.org>
153
154 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
155
156 2012-01-26 Chong Yidong <cyd@gnu.org>
157
158 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
159
160 * search.c (Fsearch_forward, Fsearch_backward): Document negative
161 repeat counts (Bug#10507).
162
163 2012-01-26 Glenn Morris <rgm@gnu.org>
164
165 * lread.c (syms_of_lread): Doc fix.
166
167 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
168
169 * coding.c (encode_designation_at_bol): Change return value to
170 EMACS_INT.
171
172 2012-01-25 Chong Yidong <cyd@gnu.org>
173
174 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
175
176 2012-01-21 Chong Yidong <cyd@gnu.org>
177
178 * floatfns.c (Fcopysign): Make the second argument non-optional,
179 since nil is not allowed anyway.
180
181 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
182
183 * process.c (read_process_output): Use p instead of XPROCESS (proc).
184 (send_process): Likewise.
185
186 2012-01-19 Martin Rudalics <rudalics@gmx.at>
187
188 * window.c (save_window_save, Fcurrent_window_configuration)
189 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
190 doc-strings.
191
192 2012-01-19 Kenichi Handa <handa@m17n.org>
193
194 * character.c (char_width): New function.
195 (Fchar_width, c_string_width, lisp_string_width):
196 Use char_width (Bug#9496).
197
198 2012-01-16 Martin Rudalics <rudalics@gmx.at>
199
200 * window.c (Vwindow_persistent_parameters): New variable.
201 (Fset_window_configuration, save_window_save): Handle persistent
202 window parameters.
203
204 2012-01-14 Eli Zaretskii <eliz@gnu.org>
205
206 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
207 thrashing the stack of the thread. (Bug#9087)
208
209 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
210
211 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
212
213 2012-01-11 Eli Zaretskii <eliz@gnu.org>
214
215 * xdisp.c (rows_from_pos_range): Handle the case where the
216 highlight ends on a newline. (Bug#10464)
217 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
218 he end column for display of highlight that ends on a newline
219 before a R2L line.
220
221 2012-01-11 Glenn Morris <rgm@gnu.org>
222
223 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
224 from load-path also when installation-directory is nil. (Bug#10208)
225
226 2012-01-10 Glenn Morris <rgm@gnu.org>
227
228 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
229
230 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
231 Update template values to be closer to their typical values these days.
232
233 2012-01-09 Eli Zaretskii <eliz@gnu.org>
234
235 * xdisp.c (rows_from_pos_range): Accept additional argument
236 DISP_STRING, and accept any glyph in a row whose object is that
237 string as eligible for mouse highlight. Fixes mouse highlight of
238 display strings from overlays. (Bug#10464)
239
240 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
241
242 emacs: fix an auto-save permissions race condition (Bug#10400)
243 * fileio.c (auto_saving_dir_umask): New static var.
244 (Fmake_directory_internal): Use it.
245 (do_auto_save_make_dir): Set it, instead of invoking chmod after
246 creating the directory. The old code temporarily assigns
247 too-generous permissions to the directory.
248 (do_auto_save_eh): Clear it.
249 (Fdo_auto_save): Catch all errors, not just file errors, so
250 that the var is always cleared.
251
252 2012-01-07 Eli Zaretskii <eliz@gnu.org>
253
254 * search.c (scan_buffer): Pass character positions to
255 know_region_cache, not byte positions. (Bug#6540)
256
257 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
258
259 * w32.c (sys_rename): Report EXDEV when rename of a directory
260 fails because the target is on another logical disk. (Bug#10284)
261
262 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
263
264 * xterm.c (x_embed_request_focus): New function.
265
266 * xterm.h: Add prototype.
267
268 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
269
270 2012-01-05 Glenn Morris <rgm@gnu.org>
271
272 * emacs.c (emacs_copyright): Update short copyright year to 2012.
273
274 2012-01-01 Eli Zaretskii <eliz@gnu.org>
275
276 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
277 Load gnutls_transport_set_lowat only if GnuTLS version is below
278 2.11.1.
279 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
280 GnuTLS versions below 2.11.1.
281
282 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
283
284 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
285 to the doc string advising against its use for altering the way
286 windows are scrolled.
287
288 2011-12-28 Kenichi Handa <handa@m17n.org>
289
290 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
291 coding-system ASCII compatible only when it does not produce BOM
292 on encoding (Bug#10383).
293
294 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
295
296 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
297 can scroll.
298 (create_and_show_popup_menu): Always use menu_position_func for
299 Gtk3 (Bug#10361).
300
301 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
302
303 * callint.c (Fcall_interactively): Don't truncate prompt string.
304
305 2011-12-23 Eli Zaretskii <eliz@gnu.org>
306
307 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
308 property that ends at ZV, so that the bidi iteration could be
309 resumed from there (after widening). (Bug#10360)
310
311 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
312
313 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
314
315 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
316
317 * nsterm.m (x_free_frame_resources):
318 Release f->output_data.ns->miniimage.
319 (ns_index_color): Fix indentation. Do not retain
320 color_table->colors[i].
321
322 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
323 before returning.
324
325 * nsfns.m (x_set_background_color): Assign return value from
326 ns_index_color to face-background instead of NSColor*.
327 (ns_implicitly_set_icon_type): Fix indentation.
328 Change assignment in for loop to comparison.
329
330 * emacs.c (ns_pool): New variable.
331 (main): Assign ns_pool.
332 (Fkill_emacs): Call ns_release_autorelease_pool.
333
334 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
335 autorelease fdesc, release fdAttrs and tdict.
336 (ns_get_covering_families): Release charset.
337 (ns_findfonts): Release NSFontDescriptor created with new.
338 (ns_uni_to_glyphs): Fix indentation.
339 (setString): Release attrStr before assigning new value.
340
341 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
342
343 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
344 and NS_IMPL_COCOA.
345 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
346 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
347
348 2011-12-18 David Reitter <reitter@cmu.edu>
349
350 * nsterm.m (ns_term_init): Subscribe for notifications
351 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
352 to method trackingNotification in EmacsMenu.
353
354 * nsmenu.m (trackingMenu): New variable.
355 (trackingNotification): New method (from Aquamacs).
356 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
357 from Aquamacs (Bug#7030).
358
359 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
360
361 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
362 (symbol_to_nsstring): Fix indentation.
363 (ns_symbol_to_pb): New function.
364 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
365 (Fns_rotate_cut_buffers_internal): Removed.
366 (Fns_store_selection_internal): Renamed from
367 Fns_store_cut_buffer_internal.
368 (ns_get_foreign_selection, Fx_own_selection_internal)
369 (Fx_disown_selection_internal, Fx_selection_exists_p)
370 (Fns_get_selection_internal, Fns_store_selection_internal):
371 Use ns_symbol_to_pb and check if return value is nil.
372 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
373 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
374 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
375 renamed to Sns_store_selection_internal.
376 (ns_handle_selection_request): Move code to Fx_own_selection_internal
377 and remove this function.
378 (ns_handle_selection_clear): Remove, never used.
379 (Fx_own_selection_internal): Move code from ns_handle_selection_request
380 here.
381
382 2011-12-17 Ken Brown <kbrown@cornell.edu>
383
384 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
385 GID is unknown (Bug#10257).
386
387 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
388
389 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
390 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
391 which caused a build failure on GNU/Linux IA-64. This problem was
392 introduced by my 2011-10-07 patch.
393
394 2011-12-15 Juri Linkov <juri@jurta.org>
395
396 * image.c (imagemagick_error): New function. (Bug#10112)
397 (imagemagick_load_image): Comment out `MagickSetResolution' call.
398 Use `imagemagick_error' where ImageMagick functions return
399 `MagickFalse'.
400 (Fimagemagick_types): Add `Fnreverse' to return the list in the
401 proper order.
402
403 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
404
405 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
406 fill background (Bug#8992).
407
408 2011-12-13 Martin Rudalics <rudalics@gmx.at>
409
410 * window.c (Vwindow_combination_resize)
411 (Vwindow_combination_limit): Use t instead of non-nil in
412 doc-strings.
413 (Vrecenter_redisplay): Add first sentence of doc-string on
414 separate line.
415 (Frecenter): Fix doc-string typo.
416
417 2011-12-11 Kenichi Handa <handa@m17n.org>
418
419 * coding.c (Funencodable_char_position): Pay attention to the
420 buffer text relocation (Bug#9389).
421
422 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
423
424 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
425 gtk_init (Bug#10100).
426
427 2011-12-10 Eli Zaretskii <eliz@gnu.org>
428
429 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
430 IT->string is nil. (Bug#10263)
431
432 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
433
434 * nsterm.h (x_free_frame_resources): Declare.
435
436 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
437 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
438
439 * nsterm.h (ns_get_defaults_value): Declare.
440
441 * nsterm.m (ns_default): Call ns_get_defaults_value.
442
443 2011-12-09 Eli Zaretskii <eliz@gnu.org>
444
445 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
446 (Bug#10170)
447
448 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
449
450 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
451 that where the value of an _OBJC_* symbol points to is in the .bss
452 section (Bug#10240).
453
454 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
455
456 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
457 after the loop to call ccl_driver at least once (Bug#8619).
458
459 2011-12-08 Kenichi Handa <handa@m17n.org>
460
461 * ftfont.c (get_adstyle_property): Fix previous change
462 (Bug#10233).
463
464 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
465
466 * w32.c (init_environment): If no_site_lisp, remove site-lisp
467 dirs from the default value of EMACSLOADPATH (bug#10208).
468
469 2011-12-07 Glenn Morris <rgm@gnu.org>
470
471 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
472 installation and source directories as well. (Bug#10208)
473
474 2011-12-06 Chong Yidong <cyd@gnu.org>
475
476 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
477
478 2011-12-06 Glenn Morris <rgm@gnu.org>
479
480 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
481 as an error, not just -1. (Bug#10217)
482
483 2011-12-05 Chong Yidong <cyd@gnu.org>
484
485 * keyboard.c (process_special_events): New function.
486 (swallow_events, Finput_pending_p): Use it (Bug#10195).
487
488 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
489
490 * coding.c (encode_designation_at_bol): Don't use uninitialized
491 local variable (Bug#9318).
492
493 2011-12-05 Kenichi Handa <handa@m17n.org>
494
495 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
496 return Qnil (Bug#8046, Bug#10193).
497
498 2011-12-05 Kenichi Handa <handa@m17n.org>
499
500 * coding.c (encode_designation_at_bol): New args charbuf_end and
501 dst. Return the number of produced bytes. Callers changed.
502 (coding_set_source): Return how many bytes coding->source was
503 relocated.
504 (coding_set_destination): Return how many bytes
505 coding->destination was relocated.
506 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
507 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
508
509 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
510
511 * coding.c (CODING_CHAR_CHARSET_P): New macro.
512 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
513 macro (Bug#9318).
514
515 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
516
517 The following changes are to fix Bug#9318.
518
519 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
520 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
521 (encode_coding_iso_2022, encode_coding_sjis)
522 (encode_coding_big5, encode_coding_charset): Use the above macros.
523
524 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
525
526 * lisp.h (process_quit_flag): Fix external declaration.
527
528 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
529
530 Don't macro-inline non-performance-critical code.
531 * eval.c (process_quit_flag): New function.
532 * lisp.h (QUIT): Use it.
533
534 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
535
536 * nsfns.m (get_geometry_from_preferences): New function.
537 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
538
539 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
540
541 * emacs.c (Qkill_emacs): Define.
542 (syms_of_emacs): Initialize it.
543 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
544 Qquit_flag to `kill-emacs' instead.
545 (quit_throw_to_read_char): Add parameter `from_signal'.
546 All callers changed. Call Fkill_emacs if requested and safe.
547 * lisp.h (QUIT): Call Fkill_emacs if requested.
548
549 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
550
551 * widget.c (update_wm_hints): Return if wmshell is null.
552 (widget_update_wm_size_hints): New function.
553
554 * widget.h (widget_update_wm_size_hints): Declare.
555
556 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
557 widget_update_wm_size_hints (Bug#10104).
558
559 2011-12-03 Eli Zaretskii <eliz@gnu.org>
560
561 * xdisp.c (handle_invisible_prop): If the invisible text ends just
562 before a newline, prepare the bidi iterator for consuming the
563 newline, and keep the current paragraph direction. (Bug#10183)
564 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
565
566 2011-12-02 Juri Linkov <juri@jurta.org>
567
568 * search.c (Fword_search_regexp): New Lisp function created from
569 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
570 (Fword_search_backward, Fword_search_forward)
571 (Fword_search_backward_lax, Fword_search_forward_lax):
572 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
573 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
574
575 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
576
577 * fileio.c (Finsert_file_contents): Move after-change-function call
578 to before the "handled:" label, since all "goto handled" appear in
579 cases where the *-change-functions have already been properly called
580 (bug#10117).
581
582 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
583
584 * keyboard.c (interrupt_signal): Don't call kill-emacs when
585 waiting for input. (Bug#10169)
586
587 2011-11-30 Eli Zaretskii <eliz@gnu.org>
588
589 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
590 verifies glyph row's hash code--we have just reallocated the
591 glyphs, so their contents can be complete garbage. (Bug#10164)
592
593 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
594
595 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
596
597 2011-11-30 Eli Zaretskii <eliz@gnu.org>
598
599 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
600 attributes are tested _before_ calling verify_row_hash, to protect
601 against GCC re-ordering of the tests. (Bug#10164)
602
603 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
604
605 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
606
607 * xterm.c (handle_one_xevent): Only set async_visible and friends
608 if net_wm_state_hidden_seen is non-zero (Bug#10002)
609 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
610 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
611
612 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
613
614 Remove GCPRO-related macros that exist only to avoid shadowing locals.
615 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
616 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
617 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
618 All uses changed to use GCPRO1 etc.
619 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
620 Revert to old implementation (i.e., before 2011-03-11).
621
622 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
623
624 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
625 of scroll runs so as to avoid assigning disabled bogus rows and
626 unnecessary graphics copy operations.
627
628 2011-11-27 Eli Zaretskii <eliz@gnu.org>
629
630 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
631 (snprintf) [_MSC_VER]: Redirect to _snprintf.
632 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
633 (malloc, free, realloc, calloc): Redirect to e_* only when
634 compiling Emacs.
635
636 * lisp.h (GCTYPEBITS): Move before first use.
637 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
638 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
639 this macro definition.
640
641 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
642 _MSC_VER.
643
644 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
645
646 * gtkutil.c (xg_create_frame_widgets):
647 Call gtk_window_set_has_resize_grip (FALSE) if that function is
648 present with Gtk+ 2.0.
649
650 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
651
652 * fileio.c (Finsert_file_contents): Undo previous change; see
653 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
654
655 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
656
657 Rename locals to avoid shadowing.
658 * fileio.c (Finsert_file_contents):
659 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
660 * process.c (wait_reading_process_output):
661 Rename inner 'proc' to 'p' to avoid shadowing.
662 Indent for consistency with usual Emacs style.
663
664 2011-11-25 Eli Zaretskii <eliz@gnu.org>
665
666 * xdisp.c (redisplay_window): If cursor row is not fully visible
667 after recentering, and scroll-conservatively is set to a large
668 number, scroll window by a few more lines to make the cursor fully
669 visible and out of scroll-margin. (Bug#10105)
670 (start_display): Don't move to the next line if the display should
671 start at a newline that is part of a display vector or an overlay
672 string. (Bug#10119)
673
674 2011-11-24 Juri Linkov <juri@jurta.org>
675
676 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
677 after the `MagickPingImage' call. (Bug#10112)
678
679 2011-11-23 Chong Yidong <cyd@gnu.org>
680
681 * window.c (Fcoordinates_in_window_p): Accept only live windows.
682
683 2011-11-23 Martin Rudalics <rudalics@gmx.at>
684
685 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
686 making another buffer current. (Bug#10114)
687
688 2011-11-23 Glenn Morris <rgm@gnu.org>
689
690 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
691
692 2011-11-23 Chong Yidong <cyd@gnu.org>
693
694 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
695 using it (Bug#5984).
696
697 2011-11-22 Eli Zaretskii <eliz@gnu.org>
698
699 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
700 and header-lines, as they don't have one computed for them.
701 (Bug#10098)
702
703 * .gdbinit (prow): Make displayed values more self-explaining.
704 Add row's hash code.
705
706 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
707
708 * process.c (wait_reading_process_output): Fix asynchrounous
709 GnuTLS socket handling on some versions of the GnuTLS library.
710 (wait_reading_process_output): Add comment and URL.
711
712 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
713
714 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
715
716 2011-11-21 Chong Yidong <cyd@gnu.org>
717
718 * window.c (Fnext_window, Fprevious_window): Doc fix.
719
720 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
721
722 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
723
724 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
725
726 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
727
728 2011-11-20 Martin Rudalics <rudalics@gmx.at>
729
730 * window.c (Fset_window_combination_limit): Rename argument
731 STATUS to LIMIT.
732 (Vwindow_combination_limit): Remove "status" from doc-string.
733
734 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
735
736 * m/ibms390.h: Remove.
737 * m/ibms390x.h: Don't include "ibms390.h".
738
739 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
740
741 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
742 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
743
744 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
745
746 * casetab.c (Fset_case_table):
747 * charset.c (Fcharset_after): Fix typos.
748
749 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
750
751 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
752 Otherwise, valgrind does not work on some platforms.
753 Problem reported by Andreas Schwab in
754 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
755 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
756 is set, removing the need for VIRT_ADDRESS_VARIES.
757 (PURE_P): Use a more-efficient implementation that needs just one
758 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
759 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
760 to 4 (xorl, subq, cmpq, setbe).
761 * alloc.c (pure): Always extern now, since that's the
762 VIRT_ADDR_VARIES behavior.
763 (PURE_POINTER_P): Use a single comparison, not two, for
764 consistency with the new puresize.h.
765 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
766 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
767 Remove VIRT_ADDR_VARIES no longer needed.
768
769 2011-11-19 Eli Zaretskii <eliz@gnu.org>
770
771 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
772 (erase_phys_cursor, update_window_cursor, show_mouse_face)
773 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
774 behave as if the cursor position were at the window margin.
775
776 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
777 and the cursor position is out of bounds, behave as if the cursor
778 position were at the window margin. (Bug#10075)
779
780 2011-11-18 Chong Yidong <cyd@gnu.org>
781
782 * window.c (Fwindow_combination_limit): Make first argument
783 non-optional, since it is meaningless for live windows like the
784 selected window.
785
786 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
787
788 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
789
790 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
791
792 * intervals.c: Fix grafting over the whole buffer (bug#10071).
793 (graft_intervals_into_buffer): Simplify.
794
795 2011-11-18 Eli Zaretskii <eliz@gnu.org>
796
797 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
798 hash values of the two rows.
799 (copy_row_except_pointers): Preserve the used[] arrays and the
800 hash values of the two rows. (Bug#10035)
801 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
802
803 * xdisp.c (row_hash): New function, body extracted from
804 compute_line_metrics.
805 (compute_line_metrics): Call row_hash, instead of computing the
806 hash code inline.
807
808 * dispnew.c (verify_row_hash): Call row_hash for computing the
809 hash code of a row, instead of duplicating code from xdisp.c.
810
811 * dispextern.h (row_hash): Add prototype.
812
813 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
814
815 * frame.c (delete_frame): Don't delete the terminal when the last
816 X frame is closed if emacs is built with GTK toolkit.
817
818 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
819
820 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
821
822 2011-11-17 Martin Rudalics <rudalics@gmx.at>
823
824 * window.c (Vwindow_splits): Rename to
825 Vwindow_combination_resize. Suggested by Juri Linkov.
826 (Fsplit_window_internal): Use Vwindow_combination_resize instead
827 of Vwindow_splits.
828
829 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
830
831 * nsfns.m (Fns_font_name):
832 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
833
834 2011-11-16 Martin Rudalics <rudalics@gmx.at>
835
836 * window.h (window): Rename slot "nest" to "combination_limit".
837 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
838 (Fset_window_nest): Rename to Fset_window_combination_limit.
839 (Vwindow_nest): Rename to Vwindow_combination_limit.
840 (recombine_windows, make_parent_window, make_window)
841 (Fsplit_window_internal, saved_window)
842 (Fset_window_configuration, save_window_save): Rename all
843 occurrences of window_nest to window_combination_limit.
844
845 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
846
847 * image.c (imagemagick_load_image): Fix typo.
848
849 2011-11-14 Eli Zaretskii <eliz@gnu.org>
850
851 * xdisp.c (display_line): Move the call to
852 highlight_trailing_whitespace before the call to
853 compute_line_metrics, since the latter needs to see the final
854 faces of all the glyphs to compute ROW's hash value.
855 Fixes assertion violations in row_equal_p. (Bug#10035)
856
857 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
858
859 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
860 just return (bug#10044).
861
862 2011-11-12 Eli Zaretskii <eliz@gnu.org>
863
864 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
865 with user-defined heap size. Bump the default size of the temacs
866 heap to 27MB, to avoid memory warning when running temacs.
867 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
868
869 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
870 current_matrix and desired_matrix. (Bug#9990)
871 (verify_row_hash) [XASSERTS]: New function.
872 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
873 that the hash value of glyph rows is correct.
874
875 2011-11-12 Martin Rudalics <rudalics@gmx.at>
876
877 * window.h (window): Remove splits slot.
878 * window.c (Fwindow_splits, Fset_window_splits): Remove.
879 (Fdelete_other_windows_internal, make_parent_window)
880 (make_window, Fsplit_window_internal, Fdelete_window_internal)
881 (Fset_window_configuration, save_window_save): Don't deal with
882 split status of windows.
883 (saved_window): Remove splits slot.
884 (Vwindow_splits): Rewrite doc-string.
885
886 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
887
888 * xfns.c (unwind_create_frame):
889 * nsfns.m (unwind_create_frame):
890 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
891 Vframe_list (Bug#9999).
892
893 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
894
895 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
896
897 2011-11-11 Kenichi Handa <handa@m17n.org>
898
899 * callproc.c (Fcall_process): Set the member dst_multibyte of
900 process_coding.
901
902 2011-11-11 Johan Bockgård <bojohan@gnu.org>
903
904 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
905 avoid a crash (bug#9496).
906
907 2011-11-09 Chong Yidong <cyd@gnu.org>
908
909 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
910 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
911
912 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
913
914 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
915
916 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
917
918 Avoid some portability problems by eschewing 'extern inline' functions.
919 The trivial performance wins aren't worth the portability hassles; see
920 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
921 et seq.
922 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
923 (window_box_width, window_box_left, window_box_left_offset)
924 (window_box_right, window_box_right_offset): Undo previous change,
925 by removing the "extern"s.
926 * intervals.c (adjust_intervals_for_insertion)
927 (adjust_intervals_for_deletion): Undo previous change,
928 making these static again.
929 (offset_intervals, temp_set_point_both, temp_set_point)
930 (copy_intervals_to_string): No longer inline.
931 * xdisp.c (window_text_bottom_y, window_box_width)
932 (window_box_height, window_box_left_offset)
933 (window_box_right_offset, window_box_left, window_box_right)
934 (window_box): No longer inline.
935
936 2011-11-08 Chong Yidong <cyd@gnu.org>
937
938 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
939 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
940 Signal an error if not a live window.
941 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
942 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
943
944 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
945
946 * lisp.h (syms_of_abbrev): Remove declaration.
947 Reported by CHENG Gao <chenggao@royau.me>.
948
949 2011-11-07 Eli Zaretskii <eliz@gnu.org>
950
951 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
952 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
953 of temacs in GUI mode.
954
955 2011-11-07 Martin Rudalics <rudalics@gmx.at>
956
957 * window.h: Declare delete_all_child_windows instead of
958 delete_all_subwindows.
959 * window.c (Fwindow_nest, Fset_window_nest)
960 (Fset_window_new_total, Fset_window_new_normal)
961 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
962 (delete_all_subwindows): Rename to delete_all_child_windows.
963 (Fdelete_other_windows_internal, Fset_window_configuration):
964 Call delete_all_child_windows instead of delete_all_subwindows.
965 * frame.c (delete_frame): Call delete_all_child_windows instead
966 of delete_all_subwindows.
967
968 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
969
970 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
971 This is also needed for porting to any host where GC_MARK_STACK is
972 not GC_MAKE_GCPROS_NOOPS.
973 (which_symbols): Use it.
974
975 2011-11-07 Kenichi Handa <handa@m17n.org>
976
977 * coding.c (coding_set_destination): Check coding->src_pos only
978 when coding->src_object is a buffer (bug#9910).
979
980 * process.c (send_process): Set the member src_multibyte of coding
981 to 0 (bug#9911) when sending a unibyte text.
982
983 * callproc.c (Fcall_process): Set the member src_multibyte of
984 process_coding to 0 (bug#9912).
985
986 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
987
988 * xmenu.c (cleanup_widget_value_tree): New function.
989 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
990 calling free_menubar_widget_value_tree directly (Bug#9830).
991
992 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
993
994 Fix some portability problems with 'inline'.
995 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
996 (window_box_width, window_box_left, window_box_left_offset)
997 (window_box_right, window_box_right_offset): Declare extern.
998 Otherwise, these inline functions do not conform to C99 and
999 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1000 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1001 * intervals.c (adjust_intervals_for_insertion)
1002 (adjust_intervals_for_deletion): Now extern, because otherwise the
1003 extern inline functions 'offset_intervals' couldn't refer to it.
1004 (static_offset_intervals): Remove.
1005 (offset_intervals): Rewrite using the old contents of
1006 static_offset_intervals. The old version didn't conform to C99
1007 because an extern inline function contained a reference to an
1008 identifier with static linkage.
1009
1010 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1011
1012 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1013 GC.
1014
1015 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1016
1017 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1018 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1019 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1020 return Qleft_to_right.
1021
1022 2011-11-06 Chong Yidong <cyd@gnu.org>
1023
1024 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1025 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1026 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1027 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1028 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1029 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1030 (Fwindow_vscroll): Doc fix.
1031 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1032 argument, since it makes no sense to pass a live window and for
1033 consistency with window-child.
1034
1035 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1036
1037 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1038 support MSVC.
1039
1040 2011-11-05 Jason Rumney <jasonr@gnu.org>
1041
1042 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1043 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1044 fonts (Bug#6029).
1045 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1046 bitwise arithmetic preventing use of unicode-sip and non-truetype
1047 opentype fonts.
1048
1049 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1050
1051 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1052 "emacs"-only part.
1053
1054 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1055 initialization code to keep similarity to xfns.c after changes
1056 from 2011-11-05.
1057
1058 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1059
1060 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1061 (unwind_create_frame): New function (Bug#9943).
1062 (Fx_create_frame): Restructure code to be more similar to the one in
1063 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1064 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1065 Move terminal->reference_count++ just before making the frame official
1066 (Bug#9943).
1067
1068 * nsterm.m (x_free_frame_resources): New function.
1069 (x_destroy_window): Move code to x_free_frame_resources.
1070
1071 * xfns.c (unwind_create_frame): Fix comment.
1072 (Fx_create_frame, x_create_tip_frame):
1073 Move terminal->reference_count++ just before making the frame
1074 official. Move initialization of image_cache_refcount and
1075 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1076
1077 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1078
1079 Support MSVC build with newer versions of Visual Studio.
1080 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1081 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1082 nt/gmake.defs.
1083
1084 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1085 which are not supported by MSVC.
1086 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1087 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1088 bitfields.
1089 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1090 types in bitfields.
1091 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1092
1093 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1094
1095 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1096
1097 Support MSVC build with newer versions of Visual Studio.
1098 * w32.c: Don't include w32api.h for MSVC.
1099 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1100
1101 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1102 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1103 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1104 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1105 e_* cousins.
1106 (alloca) [_MSC_VER]: Define to _alloca.
1107
1108 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1109
1110 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1111
1112 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1113
1114 * xdisp.c (note_mouse_highlight): If either of
1115 previous/next-single-property-change returns nil, treat that as
1116 the beginning or the end of the buffer. (Bug#9955)
1117
1118 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1119
1120 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1121 label is not null (Bug#9951).
1122 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1123 may be NULL.
1124
1125 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1126
1127 * window.c (Fwindow_body_size): Mention in the doc string that the
1128 return value is in frame's canonical units. (Bug#9949)
1129
1130 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1131
1132 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1133
1134 * w32fns.c (unwind_create_frame): If needed, free the glyph
1135 matrices of the partially constructed frame. (Bug#9943)
1136 * xfns.c (unwind_create_frame): Likewise.
1137
1138 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1139
1140 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1141 Don't stop backward scan on the continuation glyph, even though
1142 its CHARPOS is positive.
1143 (mouse_face_from_buffer_pos, note_mouse_highlight):
1144 Rename cover_string to disp_string.
1145
1146 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1147
1148 * window.c (temp_output_buffer_show): Don't use
1149 Vtemp_buffer_show_specifiers.
1150 (Vtemp_buffer_show_specifiers): Remove unused variable.
1151
1152 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1153
1154 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1155 past the beginning of the current glyph matrix.
1156
1157 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1158
1159 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1160 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1161 HAVE_GTK3 (Bug#9869).
1162
1163 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1164 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1165
1166 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1167
1168 * xterm.c: Declare x_handle_net_wm_state to return int.
1169 (handle_one_xevent): Check if we are iconified but don't have
1170 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1171 (get_current_wm_state): Return non-zero if not hidden,
1172 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1173 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1174 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1175 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1176
1177 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1180 so that this new function doesn't get optimized away by a
1181 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1182
1183 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1184
1185 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1186
1187 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1188
1189 Fix the `xbytecode' command.
1190 * .gdbinit (xprintbytestr): New command.
1191 (xwhichsymbols): Rename from `which'; all callers changed.
1192 (xbytecode): Print the byte-code string as well.
1193
1194 2011-10-29 Kim Storm <storm@cua.dk>
1195
1196 * alloc.c (which_symbols): New function.
1197
1198 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1199
1200 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1201 line. (Bug#9903)
1202
1203 2011-10-29 Glenn Morris <rgm@gnu.org>
1204
1205 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1206 Not clear what it was for, and it causes various bugs. (Bug#9839)
1207
1208 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1209
1210 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1211 possible random value that matches one of those tested as
1212 condition to clear the mouse face.
1213
1214 2011-10-28 Chong Yidong <cyd@gnu.org>
1215
1216 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1217
1218 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1219
1220 * window.c (make_window): Initialize phys_cursor_on_p.
1221
1222 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1223
1224 * lisp.h (struct Lisp_Symbol): Update comments.
1225
1226 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1227
1228 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1229
1230 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1231
1232 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1233 <oslsachem@gmail.com> for helping to debug this.
1234
1235 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1236 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1237 (g_b_init_get_glyph_outline_w): New static variables.
1238 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1239 (GetGlyphOutlineW_Proc): New typedefs.
1240 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1241 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1242 New functions.
1243 (w32font_open_internal, compute_metrics):
1244 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1245 instead of calling the "wide" APIs directly.
1246
1247 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1248
1249 * w32.h (syms_of_w32font): Add prototype.
1250
1251 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1252
1253 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1254 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1255 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1256 (Fmove_to_window_line): Doc fix.
1257
1258 2011-10-27 Chong Yidong <cyd@gnu.org>
1259
1260 * process.c (make_process): Set gnutls_state to NULL.
1261
1262 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1263 non-NULL, regardless of GNUTLS_INITSTAGE.
1264 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1265 an error. Set process slots as soon as we allocate them.
1266
1267 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1268
1269 2011-10-27 Chong Yidong <cyd@gnu.org>
1270
1271 * gnutls.c (emacs_gnutls_deinit): New function.
1272 Deallocate credentials structures as well as calling gnutls_deinit.
1273 (Fgnutls_deinit, Fgnutls_boot): Use it.
1274
1275 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1276 (deactivate_process): Call emacs_gnutls_deinit.
1277
1278 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1279
1280 * image.c (x_create_x_image_and_pixmap):
1281 * w32.c (sys_rename, w32_delayed_load):
1282 * w32font.c (fill_in_logfont):
1283 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1284
1285 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1286
1287 * w32fns.c (w32_default_color_map): New function,
1288 extracted from Fw32_default_color_map.
1289 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1290
1291 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1292
1293 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1294
1295 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1296
1297 * keyboard.c (test_undefined): New function (bug#9751).
1298 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1299
1300 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1301
1302 * sysdep.c (init_sys_modes): Fix the check for the controlling
1303 terminal (Bug#6649).
1304
1305 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1306
1307 * dispextern.h (struct bidi_it): New member next_en_type.
1308
1309 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1310 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1311 current character, check also for next_en_type being WEAK_EN.
1312 (bidi_resolve_weak): Don't enter the expensive loop if the current
1313 position is before next_en_pos. Record the bidi type of the first
1314 non-ET, non-BN character we find, in addition to its position.
1315 (bidi_level_of_next_char): Invalidate next_en_type when
1316 next_en_pos is over-stepped.
1317
1318 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1321 * editfns.c: Rewrite current-time-zone so that it invokes
1322 the equivalent of (format-time-string "%Z") to get the time zone name.
1323 This fixes a bug when the time zone name contains characters that
1324 need converting from the system time locale to Emacs internal format.
1325 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1326 that patch fixed format-time-string to do the conversion, but
1327 I forgot to fix current-time-zone.
1328 (format_time_string): New function, containing most of
1329 what Fformat_time_string used to contain.
1330 (Fformat_time_string): Rewrite in terms of format_time_string.
1331 This doesn't change this function's behavior.
1332 (current-time-zone): Rewrite to use format_time_string.
1333 This fixes the bug reported by Michael Schierl in
1334 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1335 Jason Rumney's 2007-06-07 change worked around this bug, but
1336 didn't fix it.
1337 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1338
1339 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1340
1341 * xdisp.c (start_display): If the character at POS is displayed
1342 via a display vector, reset IT->current.dpvec_index to zero.
1343 (try_window_reusing_current_matrix): If a line ends in a display
1344 vector or the next line starts in a display vector, continue
1345 redrawing the window even though the character position of
1346 start_row was reached.
1347 (Bug#9771, part 2)
1348
1349 2011-10-18 Chong Yidong <cyd@gnu.org>
1350
1351 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1352 with nobreak-char-display too.
1353
1354 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1355
1356 Fix part 3 of bug#9771.
1357 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1358 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1359 non-neutral characters if the current character is a paragraph
1360 separator (a.k.a. Newline). This avoids running the same
1361 expensive loop twice, once when we consume the preceding newline
1362 and the other time when the line actually needs to be displayed.
1363 Avoid the loop when we see neutrals on the base embedding level
1364 following a character whose directionality is the same as the
1365 paragraph's. This avoids running the expensive loop when a line
1366 ends in a long sequence of neutrals, like control characters.
1367 Add assertion against STRONG_AL type. Slightly rearrange code
1368 that determines the type of a neutral given the first non-neutral
1369 that follows it.
1370 (bidi_level_of_next_char): Set next_en_pos to zero when
1371 invalidating its info.
1372
1373 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1374
1375 * xdisp.c (push_display_prop): Determine whether to record string
1376 or buffer position by IT->string, not by IT->method. Allow
1377 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1378 (move_it_vertically_backward): Don't look for character position
1379 immediately after the newline when in a continuation line.
1380 (Bug#9771, part 1)
1381
1382 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1383
1384 * window.c (coordinates_in_window): Rewrite and delabelize
1385 vertical border check. (Bug#5357) (Bug#9618)
1386
1387 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1388
1389 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1390 errors in XSetWindowBorder (bug#9310).
1391
1392 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1393
1394 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1395 avoid crash when xmalloc overrun checking is enabled.
1396
1397 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1398
1399 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1400 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1401 cursor motion with <left> and <right> arrow keys.
1402
1403 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1404 some callers set that themselves.
1405
1406 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1407
1408 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1409 display string and the previous row comes from the same string and
1410 is empty. (Bug#9739) (Bug#9738)
1411
1412 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1413
1414 * doc.c (get_doc_string): Encode file name (bug#9735).
1415
1416 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1417
1418 * bidi.c (bidi_level_of_next_char):
1419 * xdisp.c (get_visually_first_element): Remove old incorrect
1420 comments regarding the Unicode Line Separator character.
1421
1422 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1423
1424 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1425
1426 * alloc.c (Fgc_status): Do not access beyond zombies array
1427 boundary if nzombies > MAX_ZOMBIES.
1428 * alloc.c (dump_zombies): Add missing format specifier.
1429
1430 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1433 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1434
1435 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1436 Some packages use them to denote characters with modifiers.
1437
1438 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1439
1440 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1441 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1442 matching a pp-number. Rename parameter var to var1.
1443
1444 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1445
1446 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1447
1448 2011-10-08 Glenn Morris <rgm@gnu.org>
1449
1450 * callint.c (Fcall_interactively): Give a more explicit error for the
1451 'c' case with a non-character input. (Bug#8479)
1452
1453 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1456 lines.
1457 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1458 lines that are hscrolled on the left.
1459
1460 * dispnew.c (buffer_posn_from_coords): Account for a possible
1461 presence of header-line. (Bug#4426)
1462
1463 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1464
1465 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1466 Don't advertise functionality which we discourage or doesn't work.
1467
1468 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1469
1470 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1471 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1472 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1473 this makes Emacs dump core during garbage collection on rare
1474 occasions. sizeof is obviously inferior to offsetof here, so
1475 stick with offsetof.
1476 (GC_POINTER_ALIGNMENT): New macro.
1477 (mark_memory): Omit 3rd (offset) arg; caller changed.
1478 Don't assume EMACS_INT alignment is the same as pointer alignment.
1479
1480 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1481
1482 * keyboard.c (read_key_sequence_remapped): New var.
1483 (read_key_sequence): Compute remapping in the right buffer.
1484 (command_loop_1): Use read_key_sequence's remapping directly.
1485
1486 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1487
1488 * dired.c (file_name_completion): Don't expand file name.
1489 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1490 before checking file name handler.
1491
1492 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1493 they've been requested explicitly (bug#9591).
1494
1495 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1496
1497 * keymap.c (Fsingle_key_description): Use make_specified_string
1498 instead of build_string to build string from push_key_description.
1499 (Bug#5193)
1500
1501 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1504 This fixes a Y2038 bug on 64-bit hosts.
1505 * buffer.c (reset_buffer):
1506 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1507 (Fclear_buffer_auto_save_failure):
1508 Use 0, not -1, to represent an unset failure time, since time_t
1509 might not be signed.
1510
1511 Remove dependency on glibc malloc internals.
1512 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1513 Move back here from lisp.h, but with their new implementations.
1514 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1515 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1516 * charset.c (charset_table_init): New static var.
1517 (syms_of_charset): Use it instead of xmalloc. This removes a
1518 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1519 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1520 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1521 Move back to alloc.c.
1522 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1523 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1524
1525 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1526
1527 * nsterm.m (windowDidResize): Call x_set_window_size only when
1528 ns_in_resize is true. Otherwise set pixelwidth/height and
1529 call change_frame_size (Bug#9628).
1530
1531 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 Port --enable-checking=all to Fedora 14 x86-64.
1534 * charset.c (syms_of_charset): Also account for glibc malloc's
1535 internal overhead when calculating the initial malloc maximum.
1536
1537 Port --enable-checking=all to Fedora 14 x86.
1538 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1539 Move to lisp.h.
1540 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1541 (overrun_check_realloc, overrun_check_free):
1542 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1543 That way, xmalloc returns a properly-aligned pointer even if
1544 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1545 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1546 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1547 into account when calculating the initial malloc maximum.
1548 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1549 Move here from alloc.c, so that charset.c can use it too.
1550 Properly align; the old code wasn't right for common 32-bit hosts
1551 when configured with --enable-checking=all.
1552 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1553 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1554
1555 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1556
1557 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1558 use EDOM.
1559
1560 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1561
1562 * xdisp.c (compute_display_string_end): If there's no display
1563 string at CHARPOS, return -1.
1564
1565 * bidi.c (bidi_fetch_char): When compute_display_string_end
1566 returns a negative value, treat the character as a normal
1567 character not covered by a display string. (Bug#9624)
1568
1569 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1570
1571 * lread.c (Fread_from_string): Fix typo in docstring.
1572
1573 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1574
1575 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1576 newline, reseat the iterator instead of bidi-iterating there one
1577 character at a time. (Bug#9610)
1578 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1579 TO_CHARPOS if the bidi iterator is at base embedding level.
1580
1581 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1582
1583 * lread.c (readevalloop): Use correct code for NBSP.
1584 (read1): Likewise. (Bug#9608)
1585
1586 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1587
1588 * dbusbind.c (Fdbus_register_signal): When service is not
1589 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1590
1591 2011-09-25 Glenn Morris <rgm@gnu.org>
1592
1593 * buffer.c (truncate-lines): Doc fix.
1594
1595 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1596
1597 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1598 (Fset_window_next_buffers): Doc fix.
1599
1600 2011-09-24 Glenn Morris <rgm@gnu.org>
1601
1602 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1603
1604 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 Fix minor problems found by static checking.
1607 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1608 * indent.c (Fvertical_motion): Fix == vs = typo.
1609
1610 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1611
1612 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1613 Default value is now t. Doc fix.
1614
1615 * indent.c (Fvertical_motion): Compute and apply the overshoot
1616 logic when moving up, not only when moving down. Fix the
1617 confusing name and values of the it_overshoot_expected variable;
1618 logic changes accordingly. (Bug#9254) (Bug#9549)
1619
1620 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1621 CHARPOS is covered by a display string which includes newlines.
1622 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1623 is covered by a display string with embedded newlines.
1624
1625 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1626
1627 * dbusbind.c (Fdbus_register_signal): Add match rule to
1628 Vdbus_registered_objects_table. (Bug#9581)
1629 (Fdbus_register_method, Vdbus_registered_objects_table):
1630 Fix docstring.
1631
1632 2011-09-24 Jim Meyering <meyering@redhat.com>
1633
1634 do not ignore write error for any output size
1635 The previous change was incomplete.
1636 While it makes emacs --batch detect the vast majority of stdout
1637 write failures, errors were still ignored whenever the output size is
1638 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1639 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1640 && echo FAIL: ignored write error
1641 FAIL: ignored write error
1642 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1643 && echo FAIL: ignored write error
1644 FAIL: ignored write error
1645 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1646
1647 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1648
1649 * emacs.c (Fkill_emacs): In noninteractive mode exit
1650 non-successfully if a write error occurred on stdout. (Bug#9574)
1651
1652 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1653
1654 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1655 the xassert test.
1656
1657 * dispextern.h (struct it): Update the comment documenting what
1658 can it->OBJECT be.
1659
1660 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1661
1662 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1663 a display string, extend search for cursor position to end of row.
1664 (find_row_edges): If the row ends in a newline from a display
1665 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1666 Handle the case of a display string with multiple newlines.
1667 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1668 non-empty line. Fixes confusing cursor motion with arrow keys at
1669 the beginning of a line that starts with whitespace.
1670
1671 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1672
1673 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1674 (bug#9493).
1675
1676 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1677
1678 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1679 boolean (Bug#9154).
1680
1681 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1682
1683 * xdisp.c (display_line): Record maximum and minimum buffer
1684 positions even if no glyphs were produced (e.g., by a zero-width
1685 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1686 buffer positions that will be removed from the glyph row because
1687 they don't fit.
1688 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1689 column is beyond frame width: don't subtract 1 "pixel" when
1690 computing width of the stretch.
1691 (reseat_at_next_visible_line_start): Undo the change made on
1692 2011-09-17 that saved paragraph information and restored it after
1693 the call to `reseat'. (Bug#9545)
1694
1695 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1696
1697 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1698 and turn window cursor on if cleared (Bug#9415).
1699
1700 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1701
1702 * search.c (boyer_moore): Take unibyte characters from pattern
1703 literally. (Bug#9458)
1704
1705 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1706
1707 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1708
1709 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1710
1711 Fix minor problem found by static checking.
1712 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1713 initialized, to pacify gcc -Wuninitialized.
1714
1715 * fileio.c: Report proper errno when syscall falls.
1716 (Finsert_file_contents): Save and restore errno,
1717 so that report_file_error outputs the correct diagnostic.
1718 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1719
1720 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1721
1722 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1723
1724 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1725
1726 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1727 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1728
1729 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1730
1731 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1732 about the current paragraph and restore it after the call to reseat.
1733
1734 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1735 (bidi_find_paragraph_start): Search back for paragraph beginning
1736 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1737 (bidi_move_to_visually_next): Only trigger paragraph-related
1738 computations when the last character is a newline or at EOB, not
1739 just any NEUTRAL_B. (Bug#9470)
1740
1741 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1742 truncated lines if point is covered by a display string. (Bug#9524)
1743
1744 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1747 (cons_to_x_long): New function.
1748 (lisp_data_to_selection_data): Use it. Correct the test for
1749 short-versus-long data; it was negated. Break out of vector
1750 loop, for efficiency, when a long datum is discovered.
1751
1752 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1753
1754 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1755
1756 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1757
1758 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1759 GCC PR/17406) by declaring this function with external scope.
1760
1761 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1764 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1765
1766 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1767
1768 * editfns.c (Fformat): Correctly handle text properties on "%%".
1769
1770 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1771
1772 * xterm.c (x_draw_composite_glyph_string_foreground):
1773 * w32term.c (x_draw_composite_glyph_string_foreground):
1774 * term.c (encode_terminal_code):
1775 * composite.c (composition_update_it, get_composition_id):
1776 * xdisp.c (get_next_display_element)
1777 (fill_composite_glyph_string): Add comments about special meaning
1778 of TAB characters in a composition.
1779
1780 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1781
1782 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1783 This occurs when processing a multibyte format.
1784 Problem reported by Wolfgang Jenker.
1785
1786 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1787
1788 * xdisp.c (try_cursor_movement): Only check for exact match if
1789 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1790
1791 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1792
1793 Remove unused external symbols.
1794 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1795 * xdisp.c (calc_pixel_width_or_height): Now static.
1796 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1797 * indent.c (check_display_width):
1798 * w32term.c: Fix comment to match code.
1799 * xterm.c, xterm.h (x_catching_errors): Remove.
1800
1801 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1802
1803 * xselect.c: Use signed conversions more consistently (Bug#9498).
1804 (selection_data_to_lisp_data): Assume incoming selection data are
1805 signed integers, not unsigned. This is to be consistent with
1806 outgoing selection data, which was modified to use signed integers
1807 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1808 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1809 expects long, not unsigned long.
1810
1811 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1812
1813 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1814 computation of loop end. Reported by Johan Bockgård
1815 <bojohan@gnu.org>.
1816
1817 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1818
1819 * frame.c (Fother_visible_frames_p): Function deleted.
1820
1821 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1822
1823 * indent.c (compute_motion): Process display vector front to back
1824 rather than the other way around. (Bug#2496)
1825
1826 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1827
1828 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1829
1830 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1831
1832 * minibuf.c (Fread_from_minibuffer): Doc fix.
1833
1834 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1835
1836 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1837 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1838
1839 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1840
1841 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1842 value for non-existent files.
1843
1844 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1845
1846 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1847 set its "size" to -1. This will set the modtime_size field of
1848 the corresponding buffer to -1, which is what
1849 verify-visited-file-modtime expects for files that do not exist.
1850 (Bug#9139)
1851
1852 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1855 here ...
1856 * lisp.h: ... from here. push_key_description is no longer
1857 defined in keyboard.c, so its declaration should not be in
1858 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1859 logically belongs with push_key_description.
1860
1861 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 * buffer.h: Include <sys/types.h> instead of <time.h>.
1864 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1865 Problem reported by Herbert J. Skuhra.
1866
1867 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1868
1869 * xml.c (parse_region): Make the parsing work for
1870 non-comment-starting XML files again (bug#9144).
1871
1872 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1873
1874 * image.c (gif_load): Fix calculation of bottom and right corner.
1875 (Bug#9468)
1876
1877 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1878
1879 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1880 redisplay in small windows.
1881
1882 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1883
1884 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1885
1886 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1887
1888 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1889 Operate on live windows only.
1890
1891 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1892
1893 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1894
1895 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1896
1897 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1898 only under bidi iteration.
1899
1900 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1901
1902 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1903
1904 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1905
1906 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1907 Without this fix, the command to link temacs failed due to an
1908 undefined symbol __builtin_isnan. This is because
1909 /usr/include/iso/math_c99.h #defines isnan(x) to
1910 __builtin_isnan(x), but the bundled gcc, which identifies itself
1911 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1912 a __builtin_isnan.
1913 * floatfns.c (isnan): #undef, and then #define to a clone of
1914 what's in data.c.
1915 (Fisnan): Always define, since it's always available now.
1916 (syms_of_floatfns): Always define isnan at the Lisp level.
1917
1918 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1919
1920 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1921
1922 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1923
1924 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1925 The previous code assumed that file offsets (off_t values) fit in
1926 EMACS_INT variables, which is not true on typical 32-bit hosts.
1927 The code messed up by falsely reporting buffer overflow in cases
1928 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1929 when "big" contains more than 2**29 bytes, even though this
1930 inserts just one byte and does not overflow the buffer.
1931 (Finsert_file_contents): Store file offsets as off_t
1932 values, not as EMACS_INT values. Check for overflow when
1933 converting between EMACS_INT and off_t. When checking for
1934 buffer overflow or for overlap, take the offsets into account.
1935 Don't use EMACS_INT for small values where int suffices.
1936 When checking for overlap, fix a typo: ZV was used where
1937 ZV_BYTE was intended.
1938 (Fwrite_region): Don't assume off_t fits into 'long'.
1939 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1940
1941 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1942
1943 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1944
1945 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 sprintf-related integer and memory overflow issues (Bug#9412).
1948
1949 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1950 (esprintf, exprintf, evxprintf): New functions.
1951 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1952 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1953 (modify_event_symbol): Do not assume that the length of
1954 name_alist_or_stem is safe to alloca and fits in int.
1955 (Fexecute_extended_command): Likewise for function name and binding.
1956 (Frecursion_depth): Wrap around reliably on integer overflow.
1957 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1958 since some callers pass EMACS_INT values.
1959 (Fsingle_key_description): Don't crash if symbol name contains more
1960 than MAX_ALLOCA bytes.
1961 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1962 (get_minibuffer): Arg is now EMACS_INT, not int.
1963 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1964 (esprintf, exprintf, evxprintf): New decls.
1965 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1966
1967 * dbusbind.c (signature_cat): New function.
1968 (xd_signature, Fdbus_register_signal):
1969 Do not overrun buffer; instead, report string overflow.
1970
1971 * dispnew.c (add_window_display_history): Don't overrun buffer.
1972 Truncate instead; this is OK since it's just a log.
1973
1974 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1975 even if the time zone offset is outlandishly large.
1976 Don't mishandle offset == INT_MIN.
1977
1978 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1979 when creating daemon; the previous buffer-overflow check was incorrect.
1980
1981 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1982 which has the guts of the old verror function.
1983
1984 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1985 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1986
1987 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1988 (font_unparse_xlfd): Don't blindly alloca long strings.
1989 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1990 fits in int, when using sprintf. Use single snprintf to count
1991 length of string rather than counting it via multiple sprintfs;
1992 that's simpler and more reliable.
1993 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1994 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1995 sprintf, in case result does not fit in int.
1996
1997 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1998 (fontset_from_font): Print it.
1999
2000 * frame.c (tty_frame_count): Now printmax_t, not int.
2001 (make_terminal_frame, set_term_frame_name): Print it.
2002 (x_report_frame_params): In X, window IDs are unsigned long,
2003 not signed long, so print them as unsigned.
2004 (validate_x_resource_name): Check for implausibly long names,
2005 and don't assume name length fits in 'int'.
2006 (x_get_resource_string): Don't blindly alloca invocation name;
2007 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2008 not fit in int.
2009
2010 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2011 (xg_check_special_colors, xg_set_geometry):
2012 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2013
2014 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2015 Use esprintf, not sprintf, in case result does not fit in int.
2016
2017 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2018 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2019 it as a large positive number.
2020 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2021 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2022
2023 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2024 in case result does not fit in int.
2025
2026 * print.c (float_to_string): Detect width overflow more reliably.
2027 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2028 buffer overrun. Don't assume list length fits in 'int'. Treat
2029 print length of 0 as 0, not as infinity; to be consistent with other
2030 uses of print length in this function. Don't overflow print length
2031 index. Don't assume hash table size fits in 'long', or that
2032 vectorlike size fits in 'unsigned long'.
2033
2034 * process.c (make_process): Use printmax_t, not int, to format
2035 process-name gensyms.
2036
2037 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2038
2039 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2040 to avoid potential buffer overrun.
2041
2042 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2043 if X resource line is longer than 512 bytes.
2044
2045 * xfns.c (x_window): Make sprintf buffer a bit bigger
2046 to avoid potential buffer overrun.
2047
2048 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2049
2050 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2051
2052 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 Integer overflow fixes for scrolling, etc.
2055 Without these, Emacs silently mishandles large integers sometimes.
2056 For example, "C-u 4294967297 M-x recenter" was treated as if
2057 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2058
2059 * xdisp.c (try_window_id): Check Emacs fixnum range before
2060 converting to 'int'.
2061
2062 * window.c (window_scroll_line_based, Frecenter):
2063 Check that an Emacs fixnum is in range before assigning it to 'int'.
2064 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2065 values converted from Emacs fixnums.
2066 (Frecenter): Don't wrap around a line count if it is out of 'int'
2067 range; instead, treat it as an extreme value.
2068 (Fset_window_configuration, compare_window_configurations):
2069 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2070
2071 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2072 that can exceed INT_MAX. Check that EMACS_INT value is in range
2073 before assigning it to the (possibly-narrower) index.
2074 (match_limit): Don't assume that a fixnum can fit in 'int'.
2075
2076 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2077 exceed INT_MAX.
2078
2079 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2080 (Fvertical_motion): Don't wrap around LINES values that don't fit
2081 in 'int'. Instead, treat them as extreme values. This is good
2082 enough for windows, which can't have more than INT_MAX lines anyway.
2083
2084 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2085
2086 * Require libxml/parser.h to avoid compilation warning.
2087
2088 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2089
2090 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2091 since this reportedly can destroy thread storage.
2092
2093 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2094
2095 * syntax.c (find_defun_start): Update all cache variables if
2096 exiting early (Bug#9401).
2097
2098 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2099
2100 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2101
2102 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2103 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2104 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2105
2106 * term.c (tty_append_glyph): New function.
2107 (produce_stretch_glyph): Static function and its prototype deleted.
2108
2109 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2110 Add prototypes.
2111
2112 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2113
2114 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2115 when checking :margin (Bug#9390).
2116 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2117 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2118 so that the name doesn't mislead. All uses changed.
2119
2120 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2121
2122 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2123 set_tty_hooks.
2124
2125 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2126
2127 * xdisp.c (move_it_to): Don't bail out early when reaching
2128 position beyond to_charpos, if we are scanning backwards.
2129 (move_it_vertically_backward): When DY == 0, make sure we get to
2130 the first character in the line after the newline.
2131
2132 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2135 (ccl_driver): Do not generate an out-of-range pointer.
2136 (Fccl_execute_on_string): Remove unnecessary check for
2137 integer overflow, noted by Stefan Monnier in
2138 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2139 Remove a FIXME that didn't need fixing.
2140 Simplify the newly-introduced buffer reallocation code.
2141
2142 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2143
2144 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2145
2146 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 Integer and memory overflow issues (Bug#9196).
2149
2150 * doc.c (get_doc_string): Rework so that
2151 get_doc_string_buffer_size is the actual buffer size, rather than
2152 being 1 less than the actual buffer size; this makes xpalloc more
2153 convenient.
2154
2155 * image.c (x_allocate_bitmap_record, cache_image):
2156 * xselect.c (Fx_register_dnd_atom):
2157 Simplify previous changes by using xpalloc.
2158
2159 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2160 since either will do and ptrdiff_t is convenient with xpalloc.
2161
2162 * charset.c (charset_table_size)
2163 (struct charset_sort_data.priority): Now ptrdiff_t.
2164 (charset_compare): Don't overflow if priorities differ greatly.
2165 (Fsort_charsets): Don't assume list length fits in int.
2166 Check for size-calculation overflow when allocating sort data.
2167 (syms_of_charset): Allocate an initial charset table that is
2168 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2169
2170 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2171
2172 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2173 The actual value is always <= INT_MAX, and leaving it unsigned made
2174 overflow checking harder.
2175
2176 * dispextern.h (struct glyph_matrix.rows_allocated)
2177 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2178 with xpalloc. The values are still always <= INT_MAX.
2179
2180 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2181
2182 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2183 (SAFE_NALLOCA): New macro.
2184
2185 * region-cache.c (struct boundary.pos, find_cache_boundary)
2186 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2187 (set_cache_region, invalidate_region_cache)
2188 (revalidate_region_cache, know_region_cache, region_cache_forward)
2189 (region_cache_backward, pp_cache):
2190 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2191 so that ptrdiff_t * can be passed to xpalloc.
2192 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2193 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2194 (pp_cache): Don't assume cache_len fits in int.
2195 * region-cache.h: Adjust extern decls to match.
2196
2197 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2198 EMACS_INT, since either will do, for xpalloc.
2199
2200 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2201 (xnmalloc, xnrealloc, xpalloc): New functions.
2202
2203 * bidi.c (bidi_shelve_header_size): New constant.
2204 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2205 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2206
2207 * bidi.c (bidi_cache_shrink):
2208 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2209 (overlay_strings):
2210 Don't update size of array until after memory allocation succeeds,
2211 because xmalloc/xrealloc may not return.
2212 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2213 now that we have proper integer overflow checking.
2214 (record_overlay_string, overlay_strings): Catch overflows when
2215 calculating size of overlay_str_buf.
2216
2217 * callproc.c (Fcall_process): Check for size overflow when
2218 calculating size of args2.
2219 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2220 Normally we prefer signed values, but sticking with ptrdiff_t would
2221 require adding more-complicated checks.
2222
2223 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2224 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2225 Redo buffer-overflow calculations to avoid integer overflow.
2226 Add a FIXME comment where memory seems to be over-allocated.
2227
2228 * character.c (Fstring): Check for size-calculation overflow.
2229
2230 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2231 unnecessary integer overflow. Check for size overflow.
2232 (encode_coding_object): Don't update size until xmalloc succeeds.
2233
2234 * composite.c (get_composition_id): Check for overflow in glyph
2235 length calculations.
2236
2237 Integer and memory overflow fixes for display code.
2238 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2239 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2240 (scrolling_window): Check for overflow in size calculations.
2241 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2242 Don't assume glyph table len fits in int.
2243 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2244 (row_table_size): Now ptrdiff_t, not int.
2245 (scrolling_window): Avoid overflow in size calculations.
2246 Don't update size until allocation succeeds.
2247 * fns.c (concat): Check for overflow in size calculations.
2248 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2249 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2250 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2251
2252 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2253 (get_doc_string): Check for size calculation overflow.
2254 Don't update size until allocation succeeds.
2255 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2256 EMACS_INT, where ptrdiff_t will do.
2257 (Fsubstitute_command_keys): Check for string overflow.
2258
2259 * editfns.c (set_time_zone_rule): Don't assume environment length
2260 fits in int.
2261 (message_length): Now ptrdiff_t, not int.
2262 (Fmessage_box): Don't update size until allocation succeeds.
2263 Don't assume message length fits in int.
2264 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2265
2266 * emacs.c (main): Do not reallocate argv, since there is a null at
2267 the end that can be overwritten, and this way there's no need to
2268 worry about size-calculation overflow.
2269 (sort_args): Check for size-calculation overflow.
2270
2271 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2272 alloc succeeds.
2273 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2274
2275 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2276 (x_set_scroll_bar_width, x_figure_window_size):
2277 Check for integer overflow.
2278 (x_set_alpha): Do not assume XINT fits in int.
2279
2280 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2281 This is for the members text_lines, text_cols, total_lines, total_cols,
2282 where the system imposes an 'int' limit.
2283
2284 * fringe.c (Fdefine_fringe_bitmap):
2285 Don't update size until alloc works.
2286
2287 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2288 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2289
2290 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2291 Check for size-calculation overflow.
2292 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2293 do, as we prefer signed integers.
2294 (id_to_widget.max_size, id_to_widget.used)
2295 (xg_store_widget_in_map, xg_remove_widget_from_map)
2296 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2297 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2298 Use and return ptrdiff_t, not int.
2299 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2300 * gtkutil.h: Change prototypes to match the above.
2301
2302 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2303 are duplicate now that they've been promoted to lisp.h.
2304 (x_allocate_bitmap_record, x_alloc_image_color)
2305 (make_image_cache, cache_image, xpm_load):
2306 Don't update size until alloc is done.
2307 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2308 (x_detect_edges):
2309 Check for size calculation overflow.
2310 (ct_colors_allocated_max): New constant.
2311 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2312 overflow.
2313
2314 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2315 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2316 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2317 Use ptrdiff_t, not int, to count maps.
2318 (read_char_minibuf_menu_prompt): Check for overflow in size
2319 calculations. Don't update size until allocation succeeds.
2320 Redo calculations to avoid overflow.
2321 * keyboard.h: Change prototypes to match the above.
2322
2323 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2324 to count maps.
2325 (current_minor_maps): Check for size calculation overflow.
2326 * keymap.h: Change prototypes to match the above.
2327
2328 * lread.c (read1, init_obarray): Don't update size until alloc done.
2329
2330 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2331 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2332
2333 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2334 Now ptrdiff_t, not int.
2335 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2336 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2337
2338 * process.c (Fnetwork_interface_list): Check for overflow
2339 in size calculation.
2340
2341 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2342
2343 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2344 overflow. Don't bother calling xmalloc when xrealloc will do.
2345
2346 * search.c (Freplace_match): Check for size calculation overflow.
2347 (Fset_match_data): Don't assume list lengths fit in 'int'.
2348
2349 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2350 for command line length. Do not attempt to address one before the
2351 beginning of an array, as that's not portable.
2352
2353 * term.c (max_frame_lines): Remove; unused.
2354 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2355 not int.
2356 (encode_terminal_code, calculate_costs): Check for size
2357 calculation overflow.
2358 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2359 table lengths and related sizes. Don't update size until alloc
2360 done. Redo calculations to avoid overflow.
2361 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2362
2363 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2364 subtracting pointers.
2365 (gobble_line): Check for overflow more carefully. Don't update size
2366 until alloc done.
2367
2368 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2369 Don't update size until alloc done.
2370 Redo size calculations to avoid overflow.
2371 Check for size calculation overflow.
2372 (main) [DEBUG]: Fix typo in invoking tparam1.
2373
2374 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2375 Use ptrdiff_t, not int, for sizes.
2376 (store_mode_line_noprop_char): Don't update size until alloc done.
2377
2378 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2379 Use ptrdiff_t, not int, for sizes.
2380 (Finternal_make_lisp_face, cache_face):
2381 Check for size calculation overflow.
2382 (cache_face): Treat size calculation overflows as if they were
2383 memory exhaustion (the usual treatment), rather than aborting.
2384
2385 * xfns.c (x_encode_text, x_set_name_internal)
2386 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2387 sizes, since they can exceed INT_MAX in size. Check for size
2388 calculation overflow.
2389
2390 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2391 (xg_select): Check for size calculation overflow.
2392 Don't update size until alloc done.
2393
2394 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2395 as sprintf is limited to int lengths.
2396
2397 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2398 (X_LONG_MIN): New macros.
2399 Use them to make the following changes clearer.
2400 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2401 This change doesn't affect the value now, but it may help remind
2402 future maintainers not to raise the value too much later.
2403 (SELECTION_QUANTUM): Remove, replacing with ...
2404 (selection_quantum): ... new function, which avoids overflow.
2405 All uses changed.
2406 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2407 assumption that selection length fits in 'int'.
2408 (x_reply_selection_request, x_handle_selection_request)
2409 (x_get_window_property, receive_incremental_selection)
2410 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2411 (lisp_data_to_selection_data, clean_local_selection_data):
2412 Use ptrdiff_t, not int, to record length of selection.
2413 (x_reply_selection_request, x_get_window_property)
2414 (receive_incremental_selection, x_property_data_to_lisp):
2415 Redo calculations to avoid overflow.
2416 (x_reply_selection_request): When sending hint, ceiling it at
2417 X_LONG_MAX rather than relying on wraparound overflow to send
2418 something.
2419 (x_get_window_property, receive_incremental_selection)
2420 (lisp_data_to_selection_data, x_property_data_to_lisp):
2421 Check for size-calculation overflow.
2422 (x_get_window_property, receive_incremental_selection)
2423 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2424 Don't store size until memory allocation succeeds.
2425 (x_get_window_property): Plug memory leak on memory exhaustion.
2426 Don't double-block input; malloc is safe here. Don't assume 2**34
2427 - 4 fits in unsigned long. Add an xassert to check
2428 XGetWindowProperty overflow. Be more careful about overflow
2429 calculations, and distinguish size from memory overflow better.
2430 (receive_incremental_selection): When tracing, don't assume
2431 unsigned int is less than INT_MAX.
2432 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2433 harmful) conversions of unsigned short to int.
2434 (lisp_data_to_selection_data): Don't assume that integers
2435 in the range -65535 through -1 fit in an X unsigned short.
2436 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2437 result parameters unless successful. Rely on cons_to_unsigned
2438 to report problems with elements; the old code wasn't right anyway.
2439 (x_check_property_data): Check for int overflow; we cannot use
2440 a wider type due to X limits.
2441 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2442
2443 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2444
2445 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2446 (x_term_init): Check for size calculation overflow.
2447 (x_color_cells): Don't store size until memory allocation succeeds.
2448 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2449 Don't assume alloca size is less than MAX_ALLOCA.
2450 (x_term_init): Don't assume length fits in int (sprintf is limited
2451 to int size).
2452
2453 Use ptrdiff_t for composition IDs.
2454 * character.c (lisp_string_width):
2455 * composite.c (composition_table_size, n_compositions)
2456 (get_composition_id, composition_gstring_from_id):
2457 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2458 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2459 * window.c (Frecenter):
2460 Use ptrdiff_t, not int, for composition IDs.
2461 * composite.c (get_composition_id): Check for integer overflow.
2462 * composite.h: Adjust prototypes to match the above changes.
2463
2464 Use ptrdiff_t for hash table indexes.
2465 * category.c (hash_get_category_set):
2466 * ccl.c (ccl_driver):
2467 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2468 * coding.c (coding_system_charset_list, detect_coding_system):
2469 * coding.h (struct coding_system.id):
2470 * composite.c (get_composition_id, gstring_lookup_cache):
2471 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2472 * image.c (xpm_get_color_table_h):
2473 * lisp.h (hash_lookup, hash_put):
2474 * minibuf.c (Ftest_completion):
2475 Use ptrdiff_t for hash table indexes, not int (which is too
2476 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2477 32-bit --with-wide-int hosts).
2478
2479 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2480 Add a FIXME comment about memory leaks.
2481 (syms_of_charset): Don't assume xmalloc returns.
2482
2483 Don't assume that stated character widths fit in int.
2484 * character.c (Fchar_width, c_string_width, lisp_string_width):
2485 * character.h (CHAR_WIDTH):
2486 * indent.c (MULTIBYTE_BYTES_WIDTH):
2487 Use sanitize_char_width to avoid undefined and/or bad behavior
2488 with outlandish widths.
2489 * character.h (sanitize_tab_width): Rename from sanitize_width,
2490 now that we have two such functions. All uses changed.
2491 (sanitize_char_width): New inline function.
2492
2493 Don't assume that tab-width fits in int.
2494 * character.h (sanitize_width): New inline function.
2495 (SANE_TAB_WIDTH): New macro.
2496 (ASCII_CHAR_WIDTH): Use it.
2497 * indent.c (sane_tab_width): Remove. All uses replaced by
2498 SANE_TAB_WIDTH (current_buffer).
2499 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2500
2501 * fileio.c: Integer overflow issues with file modes.
2502 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2503
2504 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2505 Remove unreachable code.
2506 (read_hex, load_charset_map_from_file): Check for integer overflow.
2507
2508 * xterm.c: Don't go over XClientMessageEvent limit.
2509 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2510 (x_send_scroll_bar_event): Likewise. Check that the size does not
2511 exceed limits imposed by XClientMessageEvent, as well as the usual
2512 ptrdiff_t and size_t limits.
2513
2514 * keyboard.c: Overflow, signedness and related fixes.
2515 (make_lispy_movement): Use same integer type in forward decl
2516 that is used in the definition.
2517 (read_key_sequence, keyremap_step):
2518 Change bufsize argument back to int, undoing my 2011-03-30 change.
2519 We prefer signed types, and int is wide enough here.
2520 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2521 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2522 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2523 length, not size_t. Use ptrdiff_t for index, not int.
2524 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2525 possibility of integer overflow.
2526
2527 Overflow, signedness and related fixes for images.
2528
2529 * dispextern.h (struct it.stack[0].u.image.image_id)
2530 (struct_it.image_id, struct image.id, struct image_cache.size)
2531 (struct image_cache.used, struct image_cache.ref_count):
2532 * gtkutil.c (update_frame_tool_bar):
2533 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2534 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2535 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2536 * nsmenu.m (update_frame_tool_bar):
2537 * xdisp.c (calc_pixel_width_or_height):
2538 * xfns.c (image_cache_refcount):
2539 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2540 on typical 64-bit hosts.
2541
2542 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2543 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2544 Omit unnecessary casts to int.
2545 (parse_image_spec): Check that integers fall into 'int' range
2546 when the callers expect that.
2547 (image_ascent): Redo ascent calculation to avoid int overflow.
2548 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2549 (lookup_image): Remove unnecessary tests.
2550 (xbm_image_p): Locals are now of int, not EMACS_INT,
2551 since parse_image_check makes sure they fit into int.
2552 (png_load, gif_load, svg_load_image):
2553 Prefer int to unsigned where either will do.
2554 (tiff_handler): New function, combining the cores of the
2555 old tiff_error_handler and tiff_warning_handler.
2556 This function is rewritten to use vsnprintf and thereby avoid
2557 stack buffer overflows. It uses only the features of vsnprintf
2558 that are common to both POSIX and native Microsoft.
2559 (tiff_error_handler, tiff_warning_handler): Use it.
2560 (tiff_load, gif_load, imagemagick_load_image):
2561 Don't assume :index value fits in 'int'.
2562 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2563 (imagemagick_load_image): Check that crop parameters fit into
2564 the integer types that MagickCropImage accepts. Don't assume
2565 Vimagemagick_render_type has a nonnegative value. Don't assume
2566 size_t fits in 'long'.
2567 (gs_load): Use printmax_t to print the widest integers possible.
2568 Check for integer overflow when computing image height and width.
2569
2570 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2571
2572 * xdisp.c (redisplay_window): Don't force window start if point
2573 will be invisible in the resulting window. (Bug#9324)
2574
2575 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2576
2577 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2578 the display spec is of the form `(space ...)'.
2579 (handle_display_spec): Return the value returned by
2580 handle_single_display_spec, not just 1 or zero.
2581 (handle_single_display_spec): If the display spec is of the form
2582 `(space ...)', and specifies display in the text area, return 2
2583 rather than 1.
2584 (try_cursor_movement): Check for the need to scroll more
2585 accurately, and prefer exact match for point under bidi.
2586 Don't advance `row' beyond the last row of the window.
2587
2588 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2589 into disp_prop; all users changed.
2590
2591 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2592 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2593 for the text covered by the display property.
2594
2595 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2596
2597 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2598 Change return value to nil.
2599 (Frecord_buffer): Delete unused function.
2600
2601 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2602
2603 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2604 buffers, return left-to-right.
2605 (set_cursor_from_row): Consider candidate row a win if its glyph
2606 represents a newline and point is on that newline. Fixes cursor
2607 positioning on the newline at EOL of R2L text within L2R
2608 paragraph, and vice versa.
2609 (try_cursor_movement): Check continued rows, in addition to
2610 continuation rows. Fixes unwarranted scroll when point enters a
2611 continued line of R2L text within an L2R paragraph, or vice versa.
2612 (cursor_row_p): Consider the case of point being equal to
2613 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2614 from the end of a short line to the beginning of a continued line
2615 of R2L text within L2R paragraph.
2616 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2617 composed characters.
2618
2619 * bidi.c (bidi_check_type): Use xassert.
2620 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2621 members.
2622
2623 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2624
2625 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2626 a character.
2627
2628 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2629
2630 * nsfont.m (ns_otf_to_script): Fix typo.
2631
2632 2011-08-22 Kenichi Handa <handa@m17n.org>
2633
2634 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2635 extra slot even if the purpose is char-code-property-table.
2636
2637 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2638
2639 * xdisp.c (redisplay_window): When computing centering_position,
2640 account for the height of the header line. (Bug#8874)
2641
2642 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2643 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2644 candidate is selected by the mouse, and that candidate has a
2645 composed character under the mouse.
2646
2647 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2648 coordinates reported by pos-visible-in-window-p for a composed
2649 character in column zero.
2650
2651 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2652
2653 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2654
2655 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2656
2657 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2658 consider it a hit if to_charpos is anywhere in the range of the
2659 composed buffer positions.
2660
2661 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2662
2663 * image.c (gif_load): Don't assume that each subimage has the same
2664 dimensions as the base image. Handle disposal method that is
2665 "undefined" by the gif spec (Bug#9335).
2666
2667 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2668
2669 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2670 (Fcondition_case): Document `debug' symbol in error handler.
2671
2672 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2673
2674 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2675 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2676 from an Org mode buffer to a Speedbar frame.
2677
2678 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2679 a composition, take its buffer position from IT->cmp_it.charpos.
2680 Fixes cursor positioning at the beginning of a line that begins
2681 with a composed character.
2682
2683 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2684
2685 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2686 character bidirectional type, use STRONG_L instead. Fixes crashes
2687 in a buffer produced by `describe-categories'.
2688
2689 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2690 members before the level stack, so they would be saved and
2691 restored when copying iterator state. Fixes incorrect reordering
2692 around TABs covered by display properties.
2693
2694 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2695
2696 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2697
2698 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2699
2700 * eval.c (internal_condition_case, internal_condition_case_1)
2701 (internal_condition_case_2, internal_condition_case_n):
2702 Remove unnecessary aborts (Bug#9081).
2703
2704 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2705
2706 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2707 has no `load' handler, try opening the file locally. (Bug#9311)
2708
2709 2011-08-16 Ken Brown <kbrown@cornell.edu>
2710
2711 * gmalloc.c: Expand comment.
2712
2713 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2714
2715 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2716 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2717
2718 2011-08-16 Ken Brown <kbrown@cornell.edu>
2719
2720 Fix memory allocation problems in Cygwin build (Bug#9273).
2721
2722 * unexcw.c ( __malloc_initialized): Declare external variable.
2723 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2724
2725 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2726 New variables.
2727 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2728 dumped emacs.
2729 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2730 in the static heap.
2731 [CYGWIN] (special_realloc): New function.
2732 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2733 requests to realloc storage in the static heap.
2734
2735 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 * bidi.c (bidi_initialize): Remove unused local.
2738
2739 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2740
2741 * bidimirror.h:
2742 * biditype.h: Remove file.
2743 * makefile.w32-in ($(BLD)/bidi.$(O)):
2744 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2745
2746 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2747
2748 * chartab.c: Improve commentary for the uniprop_table API.
2749
2750 * bidi.c (bidi_paragraph_init): Support zero value of
2751 bidi_ignore_explicit_marks_for_paragraph_level.
2752 (bidi_initialize): Use uniprop_table instead of including
2753 biditype.h and bidimirror.h.
2754
2755 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2756 coordinates of the iterator when restoring from ppos_it.
2757 (Bug#9296)
2758
2759 2011-08-14 Kenichi Handa <handa@m17n.org>
2760
2761 * process.c (create_process): Call setup_process_coding_systems
2762 after the pid of the process is set to -1 (Bug#8162).
2763
2764 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2765
2766 * xdisp.c (move_it_in_display_line_to): Don't invoke
2767 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2768 ppos_it. Fixes vertical cursor motion when line beginning is
2769 covered by an image. (Bug#9296)
2770
2771 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2772
2773 * nsterm.h (ns_run_ascript): Declare.
2774 (NSAPP_DATA2_RUNASSCRIPT): Define.
2775
2776 * nsfns.m (as_script, as_result, as_status): New static variables.
2777 (ns_run_ascript): New function.
2778 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2779 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2780 the event loop. Get status from as_status (Bug#7276).
2781
2782 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2783 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2784 the event loop (Bug#7276).
2785
2786 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2787
2788 * gnutls.c (QCgnutls_bootprop_priority)
2789 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2790 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2791 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2792 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2793 (QCgnutls_bootprop_verify_hostname_error)
2794 (QCgnutls_bootprop_callbacks_verify): Rename from
2795 Qgnutls_bootprop_..., all uses changed.
2796
2797 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2798 uses changed.
2799
2800 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2801
2802 * xfaces.c (Qframe_set_background_mode): Now static.
2803 * dispextern.h (Qframe_set_background_mode): Remove decl.
2804
2805 * process.c (Fnetwork_interface_info): Declare local only if needed.
2806
2807 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2808
2809 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2810 (Fnetwork_interface_list): Allocate in increments of bytes instead
2811 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2812 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2813 sockaddr.
2814 (struct ifflag_def): notrailers is smart on OSX.
2815 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2816 Get hardware address with getifaddrs if available.
2817
2818 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2819
2820 * xdisp.c (iterate_out_of_display_property): xassert that
2821 IT->position is set to within IT->object's boundaries. Break from
2822 the loop as soon as EOB is reached; avoids infloops in redisplay
2823 when IT->position is set up wrongly due to some bug.
2824 Set IT->current to match the bidi iterator unconditionally.
2825 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2826 entry. Force push_it to save on the stack the current
2827 buffer/string position, to be restored by pop_it. Fix flags in
2828 the iterator structure wrt the object coming from a display
2829 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2830 properties. (Bug#9284)
2831
2832 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2833
2834 * fontset.c (fontset_get_font_group): Add proper type checks.
2835 (Bug#9172)
2836
2837 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2838
2839 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2840 and LC_VERSION_MIN_MACOSX.
2841 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2842 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2843
2844 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2845
2846 * xdisp.c (forward_to_next_line_start): Allow to use the
2847 no-display-properties-and-no-overlays under bidi display.
2848 Set disp_pos in the bidi iterator to avoid searches for display
2849 properties and overlays.
2850
2851 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2852
2853 * editfns.c (Fset_time_zone_rule): Document relationship with the
2854 setenv function.
2855
2856 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2857 the font entity extracted from the cache (Bug#8109).
2858
2859 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2860
2861 * composite.c (autocmp_chars): Don't reset point. That is done by
2862 restore_point_unwind (Bug#5984).
2863
2864 2011-08-07 Juri Linkov <juri@jurta.org>
2865
2866 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2867 to show the arg `TIME' instead of `TIMEVAL'.
2868
2869 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2870
2871 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2872 display property strides EOL and includes a newline, as in
2873 longlines-mode. (Bug#9254)
2874 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2875 word-wrap under bidirectional display. (Bug#9224)
2876
2877 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2878 is non-zero, even if the data buffer is NULL. Fixes a crash in
2879 vertical-motion with longlines-mode. (Bug#9254)
2880
2881 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2882
2883 * bidi.c <bidi_cache_total_alloc>: Now static.
2884 (bidi_initialize): Initialize bidi_cache_total_alloc.
2885
2886 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2887 cache. (Bug#9221)
2888
2889 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2890 amount allocated this far in `bidi_cache_total_alloc'.
2891 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2892 non-zero, only free the data buffer without restoring the cache
2893 contents. All callers changed.
2894
2895 * dispextern.h (bidi_unshelve_cache): Update prototype.
2896
2897 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2898 (move_it_in_display_line, move_it_to)
2899 (move_it_vertically_backward, move_it_by_lines): Replace the call
2900 to xfree to an equivalent call to bidi_unshelve_cache.
2901 (move_it_in_display_line_to): Fix logic of returning
2902 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2903
2904 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2905
2906 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2907 came from a string character with a `cursor' property. (Bug#9229)
2908
2909 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2910
2911 * Makefile.in (LIB_PTHREAD): New variable.
2912 (LIBES): Add LIB_PTHREAD (Bug#9216).
2913
2914 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2915 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2916
2917 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2918
2919 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2920
2921 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2922
2923 * xterm.c (x_find_topmost_parent): New function.
2924 (x_set_frame_alpha): Find topmost parent window with
2925 x_find_topmost_parent and set the property there also (bug#9181).
2926 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2927
2928 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 * callproc.c (Fcall_process): Avoid vfork clobbering
2931 the local vars buffer, coding_systems, current_dir.
2932
2933 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2934
2935 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2936
2937 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2938
2939 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2940 so that it is not optimized away.
2941
2942 * xdisp.c (compute_display_string_pos): Remove unused local.
2943
2944 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2945
2946 Fix slow cursor motion and scrolling in large buffers with
2947 selective display, like Org Mode buffers. (Bug#9218)
2948
2949 * dispextern.h (struct bidi_it): New member disp_prop_p.
2950
2951 * xdisp.c: Remove one-slot cache of display string positions.
2952 (compute_display_string_pos): Accept an additional argument
2953 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2954 for a display string or property. If found, set DISP_PROP_P
2955 non-zero.
2956
2957 * bidi.c (bidi_fetch_char): Accept an additional argument
2958 DISP_PROP_P, and pass it to compute_display_string_pos.
2959 Only handle text covered by a display string if DISP_PROP_P is returned
2960 non-zero. All callers of bidi_fetch_char changed.
2961
2962 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2963
2964 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2965
2966 2010-12-03 Don March <don@ohspite.net>
2967
2968 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2969 last character M-[char] is translated to ESC [char] (bug#7541).
2970
2971 2011-08-02 Kenichi Handa <handa@m17n.org>
2972
2973 * lisp.h (uniprop_table): Extern it.
2974
2975 * chartab.c (uniprop_table): Make it non-static.
2976
2977 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2978
2979 * xdisp.c (forward_to_next_line_start): Accept additional argument
2980 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2981 on the newline.
2982 (reseat_at_next_visible_line_start): Use the bidi iterator state
2983 returned by forward_to_next_line_start to restore the state of
2984 it->bidi_it after backing up to previous newline. (Bug#9212)
2985
2986 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2987
2988 * regex.c (re_comp): Protoize.
2989 (re_exec): Fix return type.
2990 (regexec): Fix type of `ret'. (Bug#9203)
2991
2992 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2993
2994 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2995 This is needed if max-image-size is a floating-point number.
2996
2997 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2998
2999 * print.c (print_object): Print empty symbol as ##.
3000
3001 * lread.c (read1): Read ## as empty symbol.
3002
3003 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3004
3005 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3006 setting frame foreground color (Bug#9175).
3007 (x_set_background_color): Likewise.
3008
3009 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3010 contents (Bug#9176).
3011 (EmacsTooltip -init): Remove bezels and add shadows to
3012 tooltip windows.
3013
3014 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3015 or scroll bar (Bug#8470).
3016
3017 * nsfont.m (nsfont_open): Remove assignment to voffset and
3018 unnecessary vars hshink, expand, hd, full_height, min_height.
3019 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3020
3021 * nsterm.h (nsfont_info): Remove voffset field.
3022
3023 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3024
3025 Implement strike-through and overline on NextStep (Bug#8863).
3026
3027 * nsfont.m (nsfont_open): Use underline position provided by font,
3028 instead of hard-coded value of 2.
3029 (nsfont_draw): Call ns_draw_text_decoration instead.
3030
3031 * nsterm.h: Add declaration for ns_draw_text_decoration.
3032
3033 * nsterm.m (ns_draw_text_decoration): New function for drawing
3034 underline, overline, and strike-through.
3035 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3036 ns_draw_text_decoration. Change treatment of cursor drawing to
3037 accommodate underlining, etc.
3038
3039 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3040
3041 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3042 default.
3043
3044 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3045
3046 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3047 Without this fix, if a signal arrives just after memory fills up,
3048 'malloc' might be invoked reentrantly.
3049
3050 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3051 In other words, assume that every image size is allowed, on non-X
3052 hosts. This assumption is probably wrong, but it lets Emacs compile.
3053
3054 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3055
3056 * regex.c (re_iswctype): Convert return values to boolean.
3057
3058 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3059
3060 * xdisp.c (compute_display_string_pos): Don't use cached display
3061 string position if the buffer had its restriction changed.
3062 (Bug#9184)
3063
3064 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3065
3066 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3067
3068 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3069
3070 Integer signedness and overflow and related fixes. (Bug#9079)
3071
3072 * bidi.c: Integer size and overflow fixes.
3073 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3074 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3075 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3076 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3077 (bidi_find_other_level_edge):
3078 Use ptrdiff_t instead of EMACS_INT where either will do.
3079 This works better on 32-bit hosts configured --with-wide-int.
3080 (bidi_cache_ensure_space): Check for size-calculation overflow.
3081 Use % rather than repeated addition, for better worst-case speed.
3082 Don't set bidi_cache_size until after xrealloc returns, because it
3083 might not return.
3084 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3085 (bidi_cache_ensure_space): Also check that the bidi cache size
3086 does not exceed that of the largest Lisp string or buffer. See Eli
3087 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3088
3089 * alloc.c (__malloc_size_t): Remove.
3090 All uses replaced by size_t. See Andreas Schwab's note
3091 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3092
3093 * image.c: Improve checking for integer overflow.
3094 (check_image_size): Assume that f is nonnull, since
3095 it is always nonnull in practice. This is one less thing to
3096 worry about when checking for integer overflow later.
3097 (x_check_image_size): New function, which checks for integer
3098 overflow issues inside X.
3099 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3100 This removes the need for a memory_full check.
3101 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3102 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3103 (xbm_read_bitmap_data): Change locals back to 'int', since
3104 their values must fit in 'int'.
3105 (xpm_load_image, png_load, tiff_load):
3106 Invoke x_create_x_image_and_pixmap earlier,
3107 to avoid much needless work if the image is too large.
3108 (tiff_load): Treat overly large images as if
3109 x_create_x_image_and_pixmap failed, not as malloc failures.
3110 (gs_load): Use x_check_image_size.
3111
3112 * gtkutil.c: Omit integer casts.
3113 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3114 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3115
3116 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3117
3118 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3119 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3120 would wrongly return t on a 64-bit host.
3121
3122 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3123 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3124 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3125 and therefore cause GCC to emit a bogus diagnostic in some cases.
3126
3127 * image.c: Integer signedness and overflow and related fixes.
3128 This is not an exhaustive set of fixes, but it's time to
3129 record what I've got.
3130 (lookup_pixel_color, check_image_size): Remove redundant decls.
3131 (check_image_size): Don't assume that arbitrary EMACS_INT values
3132 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3133 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3134 (tiff_load, imagemagick_load_image):
3135 Check for overflow in size calculations.
3136 (x_create_x_image_and_pixmap): Remove unnecessary test for
3137 xmalloc returning NULL; that can't happen.
3138 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3139 (xpm_color_bucket): Use better integer hashing function.
3140 (xpm_cache_color): Don't possibly over-allocate memory.
3141 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3142 (gif_memory_source):
3143 Use ptrdiff_t, not int or size_t, to record sizes.
3144 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3145 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3146 either works, as we prefer signed integers.
3147 (tiff_read_from_memory, tiff_write_from_memory):
3148 Return tsize_t, not size_t, since that's what the TIFF API wants.
3149 (tiff_read_from_memory): Don't fail simply because the read would
3150 go past EOF; instead, return a short read.
3151 (tiff_load): Omit no-longer-needed casts.
3152 (Fimagemagick_types): Don't assume size fits into 'int'.
3153
3154 Improve hashing quality when configured --with-wide-int.
3155 * fns.c (hash_string): New function, taken from sxhash_string.
3156 Do not discard information about ASCII character case; this
3157 discarding is no longer needed.
3158 (sxhash-string): Use it. Change sig to match it. Caller changed.
3159 * lisp.h: Declare it.
3160 * lread.c (hash_string): Remove, since we now use fns.c's version.
3161 The fns.c version returns a wider integer if --with-wide-int is
3162 specified, so this should help the quality of the hashing a bit.
3163
3164 * emacs.c: Integer overflow minor fix.
3165 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3166 Define only if GNU_LINUX.
3167 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3168
3169 * dispnew.c: Integer signedness and overflow fixes.
3170 Remove unnecessary forward decls, that were a maintenance hassle.
3171 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3172 All uses changed.
3173 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3174 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3175 (prepare_desired_row, line_draw_cost):
3176 Use int, not unsigned, where either works.
3177 (save_current_matrix, restore_current_matrix):
3178 Use ptrdiff_t, not size_t, where either works.
3179 (init_display): Check for overflow more accurately, and without
3180 relying on undefined behavior.
3181
3182 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3183 Remove, replacing with the new symbols in lisp.h. All uses changed.
3184 * fileio.c (make_temp_name):
3185 * filelock.c (lock_file_1, lock_file):
3186 * xdisp.c (message_dolog):
3187 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3188 Use pMd etc. instead.
3189 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3190 replacing the pWIDE etc. symbols removed from editfns.c.
3191
3192 * keyboard.h (num_input_events): Now uintmax_t.
3193 This is (very slightly) less likely to mess up due to wraparound.
3194 All uses changed.
3195
3196 * buffer.c: Integer signedness fixes.
3197 (alloc_buffer_text, enlarge_buffer_text):
3198 Use ptrdiff_t rather than size_t when either will do, as we prefer
3199 signed integers.
3200
3201 * alloc.c: Integer signedness and overflow fixes.
3202 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3203 (__malloc_size_t): Default to size_t, not to int.
3204 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3205 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3206 Prefer ptrdiff_t to size_t when either would do, as we prefer
3207 signed integers.
3208 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3209 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3210 Now const. Initialize with values that are in range even if char
3211 is signed.
3212 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3213 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3214 These functions do the right thing with sizes > 2**32.
3215 (check_depth): Now ptrdiff_t, not int.
3216 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3217 Adjust to new way of storing sizes. Check for size overflow bugs
3218 in rest of code.
3219 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3220 slightly wrong anyway, as it missed one instance of
3221 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3222 (refill_memory_reserve): Omit needless cast to size_t.
3223 (mark_object_loop_halt): Mark as externally visible.
3224
3225 * xselect.c: Integer signedness and overflow fixes.
3226 (Fx_register_dnd_atom, x_handle_dnd_message):
3227 Use ptrdiff_t, not size_t, since we prefer signed.
3228 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3229 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3230 x_dnd_atoms_size and x_dnd_atoms_length.
3231
3232 * doprnt.c: Prefer signed to unsigned when either works.
3233 * eval.c (verror):
3234 * doprnt.c (doprnt):
3235 * lisp.h (doprnt):
3236 * xdisp.c (vmessage):
3237 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3238 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3239 prefer signed arithmetic to avoid comparison confusion.
3240 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3241 but is a bit tricky.
3242
3243 Assume freestanding C89 headers, string.h, stdlib.h.
3244 * data.c, doprnt.c, floatfns.c, print.c:
3245 Include float.h unconditionally.
3246 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3247 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3248 * regex.c: Likewise for stddef.h, string.h.
3249 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3250 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3251 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3252 (STDC_HEADERS): Remove obsolete defines.
3253 * sysdep.c: Include limits.h unconditionally.
3254
3255 Assume support for memcmp, memcpy, memmove, memset.
3256 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3257 * regex.c (memcmp, memcpy):
3258 Remove; we assume C89 now.
3259
3260 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3261 (__malloc_safe_bcopy): Remove; no longer needed.
3262
3263 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3264 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3265 well either way, and we prefer signed to unsigned.
3266
3267 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3268
3269 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3270 closes the connection while we're reading (bug#9182).
3271
3272 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3273
3274 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3275 are specified (Bug#9168).
3276
3277 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3280 Found by GCC static checking and --with-wide-int on a 32-bit host.
3281
3282 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3283
3284 * xdisp.c (compute_display_string_pos): Fix logic of caching
3285 previous display string position. Initialize cached_prev_pos to
3286 -1. Fixes slow-down at the beginning of a buffer.
3287
3288 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3289
3290 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3291 for attrs[LFACE_FONTSET_INDEX].
3292
3293 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3294
3295 * xml.c (parse_region): Remove unused local
3296 that was recently introduced.
3297
3298 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3299
3300 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3301 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3302
3303 * xdisp.c (move_it_in_display_line_to): Record the best matching
3304 position for TO_CHARPOS while scanning the line, and restore it on
3305 exit if none of the characters scanned was an exact match.
3306 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3307 when exact match is impossible due to invisible text, and the
3308 lines are truncated.
3309
3310 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3311
3312 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3313 for OSX >= 10.7.
3314
3315 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3316
3317 Fix a significant slow-down of cursor motion with C-n, C-p,
3318 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3319 auto-repeat under bidi redisplay in fontified buffers.
3320 * xdisp.c (compute_stop_pos_backwards): New function.
3321 (next_element_from_buffer): Call compute_stop_pos_backwards to
3322 find a suitable prev_stop when we find ourselves before
3323 base_level_stop.
3324 (reseat): Don't look for prev_stop, as that could mean a very long
3325 run.
3326 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3327 <cached_disp_overlay_modiff>: Cache for last found display string
3328 position.
3329 (compute_display_string_pos): Return the cached position if asked
3330 about the same buffer in the same area of character positions, and
3331 the buffer wasn't changed since the time the display string
3332 position was cached.
3333
3334 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3335
3336 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3337 is an integer, which is important for empty lines. (Bug#9149)
3338
3339 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3340
3341 * frame.c (Fmodify_frame_parameters): In tty case, update the
3342 default face if necessary (Bug#4238).
3343
3344 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3345
3346 * editfns.c (Fstring_to_char): No need to explain what a character
3347 is in the docstring (Bug#6576).
3348
3349 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3350
3351 * xml.c (parse_region): Make sure we always return a tree.
3352
3353 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3354
3355 * xml.c (parse_region): If a document contains only comments,
3356 return that, too.
3357
3358 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3359
3360 * xml.c (make_dom): Return comments, too.
3361
3362 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3363
3364 Port to OpenBSD.
3365 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3366 and the surrounding thread.
3367 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3368 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3369 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3370 timer goes off.
3371 * s/openbsd.h (BROKEN_SIGIO): Define.
3372 * unexelf.c (unexec) [__OpenBSD__]:
3373 Don't update the .mdebug section of the Alpha COFF symbol table.
3374
3375 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3376
3377 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3378 (bug#8460).
3379
3380 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3383 This fixes some race conditions on the permissions of any newly
3384 created file.
3385
3386 * alloc.c (valid_pointer_p): Use pipe, not open.
3387 This fixes some permissions issues when debugging.
3388
3389 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3390 If fchown fails to set both uid and gid, try to set just gid,
3391 as that is sometimes allowed. Adjust the file's mode to eliminate
3392 setuid or setgid bits that are inappropriate if fchown fails.
3393
3394 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3395
3396 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3397 to compare Lisp_Objects.
3398 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3399 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3400 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3401
3402 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3403
3404 * lread.c (read_integer): Unread even EOF character.
3405 (read1): Likewise. Properly record start position of symbol.
3406
3407 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3408 symbol character follows.
3409
3410 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3411
3412 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3413 This works around a problem with the previous change to Fcopy_file.
3414 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3415 and without this change, GCC might complain about discarding
3416 fchown's return value.
3417
3418 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3419
3420 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3421
3422 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3423
3424 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3425
3426 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3427
3428 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3429 it's used from the C level.
3430
3431 * process.c: Use the same condition for POLL_FOR_INPUT in both
3432 keyboard.c and process.c (bug#1858).
3433
3434 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3435
3436 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3437 (Fgnutls_boot): Use it.
3438
3439 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3440
3441 * doc.c (Fsubstitute_command_keys): Revert last change.
3442
3443 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3444
3445 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3446 quotes the next character, and doesn't affect other longer
3447 sequences (bug#8935).
3448
3449 * lread.c (syms_of_lread): Clarify that is isn't only
3450 `eval-buffer' and `eval-defun' that's affected by
3451 `lexical-binding' (bug#8460).
3452
3453 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3454
3455 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3456 bidi redisplay when a line includes both an image and is truncated.
3457
3458 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3459
3460 Fix minor problems found by static checking.
3461 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3462 (elsz): Now a signed constant, not a size_t var. We prefer signed
3463 types to unsigned, to avoid integer comparison confusion. Without
3464 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3465 "cannot optimize loop, the loop counter may overflow", a symptom
3466 of the confusion.
3467 * indent.c (Fvertical_motion): Mark locals as initialized.
3468 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3469
3470 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3471
3472 * search.c (Fre_search_backward): Mention `case-fold-search' in
3473 all the re_search_* functions (bug#8138).
3474
3475 * keyboard.c (Fopen_dribble_file): Document when the file is
3476 closed (bug#8056).
3477
3478 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3479
3480 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3481 bidi_cache_idx.
3482
3483 Support bidi reordering of display and overlay strings.
3484 * xdisp.c (compute_display_string_pos)
3485 (compute_display_string_end): Accept additional argument STRING.
3486 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3487 (reseat_to_string): Initialize bidi_it->string.s and
3488 bidi_it->string.schars.
3489 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3490 NULL (avoids a crash in bidi_paragraph_init).
3491 Initialize itb.string.lstring.
3492 (init_iterator): Call bidi_init_it only of a valid
3493 buffer position was specified. Initialize paragraph_embedding to
3494 L2R.
3495 (reseat_to_string): Initialize the bidi iterator.
3496 (display_string): If we need to ignore text properties of
3497 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3498 original value of -1 will not work with bidi.)
3499 (compute_display_string_pos): First arg is now struct
3500 `text_pos *'; all callers changed. Support display properties on
3501 Lisp strings.
3502 (compute_display_string_end): Support display properties on Lisp
3503 strings.
3504 (init_iterator, reseat_1, reseat_to_string): Initialize the
3505 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3506 when iterating on a string not from display properties).
3507 (compute_display_string_pos, compute_display_string_end):
3508 Fix calculation of the object to scan. Fixes an error when using
3509 arrow keys.
3510 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3511 base_level_stop; instead, set base_level_stop to BEGV.
3512 Fixes crashes in vertical-motion.
3513 (next_element_from_buffer): Improve commentary for when
3514 the iterator is before prev_stop.
3515 (init_iterator): Initialize bidi_p from the default value of
3516 bidi-display-reordering, not from buffer-local value. Use the
3517 buffer-local value only if initializing for buffer iteration.
3518 (handle_invisible_prop): Support invisible properties on strings
3519 that are being bidi-reordered.
3520 (set_iterator_to_next): Support bidi reordering of C strings and
3521 Lisp strings.
3522 (next_element_from_string): Support bidi reordering of Lisp
3523 strings.
3524 (handle_stop_backwards): Support Lisp strings as well.
3525 (display_string): Support display of R2L glyph rows.
3526 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3527 (init_iterator): Don't initialize it->bidi_p for strings
3528 here.
3529 (reseat_to_string): Initialize it->bidi_p for strings here.
3530 (next_element_from_string, next_element_from_c_string)
3531 (next_element_from_buffer): Add xassert's for correspondence
3532 between IT's object being iterated and it->bidi_it.string
3533 structure.
3534 (face_before_or_after_it_pos): Support bidi iteration.
3535 (next_element_from_c_string): Handle the case of the first string
3536 character that is not the first one in the visual order.
3537 (get_visually_first_element): New function, refactored from common
3538 parts of next_element_from_buffer, next_element_from_string, and
3539 next_element_from_c_string.
3540 (tool_bar_lines_needed, redisplay_tool_bar)
3541 (display_menu_bar): Force left-to-right direction. Add a FIXME
3542 comment for making that be controlled by a user option.
3543 (push_it, pop_it): Save and restore the state of the
3544 bidi iterator. Save and restore the bidi_p flag.
3545 (pop_it): Iterate out of display property for string iteration as
3546 well.
3547 (iterate_out_of_display_property): Support iteration over strings.
3548 (handle_single_display_spec): Set up it->bidi_it for iteration
3549 over a display string, and call bidi_init_it.
3550 (handle_single_display_spec, next_overlay_string)
3551 (get_overlay_strings_1, push_display_prop): Set up the bidi
3552 iterator for displaying display or overlay strings.
3553 (forward_to_next_line_start): Don't use the shortcut if
3554 bidi-iterating.
3555 (back_to_previous_visible_line_start): If handle_display_prop
3556 pushed the iterator stack, restore the internal state of the bidi
3557 iterator by calling bidi_pop_it same number of times.
3558 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3559 and we are bidi-iterating, don't decrement the iterator position;
3560 instead, set the first_elt flag in the bidi iterator, to produce
3561 the same effect.
3562 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3563 (push_display_prop): xassert that we are iterating a buffer.
3564 (push_it, pop_it): Save and restore paragraph_embedding member.
3565 (handle_single_display_spec, next_overlay_string)
3566 (get_overlay_strings_1, reseat_1, reseat_to_string)
3567 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3568 correctly. Don't assume unibyte strings are not bidi-reordered.
3569 (compute_display_string_pos)
3570 (compute_display_string_end): Fix handling the case of C string.
3571 (push_it, pop_it): Save and restore from_disp_prop_p.
3572 (handle_single_display_spec, push_display_prop): Set the
3573 from_disp_prop_p flag.
3574 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3575 (pop_it): Call iterate_out_of_display_property only if we are
3576 popping after iteration over a string that came from a display
3577 property. Fix a typo in popping stretch info. Add an assertion
3578 for verifying that the iterator position is in sync with the bidi
3579 iterator.
3580 (handle_single_display_spec, get_overlay_strings_1)
3581 (push_display_prop): Fix initialization of paragraph direction for
3582 string when that of the parent object is not yet determined.
3583 (reseat_1): Call bidi_init_it to resync the bidi
3584 iterator with IT's position. (Bug#7616)
3585 (find_row_edges): If ROW->start.pos gives position
3586 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3587 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3588 Reset the from_disp_prop_p flag.
3589 (SAVE_IT, RESTORE_IT): New macros.
3590 (pos_visible_p, face_before_or_after_it_pos)
3591 (back_to_previous_visible_line_start)
3592 (move_it_in_display_line_to, move_it_in_display_line)
3593 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3594 (try_scrolling, redisplay_window, display_line): Use them when
3595 saving a temporary copy of the iterator and restoring it back.
3596 (back_to_previous_visible_line_start, reseat_1)
3597 (init_iterator): Empty the bidi cache "stack".
3598 (move_it_in_display_line_to): If iterator ended up at
3599 EOL, but we never saw any buffer positions smaller than
3600 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3601 motion in bidi-reordered lines.
3602 (move_it_in_display_line_to): Record prev_method and prev_pos
3603 immediately before the call to set_iterator_to_next. Fixes cursor
3604 motion in bidi-reordered lines with stretch glyphs and strings
3605 displayed in margins. (Bug#8133) (Bug#8867)
3606 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3607 TO_CHARPOS.
3608 (pos_visible_p): Support positions in bidi-reordered lines.
3609 Save and restore bidi cache.
3610
3611 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3612 (bidi_paragraph_info): Delete unused struct.
3613 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3614 (bidi_cache_start): New variable.
3615 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3616 to zero.
3617 (bidi_cache_fetch_state, bidi_cache_search)
3618 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3619 (bidi_cache_find, bidi_peek_at_next_level)
3620 (bidi_level_of_next_char, bidi_find_other_level_edge)
3621 (bidi_move_to_visually_next): Compare cache index with
3622 bidi_cache_start rather than with zero.
3623 (bidi_fetch_char): Accept new argument STRING; all callers
3624 changed. Support iteration over a string. Support strings with
3625 display properties. Support unibyte strings. Fix the type of
3626 `len' according to what STRING_CHAR_AND_LENGTH expects.
3627 (bidi_paragraph_init, bidi_resolve_explicit_1)
3628 (bidi_resolve_explicit, bidi_resolve_weak)
3629 (bidi_level_of_next_char, bidi_move_to_visually_next):
3630 Support iteration over a string.
3631 (bidi_set_sor_type, bidi_resolve_explicit_1)
3632 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3633 can now be zero (for strings); special values 0 and -1 were
3634 changed to -1 and -2, respectively.
3635 (bidi_char_at_pos): New function.
3636 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3637 Call it instead of FETCH_MULTIBYTE_CHAR.
3638 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3639 initialized to valid values.
3640 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3641 values.
3642 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3643 the test for valid cached positions. Fix the logic for looking up
3644 the sentinel state in the cache. GCPRO the Lisp string we are
3645 iterating.
3646 (bidi_push_it, bidi_pop_it): New functions.
3647 (bidi_initialize): Initialize the bidi cache start stack pointer.
3648 (bidi_cache_ensure_space): New function, refactored from part of
3649 bidi_cache_iterator_state. Don't assume the required size is just
3650 one BIDI_CACHE_CHUNK away.
3651 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3652 (bidi_count_bytes, bidi_char_at_pos): New functions.
3653 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3654 always valid if bidi_cache_idx is valid.
3655 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3656 is valid if it's going to be used.
3657 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3658 (bidi_cache_fetch_state, bidi_cache_search)
3659 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3660 (bidi_cache_iterator_state, bidi_cache_find)
3661 (bidi_find_other_level_edge, bidi_cache_start_stack):
3662 All variables related to cache indices are now EMACS_INT.
3663
3664 * dispextern.h (struct bidi_string_data): New structure.
3665 (struct bidi_it): New member `string'. Make flag members be 1-bit
3666 fields, and put them last in the struct.
3667 (compute_display_string_pos, compute_display_string_end):
3668 Update prototypes.
3669 (bidi_push_it, bidi_pop_it): Add prototypes.
3670 (struct iterator_stack_entry): New members bidi_p,
3671 paragraph_embedding, and from_disp_prop_p.
3672 (struct it): Member bidi_p is now a bit field 1 bit wide.
3673 (bidi_shelve_cache, bidi_unshelve_cache):
3674 Declare prototypes.
3675
3676 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3677 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3678 and vector-like objects.
3679
3680 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3681 cache around display iteration.
3682
3683 * window.c (Fwindow_end, window_scroll_pixel_based)
3684 (displayed_window_lines, Frecenter): Save and restore the bidi
3685 cache around display iteration.
3686
3687 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3688
3689 * editfns.c (Fdelete_region): Clarify the use of the named
3690 parameters (bug#6788).
3691
3692 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3693
3694 * indent.c (Fvertical_motion): Set and restore w->pointm when
3695 saving and restoring the window's buffer (Bug#9006).
3696
3697 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3698
3699 * editfns.c (Fstring_to_char): Clarify just what is returned
3700 (bug#6576). Text by Eli Zaretskii.
3701
3702 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3703
3704 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3705
3706 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3707
3708 * buffer.c (mmap_find): Fix a typo.
3709
3710 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3711
3712 Fix execution of x selection hooks.
3713 * xselect.c (Qx_lost_selection_functions)
3714 (Qx_sent_selection_functions): New vars.
3715 (syms_of_xselect): DEFSYM them.
3716 (x_handle_selection_request): Pass Qx_sent_selection_functions
3717 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3718 (x_handle_selection_clear,x_clear_frame_selections):
3719 Pass Qx_lost_selection_functions rather than
3720 Vx_lost_selection_functions to Frun_hook_with_args.
3721
3722 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3723
3724 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3725 The old code sometimes used this field without initializing it.
3726
3727 * alloc.c (gc_sweep): Don't read past end of array.
3728 In theory, the old code could also have corrupted Emacs internals,
3729 though it'd be very unlikely.
3730
3731 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3732
3733 * character.c (Fcharacterp): Don't advertise optional ignored
3734 argument. (Bug#4026)
3735
3736 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3737
3738 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3739 key" (bug#4257).
3740
3741 * window.c (Fset_window_start): Doc fix (bug#4199).
3742 (Fset_window_hscroll): Ditto.
3743
3744 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3745
3746 Fix minor new problems caught by GCC 4.6.1.
3747 * term.c (init_tty): Remove unused local.
3748 * xsettings.c (store_monospaced_changed): Define this function only
3749 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3750 not used otherwise.
3751
3752 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3753
3754 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3755
3756 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3757
3758 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3759 are the mini-buffer and the echo area (bug#3320).
3760
3761 * term.c (init_tty): Remove support for supdup, c10 and perq
3762 terminals, which are no longer supported (bug#1482).
3763
3764 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3765
3766 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3767
3768 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3769
3770 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3771 for non-popups (Bug#3642).
3772
3773 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3774
3775 * alloc.c (reset_malloc_hooks): Protoize.
3776 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3777 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3778 * cm.c (losecursor): Likewise.
3779 * data.c (fmod): Likewise.
3780 * dispnew.c (swap_glyphs_in_rows): Likewise.
3781 * emacs.c (memory_warning_signal): Likewise.
3782 * floatfns.c (float_error): Likewise.
3783 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3784 (otf_open, font_otf_capability, generate_otf_features)
3785 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3786 Likewise.
3787 * image.c (pbm_read_file): Likewise.
3788 * indent.c (string_display_width): Likewise.
3789 * intervals.c (check_for_interval, search_for_interval)
3790 (inc_interval_count, count_intervals, root_interval)
3791 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3792 * lread.c (defalias): Likewise.
3793 * ralloc.c (r_alloc_check): Likewise.
3794 * regex.c (set_image_of_range_1, set_image_of_range)
3795 (regex_grow_registers): Likewise.
3796 * sysdep.c (strerror): Likewise.
3797 * termcap.c (valid_filename_p, tprint, main): Likewise.
3798 * tparam.c (main): Likewise.
3799 * unexhp9k800.c (run_time_remap, save_data_space)
3800 (update_file_ptrs, read_header, write_header, calculate_checksum)
3801 (copy_file, copy_rest, display_header): Likewise.
3802 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3803 Likewise.
3804 * xdisp.c (check_it): Likewise.
3805 * xfaces.c (register_color, unregister_color, unregister_colors):
3806 Likewise.
3807 * xfns.c (print_fontset_result): Likewise.
3808 * xrdb.c (member, fatal, main): Likewise.
3809
3810 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 Fix minor problems found by static checking (Bug#9031).
3813 * chartab.c (char_table_set_range, map_sub_char_table):
3814 Remove unused locals.
3815 (uniprop_table): Now static.
3816 * composite.c (_work_char): Remove unused static var.
3817
3818 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3819
3820 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3821
3822 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3823
3824 * gtkutil.c (qttip_cb): Remove code without function.
3825
3826 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3827
3828 * w32.c (pthread_sigmask): New stub.
3829
3830 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 Use pthread_sigmask, not sigprocmask (Bug#9010).
3833 sigprocmask is portable only for single-threaded applications, and
3834 Emacs can be multi-threaded when it uses GTK.
3835 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3836 (LIBES): Use it.
3837 * callproc.c (Fcall_process):
3838 * process.c (create_process):
3839 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3840 Use pthread_sigmask, not sigprocmask.
3841
3842 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3843
3844 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3845 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3846 wrong (Bug#8591).
3847
3848 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3849
3850 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3851 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3852 (xg_hide_tooltip): Fix comment.
3853
3854 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3855 in registerServicesMenuSendTypes.
3856 (validRequestorForSendType): Don't check ns_return_types.
3857
3858 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3859 ns_return_type.
3860
3861 2011-07-08 Jason Rumney <jasonr@gnu.org>
3862
3863 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3864 SH_SHOW for hidden windows (Bug#5482).
3865
3866 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3867 frame struct members of non-existent frames (Bug#6284).
3868
3869 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3870
3871 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3872 variable firstTime not needed on OSX >= 10.6.
3873 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3874 >= 10.5. Use setKnobProportion, setDoubleValue.
3875
3876 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3877 (MAC_OS_X_VERSION_10_5): Define if not defined.
3878 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3879 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3880 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3881
3882 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3883 cString and lossyCString on OSX >= 10.4
3884
3885 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3886 sizeToFit on OSX >= 10.2.
3887
3888 * nsimage.m (allocInitFromFile): Don't use deprecated method
3889 bestRepresentationForDevice on OSX >= 10.6.
3890
3891 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3892 to avoid warning.
3893
3894 * emacs.c: Declare unexec_init_emacs_zone.
3895
3896 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3897
3898 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3899
3900 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3901 on svcsMenu (Bug#8842).
3902
3903 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3904 ns_return_types.
3905 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3906
3907 * nsterm.m (QUTF8_STRING): Declare.
3908 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3909 (validRequestorForSendType): Return type is (id).
3910 Change indexOfObjectIdenticalTo to indexOfObject.
3911 Check if we have local selection before returning self (Bug#8842).
3912 (writeSelectionToPasteboard): Put local selection into paste board
3913 if we have a local selection (Bug#8842).
3914 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3915
3916 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3917 (ns_get_local_selection): Declare.
3918
3919 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3920
3921 * keymap.c (describe_map_tree): Don't insert a double newline at
3922 the end of the buffer (bug#1169) and return whether we inserted
3923 something.
3924
3925 * callint.c (Fcall_interactively): Change "reading args" to
3926 "providing args" to try to clarify what it does (bug#1010).
3927
3928 2011-07-07 Kenichi Handa <handa@m17n.org>
3929
3930 * composite.c (composition_compute_stop_pos): Ignore a static
3931 composition starting before CHARPOS (Bug#8915).
3932
3933 * xdisp.c (handle_composition_prop): Likewise.
3934
3935 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3936
3937 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3938 (Bug#9015)
3939
3940 2011-07-07 Kenichi Handa <handa@m17n.org>
3941
3942 * character.h (unicode_category_t): New enum type.
3943
3944 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3945 (Qchar_code_property_table): New variable.
3946 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3947 (UNIPROP_COMPRESSED_FORM_P): New macros.
3948 (char_table_ascii): Uncompress the compressed values.
3949 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3950 Uncompress the compressed values.
3951 (sub_char_table_ref_and_range): Likewise.
3952 (char_table_ref_and_range): Uncompress the compressed values.
3953 (sub_char_table_set): New arg is_uniprop. Callers changed.
3954 Uncompress the compressed values.
3955 (sub_char_table_set_range): Args changed. Callers changed.
3956 (char_table_set_range): Adjuted for the above change.
3957 (map_sub_char_table): Delete args default_val and parent. Add arg
3958 top. Give decoded values to a Lisp function.
3959 (map_char_table): Adjust for the above change. Give decoded
3960 values to a Lisp function. Gcpro more variables.
3961 (uniprop_table_uncompress)
3962 (uniprop_decode_value_run_length): New functions.
3963 (uniprop_decoder, uniprop_decoder_count): New variables.
3964 (uniprop_get_decoder, uniprop_encode_value_character)
3965 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3966 New functions.
3967 (uniprop_encoder, uniprop_encoder_count): New variables.
3968 (uniprop_get_encoder, uniprop_table)
3969 (Funicode_property_table_internal, Fget_unicode_property_internal)
3970 (Fput_unicode_property_internal): New functions.
3971 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3972 Sunicode_property_table_internal, Sget_unicode_property_internal,
3973 and Sput_unicode_property_internal. Defvar_lisp
3974 char-code-property-alist.
3975
3976 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3977 Vunicode_category_table.
3978
3979 * font.c (font_range): Adjust for the change of
3980 Vunicode_category_table.
3981
3982 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3983
3984 * m/iris4d.h: Remove file, move contents ...
3985 * s/irix6-5.h: ... here.
3986
3987 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3988
3989 Remove unportable assumption about struct layout (Bug#8884).
3990 * alloc.c (mark_buffer):
3991 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3992 (clone_per_buffer_values): Don't assume that
3993 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3994 This isn't true in general, and it's particularly not true
3995 if Emacs is configured with --with-wide-int.
3996 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3997 New macros, used in the buffer.c change.
3998
3999 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4000
4001 * xsettings.c: Use both GConf and GSettings if both are available.
4002 (store_config_changed_event): Add comment.
4003 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4004 (store_tool_bar_style_changed): New functions.
4005 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4006 (struct xsettings): Move font inside HAVE_XFT.
4007 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4008 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4009 Move inside HAVE_XFT.
4010 (something_changed_gsettingsCB): Rename from something_changedCB.
4011 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4012 also.
4013 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4014 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4015 (something_changed_gconfCB): Rename from something_changedCB.
4016 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4017 (parse_settings): Move check for font inside HAVE_XFT.
4018 (read_settings, apply_xft_settings): Add comment.
4019 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4020 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4021 call store_font_name_changed.
4022 (xft_settings_event): Add comment.
4023 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4024 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4025 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4026 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4027 (xsettings_initialize): Call init_gsettings last.
4028 (xsettings_get_system_font, xsettings_get_system_normal_font):
4029 Add comment.
4030
4031 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4032
4033 Random fixes. E.g., (random) never returned negative values.
4034 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4035 subseconds part to the entropy, as that's a bit more random.
4036 Prefer signed to unsigned, since the signedness doesn't matter and
4037 in general we prefer signed. When given a limit, use a
4038 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4039 latter isn't right if USE_2_TAGS_FOR_INTS.
4040 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4041 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4042
4043 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4044
4045 * textprop.c (text_property_stickiness):
4046 Obey Vtext_property_default_nonsticky.
4047 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4048 * w32fns.c (syms_of_w32fns):
4049 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4050
4051 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4052
4053 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4054 This is more efficient than Ffile_directory_p and avoids a minor race.
4055
4056 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4057
4058 * buffer.c (Foverlay_put): Say what the return value is
4059 (bug#7835).
4060
4061 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4062 is a directory before asking whether to use the file name
4063 (bug#7564).
4064 (barf_or_query_if_file_exists): Make the "File is a directory"
4065 error be more correct.
4066
4067 * fns.c (Frequire): Remove the mention of the .gz files, since
4068 that's installation-specific, but keep the mention of
4069 `get-load-suffixes'.
4070
4071 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4072
4073 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4074 Report string overflow if the output is too long.
4075
4076 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4077
4078 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4079 (syms_of_gnutls): Remove duplicate DEFSYM for
4080 Qgnutls_bootprop_verify_hostname_error, an error for
4081 Qgnutls_bootprop_verify_error (which is no longer used).
4082
4083 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4084 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4085 Also (re)move comments that are misplaced or no longer relevant.
4086
4087 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4088
4089 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4090
4091 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4092
4093 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4094 and background color parameters if they have been changed.
4095
4096 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4097
4098 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4099
4100 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4101
4102 * xsettings.c (SYSTEM_FONT): Define only when used.
4103 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4104
4105 * keymap.c (access_keymap_1): Now static.
4106
4107 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4108
4109 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4110 leave any prefix arg for the up event (Bug#1586).
4111
4112 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4113
4114 * lread.c (syms_of_lread): Mention single symbols defined by
4115 `defvar' or `defconst' (bug#7154).
4116
4117 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4118 (Frequire): Mention get-load-suffixes.
4119
4120 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4121
4122 * window.h (window): Remove clone_number slot.
4123 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4124 Remove.
4125 (make_parent_window, make_window, saved_window)
4126 (Fset_window_configuration, save_window_save): Don't deal with
4127 clone numbers.
4128 * buffer.c (Qclone_number): Remove declaration.
4129 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4130
4131 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4132
4133 Add multiple inheritance to keymaps.
4134 * keymap.c (Fmake_composed_keymap): New function.
4135 (Fset_keymap_parent): Simplify.
4136 (fix_submap_inheritance): Remove.
4137 (access_keymap_1): New function extracted from access_keymap to handle
4138 embedded parents and handle lists of maps.
4139 (access_keymap): Use it.
4140 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4141 (Fcopy_keymap): Handle embedded parents.
4142 (Fcommand_remapping, define_as_prefix): Simplify.
4143 (Fkey_binding): Simplify.
4144 (syms_of_keymap): Move minibuffer-local-completion-map,
4145 minibuffer-local-filename-completion-map,
4146 minibuffer-local-must-match-map, and
4147 minibuffer-local-filename-must-match-map to Elisp.
4148 (syms_of_keymap): Defsubr make-composed-keymap.
4149 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4150 (parse_menu_item): Trivial simplification.
4151
4152 2011-07-01 Glenn Morris <rgm@gnu.org>
4153
4154 * Makefile.in (SETTINGS_LIBS): Fix typo.
4155
4156 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4157
4158 * coding.c (Fencode_coding_string): Record the last coding system
4159 used, as the function doc string says (bug#8738).
4160
4161 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4162
4163 * xsettings.c (store_monospaced_changed): Take new font as arg and
4164 check for change against current_mono_font.
4165 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4166 (emacs_settings_constructor, emacs_settings_get_property)
4167 (emacs_settings_set_property, emacs_settings_class_init)
4168 (emacs_settings_init, gsettings_obj): Remove.
4169 (something_changedCB): New function for HAVE_GSETTINGS.
4170 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4171 with value as argument.
4172 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4173 g_settings_new (Bug#8967). Do not create gsettings_obj.
4174 Remove calls to g_settings_bind. Connect something_changedCB to
4175 "changed".
4176
4177 * xgselect.c: Add defined (HAVE_GSETTINGS).
4178 (xgselect_initialize): Ditto.
4179
4180 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4181 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4182 xg_select.
4183
4184 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4185
4186 * eval.c (struct backtrace): Simplify and port the data structure.
4187 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4188 signed bit field, as this assumption is not portable and it makes
4189 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4190 "char debug_on_exit : 1" as this is not portable either; instead,
4191 use the portable "unsigned int debug_on_exit : 1". Remove unused
4192 member evalargs. Remove obsolete comments about cc bombing out.
4193
4194 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4195
4196 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4197 Let HAVE_GSETTINGS override HAVE_GCONF.
4198 (store_monospaced_changed): New function.
4199 (EMACS_SETTINGS): A new type derived from GObject to handle
4200 GSettings notifications.
4201 (emacs_settings_constructor, emacs_settings_get_property)
4202 (emacs_settings_set_property, emacs_settings_class_init):
4203 New functions.
4204 (gsettings_client, gsettings_obj): New variables.
4205 (GSETTINGS_SCHEMA): New define.
4206 (something_changedCB): Call store_monospaced_changed.
4207 (init_gsettings): New function.
4208 (xsettings_initialize): Call init_gsettings.
4209 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4210 to NULL.
4211
4212 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4213 GCONF_CFLAGS/LIBS.
4214
4215 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4216
4217 * window.c (resize_root_window, grow_mini_window)
4218 (shrink_mini_window): Rename Qresize_root_window to
4219 Qwindow_resize_root_window and Qresize_root_window_vertically to
4220 Qwindow_resize_root_window_vertically.
4221
4222 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4223
4224 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4225
4226 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4227
4228 * makefile.w32-in: Redesign dependencies so they reflect more
4229 clearly which files are directly included by each source file,
4230 and not through other includes.
4231
4232 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4233
4234 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4235 (sort_overlays, overlay_strings): When an overlay's clone number
4236 matches the window's clone number process the overlay even if
4237 the overlay's window property doesn't match the current window.
4238
4239 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4240 (Fwindow_hchild): Rename to Fwindow_left_child.
4241 (Fwindow_next): Rename to Fwindow_next_sibling.
4242 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4243 (resize_window_check): Rename to window_resize_check.
4244 (resize_window_apply): Rename to window_resize_apply.
4245 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4246 (Fdelete_other_windows_internal, resize_frame_windows)
4247 (Fsplit_window_internal, Fdelete_window_internal)
4248 (grow_mini_window, shrink_mini_window)
4249 (Fresize_mini_window_internal): Fix callers accordingly.
4250
4251 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4252
4253 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4254 (emacs_fixed_set_min_size): Remove.
4255 (emacs_fixed_new): Take frame as argument.
4256
4257 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4258 (_EmacsFixedPrivate): Remove minwidth/height.
4259 Add struct frame *f.
4260 (emacs_fixed_init): Initialize priv->f.
4261 (get_parent_class, emacs_fixed_set_min_size): Remove.
4262 (emacs_fixed_new): Set priv->f to argument.
4263 (emacs_fixed_get_preferred_width)
4264 (emacs_fixed_get_preferred_height): Use min_width/height from
4265 frames size_hint to set minimum and natural (Bug#8919).
4266 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4267 and use min_width/height from frames size_hint to set
4268 min_width/height (Bug#8919).
4269
4270 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4271 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4272 Fix indentation.
4273
4274 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4275
4276 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4277 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4278 called at ZV.
4279
4280 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4281
4282 * process.c (wait_reading_process_output): Bypass select if
4283 waiting for a cell while ignoring keyboard input, and input is
4284 pending. Suggested by Jan Djärv (Bug#8869).
4285
4286 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4287
4288 Use gnulib's dup2 module instead of rolling our own.
4289 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4290
4291 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4292
4293 * dispnew.c (scrolling_window): Before scrolling, turn off a
4294 mouse-highlight in the window being scrolled.
4295
4296 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4297
4298 Move DEFSYM to lisp.h and use everywhere.
4299
4300 * character.h (DEFSYM): Move declaration...
4301 * lisp.h (DEFSYM): ...here.
4302
4303 * gnutls.c:
4304 * minibuf.c:
4305 * w32menu.c:
4306 * w32proc.c:
4307 * w32select.c: Don't include character.h.
4308
4309 * alloc.c (syms_of_alloc):
4310 * buffer.c (syms_of_buffer):
4311 * bytecode.c (syms_of_bytecode):
4312 * callint.c (syms_of_callint):
4313 * casefiddle.c (syms_of_casefiddle):
4314 * casetab.c (init_casetab_once):
4315 * category.c (init_category_once, syms_of_category):
4316 * ccl.c (syms_of_ccl):
4317 * cmds.c (syms_of_cmds):
4318 * composite.c (syms_of_composite):
4319 * dbusbind.c (syms_of_dbusbind):
4320 * dired.c (syms_of_dired):
4321 * dispnew.c (syms_of_display):
4322 * doc.c (syms_of_doc):
4323 * editfns.c (syms_of_editfns):
4324 * emacs.c (syms_of_emacs):
4325 * eval.c (syms_of_eval):
4326 * fileio.c (syms_of_fileio):
4327 * fns.c (syms_of_fns):
4328 * frame.c (syms_of_frame):
4329 * fringe.c (syms_of_fringe):
4330 * insdel.c (syms_of_insdel):
4331 * keymap.c (syms_of_keymap):
4332 * lread.c (init_obarray, syms_of_lread):
4333 * macros.c (syms_of_macros):
4334 * msdos.c (syms_of_msdos):
4335 * print.c (syms_of_print):
4336 * process.c (syms_of_process):
4337 * search.c (syms_of_search):
4338 * sound.c (syms_of_sound):
4339 * syntax.c (init_syntax_once, syms_of_syntax):
4340 * terminal.c (syms_of_terminal):
4341 * textprop.c (syms_of_textprop):
4342 * undo.c (syms_of_undo):
4343 * w32.c (globals_of_w32):
4344 * window.c (syms_of_window):
4345 * xdisp.c (syms_of_xdisp):
4346 * xfaces.c (syms_of_xfaces):
4347 * xfns.c (syms_of_xfns):
4348 * xmenu.c (syms_of_xmenu):
4349 * xsettings.c (syms_of_xsettings):
4350 * xterm.c (syms_of_xterm): Use DEFSYM.
4351
4352 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4353
4354 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4355
4356 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4357
4358 Integer and buffer overflow fixes (Bug#8873).
4359
4360 * print.c (printchar, strout): Check for string overflow.
4361 (PRINTPREPARE, printchar, strout):
4362 Don't set size unless allocation succeeds.
4363
4364 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4365 for sizes. Check for string overflow more accurately.
4366 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4367
4368 * macros.c: Integer and buffer overflow fixes.
4369 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4370 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4371 Use ptrdiff_t, not int, for sizes.
4372 Don't increment bufsize until after realloc succeeds.
4373 Check for size-calculation overflow.
4374 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4375
4376 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4377
4378 * lread.c: Integer overflow fixes.
4379 (read_integer): Radix is now EMACS_INT, not int,
4380 to improve quality of diagnostics for out-of-range radices.
4381 Calculate buffer size correctly for out-of-range radices.
4382 (read1): Check for integer overflow in radices, and in
4383 read-circle numbers.
4384 (read_escape): Avoid int overflow.
4385 (Fload, openp, read_buffer_size, read1)
4386 (substitute_object_recurse, read_vector, read_list, map_obarray):
4387 Use ptrdiff_t, not int, for sizes.
4388 (read1): Use EMACS_INT, not int, for sizes.
4389 Check for size overflow.
4390
4391 * image.c (cache_image): Check for size arithmetic overflow.
4392
4393 * lread.c: Integer overflow issues.
4394 (saved_doc_string_size, saved_doc_string_length)
4395 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4396 Now ptrdiff_t, not int.
4397 (read1): Don't assume doc string length fits in int. Check for
4398 out-of-range doc string lengths.
4399 (read_list): Don't assume file position fits in int.
4400 (read_escape): Check for hex character overflow.
4401
4402 2011-06-22 Leo Liu <sdl.web@gmail.com>
4403
4404 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4405 Move to minibuffer.el.
4406
4407 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4408
4409 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4410 The following patches are for when GLYPH_DEBUG && !XASSERT.
4411 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4412 * dispnew.c (flush_stdout):
4413 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4414 Mark as externally visible.
4415 * dispnew.c (check_window_matrix_pointers): Now static.
4416 * dispnew.c (window_to_frame_vpos):
4417 * xfns.c (unwind_create_frame):
4418 * xterm.c (x_check_font): Remove unused local.
4419 * scroll.c (CHECK_BOUNDS):
4420 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4421 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4422 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4423 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4424 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4425 Now static.
4426 (debug_method_add): Use va_list and vsprintf rather than relying
4427 on undefined behavior with wrong number of arguments.
4428 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4429 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4430 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4431 since we're not interested in debugging glyphs with old libraries.
4432 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4433 GCC 4.6.0's static checking.
4434
4435 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4436
4437 Integer overflow and signedness fixes (Bug#8873).
4438 A few related buffer overrun fixes, too.
4439
4440 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4441
4442 * dispextern.h (struct face.stipple):
4443 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4444 (x_bitmap_mask, x_allocate_bitmap_record)
4445 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4446 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4447 (x_create_bitmap_from_xpm_data):
4448 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4449 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4450 (.bitmaps_last):
4451 * xfaces.c (load_pixmap):
4452 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4453 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4454 (.bitmaps_last, struct x_output.icon_bitmap):
4455 Use ptrdiff_t, not int, for bitmap indexes.
4456 (x_allocate_bitmap_record): Check for size overflow.
4457 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4458
4459 Use ptrdiff_t, not int, for overlay counts.
4460 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4461 * editfns.c (overlays_around, get_pos_property):
4462 * textprop.c (get_char_property_and_overlay):
4463 * xdisp.c (next_overlay_change, note_mouse_highlight):
4464 * xfaces.c (face_at_buffer_position):
4465 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4466 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4467 (Fnext_overlay_change, Fprevious_overlay_change)
4468 (mouse_face_overlay_overlaps, Foverlays_in):
4469 Use ptrdiff_t, not int, for sizes.
4470 (overlays_at, overlays_in): Check for size-calculation overflow.
4471
4472 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4473
4474 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4475 (x_session_initialize): Do not assume string length fits in int.
4476
4477 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4478 This is unlikely, but can occur if DPI is outlandish.
4479
4480 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4481 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4482
4483 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4484 * xrdb.c (magic_file_p, search_magic_path):
4485 Omit last arg SUFFIX; it was always 0. All callers changed.
4486 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4487
4488 * xfont.c (xfont_match): Avoid need for strlen.
4489
4490 * xfns.c: Don't assume strlen fits in int.
4491 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4492
4493 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4494 not unsigned long, as we prefer signed integers. All callers changed.
4495 Detect integer overflow in repeat count.
4496 (message_dolog): Don't assume print length fits in 39 bytes.
4497 (display_mode_element): Don't assume strlen fits in int.
4498
4499 * termcap.c: Don't assume sizes fit in int and never overflow.
4500 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4501 (gobble_line): Check for size-calculation overflow.
4502
4503 * minibuf.c (Fread_buffer):
4504 * lread.c (intern, intern_c_string):
4505 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4506 Don't assume string length fits in int.
4507
4508 * keyboard.c (parse_tool_bar_item):
4509 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4510
4511 * font.c: Don't assume string length fits in int.
4512 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4513 Use ptrdiff_t, not int.
4514 (font_intern_prop): Don't assume string length fits in int.
4515 Don't assume integer property fits in fixnum.
4516 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4517
4518 * filelock.c: Fix some buffer overrun and integer overflow issues.
4519 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4520 Reformulate so as not to need the command string.
4521 Invoke gzip -cd rather than gunzip, as it's more portable.
4522 (lock_info_type, lock_file_1, lock_file):
4523 Don't assume pid_t and time_t fit in unsigned long.
4524 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4525 (current_lock_owner): Prefer signed type for sizes.
4526 Use memcpy, not strncpy, where memcpy is what is really wanted.
4527 Don't assume (via atoi) that time_t and pid_t fit in int.
4528 Check for time_t and/or pid_t out of range, e.g., via a network share.
4529 Don't alloca where an auto var works fine.
4530
4531 * fileio.c: Fix some integer overflow issues.
4532 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4533 Don't assume string length fits in int.
4534 (directory_file_name): Don't assume string length fits in long.
4535 (make_temp_name): Don't assume pid fits in int, or that its print
4536 length is less than 20.
4537
4538 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4539
4540 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4541
4542 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4543
4544 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4545 We prefer signed integers, even for size calculations.
4546
4547 * emacs.c: Don't assume string length fits in 'int'.
4548 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4549 (main): Don't invoke strlen when not needed.
4550
4551 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4552 (XD_DEBUG_MESSAGE): Don't waste a byte.
4553
4554 * callproc.c (getenv_internal_1, getenv_internal)
4555 (Fgetenv_internal):
4556 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4557
4558 * lread.c (invalid_syntax): Omit length argument.
4559 All uses changed. This doesn't fix a bug, but it simplifies the
4560 code away from its former Hollerith-constant appearance, and it's
4561 one less 'int' to worry about when looking at integer-overflow issues.
4562 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4563
4564 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4565 This didn't break anything, but it didn't help either.
4566 It's confusing to put a bogus integer in a place where the actual
4567 value does not matter.
4568 (LIST_END_P): Remove unused macro and its bogus comment.
4569 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4570
4571 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4572 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4573 implementation.
4574 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4575 We prefer signed types, and the value cannot exceed the EMACS_INT
4576 range anyway (because otherwise the length would not be representable).
4577 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4578 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4579 This avoids a GCC warning when WIDE_EMACS_INT.
4580
4581 * indent.c (sane_tab_width): New function.
4582 (current_column, scan_for_column, Findent_to, position_indentation)
4583 (compute_motion): Use it. This is just for clarity.
4584 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4585
4586 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4587
4588 * lisp.h (lint_assume): New macro.
4589 * composite.c (composition_gstring_put_cache):
4590 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4591
4592 * editfns.c, insdel.c:
4593 Omit unnecessary forward decls, to simplify future changes.
4594
4595 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4596
4597 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4598
4599 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4600 Use much-faster test for byte-length change.
4601 Don't assume string byte-length fits in 'int'.
4602 Check that character arg fits in 'int'.
4603 (mapcar1): Declare byte as byte, for clarity.
4604
4605 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4606
4607 * fns.c (concat): Catch string overflow earlier.
4608 Do not rely on integer wraparound.
4609
4610 * dispextern.h (struct it.overlay_strings_charpos)
4611 (struct it.selective): Now EMACS_INT, not int.
4612 * xdisp.c (forward_to_next_line_start)
4613 (back_to_previous_visible_line_start)
4614 (reseat_at_next_visible_line_start, next_element_from_buffer):
4615 Don't arbitrarily truncate the value of 'selective' to int.
4616
4617 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4618
4619 * composite.c: Don't truncate sizes to 'int'.
4620 (composition_gstring_p, composition_reseat_it)
4621 (composition_adjust_point): Use EMACS_INT, not int.
4622 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4623 not EMACS_UINT, for indexes.
4624
4625 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4626
4627 * buffer.c: Include <verify.h>.
4628 (struct sortvec.priority, struct sortstr.priority):
4629 Now EMACS_INT, not int.
4630 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4631 (struct sortstr.size, record_overlay_string)
4632 (struct sortstrlist.size, struct sortlist.used):
4633 Don't truncate size to int.
4634 (record_overlay_string): Check for size-calculation overflow.
4635 (init_buffer_once): Check at compile-time, not run-time.
4636
4637 2011-06-22 Jim Meyering <meyering@redhat.com>
4638
4639 Don't leak an XBM-image-sized buffer
4640 * image.c (xbm_load): Free the image buffer after using it.
4641
4642 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4643
4644 Port to Sun C.
4645 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4646 that Sun C diagnosed.
4647 * fns.c (secure_hash): Fix pointer signedness issue.
4648 * intervals.c (static_offset_intervals): New function.
4649 (offset_intervals): Use it.
4650
4651 2011-06-21 Leo Liu <sdl.web@gmail.com>
4652
4653 * deps.mk (fns.o):
4654 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4655 sha512.h.
4656
4657 * fns.c (secure_hash): Rename from crypto_hash_function and change
4658 the first arg to accept symbols.
4659 (Fsecure_hash): New primitive.
4660 (syms_of_fns): New symbols.
4661
4662 2011-06-20 Deniz Dogan <deniz@dogan.se>
4663
4664 * process.c (Fset_process_buffer): Clarify return value in
4665 docstring.
4666
4667 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4668
4669 * dispnew.c (add_window_display_history): Use BVAR.
4670
4671 * xdisp.c (debug_method_add): Use BVAR.
4672 (check_window_end, dump_glyph_matrix, dump_glyph)
4673 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4674
4675 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4676 Likewise.
4677
4678 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4679 check till after the cache is created in init_frame_faces.
4680
4681 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4682
4683 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4684
4685 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4686
4687 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4688 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4689 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4690
4691 Improve buffer-overflow checking (Bug#8873).
4692 * fileio.c (Finsert_file_contents):
4693 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4694 Remove the old (too-loose) buffer overflow checks.
4695 They weren't needed, since make_gap checks for buffer overflow.
4696 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4697 The old code merely checked for Emacs fixnum overflow, and relied
4698 on undefined (wraparound) behavior. The new code avoids undefined
4699 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4700
4701 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4702 Tune. Don't use wider integers than needed. Don't use alloca.
4703 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4704
4705 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4706
4707 * insdel.c, lisp.h (buffer_overflow): New function.
4708 (insert_from_buffer_1, replace_range, replace_range_2):
4709 * insdel.c (make_gap_larger):
4710 * editfns.c (Finsert_char):
4711 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4712
4713 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4714
4715 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4716
4717 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4718
4719 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4720 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4721
4722 * fileio.c: Don't assume EMACS_INT fits in off_t.
4723 (emacs_lseek): New static function.
4724 (Finsert_file_contents, Fwrite_region): Use it.
4725 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4726
4727 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4728
4729 * fns.c: Don't overflow int when computing a list length.
4730 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4731 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4732 truncation on 64-bit hosts. Check for QUIT every
4733 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4734 faster and is responsive enough.
4735 (Flength): Report an error instead of overflowing an integer.
4736 (Fsafe_length): Return a float if the value is not representable
4737 as a fixnum. This shouldn't happen except in contrived situations.
4738 (Fnthcdr, Fsort): Don't assume list length fits in int.
4739 (Fcopy_sequence): Don't assume vector length fits in int.
4740
4741 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4742 (header_size, word_size): New constants.
4743 (allocate_vectorlike): Don't check size overflow here.
4744 (allocate_vector): Check it here instead, since this is the only
4745 caller of allocate_vectorlike that could cause overflow.
4746 Check that the new vector's length is representable as a fixnum.
4747
4748 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4749 The previous code was bogus. For example, next_almost_prime (32)
4750 returned 39, which is undesirable as it is a multiple of 3; and
4751 next_almost_prime (24) returned 25, which is a multiple of 5 so
4752 why was the code bothering to check for multiples of 7?
4753
4754 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4755
4756 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4757
4758 Variadic C functions now count arguments with ptrdiff_t.
4759 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4760 Back then I didn't know that the Emacs coding style prefers signed int.
4761 Also, in the meantime I found a few more instances where arguments
4762 were being counted with int, which may truncate counts on 64-bit
4763 machines, or EMACS_INT, which may be unnecessarily wide.
4764 * lisp.h (struct Lisp_Subr.function.aMANY)
4765 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4766 Arg counts are now ptrdiff_t, not size_t.
4767 All variadic functions and their callers changed accordingly.
4768 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4769 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4770 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4771 * callint.c (Fcall_interactively): Check arg count for overflow,
4772 to avoid potential buffer overrun. Use signed char, not 'int',
4773 for 'varies' array, so that we needn't bother to check its size
4774 calculation for overflow.
4775 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4776 * eval.c (apply_lambda):
4777 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4778 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4779 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4780
4781 * callint.c (Fcall_interactively): Don't use index var as event count.
4782
4783 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4784 * mem-limits.h (SIZE): Remove; no longer used.
4785
4786 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4787
4788 Remove unnecessary casts.
4789 * xterm.c (x_term_init):
4790 * xfns.c (x_set_border_pixel):
4791 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4792 These aren't needed now that we assume ANSI C.
4793
4794 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4795 It's more likely to cause problems (due to unsigned overflow)
4796 than to cure them.
4797
4798 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4799
4800 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4801
4802 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4803
4804 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4805
4806 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4807
4808 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4809
4810 GLYPH_CODE_FACE returns EMACS_INT, not int.
4811 * dispextern.h (merge_faces):
4812 * xfaces.c (merge_faces):
4813 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4814 Don't assume EMACS_INT fits in int.
4815
4816 * character.h (CHAR_VALID_P): Remove unused parameter.
4817 * fontset.c, lisp.h, xdisp.c: All uses changed.
4818
4819 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4820
4821 * fns.c (concat): Minor tuning based on overflow analysis.
4822 This doesn't fix any bugs. Use int to hold character, instead
4823 of constantly refetching from Emacs object. Use XFASTINT, not
4824 XINT, for value known to be a character. Don't bother comparing
4825 a single byte to 0400, as it's always less.
4826
4827 * floatfns.c (Fexpt):
4828 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4829
4830 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4831 for characters.
4832
4833 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4834
4835 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4836 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4837 incorrectly succeed when S was a string, because 4294967386 was
4838 truncated before it was used.
4839
4840 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4841 Otherwise, an out-of-range integer could cause undefined behavior
4842 on a 64-bit host.
4843
4844 * composite.c: Use int, not EMACS_INT, for characters.
4845 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4846 EMACS_INT, for values that are known to be in character range.
4847 This doesn't fix any bugs but is the usual style inside Emacs and
4848 may generate better code on 32-bit machines.
4849
4850 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4851 This is for reasons similar to the recent CHAR_STRING fix.
4852 * charset.c (Fencode_char): Check that character arg is actually
4853 a character. Pass an int to ENCODE_CHAR.
4854 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4855 wider than 'int', as a compile-time check to prevent future regressions
4856 in this area.
4857
4858 * character.c (char_string): Remove unnecessary casts.
4859
4860 Make sure a 64-bit char is never passed to CHAR_STRING.
4861 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4862 by silently ignoring the top 32 bits, allowing some values
4863 that were far too large to be valid characters.
4864 * character.h: Include <verify.h>.
4865 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4866 arguments are no wider than unsigned, as a compile-time check
4867 to prevent future regressions in this area.
4868 * data.c (Faset):
4869 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4870 (Fsubst_char_in_region):
4871 * fns.c (concat):
4872 * xdisp.c (decode_mode_spec_coding):
4873 Adjust to CHAR_STRING's new requirement.
4874 * editfns.c (Finsert_char, Fsubst_char_in_region):
4875 * fns.c (concat): Check that character args are actually
4876 characters. Without this test, these functions did the wrong
4877 thing with wildly out-of-range values on 64-bit hosts.
4878
4879 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4880 These casts should not be needed on 32-bit hosts, either.
4881 * keyboard.c (read_char):
4882 * lread.c (Fload): Remove casts to unsigned.
4883
4884 * lisp.h (UNSIGNED_CMP): New macro.
4885 This fixes comparison bugs on 64-bit hosts.
4886 (ASCII_CHAR_P): Use it.
4887 * casefiddle.c (casify_object):
4888 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4889 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4890 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4891 * dispextern.h (FACE_FROM_ID):
4892 * keyboard.c (read_char): Use UNSIGNED_CMP.
4893
4894 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4895 not to EMACS_INT, to avoid GCC warning.
4896
4897 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4898
4899 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4900 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4901 isn't needed on 32-bit machines.
4902
4903 * buffer.c (Fgenerate_new_buffer_name):
4904 Use EMACS_INT for count, not int.
4905 (advance_to_char_boundary): Return EMACS_INT, not int.
4906
4907 * data.c (Qcompiled_function): Now static.
4908
4909 * window.c (window_body_lines): Now static.
4910
4911 * image.c (gif_load): Rename local to avoid shadowing.
4912
4913 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4914 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4915 * alloc.c (make_save_value): Integer argument is now of type
4916 ptrdiff_t, not int.
4917 (mark_object): Use ptrdiff_t, not int.
4918 * lisp.h (pD): New macro.
4919 * print.c (print_object): Use it.
4920
4921 * alloc.c: Use EMACS_INT, not int, to count objects.
4922 (total_conses, total_markers, total_symbols, total_vector_size)
4923 (total_free_conses, total_free_markers, total_free_symbols)
4924 (total_free_floats, total_floats, total_free_intervals)
4925 (total_intervals, total_strings, total_free_strings):
4926 Now EMACS_INT, not int. All uses changed.
4927 (Fgarbage_collect): Compute overall total using a double, so that
4928 integer overflow is less likely to be a problem. Check for overflow
4929 when converting back to an integer.
4930 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4931 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4932 These were 'int' variables that could overflow on 64-bit hosts;
4933 they were never used, so remove them instead of repairing them.
4934 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4935 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4936 Previously, this ceilinged at INT_MAX, but that doesn't work on
4937 64-bit machines.
4938 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4939
4940 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4941 (allocate_vectorlike): Check for ptrdiff_t overflow.
4942 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4943 when a (possibly-narrower) signed value would do just as well.
4944 We prefer using signed arithmetic, to avoid comparison confusion.
4945
4946 * alloc.c: Catch some string size overflows that we were missing.
4947 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4948 for convenience in STRING_BYTES_MAX.
4949 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4950 The definition here is exact; the one in lisp.h was approximate.
4951 (allocate_string_data): Check for string overflow. This catches
4952 some instances we weren't catching before. Also, it catches
4953 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4954 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4955 and ptrdiff_t and EMACS_INT are both 64 bits.
4956
4957 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4958 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4959 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4960
4961 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4962
4963 * alloc.c (Fmake_string): Check for out-of-range init.
4964
4965 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4966
4967 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4968
4969 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4970
4971 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4972 xg_get_default_scrollbar_width.
4973
4974 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4975 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4976 (style_changed_cb): Call update_theme_scrollbar_width and call
4977 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4978 all frames (Bug#8505).
4979 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4980 Call gtk_window_set_resizable if HAVE_GTK3.
4981 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4982 and height if HAVE_GTK3 (Bug#8505).
4983 (scroll_bar_width_for_theme): New variable.
4984 (update_theme_scrollbar_width): New function.
4985 (xg_get_default_scrollbar_width): Move code to
4986 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4987 (xg_initialize): Call update_theme_scrollbar_width.
4988
4989 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4990
4991 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4992
4993 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4994
4995 * frame.c (make_frame): Call other_buffer_safely instead of
4996 other_buffer.
4997
4998 * window.c (temp_output_buffer_show): Call display_buffer with
4999 second argument Vtemp_buffer_show_specifiers and reset latter
5000 immediately after the call.
5001 (Vtemp_buffer_show_specifiers): New variable.
5002 (auto_window_vscroll_p, next_screen_context_lines)
5003 (Vscroll_preserve_screen_position): Remove leading asterisks from
5004 doc-strings.
5005
5006 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5007
5008 Fix minor problems found by GCC 4.6.0 static checking.
5009 * buffer.c (Qclone_number): Remove for now, as it's unused.
5010 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5011 (record_buffer): Remove unused local.
5012 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5013 (set_frame_buffer_list): Remove; unused.
5014 * frame.h (other_visible_frames): Remove decl.
5015 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5016 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5017 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5018 if HAVE_GPM.
5019 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5020 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5021 Define only if HAVE_GPM.
5022 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5023 (update_hints_inhibit): Remove; never set. All uses removed.
5024 * widgetprv.h (emacsFrameClassRec): Remove decl.
5025 * window.c (delete_deletable_window): Now returns void, since it
5026 wasn't returning anything.
5027 (compare_window_configurations): Remove unused locals.
5028 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5029 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5030 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5031 the same widths as pointers. This follows up on the 2011-05-06 patch.
5032 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5033 * xterm.h: Likewise.
5034 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5035
5036 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5037
5038 * makefile.w32-in: Update dependencies.
5039 (LISP_H): Add lib/intprops.h.
5040
5041 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5042
5043 * image.c (gif_load): Add animation frame delay to the metadata.
5044 (syms_of_image): Use DEFSYM. New symbol `delay'.
5045
5046 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5047
5048 * window.c (delete_deletable_window): Re-add.
5049 (Fset_window_configuration): Rewrite to handle dead buffers and
5050 consequently deletable windows.
5051 (window_tree, Fwindow_tree): Remove. Supply functionality in
5052 window.el.
5053 (compare_window_configurations): Simplify code.
5054
5055 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5056
5057 * image.c (imagemagick_load_image): Fix type mismatch.
5058 (Fimagemagick_types): Likewise.
5059
5060 * window.h (replace_buffer_in_windows): Declare.
5061
5062 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5063
5064 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5065 Qclone_number. Remove external declaration of Qdelete_window.
5066 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5067 code.
5068 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5069 Run Qbuffer_list_update_hook if allowed.
5070 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5071 buffer list implementation.
5072 (other_buffer_safely): New function.
5073 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5074 calls to replace_buffer_in_windows and
5075 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5076 if allowed.
5077 (record_buffer): Inhibit quitting and rewrite using quittable
5078 functions. Run Qbuffer_list_update_hook if allowed.
5079 (Frecord_buffer, Funrecord_buffer): New functions.
5080 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5081 Move switch-to-buffer to window.el.
5082 (bury-buffer): Move to window.el.
5083 (Vbuffer_list_update_hook): New variable.
5084
5085 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5086 section.
5087
5088 * window.h (resize_frame_windows): Move up in code.
5089 (Fwindow_frame): Remove EXFUN.
5090 (replace_buffer_in_all_windows): Remove prototype.
5091 (replace_buffer_in_windows_safely): Add prototype.
5092
5093 * window.c: Declare Qdelete_window static again. Move down
5094 declaration of select_count.
5095 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5096 (Fother_window): Move to window.el.
5097 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5098 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5099 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5100 window.el.
5101 (replace_buffer_in_windows): Implement by calling
5102 Qreplace_buffer_in_windows.
5103 (replace_buffer_in_all_windows): Remove with some functionality
5104 moved into replace_buffer_in_windows_safely.
5105 (replace_buffer_in_windows_safely): New function.
5106 (select_window_norecord, select_frame_norecord): Move in front
5107 of run_window_configuration_change_hook. Remove now obsolete
5108 declarations.
5109 (Fset_window_buffer): Rewrite doc-string.
5110 Call Qrecord_window_buffer.
5111 (keys_of_window): Move binding for other-window to window.el.
5112
5113 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5114
5115 * dispextern.h (struct image): Replace data member, whose int_val
5116 and ptr_val fields were not used by anything, with a single
5117 lisp_val object.
5118
5119 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5120 (gif_clear_image, gif_load, imagemagick_load_image)
5121 (gs_clear_image, gs_load): Callers changed.
5122
5123 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5124
5125 * buffer.h: Include <time.h>, for time_t.
5126 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5127
5128 Fix minor problems found by static checking.
5129
5130 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5131
5132 Make identifiers static if they are not used in other modules.
5133 * data.c (Qcompiled_function, Qframe, Qvector):
5134 * image.c (QimageMagick, Qsvg):
5135 * minibuf.c (Qmetadata):
5136 * window.c (resize_window_check, resize_root_window): Now static.
5137 * window.h (resize_window_check, resize_root_window): Remove decls.
5138
5139 * window.c (window_deletion_count, delete_deletable_window):
5140 Remove; unused.
5141 (window_body_lines): Now static.
5142 (Fdelete_other_windows_internal): Mark vars as initialized.
5143 Make sure 'resize_failed' is initialized.
5144 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5145 (resize_window_apply): Remove unused local.
5146 * window.h (delete_deletable_window): Remove decl.
5147
5148 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5149 (imagemagick_load_image): Fix pointer signedness problem by changing
5150 last arg from unsigned char * to char *. All uses changed.
5151 Also, fix a local for similar reasons.
5152 Remove unused locals. Remove locals to avoid shadowing.
5153 (fn_rsvg_handle_free): Remove; unused.
5154 (svg_load, svg_load_image): Fix pointer signedness problem.
5155 (imagemagick_load_image): Don't use garbage pointer image_wand.
5156
5157 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5158
5159 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5160
5161 * image.c (gif_load): Fix omitted cast error introduced by
5162 2011-06-06 change.
5163
5164 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5165
5166 * window.h (resize_proportionally, orig_total_lines)
5167 (orig_top_line): Remove from window structure.
5168 (set_window_height, set_window_width, change_window_heights)
5169 (Fdelete_window): Remove prototypes.
5170 (resize_frame_windows): Remove duplicate declaration.
5171
5172 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5173
5174 * window.h (resize_frame_windows, resize_window_check)
5175 (delete_deletable_window, resize_root_window)
5176 (resize_frame_windows): Declare prototypes.
5177
5178 * window.c (resize_window_apply): Make definition be "static" to
5179 match the prototype.
5180
5181 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5182
5183 * window.c: Remove declarations of Qwindow_size_fixed,
5184 window_min_size_1, window_min_size_2, window_min_size,
5185 size_window, window_fixed_size_p, enlarge_window, delete_window.
5186 Remove static from declaration of Qdelete_window, it's
5187 temporarily needed by Fbury_buffer.
5188 (replace_window): Don't assign orig_top_line and
5189 orig_total_lines.
5190 (Fdelete_window, delete_window): Remove. Window deletion is
5191 handled by window.el.
5192 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5193 Replace Fdelete_window calls with calls to Qdelete_window.
5194 (Fdelete_other_windows): Remove. Deleting other windows is
5195 handled by window.el.
5196 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5197 handled in window.el.
5198 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5199 Window minimum sizes are handled in window.el.
5200 (shrink_windows, size_window, set_window_height)
5201 (set_window_width, change_window_heights, window_height)
5202 (window_width, CURBEG, CURSIZE, enlarge_window)
5203 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5204 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5205 handled in window.el.
5206 (make_dummy_parent): Rename to make_parent_window and give it a
5207 second argument horflag.
5208 (make_window): Don't set resize_proportionally any more.
5209 (Fsplit_window): Remove. Windows are split in window.el.
5210 (save_restore_action, save_restore_orig_size)
5211 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5212 Resize mini windows in window.el.
5213 (grow_mini_window, shrink_mini_window): Implement by calling
5214 Qresize_root_window_vertically, resize_window_check and
5215 resize_window_apply.
5216 (saved_window, Fset_window_configuration, save_window_save):
5217 Do not handle orig_top_line, orig_total_lines, and
5218 resize_proportionally.
5219 (window_min_height, window_min_width): Move to window.el.
5220 (keys_of_window): Move bindings for delete-other-windows,
5221 split-window, delete-window and enlarge-window to window.el.
5222
5223 * buffer.c: Temporarily extern Qdelete_window.
5224 (Fbury_buffer): Temporarily call Qdelete_window instead of
5225 Fdelete_window (Fbury_buffer will move to window.el soon).
5226
5227 * frame.c (set_menu_bar_lines_1): Remove code handling
5228 orig_top_line and orig_total_lines.
5229
5230 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5231 set_window_height but set heights directly.
5232 (change_frame_size_1): Use resize_frame_windows.
5233
5234 * xdisp.c (init_xdisp): Don't use set_window_height but set
5235 heights directly.
5236
5237 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5238 Use resize_frame_windows instead of change_window_heights and run
5239 run_window_configuration_change_hook.
5240
5241 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5242 instead of change_window_heights and run
5243 run_window_configuration_change_hook.
5244
5245 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5246
5247 * window.c (replace_window): Rename second argument REPLACEMENT to
5248 NEW. New third argument SETFLAG. Rewrite.
5249 (delete_window, make_dummy_parent): Call replace_window with
5250 third argument 1.
5251 (window_list_1): Move down in code.
5252 (run_window_configuration_change_hook): Move set_buffer part
5253 before select_frame_norecord part in order to unwind correctly.
5254 Rename count1 to count.
5255 (recombine_windows, delete_deletable_window, resize_root_window)
5256 (Fdelete_other_windows_internal)
5257 (Frun_window_configuration_change_hook, make_parent_window)
5258 (resize_window_check, resize_window_apply, Fresize_window_apply)
5259 (resize_frame_windows, Fsplit_window_internal)
5260 (Fdelete_window_internal, Fresize_mini_window_internal):
5261 New functions.
5262 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5263
5264 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5265
5266 * window.h (window): Add some new members to window structure -
5267 normal_lines, normal_cols, new_total, new_normal, clone_number,
5268 splits, nest, prev_buffers, next_buffers.
5269 (WINDOW_TOTAL_SIZE): Move here from window.c.
5270 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5271
5272 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5273 Remove.
5274 (make_dummy_parent): Set new members of windows structure.
5275 (make_window): Move down in code. Handle new members of window
5276 structure.
5277 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5278 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5279 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5280 (Fset_window_prev_buffers, Fwindow_next_buffers)
5281 (Fset_window_next_buffers, Fset_window_clone_number):
5282 New functions.
5283 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5284 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5285 Doc-string fixes.
5286 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5287 Argument WINDOW can be now internal window too.
5288 (Fwindow_use_time): Move up in code.
5289 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5290 Rewrite doc-string.
5291 (Fset_window_configuration, saved_window)
5292 (Fcurrent_window_configuration, save_window_save): Handle new
5293 members of window structure.
5294 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5295 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5296 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5297 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5298 Qget_mru_window, Qresize_root_window,
5299 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5300 Qauto_buffer_name; staticpro them.
5301
5302 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5303
5304 * window.c (Fwindow_total_size, Fwindow_left_column)
5305 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5306 (Fwindow_list_1): New functions.
5307 (window_box_text_cols): Replace with window_body_cols.
5308 (Fwindow_width, Fscroll_left, Fscroll_right):
5309 Use window_body_cols instead of window_box_text_cols.
5310 (delete_window, Fset_window_configuration):
5311 Call delete_all_subwindows with window as argument.
5312 (delete_all_subwindows): Take a window as argument and not a
5313 structure. Rewrite.
5314 (window_loop): Remove handling of GET_LRU_WINDOW and
5315 GET_LARGEST_WINDOW.
5316 (Fget_lru_window, Fget_largest_window): Move to window.el.
5317
5318 * window.h: Extern window_body_cols instead of
5319 window_box_text_cols. delete_all_subwindows now takes a
5320 Lisp_Object as argument.
5321
5322 * indent.c (compute_motion, Fcompute_motion):
5323 Use window_body_cols instead of window_box_text_cols.
5324
5325 * frame.c (delete_frame): Call delete_all_subwindows with root
5326 window as argument.
5327
5328 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5329
5330 * fns.c (Fputhash): Document return value.
5331
5332 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5333
5334 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5335
5336 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5337
5338 Cons<->int and similar integer overflow fixes (Bug#8794).
5339
5340 Check for overflow when converting integer to cons and back.
5341 * charset.c (Fdefine_charset_internal, Fdecode_char):
5342 Use cons_to_unsigned to catch overflow.
5343 (Fencode_char): Use INTEGER_TO_CONS.
5344 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5345 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5346 * data.c (long_to_cons, cons_to_long): Remove.
5347 (cons_to_unsigned, cons_to_signed): New functions.
5348 These signal an error for invalid or out-of-range values.
5349 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5350 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5351 * font.c (Ffont_variation_glyphs):
5352 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5353 * lisp.h: Include <intprops.h>.
5354 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5355 (cons_to_signed, cons_to_unsigned): New decls.
5356 (long_to_cons, cons_to_long): Remove decls.
5357 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5358 (Fprimitive_undo): Use CONS_TO_INTEGER.
5359 * xfns.c (Fx_window_property): Likewise.
5360 * xselect.c: Include <limits.h>.
5361 (x_own_selection, selection_data_to_lisp_data):
5362 Use INTEGER_TO_CONS.
5363 (x_handle_selection_request, x_handle_selection_clear)
5364 (x_get_foreign_selection, Fx_disown_selection_internal)
5365 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5366 (lisp_data_to_selection_data): Use cons_to_unsigned.
5367 (x_fill_property_data): Use cons_to_signed.
5368 Report values out of range.
5369
5370 Check for buffer and string overflow more precisely.
5371 * buffer.h (BUF_BYTES_MAX): New macro.
5372 * lisp.h (STRING_BYTES_MAX): New macro.
5373 * alloc.c (Fmake_string):
5374 * character.c (string_escape_byte8):
5375 * coding.c (coding_alloc_by_realloc):
5376 * doprnt.c (doprnt):
5377 * editfns.c (Fformat):
5378 * eval.c (verror):
5379 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5380 since they may not be the same number.
5381 * editfns.c (Finsert_char):
5382 * fileio.c (Finsert_file_contents):
5383 Likewise for BUF_BYTES_MAX.
5384
5385 * image.c: Use ptrdiff_t, not int, for sizes.
5386 (slurp_file): Switch from int to ptrdiff_t.
5387 All uses changed.
5388 (slurp_file): Check that file size fits in both size_t (for
5389 malloc) and ptrdiff_t (for sanity and safety).
5390
5391 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5392 if b->modtime has its maximal value.
5393
5394 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5395
5396 Don't assume time_t can fit into int.
5397 * buffer.h (struct buffer.modtime): Now time_t, not int.
5398 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5399 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5400
5401 Minor fixes for signed vs unsigned integers.
5402 * character.h (MAYBE_UNIFY_CHAR):
5403 * charset.c (maybe_unify_char):
5404 * keyboard.c (read_char, reorder_modifiers):
5405 XINT -> XFASTINT, since the integer must be nonnegative.
5406 * ftfont.c (ftfont_spec_pattern):
5407 * keymap.c (access_keymap, silly_event_symbol_error):
5408 XUINT -> XFASTINT, since the integer must be nonnegative.
5409 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5410 since it makes no difference and we prefer signed.
5411 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5412 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5413 nonnegative.
5414
5415 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5416
5417 * window.h (Fwindow_frame): Declare.
5418
5419 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5420
5421 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5422 (SPARE_MEMORY): Always define.
5423 (LARGE_REQUEST): Remove.
5424 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5425
5426 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5427
5428 * lisp.h: Move EXFUNS for Fframe_root_window,
5429 Fframe_first_window and Fset_frame_selected_window to window.h.
5430
5431 * window.h: Move EXFUNS for Fframe_root_window,
5432 Fframe_first_window and Fset_frame_selected_window here from
5433 lisp.h.
5434
5435 * frame.c (Fwindow_frame, Fframe_first_window)
5436 (Fframe_root_window, Fframe_selected_window)
5437 (Fset_frame_selected_window): Move to window.c.
5438 (Factive_minibuffer_window): Move to minibuf.c.
5439 (Fother_visible_frames_p): New function.
5440
5441 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5442
5443 * window.c (decode_window, decode_any_window): Move up in code.
5444 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5445 (inhibit_frame_unsplittable): Remove unused variable.
5446 (Fwindow_buffer): Move up and rewrite doc-string.
5447 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5448 (Fwindow_prev): New functions.
5449 (Fwindow_frame): Move here from frame.c. Accept any window as
5450 argument.
5451 (Fframe_root_window, Fframe_first_window)
5452 (Fframe_selected_window): Move here from frame.c. Accept frame
5453 or arbitrary window as argument. Update doc-strings.
5454 (Fminibuffer_window): Move up in code.
5455 (Fwindow_minibuffer_p): Move up in code and simplify.
5456 (Fset_frame_selected_window): Move here from frame.c.
5457 Marginal rewrite.
5458 (Fselected_window, select_window, Fselect_window): Move up in
5459 code. Minor doc-string fixes.
5460
5461 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5462
5463 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5464 Do not assume that spare memory exists; that assumption is valid
5465 only if SYSTEM_MALLOC.
5466 (LARGE_REQUEST): New macro, so that the issue of large requests
5467 is separated from the issue of spare memory.
5468
5469 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5470
5471 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5472 format. (Bug#8806)
5473
5474 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5475
5476 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5477 before statements.
5478
5479 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5480
5481 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5482
5483 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5484
5485 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5486 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5487
5488 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5489
5490 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5491
5492 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5493
5494 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5495 (x_clipboard_manager_save): Add return value.
5496 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5497 New error handlers.
5498 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5499 Obey Vx_select_enable_clipboard_manager. Catch errors in
5500 x_clipboard_manager_save (Bug#8779).
5501 (Vx_select_enable_clipboard_manager): New variable.
5502 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5503
5504 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5505
5506 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5507
5508 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5509
5510 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5511 in the current matrix if keep_current_p is non-zero.
5512
5513 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5514
5515 * bidi.c (bidi_level_of_next_char): Fix last change.
5516
5517 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5518
5519 Support bidi reordering of text covered by display properties.
5520
5521 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5522 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5523 (bidi_cache_search, bidi_cache_iterator_state)
5524 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5525 (bidi_level_of_next_char, bidi_move_to_visually_next):
5526 Support character positions inside a run of characters covered by a
5527 display string.
5528 (bidi_paragraph_init, bidi_resolve_explicit_1)
5529 (bidi_level_of_next_char): Call bidi_fetch_char and
5530 bidi_fetch_char_advance instead of FETCH_CHAR and
5531 FETCH_CHAR_ADVANCE.
5532 (bidi_init_it): Initialize new members.
5533 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5534 definitions.
5535 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5536 instead of using explicit *_CHAR codes.
5537 (bidi_resolve_explicit, bidi_resolve_weak):
5538 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5539 bidirectional text is supported only in multibyte buffers.
5540 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5541 it to initialize the frame_window_p member of struct bidi_it.
5542 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5543 (bidi_resolve_explicit, bidi_resolve_weak)
5544 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5545 bidi_it->nchars is non-positive.
5546 (bidi_level_of_next_char): Don't try to lookup the cache for the
5547 next/previous character if nothing is cached there yet, or if we
5548 were just reseat()'ed to a new position.
5549
5550 * xdisp.c (set_cursor_from_row): Set start and stop points
5551 according to the row's direction when priming the loop that looks
5552 for the glyph on which to display cursor.
5553 (single_display_spec_intangible_p): Function deleted.
5554 (display_prop_intangible_p): Reimplement to call
5555 handle_display_spec instead of single_display_spec_intangible_p.
5556 Accept 3 additional arguments needed by handle_display_spec.
5557 This fixes incorrect cursor motion across display property with complex
5558 values: lists, `(when COND...)' forms, etc.
5559 (single_display_spec_string_p): Support property values that are
5560 lists with the argument STRING its top-level element.
5561 (display_prop_string_p): Fix the condition for processing a
5562 property that is a list to be consistent with handle_display_spec.
5563 (handle_display_spec): New function, refactored from the
5564 last portion of handle_display_prop.
5565 (compute_display_string_pos): Accept additional argument
5566 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5567 value of a `display' property is a "replacing spec".
5568 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5569 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5570 the display property, but just return a value indicating whether
5571 the display property will replace the characters it covers.
5572 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5573 frame_window_p members of struct bidi_it.
5574 (compute_display_string_pos, compute_display_string_end):
5575 New functions.
5576 (push_it): Accept second argument POSITION, where pop_it should
5577 jump to continue iteration.
5578 (reseat_1): Initialize bidi_it.disp_pos.
5579
5580 * keyboard.c (adjust_point_for_property): Adjust the call to
5581 display_prop_intangible_p to its new signature.
5582
5583 * dispextern.h (struct bidi_it): New member frame_window_p.
5584 (bidi_init_it): Update prototypes.
5585 (display_prop_intangible_p): Update prototype.
5586 (compute_display_string_pos, compute_display_string_end):
5587 Declare prototypes.
5588 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5589 EMACS_INT.
5590
5591 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5592
5593 Malloc failure behavior now depends on size of allocation.
5594 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5595 * lisp.h: Change signatures accordingly.
5596 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5597 All callers changed. (Bug#8762)
5598
5599 * gnutls.c: Use Emacs's memory allocators.
5600 Without this change, the gnutls library would invoke malloc etc.
5601 directly, which causes problems on non-SYNC_INPUT hosts, and which
5602 runs afoul of improving memory_full behavior. (Bug#8761)
5603 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5604 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5605 xfree instead of the default malloc, realloc, free.
5606 (Fgnutls_boot): No need to check for memory allocation failure,
5607 since xmalloc does that for us.
5608
5609 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5610 * category.c (hash_get_category_set):
5611 * ccl.c (ccl_driver):
5612 * charset.c (Fdefine_charset_internal):
5613 * charset.h (struct charset.hash_index):
5614 * composite.c (get_composition_id, gstring_lookup_cache)
5615 (composition_gstring_put_cache):
5616 * composite.h (struct composition.hash_index):
5617 * dispextern.h (struct image.hash):
5618 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5619 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5620 (hashfn_equal, hashfn_user_defined, make_hash_table)
5621 (maybe_resize_hash_table, hash_lookup, hash_put)
5622 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5623 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5624 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5625 * image.c (make_image, search_image_cache, lookup_image)
5626 (xpm_put_color_table_h):
5627 * lisp.h (struct Lisp_Hash_Table):
5628 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5629 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5630 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5631 * alloc.c (allocate_vectorlike):
5632 Check for overflow in vector size calculations.
5633 * ccl.c (ccl_driver):
5634 Check for overflow when converting EMACS_INT to int.
5635 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5636 need to be updated by these changes.
5637 * fns.c (make_hash_table, maybe_resize_hash_table):
5638 Check for integer overflow with large hash tables.
5639 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5640 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5641 (SXHASH_REDUCE): New macro.
5642 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5643 Use it instead of discarding useful hash info with large hash values.
5644 (sxhash_float): New function.
5645 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5646 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5647 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5648 Rewrite to use FIXNUM_BITS, as this simplifies things.
5649 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5650 Adjust signatures to match updated version of code.
5651 (consing_since_gc): Now EMACS_INT, since a single hash table can
5652 use more than INT_MAX bytes.
5653
5654 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5655
5656 Make it possible to build with GCC-4.6+ -O2 -flto.
5657
5658 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5659
5660 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5661
5662 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5663 Call minibuffer-inactive-mode.
5664
5665 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5666
5667 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5668 Update dependencies.
5669
5670 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5671
5672 * data.c (init_data): Remove code for UTS, this system is not
5673 supported anymore.
5674
5675 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5676
5677 Don't force ./temacs to start in terminal mode.
5678
5679 * frame.c (make_initial_frame): Initialize faces in all cases, not
5680 only when CANNOT_DUMP is defined.
5681 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5682
5683 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5684
5685 * dispnew.c (add_window_display_history): Use const for the string
5686 pointer. Remove declaration, not needed.
5687
5688 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5689
5690 Use 'inline', not 'INLINE'.
5691 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5692 * alloc.c, fontset.c (INLINE): Remove.
5693 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5694 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5695 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5696 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5697 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5698
5699 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5700
5701 Make it possible to run ./temacs.
5702
5703 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5704 syms_of_callproc does the same thing. Remove test for
5705 "initialized", do it in the caller.
5706 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5707
5708 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5709
5710 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5711 (read_minibuf): Use get_minibuffer.
5712 (syms_of_minibuf): Use DEFSYM.
5713 (Qmetadata): New var.
5714 * data.c (Qbuffer): Don't make it static.
5715 (syms_of_data): Use DEFSYM.
5716
5717 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5718
5719 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5720 (CCL_CODE_MIN): New macro.
5721
5722 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5723
5724 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5725
5726 * eval.c (Qdebug): Now static.
5727 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5728 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5729 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5730
5731 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5732
5733 * image.c: Various fixes to ImageMagick code comments.
5734 (Fimagemagick_types): Doc fix.
5735
5736 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5737
5738 Minor fixes prompted by GCC 4.6.0 warnings.
5739
5740 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5741
5742 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5743 (x_clipboard_manager_save_all): Move extern decl to ...
5744 * xterm.h: ... here, so that it can be checked for consistency.
5745
5746 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5747
5748 * xselect.c (x_clipboard_manager_save_frame)
5749 (x_clipboard_manager_save_all): New functions.
5750 (Fx_clipboard_manager_save): Lisp function deleted.
5751
5752 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5753 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5754
5755 * xterm.h: Update prototype.
5756
5757 2011-05-28 William Xu <william.xwl@gmail.com>
5758
5759 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5760 exiting (Bug#8239).
5761
5762 2011-05-28 Jim Meyering <meyering@redhat.com>
5763
5764 Avoid a sign-extension bug in crypto_hash_function.
5765 * fns.c (to_uchar): Define.
5766 (crypto_hash_function): Use it to convert some newly-signed
5767 variables to unsigned, to avoid sign-extension bugs. For example,
5768 without this change, (md5 "truc") would evaluate to
5769 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5770 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5771 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5772
5773 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5774
5775 Integer overflow fixes.
5776
5777 * dbusbind.c: Serial number integer overflow fixes.
5778 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5779 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5780 to hold a serial number that is too large for a fixnum.
5781 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5782 Check for serial numbers out of range. Decode any serial number
5783 that was so large that it became a float. (Bug#8722)
5784
5785 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5786 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5787 Use XFASTINT rather than XUINT when numbers are nonnegative.
5788 (xd_append_arg, Fdbus_method_return_internal):
5789 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5790 arguments, check that Lisp number is nonnegative, rather than
5791 silently wrapping negative numbers around. (Bug#8722)
5792 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5793 (Bug#8722)
5794
5795 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5796
5797 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5798
5799 ccl: Add integer overflow checks.
5800 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5801 (IN_INT_RANGE): New macros.
5802 (ccl_driver): Use them to check for integer overflow when
5803 decoding a CCL program. Many of the new checks are whether XINT (x)
5804 fits in int; it doesn't always, on 64-bit hosts. The new version
5805 doesn't catch all possible integer overflows, but it's an
5806 improvement. (Bug#8719)
5807
5808 * alloc.c (make_event_array): Use XINT, not XUINT.
5809 There's no need for unsigned here.
5810
5811 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5812 This follows up to the 2011-05-06 change that substituted uintptr_t
5813 for EMACS_INT. This case wasn't caught back then.
5814
5815 Rework Fformat to avoid integer overflow issues.
5816 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5817 now (part of C89). Include <verify.h>.
5818 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5819 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5820 (Fformat): Avoid the prepass trying to compute sizes; it was only
5821 approximate and thus did not catch overflow reliably. Instead, walk
5822 through the format just once, formatting and computing sizes as we go,
5823 checking for integer overflow at every step, and allocating a larger
5824 buffer as needed. Keep track separately whether the format is
5825 multibyte. Keep only the most-recently calculated precision, rather
5826 than them all. Record whether each argument has been converted to
5827 string. Use EMACS_INT, not int, for byte and char and arg counts.
5828 Support field widths and precisions larger than INT_MAX. Avoid
5829 sprintf's undefined behavior with conversion specifications such as %#d
5830 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5831 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5832 formatting out-of-range floating point numbers with int
5833 formats. (Bug#8668)
5834
5835 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5836
5837 * data.c: Avoid integer truncation in expressions involving floats.
5838 * data.c: Include <intprops.h>.
5839 (arith_driver): When there's an integer overflow in an expression
5840 involving floating point, convert the integers to floating point
5841 so that the resulting value does not suffer from catastrophic
5842 integer truncation. For example, on a 64-bit host (* 4
5843 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5844 Do not rely on undefined behavior after integer overflow.
5845
5846 merge count_size_as_multibyte, parse_str_to_multibyte
5847 * character.c, character.h (count_size_as_multibyte):
5848 Rename from parse_str_to_multibyte; all uses changed.
5849 Check for integer overflow.
5850 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5851 since it's now a duplicate of the other. This is more of
5852 a character than a buffer op, so better that it's in character.c.
5853 * fns.c, print.c: Adjust to above changes.
5854
5855 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5856
5857 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5858
5859 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5860
5861 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5862 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5863 (x_clipboard_manager_save): Now static.
5864 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5865
5866 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5867 (crypto_hash_function): Now static.
5868 Fix pointer signedness problems. Avoid unnecessary initializations.
5869
5870 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5871
5872 * termhooks.h (Vselection_alist): Make it terminal-local.
5873
5874 * terminal.c (create_terminal): Initialize it.
5875
5876 * xselect.c: Support for clipboard managers.
5877 (Vselection_alist): Move to termhooks.h as terminal-local var.
5878 (LOCAL_SELECTION): New macro.
5879 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5880 (symbol_to_x_atom): Remove gratuitous arg.
5881 (x_handle_selection_request, lisp_data_to_selection_data)
5882 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5883 (x_own_selection, x_get_local_selection, x_convert_selection):
5884 New arg, specifying work frame. Use terminal-local Vselection_alist.
5885 (some_frame_on_display): Delete unused function.
5886 (Fx_own_selection_internal, Fx_get_selection_internal)
5887 (Fx_disown_selection_internal, Fx_selection_owner_p)
5888 (Fx_selection_exists_p): New optional frame arg.
5889 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5890 (x_handle_selection_clear): Don't treat other terminals with the
5891 same keyboard specially. Use the terminal-local Vselection_alist.
5892 (x_clear_frame_selections): Use Frun_hook_with_args.
5893
5894 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5895
5896 * xterm.h: Add support for those atoms.
5897
5898 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5899
5900 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5901 (converted_selections, conversion_fail_tag): New global variables.
5902 (x_selection_request_lisp_error): Free the above.
5903 (x_get_local_selection): Remove unnecessary code.
5904 (x_reply_selection_request): Args changed; handle arbitrary array
5905 of converted selections stored in converted_selections.
5906 Separate the XChangeProperty and SelectionNotify steps.
5907 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5908 (x_convert_selection): New function.
5909 (x_handle_selection_event): Simplify.
5910 (x_get_foreign_selection): Don't ignore incoming requests while
5911 waiting for an answer; this will fail when we implement
5912 SAVE_TARGETS, and seems unnecessary anyway.
5913 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5914 (Vx_sent_selection_functions): Doc fix.
5915
5916 2011-05-26 Leo Liu <sdl.web@gmail.com>
5917
5918 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5919
5920 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5921
5922 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5923
5924 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5925 for fringe update if it has periodic bitmap.
5926 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5927 and fringe_bitmap_periodic_p.
5928
5929 * fringe.c (get_fringe_bitmap_data): New function.
5930 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5931 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5932 row. Mark glyph row for fringe update if periodicity changed.
5933
5934 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5935 for fringe update unless it has periodic bitmap.
5936
5937 2011-05-25 Kenichi Handa <handa@m17n.org>
5938
5939 * xdisp.c (get_next_display_element): Set correct it->face_id for
5940 a static composition.
5941
5942 2011-05-24 Leo Liu <sdl.web@gmail.com>
5943
5944 * deps.mk (fns.o):
5945 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5946
5947 * fns.c (crypto_hash_function, Fsha1): New function.
5948 (Fmd5): Use crypto_hash_function.
5949 (syms_of_fns): Add Ssha1.
5950
5951 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5952
5953 * gnutls.c: Remove unused macros.
5954 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5955 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5956 Remove macros that are defined and never used.
5957 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5958
5959 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5960
5961 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5962 (Fx_get_selection_internal): Minor cleanup.
5963 (Fx_own_selection_internal): Rename arguments for consistency with
5964 select.el.
5965
5966 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5967
5968 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5969
5970 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5971
5972 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5973
5974 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5975
5976 * dispnew.c (scrolling_window): Don't exclude the case that the
5977 last enabled row in the desired matrix touches the bottom boundary.
5978
5979 2011-05-21 Glenn Morris <rgm@gnu.org>
5980
5981 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5982 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5983 and add some more files.
5984
5985 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5986
5987 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5988 report_file_error introduced by the change from 2011-05-07.
5989
5990 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5991
5992 * systime.h (Time): Define only if emacs is defined.
5993 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5994 where the include path doesn't have X11/X.h by default. See
5995 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5996
5997 2011-05-20 Kenichi Handa <handa@m17n.org>
5998
5999 * composite.c (find_automatic_composition): Fix previous change.
6000
6001 2011-05-20 Glenn Morris <rgm@gnu.org>
6002
6003 * lisp.mk: New file, split from Makefile.in.
6004 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6005 (shortlisp): Remove.
6006 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6007
6008 2011-05-19 Glenn Morris <rgm@gnu.org>
6009
6010 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6011 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6012 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6013 (lisp): Set the order to that of loadup.el.
6014 (shortlisp): Make it a copy of $lisp.
6015 (SOME_MACHINE_LISP): Remove.
6016 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6017 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6018
6019 2011-05-18 Kenichi Handa <handa@m17n.org>
6020
6021 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6022 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6023 (find_automatic_composition): Mostly rewrite for efficiency.
6024
6025 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6026
6027 * makefile.w32-in: Update dependencies.
6028
6029 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6030
6031 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6032 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6033
6034 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6035
6036 Fix some integer overflow issues, such as string length overflow.
6037
6038 * insdel.c (count_size_as_multibyte): Check for string overflow.
6039
6040 * character.c (lisp_string_width): Check for string overflow.
6041 Use EMACS_INT, not int, for string indexes and lengths; in
6042 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6043 the resulting string length overflows an EMACS_INT; instead,
6044 report a string overflow if no precision given. When checking for
6045 precision exhaustion, use a check that cannot possibly have
6046 integer overflow. (Bug#8675)
6047 * character.h (lisp_string_width): Adjust to new signature.
6048
6049 * alloc.c (string_overflow): New function.
6050 (Fmake_string): Use it. This doesn't change behavior, but saves
6051 a few bytes and will simplify future changes.
6052 * character.c (string_escape_byte8): Likewise.
6053 * lisp.h (string_overflow): New decl.
6054
6055 Fixups, following up to the user-interface timestamp change.
6056 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6057 for UI timestamps, instead of unsigned long.
6058 * msdos.c (mouse_get_pos): Likewise.
6059 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6060 * w32gui.h (Time): Define by including "systime.h" rather than by
6061 declaring it ourselves. (Bug#8664)
6062
6063 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6064 * image.c (clear_image_cache): Likewise.
6065
6066 * term.c (term_mouse_position): Don't assume time_t wraparound.
6067
6068 Be more systematic about user-interface timestamps.
6069 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6070 and sometimes 'EMACS_UINT', to represent these timestamps.
6071 This change causes it to use 'Time' uniformly, as that's what X uses.
6072 This makes the code easier to follow, and makes it easier to catch
6073 integer overflow bugs such as Bug#8664.
6074 * frame.c (Fmouse_position, Fmouse_pixel_position):
6075 Use Time, not unsigned long, for user-interface timestamps.
6076 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6077 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6078 * keyboard.h (last_event_timestamp): Likewise.
6079 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6080 * menu.h (xmenu_show): Likewise.
6081 * term.c (term_mouse_position): Likewise.
6082 * termhooks.h (struct input_event.timestamp): Likewise.
6083 (struct terminal.mouse_position_hook): Likewise.
6084 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6085 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6086 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6087 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6088 what it was before.
6089 * menu.h, termhooks.h: Include "systime.h", for Time.
6090
6091 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6092 Don't assume that the difference between two unsigned long values
6093 can fit into an integer. At this point, we know button_down_time
6094 <= event->timestamp, so the difference must be nonnegative, so
6095 there's no need to cast the result if double-click-time is
6096 nonnegative, as it should be; check that it's nonnegative, just in
6097 case. This bug is triggered when events are more than 2**31 ms
6098 apart (about 25 days). (Bug#8664)
6099
6100 * xselect.c (last_event_timestamp): Remove duplicate decl.
6101 (x_own_selection): Remove needless cast to unsigned long.
6102
6103 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6104 that always fit in int. Use a sentinel instead of a counter, to
6105 avoid a temp and to allay GCC's concerns about possible int overflow.
6106 * frame.h (struct frame): Use int for menu_bar_items_used
6107 instead of EMACS_INT, since it always fits in int.
6108
6109 * menu.c (grow_menu_items): Check for int overflow.
6110
6111 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6112
6113 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6114 Before, the code was not consistent. These values cannot exceed
6115 2**31 - 1 so there's no need to make them unsigned.
6116 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6117 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6118 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6119 as modifiers.
6120 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6121
6122 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6123 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6124 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6125 presumably because the widths might not match.
6126
6127 * window.c (size_window): Avoid needless test at loop start.
6128
6129 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6130
6131 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6132
6133 2011-05-12 Drew Adams <drew.adams@oracle.com>
6134
6135 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6136
6137 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6138
6139 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6140 `width' to `bar_area_x' and `bar_area_width', respectively.
6141 (x_scroll_run): Take account of fringe background extension.
6142
6143 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6144 Rename local vars `left' and `width' to `bar_area_x' and
6145 `bar_area_width', respectively.
6146 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6147 background extension.
6148
6149 2011-05-10 Jim Meyering <meyering@redhat.com>
6150
6151 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6152
6153 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6154
6155 * image.c (Finit_image_library): Return t for built-in image types,
6156 like pbm and xbm. (Bug#8640)
6157
6158 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6159
6160 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6161
6162 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6163
6164 * w32console.c (Fset_screen_color): Doc fix.
6165 (Fget_screen_color): New function.
6166 (syms_of_ntterm): Defsubr it.
6167
6168 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6169 unlink the temporary file if Fcall_process didn't create it in the
6170 first place.
6171 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6172 child process will be redirected to a file specified with `:file'.
6173 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6174 cue to call_process_cleanup not to close that handle.
6175
6176 2011-05-07 Ben Key <bkey76@gmail.com>
6177
6178 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6179 one of two shell specific rules, either bootstrap-temacs-CMD or
6180 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6181 to the previous implementation of the bootstrap-temacs rule.
6182 The bootstrap-temacs-CMD rule is similar to the previous
6183 implementation of the bootstrap-temacs rule except that it
6184 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6185 variable.
6186
6187 These changes, along with some changes to nt/configure.bat,
6188 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6189 earlier fix to add support for --cflags and --ldflags options
6190 that include quotes so that it works whether make uses cmd or
6191 sh as the shell.
6192
6193 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6194
6195 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6196 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6197 is a constant.
6198 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6199 a string. Handle both cases.
6200 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6201 (Fdbus_register_method): Use Qinvalid_function.
6202
6203 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6204
6205 * makefile.w32-in: Update dependencies.
6206 (LISP_H): Add inttypes.h and stdin.h.
6207 (PROCESS_H): Add unistd.h.
6208
6209 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6210
6211 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6212 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6213
6214 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6215
6216 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6217
6218 * term.c (vfatal): Remove stray call to va_end.
6219 It's not needed and the C Standard doesn't allow it here anyway.
6220
6221 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6222 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6223
6224 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6225 bytes.
6226
6227 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6228
6229 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6230
6231 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6232
6233 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6234
6235 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6236
6237 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6238 * charset.c (Fdefine_charset_internal): Don't initialize
6239 charset.code_space[15]. The value was garbage, on hosts with
6240 32-bit int (Bug#8600).
6241
6242 * lread.c (read_integer): Be more consistent with string-to-number.
6243 Use string_to_number to do the actual conversion; this avoids
6244 rounding errors and fixes some other screwups. Without this fix,
6245 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6246 (digit_to_number): Move earlier, for benefit of read_integer.
6247 Return -1 if the digit is out of range for the base, -2 if it is
6248 not a digit in any supported base. (Bug#8602)
6249
6250 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6251
6252 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6253 to match comment at start of function. This also removes a
6254 GCC warning about overflow in a 32+64-bit port.
6255
6256 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6257
6258 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6259 Reported by Stefan Monnier in
6260 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6261 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6262 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6263
6264 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6265 (EMACS_UINTPTR): Likewise, with uintptr_t.
6266
6267 * lisp.h: Prefer 64-bit EMACS_INT if available.
6268 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6269 on 32-bit hosts that have 64-bit int, so that they can access
6270 large files.
6271 However, temporarily disable this change unless the temporary
6272 symbol WIDE_EMACS_INT is defined.
6273
6274 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6275
6276 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6277 This removes an assumption that EMACS_INT and long are the same
6278 width as pointers. The assumption is true for Emacs porting targets
6279 now, but we want to make other targets possible.
6280 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6281 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6282 In the rest of the code, change types of integers that hold casted
6283 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6284 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6285 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6286 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6287 No need to cast type when ORing.
6288 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6289 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6290 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6291 assume EMACS_INT is the same width as char *.
6292 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6293 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6294 Remove no-longer-needed casts.
6295 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6296 (xg_tool_bar_help_callback, xg_make_tool_item):
6297 Use EMACS_INTPTR to hold an integer
6298 that will be cast to void *; this can avoid a GCC warning
6299 if EMACS_INT is not the same width as void *.
6300 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6301 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6302 (current_message_1, set_message_1):
6303 Use a local to convert to proper width without a cast.
6304 * xmenu.c (dialog_selection_callback): Likewise.
6305
6306 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6307 Also, don't assume VALBITS / RAND_BITS is less than 5,
6308 and don't rely on undefined behavior when shifting a 1 left into
6309 the sign bit.
6310 * lisp.h (get_random): Change signature to match.
6311
6312 * lread.c (hash_string): Use size_t, not int, for hash computation.
6313 Normally we prefer signed values; but hashing is special, because
6314 it's better to use unsigned division on hash table sizes so that
6315 the remainder is nonnegative. Also, size_t is the natural width
6316 for hashing into memory. The previous code used 'int', which doesn't
6317 retain enough info to hash well into very large tables.
6318 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6319
6320 * dbusbind.c: Don't possibly lose pointer info when converting.
6321 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6322 Use XPNTR rather than XHASH, so that the high-order bits of
6323 the pointer aren't lost when converting through void *.
6324
6325 * eval.c (Fautoload): Don't double-shift a pointer.
6326
6327 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6328
6329 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6330
6331 * gnutls.c (DEF_GNUTLS_FN):
6332 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6333
6334 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6335
6336 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6337 marker. (Bug#8610)
6338
6339 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6340
6341 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6342 New version that can reserve upto 2GB of heap space.
6343
6344 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6345
6346 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6347
6348 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6349
6350 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6351 `gnutls_certificate_set_x509_key_file'.
6352
6353 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6354
6355 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6356 Update dependencies.
6357
6358 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6359
6360 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6361 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6362 Remove unused parameter `fildes'.
6363 * process.c (read_process_output, send_process): Don't pass it.
6364
6365 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6366
6367 Fix previous change: the library cache is defined in w32.c.
6368 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6369 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6370
6371 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6372
6373 Implement dynamic loading of GnuTLS on Windows.
6374
6375 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6376 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6377 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6378 Declare.
6379
6380 * gnutls.c (Qgnutls_dll): Define.
6381 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6382 (gnutls_*): Declare function pointers.
6383 (init_gnutls_functions): New function to initialize function pointers.
6384 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6385 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6386 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6387 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6388 (emacs_gnutls_write, emacs_gnutls_read)
6389 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6390 (Fgnutls_available_p): New function.
6391 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6392 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6393 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6394
6395 * image.c: Include w32.h.
6396 (Vimage_type_cache): Delete.
6397 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6398 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6399 (w32_delayed_load): Move to w32.c.
6400
6401 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6402
6403 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6404 (w32_delayed_load): Move from image.c. When loading a library, record
6405 its filename in the :loaded-from property of the library id.
6406 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6407 Initialize and staticpro them.
6408 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6409
6410 * process.c: Include lisp.h before w32.h, not after.
6411 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6412 instead of gnutls_record_check_pending.
6413
6414 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6415
6416 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6417
6418 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6419 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6420 as passed in.
6421
6422 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6423
6424 * xterm.c (x_set_frame_alpha): Do not set property on anything
6425 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6426
6427 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6428
6429 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6430
6431 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6432
6433 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6434 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6435 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6436 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6437 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6438 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6439 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6440 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6441 (Qgnutls_bootprop_callbacks_verify): Make static.
6442
6443 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6444
6445 * callproc.c: Indentation fixup.
6446
6447 * sysdep.c (wait_for_termination_1): Make static.
6448 (wait_for_termination, interruptible_wait_for_termination):
6449 Move after wait_for_termination_1.
6450
6451 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6452
6453 * sysdep.c (interruptible_wait_for_termination): New function
6454 which is like wait_for_termination, but allows keyboard
6455 interruptions.
6456
6457 * callproc.c (Fcall_process): Add (:file "file") as an option for
6458 the STDOUT buffer.
6459 (Fcall_process_region): Ditto.
6460
6461 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6462
6463 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6464 rather than `XVECTOR (FOO)->size'.
6465
6466 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6467 inttypes.h, as a gnulib replacement is used if it not available in
6468 system headers.
6469
6470 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6471
6472 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6473 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6474 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6475
6476 * coding.c (coding_alloc_by_realloc): Error out if destination
6477 will grow beyond MOST_POSITIVE_FIXNUM.
6478 (decode_coding_emacs_mule): Abort if there isn't enough place in
6479 charbuf for the composition carryover bytes. Reserve an extra
6480 space for up to 2 characters produced in a loop.
6481 (decode_coding_iso_2022): Abort if there isn't enough place in
6482 charbuf for the composition carryover bytes.
6483
6484 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6485
6486 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6487 aborting when %lld or %lll format is passed.
6488 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6489 %llo or %llx format is passed. (Bug#8545)
6490
6491 * window.c (window_scroll_line_based): Use a marker instead of
6492 simple variables to record original value of point. (Bug#7952)
6493
6494 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6495 produced by %s or %c overflows available buffer space. (Bug#8545)
6496
6497 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6498
6499 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6500 (SIZE_MAX): Move defn after all includes, as they might #define it.
6501
6502 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6503
6504 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6505
6506 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6507
6508 * keyboard.c (Qdelayed_warnings_hook): Define.
6509 (command_loop_1): Run `delayed-warnings-hook'
6510 if Vdelayed_warnings_list is non-nil.
6511 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6512 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6513
6514 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6515
6516 * doprnt.c (doprnt): Don't return value smaller than the buffer
6517 size if the message was truncated. (Bug#8545).
6518
6519 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6520
6521 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6522 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6523
6524 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6525
6526 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6527
6528 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6529
6530 * makefile.w32-in: Update dependencies.
6531
6532 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6533
6534 Improve `doprnt' and its usage. (Bug#8545)
6535 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6536 `format_end'. Remove support for %l as a conversion specifier.
6537 Don't use xrealloc. Improve diagnostics when the %l size modifier
6538 is used. Update the commentary.
6539
6540 * eval.c (verror): Simplify calculation of size_t.
6541
6542 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6543 messages.
6544
6545 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6546
6547 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6548 change.
6549
6550 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6551
6552 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6553 This makes this file independent of the recent pseudovector change.
6554
6555 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6556
6557 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6558
6559 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6560 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6561 Remove unused local.
6562 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6563
6564 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6565 GCC 4.6.0 optimizes based on type-based alias analysis.
6566 For example, if b is of type struct buffer * and v of type struct
6567 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6568 != &v->size, and therefore "v->size = 1; b->size = 2; return
6569 v->size;" must therefore return 1. This assumption is incorrect
6570 for Emacs, since it type-puns struct Lisp_Vector * with many other
6571 types. To fix this problem, this patch adds a new type struct
6572 vectorlike_header that documents the constraints on layout of vectors
6573 and pseudovectors, and helps optimizing compilers not get fooled
6574 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6575 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6576 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6577 the size member.
6578 (XSETPVECTYPE): Rewrite in terms of new macro.
6579 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6580 This is a bit clearer, and further avoids the possibility of
6581 undesirable aliasing.
6582 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6583 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6584 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6585 since Lisp_Subr is a special case (no "next" field).
6586 (ASIZE): Now uses header.size rather than size.
6587 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6588 to avoid the hassle of writing XVECTOR (foo)->header.size.
6589 (struct vectorlike_header): New type.
6590 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6591 object, to help avoid aliasing.
6592 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6593 (SUBRP): Likewise, since Lisp_Subr is a special case.
6594 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6595 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6596 (struct Lisp_Hash_Table): Combine first two members into a single
6597 struct vectorlike_header member. All uses of "size" and "next" members
6598 changed to be "header.size" and "header.next".
6599 * buffer.h (struct buffer): Likewise.
6600 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6601 * frame.h (struct frame): Likewise.
6602 * process.h (struct Lisp_Process): Likewise.
6603 * termhooks.h (struct terminal): Likewise.
6604 * window.c (struct save_window_data, struct saved_window): Likewise.
6605 * window.h (struct window): Likewise.
6606 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6607 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6608 * buffer.c (init_buffer_once): Likewise.
6609 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6610 special case.
6611 * process.c (Fformat_network_address): Use local var for size,
6612 for brevity.
6613
6614 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6615
6616 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6617 * data.c (atof): Remove decl; no longer used or needed.
6618 (digit_to_number): Move to lread.c.
6619 (Fstring_to_number): Use new string_to_number function, to be
6620 consistent with how the Lisp reader treats infinities and NaNs.
6621 Do not assume that floating-point numbers represent EMACS_INT
6622 without losing information; this is not true on most 64-bit hosts.
6623 Avoid double-rounding errors, by insisting on integers when
6624 parsing non-base-10 numbers, as the documentation specifies.
6625 * lisp.h (string_to_number): New decl, replacing ...
6626 (isfloat_string): Remove.
6627 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6628 (read1): Do not accept +. and -. as integers; this
6629 appears to have been a coding error. Similarly, do not accept
6630 strings like +-1e0 as floating point numbers. Do not report
6631 overflow for integer overflows unless the base is not 10 which
6632 means we have no simple and reliable way to continue.
6633 Break out the floating-point parsing into a new
6634 function string_to_number, so that Fstring_to_number parses
6635 floating point numbers consistently with the Lisp reader.
6636 (digit_to_number): Move here from data.c. Make it static inline.
6637 (E_CHAR, EXP_INT): Remove, replacing with ...
6638 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6639 (string_to_number): New function, replacing isfloat_string.
6640 This function checks for valid syntax and produces the resulting
6641 Lisp float number too. Rework it so that string-to-number
6642 no longer mishandles examples like "1.0e+". Use strtoumax,
6643 so that overflow for non-base-10 numbers is reported only when
6644 there's no portable and simple way to convert to floating point.
6645
6646 * textprop.c (set_text_properties_1): Rewrite for clarity,
6647 and to avoid GCC warning about integer overflow.
6648
6649 * intervals.h (struct interval): Use EMACS_INT for members
6650 where EMACS_UINT might cause problems. See
6651 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6652 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6653 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6654 All uses changed.
6655 (offset_intervals): Tell GCC not to worry about length overflow
6656 when negating a negative length.
6657
6658 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6659 (overrun_check_free): Likewise.
6660
6661 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6662 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6663 word size.
6664
6665 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6666 (gnutls_make_error): Rename local to avoid shadowing.
6667 (gnutls_emacs_global_deinit): ifdef out; not used.
6668 (Fgnutls_boot): Use const for pointer to readonly storage.
6669 Comment out unused local. Fix pointer signedness problems.
6670
6671 * lread.c (openp): Don't stuff size_t into an 'int'.
6672 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6673 about possible signed overflow.
6674
6675 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6676 (GDK_KEY_g): Don't define if already defined.
6677 (xg_prepare_tooltip): Avoid pointer signedness problem.
6678 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6679
6680 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6681 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6682
6683 * xfns.c (Fx_window_property): Simplify a bit,
6684 to make a bit faster and to avoid GCC 4.6.0 warning.
6685 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6686
6687 * fns.c (internal_equal): Don't assume size_t fits in int.
6688
6689 * alloc.c (compact_small_strings): Tighten assertion a little.
6690
6691 Replace pEd with more-general pI, and fix some printf arg casts.
6692 * lisp.h (pI): New macro, generalizing old pEd macro to other
6693 conversion specifiers. For example, use "...%"pI"d..." rather
6694 than "...%"pEd"...".
6695 (pEd): Remove. All uses replaced with similar uses of pI.
6696 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6697 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6698 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6699 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6700 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6701 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6702 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6703 64-bit hosts.
6704 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6705 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6706 * print.c (safe_debug_print, print_object): Likewise.
6707 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6708 to int.
6709 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6710 avoiding the 0 flag, which is not portable.
6711 * process.c (Fmake_network_process): Use pI to avoid cast.
6712 * region-cache.c (pp_cache): Likewise.
6713 * xdisp.c (decode_mode_spec): Likewise.
6714 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6715 behavior on 64-bit hosts with printf arg.
6716 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6717 (x_stop_queuing_selection_requests): Likewise.
6718 (x_get_window_property): Don't truncate byte count to an 'int'
6719 when tracing.
6720
6721 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6722 here, since it parses constructs like leading '-' and spaces,
6723 which are not wanted; and it overflows with large numbers.
6724 Instead, simply match F[0-9]+, which is what is wanted anyway.
6725
6726 * alloc.c: Remove unportable assumptions about struct layout.
6727 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6728 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6729 (allocate_vectorlike, make_pure_vector): Use the new macros,
6730 plus offsetof, to remove unportable assumptions about struct layout.
6731 These assumptions hold on all porting targets that I know of, but
6732 they are not guaranteed, they're easy to remove, and removing them
6733 makes further changes easier.
6734
6735 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6736 This doesn't fix a bug but makes the code clearer.
6737 (string_overrun_cookie): Now const. Use initializers that
6738 don't formally overflow signed char, to avoid warnings.
6739 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6740 can cause Emacs to crash when string overrun checking is enabled.
6741 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6742 multiple of sizeof (EMACS_INT); it need not be, if
6743 alignof(EMACS_INT) < sizeof (EMACS_INT).
6744 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6745
6746 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6747
6748 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6749
6750 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6751
6752 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6753 supposed to be handshaking. (Bug#8556)
6754 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6755
6756 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6757
6758 * lisp.h (Qdebug): List symbol.
6759 * eval.c (Qdebug): Restore global linkage.
6760 * keyboard.c (debug-on-event): New variable.
6761 (handle_user_signal): Break into debugger when debug-on-event
6762 matches the current signal symbol.
6763
6764 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6765
6766 * alloc.c (check_sblock, check_string_bytes)
6767 (check_string_free_list): Convert to standard C.
6768
6769 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6770
6771 * w32.c (emacs_gnutls_push): Fix typo.
6772
6773 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6774
6775 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6776 "cast to pointer from integer of different size".
6777
6778 Improve doprnt and its use in verror. (Bug#8545)
6779 * doprnt.c (doprnt): Document the set of format control sequences
6780 supported by the function. Use SAFE_ALLOCA instead of always
6781 using `alloca'.
6782
6783 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6784 is one byte too soon. Don't use xrealloc; instead xfree and
6785 xmalloc anew.
6786
6787 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6788
6789 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6790 callbacks stage.
6791
6792 * gnutls.c: Renamed global_initialized to
6793 gnutls_global_initialized. Added internals for the
6794 :verify-hostname-error, :verify-error, and :verify-flags
6795 parameters of `gnutls-boot' and documented those parameters in the
6796 docstring. Start callback support.
6797 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6798 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6799 on error. Return error code.
6800 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6801 (emacs_gnutls_read): Likewise.
6802 (Fgnutls_boot): Return handshake error code.
6803 (emacs_gnutls_handle_error): New function.
6804 (wsaerror_to_errno): Likewise.
6805
6806 * w32.h (emacs_gnutls_pull): Add prototype.
6807 (emacs_gnutls_push): Likewise.
6808
6809 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6810 (emacs_gnutls_push): Likewise.
6811
6812 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6813
6814 * process.c (wait_reading_process_output): Check if GnuTLS
6815 buffered some data internally if no FDs are set for TLS
6816 connections.
6817
6818 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6819 (LIBS): Link to USER_LIBS.
6820 ($(BLD)/gnutls.$(0)): New target.
6821
6822 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6823
6824 * xdisp.c (handle_single_display_spec): Rename the
6825 display_replaced_before_p argument into display_replaced_p, to
6826 make it consistent with the commentary. Fix typos in the
6827 commentary.
6828
6829 * textprop.c (syms_of_textprop): Remove dead code.
6830 (copy_text_properties): Delete obsolete commentary about an
6831 interface that was deleted long ago. Fix typos in the description
6832 of arguments.
6833
6834 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6835 to changes in oldXMenu/XMenu.h from 2011-04-16.
6836 <menu_help_message, prev_menu_help_message>: Constify.
6837 (IT_menu_make_room): menu->help_text is now `const char **';
6838 adjust.
6839
6840 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6841 to changes in oldXMenu/XMenu.h from 2011-04-16.
6842 (struct XMenu): Declare `help_text' `const char **'.
6843
6844 * xfaces.c <Qunspecified>: Make extern again.
6845
6846 * syntax.c: Include sys/types.h before including regex.h, as
6847 required by Posix.
6848
6849 * doc.c (get_doc_string): Improve the format passed to `error'.
6850
6851 * doprnt.c (doprnt): Improve commentary.
6852
6853 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6854
6855 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6856 them with etags.
6857
6858 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6859 changes in globals.h immediately force recompilation.
6860 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6861 $(CURDIR)/s/ms-w32.h.
6862 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6863
6864 * character.c (Fchar_direction): Function deleted.
6865 (syms_of_character): Don't defsubr it.
6866 <char-direction-table>: Deleted.
6867
6868 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6869
6870 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6871 * doprnt.c: Include limits.h.
6872 (SIZE_MAX): New macro.
6873 (doprnt): Return a size_t value. 2nd arg is now size_t.
6874 Many local variables are now size_t instead of int or unsigned.
6875 Improve overflow protection. Support `l' modifier for integer
6876 conversions. Support %l conversion. Don't assume an EMACS_INT
6877 argument for integer conversions and for %c.
6878
6879 * lisp.h (doprnt): Restore prototype.
6880
6881 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6882 $(SRC)/character.h.
6883
6884 * Makefile.in (base_obj): Add back doprnt.o.
6885
6886 * deps.mk (doprnt.o): Add back prerequisites.
6887 (callint.o): Depend on character.h.
6888
6889 * eval.c (internal_lisp_condition_case): Include the handler
6890 representation in the error message.
6891 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6892 when breaking from the loop.
6893
6894 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6895
6896 * callint.c (Fcall_interactively): When displaying error message
6897 about invalid control letter, pass the character's codepoint, not
6898 a pointer to its multibyte form. Improve display of the character
6899 in octal and display also its hex code.
6900
6901 * character.c (char_string): Use %x to display the (unsigned)
6902 codepoint of an invalid character, to avoid displaying a bogus
6903 negative value.
6904
6905 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6906 `error', not SYMBOL_NAME itself.
6907
6908 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6909 character arguments to `error'.
6910
6911 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6912 to `error' in error message about FINAL_CHAR argument. Make sure
6913 FINAL_CHAR is a character, and use %c when it is passed as
6914 argument to `error'.
6915
6916 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6917
6918 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6919
6920 * w32.c: Include <time.h>.
6921 (sys_localtime): New function.
6922
6923 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6924
6925 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6926
6927 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6928
6929 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6930
6931 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6932 zombies (Bug#8467).
6933
6934 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6935
6936 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6937 gl_state.e_property when gl_state.object is Qt.
6938
6939 * insdel.c (make_gap_larger): Remove limitation of buffer size
6940 to <= INT_MAX.
6941
6942 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6943
6944 * xdisp.c (lookup_glyphless_char_display)
6945 (produce_glyphless_glyph): Handle cons cell entry in
6946 glyphless-char-display.
6947 (Vglyphless_char_display): Document it.
6948
6949 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6950 glyphless-char-display.
6951
6952 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6953
6954 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6955
6956 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6957
6958 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6959 definition for no-X builds.
6960
6961 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6962
6963 Static checks with GCC 4.6.0 and non-default toolkits.
6964
6965 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6966
6967 * process.c (keyboard_bit_set): Define only if SIGIO.
6968 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6969 (send_process): Repair possible setjmp clobbering.
6970
6971 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6972
6973 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6974
6975 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6976
6977 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6978 Define only if needed.
6979
6980 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6981 by pacifying GCC about it. Maybe it's time to retire it?
6982 * xfaces.c (USG, __TIMEVAL__): Likewise.
6983
6984 * dispextern.h (struct redisplay_interface): Rename param
6985 to avoid shadowing.
6986 * termhooks.h (struct terminal): Likewise.
6987 * xterm.c (xembed_send_message): Likewise.
6988
6989 * insdel.c (make_gap_smaller): Define only if
6990 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6991
6992 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6993 it.
6994
6995 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6996 so that we aren't warned about unused symbols.
6997
6998 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6999
7000 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7001
7002 * xfns.c (x_real_positions): Mark locals as initialized.
7003
7004 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7005
7006 * xterm.c: Fix problems found by static analysis with other toolkits.
7007 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7008 (x_dispatch_event): Declare static if USE_GTK, and
7009 define if USE_GTK || USE_X_TOOLKIT.
7010 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7011 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7012 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7013 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7014
7015 * xmenu.c (menu_help_callback): Pointer type fixes.
7016 Use const pointers when pointing at readonly data. Avoid pointer
7017 signedness clashes.
7018 (FALSE): Remove unused macro.
7019 (update_frame_menubar): Remove unused decl.
7020
7021 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7022
7023 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7024 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7025 (single_menu_item): Rename local to avoid shadowing.
7026
7027 * keyboard.c (make_lispy_event): Remove unused local var.
7028
7029 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7030 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7031
7032 * bitmaps: Change bitmaps from unsigned char back to the X11
7033 compatible char. Avoid the old compiler warnings about
7034 out-of-range initializers by using, for example, '\xab' rather
7035 than 0xab.
7036
7037 * xgselect.c (xgselect_initialize): Check vs interface
7038 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7039
7040 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7041
7042 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7043 to read-only memory.
7044
7045 * fns.c (vector): Remove; this old hack is no longer needed.
7046
7047 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7048 Remove unused var.
7049 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7050
7051 * xrdb.c (x_load_resources): Omit unused local.
7052
7053 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7054 (x_window): Rename locals to avoid shadowing.
7055 (USG): Use the kludged USG macro, to pacify gcc.
7056
7057 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7058 (x_term_init): Remove local to avoid shadowing.
7059
7060 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7061
7062 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7063 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7064
7065 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7066
7067 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7068
7069 Fix regex.c, syntax.c and friends for buffers > 2GB.
7070 * syntax.h (struct gl_state_s): Declare character position members
7071 EMACS_INT.
7072
7073 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7074
7075 * textprop.c (verify_interval_modification, interval_of):
7076 Declare arguments EMACS_INT.
7077
7078 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7079 EMACS_INT.
7080
7081 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7082
7083 * indent.c (Fvertical_motion): Local variable it_start is now
7084 EMACS_INT.
7085
7086 * regex.c (re_match, re_match_2, re_match_2_internal)
7087 (bcmp_translate, regcomp, regexec, print_double_string)
7088 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7089 (re_compile_pattern, re_exec): Declare arguments and local
7090 variables `size_t' and `ssize_t' and return values `regoff_t', as
7091 appropriate.
7092 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7093 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7094 <compile_stack_type>: `size' and `avail' are now `size_t'.
7095
7096 * regex.h <regoff_t>: Use ssize_t, not int.
7097 (re_search, re_search_2, re_match, re_match_2): Arguments that
7098 specify buffer/string position and length are now ssize_t and
7099 size_t. Return type is regoff_t.
7100
7101 2011-04-16 Ben Key <bkey76@gmail.com>
7102
7103 * nsfont.m: Fixed bugs in ns_get_family and
7104 ns_descriptor_to_entity that were caused by using free to
7105 deallocate memory blocks that were allocated by xmalloc (via
7106 xstrdup). This caused Emacs to crash when compiled with
7107 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7108 --enable-checking=xmallocoverrun). xfree is now used to
7109 deallocate these memory blocks.
7110
7111 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7112
7113 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7114
7115 emacs_write: Accept and return EMACS_INT for sizes.
7116 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7117 et seq.
7118 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7119 Accept and return EMACS_INT.
7120 (emacs_gnutls_write): Return the number of bytes written on
7121 partial writes.
7122 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7123 (emacs_read, emacs_write): Remove check for negative size, as the
7124 Emacs source code has been audited now.
7125 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7126 (emacs_read, emacs_write): Use it.
7127 * process.c (send_process): Adjust to the new signatures of
7128 emacs_write and emacs_gnutls_write. Do not attempt to store
7129 a byte offset into an 'int'; it might overflow.
7130 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7131
7132 * sound.c: Don't assume sizes fit in 'int'.
7133 (struct sound_device.period_size, alsa_period_size):
7134 Return EMACS_INT, not int.
7135 (struct sound_device.write, vox_write, alsa_write):
7136 Accept EMACS_INT, not int.
7137 (wav_play, au_play): Use EMACS_INT to store sizes and to
7138 record read return values.
7139
7140 2011-04-15 Ben Key <bkey76@gmail.com>
7141
7142 * keyboard.c (Qundefined): Don't declare static since it is used
7143 in nsfns.m.
7144 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7145 static since they are used in nsfont.m.
7146
7147 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7148
7149 * process.c (Qprocessp): Don't declare static.
7150 * lisp.h (Qprocessp): Declare again.
7151
7152 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7153
7154 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7155
7156 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7157
7158 Improve C-level modularity by making more things 'static'.
7159
7160 Don't publish debugger-only interfaces to other modules.
7161 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7162 (verify_bytepos, count_markers): Move decls to the only modules
7163 that need them.
7164 * region-cache.h (pp_cache): Likewise.
7165 * window.h (check_all_windows): Likewise.
7166 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7167
7168 * sysdep.c (croak): Now static, if
7169 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7170 * syssignal.h (croak): Declare only if not static.
7171
7172 * alloc.c (refill_memory_reserve): Now static if
7173 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7174 * lisp.h (refill_memory_reserve): Declare only if not static.
7175
7176 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7177 Define only if USE_LUCID.
7178
7179 * xrdb.c (x_customization_string, x_rm_string): Now static.
7180
7181 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7182 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7183
7184 * xdisp.c (draw_row_with_mouse_face): Now static.
7185 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7186
7187 * window.h (check_all_windows): Mark externally visible.
7188
7189 * window.c (window_deletion_count): Now static.
7190
7191 * undo.c: Make symbols static if they're not exported.
7192 (last_undo_buffer, last_boundary_position, pending_boundary):
7193 Now static.
7194
7195 * textprop.c (interval_insert_behind_hooks): Now static.
7196 (interval_insert_in_front_hooks): Likewise.
7197
7198 * term.c: Make symbols static if they're not exported.
7199 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7200 (max_frame_lines, tty_set_terminal_modes):
7201 (tty_reset_terminal_modes, tty_turn_off_highlight):
7202 (get_tty_terminal): Now static.
7203 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7204 * termhooks.h (term_mouse_moveto): Do not declare if
7205 HAVE_WINDOW_SYSTEM.
7206 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7207 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7208
7209 * sysdep.c: Make symbols static if they're not exported.
7210 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7211 Now static.
7212 (sigprocmask_set, full_mask): Remove; unused.
7213 (wait_debugging): Mark as visible.
7214 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7215 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7216
7217 * syntax.c (syntax_temp): Define only if !__GNUC__.
7218
7219 * sound.c (current_sound_device, current_sound): Now static.
7220
7221 * search.c (searchbufs, searchbuf_head): Now static.
7222
7223 * scroll.c (scroll_cost): Remove; unused.
7224 * dispextern.h (scroll_cost): Remove decl.
7225
7226 * region-cache.h (pp_cache): Mark as externally visible.
7227
7228 * process.c: Make symbols static if they're not exported.
7229 (process_tick, update_tick, create_process, chan_process):
7230 (Vprocess_alist, proc_buffered_char, datagram_access):
7231 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7232 (deactivate_process): Mark defn as static, as well as decl.
7233 * lisp.h (create_process): Remove decl.
7234 * process.h (chan_process, Vprocess_alist): Remove decls.
7235
7236 * print.c: Make symbols static if they're not exported.
7237 (print_depth, new_backquote_output, being_printed, print_buffer):
7238 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7239 (print_interval, print_number_index, initial_stderr_stream):
7240 Now static.
7241 * lisp.h (Fprinc): Remove decl.
7242 (debug_output_compilation_hack): Mark as externally visible.
7243
7244 * sysdep.c (croak): Move decl from here to syssignal.h.
7245 * syssignal.h (croak): Put it here, so the API can be checked when
7246 'croak' is called from dissociate_if_controlling_tty.
7247
7248 * minibuf.c: Make symbols static if they're not exported.
7249 (minibuf_save_list, choose_minibuf_frame): Now static.
7250 * lisp.h (choose_minibuf_frame): Remove decl.
7251
7252 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7253
7254 * lread.c: Make symbols static if they're not exported.
7255 (read_objects, initial_obarray, oblookup_last_bucket_number):
7256 Now static.
7257 (make_symbol): Remove; unused.
7258 * lisp.h (initial_obarray, make_symbol): Remove decls.
7259
7260 * keyboard.c: Make symbols static if they're not exported.
7261 (single_kboard, recent_keys_index, total_keys, recent_keys):
7262 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7263 (this_single_command_key_start, echoing, last_auto_save):
7264 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7265 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7266 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7267 (Vlispy_mouse_stem, double_click_count):
7268 Now static.
7269 (force_auto_save_soon): Define only if SIGDANGER.
7270 (ignore_mouse_drag_p): Now static if
7271 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7272 (print_help): Remove; unused.
7273 (stop_character, last_timer_event): Mark as externally visible.
7274 * keyboard.h (ignore_mouse_drag_p): Declare only if
7275 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7276 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7277 * lisp.h (echoing): Remove decl.
7278 (force_auto_save_soon): Declare only if SIGDANGER.
7279 * xdisp.c (redisplay_window): Simplify code, to make it more
7280 obvious that ignore_mouse_drag_p is not accessed if !defined
7281 USE_GTK && !defined HAVE_NS.
7282
7283 * intervals.c: Make symbols static if they're not exported.
7284 (merge_properties_sticky, merge_interval_right, delete_interval):
7285 Now static.
7286 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7287
7288 * insdel.c: Make symbols static if they're not exported.
7289 However, leave prepare_to_modify_buffer alone. It's never
7290 called from outside this function, but that appears to be a bug.
7291 (combine_after_change_list, combine_after_change_buffer):
7292 (adjust_after_replace, signal_before_change): Now static.
7293 (adjust_after_replace_noundo): Remove; unused.
7294 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7295 (signal_before_change): Remove decls.
7296
7297 * indent.c (val_compute_motion, val_vmotion): Now static.
7298
7299 * image.c: Make symbols static if they're not exported.
7300 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7301 if USE_GTK.
7302 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7303 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7304
7305 * fringe.c (standard_bitmaps): Now static.
7306 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7307
7308 * frame.c: Make symbols static if they're not exported.
7309 (x_report_frame_params, make_terminal_frame): Now static.
7310 (get_frame_param): Now static, unless HAVE_NS.
7311 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7312 (x_get_resource_string): Remove; not used.
7313 * frame.h (make_terminal_frame, x_report_frame_params):
7314 (x_get_resource_string); Remove decls.
7315 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7316 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7317
7318 * font.c, fontset.c: Make symbols static if they're not exported.
7319 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7320 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7321 * font.c (font_close_object): Now static.
7322 * font.h (font_close_object): Remove.
7323 * fontset.c (FONTSET_OBJLIST): Remove.
7324 (free_realized_fontset) #if-0 the body, which does nothing.
7325 (face_suitable_for_char_p): #if-0, as it's never called.
7326 * fontset.h (face_suitable_for_char_p): Remove decl.
7327 * xfaces.c (face_at_string_position):
7328 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7329 since 0 is always ASCII.
7330
7331 * fns.c (weak_hash_tables): Now static.
7332
7333 * fileio.c: Make symbols static if they're not exported.
7334 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7335 (Vwrite_region_annotation_buffers): Now static.
7336
7337 * eval.c: Make symbols static if they're not exported.
7338 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7339 * lisp.h (backtrace_list): Remove decl.
7340
7341 * emacs.c: Make symbols static if they're not exported.
7342 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7343 (fatal_error_code, fatal_error_signal_hook, standard_args):
7344 Now static.
7345 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7346 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7347 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7348 * lisp.h (fatal_error_signal_hook): Remove decl.
7349 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7350
7351 * editfns.c: Move a (normally-unused) function to its only use.
7352 * editfns.c, lisp.h (get_operating_system_release): Remove.
7353 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7354 worth the hassle of breaking this out.
7355
7356 * xterm.c: Make symbols static if they're not exported.
7357 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7358 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7359 (x_destroy_window, x_delete_display):
7360 Now static.
7361 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7362 (x_mouse_leave): Remove; unused.
7363 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7364 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7365 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7366 Remove decls.
7367 (x_mouse_leave): Declare only if WINDOWSNT.
7368 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7369 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7370 USE_X_TOOLKIT.
7371
7372 * ftxfont.c: Make symbols static if they're not exported.
7373 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7374 HAVE_FREETYPE.
7375 * font.h (ftxfont_driver): Likewise.
7376
7377 * xfns.c: Make symbols static if they're not exported.
7378 (x_last_font_name, x_display_info_for_name):
7379 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7380 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7381 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7382 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7383 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7384 (last_show_tip_args): Now static.
7385 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7386 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7387 (x_screen_planes): Remove; unused.
7388 * dispextern.h (x_screen_planes): Remove decl.
7389
7390 * dispnew.c: Make symbols static if they're not exported.
7391 * dispextern.h (redraw_garbaged_frames, scrolling):
7392 (increment_row_positions): Remove.
7393 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7394 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7395 Now static.
7396 (redraw_garbaged_frames): Remove; unused.
7397
7398 * xfaces.c: Make symbols static if they're not exported.
7399 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7400 Remove decls.
7401 * xterm.h (defined_color): Remove decls.
7402 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7403 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7404 (menu_face_changed_default, defined_color, free_realized_face):
7405 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7406 (ascii_face_of_lisp_face): Remove; unused.
7407
7408 * xdisp.c: Make symbols static if they're not exported.
7409 * dispextern.h (scratch_glyph_row, window_box_edges):
7410 (glyph_to_pixel_coords, set_cursor_from_row):
7411 (get_next_display_element, set_iterator_to_next):
7412 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7413 (show_mouse_face): Remove decls
7414 * frame.h (message_buf_print): Likewise.
7415 * lisp.h (pop_message, set_message, check_point_in_composition):
7416 Likewise.
7417 * xterm.h (set_vertical_scroll_bar): Likewise.
7418 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7419 (message_buf_print, scratch_glyph_row, displayed_buffer):
7420 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7421 (get_next_display_element, show_mouse_face, window_box_edges):
7422 (frame_to_window_pixel_xy, check_point_in_composition):
7423 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7424 (glyph_to_pixel_coords): Remove; unused.
7425
7426 * dired.c (file_name_completion): Now static.
7427
7428 * dbusbind.c (xd_in_read_queued_messages): Now static.
7429
7430 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7431 * data.c (circular_list_error): Remove.
7432
7433 * commands.h (last_point_position, last_point_position_buffer):
7434 (last_point_position_window): Remove decls.
7435 * keyboard.c: Make these variables static.
7436
7437 * coding.h (coding, code_convert_region, encode_coding_gap):
7438 Remove decls.
7439 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7440 (iso_code_class, detect_coding, code_convert_region): Now static.
7441 (encode_coding_gap): Remove; unused.
7442
7443 * chartab.c (chartab_chars, chartab_bits): Now static.
7444
7445 * charset.h (charset_iso_8859_1): Remove decl.
7446 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7447 Now static.
7448
7449 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7450 * ccl.c (Vccl_program_table): Now static.
7451 (check_ccl_update): Remove; unused.
7452
7453 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7454 * category.h: ... from here.
7455 * category.c (check_category_table, set_category_set): Now static.
7456
7457 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7458 * lisp.h: Remove these decls.
7459
7460 * buffer.c (buffer_count): Remove unused var.
7461
7462 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7463 so that it's not optimized away.
7464 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7465 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7466 exported only to the debugger.
7467
7468 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7469 * atimer.h (run_all_atimers): Remove; not exported.
7470
7471 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7472 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7473 was inaccessible from Lisp.
7474 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7475 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7476
7477 alloc.c: Import and export fewer symbols, and remove unused items.
7478 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7479 is defined.
7480 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7481 it's not optimized away by whole-program optimization.
7482 (message_enable_multibyte, free_misc): Remove.
7483 (catchlist, handlerlist, mark_backtrace):
7484 Declare only if BYTE_MARK_STACK.
7485 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7486 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7487 (message_enable_multibyte): Remove decl.
7488 (free_misc, interval_free_list, float_block, float_block_index):
7489 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7490 (cons_free_list, last_marked_index):
7491 Now static.
7492 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7493 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7494 (mark_backtrace): Define only if BYTE_MARK_STACK.
7495 * xdisp.c (message_enable_multibyte): Now static.
7496
7497 Declare Lisp_Object Q* variables to be 'static' if not exported.
7498 This makes it easier for human readers (and static analyzers)
7499 to see whether these variables are used from other modules.
7500 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7501 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7502 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7503 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7504 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7505 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7506 * xmenu.c, xselect.c:
7507 Declare Q* vars static if they are not used in other modules.
7508 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7509 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7510 Remove decls of unexported vars.
7511 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7512
7513 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7514
7515 Make Emacs functions such as Fatom 'static' by default.
7516 This makes it easier for human readers (and static analyzers)
7517 to see whether these functions can be called from other modules.
7518 DEFUN now defines a static function. To make the function external
7519 so that it can be used in other C modules, use the new macro DEFUE.
7520 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7521 (Finit_image_library):
7522 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7523 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7524 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7525 Remove decls, since these functions are now static.
7526 (Funintern, Fget_internal_run_time): New decls, since these functions
7527 were already external.
7528
7529 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7530 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7531 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7532 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7533 * keyboard.c, keymap.c, lread.c:
7534 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7535 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7536 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7537 Mark functions with DEFUE instead of DEFUN,
7538 if they are used in other modules.
7539 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7540 decls for now-static functions.
7541 * buffer.h (Fdelete_overlay): Remove decl.
7542 * callproc.c (Fgetenv_internal): Mark as internal.
7543 * composite.c (Fremove_list_of_text_properties): Remove decl.
7544 (Fcomposition_get_gstring): New forward static decl.
7545 * composite.h (Fcomposite_get_gstring): Remove decl.
7546 * dired.c (Ffile_attributes): New forward static decl.
7547 * doc.c (Fdocumntation_property): New forward static decl.
7548 * eval.c (Ffetch_bytecode): New forward static decl.
7549 (Funintern): Remove extern decl; now in .h file where it belongs.
7550 * fileio.c (Fmake_symbolic_link): New forward static decl.
7551 * image.c (Finit_image_library): New forward static decl.
7552 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7553 * intervals.h (Fprevious_property_change):
7554 (Fremove_list_of_text_properties): Remove decls.
7555 * keyboard.c (Fthis_command_keys): Remove decl.
7556 (Fcommand_execute): New forward static decl.
7557 * keymap.c (Flookup_key): New forward static decl.
7558 (Fcopy_keymap): Now static.
7559 * keymap.h (Flookup_key): Remove decl.
7560 * process.c (Fget_process): New forward static decl.
7561 (Fprocess_datagram_address): Mark as internal.
7562 * syntax.c (Fsyntax_table_p): New forward static decl.
7563 (skip_chars): Remove duplicate decl.
7564 * textprop.c (Fprevious_property_change): New forward static decl.
7565 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7566 Now internal.
7567 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7568 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7569
7570 * editfns.c (Fformat): Remove unreachable code.
7571
7572 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7573
7574 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7575 change. (Bug#8496)
7576
7577 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7578
7579 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7580 when at ZV. (Bug#8487)
7581
7582 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7583
7584 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7585 (Bug#8437)
7586 * keyboard.c (parse_tool_bar_item): Likewise.
7587 * sound.c (sound_cleanup, alsa_close): Likewise.
7588 * termcap.c (tgetent): Likewise.
7589 * xfns.c (x_default_font_parameter): Likewise.
7590 * xsettings.c (read_and_apply_settings): Likewise.
7591
7592 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7593 (overrun_check_free): Protoize.
7594
7595 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7596
7597 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7598 since callers should never pass a negative size.
7599 Change the signature to match that of plain 'read' and 'write'; see
7600 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7601 * lisp.h: Update prototypes of emacs_write and emacs_read.
7602
7603 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7604
7605 * xdisp.c (redisplay_window): Don't try to determine the character
7606 position of the scroll margin if the window start point w->startp
7607 is outside the buffer's accessible region. (Bug#8468)
7608
7609 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7610
7611 Fix write-region and its subroutines for buffers > 2GB.
7612 * fileio.c (a_write, e_write): Modify declaration of arguments and
7613 local variables to support buffers larger than 2GB.
7614 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7615
7616 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7617 argument, local variables, and return value.
7618
7619 * lisp.h: Update prototypes of emacs_write and emacs_read.
7620
7621 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7622
7623 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7624
7625 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7626
7627 Fix more problems found by GCC 4.6.0's static checks.
7628
7629 * xdisp.c (vmessage): Use a better test for character truncation.
7630
7631 * charset.c (load_charset_map): <, not <=, for optimization,
7632 and to avoid potential problems with integer overflow.
7633 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7634 * casetab.c (set_identity, shuffle): Likewise.
7635 * editfns.c (Fformat): Likewise.
7636 * syntax.c (skip_chars): Likewise.
7637
7638 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7639 This also lets GCC 4.6.0 generate slightly better loop code.
7640
7641 * callint.c (Fcall_interactively): <, not <=, for optimization.
7642 (Fcall_interactively): Count the number of arguments produced,
7643 not the number of arguments given. This is simpler and lets GCC
7644 4.6.0 generate slightly better code.
7645
7646 * ftfont.c: Distingish more carefully between FcChar8 and char.
7647 The previous code passed unsigned char * to a functions like
7648 strlen and xstrcasecmp that expect char *, which does not
7649 conform to the C standard.
7650 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7651 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7652 char * when the C standard requires it.
7653
7654 * keyboard.c (read_char): Remove unused var.
7655
7656 * eval.c: Port to Windows vsnprintf (Bug#8435).
7657 Include <limits.h>.
7658 (SIZE_MAX): Define if the headers do not.
7659 (verror): Do not give up if vsnprintf returns a negative count.
7660 Instead, grow the buffer. This ports to Windows vsnprintf, which
7661 does not conform to C99. Problem reported by Eli Zaretskii.
7662 Also, simplify the allocation scheme, by avoiding the need for
7663 calling realloc, and removing the ALLOCATED variable.
7664
7665 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7666
7667 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7668 But keep the doprint source code for now, as we might revamp it
7669 and use it again (Bug#8435).
7670 * lisp.h (doprnt): Remove.
7671 * Makefile.in (base_obj): Remove doprnt.o.
7672 * deps.mk (doprnt.o): Remove.
7673
7674 error: Print 32- and 64-bit integers portably (Bug#8435).
7675 Without this change, on typical 64-bit hosts error ("...%d...", N)
7676 was used to print both 32- and 64-bit integers N, which relied on
7677 undefined behavior.
7678 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7679 New macro.
7680 * lisp.h (error, verror): Mark as printf-like functions.
7681 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7682 Report overflow in size calculations when allocating printf buffer.
7683 Do not truncate output string at its first null byte.
7684 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7685 Truncate the output at a character boundary, since vsnprintf does not
7686 do that.
7687 * charset.c (check_iso_charset_parameter): Convert internal
7688 character to string before calling 'error', since %c now has the
7689 printf meaning.
7690 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7691 overflow when computing char to be passed to 'error'. Do not
7692 pass Lisp_Object to 'error'; pass the integer instead.
7693 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7694 formatted with plain %d.
7695
7696 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7697
7698 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7699
7700 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7701
7702 * xterm.c (x_catch_errors): Remove duplicate declaration.
7703
7704 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7705
7706 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7707
7708 2011-04-10 Jim Meyering <meyering@redhat.com>
7709
7710 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7711 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7712 return ssize_t not "int", and use size_t as the buffer length.
7713 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7714 * gnutls.h: Update declarations.
7715 * process.c (read_process_output): Use ssize_t, to match.
7716 (send_process): Likewise.
7717
7718 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7719
7720 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7721
7722 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7723
7724 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7725 Use unsigned char, to match FcChar8 type definition.
7726
7727 * xterm.c (handle_one_xevent):
7728 * xmenu.c (create_and_show_popup_menu):
7729 * xselect.c (x_decline_selection_request)
7730 (x_reply_selection_request): Avoid type-punned deref of X events.
7731
7732 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7733
7734 Fix some uses of `int' instead of EMACS_INT.
7735 * search.c (string_match_1, fast_string_match)
7736 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7737 (scan_buffer, find_next_newline_no_quit)
7738 (find_before_next_newline, search_command, Freplace_match)
7739 (Fmatch_data): Make some `int' variables be EMACS_INT.
7740
7741 * xdisp.c (display_count_lines): 3rd argument and return value now
7742 EMACS_INT. All callers changed.
7743 (pint2hrstr): Last argument is now EMACS_INT.
7744
7745 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7746 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7747 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7748 (decode_coding_utf_16, decode_coding_emacs_mule)
7749 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7750 (decode_coding_ccl, decode_coding_charset)
7751 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7752 (decode_coding_iso_2022, decode_coding_emacs_mule)
7753 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7754 <char_offset, last_offset>: Declare EMACS_INT.
7755 (encode_coding_utf_8, encode_coding_utf_16)
7756 (encode_coding_emacs_mule, encode_invocation_designation)
7757 (encode_designation_at_bol, encode_coding_iso_2022)
7758 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7759 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7760 Declare EMACS_INT.
7761 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7762 (encode_invocation_designation): Last argument P_NCHARS is now
7763 EMACS_INT.
7764 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7765 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7766
7767 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7768 All users changed.
7769
7770 * ccl.c (Fccl_execute_on_string): Declare some variables
7771 EMACS_INT.
7772
7773 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7774
7775 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7776
7777 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7778
7779 * process.c (Fformat_network_address): Doc fix.
7780
7781 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7782
7783 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7784
7785 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7786
7787 * keyboard.c (read_char): Call Lisp function help-form-show,
7788 instead of using internal_with_output_to_temp_buffer.
7789 (Qhelp_form_show): New var.
7790 (syms_of_keyboard): Use DEFSYM macro.
7791
7792 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7793
7794 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7795
7796 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7797
7798 * process.c (Flist_processes): Remove to Lisp.
7799 (list_processes_1): Delete.
7800
7801 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7802
7803 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7804
7805 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7806
7807 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7808
7809 Fix more problems found by GCC 4.6.0's static checks.
7810
7811 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7812
7813 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7814
7815 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7816
7817 * xdisp.c (vmessage): Mark as a printf-like function.
7818
7819 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7820
7821 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7822
7823 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7824 printf-like functions.
7825 (tiff_load): Add casts to remove these marks before passing them
7826 to system-supplied API.
7827
7828 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7829
7830 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7831 This avoids several warnings with gcc -Wstrict-overflow.
7832 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7833 directly, rather than having caller test rule sign. This avoids
7834 some unnecessary tests.
7835 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7836 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7837 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7838
7839 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7840 (xfont_open): Avoid unnecessary tests.
7841
7842 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7843
7844 * composite.h, composite.c (composition_gstring_put_cache):
7845 Use EMACS_INT, not int, for length.
7846
7847 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7848 breaking out part of COMPOSITION_DECODE_RULE.
7849 (COMPOSITION_DECODE_RULE): Use it.
7850 * composite.c (get_composition_id): Remove unused local vars,
7851 by using the new macro.
7852
7853 * textprop.c (set_text_properties_1): Change while to do-while,
7854 since the condition is always true at first.
7855
7856 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7857 (interval_deletion_adjustment): Return unsigned value.
7858 All uses changed.
7859
7860 * process.c (list_processes_1, create_pty, read_process_output):
7861 (exec_sentinel): Remove vars that were set but not used.
7862 (create_pty): Remove unnecessary "volatile"s.
7863 (Fnetwork_interface_info): Avoid possibility of int overflow.
7864 (read_process_output): Do adaptive read buffering even if carryover.
7865 (read_process_output): Simplify nbytes computation if buffered.
7866
7867 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7868
7869 * syntax.c (scan_words): Remove var that was set but not used.
7870 (update_syntax_table): Use unsigned instead of int.
7871
7872 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7873 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7874 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7875
7876 * print.c (print_error_message): Avoid int overflow.
7877
7878 * font.c (font_list_entities): Redo for clarity,
7879 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7880
7881 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7882 (font_score): Avoid potential overflow in diff calculation.
7883
7884 * fns.c (substring_both): Remove var that is set but not used.
7885 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7886
7887 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7888
7889 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7890 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7891 can always succeed if overflow has undefined behavior.
7892
7893 * search.c (boyer_moore, wordify): Remove vars set but not used.
7894 (wordify): Omit three unnecessary tests.
7895
7896 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7897 All callers changed. This avoids the need for an unused var.
7898
7899 * casefiddle.c (casify_region): Remove var that is set but not used.
7900
7901 * dired.c (file_name_completion): Remove var that is set but not used.
7902
7903 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7904
7905 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7906 (Finsert_file_contents): Remove unnecessary code checking fd.
7907
7908 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7909 Check for integer overflow on size calculations.
7910
7911 * buffer.c (Fprevious_overlay_change): Remove var that is set
7912 but not used.
7913
7914 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7915 Remove vars that are set but not used.
7916 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7917 (timer_check_2): Mark vars as initialized.
7918
7919 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7920
7921 * image.c (lookup_image): Remove var that is set but not used.
7922 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7923
7924 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7925 that are set but not used.
7926
7927 * xfns.c (make_invisible_cursor): Don't return garbage
7928 if XCreateBitmapFromData fails (Bug#8410).
7929
7930 * xselect.c (x_get_local_selection, x_handle_property_notify):
7931 Remove vars that are set but not used.
7932
7933 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7934 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7935
7936 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7937 Remove var that is set but not used.
7938 (scroll_bar_windows_size): Now size_t, not int.
7939 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7940 Check for overflow.
7941
7942 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7943 (map_tty_color) [!defined MSDOS]: Likewise.
7944
7945 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7946
7947 * coding.c: Remove vars that are set but not used.
7948 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7949 All callers changed.
7950 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7951 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7952 (decode_coding_charset): Remove vars that are set but not used.
7953
7954 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7955 that is set but not used.
7956
7957 * print.c (print_object): Remove var that is set but not used.
7958
7959 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7960 The gnulib version avoids calling malloc in the usual case,
7961 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7962 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7963 * filelock.c (current_lock_owner): Likewise.
7964 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7965 * sysdep.c: Include allocator.h, careadlinkat.h.
7966 (emacs_no_realloc_allocator): New static constant.
7967 (emacs_readlink): New function.
7968 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7969 ../lib/careadlinkat.h.
7970
7971 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7972
7973 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7974 first non-nil return value).
7975
7976 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7977
7978 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7979 if not defined (Bug#8403).
7980
7981 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7982
7983 * xdisp.c (display_count_lines): Remove parameter `start',
7984 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7985 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7986 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7987 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7988 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7989 and thereabouts. All callers changed.
7990 (get_per_char_metric): Remove parameter `f', unused since
7991 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7992
7993 2011-04-02 Jim Meyering <meyering@redhat.com>
7994
7995 do not dereference NULL upon failed strdup
7996 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7997 (ns_get_family): Likewise.
7998
7999 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8000
8001 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8002
8003 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8004
8005 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8006 later (Bug#8403).
8007
8008 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8009
8010 Add lexical binding.
8011
8012 * window.c (Ftemp_output_buffer_show): New fun.
8013 (Fsave_window_excursion):
8014 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8015
8016 * lread.c (lisp_file_lexically_bound_p): New function.
8017 (Fload): Bind Qlexical_binding.
8018 (readevalloop): Remove `evalfun' arg.
8019 Bind Qinternal_interpreter_environment.
8020 (Feval_buffer): Bind Qlexical_binding.
8021 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8022 Mark as dynamic.
8023 (syms_of_lread): Declare `lexical-binding'.
8024
8025 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8026
8027 * keyboard.c (eval_dyn): New fun.
8028 (menu_item_eval_property): Use it.
8029
8030 * image.c (parse_image_spec): Use Ffunctionp.
8031
8032 * fns.c (concat, mapcar1): Accept byte-code-functions.
8033
8034 * eval.c (Fsetq): Handle lexical vars.
8035 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8036 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8037 (FletX, Flet): Obey lexical binding.
8038 (Fcommandp): Handle closures.
8039 (Feval): New `lexical' arg.
8040 (eval_sub): New function extracted from Feval. Use it almost
8041 everywhere where Feval was used. Look up vars in lexical env.
8042 Handle closures.
8043 (Ffunctionp): Move from subr.el.
8044 (Ffuncall): Handle closures.
8045 (apply_lambda): Remove `eval_flags'.
8046 (funcall_lambda): Handle closures and new byte-code-functions.
8047 (Fspecial_variable_p): New function.
8048 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8049 but without exporting it to Lisp.
8050
8051 * doc.c (Fdocumentation, store_function_docstring):
8052 * data.c (Finteractive_form): Handle closures.
8053
8054 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8055 interactive spec.
8056
8057 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8058 New byte-codes.
8059 (exec_byte_code): New function extracted from Fbyte_code to handle new
8060 calling convention for byte-code-functions. Add new byte-codes.
8061
8062 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8063
8064 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8065
8066 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8067
8068 * xdisp.c (redisplay_internal): Fix prototype.
8069
8070 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8071
8072 * xdisp.c (SCROLL_LIMIT): New macro.
8073 (try_scrolling): Use it when setting scroll_limit.
8074 Limit scrolling to 100 screen lines.
8075 (redisplay_window): Even when falling back on "recentering",
8076 position point in the window according to scroll-conservatively,
8077 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8078
8079 (try_scrolling): When point is above the window, allow searching
8080 as far as scroll_max, or one screenful, to compute vertical
8081 distance from PT to the scroll margin position. This prevents
8082 try_scrolling from unnecessarily failing when
8083 scroll-conservatively is set to a value slightly larger than the
8084 window height. Clean up the case of PT below the margin at bottom
8085 of window: scroll_max can no longer be INT_MAX. When aggressive
8086 scrolling is in use, don't let point enter the opposite scroll
8087 margin as result of the scroll.
8088 (syms_of_xdisp) <scroll-conservatively>: Document the
8089 threshold of 100 lines for never-recentering scrolling.
8090
8091 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8092
8093 * dispextern.h (move_it_by_lines):
8094 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8095 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8096 (message_log_check_duplicate): Remove parameters `prev_bol' and
8097 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8098 (redisplay_internal): Remove parameter `preserve_echo_area',
8099 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8100
8101 * indent.c (Fvertical_motion):
8102 * window.c (window_scroll_pixel_based, Frecenter):
8103 Don't pass `need_y_p' to `move_it_by_lines'.
8104
8105 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8106
8107 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8108 steal a few bits to be more compact.
8109 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8110 Remove unneeded casts.
8111
8112 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8113
8114 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8115
8116 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8117 binding" message (bug#7967).
8118
8119 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8120
8121 Fix more problems found by GCC 4.6.0's static checks.
8122
8123 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8124 Remove unused local var.
8125
8126 * editfns.c (Fmessage_box): Remove unused local var.
8127
8128 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8129 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8130 Omit unused local vars.
8131 * window.c (shrink_windows): Omit unused local var.
8132 * menu.c (digest_single_submenu): Omit unused local var.
8133 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8134 Omit unused local var.
8135
8136 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8137 Don't assume string length fits in int.
8138 (keyremap_step, read_key_sequence): Use size_t for sizes.
8139 (read_key_sequence): Don't check last_real_key_start redundantly.
8140
8141 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8142 instead of alloca (Bug#8344).
8143
8144 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8145 (Fbacktrace_frame): Don't assume nframes fits in int.
8146
8147 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8148
8149 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8150 concerns.
8151
8152 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8153
8154 * cm.c (calccost): Turn while-do into do-while, for clarity.
8155
8156 * keyboard.c (syms_of_keyboard): Use the same style as later
8157 in this function when indexing through an array. This also
8158 works around GCC bug 48267.
8159
8160 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8161
8162 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8163
8164 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8165 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8166
8167 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8168 This avoids undefined behavior on integer overflow, and is a bit
8169 more convenient anyway since it is compared to a size_t variable.
8170
8171 Variadic C functions now count arguments with size_t, not int.
8172 This avoids an unnecessary limitation on 64-bit machines, which
8173 caused (substring ...) to crash on large vectors (Bug#8344).
8174 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8175 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8176 All variadic functions and their callers changed accordingly.
8177 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8178 * data.c (arith_driver, float_arith_driver): Likewise.
8179 * editfns.c (general_insert_function): Likewise.
8180 * eval.c (struct backtrace.nargs, interactive_p)
8181 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8182 (funcall_lambda, mark_backtrace): Likewise.
8183 * fns.c (concat): Likewise.
8184 * frame.c (x_set_frame_parameters): Likewise.
8185 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8186 0 if not found, not -1. All callers changed.
8187
8188 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8189 (stack_copy_size): Now size_t, not int.
8190 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8191
8192 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8193
8194 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8195 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8196 All callers changed.
8197
8198 * lisp.h (multibyte_char_to_unibyte):
8199 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8200 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8201 * character.h (CHAR_TO_BYTE8):
8202 * cmds.c (internal_self_insert):
8203 * editfns.c (general_insert_function):
8204 * keymap.c (push_key_description):
8205 * search.c (Freplace_match):
8206 * xdisp.c (message_dolog, set_message_1): All callers changed.
8207
8208 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8209
8210 * keyboard.c (safe_run_hook_funcall): New function.
8211 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8212 don't set the hook to nil, but remove the offending function instead.
8213 (Qcommand_hook_internal): Remove, unused.
8214 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8215 Vcommand_hook_internal.
8216
8217 * eval.c (enum run_hooks_condition): Remove.
8218 (funcall_nil, funcall_not): New functions.
8219 (run_hook_with_args): Call each function through a `funcall' argument.
8220 Remove `cond' argument, now redundant.
8221 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8222 (Frun_hook_with_args_until_failure): Adjust accordingly.
8223 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8224
8225 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8226
8227 * dispextern.h (string_buffer_position): Remove declaration.
8228
8229 * print.c (strout): Remove parameter `multibyte', unused since
8230 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8231
8232 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8233 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8234 All callers changed.
8235
8236 * w32.c (_wsa_errlist): Use braces for struct initializers.
8237
8238 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8239 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8240 All callers changed.
8241 (string_buffer_position): Likewise. Also, make static (it's never
8242 used outside xdisp.c).
8243 (cursor_row_p): Remove parameter `w', unused since
8244 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8245 (decode_mode_spec): Remove parameter `precision', introduced during
8246 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8247 All callers changed.
8248
8249 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8250
8251 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8252
8253 2011-03-27 Anders Lindgren <andlind@gmail.com>
8254
8255 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8256 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8257 (ns_update_auto_hide_menu_bar): New functions.
8258 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8259 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8260 ns_constrain_all_frames.
8261 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8262 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8263
8264 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8265
8266 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8267
8268 2011-03-27 Glenn Morris <rgm@gnu.org>
8269
8270 * syssignal.h: Replace RETSIGTYPE with void.
8271 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8272 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8273 Replace SIGTYPE with void everywhere.
8274 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8275 * s/template.h (SIGTYPE): Remove commented out definition.
8276
8277 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8278
8279 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8280 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8281
8282 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8283
8284 * w32.c (read_unc_volume): Use parameter `henum', instead of
8285 global variable `wget_enum_handle'.
8286
8287 * keymap.c (describe_vector): Remove parameters `indices' and
8288 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8289 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8290
8291 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8292
8293 * keyboard.c (timer_check): Remove parameter `do_it_now',
8294 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8295 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8296 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8297
8298 * keyboard.c (read_char):
8299 * w32menu.c (w32_menu_display_help):
8300 * xmenu.c (show_help_event, menu_help_callback):
8301 Adjust calls to `show_help_echo'.
8302
8303 * gtkutil.c (xg_maybe_add_timer):
8304 * keyboard.c (readable_events):
8305 * process.c (wait_reading_process_output):
8306 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8307
8308 * insdel.c (adjust_markers_gap_motion):
8309 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8310 (gap_left, gap_right): Don't call it.
8311
8312 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8313
8314 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8315 incurred during fontification.
8316
8317 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8318
8319 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8320 (DEFVAR_PER_BUFFER): Don't pass it.
8321
8322 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8323 (scrolling_window): Don't pass it.
8324
8325 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8326
8327 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8328
8329 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8330 and `suffix'.
8331 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8332 of variables specific to SELinux and computation of `encoded_absname'.
8333
8334 * image.c (XPutPixel): Remove unused variable `height'.
8335
8336 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8337
8338 * unexw32.c (get_section_info): Remove unused variable `section'.
8339
8340 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8341 (system_process_attributes): Remove unused variable `sess'.
8342 (sys_read): Remove unused variable `err'.
8343
8344 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8345 (w32_wnd_proc): Remove unused variable `isdead'.
8346 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8347 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8348 (x_create_tip_frame): Remove unused variable `tem'.
8349
8350 * w32inevt.c (w32_console_read_socket):
8351 Remove unused variable `no_events'.
8352
8353 * w32term.c (x_draw_composite_glyph_string_foreground):
8354 Remove unused variable `width'.
8355
8356 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8357
8358 * w32term.c (x_set_glyph_string_clipping):
8359 Don't pass uninitialized region to CombineRgn.
8360
8361 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8362
8363 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8364 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8365 (Fx_close_connection): Remove unused variable `i'.
8366
8367 * w32font.c (w32font_draw): Return number of glyphs.
8368 (w32font_open_internal): Remove unused variable `i'.
8369 (w32font_driver): Add missing initializer.
8370
8371 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8372 (fill_in_menu): Remove unused variable `items_added'.
8373
8374 * w32term.c (last_mouse_press_frame): Remove static global variable.
8375 (w32_clip_to_row): Remove unused variable `f'.
8376 (x_delete_terminal): Remove unused variable `i'.
8377
8378 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8379 (NOTHING): Remove unused static global variable.
8380 (uniscribe_check_otf): Remove unused variable `table'.
8381 (uniscribe_font_driver): Add missing initializers.
8382
8383 2011-03-23 Julien Danjou <julien@danjou.info>
8384
8385 * term.c (Fsuspend_tty, Fresume_tty):
8386 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8387 * window.c (temp_output_buffer_show):
8388 * insdel.c (signal_before_change):
8389 * frame.c (Fhandle_switch_frame):
8390 * fileio.c (Fdo_auto_save):
8391 * emacs.c (Fkill_emacs):
8392 * editfns.c (save_excursion_restore):
8393 * cmds.c (internal_self_insert):
8394 * callint.c (Fcall_interactively):
8395 * buffer.c (Fkill_all_local_variables):
8396 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8397 Use Frun_hooks.
8398 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8399 unconditionally since it does the check itself.
8400
8401 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8402
8403 Fix more problems found by GCC 4.5.2's static checks.
8404
8405 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8406 the first time through the loop, since we know p0 < p1 then.
8407 This also avoids a gcc -Wstrict-overflow warning.
8408
8409 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8410 leading to a memory leak, possible in functions like
8411 load_charset_map_from_file that can allocate an unbounded number
8412 of objects (Bug#8318).
8413
8414 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8415 that could (at least in theory) be that large.
8416
8417 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8418 This is less likely to overflow, and avoids undefined behavior if
8419 overflow does occur. All callers changed. Use strtoul to scan
8420 for the unsigned long integer.
8421 (pint2hrstr): Simplify and tune code slightly.
8422 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8423
8424 * scroll.c (do_scrolling): Work around GCC bug 48228.
8425 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8426
8427 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8428 This also avoids a warning with gcc -Wstrict-overflow.
8429 (validate_x_resource_name): Simplify count usage.
8430 This also avoids a warning with gcc -Wstrict-overflow.
8431
8432 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8433 fail (Bug#8306).
8434
8435 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8436
8437 * process.c (Fmake_network_process): Use socklen_t, not int,
8438 where POSIX says socklen_t is required in portable programs.
8439 This fixes a porting bug on hosts like 64-bit HP-UX, where
8440 socklen_t is wider than int (Bug#8277).
8441 (Fmake_network_process, server_accept_connection):
8442 (wait_reading_process_output, read_process_output):
8443 Likewise.
8444
8445 * process.c: Rename or move locals to avoid shadowing.
8446 (list_processes_1, Fmake_network_process):
8447 (read_process_output_error_handler, exec_sentinel_error_handler):
8448 Rename or move locals.
8449 (Fmake_network_process): Define label "retry_connect" only if needed.
8450 (Fnetwork_interface_info): Fix pointer signedness.
8451 (process_send_signal): Add cast to avoid pointer signedness problem.
8452 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8453 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8454
8455 Make tparam.h and terminfo.c consistent.
8456 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8457 Include tparam.h instead, since it declares them.
8458 * cm.h (PC): Remove extern decl; tparam.h now does this.
8459 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8460 * terminfo.c: Include tparam.h, to check interfaces.
8461 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8462 (tparam): Adjust signature to match interface in tparam.h;
8463 this removes some undefined behavior. Check that outstring and len
8464 are zero, which they always are with Emacs.
8465 * tparam.h (PC, BC, UP): New extern decls.
8466
8467 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8468 (xftfont_open): Rename locals to avoid shadowing.
8469
8470 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8471 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8472 (OTF_TAG_SYM): Omit macro if not needed.
8473 (ftfont_list): Remove unused local.
8474 (get_adstyle_property, ftfont_pattern_entity):
8475 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8476 Rename locals to avoid shadowing.
8477
8478 * xfont.c (xfont_list_family): Mark var as initialized.
8479
8480 * xml.c (make_dom): Now static.
8481
8482 * composite.c (composition_compute_stop_pos): Rename local to
8483 avoid shadowing.
8484 (composition_reseat_it): Remove unused locals.
8485 (find_automatic_composition, composition_adjust_point): Likewise.
8486 (composition_update_it): Mark var as initialized.
8487 (find_automatic_composition): Mark vars as initialized,
8488 with a FIXME (Bug#8290).
8489
8490 character.h: Rename locals to avoid shadowing.
8491 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8492 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8493 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8494 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8495 to avoid shadowing.
8496
8497 * textprop.c (property_change_between_p): Remove; unused.
8498
8499 * intervals.c (interval_start_pos): Now static.
8500
8501 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8502
8503 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8504 Rename locals to avoid shadowing.
8505
8506 * sound.c (wav_play, au_play, Fplay_sound_internal):
8507 Fix pointer signedness.
8508 (alsa_choose_format): Remove unused local var.
8509 (wav_play): Initialize a variable to 0, to prevent undefined
8510 behavior (Bug#8278).
8511
8512 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8513
8514 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8515
8516 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8517 clobbering (Bug#8298).
8518 * sysdep.c (sys_subshell): Likewise.
8519 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8520
8521 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8522 This should get cleaned up, so that child_setup has the
8523 same signature on all platforms.
8524
8525 * callproc.c (call_process_cleanup): Now static.
8526 (relocate_fd): Rename locals to avoid shadowing.
8527
8528 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8529
8530 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8531 not to be necessary, and produces flickering.
8532
8533 2011-03-20 Glenn Morris <rgm@gnu.org>
8534
8535 * config.in: Remove file.
8536
8537 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8538
8539 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8540 are now in src/globals.h.
8541 (syms_of_minibuf): Remove spurious & from previous change.
8542
8543 2011-03-20 Leo Liu <sdl.web@gmail.com>
8544
8545 * minibuf.c (completing-read-function): New variable.
8546 (completing-read-default): Rename from completing-read.
8547 (completing-read): Call completing-read-function.
8548
8549 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8550
8551 * xfaces.c (Fx_load_color_file):
8552 Read color file from absolute filename (bug#8250).
8553
8554 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8555
8556 * makefile.w32-in: Update dependencies.
8557
8558 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8559
8560 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8561
8562 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8563
8564 Fix more problems found by GCC 4.5.2's static checks.
8565
8566 * process.c (make_serial_process_unwind, send_process_trap):
8567 (sigchld_handler): Now static.
8568
8569 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8570 That way, the code declares only the vars that it needs.
8571 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8572 * s/cygwin.h (PTY_ITERATION): Likewise.
8573 * s/darwin.h (PTY_ITERATION): Likewise.
8574 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8575
8576 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8577 * process.c (allocate_pty): Don't declare stb unless it's needed.
8578
8579 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8580 (CONSTANTLIM): Remove; unused.
8581 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8582 Define only if needed.
8583
8584 * unexelf.c (unexec): Name an expression,
8585 to avoid gcc -Wbad-function-cast warning.
8586 Use a different way to cause a compilation error if anyone uses
8587 n rather than nn, a way that does not involve shadowing.
8588 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8589
8590 * deps.mk (unexalpha.o): Remove; unused.
8591
8592 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8593 * unexec.h: New file.
8594 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8595 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8596 Depend on unexec.h.
8597 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8598 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8599 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8600 Change as necessary to match prototype in unexec.h.
8601
8602 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8603 shadowing.
8604 (back_comment, skip_chars): Mark vars as initialized.
8605
8606 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8607 Rename locals to avoid shadowing.
8608
8609 * lread.c (read1): Rewrite so as not to use empty "else".
8610 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8611
8612 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8613
8614 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8615 warning when compiling print.c.
8616
8617 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8618 instead of using an uninitialized var.
8619 (font_sort_entities): Mark var as initialized.
8620
8621 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8622
8623 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8624 pointers to constants.
8625 (font_parse_fcname): Remove unused vars.
8626 (font_delete_unmatched): Now static.
8627 (font_get_spec): Remove; unused.
8628 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8629 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8630 Rename or move locals to avoid shadowing.
8631
8632 * fns.c (require_nesting_list, require_unwind): Now static.
8633 (Ffillarray): Rename locals to avoid shadowing.
8634
8635 * floatfns.c (domain_error2): Define only if needed.
8636 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8637
8638 * alloc.c (mark_backtrace): Move decl from here ...
8639 * lisp.h: ... to here, so that it can be checked.
8640
8641 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8642 (Fdefvar): Rewrite so as not to use empty "else".
8643 (lisp_indirect_variable): Name an expression,
8644 to avoid gcc -Wbad-function-cast warning.
8645 (Fdefvar): Rename locals to avoid shadowing.
8646
8647 * callint.c (quotify_arg, quotify_args): Now static.
8648 (Fcall_interactively): Rename locals to avoid shadowing.
8649 Use const pointer when appropriate.
8650
8651 * lisp.h (get_system_name, get_operating_system_release):
8652 Move decls here, to check interfaces.
8653 * process.c (get_operating_system_release): Move decl to lisp.h.
8654 * xrdb.c (get_system_name): Likewise.
8655 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8656 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8657 some of which prompt warnings from gcc -Wbad-function-cast.
8658 (Fformat_time_string, Fencode_time, Finsert_char):
8659 (Ftranslate_region_internal, Fformat):
8660 Rename or remove local vars to avoid shadowing.
8661 (Ftranslate_region_internal): Mark var as initialized.
8662
8663 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8664 avoid shadowing.
8665
8666 * lisp.h (eassert): Check that the argument compiles, even if
8667 ENABLE_CHECKING is not defined.
8668
8669 * data.c (Findirect_variable): Name an expression, to avoid
8670 gcc -Wbad-function-cast warning.
8671 (default_value, arithcompare, arith_driver, arith_error): Now static.
8672 (store_symval_forwarding): Rename local to avoid shadowing.
8673 (Fmake_variable_buffer_local, Fmake_local_variable):
8674 Mark variables as initialized.
8675 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8676
8677 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8678 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8679 Rename locals to avoid shadowing.
8680 (mark_stack): Move local variables into the #ifdef region where
8681 they're used.
8682 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8683 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8684 needed otherwise.
8685 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8686 (GC_STRING_CHARS): Remove; not used.
8687 (Fmemory_limit): Cast sbrk's returned value to char *.
8688
8689 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8690 avoids undefined behavior in theory.
8691
8692 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8693
8694 Use functions, not macros, for up- and down-casing (Bug#8254).
8695 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8696 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8697 to use the following functions instead of these macros.
8698 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8699 EMACS_INT, since callers assume the returned value fits in int.
8700 (upcase1): Likewise, for UPCASE_TABLE.
8701 (uppercasep, lowercasep, upcase): New static inline functions.
8702 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8703 the race-condition problem in the old DOWNCASE.
8704
8705 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8706 Rename locals to avoid shadowing.
8707 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8708 (regex_compile, re_search_2, re_match_2_internal):
8709 Remove unused local vars.
8710 (FREE_VAR): Rewrite so as not to use empty "else",
8711 which gcc can warn about.
8712 (regex_compile, re_match_2_internal): Mark locals as initialized.
8713 (RETALLOC_IF): Define only if needed.
8714 (WORDCHAR_P): Likewise. This one is never needed, but is used
8715 only in a comment talking about a compiler bug, so put inside
8716 the #if 0 of that comment.
8717 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8718 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8719 Remove; unused.
8720
8721 * search.c (boyer_moore): Rename locals to avoid shadowing.
8722 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8723 (PREV_CHAR_BOUNDARY): Likewise.
8724
8725 * search.c (simple_search): Remove unused var.
8726
8727 * dired.c (compile_pattern): Move decl from here ...
8728 * lisp.h: ... to here, so that it can be checked.
8729 (struct re_registers): New forward decl.
8730
8731 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8732
8733 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8734 All uses changed.
8735 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8736 Rename locals to avoid shadowing.
8737 (Fvertical_motion): Mark locals as initialized.
8738
8739 * casefiddle.c (casify_object, casify_region): Now static.
8740 (casify_region): Mark local as initialized.
8741
8742 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8743
8744 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8745 New macros, so that the caller can use some names other than
8746 gcpro1, gcpro2, etc.
8747 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8748 of the new macros.
8749 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8750 argument, for consistency with GCPRO2_VAR, etc: it is now the
8751 prefix of the variable, not the variable itself. All uses
8752 changed.
8753 * dired.c (directory_files_internal, file_name_completion):
8754 Rename locals to avoid shadowing.
8755
8756 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8757 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8758 dired.c's scmp function, had undefined behavior.
8759 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8760 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8761 * buffer.h: ... to here, because these macros use current_buffer,
8762 and the new implementation with inline functions needs to have
8763 current_buffer in scope now, rather than later when the macros
8764 are used.
8765 (downcase, upcase1): New static inline functions.
8766 (DOWNCASE, UPCASE1): Reimplement using these functions.
8767 This avoids undefined behavior in expressions like
8768 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8769 from race conditions in accessing the global variables
8770 case_temp1 and case_temp2.
8771 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8772 * lisp.h (case_temp1, case_temp2): Remove their decls.
8773 * character.h (ASCII_CHAR_P): Move from here ...
8774 * lisp.h: ... to here, so that the inline functions mentioned
8775 above can use them.
8776
8777 * dired.c (directory_files_internal_unwind): Now static.
8778
8779 * fileio.c (file_name_as_directory, directory_file_name):
8780 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8781 Now static.
8782 (file_name_as_directory): Use const pointers when appropriate.
8783 (Fexpand_file_name): Likewise. In particular, newdir might
8784 point at constant storage, so make it a const pointer.
8785 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8786 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8787 signedness issues.
8788 (Fset_file_times, Finsert_file_contents, auto_save_error):
8789 Rename locals to avoid shadowing.
8790
8791 * minibuf.c (choose_minibuf_frame_1): Now static.
8792 (Ftry_completion, Fall_completions): Rename or remove locals
8793 to avoid shadowing.
8794
8795 * marker.c (bytepos_to_charpos): Remove; unused.
8796
8797 * lisp.h (verify_bytepos, count_markers): New decls,
8798 so that gcc does not warn that these functions aren't declared.
8799
8800 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8801 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8802 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8803 (copy_text): Remove unused local var.
8804
8805 * filelock.c (within_one_second): Now static.
8806 (lock_file_1): Rename local to avoid shadowing.
8807
8808 * buffer.c (fix_overlays_before): Mark locals as initialized.
8809 (fix_start_end_in_overlays): Likewise. This function should be
8810 simplified by using pointers-to-pointers, but that's a different
8811 matter.
8812 (switch_to_buffer_1): Now static.
8813 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8814 (report_overlay_modification): Rename locals to avoid shadowing.
8815
8816 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8817 Fix pointer signedness issue.
8818 (sys_subshell): Mark local as volatile if checking for lint,
8819 to suppress a gcc -Wclobbered warning that does not seem to be right.
8820 (MAXPATHLEN): Define only if needed.
8821
8822 * process.c (serial_open, serial_configure): Move decls from here ...
8823 * systty.h: ... to here, so that they can be checked.
8824
8825 * fns.c (get_random, seed_random): Move extern decls from here ...
8826 * lisp.h: ... to here, so that they can be checked.
8827
8828 * sysdep.c (reset_io): Now static.
8829 (wait_for_termination_signal): Remove; unused.
8830
8831 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8832 (copy_keymap_item, append_key, push_text_char_description):
8833 Now static.
8834 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8835 (DENSE_TABLE_SIZE): Remove; unused.
8836 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8837 (describe_map_tree):
8838 Rename locals to avoid shadowing.
8839
8840 * keyboard.c: Declare functions static if they are not used elsewhere.
8841 (echo_char, echo_dash, cmd_error, top_level_2):
8842 (poll_for_input, handle_async_input): Now static.
8843 (read_char, kbd_buffer_get_event, make_lispy_position):
8844 (make_lispy_event, make_lispy_movement, apply_modifiers):
8845 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8846 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8847 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8848 (read_key_sequence, read_char): Mark locals as initialized.
8849 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8850
8851 * keyboard.h (make_ctrl_char): New decl.
8852 (mark_kboards): Move decl here ...
8853 * alloc.c (mark_kboards): ... from here.
8854
8855 * lisp.h (force_auto_save_soon): New decl.
8856
8857 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8858 (DEFINE_DUMMY_FUNCTION): New macro.
8859 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8860 Use it.
8861 (main): Add casts to avoid warnings
8862 if GCC considers string literals to be constants.
8863
8864 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8865
8866 * dbusbind.c: Pointer signedness fixes.
8867 (xd_signature, xd_append_arg, xd_initialize):
8868 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8869 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8870 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8871 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8872
8873 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8874 if GCC considers string literals to be constants.
8875 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8876
8877 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8878
8879 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8880 (print_preprocess, print_object): New macro to fix last change.
8881
8882 * print.c (print_preprocess): Don't forget font objects.
8883
8884 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8885
8886 * emacs.c (USAGE3): Doc fixes.
8887
8888 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8889
8890 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8891 structure.
8892
8893 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8894
8895 * lisp.h (VWindow_system, Qfile_name_history):
8896 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8897 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8898 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8899
8900 * w32select.c: Don't #include "keyboard.h".
8901 (run_protected): Add extern declaration for waiting_for_input.
8902
8903 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8904 * w32console.c (detect_input_pending, read_input_pending)
8905 (encode_terminal_code):
8906 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8907 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8908 (w32_system_caret_y, Qfile_name_history):
8909 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8910 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8911 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8912 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8913 * w32proc.c (Qlocal, report_file_error):
8914 * w32term.c (Vwindow_system, updating_frame):
8915 * w32uniscribe.c (initialized, uniscribe_font_driver):
8916 Remove unneeded extern declarations.
8917
8918 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8919
8920 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8921
8922 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8923
8924 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8925 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8926 These macros can no longer be used for assignment.
8927
8928 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8929 Assign struct members directly, instead of using BUF_BEGV etc.
8930 (record_buffer_markers, fetch_buffer_markers): New functions for
8931 recording and fetching special buffer markers.
8932 (set_buffer_internal_1, set_buffer_temp): Use them.
8933
8934 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8935
8936 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8937
8938 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8939 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8940
8941 * xdisp.c (hscroll_window_tree):
8942 (reconsider_clip_changes): Use PT instead of BUF_PT.
8943
8944 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8945
8946 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8947 $(EMACS_ROOT)/lib/intprops.h.
8948
8949 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8950
8951 Fix more problems found by GCC 4.5.2's static checks.
8952
8953 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8954 to unsigned char * to avoid compiler diagnostic.
8955 (xg_free_frame_widgets): Make it clear that a local variable is
8956 needed only if USE_GTK_TOOLTIP.
8957 (gdk_window_get_screen): Make it clear that this macro is needed
8958 only if USE_GTK_TOOLTIP.
8959 (int_gtk_range_get_value): New function, which avoids a diagnostic
8960 from gcc -Wbad-function-cast.
8961 (xg_set_toolkit_scroll_bar_thumb): Use it.
8962 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8963 diagnostic from gcc -Wbad-function-cast.
8964 (get_utf8_string, xg_get_file_with_chooser):
8965 Rename locals to avoid shadowing.
8966 (create_dialog): Move locals to avoid shadowing.
8967
8968 * xgselect.c (xg_select): Remove unused var.
8969
8970 * image.c (four_corners_best): Mark locals as initialized.
8971 (gif_load): Initialize transparent_p to zero (Bug#8238).
8972 Mark another local as initialized.
8973 (my_png_error, my_error_exit): Mark with NO_RETURN.
8974
8975 * image.c (clear_image_cache): Now static.
8976 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8977 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8978 (x_edge_detection): Remove unnecessary cast that
8979 gcc -Wbad-function-cast diagnoses.
8980 (gif_load): Fix pointer signedness.
8981 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8982 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8983
8984 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8985
8986 Improve quality of tests for time stamp overflow.
8987 For example, without this patch (encode-time 0 0 0 1 1
8988 1152921504606846976) returns the obviously-bogus value (-948597
8989 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8990 reports time overflow. See
8991 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8992 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8993 * editfns.c: Include limits.h and intprops.h.
8994 (TIME_T_MIN, TIME_T_MAX): New macros.
8995 (time_overflow): Move earlier, to before first use.
8996 (hi_time, lo_time): New functions, for an accurate test for
8997 out-of-range times.
8998 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8999 (Fget_internal_run_time): Don't assume time_t fits in int.
9000 (make_time): Use list2 instead of Fcons twice.
9001 (Fdecode_time): More accurate test for out-of-range times.
9002 (check_tm_member): New function.
9003 (Fencode_time): Use it, to test for out-of-range times.
9004 (lisp_time_argument): Don't rely on undefined left-shift and
9005 right-shift behavior when checking for time stamp overflow.
9006
9007 * editfns.c (time_overflow): New function, refactoring common code.
9008 (Fformat_time_string, Fdecode_time, Fencode_time):
9009 (Fcurrent_time_string): Use it.
9010
9011 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9012 * dired.c (make_time): Move to ...
9013 * editfns.c (make_time): ... here.
9014 * systime.h: Note the move.
9015
9016 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9017
9018 * fringe.c (update_window_fringes): Remove unused variables.
9019
9020 * unexmacosx.c (copy_data_segment): Also copy __got section.
9021 (Bug#8223)
9022
9023 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9024
9025 * termcap.c [MSDOS]: Include "msdos.h".
9026 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9027 Constify `char *' arguments and their references according to
9028 prototypes in tparam.h.
9029
9030 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9031
9032 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9033 Adapt all references accordingly.
9034
9035 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9036
9037 2011-03-11 Tom Tromey <tromey@redhat.com>
9038
9039 * buffer.c (syms_of_buffer): Remove obsolete comment.
9040
9041 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9042
9043 * termhooks.h (encode_terminal_code): Declare prototype.
9044
9045 * msdos.c (encode_terminal_code): Don't declare prototype.
9046
9047 * term.c (encode_terminal_code): Now external again, used by
9048 w32console.c and msdos.c.
9049
9050 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9051 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9052
9053 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9054
9055 Fix some minor problems found by GCC 4.5.2's static checks.
9056
9057 * fringe.c (update_window_fringes): Mark locals as initialized
9058 (Bug#8227).
9059 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9060
9061 * alloc.c (mark_fringe_data): Move decl from here ...
9062 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9063 to check its interface.
9064 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9065
9066 * fontset.c (free_realized_fontset): Now static.
9067 (Fset_fontset_font): Rename local to avoid shadowing.
9068 (fontset_font): Mark local as initialized.
9069 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9070
9071 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9072
9073 * xselect.c (x_disown_buffer_selections): Remove; not used.
9074 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9075 (x_own_selection, Fx_disown_selection_internal): Rename locals
9076 to avoid shadowing.
9077 (x_handle_dnd_message): Remove local to avoid shadowing.
9078
9079 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9080 so that the caller can use some name other than gcpro1.
9081 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9082 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9083 (Fx_backspace_delete_keys_p):
9084 Use them to avoid shadowing, and rename vars to avoid shadowing.
9085 (x_decode_color, x_set_name, x_window): Now static.
9086 (Fx_create_frame): Add braces to silence GCC warning.
9087 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9088 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9089 Remove unused locals.
9090 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9091 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9092 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9093 macros.
9094
9095 * xterm.h (x_mouse_leave): New decl.
9096
9097 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9098 Remove unused functions.
9099 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9100 (x_calc_absolute_position): Now static.
9101 (XTread_socket): Don't define label "out" unless it's used.
9102 Don't declare local "event" unless it's used.
9103 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9104 unless they are used.
9105 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9106 (x_fatal_error_signal): Remove; not used.
9107 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9108 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9109 (x_error_catcher, x_connection_closed, x_error_handler):
9110 (x_error_quitter, xembed_send_message, x_iconify_frame):
9111 (my_log_handler): Rename locals to avoid shadowing.
9112 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9113 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9114
9115 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9116 Rename or move locals to avoid shadowing.
9117 (tty_defined_color, merge_face_heights): Now static.
9118 (free_realized_faces_for_fontset): Remove; not used.
9119 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9120 does not deduce is never used uninitialized.
9121 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9122 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9123
9124 * terminal.c (store_terminal_param): Now static.
9125
9126 * xmenu.c (menu_highlight_callback): Now static.
9127 (set_frame_menubar): Remove unused local.
9128 (xmenu_show): Rename parameter to avoid shadowing.
9129 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9130 since they might point to immutable storage.
9131 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9132 since it's unused otherwise.
9133
9134 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9135 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9136 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9137 avoids a gcc -Wuninitialized diagnostic.
9138 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9139 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9140 does not deduce are never used uninitialized.
9141
9142 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9143
9144 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9145 * window.c (window_loop, size_window):
9146 (run_window_configuration_change_hook, enlarge_window): Likewise.
9147
9148 * window.c (display_buffer): Now static.
9149 (size_window): Mark variables that gcc -Wuninitialized
9150 does not deduce are never used uninitialized.
9151 * window.h (check_all_windows): New decl, to forestall
9152 gcc -Wmissing-prototypes diagnostic.
9153 * dispextern.h (bidi_dump_cached_states): Likewise.
9154
9155 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9156 shadowing.
9157 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9158 Include <limits.h>.
9159 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9160 and to avoid gcc -Wuninitialized warning.
9161 (load_charset_map): Mark variables that gcc -Wuninitialized
9162 does not deduce are never used uninitialized.
9163 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9164
9165 * coding.c (coding_set_source, coding_set_destination):
9166 Use "else { /* comment */ }" rather than "else /* comment */;"
9167 for clarity, and to avoid gcc -Wempty-body warning.
9168 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9169 a block, when the outer 'i' will do.
9170 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9171 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9172 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9173 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9174 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9175 Rename locals to avoid shadowing.
9176 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9177 * coding.c (emacs_mule_char, encode_invocation_designation):
9178 Now static, since they're not used elsewhere.
9179 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9180 (decode_coding_object, encode_coding_object, detect_coding_system):
9181 (decode_coding_emacs_mule): Mark variables that gcc
9182 -Wuninitialized does not deduce are never used uninitialized.
9183 (detect_coding_iso_2022): Initialize a local variable that might
9184 be used uninitialized. Leave a FIXME because it's not clear that
9185 this initialization is needed. (Bug#8211)
9186 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9187 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9188 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9189 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9190 Remove unused macros.
9191
9192 * category.c (hash_get_category_set): Remove unused local var.
9193 (copy_category_table): Now static, since it's not used elsewhere.
9194 * character.c (string_count_byte8): Likewise.
9195
9196 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9197 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9198
9199 * chartab.c (copy_sub_char_table): Now static, since it's not used
9200 elsewhere.
9201 (sub_char_table_ref_and_range, char_table_ref_and_range):
9202 Rename locals to avoid shadowing.
9203 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9204
9205 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9206 (BIDI_BOB): Remove unused macro.
9207
9208 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9209 deduce are never used uninitialized.
9210 * term.c (encode_terminal_code): Likewise.
9211
9212 * term.c (encode_terminal_code): Now static. Remove unused local.
9213
9214 * tparam.h: New file.
9215 * term.c, tparam.h: Include it.
9216 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9217 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9218 Move these decls to tparam.h, and make them agree with what
9219 is actually in tparam.c. The previous trick of using incompatible
9220 decls in different modules does not conform to the C standard.
9221 All callers of tparam changed to use tparam's actual API.
9222 * tparam.c (tparam1, tparam, tgoto):
9223 Use const pointers where appropriate.
9224
9225 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9226 * cm.h (struct cm): Likewise.
9227 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9228 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9229 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9230 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9231 (turn_on_face, init_tty): Likewise.
9232 * termchar.h (struct tty_display_info): Likewise.
9233
9234 * term.c (term_mouse_position): Rename local to avoid shadowing.
9235
9236 * alloc.c (mark_ttys): Move decl from here ...
9237 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9238
9239 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9240
9241 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9242
9243 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9244
9245 * search.c (compile_pattern_1): Remove argument regp, unused since
9246 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9247 (compile_pattern): Don't pass it.
9248
9249 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9250
9251 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9252 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9253 for ! HAVE_GTK3.
9254 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9255
9256 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9257
9258 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9259 gdk_window_get_screen, gdk_window_get_geometry,
9260 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9261 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9262 (xg_get_pixbuf_from_pixmap): New function.
9263 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9264 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9265 Call xg_get_pixbuf_from_pixmap instead of
9266 gdk_pixbuf_get_from_drawable.
9267 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9268 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9269 (xg_check_special_colors): Use GtkStyleContext and its functions
9270 for HAVE_GTK3.
9271 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9272 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9273 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9274 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9275 Call gtk_widget_get_preferred_size.
9276 (xg_frame_resized): gdk_window_get_geometry only takes 5
9277 parameters.
9278 (xg_win_to_widget, xg_event_is_for_menubar):
9279 Call gdk_x11_window_lookup_for_display.
9280 (xg_set_widget_bg): New function.
9281 (delete_cb): New function.
9282 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9283 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9284 (xg_set_background_color): Call xg_set_widget_bg.
9285 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9286 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9287 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9288 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9289 if ! HAVE_GTK3.
9290 (update_frame_tool_bar): Call gtk_widget_hide.
9291 (xg_initialize): Use GDK_KEY_g.
9292
9293 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9294 if ! HAVE_GTK3
9295 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9296
9297 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9298 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9299 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9300
9301 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9302
9303 * w32xfns.c (select_palette): Check success of RealizePalette against
9304 GDI_ERROR, not zero.
9305
9306 See ChangeLog.11 for earlier changes.
9307
9308 ;; Local Variables:
9309 ;; coding: utf-8
9310 ;; End:
9311
9312 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9313
9314 This file is part of GNU Emacs.
9315
9316 GNU Emacs is free software: you can redistribute it and/or modify
9317 it under the terms of the GNU General Public License as published by
9318 the Free Software Foundation, either version 3 of the License, or
9319 (at your option) any later version.
9320
9321 GNU Emacs is distributed in the hope that it will be useful,
9322 but WITHOUT ANY WARRANTY; without even the implied warranty of
9323 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9324 GNU General Public License for more details.
9325
9326 You should have received a copy of the GNU General Public License
9327 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.