Minor fixes for signed vs unsigned integers.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2
3 Minor fixes for signed vs unsigned integers.
4 * character.h (MAYBE_UNIFY_CHAR):
5 * charset.c (maybe_unify_char):
6 * keyboard.c (read_char, reorder_modifiers):
7 XINT -> XFASTINT, since the integer must be nonnegative.
8 * ftfont.c (ftfont_spec_pattern):
9 * keymap.c (access_keymap, silly_event_symbol_error):
10 XUINT -> XFASTINT, since the integer must be nonnegative.
11 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
12 since it makes no difference and we prefer signed.
13 * keyboard.c (record_char): Use XUINT when all the neighbors do.
14 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
15 nonnegative.
16
17 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
18
19 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
20 Do not assume that spare memory exists; that assumption is valid
21 only if SYSTEM_MALLOC.
22 (LARGE_REQUEST): New macro, so that the issue of large requests
23 is separated from the issue of spare memory.
24
25 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
26
27 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
28 format. (Bug#8806)
29
30 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
31
32 * xfns.c (x_set_scroll_bar_default_width): Move declarations
33 before statements.
34
35 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
36
37 * gtkutil.c (xg_get_default_scrollbar_width): New function.
38
39 * gtkutil.h: Declare xg_get_default_scrollbar_width.
40
41 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
42 min width by calling x_set_scroll_bar_default_width (Bug#8505).
43
44 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
45
46 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
47
48 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
49
50 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
51 (x_clipboard_manager_save): Add return value.
52 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
53 error handlers.
54 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
55 Obey Vx_select_enable_clipboard_manager. Catch errors in
56 x_clipboard_manager_save (Bug#8779).
57 (Vx_select_enable_clipboard_manager): New variable.
58 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
59
60 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
61
62 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
63
64 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
65
66 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
67 in the current matrix if keep_current_p is non-zero.
68
69 2011-06-04 Eli Zaretskii <eliz@gnu.org>
70
71 * bidi.c (bidi_level_of_next_char): Fix last change.
72
73 2011-06-03 Eli Zaretskii <eliz@gnu.org>
74
75 Support bidi reordering of text covered by display properties.
76
77 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
78 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
79 (bidi_cache_search, bidi_cache_iterator_state)
80 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
81 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
82 character positions inside a run of characters covered by a
83 display string.
84 (bidi_paragraph_init, bidi_resolve_explicit_1)
85 (bidi_level_of_next_char): Call bidi_fetch_char and
86 bidi_fetch_char_advance instead of FETCH_CHAR and
87 FETCH_CHAR_ADVANCE.
88 (bidi_init_it): Initialize new members.
89 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
90 definitions.
91 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
92 instead of using explicit *_CHAR codes.
93 (bidi_resolve_explicit, bidi_resolve_weak): Use
94 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
95 bidirectional text is supported only in multibyte buffers.
96 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
97 it to initialize the frame_window_p member of struct bidi_it.
98 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
99 (bidi_resolve_explicit, bidi_resolve_weak)
100 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
101 bidi_it->nchars is non-positive.
102 (bidi_level_of_next_char): Don't try to lookup the cache for the
103 next/previous character if nothing is cached there yet, or if we
104 were just reseat()'ed to a new position.
105
106 * xdisp.c (set_cursor_from_row): Set start and stop points
107 according to the row's direction when priming the loop that looks
108 for the glyph on which to display cursor.
109 (single_display_spec_intangible_p): Function deleted.
110 (display_prop_intangible_p): Reimplement to call
111 handle_display_spec instead of single_display_spec_intangible_p.
112 Accept 3 additional arguments needed by handle_display_spec. This
113 fixes incorrect cursor motion across display property with complex
114 values: lists, `(when COND...)' forms, etc.
115 (single_display_spec_string_p): Support property values that are
116 lists with the argument STRING its top-level element.
117 (display_prop_string_p): Fix the condition for processing a
118 property that is a list to be consistent with handle_display_spec.
119 (handle_display_spec): New function, refactored from the
120 last portion of handle_display_prop.
121 (compute_display_string_pos): Accept additional argument
122 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
123 value of a `display' property is a "replacing spec".
124 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
125 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
126 the display property, but just return a value indicating whether
127 the display property will replace the characters it covers.
128 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
129 frame_window_p members of struct bidi_it.
130 (compute_display_string_pos, compute_display_string_end): New
131 functions.
132 (push_it): Accept second argument POSITION, where pop_it should
133 jump to continue iteration.
134 (reseat_1): Initialize bidi_it.disp_pos.
135
136 * keyboard.c (adjust_point_for_property): Adjust the call to
137 display_prop_intangible_p to its new signature.
138
139 * dispextern.h (struct bidi_it): New member frame_window_p.
140 (bidi_init_it): Update prototypes.
141 (display_prop_intangible_p): Update prototype.
142 (compute_display_string_pos, compute_display_string_end): Declare
143 prototypes.
144 (struct bidi_it): New members nchars and disp_pos. ch_len is now
145 EMACS_INT.
146
147 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
148
149 Malloc failure behavior now depends on size of allocation.
150 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
151 * lisp.h: Change signatures accordingly.
152 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
153 All callers changed. (Bug#8762)
154
155 * gnutls.c: Use Emacs's memory allocators.
156 Without this change, the gnutls library would invoke malloc etc.
157 directly, which causes problems on non-SYNC_INPUT hosts, and which
158 runs afoul of improving memory_full behavior. (Bug#8761)
159 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
160 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
161 xfree instead of the default malloc, realloc, free.
162 (Fgnutls_boot): No need to check for memory allocation failure,
163 since xmalloc does that for us.
164
165 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
166 * category.c (hash_get_category_set):
167 * ccl.c (ccl_driver):
168 * charset.c (Fdefine_charset_internal):
169 * charset.h (struct charset.hash_index):
170 * composite.c (get_composition_id, gstring_lookup_cache)
171 (composition_gstring_put_cache):
172 * composite.h (struct composition.hash_index):
173 * dispextern.h (struct image.hash):
174 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
175 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
176 (hashfn_equal, hashfn_user_defined, make_hash_table)
177 (maybe_resize_hash_table, hash_lookup, hash_put)
178 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
179 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
180 (Fsxhash, Fgethash, Fputhash, Fmaphash):
181 * image.c (make_image, search_image_cache, lookup_image)
182 (xpm_put_color_table_h):
183 * lisp.h (struct Lisp_Hash_Table):
184 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
185 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
186 for hashes and hash indexes, instead of 'unsigned' and 'int'.
187 * alloc.c (allocate_vectorlike):
188 Check for overflow in vector size calculations.
189 * ccl.c (ccl_driver):
190 Check for overflow when converting EMACS_INT to int.
191 * fns.c, image.c: Remove unnecessary static decls that would otherwise
192 need to be updated by these changes.
193 * fns.c (make_hash_table, maybe_resize_hash_table):
194 Check for integer overflow with large hash tables.
195 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
196 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
197 (SXHASH_REDUCE): New macro.
198 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
199 Use it instead of discarding useful hash info with large hash values.
200 (sxhash_float): New function.
201 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
202 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
203 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
204 Rewrite to use FIXNUM_BITS, as this simplifies things.
205 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
206 Adjust signatures to match updated version of code.
207 (consing_since_gc): Now EMACS_INT, since a single hash table can
208 use more than INT_MAX bytes.
209
210 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
211
212 Make it possible to build with GCC-4.6+ -O2 -flto.
213
214 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
215
216 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
217
218 * minibuf.c (get_minibuffer, read_minibuf_unwind):
219 Call minibuffer-inactive-mode.
220
221 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
222
223 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
224 Update dependencies.
225
226 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
227
228 * data.c (init_data): Remove code for UTS, this system is not
229 supported anymore.
230
231 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
232
233 Don't force ./temacs to start in terminal mode.
234
235 * frame.c (make_initial_frame): Initialize faces in all cases, not
236 only when CANNOT_DUMP is defined.
237 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
238
239 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
240
241 * dispnew.c (add_window_display_history): Use const for the string
242 pointer. Remove declaration, not needed.
243
244 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
245
246 Use 'inline', not 'INLINE'.
247 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
248 * alloc.c, fontset.c (INLINE): Remove.
249 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
250 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
251 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
252 * gmalloc.c (register_heapinfo): Use inline unconditionally.
253 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
254
255 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
256
257 Make it possible to run ./temacs.
258
259 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
260 syms_of_callproc does the same thing. Remove test for
261 "initialized", do it in the caller.
262 * emacs.c (main): Avoid calling set_initial_environment when dumping.
263
264 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
265
266 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
267 (read_minibuf): Use get_minibuffer.
268 (syms_of_minibuf): Use DEFSYM.
269 (Qmetadata): New var.
270 * data.c (Qbuffer): Don't make it static.
271 (syms_of_data): Use DEFSYM.
272
273 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
274
275 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
276 (CCL_CODE_MIN): New macro.
277
278 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
279
280 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
281
282 * eval.c (Qdebug): Now static.
283 * lisp.h (Qdebug): Remove decl. This reverts a part of the
284 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
285 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
286
287 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
288
289 * image.c: Various fixes to ImageMagick code comments.
290 (Fimagemagick_types): Doc fix.
291
292 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
293
294 Minor fixes prompted by GCC 4.6.0 warnings.
295
296 * xselect.c (converted_selections, conversion_fail_tag): Now static.
297
298 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
299 (x_clipboard_manager_save_all): Move extern decl to ...
300 * xterm.h: ... here, so that it can be checked for consistency.
301
302 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
303
304 * xselect.c (x_clipboard_manager_save_frame)
305 (x_clipboard_manager_save_all): New functions.
306 (Fx_clipboard_manager_save): Lisp function deleted.
307
308 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
309 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
310
311 * xterm.h: Update prototype.
312
313 2011-05-28 William Xu <william.xwl@gmail.com>
314
315 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
316 exiting (Bug#8239).
317
318 2011-05-28 Jim Meyering <meyering@redhat.com>
319
320 Avoid a sign-extension bug in crypto_hash_function.
321 * fns.c (to_uchar): Define.
322 (crypto_hash_function): Use it to convert some newly-signed
323 variables to unsigned, to avoid sign-extension bugs. For example,
324 without this change, (md5 "truc") would evaluate to
325 45723a2aff78ff4fff7fff1114760e62 rather than the expected
326 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
327 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
328
329 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
330
331 Integer overflow fixes.
332
333 * dbusbind.c: Serial number integer overflow fixes.
334 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
335 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
336 to hold a serial number that is too large for a fixnum.
337 (Fdbus_method_return_internal, Fdbus_method_error_internal):
338 Check for serial numbers out of range. Decode any serial number
339 that was so large that it became a float. (Bug#8722)
340
341 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
342 (Fdbus_call_method, Fdbus_call_method_asynchronously):
343 Use XFASTINT rather than XUINT when numbers are nonnegative.
344 (xd_append_arg, Fdbus_method_return_internal):
345 (Fdbus_method_error_internal): Likewise. Also, for unsigned
346 arguments, check that Lisp number is nonnegative, rather than
347 silently wrapping negative numbers around. (Bug#8722)
348 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
349 (Bug#8722)
350
351 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
352
353 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
354
355 ccl: add integer overflow checks
356 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
357 (IN_INT_RANGE): New macros.
358 (ccl_driver): Use them to check for integer overflow when
359 decoding a CCL program. Many of the new checks are whether XINT (x)
360 fits in int; it doesn't always, on 64-bit hosts. The new version
361 doesn't catch all possible integer overflows, but it's an
362 improvement. (Bug#8719)
363
364 * alloc.c (make_event_array): Use XINT, not XUINT.
365 There's no need for unsigned here.
366
367 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
368 This follows up to the 2011-05-06 change that substituted uintptr_t
369 for EMACS_INT. This case wasn't caught back then.
370
371 Rework Fformat to avoid integer overflow issues.
372 * editfns.c: Include <float.h> unconditionally, as it's everywhere
373 now (part of C89). Include <verify.h>.
374 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
375 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
376 (Fformat): Avoid the prepass trying to compute sizes; it was only
377 approximate and thus did not catch overflow reliably. Instead, walk
378 through the format just once, formatting and computing sizes as we go,
379 checking for integer overflow at every step, and allocating a larger
380 buffer as needed. Keep track separately whether the format is
381 multibyte. Keep only the most-recently calculated precision, rather
382 than them all. Record whether each argument has been converted to
383 string. Use EMACS_INT, not int, for byte and char and arg counts.
384 Support field widths and precisions larger than INT_MAX. Avoid
385 sprintf's undefined behavior with conversion specifications such as %#d
386 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
387 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
388 formatting out-of-range floating point numbers with int
389 formats. (Bug#8668)
390
391 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
392
393 * data.c: Avoid integer truncation in expressions involving floats.
394 * data.c: Include <intprops.h>.
395 (arith_driver): When there's an integer overflow in an expression
396 involving floating point, convert the integers to floating point
397 so that the resulting value does not suffer from catastrophic
398 integer truncation. For example, on a 64-bit host (* 4
399 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
400 Do not rely on undefined behavior after integer overflow.
401
402 merge count_size_as_multibyte, parse_str_to_multibyte
403 * character.c, character.h (count_size_as_multibyte):
404 Rename from parse_str_to_multibyte; all uses changed.
405 Check for integer overflow.
406 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
407 since it's now a duplicate of the other. This is more of
408 a character than a buffer op, so better that it's in character.c.
409 * fns.c, print.c: Adjust to above changes.
410
411 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
412
413 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
414
415 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
416
417 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
418 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
419 (x_clipboard_manager_save): Now static.
420 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
421
422 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
423 (crypto_hash_function): Now static.
424 Fix pointer signedness problems. Avoid unnecessary initializations.
425
426 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
427
428 * termhooks.h (Vselection_alist): Make it terminal-local.
429
430 * terminal.c (create_terminal): Initialize it.
431
432 * xselect.c: Support for clipboard managers.
433 (Vselection_alist): Move to termhooks.h as terminal-local var.
434 (LOCAL_SELECTION): New macro.
435 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
436 (symbol_to_x_atom): Remove gratuitous arg.
437 (x_handle_selection_request, lisp_data_to_selection_data)
438 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
439 (x_own_selection, x_get_local_selection, x_convert_selection):
440 New arg, specifying work frame. Use terminal-local Vselection_alist.
441 (some_frame_on_display): Delete unused function.
442 (Fx_own_selection_internal, Fx_get_selection_internal)
443 (Fx_disown_selection_internal, Fx_selection_owner_p)
444 (Fx_selection_exists_p): New optional frame arg.
445 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
446 (x_handle_selection_clear): Don't treat other terminals with the
447 same keyboard specially. Use the terminal-local Vselection_alist.
448 (x_clear_frame_selections): Use Frun_hook_with_args.
449
450 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
451
452 * xterm.h: Add support for those atoms.
453
454 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
455
456 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
457 (converted_selections, conversion_fail_tag): New global variables.
458 (x_selection_request_lisp_error): Free the above.
459 (x_get_local_selection): Remove unnecessary code.
460 (x_reply_selection_request): Args changed; handle arbitrary array
461 of converted selections stored in converted_selections.
462 Separate the XChangeProperty and SelectionNotify steps.
463 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
464 (x_convert_selection): New function.
465 (x_handle_selection_event): Simplify.
466 (x_get_foreign_selection): Don't ignore incoming requests while
467 waiting for an answer; this will fail when we implement
468 SAVE_TARGETS, and seems unnecessary anyway.
469 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
470 (Vx_sent_selection_functions): Doc fix.
471
472 2011-05-26 Leo Liu <sdl.web@gmail.com>
473
474 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
475
476 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
477
478 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
479
480 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
481 for fringe update if it has periodic bitmap.
482 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
483 and fringe_bitmap_periodic_p.
484
485 * fringe.c (get_fringe_bitmap_data): New function.
486 (draw_fringe_bitmap_1, update_window_fringes): Use it.
487 (update_window_fringes): Record periodicity of fringe bitmap in glyph
488 row. Mark glyph row for fringe update if periodicity changed.
489
490 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
491 for fringe update unless it has periodic bitmap.
492
493 2011-05-25 Kenichi Handa <handa@m17n.org>
494
495 * xdisp.c (get_next_display_element): Set correct it->face_id for
496 a static composition.
497
498 2011-05-24 Leo Liu <sdl.web@gmail.com>
499
500 * deps.mk (fns.o):
501 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
502
503 * fns.c (crypto_hash_function, Fsha1): New function.
504 (Fmd5): Use crypto_hash_function.
505 (syms_of_fns): Add Ssha1.
506
507 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
508
509 * gnutls.c: Remove unused macros.
510 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
511 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
512 Remove macros that are defined and never used.
513 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
514
515 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
516
517 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
518 (Fx_get_selection_internal): Minor cleanup.
519 (Fx_own_selection_internal): Rename arguments for consistency with
520 select.el.
521
522 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
523
524 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
525
526 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
527
528 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
529
530 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
531
532 * dispnew.c (scrolling_window): Don't exclude the case that the
533 last enabled row in the desired matrix touches the bottom boundary.
534
535 2011-05-21 Glenn Morris <rgm@gnu.org>
536
537 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
538 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
539 and add some more files.
540
541 2011-05-20 Eli Zaretskii <eliz@gnu.org>
542
543 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
544 report_file_error introduced by the change from 2011-05-07.
545
546 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
547
548 * systime.h (Time): Define only if emacs is defined.
549 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
550 where the include path doesn't have X11/X.h by default. See
551 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
552
553 2011-05-20 Kenichi Handa <handa@m17n.org>
554
555 * composite.c (find_automatic_composition): Fix previous change.
556
557 2011-05-20 Glenn Morris <rgm@gnu.org>
558
559 * lisp.mk: New file, split from Makefile.in.
560 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
561 (shortlisp): Remove.
562 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
563
564 2011-05-19 Glenn Morris <rgm@gnu.org>
565
566 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
567 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
568 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
569 (lisp): Set the order to that of loadup.el.
570 (shortlisp): Make it a copy of $lisp.
571 (SOME_MACHINE_LISP): Remove.
572 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
573 Use just $shortlisp, not $SOME_MACHINE_LISP too.
574
575 2011-05-18 Kenichi Handa <handa@m17n.org>
576
577 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
578 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
579 (find_automatic_composition): Mostly rewrite for efficiency.
580
581 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
582
583 * makefile.w32-in: Update dependencies.
584
585 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
586
587 * menu.c: Include limits.h (fixes the MS-Windows build broken by
588 revision 104625).
589
590 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
591
592 Fix some integer overflow issues, such as string length overflow.
593
594 * insdel.c (count_size_as_multibyte): Check for string overflow.
595
596 * character.c (lisp_string_width): Check for string overflow.
597 Use EMACS_INT, not int, for string indexes and lengths; in
598 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
599 the resulting string length overflows an EMACS_INT; instead,
600 report a string overflow if no precision given. When checking for
601 precision exhaustion, use a check that cannot possibly have
602 integer overflow. (Bug#8675)
603 * character.h (lisp_string_width): Adjust to new signature.
604
605 * alloc.c (string_overflow): New function.
606 (Fmake_string): Use it. This doesn't change behavior, but saves
607 a few bytes and will simplify future changes.
608 * character.c (string_escape_byte8): Likewise.
609 * lisp.h (string_overflow): New decl.
610
611 Fixups, following up to the user-interface timestamp change.
612 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
613 for UI timestamps, instead of unsigned long.
614 * msdos.c (mouse_get_pos): Likewise.
615 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
616 * w32gui.h (Time): Define by including "systime.h" rather than by
617 declaring it ourselves. (Bug#8664)
618
619 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
620 * image.c (clear_image_cache): Likewise.
621
622 * term.c (term_mouse_position): Don't assume time_t wraparound.
623
624 Be more systematic about user-interface timestamps.
625 Before, the code sometimes used 'Time', sometimes 'unsigned long',
626 and sometimes 'EMACS_UINT', to represent these timestamps.
627 This change causes it to use 'Time' uniformly, as that's what X uses.
628 This makes the code easier to follow, and makes it easier to catch
629 integer overflow bugs such as Bug#8664.
630 * frame.c (Fmouse_position, Fmouse_pixel_position):
631 Use Time, not unsigned long, for user-interface timestamps.
632 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
633 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
634 * keyboard.h (last_event_timestamp): Likewise.
635 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
636 * menu.h (xmenu_show): Likewise.
637 * term.c (term_mouse_position): Likewise.
638 * termhooks.h (struct input_event.timestamp): Likewise.
639 (struct terminal.mouse_position_hook): Likewise.
640 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
641 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
642 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
643 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
644 what it was before.
645 * menu.h, termhooks.h: Include "systime.h", for Time.
646
647 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
648 Don't assume that the difference between two unsigned long values
649 can fit into an integer. At this point, we know button_down_time
650 <= event->timestamp, so the difference must be nonnegative, so
651 there's no need to cast the result if double-click-time is
652 nonnegative, as it should be; check that it's nonnegative, just in
653 case. This bug is triggered when events are more than 2**31 ms
654 apart (about 25 days). (Bug#8664)
655
656 * xselect.c (last_event_timestamp): Remove duplicate decl.
657 (x_own_selection): Remove needless cast to unsigned long.
658
659 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
660 that always fit in int. Use a sentinel instead of a counter, to
661 avoid a temp and to allay GCC's concerns about possible int overflow.
662 * frame.h (struct frame): Use int for menu_bar_items_used
663 instead of EMACS_INT, since it always fits in int.
664
665 * menu.c (grow_menu_items): Check for int overflow.
666
667 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
668
669 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
670 Before, the code was not consistent. These values cannot exceed
671 2**31 - 1 so there's no need to make them unsigned.
672 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
673 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
674 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
675 as modifiers.
676 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
677
678 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
679 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
680 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
681 presumably because the widths might not match.
682
683 * window.c (size_window): Avoid needless test at loop start.
684
685 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
686
687 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
688
689 2011-05-12 Drew Adams <drew.adams@oracle.com>
690
691 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
692
693 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
694
695 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
696 `width' to `bar_area_x' and `bar_area_width', respectively.
697 (x_scroll_run): Take account of fringe background extension.
698
699 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
700 Rename local vars `left' and `width' to `bar_area_x' and
701 `bar_area_width', respectively.
702 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
703 background extension.
704
705 2011-05-10 Jim Meyering <meyering@redhat.com>
706
707 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
708
709 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
710
711 * image.c (Finit_image_library): Return t for built-in image types,
712 like pbm and xbm. (Bug#8640)
713
714 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
715
716 * w32menu.c (set_frame_menubar): Fix submenu allocation.
717
718 2011-05-07 Eli Zaretskii <eliz@gnu.org>
719
720 * w32console.c (Fset_screen_color): Doc fix.
721 (Fget_screen_color): New function.
722 (syms_of_ntterm): Defsubr it.
723
724 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
725 unlink the temporary file if Fcall_process didn't create it in the
726 first place.
727 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
728 child process will be redirected to a file specified with `:file'.
729 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
730 cue to call_process_cleanup not to close that handle.
731
732 2011-05-07 Ben Key <bkey76@gmail.com>
733
734 * makefile.w32-in: The bootstrap-temacs rule now makes use of
735 one of two shell specific rules, either bootstrap-temacs-CMD or
736 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
737 to the previous implementation of the bootstrap-temacs rule.
738 The bootstrap-temacs-CMD rule is similar to the previous
739 implementation of the bootstrap-temacs rule except that it
740 makes use of the ESC_CFLAGS variable instead of the CFLAGS
741 variable.
742
743 These changes, along with some changes to nt/configure.bat,
744 nt/gmake.defs, and nt/nmake.defs, are required to extend my
745 earlier fix to add support for --cflags and --ldflags options
746 that include quotes so that it works whether make uses cmd or
747 sh as the shell.
748
749 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
750
751 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
752 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
753 is a constant.
754 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
755 a string. Handle both cases.
756 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
757 (Fdbus_register_method): Use Qinvalid_function.
758
759 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
760
761 * makefile.w32-in: Update dependencies.
762 (LISP_H): Add inttypes.h and stdin.h.
763 (PROCESS_H): Add unistd.h.
764
765 2011-05-06 Eli Zaretskii <eliz@gnu.org>
766
767 * lread.c: Include limits.h (fixes the MS-Windows build broken by
768 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
769
770 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
771
772 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
773
774 * term.c (vfatal): Remove stray call to va_end.
775 It's not needed and the C Standard doesn't allow it here anyway.
776
777 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
778 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
779
780 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
781 bytes.
782
783 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
784
785 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
786
787 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
788
789 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
790
791 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
792
793 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
794 * charset.c (Fdefine_charset_internal): Don't initialize
795 charset.code_space[15]. The value was garbage, on hosts with
796 32-bit int (Bug#8600).
797
798 * lread.c (read_integer): Be more consistent with string-to-number.
799 Use string_to_number to do the actual conversion; this avoids
800 rounding errors and fixes some other screwups. Without this fix,
801 for example, #x1fffffffffffffff was misread as -2305843009213693952.
802 (digit_to_number): Move earlier, for benefit of read_integer.
803 Return -1 if the digit is out of range for the base, -2 if it is
804 not a digit in any supported base. (Bug#8602)
805
806 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
807
808 * dispnew.c (scrolling_window): Return 1 if we scrolled,
809 to match comment at start of function. This also removes a
810 GCC warning about overflow in a 32+64-bit port.
811
812 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
813
814 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
815 Reported by Stefan Monnier in
816 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
817 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
818 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
819
820 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
821 (EMACS_UINTPTR): Likewise, with uintptr_t.
822
823 * lisp.h: Prefer 64-bit EMACS_INT if available.
824 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
825 on 32-bit hosts that have 64-bit int, so that they can access
826 large files.
827 However, temporarily disable this change unless the temporary
828 symbol WIDE_EMACS_INT is defined.
829
830 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
831
832 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
833 This removes an assumption that EMACS_INT and long are the same
834 width as pointers. The assumption is true for Emacs porting targets
835 now, but we want to make other targets possible.
836 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
837 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
838 In the rest of the code, change types of integers that hold casted
839 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
840 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
841 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
842 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
843 No need to cast type when ORing.
844 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
845 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
846 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
847 assume EMACS_INT is the same width as char *.
848 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
849 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
850 Remove no-longer-needed casts.
851 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
852 (xg_tool_bar_help_callback, xg_make_tool_item):
853 Use EMACS_INTPTR to hold an integer
854 that will be cast to void *; this can avoid a GCC warning
855 if EMACS_INT is not the same width as void *.
856 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
857 * xdisp.c (display_echo_area_1, resize_mini_window_1):
858 (current_message_1, set_message_1):
859 Use a local to convert to proper width without a cast.
860 * xmenu.c (dialog_selection_callback): Likewise.
861
862 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
863 Also, don't assume VALBITS / RAND_BITS is less than 5,
864 and don't rely on undefined behavior when shifting a 1 left into
865 the sign bit.
866 * lisp.h (get_random): Change signature to match.
867
868 * lread.c (hash_string): Use size_t, not int, for hash computation.
869 Normally we prefer signed values; but hashing is special, because
870 it's better to use unsigned division on hash table sizes so that
871 the remainder is nonnegative. Also, size_t is the natural width
872 for hashing into memory. The previous code used 'int', which doesn't
873 retain enough info to hash well into very large tables.
874 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
875
876 * dbusbind.c: Don't possibly lose pointer info when converting.
877 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
878 Use XPNTR rather than XHASH, so that the high-order bits of
879 the pointer aren't lost when converting through void *.
880
881 * eval.c (Fautoload): Don't double-shift a pointer.
882
883 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
884
885 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
886
887 * gnutls.c (DEF_GNUTLS_FN):
888 * image.c (DEF_IMGLIB_FN): Make function pointers static.
889
890 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
891
892 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
893 marker. (Bug#8610)
894
895 2011-05-05 Eli Zaretskii <eliz@gnu.org>
896
897 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
898 New version that can reserve upto 2GB of heap space.
899
900 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
901
902 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
903
904 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
905
906 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
907 `gnutls_certificate_set_x509_key_file'.
908
909 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
910
911 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
912 Update dependencies.
913
914 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
915
916 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
917 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
918 Remove unused parameter `fildes'.
919 * process.c (read_process_output, send_process): Don't pass it.
920
921 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
922
923 Fix previous change: the library cache is defined in w32.c.
924 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
925 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
926
927 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
928
929 Implement dynamic loading of GnuTLS on Windows.
930
931 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
932 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
933 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
934 Declare.
935
936 * gnutls.c (Qgnutls_dll): Define.
937 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
938 (gnutls_*): Declare function pointers.
939 (init_gnutls_functions): New function to initialize function pointers.
940 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
941 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
942 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
943 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
944 (emacs_gnutls_write, emacs_gnutls_read)
945 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
946 (Fgnutls_available_p): New function.
947 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
948 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
949 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
950
951 * image.c: Include w32.h.
952 (Vimage_type_cache): Delete.
953 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
954 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
955 (w32_delayed_load): Move to w32.c.
956
957 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
958
959 * w32.c (QCloaded_from, Vlibrary_cache): Define.
960 (w32_delayed_load): Move from image.c. When loading a library, record
961 its filename in the :loaded-from property of the library id.
962 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
963 Initialize and staticpro them.
964 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
965
966 * process.c: Include lisp.h before w32.h, not after.
967 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
968 instead of gnutls_record_check_pending.
969
970 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
971
972 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
973
974 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
975 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
976 as passed in.
977
978 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
979
980 * xterm.c (x_set_frame_alpha): Do not set property on anything
981 else than FRAME_X_OUTER_WINDOW (Bug#8608).
982
983 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
984
985 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
986
987 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
988
989 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
990 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
991 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
992 (gnutls_global_initialized, Qgnutls_bootprop_priority)
993 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
994 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
995 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
996 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
997 (Qgnutls_bootprop_callbacks_verify): Make static.
998
999 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1000
1001 * callproc.c: Indentation fixup.
1002
1003 * sysdep.c (wait_for_termination_1): Make static.
1004 (wait_for_termination, interruptible_wait_for_termination):
1005 Move after wait_for_termination_1.
1006
1007 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1008
1009 * sysdep.c (interruptible_wait_for_termination): New function
1010 which is like wait_for_termination, but allows keyboard
1011 interruptions.
1012
1013 * callproc.c (Fcall_process): Add (:file "file") as an option for
1014 the STDOUT buffer.
1015 (Fcall_process_region): Ditto.
1016
1017 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1018
1019 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1020 rather than `XVECTOR (FOO)->size'.
1021
1022 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1023 inttypes.h, as a gnulib replacement is used if it not available in
1024 system headers.
1025
1026 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1027
1028 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1029 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1030 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1031
1032 * coding.c (coding_alloc_by_realloc): Error out if destination
1033 will grow beyond MOST_POSITIVE_FIXNUM.
1034 (decode_coding_emacs_mule): Abort if there isn't enough place in
1035 charbuf for the composition carryover bytes. Reserve an extra
1036 space for up to 2 characters produced in a loop.
1037 (decode_coding_iso_2022): Abort if there isn't enough place in
1038 charbuf for the composition carryover bytes.
1039
1040 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1041
1042 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1043 aborting when %lld or %lll format is passed.
1044 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1045 %llo or %llx format is passed. (Bug#8545)
1046
1047 * window.c (window_scroll_line_based): Use a marker instead of
1048 simple variables to record original value of point. (Bug#7952)
1049
1050 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1051 produced by %s or %c overflows available buffer space. (Bug#8545)
1052
1053 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1056 (SIZE_MAX): Move defn after all includes, as they might #define it.
1057
1058 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1059
1060 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1061
1062 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1063
1064 * keyboard.c (Qdelayed_warnings_hook): Define.
1065 (command_loop_1): Run `delayed-warnings-hook'
1066 if Vdelayed_warnings_list is non-nil.
1067 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1068 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1069
1070 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1071
1072 * doprnt.c (doprnt): Don't return value smaller than the buffer
1073 size if the message was truncated. (Bug#8545).
1074
1075 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1076
1077 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1078 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1079
1080 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1081
1082 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1083
1084 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1085
1086 * makefile.w32-in: Update dependencies.
1087
1088 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1089
1090 Improve `doprnt' and its usage. (Bug#8545)
1091 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1092 `format_end'. Remove support for %l as a conversion specifier.
1093 Don't use xrealloc. Improve diagnostics when the %l size modifier
1094 is used. Update the commentary.
1095
1096 * eval.c (verror): Simplify calculation of size_t.
1097
1098 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1099 messages.
1100
1101 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1102
1103 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1104 change.
1105
1106 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1107
1108 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1109 This makes this file independent of the recent pseudovector change.
1110
1111 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1112
1113 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1114
1115 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1116 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1117 Remove unused local.
1118 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1119
1120 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1121 GCC 4.6.0 optimizes based on type-based alias analysis.
1122 For example, if b is of type struct buffer * and v of type struct
1123 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1124 != &v->size, and therefore "v->size = 1; b->size = 2; return
1125 v->size;" must therefore return 1. This assumption is incorrect
1126 for Emacs, since it type-puns struct Lisp_Vector * with many other
1127 types. To fix this problem, this patch adds a new type struct
1128 vectorlike_header that documents the constraints on layout of vectors
1129 and pseudovectors, and helps optimizing compilers not get fooled
1130 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1131 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1132 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1133 the size member.
1134 (XSETPVECTYPE): Rewrite in terms of new macro.
1135 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1136 This is a bit clearer, and further avoids the possibility of
1137 undesirable aliasing.
1138 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1139 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1140 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1141 since Lisp_Subr is a special case (no "next" field).
1142 (ASIZE): Now uses header.size rather than size.
1143 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1144 to avoid the hassle of writing XVECTOR (foo)->header.size.
1145 (struct vectorlike_header): New type.
1146 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1147 object, to help avoid aliasing.
1148 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1149 (SUBRP): Likewise, since Lisp_Subr is a special case.
1150 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1151 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1152 (struct Lisp_Hash_Table): Combine first two members into a single
1153 struct vectorlike_header member. All uses of "size" and "next" members
1154 changed to be "header.size" and "header.next".
1155 * buffer.h (struct buffer): Likewise.
1156 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1157 * frame.h (struct frame): Likewise.
1158 * process.h (struct Lisp_Process): Likewise.
1159 * termhooks.h (struct terminal): Likewise.
1160 * window.c (struct save_window_data, struct saved_window): Likewise.
1161 * window.h (struct window): Likewise.
1162 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1163 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1164 * buffer.c (init_buffer_once): Likewise.
1165 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1166 special case.
1167 * process.c (Fformat_network_address): Use local var for size,
1168 for brevity.
1169
1170 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1171
1172 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1173 * data.c (atof): Remove decl; no longer used or needed.
1174 (digit_to_number): Move to lread.c.
1175 (Fstring_to_number): Use new string_to_number function, to be
1176 consistent with how the Lisp reader treats infinities and NaNs.
1177 Do not assume that floating-point numbers represent EMACS_INT
1178 without losing information; this is not true on most 64-bit hosts.
1179 Avoid double-rounding errors, by insisting on integers when
1180 parsing non-base-10 numbers, as the documentation specifies.
1181 * lisp.h (string_to_number): New decl, replacing ...
1182 (isfloat_string): Remove.
1183 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1184 (read1): Do not accept +. and -. as integers; this
1185 appears to have been a coding error. Similarly, do not accept
1186 strings like +-1e0 as floating point numbers. Do not report
1187 overflow for integer overflows unless the base is not 10 which
1188 means we have no simple and reliable way to continue.
1189 Break out the floating-point parsing into a new
1190 function string_to_number, so that Fstring_to_number parses
1191 floating point numbers consistently with the Lisp reader.
1192 (digit_to_number): Move here from data.c. Make it static inline.
1193 (E_CHAR, EXP_INT): Remove, replacing with ...
1194 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1195 (string_to_number): New function, replacing isfloat_string.
1196 This function checks for valid syntax and produces the resulting
1197 Lisp float number too. Rework it so that string-to-number
1198 no longer mishandles examples like "1.0e+". Use strtoumax,
1199 so that overflow for non-base-10 numbers is reported only when
1200 there's no portable and simple way to convert to floating point.
1201
1202 * textprop.c (set_text_properties_1): Rewrite for clarity,
1203 and to avoid GCC warning about integer overflow.
1204
1205 * intervals.h (struct interval): Use EMACS_INT for members
1206 where EMACS_UINT might cause problems. See
1207 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1208 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1209 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1210 All uses changed.
1211 (offset_intervals): Tell GCC not to worry about length overflow
1212 when negating a negative length.
1213
1214 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1215 (overrun_check_free): Likewise.
1216
1217 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1218 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1219 word size.
1220
1221 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1222 (gnutls_make_error): Rename local to avoid shadowing.
1223 (gnutls_emacs_global_deinit): ifdef out; not used.
1224 (Fgnutls_boot): Use const for pointer to readonly storage.
1225 Comment out unused local. Fix pointer signedness problems.
1226
1227 * lread.c (openp): Don't stuff size_t into an 'int'.
1228 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1229 about possible signed overflow.
1230
1231 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1232 (GDK_KEY_g): Don't define if already defined.
1233 (xg_prepare_tooltip): Avoid pointer signedness problem.
1234 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1235
1236 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1237 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1238
1239 * xfns.c (Fx_window_property): Simplify a bit,
1240 to make a bit faster and to avoid GCC 4.6.0 warning.
1241 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1242
1243 * fns.c (internal_equal): Don't assume size_t fits in int.
1244
1245 * alloc.c (compact_small_strings): Tighten assertion a little.
1246
1247 Replace pEd with more-general pI, and fix some printf arg casts.
1248 * lisp.h (pI): New macro, generalizing old pEd macro to other
1249 conversion specifiers. For example, use "...%"pI"d..." rather
1250 than "...%"pEd"...".
1251 (pEd): Remove. All uses replaced with similar uses of pI.
1252 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1253 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1254 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1255 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1256 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1257 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1258 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1259 64-bit hosts.
1260 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1261 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1262 * print.c (safe_debug_print, print_object): Likewise.
1263 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1264 to int.
1265 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1266 avoiding the 0 flag, which is not portable.
1267 * process.c (Fmake_network_process): Use pI to avoid cast.
1268 * region-cache.c (pp_cache): Likewise.
1269 * xdisp.c (decode_mode_spec): Likewise.
1270 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1271 behavior on 64-bit hosts with printf arg.
1272 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1273 (x_stop_queuing_selection_requests): Likewise.
1274 (x_get_window_property): Don't truncate byte count to an 'int'
1275 when tracing.
1276
1277 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1278 here, since it parses constructs like leading '-' and spaces,
1279 which are not wanted; and it overflows with large numbers.
1280 Instead, simply match F[0-9]+, which is what is wanted anyway.
1281
1282 * alloc.c: Remove unportable assumptions about struct layout.
1283 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1284 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1285 (allocate_vectorlike, make_pure_vector): Use the new macros,
1286 plus offsetof, to remove unportable assumptions about struct layout.
1287 These assumptions hold on all porting targets that I know of, but
1288 they are not guaranteed, they're easy to remove, and removing them
1289 makes further changes easier.
1290
1291 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1292 This doesn't fix a bug but makes the code clearer.
1293 (string_overrun_cookie): Now const. Use initializers that
1294 don't formally overflow signed char, to avoid warnings.
1295 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1296 can cause Emacs to crash when string overrun checking is enabled.
1297 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1298 multiple of sizeof (EMACS_INT); it need not be, if
1299 alignof(EMACS_INT) < sizeof (EMACS_INT).
1300 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1301
1302 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1303
1304 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1305
1306 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1307
1308 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1309 supposed to be handshaking. (Bug#8556)
1310 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1311
1312 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1313
1314 * lisp.h (Qdebug): List symbol.
1315 * eval.c (Qdebug): Restore global linkage.
1316 * keyboard.c (debug-on-event): New variable.
1317 (handle_user_signal): Break into debugger when debug-on-event
1318 matches the current signal symbol.
1319
1320 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1321
1322 * alloc.c (check_sblock, check_string_bytes)
1323 (check_string_free_list): Convert to standard C.
1324
1325 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1326
1327 * w32.c (emacs_gnutls_push): Fix typo.
1328
1329 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1330
1331 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1332 "cast to pointer from integer of different size".
1333
1334 Improve doprnt and its use in verror. (Bug#8545)
1335 * doprnt.c (doprnt): Document the set of format control sequences
1336 supported by the function. Use SAFE_ALLOCA instead of always
1337 using `alloca'.
1338
1339 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1340 is one byte too soon. Don't use xrealloc; instead xfree and
1341 xmalloc anew.
1342
1343 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1344
1345 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1346 callbacks stage.
1347
1348 * gnutls.c: Renamed global_initialized to
1349 gnutls_global_initialized. Added internals for the
1350 :verify-hostname-error, :verify-error, and :verify-flags
1351 parameters of `gnutls-boot' and documented those parameters in the
1352 docstring. Start callback support.
1353 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1354 unless a fatal error occured. Call gnutls_alert_send_appropriate
1355 on error. Return error code.
1356 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1357 (emacs_gnutls_read): Likewise.
1358 (Fgnutls_boot): Return handshake error code.
1359 (emacs_gnutls_handle_error): New function.
1360 (wsaerror_to_errno): Likewise.
1361
1362 * w32.h (emacs_gnutls_pull): Add prototype.
1363 (emacs_gnutls_push): Likewise.
1364
1365 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1366 (emacs_gnutls_push): Likewise.
1367
1368 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1369
1370 * process.c (wait_reading_process_output): Check if GnuTLS
1371 buffered some data internally if no FDs are set for TLS
1372 connections.
1373
1374 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1375 (LIBS): Link to USER_LIBS.
1376 ($(BLD)/gnutls.$(0)): New target.
1377
1378 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1379
1380 * xdisp.c (handle_single_display_spec): Rename the
1381 display_replaced_before_p argument into display_replaced_p, to
1382 make it consistent with the commentary. Fix typos in the
1383 commentary.
1384
1385 * textprop.c (syms_of_textprop): Remove dead code.
1386 (copy_text_properties): Delete obsolete commentary about an
1387 interface that was deleted long ago. Fix typos in the description
1388 of arguments.
1389
1390 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1391 to changes in oldXMenu/XMenu.h from 2011-04-16.
1392 <menu_help_message, prev_menu_help_message>: Constify.
1393 (IT_menu_make_room): menu->help_text is now `const char **';
1394 adjust.
1395
1396 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1397 to changes in oldXMenu/XMenu.h from 2011-04-16.
1398 (struct XMenu): Declare `help_text' `const char **'.
1399
1400 * xfaces.c <Qunspecified>: Make extern again.
1401
1402 * syntax.c: Include sys/types.h before including regex.h, as
1403 required by Posix.
1404
1405 * doc.c (get_doc_string): Improve the format passed to `error'.
1406
1407 * doprnt.c (doprnt): Improve commentary.
1408
1409 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1410
1411 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1412 them with etags.
1413
1414 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1415 changes in globals.h immediately force recompilation.
1416 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1417 $(CURDIR)/s/ms-w32.h.
1418 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1419
1420 * character.c (Fchar_direction): Function deleted.
1421 (syms_of_character): Don't defsubr it.
1422 <char-direction-table>: Deleted.
1423
1424 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1425
1426 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1427 * doprnt.c: Include limits.h.
1428 (SIZE_MAX): New macro.
1429 (doprnt): Return a size_t value. 2nd arg is now size_t.
1430 Many local variables are now size_t instead of int or unsigned.
1431 Improve overflow protection. Support `l' modifier for integer
1432 conversions. Support %l conversion. Don't assume an EMACS_INT
1433 argument for integer conversions and for %c.
1434
1435 * lisp.h (doprnt): Restore prototype.
1436
1437 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1438 $(SRC)/character.h.
1439
1440 * Makefile.in (base_obj): Add back doprnt.o.
1441
1442 * deps.mk (doprnt.o): Add back prerequisites.
1443 (callint.o): Depend on character.h.
1444
1445 * eval.c (internal_lisp_condition_case): Include the handler
1446 representation in the error message.
1447 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1448 when breaking from the loop.
1449
1450 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1451
1452 * callint.c (Fcall_interactively): When displaying error message
1453 about invalid control letter, pass the character's codepoint, not
1454 a pointer to its multibyte form. Improve display of the character
1455 in octal and display also its hex code.
1456
1457 * character.c (char_string): Use %x to display the (unsigned)
1458 codepoint of an invalid character, to avoid displaying a bogus
1459 negative value.
1460
1461 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1462 `error', not SYMBOL_NAME itself.
1463
1464 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1465 character arguments to `error'.
1466
1467 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1468 to `error' in error message about FINAL_CHAR argument. Make sure
1469 FINAL_CHAR is a character, and use %c when it is passed as
1470 argument to `error'.
1471
1472 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1473
1474 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1475
1476 * w32.c: Include <time.h>.
1477 (sys_localtime): New function.
1478
1479 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1480
1481 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1482
1483 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1484
1485 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1486
1487 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1488 zombies (Bug#8467).
1489
1490 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1491
1492 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1493 gl_state.e_property when gl_state.object is Qt.
1494
1495 * insdel.c (make_gap_larger): Remove limitation of buffer size
1496 to <= INT_MAX.
1497
1498 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1499
1500 * xdisp.c (lookup_glyphless_char_display)
1501 (produce_glyphless_glyph): Handle cons cell entry in
1502 glyphless-char-display.
1503 (Vglyphless_char_display): Document it.
1504
1505 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1506 glyphless-char-display.
1507
1508 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1509
1510 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1511
1512 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1513
1514 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1515 definition for no-X builds.
1516
1517 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 Static checks with GCC 4.6.0 and non-default toolkits.
1520
1521 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1522
1523 * process.c (keyboard_bit_set): Define only if SIGIO.
1524 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1525 (send_process): Repair possible setjmp clobbering.
1526
1527 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1528
1529 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1530
1531 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1532
1533 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1534 Define only if needed.
1535
1536 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1537 by pacifying GCC about it. Maybe it's time to retire it?
1538 * xfaces.c (USG, __TIMEVAL__): Likewise.
1539
1540 * dispextern.h (struct redisplay_interface): Rename param
1541 to avoid shadowing.
1542 * termhooks.h (struct terminal): Likewise.
1543 * xterm.c (xembed_send_message): Likewise.
1544
1545 * insdel.c (make_gap_smaller): Define only if
1546 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1547
1548 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1549 it.
1550
1551 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1552 so that we aren't warned about unused symbols.
1553
1554 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1555
1556 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1557
1558 * xfns.c (x_real_positions): Mark locals as initialized.
1559
1560 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1561
1562 * xterm.c: Fix problems found by static analysis with other toolkits.
1563 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1564 (x_dispatch_event): Declare static if USE_GTK, and
1565 define if USE_GTK || USE_X_TOOLKIT.
1566 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1567 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1568 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1569 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1570
1571 * xmenu.c (menu_help_callback): Pointer type fixes.
1572 Use const pointers when pointing at readonly data. Avoid pointer
1573 signedness clashes.
1574 (FALSE): Remove unused macro.
1575 (update_frame_menubar): Remove unused decl.
1576
1577 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1578
1579 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1580 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1581 (single_menu_item): Rename local to avoid shadowing.
1582
1583 * keyboard.c (make_lispy_event): Remove unused local var.
1584
1585 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1586 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1587
1588 * bitmaps: Change bitmaps from unsigned char back to the X11
1589 compatible char. Avoid the old compiler warnings about
1590 out-of-range initializers by using, for example, '\xab' rather
1591 than 0xab.
1592
1593 * xgselect.c (xgselect_initialize): Check vs interface
1594 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1595
1596 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1597
1598 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1599 to read-only memory.
1600
1601 * fns.c (vector): Remove; this old hack is no longer needed.
1602
1603 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1604 Remove unused var.
1605 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1606
1607 * xrdb.c (x_load_resources): Omit unused local.
1608
1609 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1610 (x_window): Rename locals to avoid shadowing.
1611 (USG): Use the kludged USG macro, to pacify gcc.
1612
1613 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1614 (x_term_init): Remove local to avoid shadowing.
1615
1616 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1617
1618 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1619 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1620
1621 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1622
1623 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1624
1625 Fix regex.c, syntax.c and friends for buffers > 2GB.
1626 * syntax.h (struct gl_state_s): Declare character position members
1627 EMACS_INT.
1628
1629 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1630
1631 * textprop.c (verify_interval_modification, interval_of):
1632 Declare arguments EMACS_INT.
1633
1634 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1635 EMACS_INT.
1636
1637 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1638
1639 * indent.c (Fvertical_motion): Local variable it_start is now
1640 EMACS_INT.
1641
1642 * regex.c (re_match, re_match_2, re_match_2_internal)
1643 (bcmp_translate, regcomp, regexec, print_double_string)
1644 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1645 (re_compile_pattern, re_exec): Declare arguments and local
1646 variables `size_t' and `ssize_t' and return values `regoff_t', as
1647 appropriate.
1648 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1649 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1650 <compile_stack_type>: `size' and `avail' are now `size_t'.
1651
1652 * regex.h <regoff_t>: Use ssize_t, not int.
1653 (re_search, re_search_2, re_match, re_match_2): Arguments that
1654 specify buffer/string position and length are now ssize_t and
1655 size_t. Return type is regoff_t.
1656
1657 2011-04-16 Ben Key <bkey76@gmail.com>
1658
1659 * nsfont.m: Fixed bugs in ns_get_family and
1660 ns_descriptor_to_entity that were caused by using free to
1661 deallocate memory blocks that were allocated by xmalloc (via
1662 xstrdup). This caused Emacs to crash when compiled with
1663 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1664 --enable-checking=xmallocoverrun). xfree is now used to
1665 deallocate these memory blocks.
1666
1667 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1668
1669 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1670
1671 emacs_write: Accept and return EMACS_INT for sizes.
1672 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1673 et seq.
1674 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1675 Accept and return EMACS_INT.
1676 (emacs_gnutls_write): Return the number of bytes written on
1677 partial writes.
1678 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1679 (emacs_read, emacs_write): Remove check for negative size, as the
1680 Emacs source code has been audited now.
1681 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1682 (emacs_read, emacs_write): Use it.
1683 * process.c (send_process): Adjust to the new signatures of
1684 emacs_write and emacs_gnutls_write. Do not attempt to store
1685 a byte offset into an 'int'; it might overflow.
1686 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1687
1688 * sound.c: Don't assume sizes fit in 'int'.
1689 (struct sound_device.period_size, alsa_period_size):
1690 Return EMACS_INT, not int.
1691 (struct sound_device.write, vox_write, alsa_write):
1692 Accept EMACS_INT, not int.
1693 (wav_play, au_play): Use EMACS_INT to store sizes and to
1694 record read return values.
1695
1696 2011-04-15 Ben Key <bkey76@gmail.com>
1697
1698 * keyboard.c (Qundefined): Don't declare static since it is used
1699 in nsfns.m.
1700 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1701 static since they are used in nsfont.m.
1702
1703 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1704
1705 * process.c (Qprocessp): Don't declare static.
1706 * lisp.h (Qprocessp): Declare again.
1707
1708 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1709
1710 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1711
1712 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1713
1714 Improve C-level modularity by making more things 'static'.
1715
1716 Don't publish debugger-only interfaces to other modules.
1717 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1718 (verify_bytepos, count_markers): Move decls to the only modules
1719 that need them.
1720 * region-cache.h (pp_cache): Likewise.
1721 * window.h (check_all_windows): Likewise.
1722 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1723
1724 * sysdep.c (croak): Now static, if
1725 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1726 * syssignal.h (croak): Declare only if not static.
1727
1728 * alloc.c (refill_memory_reserve): Now static if
1729 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1730 * lisp.h (refill_memory_reserve): Declare only if not static.
1731
1732 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1733 Define only if USE_LUCID.
1734
1735 * xrdb.c (x_customization_string, x_rm_string): Now static.
1736
1737 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1738 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1739
1740 * xdisp.c (draw_row_with_mouse_face): Now static.
1741 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1742
1743 * window.h (check_all_windows): Mark externally visible.
1744
1745 * window.c (window_deletion_count): Now static.
1746
1747 * undo.c: Make symbols static if they're not exported.
1748 (last_undo_buffer, last_boundary_position, pending_boundary):
1749 Now static.
1750
1751 * textprop.c (interval_insert_behind_hooks): Now static.
1752 (interval_insert_in_front_hooks): Likewise.
1753
1754 * term.c: Make symbols static if they're not exported.
1755 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1756 (max_frame_lines, tty_set_terminal_modes):
1757 (tty_reset_terminal_modes, tty_turn_off_highlight):
1758 (get_tty_terminal): Now static.
1759 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1760 * termhooks.h (term_mouse_moveto): Do not declare if
1761 HAVE_WINDOW_SYSTEM.
1762 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1763 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1764
1765 * sysdep.c: Make symbols static if they're not exported.
1766 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1767 Now static.
1768 (sigprocmask_set, full_mask): Remove; unused.
1769 (wait_debugging): Mark as visible.
1770 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1771 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1772
1773 * syntax.c (syntax_temp): Define only if !__GNUC__.
1774
1775 * sound.c (current_sound_device, current_sound): Now static.
1776
1777 * search.c (searchbufs, searchbuf_head): Now static.
1778
1779 * scroll.c (scroll_cost): Remove; unused.
1780 * dispextern.h (scroll_cost): Remove decl.
1781
1782 * region-cache.h (pp_cache): Mark as externally visible.
1783
1784 * process.c: Make symbols static if they're not exported.
1785 (process_tick, update_tick, create_process, chan_process):
1786 (Vprocess_alist, proc_buffered_char, datagram_access):
1787 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1788 (deactivate_process): Mark defn as static, as well as decl.
1789 * lisp.h (create_process): Remove decl.
1790 * process.h (chan_process, Vprocess_alist): Remove decls.
1791
1792 * print.c: Make symbols static if they're not exported.
1793 (print_depth, new_backquote_output, being_printed, print_buffer):
1794 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1795 (print_interval, print_number_index, initial_stderr_stream):
1796 Now static.
1797 * lisp.h (Fprinc): Remove decl.
1798 (debug_output_compilation_hack): Mark as externally visible.
1799
1800 * sysdep.c (croak): Move decl from here to syssignal.h.
1801 * syssignal.h (croak): Put it here, so the API can be checked when
1802 'croak' is called from dissociate_if_controlling_tty.
1803
1804 * minibuf.c: Make symbols static if they're not exported.
1805 (minibuf_save_list, choose_minibuf_frame): Now static.
1806 * lisp.h (choose_minibuf_frame): Remove decl.
1807
1808 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1809
1810 * lread.c: Make symbols static if they're not exported.
1811 (read_objects, initial_obarray, oblookup_last_bucket_number):
1812 Now static.
1813 (make_symbol): Remove; unused.
1814 * lisp.h (initial_obarray, make_symbol): Remove decls.
1815
1816 * keyboard.c: Make symbols static if they're not exported.
1817 (single_kboard, recent_keys_index, total_keys, recent_keys):
1818 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1819 (this_single_command_key_start, echoing, last_auto_save):
1820 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1821 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1822 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1823 (Vlispy_mouse_stem, double_click_count):
1824 Now static.
1825 (force_auto_save_soon): Define only if SIGDANGER.
1826 (ignore_mouse_drag_p): Now static if
1827 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1828 (print_help): Remove; unused.
1829 (stop_character, last_timer_event): Mark as externally visible.
1830 * keyboard.h (ignore_mouse_drag_p): Declare only if
1831 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1832 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1833 * lisp.h (echoing): Remove decl.
1834 (force_auto_save_soon): Declare only if SIGDANGER.
1835 * xdisp.c (redisplay_window): Simplify code, to make it more
1836 obvious that ignore_mouse_drag_p is not accessed if !defined
1837 USE_GTK && !defined HAVE_NS.
1838
1839 * intervals.c: Make symbols static if they're not exported.
1840 (merge_properties_sticky, merge_interval_right, delete_interval):
1841 Now static.
1842 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1843
1844 * insdel.c: Make symbols static if they're not exported.
1845 However, leave prepare_to_modify_buffer alone. It's never
1846 called from outside this function, but that appears to be a bug.
1847 (combine_after_change_list, combine_after_change_buffer):
1848 (adjust_after_replace, signal_before_change): Now static.
1849 (adjust_after_replace_noundo): Remove; unused.
1850 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1851 (signal_before_change): Remove decls.
1852
1853 * indent.c (val_compute_motion, val_vmotion): Now static.
1854
1855 * image.c: Make symbols static if they're not exported.
1856 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1857 if USE_GTK.
1858 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1859 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1860
1861 * fringe.c (standard_bitmaps): Now static.
1862 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1863
1864 * frame.c: Make symbols static if they're not exported.
1865 (x_report_frame_params, make_terminal_frame): Now static.
1866 (get_frame_param): Now static, unless HAVE_NS.
1867 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1868 (x_get_resource_string): Remove; not used.
1869 * frame.h (make_terminal_frame, x_report_frame_params):
1870 (x_get_resource_string); Remove decls.
1871 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1872 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1873
1874 * font.c, fontset.c: Make symbols static if they're not exported.
1875 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1876 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1877 * font.c (font_close_object): Now static.
1878 * font.h (font_close_object): Remove.
1879 * fontset.c (FONTSET_OBJLIST): Remove.
1880 (free_realized_fontset) #if-0 the body, which does nothing.
1881 (face_suitable_for_char_p): #if-0, as it's never called.
1882 * fontset.h (face_suitable_for_char_p): Remove decl.
1883 * xfaces.c (face_at_string_position):
1884 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1885 since 0 is always ASCII.
1886
1887 * fns.c (weak_hash_tables): Now static.
1888
1889 * fileio.c: Make symbols static if they're not exported.
1890 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1891 (Vwrite_region_annotation_buffers): Now static.
1892
1893 * eval.c: Make symbols static if they're not exported.
1894 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1895 * lisp.h (backtrace_list): Remove decl.
1896
1897 * emacs.c: Make symbols static if they're not exported.
1898 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1899 (fatal_error_code, fatal_error_signal_hook, standard_args):
1900 Now static.
1901 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1902 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1903 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1904 * lisp.h (fatal_error_signal_hook): Remove decl.
1905 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1906
1907 * editfns.c: Move a (normally-unused) function to its only use.
1908 * editfns.c, lisp.h (get_operating_system_release): Remove.
1909 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1910 worth the hassle of breaking this out.
1911
1912 * xterm.c: Make symbols static if they're not exported.
1913 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1914 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1915 (x_destroy_window, x_delete_display):
1916 Now static.
1917 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1918 (x_mouse_leave): Remove; unused.
1919 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1920 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1921 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1922 Remove decls.
1923 (x_mouse_leave): Declare only if WINDOWSNT.
1924 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1925 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1926 USE_X_TOOLKIT.
1927
1928 * ftxfont.c: Make symbols static if they're not exported.
1929 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1930 HAVE_FREETYPE.
1931 * font.h (ftxfont_driver): Likewise.
1932
1933 * xfns.c: Make symbols static if they're not exported.
1934 (x_last_font_name, x_display_info_for_name):
1935 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1936 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1937 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1938 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1939 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1940 (last_show_tip_args): Now static.
1941 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1942 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1943 (x_screen_planes): Remove; unused.
1944 * dispextern.h (x_screen_planes): Remove decl.
1945
1946 * dispnew.c: Make symbols static if they're not exported.
1947 * dispextern.h (redraw_garbaged_frames, scrolling):
1948 (increment_row_positions): Remove.
1949 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1950 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1951 Now static.
1952 (redraw_garbaged_frames): Remove; unused.
1953
1954 * xfaces.c: Make symbols static if they're not exported.
1955 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1956 Remove decls.
1957 * xterm.h (defined_color): Remove decls.
1958 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1959 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1960 (menu_face_changed_default, defined_color, free_realized_face):
1961 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1962 (ascii_face_of_lisp_face): Remove; unused.
1963
1964 * xdisp.c: Make symbols static if they're not exported.
1965 * dispextern.h (scratch_glyph_row, window_box_edges):
1966 (glyph_to_pixel_coords, set_cursor_from_row):
1967 (get_next_display_element, set_iterator_to_next):
1968 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1969 (show_mouse_face): Remove decls
1970 * frame.h (message_buf_print): Likewise.
1971 * lisp.h (pop_message, set_message, check_point_in_composition):
1972 Likewise.
1973 * xterm.h (set_vertical_scroll_bar): Likewise.
1974 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1975 (message_buf_print, scratch_glyph_row, displayed_buffer):
1976 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1977 (get_next_display_element, show_mouse_face, window_box_edges):
1978 (frame_to_window_pixel_xy, check_point_in_composition):
1979 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1980 (glyph_to_pixel_coords): Remove; unused.
1981
1982 * dired.c (file_name_completion): Now static.
1983
1984 * dbusbind.c (xd_in_read_queued_messages): Now static.
1985
1986 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1987 * data.c (circular_list_error): Remove.
1988
1989 * commands.h (last_point_position, last_point_position_buffer):
1990 (last_point_position_window): Remove decls.
1991 * keyboard.c: Make these variables static.
1992
1993 * coding.h (coding, code_convert_region, encode_coding_gap):
1994 Remove decls.
1995 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1996 (iso_code_class, detect_coding, code_convert_region): Now static.
1997 (encode_coding_gap): Remove; unused.
1998
1999 * chartab.c (chartab_chars, chartab_bits): Now static.
2000
2001 * charset.h (charset_iso_8859_1): Remove decl.
2002 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2003 Now static.
2004
2005 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2006 * ccl.c (Vccl_program_table): Now static.
2007 (check_ccl_update): Remove; unused.
2008
2009 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2010 * category.h: ... from here.
2011 * category.c (check_category_table, set_category_set): Now static.
2012
2013 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2014 * lisp.h: Remove these decls.
2015
2016 * buffer.c (buffer_count): Remove unused var.
2017
2018 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2019 so that it's not optimized away.
2020 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2021 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2022 exported only to the debugger.
2023
2024 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2025 * atimer.h (run_all_atimers): Remove; not exported.
2026
2027 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2028 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2029 was inaccessible from Lisp.
2030 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2031 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2032
2033 alloc.c: Import and export fewer symbols, and remove unused items.
2034 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2035 is defined.
2036 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2037 it's not optimized away by whole-program optimization.
2038 (message_enable_multibyte, free_misc): Remove.
2039 (catchlist, handlerlist, mark_backtrace):
2040 Declare only if BYTE_MARK_STACK.
2041 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2042 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2043 (message_enable_multibyte): Remove decl.
2044 (free_misc, interval_free_list, float_block, float_block_index):
2045 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2046 (cons_free_list, last_marked_index):
2047 Now static.
2048 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2049 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2050 (mark_backtrace): Define only if BYTE_MARK_STACK.
2051 * xdisp.c (message_enable_multibyte): Now static.
2052
2053 Declare Lisp_Object Q* variables to be 'static' if not exported.
2054 This makes it easier for human readers (and static analyzers)
2055 to see whether these variables are used from other modules.
2056 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2057 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2058 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2059 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2060 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2061 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2062 * xmenu.c, xselect.c:
2063 Declare Q* vars static if they are not used in other modules.
2064 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2065 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2066 Remove decls of unexported vars.
2067 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2068
2069 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2070
2071 Make Emacs functions such as Fatom 'static' by default.
2072 This makes it easier for human readers (and static analyzers)
2073 to see whether these functions can be called from other modules.
2074 DEFUN now defines a static function. To make the function external
2075 so that it can be used in other C modules, use the new macro DEFUE.
2076 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2077 (Finit_image_library):
2078 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2079 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2080 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2081 Remove decls, since these functions are now static.
2082 (Funintern, Fget_internal_run_time): New decls, since these functions
2083 were already external.
2084
2085 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2086 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2087 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2088 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2089 * keyboard.c, keymap.c, lread.c:
2090 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2091 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2092 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2093 Mark functions with DEFUE instead of DEFUN,
2094 if they are used in other modules.
2095 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2096 decls for now-static functions.
2097 * buffer.h (Fdelete_overlay): Remove decl.
2098 * callproc.c (Fgetenv_internal): Mark as internal.
2099 * composite.c (Fremove_list_of_text_properties): Remove decl.
2100 (Fcomposition_get_gstring): New forward static decl.
2101 * composite.h (Fcomposite_get_gstring): Remove decl.
2102 * dired.c (Ffile_attributes): New forward static decl.
2103 * doc.c (Fdocumntation_property): New forward static decl.
2104 * eval.c (Ffetch_bytecode): New forward static decl.
2105 (Funintern): Remove extern decl; now in .h file where it belongs.
2106 * fileio.c (Fmake_symbolic_link): New forward static decl.
2107 * image.c (Finit_image_library): New forward static decl.
2108 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2109 * intervals.h (Fprevious_property_change):
2110 (Fremove_list_of_text_properties): Remove decls.
2111 * keyboard.c (Fthis_command_keys): Remove decl.
2112 (Fcommand_execute): New forward static decl.
2113 * keymap.c (Flookup_key): New forward static decl.
2114 (Fcopy_keymap): Now static.
2115 * keymap.h (Flookup_key): Remove decl.
2116 * process.c (Fget_process): New forward static decl.
2117 (Fprocess_datagram_address): Mark as internal.
2118 * syntax.c (Fsyntax_table_p): New forward static decl.
2119 (skip_chars): Remove duplicate decl.
2120 * textprop.c (Fprevious_property_change): New forward static decl.
2121 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2122 Now internal.
2123 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2124 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2125
2126 * editfns.c (Fformat): Remove unreachable code.
2127
2128 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2129
2130 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2131 change. (Bug#8496)
2132
2133 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2134
2135 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2136 when at ZV. (Bug#8487)
2137
2138 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2139
2140 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2141 (Bug#8437)
2142 * keyboard.c (parse_tool_bar_item): Likewise.
2143 * sound.c (sound_cleanup, alsa_close): Likewise.
2144 * termcap.c (tgetent): Likewise.
2145 * xfns.c (x_default_font_parameter): Likewise.
2146 * xsettings.c (read_and_apply_settings): Likewise.
2147
2148 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2149 (overrun_check_free): Protoize.
2150
2151 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2152
2153 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2154 since callers should never pass a negative size.
2155 Change the signature to match that of plain 'read' and 'write'; see
2156 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2157 * lisp.h: Update prototypes of emacs_write and emacs_read.
2158
2159 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2160
2161 * xdisp.c (redisplay_window): Don't try to determine the character
2162 position of the scroll margin if the window start point w->startp
2163 is outside the buffer's accessible region. (Bug#8468)
2164
2165 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2166
2167 Fix write-region and its subroutines for buffers > 2GB.
2168 * fileio.c (a_write, e_write): Modify declaration of arguments and
2169 local variables to support buffers larger than 2GB.
2170 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2171
2172 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2173 argument, local variables, and return value.
2174
2175 * lisp.h: Update prototypes of emacs_write and emacs_read.
2176
2177 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2178
2179 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2182
2183 Fix more problems found by GCC 4.6.0's static checks.
2184
2185 * xdisp.c (vmessage): Use a better test for character truncation.
2186
2187 * charset.c (load_charset_map): <, not <=, for optimization,
2188 and to avoid potential problems with integer overflow.
2189 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2190 * casetab.c (set_identity, shuffle): Likewise.
2191 * editfns.c (Fformat): Likewise.
2192 * syntax.c (skip_chars): Likewise.
2193
2194 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2195 This also lets GCC 4.6.0 generate slightly better loop code.
2196
2197 * callint.c (Fcall_interactively): <, not <=, for optimization.
2198 (Fcall_interactively): Count the number of arguments produced,
2199 not the number of arguments given. This is simpler and lets GCC
2200 4.6.0 generate slightly better code.
2201
2202 * ftfont.c: Distingish more carefully between FcChar8 and char.
2203 The previous code passed unsigned char * to a functions like
2204 strlen and xstrcasecmp that expect char *, which does not
2205 conform to the C standard.
2206 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2207 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2208 char * when the C standard requires it.
2209
2210 * keyboard.c (read_char): Remove unused var.
2211
2212 * eval.c: Port to Windows vsnprintf (Bug#8435).
2213 Include <limits.h>.
2214 (SIZE_MAX): Define if the headers do not.
2215 (verror): Do not give up if vsnprintf returns a negative count.
2216 Instead, grow the buffer. This ports to Windows vsnprintf, which
2217 does not conform to C99. Problem reported by Eli Zaretskii.
2218 Also, simplify the allocation scheme, by avoiding the need for
2219 calling realloc, and removing the ALLOCATED variable.
2220
2221 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2222
2223 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2224 But keep the doprint source code for now, as we might revamp it
2225 and use it again (Bug#8435).
2226 * lisp.h (doprnt): Remove.
2227 * Makefile.in (base_obj): Remove doprnt.o.
2228 * deps.mk (doprnt.o): Remove.
2229
2230 error: Print 32- and 64-bit integers portably (Bug#8435).
2231 Without this change, on typical 64-bit hosts error ("...%d...", N)
2232 was used to print both 32- and 64-bit integers N, which relied on
2233 undefined behavior.
2234 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2235 New macro.
2236 * lisp.h (error, verror): Mark as printf-like functions.
2237 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2238 Report overflow in size calculations when allocating printf buffer.
2239 Do not truncate output string at its first null byte.
2240 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2241 Truncate the output at a character boundary, since vsnprintf does not
2242 do that.
2243 * charset.c (check_iso_charset_parameter): Convert internal
2244 character to string before calling 'error', since %c now has the
2245 printf meaning.
2246 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2247 overflow when computing char to be passed to 'error'. Do not
2248 pass Lisp_Object to 'error'; pass the integer instead.
2249 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2250 formatted with plain %d.
2251
2252 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2253
2254 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2255
2256 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2257
2258 * xterm.c (x_catch_errors): Remove duplicate declaration.
2259
2260 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2261
2262 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2263
2264 2011-04-10 Jim Meyering <meyering@redhat.com>
2265
2266 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2267 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2268 return ssize_t not "int", and use size_t as the buffer length.
2269 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2270 * gnutls.h: Update declarations.
2271 * process.c (read_process_output): Use ssize_t, to match.
2272 (send_process): Likewise.
2273
2274 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2275
2276 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2277
2278 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2279
2280 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2281 Use unsigned char, to match FcChar8 type definition.
2282
2283 * xterm.c (handle_one_xevent):
2284 * xmenu.c (create_and_show_popup_menu):
2285 * xselect.c (x_decline_selection_request)
2286 (x_reply_selection_request): Avoid type-punned deref of X events.
2287
2288 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2289
2290 Fix some uses of `int' instead of EMACS_INT.
2291 * search.c (string_match_1, fast_string_match)
2292 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2293 (scan_buffer, find_next_newline_no_quit)
2294 (find_before_next_newline, search_command, Freplace_match)
2295 (Fmatch_data): Make some `int' variables be EMACS_INT.
2296
2297 * xdisp.c (display_count_lines): 3rd argument and return value now
2298 EMACS_INT. All callers changed.
2299 (pint2hrstr): Last argument is now EMACS_INT.
2300
2301 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2302 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2303 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2304 (decode_coding_utf_16, decode_coding_emacs_mule)
2305 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2306 (decode_coding_ccl, decode_coding_charset)
2307 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2308 (decode_coding_iso_2022, decode_coding_emacs_mule)
2309 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2310 <char_offset, last_offset>: Declare EMACS_INT.
2311 (encode_coding_utf_8, encode_coding_utf_16)
2312 (encode_coding_emacs_mule, encode_invocation_designation)
2313 (encode_designation_at_bol, encode_coding_iso_2022)
2314 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2315 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2316 Declare EMACS_INT.
2317 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2318 (encode_invocation_designation): Last argument P_NCHARS is now
2319 EMACS_INT.
2320 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2321 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2322
2323 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2324 All users changed.
2325
2326 * ccl.c (Fccl_execute_on_string): Declare some variables
2327 EMACS_INT.
2328
2329 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2330
2331 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2332
2333 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2334
2335 * process.c (Fformat_network_address): Doc fix.
2336
2337 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2338
2339 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2340
2341 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2342
2343 * keyboard.c (read_char): Call Lisp function help-form-show,
2344 instead of using internal_with_output_to_temp_buffer.
2345 (Qhelp_form_show): New var.
2346 (syms_of_keyboard): Use DEFSYM macro.
2347
2348 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2349
2350 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2351
2352 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2353
2354 * process.c (Flist_processes): Remove to Lisp.
2355 (list_processes_1): Delete.
2356
2357 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2358
2359 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2360
2361 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2362
2363 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2364
2365 Fix more problems found by GCC 4.6.0's static checks.
2366
2367 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2368
2369 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2370
2371 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2372
2373 * xdisp.c (vmessage): Mark as a printf-like function.
2374
2375 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2376
2377 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2378
2379 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2380 printf-like functions.
2381 (tiff_load): Add casts to remove these marks before passing them
2382 to system-supplied API.
2383
2384 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2385
2386 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2387 This avoids several warnings with gcc -Wstrict-overflow.
2388 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2389 directly, rather than having caller test rule sign. This avoids
2390 some unnecessary tests.
2391 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2392 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2393 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2394
2395 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2396 (xfont_open): Avoid unnecessary tests.
2397
2398 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2399
2400 * composite.h, composite.c (composition_gstring_put_cache):
2401 Use EMACS_INT, not int, for length.
2402
2403 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2404 breaking out part of COMPOSITION_DECODE_RULE.
2405 (COMPOSITION_DECODE_RULE): Use it.
2406 * composite.c (get_composition_id): Remove unused local vars,
2407 by using the new macro.
2408
2409 * textprop.c (set_text_properties_1): Change while to do-while,
2410 since the condition is always true at first.
2411
2412 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2413 (interval_deletion_adjustment): Return unsigned value.
2414 All uses changed.
2415
2416 * process.c (list_processes_1, create_pty, read_process_output):
2417 (exec_sentinel): Remove vars that were set but not used.
2418 (create_pty): Remove unnecessary "volatile"s.
2419 (Fnetwork_interface_info): Avoid possibility of int overflow.
2420 (read_process_output): Do adaptive read buffering even if carryover.
2421 (read_process_output): Simplify nbytes computation if buffered.
2422
2423 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2424
2425 * syntax.c (scan_words): Remove var that was set but not used.
2426 (update_syntax_table): Use unsigned instead of int.
2427
2428 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2429 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2430 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2431
2432 * print.c (print_error_message): Avoid int overflow.
2433
2434 * font.c (font_list_entities): Redo for clarity,
2435 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2436
2437 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2438 (font_score): Avoid potential overflow in diff calculation.
2439
2440 * fns.c (substring_both): Remove var that is set but not used.
2441 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2442
2443 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2444
2445 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2446 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2447 can always succeed if overflow has undefined behavior.
2448
2449 * search.c (boyer_moore, wordify): Remove vars set but not used.
2450 (wordify): Omit three unnecessary tests.
2451
2452 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2453 All callers changed. This avoids the need for an unused var.
2454
2455 * casefiddle.c (casify_region): Remove var that is set but not used.
2456
2457 * dired.c (file_name_completion): Remove var that is set but not used.
2458
2459 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2460
2461 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2462 (Finsert_file_contents): Remove unnecessary code checking fd.
2463
2464 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2465 Check for integer overflow on size calculations.
2466
2467 * buffer.c (Fprevious_overlay_change): Remove var that is set
2468 but not used.
2469
2470 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2471 Remove vars that are set but not used.
2472 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2473 (timer_check_2): Mark vars as initialized.
2474
2475 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2476
2477 * image.c (lookup_image): Remove var that is set but not used.
2478 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2479
2480 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2481 that are set but not used.
2482
2483 * xfns.c (make_invisible_cursor): Don't return garbage
2484 if XCreateBitmapFromData fails (Bug#8410).
2485
2486 * xselect.c (x_get_local_selection, x_handle_property_notify):
2487 Remove vars that are set but not used.
2488
2489 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2490 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2491
2492 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2493 Remove var that is set but not used.
2494 (scroll_bar_windows_size): Now size_t, not int.
2495 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2496 Check for overflow.
2497
2498 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2499 (map_tty_color) [!defined MSDOS]: Likewise.
2500
2501 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2502
2503 * coding.c: Remove vars that are set but not used.
2504 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2505 All callers changed.
2506 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2507 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2508 (decode_coding_charset): Remove vars that are set but not used.
2509
2510 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2511 that is set but not used.
2512
2513 * print.c (print_object): Remove var that is set but not used.
2514
2515 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2516 The gnulib version avoids calling malloc in the usual case,
2517 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2518 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2519 * filelock.c (current_lock_owner): Likewise.
2520 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2521 * sysdep.c: Include allocator.h, careadlinkat.h.
2522 (emacs_no_realloc_allocator): New static constant.
2523 (emacs_readlink): New function.
2524 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2525 ../lib/careadlinkat.h.
2526
2527 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2528
2529 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2530 first non-nil return value).
2531
2532 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2533
2534 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2535 if not defined (Bug#8403).
2536
2537 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2538
2539 * xdisp.c (display_count_lines): Remove parameter `start',
2540 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2541 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2542 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2543 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2544 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2545 and thereabouts. All callers changed.
2546 (get_per_char_metric): Remove parameter `f', unused since
2547 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2548
2549 2011-04-02 Jim Meyering <meyering@redhat.com>
2550
2551 do not dereference NULL upon failed strdup
2552 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2553 (ns_get_family): Likewise.
2554
2555 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2556
2557 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2558
2559 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2560
2561 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2562 later (Bug#8403).
2563
2564 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2565
2566 Add lexical binding.
2567
2568 * window.c (Ftemp_output_buffer_show): New fun.
2569 (Fsave_window_excursion):
2570 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2571
2572 * lread.c (lisp_file_lexically_bound_p): New function.
2573 (Fload): Bind Qlexical_binding.
2574 (readevalloop): Remove `evalfun' arg.
2575 Bind Qinternal_interpreter_environment.
2576 (Feval_buffer): Bind Qlexical_binding.
2577 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2578 Mark as dynamic.
2579 (syms_of_lread): Declare `lexical-binding'.
2580
2581 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2582
2583 * keyboard.c (eval_dyn): New fun.
2584 (menu_item_eval_property): Use it.
2585
2586 * image.c (parse_image_spec): Use Ffunctionp.
2587
2588 * fns.c (concat, mapcar1): Accept byte-code-functions.
2589
2590 * eval.c (Fsetq): Handle lexical vars.
2591 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2592 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2593 (FletX, Flet): Obey lexical binding.
2594 (Fcommandp): Handle closures.
2595 (Feval): New `lexical' arg.
2596 (eval_sub): New function extracted from Feval. Use it almost
2597 everywhere where Feval was used. Look up vars in lexical env.
2598 Handle closures.
2599 (Ffunctionp): Move from subr.el.
2600 (Ffuncall): Handle closures.
2601 (apply_lambda): Remove `eval_flags'.
2602 (funcall_lambda): Handle closures and new byte-code-functions.
2603 (Fspecial_variable_p): New function.
2604 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2605 but without exporting it to Lisp.
2606
2607 * doc.c (Fdocumentation, store_function_docstring):
2608 * data.c (Finteractive_form): Handle closures.
2609
2610 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2611 interactive spec.
2612
2613 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2614 New byte-codes.
2615 (exec_byte_code): New function extracted from Fbyte_code to handle new
2616 calling convention for byte-code-functions. Add new byte-codes.
2617
2618 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2619
2620 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2621
2622 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2623
2624 * xdisp.c (redisplay_internal): Fix prototype.
2625
2626 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2627
2628 * xdisp.c (SCROLL_LIMIT): New macro.
2629 (try_scrolling): Use it when setting scroll_limit.
2630 Limit scrolling to 100 screen lines.
2631 (redisplay_window): Even when falling back on "recentering",
2632 position point in the window according to scroll-conservatively,
2633 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2634
2635 (try_scrolling): When point is above the window, allow searching
2636 as far as scroll_max, or one screenful, to compute vertical
2637 distance from PT to the scroll margin position. This prevents
2638 try_scrolling from unnecessarily failing when
2639 scroll-conservatively is set to a value slightly larger than the
2640 window height. Clean up the case of PT below the margin at bottom
2641 of window: scroll_max can no longer be INT_MAX. When aggressive
2642 scrolling is in use, don't let point enter the opposite scroll
2643 margin as result of the scroll.
2644 (syms_of_xdisp) <scroll-conservatively>: Document the
2645 threshold of 100 lines for never-recentering scrolling.
2646
2647 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2648
2649 * dispextern.h (move_it_by_lines):
2650 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2651 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2652 (message_log_check_duplicate): Remove parameters `prev_bol' and
2653 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2654 (redisplay_internal): Remove parameter `preserve_echo_area',
2655 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2656
2657 * indent.c (Fvertical_motion):
2658 * window.c (window_scroll_pixel_based, Frecenter):
2659 Don't pass `need_y_p' to `move_it_by_lines'.
2660
2661 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2662
2663 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2664 steal a few bits to be more compact.
2665 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2666 Remove unneeded casts.
2667
2668 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2669
2670 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2671
2672 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2673 binding" message (bug#7967).
2674
2675 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2676
2677 Fix more problems found by GCC 4.6.0's static checks.
2678
2679 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2680 Remove unused local var.
2681
2682 * editfns.c (Fmessage_box): Remove unused local var.
2683
2684 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2685 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2686 Omit unused local vars.
2687 * window.c (shrink_windows): Omit unused local var.
2688 * menu.c (digest_single_submenu): Omit unused local var.
2689 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2690 Omit unused local var.
2691
2692 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2693 Don't assume string length fits in int.
2694 (keyremap_step, read_key_sequence): Use size_t for sizes.
2695 (read_key_sequence): Don't check last_real_key_start redundantly.
2696
2697 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2698 instead of alloca (Bug#8344).
2699
2700 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2701 (Fbacktrace_frame): Don't assume nframes fits in int.
2702
2703 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2704
2705 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2706 concerns.
2707
2708 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2709
2710 * cm.c (calccost): Turn while-do into do-while, for clarity.
2711
2712 * keyboard.c (syms_of_keyboard): Use the same style as later
2713 in this function when indexing through an array. This also
2714 works around GCC bug 48267.
2715
2716 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2717
2718 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2719
2720 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2721 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2722
2723 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2724 This avoids undefined behavior on integer overflow, and is a bit
2725 more convenient anyway since it is compared to a size_t variable.
2726
2727 Variadic C functions now count arguments with size_t, not int.
2728 This avoids an unnecessary limitation on 64-bit machines, which
2729 caused (substring ...) to crash on large vectors (Bug#8344).
2730 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2731 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2732 All variadic functions and their callers changed accordingly.
2733 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2734 * data.c (arith_driver, float_arith_driver): Likewise.
2735 * editfns.c (general_insert_function): Likewise.
2736 * eval.c (struct backtrace.nargs, interactive_p)
2737 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2738 (funcall_lambda, mark_backtrace): Likewise.
2739 * fns.c (concat): Likewise.
2740 * frame.c (x_set_frame_parameters): Likewise.
2741 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2742 0 if not found, not -1. All callers changed.
2743
2744 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2745 (stack_copy_size): Now size_t, not int.
2746 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2747
2748 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2749
2750 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2751 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2752 All callers changed.
2753
2754 * lisp.h (multibyte_char_to_unibyte):
2755 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2756 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2757 * character.h (CHAR_TO_BYTE8):
2758 * cmds.c (internal_self_insert):
2759 * editfns.c (general_insert_function):
2760 * keymap.c (push_key_description):
2761 * search.c (Freplace_match):
2762 * xdisp.c (message_dolog, set_message_1): All callers changed.
2763
2764 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2765
2766 * keyboard.c (safe_run_hook_funcall): New function.
2767 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2768 don't set the hook to nil, but remove the offending function instead.
2769 (Qcommand_hook_internal): Remove, unused.
2770 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2771 Vcommand_hook_internal.
2772
2773 * eval.c (enum run_hooks_condition): Remove.
2774 (funcall_nil, funcall_not): New functions.
2775 (run_hook_with_args): Call each function through a `funcall' argument.
2776 Remove `cond' argument, now redundant.
2777 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2778 (Frun_hook_with_args_until_failure): Adjust accordingly.
2779 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2780
2781 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2782
2783 * dispextern.h (string_buffer_position): Remove declaration.
2784
2785 * print.c (strout): Remove parameter `multibyte', unused since
2786 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2787
2788 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2789 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2790 All callers changed.
2791
2792 * w32.c (_wsa_errlist): Use braces for struct initializers.
2793
2794 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2795 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2796 All callers changed.
2797 (string_buffer_position): Likewise. Also, make static (it's never
2798 used outside xdisp.c).
2799 (cursor_row_p): Remove parameter `w', unused since
2800 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2801 (decode_mode_spec): Remove parameter `precision', introduced during
2802 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2803 All callers changed.
2804
2805 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2806
2807 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2808
2809 2011-03-27 Anders Lindgren <andlind@gmail.com>
2810
2811 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2812 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2813 (ns_update_auto_hide_menu_bar): New functions.
2814 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2815 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2816 ns_constrain_all_frames.
2817 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2818 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2819
2820 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2821
2822 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2823
2824 2011-03-27 Glenn Morris <rgm@gnu.org>
2825
2826 * syssignal.h: Replace RETSIGTYPE with void.
2827 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2828 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2829 Replace SIGTYPE with void everywhere.
2830 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2831 * s/template.h (SIGTYPE): Remove commented out definition.
2832
2833 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2834
2835 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2836 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2837
2838 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2839
2840 * w32.c (read_unc_volume): Use parameter `henum', instead of
2841 global variable `wget_enum_handle'.
2842
2843 * keymap.c (describe_vector): Remove parameters `indices' and
2844 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2845 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2846
2847 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2848
2849 * keyboard.c (timer_check): Remove parameter `do_it_now',
2850 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2851 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2852 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2853
2854 * keyboard.c (read_char):
2855 * w32menu.c (w32_menu_display_help):
2856 * xmenu.c (show_help_event, menu_help_callback):
2857 Adjust calls to `show_help_echo'.
2858
2859 * gtkutil.c (xg_maybe_add_timer):
2860 * keyboard.c (readable_events):
2861 * process.c (wait_reading_process_output):
2862 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2863
2864 * insdel.c (adjust_markers_gap_motion):
2865 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2866 (gap_left, gap_right): Don't call it.
2867
2868 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2869
2870 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2871 incurred during fontification.
2872
2873 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2874
2875 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2876 (DEFVAR_PER_BUFFER): Don't pass it.
2877
2878 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2879 (scrolling_window): Don't pass it.
2880
2881 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2882
2883 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2884
2885 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2886 and `suffix'.
2887 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2888 of variables specific to SELinux and computation of `encoded_absname'.
2889
2890 * image.c (XPutPixel): Remove unused variable `height'.
2891
2892 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2893
2894 * unexw32.c (get_section_info): Remove unused variable `section'.
2895
2896 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2897 (system_process_attributes): Remove unused variable `sess'.
2898 (sys_read): Remove unused variable `err'.
2899
2900 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2901 (w32_wnd_proc): Remove unused variable `isdead'.
2902 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2903 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2904 (x_create_tip_frame): Remove unused variable `tem'.
2905
2906 * w32inevt.c (w32_console_read_socket):
2907 Remove unused variable `no_events'.
2908
2909 * w32term.c (x_draw_composite_glyph_string_foreground):
2910 Remove unused variable `width'.
2911
2912 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2913
2914 * w32term.c (x_set_glyph_string_clipping):
2915 Don't pass uninitialized region to CombineRgn.
2916
2917 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2918
2919 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2920 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2921 (Fx_close_connection): Remove unused variable `i'.
2922
2923 * w32font.c (w32font_draw): Return number of glyphs.
2924 (w32font_open_internal): Remove unused variable `i'.
2925 (w32font_driver): Add missing initializer.
2926
2927 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2928 (fill_in_menu): Remove unused variable `items_added'.
2929
2930 * w32term.c (last_mouse_press_frame): Remove static global variable.
2931 (w32_clip_to_row): Remove unused variable `f'.
2932 (x_delete_terminal): Remove unused variable `i'.
2933
2934 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2935 (NOTHING): Remove unused static global variable.
2936 (uniscribe_check_otf): Remove unused variable `table'.
2937 (uniscribe_font_driver): Add missing initializers.
2938
2939 2011-03-23 Julien Danjou <julien@danjou.info>
2940
2941 * term.c (Fsuspend_tty, Fresume_tty):
2942 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2943 * window.c (temp_output_buffer_show):
2944 * insdel.c (signal_before_change):
2945 * frame.c (Fhandle_switch_frame):
2946 * fileio.c (Fdo_auto_save):
2947 * emacs.c (Fkill_emacs):
2948 * editfns.c (save_excursion_restore):
2949 * cmds.c (internal_self_insert):
2950 * callint.c (Fcall_interactively):
2951 * buffer.c (Fkill_all_local_variables):
2952 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2953 Use Frun_hooks.
2954 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2955 unconditionnaly since it does the check itself.
2956
2957 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2958
2959 Fix more problems found by GCC 4.5.2's static checks.
2960
2961 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2962 the first time through the loop, since we know p0 < p1 then.
2963 This also avoids a gcc -Wstrict-overflow warning.
2964
2965 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2966 leading to a memory leak, possible in functions like
2967 load_charset_map_from_file that can allocate an unbounded number
2968 of objects (Bug#8318).
2969
2970 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2971 that could (at least in theory) be that large.
2972
2973 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2974 This is less likely to overflow, and avoids undefined behavior if
2975 overflow does occur. All callers changed. Use strtoul to scan
2976 for the unsigned long integer.
2977 (pint2hrstr): Simplify and tune code slightly.
2978 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2979
2980 * scroll.c (do_scrolling): Work around GCC bug 48228.
2981 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2982
2983 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2984 This also avoids a warning with gcc -Wstrict-overflow.
2985 (validate_x_resource_name): Simplify count usage.
2986 This also avoids a warning with gcc -Wstrict-overflow.
2987
2988 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2989 fail (Bug#8306).
2990
2991 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2992
2993 * process.c (Fmake_network_process): Use socklen_t, not int,
2994 where POSIX says socklen_t is required in portable programs.
2995 This fixes a porting bug on hosts like 64-bit HP-UX, where
2996 socklen_t is wider than int (Bug#8277).
2997 (Fmake_network_process, server_accept_connection):
2998 (wait_reading_process_output, read_process_output):
2999 Likewise.
3000
3001 * process.c: Rename or move locals to avoid shadowing.
3002 (list_processes_1, Fmake_network_process):
3003 (read_process_output_error_handler, exec_sentinel_error_handler):
3004 Rename or move locals.
3005 (Fmake_network_process): Define label "retry_connect" only if needed.
3006 (Fnetwork_interface_info): Fix pointer signedness.
3007 (process_send_signal): Add cast to avoid pointer signedness problem.
3008 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3009 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3010
3011 Make tparam.h and terminfo.c consistent.
3012 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3013 Include tparam.h instead, since it declares them.
3014 * cm.h (PC): Remove extern decl; tparam.h now does this.
3015 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3016 * terminfo.c: Include tparam.h, to check interfaces.
3017 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3018 (tparam): Adjust signature to match interface in tparam.h;
3019 this removes some undefined behavior. Check that outstring and len
3020 are zero, which they always are with Emacs.
3021 * tparam.h (PC, BC, UP): New extern decls.
3022
3023 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3024 (xftfont_open): Rename locals to avoid shadowing.
3025
3026 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3027 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3028 (OTF_TAG_SYM): Omit macro if not needed.
3029 (ftfont_list): Remove unused local.
3030 (get_adstyle_property, ftfont_pattern_entity):
3031 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3032 Rename locals to avoid shadowing.
3033
3034 * xfont.c (xfont_list_family): Mark var as initialized.
3035
3036 * xml.c (make_dom): Now static.
3037
3038 * composite.c (composition_compute_stop_pos): Rename local to
3039 avoid shadowing.
3040 (composition_reseat_it): Remove unused locals.
3041 (find_automatic_composition, composition_adjust_point): Likewise.
3042 (composition_update_it): Mark var as initialized.
3043 (find_automatic_composition): Mark vars as initialized,
3044 with a FIXME (Bug#8290).
3045
3046 character.h: Rename locals to avoid shadowing.
3047 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3048 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3049 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3050 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3051 to avoid shadowing.
3052
3053 * textprop.c (property_change_between_p): Remove; unused.
3054
3055 * intervals.c (interval_start_pos): Now static.
3056
3057 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3058
3059 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3060 Rename locals to avoid shadowing.
3061
3062 * sound.c (wav_play, au_play, Fplay_sound_internal):
3063 Fix pointer signedness.
3064 (alsa_choose_format): Remove unused local var.
3065 (wav_play): Initialize a variable to 0, to prevent undefined
3066 behavior (Bug#8278).
3067
3068 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3069
3070 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3071
3072 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3073 clobbering (Bug#8298).
3074 * sysdep.c (sys_subshell): Likewise.
3075 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3076
3077 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3078 This should get cleaned up, so that child_setup has the
3079 same signature on all platforms.
3080
3081 * callproc.c (call_process_cleanup): Now static.
3082 (relocate_fd): Rename locals to avoid shadowing.
3083
3084 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3085
3086 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3087 not to be necessary, and produces flickering.
3088
3089 2011-03-20 Glenn Morris <rgm@gnu.org>
3090
3091 * config.in: Remove file.
3092
3093 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3094
3095 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3096 are now in src/globals.h.
3097 (syms_of_minibuf): Remove spurious & from previous change.
3098
3099 2011-03-20 Leo <sdl.web@gmail.com>
3100
3101 * minibuf.c (completing-read-function): New variable.
3102 (completing-read-default): Rename from completing-read.
3103 (completing-read): Call completing-read-function.
3104
3105 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3106
3107 * xfaces.c (Fx_load_color_file):
3108 Read color file from absolute filename (bug#8250).
3109
3110 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3111
3112 * makefile.w32-in: Update dependencies.
3113
3114 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3115
3116 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3117
3118 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3119
3120 Fix more problems found by GCC 4.5.2's static checks.
3121
3122 * process.c (make_serial_process_unwind, send_process_trap):
3123 (sigchld_handler): Now static.
3124
3125 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3126 That way, the code declares only the vars that it needs.
3127 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3128 * s/cygwin.h (PTY_ITERATION): Likewise.
3129 * s/darwin.h (PTY_ITERATION): Likewise.
3130 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3131
3132 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3133 * process.c (allocate_pty): Don't declare stb unless it's needed.
3134
3135 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3136 (CONSTANTLIM): Remove; unused.
3137 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3138 Define only if needed.
3139
3140 * unexelf.c (unexec): Name an expression,
3141 to avoid gcc -Wbad-function-cast warning.
3142 Use a different way to cause a compilation error if anyone uses
3143 n rather than nn, a way that does not involve shadowing.
3144 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3145
3146 * deps.mk (unexalpha.o): Remove; unused.
3147
3148 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3149 * unexec.h: New file.
3150 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3151 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3152 Depend on unexec.h.
3153 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3154 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3155 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3156 Change as necessary to match prototype in unexec.h.
3157
3158 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3159 shadowing.
3160 (back_comment, skip_chars): Mark vars as initialized.
3161
3162 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3163 Rename locals to avoid shadowing.
3164
3165 * lread.c (read1): Rewrite so as not to use empty "else".
3166 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3167
3168 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3169
3170 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3171 warning when compiling print.c.
3172
3173 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3174 instead of using an uninitialized var.
3175 (font_sort_entities): Mark var as initialized.
3176
3177 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3178
3179 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3180 pointers to constants.
3181 (font_parse_fcname): Remove unused vars.
3182 (font_delete_unmatched): Now static.
3183 (font_get_spec): Remove; unused.
3184 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3185 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3186 Rename or move locals to avoid shadowing.
3187
3188 * fns.c (require_nesting_list, require_unwind): Now static.
3189 (Ffillarray): Rename locals to avoid shadowing.
3190
3191 * floatfns.c (domain_error2): Define only if needed.
3192 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3193
3194 * alloc.c (mark_backtrace): Move decl from here ...
3195 * lisp.h: ... to here, so that it can be checked.
3196
3197 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3198 (Fdefvar): Rewrite so as not to use empty "else".
3199 (lisp_indirect_variable): Name an expression,
3200 to avoid gcc -Wbad-function-cast warning.
3201 (Fdefvar): Rename locals to avoid shadowing.
3202
3203 * callint.c (quotify_arg, quotify_args): Now static.
3204 (Fcall_interactively): Rename locals to avoid shadowing.
3205 Use const pointer when appropriate.
3206
3207 * lisp.h (get_system_name, get_operating_system_release):
3208 Move decls here, to check interfaces.
3209 * process.c (get_operating_system_release): Move decl to lisp.h.
3210 * xrdb.c (get_system_name): Likewise.
3211 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3212 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3213 some of which prompt warnings from gcc -Wbad-function-cast.
3214 (Fformat_time_string, Fencode_time, Finsert_char):
3215 (Ftranslate_region_internal, Fformat):
3216 Rename or remove local vars to avoid shadowing.
3217 (Ftranslate_region_internal): Mark var as initialized.
3218
3219 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3220 avoid shadowing.
3221
3222 * lisp.h (eassert): Check that the argument compiles, even if
3223 ENABLE_CHECKING is not defined.
3224
3225 * data.c (Findirect_variable): Name an expression, to avoid
3226 gcc -Wbad-function-cast warning.
3227 (default_value, arithcompare, arith_driver, arith_error): Now static.
3228 (store_symval_forwarding): Rename local to avoid shadowing.
3229 (Fmake_variable_buffer_local, Fmake_local_variable):
3230 Mark variables as initialized.
3231 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3232
3233 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3234 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3235 Rename locals to avoid shadowing.
3236 (mark_stack): Move local variables into the #ifdef region where
3237 they're used.
3238 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3239 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3240 needed otherwise.
3241 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3242 (GC_STRING_CHARS): Remove; not used.
3243 (Fmemory_limit): Cast sbrk's returned value to char *.
3244
3245 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3246 avoids undefined behavior in theory.
3247
3248 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3249
3250 Use functions, not macros, for up- and down-casing (Bug#8254).
3251 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3252 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3253 to use the following functions instead of these macros.
3254 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3255 EMACS_INT, since callers assume the returned value fits in int.
3256 (upcase1): Likewise, for UPCASE_TABLE.
3257 (uppercasep, lowercasep, upcase): New static inline functions.
3258 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3259 the race-condition problem in the old DOWNCASE.
3260
3261 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3262 Rename locals to avoid shadowing.
3263 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3264 (regex_compile, re_search_2, re_match_2_internal):
3265 Remove unused local vars.
3266 (FREE_VAR): Rewrite so as not to use empty "else",
3267 which gcc can warn about.
3268 (regex_compile, re_match_2_internal): Mark locals as initialized.
3269 (RETALLOC_IF): Define only if needed.
3270 (WORDCHAR_P): Likewise. This one is never needed, but is used
3271 only in a comment talking about a compiler bug, so put inside
3272 the #if 0 of that comment.
3273 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3274 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3275 Remove; unused.
3276
3277 * search.c (boyer_moore): Rename locals to avoid shadowing.
3278 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3279 (PREV_CHAR_BOUNDARY): Likewise.
3280
3281 * search.c (simple_search): Remove unused var.
3282
3283 * dired.c (compile_pattern): Move decl from here ...
3284 * lisp.h: ... to here, so that it can be checked.
3285 (struct re_registers): New forward decl.
3286
3287 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3288
3289 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3290 All uses changed.
3291 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3292 Rename locals to avoid shadowing.
3293 (Fvertical_motion): Mark locals as initialized.
3294
3295 * casefiddle.c (casify_object, casify_region): Now static.
3296 (casify_region): Mark local as initialized.
3297
3298 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3299
3300 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3301 New macros, so that the caller can use some names other than
3302 gcpro1, gcpro2, etc.
3303 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3304 of the new macros.
3305 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3306 argument, for consistency with GCPRO2_VAR, etc: it is now the
3307 prefix of the variable, not the variable itself. All uses
3308 changed.
3309 * dired.c (directory_files_internal, file_name_completion):
3310 Rename locals to avoid shadowing.
3311
3312 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3313 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3314 dired.c's scmp function, had undefined behavior.
3315 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3316 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3317 * buffer.h: ... to here, because these macros use current_buffer,
3318 and the new implementation with inline functions needs to have
3319 current_buffer in scope now, rather than later when the macros
3320 are used.
3321 (downcase, upcase1): New static inline functions.
3322 (DOWNCASE, UPCASE1): Reimplement using these functions.
3323 This avoids undefined behavior in expressions like
3324 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3325 from race conditions in accessing the global variables
3326 case_temp1 and case_temp2.
3327 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3328 * lisp.h (case_temp1, case_temp2): Remove their decls.
3329 * character.h (ASCII_CHAR_P): Move from here ...
3330 * lisp.h: ... to here, so that the inline functions mentioned
3331 above can use them.
3332
3333 * dired.c (directory_files_internal_unwind): Now static.
3334
3335 * fileio.c (file_name_as_directory, directory_file_name):
3336 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3337 Now static.
3338 (file_name_as_directory): Use const pointers when appropriate.
3339 (Fexpand_file_name): Likewise. In particular, newdir might
3340 point at constant storage, so make it a const pointer.
3341 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3342 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3343 signedness issues.
3344 (Fset_file_times, Finsert_file_contents, auto_save_error):
3345 Rename locals to avoid shadowing.
3346
3347 * minibuf.c (choose_minibuf_frame_1): Now static.
3348 (Ftry_completion, Fall_completions): Rename or remove locals
3349 to avoid shadowing.
3350
3351 * marker.c (bytepos_to_charpos): Remove; unused.
3352
3353 * lisp.h (verify_bytepos, count_markers): New decls,
3354 so that gcc does not warn that these functions aren't declared.
3355
3356 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3357 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3358 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3359 (copy_text): Remove unused local var.
3360
3361 * filelock.c (within_one_second): Now static.
3362 (lock_file_1): Rename local to avoid shadowing.
3363
3364 * buffer.c (fix_overlays_before): Mark locals as initialized.
3365 (fix_start_end_in_overlays): Likewise. This function should be
3366 simplified by using pointers-to-pointers, but that's a different
3367 matter.
3368 (switch_to_buffer_1): Now static.
3369 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3370 (report_overlay_modification): Rename locals to avoid shadowing.
3371
3372 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3373 Fix pointer signedness issue.
3374 (sys_subshell): Mark local as volatile if checking for lint,
3375 to suppress a gcc -Wclobbered warning that does not seem to be right.
3376 (MAXPATHLEN): Define only if needed.
3377
3378 * process.c (serial_open, serial_configure): Move decls from here ...
3379 * systty.h: ... to here, so that they can be checked.
3380
3381 * fns.c (get_random, seed_random): Move extern decls from here ...
3382 * lisp.h: ... to here, so that they can be checked.
3383
3384 * sysdep.c (reset_io): Now static.
3385 (wait_for_termination_signal): Remove; unused.
3386
3387 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3388 (copy_keymap_item, append_key, push_text_char_description):
3389 Now static.
3390 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3391 (DENSE_TABLE_SIZE): Remove; unused.
3392 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3393 (describe_map_tree):
3394 Rename locals to avoid shadowing.
3395
3396 * keyboard.c: Declare functions static if they are not used elsewhere.
3397 (echo_char, echo_dash, cmd_error, top_level_2):
3398 (poll_for_input, handle_async_input): Now static.
3399 (read_char, kbd_buffer_get_event, make_lispy_position):
3400 (make_lispy_event, make_lispy_movement, apply_modifiers):
3401 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3402 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3403 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3404 (read_key_sequence, read_char): Mark locals as initialized.
3405 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3406
3407 * keyboard.h (make_ctrl_char): New decl.
3408 (mark_kboards): Move decl here ...
3409 * alloc.c (mark_kboards): ... from here.
3410
3411 * lisp.h (force_auto_save_soon): New decl.
3412
3413 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3414 (DEFINE_DUMMY_FUNCTION): New macro.
3415 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3416 Use it.
3417 (main): Add casts to avoid warnings
3418 if GCC considers string literals to be constants.
3419
3420 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3421
3422 * dbusbind.c: Pointer signedness fixes.
3423 (xd_signature, xd_append_arg, xd_initialize):
3424 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3425 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3426 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3427 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3428
3429 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3430 if GCC considers string literals to be constants.
3431 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3432
3433 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3434
3435 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3436 (print_preprocess, print_object): New macro to fix last change.
3437
3438 * print.c (print_preprocess): Don't forget font objects.
3439
3440 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3441
3442 * emacs.c (USAGE3): Doc fixes.
3443
3444 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3445
3446 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3447 structure.
3448
3449 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3450
3451 * lisp.h (VWindow_system, Qfile_name_history):
3452 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3453 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3454 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3455
3456 * w32select.c: Don't #include "keyboard.h".
3457 (run_protected): Add extern declaration for waiting_for_input.
3458
3459 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3460 * w32console.c (detect_input_pending, read_input_pending)
3461 (encode_terminal_code):
3462 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3463 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3464 (w32_system_caret_y, Qfile_name_history):
3465 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3466 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3467 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3468 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3469 * w32proc.c (Qlocal, report_file_error):
3470 * w32term.c (Vwindow_system, updating_frame):
3471 * w32uniscribe.c (initialized, uniscribe_font_driver):
3472 Remove unneeded extern declarations.
3473
3474 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3475
3476 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3477
3478 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3479
3480 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3481 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3482 These macros can no longer be used for assignment.
3483
3484 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3485 Assign struct members directly, instead of using BUF_BEGV etc.
3486 (record_buffer_markers, fetch_buffer_markers): New functions for
3487 recording and fetching special buffer markers.
3488 (set_buffer_internal_1, set_buffer_temp): Use them.
3489
3490 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3491
3492 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3493
3494 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3495 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3496
3497 * xdisp.c (hscroll_window_tree):
3498 (reconsider_clip_changes): Use PT instead of BUF_PT.
3499
3500 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3501
3502 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3503 $(EMACS_ROOT)/lib/intprops.h.
3504
3505 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3506
3507 Fix more problems found by GCC 4.5.2's static checks.
3508
3509 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3510 to unsigned char * to avoid compiler diagnostic.
3511 (xg_free_frame_widgets): Make it clear that a local variable is
3512 needed only if USE_GTK_TOOLTIP.
3513 (gdk_window_get_screen): Make it clear that this macro is needed
3514 only if USE_GTK_TOOLTIP.
3515 (int_gtk_range_get_value): New function, which avoids a diagnostic
3516 from gcc -Wbad-function-cast.
3517 (xg_set_toolkit_scroll_bar_thumb): Use it.
3518 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3519 diagnostic from gcc -Wbad-function-cast.
3520 (get_utf8_string, xg_get_file_with_chooser):
3521 Rename locals to avoid shadowing.
3522 (create_dialog): Move locals to avoid shadowing.
3523
3524 * xgselect.c (xg_select): Remove unused var.
3525
3526 * image.c (four_corners_best): Mark locals as initialized.
3527 (gif_load): Initialize transparent_p to zero (Bug#8238).
3528 Mark another local as initialized.
3529 (my_png_error, my_error_exit): Mark with NO_RETURN.
3530
3531 * image.c (clear_image_cache): Now static.
3532 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3533 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3534 (x_edge_detection): Remove unnecessary cast that
3535 gcc -Wbad-function-cast diagnoses.
3536 (gif_load): Fix pointer signedness.
3537 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3538 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3539
3540 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3541
3542 Improve quality of tests for time stamp overflow.
3543 For example, without this patch (encode-time 0 0 0 1 1
3544 1152921504606846976) returns the obviously-bogus value (-948597
3545 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3546 reports time overflow. See
3547 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3548 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3549 * editfns.c: Include limits.h and intprops.h.
3550 (TIME_T_MIN, TIME_T_MAX): New macros.
3551 (time_overflow): Move earlier, to before first use.
3552 (hi_time, lo_time): New functions, for an accurate test for
3553 out-of-range times.
3554 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3555 (Fget_internal_run_time): Don't assume time_t fits in int.
3556 (make_time): Use list2 instead of Fcons twice.
3557 (Fdecode_time): More accurate test for out-of-range times.
3558 (check_tm_member): New function.
3559 (Fencode_time): Use it, to test for out-of-range times.
3560 (lisp_time_argument): Don't rely on undefined left-shift and
3561 right-shift behavior when checking for time stamp overflow.
3562
3563 * editfns.c (time_overflow): New function, refactoring common code.
3564 (Fformat_time_string, Fdecode_time, Fencode_time):
3565 (Fcurrent_time_string): Use it.
3566
3567 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3568 * dired.c (make_time): Move to ...
3569 * editfns.c (make_time): ... here.
3570 * systime.h: Note the move.
3571
3572 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3573
3574 * fringe.c (update_window_fringes): Remove unused variables.
3575
3576 * unexmacosx.c (copy_data_segment): Also copy __got section.
3577 (Bug#8223)
3578
3579 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3580
3581 * termcap.c [MSDOS]: Include "msdos.h".
3582 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3583 Constify `char *' arguments and their references according to
3584 prototypes in tparam.h.
3585
3586 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3587
3588 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3589 Adapt all references accordingly.
3590
3591 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3592
3593 2011-03-11 Tom Tromey <tromey@redhat.com>
3594
3595 * buffer.c (syms_of_buffer): Remove obsolete comment.
3596
3597 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3598
3599 * termhooks.h (encode_terminal_code): Declare prototype.
3600
3601 * msdos.c (encode_terminal_code): Don't declare prototype.
3602
3603 * term.c (encode_terminal_code): Now external again, used by
3604 w32console.c and msdos.c.
3605
3606 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3607 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3608
3609 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3610
3611 Fix some minor problems found by GCC 4.5.2's static checks.
3612
3613 * fringe.c (update_window_fringes): Mark locals as initialized
3614 (Bug#8227).
3615 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3616
3617 * alloc.c (mark_fringe_data): Move decl from here ...
3618 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3619 to check its interface.
3620 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3621
3622 * fontset.c (free_realized_fontset): Now static.
3623 (Fset_fontset_font): Rename local to avoid shadowing.
3624 (fontset_font): Mark local as initialized.
3625 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3626
3627 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3628
3629 * xselect.c (x_disown_buffer_selections): Remove; not used.
3630 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3631 (x_own_selection, Fx_disown_selection_internal): Rename locals
3632 to avoid shadowing.
3633 (x_handle_dnd_message): Remove local to avoid shadowing.
3634
3635 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3636 so that the caller can use some name other than gcpro1.
3637 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3638 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3639 (Fx_backspace_delete_keys_p):
3640 Use them to avoid shadowing, and rename vars to avoid shadowing.
3641 (x_decode_color, x_set_name, x_window): Now static.
3642 (Fx_create_frame): Add braces to silence GCC warning.
3643 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3644 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3645 Remove unused locals.
3646 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3647 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3648 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3649 macros.
3650
3651 * xterm.h (x_mouse_leave): New decl.
3652
3653 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3654 Remove unused functions.
3655 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3656 (x_calc_absolute_position): Now static.
3657 (XTread_socket): Don't define label "out" unless it's used.
3658 Don't declare local "event" unless it's used.
3659 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3660 unless they are used.
3661 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3662 (x_fatal_error_signal): Remove; not used.
3663 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3664 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3665 (x_error_catcher, x_connection_closed, x_error_handler):
3666 (x_error_quitter, xembed_send_message, x_iconify_frame):
3667 (my_log_handler): Rename locals to avoid shadowing.
3668 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3669 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3670
3671 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3672 Rename or move locals to avoid shadowing.
3673 (tty_defined_color, merge_face_heights): Now static.
3674 (free_realized_faces_for_fontset): Remove; not used.
3675 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3676 does not deduce is never used uninitialized.
3677 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3678 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3679
3680 * terminal.c (store_terminal_param): Now static.
3681
3682 * xmenu.c (menu_highlight_callback): Now static.
3683 (set_frame_menubar): Remove unused local.
3684 (xmenu_show): Rename parameter to avoid shadowing.
3685 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3686 since they might point to immutable storage.
3687 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3688 since it's unused otherwise.
3689
3690 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3691 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3692 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3693 avoids a gcc -Wuninitialized diagnostic.
3694 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3695 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3696 does not deduce are never used uninitialized.
3697
3698 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3699
3700 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3701 * window.c (window_loop, size_window):
3702 (run_window_configuration_change_hook, enlarge_window): Likewise.
3703
3704 * window.c (display_buffer): Now static.
3705 (size_window): Mark variables that gcc -Wuninitialized
3706 does not deduce are never used uninitialized.
3707 * window.h (check_all_windows): New decl, to forestall
3708 gcc -Wmissing-prototypes diagnostic.
3709 * dispextern.h (bidi_dump_cached_states): Likewise.
3710
3711 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3712 shadowing.
3713 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3714 Include <limits.h>.
3715 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3716 and to avoid gcc -Wuninitialized warning.
3717 (load_charset_map): Mark variables that gcc -Wuninitialized
3718 does not deduce are never used uninitialized.
3719 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3720
3721 * coding.c (coding_set_source, coding_set_destination):
3722 Use "else { /* comment */ }" rather than "else /* comment */;"
3723 for clarity, and to avoid gcc -Wempty-body warning.
3724 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3725 a block, when the outer 'i' will do.
3726 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3727 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3728 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3729 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3730 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3731 Rename locals to avoid shadowing.
3732 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3733 * coding.c (emacs_mule_char, encode_invocation_designation):
3734 Now static, since they're not used elsewhere.
3735 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3736 (decode_coding_object, encode_coding_object, detect_coding_system):
3737 (decode_coding_emacs_mule): Mark variables that gcc
3738 -Wuninitialized does not deduce are never used uninitialized.
3739 (detect_coding_iso_2022): Initialize a local variable that might
3740 be used uninitialized. Leave a FIXME because it's not clear that
3741 this initialization is needed. (Bug#8211)
3742 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3743 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3744 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3745 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3746 Remove unused macros.
3747
3748 * category.c (hash_get_category_set): Remove unused local var.
3749 (copy_category_table): Now static, since it's not used elsewhere.
3750 * character.c (string_count_byte8): Likewise.
3751
3752 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3753 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3754
3755 * chartab.c (copy_sub_char_table): Now static, since it's not used
3756 elsewhere.
3757 (sub_char_table_ref_and_range, char_table_ref_and_range):
3758 Rename locals to avoid shadowing.
3759 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3760
3761 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3762 (BIDI_BOB): Remove unused macro.
3763
3764 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3765 deduce are never used uninitialized.
3766 * term.c (encode_terminal_code): Likewise.
3767
3768 * term.c (encode_terminal_code): Now static. Remove unused local.
3769
3770 * tparam.h: New file.
3771 * term.c, tparam.h: Include it.
3772 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3773 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3774 Move these decls to tparam.h, and make them agree with what
3775 is actually in tparam.c. The previous trick of using incompatible
3776 decls in different modules does not conform to the C standard.
3777 All callers of tparam changed to use tparam's actual API.
3778 * tparam.c (tparam1, tparam, tgoto):
3779 Use const pointers where appropriate.
3780
3781 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3782 * cm.h (struct cm): Likewise.
3783 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3784 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3785 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3786 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3787 (turn_on_face, init_tty): Likewise.
3788 * termchar.h (struct tty_display_info): Likewise.
3789
3790 * term.c (term_mouse_position): Rename local to avoid shadowing.
3791
3792 * alloc.c (mark_ttys): Move decl from here ...
3793 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3794
3795 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3796
3797 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3798
3799 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3800
3801 * search.c (compile_pattern_1): Remove argument regp, unused since
3802 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3803 (compile_pattern): Don't pass it.
3804
3805 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3806
3807 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3808 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3809 for ! HAVE_GTK3.
3810 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3811
3812 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3813
3814 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3815 gdk_window_get_screen, gdk_window_get_geometry,
3816 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3817 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3818 (xg_get_pixbuf_from_pixmap): New function.
3819 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3820 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3821 Call xg_get_pixbuf_from_pixmap instead of
3822 gdk_pixbuf_get_from_drawable.
3823 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3824 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3825 (xg_check_special_colors): Use GtkStyleContext and its functions
3826 for HAVE_GTK3.
3827 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3828 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3829 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3830 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3831 Call gtk_widget_get_preferred_size.
3832 (xg_frame_resized): gdk_window_get_geometry only takes 5
3833 parameters.
3834 (xg_win_to_widget, xg_event_is_for_menubar):
3835 Call gdk_x11_window_lookup_for_display.
3836 (xg_set_widget_bg): New function.
3837 (delete_cb): New function.
3838 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3839 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3840 (xg_set_background_color): Call xg_set_widget_bg.
3841 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3842 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3843 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3844 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3845 if ! HAVE_GTK3.
3846 (update_frame_tool_bar): Call gtk_widget_hide.
3847 (xg_initialize): Use GDK_KEY_g.
3848
3849 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3850 if ! HAVE_GTK3
3851 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3852
3853 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3854 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3855 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3856
3857 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3858
3859 * w32xfns.c (select_palette): Check success of RealizePalette against
3860 GDI_ERROR, not zero.
3861
3862 See ChangeLog.11 for earlier changes.
3863
3864 ;; Local Variables:
3865 ;; coding: utf-8
3866 ;; End:
3867
3868 Copyright (C) 2011 Free Software Foundation, Inc.
3869
3870 This file is part of GNU Emacs.
3871
3872 GNU Emacs is free software: you can redistribute it and/or modify
3873 it under the terms of the GNU General Public License as published by
3874 the Free Software Foundation, either version 3 of the License, or
3875 (at your option) any later version.
3876
3877 GNU Emacs is distributed in the hope that it will be useful,
3878 but WITHOUT ANY WARRANTY; without even the implied warranty of
3879 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3880 GNU General Public License for more details.
3881
3882 You should have received a copy of the GNU General Public License
3883 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.