1 2011-04-19 Paul Eggert <eggert@cs.ucla.edu>
3 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4 (gnutls_make_error): Rename local to avoid shadowing.
5 (gnutls_emacs_global_deinit): ifdef out; not used.
6 (Fgnutls_boot): Use const for pointer to readonly storage.
7 Comment out unused local. Fix pointer signedness problems.
9 * lread.c (openp): Don't stuff size_t into an 'int'.
10 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11 about possible signed overflow.
13 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14 (GDK_KEY_g): Don't define if already defined.
15 (xg_prepare_tooltip): Avoid pointer signedness problem.
16 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
18 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
19 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
21 * xfns.c (Fx_window_property): Simplify a bit,
22 to make a bit faster and to avoid GCC 4.6.0 warning.
23 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
25 * fns.c (internal_equal): Don't assume size_t fits in int.
27 * alloc.c (compact_small_strings): Tighten assertion a little.
29 Replace pEd with more-general pI, and fix some printf arg casts.
30 * lisp.h (pI): New macro, generalizing old pEd macro to other
31 conversion specifiers. For example, use "...%"pI"d..." rather
33 (pEd): Remove. All uses replaced with similar uses of pI.
34 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
35 * alloc.c (check_pure_size): Don't overflow by converting size to int.
36 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
37 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
38 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
39 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
40 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
42 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
43 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
44 * print.c (safe_debug_print, print_object): Likewise.
45 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
47 Use pI instead of if-then-else-abort. Use %p to avoid casts,
48 avoiding the 0 flag, which is not portable.
49 * process.c (Fmake_network_process): Use pI to avoid cast.
50 * region-cache.c (pp_cache): Likewise.
51 * xdisp.c (decode_mode_spec): Likewise.
52 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
53 behavior on 64-bit hosts with printf arg.
54 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
55 (x_stop_queuing_selection_requests): Likewise.
56 (x_get_window_property): Don't truncate byte count to an 'int'
59 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
60 here, since it parses constructs like leading '-' and spaces,
61 which are not wanted; and it overflows with large numbers.
62 Instead, simply match F[0-9]+, which is what is wanted anyway.
64 * alloc.c: Remove unportable assumptions about struct layout.
65 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
66 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
67 (allocate_vectorlike, make_pure_vector): Use the new macros,
68 plus offsetof, to remove unportable assumptions about struct layout.
69 These assumptions hold on all porting targets that I know of, but
70 they are not guaranteed, they're easy to remove, and removing them
71 makes further changes easier.
73 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
74 This doesn't fix a bug but makes the code clearer.
75 (string_overrun_cookie): Now const. Use initializers that
76 don't formally overflow signed char, to avoid warnings.
77 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
78 can cause Emacs to crash when string overrun checking is enabled.
79 (allocate_buffer): Don't assume sizeof (struct buffer) is a
80 multiple of sizeof (EMACS_INT); it need not be, if
81 alignof(EMACS_INT) < sizeof (EMACS_INT).
82 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
84 2011-04-19 Eli Zaretskii <eliz@gnu.org>
86 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
87 gl_state.e_property when gl_state.object is Qt.
89 * insdel.c (make_gap_larger): Remove limitation of buffer size
92 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
94 * xdisp.c (lookup_glyphless_char_display)
95 (produce_glyphless_glyph): Handle cons cell entry in
96 glyphless-char-display.
97 (Vglyphless_char_display): Document it.
99 * term.c (produce_glyphless_glyph): Handle cons cell entry in
100 glyphless-char-display.
102 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
104 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
106 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
108 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
109 definition for no-X builds.
111 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
113 Static checks with GCC 4.6.0 and non-default toolkits.
115 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
117 * process.c (keyboard_bit_set): Define only if SIGIO.
118 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
119 (send_process): Repair possible setjmp clobbering.
121 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
123 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
125 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
127 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
128 Define only if needed.
130 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
131 by pacifying GCC about it. Maybe it's time to retire it?
132 * xfaces.c (USG, __TIMEVAL__): Likewise.
134 * dispextern.h (struct redisplay_interface): Rename param
136 * termhooks.h (struct terminal): Likewise.
137 * xterm.c (xembed_send_message): Likewise.
139 * insdel.c (make_gap_smaller): Define only if
140 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
142 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
145 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
146 so that we aren't warned about unused symbols.
148 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
150 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
152 * xfns.c (x_real_positions): Mark locals as initialized.
154 * xmenu.c (xmenu_show): Don't use uninitialized vars.
156 * xterm.c: Fix problems found by static analysis with other toolkits.
157 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
158 (x_dispatch_event): Declare static if USE_GTK, and
159 define if USE_GTK || USE_X_TOOLKIT.
160 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
161 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
162 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
163 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
165 * xmenu.c (menu_help_callback): Pointer type fixes.
166 Use const pointers when pointing at readonly data. Avoid pointer
168 (FALSE): Remove unused macro.
169 (update_frame_menubar): Remove unused decl.
171 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
173 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
174 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
175 (single_menu_item): Rename local to avoid shadowing.
177 * keyboard.c (make_lispy_event): Remove unused local var.
179 * frame.c, frame.h (x_get_resource_string): Bring this back, but
180 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
182 * bitmaps: Change bitmaps from unsigned char back to the X11
183 compatible char. Avoid the old compiler warnings about
184 out-of-range initializers by using, for example, '\xab' rather
187 * xgselect.c (xgselect_initialize): Check vs interface
188 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
190 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
192 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
195 * fns.c (vector): Remove; this old hack is no longer needed.
197 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
199 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
201 * xrdb.c (x_load_resources): Omit unused local.
203 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
204 (x_window): Rename locals to avoid shadowing.
205 (USG): Use the kludged USG macro, to pacify gcc.
207 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
208 (x_term_init): Remove local to avoid shadowing.
210 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
212 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
213 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
215 2011-04-16 Eli Zaretskii <eliz@gnu.org>
217 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
219 Fix regex.c, syntax.c and friends for buffers > 2GB.
220 * syntax.h (struct gl_state_s): Declare character position members
223 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
225 * textprop.c (verify_interval_modification, interval_of): Declare
228 * intervals.c (adjust_intervals_for_insertion): Declare arguments
231 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
233 * indent.c (Fvertical_motion): Local variable it_start is now
236 * regex.c (re_match, re_match_2, re_match_2_internal)
237 (bcmp_translate, regcomp, regexec, print_double_string)
238 (group_in_compile_stack, re_search, re_search_2, regex_compile)
239 (re_compile_pattern, re_exec): Declare arguments and local
240 variables `size_t' and `ssize_t' and return values `regoff_t', as
242 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
243 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
244 <compile_stack_type>: `size' and `avail' are now `size_t'.
246 * regex.h <regoff_t>: Use ssize_t, not int.
247 (re_search, re_search_2, re_match, re_match_2): Arguments that
248 specify buffer/string position and length are now ssize_t and
249 size_t. Return type is regoff_t.
251 2011-04-16 Ben Key <bkey76@gmail.com>
253 * nsfont.m: Fixed bugs in ns_get_family and
254 ns_descriptor_to_entity that were caused by using free to
255 deallocate memory blocks that were allocated by xmalloc (via
256 xstrdup). This caused Emacs to crash when compiled with
257 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
258 --enable-checking=xmallocoverrun). xfree is now used to
259 deallocate these memory blocks.
261 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
263 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
265 emacs_write: Accept and return EMACS_INT for sizes.
266 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
268 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
269 Accept and return EMACS_INT.
270 (emacs_gnutls_write): Return the number of bytes written on
272 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273 (emacs_read, emacs_write): Remove check for negative size, as the
274 Emacs source code has been audited now.
275 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
276 (emacs_read, emacs_write): Use it.
277 * process.c (send_process): Adjust to the new signatures of
278 emacs_write and emacs_gnutls_write. Do not attempt to store
279 a byte offset into an 'int'; it might overflow.
280 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
282 * sound.c: Don't assume sizes fit in 'int'.
283 (struct sound_device.period_size, alsa_period_size):
284 Return EMACS_INT, not int.
285 (struct sound_device.write, vox_write, alsa_write):
286 Accept EMACS_INT, not int.
287 (wav_play, au_play): Use EMACS_INT to store sizes and to
288 record read return values.
290 2011-04-15 Ben Key <bkey76@gmail.com>
292 * keyboard.c (Qundefined): Don't declare static since it is used
294 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
295 static since they are used in nsfont.m.
297 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
299 * process.c (Qprocessp): Don't declare static.
300 * lisp.h (Qprocessp): Declare again.
302 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
304 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
306 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
308 Improve C-level modularity by making more things 'static'.
310 Don't publish debugger-only interfaces to other modules.
311 * lisp.h (safe_debug_print, debug_output_compilation_hack):
312 (verify_bytepos, count_markers): Move decls to the only modules
314 * region-cache.h (pp_cache): Likewise.
315 * window.h (check_all_windows): Likewise.
316 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
318 * sysdep.c (croak): Now static, if
319 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
320 * syssignal.h (croak): Declare only if not static.
322 * alloc.c (refill_memory_reserve): Now static if
323 !defined REL_ALLOC || defined SYSTEM_MALLOC.
324 * lisp.h (refill_memory_reserve): Declare only if not static.
326 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
327 Define only if USE_LUCID.
329 * xrdb.c (x_customization_string, x_rm_string): Now static.
331 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
332 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
334 * xdisp.c (draw_row_with_mouse_face): Now static.
335 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
337 * window.h (check_all_windows): Mark externally visible.
339 * window.c (window_deletion_count): Now static.
341 * undo.c: Make symbols static if they're not exported.
342 (last_undo_buffer, last_boundary_position, pending_boundary):
345 * textprop.c (interval_insert_behind_hooks): Now static.
346 (interval_insert_in_front_hooks): Likewise.
348 * term.c: Make symbols static if they're not exported.
349 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
350 (max_frame_lines, tty_set_terminal_modes):
351 (tty_reset_terminal_modes, tty_turn_off_highlight):
352 (get_tty_terminal): Now static.
353 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
354 * termhooks.h (term_mouse_moveto): Do not declare if
356 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
357 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
359 * sysdep.c: Make symbols static if they're not exported.
360 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
362 (sigprocmask_set, full_mask): Remove; unused.
363 (wait_debugging): Mark as visible.
364 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
365 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
367 * syntax.c (syntax_temp): Define only if !__GNUC__.
369 * sound.c (current_sound_device, current_sound): Now static.
371 * search.c (searchbufs, searchbuf_head): Now static.
373 * scroll.c (scroll_cost): Remove; unused.
374 * dispextern.h (scroll_cost): Remove decl.
376 * region-cache.h (pp_cache): Mark as externally visible.
378 * process.c: Make symbols static if they're not exported.
379 (process_tick, update_tick, create_process, chan_process):
380 (Vprocess_alist, proc_buffered_char, datagram_access):
381 (fd_callback_data, send_process_frame, process_sent_to): Now static.
382 (deactivate_process): Mark defn as static, as well as decl.
383 * lisp.h (create_process): Remove decl.
384 * process.h (chan_process, Vprocess_alist): Remove decls.
386 * print.c: Make symbols static if they're not exported.
387 (print_depth, new_backquote_output, being_printed, print_buffer):
388 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
389 (print_interval, print_number_index, initial_stderr_stream):
391 * lisp.h (Fprinc): Remove decl.
392 (debug_output_compilation_hack): Mark as externally visible.
394 * sysdep.c (croak): Move decl from here to syssignal.h.
395 * syssignal.h (croak): Put it here, so the API can be checked when
396 'croak' is called from dissociate_if_controlling_tty.
398 * minibuf.c: Make symbols static if they're not exported.
399 (minibuf_save_list, choose_minibuf_frame): Now static.
400 * lisp.h (choose_minibuf_frame): Remove decl.
402 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
404 * lread.c: Make symbols static if they're not exported.
405 (read_objects, initial_obarray, oblookup_last_bucket_number):
407 (make_symbol): Remove; unused.
408 * lisp.h (initial_obarray, make_symbol): Remove decls.
410 * keyboard.c: Make symbols static if they're not exported.
411 (single_kboard, recent_keys_index, total_keys, recent_keys):
412 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
413 (this_single_command_key_start, echoing, last_auto_save):
414 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
415 (command_loop, echo_now, keyboard_init_hook, help_char_p):
416 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
417 (Vlispy_mouse_stem, double_click_count):
419 (force_auto_save_soon): Define only if SIGDANGER.
420 (ignore_mouse_drag_p): Now static if
421 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
422 (print_help): Remove; unused.
423 (stop_character, last_timer_event): Mark as externally visible.
424 * keyboard.h (ignore_mouse_drag_p): Declare only if
425 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
426 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
427 * lisp.h (echoing): Remove decl.
428 (force_auto_save_soon): Declare only if SIGDANGER.
429 * xdisp.c (redisplay_window): Simplify code, to make it more
430 obvious that ignore_mouse_drag_p is not accessed if !defined
431 USE_GTK && !defined HAVE_NS.
433 * intervals.c: Make symbols static if they're not exported.
434 (merge_properties_sticky, merge_interval_right, delete_interval):
436 * intervals.h (merge_interval_right, delete_interval): Remove decls.
438 * insdel.c: Make symbols static if they're not exported.
439 However, leave prepare_to_modify_buffer alone. It's never
440 called from outside this function, but that appears to be a bug.
441 (combine_after_change_list, combine_after_change_buffer):
442 (adjust_after_replace, signal_before_change): Now static.
443 (adjust_after_replace_noundo): Remove; unused.
444 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
445 (signal_before_change): Remove decls.
447 * indent.c (val_compute_motion, val_vmotion): Now static.
449 * image.c: Make symbols static if they're not exported.
450 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
452 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
453 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
455 * fringe.c (standard_bitmaps): Now static.
456 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
458 * frame.c: Make symbols static if they're not exported.
459 (x_report_frame_params, make_terminal_frame): Now static.
460 (get_frame_param): Now static, unless HAVE_NS.
461 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
462 (x_get_resource_string): Remove; not used.
463 * frame.h (make_terminal_frame, x_report_frame_params):
464 (x_get_resource_string); Remove decls.
465 (x_fullscreen_adjust): Declare only if WINDOWSNT.
466 * lisp.h (get_frame_param): Declare only if HAVE_NS.
468 * font.c, fontset.c: Make symbols static if they're not exported.
469 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
470 (FACE_SUITABLE_FOR_CHAR_P): Use it.
471 * font.c (font_close_object): Now static.
472 * font.h (font_close_object): Remove.
473 * fontset.c (FONTSET_OBJLIST): Remove.
474 (free_realized_fontset) #if-0 the body, which does nothing.
475 (face_suitable_for_char_p): #if-0, as it's never called.
476 * fontset.h (face_suitable_for_char_p): Remove decl.
477 * xfaces.c (face_at_string_position): Use
478 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
479 since 0 is always ASCII.
481 * fns.c (weak_hash_tables): Now static.
483 * fileio.c: Make symbols static if they're not exported.
484 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
485 (Vwrite_region_annotation_buffers): Now static.
487 * eval.c: Make symbols static if they're not exported.
488 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
489 * lisp.h (backtrace_list): Remove decl.
491 * emacs.c: Make symbols static if they're not exported.
492 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
493 (fatal_error_code, fatal_error_signal_hook, standard_args):
495 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
496 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
497 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
498 * lisp.h (fatal_error_signal_hook): Remove decl.
499 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
501 * editfns.c: Move a (normally-unused) function to its only use.
502 * editfns.c, lisp.h (get_operating_system_release): Remove.
503 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
504 worth the hassle of breaking this out.
506 * xterm.c: Make symbols static if they're not exported.
507 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
508 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
509 (x_destroy_window, x_delete_display):
511 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
512 (x_mouse_leave): Remove; unused.
513 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
514 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
515 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
517 (x_mouse_leave): Declare only if WINDOWSNT.
518 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
519 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
522 * ftxfont.c: Make symbols static if they're not exported.
523 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
525 * font.h (ftxfont_driver): Likewise.
527 * xfns.c: Make symbols static if they're not exported.
528 (x_last_font_name, x_display_info_for_name):
529 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
530 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
531 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
532 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
533 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
534 (last_show_tip_args): Now static.
535 (xic_defaut_fontset, xic_create_fontsetname): Define only if
536 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
537 (x_screen_planes): Remove; unused.
538 * dispextern.h (x_screen_planes): Remove decl.
540 * dispnew.c: Make symbols static if they're not exported.
541 * dispextern.h (redraw_garbaged_frames, scrolling):
542 (increment_row_positions): Remove.
543 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
544 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
546 (redraw_garbaged_frames): Remove; unused.
548 * xfaces.c: Make symbols static if they're not exported.
549 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
551 * xterm.h (defined_color): Remove decls.
552 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
553 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
554 (menu_face_changed_default, defined_color, free_realized_face):
555 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
556 (ascii_face_of_lisp_face): Remove; unused.
558 * xdisp.c: Make symbols static if they're not exported.
559 * dispextern.h (scratch_glyph_row, window_box_edges):
560 (glyph_to_pixel_coords, set_cursor_from_row):
561 (get_next_display_element, set_iterator_to_next):
562 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
563 (show_mouse_face): Remove decls
564 * frame.h (message_buf_print): Likewise.
565 * lisp.h (pop_message, set_message, check_point_in_composition):
567 * xterm.h (set_vertical_scroll_bar): Likewise.
568 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
569 (message_buf_print, scratch_glyph_row, displayed_buffer):
570 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
571 (get_next_display_element, show_mouse_face, window_box_edges):
572 (frame_to_window_pixel_xy, check_point_in_composition):
573 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
574 (glyph_to_pixel_coords): Remove; unused.
576 * dired.c (file_name_completion): Now static.
578 * dbusbind.c (xd_in_read_queued_messages): Now static.
580 * lisp.h (circular_list_error, FOREACH): Remove; unused.
581 * data.c (circular_list_error): Remove.
583 * commands.h (last_point_position, last_point_position_buffer):
584 (last_point_position_window): Remove decls.
585 * keyboard.c: Make these variables static.
587 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
589 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
590 (iso_code_class, detect_coding, code_convert_region): Now static.
591 (encode_coding_gap): Remove; unused.
593 * chartab.c (chartab_chars, chartab_bits): Now static.
595 * charset.h (charset_iso_8859_1): Remove decl.
596 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
599 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
600 * ccl.c (Vccl_program_table): Now static.
601 (check_ccl_update): Remove; unused.
603 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
604 * category.h: ... from here.
605 * category.c (check_category_table, set_category_set): Now static.
607 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
608 * lisp.h: Remove these decls.
610 * buffer.c (buffer_count): Remove unused var.
612 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
613 so that it's not optimized away.
614 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
615 * dispextern.h (bidi_dump_cached_states): Remove, since it's
616 exported only to the debugger.
618 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
619 * atimer.h (run_all_atimers): Removed; not exported.
621 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
622 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
623 was inaccessible from Lisp.
624 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
625 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
627 alloc.c: Import and export fewer symbols, and remove unused items.
628 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
630 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
631 it's not optimized away by whole-program optimization.
632 (message_enable_multibyte, free_misc): Remove.
633 (catchlist, handlerlist, mark_backtrace):
634 Declare only if BYTE_MARK_STACK.
635 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
636 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
637 (message_enable_multibyte): Remove decl.
638 (free_misc, interval_free_list, float_block, float_block_index):
639 (n_float_blocks, float_free_list, cons_block, cons_block_index):
640 (cons_free_list, last_marked_index):
642 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
643 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
644 (mark_backtrace): Define only if BYTE_MARK_STACK.
645 * xdisp.c (message_enable_multibyte): Now static.
647 Declare Lisp_Object Q* variables to be 'static' if not exported.
648 This makes it easier for human readers (and static analyzers)
649 to see whether these variables are used from other modules.
650 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
651 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
652 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
653 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
654 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
655 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
656 * xmenu.c, xselect.c:
657 Declare Q* vars static if they are not used in other modules.
658 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
659 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
660 Remove decls of unexported vars.
661 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
663 * lisp.h (DEFINE_FUNC): Make sname 'static'.
665 Make Emacs functions such as Fatom 'static' by default.
666 This makes it easier for human readers (and static analyzers)
667 to see whether these functions can be called from other modules.
668 DEFUN now defines a static function. To make the function external
669 so that it can be used in other C modules, use the new macro DEFUE.
670 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
671 (Finit_image_library):
672 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
673 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
674 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
675 Remove decls, since these functions are now static.
676 (Funintern, Fget_internal_run_time): New decls, since these functions
677 were already external.
679 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
680 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
681 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
682 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
683 * keyboard.c, keymap.c, lread.c:
684 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
685 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
686 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
687 Mark functions with DEFUE instead of DEFUN,
688 if they are used in other modules.
689 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
690 decls for now-static functions.
691 * buffer.h (Fdelete_overlay): Remove decl.
692 * callproc.c (Fgetenv_internal): Mark as internal.
693 * composite.c (Fremove_list_of_text_properties): Remove decl.
694 (Fcomposition_get_gstring): New forward static decl.
695 * composite.h (Fcomposite_get_gstring): Remove decl.
696 * dired.c (Ffile_attributes): New forward static decl.
697 * doc.c (Fdocumntation_property): New forward static decl.
698 * eval.c (Ffetch_bytecode): New forward static decl.
699 (Funintern): Remove extern decl; now in .h file where it belongs.
700 * fileio.c (Fmake_symbolic_link): New forward static decl.
701 * image.c (Finit_image_library): New forward static decl.
702 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
703 * intervals.h (Fprevious_property_change):
704 (Fremove_list_of_text_properties): Remove decls.
705 * keyboard.c (Fthis_command_keys): Remove decl.
706 (Fcommand_execute): New forward static decl.
707 * keymap.c (Flookup_key): New forward static decl.
708 (Fcopy_keymap): Now static.
709 * keymap.h (Flookup_key): Remove decl.
710 * process.c (Fget_process): New forward static decl.
711 (Fprocess_datagram_address): Mark as internal.
712 * syntax.c (Fsyntax_table_p): New forward static decl.
713 (skip_chars): Remove duplicate decl.
714 * textprop.c (Fprevious_property_change): New forward static decl.
715 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
717 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
718 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
720 * editfns.c (Fformat): Remove unreachable code.
722 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
724 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
727 2011-04-13 Eli Zaretskii <eliz@gnu.org>
729 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
730 when at ZV. (Bug#8487)
732 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
734 * charset.c (Fclear_charset_maps): Use xfree instead of free.
736 * keyboard.c (parse_tool_bar_item): Likewise.
737 * sound.c (sound_cleanup, alsa_close): Likewise.
738 * termcap.c (tgetent): Likewise.
739 * xfns.c (x_default_font_parameter): Likewise.
740 * xsettings.c (read_and_apply_settings): Likewise.
742 * alloc.c (overrun_check_malloc, overrun_check_realloc)
743 (overrun_check_free): Protoize.
745 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
747 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
748 since callers should never pass a negative size.
749 Change the signature to match that of plain 'read' and 'write'; see
750 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
751 * lisp.h: Update prototypes of emacs_write and emacs_read.
753 2011-04-11 Eli Zaretskii <eliz@gnu.org>
755 * xdisp.c (redisplay_window): Don't try to determine the character
756 position of the scroll margin if the window start point w->startp
757 is outside the buffer's accessible region. (Bug#8468)
759 2011-04-10 Eli Zaretskii <eliz@gnu.org>
761 Fix write-region and its subroutines for buffers > 2GB.
762 * fileio.c (a_write, e_write): Modify declaration of arguments and
763 local variables to support buffers larger than 2GB.
764 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
766 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
767 argument, local variables, and return value.
769 * lisp.h: Update prototypes of emacs_write and emacs_read.
771 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
773 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
775 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
777 Fix more problems found by GCC 4.6.0's static checks.
779 * xdisp.c (vmessage): Use a better test for character truncation.
781 * charset.c (load_charset_map): <, not <=, for optimization,
782 and to avoid potential problems with integer overflow.
783 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
784 * casetab.c (set_identity, shuffle): Likewise.
785 * editfns.c (Fformat): Likewise.
786 * syntax.c (skip_chars): Likewise.
788 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
789 This also lets GCC 4.6.0 generate slightly better loop code.
791 * callint.c (Fcall_interactively): <, not <=, for optimization.
792 (Fcall_interactively): Count the number of arguments produced,
793 not the number of arguments given. This is simpler and lets GCC
794 4.6.0 generate slightly better code.
796 * ftfont.c: Distingish more carefully between FcChar8 and char.
797 The previous code passed unsigned char * to a functions like
798 strlen and xstrcasecmp that expect char *, which does not
799 conform to the C standard.
800 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
801 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
802 char * when the C standard requires it.
804 * keyboard.c (read_char): Remove unused var.
806 * eval.c: Port to Windows vsnprintf (Bug#8435).
808 (SIZE_MAX): Define if the headers do not.
809 (verror): Do not give up if vsnprintf returns a negative count.
810 Instead, grow the buffer. This ports to Windows vsnprintf, which
811 does not conform to C99. Problem reported by Eli Zaretskii.
812 Also, simplify the allocation scheme, by avoiding the need for
813 calling realloc, and removing the ALLOCATED variable.
815 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
817 Remove invocations of doprnt, as Emacs now uses vsnprintf.
818 But keep the doprint source code for now, as we might revamp it
819 and use it again (Bug#8435).
820 * lisp.h (doprnt): Remove.
821 * Makefile.in (base_obj): Remove doprnt.o.
822 * deps.mk (doprnt.o): Remove.
824 error: Print 32- and 64-bit integers portably (Bug#8435).
825 Without this change, on typical 64-bit hosts error ("...%d...", N)
826 was used to print both 32- and 64-bit integers N, which relied on
828 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
830 * lisp.h (error, verror): Mark as printf-like functions.
831 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
832 Report overflow in size calculations when allocating printf buffer.
833 Do not truncate output string at its first null byte.
834 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
835 Truncate the output at a character boundary, since vsnprintf does not
837 * charset.c (check_iso_charset_parameter): Convert internal
838 character to string before calling 'error', since %c now has the
840 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
841 overflow when computing char to be passed to 'error'. Do not
842 pass Lisp_Object to 'error'; pass the integer instead.
843 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
844 formatted with plain %d.
846 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
848 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
850 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
852 * xterm.c (x_catch_errors): Remove duplicate declaration.
854 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
856 * xdisp.c, lisp.h (message_nolog): Remove; unused.
858 2011-04-10 Jim Meyering <meyering@redhat.com>
860 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
861 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
862 return ssize_t not "int", and use size_t as the buffer length.
863 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
864 * gnutls.h: Update declarations.
865 * process.c (read_process_output): Use ssize_t, to match.
866 (send_process): Likewise.
868 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
870 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
872 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
874 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
875 unsigned char, to match FcChar8 type definition.
877 * xterm.c (handle_one_xevent):
878 * xmenu.c (create_and_show_popup_menu):
879 * xselect.c (x_decline_selection_request)
880 (x_reply_selection_request): Avoid type-punned deref of X events.
882 2011-04-09 Eli Zaretskii <eliz@gnu.org>
884 Fix some uses of `int' instead of EMACS_INT.
885 * search.c (string_match_1, fast_string_match)
886 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
887 (scan_buffer, find_next_newline_no_quit)
888 (find_before_next_newline, search_command, Freplace_match)
889 (Fmatch_data): Make some `int' variables be EMACS_INT.
891 * xdisp.c (display_count_lines): 3rd argument and return value now
892 EMACS_INT. All callers changed.
893 (pint2hrstr): Last argument is now EMACS_INT.
895 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
896 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
897 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
898 (decode_coding_utf_16, decode_coding_emacs_mule)
899 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
900 (decode_coding_ccl, decode_coding_charset)
901 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
902 (decode_coding_iso_2022, decode_coding_emacs_mule)
903 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
904 <char_offset, last_offset>: Declare EMACS_INT.
905 (encode_coding_utf_8, encode_coding_utf_16)
906 (encode_coding_emacs_mule, encode_invocation_designation)
907 (encode_designation_at_bol, encode_coding_iso_2022)
908 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
909 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
911 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
912 (encode_invocation_designation): Last argument P_NCHARS is now
914 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
915 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
917 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
920 * ccl.c (Fccl_execute_on_string): Declare some variables
923 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
925 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
927 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
929 * process.c (Fformat_network_address): Doc fix.
931 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
933 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
935 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
937 * keyboard.c (read_char): Call Lisp function help-form-show,
938 instead of using internal_with_output_to_temp_buffer.
939 (Qhelp_form_show): New var.
940 (syms_of_keyboard): Use DEFSYM macro.
942 * print.c (internal_with_output_to_temp_buffer): Function deleted.
944 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
946 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
948 * process.c (Flist_processes): Removed to Lisp.
949 (list_processes_1): Deleted.
951 2011-04-06 Eli Zaretskii <eliz@gnu.org>
953 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
955 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
957 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
959 Fix more problems found by GCC 4.6.0's static checks.
961 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
963 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
965 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
967 * xdisp.c (vmessage): Mark as a printf-like function.
969 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
971 * sound.c (sound_warning): Don't crash if arg contains a printf format.
973 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
974 printf-like functions.
975 (tiff_load): Add casts to remove these marks before passing them
976 to system-supplied API.
978 * eval.c (Fsignal): Remove excess argument to 'fatal'.
980 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
981 This avoids several warnings with gcc -Wstrict-overflow.
982 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
983 directly, rather than having caller test rule sign. This avoids
984 some unnecessary tests.
985 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
986 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
987 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
989 * xfont.c (xfont_text_extents): Remove var that was set but not used.
990 (xfont_open): Avoid unnecessary tests.
992 * composite.c (composition_gstring_put_cache): Use unsigned integer.
994 * composite.h, composite.c (composition_gstring_put_cache):
995 Use EMACS_INT, not int, for length.
997 * composite.h (COMPOSITION_DECODE_REFS): New macro,
998 breaking out part of COMPOSITION_DECODE_RULE.
999 (COMPOSITION_DECODE_RULE): Use it.
1000 * composite.c (get_composition_id): Remove unused local vars,
1001 by using the new macro.
1003 * textprop.c (set_text_properties_1): Change while to do-while,
1004 since the condition is always true at first.
1006 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1007 (interval_deletion_adjustment): Return unsigned value.
1010 * process.c (list_processes_1, create_pty, read_process_output):
1011 (exec_sentinel): Remove vars that were set but not used.
1012 (create_pty): Remove unnecessary "volatile"s.
1013 (Fnetwork_interface_info): Avoid possibility of int overflow.
1014 (read_process_output): Do adaptive read buffering even if carryover.
1015 (read_process_output): Simplify nbytes computation if buffered.
1017 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1019 * syntax.c (scan_words): Remove var that was set but not used.
1020 (update_syntax_table): Use unsigned instead of int.
1022 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1023 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1024 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1026 * print.c (print_error_message): Avoid int overflow.
1028 * font.c (font_list_entities): Redo for clarity,
1029 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1031 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1032 (font_score): Avoid potential overflow in diff calculation.
1034 * fns.c (substring_both): Remove var that is set but not used.
1035 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1037 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1039 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1040 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1041 can always succeed if overflow has undefined behavior.
1043 * search.c (boyer_moore, wordify): Remove vars set but not used.
1044 (wordify): Omit three unnecessary tests.
1046 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1047 All callers changed. This avoids the need for an unused var.
1049 * casefiddle.c (casify_region): Remove var that is set but not used.
1051 * dired.c (file_name_completion): Remove var that is set but not used.
1053 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1055 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1056 (Finsert_file_contents): Remove unnecessary code checking fd.
1058 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1059 Check for integer overflow on size calculations.
1061 * buffer.c (Fprevious_overlay_change): Remove var that is set
1064 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1065 Remove vars that are set but not used.
1066 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1067 (timer_check_2): Mark vars as initialized.
1069 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1071 * image.c (lookup_image): Remove var that is set but not used.
1072 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1074 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1075 that are set but not used.
1077 * xfns.c (make_invisible_cursor): Don't return garbage
1078 if XCreateBitmapFromData fails (Bug#8410).
1080 * xselect.c (x_get_local_selection, x_handle_property_notify):
1081 Remove vars that are set but not used.
1083 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1084 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1086 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1087 Remove var that is set but not used.
1088 (scroll_bar_windows_size): Now size_t, not int.
1089 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1092 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1093 (map_tty_color) [!defined MSDOS]: Likewise.
1095 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1097 * coding.c: Remove vars that are set but not used.
1098 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1099 All callers changed.
1100 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1101 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1102 (decode_coding_charset): Remove vars that are set but not used.
1104 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1105 that is set but not used.
1107 * print.c (print_object): Remove var that is set but not used.
1109 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1110 The gnulib version avoids calling malloc in the usual case,
1111 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1112 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1113 * filelock.c (current_lock_owner): Likewise.
1114 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1115 * sysdep.c: Include allocator.h, careadlinkat.h.
1116 (emacs_no_realloc_allocator): New static constant.
1117 (emacs_readlink): New function.
1118 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1119 ../lib/careadlinkat.h.
1121 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1123 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1124 first non-nil return value).
1126 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1128 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1129 if not defined (Bug#8403).
1131 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1133 * xdisp.c (display_count_lines): Remove parameter `start',
1134 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1135 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1136 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1137 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1138 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1139 and thereabouts. All callers changed.
1140 (get_per_char_metric): Remove parameter `f', unused since
1141 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1143 2011-04-02 Jim Meyering <meyering@redhat.com>
1145 do not dereference NULL upon failed strdup
1146 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1147 (ns_get_family): Likewise.
1149 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1151 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1153 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1155 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1158 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1160 Add lexical binding.
1162 * window.c (Ftemp_output_buffer_show): New fun.
1163 (Fsave_window_excursion):
1164 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1166 * lread.c (lisp_file_lexically_bound_p): New function.
1167 (Fload): Bind Qlexical_binding.
1168 (readevalloop): Remove `evalfun' arg.
1169 Bind Qinternal_interpreter_environment.
1170 (Feval_buffer): Bind Qlexical_binding.
1171 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1173 (syms_of_lread): Declare `lexical-binding'.
1175 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1177 * keyboard.c (eval_dyn): New fun.
1178 (menu_item_eval_property): Use it.
1180 * image.c (parse_image_spec): Use Ffunctionp.
1182 * fns.c (concat, mapcar1): Accept byte-code-functions.
1184 * eval.c (Fsetq): Handle lexical vars.
1185 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1186 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1187 (FletX, Flet): Obey lexical binding.
1188 (Fcommandp): Handle closures.
1189 (Feval): New `lexical' arg.
1190 (eval_sub): New function extracted from Feval. Use it almost
1191 everywhere where Feval was used. Look up vars in lexical env.
1193 (Ffunctionp): Move from subr.el.
1194 (Ffuncall): Handle closures.
1195 (apply_lambda): Remove `eval_flags'.
1196 (funcall_lambda): Handle closures and new byte-code-functions.
1197 (Fspecial_variable_p): New function.
1198 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1199 but without exporting it to Lisp.
1201 * doc.c (Fdocumentation, store_function_docstring):
1202 * data.c (Finteractive_form): Handle closures.
1204 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1207 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1209 (exec_byte_code): New function extracted from Fbyte_code to handle new
1210 calling convention for byte-code-functions. Add new byte-codes.
1212 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1214 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1216 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1218 * xdisp.c (redisplay_internal): Fix prototype.
1220 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1222 * xdisp.c (SCROLL_LIMIT): New macro.
1223 (try_scrolling): Use it when setting scroll_limit. Limit
1224 scrolling to 100 screen lines.
1225 (redisplay_window): Even when falling back on "recentering",
1226 position point in the window according to scroll-conservatively,
1227 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1229 (try_scrolling): When point is above the window, allow searching
1230 as far as scroll_max, or one screenful, to compute vertical
1231 distance from PT to the scroll margin position. This prevents
1232 try_scrolling from unnecessarily failing when
1233 scroll-conservatively is set to a value slightly larger than the
1234 window height. Clean up the case of PT below the margin at bottom
1235 of window: scroll_max can no longer be INT_MAX. When aggressive
1236 scrolling is in use, don't let point enter the opposite scroll
1237 margin as result of the scroll.
1238 (syms_of_xdisp) <scroll-conservatively>: Document the
1239 threshold of 100 lines for never-recentering scrolling.
1241 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1243 * dispextern.h (move_it_by_lines):
1244 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1245 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1246 (message_log_check_duplicate): Remove parameters `prev_bol' and
1247 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1248 (redisplay_internal): Remove parameter `preserve_echo_area',
1249 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1251 * indent.c (Fvertical_motion):
1252 * window.c (window_scroll_pixel_based, Frecenter):
1253 Don't pass `need_y_p' to `move_it_by_lines'.
1255 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1257 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1258 steal a few bits to be more compact.
1259 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1260 Remove unneeded casts.
1262 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1264 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1266 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1267 binding" message (bug#7967).
1269 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1271 Fix more problems found by GCC 4.6.0's static checks.
1273 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1274 Remove unused local var.
1276 * editfns.c (Fmessage_box): Remove unused local var.
1278 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1279 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1280 Omit unused local vars.
1281 * window.c (shrink_windows): Omit unused local var.
1282 * menu.c (digest_single_submenu): Omit unused local var.
1283 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1284 Omit unused local var.
1286 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1287 Don't assume string length fits in int.
1288 (keyremap_step, read_key_sequence): Use size_t for sizes.
1289 (read_key_sequence): Don't check last_real_key_start redundantly.
1291 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1292 instead of alloca (Bug#8344).
1294 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1295 (Fbacktrace_frame): Don't assume nframes fits in int.
1297 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1299 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1302 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1304 * cm.c (calccost): Turn while-do into do-while, for clarity.
1306 * keyboard.c (syms_of_keyboard): Use the same style as later
1307 in this function when indexing through an array. This also
1308 works around GCC bug 48267.
1310 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1312 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1314 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1315 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1317 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1318 This avoids undefined behavior on integer overflow, and is a bit
1319 more convenient anyway since it is compared to a size_t variable.
1321 Variadic C functions now count arguments with size_t, not int.
1322 This avoids an unnecessary limitation on 64-bit machines, which
1323 caused (substring ...) to crash on large vectors (Bug#8344).
1324 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1325 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1326 All variadic functions and their callers changed accordingly.
1327 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1328 * data.c (arith_driver, float_arith_driver): Likewise.
1329 * editfns.c (general_insert_function): Likewise.
1330 * eval.c (struct backtrace.nargs, interactive_p)
1331 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1332 (funcall_lambda, mark_backtrace): Likewise.
1333 * fns.c (concat): Likewise.
1334 * frame.c (x_set_frame_parameters): Likewise.
1335 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1336 0 if not found, not -1. All callers changed.
1338 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1339 (stack_copy_size): Now size_t, not int.
1340 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1342 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1344 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1345 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1346 All callers changed.
1348 * lisp.h (multibyte_char_to_unibyte):
1349 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1350 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1351 * character.h (CHAR_TO_BYTE8):
1352 * cmds.c (internal_self_insert):
1353 * editfns.c (general_insert_function):
1354 * keymap.c (push_key_description):
1355 * search.c (Freplace_match):
1356 * xdisp.c (message_dolog, set_message_1): All callers changed.
1358 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1360 * keyboard.c (safe_run_hook_funcall): New function.
1361 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1362 don't set the hook to nil, but remove the offending function instead.
1363 (Qcommand_hook_internal): Remove, unused.
1364 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1365 Vcommand_hook_internal.
1367 * eval.c (enum run_hooks_condition): Remove.
1368 (funcall_nil, funcall_not): New functions.
1369 (run_hook_with_args): Call each function through a `funcall' argument.
1370 Remove `cond' argument, now redundant.
1371 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1372 (Frun_hook_with_args_until_failure): Adjust accordingly.
1373 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1375 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1377 * dispextern.h (string_buffer_position): Remove declaration.
1379 * print.c (strout): Remove parameter `multibyte', unused since
1380 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1382 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1383 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1384 All callers changed.
1386 * w32.c (_wsa_errlist): Use braces for struct initializers.
1388 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1389 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1390 All callers changed.
1391 (string_buffer_position): Likewise. Also, make static (it's never
1392 used outside xdisp.c).
1393 (cursor_row_p): Remove parameter `w', unused since
1394 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1395 (decode_mode_spec): Remove parameter `precision', introduced during
1396 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1397 All callers changed.
1399 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1401 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1403 2011-03-27 Anders Lindgren <andlind@gmail.com>
1405 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1406 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1407 (ns_update_auto_hide_menu_bar): New functions.
1408 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1409 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1410 ns_constrain_all_frames.
1411 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1412 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1414 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1416 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1418 2011-03-27 Glenn Morris <rgm@gnu.org>
1420 * syssignal.h: Replace RETSIGTYPE with void.
1421 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1422 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1423 Replace SIGTYPE with void everywhere.
1424 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1425 * s/template.h (SIGTYPE): Remove commented out definition.
1427 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1429 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1430 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1432 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1434 * w32.c (read_unc_volume): Use parameter `henum', instead of
1435 global variable `wget_enum_handle'.
1437 * keymap.c (describe_vector): Remove parameters `indices' and
1438 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1439 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1441 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1443 * keyboard.c (timer_check): Remove parameter `do_it_now',
1444 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1445 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1446 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1448 * keyboard.c (read_char):
1449 * w32menu.c (w32_menu_display_help):
1450 * xmenu.c (show_help_event, menu_help_callback):
1451 Adjust calls to `show_help_echo'.
1453 * gtkutil.c (xg_maybe_add_timer):
1454 * keyboard.c (readable_events):
1455 * process.c (wait_reading_process_output):
1456 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1458 * insdel.c (adjust_markers_gap_motion):
1459 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1460 (gap_left, gap_right): Don't call it.
1462 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1464 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1465 incurred during fontification.
1467 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1469 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1470 (DEFVAR_PER_BUFFER): Don't pass it.
1472 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1473 (scrolling_window): Don't pass it.
1475 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1477 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1479 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1481 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1482 of variables specific to SELinux and computation of `encoded_absname'.
1484 * image.c (XPutPixel): Remove unused variable `height'.
1486 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1488 * unexw32.c (get_section_info): Remove unused variable `section'.
1490 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1491 (system_process_attributes): Remove unused variable `sess'.
1492 (sys_read): Remove unused variable `err'.
1494 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1495 (w32_wnd_proc): Remove unused variable `isdead'.
1496 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1497 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1498 (x_create_tip_frame): Remove unused variable `tem'.
1500 * w32inevt.c (w32_console_read_socket):
1501 Remove unused variable `no_events'.
1503 * w32term.c (x_draw_composite_glyph_string_foreground):
1504 Remove unused variable `width'.
1506 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1508 * w32term.c (x_set_glyph_string_clipping):
1509 Don't pass uninitialized region to CombineRgn.
1511 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1513 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1514 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1515 (Fx_close_connection): Remove unused variable `i'.
1517 * w32font.c (w32font_draw): Return number of glyphs.
1518 (w32font_open_internal): Remove unused variable `i'.
1519 (w32font_driver): Add missing initializer.
1521 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1522 (fill_in_menu): Remove unused variable `items_added'.
1524 * w32term.c (last_mouse_press_frame): Remove static global variable.
1525 (w32_clip_to_row): Remove unused variable `f'.
1526 (x_delete_terminal): Remove unused variable `i'.
1528 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1529 (NOTHING): Remove unused static global variable.
1530 (uniscribe_check_otf): Remove unused variable `table'.
1531 (uniscribe_font_driver): Add missing initializers.
1533 2011-03-23 Julien Danjou <julien@danjou.info>
1535 * term.c (Fsuspend_tty, Fresume_tty):
1536 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1537 * window.c (temp_output_buffer_show):
1538 * insdel.c (signal_before_change):
1539 * frame.c (Fhandle_switch_frame):
1540 * fileio.c (Fdo_auto_save):
1541 * emacs.c (Fkill_emacs):
1542 * editfns.c (save_excursion_restore):
1543 * cmds.c (internal_self_insert):
1544 * callint.c (Fcall_interactively):
1545 * buffer.c (Fkill_all_local_variables):
1546 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1548 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1549 unconditionnaly since it does the check itself.
1551 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1553 Fix more problems found by GCC 4.5.2's static checks.
1555 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1556 the first time through the loop, since we know p0 < p1 then.
1557 This also avoids a gcc -Wstrict-overflow warning.
1559 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1560 leading to a memory leak, possible in functions like
1561 load_charset_map_from_file that can allocate an unbounded number
1562 of objects (Bug#8318).
1564 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1565 that could (at least in theory) be that large.
1567 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1568 This is less likely to overflow, and avoids undefined behavior if
1569 overflow does occur. All callers changed. Use strtoul to scan
1570 for the unsigned long integer.
1571 (pint2hrstr): Simplify and tune code slightly.
1572 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1574 * scroll.c (do_scrolling): Work around GCC bug 48228.
1575 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1577 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1578 This also avoids a warning with gcc -Wstrict-overflow.
1579 (validate_x_resource_name): Simplify count usage.
1580 This also avoids a warning with gcc -Wstrict-overflow.
1582 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1585 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1587 * process.c (Fmake_network_process): Use socklen_t, not int,
1588 where POSIX says socklen_t is required in portable programs.
1589 This fixes a porting bug on hosts like 64-bit HP-UX, where
1590 socklen_t is wider than int (Bug#8277).
1591 (Fmake_network_process, server_accept_connection):
1592 (wait_reading_process_output, read_process_output):
1595 * process.c: Rename or move locals to avoid shadowing.
1596 (list_processes_1, Fmake_network_process):
1597 (read_process_output_error_handler, exec_sentinel_error_handler):
1598 Rename or move locals.
1599 (Fmake_network_process): Define label "retry_connect" only if needed.
1600 (Fnetwork_interface_info): Fix pointer signedness.
1601 (process_send_signal): Add cast to avoid pointer signedness problem.
1602 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1603 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1605 Make tparam.h and terminfo.c consistent.
1606 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1607 Include tparam.h instead, since it declares them.
1608 * cm.h (PC): Remove extern decl; tparam.h now does this.
1609 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1610 * terminfo.c: Include tparam.h, to check interfaces.
1611 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1612 (tparam): Adjust signature to match interface in tparam.h;
1613 this removes some undefined behavior. Check that outstring and len
1614 are zero, which they always are with Emacs.
1615 * tparam.h (PC, BC, UP): New extern decls.
1617 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1618 (xftfont_open): Rename locals to avoid shadowing.
1620 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1621 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1622 (OTF_TAG_SYM): Omit macro if not needed.
1623 (ftfont_list): Remove unused local.
1624 (get_adstyle_property, ftfont_pattern_entity):
1625 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1626 Rename locals to avoid shadowing.
1628 * xfont.c (xfont_list_family): Mark var as initialized.
1630 * xml.c (make_dom): Now static.
1632 * composite.c (composition_compute_stop_pos): Rename local to
1634 (composition_reseat_it): Remove unused locals.
1635 (find_automatic_composition, composition_adjust_point): Likewise.
1636 (composition_update_it): Mark var as initialized.
1637 (find_automatic_composition): Mark vars as initialized,
1638 with a FIXME (Bug#8290).
1640 character.h: Rename locals to avoid shadowing.
1641 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1642 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1643 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1644 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1647 * textprop.c (property_change_between_p): Remove; unused.
1649 * intervals.c (interval_start_pos): Now static.
1651 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1653 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1654 Rename locals to avoid shadowing.
1656 * sound.c (wav_play, au_play, Fplay_sound_internal):
1657 Fix pointer signedness.
1658 (alsa_choose_format): Remove unused local var.
1659 (wav_play): Initialize a variable to 0, to prevent undefined
1660 behavior (Bug#8278).
1662 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1664 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1666 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1667 clobbering (Bug#8298).
1668 * sysdep.c (sys_subshell): Likewise.
1669 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1671 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1672 This should get cleaned up, so that child_setup has the
1673 same signature on all platforms.
1675 * callproc.c (call_process_cleanup): Now static.
1676 (relocate_fd): Rename locals to avoid shadowing.
1678 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1680 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1681 not to be necessary, and produces flickering.
1683 2011-03-20 Glenn Morris <rgm@gnu.org>
1685 * config.in: Remove file.
1687 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1689 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1690 are now in src/globals.h.
1691 (syms_of_minibuf): Remove spurious & from previous change.
1693 2011-03-20 Leo <sdl.web@gmail.com>
1695 * minibuf.c (completing-read-function): New variable.
1696 (completing-read-default): Rename from completing-read.
1697 (completing-read): Call completing-read-function.
1699 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1701 * xfaces.c (Fx_load_color_file):
1702 Read color file from absolute filename (bug#8250).
1704 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1706 * makefile.w32-in: Update dependencies.
1708 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1710 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1712 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1714 Fix more problems found by GCC 4.5.2's static checks.
1716 * process.c (make_serial_process_unwind, send_process_trap):
1717 (sigchld_handler): Now static.
1719 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1720 That way, the code declares only the vars that it needs.
1721 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1722 * s/cygwin.h (PTY_ITERATION): Likewise.
1723 * s/darwin.h (PTY_ITERATION): Likewise.
1724 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1726 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1727 * process.c (allocate_pty): Don't declare stb unless it's needed.
1729 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1730 (CONSTANTLIM): Remove; unused.
1731 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1732 Define only if needed.
1734 * unexelf.c (unexec): Name an expression,
1735 to avoid gcc -Wbad-function-cast warning.
1736 Use a different way to cause a compilation error if anyone uses
1737 n rather than nn, a way that does not involve shadowing.
1738 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1740 * deps.mk (unexalpha.o): Remove; unused.
1742 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1743 * unexec.h: New file.
1744 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1745 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1747 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1748 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1749 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1750 Change as necessary to match prototype in unexec.h.
1752 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1754 (back_comment, skip_chars): Mark vars as initialized.
1756 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1757 Rename locals to avoid shadowing.
1759 * lread.c (read1): Rewrite so as not to use empty "else".
1760 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1762 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1764 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1765 warning when compiling print.c.
1767 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1768 instead of using an uninitialized var.
1769 (font_sort_entities): Mark var as initialized.
1771 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1773 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1774 pointers to constants.
1775 (font_parse_fcname): Remove unused vars.
1776 (font_delete_unmatched): Now static.
1777 (font_get_spec): Remove; unused.
1778 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1779 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1780 Rename or move locals to avoid shadowing.
1782 * fns.c (require_nesting_list, require_unwind): Now static.
1783 (Ffillarray): Rename locals to avoid shadowing.
1785 * floatfns.c (domain_error2): Define only if needed.
1786 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1788 * alloc.c (mark_backtrace): Move decl from here ...
1789 * lisp.h: ... to here, so that it can be checked.
1791 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1792 (Fdefvar): Rewrite so as not to use empty "else".
1793 (lisp_indirect_variable): Name an expression,
1794 to avoid gcc -Wbad-function-cast warning.
1795 (Fdefvar): Rename locals to avoid shadowing.
1797 * callint.c (quotify_arg, quotify_args): Now static.
1798 (Fcall_interactively): Rename locals to avoid shadowing.
1799 Use const pointer when appropriate.
1801 * lisp.h (get_system_name, get_operating_system_release):
1802 Move decls here, to check interfaces.
1803 * process.c (get_operating_system_release): Move decl to lisp.h.
1804 * xrdb.c (get_system_name): Likewise.
1805 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1806 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1807 some of which prompt warnings from gcc -Wbad-function-cast.
1808 (Fformat_time_string, Fencode_time, Finsert_char):
1809 (Ftranslate_region_internal, Fformat):
1810 Rename or remove local vars to avoid shadowing.
1811 (Ftranslate_region_internal): Mark var as initialized.
1813 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1816 * lisp.h (eassert): Check that the argument compiles, even if
1817 ENABLE_CHECKING is not defined.
1819 * data.c (Findirect_variable): Name an expression, to avoid
1820 gcc -Wbad-function-cast warning.
1821 (default_value, arithcompare, arith_driver, arith_error): Now static.
1822 (store_symval_forwarding): Rename local to avoid shadowing.
1823 (Fmake_variable_buffer_local, Fmake_local_variable):
1824 Mark variables as initialized.
1825 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1827 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1828 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1829 Rename locals to avoid shadowing.
1830 (mark_stack): Move local variables into the #ifdef region where
1832 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1833 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1835 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1836 (GC_STRING_CHARS): Remove; not used.
1837 (Fmemory_limit): Cast sbrk's returned value to char *.
1839 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1840 avoids undefined behavior in theory.
1842 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1844 Use functions, not macros, for up- and down-casing (Bug#8254).
1845 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1846 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1847 to use the following functions instead of these macros.
1848 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1849 EMACS_INT, since callers assume the returned value fits in int.
1850 (upcase1): Likewise, for UPCASE_TABLE.
1851 (uppercasep, lowercasep, upcase): New static inline functions.
1852 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1853 the race-condition problem in the old DOWNCASE.
1855 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1856 Rename locals to avoid shadowing.
1857 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1858 (regex_compile, re_search_2, re_match_2_internal):
1859 Remove unused local vars.
1860 (FREE_VAR): Rewrite so as not to use empty "else",
1861 which gcc can warn about.
1862 (regex_compile, re_match_2_internal): Mark locals as initialized.
1863 (RETALLOC_IF): Define only if needed.
1864 (WORDCHAR_P): Likewise. This one is never needed, but is used
1865 only in a comment talking about a compiler bug, so put inside
1866 the #if 0 of that comment.
1867 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1868 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1871 * search.c (boyer_moore): Rename locals to avoid shadowing.
1872 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1873 (PREV_CHAR_BOUNDARY): Likewise.
1875 * search.c (simple_search): Remove unused var.
1877 * dired.c (compile_pattern): Move decl from here ...
1878 * lisp.h: ... to here, so that it can be checked.
1879 (struct re_registers): New forward decl.
1881 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1883 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1885 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1886 Rename locals to avoid shadowing.
1887 (Fvertical_motion): Mark locals as initialized.
1889 * casefiddle.c (casify_object, casify_region): Now static.
1890 (casify_region): Mark local as initialized.
1892 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1894 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1895 New macros, so that the caller can use some names other than
1896 gcpro1, gcpro2, etc.
1897 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1899 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1900 argument, for consistency with GCPRO2_VAR, etc: it is now the
1901 prefix of the variable, not the variable itself. All uses
1903 * dired.c (directory_files_internal, file_name_completion):
1904 Rename locals to avoid shadowing.
1906 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1907 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1908 dired.c's scmp function, had undefined behavior.
1909 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1910 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1911 * buffer.h: ... to here, because these macros use current_buffer,
1912 and the new implementation with inline functions needs to have
1913 current_buffer in scope now, rather than later when the macros
1915 (downcase, upcase1): New static inline functions.
1916 (DOWNCASE, UPCASE1): Reimplement using these functions.
1917 This avoids undefined behavior in expressions like
1918 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1919 from race conditions in accessing the global variables
1920 case_temp1 and case_temp2.
1921 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1922 * lisp.h (case_temp1, case_temp2): Remove their decls.
1923 * character.h (ASCII_CHAR_P): Move from here ...
1924 * lisp.h: ... to here, so that the inline functions mentioned
1927 * dired.c (directory_files_internal_unwind): Now static.
1929 * fileio.c (file_name_as_directory, directory_file_name):
1930 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1932 (file_name_as_directory): Use const pointers when appropriate.
1933 (Fexpand_file_name): Likewise. In particular, newdir might
1934 point at constant storage, so make it a const pointer.
1935 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1936 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1938 (Fset_file_times, Finsert_file_contents, auto_save_error):
1939 Rename locals to avoid shadowing.
1941 * minibuf.c (choose_minibuf_frame_1): Now static.
1942 (Ftry_completion, Fall_completions): Rename or remove locals
1945 * marker.c (bytepos_to_charpos): Remove; unused.
1947 * lisp.h (verify_bytepos, count_markers): New decls,
1948 so that gcc does not warn that these functions aren't declared.
1950 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1951 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1952 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1953 (copy_text): Remove unused local var.
1955 * filelock.c (within_one_second): Now static.
1956 (lock_file_1): Rename local to avoid shadowing.
1958 * buffer.c (fix_overlays_before): Mark locals as initialized.
1959 (fix_start_end_in_overlays): Likewise. This function should be
1960 simplified by using pointers-to-pointers, but that's a different
1962 (switch_to_buffer_1): Now static.
1963 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1964 (report_overlay_modification): Rename locals to avoid shadowing.
1966 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1967 Fix pointer signedness issue.
1968 (sys_subshell): Mark local as volatile if checking for lint,
1969 to suppress a gcc -Wclobbered warning that does not seem to be right.
1970 (MAXPATHLEN): Define only if needed.
1972 * process.c (serial_open, serial_configure): Move decls from here ...
1973 * systty.h: ... to here, so that they can be checked.
1975 * fns.c (get_random, seed_random): Move extern decls from here ...
1976 * lisp.h: ... to here, so that they can be checked.
1978 * sysdep.c (reset_io): Now static.
1979 (wait_for_termination_signal): Remove; unused.
1981 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1982 (copy_keymap_item, append_key, push_text_char_description):
1984 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1985 (DENSE_TABLE_SIZE): Remove; unused.
1986 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1987 (describe_map_tree):
1988 Rename locals to avoid shadowing.
1990 * keyboard.c: Declare functions static if they are not used elsewhere.
1991 (echo_char, echo_dash, cmd_error, top_level_2):
1992 (poll_for_input, handle_async_input): Now static.
1993 (read_char, kbd_buffer_get_event, make_lispy_position):
1994 (make_lispy_event, make_lispy_movement, apply_modifiers):
1995 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1996 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1997 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1998 (read_key_sequence, read_char): Mark locals as initialized.
1999 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2001 * keyboard.h (make_ctrl_char): New decl.
2002 (mark_kboards): Move decl here ...
2003 * alloc.c (mark_kboards): ... from here.
2005 * lisp.h (force_auto_save_soon): New decl.
2007 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2008 (DEFINE_DUMMY_FUNCTION): New macro.
2009 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2011 (main): Add casts to avoid warnings
2012 if GCC considers string literals to be constants.
2014 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2016 * dbusbind.c: Pointer signedness fixes.
2017 (xd_signature, xd_append_arg, xd_initialize):
2018 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2019 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2020 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2021 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2023 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2024 if GCC considers string literals to be constants.
2025 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2027 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2029 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2030 (print_preprocess, print_object): New macro to fix last change.
2032 * print.c (print_preprocess): Don't forget font objects.
2034 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2036 * emacs.c (USAGE3): Doc fixes.
2038 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2040 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2043 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2045 * lisp.h (VWindow_system, Qfile_name_history):
2046 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2047 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2048 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2050 * w32select.c: Don't #include "keyboard.h".
2051 (run_protected): Add extern declaration for waiting_for_input.
2053 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2054 * w32console.c (detect_input_pending, read_input_pending)
2055 (encode_terminal_code):
2056 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2057 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2058 (w32_system_caret_y, Qfile_name_history):
2059 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2060 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2061 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2062 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2063 * w32proc.c (Qlocal, report_file_error):
2064 * w32term.c (Vwindow_system, updating_frame):
2065 * w32uniscribe.c (initialized, uniscribe_font_driver):
2066 Remove unneeded extern declarations.
2068 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2070 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2072 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2074 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2075 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2076 These macros can no longer be used for assignment.
2078 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2079 Assign struct members directly, instead of using BUF_BEGV etc.
2080 (record_buffer_markers, fetch_buffer_markers): New functions for
2081 recording and fetching special buffer markers.
2082 (set_buffer_internal_1, set_buffer_temp): Use them.
2084 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2086 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2088 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2089 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2091 * xdisp.c (hscroll_window_tree):
2092 (reconsider_clip_changes): Use PT instead of BUF_PT.
2094 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2096 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2097 $(EMACS_ROOT)/lib/intprops.h.
2099 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2101 Fix more problems found by GCC 4.5.2's static checks.
2103 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2104 to unsigned char * to avoid compiler diagnostic.
2105 (xg_free_frame_widgets): Make it clear that a local variable is
2106 needed only if USE_GTK_TOOLTIP.
2107 (gdk_window_get_screen): Make it clear that this macro is needed
2108 only if USE_GTK_TOOLTIP.
2109 (int_gtk_range_get_value): New function, which avoids a diagnostic
2110 from gcc -Wbad-function-cast.
2111 (xg_set_toolkit_scroll_bar_thumb): Use it.
2112 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2113 diagnostic from gcc -Wbad-function-cast.
2114 (get_utf8_string, xg_get_file_with_chooser):
2115 Rename locals to avoid shadowing.
2116 (create_dialog): Move locals to avoid shadowing.
2118 * xgselect.c (xg_select): Remove unused var.
2120 * image.c (four_corners_best): Mark locals as initialized.
2121 (gif_load): Initialize transparent_p to zero (Bug#8238).
2122 Mark another local as initialized.
2123 (my_png_error, my_error_exit): Mark with NO_RETURN.
2125 * image.c (clear_image_cache): Now static.
2126 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2127 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2128 (x_edge_detection): Remove unnecessary cast that
2129 gcc -Wbad-function-cast diagnoses.
2130 (gif_load): Fix pointer signedness.
2131 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2132 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2134 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2136 Improve quality of tests for time stamp overflow.
2137 For example, without this patch (encode-time 0 0 0 1 1
2138 1152921504606846976) returns the obviously-bogus value (-948597
2139 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2140 reports time overflow. See
2141 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2142 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2143 * editfns.c: Include limits.h and intprops.h.
2144 (TIME_T_MIN, TIME_T_MAX): New macros.
2145 (time_overflow): Move earlier, to before first use.
2146 (hi_time, lo_time): New functions, for an accurate test for
2148 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2149 (Fget_internal_run_time): Don't assume time_t fits in int.
2150 (make_time): Use list2 instead of Fcons twice.
2151 (Fdecode_time): More accurate test for out-of-range times.
2152 (check_tm_member): New function.
2153 (Fencode_time): Use it, to test for out-of-range times.
2154 (lisp_time_argument): Don't rely on undefined left-shift and
2155 right-shift behavior when checking for time stamp overflow.
2157 * editfns.c (time_overflow): New function, refactoring common code.
2158 (Fformat_time_string, Fdecode_time, Fencode_time):
2159 (Fcurrent_time_string): Use it.
2161 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2162 * dired.c (make_time): Move to ...
2163 * editfns.c (make_time): ... here.
2164 * systime.h: Note the move.
2166 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2168 * fringe.c (update_window_fringes): Remove unused variables.
2170 * unexmacosx.c (copy_data_segment): Also copy __got section.
2173 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2175 * termcap.c [MSDOS]: Include "msdos.h".
2176 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2177 Constify `char *' arguments and their references according to
2178 prototypes in tparam.h.
2180 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2182 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2183 Adapt all references accordingly.
2185 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2187 2011-03-11 Tom Tromey <tromey@redhat.com>
2189 * buffer.c (syms_of_buffer): Remove obsolete comment.
2191 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2193 * termhooks.h (encode_terminal_code): Declare prototype.
2195 * msdos.c (encode_terminal_code): Don't declare prototype.
2197 * term.c (encode_terminal_code): Now external again, used by
2198 w32console.c and msdos.c.
2200 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2201 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2203 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2205 Fix some minor problems found by GCC 4.5.2's static checks.
2207 * fringe.c (update_window_fringes): Mark locals as initialized
2209 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2211 * alloc.c (mark_fringe_data): Move decl from here ...
2212 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2213 to check its interface.
2214 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2216 * fontset.c (free_realized_fontset): Now static.
2217 (Fset_fontset_font): Rename local to avoid shadowing.
2218 (fontset_font): Mark local as initialized.
2219 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2221 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2223 * xselect.c (x_disown_buffer_selections): Remove; not used.
2224 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2225 (x_own_selection, Fx_disown_selection_internal): Rename locals
2227 (x_handle_dnd_message): Remove local to avoid shadowing.
2229 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2230 so that the caller can use some name other than gcpro1.
2231 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2232 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2233 (Fx_backspace_delete_keys_p):
2234 Use them to avoid shadowing, and rename vars to avoid shadowing.
2235 (x_decode_color, x_set_name, x_window): Now static.
2236 (Fx_create_frame): Add braces to silence GCC warning.
2237 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2238 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2239 Remove unused locals.
2240 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2241 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2242 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2245 * xterm.h (x_mouse_leave): New decl.
2247 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2248 Remove unused functions.
2249 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2250 (x_calc_absolute_position): Now static.
2251 (XTread_socket): Don't define label "out" unless it's used.
2252 Don't declare local "event" unless it's used.
2253 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2254 unless they are used.
2255 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2256 (x_fatal_error_signal): Remove; not used.
2257 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2258 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2259 (x_error_catcher, x_connection_closed, x_error_handler):
2260 (x_error_quitter, xembed_send_message, x_iconify_frame):
2261 (my_log_handler): Rename locals to avoid shadowing.
2262 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2263 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2265 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2266 Rename or move locals to avoid shadowing.
2267 (tty_defined_color, merge_face_heights): Now static.
2268 (free_realized_faces_for_fontset): Remove; not used.
2269 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2270 does not deduce is never used uninitialized.
2271 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2272 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2274 * terminal.c (store_terminal_param): Now static.
2276 * xmenu.c (menu_highlight_callback): Now static.
2277 (set_frame_menubar): Remove unused local.
2278 (xmenu_show): Rename parameter to avoid shadowing.
2279 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2280 since they might point to immutable storage.
2281 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2282 since it's unused otherwise.
2284 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2285 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2286 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2287 avoids a gcc -Wuninitialized diagnostic.
2288 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2289 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2290 does not deduce are never used uninitialized.
2292 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2294 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2295 * window.c (window_loop, size_window):
2296 (run_window_configuration_change_hook, enlarge_window): Likewise.
2298 * window.c (display_buffer): Now static.
2299 (size_window): Mark variables that gcc -Wuninitialized
2300 does not deduce are never used uninitialized.
2301 * window.h (check_all_windows): New decl, to forestall
2302 gcc -Wmissing-prototypes diagnostic.
2303 * dispextern.h (bidi_dump_cached_states): Likewise.
2305 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2307 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2309 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2310 and to avoid gcc -Wuninitialized warning.
2311 (load_charset_map): Mark variables that gcc -Wuninitialized
2312 does not deduce are never used uninitialized.
2313 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2315 * coding.c (coding_set_source, coding_set_destination):
2316 Use "else { /* comment */ }" rather than "else /* comment */;"
2317 for clarity, and to avoid gcc -Wempty-body warning.
2318 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2319 a block, when the outer 'i' will do.
2320 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2321 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2322 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2323 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2324 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2325 Rename locals to avoid shadowing.
2326 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2327 * coding.c (emacs_mule_char, encode_invocation_designation):
2328 Now static, since they're not used elsewhere.
2329 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2330 (decode_coding_object, encode_coding_object, detect_coding_system):
2331 (decode_coding_emacs_mule): Mark variables that gcc
2332 -Wuninitialized does not deduce are never used uninitialized.
2333 (detect_coding_iso_2022): Initialize a local variable that might
2334 be used uninitialized. Leave a FIXME because it's not clear that
2335 this initialization is needed. (Bug#8211)
2336 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2337 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2338 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2339 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2340 Remove unused macros.
2342 * category.c (hash_get_category_set): Remove unused local var.
2343 (copy_category_table): Now static, since it's not used elsewhere.
2344 * character.c (string_count_byte8): Likewise.
2346 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2347 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2349 * chartab.c (copy_sub_char_table): Now static, since it's not used
2351 (sub_char_table_ref_and_range, char_table_ref_and_range):
2352 Rename locals to avoid shadowing.
2353 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2355 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2356 (BIDI_BOB): Remove unused macro.
2358 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2359 deduce are never used uninitialized.
2360 * term.c (encode_terminal_code): Likewise.
2362 * term.c (encode_terminal_code): Now static. Remove unused local.
2364 * tparam.h: New file.
2365 * term.c, tparam.h: Include it.
2366 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2367 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2368 Move these decls to tparam.h, and make them agree with what
2369 is actually in tparam.c. The previous trick of using incompatible
2370 decls in different modules does not conform to the C standard.
2371 All callers of tparam changed to use tparam's actual API.
2372 * tparam.c (tparam1, tparam, tgoto):
2373 Use const pointers where appropriate.
2375 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2376 * cm.h (struct cm): Likewise.
2377 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2378 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2379 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2380 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2381 (turn_on_face, init_tty): Likewise.
2382 * termchar.h (struct tty_display_info): Likewise.
2384 * term.c (term_mouse_position): Rename local to avoid shadowing.
2386 * alloc.c (mark_ttys): Move decl from here ...
2387 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2389 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2391 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2393 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2395 * search.c (compile_pattern_1): Remove argument regp, unused since
2396 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2397 (compile_pattern): Don't pass it.
2399 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2401 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2402 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2404 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2406 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2408 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2409 gdk_window_get_screen, gdk_window_get_geometry,
2410 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2411 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2412 (xg_get_pixbuf_from_pixmap): New function.
2413 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2414 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2415 Call xg_get_pixbuf_from_pixmap instead of
2416 gdk_pixbuf_get_from_drawable.
2417 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2418 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2419 (xg_check_special_colors): Use GtkStyleContext and its functions
2421 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2422 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2423 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2424 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2425 Call gtk_widget_get_preferred_size.
2426 (xg_frame_resized): gdk_window_get_geometry only takes 5
2428 (xg_win_to_widget, xg_event_is_for_menubar):
2429 Call gdk_x11_window_lookup_for_display.
2430 (xg_set_widget_bg): New function.
2431 (delete_cb): New function.
2432 (xg_create_frame_widgets): connect delete-event to delete_cb.
2433 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2434 (xg_set_background_color): Call xg_set_widget_bg.
2435 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2436 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2437 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2438 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2440 (update_frame_tool_bar): Call gtk_widget_hide.
2441 (xg_initialize): Use GDK_KEY_g.
2443 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2445 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2447 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2448 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2449 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2451 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2453 * w32xfns.c (select_palette): Check success of RealizePalette against
2454 GDI_ERROR, not zero.
2456 See ChangeLog.11 for earlier changes.
2462 Copyright (C) 2011 Free Software Foundation, Inc.
2464 This file is part of GNU Emacs.
2466 GNU Emacs is free software: you can redistribute it and/or modify
2467 it under the terms of the GNU General Public License as published by
2468 the Free Software Foundation, either version 3 of the License, or
2469 (at your option) any later version.
2471 GNU Emacs is distributed in the hope that it will be useful,
2472 but WITHOUT ANY WARRANTY; without even the implied warranty of
2473 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2474 GNU General Public License for more details.
2476 You should have received a copy of the GNU General Public License
2477 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.