* process.c (Fnetwork_interface_info): Declare local only if needed.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 * process.c (Fnetwork_interface_info): Declare local only if needed.
4
5 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6
7 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8 (Fnetwork_interface_list): Allocate in increments of bytes instead
9 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
10 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
11 sockaddr.
12 (struct ifflag_def): notrailers is smart on OSX.
13 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
14 Get hardware address with getifaddrs if available.
15
16 2011-08-12 Eli Zaretskii <eliz@gnu.org>
17
18 * xdisp.c (iterate_out_of_display_property): xassert that
19 IT->position is set to within IT->object's boundaries. Break from
20 the loop as soon as EOB is reached; avoids infloops in redisplay
21 when IT->position is set up wrongly due to some bug. Set
22 IT->current to match the bidi iterator unconditionally.
23 (push_display_prop): Allow GET_FROM_STRING as IT->method on
24 entry. Force push_it to save on the stack the current
25 buffer/string position, to be restored by pop_it. Fix flags in
26 the iterator structure wrt the object coming from a display
27 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
28 properties. (Bug#9284)
29
30 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
31
32 * fontset.c (fontset_get_font_group): Add proper type checks.
33 (Bug#9172)
34
35 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
36
37 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
38 and LC_VERSION_MIN_MACOSX.
39 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
40 (dump_it) [LC_FUNCTION_STARTS]: Use it.
41
42 2011-08-08 Eli Zaretskii <eliz@gnu.org>
43
44 * xdisp.c (forward_to_next_line_start): Allow to use the
45 no-display-properties-and-no-overlays under bidi display. Set
46 disp_pos in the bidi iterator to avoid searches for display
47 properties and overlays.
48
49 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
50
51 * editfns.c (Fset_time_zone_rule): Document relationship with the
52 setenv function.
53
54 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
55 the font entity extracted from the cache (Bug#8109).
56
57 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
58
59 * composite.c (autocmp_chars): Don't reset point. That is done by
60 restore_point_unwind (Bug#5984).
61
62 2011-08-07 Juri Linkov <juri@jurta.org>
63
64 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
65 to show the arg `TIME' instead of `TIMEVAL'.
66
67 2011-08-06 Eli Zaretskii <eliz@gnu.org>
68
69 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
70 display property strides EOL and includes a newline, as in
71 longlines-mode. (Bug#9254)
72 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
73 word-wrap under bidirectional display. (Bug#9224)
74
75 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
76 is non-zero, even if the data buffer is NULL. Fixes a crash in
77 vertical-motion with longlines-mode. (Bug#9254)
78
79 2011-08-05 Eli Zaretskii <eliz@gnu.org>
80
81 * bidi.c <bidi_cache_total_alloc>: Now static.
82 (bidi_initialize): Initialize bidi_cache_total_alloc.
83
84 *xdisp.c (display_line): Release buffer allocated for shelved bidi
85 cache. (Bug#9221)
86
87 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
88 amount allocated this far in `bidi_cache_total_alloc'.
89 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
90 non-zero, only free the data buffer without restoring the cache
91 contents. All callers changed.
92
93 * dispextern.h (bidi_unshelve_cache): Update prototype.
94
95 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
96 (move_it_in_display_line, move_it_to)
97 (move_it_vertically_backward, move_it_by_lines): Replace the call
98 to xfree to an equivalent call to bidi_unshelve_cache.
99 (move_it_in_display_line_to): Fix logic of returning
100 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
101
102 2011-08-05 Eli Zaretskii <eliz@gnu.org>
103
104 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
105 came from a string character with a `cursor' property. (Bug#9229)
106
107 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
108
109 * Makefile.in (LIB_PTHREAD): New variable.
110 (LIBES): Add LIB_PTHREAD (Bug#9216).
111
112 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
113 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
114
115 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
116
117 * regex.c (re_iswctype): Remove some redundant boolean
118 conversions.
119
120 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
121
122 * xterm.c (x_find_topmost_parent): New function.
123 (x_set_frame_alpha): Find topmost parent window with
124 x_find_topmost_parent and set the property there also (bug#9181).
125 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
126
127 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
128
129 * callproc.c (Fcall_process): Avoid vfork clobbering
130 the local vars buffer, coding_systems, current_dir.
131
132 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
133
134 * keymap.c (Fmake_composed_keymap): Move to subr.el.
135
136 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
137
138 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
139 so that it is not optimized away.
140
141 * xdisp.c (compute_display_string_pos): Remove unused local.
142
143 2011-08-02 Eli Zaretskii <eliz@gnu.org>
144
145 Fix slow cursor motion and scrolling in large buffers with
146 selective display, like Org Mode buffers. (Bug#9218)
147
148 * dispextern.h (struct bidi_it): New member disp_prop_p.
149
150 * xdisp.c: Remove one-slot cache of display string positions.
151 (compute_display_string_pos): Accept an additional argument
152 DISP_PROP_P; callers changed. Scan at most 5K characters forward
153 for a display string or property. If found, set DISP_PROP_P
154 non-zero.
155
156 * bidi.c (bidi_fetch_char): Accept an additional argument
157 DISP_PROP_P, and pass it to compute_display_string_pos.
158 Only handle text covered by a display string if DISP_PROP_P is returned
159 non-zero. All callers of bidi_fetch_char changed.
160
161 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
162
163 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
164
165 2010-12-03 Don March <don@ohspite.net>
166
167 * keymap.c (Fdefine_key): Fix non-prefix key error message when
168 last character M-[char] is translated to ESC [char] (bug#7541).
169
170 2011-08-02 Kenichi Handa <handa@m17n.org>
171
172 * lisp.h (uniprop_table): Extern it.
173
174 * chartab.c (uniprop_table): Make it non-static.
175
176 2011-08-01 Eli Zaretskii <eliz@gnu.org>
177
178 * xdisp.c (forward_to_next_line_start): Accept additional argument
179 BIDI_IT_PREV, and store into it the state of the bidi iterator had
180 on the newline.
181 (reseat_at_next_visible_line_start): Use the bidi iterator state
182 returned by forward_to_next_line_start to restore the state of
183 it->bidi_it after backing up to previous newline. (Bug#9212)
184
185 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
186
187 * regex.c (re_comp): Protoize.
188 (re_exec): Fix return type.
189 (regexec): Fix type of `ret'. (Bug#9203)
190
191 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
192
193 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
194 This is needed if max-image-size is a floating-point number.
195
196 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
197
198 * print.c (print_object): Print empty symbol as ##.
199
200 * lread.c (read1): Read ## as empty symbol.
201
202 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
203
204 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
205 setting frame foreground color (Bug#9175).
206 (x_set_background_color): Likewise.
207
208 * nsmenu.m (-setText): Size tooltip dimensions precisely to
209 contents (Bug#9176).
210 (EmacsTooltip -init): Remove bezels and add shadows to
211 tooltip windows.
212
213 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
214 or scroll bar (Bug#8470).
215
216 * nsfont.m (nsfont_open): Remove assignment to voffset and
217 unnecessary vars hshink, expand, hd, full_height, min_height.
218 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
219
220 * nsterm.h (nsfont_info): Remove voffset field.
221
222 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
223
224 Implement strike-through and overline on NextStep (Bug#8863).
225
226 * nsfont.m (nsfont_open): Use underline position provided by font,
227 instead of hard-coded value of 2.
228 (nsfont_draw): Call ns_draw_text_decoration instead.
229
230 * nsterm.h: Add declaration for ns_draw_text_decoration.
231
232 * nsterm.m (ns_draw_text_decoration): New function for drawing
233 underline, overline, and strike-through.
234 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
235 ns_draw_text_decoration. Change treatment of cursor drawing to
236 accomodate underlining, etc.
237
238 2011-07-28 Eli Zaretskii <eliz@gnu.org>
239
240 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
241 default.
242
243 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
244
245 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
246 Without this fix, if a signal arrives just after memory fills up,
247 'malloc' might be invoked reentrantly.
248
249 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
250 In other words, assume that every image size is allowed, on non-X
251 hosts. This assumption is probably wrong, but it lets Emacs compile.
252
253 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
254
255 * regex.c (re_iswctype): Convert return values to boolean.
256
257 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
258
259 * xdisp.c (compute_display_string_pos): Don't use cached display
260 string position if the buffer had its restriction changed.
261 (Bug#9184)
262
263 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
264
265 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
266
267 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
268
269 Integer signedness and overflow and related fixes. (Bug#9079)
270
271 * bidi.c: Integer size and overflow fixes.
272 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
273 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
274 (bidi_cache_find_level_change, bidi_cache_ensure_space)
275 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
276 (bidi_find_other_level_edge):
277 Use ptrdiff_t instead of EMACS_INT where either will do.
278 This works better on 32-bit hosts configured --with-wide-int.
279 (bidi_cache_ensure_space): Check for size-calculation overflow.
280 Use % rather than repeated addition, for better worst-case speed.
281 Don't set bidi_cache_size until after xrealloc returns, because it
282 might not return.
283 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
284 (bidi_cache_ensure_space): Also check that the bidi cache size
285 does not exceed that of the largest Lisp string or buffer. See Eli
286 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
287
288 * alloc.c (__malloc_size_t): Remove.
289 All uses replaced by size_t. See Andreas Schwab's note
290 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
291
292 * image.c: Improve checking for integer overflow.
293 (check_image_size): Assume that f is nonnull, since
294 it is always nonnull in practice. This is one less thing to
295 worry about when checking for integer overflow later.
296 (x_check_image_size): New function, which checks for integer
297 overflow issues inside X.
298 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
299 This removes the need for a memory_full check.
300 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
301 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
302 (xbm_read_bitmap_data): Change locals back to 'int', since
303 their values must fit in 'int'.
304 (xpm_load_image, png_load, tiff_load):
305 Invoke x_create_x_image_and_pixmap earlier,
306 to avoid much needless work if the image is too large.
307 (tiff_load): Treat overly large images as if
308 x_create_x_image_and_pixmap failed, not as malloc failures.
309 (gs_load): Use x_check_image_size.
310
311 * gtkutil.c: Omit integer casts.
312 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
313 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
314
315 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
316
317 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
318 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
319 would wrongly return t on a 64-bit host.
320
321 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
322 The plain *_OVERFLOW macros run afoul of GCC bug 49705
323 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
324 and therefore cause GCC to emit a bogus diagnostic in some cases.
325
326 * image.c: Integer signedness and overflow and related fixes.
327 This is not an exhaustive set of fixes, but it's time to
328 record what I've got.
329 (lookup_pixel_color, check_image_size): Remove redundant decls.
330 (check_image_size): Don't assume that arbitrary EMACS_INT values
331 fit in 'int', or that arbitrary 'double' values fit in 'int'.
332 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
333 (tiff_load, imagemagick_load_image):
334 Check for overflow in size calculations.
335 (x_create_x_image_and_pixmap): Remove unnecessary test for
336 xmalloc returning NULL; that can't happen.
337 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
338 (xpm_color_bucket): Use better integer hashing function.
339 (xpm_cache_color): Don't possibly over-allocate memory.
340 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
341 (gif_memory_source):
342 Use ptrdiff_t, not int or size_t, to record sizes.
343 (png_load): Don't assume values greater than 2**31 fit in 'int'.
344 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
345 either works, as we prefer signed integers.
346 (tiff_read_from_memory, tiff_write_from_memory):
347 Return tsize_t, not size_t, since that's what the TIFF API wants.
348 (tiff_read_from_memory): Don't fail simply because the read would
349 go past EOF; instead, return a short read.
350 (tiff_load): Omit no-longer-needed casts.
351 (Fimagemagick_types): Don't assume size fits into 'int'.
352
353 Improve hashing quality when configured --with-wide-int.
354 * fns.c (hash_string): New function, taken from sxhash_string.
355 Do not discard information about ASCII character case; this
356 discarding is no longer needed.
357 (sxhash-string): Use it. Change sig to match it. Caller changed.
358 * lisp.h: Declare it.
359 * lread.c (hash_string): Remove, since we now use fns.c's version.
360 The fns.c version returns a wider integer if --with-wide-int is
361 specified, so this should help the quality of the hashing a bit.
362
363 * emacs.c: Integer overflow minor fix.
364 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
365 Define only if GNU_LINUX.
366 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
367
368 * dispnew.c: Integer signedness and overflow fixes.
369 Remove unnecessary forward decls, that were a maintenance hassle.
370 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
371 All uses changed.
372 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
373 (scrolling_window): Use ptrdiff_t, not int, for byte count.
374 (prepare_desired_row, line_draw_cost):
375 Use int, not unsigned, where either works.
376 (save_current_matrix, restore_current_matrix):
377 Use ptrdiff_t, not size_t, where either works.
378 (init_display): Check for overflow more accurately, and without
379 relying on undefined behavior.
380
381 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
382 Remove, replacing with the new symbols in lisp.h. All uses changed.
383 * fileio.c (make_temp_name):
384 * filelock.c (lock_file_1, lock_file):
385 * xdisp.c (message_dolog):
386 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
387 Use pMd etc. instead.
388 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
389 replacing the pWIDE etc. symbols removed from editfns.c.
390
391 * keyboard.h (num_input_events): Now uintmax_t.
392 This is (very slightly) less likely to mess up due to wraparound.
393 All uses changed.
394
395 * buffer.c: Integer signedness fixes.
396 (alloc_buffer_text, enlarge_buffer_text):
397 Use ptrdiff_t rather than size_t when either will do, as we prefer
398 signed integers.
399
400 * alloc.c: Integer signedness and overflow fixes.
401 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
402 (__malloc_size_t): Default to size_t, not to int.
403 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
404 (Fgarbage_collect, mark_object_loop_halt, mark_object):
405 Prefer ptrdiff_t to size_t when either would do, as we prefer
406 signed integers.
407 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
408 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
409 Now const. Initialize with values that are in range even if char
410 is signed.
411 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
412 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
413 These functions do the right thing with sizes > 2**32.
414 (check_depth): Now ptrdiff_t, not int.
415 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
416 Adjust to new way of storing sizes. Check for size overflow bugs
417 in rest of code.
418 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
419 slightly wrong anyway, as it missed one instance of
420 XMALLOC_OVERRUN_CHECK_OVERHEAD.
421 (refill_memory_reserve): Omit needless cast to size_t.
422 (mark_object_loop_halt): Mark as externally visible.
423
424 * xselect.c: Integer signedness and overflow fixes.
425 (Fx_register_dnd_atom, x_handle_dnd_message):
426 Use ptrdiff_t, not size_t, since we prefer signed.
427 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
428 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
429 x_dnd_atoms_size and x_dnd_atoms_length.
430
431 * doprnt.c: Prefer signed to unsigned when either works.
432 * eval.c (verror):
433 * doprnt.c (doprnt):
434 * lisp.h (doprnt):
435 * xdisp.c (vmessage):
436 Use ptrdiff_t, not size_t, when using or implementing doprnt,
437 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
438 prefer signed arithmetic to avoid comparison confusion.
439 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
440 but is a bit tricky.
441
442 Assume freestanding C89 headers, string.h, stdlib.h.
443 * data.c, doprnt.c, floatfns.c, print.c:
444 Include float.h unconditionally.
445 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
446 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
447 * regex.c: Likewise for stddef.h, string.h.
448 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
449 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
450 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
451 (STDC_HEADERS): Remove obsolete defines.
452 * sysdep.c: Include limits.h unconditionally.
453
454 Assume support for memcmp, memcpy, memmove, memset.
455 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
456 * regex.c (memcmp, memcpy):
457 Remove; we assume C89 now.
458
459 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
460 (__malloc_safe_bcopy): Remove; no longer needed.
461
462 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
463 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
464 well either way, and we prefer signed to unsigned.
465
466 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
467
468 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
469 closes the connection while we're reading (bug#9182).
470
471 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
472
473 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
474 are specified (Bug#9168).
475
476 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
477
478 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
479 Found by GCC static checking and --with-wide-int on a 32-bit host.
480
481 2011-07-25 Eli Zaretskii <eliz@gnu.org>
482
483 * xdisp.c (compute_display_string_pos): Fix logic of caching
484 previous display string position. Initialize cached_prev_pos to
485 -1. Fixes slow-down at the beginning of a buffer.
486
487 2011-07-24 Eli Zaretskii <eliz@gnu.org>
488
489 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
490 for attrs[LFACE_FONTSET_INDEX].
491
492 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
493
494 * xml.c (parse_region): Remove unused local
495 that was recently introduced.
496
497 2011-07-23 Eli Zaretskii <eliz@gnu.org>
498
499 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
500 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
501
502 * xdisp.c (move_it_in_display_line_to): Record the best matching
503 position for TO_CHARPOS while scanning the line, and restore it on
504 exit if none of the characters scanned was an exact match.
505 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
506 when exact match is impossible due to invisible text, and the
507 lines are truncated.
508
509 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
510
511 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
512 for OSX >= 10.7.
513
514 2011-07-22 Eli Zaretskii <eliz@gnu.org>
515
516 Fix a significant slow-down of cursor motion with C-n, C-p,
517 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
518 auto-repeat under bidi redisplay in fontified buffers.
519 * xdisp.c (compute_stop_pos_backwards): New function.
520 (next_element_from_buffer): Call compute_stop_pos_backwards to
521 find a suitable prev_stop when we find ourselves before
522 base_level_stop.
523 (reseat): Don't look for prev_stop, as that could mean a very long
524 run.
525 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
526 <cached_disp_overlay_modiff>: Cache for last found display string
527 position.
528 (compute_display_string_pos): Return the cached position if asked
529 about the same buffer in the same area of character positions, and
530 the buffer wasn't changed since the time the display string
531 position was cached.
532
533 2011-07-22 Eli Zaretskii <eliz@gnu.org>
534
535 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
536 is an integer, which is important for empty lines. (Bug#9149)
537
538 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
539
540 * frame.c (Fmodify_frame_parameters): In tty case, update the
541 default face if necessary (Bug#4238).
542
543 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
544
545 * editfns.c (Fstring_to_char): No need to explain what a character
546 is in the docstring (Bug#6576).
547
548 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
549
550 * xml.c (parse_region): Make sure we always return a tree.
551
552 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
553
554 * xml.c (parse_region): If a document contains only comments,
555 return that, too.
556
557 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
558
559 * xml.c (make_dom): Return comments, too.
560
561 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
562
563 Port to OpenBSD.
564 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
565 and the surrounding thread.
566 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
567 rather than fgets, and retry after EINTR. Otherwise, 'emacs
568 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
569 timer goes off.
570 * s/openbsd.h (BROKEN_SIGIO): Define.
571 * unexelf.c (unexec) [__OpenBSD__]:
572 Don't update the .mdebug section of the Alpha COFF symbol table.
573
574 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
575
576 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
577 (bug#8460).
578
579 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
580
581 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
582 This fixes some race conditions on the permissions of any newly
583 created file.
584
585 * alloc.c (valid_pointer_p): Use pipe, not open.
586 This fixes some permissions issues when debugging.
587
588 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
589 If fchown fails to set both uid and gid, try to set just gid,
590 as that is sometimes allowed. Adjust the file's mode to eliminate
591 setuid or setgid bits that are inappropriate if fchown fails.
592
593 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
594
595 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
596 to compare Lisp_Objects.
597 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
598 global_gnutls_log_level, don't mistake it for a Lisp_Object.
599 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
600
601 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
602
603 * lread.c (read_integer): Unread even EOF character.
604 (read1): Likewise. Properly record start position of symbol.
605
606 * lread.c (read1): Read `#:' as empty uninterned symbol if no
607 symbol character follows.
608
609 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
610
611 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
612 This works around a problem with the previous change to Fcopy_file.
613 Recent glibc declares fchown with __attribute__((warn_unused_result)),
614 and without this change, GCC might complain about discarding
615 fchown's return value.
616
617 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
618
619 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
620
621 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
622
623 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
624
625 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
626
627 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
628 it's used from the C level.
629
630 * process.c: Use the same condition for POLL_FOR_INPUT in both
631 keyboard.c and process.c (bug#1858).
632
633 2011-07-09 Lawrence Mitchell <wence@gmx.li>
634
635 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
636 (Fgnutls_boot): Use it.
637
638 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
639
640 * doc.c (Fsubstitute_command_keys): Revert last change.
641
642 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
643
644 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
645 quotes the next character, and doesn't affect other longer
646 sequences (bug#8935).
647
648 * lread.c (syms_of_lread): Clarify that is isn't only
649 `eval-buffer' and `eval-defun' that's affected by
650 `lexical-binding' (bug#8460).
651
652 2011-07-15 Eli Zaretskii <eliz@gnu.org>
653
654 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
655 bidi redisplay when a line includes both an image and is
656 truncated.
657
658 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
659
660 Fix minor problems found by static checking.
661 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
662 (elsz): Now a signed constant, not a size_t var. We prefer signed
663 types to unsigned, to avoid integer comparison confusion. Without
664 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
665 "cannot optimize loop, the loop counter may overflow", a symptom
666 of the confusion.
667 * indent.c (Fvertical_motion): Mark locals as initialized.
668 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
669
670 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
671
672 * search.c (Fre_search_backward): Mention `case-fold-search' in
673 all the re_search_* functions (bug#8138).
674
675 * keyboard.c (Fopen_dribble_file): Document when the file is
676 closed (bug#8056).
677
678 2011-07-14 Eli Zaretskii <eliz@gnu.org>
679
680 * bidi.c (bidi_dump_cached_states): Fix format of displaying
681 bidi_cache_idx.
682
683 Support bidi reordering of display and overlay strings.
684 * xdisp.c (compute_display_string_pos)
685 (compute_display_string_end): Accept additional argument STRING.
686 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
687 (reseat_to_string): Initialize bidi_it->string.s and
688 bidi_it->string.schars.
689 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
690 NULL (avoids a crash in bidi_paragraph_init).
691 Initialize itb.string.lstring.
692 (init_iterator): Call bidi_init_it only of a valid
693 buffer position was specified. Initialize paragraph_embedding to
694 L2R.
695 (reseat_to_string): Initialize the bidi iterator.
696 (display_string): If we need to ignore text properties of
697 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
698 original value of -1 will not work with bidi.)
699 (compute_display_string_pos): First arg is now struct
700 `text_pos *'; all callers changed. Support display properties on
701 Lisp strings.
702 (compute_display_string_end): Support display properties on Lisp
703 strings.
704 (init_iterator, reseat_1, reseat_to_string): Initialize the
705 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
706 when iterating on a string not from display properties).
707 (compute_display_string_pos, compute_display_string_end):
708 Fix calculation of the object to scan. Fixes an error when using
709 arrow keys.
710 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
711 base_level_stop; instead, set base_level_stop to BEGV.
712 Fixes crashes in vertical-motion.
713 (next_element_from_buffer): Improve commentary for when
714 the iterator is before prev_stop.
715 (init_iterator): Initialize bidi_p from the default value of
716 bidi-display-reordering, not from buffer-local value. Use the
717 buffer-local value only if initializing for buffer iteration.
718 (handle_invisible_prop): Support invisible properties on strings
719 that are being bidi-reordered.
720 (set_iterator_to_next): Support bidi reordering of C strings and
721 Lisp strings.
722 (next_element_from_string): Support bidi reordering of Lisp
723 strings.
724 (handle_stop_backwards): Support Lisp strings as well.
725 (display_string): Support display of R2L glyph rows.
726 Use IT_STRING_CHARPOS when displaying from a Lisp string.
727 (init_iterator): Don't initialize it->bidi_p for strings
728 here.
729 (reseat_to_string): Initialize it->bidi_p for strings here.
730 (next_element_from_string, next_element_from_c_string)
731 (next_element_from_buffer): Add xassert's for correspondence
732 between IT's object being iterated and it->bidi_it.string
733 structure.
734 (face_before_or_after_it_pos): Support bidi iteration.
735 (next_element_from_c_string): Handle the case of the first string
736 character that is not the first one in the visual order.
737 (get_visually_first_element): New function, refactored from common
738 parts of next_element_from_buffer, next_element_from_string, and
739 next_element_from_c_string.
740 (tool_bar_lines_needed, redisplay_tool_bar)
741 (display_menu_bar): Force left-to-right direction. Add a FIXME
742 comment for making that be controlled by a user option.
743 (push_it, pop_it): Save and restore the state of the
744 bidi iterator. Save and restore the bidi_p flag.
745 (pop_it): Iterate out of display property for string iteration as
746 well.
747 (iterate_out_of_display_property): Support iteration over strings.
748 (handle_single_display_spec): Set up it->bidi_it for iteration
749 over a display string, and call bidi_init_it.
750 (handle_single_display_spec, next_overlay_string)
751 (get_overlay_strings_1, push_display_prop): Set up the bidi
752 iterator for displaying display or overlay strings.
753 (forward_to_next_line_start): Don't use the shortcut if
754 bidi-iterating.
755 (back_to_previous_visible_line_start): If handle_display_prop
756 pushed the iterator stack, restore the internal state of the bidi
757 iterator by calling bidi_pop_it same number of times.
758 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
759 and we are bidi-iterating, don't decrement the iterator position;
760 instead, set the first_elt flag in the bidi iterator, to produce
761 the same effect.
762 (reseat_1): Remove redundant setting of string_from_display_prop_p.
763 (push_display_prop): xassert that we are iterating a buffer.
764 (push_it, pop_it): Save and restore paragraph_embedding member.
765 (handle_single_display_spec, next_overlay_string)
766 (get_overlay_strings_1, reseat_1, reseat_to_string)
767 (push_display_prop): Set up the `unibyte' member of bidi_it.string
768 correctly. Don't assume unibyte strings are not bidi-reordered.
769 (compute_display_string_pos)
770 (compute_display_string_end): Fix handling the case of C string.
771 (push_it, pop_it): Save and restore from_disp_prop_p.
772 (handle_single_display_spec, push_display_prop): Set the
773 from_disp_prop_p flag.
774 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
775 (pop_it): Call iterate_out_of_display_property only if we are
776 popping after iteration over a string that came from a display
777 property. Fix a typo in popping stretch info. Add an assertion
778 for verifying that the iterator position is in sync with the bidi
779 iterator.
780 (handle_single_display_spec, get_overlay_strings_1)
781 (push_display_prop): Fix initialization of paragraph direction for
782 string when that of the parent object is not yet determined.
783 (reseat_1): Call bidi_init_it to resync the bidi
784 iterator with IT's position. (Bug#7616)
785 (find_row_edges): If ROW->start.pos gives position
786 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
787 (handle_stop, back_to_previous_visible_line_start, reseat_1):
788 Reset the from_disp_prop_p flag.
789 (SAVE_IT, RESTORE_IT): New macros.
790 (pos_visible_p, face_before_or_after_it_pos)
791 (back_to_previous_visible_line_start)
792 (move_it_in_display_line_to, move_it_in_display_line)
793 (move_it_to, move_it_vertically_backward, move_it_by_lines)
794 (try_scrolling, redisplay_window, display_line): Use them when
795 saving a temporary copy of the iterator and restoring it back.
796 (back_to_previous_visible_line_start, reseat_1)
797 (init_iterator): Empty the bidi cache "stack".
798 (move_it_in_display_line_to): If iterator ended up at
799 EOL, but we never saw any buffer positions smaller than
800 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
801 motion in bidi-reordered lines.
802 (move_it_in_display_line_to): Record prev_method and prev_pos
803 immediately before the call to set_iterator_to_next. Fixes cursor
804 motion in bidi-reordered lines with stretch glyphs and strings
805 displayed in margins. (Bug#8133) (Bug#8867)
806 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
807 TO_CHARPOS.
808 (pos_visible_p): Support positions in bidi-reordered lines.
809 Save and restore bidi cache.
810
811 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
812 (bidi_paragraph_info): Delete unused struct.
813 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
814 (bidi_cache_start): New variable.
815 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
816 to zero.
817 (bidi_cache_fetch_state, bidi_cache_search)
818 (bidi_cache_find_level_change, bidi_cache_iterator_state)
819 (bidi_cache_find, bidi_peek_at_next_level)
820 (bidi_level_of_next_char, bidi_find_other_level_edge)
821 (bidi_move_to_visually_next): Compare cache index with
822 bidi_cache_start rather than with zero.
823 (bidi_fetch_char): Accept new argument STRING; all callers
824 changed. Support iteration over a string. Support strings with
825 display properties. Support unibyte strings. Fix the type of
826 `len' according to what STRING_CHAR_AND_LENGTH expects.
827 (bidi_paragraph_init, bidi_resolve_explicit_1)
828 (bidi_resolve_explicit, bidi_resolve_weak)
829 (bidi_level_of_next_char, bidi_move_to_visually_next):
830 Support iteration over a string.
831 (bidi_set_sor_type, bidi_resolve_explicit_1)
832 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
833 can now be zero (for strings); special values 0 and -1 were
834 changed to -1 and -2, respectively.
835 (bidi_char_at_pos): New function.
836 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
837 Call it instead of FETCH_MULTIBYTE_CHAR.
838 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
839 initialized to valid values.
840 (bidi_init_it): Don't initialize charpos and bytepos with invalid
841 values.
842 (bidi_level_of_next_char): Allow the sentinel "position" to pass
843 the test for valid cached positions. Fix the logic for looking up
844 the sentinel state in the cache. GCPRO the Lisp string we are
845 iterating.
846 (bidi_push_it, bidi_pop_it): New functions.
847 (bidi_initialize): Initialize the bidi cache start stack pointer.
848 (bidi_cache_ensure_space): New function, refactored from part of
849 bidi_cache_iterator_state. Don't assume the required size is just
850 one BIDI_CACHE_CHUNK away.
851 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
852 (bidi_count_bytes, bidi_char_at_pos): New functions.
853 (bidi_cache_search): Don't assume bidi_cache_last_idx is
854 always valid if bidi_cache_idx is valid.
855 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
856 is valid if it's going to be used.
857 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
858 (bidi_cache_fetch_state, bidi_cache_search)
859 (bidi_cache_find_level_change, bidi_cache_ensure_space)
860 (bidi_cache_iterator_state, bidi_cache_find)
861 (bidi_find_other_level_edge, bidi_cache_start_stack):
862 All variables related to cache indices are now EMACS_INT.
863
864 * dispextern.h (struct bidi_string_data): New structure.
865 (struct bidi_it): New member `string'. Make flag members be 1-bit
866 fields, and put them last in the struct.
867 (compute_display_string_pos, compute_display_string_end):
868 Update prototypes.
869 (bidi_push_it, bidi_pop_it): Add prototypes.
870 (struct iterator_stack_entry): New members bidi_p,
871 paragraph_embedding, and from_disp_prop_p.
872 (struct it): Member bidi_p is now a bit field 1 bit wide.
873 (bidi_shelve_cache, bidi_unshelve_cache):
874 Declare prototypes.
875
876 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
877 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
878 and vector-like objects.
879
880 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
881 cache around display iteration.
882
883 * window.c (Fwindow_end, window_scroll_pixel_based)
884 (displayed_window_lines, Frecenter): Save and restore the bidi
885 cache around display iteration.
886
887 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
888
889 * editfns.c (Fdelete_region): Clarify the use of the named
890 parameters (bug#6788).
891
892 2011-07-14 Martin Rudalics <rudalics@gmx.at>
893
894 * indent.c (Fvertical_motion): Set and restore w->pointm when
895 saving and restoring the window's buffer (Bug#9006).
896
897 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
898
899 * editfns.c (Fstring_to_char): Clarify just what is returned
900 (bug#6576). Text by Eli Zaretskii.
901
902 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
903
904 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
905
906 2011-07-13 Eli Zaretskii <eliz@gnu.org>
907
908 * buffer.c (mmap_find): Fix a typo.
909
910 2011-07-13 Johan Bockgård <bojohan@gnu.org>
911
912 Fix execution of x selection hooks.
913 * xselect.c (Qx_lost_selection_functions)
914 (Qx_sent_selection_functions): New vars.
915 (syms_of_xselect): DEFSYM them.
916 (x_handle_selection_request): Pass Qx_sent_selection_functions
917 rather than Vx_sent_selection_functions to Frun_hook_with_args.
918 (x_handle_selection_clear,x_clear_frame_selections):
919 Pass Qx_lost_selection_functions rather than
920 Vx_lost_selection_functions to Frun_hook_with_args.
921
922 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
923
924 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
925 The old code sometimes used this field without initializing it.
926
927 * alloc.c (gc_sweep): Don't read past end of array.
928 In theory, the old code could also have corrupted Emacs internals,
929 though it'd be very unlikely.
930
931 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
932
933 * character.c (Fcharacterp): Don't advertise optional ignored
934 argument. (Bug#4026)
935
936 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
937
938 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
939 key" (bug#4257).
940
941 * window.c (Fset_window_start): Doc fix (bug#4199).
942 (Fset_window_hscroll): Ditto.
943
944 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
945
946 Fix minor new problems caught by GCC 4.6.1.
947 * term.c (init_tty): Remove unused local.
948 * xsettings.c (store_monospaced_changed): Define this function only
949 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
950 not used otherwise.
951
952 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
953
954 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
955
956 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
957
958 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
959 are the mini-buffer and the echo area (bug#3320).
960
961 * term.c (init_tty): Remove support for supdup, c10 and perq
962 terminals, which are no longer supported (bug#1482).
963
964 2011-07-10 Johan Bockgård <bojohan@gnu.org>
965
966 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
967
968 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
969
970 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
971 for non-popups (Bug#3642).
972
973 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
974
975 * alloc.c (reset_malloc_hooks): Protoize.
976 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
977 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
978 * cm.c (losecursor): Likewise.
979 * data.c (fmod): Likewise.
980 * dispnew.c (swap_glyphs_in_rows): Likewise.
981 * emacs.c (memory_warning_signal): Likewise.
982 * floatfns.c (float_error): Likewise.
983 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
984 (otf_open, font_otf_capability, generate_otf_features)
985 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
986 Likewise.
987 * image.c (pbm_read_file): Likewise.
988 * indent.c (string_display_width): Likewise.
989 * intervals.c (check_for_interval, search_for_interval)
990 (inc_interval_count, count_intervals, root_interval)
991 (adjust_intervals_for_insertion, make_new_interval): Likewise.
992 * lread.c (defalias): Likewise.
993 * ralloc.c (r_alloc_check): Likewise.
994 * regex.c (set_image_of_range_1, set_image_of_range)
995 (regex_grow_registers): Likewise.
996 * sysdep.c (strerror): Likewise.
997 * termcap.c (valid_filename_p, tprint, main): Likewise.
998 * tparam.c (main): Likewise.
999 * unexhp9k800.c (run_time_remap, save_data_space)
1000 (update_file_ptrs, read_header, write_header, calculate_checksum)
1001 (copy_file, copy_rest, display_header): Likewise.
1002 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1003 Likewise.
1004 * xdisp.c (check_it): Likewise.
1005 * xfaces.c (register_color, unregister_color, unregister_colors):
1006 Likewise.
1007 * xfns.c (print_fontset_result): Likewise.
1008 * xrdb.c (member, fatal, main): Likewise.
1009
1010 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1011
1012 Fix minor problems found by static checking (Bug#9031).
1013 * chartab.c (char_table_set_range, map_sub_char_table):
1014 Remove unused locals.
1015 (uniprop_table): Now static.
1016 * composite.c (_work_char): Remove unused static var.
1017
1018 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1019
1020 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1021
1022 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1023
1024 * gtkutil.c (qttip_cb): Remove code without function.
1025
1026 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1027
1028 * w32.c (pthread_sigmask): New stub.
1029
1030 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 Use pthread_sigmask, not sigprocmask (Bug#9010).
1033 sigprocmask is portable only for single-threaded applications, and
1034 Emacs can be multi-threaded when it uses GTK.
1035 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1036 (LIBES): Use it.
1037 * callproc.c (Fcall_process):
1038 * process.c (create_process):
1039 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1040 Use pthread_sigmask, not sigprocmask.
1041
1042 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1043
1044 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1045 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1046 wrong (Bug#8591).
1047
1048 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1049
1050 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1051 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1052 (xg_hide_tooltip): Fix comment.
1053
1054 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1055 in registerServicesMenuSendTypes.
1056 (validRequestorForSendType): Don't check ns_return_types.
1057
1058 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1059 ns_return_type.
1060
1061 2011-07-08 Jason Rumney <jasonr@gnu.org>
1062
1063 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1064 frame struct members of non-existent frames (Bug#6284).
1065
1066 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1067
1068 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1069 variable firstTime not needed on OSX >= 10.6.
1070 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1071 >= 10.5. Use setKnobProportion, setDoubleValue.
1072
1073 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1074 (MAC_OS_X_VERSION_10_5): Define if not defined.
1075 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1076 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1077 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1078
1079 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1080 cString and lossyCString on OSX >= 10.4
1081
1082 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1083 sizeToFit on OSX >= 10.2.
1084
1085 * nsimage.m (allocInitFromFile): Don't use deprecated method
1086 bestRepresentationForDevice on OSX >= 10.6.
1087
1088 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1089 to avoid warning.
1090
1091 * emacs.c: Declare unexec_init_emacs_zone.
1092
1093 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1094
1095 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1096
1097 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1098 on svcsMenu (Bug#8842).
1099
1100 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1101 ns_return_types.
1102 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1103
1104 * nsterm.m (QUTF8_STRING): Declare.
1105 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1106 (validRequestorForSendType): Return type is (id).
1107 Change indexOfObjectIdenticalTo to indexOfObject.
1108 Check if we have local selection before returning self (Bug#8842).
1109 (writeSelectionToPasteboard): Put local selection into paste board
1110 if we have a local selection (Bug#8842).
1111 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1112
1113 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1114 (ns_get_local_selection): Declare.
1115
1116 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1117
1118 * keymap.c (describe_map_tree): Don't insert a double newline at
1119 the end of the buffer (bug#1169) and return whether we inserted
1120 something.
1121
1122 * callint.c (Fcall_interactively): Change "reading args" to
1123 "providing args" to try to clarify what it does (bug#1010).
1124
1125 2011-07-07 Kenichi Handa <handa@m17n.org>
1126
1127 * composite.c (composition_compute_stop_pos): Ignore a static
1128 composition starting before CHARPOS (Bug#8915).
1129
1130 * xdisp.c (handle_composition_prop): Likewise.
1131
1132 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1133
1134 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1135 (Bug#9015)
1136
1137 2011-07-07 Kenichi Handa <handa@m17n.org>
1138
1139 * character.h (unicode_category_t): New enum type.
1140
1141 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1142 (Qchar_code_property_table): New variable.
1143 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1144 (UNIPROP_COMPRESSED_FORM_P): New macros.
1145 (char_table_ascii): Uncompress the compressed values.
1146 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1147 Uncompress the compressed values.
1148 (sub_char_table_ref_and_range): Likewise.
1149 (char_table_ref_and_range): Uncompress the compressed values.
1150 (sub_char_table_set): New arg is_uniprop. Callers changed.
1151 Uncompress the compressed values.
1152 (sub_char_table_set_range): Args changed. Callers changed.
1153 (char_table_set_range): Adjuted for the above change.
1154 (map_sub_char_table): Delete args default_val and parent. Add arg
1155 top. Give decoded values to a Lisp function.
1156 (map_char_table): Adjust for the above change. Give decoded
1157 values to a Lisp function. Gcpro more variables.
1158 (uniprop_table_uncompress)
1159 (uniprop_decode_value_run_length): New functions.
1160 (uniprop_decoder, uniprop_decoder_count): New variables.
1161 (uniprop_get_decoder, uniprop_encode_value_character)
1162 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1163 New functions.
1164 (uniprop_encoder, uniprop_encoder_count): New variables.
1165 (uniprop_get_encoder, uniprop_table)
1166 (Funicode_property_table_internal, Fget_unicode_property_internal)
1167 (Fput_unicode_property_internal): New functions.
1168 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1169 Sunicode_property_table_internal, Sget_unicode_property_internal,
1170 and Sput_unicode_property_internal. Defvar_lisp
1171 char-code-property-alist.
1172
1173 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1174 Vunicode_category_table.
1175
1176 * font.c (font_range): Adjust for the change of
1177 Vunicode_category_table.
1178
1179 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1180
1181 * m/iris4d.h: Remove file, move contents ...
1182 * s/irix6-5.h: ... here.
1183
1184 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1185
1186 Remove unportable assumption about struct layout (Bug#8884).
1187 * alloc.c (mark_buffer):
1188 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1189 (clone_per_buffer_values): Don't assume that
1190 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1191 This isn't true in general, and it's particularly not true
1192 if Emacs is configured with --with-wide-int.
1193 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1194 New macros, used in the buffer.c change.
1195
1196 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1197
1198 * xsettings.c: Use both GConf and GSettings if both are available.
1199 (store_config_changed_event): Add comment.
1200 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1201 (store_tool_bar_style_changed): New functions.
1202 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1203 (struct xsettings): Move font inside HAVE_XFT.
1204 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1205 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1206 Move inside HAVE_XFT.
1207 (something_changed_gsettingsCB): Rename from something_changedCB.
1208 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1209 also.
1210 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1211 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1212 (something_changed_gconfCB): Rename from something_changedCB.
1213 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1214 (parse_settings): Move check for font inside HAVE_XFT.
1215 (read_settings, apply_xft_settings): Add comment.
1216 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1217 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1218 call store_font_name_changed.
1219 (xft_settings_event): Add comment.
1220 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1221 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1222 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1223 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1224 (xsettings_initialize): Call init_gsettings last.
1225 (xsettings_get_system_font, xsettings_get_system_normal_font):
1226 Add comment.
1227
1228 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 Random fixes. E.g., (random) never returned negative values.
1231 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1232 subseconds part to the entropy, as that's a bit more random.
1233 Prefer signed to unsigned, since the signedness doesn't matter and
1234 in general we prefer signed. When given a limit, use a
1235 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1236 latter isn't right if USE_2_TAGS_FOR_INTS.
1237 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1238 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1239
1240 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1241
1242 * textprop.c (text_property_stickiness):
1243 Obey Vtext_property_default_nonsticky.
1244 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1245 * w32fns.c (syms_of_w32fns):
1246 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1247
1248 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1251 This is more efficient than Ffile_directory_p and avoids a minor race.
1252
1253 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1254
1255 * buffer.c (Foverlay_put): Say what the return value is
1256 (bug#7835).
1257
1258 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1259 is a directory before asking whether to use the file name
1260 (bug#7564).
1261 (barf_or_query_if_file_exists): Make the "File is a directory"
1262 error be more correct.
1263
1264 * fns.c (Frequire): Remove the mention of the .gz files, since
1265 that's installation-specific, but keep the mention of
1266 `get-load-suffixes'.
1267
1268 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1269
1270 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1271 Report string overflow if the output is too long.
1272
1273 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1274
1275 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1276 (syms_of_gnutls): Remove duplicate DEFSYM for
1277 Qgnutls_bootprop_verify_hostname_error, an error for
1278 Qgnutls_bootprop_verify_error (which is no longer used).
1279
1280 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1281 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1282 Also (re)move comments that are misplaced or no longer relevant.
1283
1284 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1285
1286 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1287
1288 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1289
1290 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1291 and background color parameters if they have been changed.
1292
1293 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1294
1295 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1296
1297 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1298
1299 * xsettings.c (SYSTEM_FONT): Define only when used.
1300 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1301
1302 * keymap.c (access_keymap_1): Now static.
1303
1304 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1305
1306 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1307 leave any prefix arg for the up event (Bug#1586).
1308
1309 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1310
1311 * lread.c (syms_of_lread): Mention single symbols defined by
1312 `defvar' or `defconst' (bug#7154).
1313
1314 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1315 (Frequire): Mention get-load-suffixes.
1316
1317 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1318
1319 * window.h (window): Remove clone_number slot.
1320 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1321 Remove.
1322 (make_parent_window, make_window, saved_window)
1323 (Fset_window_configuration, save_window_save): Don't deal with
1324 clone numbers.
1325 * buffer.c (Qclone_number): Remove declaration.
1326 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1327
1328 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1329
1330 Add multiple inheritance to keymaps.
1331 * keymap.c (Fmake_composed_keymap): New function.
1332 (Fset_keymap_parent): Simplify.
1333 (fix_submap_inheritance): Remove.
1334 (access_keymap_1): New function extracted from access_keymap to handle
1335 embedded parents and handle lists of maps.
1336 (access_keymap): Use it.
1337 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1338 (Fcopy_keymap): Handle embedded parents.
1339 (Fcommand_remapping, define_as_prefix): Simplify.
1340 (Fkey_binding): Simplify.
1341 (syms_of_keymap): Move minibuffer-local-completion-map,
1342 minibuffer-local-filename-completion-map,
1343 minibuffer-local-must-match-map, and
1344 minibuffer-local-filename-must-match-map to Elisp.
1345 (syms_of_keymap): Defsubr make-composed-keymap.
1346 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1347 (parse_menu_item): Trivial simplification.
1348
1349 2011-07-01 Glenn Morris <rgm@gnu.org>
1350
1351 * Makefile.in (SETTINGS_LIBS): Fix typo.
1352
1353 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1354
1355 * coding.c (Fencode_coding_string): Record the last coding system
1356 used, as the function doc string says (bug#8738).
1357
1358 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1359
1360 * xsettings.c (store_monospaced_changed): Take new font as arg and
1361 check for change against current_mono_font.
1362 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1363 (emacs_settings_constructor, emacs_settings_get_property)
1364 (emacs_settings_set_property, emacs_settings_class_init)
1365 (emacs_settings_init, gsettings_obj): Remove.
1366 (something_changedCB): New function for HAVE_GSETTINGS.
1367 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1368 with value as argument.
1369 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1370 g_settings_new (Bug#8967). Do not create gsettings_obj.
1371 Remove calls to g_settings_bind. Connect something_changedCB to
1372 "changed".
1373
1374 * xgselect.c: Add defined (HAVE_GSETTINGS).
1375 (xgselect_initialize): Ditto.
1376
1377 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1378 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1379 xg_select.
1380
1381 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 * eval.c (struct backtrace): Simplify and port the data structure.
1384 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1385 signed bit field, as this assumption is not portable and it makes
1386 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1387 "char debug_on_exit : 1" as this is not portable either; instead,
1388 use the portable "unsigned int debug_on_exit : 1". Remove unused
1389 member evalargs. Remove obsolete comments about cc bombing out.
1390
1391 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1392
1393 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1394 Let HAVE_GSETTINGS override HAVE_GCONF.
1395 (store_monospaced_changed): New function.
1396 (EMACS_SETTINGS): A new type derived from GObject to handle
1397 GSettings notifications.
1398 (emacs_settings_constructor, emacs_settings_get_property)
1399 (emacs_settings_set_property, emacs_settings_class_init):
1400 New functions.
1401 (gsettings_client, gsettings_obj): New variables.
1402 (GSETTINGS_SCHEMA): New define.
1403 (something_changedCB): Call store_monospaced_changed.
1404 (init_gsettings): New function.
1405 (xsettings_initialize): Call init_gsettings.
1406 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1407 to NULL.
1408
1409 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1410 GCONF_CFLAGS/LIBS.
1411
1412 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1413
1414 * window.c (resize_root_window, grow_mini_window)
1415 (shrink_mini_window): Rename Qresize_root_window to
1416 Qwindow_resize_root_window and Qresize_root_window_vertically to
1417 Qwindow_resize_root_window_vertically.
1418
1419 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1420
1421 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1422
1423 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1424
1425 * makefile.w32-in: Redesign dependencies so they reflect more
1426 clearly which files are directly included by each source file,
1427 and not through other includes.
1428
1429 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1430
1431 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1432 (sort_overlays, overlay_strings): When an overlay's clone number
1433 matches the window's clone number process the overlay even if
1434 the overlay's window property doesn't match the current window.
1435
1436 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1437 (Fwindow_hchild): Rename to Fwindow_left_child.
1438 (Fwindow_next): Rename to Fwindow_next_sibling.
1439 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1440 (resize_window_check): Rename to window_resize_check.
1441 (resize_window_apply): Rename to window_resize_apply.
1442 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1443 (Fdelete_other_windows_internal, resize_frame_windows)
1444 (Fsplit_window_internal, Fdelete_window_internal)
1445 (grow_mini_window, shrink_mini_window)
1446 (Fresize_mini_window_internal): Fix callers accordingly.
1447
1448 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1449
1450 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1451 (emacs_fixed_set_min_size): Remove.
1452 (emacs_fixed_new): Take frame as argument.
1453
1454 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1455 (_EmacsFixedPrivate): Remove minwidth/height.
1456 Add struct frame *f.
1457 (emacs_fixed_init): Initialize priv->f.
1458 (get_parent_class, emacs_fixed_set_min_size): Remove.
1459 (emacs_fixed_new): Set priv->f to argument.
1460 (emacs_fixed_get_preferred_width)
1461 (emacs_fixed_get_preferred_height): Use min_width/height from
1462 frames size_hint to set minimum and natural (Bug#8919).
1463 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1464 and use min_width/height from frames size_hint to set
1465 min_width/height (Bug#8919).
1466
1467 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1468 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1469 Fix indentation.
1470
1471 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1472
1473 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1474 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1475 called at ZV.
1476
1477 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1478
1479 * process.c (wait_reading_process_output): Bypass select if
1480 waiting for a cell while ignoring keyboard input, and input is
1481 pending. Suggested by Jan Djärv (Bug#8869).
1482
1483 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 Use gnulib's dup2 module instead of rolling our own.
1486 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1487
1488 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1489
1490 * dispnew.c (scrolling_window): Before scrolling, turn off a
1491 mouse-highlight in the window being scrolled.
1492
1493 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1494
1495 Move DEFSYM to lisp.h and use everywhere.
1496
1497 * character.h (DEFSYM): Move declaration...
1498 * lisp.h (DEFSYM): ...here.
1499
1500 * gnutls.c:
1501 * minibuf.c:
1502 * w32menu.c:
1503 * w32proc.c:
1504 * w32select.c: Don't include character.h.
1505
1506 * alloc.c (syms_of_alloc):
1507 * buffer.c (syms_of_buffer):
1508 * bytecode.c (syms_of_bytecode):
1509 * callint.c (syms_of_callint):
1510 * casefiddle.c (syms_of_casefiddle):
1511 * casetab.c (init_casetab_once):
1512 * category.c (init_category_once, syms_of_category):
1513 * ccl.c (syms_of_ccl):
1514 * cmds.c (syms_of_cmds):
1515 * composite.c (syms_of_composite):
1516 * dbusbind.c (syms_of_dbusbind):
1517 * dired.c (syms_of_dired):
1518 * dispnew.c (syms_of_display):
1519 * doc.c (syms_of_doc):
1520 * editfns.c (syms_of_editfns):
1521 * emacs.c (syms_of_emacs):
1522 * eval.c (syms_of_eval):
1523 * fileio.c (syms_of_fileio):
1524 * fns.c (syms_of_fns):
1525 * frame.c (syms_of_frame):
1526 * fringe.c (syms_of_fringe):
1527 * insdel.c (syms_of_insdel):
1528 * keymap.c (syms_of_keymap):
1529 * lread.c (init_obarray, syms_of_lread):
1530 * macros.c (syms_of_macros):
1531 * msdos.c (syms_of_msdos):
1532 * print.c (syms_of_print):
1533 * process.c (syms_of_process):
1534 * search.c (syms_of_search):
1535 * sound.c (syms_of_sound):
1536 * syntax.c (init_syntax_once, syms_of_syntax):
1537 * terminal.c (syms_of_terminal):
1538 * textprop.c (syms_of_textprop):
1539 * undo.c (syms_of_undo):
1540 * w32.c (globals_of_w32):
1541 * window.c (syms_of_window):
1542 * xdisp.c (syms_of_xdisp):
1543 * xfaces.c (syms_of_xfaces):
1544 * xfns.c (syms_of_xfns):
1545 * xmenu.c (syms_of_xmenu):
1546 * xsettings.c (syms_of_xsettings):
1547 * xterm.c (syms_of_xterm): Use DEFSYM.
1548
1549 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1550
1551 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1552
1553 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 Integer and buffer overflow fixes (Bug#8873).
1556
1557 * print.c (printchar, strout): Check for string overflow.
1558 (PRINTPREPARE, printchar, strout):
1559 Don't set size unless allocation succeeds.
1560
1561 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1562 for sizes. Check for string overflow more accurately.
1563 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1564
1565 * macros.c: Integer and buffer overflow fixes.
1566 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1567 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1568 Use ptrdiff_t, not int, for sizes.
1569 Don't increment bufsize until after realloc succeeds.
1570 Check for size-calculation overflow.
1571 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1572
1573 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1574
1575 * lread.c: Integer overflow fixes.
1576 (read_integer): Radix is now EMACS_INT, not int,
1577 to improve quality of diagnostics for out-of-range radices.
1578 Calculate buffer size correctly for out-of-range radices.
1579 (read1): Check for integer overflow in radices, and in
1580 read-circle numbers.
1581 (read_escape): Avoid int overflow.
1582 (Fload, openp, read_buffer_size, read1)
1583 (substitute_object_recurse, read_vector, read_list, map_obarray):
1584 Use ptrdiff_t, not int, for sizes.
1585 (read1): Use EMACS_INT, not int, for sizes.
1586 Check for size overflow.
1587
1588 * image.c (cache_image): Check for size arithmetic overflow.
1589
1590 * lread.c: Integer overflow issues.
1591 (saved_doc_string_size, saved_doc_string_length)
1592 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1593 Now ptrdiff_t, not int.
1594 (read1): Don't assume doc string length fits in int. Check for
1595 out-of-range doc string lengths.
1596 (read_list): Don't assume file position fits in int.
1597 (read_escape): Check for hex character overflow.
1598
1599 2011-06-22 Leo Liu <sdl.web@gmail.com>
1600
1601 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1602 Move to minibuffer.el.
1603
1604 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1607 The following patches are for when GLYPH_DEBUG && !XASSERT.
1608 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1609 * dispnew.c (flush_stdout):
1610 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1611 Mark as externally visible.
1612 * dispnew.c (check_window_matrix_pointers): Now static.
1613 * dispnew.c (window_to_frame_vpos):
1614 * xfns.c (unwind_create_frame):
1615 * xterm.c (x_check_font): Remove unused local.
1616 * scroll.c (CHECK_BOUNDS):
1617 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1618 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1619 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1620 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1621 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1622 Now static.
1623 (debug_method_add): Use va_list and vsprintf rather than relying
1624 on undefined behavior with wrong number of arguments.
1625 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1626 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1627 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1628 since we're not interested in debugging glyphs with old libraries.
1629 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1630 GCC 4.6.0's static checking.
1631
1632 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 Integer overflow and signedness fixes (Bug#8873).
1635 A few related buffer overrun fixes, too.
1636
1637 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1638
1639 * dispextern.h (struct face.stipple):
1640 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1641 (x_bitmap_mask, x_allocate_bitmap_record)
1642 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1643 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1644 (x_create_bitmap_from_xpm_data):
1645 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1646 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1647 (.bitmaps_last):
1648 * xfaces.c (load_pixmap):
1649 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1650 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1651 (.bitmaps_last, struct x_output.icon_bitmap):
1652 Use ptrdiff_t, not int, for bitmap indexes.
1653 (x_allocate_bitmap_record): Check for size overflow.
1654 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1655
1656 Use ptrdiff_t, not int, for overlay counts.
1657 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1658 * editfns.c (overlays_around, get_pos_property):
1659 * textprop.c (get_char_property_and_overlay):
1660 * xdisp.c (next_overlay_change, note_mouse_highlight):
1661 * xfaces.c (face_at_buffer_position):
1662 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1663 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1664 (Fnext_overlay_change, Fprevious_overlay_change)
1665 (mouse_face_overlay_overlaps, Foverlays_in):
1666 Use ptrdiff_t, not int, for sizes.
1667 (overlays_at, overlays_in): Check for size-calculation overflow.
1668
1669 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1670
1671 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1672 (x_session_initialize): Do not assume string length fits in int.
1673
1674 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1675 This is unlikely, but can occur if DPI is outlandish.
1676
1677 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1678 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1679
1680 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1681 * xrdb.c (magic_file_p, search_magic_path):
1682 Omit last arg SUFFIX; it was always 0. All callers changed.
1683 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1684
1685 * xfont.c (xfont_match): Avoid need for strlen.
1686
1687 * xfns.c: Don't assume strlen fits in int.
1688 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1689
1690 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1691 not unsigned long, as we prefer signed integers. All callers changed.
1692 Detect integer overflow in repeat count.
1693 (message_dolog): Don't assume print length fits in 39 bytes.
1694 (display_mode_element): Don't assume strlen fits in int.
1695
1696 * termcap.c: Don't assume sizes fit in int and never overflow.
1697 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1698 (gobble_line): Check for size-calculation overflow.
1699
1700 * minibuf.c (Fread_buffer):
1701 * lread.c (intern, intern_c_string):
1702 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1703 Don't assume string length fits in int.
1704
1705 * keyboard.c (parse_tool_bar_item):
1706 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1707
1708 * font.c: Don't assume string length fits in int.
1709 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1710 Use ptrdiff_t, not int.
1711 (font_intern_prop): Don't assume string length fits in int.
1712 Don't assume integer property fits in fixnum.
1713 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1714
1715 * filelock.c: Fix some buffer overrun and integer overflow issues.
1716 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1717 Reformulate so as not to need the command string.
1718 Invoke gzip -cd rather than gunzip, as it's more portable.
1719 (lock_info_type, lock_file_1, lock_file):
1720 Don't assume pid_t and time_t fit in unsigned long.
1721 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1722 (current_lock_owner): Prefer signed type for sizes.
1723 Use memcpy, not strncpy, where memcpy is what is really wanted.
1724 Don't assume (via atoi) that time_t and pid_t fit in int.
1725 Check for time_t and/or pid_t out of range, e.g., via a network share.
1726 Don't alloca where an auto var works fine.
1727
1728 * fileio.c: Fix some integer overflow issues.
1729 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1730 Don't assume string length fits in int.
1731 (directory_file_name): Don't assume string length fits in long.
1732 (make_temp_name): Don't assume pid fits in int, or that its print
1733 length is less than 20.
1734
1735 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1736
1737 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1738
1739 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1740
1741 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1742 We prefer signed integers, even for size calculations.
1743
1744 * emacs.c: Don't assume string length fits in 'int'.
1745 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1746 (main): Don't invoke strlen when not needed.
1747
1748 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1749 (XD_DEBUG_MESSAGE): Don't waste a byte.
1750
1751 * callproc.c (getenv_internal_1, getenv_internal)
1752 (Fgetenv_internal):
1753 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1754
1755 * lread.c (invalid_syntax): Omit length argument.
1756 All uses changed. This doesn't fix a bug, but it simplifies the
1757 code away from its former Hollerith-constant appearance, and it's
1758 one less 'int' to worry about when looking at integer-overflow issues.
1759 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1760
1761 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1762 This didn't break anything, but it didn't help either.
1763 It's confusing to put a bogus integer in a place where the actual
1764 value does not matter.
1765 (LIST_END_P): Remove unused macro and its bogus comment.
1766 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1767
1768 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1769 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1770 implementation.
1771 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1772 We prefer signed types, and the value cannot exceed the EMACS_INT
1773 range anyway (because otherwise the length would not be representable).
1774 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1775 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1776 This avoids a GCC warning when WIDE_EMACS_INT.
1777
1778 * indent.c (sane_tab_width): New function.
1779 (current_column, scan_for_column, Findent_to, position_indentation)
1780 (compute_motion): Use it. This is just for clarity.
1781 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1782
1783 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1784
1785 * lisp.h (lint_assume): New macro.
1786 * composite.c (composition_gstring_put_cache):
1787 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1788
1789 * editfns.c, insdel.c:
1790 Omit unnecessary forward decls, to simplify future changes.
1791
1792 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1793
1794 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1795
1796 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1797 Use much-faster test for byte-length change.
1798 Don't assume string byte-length fits in 'int'.
1799 Check that character arg fits in 'int'.
1800 (mapcar1): Declare byte as byte, for clarity.
1801
1802 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1803
1804 * fns.c (concat): Catch string overflow earlier.
1805 Do not rely on integer wraparound.
1806
1807 * dispextern.h (struct it.overlay_strings_charpos)
1808 (struct it.selective): Now EMACS_INT, not int.
1809 * xdisp.c (forward_to_next_line_start)
1810 (back_to_previous_visible_line_start)
1811 (reseat_at_next_visible_line_start, next_element_from_buffer):
1812 Don't arbitrarily truncate the value of 'selective' to int.
1813
1814 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1815
1816 * composite.c: Don't truncate sizes to 'int'.
1817 (composition_gstring_p, composition_reseat_it)
1818 (composition_adjust_point): Use EMACS_INT, not int.
1819 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1820 not EMACS_UINT, for indexes.
1821
1822 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1823
1824 * buffer.c: Include <verify.h>.
1825 (struct sortvec.priority, struct sortstr.priority):
1826 Now EMACS_INT, not int.
1827 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1828 (struct sortstr.size, record_overlay_string)
1829 (struct sortstrlist.size, struct sortlist.used):
1830 Don't truncate size to int.
1831 (record_overlay_string): Check for size-calculation overflow.
1832 (init_buffer_once): Check at compile-time, not run-time.
1833
1834 2011-06-22 Jim Meyering <meyering@redhat.com>
1835
1836 Don't leak an XBM-image-sized buffer
1837 * image.c (xbm_load): Free the image buffer after using it.
1838
1839 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 Port to Sun C.
1842 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1843 that Sun C diagnosed.
1844 * fns.c (secure_hash): Fix pointer signedness issue.
1845 * intervals.c (static_offset_intervals): New function.
1846 (offset_intervals): Use it.
1847
1848 2011-06-21 Leo Liu <sdl.web@gmail.com>
1849
1850 * deps.mk (fns.o):
1851 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1852 sha512.h.
1853
1854 * fns.c (secure_hash): Rename from crypto_hash_function and change
1855 the first arg to accept symbols.
1856 (Fsecure_hash): New primitive.
1857 (syms_of_fns): New symbols.
1858
1859 2011-06-20 Deniz Dogan <deniz@dogan.se>
1860
1861 * process.c (Fset_process_buffer): Clarify return value in
1862 docstring.
1863
1864 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1865
1866 * dispnew.c (add_window_display_history): Use BVAR.
1867
1868 * xdisp.c (debug_method_add): Use BVAR.
1869 (check_window_end, dump_glyph_matrix, dump_glyph)
1870 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1871
1872 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1873 Likewise.
1874
1875 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1876 check till after the cache is created in init_frame_faces.
1877
1878 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1879
1880 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1881
1882 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1883
1884 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1885 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1886 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1887
1888 Improve buffer-overflow checking (Bug#8873).
1889 * fileio.c (Finsert_file_contents):
1890 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1891 Remove the old (too-loose) buffer overflow checks.
1892 They weren't needed, since make_gap checks for buffer overflow.
1893 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1894 The old code merely checked for Emacs fixnum overflow, and relied
1895 on undefined (wraparound) behavior. The new code avoids undefined
1896 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1897
1898 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1899 Tune. Don't use wider integers than needed. Don't use alloca.
1900 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1901
1902 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1903
1904 * insdel.c, lisp.h (buffer_overflow): New function.
1905 (insert_from_buffer_1, replace_range, replace_range_2):
1906 * insdel.c (make_gap_larger):
1907 * editfns.c (Finsert_char):
1908 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1909
1910 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1911
1912 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 Integer overflow and signedness fixes (Bug#8873).
1915
1916 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1917 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1918
1919 * fileio.c: Don't assume EMACS_INT fits in off_t.
1920 (emacs_lseek): New static function.
1921 (Finsert_file_contents, Fwrite_region): Use it.
1922 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1923
1924 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1925
1926 * fns.c: Don't overflow int when computing a list length.
1927 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1928 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1929 truncation on 64-bit hosts. Check for QUIT every
1930 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1931 faster and is responsive enough.
1932 (Flength): Report an error instead of overflowing an integer.
1933 (Fsafe_length): Return a float if the value is not representable
1934 as a fixnum. This shouldn't happen except in contrived situations.
1935 (Fnthcdr, Fsort): Don't assume list length fits in int.
1936 (Fcopy_sequence): Don't assume vector length fits in int.
1937
1938 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1939 (header_size, word_size): New constants.
1940 (allocate_vectorlike): Don't check size overflow here.
1941 (allocate_vector): Check it here instead, since this is the only
1942 caller of allocate_vectorlike that could cause overflow.
1943 Check that the new vector's length is representable as a fixnum.
1944
1945 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1946 The previous code was bogus. For example, next_almost_prime (32)
1947 returned 39, which is undesirable as it is a multiple of 3; and
1948 next_almost_prime (24) returned 25, which is a multiple of 5 so
1949 why was the code bothering to check for multiples of 7?
1950
1951 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1952
1953 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1954
1955 Variadic C functions now count arguments with ptrdiff_t.
1956 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1957 Back then I didn't know that the Emacs coding style prefers signed int.
1958 Also, in the meantime I found a few more instances where arguments
1959 were being counted with int, which may truncate counts on 64-bit
1960 machines, or EMACS_INT, which may be unnecessarily wide.
1961 * lisp.h (struct Lisp_Subr.function.aMANY)
1962 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1963 Arg counts are now ptrdiff_t, not size_t.
1964 All variadic functions and their callers changed accordingly.
1965 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1966 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1967 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1968 * callint.c (Fcall_interactively): Check arg count for overflow,
1969 to avoid potential buffer overrun. Use signed char, not 'int',
1970 for 'varies' array, so that we needn't bother to check its size
1971 calculation for overflow.
1972 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1973 * eval.c (apply_lambda):
1974 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1975 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1976 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1977
1978 * callint.c (Fcall_interactively): Don't use index var as event count.
1979
1980 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1981 * mem-limits.h (SIZE): Remove; no longer used.
1982
1983 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1984
1985 Remove unnecessary casts.
1986 * xterm.c (x_term_init):
1987 * xfns.c (x_set_border_pixel):
1988 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1989 These aren't needed now that we assume ANSI C.
1990
1991 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1992 It's more likely to cause problems (due to unsigned overflow)
1993 than to cure them.
1994
1995 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1996
1997 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1998
1999 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2000
2001 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2002
2003 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2004
2005 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2006
2007 GLYPH_CODE_FACE returns EMACS_INT, not int.
2008 * dispextern.h (merge_faces):
2009 * xfaces.c (merge_faces):
2010 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2011 Don't assume EMACS_INT fits in int.
2012
2013 * character.h (CHAR_VALID_P): Remove unused parameter.
2014 * fontset.c, lisp.h, xdisp.c: All uses changed.
2015
2016 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2017
2018 * fns.c (concat): Minor tuning based on overflow analysis.
2019 This doesn't fix any bugs. Use int to hold character, instead
2020 of constantly refetching from Emacs object. Use XFASTINT, not
2021 XINT, for value known to be a character. Don't bother comparing
2022 a single byte to 0400, as it's always less.
2023
2024 * floatfns.c (Fexpt):
2025 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2026
2027 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2028 for characters.
2029
2030 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2031
2032 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2033 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2034 incorrectly succeed when S was a string, because 4294967386 was
2035 truncated before it was used.
2036
2037 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2038 Otherwise, an out-of-range integer could cause undefined behavior
2039 on a 64-bit host.
2040
2041 * composite.c: Use int, not EMACS_INT, for characters.
2042 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2043 EMACS_INT, for values that are known to be in character range.
2044 This doesn't fix any bugs but is the usual style inside Emacs and
2045 may generate better code on 32-bit machines.
2046
2047 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2048 This is for reasons similar to the recent CHAR_STRING fix.
2049 * charset.c (Fencode_char): Check that character arg is actually
2050 a character. Pass an int to ENCODE_CHAR.
2051 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2052 wider than 'int', as a compile-time check to prevent future regressions
2053 in this area.
2054
2055 * character.c (char_string): Remove unnecessary casts.
2056
2057 Make sure a 64-bit char is never passed to CHAR_STRING.
2058 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2059 by silently ignoring the top 32 bits, allowing some values
2060 that were far too large to be valid characters.
2061 * character.h: Include <verify.h>.
2062 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2063 arguments are no wider than unsigned, as a compile-time check
2064 to prevent future regressions in this area.
2065 * data.c (Faset):
2066 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2067 (Fsubst_char_in_region):
2068 * fns.c (concat):
2069 * xdisp.c (decode_mode_spec_coding):
2070 Adjust to CHAR_STRING's new requirement.
2071 * editfns.c (Finsert_char, Fsubst_char_in_region):
2072 * fns.c (concat): Check that character args are actually
2073 characters. Without this test, these functions did the wrong
2074 thing with wildly out-of-range values on 64-bit hosts.
2075
2076 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2077 These casts should not be needed on 32-bit hosts, either.
2078 * keyboard.c (read_char):
2079 * lread.c (Fload): Remove casts to unsigned.
2080
2081 * lisp.h (UNSIGNED_CMP): New macro.
2082 This fixes comparison bugs on 64-bit hosts.
2083 (ASCII_CHAR_P): Use it.
2084 * casefiddle.c (casify_object):
2085 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2086 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2087 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2088 * dispextern.h (FACE_FROM_ID):
2089 * keyboard.c (read_char): Use UNSIGNED_CMP.
2090
2091 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2092 not to EMACS_INT, to avoid GCC warning.
2093
2094 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2095
2096 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2097 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2098 isn't needed on 32-bit machines.
2099
2100 * buffer.c (Fgenerate_new_buffer_name):
2101 Use EMACS_INT for count, not int.
2102 (advance_to_char_boundary): Return EMACS_INT, not int.
2103
2104 * data.c (Qcompiled_function): Now static.
2105
2106 * window.c (window_body_lines): Now static.
2107
2108 * image.c (gif_load): Rename local to avoid shadowing.
2109
2110 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2111 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2112 * alloc.c (make_save_value): Integer argument is now of type
2113 ptrdiff_t, not int.
2114 (mark_object): Use ptrdiff_t, not int.
2115 * lisp.h (pD): New macro.
2116 * print.c (print_object): Use it.
2117
2118 * alloc.c: Use EMACS_INT, not int, to count objects.
2119 (total_conses, total_markers, total_symbols, total_vector_size)
2120 (total_free_conses, total_free_markers, total_free_symbols)
2121 (total_free_floats, total_floats, total_free_intervals)
2122 (total_intervals, total_strings, total_free_strings):
2123 Now EMACS_INT, not int. All uses changed.
2124 (Fgarbage_collect): Compute overall total using a double, so that
2125 integer overflow is less likely to be a problem. Check for overflow
2126 when converting back to an integer.
2127 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2128 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2129 These were 'int' variables that could overflow on 64-bit hosts;
2130 they were never used, so remove them instead of repairing them.
2131 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2132 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2133 Previously, this ceilinged at INT_MAX, but that doesn't work on
2134 64-bit machines.
2135 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2136
2137 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2138 (allocate_vectorlike): Check for ptrdiff_t overflow.
2139 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2140 when a (possibly-narrower) signed value would do just as well.
2141 We prefer using signed arithmetic, to avoid comparison confusion.
2142
2143 * alloc.c: Catch some string size overflows that we were missing.
2144 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2145 for convenience in STRING_BYTES_MAX.
2146 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2147 The definition here is exact; the one in lisp.h was approximate.
2148 (allocate_string_data): Check for string overflow. This catches
2149 some instances we weren't catching before. Also, it catches
2150 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2151 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2152 and ptrdiff_t and EMACS_INT are both 64 bits.
2153
2154 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2155 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2156 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2157
2158 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2159
2160 * alloc.c (Fmake_string): Check for out-of-range init.
2161
2162 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2163
2164 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2165
2166 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2167
2168 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2169 xg_get_default_scrollbar_width.
2170
2171 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2172 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2173 (style_changed_cb): Call update_theme_scrollbar_width and call
2174 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2175 all frames (Bug#8505).
2176 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2177 Call gtk_window_set_resizable if HAVE_GTK3.
2178 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2179 and height if HAVE_GTK3 (Bug#8505).
2180 (scroll_bar_width_for_theme): New variable.
2181 (update_theme_scrollbar_width): New function.
2182 (xg_get_default_scrollbar_width): Move code to
2183 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2184 (xg_initialize): Call update_theme_scrollbar_width.
2185
2186 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2187
2188 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2189
2190 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2191
2192 * frame.c (make_frame): Call other_buffer_safely instead of
2193 other_buffer.
2194
2195 * window.c (temp_output_buffer_show): Call display_buffer with
2196 second argument Vtemp_buffer_show_specifiers and reset latter
2197 immediately after the call.
2198 (Vtemp_buffer_show_specifiers): New variable.
2199 (auto_window_vscroll_p, next_screen_context_lines)
2200 (Vscroll_preserve_screen_position): Remove leading asterisks from
2201 doc-strings.
2202
2203 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2204
2205 Fix minor problems found by GCC 4.6.0 static checking.
2206 * buffer.c (Qclone_number): Remove for now, as it's unused.
2207 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2208 (record_buffer): Remove unused local.
2209 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2210 (set_frame_buffer_list): Remove; unused.
2211 * frame.h (other_visible_frames): Remove decl.
2212 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2213 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2214 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2215 if HAVE_GPM.
2216 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2217 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2218 Define only if HAVE_GPM.
2219 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2220 (update_hints_inhibit): Remove; never set. All uses removed.
2221 * widgetprv.h (emacsFrameClassRec): Remove decl.
2222 * window.c (delete_deletable_window): Now returns void, since it
2223 wasn't returning anything.
2224 (compare_window_configurations): Remove unused locals.
2225 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2226 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2227 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2228 the same widths as pointers. This follows up on the 2011-05-06 patch.
2229 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2230 * xterm.h: Likewise.
2231 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2232
2233 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2234
2235 * makefile.w32-in: Update dependencies.
2236 (LISP_H): Add lib/intprops.h.
2237
2238 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2239
2240 * image.c (gif_load): Add animation frame delay to the metadata.
2241 (syms_of_image): Use DEFSYM. New symbol `delay'.
2242
2243 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2244
2245 * window.c (delete_deletable_window): Re-add.
2246 (Fset_window_configuration): Rewrite to handle dead buffers and
2247 consequently deletable windows.
2248 (window_tree, Fwindow_tree): Remove. Supply functionality in
2249 window.el.
2250 (compare_window_configurations): Simplify code.
2251
2252 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2253
2254 * image.c (imagemagick_load_image): Fix type mismatch.
2255 (Fimagemagick_types): Likewise.
2256
2257 * window.h (replace_buffer_in_windows): Declare.
2258
2259 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2260
2261 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2262 Qclone_number. Remove external declaration of Qdelete_window.
2263 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2264 code.
2265 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2266 Run Qbuffer_list_update_hook if allowed.
2267 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2268 buffer list implementation.
2269 (other_buffer_safely): New function.
2270 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2271 calls to replace_buffer_in_windows and
2272 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2273 if allowed.
2274 (record_buffer): Inhibit quitting and rewrite using quittable
2275 functions. Run Qbuffer_list_update_hook if allowed.
2276 (Frecord_buffer, Funrecord_buffer): New functions.
2277 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2278 Move switch-to-buffer to window.el.
2279 (bury-buffer): Move to window.el.
2280 (Vbuffer_list_update_hook): New variable.
2281
2282 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2283 section.
2284
2285 * window.h (resize_frame_windows): Move up in code.
2286 (Fwindow_frame): Remove EXFUN.
2287 (replace_buffer_in_all_windows): Remove prototype.
2288 (replace_buffer_in_windows_safely): Add prototype.
2289
2290 * window.c: Declare Qdelete_window static again. Move down
2291 declaration of select_count.
2292 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2293 (Fother_window): Move to window.el.
2294 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2295 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2296 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2297 window.el.
2298 (replace_buffer_in_windows): Implement by calling
2299 Qreplace_buffer_in_windows.
2300 (replace_buffer_in_all_windows): Remove with some functionality
2301 moved into replace_buffer_in_windows_safely.
2302 (replace_buffer_in_windows_safely): New function.
2303 (select_window_norecord, select_frame_norecord): Move in front
2304 of run_window_configuration_change_hook. Remove now obsolete
2305 declarations.
2306 (Fset_window_buffer): Rewrite doc-string.
2307 Call Qrecord_window_buffer.
2308 (keys_of_window): Move binding for other-window to window.el.
2309
2310 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2311
2312 * dispextern.h (struct image): Replace data member, whose int_val
2313 and ptr_val fields were not used by anything, with a single
2314 lisp_val object.
2315
2316 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2317 (gif_clear_image, gif_load, imagemagick_load_image)
2318 (gs_clear_image, gs_load): Callers changed.
2319
2320 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2321
2322 * buffer.h: Include <time.h>, for time_t.
2323 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2324
2325 Fix minor problems found by static checking.
2326
2327 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2328
2329 Make identifiers static if they are not used in other modules.
2330 * data.c (Qcompiled_function, Qframe, Qvector):
2331 * image.c (QimageMagick, Qsvg):
2332 * minibuf.c (Qmetadata):
2333 * window.c (resize_window_check, resize_root_window): Now static.
2334 * window.h (resize_window_check, resize_root_window): Remove decls.
2335
2336 * window.c (window_deletion_count, delete_deletable_window):
2337 Remove; unused.
2338 (window_body_lines): Now static.
2339 (Fdelete_other_windows_internal): Mark vars as initialized.
2340 Make sure 'resize_failed' is initialized.
2341 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2342 (resize_window_apply): Remove unused local.
2343 * window.h (delete_deletable_window): Remove decl.
2344
2345 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2346 (imagemagick_load_image): Fix pointer signedness problem by changing
2347 last arg from unsigned char * to char *. All uses changed.
2348 Also, fix a local for similar reasons.
2349 Remove unused locals. Remove locals to avoid shadowing.
2350 (fn_rsvg_handle_free): Remove; unused.
2351 (svg_load, svg_load_image): Fix pointer signedness problem.
2352 (imagemagick_load_image): Don't use garbage pointer image_wand.
2353
2354 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2355
2356 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2357
2358 * image.c (gif_load): Fix omitted cast error introduced by
2359 2011-06-06 change.
2360
2361 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2362
2363 * window.h (resize_proportionally, orig_total_lines)
2364 (orig_top_line): Remove from window structure.
2365 (set_window_height, set_window_width, change_window_heights)
2366 (Fdelete_window): Remove prototypes.
2367 (resize_frame_windows): Remove duplicate declaration.
2368
2369 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2370
2371 * window.h (resize_frame_windows, resize_window_check)
2372 (delete_deletable_window, resize_root_window)
2373 (resize_frame_windows): Declare prototypes.
2374
2375 * window.c (resize_window_apply): Make definition be "static" to
2376 match the prototype.
2377
2378 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2379
2380 * window.c: Remove declarations of Qwindow_size_fixed,
2381 window_min_size_1, window_min_size_2, window_min_size,
2382 size_window, window_fixed_size_p, enlarge_window, delete_window.
2383 Remove static from declaration of Qdelete_window, it's
2384 temporarily needed by Fbury_buffer.
2385 (replace_window): Don't assign orig_top_line and
2386 orig_total_lines.
2387 (Fdelete_window, delete_window): Remove. Window deletion is
2388 handled by window.el.
2389 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2390 Replace Fdelete_window calls with calls to Qdelete_window.
2391 (Fdelete_other_windows): Remove. Deleting other windows is
2392 handled by window.el.
2393 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2394 handled in window.el.
2395 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2396 Window minimum sizes are handled in window.el.
2397 (shrink_windows, size_window, set_window_height)
2398 (set_window_width, change_window_heights, window_height)
2399 (window_width, CURBEG, CURSIZE, enlarge_window)
2400 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2401 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2402 handled in window.el.
2403 (make_dummy_parent): Rename to make_parent_window and give it a
2404 second argument horflag.
2405 (make_window): Don't set resize_proportionally any more.
2406 (Fsplit_window): Remove. Windows are split in window.el.
2407 (save_restore_action, save_restore_orig_size)
2408 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2409 Resize mini windows in window.el.
2410 (grow_mini_window, shrink_mini_window): Implement by calling
2411 Qresize_root_window_vertically, resize_window_check and
2412 resize_window_apply.
2413 (saved_window, Fset_window_configuration, save_window_save):
2414 Do not handle orig_top_line, orig_total_lines, and
2415 resize_proportionally.
2416 (window_min_height, window_min_width): Move to window.el.
2417 (keys_of_window): Move bindings for delete-other-windows,
2418 split-window, delete-window and enlarge-window to window.el.
2419
2420 * buffer.c: Temporarily extern Qdelete_window.
2421 (Fbury_buffer): Temporarily call Qdelete_window instead of
2422 Fdelete_window (Fbury_buffer will move to window.el soon).
2423
2424 * frame.c (set_menu_bar_lines_1): Remove code handling
2425 orig_top_line and orig_total_lines.
2426
2427 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2428 set_window_height but set heights directly.
2429 (change_frame_size_1): Use resize_frame_windows.
2430
2431 * xdisp.c (init_xdisp): Don't use set_window_height but set
2432 heights directly.
2433
2434 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2435 Use resize_frame_windows instead of change_window_heights and run
2436 run_window_configuration_change_hook.
2437
2438 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2439 instead of change_window_heights and run
2440 run_window_configuration_change_hook.
2441
2442 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2443
2444 * window.c (replace_window): Rename second argument REPLACEMENT to
2445 NEW. New third argument SETFLAG. Rewrite.
2446 (delete_window, make_dummy_parent): Call replace_window with
2447 third argument 1.
2448 (window_list_1): Move down in code.
2449 (run_window_configuration_change_hook): Move set_buffer part
2450 before select_frame_norecord part in order to unwind correctly.
2451 Rename count1 to count.
2452 (recombine_windows, delete_deletable_window, resize_root_window)
2453 (Fdelete_other_windows_internal)
2454 (Frun_window_configuration_change_hook, make_parent_window)
2455 (resize_window_check, resize_window_apply, Fresize_window_apply)
2456 (resize_frame_windows, Fsplit_window_internal)
2457 (Fdelete_window_internal, Fresize_mini_window_internal):
2458 New functions.
2459 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2460
2461 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2462
2463 * window.h (window): Add some new members to window structure -
2464 normal_lines, normal_cols, new_total, new_normal, clone_number,
2465 splits, nest, prev_buffers, next_buffers.
2466 (WINDOW_TOTAL_SIZE): Move here from window.c.
2467 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2468
2469 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2470 Remove.
2471 (make_dummy_parent): Set new members of windows structure.
2472 (make_window): Move down in code. Handle new members of window
2473 structure.
2474 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2475 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2476 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2477 (Fset_window_prev_buffers, Fwindow_next_buffers)
2478 (Fset_window_next_buffers, Fset_window_clone_number):
2479 New functions.
2480 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2481 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2482 Doc-string fixes.
2483 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2484 Argument WINDOW can be now internal window too.
2485 (Fwindow_use_time): Move up in code.
2486 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2487 Rewrite doc-string.
2488 (Fset_window_configuration, saved_window)
2489 (Fcurrent_window_configuration, save_window_save): Handle new
2490 members of window structure.
2491 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2492 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2493 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2494 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2495 Qget_mru_window, Qresize_root_window,
2496 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2497 Qauto_buffer_name; staticpro them.
2498
2499 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2500
2501 * window.c (Fwindow_total_size, Fwindow_left_column)
2502 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2503 (Fwindow_list_1): New functions.
2504 (window_box_text_cols): Replace with window_body_cols.
2505 (Fwindow_width, Fscroll_left, Fscroll_right):
2506 Use window_body_cols instead of window_box_text_cols.
2507 (delete_window, Fset_window_configuration):
2508 Call delete_all_subwindows with window as argument.
2509 (delete_all_subwindows): Take a window as argument and not a
2510 structure. Rewrite.
2511 (window_loop): Remove handling of GET_LRU_WINDOW and
2512 GET_LARGEST_WINDOW.
2513 (Fget_lru_window, Fget_largest_window): Move to window.el.
2514
2515 * window.h: Extern window_body_cols instead of
2516 window_box_text_cols. delete_all_subwindows now takes a
2517 Lisp_Object as argument.
2518
2519 * indent.c (compute_motion, Fcompute_motion):
2520 Use window_body_cols instead of window_box_text_cols.
2521
2522 * frame.c (delete_frame): Call delete_all_subwindows with root
2523 window as argument.
2524
2525 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2526
2527 * fns.c (Fputhash): Document return value.
2528
2529 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2530
2531 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2532
2533 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2534
2535 Cons<->int and similar integer overflow fixes (Bug#8794).
2536
2537 Check for overflow when converting integer to cons and back.
2538 * charset.c (Fdefine_charset_internal, Fdecode_char):
2539 Use cons_to_unsigned to catch overflow.
2540 (Fencode_char): Use INTEGER_TO_CONS.
2541 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2542 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2543 * data.c (long_to_cons, cons_to_long): Remove.
2544 (cons_to_unsigned, cons_to_signed): New functions.
2545 These signal an error for invalid or out-of-range values.
2546 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2547 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2548 * font.c (Ffont_variation_glyphs):
2549 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2550 * lisp.h: Include <intprops.h>.
2551 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2552 (cons_to_signed, cons_to_unsigned): New decls.
2553 (long_to_cons, cons_to_long): Remove decls.
2554 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2555 (Fprimitive_undo): Use CONS_TO_INTEGER.
2556 * xfns.c (Fx_window_property): Likewise.
2557 * xselect.c: Include <limits.h>.
2558 (x_own_selection, selection_data_to_lisp_data):
2559 Use INTEGER_TO_CONS.
2560 (x_handle_selection_request, x_handle_selection_clear)
2561 (x_get_foreign_selection, Fx_disown_selection_internal)
2562 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2563 (lisp_data_to_selection_data): Use cons_to_unsigned.
2564 (x_fill_property_data): Use cons_to_signed.
2565 Report values out of range.
2566
2567 Check for buffer and string overflow more precisely.
2568 * buffer.h (BUF_BYTES_MAX): New macro.
2569 * lisp.h (STRING_BYTES_MAX): New macro.
2570 * alloc.c (Fmake_string):
2571 * character.c (string_escape_byte8):
2572 * coding.c (coding_alloc_by_realloc):
2573 * doprnt.c (doprnt):
2574 * editfns.c (Fformat):
2575 * eval.c (verror):
2576 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2577 since they may not be the same number.
2578 * editfns.c (Finsert_char):
2579 * fileio.c (Finsert_file_contents):
2580 Likewise for BUF_BYTES_MAX.
2581
2582 * image.c: Use ptrdiff_t, not int, for sizes.
2583 (slurp_file): Switch from int to ptrdiff_t.
2584 All uses changed.
2585 (slurp_file): Check that file size fits in both size_t (for
2586 malloc) and ptrdiff_t (for sanity and safety).
2587
2588 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2589 if b->modtime has its maximal value.
2590
2591 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2592
2593 Don't assume time_t can fit into int.
2594 * buffer.h (struct buffer.modtime): Now time_t, not int.
2595 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2596 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2597
2598 Minor fixes for signed vs unsigned integers.
2599 * character.h (MAYBE_UNIFY_CHAR):
2600 * charset.c (maybe_unify_char):
2601 * keyboard.c (read_char, reorder_modifiers):
2602 XINT -> XFASTINT, since the integer must be nonnegative.
2603 * ftfont.c (ftfont_spec_pattern):
2604 * keymap.c (access_keymap, silly_event_symbol_error):
2605 XUINT -> XFASTINT, since the integer must be nonnegative.
2606 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2607 since it makes no difference and we prefer signed.
2608 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2609 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2610 nonnegative.
2611
2612 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2613
2614 * window.h (Fwindow_frame): Declare.
2615
2616 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2617
2618 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2619 (SPARE_MEMORY): Always define.
2620 (LARGE_REQUEST): Remove.
2621 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2622
2623 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2624
2625 * lisp.h: Move EXFUNS for Fframe_root_window,
2626 Fframe_first_window and Fset_frame_selected_window to window.h.
2627
2628 * window.h: Move EXFUNS for Fframe_root_window,
2629 Fframe_first_window and Fset_frame_selected_window here from
2630 lisp.h.
2631
2632 * frame.c (Fwindow_frame, Fframe_first_window)
2633 (Fframe_root_window, Fframe_selected_window)
2634 (Fset_frame_selected_window): Move to window.c.
2635 (Factive_minibuffer_window): Move to minibuf.c.
2636 (Fother_visible_frames_p): New function.
2637
2638 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2639
2640 * window.c (decode_window, decode_any_window): Move up in code.
2641 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2642 (inhibit_frame_unsplittable): Remove unused variable.
2643 (Fwindow_buffer): Move up and rewrite doc-string.
2644 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2645 (Fwindow_prev): New functions.
2646 (Fwindow_frame): Move here from frame.c. Accept any window as
2647 argument.
2648 (Fframe_root_window, Fframe_first_window)
2649 (Fframe_selected_window): Move here from frame.c. Accept frame
2650 or arbitrary window as argument. Update doc-strings.
2651 (Fminibuffer_window): Move up in code.
2652 (Fwindow_minibuffer_p): Move up in code and simplify.
2653 (Fset_frame_selected_window): Move here from frame.c.
2654 Marginal rewrite.
2655 (Fselected_window, select_window, Fselect_window): Move up in
2656 code. Minor doc-string fixes.
2657
2658 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2659
2660 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2661 Do not assume that spare memory exists; that assumption is valid
2662 only if SYSTEM_MALLOC.
2663 (LARGE_REQUEST): New macro, so that the issue of large requests
2664 is separated from the issue of spare memory.
2665
2666 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2667
2668 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2669 format. (Bug#8806)
2670
2671 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2672
2673 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2674 before statements.
2675
2676 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2677
2678 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2679
2680 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2681
2682 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2683 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2684
2685 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2686
2687 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2688
2689 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2690
2691 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2692 (x_clipboard_manager_save): Add return value.
2693 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2694 New error handlers.
2695 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2696 Obey Vx_select_enable_clipboard_manager. Catch errors in
2697 x_clipboard_manager_save (Bug#8779).
2698 (Vx_select_enable_clipboard_manager): New variable.
2699 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2700
2701 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2702
2703 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2704
2705 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2706
2707 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2708 in the current matrix if keep_current_p is non-zero.
2709
2710 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2711
2712 * bidi.c (bidi_level_of_next_char): Fix last change.
2713
2714 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2715
2716 Support bidi reordering of text covered by display properties.
2717
2718 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2719 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2720 (bidi_cache_search, bidi_cache_iterator_state)
2721 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2722 (bidi_level_of_next_char, bidi_move_to_visually_next):
2723 Support character positions inside a run of characters covered by a
2724 display string.
2725 (bidi_paragraph_init, bidi_resolve_explicit_1)
2726 (bidi_level_of_next_char): Call bidi_fetch_char and
2727 bidi_fetch_char_advance instead of FETCH_CHAR and
2728 FETCH_CHAR_ADVANCE.
2729 (bidi_init_it): Initialize new members.
2730 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2731 definitions.
2732 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2733 instead of using explicit *_CHAR codes.
2734 (bidi_resolve_explicit, bidi_resolve_weak):
2735 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2736 bidirectional text is supported only in multibyte buffers.
2737 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2738 it to initialize the frame_window_p member of struct bidi_it.
2739 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2740 (bidi_resolve_explicit, bidi_resolve_weak)
2741 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2742 bidi_it->nchars is non-positive.
2743 (bidi_level_of_next_char): Don't try to lookup the cache for the
2744 next/previous character if nothing is cached there yet, or if we
2745 were just reseat()'ed to a new position.
2746
2747 * xdisp.c (set_cursor_from_row): Set start and stop points
2748 according to the row's direction when priming the loop that looks
2749 for the glyph on which to display cursor.
2750 (single_display_spec_intangible_p): Function deleted.
2751 (display_prop_intangible_p): Reimplement to call
2752 handle_display_spec instead of single_display_spec_intangible_p.
2753 Accept 3 additional arguments needed by handle_display_spec.
2754 This fixes incorrect cursor motion across display property with complex
2755 values: lists, `(when COND...)' forms, etc.
2756 (single_display_spec_string_p): Support property values that are
2757 lists with the argument STRING its top-level element.
2758 (display_prop_string_p): Fix the condition for processing a
2759 property that is a list to be consistent with handle_display_spec.
2760 (handle_display_spec): New function, refactored from the
2761 last portion of handle_display_prop.
2762 (compute_display_string_pos): Accept additional argument
2763 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2764 value of a `display' property is a "replacing spec".
2765 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2766 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2767 the display property, but just return a value indicating whether
2768 the display property will replace the characters it covers.
2769 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2770 frame_window_p members of struct bidi_it.
2771 (compute_display_string_pos, compute_display_string_end):
2772 New functions.
2773 (push_it): Accept second argument POSITION, where pop_it should
2774 jump to continue iteration.
2775 (reseat_1): Initialize bidi_it.disp_pos.
2776
2777 * keyboard.c (adjust_point_for_property): Adjust the call to
2778 display_prop_intangible_p to its new signature.
2779
2780 * dispextern.h (struct bidi_it): New member frame_window_p.
2781 (bidi_init_it): Update prototypes.
2782 (display_prop_intangible_p): Update prototype.
2783 (compute_display_string_pos, compute_display_string_end):
2784 Declare prototypes.
2785 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2786 EMACS_INT.
2787
2788 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2789
2790 Malloc failure behavior now depends on size of allocation.
2791 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2792 * lisp.h: Change signatures accordingly.
2793 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2794 All callers changed. (Bug#8762)
2795
2796 * gnutls.c: Use Emacs's memory allocators.
2797 Without this change, the gnutls library would invoke malloc etc.
2798 directly, which causes problems on non-SYNC_INPUT hosts, and which
2799 runs afoul of improving memory_full behavior. (Bug#8761)
2800 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2801 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2802 xfree instead of the default malloc, realloc, free.
2803 (Fgnutls_boot): No need to check for memory allocation failure,
2804 since xmalloc does that for us.
2805
2806 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2807 * category.c (hash_get_category_set):
2808 * ccl.c (ccl_driver):
2809 * charset.c (Fdefine_charset_internal):
2810 * charset.h (struct charset.hash_index):
2811 * composite.c (get_composition_id, gstring_lookup_cache)
2812 (composition_gstring_put_cache):
2813 * composite.h (struct composition.hash_index):
2814 * dispextern.h (struct image.hash):
2815 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2816 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2817 (hashfn_equal, hashfn_user_defined, make_hash_table)
2818 (maybe_resize_hash_table, hash_lookup, hash_put)
2819 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2820 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2821 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2822 * image.c (make_image, search_image_cache, lookup_image)
2823 (xpm_put_color_table_h):
2824 * lisp.h (struct Lisp_Hash_Table):
2825 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2826 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2827 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2828 * alloc.c (allocate_vectorlike):
2829 Check for overflow in vector size calculations.
2830 * ccl.c (ccl_driver):
2831 Check for overflow when converting EMACS_INT to int.
2832 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2833 need to be updated by these changes.
2834 * fns.c (make_hash_table, maybe_resize_hash_table):
2835 Check for integer overflow with large hash tables.
2836 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2837 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2838 (SXHASH_REDUCE): New macro.
2839 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2840 Use it instead of discarding useful hash info with large hash values.
2841 (sxhash_float): New function.
2842 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2843 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2844 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2845 Rewrite to use FIXNUM_BITS, as this simplifies things.
2846 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2847 Adjust signatures to match updated version of code.
2848 (consing_since_gc): Now EMACS_INT, since a single hash table can
2849 use more than INT_MAX bytes.
2850
2851 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2852
2853 Make it possible to build with GCC-4.6+ -O2 -flto.
2854
2855 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2856
2857 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2858
2859 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2860 Call minibuffer-inactive-mode.
2861
2862 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2863
2864 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2865 Update dependencies.
2866
2867 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2868
2869 * data.c (init_data): Remove code for UTS, this system is not
2870 supported anymore.
2871
2872 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2873
2874 Don't force ./temacs to start in terminal mode.
2875
2876 * frame.c (make_initial_frame): Initialize faces in all cases, not
2877 only when CANNOT_DUMP is defined.
2878 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2879
2880 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2881
2882 * dispnew.c (add_window_display_history): Use const for the string
2883 pointer. Remove declaration, not needed.
2884
2885 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2886
2887 Use 'inline', not 'INLINE'.
2888 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2889 * alloc.c, fontset.c (INLINE): Remove.
2890 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2891 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2892 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2893 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2894 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2895
2896 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2897
2898 Make it possible to run ./temacs.
2899
2900 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2901 syms_of_callproc does the same thing. Remove test for
2902 "initialized", do it in the caller.
2903 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2904
2905 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2906
2907 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2908 (read_minibuf): Use get_minibuffer.
2909 (syms_of_minibuf): Use DEFSYM.
2910 (Qmetadata): New var.
2911 * data.c (Qbuffer): Don't make it static.
2912 (syms_of_data): Use DEFSYM.
2913
2914 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2915
2916 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2917 (CCL_CODE_MIN): New macro.
2918
2919 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2920
2921 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2922
2923 * eval.c (Qdebug): Now static.
2924 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2925 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2926 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2927
2928 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2929
2930 * image.c: Various fixes to ImageMagick code comments.
2931 (Fimagemagick_types): Doc fix.
2932
2933 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2934
2935 Minor fixes prompted by GCC 4.6.0 warnings.
2936
2937 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2938
2939 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2940 (x_clipboard_manager_save_all): Move extern decl to ...
2941 * xterm.h: ... here, so that it can be checked for consistency.
2942
2943 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2944
2945 * xselect.c (x_clipboard_manager_save_frame)
2946 (x_clipboard_manager_save_all): New functions.
2947 (Fx_clipboard_manager_save): Lisp function deleted.
2948
2949 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2950 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2951
2952 * xterm.h: Update prototype.
2953
2954 2011-05-28 William Xu <william.xwl@gmail.com>
2955
2956 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2957 exiting (Bug#8239).
2958
2959 2011-05-28 Jim Meyering <meyering@redhat.com>
2960
2961 Avoid a sign-extension bug in crypto_hash_function.
2962 * fns.c (to_uchar): Define.
2963 (crypto_hash_function): Use it to convert some newly-signed
2964 variables to unsigned, to avoid sign-extension bugs. For example,
2965 without this change, (md5 "truc") would evaluate to
2966 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2967 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2968 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2969
2970 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2971
2972 Integer overflow fixes.
2973
2974 * dbusbind.c: Serial number integer overflow fixes.
2975 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2976 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2977 to hold a serial number that is too large for a fixnum.
2978 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2979 Check for serial numbers out of range. Decode any serial number
2980 that was so large that it became a float. (Bug#8722)
2981
2982 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2983 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2984 Use XFASTINT rather than XUINT when numbers are nonnegative.
2985 (xd_append_arg, Fdbus_method_return_internal):
2986 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2987 arguments, check that Lisp number is nonnegative, rather than
2988 silently wrapping negative numbers around. (Bug#8722)
2989 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2990 (Bug#8722)
2991
2992 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2993
2994 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2995
2996 ccl: add integer overflow checks
2997 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2998 (IN_INT_RANGE): New macros.
2999 (ccl_driver): Use them to check for integer overflow when
3000 decoding a CCL program. Many of the new checks are whether XINT (x)
3001 fits in int; it doesn't always, on 64-bit hosts. The new version
3002 doesn't catch all possible integer overflows, but it's an
3003 improvement. (Bug#8719)
3004
3005 * alloc.c (make_event_array): Use XINT, not XUINT.
3006 There's no need for unsigned here.
3007
3008 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3009 This follows up to the 2011-05-06 change that substituted uintptr_t
3010 for EMACS_INT. This case wasn't caught back then.
3011
3012 Rework Fformat to avoid integer overflow issues.
3013 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3014 now (part of C89). Include <verify.h>.
3015 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3016 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3017 (Fformat): Avoid the prepass trying to compute sizes; it was only
3018 approximate and thus did not catch overflow reliably. Instead, walk
3019 through the format just once, formatting and computing sizes as we go,
3020 checking for integer overflow at every step, and allocating a larger
3021 buffer as needed. Keep track separately whether the format is
3022 multibyte. Keep only the most-recently calculated precision, rather
3023 than them all. Record whether each argument has been converted to
3024 string. Use EMACS_INT, not int, for byte and char and arg counts.
3025 Support field widths and precisions larger than INT_MAX. Avoid
3026 sprintf's undefined behavior with conversion specifications such as %#d
3027 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3028 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3029 formatting out-of-range floating point numbers with int
3030 formats. (Bug#8668)
3031
3032 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3033
3034 * data.c: Avoid integer truncation in expressions involving floats.
3035 * data.c: Include <intprops.h>.
3036 (arith_driver): When there's an integer overflow in an expression
3037 involving floating point, convert the integers to floating point
3038 so that the resulting value does not suffer from catastrophic
3039 integer truncation. For example, on a 64-bit host (* 4
3040 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3041 Do not rely on undefined behavior after integer overflow.
3042
3043 merge count_size_as_multibyte, parse_str_to_multibyte
3044 * character.c, character.h (count_size_as_multibyte):
3045 Rename from parse_str_to_multibyte; all uses changed.
3046 Check for integer overflow.
3047 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3048 since it's now a duplicate of the other. This is more of
3049 a character than a buffer op, so better that it's in character.c.
3050 * fns.c, print.c: Adjust to above changes.
3051
3052 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3053
3054 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3055
3056 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3057
3058 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3059 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3060 (x_clipboard_manager_save): Now static.
3061 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3062
3063 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3064 (crypto_hash_function): Now static.
3065 Fix pointer signedness problems. Avoid unnecessary initializations.
3066
3067 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3068
3069 * termhooks.h (Vselection_alist): Make it terminal-local.
3070
3071 * terminal.c (create_terminal): Initialize it.
3072
3073 * xselect.c: Support for clipboard managers.
3074 (Vselection_alist): Move to termhooks.h as terminal-local var.
3075 (LOCAL_SELECTION): New macro.
3076 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3077 (symbol_to_x_atom): Remove gratuitous arg.
3078 (x_handle_selection_request, lisp_data_to_selection_data)
3079 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3080 (x_own_selection, x_get_local_selection, x_convert_selection):
3081 New arg, specifying work frame. Use terminal-local Vselection_alist.
3082 (some_frame_on_display): Delete unused function.
3083 (Fx_own_selection_internal, Fx_get_selection_internal)
3084 (Fx_disown_selection_internal, Fx_selection_owner_p)
3085 (Fx_selection_exists_p): New optional frame arg.
3086 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3087 (x_handle_selection_clear): Don't treat other terminals with the
3088 same keyboard specially. Use the terminal-local Vselection_alist.
3089 (x_clear_frame_selections): Use Frun_hook_with_args.
3090
3091 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3092
3093 * xterm.h: Add support for those atoms.
3094
3095 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3096
3097 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3098 (converted_selections, conversion_fail_tag): New global variables.
3099 (x_selection_request_lisp_error): Free the above.
3100 (x_get_local_selection): Remove unnecessary code.
3101 (x_reply_selection_request): Args changed; handle arbitrary array
3102 of converted selections stored in converted_selections.
3103 Separate the XChangeProperty and SelectionNotify steps.
3104 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3105 (x_convert_selection): New function.
3106 (x_handle_selection_event): Simplify.
3107 (x_get_foreign_selection): Don't ignore incoming requests while
3108 waiting for an answer; this will fail when we implement
3109 SAVE_TARGETS, and seems unnecessary anyway.
3110 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3111 (Vx_sent_selection_functions): Doc fix.
3112
3113 2011-05-26 Leo Liu <sdl.web@gmail.com>
3114
3115 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3116
3117 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3118
3119 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3120
3121 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3122 for fringe update if it has periodic bitmap.
3123 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3124 and fringe_bitmap_periodic_p.
3125
3126 * fringe.c (get_fringe_bitmap_data): New function.
3127 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3128 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3129 row. Mark glyph row for fringe update if periodicity changed.
3130
3131 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3132 for fringe update unless it has periodic bitmap.
3133
3134 2011-05-25 Kenichi Handa <handa@m17n.org>
3135
3136 * xdisp.c (get_next_display_element): Set correct it->face_id for
3137 a static composition.
3138
3139 2011-05-24 Leo Liu <sdl.web@gmail.com>
3140
3141 * deps.mk (fns.o):
3142 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3143
3144 * fns.c (crypto_hash_function, Fsha1): New function.
3145 (Fmd5): Use crypto_hash_function.
3146 (syms_of_fns): Add Ssha1.
3147
3148 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3149
3150 * gnutls.c: Remove unused macros.
3151 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3152 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3153 Remove macros that are defined and never used.
3154 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3155
3156 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3157
3158 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3159 (Fx_get_selection_internal): Minor cleanup.
3160 (Fx_own_selection_internal): Rename arguments for consistency with
3161 select.el.
3162
3163 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3166
3167 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3168
3169 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3170
3171 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3172
3173 * dispnew.c (scrolling_window): Don't exclude the case that the
3174 last enabled row in the desired matrix touches the bottom boundary.
3175
3176 2011-05-21 Glenn Morris <rgm@gnu.org>
3177
3178 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3179 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3180 and add some more files.
3181
3182 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3183
3184 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3185 report_file_error introduced by the change from 2011-05-07.
3186
3187 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3188
3189 * systime.h (Time): Define only if emacs is defined.
3190 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3191 where the include path doesn't have X11/X.h by default. See
3192 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3193
3194 2011-05-20 Kenichi Handa <handa@m17n.org>
3195
3196 * composite.c (find_automatic_composition): Fix previous change.
3197
3198 2011-05-20 Glenn Morris <rgm@gnu.org>
3199
3200 * lisp.mk: New file, split from Makefile.in.
3201 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3202 (shortlisp): Remove.
3203 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3204
3205 2011-05-19 Glenn Morris <rgm@gnu.org>
3206
3207 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3208 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3209 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3210 (lisp): Set the order to that of loadup.el.
3211 (shortlisp): Make it a copy of $lisp.
3212 (SOME_MACHINE_LISP): Remove.
3213 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3214 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3215
3216 2011-05-18 Kenichi Handa <handa@m17n.org>
3217
3218 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3219 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3220 (find_automatic_composition): Mostly rewrite for efficiency.
3221
3222 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3223
3224 * makefile.w32-in: Update dependencies.
3225
3226 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3227
3228 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3229 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3230
3231 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3232
3233 Fix some integer overflow issues, such as string length overflow.
3234
3235 * insdel.c (count_size_as_multibyte): Check for string overflow.
3236
3237 * character.c (lisp_string_width): Check for string overflow.
3238 Use EMACS_INT, not int, for string indexes and lengths; in
3239 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3240 the resulting string length overflows an EMACS_INT; instead,
3241 report a string overflow if no precision given. When checking for
3242 precision exhaustion, use a check that cannot possibly have
3243 integer overflow. (Bug#8675)
3244 * character.h (lisp_string_width): Adjust to new signature.
3245
3246 * alloc.c (string_overflow): New function.
3247 (Fmake_string): Use it. This doesn't change behavior, but saves
3248 a few bytes and will simplify future changes.
3249 * character.c (string_escape_byte8): Likewise.
3250 * lisp.h (string_overflow): New decl.
3251
3252 Fixups, following up to the user-interface timestamp change.
3253 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3254 for UI timestamps, instead of unsigned long.
3255 * msdos.c (mouse_get_pos): Likewise.
3256 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3257 * w32gui.h (Time): Define by including "systime.h" rather than by
3258 declaring it ourselves. (Bug#8664)
3259
3260 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3261 * image.c (clear_image_cache): Likewise.
3262
3263 * term.c (term_mouse_position): Don't assume time_t wraparound.
3264
3265 Be more systematic about user-interface timestamps.
3266 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3267 and sometimes 'EMACS_UINT', to represent these timestamps.
3268 This change causes it to use 'Time' uniformly, as that's what X uses.
3269 This makes the code easier to follow, and makes it easier to catch
3270 integer overflow bugs such as Bug#8664.
3271 * frame.c (Fmouse_position, Fmouse_pixel_position):
3272 Use Time, not unsigned long, for user-interface timestamps.
3273 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3274 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3275 * keyboard.h (last_event_timestamp): Likewise.
3276 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3277 * menu.h (xmenu_show): Likewise.
3278 * term.c (term_mouse_position): Likewise.
3279 * termhooks.h (struct input_event.timestamp): Likewise.
3280 (struct terminal.mouse_position_hook): Likewise.
3281 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3282 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3283 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3284 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3285 what it was before.
3286 * menu.h, termhooks.h: Include "systime.h", for Time.
3287
3288 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3289 Don't assume that the difference between two unsigned long values
3290 can fit into an integer. At this point, we know button_down_time
3291 <= event->timestamp, so the difference must be nonnegative, so
3292 there's no need to cast the result if double-click-time is
3293 nonnegative, as it should be; check that it's nonnegative, just in
3294 case. This bug is triggered when events are more than 2**31 ms
3295 apart (about 25 days). (Bug#8664)
3296
3297 * xselect.c (last_event_timestamp): Remove duplicate decl.
3298 (x_own_selection): Remove needless cast to unsigned long.
3299
3300 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3301 that always fit in int. Use a sentinel instead of a counter, to
3302 avoid a temp and to allay GCC's concerns about possible int overflow.
3303 * frame.h (struct frame): Use int for menu_bar_items_used
3304 instead of EMACS_INT, since it always fits in int.
3305
3306 * menu.c (grow_menu_items): Check for int overflow.
3307
3308 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3309
3310 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3311 Before, the code was not consistent. These values cannot exceed
3312 2**31 - 1 so there's no need to make them unsigned.
3313 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3314 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3315 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3316 as modifiers.
3317 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3318
3319 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3320 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3321 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3322 presumably because the widths might not match.
3323
3324 * window.c (size_window): Avoid needless test at loop start.
3325
3326 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3327
3328 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3329
3330 2011-05-12 Drew Adams <drew.adams@oracle.com>
3331
3332 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3333
3334 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3335
3336 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3337 `width' to `bar_area_x' and `bar_area_width', respectively.
3338 (x_scroll_run): Take account of fringe background extension.
3339
3340 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3341 Rename local vars `left' and `width' to `bar_area_x' and
3342 `bar_area_width', respectively.
3343 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3344 background extension.
3345
3346 2011-05-10 Jim Meyering <meyering@redhat.com>
3347
3348 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3349
3350 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3351
3352 * image.c (Finit_image_library): Return t for built-in image types,
3353 like pbm and xbm. (Bug#8640)
3354
3355 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3356
3357 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3358
3359 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3360
3361 * w32console.c (Fset_screen_color): Doc fix.
3362 (Fget_screen_color): New function.
3363 (syms_of_ntterm): Defsubr it.
3364
3365 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3366 unlink the temporary file if Fcall_process didn't create it in the
3367 first place.
3368 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3369 child process will be redirected to a file specified with `:file'.
3370 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3371 cue to call_process_cleanup not to close that handle.
3372
3373 2011-05-07 Ben Key <bkey76@gmail.com>
3374
3375 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3376 one of two shell specific rules, either bootstrap-temacs-CMD or
3377 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3378 to the previous implementation of the bootstrap-temacs rule.
3379 The bootstrap-temacs-CMD rule is similar to the previous
3380 implementation of the bootstrap-temacs rule except that it
3381 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3382 variable.
3383
3384 These changes, along with some changes to nt/configure.bat,
3385 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3386 earlier fix to add support for --cflags and --ldflags options
3387 that include quotes so that it works whether make uses cmd or
3388 sh as the shell.
3389
3390 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3391
3392 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3393 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3394 is a constant.
3395 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3396 a string. Handle both cases.
3397 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3398 (Fdbus_register_method): Use Qinvalid_function.
3399
3400 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3401
3402 * makefile.w32-in: Update dependencies.
3403 (LISP_H): Add inttypes.h and stdin.h.
3404 (PROCESS_H): Add unistd.h.
3405
3406 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3407
3408 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3409 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3410
3411 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3412
3413 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3414
3415 * term.c (vfatal): Remove stray call to va_end.
3416 It's not needed and the C Standard doesn't allow it here anyway.
3417
3418 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3419 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3420
3421 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3422 bytes.
3423
3424 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3425
3426 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3427
3428 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3429
3430 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3431
3432 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3433
3434 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3435 * charset.c (Fdefine_charset_internal): Don't initialize
3436 charset.code_space[15]. The value was garbage, on hosts with
3437 32-bit int (Bug#8600).
3438
3439 * lread.c (read_integer): Be more consistent with string-to-number.
3440 Use string_to_number to do the actual conversion; this avoids
3441 rounding errors and fixes some other screwups. Without this fix,
3442 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3443 (digit_to_number): Move earlier, for benefit of read_integer.
3444 Return -1 if the digit is out of range for the base, -2 if it is
3445 not a digit in any supported base. (Bug#8602)
3446
3447 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3448
3449 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3450 to match comment at start of function. This also removes a
3451 GCC warning about overflow in a 32+64-bit port.
3452
3453 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3454
3455 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3456 Reported by Stefan Monnier in
3457 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3458 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3459 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3460
3461 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3462 (EMACS_UINTPTR): Likewise, with uintptr_t.
3463
3464 * lisp.h: Prefer 64-bit EMACS_INT if available.
3465 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3466 on 32-bit hosts that have 64-bit int, so that they can access
3467 large files.
3468 However, temporarily disable this change unless the temporary
3469 symbol WIDE_EMACS_INT is defined.
3470
3471 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3472
3473 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3474 This removes an assumption that EMACS_INT and long are the same
3475 width as pointers. The assumption is true for Emacs porting targets
3476 now, but we want to make other targets possible.
3477 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3478 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3479 In the rest of the code, change types of integers that hold casted
3480 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3481 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3482 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3483 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3484 No need to cast type when ORing.
3485 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3486 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3487 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3488 assume EMACS_INT is the same width as char *.
3489 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3490 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3491 Remove no-longer-needed casts.
3492 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3493 (xg_tool_bar_help_callback, xg_make_tool_item):
3494 Use EMACS_INTPTR to hold an integer
3495 that will be cast to void *; this can avoid a GCC warning
3496 if EMACS_INT is not the same width as void *.
3497 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3498 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3499 (current_message_1, set_message_1):
3500 Use a local to convert to proper width without a cast.
3501 * xmenu.c (dialog_selection_callback): Likewise.
3502
3503 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3504 Also, don't assume VALBITS / RAND_BITS is less than 5,
3505 and don't rely on undefined behavior when shifting a 1 left into
3506 the sign bit.
3507 * lisp.h (get_random): Change signature to match.
3508
3509 * lread.c (hash_string): Use size_t, not int, for hash computation.
3510 Normally we prefer signed values; but hashing is special, because
3511 it's better to use unsigned division on hash table sizes so that
3512 the remainder is nonnegative. Also, size_t is the natural width
3513 for hashing into memory. The previous code used 'int', which doesn't
3514 retain enough info to hash well into very large tables.
3515 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3516
3517 * dbusbind.c: Don't possibly lose pointer info when converting.
3518 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3519 Use XPNTR rather than XHASH, so that the high-order bits of
3520 the pointer aren't lost when converting through void *.
3521
3522 * eval.c (Fautoload): Don't double-shift a pointer.
3523
3524 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3525
3526 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3527
3528 * gnutls.c (DEF_GNUTLS_FN):
3529 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3530
3531 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3532
3533 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3534 marker. (Bug#8610)
3535
3536 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3537
3538 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3539 New version that can reserve upto 2GB of heap space.
3540
3541 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3542
3543 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3544
3545 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3546
3547 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3548 `gnutls_certificate_set_x509_key_file'.
3549
3550 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3551
3552 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3553 Update dependencies.
3554
3555 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3556
3557 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3558 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3559 Remove unused parameter `fildes'.
3560 * process.c (read_process_output, send_process): Don't pass it.
3561
3562 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3563
3564 Fix previous change: the library cache is defined in w32.c.
3565 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3566 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3567
3568 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3569
3570 Implement dynamic loading of GnuTLS on Windows.
3571
3572 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3573 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3574 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3575 Declare.
3576
3577 * gnutls.c (Qgnutls_dll): Define.
3578 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3579 (gnutls_*): Declare function pointers.
3580 (init_gnutls_functions): New function to initialize function pointers.
3581 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3582 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3583 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3584 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3585 (emacs_gnutls_write, emacs_gnutls_read)
3586 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3587 (Fgnutls_available_p): New function.
3588 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3589 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3590 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3591
3592 * image.c: Include w32.h.
3593 (Vimage_type_cache): Delete.
3594 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3595 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3596 (w32_delayed_load): Move to w32.c.
3597
3598 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3599
3600 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3601 (w32_delayed_load): Move from image.c. When loading a library, record
3602 its filename in the :loaded-from property of the library id.
3603 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3604 Initialize and staticpro them.
3605 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3606
3607 * process.c: Include lisp.h before w32.h, not after.
3608 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3609 instead of gnutls_record_check_pending.
3610
3611 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3612
3613 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3614
3615 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3616 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3617 as passed in.
3618
3619 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3620
3621 * xterm.c (x_set_frame_alpha): Do not set property on anything
3622 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3623
3624 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3625
3626 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3627
3628 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3629
3630 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3631 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3632 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3633 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3634 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3635 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3636 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3637 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3638 (Qgnutls_bootprop_callbacks_verify): Make static.
3639
3640 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3641
3642 * callproc.c: Indentation fixup.
3643
3644 * sysdep.c (wait_for_termination_1): Make static.
3645 (wait_for_termination, interruptible_wait_for_termination):
3646 Move after wait_for_termination_1.
3647
3648 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3649
3650 * sysdep.c (interruptible_wait_for_termination): New function
3651 which is like wait_for_termination, but allows keyboard
3652 interruptions.
3653
3654 * callproc.c (Fcall_process): Add (:file "file") as an option for
3655 the STDOUT buffer.
3656 (Fcall_process_region): Ditto.
3657
3658 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3659
3660 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3661 rather than `XVECTOR (FOO)->size'.
3662
3663 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3664 inttypes.h, as a gnulib replacement is used if it not available in
3665 system headers.
3666
3667 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3668
3669 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3670 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3671 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3672
3673 * coding.c (coding_alloc_by_realloc): Error out if destination
3674 will grow beyond MOST_POSITIVE_FIXNUM.
3675 (decode_coding_emacs_mule): Abort if there isn't enough place in
3676 charbuf for the composition carryover bytes. Reserve an extra
3677 space for up to 2 characters produced in a loop.
3678 (decode_coding_iso_2022): Abort if there isn't enough place in
3679 charbuf for the composition carryover bytes.
3680
3681 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3682
3683 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3684 aborting when %lld or %lll format is passed.
3685 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3686 %llo or %llx format is passed. (Bug#8545)
3687
3688 * window.c (window_scroll_line_based): Use a marker instead of
3689 simple variables to record original value of point. (Bug#7952)
3690
3691 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3692 produced by %s or %c overflows available buffer space. (Bug#8545)
3693
3694 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3695
3696 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3697 (SIZE_MAX): Move defn after all includes, as they might #define it.
3698
3699 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3700
3701 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3702
3703 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3704
3705 * keyboard.c (Qdelayed_warnings_hook): Define.
3706 (command_loop_1): Run `delayed-warnings-hook'
3707 if Vdelayed_warnings_list is non-nil.
3708 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3709 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3710
3711 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3712
3713 * doprnt.c (doprnt): Don't return value smaller than the buffer
3714 size if the message was truncated. (Bug#8545).
3715
3716 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3717
3718 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3719 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3720
3721 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3722
3723 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3724
3725 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3726
3727 * makefile.w32-in: Update dependencies.
3728
3729 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3730
3731 Improve `doprnt' and its usage. (Bug#8545)
3732 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3733 `format_end'. Remove support for %l as a conversion specifier.
3734 Don't use xrealloc. Improve diagnostics when the %l size modifier
3735 is used. Update the commentary.
3736
3737 * eval.c (verror): Simplify calculation of size_t.
3738
3739 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3740 messages.
3741
3742 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3743
3744 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3745 change.
3746
3747 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3748
3749 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3750 This makes this file independent of the recent pseudovector change.
3751
3752 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3753
3754 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3755
3756 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3757 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3758 Remove unused local.
3759 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3760
3761 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3762 GCC 4.6.0 optimizes based on type-based alias analysis.
3763 For example, if b is of type struct buffer * and v of type struct
3764 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3765 != &v->size, and therefore "v->size = 1; b->size = 2; return
3766 v->size;" must therefore return 1. This assumption is incorrect
3767 for Emacs, since it type-puns struct Lisp_Vector * with many other
3768 types. To fix this problem, this patch adds a new type struct
3769 vectorlike_header that documents the constraints on layout of vectors
3770 and pseudovectors, and helps optimizing compilers not get fooled
3771 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3772 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3773 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3774 the size member.
3775 (XSETPVECTYPE): Rewrite in terms of new macro.
3776 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3777 This is a bit clearer, and further avoids the possibility of
3778 undesirable aliasing.
3779 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3780 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3781 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3782 since Lisp_Subr is a special case (no "next" field).
3783 (ASIZE): Now uses header.size rather than size.
3784 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3785 to avoid the hassle of writing XVECTOR (foo)->header.size.
3786 (struct vectorlike_header): New type.
3787 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3788 object, to help avoid aliasing.
3789 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3790 (SUBRP): Likewise, since Lisp_Subr is a special case.
3791 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3792 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3793 (struct Lisp_Hash_Table): Combine first two members into a single
3794 struct vectorlike_header member. All uses of "size" and "next" members
3795 changed to be "header.size" and "header.next".
3796 * buffer.h (struct buffer): Likewise.
3797 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3798 * frame.h (struct frame): Likewise.
3799 * process.h (struct Lisp_Process): Likewise.
3800 * termhooks.h (struct terminal): Likewise.
3801 * window.c (struct save_window_data, struct saved_window): Likewise.
3802 * window.h (struct window): Likewise.
3803 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3804 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3805 * buffer.c (init_buffer_once): Likewise.
3806 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3807 special case.
3808 * process.c (Fformat_network_address): Use local var for size,
3809 for brevity.
3810
3811 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3812
3813 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3814 * data.c (atof): Remove decl; no longer used or needed.
3815 (digit_to_number): Move to lread.c.
3816 (Fstring_to_number): Use new string_to_number function, to be
3817 consistent with how the Lisp reader treats infinities and NaNs.
3818 Do not assume that floating-point numbers represent EMACS_INT
3819 without losing information; this is not true on most 64-bit hosts.
3820 Avoid double-rounding errors, by insisting on integers when
3821 parsing non-base-10 numbers, as the documentation specifies.
3822 * lisp.h (string_to_number): New decl, replacing ...
3823 (isfloat_string): Remove.
3824 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3825 (read1): Do not accept +. and -. as integers; this
3826 appears to have been a coding error. Similarly, do not accept
3827 strings like +-1e0 as floating point numbers. Do not report
3828 overflow for integer overflows unless the base is not 10 which
3829 means we have no simple and reliable way to continue.
3830 Break out the floating-point parsing into a new
3831 function string_to_number, so that Fstring_to_number parses
3832 floating point numbers consistently with the Lisp reader.
3833 (digit_to_number): Move here from data.c. Make it static inline.
3834 (E_CHAR, EXP_INT): Remove, replacing with ...
3835 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3836 (string_to_number): New function, replacing isfloat_string.
3837 This function checks for valid syntax and produces the resulting
3838 Lisp float number too. Rework it so that string-to-number
3839 no longer mishandles examples like "1.0e+". Use strtoumax,
3840 so that overflow for non-base-10 numbers is reported only when
3841 there's no portable and simple way to convert to floating point.
3842
3843 * textprop.c (set_text_properties_1): Rewrite for clarity,
3844 and to avoid GCC warning about integer overflow.
3845
3846 * intervals.h (struct interval): Use EMACS_INT for members
3847 where EMACS_UINT might cause problems. See
3848 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3849 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3850 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3851 All uses changed.
3852 (offset_intervals): Tell GCC not to worry about length overflow
3853 when negating a negative length.
3854
3855 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3856 (overrun_check_free): Likewise.
3857
3858 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3859 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3860 word size.
3861
3862 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3863 (gnutls_make_error): Rename local to avoid shadowing.
3864 (gnutls_emacs_global_deinit): ifdef out; not used.
3865 (Fgnutls_boot): Use const for pointer to readonly storage.
3866 Comment out unused local. Fix pointer signedness problems.
3867
3868 * lread.c (openp): Don't stuff size_t into an 'int'.
3869 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3870 about possible signed overflow.
3871
3872 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3873 (GDK_KEY_g): Don't define if already defined.
3874 (xg_prepare_tooltip): Avoid pointer signedness problem.
3875 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3876
3877 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3878 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3879
3880 * xfns.c (Fx_window_property): Simplify a bit,
3881 to make a bit faster and to avoid GCC 4.6.0 warning.
3882 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3883
3884 * fns.c (internal_equal): Don't assume size_t fits in int.
3885
3886 * alloc.c (compact_small_strings): Tighten assertion a little.
3887
3888 Replace pEd with more-general pI, and fix some printf arg casts.
3889 * lisp.h (pI): New macro, generalizing old pEd macro to other
3890 conversion specifiers. For example, use "...%"pI"d..." rather
3891 than "...%"pEd"...".
3892 (pEd): Remove. All uses replaced with similar uses of pI.
3893 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3894 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3895 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3896 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3897 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3898 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3899 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3900 64-bit hosts.
3901 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3902 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3903 * print.c (safe_debug_print, print_object): Likewise.
3904 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3905 to int.
3906 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3907 avoiding the 0 flag, which is not portable.
3908 * process.c (Fmake_network_process): Use pI to avoid cast.
3909 * region-cache.c (pp_cache): Likewise.
3910 * xdisp.c (decode_mode_spec): Likewise.
3911 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3912 behavior on 64-bit hosts with printf arg.
3913 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3914 (x_stop_queuing_selection_requests): Likewise.
3915 (x_get_window_property): Don't truncate byte count to an 'int'
3916 when tracing.
3917
3918 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3919 here, since it parses constructs like leading '-' and spaces,
3920 which are not wanted; and it overflows with large numbers.
3921 Instead, simply match F[0-9]+, which is what is wanted anyway.
3922
3923 * alloc.c: Remove unportable assumptions about struct layout.
3924 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3925 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3926 (allocate_vectorlike, make_pure_vector): Use the new macros,
3927 plus offsetof, to remove unportable assumptions about struct layout.
3928 These assumptions hold on all porting targets that I know of, but
3929 they are not guaranteed, they're easy to remove, and removing them
3930 makes further changes easier.
3931
3932 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3933 This doesn't fix a bug but makes the code clearer.
3934 (string_overrun_cookie): Now const. Use initializers that
3935 don't formally overflow signed char, to avoid warnings.
3936 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3937 can cause Emacs to crash when string overrun checking is enabled.
3938 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3939 multiple of sizeof (EMACS_INT); it need not be, if
3940 alignof(EMACS_INT) < sizeof (EMACS_INT).
3941 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3942
3943 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3944
3945 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3946
3947 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3948
3949 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3950 supposed to be handshaking. (Bug#8556)
3951 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3952
3953 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3954
3955 * lisp.h (Qdebug): List symbol.
3956 * eval.c (Qdebug): Restore global linkage.
3957 * keyboard.c (debug-on-event): New variable.
3958 (handle_user_signal): Break into debugger when debug-on-event
3959 matches the current signal symbol.
3960
3961 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3962
3963 * alloc.c (check_sblock, check_string_bytes)
3964 (check_string_free_list): Convert to standard C.
3965
3966 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3967
3968 * w32.c (emacs_gnutls_push): Fix typo.
3969
3970 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3971
3972 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3973 "cast to pointer from integer of different size".
3974
3975 Improve doprnt and its use in verror. (Bug#8545)
3976 * doprnt.c (doprnt): Document the set of format control sequences
3977 supported by the function. Use SAFE_ALLOCA instead of always
3978 using `alloca'.
3979
3980 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3981 is one byte too soon. Don't use xrealloc; instead xfree and
3982 xmalloc anew.
3983
3984 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3985
3986 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3987 callbacks stage.
3988
3989 * gnutls.c: Renamed global_initialized to
3990 gnutls_global_initialized. Added internals for the
3991 :verify-hostname-error, :verify-error, and :verify-flags
3992 parameters of `gnutls-boot' and documented those parameters in the
3993 docstring. Start callback support.
3994 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3995 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3996 on error. Return error code.
3997 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3998 (emacs_gnutls_read): Likewise.
3999 (Fgnutls_boot): Return handshake error code.
4000 (emacs_gnutls_handle_error): New function.
4001 (wsaerror_to_errno): Likewise.
4002
4003 * w32.h (emacs_gnutls_pull): Add prototype.
4004 (emacs_gnutls_push): Likewise.
4005
4006 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4007 (emacs_gnutls_push): Likewise.
4008
4009 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4010
4011 * process.c (wait_reading_process_output): Check if GnuTLS
4012 buffered some data internally if no FDs are set for TLS
4013 connections.
4014
4015 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4016 (LIBS): Link to USER_LIBS.
4017 ($(BLD)/gnutls.$(0)): New target.
4018
4019 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4020
4021 * xdisp.c (handle_single_display_spec): Rename the
4022 display_replaced_before_p argument into display_replaced_p, to
4023 make it consistent with the commentary. Fix typos in the
4024 commentary.
4025
4026 * textprop.c (syms_of_textprop): Remove dead code.
4027 (copy_text_properties): Delete obsolete commentary about an
4028 interface that was deleted long ago. Fix typos in the description
4029 of arguments.
4030
4031 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4032 to changes in oldXMenu/XMenu.h from 2011-04-16.
4033 <menu_help_message, prev_menu_help_message>: Constify.
4034 (IT_menu_make_room): menu->help_text is now `const char **';
4035 adjust.
4036
4037 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4038 to changes in oldXMenu/XMenu.h from 2011-04-16.
4039 (struct XMenu): Declare `help_text' `const char **'.
4040
4041 * xfaces.c <Qunspecified>: Make extern again.
4042
4043 * syntax.c: Include sys/types.h before including regex.h, as
4044 required by Posix.
4045
4046 * doc.c (get_doc_string): Improve the format passed to `error'.
4047
4048 * doprnt.c (doprnt): Improve commentary.
4049
4050 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4051
4052 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4053 them with etags.
4054
4055 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4056 changes in globals.h immediately force recompilation.
4057 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4058 $(CURDIR)/s/ms-w32.h.
4059 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4060
4061 * character.c (Fchar_direction): Function deleted.
4062 (syms_of_character): Don't defsubr it.
4063 <char-direction-table>: Deleted.
4064
4065 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4066
4067 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4068 * doprnt.c: Include limits.h.
4069 (SIZE_MAX): New macro.
4070 (doprnt): Return a size_t value. 2nd arg is now size_t.
4071 Many local variables are now size_t instead of int or unsigned.
4072 Improve overflow protection. Support `l' modifier for integer
4073 conversions. Support %l conversion. Don't assume an EMACS_INT
4074 argument for integer conversions and for %c.
4075
4076 * lisp.h (doprnt): Restore prototype.
4077
4078 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4079 $(SRC)/character.h.
4080
4081 * Makefile.in (base_obj): Add back doprnt.o.
4082
4083 * deps.mk (doprnt.o): Add back prerequisites.
4084 (callint.o): Depend on character.h.
4085
4086 * eval.c (internal_lisp_condition_case): Include the handler
4087 representation in the error message.
4088 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4089 when breaking from the loop.
4090
4091 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4092
4093 * callint.c (Fcall_interactively): When displaying error message
4094 about invalid control letter, pass the character's codepoint, not
4095 a pointer to its multibyte form. Improve display of the character
4096 in octal and display also its hex code.
4097
4098 * character.c (char_string): Use %x to display the (unsigned)
4099 codepoint of an invalid character, to avoid displaying a bogus
4100 negative value.
4101
4102 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4103 `error', not SYMBOL_NAME itself.
4104
4105 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4106 character arguments to `error'.
4107
4108 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4109 to `error' in error message about FINAL_CHAR argument. Make sure
4110 FINAL_CHAR is a character, and use %c when it is passed as
4111 argument to `error'.
4112
4113 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4114
4115 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4116
4117 * w32.c: Include <time.h>.
4118 (sys_localtime): New function.
4119
4120 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4121
4122 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4123
4124 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4125
4126 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4127
4128 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4129 zombies (Bug#8467).
4130
4131 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4132
4133 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4134 gl_state.e_property when gl_state.object is Qt.
4135
4136 * insdel.c (make_gap_larger): Remove limitation of buffer size
4137 to <= INT_MAX.
4138
4139 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4140
4141 * xdisp.c (lookup_glyphless_char_display)
4142 (produce_glyphless_glyph): Handle cons cell entry in
4143 glyphless-char-display.
4144 (Vglyphless_char_display): Document it.
4145
4146 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4147 glyphless-char-display.
4148
4149 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4150
4151 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4152
4153 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4154
4155 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4156 definition for no-X builds.
4157
4158 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4159
4160 Static checks with GCC 4.6.0 and non-default toolkits.
4161
4162 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4163
4164 * process.c (keyboard_bit_set): Define only if SIGIO.
4165 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4166 (send_process): Repair possible setjmp clobbering.
4167
4168 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4169
4170 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4171
4172 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4173
4174 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4175 Define only if needed.
4176
4177 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4178 by pacifying GCC about it. Maybe it's time to retire it?
4179 * xfaces.c (USG, __TIMEVAL__): Likewise.
4180
4181 * dispextern.h (struct redisplay_interface): Rename param
4182 to avoid shadowing.
4183 * termhooks.h (struct terminal): Likewise.
4184 * xterm.c (xembed_send_message): Likewise.
4185
4186 * insdel.c (make_gap_smaller): Define only if
4187 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4188
4189 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4190 it.
4191
4192 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4193 so that we aren't warned about unused symbols.
4194
4195 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4196
4197 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4198
4199 * xfns.c (x_real_positions): Mark locals as initialized.
4200
4201 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4202
4203 * xterm.c: Fix problems found by static analysis with other toolkits.
4204 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4205 (x_dispatch_event): Declare static if USE_GTK, and
4206 define if USE_GTK || USE_X_TOOLKIT.
4207 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4208 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4209 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4210 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4211
4212 * xmenu.c (menu_help_callback): Pointer type fixes.
4213 Use const pointers when pointing at readonly data. Avoid pointer
4214 signedness clashes.
4215 (FALSE): Remove unused macro.
4216 (update_frame_menubar): Remove unused decl.
4217
4218 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4219
4220 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4221 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4222 (single_menu_item): Rename local to avoid shadowing.
4223
4224 * keyboard.c (make_lispy_event): Remove unused local var.
4225
4226 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4227 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4228
4229 * bitmaps: Change bitmaps from unsigned char back to the X11
4230 compatible char. Avoid the old compiler warnings about
4231 out-of-range initializers by using, for example, '\xab' rather
4232 than 0xab.
4233
4234 * xgselect.c (xgselect_initialize): Check vs interface
4235 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4236
4237 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4238
4239 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4240 to read-only memory.
4241
4242 * fns.c (vector): Remove; this old hack is no longer needed.
4243
4244 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4245 Remove unused var.
4246 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4247
4248 * xrdb.c (x_load_resources): Omit unused local.
4249
4250 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4251 (x_window): Rename locals to avoid shadowing.
4252 (USG): Use the kludged USG macro, to pacify gcc.
4253
4254 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4255 (x_term_init): Remove local to avoid shadowing.
4256
4257 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4258
4259 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4260 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4261
4262 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4263
4264 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4265
4266 Fix regex.c, syntax.c and friends for buffers > 2GB.
4267 * syntax.h (struct gl_state_s): Declare character position members
4268 EMACS_INT.
4269
4270 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4271
4272 * textprop.c (verify_interval_modification, interval_of):
4273 Declare arguments EMACS_INT.
4274
4275 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4276 EMACS_INT.
4277
4278 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4279
4280 * indent.c (Fvertical_motion): Local variable it_start is now
4281 EMACS_INT.
4282
4283 * regex.c (re_match, re_match_2, re_match_2_internal)
4284 (bcmp_translate, regcomp, regexec, print_double_string)
4285 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4286 (re_compile_pattern, re_exec): Declare arguments and local
4287 variables `size_t' and `ssize_t' and return values `regoff_t', as
4288 appropriate.
4289 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4290 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4291 <compile_stack_type>: `size' and `avail' are now `size_t'.
4292
4293 * regex.h <regoff_t>: Use ssize_t, not int.
4294 (re_search, re_search_2, re_match, re_match_2): Arguments that
4295 specify buffer/string position and length are now ssize_t and
4296 size_t. Return type is regoff_t.
4297
4298 2011-04-16 Ben Key <bkey76@gmail.com>
4299
4300 * nsfont.m: Fixed bugs in ns_get_family and
4301 ns_descriptor_to_entity that were caused by using free to
4302 deallocate memory blocks that were allocated by xmalloc (via
4303 xstrdup). This caused Emacs to crash when compiled with
4304 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4305 --enable-checking=xmallocoverrun). xfree is now used to
4306 deallocate these memory blocks.
4307
4308 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4309
4310 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4311
4312 emacs_write: Accept and return EMACS_INT for sizes.
4313 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4314 et seq.
4315 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4316 Accept and return EMACS_INT.
4317 (emacs_gnutls_write): Return the number of bytes written on
4318 partial writes.
4319 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4320 (emacs_read, emacs_write): Remove check for negative size, as the
4321 Emacs source code has been audited now.
4322 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4323 (emacs_read, emacs_write): Use it.
4324 * process.c (send_process): Adjust to the new signatures of
4325 emacs_write and emacs_gnutls_write. Do not attempt to store
4326 a byte offset into an 'int'; it might overflow.
4327 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4328
4329 * sound.c: Don't assume sizes fit in 'int'.
4330 (struct sound_device.period_size, alsa_period_size):
4331 Return EMACS_INT, not int.
4332 (struct sound_device.write, vox_write, alsa_write):
4333 Accept EMACS_INT, not int.
4334 (wav_play, au_play): Use EMACS_INT to store sizes and to
4335 record read return values.
4336
4337 2011-04-15 Ben Key <bkey76@gmail.com>
4338
4339 * keyboard.c (Qundefined): Don't declare static since it is used
4340 in nsfns.m.
4341 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4342 static since they are used in nsfont.m.
4343
4344 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4345
4346 * process.c (Qprocessp): Don't declare static.
4347 * lisp.h (Qprocessp): Declare again.
4348
4349 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4350
4351 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4352
4353 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4354
4355 Improve C-level modularity by making more things 'static'.
4356
4357 Don't publish debugger-only interfaces to other modules.
4358 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4359 (verify_bytepos, count_markers): Move decls to the only modules
4360 that need them.
4361 * region-cache.h (pp_cache): Likewise.
4362 * window.h (check_all_windows): Likewise.
4363 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4364
4365 * sysdep.c (croak): Now static, if
4366 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4367 * syssignal.h (croak): Declare only if not static.
4368
4369 * alloc.c (refill_memory_reserve): Now static if
4370 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4371 * lisp.h (refill_memory_reserve): Declare only if not static.
4372
4373 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4374 Define only if USE_LUCID.
4375
4376 * xrdb.c (x_customization_string, x_rm_string): Now static.
4377
4378 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4379 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4380
4381 * xdisp.c (draw_row_with_mouse_face): Now static.
4382 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4383
4384 * window.h (check_all_windows): Mark externally visible.
4385
4386 * window.c (window_deletion_count): Now static.
4387
4388 * undo.c: Make symbols static if they're not exported.
4389 (last_undo_buffer, last_boundary_position, pending_boundary):
4390 Now static.
4391
4392 * textprop.c (interval_insert_behind_hooks): Now static.
4393 (interval_insert_in_front_hooks): Likewise.
4394
4395 * term.c: Make symbols static if they're not exported.
4396 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4397 (max_frame_lines, tty_set_terminal_modes):
4398 (tty_reset_terminal_modes, tty_turn_off_highlight):
4399 (get_tty_terminal): Now static.
4400 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4401 * termhooks.h (term_mouse_moveto): Do not declare if
4402 HAVE_WINDOW_SYSTEM.
4403 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4404 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4405
4406 * sysdep.c: Make symbols static if they're not exported.
4407 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4408 Now static.
4409 (sigprocmask_set, full_mask): Remove; unused.
4410 (wait_debugging): Mark as visible.
4411 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4412 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4413
4414 * syntax.c (syntax_temp): Define only if !__GNUC__.
4415
4416 * sound.c (current_sound_device, current_sound): Now static.
4417
4418 * search.c (searchbufs, searchbuf_head): Now static.
4419
4420 * scroll.c (scroll_cost): Remove; unused.
4421 * dispextern.h (scroll_cost): Remove decl.
4422
4423 * region-cache.h (pp_cache): Mark as externally visible.
4424
4425 * process.c: Make symbols static if they're not exported.
4426 (process_tick, update_tick, create_process, chan_process):
4427 (Vprocess_alist, proc_buffered_char, datagram_access):
4428 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4429 (deactivate_process): Mark defn as static, as well as decl.
4430 * lisp.h (create_process): Remove decl.
4431 * process.h (chan_process, Vprocess_alist): Remove decls.
4432
4433 * print.c: Make symbols static if they're not exported.
4434 (print_depth, new_backquote_output, being_printed, print_buffer):
4435 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4436 (print_interval, print_number_index, initial_stderr_stream):
4437 Now static.
4438 * lisp.h (Fprinc): Remove decl.
4439 (debug_output_compilation_hack): Mark as externally visible.
4440
4441 * sysdep.c (croak): Move decl from here to syssignal.h.
4442 * syssignal.h (croak): Put it here, so the API can be checked when
4443 'croak' is called from dissociate_if_controlling_tty.
4444
4445 * minibuf.c: Make symbols static if they're not exported.
4446 (minibuf_save_list, choose_minibuf_frame): Now static.
4447 * lisp.h (choose_minibuf_frame): Remove decl.
4448
4449 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4450
4451 * lread.c: Make symbols static if they're not exported.
4452 (read_objects, initial_obarray, oblookup_last_bucket_number):
4453 Now static.
4454 (make_symbol): Remove; unused.
4455 * lisp.h (initial_obarray, make_symbol): Remove decls.
4456
4457 * keyboard.c: Make symbols static if they're not exported.
4458 (single_kboard, recent_keys_index, total_keys, recent_keys):
4459 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4460 (this_single_command_key_start, echoing, last_auto_save):
4461 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4462 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4463 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4464 (Vlispy_mouse_stem, double_click_count):
4465 Now static.
4466 (force_auto_save_soon): Define only if SIGDANGER.
4467 (ignore_mouse_drag_p): Now static if
4468 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4469 (print_help): Remove; unused.
4470 (stop_character, last_timer_event): Mark as externally visible.
4471 * keyboard.h (ignore_mouse_drag_p): Declare only if
4472 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4473 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4474 * lisp.h (echoing): Remove decl.
4475 (force_auto_save_soon): Declare only if SIGDANGER.
4476 * xdisp.c (redisplay_window): Simplify code, to make it more
4477 obvious that ignore_mouse_drag_p is not accessed if !defined
4478 USE_GTK && !defined HAVE_NS.
4479
4480 * intervals.c: Make symbols static if they're not exported.
4481 (merge_properties_sticky, merge_interval_right, delete_interval):
4482 Now static.
4483 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4484
4485 * insdel.c: Make symbols static if they're not exported.
4486 However, leave prepare_to_modify_buffer alone. It's never
4487 called from outside this function, but that appears to be a bug.
4488 (combine_after_change_list, combine_after_change_buffer):
4489 (adjust_after_replace, signal_before_change): Now static.
4490 (adjust_after_replace_noundo): Remove; unused.
4491 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4492 (signal_before_change): Remove decls.
4493
4494 * indent.c (val_compute_motion, val_vmotion): Now static.
4495
4496 * image.c: Make symbols static if they're not exported.
4497 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4498 if USE_GTK.
4499 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4500 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4501
4502 * fringe.c (standard_bitmaps): Now static.
4503 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4504
4505 * frame.c: Make symbols static if they're not exported.
4506 (x_report_frame_params, make_terminal_frame): Now static.
4507 (get_frame_param): Now static, unless HAVE_NS.
4508 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4509 (x_get_resource_string): Remove; not used.
4510 * frame.h (make_terminal_frame, x_report_frame_params):
4511 (x_get_resource_string); Remove decls.
4512 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4513 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4514
4515 * font.c, fontset.c: Make symbols static if they're not exported.
4516 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4517 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4518 * font.c (font_close_object): Now static.
4519 * font.h (font_close_object): Remove.
4520 * fontset.c (FONTSET_OBJLIST): Remove.
4521 (free_realized_fontset) #if-0 the body, which does nothing.
4522 (face_suitable_for_char_p): #if-0, as it's never called.
4523 * fontset.h (face_suitable_for_char_p): Remove decl.
4524 * xfaces.c (face_at_string_position):
4525 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4526 since 0 is always ASCII.
4527
4528 * fns.c (weak_hash_tables): Now static.
4529
4530 * fileio.c: Make symbols static if they're not exported.
4531 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4532 (Vwrite_region_annotation_buffers): Now static.
4533
4534 * eval.c: Make symbols static if they're not exported.
4535 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4536 * lisp.h (backtrace_list): Remove decl.
4537
4538 * emacs.c: Make symbols static if they're not exported.
4539 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4540 (fatal_error_code, fatal_error_signal_hook, standard_args):
4541 Now static.
4542 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4543 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4544 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4545 * lisp.h (fatal_error_signal_hook): Remove decl.
4546 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4547
4548 * editfns.c: Move a (normally-unused) function to its only use.
4549 * editfns.c, lisp.h (get_operating_system_release): Remove.
4550 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4551 worth the hassle of breaking this out.
4552
4553 * xterm.c: Make symbols static if they're not exported.
4554 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4555 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4556 (x_destroy_window, x_delete_display):
4557 Now static.
4558 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4559 (x_mouse_leave): Remove; unused.
4560 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4561 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4562 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4563 Remove decls.
4564 (x_mouse_leave): Declare only if WINDOWSNT.
4565 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4566 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4567 USE_X_TOOLKIT.
4568
4569 * ftxfont.c: Make symbols static if they're not exported.
4570 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4571 HAVE_FREETYPE.
4572 * font.h (ftxfont_driver): Likewise.
4573
4574 * xfns.c: Make symbols static if they're not exported.
4575 (x_last_font_name, x_display_info_for_name):
4576 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4577 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4578 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4579 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4580 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4581 (last_show_tip_args): Now static.
4582 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4583 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4584 (x_screen_planes): Remove; unused.
4585 * dispextern.h (x_screen_planes): Remove decl.
4586
4587 * dispnew.c: Make symbols static if they're not exported.
4588 * dispextern.h (redraw_garbaged_frames, scrolling):
4589 (increment_row_positions): Remove.
4590 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4591 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4592 Now static.
4593 (redraw_garbaged_frames): Remove; unused.
4594
4595 * xfaces.c: Make symbols static if they're not exported.
4596 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4597 Remove decls.
4598 * xterm.h (defined_color): Remove decls.
4599 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4600 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4601 (menu_face_changed_default, defined_color, free_realized_face):
4602 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4603 (ascii_face_of_lisp_face): Remove; unused.
4604
4605 * xdisp.c: Make symbols static if they're not exported.
4606 * dispextern.h (scratch_glyph_row, window_box_edges):
4607 (glyph_to_pixel_coords, set_cursor_from_row):
4608 (get_next_display_element, set_iterator_to_next):
4609 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4610 (show_mouse_face): Remove decls
4611 * frame.h (message_buf_print): Likewise.
4612 * lisp.h (pop_message, set_message, check_point_in_composition):
4613 Likewise.
4614 * xterm.h (set_vertical_scroll_bar): Likewise.
4615 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4616 (message_buf_print, scratch_glyph_row, displayed_buffer):
4617 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4618 (get_next_display_element, show_mouse_face, window_box_edges):
4619 (frame_to_window_pixel_xy, check_point_in_composition):
4620 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4621 (glyph_to_pixel_coords): Remove; unused.
4622
4623 * dired.c (file_name_completion): Now static.
4624
4625 * dbusbind.c (xd_in_read_queued_messages): Now static.
4626
4627 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4628 * data.c (circular_list_error): Remove.
4629
4630 * commands.h (last_point_position, last_point_position_buffer):
4631 (last_point_position_window): Remove decls.
4632 * keyboard.c: Make these variables static.
4633
4634 * coding.h (coding, code_convert_region, encode_coding_gap):
4635 Remove decls.
4636 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4637 (iso_code_class, detect_coding, code_convert_region): Now static.
4638 (encode_coding_gap): Remove; unused.
4639
4640 * chartab.c (chartab_chars, chartab_bits): Now static.
4641
4642 * charset.h (charset_iso_8859_1): Remove decl.
4643 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4644 Now static.
4645
4646 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4647 * ccl.c (Vccl_program_table): Now static.
4648 (check_ccl_update): Remove; unused.
4649
4650 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4651 * category.h: ... from here.
4652 * category.c (check_category_table, set_category_set): Now static.
4653
4654 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4655 * lisp.h: Remove these decls.
4656
4657 * buffer.c (buffer_count): Remove unused var.
4658
4659 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4660 so that it's not optimized away.
4661 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4662 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4663 exported only to the debugger.
4664
4665 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4666 * atimer.h (run_all_atimers): Remove; not exported.
4667
4668 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4669 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4670 was inaccessible from Lisp.
4671 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4672 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4673
4674 alloc.c: Import and export fewer symbols, and remove unused items.
4675 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4676 is defined.
4677 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4678 it's not optimized away by whole-program optimization.
4679 (message_enable_multibyte, free_misc): Remove.
4680 (catchlist, handlerlist, mark_backtrace):
4681 Declare only if BYTE_MARK_STACK.
4682 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4683 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4684 (message_enable_multibyte): Remove decl.
4685 (free_misc, interval_free_list, float_block, float_block_index):
4686 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4687 (cons_free_list, last_marked_index):
4688 Now static.
4689 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4690 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4691 (mark_backtrace): Define only if BYTE_MARK_STACK.
4692 * xdisp.c (message_enable_multibyte): Now static.
4693
4694 Declare Lisp_Object Q* variables to be 'static' if not exported.
4695 This makes it easier for human readers (and static analyzers)
4696 to see whether these variables are used from other modules.
4697 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4698 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4699 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4700 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4701 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4702 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4703 * xmenu.c, xselect.c:
4704 Declare Q* vars static if they are not used in other modules.
4705 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4706 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4707 Remove decls of unexported vars.
4708 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4709
4710 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4711
4712 Make Emacs functions such as Fatom 'static' by default.
4713 This makes it easier for human readers (and static analyzers)
4714 to see whether these functions can be called from other modules.
4715 DEFUN now defines a static function. To make the function external
4716 so that it can be used in other C modules, use the new macro DEFUE.
4717 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4718 (Finit_image_library):
4719 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4720 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4721 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4722 Remove decls, since these functions are now static.
4723 (Funintern, Fget_internal_run_time): New decls, since these functions
4724 were already external.
4725
4726 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4727 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4728 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4729 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4730 * keyboard.c, keymap.c, lread.c:
4731 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4732 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4733 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4734 Mark functions with DEFUE instead of DEFUN,
4735 if they are used in other modules.
4736 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4737 decls for now-static functions.
4738 * buffer.h (Fdelete_overlay): Remove decl.
4739 * callproc.c (Fgetenv_internal): Mark as internal.
4740 * composite.c (Fremove_list_of_text_properties): Remove decl.
4741 (Fcomposition_get_gstring): New forward static decl.
4742 * composite.h (Fcomposite_get_gstring): Remove decl.
4743 * dired.c (Ffile_attributes): New forward static decl.
4744 * doc.c (Fdocumntation_property): New forward static decl.
4745 * eval.c (Ffetch_bytecode): New forward static decl.
4746 (Funintern): Remove extern decl; now in .h file where it belongs.
4747 * fileio.c (Fmake_symbolic_link): New forward static decl.
4748 * image.c (Finit_image_library): New forward static decl.
4749 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4750 * intervals.h (Fprevious_property_change):
4751 (Fremove_list_of_text_properties): Remove decls.
4752 * keyboard.c (Fthis_command_keys): Remove decl.
4753 (Fcommand_execute): New forward static decl.
4754 * keymap.c (Flookup_key): New forward static decl.
4755 (Fcopy_keymap): Now static.
4756 * keymap.h (Flookup_key): Remove decl.
4757 * process.c (Fget_process): New forward static decl.
4758 (Fprocess_datagram_address): Mark as internal.
4759 * syntax.c (Fsyntax_table_p): New forward static decl.
4760 (skip_chars): Remove duplicate decl.
4761 * textprop.c (Fprevious_property_change): New forward static decl.
4762 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4763 Now internal.
4764 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4765 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4766
4767 * editfns.c (Fformat): Remove unreachable code.
4768
4769 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4770
4771 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4772 change. (Bug#8496)
4773
4774 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4775
4776 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4777 when at ZV. (Bug#8487)
4778
4779 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4780
4781 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4782 (Bug#8437)
4783 * keyboard.c (parse_tool_bar_item): Likewise.
4784 * sound.c (sound_cleanup, alsa_close): Likewise.
4785 * termcap.c (tgetent): Likewise.
4786 * xfns.c (x_default_font_parameter): Likewise.
4787 * xsettings.c (read_and_apply_settings): Likewise.
4788
4789 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4790 (overrun_check_free): Protoize.
4791
4792 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4793
4794 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4795 since callers should never pass a negative size.
4796 Change the signature to match that of plain 'read' and 'write'; see
4797 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4798 * lisp.h: Update prototypes of emacs_write and emacs_read.
4799
4800 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4801
4802 * xdisp.c (redisplay_window): Don't try to determine the character
4803 position of the scroll margin if the window start point w->startp
4804 is outside the buffer's accessible region. (Bug#8468)
4805
4806 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4807
4808 Fix write-region and its subroutines for buffers > 2GB.
4809 * fileio.c (a_write, e_write): Modify declaration of arguments and
4810 local variables to support buffers larger than 2GB.
4811 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4812
4813 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4814 argument, local variables, and return value.
4815
4816 * lisp.h: Update prototypes of emacs_write and emacs_read.
4817
4818 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4819
4820 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4821
4822 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4823
4824 Fix more problems found by GCC 4.6.0's static checks.
4825
4826 * xdisp.c (vmessage): Use a better test for character truncation.
4827
4828 * charset.c (load_charset_map): <, not <=, for optimization,
4829 and to avoid potential problems with integer overflow.
4830 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4831 * casetab.c (set_identity, shuffle): Likewise.
4832 * editfns.c (Fformat): Likewise.
4833 * syntax.c (skip_chars): Likewise.
4834
4835 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4836 This also lets GCC 4.6.0 generate slightly better loop code.
4837
4838 * callint.c (Fcall_interactively): <, not <=, for optimization.
4839 (Fcall_interactively): Count the number of arguments produced,
4840 not the number of arguments given. This is simpler and lets GCC
4841 4.6.0 generate slightly better code.
4842
4843 * ftfont.c: Distingish more carefully between FcChar8 and char.
4844 The previous code passed unsigned char * to a functions like
4845 strlen and xstrcasecmp that expect char *, which does not
4846 conform to the C standard.
4847 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4848 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4849 char * when the C standard requires it.
4850
4851 * keyboard.c (read_char): Remove unused var.
4852
4853 * eval.c: Port to Windows vsnprintf (Bug#8435).
4854 Include <limits.h>.
4855 (SIZE_MAX): Define if the headers do not.
4856 (verror): Do not give up if vsnprintf returns a negative count.
4857 Instead, grow the buffer. This ports to Windows vsnprintf, which
4858 does not conform to C99. Problem reported by Eli Zaretskii.
4859 Also, simplify the allocation scheme, by avoiding the need for
4860 calling realloc, and removing the ALLOCATED variable.
4861
4862 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4863
4864 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4865 But keep the doprint source code for now, as we might revamp it
4866 and use it again (Bug#8435).
4867 * lisp.h (doprnt): Remove.
4868 * Makefile.in (base_obj): Remove doprnt.o.
4869 * deps.mk (doprnt.o): Remove.
4870
4871 error: Print 32- and 64-bit integers portably (Bug#8435).
4872 Without this change, on typical 64-bit hosts error ("...%d...", N)
4873 was used to print both 32- and 64-bit integers N, which relied on
4874 undefined behavior.
4875 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4876 New macro.
4877 * lisp.h (error, verror): Mark as printf-like functions.
4878 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4879 Report overflow in size calculations when allocating printf buffer.
4880 Do not truncate output string at its first null byte.
4881 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4882 Truncate the output at a character boundary, since vsnprintf does not
4883 do that.
4884 * charset.c (check_iso_charset_parameter): Convert internal
4885 character to string before calling 'error', since %c now has the
4886 printf meaning.
4887 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4888 overflow when computing char to be passed to 'error'. Do not
4889 pass Lisp_Object to 'error'; pass the integer instead.
4890 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4891 formatted with plain %d.
4892
4893 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4894
4895 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4896
4897 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4898
4899 * xterm.c (x_catch_errors): Remove duplicate declaration.
4900
4901 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4902
4903 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4904
4905 2011-04-10 Jim Meyering <meyering@redhat.com>
4906
4907 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4908 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4909 return ssize_t not "int", and use size_t as the buffer length.
4910 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4911 * gnutls.h: Update declarations.
4912 * process.c (read_process_output): Use ssize_t, to match.
4913 (send_process): Likewise.
4914
4915 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4916
4917 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4918
4919 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4920
4921 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4922 Use unsigned char, to match FcChar8 type definition.
4923
4924 * xterm.c (handle_one_xevent):
4925 * xmenu.c (create_and_show_popup_menu):
4926 * xselect.c (x_decline_selection_request)
4927 (x_reply_selection_request): Avoid type-punned deref of X events.
4928
4929 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4930
4931 Fix some uses of `int' instead of EMACS_INT.
4932 * search.c (string_match_1, fast_string_match)
4933 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4934 (scan_buffer, find_next_newline_no_quit)
4935 (find_before_next_newline, search_command, Freplace_match)
4936 (Fmatch_data): Make some `int' variables be EMACS_INT.
4937
4938 * xdisp.c (display_count_lines): 3rd argument and return value now
4939 EMACS_INT. All callers changed.
4940 (pint2hrstr): Last argument is now EMACS_INT.
4941
4942 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4943 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4944 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4945 (decode_coding_utf_16, decode_coding_emacs_mule)
4946 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4947 (decode_coding_ccl, decode_coding_charset)
4948 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4949 (decode_coding_iso_2022, decode_coding_emacs_mule)
4950 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4951 <char_offset, last_offset>: Declare EMACS_INT.
4952 (encode_coding_utf_8, encode_coding_utf_16)
4953 (encode_coding_emacs_mule, encode_invocation_designation)
4954 (encode_designation_at_bol, encode_coding_iso_2022)
4955 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4956 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4957 Declare EMACS_INT.
4958 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4959 (encode_invocation_designation): Last argument P_NCHARS is now
4960 EMACS_INT.
4961 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4962 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4963
4964 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4965 All users changed.
4966
4967 * ccl.c (Fccl_execute_on_string): Declare some variables
4968 EMACS_INT.
4969
4970 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4971
4972 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4973
4974 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4975
4976 * process.c (Fformat_network_address): Doc fix.
4977
4978 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4979
4980 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4981
4982 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4983
4984 * keyboard.c (read_char): Call Lisp function help-form-show,
4985 instead of using internal_with_output_to_temp_buffer.
4986 (Qhelp_form_show): New var.
4987 (syms_of_keyboard): Use DEFSYM macro.
4988
4989 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4990
4991 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4992
4993 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4994
4995 * process.c (Flist_processes): Remove to Lisp.
4996 (list_processes_1): Delete.
4997
4998 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4999
5000 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5001
5002 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5003
5004 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5005
5006 Fix more problems found by GCC 4.6.0's static checks.
5007
5008 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5009
5010 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5011
5012 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5013
5014 * xdisp.c (vmessage): Mark as a printf-like function.
5015
5016 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5017
5018 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5019
5020 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5021 printf-like functions.
5022 (tiff_load): Add casts to remove these marks before passing them
5023 to system-supplied API.
5024
5025 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5026
5027 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5028 This avoids several warnings with gcc -Wstrict-overflow.
5029 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5030 directly, rather than having caller test rule sign. This avoids
5031 some unnecessary tests.
5032 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5033 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5034 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5035
5036 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5037 (xfont_open): Avoid unnecessary tests.
5038
5039 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5040
5041 * composite.h, composite.c (composition_gstring_put_cache):
5042 Use EMACS_INT, not int, for length.
5043
5044 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5045 breaking out part of COMPOSITION_DECODE_RULE.
5046 (COMPOSITION_DECODE_RULE): Use it.
5047 * composite.c (get_composition_id): Remove unused local vars,
5048 by using the new macro.
5049
5050 * textprop.c (set_text_properties_1): Change while to do-while,
5051 since the condition is always true at first.
5052
5053 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5054 (interval_deletion_adjustment): Return unsigned value.
5055 All uses changed.
5056
5057 * process.c (list_processes_1, create_pty, read_process_output):
5058 (exec_sentinel): Remove vars that were set but not used.
5059 (create_pty): Remove unnecessary "volatile"s.
5060 (Fnetwork_interface_info): Avoid possibility of int overflow.
5061 (read_process_output): Do adaptive read buffering even if carryover.
5062 (read_process_output): Simplify nbytes computation if buffered.
5063
5064 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5065
5066 * syntax.c (scan_words): Remove var that was set but not used.
5067 (update_syntax_table): Use unsigned instead of int.
5068
5069 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5070 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5071 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5072
5073 * print.c (print_error_message): Avoid int overflow.
5074
5075 * font.c (font_list_entities): Redo for clarity,
5076 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5077
5078 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5079 (font_score): Avoid potential overflow in diff calculation.
5080
5081 * fns.c (substring_both): Remove var that is set but not used.
5082 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5083
5084 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5085
5086 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5087 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5088 can always succeed if overflow has undefined behavior.
5089
5090 * search.c (boyer_moore, wordify): Remove vars set but not used.
5091 (wordify): Omit three unnecessary tests.
5092
5093 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5094 All callers changed. This avoids the need for an unused var.
5095
5096 * casefiddle.c (casify_region): Remove var that is set but not used.
5097
5098 * dired.c (file_name_completion): Remove var that is set but not used.
5099
5100 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5101
5102 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5103 (Finsert_file_contents): Remove unnecessary code checking fd.
5104
5105 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5106 Check for integer overflow on size calculations.
5107
5108 * buffer.c (Fprevious_overlay_change): Remove var that is set
5109 but not used.
5110
5111 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5112 Remove vars that are set but not used.
5113 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5114 (timer_check_2): Mark vars as initialized.
5115
5116 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5117
5118 * image.c (lookup_image): Remove var that is set but not used.
5119 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5120
5121 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5122 that are set but not used.
5123
5124 * xfns.c (make_invisible_cursor): Don't return garbage
5125 if XCreateBitmapFromData fails (Bug#8410).
5126
5127 * xselect.c (x_get_local_selection, x_handle_property_notify):
5128 Remove vars that are set but not used.
5129
5130 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5131 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5132
5133 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5134 Remove var that is set but not used.
5135 (scroll_bar_windows_size): Now size_t, not int.
5136 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5137 Check for overflow.
5138
5139 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5140 (map_tty_color) [!defined MSDOS]: Likewise.
5141
5142 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5143
5144 * coding.c: Remove vars that are set but not used.
5145 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5146 All callers changed.
5147 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5148 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5149 (decode_coding_charset): Remove vars that are set but not used.
5150
5151 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5152 that is set but not used.
5153
5154 * print.c (print_object): Remove var that is set but not used.
5155
5156 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5157 The gnulib version avoids calling malloc in the usual case,
5158 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5159 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5160 * filelock.c (current_lock_owner): Likewise.
5161 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5162 * sysdep.c: Include allocator.h, careadlinkat.h.
5163 (emacs_no_realloc_allocator): New static constant.
5164 (emacs_readlink): New function.
5165 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5166 ../lib/careadlinkat.h.
5167
5168 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5169
5170 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5171 first non-nil return value).
5172
5173 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5174
5175 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5176 if not defined (Bug#8403).
5177
5178 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5179
5180 * xdisp.c (display_count_lines): Remove parameter `start',
5181 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5182 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5183 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5184 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5185 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5186 and thereabouts. All callers changed.
5187 (get_per_char_metric): Remove parameter `f', unused since
5188 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5189
5190 2011-04-02 Jim Meyering <meyering@redhat.com>
5191
5192 do not dereference NULL upon failed strdup
5193 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5194 (ns_get_family): Likewise.
5195
5196 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5197
5198 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5199
5200 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5201
5202 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5203 later (Bug#8403).
5204
5205 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5206
5207 Add lexical binding.
5208
5209 * window.c (Ftemp_output_buffer_show): New fun.
5210 (Fsave_window_excursion):
5211 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5212
5213 * lread.c (lisp_file_lexically_bound_p): New function.
5214 (Fload): Bind Qlexical_binding.
5215 (readevalloop): Remove `evalfun' arg.
5216 Bind Qinternal_interpreter_environment.
5217 (Feval_buffer): Bind Qlexical_binding.
5218 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5219 Mark as dynamic.
5220 (syms_of_lread): Declare `lexical-binding'.
5221
5222 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5223
5224 * keyboard.c (eval_dyn): New fun.
5225 (menu_item_eval_property): Use it.
5226
5227 * image.c (parse_image_spec): Use Ffunctionp.
5228
5229 * fns.c (concat, mapcar1): Accept byte-code-functions.
5230
5231 * eval.c (Fsetq): Handle lexical vars.
5232 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5233 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5234 (FletX, Flet): Obey lexical binding.
5235 (Fcommandp): Handle closures.
5236 (Feval): New `lexical' arg.
5237 (eval_sub): New function extracted from Feval. Use it almost
5238 everywhere where Feval was used. Look up vars in lexical env.
5239 Handle closures.
5240 (Ffunctionp): Move from subr.el.
5241 (Ffuncall): Handle closures.
5242 (apply_lambda): Remove `eval_flags'.
5243 (funcall_lambda): Handle closures and new byte-code-functions.
5244 (Fspecial_variable_p): New function.
5245 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5246 but without exporting it to Lisp.
5247
5248 * doc.c (Fdocumentation, store_function_docstring):
5249 * data.c (Finteractive_form): Handle closures.
5250
5251 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5252 interactive spec.
5253
5254 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5255 New byte-codes.
5256 (exec_byte_code): New function extracted from Fbyte_code to handle new
5257 calling convention for byte-code-functions. Add new byte-codes.
5258
5259 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5260
5261 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5262
5263 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5264
5265 * xdisp.c (redisplay_internal): Fix prototype.
5266
5267 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5268
5269 * xdisp.c (SCROLL_LIMIT): New macro.
5270 (try_scrolling): Use it when setting scroll_limit.
5271 Limit scrolling to 100 screen lines.
5272 (redisplay_window): Even when falling back on "recentering",
5273 position point in the window according to scroll-conservatively,
5274 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5275
5276 (try_scrolling): When point is above the window, allow searching
5277 as far as scroll_max, or one screenful, to compute vertical
5278 distance from PT to the scroll margin position. This prevents
5279 try_scrolling from unnecessarily failing when
5280 scroll-conservatively is set to a value slightly larger than the
5281 window height. Clean up the case of PT below the margin at bottom
5282 of window: scroll_max can no longer be INT_MAX. When aggressive
5283 scrolling is in use, don't let point enter the opposite scroll
5284 margin as result of the scroll.
5285 (syms_of_xdisp) <scroll-conservatively>: Document the
5286 threshold of 100 lines for never-recentering scrolling.
5287
5288 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5289
5290 * dispextern.h (move_it_by_lines):
5291 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5292 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5293 (message_log_check_duplicate): Remove parameters `prev_bol' and
5294 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5295 (redisplay_internal): Remove parameter `preserve_echo_area',
5296 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5297
5298 * indent.c (Fvertical_motion):
5299 * window.c (window_scroll_pixel_based, Frecenter):
5300 Don't pass `need_y_p' to `move_it_by_lines'.
5301
5302 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5303
5304 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5305 steal a few bits to be more compact.
5306 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5307 Remove unneeded casts.
5308
5309 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5310
5311 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5312
5313 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5314 binding" message (bug#7967).
5315
5316 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5317
5318 Fix more problems found by GCC 4.6.0's static checks.
5319
5320 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5321 Remove unused local var.
5322
5323 * editfns.c (Fmessage_box): Remove unused local var.
5324
5325 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5326 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5327 Omit unused local vars.
5328 * window.c (shrink_windows): Omit unused local var.
5329 * menu.c (digest_single_submenu): Omit unused local var.
5330 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5331 Omit unused local var.
5332
5333 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5334 Don't assume string length fits in int.
5335 (keyremap_step, read_key_sequence): Use size_t for sizes.
5336 (read_key_sequence): Don't check last_real_key_start redundantly.
5337
5338 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5339 instead of alloca (Bug#8344).
5340
5341 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5342 (Fbacktrace_frame): Don't assume nframes fits in int.
5343
5344 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5345
5346 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5347 concerns.
5348
5349 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5350
5351 * cm.c (calccost): Turn while-do into do-while, for clarity.
5352
5353 * keyboard.c (syms_of_keyboard): Use the same style as later
5354 in this function when indexing through an array. This also
5355 works around GCC bug 48267.
5356
5357 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5358
5359 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5360
5361 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5362 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5363
5364 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5365 This avoids undefined behavior on integer overflow, and is a bit
5366 more convenient anyway since it is compared to a size_t variable.
5367
5368 Variadic C functions now count arguments with size_t, not int.
5369 This avoids an unnecessary limitation on 64-bit machines, which
5370 caused (substring ...) to crash on large vectors (Bug#8344).
5371 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5372 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5373 All variadic functions and their callers changed accordingly.
5374 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5375 * data.c (arith_driver, float_arith_driver): Likewise.
5376 * editfns.c (general_insert_function): Likewise.
5377 * eval.c (struct backtrace.nargs, interactive_p)
5378 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5379 (funcall_lambda, mark_backtrace): Likewise.
5380 * fns.c (concat): Likewise.
5381 * frame.c (x_set_frame_parameters): Likewise.
5382 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5383 0 if not found, not -1. All callers changed.
5384
5385 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5386 (stack_copy_size): Now size_t, not int.
5387 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5388
5389 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5390
5391 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5392 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5393 All callers changed.
5394
5395 * lisp.h (multibyte_char_to_unibyte):
5396 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5397 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5398 * character.h (CHAR_TO_BYTE8):
5399 * cmds.c (internal_self_insert):
5400 * editfns.c (general_insert_function):
5401 * keymap.c (push_key_description):
5402 * search.c (Freplace_match):
5403 * xdisp.c (message_dolog, set_message_1): All callers changed.
5404
5405 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5406
5407 * keyboard.c (safe_run_hook_funcall): New function.
5408 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5409 don't set the hook to nil, but remove the offending function instead.
5410 (Qcommand_hook_internal): Remove, unused.
5411 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5412 Vcommand_hook_internal.
5413
5414 * eval.c (enum run_hooks_condition): Remove.
5415 (funcall_nil, funcall_not): New functions.
5416 (run_hook_with_args): Call each function through a `funcall' argument.
5417 Remove `cond' argument, now redundant.
5418 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5419 (Frun_hook_with_args_until_failure): Adjust accordingly.
5420 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5421
5422 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5423
5424 * dispextern.h (string_buffer_position): Remove declaration.
5425
5426 * print.c (strout): Remove parameter `multibyte', unused since
5427 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5428
5429 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5430 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5431 All callers changed.
5432
5433 * w32.c (_wsa_errlist): Use braces for struct initializers.
5434
5435 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5436 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5437 All callers changed.
5438 (string_buffer_position): Likewise. Also, make static (it's never
5439 used outside xdisp.c).
5440 (cursor_row_p): Remove parameter `w', unused since
5441 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5442 (decode_mode_spec): Remove parameter `precision', introduced during
5443 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5444 All callers changed.
5445
5446 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5447
5448 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5449
5450 2011-03-27 Anders Lindgren <andlind@gmail.com>
5451
5452 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5453 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5454 (ns_update_auto_hide_menu_bar): New functions.
5455 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5456 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5457 ns_constrain_all_frames.
5458 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5459 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5460
5461 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5462
5463 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5464
5465 2011-03-27 Glenn Morris <rgm@gnu.org>
5466
5467 * syssignal.h: Replace RETSIGTYPE with void.
5468 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5469 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5470 Replace SIGTYPE with void everywhere.
5471 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5472 * s/template.h (SIGTYPE): Remove commented out definition.
5473
5474 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5475
5476 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5477 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5478
5479 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5480
5481 * w32.c (read_unc_volume): Use parameter `henum', instead of
5482 global variable `wget_enum_handle'.
5483
5484 * keymap.c (describe_vector): Remove parameters `indices' and
5485 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5486 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5487
5488 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5489
5490 * keyboard.c (timer_check): Remove parameter `do_it_now',
5491 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5492 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5493 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5494
5495 * keyboard.c (read_char):
5496 * w32menu.c (w32_menu_display_help):
5497 * xmenu.c (show_help_event, menu_help_callback):
5498 Adjust calls to `show_help_echo'.
5499
5500 * gtkutil.c (xg_maybe_add_timer):
5501 * keyboard.c (readable_events):
5502 * process.c (wait_reading_process_output):
5503 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5504
5505 * insdel.c (adjust_markers_gap_motion):
5506 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5507 (gap_left, gap_right): Don't call it.
5508
5509 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5510
5511 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5512 incurred during fontification.
5513
5514 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5515
5516 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5517 (DEFVAR_PER_BUFFER): Don't pass it.
5518
5519 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5520 (scrolling_window): Don't pass it.
5521
5522 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5523
5524 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5525
5526 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5527 and `suffix'.
5528 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5529 of variables specific to SELinux and computation of `encoded_absname'.
5530
5531 * image.c (XPutPixel): Remove unused variable `height'.
5532
5533 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5534
5535 * unexw32.c (get_section_info): Remove unused variable `section'.
5536
5537 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5538 (system_process_attributes): Remove unused variable `sess'.
5539 (sys_read): Remove unused variable `err'.
5540
5541 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5542 (w32_wnd_proc): Remove unused variable `isdead'.
5543 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5544 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5545 (x_create_tip_frame): Remove unused variable `tem'.
5546
5547 * w32inevt.c (w32_console_read_socket):
5548 Remove unused variable `no_events'.
5549
5550 * w32term.c (x_draw_composite_glyph_string_foreground):
5551 Remove unused variable `width'.
5552
5553 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5554
5555 * w32term.c (x_set_glyph_string_clipping):
5556 Don't pass uninitialized region to CombineRgn.
5557
5558 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5559
5560 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5561 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5562 (Fx_close_connection): Remove unused variable `i'.
5563
5564 * w32font.c (w32font_draw): Return number of glyphs.
5565 (w32font_open_internal): Remove unused variable `i'.
5566 (w32font_driver): Add missing initializer.
5567
5568 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5569 (fill_in_menu): Remove unused variable `items_added'.
5570
5571 * w32term.c (last_mouse_press_frame): Remove static global variable.
5572 (w32_clip_to_row): Remove unused variable `f'.
5573 (x_delete_terminal): Remove unused variable `i'.
5574
5575 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5576 (NOTHING): Remove unused static global variable.
5577 (uniscribe_check_otf): Remove unused variable `table'.
5578 (uniscribe_font_driver): Add missing initializers.
5579
5580 2011-03-23 Julien Danjou <julien@danjou.info>
5581
5582 * term.c (Fsuspend_tty, Fresume_tty):
5583 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5584 * window.c (temp_output_buffer_show):
5585 * insdel.c (signal_before_change):
5586 * frame.c (Fhandle_switch_frame):
5587 * fileio.c (Fdo_auto_save):
5588 * emacs.c (Fkill_emacs):
5589 * editfns.c (save_excursion_restore):
5590 * cmds.c (internal_self_insert):
5591 * callint.c (Fcall_interactively):
5592 * buffer.c (Fkill_all_local_variables):
5593 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5594 Use Frun_hooks.
5595 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5596 unconditionnaly since it does the check itself.
5597
5598 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5599
5600 Fix more problems found by GCC 4.5.2's static checks.
5601
5602 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5603 the first time through the loop, since we know p0 < p1 then.
5604 This also avoids a gcc -Wstrict-overflow warning.
5605
5606 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5607 leading to a memory leak, possible in functions like
5608 load_charset_map_from_file that can allocate an unbounded number
5609 of objects (Bug#8318).
5610
5611 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5612 that could (at least in theory) be that large.
5613
5614 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5615 This is less likely to overflow, and avoids undefined behavior if
5616 overflow does occur. All callers changed. Use strtoul to scan
5617 for the unsigned long integer.
5618 (pint2hrstr): Simplify and tune code slightly.
5619 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5620
5621 * scroll.c (do_scrolling): Work around GCC bug 48228.
5622 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5623
5624 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5625 This also avoids a warning with gcc -Wstrict-overflow.
5626 (validate_x_resource_name): Simplify count usage.
5627 This also avoids a warning with gcc -Wstrict-overflow.
5628
5629 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5630 fail (Bug#8306).
5631
5632 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5633
5634 * process.c (Fmake_network_process): Use socklen_t, not int,
5635 where POSIX says socklen_t is required in portable programs.
5636 This fixes a porting bug on hosts like 64-bit HP-UX, where
5637 socklen_t is wider than int (Bug#8277).
5638 (Fmake_network_process, server_accept_connection):
5639 (wait_reading_process_output, read_process_output):
5640 Likewise.
5641
5642 * process.c: Rename or move locals to avoid shadowing.
5643 (list_processes_1, Fmake_network_process):
5644 (read_process_output_error_handler, exec_sentinel_error_handler):
5645 Rename or move locals.
5646 (Fmake_network_process): Define label "retry_connect" only if needed.
5647 (Fnetwork_interface_info): Fix pointer signedness.
5648 (process_send_signal): Add cast to avoid pointer signedness problem.
5649 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5650 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5651
5652 Make tparam.h and terminfo.c consistent.
5653 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5654 Include tparam.h instead, since it declares them.
5655 * cm.h (PC): Remove extern decl; tparam.h now does this.
5656 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5657 * terminfo.c: Include tparam.h, to check interfaces.
5658 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5659 (tparam): Adjust signature to match interface in tparam.h;
5660 this removes some undefined behavior. Check that outstring and len
5661 are zero, which they always are with Emacs.
5662 * tparam.h (PC, BC, UP): New extern decls.
5663
5664 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5665 (xftfont_open): Rename locals to avoid shadowing.
5666
5667 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5668 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5669 (OTF_TAG_SYM): Omit macro if not needed.
5670 (ftfont_list): Remove unused local.
5671 (get_adstyle_property, ftfont_pattern_entity):
5672 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5673 Rename locals to avoid shadowing.
5674
5675 * xfont.c (xfont_list_family): Mark var as initialized.
5676
5677 * xml.c (make_dom): Now static.
5678
5679 * composite.c (composition_compute_stop_pos): Rename local to
5680 avoid shadowing.
5681 (composition_reseat_it): Remove unused locals.
5682 (find_automatic_composition, composition_adjust_point): Likewise.
5683 (composition_update_it): Mark var as initialized.
5684 (find_automatic_composition): Mark vars as initialized,
5685 with a FIXME (Bug#8290).
5686
5687 character.h: Rename locals to avoid shadowing.
5688 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5689 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5690 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5691 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5692 to avoid shadowing.
5693
5694 * textprop.c (property_change_between_p): Remove; unused.
5695
5696 * intervals.c (interval_start_pos): Now static.
5697
5698 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5699
5700 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5701 Rename locals to avoid shadowing.
5702
5703 * sound.c (wav_play, au_play, Fplay_sound_internal):
5704 Fix pointer signedness.
5705 (alsa_choose_format): Remove unused local var.
5706 (wav_play): Initialize a variable to 0, to prevent undefined
5707 behavior (Bug#8278).
5708
5709 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5710
5711 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5712
5713 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5714 clobbering (Bug#8298).
5715 * sysdep.c (sys_subshell): Likewise.
5716 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5717
5718 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5719 This should get cleaned up, so that child_setup has the
5720 same signature on all platforms.
5721
5722 * callproc.c (call_process_cleanup): Now static.
5723 (relocate_fd): Rename locals to avoid shadowing.
5724
5725 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5726
5727 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5728 not to be necessary, and produces flickering.
5729
5730 2011-03-20 Glenn Morris <rgm@gnu.org>
5731
5732 * config.in: Remove file.
5733
5734 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5735
5736 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5737 are now in src/globals.h.
5738 (syms_of_minibuf): Remove spurious & from previous change.
5739
5740 2011-03-20 Leo <sdl.web@gmail.com>
5741
5742 * minibuf.c (completing-read-function): New variable.
5743 (completing-read-default): Rename from completing-read.
5744 (completing-read): Call completing-read-function.
5745
5746 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5747
5748 * xfaces.c (Fx_load_color_file):
5749 Read color file from absolute filename (bug#8250).
5750
5751 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5752
5753 * makefile.w32-in: Update dependencies.
5754
5755 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5756
5757 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5758
5759 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5760
5761 Fix more problems found by GCC 4.5.2's static checks.
5762
5763 * process.c (make_serial_process_unwind, send_process_trap):
5764 (sigchld_handler): Now static.
5765
5766 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5767 That way, the code declares only the vars that it needs.
5768 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5769 * s/cygwin.h (PTY_ITERATION): Likewise.
5770 * s/darwin.h (PTY_ITERATION): Likewise.
5771 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5772
5773 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5774 * process.c (allocate_pty): Don't declare stb unless it's needed.
5775
5776 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5777 (CONSTANTLIM): Remove; unused.
5778 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5779 Define only if needed.
5780
5781 * unexelf.c (unexec): Name an expression,
5782 to avoid gcc -Wbad-function-cast warning.
5783 Use a different way to cause a compilation error if anyone uses
5784 n rather than nn, a way that does not involve shadowing.
5785 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5786
5787 * deps.mk (unexalpha.o): Remove; unused.
5788
5789 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5790 * unexec.h: New file.
5791 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5792 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5793 Depend on unexec.h.
5794 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5795 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5796 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5797 Change as necessary to match prototype in unexec.h.
5798
5799 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5800 shadowing.
5801 (back_comment, skip_chars): Mark vars as initialized.
5802
5803 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5804 Rename locals to avoid shadowing.
5805
5806 * lread.c (read1): Rewrite so as not to use empty "else".
5807 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5808
5809 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5810
5811 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5812 warning when compiling print.c.
5813
5814 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5815 instead of using an uninitialized var.
5816 (font_sort_entities): Mark var as initialized.
5817
5818 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5819
5820 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5821 pointers to constants.
5822 (font_parse_fcname): Remove unused vars.
5823 (font_delete_unmatched): Now static.
5824 (font_get_spec): Remove; unused.
5825 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5826 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5827 Rename or move locals to avoid shadowing.
5828
5829 * fns.c (require_nesting_list, require_unwind): Now static.
5830 (Ffillarray): Rename locals to avoid shadowing.
5831
5832 * floatfns.c (domain_error2): Define only if needed.
5833 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5834
5835 * alloc.c (mark_backtrace): Move decl from here ...
5836 * lisp.h: ... to here, so that it can be checked.
5837
5838 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5839 (Fdefvar): Rewrite so as not to use empty "else".
5840 (lisp_indirect_variable): Name an expression,
5841 to avoid gcc -Wbad-function-cast warning.
5842 (Fdefvar): Rename locals to avoid shadowing.
5843
5844 * callint.c (quotify_arg, quotify_args): Now static.
5845 (Fcall_interactively): Rename locals to avoid shadowing.
5846 Use const pointer when appropriate.
5847
5848 * lisp.h (get_system_name, get_operating_system_release):
5849 Move decls here, to check interfaces.
5850 * process.c (get_operating_system_release): Move decl to lisp.h.
5851 * xrdb.c (get_system_name): Likewise.
5852 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5853 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5854 some of which prompt warnings from gcc -Wbad-function-cast.
5855 (Fformat_time_string, Fencode_time, Finsert_char):
5856 (Ftranslate_region_internal, Fformat):
5857 Rename or remove local vars to avoid shadowing.
5858 (Ftranslate_region_internal): Mark var as initialized.
5859
5860 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5861 avoid shadowing.
5862
5863 * lisp.h (eassert): Check that the argument compiles, even if
5864 ENABLE_CHECKING is not defined.
5865
5866 * data.c (Findirect_variable): Name an expression, to avoid
5867 gcc -Wbad-function-cast warning.
5868 (default_value, arithcompare, arith_driver, arith_error): Now static.
5869 (store_symval_forwarding): Rename local to avoid shadowing.
5870 (Fmake_variable_buffer_local, Fmake_local_variable):
5871 Mark variables as initialized.
5872 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5873
5874 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5875 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5876 Rename locals to avoid shadowing.
5877 (mark_stack): Move local variables into the #ifdef region where
5878 they're used.
5879 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5880 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5881 needed otherwise.
5882 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5883 (GC_STRING_CHARS): Remove; not used.
5884 (Fmemory_limit): Cast sbrk's returned value to char *.
5885
5886 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5887 avoids undefined behavior in theory.
5888
5889 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5890
5891 Use functions, not macros, for up- and down-casing (Bug#8254).
5892 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5893 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5894 to use the following functions instead of these macros.
5895 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5896 EMACS_INT, since callers assume the returned value fits in int.
5897 (upcase1): Likewise, for UPCASE_TABLE.
5898 (uppercasep, lowercasep, upcase): New static inline functions.
5899 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5900 the race-condition problem in the old DOWNCASE.
5901
5902 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5903 Rename locals to avoid shadowing.
5904 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5905 (regex_compile, re_search_2, re_match_2_internal):
5906 Remove unused local vars.
5907 (FREE_VAR): Rewrite so as not to use empty "else",
5908 which gcc can warn about.
5909 (regex_compile, re_match_2_internal): Mark locals as initialized.
5910 (RETALLOC_IF): Define only if needed.
5911 (WORDCHAR_P): Likewise. This one is never needed, but is used
5912 only in a comment talking about a compiler bug, so put inside
5913 the #if 0 of that comment.
5914 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5915 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5916 Remove; unused.
5917
5918 * search.c (boyer_moore): Rename locals to avoid shadowing.
5919 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5920 (PREV_CHAR_BOUNDARY): Likewise.
5921
5922 * search.c (simple_search): Remove unused var.
5923
5924 * dired.c (compile_pattern): Move decl from here ...
5925 * lisp.h: ... to here, so that it can be checked.
5926 (struct re_registers): New forward decl.
5927
5928 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5929
5930 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5931 All uses changed.
5932 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5933 Rename locals to avoid shadowing.
5934 (Fvertical_motion): Mark locals as initialized.
5935
5936 * casefiddle.c (casify_object, casify_region): Now static.
5937 (casify_region): Mark local as initialized.
5938
5939 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5940
5941 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5942 New macros, so that the caller can use some names other than
5943 gcpro1, gcpro2, etc.
5944 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5945 of the new macros.
5946 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5947 argument, for consistency with GCPRO2_VAR, etc: it is now the
5948 prefix of the variable, not the variable itself. All uses
5949 changed.
5950 * dired.c (directory_files_internal, file_name_completion):
5951 Rename locals to avoid shadowing.
5952
5953 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5954 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5955 dired.c's scmp function, had undefined behavior.
5956 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5957 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5958 * buffer.h: ... to here, because these macros use current_buffer,
5959 and the new implementation with inline functions needs to have
5960 current_buffer in scope now, rather than later when the macros
5961 are used.
5962 (downcase, upcase1): New static inline functions.
5963 (DOWNCASE, UPCASE1): Reimplement using these functions.
5964 This avoids undefined behavior in expressions like
5965 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5966 from race conditions in accessing the global variables
5967 case_temp1 and case_temp2.
5968 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5969 * lisp.h (case_temp1, case_temp2): Remove their decls.
5970 * character.h (ASCII_CHAR_P): Move from here ...
5971 * lisp.h: ... to here, so that the inline functions mentioned
5972 above can use them.
5973
5974 * dired.c (directory_files_internal_unwind): Now static.
5975
5976 * fileio.c (file_name_as_directory, directory_file_name):
5977 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5978 Now static.
5979 (file_name_as_directory): Use const pointers when appropriate.
5980 (Fexpand_file_name): Likewise. In particular, newdir might
5981 point at constant storage, so make it a const pointer.
5982 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5983 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5984 signedness issues.
5985 (Fset_file_times, Finsert_file_contents, auto_save_error):
5986 Rename locals to avoid shadowing.
5987
5988 * minibuf.c (choose_minibuf_frame_1): Now static.
5989 (Ftry_completion, Fall_completions): Rename or remove locals
5990 to avoid shadowing.
5991
5992 * marker.c (bytepos_to_charpos): Remove; unused.
5993
5994 * lisp.h (verify_bytepos, count_markers): New decls,
5995 so that gcc does not warn that these functions aren't declared.
5996
5997 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5998 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5999 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6000 (copy_text): Remove unused local var.
6001
6002 * filelock.c (within_one_second): Now static.
6003 (lock_file_1): Rename local to avoid shadowing.
6004
6005 * buffer.c (fix_overlays_before): Mark locals as initialized.
6006 (fix_start_end_in_overlays): Likewise. This function should be
6007 simplified by using pointers-to-pointers, but that's a different
6008 matter.
6009 (switch_to_buffer_1): Now static.
6010 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6011 (report_overlay_modification): Rename locals to avoid shadowing.
6012
6013 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6014 Fix pointer signedness issue.
6015 (sys_subshell): Mark local as volatile if checking for lint,
6016 to suppress a gcc -Wclobbered warning that does not seem to be right.
6017 (MAXPATHLEN): Define only if needed.
6018
6019 * process.c (serial_open, serial_configure): Move decls from here ...
6020 * systty.h: ... to here, so that they can be checked.
6021
6022 * fns.c (get_random, seed_random): Move extern decls from here ...
6023 * lisp.h: ... to here, so that they can be checked.
6024
6025 * sysdep.c (reset_io): Now static.
6026 (wait_for_termination_signal): Remove; unused.
6027
6028 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6029 (copy_keymap_item, append_key, push_text_char_description):
6030 Now static.
6031 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6032 (DENSE_TABLE_SIZE): Remove; unused.
6033 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6034 (describe_map_tree):
6035 Rename locals to avoid shadowing.
6036
6037 * keyboard.c: Declare functions static if they are not used elsewhere.
6038 (echo_char, echo_dash, cmd_error, top_level_2):
6039 (poll_for_input, handle_async_input): Now static.
6040 (read_char, kbd_buffer_get_event, make_lispy_position):
6041 (make_lispy_event, make_lispy_movement, apply_modifiers):
6042 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6043 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6044 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6045 (read_key_sequence, read_char): Mark locals as initialized.
6046 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6047
6048 * keyboard.h (make_ctrl_char): New decl.
6049 (mark_kboards): Move decl here ...
6050 * alloc.c (mark_kboards): ... from here.
6051
6052 * lisp.h (force_auto_save_soon): New decl.
6053
6054 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6055 (DEFINE_DUMMY_FUNCTION): New macro.
6056 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6057 Use it.
6058 (main): Add casts to avoid warnings
6059 if GCC considers string literals to be constants.
6060
6061 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6062
6063 * dbusbind.c: Pointer signedness fixes.
6064 (xd_signature, xd_append_arg, xd_initialize):
6065 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6066 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6067 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6068 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6069
6070 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6071 if GCC considers string literals to be constants.
6072 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6073
6074 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6075
6076 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6077 (print_preprocess, print_object): New macro to fix last change.
6078
6079 * print.c (print_preprocess): Don't forget font objects.
6080
6081 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6082
6083 * emacs.c (USAGE3): Doc fixes.
6084
6085 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6086
6087 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6088 structure.
6089
6090 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6091
6092 * lisp.h (VWindow_system, Qfile_name_history):
6093 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6094 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6095 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6096
6097 * w32select.c: Don't #include "keyboard.h".
6098 (run_protected): Add extern declaration for waiting_for_input.
6099
6100 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6101 * w32console.c (detect_input_pending, read_input_pending)
6102 (encode_terminal_code):
6103 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6104 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6105 (w32_system_caret_y, Qfile_name_history):
6106 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6107 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6108 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6109 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6110 * w32proc.c (Qlocal, report_file_error):
6111 * w32term.c (Vwindow_system, updating_frame):
6112 * w32uniscribe.c (initialized, uniscribe_font_driver):
6113 Remove unneeded extern declarations.
6114
6115 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6116
6117 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6118
6119 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6120
6121 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6122 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6123 These macros can no longer be used for assignment.
6124
6125 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6126 Assign struct members directly, instead of using BUF_BEGV etc.
6127 (record_buffer_markers, fetch_buffer_markers): New functions for
6128 recording and fetching special buffer markers.
6129 (set_buffer_internal_1, set_buffer_temp): Use them.
6130
6131 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6132
6133 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6134
6135 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6136 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6137
6138 * xdisp.c (hscroll_window_tree):
6139 (reconsider_clip_changes): Use PT instead of BUF_PT.
6140
6141 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6142
6143 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6144 $(EMACS_ROOT)/lib/intprops.h.
6145
6146 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6147
6148 Fix more problems found by GCC 4.5.2's static checks.
6149
6150 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6151 to unsigned char * to avoid compiler diagnostic.
6152 (xg_free_frame_widgets): Make it clear that a local variable is
6153 needed only if USE_GTK_TOOLTIP.
6154 (gdk_window_get_screen): Make it clear that this macro is needed
6155 only if USE_GTK_TOOLTIP.
6156 (int_gtk_range_get_value): New function, which avoids a diagnostic
6157 from gcc -Wbad-function-cast.
6158 (xg_set_toolkit_scroll_bar_thumb): Use it.
6159 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6160 diagnostic from gcc -Wbad-function-cast.
6161 (get_utf8_string, xg_get_file_with_chooser):
6162 Rename locals to avoid shadowing.
6163 (create_dialog): Move locals to avoid shadowing.
6164
6165 * xgselect.c (xg_select): Remove unused var.
6166
6167 * image.c (four_corners_best): Mark locals as initialized.
6168 (gif_load): Initialize transparent_p to zero (Bug#8238).
6169 Mark another local as initialized.
6170 (my_png_error, my_error_exit): Mark with NO_RETURN.
6171
6172 * image.c (clear_image_cache): Now static.
6173 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6174 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6175 (x_edge_detection): Remove unnecessary cast that
6176 gcc -Wbad-function-cast diagnoses.
6177 (gif_load): Fix pointer signedness.
6178 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6179 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6180
6181 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6182
6183 Improve quality of tests for time stamp overflow.
6184 For example, without this patch (encode-time 0 0 0 1 1
6185 1152921504606846976) returns the obviously-bogus value (-948597
6186 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6187 reports time overflow. See
6188 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6189 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6190 * editfns.c: Include limits.h and intprops.h.
6191 (TIME_T_MIN, TIME_T_MAX): New macros.
6192 (time_overflow): Move earlier, to before first use.
6193 (hi_time, lo_time): New functions, for an accurate test for
6194 out-of-range times.
6195 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6196 (Fget_internal_run_time): Don't assume time_t fits in int.
6197 (make_time): Use list2 instead of Fcons twice.
6198 (Fdecode_time): More accurate test for out-of-range times.
6199 (check_tm_member): New function.
6200 (Fencode_time): Use it, to test for out-of-range times.
6201 (lisp_time_argument): Don't rely on undefined left-shift and
6202 right-shift behavior when checking for time stamp overflow.
6203
6204 * editfns.c (time_overflow): New function, refactoring common code.
6205 (Fformat_time_string, Fdecode_time, Fencode_time):
6206 (Fcurrent_time_string): Use it.
6207
6208 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6209 * dired.c (make_time): Move to ...
6210 * editfns.c (make_time): ... here.
6211 * systime.h: Note the move.
6212
6213 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6214
6215 * fringe.c (update_window_fringes): Remove unused variables.
6216
6217 * unexmacosx.c (copy_data_segment): Also copy __got section.
6218 (Bug#8223)
6219
6220 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6221
6222 * termcap.c [MSDOS]: Include "msdos.h".
6223 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6224 Constify `char *' arguments and their references according to
6225 prototypes in tparam.h.
6226
6227 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6228
6229 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6230 Adapt all references accordingly.
6231
6232 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6233
6234 2011-03-11 Tom Tromey <tromey@redhat.com>
6235
6236 * buffer.c (syms_of_buffer): Remove obsolete comment.
6237
6238 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6239
6240 * termhooks.h (encode_terminal_code): Declare prototype.
6241
6242 * msdos.c (encode_terminal_code): Don't declare prototype.
6243
6244 * term.c (encode_terminal_code): Now external again, used by
6245 w32console.c and msdos.c.
6246
6247 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6248 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6249
6250 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6251
6252 Fix some minor problems found by GCC 4.5.2's static checks.
6253
6254 * fringe.c (update_window_fringes): Mark locals as initialized
6255 (Bug#8227).
6256 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6257
6258 * alloc.c (mark_fringe_data): Move decl from here ...
6259 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6260 to check its interface.
6261 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6262
6263 * fontset.c (free_realized_fontset): Now static.
6264 (Fset_fontset_font): Rename local to avoid shadowing.
6265 (fontset_font): Mark local as initialized.
6266 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6267
6268 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6269
6270 * xselect.c (x_disown_buffer_selections): Remove; not used.
6271 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6272 (x_own_selection, Fx_disown_selection_internal): Rename locals
6273 to avoid shadowing.
6274 (x_handle_dnd_message): Remove local to avoid shadowing.
6275
6276 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6277 so that the caller can use some name other than gcpro1.
6278 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6279 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6280 (Fx_backspace_delete_keys_p):
6281 Use them to avoid shadowing, and rename vars to avoid shadowing.
6282 (x_decode_color, x_set_name, x_window): Now static.
6283 (Fx_create_frame): Add braces to silence GCC warning.
6284 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6285 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6286 Remove unused locals.
6287 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6288 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6289 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6290 macros.
6291
6292 * xterm.h (x_mouse_leave): New decl.
6293
6294 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6295 Remove unused functions.
6296 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6297 (x_calc_absolute_position): Now static.
6298 (XTread_socket): Don't define label "out" unless it's used.
6299 Don't declare local "event" unless it's used.
6300 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6301 unless they are used.
6302 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6303 (x_fatal_error_signal): Remove; not used.
6304 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6305 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6306 (x_error_catcher, x_connection_closed, x_error_handler):
6307 (x_error_quitter, xembed_send_message, x_iconify_frame):
6308 (my_log_handler): Rename locals to avoid shadowing.
6309 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6310 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6311
6312 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6313 Rename or move locals to avoid shadowing.
6314 (tty_defined_color, merge_face_heights): Now static.
6315 (free_realized_faces_for_fontset): Remove; not used.
6316 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6317 does not deduce is never used uninitialized.
6318 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6319 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6320
6321 * terminal.c (store_terminal_param): Now static.
6322
6323 * xmenu.c (menu_highlight_callback): Now static.
6324 (set_frame_menubar): Remove unused local.
6325 (xmenu_show): Rename parameter to avoid shadowing.
6326 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6327 since they might point to immutable storage.
6328 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6329 since it's unused otherwise.
6330
6331 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6332 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6333 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6334 avoids a gcc -Wuninitialized diagnostic.
6335 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6336 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6337 does not deduce are never used uninitialized.
6338
6339 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6340
6341 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6342 * window.c (window_loop, size_window):
6343 (run_window_configuration_change_hook, enlarge_window): Likewise.
6344
6345 * window.c (display_buffer): Now static.
6346 (size_window): Mark variables that gcc -Wuninitialized
6347 does not deduce are never used uninitialized.
6348 * window.h (check_all_windows): New decl, to forestall
6349 gcc -Wmissing-prototypes diagnostic.
6350 * dispextern.h (bidi_dump_cached_states): Likewise.
6351
6352 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6353 shadowing.
6354 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6355 Include <limits.h>.
6356 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6357 and to avoid gcc -Wuninitialized warning.
6358 (load_charset_map): Mark variables that gcc -Wuninitialized
6359 does not deduce are never used uninitialized.
6360 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6361
6362 * coding.c (coding_set_source, coding_set_destination):
6363 Use "else { /* comment */ }" rather than "else /* comment */;"
6364 for clarity, and to avoid gcc -Wempty-body warning.
6365 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6366 a block, when the outer 'i' will do.
6367 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6368 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6369 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6370 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6371 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6372 Rename locals to avoid shadowing.
6373 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6374 * coding.c (emacs_mule_char, encode_invocation_designation):
6375 Now static, since they're not used elsewhere.
6376 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6377 (decode_coding_object, encode_coding_object, detect_coding_system):
6378 (decode_coding_emacs_mule): Mark variables that gcc
6379 -Wuninitialized does not deduce are never used uninitialized.
6380 (detect_coding_iso_2022): Initialize a local variable that might
6381 be used uninitialized. Leave a FIXME because it's not clear that
6382 this initialization is needed. (Bug#8211)
6383 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6384 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6385 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6386 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6387 Remove unused macros.
6388
6389 * category.c (hash_get_category_set): Remove unused local var.
6390 (copy_category_table): Now static, since it's not used elsewhere.
6391 * character.c (string_count_byte8): Likewise.
6392
6393 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6394 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6395
6396 * chartab.c (copy_sub_char_table): Now static, since it's not used
6397 elsewhere.
6398 (sub_char_table_ref_and_range, char_table_ref_and_range):
6399 Rename locals to avoid shadowing.
6400 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6401
6402 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6403 (BIDI_BOB): Remove unused macro.
6404
6405 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6406 deduce are never used uninitialized.
6407 * term.c (encode_terminal_code): Likewise.
6408
6409 * term.c (encode_terminal_code): Now static. Remove unused local.
6410
6411 * tparam.h: New file.
6412 * term.c, tparam.h: Include it.
6413 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6414 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6415 Move these decls to tparam.h, and make them agree with what
6416 is actually in tparam.c. The previous trick of using incompatible
6417 decls in different modules does not conform to the C standard.
6418 All callers of tparam changed to use tparam's actual API.
6419 * tparam.c (tparam1, tparam, tgoto):
6420 Use const pointers where appropriate.
6421
6422 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6423 * cm.h (struct cm): Likewise.
6424 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6425 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6426 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6427 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6428 (turn_on_face, init_tty): Likewise.
6429 * termchar.h (struct tty_display_info): Likewise.
6430
6431 * term.c (term_mouse_position): Rename local to avoid shadowing.
6432
6433 * alloc.c (mark_ttys): Move decl from here ...
6434 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6435
6436 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6437
6438 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6439
6440 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6441
6442 * search.c (compile_pattern_1): Remove argument regp, unused since
6443 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6444 (compile_pattern): Don't pass it.
6445
6446 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6447
6448 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6449 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6450 for ! HAVE_GTK3.
6451 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6452
6453 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6454
6455 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6456 gdk_window_get_screen, gdk_window_get_geometry,
6457 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6458 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6459 (xg_get_pixbuf_from_pixmap): New function.
6460 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6461 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6462 Call xg_get_pixbuf_from_pixmap instead of
6463 gdk_pixbuf_get_from_drawable.
6464 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6465 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6466 (xg_check_special_colors): Use GtkStyleContext and its functions
6467 for HAVE_GTK3.
6468 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6469 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6470 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6471 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6472 Call gtk_widget_get_preferred_size.
6473 (xg_frame_resized): gdk_window_get_geometry only takes 5
6474 parameters.
6475 (xg_win_to_widget, xg_event_is_for_menubar):
6476 Call gdk_x11_window_lookup_for_display.
6477 (xg_set_widget_bg): New function.
6478 (delete_cb): New function.
6479 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6480 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6481 (xg_set_background_color): Call xg_set_widget_bg.
6482 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6483 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6484 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6485 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6486 if ! HAVE_GTK3.
6487 (update_frame_tool_bar): Call gtk_widget_hide.
6488 (xg_initialize): Use GDK_KEY_g.
6489
6490 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6491 if ! HAVE_GTK3
6492 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6493
6494 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6495 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6496 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6497
6498 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6499
6500 * w32xfns.c (select_palette): Check success of RealizePalette against
6501 GDI_ERROR, not zero.
6502
6503 See ChangeLog.11 for earlier changes.
6504
6505 ;; Local Variables:
6506 ;; coding: utf-8
6507 ;; End:
6508
6509 Copyright (C) 2011 Free Software Foundation, Inc.
6510
6511 This file is part of GNU Emacs.
6512
6513 GNU Emacs is free software: you can redistribute it and/or modify
6514 it under the terms of the GNU General Public License as published by
6515 the Free Software Foundation, either version 3 of the License, or
6516 (at your option) any later version.
6517
6518 GNU Emacs is distributed in the hope that it will be useful,
6519 but WITHOUT ANY WARRANTY; without even the implied warranty of
6520 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6521 GNU General Public License for more details.
6522
6523 You should have received a copy of the GNU General Public License
6524 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.