1 2011-08-22 Kenichi Handa <handa@m17n.org>
3 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4 extra slot even if the purpose is char-code-property-table.
6 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
9 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
10 from an Org mode buffer to a Speedbar frame.
12 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
13 a composition, take its buffer position from IT->cmp_it.charpos.
14 Fixes cursor positioning at the beginning of a line that begins
15 with a composed character.
17 2011-08-18 Eli Zaretskii <eliz@gnu.org>
19 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
20 character bidirectional type, use STRONG_L instead. Fixes crashes
21 in a buffer produced by `describe-categories'.
23 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
24 members before the level stack, so they would be saved and
25 restored when copying iterator state. Fixes incorrect reordering
26 around TABs covered by display properties.
28 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
30 * process.c (Fnetwork_interface_list): Correctly determine buffer
33 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
35 * eval.c (internal_condition_case, internal_condition_case_1)
36 (internal_condition_case_2, internal_condition_case_n): Remove
37 unnecessary aborts (Bug#9081).
39 2011-08-17 Eli Zaretskii <eliz@gnu.org>
41 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
42 has no `load' handler, try opening the file locally. (Bug#9311)
44 2011-08-16 Ken Brown <kbrown@cornell.edu>
46 * gmalloc.c: Expand comment.
48 2011-08-16 Eli Zaretskii <eliz@gnu.org>
50 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
51 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
53 2011-08-16 Ken Brown <kbrown@cornell.edu>
55 Fix memory allocation problems in Cygwin build (Bug#9273).
57 * unexcw.c ( __malloc_initialized): Declare external variable.
58 (fixup_executable): Force the dumped emacs to reinitialize malloc.
60 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
62 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
64 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
66 [CYGWIN] (special_realloc): New function.
67 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
68 requests to realloc storage in the static heap.
70 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
72 * bidi.c (bidi_initialize): Remove unused local.
74 2011-08-15 Eli Zaretskii <eliz@gnu.org>
76 * biditype.h: File removed.
78 * bidimirror.h: File removed.
80 * deps.mk (bidi.o): Remove biditype.h and
83 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
86 * dispextern.h: Fix a typo in the comment to bidi_type_t.
88 * chartab.c: Improve commentary for the uniprop_table API.
90 * bidi.c (bidi_paragraph_init): Support zero value of
91 bidi_ignore_explicit_marks_for_paragraph_level.
92 (bidi_initialize): Use uniprop_table instead of including
93 biditype.h and bidimirror.h.
95 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
96 coordinates of the iterator when restoring from ppos_it.
99 2011-08-14 Kenichi Handa <handa@m17n.org>
101 * process.c (create_process): Call setup_process_coding_systems
102 after the pid of the process is set to -1 (Bug#8162).
104 2011-08-14 Eli Zaretskii <eliz@gnu.org>
106 * xdisp.c (move_it_in_display_line_to): Don't invoke
107 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
108 ppos_it. Fixes vertical cursor motion when line beginning is
109 covered by an image. (Bug#9296)
111 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
113 * nsterm.h (ns_run_ascript): Declare.
114 (NSAPP_DATA2_RUNASSCRIPT): Define.
116 * nsfns.m (as_script, as_result, as_status): New static variables.
117 (ns_run_ascript): New function.
118 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
119 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
120 the event loop. Get status from as_status (Bug#7276).
122 * nsterm.m (sendEvent): If event is NSApplicationDefined and
123 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
124 the event loop (Bug#7276).
126 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
128 * gnutls.c (QCgnutls_bootprop_priority)
129 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
130 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
131 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
132 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
133 (QCgnutls_bootprop_verify_hostname_error)
134 (QCgnutls_bootprop_callbacks_verify): Rename from
135 Qgnutls_bootprop_..., all uses changed.
137 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
140 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
142 * xfaces.c (Qframe_set_background_mode): Now static.
143 * dispextern.h (Qframe_set_background_mode): Remove decl.
145 * process.c (Fnetwork_interface_info): Declare local only if needed.
147 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
149 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
150 (Fnetwork_interface_list): Allocate in increments of bytes instead
151 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
152 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
154 (struct ifflag_def): notrailers is smart on OSX.
155 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
156 Get hardware address with getifaddrs if available.
158 2011-08-12 Eli Zaretskii <eliz@gnu.org>
160 * xdisp.c (iterate_out_of_display_property): xassert that
161 IT->position is set to within IT->object's boundaries. Break from
162 the loop as soon as EOB is reached; avoids infloops in redisplay
163 when IT->position is set up wrongly due to some bug. Set
164 IT->current to match the bidi iterator unconditionally.
165 (push_display_prop): Allow GET_FROM_STRING as IT->method on
166 entry. Force push_it to save on the stack the current
167 buffer/string position, to be restored by pop_it. Fix flags in
168 the iterator structure wrt the object coming from a display
169 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
170 properties. (Bug#9284)
172 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
174 * fontset.c (fontset_get_font_group): Add proper type checks.
177 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
179 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
180 and LC_VERSION_MIN_MACOSX.
181 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
182 (dump_it) [LC_FUNCTION_STARTS]: Use it.
184 2011-08-08 Eli Zaretskii <eliz@gnu.org>
186 * xdisp.c (forward_to_next_line_start): Allow to use the
187 no-display-properties-and-no-overlays under bidi display. Set
188 disp_pos in the bidi iterator to avoid searches for display
189 properties and overlays.
191 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
193 * editfns.c (Fset_time_zone_rule): Document relationship with the
196 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
197 the font entity extracted from the cache (Bug#8109).
199 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
201 * composite.c (autocmp_chars): Don't reset point. That is done by
202 restore_point_unwind (Bug#5984).
204 2011-08-07 Juri Linkov <juri@jurta.org>
206 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
207 to show the arg `TIME' instead of `TIMEVAL'.
209 2011-08-06 Eli Zaretskii <eliz@gnu.org>
211 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
212 display property strides EOL and includes a newline, as in
213 longlines-mode. (Bug#9254)
214 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
215 word-wrap under bidirectional display. (Bug#9224)
217 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
218 is non-zero, even if the data buffer is NULL. Fixes a crash in
219 vertical-motion with longlines-mode. (Bug#9254)
221 2011-08-05 Eli Zaretskii <eliz@gnu.org>
223 * bidi.c <bidi_cache_total_alloc>: Now static.
224 (bidi_initialize): Initialize bidi_cache_total_alloc.
226 *xdisp.c (display_line): Release buffer allocated for shelved bidi
229 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
230 amount allocated this far in `bidi_cache_total_alloc'.
231 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
232 non-zero, only free the data buffer without restoring the cache
233 contents. All callers changed.
235 * dispextern.h (bidi_unshelve_cache): Update prototype.
237 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
238 (move_it_in_display_line, move_it_to)
239 (move_it_vertically_backward, move_it_by_lines): Replace the call
240 to xfree to an equivalent call to bidi_unshelve_cache.
241 (move_it_in_display_line_to): Fix logic of returning
242 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
244 2011-08-05 Eli Zaretskii <eliz@gnu.org>
246 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
247 came from a string character with a `cursor' property. (Bug#9229)
249 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
251 * Makefile.in (LIB_PTHREAD): New variable.
252 (LIBES): Add LIB_PTHREAD (Bug#9216).
254 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
255 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
257 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
259 * regex.c (re_iswctype): Remove some redundant boolean
262 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
264 * xterm.c (x_find_topmost_parent): New function.
265 (x_set_frame_alpha): Find topmost parent window with
266 x_find_topmost_parent and set the property there also (bug#9181).
267 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
269 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
271 * callproc.c (Fcall_process): Avoid vfork clobbering
272 the local vars buffer, coding_systems, current_dir.
274 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
276 * keymap.c (Fmake_composed_keymap): Move to subr.el.
278 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
280 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
281 so that it is not optimized away.
283 * xdisp.c (compute_display_string_pos): Remove unused local.
285 2011-08-02 Eli Zaretskii <eliz@gnu.org>
287 Fix slow cursor motion and scrolling in large buffers with
288 selective display, like Org Mode buffers. (Bug#9218)
290 * dispextern.h (struct bidi_it): New member disp_prop_p.
292 * xdisp.c: Remove one-slot cache of display string positions.
293 (compute_display_string_pos): Accept an additional argument
294 DISP_PROP_P; callers changed. Scan at most 5K characters forward
295 for a display string or property. If found, set DISP_PROP_P
298 * bidi.c (bidi_fetch_char): Accept an additional argument
299 DISP_PROP_P, and pass it to compute_display_string_pos.
300 Only handle text covered by a display string if DISP_PROP_P is returned
301 non-zero. All callers of bidi_fetch_char changed.
303 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
305 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
307 2010-12-03 Don March <don@ohspite.net>
309 * keymap.c (Fdefine_key): Fix non-prefix key error message when
310 last character M-[char] is translated to ESC [char] (bug#7541).
312 2011-08-02 Kenichi Handa <handa@m17n.org>
314 * lisp.h (uniprop_table): Extern it.
316 * chartab.c (uniprop_table): Make it non-static.
318 2011-08-01 Eli Zaretskii <eliz@gnu.org>
320 * xdisp.c (forward_to_next_line_start): Accept additional argument
321 BIDI_IT_PREV, and store into it the state of the bidi iterator had
323 (reseat_at_next_visible_line_start): Use the bidi iterator state
324 returned by forward_to_next_line_start to restore the state of
325 it->bidi_it after backing up to previous newline. (Bug#9212)
327 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
329 * regex.c (re_comp): Protoize.
330 (re_exec): Fix return type.
331 (regexec): Fix type of `ret'. (Bug#9203)
333 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
335 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
336 This is needed if max-image-size is a floating-point number.
338 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
340 * print.c (print_object): Print empty symbol as ##.
342 * lread.c (read1): Read ## as empty symbol.
344 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
346 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
347 setting frame foreground color (Bug#9175).
348 (x_set_background_color): Likewise.
350 * nsmenu.m (-setText): Size tooltip dimensions precisely to
352 (EmacsTooltip -init): Remove bezels and add shadows to
355 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
356 or scroll bar (Bug#8470).
358 * nsfont.m (nsfont_open): Remove assignment to voffset and
359 unnecessary vars hshink, expand, hd, full_height, min_height.
360 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
362 * nsterm.h (nsfont_info): Remove voffset field.
364 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
366 Implement strike-through and overline on NextStep (Bug#8863).
368 * nsfont.m (nsfont_open): Use underline position provided by font,
369 instead of hard-coded value of 2.
370 (nsfont_draw): Call ns_draw_text_decoration instead.
372 * nsterm.h: Add declaration for ns_draw_text_decoration.
374 * nsterm.m (ns_draw_text_decoration): New function for drawing
375 underline, overline, and strike-through.
376 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
377 ns_draw_text_decoration. Change treatment of cursor drawing to
378 accomodate underlining, etc.
380 2011-07-28 Eli Zaretskii <eliz@gnu.org>
382 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
385 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
387 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
388 Without this fix, if a signal arrives just after memory fills up,
389 'malloc' might be invoked reentrantly.
391 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
392 In other words, assume that every image size is allowed, on non-X
393 hosts. This assumption is probably wrong, but it lets Emacs compile.
395 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
397 * regex.c (re_iswctype): Convert return values to boolean.
399 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
401 * xdisp.c (compute_display_string_pos): Don't use cached display
402 string position if the buffer had its restriction changed.
405 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
407 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
409 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
411 Integer signedness and overflow and related fixes. (Bug#9079)
413 * bidi.c: Integer size and overflow fixes.
414 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
415 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
416 (bidi_cache_find_level_change, bidi_cache_ensure_space)
417 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
418 (bidi_find_other_level_edge):
419 Use ptrdiff_t instead of EMACS_INT where either will do.
420 This works better on 32-bit hosts configured --with-wide-int.
421 (bidi_cache_ensure_space): Check for size-calculation overflow.
422 Use % rather than repeated addition, for better worst-case speed.
423 Don't set bidi_cache_size until after xrealloc returns, because it
425 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
426 (bidi_cache_ensure_space): Also check that the bidi cache size
427 does not exceed that of the largest Lisp string or buffer. See Eli
428 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
430 * alloc.c (__malloc_size_t): Remove.
431 All uses replaced by size_t. See Andreas Schwab's note
432 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
434 * image.c: Improve checking for integer overflow.
435 (check_image_size): Assume that f is nonnull, since
436 it is always nonnull in practice. This is one less thing to
437 worry about when checking for integer overflow later.
438 (x_check_image_size): New function, which checks for integer
439 overflow issues inside X.
440 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
441 This removes the need for a memory_full check.
442 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
443 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
444 (xbm_read_bitmap_data): Change locals back to 'int', since
445 their values must fit in 'int'.
446 (xpm_load_image, png_load, tiff_load):
447 Invoke x_create_x_image_and_pixmap earlier,
448 to avoid much needless work if the image is too large.
449 (tiff_load): Treat overly large images as if
450 x_create_x_image_and_pixmap failed, not as malloc failures.
451 (gs_load): Use x_check_image_size.
453 * gtkutil.c: Omit integer casts.
454 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
455 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
457 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
459 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
460 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
461 would wrongly return t on a 64-bit host.
463 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
464 The plain *_OVERFLOW macros run afoul of GCC bug 49705
465 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
466 and therefore cause GCC to emit a bogus diagnostic in some cases.
468 * image.c: Integer signedness and overflow and related fixes.
469 This is not an exhaustive set of fixes, but it's time to
470 record what I've got.
471 (lookup_pixel_color, check_image_size): Remove redundant decls.
472 (check_image_size): Don't assume that arbitrary EMACS_INT values
473 fit in 'int', or that arbitrary 'double' values fit in 'int'.
474 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
475 (tiff_load, imagemagick_load_image):
476 Check for overflow in size calculations.
477 (x_create_x_image_and_pixmap): Remove unnecessary test for
478 xmalloc returning NULL; that can't happen.
479 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
480 (xpm_color_bucket): Use better integer hashing function.
481 (xpm_cache_color): Don't possibly over-allocate memory.
482 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
484 Use ptrdiff_t, not int or size_t, to record sizes.
485 (png_load): Don't assume values greater than 2**31 fit in 'int'.
486 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
487 either works, as we prefer signed integers.
488 (tiff_read_from_memory, tiff_write_from_memory):
489 Return tsize_t, not size_t, since that's what the TIFF API wants.
490 (tiff_read_from_memory): Don't fail simply because the read would
491 go past EOF; instead, return a short read.
492 (tiff_load): Omit no-longer-needed casts.
493 (Fimagemagick_types): Don't assume size fits into 'int'.
495 Improve hashing quality when configured --with-wide-int.
496 * fns.c (hash_string): New function, taken from sxhash_string.
497 Do not discard information about ASCII character case; this
498 discarding is no longer needed.
499 (sxhash-string): Use it. Change sig to match it. Caller changed.
500 * lisp.h: Declare it.
501 * lread.c (hash_string): Remove, since we now use fns.c's version.
502 The fns.c version returns a wider integer if --with-wide-int is
503 specified, so this should help the quality of the hashing a bit.
505 * emacs.c: Integer overflow minor fix.
506 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
507 Define only if GNU_LINUX.
508 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
510 * dispnew.c: Integer signedness and overflow fixes.
511 Remove unnecessary forward decls, that were a maintenance hassle.
512 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
514 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
515 (scrolling_window): Use ptrdiff_t, not int, for byte count.
516 (prepare_desired_row, line_draw_cost):
517 Use int, not unsigned, where either works.
518 (save_current_matrix, restore_current_matrix):
519 Use ptrdiff_t, not size_t, where either works.
520 (init_display): Check for overflow more accurately, and without
521 relying on undefined behavior.
523 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
524 Remove, replacing with the new symbols in lisp.h. All uses changed.
525 * fileio.c (make_temp_name):
526 * filelock.c (lock_file_1, lock_file):
527 * xdisp.c (message_dolog):
528 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
529 Use pMd etc. instead.
530 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
531 replacing the pWIDE etc. symbols removed from editfns.c.
533 * keyboard.h (num_input_events): Now uintmax_t.
534 This is (very slightly) less likely to mess up due to wraparound.
537 * buffer.c: Integer signedness fixes.
538 (alloc_buffer_text, enlarge_buffer_text):
539 Use ptrdiff_t rather than size_t when either will do, as we prefer
542 * alloc.c: Integer signedness and overflow fixes.
543 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
544 (__malloc_size_t): Default to size_t, not to int.
545 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
546 (Fgarbage_collect, mark_object_loop_halt, mark_object):
547 Prefer ptrdiff_t to size_t when either would do, as we prefer
549 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
550 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
551 Now const. Initialize with values that are in range even if char
553 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
554 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
555 These functions do the right thing with sizes > 2**32.
556 (check_depth): Now ptrdiff_t, not int.
557 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
558 Adjust to new way of storing sizes. Check for size overflow bugs
560 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
561 slightly wrong anyway, as it missed one instance of
562 XMALLOC_OVERRUN_CHECK_OVERHEAD.
563 (refill_memory_reserve): Omit needless cast to size_t.
564 (mark_object_loop_halt): Mark as externally visible.
566 * xselect.c: Integer signedness and overflow fixes.
567 (Fx_register_dnd_atom, x_handle_dnd_message):
568 Use ptrdiff_t, not size_t, since we prefer signed.
569 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
570 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
571 x_dnd_atoms_size and x_dnd_atoms_length.
573 * doprnt.c: Prefer signed to unsigned when either works.
577 * xdisp.c (vmessage):
578 Use ptrdiff_t, not size_t, when using or implementing doprnt,
579 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
580 prefer signed arithmetic to avoid comparison confusion.
581 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
584 Assume freestanding C89 headers, string.h, stdlib.h.
585 * data.c, doprnt.c, floatfns.c, print.c:
586 Include float.h unconditionally.
587 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
588 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
589 * regex.c: Likewise for stddef.h, string.h.
590 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
591 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
592 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
593 (STDC_HEADERS): Remove obsolete defines.
594 * sysdep.c: Include limits.h unconditionally.
596 Assume support for memcmp, memcpy, memmove, memset.
597 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
598 * regex.c (memcmp, memcpy):
599 Remove; we assume C89 now.
601 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
602 (__malloc_safe_bcopy): Remove; no longer needed.
604 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
605 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
606 well either way, and we prefer signed to unsigned.
608 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
610 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
611 closes the connection while we're reading (bug#9182).
613 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
615 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
616 are specified (Bug#9168).
618 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
620 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
621 Found by GCC static checking and --with-wide-int on a 32-bit host.
623 2011-07-25 Eli Zaretskii <eliz@gnu.org>
625 * xdisp.c (compute_display_string_pos): Fix logic of caching
626 previous display string position. Initialize cached_prev_pos to
627 -1. Fixes slow-down at the beginning of a buffer.
629 2011-07-24 Eli Zaretskii <eliz@gnu.org>
631 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
632 for attrs[LFACE_FONTSET_INDEX].
634 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
636 * xml.c (parse_region): Remove unused local
637 that was recently introduced.
639 2011-07-23 Eli Zaretskii <eliz@gnu.org>
641 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
642 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
644 * xdisp.c (move_it_in_display_line_to): Record the best matching
645 position for TO_CHARPOS while scanning the line, and restore it on
646 exit if none of the characters scanned was an exact match.
647 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
648 when exact match is impossible due to invisible text, and the
651 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
653 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
656 2011-07-22 Eli Zaretskii <eliz@gnu.org>
658 Fix a significant slow-down of cursor motion with C-n, C-p,
659 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
660 auto-repeat under bidi redisplay in fontified buffers.
661 * xdisp.c (compute_stop_pos_backwards): New function.
662 (next_element_from_buffer): Call compute_stop_pos_backwards to
663 find a suitable prev_stop when we find ourselves before
665 (reseat): Don't look for prev_stop, as that could mean a very long
667 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
668 <cached_disp_overlay_modiff>: Cache for last found display string
670 (compute_display_string_pos): Return the cached position if asked
671 about the same buffer in the same area of character positions, and
672 the buffer wasn't changed since the time the display string
675 2011-07-22 Eli Zaretskii <eliz@gnu.org>
677 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
678 is an integer, which is important for empty lines. (Bug#9149)
680 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
682 * frame.c (Fmodify_frame_parameters): In tty case, update the
683 default face if necessary (Bug#4238).
685 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
687 * editfns.c (Fstring_to_char): No need to explain what a character
688 is in the docstring (Bug#6576).
690 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
692 * xml.c (parse_region): Make sure we always return a tree.
694 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
696 * xml.c (parse_region): If a document contains only comments,
699 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
701 * xml.c (make_dom): Return comments, too.
703 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
706 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
707 and the surrounding thread.
708 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
709 rather than fgets, and retry after EINTR. Otherwise, 'emacs
710 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
712 * s/openbsd.h (BROKEN_SIGIO): Define.
713 * unexelf.c (unexec) [__OpenBSD__]:
714 Don't update the .mdebug section of the Alpha COFF symbol table.
716 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
718 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
721 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
723 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
724 This fixes some race conditions on the permissions of any newly
727 * alloc.c (valid_pointer_p): Use pipe, not open.
728 This fixes some permissions issues when debugging.
730 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
731 If fchown fails to set both uid and gid, try to set just gid,
732 as that is sometimes allowed. Adjust the file's mode to eliminate
733 setuid or setgid bits that are inappropriate if fchown fails.
735 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
737 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
738 to compare Lisp_Objects.
739 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
740 global_gnutls_log_level, don't mistake it for a Lisp_Object.
741 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
743 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
745 * lread.c (read_integer): Unread even EOF character.
746 (read1): Likewise. Properly record start position of symbol.
748 * lread.c (read1): Read `#:' as empty uninterned symbol if no
749 symbol character follows.
751 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
753 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
754 This works around a problem with the previous change to Fcopy_file.
755 Recent glibc declares fchown with __attribute__((warn_unused_result)),
756 and without this change, GCC might complain about discarding
757 fchown's return value.
759 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
761 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
763 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
765 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
767 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
769 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
770 it's used from the C level.
772 * process.c: Use the same condition for POLL_FOR_INPUT in both
773 keyboard.c and process.c (bug#1858).
775 2011-07-09 Lawrence Mitchell <wence@gmx.li>
777 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
778 (Fgnutls_boot): Use it.
780 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
782 * doc.c (Fsubstitute_command_keys): Revert last change.
784 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
786 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
787 quotes the next character, and doesn't affect other longer
788 sequences (bug#8935).
790 * lread.c (syms_of_lread): Clarify that is isn't only
791 `eval-buffer' and `eval-defun' that's affected by
792 `lexical-binding' (bug#8460).
794 2011-07-15 Eli Zaretskii <eliz@gnu.org>
796 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
797 bidi redisplay when a line includes both an image and is
800 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
802 Fix minor problems found by static checking.
803 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
804 (elsz): Now a signed constant, not a size_t var. We prefer signed
805 types to unsigned, to avoid integer comparison confusion. Without
806 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
807 "cannot optimize loop, the loop counter may overflow", a symptom
809 * indent.c (Fvertical_motion): Mark locals as initialized.
810 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
812 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
814 * search.c (Fre_search_backward): Mention `case-fold-search' in
815 all the re_search_* functions (bug#8138).
817 * keyboard.c (Fopen_dribble_file): Document when the file is
820 2011-07-14 Eli Zaretskii <eliz@gnu.org>
822 * bidi.c (bidi_dump_cached_states): Fix format of displaying
825 Support bidi reordering of display and overlay strings.
826 * xdisp.c (compute_display_string_pos)
827 (compute_display_string_end): Accept additional argument STRING.
828 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
829 (reseat_to_string): Initialize bidi_it->string.s and
830 bidi_it->string.schars.
831 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
832 NULL (avoids a crash in bidi_paragraph_init).
833 Initialize itb.string.lstring.
834 (init_iterator): Call bidi_init_it only of a valid
835 buffer position was specified. Initialize paragraph_embedding to
837 (reseat_to_string): Initialize the bidi iterator.
838 (display_string): If we need to ignore text properties of
839 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
840 original value of -1 will not work with bidi.)
841 (compute_display_string_pos): First arg is now struct
842 `text_pos *'; all callers changed. Support display properties on
844 (compute_display_string_end): Support display properties on Lisp
846 (init_iterator, reseat_1, reseat_to_string): Initialize the
847 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
848 when iterating on a string not from display properties).
849 (compute_display_string_pos, compute_display_string_end):
850 Fix calculation of the object to scan. Fixes an error when using
852 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
853 base_level_stop; instead, set base_level_stop to BEGV.
854 Fixes crashes in vertical-motion.
855 (next_element_from_buffer): Improve commentary for when
856 the iterator is before prev_stop.
857 (init_iterator): Initialize bidi_p from the default value of
858 bidi-display-reordering, not from buffer-local value. Use the
859 buffer-local value only if initializing for buffer iteration.
860 (handle_invisible_prop): Support invisible properties on strings
861 that are being bidi-reordered.
862 (set_iterator_to_next): Support bidi reordering of C strings and
864 (next_element_from_string): Support bidi reordering of Lisp
866 (handle_stop_backwards): Support Lisp strings as well.
867 (display_string): Support display of R2L glyph rows.
868 Use IT_STRING_CHARPOS when displaying from a Lisp string.
869 (init_iterator): Don't initialize it->bidi_p for strings
871 (reseat_to_string): Initialize it->bidi_p for strings here.
872 (next_element_from_string, next_element_from_c_string)
873 (next_element_from_buffer): Add xassert's for correspondence
874 between IT's object being iterated and it->bidi_it.string
876 (face_before_or_after_it_pos): Support bidi iteration.
877 (next_element_from_c_string): Handle the case of the first string
878 character that is not the first one in the visual order.
879 (get_visually_first_element): New function, refactored from common
880 parts of next_element_from_buffer, next_element_from_string, and
881 next_element_from_c_string.
882 (tool_bar_lines_needed, redisplay_tool_bar)
883 (display_menu_bar): Force left-to-right direction. Add a FIXME
884 comment for making that be controlled by a user option.
885 (push_it, pop_it): Save and restore the state of the
886 bidi iterator. Save and restore the bidi_p flag.
887 (pop_it): Iterate out of display property for string iteration as
889 (iterate_out_of_display_property): Support iteration over strings.
890 (handle_single_display_spec): Set up it->bidi_it for iteration
891 over a display string, and call bidi_init_it.
892 (handle_single_display_spec, next_overlay_string)
893 (get_overlay_strings_1, push_display_prop): Set up the bidi
894 iterator for displaying display or overlay strings.
895 (forward_to_next_line_start): Don't use the shortcut if
897 (back_to_previous_visible_line_start): If handle_display_prop
898 pushed the iterator stack, restore the internal state of the bidi
899 iterator by calling bidi_pop_it same number of times.
900 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
901 and we are bidi-iterating, don't decrement the iterator position;
902 instead, set the first_elt flag in the bidi iterator, to produce
904 (reseat_1): Remove redundant setting of string_from_display_prop_p.
905 (push_display_prop): xassert that we are iterating a buffer.
906 (push_it, pop_it): Save and restore paragraph_embedding member.
907 (handle_single_display_spec, next_overlay_string)
908 (get_overlay_strings_1, reseat_1, reseat_to_string)
909 (push_display_prop): Set up the `unibyte' member of bidi_it.string
910 correctly. Don't assume unibyte strings are not bidi-reordered.
911 (compute_display_string_pos)
912 (compute_display_string_end): Fix handling the case of C string.
913 (push_it, pop_it): Save and restore from_disp_prop_p.
914 (handle_single_display_spec, push_display_prop): Set the
915 from_disp_prop_p flag.
916 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
917 (pop_it): Call iterate_out_of_display_property only if we are
918 popping after iteration over a string that came from a display
919 property. Fix a typo in popping stretch info. Add an assertion
920 for verifying that the iterator position is in sync with the bidi
922 (handle_single_display_spec, get_overlay_strings_1)
923 (push_display_prop): Fix initialization of paragraph direction for
924 string when that of the parent object is not yet determined.
925 (reseat_1): Call bidi_init_it to resync the bidi
926 iterator with IT's position. (Bug#7616)
927 (find_row_edges): If ROW->start.pos gives position
928 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
929 (handle_stop, back_to_previous_visible_line_start, reseat_1):
930 Reset the from_disp_prop_p flag.
931 (SAVE_IT, RESTORE_IT): New macros.
932 (pos_visible_p, face_before_or_after_it_pos)
933 (back_to_previous_visible_line_start)
934 (move_it_in_display_line_to, move_it_in_display_line)
935 (move_it_to, move_it_vertically_backward, move_it_by_lines)
936 (try_scrolling, redisplay_window, display_line): Use them when
937 saving a temporary copy of the iterator and restoring it back.
938 (back_to_previous_visible_line_start, reseat_1)
939 (init_iterator): Empty the bidi cache "stack".
940 (move_it_in_display_line_to): If iterator ended up at
941 EOL, but we never saw any buffer positions smaller than
942 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
943 motion in bidi-reordered lines.
944 (move_it_in_display_line_to): Record prev_method and prev_pos
945 immediately before the call to set_iterator_to_next. Fixes cursor
946 motion in bidi-reordered lines with stretch glyphs and strings
947 displayed in margins. (Bug#8133) (Bug#8867)
948 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
950 (pos_visible_p): Support positions in bidi-reordered lines.
951 Save and restore bidi cache.
953 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
954 (bidi_paragraph_info): Delete unused struct.
955 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
956 (bidi_cache_start): New variable.
957 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
959 (bidi_cache_fetch_state, bidi_cache_search)
960 (bidi_cache_find_level_change, bidi_cache_iterator_state)
961 (bidi_cache_find, bidi_peek_at_next_level)
962 (bidi_level_of_next_char, bidi_find_other_level_edge)
963 (bidi_move_to_visually_next): Compare cache index with
964 bidi_cache_start rather than with zero.
965 (bidi_fetch_char): Accept new argument STRING; all callers
966 changed. Support iteration over a string. Support strings with
967 display properties. Support unibyte strings. Fix the type of
968 `len' according to what STRING_CHAR_AND_LENGTH expects.
969 (bidi_paragraph_init, bidi_resolve_explicit_1)
970 (bidi_resolve_explicit, bidi_resolve_weak)
971 (bidi_level_of_next_char, bidi_move_to_visually_next):
972 Support iteration over a string.
973 (bidi_set_sor_type, bidi_resolve_explicit_1)
974 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
975 can now be zero (for strings); special values 0 and -1 were
976 changed to -1 and -2, respectively.
977 (bidi_char_at_pos): New function.
978 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
979 Call it instead of FETCH_MULTIBYTE_CHAR.
980 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
981 initialized to valid values.
982 (bidi_init_it): Don't initialize charpos and bytepos with invalid
984 (bidi_level_of_next_char): Allow the sentinel "position" to pass
985 the test for valid cached positions. Fix the logic for looking up
986 the sentinel state in the cache. GCPRO the Lisp string we are
988 (bidi_push_it, bidi_pop_it): New functions.
989 (bidi_initialize): Initialize the bidi cache start stack pointer.
990 (bidi_cache_ensure_space): New function, refactored from part of
991 bidi_cache_iterator_state. Don't assume the required size is just
992 one BIDI_CACHE_CHUNK away.
993 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
994 (bidi_count_bytes, bidi_char_at_pos): New functions.
995 (bidi_cache_search): Don't assume bidi_cache_last_idx is
996 always valid if bidi_cache_idx is valid.
997 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
998 is valid if it's going to be used.
999 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1000 (bidi_cache_fetch_state, bidi_cache_search)
1001 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1002 (bidi_cache_iterator_state, bidi_cache_find)
1003 (bidi_find_other_level_edge, bidi_cache_start_stack):
1004 All variables related to cache indices are now EMACS_INT.
1006 * dispextern.h (struct bidi_string_data): New structure.
1007 (struct bidi_it): New member `string'. Make flag members be 1-bit
1008 fields, and put them last in the struct.
1009 (compute_display_string_pos, compute_display_string_end):
1011 (bidi_push_it, bidi_pop_it): Add prototypes.
1012 (struct iterator_stack_entry): New members bidi_p,
1013 paragraph_embedding, and from_disp_prop_p.
1014 (struct it): Member bidi_p is now a bit field 1 bit wide.
1015 (bidi_shelve_cache, bidi_unshelve_cache):
1018 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1019 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1020 and vector-like objects.
1022 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1023 cache around display iteration.
1025 * window.c (Fwindow_end, window_scroll_pixel_based)
1026 (displayed_window_lines, Frecenter): Save and restore the bidi
1027 cache around display iteration.
1029 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1031 * editfns.c (Fdelete_region): Clarify the use of the named
1032 parameters (bug#6788).
1034 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1036 * indent.c (Fvertical_motion): Set and restore w->pointm when
1037 saving and restoring the window's buffer (Bug#9006).
1039 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1041 * editfns.c (Fstring_to_char): Clarify just what is returned
1042 (bug#6576). Text by Eli Zaretskii.
1044 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1046 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1048 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1050 * buffer.c (mmap_find): Fix a typo.
1052 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1054 Fix execution of x selection hooks.
1055 * xselect.c (Qx_lost_selection_functions)
1056 (Qx_sent_selection_functions): New vars.
1057 (syms_of_xselect): DEFSYM them.
1058 (x_handle_selection_request): Pass Qx_sent_selection_functions
1059 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1060 (x_handle_selection_clear,x_clear_frame_selections):
1061 Pass Qx_lost_selection_functions rather than
1062 Vx_lost_selection_functions to Frun_hook_with_args.
1064 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1066 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1067 The old code sometimes used this field without initializing it.
1069 * alloc.c (gc_sweep): Don't read past end of array.
1070 In theory, the old code could also have corrupted Emacs internals,
1071 though it'd be very unlikely.
1073 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1075 * character.c (Fcharacterp): Don't advertise optional ignored
1076 argument. (Bug#4026)
1078 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1080 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1083 * window.c (Fset_window_start): Doc fix (bug#4199).
1084 (Fset_window_hscroll): Ditto.
1086 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1088 Fix minor new problems caught by GCC 4.6.1.
1089 * term.c (init_tty): Remove unused local.
1090 * xsettings.c (store_monospaced_changed): Define this function only
1091 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1094 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1096 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1098 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1100 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1101 are the mini-buffer and the echo area (bug#3320).
1103 * term.c (init_tty): Remove support for supdup, c10 and perq
1104 terminals, which are no longer supported (bug#1482).
1106 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1108 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1110 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1112 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1113 for non-popups (Bug#3642).
1115 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1117 * alloc.c (reset_malloc_hooks): Protoize.
1118 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1119 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1120 * cm.c (losecursor): Likewise.
1121 * data.c (fmod): Likewise.
1122 * dispnew.c (swap_glyphs_in_rows): Likewise.
1123 * emacs.c (memory_warning_signal): Likewise.
1124 * floatfns.c (float_error): Likewise.
1125 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1126 (otf_open, font_otf_capability, generate_otf_features)
1127 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1129 * image.c (pbm_read_file): Likewise.
1130 * indent.c (string_display_width): Likewise.
1131 * intervals.c (check_for_interval, search_for_interval)
1132 (inc_interval_count, count_intervals, root_interval)
1133 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1134 * lread.c (defalias): Likewise.
1135 * ralloc.c (r_alloc_check): Likewise.
1136 * regex.c (set_image_of_range_1, set_image_of_range)
1137 (regex_grow_registers): Likewise.
1138 * sysdep.c (strerror): Likewise.
1139 * termcap.c (valid_filename_p, tprint, main): Likewise.
1140 * tparam.c (main): Likewise.
1141 * unexhp9k800.c (run_time_remap, save_data_space)
1142 (update_file_ptrs, read_header, write_header, calculate_checksum)
1143 (copy_file, copy_rest, display_header): Likewise.
1144 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1146 * xdisp.c (check_it): Likewise.
1147 * xfaces.c (register_color, unregister_color, unregister_colors):
1149 * xfns.c (print_fontset_result): Likewise.
1150 * xrdb.c (member, fatal, main): Likewise.
1152 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1154 Fix minor problems found by static checking (Bug#9031).
1155 * chartab.c (char_table_set_range, map_sub_char_table):
1156 Remove unused locals.
1157 (uniprop_table): Now static.
1158 * composite.c (_work_char): Remove unused static var.
1160 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1162 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1164 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1166 * gtkutil.c (qttip_cb): Remove code without function.
1168 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1170 * w32.c (pthread_sigmask): New stub.
1172 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1174 Use pthread_sigmask, not sigprocmask (Bug#9010).
1175 sigprocmask is portable only for single-threaded applications, and
1176 Emacs can be multi-threaded when it uses GTK.
1177 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1179 * callproc.c (Fcall_process):
1180 * process.c (create_process):
1181 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1182 Use pthread_sigmask, not sigprocmask.
1184 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1186 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1187 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1190 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1192 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1193 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1194 (xg_hide_tooltip): Fix comment.
1196 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1197 in registerServicesMenuSendTypes.
1198 (validRequestorForSendType): Don't check ns_return_types.
1200 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1203 2011-07-08 Jason Rumney <jasonr@gnu.org>
1205 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1206 frame struct members of non-existent frames (Bug#6284).
1208 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1210 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1211 variable firstTime not needed on OSX >= 10.6.
1212 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1213 >= 10.5. Use setKnobProportion, setDoubleValue.
1215 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1216 (MAC_OS_X_VERSION_10_5): Define if not defined.
1217 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1218 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1219 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1221 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1222 cString and lossyCString on OSX >= 10.4
1224 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1225 sizeToFit on OSX >= 10.2.
1227 * nsimage.m (allocInitFromFile): Don't use deprecated method
1228 bestRepresentationForDevice on OSX >= 10.6.
1230 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1233 * emacs.c: Declare unexec_init_emacs_zone.
1235 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1237 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1239 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1240 on svcsMenu (Bug#8842).
1242 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1244 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1246 * nsterm.m (QUTF8_STRING): Declare.
1247 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1248 (validRequestorForSendType): Return type is (id).
1249 Change indexOfObjectIdenticalTo to indexOfObject.
1250 Check if we have local selection before returning self (Bug#8842).
1251 (writeSelectionToPasteboard): Put local selection into paste board
1252 if we have a local selection (Bug#8842).
1253 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1255 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1256 (ns_get_local_selection): Declare.
1258 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1260 * keymap.c (describe_map_tree): Don't insert a double newline at
1261 the end of the buffer (bug#1169) and return whether we inserted
1264 * callint.c (Fcall_interactively): Change "reading args" to
1265 "providing args" to try to clarify what it does (bug#1010).
1267 2011-07-07 Kenichi Handa <handa@m17n.org>
1269 * composite.c (composition_compute_stop_pos): Ignore a static
1270 composition starting before CHARPOS (Bug#8915).
1272 * xdisp.c (handle_composition_prop): Likewise.
1274 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1276 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1279 2011-07-07 Kenichi Handa <handa@m17n.org>
1281 * character.h (unicode_category_t): New enum type.
1283 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1284 (Qchar_code_property_table): New variable.
1285 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1286 (UNIPROP_COMPRESSED_FORM_P): New macros.
1287 (char_table_ascii): Uncompress the compressed values.
1288 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1289 Uncompress the compressed values.
1290 (sub_char_table_ref_and_range): Likewise.
1291 (char_table_ref_and_range): Uncompress the compressed values.
1292 (sub_char_table_set): New arg is_uniprop. Callers changed.
1293 Uncompress the compressed values.
1294 (sub_char_table_set_range): Args changed. Callers changed.
1295 (char_table_set_range): Adjuted for the above change.
1296 (map_sub_char_table): Delete args default_val and parent. Add arg
1297 top. Give decoded values to a Lisp function.
1298 (map_char_table): Adjust for the above change. Give decoded
1299 values to a Lisp function. Gcpro more variables.
1300 (uniprop_table_uncompress)
1301 (uniprop_decode_value_run_length): New functions.
1302 (uniprop_decoder, uniprop_decoder_count): New variables.
1303 (uniprop_get_decoder, uniprop_encode_value_character)
1304 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1306 (uniprop_encoder, uniprop_encoder_count): New variables.
1307 (uniprop_get_encoder, uniprop_table)
1308 (Funicode_property_table_internal, Fget_unicode_property_internal)
1309 (Fput_unicode_property_internal): New functions.
1310 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1311 Sunicode_property_table_internal, Sget_unicode_property_internal,
1312 and Sput_unicode_property_internal. Defvar_lisp
1313 char-code-property-alist.
1315 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1316 Vunicode_category_table.
1318 * font.c (font_range): Adjust for the change of
1319 Vunicode_category_table.
1321 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1323 * m/iris4d.h: Remove file, move contents ...
1324 * s/irix6-5.h: ... here.
1326 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1328 Remove unportable assumption about struct layout (Bug#8884).
1329 * alloc.c (mark_buffer):
1330 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1331 (clone_per_buffer_values): Don't assume that
1332 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1333 This isn't true in general, and it's particularly not true
1334 if Emacs is configured with --with-wide-int.
1335 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1336 New macros, used in the buffer.c change.
1338 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1340 * xsettings.c: Use both GConf and GSettings if both are available.
1341 (store_config_changed_event): Add comment.
1342 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1343 (store_tool_bar_style_changed): New functions.
1344 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1345 (struct xsettings): Move font inside HAVE_XFT.
1346 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1347 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1348 Move inside HAVE_XFT.
1349 (something_changed_gsettingsCB): Rename from something_changedCB.
1350 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1352 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1353 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1354 (something_changed_gconfCB): Rename from something_changedCB.
1355 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1356 (parse_settings): Move check for font inside HAVE_XFT.
1357 (read_settings, apply_xft_settings): Add comment.
1358 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1359 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1360 call store_font_name_changed.
1361 (xft_settings_event): Add comment.
1362 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1363 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1364 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1365 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1366 (xsettings_initialize): Call init_gsettings last.
1367 (xsettings_get_system_font, xsettings_get_system_normal_font):
1370 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1372 Random fixes. E.g., (random) never returned negative values.
1373 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1374 subseconds part to the entropy, as that's a bit more random.
1375 Prefer signed to unsigned, since the signedness doesn't matter and
1376 in general we prefer signed. When given a limit, use a
1377 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1378 latter isn't right if USE_2_TAGS_FOR_INTS.
1379 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1380 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1382 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1384 * textprop.c (text_property_stickiness):
1385 Obey Vtext_property_default_nonsticky.
1386 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1387 * w32fns.c (syms_of_w32fns):
1388 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1390 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1392 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1393 This is more efficient than Ffile_directory_p and avoids a minor race.
1395 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1397 * buffer.c (Foverlay_put): Say what the return value is
1400 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1401 is a directory before asking whether to use the file name
1403 (barf_or_query_if_file_exists): Make the "File is a directory"
1404 error be more correct.
1406 * fns.c (Frequire): Remove the mention of the .gz files, since
1407 that's installation-specific, but keep the mention of
1408 `get-load-suffixes'.
1410 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1412 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1413 Report string overflow if the output is too long.
1415 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1417 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1418 (syms_of_gnutls): Remove duplicate DEFSYM for
1419 Qgnutls_bootprop_verify_hostname_error, an error for
1420 Qgnutls_bootprop_verify_error (which is no longer used).
1422 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1423 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1424 Also (re)move comments that are misplaced or no longer relevant.
1426 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1428 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1430 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1432 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1433 and background color parameters if they have been changed.
1435 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1437 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1439 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1441 * xsettings.c (SYSTEM_FONT): Define only when used.
1442 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1444 * keymap.c (access_keymap_1): Now static.
1446 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1448 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1449 leave any prefix arg for the up event (Bug#1586).
1451 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1453 * lread.c (syms_of_lread): Mention single symbols defined by
1454 `defvar' or `defconst' (bug#7154).
1456 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1457 (Frequire): Mention get-load-suffixes.
1459 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1461 * window.h (window): Remove clone_number slot.
1462 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1464 (make_parent_window, make_window, saved_window)
1465 (Fset_window_configuration, save_window_save): Don't deal with
1467 * buffer.c (Qclone_number): Remove declaration.
1468 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1470 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1472 Add multiple inheritance to keymaps.
1473 * keymap.c (Fmake_composed_keymap): New function.
1474 (Fset_keymap_parent): Simplify.
1475 (fix_submap_inheritance): Remove.
1476 (access_keymap_1): New function extracted from access_keymap to handle
1477 embedded parents and handle lists of maps.
1478 (access_keymap): Use it.
1479 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1480 (Fcopy_keymap): Handle embedded parents.
1481 (Fcommand_remapping, define_as_prefix): Simplify.
1482 (Fkey_binding): Simplify.
1483 (syms_of_keymap): Move minibuffer-local-completion-map,
1484 minibuffer-local-filename-completion-map,
1485 minibuffer-local-must-match-map, and
1486 minibuffer-local-filename-must-match-map to Elisp.
1487 (syms_of_keymap): Defsubr make-composed-keymap.
1488 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1489 (parse_menu_item): Trivial simplification.
1491 2011-07-01 Glenn Morris <rgm@gnu.org>
1493 * Makefile.in (SETTINGS_LIBS): Fix typo.
1495 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1497 * coding.c (Fencode_coding_string): Record the last coding system
1498 used, as the function doc string says (bug#8738).
1500 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1502 * xsettings.c (store_monospaced_changed): Take new font as arg and
1503 check for change against current_mono_font.
1504 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1505 (emacs_settings_constructor, emacs_settings_get_property)
1506 (emacs_settings_set_property, emacs_settings_class_init)
1507 (emacs_settings_init, gsettings_obj): Remove.
1508 (something_changedCB): New function for HAVE_GSETTINGS.
1509 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1510 with value as argument.
1511 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1512 g_settings_new (Bug#8967). Do not create gsettings_obj.
1513 Remove calls to g_settings_bind. Connect something_changedCB to
1516 * xgselect.c: Add defined (HAVE_GSETTINGS).
1517 (xgselect_initialize): Ditto.
1519 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1520 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1523 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1525 * eval.c (struct backtrace): Simplify and port the data structure.
1526 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1527 signed bit field, as this assumption is not portable and it makes
1528 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1529 "char debug_on_exit : 1" as this is not portable either; instead,
1530 use the portable "unsigned int debug_on_exit : 1". Remove unused
1531 member evalargs. Remove obsolete comments about cc bombing out.
1533 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1535 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1536 Let HAVE_GSETTINGS override HAVE_GCONF.
1537 (store_monospaced_changed): New function.
1538 (EMACS_SETTINGS): A new type derived from GObject to handle
1539 GSettings notifications.
1540 (emacs_settings_constructor, emacs_settings_get_property)
1541 (emacs_settings_set_property, emacs_settings_class_init):
1543 (gsettings_client, gsettings_obj): New variables.
1544 (GSETTINGS_SCHEMA): New define.
1545 (something_changedCB): Call store_monospaced_changed.
1546 (init_gsettings): New function.
1547 (xsettings_initialize): Call init_gsettings.
1548 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1551 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1554 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1556 * window.c (resize_root_window, grow_mini_window)
1557 (shrink_mini_window): Rename Qresize_root_window to
1558 Qwindow_resize_root_window and Qresize_root_window_vertically to
1559 Qwindow_resize_root_window_vertically.
1561 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1563 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1565 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1567 * makefile.w32-in: Redesign dependencies so they reflect more
1568 clearly which files are directly included by each source file,
1569 and not through other includes.
1571 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1573 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1574 (sort_overlays, overlay_strings): When an overlay's clone number
1575 matches the window's clone number process the overlay even if
1576 the overlay's window property doesn't match the current window.
1578 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1579 (Fwindow_hchild): Rename to Fwindow_left_child.
1580 (Fwindow_next): Rename to Fwindow_next_sibling.
1581 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1582 (resize_window_check): Rename to window_resize_check.
1583 (resize_window_apply): Rename to window_resize_apply.
1584 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1585 (Fdelete_other_windows_internal, resize_frame_windows)
1586 (Fsplit_window_internal, Fdelete_window_internal)
1587 (grow_mini_window, shrink_mini_window)
1588 (Fresize_mini_window_internal): Fix callers accordingly.
1590 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1592 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1593 (emacs_fixed_set_min_size): Remove.
1594 (emacs_fixed_new): Take frame as argument.
1596 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1597 (_EmacsFixedPrivate): Remove minwidth/height.
1598 Add struct frame *f.
1599 (emacs_fixed_init): Initialize priv->f.
1600 (get_parent_class, emacs_fixed_set_min_size): Remove.
1601 (emacs_fixed_new): Set priv->f to argument.
1602 (emacs_fixed_get_preferred_width)
1603 (emacs_fixed_get_preferred_height): Use min_width/height from
1604 frames size_hint to set minimum and natural (Bug#8919).
1605 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1606 and use min_width/height from frames size_hint to set
1607 min_width/height (Bug#8919).
1609 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1610 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1613 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1615 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1616 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1619 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1621 * process.c (wait_reading_process_output): Bypass select if
1622 waiting for a cell while ignoring keyboard input, and input is
1623 pending. Suggested by Jan Djärv (Bug#8869).
1625 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1627 Use gnulib's dup2 module instead of rolling our own.
1628 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1630 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1632 * dispnew.c (scrolling_window): Before scrolling, turn off a
1633 mouse-highlight in the window being scrolled.
1635 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1637 Move DEFSYM to lisp.h and use everywhere.
1639 * character.h (DEFSYM): Move declaration...
1640 * lisp.h (DEFSYM): ...here.
1646 * w32select.c: Don't include character.h.
1648 * alloc.c (syms_of_alloc):
1649 * buffer.c (syms_of_buffer):
1650 * bytecode.c (syms_of_bytecode):
1651 * callint.c (syms_of_callint):
1652 * casefiddle.c (syms_of_casefiddle):
1653 * casetab.c (init_casetab_once):
1654 * category.c (init_category_once, syms_of_category):
1655 * ccl.c (syms_of_ccl):
1656 * cmds.c (syms_of_cmds):
1657 * composite.c (syms_of_composite):
1658 * dbusbind.c (syms_of_dbusbind):
1659 * dired.c (syms_of_dired):
1660 * dispnew.c (syms_of_display):
1661 * doc.c (syms_of_doc):
1662 * editfns.c (syms_of_editfns):
1663 * emacs.c (syms_of_emacs):
1664 * eval.c (syms_of_eval):
1665 * fileio.c (syms_of_fileio):
1666 * fns.c (syms_of_fns):
1667 * frame.c (syms_of_frame):
1668 * fringe.c (syms_of_fringe):
1669 * insdel.c (syms_of_insdel):
1670 * keymap.c (syms_of_keymap):
1671 * lread.c (init_obarray, syms_of_lread):
1672 * macros.c (syms_of_macros):
1673 * msdos.c (syms_of_msdos):
1674 * print.c (syms_of_print):
1675 * process.c (syms_of_process):
1676 * search.c (syms_of_search):
1677 * sound.c (syms_of_sound):
1678 * syntax.c (init_syntax_once, syms_of_syntax):
1679 * terminal.c (syms_of_terminal):
1680 * textprop.c (syms_of_textprop):
1681 * undo.c (syms_of_undo):
1682 * w32.c (globals_of_w32):
1683 * window.c (syms_of_window):
1684 * xdisp.c (syms_of_xdisp):
1685 * xfaces.c (syms_of_xfaces):
1686 * xfns.c (syms_of_xfns):
1687 * xmenu.c (syms_of_xmenu):
1688 * xsettings.c (syms_of_xsettings):
1689 * xterm.c (syms_of_xterm): Use DEFSYM.
1691 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1693 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1695 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1697 Integer and buffer overflow fixes (Bug#8873).
1699 * print.c (printchar, strout): Check for string overflow.
1700 (PRINTPREPARE, printchar, strout):
1701 Don't set size unless allocation succeeds.
1703 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1704 for sizes. Check for string overflow more accurately.
1705 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1707 * macros.c: Integer and buffer overflow fixes.
1708 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1709 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1710 Use ptrdiff_t, not int, for sizes.
1711 Don't increment bufsize until after realloc succeeds.
1712 Check for size-calculation overflow.
1713 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1715 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1717 * lread.c: Integer overflow fixes.
1718 (read_integer): Radix is now EMACS_INT, not int,
1719 to improve quality of diagnostics for out-of-range radices.
1720 Calculate buffer size correctly for out-of-range radices.
1721 (read1): Check for integer overflow in radices, and in
1722 read-circle numbers.
1723 (read_escape): Avoid int overflow.
1724 (Fload, openp, read_buffer_size, read1)
1725 (substitute_object_recurse, read_vector, read_list, map_obarray):
1726 Use ptrdiff_t, not int, for sizes.
1727 (read1): Use EMACS_INT, not int, for sizes.
1728 Check for size overflow.
1730 * image.c (cache_image): Check for size arithmetic overflow.
1732 * lread.c: Integer overflow issues.
1733 (saved_doc_string_size, saved_doc_string_length)
1734 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1735 Now ptrdiff_t, not int.
1736 (read1): Don't assume doc string length fits in int. Check for
1737 out-of-range doc string lengths.
1738 (read_list): Don't assume file position fits in int.
1739 (read_escape): Check for hex character overflow.
1741 2011-06-22 Leo Liu <sdl.web@gmail.com>
1743 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1744 Move to minibuffer.el.
1746 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1748 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1749 The following patches are for when GLYPH_DEBUG && !XASSERT.
1750 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1751 * dispnew.c (flush_stdout):
1752 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1753 Mark as externally visible.
1754 * dispnew.c (check_window_matrix_pointers): Now static.
1755 * dispnew.c (window_to_frame_vpos):
1756 * xfns.c (unwind_create_frame):
1757 * xterm.c (x_check_font): Remove unused local.
1758 * scroll.c (CHECK_BOUNDS):
1759 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1760 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1761 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1762 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1763 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1765 (debug_method_add): Use va_list and vsprintf rather than relying
1766 on undefined behavior with wrong number of arguments.
1767 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1768 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1769 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1770 since we're not interested in debugging glyphs with old libraries.
1771 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1772 GCC 4.6.0's static checking.
1774 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1776 Integer overflow and signedness fixes (Bug#8873).
1777 A few related buffer overrun fixes, too.
1779 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1781 * dispextern.h (struct face.stipple):
1782 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1783 (x_bitmap_mask, x_allocate_bitmap_record)
1784 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1785 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1786 (x_create_bitmap_from_xpm_data):
1787 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1788 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1790 * xfaces.c (load_pixmap):
1791 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1792 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1793 (.bitmaps_last, struct x_output.icon_bitmap):
1794 Use ptrdiff_t, not int, for bitmap indexes.
1795 (x_allocate_bitmap_record): Check for size overflow.
1796 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1798 Use ptrdiff_t, not int, for overlay counts.
1799 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1800 * editfns.c (overlays_around, get_pos_property):
1801 * textprop.c (get_char_property_and_overlay):
1802 * xdisp.c (next_overlay_change, note_mouse_highlight):
1803 * xfaces.c (face_at_buffer_position):
1804 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1805 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1806 (Fnext_overlay_change, Fprevious_overlay_change)
1807 (mouse_face_overlay_overlaps, Foverlays_in):
1808 Use ptrdiff_t, not int, for sizes.
1809 (overlays_at, overlays_in): Check for size-calculation overflow.
1811 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1813 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1814 (x_session_initialize): Do not assume string length fits in int.
1816 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1817 This is unlikely, but can occur if DPI is outlandish.
1819 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1820 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1822 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1823 * xrdb.c (magic_file_p, search_magic_path):
1824 Omit last arg SUFFIX; it was always 0. All callers changed.
1825 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1827 * xfont.c (xfont_match): Avoid need for strlen.
1829 * xfns.c: Don't assume strlen fits in int.
1830 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1832 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1833 not unsigned long, as we prefer signed integers. All callers changed.
1834 Detect integer overflow in repeat count.
1835 (message_dolog): Don't assume print length fits in 39 bytes.
1836 (display_mode_element): Don't assume strlen fits in int.
1838 * termcap.c: Don't assume sizes fit in int and never overflow.
1839 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1840 (gobble_line): Check for size-calculation overflow.
1842 * minibuf.c (Fread_buffer):
1843 * lread.c (intern, intern_c_string):
1844 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1845 Don't assume string length fits in int.
1847 * keyboard.c (parse_tool_bar_item):
1848 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1850 * font.c: Don't assume string length fits in int.
1851 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1852 Use ptrdiff_t, not int.
1853 (font_intern_prop): Don't assume string length fits in int.
1854 Don't assume integer property fits in fixnum.
1855 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1857 * filelock.c: Fix some buffer overrun and integer overflow issues.
1858 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1859 Reformulate so as not to need the command string.
1860 Invoke gzip -cd rather than gunzip, as it's more portable.
1861 (lock_info_type, lock_file_1, lock_file):
1862 Don't assume pid_t and time_t fit in unsigned long.
1863 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1864 (current_lock_owner): Prefer signed type for sizes.
1865 Use memcpy, not strncpy, where memcpy is what is really wanted.
1866 Don't assume (via atoi) that time_t and pid_t fit in int.
1867 Check for time_t and/or pid_t out of range, e.g., via a network share.
1868 Don't alloca where an auto var works fine.
1870 * fileio.c: Fix some integer overflow issues.
1871 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1872 Don't assume string length fits in int.
1873 (directory_file_name): Don't assume string length fits in long.
1874 (make_temp_name): Don't assume pid fits in int, or that its print
1875 length is less than 20.
1877 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1879 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1881 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1883 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1884 We prefer signed integers, even for size calculations.
1886 * emacs.c: Don't assume string length fits in 'int'.
1887 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1888 (main): Don't invoke strlen when not needed.
1890 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1891 (XD_DEBUG_MESSAGE): Don't waste a byte.
1893 * callproc.c (getenv_internal_1, getenv_internal)
1895 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1897 * lread.c (invalid_syntax): Omit length argument.
1898 All uses changed. This doesn't fix a bug, but it simplifies the
1899 code away from its former Hollerith-constant appearance, and it's
1900 one less 'int' to worry about when looking at integer-overflow issues.
1901 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1903 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1904 This didn't break anything, but it didn't help either.
1905 It's confusing to put a bogus integer in a place where the actual
1906 value does not matter.
1907 (LIST_END_P): Remove unused macro and its bogus comment.
1908 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1910 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1911 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1913 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1914 We prefer signed types, and the value cannot exceed the EMACS_INT
1915 range anyway (because otherwise the length would not be representable).
1916 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1917 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1918 This avoids a GCC warning when WIDE_EMACS_INT.
1920 * indent.c (sane_tab_width): New function.
1921 (current_column, scan_for_column, Findent_to, position_indentation)
1922 (compute_motion): Use it. This is just for clarity.
1923 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1925 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1927 * lisp.h (lint_assume): New macro.
1928 * composite.c (composition_gstring_put_cache):
1929 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1931 * editfns.c, insdel.c:
1932 Omit unnecessary forward decls, to simplify future changes.
1934 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1936 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1938 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1939 Use much-faster test for byte-length change.
1940 Don't assume string byte-length fits in 'int'.
1941 Check that character arg fits in 'int'.
1942 (mapcar1): Declare byte as byte, for clarity.
1944 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1946 * fns.c (concat): Catch string overflow earlier.
1947 Do not rely on integer wraparound.
1949 * dispextern.h (struct it.overlay_strings_charpos)
1950 (struct it.selective): Now EMACS_INT, not int.
1951 * xdisp.c (forward_to_next_line_start)
1952 (back_to_previous_visible_line_start)
1953 (reseat_at_next_visible_line_start, next_element_from_buffer):
1954 Don't arbitrarily truncate the value of 'selective' to int.
1956 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1958 * composite.c: Don't truncate sizes to 'int'.
1959 (composition_gstring_p, composition_reseat_it)
1960 (composition_adjust_point): Use EMACS_INT, not int.
1961 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1962 not EMACS_UINT, for indexes.
1964 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1966 * buffer.c: Include <verify.h>.
1967 (struct sortvec.priority, struct sortstr.priority):
1968 Now EMACS_INT, not int.
1969 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1970 (struct sortstr.size, record_overlay_string)
1971 (struct sortstrlist.size, struct sortlist.used):
1972 Don't truncate size to int.
1973 (record_overlay_string): Check for size-calculation overflow.
1974 (init_buffer_once): Check at compile-time, not run-time.
1976 2011-06-22 Jim Meyering <meyering@redhat.com>
1978 Don't leak an XBM-image-sized buffer
1979 * image.c (xbm_load): Free the image buffer after using it.
1981 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1984 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1985 that Sun C diagnosed.
1986 * fns.c (secure_hash): Fix pointer signedness issue.
1987 * intervals.c (static_offset_intervals): New function.
1988 (offset_intervals): Use it.
1990 2011-06-21 Leo Liu <sdl.web@gmail.com>
1993 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1996 * fns.c (secure_hash): Rename from crypto_hash_function and change
1997 the first arg to accept symbols.
1998 (Fsecure_hash): New primitive.
1999 (syms_of_fns): New symbols.
2001 2011-06-20 Deniz Dogan <deniz@dogan.se>
2003 * process.c (Fset_process_buffer): Clarify return value in
2006 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2008 * dispnew.c (add_window_display_history): Use BVAR.
2010 * xdisp.c (debug_method_add): Use BVAR.
2011 (check_window_end, dump_glyph_matrix, dump_glyph)
2012 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2014 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2017 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2018 check till after the cache is created in init_frame_faces.
2020 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2022 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2024 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2026 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2027 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2028 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2030 Improve buffer-overflow checking (Bug#8873).
2031 * fileio.c (Finsert_file_contents):
2032 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2033 Remove the old (too-loose) buffer overflow checks.
2034 They weren't needed, since make_gap checks for buffer overflow.
2035 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2036 The old code merely checked for Emacs fixnum overflow, and relied
2037 on undefined (wraparound) behavior. The new code avoids undefined
2038 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2040 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2041 Tune. Don't use wider integers than needed. Don't use alloca.
2042 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2044 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2046 * insdel.c, lisp.h (buffer_overflow): New function.
2047 (insert_from_buffer_1, replace_range, replace_range_2):
2048 * insdel.c (make_gap_larger):
2049 * editfns.c (Finsert_char):
2050 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2052 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2054 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2056 Integer overflow and signedness fixes (Bug#8873).
2058 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2059 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2061 * fileio.c: Don't assume EMACS_INT fits in off_t.
2062 (emacs_lseek): New static function.
2063 (Finsert_file_contents, Fwrite_region): Use it.
2064 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2066 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2068 * fns.c: Don't overflow int when computing a list length.
2069 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2070 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2071 truncation on 64-bit hosts. Check for QUIT every
2072 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2073 faster and is responsive enough.
2074 (Flength): Report an error instead of overflowing an integer.
2075 (Fsafe_length): Return a float if the value is not representable
2076 as a fixnum. This shouldn't happen except in contrived situations.
2077 (Fnthcdr, Fsort): Don't assume list length fits in int.
2078 (Fcopy_sequence): Don't assume vector length fits in int.
2080 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2081 (header_size, word_size): New constants.
2082 (allocate_vectorlike): Don't check size overflow here.
2083 (allocate_vector): Check it here instead, since this is the only
2084 caller of allocate_vectorlike that could cause overflow.
2085 Check that the new vector's length is representable as a fixnum.
2087 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2088 The previous code was bogus. For example, next_almost_prime (32)
2089 returned 39, which is undesirable as it is a multiple of 3; and
2090 next_almost_prime (24) returned 25, which is a multiple of 5 so
2091 why was the code bothering to check for multiples of 7?
2093 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2095 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2097 Variadic C functions now count arguments with ptrdiff_t.
2098 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2099 Back then I didn't know that the Emacs coding style prefers signed int.
2100 Also, in the meantime I found a few more instances where arguments
2101 were being counted with int, which may truncate counts on 64-bit
2102 machines, or EMACS_INT, which may be unnecessarily wide.
2103 * lisp.h (struct Lisp_Subr.function.aMANY)
2104 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2105 Arg counts are now ptrdiff_t, not size_t.
2106 All variadic functions and their callers changed accordingly.
2107 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2108 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2109 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2110 * callint.c (Fcall_interactively): Check arg count for overflow,
2111 to avoid potential buffer overrun. Use signed char, not 'int',
2112 for 'varies' array, so that we needn't bother to check its size
2113 calculation for overflow.
2114 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2115 * eval.c (apply_lambda):
2116 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2117 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2118 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2120 * callint.c (Fcall_interactively): Don't use index var as event count.
2122 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2123 * mem-limits.h (SIZE): Remove; no longer used.
2125 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2127 Remove unnecessary casts.
2128 * xterm.c (x_term_init):
2129 * xfns.c (x_set_border_pixel):
2130 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2131 These aren't needed now that we assume ANSI C.
2133 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2134 It's more likely to cause problems (due to unsigned overflow)
2137 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2139 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2141 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2143 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2145 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2147 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2149 GLYPH_CODE_FACE returns EMACS_INT, not int.
2150 * dispextern.h (merge_faces):
2151 * xfaces.c (merge_faces):
2152 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2153 Don't assume EMACS_INT fits in int.
2155 * character.h (CHAR_VALID_P): Remove unused parameter.
2156 * fontset.c, lisp.h, xdisp.c: All uses changed.
2158 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2160 * fns.c (concat): Minor tuning based on overflow analysis.
2161 This doesn't fix any bugs. Use int to hold character, instead
2162 of constantly refetching from Emacs object. Use XFASTINT, not
2163 XINT, for value known to be a character. Don't bother comparing
2164 a single byte to 0400, as it's always less.
2166 * floatfns.c (Fexpt):
2167 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2169 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2172 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2174 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2175 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2176 incorrectly succeed when S was a string, because 4294967386 was
2177 truncated before it was used.
2179 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2180 Otherwise, an out-of-range integer could cause undefined behavior
2183 * composite.c: Use int, not EMACS_INT, for characters.
2184 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2185 EMACS_INT, for values that are known to be in character range.
2186 This doesn't fix any bugs but is the usual style inside Emacs and
2187 may generate better code on 32-bit machines.
2189 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2190 This is for reasons similar to the recent CHAR_STRING fix.
2191 * charset.c (Fencode_char): Check that character arg is actually
2192 a character. Pass an int to ENCODE_CHAR.
2193 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2194 wider than 'int', as a compile-time check to prevent future regressions
2197 * character.c (char_string): Remove unnecessary casts.
2199 Make sure a 64-bit char is never passed to CHAR_STRING.
2200 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2201 by silently ignoring the top 32 bits, allowing some values
2202 that were far too large to be valid characters.
2203 * character.h: Include <verify.h>.
2204 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2205 arguments are no wider than unsigned, as a compile-time check
2206 to prevent future regressions in this area.
2208 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2209 (Fsubst_char_in_region):
2211 * xdisp.c (decode_mode_spec_coding):
2212 Adjust to CHAR_STRING's new requirement.
2213 * editfns.c (Finsert_char, Fsubst_char_in_region):
2214 * fns.c (concat): Check that character args are actually
2215 characters. Without this test, these functions did the wrong
2216 thing with wildly out-of-range values on 64-bit hosts.
2218 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2219 These casts should not be needed on 32-bit hosts, either.
2220 * keyboard.c (read_char):
2221 * lread.c (Fload): Remove casts to unsigned.
2223 * lisp.h (UNSIGNED_CMP): New macro.
2224 This fixes comparison bugs on 64-bit hosts.
2225 (ASCII_CHAR_P): Use it.
2226 * casefiddle.c (casify_object):
2227 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2228 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2229 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2230 * dispextern.h (FACE_FROM_ID):
2231 * keyboard.c (read_char): Use UNSIGNED_CMP.
2233 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2234 not to EMACS_INT, to avoid GCC warning.
2236 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2238 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2239 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2240 isn't needed on 32-bit machines.
2242 * buffer.c (Fgenerate_new_buffer_name):
2243 Use EMACS_INT for count, not int.
2244 (advance_to_char_boundary): Return EMACS_INT, not int.
2246 * data.c (Qcompiled_function): Now static.
2248 * window.c (window_body_lines): Now static.
2250 * image.c (gif_load): Rename local to avoid shadowing.
2252 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2253 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2254 * alloc.c (make_save_value): Integer argument is now of type
2256 (mark_object): Use ptrdiff_t, not int.
2257 * lisp.h (pD): New macro.
2258 * print.c (print_object): Use it.
2260 * alloc.c: Use EMACS_INT, not int, to count objects.
2261 (total_conses, total_markers, total_symbols, total_vector_size)
2262 (total_free_conses, total_free_markers, total_free_symbols)
2263 (total_free_floats, total_floats, total_free_intervals)
2264 (total_intervals, total_strings, total_free_strings):
2265 Now EMACS_INT, not int. All uses changed.
2266 (Fgarbage_collect): Compute overall total using a double, so that
2267 integer overflow is less likely to be a problem. Check for overflow
2268 when converting back to an integer.
2269 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2270 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2271 These were 'int' variables that could overflow on 64-bit hosts;
2272 they were never used, so remove them instead of repairing them.
2273 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2274 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2275 Previously, this ceilinged at INT_MAX, but that doesn't work on
2277 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2279 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2280 (allocate_vectorlike): Check for ptrdiff_t overflow.
2281 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2282 when a (possibly-narrower) signed value would do just as well.
2283 We prefer using signed arithmetic, to avoid comparison confusion.
2285 * alloc.c: Catch some string size overflows that we were missing.
2286 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2287 for convenience in STRING_BYTES_MAX.
2288 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2289 The definition here is exact; the one in lisp.h was approximate.
2290 (allocate_string_data): Check for string overflow. This catches
2291 some instances we weren't catching before. Also, it catches
2292 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2293 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2294 and ptrdiff_t and EMACS_INT are both 64 bits.
2296 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2297 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2298 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2300 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2302 * alloc.c (Fmake_string): Check for out-of-range init.
2304 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2306 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2308 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2310 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2311 xg_get_default_scrollbar_width.
2313 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2314 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2315 (style_changed_cb): Call update_theme_scrollbar_width and call
2316 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2317 all frames (Bug#8505).
2318 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2319 Call gtk_window_set_resizable if HAVE_GTK3.
2320 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2321 and height if HAVE_GTK3 (Bug#8505).
2322 (scroll_bar_width_for_theme): New variable.
2323 (update_theme_scrollbar_width): New function.
2324 (xg_get_default_scrollbar_width): Move code to
2325 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2326 (xg_initialize): Call update_theme_scrollbar_width.
2328 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2330 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2332 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2334 * frame.c (make_frame): Call other_buffer_safely instead of
2337 * window.c (temp_output_buffer_show): Call display_buffer with
2338 second argument Vtemp_buffer_show_specifiers and reset latter
2339 immediately after the call.
2340 (Vtemp_buffer_show_specifiers): New variable.
2341 (auto_window_vscroll_p, next_screen_context_lines)
2342 (Vscroll_preserve_screen_position): Remove leading asterisks from
2345 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2347 Fix minor problems found by GCC 4.6.0 static checking.
2348 * buffer.c (Qclone_number): Remove for now, as it's unused.
2349 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2350 (record_buffer): Remove unused local.
2351 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2352 (set_frame_buffer_list): Remove; unused.
2353 * frame.h (other_visible_frames): Remove decl.
2354 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2355 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2356 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2358 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2359 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2360 Define only if HAVE_GPM.
2361 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2362 (update_hints_inhibit): Remove; never set. All uses removed.
2363 * widgetprv.h (emacsFrameClassRec): Remove decl.
2364 * window.c (delete_deletable_window): Now returns void, since it
2365 wasn't returning anything.
2366 (compare_window_configurations): Remove unused locals.
2367 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2368 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2369 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2370 the same widths as pointers. This follows up on the 2011-05-06 patch.
2371 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2372 * xterm.h: Likewise.
2373 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2375 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2377 * makefile.w32-in: Update dependencies.
2378 (LISP_H): Add lib/intprops.h.
2380 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2382 * image.c (gif_load): Add animation frame delay to the metadata.
2383 (syms_of_image): Use DEFSYM. New symbol `delay'.
2385 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2387 * window.c (delete_deletable_window): Re-add.
2388 (Fset_window_configuration): Rewrite to handle dead buffers and
2389 consequently deletable windows.
2390 (window_tree, Fwindow_tree): Remove. Supply functionality in
2392 (compare_window_configurations): Simplify code.
2394 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2396 * image.c (imagemagick_load_image): Fix type mismatch.
2397 (Fimagemagick_types): Likewise.
2399 * window.h (replace_buffer_in_windows): Declare.
2401 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2403 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2404 Qclone_number. Remove external declaration of Qdelete_window.
2405 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2407 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2408 Run Qbuffer_list_update_hook if allowed.
2409 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2410 buffer list implementation.
2411 (other_buffer_safely): New function.
2412 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2413 calls to replace_buffer_in_windows and
2414 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2416 (record_buffer): Inhibit quitting and rewrite using quittable
2417 functions. Run Qbuffer_list_update_hook if allowed.
2418 (Frecord_buffer, Funrecord_buffer): New functions.
2419 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2420 Move switch-to-buffer to window.el.
2421 (bury-buffer): Move to window.el.
2422 (Vbuffer_list_update_hook): New variable.
2424 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2427 * window.h (resize_frame_windows): Move up in code.
2428 (Fwindow_frame): Remove EXFUN.
2429 (replace_buffer_in_all_windows): Remove prototype.
2430 (replace_buffer_in_windows_safely): Add prototype.
2432 * window.c: Declare Qdelete_window static again. Move down
2433 declaration of select_count.
2434 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2435 (Fother_window): Move to window.el.
2436 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2437 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2438 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2440 (replace_buffer_in_windows): Implement by calling
2441 Qreplace_buffer_in_windows.
2442 (replace_buffer_in_all_windows): Remove with some functionality
2443 moved into replace_buffer_in_windows_safely.
2444 (replace_buffer_in_windows_safely): New function.
2445 (select_window_norecord, select_frame_norecord): Move in front
2446 of run_window_configuration_change_hook. Remove now obsolete
2448 (Fset_window_buffer): Rewrite doc-string.
2449 Call Qrecord_window_buffer.
2450 (keys_of_window): Move binding for other-window to window.el.
2452 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2454 * dispextern.h (struct image): Replace data member, whose int_val
2455 and ptr_val fields were not used by anything, with a single
2458 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2459 (gif_clear_image, gif_load, imagemagick_load_image)
2460 (gs_clear_image, gs_load): Callers changed.
2462 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2464 * buffer.h: Include <time.h>, for time_t.
2465 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2467 Fix minor problems found by static checking.
2469 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2471 Make identifiers static if they are not used in other modules.
2472 * data.c (Qcompiled_function, Qframe, Qvector):
2473 * image.c (QimageMagick, Qsvg):
2474 * minibuf.c (Qmetadata):
2475 * window.c (resize_window_check, resize_root_window): Now static.
2476 * window.h (resize_window_check, resize_root_window): Remove decls.
2478 * window.c (window_deletion_count, delete_deletable_window):
2480 (window_body_lines): Now static.
2481 (Fdelete_other_windows_internal): Mark vars as initialized.
2482 Make sure 'resize_failed' is initialized.
2483 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2484 (resize_window_apply): Remove unused local.
2485 * window.h (delete_deletable_window): Remove decl.
2487 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2488 (imagemagick_load_image): Fix pointer signedness problem by changing
2489 last arg from unsigned char * to char *. All uses changed.
2490 Also, fix a local for similar reasons.
2491 Remove unused locals. Remove locals to avoid shadowing.
2492 (fn_rsvg_handle_free): Remove; unused.
2493 (svg_load, svg_load_image): Fix pointer signedness problem.
2494 (imagemagick_load_image): Don't use garbage pointer image_wand.
2496 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2498 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2500 * image.c (gif_load): Fix omitted cast error introduced by
2503 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2505 * window.h (resize_proportionally, orig_total_lines)
2506 (orig_top_line): Remove from window structure.
2507 (set_window_height, set_window_width, change_window_heights)
2508 (Fdelete_window): Remove prototypes.
2509 (resize_frame_windows): Remove duplicate declaration.
2511 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2513 * window.h (resize_frame_windows, resize_window_check)
2514 (delete_deletable_window, resize_root_window)
2515 (resize_frame_windows): Declare prototypes.
2517 * window.c (resize_window_apply): Make definition be "static" to
2518 match the prototype.
2520 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2522 * window.c: Remove declarations of Qwindow_size_fixed,
2523 window_min_size_1, window_min_size_2, window_min_size,
2524 size_window, window_fixed_size_p, enlarge_window, delete_window.
2525 Remove static from declaration of Qdelete_window, it's
2526 temporarily needed by Fbury_buffer.
2527 (replace_window): Don't assign orig_top_line and
2529 (Fdelete_window, delete_window): Remove. Window deletion is
2530 handled by window.el.
2531 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2532 Replace Fdelete_window calls with calls to Qdelete_window.
2533 (Fdelete_other_windows): Remove. Deleting other windows is
2534 handled by window.el.
2535 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2536 handled in window.el.
2537 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2538 Window minimum sizes are handled in window.el.
2539 (shrink_windows, size_window, set_window_height)
2540 (set_window_width, change_window_heights, window_height)
2541 (window_width, CURBEG, CURSIZE, enlarge_window)
2542 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2543 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2544 handled in window.el.
2545 (make_dummy_parent): Rename to make_parent_window and give it a
2546 second argument horflag.
2547 (make_window): Don't set resize_proportionally any more.
2548 (Fsplit_window): Remove. Windows are split in window.el.
2549 (save_restore_action, save_restore_orig_size)
2550 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2551 Resize mini windows in window.el.
2552 (grow_mini_window, shrink_mini_window): Implement by calling
2553 Qresize_root_window_vertically, resize_window_check and
2554 resize_window_apply.
2555 (saved_window, Fset_window_configuration, save_window_save):
2556 Do not handle orig_top_line, orig_total_lines, and
2557 resize_proportionally.
2558 (window_min_height, window_min_width): Move to window.el.
2559 (keys_of_window): Move bindings for delete-other-windows,
2560 split-window, delete-window and enlarge-window to window.el.
2562 * buffer.c: Temporarily extern Qdelete_window.
2563 (Fbury_buffer): Temporarily call Qdelete_window instead of
2564 Fdelete_window (Fbury_buffer will move to window.el soon).
2566 * frame.c (set_menu_bar_lines_1): Remove code handling
2567 orig_top_line and orig_total_lines.
2569 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2570 set_window_height but set heights directly.
2571 (change_frame_size_1): Use resize_frame_windows.
2573 * xdisp.c (init_xdisp): Don't use set_window_height but set
2576 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2577 Use resize_frame_windows instead of change_window_heights and run
2578 run_window_configuration_change_hook.
2580 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2581 instead of change_window_heights and run
2582 run_window_configuration_change_hook.
2584 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2586 * window.c (replace_window): Rename second argument REPLACEMENT to
2587 NEW. New third argument SETFLAG. Rewrite.
2588 (delete_window, make_dummy_parent): Call replace_window with
2590 (window_list_1): Move down in code.
2591 (run_window_configuration_change_hook): Move set_buffer part
2592 before select_frame_norecord part in order to unwind correctly.
2593 Rename count1 to count.
2594 (recombine_windows, delete_deletable_window, resize_root_window)
2595 (Fdelete_other_windows_internal)
2596 (Frun_window_configuration_change_hook, make_parent_window)
2597 (resize_window_check, resize_window_apply, Fresize_window_apply)
2598 (resize_frame_windows, Fsplit_window_internal)
2599 (Fdelete_window_internal, Fresize_mini_window_internal):
2601 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2603 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2605 * window.h (window): Add some new members to window structure -
2606 normal_lines, normal_cols, new_total, new_normal, clone_number,
2607 splits, nest, prev_buffers, next_buffers.
2608 (WINDOW_TOTAL_SIZE): Move here from window.c.
2609 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2611 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2613 (make_dummy_parent): Set new members of windows structure.
2614 (make_window): Move down in code. Handle new members of window
2616 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2617 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2618 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2619 (Fset_window_prev_buffers, Fwindow_next_buffers)
2620 (Fset_window_next_buffers, Fset_window_clone_number):
2622 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2623 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2625 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2626 Argument WINDOW can be now internal window too.
2627 (Fwindow_use_time): Move up in code.
2628 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2630 (Fset_window_configuration, saved_window)
2631 (Fcurrent_window_configuration, save_window_save): Handle new
2632 members of window structure.
2633 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2634 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2635 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2636 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2637 Qget_mru_window, Qresize_root_window,
2638 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2639 Qauto_buffer_name; staticpro them.
2641 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2643 * window.c (Fwindow_total_size, Fwindow_left_column)
2644 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2645 (Fwindow_list_1): New functions.
2646 (window_box_text_cols): Replace with window_body_cols.
2647 (Fwindow_width, Fscroll_left, Fscroll_right):
2648 Use window_body_cols instead of window_box_text_cols.
2649 (delete_window, Fset_window_configuration):
2650 Call delete_all_subwindows with window as argument.
2651 (delete_all_subwindows): Take a window as argument and not a
2653 (window_loop): Remove handling of GET_LRU_WINDOW and
2655 (Fget_lru_window, Fget_largest_window): Move to window.el.
2657 * window.h: Extern window_body_cols instead of
2658 window_box_text_cols. delete_all_subwindows now takes a
2659 Lisp_Object as argument.
2661 * indent.c (compute_motion, Fcompute_motion):
2662 Use window_body_cols instead of window_box_text_cols.
2664 * frame.c (delete_frame): Call delete_all_subwindows with root
2667 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2669 * fns.c (Fputhash): Document return value.
2671 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2673 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2675 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2677 Cons<->int and similar integer overflow fixes (Bug#8794).
2679 Check for overflow when converting integer to cons and back.
2680 * charset.c (Fdefine_charset_internal, Fdecode_char):
2681 Use cons_to_unsigned to catch overflow.
2682 (Fencode_char): Use INTEGER_TO_CONS.
2683 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2684 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2685 * data.c (long_to_cons, cons_to_long): Remove.
2686 (cons_to_unsigned, cons_to_signed): New functions.
2687 These signal an error for invalid or out-of-range values.
2688 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2689 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2690 * font.c (Ffont_variation_glyphs):
2691 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2692 * lisp.h: Include <intprops.h>.
2693 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2694 (cons_to_signed, cons_to_unsigned): New decls.
2695 (long_to_cons, cons_to_long): Remove decls.
2696 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2697 (Fprimitive_undo): Use CONS_TO_INTEGER.
2698 * xfns.c (Fx_window_property): Likewise.
2699 * xselect.c: Include <limits.h>.
2700 (x_own_selection, selection_data_to_lisp_data):
2701 Use INTEGER_TO_CONS.
2702 (x_handle_selection_request, x_handle_selection_clear)
2703 (x_get_foreign_selection, Fx_disown_selection_internal)
2704 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2705 (lisp_data_to_selection_data): Use cons_to_unsigned.
2706 (x_fill_property_data): Use cons_to_signed.
2707 Report values out of range.
2709 Check for buffer and string overflow more precisely.
2710 * buffer.h (BUF_BYTES_MAX): New macro.
2711 * lisp.h (STRING_BYTES_MAX): New macro.
2712 * alloc.c (Fmake_string):
2713 * character.c (string_escape_byte8):
2714 * coding.c (coding_alloc_by_realloc):
2715 * doprnt.c (doprnt):
2716 * editfns.c (Fformat):
2718 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2719 since they may not be the same number.
2720 * editfns.c (Finsert_char):
2721 * fileio.c (Finsert_file_contents):
2722 Likewise for BUF_BYTES_MAX.
2724 * image.c: Use ptrdiff_t, not int, for sizes.
2725 (slurp_file): Switch from int to ptrdiff_t.
2727 (slurp_file): Check that file size fits in both size_t (for
2728 malloc) and ptrdiff_t (for sanity and safety).
2730 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2731 if b->modtime has its maximal value.
2733 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2735 Don't assume time_t can fit into int.
2736 * buffer.h (struct buffer.modtime): Now time_t, not int.
2737 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2738 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2740 Minor fixes for signed vs unsigned integers.
2741 * character.h (MAYBE_UNIFY_CHAR):
2742 * charset.c (maybe_unify_char):
2743 * keyboard.c (read_char, reorder_modifiers):
2744 XINT -> XFASTINT, since the integer must be nonnegative.
2745 * ftfont.c (ftfont_spec_pattern):
2746 * keymap.c (access_keymap, silly_event_symbol_error):
2747 XUINT -> XFASTINT, since the integer must be nonnegative.
2748 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2749 since it makes no difference and we prefer signed.
2750 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2751 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2754 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2756 * window.h (Fwindow_frame): Declare.
2758 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2760 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2761 (SPARE_MEMORY): Always define.
2762 (LARGE_REQUEST): Remove.
2763 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2765 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2767 * lisp.h: Move EXFUNS for Fframe_root_window,
2768 Fframe_first_window and Fset_frame_selected_window to window.h.
2770 * window.h: Move EXFUNS for Fframe_root_window,
2771 Fframe_first_window and Fset_frame_selected_window here from
2774 * frame.c (Fwindow_frame, Fframe_first_window)
2775 (Fframe_root_window, Fframe_selected_window)
2776 (Fset_frame_selected_window): Move to window.c.
2777 (Factive_minibuffer_window): Move to minibuf.c.
2778 (Fother_visible_frames_p): New function.
2780 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2782 * window.c (decode_window, decode_any_window): Move up in code.
2783 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2784 (inhibit_frame_unsplittable): Remove unused variable.
2785 (Fwindow_buffer): Move up and rewrite doc-string.
2786 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2787 (Fwindow_prev): New functions.
2788 (Fwindow_frame): Move here from frame.c. Accept any window as
2790 (Fframe_root_window, Fframe_first_window)
2791 (Fframe_selected_window): Move here from frame.c. Accept frame
2792 or arbitrary window as argument. Update doc-strings.
2793 (Fminibuffer_window): Move up in code.
2794 (Fwindow_minibuffer_p): Move up in code and simplify.
2795 (Fset_frame_selected_window): Move here from frame.c.
2797 (Fselected_window, select_window, Fselect_window): Move up in
2798 code. Minor doc-string fixes.
2800 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2802 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2803 Do not assume that spare memory exists; that assumption is valid
2804 only if SYSTEM_MALLOC.
2805 (LARGE_REQUEST): New macro, so that the issue of large requests
2806 is separated from the issue of spare memory.
2808 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2810 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2813 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2815 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2818 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2820 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2822 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2824 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2825 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2827 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2829 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2831 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2833 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2834 (x_clipboard_manager_save): Add return value.
2835 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2837 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2838 Obey Vx_select_enable_clipboard_manager. Catch errors in
2839 x_clipboard_manager_save (Bug#8779).
2840 (Vx_select_enable_clipboard_manager): New variable.
2841 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2843 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2845 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2847 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2849 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2850 in the current matrix if keep_current_p is non-zero.
2852 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2854 * bidi.c (bidi_level_of_next_char): Fix last change.
2856 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2858 Support bidi reordering of text covered by display properties.
2860 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2861 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2862 (bidi_cache_search, bidi_cache_iterator_state)
2863 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2864 (bidi_level_of_next_char, bidi_move_to_visually_next):
2865 Support character positions inside a run of characters covered by a
2867 (bidi_paragraph_init, bidi_resolve_explicit_1)
2868 (bidi_level_of_next_char): Call bidi_fetch_char and
2869 bidi_fetch_char_advance instead of FETCH_CHAR and
2871 (bidi_init_it): Initialize new members.
2872 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2874 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2875 instead of using explicit *_CHAR codes.
2876 (bidi_resolve_explicit, bidi_resolve_weak):
2877 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2878 bidirectional text is supported only in multibyte buffers.
2879 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2880 it to initialize the frame_window_p member of struct bidi_it.
2881 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2882 (bidi_resolve_explicit, bidi_resolve_weak)
2883 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2884 bidi_it->nchars is non-positive.
2885 (bidi_level_of_next_char): Don't try to lookup the cache for the
2886 next/previous character if nothing is cached there yet, or if we
2887 were just reseat()'ed to a new position.
2889 * xdisp.c (set_cursor_from_row): Set start and stop points
2890 according to the row's direction when priming the loop that looks
2891 for the glyph on which to display cursor.
2892 (single_display_spec_intangible_p): Function deleted.
2893 (display_prop_intangible_p): Reimplement to call
2894 handle_display_spec instead of single_display_spec_intangible_p.
2895 Accept 3 additional arguments needed by handle_display_spec.
2896 This fixes incorrect cursor motion across display property with complex
2897 values: lists, `(when COND...)' forms, etc.
2898 (single_display_spec_string_p): Support property values that are
2899 lists with the argument STRING its top-level element.
2900 (display_prop_string_p): Fix the condition for processing a
2901 property that is a list to be consistent with handle_display_spec.
2902 (handle_display_spec): New function, refactored from the
2903 last portion of handle_display_prop.
2904 (compute_display_string_pos): Accept additional argument
2905 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2906 value of a `display' property is a "replacing spec".
2907 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2908 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2909 the display property, but just return a value indicating whether
2910 the display property will replace the characters it covers.
2911 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2912 frame_window_p members of struct bidi_it.
2913 (compute_display_string_pos, compute_display_string_end):
2915 (push_it): Accept second argument POSITION, where pop_it should
2916 jump to continue iteration.
2917 (reseat_1): Initialize bidi_it.disp_pos.
2919 * keyboard.c (adjust_point_for_property): Adjust the call to
2920 display_prop_intangible_p to its new signature.
2922 * dispextern.h (struct bidi_it): New member frame_window_p.
2923 (bidi_init_it): Update prototypes.
2924 (display_prop_intangible_p): Update prototype.
2925 (compute_display_string_pos, compute_display_string_end):
2927 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2930 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2932 Malloc failure behavior now depends on size of allocation.
2933 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2934 * lisp.h: Change signatures accordingly.
2935 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2936 All callers changed. (Bug#8762)
2938 * gnutls.c: Use Emacs's memory allocators.
2939 Without this change, the gnutls library would invoke malloc etc.
2940 directly, which causes problems on non-SYNC_INPUT hosts, and which
2941 runs afoul of improving memory_full behavior. (Bug#8761)
2942 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2943 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2944 xfree instead of the default malloc, realloc, free.
2945 (Fgnutls_boot): No need to check for memory allocation failure,
2946 since xmalloc does that for us.
2948 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2949 * category.c (hash_get_category_set):
2950 * ccl.c (ccl_driver):
2951 * charset.c (Fdefine_charset_internal):
2952 * charset.h (struct charset.hash_index):
2953 * composite.c (get_composition_id, gstring_lookup_cache)
2954 (composition_gstring_put_cache):
2955 * composite.h (struct composition.hash_index):
2956 * dispextern.h (struct image.hash):
2957 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2958 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2959 (hashfn_equal, hashfn_user_defined, make_hash_table)
2960 (maybe_resize_hash_table, hash_lookup, hash_put)
2961 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2962 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2963 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2964 * image.c (make_image, search_image_cache, lookup_image)
2965 (xpm_put_color_table_h):
2966 * lisp.h (struct Lisp_Hash_Table):
2967 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2968 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2969 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2970 * alloc.c (allocate_vectorlike):
2971 Check for overflow in vector size calculations.
2972 * ccl.c (ccl_driver):
2973 Check for overflow when converting EMACS_INT to int.
2974 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2975 need to be updated by these changes.
2976 * fns.c (make_hash_table, maybe_resize_hash_table):
2977 Check for integer overflow with large hash tables.
2978 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2979 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2980 (SXHASH_REDUCE): New macro.
2981 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2982 Use it instead of discarding useful hash info with large hash values.
2983 (sxhash_float): New function.
2984 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2985 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2986 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2987 Rewrite to use FIXNUM_BITS, as this simplifies things.
2988 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2989 Adjust signatures to match updated version of code.
2990 (consing_since_gc): Now EMACS_INT, since a single hash table can
2991 use more than INT_MAX bytes.
2993 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2995 Make it possible to build with GCC-4.6+ -O2 -flto.
2997 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2999 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3001 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3002 Call minibuffer-inactive-mode.
3004 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3006 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3007 Update dependencies.
3009 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3011 * data.c (init_data): Remove code for UTS, this system is not
3014 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3016 Don't force ./temacs to start in terminal mode.
3018 * frame.c (make_initial_frame): Initialize faces in all cases, not
3019 only when CANNOT_DUMP is defined.
3020 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3022 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3024 * dispnew.c (add_window_display_history): Use const for the string
3025 pointer. Remove declaration, not needed.
3027 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3029 Use 'inline', not 'INLINE'.
3030 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3031 * alloc.c, fontset.c (INLINE): Remove.
3032 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3033 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3034 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3035 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3036 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3038 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3040 Make it possible to run ./temacs.
3042 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3043 syms_of_callproc does the same thing. Remove test for
3044 "initialized", do it in the caller.
3045 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3047 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3049 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3050 (read_minibuf): Use get_minibuffer.
3051 (syms_of_minibuf): Use DEFSYM.
3052 (Qmetadata): New var.
3053 * data.c (Qbuffer): Don't make it static.
3054 (syms_of_data): Use DEFSYM.
3056 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3058 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3059 (CCL_CODE_MIN): New macro.
3061 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3063 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3065 * eval.c (Qdebug): Now static.
3066 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3067 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3068 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3070 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3072 * image.c: Various fixes to ImageMagick code comments.
3073 (Fimagemagick_types): Doc fix.
3075 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3077 Minor fixes prompted by GCC 4.6.0 warnings.
3079 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3081 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3082 (x_clipboard_manager_save_all): Move extern decl to ...
3083 * xterm.h: ... here, so that it can be checked for consistency.
3085 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3087 * xselect.c (x_clipboard_manager_save_frame)
3088 (x_clipboard_manager_save_all): New functions.
3089 (Fx_clipboard_manager_save): Lisp function deleted.
3091 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3092 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3094 * xterm.h: Update prototype.
3096 2011-05-28 William Xu <william.xwl@gmail.com>
3098 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3101 2011-05-28 Jim Meyering <meyering@redhat.com>
3103 Avoid a sign-extension bug in crypto_hash_function.
3104 * fns.c (to_uchar): Define.
3105 (crypto_hash_function): Use it to convert some newly-signed
3106 variables to unsigned, to avoid sign-extension bugs. For example,
3107 without this change, (md5 "truc") would evaluate to
3108 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3109 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3110 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3112 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3114 Integer overflow fixes.
3116 * dbusbind.c: Serial number integer overflow fixes.
3117 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3118 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3119 to hold a serial number that is too large for a fixnum.
3120 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3121 Check for serial numbers out of range. Decode any serial number
3122 that was so large that it became a float. (Bug#8722)
3124 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3125 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3126 Use XFASTINT rather than XUINT when numbers are nonnegative.
3127 (xd_append_arg, Fdbus_method_return_internal):
3128 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3129 arguments, check that Lisp number is nonnegative, rather than
3130 silently wrapping negative numbers around. (Bug#8722)
3131 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3134 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3136 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3138 ccl: add integer overflow checks
3139 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3140 (IN_INT_RANGE): New macros.
3141 (ccl_driver): Use them to check for integer overflow when
3142 decoding a CCL program. Many of the new checks are whether XINT (x)
3143 fits in int; it doesn't always, on 64-bit hosts. The new version
3144 doesn't catch all possible integer overflows, but it's an
3145 improvement. (Bug#8719)
3147 * alloc.c (make_event_array): Use XINT, not XUINT.
3148 There's no need for unsigned here.
3150 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3151 This follows up to the 2011-05-06 change that substituted uintptr_t
3152 for EMACS_INT. This case wasn't caught back then.
3154 Rework Fformat to avoid integer overflow issues.
3155 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3156 now (part of C89). Include <verify.h>.
3157 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3158 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3159 (Fformat): Avoid the prepass trying to compute sizes; it was only
3160 approximate and thus did not catch overflow reliably. Instead, walk
3161 through the format just once, formatting and computing sizes as we go,
3162 checking for integer overflow at every step, and allocating a larger
3163 buffer as needed. Keep track separately whether the format is
3164 multibyte. Keep only the most-recently calculated precision, rather
3165 than them all. Record whether each argument has been converted to
3166 string. Use EMACS_INT, not int, for byte and char and arg counts.
3167 Support field widths and precisions larger than INT_MAX. Avoid
3168 sprintf's undefined behavior with conversion specifications such as %#d
3169 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3170 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3171 formatting out-of-range floating point numbers with int
3174 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3176 * data.c: Avoid integer truncation in expressions involving floats.
3177 * data.c: Include <intprops.h>.
3178 (arith_driver): When there's an integer overflow in an expression
3179 involving floating point, convert the integers to floating point
3180 so that the resulting value does not suffer from catastrophic
3181 integer truncation. For example, on a 64-bit host (* 4
3182 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3183 Do not rely on undefined behavior after integer overflow.
3185 merge count_size_as_multibyte, parse_str_to_multibyte
3186 * character.c, character.h (count_size_as_multibyte):
3187 Rename from parse_str_to_multibyte; all uses changed.
3188 Check for integer overflow.
3189 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3190 since it's now a duplicate of the other. This is more of
3191 a character than a buffer op, so better that it's in character.c.
3192 * fns.c, print.c: Adjust to above changes.
3194 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3196 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3198 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3200 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3201 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3202 (x_clipboard_manager_save): Now static.
3203 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3205 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3206 (crypto_hash_function): Now static.
3207 Fix pointer signedness problems. Avoid unnecessary initializations.
3209 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3211 * termhooks.h (Vselection_alist): Make it terminal-local.
3213 * terminal.c (create_terminal): Initialize it.
3215 * xselect.c: Support for clipboard managers.
3216 (Vselection_alist): Move to termhooks.h as terminal-local var.
3217 (LOCAL_SELECTION): New macro.
3218 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3219 (symbol_to_x_atom): Remove gratuitous arg.
3220 (x_handle_selection_request, lisp_data_to_selection_data)
3221 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3222 (x_own_selection, x_get_local_selection, x_convert_selection):
3223 New arg, specifying work frame. Use terminal-local Vselection_alist.
3224 (some_frame_on_display): Delete unused function.
3225 (Fx_own_selection_internal, Fx_get_selection_internal)
3226 (Fx_disown_selection_internal, Fx_selection_owner_p)
3227 (Fx_selection_exists_p): New optional frame arg.
3228 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3229 (x_handle_selection_clear): Don't treat other terminals with the
3230 same keyboard specially. Use the terminal-local Vselection_alist.
3231 (x_clear_frame_selections): Use Frun_hook_with_args.
3233 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3235 * xterm.h: Add support for those atoms.
3237 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3239 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3240 (converted_selections, conversion_fail_tag): New global variables.
3241 (x_selection_request_lisp_error): Free the above.
3242 (x_get_local_selection): Remove unnecessary code.
3243 (x_reply_selection_request): Args changed; handle arbitrary array
3244 of converted selections stored in converted_selections.
3245 Separate the XChangeProperty and SelectionNotify steps.
3246 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3247 (x_convert_selection): New function.
3248 (x_handle_selection_event): Simplify.
3249 (x_get_foreign_selection): Don't ignore incoming requests while
3250 waiting for an answer; this will fail when we implement
3251 SAVE_TARGETS, and seems unnecessary anyway.
3252 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3253 (Vx_sent_selection_functions): Doc fix.
3255 2011-05-26 Leo Liu <sdl.web@gmail.com>
3257 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3259 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3261 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3263 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3264 for fringe update if it has periodic bitmap.
3265 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3266 and fringe_bitmap_periodic_p.
3268 * fringe.c (get_fringe_bitmap_data): New function.
3269 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3270 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3271 row. Mark glyph row for fringe update if periodicity changed.
3273 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3274 for fringe update unless it has periodic bitmap.
3276 2011-05-25 Kenichi Handa <handa@m17n.org>
3278 * xdisp.c (get_next_display_element): Set correct it->face_id for
3279 a static composition.
3281 2011-05-24 Leo Liu <sdl.web@gmail.com>
3284 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3286 * fns.c (crypto_hash_function, Fsha1): New function.
3287 (Fmd5): Use crypto_hash_function.
3288 (syms_of_fns): Add Ssha1.
3290 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3292 * gnutls.c: Remove unused macros.
3293 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3294 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3295 Remove macros that are defined and never used.
3296 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3298 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3300 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3301 (Fx_get_selection_internal): Minor cleanup.
3302 (Fx_own_selection_internal): Rename arguments for consistency with
3305 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3307 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3309 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3311 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3313 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3315 * dispnew.c (scrolling_window): Don't exclude the case that the
3316 last enabled row in the desired matrix touches the bottom boundary.
3318 2011-05-21 Glenn Morris <rgm@gnu.org>
3320 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3321 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3322 and add some more files.
3324 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3326 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3327 report_file_error introduced by the change from 2011-05-07.
3329 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3331 * systime.h (Time): Define only if emacs is defined.
3332 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3333 where the include path doesn't have X11/X.h by default. See
3334 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3336 2011-05-20 Kenichi Handa <handa@m17n.org>
3338 * composite.c (find_automatic_composition): Fix previous change.
3340 2011-05-20 Glenn Morris <rgm@gnu.org>
3342 * lisp.mk: New file, split from Makefile.in.
3343 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3344 (shortlisp): Remove.
3345 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3347 2011-05-19 Glenn Morris <rgm@gnu.org>
3349 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3350 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3351 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3352 (lisp): Set the order to that of loadup.el.
3353 (shortlisp): Make it a copy of $lisp.
3354 (SOME_MACHINE_LISP): Remove.
3355 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3356 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3358 2011-05-18 Kenichi Handa <handa@m17n.org>
3360 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3361 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3362 (find_automatic_composition): Mostly rewrite for efficiency.
3364 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3366 * makefile.w32-in: Update dependencies.
3368 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3370 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3371 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3373 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3375 Fix some integer overflow issues, such as string length overflow.
3377 * insdel.c (count_size_as_multibyte): Check for string overflow.
3379 * character.c (lisp_string_width): Check for string overflow.
3380 Use EMACS_INT, not int, for string indexes and lengths; in
3381 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3382 the resulting string length overflows an EMACS_INT; instead,
3383 report a string overflow if no precision given. When checking for
3384 precision exhaustion, use a check that cannot possibly have
3385 integer overflow. (Bug#8675)
3386 * character.h (lisp_string_width): Adjust to new signature.
3388 * alloc.c (string_overflow): New function.
3389 (Fmake_string): Use it. This doesn't change behavior, but saves
3390 a few bytes and will simplify future changes.
3391 * character.c (string_escape_byte8): Likewise.
3392 * lisp.h (string_overflow): New decl.
3394 Fixups, following up to the user-interface timestamp change.
3395 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3396 for UI timestamps, instead of unsigned long.
3397 * msdos.c (mouse_get_pos): Likewise.
3398 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3399 * w32gui.h (Time): Define by including "systime.h" rather than by
3400 declaring it ourselves. (Bug#8664)
3402 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3403 * image.c (clear_image_cache): Likewise.
3405 * term.c (term_mouse_position): Don't assume time_t wraparound.
3407 Be more systematic about user-interface timestamps.
3408 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3409 and sometimes 'EMACS_UINT', to represent these timestamps.
3410 This change causes it to use 'Time' uniformly, as that's what X uses.
3411 This makes the code easier to follow, and makes it easier to catch
3412 integer overflow bugs such as Bug#8664.
3413 * frame.c (Fmouse_position, Fmouse_pixel_position):
3414 Use Time, not unsigned long, for user-interface timestamps.
3415 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3416 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3417 * keyboard.h (last_event_timestamp): Likewise.
3418 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3419 * menu.h (xmenu_show): Likewise.
3420 * term.c (term_mouse_position): Likewise.
3421 * termhooks.h (struct input_event.timestamp): Likewise.
3422 (struct terminal.mouse_position_hook): Likewise.
3423 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3424 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3425 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3426 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3428 * menu.h, termhooks.h: Include "systime.h", for Time.
3430 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3431 Don't assume that the difference between two unsigned long values
3432 can fit into an integer. At this point, we know button_down_time
3433 <= event->timestamp, so the difference must be nonnegative, so
3434 there's no need to cast the result if double-click-time is
3435 nonnegative, as it should be; check that it's nonnegative, just in
3436 case. This bug is triggered when events are more than 2**31 ms
3437 apart (about 25 days). (Bug#8664)
3439 * xselect.c (last_event_timestamp): Remove duplicate decl.
3440 (x_own_selection): Remove needless cast to unsigned long.
3442 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3443 that always fit in int. Use a sentinel instead of a counter, to
3444 avoid a temp and to allay GCC's concerns about possible int overflow.
3445 * frame.h (struct frame): Use int for menu_bar_items_used
3446 instead of EMACS_INT, since it always fits in int.
3448 * menu.c (grow_menu_items): Check for int overflow.
3450 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3452 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3453 Before, the code was not consistent. These values cannot exceed
3454 2**31 - 1 so there's no need to make them unsigned.
3455 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3456 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3457 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3459 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3461 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3462 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3463 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3464 presumably because the widths might not match.
3466 * window.c (size_window): Avoid needless test at loop start.
3468 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3470 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3472 2011-05-12 Drew Adams <drew.adams@oracle.com>
3474 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3476 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3478 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3479 `width' to `bar_area_x' and `bar_area_width', respectively.
3480 (x_scroll_run): Take account of fringe background extension.
3482 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3483 Rename local vars `left' and `width' to `bar_area_x' and
3484 `bar_area_width', respectively.
3485 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3486 background extension.
3488 2011-05-10 Jim Meyering <meyering@redhat.com>
3490 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3492 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3494 * image.c (Finit_image_library): Return t for built-in image types,
3495 like pbm and xbm. (Bug#8640)
3497 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3499 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3501 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3503 * w32console.c (Fset_screen_color): Doc fix.
3504 (Fget_screen_color): New function.
3505 (syms_of_ntterm): Defsubr it.
3507 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3508 unlink the temporary file if Fcall_process didn't create it in the
3510 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3511 child process will be redirected to a file specified with `:file'.
3512 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3513 cue to call_process_cleanup not to close that handle.
3515 2011-05-07 Ben Key <bkey76@gmail.com>
3517 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3518 one of two shell specific rules, either bootstrap-temacs-CMD or
3519 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3520 to the previous implementation of the bootstrap-temacs rule.
3521 The bootstrap-temacs-CMD rule is similar to the previous
3522 implementation of the bootstrap-temacs rule except that it
3523 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3526 These changes, along with some changes to nt/configure.bat,
3527 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3528 earlier fix to add support for --cflags and --ldflags options
3529 that include quotes so that it works whether make uses cmd or
3532 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3534 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3535 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3537 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3538 a string. Handle both cases.
3539 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3540 (Fdbus_register_method): Use Qinvalid_function.
3542 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3544 * makefile.w32-in: Update dependencies.
3545 (LISP_H): Add inttypes.h and stdin.h.
3546 (PROCESS_H): Add unistd.h.
3548 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3550 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3551 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3553 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3555 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3557 * term.c (vfatal): Remove stray call to va_end.
3558 It's not needed and the C Standard doesn't allow it here anyway.
3560 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3561 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3563 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3566 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3568 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3570 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3572 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3574 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3576 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3577 * charset.c (Fdefine_charset_internal): Don't initialize
3578 charset.code_space[15]. The value was garbage, on hosts with
3579 32-bit int (Bug#8600).
3581 * lread.c (read_integer): Be more consistent with string-to-number.
3582 Use string_to_number to do the actual conversion; this avoids
3583 rounding errors and fixes some other screwups. Without this fix,
3584 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3585 (digit_to_number): Move earlier, for benefit of read_integer.
3586 Return -1 if the digit is out of range for the base, -2 if it is
3587 not a digit in any supported base. (Bug#8602)
3589 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3591 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3592 to match comment at start of function. This also removes a
3593 GCC warning about overflow in a 32+64-bit port.
3595 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3597 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3598 Reported by Stefan Monnier in
3599 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3600 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3601 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3603 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3604 (EMACS_UINTPTR): Likewise, with uintptr_t.
3606 * lisp.h: Prefer 64-bit EMACS_INT if available.
3607 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3608 on 32-bit hosts that have 64-bit int, so that they can access
3610 However, temporarily disable this change unless the temporary
3611 symbol WIDE_EMACS_INT is defined.
3613 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3615 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3616 This removes an assumption that EMACS_INT and long are the same
3617 width as pointers. The assumption is true for Emacs porting targets
3618 now, but we want to make other targets possible.
3619 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3620 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3621 In the rest of the code, change types of integers that hold casted
3622 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3623 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3624 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3625 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3626 No need to cast type when ORing.
3627 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3628 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3629 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3630 assume EMACS_INT is the same width as char *.
3631 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3632 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3633 Remove no-longer-needed casts.
3634 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3635 (xg_tool_bar_help_callback, xg_make_tool_item):
3636 Use EMACS_INTPTR to hold an integer
3637 that will be cast to void *; this can avoid a GCC warning
3638 if EMACS_INT is not the same width as void *.
3639 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3640 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3641 (current_message_1, set_message_1):
3642 Use a local to convert to proper width without a cast.
3643 * xmenu.c (dialog_selection_callback): Likewise.
3645 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3646 Also, don't assume VALBITS / RAND_BITS is less than 5,
3647 and don't rely on undefined behavior when shifting a 1 left into
3649 * lisp.h (get_random): Change signature to match.
3651 * lread.c (hash_string): Use size_t, not int, for hash computation.
3652 Normally we prefer signed values; but hashing is special, because
3653 it's better to use unsigned division on hash table sizes so that
3654 the remainder is nonnegative. Also, size_t is the natural width
3655 for hashing into memory. The previous code used 'int', which doesn't
3656 retain enough info to hash well into very large tables.
3657 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3659 * dbusbind.c: Don't possibly lose pointer info when converting.
3660 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3661 Use XPNTR rather than XHASH, so that the high-order bits of
3662 the pointer aren't lost when converting through void *.
3664 * eval.c (Fautoload): Don't double-shift a pointer.
3666 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3668 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3670 * gnutls.c (DEF_GNUTLS_FN):
3671 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3673 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3675 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3678 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3680 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3681 New version that can reserve upto 2GB of heap space.
3683 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3685 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3687 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3689 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3690 `gnutls_certificate_set_x509_key_file'.
3692 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3694 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3695 Update dependencies.
3697 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3699 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3700 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3701 Remove unused parameter `fildes'.
3702 * process.c (read_process_output, send_process): Don't pass it.
3704 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3706 Fix previous change: the library cache is defined in w32.c.
3707 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3708 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3710 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3712 Implement dynamic loading of GnuTLS on Windows.
3714 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3715 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3716 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3719 * gnutls.c (Qgnutls_dll): Define.
3720 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3721 (gnutls_*): Declare function pointers.
3722 (init_gnutls_functions): New function to initialize function pointers.
3723 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3724 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3725 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3726 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3727 (emacs_gnutls_write, emacs_gnutls_read)
3728 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3729 (Fgnutls_available_p): New function.
3730 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3731 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3732 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3734 * image.c: Include w32.h.
3735 (Vimage_type_cache): Delete.
3736 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3737 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3738 (w32_delayed_load): Move to w32.c.
3740 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3742 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3743 (w32_delayed_load): Move from image.c. When loading a library, record
3744 its filename in the :loaded-from property of the library id.
3745 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3746 Initialize and staticpro them.
3747 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3749 * process.c: Include lisp.h before w32.h, not after.
3750 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3751 instead of gnutls_record_check_pending.
3753 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3755 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3757 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3758 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3761 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3763 * xterm.c (x_set_frame_alpha): Do not set property on anything
3764 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3766 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3768 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3770 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3772 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3773 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3774 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3775 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3776 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3777 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3778 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3779 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3780 (Qgnutls_bootprop_callbacks_verify): Make static.
3782 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3784 * callproc.c: Indentation fixup.
3786 * sysdep.c (wait_for_termination_1): Make static.
3787 (wait_for_termination, interruptible_wait_for_termination):
3788 Move after wait_for_termination_1.
3790 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3792 * sysdep.c (interruptible_wait_for_termination): New function
3793 which is like wait_for_termination, but allows keyboard
3796 * callproc.c (Fcall_process): Add (:file "file") as an option for
3798 (Fcall_process_region): Ditto.
3800 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3802 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3803 rather than `XVECTOR (FOO)->size'.
3805 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3806 inttypes.h, as a gnulib replacement is used if it not available in
3809 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3811 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3812 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3813 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3815 * coding.c (coding_alloc_by_realloc): Error out if destination
3816 will grow beyond MOST_POSITIVE_FIXNUM.
3817 (decode_coding_emacs_mule): Abort if there isn't enough place in
3818 charbuf for the composition carryover bytes. Reserve an extra
3819 space for up to 2 characters produced in a loop.
3820 (decode_coding_iso_2022): Abort if there isn't enough place in
3821 charbuf for the composition carryover bytes.
3823 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3825 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3826 aborting when %lld or %lll format is passed.
3827 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3828 %llo or %llx format is passed. (Bug#8545)
3830 * window.c (window_scroll_line_based): Use a marker instead of
3831 simple variables to record original value of point. (Bug#7952)
3833 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3834 produced by %s or %c overflows available buffer space. (Bug#8545)
3836 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3838 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3839 (SIZE_MAX): Move defn after all includes, as they might #define it.
3841 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3843 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3845 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3847 * keyboard.c (Qdelayed_warnings_hook): Define.
3848 (command_loop_1): Run `delayed-warnings-hook'
3849 if Vdelayed_warnings_list is non-nil.
3850 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3851 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3853 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3855 * doprnt.c (doprnt): Don't return value smaller than the buffer
3856 size if the message was truncated. (Bug#8545).
3858 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3860 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3861 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3863 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3865 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3867 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3869 * makefile.w32-in: Update dependencies.
3871 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3873 Improve `doprnt' and its usage. (Bug#8545)
3874 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3875 `format_end'. Remove support for %l as a conversion specifier.
3876 Don't use xrealloc. Improve diagnostics when the %l size modifier
3877 is used. Update the commentary.
3879 * eval.c (verror): Simplify calculation of size_t.
3881 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3884 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3886 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3889 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3891 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3892 This makes this file independent of the recent pseudovector change.
3894 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3896 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3898 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3899 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3900 Remove unused local.
3901 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3903 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3904 GCC 4.6.0 optimizes based on type-based alias analysis.
3905 For example, if b is of type struct buffer * and v of type struct
3906 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3907 != &v->size, and therefore "v->size = 1; b->size = 2; return
3908 v->size;" must therefore return 1. This assumption is incorrect
3909 for Emacs, since it type-puns struct Lisp_Vector * with many other
3910 types. To fix this problem, this patch adds a new type struct
3911 vectorlike_header that documents the constraints on layout of vectors
3912 and pseudovectors, and helps optimizing compilers not get fooled
3913 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3914 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3915 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3917 (XSETPVECTYPE): Rewrite in terms of new macro.
3918 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3919 This is a bit clearer, and further avoids the possibility of
3920 undesirable aliasing.
3921 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3922 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3923 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3924 since Lisp_Subr is a special case (no "next" field).
3925 (ASIZE): Now uses header.size rather than size.
3926 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3927 to avoid the hassle of writing XVECTOR (foo)->header.size.
3928 (struct vectorlike_header): New type.
3929 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3930 object, to help avoid aliasing.
3931 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3932 (SUBRP): Likewise, since Lisp_Subr is a special case.
3933 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3934 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3935 (struct Lisp_Hash_Table): Combine first two members into a single
3936 struct vectorlike_header member. All uses of "size" and "next" members
3937 changed to be "header.size" and "header.next".
3938 * buffer.h (struct buffer): Likewise.
3939 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3940 * frame.h (struct frame): Likewise.
3941 * process.h (struct Lisp_Process): Likewise.
3942 * termhooks.h (struct terminal): Likewise.
3943 * window.c (struct save_window_data, struct saved_window): Likewise.
3944 * window.h (struct window): Likewise.
3945 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3946 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3947 * buffer.c (init_buffer_once): Likewise.
3948 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3950 * process.c (Fformat_network_address): Use local var for size,
3953 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3955 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3956 * data.c (atof): Remove decl; no longer used or needed.
3957 (digit_to_number): Move to lread.c.
3958 (Fstring_to_number): Use new string_to_number function, to be
3959 consistent with how the Lisp reader treats infinities and NaNs.
3960 Do not assume that floating-point numbers represent EMACS_INT
3961 without losing information; this is not true on most 64-bit hosts.
3962 Avoid double-rounding errors, by insisting on integers when
3963 parsing non-base-10 numbers, as the documentation specifies.
3964 * lisp.h (string_to_number): New decl, replacing ...
3965 (isfloat_string): Remove.
3966 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3967 (read1): Do not accept +. and -. as integers; this
3968 appears to have been a coding error. Similarly, do not accept
3969 strings like +-1e0 as floating point numbers. Do not report
3970 overflow for integer overflows unless the base is not 10 which
3971 means we have no simple and reliable way to continue.
3972 Break out the floating-point parsing into a new
3973 function string_to_number, so that Fstring_to_number parses
3974 floating point numbers consistently with the Lisp reader.
3975 (digit_to_number): Move here from data.c. Make it static inline.
3976 (E_CHAR, EXP_INT): Remove, replacing with ...
3977 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3978 (string_to_number): New function, replacing isfloat_string.
3979 This function checks for valid syntax and produces the resulting
3980 Lisp float number too. Rework it so that string-to-number
3981 no longer mishandles examples like "1.0e+". Use strtoumax,
3982 so that overflow for non-base-10 numbers is reported only when
3983 there's no portable and simple way to convert to floating point.
3985 * textprop.c (set_text_properties_1): Rewrite for clarity,
3986 and to avoid GCC warning about integer overflow.
3988 * intervals.h (struct interval): Use EMACS_INT for members
3989 where EMACS_UINT might cause problems. See
3990 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3991 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3992 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3994 (offset_intervals): Tell GCC not to worry about length overflow
3995 when negating a negative length.
3997 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3998 (overrun_check_free): Likewise.
4000 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4001 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4004 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4005 (gnutls_make_error): Rename local to avoid shadowing.
4006 (gnutls_emacs_global_deinit): ifdef out; not used.
4007 (Fgnutls_boot): Use const for pointer to readonly storage.
4008 Comment out unused local. Fix pointer signedness problems.
4010 * lread.c (openp): Don't stuff size_t into an 'int'.
4011 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4012 about possible signed overflow.
4014 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4015 (GDK_KEY_g): Don't define if already defined.
4016 (xg_prepare_tooltip): Avoid pointer signedness problem.
4017 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4019 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4020 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4022 * xfns.c (Fx_window_property): Simplify a bit,
4023 to make a bit faster and to avoid GCC 4.6.0 warning.
4024 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4026 * fns.c (internal_equal): Don't assume size_t fits in int.
4028 * alloc.c (compact_small_strings): Tighten assertion a little.
4030 Replace pEd with more-general pI, and fix some printf arg casts.
4031 * lisp.h (pI): New macro, generalizing old pEd macro to other
4032 conversion specifiers. For example, use "...%"pI"d..." rather
4033 than "...%"pEd"...".
4034 (pEd): Remove. All uses replaced with similar uses of pI.
4035 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4036 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4037 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4038 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4039 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4040 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4041 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4043 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4044 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4045 * print.c (safe_debug_print, print_object): Likewise.
4046 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4048 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4049 avoiding the 0 flag, which is not portable.
4050 * process.c (Fmake_network_process): Use pI to avoid cast.
4051 * region-cache.c (pp_cache): Likewise.
4052 * xdisp.c (decode_mode_spec): Likewise.
4053 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4054 behavior on 64-bit hosts with printf arg.
4055 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4056 (x_stop_queuing_selection_requests): Likewise.
4057 (x_get_window_property): Don't truncate byte count to an 'int'
4060 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4061 here, since it parses constructs like leading '-' and spaces,
4062 which are not wanted; and it overflows with large numbers.
4063 Instead, simply match F[0-9]+, which is what is wanted anyway.
4065 * alloc.c: Remove unportable assumptions about struct layout.
4066 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4067 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4068 (allocate_vectorlike, make_pure_vector): Use the new macros,
4069 plus offsetof, to remove unportable assumptions about struct layout.
4070 These assumptions hold on all porting targets that I know of, but
4071 they are not guaranteed, they're easy to remove, and removing them
4072 makes further changes easier.
4074 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4075 This doesn't fix a bug but makes the code clearer.
4076 (string_overrun_cookie): Now const. Use initializers that
4077 don't formally overflow signed char, to avoid warnings.
4078 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4079 can cause Emacs to crash when string overrun checking is enabled.
4080 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4081 multiple of sizeof (EMACS_INT); it need not be, if
4082 alignof(EMACS_INT) < sizeof (EMACS_INT).
4083 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4085 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4087 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4089 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4091 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4092 supposed to be handshaking. (Bug#8556)
4093 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4095 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4097 * lisp.h (Qdebug): List symbol.
4098 * eval.c (Qdebug): Restore global linkage.
4099 * keyboard.c (debug-on-event): New variable.
4100 (handle_user_signal): Break into debugger when debug-on-event
4101 matches the current signal symbol.
4103 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4105 * alloc.c (check_sblock, check_string_bytes)
4106 (check_string_free_list): Convert to standard C.
4108 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4110 * w32.c (emacs_gnutls_push): Fix typo.
4112 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4114 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4115 "cast to pointer from integer of different size".
4117 Improve doprnt and its use in verror. (Bug#8545)
4118 * doprnt.c (doprnt): Document the set of format control sequences
4119 supported by the function. Use SAFE_ALLOCA instead of always
4122 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4123 is one byte too soon. Don't use xrealloc; instead xfree and
4126 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4128 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4131 * gnutls.c: Renamed global_initialized to
4132 gnutls_global_initialized. Added internals for the
4133 :verify-hostname-error, :verify-error, and :verify-flags
4134 parameters of `gnutls-boot' and documented those parameters in the
4135 docstring. Start callback support.
4136 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4137 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4138 on error. Return error code.
4139 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4140 (emacs_gnutls_read): Likewise.
4141 (Fgnutls_boot): Return handshake error code.
4142 (emacs_gnutls_handle_error): New function.
4143 (wsaerror_to_errno): Likewise.
4145 * w32.h (emacs_gnutls_pull): Add prototype.
4146 (emacs_gnutls_push): Likewise.
4148 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4149 (emacs_gnutls_push): Likewise.
4151 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4153 * process.c (wait_reading_process_output): Check if GnuTLS
4154 buffered some data internally if no FDs are set for TLS
4157 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4158 (LIBS): Link to USER_LIBS.
4159 ($(BLD)/gnutls.$(0)): New target.
4161 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4163 * xdisp.c (handle_single_display_spec): Rename the
4164 display_replaced_before_p argument into display_replaced_p, to
4165 make it consistent with the commentary. Fix typos in the
4168 * textprop.c (syms_of_textprop): Remove dead code.
4169 (copy_text_properties): Delete obsolete commentary about an
4170 interface that was deleted long ago. Fix typos in the description
4173 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4174 to changes in oldXMenu/XMenu.h from 2011-04-16.
4175 <menu_help_message, prev_menu_help_message>: Constify.
4176 (IT_menu_make_room): menu->help_text is now `const char **';
4179 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4180 to changes in oldXMenu/XMenu.h from 2011-04-16.
4181 (struct XMenu): Declare `help_text' `const char **'.
4183 * xfaces.c <Qunspecified>: Make extern again.
4185 * syntax.c: Include sys/types.h before including regex.h, as
4188 * doc.c (get_doc_string): Improve the format passed to `error'.
4190 * doprnt.c (doprnt): Improve commentary.
4192 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4194 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4197 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4198 changes in globals.h immediately force recompilation.
4199 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4200 $(CURDIR)/s/ms-w32.h.
4201 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4203 * character.c (Fchar_direction): Function deleted.
4204 (syms_of_character): Don't defsubr it.
4205 <char-direction-table>: Deleted.
4207 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4209 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4210 * doprnt.c: Include limits.h.
4211 (SIZE_MAX): New macro.
4212 (doprnt): Return a size_t value. 2nd arg is now size_t.
4213 Many local variables are now size_t instead of int or unsigned.
4214 Improve overflow protection. Support `l' modifier for integer
4215 conversions. Support %l conversion. Don't assume an EMACS_INT
4216 argument for integer conversions and for %c.
4218 * lisp.h (doprnt): Restore prototype.
4220 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4223 * Makefile.in (base_obj): Add back doprnt.o.
4225 * deps.mk (doprnt.o): Add back prerequisites.
4226 (callint.o): Depend on character.h.
4228 * eval.c (internal_lisp_condition_case): Include the handler
4229 representation in the error message.
4230 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4231 when breaking from the loop.
4233 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4235 * callint.c (Fcall_interactively): When displaying error message
4236 about invalid control letter, pass the character's codepoint, not
4237 a pointer to its multibyte form. Improve display of the character
4238 in octal and display also its hex code.
4240 * character.c (char_string): Use %x to display the (unsigned)
4241 codepoint of an invalid character, to avoid displaying a bogus
4244 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4245 `error', not SYMBOL_NAME itself.
4247 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4248 character arguments to `error'.
4250 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4251 to `error' in error message about FINAL_CHAR argument. Make sure
4252 FINAL_CHAR is a character, and use %c when it is passed as
4253 argument to `error'.
4255 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4257 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4259 * w32.c: Include <time.h>.
4260 (sys_localtime): New function.
4262 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4264 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4266 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4268 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4270 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4273 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4275 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4276 gl_state.e_property when gl_state.object is Qt.
4278 * insdel.c (make_gap_larger): Remove limitation of buffer size
4281 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4283 * xdisp.c (lookup_glyphless_char_display)
4284 (produce_glyphless_glyph): Handle cons cell entry in
4285 glyphless-char-display.
4286 (Vglyphless_char_display): Document it.
4288 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4289 glyphless-char-display.
4291 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4293 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4295 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4297 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4298 definition for no-X builds.
4300 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4302 Static checks with GCC 4.6.0 and non-default toolkits.
4304 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4306 * process.c (keyboard_bit_set): Define only if SIGIO.
4307 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4308 (send_process): Repair possible setjmp clobbering.
4310 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4312 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4314 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4316 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4317 Define only if needed.
4319 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4320 by pacifying GCC about it. Maybe it's time to retire it?
4321 * xfaces.c (USG, __TIMEVAL__): Likewise.
4323 * dispextern.h (struct redisplay_interface): Rename param
4325 * termhooks.h (struct terminal): Likewise.
4326 * xterm.c (xembed_send_message): Likewise.
4328 * insdel.c (make_gap_smaller): Define only if
4329 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4331 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4334 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4335 so that we aren't warned about unused symbols.
4337 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4339 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4341 * xfns.c (x_real_positions): Mark locals as initialized.
4343 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4345 * xterm.c: Fix problems found by static analysis with other toolkits.
4346 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4347 (x_dispatch_event): Declare static if USE_GTK, and
4348 define if USE_GTK || USE_X_TOOLKIT.
4349 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4350 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4351 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4352 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4354 * xmenu.c (menu_help_callback): Pointer type fixes.
4355 Use const pointers when pointing at readonly data. Avoid pointer
4357 (FALSE): Remove unused macro.
4358 (update_frame_menubar): Remove unused decl.
4360 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4362 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4363 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4364 (single_menu_item): Rename local to avoid shadowing.
4366 * keyboard.c (make_lispy_event): Remove unused local var.
4368 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4369 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4371 * bitmaps: Change bitmaps from unsigned char back to the X11
4372 compatible char. Avoid the old compiler warnings about
4373 out-of-range initializers by using, for example, '\xab' rather
4376 * xgselect.c (xgselect_initialize): Check vs interface
4377 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4379 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4381 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4382 to read-only memory.
4384 * fns.c (vector): Remove; this old hack is no longer needed.
4386 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4388 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4390 * xrdb.c (x_load_resources): Omit unused local.
4392 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4393 (x_window): Rename locals to avoid shadowing.
4394 (USG): Use the kludged USG macro, to pacify gcc.
4396 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4397 (x_term_init): Remove local to avoid shadowing.
4399 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4401 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4402 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4404 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4406 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4408 Fix regex.c, syntax.c and friends for buffers > 2GB.
4409 * syntax.h (struct gl_state_s): Declare character position members
4412 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4414 * textprop.c (verify_interval_modification, interval_of):
4415 Declare arguments EMACS_INT.
4417 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4420 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4422 * indent.c (Fvertical_motion): Local variable it_start is now
4425 * regex.c (re_match, re_match_2, re_match_2_internal)
4426 (bcmp_translate, regcomp, regexec, print_double_string)
4427 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4428 (re_compile_pattern, re_exec): Declare arguments and local
4429 variables `size_t' and `ssize_t' and return values `regoff_t', as
4431 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4432 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4433 <compile_stack_type>: `size' and `avail' are now `size_t'.
4435 * regex.h <regoff_t>: Use ssize_t, not int.
4436 (re_search, re_search_2, re_match, re_match_2): Arguments that
4437 specify buffer/string position and length are now ssize_t and
4438 size_t. Return type is regoff_t.
4440 2011-04-16 Ben Key <bkey76@gmail.com>
4442 * nsfont.m: Fixed bugs in ns_get_family and
4443 ns_descriptor_to_entity that were caused by using free to
4444 deallocate memory blocks that were allocated by xmalloc (via
4445 xstrdup). This caused Emacs to crash when compiled with
4446 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4447 --enable-checking=xmallocoverrun). xfree is now used to
4448 deallocate these memory blocks.
4450 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4452 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4454 emacs_write: Accept and return EMACS_INT for sizes.
4455 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4457 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4458 Accept and return EMACS_INT.
4459 (emacs_gnutls_write): Return the number of bytes written on
4461 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4462 (emacs_read, emacs_write): Remove check for negative size, as the
4463 Emacs source code has been audited now.
4464 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4465 (emacs_read, emacs_write): Use it.
4466 * process.c (send_process): Adjust to the new signatures of
4467 emacs_write and emacs_gnutls_write. Do not attempt to store
4468 a byte offset into an 'int'; it might overflow.
4469 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4471 * sound.c: Don't assume sizes fit in 'int'.
4472 (struct sound_device.period_size, alsa_period_size):
4473 Return EMACS_INT, not int.
4474 (struct sound_device.write, vox_write, alsa_write):
4475 Accept EMACS_INT, not int.
4476 (wav_play, au_play): Use EMACS_INT to store sizes and to
4477 record read return values.
4479 2011-04-15 Ben Key <bkey76@gmail.com>
4481 * keyboard.c (Qundefined): Don't declare static since it is used
4483 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4484 static since they are used in nsfont.m.
4486 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4488 * process.c (Qprocessp): Don't declare static.
4489 * lisp.h (Qprocessp): Declare again.
4491 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4493 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4495 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4497 Improve C-level modularity by making more things 'static'.
4499 Don't publish debugger-only interfaces to other modules.
4500 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4501 (verify_bytepos, count_markers): Move decls to the only modules
4503 * region-cache.h (pp_cache): Likewise.
4504 * window.h (check_all_windows): Likewise.
4505 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4507 * sysdep.c (croak): Now static, if
4508 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4509 * syssignal.h (croak): Declare only if not static.
4511 * alloc.c (refill_memory_reserve): Now static if
4512 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4513 * lisp.h (refill_memory_reserve): Declare only if not static.
4515 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4516 Define only if USE_LUCID.
4518 * xrdb.c (x_customization_string, x_rm_string): Now static.
4520 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4521 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4523 * xdisp.c (draw_row_with_mouse_face): Now static.
4524 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4526 * window.h (check_all_windows): Mark externally visible.
4528 * window.c (window_deletion_count): Now static.
4530 * undo.c: Make symbols static if they're not exported.
4531 (last_undo_buffer, last_boundary_position, pending_boundary):
4534 * textprop.c (interval_insert_behind_hooks): Now static.
4535 (interval_insert_in_front_hooks): Likewise.
4537 * term.c: Make symbols static if they're not exported.
4538 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4539 (max_frame_lines, tty_set_terminal_modes):
4540 (tty_reset_terminal_modes, tty_turn_off_highlight):
4541 (get_tty_terminal): Now static.
4542 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4543 * termhooks.h (term_mouse_moveto): Do not declare if
4545 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4546 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4548 * sysdep.c: Make symbols static if they're not exported.
4549 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4551 (sigprocmask_set, full_mask): Remove; unused.
4552 (wait_debugging): Mark as visible.
4553 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4554 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4556 * syntax.c (syntax_temp): Define only if !__GNUC__.
4558 * sound.c (current_sound_device, current_sound): Now static.
4560 * search.c (searchbufs, searchbuf_head): Now static.
4562 * scroll.c (scroll_cost): Remove; unused.
4563 * dispextern.h (scroll_cost): Remove decl.
4565 * region-cache.h (pp_cache): Mark as externally visible.
4567 * process.c: Make symbols static if they're not exported.
4568 (process_tick, update_tick, create_process, chan_process):
4569 (Vprocess_alist, proc_buffered_char, datagram_access):
4570 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4571 (deactivate_process): Mark defn as static, as well as decl.
4572 * lisp.h (create_process): Remove decl.
4573 * process.h (chan_process, Vprocess_alist): Remove decls.
4575 * print.c: Make symbols static if they're not exported.
4576 (print_depth, new_backquote_output, being_printed, print_buffer):
4577 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4578 (print_interval, print_number_index, initial_stderr_stream):
4580 * lisp.h (Fprinc): Remove decl.
4581 (debug_output_compilation_hack): Mark as externally visible.
4583 * sysdep.c (croak): Move decl from here to syssignal.h.
4584 * syssignal.h (croak): Put it here, so the API can be checked when
4585 'croak' is called from dissociate_if_controlling_tty.
4587 * minibuf.c: Make symbols static if they're not exported.
4588 (minibuf_save_list, choose_minibuf_frame): Now static.
4589 * lisp.h (choose_minibuf_frame): Remove decl.
4591 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4593 * lread.c: Make symbols static if they're not exported.
4594 (read_objects, initial_obarray, oblookup_last_bucket_number):
4596 (make_symbol): Remove; unused.
4597 * lisp.h (initial_obarray, make_symbol): Remove decls.
4599 * keyboard.c: Make symbols static if they're not exported.
4600 (single_kboard, recent_keys_index, total_keys, recent_keys):
4601 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4602 (this_single_command_key_start, echoing, last_auto_save):
4603 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4604 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4605 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4606 (Vlispy_mouse_stem, double_click_count):
4608 (force_auto_save_soon): Define only if SIGDANGER.
4609 (ignore_mouse_drag_p): Now static if
4610 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4611 (print_help): Remove; unused.
4612 (stop_character, last_timer_event): Mark as externally visible.
4613 * keyboard.h (ignore_mouse_drag_p): Declare only if
4614 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4615 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4616 * lisp.h (echoing): Remove decl.
4617 (force_auto_save_soon): Declare only if SIGDANGER.
4618 * xdisp.c (redisplay_window): Simplify code, to make it more
4619 obvious that ignore_mouse_drag_p is not accessed if !defined
4620 USE_GTK && !defined HAVE_NS.
4622 * intervals.c: Make symbols static if they're not exported.
4623 (merge_properties_sticky, merge_interval_right, delete_interval):
4625 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4627 * insdel.c: Make symbols static if they're not exported.
4628 However, leave prepare_to_modify_buffer alone. It's never
4629 called from outside this function, but that appears to be a bug.
4630 (combine_after_change_list, combine_after_change_buffer):
4631 (adjust_after_replace, signal_before_change): Now static.
4632 (adjust_after_replace_noundo): Remove; unused.
4633 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4634 (signal_before_change): Remove decls.
4636 * indent.c (val_compute_motion, val_vmotion): Now static.
4638 * image.c: Make symbols static if they're not exported.
4639 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4641 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4642 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4644 * fringe.c (standard_bitmaps): Now static.
4645 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4647 * frame.c: Make symbols static if they're not exported.
4648 (x_report_frame_params, make_terminal_frame): Now static.
4649 (get_frame_param): Now static, unless HAVE_NS.
4650 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4651 (x_get_resource_string): Remove; not used.
4652 * frame.h (make_terminal_frame, x_report_frame_params):
4653 (x_get_resource_string); Remove decls.
4654 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4655 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4657 * font.c, fontset.c: Make symbols static if they're not exported.
4658 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4659 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4660 * font.c (font_close_object): Now static.
4661 * font.h (font_close_object): Remove.
4662 * fontset.c (FONTSET_OBJLIST): Remove.
4663 (free_realized_fontset) #if-0 the body, which does nothing.
4664 (face_suitable_for_char_p): #if-0, as it's never called.
4665 * fontset.h (face_suitable_for_char_p): Remove decl.
4666 * xfaces.c (face_at_string_position):
4667 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4668 since 0 is always ASCII.
4670 * fns.c (weak_hash_tables): Now static.
4672 * fileio.c: Make symbols static if they're not exported.
4673 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4674 (Vwrite_region_annotation_buffers): Now static.
4676 * eval.c: Make symbols static if they're not exported.
4677 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4678 * lisp.h (backtrace_list): Remove decl.
4680 * emacs.c: Make symbols static if they're not exported.
4681 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4682 (fatal_error_code, fatal_error_signal_hook, standard_args):
4684 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4685 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4686 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4687 * lisp.h (fatal_error_signal_hook): Remove decl.
4688 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4690 * editfns.c: Move a (normally-unused) function to its only use.
4691 * editfns.c, lisp.h (get_operating_system_release): Remove.
4692 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4693 worth the hassle of breaking this out.
4695 * xterm.c: Make symbols static if they're not exported.
4696 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4697 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4698 (x_destroy_window, x_delete_display):
4700 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4701 (x_mouse_leave): Remove; unused.
4702 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4703 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4704 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4706 (x_mouse_leave): Declare only if WINDOWSNT.
4707 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4708 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4711 * ftxfont.c: Make symbols static if they're not exported.
4712 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4714 * font.h (ftxfont_driver): Likewise.
4716 * xfns.c: Make symbols static if they're not exported.
4717 (x_last_font_name, x_display_info_for_name):
4718 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4719 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4720 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4721 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4722 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4723 (last_show_tip_args): Now static.
4724 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4725 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4726 (x_screen_planes): Remove; unused.
4727 * dispextern.h (x_screen_planes): Remove decl.
4729 * dispnew.c: Make symbols static if they're not exported.
4730 * dispextern.h (redraw_garbaged_frames, scrolling):
4731 (increment_row_positions): Remove.
4732 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4733 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4735 (redraw_garbaged_frames): Remove; unused.
4737 * xfaces.c: Make symbols static if they're not exported.
4738 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4740 * xterm.h (defined_color): Remove decls.
4741 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4742 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4743 (menu_face_changed_default, defined_color, free_realized_face):
4744 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4745 (ascii_face_of_lisp_face): Remove; unused.
4747 * xdisp.c: Make symbols static if they're not exported.
4748 * dispextern.h (scratch_glyph_row, window_box_edges):
4749 (glyph_to_pixel_coords, set_cursor_from_row):
4750 (get_next_display_element, set_iterator_to_next):
4751 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4752 (show_mouse_face): Remove decls
4753 * frame.h (message_buf_print): Likewise.
4754 * lisp.h (pop_message, set_message, check_point_in_composition):
4756 * xterm.h (set_vertical_scroll_bar): Likewise.
4757 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4758 (message_buf_print, scratch_glyph_row, displayed_buffer):
4759 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4760 (get_next_display_element, show_mouse_face, window_box_edges):
4761 (frame_to_window_pixel_xy, check_point_in_composition):
4762 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4763 (glyph_to_pixel_coords): Remove; unused.
4765 * dired.c (file_name_completion): Now static.
4767 * dbusbind.c (xd_in_read_queued_messages): Now static.
4769 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4770 * data.c (circular_list_error): Remove.
4772 * commands.h (last_point_position, last_point_position_buffer):
4773 (last_point_position_window): Remove decls.
4774 * keyboard.c: Make these variables static.
4776 * coding.h (coding, code_convert_region, encode_coding_gap):
4778 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4779 (iso_code_class, detect_coding, code_convert_region): Now static.
4780 (encode_coding_gap): Remove; unused.
4782 * chartab.c (chartab_chars, chartab_bits): Now static.
4784 * charset.h (charset_iso_8859_1): Remove decl.
4785 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4788 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4789 * ccl.c (Vccl_program_table): Now static.
4790 (check_ccl_update): Remove; unused.
4792 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4793 * category.h: ... from here.
4794 * category.c (check_category_table, set_category_set): Now static.
4796 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4797 * lisp.h: Remove these decls.
4799 * buffer.c (buffer_count): Remove unused var.
4801 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4802 so that it's not optimized away.
4803 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4804 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4805 exported only to the debugger.
4807 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4808 * atimer.h (run_all_atimers): Remove; not exported.
4810 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4811 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4812 was inaccessible from Lisp.
4813 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4814 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4816 alloc.c: Import and export fewer symbols, and remove unused items.
4817 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4819 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4820 it's not optimized away by whole-program optimization.
4821 (message_enable_multibyte, free_misc): Remove.
4822 (catchlist, handlerlist, mark_backtrace):
4823 Declare only if BYTE_MARK_STACK.
4824 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4825 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4826 (message_enable_multibyte): Remove decl.
4827 (free_misc, interval_free_list, float_block, float_block_index):
4828 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4829 (cons_free_list, last_marked_index):
4831 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4832 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4833 (mark_backtrace): Define only if BYTE_MARK_STACK.
4834 * xdisp.c (message_enable_multibyte): Now static.
4836 Declare Lisp_Object Q* variables to be 'static' if not exported.
4837 This makes it easier for human readers (and static analyzers)
4838 to see whether these variables are used from other modules.
4839 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4840 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4841 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4842 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4843 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4844 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4845 * xmenu.c, xselect.c:
4846 Declare Q* vars static if they are not used in other modules.
4847 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4848 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4849 Remove decls of unexported vars.
4850 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4852 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4854 Make Emacs functions such as Fatom 'static' by default.
4855 This makes it easier for human readers (and static analyzers)
4856 to see whether these functions can be called from other modules.
4857 DEFUN now defines a static function. To make the function external
4858 so that it can be used in other C modules, use the new macro DEFUE.
4859 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4860 (Finit_image_library):
4861 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4862 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4863 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4864 Remove decls, since these functions are now static.
4865 (Funintern, Fget_internal_run_time): New decls, since these functions
4866 were already external.
4868 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4869 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4870 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4871 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4872 * keyboard.c, keymap.c, lread.c:
4873 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4874 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4875 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4876 Mark functions with DEFUE instead of DEFUN,
4877 if they are used in other modules.
4878 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4879 decls for now-static functions.
4880 * buffer.h (Fdelete_overlay): Remove decl.
4881 * callproc.c (Fgetenv_internal): Mark as internal.
4882 * composite.c (Fremove_list_of_text_properties): Remove decl.
4883 (Fcomposition_get_gstring): New forward static decl.
4884 * composite.h (Fcomposite_get_gstring): Remove decl.
4885 * dired.c (Ffile_attributes): New forward static decl.
4886 * doc.c (Fdocumntation_property): New forward static decl.
4887 * eval.c (Ffetch_bytecode): New forward static decl.
4888 (Funintern): Remove extern decl; now in .h file where it belongs.
4889 * fileio.c (Fmake_symbolic_link): New forward static decl.
4890 * image.c (Finit_image_library): New forward static decl.
4891 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4892 * intervals.h (Fprevious_property_change):
4893 (Fremove_list_of_text_properties): Remove decls.
4894 * keyboard.c (Fthis_command_keys): Remove decl.
4895 (Fcommand_execute): New forward static decl.
4896 * keymap.c (Flookup_key): New forward static decl.
4897 (Fcopy_keymap): Now static.
4898 * keymap.h (Flookup_key): Remove decl.
4899 * process.c (Fget_process): New forward static decl.
4900 (Fprocess_datagram_address): Mark as internal.
4901 * syntax.c (Fsyntax_table_p): New forward static decl.
4902 (skip_chars): Remove duplicate decl.
4903 * textprop.c (Fprevious_property_change): New forward static decl.
4904 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4906 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4907 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4909 * editfns.c (Fformat): Remove unreachable code.
4911 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4913 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4916 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4918 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4919 when at ZV. (Bug#8487)
4921 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4923 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4925 * keyboard.c (parse_tool_bar_item): Likewise.
4926 * sound.c (sound_cleanup, alsa_close): Likewise.
4927 * termcap.c (tgetent): Likewise.
4928 * xfns.c (x_default_font_parameter): Likewise.
4929 * xsettings.c (read_and_apply_settings): Likewise.
4931 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4932 (overrun_check_free): Protoize.
4934 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4936 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4937 since callers should never pass a negative size.
4938 Change the signature to match that of plain 'read' and 'write'; see
4939 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4940 * lisp.h: Update prototypes of emacs_write and emacs_read.
4942 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4944 * xdisp.c (redisplay_window): Don't try to determine the character
4945 position of the scroll margin if the window start point w->startp
4946 is outside the buffer's accessible region. (Bug#8468)
4948 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4950 Fix write-region and its subroutines for buffers > 2GB.
4951 * fileio.c (a_write, e_write): Modify declaration of arguments and
4952 local variables to support buffers larger than 2GB.
4953 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4955 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4956 argument, local variables, and return value.
4958 * lisp.h: Update prototypes of emacs_write and emacs_read.
4960 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4962 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4964 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4966 Fix more problems found by GCC 4.6.0's static checks.
4968 * xdisp.c (vmessage): Use a better test for character truncation.
4970 * charset.c (load_charset_map): <, not <=, for optimization,
4971 and to avoid potential problems with integer overflow.
4972 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4973 * casetab.c (set_identity, shuffle): Likewise.
4974 * editfns.c (Fformat): Likewise.
4975 * syntax.c (skip_chars): Likewise.
4977 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4978 This also lets GCC 4.6.0 generate slightly better loop code.
4980 * callint.c (Fcall_interactively): <, not <=, for optimization.
4981 (Fcall_interactively): Count the number of arguments produced,
4982 not the number of arguments given. This is simpler and lets GCC
4983 4.6.0 generate slightly better code.
4985 * ftfont.c: Distingish more carefully between FcChar8 and char.
4986 The previous code passed unsigned char * to a functions like
4987 strlen and xstrcasecmp that expect char *, which does not
4988 conform to the C standard.
4989 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4990 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4991 char * when the C standard requires it.
4993 * keyboard.c (read_char): Remove unused var.
4995 * eval.c: Port to Windows vsnprintf (Bug#8435).
4997 (SIZE_MAX): Define if the headers do not.
4998 (verror): Do not give up if vsnprintf returns a negative count.
4999 Instead, grow the buffer. This ports to Windows vsnprintf, which
5000 does not conform to C99. Problem reported by Eli Zaretskii.
5001 Also, simplify the allocation scheme, by avoiding the need for
5002 calling realloc, and removing the ALLOCATED variable.
5004 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5006 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5007 But keep the doprint source code for now, as we might revamp it
5008 and use it again (Bug#8435).
5009 * lisp.h (doprnt): Remove.
5010 * Makefile.in (base_obj): Remove doprnt.o.
5011 * deps.mk (doprnt.o): Remove.
5013 error: Print 32- and 64-bit integers portably (Bug#8435).
5014 Without this change, on typical 64-bit hosts error ("...%d...", N)
5015 was used to print both 32- and 64-bit integers N, which relied on
5017 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5019 * lisp.h (error, verror): Mark as printf-like functions.
5020 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5021 Report overflow in size calculations when allocating printf buffer.
5022 Do not truncate output string at its first null byte.
5023 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5024 Truncate the output at a character boundary, since vsnprintf does not
5026 * charset.c (check_iso_charset_parameter): Convert internal
5027 character to string before calling 'error', since %c now has the
5029 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5030 overflow when computing char to be passed to 'error'. Do not
5031 pass Lisp_Object to 'error'; pass the integer instead.
5032 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5033 formatted with plain %d.
5035 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5037 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5039 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5041 * xterm.c (x_catch_errors): Remove duplicate declaration.
5043 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5045 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5047 2011-04-10 Jim Meyering <meyering@redhat.com>
5049 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5050 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5051 return ssize_t not "int", and use size_t as the buffer length.
5052 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5053 * gnutls.h: Update declarations.
5054 * process.c (read_process_output): Use ssize_t, to match.
5055 (send_process): Likewise.
5057 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5059 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5061 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5063 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5064 Use unsigned char, to match FcChar8 type definition.
5066 * xterm.c (handle_one_xevent):
5067 * xmenu.c (create_and_show_popup_menu):
5068 * xselect.c (x_decline_selection_request)
5069 (x_reply_selection_request): Avoid type-punned deref of X events.
5071 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5073 Fix some uses of `int' instead of EMACS_INT.
5074 * search.c (string_match_1, fast_string_match)
5075 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5076 (scan_buffer, find_next_newline_no_quit)
5077 (find_before_next_newline, search_command, Freplace_match)
5078 (Fmatch_data): Make some `int' variables be EMACS_INT.
5080 * xdisp.c (display_count_lines): 3rd argument and return value now
5081 EMACS_INT. All callers changed.
5082 (pint2hrstr): Last argument is now EMACS_INT.
5084 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5085 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5086 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5087 (decode_coding_utf_16, decode_coding_emacs_mule)
5088 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5089 (decode_coding_ccl, decode_coding_charset)
5090 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5091 (decode_coding_iso_2022, decode_coding_emacs_mule)
5092 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5093 <char_offset, last_offset>: Declare EMACS_INT.
5094 (encode_coding_utf_8, encode_coding_utf_16)
5095 (encode_coding_emacs_mule, encode_invocation_designation)
5096 (encode_designation_at_bol, encode_coding_iso_2022)
5097 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5098 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5100 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5101 (encode_invocation_designation): Last argument P_NCHARS is now
5103 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5104 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5106 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5109 * ccl.c (Fccl_execute_on_string): Declare some variables
5112 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5114 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5116 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5118 * process.c (Fformat_network_address): Doc fix.
5120 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5122 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5124 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5126 * keyboard.c (read_char): Call Lisp function help-form-show,
5127 instead of using internal_with_output_to_temp_buffer.
5128 (Qhelp_form_show): New var.
5129 (syms_of_keyboard): Use DEFSYM macro.
5131 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5133 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5135 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5137 * process.c (Flist_processes): Remove to Lisp.
5138 (list_processes_1): Delete.
5140 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5142 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5144 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5146 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5148 Fix more problems found by GCC 4.6.0's static checks.
5150 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5152 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5154 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5156 * xdisp.c (vmessage): Mark as a printf-like function.
5158 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5160 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5162 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5163 printf-like functions.
5164 (tiff_load): Add casts to remove these marks before passing them
5165 to system-supplied API.
5167 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5169 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5170 This avoids several warnings with gcc -Wstrict-overflow.
5171 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5172 directly, rather than having caller test rule sign. This avoids
5173 some unnecessary tests.
5174 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5175 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5176 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5178 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5179 (xfont_open): Avoid unnecessary tests.
5181 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5183 * composite.h, composite.c (composition_gstring_put_cache):
5184 Use EMACS_INT, not int, for length.
5186 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5187 breaking out part of COMPOSITION_DECODE_RULE.
5188 (COMPOSITION_DECODE_RULE): Use it.
5189 * composite.c (get_composition_id): Remove unused local vars,
5190 by using the new macro.
5192 * textprop.c (set_text_properties_1): Change while to do-while,
5193 since the condition is always true at first.
5195 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5196 (interval_deletion_adjustment): Return unsigned value.
5199 * process.c (list_processes_1, create_pty, read_process_output):
5200 (exec_sentinel): Remove vars that were set but not used.
5201 (create_pty): Remove unnecessary "volatile"s.
5202 (Fnetwork_interface_info): Avoid possibility of int overflow.
5203 (read_process_output): Do adaptive read buffering even if carryover.
5204 (read_process_output): Simplify nbytes computation if buffered.
5206 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5208 * syntax.c (scan_words): Remove var that was set but not used.
5209 (update_syntax_table): Use unsigned instead of int.
5211 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5212 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5213 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5215 * print.c (print_error_message): Avoid int overflow.
5217 * font.c (font_list_entities): Redo for clarity,
5218 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5220 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5221 (font_score): Avoid potential overflow in diff calculation.
5223 * fns.c (substring_both): Remove var that is set but not used.
5224 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5226 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5228 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5229 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5230 can always succeed if overflow has undefined behavior.
5232 * search.c (boyer_moore, wordify): Remove vars set but not used.
5233 (wordify): Omit three unnecessary tests.
5235 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5236 All callers changed. This avoids the need for an unused var.
5238 * casefiddle.c (casify_region): Remove var that is set but not used.
5240 * dired.c (file_name_completion): Remove var that is set but not used.
5242 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5244 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5245 (Finsert_file_contents): Remove unnecessary code checking fd.
5247 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5248 Check for integer overflow on size calculations.
5250 * buffer.c (Fprevious_overlay_change): Remove var that is set
5253 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5254 Remove vars that are set but not used.
5255 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5256 (timer_check_2): Mark vars as initialized.
5258 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5260 * image.c (lookup_image): Remove var that is set but not used.
5261 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5263 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5264 that are set but not used.
5266 * xfns.c (make_invisible_cursor): Don't return garbage
5267 if XCreateBitmapFromData fails (Bug#8410).
5269 * xselect.c (x_get_local_selection, x_handle_property_notify):
5270 Remove vars that are set but not used.
5272 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5273 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5275 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5276 Remove var that is set but not used.
5277 (scroll_bar_windows_size): Now size_t, not int.
5278 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5281 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5282 (map_tty_color) [!defined MSDOS]: Likewise.
5284 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5286 * coding.c: Remove vars that are set but not used.
5287 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5288 All callers changed.
5289 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5290 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5291 (decode_coding_charset): Remove vars that are set but not used.
5293 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5294 that is set but not used.
5296 * print.c (print_object): Remove var that is set but not used.
5298 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5299 The gnulib version avoids calling malloc in the usual case,
5300 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5301 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5302 * filelock.c (current_lock_owner): Likewise.
5303 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5304 * sysdep.c: Include allocator.h, careadlinkat.h.
5305 (emacs_no_realloc_allocator): New static constant.
5306 (emacs_readlink): New function.
5307 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5308 ../lib/careadlinkat.h.
5310 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5312 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5313 first non-nil return value).
5315 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5317 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5318 if not defined (Bug#8403).
5320 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5322 * xdisp.c (display_count_lines): Remove parameter `start',
5323 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5324 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5325 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5326 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5327 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5328 and thereabouts. All callers changed.
5329 (get_per_char_metric): Remove parameter `f', unused since
5330 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5332 2011-04-02 Jim Meyering <meyering@redhat.com>
5334 do not dereference NULL upon failed strdup
5335 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5336 (ns_get_family): Likewise.
5338 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5340 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5342 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5344 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5347 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5349 Add lexical binding.
5351 * window.c (Ftemp_output_buffer_show): New fun.
5352 (Fsave_window_excursion):
5353 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5355 * lread.c (lisp_file_lexically_bound_p): New function.
5356 (Fload): Bind Qlexical_binding.
5357 (readevalloop): Remove `evalfun' arg.
5358 Bind Qinternal_interpreter_environment.
5359 (Feval_buffer): Bind Qlexical_binding.
5360 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5362 (syms_of_lread): Declare `lexical-binding'.
5364 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5366 * keyboard.c (eval_dyn): New fun.
5367 (menu_item_eval_property): Use it.
5369 * image.c (parse_image_spec): Use Ffunctionp.
5371 * fns.c (concat, mapcar1): Accept byte-code-functions.
5373 * eval.c (Fsetq): Handle lexical vars.
5374 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5375 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5376 (FletX, Flet): Obey lexical binding.
5377 (Fcommandp): Handle closures.
5378 (Feval): New `lexical' arg.
5379 (eval_sub): New function extracted from Feval. Use it almost
5380 everywhere where Feval was used. Look up vars in lexical env.
5382 (Ffunctionp): Move from subr.el.
5383 (Ffuncall): Handle closures.
5384 (apply_lambda): Remove `eval_flags'.
5385 (funcall_lambda): Handle closures and new byte-code-functions.
5386 (Fspecial_variable_p): New function.
5387 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5388 but without exporting it to Lisp.
5390 * doc.c (Fdocumentation, store_function_docstring):
5391 * data.c (Finteractive_form): Handle closures.
5393 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5396 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5398 (exec_byte_code): New function extracted from Fbyte_code to handle new
5399 calling convention for byte-code-functions. Add new byte-codes.
5401 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5403 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5405 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5407 * xdisp.c (redisplay_internal): Fix prototype.
5409 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5411 * xdisp.c (SCROLL_LIMIT): New macro.
5412 (try_scrolling): Use it when setting scroll_limit.
5413 Limit scrolling to 100 screen lines.
5414 (redisplay_window): Even when falling back on "recentering",
5415 position point in the window according to scroll-conservatively,
5416 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5418 (try_scrolling): When point is above the window, allow searching
5419 as far as scroll_max, or one screenful, to compute vertical
5420 distance from PT to the scroll margin position. This prevents
5421 try_scrolling from unnecessarily failing when
5422 scroll-conservatively is set to a value slightly larger than the
5423 window height. Clean up the case of PT below the margin at bottom
5424 of window: scroll_max can no longer be INT_MAX. When aggressive
5425 scrolling is in use, don't let point enter the opposite scroll
5426 margin as result of the scroll.
5427 (syms_of_xdisp) <scroll-conservatively>: Document the
5428 threshold of 100 lines for never-recentering scrolling.
5430 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5432 * dispextern.h (move_it_by_lines):
5433 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5434 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5435 (message_log_check_duplicate): Remove parameters `prev_bol' and
5436 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5437 (redisplay_internal): Remove parameter `preserve_echo_area',
5438 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5440 * indent.c (Fvertical_motion):
5441 * window.c (window_scroll_pixel_based, Frecenter):
5442 Don't pass `need_y_p' to `move_it_by_lines'.
5444 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5446 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5447 steal a few bits to be more compact.
5448 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5449 Remove unneeded casts.
5451 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5453 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5455 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5456 binding" message (bug#7967).
5458 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5460 Fix more problems found by GCC 4.6.0's static checks.
5462 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5463 Remove unused local var.
5465 * editfns.c (Fmessage_box): Remove unused local var.
5467 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5468 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5469 Omit unused local vars.
5470 * window.c (shrink_windows): Omit unused local var.
5471 * menu.c (digest_single_submenu): Omit unused local var.
5472 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5473 Omit unused local var.
5475 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5476 Don't assume string length fits in int.
5477 (keyremap_step, read_key_sequence): Use size_t for sizes.
5478 (read_key_sequence): Don't check last_real_key_start redundantly.
5480 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5481 instead of alloca (Bug#8344).
5483 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5484 (Fbacktrace_frame): Don't assume nframes fits in int.
5486 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5488 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5491 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5493 * cm.c (calccost): Turn while-do into do-while, for clarity.
5495 * keyboard.c (syms_of_keyboard): Use the same style as later
5496 in this function when indexing through an array. This also
5497 works around GCC bug 48267.
5499 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5501 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5503 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5504 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5506 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5507 This avoids undefined behavior on integer overflow, and is a bit
5508 more convenient anyway since it is compared to a size_t variable.
5510 Variadic C functions now count arguments with size_t, not int.
5511 This avoids an unnecessary limitation on 64-bit machines, which
5512 caused (substring ...) to crash on large vectors (Bug#8344).
5513 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5514 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5515 All variadic functions and their callers changed accordingly.
5516 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5517 * data.c (arith_driver, float_arith_driver): Likewise.
5518 * editfns.c (general_insert_function): Likewise.
5519 * eval.c (struct backtrace.nargs, interactive_p)
5520 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5521 (funcall_lambda, mark_backtrace): Likewise.
5522 * fns.c (concat): Likewise.
5523 * frame.c (x_set_frame_parameters): Likewise.
5524 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5525 0 if not found, not -1. All callers changed.
5527 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5528 (stack_copy_size): Now size_t, not int.
5529 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5531 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5533 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5534 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5535 All callers changed.
5537 * lisp.h (multibyte_char_to_unibyte):
5538 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5539 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5540 * character.h (CHAR_TO_BYTE8):
5541 * cmds.c (internal_self_insert):
5542 * editfns.c (general_insert_function):
5543 * keymap.c (push_key_description):
5544 * search.c (Freplace_match):
5545 * xdisp.c (message_dolog, set_message_1): All callers changed.
5547 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5549 * keyboard.c (safe_run_hook_funcall): New function.
5550 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5551 don't set the hook to nil, but remove the offending function instead.
5552 (Qcommand_hook_internal): Remove, unused.
5553 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5554 Vcommand_hook_internal.
5556 * eval.c (enum run_hooks_condition): Remove.
5557 (funcall_nil, funcall_not): New functions.
5558 (run_hook_with_args): Call each function through a `funcall' argument.
5559 Remove `cond' argument, now redundant.
5560 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5561 (Frun_hook_with_args_until_failure): Adjust accordingly.
5562 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5564 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5566 * dispextern.h (string_buffer_position): Remove declaration.
5568 * print.c (strout): Remove parameter `multibyte', unused since
5569 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5571 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5572 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5573 All callers changed.
5575 * w32.c (_wsa_errlist): Use braces for struct initializers.
5577 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5578 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5579 All callers changed.
5580 (string_buffer_position): Likewise. Also, make static (it's never
5581 used outside xdisp.c).
5582 (cursor_row_p): Remove parameter `w', unused since
5583 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5584 (decode_mode_spec): Remove parameter `precision', introduced during
5585 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5586 All callers changed.
5588 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5590 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5592 2011-03-27 Anders Lindgren <andlind@gmail.com>
5594 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5595 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5596 (ns_update_auto_hide_menu_bar): New functions.
5597 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5598 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5599 ns_constrain_all_frames.
5600 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5601 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5603 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5605 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5607 2011-03-27 Glenn Morris <rgm@gnu.org>
5609 * syssignal.h: Replace RETSIGTYPE with void.
5610 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5611 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5612 Replace SIGTYPE with void everywhere.
5613 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5614 * s/template.h (SIGTYPE): Remove commented out definition.
5616 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5618 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5619 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5621 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5623 * w32.c (read_unc_volume): Use parameter `henum', instead of
5624 global variable `wget_enum_handle'.
5626 * keymap.c (describe_vector): Remove parameters `indices' and
5627 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5628 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5630 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5632 * keyboard.c (timer_check): Remove parameter `do_it_now',
5633 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5634 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5635 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5637 * keyboard.c (read_char):
5638 * w32menu.c (w32_menu_display_help):
5639 * xmenu.c (show_help_event, menu_help_callback):
5640 Adjust calls to `show_help_echo'.
5642 * gtkutil.c (xg_maybe_add_timer):
5643 * keyboard.c (readable_events):
5644 * process.c (wait_reading_process_output):
5645 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5647 * insdel.c (adjust_markers_gap_motion):
5648 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5649 (gap_left, gap_right): Don't call it.
5651 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5653 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5654 incurred during fontification.
5656 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5658 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5659 (DEFVAR_PER_BUFFER): Don't pass it.
5661 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5662 (scrolling_window): Don't pass it.
5664 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5666 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5668 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5670 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5671 of variables specific to SELinux and computation of `encoded_absname'.
5673 * image.c (XPutPixel): Remove unused variable `height'.
5675 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5677 * unexw32.c (get_section_info): Remove unused variable `section'.
5679 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5680 (system_process_attributes): Remove unused variable `sess'.
5681 (sys_read): Remove unused variable `err'.
5683 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5684 (w32_wnd_proc): Remove unused variable `isdead'.
5685 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5686 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5687 (x_create_tip_frame): Remove unused variable `tem'.
5689 * w32inevt.c (w32_console_read_socket):
5690 Remove unused variable `no_events'.
5692 * w32term.c (x_draw_composite_glyph_string_foreground):
5693 Remove unused variable `width'.
5695 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5697 * w32term.c (x_set_glyph_string_clipping):
5698 Don't pass uninitialized region to CombineRgn.
5700 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5702 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5703 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5704 (Fx_close_connection): Remove unused variable `i'.
5706 * w32font.c (w32font_draw): Return number of glyphs.
5707 (w32font_open_internal): Remove unused variable `i'.
5708 (w32font_driver): Add missing initializer.
5710 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5711 (fill_in_menu): Remove unused variable `items_added'.
5713 * w32term.c (last_mouse_press_frame): Remove static global variable.
5714 (w32_clip_to_row): Remove unused variable `f'.
5715 (x_delete_terminal): Remove unused variable `i'.
5717 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5718 (NOTHING): Remove unused static global variable.
5719 (uniscribe_check_otf): Remove unused variable `table'.
5720 (uniscribe_font_driver): Add missing initializers.
5722 2011-03-23 Julien Danjou <julien@danjou.info>
5724 * term.c (Fsuspend_tty, Fresume_tty):
5725 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5726 * window.c (temp_output_buffer_show):
5727 * insdel.c (signal_before_change):
5728 * frame.c (Fhandle_switch_frame):
5729 * fileio.c (Fdo_auto_save):
5730 * emacs.c (Fkill_emacs):
5731 * editfns.c (save_excursion_restore):
5732 * cmds.c (internal_self_insert):
5733 * callint.c (Fcall_interactively):
5734 * buffer.c (Fkill_all_local_variables):
5735 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5737 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5738 unconditionnaly since it does the check itself.
5740 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5742 Fix more problems found by GCC 4.5.2's static checks.
5744 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5745 the first time through the loop, since we know p0 < p1 then.
5746 This also avoids a gcc -Wstrict-overflow warning.
5748 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5749 leading to a memory leak, possible in functions like
5750 load_charset_map_from_file that can allocate an unbounded number
5751 of objects (Bug#8318).
5753 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5754 that could (at least in theory) be that large.
5756 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5757 This is less likely to overflow, and avoids undefined behavior if
5758 overflow does occur. All callers changed. Use strtoul to scan
5759 for the unsigned long integer.
5760 (pint2hrstr): Simplify and tune code slightly.
5761 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5763 * scroll.c (do_scrolling): Work around GCC bug 48228.
5764 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5766 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5767 This also avoids a warning with gcc -Wstrict-overflow.
5768 (validate_x_resource_name): Simplify count usage.
5769 This also avoids a warning with gcc -Wstrict-overflow.
5771 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5774 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5776 * process.c (Fmake_network_process): Use socklen_t, not int,
5777 where POSIX says socklen_t is required in portable programs.
5778 This fixes a porting bug on hosts like 64-bit HP-UX, where
5779 socklen_t is wider than int (Bug#8277).
5780 (Fmake_network_process, server_accept_connection):
5781 (wait_reading_process_output, read_process_output):
5784 * process.c: Rename or move locals to avoid shadowing.
5785 (list_processes_1, Fmake_network_process):
5786 (read_process_output_error_handler, exec_sentinel_error_handler):
5787 Rename or move locals.
5788 (Fmake_network_process): Define label "retry_connect" only if needed.
5789 (Fnetwork_interface_info): Fix pointer signedness.
5790 (process_send_signal): Add cast to avoid pointer signedness problem.
5791 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5792 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5794 Make tparam.h and terminfo.c consistent.
5795 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5796 Include tparam.h instead, since it declares them.
5797 * cm.h (PC): Remove extern decl; tparam.h now does this.
5798 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5799 * terminfo.c: Include tparam.h, to check interfaces.
5800 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5801 (tparam): Adjust signature to match interface in tparam.h;
5802 this removes some undefined behavior. Check that outstring and len
5803 are zero, which they always are with Emacs.
5804 * tparam.h (PC, BC, UP): New extern decls.
5806 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5807 (xftfont_open): Rename locals to avoid shadowing.
5809 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5810 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5811 (OTF_TAG_SYM): Omit macro if not needed.
5812 (ftfont_list): Remove unused local.
5813 (get_adstyle_property, ftfont_pattern_entity):
5814 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5815 Rename locals to avoid shadowing.
5817 * xfont.c (xfont_list_family): Mark var as initialized.
5819 * xml.c (make_dom): Now static.
5821 * composite.c (composition_compute_stop_pos): Rename local to
5823 (composition_reseat_it): Remove unused locals.
5824 (find_automatic_composition, composition_adjust_point): Likewise.
5825 (composition_update_it): Mark var as initialized.
5826 (find_automatic_composition): Mark vars as initialized,
5827 with a FIXME (Bug#8290).
5829 character.h: Rename locals to avoid shadowing.
5830 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5831 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5832 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5833 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5836 * textprop.c (property_change_between_p): Remove; unused.
5838 * intervals.c (interval_start_pos): Now static.
5840 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5842 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5843 Rename locals to avoid shadowing.
5845 * sound.c (wav_play, au_play, Fplay_sound_internal):
5846 Fix pointer signedness.
5847 (alsa_choose_format): Remove unused local var.
5848 (wav_play): Initialize a variable to 0, to prevent undefined
5849 behavior (Bug#8278).
5851 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5853 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5855 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5856 clobbering (Bug#8298).
5857 * sysdep.c (sys_subshell): Likewise.
5858 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5860 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5861 This should get cleaned up, so that child_setup has the
5862 same signature on all platforms.
5864 * callproc.c (call_process_cleanup): Now static.
5865 (relocate_fd): Rename locals to avoid shadowing.
5867 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5869 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5870 not to be necessary, and produces flickering.
5872 2011-03-20 Glenn Morris <rgm@gnu.org>
5874 * config.in: Remove file.
5876 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5878 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5879 are now in src/globals.h.
5880 (syms_of_minibuf): Remove spurious & from previous change.
5882 2011-03-20 Leo <sdl.web@gmail.com>
5884 * minibuf.c (completing-read-function): New variable.
5885 (completing-read-default): Rename from completing-read.
5886 (completing-read): Call completing-read-function.
5888 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5890 * xfaces.c (Fx_load_color_file):
5891 Read color file from absolute filename (bug#8250).
5893 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5895 * makefile.w32-in: Update dependencies.
5897 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5899 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5901 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5903 Fix more problems found by GCC 4.5.2's static checks.
5905 * process.c (make_serial_process_unwind, send_process_trap):
5906 (sigchld_handler): Now static.
5908 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5909 That way, the code declares only the vars that it needs.
5910 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5911 * s/cygwin.h (PTY_ITERATION): Likewise.
5912 * s/darwin.h (PTY_ITERATION): Likewise.
5913 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5915 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5916 * process.c (allocate_pty): Don't declare stb unless it's needed.
5918 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5919 (CONSTANTLIM): Remove; unused.
5920 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5921 Define only if needed.
5923 * unexelf.c (unexec): Name an expression,
5924 to avoid gcc -Wbad-function-cast warning.
5925 Use a different way to cause a compilation error if anyone uses
5926 n rather than nn, a way that does not involve shadowing.
5927 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5929 * deps.mk (unexalpha.o): Remove; unused.
5931 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5932 * unexec.h: New file.
5933 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5934 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5936 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5937 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5938 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5939 Change as necessary to match prototype in unexec.h.
5941 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5943 (back_comment, skip_chars): Mark vars as initialized.
5945 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5946 Rename locals to avoid shadowing.
5948 * lread.c (read1): Rewrite so as not to use empty "else".
5949 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5951 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5953 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5954 warning when compiling print.c.
5956 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5957 instead of using an uninitialized var.
5958 (font_sort_entities): Mark var as initialized.
5960 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5962 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5963 pointers to constants.
5964 (font_parse_fcname): Remove unused vars.
5965 (font_delete_unmatched): Now static.
5966 (font_get_spec): Remove; unused.
5967 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5968 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5969 Rename or move locals to avoid shadowing.
5971 * fns.c (require_nesting_list, require_unwind): Now static.
5972 (Ffillarray): Rename locals to avoid shadowing.
5974 * floatfns.c (domain_error2): Define only if needed.
5975 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5977 * alloc.c (mark_backtrace): Move decl from here ...
5978 * lisp.h: ... to here, so that it can be checked.
5980 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5981 (Fdefvar): Rewrite so as not to use empty "else".
5982 (lisp_indirect_variable): Name an expression,
5983 to avoid gcc -Wbad-function-cast warning.
5984 (Fdefvar): Rename locals to avoid shadowing.
5986 * callint.c (quotify_arg, quotify_args): Now static.
5987 (Fcall_interactively): Rename locals to avoid shadowing.
5988 Use const pointer when appropriate.
5990 * lisp.h (get_system_name, get_operating_system_release):
5991 Move decls here, to check interfaces.
5992 * process.c (get_operating_system_release): Move decl to lisp.h.
5993 * xrdb.c (get_system_name): Likewise.
5994 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5995 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5996 some of which prompt warnings from gcc -Wbad-function-cast.
5997 (Fformat_time_string, Fencode_time, Finsert_char):
5998 (Ftranslate_region_internal, Fformat):
5999 Rename or remove local vars to avoid shadowing.
6000 (Ftranslate_region_internal): Mark var as initialized.
6002 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6005 * lisp.h (eassert): Check that the argument compiles, even if
6006 ENABLE_CHECKING is not defined.
6008 * data.c (Findirect_variable): Name an expression, to avoid
6009 gcc -Wbad-function-cast warning.
6010 (default_value, arithcompare, arith_driver, arith_error): Now static.
6011 (store_symval_forwarding): Rename local to avoid shadowing.
6012 (Fmake_variable_buffer_local, Fmake_local_variable):
6013 Mark variables as initialized.
6014 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6016 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6017 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6018 Rename locals to avoid shadowing.
6019 (mark_stack): Move local variables into the #ifdef region where
6021 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6022 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6024 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6025 (GC_STRING_CHARS): Remove; not used.
6026 (Fmemory_limit): Cast sbrk's returned value to char *.
6028 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6029 avoids undefined behavior in theory.
6031 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6033 Use functions, not macros, for up- and down-casing (Bug#8254).
6034 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6035 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6036 to use the following functions instead of these macros.
6037 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6038 EMACS_INT, since callers assume the returned value fits in int.
6039 (upcase1): Likewise, for UPCASE_TABLE.
6040 (uppercasep, lowercasep, upcase): New static inline functions.
6041 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6042 the race-condition problem in the old DOWNCASE.
6044 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6045 Rename locals to avoid shadowing.
6046 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6047 (regex_compile, re_search_2, re_match_2_internal):
6048 Remove unused local vars.
6049 (FREE_VAR): Rewrite so as not to use empty "else",
6050 which gcc can warn about.
6051 (regex_compile, re_match_2_internal): Mark locals as initialized.
6052 (RETALLOC_IF): Define only if needed.
6053 (WORDCHAR_P): Likewise. This one is never needed, but is used
6054 only in a comment talking about a compiler bug, so put inside
6055 the #if 0 of that comment.
6056 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6057 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6060 * search.c (boyer_moore): Rename locals to avoid shadowing.
6061 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6062 (PREV_CHAR_BOUNDARY): Likewise.
6064 * search.c (simple_search): Remove unused var.
6066 * dired.c (compile_pattern): Move decl from here ...
6067 * lisp.h: ... to here, so that it can be checked.
6068 (struct re_registers): New forward decl.
6070 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6072 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6074 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6075 Rename locals to avoid shadowing.
6076 (Fvertical_motion): Mark locals as initialized.
6078 * casefiddle.c (casify_object, casify_region): Now static.
6079 (casify_region): Mark local as initialized.
6081 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6083 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6084 New macros, so that the caller can use some names other than
6085 gcpro1, gcpro2, etc.
6086 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6088 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6089 argument, for consistency with GCPRO2_VAR, etc: it is now the
6090 prefix of the variable, not the variable itself. All uses
6092 * dired.c (directory_files_internal, file_name_completion):
6093 Rename locals to avoid shadowing.
6095 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6096 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6097 dired.c's scmp function, had undefined behavior.
6098 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6099 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6100 * buffer.h: ... to here, because these macros use current_buffer,
6101 and the new implementation with inline functions needs to have
6102 current_buffer in scope now, rather than later when the macros
6104 (downcase, upcase1): New static inline functions.
6105 (DOWNCASE, UPCASE1): Reimplement using these functions.
6106 This avoids undefined behavior in expressions like
6107 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6108 from race conditions in accessing the global variables
6109 case_temp1 and case_temp2.
6110 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6111 * lisp.h (case_temp1, case_temp2): Remove their decls.
6112 * character.h (ASCII_CHAR_P): Move from here ...
6113 * lisp.h: ... to here, so that the inline functions mentioned
6116 * dired.c (directory_files_internal_unwind): Now static.
6118 * fileio.c (file_name_as_directory, directory_file_name):
6119 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6121 (file_name_as_directory): Use const pointers when appropriate.
6122 (Fexpand_file_name): Likewise. In particular, newdir might
6123 point at constant storage, so make it a const pointer.
6124 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6125 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6127 (Fset_file_times, Finsert_file_contents, auto_save_error):
6128 Rename locals to avoid shadowing.
6130 * minibuf.c (choose_minibuf_frame_1): Now static.
6131 (Ftry_completion, Fall_completions): Rename or remove locals
6134 * marker.c (bytepos_to_charpos): Remove; unused.
6136 * lisp.h (verify_bytepos, count_markers): New decls,
6137 so that gcc does not warn that these functions aren't declared.
6139 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6140 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6141 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6142 (copy_text): Remove unused local var.
6144 * filelock.c (within_one_second): Now static.
6145 (lock_file_1): Rename local to avoid shadowing.
6147 * buffer.c (fix_overlays_before): Mark locals as initialized.
6148 (fix_start_end_in_overlays): Likewise. This function should be
6149 simplified by using pointers-to-pointers, but that's a different
6151 (switch_to_buffer_1): Now static.
6152 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6153 (report_overlay_modification): Rename locals to avoid shadowing.
6155 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6156 Fix pointer signedness issue.
6157 (sys_subshell): Mark local as volatile if checking for lint,
6158 to suppress a gcc -Wclobbered warning that does not seem to be right.
6159 (MAXPATHLEN): Define only if needed.
6161 * process.c (serial_open, serial_configure): Move decls from here ...
6162 * systty.h: ... to here, so that they can be checked.
6164 * fns.c (get_random, seed_random): Move extern decls from here ...
6165 * lisp.h: ... to here, so that they can be checked.
6167 * sysdep.c (reset_io): Now static.
6168 (wait_for_termination_signal): Remove; unused.
6170 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6171 (copy_keymap_item, append_key, push_text_char_description):
6173 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6174 (DENSE_TABLE_SIZE): Remove; unused.
6175 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6176 (describe_map_tree):
6177 Rename locals to avoid shadowing.
6179 * keyboard.c: Declare functions static if they are not used elsewhere.
6180 (echo_char, echo_dash, cmd_error, top_level_2):
6181 (poll_for_input, handle_async_input): Now static.
6182 (read_char, kbd_buffer_get_event, make_lispy_position):
6183 (make_lispy_event, make_lispy_movement, apply_modifiers):
6184 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6185 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6186 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6187 (read_key_sequence, read_char): Mark locals as initialized.
6188 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6190 * keyboard.h (make_ctrl_char): New decl.
6191 (mark_kboards): Move decl here ...
6192 * alloc.c (mark_kboards): ... from here.
6194 * lisp.h (force_auto_save_soon): New decl.
6196 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6197 (DEFINE_DUMMY_FUNCTION): New macro.
6198 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6200 (main): Add casts to avoid warnings
6201 if GCC considers string literals to be constants.
6203 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6205 * dbusbind.c: Pointer signedness fixes.
6206 (xd_signature, xd_append_arg, xd_initialize):
6207 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6208 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6209 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6210 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6212 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6213 if GCC considers string literals to be constants.
6214 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6216 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6218 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6219 (print_preprocess, print_object): New macro to fix last change.
6221 * print.c (print_preprocess): Don't forget font objects.
6223 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6225 * emacs.c (USAGE3): Doc fixes.
6227 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6229 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6232 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6234 * lisp.h (VWindow_system, Qfile_name_history):
6235 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6236 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6237 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6239 * w32select.c: Don't #include "keyboard.h".
6240 (run_protected): Add extern declaration for waiting_for_input.
6242 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6243 * w32console.c (detect_input_pending, read_input_pending)
6244 (encode_terminal_code):
6245 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6246 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6247 (w32_system_caret_y, Qfile_name_history):
6248 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6249 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6250 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6251 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6252 * w32proc.c (Qlocal, report_file_error):
6253 * w32term.c (Vwindow_system, updating_frame):
6254 * w32uniscribe.c (initialized, uniscribe_font_driver):
6255 Remove unneeded extern declarations.
6257 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6259 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6261 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6263 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6264 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6265 These macros can no longer be used for assignment.
6267 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6268 Assign struct members directly, instead of using BUF_BEGV etc.
6269 (record_buffer_markers, fetch_buffer_markers): New functions for
6270 recording and fetching special buffer markers.
6271 (set_buffer_internal_1, set_buffer_temp): Use them.
6273 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6275 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6277 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6278 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6280 * xdisp.c (hscroll_window_tree):
6281 (reconsider_clip_changes): Use PT instead of BUF_PT.
6283 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6285 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6286 $(EMACS_ROOT)/lib/intprops.h.
6288 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6290 Fix more problems found by GCC 4.5.2's static checks.
6292 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6293 to unsigned char * to avoid compiler diagnostic.
6294 (xg_free_frame_widgets): Make it clear that a local variable is
6295 needed only if USE_GTK_TOOLTIP.
6296 (gdk_window_get_screen): Make it clear that this macro is needed
6297 only if USE_GTK_TOOLTIP.
6298 (int_gtk_range_get_value): New function, which avoids a diagnostic
6299 from gcc -Wbad-function-cast.
6300 (xg_set_toolkit_scroll_bar_thumb): Use it.
6301 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6302 diagnostic from gcc -Wbad-function-cast.
6303 (get_utf8_string, xg_get_file_with_chooser):
6304 Rename locals to avoid shadowing.
6305 (create_dialog): Move locals to avoid shadowing.
6307 * xgselect.c (xg_select): Remove unused var.
6309 * image.c (four_corners_best): Mark locals as initialized.
6310 (gif_load): Initialize transparent_p to zero (Bug#8238).
6311 Mark another local as initialized.
6312 (my_png_error, my_error_exit): Mark with NO_RETURN.
6314 * image.c (clear_image_cache): Now static.
6315 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6316 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6317 (x_edge_detection): Remove unnecessary cast that
6318 gcc -Wbad-function-cast diagnoses.
6319 (gif_load): Fix pointer signedness.
6320 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6321 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6323 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6325 Improve quality of tests for time stamp overflow.
6326 For example, without this patch (encode-time 0 0 0 1 1
6327 1152921504606846976) returns the obviously-bogus value (-948597
6328 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6329 reports time overflow. See
6330 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6331 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6332 * editfns.c: Include limits.h and intprops.h.
6333 (TIME_T_MIN, TIME_T_MAX): New macros.
6334 (time_overflow): Move earlier, to before first use.
6335 (hi_time, lo_time): New functions, for an accurate test for
6337 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6338 (Fget_internal_run_time): Don't assume time_t fits in int.
6339 (make_time): Use list2 instead of Fcons twice.
6340 (Fdecode_time): More accurate test for out-of-range times.
6341 (check_tm_member): New function.
6342 (Fencode_time): Use it, to test for out-of-range times.
6343 (lisp_time_argument): Don't rely on undefined left-shift and
6344 right-shift behavior when checking for time stamp overflow.
6346 * editfns.c (time_overflow): New function, refactoring common code.
6347 (Fformat_time_string, Fdecode_time, Fencode_time):
6348 (Fcurrent_time_string): Use it.
6350 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6351 * dired.c (make_time): Move to ...
6352 * editfns.c (make_time): ... here.
6353 * systime.h: Note the move.
6355 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6357 * fringe.c (update_window_fringes): Remove unused variables.
6359 * unexmacosx.c (copy_data_segment): Also copy __got section.
6362 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6364 * termcap.c [MSDOS]: Include "msdos.h".
6365 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6366 Constify `char *' arguments and their references according to
6367 prototypes in tparam.h.
6369 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6371 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6372 Adapt all references accordingly.
6374 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6376 2011-03-11 Tom Tromey <tromey@redhat.com>
6378 * buffer.c (syms_of_buffer): Remove obsolete comment.
6380 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6382 * termhooks.h (encode_terminal_code): Declare prototype.
6384 * msdos.c (encode_terminal_code): Don't declare prototype.
6386 * term.c (encode_terminal_code): Now external again, used by
6387 w32console.c and msdos.c.
6389 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6390 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6392 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6394 Fix some minor problems found by GCC 4.5.2's static checks.
6396 * fringe.c (update_window_fringes): Mark locals as initialized
6398 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6400 * alloc.c (mark_fringe_data): Move decl from here ...
6401 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6402 to check its interface.
6403 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6405 * fontset.c (free_realized_fontset): Now static.
6406 (Fset_fontset_font): Rename local to avoid shadowing.
6407 (fontset_font): Mark local as initialized.
6408 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6410 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6412 * xselect.c (x_disown_buffer_selections): Remove; not used.
6413 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6414 (x_own_selection, Fx_disown_selection_internal): Rename locals
6416 (x_handle_dnd_message): Remove local to avoid shadowing.
6418 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6419 so that the caller can use some name other than gcpro1.
6420 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6421 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6422 (Fx_backspace_delete_keys_p):
6423 Use them to avoid shadowing, and rename vars to avoid shadowing.
6424 (x_decode_color, x_set_name, x_window): Now static.
6425 (Fx_create_frame): Add braces to silence GCC warning.
6426 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6427 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6428 Remove unused locals.
6429 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6430 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6431 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6434 * xterm.h (x_mouse_leave): New decl.
6436 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6437 Remove unused functions.
6438 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6439 (x_calc_absolute_position): Now static.
6440 (XTread_socket): Don't define label "out" unless it's used.
6441 Don't declare local "event" unless it's used.
6442 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6443 unless they are used.
6444 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6445 (x_fatal_error_signal): Remove; not used.
6446 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6447 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6448 (x_error_catcher, x_connection_closed, x_error_handler):
6449 (x_error_quitter, xembed_send_message, x_iconify_frame):
6450 (my_log_handler): Rename locals to avoid shadowing.
6451 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6452 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6454 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6455 Rename or move locals to avoid shadowing.
6456 (tty_defined_color, merge_face_heights): Now static.
6457 (free_realized_faces_for_fontset): Remove; not used.
6458 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6459 does not deduce is never used uninitialized.
6460 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6461 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6463 * terminal.c (store_terminal_param): Now static.
6465 * xmenu.c (menu_highlight_callback): Now static.
6466 (set_frame_menubar): Remove unused local.
6467 (xmenu_show): Rename parameter to avoid shadowing.
6468 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6469 since they might point to immutable storage.
6470 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6471 since it's unused otherwise.
6473 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6474 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6475 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6476 avoids a gcc -Wuninitialized diagnostic.
6477 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6478 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6479 does not deduce are never used uninitialized.
6481 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6483 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6484 * window.c (window_loop, size_window):
6485 (run_window_configuration_change_hook, enlarge_window): Likewise.
6487 * window.c (display_buffer): Now static.
6488 (size_window): Mark variables that gcc -Wuninitialized
6489 does not deduce are never used uninitialized.
6490 * window.h (check_all_windows): New decl, to forestall
6491 gcc -Wmissing-prototypes diagnostic.
6492 * dispextern.h (bidi_dump_cached_states): Likewise.
6494 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6496 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6498 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6499 and to avoid gcc -Wuninitialized warning.
6500 (load_charset_map): Mark variables that gcc -Wuninitialized
6501 does not deduce are never used uninitialized.
6502 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6504 * coding.c (coding_set_source, coding_set_destination):
6505 Use "else { /* comment */ }" rather than "else /* comment */;"
6506 for clarity, and to avoid gcc -Wempty-body warning.
6507 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6508 a block, when the outer 'i' will do.
6509 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6510 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6511 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6512 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6513 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6514 Rename locals to avoid shadowing.
6515 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6516 * coding.c (emacs_mule_char, encode_invocation_designation):
6517 Now static, since they're not used elsewhere.
6518 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6519 (decode_coding_object, encode_coding_object, detect_coding_system):
6520 (decode_coding_emacs_mule): Mark variables that gcc
6521 -Wuninitialized does not deduce are never used uninitialized.
6522 (detect_coding_iso_2022): Initialize a local variable that might
6523 be used uninitialized. Leave a FIXME because it's not clear that
6524 this initialization is needed. (Bug#8211)
6525 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6526 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6527 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6528 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6529 Remove unused macros.
6531 * category.c (hash_get_category_set): Remove unused local var.
6532 (copy_category_table): Now static, since it's not used elsewhere.
6533 * character.c (string_count_byte8): Likewise.
6535 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6536 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6538 * chartab.c (copy_sub_char_table): Now static, since it's not used
6540 (sub_char_table_ref_and_range, char_table_ref_and_range):
6541 Rename locals to avoid shadowing.
6542 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6544 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6545 (BIDI_BOB): Remove unused macro.
6547 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6548 deduce are never used uninitialized.
6549 * term.c (encode_terminal_code): Likewise.
6551 * term.c (encode_terminal_code): Now static. Remove unused local.
6553 * tparam.h: New file.
6554 * term.c, tparam.h: Include it.
6555 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6556 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6557 Move these decls to tparam.h, and make them agree with what
6558 is actually in tparam.c. The previous trick of using incompatible
6559 decls in different modules does not conform to the C standard.
6560 All callers of tparam changed to use tparam's actual API.
6561 * tparam.c (tparam1, tparam, tgoto):
6562 Use const pointers where appropriate.
6564 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6565 * cm.h (struct cm): Likewise.
6566 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6567 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6568 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6569 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6570 (turn_on_face, init_tty): Likewise.
6571 * termchar.h (struct tty_display_info): Likewise.
6573 * term.c (term_mouse_position): Rename local to avoid shadowing.
6575 * alloc.c (mark_ttys): Move decl from here ...
6576 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6578 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6580 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6582 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6584 * search.c (compile_pattern_1): Remove argument regp, unused since
6585 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6586 (compile_pattern): Don't pass it.
6588 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6590 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6591 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6593 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6595 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6597 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6598 gdk_window_get_screen, gdk_window_get_geometry,
6599 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6600 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6601 (xg_get_pixbuf_from_pixmap): New function.
6602 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6603 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6604 Call xg_get_pixbuf_from_pixmap instead of
6605 gdk_pixbuf_get_from_drawable.
6606 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6607 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6608 (xg_check_special_colors): Use GtkStyleContext and its functions
6610 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6611 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6612 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6613 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6614 Call gtk_widget_get_preferred_size.
6615 (xg_frame_resized): gdk_window_get_geometry only takes 5
6617 (xg_win_to_widget, xg_event_is_for_menubar):
6618 Call gdk_x11_window_lookup_for_display.
6619 (xg_set_widget_bg): New function.
6620 (delete_cb): New function.
6621 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6622 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6623 (xg_set_background_color): Call xg_set_widget_bg.
6624 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6625 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6626 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6627 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6629 (update_frame_tool_bar): Call gtk_widget_hide.
6630 (xg_initialize): Use GDK_KEY_g.
6632 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6634 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6636 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6637 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6638 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6640 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6642 * w32xfns.c (select_palette): Check success of RealizePalette against
6643 GDI_ERROR, not zero.
6645 See ChangeLog.11 for earlier changes.
6651 Copyright (C) 2011 Free Software Foundation, Inc.
6653 This file is part of GNU Emacs.
6655 GNU Emacs is free software: you can redistribute it and/or modify
6656 it under the terms of the GNU General Public License as published by
6657 the Free Software Foundation, either version 3 of the License, or
6658 (at your option) any later version.
6660 GNU Emacs is distributed in the hope that it will be useful,
6661 but WITHOUT ANY WARRANTY; without even the implied warranty of
6662 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6663 GNU General Public License for more details.
6665 You should have received a copy of the GNU General Public License
6666 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.