1 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (iterate_out_of_display_property): xassert that
4 IT->position is set to within IT->object's boundaries. Break from
5 the loop as soon as EOB is reached; avoids infloops in redisplay
6 when IT->position is set up wrongly due to some bug. Set
7 IT->current to match the bidi iterator unconditionally.
8 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9 entry. Force push_it to save on the stack the current
10 buffer/string position, to be restored by pop_it. Fix flags in
11 the iterator structure wrt the object coming from a display
12 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
13 properties. (Bug#9284)
15 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
17 * fontset.c (fontset_get_font_group): Add proper type checks.
20 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
22 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
23 and LC_VERSION_MIN_MACOSX.
24 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
25 (dump_it) [LC_FUNCTION_STARTS]: Use it.
27 2011-08-08 Eli Zaretskii <eliz@gnu.org>
29 * xdisp.c (forward_to_next_line_start): Allow to use the
30 no-display-properties-and-no-overlays under bidi display. Set
31 disp_pos in the bidi iterator to avoid searches for display
32 properties and overlays.
34 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
36 * editfns.c (Fset_time_zone_rule): Document relationship with the
39 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
40 the font entity extracted from the cache (Bug#8109).
42 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
44 * composite.c (autocmp_chars): Don't reset point. That is done by
45 restore_point_unwind (Bug#5984).
47 2011-08-07 Juri Linkov <juri@jurta.org>
49 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
50 to show the arg `TIME' instead of `TIMEVAL'.
52 2011-08-06 Eli Zaretskii <eliz@gnu.org>
54 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
55 display property strides EOL and includes a newline, as in
56 longlines-mode. (Bug#9254)
57 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
58 word-wrap under bidirectional display. (Bug#9224)
60 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
61 is non-zero, even if the data buffer is NULL. Fixes a crash in
62 vertical-motion with longlines-mode. (Bug#9254)
64 2011-08-05 Eli Zaretskii <eliz@gnu.org>
66 * bidi.c <bidi_cache_total_alloc>: Now static.
67 (bidi_initialize): Initialize bidi_cache_total_alloc.
69 *xdisp.c (display_line): Release buffer allocated for shelved bidi
72 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
73 amount allocated this far in `bidi_cache_total_alloc'.
74 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
75 non-zero, only free the data buffer without restoring the cache
76 contents. All callers changed.
78 * dispextern.h (bidi_unshelve_cache): Update prototype.
80 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
81 (move_it_in_display_line, move_it_to)
82 (move_it_vertically_backward, move_it_by_lines): Replace the call
83 to xfree to an equivalent call to bidi_unshelve_cache.
84 (move_it_in_display_line_to): Fix logic of returning
85 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
87 2011-08-05 Eli Zaretskii <eliz@gnu.org>
89 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
90 came from a string character with a `cursor' property. (Bug#9229)
92 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
94 * Makefile.in (LIB_PTHREAD): New variable.
95 (LIBES): Add LIB_PTHREAD (Bug#9216).
97 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
98 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
100 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
102 * regex.c (re_iswctype): Remove some redundant boolean
105 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
107 * xterm.c (x_find_topmost_parent): New function.
108 (x_set_frame_alpha): Find topmost parent window with
109 x_find_topmost_parent and set the property there also (bug#9181).
110 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
112 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
114 * callproc.c (Fcall_process): Avoid vfork clobbering
115 the local vars buffer, coding_systems, current_dir.
117 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
119 * keymap.c (Fmake_composed_keymap): Move to subr.el.
121 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
123 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
124 so that it is not optimized away.
126 * xdisp.c (compute_display_string_pos): Remove unused local.
128 2011-08-02 Eli Zaretskii <eliz@gnu.org>
130 Fix slow cursor motion and scrolling in large buffers with
131 selective display, like Org Mode buffers. (Bug#9218)
133 * dispextern.h (struct bidi_it): New member disp_prop_p.
135 * xdisp.c: Remove one-slot cache of display string positions.
136 (compute_display_string_pos): Accept an additional argument
137 DISP_PROP_P; callers changed. Scan at most 5K characters forward
138 for a display string or property. If found, set DISP_PROP_P
141 * bidi.c (bidi_fetch_char): Accept an additional argument
142 DISP_PROP_P, and pass it to compute_display_string_pos.
143 Only handle text covered by a display string if DISP_PROP_P is returned
144 non-zero. All callers of bidi_fetch_char changed.
146 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
148 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
150 2010-12-03 Don March <don@ohspite.net>
152 * keymap.c (Fdefine_key): Fix non-prefix key error message when
153 last character M-[char] is translated to ESC [char] (bug#7541).
155 2011-08-02 Kenichi Handa <handa@m17n.org>
157 * lisp.h (uniprop_table): Extern it.
159 * chartab.c (uniprop_table): Make it non-static.
161 2011-08-01 Eli Zaretskii <eliz@gnu.org>
163 * xdisp.c (forward_to_next_line_start): Accept additional argument
164 BIDI_IT_PREV, and store into it the state of the bidi iterator had
166 (reseat_at_next_visible_line_start): Use the bidi iterator state
167 returned by forward_to_next_line_start to restore the state of
168 it->bidi_it after backing up to previous newline. (Bug#9212)
170 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
172 * regex.c (re_comp): Protoize.
173 (re_exec): Fix return type.
174 (regexec): Fix type of `ret'. (Bug#9203)
176 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
178 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
179 This is needed if max-image-size is a floating-point number.
181 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
183 * print.c (print_object): Print empty symbol as ##.
185 * lread.c (read1): Read ## as empty symbol.
187 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
189 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
190 setting frame foreground color (Bug#9175).
191 (x_set_background_color): Likewise.
193 * nsmenu.m (-setText): Size tooltip dimensions precisely to
195 (EmacsTooltip -init): Remove bezels and add shadows to
198 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
199 or scroll bar (Bug#8470).
201 * nsfont.m (nsfont_open): Remove assignment to voffset and
202 unnecessary vars hshink, expand, hd, full_height, min_height.
203 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
205 * nsterm.h (nsfont_info): Remove voffset field.
207 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
209 Implement strike-through and overline on NextStep (Bug#8863).
211 * nsfont.m (nsfont_open): Use underline position provided by font,
212 instead of hard-coded value of 2.
213 (nsfont_draw): Call ns_draw_text_decoration instead.
215 * nsterm.h: Add declaration for ns_draw_text_decoration.
217 * nsterm.m (ns_draw_text_decoration): New function for drawing
218 underline, overline, and strike-through.
219 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
220 ns_draw_text_decoration. Change treatment of cursor drawing to
221 accomodate underlining, etc.
223 2011-07-28 Eli Zaretskii <eliz@gnu.org>
225 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
228 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
230 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
231 Without this fix, if a signal arrives just after memory fills up,
232 'malloc' might be invoked reentrantly.
234 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
235 In other words, assume that every image size is allowed, on non-X
236 hosts. This assumption is probably wrong, but it lets Emacs compile.
238 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
240 * regex.c (re_iswctype): Convert return values to boolean.
242 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
244 * xdisp.c (compute_display_string_pos): Don't use cached display
245 string position if the buffer had its restriction changed.
248 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
250 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
252 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
254 Integer signedness and overflow and related fixes. (Bug#9079)
256 * bidi.c: Integer size and overflow fixes.
257 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
258 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
259 (bidi_cache_find_level_change, bidi_cache_ensure_space)
260 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
261 (bidi_find_other_level_edge):
262 Use ptrdiff_t instead of EMACS_INT where either will do.
263 This works better on 32-bit hosts configured --with-wide-int.
264 (bidi_cache_ensure_space): Check for size-calculation overflow.
265 Use % rather than repeated addition, for better worst-case speed.
266 Don't set bidi_cache_size until after xrealloc returns, because it
268 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
269 (bidi_cache_ensure_space): Also check that the bidi cache size
270 does not exceed that of the largest Lisp string or buffer. See Eli
271 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
273 * alloc.c (__malloc_size_t): Remove.
274 All uses replaced by size_t. See Andreas Schwab's note
275 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
277 * image.c: Improve checking for integer overflow.
278 (check_image_size): Assume that f is nonnull, since
279 it is always nonnull in practice. This is one less thing to
280 worry about when checking for integer overflow later.
281 (x_check_image_size): New function, which checks for integer
282 overflow issues inside X.
283 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
284 This removes the need for a memory_full check.
285 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
286 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
287 (xbm_read_bitmap_data): Change locals back to 'int', since
288 their values must fit in 'int'.
289 (xpm_load_image, png_load, tiff_load):
290 Invoke x_create_x_image_and_pixmap earlier,
291 to avoid much needless work if the image is too large.
292 (tiff_load): Treat overly large images as if
293 x_create_x_image_and_pixmap failed, not as malloc failures.
294 (gs_load): Use x_check_image_size.
296 * gtkutil.c: Omit integer casts.
297 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
298 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
300 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
302 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
303 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
304 would wrongly return t on a 64-bit host.
306 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
307 The plain *_OVERFLOW macros run afoul of GCC bug 49705
308 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
309 and therefore cause GCC to emit a bogus diagnostic in some cases.
311 * image.c: Integer signedness and overflow and related fixes.
312 This is not an exhaustive set of fixes, but it's time to
313 record what I've got.
314 (lookup_pixel_color, check_image_size): Remove redundant decls.
315 (check_image_size): Don't assume that arbitrary EMACS_INT values
316 fit in 'int', or that arbitrary 'double' values fit in 'int'.
317 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
318 (tiff_load, imagemagick_load_image):
319 Check for overflow in size calculations.
320 (x_create_x_image_and_pixmap): Remove unnecessary test for
321 xmalloc returning NULL; that can't happen.
322 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
323 (xpm_color_bucket): Use better integer hashing function.
324 (xpm_cache_color): Don't possibly over-allocate memory.
325 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
327 Use ptrdiff_t, not int or size_t, to record sizes.
328 (png_load): Don't assume values greater than 2**31 fit in 'int'.
329 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
330 either works, as we prefer signed integers.
331 (tiff_read_from_memory, tiff_write_from_memory):
332 Return tsize_t, not size_t, since that's what the TIFF API wants.
333 (tiff_read_from_memory): Don't fail simply because the read would
334 go past EOF; instead, return a short read.
335 (tiff_load): Omit no-longer-needed casts.
336 (Fimagemagick_types): Don't assume size fits into 'int'.
338 Improve hashing quality when configured --with-wide-int.
339 * fns.c (hash_string): New function, taken from sxhash_string.
340 Do not discard information about ASCII character case; this
341 discarding is no longer needed.
342 (sxhash-string): Use it. Change sig to match it. Caller changed.
343 * lisp.h: Declare it.
344 * lread.c (hash_string): Remove, since we now use fns.c's version.
345 The fns.c version returns a wider integer if --with-wide-int is
346 specified, so this should help the quality of the hashing a bit.
348 * emacs.c: Integer overflow minor fix.
349 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
350 Define only if GNU_LINUX.
351 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
353 * dispnew.c: Integer signedness and overflow fixes.
354 Remove unnecessary forward decls, that were a maintenance hassle.
355 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
357 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
358 (scrolling_window): Use ptrdiff_t, not int, for byte count.
359 (prepare_desired_row, line_draw_cost):
360 Use int, not unsigned, where either works.
361 (save_current_matrix, restore_current_matrix):
362 Use ptrdiff_t, not size_t, where either works.
363 (init_display): Check for overflow more accurately, and without
364 relying on undefined behavior.
366 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
367 Remove, replacing with the new symbols in lisp.h. All uses changed.
368 * fileio.c (make_temp_name):
369 * filelock.c (lock_file_1, lock_file):
370 * xdisp.c (message_dolog):
371 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
372 Use pMd etc. instead.
373 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
374 replacing the pWIDE etc. symbols removed from editfns.c.
376 * keyboard.h (num_input_events): Now uintmax_t.
377 This is (very slightly) less likely to mess up due to wraparound.
380 * buffer.c: Integer signedness fixes.
381 (alloc_buffer_text, enlarge_buffer_text):
382 Use ptrdiff_t rather than size_t when either will do, as we prefer
385 * alloc.c: Integer signedness and overflow fixes.
386 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
387 (__malloc_size_t): Default to size_t, not to int.
388 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
389 (Fgarbage_collect, mark_object_loop_halt, mark_object):
390 Prefer ptrdiff_t to size_t when either would do, as we prefer
392 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
393 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
394 Now const. Initialize with values that are in range even if char
396 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
397 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
398 These functions do the right thing with sizes > 2**32.
399 (check_depth): Now ptrdiff_t, not int.
400 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
401 Adjust to new way of storing sizes. Check for size overflow bugs
403 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
404 slightly wrong anyway, as it missed one instance of
405 XMALLOC_OVERRUN_CHECK_OVERHEAD.
406 (refill_memory_reserve): Omit needless cast to size_t.
407 (mark_object_loop_halt): Mark as externally visible.
409 * xselect.c: Integer signedness and overflow fixes.
410 (Fx_register_dnd_atom, x_handle_dnd_message):
411 Use ptrdiff_t, not size_t, since we prefer signed.
412 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
413 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
414 x_dnd_atoms_size and x_dnd_atoms_length.
416 * doprnt.c: Prefer signed to unsigned when either works.
420 * xdisp.c (vmessage):
421 Use ptrdiff_t, not size_t, when using or implementing doprnt,
422 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
423 prefer signed arithmetic to avoid comparison confusion.
424 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
427 Assume freestanding C89 headers, string.h, stdlib.h.
428 * data.c, doprnt.c, floatfns.c, print.c:
429 Include float.h unconditionally.
430 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
431 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
432 * regex.c: Likewise for stddef.h, string.h.
433 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
434 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
435 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
436 (STDC_HEADERS): Remove obsolete defines.
437 * sysdep.c: Include limits.h unconditionally.
439 Assume support for memcmp, memcpy, memmove, memset.
440 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
441 * regex.c (memcmp, memcpy):
442 Remove; we assume C89 now.
444 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
445 (__malloc_safe_bcopy): Remove; no longer needed.
447 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
448 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
449 well either way, and we prefer signed to unsigned.
451 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
453 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
454 closes the connection while we're reading (bug#9182).
456 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
458 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
459 are specified (Bug#9168).
461 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
463 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
464 Found by GCC static checking and --with-wide-int on a 32-bit host.
466 2011-07-25 Eli Zaretskii <eliz@gnu.org>
468 * xdisp.c (compute_display_string_pos): Fix logic of caching
469 previous display string position. Initialize cached_prev_pos to
470 -1. Fixes slow-down at the beginning of a buffer.
472 2011-07-24 Eli Zaretskii <eliz@gnu.org>
474 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
475 for attrs[LFACE_FONTSET_INDEX].
477 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
479 * xml.c (parse_region): Remove unused local
480 that was recently introduced.
482 2011-07-23 Eli Zaretskii <eliz@gnu.org>
484 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
485 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
487 * xdisp.c (move_it_in_display_line_to): Record the best matching
488 position for TO_CHARPOS while scanning the line, and restore it on
489 exit if none of the characters scanned was an exact match.
490 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
491 when exact match is impossible due to invisible text, and the
494 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
496 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
499 2011-07-22 Eli Zaretskii <eliz@gnu.org>
501 Fix a significant slow-down of cursor motion with C-n, C-p,
502 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
503 auto-repeat under bidi redisplay in fontified buffers.
504 * xdisp.c (compute_stop_pos_backwards): New function.
505 (next_element_from_buffer): Call compute_stop_pos_backwards to
506 find a suitable prev_stop when we find ourselves before
508 (reseat): Don't look for prev_stop, as that could mean a very long
510 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
511 <cached_disp_overlay_modiff>: Cache for last found display string
513 (compute_display_string_pos): Return the cached position if asked
514 about the same buffer in the same area of character positions, and
515 the buffer wasn't changed since the time the display string
518 2011-07-22 Eli Zaretskii <eliz@gnu.org>
520 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
521 is an integer, which is important for empty lines. (Bug#9149)
523 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
525 * frame.c (Fmodify_frame_parameters): In tty case, update the
526 default face if necessary (Bug#4238).
528 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
530 * editfns.c (Fstring_to_char): No need to explain what a character
531 is in the docstring (Bug#6576).
533 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
535 * xml.c (parse_region): Make sure we always return a tree.
537 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
539 * xml.c (parse_region): If a document contains only comments,
542 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
544 * xml.c (make_dom): Return comments, too.
546 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
549 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
550 and the surrounding thread.
551 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
552 rather than fgets, and retry after EINTR. Otherwise, 'emacs
553 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
555 * s/openbsd.h (BROKEN_SIGIO): Define.
556 * unexelf.c (unexec) [__OpenBSD__]:
557 Don't update the .mdebug section of the Alpha COFF symbol table.
559 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
561 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
564 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
566 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
567 This fixes some race conditions on the permissions of any newly
570 * alloc.c (valid_pointer_p): Use pipe, not open.
571 This fixes some permissions issues when debugging.
573 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
574 If fchown fails to set both uid and gid, try to set just gid,
575 as that is sometimes allowed. Adjust the file's mode to eliminate
576 setuid or setgid bits that are inappropriate if fchown fails.
578 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
580 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
581 to compare Lisp_Objects.
582 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
583 global_gnutls_log_level, don't mistake it for a Lisp_Object.
584 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
586 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
588 * lread.c (read_integer): Unread even EOF character.
589 (read1): Likewise. Properly record start position of symbol.
591 * lread.c (read1): Read `#:' as empty uninterned symbol if no
592 symbol character follows.
594 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
596 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
597 This works around a problem with the previous change to Fcopy_file.
598 Recent glibc declares fchown with __attribute__((warn_unused_result)),
599 and without this change, GCC might complain about discarding
600 fchown's return value.
602 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
604 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
606 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
608 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
610 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
612 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
613 it's used from the C level.
615 * process.c: Use the same condition for POLL_FOR_INPUT in both
616 keyboard.c and process.c (bug#1858).
618 2011-07-09 Lawrence Mitchell <wence@gmx.li>
620 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
621 (Fgnutls_boot): Use it.
623 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
625 * doc.c (Fsubstitute_command_keys): Revert last change.
627 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
629 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
630 quotes the next character, and doesn't affect other longer
631 sequences (bug#8935).
633 * lread.c (syms_of_lread): Clarify that is isn't only
634 `eval-buffer' and `eval-defun' that's affected by
635 `lexical-binding' (bug#8460).
637 2011-07-15 Eli Zaretskii <eliz@gnu.org>
639 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
640 bidi redisplay when a line includes both an image and is
643 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
645 Fix minor problems found by static checking.
646 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
647 (elsz): Now a signed constant, not a size_t var. We prefer signed
648 types to unsigned, to avoid integer comparison confusion. Without
649 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
650 "cannot optimize loop, the loop counter may overflow", a symptom
652 * indent.c (Fvertical_motion): Mark locals as initialized.
653 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
655 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
657 * search.c (Fre_search_backward): Mention `case-fold-search' in
658 all the re_search_* functions (bug#8138).
660 * keyboard.c (Fopen_dribble_file): Document when the file is
663 2011-07-14 Eli Zaretskii <eliz@gnu.org>
665 * bidi.c (bidi_dump_cached_states): Fix format of displaying
668 Support bidi reordering of display and overlay strings.
669 * xdisp.c (compute_display_string_pos)
670 (compute_display_string_end): Accept additional argument STRING.
671 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
672 (reseat_to_string): Initialize bidi_it->string.s and
673 bidi_it->string.schars.
674 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
675 NULL (avoids a crash in bidi_paragraph_init).
676 Initialize itb.string.lstring.
677 (init_iterator): Call bidi_init_it only of a valid
678 buffer position was specified. Initialize paragraph_embedding to
680 (reseat_to_string): Initialize the bidi iterator.
681 (display_string): If we need to ignore text properties of
682 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
683 original value of -1 will not work with bidi.)
684 (compute_display_string_pos): First arg is now struct
685 `text_pos *'; all callers changed. Support display properties on
687 (compute_display_string_end): Support display properties on Lisp
689 (init_iterator, reseat_1, reseat_to_string): Initialize the
690 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
691 when iterating on a string not from display properties).
692 (compute_display_string_pos, compute_display_string_end):
693 Fix calculation of the object to scan. Fixes an error when using
695 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
696 base_level_stop; instead, set base_level_stop to BEGV.
697 Fixes crashes in vertical-motion.
698 (next_element_from_buffer): Improve commentary for when
699 the iterator is before prev_stop.
700 (init_iterator): Initialize bidi_p from the default value of
701 bidi-display-reordering, not from buffer-local value. Use the
702 buffer-local value only if initializing for buffer iteration.
703 (handle_invisible_prop): Support invisible properties on strings
704 that are being bidi-reordered.
705 (set_iterator_to_next): Support bidi reordering of C strings and
707 (next_element_from_string): Support bidi reordering of Lisp
709 (handle_stop_backwards): Support Lisp strings as well.
710 (display_string): Support display of R2L glyph rows.
711 Use IT_STRING_CHARPOS when displaying from a Lisp string.
712 (init_iterator): Don't initialize it->bidi_p for strings
714 (reseat_to_string): Initialize it->bidi_p for strings here.
715 (next_element_from_string, next_element_from_c_string)
716 (next_element_from_buffer): Add xassert's for correspondence
717 between IT's object being iterated and it->bidi_it.string
719 (face_before_or_after_it_pos): Support bidi iteration.
720 (next_element_from_c_string): Handle the case of the first string
721 character that is not the first one in the visual order.
722 (get_visually_first_element): New function, refactored from common
723 parts of next_element_from_buffer, next_element_from_string, and
724 next_element_from_c_string.
725 (tool_bar_lines_needed, redisplay_tool_bar)
726 (display_menu_bar): Force left-to-right direction. Add a FIXME
727 comment for making that be controlled by a user option.
728 (push_it, pop_it): Save and restore the state of the
729 bidi iterator. Save and restore the bidi_p flag.
730 (pop_it): Iterate out of display property for string iteration as
732 (iterate_out_of_display_property): Support iteration over strings.
733 (handle_single_display_spec): Set up it->bidi_it for iteration
734 over a display string, and call bidi_init_it.
735 (handle_single_display_spec, next_overlay_string)
736 (get_overlay_strings_1, push_display_prop): Set up the bidi
737 iterator for displaying display or overlay strings.
738 (forward_to_next_line_start): Don't use the shortcut if
740 (back_to_previous_visible_line_start): If handle_display_prop
741 pushed the iterator stack, restore the internal state of the bidi
742 iterator by calling bidi_pop_it same number of times.
743 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
744 and we are bidi-iterating, don't decrement the iterator position;
745 instead, set the first_elt flag in the bidi iterator, to produce
747 (reseat_1): Remove redundant setting of string_from_display_prop_p.
748 (push_display_prop): xassert that we are iterating a buffer.
749 (push_it, pop_it): Save and restore paragraph_embedding member.
750 (handle_single_display_spec, next_overlay_string)
751 (get_overlay_strings_1, reseat_1, reseat_to_string)
752 (push_display_prop): Set up the `unibyte' member of bidi_it.string
753 correctly. Don't assume unibyte strings are not bidi-reordered.
754 (compute_display_string_pos)
755 (compute_display_string_end): Fix handling the case of C string.
756 (push_it, pop_it): Save and restore from_disp_prop_p.
757 (handle_single_display_spec, push_display_prop): Set the
758 from_disp_prop_p flag.
759 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
760 (pop_it): Call iterate_out_of_display_property only if we are
761 popping after iteration over a string that came from a display
762 property. Fix a typo in popping stretch info. Add an assertion
763 for verifying that the iterator position is in sync with the bidi
765 (handle_single_display_spec, get_overlay_strings_1)
766 (push_display_prop): Fix initialization of paragraph direction for
767 string when that of the parent object is not yet determined.
768 (reseat_1): Call bidi_init_it to resync the bidi
769 iterator with IT's position. (Bug#7616)
770 (find_row_edges): If ROW->start.pos gives position
771 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
772 (handle_stop, back_to_previous_visible_line_start, reseat_1):
773 Reset the from_disp_prop_p flag.
774 (SAVE_IT, RESTORE_IT): New macros.
775 (pos_visible_p, face_before_or_after_it_pos)
776 (back_to_previous_visible_line_start)
777 (move_it_in_display_line_to, move_it_in_display_line)
778 (move_it_to, move_it_vertically_backward, move_it_by_lines)
779 (try_scrolling, redisplay_window, display_line): Use them when
780 saving a temporary copy of the iterator and restoring it back.
781 (back_to_previous_visible_line_start, reseat_1)
782 (init_iterator): Empty the bidi cache "stack".
783 (move_it_in_display_line_to): If iterator ended up at
784 EOL, but we never saw any buffer positions smaller than
785 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
786 motion in bidi-reordered lines.
787 (move_it_in_display_line_to): Record prev_method and prev_pos
788 immediately before the call to set_iterator_to_next. Fixes cursor
789 motion in bidi-reordered lines with stretch glyphs and strings
790 displayed in margins. (Bug#8133) (Bug#8867)
791 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
793 (pos_visible_p): Support positions in bidi-reordered lines.
794 Save and restore bidi cache.
796 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
797 (bidi_paragraph_info): Delete unused struct.
798 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
799 (bidi_cache_start): New variable.
800 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
802 (bidi_cache_fetch_state, bidi_cache_search)
803 (bidi_cache_find_level_change, bidi_cache_iterator_state)
804 (bidi_cache_find, bidi_peek_at_next_level)
805 (bidi_level_of_next_char, bidi_find_other_level_edge)
806 (bidi_move_to_visually_next): Compare cache index with
807 bidi_cache_start rather than with zero.
808 (bidi_fetch_char): Accept new argument STRING; all callers
809 changed. Support iteration over a string. Support strings with
810 display properties. Support unibyte strings. Fix the type of
811 `len' according to what STRING_CHAR_AND_LENGTH expects.
812 (bidi_paragraph_init, bidi_resolve_explicit_1)
813 (bidi_resolve_explicit, bidi_resolve_weak)
814 (bidi_level_of_next_char, bidi_move_to_visually_next):
815 Support iteration over a string.
816 (bidi_set_sor_type, bidi_resolve_explicit_1)
817 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
818 can now be zero (for strings); special values 0 and -1 were
819 changed to -1 and -2, respectively.
820 (bidi_char_at_pos): New function.
821 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
822 Call it instead of FETCH_MULTIBYTE_CHAR.
823 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
824 initialized to valid values.
825 (bidi_init_it): Don't initialize charpos and bytepos with invalid
827 (bidi_level_of_next_char): Allow the sentinel "position" to pass
828 the test for valid cached positions. Fix the logic for looking up
829 the sentinel state in the cache. GCPRO the Lisp string we are
831 (bidi_push_it, bidi_pop_it): New functions.
832 (bidi_initialize): Initialize the bidi cache start stack pointer.
833 (bidi_cache_ensure_space): New function, refactored from part of
834 bidi_cache_iterator_state. Don't assume the required size is just
835 one BIDI_CACHE_CHUNK away.
836 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
837 (bidi_count_bytes, bidi_char_at_pos): New functions.
838 (bidi_cache_search): Don't assume bidi_cache_last_idx is
839 always valid if bidi_cache_idx is valid.
840 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
841 is valid if it's going to be used.
842 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
843 (bidi_cache_fetch_state, bidi_cache_search)
844 (bidi_cache_find_level_change, bidi_cache_ensure_space)
845 (bidi_cache_iterator_state, bidi_cache_find)
846 (bidi_find_other_level_edge, bidi_cache_start_stack):
847 All variables related to cache indices are now EMACS_INT.
849 * dispextern.h (struct bidi_string_data): New structure.
850 (struct bidi_it): New member `string'. Make flag members be 1-bit
851 fields, and put them last in the struct.
852 (compute_display_string_pos, compute_display_string_end):
854 (bidi_push_it, bidi_pop_it): Add prototypes.
855 (struct iterator_stack_entry): New members bidi_p,
856 paragraph_embedding, and from_disp_prop_p.
857 (struct it): Member bidi_p is now a bit field 1 bit wide.
858 (bidi_shelve_cache, bidi_unshelve_cache):
861 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
862 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
863 and vector-like objects.
865 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
866 cache around display iteration.
868 * window.c (Fwindow_end, window_scroll_pixel_based)
869 (displayed_window_lines, Frecenter): Save and restore the bidi
870 cache around display iteration.
872 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
874 * editfns.c (Fdelete_region): Clarify the use of the named
875 parameters (bug#6788).
877 2011-07-14 Martin Rudalics <rudalics@gmx.at>
879 * indent.c (Fvertical_motion): Set and restore w->pointm when
880 saving and restoring the window's buffer (Bug#9006).
882 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
884 * editfns.c (Fstring_to_char): Clarify just what is returned
885 (bug#6576). Text by Eli Zaretskii.
887 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
889 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
891 2011-07-13 Eli Zaretskii <eliz@gnu.org>
893 * buffer.c (mmap_find): Fix a typo.
895 2011-07-13 Johan Bockgård <bojohan@gnu.org>
897 Fix execution of x selection hooks.
898 * xselect.c (Qx_lost_selection_functions)
899 (Qx_sent_selection_functions): New vars.
900 (syms_of_xselect): DEFSYM them.
901 (x_handle_selection_request): Pass Qx_sent_selection_functions
902 rather than Vx_sent_selection_functions to Frun_hook_with_args.
903 (x_handle_selection_clear,x_clear_frame_selections):
904 Pass Qx_lost_selection_functions rather than
905 Vx_lost_selection_functions to Frun_hook_with_args.
907 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
909 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
910 The old code sometimes used this field without initializing it.
912 * alloc.c (gc_sweep): Don't read past end of array.
913 In theory, the old code could also have corrupted Emacs internals,
914 though it'd be very unlikely.
916 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
918 * character.c (Fcharacterp): Don't advertise optional ignored
921 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
923 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
926 * window.c (Fset_window_start): Doc fix (bug#4199).
927 (Fset_window_hscroll): Ditto.
929 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
931 Fix minor new problems caught by GCC 4.6.1.
932 * term.c (init_tty): Remove unused local.
933 * xsettings.c (store_monospaced_changed): Define this function only
934 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
937 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
939 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
941 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
943 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
944 are the mini-buffer and the echo area (bug#3320).
946 * term.c (init_tty): Remove support for supdup, c10 and perq
947 terminals, which are no longer supported (bug#1482).
949 2011-07-10 Johan Bockgård <bojohan@gnu.org>
951 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
953 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
955 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
956 for non-popups (Bug#3642).
958 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
960 * alloc.c (reset_malloc_hooks): Protoize.
961 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
962 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
963 * cm.c (losecursor): Likewise.
964 * data.c (fmod): Likewise.
965 * dispnew.c (swap_glyphs_in_rows): Likewise.
966 * emacs.c (memory_warning_signal): Likewise.
967 * floatfns.c (float_error): Likewise.
968 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
969 (otf_open, font_otf_capability, generate_otf_features)
970 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
972 * image.c (pbm_read_file): Likewise.
973 * indent.c (string_display_width): Likewise.
974 * intervals.c (check_for_interval, search_for_interval)
975 (inc_interval_count, count_intervals, root_interval)
976 (adjust_intervals_for_insertion, make_new_interval): Likewise.
977 * lread.c (defalias): Likewise.
978 * ralloc.c (r_alloc_check): Likewise.
979 * regex.c (set_image_of_range_1, set_image_of_range)
980 (regex_grow_registers): Likewise.
981 * sysdep.c (strerror): Likewise.
982 * termcap.c (valid_filename_p, tprint, main): Likewise.
983 * tparam.c (main): Likewise.
984 * unexhp9k800.c (run_time_remap, save_data_space)
985 (update_file_ptrs, read_header, write_header, calculate_checksum)
986 (copy_file, copy_rest, display_header): Likewise.
987 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
989 * xdisp.c (check_it): Likewise.
990 * xfaces.c (register_color, unregister_color, unregister_colors):
992 * xfns.c (print_fontset_result): Likewise.
993 * xrdb.c (member, fatal, main): Likewise.
995 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
997 Fix minor problems found by static checking (Bug#9031).
998 * chartab.c (char_table_set_range, map_sub_char_table):
999 Remove unused locals.
1000 (uniprop_table): Now static.
1001 * composite.c (_work_char): Remove unused static var.
1003 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1005 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1007 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1009 * gtkutil.c (qttip_cb): Remove code without function.
1011 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1013 * w32.c (pthread_sigmask): New stub.
1015 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1017 Use pthread_sigmask, not sigprocmask (Bug#9010).
1018 sigprocmask is portable only for single-threaded applications, and
1019 Emacs can be multi-threaded when it uses GTK.
1020 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1022 * callproc.c (Fcall_process):
1023 * process.c (create_process):
1024 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1025 Use pthread_sigmask, not sigprocmask.
1027 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1029 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1030 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1033 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1035 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1036 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1037 (xg_hide_tooltip): Fix comment.
1039 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1040 in registerServicesMenuSendTypes.
1041 (validRequestorForSendType): Don't check ns_return_types.
1043 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1046 2011-07-08 Jason Rumney <jasonr@gnu.org>
1048 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1049 frame struct members of non-existent frames (Bug#6284).
1051 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1053 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1054 variable firstTime not needed on OSX >= 10.6.
1055 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1056 >= 10.5. Use setKnobProportion, setDoubleValue.
1058 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1059 (MAC_OS_X_VERSION_10_5): Define if not defined.
1060 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1061 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1062 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1064 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1065 cString and lossyCString on OSX >= 10.4
1067 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1068 sizeToFit on OSX >= 10.2.
1070 * nsimage.m (allocInitFromFile): Don't use deprecated method
1071 bestRepresentationForDevice on OSX >= 10.6.
1073 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1076 * emacs.c: Declare unexec_init_emacs_zone.
1078 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1080 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1082 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1083 on svcsMenu (Bug#8842).
1085 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1087 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1089 * nsterm.m (QUTF8_STRING): Declare.
1090 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1091 (validRequestorForSendType): Return type is (id).
1092 Change indexOfObjectIdenticalTo to indexOfObject.
1093 Check if we have local selection before returning self (Bug#8842).
1094 (writeSelectionToPasteboard): Put local selection into paste board
1095 if we have a local selection (Bug#8842).
1096 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1098 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1099 (ns_get_local_selection): Declare.
1101 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1103 * keymap.c (describe_map_tree): Don't insert a double newline at
1104 the end of the buffer (bug#1169) and return whether we inserted
1107 * callint.c (Fcall_interactively): Change "reading args" to
1108 "providing args" to try to clarify what it does (bug#1010).
1110 2011-07-07 Kenichi Handa <handa@m17n.org>
1112 * composite.c (composition_compute_stop_pos): Ignore a static
1113 composition starting before CHARPOS (Bug#8915).
1115 * xdisp.c (handle_composition_prop): Likewise.
1117 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1119 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1122 2011-07-07 Kenichi Handa <handa@m17n.org>
1124 * character.h (unicode_category_t): New enum type.
1126 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1127 (Qchar_code_property_table): New variable.
1128 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1129 (UNIPROP_COMPRESSED_FORM_P): New macros.
1130 (char_table_ascii): Uncompress the compressed values.
1131 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1132 Uncompress the compressed values.
1133 (sub_char_table_ref_and_range): Likewise.
1134 (char_table_ref_and_range): Uncompress the compressed values.
1135 (sub_char_table_set): New arg is_uniprop. Callers changed.
1136 Uncompress the compressed values.
1137 (sub_char_table_set_range): Args changed. Callers changed.
1138 (char_table_set_range): Adjuted for the above change.
1139 (map_sub_char_table): Delete args default_val and parent. Add arg
1140 top. Give decoded values to a Lisp function.
1141 (map_char_table): Adjust for the above change. Give decoded
1142 values to a Lisp function. Gcpro more variables.
1143 (uniprop_table_uncompress)
1144 (uniprop_decode_value_run_length): New functions.
1145 (uniprop_decoder, uniprop_decoder_count): New variables.
1146 (uniprop_get_decoder, uniprop_encode_value_character)
1147 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1149 (uniprop_encoder, uniprop_encoder_count): New variables.
1150 (uniprop_get_encoder, uniprop_table)
1151 (Funicode_property_table_internal, Fget_unicode_property_internal)
1152 (Fput_unicode_property_internal): New functions.
1153 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1154 Sunicode_property_table_internal, Sget_unicode_property_internal,
1155 and Sput_unicode_property_internal. Defvar_lisp
1156 char-code-property-alist.
1158 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1159 Vunicode_category_table.
1161 * font.c (font_range): Adjust for the change of
1162 Vunicode_category_table.
1164 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1166 * m/iris4d.h: Remove file, move contents ...
1167 * s/irix6-5.h: ... here.
1169 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1171 Remove unportable assumption about struct layout (Bug#8884).
1172 * alloc.c (mark_buffer):
1173 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1174 (clone_per_buffer_values): Don't assume that
1175 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1176 This isn't true in general, and it's particularly not true
1177 if Emacs is configured with --with-wide-int.
1178 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1179 New macros, used in the buffer.c change.
1181 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1183 * xsettings.c: Use both GConf and GSettings if both are available.
1184 (store_config_changed_event): Add comment.
1185 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1186 (store_tool_bar_style_changed): New functions.
1187 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1188 (struct xsettings): Move font inside HAVE_XFT.
1189 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1190 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1191 Move inside HAVE_XFT.
1192 (something_changed_gsettingsCB): Rename from something_changedCB.
1193 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1195 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1196 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1197 (something_changed_gconfCB): Rename from something_changedCB.
1198 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1199 (parse_settings): Move check for font inside HAVE_XFT.
1200 (read_settings, apply_xft_settings): Add comment.
1201 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1202 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1203 call store_font_name_changed.
1204 (xft_settings_event): Add comment.
1205 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1206 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1207 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1208 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1209 (xsettings_initialize): Call init_gsettings last.
1210 (xsettings_get_system_font, xsettings_get_system_normal_font):
1213 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1215 Random fixes. E.g., (random) never returned negative values.
1216 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1217 subseconds part to the entropy, as that's a bit more random.
1218 Prefer signed to unsigned, since the signedness doesn't matter and
1219 in general we prefer signed. When given a limit, use a
1220 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1221 latter isn't right if USE_2_TAGS_FOR_INTS.
1222 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1223 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1225 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1227 * textprop.c (text_property_stickiness):
1228 Obey Vtext_property_default_nonsticky.
1229 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1230 * w32fns.c (syms_of_w32fns):
1231 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1233 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1235 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1236 This is more efficient than Ffile_directory_p and avoids a minor race.
1238 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1240 * buffer.c (Foverlay_put): Say what the return value is
1243 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1244 is a directory before asking whether to use the file name
1246 (barf_or_query_if_file_exists): Make the "File is a directory"
1247 error be more correct.
1249 * fns.c (Frequire): Remove the mention of the .gz files, since
1250 that's installation-specific, but keep the mention of
1251 `get-load-suffixes'.
1253 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1255 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1256 Report string overflow if the output is too long.
1258 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1260 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1261 (syms_of_gnutls): Remove duplicate DEFSYM for
1262 Qgnutls_bootprop_verify_hostname_error, an error for
1263 Qgnutls_bootprop_verify_error (which is no longer used).
1265 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1266 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1267 Also (re)move comments that are misplaced or no longer relevant.
1269 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1271 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1273 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1275 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1276 and background color parameters if they have been changed.
1278 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1280 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1282 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1284 * xsettings.c (SYSTEM_FONT): Define only when used.
1285 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1287 * keymap.c (access_keymap_1): Now static.
1289 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1291 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1292 leave any prefix arg for the up event (Bug#1586).
1294 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1296 * lread.c (syms_of_lread): Mention single symbols defined by
1297 `defvar' or `defconst' (bug#7154).
1299 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1300 (Frequire): Mention get-load-suffixes.
1302 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1304 * window.h (window): Remove clone_number slot.
1305 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1307 (make_parent_window, make_window, saved_window)
1308 (Fset_window_configuration, save_window_save): Don't deal with
1310 * buffer.c (Qclone_number): Remove declaration.
1311 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1313 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1315 Add multiple inheritance to keymaps.
1316 * keymap.c (Fmake_composed_keymap): New function.
1317 (Fset_keymap_parent): Simplify.
1318 (fix_submap_inheritance): Remove.
1319 (access_keymap_1): New function extracted from access_keymap to handle
1320 embedded parents and handle lists of maps.
1321 (access_keymap): Use it.
1322 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1323 (Fcopy_keymap): Handle embedded parents.
1324 (Fcommand_remapping, define_as_prefix): Simplify.
1325 (Fkey_binding): Simplify.
1326 (syms_of_keymap): Move minibuffer-local-completion-map,
1327 minibuffer-local-filename-completion-map,
1328 minibuffer-local-must-match-map, and
1329 minibuffer-local-filename-must-match-map to Elisp.
1330 (syms_of_keymap): Defsubr make-composed-keymap.
1331 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1332 (parse_menu_item): Trivial simplification.
1334 2011-07-01 Glenn Morris <rgm@gnu.org>
1336 * Makefile.in (SETTINGS_LIBS): Fix typo.
1338 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1340 * coding.c (Fencode_coding_string): Record the last coding system
1341 used, as the function doc string says (bug#8738).
1343 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1345 * xsettings.c (store_monospaced_changed): Take new font as arg and
1346 check for change against current_mono_font.
1347 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1348 (emacs_settings_constructor, emacs_settings_get_property)
1349 (emacs_settings_set_property, emacs_settings_class_init)
1350 (emacs_settings_init, gsettings_obj): Remove.
1351 (something_changedCB): New function for HAVE_GSETTINGS.
1352 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1353 with value as argument.
1354 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1355 g_settings_new (Bug#8967). Do not create gsettings_obj.
1356 Remove calls to g_settings_bind. Connect something_changedCB to
1359 * xgselect.c: Add defined (HAVE_GSETTINGS).
1360 (xgselect_initialize): Ditto.
1362 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1363 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1366 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1368 * eval.c (struct backtrace): Simplify and port the data structure.
1369 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1370 signed bit field, as this assumption is not portable and it makes
1371 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1372 "char debug_on_exit : 1" as this is not portable either; instead,
1373 use the portable "unsigned int debug_on_exit : 1". Remove unused
1374 member evalargs. Remove obsolete comments about cc bombing out.
1376 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1378 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1379 Let HAVE_GSETTINGS override HAVE_GCONF.
1380 (store_monospaced_changed): New function.
1381 (EMACS_SETTINGS): A new type derived from GObject to handle
1382 GSettings notifications.
1383 (emacs_settings_constructor, emacs_settings_get_property)
1384 (emacs_settings_set_property, emacs_settings_class_init):
1386 (gsettings_client, gsettings_obj): New variables.
1387 (GSETTINGS_SCHEMA): New define.
1388 (something_changedCB): Call store_monospaced_changed.
1389 (init_gsettings): New function.
1390 (xsettings_initialize): Call init_gsettings.
1391 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1394 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1397 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1399 * window.c (resize_root_window, grow_mini_window)
1400 (shrink_mini_window): Rename Qresize_root_window to
1401 Qwindow_resize_root_window and Qresize_root_window_vertically to
1402 Qwindow_resize_root_window_vertically.
1404 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1406 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1408 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1410 * makefile.w32-in: Redesign dependencies so they reflect more
1411 clearly which files are directly included by each source file,
1412 and not through other includes.
1414 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1416 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1417 (sort_overlays, overlay_strings): When an overlay's clone number
1418 matches the window's clone number process the overlay even if
1419 the overlay's window property doesn't match the current window.
1421 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1422 (Fwindow_hchild): Rename to Fwindow_left_child.
1423 (Fwindow_next): Rename to Fwindow_next_sibling.
1424 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1425 (resize_window_check): Rename to window_resize_check.
1426 (resize_window_apply): Rename to window_resize_apply.
1427 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1428 (Fdelete_other_windows_internal, resize_frame_windows)
1429 (Fsplit_window_internal, Fdelete_window_internal)
1430 (grow_mini_window, shrink_mini_window)
1431 (Fresize_mini_window_internal): Fix callers accordingly.
1433 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1435 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1436 (emacs_fixed_set_min_size): Remove.
1437 (emacs_fixed_new): Take frame as argument.
1439 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1440 (_EmacsFixedPrivate): Remove minwidth/height.
1441 Add struct frame *f.
1442 (emacs_fixed_init): Initialize priv->f.
1443 (get_parent_class, emacs_fixed_set_min_size): Remove.
1444 (emacs_fixed_new): Set priv->f to argument.
1445 (emacs_fixed_get_preferred_width)
1446 (emacs_fixed_get_preferred_height): Use min_width/height from
1447 frames size_hint to set minimum and natural (Bug#8919).
1448 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1449 and use min_width/height from frames size_hint to set
1450 min_width/height (Bug#8919).
1452 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1453 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1456 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1458 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1459 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1462 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1464 * process.c (wait_reading_process_output): Bypass select if
1465 waiting for a cell while ignoring keyboard input, and input is
1466 pending. Suggested by Jan Djärv (Bug#8869).
1468 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1470 Use gnulib's dup2 module instead of rolling our own.
1471 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1473 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1475 * dispnew.c (scrolling_window): Before scrolling, turn off a
1476 mouse-highlight in the window being scrolled.
1478 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1480 Move DEFSYM to lisp.h and use everywhere.
1482 * character.h (DEFSYM): Move declaration...
1483 * lisp.h (DEFSYM): ...here.
1489 * w32select.c: Don't include character.h.
1491 * alloc.c (syms_of_alloc):
1492 * buffer.c (syms_of_buffer):
1493 * bytecode.c (syms_of_bytecode):
1494 * callint.c (syms_of_callint):
1495 * casefiddle.c (syms_of_casefiddle):
1496 * casetab.c (init_casetab_once):
1497 * category.c (init_category_once, syms_of_category):
1498 * ccl.c (syms_of_ccl):
1499 * cmds.c (syms_of_cmds):
1500 * composite.c (syms_of_composite):
1501 * dbusbind.c (syms_of_dbusbind):
1502 * dired.c (syms_of_dired):
1503 * dispnew.c (syms_of_display):
1504 * doc.c (syms_of_doc):
1505 * editfns.c (syms_of_editfns):
1506 * emacs.c (syms_of_emacs):
1507 * eval.c (syms_of_eval):
1508 * fileio.c (syms_of_fileio):
1509 * fns.c (syms_of_fns):
1510 * frame.c (syms_of_frame):
1511 * fringe.c (syms_of_fringe):
1512 * insdel.c (syms_of_insdel):
1513 * keymap.c (syms_of_keymap):
1514 * lread.c (init_obarray, syms_of_lread):
1515 * macros.c (syms_of_macros):
1516 * msdos.c (syms_of_msdos):
1517 * print.c (syms_of_print):
1518 * process.c (syms_of_process):
1519 * search.c (syms_of_search):
1520 * sound.c (syms_of_sound):
1521 * syntax.c (init_syntax_once, syms_of_syntax):
1522 * terminal.c (syms_of_terminal):
1523 * textprop.c (syms_of_textprop):
1524 * undo.c (syms_of_undo):
1525 * w32.c (globals_of_w32):
1526 * window.c (syms_of_window):
1527 * xdisp.c (syms_of_xdisp):
1528 * xfaces.c (syms_of_xfaces):
1529 * xfns.c (syms_of_xfns):
1530 * xmenu.c (syms_of_xmenu):
1531 * xsettings.c (syms_of_xsettings):
1532 * xterm.c (syms_of_xterm): Use DEFSYM.
1534 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1536 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1538 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1540 Integer and buffer overflow fixes (Bug#8873).
1542 * print.c (printchar, strout): Check for string overflow.
1543 (PRINTPREPARE, printchar, strout):
1544 Don't set size unless allocation succeeds.
1546 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1547 for sizes. Check for string overflow more accurately.
1548 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1550 * macros.c: Integer and buffer overflow fixes.
1551 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1552 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1553 Use ptrdiff_t, not int, for sizes.
1554 Don't increment bufsize until after realloc succeeds.
1555 Check for size-calculation overflow.
1556 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1558 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1560 * lread.c: Integer overflow fixes.
1561 (read_integer): Radix is now EMACS_INT, not int,
1562 to improve quality of diagnostics for out-of-range radices.
1563 Calculate buffer size correctly for out-of-range radices.
1564 (read1): Check for integer overflow in radices, and in
1565 read-circle numbers.
1566 (read_escape): Avoid int overflow.
1567 (Fload, openp, read_buffer_size, read1)
1568 (substitute_object_recurse, read_vector, read_list, map_obarray):
1569 Use ptrdiff_t, not int, for sizes.
1570 (read1): Use EMACS_INT, not int, for sizes.
1571 Check for size overflow.
1573 * image.c (cache_image): Check for size arithmetic overflow.
1575 * lread.c: Integer overflow issues.
1576 (saved_doc_string_size, saved_doc_string_length)
1577 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1578 Now ptrdiff_t, not int.
1579 (read1): Don't assume doc string length fits in int. Check for
1580 out-of-range doc string lengths.
1581 (read_list): Don't assume file position fits in int.
1582 (read_escape): Check for hex character overflow.
1584 2011-06-22 Leo Liu <sdl.web@gmail.com>
1586 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1587 Move to minibuffer.el.
1589 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1591 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1592 The following patches are for when GLYPH_DEBUG && !XASSERT.
1593 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1594 * dispnew.c (flush_stdout):
1595 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1596 Mark as externally visible.
1597 * dispnew.c (check_window_matrix_pointers): Now static.
1598 * dispnew.c (window_to_frame_vpos):
1599 * xfns.c (unwind_create_frame):
1600 * xterm.c (x_check_font): Remove unused local.
1601 * scroll.c (CHECK_BOUNDS):
1602 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1603 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1604 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1605 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1606 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1608 (debug_method_add): Use va_list and vsprintf rather than relying
1609 on undefined behavior with wrong number of arguments.
1610 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1611 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1612 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1613 since we're not interested in debugging glyphs with old libraries.
1614 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1615 GCC 4.6.0's static checking.
1617 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1619 Integer overflow and signedness fixes (Bug#8873).
1620 A few related buffer overrun fixes, too.
1622 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1624 * dispextern.h (struct face.stipple):
1625 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1626 (x_bitmap_mask, x_allocate_bitmap_record)
1627 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1628 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1629 (x_create_bitmap_from_xpm_data):
1630 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1631 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1633 * xfaces.c (load_pixmap):
1634 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1635 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1636 (.bitmaps_last, struct x_output.icon_bitmap):
1637 Use ptrdiff_t, not int, for bitmap indexes.
1638 (x_allocate_bitmap_record): Check for size overflow.
1639 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1641 Use ptrdiff_t, not int, for overlay counts.
1642 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1643 * editfns.c (overlays_around, get_pos_property):
1644 * textprop.c (get_char_property_and_overlay):
1645 * xdisp.c (next_overlay_change, note_mouse_highlight):
1646 * xfaces.c (face_at_buffer_position):
1647 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1648 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1649 (Fnext_overlay_change, Fprevious_overlay_change)
1650 (mouse_face_overlay_overlaps, Foverlays_in):
1651 Use ptrdiff_t, not int, for sizes.
1652 (overlays_at, overlays_in): Check for size-calculation overflow.
1654 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1656 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1657 (x_session_initialize): Do not assume string length fits in int.
1659 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1660 This is unlikely, but can occur if DPI is outlandish.
1662 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1663 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1665 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1666 * xrdb.c (magic_file_p, search_magic_path):
1667 Omit last arg SUFFIX; it was always 0. All callers changed.
1668 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1670 * xfont.c (xfont_match): Avoid need for strlen.
1672 * xfns.c: Don't assume strlen fits in int.
1673 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1675 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1676 not unsigned long, as we prefer signed integers. All callers changed.
1677 Detect integer overflow in repeat count.
1678 (message_dolog): Don't assume print length fits in 39 bytes.
1679 (display_mode_element): Don't assume strlen fits in int.
1681 * termcap.c: Don't assume sizes fit in int and never overflow.
1682 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1683 (gobble_line): Check for size-calculation overflow.
1685 * minibuf.c (Fread_buffer):
1686 * lread.c (intern, intern_c_string):
1687 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1688 Don't assume string length fits in int.
1690 * keyboard.c (parse_tool_bar_item):
1691 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1693 * font.c: Don't assume string length fits in int.
1694 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1695 Use ptrdiff_t, not int.
1696 (font_intern_prop): Don't assume string length fits in int.
1697 Don't assume integer property fits in fixnum.
1698 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1700 * filelock.c: Fix some buffer overrun and integer overflow issues.
1701 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1702 Reformulate so as not to need the command string.
1703 Invoke gzip -cd rather than gunzip, as it's more portable.
1704 (lock_info_type, lock_file_1, lock_file):
1705 Don't assume pid_t and time_t fit in unsigned long.
1706 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1707 (current_lock_owner): Prefer signed type for sizes.
1708 Use memcpy, not strncpy, where memcpy is what is really wanted.
1709 Don't assume (via atoi) that time_t and pid_t fit in int.
1710 Check for time_t and/or pid_t out of range, e.g., via a network share.
1711 Don't alloca where an auto var works fine.
1713 * fileio.c: Fix some integer overflow issues.
1714 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1715 Don't assume string length fits in int.
1716 (directory_file_name): Don't assume string length fits in long.
1717 (make_temp_name): Don't assume pid fits in int, or that its print
1718 length is less than 20.
1720 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1722 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1724 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1726 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1727 We prefer signed integers, even for size calculations.
1729 * emacs.c: Don't assume string length fits in 'int'.
1730 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1731 (main): Don't invoke strlen when not needed.
1733 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1734 (XD_DEBUG_MESSAGE): Don't waste a byte.
1736 * callproc.c (getenv_internal_1, getenv_internal)
1738 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1740 * lread.c (invalid_syntax): Omit length argument.
1741 All uses changed. This doesn't fix a bug, but it simplifies the
1742 code away from its former Hollerith-constant appearance, and it's
1743 one less 'int' to worry about when looking at integer-overflow issues.
1744 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1746 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1747 This didn't break anything, but it didn't help either.
1748 It's confusing to put a bogus integer in a place where the actual
1749 value does not matter.
1750 (LIST_END_P): Remove unused macro and its bogus comment.
1751 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1753 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1754 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1756 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1757 We prefer signed types, and the value cannot exceed the EMACS_INT
1758 range anyway (because otherwise the length would not be representable).
1759 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1760 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1761 This avoids a GCC warning when WIDE_EMACS_INT.
1763 * indent.c (sane_tab_width): New function.
1764 (current_column, scan_for_column, Findent_to, position_indentation)
1765 (compute_motion): Use it. This is just for clarity.
1766 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1768 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1770 * lisp.h (lint_assume): New macro.
1771 * composite.c (composition_gstring_put_cache):
1772 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1774 * editfns.c, insdel.c:
1775 Omit unnecessary forward decls, to simplify future changes.
1777 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1779 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1781 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1782 Use much-faster test for byte-length change.
1783 Don't assume string byte-length fits in 'int'.
1784 Check that character arg fits in 'int'.
1785 (mapcar1): Declare byte as byte, for clarity.
1787 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1789 * fns.c (concat): Catch string overflow earlier.
1790 Do not rely on integer wraparound.
1792 * dispextern.h (struct it.overlay_strings_charpos)
1793 (struct it.selective): Now EMACS_INT, not int.
1794 * xdisp.c (forward_to_next_line_start)
1795 (back_to_previous_visible_line_start)
1796 (reseat_at_next_visible_line_start, next_element_from_buffer):
1797 Don't arbitrarily truncate the value of 'selective' to int.
1799 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1801 * composite.c: Don't truncate sizes to 'int'.
1802 (composition_gstring_p, composition_reseat_it)
1803 (composition_adjust_point): Use EMACS_INT, not int.
1804 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1805 not EMACS_UINT, for indexes.
1807 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1809 * buffer.c: Include <verify.h>.
1810 (struct sortvec.priority, struct sortstr.priority):
1811 Now EMACS_INT, not int.
1812 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1813 (struct sortstr.size, record_overlay_string)
1814 (struct sortstrlist.size, struct sortlist.used):
1815 Don't truncate size to int.
1816 (record_overlay_string): Check for size-calculation overflow.
1817 (init_buffer_once): Check at compile-time, not run-time.
1819 2011-06-22 Jim Meyering <meyering@redhat.com>
1821 Don't leak an XBM-image-sized buffer
1822 * image.c (xbm_load): Free the image buffer after using it.
1824 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1827 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1828 that Sun C diagnosed.
1829 * fns.c (secure_hash): Fix pointer signedness issue.
1830 * intervals.c (static_offset_intervals): New function.
1831 (offset_intervals): Use it.
1833 2011-06-21 Leo Liu <sdl.web@gmail.com>
1836 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1839 * fns.c (secure_hash): Rename from crypto_hash_function and change
1840 the first arg to accept symbols.
1841 (Fsecure_hash): New primitive.
1842 (syms_of_fns): New symbols.
1844 2011-06-20 Deniz Dogan <deniz@dogan.se>
1846 * process.c (Fset_process_buffer): Clarify return value in
1849 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1851 * dispnew.c (add_window_display_history): Use BVAR.
1853 * xdisp.c (debug_method_add): Use BVAR.
1854 (check_window_end, dump_glyph_matrix, dump_glyph)
1855 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1857 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1860 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1861 check till after the cache is created in init_frame_faces.
1863 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1865 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1867 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1869 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1870 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1871 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1873 Improve buffer-overflow checking (Bug#8873).
1874 * fileio.c (Finsert_file_contents):
1875 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1876 Remove the old (too-loose) buffer overflow checks.
1877 They weren't needed, since make_gap checks for buffer overflow.
1878 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1879 The old code merely checked for Emacs fixnum overflow, and relied
1880 on undefined (wraparound) behavior. The new code avoids undefined
1881 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1883 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1884 Tune. Don't use wider integers than needed. Don't use alloca.
1885 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1887 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1889 * insdel.c, lisp.h (buffer_overflow): New function.
1890 (insert_from_buffer_1, replace_range, replace_range_2):
1891 * insdel.c (make_gap_larger):
1892 * editfns.c (Finsert_char):
1893 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1895 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1897 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1899 Integer overflow and signedness fixes (Bug#8873).
1901 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1902 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1904 * fileio.c: Don't assume EMACS_INT fits in off_t.
1905 (emacs_lseek): New static function.
1906 (Finsert_file_contents, Fwrite_region): Use it.
1907 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1909 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1911 * fns.c: Don't overflow int when computing a list length.
1912 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1913 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1914 truncation on 64-bit hosts. Check for QUIT every
1915 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1916 faster and is responsive enough.
1917 (Flength): Report an error instead of overflowing an integer.
1918 (Fsafe_length): Return a float if the value is not representable
1919 as a fixnum. This shouldn't happen except in contrived situations.
1920 (Fnthcdr, Fsort): Don't assume list length fits in int.
1921 (Fcopy_sequence): Don't assume vector length fits in int.
1923 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1924 (header_size, word_size): New constants.
1925 (allocate_vectorlike): Don't check size overflow here.
1926 (allocate_vector): Check it here instead, since this is the only
1927 caller of allocate_vectorlike that could cause overflow.
1928 Check that the new vector's length is representable as a fixnum.
1930 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1931 The previous code was bogus. For example, next_almost_prime (32)
1932 returned 39, which is undesirable as it is a multiple of 3; and
1933 next_almost_prime (24) returned 25, which is a multiple of 5 so
1934 why was the code bothering to check for multiples of 7?
1936 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1938 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1940 Variadic C functions now count arguments with ptrdiff_t.
1941 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1942 Back then I didn't know that the Emacs coding style prefers signed int.
1943 Also, in the meantime I found a few more instances where arguments
1944 were being counted with int, which may truncate counts on 64-bit
1945 machines, or EMACS_INT, which may be unnecessarily wide.
1946 * lisp.h (struct Lisp_Subr.function.aMANY)
1947 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1948 Arg counts are now ptrdiff_t, not size_t.
1949 All variadic functions and their callers changed accordingly.
1950 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1951 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1952 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1953 * callint.c (Fcall_interactively): Check arg count for overflow,
1954 to avoid potential buffer overrun. Use signed char, not 'int',
1955 for 'varies' array, so that we needn't bother to check its size
1956 calculation for overflow.
1957 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1958 * eval.c (apply_lambda):
1959 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1960 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1961 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1963 * callint.c (Fcall_interactively): Don't use index var as event count.
1965 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1966 * mem-limits.h (SIZE): Remove; no longer used.
1968 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1970 Remove unnecessary casts.
1971 * xterm.c (x_term_init):
1972 * xfns.c (x_set_border_pixel):
1973 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1974 These aren't needed now that we assume ANSI C.
1976 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1977 It's more likely to cause problems (due to unsigned overflow)
1980 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1982 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1984 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1986 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1988 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1990 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1992 GLYPH_CODE_FACE returns EMACS_INT, not int.
1993 * dispextern.h (merge_faces):
1994 * xfaces.c (merge_faces):
1995 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1996 Don't assume EMACS_INT fits in int.
1998 * character.h (CHAR_VALID_P): Remove unused parameter.
1999 * fontset.c, lisp.h, xdisp.c: All uses changed.
2001 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2003 * fns.c (concat): Minor tuning based on overflow analysis.
2004 This doesn't fix any bugs. Use int to hold character, instead
2005 of constantly refetching from Emacs object. Use XFASTINT, not
2006 XINT, for value known to be a character. Don't bother comparing
2007 a single byte to 0400, as it's always less.
2009 * floatfns.c (Fexpt):
2010 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2012 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2015 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2017 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2018 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2019 incorrectly succeed when S was a string, because 4294967386 was
2020 truncated before it was used.
2022 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2023 Otherwise, an out-of-range integer could cause undefined behavior
2026 * composite.c: Use int, not EMACS_INT, for characters.
2027 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2028 EMACS_INT, for values that are known to be in character range.
2029 This doesn't fix any bugs but is the usual style inside Emacs and
2030 may generate better code on 32-bit machines.
2032 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2033 This is for reasons similar to the recent CHAR_STRING fix.
2034 * charset.c (Fencode_char): Check that character arg is actually
2035 a character. Pass an int to ENCODE_CHAR.
2036 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2037 wider than 'int', as a compile-time check to prevent future regressions
2040 * character.c (char_string): Remove unnecessary casts.
2042 Make sure a 64-bit char is never passed to CHAR_STRING.
2043 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2044 by silently ignoring the top 32 bits, allowing some values
2045 that were far too large to be valid characters.
2046 * character.h: Include <verify.h>.
2047 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2048 arguments are no wider than unsigned, as a compile-time check
2049 to prevent future regressions in this area.
2051 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2052 (Fsubst_char_in_region):
2054 * xdisp.c (decode_mode_spec_coding):
2055 Adjust to CHAR_STRING's new requirement.
2056 * editfns.c (Finsert_char, Fsubst_char_in_region):
2057 * fns.c (concat): Check that character args are actually
2058 characters. Without this test, these functions did the wrong
2059 thing with wildly out-of-range values on 64-bit hosts.
2061 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2062 These casts should not be needed on 32-bit hosts, either.
2063 * keyboard.c (read_char):
2064 * lread.c (Fload): Remove casts to unsigned.
2066 * lisp.h (UNSIGNED_CMP): New macro.
2067 This fixes comparison bugs on 64-bit hosts.
2068 (ASCII_CHAR_P): Use it.
2069 * casefiddle.c (casify_object):
2070 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2071 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2072 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2073 * dispextern.h (FACE_FROM_ID):
2074 * keyboard.c (read_char): Use UNSIGNED_CMP.
2076 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2077 not to EMACS_INT, to avoid GCC warning.
2079 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2081 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2082 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2083 isn't needed on 32-bit machines.
2085 * buffer.c (Fgenerate_new_buffer_name):
2086 Use EMACS_INT for count, not int.
2087 (advance_to_char_boundary): Return EMACS_INT, not int.
2089 * data.c (Qcompiled_function): Now static.
2091 * window.c (window_body_lines): Now static.
2093 * image.c (gif_load): Rename local to avoid shadowing.
2095 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2096 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2097 * alloc.c (make_save_value): Integer argument is now of type
2099 (mark_object): Use ptrdiff_t, not int.
2100 * lisp.h (pD): New macro.
2101 * print.c (print_object): Use it.
2103 * alloc.c: Use EMACS_INT, not int, to count objects.
2104 (total_conses, total_markers, total_symbols, total_vector_size)
2105 (total_free_conses, total_free_markers, total_free_symbols)
2106 (total_free_floats, total_floats, total_free_intervals)
2107 (total_intervals, total_strings, total_free_strings):
2108 Now EMACS_INT, not int. All uses changed.
2109 (Fgarbage_collect): Compute overall total using a double, so that
2110 integer overflow is less likely to be a problem. Check for overflow
2111 when converting back to an integer.
2112 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2113 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2114 These were 'int' variables that could overflow on 64-bit hosts;
2115 they were never used, so remove them instead of repairing them.
2116 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2117 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2118 Previously, this ceilinged at INT_MAX, but that doesn't work on
2120 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2122 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2123 (allocate_vectorlike): Check for ptrdiff_t overflow.
2124 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2125 when a (possibly-narrower) signed value would do just as well.
2126 We prefer using signed arithmetic, to avoid comparison confusion.
2128 * alloc.c: Catch some string size overflows that we were missing.
2129 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2130 for convenience in STRING_BYTES_MAX.
2131 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2132 The definition here is exact; the one in lisp.h was approximate.
2133 (allocate_string_data): Check for string overflow. This catches
2134 some instances we weren't catching before. Also, it catches
2135 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2136 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2137 and ptrdiff_t and EMACS_INT are both 64 bits.
2139 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2140 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2141 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2143 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2145 * alloc.c (Fmake_string): Check for out-of-range init.
2147 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2149 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2151 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2153 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2154 xg_get_default_scrollbar_width.
2156 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2157 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2158 (style_changed_cb): Call update_theme_scrollbar_width and call
2159 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2160 all frames (Bug#8505).
2161 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2162 Call gtk_window_set_resizable if HAVE_GTK3.
2163 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2164 and height if HAVE_GTK3 (Bug#8505).
2165 (scroll_bar_width_for_theme): New variable.
2166 (update_theme_scrollbar_width): New function.
2167 (xg_get_default_scrollbar_width): Move code to
2168 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2169 (xg_initialize): Call update_theme_scrollbar_width.
2171 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2173 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2175 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2177 * frame.c (make_frame): Call other_buffer_safely instead of
2180 * window.c (temp_output_buffer_show): Call display_buffer with
2181 second argument Vtemp_buffer_show_specifiers and reset latter
2182 immediately after the call.
2183 (Vtemp_buffer_show_specifiers): New variable.
2184 (auto_window_vscroll_p, next_screen_context_lines)
2185 (Vscroll_preserve_screen_position): Remove leading asterisks from
2188 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2190 Fix minor problems found by GCC 4.6.0 static checking.
2191 * buffer.c (Qclone_number): Remove for now, as it's unused.
2192 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2193 (record_buffer): Remove unused local.
2194 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2195 (set_frame_buffer_list): Remove; unused.
2196 * frame.h (other_visible_frames): Remove decl.
2197 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2198 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2199 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2201 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2202 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2203 Define only if HAVE_GPM.
2204 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2205 (update_hints_inhibit): Remove; never set. All uses removed.
2206 * widgetprv.h (emacsFrameClassRec): Remove decl.
2207 * window.c (delete_deletable_window): Now returns void, since it
2208 wasn't returning anything.
2209 (compare_window_configurations): Remove unused locals.
2210 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2211 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2212 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2213 the same widths as pointers. This follows up on the 2011-05-06 patch.
2214 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2215 * xterm.h: Likewise.
2216 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2218 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2220 * makefile.w32-in: Update dependencies.
2221 (LISP_H): Add lib/intprops.h.
2223 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2225 * image.c (gif_load): Add animation frame delay to the metadata.
2226 (syms_of_image): Use DEFSYM. New symbol `delay'.
2228 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2230 * window.c (delete_deletable_window): Re-add.
2231 (Fset_window_configuration): Rewrite to handle dead buffers and
2232 consequently deletable windows.
2233 (window_tree, Fwindow_tree): Remove. Supply functionality in
2235 (compare_window_configurations): Simplify code.
2237 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2239 * image.c (imagemagick_load_image): Fix type mismatch.
2240 (Fimagemagick_types): Likewise.
2242 * window.h (replace_buffer_in_windows): Declare.
2244 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2246 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2247 Qclone_number. Remove external declaration of Qdelete_window.
2248 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2250 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2251 Run Qbuffer_list_update_hook if allowed.
2252 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2253 buffer list implementation.
2254 (other_buffer_safely): New function.
2255 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2256 calls to replace_buffer_in_windows and
2257 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2259 (record_buffer): Inhibit quitting and rewrite using quittable
2260 functions. Run Qbuffer_list_update_hook if allowed.
2261 (Frecord_buffer, Funrecord_buffer): New functions.
2262 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2263 Move switch-to-buffer to window.el.
2264 (bury-buffer): Move to window.el.
2265 (Vbuffer_list_update_hook): New variable.
2267 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2270 * window.h (resize_frame_windows): Move up in code.
2271 (Fwindow_frame): Remove EXFUN.
2272 (replace_buffer_in_all_windows): Remove prototype.
2273 (replace_buffer_in_windows_safely): Add prototype.
2275 * window.c: Declare Qdelete_window static again. Move down
2276 declaration of select_count.
2277 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2278 (Fother_window): Move to window.el.
2279 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2280 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2281 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2283 (replace_buffer_in_windows): Implement by calling
2284 Qreplace_buffer_in_windows.
2285 (replace_buffer_in_all_windows): Remove with some functionality
2286 moved into replace_buffer_in_windows_safely.
2287 (replace_buffer_in_windows_safely): New function.
2288 (select_window_norecord, select_frame_norecord): Move in front
2289 of run_window_configuration_change_hook. Remove now obsolete
2291 (Fset_window_buffer): Rewrite doc-string.
2292 Call Qrecord_window_buffer.
2293 (keys_of_window): Move binding for other-window to window.el.
2295 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2297 * dispextern.h (struct image): Replace data member, whose int_val
2298 and ptr_val fields were not used by anything, with a single
2301 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2302 (gif_clear_image, gif_load, imagemagick_load_image)
2303 (gs_clear_image, gs_load): Callers changed.
2305 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2307 * buffer.h: Include <time.h>, for time_t.
2308 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2310 Fix minor problems found by static checking.
2312 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2314 Make identifiers static if they are not used in other modules.
2315 * data.c (Qcompiled_function, Qframe, Qvector):
2316 * image.c (QimageMagick, Qsvg):
2317 * minibuf.c (Qmetadata):
2318 * window.c (resize_window_check, resize_root_window): Now static.
2319 * window.h (resize_window_check, resize_root_window): Remove decls.
2321 * window.c (window_deletion_count, delete_deletable_window):
2323 (window_body_lines): Now static.
2324 (Fdelete_other_windows_internal): Mark vars as initialized.
2325 Make sure 'resize_failed' is initialized.
2326 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2327 (resize_window_apply): Remove unused local.
2328 * window.h (delete_deletable_window): Remove decl.
2330 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2331 (imagemagick_load_image): Fix pointer signedness problem by changing
2332 last arg from unsigned char * to char *. All uses changed.
2333 Also, fix a local for similar reasons.
2334 Remove unused locals. Remove locals to avoid shadowing.
2335 (fn_rsvg_handle_free): Remove; unused.
2336 (svg_load, svg_load_image): Fix pointer signedness problem.
2337 (imagemagick_load_image): Don't use garbage pointer image_wand.
2339 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2341 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2343 * image.c (gif_load): Fix omitted cast error introduced by
2346 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2348 * window.h (resize_proportionally, orig_total_lines)
2349 (orig_top_line): Remove from window structure.
2350 (set_window_height, set_window_width, change_window_heights)
2351 (Fdelete_window): Remove prototypes.
2352 (resize_frame_windows): Remove duplicate declaration.
2354 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2356 * window.h (resize_frame_windows, resize_window_check)
2357 (delete_deletable_window, resize_root_window)
2358 (resize_frame_windows): Declare prototypes.
2360 * window.c (resize_window_apply): Make definition be "static" to
2361 match the prototype.
2363 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2365 * window.c: Remove declarations of Qwindow_size_fixed,
2366 window_min_size_1, window_min_size_2, window_min_size,
2367 size_window, window_fixed_size_p, enlarge_window, delete_window.
2368 Remove static from declaration of Qdelete_window, it's
2369 temporarily needed by Fbury_buffer.
2370 (replace_window): Don't assign orig_top_line and
2372 (Fdelete_window, delete_window): Remove. Window deletion is
2373 handled by window.el.
2374 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2375 Replace Fdelete_window calls with calls to Qdelete_window.
2376 (Fdelete_other_windows): Remove. Deleting other windows is
2377 handled by window.el.
2378 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2379 handled in window.el.
2380 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2381 Window minimum sizes are handled in window.el.
2382 (shrink_windows, size_window, set_window_height)
2383 (set_window_width, change_window_heights, window_height)
2384 (window_width, CURBEG, CURSIZE, enlarge_window)
2385 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2386 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2387 handled in window.el.
2388 (make_dummy_parent): Rename to make_parent_window and give it a
2389 second argument horflag.
2390 (make_window): Don't set resize_proportionally any more.
2391 (Fsplit_window): Remove. Windows are split in window.el.
2392 (save_restore_action, save_restore_orig_size)
2393 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2394 Resize mini windows in window.el.
2395 (grow_mini_window, shrink_mini_window): Implement by calling
2396 Qresize_root_window_vertically, resize_window_check and
2397 resize_window_apply.
2398 (saved_window, Fset_window_configuration, save_window_save):
2399 Do not handle orig_top_line, orig_total_lines, and
2400 resize_proportionally.
2401 (window_min_height, window_min_width): Move to window.el.
2402 (keys_of_window): Move bindings for delete-other-windows,
2403 split-window, delete-window and enlarge-window to window.el.
2405 * buffer.c: Temporarily extern Qdelete_window.
2406 (Fbury_buffer): Temporarily call Qdelete_window instead of
2407 Fdelete_window (Fbury_buffer will move to window.el soon).
2409 * frame.c (set_menu_bar_lines_1): Remove code handling
2410 orig_top_line and orig_total_lines.
2412 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2413 set_window_height but set heights directly.
2414 (change_frame_size_1): Use resize_frame_windows.
2416 * xdisp.c (init_xdisp): Don't use set_window_height but set
2419 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2420 Use resize_frame_windows instead of change_window_heights and run
2421 run_window_configuration_change_hook.
2423 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2424 instead of change_window_heights and run
2425 run_window_configuration_change_hook.
2427 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2429 * window.c (replace_window): Rename second argument REPLACEMENT to
2430 NEW. New third argument SETFLAG. Rewrite.
2431 (delete_window, make_dummy_parent): Call replace_window with
2433 (window_list_1): Move down in code.
2434 (run_window_configuration_change_hook): Move set_buffer part
2435 before select_frame_norecord part in order to unwind correctly.
2436 Rename count1 to count.
2437 (recombine_windows, delete_deletable_window, resize_root_window)
2438 (Fdelete_other_windows_internal)
2439 (Frun_window_configuration_change_hook, make_parent_window)
2440 (resize_window_check, resize_window_apply, Fresize_window_apply)
2441 (resize_frame_windows, Fsplit_window_internal)
2442 (Fdelete_window_internal, Fresize_mini_window_internal):
2444 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2446 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2448 * window.h (window): Add some new members to window structure -
2449 normal_lines, normal_cols, new_total, new_normal, clone_number,
2450 splits, nest, prev_buffers, next_buffers.
2451 (WINDOW_TOTAL_SIZE): Move here from window.c.
2452 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2454 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2456 (make_dummy_parent): Set new members of windows structure.
2457 (make_window): Move down in code. Handle new members of window
2459 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2460 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2461 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2462 (Fset_window_prev_buffers, Fwindow_next_buffers)
2463 (Fset_window_next_buffers, Fset_window_clone_number):
2465 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2466 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2468 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2469 Argument WINDOW can be now internal window too.
2470 (Fwindow_use_time): Move up in code.
2471 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2473 (Fset_window_configuration, saved_window)
2474 (Fcurrent_window_configuration, save_window_save): Handle new
2475 members of window structure.
2476 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2477 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2478 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2479 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2480 Qget_mru_window, Qresize_root_window,
2481 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2482 Qauto_buffer_name; staticpro them.
2484 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2486 * window.c (Fwindow_total_size, Fwindow_left_column)
2487 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2488 (Fwindow_list_1): New functions.
2489 (window_box_text_cols): Replace with window_body_cols.
2490 (Fwindow_width, Fscroll_left, Fscroll_right):
2491 Use window_body_cols instead of window_box_text_cols.
2492 (delete_window, Fset_window_configuration):
2493 Call delete_all_subwindows with window as argument.
2494 (delete_all_subwindows): Take a window as argument and not a
2496 (window_loop): Remove handling of GET_LRU_WINDOW and
2498 (Fget_lru_window, Fget_largest_window): Move to window.el.
2500 * window.h: Extern window_body_cols instead of
2501 window_box_text_cols. delete_all_subwindows now takes a
2502 Lisp_Object as argument.
2504 * indent.c (compute_motion, Fcompute_motion):
2505 Use window_body_cols instead of window_box_text_cols.
2507 * frame.c (delete_frame): Call delete_all_subwindows with root
2510 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2512 * fns.c (Fputhash): Document return value.
2514 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2516 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2518 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2520 Cons<->int and similar integer overflow fixes (Bug#8794).
2522 Check for overflow when converting integer to cons and back.
2523 * charset.c (Fdefine_charset_internal, Fdecode_char):
2524 Use cons_to_unsigned to catch overflow.
2525 (Fencode_char): Use INTEGER_TO_CONS.
2526 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2527 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2528 * data.c (long_to_cons, cons_to_long): Remove.
2529 (cons_to_unsigned, cons_to_signed): New functions.
2530 These signal an error for invalid or out-of-range values.
2531 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2532 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2533 * font.c (Ffont_variation_glyphs):
2534 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2535 * lisp.h: Include <intprops.h>.
2536 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2537 (cons_to_signed, cons_to_unsigned): New decls.
2538 (long_to_cons, cons_to_long): Remove decls.
2539 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2540 (Fprimitive_undo): Use CONS_TO_INTEGER.
2541 * xfns.c (Fx_window_property): Likewise.
2542 * xselect.c: Include <limits.h>.
2543 (x_own_selection, selection_data_to_lisp_data):
2544 Use INTEGER_TO_CONS.
2545 (x_handle_selection_request, x_handle_selection_clear)
2546 (x_get_foreign_selection, Fx_disown_selection_internal)
2547 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2548 (lisp_data_to_selection_data): Use cons_to_unsigned.
2549 (x_fill_property_data): Use cons_to_signed.
2550 Report values out of range.
2552 Check for buffer and string overflow more precisely.
2553 * buffer.h (BUF_BYTES_MAX): New macro.
2554 * lisp.h (STRING_BYTES_MAX): New macro.
2555 * alloc.c (Fmake_string):
2556 * character.c (string_escape_byte8):
2557 * coding.c (coding_alloc_by_realloc):
2558 * doprnt.c (doprnt):
2559 * editfns.c (Fformat):
2561 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2562 since they may not be the same number.
2563 * editfns.c (Finsert_char):
2564 * fileio.c (Finsert_file_contents):
2565 Likewise for BUF_BYTES_MAX.
2567 * image.c: Use ptrdiff_t, not int, for sizes.
2568 (slurp_file): Switch from int to ptrdiff_t.
2570 (slurp_file): Check that file size fits in both size_t (for
2571 malloc) and ptrdiff_t (for sanity and safety).
2573 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2574 if b->modtime has its maximal value.
2576 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2578 Don't assume time_t can fit into int.
2579 * buffer.h (struct buffer.modtime): Now time_t, not int.
2580 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2581 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2583 Minor fixes for signed vs unsigned integers.
2584 * character.h (MAYBE_UNIFY_CHAR):
2585 * charset.c (maybe_unify_char):
2586 * keyboard.c (read_char, reorder_modifiers):
2587 XINT -> XFASTINT, since the integer must be nonnegative.
2588 * ftfont.c (ftfont_spec_pattern):
2589 * keymap.c (access_keymap, silly_event_symbol_error):
2590 XUINT -> XFASTINT, since the integer must be nonnegative.
2591 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2592 since it makes no difference and we prefer signed.
2593 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2594 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2597 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2599 * window.h (Fwindow_frame): Declare.
2601 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2603 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2604 (SPARE_MEMORY): Always define.
2605 (LARGE_REQUEST): Remove.
2606 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2608 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2610 * lisp.h: Move EXFUNS for Fframe_root_window,
2611 Fframe_first_window and Fset_frame_selected_window to window.h.
2613 * window.h: Move EXFUNS for Fframe_root_window,
2614 Fframe_first_window and Fset_frame_selected_window here from
2617 * frame.c (Fwindow_frame, Fframe_first_window)
2618 (Fframe_root_window, Fframe_selected_window)
2619 (Fset_frame_selected_window): Move to window.c.
2620 (Factive_minibuffer_window): Move to minibuf.c.
2621 (Fother_visible_frames_p): New function.
2623 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2625 * window.c (decode_window, decode_any_window): Move up in code.
2626 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2627 (inhibit_frame_unsplittable): Remove unused variable.
2628 (Fwindow_buffer): Move up and rewrite doc-string.
2629 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2630 (Fwindow_prev): New functions.
2631 (Fwindow_frame): Move here from frame.c. Accept any window as
2633 (Fframe_root_window, Fframe_first_window)
2634 (Fframe_selected_window): Move here from frame.c. Accept frame
2635 or arbitrary window as argument. Update doc-strings.
2636 (Fminibuffer_window): Move up in code.
2637 (Fwindow_minibuffer_p): Move up in code and simplify.
2638 (Fset_frame_selected_window): Move here from frame.c.
2640 (Fselected_window, select_window, Fselect_window): Move up in
2641 code. Minor doc-string fixes.
2643 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2645 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2646 Do not assume that spare memory exists; that assumption is valid
2647 only if SYSTEM_MALLOC.
2648 (LARGE_REQUEST): New macro, so that the issue of large requests
2649 is separated from the issue of spare memory.
2651 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2653 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2656 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2658 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2661 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2663 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2665 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2667 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2668 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2670 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2672 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2674 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2676 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2677 (x_clipboard_manager_save): Add return value.
2678 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2680 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2681 Obey Vx_select_enable_clipboard_manager. Catch errors in
2682 x_clipboard_manager_save (Bug#8779).
2683 (Vx_select_enable_clipboard_manager): New variable.
2684 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2686 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2688 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2690 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2692 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2693 in the current matrix if keep_current_p is non-zero.
2695 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2697 * bidi.c (bidi_level_of_next_char): Fix last change.
2699 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2701 Support bidi reordering of text covered by display properties.
2703 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2704 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2705 (bidi_cache_search, bidi_cache_iterator_state)
2706 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2707 (bidi_level_of_next_char, bidi_move_to_visually_next):
2708 Support character positions inside a run of characters covered by a
2710 (bidi_paragraph_init, bidi_resolve_explicit_1)
2711 (bidi_level_of_next_char): Call bidi_fetch_char and
2712 bidi_fetch_char_advance instead of FETCH_CHAR and
2714 (bidi_init_it): Initialize new members.
2715 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2717 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2718 instead of using explicit *_CHAR codes.
2719 (bidi_resolve_explicit, bidi_resolve_weak):
2720 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2721 bidirectional text is supported only in multibyte buffers.
2722 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2723 it to initialize the frame_window_p member of struct bidi_it.
2724 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2725 (bidi_resolve_explicit, bidi_resolve_weak)
2726 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2727 bidi_it->nchars is non-positive.
2728 (bidi_level_of_next_char): Don't try to lookup the cache for the
2729 next/previous character if nothing is cached there yet, or if we
2730 were just reseat()'ed to a new position.
2732 * xdisp.c (set_cursor_from_row): Set start and stop points
2733 according to the row's direction when priming the loop that looks
2734 for the glyph on which to display cursor.
2735 (single_display_spec_intangible_p): Function deleted.
2736 (display_prop_intangible_p): Reimplement to call
2737 handle_display_spec instead of single_display_spec_intangible_p.
2738 Accept 3 additional arguments needed by handle_display_spec.
2739 This fixes incorrect cursor motion across display property with complex
2740 values: lists, `(when COND...)' forms, etc.
2741 (single_display_spec_string_p): Support property values that are
2742 lists with the argument STRING its top-level element.
2743 (display_prop_string_p): Fix the condition for processing a
2744 property that is a list to be consistent with handle_display_spec.
2745 (handle_display_spec): New function, refactored from the
2746 last portion of handle_display_prop.
2747 (compute_display_string_pos): Accept additional argument
2748 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2749 value of a `display' property is a "replacing spec".
2750 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2751 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2752 the display property, but just return a value indicating whether
2753 the display property will replace the characters it covers.
2754 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2755 frame_window_p members of struct bidi_it.
2756 (compute_display_string_pos, compute_display_string_end):
2758 (push_it): Accept second argument POSITION, where pop_it should
2759 jump to continue iteration.
2760 (reseat_1): Initialize bidi_it.disp_pos.
2762 * keyboard.c (adjust_point_for_property): Adjust the call to
2763 display_prop_intangible_p to its new signature.
2765 * dispextern.h (struct bidi_it): New member frame_window_p.
2766 (bidi_init_it): Update prototypes.
2767 (display_prop_intangible_p): Update prototype.
2768 (compute_display_string_pos, compute_display_string_end):
2770 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2773 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2775 Malloc failure behavior now depends on size of allocation.
2776 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2777 * lisp.h: Change signatures accordingly.
2778 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2779 All callers changed. (Bug#8762)
2781 * gnutls.c: Use Emacs's memory allocators.
2782 Without this change, the gnutls library would invoke malloc etc.
2783 directly, which causes problems on non-SYNC_INPUT hosts, and which
2784 runs afoul of improving memory_full behavior. (Bug#8761)
2785 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2786 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2787 xfree instead of the default malloc, realloc, free.
2788 (Fgnutls_boot): No need to check for memory allocation failure,
2789 since xmalloc does that for us.
2791 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2792 * category.c (hash_get_category_set):
2793 * ccl.c (ccl_driver):
2794 * charset.c (Fdefine_charset_internal):
2795 * charset.h (struct charset.hash_index):
2796 * composite.c (get_composition_id, gstring_lookup_cache)
2797 (composition_gstring_put_cache):
2798 * composite.h (struct composition.hash_index):
2799 * dispextern.h (struct image.hash):
2800 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2801 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2802 (hashfn_equal, hashfn_user_defined, make_hash_table)
2803 (maybe_resize_hash_table, hash_lookup, hash_put)
2804 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2805 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2806 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2807 * image.c (make_image, search_image_cache, lookup_image)
2808 (xpm_put_color_table_h):
2809 * lisp.h (struct Lisp_Hash_Table):
2810 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2811 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2812 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2813 * alloc.c (allocate_vectorlike):
2814 Check for overflow in vector size calculations.
2815 * ccl.c (ccl_driver):
2816 Check for overflow when converting EMACS_INT to int.
2817 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2818 need to be updated by these changes.
2819 * fns.c (make_hash_table, maybe_resize_hash_table):
2820 Check for integer overflow with large hash tables.
2821 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2822 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2823 (SXHASH_REDUCE): New macro.
2824 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2825 Use it instead of discarding useful hash info with large hash values.
2826 (sxhash_float): New function.
2827 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2828 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2829 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2830 Rewrite to use FIXNUM_BITS, as this simplifies things.
2831 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2832 Adjust signatures to match updated version of code.
2833 (consing_since_gc): Now EMACS_INT, since a single hash table can
2834 use more than INT_MAX bytes.
2836 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2838 Make it possible to build with GCC-4.6+ -O2 -flto.
2840 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2842 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2844 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2845 Call minibuffer-inactive-mode.
2847 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2849 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2850 Update dependencies.
2852 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2854 * data.c (init_data): Remove code for UTS, this system is not
2857 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2859 Don't force ./temacs to start in terminal mode.
2861 * frame.c (make_initial_frame): Initialize faces in all cases, not
2862 only when CANNOT_DUMP is defined.
2863 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2865 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2867 * dispnew.c (add_window_display_history): Use const for the string
2868 pointer. Remove declaration, not needed.
2870 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2872 Use 'inline', not 'INLINE'.
2873 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2874 * alloc.c, fontset.c (INLINE): Remove.
2875 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2876 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2877 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2878 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2879 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2881 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2883 Make it possible to run ./temacs.
2885 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2886 syms_of_callproc does the same thing. Remove test for
2887 "initialized", do it in the caller.
2888 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2890 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2892 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2893 (read_minibuf): Use get_minibuffer.
2894 (syms_of_minibuf): Use DEFSYM.
2895 (Qmetadata): New var.
2896 * data.c (Qbuffer): Don't make it static.
2897 (syms_of_data): Use DEFSYM.
2899 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2901 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2902 (CCL_CODE_MIN): New macro.
2904 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2906 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2908 * eval.c (Qdebug): Now static.
2909 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2910 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2911 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2913 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2915 * image.c: Various fixes to ImageMagick code comments.
2916 (Fimagemagick_types): Doc fix.
2918 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2920 Minor fixes prompted by GCC 4.6.0 warnings.
2922 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2924 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2925 (x_clipboard_manager_save_all): Move extern decl to ...
2926 * xterm.h: ... here, so that it can be checked for consistency.
2928 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2930 * xselect.c (x_clipboard_manager_save_frame)
2931 (x_clipboard_manager_save_all): New functions.
2932 (Fx_clipboard_manager_save): Lisp function deleted.
2934 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2935 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2937 * xterm.h: Update prototype.
2939 2011-05-28 William Xu <william.xwl@gmail.com>
2941 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2944 2011-05-28 Jim Meyering <meyering@redhat.com>
2946 Avoid a sign-extension bug in crypto_hash_function.
2947 * fns.c (to_uchar): Define.
2948 (crypto_hash_function): Use it to convert some newly-signed
2949 variables to unsigned, to avoid sign-extension bugs. For example,
2950 without this change, (md5 "truc") would evaluate to
2951 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2952 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2953 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2955 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2957 Integer overflow fixes.
2959 * dbusbind.c: Serial number integer overflow fixes.
2960 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2961 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2962 to hold a serial number that is too large for a fixnum.
2963 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2964 Check for serial numbers out of range. Decode any serial number
2965 that was so large that it became a float. (Bug#8722)
2967 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2968 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2969 Use XFASTINT rather than XUINT when numbers are nonnegative.
2970 (xd_append_arg, Fdbus_method_return_internal):
2971 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2972 arguments, check that Lisp number is nonnegative, rather than
2973 silently wrapping negative numbers around. (Bug#8722)
2974 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2977 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2979 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2981 ccl: add integer overflow checks
2982 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2983 (IN_INT_RANGE): New macros.
2984 (ccl_driver): Use them to check for integer overflow when
2985 decoding a CCL program. Many of the new checks are whether XINT (x)
2986 fits in int; it doesn't always, on 64-bit hosts. The new version
2987 doesn't catch all possible integer overflows, but it's an
2988 improvement. (Bug#8719)
2990 * alloc.c (make_event_array): Use XINT, not XUINT.
2991 There's no need for unsigned here.
2993 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2994 This follows up to the 2011-05-06 change that substituted uintptr_t
2995 for EMACS_INT. This case wasn't caught back then.
2997 Rework Fformat to avoid integer overflow issues.
2998 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2999 now (part of C89). Include <verify.h>.
3000 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3001 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3002 (Fformat): Avoid the prepass trying to compute sizes; it was only
3003 approximate and thus did not catch overflow reliably. Instead, walk
3004 through the format just once, formatting and computing sizes as we go,
3005 checking for integer overflow at every step, and allocating a larger
3006 buffer as needed. Keep track separately whether the format is
3007 multibyte. Keep only the most-recently calculated precision, rather
3008 than them all. Record whether each argument has been converted to
3009 string. Use EMACS_INT, not int, for byte and char and arg counts.
3010 Support field widths and precisions larger than INT_MAX. Avoid
3011 sprintf's undefined behavior with conversion specifications such as %#d
3012 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3013 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3014 formatting out-of-range floating point numbers with int
3017 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3019 * data.c: Avoid integer truncation in expressions involving floats.
3020 * data.c: Include <intprops.h>.
3021 (arith_driver): When there's an integer overflow in an expression
3022 involving floating point, convert the integers to floating point
3023 so that the resulting value does not suffer from catastrophic
3024 integer truncation. For example, on a 64-bit host (* 4
3025 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3026 Do not rely on undefined behavior after integer overflow.
3028 merge count_size_as_multibyte, parse_str_to_multibyte
3029 * character.c, character.h (count_size_as_multibyte):
3030 Rename from parse_str_to_multibyte; all uses changed.
3031 Check for integer overflow.
3032 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3033 since it's now a duplicate of the other. This is more of
3034 a character than a buffer op, so better that it's in character.c.
3035 * fns.c, print.c: Adjust to above changes.
3037 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3039 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3041 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3043 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3044 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3045 (x_clipboard_manager_save): Now static.
3046 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3048 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3049 (crypto_hash_function): Now static.
3050 Fix pointer signedness problems. Avoid unnecessary initializations.
3052 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3054 * termhooks.h (Vselection_alist): Make it terminal-local.
3056 * terminal.c (create_terminal): Initialize it.
3058 * xselect.c: Support for clipboard managers.
3059 (Vselection_alist): Move to termhooks.h as terminal-local var.
3060 (LOCAL_SELECTION): New macro.
3061 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3062 (symbol_to_x_atom): Remove gratuitous arg.
3063 (x_handle_selection_request, lisp_data_to_selection_data)
3064 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3065 (x_own_selection, x_get_local_selection, x_convert_selection):
3066 New arg, specifying work frame. Use terminal-local Vselection_alist.
3067 (some_frame_on_display): Delete unused function.
3068 (Fx_own_selection_internal, Fx_get_selection_internal)
3069 (Fx_disown_selection_internal, Fx_selection_owner_p)
3070 (Fx_selection_exists_p): New optional frame arg.
3071 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3072 (x_handle_selection_clear): Don't treat other terminals with the
3073 same keyboard specially. Use the terminal-local Vselection_alist.
3074 (x_clear_frame_selections): Use Frun_hook_with_args.
3076 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3078 * xterm.h: Add support for those atoms.
3080 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3082 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3083 (converted_selections, conversion_fail_tag): New global variables.
3084 (x_selection_request_lisp_error): Free the above.
3085 (x_get_local_selection): Remove unnecessary code.
3086 (x_reply_selection_request): Args changed; handle arbitrary array
3087 of converted selections stored in converted_selections.
3088 Separate the XChangeProperty and SelectionNotify steps.
3089 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3090 (x_convert_selection): New function.
3091 (x_handle_selection_event): Simplify.
3092 (x_get_foreign_selection): Don't ignore incoming requests while
3093 waiting for an answer; this will fail when we implement
3094 SAVE_TARGETS, and seems unnecessary anyway.
3095 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3096 (Vx_sent_selection_functions): Doc fix.
3098 2011-05-26 Leo Liu <sdl.web@gmail.com>
3100 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3102 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3104 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3106 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3107 for fringe update if it has periodic bitmap.
3108 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3109 and fringe_bitmap_periodic_p.
3111 * fringe.c (get_fringe_bitmap_data): New function.
3112 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3113 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3114 row. Mark glyph row for fringe update if periodicity changed.
3116 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3117 for fringe update unless it has periodic bitmap.
3119 2011-05-25 Kenichi Handa <handa@m17n.org>
3121 * xdisp.c (get_next_display_element): Set correct it->face_id for
3122 a static composition.
3124 2011-05-24 Leo Liu <sdl.web@gmail.com>
3127 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3129 * fns.c (crypto_hash_function, Fsha1): New function.
3130 (Fmd5): Use crypto_hash_function.
3131 (syms_of_fns): Add Ssha1.
3133 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3135 * gnutls.c: Remove unused macros.
3136 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3137 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3138 Remove macros that are defined and never used.
3139 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3141 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3143 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3144 (Fx_get_selection_internal): Minor cleanup.
3145 (Fx_own_selection_internal): Rename arguments for consistency with
3148 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3150 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3152 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3154 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3156 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3158 * dispnew.c (scrolling_window): Don't exclude the case that the
3159 last enabled row in the desired matrix touches the bottom boundary.
3161 2011-05-21 Glenn Morris <rgm@gnu.org>
3163 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3164 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3165 and add some more files.
3167 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3169 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3170 report_file_error introduced by the change from 2011-05-07.
3172 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3174 * systime.h (Time): Define only if emacs is defined.
3175 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3176 where the include path doesn't have X11/X.h by default. See
3177 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3179 2011-05-20 Kenichi Handa <handa@m17n.org>
3181 * composite.c (find_automatic_composition): Fix previous change.
3183 2011-05-20 Glenn Morris <rgm@gnu.org>
3185 * lisp.mk: New file, split from Makefile.in.
3186 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3187 (shortlisp): Remove.
3188 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3190 2011-05-19 Glenn Morris <rgm@gnu.org>
3192 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3193 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3194 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3195 (lisp): Set the order to that of loadup.el.
3196 (shortlisp): Make it a copy of $lisp.
3197 (SOME_MACHINE_LISP): Remove.
3198 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3199 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3201 2011-05-18 Kenichi Handa <handa@m17n.org>
3203 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3204 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3205 (find_automatic_composition): Mostly rewrite for efficiency.
3207 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3209 * makefile.w32-in: Update dependencies.
3211 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3213 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3214 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3216 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3218 Fix some integer overflow issues, such as string length overflow.
3220 * insdel.c (count_size_as_multibyte): Check for string overflow.
3222 * character.c (lisp_string_width): Check for string overflow.
3223 Use EMACS_INT, not int, for string indexes and lengths; in
3224 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3225 the resulting string length overflows an EMACS_INT; instead,
3226 report a string overflow if no precision given. When checking for
3227 precision exhaustion, use a check that cannot possibly have
3228 integer overflow. (Bug#8675)
3229 * character.h (lisp_string_width): Adjust to new signature.
3231 * alloc.c (string_overflow): New function.
3232 (Fmake_string): Use it. This doesn't change behavior, but saves
3233 a few bytes and will simplify future changes.
3234 * character.c (string_escape_byte8): Likewise.
3235 * lisp.h (string_overflow): New decl.
3237 Fixups, following up to the user-interface timestamp change.
3238 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3239 for UI timestamps, instead of unsigned long.
3240 * msdos.c (mouse_get_pos): Likewise.
3241 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3242 * w32gui.h (Time): Define by including "systime.h" rather than by
3243 declaring it ourselves. (Bug#8664)
3245 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3246 * image.c (clear_image_cache): Likewise.
3248 * term.c (term_mouse_position): Don't assume time_t wraparound.
3250 Be more systematic about user-interface timestamps.
3251 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3252 and sometimes 'EMACS_UINT', to represent these timestamps.
3253 This change causes it to use 'Time' uniformly, as that's what X uses.
3254 This makes the code easier to follow, and makes it easier to catch
3255 integer overflow bugs such as Bug#8664.
3256 * frame.c (Fmouse_position, Fmouse_pixel_position):
3257 Use Time, not unsigned long, for user-interface timestamps.
3258 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3259 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3260 * keyboard.h (last_event_timestamp): Likewise.
3261 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3262 * menu.h (xmenu_show): Likewise.
3263 * term.c (term_mouse_position): Likewise.
3264 * termhooks.h (struct input_event.timestamp): Likewise.
3265 (struct terminal.mouse_position_hook): Likewise.
3266 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3267 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3268 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3269 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3271 * menu.h, termhooks.h: Include "systime.h", for Time.
3273 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3274 Don't assume that the difference between two unsigned long values
3275 can fit into an integer. At this point, we know button_down_time
3276 <= event->timestamp, so the difference must be nonnegative, so
3277 there's no need to cast the result if double-click-time is
3278 nonnegative, as it should be; check that it's nonnegative, just in
3279 case. This bug is triggered when events are more than 2**31 ms
3280 apart (about 25 days). (Bug#8664)
3282 * xselect.c (last_event_timestamp): Remove duplicate decl.
3283 (x_own_selection): Remove needless cast to unsigned long.
3285 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3286 that always fit in int. Use a sentinel instead of a counter, to
3287 avoid a temp and to allay GCC's concerns about possible int overflow.
3288 * frame.h (struct frame): Use int for menu_bar_items_used
3289 instead of EMACS_INT, since it always fits in int.
3291 * menu.c (grow_menu_items): Check for int overflow.
3293 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3295 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3296 Before, the code was not consistent. These values cannot exceed
3297 2**31 - 1 so there's no need to make them unsigned.
3298 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3299 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3300 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3302 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3304 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3305 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3306 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3307 presumably because the widths might not match.
3309 * window.c (size_window): Avoid needless test at loop start.
3311 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3313 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3315 2011-05-12 Drew Adams <drew.adams@oracle.com>
3317 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3319 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3321 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3322 `width' to `bar_area_x' and `bar_area_width', respectively.
3323 (x_scroll_run): Take account of fringe background extension.
3325 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3326 Rename local vars `left' and `width' to `bar_area_x' and
3327 `bar_area_width', respectively.
3328 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3329 background extension.
3331 2011-05-10 Jim Meyering <meyering@redhat.com>
3333 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3335 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3337 * image.c (Finit_image_library): Return t for built-in image types,
3338 like pbm and xbm. (Bug#8640)
3340 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3342 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3344 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3346 * w32console.c (Fset_screen_color): Doc fix.
3347 (Fget_screen_color): New function.
3348 (syms_of_ntterm): Defsubr it.
3350 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3351 unlink the temporary file if Fcall_process didn't create it in the
3353 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3354 child process will be redirected to a file specified with `:file'.
3355 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3356 cue to call_process_cleanup not to close that handle.
3358 2011-05-07 Ben Key <bkey76@gmail.com>
3360 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3361 one of two shell specific rules, either bootstrap-temacs-CMD or
3362 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3363 to the previous implementation of the bootstrap-temacs rule.
3364 The bootstrap-temacs-CMD rule is similar to the previous
3365 implementation of the bootstrap-temacs rule except that it
3366 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3369 These changes, along with some changes to nt/configure.bat,
3370 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3371 earlier fix to add support for --cflags and --ldflags options
3372 that include quotes so that it works whether make uses cmd or
3375 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3377 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3378 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3380 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3381 a string. Handle both cases.
3382 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3383 (Fdbus_register_method): Use Qinvalid_function.
3385 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3387 * makefile.w32-in: Update dependencies.
3388 (LISP_H): Add inttypes.h and stdin.h.
3389 (PROCESS_H): Add unistd.h.
3391 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3393 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3394 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3396 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3398 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3400 * term.c (vfatal): Remove stray call to va_end.
3401 It's not needed and the C Standard doesn't allow it here anyway.
3403 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3404 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3406 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3409 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3411 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3413 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3415 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3417 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3419 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3420 * charset.c (Fdefine_charset_internal): Don't initialize
3421 charset.code_space[15]. The value was garbage, on hosts with
3422 32-bit int (Bug#8600).
3424 * lread.c (read_integer): Be more consistent with string-to-number.
3425 Use string_to_number to do the actual conversion; this avoids
3426 rounding errors and fixes some other screwups. Without this fix,
3427 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3428 (digit_to_number): Move earlier, for benefit of read_integer.
3429 Return -1 if the digit is out of range for the base, -2 if it is
3430 not a digit in any supported base. (Bug#8602)
3432 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3434 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3435 to match comment at start of function. This also removes a
3436 GCC warning about overflow in a 32+64-bit port.
3438 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3440 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3441 Reported by Stefan Monnier in
3442 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3443 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3444 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3446 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3447 (EMACS_UINTPTR): Likewise, with uintptr_t.
3449 * lisp.h: Prefer 64-bit EMACS_INT if available.
3450 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3451 on 32-bit hosts that have 64-bit int, so that they can access
3453 However, temporarily disable this change unless the temporary
3454 symbol WIDE_EMACS_INT is defined.
3456 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3458 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3459 This removes an assumption that EMACS_INT and long are the same
3460 width as pointers. The assumption is true for Emacs porting targets
3461 now, but we want to make other targets possible.
3462 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3463 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3464 In the rest of the code, change types of integers that hold casted
3465 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3466 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3467 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3468 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3469 No need to cast type when ORing.
3470 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3471 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3472 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3473 assume EMACS_INT is the same width as char *.
3474 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3475 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3476 Remove no-longer-needed casts.
3477 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3478 (xg_tool_bar_help_callback, xg_make_tool_item):
3479 Use EMACS_INTPTR to hold an integer
3480 that will be cast to void *; this can avoid a GCC warning
3481 if EMACS_INT is not the same width as void *.
3482 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3483 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3484 (current_message_1, set_message_1):
3485 Use a local to convert to proper width without a cast.
3486 * xmenu.c (dialog_selection_callback): Likewise.
3488 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3489 Also, don't assume VALBITS / RAND_BITS is less than 5,
3490 and don't rely on undefined behavior when shifting a 1 left into
3492 * lisp.h (get_random): Change signature to match.
3494 * lread.c (hash_string): Use size_t, not int, for hash computation.
3495 Normally we prefer signed values; but hashing is special, because
3496 it's better to use unsigned division on hash table sizes so that
3497 the remainder is nonnegative. Also, size_t is the natural width
3498 for hashing into memory. The previous code used 'int', which doesn't
3499 retain enough info to hash well into very large tables.
3500 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3502 * dbusbind.c: Don't possibly lose pointer info when converting.
3503 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3504 Use XPNTR rather than XHASH, so that the high-order bits of
3505 the pointer aren't lost when converting through void *.
3507 * eval.c (Fautoload): Don't double-shift a pointer.
3509 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3511 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3513 * gnutls.c (DEF_GNUTLS_FN):
3514 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3516 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3518 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3521 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3523 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3524 New version that can reserve upto 2GB of heap space.
3526 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3528 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3530 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3532 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3533 `gnutls_certificate_set_x509_key_file'.
3535 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3537 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3538 Update dependencies.
3540 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3542 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3543 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3544 Remove unused parameter `fildes'.
3545 * process.c (read_process_output, send_process): Don't pass it.
3547 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3549 Fix previous change: the library cache is defined in w32.c.
3550 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3551 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3553 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3555 Implement dynamic loading of GnuTLS on Windows.
3557 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3558 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3559 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3562 * gnutls.c (Qgnutls_dll): Define.
3563 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3564 (gnutls_*): Declare function pointers.
3565 (init_gnutls_functions): New function to initialize function pointers.
3566 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3567 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3568 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3569 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3570 (emacs_gnutls_write, emacs_gnutls_read)
3571 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3572 (Fgnutls_available_p): New function.
3573 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3574 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3575 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3577 * image.c: Include w32.h.
3578 (Vimage_type_cache): Delete.
3579 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3580 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3581 (w32_delayed_load): Move to w32.c.
3583 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3585 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3586 (w32_delayed_load): Move from image.c. When loading a library, record
3587 its filename in the :loaded-from property of the library id.
3588 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3589 Initialize and staticpro them.
3590 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3592 * process.c: Include lisp.h before w32.h, not after.
3593 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3594 instead of gnutls_record_check_pending.
3596 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3598 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3600 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3601 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3604 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3606 * xterm.c (x_set_frame_alpha): Do not set property on anything
3607 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3609 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3611 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3613 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3615 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3616 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3617 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3618 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3619 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3620 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3621 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3622 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3623 (Qgnutls_bootprop_callbacks_verify): Make static.
3625 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3627 * callproc.c: Indentation fixup.
3629 * sysdep.c (wait_for_termination_1): Make static.
3630 (wait_for_termination, interruptible_wait_for_termination):
3631 Move after wait_for_termination_1.
3633 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3635 * sysdep.c (interruptible_wait_for_termination): New function
3636 which is like wait_for_termination, but allows keyboard
3639 * callproc.c (Fcall_process): Add (:file "file") as an option for
3641 (Fcall_process_region): Ditto.
3643 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3645 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3646 rather than `XVECTOR (FOO)->size'.
3648 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3649 inttypes.h, as a gnulib replacement is used if it not available in
3652 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3654 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3655 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3656 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3658 * coding.c (coding_alloc_by_realloc): Error out if destination
3659 will grow beyond MOST_POSITIVE_FIXNUM.
3660 (decode_coding_emacs_mule): Abort if there isn't enough place in
3661 charbuf for the composition carryover bytes. Reserve an extra
3662 space for up to 2 characters produced in a loop.
3663 (decode_coding_iso_2022): Abort if there isn't enough place in
3664 charbuf for the composition carryover bytes.
3666 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3668 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3669 aborting when %lld or %lll format is passed.
3670 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3671 %llo or %llx format is passed. (Bug#8545)
3673 * window.c (window_scroll_line_based): Use a marker instead of
3674 simple variables to record original value of point. (Bug#7952)
3676 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3677 produced by %s or %c overflows available buffer space. (Bug#8545)
3679 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3681 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3682 (SIZE_MAX): Move defn after all includes, as they might #define it.
3684 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3686 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3688 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3690 * keyboard.c (Qdelayed_warnings_hook): Define.
3691 (command_loop_1): Run `delayed-warnings-hook'
3692 if Vdelayed_warnings_list is non-nil.
3693 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3694 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3696 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3698 * doprnt.c (doprnt): Don't return value smaller than the buffer
3699 size if the message was truncated. (Bug#8545).
3701 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3703 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3704 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3706 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3708 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3710 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3712 * makefile.w32-in: Update dependencies.
3714 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3716 Improve `doprnt' and its usage. (Bug#8545)
3717 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3718 `format_end'. Remove support for %l as a conversion specifier.
3719 Don't use xrealloc. Improve diagnostics when the %l size modifier
3720 is used. Update the commentary.
3722 * eval.c (verror): Simplify calculation of size_t.
3724 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3727 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3729 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3732 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3734 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3735 This makes this file independent of the recent pseudovector change.
3737 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3739 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3741 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3742 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3743 Remove unused local.
3744 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3746 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3747 GCC 4.6.0 optimizes based on type-based alias analysis.
3748 For example, if b is of type struct buffer * and v of type struct
3749 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3750 != &v->size, and therefore "v->size = 1; b->size = 2; return
3751 v->size;" must therefore return 1. This assumption is incorrect
3752 for Emacs, since it type-puns struct Lisp_Vector * with many other
3753 types. To fix this problem, this patch adds a new type struct
3754 vectorlike_header that documents the constraints on layout of vectors
3755 and pseudovectors, and helps optimizing compilers not get fooled
3756 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3757 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3758 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3760 (XSETPVECTYPE): Rewrite in terms of new macro.
3761 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3762 This is a bit clearer, and further avoids the possibility of
3763 undesirable aliasing.
3764 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3765 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3766 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3767 since Lisp_Subr is a special case (no "next" field).
3768 (ASIZE): Now uses header.size rather than size.
3769 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3770 to avoid the hassle of writing XVECTOR (foo)->header.size.
3771 (struct vectorlike_header): New type.
3772 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3773 object, to help avoid aliasing.
3774 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3775 (SUBRP): Likewise, since Lisp_Subr is a special case.
3776 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3777 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3778 (struct Lisp_Hash_Table): Combine first two members into a single
3779 struct vectorlike_header member. All uses of "size" and "next" members
3780 changed to be "header.size" and "header.next".
3781 * buffer.h (struct buffer): Likewise.
3782 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3783 * frame.h (struct frame): Likewise.
3784 * process.h (struct Lisp_Process): Likewise.
3785 * termhooks.h (struct terminal): Likewise.
3786 * window.c (struct save_window_data, struct saved_window): Likewise.
3787 * window.h (struct window): Likewise.
3788 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3789 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3790 * buffer.c (init_buffer_once): Likewise.
3791 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3793 * process.c (Fformat_network_address): Use local var for size,
3796 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3798 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3799 * data.c (atof): Remove decl; no longer used or needed.
3800 (digit_to_number): Move to lread.c.
3801 (Fstring_to_number): Use new string_to_number function, to be
3802 consistent with how the Lisp reader treats infinities and NaNs.
3803 Do not assume that floating-point numbers represent EMACS_INT
3804 without losing information; this is not true on most 64-bit hosts.
3805 Avoid double-rounding errors, by insisting on integers when
3806 parsing non-base-10 numbers, as the documentation specifies.
3807 * lisp.h (string_to_number): New decl, replacing ...
3808 (isfloat_string): Remove.
3809 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3810 (read1): Do not accept +. and -. as integers; this
3811 appears to have been a coding error. Similarly, do not accept
3812 strings like +-1e0 as floating point numbers. Do not report
3813 overflow for integer overflows unless the base is not 10 which
3814 means we have no simple and reliable way to continue.
3815 Break out the floating-point parsing into a new
3816 function string_to_number, so that Fstring_to_number parses
3817 floating point numbers consistently with the Lisp reader.
3818 (digit_to_number): Move here from data.c. Make it static inline.
3819 (E_CHAR, EXP_INT): Remove, replacing with ...
3820 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3821 (string_to_number): New function, replacing isfloat_string.
3822 This function checks for valid syntax and produces the resulting
3823 Lisp float number too. Rework it so that string-to-number
3824 no longer mishandles examples like "1.0e+". Use strtoumax,
3825 so that overflow for non-base-10 numbers is reported only when
3826 there's no portable and simple way to convert to floating point.
3828 * textprop.c (set_text_properties_1): Rewrite for clarity,
3829 and to avoid GCC warning about integer overflow.
3831 * intervals.h (struct interval): Use EMACS_INT for members
3832 where EMACS_UINT might cause problems. See
3833 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3834 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3835 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3837 (offset_intervals): Tell GCC not to worry about length overflow
3838 when negating a negative length.
3840 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3841 (overrun_check_free): Likewise.
3843 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3844 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3847 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3848 (gnutls_make_error): Rename local to avoid shadowing.
3849 (gnutls_emacs_global_deinit): ifdef out; not used.
3850 (Fgnutls_boot): Use const for pointer to readonly storage.
3851 Comment out unused local. Fix pointer signedness problems.
3853 * lread.c (openp): Don't stuff size_t into an 'int'.
3854 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3855 about possible signed overflow.
3857 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3858 (GDK_KEY_g): Don't define if already defined.
3859 (xg_prepare_tooltip): Avoid pointer signedness problem.
3860 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3862 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3863 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3865 * xfns.c (Fx_window_property): Simplify a bit,
3866 to make a bit faster and to avoid GCC 4.6.0 warning.
3867 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3869 * fns.c (internal_equal): Don't assume size_t fits in int.
3871 * alloc.c (compact_small_strings): Tighten assertion a little.
3873 Replace pEd with more-general pI, and fix some printf arg casts.
3874 * lisp.h (pI): New macro, generalizing old pEd macro to other
3875 conversion specifiers. For example, use "...%"pI"d..." rather
3876 than "...%"pEd"...".
3877 (pEd): Remove. All uses replaced with similar uses of pI.
3878 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3879 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3880 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3881 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3882 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3883 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3884 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3886 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3887 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3888 * print.c (safe_debug_print, print_object): Likewise.
3889 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3891 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3892 avoiding the 0 flag, which is not portable.
3893 * process.c (Fmake_network_process): Use pI to avoid cast.
3894 * region-cache.c (pp_cache): Likewise.
3895 * xdisp.c (decode_mode_spec): Likewise.
3896 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3897 behavior on 64-bit hosts with printf arg.
3898 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3899 (x_stop_queuing_selection_requests): Likewise.
3900 (x_get_window_property): Don't truncate byte count to an 'int'
3903 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3904 here, since it parses constructs like leading '-' and spaces,
3905 which are not wanted; and it overflows with large numbers.
3906 Instead, simply match F[0-9]+, which is what is wanted anyway.
3908 * alloc.c: Remove unportable assumptions about struct layout.
3909 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3910 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3911 (allocate_vectorlike, make_pure_vector): Use the new macros,
3912 plus offsetof, to remove unportable assumptions about struct layout.
3913 These assumptions hold on all porting targets that I know of, but
3914 they are not guaranteed, they're easy to remove, and removing them
3915 makes further changes easier.
3917 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3918 This doesn't fix a bug but makes the code clearer.
3919 (string_overrun_cookie): Now const. Use initializers that
3920 don't formally overflow signed char, to avoid warnings.
3921 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3922 can cause Emacs to crash when string overrun checking is enabled.
3923 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3924 multiple of sizeof (EMACS_INT); it need not be, if
3925 alignof(EMACS_INT) < sizeof (EMACS_INT).
3926 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3928 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3930 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3932 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3934 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3935 supposed to be handshaking. (Bug#8556)
3936 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3938 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3940 * lisp.h (Qdebug): List symbol.
3941 * eval.c (Qdebug): Restore global linkage.
3942 * keyboard.c (debug-on-event): New variable.
3943 (handle_user_signal): Break into debugger when debug-on-event
3944 matches the current signal symbol.
3946 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3948 * alloc.c (check_sblock, check_string_bytes)
3949 (check_string_free_list): Convert to standard C.
3951 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3953 * w32.c (emacs_gnutls_push): Fix typo.
3955 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3957 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3958 "cast to pointer from integer of different size".
3960 Improve doprnt and its use in verror. (Bug#8545)
3961 * doprnt.c (doprnt): Document the set of format control sequences
3962 supported by the function. Use SAFE_ALLOCA instead of always
3965 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3966 is one byte too soon. Don't use xrealloc; instead xfree and
3969 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3971 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3974 * gnutls.c: Renamed global_initialized to
3975 gnutls_global_initialized. Added internals for the
3976 :verify-hostname-error, :verify-error, and :verify-flags
3977 parameters of `gnutls-boot' and documented those parameters in the
3978 docstring. Start callback support.
3979 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3980 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3981 on error. Return error code.
3982 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3983 (emacs_gnutls_read): Likewise.
3984 (Fgnutls_boot): Return handshake error code.
3985 (emacs_gnutls_handle_error): New function.
3986 (wsaerror_to_errno): Likewise.
3988 * w32.h (emacs_gnutls_pull): Add prototype.
3989 (emacs_gnutls_push): Likewise.
3991 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3992 (emacs_gnutls_push): Likewise.
3994 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3996 * process.c (wait_reading_process_output): Check if GnuTLS
3997 buffered some data internally if no FDs are set for TLS
4000 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4001 (LIBS): Link to USER_LIBS.
4002 ($(BLD)/gnutls.$(0)): New target.
4004 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4006 * xdisp.c (handle_single_display_spec): Rename the
4007 display_replaced_before_p argument into display_replaced_p, to
4008 make it consistent with the commentary. Fix typos in the
4011 * textprop.c (syms_of_textprop): Remove dead code.
4012 (copy_text_properties): Delete obsolete commentary about an
4013 interface that was deleted long ago. Fix typos in the description
4016 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4017 to changes in oldXMenu/XMenu.h from 2011-04-16.
4018 <menu_help_message, prev_menu_help_message>: Constify.
4019 (IT_menu_make_room): menu->help_text is now `const char **';
4022 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4023 to changes in oldXMenu/XMenu.h from 2011-04-16.
4024 (struct XMenu): Declare `help_text' `const char **'.
4026 * xfaces.c <Qunspecified>: Make extern again.
4028 * syntax.c: Include sys/types.h before including regex.h, as
4031 * doc.c (get_doc_string): Improve the format passed to `error'.
4033 * doprnt.c (doprnt): Improve commentary.
4035 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4037 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4040 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4041 changes in globals.h immediately force recompilation.
4042 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4043 $(CURDIR)/s/ms-w32.h.
4044 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4046 * character.c (Fchar_direction): Function deleted.
4047 (syms_of_character): Don't defsubr it.
4048 <char-direction-table>: Deleted.
4050 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4052 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4053 * doprnt.c: Include limits.h.
4054 (SIZE_MAX): New macro.
4055 (doprnt): Return a size_t value. 2nd arg is now size_t.
4056 Many local variables are now size_t instead of int or unsigned.
4057 Improve overflow protection. Support `l' modifier for integer
4058 conversions. Support %l conversion. Don't assume an EMACS_INT
4059 argument for integer conversions and for %c.
4061 * lisp.h (doprnt): Restore prototype.
4063 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4066 * Makefile.in (base_obj): Add back doprnt.o.
4068 * deps.mk (doprnt.o): Add back prerequisites.
4069 (callint.o): Depend on character.h.
4071 * eval.c (internal_lisp_condition_case): Include the handler
4072 representation in the error message.
4073 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4074 when breaking from the loop.
4076 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4078 * callint.c (Fcall_interactively): When displaying error message
4079 about invalid control letter, pass the character's codepoint, not
4080 a pointer to its multibyte form. Improve display of the character
4081 in octal and display also its hex code.
4083 * character.c (char_string): Use %x to display the (unsigned)
4084 codepoint of an invalid character, to avoid displaying a bogus
4087 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4088 `error', not SYMBOL_NAME itself.
4090 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4091 character arguments to `error'.
4093 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4094 to `error' in error message about FINAL_CHAR argument. Make sure
4095 FINAL_CHAR is a character, and use %c when it is passed as
4096 argument to `error'.
4098 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4100 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4102 * w32.c: Include <time.h>.
4103 (sys_localtime): New function.
4105 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4107 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4109 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4111 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4113 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4116 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4118 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4119 gl_state.e_property when gl_state.object is Qt.
4121 * insdel.c (make_gap_larger): Remove limitation of buffer size
4124 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4126 * xdisp.c (lookup_glyphless_char_display)
4127 (produce_glyphless_glyph): Handle cons cell entry in
4128 glyphless-char-display.
4129 (Vglyphless_char_display): Document it.
4131 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4132 glyphless-char-display.
4134 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4136 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4138 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4140 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4141 definition for no-X builds.
4143 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4145 Static checks with GCC 4.6.0 and non-default toolkits.
4147 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4149 * process.c (keyboard_bit_set): Define only if SIGIO.
4150 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4151 (send_process): Repair possible setjmp clobbering.
4153 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4155 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4157 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4159 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4160 Define only if needed.
4162 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4163 by pacifying GCC about it. Maybe it's time to retire it?
4164 * xfaces.c (USG, __TIMEVAL__): Likewise.
4166 * dispextern.h (struct redisplay_interface): Rename param
4168 * termhooks.h (struct terminal): Likewise.
4169 * xterm.c (xembed_send_message): Likewise.
4171 * insdel.c (make_gap_smaller): Define only if
4172 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4174 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4177 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4178 so that we aren't warned about unused symbols.
4180 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4182 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4184 * xfns.c (x_real_positions): Mark locals as initialized.
4186 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4188 * xterm.c: Fix problems found by static analysis with other toolkits.
4189 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4190 (x_dispatch_event): Declare static if USE_GTK, and
4191 define if USE_GTK || USE_X_TOOLKIT.
4192 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4193 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4194 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4195 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4197 * xmenu.c (menu_help_callback): Pointer type fixes.
4198 Use const pointers when pointing at readonly data. Avoid pointer
4200 (FALSE): Remove unused macro.
4201 (update_frame_menubar): Remove unused decl.
4203 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4205 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4206 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4207 (single_menu_item): Rename local to avoid shadowing.
4209 * keyboard.c (make_lispy_event): Remove unused local var.
4211 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4212 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4214 * bitmaps: Change bitmaps from unsigned char back to the X11
4215 compatible char. Avoid the old compiler warnings about
4216 out-of-range initializers by using, for example, '\xab' rather
4219 * xgselect.c (xgselect_initialize): Check vs interface
4220 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4222 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4224 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4225 to read-only memory.
4227 * fns.c (vector): Remove; this old hack is no longer needed.
4229 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4231 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4233 * xrdb.c (x_load_resources): Omit unused local.
4235 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4236 (x_window): Rename locals to avoid shadowing.
4237 (USG): Use the kludged USG macro, to pacify gcc.
4239 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4240 (x_term_init): Remove local to avoid shadowing.
4242 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4244 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4245 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4247 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4249 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4251 Fix regex.c, syntax.c and friends for buffers > 2GB.
4252 * syntax.h (struct gl_state_s): Declare character position members
4255 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4257 * textprop.c (verify_interval_modification, interval_of):
4258 Declare arguments EMACS_INT.
4260 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4263 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4265 * indent.c (Fvertical_motion): Local variable it_start is now
4268 * regex.c (re_match, re_match_2, re_match_2_internal)
4269 (bcmp_translate, regcomp, regexec, print_double_string)
4270 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4271 (re_compile_pattern, re_exec): Declare arguments and local
4272 variables `size_t' and `ssize_t' and return values `regoff_t', as
4274 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4275 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4276 <compile_stack_type>: `size' and `avail' are now `size_t'.
4278 * regex.h <regoff_t>: Use ssize_t, not int.
4279 (re_search, re_search_2, re_match, re_match_2): Arguments that
4280 specify buffer/string position and length are now ssize_t and
4281 size_t. Return type is regoff_t.
4283 2011-04-16 Ben Key <bkey76@gmail.com>
4285 * nsfont.m: Fixed bugs in ns_get_family and
4286 ns_descriptor_to_entity that were caused by using free to
4287 deallocate memory blocks that were allocated by xmalloc (via
4288 xstrdup). This caused Emacs to crash when compiled with
4289 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4290 --enable-checking=xmallocoverrun). xfree is now used to
4291 deallocate these memory blocks.
4293 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4295 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4297 emacs_write: Accept and return EMACS_INT for sizes.
4298 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4300 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4301 Accept and return EMACS_INT.
4302 (emacs_gnutls_write): Return the number of bytes written on
4304 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4305 (emacs_read, emacs_write): Remove check for negative size, as the
4306 Emacs source code has been audited now.
4307 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4308 (emacs_read, emacs_write): Use it.
4309 * process.c (send_process): Adjust to the new signatures of
4310 emacs_write and emacs_gnutls_write. Do not attempt to store
4311 a byte offset into an 'int'; it might overflow.
4312 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4314 * sound.c: Don't assume sizes fit in 'int'.
4315 (struct sound_device.period_size, alsa_period_size):
4316 Return EMACS_INT, not int.
4317 (struct sound_device.write, vox_write, alsa_write):
4318 Accept EMACS_INT, not int.
4319 (wav_play, au_play): Use EMACS_INT to store sizes and to
4320 record read return values.
4322 2011-04-15 Ben Key <bkey76@gmail.com>
4324 * keyboard.c (Qundefined): Don't declare static since it is used
4326 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4327 static since they are used in nsfont.m.
4329 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4331 * process.c (Qprocessp): Don't declare static.
4332 * lisp.h (Qprocessp): Declare again.
4334 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4336 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4338 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4340 Improve C-level modularity by making more things 'static'.
4342 Don't publish debugger-only interfaces to other modules.
4343 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4344 (verify_bytepos, count_markers): Move decls to the only modules
4346 * region-cache.h (pp_cache): Likewise.
4347 * window.h (check_all_windows): Likewise.
4348 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4350 * sysdep.c (croak): Now static, if
4351 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4352 * syssignal.h (croak): Declare only if not static.
4354 * alloc.c (refill_memory_reserve): Now static if
4355 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4356 * lisp.h (refill_memory_reserve): Declare only if not static.
4358 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4359 Define only if USE_LUCID.
4361 * xrdb.c (x_customization_string, x_rm_string): Now static.
4363 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4364 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4366 * xdisp.c (draw_row_with_mouse_face): Now static.
4367 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4369 * window.h (check_all_windows): Mark externally visible.
4371 * window.c (window_deletion_count): Now static.
4373 * undo.c: Make symbols static if they're not exported.
4374 (last_undo_buffer, last_boundary_position, pending_boundary):
4377 * textprop.c (interval_insert_behind_hooks): Now static.
4378 (interval_insert_in_front_hooks): Likewise.
4380 * term.c: Make symbols static if they're not exported.
4381 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4382 (max_frame_lines, tty_set_terminal_modes):
4383 (tty_reset_terminal_modes, tty_turn_off_highlight):
4384 (get_tty_terminal): Now static.
4385 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4386 * termhooks.h (term_mouse_moveto): Do not declare if
4388 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4389 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4391 * sysdep.c: Make symbols static if they're not exported.
4392 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4394 (sigprocmask_set, full_mask): Remove; unused.
4395 (wait_debugging): Mark as visible.
4396 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4397 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4399 * syntax.c (syntax_temp): Define only if !__GNUC__.
4401 * sound.c (current_sound_device, current_sound): Now static.
4403 * search.c (searchbufs, searchbuf_head): Now static.
4405 * scroll.c (scroll_cost): Remove; unused.
4406 * dispextern.h (scroll_cost): Remove decl.
4408 * region-cache.h (pp_cache): Mark as externally visible.
4410 * process.c: Make symbols static if they're not exported.
4411 (process_tick, update_tick, create_process, chan_process):
4412 (Vprocess_alist, proc_buffered_char, datagram_access):
4413 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4414 (deactivate_process): Mark defn as static, as well as decl.
4415 * lisp.h (create_process): Remove decl.
4416 * process.h (chan_process, Vprocess_alist): Remove decls.
4418 * print.c: Make symbols static if they're not exported.
4419 (print_depth, new_backquote_output, being_printed, print_buffer):
4420 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4421 (print_interval, print_number_index, initial_stderr_stream):
4423 * lisp.h (Fprinc): Remove decl.
4424 (debug_output_compilation_hack): Mark as externally visible.
4426 * sysdep.c (croak): Move decl from here to syssignal.h.
4427 * syssignal.h (croak): Put it here, so the API can be checked when
4428 'croak' is called from dissociate_if_controlling_tty.
4430 * minibuf.c: Make symbols static if they're not exported.
4431 (minibuf_save_list, choose_minibuf_frame): Now static.
4432 * lisp.h (choose_minibuf_frame): Remove decl.
4434 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4436 * lread.c: Make symbols static if they're not exported.
4437 (read_objects, initial_obarray, oblookup_last_bucket_number):
4439 (make_symbol): Remove; unused.
4440 * lisp.h (initial_obarray, make_symbol): Remove decls.
4442 * keyboard.c: Make symbols static if they're not exported.
4443 (single_kboard, recent_keys_index, total_keys, recent_keys):
4444 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4445 (this_single_command_key_start, echoing, last_auto_save):
4446 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4447 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4448 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4449 (Vlispy_mouse_stem, double_click_count):
4451 (force_auto_save_soon): Define only if SIGDANGER.
4452 (ignore_mouse_drag_p): Now static if
4453 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4454 (print_help): Remove; unused.
4455 (stop_character, last_timer_event): Mark as externally visible.
4456 * keyboard.h (ignore_mouse_drag_p): Declare only if
4457 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4458 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4459 * lisp.h (echoing): Remove decl.
4460 (force_auto_save_soon): Declare only if SIGDANGER.
4461 * xdisp.c (redisplay_window): Simplify code, to make it more
4462 obvious that ignore_mouse_drag_p is not accessed if !defined
4463 USE_GTK && !defined HAVE_NS.
4465 * intervals.c: Make symbols static if they're not exported.
4466 (merge_properties_sticky, merge_interval_right, delete_interval):
4468 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4470 * insdel.c: Make symbols static if they're not exported.
4471 However, leave prepare_to_modify_buffer alone. It's never
4472 called from outside this function, but that appears to be a bug.
4473 (combine_after_change_list, combine_after_change_buffer):
4474 (adjust_after_replace, signal_before_change): Now static.
4475 (adjust_after_replace_noundo): Remove; unused.
4476 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4477 (signal_before_change): Remove decls.
4479 * indent.c (val_compute_motion, val_vmotion): Now static.
4481 * image.c: Make symbols static if they're not exported.
4482 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4484 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4485 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4487 * fringe.c (standard_bitmaps): Now static.
4488 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4490 * frame.c: Make symbols static if they're not exported.
4491 (x_report_frame_params, make_terminal_frame): Now static.
4492 (get_frame_param): Now static, unless HAVE_NS.
4493 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4494 (x_get_resource_string): Remove; not used.
4495 * frame.h (make_terminal_frame, x_report_frame_params):
4496 (x_get_resource_string); Remove decls.
4497 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4498 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4500 * font.c, fontset.c: Make symbols static if they're not exported.
4501 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4502 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4503 * font.c (font_close_object): Now static.
4504 * font.h (font_close_object): Remove.
4505 * fontset.c (FONTSET_OBJLIST): Remove.
4506 (free_realized_fontset) #if-0 the body, which does nothing.
4507 (face_suitable_for_char_p): #if-0, as it's never called.
4508 * fontset.h (face_suitable_for_char_p): Remove decl.
4509 * xfaces.c (face_at_string_position):
4510 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4511 since 0 is always ASCII.
4513 * fns.c (weak_hash_tables): Now static.
4515 * fileio.c: Make symbols static if they're not exported.
4516 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4517 (Vwrite_region_annotation_buffers): Now static.
4519 * eval.c: Make symbols static if they're not exported.
4520 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4521 * lisp.h (backtrace_list): Remove decl.
4523 * emacs.c: Make symbols static if they're not exported.
4524 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4525 (fatal_error_code, fatal_error_signal_hook, standard_args):
4527 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4528 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4529 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4530 * lisp.h (fatal_error_signal_hook): Remove decl.
4531 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4533 * editfns.c: Move a (normally-unused) function to its only use.
4534 * editfns.c, lisp.h (get_operating_system_release): Remove.
4535 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4536 worth the hassle of breaking this out.
4538 * xterm.c: Make symbols static if they're not exported.
4539 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4540 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4541 (x_destroy_window, x_delete_display):
4543 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4544 (x_mouse_leave): Remove; unused.
4545 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4546 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4547 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4549 (x_mouse_leave): Declare only if WINDOWSNT.
4550 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4551 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4554 * ftxfont.c: Make symbols static if they're not exported.
4555 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4557 * font.h (ftxfont_driver): Likewise.
4559 * xfns.c: Make symbols static if they're not exported.
4560 (x_last_font_name, x_display_info_for_name):
4561 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4562 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4563 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4564 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4565 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4566 (last_show_tip_args): Now static.
4567 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4568 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4569 (x_screen_planes): Remove; unused.
4570 * dispextern.h (x_screen_planes): Remove decl.
4572 * dispnew.c: Make symbols static if they're not exported.
4573 * dispextern.h (redraw_garbaged_frames, scrolling):
4574 (increment_row_positions): Remove.
4575 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4576 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4578 (redraw_garbaged_frames): Remove; unused.
4580 * xfaces.c: Make symbols static if they're not exported.
4581 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4583 * xterm.h (defined_color): Remove decls.
4584 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4585 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4586 (menu_face_changed_default, defined_color, free_realized_face):
4587 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4588 (ascii_face_of_lisp_face): Remove; unused.
4590 * xdisp.c: Make symbols static if they're not exported.
4591 * dispextern.h (scratch_glyph_row, window_box_edges):
4592 (glyph_to_pixel_coords, set_cursor_from_row):
4593 (get_next_display_element, set_iterator_to_next):
4594 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4595 (show_mouse_face): Remove decls
4596 * frame.h (message_buf_print): Likewise.
4597 * lisp.h (pop_message, set_message, check_point_in_composition):
4599 * xterm.h (set_vertical_scroll_bar): Likewise.
4600 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4601 (message_buf_print, scratch_glyph_row, displayed_buffer):
4602 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4603 (get_next_display_element, show_mouse_face, window_box_edges):
4604 (frame_to_window_pixel_xy, check_point_in_composition):
4605 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4606 (glyph_to_pixel_coords): Remove; unused.
4608 * dired.c (file_name_completion): Now static.
4610 * dbusbind.c (xd_in_read_queued_messages): Now static.
4612 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4613 * data.c (circular_list_error): Remove.
4615 * commands.h (last_point_position, last_point_position_buffer):
4616 (last_point_position_window): Remove decls.
4617 * keyboard.c: Make these variables static.
4619 * coding.h (coding, code_convert_region, encode_coding_gap):
4621 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4622 (iso_code_class, detect_coding, code_convert_region): Now static.
4623 (encode_coding_gap): Remove; unused.
4625 * chartab.c (chartab_chars, chartab_bits): Now static.
4627 * charset.h (charset_iso_8859_1): Remove decl.
4628 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4631 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4632 * ccl.c (Vccl_program_table): Now static.
4633 (check_ccl_update): Remove; unused.
4635 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4636 * category.h: ... from here.
4637 * category.c (check_category_table, set_category_set): Now static.
4639 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4640 * lisp.h: Remove these decls.
4642 * buffer.c (buffer_count): Remove unused var.
4644 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4645 so that it's not optimized away.
4646 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4647 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4648 exported only to the debugger.
4650 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4651 * atimer.h (run_all_atimers): Remove; not exported.
4653 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4654 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4655 was inaccessible from Lisp.
4656 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4657 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4659 alloc.c: Import and export fewer symbols, and remove unused items.
4660 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4662 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4663 it's not optimized away by whole-program optimization.
4664 (message_enable_multibyte, free_misc): Remove.
4665 (catchlist, handlerlist, mark_backtrace):
4666 Declare only if BYTE_MARK_STACK.
4667 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4668 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4669 (message_enable_multibyte): Remove decl.
4670 (free_misc, interval_free_list, float_block, float_block_index):
4671 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4672 (cons_free_list, last_marked_index):
4674 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4675 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4676 (mark_backtrace): Define only if BYTE_MARK_STACK.
4677 * xdisp.c (message_enable_multibyte): Now static.
4679 Declare Lisp_Object Q* variables to be 'static' if not exported.
4680 This makes it easier for human readers (and static analyzers)
4681 to see whether these variables are used from other modules.
4682 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4683 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4684 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4685 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4686 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4687 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4688 * xmenu.c, xselect.c:
4689 Declare Q* vars static if they are not used in other modules.
4690 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4691 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4692 Remove decls of unexported vars.
4693 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4695 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4697 Make Emacs functions such as Fatom 'static' by default.
4698 This makes it easier for human readers (and static analyzers)
4699 to see whether these functions can be called from other modules.
4700 DEFUN now defines a static function. To make the function external
4701 so that it can be used in other C modules, use the new macro DEFUE.
4702 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4703 (Finit_image_library):
4704 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4705 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4706 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4707 Remove decls, since these functions are now static.
4708 (Funintern, Fget_internal_run_time): New decls, since these functions
4709 were already external.
4711 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4712 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4713 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4714 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4715 * keyboard.c, keymap.c, lread.c:
4716 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4717 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4718 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4719 Mark functions with DEFUE instead of DEFUN,
4720 if they are used in other modules.
4721 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4722 decls for now-static functions.
4723 * buffer.h (Fdelete_overlay): Remove decl.
4724 * callproc.c (Fgetenv_internal): Mark as internal.
4725 * composite.c (Fremove_list_of_text_properties): Remove decl.
4726 (Fcomposition_get_gstring): New forward static decl.
4727 * composite.h (Fcomposite_get_gstring): Remove decl.
4728 * dired.c (Ffile_attributes): New forward static decl.
4729 * doc.c (Fdocumntation_property): New forward static decl.
4730 * eval.c (Ffetch_bytecode): New forward static decl.
4731 (Funintern): Remove extern decl; now in .h file where it belongs.
4732 * fileio.c (Fmake_symbolic_link): New forward static decl.
4733 * image.c (Finit_image_library): New forward static decl.
4734 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4735 * intervals.h (Fprevious_property_change):
4736 (Fremove_list_of_text_properties): Remove decls.
4737 * keyboard.c (Fthis_command_keys): Remove decl.
4738 (Fcommand_execute): New forward static decl.
4739 * keymap.c (Flookup_key): New forward static decl.
4740 (Fcopy_keymap): Now static.
4741 * keymap.h (Flookup_key): Remove decl.
4742 * process.c (Fget_process): New forward static decl.
4743 (Fprocess_datagram_address): Mark as internal.
4744 * syntax.c (Fsyntax_table_p): New forward static decl.
4745 (skip_chars): Remove duplicate decl.
4746 * textprop.c (Fprevious_property_change): New forward static decl.
4747 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4749 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4750 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4752 * editfns.c (Fformat): Remove unreachable code.
4754 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4756 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4759 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4761 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4762 when at ZV. (Bug#8487)
4764 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4766 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4768 * keyboard.c (parse_tool_bar_item): Likewise.
4769 * sound.c (sound_cleanup, alsa_close): Likewise.
4770 * termcap.c (tgetent): Likewise.
4771 * xfns.c (x_default_font_parameter): Likewise.
4772 * xsettings.c (read_and_apply_settings): Likewise.
4774 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4775 (overrun_check_free): Protoize.
4777 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4779 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4780 since callers should never pass a negative size.
4781 Change the signature to match that of plain 'read' and 'write'; see
4782 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4783 * lisp.h: Update prototypes of emacs_write and emacs_read.
4785 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4787 * xdisp.c (redisplay_window): Don't try to determine the character
4788 position of the scroll margin if the window start point w->startp
4789 is outside the buffer's accessible region. (Bug#8468)
4791 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4793 Fix write-region and its subroutines for buffers > 2GB.
4794 * fileio.c (a_write, e_write): Modify declaration of arguments and
4795 local variables to support buffers larger than 2GB.
4796 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4798 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4799 argument, local variables, and return value.
4801 * lisp.h: Update prototypes of emacs_write and emacs_read.
4803 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4805 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4807 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4809 Fix more problems found by GCC 4.6.0's static checks.
4811 * xdisp.c (vmessage): Use a better test for character truncation.
4813 * charset.c (load_charset_map): <, not <=, for optimization,
4814 and to avoid potential problems with integer overflow.
4815 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4816 * casetab.c (set_identity, shuffle): Likewise.
4817 * editfns.c (Fformat): Likewise.
4818 * syntax.c (skip_chars): Likewise.
4820 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4821 This also lets GCC 4.6.0 generate slightly better loop code.
4823 * callint.c (Fcall_interactively): <, not <=, for optimization.
4824 (Fcall_interactively): Count the number of arguments produced,
4825 not the number of arguments given. This is simpler and lets GCC
4826 4.6.0 generate slightly better code.
4828 * ftfont.c: Distingish more carefully between FcChar8 and char.
4829 The previous code passed unsigned char * to a functions like
4830 strlen and xstrcasecmp that expect char *, which does not
4831 conform to the C standard.
4832 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4833 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4834 char * when the C standard requires it.
4836 * keyboard.c (read_char): Remove unused var.
4838 * eval.c: Port to Windows vsnprintf (Bug#8435).
4840 (SIZE_MAX): Define if the headers do not.
4841 (verror): Do not give up if vsnprintf returns a negative count.
4842 Instead, grow the buffer. This ports to Windows vsnprintf, which
4843 does not conform to C99. Problem reported by Eli Zaretskii.
4844 Also, simplify the allocation scheme, by avoiding the need for
4845 calling realloc, and removing the ALLOCATED variable.
4847 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4849 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4850 But keep the doprint source code for now, as we might revamp it
4851 and use it again (Bug#8435).
4852 * lisp.h (doprnt): Remove.
4853 * Makefile.in (base_obj): Remove doprnt.o.
4854 * deps.mk (doprnt.o): Remove.
4856 error: Print 32- and 64-bit integers portably (Bug#8435).
4857 Without this change, on typical 64-bit hosts error ("...%d...", N)
4858 was used to print both 32- and 64-bit integers N, which relied on
4860 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4862 * lisp.h (error, verror): Mark as printf-like functions.
4863 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4864 Report overflow in size calculations when allocating printf buffer.
4865 Do not truncate output string at its first null byte.
4866 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4867 Truncate the output at a character boundary, since vsnprintf does not
4869 * charset.c (check_iso_charset_parameter): Convert internal
4870 character to string before calling 'error', since %c now has the
4872 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4873 overflow when computing char to be passed to 'error'. Do not
4874 pass Lisp_Object to 'error'; pass the integer instead.
4875 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4876 formatted with plain %d.
4878 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4880 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4882 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4884 * xterm.c (x_catch_errors): Remove duplicate declaration.
4886 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4888 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4890 2011-04-10 Jim Meyering <meyering@redhat.com>
4892 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4893 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4894 return ssize_t not "int", and use size_t as the buffer length.
4895 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4896 * gnutls.h: Update declarations.
4897 * process.c (read_process_output): Use ssize_t, to match.
4898 (send_process): Likewise.
4900 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4902 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4904 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4906 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4907 Use unsigned char, to match FcChar8 type definition.
4909 * xterm.c (handle_one_xevent):
4910 * xmenu.c (create_and_show_popup_menu):
4911 * xselect.c (x_decline_selection_request)
4912 (x_reply_selection_request): Avoid type-punned deref of X events.
4914 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4916 Fix some uses of `int' instead of EMACS_INT.
4917 * search.c (string_match_1, fast_string_match)
4918 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4919 (scan_buffer, find_next_newline_no_quit)
4920 (find_before_next_newline, search_command, Freplace_match)
4921 (Fmatch_data): Make some `int' variables be EMACS_INT.
4923 * xdisp.c (display_count_lines): 3rd argument and return value now
4924 EMACS_INT. All callers changed.
4925 (pint2hrstr): Last argument is now EMACS_INT.
4927 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4928 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4929 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4930 (decode_coding_utf_16, decode_coding_emacs_mule)
4931 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4932 (decode_coding_ccl, decode_coding_charset)
4933 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4934 (decode_coding_iso_2022, decode_coding_emacs_mule)
4935 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4936 <char_offset, last_offset>: Declare EMACS_INT.
4937 (encode_coding_utf_8, encode_coding_utf_16)
4938 (encode_coding_emacs_mule, encode_invocation_designation)
4939 (encode_designation_at_bol, encode_coding_iso_2022)
4940 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4941 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4943 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4944 (encode_invocation_designation): Last argument P_NCHARS is now
4946 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4947 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4949 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4952 * ccl.c (Fccl_execute_on_string): Declare some variables
4955 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4957 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4959 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4961 * process.c (Fformat_network_address): Doc fix.
4963 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4965 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4967 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4969 * keyboard.c (read_char): Call Lisp function help-form-show,
4970 instead of using internal_with_output_to_temp_buffer.
4971 (Qhelp_form_show): New var.
4972 (syms_of_keyboard): Use DEFSYM macro.
4974 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4976 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4978 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4980 * process.c (Flist_processes): Remove to Lisp.
4981 (list_processes_1): Delete.
4983 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4985 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4987 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4989 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4991 Fix more problems found by GCC 4.6.0's static checks.
4993 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4995 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4997 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4999 * xdisp.c (vmessage): Mark as a printf-like function.
5001 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5003 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5005 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5006 printf-like functions.
5007 (tiff_load): Add casts to remove these marks before passing them
5008 to system-supplied API.
5010 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5012 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5013 This avoids several warnings with gcc -Wstrict-overflow.
5014 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5015 directly, rather than having caller test rule sign. This avoids
5016 some unnecessary tests.
5017 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5018 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5019 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5021 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5022 (xfont_open): Avoid unnecessary tests.
5024 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5026 * composite.h, composite.c (composition_gstring_put_cache):
5027 Use EMACS_INT, not int, for length.
5029 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5030 breaking out part of COMPOSITION_DECODE_RULE.
5031 (COMPOSITION_DECODE_RULE): Use it.
5032 * composite.c (get_composition_id): Remove unused local vars,
5033 by using the new macro.
5035 * textprop.c (set_text_properties_1): Change while to do-while,
5036 since the condition is always true at first.
5038 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5039 (interval_deletion_adjustment): Return unsigned value.
5042 * process.c (list_processes_1, create_pty, read_process_output):
5043 (exec_sentinel): Remove vars that were set but not used.
5044 (create_pty): Remove unnecessary "volatile"s.
5045 (Fnetwork_interface_info): Avoid possibility of int overflow.
5046 (read_process_output): Do adaptive read buffering even if carryover.
5047 (read_process_output): Simplify nbytes computation if buffered.
5049 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5051 * syntax.c (scan_words): Remove var that was set but not used.
5052 (update_syntax_table): Use unsigned instead of int.
5054 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5055 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5056 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5058 * print.c (print_error_message): Avoid int overflow.
5060 * font.c (font_list_entities): Redo for clarity,
5061 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5063 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5064 (font_score): Avoid potential overflow in diff calculation.
5066 * fns.c (substring_both): Remove var that is set but not used.
5067 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5069 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5071 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5072 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5073 can always succeed if overflow has undefined behavior.
5075 * search.c (boyer_moore, wordify): Remove vars set but not used.
5076 (wordify): Omit three unnecessary tests.
5078 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5079 All callers changed. This avoids the need for an unused var.
5081 * casefiddle.c (casify_region): Remove var that is set but not used.
5083 * dired.c (file_name_completion): Remove var that is set but not used.
5085 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5087 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5088 (Finsert_file_contents): Remove unnecessary code checking fd.
5090 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5091 Check for integer overflow on size calculations.
5093 * buffer.c (Fprevious_overlay_change): Remove var that is set
5096 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5097 Remove vars that are set but not used.
5098 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5099 (timer_check_2): Mark vars as initialized.
5101 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5103 * image.c (lookup_image): Remove var that is set but not used.
5104 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5106 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5107 that are set but not used.
5109 * xfns.c (make_invisible_cursor): Don't return garbage
5110 if XCreateBitmapFromData fails (Bug#8410).
5112 * xselect.c (x_get_local_selection, x_handle_property_notify):
5113 Remove vars that are set but not used.
5115 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5116 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5118 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5119 Remove var that is set but not used.
5120 (scroll_bar_windows_size): Now size_t, not int.
5121 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5124 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5125 (map_tty_color) [!defined MSDOS]: Likewise.
5127 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5129 * coding.c: Remove vars that are set but not used.
5130 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5131 All callers changed.
5132 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5133 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5134 (decode_coding_charset): Remove vars that are set but not used.
5136 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5137 that is set but not used.
5139 * print.c (print_object): Remove var that is set but not used.
5141 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5142 The gnulib version avoids calling malloc in the usual case,
5143 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5144 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5145 * filelock.c (current_lock_owner): Likewise.
5146 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5147 * sysdep.c: Include allocator.h, careadlinkat.h.
5148 (emacs_no_realloc_allocator): New static constant.
5149 (emacs_readlink): New function.
5150 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5151 ../lib/careadlinkat.h.
5153 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5155 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5156 first non-nil return value).
5158 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5160 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5161 if not defined (Bug#8403).
5163 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5165 * xdisp.c (display_count_lines): Remove parameter `start',
5166 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5167 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5168 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5169 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5170 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5171 and thereabouts. All callers changed.
5172 (get_per_char_metric): Remove parameter `f', unused since
5173 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5175 2011-04-02 Jim Meyering <meyering@redhat.com>
5177 do not dereference NULL upon failed strdup
5178 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5179 (ns_get_family): Likewise.
5181 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5183 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5185 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5187 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5190 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5192 Add lexical binding.
5194 * window.c (Ftemp_output_buffer_show): New fun.
5195 (Fsave_window_excursion):
5196 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5198 * lread.c (lisp_file_lexically_bound_p): New function.
5199 (Fload): Bind Qlexical_binding.
5200 (readevalloop): Remove `evalfun' arg.
5201 Bind Qinternal_interpreter_environment.
5202 (Feval_buffer): Bind Qlexical_binding.
5203 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5205 (syms_of_lread): Declare `lexical-binding'.
5207 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5209 * keyboard.c (eval_dyn): New fun.
5210 (menu_item_eval_property): Use it.
5212 * image.c (parse_image_spec): Use Ffunctionp.
5214 * fns.c (concat, mapcar1): Accept byte-code-functions.
5216 * eval.c (Fsetq): Handle lexical vars.
5217 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5218 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5219 (FletX, Flet): Obey lexical binding.
5220 (Fcommandp): Handle closures.
5221 (Feval): New `lexical' arg.
5222 (eval_sub): New function extracted from Feval. Use it almost
5223 everywhere where Feval was used. Look up vars in lexical env.
5225 (Ffunctionp): Move from subr.el.
5226 (Ffuncall): Handle closures.
5227 (apply_lambda): Remove `eval_flags'.
5228 (funcall_lambda): Handle closures and new byte-code-functions.
5229 (Fspecial_variable_p): New function.
5230 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5231 but without exporting it to Lisp.
5233 * doc.c (Fdocumentation, store_function_docstring):
5234 * data.c (Finteractive_form): Handle closures.
5236 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5239 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5241 (exec_byte_code): New function extracted from Fbyte_code to handle new
5242 calling convention for byte-code-functions. Add new byte-codes.
5244 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5246 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5248 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5250 * xdisp.c (redisplay_internal): Fix prototype.
5252 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5254 * xdisp.c (SCROLL_LIMIT): New macro.
5255 (try_scrolling): Use it when setting scroll_limit.
5256 Limit scrolling to 100 screen lines.
5257 (redisplay_window): Even when falling back on "recentering",
5258 position point in the window according to scroll-conservatively,
5259 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5261 (try_scrolling): When point is above the window, allow searching
5262 as far as scroll_max, or one screenful, to compute vertical
5263 distance from PT to the scroll margin position. This prevents
5264 try_scrolling from unnecessarily failing when
5265 scroll-conservatively is set to a value slightly larger than the
5266 window height. Clean up the case of PT below the margin at bottom
5267 of window: scroll_max can no longer be INT_MAX. When aggressive
5268 scrolling is in use, don't let point enter the opposite scroll
5269 margin as result of the scroll.
5270 (syms_of_xdisp) <scroll-conservatively>: Document the
5271 threshold of 100 lines for never-recentering scrolling.
5273 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5275 * dispextern.h (move_it_by_lines):
5276 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5277 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5278 (message_log_check_duplicate): Remove parameters `prev_bol' and
5279 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5280 (redisplay_internal): Remove parameter `preserve_echo_area',
5281 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5283 * indent.c (Fvertical_motion):
5284 * window.c (window_scroll_pixel_based, Frecenter):
5285 Don't pass `need_y_p' to `move_it_by_lines'.
5287 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5289 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5290 steal a few bits to be more compact.
5291 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5292 Remove unneeded casts.
5294 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5296 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5298 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5299 binding" message (bug#7967).
5301 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5303 Fix more problems found by GCC 4.6.0's static checks.
5305 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5306 Remove unused local var.
5308 * editfns.c (Fmessage_box): Remove unused local var.
5310 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5311 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5312 Omit unused local vars.
5313 * window.c (shrink_windows): Omit unused local var.
5314 * menu.c (digest_single_submenu): Omit unused local var.
5315 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5316 Omit unused local var.
5318 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5319 Don't assume string length fits in int.
5320 (keyremap_step, read_key_sequence): Use size_t for sizes.
5321 (read_key_sequence): Don't check last_real_key_start redundantly.
5323 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5324 instead of alloca (Bug#8344).
5326 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5327 (Fbacktrace_frame): Don't assume nframes fits in int.
5329 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5331 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5334 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5336 * cm.c (calccost): Turn while-do into do-while, for clarity.
5338 * keyboard.c (syms_of_keyboard): Use the same style as later
5339 in this function when indexing through an array. This also
5340 works around GCC bug 48267.
5342 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5344 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5346 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5347 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5349 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5350 This avoids undefined behavior on integer overflow, and is a bit
5351 more convenient anyway since it is compared to a size_t variable.
5353 Variadic C functions now count arguments with size_t, not int.
5354 This avoids an unnecessary limitation on 64-bit machines, which
5355 caused (substring ...) to crash on large vectors (Bug#8344).
5356 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5357 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5358 All variadic functions and their callers changed accordingly.
5359 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5360 * data.c (arith_driver, float_arith_driver): Likewise.
5361 * editfns.c (general_insert_function): Likewise.
5362 * eval.c (struct backtrace.nargs, interactive_p)
5363 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5364 (funcall_lambda, mark_backtrace): Likewise.
5365 * fns.c (concat): Likewise.
5366 * frame.c (x_set_frame_parameters): Likewise.
5367 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5368 0 if not found, not -1. All callers changed.
5370 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5371 (stack_copy_size): Now size_t, not int.
5372 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5374 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5376 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5377 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5378 All callers changed.
5380 * lisp.h (multibyte_char_to_unibyte):
5381 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5382 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5383 * character.h (CHAR_TO_BYTE8):
5384 * cmds.c (internal_self_insert):
5385 * editfns.c (general_insert_function):
5386 * keymap.c (push_key_description):
5387 * search.c (Freplace_match):
5388 * xdisp.c (message_dolog, set_message_1): All callers changed.
5390 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5392 * keyboard.c (safe_run_hook_funcall): New function.
5393 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5394 don't set the hook to nil, but remove the offending function instead.
5395 (Qcommand_hook_internal): Remove, unused.
5396 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5397 Vcommand_hook_internal.
5399 * eval.c (enum run_hooks_condition): Remove.
5400 (funcall_nil, funcall_not): New functions.
5401 (run_hook_with_args): Call each function through a `funcall' argument.
5402 Remove `cond' argument, now redundant.
5403 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5404 (Frun_hook_with_args_until_failure): Adjust accordingly.
5405 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5407 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5409 * dispextern.h (string_buffer_position): Remove declaration.
5411 * print.c (strout): Remove parameter `multibyte', unused since
5412 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5414 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5415 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5416 All callers changed.
5418 * w32.c (_wsa_errlist): Use braces for struct initializers.
5420 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5421 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5422 All callers changed.
5423 (string_buffer_position): Likewise. Also, make static (it's never
5424 used outside xdisp.c).
5425 (cursor_row_p): Remove parameter `w', unused since
5426 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5427 (decode_mode_spec): Remove parameter `precision', introduced during
5428 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5429 All callers changed.
5431 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5433 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5435 2011-03-27 Anders Lindgren <andlind@gmail.com>
5437 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5438 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5439 (ns_update_auto_hide_menu_bar): New functions.
5440 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5441 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5442 ns_constrain_all_frames.
5443 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5444 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5446 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5448 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5450 2011-03-27 Glenn Morris <rgm@gnu.org>
5452 * syssignal.h: Replace RETSIGTYPE with void.
5453 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5454 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5455 Replace SIGTYPE with void everywhere.
5456 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5457 * s/template.h (SIGTYPE): Remove commented out definition.
5459 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5461 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5462 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5464 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5466 * w32.c (read_unc_volume): Use parameter `henum', instead of
5467 global variable `wget_enum_handle'.
5469 * keymap.c (describe_vector): Remove parameters `indices' and
5470 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5471 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5473 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5475 * keyboard.c (timer_check): Remove parameter `do_it_now',
5476 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5477 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5478 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5480 * keyboard.c (read_char):
5481 * w32menu.c (w32_menu_display_help):
5482 * xmenu.c (show_help_event, menu_help_callback):
5483 Adjust calls to `show_help_echo'.
5485 * gtkutil.c (xg_maybe_add_timer):
5486 * keyboard.c (readable_events):
5487 * process.c (wait_reading_process_output):
5488 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5490 * insdel.c (adjust_markers_gap_motion):
5491 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5492 (gap_left, gap_right): Don't call it.
5494 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5496 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5497 incurred during fontification.
5499 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5501 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5502 (DEFVAR_PER_BUFFER): Don't pass it.
5504 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5505 (scrolling_window): Don't pass it.
5507 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5509 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5511 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5513 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5514 of variables specific to SELinux and computation of `encoded_absname'.
5516 * image.c (XPutPixel): Remove unused variable `height'.
5518 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5520 * unexw32.c (get_section_info): Remove unused variable `section'.
5522 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5523 (system_process_attributes): Remove unused variable `sess'.
5524 (sys_read): Remove unused variable `err'.
5526 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5527 (w32_wnd_proc): Remove unused variable `isdead'.
5528 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5529 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5530 (x_create_tip_frame): Remove unused variable `tem'.
5532 * w32inevt.c (w32_console_read_socket):
5533 Remove unused variable `no_events'.
5535 * w32term.c (x_draw_composite_glyph_string_foreground):
5536 Remove unused variable `width'.
5538 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5540 * w32term.c (x_set_glyph_string_clipping):
5541 Don't pass uninitialized region to CombineRgn.
5543 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5545 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5546 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5547 (Fx_close_connection): Remove unused variable `i'.
5549 * w32font.c (w32font_draw): Return number of glyphs.
5550 (w32font_open_internal): Remove unused variable `i'.
5551 (w32font_driver): Add missing initializer.
5553 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5554 (fill_in_menu): Remove unused variable `items_added'.
5556 * w32term.c (last_mouse_press_frame): Remove static global variable.
5557 (w32_clip_to_row): Remove unused variable `f'.
5558 (x_delete_terminal): Remove unused variable `i'.
5560 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5561 (NOTHING): Remove unused static global variable.
5562 (uniscribe_check_otf): Remove unused variable `table'.
5563 (uniscribe_font_driver): Add missing initializers.
5565 2011-03-23 Julien Danjou <julien@danjou.info>
5567 * term.c (Fsuspend_tty, Fresume_tty):
5568 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5569 * window.c (temp_output_buffer_show):
5570 * insdel.c (signal_before_change):
5571 * frame.c (Fhandle_switch_frame):
5572 * fileio.c (Fdo_auto_save):
5573 * emacs.c (Fkill_emacs):
5574 * editfns.c (save_excursion_restore):
5575 * cmds.c (internal_self_insert):
5576 * callint.c (Fcall_interactively):
5577 * buffer.c (Fkill_all_local_variables):
5578 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5580 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5581 unconditionnaly since it does the check itself.
5583 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5585 Fix more problems found by GCC 4.5.2's static checks.
5587 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5588 the first time through the loop, since we know p0 < p1 then.
5589 This also avoids a gcc -Wstrict-overflow warning.
5591 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5592 leading to a memory leak, possible in functions like
5593 load_charset_map_from_file that can allocate an unbounded number
5594 of objects (Bug#8318).
5596 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5597 that could (at least in theory) be that large.
5599 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5600 This is less likely to overflow, and avoids undefined behavior if
5601 overflow does occur. All callers changed. Use strtoul to scan
5602 for the unsigned long integer.
5603 (pint2hrstr): Simplify and tune code slightly.
5604 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5606 * scroll.c (do_scrolling): Work around GCC bug 48228.
5607 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5609 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5610 This also avoids a warning with gcc -Wstrict-overflow.
5611 (validate_x_resource_name): Simplify count usage.
5612 This also avoids a warning with gcc -Wstrict-overflow.
5614 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5617 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5619 * process.c (Fmake_network_process): Use socklen_t, not int,
5620 where POSIX says socklen_t is required in portable programs.
5621 This fixes a porting bug on hosts like 64-bit HP-UX, where
5622 socklen_t is wider than int (Bug#8277).
5623 (Fmake_network_process, server_accept_connection):
5624 (wait_reading_process_output, read_process_output):
5627 * process.c: Rename or move locals to avoid shadowing.
5628 (list_processes_1, Fmake_network_process):
5629 (read_process_output_error_handler, exec_sentinel_error_handler):
5630 Rename or move locals.
5631 (Fmake_network_process): Define label "retry_connect" only if needed.
5632 (Fnetwork_interface_info): Fix pointer signedness.
5633 (process_send_signal): Add cast to avoid pointer signedness problem.
5634 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5635 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5637 Make tparam.h and terminfo.c consistent.
5638 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5639 Include tparam.h instead, since it declares them.
5640 * cm.h (PC): Remove extern decl; tparam.h now does this.
5641 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5642 * terminfo.c: Include tparam.h, to check interfaces.
5643 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5644 (tparam): Adjust signature to match interface in tparam.h;
5645 this removes some undefined behavior. Check that outstring and len
5646 are zero, which they always are with Emacs.
5647 * tparam.h (PC, BC, UP): New extern decls.
5649 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5650 (xftfont_open): Rename locals to avoid shadowing.
5652 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5653 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5654 (OTF_TAG_SYM): Omit macro if not needed.
5655 (ftfont_list): Remove unused local.
5656 (get_adstyle_property, ftfont_pattern_entity):
5657 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5658 Rename locals to avoid shadowing.
5660 * xfont.c (xfont_list_family): Mark var as initialized.
5662 * xml.c (make_dom): Now static.
5664 * composite.c (composition_compute_stop_pos): Rename local to
5666 (composition_reseat_it): Remove unused locals.
5667 (find_automatic_composition, composition_adjust_point): Likewise.
5668 (composition_update_it): Mark var as initialized.
5669 (find_automatic_composition): Mark vars as initialized,
5670 with a FIXME (Bug#8290).
5672 character.h: Rename locals to avoid shadowing.
5673 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5674 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5675 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5676 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5679 * textprop.c (property_change_between_p): Remove; unused.
5681 * intervals.c (interval_start_pos): Now static.
5683 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5685 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5686 Rename locals to avoid shadowing.
5688 * sound.c (wav_play, au_play, Fplay_sound_internal):
5689 Fix pointer signedness.
5690 (alsa_choose_format): Remove unused local var.
5691 (wav_play): Initialize a variable to 0, to prevent undefined
5692 behavior (Bug#8278).
5694 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5696 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5698 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5699 clobbering (Bug#8298).
5700 * sysdep.c (sys_subshell): Likewise.
5701 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5703 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5704 This should get cleaned up, so that child_setup has the
5705 same signature on all platforms.
5707 * callproc.c (call_process_cleanup): Now static.
5708 (relocate_fd): Rename locals to avoid shadowing.
5710 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5712 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5713 not to be necessary, and produces flickering.
5715 2011-03-20 Glenn Morris <rgm@gnu.org>
5717 * config.in: Remove file.
5719 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5721 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5722 are now in src/globals.h.
5723 (syms_of_minibuf): Remove spurious & from previous change.
5725 2011-03-20 Leo <sdl.web@gmail.com>
5727 * minibuf.c (completing-read-function): New variable.
5728 (completing-read-default): Rename from completing-read.
5729 (completing-read): Call completing-read-function.
5731 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5733 * xfaces.c (Fx_load_color_file):
5734 Read color file from absolute filename (bug#8250).
5736 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5738 * makefile.w32-in: Update dependencies.
5740 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5742 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5744 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5746 Fix more problems found by GCC 4.5.2's static checks.
5748 * process.c (make_serial_process_unwind, send_process_trap):
5749 (sigchld_handler): Now static.
5751 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5752 That way, the code declares only the vars that it needs.
5753 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5754 * s/cygwin.h (PTY_ITERATION): Likewise.
5755 * s/darwin.h (PTY_ITERATION): Likewise.
5756 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5758 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5759 * process.c (allocate_pty): Don't declare stb unless it's needed.
5761 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5762 (CONSTANTLIM): Remove; unused.
5763 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5764 Define only if needed.
5766 * unexelf.c (unexec): Name an expression,
5767 to avoid gcc -Wbad-function-cast warning.
5768 Use a different way to cause a compilation error if anyone uses
5769 n rather than nn, a way that does not involve shadowing.
5770 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5772 * deps.mk (unexalpha.o): Remove; unused.
5774 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5775 * unexec.h: New file.
5776 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5777 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5779 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5780 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5781 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5782 Change as necessary to match prototype in unexec.h.
5784 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5786 (back_comment, skip_chars): Mark vars as initialized.
5788 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5789 Rename locals to avoid shadowing.
5791 * lread.c (read1): Rewrite so as not to use empty "else".
5792 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5794 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5796 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5797 warning when compiling print.c.
5799 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5800 instead of using an uninitialized var.
5801 (font_sort_entities): Mark var as initialized.
5803 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5805 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5806 pointers to constants.
5807 (font_parse_fcname): Remove unused vars.
5808 (font_delete_unmatched): Now static.
5809 (font_get_spec): Remove; unused.
5810 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5811 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5812 Rename or move locals to avoid shadowing.
5814 * fns.c (require_nesting_list, require_unwind): Now static.
5815 (Ffillarray): Rename locals to avoid shadowing.
5817 * floatfns.c (domain_error2): Define only if needed.
5818 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5820 * alloc.c (mark_backtrace): Move decl from here ...
5821 * lisp.h: ... to here, so that it can be checked.
5823 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5824 (Fdefvar): Rewrite so as not to use empty "else".
5825 (lisp_indirect_variable): Name an expression,
5826 to avoid gcc -Wbad-function-cast warning.
5827 (Fdefvar): Rename locals to avoid shadowing.
5829 * callint.c (quotify_arg, quotify_args): Now static.
5830 (Fcall_interactively): Rename locals to avoid shadowing.
5831 Use const pointer when appropriate.
5833 * lisp.h (get_system_name, get_operating_system_release):
5834 Move decls here, to check interfaces.
5835 * process.c (get_operating_system_release): Move decl to lisp.h.
5836 * xrdb.c (get_system_name): Likewise.
5837 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5838 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5839 some of which prompt warnings from gcc -Wbad-function-cast.
5840 (Fformat_time_string, Fencode_time, Finsert_char):
5841 (Ftranslate_region_internal, Fformat):
5842 Rename or remove local vars to avoid shadowing.
5843 (Ftranslate_region_internal): Mark var as initialized.
5845 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5848 * lisp.h (eassert): Check that the argument compiles, even if
5849 ENABLE_CHECKING is not defined.
5851 * data.c (Findirect_variable): Name an expression, to avoid
5852 gcc -Wbad-function-cast warning.
5853 (default_value, arithcompare, arith_driver, arith_error): Now static.
5854 (store_symval_forwarding): Rename local to avoid shadowing.
5855 (Fmake_variable_buffer_local, Fmake_local_variable):
5856 Mark variables as initialized.
5857 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5859 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5860 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5861 Rename locals to avoid shadowing.
5862 (mark_stack): Move local variables into the #ifdef region where
5864 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5865 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5867 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5868 (GC_STRING_CHARS): Remove; not used.
5869 (Fmemory_limit): Cast sbrk's returned value to char *.
5871 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5872 avoids undefined behavior in theory.
5874 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5876 Use functions, not macros, for up- and down-casing (Bug#8254).
5877 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5878 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5879 to use the following functions instead of these macros.
5880 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5881 EMACS_INT, since callers assume the returned value fits in int.
5882 (upcase1): Likewise, for UPCASE_TABLE.
5883 (uppercasep, lowercasep, upcase): New static inline functions.
5884 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5885 the race-condition problem in the old DOWNCASE.
5887 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5888 Rename locals to avoid shadowing.
5889 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5890 (regex_compile, re_search_2, re_match_2_internal):
5891 Remove unused local vars.
5892 (FREE_VAR): Rewrite so as not to use empty "else",
5893 which gcc can warn about.
5894 (regex_compile, re_match_2_internal): Mark locals as initialized.
5895 (RETALLOC_IF): Define only if needed.
5896 (WORDCHAR_P): Likewise. This one is never needed, but is used
5897 only in a comment talking about a compiler bug, so put inside
5898 the #if 0 of that comment.
5899 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5900 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5903 * search.c (boyer_moore): Rename locals to avoid shadowing.
5904 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5905 (PREV_CHAR_BOUNDARY): Likewise.
5907 * search.c (simple_search): Remove unused var.
5909 * dired.c (compile_pattern): Move decl from here ...
5910 * lisp.h: ... to here, so that it can be checked.
5911 (struct re_registers): New forward decl.
5913 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5915 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5917 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5918 Rename locals to avoid shadowing.
5919 (Fvertical_motion): Mark locals as initialized.
5921 * casefiddle.c (casify_object, casify_region): Now static.
5922 (casify_region): Mark local as initialized.
5924 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5926 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5927 New macros, so that the caller can use some names other than
5928 gcpro1, gcpro2, etc.
5929 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5931 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5932 argument, for consistency with GCPRO2_VAR, etc: it is now the
5933 prefix of the variable, not the variable itself. All uses
5935 * dired.c (directory_files_internal, file_name_completion):
5936 Rename locals to avoid shadowing.
5938 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5939 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5940 dired.c's scmp function, had undefined behavior.
5941 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5942 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5943 * buffer.h: ... to here, because these macros use current_buffer,
5944 and the new implementation with inline functions needs to have
5945 current_buffer in scope now, rather than later when the macros
5947 (downcase, upcase1): New static inline functions.
5948 (DOWNCASE, UPCASE1): Reimplement using these functions.
5949 This avoids undefined behavior in expressions like
5950 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5951 from race conditions in accessing the global variables
5952 case_temp1 and case_temp2.
5953 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5954 * lisp.h (case_temp1, case_temp2): Remove their decls.
5955 * character.h (ASCII_CHAR_P): Move from here ...
5956 * lisp.h: ... to here, so that the inline functions mentioned
5959 * dired.c (directory_files_internal_unwind): Now static.
5961 * fileio.c (file_name_as_directory, directory_file_name):
5962 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5964 (file_name_as_directory): Use const pointers when appropriate.
5965 (Fexpand_file_name): Likewise. In particular, newdir might
5966 point at constant storage, so make it a const pointer.
5967 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5968 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5970 (Fset_file_times, Finsert_file_contents, auto_save_error):
5971 Rename locals to avoid shadowing.
5973 * minibuf.c (choose_minibuf_frame_1): Now static.
5974 (Ftry_completion, Fall_completions): Rename or remove locals
5977 * marker.c (bytepos_to_charpos): Remove; unused.
5979 * lisp.h (verify_bytepos, count_markers): New decls,
5980 so that gcc does not warn that these functions aren't declared.
5982 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5983 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5984 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5985 (copy_text): Remove unused local var.
5987 * filelock.c (within_one_second): Now static.
5988 (lock_file_1): Rename local to avoid shadowing.
5990 * buffer.c (fix_overlays_before): Mark locals as initialized.
5991 (fix_start_end_in_overlays): Likewise. This function should be
5992 simplified by using pointers-to-pointers, but that's a different
5994 (switch_to_buffer_1): Now static.
5995 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5996 (report_overlay_modification): Rename locals to avoid shadowing.
5998 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5999 Fix pointer signedness issue.
6000 (sys_subshell): Mark local as volatile if checking for lint,
6001 to suppress a gcc -Wclobbered warning that does not seem to be right.
6002 (MAXPATHLEN): Define only if needed.
6004 * process.c (serial_open, serial_configure): Move decls from here ...
6005 * systty.h: ... to here, so that they can be checked.
6007 * fns.c (get_random, seed_random): Move extern decls from here ...
6008 * lisp.h: ... to here, so that they can be checked.
6010 * sysdep.c (reset_io): Now static.
6011 (wait_for_termination_signal): Remove; unused.
6013 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6014 (copy_keymap_item, append_key, push_text_char_description):
6016 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6017 (DENSE_TABLE_SIZE): Remove; unused.
6018 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6019 (describe_map_tree):
6020 Rename locals to avoid shadowing.
6022 * keyboard.c: Declare functions static if they are not used elsewhere.
6023 (echo_char, echo_dash, cmd_error, top_level_2):
6024 (poll_for_input, handle_async_input): Now static.
6025 (read_char, kbd_buffer_get_event, make_lispy_position):
6026 (make_lispy_event, make_lispy_movement, apply_modifiers):
6027 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6028 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6029 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6030 (read_key_sequence, read_char): Mark locals as initialized.
6031 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6033 * keyboard.h (make_ctrl_char): New decl.
6034 (mark_kboards): Move decl here ...
6035 * alloc.c (mark_kboards): ... from here.
6037 * lisp.h (force_auto_save_soon): New decl.
6039 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6040 (DEFINE_DUMMY_FUNCTION): New macro.
6041 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6043 (main): Add casts to avoid warnings
6044 if GCC considers string literals to be constants.
6046 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6048 * dbusbind.c: Pointer signedness fixes.
6049 (xd_signature, xd_append_arg, xd_initialize):
6050 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6051 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6052 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6053 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6055 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6056 if GCC considers string literals to be constants.
6057 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6059 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6061 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6062 (print_preprocess, print_object): New macro to fix last change.
6064 * print.c (print_preprocess): Don't forget font objects.
6066 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6068 * emacs.c (USAGE3): Doc fixes.
6070 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6072 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6075 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6077 * lisp.h (VWindow_system, Qfile_name_history):
6078 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6079 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6080 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6082 * w32select.c: Don't #include "keyboard.h".
6083 (run_protected): Add extern declaration for waiting_for_input.
6085 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6086 * w32console.c (detect_input_pending, read_input_pending)
6087 (encode_terminal_code):
6088 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6089 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6090 (w32_system_caret_y, Qfile_name_history):
6091 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6092 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6093 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6094 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6095 * w32proc.c (Qlocal, report_file_error):
6096 * w32term.c (Vwindow_system, updating_frame):
6097 * w32uniscribe.c (initialized, uniscribe_font_driver):
6098 Remove unneeded extern declarations.
6100 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6102 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6104 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6106 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6107 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6108 These macros can no longer be used for assignment.
6110 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6111 Assign struct members directly, instead of using BUF_BEGV etc.
6112 (record_buffer_markers, fetch_buffer_markers): New functions for
6113 recording and fetching special buffer markers.
6114 (set_buffer_internal_1, set_buffer_temp): Use them.
6116 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6118 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6120 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6121 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6123 * xdisp.c (hscroll_window_tree):
6124 (reconsider_clip_changes): Use PT instead of BUF_PT.
6126 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6128 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6129 $(EMACS_ROOT)/lib/intprops.h.
6131 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6133 Fix more problems found by GCC 4.5.2's static checks.
6135 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6136 to unsigned char * to avoid compiler diagnostic.
6137 (xg_free_frame_widgets): Make it clear that a local variable is
6138 needed only if USE_GTK_TOOLTIP.
6139 (gdk_window_get_screen): Make it clear that this macro is needed
6140 only if USE_GTK_TOOLTIP.
6141 (int_gtk_range_get_value): New function, which avoids a diagnostic
6142 from gcc -Wbad-function-cast.
6143 (xg_set_toolkit_scroll_bar_thumb): Use it.
6144 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6145 diagnostic from gcc -Wbad-function-cast.
6146 (get_utf8_string, xg_get_file_with_chooser):
6147 Rename locals to avoid shadowing.
6148 (create_dialog): Move locals to avoid shadowing.
6150 * xgselect.c (xg_select): Remove unused var.
6152 * image.c (four_corners_best): Mark locals as initialized.
6153 (gif_load): Initialize transparent_p to zero (Bug#8238).
6154 Mark another local as initialized.
6155 (my_png_error, my_error_exit): Mark with NO_RETURN.
6157 * image.c (clear_image_cache): Now static.
6158 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6159 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6160 (x_edge_detection): Remove unnecessary cast that
6161 gcc -Wbad-function-cast diagnoses.
6162 (gif_load): Fix pointer signedness.
6163 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6164 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6166 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6168 Improve quality of tests for time stamp overflow.
6169 For example, without this patch (encode-time 0 0 0 1 1
6170 1152921504606846976) returns the obviously-bogus value (-948597
6171 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6172 reports time overflow. See
6173 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6174 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6175 * editfns.c: Include limits.h and intprops.h.
6176 (TIME_T_MIN, TIME_T_MAX): New macros.
6177 (time_overflow): Move earlier, to before first use.
6178 (hi_time, lo_time): New functions, for an accurate test for
6180 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6181 (Fget_internal_run_time): Don't assume time_t fits in int.
6182 (make_time): Use list2 instead of Fcons twice.
6183 (Fdecode_time): More accurate test for out-of-range times.
6184 (check_tm_member): New function.
6185 (Fencode_time): Use it, to test for out-of-range times.
6186 (lisp_time_argument): Don't rely on undefined left-shift and
6187 right-shift behavior when checking for time stamp overflow.
6189 * editfns.c (time_overflow): New function, refactoring common code.
6190 (Fformat_time_string, Fdecode_time, Fencode_time):
6191 (Fcurrent_time_string): Use it.
6193 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6194 * dired.c (make_time): Move to ...
6195 * editfns.c (make_time): ... here.
6196 * systime.h: Note the move.
6198 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6200 * fringe.c (update_window_fringes): Remove unused variables.
6202 * unexmacosx.c (copy_data_segment): Also copy __got section.
6205 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6207 * termcap.c [MSDOS]: Include "msdos.h".
6208 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6209 Constify `char *' arguments and their references according to
6210 prototypes in tparam.h.
6212 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6214 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6215 Adapt all references accordingly.
6217 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6219 2011-03-11 Tom Tromey <tromey@redhat.com>
6221 * buffer.c (syms_of_buffer): Remove obsolete comment.
6223 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6225 * termhooks.h (encode_terminal_code): Declare prototype.
6227 * msdos.c (encode_terminal_code): Don't declare prototype.
6229 * term.c (encode_terminal_code): Now external again, used by
6230 w32console.c and msdos.c.
6232 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6233 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6235 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6237 Fix some minor problems found by GCC 4.5.2's static checks.
6239 * fringe.c (update_window_fringes): Mark locals as initialized
6241 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6243 * alloc.c (mark_fringe_data): Move decl from here ...
6244 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6245 to check its interface.
6246 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6248 * fontset.c (free_realized_fontset): Now static.
6249 (Fset_fontset_font): Rename local to avoid shadowing.
6250 (fontset_font): Mark local as initialized.
6251 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6253 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6255 * xselect.c (x_disown_buffer_selections): Remove; not used.
6256 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6257 (x_own_selection, Fx_disown_selection_internal): Rename locals
6259 (x_handle_dnd_message): Remove local to avoid shadowing.
6261 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6262 so that the caller can use some name other than gcpro1.
6263 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6264 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6265 (Fx_backspace_delete_keys_p):
6266 Use them to avoid shadowing, and rename vars to avoid shadowing.
6267 (x_decode_color, x_set_name, x_window): Now static.
6268 (Fx_create_frame): Add braces to silence GCC warning.
6269 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6270 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6271 Remove unused locals.
6272 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6273 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6274 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6277 * xterm.h (x_mouse_leave): New decl.
6279 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6280 Remove unused functions.
6281 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6282 (x_calc_absolute_position): Now static.
6283 (XTread_socket): Don't define label "out" unless it's used.
6284 Don't declare local "event" unless it's used.
6285 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6286 unless they are used.
6287 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6288 (x_fatal_error_signal): Remove; not used.
6289 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6290 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6291 (x_error_catcher, x_connection_closed, x_error_handler):
6292 (x_error_quitter, xembed_send_message, x_iconify_frame):
6293 (my_log_handler): Rename locals to avoid shadowing.
6294 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6295 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6297 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6298 Rename or move locals to avoid shadowing.
6299 (tty_defined_color, merge_face_heights): Now static.
6300 (free_realized_faces_for_fontset): Remove; not used.
6301 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6302 does not deduce is never used uninitialized.
6303 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6304 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6306 * terminal.c (store_terminal_param): Now static.
6308 * xmenu.c (menu_highlight_callback): Now static.
6309 (set_frame_menubar): Remove unused local.
6310 (xmenu_show): Rename parameter to avoid shadowing.
6311 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6312 since they might point to immutable storage.
6313 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6314 since it's unused otherwise.
6316 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6317 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6318 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6319 avoids a gcc -Wuninitialized diagnostic.
6320 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6321 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6322 does not deduce are never used uninitialized.
6324 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6326 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6327 * window.c (window_loop, size_window):
6328 (run_window_configuration_change_hook, enlarge_window): Likewise.
6330 * window.c (display_buffer): Now static.
6331 (size_window): Mark variables that gcc -Wuninitialized
6332 does not deduce are never used uninitialized.
6333 * window.h (check_all_windows): New decl, to forestall
6334 gcc -Wmissing-prototypes diagnostic.
6335 * dispextern.h (bidi_dump_cached_states): Likewise.
6337 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6339 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6341 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6342 and to avoid gcc -Wuninitialized warning.
6343 (load_charset_map): Mark variables that gcc -Wuninitialized
6344 does not deduce are never used uninitialized.
6345 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6347 * coding.c (coding_set_source, coding_set_destination):
6348 Use "else { /* comment */ }" rather than "else /* comment */;"
6349 for clarity, and to avoid gcc -Wempty-body warning.
6350 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6351 a block, when the outer 'i' will do.
6352 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6353 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6354 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6355 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6356 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6357 Rename locals to avoid shadowing.
6358 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6359 * coding.c (emacs_mule_char, encode_invocation_designation):
6360 Now static, since they're not used elsewhere.
6361 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6362 (decode_coding_object, encode_coding_object, detect_coding_system):
6363 (decode_coding_emacs_mule): Mark variables that gcc
6364 -Wuninitialized does not deduce are never used uninitialized.
6365 (detect_coding_iso_2022): Initialize a local variable that might
6366 be used uninitialized. Leave a FIXME because it's not clear that
6367 this initialization is needed. (Bug#8211)
6368 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6369 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6370 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6371 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6372 Remove unused macros.
6374 * category.c (hash_get_category_set): Remove unused local var.
6375 (copy_category_table): Now static, since it's not used elsewhere.
6376 * character.c (string_count_byte8): Likewise.
6378 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6379 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6381 * chartab.c (copy_sub_char_table): Now static, since it's not used
6383 (sub_char_table_ref_and_range, char_table_ref_and_range):
6384 Rename locals to avoid shadowing.
6385 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6387 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6388 (BIDI_BOB): Remove unused macro.
6390 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6391 deduce are never used uninitialized.
6392 * term.c (encode_terminal_code): Likewise.
6394 * term.c (encode_terminal_code): Now static. Remove unused local.
6396 * tparam.h: New file.
6397 * term.c, tparam.h: Include it.
6398 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6399 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6400 Move these decls to tparam.h, and make them agree with what
6401 is actually in tparam.c. The previous trick of using incompatible
6402 decls in different modules does not conform to the C standard.
6403 All callers of tparam changed to use tparam's actual API.
6404 * tparam.c (tparam1, tparam, tgoto):
6405 Use const pointers where appropriate.
6407 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6408 * cm.h (struct cm): Likewise.
6409 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6410 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6411 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6412 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6413 (turn_on_face, init_tty): Likewise.
6414 * termchar.h (struct tty_display_info): Likewise.
6416 * term.c (term_mouse_position): Rename local to avoid shadowing.
6418 * alloc.c (mark_ttys): Move decl from here ...
6419 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6421 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6423 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6425 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6427 * search.c (compile_pattern_1): Remove argument regp, unused since
6428 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6429 (compile_pattern): Don't pass it.
6431 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6433 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6434 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6436 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6438 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6440 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6441 gdk_window_get_screen, gdk_window_get_geometry,
6442 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6443 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6444 (xg_get_pixbuf_from_pixmap): New function.
6445 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6446 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6447 Call xg_get_pixbuf_from_pixmap instead of
6448 gdk_pixbuf_get_from_drawable.
6449 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6450 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6451 (xg_check_special_colors): Use GtkStyleContext and its functions
6453 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6454 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6455 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6456 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6457 Call gtk_widget_get_preferred_size.
6458 (xg_frame_resized): gdk_window_get_geometry only takes 5
6460 (xg_win_to_widget, xg_event_is_for_menubar):
6461 Call gdk_x11_window_lookup_for_display.
6462 (xg_set_widget_bg): New function.
6463 (delete_cb): New function.
6464 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6465 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6466 (xg_set_background_color): Call xg_set_widget_bg.
6467 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6468 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6469 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6470 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6472 (update_frame_tool_bar): Call gtk_widget_hide.
6473 (xg_initialize): Use GDK_KEY_g.
6475 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6477 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6479 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6480 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6481 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6483 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6485 * w32xfns.c (select_palette): Check success of RealizePalette against
6486 GDI_ERROR, not zero.
6488 See ChangeLog.11 for earlier changes.
6494 Copyright (C) 2011 Free Software Foundation, Inc.
6496 This file is part of GNU Emacs.
6498 GNU Emacs is free software: you can redistribute it and/or modify
6499 it under the terms of the GNU General Public License as published by
6500 the Free Software Foundation, either version 3 of the License, or
6501 (at your option) any later version.
6503 GNU Emacs is distributed in the hope that it will be useful,
6504 but WITHOUT ANY WARRANTY; without even the implied warranty of
6505 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6506 GNU General Public License for more details.
6508 You should have received a copy of the GNU General Public License
6509 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.