1 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3 * nsterm.h (ns_run_ascript): Declare.
4 (NSAPP_DATA2_RUNASSCRIPT): Define.
6 * nsfns.m (as_script, as_result, as_status): New static variables.
7 (ns_run_ascript): New function.
8 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
9 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
10 the event loop. Get status from as_status (Bug#7276).
12 * nsterm.m (sendEvent): If event is NSApplicationDefined and
13 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
14 the event loop (Bug#7276).
16 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
18 * gnutls.c (QCgnutls_bootprop_priority)
19 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
20 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
21 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
22 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
23 (QCgnutls_bootprop_verify_hostname_error)
24 (QCgnutls_bootprop_callbacks_verify): Rename from
25 Qgnutls_bootprop_..., all uses changed.
27 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
30 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
32 * xfaces.c (Qframe_set_background_mode): Now static.
33 * dispextern.h (Qframe_set_background_mode): Remove decl.
35 * process.c (Fnetwork_interface_info): Declare local only if needed.
37 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
39 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
40 (Fnetwork_interface_list): Allocate in increments of bytes instead
41 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
42 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
44 (struct ifflag_def): notrailers is smart on OSX.
45 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
46 Get hardware address with getifaddrs if available.
48 2011-08-12 Eli Zaretskii <eliz@gnu.org>
50 * xdisp.c (iterate_out_of_display_property): xassert that
51 IT->position is set to within IT->object's boundaries. Break from
52 the loop as soon as EOB is reached; avoids infloops in redisplay
53 when IT->position is set up wrongly due to some bug. Set
54 IT->current to match the bidi iterator unconditionally.
55 (push_display_prop): Allow GET_FROM_STRING as IT->method on
56 entry. Force push_it to save on the stack the current
57 buffer/string position, to be restored by pop_it. Fix flags in
58 the iterator structure wrt the object coming from a display
59 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
60 properties. (Bug#9284)
62 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
64 * fontset.c (fontset_get_font_group): Add proper type checks.
67 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
69 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
70 and LC_VERSION_MIN_MACOSX.
71 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
72 (dump_it) [LC_FUNCTION_STARTS]: Use it.
74 2011-08-08 Eli Zaretskii <eliz@gnu.org>
76 * xdisp.c (forward_to_next_line_start): Allow to use the
77 no-display-properties-and-no-overlays under bidi display. Set
78 disp_pos in the bidi iterator to avoid searches for display
79 properties and overlays.
81 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
83 * editfns.c (Fset_time_zone_rule): Document relationship with the
86 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
87 the font entity extracted from the cache (Bug#8109).
89 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
91 * composite.c (autocmp_chars): Don't reset point. That is done by
92 restore_point_unwind (Bug#5984).
94 2011-08-07 Juri Linkov <juri@jurta.org>
96 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
97 to show the arg `TIME' instead of `TIMEVAL'.
99 2011-08-06 Eli Zaretskii <eliz@gnu.org>
101 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
102 display property strides EOL and includes a newline, as in
103 longlines-mode. (Bug#9254)
104 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
105 word-wrap under bidirectional display. (Bug#9224)
107 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
108 is non-zero, even if the data buffer is NULL. Fixes a crash in
109 vertical-motion with longlines-mode. (Bug#9254)
111 2011-08-05 Eli Zaretskii <eliz@gnu.org>
113 * bidi.c <bidi_cache_total_alloc>: Now static.
114 (bidi_initialize): Initialize bidi_cache_total_alloc.
116 *xdisp.c (display_line): Release buffer allocated for shelved bidi
119 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
120 amount allocated this far in `bidi_cache_total_alloc'.
121 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
122 non-zero, only free the data buffer without restoring the cache
123 contents. All callers changed.
125 * dispextern.h (bidi_unshelve_cache): Update prototype.
127 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
128 (move_it_in_display_line, move_it_to)
129 (move_it_vertically_backward, move_it_by_lines): Replace the call
130 to xfree to an equivalent call to bidi_unshelve_cache.
131 (move_it_in_display_line_to): Fix logic of returning
132 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
134 2011-08-05 Eli Zaretskii <eliz@gnu.org>
136 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
137 came from a string character with a `cursor' property. (Bug#9229)
139 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
141 * Makefile.in (LIB_PTHREAD): New variable.
142 (LIBES): Add LIB_PTHREAD (Bug#9216).
144 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
145 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
147 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
149 * regex.c (re_iswctype): Remove some redundant boolean
152 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
154 * xterm.c (x_find_topmost_parent): New function.
155 (x_set_frame_alpha): Find topmost parent window with
156 x_find_topmost_parent and set the property there also (bug#9181).
157 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
159 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
161 * callproc.c (Fcall_process): Avoid vfork clobbering
162 the local vars buffer, coding_systems, current_dir.
164 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
166 * keymap.c (Fmake_composed_keymap): Move to subr.el.
168 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
170 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
171 so that it is not optimized away.
173 * xdisp.c (compute_display_string_pos): Remove unused local.
175 2011-08-02 Eli Zaretskii <eliz@gnu.org>
177 Fix slow cursor motion and scrolling in large buffers with
178 selective display, like Org Mode buffers. (Bug#9218)
180 * dispextern.h (struct bidi_it): New member disp_prop_p.
182 * xdisp.c: Remove one-slot cache of display string positions.
183 (compute_display_string_pos): Accept an additional argument
184 DISP_PROP_P; callers changed. Scan at most 5K characters forward
185 for a display string or property. If found, set DISP_PROP_P
188 * bidi.c (bidi_fetch_char): Accept an additional argument
189 DISP_PROP_P, and pass it to compute_display_string_pos.
190 Only handle text covered by a display string if DISP_PROP_P is returned
191 non-zero. All callers of bidi_fetch_char changed.
193 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
195 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
197 2010-12-03 Don March <don@ohspite.net>
199 * keymap.c (Fdefine_key): Fix non-prefix key error message when
200 last character M-[char] is translated to ESC [char] (bug#7541).
202 2011-08-02 Kenichi Handa <handa@m17n.org>
204 * lisp.h (uniprop_table): Extern it.
206 * chartab.c (uniprop_table): Make it non-static.
208 2011-08-01 Eli Zaretskii <eliz@gnu.org>
210 * xdisp.c (forward_to_next_line_start): Accept additional argument
211 BIDI_IT_PREV, and store into it the state of the bidi iterator had
213 (reseat_at_next_visible_line_start): Use the bidi iterator state
214 returned by forward_to_next_line_start to restore the state of
215 it->bidi_it after backing up to previous newline. (Bug#9212)
217 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
219 * regex.c (re_comp): Protoize.
220 (re_exec): Fix return type.
221 (regexec): Fix type of `ret'. (Bug#9203)
223 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
225 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
226 This is needed if max-image-size is a floating-point number.
228 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
230 * print.c (print_object): Print empty symbol as ##.
232 * lread.c (read1): Read ## as empty symbol.
234 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
236 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
237 setting frame foreground color (Bug#9175).
238 (x_set_background_color): Likewise.
240 * nsmenu.m (-setText): Size tooltip dimensions precisely to
242 (EmacsTooltip -init): Remove bezels and add shadows to
245 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
246 or scroll bar (Bug#8470).
248 * nsfont.m (nsfont_open): Remove assignment to voffset and
249 unnecessary vars hshink, expand, hd, full_height, min_height.
250 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
252 * nsterm.h (nsfont_info): Remove voffset field.
254 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
256 Implement strike-through and overline on NextStep (Bug#8863).
258 * nsfont.m (nsfont_open): Use underline position provided by font,
259 instead of hard-coded value of 2.
260 (nsfont_draw): Call ns_draw_text_decoration instead.
262 * nsterm.h: Add declaration for ns_draw_text_decoration.
264 * nsterm.m (ns_draw_text_decoration): New function for drawing
265 underline, overline, and strike-through.
266 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
267 ns_draw_text_decoration. Change treatment of cursor drawing to
268 accomodate underlining, etc.
270 2011-07-28 Eli Zaretskii <eliz@gnu.org>
272 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
275 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
277 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
278 Without this fix, if a signal arrives just after memory fills up,
279 'malloc' might be invoked reentrantly.
281 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
282 In other words, assume that every image size is allowed, on non-X
283 hosts. This assumption is probably wrong, but it lets Emacs compile.
285 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
287 * regex.c (re_iswctype): Convert return values to boolean.
289 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
291 * xdisp.c (compute_display_string_pos): Don't use cached display
292 string position if the buffer had its restriction changed.
295 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
297 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
299 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
301 Integer signedness and overflow and related fixes. (Bug#9079)
303 * bidi.c: Integer size and overflow fixes.
304 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
305 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
306 (bidi_cache_find_level_change, bidi_cache_ensure_space)
307 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
308 (bidi_find_other_level_edge):
309 Use ptrdiff_t instead of EMACS_INT where either will do.
310 This works better on 32-bit hosts configured --with-wide-int.
311 (bidi_cache_ensure_space): Check for size-calculation overflow.
312 Use % rather than repeated addition, for better worst-case speed.
313 Don't set bidi_cache_size until after xrealloc returns, because it
315 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
316 (bidi_cache_ensure_space): Also check that the bidi cache size
317 does not exceed that of the largest Lisp string or buffer. See Eli
318 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
320 * alloc.c (__malloc_size_t): Remove.
321 All uses replaced by size_t. See Andreas Schwab's note
322 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
324 * image.c: Improve checking for integer overflow.
325 (check_image_size): Assume that f is nonnull, since
326 it is always nonnull in practice. This is one less thing to
327 worry about when checking for integer overflow later.
328 (x_check_image_size): New function, which checks for integer
329 overflow issues inside X.
330 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
331 This removes the need for a memory_full check.
332 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
333 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
334 (xbm_read_bitmap_data): Change locals back to 'int', since
335 their values must fit in 'int'.
336 (xpm_load_image, png_load, tiff_load):
337 Invoke x_create_x_image_and_pixmap earlier,
338 to avoid much needless work if the image is too large.
339 (tiff_load): Treat overly large images as if
340 x_create_x_image_and_pixmap failed, not as malloc failures.
341 (gs_load): Use x_check_image_size.
343 * gtkutil.c: Omit integer casts.
344 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
345 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
347 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
349 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
350 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
351 would wrongly return t on a 64-bit host.
353 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
354 The plain *_OVERFLOW macros run afoul of GCC bug 49705
355 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
356 and therefore cause GCC to emit a bogus diagnostic in some cases.
358 * image.c: Integer signedness and overflow and related fixes.
359 This is not an exhaustive set of fixes, but it's time to
360 record what I've got.
361 (lookup_pixel_color, check_image_size): Remove redundant decls.
362 (check_image_size): Don't assume that arbitrary EMACS_INT values
363 fit in 'int', or that arbitrary 'double' values fit in 'int'.
364 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
365 (tiff_load, imagemagick_load_image):
366 Check for overflow in size calculations.
367 (x_create_x_image_and_pixmap): Remove unnecessary test for
368 xmalloc returning NULL; that can't happen.
369 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
370 (xpm_color_bucket): Use better integer hashing function.
371 (xpm_cache_color): Don't possibly over-allocate memory.
372 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
374 Use ptrdiff_t, not int or size_t, to record sizes.
375 (png_load): Don't assume values greater than 2**31 fit in 'int'.
376 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
377 either works, as we prefer signed integers.
378 (tiff_read_from_memory, tiff_write_from_memory):
379 Return tsize_t, not size_t, since that's what the TIFF API wants.
380 (tiff_read_from_memory): Don't fail simply because the read would
381 go past EOF; instead, return a short read.
382 (tiff_load): Omit no-longer-needed casts.
383 (Fimagemagick_types): Don't assume size fits into 'int'.
385 Improve hashing quality when configured --with-wide-int.
386 * fns.c (hash_string): New function, taken from sxhash_string.
387 Do not discard information about ASCII character case; this
388 discarding is no longer needed.
389 (sxhash-string): Use it. Change sig to match it. Caller changed.
390 * lisp.h: Declare it.
391 * lread.c (hash_string): Remove, since we now use fns.c's version.
392 The fns.c version returns a wider integer if --with-wide-int is
393 specified, so this should help the quality of the hashing a bit.
395 * emacs.c: Integer overflow minor fix.
396 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
397 Define only if GNU_LINUX.
398 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
400 * dispnew.c: Integer signedness and overflow fixes.
401 Remove unnecessary forward decls, that were a maintenance hassle.
402 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
404 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
405 (scrolling_window): Use ptrdiff_t, not int, for byte count.
406 (prepare_desired_row, line_draw_cost):
407 Use int, not unsigned, where either works.
408 (save_current_matrix, restore_current_matrix):
409 Use ptrdiff_t, not size_t, where either works.
410 (init_display): Check for overflow more accurately, and without
411 relying on undefined behavior.
413 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
414 Remove, replacing with the new symbols in lisp.h. All uses changed.
415 * fileio.c (make_temp_name):
416 * filelock.c (lock_file_1, lock_file):
417 * xdisp.c (message_dolog):
418 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
419 Use pMd etc. instead.
420 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
421 replacing the pWIDE etc. symbols removed from editfns.c.
423 * keyboard.h (num_input_events): Now uintmax_t.
424 This is (very slightly) less likely to mess up due to wraparound.
427 * buffer.c: Integer signedness fixes.
428 (alloc_buffer_text, enlarge_buffer_text):
429 Use ptrdiff_t rather than size_t when either will do, as we prefer
432 * alloc.c: Integer signedness and overflow fixes.
433 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
434 (__malloc_size_t): Default to size_t, not to int.
435 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
436 (Fgarbage_collect, mark_object_loop_halt, mark_object):
437 Prefer ptrdiff_t to size_t when either would do, as we prefer
439 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
440 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
441 Now const. Initialize with values that are in range even if char
443 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
444 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
445 These functions do the right thing with sizes > 2**32.
446 (check_depth): Now ptrdiff_t, not int.
447 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
448 Adjust to new way of storing sizes. Check for size overflow bugs
450 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
451 slightly wrong anyway, as it missed one instance of
452 XMALLOC_OVERRUN_CHECK_OVERHEAD.
453 (refill_memory_reserve): Omit needless cast to size_t.
454 (mark_object_loop_halt): Mark as externally visible.
456 * xselect.c: Integer signedness and overflow fixes.
457 (Fx_register_dnd_atom, x_handle_dnd_message):
458 Use ptrdiff_t, not size_t, since we prefer signed.
459 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
460 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
461 x_dnd_atoms_size and x_dnd_atoms_length.
463 * doprnt.c: Prefer signed to unsigned when either works.
467 * xdisp.c (vmessage):
468 Use ptrdiff_t, not size_t, when using or implementing doprnt,
469 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
470 prefer signed arithmetic to avoid comparison confusion.
471 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
474 Assume freestanding C89 headers, string.h, stdlib.h.
475 * data.c, doprnt.c, floatfns.c, print.c:
476 Include float.h unconditionally.
477 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
478 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
479 * regex.c: Likewise for stddef.h, string.h.
480 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
481 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
482 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
483 (STDC_HEADERS): Remove obsolete defines.
484 * sysdep.c: Include limits.h unconditionally.
486 Assume support for memcmp, memcpy, memmove, memset.
487 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
488 * regex.c (memcmp, memcpy):
489 Remove; we assume C89 now.
491 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
492 (__malloc_safe_bcopy): Remove; no longer needed.
494 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
495 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
496 well either way, and we prefer signed to unsigned.
498 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
500 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
501 closes the connection while we're reading (bug#9182).
503 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
505 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
506 are specified (Bug#9168).
508 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
510 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
511 Found by GCC static checking and --with-wide-int on a 32-bit host.
513 2011-07-25 Eli Zaretskii <eliz@gnu.org>
515 * xdisp.c (compute_display_string_pos): Fix logic of caching
516 previous display string position. Initialize cached_prev_pos to
517 -1. Fixes slow-down at the beginning of a buffer.
519 2011-07-24 Eli Zaretskii <eliz@gnu.org>
521 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
522 for attrs[LFACE_FONTSET_INDEX].
524 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
526 * xml.c (parse_region): Remove unused local
527 that was recently introduced.
529 2011-07-23 Eli Zaretskii <eliz@gnu.org>
531 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
532 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
534 * xdisp.c (move_it_in_display_line_to): Record the best matching
535 position for TO_CHARPOS while scanning the line, and restore it on
536 exit if none of the characters scanned was an exact match.
537 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
538 when exact match is impossible due to invisible text, and the
541 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
543 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
546 2011-07-22 Eli Zaretskii <eliz@gnu.org>
548 Fix a significant slow-down of cursor motion with C-n, C-p,
549 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
550 auto-repeat under bidi redisplay in fontified buffers.
551 * xdisp.c (compute_stop_pos_backwards): New function.
552 (next_element_from_buffer): Call compute_stop_pos_backwards to
553 find a suitable prev_stop when we find ourselves before
555 (reseat): Don't look for prev_stop, as that could mean a very long
557 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
558 <cached_disp_overlay_modiff>: Cache for last found display string
560 (compute_display_string_pos): Return the cached position if asked
561 about the same buffer in the same area of character positions, and
562 the buffer wasn't changed since the time the display string
565 2011-07-22 Eli Zaretskii <eliz@gnu.org>
567 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
568 is an integer, which is important for empty lines. (Bug#9149)
570 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
572 * frame.c (Fmodify_frame_parameters): In tty case, update the
573 default face if necessary (Bug#4238).
575 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
577 * editfns.c (Fstring_to_char): No need to explain what a character
578 is in the docstring (Bug#6576).
580 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
582 * xml.c (parse_region): Make sure we always return a tree.
584 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
586 * xml.c (parse_region): If a document contains only comments,
589 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
591 * xml.c (make_dom): Return comments, too.
593 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
596 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
597 and the surrounding thread.
598 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
599 rather than fgets, and retry after EINTR. Otherwise, 'emacs
600 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
602 * s/openbsd.h (BROKEN_SIGIO): Define.
603 * unexelf.c (unexec) [__OpenBSD__]:
604 Don't update the .mdebug section of the Alpha COFF symbol table.
606 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
608 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
611 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
613 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
614 This fixes some race conditions on the permissions of any newly
617 * alloc.c (valid_pointer_p): Use pipe, not open.
618 This fixes some permissions issues when debugging.
620 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
621 If fchown fails to set both uid and gid, try to set just gid,
622 as that is sometimes allowed. Adjust the file's mode to eliminate
623 setuid or setgid bits that are inappropriate if fchown fails.
625 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
627 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
628 to compare Lisp_Objects.
629 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
630 global_gnutls_log_level, don't mistake it for a Lisp_Object.
631 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
633 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
635 * lread.c (read_integer): Unread even EOF character.
636 (read1): Likewise. Properly record start position of symbol.
638 * lread.c (read1): Read `#:' as empty uninterned symbol if no
639 symbol character follows.
641 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
643 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
644 This works around a problem with the previous change to Fcopy_file.
645 Recent glibc declares fchown with __attribute__((warn_unused_result)),
646 and without this change, GCC might complain about discarding
647 fchown's return value.
649 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
651 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
653 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
655 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
657 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
659 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
660 it's used from the C level.
662 * process.c: Use the same condition for POLL_FOR_INPUT in both
663 keyboard.c and process.c (bug#1858).
665 2011-07-09 Lawrence Mitchell <wence@gmx.li>
667 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
668 (Fgnutls_boot): Use it.
670 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
672 * doc.c (Fsubstitute_command_keys): Revert last change.
674 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
676 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
677 quotes the next character, and doesn't affect other longer
678 sequences (bug#8935).
680 * lread.c (syms_of_lread): Clarify that is isn't only
681 `eval-buffer' and `eval-defun' that's affected by
682 `lexical-binding' (bug#8460).
684 2011-07-15 Eli Zaretskii <eliz@gnu.org>
686 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
687 bidi redisplay when a line includes both an image and is
690 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
692 Fix minor problems found by static checking.
693 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
694 (elsz): Now a signed constant, not a size_t var. We prefer signed
695 types to unsigned, to avoid integer comparison confusion. Without
696 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
697 "cannot optimize loop, the loop counter may overflow", a symptom
699 * indent.c (Fvertical_motion): Mark locals as initialized.
700 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
702 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
704 * search.c (Fre_search_backward): Mention `case-fold-search' in
705 all the re_search_* functions (bug#8138).
707 * keyboard.c (Fopen_dribble_file): Document when the file is
710 2011-07-14 Eli Zaretskii <eliz@gnu.org>
712 * bidi.c (bidi_dump_cached_states): Fix format of displaying
715 Support bidi reordering of display and overlay strings.
716 * xdisp.c (compute_display_string_pos)
717 (compute_display_string_end): Accept additional argument STRING.
718 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
719 (reseat_to_string): Initialize bidi_it->string.s and
720 bidi_it->string.schars.
721 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
722 NULL (avoids a crash in bidi_paragraph_init).
723 Initialize itb.string.lstring.
724 (init_iterator): Call bidi_init_it only of a valid
725 buffer position was specified. Initialize paragraph_embedding to
727 (reseat_to_string): Initialize the bidi iterator.
728 (display_string): If we need to ignore text properties of
729 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
730 original value of -1 will not work with bidi.)
731 (compute_display_string_pos): First arg is now struct
732 `text_pos *'; all callers changed. Support display properties on
734 (compute_display_string_end): Support display properties on Lisp
736 (init_iterator, reseat_1, reseat_to_string): Initialize the
737 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
738 when iterating on a string not from display properties).
739 (compute_display_string_pos, compute_display_string_end):
740 Fix calculation of the object to scan. Fixes an error when using
742 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
743 base_level_stop; instead, set base_level_stop to BEGV.
744 Fixes crashes in vertical-motion.
745 (next_element_from_buffer): Improve commentary for when
746 the iterator is before prev_stop.
747 (init_iterator): Initialize bidi_p from the default value of
748 bidi-display-reordering, not from buffer-local value. Use the
749 buffer-local value only if initializing for buffer iteration.
750 (handle_invisible_prop): Support invisible properties on strings
751 that are being bidi-reordered.
752 (set_iterator_to_next): Support bidi reordering of C strings and
754 (next_element_from_string): Support bidi reordering of Lisp
756 (handle_stop_backwards): Support Lisp strings as well.
757 (display_string): Support display of R2L glyph rows.
758 Use IT_STRING_CHARPOS when displaying from a Lisp string.
759 (init_iterator): Don't initialize it->bidi_p for strings
761 (reseat_to_string): Initialize it->bidi_p for strings here.
762 (next_element_from_string, next_element_from_c_string)
763 (next_element_from_buffer): Add xassert's for correspondence
764 between IT's object being iterated and it->bidi_it.string
766 (face_before_or_after_it_pos): Support bidi iteration.
767 (next_element_from_c_string): Handle the case of the first string
768 character that is not the first one in the visual order.
769 (get_visually_first_element): New function, refactored from common
770 parts of next_element_from_buffer, next_element_from_string, and
771 next_element_from_c_string.
772 (tool_bar_lines_needed, redisplay_tool_bar)
773 (display_menu_bar): Force left-to-right direction. Add a FIXME
774 comment for making that be controlled by a user option.
775 (push_it, pop_it): Save and restore the state of the
776 bidi iterator. Save and restore the bidi_p flag.
777 (pop_it): Iterate out of display property for string iteration as
779 (iterate_out_of_display_property): Support iteration over strings.
780 (handle_single_display_spec): Set up it->bidi_it for iteration
781 over a display string, and call bidi_init_it.
782 (handle_single_display_spec, next_overlay_string)
783 (get_overlay_strings_1, push_display_prop): Set up the bidi
784 iterator for displaying display or overlay strings.
785 (forward_to_next_line_start): Don't use the shortcut if
787 (back_to_previous_visible_line_start): If handle_display_prop
788 pushed the iterator stack, restore the internal state of the bidi
789 iterator by calling bidi_pop_it same number of times.
790 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
791 and we are bidi-iterating, don't decrement the iterator position;
792 instead, set the first_elt flag in the bidi iterator, to produce
794 (reseat_1): Remove redundant setting of string_from_display_prop_p.
795 (push_display_prop): xassert that we are iterating a buffer.
796 (push_it, pop_it): Save and restore paragraph_embedding member.
797 (handle_single_display_spec, next_overlay_string)
798 (get_overlay_strings_1, reseat_1, reseat_to_string)
799 (push_display_prop): Set up the `unibyte' member of bidi_it.string
800 correctly. Don't assume unibyte strings are not bidi-reordered.
801 (compute_display_string_pos)
802 (compute_display_string_end): Fix handling the case of C string.
803 (push_it, pop_it): Save and restore from_disp_prop_p.
804 (handle_single_display_spec, push_display_prop): Set the
805 from_disp_prop_p flag.
806 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
807 (pop_it): Call iterate_out_of_display_property only if we are
808 popping after iteration over a string that came from a display
809 property. Fix a typo in popping stretch info. Add an assertion
810 for verifying that the iterator position is in sync with the bidi
812 (handle_single_display_spec, get_overlay_strings_1)
813 (push_display_prop): Fix initialization of paragraph direction for
814 string when that of the parent object is not yet determined.
815 (reseat_1): Call bidi_init_it to resync the bidi
816 iterator with IT's position. (Bug#7616)
817 (find_row_edges): If ROW->start.pos gives position
818 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
819 (handle_stop, back_to_previous_visible_line_start, reseat_1):
820 Reset the from_disp_prop_p flag.
821 (SAVE_IT, RESTORE_IT): New macros.
822 (pos_visible_p, face_before_or_after_it_pos)
823 (back_to_previous_visible_line_start)
824 (move_it_in_display_line_to, move_it_in_display_line)
825 (move_it_to, move_it_vertically_backward, move_it_by_lines)
826 (try_scrolling, redisplay_window, display_line): Use them when
827 saving a temporary copy of the iterator and restoring it back.
828 (back_to_previous_visible_line_start, reseat_1)
829 (init_iterator): Empty the bidi cache "stack".
830 (move_it_in_display_line_to): If iterator ended up at
831 EOL, but we never saw any buffer positions smaller than
832 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
833 motion in bidi-reordered lines.
834 (move_it_in_display_line_to): Record prev_method and prev_pos
835 immediately before the call to set_iterator_to_next. Fixes cursor
836 motion in bidi-reordered lines with stretch glyphs and strings
837 displayed in margins. (Bug#8133) (Bug#8867)
838 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
840 (pos_visible_p): Support positions in bidi-reordered lines.
841 Save and restore bidi cache.
843 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
844 (bidi_paragraph_info): Delete unused struct.
845 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
846 (bidi_cache_start): New variable.
847 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
849 (bidi_cache_fetch_state, bidi_cache_search)
850 (bidi_cache_find_level_change, bidi_cache_iterator_state)
851 (bidi_cache_find, bidi_peek_at_next_level)
852 (bidi_level_of_next_char, bidi_find_other_level_edge)
853 (bidi_move_to_visually_next): Compare cache index with
854 bidi_cache_start rather than with zero.
855 (bidi_fetch_char): Accept new argument STRING; all callers
856 changed. Support iteration over a string. Support strings with
857 display properties. Support unibyte strings. Fix the type of
858 `len' according to what STRING_CHAR_AND_LENGTH expects.
859 (bidi_paragraph_init, bidi_resolve_explicit_1)
860 (bidi_resolve_explicit, bidi_resolve_weak)
861 (bidi_level_of_next_char, bidi_move_to_visually_next):
862 Support iteration over a string.
863 (bidi_set_sor_type, bidi_resolve_explicit_1)
864 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
865 can now be zero (for strings); special values 0 and -1 were
866 changed to -1 and -2, respectively.
867 (bidi_char_at_pos): New function.
868 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
869 Call it instead of FETCH_MULTIBYTE_CHAR.
870 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
871 initialized to valid values.
872 (bidi_init_it): Don't initialize charpos and bytepos with invalid
874 (bidi_level_of_next_char): Allow the sentinel "position" to pass
875 the test for valid cached positions. Fix the logic for looking up
876 the sentinel state in the cache. GCPRO the Lisp string we are
878 (bidi_push_it, bidi_pop_it): New functions.
879 (bidi_initialize): Initialize the bidi cache start stack pointer.
880 (bidi_cache_ensure_space): New function, refactored from part of
881 bidi_cache_iterator_state. Don't assume the required size is just
882 one BIDI_CACHE_CHUNK away.
883 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
884 (bidi_count_bytes, bidi_char_at_pos): New functions.
885 (bidi_cache_search): Don't assume bidi_cache_last_idx is
886 always valid if bidi_cache_idx is valid.
887 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
888 is valid if it's going to be used.
889 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
890 (bidi_cache_fetch_state, bidi_cache_search)
891 (bidi_cache_find_level_change, bidi_cache_ensure_space)
892 (bidi_cache_iterator_state, bidi_cache_find)
893 (bidi_find_other_level_edge, bidi_cache_start_stack):
894 All variables related to cache indices are now EMACS_INT.
896 * dispextern.h (struct bidi_string_data): New structure.
897 (struct bidi_it): New member `string'. Make flag members be 1-bit
898 fields, and put them last in the struct.
899 (compute_display_string_pos, compute_display_string_end):
901 (bidi_push_it, bidi_pop_it): Add prototypes.
902 (struct iterator_stack_entry): New members bidi_p,
903 paragraph_embedding, and from_disp_prop_p.
904 (struct it): Member bidi_p is now a bit field 1 bit wide.
905 (bidi_shelve_cache, bidi_unshelve_cache):
908 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
909 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
910 and vector-like objects.
912 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
913 cache around display iteration.
915 * window.c (Fwindow_end, window_scroll_pixel_based)
916 (displayed_window_lines, Frecenter): Save and restore the bidi
917 cache around display iteration.
919 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
921 * editfns.c (Fdelete_region): Clarify the use of the named
922 parameters (bug#6788).
924 2011-07-14 Martin Rudalics <rudalics@gmx.at>
926 * indent.c (Fvertical_motion): Set and restore w->pointm when
927 saving and restoring the window's buffer (Bug#9006).
929 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
931 * editfns.c (Fstring_to_char): Clarify just what is returned
932 (bug#6576). Text by Eli Zaretskii.
934 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
936 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
938 2011-07-13 Eli Zaretskii <eliz@gnu.org>
940 * buffer.c (mmap_find): Fix a typo.
942 2011-07-13 Johan Bockgård <bojohan@gnu.org>
944 Fix execution of x selection hooks.
945 * xselect.c (Qx_lost_selection_functions)
946 (Qx_sent_selection_functions): New vars.
947 (syms_of_xselect): DEFSYM them.
948 (x_handle_selection_request): Pass Qx_sent_selection_functions
949 rather than Vx_sent_selection_functions to Frun_hook_with_args.
950 (x_handle_selection_clear,x_clear_frame_selections):
951 Pass Qx_lost_selection_functions rather than
952 Vx_lost_selection_functions to Frun_hook_with_args.
954 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
956 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
957 The old code sometimes used this field without initializing it.
959 * alloc.c (gc_sweep): Don't read past end of array.
960 In theory, the old code could also have corrupted Emacs internals,
961 though it'd be very unlikely.
963 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
965 * character.c (Fcharacterp): Don't advertise optional ignored
968 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
970 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
973 * window.c (Fset_window_start): Doc fix (bug#4199).
974 (Fset_window_hscroll): Ditto.
976 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
978 Fix minor new problems caught by GCC 4.6.1.
979 * term.c (init_tty): Remove unused local.
980 * xsettings.c (store_monospaced_changed): Define this function only
981 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
984 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
986 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
988 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
990 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
991 are the mini-buffer and the echo area (bug#3320).
993 * term.c (init_tty): Remove support for supdup, c10 and perq
994 terminals, which are no longer supported (bug#1482).
996 2011-07-10 Johan Bockgård <bojohan@gnu.org>
998 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1000 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1002 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1003 for non-popups (Bug#3642).
1005 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1007 * alloc.c (reset_malloc_hooks): Protoize.
1008 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1009 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1010 * cm.c (losecursor): Likewise.
1011 * data.c (fmod): Likewise.
1012 * dispnew.c (swap_glyphs_in_rows): Likewise.
1013 * emacs.c (memory_warning_signal): Likewise.
1014 * floatfns.c (float_error): Likewise.
1015 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1016 (otf_open, font_otf_capability, generate_otf_features)
1017 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1019 * image.c (pbm_read_file): Likewise.
1020 * indent.c (string_display_width): Likewise.
1021 * intervals.c (check_for_interval, search_for_interval)
1022 (inc_interval_count, count_intervals, root_interval)
1023 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1024 * lread.c (defalias): Likewise.
1025 * ralloc.c (r_alloc_check): Likewise.
1026 * regex.c (set_image_of_range_1, set_image_of_range)
1027 (regex_grow_registers): Likewise.
1028 * sysdep.c (strerror): Likewise.
1029 * termcap.c (valid_filename_p, tprint, main): Likewise.
1030 * tparam.c (main): Likewise.
1031 * unexhp9k800.c (run_time_remap, save_data_space)
1032 (update_file_ptrs, read_header, write_header, calculate_checksum)
1033 (copy_file, copy_rest, display_header): Likewise.
1034 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1036 * xdisp.c (check_it): Likewise.
1037 * xfaces.c (register_color, unregister_color, unregister_colors):
1039 * xfns.c (print_fontset_result): Likewise.
1040 * xrdb.c (member, fatal, main): Likewise.
1042 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1044 Fix minor problems found by static checking (Bug#9031).
1045 * chartab.c (char_table_set_range, map_sub_char_table):
1046 Remove unused locals.
1047 (uniprop_table): Now static.
1048 * composite.c (_work_char): Remove unused static var.
1050 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1052 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1054 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1056 * gtkutil.c (qttip_cb): Remove code without function.
1058 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1060 * w32.c (pthread_sigmask): New stub.
1062 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1064 Use pthread_sigmask, not sigprocmask (Bug#9010).
1065 sigprocmask is portable only for single-threaded applications, and
1066 Emacs can be multi-threaded when it uses GTK.
1067 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1069 * callproc.c (Fcall_process):
1070 * process.c (create_process):
1071 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1072 Use pthread_sigmask, not sigprocmask.
1074 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1076 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1077 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1080 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1082 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1083 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1084 (xg_hide_tooltip): Fix comment.
1086 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1087 in registerServicesMenuSendTypes.
1088 (validRequestorForSendType): Don't check ns_return_types.
1090 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1093 2011-07-08 Jason Rumney <jasonr@gnu.org>
1095 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1096 frame struct members of non-existent frames (Bug#6284).
1098 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1100 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1101 variable firstTime not needed on OSX >= 10.6.
1102 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1103 >= 10.5. Use setKnobProportion, setDoubleValue.
1105 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1106 (MAC_OS_X_VERSION_10_5): Define if not defined.
1107 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1108 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1109 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1111 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1112 cString and lossyCString on OSX >= 10.4
1114 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1115 sizeToFit on OSX >= 10.2.
1117 * nsimage.m (allocInitFromFile): Don't use deprecated method
1118 bestRepresentationForDevice on OSX >= 10.6.
1120 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1123 * emacs.c: Declare unexec_init_emacs_zone.
1125 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1127 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1129 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1130 on svcsMenu (Bug#8842).
1132 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1134 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1136 * nsterm.m (QUTF8_STRING): Declare.
1137 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1138 (validRequestorForSendType): Return type is (id).
1139 Change indexOfObjectIdenticalTo to indexOfObject.
1140 Check if we have local selection before returning self (Bug#8842).
1141 (writeSelectionToPasteboard): Put local selection into paste board
1142 if we have a local selection (Bug#8842).
1143 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1145 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1146 (ns_get_local_selection): Declare.
1148 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1150 * keymap.c (describe_map_tree): Don't insert a double newline at
1151 the end of the buffer (bug#1169) and return whether we inserted
1154 * callint.c (Fcall_interactively): Change "reading args" to
1155 "providing args" to try to clarify what it does (bug#1010).
1157 2011-07-07 Kenichi Handa <handa@m17n.org>
1159 * composite.c (composition_compute_stop_pos): Ignore a static
1160 composition starting before CHARPOS (Bug#8915).
1162 * xdisp.c (handle_composition_prop): Likewise.
1164 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1166 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1169 2011-07-07 Kenichi Handa <handa@m17n.org>
1171 * character.h (unicode_category_t): New enum type.
1173 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1174 (Qchar_code_property_table): New variable.
1175 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1176 (UNIPROP_COMPRESSED_FORM_P): New macros.
1177 (char_table_ascii): Uncompress the compressed values.
1178 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1179 Uncompress the compressed values.
1180 (sub_char_table_ref_and_range): Likewise.
1181 (char_table_ref_and_range): Uncompress the compressed values.
1182 (sub_char_table_set): New arg is_uniprop. Callers changed.
1183 Uncompress the compressed values.
1184 (sub_char_table_set_range): Args changed. Callers changed.
1185 (char_table_set_range): Adjuted for the above change.
1186 (map_sub_char_table): Delete args default_val and parent. Add arg
1187 top. Give decoded values to a Lisp function.
1188 (map_char_table): Adjust for the above change. Give decoded
1189 values to a Lisp function. Gcpro more variables.
1190 (uniprop_table_uncompress)
1191 (uniprop_decode_value_run_length): New functions.
1192 (uniprop_decoder, uniprop_decoder_count): New variables.
1193 (uniprop_get_decoder, uniprop_encode_value_character)
1194 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1196 (uniprop_encoder, uniprop_encoder_count): New variables.
1197 (uniprop_get_encoder, uniprop_table)
1198 (Funicode_property_table_internal, Fget_unicode_property_internal)
1199 (Fput_unicode_property_internal): New functions.
1200 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1201 Sunicode_property_table_internal, Sget_unicode_property_internal,
1202 and Sput_unicode_property_internal. Defvar_lisp
1203 char-code-property-alist.
1205 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1206 Vunicode_category_table.
1208 * font.c (font_range): Adjust for the change of
1209 Vunicode_category_table.
1211 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1213 * m/iris4d.h: Remove file, move contents ...
1214 * s/irix6-5.h: ... here.
1216 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1218 Remove unportable assumption about struct layout (Bug#8884).
1219 * alloc.c (mark_buffer):
1220 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1221 (clone_per_buffer_values): Don't assume that
1222 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1223 This isn't true in general, and it's particularly not true
1224 if Emacs is configured with --with-wide-int.
1225 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1226 New macros, used in the buffer.c change.
1228 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1230 * xsettings.c: Use both GConf and GSettings if both are available.
1231 (store_config_changed_event): Add comment.
1232 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1233 (store_tool_bar_style_changed): New functions.
1234 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1235 (struct xsettings): Move font inside HAVE_XFT.
1236 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1237 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1238 Move inside HAVE_XFT.
1239 (something_changed_gsettingsCB): Rename from something_changedCB.
1240 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1242 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1243 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1244 (something_changed_gconfCB): Rename from something_changedCB.
1245 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1246 (parse_settings): Move check for font inside HAVE_XFT.
1247 (read_settings, apply_xft_settings): Add comment.
1248 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1249 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1250 call store_font_name_changed.
1251 (xft_settings_event): Add comment.
1252 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1253 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1254 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1255 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1256 (xsettings_initialize): Call init_gsettings last.
1257 (xsettings_get_system_font, xsettings_get_system_normal_font):
1260 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1262 Random fixes. E.g., (random) never returned negative values.
1263 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1264 subseconds part to the entropy, as that's a bit more random.
1265 Prefer signed to unsigned, since the signedness doesn't matter and
1266 in general we prefer signed. When given a limit, use a
1267 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1268 latter isn't right if USE_2_TAGS_FOR_INTS.
1269 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1270 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1272 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1274 * textprop.c (text_property_stickiness):
1275 Obey Vtext_property_default_nonsticky.
1276 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1277 * w32fns.c (syms_of_w32fns):
1278 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1280 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1282 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1283 This is more efficient than Ffile_directory_p and avoids a minor race.
1285 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1287 * buffer.c (Foverlay_put): Say what the return value is
1290 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1291 is a directory before asking whether to use the file name
1293 (barf_or_query_if_file_exists): Make the "File is a directory"
1294 error be more correct.
1296 * fns.c (Frequire): Remove the mention of the .gz files, since
1297 that's installation-specific, but keep the mention of
1298 `get-load-suffixes'.
1300 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1302 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1303 Report string overflow if the output is too long.
1305 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1307 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1308 (syms_of_gnutls): Remove duplicate DEFSYM for
1309 Qgnutls_bootprop_verify_hostname_error, an error for
1310 Qgnutls_bootprop_verify_error (which is no longer used).
1312 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1313 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1314 Also (re)move comments that are misplaced or no longer relevant.
1316 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1318 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1320 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1322 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1323 and background color parameters if they have been changed.
1325 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1327 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1329 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1331 * xsettings.c (SYSTEM_FONT): Define only when used.
1332 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1334 * keymap.c (access_keymap_1): Now static.
1336 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1338 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1339 leave any prefix arg for the up event (Bug#1586).
1341 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1343 * lread.c (syms_of_lread): Mention single symbols defined by
1344 `defvar' or `defconst' (bug#7154).
1346 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1347 (Frequire): Mention get-load-suffixes.
1349 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1351 * window.h (window): Remove clone_number slot.
1352 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1354 (make_parent_window, make_window, saved_window)
1355 (Fset_window_configuration, save_window_save): Don't deal with
1357 * buffer.c (Qclone_number): Remove declaration.
1358 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1360 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1362 Add multiple inheritance to keymaps.
1363 * keymap.c (Fmake_composed_keymap): New function.
1364 (Fset_keymap_parent): Simplify.
1365 (fix_submap_inheritance): Remove.
1366 (access_keymap_1): New function extracted from access_keymap to handle
1367 embedded parents and handle lists of maps.
1368 (access_keymap): Use it.
1369 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1370 (Fcopy_keymap): Handle embedded parents.
1371 (Fcommand_remapping, define_as_prefix): Simplify.
1372 (Fkey_binding): Simplify.
1373 (syms_of_keymap): Move minibuffer-local-completion-map,
1374 minibuffer-local-filename-completion-map,
1375 minibuffer-local-must-match-map, and
1376 minibuffer-local-filename-must-match-map to Elisp.
1377 (syms_of_keymap): Defsubr make-composed-keymap.
1378 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1379 (parse_menu_item): Trivial simplification.
1381 2011-07-01 Glenn Morris <rgm@gnu.org>
1383 * Makefile.in (SETTINGS_LIBS): Fix typo.
1385 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1387 * coding.c (Fencode_coding_string): Record the last coding system
1388 used, as the function doc string says (bug#8738).
1390 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1392 * xsettings.c (store_monospaced_changed): Take new font as arg and
1393 check for change against current_mono_font.
1394 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1395 (emacs_settings_constructor, emacs_settings_get_property)
1396 (emacs_settings_set_property, emacs_settings_class_init)
1397 (emacs_settings_init, gsettings_obj): Remove.
1398 (something_changedCB): New function for HAVE_GSETTINGS.
1399 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1400 with value as argument.
1401 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1402 g_settings_new (Bug#8967). Do not create gsettings_obj.
1403 Remove calls to g_settings_bind. Connect something_changedCB to
1406 * xgselect.c: Add defined (HAVE_GSETTINGS).
1407 (xgselect_initialize): Ditto.
1409 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1410 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1413 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1415 * eval.c (struct backtrace): Simplify and port the data structure.
1416 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1417 signed bit field, as this assumption is not portable and it makes
1418 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1419 "char debug_on_exit : 1" as this is not portable either; instead,
1420 use the portable "unsigned int debug_on_exit : 1". Remove unused
1421 member evalargs. Remove obsolete comments about cc bombing out.
1423 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1425 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1426 Let HAVE_GSETTINGS override HAVE_GCONF.
1427 (store_monospaced_changed): New function.
1428 (EMACS_SETTINGS): A new type derived from GObject to handle
1429 GSettings notifications.
1430 (emacs_settings_constructor, emacs_settings_get_property)
1431 (emacs_settings_set_property, emacs_settings_class_init):
1433 (gsettings_client, gsettings_obj): New variables.
1434 (GSETTINGS_SCHEMA): New define.
1435 (something_changedCB): Call store_monospaced_changed.
1436 (init_gsettings): New function.
1437 (xsettings_initialize): Call init_gsettings.
1438 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1441 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1444 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1446 * window.c (resize_root_window, grow_mini_window)
1447 (shrink_mini_window): Rename Qresize_root_window to
1448 Qwindow_resize_root_window and Qresize_root_window_vertically to
1449 Qwindow_resize_root_window_vertically.
1451 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1453 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1455 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1457 * makefile.w32-in: Redesign dependencies so they reflect more
1458 clearly which files are directly included by each source file,
1459 and not through other includes.
1461 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1463 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1464 (sort_overlays, overlay_strings): When an overlay's clone number
1465 matches the window's clone number process the overlay even if
1466 the overlay's window property doesn't match the current window.
1468 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1469 (Fwindow_hchild): Rename to Fwindow_left_child.
1470 (Fwindow_next): Rename to Fwindow_next_sibling.
1471 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1472 (resize_window_check): Rename to window_resize_check.
1473 (resize_window_apply): Rename to window_resize_apply.
1474 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1475 (Fdelete_other_windows_internal, resize_frame_windows)
1476 (Fsplit_window_internal, Fdelete_window_internal)
1477 (grow_mini_window, shrink_mini_window)
1478 (Fresize_mini_window_internal): Fix callers accordingly.
1480 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1482 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1483 (emacs_fixed_set_min_size): Remove.
1484 (emacs_fixed_new): Take frame as argument.
1486 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1487 (_EmacsFixedPrivate): Remove minwidth/height.
1488 Add struct frame *f.
1489 (emacs_fixed_init): Initialize priv->f.
1490 (get_parent_class, emacs_fixed_set_min_size): Remove.
1491 (emacs_fixed_new): Set priv->f to argument.
1492 (emacs_fixed_get_preferred_width)
1493 (emacs_fixed_get_preferred_height): Use min_width/height from
1494 frames size_hint to set minimum and natural (Bug#8919).
1495 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1496 and use min_width/height from frames size_hint to set
1497 min_width/height (Bug#8919).
1499 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1500 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1503 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1505 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1506 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1509 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1511 * process.c (wait_reading_process_output): Bypass select if
1512 waiting for a cell while ignoring keyboard input, and input is
1513 pending. Suggested by Jan Djärv (Bug#8869).
1515 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1517 Use gnulib's dup2 module instead of rolling our own.
1518 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1520 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1522 * dispnew.c (scrolling_window): Before scrolling, turn off a
1523 mouse-highlight in the window being scrolled.
1525 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1527 Move DEFSYM to lisp.h and use everywhere.
1529 * character.h (DEFSYM): Move declaration...
1530 * lisp.h (DEFSYM): ...here.
1536 * w32select.c: Don't include character.h.
1538 * alloc.c (syms_of_alloc):
1539 * buffer.c (syms_of_buffer):
1540 * bytecode.c (syms_of_bytecode):
1541 * callint.c (syms_of_callint):
1542 * casefiddle.c (syms_of_casefiddle):
1543 * casetab.c (init_casetab_once):
1544 * category.c (init_category_once, syms_of_category):
1545 * ccl.c (syms_of_ccl):
1546 * cmds.c (syms_of_cmds):
1547 * composite.c (syms_of_composite):
1548 * dbusbind.c (syms_of_dbusbind):
1549 * dired.c (syms_of_dired):
1550 * dispnew.c (syms_of_display):
1551 * doc.c (syms_of_doc):
1552 * editfns.c (syms_of_editfns):
1553 * emacs.c (syms_of_emacs):
1554 * eval.c (syms_of_eval):
1555 * fileio.c (syms_of_fileio):
1556 * fns.c (syms_of_fns):
1557 * frame.c (syms_of_frame):
1558 * fringe.c (syms_of_fringe):
1559 * insdel.c (syms_of_insdel):
1560 * keymap.c (syms_of_keymap):
1561 * lread.c (init_obarray, syms_of_lread):
1562 * macros.c (syms_of_macros):
1563 * msdos.c (syms_of_msdos):
1564 * print.c (syms_of_print):
1565 * process.c (syms_of_process):
1566 * search.c (syms_of_search):
1567 * sound.c (syms_of_sound):
1568 * syntax.c (init_syntax_once, syms_of_syntax):
1569 * terminal.c (syms_of_terminal):
1570 * textprop.c (syms_of_textprop):
1571 * undo.c (syms_of_undo):
1572 * w32.c (globals_of_w32):
1573 * window.c (syms_of_window):
1574 * xdisp.c (syms_of_xdisp):
1575 * xfaces.c (syms_of_xfaces):
1576 * xfns.c (syms_of_xfns):
1577 * xmenu.c (syms_of_xmenu):
1578 * xsettings.c (syms_of_xsettings):
1579 * xterm.c (syms_of_xterm): Use DEFSYM.
1581 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1583 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1585 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1587 Integer and buffer overflow fixes (Bug#8873).
1589 * print.c (printchar, strout): Check for string overflow.
1590 (PRINTPREPARE, printchar, strout):
1591 Don't set size unless allocation succeeds.
1593 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1594 for sizes. Check for string overflow more accurately.
1595 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1597 * macros.c: Integer and buffer overflow fixes.
1598 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1599 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1600 Use ptrdiff_t, not int, for sizes.
1601 Don't increment bufsize until after realloc succeeds.
1602 Check for size-calculation overflow.
1603 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1605 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1607 * lread.c: Integer overflow fixes.
1608 (read_integer): Radix is now EMACS_INT, not int,
1609 to improve quality of diagnostics for out-of-range radices.
1610 Calculate buffer size correctly for out-of-range radices.
1611 (read1): Check for integer overflow in radices, and in
1612 read-circle numbers.
1613 (read_escape): Avoid int overflow.
1614 (Fload, openp, read_buffer_size, read1)
1615 (substitute_object_recurse, read_vector, read_list, map_obarray):
1616 Use ptrdiff_t, not int, for sizes.
1617 (read1): Use EMACS_INT, not int, for sizes.
1618 Check for size overflow.
1620 * image.c (cache_image): Check for size arithmetic overflow.
1622 * lread.c: Integer overflow issues.
1623 (saved_doc_string_size, saved_doc_string_length)
1624 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1625 Now ptrdiff_t, not int.
1626 (read1): Don't assume doc string length fits in int. Check for
1627 out-of-range doc string lengths.
1628 (read_list): Don't assume file position fits in int.
1629 (read_escape): Check for hex character overflow.
1631 2011-06-22 Leo Liu <sdl.web@gmail.com>
1633 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1634 Move to minibuffer.el.
1636 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1638 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1639 The following patches are for when GLYPH_DEBUG && !XASSERT.
1640 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1641 * dispnew.c (flush_stdout):
1642 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1643 Mark as externally visible.
1644 * dispnew.c (check_window_matrix_pointers): Now static.
1645 * dispnew.c (window_to_frame_vpos):
1646 * xfns.c (unwind_create_frame):
1647 * xterm.c (x_check_font): Remove unused local.
1648 * scroll.c (CHECK_BOUNDS):
1649 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1650 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1651 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1652 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1653 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1655 (debug_method_add): Use va_list and vsprintf rather than relying
1656 on undefined behavior with wrong number of arguments.
1657 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1658 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1659 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1660 since we're not interested in debugging glyphs with old libraries.
1661 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1662 GCC 4.6.0's static checking.
1664 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1666 Integer overflow and signedness fixes (Bug#8873).
1667 A few related buffer overrun fixes, too.
1669 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1671 * dispextern.h (struct face.stipple):
1672 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1673 (x_bitmap_mask, x_allocate_bitmap_record)
1674 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1675 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1676 (x_create_bitmap_from_xpm_data):
1677 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1678 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1680 * xfaces.c (load_pixmap):
1681 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1682 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1683 (.bitmaps_last, struct x_output.icon_bitmap):
1684 Use ptrdiff_t, not int, for bitmap indexes.
1685 (x_allocate_bitmap_record): Check for size overflow.
1686 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1688 Use ptrdiff_t, not int, for overlay counts.
1689 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1690 * editfns.c (overlays_around, get_pos_property):
1691 * textprop.c (get_char_property_and_overlay):
1692 * xdisp.c (next_overlay_change, note_mouse_highlight):
1693 * xfaces.c (face_at_buffer_position):
1694 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1695 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1696 (Fnext_overlay_change, Fprevious_overlay_change)
1697 (mouse_face_overlay_overlaps, Foverlays_in):
1698 Use ptrdiff_t, not int, for sizes.
1699 (overlays_at, overlays_in): Check for size-calculation overflow.
1701 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1703 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1704 (x_session_initialize): Do not assume string length fits in int.
1706 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1707 This is unlikely, but can occur if DPI is outlandish.
1709 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1710 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1712 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1713 * xrdb.c (magic_file_p, search_magic_path):
1714 Omit last arg SUFFIX; it was always 0. All callers changed.
1715 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1717 * xfont.c (xfont_match): Avoid need for strlen.
1719 * xfns.c: Don't assume strlen fits in int.
1720 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1722 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1723 not unsigned long, as we prefer signed integers. All callers changed.
1724 Detect integer overflow in repeat count.
1725 (message_dolog): Don't assume print length fits in 39 bytes.
1726 (display_mode_element): Don't assume strlen fits in int.
1728 * termcap.c: Don't assume sizes fit in int and never overflow.
1729 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1730 (gobble_line): Check for size-calculation overflow.
1732 * minibuf.c (Fread_buffer):
1733 * lread.c (intern, intern_c_string):
1734 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1735 Don't assume string length fits in int.
1737 * keyboard.c (parse_tool_bar_item):
1738 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1740 * font.c: Don't assume string length fits in int.
1741 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1742 Use ptrdiff_t, not int.
1743 (font_intern_prop): Don't assume string length fits in int.
1744 Don't assume integer property fits in fixnum.
1745 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1747 * filelock.c: Fix some buffer overrun and integer overflow issues.
1748 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1749 Reformulate so as not to need the command string.
1750 Invoke gzip -cd rather than gunzip, as it's more portable.
1751 (lock_info_type, lock_file_1, lock_file):
1752 Don't assume pid_t and time_t fit in unsigned long.
1753 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1754 (current_lock_owner): Prefer signed type for sizes.
1755 Use memcpy, not strncpy, where memcpy is what is really wanted.
1756 Don't assume (via atoi) that time_t and pid_t fit in int.
1757 Check for time_t and/or pid_t out of range, e.g., via a network share.
1758 Don't alloca where an auto var works fine.
1760 * fileio.c: Fix some integer overflow issues.
1761 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1762 Don't assume string length fits in int.
1763 (directory_file_name): Don't assume string length fits in long.
1764 (make_temp_name): Don't assume pid fits in int, or that its print
1765 length is less than 20.
1767 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1769 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1771 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1773 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1774 We prefer signed integers, even for size calculations.
1776 * emacs.c: Don't assume string length fits in 'int'.
1777 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1778 (main): Don't invoke strlen when not needed.
1780 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1781 (XD_DEBUG_MESSAGE): Don't waste a byte.
1783 * callproc.c (getenv_internal_1, getenv_internal)
1785 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1787 * lread.c (invalid_syntax): Omit length argument.
1788 All uses changed. This doesn't fix a bug, but it simplifies the
1789 code away from its former Hollerith-constant appearance, and it's
1790 one less 'int' to worry about when looking at integer-overflow issues.
1791 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1793 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1794 This didn't break anything, but it didn't help either.
1795 It's confusing to put a bogus integer in a place where the actual
1796 value does not matter.
1797 (LIST_END_P): Remove unused macro and its bogus comment.
1798 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1800 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1801 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1803 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1804 We prefer signed types, and the value cannot exceed the EMACS_INT
1805 range anyway (because otherwise the length would not be representable).
1806 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1807 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1808 This avoids a GCC warning when WIDE_EMACS_INT.
1810 * indent.c (sane_tab_width): New function.
1811 (current_column, scan_for_column, Findent_to, position_indentation)
1812 (compute_motion): Use it. This is just for clarity.
1813 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1815 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1817 * lisp.h (lint_assume): New macro.
1818 * composite.c (composition_gstring_put_cache):
1819 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1821 * editfns.c, insdel.c:
1822 Omit unnecessary forward decls, to simplify future changes.
1824 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1826 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1828 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1829 Use much-faster test for byte-length change.
1830 Don't assume string byte-length fits in 'int'.
1831 Check that character arg fits in 'int'.
1832 (mapcar1): Declare byte as byte, for clarity.
1834 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1836 * fns.c (concat): Catch string overflow earlier.
1837 Do not rely on integer wraparound.
1839 * dispextern.h (struct it.overlay_strings_charpos)
1840 (struct it.selective): Now EMACS_INT, not int.
1841 * xdisp.c (forward_to_next_line_start)
1842 (back_to_previous_visible_line_start)
1843 (reseat_at_next_visible_line_start, next_element_from_buffer):
1844 Don't arbitrarily truncate the value of 'selective' to int.
1846 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1848 * composite.c: Don't truncate sizes to 'int'.
1849 (composition_gstring_p, composition_reseat_it)
1850 (composition_adjust_point): Use EMACS_INT, not int.
1851 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1852 not EMACS_UINT, for indexes.
1854 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1856 * buffer.c: Include <verify.h>.
1857 (struct sortvec.priority, struct sortstr.priority):
1858 Now EMACS_INT, not int.
1859 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1860 (struct sortstr.size, record_overlay_string)
1861 (struct sortstrlist.size, struct sortlist.used):
1862 Don't truncate size to int.
1863 (record_overlay_string): Check for size-calculation overflow.
1864 (init_buffer_once): Check at compile-time, not run-time.
1866 2011-06-22 Jim Meyering <meyering@redhat.com>
1868 Don't leak an XBM-image-sized buffer
1869 * image.c (xbm_load): Free the image buffer after using it.
1871 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1874 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1875 that Sun C diagnosed.
1876 * fns.c (secure_hash): Fix pointer signedness issue.
1877 * intervals.c (static_offset_intervals): New function.
1878 (offset_intervals): Use it.
1880 2011-06-21 Leo Liu <sdl.web@gmail.com>
1883 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1886 * fns.c (secure_hash): Rename from crypto_hash_function and change
1887 the first arg to accept symbols.
1888 (Fsecure_hash): New primitive.
1889 (syms_of_fns): New symbols.
1891 2011-06-20 Deniz Dogan <deniz@dogan.se>
1893 * process.c (Fset_process_buffer): Clarify return value in
1896 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1898 * dispnew.c (add_window_display_history): Use BVAR.
1900 * xdisp.c (debug_method_add): Use BVAR.
1901 (check_window_end, dump_glyph_matrix, dump_glyph)
1902 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1904 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1907 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1908 check till after the cache is created in init_frame_faces.
1910 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1912 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1914 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1916 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1917 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1918 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1920 Improve buffer-overflow checking (Bug#8873).
1921 * fileio.c (Finsert_file_contents):
1922 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1923 Remove the old (too-loose) buffer overflow checks.
1924 They weren't needed, since make_gap checks for buffer overflow.
1925 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1926 The old code merely checked for Emacs fixnum overflow, and relied
1927 on undefined (wraparound) behavior. The new code avoids undefined
1928 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1930 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1931 Tune. Don't use wider integers than needed. Don't use alloca.
1932 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1934 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1936 * insdel.c, lisp.h (buffer_overflow): New function.
1937 (insert_from_buffer_1, replace_range, replace_range_2):
1938 * insdel.c (make_gap_larger):
1939 * editfns.c (Finsert_char):
1940 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1942 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1944 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1946 Integer overflow and signedness fixes (Bug#8873).
1948 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1949 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1951 * fileio.c: Don't assume EMACS_INT fits in off_t.
1952 (emacs_lseek): New static function.
1953 (Finsert_file_contents, Fwrite_region): Use it.
1954 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1956 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1958 * fns.c: Don't overflow int when computing a list length.
1959 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1960 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1961 truncation on 64-bit hosts. Check for QUIT every
1962 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1963 faster and is responsive enough.
1964 (Flength): Report an error instead of overflowing an integer.
1965 (Fsafe_length): Return a float if the value is not representable
1966 as a fixnum. This shouldn't happen except in contrived situations.
1967 (Fnthcdr, Fsort): Don't assume list length fits in int.
1968 (Fcopy_sequence): Don't assume vector length fits in int.
1970 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1971 (header_size, word_size): New constants.
1972 (allocate_vectorlike): Don't check size overflow here.
1973 (allocate_vector): Check it here instead, since this is the only
1974 caller of allocate_vectorlike that could cause overflow.
1975 Check that the new vector's length is representable as a fixnum.
1977 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1978 The previous code was bogus. For example, next_almost_prime (32)
1979 returned 39, which is undesirable as it is a multiple of 3; and
1980 next_almost_prime (24) returned 25, which is a multiple of 5 so
1981 why was the code bothering to check for multiples of 7?
1983 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1985 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1987 Variadic C functions now count arguments with ptrdiff_t.
1988 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1989 Back then I didn't know that the Emacs coding style prefers signed int.
1990 Also, in the meantime I found a few more instances where arguments
1991 were being counted with int, which may truncate counts on 64-bit
1992 machines, or EMACS_INT, which may be unnecessarily wide.
1993 * lisp.h (struct Lisp_Subr.function.aMANY)
1994 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1995 Arg counts are now ptrdiff_t, not size_t.
1996 All variadic functions and their callers changed accordingly.
1997 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1998 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1999 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2000 * callint.c (Fcall_interactively): Check arg count for overflow,
2001 to avoid potential buffer overrun. Use signed char, not 'int',
2002 for 'varies' array, so that we needn't bother to check its size
2003 calculation for overflow.
2004 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2005 * eval.c (apply_lambda):
2006 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2007 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2008 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2010 * callint.c (Fcall_interactively): Don't use index var as event count.
2012 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2013 * mem-limits.h (SIZE): Remove; no longer used.
2015 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2017 Remove unnecessary casts.
2018 * xterm.c (x_term_init):
2019 * xfns.c (x_set_border_pixel):
2020 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2021 These aren't needed now that we assume ANSI C.
2023 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2024 It's more likely to cause problems (due to unsigned overflow)
2027 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2029 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2031 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2033 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2035 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2037 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2039 GLYPH_CODE_FACE returns EMACS_INT, not int.
2040 * dispextern.h (merge_faces):
2041 * xfaces.c (merge_faces):
2042 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2043 Don't assume EMACS_INT fits in int.
2045 * character.h (CHAR_VALID_P): Remove unused parameter.
2046 * fontset.c, lisp.h, xdisp.c: All uses changed.
2048 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2050 * fns.c (concat): Minor tuning based on overflow analysis.
2051 This doesn't fix any bugs. Use int to hold character, instead
2052 of constantly refetching from Emacs object. Use XFASTINT, not
2053 XINT, for value known to be a character. Don't bother comparing
2054 a single byte to 0400, as it's always less.
2056 * floatfns.c (Fexpt):
2057 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2059 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2062 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2064 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2065 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2066 incorrectly succeed when S was a string, because 4294967386 was
2067 truncated before it was used.
2069 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2070 Otherwise, an out-of-range integer could cause undefined behavior
2073 * composite.c: Use int, not EMACS_INT, for characters.
2074 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2075 EMACS_INT, for values that are known to be in character range.
2076 This doesn't fix any bugs but is the usual style inside Emacs and
2077 may generate better code on 32-bit machines.
2079 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2080 This is for reasons similar to the recent CHAR_STRING fix.
2081 * charset.c (Fencode_char): Check that character arg is actually
2082 a character. Pass an int to ENCODE_CHAR.
2083 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2084 wider than 'int', as a compile-time check to prevent future regressions
2087 * character.c (char_string): Remove unnecessary casts.
2089 Make sure a 64-bit char is never passed to CHAR_STRING.
2090 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2091 by silently ignoring the top 32 bits, allowing some values
2092 that were far too large to be valid characters.
2093 * character.h: Include <verify.h>.
2094 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2095 arguments are no wider than unsigned, as a compile-time check
2096 to prevent future regressions in this area.
2098 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2099 (Fsubst_char_in_region):
2101 * xdisp.c (decode_mode_spec_coding):
2102 Adjust to CHAR_STRING's new requirement.
2103 * editfns.c (Finsert_char, Fsubst_char_in_region):
2104 * fns.c (concat): Check that character args are actually
2105 characters. Without this test, these functions did the wrong
2106 thing with wildly out-of-range values on 64-bit hosts.
2108 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2109 These casts should not be needed on 32-bit hosts, either.
2110 * keyboard.c (read_char):
2111 * lread.c (Fload): Remove casts to unsigned.
2113 * lisp.h (UNSIGNED_CMP): New macro.
2114 This fixes comparison bugs on 64-bit hosts.
2115 (ASCII_CHAR_P): Use it.
2116 * casefiddle.c (casify_object):
2117 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2118 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2119 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2120 * dispextern.h (FACE_FROM_ID):
2121 * keyboard.c (read_char): Use UNSIGNED_CMP.
2123 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2124 not to EMACS_INT, to avoid GCC warning.
2126 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2128 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2129 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2130 isn't needed on 32-bit machines.
2132 * buffer.c (Fgenerate_new_buffer_name):
2133 Use EMACS_INT for count, not int.
2134 (advance_to_char_boundary): Return EMACS_INT, not int.
2136 * data.c (Qcompiled_function): Now static.
2138 * window.c (window_body_lines): Now static.
2140 * image.c (gif_load): Rename local to avoid shadowing.
2142 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2143 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2144 * alloc.c (make_save_value): Integer argument is now of type
2146 (mark_object): Use ptrdiff_t, not int.
2147 * lisp.h (pD): New macro.
2148 * print.c (print_object): Use it.
2150 * alloc.c: Use EMACS_INT, not int, to count objects.
2151 (total_conses, total_markers, total_symbols, total_vector_size)
2152 (total_free_conses, total_free_markers, total_free_symbols)
2153 (total_free_floats, total_floats, total_free_intervals)
2154 (total_intervals, total_strings, total_free_strings):
2155 Now EMACS_INT, not int. All uses changed.
2156 (Fgarbage_collect): Compute overall total using a double, so that
2157 integer overflow is less likely to be a problem. Check for overflow
2158 when converting back to an integer.
2159 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2160 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2161 These were 'int' variables that could overflow on 64-bit hosts;
2162 they were never used, so remove them instead of repairing them.
2163 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2164 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2165 Previously, this ceilinged at INT_MAX, but that doesn't work on
2167 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2169 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2170 (allocate_vectorlike): Check for ptrdiff_t overflow.
2171 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2172 when a (possibly-narrower) signed value would do just as well.
2173 We prefer using signed arithmetic, to avoid comparison confusion.
2175 * alloc.c: Catch some string size overflows that we were missing.
2176 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2177 for convenience in STRING_BYTES_MAX.
2178 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2179 The definition here is exact; the one in lisp.h was approximate.
2180 (allocate_string_data): Check for string overflow. This catches
2181 some instances we weren't catching before. Also, it catches
2182 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2183 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2184 and ptrdiff_t and EMACS_INT are both 64 bits.
2186 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2187 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2188 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2190 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2192 * alloc.c (Fmake_string): Check for out-of-range init.
2194 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2196 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2198 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2200 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2201 xg_get_default_scrollbar_width.
2203 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2204 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2205 (style_changed_cb): Call update_theme_scrollbar_width and call
2206 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2207 all frames (Bug#8505).
2208 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2209 Call gtk_window_set_resizable if HAVE_GTK3.
2210 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2211 and height if HAVE_GTK3 (Bug#8505).
2212 (scroll_bar_width_for_theme): New variable.
2213 (update_theme_scrollbar_width): New function.
2214 (xg_get_default_scrollbar_width): Move code to
2215 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2216 (xg_initialize): Call update_theme_scrollbar_width.
2218 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2220 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2222 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2224 * frame.c (make_frame): Call other_buffer_safely instead of
2227 * window.c (temp_output_buffer_show): Call display_buffer with
2228 second argument Vtemp_buffer_show_specifiers and reset latter
2229 immediately after the call.
2230 (Vtemp_buffer_show_specifiers): New variable.
2231 (auto_window_vscroll_p, next_screen_context_lines)
2232 (Vscroll_preserve_screen_position): Remove leading asterisks from
2235 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2237 Fix minor problems found by GCC 4.6.0 static checking.
2238 * buffer.c (Qclone_number): Remove for now, as it's unused.
2239 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2240 (record_buffer): Remove unused local.
2241 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2242 (set_frame_buffer_list): Remove; unused.
2243 * frame.h (other_visible_frames): Remove decl.
2244 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2245 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2246 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2248 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2249 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2250 Define only if HAVE_GPM.
2251 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2252 (update_hints_inhibit): Remove; never set. All uses removed.
2253 * widgetprv.h (emacsFrameClassRec): Remove decl.
2254 * window.c (delete_deletable_window): Now returns void, since it
2255 wasn't returning anything.
2256 (compare_window_configurations): Remove unused locals.
2257 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2258 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2259 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2260 the same widths as pointers. This follows up on the 2011-05-06 patch.
2261 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2262 * xterm.h: Likewise.
2263 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2265 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2267 * makefile.w32-in: Update dependencies.
2268 (LISP_H): Add lib/intprops.h.
2270 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2272 * image.c (gif_load): Add animation frame delay to the metadata.
2273 (syms_of_image): Use DEFSYM. New symbol `delay'.
2275 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2277 * window.c (delete_deletable_window): Re-add.
2278 (Fset_window_configuration): Rewrite to handle dead buffers and
2279 consequently deletable windows.
2280 (window_tree, Fwindow_tree): Remove. Supply functionality in
2282 (compare_window_configurations): Simplify code.
2284 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2286 * image.c (imagemagick_load_image): Fix type mismatch.
2287 (Fimagemagick_types): Likewise.
2289 * window.h (replace_buffer_in_windows): Declare.
2291 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2293 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2294 Qclone_number. Remove external declaration of Qdelete_window.
2295 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2297 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2298 Run Qbuffer_list_update_hook if allowed.
2299 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2300 buffer list implementation.
2301 (other_buffer_safely): New function.
2302 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2303 calls to replace_buffer_in_windows and
2304 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2306 (record_buffer): Inhibit quitting and rewrite using quittable
2307 functions. Run Qbuffer_list_update_hook if allowed.
2308 (Frecord_buffer, Funrecord_buffer): New functions.
2309 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2310 Move switch-to-buffer to window.el.
2311 (bury-buffer): Move to window.el.
2312 (Vbuffer_list_update_hook): New variable.
2314 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2317 * window.h (resize_frame_windows): Move up in code.
2318 (Fwindow_frame): Remove EXFUN.
2319 (replace_buffer_in_all_windows): Remove prototype.
2320 (replace_buffer_in_windows_safely): Add prototype.
2322 * window.c: Declare Qdelete_window static again. Move down
2323 declaration of select_count.
2324 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2325 (Fother_window): Move to window.el.
2326 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2327 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2328 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2330 (replace_buffer_in_windows): Implement by calling
2331 Qreplace_buffer_in_windows.
2332 (replace_buffer_in_all_windows): Remove with some functionality
2333 moved into replace_buffer_in_windows_safely.
2334 (replace_buffer_in_windows_safely): New function.
2335 (select_window_norecord, select_frame_norecord): Move in front
2336 of run_window_configuration_change_hook. Remove now obsolete
2338 (Fset_window_buffer): Rewrite doc-string.
2339 Call Qrecord_window_buffer.
2340 (keys_of_window): Move binding for other-window to window.el.
2342 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2344 * dispextern.h (struct image): Replace data member, whose int_val
2345 and ptr_val fields were not used by anything, with a single
2348 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2349 (gif_clear_image, gif_load, imagemagick_load_image)
2350 (gs_clear_image, gs_load): Callers changed.
2352 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2354 * buffer.h: Include <time.h>, for time_t.
2355 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2357 Fix minor problems found by static checking.
2359 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2361 Make identifiers static if they are not used in other modules.
2362 * data.c (Qcompiled_function, Qframe, Qvector):
2363 * image.c (QimageMagick, Qsvg):
2364 * minibuf.c (Qmetadata):
2365 * window.c (resize_window_check, resize_root_window): Now static.
2366 * window.h (resize_window_check, resize_root_window): Remove decls.
2368 * window.c (window_deletion_count, delete_deletable_window):
2370 (window_body_lines): Now static.
2371 (Fdelete_other_windows_internal): Mark vars as initialized.
2372 Make sure 'resize_failed' is initialized.
2373 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2374 (resize_window_apply): Remove unused local.
2375 * window.h (delete_deletable_window): Remove decl.
2377 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2378 (imagemagick_load_image): Fix pointer signedness problem by changing
2379 last arg from unsigned char * to char *. All uses changed.
2380 Also, fix a local for similar reasons.
2381 Remove unused locals. Remove locals to avoid shadowing.
2382 (fn_rsvg_handle_free): Remove; unused.
2383 (svg_load, svg_load_image): Fix pointer signedness problem.
2384 (imagemagick_load_image): Don't use garbage pointer image_wand.
2386 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2388 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2390 * image.c (gif_load): Fix omitted cast error introduced by
2393 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2395 * window.h (resize_proportionally, orig_total_lines)
2396 (orig_top_line): Remove from window structure.
2397 (set_window_height, set_window_width, change_window_heights)
2398 (Fdelete_window): Remove prototypes.
2399 (resize_frame_windows): Remove duplicate declaration.
2401 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2403 * window.h (resize_frame_windows, resize_window_check)
2404 (delete_deletable_window, resize_root_window)
2405 (resize_frame_windows): Declare prototypes.
2407 * window.c (resize_window_apply): Make definition be "static" to
2408 match the prototype.
2410 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2412 * window.c: Remove declarations of Qwindow_size_fixed,
2413 window_min_size_1, window_min_size_2, window_min_size,
2414 size_window, window_fixed_size_p, enlarge_window, delete_window.
2415 Remove static from declaration of Qdelete_window, it's
2416 temporarily needed by Fbury_buffer.
2417 (replace_window): Don't assign orig_top_line and
2419 (Fdelete_window, delete_window): Remove. Window deletion is
2420 handled by window.el.
2421 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2422 Replace Fdelete_window calls with calls to Qdelete_window.
2423 (Fdelete_other_windows): Remove. Deleting other windows is
2424 handled by window.el.
2425 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2426 handled in window.el.
2427 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2428 Window minimum sizes are handled in window.el.
2429 (shrink_windows, size_window, set_window_height)
2430 (set_window_width, change_window_heights, window_height)
2431 (window_width, CURBEG, CURSIZE, enlarge_window)
2432 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2433 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2434 handled in window.el.
2435 (make_dummy_parent): Rename to make_parent_window and give it a
2436 second argument horflag.
2437 (make_window): Don't set resize_proportionally any more.
2438 (Fsplit_window): Remove. Windows are split in window.el.
2439 (save_restore_action, save_restore_orig_size)
2440 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2441 Resize mini windows in window.el.
2442 (grow_mini_window, shrink_mini_window): Implement by calling
2443 Qresize_root_window_vertically, resize_window_check and
2444 resize_window_apply.
2445 (saved_window, Fset_window_configuration, save_window_save):
2446 Do not handle orig_top_line, orig_total_lines, and
2447 resize_proportionally.
2448 (window_min_height, window_min_width): Move to window.el.
2449 (keys_of_window): Move bindings for delete-other-windows,
2450 split-window, delete-window and enlarge-window to window.el.
2452 * buffer.c: Temporarily extern Qdelete_window.
2453 (Fbury_buffer): Temporarily call Qdelete_window instead of
2454 Fdelete_window (Fbury_buffer will move to window.el soon).
2456 * frame.c (set_menu_bar_lines_1): Remove code handling
2457 orig_top_line and orig_total_lines.
2459 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2460 set_window_height but set heights directly.
2461 (change_frame_size_1): Use resize_frame_windows.
2463 * xdisp.c (init_xdisp): Don't use set_window_height but set
2466 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2467 Use resize_frame_windows instead of change_window_heights and run
2468 run_window_configuration_change_hook.
2470 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2471 instead of change_window_heights and run
2472 run_window_configuration_change_hook.
2474 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2476 * window.c (replace_window): Rename second argument REPLACEMENT to
2477 NEW. New third argument SETFLAG. Rewrite.
2478 (delete_window, make_dummy_parent): Call replace_window with
2480 (window_list_1): Move down in code.
2481 (run_window_configuration_change_hook): Move set_buffer part
2482 before select_frame_norecord part in order to unwind correctly.
2483 Rename count1 to count.
2484 (recombine_windows, delete_deletable_window, resize_root_window)
2485 (Fdelete_other_windows_internal)
2486 (Frun_window_configuration_change_hook, make_parent_window)
2487 (resize_window_check, resize_window_apply, Fresize_window_apply)
2488 (resize_frame_windows, Fsplit_window_internal)
2489 (Fdelete_window_internal, Fresize_mini_window_internal):
2491 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2493 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2495 * window.h (window): Add some new members to window structure -
2496 normal_lines, normal_cols, new_total, new_normal, clone_number,
2497 splits, nest, prev_buffers, next_buffers.
2498 (WINDOW_TOTAL_SIZE): Move here from window.c.
2499 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2501 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2503 (make_dummy_parent): Set new members of windows structure.
2504 (make_window): Move down in code. Handle new members of window
2506 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2507 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2508 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2509 (Fset_window_prev_buffers, Fwindow_next_buffers)
2510 (Fset_window_next_buffers, Fset_window_clone_number):
2512 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2513 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2515 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2516 Argument WINDOW can be now internal window too.
2517 (Fwindow_use_time): Move up in code.
2518 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2520 (Fset_window_configuration, saved_window)
2521 (Fcurrent_window_configuration, save_window_save): Handle new
2522 members of window structure.
2523 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2524 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2525 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2526 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2527 Qget_mru_window, Qresize_root_window,
2528 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2529 Qauto_buffer_name; staticpro them.
2531 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2533 * window.c (Fwindow_total_size, Fwindow_left_column)
2534 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2535 (Fwindow_list_1): New functions.
2536 (window_box_text_cols): Replace with window_body_cols.
2537 (Fwindow_width, Fscroll_left, Fscroll_right):
2538 Use window_body_cols instead of window_box_text_cols.
2539 (delete_window, Fset_window_configuration):
2540 Call delete_all_subwindows with window as argument.
2541 (delete_all_subwindows): Take a window as argument and not a
2543 (window_loop): Remove handling of GET_LRU_WINDOW and
2545 (Fget_lru_window, Fget_largest_window): Move to window.el.
2547 * window.h: Extern window_body_cols instead of
2548 window_box_text_cols. delete_all_subwindows now takes a
2549 Lisp_Object as argument.
2551 * indent.c (compute_motion, Fcompute_motion):
2552 Use window_body_cols instead of window_box_text_cols.
2554 * frame.c (delete_frame): Call delete_all_subwindows with root
2557 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2559 * fns.c (Fputhash): Document return value.
2561 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2563 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2565 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2567 Cons<->int and similar integer overflow fixes (Bug#8794).
2569 Check for overflow when converting integer to cons and back.
2570 * charset.c (Fdefine_charset_internal, Fdecode_char):
2571 Use cons_to_unsigned to catch overflow.
2572 (Fencode_char): Use INTEGER_TO_CONS.
2573 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2574 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2575 * data.c (long_to_cons, cons_to_long): Remove.
2576 (cons_to_unsigned, cons_to_signed): New functions.
2577 These signal an error for invalid or out-of-range values.
2578 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2579 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2580 * font.c (Ffont_variation_glyphs):
2581 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2582 * lisp.h: Include <intprops.h>.
2583 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2584 (cons_to_signed, cons_to_unsigned): New decls.
2585 (long_to_cons, cons_to_long): Remove decls.
2586 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2587 (Fprimitive_undo): Use CONS_TO_INTEGER.
2588 * xfns.c (Fx_window_property): Likewise.
2589 * xselect.c: Include <limits.h>.
2590 (x_own_selection, selection_data_to_lisp_data):
2591 Use INTEGER_TO_CONS.
2592 (x_handle_selection_request, x_handle_selection_clear)
2593 (x_get_foreign_selection, Fx_disown_selection_internal)
2594 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2595 (lisp_data_to_selection_data): Use cons_to_unsigned.
2596 (x_fill_property_data): Use cons_to_signed.
2597 Report values out of range.
2599 Check for buffer and string overflow more precisely.
2600 * buffer.h (BUF_BYTES_MAX): New macro.
2601 * lisp.h (STRING_BYTES_MAX): New macro.
2602 * alloc.c (Fmake_string):
2603 * character.c (string_escape_byte8):
2604 * coding.c (coding_alloc_by_realloc):
2605 * doprnt.c (doprnt):
2606 * editfns.c (Fformat):
2608 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2609 since they may not be the same number.
2610 * editfns.c (Finsert_char):
2611 * fileio.c (Finsert_file_contents):
2612 Likewise for BUF_BYTES_MAX.
2614 * image.c: Use ptrdiff_t, not int, for sizes.
2615 (slurp_file): Switch from int to ptrdiff_t.
2617 (slurp_file): Check that file size fits in both size_t (for
2618 malloc) and ptrdiff_t (for sanity and safety).
2620 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2621 if b->modtime has its maximal value.
2623 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2625 Don't assume time_t can fit into int.
2626 * buffer.h (struct buffer.modtime): Now time_t, not int.
2627 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2628 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2630 Minor fixes for signed vs unsigned integers.
2631 * character.h (MAYBE_UNIFY_CHAR):
2632 * charset.c (maybe_unify_char):
2633 * keyboard.c (read_char, reorder_modifiers):
2634 XINT -> XFASTINT, since the integer must be nonnegative.
2635 * ftfont.c (ftfont_spec_pattern):
2636 * keymap.c (access_keymap, silly_event_symbol_error):
2637 XUINT -> XFASTINT, since the integer must be nonnegative.
2638 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2639 since it makes no difference and we prefer signed.
2640 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2641 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2644 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2646 * window.h (Fwindow_frame): Declare.
2648 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2650 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2651 (SPARE_MEMORY): Always define.
2652 (LARGE_REQUEST): Remove.
2653 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2655 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2657 * lisp.h: Move EXFUNS for Fframe_root_window,
2658 Fframe_first_window and Fset_frame_selected_window to window.h.
2660 * window.h: Move EXFUNS for Fframe_root_window,
2661 Fframe_first_window and Fset_frame_selected_window here from
2664 * frame.c (Fwindow_frame, Fframe_first_window)
2665 (Fframe_root_window, Fframe_selected_window)
2666 (Fset_frame_selected_window): Move to window.c.
2667 (Factive_minibuffer_window): Move to minibuf.c.
2668 (Fother_visible_frames_p): New function.
2670 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2672 * window.c (decode_window, decode_any_window): Move up in code.
2673 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2674 (inhibit_frame_unsplittable): Remove unused variable.
2675 (Fwindow_buffer): Move up and rewrite doc-string.
2676 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2677 (Fwindow_prev): New functions.
2678 (Fwindow_frame): Move here from frame.c. Accept any window as
2680 (Fframe_root_window, Fframe_first_window)
2681 (Fframe_selected_window): Move here from frame.c. Accept frame
2682 or arbitrary window as argument. Update doc-strings.
2683 (Fminibuffer_window): Move up in code.
2684 (Fwindow_minibuffer_p): Move up in code and simplify.
2685 (Fset_frame_selected_window): Move here from frame.c.
2687 (Fselected_window, select_window, Fselect_window): Move up in
2688 code. Minor doc-string fixes.
2690 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2692 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2693 Do not assume that spare memory exists; that assumption is valid
2694 only if SYSTEM_MALLOC.
2695 (LARGE_REQUEST): New macro, so that the issue of large requests
2696 is separated from the issue of spare memory.
2698 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2700 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2703 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2705 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2708 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2710 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2712 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2714 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2715 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2717 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2719 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2721 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2723 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2724 (x_clipboard_manager_save): Add return value.
2725 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2727 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2728 Obey Vx_select_enable_clipboard_manager. Catch errors in
2729 x_clipboard_manager_save (Bug#8779).
2730 (Vx_select_enable_clipboard_manager): New variable.
2731 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2733 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2735 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2737 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2739 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2740 in the current matrix if keep_current_p is non-zero.
2742 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2744 * bidi.c (bidi_level_of_next_char): Fix last change.
2746 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2748 Support bidi reordering of text covered by display properties.
2750 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2751 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2752 (bidi_cache_search, bidi_cache_iterator_state)
2753 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2754 (bidi_level_of_next_char, bidi_move_to_visually_next):
2755 Support character positions inside a run of characters covered by a
2757 (bidi_paragraph_init, bidi_resolve_explicit_1)
2758 (bidi_level_of_next_char): Call bidi_fetch_char and
2759 bidi_fetch_char_advance instead of FETCH_CHAR and
2761 (bidi_init_it): Initialize new members.
2762 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2764 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2765 instead of using explicit *_CHAR codes.
2766 (bidi_resolve_explicit, bidi_resolve_weak):
2767 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2768 bidirectional text is supported only in multibyte buffers.
2769 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2770 it to initialize the frame_window_p member of struct bidi_it.
2771 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2772 (bidi_resolve_explicit, bidi_resolve_weak)
2773 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2774 bidi_it->nchars is non-positive.
2775 (bidi_level_of_next_char): Don't try to lookup the cache for the
2776 next/previous character if nothing is cached there yet, or if we
2777 were just reseat()'ed to a new position.
2779 * xdisp.c (set_cursor_from_row): Set start and stop points
2780 according to the row's direction when priming the loop that looks
2781 for the glyph on which to display cursor.
2782 (single_display_spec_intangible_p): Function deleted.
2783 (display_prop_intangible_p): Reimplement to call
2784 handle_display_spec instead of single_display_spec_intangible_p.
2785 Accept 3 additional arguments needed by handle_display_spec.
2786 This fixes incorrect cursor motion across display property with complex
2787 values: lists, `(when COND...)' forms, etc.
2788 (single_display_spec_string_p): Support property values that are
2789 lists with the argument STRING its top-level element.
2790 (display_prop_string_p): Fix the condition for processing a
2791 property that is a list to be consistent with handle_display_spec.
2792 (handle_display_spec): New function, refactored from the
2793 last portion of handle_display_prop.
2794 (compute_display_string_pos): Accept additional argument
2795 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2796 value of a `display' property is a "replacing spec".
2797 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2798 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2799 the display property, but just return a value indicating whether
2800 the display property will replace the characters it covers.
2801 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2802 frame_window_p members of struct bidi_it.
2803 (compute_display_string_pos, compute_display_string_end):
2805 (push_it): Accept second argument POSITION, where pop_it should
2806 jump to continue iteration.
2807 (reseat_1): Initialize bidi_it.disp_pos.
2809 * keyboard.c (adjust_point_for_property): Adjust the call to
2810 display_prop_intangible_p to its new signature.
2812 * dispextern.h (struct bidi_it): New member frame_window_p.
2813 (bidi_init_it): Update prototypes.
2814 (display_prop_intangible_p): Update prototype.
2815 (compute_display_string_pos, compute_display_string_end):
2817 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2820 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2822 Malloc failure behavior now depends on size of allocation.
2823 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2824 * lisp.h: Change signatures accordingly.
2825 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2826 All callers changed. (Bug#8762)
2828 * gnutls.c: Use Emacs's memory allocators.
2829 Without this change, the gnutls library would invoke malloc etc.
2830 directly, which causes problems on non-SYNC_INPUT hosts, and which
2831 runs afoul of improving memory_full behavior. (Bug#8761)
2832 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2833 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2834 xfree instead of the default malloc, realloc, free.
2835 (Fgnutls_boot): No need to check for memory allocation failure,
2836 since xmalloc does that for us.
2838 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2839 * category.c (hash_get_category_set):
2840 * ccl.c (ccl_driver):
2841 * charset.c (Fdefine_charset_internal):
2842 * charset.h (struct charset.hash_index):
2843 * composite.c (get_composition_id, gstring_lookup_cache)
2844 (composition_gstring_put_cache):
2845 * composite.h (struct composition.hash_index):
2846 * dispextern.h (struct image.hash):
2847 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2848 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2849 (hashfn_equal, hashfn_user_defined, make_hash_table)
2850 (maybe_resize_hash_table, hash_lookup, hash_put)
2851 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2852 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2853 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2854 * image.c (make_image, search_image_cache, lookup_image)
2855 (xpm_put_color_table_h):
2856 * lisp.h (struct Lisp_Hash_Table):
2857 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2858 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2859 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2860 * alloc.c (allocate_vectorlike):
2861 Check for overflow in vector size calculations.
2862 * ccl.c (ccl_driver):
2863 Check for overflow when converting EMACS_INT to int.
2864 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2865 need to be updated by these changes.
2866 * fns.c (make_hash_table, maybe_resize_hash_table):
2867 Check for integer overflow with large hash tables.
2868 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2869 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2870 (SXHASH_REDUCE): New macro.
2871 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2872 Use it instead of discarding useful hash info with large hash values.
2873 (sxhash_float): New function.
2874 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2875 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2876 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2877 Rewrite to use FIXNUM_BITS, as this simplifies things.
2878 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2879 Adjust signatures to match updated version of code.
2880 (consing_since_gc): Now EMACS_INT, since a single hash table can
2881 use more than INT_MAX bytes.
2883 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2885 Make it possible to build with GCC-4.6+ -O2 -flto.
2887 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2889 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2891 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2892 Call minibuffer-inactive-mode.
2894 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2896 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2897 Update dependencies.
2899 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2901 * data.c (init_data): Remove code for UTS, this system is not
2904 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2906 Don't force ./temacs to start in terminal mode.
2908 * frame.c (make_initial_frame): Initialize faces in all cases, not
2909 only when CANNOT_DUMP is defined.
2910 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2912 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2914 * dispnew.c (add_window_display_history): Use const for the string
2915 pointer. Remove declaration, not needed.
2917 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2919 Use 'inline', not 'INLINE'.
2920 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2921 * alloc.c, fontset.c (INLINE): Remove.
2922 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2923 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2924 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2925 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2926 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2928 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2930 Make it possible to run ./temacs.
2932 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2933 syms_of_callproc does the same thing. Remove test for
2934 "initialized", do it in the caller.
2935 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2937 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2939 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2940 (read_minibuf): Use get_minibuffer.
2941 (syms_of_minibuf): Use DEFSYM.
2942 (Qmetadata): New var.
2943 * data.c (Qbuffer): Don't make it static.
2944 (syms_of_data): Use DEFSYM.
2946 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2948 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2949 (CCL_CODE_MIN): New macro.
2951 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2953 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2955 * eval.c (Qdebug): Now static.
2956 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2957 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2958 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2960 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2962 * image.c: Various fixes to ImageMagick code comments.
2963 (Fimagemagick_types): Doc fix.
2965 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2967 Minor fixes prompted by GCC 4.6.0 warnings.
2969 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2971 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2972 (x_clipboard_manager_save_all): Move extern decl to ...
2973 * xterm.h: ... here, so that it can be checked for consistency.
2975 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2977 * xselect.c (x_clipboard_manager_save_frame)
2978 (x_clipboard_manager_save_all): New functions.
2979 (Fx_clipboard_manager_save): Lisp function deleted.
2981 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2982 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2984 * xterm.h: Update prototype.
2986 2011-05-28 William Xu <william.xwl@gmail.com>
2988 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2991 2011-05-28 Jim Meyering <meyering@redhat.com>
2993 Avoid a sign-extension bug in crypto_hash_function.
2994 * fns.c (to_uchar): Define.
2995 (crypto_hash_function): Use it to convert some newly-signed
2996 variables to unsigned, to avoid sign-extension bugs. For example,
2997 without this change, (md5 "truc") would evaluate to
2998 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2999 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3000 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3002 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3004 Integer overflow fixes.
3006 * dbusbind.c: Serial number integer overflow fixes.
3007 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3008 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3009 to hold a serial number that is too large for a fixnum.
3010 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3011 Check for serial numbers out of range. Decode any serial number
3012 that was so large that it became a float. (Bug#8722)
3014 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3015 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3016 Use XFASTINT rather than XUINT when numbers are nonnegative.
3017 (xd_append_arg, Fdbus_method_return_internal):
3018 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3019 arguments, check that Lisp number is nonnegative, rather than
3020 silently wrapping negative numbers around. (Bug#8722)
3021 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3024 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3026 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3028 ccl: add integer overflow checks
3029 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3030 (IN_INT_RANGE): New macros.
3031 (ccl_driver): Use them to check for integer overflow when
3032 decoding a CCL program. Many of the new checks are whether XINT (x)
3033 fits in int; it doesn't always, on 64-bit hosts. The new version
3034 doesn't catch all possible integer overflows, but it's an
3035 improvement. (Bug#8719)
3037 * alloc.c (make_event_array): Use XINT, not XUINT.
3038 There's no need for unsigned here.
3040 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3041 This follows up to the 2011-05-06 change that substituted uintptr_t
3042 for EMACS_INT. This case wasn't caught back then.
3044 Rework Fformat to avoid integer overflow issues.
3045 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3046 now (part of C89). Include <verify.h>.
3047 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3048 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3049 (Fformat): Avoid the prepass trying to compute sizes; it was only
3050 approximate and thus did not catch overflow reliably. Instead, walk
3051 through the format just once, formatting and computing sizes as we go,
3052 checking for integer overflow at every step, and allocating a larger
3053 buffer as needed. Keep track separately whether the format is
3054 multibyte. Keep only the most-recently calculated precision, rather
3055 than them all. Record whether each argument has been converted to
3056 string. Use EMACS_INT, not int, for byte and char and arg counts.
3057 Support field widths and precisions larger than INT_MAX. Avoid
3058 sprintf's undefined behavior with conversion specifications such as %#d
3059 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3060 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3061 formatting out-of-range floating point numbers with int
3064 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3066 * data.c: Avoid integer truncation in expressions involving floats.
3067 * data.c: Include <intprops.h>.
3068 (arith_driver): When there's an integer overflow in an expression
3069 involving floating point, convert the integers to floating point
3070 so that the resulting value does not suffer from catastrophic
3071 integer truncation. For example, on a 64-bit host (* 4
3072 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3073 Do not rely on undefined behavior after integer overflow.
3075 merge count_size_as_multibyte, parse_str_to_multibyte
3076 * character.c, character.h (count_size_as_multibyte):
3077 Rename from parse_str_to_multibyte; all uses changed.
3078 Check for integer overflow.
3079 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3080 since it's now a duplicate of the other. This is more of
3081 a character than a buffer op, so better that it's in character.c.
3082 * fns.c, print.c: Adjust to above changes.
3084 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3086 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3088 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3090 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3091 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3092 (x_clipboard_manager_save): Now static.
3093 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3095 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3096 (crypto_hash_function): Now static.
3097 Fix pointer signedness problems. Avoid unnecessary initializations.
3099 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3101 * termhooks.h (Vselection_alist): Make it terminal-local.
3103 * terminal.c (create_terminal): Initialize it.
3105 * xselect.c: Support for clipboard managers.
3106 (Vselection_alist): Move to termhooks.h as terminal-local var.
3107 (LOCAL_SELECTION): New macro.
3108 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3109 (symbol_to_x_atom): Remove gratuitous arg.
3110 (x_handle_selection_request, lisp_data_to_selection_data)
3111 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3112 (x_own_selection, x_get_local_selection, x_convert_selection):
3113 New arg, specifying work frame. Use terminal-local Vselection_alist.
3114 (some_frame_on_display): Delete unused function.
3115 (Fx_own_selection_internal, Fx_get_selection_internal)
3116 (Fx_disown_selection_internal, Fx_selection_owner_p)
3117 (Fx_selection_exists_p): New optional frame arg.
3118 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3119 (x_handle_selection_clear): Don't treat other terminals with the
3120 same keyboard specially. Use the terminal-local Vselection_alist.
3121 (x_clear_frame_selections): Use Frun_hook_with_args.
3123 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3125 * xterm.h: Add support for those atoms.
3127 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3129 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3130 (converted_selections, conversion_fail_tag): New global variables.
3131 (x_selection_request_lisp_error): Free the above.
3132 (x_get_local_selection): Remove unnecessary code.
3133 (x_reply_selection_request): Args changed; handle arbitrary array
3134 of converted selections stored in converted_selections.
3135 Separate the XChangeProperty and SelectionNotify steps.
3136 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3137 (x_convert_selection): New function.
3138 (x_handle_selection_event): Simplify.
3139 (x_get_foreign_selection): Don't ignore incoming requests while
3140 waiting for an answer; this will fail when we implement
3141 SAVE_TARGETS, and seems unnecessary anyway.
3142 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3143 (Vx_sent_selection_functions): Doc fix.
3145 2011-05-26 Leo Liu <sdl.web@gmail.com>
3147 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3149 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3151 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3153 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3154 for fringe update if it has periodic bitmap.
3155 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3156 and fringe_bitmap_periodic_p.
3158 * fringe.c (get_fringe_bitmap_data): New function.
3159 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3160 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3161 row. Mark glyph row for fringe update if periodicity changed.
3163 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3164 for fringe update unless it has periodic bitmap.
3166 2011-05-25 Kenichi Handa <handa@m17n.org>
3168 * xdisp.c (get_next_display_element): Set correct it->face_id for
3169 a static composition.
3171 2011-05-24 Leo Liu <sdl.web@gmail.com>
3174 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3176 * fns.c (crypto_hash_function, Fsha1): New function.
3177 (Fmd5): Use crypto_hash_function.
3178 (syms_of_fns): Add Ssha1.
3180 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3182 * gnutls.c: Remove unused macros.
3183 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3184 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3185 Remove macros that are defined and never used.
3186 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3188 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3190 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3191 (Fx_get_selection_internal): Minor cleanup.
3192 (Fx_own_selection_internal): Rename arguments for consistency with
3195 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3197 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3199 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3201 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3203 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3205 * dispnew.c (scrolling_window): Don't exclude the case that the
3206 last enabled row in the desired matrix touches the bottom boundary.
3208 2011-05-21 Glenn Morris <rgm@gnu.org>
3210 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3211 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3212 and add some more files.
3214 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3216 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3217 report_file_error introduced by the change from 2011-05-07.
3219 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3221 * systime.h (Time): Define only if emacs is defined.
3222 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3223 where the include path doesn't have X11/X.h by default. See
3224 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3226 2011-05-20 Kenichi Handa <handa@m17n.org>
3228 * composite.c (find_automatic_composition): Fix previous change.
3230 2011-05-20 Glenn Morris <rgm@gnu.org>
3232 * lisp.mk: New file, split from Makefile.in.
3233 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3234 (shortlisp): Remove.
3235 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3237 2011-05-19 Glenn Morris <rgm@gnu.org>
3239 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3240 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3241 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3242 (lisp): Set the order to that of loadup.el.
3243 (shortlisp): Make it a copy of $lisp.
3244 (SOME_MACHINE_LISP): Remove.
3245 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3246 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3248 2011-05-18 Kenichi Handa <handa@m17n.org>
3250 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3251 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3252 (find_automatic_composition): Mostly rewrite for efficiency.
3254 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3256 * makefile.w32-in: Update dependencies.
3258 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3260 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3261 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3263 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3265 Fix some integer overflow issues, such as string length overflow.
3267 * insdel.c (count_size_as_multibyte): Check for string overflow.
3269 * character.c (lisp_string_width): Check for string overflow.
3270 Use EMACS_INT, not int, for string indexes and lengths; in
3271 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3272 the resulting string length overflows an EMACS_INT; instead,
3273 report a string overflow if no precision given. When checking for
3274 precision exhaustion, use a check that cannot possibly have
3275 integer overflow. (Bug#8675)
3276 * character.h (lisp_string_width): Adjust to new signature.
3278 * alloc.c (string_overflow): New function.
3279 (Fmake_string): Use it. This doesn't change behavior, but saves
3280 a few bytes and will simplify future changes.
3281 * character.c (string_escape_byte8): Likewise.
3282 * lisp.h (string_overflow): New decl.
3284 Fixups, following up to the user-interface timestamp change.
3285 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3286 for UI timestamps, instead of unsigned long.
3287 * msdos.c (mouse_get_pos): Likewise.
3288 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3289 * w32gui.h (Time): Define by including "systime.h" rather than by
3290 declaring it ourselves. (Bug#8664)
3292 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3293 * image.c (clear_image_cache): Likewise.
3295 * term.c (term_mouse_position): Don't assume time_t wraparound.
3297 Be more systematic about user-interface timestamps.
3298 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3299 and sometimes 'EMACS_UINT', to represent these timestamps.
3300 This change causes it to use 'Time' uniformly, as that's what X uses.
3301 This makes the code easier to follow, and makes it easier to catch
3302 integer overflow bugs such as Bug#8664.
3303 * frame.c (Fmouse_position, Fmouse_pixel_position):
3304 Use Time, not unsigned long, for user-interface timestamps.
3305 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3306 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3307 * keyboard.h (last_event_timestamp): Likewise.
3308 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3309 * menu.h (xmenu_show): Likewise.
3310 * term.c (term_mouse_position): Likewise.
3311 * termhooks.h (struct input_event.timestamp): Likewise.
3312 (struct terminal.mouse_position_hook): Likewise.
3313 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3314 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3315 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3316 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3318 * menu.h, termhooks.h: Include "systime.h", for Time.
3320 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3321 Don't assume that the difference between two unsigned long values
3322 can fit into an integer. At this point, we know button_down_time
3323 <= event->timestamp, so the difference must be nonnegative, so
3324 there's no need to cast the result if double-click-time is
3325 nonnegative, as it should be; check that it's nonnegative, just in
3326 case. This bug is triggered when events are more than 2**31 ms
3327 apart (about 25 days). (Bug#8664)
3329 * xselect.c (last_event_timestamp): Remove duplicate decl.
3330 (x_own_selection): Remove needless cast to unsigned long.
3332 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3333 that always fit in int. Use a sentinel instead of a counter, to
3334 avoid a temp and to allay GCC's concerns about possible int overflow.
3335 * frame.h (struct frame): Use int for menu_bar_items_used
3336 instead of EMACS_INT, since it always fits in int.
3338 * menu.c (grow_menu_items): Check for int overflow.
3340 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3342 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3343 Before, the code was not consistent. These values cannot exceed
3344 2**31 - 1 so there's no need to make them unsigned.
3345 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3346 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3347 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3349 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3351 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3352 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3353 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3354 presumably because the widths might not match.
3356 * window.c (size_window): Avoid needless test at loop start.
3358 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3360 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3362 2011-05-12 Drew Adams <drew.adams@oracle.com>
3364 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3366 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3368 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3369 `width' to `bar_area_x' and `bar_area_width', respectively.
3370 (x_scroll_run): Take account of fringe background extension.
3372 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3373 Rename local vars `left' and `width' to `bar_area_x' and
3374 `bar_area_width', respectively.
3375 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3376 background extension.
3378 2011-05-10 Jim Meyering <meyering@redhat.com>
3380 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3382 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3384 * image.c (Finit_image_library): Return t for built-in image types,
3385 like pbm and xbm. (Bug#8640)
3387 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3389 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3391 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3393 * w32console.c (Fset_screen_color): Doc fix.
3394 (Fget_screen_color): New function.
3395 (syms_of_ntterm): Defsubr it.
3397 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3398 unlink the temporary file if Fcall_process didn't create it in the
3400 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3401 child process will be redirected to a file specified with `:file'.
3402 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3403 cue to call_process_cleanup not to close that handle.
3405 2011-05-07 Ben Key <bkey76@gmail.com>
3407 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3408 one of two shell specific rules, either bootstrap-temacs-CMD or
3409 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3410 to the previous implementation of the bootstrap-temacs rule.
3411 The bootstrap-temacs-CMD rule is similar to the previous
3412 implementation of the bootstrap-temacs rule except that it
3413 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3416 These changes, along with some changes to nt/configure.bat,
3417 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3418 earlier fix to add support for --cflags and --ldflags options
3419 that include quotes so that it works whether make uses cmd or
3422 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3424 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3425 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3427 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3428 a string. Handle both cases.
3429 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3430 (Fdbus_register_method): Use Qinvalid_function.
3432 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3434 * makefile.w32-in: Update dependencies.
3435 (LISP_H): Add inttypes.h and stdin.h.
3436 (PROCESS_H): Add unistd.h.
3438 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3440 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3441 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3443 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3445 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3447 * term.c (vfatal): Remove stray call to va_end.
3448 It's not needed and the C Standard doesn't allow it here anyway.
3450 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3451 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3453 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3456 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3458 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3460 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3462 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3464 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3466 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3467 * charset.c (Fdefine_charset_internal): Don't initialize
3468 charset.code_space[15]. The value was garbage, on hosts with
3469 32-bit int (Bug#8600).
3471 * lread.c (read_integer): Be more consistent with string-to-number.
3472 Use string_to_number to do the actual conversion; this avoids
3473 rounding errors and fixes some other screwups. Without this fix,
3474 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3475 (digit_to_number): Move earlier, for benefit of read_integer.
3476 Return -1 if the digit is out of range for the base, -2 if it is
3477 not a digit in any supported base. (Bug#8602)
3479 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3481 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3482 to match comment at start of function. This also removes a
3483 GCC warning about overflow in a 32+64-bit port.
3485 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3487 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3488 Reported by Stefan Monnier in
3489 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3490 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3491 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3493 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3494 (EMACS_UINTPTR): Likewise, with uintptr_t.
3496 * lisp.h: Prefer 64-bit EMACS_INT if available.
3497 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3498 on 32-bit hosts that have 64-bit int, so that they can access
3500 However, temporarily disable this change unless the temporary
3501 symbol WIDE_EMACS_INT is defined.
3503 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3505 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3506 This removes an assumption that EMACS_INT and long are the same
3507 width as pointers. The assumption is true for Emacs porting targets
3508 now, but we want to make other targets possible.
3509 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3510 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3511 In the rest of the code, change types of integers that hold casted
3512 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3513 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3514 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3515 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3516 No need to cast type when ORing.
3517 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3518 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3519 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3520 assume EMACS_INT is the same width as char *.
3521 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3522 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3523 Remove no-longer-needed casts.
3524 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3525 (xg_tool_bar_help_callback, xg_make_tool_item):
3526 Use EMACS_INTPTR to hold an integer
3527 that will be cast to void *; this can avoid a GCC warning
3528 if EMACS_INT is not the same width as void *.
3529 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3530 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3531 (current_message_1, set_message_1):
3532 Use a local to convert to proper width without a cast.
3533 * xmenu.c (dialog_selection_callback): Likewise.
3535 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3536 Also, don't assume VALBITS / RAND_BITS is less than 5,
3537 and don't rely on undefined behavior when shifting a 1 left into
3539 * lisp.h (get_random): Change signature to match.
3541 * lread.c (hash_string): Use size_t, not int, for hash computation.
3542 Normally we prefer signed values; but hashing is special, because
3543 it's better to use unsigned division on hash table sizes so that
3544 the remainder is nonnegative. Also, size_t is the natural width
3545 for hashing into memory. The previous code used 'int', which doesn't
3546 retain enough info to hash well into very large tables.
3547 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3549 * dbusbind.c: Don't possibly lose pointer info when converting.
3550 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3551 Use XPNTR rather than XHASH, so that the high-order bits of
3552 the pointer aren't lost when converting through void *.
3554 * eval.c (Fautoload): Don't double-shift a pointer.
3556 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3558 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3560 * gnutls.c (DEF_GNUTLS_FN):
3561 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3563 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3565 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3568 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3570 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3571 New version that can reserve upto 2GB of heap space.
3573 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3575 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3577 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3579 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3580 `gnutls_certificate_set_x509_key_file'.
3582 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3584 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3585 Update dependencies.
3587 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3589 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3590 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3591 Remove unused parameter `fildes'.
3592 * process.c (read_process_output, send_process): Don't pass it.
3594 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3596 Fix previous change: the library cache is defined in w32.c.
3597 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3598 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3600 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3602 Implement dynamic loading of GnuTLS on Windows.
3604 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3605 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3606 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3609 * gnutls.c (Qgnutls_dll): Define.
3610 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3611 (gnutls_*): Declare function pointers.
3612 (init_gnutls_functions): New function to initialize function pointers.
3613 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3614 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3615 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3616 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3617 (emacs_gnutls_write, emacs_gnutls_read)
3618 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3619 (Fgnutls_available_p): New function.
3620 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3621 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3622 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3624 * image.c: Include w32.h.
3625 (Vimage_type_cache): Delete.
3626 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3627 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3628 (w32_delayed_load): Move to w32.c.
3630 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3632 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3633 (w32_delayed_load): Move from image.c. When loading a library, record
3634 its filename in the :loaded-from property of the library id.
3635 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3636 Initialize and staticpro them.
3637 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3639 * process.c: Include lisp.h before w32.h, not after.
3640 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3641 instead of gnutls_record_check_pending.
3643 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3645 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3647 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3648 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3651 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3653 * xterm.c (x_set_frame_alpha): Do not set property on anything
3654 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3656 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3658 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3660 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3662 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3663 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3664 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3665 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3666 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3667 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3668 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3669 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3670 (Qgnutls_bootprop_callbacks_verify): Make static.
3672 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3674 * callproc.c: Indentation fixup.
3676 * sysdep.c (wait_for_termination_1): Make static.
3677 (wait_for_termination, interruptible_wait_for_termination):
3678 Move after wait_for_termination_1.
3680 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3682 * sysdep.c (interruptible_wait_for_termination): New function
3683 which is like wait_for_termination, but allows keyboard
3686 * callproc.c (Fcall_process): Add (:file "file") as an option for
3688 (Fcall_process_region): Ditto.
3690 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3692 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3693 rather than `XVECTOR (FOO)->size'.
3695 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3696 inttypes.h, as a gnulib replacement is used if it not available in
3699 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3701 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3702 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3703 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3705 * coding.c (coding_alloc_by_realloc): Error out if destination
3706 will grow beyond MOST_POSITIVE_FIXNUM.
3707 (decode_coding_emacs_mule): Abort if there isn't enough place in
3708 charbuf for the composition carryover bytes. Reserve an extra
3709 space for up to 2 characters produced in a loop.
3710 (decode_coding_iso_2022): Abort if there isn't enough place in
3711 charbuf for the composition carryover bytes.
3713 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3715 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3716 aborting when %lld or %lll format is passed.
3717 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3718 %llo or %llx format is passed. (Bug#8545)
3720 * window.c (window_scroll_line_based): Use a marker instead of
3721 simple variables to record original value of point. (Bug#7952)
3723 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3724 produced by %s or %c overflows available buffer space. (Bug#8545)
3726 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3728 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3729 (SIZE_MAX): Move defn after all includes, as they might #define it.
3731 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3733 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3735 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3737 * keyboard.c (Qdelayed_warnings_hook): Define.
3738 (command_loop_1): Run `delayed-warnings-hook'
3739 if Vdelayed_warnings_list is non-nil.
3740 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3741 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3743 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3745 * doprnt.c (doprnt): Don't return value smaller than the buffer
3746 size if the message was truncated. (Bug#8545).
3748 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3750 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3751 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3753 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3755 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3757 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3759 * makefile.w32-in: Update dependencies.
3761 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3763 Improve `doprnt' and its usage. (Bug#8545)
3764 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3765 `format_end'. Remove support for %l as a conversion specifier.
3766 Don't use xrealloc. Improve diagnostics when the %l size modifier
3767 is used. Update the commentary.
3769 * eval.c (verror): Simplify calculation of size_t.
3771 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3774 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3776 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3779 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3781 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3782 This makes this file independent of the recent pseudovector change.
3784 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3786 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3788 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3789 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3790 Remove unused local.
3791 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3793 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3794 GCC 4.6.0 optimizes based on type-based alias analysis.
3795 For example, if b is of type struct buffer * and v of type struct
3796 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3797 != &v->size, and therefore "v->size = 1; b->size = 2; return
3798 v->size;" must therefore return 1. This assumption is incorrect
3799 for Emacs, since it type-puns struct Lisp_Vector * with many other
3800 types. To fix this problem, this patch adds a new type struct
3801 vectorlike_header that documents the constraints on layout of vectors
3802 and pseudovectors, and helps optimizing compilers not get fooled
3803 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3804 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3805 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3807 (XSETPVECTYPE): Rewrite in terms of new macro.
3808 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3809 This is a bit clearer, and further avoids the possibility of
3810 undesirable aliasing.
3811 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3812 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3813 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3814 since Lisp_Subr is a special case (no "next" field).
3815 (ASIZE): Now uses header.size rather than size.
3816 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3817 to avoid the hassle of writing XVECTOR (foo)->header.size.
3818 (struct vectorlike_header): New type.
3819 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3820 object, to help avoid aliasing.
3821 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3822 (SUBRP): Likewise, since Lisp_Subr is a special case.
3823 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3824 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3825 (struct Lisp_Hash_Table): Combine first two members into a single
3826 struct vectorlike_header member. All uses of "size" and "next" members
3827 changed to be "header.size" and "header.next".
3828 * buffer.h (struct buffer): Likewise.
3829 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3830 * frame.h (struct frame): Likewise.
3831 * process.h (struct Lisp_Process): Likewise.
3832 * termhooks.h (struct terminal): Likewise.
3833 * window.c (struct save_window_data, struct saved_window): Likewise.
3834 * window.h (struct window): Likewise.
3835 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3836 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3837 * buffer.c (init_buffer_once): Likewise.
3838 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3840 * process.c (Fformat_network_address): Use local var for size,
3843 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3845 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3846 * data.c (atof): Remove decl; no longer used or needed.
3847 (digit_to_number): Move to lread.c.
3848 (Fstring_to_number): Use new string_to_number function, to be
3849 consistent with how the Lisp reader treats infinities and NaNs.
3850 Do not assume that floating-point numbers represent EMACS_INT
3851 without losing information; this is not true on most 64-bit hosts.
3852 Avoid double-rounding errors, by insisting on integers when
3853 parsing non-base-10 numbers, as the documentation specifies.
3854 * lisp.h (string_to_number): New decl, replacing ...
3855 (isfloat_string): Remove.
3856 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3857 (read1): Do not accept +. and -. as integers; this
3858 appears to have been a coding error. Similarly, do not accept
3859 strings like +-1e0 as floating point numbers. Do not report
3860 overflow for integer overflows unless the base is not 10 which
3861 means we have no simple and reliable way to continue.
3862 Break out the floating-point parsing into a new
3863 function string_to_number, so that Fstring_to_number parses
3864 floating point numbers consistently with the Lisp reader.
3865 (digit_to_number): Move here from data.c. Make it static inline.
3866 (E_CHAR, EXP_INT): Remove, replacing with ...
3867 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3868 (string_to_number): New function, replacing isfloat_string.
3869 This function checks for valid syntax and produces the resulting
3870 Lisp float number too. Rework it so that string-to-number
3871 no longer mishandles examples like "1.0e+". Use strtoumax,
3872 so that overflow for non-base-10 numbers is reported only when
3873 there's no portable and simple way to convert to floating point.
3875 * textprop.c (set_text_properties_1): Rewrite for clarity,
3876 and to avoid GCC warning about integer overflow.
3878 * intervals.h (struct interval): Use EMACS_INT for members
3879 where EMACS_UINT might cause problems. See
3880 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3881 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3882 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3884 (offset_intervals): Tell GCC not to worry about length overflow
3885 when negating a negative length.
3887 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3888 (overrun_check_free): Likewise.
3890 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3891 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3894 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3895 (gnutls_make_error): Rename local to avoid shadowing.
3896 (gnutls_emacs_global_deinit): ifdef out; not used.
3897 (Fgnutls_boot): Use const for pointer to readonly storage.
3898 Comment out unused local. Fix pointer signedness problems.
3900 * lread.c (openp): Don't stuff size_t into an 'int'.
3901 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3902 about possible signed overflow.
3904 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3905 (GDK_KEY_g): Don't define if already defined.
3906 (xg_prepare_tooltip): Avoid pointer signedness problem.
3907 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3909 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3910 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3912 * xfns.c (Fx_window_property): Simplify a bit,
3913 to make a bit faster and to avoid GCC 4.6.0 warning.
3914 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3916 * fns.c (internal_equal): Don't assume size_t fits in int.
3918 * alloc.c (compact_small_strings): Tighten assertion a little.
3920 Replace pEd with more-general pI, and fix some printf arg casts.
3921 * lisp.h (pI): New macro, generalizing old pEd macro to other
3922 conversion specifiers. For example, use "...%"pI"d..." rather
3923 than "...%"pEd"...".
3924 (pEd): Remove. All uses replaced with similar uses of pI.
3925 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3926 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3927 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3928 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3929 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3930 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3931 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3933 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3934 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3935 * print.c (safe_debug_print, print_object): Likewise.
3936 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3938 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3939 avoiding the 0 flag, which is not portable.
3940 * process.c (Fmake_network_process): Use pI to avoid cast.
3941 * region-cache.c (pp_cache): Likewise.
3942 * xdisp.c (decode_mode_spec): Likewise.
3943 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3944 behavior on 64-bit hosts with printf arg.
3945 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3946 (x_stop_queuing_selection_requests): Likewise.
3947 (x_get_window_property): Don't truncate byte count to an 'int'
3950 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3951 here, since it parses constructs like leading '-' and spaces,
3952 which are not wanted; and it overflows with large numbers.
3953 Instead, simply match F[0-9]+, which is what is wanted anyway.
3955 * alloc.c: Remove unportable assumptions about struct layout.
3956 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3957 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3958 (allocate_vectorlike, make_pure_vector): Use the new macros,
3959 plus offsetof, to remove unportable assumptions about struct layout.
3960 These assumptions hold on all porting targets that I know of, but
3961 they are not guaranteed, they're easy to remove, and removing them
3962 makes further changes easier.
3964 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3965 This doesn't fix a bug but makes the code clearer.
3966 (string_overrun_cookie): Now const. Use initializers that
3967 don't formally overflow signed char, to avoid warnings.
3968 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3969 can cause Emacs to crash when string overrun checking is enabled.
3970 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3971 multiple of sizeof (EMACS_INT); it need not be, if
3972 alignof(EMACS_INT) < sizeof (EMACS_INT).
3973 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3975 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3977 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3979 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3981 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3982 supposed to be handshaking. (Bug#8556)
3983 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3985 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3987 * lisp.h (Qdebug): List symbol.
3988 * eval.c (Qdebug): Restore global linkage.
3989 * keyboard.c (debug-on-event): New variable.
3990 (handle_user_signal): Break into debugger when debug-on-event
3991 matches the current signal symbol.
3993 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3995 * alloc.c (check_sblock, check_string_bytes)
3996 (check_string_free_list): Convert to standard C.
3998 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4000 * w32.c (emacs_gnutls_push): Fix typo.
4002 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4004 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4005 "cast to pointer from integer of different size".
4007 Improve doprnt and its use in verror. (Bug#8545)
4008 * doprnt.c (doprnt): Document the set of format control sequences
4009 supported by the function. Use SAFE_ALLOCA instead of always
4012 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4013 is one byte too soon. Don't use xrealloc; instead xfree and
4016 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4018 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4021 * gnutls.c: Renamed global_initialized to
4022 gnutls_global_initialized. Added internals for the
4023 :verify-hostname-error, :verify-error, and :verify-flags
4024 parameters of `gnutls-boot' and documented those parameters in the
4025 docstring. Start callback support.
4026 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4027 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4028 on error. Return error code.
4029 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4030 (emacs_gnutls_read): Likewise.
4031 (Fgnutls_boot): Return handshake error code.
4032 (emacs_gnutls_handle_error): New function.
4033 (wsaerror_to_errno): Likewise.
4035 * w32.h (emacs_gnutls_pull): Add prototype.
4036 (emacs_gnutls_push): Likewise.
4038 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4039 (emacs_gnutls_push): Likewise.
4041 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4043 * process.c (wait_reading_process_output): Check if GnuTLS
4044 buffered some data internally if no FDs are set for TLS
4047 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4048 (LIBS): Link to USER_LIBS.
4049 ($(BLD)/gnutls.$(0)): New target.
4051 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4053 * xdisp.c (handle_single_display_spec): Rename the
4054 display_replaced_before_p argument into display_replaced_p, to
4055 make it consistent with the commentary. Fix typos in the
4058 * textprop.c (syms_of_textprop): Remove dead code.
4059 (copy_text_properties): Delete obsolete commentary about an
4060 interface that was deleted long ago. Fix typos in the description
4063 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4064 to changes in oldXMenu/XMenu.h from 2011-04-16.
4065 <menu_help_message, prev_menu_help_message>: Constify.
4066 (IT_menu_make_room): menu->help_text is now `const char **';
4069 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4070 to changes in oldXMenu/XMenu.h from 2011-04-16.
4071 (struct XMenu): Declare `help_text' `const char **'.
4073 * xfaces.c <Qunspecified>: Make extern again.
4075 * syntax.c: Include sys/types.h before including regex.h, as
4078 * doc.c (get_doc_string): Improve the format passed to `error'.
4080 * doprnt.c (doprnt): Improve commentary.
4082 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4084 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4087 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4088 changes in globals.h immediately force recompilation.
4089 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4090 $(CURDIR)/s/ms-w32.h.
4091 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4093 * character.c (Fchar_direction): Function deleted.
4094 (syms_of_character): Don't defsubr it.
4095 <char-direction-table>: Deleted.
4097 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4099 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4100 * doprnt.c: Include limits.h.
4101 (SIZE_MAX): New macro.
4102 (doprnt): Return a size_t value. 2nd arg is now size_t.
4103 Many local variables are now size_t instead of int or unsigned.
4104 Improve overflow protection. Support `l' modifier for integer
4105 conversions. Support %l conversion. Don't assume an EMACS_INT
4106 argument for integer conversions and for %c.
4108 * lisp.h (doprnt): Restore prototype.
4110 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4113 * Makefile.in (base_obj): Add back doprnt.o.
4115 * deps.mk (doprnt.o): Add back prerequisites.
4116 (callint.o): Depend on character.h.
4118 * eval.c (internal_lisp_condition_case): Include the handler
4119 representation in the error message.
4120 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4121 when breaking from the loop.
4123 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4125 * callint.c (Fcall_interactively): When displaying error message
4126 about invalid control letter, pass the character's codepoint, not
4127 a pointer to its multibyte form. Improve display of the character
4128 in octal and display also its hex code.
4130 * character.c (char_string): Use %x to display the (unsigned)
4131 codepoint of an invalid character, to avoid displaying a bogus
4134 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4135 `error', not SYMBOL_NAME itself.
4137 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4138 character arguments to `error'.
4140 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4141 to `error' in error message about FINAL_CHAR argument. Make sure
4142 FINAL_CHAR is a character, and use %c when it is passed as
4143 argument to `error'.
4145 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4147 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4149 * w32.c: Include <time.h>.
4150 (sys_localtime): New function.
4152 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4154 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4156 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4158 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4160 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4163 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4165 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4166 gl_state.e_property when gl_state.object is Qt.
4168 * insdel.c (make_gap_larger): Remove limitation of buffer size
4171 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4173 * xdisp.c (lookup_glyphless_char_display)
4174 (produce_glyphless_glyph): Handle cons cell entry in
4175 glyphless-char-display.
4176 (Vglyphless_char_display): Document it.
4178 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4179 glyphless-char-display.
4181 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4183 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4185 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4187 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4188 definition for no-X builds.
4190 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4192 Static checks with GCC 4.6.0 and non-default toolkits.
4194 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4196 * process.c (keyboard_bit_set): Define only if SIGIO.
4197 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4198 (send_process): Repair possible setjmp clobbering.
4200 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4202 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4204 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4206 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4207 Define only if needed.
4209 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4210 by pacifying GCC about it. Maybe it's time to retire it?
4211 * xfaces.c (USG, __TIMEVAL__): Likewise.
4213 * dispextern.h (struct redisplay_interface): Rename param
4215 * termhooks.h (struct terminal): Likewise.
4216 * xterm.c (xembed_send_message): Likewise.
4218 * insdel.c (make_gap_smaller): Define only if
4219 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4221 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4224 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4225 so that we aren't warned about unused symbols.
4227 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4229 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4231 * xfns.c (x_real_positions): Mark locals as initialized.
4233 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4235 * xterm.c: Fix problems found by static analysis with other toolkits.
4236 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4237 (x_dispatch_event): Declare static if USE_GTK, and
4238 define if USE_GTK || USE_X_TOOLKIT.
4239 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4240 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4241 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4242 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4244 * xmenu.c (menu_help_callback): Pointer type fixes.
4245 Use const pointers when pointing at readonly data. Avoid pointer
4247 (FALSE): Remove unused macro.
4248 (update_frame_menubar): Remove unused decl.
4250 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4252 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4253 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4254 (single_menu_item): Rename local to avoid shadowing.
4256 * keyboard.c (make_lispy_event): Remove unused local var.
4258 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4259 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4261 * bitmaps: Change bitmaps from unsigned char back to the X11
4262 compatible char. Avoid the old compiler warnings about
4263 out-of-range initializers by using, for example, '\xab' rather
4266 * xgselect.c (xgselect_initialize): Check vs interface
4267 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4269 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4271 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4272 to read-only memory.
4274 * fns.c (vector): Remove; this old hack is no longer needed.
4276 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4278 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4280 * xrdb.c (x_load_resources): Omit unused local.
4282 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4283 (x_window): Rename locals to avoid shadowing.
4284 (USG): Use the kludged USG macro, to pacify gcc.
4286 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4287 (x_term_init): Remove local to avoid shadowing.
4289 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4291 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4292 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4294 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4296 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4298 Fix regex.c, syntax.c and friends for buffers > 2GB.
4299 * syntax.h (struct gl_state_s): Declare character position members
4302 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4304 * textprop.c (verify_interval_modification, interval_of):
4305 Declare arguments EMACS_INT.
4307 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4310 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4312 * indent.c (Fvertical_motion): Local variable it_start is now
4315 * regex.c (re_match, re_match_2, re_match_2_internal)
4316 (bcmp_translate, regcomp, regexec, print_double_string)
4317 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4318 (re_compile_pattern, re_exec): Declare arguments and local
4319 variables `size_t' and `ssize_t' and return values `regoff_t', as
4321 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4322 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4323 <compile_stack_type>: `size' and `avail' are now `size_t'.
4325 * regex.h <regoff_t>: Use ssize_t, not int.
4326 (re_search, re_search_2, re_match, re_match_2): Arguments that
4327 specify buffer/string position and length are now ssize_t and
4328 size_t. Return type is regoff_t.
4330 2011-04-16 Ben Key <bkey76@gmail.com>
4332 * nsfont.m: Fixed bugs in ns_get_family and
4333 ns_descriptor_to_entity that were caused by using free to
4334 deallocate memory blocks that were allocated by xmalloc (via
4335 xstrdup). This caused Emacs to crash when compiled with
4336 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4337 --enable-checking=xmallocoverrun). xfree is now used to
4338 deallocate these memory blocks.
4340 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4342 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4344 emacs_write: Accept and return EMACS_INT for sizes.
4345 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4347 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4348 Accept and return EMACS_INT.
4349 (emacs_gnutls_write): Return the number of bytes written on
4351 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4352 (emacs_read, emacs_write): Remove check for negative size, as the
4353 Emacs source code has been audited now.
4354 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4355 (emacs_read, emacs_write): Use it.
4356 * process.c (send_process): Adjust to the new signatures of
4357 emacs_write and emacs_gnutls_write. Do not attempt to store
4358 a byte offset into an 'int'; it might overflow.
4359 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4361 * sound.c: Don't assume sizes fit in 'int'.
4362 (struct sound_device.period_size, alsa_period_size):
4363 Return EMACS_INT, not int.
4364 (struct sound_device.write, vox_write, alsa_write):
4365 Accept EMACS_INT, not int.
4366 (wav_play, au_play): Use EMACS_INT to store sizes and to
4367 record read return values.
4369 2011-04-15 Ben Key <bkey76@gmail.com>
4371 * keyboard.c (Qundefined): Don't declare static since it is used
4373 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4374 static since they are used in nsfont.m.
4376 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4378 * process.c (Qprocessp): Don't declare static.
4379 * lisp.h (Qprocessp): Declare again.
4381 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4383 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4385 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4387 Improve C-level modularity by making more things 'static'.
4389 Don't publish debugger-only interfaces to other modules.
4390 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4391 (verify_bytepos, count_markers): Move decls to the only modules
4393 * region-cache.h (pp_cache): Likewise.
4394 * window.h (check_all_windows): Likewise.
4395 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4397 * sysdep.c (croak): Now static, if
4398 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4399 * syssignal.h (croak): Declare only if not static.
4401 * alloc.c (refill_memory_reserve): Now static if
4402 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4403 * lisp.h (refill_memory_reserve): Declare only if not static.
4405 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4406 Define only if USE_LUCID.
4408 * xrdb.c (x_customization_string, x_rm_string): Now static.
4410 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4411 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4413 * xdisp.c (draw_row_with_mouse_face): Now static.
4414 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4416 * window.h (check_all_windows): Mark externally visible.
4418 * window.c (window_deletion_count): Now static.
4420 * undo.c: Make symbols static if they're not exported.
4421 (last_undo_buffer, last_boundary_position, pending_boundary):
4424 * textprop.c (interval_insert_behind_hooks): Now static.
4425 (interval_insert_in_front_hooks): Likewise.
4427 * term.c: Make symbols static if they're not exported.
4428 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4429 (max_frame_lines, tty_set_terminal_modes):
4430 (tty_reset_terminal_modes, tty_turn_off_highlight):
4431 (get_tty_terminal): Now static.
4432 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4433 * termhooks.h (term_mouse_moveto): Do not declare if
4435 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4436 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4438 * sysdep.c: Make symbols static if they're not exported.
4439 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4441 (sigprocmask_set, full_mask): Remove; unused.
4442 (wait_debugging): Mark as visible.
4443 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4444 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4446 * syntax.c (syntax_temp): Define only if !__GNUC__.
4448 * sound.c (current_sound_device, current_sound): Now static.
4450 * search.c (searchbufs, searchbuf_head): Now static.
4452 * scroll.c (scroll_cost): Remove; unused.
4453 * dispextern.h (scroll_cost): Remove decl.
4455 * region-cache.h (pp_cache): Mark as externally visible.
4457 * process.c: Make symbols static if they're not exported.
4458 (process_tick, update_tick, create_process, chan_process):
4459 (Vprocess_alist, proc_buffered_char, datagram_access):
4460 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4461 (deactivate_process): Mark defn as static, as well as decl.
4462 * lisp.h (create_process): Remove decl.
4463 * process.h (chan_process, Vprocess_alist): Remove decls.
4465 * print.c: Make symbols static if they're not exported.
4466 (print_depth, new_backquote_output, being_printed, print_buffer):
4467 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4468 (print_interval, print_number_index, initial_stderr_stream):
4470 * lisp.h (Fprinc): Remove decl.
4471 (debug_output_compilation_hack): Mark as externally visible.
4473 * sysdep.c (croak): Move decl from here to syssignal.h.
4474 * syssignal.h (croak): Put it here, so the API can be checked when
4475 'croak' is called from dissociate_if_controlling_tty.
4477 * minibuf.c: Make symbols static if they're not exported.
4478 (minibuf_save_list, choose_minibuf_frame): Now static.
4479 * lisp.h (choose_minibuf_frame): Remove decl.
4481 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4483 * lread.c: Make symbols static if they're not exported.
4484 (read_objects, initial_obarray, oblookup_last_bucket_number):
4486 (make_symbol): Remove; unused.
4487 * lisp.h (initial_obarray, make_symbol): Remove decls.
4489 * keyboard.c: Make symbols static if they're not exported.
4490 (single_kboard, recent_keys_index, total_keys, recent_keys):
4491 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4492 (this_single_command_key_start, echoing, last_auto_save):
4493 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4494 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4495 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4496 (Vlispy_mouse_stem, double_click_count):
4498 (force_auto_save_soon): Define only if SIGDANGER.
4499 (ignore_mouse_drag_p): Now static if
4500 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4501 (print_help): Remove; unused.
4502 (stop_character, last_timer_event): Mark as externally visible.
4503 * keyboard.h (ignore_mouse_drag_p): Declare only if
4504 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4505 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4506 * lisp.h (echoing): Remove decl.
4507 (force_auto_save_soon): Declare only if SIGDANGER.
4508 * xdisp.c (redisplay_window): Simplify code, to make it more
4509 obvious that ignore_mouse_drag_p is not accessed if !defined
4510 USE_GTK && !defined HAVE_NS.
4512 * intervals.c: Make symbols static if they're not exported.
4513 (merge_properties_sticky, merge_interval_right, delete_interval):
4515 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4517 * insdel.c: Make symbols static if they're not exported.
4518 However, leave prepare_to_modify_buffer alone. It's never
4519 called from outside this function, but that appears to be a bug.
4520 (combine_after_change_list, combine_after_change_buffer):
4521 (adjust_after_replace, signal_before_change): Now static.
4522 (adjust_after_replace_noundo): Remove; unused.
4523 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4524 (signal_before_change): Remove decls.
4526 * indent.c (val_compute_motion, val_vmotion): Now static.
4528 * image.c: Make symbols static if they're not exported.
4529 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4531 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4532 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4534 * fringe.c (standard_bitmaps): Now static.
4535 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4537 * frame.c: Make symbols static if they're not exported.
4538 (x_report_frame_params, make_terminal_frame): Now static.
4539 (get_frame_param): Now static, unless HAVE_NS.
4540 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4541 (x_get_resource_string): Remove; not used.
4542 * frame.h (make_terminal_frame, x_report_frame_params):
4543 (x_get_resource_string); Remove decls.
4544 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4545 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4547 * font.c, fontset.c: Make symbols static if they're not exported.
4548 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4549 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4550 * font.c (font_close_object): Now static.
4551 * font.h (font_close_object): Remove.
4552 * fontset.c (FONTSET_OBJLIST): Remove.
4553 (free_realized_fontset) #if-0 the body, which does nothing.
4554 (face_suitable_for_char_p): #if-0, as it's never called.
4555 * fontset.h (face_suitable_for_char_p): Remove decl.
4556 * xfaces.c (face_at_string_position):
4557 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4558 since 0 is always ASCII.
4560 * fns.c (weak_hash_tables): Now static.
4562 * fileio.c: Make symbols static if they're not exported.
4563 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4564 (Vwrite_region_annotation_buffers): Now static.
4566 * eval.c: Make symbols static if they're not exported.
4567 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4568 * lisp.h (backtrace_list): Remove decl.
4570 * emacs.c: Make symbols static if they're not exported.
4571 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4572 (fatal_error_code, fatal_error_signal_hook, standard_args):
4574 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4575 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4576 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4577 * lisp.h (fatal_error_signal_hook): Remove decl.
4578 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4580 * editfns.c: Move a (normally-unused) function to its only use.
4581 * editfns.c, lisp.h (get_operating_system_release): Remove.
4582 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4583 worth the hassle of breaking this out.
4585 * xterm.c: Make symbols static if they're not exported.
4586 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4587 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4588 (x_destroy_window, x_delete_display):
4590 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4591 (x_mouse_leave): Remove; unused.
4592 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4593 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4594 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4596 (x_mouse_leave): Declare only if WINDOWSNT.
4597 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4598 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4601 * ftxfont.c: Make symbols static if they're not exported.
4602 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4604 * font.h (ftxfont_driver): Likewise.
4606 * xfns.c: Make symbols static if they're not exported.
4607 (x_last_font_name, x_display_info_for_name):
4608 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4609 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4610 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4611 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4612 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4613 (last_show_tip_args): Now static.
4614 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4615 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4616 (x_screen_planes): Remove; unused.
4617 * dispextern.h (x_screen_planes): Remove decl.
4619 * dispnew.c: Make symbols static if they're not exported.
4620 * dispextern.h (redraw_garbaged_frames, scrolling):
4621 (increment_row_positions): Remove.
4622 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4623 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4625 (redraw_garbaged_frames): Remove; unused.
4627 * xfaces.c: Make symbols static if they're not exported.
4628 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4630 * xterm.h (defined_color): Remove decls.
4631 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4632 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4633 (menu_face_changed_default, defined_color, free_realized_face):
4634 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4635 (ascii_face_of_lisp_face): Remove; unused.
4637 * xdisp.c: Make symbols static if they're not exported.
4638 * dispextern.h (scratch_glyph_row, window_box_edges):
4639 (glyph_to_pixel_coords, set_cursor_from_row):
4640 (get_next_display_element, set_iterator_to_next):
4641 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4642 (show_mouse_face): Remove decls
4643 * frame.h (message_buf_print): Likewise.
4644 * lisp.h (pop_message, set_message, check_point_in_composition):
4646 * xterm.h (set_vertical_scroll_bar): Likewise.
4647 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4648 (message_buf_print, scratch_glyph_row, displayed_buffer):
4649 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4650 (get_next_display_element, show_mouse_face, window_box_edges):
4651 (frame_to_window_pixel_xy, check_point_in_composition):
4652 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4653 (glyph_to_pixel_coords): Remove; unused.
4655 * dired.c (file_name_completion): Now static.
4657 * dbusbind.c (xd_in_read_queued_messages): Now static.
4659 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4660 * data.c (circular_list_error): Remove.
4662 * commands.h (last_point_position, last_point_position_buffer):
4663 (last_point_position_window): Remove decls.
4664 * keyboard.c: Make these variables static.
4666 * coding.h (coding, code_convert_region, encode_coding_gap):
4668 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4669 (iso_code_class, detect_coding, code_convert_region): Now static.
4670 (encode_coding_gap): Remove; unused.
4672 * chartab.c (chartab_chars, chartab_bits): Now static.
4674 * charset.h (charset_iso_8859_1): Remove decl.
4675 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4678 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4679 * ccl.c (Vccl_program_table): Now static.
4680 (check_ccl_update): Remove; unused.
4682 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4683 * category.h: ... from here.
4684 * category.c (check_category_table, set_category_set): Now static.
4686 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4687 * lisp.h: Remove these decls.
4689 * buffer.c (buffer_count): Remove unused var.
4691 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4692 so that it's not optimized away.
4693 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4694 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4695 exported only to the debugger.
4697 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4698 * atimer.h (run_all_atimers): Remove; not exported.
4700 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4701 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4702 was inaccessible from Lisp.
4703 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4704 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4706 alloc.c: Import and export fewer symbols, and remove unused items.
4707 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4709 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4710 it's not optimized away by whole-program optimization.
4711 (message_enable_multibyte, free_misc): Remove.
4712 (catchlist, handlerlist, mark_backtrace):
4713 Declare only if BYTE_MARK_STACK.
4714 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4715 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4716 (message_enable_multibyte): Remove decl.
4717 (free_misc, interval_free_list, float_block, float_block_index):
4718 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4719 (cons_free_list, last_marked_index):
4721 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4722 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4723 (mark_backtrace): Define only if BYTE_MARK_STACK.
4724 * xdisp.c (message_enable_multibyte): Now static.
4726 Declare Lisp_Object Q* variables to be 'static' if not exported.
4727 This makes it easier for human readers (and static analyzers)
4728 to see whether these variables are used from other modules.
4729 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4730 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4731 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4732 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4733 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4734 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4735 * xmenu.c, xselect.c:
4736 Declare Q* vars static if they are not used in other modules.
4737 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4738 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4739 Remove decls of unexported vars.
4740 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4742 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4744 Make Emacs functions such as Fatom 'static' by default.
4745 This makes it easier for human readers (and static analyzers)
4746 to see whether these functions can be called from other modules.
4747 DEFUN now defines a static function. To make the function external
4748 so that it can be used in other C modules, use the new macro DEFUE.
4749 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4750 (Finit_image_library):
4751 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4752 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4753 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4754 Remove decls, since these functions are now static.
4755 (Funintern, Fget_internal_run_time): New decls, since these functions
4756 were already external.
4758 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4759 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4760 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4761 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4762 * keyboard.c, keymap.c, lread.c:
4763 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4764 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4765 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4766 Mark functions with DEFUE instead of DEFUN,
4767 if they are used in other modules.
4768 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4769 decls for now-static functions.
4770 * buffer.h (Fdelete_overlay): Remove decl.
4771 * callproc.c (Fgetenv_internal): Mark as internal.
4772 * composite.c (Fremove_list_of_text_properties): Remove decl.
4773 (Fcomposition_get_gstring): New forward static decl.
4774 * composite.h (Fcomposite_get_gstring): Remove decl.
4775 * dired.c (Ffile_attributes): New forward static decl.
4776 * doc.c (Fdocumntation_property): New forward static decl.
4777 * eval.c (Ffetch_bytecode): New forward static decl.
4778 (Funintern): Remove extern decl; now in .h file where it belongs.
4779 * fileio.c (Fmake_symbolic_link): New forward static decl.
4780 * image.c (Finit_image_library): New forward static decl.
4781 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4782 * intervals.h (Fprevious_property_change):
4783 (Fremove_list_of_text_properties): Remove decls.
4784 * keyboard.c (Fthis_command_keys): Remove decl.
4785 (Fcommand_execute): New forward static decl.
4786 * keymap.c (Flookup_key): New forward static decl.
4787 (Fcopy_keymap): Now static.
4788 * keymap.h (Flookup_key): Remove decl.
4789 * process.c (Fget_process): New forward static decl.
4790 (Fprocess_datagram_address): Mark as internal.
4791 * syntax.c (Fsyntax_table_p): New forward static decl.
4792 (skip_chars): Remove duplicate decl.
4793 * textprop.c (Fprevious_property_change): New forward static decl.
4794 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4796 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4797 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4799 * editfns.c (Fformat): Remove unreachable code.
4801 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4803 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4806 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4808 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4809 when at ZV. (Bug#8487)
4811 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4813 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4815 * keyboard.c (parse_tool_bar_item): Likewise.
4816 * sound.c (sound_cleanup, alsa_close): Likewise.
4817 * termcap.c (tgetent): Likewise.
4818 * xfns.c (x_default_font_parameter): Likewise.
4819 * xsettings.c (read_and_apply_settings): Likewise.
4821 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4822 (overrun_check_free): Protoize.
4824 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4826 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4827 since callers should never pass a negative size.
4828 Change the signature to match that of plain 'read' and 'write'; see
4829 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4830 * lisp.h: Update prototypes of emacs_write and emacs_read.
4832 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4834 * xdisp.c (redisplay_window): Don't try to determine the character
4835 position of the scroll margin if the window start point w->startp
4836 is outside the buffer's accessible region. (Bug#8468)
4838 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4840 Fix write-region and its subroutines for buffers > 2GB.
4841 * fileio.c (a_write, e_write): Modify declaration of arguments and
4842 local variables to support buffers larger than 2GB.
4843 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4845 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4846 argument, local variables, and return value.
4848 * lisp.h: Update prototypes of emacs_write and emacs_read.
4850 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4852 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4854 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4856 Fix more problems found by GCC 4.6.0's static checks.
4858 * xdisp.c (vmessage): Use a better test for character truncation.
4860 * charset.c (load_charset_map): <, not <=, for optimization,
4861 and to avoid potential problems with integer overflow.
4862 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4863 * casetab.c (set_identity, shuffle): Likewise.
4864 * editfns.c (Fformat): Likewise.
4865 * syntax.c (skip_chars): Likewise.
4867 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4868 This also lets GCC 4.6.0 generate slightly better loop code.
4870 * callint.c (Fcall_interactively): <, not <=, for optimization.
4871 (Fcall_interactively): Count the number of arguments produced,
4872 not the number of arguments given. This is simpler and lets GCC
4873 4.6.0 generate slightly better code.
4875 * ftfont.c: Distingish more carefully between FcChar8 and char.
4876 The previous code passed unsigned char * to a functions like
4877 strlen and xstrcasecmp that expect char *, which does not
4878 conform to the C standard.
4879 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4880 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4881 char * when the C standard requires it.
4883 * keyboard.c (read_char): Remove unused var.
4885 * eval.c: Port to Windows vsnprintf (Bug#8435).
4887 (SIZE_MAX): Define if the headers do not.
4888 (verror): Do not give up if vsnprintf returns a negative count.
4889 Instead, grow the buffer. This ports to Windows vsnprintf, which
4890 does not conform to C99. Problem reported by Eli Zaretskii.
4891 Also, simplify the allocation scheme, by avoiding the need for
4892 calling realloc, and removing the ALLOCATED variable.
4894 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4896 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4897 But keep the doprint source code for now, as we might revamp it
4898 and use it again (Bug#8435).
4899 * lisp.h (doprnt): Remove.
4900 * Makefile.in (base_obj): Remove doprnt.o.
4901 * deps.mk (doprnt.o): Remove.
4903 error: Print 32- and 64-bit integers portably (Bug#8435).
4904 Without this change, on typical 64-bit hosts error ("...%d...", N)
4905 was used to print both 32- and 64-bit integers N, which relied on
4907 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4909 * lisp.h (error, verror): Mark as printf-like functions.
4910 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4911 Report overflow in size calculations when allocating printf buffer.
4912 Do not truncate output string at its first null byte.
4913 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4914 Truncate the output at a character boundary, since vsnprintf does not
4916 * charset.c (check_iso_charset_parameter): Convert internal
4917 character to string before calling 'error', since %c now has the
4919 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4920 overflow when computing char to be passed to 'error'. Do not
4921 pass Lisp_Object to 'error'; pass the integer instead.
4922 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4923 formatted with plain %d.
4925 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4927 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4929 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4931 * xterm.c (x_catch_errors): Remove duplicate declaration.
4933 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4935 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4937 2011-04-10 Jim Meyering <meyering@redhat.com>
4939 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4940 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4941 return ssize_t not "int", and use size_t as the buffer length.
4942 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4943 * gnutls.h: Update declarations.
4944 * process.c (read_process_output): Use ssize_t, to match.
4945 (send_process): Likewise.
4947 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4949 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4951 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4953 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4954 Use unsigned char, to match FcChar8 type definition.
4956 * xterm.c (handle_one_xevent):
4957 * xmenu.c (create_and_show_popup_menu):
4958 * xselect.c (x_decline_selection_request)
4959 (x_reply_selection_request): Avoid type-punned deref of X events.
4961 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4963 Fix some uses of `int' instead of EMACS_INT.
4964 * search.c (string_match_1, fast_string_match)
4965 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4966 (scan_buffer, find_next_newline_no_quit)
4967 (find_before_next_newline, search_command, Freplace_match)
4968 (Fmatch_data): Make some `int' variables be EMACS_INT.
4970 * xdisp.c (display_count_lines): 3rd argument and return value now
4971 EMACS_INT. All callers changed.
4972 (pint2hrstr): Last argument is now EMACS_INT.
4974 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4975 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4976 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4977 (decode_coding_utf_16, decode_coding_emacs_mule)
4978 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4979 (decode_coding_ccl, decode_coding_charset)
4980 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4981 (decode_coding_iso_2022, decode_coding_emacs_mule)
4982 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4983 <char_offset, last_offset>: Declare EMACS_INT.
4984 (encode_coding_utf_8, encode_coding_utf_16)
4985 (encode_coding_emacs_mule, encode_invocation_designation)
4986 (encode_designation_at_bol, encode_coding_iso_2022)
4987 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4988 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4990 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4991 (encode_invocation_designation): Last argument P_NCHARS is now
4993 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4994 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4996 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4999 * ccl.c (Fccl_execute_on_string): Declare some variables
5002 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5004 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5006 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5008 * process.c (Fformat_network_address): Doc fix.
5010 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5012 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5014 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5016 * keyboard.c (read_char): Call Lisp function help-form-show,
5017 instead of using internal_with_output_to_temp_buffer.
5018 (Qhelp_form_show): New var.
5019 (syms_of_keyboard): Use DEFSYM macro.
5021 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5023 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5025 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5027 * process.c (Flist_processes): Remove to Lisp.
5028 (list_processes_1): Delete.
5030 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5032 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5034 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5036 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5038 Fix more problems found by GCC 4.6.0's static checks.
5040 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5042 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5044 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5046 * xdisp.c (vmessage): Mark as a printf-like function.
5048 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5050 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5052 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5053 printf-like functions.
5054 (tiff_load): Add casts to remove these marks before passing them
5055 to system-supplied API.
5057 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5059 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5060 This avoids several warnings with gcc -Wstrict-overflow.
5061 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5062 directly, rather than having caller test rule sign. This avoids
5063 some unnecessary tests.
5064 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5065 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5066 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5068 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5069 (xfont_open): Avoid unnecessary tests.
5071 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5073 * composite.h, composite.c (composition_gstring_put_cache):
5074 Use EMACS_INT, not int, for length.
5076 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5077 breaking out part of COMPOSITION_DECODE_RULE.
5078 (COMPOSITION_DECODE_RULE): Use it.
5079 * composite.c (get_composition_id): Remove unused local vars,
5080 by using the new macro.
5082 * textprop.c (set_text_properties_1): Change while to do-while,
5083 since the condition is always true at first.
5085 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5086 (interval_deletion_adjustment): Return unsigned value.
5089 * process.c (list_processes_1, create_pty, read_process_output):
5090 (exec_sentinel): Remove vars that were set but not used.
5091 (create_pty): Remove unnecessary "volatile"s.
5092 (Fnetwork_interface_info): Avoid possibility of int overflow.
5093 (read_process_output): Do adaptive read buffering even if carryover.
5094 (read_process_output): Simplify nbytes computation if buffered.
5096 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5098 * syntax.c (scan_words): Remove var that was set but not used.
5099 (update_syntax_table): Use unsigned instead of int.
5101 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5102 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5103 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5105 * print.c (print_error_message): Avoid int overflow.
5107 * font.c (font_list_entities): Redo for clarity,
5108 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5110 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5111 (font_score): Avoid potential overflow in diff calculation.
5113 * fns.c (substring_both): Remove var that is set but not used.
5114 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5116 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5118 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5119 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5120 can always succeed if overflow has undefined behavior.
5122 * search.c (boyer_moore, wordify): Remove vars set but not used.
5123 (wordify): Omit three unnecessary tests.
5125 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5126 All callers changed. This avoids the need for an unused var.
5128 * casefiddle.c (casify_region): Remove var that is set but not used.
5130 * dired.c (file_name_completion): Remove var that is set but not used.
5132 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5134 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5135 (Finsert_file_contents): Remove unnecessary code checking fd.
5137 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5138 Check for integer overflow on size calculations.
5140 * buffer.c (Fprevious_overlay_change): Remove var that is set
5143 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5144 Remove vars that are set but not used.
5145 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5146 (timer_check_2): Mark vars as initialized.
5148 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5150 * image.c (lookup_image): Remove var that is set but not used.
5151 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5153 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5154 that are set but not used.
5156 * xfns.c (make_invisible_cursor): Don't return garbage
5157 if XCreateBitmapFromData fails (Bug#8410).
5159 * xselect.c (x_get_local_selection, x_handle_property_notify):
5160 Remove vars that are set but not used.
5162 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5163 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5165 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5166 Remove var that is set but not used.
5167 (scroll_bar_windows_size): Now size_t, not int.
5168 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5171 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5172 (map_tty_color) [!defined MSDOS]: Likewise.
5174 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5176 * coding.c: Remove vars that are set but not used.
5177 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5178 All callers changed.
5179 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5180 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5181 (decode_coding_charset): Remove vars that are set but not used.
5183 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5184 that is set but not used.
5186 * print.c (print_object): Remove var that is set but not used.
5188 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5189 The gnulib version avoids calling malloc in the usual case,
5190 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5191 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5192 * filelock.c (current_lock_owner): Likewise.
5193 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5194 * sysdep.c: Include allocator.h, careadlinkat.h.
5195 (emacs_no_realloc_allocator): New static constant.
5196 (emacs_readlink): New function.
5197 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5198 ../lib/careadlinkat.h.
5200 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5202 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5203 first non-nil return value).
5205 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5207 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5208 if not defined (Bug#8403).
5210 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5212 * xdisp.c (display_count_lines): Remove parameter `start',
5213 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5214 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5215 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5216 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5217 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5218 and thereabouts. All callers changed.
5219 (get_per_char_metric): Remove parameter `f', unused since
5220 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5222 2011-04-02 Jim Meyering <meyering@redhat.com>
5224 do not dereference NULL upon failed strdup
5225 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5226 (ns_get_family): Likewise.
5228 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5230 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5232 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5234 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5237 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5239 Add lexical binding.
5241 * window.c (Ftemp_output_buffer_show): New fun.
5242 (Fsave_window_excursion):
5243 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5245 * lread.c (lisp_file_lexically_bound_p): New function.
5246 (Fload): Bind Qlexical_binding.
5247 (readevalloop): Remove `evalfun' arg.
5248 Bind Qinternal_interpreter_environment.
5249 (Feval_buffer): Bind Qlexical_binding.
5250 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5252 (syms_of_lread): Declare `lexical-binding'.
5254 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5256 * keyboard.c (eval_dyn): New fun.
5257 (menu_item_eval_property): Use it.
5259 * image.c (parse_image_spec): Use Ffunctionp.
5261 * fns.c (concat, mapcar1): Accept byte-code-functions.
5263 * eval.c (Fsetq): Handle lexical vars.
5264 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5265 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5266 (FletX, Flet): Obey lexical binding.
5267 (Fcommandp): Handle closures.
5268 (Feval): New `lexical' arg.
5269 (eval_sub): New function extracted from Feval. Use it almost
5270 everywhere where Feval was used. Look up vars in lexical env.
5272 (Ffunctionp): Move from subr.el.
5273 (Ffuncall): Handle closures.
5274 (apply_lambda): Remove `eval_flags'.
5275 (funcall_lambda): Handle closures and new byte-code-functions.
5276 (Fspecial_variable_p): New function.
5277 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5278 but without exporting it to Lisp.
5280 * doc.c (Fdocumentation, store_function_docstring):
5281 * data.c (Finteractive_form): Handle closures.
5283 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5286 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5288 (exec_byte_code): New function extracted from Fbyte_code to handle new
5289 calling convention for byte-code-functions. Add new byte-codes.
5291 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5293 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5295 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5297 * xdisp.c (redisplay_internal): Fix prototype.
5299 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5301 * xdisp.c (SCROLL_LIMIT): New macro.
5302 (try_scrolling): Use it when setting scroll_limit.
5303 Limit scrolling to 100 screen lines.
5304 (redisplay_window): Even when falling back on "recentering",
5305 position point in the window according to scroll-conservatively,
5306 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5308 (try_scrolling): When point is above the window, allow searching
5309 as far as scroll_max, or one screenful, to compute vertical
5310 distance from PT to the scroll margin position. This prevents
5311 try_scrolling from unnecessarily failing when
5312 scroll-conservatively is set to a value slightly larger than the
5313 window height. Clean up the case of PT below the margin at bottom
5314 of window: scroll_max can no longer be INT_MAX. When aggressive
5315 scrolling is in use, don't let point enter the opposite scroll
5316 margin as result of the scroll.
5317 (syms_of_xdisp) <scroll-conservatively>: Document the
5318 threshold of 100 lines for never-recentering scrolling.
5320 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5322 * dispextern.h (move_it_by_lines):
5323 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5324 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5325 (message_log_check_duplicate): Remove parameters `prev_bol' and
5326 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5327 (redisplay_internal): Remove parameter `preserve_echo_area',
5328 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5330 * indent.c (Fvertical_motion):
5331 * window.c (window_scroll_pixel_based, Frecenter):
5332 Don't pass `need_y_p' to `move_it_by_lines'.
5334 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5336 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5337 steal a few bits to be more compact.
5338 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5339 Remove unneeded casts.
5341 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5343 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5345 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5346 binding" message (bug#7967).
5348 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5350 Fix more problems found by GCC 4.6.0's static checks.
5352 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5353 Remove unused local var.
5355 * editfns.c (Fmessage_box): Remove unused local var.
5357 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5358 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5359 Omit unused local vars.
5360 * window.c (shrink_windows): Omit unused local var.
5361 * menu.c (digest_single_submenu): Omit unused local var.
5362 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5363 Omit unused local var.
5365 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5366 Don't assume string length fits in int.
5367 (keyremap_step, read_key_sequence): Use size_t for sizes.
5368 (read_key_sequence): Don't check last_real_key_start redundantly.
5370 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5371 instead of alloca (Bug#8344).
5373 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5374 (Fbacktrace_frame): Don't assume nframes fits in int.
5376 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5378 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5381 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5383 * cm.c (calccost): Turn while-do into do-while, for clarity.
5385 * keyboard.c (syms_of_keyboard): Use the same style as later
5386 in this function when indexing through an array. This also
5387 works around GCC bug 48267.
5389 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5391 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5393 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5394 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5396 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5397 This avoids undefined behavior on integer overflow, and is a bit
5398 more convenient anyway since it is compared to a size_t variable.
5400 Variadic C functions now count arguments with size_t, not int.
5401 This avoids an unnecessary limitation on 64-bit machines, which
5402 caused (substring ...) to crash on large vectors (Bug#8344).
5403 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5404 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5405 All variadic functions and their callers changed accordingly.
5406 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5407 * data.c (arith_driver, float_arith_driver): Likewise.
5408 * editfns.c (general_insert_function): Likewise.
5409 * eval.c (struct backtrace.nargs, interactive_p)
5410 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5411 (funcall_lambda, mark_backtrace): Likewise.
5412 * fns.c (concat): Likewise.
5413 * frame.c (x_set_frame_parameters): Likewise.
5414 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5415 0 if not found, not -1. All callers changed.
5417 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5418 (stack_copy_size): Now size_t, not int.
5419 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5421 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5423 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5424 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5425 All callers changed.
5427 * lisp.h (multibyte_char_to_unibyte):
5428 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5429 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5430 * character.h (CHAR_TO_BYTE8):
5431 * cmds.c (internal_self_insert):
5432 * editfns.c (general_insert_function):
5433 * keymap.c (push_key_description):
5434 * search.c (Freplace_match):
5435 * xdisp.c (message_dolog, set_message_1): All callers changed.
5437 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5439 * keyboard.c (safe_run_hook_funcall): New function.
5440 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5441 don't set the hook to nil, but remove the offending function instead.
5442 (Qcommand_hook_internal): Remove, unused.
5443 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5444 Vcommand_hook_internal.
5446 * eval.c (enum run_hooks_condition): Remove.
5447 (funcall_nil, funcall_not): New functions.
5448 (run_hook_with_args): Call each function through a `funcall' argument.
5449 Remove `cond' argument, now redundant.
5450 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5451 (Frun_hook_with_args_until_failure): Adjust accordingly.
5452 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5454 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5456 * dispextern.h (string_buffer_position): Remove declaration.
5458 * print.c (strout): Remove parameter `multibyte', unused since
5459 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5461 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5462 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5463 All callers changed.
5465 * w32.c (_wsa_errlist): Use braces for struct initializers.
5467 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5468 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5469 All callers changed.
5470 (string_buffer_position): Likewise. Also, make static (it's never
5471 used outside xdisp.c).
5472 (cursor_row_p): Remove parameter `w', unused since
5473 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5474 (decode_mode_spec): Remove parameter `precision', introduced during
5475 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5476 All callers changed.
5478 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5480 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5482 2011-03-27 Anders Lindgren <andlind@gmail.com>
5484 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5485 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5486 (ns_update_auto_hide_menu_bar): New functions.
5487 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5488 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5489 ns_constrain_all_frames.
5490 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5491 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5493 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5495 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5497 2011-03-27 Glenn Morris <rgm@gnu.org>
5499 * syssignal.h: Replace RETSIGTYPE with void.
5500 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5501 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5502 Replace SIGTYPE with void everywhere.
5503 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5504 * s/template.h (SIGTYPE): Remove commented out definition.
5506 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5508 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5509 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5511 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5513 * w32.c (read_unc_volume): Use parameter `henum', instead of
5514 global variable `wget_enum_handle'.
5516 * keymap.c (describe_vector): Remove parameters `indices' and
5517 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5518 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5520 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5522 * keyboard.c (timer_check): Remove parameter `do_it_now',
5523 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5524 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5525 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5527 * keyboard.c (read_char):
5528 * w32menu.c (w32_menu_display_help):
5529 * xmenu.c (show_help_event, menu_help_callback):
5530 Adjust calls to `show_help_echo'.
5532 * gtkutil.c (xg_maybe_add_timer):
5533 * keyboard.c (readable_events):
5534 * process.c (wait_reading_process_output):
5535 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5537 * insdel.c (adjust_markers_gap_motion):
5538 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5539 (gap_left, gap_right): Don't call it.
5541 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5543 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5544 incurred during fontification.
5546 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5548 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5549 (DEFVAR_PER_BUFFER): Don't pass it.
5551 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5552 (scrolling_window): Don't pass it.
5554 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5556 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5558 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5560 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5561 of variables specific to SELinux and computation of `encoded_absname'.
5563 * image.c (XPutPixel): Remove unused variable `height'.
5565 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5567 * unexw32.c (get_section_info): Remove unused variable `section'.
5569 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5570 (system_process_attributes): Remove unused variable `sess'.
5571 (sys_read): Remove unused variable `err'.
5573 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5574 (w32_wnd_proc): Remove unused variable `isdead'.
5575 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5576 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5577 (x_create_tip_frame): Remove unused variable `tem'.
5579 * w32inevt.c (w32_console_read_socket):
5580 Remove unused variable `no_events'.
5582 * w32term.c (x_draw_composite_glyph_string_foreground):
5583 Remove unused variable `width'.
5585 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5587 * w32term.c (x_set_glyph_string_clipping):
5588 Don't pass uninitialized region to CombineRgn.
5590 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5592 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5593 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5594 (Fx_close_connection): Remove unused variable `i'.
5596 * w32font.c (w32font_draw): Return number of glyphs.
5597 (w32font_open_internal): Remove unused variable `i'.
5598 (w32font_driver): Add missing initializer.
5600 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5601 (fill_in_menu): Remove unused variable `items_added'.
5603 * w32term.c (last_mouse_press_frame): Remove static global variable.
5604 (w32_clip_to_row): Remove unused variable `f'.
5605 (x_delete_terminal): Remove unused variable `i'.
5607 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5608 (NOTHING): Remove unused static global variable.
5609 (uniscribe_check_otf): Remove unused variable `table'.
5610 (uniscribe_font_driver): Add missing initializers.
5612 2011-03-23 Julien Danjou <julien@danjou.info>
5614 * term.c (Fsuspend_tty, Fresume_tty):
5615 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5616 * window.c (temp_output_buffer_show):
5617 * insdel.c (signal_before_change):
5618 * frame.c (Fhandle_switch_frame):
5619 * fileio.c (Fdo_auto_save):
5620 * emacs.c (Fkill_emacs):
5621 * editfns.c (save_excursion_restore):
5622 * cmds.c (internal_self_insert):
5623 * callint.c (Fcall_interactively):
5624 * buffer.c (Fkill_all_local_variables):
5625 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5627 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5628 unconditionnaly since it does the check itself.
5630 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5632 Fix more problems found by GCC 4.5.2's static checks.
5634 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5635 the first time through the loop, since we know p0 < p1 then.
5636 This also avoids a gcc -Wstrict-overflow warning.
5638 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5639 leading to a memory leak, possible in functions like
5640 load_charset_map_from_file that can allocate an unbounded number
5641 of objects (Bug#8318).
5643 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5644 that could (at least in theory) be that large.
5646 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5647 This is less likely to overflow, and avoids undefined behavior if
5648 overflow does occur. All callers changed. Use strtoul to scan
5649 for the unsigned long integer.
5650 (pint2hrstr): Simplify and tune code slightly.
5651 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5653 * scroll.c (do_scrolling): Work around GCC bug 48228.
5654 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5656 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5657 This also avoids a warning with gcc -Wstrict-overflow.
5658 (validate_x_resource_name): Simplify count usage.
5659 This also avoids a warning with gcc -Wstrict-overflow.
5661 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5664 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5666 * process.c (Fmake_network_process): Use socklen_t, not int,
5667 where POSIX says socklen_t is required in portable programs.
5668 This fixes a porting bug on hosts like 64-bit HP-UX, where
5669 socklen_t is wider than int (Bug#8277).
5670 (Fmake_network_process, server_accept_connection):
5671 (wait_reading_process_output, read_process_output):
5674 * process.c: Rename or move locals to avoid shadowing.
5675 (list_processes_1, Fmake_network_process):
5676 (read_process_output_error_handler, exec_sentinel_error_handler):
5677 Rename or move locals.
5678 (Fmake_network_process): Define label "retry_connect" only if needed.
5679 (Fnetwork_interface_info): Fix pointer signedness.
5680 (process_send_signal): Add cast to avoid pointer signedness problem.
5681 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5682 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5684 Make tparam.h and terminfo.c consistent.
5685 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5686 Include tparam.h instead, since it declares them.
5687 * cm.h (PC): Remove extern decl; tparam.h now does this.
5688 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5689 * terminfo.c: Include tparam.h, to check interfaces.
5690 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5691 (tparam): Adjust signature to match interface in tparam.h;
5692 this removes some undefined behavior. Check that outstring and len
5693 are zero, which they always are with Emacs.
5694 * tparam.h (PC, BC, UP): New extern decls.
5696 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5697 (xftfont_open): Rename locals to avoid shadowing.
5699 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5700 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5701 (OTF_TAG_SYM): Omit macro if not needed.
5702 (ftfont_list): Remove unused local.
5703 (get_adstyle_property, ftfont_pattern_entity):
5704 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5705 Rename locals to avoid shadowing.
5707 * xfont.c (xfont_list_family): Mark var as initialized.
5709 * xml.c (make_dom): Now static.
5711 * composite.c (composition_compute_stop_pos): Rename local to
5713 (composition_reseat_it): Remove unused locals.
5714 (find_automatic_composition, composition_adjust_point): Likewise.
5715 (composition_update_it): Mark var as initialized.
5716 (find_automatic_composition): Mark vars as initialized,
5717 with a FIXME (Bug#8290).
5719 character.h: Rename locals to avoid shadowing.
5720 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5721 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5722 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5723 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5726 * textprop.c (property_change_between_p): Remove; unused.
5728 * intervals.c (interval_start_pos): Now static.
5730 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5732 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5733 Rename locals to avoid shadowing.
5735 * sound.c (wav_play, au_play, Fplay_sound_internal):
5736 Fix pointer signedness.
5737 (alsa_choose_format): Remove unused local var.
5738 (wav_play): Initialize a variable to 0, to prevent undefined
5739 behavior (Bug#8278).
5741 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5743 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5745 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5746 clobbering (Bug#8298).
5747 * sysdep.c (sys_subshell): Likewise.
5748 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5750 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5751 This should get cleaned up, so that child_setup has the
5752 same signature on all platforms.
5754 * callproc.c (call_process_cleanup): Now static.
5755 (relocate_fd): Rename locals to avoid shadowing.
5757 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5759 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5760 not to be necessary, and produces flickering.
5762 2011-03-20 Glenn Morris <rgm@gnu.org>
5764 * config.in: Remove file.
5766 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5768 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5769 are now in src/globals.h.
5770 (syms_of_minibuf): Remove spurious & from previous change.
5772 2011-03-20 Leo <sdl.web@gmail.com>
5774 * minibuf.c (completing-read-function): New variable.
5775 (completing-read-default): Rename from completing-read.
5776 (completing-read): Call completing-read-function.
5778 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5780 * xfaces.c (Fx_load_color_file):
5781 Read color file from absolute filename (bug#8250).
5783 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5785 * makefile.w32-in: Update dependencies.
5787 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5789 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5791 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5793 Fix more problems found by GCC 4.5.2's static checks.
5795 * process.c (make_serial_process_unwind, send_process_trap):
5796 (sigchld_handler): Now static.
5798 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5799 That way, the code declares only the vars that it needs.
5800 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5801 * s/cygwin.h (PTY_ITERATION): Likewise.
5802 * s/darwin.h (PTY_ITERATION): Likewise.
5803 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5805 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5806 * process.c (allocate_pty): Don't declare stb unless it's needed.
5808 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5809 (CONSTANTLIM): Remove; unused.
5810 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5811 Define only if needed.
5813 * unexelf.c (unexec): Name an expression,
5814 to avoid gcc -Wbad-function-cast warning.
5815 Use a different way to cause a compilation error if anyone uses
5816 n rather than nn, a way that does not involve shadowing.
5817 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5819 * deps.mk (unexalpha.o): Remove; unused.
5821 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5822 * unexec.h: New file.
5823 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5824 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5826 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5827 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5828 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5829 Change as necessary to match prototype in unexec.h.
5831 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5833 (back_comment, skip_chars): Mark vars as initialized.
5835 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5836 Rename locals to avoid shadowing.
5838 * lread.c (read1): Rewrite so as not to use empty "else".
5839 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5841 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5843 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5844 warning when compiling print.c.
5846 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5847 instead of using an uninitialized var.
5848 (font_sort_entities): Mark var as initialized.
5850 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5852 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5853 pointers to constants.
5854 (font_parse_fcname): Remove unused vars.
5855 (font_delete_unmatched): Now static.
5856 (font_get_spec): Remove; unused.
5857 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5858 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5859 Rename or move locals to avoid shadowing.
5861 * fns.c (require_nesting_list, require_unwind): Now static.
5862 (Ffillarray): Rename locals to avoid shadowing.
5864 * floatfns.c (domain_error2): Define only if needed.
5865 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5867 * alloc.c (mark_backtrace): Move decl from here ...
5868 * lisp.h: ... to here, so that it can be checked.
5870 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5871 (Fdefvar): Rewrite so as not to use empty "else".
5872 (lisp_indirect_variable): Name an expression,
5873 to avoid gcc -Wbad-function-cast warning.
5874 (Fdefvar): Rename locals to avoid shadowing.
5876 * callint.c (quotify_arg, quotify_args): Now static.
5877 (Fcall_interactively): Rename locals to avoid shadowing.
5878 Use const pointer when appropriate.
5880 * lisp.h (get_system_name, get_operating_system_release):
5881 Move decls here, to check interfaces.
5882 * process.c (get_operating_system_release): Move decl to lisp.h.
5883 * xrdb.c (get_system_name): Likewise.
5884 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5885 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5886 some of which prompt warnings from gcc -Wbad-function-cast.
5887 (Fformat_time_string, Fencode_time, Finsert_char):
5888 (Ftranslate_region_internal, Fformat):
5889 Rename or remove local vars to avoid shadowing.
5890 (Ftranslate_region_internal): Mark var as initialized.
5892 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5895 * lisp.h (eassert): Check that the argument compiles, even if
5896 ENABLE_CHECKING is not defined.
5898 * data.c (Findirect_variable): Name an expression, to avoid
5899 gcc -Wbad-function-cast warning.
5900 (default_value, arithcompare, arith_driver, arith_error): Now static.
5901 (store_symval_forwarding): Rename local to avoid shadowing.
5902 (Fmake_variable_buffer_local, Fmake_local_variable):
5903 Mark variables as initialized.
5904 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5906 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5907 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5908 Rename locals to avoid shadowing.
5909 (mark_stack): Move local variables into the #ifdef region where
5911 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5912 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5914 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5915 (GC_STRING_CHARS): Remove; not used.
5916 (Fmemory_limit): Cast sbrk's returned value to char *.
5918 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5919 avoids undefined behavior in theory.
5921 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5923 Use functions, not macros, for up- and down-casing (Bug#8254).
5924 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5925 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5926 to use the following functions instead of these macros.
5927 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5928 EMACS_INT, since callers assume the returned value fits in int.
5929 (upcase1): Likewise, for UPCASE_TABLE.
5930 (uppercasep, lowercasep, upcase): New static inline functions.
5931 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5932 the race-condition problem in the old DOWNCASE.
5934 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5935 Rename locals to avoid shadowing.
5936 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5937 (regex_compile, re_search_2, re_match_2_internal):
5938 Remove unused local vars.
5939 (FREE_VAR): Rewrite so as not to use empty "else",
5940 which gcc can warn about.
5941 (regex_compile, re_match_2_internal): Mark locals as initialized.
5942 (RETALLOC_IF): Define only if needed.
5943 (WORDCHAR_P): Likewise. This one is never needed, but is used
5944 only in a comment talking about a compiler bug, so put inside
5945 the #if 0 of that comment.
5946 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5947 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5950 * search.c (boyer_moore): Rename locals to avoid shadowing.
5951 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5952 (PREV_CHAR_BOUNDARY): Likewise.
5954 * search.c (simple_search): Remove unused var.
5956 * dired.c (compile_pattern): Move decl from here ...
5957 * lisp.h: ... to here, so that it can be checked.
5958 (struct re_registers): New forward decl.
5960 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5962 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5964 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5965 Rename locals to avoid shadowing.
5966 (Fvertical_motion): Mark locals as initialized.
5968 * casefiddle.c (casify_object, casify_region): Now static.
5969 (casify_region): Mark local as initialized.
5971 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5973 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5974 New macros, so that the caller can use some names other than
5975 gcpro1, gcpro2, etc.
5976 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5978 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5979 argument, for consistency with GCPRO2_VAR, etc: it is now the
5980 prefix of the variable, not the variable itself. All uses
5982 * dired.c (directory_files_internal, file_name_completion):
5983 Rename locals to avoid shadowing.
5985 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5986 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5987 dired.c's scmp function, had undefined behavior.
5988 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5989 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5990 * buffer.h: ... to here, because these macros use current_buffer,
5991 and the new implementation with inline functions needs to have
5992 current_buffer in scope now, rather than later when the macros
5994 (downcase, upcase1): New static inline functions.
5995 (DOWNCASE, UPCASE1): Reimplement using these functions.
5996 This avoids undefined behavior in expressions like
5997 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5998 from race conditions in accessing the global variables
5999 case_temp1 and case_temp2.
6000 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6001 * lisp.h (case_temp1, case_temp2): Remove their decls.
6002 * character.h (ASCII_CHAR_P): Move from here ...
6003 * lisp.h: ... to here, so that the inline functions mentioned
6006 * dired.c (directory_files_internal_unwind): Now static.
6008 * fileio.c (file_name_as_directory, directory_file_name):
6009 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6011 (file_name_as_directory): Use const pointers when appropriate.
6012 (Fexpand_file_name): Likewise. In particular, newdir might
6013 point at constant storage, so make it a const pointer.
6014 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6015 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6017 (Fset_file_times, Finsert_file_contents, auto_save_error):
6018 Rename locals to avoid shadowing.
6020 * minibuf.c (choose_minibuf_frame_1): Now static.
6021 (Ftry_completion, Fall_completions): Rename or remove locals
6024 * marker.c (bytepos_to_charpos): Remove; unused.
6026 * lisp.h (verify_bytepos, count_markers): New decls,
6027 so that gcc does not warn that these functions aren't declared.
6029 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6030 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6031 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6032 (copy_text): Remove unused local var.
6034 * filelock.c (within_one_second): Now static.
6035 (lock_file_1): Rename local to avoid shadowing.
6037 * buffer.c (fix_overlays_before): Mark locals as initialized.
6038 (fix_start_end_in_overlays): Likewise. This function should be
6039 simplified by using pointers-to-pointers, but that's a different
6041 (switch_to_buffer_1): Now static.
6042 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6043 (report_overlay_modification): Rename locals to avoid shadowing.
6045 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6046 Fix pointer signedness issue.
6047 (sys_subshell): Mark local as volatile if checking for lint,
6048 to suppress a gcc -Wclobbered warning that does not seem to be right.
6049 (MAXPATHLEN): Define only if needed.
6051 * process.c (serial_open, serial_configure): Move decls from here ...
6052 * systty.h: ... to here, so that they can be checked.
6054 * fns.c (get_random, seed_random): Move extern decls from here ...
6055 * lisp.h: ... to here, so that they can be checked.
6057 * sysdep.c (reset_io): Now static.
6058 (wait_for_termination_signal): Remove; unused.
6060 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6061 (copy_keymap_item, append_key, push_text_char_description):
6063 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6064 (DENSE_TABLE_SIZE): Remove; unused.
6065 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6066 (describe_map_tree):
6067 Rename locals to avoid shadowing.
6069 * keyboard.c: Declare functions static if they are not used elsewhere.
6070 (echo_char, echo_dash, cmd_error, top_level_2):
6071 (poll_for_input, handle_async_input): Now static.
6072 (read_char, kbd_buffer_get_event, make_lispy_position):
6073 (make_lispy_event, make_lispy_movement, apply_modifiers):
6074 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6075 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6076 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6077 (read_key_sequence, read_char): Mark locals as initialized.
6078 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6080 * keyboard.h (make_ctrl_char): New decl.
6081 (mark_kboards): Move decl here ...
6082 * alloc.c (mark_kboards): ... from here.
6084 * lisp.h (force_auto_save_soon): New decl.
6086 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6087 (DEFINE_DUMMY_FUNCTION): New macro.
6088 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6090 (main): Add casts to avoid warnings
6091 if GCC considers string literals to be constants.
6093 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6095 * dbusbind.c: Pointer signedness fixes.
6096 (xd_signature, xd_append_arg, xd_initialize):
6097 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6098 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6099 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6100 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6102 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6103 if GCC considers string literals to be constants.
6104 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6106 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6108 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6109 (print_preprocess, print_object): New macro to fix last change.
6111 * print.c (print_preprocess): Don't forget font objects.
6113 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6115 * emacs.c (USAGE3): Doc fixes.
6117 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6119 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6122 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6124 * lisp.h (VWindow_system, Qfile_name_history):
6125 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6126 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6127 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6129 * w32select.c: Don't #include "keyboard.h".
6130 (run_protected): Add extern declaration for waiting_for_input.
6132 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6133 * w32console.c (detect_input_pending, read_input_pending)
6134 (encode_terminal_code):
6135 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6136 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6137 (w32_system_caret_y, Qfile_name_history):
6138 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6139 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6140 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6141 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6142 * w32proc.c (Qlocal, report_file_error):
6143 * w32term.c (Vwindow_system, updating_frame):
6144 * w32uniscribe.c (initialized, uniscribe_font_driver):
6145 Remove unneeded extern declarations.
6147 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6149 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6151 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6153 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6154 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6155 These macros can no longer be used for assignment.
6157 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6158 Assign struct members directly, instead of using BUF_BEGV etc.
6159 (record_buffer_markers, fetch_buffer_markers): New functions for
6160 recording and fetching special buffer markers.
6161 (set_buffer_internal_1, set_buffer_temp): Use them.
6163 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6165 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6167 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6168 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6170 * xdisp.c (hscroll_window_tree):
6171 (reconsider_clip_changes): Use PT instead of BUF_PT.
6173 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6175 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6176 $(EMACS_ROOT)/lib/intprops.h.
6178 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6180 Fix more problems found by GCC 4.5.2's static checks.
6182 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6183 to unsigned char * to avoid compiler diagnostic.
6184 (xg_free_frame_widgets): Make it clear that a local variable is
6185 needed only if USE_GTK_TOOLTIP.
6186 (gdk_window_get_screen): Make it clear that this macro is needed
6187 only if USE_GTK_TOOLTIP.
6188 (int_gtk_range_get_value): New function, which avoids a diagnostic
6189 from gcc -Wbad-function-cast.
6190 (xg_set_toolkit_scroll_bar_thumb): Use it.
6191 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6192 diagnostic from gcc -Wbad-function-cast.
6193 (get_utf8_string, xg_get_file_with_chooser):
6194 Rename locals to avoid shadowing.
6195 (create_dialog): Move locals to avoid shadowing.
6197 * xgselect.c (xg_select): Remove unused var.
6199 * image.c (four_corners_best): Mark locals as initialized.
6200 (gif_load): Initialize transparent_p to zero (Bug#8238).
6201 Mark another local as initialized.
6202 (my_png_error, my_error_exit): Mark with NO_RETURN.
6204 * image.c (clear_image_cache): Now static.
6205 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6206 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6207 (x_edge_detection): Remove unnecessary cast that
6208 gcc -Wbad-function-cast diagnoses.
6209 (gif_load): Fix pointer signedness.
6210 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6211 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6213 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6215 Improve quality of tests for time stamp overflow.
6216 For example, without this patch (encode-time 0 0 0 1 1
6217 1152921504606846976) returns the obviously-bogus value (-948597
6218 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6219 reports time overflow. See
6220 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6221 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6222 * editfns.c: Include limits.h and intprops.h.
6223 (TIME_T_MIN, TIME_T_MAX): New macros.
6224 (time_overflow): Move earlier, to before first use.
6225 (hi_time, lo_time): New functions, for an accurate test for
6227 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6228 (Fget_internal_run_time): Don't assume time_t fits in int.
6229 (make_time): Use list2 instead of Fcons twice.
6230 (Fdecode_time): More accurate test for out-of-range times.
6231 (check_tm_member): New function.
6232 (Fencode_time): Use it, to test for out-of-range times.
6233 (lisp_time_argument): Don't rely on undefined left-shift and
6234 right-shift behavior when checking for time stamp overflow.
6236 * editfns.c (time_overflow): New function, refactoring common code.
6237 (Fformat_time_string, Fdecode_time, Fencode_time):
6238 (Fcurrent_time_string): Use it.
6240 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6241 * dired.c (make_time): Move to ...
6242 * editfns.c (make_time): ... here.
6243 * systime.h: Note the move.
6245 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6247 * fringe.c (update_window_fringes): Remove unused variables.
6249 * unexmacosx.c (copy_data_segment): Also copy __got section.
6252 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6254 * termcap.c [MSDOS]: Include "msdos.h".
6255 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6256 Constify `char *' arguments and their references according to
6257 prototypes in tparam.h.
6259 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6261 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6262 Adapt all references accordingly.
6264 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6266 2011-03-11 Tom Tromey <tromey@redhat.com>
6268 * buffer.c (syms_of_buffer): Remove obsolete comment.
6270 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6272 * termhooks.h (encode_terminal_code): Declare prototype.
6274 * msdos.c (encode_terminal_code): Don't declare prototype.
6276 * term.c (encode_terminal_code): Now external again, used by
6277 w32console.c and msdos.c.
6279 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6280 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6282 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6284 Fix some minor problems found by GCC 4.5.2's static checks.
6286 * fringe.c (update_window_fringes): Mark locals as initialized
6288 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6290 * alloc.c (mark_fringe_data): Move decl from here ...
6291 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6292 to check its interface.
6293 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6295 * fontset.c (free_realized_fontset): Now static.
6296 (Fset_fontset_font): Rename local to avoid shadowing.
6297 (fontset_font): Mark local as initialized.
6298 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6300 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6302 * xselect.c (x_disown_buffer_selections): Remove; not used.
6303 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6304 (x_own_selection, Fx_disown_selection_internal): Rename locals
6306 (x_handle_dnd_message): Remove local to avoid shadowing.
6308 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6309 so that the caller can use some name other than gcpro1.
6310 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6311 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6312 (Fx_backspace_delete_keys_p):
6313 Use them to avoid shadowing, and rename vars to avoid shadowing.
6314 (x_decode_color, x_set_name, x_window): Now static.
6315 (Fx_create_frame): Add braces to silence GCC warning.
6316 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6317 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6318 Remove unused locals.
6319 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6320 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6321 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6324 * xterm.h (x_mouse_leave): New decl.
6326 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6327 Remove unused functions.
6328 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6329 (x_calc_absolute_position): Now static.
6330 (XTread_socket): Don't define label "out" unless it's used.
6331 Don't declare local "event" unless it's used.
6332 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6333 unless they are used.
6334 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6335 (x_fatal_error_signal): Remove; not used.
6336 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6337 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6338 (x_error_catcher, x_connection_closed, x_error_handler):
6339 (x_error_quitter, xembed_send_message, x_iconify_frame):
6340 (my_log_handler): Rename locals to avoid shadowing.
6341 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6342 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6344 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6345 Rename or move locals to avoid shadowing.
6346 (tty_defined_color, merge_face_heights): Now static.
6347 (free_realized_faces_for_fontset): Remove; not used.
6348 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6349 does not deduce is never used uninitialized.
6350 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6351 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6353 * terminal.c (store_terminal_param): Now static.
6355 * xmenu.c (menu_highlight_callback): Now static.
6356 (set_frame_menubar): Remove unused local.
6357 (xmenu_show): Rename parameter to avoid shadowing.
6358 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6359 since they might point to immutable storage.
6360 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6361 since it's unused otherwise.
6363 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6364 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6365 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6366 avoids a gcc -Wuninitialized diagnostic.
6367 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6368 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6369 does not deduce are never used uninitialized.
6371 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6373 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6374 * window.c (window_loop, size_window):
6375 (run_window_configuration_change_hook, enlarge_window): Likewise.
6377 * window.c (display_buffer): Now static.
6378 (size_window): Mark variables that gcc -Wuninitialized
6379 does not deduce are never used uninitialized.
6380 * window.h (check_all_windows): New decl, to forestall
6381 gcc -Wmissing-prototypes diagnostic.
6382 * dispextern.h (bidi_dump_cached_states): Likewise.
6384 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6386 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6388 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6389 and to avoid gcc -Wuninitialized warning.
6390 (load_charset_map): Mark variables that gcc -Wuninitialized
6391 does not deduce are never used uninitialized.
6392 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6394 * coding.c (coding_set_source, coding_set_destination):
6395 Use "else { /* comment */ }" rather than "else /* comment */;"
6396 for clarity, and to avoid gcc -Wempty-body warning.
6397 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6398 a block, when the outer 'i' will do.
6399 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6400 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6401 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6402 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6403 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6404 Rename locals to avoid shadowing.
6405 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6406 * coding.c (emacs_mule_char, encode_invocation_designation):
6407 Now static, since they're not used elsewhere.
6408 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6409 (decode_coding_object, encode_coding_object, detect_coding_system):
6410 (decode_coding_emacs_mule): Mark variables that gcc
6411 -Wuninitialized does not deduce are never used uninitialized.
6412 (detect_coding_iso_2022): Initialize a local variable that might
6413 be used uninitialized. Leave a FIXME because it's not clear that
6414 this initialization is needed. (Bug#8211)
6415 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6416 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6417 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6418 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6419 Remove unused macros.
6421 * category.c (hash_get_category_set): Remove unused local var.
6422 (copy_category_table): Now static, since it's not used elsewhere.
6423 * character.c (string_count_byte8): Likewise.
6425 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6426 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6428 * chartab.c (copy_sub_char_table): Now static, since it's not used
6430 (sub_char_table_ref_and_range, char_table_ref_and_range):
6431 Rename locals to avoid shadowing.
6432 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6434 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6435 (BIDI_BOB): Remove unused macro.
6437 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6438 deduce are never used uninitialized.
6439 * term.c (encode_terminal_code): Likewise.
6441 * term.c (encode_terminal_code): Now static. Remove unused local.
6443 * tparam.h: New file.
6444 * term.c, tparam.h: Include it.
6445 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6446 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6447 Move these decls to tparam.h, and make them agree with what
6448 is actually in tparam.c. The previous trick of using incompatible
6449 decls in different modules does not conform to the C standard.
6450 All callers of tparam changed to use tparam's actual API.
6451 * tparam.c (tparam1, tparam, tgoto):
6452 Use const pointers where appropriate.
6454 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6455 * cm.h (struct cm): Likewise.
6456 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6457 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6458 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6459 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6460 (turn_on_face, init_tty): Likewise.
6461 * termchar.h (struct tty_display_info): Likewise.
6463 * term.c (term_mouse_position): Rename local to avoid shadowing.
6465 * alloc.c (mark_ttys): Move decl from here ...
6466 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6468 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6470 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6472 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6474 * search.c (compile_pattern_1): Remove argument regp, unused since
6475 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6476 (compile_pattern): Don't pass it.
6478 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6480 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6481 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6483 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6485 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6487 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6488 gdk_window_get_screen, gdk_window_get_geometry,
6489 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6490 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6491 (xg_get_pixbuf_from_pixmap): New function.
6492 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6493 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6494 Call xg_get_pixbuf_from_pixmap instead of
6495 gdk_pixbuf_get_from_drawable.
6496 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6497 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6498 (xg_check_special_colors): Use GtkStyleContext and its functions
6500 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6501 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6502 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6503 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6504 Call gtk_widget_get_preferred_size.
6505 (xg_frame_resized): gdk_window_get_geometry only takes 5
6507 (xg_win_to_widget, xg_event_is_for_menubar):
6508 Call gdk_x11_window_lookup_for_display.
6509 (xg_set_widget_bg): New function.
6510 (delete_cb): New function.
6511 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6512 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6513 (xg_set_background_color): Call xg_set_widget_bg.
6514 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6515 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6516 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6517 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6519 (update_frame_tool_bar): Call gtk_widget_hide.
6520 (xg_initialize): Use GDK_KEY_g.
6522 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6524 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6526 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6527 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6528 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6530 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6532 * w32xfns.c (select_palette): Check success of RealizePalette against
6533 GDI_ERROR, not zero.
6535 See ChangeLog.11 for earlier changes.
6541 Copyright (C) 2011 Free Software Foundation, Inc.
6543 This file is part of GNU Emacs.
6545 GNU Emacs is free software: you can redistribute it and/or modify
6546 it under the terms of the GNU General Public License as published by
6547 the Free Software Foundation, either version 3 of the License, or
6548 (at your option) any later version.
6550 GNU Emacs is distributed in the hope that it will be useful,
6551 but WITHOUT ANY WARRANTY; without even the implied warranty of
6552 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6553 GNU General Public License for more details.
6555 You should have received a copy of the GNU General Public License
6556 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.