1 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
3 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
6 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
8 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
10 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
11 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
12 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
13 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
14 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
15 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
17 * xfont.c (compare_font_names): Redo to omit the need for casts.
19 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
21 * xfns.c (Fx_change_window_property): Doc fix.
22 * w32fns.c (Fx_change_window_property): Doc fix.
24 * w32fns.c (Fx_window_property): Accept the same arguments as the
25 X Windows version. Doc fix.
26 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
28 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
29 Eli Zaretskii <eliz@gnu.org>
31 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
32 Windows-specific code from nt/config.nt moved here.
33 Obsolete settings removed.
35 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
37 * process.c: Avoid unnecessary calls to gettime.
38 (wait_reading_process_output): Don't get the time of day
39 when gobbling data immediately and not waiting, as there's no need
40 for it in that case. This removes a FIXME.
42 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
44 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
45 is defined (Bug#11768).
47 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
49 Fix marker debugging code.
50 * marker.c (byte_char_debug_check): Do not perform the check
51 if buffer is not multibyte.
52 (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Call
53 byte_char_debug_check with correct arguments.
55 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
57 Compile marker debugging code only if ENABLE_CHECKING is defined.
58 * marker.c (byte_char_debug_check, count_markers): Use
59 only if ENABLE_CHECKING is defined.
60 (byte_debug_flag): Remove.
61 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
62 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
64 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
66 Avoid code repetition in marker-related functions.
67 * marker.c (attach_marker): New function.
68 (Fset_marker, set_marker_restricted, set_marker_both)
69 (set_marker_restricted_both): Use it.
70 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
71 Consistently rename charno to charpos.
72 (marker_position): Add eassert.
73 (marker_byte_position): Convert to eassert.
75 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
77 Simplify list operations in unchain_overlay and unchain_marker.
78 * buffer.c (unchain_overlay): Simplify. Add comment.
79 * marker.c (unchain_marker): Simplify. Fix comments.
81 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
83 Introduce fast path for the widely used marker operation.
84 * alloc.c (build_marker): New function.
85 * lisp.h (build_marker): New prototype.
86 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
87 * composite.c (autocmp_chars): Likewise.
88 * editfns.c (buildmark): Remove.
89 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
90 (save_restriction_save): Use build_marker.
91 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
92 * window.c (save_window_save): Likewise.
94 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
96 Do not use Fdelete_overlay in delete_all_overlays
97 to avoid redundant calls to unchain_overlay.
98 * buffer.c (drop_overlay): New function.
99 (delete_all_overlays, Fdelete_overlay): Use it.
100 * minibuf.c (get_minibuffer): Fix comment.
102 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
104 Port to OpenBSD 5.1 amd64.
105 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
106 This is needed for OpenBSD, and should be harmless on all BSD systems.
107 Also, include <sys/sysctl.h>, as it should be available on all
108 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
109 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
110 use p_pid member, not kp_proc.pid.
112 2012-07-06 Glenn Morris <rgm@gnu.org>
114 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
116 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
118 More xmalloc and related cleanup.
119 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
120 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
121 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
122 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
123 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
124 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
125 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
126 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
127 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
129 Omit needless casts involving void * pointers and allocation.
130 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
131 as the former is more robust if P's type is changed.
132 Prefer xzalloc to xmalloc + memset 0.
133 Simplify malloc-or-realloc to realloc.
134 Don't worry about xmalloc returning a null pointer.
135 Prefer xstrdup to xmalloc + strcpy.
136 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
138 * keyboard.c (apply_modifiers_uncached): Prefer local array to
139 alloca of a constant.
141 2012-07-05 Eli Zaretskii <eliz@gnu.org>
143 * xdisp.c (display_line): Fix horizontal pixel coordinates when
144 hscroll is larger than the line width. Fixes long and futile
145 looping inside extend_face_to_end_of_line (on a TTY) producing
146 glyphs that are not needed and thrown away.
148 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
150 * marker.c (set_marker_restricted_both): Simplify by using
153 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
155 * editfns.c (region_limit): Simplify by using clip_to_bounds.
157 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
159 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
160 not defined (Bug#11768).
161 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
162 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
163 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
164 followed by gtk_box_set_homogeneous (Bug#11768).
165 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
166 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
167 gtk_scrollbar_new (Bug#11768).
168 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
169 (is_box_type): New function (Bug#11768).
170 (xg_tool_item_stale_p): Call is_box_type.
171 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
172 with default display (Bug#11768).
174 2012-07-05 Eli Zaretskii <eliz@gnu.org>
176 * xdisp.c (window_hscroll_limited): New function.
177 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
178 coordinates when window's hscroll is set to insanely large
181 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
183 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
184 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
186 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
189 * lisp.h (xzalloc): New prototype. Omit needless casts.
190 * alloc.c (xzalloc): New function. Omit needless casts.
191 * charset.c: Omit needless casts. Convert all calls to
192 xmalloc with following memset to xzalloc.
193 * dispnew.c: Likewise.
194 * fringe.c: Likewise.
198 * w32fns.c: Likewise.
199 * w32font.c: Likewise.
200 * w32term.c: Likewise.
201 * xfaces.c: Likewise.
204 * atimer.c: Omit needless casts.
205 * buffer.c: Likewise.
206 * callproc.c: Likewise.
208 * coding.c: Likewise.
209 * composite.c: Likewise.
211 * doprnt.c: Likewise.
212 * editfns.c: Likewise.
215 * filelock.c: Likewise.
217 * gtkutil.c: Likewise.
218 * keyboard.c: Likewise.
221 * minibuf.c: Likewise.
224 * process.c: Likewise.
225 * region-cache.c: Likewise.
226 * search.c: Likewise.
227 * sysdep.c: Likewise.
228 * termcap.c: Likewise.
229 * terminal.c: Likewise.
230 * tparam.c: Likewise.
231 * w16select.c: Likewise.
233 * w32reg.c: Likewise.
234 * w32select.c: Likewise.
235 * w32uniscribe.c: Likewise.
236 * widget.c: Likewise.
240 * xselect.c: Likewise.
242 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
244 * fileio.c (time_error_value): Check the right error number.
245 Problem reported by Troels Nielsen in
246 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
248 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
250 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
251 This should be fixed in a better way; see Eli Zaretskii in
252 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
253 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
255 * fileio.c (time_error_value): Rename from special_mtime.
256 The old name's problems were noted by Eli Zaretskii in
257 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
259 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
260 This variable's comment says Emacs needs at least one GDB-visible
261 symbol of type enum pvec_type, to work around GDB problems.
262 The symbol's value doesn't matter.
264 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
265 that causes compilation to fail on pre-C99 compilers.
267 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
269 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
270 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
272 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
274 * buffer.c (init_buffer_once): Fix initialization of
275 headers for buffer_defaults and buffer_local_symbols.
276 Reported by Juanma Barranquero <lekktu@gmail.com>.
278 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
280 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
281 * lisp.h (enum pvec_type): Use fewer bits.
282 (PSEUDOVECTOR_SIZE_BITS): New constant.
283 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
284 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
286 (PSEUDOVECTOR_TYPEP): New macro.
287 (TYPED_PSEUDOVECTORP): Use it.
288 * fns.c (internal_equal): Adapt code to extract pvectype.
289 * emacs.c (gdb_pvec_type): Update type.
290 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
291 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
292 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
293 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
294 (sweep_vectors): Use it. Use local var `total_bytes' instead of
295 abusing vector->header.next.nbytes.
296 (live_vector_p): Use PVEC_TYPE.
297 (mark_object): Adapt code to extract pvectype. Use switch.
299 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
301 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
302 Tighten new eassert a bit.
304 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
306 Fix compilation with --enable-gcc-warnings and -O1
308 * doprnt.c (doprnt): Change type of tem to int, initialize
309 to avoid compiler warning. Add eassert.
310 * search.c (simple_search): Initialize match_byte to avoid
311 compiler warning. Add eassert.
313 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
315 Avoid weird behavior with large horizontal scrolls.
316 Without this change, for example, large hscroll values would
317 mess up Emacs's display on Fedora 15 x86, presumably due to
318 overflows in int calculations in the display code.
319 Also, if buffers had long lines, Emacs would freeze.
320 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
321 (set_window_hscroll): New function, containing the old guts of
322 Fset_window_hscroll. Return the clipped value.
323 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
324 This avoids the need to check against PTRDIFF_MAX.
326 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
328 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
330 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
332 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
334 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
335 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
336 since GCC 4.4.6 issues a bogus warning for them.
338 Fix bugs in file timestamp newness comparisons.
339 * fileio.c (Ffile_newer_than_file_p):
340 * lread.c (Fload): Use full timestamp resolution of files,
341 not just the 1-second resolution, so that files that are only
342 slightly newer still count as newer.
343 * fileio.c (Ffile_newer_than_file_p): Don't assume file
344 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
346 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
348 * fileio.c: Improve handling of file time marker. (Bug#11852)
349 (special_mtime): New function.
350 (Finsert_file_contents, Fverify_visited_file_modtime):
351 Use it to set special mtime values consistently.
353 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
355 * fileio.c (Finsert_file_contents): Properly handle st_mtime
356 marker for non-existing file. (Bug#11852)
358 2012-07-03 Glenn Morris <rgm@gnu.org>
360 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
361 and did not make it into globals.h).
363 2012-07-03 Tom Tromey <tromey@redhat.com>
365 * window.c (Fset_window_margins, Fset_window_fringes)
366 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
367 * textprop.c (Fprevious_property_change): No longer static.
368 * syntax.c (Fsyntax_table_p): No longer static.
369 * process.c (Fget_process, Fprocess_datagram_address): No longer
371 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
372 * keyboard.c (Fcommand_execute): No longer static.
374 * insdel.c (Fcombine_after_change_execute): No longer static.
375 * image.c (Finit_image_library): No longer static.
376 * fileio.c (Fmake_symbolic_link): No longer static.
377 * eval.c (Ffetch_bytecode): No longer static.
378 * editfns.c (Fuser_full_name): No longer static.
379 * doc.c (Fdocumentation_property, Fsnarf_documentation):
381 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
383 * dired.c (Ffile_attributes): No longer static.
384 * composite.c (Fcomposition_get_gstring): No longer static.
385 * callproc.c (Fgetenv_internal): No longer static.
387 * ccl.h: Remove EXFUNs.
388 * buffer.h: Remove EXFUNs.
389 * dispextern.h: Remove EXFUNs.
390 * intervals.h: Remove EXFUNs.
391 * fontset.h: Remove EXFUN.
392 * font.h: Remove EXFUNs.
393 * dosfns.c (system_process_attributes): Remove EXFUN.
394 * keymap.h: Remove EXFUNs.
395 * lisp.h: Remove EXFUNs.
396 * w32term.h: Remove EXFUNs.
397 * window.h: Remove EXFUNs.
398 * xsettings.h: Remove EXFUN.
399 * xterm.h: Remove EXFUN.
401 2012-07-03 Glenn Morris <rgm@gnu.org>
403 * lisp.h (Frandom): Make it visible to C.
404 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
405 buffer for invisible buffers. (Bug#1229)
407 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
409 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
410 values which aren't power of 2.
411 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
412 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
415 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
417 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
419 * alloc.c (mark_object): Revert part of last patch to use `switch'.
421 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
423 * alloc.c (allocate_vector_block): Remove redundant
424 calls to mallopt if DOUG_LEA_MALLOC is defined.
425 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
426 avoid calls to mallopt if zero_vector is returned.
428 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
430 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
431 is enabled, avoid dereferencing NULL current_sblock if
434 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
436 Cleanup basic buffer management.
437 * buffer.h (struct buffer): Change layout to use generic vector
438 marking code. Fix some comments. Change type of 'clip_changed'
439 to bitfield. Remove unused #ifndef old.
440 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
441 (GET_OVERLAYS_AT): Fix indentation.
442 (for_each_per_buffer_object_at): New macro.
443 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
444 (Fbuffer_local_variables): Use it.
445 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
446 * alloc.c (allocate_buffer): Adjust to match new layout of
447 struct buffer. Fix comment.
448 (mark_overlay): New function.
449 (mark_buffer): Use it. Use mark_vectorlike to mark normal
450 Lisp area of struct buffer.
451 (mark_object): Use it. Adjust marking of misc objects
452 and related comments.
454 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
456 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
457 wrapper that is not needed because the wrapped code is a no-op (zero
458 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
459 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
461 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
463 * alloc.c (mark_buffer): Simplify. Remove prototype.
464 (mark_object): Add comment. Reorganize marking of vector-like
465 objects. Use CHECK_LIVE for all vector-like objects except buffers
466 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
467 redundant calls to mark_vectorlike for bool vectors.
469 2012-06-30 Glenn Morris <rgm@gnu.org>
471 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
473 * epaths.in (PATH_SITELOADSEARCH): New.
474 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
475 This is rather than relying on --enable-locallisppath elements
476 having "site-lisp" in their names. (Bug#10208#25, 11658)
478 2012-06-30 Eli Zaretskii <eliz@gnu.org>
480 * w32proc.c (sys_select): Accept and ignore one more argument.
482 * w32.c (emacs_gnutls_pull): Call select with one more argument.
484 * sysselect.h [DOS_NT]: Don't include sys/select.h.
485 (pselect) [!MS_DOS]: Redirect to sys_select.
487 * sysdep.c: Don't include dos.h and dosfns.h.
489 * process.c (sys_select):
490 * msdos.c (sys_select): Accept one more argument and ignore it.
492 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
493 adapt data types and code to that.
496 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
497 which clashes with the gnulib function of the same name.
499 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
501 * font.c (font_style_to_value, font_style_symbolic)
502 (font_prop_validate_style): Add type checks for values in
505 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
507 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
510 2012-06-29 Eli Zaretskii <eliz@gnu.org>
512 * xdisp.c (try_window_id): Undo last change.
514 * w32.c (getwd): Adjust commentary about startup_dir.
515 (init_environment): Always call sys_access, even in non-MSVC
516 builds. Don't chdir to the directory of the Emacs executable.
517 This undoes code from 1997 which was justified by the need to
518 "avoid conflicts when removing and renaming directories". But its
519 downside was that every relative file name was being interpreted
520 relative to the directory of the Emacs executable, which can never
521 be TRT. In particular, it broke sys_access when called with
523 (sys_access): Map GetLastError to errno.
525 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
527 * window.h (struct window): Change type of 'fringes_outside_margins'
528 to bitfield. Fix comment. Adjust users accordingly.
529 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
531 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
534 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
536 * gnutls.c (emacs_gnutls_handshake):
537 Add QUIT to make the loop interruptible.
539 2012-06-29 Glenn Morris <rgm@gnu.org>
541 * charset.c (init_charset): Make lack of etc/charsets fatal.
543 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
545 * editfns.c (region_limit): Fix type mismatch.
547 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
549 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
550 undefined. Convert from xassert to eassert.
551 * nsmenu.m: Convert from xassert to eassert.
552 * nsterm.m: Likewise.
554 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
556 * editfns.c (region_limit): Clip to narrowing (bug#11770).
558 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
560 Avoid integer overflow on scroll-left and scroll-right.
561 * window.c (HSCROLL_MAX): New macro.
562 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
563 overflow when requested scroll falls outside ptrdiff_t range.
565 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
567 * window.h (struct window): Change type of 'hscroll',
568 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
569 'last_modified' and 'last_overlay_modified' to EMACS_INT.
570 Adjust users accordingly.
571 * xdisp.c (try_cursor_movement): Replace type check with eassert.
572 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
573 from EMACS_INT to ptrdiff_t.
574 (make_window): Omit redundant initialization.
576 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
578 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
580 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
582 * window.h (struct window): Change type of 'use_time' and
583 'sequence_number' from Lisp_Object to int.
584 * frame.c (make_frame): Adjust users accordingly.
585 * print.c (print_object): Likewise.
586 * window.c (select_window, Fwindow_use_time, make_parent_window)
587 (make_window): Likewise.
589 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
591 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
592 enabled with --enable-checking=[all,glyphs] configure option.
593 Fix GLYPH_DEBUG usage assuming that it may be undefined,
594 adjust comments accordingly.
595 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
596 undefined, adjust comments accordingly.
598 * scroll.c: Likewise.
599 * w32fns.c: Likewise.
600 * w32term.c: Likewise.
602 * xfaces.c: Likewise.
606 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
608 Generalize run-time debugging checks.
609 * dispextern.h (XASSERTS): Remove.
610 * fontset.c (xassert): Remove.
611 Convert from xassert to eassert.
612 * alloc.c: Convert from xassert to eassert.
614 * dispnew.c: Likewise.
616 * fringe.c: Likewise.
617 * ftfont.c: Likewise.
618 * gtkutil.c: Likewise.
620 * keyboard.c: Likewise.
622 * process.c: Likewise.
623 * scroll.c: Likewise.
626 * w32console.c: Likewise.
627 * w32fns.c: Likewise.
628 * w32term.c: Likewise.
629 * window.c: Likewise.
631 * xfaces.c: Likewise.
633 * xselect.c: Likewise.
636 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
638 * fns.c (maybe_resize_hash_table): Output message when growing the
641 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
643 * alloc.c (allocate_string_data): Remove dead code.
644 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
645 avoid GCC warning about unused macro.
647 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
649 * alloc.c (allocate_string): Omit intervals initialization.
650 * alloc.c (make_uninit_multibyte_string): Initialize intervals
651 as in make_pure_string and make_pure_c_string.
653 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
655 * alloc.c (allocate_string): Fix last change.
657 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
659 * alloc.c (allocate_string): Remove two redundant calls
660 to memset, add explicit initialization where appropriate.
662 2012-06-27 Glenn Morris <rgm@gnu.org>
664 * lisp.mk (lisp): Remove paths.elc.
666 2012-06-27 Chong Yidong <cyd@gnu.org>
668 * doc.c (Fsubstitute_command_keys): Fix punctuation.
670 2012-06-26 John Wiegley <johnw@newartisans.com>
672 * unexmacosx.c (copy_data_segment): Add two section names used
673 on Mac OS X Lion: __mod_init_func and __mod_term_func.
675 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
676 when building with Clang.
678 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
680 * eval.c (Fapply): Allow calling it with a single argument.
682 2012-06-26 Eli Zaretskii <eliz@gnu.org>
684 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
685 _stricmp and _strnicmp.
686 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
688 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
690 * alloc.c (allocate_window): Zero out non-Lisp part of newly
692 (allocate_process): Likewise for new process.
693 (allocate_terminal): Change to use offsetof.
694 (allocate_frame): Likewise.
695 * frame.c (make_frame): Omit redundant initialization.
696 * window.c (make_parent_window): Use memset.
697 (make_window): Omit redundant initialization.
698 * process.c (make_process): Omit redundant initialization.
699 * terminal.c (create_terminal): Likewise.
701 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
703 * term.c (delete_tty): Remove redundant call to memset.
705 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
707 * alloc.c: Remove build_string.
708 * lisp.h: Define build_string as static inline. This provides
709 a better opportunity to optimize away calls to strlen when the
710 function is called with compile-time constant argument.
711 * image.c (imagemagick_error): Convert to build_string.
712 * w32proc.c (sys_spawnve): Likewise.
713 * xterm.c (x_term_init): Likewise.
715 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
717 Use sprintf return value instead of invoking strlen on result.
718 In the old days this wasn't portable, since some sprintf
719 implementations returned char *. But they died out years ago and
720 Emacs already assumes sprintf returns int.
721 Similarly for float_to_string.
722 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
723 * ccl.c (ccl_driver):
724 * character.c (string_escape_byte8):
725 * data.c (Fnumber_to_string):
727 * print.c (print_object):
728 * xdisp.c (message_dolog):
729 * xfns.c (syms_of_xfns):
730 Use sprintf or float_to_string result to avoid need to call strlen.
731 * data.c (Fnumber_to_string):
732 Use make_unibyte_string, since the string must be ASCII.
733 * lisp.h, print.c (float_to_string): Now returns int length.
734 * term.c (produce_glyphless_glyph):
735 Use sprintf result rather than recomputing it.
737 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
738 * Makefile.in (ALL_CFLAGS):
739 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
740 * gmalloc.c, regex.c: Include <config.h> unconditionally.
742 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
744 * dispextern.h (xstrcasecmp): Define to library function
745 strcasecmp if available.
746 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
748 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
750 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
751 Avoid comma operator.
752 * menu.c (push_submenu_start, push_submenu_end)
753 (push_left_right_boundary, push_menu_pane): Likewise.
754 * msdos.c (dos_rawgetc): Likewise.
756 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
758 * xfns.c (xic_create_fontsetname): Remove redundant calls
761 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
763 * gtkutil.c (get_utf8_string): Remove redundant assignment.
764 sprintf already null-terminates its output.
766 * xfns.c (x_window): Remove redundant cast.
768 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
770 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
771 `const char *' to `char *' to avoid compiler warning.
773 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
775 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
776 instead of truncating it to 63 (admittedly a generous limit).
778 * process.c: Fix spelling and caps in comments.
780 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
782 * emacs.c (setpgrp): Remove definition, unused.
783 * sysdep.c (setpgrp): Remove definition, not used in this file.
785 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
787 * makefile.w32-in: Update dependencies.
789 2012-06-24 Eli Zaretskii <eliz@gnu.org>
791 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
792 (SYSTIME_H): Add nt/inc/sys/time.h.
794 * systime.h [WINDOWSNT]: Include sys/time.h.
796 * s/ms-w32.h (struct timespec): Definition moved from
797 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
799 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
801 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
802 * buffer.h (buffer_slot_type_mismatch):
803 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
804 * eval.c (unwind_to_catch):
805 * image.c (my_png_error, my_error_exit):
806 * keyboard.c (quit_throw_to_read_char, user_error)
807 (Fexit_recursive_edit, Fabort_recursive_edit):
808 * lisp.h (die, args_out_of_range, args_out_of_range_3)
809 (wrong_type_argument, buffer_overflow, __executable_start)
810 (memory_full, buffer_memory_full, string_overflow, Fthrow)
811 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
812 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
814 (child_setup) [!DOS_NT]:
815 * lread.c (end_of_file_error, invalid_syntax):
816 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
817 * puresize.h (pure_write_error):
818 * search.c (matcher_overflow):
819 * sound.c (sound_perror, alsa_sound_perror):
820 * sysdep.c, syssignal.h (croak):
821 * term.c (maybe_fatal, vfatal):
822 * textprop.c (text_read_only):
823 * undo.c (user_error):
824 * unexmacosx.c (unexec_error):
825 * xterm.c (x_ins_del_lines, x_delete_glyphs):
826 Use _Noreturn rather than NO_RETURN.
827 No need for separate decl merely because of _Noreturn.
828 * sound.c (sound_warning, parse_sound):
829 Remove unnecessary forward decls.
831 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
833 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
834 * lisp.h (WAIT_READING_MAX): New macro.
835 * dispnew.c (Fsleep_for, sit_for):
836 * keyboard.c (kbd_buffer_get_event):
837 * process.c (Faccept_process_output):
838 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
839 This improves on the previous patch, which introduced a bug
840 when time_t is unsigned and as wide as intmax_t.
841 See <http://bugs.gnu.org/9000#51>.
843 2012-06-23 Eli Zaretskii <eliz@gnu.org>
845 * dispnew.c (sit_for, Fsleep_for):
846 * keyboard.c (kbd_buffer_get_event):
847 * process.c (Faccept_process_output): Avoid compiler warnings when
848 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
850 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
852 * makefile.w32-in: Update dependencies.
854 * w32.c (ltime): Add return type and declare static.
855 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
857 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
859 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
860 Privately reported by Herbert J. Skuhra.
861 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
863 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
864 not make_lisp_timeval, when the argument is of type EMACS_TIME.
866 2012-06-23 Eli Zaretskii <eliz@gnu.org>
868 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
869 last argument of make_unibyte_string.
871 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
872 language ID in the event parameters.
874 * w32term.c (w32_read_socket): Put the new keyboard codepage into
875 event.code, not the obscure "character set ID".
877 2012-06-23 Chong Yidong <cyd@gnu.org>
879 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
881 2012-06-23 Eli Zaretskii <eliz@gnu.org>
883 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
884 * w32.c (fdutimens): New function.
886 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
888 * s/ms-w32.h (pselect): Redirect to sys_select.
890 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
892 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
893 in the logic of incrementing and decrementing the value of
894 use_relocatable_buffers.
896 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
898 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
899 Privately reported by Herbert J. Skuhra.
900 [__FreeBSD__]: Remove "*/" typo after "#include".
901 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
902 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
903 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
904 Don't assume EMACS_TIME and struct timeval are the same type.
906 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
908 Support higher-resolution time stamps (Bug#9000).
909 The time stamps are only nanosecond-resolution at the C level,
910 since that's the best that any real-world system supports now.
911 But they are picosecond-resolution at the Lisp level, as that's
912 easy, and leaves room for future OS improvements.
914 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
917 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
918 Don't get current time unless it's needed.
920 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
921 now provides it if it's absent.
922 (start_atimer): Port to higher-res time stamps.
923 Check for time stamp overflow. Don't get current time more
924 often than is needed.
926 * buffer.h (struct buffer): Buffer modtime now has high resolution.
927 Include systime.h, not time.h.
928 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
930 * dired.c: Include stat-time.h.
931 (Ffile-attributes): File times now have higher resolution.
933 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
934 (struct image): Timestamp now has higher resolution.
936 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
937 has at least microseconds now. All uses removed.
938 (update_frame, update_single_window, update_window, update_frame_1)
939 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
941 * editfns.c (time_overflow): Now extern.
942 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
943 (float-time, Fformat_time_string, Fcurrent_time_string)
944 (Fcurrent_time_zone): Accept and generate higher-resolution
946 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
947 (decode_time_components, lisp_seconds_argument): New functions.
948 (make_time): Now static.
949 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
950 Report an error if the time is invalid, rather than having the caller
953 * fileio.c: Include <stat-time.h>
954 (Fcopy_file): Copy higher-resolution time stamps.
955 Prefer to set the time stamp via a file descriptor if that works.
956 (Fset_file_times, Finsert_file_contents, Fwrite_region)
957 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
958 (Fvisited_file_modtime, Fset_visited_file_modtime):
959 Support higher-resolution time stamps.
961 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
963 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
965 * image.c (prepare_image_for_display, clear_image_cache)
966 (lookup_image): Port to higer-resolution time stamps.
968 * keyboard.c (start_polling, bind_polling_period):
969 Check for time stamp overflow.
970 (read_char, kbd_buffer_get_event, timer_start_idle)
971 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
972 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
973 Port to higher-resolution time stamps. Do not assume time_t is signed.
974 (decode_timer): New function. Timers are now vectors of length 9,
975 not 8, to accommodate the picosecond component.
976 (timer_check_2): Use it.
978 * nsterm.m (select_timeout, timeval_subtract): Remove.
979 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
980 as they're a bit more accurate and handle overflow better.
981 (ns_select): Change prototype to be compatible with pselect.
982 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
983 * nsterm.h (ns_select): Adjust prototype.
985 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
986 us-resolution time stamps.
987 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
989 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
991 * lisp.h (time_overflow): New decl.
992 (wait_reading_process_output): First arg is now intmax_t, not int,
993 to accommodate larger waits.
995 * process.h (struct Lisp_Process.read_output_delay):
996 Now counts nanoseconds, not microseconds.
997 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
999 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1000 (wait_reading_process_output):
1001 Port to ns-resolution time stamps.
1002 (Faccept_process_output, wait_reading_process_output):
1003 Check for time stamp overflow. Do not assume time_t is signed.
1004 (select_wrapper): Remove; we now use pselect.
1005 (Fprocess_attributes): Now generates ns-resolution time stamps.
1007 * sysdep.c: Include utimens.h. Don't include utime.h
1008 or worry about struct utimbuf; gnulib does that for us now.
1009 (gettimeofday): Remove; gnulib provides a substitute.
1010 (make_timeval): New function.
1011 (set_file_times): Now sets ns-resolution time stamps.
1012 New arg FD; all uses changed.
1013 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1014 (system_process_attributes):
1015 Now returns ns-resolution time stamp. All uses changed.
1016 Check for time stamp overflow.
1018 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1019 provides a substitute now.
1021 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1022 since it guarantees struct timespec.
1023 (EMACS_TIME): Now struct timespec, so that we can support
1024 ns-resolution time stamps.
1025 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1026 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1027 (EMACS_USECS): Remove.
1028 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1029 so multiply the arg by 1000 before storing it.
1030 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1032 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1033 Port to ns-resolution time stamps.
1034 (EMACS_TIME_NEG_P): Remove; replaced by....
1035 (EMACS_TIME_SIGN): New macro.
1036 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1037 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1038 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1039 (make_timeval, make_lisp_time, decode_time_components): New decls.
1040 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1041 that it mishandled time_t overflow. You can't compare by subtracting!
1042 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1043 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1045 * term.c: Include <sys/time.h>.
1046 (timeval_to_Time): New function, for proper overflow wraparound.
1047 (term_mouse_position, term_mouse_click): Use it.
1049 * undo.c (record_first_change): Support higher-resolution time stamps
1051 (Fprimitive_undo): Use them when restoring time stamps.
1053 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1054 (w32_get_internal_run_time):
1055 Port to higher-resolution Emacs time stamps.
1056 (ltime): Now accepts single 64-bit integer, as that's more convenient
1059 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1061 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1062 for compatibility with pselect. Support ns-resolution time stamps.
1064 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1066 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1067 Check for time stamp overflow, and support ns-resolution time stamps.
1069 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1070 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1071 (timeval_subtract): Remove; no longer needed.
1072 (XTflash, XTring_bell, x_wait_for_event):
1073 Port to ns-resolution time stamps. Don't assume time_t is signed.
1075 2012-06-22 Chong Yidong <cyd@gnu.org>
1077 * xdisp.c (x_consider_frame_title): Revert last change.
1079 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1081 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1082 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1083 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1084 staticidx goes up to 1597 out of 1600 = 0x640.)
1086 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1088 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1089 Otherwise, the umask might be mistakenly 0 while handling input signals.
1091 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1093 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1095 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1097 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1098 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1099 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1100 access to `contents' member of Lisp_Vector objects with AREF and ASET
1103 2012-06-19 Chong Yidong <cyd@gnu.org>
1105 * frame.c (delete_frame): When selecting a frame on a different
1106 text terminal, do not alter the terminal's top-frame.
1108 * xdisp.c (format_mode_line_unwind_data): Record the target
1109 frame's selected window and its terminal's top-frame.
1110 (unwind_format_mode_line): Restore them.
1111 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1113 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1114 since tty frames can be explicitly named.
1115 (prepare_menu_bars): Likewise.
1117 * term.c (Ftty_top_frame): New function.
1119 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1121 Port byte-code-meter to modern targets.
1122 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1123 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1124 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1125 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1126 (METER_1, METER_2): Simplify.
1128 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1130 * data.c (Fdefalias): Return `symbol' (bug#11686).
1132 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1134 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1135 gets killed during executing of this function (Bug#11665).
1136 Try to always return Qt when the buffer has been actually killed.
1137 (Vkill_buffer_query_functions): In doc-string say that functions
1138 run by this hook should not change the current buffer.
1140 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1142 Fix recently-introduced process.c problems found by static checking.
1143 * process.c (write_queue_push, write_queue_pop, send_process):
1144 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1145 (write_queue_pop): Fix pointer signedness problem.
1146 (send_process): Remove unused local.
1148 2012-06-17 Chong Yidong <cyd@gnu.org>
1150 * xdisp.c (redisplay_internal): No need to redisplay terminal
1151 frames that are not on top.
1153 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1155 * process.c (make_process): Initialize write_queue.
1156 (write_queue_push, write_queue_pop): New functions.
1157 (send_process): Use them to maintain correct ordering of process
1160 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1162 * lisp.h (eassert): Assume C89 or later.
1163 This removes the need for CHECK.
1164 (CHECK): Remove. Its comments about always evaluating its
1165 argument were confusing, as 'eassert' typically does not evaluate
1168 * coding.c (produce_chars): Use ptrdiff_t, not int.
1170 * xterm.c (x_draw_underwave): Check for integer overflow.
1171 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1173 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1175 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1176 referenced (Bug#11583).
1178 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1180 Implement wave-style variant of underlining.
1181 * dispextern.h (face_underline_type): New enum.
1182 (face): Add field for underline type.
1183 * nsterm.m (ns_draw_underwave): New function.
1184 (ns_draw_text_decoration): Use it.
1185 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1187 (x_draw_glyph_string): Use them.
1188 * xfaces.c (Qline, Qwave): New Lisp objects.
1189 (check_lface_attrs, merge_face_ref)
1190 (Finternal_set_lisp_face_attribute, realize_x_face):
1191 Handle wave-style underline face attributes.
1192 * xterm.c (x_draw_underwave): New function.
1193 (x_draw_glyph_string): Use it.
1195 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1197 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1198 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1199 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1200 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1201 ($(BLD)/w32select.$(O)): Update dependencies.
1203 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1205 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1206 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1207 * character.c (_fetch_multibyte_char_p): Remove.
1208 * alloc.c: Include "character.h" before "buffer.h".
1210 * buffer.c: Likewise.
1211 * bytecode.c: Likewise.
1212 * callint.c: Likewise.
1213 * callproc.c: Likewise.
1214 * casefiddle.c: Likewise.
1215 * casetab.c: Likewise.
1216 * category.c: Likewise.
1218 * coding.c: Likewise.
1219 * composite.c: Likewise.
1220 * dired.c: Likewise.
1221 * dispnew.c: Likewise.
1223 * dosfns.c: Likewise.
1224 * editfns.c: Likewise.
1225 * emacs.c: Likewise.
1226 * fileio.c: Likewise.
1227 * filelock.c: Likewise.
1229 * fontset.c: Likewise.
1230 * fringe.c: Likewise.
1231 * indent.c: Likewise.
1232 * insdel.c: Likewise.
1233 * intervals.c: Likewise.
1234 * keyboard.c: Likewise.
1235 * keymap.c: Likewise.
1236 * lread.c: Likewise.
1237 * macros.c: Likewise.
1238 * marker.c: Likewise.
1239 * minibuf.c: Likewise.
1240 * nsfns.m: Likewise.
1241 * nsmenu.m: Likewise.
1242 * print.c: Likewise.
1243 * process.c: Likewise.
1244 * regex.c: Likewise.
1245 * region-cache.c: Likewise.
1246 * search.c: Likewise.
1247 * syntax.c: Likewise.
1249 * textprop.c: Likewise.
1251 * unexsol.c: Likewise.
1252 * w16select.c: Likewise.
1253 * w32fns.c: Likewise.
1254 * w32menu.c: Likewise.
1255 * window.c: Likewise.
1256 * xdisp.c: Likewise.
1258 * xmenu.c: Likewise.
1260 * xselect.c: Likewise.
1262 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1264 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1265 If all the glyphs of the glyph row came from strings, and we have no
1266 cursor positioning clues, put the cursor on the first glyph of the
1268 (handle_face_prop): Use chunk-relative overlay string index when
1269 indexing into it->string_overlays array. (Bug#11653)
1270 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1271 the rightmost. (Bug#11720)
1273 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1275 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1276 (CATEGORY_MEMBER): Enforce 1/0 value.
1277 * category.c (_temp_category_set): Remove.
1279 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1281 * window.c (Fdelete_other_windows_internal)
1282 (Fdelete_window_internal): Don't access frame's mouse highlight
1283 info of the initial frame. (Bug#11677)
1285 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1287 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1288 Assume USE_2_TAGS_FOR_INTS.
1289 (xreload): Adjust $tagmask width to match recent lisp.h change.
1291 Simplify lisp.h in minor ways that should not affect code.
1292 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1293 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1294 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1295 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1296 (INTTYPEBITS): New macro, for clarity.
1297 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1298 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1299 Simplify now that USE_LSB_TAG is always defined.
1300 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1301 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1303 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1305 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1307 2012-06-13 Glenn Morris <rgm@gnu.org>
1309 * s/bsd-common.h (BSD4_3):
1310 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1312 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1314 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1317 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1319 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1320 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1321 * alloc.c (widen_to_Lisp_Object): Remove.
1322 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1323 * frame.c (delete_frame): Remove outdated comment.
1324 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1325 USE_LISP_UNION_TYPE.
1326 (Fw32_unregister_hot_key): Likewise.
1327 (Fw32_toggle_lock_key): Likewise.
1328 * w32menu.c (add_menu_item): Likewise.
1329 (w32_menu_display_help): Use XIL instead of checking
1330 USE_LISP_UNION_TYPE.
1331 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1332 (init_heap): Likewise.
1333 * w32term.c (w32_read_socket): Update comment.
1335 2012-06-13 Glenn Morris <rgm@gnu.org>
1337 * s/usg5-4-common.h, src/s/unixware.h:
1338 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1340 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1342 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1344 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1345 * alloc.c (make_number) [!defined make_number]:
1346 Remove, as lisp.h always defines this now.
1347 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1348 (roundup_size): Verify that it is a power of 2.
1349 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1350 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1351 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1352 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1353 USE_LSB_TAG now is always defined to be either 0 or 1.
1355 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1356 code works fine either way, and efficiency is not a concern here,
1357 as the union type is for debugging, not for production.
1358 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1359 Use an inline function on all platforms when using the union type,
1360 since this is simpler and 'static inline' can be used portably
1362 (LISP_INITIALLY_ZERO): New macro.
1363 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1364 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1366 2012-06-12 Glenn Morris <rgm@gnu.org>
1368 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1370 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1372 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1373 Move BROKEN_SIGIO to configure.
1375 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1376 Move NO_TERMIO to configure.
1378 2012-06-12 Chong Yidong <cyd@gnu.org>
1380 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1381 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1382 MagickExportImagePixels is undefined.
1384 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1386 * image.c (imagemagick_load_image): Remove unused label.
1388 2012-06-11 Glenn Morris <rgm@gnu.org>
1390 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1391 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1392 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1393 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1395 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1397 * alloc.c (make_byte_code): New function.
1398 (Fmake_byte_code): Use it. Don't purify here.
1399 * lread.c (read1): Use it as well to avoid extra allocation.
1401 2012-06-11 Chong Yidong <cyd@gnu.org>
1403 * image.c (imagemagick_load_image): Implement transparency.
1405 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1407 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1408 account for preceding backslashes. (Bug#11663)
1410 2012-06-09 Chong Yidong <cyd@gnu.org>
1412 * term.c: Support italics in capable terminals (Bug#9652).
1413 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1414 (turn_on_face): Output using TS_enter_italic_mode if available.
1415 Don't handle unused blinking and alt-charset cases.
1416 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1417 and tty_alt_charset_p cases.
1418 (tty_capable_p, init_tty): Support italics.
1420 * termchar.h (struct tty_display_info): Add field for italics.
1421 Remove unused blink field.
1423 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1426 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1427 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1428 tty_alt_charset_p. Add tty_italic_p.
1430 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1432 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1433 dbus_type_is_basic if available.
1434 (xd_extract_signed, xd_extract_unsigned): Rename from
1435 extract_signed and extract_unsigned, respectively. Adapt callers.
1437 2012-06-09 Chong Yidong <cyd@gnu.org>
1439 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1441 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1444 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1446 * xdisp.c (vmessage): Treat frame message as multibyte.
1447 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1448 would generate the diagnostic "Making \302\247 buffer-local while
1451 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1453 * dispnew.c (showing_window_margins_p): Undo last change, which
1454 was done due to an inadvertent commit.
1455 (adjust_frame_glyphs_for_frame_redisplay): Do call
1456 showing_window_margins_p.
1458 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1460 * eval.c (Fmake_var_non_special): New primitive.
1461 (syms_of_eval): Defsubr it.
1462 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1464 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1466 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1467 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1469 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1471 * alloc.c (allocate_vectorlike): Fix last change.
1473 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1475 Block-based vector allocation of small vectors.
1476 * lisp.h (struct vectorlike_header): New field `nbytes',
1477 adjust comment accordingly.
1478 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1479 to denote vector blocks. Adjust users (live_vector_p,
1480 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1481 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1482 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1483 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1484 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1485 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1486 (roundup_size): New constant.
1487 (struct vector_block): New data type.
1488 (vector_blocks, vector_free_lists, zero_vector): New variables.
1489 (all_vectors): Rename to `large_vectors'.
1490 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1491 (sweep_vectors): New functions.
1492 (allocate_vectorlike): Return `zero_vector' as the only vector of
1493 0 items. Allocate new vector from block if vector size is less than
1494 or equal to VBLOCK_BYTES_MAX.
1495 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1496 (init_alloc_once): Add call to init_vectors.
1498 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1500 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1502 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1504 * doprnt.c (doprnt): Truncate multibyte char correctly.
1505 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1506 would mishandle a string argument "Xc" if X was a multibyte
1507 character of length 2: it would truncate after X's first byte
1508 rather than including all of X.
1510 2012-06-06 Chong Yidong <cyd@gnu.org>
1512 * buffer.c (word_wrap): Doc fix.
1514 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1516 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1518 2012-06-03 Glenn Morris <rgm@gnu.org>
1520 * xdisp.c (tool-bar-style): Doc fix.
1522 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1524 * Makefile.in (PAXCTL): Define.
1525 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1526 binary via PaX flags if the paxctl utility is available.
1527 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1528 Restore PaX flags to their default. (Bug#11398)
1530 2012-06-03 Chong Yidong <cyd@gnu.org>
1532 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1535 2012-06-03 Chong Yidong <cyd@gnu.org>
1537 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1538 (note_mode_line_or_margin_highlight): If there is no help echo,
1539 use mode-line-default-help-echo. Handle the case where the mouse
1540 position is past the end of the mode line string.
1542 * buffer.c (buffer_local_value_1): New function, split from
1543 Fbuffer_local_value; can return Qunbound.
1544 (Fbuffer_local_value): Use it.
1545 (Vmode_line_format): Docstring tweaks.
1547 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1549 * sysdep.c (system_process_attributes): Improve comment.
1551 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1553 * keyboard.c: Export real-this-command to Elisp.
1554 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1555 and DEFVAR it. Update all users.
1557 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1559 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1561 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1562 Convert pctcpu and pctmem to Lisp float properly.
1563 Let the compiler fold better, as 100.0/0x8000 is exact.
1565 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1567 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1570 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1572 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1574 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1576 For a 'struct window', replace some Lisp_Object fields to
1577 bitfields where appropriate, remove unused fields.
1578 * window.h (struct window): Remove unused 'last_mark_x' and
1579 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1580 change it's type from Lisp_Object to bitfield.
1581 Change type of 'force_start', 'optional_new_start',
1582 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1583 fields from Lisp_Object to bitfield. Adjust users accordingly.
1585 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1587 Pacify gcc -Wdouble-precision when using Xaw.
1588 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1589 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1590 Use 'float' consistently, rather than 'float' in most places
1591 and 'double' in a couple of places.
1593 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1595 * xdisp.c (handle_stop): Detect whether we have overlay strings
1596 loaded by testing it->current.overlay_string_index to be
1597 non-negative, instead of checking whether n_overlay_strings is
1598 positive. (Bug#11587)
1600 2012-05-31 Chong Yidong <cyd@gnu.org>
1602 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1604 * doc.c (Fsubstitute_command_keys): Doc fix.
1606 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1608 * search.c (search_buffer): Remove calls to
1609 r_alloc_inhibit_buffer_relocation, as it is now called by
1610 maybe_unify_char, which was the cause of relocation of buffer text
1613 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1615 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1616 for the duration of call to load_charset, to avoid problems with
1617 callers of maybe_unify_char that access buffer text through C
1620 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1621 decrement the inhibition flag, instead of just setting or
1624 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1626 Remove obsolete '#define static' cruft.
1627 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1628 This #undef was "temporary" in 2000; it is no longer needed
1629 now that '#define static' has gone away.
1630 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1631 (gray_bitmap_bits): Remove; no longer needed.
1632 All uses replaced with definiens.
1633 * xterm.c: Include "bitmaps/gray.xbm".
1635 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1637 Clean up __executable_start, monstartup when --enable-profiling.
1638 The following changes affect the code only when profiling.
1639 * dispnew.c (__executable_start): Rename from safe_bcopy.
1640 Define only on platforms that need it.
1641 * emacs.c: Include <sys/gmon.h> when profiling.
1642 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1643 (__executable_start): Remove decl, since lisp.h does it now.
1644 (safe_bcopy): Remove decl; no longer has that name.
1645 (main): Coalesce #if into single bit of code, for simplicity.
1646 Cast pointers to uintptr_t, since standard libraries want integers
1648 * lisp.h (__executable_start): New decl.
1650 2012-05-31 Glenn Morris <rgm@gnu.org>
1652 * image.c (Fimagemagick_types): Doc fix.
1654 2012-05-30 Jim Meyering <meyering@redhat.com>
1656 * callproc.c (Fcall_process_region): Include directory component
1657 in mkstemp error message (Bug#11586).
1659 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1661 * alloc.c, lisp.h (make_pure_vector): Now static.
1663 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1665 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1666 Move to byte-run.el.
1667 (Fautoload): Do the hash-doc more carefully.
1668 * data.c (Fdefalias): Purify definition, except for keymaps.
1669 (Qdefun): Move from eval.c.
1670 * lisp.h (Qdefun): Remove.
1671 * lread.c (read1): Tiny simplification.
1673 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1675 Do not create empty overlays with the evaporate property (Bug#9642).
1676 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1677 Bug#9642, but explicitly check that the buffer the overlay would
1678 be moved to is live and rearrange lines to make sure that errors
1679 will not put the overlay in an inconsistent state.
1680 (Fdelete_overlay): Cosmetics.
1682 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1684 * w32term.c (my_bring_window_to_top): New function.
1685 (x_raise_frame): Use handle returned by DeferWindowPos, which
1686 could be different from the original one.
1687 Call my_bring_window_to_top instead of my_set_foreground_window.
1690 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1691 by calling BringWindowToTop.
1693 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1694 (WM_EMACS_END): Increase by one.
1696 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1698 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1699 This avoids undefined behavior that might cause the eassert
1700 to not catch an out-of-range value.
1702 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1704 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1705 Update dependencies.
1707 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1709 * bidi.c (bidi_mirror_char): Fix last change.
1711 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1713 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1714 when referring to sectname field in printf format.
1716 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1718 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1719 Only r_alloc_inhibit_buffer_relocation needed to be added;
1720 the others were already declared.
1722 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1723 before checking whether it's out of range. Put the check inside
1725 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1727 2012-05-27 Ken Brown <kbrown@cornell.edu>
1729 * callproc.c (Fcall_process): Restore a line that was accidentally
1730 commented out in the 2011-02-13 change (bug#11547).
1732 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1734 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1735 defined on ralloc.c.
1737 * buffer.c [REL_ALLOC]: Remove prototypes of
1738 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1739 they are now on lisp.h.
1741 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1743 * search.c (search_buffer): Use it to inhibit relocation of buffer
1744 text while re_search_2 is doing its job, because re_search_2 is
1745 passed C pointers to buffer text. (Bug#11519)
1747 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1750 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1751 state after an additional call to move_it_in_display_line_to, keep
1752 the values of it->max_ascent and it->max_descent found for the
1754 (pos_visible_p): Revert the comparison against bottom_y to what it
1755 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1758 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1760 Fix coding-related core dumps with gcc -ftrapv.
1761 The code was computing A - B, where A and B are pointers, and B is
1762 random garbage. This can lead to core dumps on platforms that
1763 have special pointer registers, and it also leads to core dumps on
1764 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1765 A - B only when B is initialized properly.
1766 * coding.c (coding_set_source, coding_set_destination): Return void.
1767 (coding_change_source, coding_change_destinations): New functions,
1768 with the old behaviors of coding_set_source and coding_set_destination.
1769 All callers that need an offset changed to use these new functions.
1771 2012-05-26 Glenn Morris <rgm@gnu.org>
1773 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1775 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1777 Extend mouse support on W32 text-mode console.
1778 * xdisp.c (draw_row_with_mouse_face):
1779 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1781 * w32console.c: Include window.h.
1782 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1784 (initialize_w32_display): Initialize mouse-highlight data.
1786 * w32inevt.c: Include termchar.h and window.h.
1787 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1788 moves, call note_mouse_highlight. If help_echo changed, call
1789 gen_help_event to produce help-echo message in the echo area.
1790 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1793 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1795 * lread.c (read1): Simplify slightly to avoid an overflow warning
1796 with GCC 4.7.0 on x86-64.
1798 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1800 * bidi.c (bidi_mirror_char): Revert last change: an int is
1801 definitely wide enough here.
1803 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1805 Fix integer width and related bugs (Bug#9874).
1806 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1807 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1808 (string_bytes, check_sblock, allocate_string_data):
1809 (compact_small_strings, Fmake_bool_vector, make_string)
1810 (make_unibyte_string, make_multibyte_string)
1811 (make_string_from_bytes, make_specified_string)
1812 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1813 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1816 (allocate_pseudovector):
1817 Use int, not EMACS_INT, where int is wide enough.
1818 (inhibit_garbage_collection, Fgarbage_collect):
1819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1820 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1821 int might not be wide enough.
1822 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1823 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1824 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1825 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1826 (bidi_level_of_next_char, bidi_move_to_visually_next):
1827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1828 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1829 (Fkill_buffer, Fset_buffer_major_mode)
1830 (advance_to_char_boundary, Fbuffer_swap_text)
1831 (Fset_buffer_multibyte, overlays_at, overlays_in)
1832 (overlay_touches_p, struct sortvec, record_overlay_string)
1833 (overlay_strings, recenter_overlay_lists)
1834 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1835 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1836 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1837 (Foverlay_recenter, last_overlay_modification_hooks_used)
1838 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1840 (validate_region): Omit unnecessary test for b <= e,
1841 since that's guaranteed by the previous test.
1842 (adjust_overlays_for_delete): Avoid pos + length overflow.
1843 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1844 (report_overlay_modification):
1845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1846 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1847 Omit pointer cast, which isn't needed anyway, and doesn't work
1848 after the EMACS_INT -> ptrdiff_t change.
1849 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1850 * buffer.h: Adjust decls to match defn changes elsewhere.
1851 (struct buffer_text, struct buffer):
1852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1853 Use EMACS_INT, not int, where int might not be wide enough.
1854 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1855 not int, to avoid needless 32-bit limit on 64-bit hosts.
1856 (exec_byte_code): Use tighter memory-full test, one that checks
1857 for alloca overflow. Don't compute the address of the object just
1858 before an array, as that's not portable. Use EMACS_INT, not
1859 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1860 * callint.c (Fcall_interactively):
1861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1862 * callproc.c (call_process_kill, Fcall_process):
1863 Don't assume pid_t fits into an Emacs fixnum.
1864 (call_process_cleanup, Fcall_process, child_setup):
1865 Don't assume pid_t fits into int.
1866 (call_process_cleanup, Fcall_process, delete_temp_file)
1867 (Fcall_process_region):
1868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1869 (Fcall_process): Simplify handling of volatile integers.
1870 Use int, not EMACS_INT, where int will do.
1871 * casefiddle.c (casify_object, casify_region, operate_on_word)
1872 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1874 (casify_object): Avoid integer overflow when overallocating buffer.
1875 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1876 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1877 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1878 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1879 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1880 integers are now checked earlier. All uses replaced with XINT.
1882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1883 For CCL_MapSingle, check that content and value are in int range.
1884 (ccl_driver, Fregister_code_conversion_map):
1885 Check that Vcode_version_map_vector is a vector.
1886 (resolve_symbol_ccl_program): Check that vector header is in range.
1887 Always copy the vector, so that we can check its contents reliably
1888 now rather than having to recheck each instruction as it's being
1889 executed. Check that vector words fit in 'int'.
1890 (ccl_get_compiled_code, Fregister_ccl_program)
1891 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1892 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1893 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1894 contents are in range.
1895 (Fccl_execute_on_string): Check that status is in range.
1896 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1897 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1898 Accept and return EMACS_INT, not int, because callers can pass values
1900 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1901 (multibyte_chars_in_text, parse_str_as_multibyte)
1902 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1903 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1904 (string_escape_byte8, Fget_byte):
1905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1906 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1907 avoid mishandling large integers.
1908 * character.h: Adjust decls to match defn changes elsewhere.
1909 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1910 (Ffind_charset_region):
1911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1912 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1913 (load_charset_map_from_vector, Fdefine_charset_internal):
1914 Don't assume fixnum fits in int.
1915 (load_charset_map_from_vector, Fmap_charset_chars):
1916 Remove now-unnecessary CHECK_NATNUMs.
1917 (Fdefine_charset_internal): Check ranges here, more carefully.
1918 Don't rely on undefined behavior with signed left shift overflow.
1919 Don't assume unsigned int fits into fixnum, or that fixnum fits
1920 into unsigned int. Don't require max_code to be a valid fixnum;
1921 that's not true for gb10830 4-byte on a 32-bit host. Allow
1922 invalid_code to be a cons, for the same reason. Require code_offset
1923 to be a character. Avoid int overflow if max_char is close
1925 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1926 this is intended anyway and avoids some undefined behavior.
1927 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1928 INDEX_TO_CODE_POINT, as that's what it expects.
1929 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1930 * charset.h (DECODE_CHAR): Return int, not unsigned;
1931 this is what was intended anyway, and it avoids undefined behavior.
1932 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1933 integer-overflow issues.
1934 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1935 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1936 where the argument is EMACS_INT, and this behavior is not intended.
1937 * chartab.c (Fmake_char_table, Fset_char_table_range)
1938 (uniprop_get_decoder, uniprop_get_encoder):
1939 Don't assume fixnum fits in int.
1940 * cmds.c (move_point): New function, that does the gist of
1941 Fforward_char and Fbackward_char, but does so while checking
1942 for integer overflow more accurately.
1943 (Fforward_char, Fbackward_char): Use it.
1944 (Fforward_line, Fend_of_line, internal_self_insert)
1945 (internal_self_insert):
1946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1947 Fix a FIXME, by checking for integer overflow when calculating
1948 target_clm and actual_clm.
1949 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1950 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1951 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1952 (coding_alloc_by_making_gap, alloc_destination)
1953 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1954 (encode_coding_utf_16, detect_coding_emacs_mule)
1955 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1956 (detect_coding_iso_2022, decode_coding_iso_2022)
1957 (encode_invocation_designation, encode_designation_at_bol)
1958 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1959 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1960 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1961 (encode_coding_ccl, encode_coding_raw_text)
1962 (detect_coding_charset, decode_coding_charset)
1963 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1964 (produce_composition, produce_charset, produce_annotation)
1965 (decode_coding, handle_composition_annotation)
1966 (handle_charset_annotation, consume_chars, decode_coding_gap)
1967 (decode_coding_object, encode_coding_object, detect_coding_system)
1968 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1969 (code_convert_region, code_convert_string)
1970 (Fdefine_coding_system_internal)
1971 (coding_set_source, coding_set_destination):
1972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1973 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1974 (Fdefine_coding_system_internal):
1975 Don't assume fixnums fit in int.
1976 (decode_coding_gap, decode_coding_object, encode_coding_object)
1977 (Fread_coding_system, Fdetect_coding_region)
1978 (Funencodable_char_position, Fcheck_coding_systems_region)
1979 (get_translation, handle_composition_annotation, consume_chars):
1980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1981 (consume_chars): Rewrite to not calculate an address outside buffer.
1982 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1983 Don't access memory outside of the args array.
1984 (Fdefine_coding_system_internal): Check for charset-id overflow.
1985 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1986 result of ENCODE_CHAR.
1987 * coding.h: Adjust decls to match defn changes elsewhere.
1988 (struct coding_system):
1989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1990 * composite.c (get_composition_id, find_composition)
1991 (run_composition_function, update_compositions)
1992 (compose_text, composition_gstring_put_cache)
1993 (composition_gstring_p, composition_gstring_width)
1994 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1995 (composition_compute_stop_pos, composition_reseat_it)
1996 (composition_update_it, struct position_record)
1997 (find_automatic_composition, composition_adjust_point)
1998 (Fcomposition_get_gstring, Ffind_composition_internal):
1999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2000 (update_compositions):
2001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2002 * composite.h: Adjust decls to match defn changes elsewhere.
2003 (struct composition):
2004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2005 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2006 Do not attempt to compute the address of the object just before a
2007 buffer; this is not portable.
2009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2010 (Faset): Use int, not EMACS_INT, where int is wide enough.
2011 (Fstring_to_number): Don't assume fixnums fit in int.
2012 (Frem): Don't assume arg is nonnegative.
2013 * dbusbind.c (xd_append_arg): Check for integers out of range.
2014 (Fdbus_call_method): Don't overflow the timeout int.
2015 (extract_signed, extract_unsigned): New functions.
2016 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2017 (xd_get_connection_references): Return ptrdiff_t, not int.
2019 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2020 (xd_read_message_1):
2021 Use int, not unsigned, where the dbus API uses int.
2022 (Fdbus_message_internal): Don't overflow mtype.
2023 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2024 * dired.c (directory_files_internal, file_name_completion, scmp)
2025 (file_name_completion_stat):
2026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2027 (file_name_completion): Don't overflow matchcount.
2028 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2029 * dispextern.h: Adjust decls to match defn changes elsewhere.
2030 (struct text_pos, struct glyph, struct bidi_saved_info)
2031 (struct bidi_string_data, struct bidi_it, struct composition_it)
2033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2034 (struct display_pos, struct composition_it, struct it):
2035 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2036 * dispnew.c (increment_matrix_positions)
2037 (increment_row_positions, mode_line_string)
2038 (marginal_area_string):
2039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2040 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2042 (duration_to_sec_usec): New function, to check for overflow better.
2043 (Fsleep_for, sit_for): Use it.
2044 * doc.c (get_doc_string, store_function_docstring):
2045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2046 (get_doc_string, Fsnarf_documentation):
2047 Use int, not EMACS_INT, where int is wide enough.
2049 Use SAFE_ALLOCA, not alloca.
2050 Check for overflow when converting EMACS_INT to off_t.
2051 * doprnt.c (doprnt):
2052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2053 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2054 Don't assume uid_t fits into fixnum.
2055 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2056 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2057 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2058 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2059 (general_insert_function)
2060 (Finsert_char, make_buffer_string, make_buffer_string_both)
2061 (update_buffer_properties, Fbuffer_substring)
2062 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2063 (Fsubst_char_in_region, check_translation)
2064 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2065 (transpose_markers, Ftranspose_regions):
2066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2067 (clip_to_bounds): Move to lisp.h as an inline function).
2068 (Fconstrain_to_field): Don't assume integers are nonnegative.
2069 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2070 (Fsubst_char_in_region, Fsave_restriction):
2071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2072 (Femacs_pid): Don't assume pid_t fits into fixnum.
2073 (lo_time): Use int, not EMACS_INT, when int suffices.
2074 (lisp_time_argument): Check for usec out of range.
2075 (Fencode_time): Don't assume fixnum fits in int.
2076 (Fuser_login_name, Fuser_full_name): Signal an error
2077 if a uid argument is out of range, rather than relying on
2079 (Fformat_time_string): Remove now-unnecessary check.
2080 lisp_time_argument checks for out-of-range usec now.
2081 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2082 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2083 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2084 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2085 (init_cmdargs, Fdump_emacs):
2086 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2087 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2088 the bottom (typically) 32 bits of the fixnum.
2089 * eval.c (specpdl_size, call_debugger):
2090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2091 (when_entered_debugger, Fbacktrace_debug):
2092 Don't assume fixnum can fit in int.
2093 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2094 the object just before a buffer; this is not portable.
2095 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2096 (grow_specpdl, unbind_to):
2097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2098 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2099 (grow_specpdl): Simplify allocation by using xpalloc.
2100 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2101 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2102 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2104 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2106 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2107 (Fcopy_file, non_regular_nbytes, read_non_regular)
2108 (Finsert_file_contents):
2109 Use int, not EMACS_INT, where int is wide enough.
2110 (READ_BUF_SIZE): Verify that it fits in int.
2111 (Finsert_file_contents): Check that counts are in proper range,
2112 rather than assuming fixnums fit into ptrdiff_t etc.
2113 Don't assume fixnums fit into int.
2114 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2115 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2116 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2117 (string_char_to_byte, string_byte_to_char)
2118 (string_make_multibyte, string_to_multibyte)
2119 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2120 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2121 (substring_both, Fdelete, internal_equal, Ffillarray)
2122 (Fclear_string, mapcar1)
2123 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2124 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2125 (larger_vector, make_hash_table, maybe_resize_hash_table)
2126 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2127 (Fmaphash, secure_hash):
2128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2129 (concat): Check for string index and length overflow.
2130 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2133 (larger_vector): New API (vec, incr_min, size_max) replaces old
2134 one (vec, new_size, init). This catches size overflow.
2135 INIT was removed because it was always Qnil.
2136 All callers changed.
2137 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2138 the upper bound on a hash table index size.
2139 (make_hash_table, maybe_resize_hash_table): Use it.
2140 (secure_hash): Computer start_byte and end_byte only after
2141 they're known to be in ptrdiff_t range.
2142 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2143 (Ffont_get_glyphs, Ffont_at):
2144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2145 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2146 (Flist_fonts, Fopen_font):
2147 Don't assume fixnum can fit in int.
2148 (check_gstring): Don't assume index can fit in int.
2149 (font_match_p): Check that fixnum is a character, not a nonnegative
2150 fixnum, since the later code needs to stuff it into an int.
2151 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2152 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2153 conversion overflow issues.
2154 (Fopen_font): Check for integer out of range.
2155 (Ffont_get_glyphs): Don't assume index can fit in int.
2156 * font.h: Adjust decls to match defn changes elsewhere.
2157 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2159 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2160 printmax_t, where ptrdiff_t is wide enough.
2161 (Finternal_char_font):
2162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2163 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2164 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2165 (Fset_frame_position, x_set_frame_parameters)
2166 (x_set_line_spacing, x_set_border_width)
2167 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2168 Check that fixnums are in proper range for system types.
2169 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2171 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2172 Use SAFE_ALLOCA_LISP, not alloca.
2173 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2174 intptr_t is wide enough.
2175 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2176 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2177 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2178 Check for fixnum out of range.
2179 * ftfont.c (ftfont_list): Don't assume index fits in int.
2180 Check that fixnums are in proper range for system types.
2181 (ftfont_shape_by_flt):
2182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2183 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2185 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2186 Check that fixnums are in proper range for system types.
2187 * gnutls.h: Adjust decls to match defn changes elsewhere.
2188 * gtkutil.c (xg_dialog_run):
2189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2190 (update_frame_tool_bar):
2191 Check that fixnums are in proper range for system types.
2192 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2193 (lookup_image): Check that fixnums are in range for system types.
2194 * indent.c (last_known_column, last_known_column_point):
2195 (current_column_bol_cache):
2196 (skip_invisible, current_column, check_display_width):
2197 (check_display_width, scan_for_column, current_column_1)
2198 (Findent_to, Fcurrent_indentation, position_indentation)
2199 (indented_beyond_p, Fmove_to_column, compute_motion):
2200 (Fcompute_motion, Fvertical_motion):
2201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2202 (last_known_column_modified): Use EMACS_INT, not int.
2203 (check_display_width):
2205 Check that fixnums and floats are in proper range for system types.
2206 (compute_motion): Don't assume index or fixnum fits in int.
2207 (compute_motion, Fcompute_motion):
2208 Use int, not EMACS_INT, when it is wide enough.
2209 (vmotion): Omit local var start_hpos that is always 0; that way
2210 we don't need to worry about overflow in expressions involving it.
2211 * indent.h: Adjust decls to match defn changes elsewhere.
2213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2214 Use int, not EMACS_INT, where int is wide enough.
2215 Remove unused members ovstring_chars_done and tab_offset;
2217 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2218 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2219 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2220 (make_gap, copy_text, insert, insert_and_inherit)
2221 (insert_before_markers, insert_before_markers_and_inherit)
2222 (insert_1, count_combining_before, count_combining_after)
2223 (insert_1_both, insert_from_string)
2224 (insert_from_string_before_markers, insert_from_string_1)
2225 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2226 (adjust_after_replace, adjust_after_insert, replace_range)
2227 (replace_range_2, del_range, del_range_1, del_range_byte)
2228 (del_range_both, del_range_2, modify_region)
2229 (prepare_to_modify_buffer, signal_before_change)
2230 (signal_after_change, Fcombine_after_change_execute):
2231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2232 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2233 (balance_an_interval, split_interval_right, split_interval_left)
2234 (find_interval, next_interval, update_interval)
2235 (adjust_intervals_for_insertion, delete_node, delete_interval)
2236 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2237 (static_offset_intervals, offset_intervals)
2238 (merge_interval_right, merge_interval_left, make_new_interval)
2239 (graft_intervals_into_buffer, temp_set_point_both)
2240 (temp_set_point, set_point, adjust_for_invis_intang)
2241 (set_point_both, move_if_not_intangible, get_property_and_range)
2242 (get_local_map, copy_intervals, copy_intervals_to_string)
2243 (compare_string_intervals, set_intervals_multibyte_1):
2244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2245 * intervals.h: Adjust decls to match defn changes elsewhere.
2247 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2248 * keyboard.c (this_command_key_count, this_single_command_key_start)
2249 (before_command_key_count, before_command_echo_length, echo_now)
2250 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2251 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2252 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2253 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2255 (last_non_minibuf_size, last_point_position, echo_truncate)
2256 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2257 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2258 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2259 (stuff_buffered_input):
2260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2261 (last_auto_save, command_loop_1, read_char):
2262 Use EMACS_INT, not int, to avoid integer overflow.
2263 (record_char): Avoid overflow in total_keys computation.
2264 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2265 * keyboard.h: Adjust decls to match defn changes elsewhere.
2266 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2267 (Fkey_description, Fdescribe_vector, Flookup_key):
2268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2269 (click_position): New function, to check that positions are in range.
2270 (Fcurrent_active_maps):
2272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2273 (Faccessible_keymaps, Fkey_description):
2274 (preferred_sequence_p):
2275 Don't assume fixnum can fit into int.
2276 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2277 Check for integer overflow in size calculations.
2278 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2279 avoid mishandling large integers.
2280 * lisp.h: Adjust decls to match defn changes elsewhere.
2281 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2282 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2283 (struct Lisp_Marker):
2284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2285 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2286 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2287 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2288 All callers changed.
2289 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2290 Assume the arg has valid form, since it always does.
2291 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2292 unsigned integer system type.
2293 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2294 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2296 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2297 (duration_to_sec_usec): New decl.
2298 * lread.c (read_from_string_index, read_from_string_index_byte)
2299 (read_from_string_limit, readchar, unreadchar, openp)
2300 (read_internal_start, read1, oblookup):
2301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2302 (Fload, readevalloop, Feval_buffer, Feval_region):
2303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2304 (openp): Check for out-of-range argument to 'access'.
2305 (read1): Use int, not EMACS_INT, where int is wide enough.
2306 Don't assume fixnum fits into int.
2307 Fix off-by-one error that can read outside a buffer.
2308 (read_filtered_event): Use duration_to_sec_usec
2309 to do proper overflow checking on durations.
2310 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2311 in size calculation.
2312 (Fexecute_kbd_macro):
2313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2314 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2315 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2316 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2317 (set_marker_both, set_marker_restricted_both, marker_position)
2318 (marker_byte_position, Fbuffer_has_markers_at):
2319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2320 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2321 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2322 It now merely ensures that the menu is large enough, without
2323 necessarily growing it, as this avoids some integer overflow issues.
2324 All callers changed.
2325 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2327 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2328 Use SAFE_ALLOCA_LISP, not alloca.
2329 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2330 to EMACS_INT. Check that fixnums are in proper range for system types.
2331 * minibuf.c (minibuf_prompt_width, string_to_object)
2332 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2333 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2335 (get_minibuffer, read_minibuf_unwind):
2336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2337 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2338 this simplifies overflow checking. All callers changed.
2339 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2341 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2342 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2343 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2344 Check that fixnums are in proper range for system types.
2345 (Fx_create_frame, Fx_show_tip):
2346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2347 * nsfont.m (ns_findfonts, nsfont_list_family):
2348 Don't assume fixnum fits in long.
2349 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2350 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2351 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2353 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2355 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2356 (PRINTDECLARE, PRINTPREPARE):
2357 (strout, print_string):
2358 (print, print_preprocess, print_check_string_charset_prop)
2360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2362 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2363 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2364 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2365 (printchar, strout): Use xpalloc to catch size calculation overflow.
2366 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2367 (print_error_message): Use SAFE_ALLOCA, not alloca.
2368 (print_object): Use int, not EMACS_INT, where int is wide enough.
2369 (print_depth, new_backquote_output, print_number_index):
2370 Use ptrdiff_t, not int, where int might not be wide enough.
2371 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2372 (Fset_process_window_size, Fformat_network_address)
2373 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2375 Check that fixnums are in proper range for system types.
2376 (Fsignal_process): Simplify by avoiding a goto.
2377 Check for process-ids out of pid_t range rather than relying on
2379 (process_tick, update_tick): Use EMACS_INT, not int.
2380 (Fformat_network_address, read_process_output, send_process)
2381 (Fprocess_send_region, status_notify):
2382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2383 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2384 (wait_reading_process_output, read_process_output, exec_sentinel):
2385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2386 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2387 (Faccept_process_output): Use duration_to_sec_usec to do proper
2388 overflow checking on durations.
2389 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2390 Don't assume pid_t fits in int.
2391 * process.h (struct Lisp_Process): Members tick and update_tick
2392 are now of type EMACS_INT, not int.
2393 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2394 configured --with-wide-int.
2395 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2396 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2397 * search.c (looking_at_1, string_match_1):
2398 (fast_string_match, fast_c_string_match_ignore_case)
2399 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2400 (scan_newline, find_before_next_newline, search_command)
2401 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2402 (set_search_regs, wordify):
2405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2406 (string_match_1, search_buffer, set_search_regs):
2408 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2409 (wordify): Check for overflow in size calculation.
2410 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2411 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2412 Check that fixnums are in proper range for system types.
2413 * sound.c (struct sound_device)
2414 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2416 (Fplay_sound_internal):
2417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2418 * syntax.c (struct lisp_parse_state, find_start_modiff)
2419 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2420 (Fparse_partial_sexp):
2421 Don't assume fixnums can fit in int.
2422 (struct lisp_parse_state, find_start_pos, find_start_value)
2423 (find_start_value_byte, find_start_begv)
2424 (update_syntax_table, char_quoted, dec_bytepos)
2425 (find_defun_start, prev_char_comend_first, back_comment):
2426 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2427 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2429 (Finternal_describe_syntax_value): Check that match_lisp is a
2430 character, not an integer, since the code stuffs it into int.
2431 (scan_words, scan_sexps_forward):
2432 Check that fixnums are in proper range for system types.
2434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2435 (scan_sexps_forward):
2436 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2437 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2438 * syntax.h: Adjust decls to match defn changes elsewhere.
2439 (struct gl_state_s):
2440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2441 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2442 MOST_POSITIVE_FIXNUM.
2443 * sysdep.c (wait_for_termination_1, wait_for_termination)
2444 (interruptible_wait_for_termination, mkdir):
2445 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2446 (emacs_read, emacs_write):
2447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2448 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2449 and double all fit in int.
2450 * term.c (set_tty_color_mode):
2451 Check that fixnums are in proper range for system types.
2452 * termhooks.h (struct input_event):
2453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2454 * textprop.c (validate_interval_range, interval_of)
2455 (Fadd_text_properties, set_text_properties_1)
2456 (Fremove_text_properties, Fremove_list_of_text_properties)
2457 (Ftext_property_any, Ftext_property_not_all)
2458 (copy_text_properties, text_property_list, extend_property_ranges)
2459 (verify_interval_modification):
2460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2461 (Fnext_single_char_property_change)
2462 (Fprevious_single_char_property_change):
2463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2464 (copy_text_properties):
2465 Check for integer overflow in index calculation.
2466 * undo.c (last_boundary_position, record_point, record_insert)
2467 (record_delete, record_marker_adjustment, record_change)
2468 (record_property_change):
2469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2470 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2472 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2473 (Fx_hide_tip, Fx_file_dialog):
2474 * w32menu.c (set_frame_menubar):
2475 Use ptrdiff_t, not int, for consistency with rest of code.
2476 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2477 (select_window, Fdelete_other_windows_internal)
2478 (window_scroll_pixel_based, window_scroll_line_based)
2479 (Frecenter, Fset_window_configuration):
2480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2481 (Fset_window_hscroll, run_window_configuration_change_hook)
2482 (set_window_buffer, temp_output_buffer_show, scroll_command)
2483 (Fscroll_other_window, Frecenter):
2484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2485 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2486 Don't assume fixnum fits in int.
2487 (Fset_window_scroll_bars):
2488 Check that fixnums are in proper range for system types.
2489 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2490 (string_pos, c_string_pos, number_of_chars, init_iterator)
2491 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2492 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2493 (compute_display_string_end, handle_face_prop)
2494 (face_before_or_after_it_pos, handle_invisible_prop)
2495 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2496 (display_prop_intangible_p, string_buffer_position_lim)
2497 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2498 (get_overlay_strings_1, get_overlay_strings)
2499 (iterate_out_of_display_property, forward_to_next_line_start)
2500 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2501 (get_next_display_element, set_iterator_to_next)
2502 (get_visually_first_element, compute_stop_pos_backwards)
2503 (handle_stop_backwards, next_element_from_buffer)
2504 (move_it_in_display_line_to, move_it_in_display_line)
2505 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2506 (add_to_log, message_dolog, message_log_check_duplicate)
2507 (message2, message2_nolog, message3, message3_nolog
2508 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2509 (current_message_1, truncate_echo_area, truncate_message_1)
2510 (set_message, set_message_1, store_mode_line_noprop)
2511 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2512 (text_outside_line_unchanged_p, check_point_in_composition)
2513 (reconsider_clip_changes)
2514 (redisplay_internal, set_cursor_from_row, try_scrolling)
2515 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2516 (redisplay_window, find_last_unchanged_at_beg_row)
2517 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2518 (trailing_whitespace_p, find_row_edges, display_line)
2519 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2520 (display_mode_element, store_mode_line_string)
2521 (pint2str, pint2hrstr, decode_mode_spec)
2522 (display_count_lines, display_string, draw_glyphs)
2523 (x_produce_glyphs, x_insert_glyphs)
2524 (rows_from_pos_range, mouse_face_from_buffer_pos)
2525 (fast_find_string_pos, mouse_face_from_string_pos)
2526 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2528 (safe_call, init_from_display_pos, handle_fontified_prop)
2529 (handle_single_display_spec, load_overlay_strings)
2530 (with_echo_area_buffer, setup_echo_area_for_printing)
2531 (display_echo_area, echo_area_display)
2532 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2533 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2534 (redisplay_window, dump_glyph_row, display_mode_line)
2535 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2536 (handle_display_spec, display_prop_string_p):
2537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2538 (handle_single_display_spec, build_desired_tool_bar_string)
2539 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2540 (get_specified_cursor_type):
2541 Check that fixnums are in proper range for system types.
2542 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2543 (Flookup_image_map):
2544 Don't assume fixnums fit in int.
2545 (compare_overlay_entries):
2546 Avoid mishandling comparisons due to subtraction overflow.
2547 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2548 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2549 (handle_tool_bar_click):
2550 Use int, not unsigned, since we prefer signed and the signedness
2551 doesn't matter here.
2552 (get_next_display_element, next_element_from_display_vector):
2553 Use int, not EMACS_INT, when int is wide enough.
2554 (start_hourglass): Use duration_to_sec_usec to do proper
2555 overflow checking on durations.
2556 * xfaces.c (Fbitmap_spec_p):
2557 Check that fixnums are in proper range for system types.
2558 (compare_fonts_by_sort_order):
2559 Avoid mishandling comparisons due to subtraction overflow.
2560 (Fx_family_fonts, realize_basic_faces):
2561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2563 Don't assume fixnum fits in int.
2564 Use SAFE_ALLOCA_LISP, not alloca.
2565 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2566 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2567 (face_at_buffer_position, face_for_overlay_string)
2568 (face_at_string_position):
2569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2570 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2571 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2573 Check that fixnums are in proper range for system types.
2574 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2575 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2577 (Fx_change_window_property): Don't assume fixnums fit in int.
2578 * xfont.c (xfont_chars_supported):
2579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2580 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2581 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2583 * xml.c (parse_region):
2584 * xrdb.c (magic_file_p):
2585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2586 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2587 (x_get_local_selection, x_reply_selection_request)
2588 (x_handle_selection_request, wait_for_property_change):
2589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2590 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2591 short is wide enough.
2592 (x_send_client_event): Don't assume fixnum fits in int.
2593 * xterm.c (x_x_to_emacs_modifiers):
2594 Don't assume EMACS_INT overflows nicely into int.
2595 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2597 (handle_one_xevent): NATNUMP can eval its arg twice.
2598 (x_connection_closed):
2599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2600 * xterm.h: Adjust decls to match defn changes elsewhere.
2601 (struct scroll_bar): Use struct vectorlike_header
2602 rather than rolling our own approximation.
2603 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2605 2012-05-25 Glenn Morris <rgm@gnu.org>
2607 * lisp.mk (lisp): Update for more files being compiled now.
2609 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2611 * lread.c: Remove `read_pure' which makes no difference.
2612 (read_pure): Remove var.
2613 (unreadpure): Remove function.
2614 (readevalloop): Don't call read_list with -1 flag.
2615 (read1, read_vector): Don't test read_pure any more.
2616 (read_list): Simplify.
2618 * fileio.c, character.h: Minor style tweaks.
2620 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2622 * window.h (clip_changed): Remove useless declaration.
2624 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2626 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2627 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2629 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2632 This directory predates autoconf and is no longer needed nowadays.
2633 Move its few remaining bits of functionality to where they're needed.
2634 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2635 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2636 * m/template.h: Remove.
2637 * Makefile.in (M_FILE): Remove. All uses removed.
2638 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2639 * lisp.h (USE_LSB_TAG):
2640 * mem-limits.h (EXCEEDS_LISP_PTR):
2641 Use VAL_MAX, not VALBITS, in #if.
2642 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2643 (EMACS_UINT): Define unconditionally now.
2644 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2645 (BITS_PER_EMACS_INT): New constants, replacing
2646 what used to be in config.h, but not useful in #if.
2647 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2648 define them any more.
2649 (VAL_MAX): New macro.
2651 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2652 BITS_PER_EMACS_INT, in #if.
2653 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2654 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2655 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2656 * s/ms-w32.h (DATA_START):
2657 Move here from removed file m/intel386.h.
2658 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2659 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2661 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2663 Assume C89 or later.
2664 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2665 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2667 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2668 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2669 * textprop.c, tparam.c (NULL): Remove.
2670 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2671 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2672 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2673 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2674 * xterm.c (input_signal_count): Assume volatile works.
2676 2012-05-21 Ken Brown <kbrown@cornell.edu>
2678 * xgselect.c (xg_select): Fix first argument in call to 'select'
2681 2012-05-20 Ken Brown <kbrown@cornell.edu>
2683 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2684 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2686 2012-05-19 Ken Brown <kbrown@cornell.edu>
2688 * xfns.c (x_in_use): Remove `static' qualifier.
2689 * xterm.h (x_in_use): Declare.
2690 * xgselect.c: Include xterm.h.
2691 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2692 and `display_arg' (bug#9754).
2694 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2696 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2698 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2699 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2701 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2703 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2705 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2706 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2708 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2709 reference to image_cache->refcount.
2710 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2712 2012-05-17 Juri Linkov <juri@jurta.org>
2714 * search.c (Fword_search_regexp, Fword_search_backward)
2715 (Fword_search_forward, Fword_search_backward_lax)
2716 (Fword_search_forward_lax): Move functions to isearch.el
2717 (bug#10145, bug#11381).
2719 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2721 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2723 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2725 * lread.c (init_obarray): Declare Qt and Qnil as special.
2727 2012-05-14 Glenn Morris <rgm@gnu.org>
2729 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2730 Put "libexec" before "bin", for the sake of init_callproc_1.
2732 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2734 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2736 * unexaix.c: Port to more-recent AIX compilers.
2737 (report_error, report_error_1, make_hdr, copy_sym)
2738 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2739 Make arguments const char *, not char *, to avoid violations of C
2740 standard and to fix some AIX warnings reported by Gilles Pion.
2742 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2744 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2745 already have overlays loaded.
2746 (handle_single_display_spec): Before returning without displaying
2747 fringe bitmap, synchronize the bidi iterator with the main display
2748 iterator, by calling iterate_out_of_display_property.
2749 (iterate_out_of_display_property): Detect buffer iteration by
2750 testing that it->string is a Lisp string.
2751 (get_next_display_element): When the current object is exhausted,
2752 and there's something on it->stack, call set_iterator_to_next to
2753 proceed with what's on the stack, instead of returning zero.
2754 (set_iterator_to_next): If called at the end of a Lisp string,
2755 proceed to consider_string_end without incrementing string
2756 position. Don't increment display vector index past the end of
2757 the display vector. (Bug#11417)
2758 (pos_visible_p): Don't report a position visible when move_it_to
2759 stopped at the last line of window, which happens to be scanned
2760 backwards by the bidi iteration. (Bug#11464)
2762 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2764 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2765 and right-margin display specs even if the spec is invalid or we
2766 are on a TTY, and thus unable to display on the fringes.
2767 That's because the text with the property will not be displayed anyway,
2768 so we need to signal to the caller that this is a "replacing"
2769 display spec. This fixes display when the spec is invalid or we
2772 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2774 * unexaix.c (make_hdr): Fix typo in prototype.
2775 This bug broke the build on AIX. Problem reported by Gilles Pion.
2777 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2779 * keyboard.c (kbd_buffer_get_event): Read special events also in
2780 batch mode. (Bug#11415)
2782 2012-05-12 Glenn Morris <rgm@gnu.org>
2784 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2786 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2788 * lisp.mk (lisp): Add newcomment.elc.
2790 2012-05-12 Glenn Morris <rgm@gnu.org>
2792 * Makefile.in (MKDIR_P): New, set by configure.
2793 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2795 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2797 Remove unused function hourglass_started.
2798 * dispextern.h (hourglass_started):
2799 * w32fns.c (hourglass_started):
2800 * xdisp.c (hourglass_started): Remove.
2802 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2804 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2805 Update dependencies.
2807 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2809 * xgselect.c (xg_select): Put maxfds+1 into a var.
2810 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2812 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2814 2012-05-10 Dave Abrahams <dave@boostpro.com>
2816 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2817 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2819 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2821 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2822 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2823 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2824 Initialize xd_registered_buses.
2826 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2828 Untag more efficiently if USE_LSB_TAG.
2829 This is based on a proposal by YAMAMOTO Mitsuharu in
2830 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2831 For an admittedly artificial (nth 8000 longlist) benchmark on
2832 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2833 Emacs's overall text size by 1%.
2834 * lisp.h (XUNTAG): New macro.
2835 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2836 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2837 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2838 * eval.c (Fautoload):
2839 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2840 * frame.h (XFRAME): Use XUNTAG.
2842 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2843 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2844 Remove unportable assumptions about print widths of types like
2846 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2847 intptr_t when converting between pointer and integer, to avoid GCC
2848 warnings about wrong width.
2850 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2852 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2853 stack for each reader_thread, instead of defaulting to 8MB
2854 determined by the linker. This avoids failures in creating
2855 subprocesses on Windows 7, see the discussion in this thread:
2856 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2858 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2860 Fix up display of the *Minibuf-0* buffer in the mini window.
2861 * keyboard.c (read_char): Don't clear the echo area if there's no
2863 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2864 contents of *Minibuf-0*) if there's no message displayed in its stead.
2866 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2868 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2871 2012-05-06 Chong Yidong <cyd@gnu.org>
2873 * lisp.mk (lisp): Update.
2875 2012-05-05 Jim Meyering <meyering@redhat.com>
2877 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2879 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2881 * data.c (PUT_ERROR): New macro.
2882 (syms_of_data): Use it. Add new error type `user-error'.
2883 * undo.c (user_error): New function.
2884 (Fprimitive_undo): Use it.
2885 * print.c (print_error_message): Adjust print style for `user-error'.
2886 * keyboard.c (user_error): New function.
2887 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2889 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2891 Do not limit current-time-string to years 1000..9999.
2892 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2893 (Fcurrent_time_string): Support any year that is supported by the
2894 underlying localtime representation. Don't use asctime, as it
2895 has undefined behavior for years outside the range -999..9999.
2897 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2899 Fix race conditions involving setenv, gmtime, localtime, asctime.
2900 Without this fix, interrupts could mess up code that uses these
2901 nonreentrant functions, since setting TZ invalidates existing
2902 tm_zone or tzname values, and since most of these functions return
2903 pointers to static storage.
2904 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2905 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2906 Grow the critical sections to include not just invoking
2907 localtime/gmtime, but also accessing these functions' results
2908 including their tm_zone values if any, and any related TZ setting.
2909 (format_time_string): Last arg is now struct tm *, not struct tm **,
2910 so that the struct tm is saved in the critical section.
2911 All callers changed. Simplify allocation of initial buffer, partly
2912 motivated by the fact that memory allocation needs to be outside
2913 the critical section.
2915 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2917 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2918 with RESET_INTERVAL.
2920 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2921 Remove duplicated buffer name initialization.
2923 2012-05-02 Jim Meyering <jim@meyering.net>
2925 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2927 * xfns.c (x_window): Use xstrdup (Bug#11375).
2929 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2931 * xdisp.c (pos_visible_p): If already at a newline from the
2932 display string before the 'while' loop, don't walk back the glyphs
2933 from it3.glyph_row. Solves assertion violation when the display
2934 string begins with a newline (egg.el). (Bug#11367)
2936 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2938 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2941 2012-05-01 Glenn Morris <rgm@gnu.org>
2943 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2944 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2945 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2946 All were removed before 23.1.
2948 * dispnew.c: Remove HAVE_LIBNCURSES test;
2949 it is always true on relevant platforms.
2951 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2952 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2954 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2956 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2958 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2959 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2962 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2964 Do not avoid creating empty evaporating overlays (Bug#9642).
2965 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2966 That is, do not delete an evaporating overlay if it becomes
2967 empty after its bounds are adjusted to fit within its buffer.
2968 This fix caused other problems, and I'm reverting it until we get
2969 to the bottom of them.
2971 2012-04-27 Chong Yidong <cyd@gnu.org>
2973 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2975 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2977 * xdisp.c (pos_visible_p): If the window start position is beyond
2978 ZV, start the display from buffer beginning. Prevents assertion
2979 violation in init_iterator when the minibuffer window is scrolled
2982 * window.c (window_scroll_pixel_based): Likewise.
2984 2012-04-27 Chong Yidong <cyd@gnu.org>
2986 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2988 2012-04-27 Glenn Morris <rgm@gnu.org>
2990 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2991 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2993 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2995 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2996 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2998 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3000 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3001 display element, check also the underlying string or buffer
3002 character. (Bug#11341)
3004 * w32menu.c: Include w32heap.h.
3005 (add_menu_item): If the call to AppendMenuW (via
3006 unicode_append_menu) fails, disable Unicode menus only if we are
3007 running on Windows 9X/Me.
3009 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3011 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3012 (xgetint): Add missing shift for LSB tags.
3014 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3016 * keyboard.c (read_char): Don't wipe echo area for select window
3017 events: These might get delayed via `mouse-autoselect-window'
3020 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3022 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3023 manipulation of :loaded-from data.
3025 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3027 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3028 now a cons (bug#11311).
3030 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3032 Do not create empty overlays with the evaporate property (Bug#9642).
3033 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3034 if it becomes empty after its bounds are adjusted to fit within
3035 its buffer. Without this fix, in a nonempty buffer (let ((o
3036 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3037 yields an empty overlay that has the evaporate property, which is
3038 not supposed to happen.
3040 Fix minor GTK3 problems found by static checking.
3041 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3042 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3043 (struct _EmacsFixedClass, emacs_fixed_get_type):
3044 Move decls here from emacsgtkfixed.h, since they needn't be public.
3045 (emacs_fixed_get_type): Now static.
3046 (emacs_fixed_class_init): Omit unused local.
3047 (emacs_fixed_child_type): Remove; unused.
3048 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3049 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3050 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3051 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3052 (EMACS_FIXED_GET_CLASS): Remove; unused.
3053 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3055 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3056 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3058 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3060 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3061 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3062 (__malloc_size_t, __malloc_ptrdiff_t):
3063 Remove. All uses removed, replaced by the definiens if needed,
3064 since we can assume C89 or better now.
3065 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3066 (protect_malloc_state, align, get_contiguous_space)
3067 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3068 (malloc_atfork_handler_child, malloc_enable_thread)
3069 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3070 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3071 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3072 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3073 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3074 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3075 Define using prototypes, not old style.
3076 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3077 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3078 (align): Don't assume that signed integer overflow wraps around.
3079 Omit unused local var.
3080 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3081 (_free_internal_nolock, memalign, mallochook, reallochook):
3082 Omit no-longer-needed casts.
3083 (valloc): Use getpagesize, not __getpagesize.
3084 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3085 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3087 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3089 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3091 Move functions from C to Lisp. Make non-blocking method calls
3092 the default. Implement further D-Bus standard interfaces.
3094 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3095 (QCdbus_request_name_allow_replacement)
3096 (QCdbus_request_name_replace_existing)
3097 (QCdbus_request_name_do_not_queue)
3098 (QCdbus_request_name_reply_primary_owner)
3099 (QCdbus_request_name_reply_in_queue)
3100 (QCdbus_request_name_reply_exists)
3101 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3102 (QCdbus_registered_serial, QCdbus_registered_method)
3103 (QCdbus_registered_signal): New Lisp objects.
3104 (XD_DEBUG_MESSAGE): Use sizeof.
3105 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3106 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3107 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3108 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3109 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3110 (xd_signature, xd_append_arg): Allow float for integer types.
3111 (xd_get_connection_references): New function.
3112 (xd_get_connection_address): Rename from xd_initialize.
3113 Return cached address.
3114 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3115 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3117 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3118 Return number of refcounts.
3119 (Fdbus_get_unique_name): Make stronger parameter check.
3120 (Fdbus_message_internal): New defun.
3121 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3122 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3123 (Fdbus_send_signal, Fdbus_register_service)
3124 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3125 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3126 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3127 (Vdbus_compiled_version, Vdbus_runtime_version)
3128 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3129 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3130 (Vdbus_message_type_signal): New defvars.
3131 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3134 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3136 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3137 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3138 Do not assume ptrdiff_t is the same width as 'int'.
3140 * alloc.c: Handle unusual debugging option combinations.
3141 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3142 since the two debugging options are incompatible.
3143 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3145 (mem_init, mem_insert, mem_insert_fixup):
3146 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3147 (NEED_MEM_INSERT): Remove; no longer needed.
3149 2012-04-22 Leo Liu <sdl.web@gmail.com>
3151 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3153 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3155 * sysdep.c [__FreeBSD__]: Minor cleanups.
3156 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3157 Use Emacs indenting style more consistently. Avoid some casts.
3158 Use 'double' consistently rather than mixing 'float' and 'double'.
3160 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3162 * sysdep.c (list_system_processes, system_process_attributes):
3163 Add implementation for FreeBSD (Bug#5243).
3165 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3167 * lisp.mk (lisp): Update.
3169 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3171 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3172 It is never used otherwise.
3174 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3176 * print.c (print_preprocess): Only check print_depth if print-circle
3178 (print_object): Check for cycles even when print-circle is nil and
3179 print-gensym is t, but only check print_depth if print-circle is nil.
3181 2012-04-20 Chong Yidong <cyd@gnu.org>
3183 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3184 set the status to "failed" and ensure that sentinel is run.
3186 2012-04-20 Glenn Morris <rgm@gnu.org>
3188 * process.c (Fset_process_inherit_coding_system_flag)
3189 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3190 (Fmake_network_process, Fmake_serial_process): Doc fix.
3192 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3194 * xdisp.c (string_buffer_position_lim): Limit starting position to
3196 (set_cursor_from_row): If called for a mode-line or header-line
3197 row, return zero immediately.
3198 (try_cursor_movement): If inside continuation line, don't back up
3199 farther than the first row after the header line, if any.
3200 Don't consider the header-line row as "partially visible", even if
3201 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3203 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3205 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3208 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3209 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3211 configure: new option --enable-gcc-warnings (Bug#11207)
3212 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3213 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3214 (ALL_CFLAGS): Use new macros rather than old.
3215 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3216 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3217 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3218 -Wunused-result, -Wunused-variable. This should go away once
3219 the Emacs and Gnulib regex code is merged.
3220 (xmalloc, xrealloc): Now static.
3222 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3224 * dired.c (Fsystem_groups): Remove unused local.
3226 2012-04-17 Glenn Morris <rgm@gnu.org>
3228 * dired.c (Fsystem_users): Doc fix.
3230 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3232 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3233 (syms_of_dired): Add them.
3235 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3237 Fix minor alloc.c problems found by static checking.
3238 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3239 New extern decls, to avoid calling undeclared functions.
3240 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3241 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3242 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3243 (NEED_MEM_INSERT): New macro.
3244 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3245 Remove one incorrect comment and fix another.
3247 Fix minor ralloc.c problems found by static checking.
3248 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3249 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3250 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3251 (r_alloc_sbrk): Now static.
3253 Improve ralloc.c interface checking.
3254 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3255 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3256 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3257 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3258 [REL_ALLOC]: ... to here, to check interface.
3259 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3260 Remove decls. This fixes an "It stinks!".
3262 * alloc.c (which_symbols): Fix alignment issue / type clash.
3264 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3266 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3267 (struct Lisp_Misc_Any): Likewise.
3268 (struct Lisp_Free): Likewise.
3269 * alloc.c (union aligned_Lisp_Symbol): Define.
3270 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3271 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3272 (union aligned_Lisp_Misc): Define.
3273 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3274 aligned_Lisp_Misc instead of union Lisp_Misc.
3275 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3277 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3279 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3280 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3281 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3282 * s/netbsd.h, s/sol2-6.h:
3283 Remove definition of GC_MARK_STACK, since the default now works.
3284 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3285 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3286 no longer the default.
3287 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3289 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3291 * lread.c (lisp_file_lexically_bound_p):
3292 Fix hang at ";-*-\n" (bug#11238).
3294 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3296 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3297 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3299 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3301 * nsterm.m (constrainFrameRect): Always constrain when there is only
3302 one screen (Bug#10962).
3304 2012-04-13 Ken Brown <kbrown@cornell.edu>
3306 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3308 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3310 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3312 2012-04-11 Daniel Colascione <dancol@dancol.org>
3314 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3315 against is gone. It's better to use vfork now so that when Cygwin
3316 gains a new, working vfork, we use it automatically (bug#10398).
3318 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3320 * window.c (save_window_save): Obey window-point-insertion-type.
3322 2012-04-11 Glenn Morris <rgm@gnu.org>
3324 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3326 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3328 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3330 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3332 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3333 (force_quit_count): New var.
3334 (handle_interrupt): Use it.
3336 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3338 * w32.c (w32_delayed_load): Record the full path of the library
3339 being loaded (bug#10424).
3341 2012-04-09 Glenn Morris <rgm@gnu.org>
3343 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3344 not just in the obarray, before snarfing them. (Bug#11036)
3346 * Makefile.in ($(leimdir)/leim-list.el):
3347 Pass EMACS rather than BUILT_EMACS.
3349 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3351 * process.c (make_process):
3352 * process.h: Add integer `gnutls_handshakes_tried' member to
3355 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3356 Add convenience `GNUTLS_LOG2i' macro.
3358 * gnutls.c (gnutls_log_function2i): Convenience log function.
3359 (emacs_gnutls_read): Use new log functions,
3360 `gnutls_handshakes_tried' process member, and
3361 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3362 attempts per process (connection).
3364 2012-04-09 Chong Yidong <cyd@gnu.org>
3366 * eval.c (Fuser_variable_p, user_variable_p_eh)
3367 (lisp_indirect_variable): Functions deleted.
3368 (Fdefvar): Caller changed.
3370 * callint.c (Finteractive, Fcall_interactively):
3371 * minibuf.c (Fread_variable): Callers changed.
3373 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3375 * xdisp.c (set_cursor_from_row): If the display string appears in
3376 the buffer at position that is closer to point than the position
3377 after the display string, display the cursor on the first glyph of
3378 the display string. Fixes cursor display when a 'display' text
3379 property immediately follows invisible text. (Bug#11094)
3381 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3383 composite.c: use 'double' consistently
3384 * composite.c (get_composition_id): Use 'double' consistently
3385 instead of converting 'float' to 'double' and vice versa; this is
3386 easier to understand and avoids a GCC warning.
3388 2012-04-09 Glenn Morris <rgm@gnu.org>
3390 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3391 preparation for dumping it with emacs. (Bug#4789)
3392 (leimdir): New variable.
3393 ($(leimdir)/leim-list.el): New rule.
3394 (emacs$(EXEEXT)): Depend on leim-list.el.
3396 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3397 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3398 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3400 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3402 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3405 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3407 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3408 Remove unused local variable.
3410 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3412 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3413 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3414 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3415 objects, as mark_maybe_pointer will catch them otherwise.
3416 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3417 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3419 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3421 Fix typo that broke non-Windows builds.
3422 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3424 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3426 Support building on MS-Windows with libxml2.
3428 * makefile.w32-in (OBJ2): Add xml.$(O).
3429 (GLOBAL_SOURCES): Add xml.c.
3430 ($(BLD)/xml.$(O)): New dependency list.
3432 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3433 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3434 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3435 [!WINDOWSNT]: New macros.
3436 (init_libxml2_functions, libxml2_loaded_p): New functions.
3437 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3438 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3439 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3440 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3442 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3443 Call init_libxml2_functions before calling libxml2 functions.
3444 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3446 * emacs.c: Don't include libxml/parser.h.
3447 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3448 xmlCleanupParser directly.
3450 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3452 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3454 * indent.c (Fvertical_motion): If there is a display string at
3455 point, use it.vpos to compute how many lines to backtrack after
3456 move_it_to point. (Bug#11133)
3458 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3460 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3461 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3462 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3463 macros related to unification of CJK characters. For the details,
3464 see the discussion following the message here:
3465 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3467 2012-04-04 Chong Yidong <cyd@gnu.org>
3469 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3471 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3473 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3474 instead of alloca. (Bug#11138)
3476 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3478 * w32menu.c (is_simple_dialog): Properly check lisp types.
3481 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3483 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3484 position we get to after a call to move_it_to fails the
3485 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3486 only if we wind up in a string from display property. (Bug#11063)
3488 * window.c (Fdelete_other_windows_internal): Invalidate the row
3489 and column information about mouse highlight, so that redisplay
3490 restores it after reallocating the glyph matrices. (Bug#7464)
3492 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3493 string comes from a `display' text property, use the buffer
3494 position of that property as if we actually saw that position in
3496 (move_it_by_lines): Remove the assertion that
3497 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3498 violated when there's a before-string at the beginning of a line.
3501 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3503 * xdisp.c (append_space_for_newline): If the default face was
3504 remapped, use the remapped face for the appended newline.
3505 (extend_face_to_end_of_line): Use the remapped default face for
3506 extending the face to the end of the line.
3507 (display_line): Call extend_face_to_end_of_line when the default
3508 face was remapped. (Bug#11068)
3510 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3512 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3514 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3516 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3518 2012-03-27 Glenn Morris <rgm@gnu.org>
3520 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3523 2012-03-26 Kenichi Handa <handa@m17n.org>
3525 * dispextern.h (struct glyph): Fix previous change. Change the
3526 bit length of glyphless.ch to 25 (Bug#11082).
3528 2012-03-26 Chong Yidong <cyd@gnu.org>
3530 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3531 (command_loop_1): Use it; inhibit selection update for
3532 handle-select-window too (Bug#8996).
3534 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3536 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3538 2012-03-25 Kenichi Handa <handa@m17n.org>
3540 * dispextern.h (struct glyph): Change the bit length of
3541 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3543 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3545 * s/ms-w32.h (tzname): Include time.h before redirecting to
3546 _tzname. Fixes the MSVC build. (Bug#9960)
3548 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3550 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3553 * xterm.c (XTread_socket): Only modify handling_signal if
3554 !SYNC_INPUT. (Bug#11080)
3556 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3558 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3559 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3560 when fetching a multibyte character consumes more bytes than
3561 CHAR_BYTES returns, due to unification of CJK characters in
3562 string_char. (Bug#11073)
3564 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3566 * process.c (wait_reading_process_output): Handle pty disconnect
3567 by refraining from sending oneself a SIGCHLD (bug#10933).
3569 2012-03-22 Chong Yidong <cyd@gnu.org>
3571 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3573 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3574 Mark string as coming from a prefix property.
3575 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3576 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3578 2012-03-21 Chong Yidong <cyd@gnu.org>
3580 * xfaces.c (Vface_remapping_alist): Doc fix.
3582 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3584 * w32proc.c (Fw32_set_console_codepage)
3585 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3588 2012-03-20 Chong Yidong <cyd@gnu.org>
3590 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3591 to reflect default non-nil value of redisplay-dont-pause.
3593 2012-03-19 Kenichi Handa <handa@m17n.org>
3595 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3596 it fit in a valid range (Bug#11003).
3598 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3600 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3601 that is not from display property, accept the row as a "cursor
3602 row" if one of the string's character has a non-nil `cursor'
3603 property. Fixes cursor positioning when there are newlines in
3604 overlay strings, e.g. in icomplete.el. (Bug#11035)
3606 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3608 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3610 2012-03-12 Chong Yidong <cyd@gnu.org>
3612 * eval.c (inhibit_lisp_code): Rename from
3613 inhibit_window_configuration_change_hook; move from window.c.
3615 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3616 * window.c (run_window_configuration_change_hook)
3617 (syms_of_window): Callers changed.
3619 2012-03-11 Chong Yidong <cyd@gnu.org>
3621 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3623 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3625 2012-03-10 Chong Yidong <cyd@gnu.org>
3627 * frame.c (other_visible_frames): Don't assume the selected frame
3628 is visible (Bug#10955).
3630 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3632 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3634 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3636 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3637 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3640 2012-03-03 Glenn Morris <rgm@gnu.org>
3642 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3644 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3646 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3647 position past the first glyph_row that ends at ZV. (Bug#10902)
3648 (redisplay_window, next_element_from_string): Fix typos in
3650 (redisplay_window): Pass to move_it_vertically the margin in
3651 pixels, not in screen lines.
3653 2012-03-02 Glenn Morris <rgm@gnu.org>
3655 * buffer.c (buffer-list-update-hook): Doc fix.
3657 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3659 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3660 push_it before setting up the iterator for the first overlay
3661 string, even if we have an empty string loaded.
3662 (next_overlay_string): If there's an empty string on the iterator
3663 stack, pop the stack. (Bug#10903)
3665 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3667 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3668 Suggested by Stefan Monnier in
3669 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3670 * alloc.c (widen_to_Lisp_Object): New static function.
3671 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3672 and widening them to Lisp_Objects. This would work even if
3673 USE_LSB_TAG is defined and wide integers are used, which might
3674 happen in a future version of Emacs.
3676 2012-02-25 Chong Yidong <cyd@gnu.org>
3678 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3681 * xselect.c (Fx_selection_exists_p): Doc fix.
3682 (x_clipboard_manager_save_all): Print an informative message
3683 before saving to clipboard manager.
3685 2012-02-24 Chong Yidong <cyd@gnu.org>
3687 * keyboard.c (process_special_events): Handle all X selection
3688 requests in kbd_buffer, not just the next one (Bug#8869).
3690 2012-02-23 Chong Yidong <cyd@gnu.org>
3692 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3693 call when setting menu-bar-lines and tool-bar-lines parameters.
3694 (unwind_create_frame_1): New helper function.
3696 * window.c (inhibit_window_configuration_change_hook): New var.
3697 (run_window_configuration_change_hook): Obey it.
3698 (syms_of_window): Initialize it.
3700 2012-02-22 Chong Yidong <cyd@gnu.org>
3702 * xterm.c (x_draw_image_relief): Add missing type check for
3703 Vtool_bar_button_margin (Bug#10743).
3705 2012-02-21 Chong Yidong <cyd@gnu.org>
3707 * fileio.c (Vfile_name_handler_alist): Doc fix.
3709 * buffer.c (Fget_file_buffer): Protect against invalid file
3710 handler return value.
3712 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3714 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3715 when computing $valmask.
3717 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3718 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3719 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3720 It's useless in that case, and it can cause problems on hosts
3721 that allocate halves of EMACS_INT values separately.
3722 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3723 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3724 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3725 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3726 it avoids undefined behavior on hosts where shifting right by more
3727 than the word width has undefined behavior.
3729 2012-02-19 Chong Yidong <cyd@gnu.org>
3731 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3732 (Funhandled_file_name_directory, Ffile_name_as_directory)
3733 (Fdirectory_file_name, Fexpand_file_name)
3734 (Fsubstitute_in_file_name): Protect against invalid file handler
3735 return values (Bug#10845).
3737 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3739 * .gdbinit (pitx): Fix incorrect references to fields of the
3742 2012-02-17 Chong Yidong <cyd@gnu.org>
3744 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3746 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3748 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3749 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3751 2012-02-15 Chong Yidong <cyd@gnu.org>
3753 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3754 marked as special. Also, starting docstrings with * is obsolete.
3756 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3758 * gnutls.c (emacs_gnutls_write): Fix last change.
3760 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3762 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3765 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3767 * keymap.c (Fsingle_key_description): Handle char ranges.
3769 2012-02-12 Chong Yidong <cyd@gnu.org>
3771 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3772 as that creates a dangerous corner case.
3774 * window.c (Fdelete_window_internal): Invalidate the mouse
3775 highlight (Bug#9904).
3777 2012-02-12 Glenn Morris <rgm@gnu.org>
3779 * xselect.c (Fx_own_selection_internal)
3780 (Fx_get_selection_internal, Fx_disown_selection_internal)
3781 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3782 * nsselect.m (Fx_own_selection_internal)
3783 (Fx_disown_selection_internal, Fx_selection_exists_p)
3784 (Fx_selection_owner_p, Fx_get_selection_internal):
3785 Sync docs and argument specs with the xselect.c versions.
3787 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3789 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3791 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3793 * w32select.c (Fx_selection_exists_p): Sync doc string and
3794 argument list with xselect.c. (Bug#10783)
3796 * w16select.c (Fx_selection_exists_p): Sync doc string and
3797 argument list with xselect.c. (Bug#10783)
3799 2012-02-10 Glenn Morris <rgm@gnu.org>
3801 * fns.c (Fsecure_hash): Doc fix.
3803 2012-02-09 Kenichi Handa <handa@m17n.org>
3805 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3807 2012-02-07 Chong Yidong <cyd@gnu.org>
3809 * buffer.c (Fbuffer_local_variables)
3810 (buffer_lisp_local_variables): Handle unbound vars correctly;
3811 don't let Qunbound leak into Lisp.
3813 2012-02-07 Glenn Morris <rgm@gnu.org>
3815 * image.c (Fimagemagick_types): Doc fix.
3817 * image.c (imagemagick-render-type): Change it from a lisp object
3818 to an integer. Move the doc here from the lisp manual.
3819 Treat all values not equal to 0 the same.
3821 2012-02-06 Chong Yidong <cyd@gnu.org>
3823 * doc.c (store_function_docstring): Avoid applying docstring of
3824 alias to base function (Bug#2603).
3826 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3828 * .gdbinit (pp1, pv1): Remove redundant defines.
3831 2012-02-04 Chong Yidong <cyd@gnu.org>
3833 * nsterm.m: Declare a global (Bug#10694).
3835 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3837 * w32.c (get_emacs_configuration_options):
3838 Include --enable-checking, if specified, in the return value.
3840 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3842 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3843 after rounding frame sizes. (Bug#9723)
3845 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3847 * keyboard.c (adjust_point_for_property): Don't position point
3848 before BEGV. (Bug#10696)
3850 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3852 Handle overflow when computing char display width (Bug#9496).
3853 * character.c (char_width): Return EMACS_INT, not int.
3854 (char_width, c_string_width): Check for overflow when
3855 computing the width; this is possible now that individual
3856 characters can have unbounded width. Problem introduced
3857 by merge from Emacs 23 on 2012-01-19.
3859 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3861 * dbusbind.c (Fdbus_register_method): Mention the return value
3862 :ignore in the docstring.
3864 2012-02-02 Glenn Morris <rgm@gnu.org>
3866 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3868 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3869 Unconditionally set to t. (Bug#10673)
3870 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3871 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3872 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3874 2012-02-02 Kenichi Handa <handa@m17n.org>
3876 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3877 0, do not call append_composite_glyph.
3879 2012-02-02 Kenichi Handa <handa@m17n.org>
3881 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3883 (x_produce_glyphs): If the component of a composition is a null
3884 string, set it->pixel_width to 1 to avoid zero-width glyph.
3886 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3888 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3889 first 2 arguments are identical. This makes inserting large
3890 output from a subprocess an order of magnitude faster on
3891 MS-Windows, where all sbrk'ed memory is always contiguous.
3893 2012-01-31 Glenn Morris <rgm@gnu.org>
3895 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3896 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3897 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3899 2012-01-29 Glenn Morris <rgm@gnu.org>
3901 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3903 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3905 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3907 2012-01-28 Chong Yidong <cyd@gnu.org>
3909 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3911 2012-01-26 Chong Yidong <cyd@gnu.org>
3913 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3915 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3916 repeat counts (Bug#10507).
3918 2012-01-26 Glenn Morris <rgm@gnu.org>
3920 * lread.c (syms_of_lread): Doc fix.
3922 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3924 * coding.c (encode_designation_at_bol): Change return value to
3927 2012-01-25 Chong Yidong <cyd@gnu.org>
3929 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3931 2012-01-21 Chong Yidong <cyd@gnu.org>
3933 * floatfns.c (Fcopysign): Make the second argument non-optional,
3934 since nil is not allowed anyway.
3936 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3938 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3939 (send_process): Likewise.
3941 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3943 * window.c (save_window_save, Fcurrent_window_configuration)
3944 (Vwindow_persistent_parameters): Do not use Qstate.
3945 Rewrite doc-strings.
3947 2012-01-19 Kenichi Handa <handa@m17n.org>
3949 * character.c (char_width): New function.
3950 (Fchar_width, c_string_width, lisp_string_width):
3951 Use char_width (Bug#9496).
3953 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3955 * window.c (Vwindow_persistent_parameters): New variable.
3956 (Fset_window_configuration, save_window_save): Handle persistent
3959 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3961 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3962 thrashing the stack of the thread. (Bug#9087)
3964 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3966 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3968 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3970 * xdisp.c (rows_from_pos_range): Handle the case where the
3971 highlight ends on a newline. (Bug#10464)
3972 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3973 he end column for display of highlight that ends on a newline
3976 2012-01-11 Glenn Morris <rgm@gnu.org>
3978 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3979 from load-path also when installation-directory is nil. (Bug#10208)
3981 2012-01-10 Glenn Morris <rgm@gnu.org>
3983 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3985 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3986 Update template values to be closer to their typical values these days.
3988 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3990 * xdisp.c (rows_from_pos_range): Accept additional argument
3991 DISP_STRING, and accept any glyph in a row whose object is that
3992 string as eligible for mouse highlight. Fixes mouse highlight of
3993 display strings from overlays. (Bug#10464)
3995 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3997 emacs: fix an auto-save permissions race condition (Bug#10400)
3998 * fileio.c (auto_saving_dir_umask): New static var.
3999 (Fmake_directory_internal): Use it.
4000 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4001 creating the directory. The old code temporarily assigns
4002 too-generous permissions to the directory.
4003 (do_auto_save_eh): Clear it.
4004 (Fdo_auto_save): Catch all errors, not just file errors, so
4005 that the var is always cleared.
4007 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4009 * search.c (scan_buffer): Pass character positions to
4010 know_region_cache, not byte positions. (Bug#6540)
4012 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4014 * w32.c (sys_rename): Report EXDEV when rename of a directory
4015 fails because the target is on another logical disk. (Bug#10284)
4017 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4019 * xterm.c (x_embed_request_focus): New function.
4021 * xterm.h: Add prototype.
4023 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4025 2012-01-05 Glenn Morris <rgm@gnu.org>
4027 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4029 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4031 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4032 Load gnutls_transport_set_lowat only if GnuTLS version is below
4034 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4035 GnuTLS versions below 2.11.1.
4037 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4039 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4040 to the doc string advising against its use for altering the way
4041 windows are scrolled.
4043 2011-12-28 Kenichi Handa <handa@m17n.org>
4045 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4046 coding-system ASCII compatible only when it does not produce BOM
4047 on encoding (Bug#10383).
4049 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4051 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4053 (create_and_show_popup_menu): Always use menu_position_func for
4056 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4058 * callint.c (Fcall_interactively): Don't truncate prompt string.
4060 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4062 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4063 property that ends at ZV, so that the bidi iteration could be
4064 resumed from there (after widening). (Bug#10360)
4066 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4068 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4070 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4072 * nsterm.m (x_free_frame_resources):
4073 Release f->output_data.ns->miniimage.
4074 (ns_index_color): Fix indentation. Do not retain
4075 color_table->colors[i].
4077 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4080 * nsfns.m (x_set_background_color): Assign return value from
4081 ns_index_color to face-background instead of NSColor*.
4082 (ns_implicitly_set_icon_type): Fix indentation.
4083 Change assignment in for loop to comparison.
4085 * emacs.c (ns_pool): New variable.
4086 (main): Assign ns_pool.
4087 (Fkill_emacs): Call ns_release_autorelease_pool.
4089 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4090 autorelease fdesc, release fdAttrs and tdict.
4091 (ns_get_covering_families): Release charset.
4092 (ns_findfonts): Release NSFontDescriptor created with new.
4093 (ns_uni_to_glyphs): Fix indentation.
4094 (setString): Release attrStr before assigning new value.
4096 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4098 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4100 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4101 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4103 2011-12-18 David Reitter <reitter@cmu.edu>
4105 * nsterm.m (ns_term_init): Subscribe for notifications
4106 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4107 to method trackingNotification in EmacsMenu.
4109 * nsmenu.m (trackingMenu): New variable.
4110 (trackingNotification): New method (from Aquamacs).
4111 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4112 from Aquamacs (Bug#7030).
4114 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4116 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4117 (symbol_to_nsstring): Fix indentation.
4118 (ns_symbol_to_pb): New function.
4119 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4120 (Fns_rotate_cut_buffers_internal): Remove.
4121 (Fns_store_selection_internal): Rename from
4122 Fns_store_cut_buffer_internal.
4123 (ns_get_foreign_selection, Fx_own_selection_internal)
4124 (Fx_disown_selection_internal, Fx_selection_exists_p)
4125 (Fns_get_selection_internal, Fns_store_selection_internal):
4126 Use ns_symbol_to_pb and check if return value is nil.
4127 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4128 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4129 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4130 renamed to Sns_store_selection_internal.
4131 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4132 and remove this function.
4133 (ns_handle_selection_clear): Remove, never used.
4134 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4137 2011-12-17 Ken Brown <kbrown@cornell.edu>
4139 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4140 GID is unknown (Bug#10257).
4142 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4144 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4145 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4146 which caused a build failure on GNU/Linux IA-64. This problem was
4147 introduced by my 2011-10-07 patch.
4149 2011-12-15 Juri Linkov <juri@jurta.org>
4151 * image.c (imagemagick_error): New function. (Bug#10112)
4152 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4153 Use `imagemagick_error' where ImageMagick functions return
4155 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4158 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4160 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4161 fill background (Bug#8992).
4163 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4165 * window.c (Vwindow_combination_resize)
4166 (Vwindow_combination_limit): Use t instead of non-nil in
4168 (Vrecenter_redisplay): Add first sentence of doc-string on
4170 (Frecenter): Fix doc-string typo.
4172 2011-12-11 Kenichi Handa <handa@m17n.org>
4174 * coding.c (Funencodable_char_position): Pay attention to the
4175 buffer text relocation (Bug#9389).
4177 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4179 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4180 gtk_init (Bug#10100).
4182 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4184 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4185 IT->string is nil. (Bug#10263)
4187 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4189 * nsterm.h (x_free_frame_resources): Declare.
4191 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4192 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4194 * nsterm.h (ns_get_defaults_value): Declare.
4196 * nsterm.m (ns_default): Call ns_get_defaults_value.
4198 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4200 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4203 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4205 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4206 that where the value of an _OBJC_* symbol points to is in the .bss
4207 section (Bug#10240).
4209 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4211 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4212 after the loop to call ccl_driver at least once (Bug#8619).
4214 2011-12-08 Kenichi Handa <handa@m17n.org>
4216 * ftfont.c (get_adstyle_property): Fix previous change
4219 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4221 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4222 dirs from the default value of EMACSLOADPATH (bug#10208).
4224 2011-12-07 Glenn Morris <rgm@gnu.org>
4226 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4227 installation and source directories as well. (Bug#10208)
4229 2011-12-06 Chong Yidong <cyd@gnu.org>
4231 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4233 2011-12-06 Glenn Morris <rgm@gnu.org>
4235 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4236 as an error, not just -1. (Bug#10217)
4238 2011-12-05 Chong Yidong <cyd@gnu.org>
4240 * keyboard.c (process_special_events): New function.
4241 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4243 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4245 * coding.c (encode_designation_at_bol): Don't use uninitialized
4246 local variable (Bug#9318).
4248 2011-12-05 Kenichi Handa <handa@m17n.org>
4250 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4251 return Qnil (Bug#8046, Bug#10193).
4253 2011-12-05 Kenichi Handa <handa@m17n.org>
4255 * coding.c (encode_designation_at_bol): New args charbuf_end and
4256 dst. Return the number of produced bytes. Callers changed.
4257 (coding_set_source): Return how many bytes coding->source was
4259 (coding_set_destination): Return how many bytes
4260 coding->destination was relocated.
4261 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4262 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4264 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4266 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4267 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4270 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4272 The following changes are to fix Bug#9318.
4274 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4275 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4276 (encode_coding_iso_2022, encode_coding_sjis)
4277 (encode_coding_big5, encode_coding_charset): Use the above macros.
4279 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4281 * lisp.h (process_quit_flag): Fix external declaration.
4283 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4285 Don't macro-inline non-performance-critical code.
4286 * eval.c (process_quit_flag): New function.
4287 * lisp.h (QUIT): Use it.
4289 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4291 * nsfns.m (get_geometry_from_preferences): New function.
4292 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4294 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4296 * emacs.c (Qkill_emacs): Define.
4297 (syms_of_emacs): Initialize it.
4298 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4299 Qquit_flag to `kill-emacs' instead.
4300 (quit_throw_to_read_char): Add parameter `from_signal'.
4301 All callers changed. Call Fkill_emacs if requested and safe.
4302 * lisp.h (QUIT): Call Fkill_emacs if requested.
4304 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4306 * widget.c (update_wm_hints): Return if wmshell is null.
4307 (widget_update_wm_size_hints): New function.
4309 * widget.h (widget_update_wm_size_hints): Declare.
4311 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4312 widget_update_wm_size_hints (Bug#10104).
4314 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4316 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4317 before a newline, prepare the bidi iterator for consuming the
4318 newline, and keep the current paragraph direction. (Bug#10183)
4319 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4321 2011-12-02 Juri Linkov <juri@jurta.org>
4323 * search.c (Fword_search_regexp): New Lisp function created from
4324 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4325 (Fword_search_backward, Fword_search_forward)
4326 (Fword_search_backward_lax, Fword_search_forward_lax):
4327 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4328 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4330 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4332 * fileio.c (Finsert_file_contents): Move after-change-function call
4333 to before the "handled:" label, since all "goto handled" appear in
4334 cases where the *-change-functions have already been properly called
4337 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4339 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4340 waiting for input. (Bug#10169)
4342 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4344 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4345 verifies glyph row's hash code--we have just reallocated the
4346 glyphs, so their contents can be complete garbage. (Bug#10164)
4348 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4350 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4352 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4354 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4355 attributes are tested _before_ calling verify_row_hash, to protect
4356 against GCC re-ordering of the tests. (Bug#10164)
4358 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4360 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4362 * xterm.c (handle_one_xevent): Only set async_visible and friends
4363 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4364 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4365 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4367 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4369 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4370 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4371 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4372 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4373 All uses changed to use GCPRO1 etc.
4374 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4375 Revert to old implementation (i.e., before 2011-03-11).
4377 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4379 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4380 of scroll runs so as to avoid assigning disabled bogus rows and
4381 unnecessary graphics copy operations.
4383 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4385 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4386 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4387 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4388 (malloc, free, realloc, calloc): Redirect to e_* only when
4391 * lisp.h (GCTYPEBITS): Move before first use.
4392 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4393 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4394 this macro definition.
4396 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4399 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4401 * gtkutil.c (xg_create_frame_widgets):
4402 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4403 present with Gtk+ 2.0.
4405 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4407 * fileio.c (Finsert_file_contents): Undo previous change; see
4408 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4410 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4412 Rename locals to avoid shadowing.
4413 * fileio.c (Finsert_file_contents):
4414 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4415 * process.c (wait_reading_process_output):
4416 Rename inner 'proc' to 'p' to avoid shadowing.
4417 Indent for consistency with usual Emacs style.
4419 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4421 * xdisp.c (redisplay_window): If cursor row is not fully visible
4422 after recentering, and scroll-conservatively is set to a large
4423 number, scroll window by a few more lines to make the cursor fully
4424 visible and out of scroll-margin. (Bug#10105)
4425 (start_display): Don't move to the next line if the display should
4426 start at a newline that is part of a display vector or an overlay
4429 2011-11-24 Juri Linkov <juri@jurta.org>
4431 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4432 after the `MagickPingImage' call. (Bug#10112)
4434 2011-11-23 Chong Yidong <cyd@gnu.org>
4436 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4438 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4440 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4441 making another buffer current. (Bug#10114)
4443 2011-11-23 Glenn Morris <rgm@gnu.org>
4445 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4447 2011-11-23 Chong Yidong <cyd@gnu.org>
4449 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4450 using it (Bug#5984).
4452 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4454 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4455 and header-lines, as they don't have one computed for them.
4458 * .gdbinit (prow): Make displayed values more self-explaining.
4459 Add row's hash code.
4461 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4463 * process.c (wait_reading_process_output): Fix asynchrounous
4464 GnuTLS socket handling on some versions of the GnuTLS library.
4465 (wait_reading_process_output): Add comment and URL.
4467 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4469 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4471 2011-11-21 Chong Yidong <cyd@gnu.org>
4473 * window.c (Fnext_window, Fprevious_window): Doc fix.
4475 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4477 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4479 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4481 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4483 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4485 * window.c (Fset_window_combination_limit): Rename argument
4487 (Vwindow_combination_limit): Remove "status" from doc-string.
4489 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4491 * m/ibms390.h: Remove.
4492 * m/ibms390x.h: Don't include "ibms390.h".
4494 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4496 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4497 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4499 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4501 * casetab.c (Fset_case_table):
4502 * charset.c (Fcharset_after): Fix typos.
4504 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4506 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4507 Otherwise, valgrind does not work on some platforms.
4508 Problem reported by Andreas Schwab in
4509 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4510 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4511 is set, removing the need for VIRT_ADDRESS_VARIES.
4512 (PURE_P): Use a more-efficient implementation that needs just one
4513 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4514 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4515 to 4 (xorl, subq, cmpq, setbe).
4516 * alloc.c (pure): Always extern now, since that's the
4517 VIRT_ADDR_VARIES behavior.
4518 (PURE_POINTER_P): Use a single comparison, not two, for
4519 consistency with the new puresize.h.
4520 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4521 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4522 Remove VIRT_ADDR_VARIES no longer needed.
4524 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4526 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4527 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4528 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4529 behave as if the cursor position were at the window margin.
4531 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4532 and the cursor position is out of bounds, behave as if the cursor
4533 position were at the window margin. (Bug#10075)
4535 2011-11-18 Chong Yidong <cyd@gnu.org>
4537 * window.c (Fwindow_combination_limit): Make first argument
4538 non-optional, since it is meaningless for live windows like the
4541 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4543 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4545 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4547 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4548 (graft_intervals_into_buffer): Simplify.
4550 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4552 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4553 hash values of the two rows.
4554 (copy_row_except_pointers): Preserve the used[] arrays and the
4555 hash values of the two rows. (Bug#10035)
4556 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4558 * xdisp.c (row_hash): New function, body extracted from
4559 compute_line_metrics.
4560 (compute_line_metrics): Call row_hash, instead of computing the
4563 * dispnew.c (verify_row_hash): Call row_hash for computing the
4564 hash code of a row, instead of duplicating code from xdisp.c.
4566 * dispextern.h (row_hash): Add prototype.
4568 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4570 * frame.c (delete_frame): Don't delete the terminal when the last
4571 X frame is closed if emacs is built with GTK toolkit.
4573 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4575 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4577 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4579 * window.c (Vwindow_splits): Rename to
4580 Vwindow_combination_resize. Suggested by Juri Linkov.
4581 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4584 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4586 * nsfns.m (Fns_font_name):
4587 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4589 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4591 * window.h (window): Rename slot "nest" to "combination_limit".
4592 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4593 (Fset_window_nest): Rename to Fset_window_combination_limit.
4594 (Vwindow_nest): Rename to Vwindow_combination_limit.
4595 (recombine_windows, make_parent_window, make_window)
4596 (Fsplit_window_internal, saved_window)
4597 (Fset_window_configuration, save_window_save): Rename all
4598 occurrences of window_nest to window_combination_limit.
4600 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4602 * image.c (imagemagick_load_image): Fix typo.
4604 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4606 * xdisp.c (display_line): Move the call to
4607 highlight_trailing_whitespace before the call to
4608 compute_line_metrics, since the latter needs to see the final
4609 faces of all the glyphs to compute ROW's hash value.
4610 Fixes assertion violations in row_equal_p. (Bug#10035)
4612 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4614 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4615 just return (bug#10044).
4617 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4619 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4620 with user-defined heap size. Bump the default size of the temacs
4621 heap to 27MB, to avoid memory warning when running temacs.
4622 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4624 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4625 current_matrix and desired_matrix. (Bug#9990)
4626 (verify_row_hash) [XASSERTS]: New function.
4627 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4628 that the hash value of glyph rows is correct.
4630 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4632 * window.h (window): Remove splits slot.
4633 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4634 (Fdelete_other_windows_internal, make_parent_window)
4635 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4636 (Fset_window_configuration, save_window_save): Don't deal with
4637 split status of windows.
4638 (saved_window): Remove splits slot.
4639 (Vwindow_splits): Rewrite doc-string.
4641 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4643 * xfns.c (unwind_create_frame):
4644 * nsfns.m (unwind_create_frame):
4645 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4646 Vframe_list (Bug#9999).
4648 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4650 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4652 2011-11-11 Kenichi Handa <handa@m17n.org>
4654 * callproc.c (Fcall_process): Set the member dst_multibyte of
4657 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4659 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4660 avoid a crash (bug#9496).
4662 2011-11-09 Chong Yidong <cyd@gnu.org>
4664 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4665 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4667 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4669 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4671 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4673 Avoid some portability problems by eschewing 'extern inline' functions.
4674 The trivial performance wins aren't worth the portability hassles; see
4675 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4677 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4678 (window_box_width, window_box_left, window_box_left_offset)
4679 (window_box_right, window_box_right_offset): Undo previous change,
4680 by removing the "extern"s.
4681 * intervals.c (adjust_intervals_for_insertion)
4682 (adjust_intervals_for_deletion): Undo previous change,
4683 making these static again.
4684 (offset_intervals, temp_set_point_both, temp_set_point)
4685 (copy_intervals_to_string): No longer inline.
4686 * xdisp.c (window_text_bottom_y, window_box_width)
4687 (window_box_height, window_box_left_offset)
4688 (window_box_right_offset, window_box_left, window_box_right)
4689 (window_box): No longer inline.
4691 2011-11-08 Chong Yidong <cyd@gnu.org>
4693 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4694 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4695 Signal an error if not a live window.
4696 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4697 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4699 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4701 * lisp.h (syms_of_abbrev): Remove declaration.
4702 Reported by CHENG Gao <chenggao@royau.me>.
4704 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4706 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4707 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4708 of temacs in GUI mode.
4710 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4712 * window.h: Declare delete_all_child_windows instead of
4713 delete_all_subwindows.
4714 * window.c (Fwindow_nest, Fset_window_nest)
4715 (Fset_window_new_total, Fset_window_new_normal)
4716 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4717 (delete_all_subwindows): Rename to delete_all_child_windows.
4718 (Fdelete_other_windows_internal, Fset_window_configuration):
4719 Call delete_all_child_windows instead of delete_all_subwindows.
4720 * frame.c (delete_frame): Call delete_all_child_windows instead
4721 of delete_all_subwindows.
4723 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4725 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4726 This is also needed for porting to any host where GC_MARK_STACK is
4727 not GC_MAKE_GCPROS_NOOPS.
4728 (which_symbols): Use it.
4730 2011-11-07 Kenichi Handa <handa@m17n.org>
4732 * coding.c (coding_set_destination): Check coding->src_pos only
4733 when coding->src_object is a buffer (bug#9910).
4735 * process.c (send_process): Set the member src_multibyte of coding
4736 to 0 (bug#9911) when sending a unibyte text.
4738 * callproc.c (Fcall_process): Set the member src_multibyte of
4739 process_coding to 0 (bug#9912).
4741 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4743 * xmenu.c (cleanup_widget_value_tree): New function.
4744 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4745 calling free_menubar_widget_value_tree directly (Bug#9830).
4747 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4749 Fix some portability problems with 'inline'.
4750 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4751 (window_box_width, window_box_left, window_box_left_offset)
4752 (window_box_right, window_box_right_offset): Declare extern.
4753 Otherwise, these inline functions do not conform to C99 and
4754 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4755 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4756 * intervals.c (adjust_intervals_for_insertion)
4757 (adjust_intervals_for_deletion): Now extern, because otherwise the
4758 extern inline functions 'offset_intervals' couldn't refer to it.
4759 (static_offset_intervals): Remove.
4760 (offset_intervals): Rewrite using the old contents of
4761 static_offset_intervals. The old version didn't conform to C99
4762 because an extern inline function contained a reference to an
4763 identifier with static linkage.
4765 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4767 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4770 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4772 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4773 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4774 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4775 return Qleft_to_right.
4777 2011-11-06 Chong Yidong <cyd@gnu.org>
4779 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4780 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4781 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4782 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4783 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4784 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4785 (Fwindow_vscroll): Doc fix.
4786 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4787 argument, since it makes no sense to pass a live window and for
4788 consistency with window-child.
4790 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4792 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4795 2011-11-05 Jason Rumney <jasonr@gnu.org>
4797 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4798 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4800 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4801 bitwise arithmetic preventing use of unicode-sip and non-truetype
4804 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4806 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4809 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4810 initialization code to keep similarity to xfns.c after changes
4813 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4815 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4816 (unwind_create_frame): New function (Bug#9943).
4817 (Fx_create_frame): Restructure code to be more similar to the one in
4818 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4819 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4820 Move terminal->reference_count++ just before making the frame official
4823 * nsterm.m (x_free_frame_resources): New function.
4824 (x_destroy_window): Move code to x_free_frame_resources.
4826 * xfns.c (unwind_create_frame): Fix comment.
4827 (Fx_create_frame, x_create_tip_frame):
4828 Move terminal->reference_count++ just before making the frame
4829 official. Move initialization of image_cache_refcount and
4830 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4832 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4834 Support MSVC build with newer versions of Visual Studio.
4835 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4836 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4839 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4840 which are not supported by MSVC.
4841 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4842 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4844 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4846 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4848 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4850 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4852 Support MSVC build with newer versions of Visual Studio.
4853 * w32.c: Don't include w32api.h for MSVC.
4854 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4856 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4857 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4858 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4859 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4861 (alloca) [_MSC_VER]: Define to _alloca.
4863 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4865 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4867 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4869 * xdisp.c (note_mouse_highlight): If either of
4870 previous/next-single-property-change returns nil, treat that as
4871 the beginning or the end of the buffer. (Bug#9955)
4873 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4875 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4876 label is not null (Bug#9951).
4877 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4880 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4882 * window.c (Fwindow_body_size): Mention in the doc string that the
4883 return value is in frame's canonical units. (Bug#9949)
4885 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4887 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4889 * w32fns.c (unwind_create_frame): If needed, free the glyph
4890 matrices of the partially constructed frame. (Bug#9943)
4891 * xfns.c (unwind_create_frame): Likewise.
4893 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4895 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4896 Don't stop backward scan on the continuation glyph, even though
4897 its CHARPOS is positive.
4898 (mouse_face_from_buffer_pos, note_mouse_highlight):
4899 Rename cover_string to disp_string.
4901 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4903 * window.c (temp_output_buffer_show): Don't use
4904 Vtemp_buffer_show_specifiers.
4905 (Vtemp_buffer_show_specifiers): Remove unused variable.
4907 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4909 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4910 past the beginning of the current glyph matrix.
4912 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4914 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4915 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4916 HAVE_GTK3 (Bug#9869).
4918 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4919 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4921 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4923 * xterm.c: Declare x_handle_net_wm_state to return int.
4924 (handle_one_xevent): Check if we are iconified but don't have
4925 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4926 (get_current_wm_state): Return non-zero if not hidden,
4927 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4928 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4929 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4930 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4932 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4934 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4935 so that this new function doesn't get optimized away by a
4936 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4938 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4940 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4942 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4944 Fix the `xbytecode' command.
4945 * .gdbinit (xprintbytestr): New command.
4946 (xwhichsymbols): Rename from `which'; all callers changed.
4947 (xbytecode): Print the byte-code string as well.
4949 2011-10-29 Kim Storm <storm@cua.dk>
4951 * alloc.c (which_symbols): New function.
4953 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4955 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4958 2011-10-29 Glenn Morris <rgm@gnu.org>
4960 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4961 Not clear what it was for, and it causes various bugs. (Bug#9839)
4963 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4965 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4966 possible random value that matches one of those tested as
4967 condition to clear the mouse face.
4969 2011-10-28 Chong Yidong <cyd@gnu.org>
4971 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4973 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4975 * window.c (make_window): Initialize phys_cursor_on_p.
4977 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4979 * lisp.h (struct Lisp_Symbol): Update comments.
4981 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4983 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4985 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4987 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4988 <oslsachem@gmail.com> for helping to debug this.
4990 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4991 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4992 (g_b_init_get_glyph_outline_w): New static variables.
4993 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4994 (GetGlyphOutlineW_Proc): New typedefs.
4995 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4996 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4998 (w32font_open_internal, compute_metrics):
4999 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5000 instead of calling the "wide" APIs directly.
5002 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5004 * w32.h (syms_of_w32font): Add prototype.
5006 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5008 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5009 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5010 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5011 (Fmove_to_window_line): Doc fix.
5013 2011-10-27 Chong Yidong <cyd@gnu.org>
5015 * process.c (make_process): Set gnutls_state to NULL.
5017 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5018 non-NULL, regardless of GNUTLS_INITSTAGE.
5019 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5020 an error. Set process slots as soon as we allocate them.
5022 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5024 2011-10-27 Chong Yidong <cyd@gnu.org>
5026 * gnutls.c (emacs_gnutls_deinit): New function.
5027 Deallocate credentials structures as well as calling gnutls_deinit.
5028 (Fgnutls_deinit, Fgnutls_boot): Use it.
5030 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5031 (deactivate_process): Call emacs_gnutls_deinit.
5033 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5035 * image.c (x_create_x_image_and_pixmap):
5036 * w32.c (sys_rename, w32_delayed_load):
5037 * w32font.c (fill_in_logfont):
5038 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5040 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5042 * w32fns.c (w32_default_color_map): New function,
5043 extracted from Fw32_default_color_map.
5044 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5046 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5048 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5050 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5052 * keyboard.c (test_undefined): New function (bug#9751).
5053 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5055 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5057 * sysdep.c (init_sys_modes): Fix the check for the controlling
5058 terminal (Bug#6649).
5060 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5062 * dispextern.h (struct bidi_it): New member next_en_type.
5064 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5065 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5066 current character, check also for next_en_type being WEAK_EN.
5067 (bidi_resolve_weak): Don't enter the expensive loop if the current
5068 position is before next_en_pos. Record the bidi type of the first
5069 non-ET, non-BN character we find, in addition to its position.
5070 (bidi_level_of_next_char): Invalidate next_en_type when
5071 next_en_pos is over-stepped.
5073 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5075 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5076 * editfns.c: Rewrite current-time-zone so that it invokes
5077 the equivalent of (format-time-string "%Z") to get the time zone name.
5078 This fixes a bug when the time zone name contains characters that
5079 need converting from the system time locale to Emacs internal format.
5080 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5081 that patch fixed format-time-string to do the conversion, but
5082 I forgot to fix current-time-zone.
5083 (format_time_string): New function, containing most of
5084 what Fformat_time_string used to contain.
5085 (Fformat_time_string): Rewrite in terms of format_time_string.
5086 This doesn't change this function's behavior.
5087 (current-time-zone): Rewrite to use format_time_string.
5088 This fixes the bug reported by Michael Schierl in
5089 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5090 Jason Rumney's 2007-06-07 change worked around this bug, but
5092 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5094 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5096 * xdisp.c (start_display): If the character at POS is displayed
5097 via a display vector, reset IT->current.dpvec_index to zero.
5098 (try_window_reusing_current_matrix): If a line ends in a display
5099 vector or the next line starts in a display vector, continue
5100 redrawing the window even though the character position of
5101 start_row was reached.
5104 2011-10-18 Chong Yidong <cyd@gnu.org>
5106 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5107 with nobreak-char-display too.
5109 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5111 Fix part 3 of bug#9771.
5112 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5113 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5114 non-neutral characters if the current character is a paragraph
5115 separator (a.k.a. Newline). This avoids running the same
5116 expensive loop twice, once when we consume the preceding newline
5117 and the other time when the line actually needs to be displayed.
5118 Avoid the loop when we see neutrals on the base embedding level
5119 following a character whose directionality is the same as the
5120 paragraph's. This avoids running the expensive loop when a line
5121 ends in a long sequence of neutrals, like control characters.
5122 Add assertion against STRONG_AL type. Slightly rearrange code
5123 that determines the type of a neutral given the first non-neutral
5125 (bidi_level_of_next_char): Set next_en_pos to zero when
5126 invalidating its info.
5128 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5130 * xdisp.c (push_display_prop): Determine whether to record string
5131 or buffer position by IT->string, not by IT->method. Allow
5132 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5133 (move_it_vertically_backward): Don't look for character position
5134 immediately after the newline when in a continuation line.
5137 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5139 * window.c (coordinates_in_window): Rewrite and delabelize
5140 vertical border check. (Bug#5357) (Bug#9618)
5142 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5144 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5145 errors in XSetWindowBorder (bug#9310).
5147 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5149 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5150 avoid crash when xmalloc overrun checking is enabled.
5152 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5154 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5155 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5156 cursor motion with <left> and <right> arrow keys.
5158 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5159 some callers set that themselves.
5161 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5163 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5164 display string and the previous row comes from the same string and
5165 is empty. (Bug#9739) (Bug#9738)
5167 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5169 * doc.c (get_doc_string): Encode file name (bug#9735).
5171 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5173 * bidi.c (bidi_level_of_next_char):
5174 * xdisp.c (get_visually_first_element): Remove old incorrect
5175 comments regarding the Unicode Line Separator character.
5177 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5179 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5181 * alloc.c (Fgc_status): Do not access beyond zombies array
5182 boundary if nzombies > MAX_ZOMBIES.
5183 * alloc.c (dump_zombies): Add missing format specifier.
5185 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5187 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5188 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5190 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5191 Some packages use them to denote characters with modifiers.
5193 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5195 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5196 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5197 matching a pp-number. Rename parameter var to var1.
5199 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5201 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5203 2011-10-08 Glenn Morris <rgm@gnu.org>
5205 * callint.c (Fcall_interactively): Give a more explicit error for the
5206 'c' case with a non-character input. (Bug#8479)
5208 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5210 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5212 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5213 lines that are hscrolled on the left.
5215 * dispnew.c (buffer_posn_from_coords): Account for a possible
5216 presence of header-line. (Bug#4426)
5218 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5220 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5221 Don't advertise functionality which we discourage or doesn't work.
5223 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5225 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5226 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5227 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5228 this makes Emacs dump core during garbage collection on rare
5229 occasions. sizeof is obviously inferior to offsetof here, so
5230 stick with offsetof.
5231 (GC_POINTER_ALIGNMENT): New macro.
5232 (mark_memory): Omit 3rd (offset) arg; caller changed.
5233 Don't assume EMACS_INT alignment is the same as pointer alignment.
5235 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5237 * keyboard.c (read_key_sequence_remapped): New var.
5238 (read_key_sequence): Compute remapping in the right buffer.
5239 (command_loop_1): Use read_key_sequence's remapping directly.
5241 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5243 * dired.c (file_name_completion): Don't expand file name.
5244 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5245 before checking file name handler.
5247 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5248 they've been requested explicitly (bug#9591).
5250 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5252 * keymap.c (Fsingle_key_description): Use make_specified_string
5253 instead of build_string to build string from push_key_description.
5256 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5258 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5259 This fixes a Y2038 bug on 64-bit hosts.
5260 * buffer.c (reset_buffer):
5261 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5262 (Fclear_buffer_auto_save_failure):
5263 Use 0, not -1, to represent an unset failure time, since time_t
5264 might not be signed.
5266 Remove dependency on glibc malloc internals.
5267 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5268 Move back here from lisp.h, but with their new implementations.
5269 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5270 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5271 * charset.c (charset_table_init): New static var.
5272 (syms_of_charset): Use it instead of xmalloc. This removes a
5273 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5274 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5275 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5276 Move back to alloc.c.
5277 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5278 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5280 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5282 * nsterm.m (windowDidResize): Call x_set_window_size only when
5283 ns_in_resize is true. Otherwise set pixelwidth/height and
5284 call change_frame_size (Bug#9628).
5286 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5288 Port --enable-checking=all to Fedora 14 x86-64.
5289 * charset.c (syms_of_charset): Also account for glibc malloc's
5290 internal overhead when calculating the initial malloc maximum.
5292 Port --enable-checking=all to Fedora 14 x86.
5293 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5295 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5296 (overrun_check_realloc, overrun_check_free):
5297 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5298 That way, xmalloc returns a properly-aligned pointer even if
5299 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5300 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5301 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5302 into account when calculating the initial malloc maximum.
5303 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5304 Move here from alloc.c, so that charset.c can use it too.
5305 Properly align; the old code wasn't right for common 32-bit hosts
5306 when configured with --enable-checking=all.
5307 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5308 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5310 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5312 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5315 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5317 * xdisp.c (compute_display_string_end): If there's no display
5318 string at CHARPOS, return -1.
5320 * bidi.c (bidi_fetch_char): When compute_display_string_end
5321 returns a negative value, treat the character as a normal
5322 character not covered by a display string. (Bug#9624)
5324 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5326 * lread.c (Fread_from_string): Fix typo in docstring.
5328 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5330 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5331 newline, reseat the iterator instead of bidi-iterating there one
5332 character at a time. (Bug#9610)
5333 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5334 TO_CHARPOS if the bidi iterator is at base embedding level.
5336 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5338 * lread.c (readevalloop): Use correct code for NBSP.
5339 (read1): Likewise. (Bug#9608)
5341 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5343 * dbusbind.c (Fdbus_register_signal): When service is not
5344 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5346 2011-09-25 Glenn Morris <rgm@gnu.org>
5348 * buffer.c (truncate-lines): Doc fix.
5350 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5352 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5353 (Fset_window_next_buffers): Doc fix.
5355 2011-09-24 Glenn Morris <rgm@gnu.org>
5357 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5359 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5361 Fix minor problems found by static checking.
5362 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5363 * indent.c (Fvertical_motion): Fix == vs = typo.
5365 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5367 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5368 Default value is now t. Doc fix.
5370 * indent.c (Fvertical_motion): Compute and apply the overshoot
5371 logic when moving up, not only when moving down. Fix the
5372 confusing name and values of the it_overshoot_expected variable;
5373 logic changes accordingly. (Bug#9254) (Bug#9549)
5375 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5376 CHARPOS is covered by a display string which includes newlines.
5377 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5378 is covered by a display string with embedded newlines.
5380 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5382 * dbusbind.c (Fdbus_register_signal): Add match rule to
5383 Vdbus_registered_objects_table. (Bug#9581)
5384 (Fdbus_register_method, Vdbus_registered_objects_table):
5387 2011-09-24 Jim Meyering <meyering@redhat.com>
5389 do not ignore write error for any output size
5390 The previous change was incomplete.
5391 While it makes emacs --batch detect the vast majority of stdout
5392 write failures, errors were still ignored whenever the output size is
5393 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5394 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5395 && echo FAIL: ignored write error
5396 FAIL: ignored write error
5397 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5398 && echo FAIL: ignored write error
5399 FAIL: ignored write error
5400 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5402 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5404 * emacs.c (Fkill_emacs): In noninteractive mode exit
5405 non-successfully if a write error occurred on stdout. (Bug#9574)
5407 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5409 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5412 * dispextern.h (struct it): Update the comment documenting what
5415 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5417 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5418 a display string, extend search for cursor position to end of row.
5419 (find_row_edges): If the row ends in a newline from a display
5420 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5421 Handle the case of a display string with multiple newlines.
5422 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5423 non-empty line. Fixes confusing cursor motion with arrow keys at
5424 the beginning of a line that starts with whitespace.
5426 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5428 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5431 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5433 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5436 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5438 * xdisp.c (display_line): Record maximum and minimum buffer
5439 positions even if no glyphs were produced (e.g., by a zero-width
5440 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5441 buffer positions that will be removed from the glyph row because
5443 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5444 column is beyond frame width: don't subtract 1 "pixel" when
5445 computing width of the stretch.
5446 (reseat_at_next_visible_line_start): Undo the change made on
5447 2011-09-17 that saved paragraph information and restored it after
5448 the call to `reseat'. (Bug#9545)
5450 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5452 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5453 and turn window cursor on if cleared (Bug#9415).
5455 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5457 * search.c (boyer_moore): Take unibyte characters from pattern
5458 literally. (Bug#9458)
5460 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5462 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5464 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5466 Fix minor problem found by static checking.
5467 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5468 initialized, to pacify gcc -Wuninitialized.
5470 * fileio.c: Report proper errno when syscall falls.
5471 (Finsert_file_contents): Save and restore errno,
5472 so that report_file_error outputs the correct diagnostic.
5473 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5475 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5477 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5479 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5481 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5482 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5484 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5486 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5487 about the current paragraph and restore it after the call to reseat.
5489 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5490 (bidi_find_paragraph_start): Search back for paragraph beginning
5491 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5492 (bidi_move_to_visually_next): Only trigger paragraph-related
5493 computations when the last character is a newline or at EOB, not
5494 just any NEUTRAL_B. (Bug#9470)
5496 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5497 truncated lines if point is covered by a display string. (Bug#9524)
5499 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5501 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5502 (cons_to_x_long): New function.
5503 (lisp_data_to_selection_data): Use it. Correct the test for
5504 short-versus-long data; it was negated. Break out of vector
5505 loop, for efficiency, when a long datum is discovered.
5507 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5509 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5511 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5513 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5514 GCC PR/17406) by declaring this function with external scope.
5516 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5518 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5519 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5521 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5523 * editfns.c (Fformat): Correctly handle text properties on "%%".
5525 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5527 * xterm.c (x_draw_composite_glyph_string_foreground):
5528 * w32term.c (x_draw_composite_glyph_string_foreground):
5529 * term.c (encode_terminal_code):
5530 * composite.c (composition_update_it, get_composition_id):
5531 * xdisp.c (get_next_display_element)
5532 (fill_composite_glyph_string): Add comments about special meaning
5533 of TAB characters in a composition.
5535 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5537 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5538 This occurs when processing a multibyte format.
5539 Problem reported by Wolfgang Jenker.
5541 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5543 * xdisp.c (try_cursor_movement): Only check for exact match if
5544 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5546 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5548 Remove unused external symbols.
5549 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5550 * xdisp.c (calc_pixel_width_or_height): Now static.
5551 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5552 * indent.c (check_display_width):
5553 * w32term.c: Fix comment to match code.
5554 * xterm.c, xterm.h (x_catching_errors): Remove.
5556 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5558 * xselect.c: Use signed conversions more consistently (Bug#9498).
5559 (selection_data_to_lisp_data): Assume incoming selection data are
5560 signed integers, not unsigned. This is to be consistent with
5561 outgoing selection data, which was modified to use signed integers
5562 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5563 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5564 expects long, not unsigned long.
5566 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5568 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5569 computation of loop end. Reported by Johan Bockgård
5572 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5574 * frame.c (Fother_visible_frames_p): Function deleted.
5576 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5578 * indent.c (compute_motion): Process display vector front to back
5579 rather than the other way around. (Bug#2496)
5581 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5583 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5585 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5587 * minibuf.c (Fread_from_minibuffer): Doc fix.
5589 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5591 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5592 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5594 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5596 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5597 value for non-existent files.
5599 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5601 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5602 set its "size" to -1. This will set the modtime_size field of
5603 the corresponding buffer to -1, which is what
5604 verify-visited-file-modtime expects for files that do not exist.
5607 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5609 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5611 * lisp.h: ... from here. push_key_description is no longer
5612 defined in keyboard.c, so its declaration should not be in
5613 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5614 logically belongs with push_key_description.
5616 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5618 * buffer.h: Include <sys/types.h> instead of <time.h>.
5619 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5620 Problem reported by Herbert J. Skuhra.
5622 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5624 * xml.c (parse_region): Make the parsing work for
5625 non-comment-starting XML files again (bug#9144).
5627 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5629 * image.c (gif_load): Fix calculation of bottom and right corner.
5632 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5634 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5635 redisplay in small windows.
5637 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5639 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5641 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5643 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5644 Operate on live windows only.
5646 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5648 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5650 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5652 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5653 only under bidi iteration.
5655 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5657 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5659 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5661 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5662 Without this fix, the command to link temacs failed due to an
5663 undefined symbol __builtin_isnan. This is because
5664 /usr/include/iso/math_c99.h #defines isnan(x) to
5665 __builtin_isnan(x), but the bundled gcc, which identifies itself
5666 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5668 * floatfns.c (isnan): #undef, and then #define to a clone of
5670 (Fisnan): Always define, since it's always available now.
5671 (syms_of_floatfns): Always define isnan at the Lisp level.
5673 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5675 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5677 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5679 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5680 The previous code assumed that file offsets (off_t values) fit in
5681 EMACS_INT variables, which is not true on typical 32-bit hosts.
5682 The code messed up by falsely reporting buffer overflow in cases
5683 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5684 when "big" contains more than 2**29 bytes, even though this
5685 inserts just one byte and does not overflow the buffer.
5686 (Finsert_file_contents): Store file offsets as off_t
5687 values, not as EMACS_INT values. Check for overflow when
5688 converting between EMACS_INT and off_t. When checking for
5689 buffer overflow or for overlap, take the offsets into account.
5690 Don't use EMACS_INT for small values where int suffices.
5691 When checking for overlap, fix a typo: ZV was used where
5692 ZV_BYTE was intended.
5693 (Fwrite_region): Don't assume off_t fits into 'long'.
5694 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5696 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5698 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5700 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5702 sprintf-related integer and memory overflow issues (Bug#9412).
5704 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5705 (esprintf, exprintf, evxprintf): New functions.
5706 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5707 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5708 (modify_event_symbol): Do not assume that the length of
5709 name_alist_or_stem is safe to alloca and fits in int.
5710 (Fexecute_extended_command): Likewise for function name and binding.
5711 (Frecursion_depth): Wrap around reliably on integer overflow.
5712 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5713 since some callers pass EMACS_INT values.
5714 (Fsingle_key_description): Don't crash if symbol name contains more
5715 than MAX_ALLOCA bytes.
5716 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5717 (get_minibuffer): Arg is now EMACS_INT, not int.
5718 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5719 (esprintf, exprintf, evxprintf): New decls.
5720 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5722 * dbusbind.c (signature_cat): New function.
5723 (xd_signature, Fdbus_register_signal):
5724 Do not overrun buffer; instead, report string overflow.
5726 * dispnew.c (add_window_display_history): Don't overrun buffer.
5727 Truncate instead; this is OK since it's just a log.
5729 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5730 even if the time zone offset is outlandishly large.
5731 Don't mishandle offset == INT_MIN.
5733 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5734 when creating daemon; the previous buffer-overflow check was incorrect.
5736 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5737 which has the guts of the old verror function.
5739 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5740 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5742 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5743 (font_unparse_xlfd): Don't blindly alloca long strings.
5744 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5745 fits in int, when using sprintf. Use single snprintf to count
5746 length of string rather than counting it via multiple sprintfs;
5747 that's simpler and more reliable.
5748 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5749 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5750 sprintf, in case result does not fit in int.
5752 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5753 (fontset_from_font): Print it.
5755 * frame.c (tty_frame_count): Now printmax_t, not int.
5756 (make_terminal_frame, set_term_frame_name): Print it.
5757 (x_report_frame_params): In X, window IDs are unsigned long,
5758 not signed long, so print them as unsigned.
5759 (validate_x_resource_name): Check for implausibly long names,
5760 and don't assume name length fits in 'int'.
5761 (x_get_resource_string): Don't blindly alloca invocation name;
5762 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5765 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5766 (xg_check_special_colors, xg_set_geometry):
5767 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5769 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5770 Use esprintf, not sprintf, in case result does not fit in int.
5772 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5773 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5774 it as a large positive number.
5775 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5776 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5778 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5779 in case result does not fit in int.
5781 * print.c (float_to_string): Detect width overflow more reliably.
5782 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5783 buffer overrun. Don't assume list length fits in 'int'. Treat
5784 print length of 0 as 0, not as infinity; to be consistent with other
5785 uses of print length in this function. Don't overflow print length
5786 index. Don't assume hash table size fits in 'long', or that
5787 vectorlike size fits in 'unsigned long'.
5789 * process.c (make_process): Use printmax_t, not int, to format
5790 process-name gensyms.
5792 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5794 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5795 to avoid potential buffer overrun.
5797 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5798 if X resource line is longer than 512 bytes.
5800 * xfns.c (x_window): Make sprintf buffer a bit bigger
5801 to avoid potential buffer overrun.
5803 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5805 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5807 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5809 Integer overflow fixes for scrolling, etc.
5810 Without these, Emacs silently mishandles large integers sometimes.
5811 For example, "C-u 4294967297 M-x recenter" was treated as if
5812 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5814 * xdisp.c (try_window_id): Check Emacs fixnum range before
5815 converting to 'int'.
5817 * window.c (window_scroll_line_based, Frecenter):
5818 Check that an Emacs fixnum is in range before assigning it to 'int'.
5819 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5820 values converted from Emacs fixnums.
5821 (Frecenter): Don't wrap around a line count if it is out of 'int'
5822 range; instead, treat it as an extreme value.
5823 (Fset_window_configuration, compare_window_configurations):
5824 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5826 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5827 that can exceed INT_MAX. Check that EMACS_INT value is in range
5828 before assigning it to the (possibly-narrower) index.
5829 (match_limit): Don't assume that a fixnum can fit in 'int'.
5831 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5834 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5835 (Fvertical_motion): Don't wrap around LINES values that don't fit
5836 in 'int'. Instead, treat them as extreme values. This is good
5837 enough for windows, which can't have more than INT_MAX lines anyway.
5839 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5841 * Require libxml/parser.h to avoid compilation warning.
5843 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5845 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5846 since this reportedly can destroy thread storage.
5848 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5850 * syntax.c (find_defun_start): Update all cache variables if
5851 exiting early (Bug#9401).
5853 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5855 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5857 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5858 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5859 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5861 * term.c (tty_append_glyph): New function.
5862 (produce_stretch_glyph): Static function and its prototype deleted.
5864 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5867 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5869 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5870 when checking :margin (Bug#9390).
5871 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5872 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5873 so that the name doesn't mislead. All uses changed.
5875 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5877 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5880 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5882 * xdisp.c (move_it_to): Don't bail out early when reaching
5883 position beyond to_charpos, if we are scanning backwards.
5884 (move_it_vertically_backward): When DY == 0, make sure we get to
5885 the first character in the line after the newline.
5887 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5889 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5890 (ccl_driver): Do not generate an out-of-range pointer.
5891 (Fccl_execute_on_string): Remove unnecessary check for
5892 integer overflow, noted by Stefan Monnier in
5893 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5894 Remove a FIXME that didn't need fixing.
5895 Simplify the newly-introduced buffer reallocation code.
5897 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5899 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5901 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5903 Integer and memory overflow issues (Bug#9196).
5905 * doc.c (get_doc_string): Rework so that
5906 get_doc_string_buffer_size is the actual buffer size, rather than
5907 being 1 less than the actual buffer size; this makes xpalloc more
5910 * image.c (x_allocate_bitmap_record, cache_image):
5911 * xselect.c (Fx_register_dnd_atom):
5912 Simplify previous changes by using xpalloc.
5914 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5915 since either will do and ptrdiff_t is convenient with xpalloc.
5917 * charset.c (charset_table_size)
5918 (struct charset_sort_data.priority): Now ptrdiff_t.
5919 (charset_compare): Don't overflow if priorities differ greatly.
5920 (Fsort_charsets): Don't assume list length fits in int.
5921 Check for size-calculation overflow when allocating sort data.
5922 (syms_of_charset): Allocate an initial charset table that is
5923 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5925 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5927 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5928 The actual value is always <= INT_MAX, and leaving it unsigned made
5929 overflow checking harder.
5931 * dispextern.h (struct glyph_matrix.rows_allocated)
5932 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5933 with xpalloc. The values are still always <= INT_MAX.
5935 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5937 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5938 (SAFE_NALLOCA): New macro.
5940 * region-cache.c (struct boundary.pos, find_cache_boundary)
5941 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5942 (set_cache_region, invalidate_region_cache)
5943 (revalidate_region_cache, know_region_cache, region_cache_forward)
5944 (region_cache_backward, pp_cache):
5945 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5946 so that ptrdiff_t * can be passed to xpalloc.
5947 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5948 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5949 (pp_cache): Don't assume cache_len fits in int.
5950 * region-cache.h: Adjust extern decls to match.
5952 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5953 EMACS_INT, since either will do, for xpalloc.
5955 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5956 (xnmalloc, xnrealloc, xpalloc): New functions.
5958 * bidi.c (bidi_shelve_header_size): New constant.
5959 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5960 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5962 * bidi.c (bidi_cache_shrink):
5963 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5965 Don't update size of array until after memory allocation succeeds,
5966 because xmalloc/xrealloc may not return.
5967 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5968 now that we have proper integer overflow checking.
5969 (record_overlay_string, overlay_strings): Catch overflows when
5970 calculating size of overlay_str_buf.
5972 * callproc.c (Fcall_process): Check for size overflow when
5973 calculating size of args2.
5974 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5975 Normally we prefer signed values, but sticking with ptrdiff_t would
5976 require adding more-complicated checks.
5978 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5979 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5980 Redo buffer-overflow calculations to avoid integer overflow.
5981 Add a FIXME comment where memory seems to be over-allocated.
5983 * character.c (Fstring): Check for size-calculation overflow.
5985 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5986 unnecessary integer overflow. Check for size overflow.
5987 (encode_coding_object): Don't update size until xmalloc succeeds.
5989 * composite.c (get_composition_id): Check for overflow in glyph
5990 length calculations.
5992 Integer and memory overflow fixes for display code.
5993 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5994 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5995 (scrolling_window): Check for overflow in size calculations.
5996 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5997 Don't assume glyph table len fits in int.
5998 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5999 (row_table_size): Now ptrdiff_t, not int.
6000 (scrolling_window): Avoid overflow in size calculations.
6001 Don't update size until allocation succeeds.
6002 * fns.c (concat): Check for overflow in size calculations.
6003 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6004 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6005 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6007 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6008 (get_doc_string): Check for size calculation overflow.
6009 Don't update size until allocation succeeds.
6010 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6011 EMACS_INT, where ptrdiff_t will do.
6012 (Fsubstitute_command_keys): Check for string overflow.
6014 * editfns.c (set_time_zone_rule): Don't assume environment length
6016 (message_length): Now ptrdiff_t, not int.
6017 (Fmessage_box): Don't update size until allocation succeeds.
6018 Don't assume message length fits in int.
6019 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6021 * emacs.c (main): Do not reallocate argv, since there is a null at
6022 the end that can be overwritten, and this way there's no need to
6023 worry about size-calculation overflow.
6024 (sort_args): Check for size-calculation overflow.
6026 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6028 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6030 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6031 (x_set_scroll_bar_width, x_figure_window_size):
6032 Check for integer overflow.
6033 (x_set_alpha): Do not assume XINT fits in int.
6035 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6036 This is for the members text_lines, text_cols, total_lines, total_cols,
6037 where the system imposes an 'int' limit.
6039 * fringe.c (Fdefine_fringe_bitmap):
6040 Don't update size until alloc works.
6042 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6043 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6045 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6046 Check for size-calculation overflow.
6047 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6048 do, as we prefer signed integers.
6049 (id_to_widget.max_size, id_to_widget.used)
6050 (xg_store_widget_in_map, xg_remove_widget_from_map)
6051 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6052 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6053 Use and return ptrdiff_t, not int.
6054 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6055 * gtkutil.h: Change prototypes to match the above.
6057 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6058 are duplicate now that they've been promoted to lisp.h.
6059 (x_allocate_bitmap_record, x_alloc_image_color)
6060 (make_image_cache, cache_image, xpm_load):
6061 Don't update size until alloc is done.
6062 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6064 Check for size calculation overflow.
6065 (ct_colors_allocated_max): New constant.
6066 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6069 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6070 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6071 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6072 Use ptrdiff_t, not int, to count maps.
6073 (read_char_minibuf_menu_prompt): Check for overflow in size
6074 calculations. Don't update size until allocation succeeds.
6075 Redo calculations to avoid overflow.
6076 * keyboard.h: Change prototypes to match the above.
6078 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6080 (current_minor_maps): Check for size calculation overflow.
6081 * keymap.h: Change prototypes to match the above.
6083 * lread.c (read1, init_obarray): Don't update size until alloc done.
6085 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6086 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6088 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6089 Now ptrdiff_t, not int.
6090 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6091 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6093 * process.c (Fnetwork_interface_list): Check for overflow
6094 in size calculation.
6096 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6098 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6099 overflow. Don't bother calling xmalloc when xrealloc will do.
6101 * search.c (Freplace_match): Check for size calculation overflow.
6102 (Fset_match_data): Don't assume list lengths fit in 'int'.
6104 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6105 for command line length. Do not attempt to address one before the
6106 beginning of an array, as that's not portable.
6108 * term.c (max_frame_lines): Remove; unused.
6109 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6111 (encode_terminal_code, calculate_costs): Check for size
6112 calculation overflow.
6113 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6114 table lengths and related sizes. Don't update size until alloc
6115 done. Redo calculations to avoid overflow.
6116 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6118 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6119 subtracting pointers.
6120 (gobble_line): Check for overflow more carefully. Don't update size
6123 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6124 Don't update size until alloc done.
6125 Redo size calculations to avoid overflow.
6126 Check for size calculation overflow.
6127 (main) [DEBUG]: Fix typo in invoking tparam1.
6129 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6130 Use ptrdiff_t, not int, for sizes.
6131 (store_mode_line_noprop_char): Don't update size until alloc done.
6133 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6134 Use ptrdiff_t, not int, for sizes.
6135 (Finternal_make_lisp_face, cache_face):
6136 Check for size calculation overflow.
6137 (cache_face): Treat size calculation overflows as if they were
6138 memory exhaustion (the usual treatment), rather than aborting.
6140 * xfns.c (x_encode_text, x_set_name_internal)
6141 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6142 sizes, since they can exceed INT_MAX in size. Check for size
6143 calculation overflow.
6145 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6146 (xg_select): Check for size calculation overflow.
6147 Don't update size until alloc done.
6149 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6150 as sprintf is limited to int lengths.
6152 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6153 (X_LONG_MIN): New macros.
6154 Use them to make the following changes clearer.
6155 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6156 This change doesn't affect the value now, but it may help remind
6157 future maintainers not to raise the value too much later.
6158 (SELECTION_QUANTUM): Remove, replacing with ...
6159 (selection_quantum): ... new function, which avoids overflow.
6161 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6162 assumption that selection length fits in 'int'.
6163 (x_reply_selection_request, x_handle_selection_request)
6164 (x_get_window_property, receive_incremental_selection)
6165 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6166 (lisp_data_to_selection_data, clean_local_selection_data):
6167 Use ptrdiff_t, not int, to record length of selection.
6168 (x_reply_selection_request, x_get_window_property)
6169 (receive_incremental_selection, x_property_data_to_lisp):
6170 Redo calculations to avoid overflow.
6171 (x_reply_selection_request): When sending hint, ceiling it at
6172 X_LONG_MAX rather than relying on wraparound overflow to send
6174 (x_get_window_property, receive_incremental_selection)
6175 (lisp_data_to_selection_data, x_property_data_to_lisp):
6176 Check for size-calculation overflow.
6177 (x_get_window_property, receive_incremental_selection)
6178 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6179 Don't store size until memory allocation succeeds.
6180 (x_get_window_property): Plug memory leak on memory exhaustion.
6181 Don't double-block input; malloc is safe here. Don't assume 2**34
6182 - 4 fits in unsigned long. Add an xassert to check
6183 XGetWindowProperty overflow. Be more careful about overflow
6184 calculations, and distinguish size from memory overflow better.
6185 (receive_incremental_selection): When tracing, don't assume
6186 unsigned int is less than INT_MAX.
6187 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6188 harmful) conversions of unsigned short to int.
6189 (lisp_data_to_selection_data): Don't assume that integers
6190 in the range -65535 through -1 fit in an X unsigned short.
6191 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6192 result parameters unless successful. Rely on cons_to_unsigned
6193 to report problems with elements; the old code wasn't right anyway.
6194 (x_check_property_data): Check for int overflow; we cannot use
6195 a wider type due to X limits.
6196 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6198 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6200 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6201 (x_term_init): Check for size calculation overflow.
6202 (x_color_cells): Don't store size until memory allocation succeeds.
6203 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6204 Don't assume alloca size is less than MAX_ALLOCA.
6205 (x_term_init): Don't assume length fits in int (sprintf is limited
6208 Use ptrdiff_t for composition IDs.
6209 * character.c (lisp_string_width):
6210 * composite.c (composition_table_size, n_compositions)
6211 (get_composition_id, composition_gstring_from_id):
6212 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6213 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6214 * window.c (Frecenter):
6215 Use ptrdiff_t, not int, for composition IDs.
6216 * composite.c (get_composition_id): Check for integer overflow.
6217 * composite.h: Adjust prototypes to match the above changes.
6219 Use ptrdiff_t for hash table indexes.
6220 * category.c (hash_get_category_set):
6221 * ccl.c (ccl_driver):
6222 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6223 * coding.c (coding_system_charset_list, detect_coding_system):
6224 * coding.h (struct coding_system.id):
6225 * composite.c (get_composition_id, gstring_lookup_cache):
6226 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6227 * image.c (xpm_get_color_table_h):
6228 * lisp.h (hash_lookup, hash_put):
6229 * minibuf.c (Ftest_completion):
6230 Use ptrdiff_t for hash table indexes, not int (which is too
6231 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6232 32-bit --with-wide-int hosts).
6234 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6235 Add a FIXME comment about memory leaks.
6236 (syms_of_charset): Don't assume xmalloc returns.
6238 Don't assume that stated character widths fit in int.
6239 * character.c (Fchar_width, c_string_width, lisp_string_width):
6240 * character.h (CHAR_WIDTH):
6241 * indent.c (MULTIBYTE_BYTES_WIDTH):
6242 Use sanitize_char_width to avoid undefined and/or bad behavior
6243 with outlandish widths.
6244 * character.h (sanitize_tab_width): Rename from sanitize_width,
6245 now that we have two such functions. All uses changed.
6246 (sanitize_char_width): New inline function.
6248 Don't assume that tab-width fits in int.
6249 * character.h (sanitize_width): New inline function.
6250 (SANE_TAB_WIDTH): New macro.
6251 (ASCII_CHAR_WIDTH): Use it.
6252 * indent.c (sane_tab_width): Remove. All uses replaced by
6253 SANE_TAB_WIDTH (current_buffer).
6254 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6256 * fileio.c: Integer overflow issues with file modes.
6257 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6259 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6260 Remove unreachable code.
6261 (read_hex, load_charset_map_from_file): Check for integer overflow.
6263 * xterm.c: Don't go over XClientMessageEvent limit.
6264 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6265 (x_send_scroll_bar_event): Likewise. Check that the size does not
6266 exceed limits imposed by XClientMessageEvent, as well as the usual
6267 ptrdiff_t and size_t limits.
6269 * keyboard.c: Overflow, signedness and related fixes.
6270 (make_lispy_movement): Use same integer type in forward decl
6271 that is used in the definition.
6272 (read_key_sequence, keyremap_step):
6273 Change bufsize argument back to int, undoing my 2011-03-30 change.
6274 We prefer signed types, and int is wide enough here.
6275 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6276 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6277 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6278 length, not size_t. Use ptrdiff_t for index, not int.
6279 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6280 possibility of integer overflow.
6282 Overflow, signedness and related fixes for images.
6284 * dispextern.h (struct it.stack[0].u.image.image_id)
6285 (struct_it.image_id, struct image.id, struct image_cache.size)
6286 (struct image_cache.used, struct image_cache.ref_count):
6287 * gtkutil.c (update_frame_tool_bar):
6288 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6289 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6290 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6291 * nsmenu.m (update_frame_tool_bar):
6292 * xdisp.c (calc_pixel_width_or_height):
6293 * xfns.c (image_cache_refcount):
6294 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6295 on typical 64-bit hosts.
6297 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6298 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6299 Omit unnecessary casts to int.
6300 (parse_image_spec): Check that integers fall into 'int' range
6301 when the callers expect that.
6302 (image_ascent): Redo ascent calculation to avoid int overflow.
6303 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6304 (lookup_image): Remove unnecessary tests.
6305 (xbm_image_p): Locals are now of int, not EMACS_INT,
6306 since parse_image_check makes sure they fit into int.
6307 (png_load, gif_load, svg_load_image):
6308 Prefer int to unsigned where either will do.
6309 (tiff_handler): New function, combining the cores of the
6310 old tiff_error_handler and tiff_warning_handler.
6311 This function is rewritten to use vsnprintf and thereby avoid
6312 stack buffer overflows. It uses only the features of vsnprintf
6313 that are common to both POSIX and native Microsoft.
6314 (tiff_error_handler, tiff_warning_handler): Use it.
6315 (tiff_load, gif_load, imagemagick_load_image):
6316 Don't assume :index value fits in 'int'.
6317 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6318 (imagemagick_load_image): Check that crop parameters fit into
6319 the integer types that MagickCropImage accepts. Don't assume
6320 Vimagemagick_render_type has a nonnegative value. Don't assume
6321 size_t fits in 'long'.
6322 (gs_load): Use printmax_t to print the widest integers possible.
6323 Check for integer overflow when computing image height and width.
6325 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6327 * xdisp.c (redisplay_window): Don't force window start if point
6328 will be invisible in the resulting window. (Bug#9324)
6330 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6332 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6333 the display spec is of the form `(space ...)'.
6334 (handle_display_spec): Return the value returned by
6335 handle_single_display_spec, not just 1 or zero.
6336 (handle_single_display_spec): If the display spec is of the form
6337 `(space ...)', and specifies display in the text area, return 2
6339 (try_cursor_movement): Check for the need to scroll more
6340 accurately, and prefer exact match for point under bidi.
6341 Don't advance `row' beyond the last row of the window.
6343 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6344 into disp_prop; all users changed.
6346 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6347 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6348 for the text covered by the display property.
6350 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6352 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6353 Change return value to nil.
6354 (Frecord_buffer): Delete unused function.
6356 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6358 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6359 buffers, return left-to-right.
6360 (set_cursor_from_row): Consider candidate row a win if its glyph
6361 represents a newline and point is on that newline. Fixes cursor
6362 positioning on the newline at EOL of R2L text within L2R
6363 paragraph, and vice versa.
6364 (try_cursor_movement): Check continued rows, in addition to
6365 continuation rows. Fixes unwarranted scroll when point enters a
6366 continued line of R2L text within an L2R paragraph, or vice versa.
6367 (cursor_row_p): Consider the case of point being equal to
6368 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6369 from the end of a short line to the beginning of a continued line
6370 of R2L text within L2R paragraph.
6371 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6372 composed characters.
6374 * bidi.c (bidi_check_type): Use xassert.
6375 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6378 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6380 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6383 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6385 * nsfont.m (ns_otf_to_script): Fix typo.
6387 2011-08-22 Kenichi Handa <handa@m17n.org>
6389 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6390 extra slot even if the purpose is char-code-property-table.
6392 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6394 * xdisp.c (redisplay_window): When computing centering_position,
6395 account for the height of the header line. (Bug#8874)
6397 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6398 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6399 candidate is selected by the mouse, and that candidate has a
6400 composed character under the mouse.
6402 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6403 coordinates reported by pos-visible-in-window-p for a composed
6404 character in column zero.
6406 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6408 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6410 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6412 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6413 consider it a hit if to_charpos is anywhere in the range of the
6414 composed buffer positions.
6416 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6418 * image.c (gif_load): Don't assume that each subimage has the same
6419 dimensions as the base image. Handle disposal method that is
6420 "undefined" by the gif spec (Bug#9335).
6422 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6424 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6425 (Fcondition_case): Document `debug' symbol in error handler.
6427 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6429 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6430 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6431 from an Org mode buffer to a Speedbar frame.
6433 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6434 a composition, take its buffer position from IT->cmp_it.charpos.
6435 Fixes cursor positioning at the beginning of a line that begins
6436 with a composed character.
6438 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6440 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6441 character bidirectional type, use STRONG_L instead. Fixes crashes
6442 in a buffer produced by `describe-categories'.
6444 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6445 members before the level stack, so they would be saved and
6446 restored when copying iterator state. Fixes incorrect reordering
6447 around TABs covered by display properties.
6449 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6451 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6453 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6455 * eval.c (internal_condition_case, internal_condition_case_1)
6456 (internal_condition_case_2, internal_condition_case_n):
6457 Remove unnecessary aborts (Bug#9081).
6459 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6461 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6462 has no `load' handler, try opening the file locally. (Bug#9311)
6464 2011-08-16 Ken Brown <kbrown@cornell.edu>
6466 * gmalloc.c: Expand comment.
6468 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6470 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6471 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6473 2011-08-16 Ken Brown <kbrown@cornell.edu>
6475 Fix memory allocation problems in Cygwin build (Bug#9273).
6477 * unexcw.c ( __malloc_initialized): Declare external variable.
6478 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6480 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6482 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6484 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6486 [CYGWIN] (special_realloc): New function.
6487 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6488 requests to realloc storage in the static heap.
6490 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6492 * bidi.c (bidi_initialize): Remove unused local.
6494 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6497 * biditype.h: Remove file.
6498 * makefile.w32-in ($(BLD)/bidi.$(O)):
6499 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6501 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6503 * chartab.c: Improve commentary for the uniprop_table API.
6505 * bidi.c (bidi_paragraph_init): Support zero value of
6506 bidi_ignore_explicit_marks_for_paragraph_level.
6507 (bidi_initialize): Use uniprop_table instead of including
6508 biditype.h and bidimirror.h.
6510 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6511 coordinates of the iterator when restoring from ppos_it.
6514 2011-08-14 Kenichi Handa <handa@m17n.org>
6516 * process.c (create_process): Call setup_process_coding_systems
6517 after the pid of the process is set to -1 (Bug#8162).
6519 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6521 * xdisp.c (move_it_in_display_line_to): Don't invoke
6522 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6523 ppos_it. Fixes vertical cursor motion when line beginning is
6524 covered by an image. (Bug#9296)
6526 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6528 * nsterm.h (ns_run_ascript): Declare.
6529 (NSAPP_DATA2_RUNASSCRIPT): Define.
6531 * nsfns.m (as_script, as_result, as_status): New static variables.
6532 (ns_run_ascript): New function.
6533 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6534 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6535 the event loop. Get status from as_status (Bug#7276).
6537 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6538 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6539 the event loop (Bug#7276).
6541 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6543 * gnutls.c (QCgnutls_bootprop_priority)
6544 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6545 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6546 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6547 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6548 (QCgnutls_bootprop_verify_hostname_error)
6549 (QCgnutls_bootprop_callbacks_verify): Rename from
6550 Qgnutls_bootprop_..., all uses changed.
6552 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6555 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6557 * xfaces.c (Qframe_set_background_mode): Now static.
6558 * dispextern.h (Qframe_set_background_mode): Remove decl.
6560 * process.c (Fnetwork_interface_info): Declare local only if needed.
6562 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6564 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6565 (Fnetwork_interface_list): Allocate in increments of bytes instead
6566 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6567 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6569 (struct ifflag_def): notrailers is smart on OSX.
6570 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6571 Get hardware address with getifaddrs if available.
6573 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6575 * xdisp.c (iterate_out_of_display_property): xassert that
6576 IT->position is set to within IT->object's boundaries. Break from
6577 the loop as soon as EOB is reached; avoids infloops in redisplay
6578 when IT->position is set up wrongly due to some bug.
6579 Set IT->current to match the bidi iterator unconditionally.
6580 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6581 entry. Force push_it to save on the stack the current
6582 buffer/string position, to be restored by pop_it. Fix flags in
6583 the iterator structure wrt the object coming from a display
6584 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6585 properties. (Bug#9284)
6587 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6589 * fontset.c (fontset_get_font_group): Add proper type checks.
6592 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6594 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6595 and LC_VERSION_MIN_MACOSX.
6596 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6597 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6599 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6601 * xdisp.c (forward_to_next_line_start): Allow to use the
6602 no-display-properties-and-no-overlays under bidi display.
6603 Set disp_pos in the bidi iterator to avoid searches for display
6604 properties and overlays.
6606 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6608 * editfns.c (Fset_time_zone_rule): Document relationship with the
6611 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6612 the font entity extracted from the cache (Bug#8109).
6614 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6616 * composite.c (autocmp_chars): Don't reset point. That is done by
6617 restore_point_unwind (Bug#5984).
6619 2011-08-07 Juri Linkov <juri@jurta.org>
6621 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6622 to show the arg `TIME' instead of `TIMEVAL'.
6624 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6626 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6627 display property strides EOL and includes a newline, as in
6628 longlines-mode. (Bug#9254)
6629 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6630 word-wrap under bidirectional display. (Bug#9224)
6632 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6633 is non-zero, even if the data buffer is NULL. Fixes a crash in
6634 vertical-motion with longlines-mode. (Bug#9254)
6636 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6638 * bidi.c <bidi_cache_total_alloc>: Now static.
6639 (bidi_initialize): Initialize bidi_cache_total_alloc.
6641 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6644 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6645 amount allocated this far in `bidi_cache_total_alloc'.
6646 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6647 non-zero, only free the data buffer without restoring the cache
6648 contents. All callers changed.
6650 * dispextern.h (bidi_unshelve_cache): Update prototype.
6652 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6653 (move_it_in_display_line, move_it_to)
6654 (move_it_vertically_backward, move_it_by_lines): Replace the call
6655 to xfree to an equivalent call to bidi_unshelve_cache.
6656 (move_it_in_display_line_to): Fix logic of returning
6657 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6659 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6661 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6662 came from a string character with a `cursor' property. (Bug#9229)
6664 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6666 * Makefile.in (LIB_PTHREAD): New variable.
6667 (LIBES): Add LIB_PTHREAD (Bug#9216).
6669 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6670 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6672 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6674 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6676 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6678 * xterm.c (x_find_topmost_parent): New function.
6679 (x_set_frame_alpha): Find topmost parent window with
6680 x_find_topmost_parent and set the property there also (bug#9181).
6681 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6683 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6685 * callproc.c (Fcall_process): Avoid vfork clobbering
6686 the local vars buffer, coding_systems, current_dir.
6688 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6690 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6692 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6694 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6695 so that it is not optimized away.
6697 * xdisp.c (compute_display_string_pos): Remove unused local.
6699 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6701 Fix slow cursor motion and scrolling in large buffers with
6702 selective display, like Org Mode buffers. (Bug#9218)
6704 * dispextern.h (struct bidi_it): New member disp_prop_p.
6706 * xdisp.c: Remove one-slot cache of display string positions.
6707 (compute_display_string_pos): Accept an additional argument
6708 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6709 for a display string or property. If found, set DISP_PROP_P
6712 * bidi.c (bidi_fetch_char): Accept an additional argument
6713 DISP_PROP_P, and pass it to compute_display_string_pos.
6714 Only handle text covered by a display string if DISP_PROP_P is returned
6715 non-zero. All callers of bidi_fetch_char changed.
6717 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6719 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6721 2010-12-03 Don March <don@ohspite.net>
6723 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6724 last character M-[char] is translated to ESC [char] (bug#7541).
6726 2011-08-02 Kenichi Handa <handa@m17n.org>
6728 * lisp.h (uniprop_table): Extern it.
6730 * chartab.c (uniprop_table): Make it non-static.
6732 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6734 * xdisp.c (forward_to_next_line_start): Accept additional argument
6735 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6737 (reseat_at_next_visible_line_start): Use the bidi iterator state
6738 returned by forward_to_next_line_start to restore the state of
6739 it->bidi_it after backing up to previous newline. (Bug#9212)
6741 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6743 * regex.c (re_comp): Protoize.
6744 (re_exec): Fix return type.
6745 (regexec): Fix type of `ret'. (Bug#9203)
6747 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6749 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6750 This is needed if max-image-size is a floating-point number.
6752 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6754 * print.c (print_object): Print empty symbol as ##.
6756 * lread.c (read1): Read ## as empty symbol.
6758 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6760 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6761 setting frame foreground color (Bug#9175).
6762 (x_set_background_color): Likewise.
6764 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6765 contents (Bug#9176).
6766 (EmacsTooltip -init): Remove bezels and add shadows to
6769 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6770 or scroll bar (Bug#8470).
6772 * nsfont.m (nsfont_open): Remove assignment to voffset and
6773 unnecessary vars hshink, expand, hd, full_height, min_height.
6774 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6776 * nsterm.h (nsfont_info): Remove voffset field.
6778 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6780 Implement strike-through and overline on NextStep (Bug#8863).
6782 * nsfont.m (nsfont_open): Use underline position provided by font,
6783 instead of hard-coded value of 2.
6784 (nsfont_draw): Call ns_draw_text_decoration instead.
6786 * nsterm.h: Add declaration for ns_draw_text_decoration.
6788 * nsterm.m (ns_draw_text_decoration): New function for drawing
6789 underline, overline, and strike-through.
6790 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6791 ns_draw_text_decoration. Change treatment of cursor drawing to
6792 accommodate underlining, etc.
6794 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6796 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6799 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6801 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6802 Without this fix, if a signal arrives just after memory fills up,
6803 'malloc' might be invoked reentrantly.
6805 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6806 In other words, assume that every image size is allowed, on non-X
6807 hosts. This assumption is probably wrong, but it lets Emacs compile.
6809 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6811 * regex.c (re_iswctype): Convert return values to boolean.
6813 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6815 * xdisp.c (compute_display_string_pos): Don't use cached display
6816 string position if the buffer had its restriction changed.
6819 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6821 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6823 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6825 Integer signedness and overflow and related fixes. (Bug#9079)
6827 * bidi.c: Integer size and overflow fixes.
6828 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6829 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6830 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6831 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6832 (bidi_find_other_level_edge):
6833 Use ptrdiff_t instead of EMACS_INT where either will do.
6834 This works better on 32-bit hosts configured --with-wide-int.
6835 (bidi_cache_ensure_space): Check for size-calculation overflow.
6836 Use % rather than repeated addition, for better worst-case speed.
6837 Don't set bidi_cache_size until after xrealloc returns, because it
6839 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6840 (bidi_cache_ensure_space): Also check that the bidi cache size
6841 does not exceed that of the largest Lisp string or buffer. See Eli
6842 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6844 * alloc.c (__malloc_size_t): Remove.
6845 All uses replaced by size_t. See Andreas Schwab's note
6846 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6848 * image.c: Improve checking for integer overflow.
6849 (check_image_size): Assume that f is nonnull, since
6850 it is always nonnull in practice. This is one less thing to
6851 worry about when checking for integer overflow later.
6852 (x_check_image_size): New function, which checks for integer
6853 overflow issues inside X.
6854 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6855 This removes the need for a memory_full check.
6856 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6857 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6858 (xbm_read_bitmap_data): Change locals back to 'int', since
6859 their values must fit in 'int'.
6860 (xpm_load_image, png_load, tiff_load):
6861 Invoke x_create_x_image_and_pixmap earlier,
6862 to avoid much needless work if the image is too large.
6863 (tiff_load): Treat overly large images as if
6864 x_create_x_image_and_pixmap failed, not as malloc failures.
6865 (gs_load): Use x_check_image_size.
6867 * gtkutil.c: Omit integer casts.
6868 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6869 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6871 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6873 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6874 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6875 would wrongly return t on a 64-bit host.
6877 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6878 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6879 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6880 and therefore cause GCC to emit a bogus diagnostic in some cases.
6882 * image.c: Integer signedness and overflow and related fixes.
6883 This is not an exhaustive set of fixes, but it's time to
6884 record what I've got.
6885 (lookup_pixel_color, check_image_size): Remove redundant decls.
6886 (check_image_size): Don't assume that arbitrary EMACS_INT values
6887 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6888 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6889 (tiff_load, imagemagick_load_image):
6890 Check for overflow in size calculations.
6891 (x_create_x_image_and_pixmap): Remove unnecessary test for
6892 xmalloc returning NULL; that can't happen.
6893 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6894 (xpm_color_bucket): Use better integer hashing function.
6895 (xpm_cache_color): Don't possibly over-allocate memory.
6896 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6897 (gif_memory_source):
6898 Use ptrdiff_t, not int or size_t, to record sizes.
6899 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6900 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6901 either works, as we prefer signed integers.
6902 (tiff_read_from_memory, tiff_write_from_memory):
6903 Return tsize_t, not size_t, since that's what the TIFF API wants.
6904 (tiff_read_from_memory): Don't fail simply because the read would
6905 go past EOF; instead, return a short read.
6906 (tiff_load): Omit no-longer-needed casts.
6907 (Fimagemagick_types): Don't assume size fits into 'int'.
6909 Improve hashing quality when configured --with-wide-int.
6910 * fns.c (hash_string): New function, taken from sxhash_string.
6911 Do not discard information about ASCII character case; this
6912 discarding is no longer needed.
6913 (sxhash-string): Use it. Change sig to match it. Caller changed.
6914 * lisp.h: Declare it.
6915 * lread.c (hash_string): Remove, since we now use fns.c's version.
6916 The fns.c version returns a wider integer if --with-wide-int is
6917 specified, so this should help the quality of the hashing a bit.
6919 * emacs.c: Integer overflow minor fix.
6920 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6921 Define only if GNU_LINUX.
6922 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6924 * dispnew.c: Integer signedness and overflow fixes.
6925 Remove unnecessary forward decls, that were a maintenance hassle.
6926 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6928 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6929 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6930 (prepare_desired_row, line_draw_cost):
6931 Use int, not unsigned, where either works.
6932 (save_current_matrix, restore_current_matrix):
6933 Use ptrdiff_t, not size_t, where either works.
6934 (init_display): Check for overflow more accurately, and without
6935 relying on undefined behavior.
6937 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6938 Remove, replacing with the new symbols in lisp.h. All uses changed.
6939 * fileio.c (make_temp_name):
6940 * filelock.c (lock_file_1, lock_file):
6941 * xdisp.c (message_dolog):
6942 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6943 Use pMd etc. instead.
6944 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6945 replacing the pWIDE etc. symbols removed from editfns.c.
6947 * keyboard.h (num_input_events): Now uintmax_t.
6948 This is (very slightly) less likely to mess up due to wraparound.
6951 * buffer.c: Integer signedness fixes.
6952 (alloc_buffer_text, enlarge_buffer_text):
6953 Use ptrdiff_t rather than size_t when either will do, as we prefer
6956 * alloc.c: Integer signedness and overflow fixes.
6957 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6958 (__malloc_size_t): Default to size_t, not to int.
6959 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6960 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6961 Prefer ptrdiff_t to size_t when either would do, as we prefer
6963 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6964 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6965 Now const. Initialize with values that are in range even if char
6967 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6968 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6969 These functions do the right thing with sizes > 2**32.
6970 (check_depth): Now ptrdiff_t, not int.
6971 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6972 Adjust to new way of storing sizes. Check for size overflow bugs
6974 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6975 slightly wrong anyway, as it missed one instance of
6976 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6977 (refill_memory_reserve): Omit needless cast to size_t.
6978 (mark_object_loop_halt): Mark as externally visible.
6980 * xselect.c: Integer signedness and overflow fixes.
6981 (Fx_register_dnd_atom, x_handle_dnd_message):
6982 Use ptrdiff_t, not size_t, since we prefer signed.
6983 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6984 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6985 x_dnd_atoms_size and x_dnd_atoms_length.
6987 * doprnt.c: Prefer signed to unsigned when either works.
6989 * doprnt.c (doprnt):
6991 * xdisp.c (vmessage):
6992 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6993 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6994 prefer signed arithmetic to avoid comparison confusion.
6995 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6996 but is a bit tricky.
6998 Assume freestanding C89 headers, string.h, stdlib.h.
6999 * data.c, doprnt.c, floatfns.c, print.c:
7000 Include float.h unconditionally.
7001 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7002 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7003 * regex.c: Likewise for stddef.h, string.h.
7004 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7005 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7006 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7007 (STDC_HEADERS): Remove obsolete defines.
7008 * sysdep.c: Include limits.h unconditionally.
7010 Assume support for memcmp, memcpy, memmove, memset.
7011 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7012 * regex.c (memcmp, memcpy):
7013 Remove; we assume C89 now.
7015 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7016 (__malloc_safe_bcopy): Remove; no longer needed.
7018 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7019 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7020 well either way, and we prefer signed to unsigned.
7022 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7024 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7025 closes the connection while we're reading (bug#9182).
7027 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7029 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7030 are specified (Bug#9168).
7032 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7034 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7035 Found by GCC static checking and --with-wide-int on a 32-bit host.
7037 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7039 * xdisp.c (compute_display_string_pos): Fix logic of caching
7040 previous display string position. Initialize cached_prev_pos to
7041 -1. Fixes slow-down at the beginning of a buffer.
7043 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7045 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7046 for attrs[LFACE_FONTSET_INDEX].
7048 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7050 * xml.c (parse_region): Remove unused local
7051 that was recently introduced.
7053 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7055 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7056 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7058 * xdisp.c (move_it_in_display_line_to): Record the best matching
7059 position for TO_CHARPOS while scanning the line, and restore it on
7060 exit if none of the characters scanned was an exact match.
7061 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7062 when exact match is impossible due to invisible text, and the
7063 lines are truncated.
7065 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7067 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7070 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7072 Fix a significant slow-down of cursor motion with C-n, C-p,
7073 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7074 auto-repeat under bidi redisplay in fontified buffers.
7075 * xdisp.c (compute_stop_pos_backwards): New function.
7076 (next_element_from_buffer): Call compute_stop_pos_backwards to
7077 find a suitable prev_stop when we find ourselves before
7079 (reseat): Don't look for prev_stop, as that could mean a very long
7081 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7082 <cached_disp_overlay_modiff>: Cache for last found display string
7084 (compute_display_string_pos): Return the cached position if asked
7085 about the same buffer in the same area of character positions, and
7086 the buffer wasn't changed since the time the display string
7087 position was cached.
7089 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7091 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7092 is an integer, which is important for empty lines. (Bug#9149)
7094 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7096 * frame.c (Fmodify_frame_parameters): In tty case, update the
7097 default face if necessary (Bug#4238).
7099 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7101 * editfns.c (Fstring_to_char): No need to explain what a character
7102 is in the docstring (Bug#6576).
7104 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7106 * xml.c (parse_region): Make sure we always return a tree.
7108 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7110 * xml.c (parse_region): If a document contains only comments,
7113 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7115 * xml.c (make_dom): Return comments, too.
7117 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7120 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7121 and the surrounding thread.
7122 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7123 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7124 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7126 * s/openbsd.h (BROKEN_SIGIO): Define.
7127 * unexelf.c (unexec) [__OpenBSD__]:
7128 Don't update the .mdebug section of the Alpha COFF symbol table.
7130 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7132 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7135 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7137 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7138 This fixes some race conditions on the permissions of any newly
7141 * alloc.c (valid_pointer_p): Use pipe, not open.
7142 This fixes some permissions issues when debugging.
7144 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7145 If fchown fails to set both uid and gid, try to set just gid,
7146 as that is sometimes allowed. Adjust the file's mode to eliminate
7147 setuid or setgid bits that are inappropriate if fchown fails.
7149 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7151 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7152 to compare Lisp_Objects.
7153 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7154 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7155 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7157 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7159 * lread.c (read_integer): Unread even EOF character.
7160 (read1): Likewise. Properly record start position of symbol.
7162 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7163 symbol character follows.
7165 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7167 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7168 This works around a problem with the previous change to Fcopy_file.
7169 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7170 and without this change, GCC might complain about discarding
7171 fchown's return value.
7173 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7175 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7177 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7179 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7181 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7183 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7184 it's used from the C level.
7186 * process.c: Use the same condition for POLL_FOR_INPUT in both
7187 keyboard.c and process.c (bug#1858).
7189 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7191 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7192 (Fgnutls_boot): Use it.
7194 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7196 * doc.c (Fsubstitute_command_keys): Revert last change.
7198 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7200 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7201 quotes the next character, and doesn't affect other longer
7202 sequences (bug#8935).
7204 * lread.c (syms_of_lread): Clarify that is isn't only
7205 `eval-buffer' and `eval-defun' that's affected by
7206 `lexical-binding' (bug#8460).
7208 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7210 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7211 bidi redisplay when a line includes both an image and is truncated.
7213 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7215 Fix minor problems found by static checking.
7216 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7217 (elsz): Now a signed constant, not a size_t var. We prefer signed
7218 types to unsigned, to avoid integer comparison confusion. Without
7219 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7220 "cannot optimize loop, the loop counter may overflow", a symptom
7222 * indent.c (Fvertical_motion): Mark locals as initialized.
7223 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7225 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7227 * search.c (Fre_search_backward): Mention `case-fold-search' in
7228 all the re_search_* functions (bug#8138).
7230 * keyboard.c (Fopen_dribble_file): Document when the file is
7233 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7235 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7238 Support bidi reordering of display and overlay strings.
7239 * xdisp.c (compute_display_string_pos)
7240 (compute_display_string_end): Accept additional argument STRING.
7241 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7242 (reseat_to_string): Initialize bidi_it->string.s and
7243 bidi_it->string.schars.
7244 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7245 NULL (avoids a crash in bidi_paragraph_init).
7246 Initialize itb.string.lstring.
7247 (init_iterator): Call bidi_init_it only of a valid
7248 buffer position was specified. Initialize paragraph_embedding to
7250 (reseat_to_string): Initialize the bidi iterator.
7251 (display_string): If we need to ignore text properties of
7252 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7253 original value of -1 will not work with bidi.)
7254 (compute_display_string_pos): First arg is now struct
7255 `text_pos *'; all callers changed. Support display properties on
7257 (compute_display_string_end): Support display properties on Lisp
7259 (init_iterator, reseat_1, reseat_to_string): Initialize the
7260 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7261 when iterating on a string not from display properties).
7262 (compute_display_string_pos, compute_display_string_end):
7263 Fix calculation of the object to scan. Fixes an error when using
7265 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7266 base_level_stop; instead, set base_level_stop to BEGV.
7267 Fixes crashes in vertical-motion.
7268 (next_element_from_buffer): Improve commentary for when
7269 the iterator is before prev_stop.
7270 (init_iterator): Initialize bidi_p from the default value of
7271 bidi-display-reordering, not from buffer-local value. Use the
7272 buffer-local value only if initializing for buffer iteration.
7273 (handle_invisible_prop): Support invisible properties on strings
7274 that are being bidi-reordered.
7275 (set_iterator_to_next): Support bidi reordering of C strings and
7277 (next_element_from_string): Support bidi reordering of Lisp
7279 (handle_stop_backwards): Support Lisp strings as well.
7280 (display_string): Support display of R2L glyph rows.
7281 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7282 (init_iterator): Don't initialize it->bidi_p for strings
7284 (reseat_to_string): Initialize it->bidi_p for strings here.
7285 (next_element_from_string, next_element_from_c_string)
7286 (next_element_from_buffer): Add xassert's for correspondence
7287 between IT's object being iterated and it->bidi_it.string
7289 (face_before_or_after_it_pos): Support bidi iteration.
7290 (next_element_from_c_string): Handle the case of the first string
7291 character that is not the first one in the visual order.
7292 (get_visually_first_element): New function, refactored from common
7293 parts of next_element_from_buffer, next_element_from_string, and
7294 next_element_from_c_string.
7295 (tool_bar_lines_needed, redisplay_tool_bar)
7296 (display_menu_bar): Force left-to-right direction. Add a FIXME
7297 comment for making that be controlled by a user option.
7298 (push_it, pop_it): Save and restore the state of the
7299 bidi iterator. Save and restore the bidi_p flag.
7300 (pop_it): Iterate out of display property for string iteration as
7302 (iterate_out_of_display_property): Support iteration over strings.
7303 (handle_single_display_spec): Set up it->bidi_it for iteration
7304 over a display string, and call bidi_init_it.
7305 (handle_single_display_spec, next_overlay_string)
7306 (get_overlay_strings_1, push_display_prop): Set up the bidi
7307 iterator for displaying display or overlay strings.
7308 (forward_to_next_line_start): Don't use the shortcut if
7310 (back_to_previous_visible_line_start): If handle_display_prop
7311 pushed the iterator stack, restore the internal state of the bidi
7312 iterator by calling bidi_pop_it same number of times.
7313 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7314 and we are bidi-iterating, don't decrement the iterator position;
7315 instead, set the first_elt flag in the bidi iterator, to produce
7317 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7318 (push_display_prop): xassert that we are iterating a buffer.
7319 (push_it, pop_it): Save and restore paragraph_embedding member.
7320 (handle_single_display_spec, next_overlay_string)
7321 (get_overlay_strings_1, reseat_1, reseat_to_string)
7322 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7323 correctly. Don't assume unibyte strings are not bidi-reordered.
7324 (compute_display_string_pos)
7325 (compute_display_string_end): Fix handling the case of C string.
7326 (push_it, pop_it): Save and restore from_disp_prop_p.
7327 (handle_single_display_spec, push_display_prop): Set the
7328 from_disp_prop_p flag.
7329 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7330 (pop_it): Call iterate_out_of_display_property only if we are
7331 popping after iteration over a string that came from a display
7332 property. Fix a typo in popping stretch info. Add an assertion
7333 for verifying that the iterator position is in sync with the bidi
7335 (handle_single_display_spec, get_overlay_strings_1)
7336 (push_display_prop): Fix initialization of paragraph direction for
7337 string when that of the parent object is not yet determined.
7338 (reseat_1): Call bidi_init_it to resync the bidi
7339 iterator with IT's position. (Bug#7616)
7340 (find_row_edges): If ROW->start.pos gives position
7341 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7342 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7343 Reset the from_disp_prop_p flag.
7344 (SAVE_IT, RESTORE_IT): New macros.
7345 (pos_visible_p, face_before_or_after_it_pos)
7346 (back_to_previous_visible_line_start)
7347 (move_it_in_display_line_to, move_it_in_display_line)
7348 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7349 (try_scrolling, redisplay_window, display_line): Use them when
7350 saving a temporary copy of the iterator and restoring it back.
7351 (back_to_previous_visible_line_start, reseat_1)
7352 (init_iterator): Empty the bidi cache "stack".
7353 (move_it_in_display_line_to): If iterator ended up at
7354 EOL, but we never saw any buffer positions smaller than
7355 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7356 motion in bidi-reordered lines.
7357 (move_it_in_display_line_to): Record prev_method and prev_pos
7358 immediately before the call to set_iterator_to_next. Fixes cursor
7359 motion in bidi-reordered lines with stretch glyphs and strings
7360 displayed in margins. (Bug#8133) (Bug#8867)
7361 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7363 (pos_visible_p): Support positions in bidi-reordered lines.
7364 Save and restore bidi cache.
7366 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7367 (bidi_paragraph_info): Delete unused struct.
7368 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7369 (bidi_cache_start): New variable.
7370 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7372 (bidi_cache_fetch_state, bidi_cache_search)
7373 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7374 (bidi_cache_find, bidi_peek_at_next_level)
7375 (bidi_level_of_next_char, bidi_find_other_level_edge)
7376 (bidi_move_to_visually_next): Compare cache index with
7377 bidi_cache_start rather than with zero.
7378 (bidi_fetch_char): Accept new argument STRING; all callers
7379 changed. Support iteration over a string. Support strings with
7380 display properties. Support unibyte strings. Fix the type of
7381 `len' according to what STRING_CHAR_AND_LENGTH expects.
7382 (bidi_paragraph_init, bidi_resolve_explicit_1)
7383 (bidi_resolve_explicit, bidi_resolve_weak)
7384 (bidi_level_of_next_char, bidi_move_to_visually_next):
7385 Support iteration over a string.
7386 (bidi_set_sor_type, bidi_resolve_explicit_1)
7387 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7388 can now be zero (for strings); special values 0 and -1 were
7389 changed to -1 and -2, respectively.
7390 (bidi_char_at_pos): New function.
7391 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7392 Call it instead of FETCH_MULTIBYTE_CHAR.
7393 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7394 initialized to valid values.
7395 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7397 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7398 the test for valid cached positions. Fix the logic for looking up
7399 the sentinel state in the cache. GCPRO the Lisp string we are
7401 (bidi_push_it, bidi_pop_it): New functions.
7402 (bidi_initialize): Initialize the bidi cache start stack pointer.
7403 (bidi_cache_ensure_space): New function, refactored from part of
7404 bidi_cache_iterator_state. Don't assume the required size is just
7405 one BIDI_CACHE_CHUNK away.
7406 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7407 (bidi_count_bytes, bidi_char_at_pos): New functions.
7408 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7409 always valid if bidi_cache_idx is valid.
7410 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7411 is valid if it's going to be used.
7412 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7413 (bidi_cache_fetch_state, bidi_cache_search)
7414 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7415 (bidi_cache_iterator_state, bidi_cache_find)
7416 (bidi_find_other_level_edge, bidi_cache_start_stack):
7417 All variables related to cache indices are now EMACS_INT.
7419 * dispextern.h (struct bidi_string_data): New structure.
7420 (struct bidi_it): New member `string'. Make flag members be 1-bit
7421 fields, and put them last in the struct.
7422 (compute_display_string_pos, compute_display_string_end):
7424 (bidi_push_it, bidi_pop_it): Add prototypes.
7425 (struct iterator_stack_entry): New members bidi_p,
7426 paragraph_embedding, and from_disp_prop_p.
7427 (struct it): Member bidi_p is now a bit field 1 bit wide.
7428 (bidi_shelve_cache, bidi_unshelve_cache):
7431 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7432 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7433 and vector-like objects.
7435 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7436 cache around display iteration.
7438 * window.c (Fwindow_end, window_scroll_pixel_based)
7439 (displayed_window_lines, Frecenter): Save and restore the bidi
7440 cache around display iteration.
7442 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7444 * editfns.c (Fdelete_region): Clarify the use of the named
7445 parameters (bug#6788).
7447 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7449 * indent.c (Fvertical_motion): Set and restore w->pointm when
7450 saving and restoring the window's buffer (Bug#9006).
7452 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7454 * editfns.c (Fstring_to_char): Clarify just what is returned
7455 (bug#6576). Text by Eli Zaretskii.
7457 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7459 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7461 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7463 * buffer.c (mmap_find): Fix a typo.
7465 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7467 Fix execution of x selection hooks.
7468 * xselect.c (Qx_lost_selection_functions)
7469 (Qx_sent_selection_functions): New vars.
7470 (syms_of_xselect): DEFSYM them.
7471 (x_handle_selection_request): Pass Qx_sent_selection_functions
7472 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7473 (x_handle_selection_clear,x_clear_frame_selections):
7474 Pass Qx_lost_selection_functions rather than
7475 Vx_lost_selection_functions to Frun_hook_with_args.
7477 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7479 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7480 The old code sometimes used this field without initializing it.
7482 * alloc.c (gc_sweep): Don't read past end of array.
7483 In theory, the old code could also have corrupted Emacs internals,
7484 though it'd be very unlikely.
7486 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7488 * character.c (Fcharacterp): Don't advertise optional ignored
7489 argument. (Bug#4026)
7491 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7493 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7496 * window.c (Fset_window_start): Doc fix (bug#4199).
7497 (Fset_window_hscroll): Ditto.
7499 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7501 Fix minor new problems caught by GCC 4.6.1.
7502 * term.c (init_tty): Remove unused local.
7503 * xsettings.c (store_monospaced_changed): Define this function only
7504 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7507 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7509 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7511 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7513 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7514 are the mini-buffer and the echo area (bug#3320).
7516 * term.c (init_tty): Remove support for supdup, c10 and perq
7517 terminals, which are no longer supported (bug#1482).
7519 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7521 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7523 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7525 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7526 for non-popups (Bug#3642).
7528 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7530 * alloc.c (reset_malloc_hooks): Protoize.
7531 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7532 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7533 * cm.c (losecursor): Likewise.
7534 * data.c (fmod): Likewise.
7535 * dispnew.c (swap_glyphs_in_rows): Likewise.
7536 * emacs.c (memory_warning_signal): Likewise.
7537 * floatfns.c (float_error): Likewise.
7538 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7539 (otf_open, font_otf_capability, generate_otf_features)
7540 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7542 * image.c (pbm_read_file): Likewise.
7543 * indent.c (string_display_width): Likewise.
7544 * intervals.c (check_for_interval, search_for_interval)
7545 (inc_interval_count, count_intervals, root_interval)
7546 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7547 * lread.c (defalias): Likewise.
7548 * ralloc.c (r_alloc_check): Likewise.
7549 * regex.c (set_image_of_range_1, set_image_of_range)
7550 (regex_grow_registers): Likewise.
7551 * sysdep.c (strerror): Likewise.
7552 * termcap.c (valid_filename_p, tprint, main): Likewise.
7553 * tparam.c (main): Likewise.
7554 * unexhp9k800.c (run_time_remap, save_data_space)
7555 (update_file_ptrs, read_header, write_header, calculate_checksum)
7556 (copy_file, copy_rest, display_header): Likewise.
7557 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7559 * xdisp.c (check_it): Likewise.
7560 * xfaces.c (register_color, unregister_color, unregister_colors):
7562 * xfns.c (print_fontset_result): Likewise.
7563 * xrdb.c (member, fatal, main): Likewise.
7565 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7567 Fix minor problems found by static checking (Bug#9031).
7568 * chartab.c (char_table_set_range, map_sub_char_table):
7569 Remove unused locals.
7570 (uniprop_table): Now static.
7571 * composite.c (_work_char): Remove unused static var.
7573 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7575 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7577 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7579 * gtkutil.c (qttip_cb): Remove code without function.
7581 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7583 * w32.c (pthread_sigmask): New stub.
7585 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7587 Use pthread_sigmask, not sigprocmask (Bug#9010).
7588 sigprocmask is portable only for single-threaded applications, and
7589 Emacs can be multi-threaded when it uses GTK.
7590 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7592 * callproc.c (Fcall_process):
7593 * process.c (create_process):
7594 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7595 Use pthread_sigmask, not sigprocmask.
7597 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7599 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7600 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7603 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7605 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7606 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7607 (xg_hide_tooltip): Fix comment.
7609 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7610 in registerServicesMenuSendTypes.
7611 (validRequestorForSendType): Don't check ns_return_types.
7613 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7616 2011-07-08 Jason Rumney <jasonr@gnu.org>
7618 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7619 SH_SHOW for hidden windows (Bug#5482).
7621 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7622 frame struct members of non-existent frames (Bug#6284).
7624 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7626 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7627 variable firstTime not needed on OSX >= 10.6.
7628 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7629 >= 10.5. Use setKnobProportion, setDoubleValue.
7631 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7632 (MAC_OS_X_VERSION_10_5): Define if not defined.
7633 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7634 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7635 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7637 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7638 cString and lossyCString on OSX >= 10.4
7640 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7641 sizeToFit on OSX >= 10.2.
7643 * nsimage.m (allocInitFromFile): Don't use deprecated method
7644 bestRepresentationForDevice on OSX >= 10.6.
7646 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7649 * emacs.c: Declare unexec_init_emacs_zone.
7651 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7653 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7655 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7656 on svcsMenu (Bug#8842).
7658 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7660 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7662 * nsterm.m (QUTF8_STRING): Declare.
7663 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7664 (validRequestorForSendType): Return type is (id).
7665 Change indexOfObjectIdenticalTo to indexOfObject.
7666 Check if we have local selection before returning self (Bug#8842).
7667 (writeSelectionToPasteboard): Put local selection into paste board
7668 if we have a local selection (Bug#8842).
7669 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7671 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7672 (ns_get_local_selection): Declare.
7674 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7676 * keymap.c (describe_map_tree): Don't insert a double newline at
7677 the end of the buffer (bug#1169) and return whether we inserted
7680 * callint.c (Fcall_interactively): Change "reading args" to
7681 "providing args" to try to clarify what it does (bug#1010).
7683 2011-07-07 Kenichi Handa <handa@m17n.org>
7685 * composite.c (composition_compute_stop_pos): Ignore a static
7686 composition starting before CHARPOS (Bug#8915).
7688 * xdisp.c (handle_composition_prop): Likewise.
7690 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7692 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7695 2011-07-07 Kenichi Handa <handa@m17n.org>
7697 * character.h (unicode_category_t): New enum type.
7699 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7700 (Qchar_code_property_table): New variable.
7701 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7702 (UNIPROP_COMPRESSED_FORM_P): New macros.
7703 (char_table_ascii): Uncompress the compressed values.
7704 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7705 Uncompress the compressed values.
7706 (sub_char_table_ref_and_range): Likewise.
7707 (char_table_ref_and_range): Uncompress the compressed values.
7708 (sub_char_table_set): New arg is_uniprop. Callers changed.
7709 Uncompress the compressed values.
7710 (sub_char_table_set_range): Args changed. Callers changed.
7711 (char_table_set_range): Adjuted for the above change.
7712 (map_sub_char_table): Delete args default_val and parent. Add arg
7713 top. Give decoded values to a Lisp function.
7714 (map_char_table): Adjust for the above change. Give decoded
7715 values to a Lisp function. Gcpro more variables.
7716 (uniprop_table_uncompress)
7717 (uniprop_decode_value_run_length): New functions.
7718 (uniprop_decoder, uniprop_decoder_count): New variables.
7719 (uniprop_get_decoder, uniprop_encode_value_character)
7720 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7722 (uniprop_encoder, uniprop_encoder_count): New variables.
7723 (uniprop_get_encoder, uniprop_table)
7724 (Funicode_property_table_internal, Fget_unicode_property_internal)
7725 (Fput_unicode_property_internal): New functions.
7726 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7727 Sunicode_property_table_internal, Sget_unicode_property_internal,
7728 and Sput_unicode_property_internal. Defvar_lisp
7729 char-code-property-alist.
7731 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7732 Vunicode_category_table.
7734 * font.c (font_range): Adjust for the change of
7735 Vunicode_category_table.
7737 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7739 * m/iris4d.h: Remove file, move contents ...
7740 * s/irix6-5.h: ... here.
7742 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7744 Remove unportable assumption about struct layout (Bug#8884).
7745 * alloc.c (mark_buffer):
7746 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7747 (clone_per_buffer_values): Don't assume that
7748 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7749 This isn't true in general, and it's particularly not true
7750 if Emacs is configured with --with-wide-int.
7751 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7752 New macros, used in the buffer.c change.
7754 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7756 * xsettings.c: Use both GConf and GSettings if both are available.
7757 (store_config_changed_event): Add comment.
7758 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7759 (store_tool_bar_style_changed): New functions.
7760 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7761 (struct xsettings): Move font inside HAVE_XFT.
7762 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7763 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7764 Move inside HAVE_XFT.
7765 (something_changed_gsettingsCB): Rename from something_changedCB.
7766 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7768 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7769 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7770 (something_changed_gconfCB): Rename from something_changedCB.
7771 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7772 (parse_settings): Move check for font inside HAVE_XFT.
7773 (read_settings, apply_xft_settings): Add comment.
7774 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7775 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7776 call store_font_name_changed.
7777 (xft_settings_event): Add comment.
7778 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7779 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7780 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7781 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7782 (xsettings_initialize): Call init_gsettings last.
7783 (xsettings_get_system_font, xsettings_get_system_normal_font):
7786 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7788 Random fixes. E.g., (random) never returned negative values.
7789 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7790 subseconds part to the entropy, as that's a bit more random.
7791 Prefer signed to unsigned, since the signedness doesn't matter and
7792 in general we prefer signed. When given a limit, use a
7793 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7794 latter isn't right if USE_2_TAGS_FOR_INTS.
7795 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7796 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7798 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7800 * textprop.c (text_property_stickiness):
7801 Obey Vtext_property_default_nonsticky.
7802 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7803 * w32fns.c (syms_of_w32fns):
7804 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7806 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7808 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7809 This is more efficient than Ffile_directory_p and avoids a minor race.
7811 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7813 * buffer.c (Foverlay_put): Say what the return value is
7816 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7817 is a directory before asking whether to use the file name
7819 (barf_or_query_if_file_exists): Make the "File is a directory"
7820 error be more correct.
7822 * fns.c (Frequire): Remove the mention of the .gz files, since
7823 that's installation-specific, but keep the mention of
7824 `get-load-suffixes'.
7826 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7828 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7829 Report string overflow if the output is too long.
7831 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7833 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7834 (syms_of_gnutls): Remove duplicate DEFSYM for
7835 Qgnutls_bootprop_verify_hostname_error, an error for
7836 Qgnutls_bootprop_verify_error (which is no longer used).
7838 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7839 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7840 Also (re)move comments that are misplaced or no longer relevant.
7842 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7844 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7846 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7848 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7849 and background color parameters if they have been changed.
7851 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7853 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7855 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7857 * xsettings.c (SYSTEM_FONT): Define only when used.
7858 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7860 * keymap.c (access_keymap_1): Now static.
7862 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7864 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7865 leave any prefix arg for the up event (Bug#1586).
7867 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7869 * lread.c (syms_of_lread): Mention single symbols defined by
7870 `defvar' or `defconst' (bug#7154).
7872 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7873 (Frequire): Mention get-load-suffixes.
7875 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7877 * window.h (window): Remove clone_number slot.
7878 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7880 (make_parent_window, make_window, saved_window)
7881 (Fset_window_configuration, save_window_save): Don't deal with
7883 * buffer.c (Qclone_number): Remove declaration.
7884 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7886 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7888 Add multiple inheritance to keymaps.
7889 * keymap.c (Fmake_composed_keymap): New function.
7890 (Fset_keymap_parent): Simplify.
7891 (fix_submap_inheritance): Remove.
7892 (access_keymap_1): New function extracted from access_keymap to handle
7893 embedded parents and handle lists of maps.
7894 (access_keymap): Use it.
7895 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7896 (Fcopy_keymap): Handle embedded parents.
7897 (Fcommand_remapping, define_as_prefix): Simplify.
7898 (Fkey_binding): Simplify.
7899 (syms_of_keymap): Move minibuffer-local-completion-map,
7900 minibuffer-local-filename-completion-map,
7901 minibuffer-local-must-match-map, and
7902 minibuffer-local-filename-must-match-map to Elisp.
7903 (syms_of_keymap): Defsubr make-composed-keymap.
7904 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7905 (parse_menu_item): Trivial simplification.
7907 2011-07-01 Glenn Morris <rgm@gnu.org>
7909 * Makefile.in (SETTINGS_LIBS): Fix typo.
7911 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7913 * coding.c (Fencode_coding_string): Record the last coding system
7914 used, as the function doc string says (bug#8738).
7916 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7918 * xsettings.c (store_monospaced_changed): Take new font as arg and
7919 check for change against current_mono_font.
7920 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7921 (emacs_settings_constructor, emacs_settings_get_property)
7922 (emacs_settings_set_property, emacs_settings_class_init)
7923 (emacs_settings_init, gsettings_obj): Remove.
7924 (something_changedCB): New function for HAVE_GSETTINGS.
7925 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7926 with value as argument.
7927 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7928 g_settings_new (Bug#8967). Do not create gsettings_obj.
7929 Remove calls to g_settings_bind. Connect something_changedCB to
7932 * xgselect.c: Add defined (HAVE_GSETTINGS).
7933 (xgselect_initialize): Ditto.
7935 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7936 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7939 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7941 * eval.c (struct backtrace): Simplify and port the data structure.
7942 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7943 signed bit field, as this assumption is not portable and it makes
7944 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7945 "char debug_on_exit : 1" as this is not portable either; instead,
7946 use the portable "unsigned int debug_on_exit : 1". Remove unused
7947 member evalargs. Remove obsolete comments about cc bombing out.
7949 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7951 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7952 Let HAVE_GSETTINGS override HAVE_GCONF.
7953 (store_monospaced_changed): New function.
7954 (EMACS_SETTINGS): A new type derived from GObject to handle
7955 GSettings notifications.
7956 (emacs_settings_constructor, emacs_settings_get_property)
7957 (emacs_settings_set_property, emacs_settings_class_init):
7959 (gsettings_client, gsettings_obj): New variables.
7960 (GSETTINGS_SCHEMA): New define.
7961 (something_changedCB): Call store_monospaced_changed.
7962 (init_gsettings): New function.
7963 (xsettings_initialize): Call init_gsettings.
7964 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7967 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7970 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7972 * window.c (resize_root_window, grow_mini_window)
7973 (shrink_mini_window): Rename Qresize_root_window to
7974 Qwindow_resize_root_window and Qresize_root_window_vertically to
7975 Qwindow_resize_root_window_vertically.
7977 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7979 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7981 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7983 * makefile.w32-in: Redesign dependencies so they reflect more
7984 clearly which files are directly included by each source file,
7985 and not through other includes.
7987 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7989 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7990 (sort_overlays, overlay_strings): When an overlay's clone number
7991 matches the window's clone number process the overlay even if
7992 the overlay's window property doesn't match the current window.
7994 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7995 (Fwindow_hchild): Rename to Fwindow_left_child.
7996 (Fwindow_next): Rename to Fwindow_next_sibling.
7997 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7998 (resize_window_check): Rename to window_resize_check.
7999 (resize_window_apply): Rename to window_resize_apply.
8000 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8001 (Fdelete_other_windows_internal, resize_frame_windows)
8002 (Fsplit_window_internal, Fdelete_window_internal)
8003 (grow_mini_window, shrink_mini_window)
8004 (Fresize_mini_window_internal): Fix callers accordingly.
8006 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8008 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8009 (emacs_fixed_set_min_size): Remove.
8010 (emacs_fixed_new): Take frame as argument.
8012 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8013 (_EmacsFixedPrivate): Remove minwidth/height.
8014 Add struct frame *f.
8015 (emacs_fixed_init): Initialize priv->f.
8016 (get_parent_class, emacs_fixed_set_min_size): Remove.
8017 (emacs_fixed_new): Set priv->f to argument.
8018 (emacs_fixed_get_preferred_width)
8019 (emacs_fixed_get_preferred_height): Use min_width/height from
8020 frames size_hint to set minimum and natural (Bug#8919).
8021 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8022 and use min_width/height from frames size_hint to set
8023 min_width/height (Bug#8919).
8025 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8026 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8029 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8031 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8032 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8035 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8037 * process.c (wait_reading_process_output): Bypass select if
8038 waiting for a cell while ignoring keyboard input, and input is
8039 pending. Suggested by Jan Djärv (Bug#8869).
8041 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8043 Use gnulib's dup2 module instead of rolling our own.
8044 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8046 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8048 * dispnew.c (scrolling_window): Before scrolling, turn off a
8049 mouse-highlight in the window being scrolled.
8051 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8053 Move DEFSYM to lisp.h and use everywhere.
8055 * character.h (DEFSYM): Move declaration...
8056 * lisp.h (DEFSYM): ...here.
8062 * w32select.c: Don't include character.h.
8064 * alloc.c (syms_of_alloc):
8065 * buffer.c (syms_of_buffer):
8066 * bytecode.c (syms_of_bytecode):
8067 * callint.c (syms_of_callint):
8068 * casefiddle.c (syms_of_casefiddle):
8069 * casetab.c (init_casetab_once):
8070 * category.c (init_category_once, syms_of_category):
8071 * ccl.c (syms_of_ccl):
8072 * cmds.c (syms_of_cmds):
8073 * composite.c (syms_of_composite):
8074 * dbusbind.c (syms_of_dbusbind):
8075 * dired.c (syms_of_dired):
8076 * dispnew.c (syms_of_display):
8077 * doc.c (syms_of_doc):
8078 * editfns.c (syms_of_editfns):
8079 * emacs.c (syms_of_emacs):
8080 * eval.c (syms_of_eval):
8081 * fileio.c (syms_of_fileio):
8082 * fns.c (syms_of_fns):
8083 * frame.c (syms_of_frame):
8084 * fringe.c (syms_of_fringe):
8085 * insdel.c (syms_of_insdel):
8086 * keymap.c (syms_of_keymap):
8087 * lread.c (init_obarray, syms_of_lread):
8088 * macros.c (syms_of_macros):
8089 * msdos.c (syms_of_msdos):
8090 * print.c (syms_of_print):
8091 * process.c (syms_of_process):
8092 * search.c (syms_of_search):
8093 * sound.c (syms_of_sound):
8094 * syntax.c (init_syntax_once, syms_of_syntax):
8095 * terminal.c (syms_of_terminal):
8096 * textprop.c (syms_of_textprop):
8097 * undo.c (syms_of_undo):
8098 * w32.c (globals_of_w32):
8099 * window.c (syms_of_window):
8100 * xdisp.c (syms_of_xdisp):
8101 * xfaces.c (syms_of_xfaces):
8102 * xfns.c (syms_of_xfns):
8103 * xmenu.c (syms_of_xmenu):
8104 * xsettings.c (syms_of_xsettings):
8105 * xterm.c (syms_of_xterm): Use DEFSYM.
8107 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8109 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8111 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8113 Integer and buffer overflow fixes (Bug#8873).
8115 * print.c (printchar, strout): Check for string overflow.
8116 (PRINTPREPARE, printchar, strout):
8117 Don't set size unless allocation succeeds.
8119 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8120 for sizes. Check for string overflow more accurately.
8121 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8123 * macros.c: Integer and buffer overflow fixes.
8124 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8125 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8126 Use ptrdiff_t, not int, for sizes.
8127 Don't increment bufsize until after realloc succeeds.
8128 Check for size-calculation overflow.
8129 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8131 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8133 * lread.c: Integer overflow fixes.
8134 (read_integer): Radix is now EMACS_INT, not int,
8135 to improve quality of diagnostics for out-of-range radices.
8136 Calculate buffer size correctly for out-of-range radices.
8137 (read1): Check for integer overflow in radices, and in
8138 read-circle numbers.
8139 (read_escape): Avoid int overflow.
8140 (Fload, openp, read_buffer_size, read1)
8141 (substitute_object_recurse, read_vector, read_list, map_obarray):
8142 Use ptrdiff_t, not int, for sizes.
8143 (read1): Use EMACS_INT, not int, for sizes.
8144 Check for size overflow.
8146 * image.c (cache_image): Check for size arithmetic overflow.
8148 * lread.c: Integer overflow issues.
8149 (saved_doc_string_size, saved_doc_string_length)
8150 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8151 Now ptrdiff_t, not int.
8152 (read1): Don't assume doc string length fits in int. Check for
8153 out-of-range doc string lengths.
8154 (read_list): Don't assume file position fits in int.
8155 (read_escape): Check for hex character overflow.
8157 2011-06-22 Leo Liu <sdl.web@gmail.com>
8159 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8160 Move to minibuffer.el.
8162 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8164 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8165 The following patches are for when GLYPH_DEBUG && !XASSERT.
8166 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8167 * dispnew.c (flush_stdout):
8168 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8169 Mark as externally visible.
8170 * dispnew.c (check_window_matrix_pointers): Now static.
8171 * dispnew.c (window_to_frame_vpos):
8172 * xfns.c (unwind_create_frame):
8173 * xterm.c (x_check_font): Remove unused local.
8174 * scroll.c (CHECK_BOUNDS):
8175 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8176 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8177 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8178 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8179 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8181 (debug_method_add): Use va_list and vsprintf rather than relying
8182 on undefined behavior with wrong number of arguments.
8183 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8184 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8185 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8186 since we're not interested in debugging glyphs with old libraries.
8187 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8188 GCC 4.6.0's static checking.
8190 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8192 Integer overflow and signedness fixes (Bug#8873).
8193 A few related buffer overrun fixes, too.
8195 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8197 * dispextern.h (struct face.stipple):
8198 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8199 (x_bitmap_mask, x_allocate_bitmap_record)
8200 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8201 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8202 (x_create_bitmap_from_xpm_data):
8203 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8204 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8206 * xfaces.c (load_pixmap):
8207 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8208 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8209 (.bitmaps_last, struct x_output.icon_bitmap):
8210 Use ptrdiff_t, not int, for bitmap indexes.
8211 (x_allocate_bitmap_record): Check for size overflow.
8212 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8214 Use ptrdiff_t, not int, for overlay counts.
8215 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8216 * editfns.c (overlays_around, get_pos_property):
8217 * textprop.c (get_char_property_and_overlay):
8218 * xdisp.c (next_overlay_change, note_mouse_highlight):
8219 * xfaces.c (face_at_buffer_position):
8220 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8221 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8222 (Fnext_overlay_change, Fprevious_overlay_change)
8223 (mouse_face_overlay_overlaps, Foverlays_in):
8224 Use ptrdiff_t, not int, for sizes.
8225 (overlays_at, overlays_in): Check for size-calculation overflow.
8227 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8229 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8230 (x_session_initialize): Do not assume string length fits in int.
8232 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8233 This is unlikely, but can occur if DPI is outlandish.
8235 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8236 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8238 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8239 * xrdb.c (magic_file_p, search_magic_path):
8240 Omit last arg SUFFIX; it was always 0. All callers changed.
8241 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8243 * xfont.c (xfont_match): Avoid need for strlen.
8245 * xfns.c: Don't assume strlen fits in int.
8246 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8248 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8249 not unsigned long, as we prefer signed integers. All callers changed.
8250 Detect integer overflow in repeat count.
8251 (message_dolog): Don't assume print length fits in 39 bytes.
8252 (display_mode_element): Don't assume strlen fits in int.
8254 * termcap.c: Don't assume sizes fit in int and never overflow.
8255 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8256 (gobble_line): Check for size-calculation overflow.
8258 * minibuf.c (Fread_buffer):
8259 * lread.c (intern, intern_c_string):
8260 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8261 Don't assume string length fits in int.
8263 * keyboard.c (parse_tool_bar_item):
8264 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8266 * font.c: Don't assume string length fits in int.
8267 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8268 Use ptrdiff_t, not int.
8269 (font_intern_prop): Don't assume string length fits in int.
8270 Don't assume integer property fits in fixnum.
8271 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8273 * filelock.c: Fix some buffer overrun and integer overflow issues.
8274 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8275 Reformulate so as not to need the command string.
8276 Invoke gzip -cd rather than gunzip, as it's more portable.
8277 (lock_info_type, lock_file_1, lock_file):
8278 Don't assume pid_t and time_t fit in unsigned long.
8279 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8280 (current_lock_owner): Prefer signed type for sizes.
8281 Use memcpy, not strncpy, where memcpy is what is really wanted.
8282 Don't assume (via atoi) that time_t and pid_t fit in int.
8283 Check for time_t and/or pid_t out of range, e.g., via a network share.
8284 Don't alloca where an auto var works fine.
8286 * fileio.c: Fix some integer overflow issues.
8287 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8288 Don't assume string length fits in int.
8289 (directory_file_name): Don't assume string length fits in long.
8290 (make_temp_name): Don't assume pid fits in int, or that its print
8291 length is less than 20.
8293 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8295 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8297 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8299 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8300 We prefer signed integers, even for size calculations.
8302 * emacs.c: Don't assume string length fits in 'int'.
8303 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8304 (main): Don't invoke strlen when not needed.
8306 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8307 (XD_DEBUG_MESSAGE): Don't waste a byte.
8309 * callproc.c (getenv_internal_1, getenv_internal)
8311 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8313 * lread.c (invalid_syntax): Omit length argument.
8314 All uses changed. This doesn't fix a bug, but it simplifies the
8315 code away from its former Hollerith-constant appearance, and it's
8316 one less 'int' to worry about when looking at integer-overflow issues.
8317 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8319 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8320 This didn't break anything, but it didn't help either.
8321 It's confusing to put a bogus integer in a place where the actual
8322 value does not matter.
8323 (LIST_END_P): Remove unused macro and its bogus comment.
8324 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8326 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8327 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8329 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8330 We prefer signed types, and the value cannot exceed the EMACS_INT
8331 range anyway (because otherwise the length would not be representable).
8332 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8333 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8334 This avoids a GCC warning when WIDE_EMACS_INT.
8336 * indent.c (sane_tab_width): New function.
8337 (current_column, scan_for_column, Findent_to, position_indentation)
8338 (compute_motion): Use it. This is just for clarity.
8339 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8341 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8343 * lisp.h (lint_assume): New macro.
8344 * composite.c (composition_gstring_put_cache):
8345 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8347 * editfns.c, insdel.c:
8348 Omit unnecessary forward decls, to simplify future changes.
8350 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8352 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8354 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8355 Use much-faster test for byte-length change.
8356 Don't assume string byte-length fits in 'int'.
8357 Check that character arg fits in 'int'.
8358 (mapcar1): Declare byte as byte, for clarity.
8360 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8362 * fns.c (concat): Catch string overflow earlier.
8363 Do not rely on integer wraparound.
8365 * dispextern.h (struct it.overlay_strings_charpos)
8366 (struct it.selective): Now EMACS_INT, not int.
8367 * xdisp.c (forward_to_next_line_start)
8368 (back_to_previous_visible_line_start)
8369 (reseat_at_next_visible_line_start, next_element_from_buffer):
8370 Don't arbitrarily truncate the value of 'selective' to int.
8372 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8374 * composite.c: Don't truncate sizes to 'int'.
8375 (composition_gstring_p, composition_reseat_it)
8376 (composition_adjust_point): Use EMACS_INT, not int.
8377 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8378 not EMACS_UINT, for indexes.
8380 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8382 * buffer.c: Include <verify.h>.
8383 (struct sortvec.priority, struct sortstr.priority):
8384 Now EMACS_INT, not int.
8385 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8386 (struct sortstr.size, record_overlay_string)
8387 (struct sortstrlist.size, struct sortlist.used):
8388 Don't truncate size to int.
8389 (record_overlay_string): Check for size-calculation overflow.
8390 (init_buffer_once): Check at compile-time, not run-time.
8392 2011-06-22 Jim Meyering <meyering@redhat.com>
8394 Don't leak an XBM-image-sized buffer
8395 * image.c (xbm_load): Free the image buffer after using it.
8397 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8400 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8401 that Sun C diagnosed.
8402 * fns.c (secure_hash): Fix pointer signedness issue.
8403 * intervals.c (static_offset_intervals): New function.
8404 (offset_intervals): Use it.
8406 2011-06-21 Leo Liu <sdl.web@gmail.com>
8409 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8412 * fns.c (secure_hash): Rename from crypto_hash_function and change
8413 the first arg to accept symbols.
8414 (Fsecure_hash): New primitive.
8415 (syms_of_fns): New symbols.
8417 2011-06-20 Deniz Dogan <deniz@dogan.se>
8419 * process.c (Fset_process_buffer): Clarify return value in
8422 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8424 * dispnew.c (add_window_display_history): Use BVAR.
8426 * xdisp.c (debug_method_add): Use BVAR.
8427 (check_window_end, dump_glyph_matrix, dump_glyph)
8428 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8430 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8433 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8434 check till after the cache is created in init_frame_faces.
8436 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8438 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8440 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8442 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8443 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8444 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8446 Improve buffer-overflow checking (Bug#8873).
8447 * fileio.c (Finsert_file_contents):
8448 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8449 Remove the old (too-loose) buffer overflow checks.
8450 They weren't needed, since make_gap checks for buffer overflow.
8451 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8452 The old code merely checked for Emacs fixnum overflow, and relied
8453 on undefined (wraparound) behavior. The new code avoids undefined
8454 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8456 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8457 Tune. Don't use wider integers than needed. Don't use alloca.
8458 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8460 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8462 * insdel.c, lisp.h (buffer_overflow): New function.
8463 (insert_from_buffer_1, replace_range, replace_range_2):
8464 * insdel.c (make_gap_larger):
8465 * editfns.c (Finsert_char):
8466 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8468 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8470 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8472 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8474 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8475 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8477 * fileio.c: Don't assume EMACS_INT fits in off_t.
8478 (emacs_lseek): New static function.
8479 (Finsert_file_contents, Fwrite_region): Use it.
8480 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8482 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8484 * fns.c: Don't overflow int when computing a list length.
8485 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8486 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8487 truncation on 64-bit hosts. Check for QUIT every
8488 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8489 faster and is responsive enough.
8490 (Flength): Report an error instead of overflowing an integer.
8491 (Fsafe_length): Return a float if the value is not representable
8492 as a fixnum. This shouldn't happen except in contrived situations.
8493 (Fnthcdr, Fsort): Don't assume list length fits in int.
8494 (Fcopy_sequence): Don't assume vector length fits in int.
8496 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8497 (header_size, word_size): New constants.
8498 (allocate_vectorlike): Don't check size overflow here.
8499 (allocate_vector): Check it here instead, since this is the only
8500 caller of allocate_vectorlike that could cause overflow.
8501 Check that the new vector's length is representable as a fixnum.
8503 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8504 The previous code was bogus. For example, next_almost_prime (32)
8505 returned 39, which is undesirable as it is a multiple of 3; and
8506 next_almost_prime (24) returned 25, which is a multiple of 5 so
8507 why was the code bothering to check for multiples of 7?
8509 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8511 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8513 Variadic C functions now count arguments with ptrdiff_t.
8514 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8515 Back then I didn't know that the Emacs coding style prefers signed int.
8516 Also, in the meantime I found a few more instances where arguments
8517 were being counted with int, which may truncate counts on 64-bit
8518 machines, or EMACS_INT, which may be unnecessarily wide.
8519 * lisp.h (struct Lisp_Subr.function.aMANY)
8520 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8521 Arg counts are now ptrdiff_t, not size_t.
8522 All variadic functions and their callers changed accordingly.
8523 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8524 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8525 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8526 * callint.c (Fcall_interactively): Check arg count for overflow,
8527 to avoid potential buffer overrun. Use signed char, not 'int',
8528 for 'varies' array, so that we needn't bother to check its size
8529 calculation for overflow.
8530 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8531 * eval.c (apply_lambda):
8532 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8533 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8534 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8536 * callint.c (Fcall_interactively): Don't use index var as event count.
8538 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8539 * mem-limits.h (SIZE): Remove; no longer used.
8541 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8543 Remove unnecessary casts.
8544 * xterm.c (x_term_init):
8545 * xfns.c (x_set_border_pixel):
8546 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8547 These aren't needed now that we assume ANSI C.
8549 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8550 It's more likely to cause problems (due to unsigned overflow)
8553 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8555 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8557 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8559 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8561 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8563 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8565 GLYPH_CODE_FACE returns EMACS_INT, not int.
8566 * dispextern.h (merge_faces):
8567 * xfaces.c (merge_faces):
8568 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8569 Don't assume EMACS_INT fits in int.
8571 * character.h (CHAR_VALID_P): Remove unused parameter.
8572 * fontset.c, lisp.h, xdisp.c: All uses changed.
8574 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8576 * fns.c (concat): Minor tuning based on overflow analysis.
8577 This doesn't fix any bugs. Use int to hold character, instead
8578 of constantly refetching from Emacs object. Use XFASTINT, not
8579 XINT, for value known to be a character. Don't bother comparing
8580 a single byte to 0400, as it's always less.
8582 * floatfns.c (Fexpt):
8583 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8585 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8588 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8590 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8591 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8592 incorrectly succeed when S was a string, because 4294967386 was
8593 truncated before it was used.
8595 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8596 Otherwise, an out-of-range integer could cause undefined behavior
8599 * composite.c: Use int, not EMACS_INT, for characters.
8600 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8601 EMACS_INT, for values that are known to be in character range.
8602 This doesn't fix any bugs but is the usual style inside Emacs and
8603 may generate better code on 32-bit machines.
8605 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8606 This is for reasons similar to the recent CHAR_STRING fix.
8607 * charset.c (Fencode_char): Check that character arg is actually
8608 a character. Pass an int to ENCODE_CHAR.
8609 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8610 wider than 'int', as a compile-time check to prevent future regressions
8613 * character.c (char_string): Remove unnecessary casts.
8615 Make sure a 64-bit char is never passed to CHAR_STRING.
8616 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8617 by silently ignoring the top 32 bits, allowing some values
8618 that were far too large to be valid characters.
8619 * character.h: Include <verify.h>.
8620 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8621 arguments are no wider than unsigned, as a compile-time check
8622 to prevent future regressions in this area.
8624 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8625 (Fsubst_char_in_region):
8627 * xdisp.c (decode_mode_spec_coding):
8628 Adjust to CHAR_STRING's new requirement.
8629 * editfns.c (Finsert_char, Fsubst_char_in_region):
8630 * fns.c (concat): Check that character args are actually
8631 characters. Without this test, these functions did the wrong
8632 thing with wildly out-of-range values on 64-bit hosts.
8634 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8635 These casts should not be needed on 32-bit hosts, either.
8636 * keyboard.c (read_char):
8637 * lread.c (Fload): Remove casts to unsigned.
8639 * lisp.h (UNSIGNED_CMP): New macro.
8640 This fixes comparison bugs on 64-bit hosts.
8641 (ASCII_CHAR_P): Use it.
8642 * casefiddle.c (casify_object):
8643 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8644 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8645 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8646 * dispextern.h (FACE_FROM_ID):
8647 * keyboard.c (read_char): Use UNSIGNED_CMP.
8649 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8650 not to EMACS_INT, to avoid GCC warning.
8652 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8654 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8655 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8656 isn't needed on 32-bit machines.
8658 * buffer.c (Fgenerate_new_buffer_name):
8659 Use EMACS_INT for count, not int.
8660 (advance_to_char_boundary): Return EMACS_INT, not int.
8662 * data.c (Qcompiled_function): Now static.
8664 * window.c (window_body_lines): Now static.
8666 * image.c (gif_load): Rename local to avoid shadowing.
8668 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8669 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8670 * alloc.c (make_save_value): Integer argument is now of type
8672 (mark_object): Use ptrdiff_t, not int.
8673 * lisp.h (pD): New macro.
8674 * print.c (print_object): Use it.
8676 * alloc.c: Use EMACS_INT, not int, to count objects.
8677 (total_conses, total_markers, total_symbols, total_vector_size)
8678 (total_free_conses, total_free_markers, total_free_symbols)
8679 (total_free_floats, total_floats, total_free_intervals)
8680 (total_intervals, total_strings, total_free_strings):
8681 Now EMACS_INT, not int. All uses changed.
8682 (Fgarbage_collect): Compute overall total using a double, so that
8683 integer overflow is less likely to be a problem. Check for overflow
8684 when converting back to an integer.
8685 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8686 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8687 These were 'int' variables that could overflow on 64-bit hosts;
8688 they were never used, so remove them instead of repairing them.
8689 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8690 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8691 Previously, this ceilinged at INT_MAX, but that doesn't work on
8693 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8695 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8696 (allocate_vectorlike): Check for ptrdiff_t overflow.
8697 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8698 when a (possibly-narrower) signed value would do just as well.
8699 We prefer using signed arithmetic, to avoid comparison confusion.
8701 * alloc.c: Catch some string size overflows that we were missing.
8702 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8703 for convenience in STRING_BYTES_MAX.
8704 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8705 The definition here is exact; the one in lisp.h was approximate.
8706 (allocate_string_data): Check for string overflow. This catches
8707 some instances we weren't catching before. Also, it catches
8708 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8709 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8710 and ptrdiff_t and EMACS_INT are both 64 bits.
8712 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8713 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8714 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8716 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8718 * alloc.c (Fmake_string): Check for out-of-range init.
8720 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8722 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8724 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8726 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8727 xg_get_default_scrollbar_width.
8729 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8730 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8731 (style_changed_cb): Call update_theme_scrollbar_width and call
8732 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8733 all frames (Bug#8505).
8734 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8735 Call gtk_window_set_resizable if HAVE_GTK3.
8736 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8737 and height if HAVE_GTK3 (Bug#8505).
8738 (scroll_bar_width_for_theme): New variable.
8739 (update_theme_scrollbar_width): New function.
8740 (xg_get_default_scrollbar_width): Move code to
8741 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8742 (xg_initialize): Call update_theme_scrollbar_width.
8744 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8746 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8748 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8750 * frame.c (make_frame): Call other_buffer_safely instead of
8753 * window.c (temp_output_buffer_show): Call display_buffer with
8754 second argument Vtemp_buffer_show_specifiers and reset latter
8755 immediately after the call.
8756 (Vtemp_buffer_show_specifiers): New variable.
8757 (auto_window_vscroll_p, next_screen_context_lines)
8758 (Vscroll_preserve_screen_position): Remove leading asterisks from
8761 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8763 Fix minor problems found by GCC 4.6.0 static checking.
8764 * buffer.c (Qclone_number): Remove for now, as it's unused.
8765 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8766 (record_buffer): Remove unused local.
8767 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8768 (set_frame_buffer_list): Remove; unused.
8769 * frame.h (other_visible_frames): Remove decl.
8770 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8771 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8772 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8774 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8775 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8776 Define only if HAVE_GPM.
8777 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8778 (update_hints_inhibit): Remove; never set. All uses removed.
8779 * widgetprv.h (emacsFrameClassRec): Remove decl.
8780 * window.c (delete_deletable_window): Now returns void, since it
8781 wasn't returning anything.
8782 (compare_window_configurations): Remove unused locals.
8783 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8784 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8785 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8786 the same widths as pointers. This follows up on the 2011-05-06 patch.
8787 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8788 * xterm.h: Likewise.
8789 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8791 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8793 * makefile.w32-in: Update dependencies.
8794 (LISP_H): Add lib/intprops.h.
8796 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8798 * image.c (gif_load): Add animation frame delay to the metadata.
8799 (syms_of_image): Use DEFSYM. New symbol `delay'.
8801 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8803 * window.c (delete_deletable_window): Re-add.
8804 (Fset_window_configuration): Rewrite to handle dead buffers and
8805 consequently deletable windows.
8806 (window_tree, Fwindow_tree): Remove. Supply functionality in
8808 (compare_window_configurations): Simplify code.
8810 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8812 * image.c (imagemagick_load_image): Fix type mismatch.
8813 (Fimagemagick_types): Likewise.
8815 * window.h (replace_buffer_in_windows): Declare.
8817 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8819 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8820 Qclone_number. Remove external declaration of Qdelete_window.
8821 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8823 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8824 Run Qbuffer_list_update_hook if allowed.
8825 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8826 buffer list implementation.
8827 (other_buffer_safely): New function.
8828 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8829 calls to replace_buffer_in_windows and
8830 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8832 (record_buffer): Inhibit quitting and rewrite using quittable
8833 functions. Run Qbuffer_list_update_hook if allowed.
8834 (Frecord_buffer, Funrecord_buffer): New functions.
8835 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8836 Move switch-to-buffer to window.el.
8837 (bury-buffer): Move to window.el.
8838 (Vbuffer_list_update_hook): New variable.
8840 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8843 * window.h (resize_frame_windows): Move up in code.
8844 (Fwindow_frame): Remove EXFUN.
8845 (replace_buffer_in_all_windows): Remove prototype.
8846 (replace_buffer_in_windows_safely): Add prototype.
8848 * window.c: Declare Qdelete_window static again. Move down
8849 declaration of select_count.
8850 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8851 (Fother_window): Move to window.el.
8852 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8853 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8854 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8856 (replace_buffer_in_windows): Implement by calling
8857 Qreplace_buffer_in_windows.
8858 (replace_buffer_in_all_windows): Remove with some functionality
8859 moved into replace_buffer_in_windows_safely.
8860 (replace_buffer_in_windows_safely): New function.
8861 (select_window_norecord, select_frame_norecord): Move in front
8862 of run_window_configuration_change_hook. Remove now obsolete
8864 (Fset_window_buffer): Rewrite doc-string.
8865 Call Qrecord_window_buffer.
8866 (keys_of_window): Move binding for other-window to window.el.
8868 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8870 * dispextern.h (struct image): Replace data member, whose int_val
8871 and ptr_val fields were not used by anything, with a single
8874 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8875 (gif_clear_image, gif_load, imagemagick_load_image)
8876 (gs_clear_image, gs_load): Callers changed.
8878 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8880 * buffer.h: Include <time.h>, for time_t.
8881 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8883 Fix minor problems found by static checking.
8885 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8887 Make identifiers static if they are not used in other modules.
8888 * data.c (Qcompiled_function, Qframe, Qvector):
8889 * image.c (QimageMagick, Qsvg):
8890 * minibuf.c (Qmetadata):
8891 * window.c (resize_window_check, resize_root_window): Now static.
8892 * window.h (resize_window_check, resize_root_window): Remove decls.
8894 * window.c (window_deletion_count, delete_deletable_window):
8896 (window_body_lines): Now static.
8897 (Fdelete_other_windows_internal): Mark vars as initialized.
8898 Make sure 'resize_failed' is initialized.
8899 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8900 (resize_window_apply): Remove unused local.
8901 * window.h (delete_deletable_window): Remove decl.
8903 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8904 (imagemagick_load_image): Fix pointer signedness problem by changing
8905 last arg from unsigned char * to char *. All uses changed.
8906 Also, fix a local for similar reasons.
8907 Remove unused locals. Remove locals to avoid shadowing.
8908 (fn_rsvg_handle_free): Remove; unused.
8909 (svg_load, svg_load_image): Fix pointer signedness problem.
8910 (imagemagick_load_image): Don't use garbage pointer image_wand.
8912 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8914 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8916 * image.c (gif_load): Fix omitted cast error introduced by
8919 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8921 * window.h (resize_proportionally, orig_total_lines)
8922 (orig_top_line): Remove from window structure.
8923 (set_window_height, set_window_width, change_window_heights)
8924 (Fdelete_window): Remove prototypes.
8925 (resize_frame_windows): Remove duplicate declaration.
8927 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8929 * window.h (resize_frame_windows, resize_window_check)
8930 (delete_deletable_window, resize_root_window)
8931 (resize_frame_windows): Declare prototypes.
8933 * window.c (resize_window_apply): Make definition be "static" to
8934 match the prototype.
8936 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8938 * window.c: Remove declarations of Qwindow_size_fixed,
8939 window_min_size_1, window_min_size_2, window_min_size,
8940 size_window, window_fixed_size_p, enlarge_window, delete_window.
8941 Remove static from declaration of Qdelete_window, it's
8942 temporarily needed by Fbury_buffer.
8943 (replace_window): Don't assign orig_top_line and
8945 (Fdelete_window, delete_window): Remove. Window deletion is
8946 handled by window.el.
8947 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8948 Replace Fdelete_window calls with calls to Qdelete_window.
8949 (Fdelete_other_windows): Remove. Deleting other windows is
8950 handled by window.el.
8951 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8952 handled in window.el.
8953 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8954 Window minimum sizes are handled in window.el.
8955 (shrink_windows, size_window, set_window_height)
8956 (set_window_width, change_window_heights, window_height)
8957 (window_width, CURBEG, CURSIZE, enlarge_window)
8958 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8959 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8960 handled in window.el.
8961 (make_dummy_parent): Rename to make_parent_window and give it a
8962 second argument horflag.
8963 (make_window): Don't set resize_proportionally any more.
8964 (Fsplit_window): Remove. Windows are split in window.el.
8965 (save_restore_action, save_restore_orig_size)
8966 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8967 Resize mini windows in window.el.
8968 (grow_mini_window, shrink_mini_window): Implement by calling
8969 Qresize_root_window_vertically, resize_window_check and
8970 resize_window_apply.
8971 (saved_window, Fset_window_configuration, save_window_save):
8972 Do not handle orig_top_line, orig_total_lines, and
8973 resize_proportionally.
8974 (window_min_height, window_min_width): Move to window.el.
8975 (keys_of_window): Move bindings for delete-other-windows,
8976 split-window, delete-window and enlarge-window to window.el.
8978 * buffer.c: Temporarily extern Qdelete_window.
8979 (Fbury_buffer): Temporarily call Qdelete_window instead of
8980 Fdelete_window (Fbury_buffer will move to window.el soon).
8982 * frame.c (set_menu_bar_lines_1): Remove code handling
8983 orig_top_line and orig_total_lines.
8985 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8986 set_window_height but set heights directly.
8987 (change_frame_size_1): Use resize_frame_windows.
8989 * xdisp.c (init_xdisp): Don't use set_window_height but set
8992 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8993 Use resize_frame_windows instead of change_window_heights and run
8994 run_window_configuration_change_hook.
8996 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8997 instead of change_window_heights and run
8998 run_window_configuration_change_hook.
9000 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9002 * window.c (replace_window): Rename second argument REPLACEMENT to
9003 NEW. New third argument SETFLAG. Rewrite.
9004 (delete_window, make_dummy_parent): Call replace_window with
9006 (window_list_1): Move down in code.
9007 (run_window_configuration_change_hook): Move set_buffer part
9008 before select_frame_norecord part in order to unwind correctly.
9009 Rename count1 to count.
9010 (recombine_windows, delete_deletable_window, resize_root_window)
9011 (Fdelete_other_windows_internal)
9012 (Frun_window_configuration_change_hook, make_parent_window)
9013 (resize_window_check, resize_window_apply, Fresize_window_apply)
9014 (resize_frame_windows, Fsplit_window_internal)
9015 (Fdelete_window_internal, Fresize_mini_window_internal):
9017 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9019 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9021 * window.h (window): Add some new members to window structure -
9022 normal_lines, normal_cols, new_total, new_normal, clone_number,
9023 splits, nest, prev_buffers, next_buffers.
9024 (WINDOW_TOTAL_SIZE): Move here from window.c.
9025 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9027 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9029 (make_dummy_parent): Set new members of windows structure.
9030 (make_window): Move down in code. Handle new members of window
9032 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9033 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9034 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9035 (Fset_window_prev_buffers, Fwindow_next_buffers)
9036 (Fset_window_next_buffers, Fset_window_clone_number):
9038 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9039 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9041 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9042 Argument WINDOW can be now internal window too.
9043 (Fwindow_use_time): Move up in code.
9044 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9046 (Fset_window_configuration, saved_window)
9047 (Fcurrent_window_configuration, save_window_save): Handle new
9048 members of window structure.
9049 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9050 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9051 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9052 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9053 Qget_mru_window, Qresize_root_window,
9054 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9055 Qauto_buffer_name; staticpro them.
9057 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9059 * window.c (Fwindow_total_size, Fwindow_left_column)
9060 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9061 (Fwindow_list_1): New functions.
9062 (window_box_text_cols): Replace with window_body_cols.
9063 (Fwindow_width, Fscroll_left, Fscroll_right):
9064 Use window_body_cols instead of window_box_text_cols.
9065 (delete_window, Fset_window_configuration):
9066 Call delete_all_subwindows with window as argument.
9067 (delete_all_subwindows): Take a window as argument and not a
9069 (window_loop): Remove handling of GET_LRU_WINDOW and
9071 (Fget_lru_window, Fget_largest_window): Move to window.el.
9073 * window.h: Extern window_body_cols instead of
9074 window_box_text_cols. delete_all_subwindows now takes a
9075 Lisp_Object as argument.
9077 * indent.c (compute_motion, Fcompute_motion):
9078 Use window_body_cols instead of window_box_text_cols.
9080 * frame.c (delete_frame): Call delete_all_subwindows with root
9083 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9085 * fns.c (Fputhash): Document return value.
9087 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9089 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9091 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9093 Cons<->int and similar integer overflow fixes (Bug#8794).
9095 Check for overflow when converting integer to cons and back.
9096 * charset.c (Fdefine_charset_internal, Fdecode_char):
9097 Use cons_to_unsigned to catch overflow.
9098 (Fencode_char): Use INTEGER_TO_CONS.
9099 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9100 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9101 * data.c (long_to_cons, cons_to_long): Remove.
9102 (cons_to_unsigned, cons_to_signed): New functions.
9103 These signal an error for invalid or out-of-range values.
9104 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9105 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9106 * font.c (Ffont_variation_glyphs):
9107 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9108 * lisp.h: Include <intprops.h>.
9109 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9110 (cons_to_signed, cons_to_unsigned): New decls.
9111 (long_to_cons, cons_to_long): Remove decls.
9112 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9113 (Fprimitive_undo): Use CONS_TO_INTEGER.
9114 * xfns.c (Fx_window_property): Likewise.
9115 * xselect.c: Include <limits.h>.
9116 (x_own_selection, selection_data_to_lisp_data):
9117 Use INTEGER_TO_CONS.
9118 (x_handle_selection_request, x_handle_selection_clear)
9119 (x_get_foreign_selection, Fx_disown_selection_internal)
9120 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9121 (lisp_data_to_selection_data): Use cons_to_unsigned.
9122 (x_fill_property_data): Use cons_to_signed.
9123 Report values out of range.
9125 Check for buffer and string overflow more precisely.
9126 * buffer.h (BUF_BYTES_MAX): New macro.
9127 * lisp.h (STRING_BYTES_MAX): New macro.
9128 * alloc.c (Fmake_string):
9129 * character.c (string_escape_byte8):
9130 * coding.c (coding_alloc_by_realloc):
9131 * doprnt.c (doprnt):
9132 * editfns.c (Fformat):
9134 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9135 since they may not be the same number.
9136 * editfns.c (Finsert_char):
9137 * fileio.c (Finsert_file_contents):
9138 Likewise for BUF_BYTES_MAX.
9140 * image.c: Use ptrdiff_t, not int, for sizes.
9141 (slurp_file): Switch from int to ptrdiff_t.
9143 (slurp_file): Check that file size fits in both size_t (for
9144 malloc) and ptrdiff_t (for sanity and safety).
9146 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9147 if b->modtime has its maximal value.
9149 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9151 Don't assume time_t can fit into int.
9152 * buffer.h (struct buffer.modtime): Now time_t, not int.
9153 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9154 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9156 Minor fixes for signed vs unsigned integers.
9157 * character.h (MAYBE_UNIFY_CHAR):
9158 * charset.c (maybe_unify_char):
9159 * keyboard.c (read_char, reorder_modifiers):
9160 XINT -> XFASTINT, since the integer must be nonnegative.
9161 * ftfont.c (ftfont_spec_pattern):
9162 * keymap.c (access_keymap, silly_event_symbol_error):
9163 XUINT -> XFASTINT, since the integer must be nonnegative.
9164 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9165 since it makes no difference and we prefer signed.
9166 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9167 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9170 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9172 * window.h (Fwindow_frame): Declare.
9174 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9176 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9177 (SPARE_MEMORY): Always define.
9178 (LARGE_REQUEST): Remove.
9179 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9181 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9183 * lisp.h: Move EXFUNS for Fframe_root_window,
9184 Fframe_first_window and Fset_frame_selected_window to window.h.
9186 * window.h: Move EXFUNS for Fframe_root_window,
9187 Fframe_first_window and Fset_frame_selected_window here from
9190 * frame.c (Fwindow_frame, Fframe_first_window)
9191 (Fframe_root_window, Fframe_selected_window)
9192 (Fset_frame_selected_window): Move to window.c.
9193 (Factive_minibuffer_window): Move to minibuf.c.
9194 (Fother_visible_frames_p): New function.
9196 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9198 * window.c (decode_window, decode_any_window): Move up in code.
9199 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9200 (inhibit_frame_unsplittable): Remove unused variable.
9201 (Fwindow_buffer): Move up and rewrite doc-string.
9202 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9203 (Fwindow_prev): New functions.
9204 (Fwindow_frame): Move here from frame.c. Accept any window as
9206 (Fframe_root_window, Fframe_first_window)
9207 (Fframe_selected_window): Move here from frame.c. Accept frame
9208 or arbitrary window as argument. Update doc-strings.
9209 (Fminibuffer_window): Move up in code.
9210 (Fwindow_minibuffer_p): Move up in code and simplify.
9211 (Fset_frame_selected_window): Move here from frame.c.
9213 (Fselected_window, select_window, Fselect_window): Move up in
9214 code. Minor doc-string fixes.
9216 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9218 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9219 Do not assume that spare memory exists; that assumption is valid
9220 only if SYSTEM_MALLOC.
9221 (LARGE_REQUEST): New macro, so that the issue of large requests
9222 is separated from the issue of spare memory.
9224 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9226 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9229 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9231 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9234 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9236 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9238 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9240 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9241 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9243 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9245 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9247 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9249 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9250 (x_clipboard_manager_save): Add return value.
9251 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9253 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9254 Obey Vx_select_enable_clipboard_manager. Catch errors in
9255 x_clipboard_manager_save (Bug#8779).
9256 (Vx_select_enable_clipboard_manager): New variable.
9257 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9259 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9261 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9263 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9265 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9266 in the current matrix if keep_current_p is non-zero.
9268 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9270 * bidi.c (bidi_level_of_next_char): Fix last change.
9272 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9274 Support bidi reordering of text covered by display properties.
9276 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9277 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9278 (bidi_cache_search, bidi_cache_iterator_state)
9279 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9280 (bidi_level_of_next_char, bidi_move_to_visually_next):
9281 Support character positions inside a run of characters covered by a
9283 (bidi_paragraph_init, bidi_resolve_explicit_1)
9284 (bidi_level_of_next_char): Call bidi_fetch_char and
9285 bidi_fetch_char_advance instead of FETCH_CHAR and
9287 (bidi_init_it): Initialize new members.
9288 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9290 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9291 instead of using explicit *_CHAR codes.
9292 (bidi_resolve_explicit, bidi_resolve_weak):
9293 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9294 bidirectional text is supported only in multibyte buffers.
9295 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9296 it to initialize the frame_window_p member of struct bidi_it.
9297 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9298 (bidi_resolve_explicit, bidi_resolve_weak)
9299 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9300 bidi_it->nchars is non-positive.
9301 (bidi_level_of_next_char): Don't try to lookup the cache for the
9302 next/previous character if nothing is cached there yet, or if we
9303 were just reseat()'ed to a new position.
9305 * xdisp.c (set_cursor_from_row): Set start and stop points
9306 according to the row's direction when priming the loop that looks
9307 for the glyph on which to display cursor.
9308 (single_display_spec_intangible_p): Function deleted.
9309 (display_prop_intangible_p): Reimplement to call
9310 handle_display_spec instead of single_display_spec_intangible_p.
9311 Accept 3 additional arguments needed by handle_display_spec.
9312 This fixes incorrect cursor motion across display property with complex
9313 values: lists, `(when COND...)' forms, etc.
9314 (single_display_spec_string_p): Support property values that are
9315 lists with the argument STRING its top-level element.
9316 (display_prop_string_p): Fix the condition for processing a
9317 property that is a list to be consistent with handle_display_spec.
9318 (handle_display_spec): New function, refactored from the
9319 last portion of handle_display_prop.
9320 (compute_display_string_pos): Accept additional argument
9321 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9322 value of a `display' property is a "replacing spec".
9323 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9324 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9325 the display property, but just return a value indicating whether
9326 the display property will replace the characters it covers.
9327 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9328 frame_window_p members of struct bidi_it.
9329 (compute_display_string_pos, compute_display_string_end):
9331 (push_it): Accept second argument POSITION, where pop_it should
9332 jump to continue iteration.
9333 (reseat_1): Initialize bidi_it.disp_pos.
9335 * keyboard.c (adjust_point_for_property): Adjust the call to
9336 display_prop_intangible_p to its new signature.
9338 * dispextern.h (struct bidi_it): New member frame_window_p.
9339 (bidi_init_it): Update prototypes.
9340 (display_prop_intangible_p): Update prototype.
9341 (compute_display_string_pos, compute_display_string_end):
9343 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9346 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9348 Malloc failure behavior now depends on size of allocation.
9349 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9350 * lisp.h: Change signatures accordingly.
9351 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9352 All callers changed. (Bug#8762)
9354 * gnutls.c: Use Emacs's memory allocators.
9355 Without this change, the gnutls library would invoke malloc etc.
9356 directly, which causes problems on non-SYNC_INPUT hosts, and which
9357 runs afoul of improving memory_full behavior. (Bug#8761)
9358 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9359 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9360 xfree instead of the default malloc, realloc, free.
9361 (Fgnutls_boot): No need to check for memory allocation failure,
9362 since xmalloc does that for us.
9364 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9365 * category.c (hash_get_category_set):
9366 * ccl.c (ccl_driver):
9367 * charset.c (Fdefine_charset_internal):
9368 * charset.h (struct charset.hash_index):
9369 * composite.c (get_composition_id, gstring_lookup_cache)
9370 (composition_gstring_put_cache):
9371 * composite.h (struct composition.hash_index):
9372 * dispextern.h (struct image.hash):
9373 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9374 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9375 (hashfn_equal, hashfn_user_defined, make_hash_table)
9376 (maybe_resize_hash_table, hash_lookup, hash_put)
9377 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9378 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9379 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9380 * image.c (make_image, search_image_cache, lookup_image)
9381 (xpm_put_color_table_h):
9382 * lisp.h (struct Lisp_Hash_Table):
9383 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9384 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9385 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9386 * alloc.c (allocate_vectorlike):
9387 Check for overflow in vector size calculations.
9388 * ccl.c (ccl_driver):
9389 Check for overflow when converting EMACS_INT to int.
9390 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9391 need to be updated by these changes.
9392 * fns.c (make_hash_table, maybe_resize_hash_table):
9393 Check for integer overflow with large hash tables.
9394 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9395 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9396 (SXHASH_REDUCE): New macro.
9397 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9398 Use it instead of discarding useful hash info with large hash values.
9399 (sxhash_float): New function.
9400 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9401 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9402 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9403 Rewrite to use FIXNUM_BITS, as this simplifies things.
9404 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9405 Adjust signatures to match updated version of code.
9406 (consing_since_gc): Now EMACS_INT, since a single hash table can
9407 use more than INT_MAX bytes.
9409 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9411 Make it possible to build with GCC-4.6+ -O2 -flto.
9413 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9415 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9417 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9418 Call minibuffer-inactive-mode.
9420 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9422 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9423 Update dependencies.
9425 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9427 * data.c (init_data): Remove code for UTS, this system is not
9430 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9432 Don't force ./temacs to start in terminal mode.
9434 * frame.c (make_initial_frame): Initialize faces in all cases, not
9435 only when CANNOT_DUMP is defined.
9436 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9438 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9440 * dispnew.c (add_window_display_history): Use const for the string
9441 pointer. Remove declaration, not needed.
9443 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9445 Use 'inline', not 'INLINE'.
9446 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9447 * alloc.c, fontset.c (INLINE): Remove.
9448 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9449 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9450 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9451 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9452 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9454 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9456 Make it possible to run ./temacs.
9458 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9459 syms_of_callproc does the same thing. Remove test for
9460 "initialized", do it in the caller.
9461 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9463 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9465 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9466 (read_minibuf): Use get_minibuffer.
9467 (syms_of_minibuf): Use DEFSYM.
9468 (Qmetadata): New var.
9469 * data.c (Qbuffer): Don't make it static.
9470 (syms_of_data): Use DEFSYM.
9472 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9474 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9475 (CCL_CODE_MIN): New macro.
9477 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9479 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9481 * eval.c (Qdebug): Now static.
9482 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9483 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9484 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9486 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9488 * image.c: Various fixes to ImageMagick code comments.
9489 (Fimagemagick_types): Doc fix.
9491 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9493 Minor fixes prompted by GCC 4.6.0 warnings.
9495 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9497 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9498 (x_clipboard_manager_save_all): Move extern decl to ...
9499 * xterm.h: ... here, so that it can be checked for consistency.
9501 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9503 * xselect.c (x_clipboard_manager_save_frame)
9504 (x_clipboard_manager_save_all): New functions.
9505 (Fx_clipboard_manager_save): Lisp function deleted.
9507 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9508 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9510 * xterm.h: Update prototype.
9512 2011-05-28 William Xu <william.xwl@gmail.com>
9514 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9517 2011-05-28 Jim Meyering <meyering@redhat.com>
9519 Avoid a sign-extension bug in crypto_hash_function.
9520 * fns.c (to_uchar): Define.
9521 (crypto_hash_function): Use it to convert some newly-signed
9522 variables to unsigned, to avoid sign-extension bugs. For example,
9523 without this change, (md5 "truc") would evaluate to
9524 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9525 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9526 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9528 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9530 Integer overflow fixes.
9532 * dbusbind.c: Serial number integer overflow fixes.
9533 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9534 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9535 to hold a serial number that is too large for a fixnum.
9536 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9537 Check for serial numbers out of range. Decode any serial number
9538 that was so large that it became a float. (Bug#8722)
9540 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9541 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9542 Use XFASTINT rather than XUINT when numbers are nonnegative.
9543 (xd_append_arg, Fdbus_method_return_internal):
9544 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9545 arguments, check that Lisp number is nonnegative, rather than
9546 silently wrapping negative numbers around. (Bug#8722)
9547 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9550 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9552 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9554 ccl: Add integer overflow checks.
9555 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9556 (IN_INT_RANGE): New macros.
9557 (ccl_driver): Use them to check for integer overflow when
9558 decoding a CCL program. Many of the new checks are whether XINT (x)
9559 fits in int; it doesn't always, on 64-bit hosts. The new version
9560 doesn't catch all possible integer overflows, but it's an
9561 improvement. (Bug#8719)
9563 * alloc.c (make_event_array): Use XINT, not XUINT.
9564 There's no need for unsigned here.
9566 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9567 This follows up to the 2011-05-06 change that substituted uintptr_t
9568 for EMACS_INT. This case wasn't caught back then.
9570 Rework Fformat to avoid integer overflow issues.
9571 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9572 now (part of C89). Include <verify.h>.
9573 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9574 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9575 (Fformat): Avoid the prepass trying to compute sizes; it was only
9576 approximate and thus did not catch overflow reliably. Instead, walk
9577 through the format just once, formatting and computing sizes as we go,
9578 checking for integer overflow at every step, and allocating a larger
9579 buffer as needed. Keep track separately whether the format is
9580 multibyte. Keep only the most-recently calculated precision, rather
9581 than them all. Record whether each argument has been converted to
9582 string. Use EMACS_INT, not int, for byte and char and arg counts.
9583 Support field widths and precisions larger than INT_MAX. Avoid
9584 sprintf's undefined behavior with conversion specifications such as %#d
9585 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9586 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9587 formatting out-of-range floating point numbers with int
9590 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9592 * data.c: Avoid integer truncation in expressions involving floats.
9593 * data.c: Include <intprops.h>.
9594 (arith_driver): When there's an integer overflow in an expression
9595 involving floating point, convert the integers to floating point
9596 so that the resulting value does not suffer from catastrophic
9597 integer truncation. For example, on a 64-bit host (* 4
9598 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9599 Do not rely on undefined behavior after integer overflow.
9601 merge count_size_as_multibyte, parse_str_to_multibyte
9602 * character.c, character.h (count_size_as_multibyte):
9603 Rename from parse_str_to_multibyte; all uses changed.
9604 Check for integer overflow.
9605 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9606 since it's now a duplicate of the other. This is more of
9607 a character than a buffer op, so better that it's in character.c.
9608 * fns.c, print.c: Adjust to above changes.
9610 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9612 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9614 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9616 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9617 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9618 (x_clipboard_manager_save): Now static.
9619 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9621 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9622 (crypto_hash_function): Now static.
9623 Fix pointer signedness problems. Avoid unnecessary initializations.
9625 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9627 * termhooks.h (Vselection_alist): Make it terminal-local.
9629 * terminal.c (create_terminal): Initialize it.
9631 * xselect.c: Support for clipboard managers.
9632 (Vselection_alist): Move to termhooks.h as terminal-local var.
9633 (LOCAL_SELECTION): New macro.
9634 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9635 (symbol_to_x_atom): Remove gratuitous arg.
9636 (x_handle_selection_request, lisp_data_to_selection_data)
9637 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9638 (x_own_selection, x_get_local_selection, x_convert_selection):
9639 New arg, specifying work frame. Use terminal-local Vselection_alist.
9640 (some_frame_on_display): Delete unused function.
9641 (Fx_own_selection_internal, Fx_get_selection_internal)
9642 (Fx_disown_selection_internal, Fx_selection_owner_p)
9643 (Fx_selection_exists_p): New optional frame arg.
9644 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9645 (x_handle_selection_clear): Don't treat other terminals with the
9646 same keyboard specially. Use the terminal-local Vselection_alist.
9647 (x_clear_frame_selections): Use Frun_hook_with_args.
9649 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9651 * xterm.h: Add support for those atoms.
9653 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9655 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9656 (converted_selections, conversion_fail_tag): New global variables.
9657 (x_selection_request_lisp_error): Free the above.
9658 (x_get_local_selection): Remove unnecessary code.
9659 (x_reply_selection_request): Args changed; handle arbitrary array
9660 of converted selections stored in converted_selections.
9661 Separate the XChangeProperty and SelectionNotify steps.
9662 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9663 (x_convert_selection): New function.
9664 (x_handle_selection_event): Simplify.
9665 (x_get_foreign_selection): Don't ignore incoming requests while
9666 waiting for an answer; this will fail when we implement
9667 SAVE_TARGETS, and seems unnecessary anyway.
9668 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9669 (Vx_sent_selection_functions): Doc fix.
9671 2011-05-26 Leo Liu <sdl.web@gmail.com>
9673 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9675 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9677 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9679 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9680 for fringe update if it has periodic bitmap.
9681 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9682 and fringe_bitmap_periodic_p.
9684 * fringe.c (get_fringe_bitmap_data): New function.
9685 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9686 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9687 row. Mark glyph row for fringe update if periodicity changed.
9689 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9690 for fringe update unless it has periodic bitmap.
9692 2011-05-25 Kenichi Handa <handa@m17n.org>
9694 * xdisp.c (get_next_display_element): Set correct it->face_id for
9695 a static composition.
9697 2011-05-24 Leo Liu <sdl.web@gmail.com>
9700 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9702 * fns.c (crypto_hash_function, Fsha1): New function.
9703 (Fmd5): Use crypto_hash_function.
9704 (syms_of_fns): Add Ssha1.
9706 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9708 * gnutls.c: Remove unused macros.
9709 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9710 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9711 Remove macros that are defined and never used.
9712 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9714 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9716 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9717 (Fx_get_selection_internal): Minor cleanup.
9718 (Fx_own_selection_internal): Rename arguments for consistency with
9721 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9723 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9725 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9727 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9729 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9731 * dispnew.c (scrolling_window): Don't exclude the case that the
9732 last enabled row in the desired matrix touches the bottom boundary.
9734 2011-05-21 Glenn Morris <rgm@gnu.org>
9736 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9737 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9738 and add some more files.
9740 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9742 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9743 report_file_error introduced by the change from 2011-05-07.
9745 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9747 * systime.h (Time): Define only if emacs is defined.
9748 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9749 where the include path doesn't have X11/X.h by default. See
9750 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9752 2011-05-20 Kenichi Handa <handa@m17n.org>
9754 * composite.c (find_automatic_composition): Fix previous change.
9756 2011-05-20 Glenn Morris <rgm@gnu.org>
9758 * lisp.mk: New file, split from Makefile.in.
9759 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9760 (shortlisp): Remove.
9761 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9763 2011-05-19 Glenn Morris <rgm@gnu.org>
9765 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9766 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9767 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9768 (lisp): Set the order to that of loadup.el.
9769 (shortlisp): Make it a copy of $lisp.
9770 (SOME_MACHINE_LISP): Remove.
9771 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9772 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9774 2011-05-18 Kenichi Handa <handa@m17n.org>
9776 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9777 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9778 (find_automatic_composition): Mostly rewrite for efficiency.
9780 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9782 * makefile.w32-in: Update dependencies.
9784 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9786 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9787 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9789 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9791 Fix some integer overflow issues, such as string length overflow.
9793 * insdel.c (count_size_as_multibyte): Check for string overflow.
9795 * character.c (lisp_string_width): Check for string overflow.
9796 Use EMACS_INT, not int, for string indexes and lengths; in
9797 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9798 the resulting string length overflows an EMACS_INT; instead,
9799 report a string overflow if no precision given. When checking for
9800 precision exhaustion, use a check that cannot possibly have
9801 integer overflow. (Bug#8675)
9802 * character.h (lisp_string_width): Adjust to new signature.
9804 * alloc.c (string_overflow): New function.
9805 (Fmake_string): Use it. This doesn't change behavior, but saves
9806 a few bytes and will simplify future changes.
9807 * character.c (string_escape_byte8): Likewise.
9808 * lisp.h (string_overflow): New decl.
9810 Fixups, following up to the user-interface timestamp change.
9811 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9812 for UI timestamps, instead of unsigned long.
9813 * msdos.c (mouse_get_pos): Likewise.
9814 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9815 * w32gui.h (Time): Define by including "systime.h" rather than by
9816 declaring it ourselves. (Bug#8664)
9818 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9819 * image.c (clear_image_cache): Likewise.
9821 * term.c (term_mouse_position): Don't assume time_t wraparound.
9823 Be more systematic about user-interface timestamps.
9824 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9825 and sometimes 'EMACS_UINT', to represent these timestamps.
9826 This change causes it to use 'Time' uniformly, as that's what X uses.
9827 This makes the code easier to follow, and makes it easier to catch
9828 integer overflow bugs such as Bug#8664.
9829 * frame.c (Fmouse_position, Fmouse_pixel_position):
9830 Use Time, not unsigned long, for user-interface timestamps.
9831 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9832 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9833 * keyboard.h (last_event_timestamp): Likewise.
9834 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9835 * menu.h (xmenu_show): Likewise.
9836 * term.c (term_mouse_position): Likewise.
9837 * termhooks.h (struct input_event.timestamp): Likewise.
9838 (struct terminal.mouse_position_hook): Likewise.
9839 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9840 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9841 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9842 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9844 * menu.h, termhooks.h: Include "systime.h", for Time.
9846 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9847 Don't assume that the difference between two unsigned long values
9848 can fit into an integer. At this point, we know button_down_time
9849 <= event->timestamp, so the difference must be nonnegative, so
9850 there's no need to cast the result if double-click-time is
9851 nonnegative, as it should be; check that it's nonnegative, just in
9852 case. This bug is triggered when events are more than 2**31 ms
9853 apart (about 25 days). (Bug#8664)
9855 * xselect.c (last_event_timestamp): Remove duplicate decl.
9856 (x_own_selection): Remove needless cast to unsigned long.
9858 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9859 that always fit in int. Use a sentinel instead of a counter, to
9860 avoid a temp and to allay GCC's concerns about possible int overflow.
9861 * frame.h (struct frame): Use int for menu_bar_items_used
9862 instead of EMACS_INT, since it always fits in int.
9864 * menu.c (grow_menu_items): Check for int overflow.
9866 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9868 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9869 Before, the code was not consistent. These values cannot exceed
9870 2**31 - 1 so there's no need to make them unsigned.
9871 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9872 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9873 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9875 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9877 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9878 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9879 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9880 presumably because the widths might not match.
9882 * window.c (size_window): Avoid needless test at loop start.
9884 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9886 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9888 2011-05-12 Drew Adams <drew.adams@oracle.com>
9890 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9892 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9894 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9895 `width' to `bar_area_x' and `bar_area_width', respectively.
9896 (x_scroll_run): Take account of fringe background extension.
9898 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9899 Rename local vars `left' and `width' to `bar_area_x' and
9900 `bar_area_width', respectively.
9901 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9902 background extension.
9904 2011-05-10 Jim Meyering <meyering@redhat.com>
9906 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9908 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9910 * image.c (Finit_image_library): Return t for built-in image types,
9911 like pbm and xbm. (Bug#8640)
9913 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9915 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9917 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9919 * w32console.c (Fset_screen_color): Doc fix.
9920 (Fget_screen_color): New function.
9921 (syms_of_ntterm): Defsubr it.
9923 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9924 unlink the temporary file if Fcall_process didn't create it in the
9926 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9927 child process will be redirected to a file specified with `:file'.
9928 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9929 cue to call_process_cleanup not to close that handle.
9931 2011-05-07 Ben Key <bkey76@gmail.com>
9933 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9934 one of two shell specific rules, either bootstrap-temacs-CMD or
9935 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9936 to the previous implementation of the bootstrap-temacs rule.
9937 The bootstrap-temacs-CMD rule is similar to the previous
9938 implementation of the bootstrap-temacs rule except that it
9939 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9942 These changes, along with some changes to nt/configure.bat,
9943 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9944 earlier fix to add support for --cflags and --ldflags options
9945 that include quotes so that it works whether make uses cmd or
9948 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9950 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9951 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9953 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9954 a string. Handle both cases.
9955 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9956 (Fdbus_register_method): Use Qinvalid_function.
9958 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9960 * makefile.w32-in: Update dependencies.
9961 (LISP_H): Add inttypes.h and stdin.h.
9962 (PROCESS_H): Add unistd.h.
9964 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9966 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9967 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9969 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9971 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9973 * term.c (vfatal): Remove stray call to va_end.
9974 It's not needed and the C Standard doesn't allow it here anyway.
9976 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9977 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9979 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9982 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9984 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9986 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9988 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9990 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9992 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9993 * charset.c (Fdefine_charset_internal): Don't initialize
9994 charset.code_space[15]. The value was garbage, on hosts with
9995 32-bit int (Bug#8600).
9997 * lread.c (read_integer): Be more consistent with string-to-number.
9998 Use string_to_number to do the actual conversion; this avoids
9999 rounding errors and fixes some other screwups. Without this fix,
10000 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10001 (digit_to_number): Move earlier, for benefit of read_integer.
10002 Return -1 if the digit is out of range for the base, -2 if it is
10003 not a digit in any supported base. (Bug#8602)
10005 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10007 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10008 to match comment at start of function. This also removes a
10009 GCC warning about overflow in a 32+64-bit port.
10011 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10013 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10014 Reported by Stefan Monnier in
10015 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10016 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10017 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10019 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10020 (EMACS_UINTPTR): Likewise, with uintptr_t.
10022 * lisp.h: Prefer 64-bit EMACS_INT if available.
10023 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10024 on 32-bit hosts that have 64-bit int, so that they can access
10026 However, temporarily disable this change unless the temporary
10027 symbol WIDE_EMACS_INT is defined.
10029 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10031 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10032 This removes an assumption that EMACS_INT and long are the same
10033 width as pointers. The assumption is true for Emacs porting targets
10034 now, but we want to make other targets possible.
10035 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10036 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10037 In the rest of the code, change types of integers that hold casted
10038 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10039 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10040 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10041 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10042 No need to cast type when ORing.
10043 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10044 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10045 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10046 assume EMACS_INT is the same width as char *.
10047 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10048 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10049 Remove no-longer-needed casts.
10050 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10051 (xg_tool_bar_help_callback, xg_make_tool_item):
10052 Use EMACS_INTPTR to hold an integer
10053 that will be cast to void *; this can avoid a GCC warning
10054 if EMACS_INT is not the same width as void *.
10055 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10056 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10057 (current_message_1, set_message_1):
10058 Use a local to convert to proper width without a cast.
10059 * xmenu.c (dialog_selection_callback): Likewise.
10061 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10062 Also, don't assume VALBITS / RAND_BITS is less than 5,
10063 and don't rely on undefined behavior when shifting a 1 left into
10065 * lisp.h (get_random): Change signature to match.
10067 * lread.c (hash_string): Use size_t, not int, for hash computation.
10068 Normally we prefer signed values; but hashing is special, because
10069 it's better to use unsigned division on hash table sizes so that
10070 the remainder is nonnegative. Also, size_t is the natural width
10071 for hashing into memory. The previous code used 'int', which doesn't
10072 retain enough info to hash well into very large tables.
10073 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10075 * dbusbind.c: Don't possibly lose pointer info when converting.
10076 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10077 Use XPNTR rather than XHASH, so that the high-order bits of
10078 the pointer aren't lost when converting through void *.
10080 * eval.c (Fautoload): Don't double-shift a pointer.
10082 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10084 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10086 * gnutls.c (DEF_GNUTLS_FN):
10087 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10089 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10091 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10094 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10096 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10097 New version that can reserve upto 2GB of heap space.
10099 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10101 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10103 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10105 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10106 `gnutls_certificate_set_x509_key_file'.
10108 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10110 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10111 Update dependencies.
10113 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10115 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10116 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10117 Remove unused parameter `fildes'.
10118 * process.c (read_process_output, send_process): Don't pass it.
10120 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10122 Fix previous change: the library cache is defined in w32.c.
10123 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10124 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10126 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10128 Implement dynamic loading of GnuTLS on Windows.
10130 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10131 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10132 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10135 * gnutls.c (Qgnutls_dll): Define.
10136 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10137 (gnutls_*): Declare function pointers.
10138 (init_gnutls_functions): New function to initialize function pointers.
10139 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10140 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10141 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10142 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10143 (emacs_gnutls_write, emacs_gnutls_read)
10144 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10145 (Fgnutls_available_p): New function.
10146 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10147 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10148 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10150 * image.c: Include w32.h.
10151 (Vimage_type_cache): Delete.
10152 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10153 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10154 (w32_delayed_load): Move to w32.c.
10156 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10158 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10159 (w32_delayed_load): Move from image.c. When loading a library, record
10160 its filename in the :loaded-from property of the library id.
10161 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10162 Initialize and staticpro them.
10163 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10165 * process.c: Include lisp.h before w32.h, not after.
10166 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10167 instead of gnutls_record_check_pending.
10169 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10171 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10173 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10174 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10177 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10179 * xterm.c (x_set_frame_alpha): Do not set property on anything
10180 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10182 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10184 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10186 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10188 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10189 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10190 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10191 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10192 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10193 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10194 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10195 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10196 (Qgnutls_bootprop_callbacks_verify): Make static.
10198 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10200 * callproc.c: Indentation fixup.
10202 * sysdep.c (wait_for_termination_1): Make static.
10203 (wait_for_termination, interruptible_wait_for_termination):
10204 Move after wait_for_termination_1.
10206 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10208 * sysdep.c (interruptible_wait_for_termination): New function
10209 which is like wait_for_termination, but allows keyboard
10212 * callproc.c (Fcall_process): Add (:file "file") as an option for
10214 (Fcall_process_region): Ditto.
10216 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10218 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10219 rather than `XVECTOR (FOO)->size'.
10221 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10222 inttypes.h, as a gnulib replacement is used if it not available in
10225 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10227 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10228 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10229 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10231 * coding.c (coding_alloc_by_realloc): Error out if destination
10232 will grow beyond MOST_POSITIVE_FIXNUM.
10233 (decode_coding_emacs_mule): Abort if there isn't enough place in
10234 charbuf for the composition carryover bytes. Reserve an extra
10235 space for up to 2 characters produced in a loop.
10236 (decode_coding_iso_2022): Abort if there isn't enough place in
10237 charbuf for the composition carryover bytes.
10239 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10241 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10242 aborting when %lld or %lll format is passed.
10243 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10244 %llo or %llx format is passed. (Bug#8545)
10246 * window.c (window_scroll_line_based): Use a marker instead of
10247 simple variables to record original value of point. (Bug#7952)
10249 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10250 produced by %s or %c overflows available buffer space. (Bug#8545)
10252 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10254 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10255 (SIZE_MAX): Move defn after all includes, as they might #define it.
10257 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10259 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10261 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10263 * keyboard.c (Qdelayed_warnings_hook): Define.
10264 (command_loop_1): Run `delayed-warnings-hook'
10265 if Vdelayed_warnings_list is non-nil.
10266 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10267 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10269 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10271 * doprnt.c (doprnt): Don't return value smaller than the buffer
10272 size if the message was truncated. (Bug#8545).
10274 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10276 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10277 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10279 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10281 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10283 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10285 * makefile.w32-in: Update dependencies.
10287 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10289 Improve `doprnt' and its usage. (Bug#8545)
10290 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10291 `format_end'. Remove support for %l as a conversion specifier.
10292 Don't use xrealloc. Improve diagnostics when the %l size modifier
10293 is used. Update the commentary.
10295 * eval.c (verror): Simplify calculation of size_t.
10297 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10300 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10302 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10305 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10307 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10308 This makes this file independent of the recent pseudovector change.
10310 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10312 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10314 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10315 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10316 Remove unused local.
10317 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10319 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10320 GCC 4.6.0 optimizes based on type-based alias analysis.
10321 For example, if b is of type struct buffer * and v of type struct
10322 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10323 != &v->size, and therefore "v->size = 1; b->size = 2; return
10324 v->size;" must therefore return 1. This assumption is incorrect
10325 for Emacs, since it type-puns struct Lisp_Vector * with many other
10326 types. To fix this problem, this patch adds a new type struct
10327 vectorlike_header that documents the constraints on layout of vectors
10328 and pseudovectors, and helps optimizing compilers not get fooled
10329 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10330 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10331 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10333 (XSETPVECTYPE): Rewrite in terms of new macro.
10334 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10335 This is a bit clearer, and further avoids the possibility of
10336 undesirable aliasing.
10337 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10338 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10339 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10340 since Lisp_Subr is a special case (no "next" field).
10341 (ASIZE): Now uses header.size rather than size.
10342 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10343 to avoid the hassle of writing XVECTOR (foo)->header.size.
10344 (struct vectorlike_header): New type.
10345 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10346 object, to help avoid aliasing.
10347 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10348 (SUBRP): Likewise, since Lisp_Subr is a special case.
10349 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10350 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10351 (struct Lisp_Hash_Table): Combine first two members into a single
10352 struct vectorlike_header member. All uses of "size" and "next" members
10353 changed to be "header.size" and "header.next".
10354 * buffer.h (struct buffer): Likewise.
10355 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10356 * frame.h (struct frame): Likewise.
10357 * process.h (struct Lisp_Process): Likewise.
10358 * termhooks.h (struct terminal): Likewise.
10359 * window.c (struct save_window_data, struct saved_window): Likewise.
10360 * window.h (struct window): Likewise.
10361 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10362 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10363 * buffer.c (init_buffer_once): Likewise.
10364 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10366 * process.c (Fformat_network_address): Use local var for size,
10369 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10371 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10372 * data.c (atof): Remove decl; no longer used or needed.
10373 (digit_to_number): Move to lread.c.
10374 (Fstring_to_number): Use new string_to_number function, to be
10375 consistent with how the Lisp reader treats infinities and NaNs.
10376 Do not assume that floating-point numbers represent EMACS_INT
10377 without losing information; this is not true on most 64-bit hosts.
10378 Avoid double-rounding errors, by insisting on integers when
10379 parsing non-base-10 numbers, as the documentation specifies.
10380 * lisp.h (string_to_number): New decl, replacing ...
10381 (isfloat_string): Remove.
10382 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10383 (read1): Do not accept +. and -. as integers; this
10384 appears to have been a coding error. Similarly, do not accept
10385 strings like +-1e0 as floating point numbers. Do not report
10386 overflow for integer overflows unless the base is not 10 which
10387 means we have no simple and reliable way to continue.
10388 Break out the floating-point parsing into a new
10389 function string_to_number, so that Fstring_to_number parses
10390 floating point numbers consistently with the Lisp reader.
10391 (digit_to_number): Move here from data.c. Make it static inline.
10392 (E_CHAR, EXP_INT): Remove, replacing with ...
10393 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10394 (string_to_number): New function, replacing isfloat_string.
10395 This function checks for valid syntax and produces the resulting
10396 Lisp float number too. Rework it so that string-to-number
10397 no longer mishandles examples like "1.0e+". Use strtoumax,
10398 so that overflow for non-base-10 numbers is reported only when
10399 there's no portable and simple way to convert to floating point.
10401 * textprop.c (set_text_properties_1): Rewrite for clarity,
10402 and to avoid GCC warning about integer overflow.
10404 * intervals.h (struct interval): Use EMACS_INT for members
10405 where EMACS_UINT might cause problems. See
10406 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10407 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10408 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10410 (offset_intervals): Tell GCC not to worry about length overflow
10411 when negating a negative length.
10413 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10414 (overrun_check_free): Likewise.
10416 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10417 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10420 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10421 (gnutls_make_error): Rename local to avoid shadowing.
10422 (gnutls_emacs_global_deinit): ifdef out; not used.
10423 (Fgnutls_boot): Use const for pointer to readonly storage.
10424 Comment out unused local. Fix pointer signedness problems.
10426 * lread.c (openp): Don't stuff size_t into an 'int'.
10427 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10428 about possible signed overflow.
10430 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10431 (GDK_KEY_g): Don't define if already defined.
10432 (xg_prepare_tooltip): Avoid pointer signedness problem.
10433 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10435 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10436 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10438 * xfns.c (Fx_window_property): Simplify a bit,
10439 to make a bit faster and to avoid GCC 4.6.0 warning.
10440 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10442 * fns.c (internal_equal): Don't assume size_t fits in int.
10444 * alloc.c (compact_small_strings): Tighten assertion a little.
10446 Replace pEd with more-general pI, and fix some printf arg casts.
10447 * lisp.h (pI): New macro, generalizing old pEd macro to other
10448 conversion specifiers. For example, use "...%"pI"d..." rather
10449 than "...%"pEd"...".
10450 (pEd): Remove. All uses replaced with similar uses of pI.
10451 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10452 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10453 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10454 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10455 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10456 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10457 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10459 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10460 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10461 * print.c (safe_debug_print, print_object): Likewise.
10462 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10464 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10465 avoiding the 0 flag, which is not portable.
10466 * process.c (Fmake_network_process): Use pI to avoid cast.
10467 * region-cache.c (pp_cache): Likewise.
10468 * xdisp.c (decode_mode_spec): Likewise.
10469 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10470 behavior on 64-bit hosts with printf arg.
10471 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10472 (x_stop_queuing_selection_requests): Likewise.
10473 (x_get_window_property): Don't truncate byte count to an 'int'
10476 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10477 here, since it parses constructs like leading '-' and spaces,
10478 which are not wanted; and it overflows with large numbers.
10479 Instead, simply match F[0-9]+, which is what is wanted anyway.
10481 * alloc.c: Remove unportable assumptions about struct layout.
10482 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10483 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10484 (allocate_vectorlike, make_pure_vector): Use the new macros,
10485 plus offsetof, to remove unportable assumptions about struct layout.
10486 These assumptions hold on all porting targets that I know of, but
10487 they are not guaranteed, they're easy to remove, and removing them
10488 makes further changes easier.
10490 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10491 This doesn't fix a bug but makes the code clearer.
10492 (string_overrun_cookie): Now const. Use initializers that
10493 don't formally overflow signed char, to avoid warnings.
10494 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10495 can cause Emacs to crash when string overrun checking is enabled.
10496 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10497 multiple of sizeof (EMACS_INT); it need not be, if
10498 alignof(EMACS_INT) < sizeof (EMACS_INT).
10499 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10501 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10503 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10505 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10507 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10508 supposed to be handshaking. (Bug#8556)
10509 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10511 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10513 * lisp.h (Qdebug): List symbol.
10514 * eval.c (Qdebug): Restore global linkage.
10515 * keyboard.c (debug-on-event): New variable.
10516 (handle_user_signal): Break into debugger when debug-on-event
10517 matches the current signal symbol.
10519 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10521 * alloc.c (check_sblock, check_string_bytes)
10522 (check_string_free_list): Convert to standard C.
10524 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10526 * w32.c (emacs_gnutls_push): Fix typo.
10528 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10530 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10531 "cast to pointer from integer of different size".
10533 Improve doprnt and its use in verror. (Bug#8545)
10534 * doprnt.c (doprnt): Document the set of format control sequences
10535 supported by the function. Use SAFE_ALLOCA instead of always
10538 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10539 is one byte too soon. Don't use xrealloc; instead xfree and
10542 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10544 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10547 * gnutls.c: Renamed global_initialized to
10548 gnutls_global_initialized. Added internals for the
10549 :verify-hostname-error, :verify-error, and :verify-flags
10550 parameters of `gnutls-boot' and documented those parameters in the
10551 docstring. Start callback support.
10552 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10553 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10554 on error. Return error code.
10555 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10556 (emacs_gnutls_read): Likewise.
10557 (Fgnutls_boot): Return handshake error code.
10558 (emacs_gnutls_handle_error): New function.
10559 (wsaerror_to_errno): Likewise.
10561 * w32.h (emacs_gnutls_pull): Add prototype.
10562 (emacs_gnutls_push): Likewise.
10564 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10565 (emacs_gnutls_push): Likewise.
10567 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10569 * process.c (wait_reading_process_output): Check if GnuTLS
10570 buffered some data internally if no FDs are set for TLS
10573 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10574 (LIBS): Link to USER_LIBS.
10575 ($(BLD)/gnutls.$(0)): New target.
10577 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10579 * xdisp.c (handle_single_display_spec): Rename the
10580 display_replaced_before_p argument into display_replaced_p, to
10581 make it consistent with the commentary. Fix typos in the
10584 * textprop.c (syms_of_textprop): Remove dead code.
10585 (copy_text_properties): Delete obsolete commentary about an
10586 interface that was deleted long ago. Fix typos in the description
10589 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10590 to changes in oldXMenu/XMenu.h from 2011-04-16.
10591 <menu_help_message, prev_menu_help_message>: Constify.
10592 (IT_menu_make_room): menu->help_text is now `const char **';
10595 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10596 to changes in oldXMenu/XMenu.h from 2011-04-16.
10597 (struct XMenu): Declare `help_text' `const char **'.
10599 * xfaces.c <Qunspecified>: Make extern again.
10601 * syntax.c: Include sys/types.h before including regex.h, as
10604 * doc.c (get_doc_string): Improve the format passed to `error'.
10606 * doprnt.c (doprnt): Improve commentary.
10608 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10610 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10613 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10614 changes in globals.h immediately force recompilation.
10615 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10616 $(CURDIR)/s/ms-w32.h.
10617 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10619 * character.c (Fchar_direction): Function deleted.
10620 (syms_of_character): Don't defsubr it.
10621 <char-direction-table>: Deleted.
10623 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10625 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10626 * doprnt.c: Include limits.h.
10627 (SIZE_MAX): New macro.
10628 (doprnt): Return a size_t value. 2nd arg is now size_t.
10629 Many local variables are now size_t instead of int or unsigned.
10630 Improve overflow protection. Support `l' modifier for integer
10631 conversions. Support %l conversion. Don't assume an EMACS_INT
10632 argument for integer conversions and for %c.
10634 * lisp.h (doprnt): Restore prototype.
10636 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10637 $(SRC)/character.h.
10639 * Makefile.in (base_obj): Add back doprnt.o.
10641 * deps.mk (doprnt.o): Add back prerequisites.
10642 (callint.o): Depend on character.h.
10644 * eval.c (internal_lisp_condition_case): Include the handler
10645 representation in the error message.
10646 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10647 when breaking from the loop.
10649 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10651 * callint.c (Fcall_interactively): When displaying error message
10652 about invalid control letter, pass the character's codepoint, not
10653 a pointer to its multibyte form. Improve display of the character
10654 in octal and display also its hex code.
10656 * character.c (char_string): Use %x to display the (unsigned)
10657 codepoint of an invalid character, to avoid displaying a bogus
10660 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10661 `error', not SYMBOL_NAME itself.
10663 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10664 character arguments to `error'.
10666 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10667 to `error' in error message about FINAL_CHAR argument. Make sure
10668 FINAL_CHAR is a character, and use %c when it is passed as
10669 argument to `error'.
10671 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10673 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10675 * w32.c: Include <time.h>.
10676 (sys_localtime): New function.
10678 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10680 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10682 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10684 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10686 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10687 zombies (Bug#8467).
10689 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10691 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10692 gl_state.e_property when gl_state.object is Qt.
10694 * insdel.c (make_gap_larger): Remove limitation of buffer size
10697 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10699 * xdisp.c (lookup_glyphless_char_display)
10700 (produce_glyphless_glyph): Handle cons cell entry in
10701 glyphless-char-display.
10702 (Vglyphless_char_display): Document it.
10704 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10705 glyphless-char-display.
10707 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10709 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10711 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10713 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10714 definition for no-X builds.
10716 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10718 Static checks with GCC 4.6.0 and non-default toolkits.
10720 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10722 * process.c (keyboard_bit_set): Define only if SIGIO.
10723 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10724 (send_process): Repair possible setjmp clobbering.
10726 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10728 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10730 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10732 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10733 Define only if needed.
10735 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10736 by pacifying GCC about it. Maybe it's time to retire it?
10737 * xfaces.c (USG, __TIMEVAL__): Likewise.
10739 * dispextern.h (struct redisplay_interface): Rename param
10740 to avoid shadowing.
10741 * termhooks.h (struct terminal): Likewise.
10742 * xterm.c (xembed_send_message): Likewise.
10744 * insdel.c (make_gap_smaller): Define only if
10745 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10747 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10750 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10751 so that we aren't warned about unused symbols.
10753 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10755 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10757 * xfns.c (x_real_positions): Mark locals as initialized.
10759 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10761 * xterm.c: Fix problems found by static analysis with other toolkits.
10762 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10763 (x_dispatch_event): Declare static if USE_GTK, and
10764 define if USE_GTK || USE_X_TOOLKIT.
10765 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10766 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10767 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10768 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10770 * xmenu.c (menu_help_callback): Pointer type fixes.
10771 Use const pointers when pointing at readonly data. Avoid pointer
10772 signedness clashes.
10773 (FALSE): Remove unused macro.
10774 (update_frame_menubar): Remove unused decl.
10776 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10778 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10779 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10780 (single_menu_item): Rename local to avoid shadowing.
10782 * keyboard.c (make_lispy_event): Remove unused local var.
10784 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10785 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10787 * bitmaps: Change bitmaps from unsigned char back to the X11
10788 compatible char. Avoid the old compiler warnings about
10789 out-of-range initializers by using, for example, '\xab' rather
10792 * xgselect.c (xgselect_initialize): Check vs interface
10793 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10795 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10797 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10798 to read-only memory.
10800 * fns.c (vector): Remove; this old hack is no longer needed.
10802 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10804 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10806 * xrdb.c (x_load_resources): Omit unused local.
10808 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10809 (x_window): Rename locals to avoid shadowing.
10810 (USG): Use the kludged USG macro, to pacify gcc.
10812 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10813 (x_term_init): Remove local to avoid shadowing.
10815 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10817 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10818 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10820 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10822 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10824 Fix regex.c, syntax.c and friends for buffers > 2GB.
10825 * syntax.h (struct gl_state_s): Declare character position members
10828 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10830 * textprop.c (verify_interval_modification, interval_of):
10831 Declare arguments EMACS_INT.
10833 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10836 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10838 * indent.c (Fvertical_motion): Local variable it_start is now
10841 * regex.c (re_match, re_match_2, re_match_2_internal)
10842 (bcmp_translate, regcomp, regexec, print_double_string)
10843 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10844 (re_compile_pattern, re_exec): Declare arguments and local
10845 variables `size_t' and `ssize_t' and return values `regoff_t', as
10847 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10848 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10849 <compile_stack_type>: `size' and `avail' are now `size_t'.
10851 * regex.h <regoff_t>: Use ssize_t, not int.
10852 (re_search, re_search_2, re_match, re_match_2): Arguments that
10853 specify buffer/string position and length are now ssize_t and
10854 size_t. Return type is regoff_t.
10856 2011-04-16 Ben Key <bkey76@gmail.com>
10858 * nsfont.m: Fixed bugs in ns_get_family and
10859 ns_descriptor_to_entity that were caused by using free to
10860 deallocate memory blocks that were allocated by xmalloc (via
10861 xstrdup). This caused Emacs to crash when compiled with
10862 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10863 --enable-checking=xmallocoverrun). xfree is now used to
10864 deallocate these memory blocks.
10866 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10868 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10870 emacs_write: Accept and return EMACS_INT for sizes.
10871 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10873 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10874 Accept and return EMACS_INT.
10875 (emacs_gnutls_write): Return the number of bytes written on
10877 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10878 (emacs_read, emacs_write): Remove check for negative size, as the
10879 Emacs source code has been audited now.
10880 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10881 (emacs_read, emacs_write): Use it.
10882 * process.c (send_process): Adjust to the new signatures of
10883 emacs_write and emacs_gnutls_write. Do not attempt to store
10884 a byte offset into an 'int'; it might overflow.
10885 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10887 * sound.c: Don't assume sizes fit in 'int'.
10888 (struct sound_device.period_size, alsa_period_size):
10889 Return EMACS_INT, not int.
10890 (struct sound_device.write, vox_write, alsa_write):
10891 Accept EMACS_INT, not int.
10892 (wav_play, au_play): Use EMACS_INT to store sizes and to
10893 record read return values.
10895 2011-04-15 Ben Key <bkey76@gmail.com>
10897 * keyboard.c (Qundefined): Don't declare static since it is used
10899 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10900 static since they are used in nsfont.m.
10902 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10904 * process.c (Qprocessp): Don't declare static.
10905 * lisp.h (Qprocessp): Declare again.
10907 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10909 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10911 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10913 Improve C-level modularity by making more things 'static'.
10915 Don't publish debugger-only interfaces to other modules.
10916 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10917 (verify_bytepos, count_markers): Move decls to the only modules
10919 * region-cache.h (pp_cache): Likewise.
10920 * window.h (check_all_windows): Likewise.
10921 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10923 * sysdep.c (croak): Now static, if
10924 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10925 * syssignal.h (croak): Declare only if not static.
10927 * alloc.c (refill_memory_reserve): Now static if
10928 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10929 * lisp.h (refill_memory_reserve): Declare only if not static.
10931 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10932 Define only if USE_LUCID.
10934 * xrdb.c (x_customization_string, x_rm_string): Now static.
10936 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10937 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10939 * xdisp.c (draw_row_with_mouse_face): Now static.
10940 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10942 * window.h (check_all_windows): Mark externally visible.
10944 * window.c (window_deletion_count): Now static.
10946 * undo.c: Make symbols static if they're not exported.
10947 (last_undo_buffer, last_boundary_position, pending_boundary):
10950 * textprop.c (interval_insert_behind_hooks): Now static.
10951 (interval_insert_in_front_hooks): Likewise.
10953 * term.c: Make symbols static if they're not exported.
10954 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10955 (max_frame_lines, tty_set_terminal_modes):
10956 (tty_reset_terminal_modes, tty_turn_off_highlight):
10957 (get_tty_terminal): Now static.
10958 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10959 * termhooks.h (term_mouse_moveto): Do not declare if
10960 HAVE_WINDOW_SYSTEM.
10961 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10962 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10964 * sysdep.c: Make symbols static if they're not exported.
10965 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10967 (sigprocmask_set, full_mask): Remove; unused.
10968 (wait_debugging): Mark as visible.
10969 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10970 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10972 * syntax.c (syntax_temp): Define only if !__GNUC__.
10974 * sound.c (current_sound_device, current_sound): Now static.
10976 * search.c (searchbufs, searchbuf_head): Now static.
10978 * scroll.c (scroll_cost): Remove; unused.
10979 * dispextern.h (scroll_cost): Remove decl.
10981 * region-cache.h (pp_cache): Mark as externally visible.
10983 * process.c: Make symbols static if they're not exported.
10984 (process_tick, update_tick, create_process, chan_process):
10985 (Vprocess_alist, proc_buffered_char, datagram_access):
10986 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10987 (deactivate_process): Mark defn as static, as well as decl.
10988 * lisp.h (create_process): Remove decl.
10989 * process.h (chan_process, Vprocess_alist): Remove decls.
10991 * print.c: Make symbols static if they're not exported.
10992 (print_depth, new_backquote_output, being_printed, print_buffer):
10993 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10994 (print_interval, print_number_index, initial_stderr_stream):
10996 * lisp.h (Fprinc): Remove decl.
10997 (debug_output_compilation_hack): Mark as externally visible.
10999 * sysdep.c (croak): Move decl from here to syssignal.h.
11000 * syssignal.h (croak): Put it here, so the API can be checked when
11001 'croak' is called from dissociate_if_controlling_tty.
11003 * minibuf.c: Make symbols static if they're not exported.
11004 (minibuf_save_list, choose_minibuf_frame): Now static.
11005 * lisp.h (choose_minibuf_frame): Remove decl.
11007 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11009 * lread.c: Make symbols static if they're not exported.
11010 (read_objects, initial_obarray, oblookup_last_bucket_number):
11012 (make_symbol): Remove; unused.
11013 * lisp.h (initial_obarray, make_symbol): Remove decls.
11015 * keyboard.c: Make symbols static if they're not exported.
11016 (single_kboard, recent_keys_index, total_keys, recent_keys):
11017 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11018 (this_single_command_key_start, echoing, last_auto_save):
11019 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11020 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11021 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11022 (Vlispy_mouse_stem, double_click_count):
11024 (force_auto_save_soon): Define only if SIGDANGER.
11025 (ignore_mouse_drag_p): Now static if
11026 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11027 (print_help): Remove; unused.
11028 (stop_character, last_timer_event): Mark as externally visible.
11029 * keyboard.h (ignore_mouse_drag_p): Declare only if
11030 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11031 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11032 * lisp.h (echoing): Remove decl.
11033 (force_auto_save_soon): Declare only if SIGDANGER.
11034 * xdisp.c (redisplay_window): Simplify code, to make it more
11035 obvious that ignore_mouse_drag_p is not accessed if !defined
11036 USE_GTK && !defined HAVE_NS.
11038 * intervals.c: Make symbols static if they're not exported.
11039 (merge_properties_sticky, merge_interval_right, delete_interval):
11041 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11043 * insdel.c: Make symbols static if they're not exported.
11044 However, leave prepare_to_modify_buffer alone. It's never
11045 called from outside this function, but that appears to be a bug.
11046 (combine_after_change_list, combine_after_change_buffer):
11047 (adjust_after_replace, signal_before_change): Now static.
11048 (adjust_after_replace_noundo): Remove; unused.
11049 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11050 (signal_before_change): Remove decls.
11052 * indent.c (val_compute_motion, val_vmotion): Now static.
11054 * image.c: Make symbols static if they're not exported.
11055 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11057 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11058 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11060 * fringe.c (standard_bitmaps): Now static.
11061 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11063 * frame.c: Make symbols static if they're not exported.
11064 (x_report_frame_params, make_terminal_frame): Now static.
11065 (get_frame_param): Now static, unless HAVE_NS.
11066 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11067 (x_get_resource_string): Remove; not used.
11068 * frame.h (make_terminal_frame, x_report_frame_params):
11069 (x_get_resource_string); Remove decls.
11070 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11071 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11073 * font.c, fontset.c: Make symbols static if they're not exported.
11074 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11075 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11076 * font.c (font_close_object): Now static.
11077 * font.h (font_close_object): Remove.
11078 * fontset.c (FONTSET_OBJLIST): Remove.
11079 (free_realized_fontset) #if-0 the body, which does nothing.
11080 (face_suitable_for_char_p): #if-0, as it's never called.
11081 * fontset.h (face_suitable_for_char_p): Remove decl.
11082 * xfaces.c (face_at_string_position):
11083 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11084 since 0 is always ASCII.
11086 * fns.c (weak_hash_tables): Now static.
11088 * fileio.c: Make symbols static if they're not exported.
11089 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11090 (Vwrite_region_annotation_buffers): Now static.
11092 * eval.c: Make symbols static if they're not exported.
11093 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11094 * lisp.h (backtrace_list): Remove decl.
11096 * emacs.c: Make symbols static if they're not exported.
11097 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11098 (fatal_error_code, fatal_error_signal_hook, standard_args):
11100 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11101 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11102 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11103 * lisp.h (fatal_error_signal_hook): Remove decl.
11104 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11106 * editfns.c: Move a (normally-unused) function to its only use.
11107 * editfns.c, lisp.h (get_operating_system_release): Remove.
11108 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11109 worth the hassle of breaking this out.
11111 * xterm.c: Make symbols static if they're not exported.
11112 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11113 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11114 (x_destroy_window, x_delete_display):
11116 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11117 (x_mouse_leave): Remove; unused.
11118 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11119 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11120 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11122 (x_mouse_leave): Declare only if WINDOWSNT.
11123 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11124 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11127 * ftxfont.c: Make symbols static if they're not exported.
11128 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11130 * font.h (ftxfont_driver): Likewise.
11132 * xfns.c: Make symbols static if they're not exported.
11133 (x_last_font_name, x_display_info_for_name):
11134 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11135 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11136 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11137 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11138 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11139 (last_show_tip_args): Now static.
11140 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11141 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11142 (x_screen_planes): Remove; unused.
11143 * dispextern.h (x_screen_planes): Remove decl.
11145 * dispnew.c: Make symbols static if they're not exported.
11146 * dispextern.h (redraw_garbaged_frames, scrolling):
11147 (increment_row_positions): Remove.
11148 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11149 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11151 (redraw_garbaged_frames): Remove; unused.
11153 * xfaces.c: Make symbols static if they're not exported.
11154 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11156 * xterm.h (defined_color): Remove decls.
11157 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11158 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11159 (menu_face_changed_default, defined_color, free_realized_face):
11160 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11161 (ascii_face_of_lisp_face): Remove; unused.
11163 * xdisp.c: Make symbols static if they're not exported.
11164 * dispextern.h (scratch_glyph_row, window_box_edges):
11165 (glyph_to_pixel_coords, set_cursor_from_row):
11166 (get_next_display_element, set_iterator_to_next):
11167 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11168 (show_mouse_face): Remove decls
11169 * frame.h (message_buf_print): Likewise.
11170 * lisp.h (pop_message, set_message, check_point_in_composition):
11172 * xterm.h (set_vertical_scroll_bar): Likewise.
11173 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11174 (message_buf_print, scratch_glyph_row, displayed_buffer):
11175 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11176 (get_next_display_element, show_mouse_face, window_box_edges):
11177 (frame_to_window_pixel_xy, check_point_in_composition):
11178 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11179 (glyph_to_pixel_coords): Remove; unused.
11181 * dired.c (file_name_completion): Now static.
11183 * dbusbind.c (xd_in_read_queued_messages): Now static.
11185 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11186 * data.c (circular_list_error): Remove.
11188 * commands.h (last_point_position, last_point_position_buffer):
11189 (last_point_position_window): Remove decls.
11190 * keyboard.c: Make these variables static.
11192 * coding.h (coding, code_convert_region, encode_coding_gap):
11194 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11195 (iso_code_class, detect_coding, code_convert_region): Now static.
11196 (encode_coding_gap): Remove; unused.
11198 * chartab.c (chartab_chars, chartab_bits): Now static.
11200 * charset.h (charset_iso_8859_1): Remove decl.
11201 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11204 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11205 * ccl.c (Vccl_program_table): Now static.
11206 (check_ccl_update): Remove; unused.
11208 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11209 * category.h: ... from here.
11210 * category.c (check_category_table, set_category_set): Now static.
11212 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11213 * lisp.h: Remove these decls.
11215 * buffer.c (buffer_count): Remove unused var.
11217 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11218 so that it's not optimized away.
11219 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11220 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11221 exported only to the debugger.
11223 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11224 * atimer.h (run_all_atimers): Remove; not exported.
11226 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11227 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11228 was inaccessible from Lisp.
11229 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11230 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11232 alloc.c: Import and export fewer symbols, and remove unused items.
11233 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11235 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11236 it's not optimized away by whole-program optimization.
11237 (message_enable_multibyte, free_misc): Remove.
11238 (catchlist, handlerlist, mark_backtrace):
11239 Declare only if BYTE_MARK_STACK.
11240 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11241 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11242 (message_enable_multibyte): Remove decl.
11243 (free_misc, interval_free_list, float_block, float_block_index):
11244 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11245 (cons_free_list, last_marked_index):
11247 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11248 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11249 (mark_backtrace): Define only if BYTE_MARK_STACK.
11250 * xdisp.c (message_enable_multibyte): Now static.
11252 Declare Lisp_Object Q* variables to be 'static' if not exported.
11253 This makes it easier for human readers (and static analyzers)
11254 to see whether these variables are used from other modules.
11255 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11256 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11257 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11258 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11259 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11260 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11261 * xmenu.c, xselect.c:
11262 Declare Q* vars static if they are not used in other modules.
11263 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11264 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11265 Remove decls of unexported vars.
11266 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11268 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11270 Make Emacs functions such as Fatom 'static' by default.
11271 This makes it easier for human readers (and static analyzers)
11272 to see whether these functions can be called from other modules.
11273 DEFUN now defines a static function. To make the function external
11274 so that it can be used in other C modules, use the new macro DEFUE.
11275 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11276 (Finit_image_library):
11277 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11278 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11279 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11280 Remove decls, since these functions are now static.
11281 (Funintern, Fget_internal_run_time): New decls, since these functions
11282 were already external.
11284 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11285 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11286 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11287 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11288 * keyboard.c, keymap.c, lread.c:
11289 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11290 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11291 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11292 Mark functions with DEFUE instead of DEFUN,
11293 if they are used in other modules.
11294 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11295 decls for now-static functions.
11296 * buffer.h (Fdelete_overlay): Remove decl.
11297 * callproc.c (Fgetenv_internal): Mark as internal.
11298 * composite.c (Fremove_list_of_text_properties): Remove decl.
11299 (Fcomposition_get_gstring): New forward static decl.
11300 * composite.h (Fcomposite_get_gstring): Remove decl.
11301 * dired.c (Ffile_attributes): New forward static decl.
11302 * doc.c (Fdocumntation_property): New forward static decl.
11303 * eval.c (Ffetch_bytecode): New forward static decl.
11304 (Funintern): Remove extern decl; now in .h file where it belongs.
11305 * fileio.c (Fmake_symbolic_link): New forward static decl.
11306 * image.c (Finit_image_library): New forward static decl.
11307 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11308 * intervals.h (Fprevious_property_change):
11309 (Fremove_list_of_text_properties): Remove decls.
11310 * keyboard.c (Fthis_command_keys): Remove decl.
11311 (Fcommand_execute): New forward static decl.
11312 * keymap.c (Flookup_key): New forward static decl.
11313 (Fcopy_keymap): Now static.
11314 * keymap.h (Flookup_key): Remove decl.
11315 * process.c (Fget_process): New forward static decl.
11316 (Fprocess_datagram_address): Mark as internal.
11317 * syntax.c (Fsyntax_table_p): New forward static decl.
11318 (skip_chars): Remove duplicate decl.
11319 * textprop.c (Fprevious_property_change): New forward static decl.
11320 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11322 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11323 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11325 * editfns.c (Fformat): Remove unreachable code.
11327 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11329 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11332 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11334 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11335 when at ZV. (Bug#8487)
11337 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11339 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11341 * keyboard.c (parse_tool_bar_item): Likewise.
11342 * sound.c (sound_cleanup, alsa_close): Likewise.
11343 * termcap.c (tgetent): Likewise.
11344 * xfns.c (x_default_font_parameter): Likewise.
11345 * xsettings.c (read_and_apply_settings): Likewise.
11347 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11348 (overrun_check_free): Protoize.
11350 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11352 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11353 since callers should never pass a negative size.
11354 Change the signature to match that of plain 'read' and 'write'; see
11355 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11356 * lisp.h: Update prototypes of emacs_write and emacs_read.
11358 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11360 * xdisp.c (redisplay_window): Don't try to determine the character
11361 position of the scroll margin if the window start point w->startp
11362 is outside the buffer's accessible region. (Bug#8468)
11364 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11366 Fix write-region and its subroutines for buffers > 2GB.
11367 * fileio.c (a_write, e_write): Modify declaration of arguments and
11368 local variables to support buffers larger than 2GB.
11369 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11371 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11372 argument, local variables, and return value.
11374 * lisp.h: Update prototypes of emacs_write and emacs_read.
11376 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11378 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11380 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11382 Fix more problems found by GCC 4.6.0's static checks.
11384 * xdisp.c (vmessage): Use a better test for character truncation.
11386 * charset.c (load_charset_map): <, not <=, for optimization,
11387 and to avoid potential problems with integer overflow.
11388 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11389 * casetab.c (set_identity, shuffle): Likewise.
11390 * editfns.c (Fformat): Likewise.
11391 * syntax.c (skip_chars): Likewise.
11393 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11394 This also lets GCC 4.6.0 generate slightly better loop code.
11396 * callint.c (Fcall_interactively): <, not <=, for optimization.
11397 (Fcall_interactively): Count the number of arguments produced,
11398 not the number of arguments given. This is simpler and lets GCC
11399 4.6.0 generate slightly better code.
11401 * ftfont.c: Distingish more carefully between FcChar8 and char.
11402 The previous code passed unsigned char * to a functions like
11403 strlen and xstrcasecmp that expect char *, which does not
11404 conform to the C standard.
11405 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11406 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11407 char * when the C standard requires it.
11409 * keyboard.c (read_char): Remove unused var.
11411 * eval.c: Port to Windows vsnprintf (Bug#8435).
11412 Include <limits.h>.
11413 (SIZE_MAX): Define if the headers do not.
11414 (verror): Do not give up if vsnprintf returns a negative count.
11415 Instead, grow the buffer. This ports to Windows vsnprintf, which
11416 does not conform to C99. Problem reported by Eli Zaretskii.
11417 Also, simplify the allocation scheme, by avoiding the need for
11418 calling realloc, and removing the ALLOCATED variable.
11420 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11422 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11423 But keep the doprint source code for now, as we might revamp it
11424 and use it again (Bug#8435).
11425 * lisp.h (doprnt): Remove.
11426 * Makefile.in (base_obj): Remove doprnt.o.
11427 * deps.mk (doprnt.o): Remove.
11429 error: Print 32- and 64-bit integers portably (Bug#8435).
11430 Without this change, on typical 64-bit hosts error ("...%d...", N)
11431 was used to print both 32- and 64-bit integers N, which relied on
11432 undefined behavior.
11433 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11434 * lisp.h (error, verror): Mark as printf-like functions.
11435 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11436 Report overflow in size calculations when allocating printf buffer.
11437 Do not truncate output string at its first null byte.
11438 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11439 Truncate the output at a character boundary, since vsnprintf does not
11441 * charset.c (check_iso_charset_parameter): Convert internal
11442 character to string before calling 'error', since %c now has the
11444 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11445 overflow when computing char to be passed to 'error'. Do not
11446 pass Lisp_Object to 'error'; pass the integer instead.
11447 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11448 formatted with plain %d.
11450 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11452 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11454 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11456 * xterm.c (x_catch_errors): Remove duplicate declaration.
11458 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11460 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11462 2011-04-10 Jim Meyering <meyering@redhat.com>
11464 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11465 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11466 return ssize_t not "int", and use size_t as the buffer length.
11467 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11468 * gnutls.h: Update declarations.
11469 * process.c (read_process_output): Use ssize_t, to match.
11470 (send_process): Likewise.
11472 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11474 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11476 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11478 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11479 Use unsigned char, to match FcChar8 type definition.
11481 * xterm.c (handle_one_xevent):
11482 * xmenu.c (create_and_show_popup_menu):
11483 * xselect.c (x_decline_selection_request)
11484 (x_reply_selection_request): Avoid type-punned deref of X events.
11486 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11488 Fix some uses of `int' instead of EMACS_INT.
11489 * search.c (string_match_1, fast_string_match)
11490 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11491 (scan_buffer, find_next_newline_no_quit)
11492 (find_before_next_newline, search_command, Freplace_match)
11493 (Fmatch_data): Make some `int' variables be EMACS_INT.
11495 * xdisp.c (display_count_lines): 3rd argument and return value now
11496 EMACS_INT. All callers changed.
11497 (pint2hrstr): Last argument is now EMACS_INT.
11499 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11500 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11501 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11502 (decode_coding_utf_16, decode_coding_emacs_mule)
11503 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11504 (decode_coding_ccl, decode_coding_charset)
11505 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11506 (decode_coding_iso_2022, decode_coding_emacs_mule)
11507 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11508 <char_offset, last_offset>: Declare EMACS_INT.
11509 (encode_coding_utf_8, encode_coding_utf_16)
11510 (encode_coding_emacs_mule, encode_invocation_designation)
11511 (encode_designation_at_bol, encode_coding_iso_2022)
11512 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11513 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11515 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11516 (encode_invocation_designation): Last argument P_NCHARS is now
11518 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11519 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11521 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11524 * ccl.c (Fccl_execute_on_string): Declare some variables
11527 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11529 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11531 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11533 * process.c (Fformat_network_address): Doc fix.
11535 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11537 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11539 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11541 * keyboard.c (read_char): Call Lisp function help-form-show,
11542 instead of using internal_with_output_to_temp_buffer.
11543 (Qhelp_form_show): New var.
11544 (syms_of_keyboard): Use DEFSYM macro.
11546 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11548 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11550 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11552 * process.c (Flist_processes): Remove to Lisp.
11553 (list_processes_1): Delete.
11555 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11557 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11559 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11561 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11563 Fix more problems found by GCC 4.6.0's static checks.
11565 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11567 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11569 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11571 * xdisp.c (vmessage): Mark as a printf-like function.
11573 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11575 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11577 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11578 printf-like functions.
11579 (tiff_load): Add casts to remove these marks before passing them
11580 to system-supplied API.
11582 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11584 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11585 This avoids several warnings with gcc -Wstrict-overflow.
11586 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11587 directly, rather than having caller test rule sign. This avoids
11588 some unnecessary tests.
11589 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11590 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11591 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11593 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11594 (xfont_open): Avoid unnecessary tests.
11596 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11598 * composite.h, composite.c (composition_gstring_put_cache):
11599 Use EMACS_INT, not int, for length.
11601 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11602 breaking out part of COMPOSITION_DECODE_RULE.
11603 (COMPOSITION_DECODE_RULE): Use it.
11604 * composite.c (get_composition_id): Remove unused local vars,
11605 by using the new macro.
11607 * textprop.c (set_text_properties_1): Change while to do-while,
11608 since the condition is always true at first.
11610 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11611 (interval_deletion_adjustment): Return unsigned value.
11614 * process.c (list_processes_1, create_pty, read_process_output):
11615 (exec_sentinel): Remove vars that were set but not used.
11616 (create_pty): Remove unnecessary "volatile"s.
11617 (Fnetwork_interface_info): Avoid possibility of int overflow.
11618 (read_process_output): Do adaptive read buffering even if carryover.
11619 (read_process_output): Simplify nbytes computation if buffered.
11621 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11623 * syntax.c (scan_words): Remove var that was set but not used.
11624 (update_syntax_table): Use unsigned instead of int.
11626 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11627 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11628 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11630 * print.c (print_error_message): Avoid int overflow.
11632 * font.c (font_list_entities): Redo for clarity,
11633 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11635 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11636 (font_score): Avoid potential overflow in diff calculation.
11638 * fns.c (substring_both): Remove var that is set but not used.
11639 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11641 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11643 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11644 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11645 can always succeed if overflow has undefined behavior.
11647 * search.c (boyer_moore, wordify): Remove vars set but not used.
11648 (wordify): Omit three unnecessary tests.
11650 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11651 All callers changed. This avoids the need for an unused var.
11653 * casefiddle.c (casify_region): Remove var that is set but not used.
11655 * dired.c (file_name_completion): Remove var that is set but not used.
11657 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11659 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11660 (Finsert_file_contents): Remove unnecessary code checking fd.
11662 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11663 Check for integer overflow on size calculations.
11665 * buffer.c (Fprevious_overlay_change): Remove var that is set
11668 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11669 Remove vars that are set but not used.
11670 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11671 (timer_check_2): Mark vars as initialized.
11673 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11675 * image.c (lookup_image): Remove var that is set but not used.
11676 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11678 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11679 that are set but not used.
11681 * xfns.c (make_invisible_cursor): Don't return garbage
11682 if XCreateBitmapFromData fails (Bug#8410).
11684 * xselect.c (x_get_local_selection, x_handle_property_notify):
11685 Remove vars that are set but not used.
11687 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11688 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11690 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11691 Remove var that is set but not used.
11692 (scroll_bar_windows_size): Now size_t, not int.
11693 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11694 Check for overflow.
11696 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11697 (map_tty_color) [!defined MSDOS]: Likewise.
11699 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11701 * coding.c: Remove vars that are set but not used.
11702 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11703 All callers changed.
11704 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11705 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11706 (decode_coding_charset): Remove vars that are set but not used.
11708 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11709 that is set but not used.
11711 * print.c (print_object): Remove var that is set but not used.
11713 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11714 The gnulib version avoids calling malloc in the usual case,
11715 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11716 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11717 * filelock.c (current_lock_owner): Likewise.
11718 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11719 * sysdep.c: Include allocator.h, careadlinkat.h.
11720 (emacs_no_realloc_allocator): New static constant.
11721 (emacs_readlink): New function.
11722 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11723 ../lib/careadlinkat.h.
11725 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11727 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11728 first non-nil return value).
11730 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11732 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11733 if not defined (Bug#8403).
11735 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11737 * xdisp.c (display_count_lines): Remove parameter `start',
11738 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11739 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11740 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11741 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11742 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11743 and thereabouts. All callers changed.
11744 (get_per_char_metric): Remove parameter `f', unused since
11745 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11747 2011-04-02 Jim Meyering <meyering@redhat.com>
11749 do not dereference NULL upon failed strdup
11750 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11751 (ns_get_family): Likewise.
11753 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11755 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11757 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11759 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11762 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11764 Add lexical binding.
11766 * window.c (Ftemp_output_buffer_show): New fun.
11767 (Fsave_window_excursion):
11768 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11770 * lread.c (lisp_file_lexically_bound_p): New function.
11771 (Fload): Bind Qlexical_binding.
11772 (readevalloop): Remove `evalfun' arg.
11773 Bind Qinternal_interpreter_environment.
11774 (Feval_buffer): Bind Qlexical_binding.
11775 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11777 (syms_of_lread): Declare `lexical-binding'.
11779 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11781 * keyboard.c (eval_dyn): New fun.
11782 (menu_item_eval_property): Use it.
11784 * image.c (parse_image_spec): Use Ffunctionp.
11786 * fns.c (concat, mapcar1): Accept byte-code-functions.
11788 * eval.c (Fsetq): Handle lexical vars.
11789 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11790 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11791 (FletX, Flet): Obey lexical binding.
11792 (Fcommandp): Handle closures.
11793 (Feval): New `lexical' arg.
11794 (eval_sub): New function extracted from Feval. Use it almost
11795 everywhere where Feval was used. Look up vars in lexical env.
11797 (Ffunctionp): Move from subr.el.
11798 (Ffuncall): Handle closures.
11799 (apply_lambda): Remove `eval_flags'.
11800 (funcall_lambda): Handle closures and new byte-code-functions.
11801 (Fspecial_variable_p): New function.
11802 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11803 but without exporting it to Lisp.
11805 * doc.c (Fdocumentation, store_function_docstring):
11806 * data.c (Finteractive_form): Handle closures.
11808 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11811 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11813 (exec_byte_code): New function extracted from Fbyte_code to handle new
11814 calling convention for byte-code-functions. Add new byte-codes.
11816 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11818 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11820 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11822 * xdisp.c (redisplay_internal): Fix prototype.
11824 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11826 * xdisp.c (SCROLL_LIMIT): New macro.
11827 (try_scrolling): Use it when setting scroll_limit.
11828 Limit scrolling to 100 screen lines.
11829 (redisplay_window): Even when falling back on "recentering",
11830 position point in the window according to scroll-conservatively,
11831 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11833 (try_scrolling): When point is above the window, allow searching
11834 as far as scroll_max, or one screenful, to compute vertical
11835 distance from PT to the scroll margin position. This prevents
11836 try_scrolling from unnecessarily failing when
11837 scroll-conservatively is set to a value slightly larger than the
11838 window height. Clean up the case of PT below the margin at bottom
11839 of window: scroll_max can no longer be INT_MAX. When aggressive
11840 scrolling is in use, don't let point enter the opposite scroll
11841 margin as result of the scroll.
11842 (syms_of_xdisp) <scroll-conservatively>: Document the
11843 threshold of 100 lines for never-recentering scrolling.
11845 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11847 * dispextern.h (move_it_by_lines):
11848 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11849 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11850 (message_log_check_duplicate): Remove parameters `prev_bol' and
11851 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11852 (redisplay_internal): Remove parameter `preserve_echo_area',
11853 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11855 * indent.c (Fvertical_motion):
11856 * window.c (window_scroll_pixel_based, Frecenter):
11857 Don't pass `need_y_p' to `move_it_by_lines'.
11859 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11861 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11862 steal a few bits to be more compact.
11863 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11864 Remove unneeded casts.
11866 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11868 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11870 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11871 binding" message (bug#7967).
11873 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11875 Fix more problems found by GCC 4.6.0's static checks.
11877 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11878 Remove unused local var.
11880 * editfns.c (Fmessage_box): Remove unused local var.
11882 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11883 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11884 Omit unused local vars.
11885 * window.c (shrink_windows): Omit unused local var.
11886 * menu.c (digest_single_submenu): Omit unused local var.
11887 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11888 Omit unused local var.
11890 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11891 Don't assume string length fits in int.
11892 (keyremap_step, read_key_sequence): Use size_t for sizes.
11893 (read_key_sequence): Don't check last_real_key_start redundantly.
11895 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11896 instead of alloca (Bug#8344).
11898 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11899 (Fbacktrace_frame): Don't assume nframes fits in int.
11901 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11903 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11906 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11908 * cm.c (calccost): Turn while-do into do-while, for clarity.
11910 * keyboard.c (syms_of_keyboard): Use the same style as later
11911 in this function when indexing through an array. This also
11912 works around GCC bug 48267.
11914 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11916 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11918 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11919 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11921 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11922 This avoids undefined behavior on integer overflow, and is a bit
11923 more convenient anyway since it is compared to a size_t variable.
11925 Variadic C functions now count arguments with size_t, not int.
11926 This avoids an unnecessary limitation on 64-bit machines, which
11927 caused (substring ...) to crash on large vectors (Bug#8344).
11928 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11929 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11930 All variadic functions and their callers changed accordingly.
11931 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11932 * data.c (arith_driver, float_arith_driver): Likewise.
11933 * editfns.c (general_insert_function): Likewise.
11934 * eval.c (struct backtrace.nargs, interactive_p)
11935 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11936 (funcall_lambda, mark_backtrace): Likewise.
11937 * fns.c (concat): Likewise.
11938 * frame.c (x_set_frame_parameters): Likewise.
11939 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11940 0 if not found, not -1. All callers changed.
11942 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11943 (stack_copy_size): Now size_t, not int.
11944 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11946 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11948 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11949 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11950 All callers changed.
11952 * lisp.h (multibyte_char_to_unibyte):
11953 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11954 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11955 * character.h (CHAR_TO_BYTE8):
11956 * cmds.c (internal_self_insert):
11957 * editfns.c (general_insert_function):
11958 * keymap.c (push_key_description):
11959 * search.c (Freplace_match):
11960 * xdisp.c (message_dolog, set_message_1): All callers changed.
11962 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11964 * keyboard.c (safe_run_hook_funcall): New function.
11965 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11966 don't set the hook to nil, but remove the offending function instead.
11967 (Qcommand_hook_internal): Remove, unused.
11968 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11969 Vcommand_hook_internal.
11971 * eval.c (enum run_hooks_condition): Remove.
11972 (funcall_nil, funcall_not): New functions.
11973 (run_hook_with_args): Call each function through a `funcall' argument.
11974 Remove `cond' argument, now redundant.
11975 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11976 (Frun_hook_with_args_until_failure): Adjust accordingly.
11977 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11979 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11981 * dispextern.h (string_buffer_position): Remove declaration.
11983 * print.c (strout): Remove parameter `multibyte', unused since
11984 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11986 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11987 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11988 All callers changed.
11990 * w32.c (_wsa_errlist): Use braces for struct initializers.
11992 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11993 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11994 All callers changed.
11995 (string_buffer_position): Likewise. Also, make static (it's never
11996 used outside xdisp.c).
11997 (cursor_row_p): Remove parameter `w', unused since
11998 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11999 (decode_mode_spec): Remove parameter `precision', introduced during
12000 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12001 All callers changed.
12003 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12005 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12007 2011-03-27 Anders Lindgren <andlind@gmail.com>
12009 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12010 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12011 (ns_update_auto_hide_menu_bar): New functions.
12012 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12013 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12014 ns_constrain_all_frames.
12015 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12016 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12018 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12020 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12022 2011-03-27 Glenn Morris <rgm@gnu.org>
12024 * syssignal.h: Replace RETSIGTYPE with void.
12025 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12026 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12027 Replace SIGTYPE with void everywhere.
12028 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12029 * s/template.h (SIGTYPE): Remove commented out definition.
12031 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12033 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12034 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12036 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12038 * w32.c (read_unc_volume): Use parameter `henum', instead of
12039 global variable `wget_enum_handle'.
12041 * keymap.c (describe_vector): Remove parameters `indices' and
12042 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12043 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12045 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12047 * keyboard.c (timer_check): Remove parameter `do_it_now',
12048 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12049 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12050 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12052 * keyboard.c (read_char):
12053 * w32menu.c (w32_menu_display_help):
12054 * xmenu.c (show_help_event, menu_help_callback):
12055 Adjust calls to `show_help_echo'.
12057 * gtkutil.c (xg_maybe_add_timer):
12058 * keyboard.c (readable_events):
12059 * process.c (wait_reading_process_output):
12060 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12062 * insdel.c (adjust_markers_gap_motion):
12063 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12064 (gap_left, gap_right): Don't call it.
12066 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12068 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12069 incurred during fontification.
12071 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12073 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12074 (DEFVAR_PER_BUFFER): Don't pass it.
12076 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12077 (scrolling_window): Don't pass it.
12079 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12081 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12083 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12085 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12086 of variables specific to SELinux and computation of `encoded_absname'.
12088 * image.c (XPutPixel): Remove unused variable `height'.
12090 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12092 * unexw32.c (get_section_info): Remove unused variable `section'.
12094 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12095 (system_process_attributes): Remove unused variable `sess'.
12096 (sys_read): Remove unused variable `err'.
12098 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12099 (w32_wnd_proc): Remove unused variable `isdead'.
12100 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12101 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12102 (x_create_tip_frame): Remove unused variable `tem'.
12104 * w32inevt.c (w32_console_read_socket):
12105 Remove unused variable `no_events'.
12107 * w32term.c (x_draw_composite_glyph_string_foreground):
12108 Remove unused variable `width'.
12110 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12112 * w32term.c (x_set_glyph_string_clipping):
12113 Don't pass uninitialized region to CombineRgn.
12115 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12117 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12118 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12119 (Fx_close_connection): Remove unused variable `i'.
12121 * w32font.c (w32font_draw): Return number of glyphs.
12122 (w32font_open_internal): Remove unused variable `i'.
12123 (w32font_driver): Add missing initializer.
12125 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12126 (fill_in_menu): Remove unused variable `items_added'.
12128 * w32term.c (last_mouse_press_frame): Remove static global variable.
12129 (w32_clip_to_row): Remove unused variable `f'.
12130 (x_delete_terminal): Remove unused variable `i'.
12132 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12133 (NOTHING): Remove unused static global variable.
12134 (uniscribe_check_otf): Remove unused variable `table'.
12135 (uniscribe_font_driver): Add missing initializers.
12137 2011-03-23 Julien Danjou <julien@danjou.info>
12139 * term.c (Fsuspend_tty, Fresume_tty):
12140 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12141 * window.c (temp_output_buffer_show):
12142 * insdel.c (signal_before_change):
12143 * frame.c (Fhandle_switch_frame):
12144 * fileio.c (Fdo_auto_save):
12145 * emacs.c (Fkill_emacs):
12146 * editfns.c (save_excursion_restore):
12147 * cmds.c (internal_self_insert):
12148 * callint.c (Fcall_interactively):
12149 * buffer.c (Fkill_all_local_variables):
12150 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12152 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12153 unconditionally since it does the check itself.
12155 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12157 Fix more problems found by GCC 4.5.2's static checks.
12159 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12160 the first time through the loop, since we know p0 < p1 then.
12161 This also avoids a gcc -Wstrict-overflow warning.
12163 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12164 leading to a memory leak, possible in functions like
12165 load_charset_map_from_file that can allocate an unbounded number
12166 of objects (Bug#8318).
12168 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12169 that could (at least in theory) be that large.
12171 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12172 This is less likely to overflow, and avoids undefined behavior if
12173 overflow does occur. All callers changed. Use strtoul to scan
12174 for the unsigned long integer.
12175 (pint2hrstr): Simplify and tune code slightly.
12176 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12178 * scroll.c (do_scrolling): Work around GCC bug 48228.
12179 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12181 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12182 This also avoids a warning with gcc -Wstrict-overflow.
12183 (validate_x_resource_name): Simplify count usage.
12184 This also avoids a warning with gcc -Wstrict-overflow.
12186 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12189 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12191 * process.c (Fmake_network_process): Use socklen_t, not int,
12192 where POSIX says socklen_t is required in portable programs.
12193 This fixes a porting bug on hosts like 64-bit HP-UX, where
12194 socklen_t is wider than int (Bug#8277).
12195 (Fmake_network_process, server_accept_connection):
12196 (wait_reading_process_output, read_process_output):
12199 * process.c: Rename or move locals to avoid shadowing.
12200 (list_processes_1, Fmake_network_process):
12201 (read_process_output_error_handler, exec_sentinel_error_handler):
12202 Rename or move locals.
12203 (Fmake_network_process): Define label "retry_connect" only if needed.
12204 (Fnetwork_interface_info): Fix pointer signedness.
12205 (process_send_signal): Add cast to avoid pointer signedness problem.
12206 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12207 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12209 Make tparam.h and terminfo.c consistent.
12210 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12211 Include tparam.h instead, since it declares them.
12212 * cm.h (PC): Remove extern decl; tparam.h now does this.
12213 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12214 * terminfo.c: Include tparam.h, to check interfaces.
12215 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12216 (tparam): Adjust signature to match interface in tparam.h;
12217 this removes some undefined behavior. Check that outstring and len
12218 are zero, which they always are with Emacs.
12219 * tparam.h (PC, BC, UP): New extern decls.
12221 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12222 (xftfont_open): Rename locals to avoid shadowing.
12224 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12225 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12226 (OTF_TAG_SYM): Omit macro if not needed.
12227 (ftfont_list): Remove unused local.
12228 (get_adstyle_property, ftfont_pattern_entity):
12229 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12230 Rename locals to avoid shadowing.
12232 * xfont.c (xfont_list_family): Mark var as initialized.
12234 * xml.c (make_dom): Now static.
12236 * composite.c (composition_compute_stop_pos): Rename local to
12238 (composition_reseat_it): Remove unused locals.
12239 (find_automatic_composition, composition_adjust_point): Likewise.
12240 (composition_update_it): Mark var as initialized.
12241 (find_automatic_composition): Mark vars as initialized,
12242 with a FIXME (Bug#8290).
12244 character.h: Rename locals to avoid shadowing.
12245 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12246 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12247 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12248 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12249 to avoid shadowing.
12251 * textprop.c (property_change_between_p): Remove; unused.
12253 * intervals.c (interval_start_pos): Now static.
12255 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12257 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12258 Rename locals to avoid shadowing.
12260 * sound.c (wav_play, au_play, Fplay_sound_internal):
12261 Fix pointer signedness.
12262 (alsa_choose_format): Remove unused local var.
12263 (wav_play): Initialize a variable to 0, to prevent undefined
12264 behavior (Bug#8278).
12266 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12268 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12270 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12271 clobbering (Bug#8298).
12272 * sysdep.c (sys_subshell): Likewise.
12273 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12275 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12276 This should get cleaned up, so that child_setup has the
12277 same signature on all platforms.
12279 * callproc.c (call_process_cleanup): Now static.
12280 (relocate_fd): Rename locals to avoid shadowing.
12282 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12284 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12285 not to be necessary, and produces flickering.
12287 2011-03-20 Glenn Morris <rgm@gnu.org>
12289 * config.in: Remove file.
12291 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12293 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12294 are now in src/globals.h.
12295 (syms_of_minibuf): Remove spurious & from previous change.
12297 2011-03-20 Leo Liu <sdl.web@gmail.com>
12299 * minibuf.c (completing-read-function): New variable.
12300 (completing-read-default): Rename from completing-read.
12301 (completing-read): Call completing-read-function.
12303 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12305 * xfaces.c (Fx_load_color_file):
12306 Read color file from absolute filename (bug#8250).
12308 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12310 * makefile.w32-in: Update dependencies.
12312 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12314 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12316 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12318 Fix more problems found by GCC 4.5.2's static checks.
12320 * process.c (make_serial_process_unwind, send_process_trap):
12321 (sigchld_handler): Now static.
12323 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12324 That way, the code declares only the vars that it needs.
12325 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12326 * s/cygwin.h (PTY_ITERATION): Likewise.
12327 * s/darwin.h (PTY_ITERATION): Likewise.
12328 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12330 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12331 * process.c (allocate_pty): Don't declare stb unless it's needed.
12333 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12334 (CONSTANTLIM): Remove; unused.
12335 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12336 Define only if needed.
12338 * unexelf.c (unexec): Name an expression,
12339 to avoid gcc -Wbad-function-cast warning.
12340 Use a different way to cause a compilation error if anyone uses
12341 n rather than nn, a way that does not involve shadowing.
12342 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12344 * deps.mk (unexalpha.o): Remove; unused.
12346 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12347 * unexec.h: New file.
12348 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12349 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12350 Depend on unexec.h.
12351 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12352 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12353 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12354 Change as necessary to match prototype in unexec.h.
12356 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12358 (back_comment, skip_chars): Mark vars as initialized.
12360 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12361 Rename locals to avoid shadowing.
12363 * lread.c (read1): Rewrite so as not to use empty "else".
12364 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12366 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12368 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12369 warning when compiling print.c.
12371 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12372 instead of using an uninitialized var.
12373 (font_sort_entities): Mark var as initialized.
12375 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12377 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12378 pointers to constants.
12379 (font_parse_fcname): Remove unused vars.
12380 (font_delete_unmatched): Now static.
12381 (font_get_spec): Remove; unused.
12382 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12383 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12384 Rename or move locals to avoid shadowing.
12386 * fns.c (require_nesting_list, require_unwind): Now static.
12387 (Ffillarray): Rename locals to avoid shadowing.
12389 * floatfns.c (domain_error2): Define only if needed.
12390 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12392 * alloc.c (mark_backtrace): Move decl from here ...
12393 * lisp.h: ... to here, so that it can be checked.
12395 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12396 (Fdefvar): Rewrite so as not to use empty "else".
12397 (lisp_indirect_variable): Name an expression,
12398 to avoid gcc -Wbad-function-cast warning.
12399 (Fdefvar): Rename locals to avoid shadowing.
12401 * callint.c (quotify_arg, quotify_args): Now static.
12402 (Fcall_interactively): Rename locals to avoid shadowing.
12403 Use const pointer when appropriate.
12405 * lisp.h (get_system_name, get_operating_system_release):
12406 Move decls here, to check interfaces.
12407 * process.c (get_operating_system_release): Move decl to lisp.h.
12408 * xrdb.c (get_system_name): Likewise.
12409 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12410 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12411 some of which prompt warnings from gcc -Wbad-function-cast.
12412 (Fformat_time_string, Fencode_time, Finsert_char):
12413 (Ftranslate_region_internal, Fformat):
12414 Rename or remove local vars to avoid shadowing.
12415 (Ftranslate_region_internal): Mark var as initialized.
12417 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12420 * lisp.h (eassert): Check that the argument compiles, even if
12421 ENABLE_CHECKING is not defined.
12423 * data.c (Findirect_variable): Name an expression, to avoid
12424 gcc -Wbad-function-cast warning.
12425 (default_value, arithcompare, arith_driver, arith_error): Now static.
12426 (store_symval_forwarding): Rename local to avoid shadowing.
12427 (Fmake_variable_buffer_local, Fmake_local_variable):
12428 Mark variables as initialized.
12429 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12431 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12432 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12433 Rename locals to avoid shadowing.
12434 (mark_stack): Move local variables into the #ifdef region where
12436 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12437 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12439 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12440 (GC_STRING_CHARS): Remove; not used.
12441 (Fmemory_limit): Cast sbrk's returned value to char *.
12443 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12444 avoids undefined behavior in theory.
12446 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12448 Use functions, not macros, for up- and down-casing (Bug#8254).
12449 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12450 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12451 to use the following functions instead of these macros.
12452 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12453 EMACS_INT, since callers assume the returned value fits in int.
12454 (upcase1): Likewise, for UPCASE_TABLE.
12455 (uppercasep, lowercasep, upcase): New static inline functions.
12456 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12457 the race-condition problem in the old DOWNCASE.
12459 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12460 Rename locals to avoid shadowing.
12461 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12462 (regex_compile, re_search_2, re_match_2_internal):
12463 Remove unused local vars.
12464 (FREE_VAR): Rewrite so as not to use empty "else",
12465 which gcc can warn about.
12466 (regex_compile, re_match_2_internal): Mark locals as initialized.
12467 (RETALLOC_IF): Define only if needed.
12468 (WORDCHAR_P): Likewise. This one is never needed, but is used
12469 only in a comment talking about a compiler bug, so put inside
12470 the #if 0 of that comment.
12471 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12472 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12475 * search.c (boyer_moore): Rename locals to avoid shadowing.
12476 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12477 (PREV_CHAR_BOUNDARY): Likewise.
12479 * search.c (simple_search): Remove unused var.
12481 * dired.c (compile_pattern): Move decl from here ...
12482 * lisp.h: ... to here, so that it can be checked.
12483 (struct re_registers): New forward decl.
12485 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12487 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12489 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12490 Rename locals to avoid shadowing.
12491 (Fvertical_motion): Mark locals as initialized.
12493 * casefiddle.c (casify_object, casify_region): Now static.
12494 (casify_region): Mark local as initialized.
12496 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12498 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12499 New macros, so that the caller can use some names other than
12500 gcpro1, gcpro2, etc.
12501 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12503 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12504 argument, for consistency with GCPRO2_VAR, etc: it is now the
12505 prefix of the variable, not the variable itself. All uses
12507 * dired.c (directory_files_internal, file_name_completion):
12508 Rename locals to avoid shadowing.
12510 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12511 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12512 dired.c's scmp function, had undefined behavior.
12513 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12514 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12515 * buffer.h: ... to here, because these macros use current_buffer,
12516 and the new implementation with inline functions needs to have
12517 current_buffer in scope now, rather than later when the macros
12519 (downcase, upcase1): New static inline functions.
12520 (DOWNCASE, UPCASE1): Reimplement using these functions.
12521 This avoids undefined behavior in expressions like
12522 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12523 from race conditions in accessing the global variables
12524 case_temp1 and case_temp2.
12525 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12526 * lisp.h (case_temp1, case_temp2): Remove their decls.
12527 * character.h (ASCII_CHAR_P): Move from here ...
12528 * lisp.h: ... to here, so that the inline functions mentioned
12529 above can use them.
12531 * dired.c (directory_files_internal_unwind): Now static.
12533 * fileio.c (file_name_as_directory, directory_file_name):
12534 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12536 (file_name_as_directory): Use const pointers when appropriate.
12537 (Fexpand_file_name): Likewise. In particular, newdir might
12538 point at constant storage, so make it a const pointer.
12539 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12540 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12542 (Fset_file_times, Finsert_file_contents, auto_save_error):
12543 Rename locals to avoid shadowing.
12545 * minibuf.c (choose_minibuf_frame_1): Now static.
12546 (Ftry_completion, Fall_completions): Rename or remove locals
12547 to avoid shadowing.
12549 * marker.c (bytepos_to_charpos): Remove; unused.
12551 * lisp.h (verify_bytepos, count_markers): New decls,
12552 so that gcc does not warn that these functions aren't declared.
12554 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12555 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12556 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12557 (copy_text): Remove unused local var.
12559 * filelock.c (within_one_second): Now static.
12560 (lock_file_1): Rename local to avoid shadowing.
12562 * buffer.c (fix_overlays_before): Mark locals as initialized.
12563 (fix_start_end_in_overlays): Likewise. This function should be
12564 simplified by using pointers-to-pointers, but that's a different
12566 (switch_to_buffer_1): Now static.
12567 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12568 (report_overlay_modification): Rename locals to avoid shadowing.
12570 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12571 Fix pointer signedness issue.
12572 (sys_subshell): Mark local as volatile if checking for lint,
12573 to suppress a gcc -Wclobbered warning that does not seem to be right.
12574 (MAXPATHLEN): Define only if needed.
12576 * process.c (serial_open, serial_configure): Move decls from here ...
12577 * systty.h: ... to here, so that they can be checked.
12579 * fns.c (get_random, seed_random): Move extern decls from here ...
12580 * lisp.h: ... to here, so that they can be checked.
12582 * sysdep.c (reset_io): Now static.
12583 (wait_for_termination_signal): Remove; unused.
12585 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12586 (copy_keymap_item, append_key, push_text_char_description):
12588 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12589 (DENSE_TABLE_SIZE): Remove; unused.
12590 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12591 (describe_map_tree):
12592 Rename locals to avoid shadowing.
12594 * keyboard.c: Declare functions static if they are not used elsewhere.
12595 (echo_char, echo_dash, cmd_error, top_level_2):
12596 (poll_for_input, handle_async_input): Now static.
12597 (read_char, kbd_buffer_get_event, make_lispy_position):
12598 (make_lispy_event, make_lispy_movement, apply_modifiers):
12599 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12600 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12601 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12602 (read_key_sequence, read_char): Mark locals as initialized.
12603 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12605 * keyboard.h (make_ctrl_char): New decl.
12606 (mark_kboards): Move decl here ...
12607 * alloc.c (mark_kboards): ... from here.
12609 * lisp.h (force_auto_save_soon): New decl.
12611 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12612 (DEFINE_DUMMY_FUNCTION): New macro.
12613 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12615 (main): Add casts to avoid warnings
12616 if GCC considers string literals to be constants.
12618 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12620 * dbusbind.c: Pointer signedness fixes.
12621 (xd_signature, xd_append_arg, xd_initialize):
12622 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12623 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12624 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12625 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12627 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12628 if GCC considers string literals to be constants.
12629 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12631 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12633 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12634 (print_preprocess, print_object): New macro to fix last change.
12636 * print.c (print_preprocess): Don't forget font objects.
12638 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12640 * emacs.c (USAGE3): Doc fixes.
12642 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12644 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12647 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12649 * lisp.h (VWindow_system, Qfile_name_history):
12650 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12651 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12652 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12654 * w32select.c: Don't #include "keyboard.h".
12655 (run_protected): Add extern declaration for waiting_for_input.
12657 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12658 * w32console.c (detect_input_pending, read_input_pending)
12659 (encode_terminal_code):
12660 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12661 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12662 (w32_system_caret_y, Qfile_name_history):
12663 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12664 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12665 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12666 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12667 * w32proc.c (Qlocal, report_file_error):
12668 * w32term.c (Vwindow_system, updating_frame):
12669 * w32uniscribe.c (initialized, uniscribe_font_driver):
12670 Remove unneeded extern declarations.
12672 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12674 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12676 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12678 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12679 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12680 These macros can no longer be used for assignment.
12682 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12683 Assign struct members directly, instead of using BUF_BEGV etc.
12684 (record_buffer_markers, fetch_buffer_markers): New functions for
12685 recording and fetching special buffer markers.
12686 (set_buffer_internal_1, set_buffer_temp): Use them.
12688 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12690 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12692 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12693 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12695 * xdisp.c (hscroll_window_tree):
12696 (reconsider_clip_changes): Use PT instead of BUF_PT.
12698 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12700 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12701 $(EMACS_ROOT)/lib/intprops.h.
12703 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12705 Fix more problems found by GCC 4.5.2's static checks.
12707 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12708 to unsigned char * to avoid compiler diagnostic.
12709 (xg_free_frame_widgets): Make it clear that a local variable is
12710 needed only if USE_GTK_TOOLTIP.
12711 (gdk_window_get_screen): Make it clear that this macro is needed
12712 only if USE_GTK_TOOLTIP.
12713 (int_gtk_range_get_value): New function, which avoids a diagnostic
12714 from gcc -Wbad-function-cast.
12715 (xg_set_toolkit_scroll_bar_thumb): Use it.
12716 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12717 diagnostic from gcc -Wbad-function-cast.
12718 (get_utf8_string, xg_get_file_with_chooser):
12719 Rename locals to avoid shadowing.
12720 (create_dialog): Move locals to avoid shadowing.
12722 * xgselect.c (xg_select): Remove unused var.
12724 * image.c (four_corners_best): Mark locals as initialized.
12725 (gif_load): Initialize transparent_p to zero (Bug#8238).
12726 Mark another local as initialized.
12727 (my_png_error, my_error_exit): Mark with NO_RETURN.
12729 * image.c (clear_image_cache): Now static.
12730 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12731 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12732 (x_edge_detection): Remove unnecessary cast that
12733 gcc -Wbad-function-cast diagnoses.
12734 (gif_load): Fix pointer signedness.
12735 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12736 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12738 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12740 Improve quality of tests for time stamp overflow.
12741 For example, without this patch (encode-time 0 0 0 1 1
12742 1152921504606846976) returns the obviously-bogus value (-948597
12743 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12744 reports time overflow. See
12745 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12746 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12747 * editfns.c: Include limits.h and intprops.h.
12748 (TIME_T_MIN, TIME_T_MAX): New macros.
12749 (time_overflow): Move earlier, to before first use.
12750 (hi_time, lo_time): New functions, for an accurate test for
12751 out-of-range times.
12752 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12753 (Fget_internal_run_time): Don't assume time_t fits in int.
12754 (make_time): Use list2 instead of Fcons twice.
12755 (Fdecode_time): More accurate test for out-of-range times.
12756 (check_tm_member): New function.
12757 (Fencode_time): Use it, to test for out-of-range times.
12758 (lisp_time_argument): Don't rely on undefined left-shift and
12759 right-shift behavior when checking for time stamp overflow.
12761 * editfns.c (time_overflow): New function, refactoring common code.
12762 (Fformat_time_string, Fdecode_time, Fencode_time):
12763 (Fcurrent_time_string): Use it.
12765 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12766 * dired.c (make_time): Move to ...
12767 * editfns.c (make_time): ... here.
12768 * systime.h: Note the move.
12770 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12772 * fringe.c (update_window_fringes): Remove unused variables.
12774 * unexmacosx.c (copy_data_segment): Also copy __got section.
12777 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12779 * termcap.c [MSDOS]: Include "msdos.h".
12780 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12781 Constify `char *' arguments and their references according to
12782 prototypes in tparam.h.
12784 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12786 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12787 Adapt all references accordingly.
12789 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12791 2011-03-11 Tom Tromey <tromey@redhat.com>
12793 * buffer.c (syms_of_buffer): Remove obsolete comment.
12795 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12797 * termhooks.h (encode_terminal_code): Declare prototype.
12799 * msdos.c (encode_terminal_code): Don't declare prototype.
12801 * term.c (encode_terminal_code): Now external again, used by
12802 w32console.c and msdos.c.
12804 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12805 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12807 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12809 Fix some minor problems found by GCC 4.5.2's static checks.
12811 * fringe.c (update_window_fringes): Mark locals as initialized
12813 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12815 * alloc.c (mark_fringe_data): Move decl from here ...
12816 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12817 to check its interface.
12818 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12820 * fontset.c (free_realized_fontset): Now static.
12821 (Fset_fontset_font): Rename local to avoid shadowing.
12822 (fontset_font): Mark local as initialized.
12823 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12825 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12827 * xselect.c (x_disown_buffer_selections): Remove; not used.
12828 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12829 (x_own_selection, Fx_disown_selection_internal): Rename locals
12830 to avoid shadowing.
12831 (x_handle_dnd_message): Remove local to avoid shadowing.
12833 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12834 so that the caller can use some name other than gcpro1.
12835 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12836 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12837 (Fx_backspace_delete_keys_p):
12838 Use them to avoid shadowing, and rename vars to avoid shadowing.
12839 (x_decode_color, x_set_name, x_window): Now static.
12840 (Fx_create_frame): Add braces to silence GCC warning.
12841 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12842 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12843 Remove unused locals.
12844 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12845 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12846 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12849 * xterm.h (x_mouse_leave): New decl.
12851 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12852 Remove unused functions.
12853 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12854 (x_calc_absolute_position): Now static.
12855 (XTread_socket): Don't define label "out" unless it's used.
12856 Don't declare local "event" unless it's used.
12857 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12858 unless they are used.
12859 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12860 (x_fatal_error_signal): Remove; not used.
12861 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12862 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12863 (x_error_catcher, x_connection_closed, x_error_handler):
12864 (x_error_quitter, xembed_send_message, x_iconify_frame):
12865 (my_log_handler): Rename locals to avoid shadowing.
12866 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12867 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12869 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12870 Rename or move locals to avoid shadowing.
12871 (tty_defined_color, merge_face_heights): Now static.
12872 (free_realized_faces_for_fontset): Remove; not used.
12873 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12874 does not deduce is never used uninitialized.
12875 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12876 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12878 * terminal.c (store_terminal_param): Now static.
12880 * xmenu.c (menu_highlight_callback): Now static.
12881 (set_frame_menubar): Remove unused local.
12882 (xmenu_show): Rename parameter to avoid shadowing.
12883 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12884 since they might point to immutable storage.
12885 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12886 since it's unused otherwise.
12888 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12889 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12890 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12891 avoids a gcc -Wuninitialized diagnostic.
12892 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12893 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12894 does not deduce are never used uninitialized.
12896 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12898 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12899 * window.c (window_loop, size_window):
12900 (run_window_configuration_change_hook, enlarge_window): Likewise.
12902 * window.c (display_buffer): Now static.
12903 (size_window): Mark variables that gcc -Wuninitialized
12904 does not deduce are never used uninitialized.
12905 * window.h (check_all_windows): New decl, to forestall
12906 gcc -Wmissing-prototypes diagnostic.
12907 * dispextern.h (bidi_dump_cached_states): Likewise.
12909 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12911 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12912 Include <limits.h>.
12913 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12914 and to avoid gcc -Wuninitialized warning.
12915 (load_charset_map): Mark variables that gcc -Wuninitialized
12916 does not deduce are never used uninitialized.
12917 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12919 * coding.c (coding_set_source, coding_set_destination):
12920 Use "else { /* comment */ }" rather than "else /* comment */;"
12921 for clarity, and to avoid gcc -Wempty-body warning.
12922 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12923 a block, when the outer 'i' will do.
12924 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12925 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12926 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12927 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12928 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12929 Rename locals to avoid shadowing.
12930 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12931 * coding.c (emacs_mule_char, encode_invocation_designation):
12932 Now static, since they're not used elsewhere.
12933 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12934 (decode_coding_object, encode_coding_object, detect_coding_system):
12935 (decode_coding_emacs_mule): Mark variables that gcc
12936 -Wuninitialized does not deduce are never used uninitialized.
12937 (detect_coding_iso_2022): Initialize a local variable that might
12938 be used uninitialized. Leave a FIXME because it's not clear that
12939 this initialization is needed. (Bug#8211)
12940 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12941 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12942 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12943 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12944 Remove unused macros.
12946 * category.c (hash_get_category_set): Remove unused local var.
12947 (copy_category_table): Now static, since it's not used elsewhere.
12948 * character.c (string_count_byte8): Likewise.
12950 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12951 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12953 * chartab.c (copy_sub_char_table): Now static, since it's not used
12955 (sub_char_table_ref_and_range, char_table_ref_and_range):
12956 Rename locals to avoid shadowing.
12957 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12959 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12960 (BIDI_BOB): Remove unused macro.
12962 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12963 deduce are never used uninitialized.
12964 * term.c (encode_terminal_code): Likewise.
12966 * term.c (encode_terminal_code): Now static. Remove unused local.
12968 * tparam.h: New file.
12969 * term.c, tparam.h: Include it.
12970 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12971 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12972 Move these decls to tparam.h, and make them agree with what
12973 is actually in tparam.c. The previous trick of using incompatible
12974 decls in different modules does not conform to the C standard.
12975 All callers of tparam changed to use tparam's actual API.
12976 * tparam.c (tparam1, tparam, tgoto):
12977 Use const pointers where appropriate.
12979 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12980 * cm.h (struct cm): Likewise.
12981 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12982 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12983 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12984 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12985 (turn_on_face, init_tty): Likewise.
12986 * termchar.h (struct tty_display_info): Likewise.
12988 * term.c (term_mouse_position): Rename local to avoid shadowing.
12990 * alloc.c (mark_ttys): Move decl from here ...
12991 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12993 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12995 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12997 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12999 * search.c (compile_pattern_1): Remove argument regp, unused since
13000 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13001 (compile_pattern): Don't pass it.
13003 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13005 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13006 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13008 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13010 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13012 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13013 gdk_window_get_screen, gdk_window_get_geometry,
13014 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13015 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13016 (xg_get_pixbuf_from_pixmap): New function.
13017 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13018 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13019 Call xg_get_pixbuf_from_pixmap instead of
13020 gdk_pixbuf_get_from_drawable.
13021 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13022 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13023 (xg_check_special_colors): Use GtkStyleContext and its functions
13025 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13026 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13027 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13028 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13029 Call gtk_widget_get_preferred_size.
13030 (xg_frame_resized): gdk_window_get_geometry only takes 5
13032 (xg_win_to_widget, xg_event_is_for_menubar):
13033 Call gdk_x11_window_lookup_for_display.
13034 (xg_set_widget_bg): New function.
13035 (delete_cb): New function.
13036 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13037 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13038 (xg_set_background_color): Call xg_set_widget_bg.
13039 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13040 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13041 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13042 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13044 (update_frame_tool_bar): Call gtk_widget_hide.
13045 (xg_initialize): Use GDK_KEY_g.
13047 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13049 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13051 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13052 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13053 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13055 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13057 * w32xfns.c (select_palette): Check success of RealizePalette against
13058 GDI_ERROR, not zero.
13060 See ChangeLog.11 for earlier changes.
13062 ;; Local Variables:
13066 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13068 This file is part of GNU Emacs.
13070 GNU Emacs is free software: you can redistribute it and/or modify
13071 it under the terms of the GNU General Public License as published by
13072 the Free Software Foundation, either version 3 of the License, or
13073 (at your option) any later version.
13075 GNU Emacs is distributed in the hope that it will be useful,
13076 but WITHOUT ANY WARRANTY; without even the implied warranty of
13077 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13078 GNU General Public License for more details.
13080 You should have received a copy of the GNU General Public License
13081 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.