Fix handling of pending signals in wait_reading_process_output (Bug#8869).
[bpt/emacs.git] / src / ChangeLog
1 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2
3 * process.c (wait_reading_process_output): Bypass select if
4 waiting for a cell while ignoring keyboard input, and input is
5 pending. Suggested by Jan Djärv (Bug#8869).
6
7 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8
9 Use gnulib's dup2 module instead of rolling our own.
10 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
11
12 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13
14 * dispnew.c (scrolling_window): Before scrolling, turn off a
15 mouse-highlight in the window being scrolled.
16
17 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
18
19 Move DEFSYM to lisp.h and use everywhere.
20
21 * character.h (DEFSYM): Move declaration...
22 * lisp.h (DEFSYM): ...here.
23
24 * gnutls.c:
25 * minibuf.c:
26 * w32menu.c:
27 * w32proc.c:
28 * w32select.c: Don't include character.h.
29
30 * alloc.c (syms_of_alloc):
31 * buffer.c (syms_of_buffer):
32 * bytecode.c (syms_of_bytecode):
33 * callint.c (syms_of_callint):
34 * casefiddle.c (syms_of_casefiddle):
35 * casetab.c (init_casetab_once):
36 * category.c (init_category_once, syms_of_category):
37 * ccl.c (syms_of_ccl):
38 * cmds.c (syms_of_cmds):
39 * composite.c (syms_of_composite):
40 * dbusbind.c (syms_of_dbusbind):
41 * dired.c (syms_of_dired):
42 * dispnew.c (syms_of_display):
43 * doc.c (syms_of_doc):
44 * editfns.c (syms_of_editfns):
45 * emacs.c (syms_of_emacs):
46 * eval.c (syms_of_eval):
47 * fileio.c (syms_of_fileio):
48 * fns.c (syms_of_fns):
49 * frame.c (syms_of_frame):
50 * fringe.c (syms_of_fringe):
51 * insdel.c (syms_of_insdel):
52 * keymap.c (syms_of_keymap):
53 * lread.c (init_obarray, syms_of_lread):
54 * macros.c (syms_of_macros):
55 * msdos.c (syms_of_msdos):
56 * print.c (syms_of_print):
57 * process.c (syms_of_process):
58 * search.c (syms_of_search):
59 * sound.c (syms_of_sound):
60 * syntax.c (init_syntax_once, syms_of_syntax):
61 * terminal.c (syms_of_terminal):
62 * textprop.c (syms_of_textprop):
63 * undo.c (syms_of_undo):
64 * w32.c (globals_of_w32):
65 * window.c (syms_of_window):
66 * xdisp.c (syms_of_xdisp):
67 * xfaces.c (syms_of_xfaces):
68 * xfns.c (syms_of_xfns):
69 * xmenu.c (syms_of_xmenu):
70 * xsettings.c (syms_of_xsettings):
71 * xterm.c (syms_of_xterm): Use DEFSYM.
72
73 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
74
75 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
76
77 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
78
79 Integer and buffer overflow fixes (Bug#8873).
80
81 * print.c (printchar, strout): Check for string overflow.
82 (PRINTPREPARE, printchar, strout):
83 Don't set size unless allocation succeeds.
84
85 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
86 for sizes. Check for string overflow more accurately.
87 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
88
89 * macros.c: Integer and buffer overflow fixes.
90 * keyboard.h (struct keyboard.kbd_macro_bufsize):
91 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
92 Use ptrdiff_t, not int, for sizes.
93 Don't increment bufsize until after realloc succeeds.
94 Check for size-calculation overflow.
95 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
96
97 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
98
99 * lread.c: Integer overflow fixes.
100 (read_integer): Radix is now EMACS_INT, not int,
101 to improve quality of diagnostics for out-of-range radices.
102 Calculate buffer size correctly for out-of-range radices.
103 (read1): Check for integer overflow in radices, and in
104 read-circle numbers.
105 (read_escape): Avoid int overflow.
106 (Fload, openp, read_buffer_size, read1)
107 (substitute_object_recurse, read_vector, read_list, map_obarray):
108 Use ptrdiff_t, not int, for sizes.
109 (read1): Use EMACS_INT, not int, for sizes.
110 Check for size overflow.
111
112 * image.c (cache_image): Check for size arithmetic overflow.
113
114 * lread.c: Integer overflow issues.
115 (saved_doc_string_size, saved_doc_string_length)
116 (prev_saved_doc_string_size, prev_saved_doc_string_length):
117 Now ptrdiff_t, not int.
118 (read1): Don't assume doc string length fits in int. Check for
119 out-of-range doc string lengths.
120 (read_list): Don't assume file position fits in int.
121 (read_escape): Check for hex character overflow.
122
123 2011-06-22 Leo Liu <sdl.web@gmail.com>
124
125 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
126 Move to minibuffer.el.
127
128 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
129
130 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
131 The following patches are for when GLYPH_DEBUG && !XASSERT.
132 * dispextern.h (trace_redisplay_p, dump_glyph_string):
133 * dispnew.c (flush_stdout):
134 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
135 Mark as externally visible.
136 * dispnew.c (check_window_matrix_pointers): Now static.
137 * dispnew.c (window_to_frame_vpos):
138 * xfns.c (unwind_create_frame):
139 * xterm.c (x_check_font): Remove unused local.
140 * scroll.c (CHECK_BOUNDS):
141 * xfaces.c (cache_fache): Rename local to avoid shadowing.
142 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
143 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
144 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
145 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
146 Now static.
147 (debug_method_add): Use va_list and vsprintf rather than relying
148 on undefined behavior with wrong number of arguments.
149 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
150 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
151 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
152 since we're not interested in debugging glyphs with old libraries.
153 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
154 GCC 4.6.0's static checking.
155
156 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
157
158 Integer overflow and signedness fixes (Bug#8873).
159 A few related buffer overrun fixes, too.
160
161 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
162
163 * dispextern.h (struct face.stipple):
164 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
165 (x_bitmap_mask, x_allocate_bitmap_record)
166 (x_create_bitmap_from_data, x_create_bitmap_from_file)
167 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
168 (x_create_bitmap_from_xpm_data):
169 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
170 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
171 (.bitmaps_last):
172 * xfaces.c (load_pixmap):
173 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
174 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
175 (.bitmaps_last, struct x_output.icon_bitmap):
176 Use ptrdiff_t, not int, for bitmap indexes.
177 (x_allocate_bitmap_record): Check for size overflow.
178 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
179
180 Use ptrdiff_t, not int, for overlay counts.
181 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
182 * editfns.c (overlays_around, get_pos_property):
183 * textprop.c (get_char_property_and_overlay):
184 * xdisp.c (next_overlay_change, note_mouse_highlight):
185 * xfaces.c (face_at_buffer_position):
186 * buffer.c (OVERLAY_COUNT_MAX): New macro.
187 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
188 (Fnext_overlay_change, Fprevious_overlay_change)
189 (mouse_face_overlay_overlaps, Foverlays_in):
190 Use ptrdiff_t, not int, for sizes.
191 (overlays_at, overlays_in): Check for size-calculation overflow.
192
193 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
194
195 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
196 (x_session_initialize): Do not assume string length fits in int.
197
198 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
199 This is unlikely, but can occur if DPI is outlandish.
200
201 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
202 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
203
204 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
205 * xrdb.c (magic_file_p, search_magic_path):
206 Omit last arg SUFFIX; it was always 0. All callers changed.
207 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
208
209 * xfont.c (xfont_match): Avoid need for strlen.
210
211 * xfns.c: Don't assume strlen fits in int.
212 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
213
214 * xdisp.c (message_log_check_duplicate): Return intmax_t,
215 not unsigned long, as we prefer signed integers. All callers changed.
216 Detect integer overflow in repeat count.
217 (message_dolog): Don't assume print length fits in 39 bytes.
218 (display_mode_element): Don't assume strlen fits in int.
219
220 * termcap.c: Don't assume sizes fit in int and never overflow.
221 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
222 (gobble_line): Check for size-calculation overflow.
223
224 * minibuf.c (Fread_buffer):
225 * lread.c (intern, intern_c_string):
226 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
227 Don't assume string length fits in int.
228
229 * keyboard.c (parse_tool_bar_item):
230 * gtkutil.c (style_changed_cb): Avoid need for strlen.
231
232 * font.c: Don't assume string length fits in int.
233 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
234 Use ptrdiff_t, not int.
235 (font_intern_prop): Don't assume string length fits in int.
236 Don't assume integer property fits in fixnum.
237 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
238
239 * filelock.c: Fix some buffer overrun and integer overflow issues.
240 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
241 Reformulate so as not to need the command string.
242 Invoke gzip -cd rather than gunzip, as it's more portable.
243 (lock_info_type, lock_file_1, lock_file):
244 Don't assume pid_t and time_t fit in unsigned long.
245 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
246 (current_lock_owner): Prefer signed type for sizes.
247 Use memcpy, not strncpy, where memcpy is what is really wanted.
248 Don't assume (via atoi) that time_t and pid_t fit in int.
249 Check for time_t and/or pid_t out of range, e.g., via a network share.
250 Don't alloca where an auto var works fine.
251
252 * fileio.c: Fix some integer overflow issues.
253 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
254 Don't assume string length fits in int.
255 (directory_file_name): Don't assume string length fits in long.
256 (make_temp_name): Don't assume pid fits in int, or that its print
257 length is less than 20.
258
259 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
260
261 * coding.c (make_subsidiaries): Don't assume string length fits in int.
262
263 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
264
265 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
266 We prefer signed integers, even for size calculations.
267
268 * emacs.c: Don't assume string length fits in 'int'.
269 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
270 (main): Don't invoke strlen when not needed.
271
272 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
273 (XD_DEBUG_MESSAGE): Don't waste a byte.
274
275 * callproc.c (getenv_internal_1, getenv_internal)
276 (Fgetenv_internal):
277 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
278
279 * lread.c (invalid_syntax): Omit length argument.
280 All uses changed. This doesn't fix a bug, but it simplifies the
281 code away from its former Hollerith-constant appearance, and it's
282 one less 'int' to worry about when looking at integer-overflow issues.
283 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
284
285 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
286 This didn't break anything, but it didn't help either.
287 It's confusing to put a bogus integer in a place where the actual
288 value does not matter.
289 (LIST_END_P): Remove unused macro and its bogus comment.
290 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
291
292 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
293 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
294 implementation.
295 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
296 We prefer signed types, and the value cannot exceed the EMACS_INT
297 range anyway (because otherwise the length would not be representable).
298 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
299 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
300 This avoids a GCC warning when WIDE_EMACS_INT.
301
302 * indent.c (sane_tab_width): New function.
303 (current_column, scan_for_column, Findent_to, position_indentation)
304 (compute_motion): Use it. This is just for clarity.
305 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
306
307 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
308
309 * lisp.h (lint_assume): New macro.
310 * composite.c (composition_gstring_put_cache):
311 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
312
313 * editfns.c, insdel.c:
314 Omit unnecessary forward decls, to simplify future changes.
315
316 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
317
318 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
319
320 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
321 Use much-faster test for byte-length change.
322 Don't assume string byte-length fits in 'int'.
323 Check that character arg fits in 'int'.
324 (mapcar1): Declare byte as byte, for clarity.
325
326 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
327
328 * fns.c (concat): Catch string overflow earlier.
329 Do not rely on integer wraparound.
330
331 * dispextern.h (struct it.overlay_strings_charpos)
332 (struct it.selective): Now EMACS_INT, not int.
333 * xdisp.c (forward_to_next_line_start)
334 (back_to_previous_visible_line_start)
335 (reseat_at_next_visible_line_start, next_element_from_buffer):
336 Don't arbitrarily truncate the value of 'selective' to int.
337
338 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
339
340 * composite.c: Don't truncate sizes to 'int'.
341 (composition_gstring_p, composition_reseat_it)
342 (composition_adjust_point): Use EMACS_INT, not int.
343 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
344 not EMACS_UINT, for indexes.
345
346 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
347
348 * buffer.c: Include <verify.h>.
349 (struct sortvec.priority, struct sortstr.priority):
350 Now EMACS_INT, not int.
351 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
352 (struct sortstr.size, record_overlay_string)
353 (struct sortstrlist.size, struct sortlist.used):
354 Don't truncate size to int.
355 (record_overlay_string): Check for size-calculation overflow.
356 (init_buffer_once): Check at compile-time, not run-time.
357
358 2011-06-22 Jim Meyering <meyering@redhat.com>
359
360 Don't leak an XBM-image-sized buffer
361 * image.c (xbm_load): Free the image buffer after using it.
362
363 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
364
365 Port to Sun C.
366 * composite.c (find_automatic_composition): Omit needless 'return 0;'
367 that Sun C diagnosed.
368 * fns.c (secure_hash): Fix pointer signedness issue.
369 * intervals.c (static_offset_intervals): New function.
370 (offset_intervals): Use it.
371
372 2011-06-21 Leo Liu <sdl.web@gmail.com>
373
374 * deps.mk (fns.o):
375 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
376 sha512.h.
377
378 * fns.c (secure_hash): Rename from crypto_hash_function and change
379 the first arg to accept symbols.
380 (Fsecure_hash): New primitive.
381 (syms_of_fns): New symbols.
382
383 2011-06-20 Deniz Dogan <deniz@dogan.se>
384
385 * process.c (Fset_process_buffer): Clarify return value in
386 docstring.
387
388 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
389
390 * dispnew.c (add_window_display_history): Use BVAR.
391
392 * xdisp.c (debug_method_add): Use BVAR.
393 (check_window_end, dump_glyph_matrix, dump_glyph)
394 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
395
396 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
397 Likewise.
398
399 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
400 check till after the cache is created in init_frame_faces.
401
402 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
403
404 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
405
406 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
407
408 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
409 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
410 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
411
412 Improve buffer-overflow checking (Bug#8873).
413 * fileio.c (Finsert_file_contents):
414 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
415 Remove the old (too-loose) buffer overflow checks.
416 They weren't needed, since make_gap checks for buffer overflow.
417 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
418 The old code merely checked for Emacs fixnum overflow, and relied
419 on undefined (wraparound) behavior. The new code avoids undefined
420 behavior, and also checks for ptrdiff_t and/or size_t overflow.
421
422 * editfns.c (Finsert_char): Don't dump core with very negative counts.
423 Tune. Don't use wider integers than needed. Don't use alloca.
424 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
425
426 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
427
428 * insdel.c, lisp.h (buffer_overflow): New function.
429 (insert_from_buffer_1, replace_range, replace_range_2):
430 * insdel.c (make_gap_larger):
431 * editfns.c (Finsert_char):
432 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
433
434 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
435
436 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
437
438 Integer overflow and signedness fixes (Bug#8873).
439
440 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
441 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
442
443 * fileio.c: Don't assume EMACS_INT fits in off_t.
444 (emacs_lseek): New static function.
445 (Finsert_file_contents, Fwrite_region): Use it.
446 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
447
448 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
449
450 * fns.c: Don't overflow int when computing a list length.
451 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
452 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
453 truncation on 64-bit hosts. Check for QUIT every
454 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
455 faster and is responsive enough.
456 (Flength): Report an error instead of overflowing an integer.
457 (Fsafe_length): Return a float if the value is not representable
458 as a fixnum. This shouldn't happen except in contrived situations.
459 (Fnthcdr, Fsort): Don't assume list length fits in int.
460 (Fcopy_sequence): Don't assume vector length fits in int.
461
462 * alloc.c: Check that resized vectors' lengths fit in fixnums.
463 (header_size, word_size): New constants.
464 (allocate_vectorlike): Don't check size overflow here.
465 (allocate_vector): Check it here instead, since this is the only
466 caller of allocate_vectorlike that could cause overflow.
467 Check that the new vector's length is representable as a fixnum.
468
469 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
470 The previous code was bogus. For example, next_almost_prime (32)
471 returned 39, which is undesirable as it is a multiple of 3; and
472 next_almost_prime (24) returned 25, which is a multiple of 5 so
473 why was the code bothering to check for multiples of 7?
474
475 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
476
477 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
478
479 Variadic C functions now count arguments with ptrdiff_t.
480 This partly undoes my 2011-03-30 change, which replaced int with size_t.
481 Back then I didn't know that the Emacs coding style prefers signed int.
482 Also, in the meantime I found a few more instances where arguments
483 were being counted with int, which may truncate counts on 64-bit
484 machines, or EMACS_INT, which may be unnecessarily wide.
485 * lisp.h (struct Lisp_Subr.function.aMANY)
486 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
487 Arg counts are now ptrdiff_t, not size_t.
488 All variadic functions and their callers changed accordingly.
489 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
490 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
491 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
492 * callint.c (Fcall_interactively): Check arg count for overflow,
493 to avoid potential buffer overrun. Use signed char, not 'int',
494 for 'varies' array, so that we needn't bother to check its size
495 calculation for overflow.
496 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
497 * eval.c (apply_lambda):
498 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
499 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
500 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
501
502 * callint.c (Fcall_interactively): Don't use index var as event count.
503
504 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
505 * mem-limits.h (SIZE): Remove; no longer used.
506
507 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
508
509 Remove unnecessary casts.
510 * xterm.c (x_term_init):
511 * xfns.c (x_set_border_pixel):
512 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
513 These aren't needed now that we assume ANSI C.
514
515 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
516 It's more likely to cause problems (due to unsigned overflow)
517 than to cure them.
518
519 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
520
521 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
522
523 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
524
525 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
526
527 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
528
529 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
530
531 GLYPH_CODE_FACE returns EMACS_INT, not int.
532 * dispextern.h (merge_faces):
533 * xfaces.c (merge_faces):
534 * xdisp.c (get_next_display_element, next_element_from_display_vector):
535 Don't assume EMACS_INT fits in int.
536
537 * character.h (CHAR_VALID_P): Remove unused parameter.
538 * fontset.c, lisp.h, xdisp.c: All uses changed.
539
540 * editfns.c (Ftranslate_region_internal): Omit redundant test.
541
542 * fns.c (concat): Minor tuning based on overflow analysis.
543 This doesn't fix any bugs. Use int to hold character, instead
544 of constantly refetching from Emacs object. Use XFASTINT, not
545 XINT, for value known to be a character. Don't bother comparing
546 a single byte to 0400, as it's always less.
547
548 * floatfns.c (Fexpt):
549 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
550
551 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
552 for characters.
553
554 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
555
556 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
557 Without this fix, on a 64-bit host (aset S 0 4294967386) would
558 incorrectly succeed when S was a string, because 4294967386 was
559 truncated before it was used.
560
561 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
562 Otherwise, an out-of-range integer could cause undefined behavior
563 on a 64-bit host.
564
565 * composite.c: Use int, not EMACS_INT, for characters.
566 (fill_gstring_body, composition_compute_stop_pos): Use int, not
567 EMACS_INT, for values that are known to be in character range.
568 This doesn't fix any bugs but is the usual style inside Emacs and
569 may generate better code on 32-bit machines.
570
571 Make sure a 64-bit char is never passed to ENCODE_CHAR.
572 This is for reasons similar to the recent CHAR_STRING fix.
573 * charset.c (Fencode_char): Check that character arg is actually
574 a character. Pass an int to ENCODE_CHAR.
575 * charset.h (ENCODE_CHAR): Verify that the character argument is no
576 wider than 'int', as a compile-time check to prevent future regressions
577 in this area.
578
579 * character.c (char_string): Remove unnecessary casts.
580
581 Make sure a 64-bit char is never passed to CHAR_STRING.
582 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
583 by silently ignoring the top 32 bits, allowing some values
584 that were far too large to be valid characters.
585 * character.h: Include <verify.h>.
586 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
587 arguments are no wider than unsigned, as a compile-time check
588 to prevent future regressions in this area.
589 * data.c (Faset):
590 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
591 (Fsubst_char_in_region):
592 * fns.c (concat):
593 * xdisp.c (decode_mode_spec_coding):
594 Adjust to CHAR_STRING's new requirement.
595 * editfns.c (Finsert_char, Fsubst_char_in_region):
596 * fns.c (concat): Check that character args are actually
597 characters. Without this test, these functions did the wrong
598 thing with wildly out-of-range values on 64-bit hosts.
599
600 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
601 These casts should not be needed on 32-bit hosts, either.
602 * keyboard.c (read_char):
603 * lread.c (Fload): Remove casts to unsigned.
604
605 * lisp.h (UNSIGNED_CMP): New macro.
606 This fixes comparison bugs on 64-bit hosts.
607 (ASCII_CHAR_P): Use it.
608 * casefiddle.c (casify_object):
609 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
610 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
611 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
612 * dispextern.h (FACE_FROM_ID):
613 * keyboard.c (read_char): Use UNSIGNED_CMP.
614
615 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
616 not to EMACS_INT, to avoid GCC warning.
617
618 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
619
620 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
621 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
622 isn't needed on 32-bit machines.
623
624 * buffer.c (Fgenerate_new_buffer_name):
625 Use EMACS_INT for count, not int.
626 (advance_to_char_boundary): Return EMACS_INT, not int.
627
628 * data.c (Qcompiled_function): Now static.
629
630 * window.c (window_body_lines): Now static.
631
632 * image.c (gif_load): Rename local to avoid shadowing.
633
634 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
635 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
636 * alloc.c (make_save_value): Integer argument is now of type
637 ptrdiff_t, not int.
638 (mark_object): Use ptrdiff_t, not int.
639 * lisp.h (pD): New macro.
640 * print.c (print_object): Use it.
641
642 * alloc.c: Use EMACS_INT, not int, to count objects.
643 (total_conses, total_markers, total_symbols, total_vector_size)
644 (total_free_conses, total_free_markers, total_free_symbols)
645 (total_free_floats, total_floats, total_free_intervals)
646 (total_intervals, total_strings, total_free_strings):
647 Now EMACS_INT, not int. All uses changed.
648 (Fgarbage_collect): Compute overall total using a double, so that
649 integer overflow is less likely to be a problem. Check for overflow
650 when converting back to an integer.
651 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
652 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
653 These were 'int' variables that could overflow on 64-bit hosts;
654 they were never used, so remove them instead of repairing them.
655 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
656 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
657 Previously, this ceilinged at INT_MAX, but that doesn't work on
658 64-bit machines.
659 (allocate_pseudovector): Don't use EMACS_INT when int would do.
660
661 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
662 (allocate_vectorlike): Check for ptrdiff_t overflow.
663 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
664 when a (possibly-narrower) signed value would do just as well.
665 We prefer using signed arithmetic, to avoid comparison confusion.
666
667 * alloc.c: Catch some string size overflows that we were missing.
668 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
669 for convenience in STRING_BYTES_MAX.
670 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
671 The definition here is exact; the one in lisp.h was approximate.
672 (allocate_string_data): Check for string overflow. This catches
673 some instances we weren't catching before. Also, it catches
674 size_t overflow on (unusual) hosts where SIZE_MAX <= min
675 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
676 and ptrdiff_t and EMACS_INT are both 64 bits.
677
678 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
679 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
680 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
681
682 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
683
684 * alloc.c (Fmake_string): Check for out-of-range init.
685
686 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
687
688 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
689
690 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
691
692 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
693 xg_get_default_scrollbar_width.
694
695 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
696 (int_gtk_range_get_value): Move to the scroll bar part of the file.
697 (style_changed_cb): Call update_theme_scrollbar_width and call
698 x_set_scroll_bar_default_width and xg_frame_set_char_size for
699 all frames (Bug#8505).
700 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
701 Call gtk_window_set_resizable if HAVE_GTK3.
702 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
703 and height if HAVE_GTK3 (Bug#8505).
704 (scroll_bar_width_for_theme): New variable.
705 (update_theme_scrollbar_width): New function.
706 (xg_get_default_scrollbar_width): Move code to
707 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
708 (xg_initialize): Call update_theme_scrollbar_width.
709
710 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
711
712 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
713
714 2011-06-12 Martin Rudalics <rudalics@gmx.at>
715
716 * frame.c (make_frame): Call other_buffer_safely instead of
717 other_buffer.
718
719 * window.c (temp_output_buffer_show): Call display_buffer with
720 second argument Vtemp_buffer_show_specifiers and reset latter
721 immediately after the call.
722 (Vtemp_buffer_show_specifiers): New variable.
723 (auto_window_vscroll_p, next_screen_context_lines)
724 (Vscroll_preserve_screen_position): Remove leading asterisks from
725 doc-strings.
726
727 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
728
729 Fix minor problems found by GCC 4.6.0 static checking.
730 * buffer.c (Qclone_number): Remove for now, as it's unused.
731 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
732 (record_buffer): Remove unused local.
733 * frame.c (other_visible_frames, frame_buffer_list): Now static.
734 (set_frame_buffer_list): Remove; unused.
735 * frame.h (other_visible_frames): Remove decl.
736 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
737 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
738 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
739 if HAVE_GPM.
740 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
741 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
742 Define only if HAVE_GPM.
743 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
744 (update_hints_inhibit): Remove; never set. All uses removed.
745 * widgetprv.h (emacsFrameClassRec): Remove decl.
746 * window.c (delete_deletable_window): Now returns void, since it
747 wasn't returning anything.
748 (compare_window_configurations): Remove unused locals.
749 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
750 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
751 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
752 the same widths as pointers. This follows up on the 2011-05-06 patch.
753 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
754 * xterm.h: Likewise.
755 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
756
757 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
758
759 * makefile.w32-in: Update dependencies.
760 (LISP_H): Add lib/intprops.h.
761
762 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
763
764 * image.c (gif_load): Add animation frame delay to the metadata.
765 (syms_of_image): Use DEFSYM. New symbol `delay'.
766
767 2011-06-11 Martin Rudalics <rudalics@gmx.at>
768
769 * window.c (delete_deletable_window): Re-add.
770 (Fset_window_configuration): Rewrite to handle dead buffers and
771 consequently deletable windows.
772 (window_tree, Fwindow_tree): Remove. Supply functionality in
773 window.el.
774 (compare_window_configurations): Simplify code.
775
776 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
777
778 * image.c (imagemagick_load_image): Fix type mismatch.
779 (Fimagemagick_types): Likewise.
780
781 * window.h (replace_buffer_in_windows): Declare.
782
783 2011-06-11 Martin Rudalics <rudalics@gmx.at>
784
785 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
786 Qclone_number. Remove external declaration of Qdelete_window.
787 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
788 code.
789 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
790 Qbuffer_list_update_hook if allowed.
791 (Fother_buffer): Rewrite doc-string. Major rewrite for new
792 buffer list implementation.
793 (other_buffer_safely): New function.
794 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
795 calls to replace_buffer_in_windows and
796 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
797 if allowed.
798 (record_buffer): Inhibit quitting and rewrite using quittable
799 functions. Run Qbuffer_list_update_hook if allowed.
800 (Frecord_buffer, Funrecord_buffer): New functions.
801 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
802 switch-to-buffer to window.el.
803 (bury-buffer): Move to window.el.
804 (Vbuffer_list_update_hook): New variable.
805
806 * lisp.h (other_buffer_safely): Add prototype in buffer.c
807 section.
808
809 * window.h (resize_frame_windows): Move up in code.
810 (Fwindow_frame): Remove EXFUN.
811 (replace_buffer_in_all_windows): Remove prototype.
812 (replace_buffer_in_windows_safely): Add prototype.
813
814 * window.c: Declare Qdelete_window static again. Move down
815 declaration of select_count.
816 (Fnext_window, Fprevious_window): Rewrite doc-strings.
817 (Fother_window): Move to window.el.
818 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
819 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
820 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
821 window.el.
822 (replace_buffer_in_windows): Implement by calling
823 Qreplace_buffer_in_windows.
824 (replace_buffer_in_all_windows): Remove with some functionality
825 moved into replace_buffer_in_windows_safely.
826 (replace_buffer_in_windows_safely): New function.
827 (select_window_norecord, select_frame_norecord): Move in front
828 of run_window_configuration_change_hook. Remove now obsolete
829 declarations.
830 (Fset_window_buffer): Rewrite doc-string. Call
831 Qrecord_window_buffer.
832 (keys_of_window): Move binding for other-window to window.el.
833
834 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
835
836 * dispextern.h (struct image): Replace data member, whose int_val
837 and ptr_val fields were not used by anything, with a single
838 lisp_val object.
839
840 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
841 (gif_clear_image, gif_load, imagemagick_load_image)
842 (gs_clear_image, gs_load): Callers changed.
843
844 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
845
846 * buffer.h: Include <time.h>, for time_t.
847 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
848
849 Fix minor problems found by static checking.
850
851 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
852
853 Make identifiers static if they are not used in other modules.
854 * data.c (Qcompiled_function, Qframe, Qvector):
855 * image.c (QimageMagick, Qsvg):
856 * minibuf.c (Qmetadata):
857 * window.c (resize_window_check, resize_root_window): Now static.
858 * window.h (resize_window_check, resize_root_window): Remove decls.
859
860 * window.c (window_deletion_count, delete_deletable_window):
861 Remove; unused.
862 (window_body_lines): Now static.
863 (Fdelete_other_windows_internal): Mark vars as initialized.
864 Make sure 'resize_failed' is initialized.
865 (run_window_configuration_change_hook): Rename local to avoid shadowing.
866 (resize_window_apply): Remove unused local.
867 * window.h (delete_deletable_window): Remove decl.
868
869 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
870 (imagemagick_load_image): Fix pointer signedness problem by changing
871 last arg from unsigned char * to char *. All uses changed.
872 Also, fix a local for similar reasons.
873 Remove unused locals. Remove locals to avoid shadowing.
874 (fn_rsvg_handle_free): Remove; unused.
875 (svg_load, svg_load_image): Fix pointer signedness problem.
876 (imagemagick_load_image): Don't use garbage pointer image_wand.
877
878 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
879
880 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
881
882 * image.c (gif_load): Fix omitted cast error introduced by
883 2011-06-06 change.
884
885 2011-06-10 Martin Rudalics <rudalics@gmx.at>
886
887 * window.h (resize_proportionally, orig_total_lines)
888 (orig_top_line): Remove from window structure.
889 (set_window_height, set_window_width, change_window_heights)
890 (Fdelete_window): Remove prototypes.
891 (resize_frame_windows): Remove duplicate declaration.
892
893 2011-06-10 Eli Zaretskii <eliz@gnu.org>
894
895 * window.h (resize_frame_windows, resize_window_check)
896 (delete_deletable_window, resize_root_window)
897 (resize_frame_windows): Declare prototypes.
898
899 * window.c (resize_window_apply): Make definition be "static" to
900 match the prototype.
901
902 2011-06-10 Martin Rudalics <rudalics@gmx.at>
903
904 * window.c: Remove declarations of Qwindow_size_fixed,
905 window_min_size_1, window_min_size_2, window_min_size,
906 size_window, window_fixed_size_p, enlarge_window, delete_window.
907 Remove static from declaration of Qdelete_window, it's
908 temporarily needed by Fbury_buffer.
909 (replace_window): Don't assign orig_top_line and
910 orig_total_lines.
911 (Fdelete_window, delete_window): Remove. Window deletion is
912 handled by window.el.
913 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
914 Fdelete_window calls with calls to Qdelete_window.
915 (Fdelete_other_windows): Remove. Deleting other windows is
916 handled by window.el.
917 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
918 handled in window.el.
919 (window_min_size_2, window_min_size_1, window_min_size): Remove.
920 Window minimum sizes are handled in window.el.
921 (shrink_windows, size_window, set_window_height)
922 (set_window_width, change_window_heights, window_height)
923 (window_width, CURBEG, CURSIZE, enlarge_window)
924 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
925 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
926 handled in window.el.
927 (make_dummy_parent): Rename to make_parent_window and give it a
928 second argument horflag.
929 (make_window): Don't set resize_proportionally any more.
930 (Fsplit_window): Remove. Windows are split in window.el.
931 (save_restore_action, save_restore_orig_size)
932 (shrink_window_lowest_first, save_restore_orig_size): Remove.
933 Resize mini windows in window.el.
934 (grow_mini_window, shrink_mini_window): Implement by calling
935 Qresize_root_window_vertically, resize_window_check and
936 resize_window_apply.
937 (saved_window, Fset_window_configuration, save_window_save): Do
938 not handle orig_top_line, orig_total_lines, and
939 resize_proportionally.
940 (window_min_height, window_min_width): Move to window.el.
941 (keys_of_window): Move bindings for delete-other-windows,
942 split-window, delete-window and enlarge-window to window.el.
943
944 * buffer.c: Temporarily extern Qdelete_window.
945 (Fbury_buffer): Temporarily call Qdelete_window instead of
946 Fdelete_window (Fbury_buffer will move to window.el soon).
947
948 * frame.c (set_menu_bar_lines_1): Remove code handling
949 orig_top_line and orig_total_lines.
950
951 * dispnew.c (adjust_frame_glyphs_initially): Don't use
952 set_window_height but set heights directly.
953 (change_frame_size_1): Use resize_frame_windows.
954
955 * xdisp.c (init_xdisp): Don't use set_window_height but set
956 heights directly.
957
958 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
959 resize_frame_windows instead of change_window_heights and run
960 run_window_configuration_change_hook.
961
962 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
963 instead of change_window_heights and run
964 run_window_configuration_change_hook.
965
966 2011-06-09 Martin Rudalics <rudalics@gmx.at>
967
968 * window.c (replace_window): Rename second argument REPLACEMENT to
969 NEW. New third argument SETFLAG. Rewrite.
970 (delete_window, make_dummy_parent): Call replace_window with
971 third argument 1.
972 (window_list_1): Move down in code.
973 (run_window_configuration_change_hook): Move set_buffer part
974 before select_frame_norecord part in order to unwind correctly.
975 Rename count1 to count.
976 (recombine_windows, delete_deletable_window, resize_root_window)
977 (Fdelete_other_windows_internal)
978 (Frun_window_configuration_change_hook, make_parent_window)
979 (resize_window_check, resize_window_apply, Fresize_window_apply)
980 (resize_frame_windows, Fsplit_window_internal)
981 (Fdelete_window_internal, Fresize_mini_window_internal): New
982 functions.
983 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
984
985 2011-06-08 Martin Rudalics <rudalics@gmx.at>
986
987 * window.h (window): Add some new members to window structure -
988 normal_lines, normal_cols, new_total, new_normal, clone_number,
989 splits, nest, prev_buffers, next_buffers.
990 (WINDOW_TOTAL_SIZE): Move here from window.c.
991 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
992
993 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
994 Remove.
995 (make_dummy_parent): Set new members of windows structure.
996 (make_window): Move down in code. Handle new members of window
997 structure.
998 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
999 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1000 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1001 (Fset_window_prev_buffers, Fwindow_next_buffers)
1002 (Fset_window_next_buffers, Fset_window_clone_number): New
1003 functions.
1004 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1005 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1006 Doc-string fixes.
1007 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1008 Argument WINDOW can be now internal window too.
1009 (Fwindow_use_time): Move up in code.
1010 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1011 Rewrite doc-string.
1012 (Fset_window_configuration, saved_window)
1013 (Fcurrent_window_configuration, save_window_save): Handle new
1014 members of window structure.
1015 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1016 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1017 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1018 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1019 Qget_mru_window, Qresize_root_window,
1020 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1021 Qauto_buffer_name; staticpro them.
1022
1023 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1024
1025 * window.c (Fwindow_total_size, Fwindow_left_column)
1026 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1027 (Fwindow_list_1): New functions.
1028 (window_box_text_cols): Replace with window_body_cols.
1029 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1030 window_body_cols instead of window_box_text_cols.
1031 (delete_window, Fset_window_configuration): Call
1032 delete_all_subwindows with window as argument.
1033 (delete_all_subwindows): Take a window as argument and not a
1034 structure. Rewrite.
1035 (window_loop): Remove handling of GET_LRU_WINDOW and
1036 GET_LARGEST_WINDOW.
1037 (Fget_lru_window, Fget_largest_window): Move to window.el.
1038
1039 * window.h: Extern window_body_cols instead of
1040 window_box_text_cols. delete_all_subwindows now takes a
1041 Lisp_Object as argument.
1042
1043 * indent.c (compute_motion, Fcompute_motion): Use
1044 window_body_cols instead of window_box_text_cols.
1045
1046 * frame.c (delete_frame): Call delete_all_subwindows with root
1047 window as argument.
1048
1049 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1050
1051 * fns.c (Fputhash): Document return value.
1052
1053 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1054
1055 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1056
1057 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 Cons<->int and similar integer overflow fixes (Bug#8794).
1060
1061 Check for overflow when converting integer to cons and back.
1062 * charset.c (Fdefine_charset_internal, Fdecode_char):
1063 Use cons_to_unsigned to catch overflow.
1064 (Fencode_char): Use INTEGER_TO_CONS.
1065 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1066 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1067 * data.c (long_to_cons, cons_to_long): Remove.
1068 (cons_to_unsigned, cons_to_signed): New functions.
1069 These signal an error for invalid or out-of-range values.
1070 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1071 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1072 * font.c (Ffont_variation_glyphs):
1073 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1074 * lisp.h: Include <intprops.h>.
1075 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1076 (cons_to_signed, cons_to_unsigned): New decls.
1077 (long_to_cons, cons_to_long): Remove decls.
1078 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1079 (Fprimitive_undo): Use CONS_TO_INTEGER.
1080 * xfns.c (Fx_window_property): Likewise.
1081 * xselect.c: Include <limits.h>.
1082 (x_own_selection, selection_data_to_lisp_data):
1083 Use INTEGER_TO_CONS.
1084 (x_handle_selection_request, x_handle_selection_clear)
1085 (x_get_foreign_selection, Fx_disown_selection_internal)
1086 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1087 (lisp_data_to_selection_data): Use cons_to_unsigned.
1088 (x_fill_property_data): Use cons_to_signed.
1089 Report values out of range.
1090
1091 Check for buffer and string overflow more precisely.
1092 * buffer.h (BUF_BYTES_MAX): New macro.
1093 * lisp.h (STRING_BYTES_MAX): New macro.
1094 * alloc.c (Fmake_string):
1095 * character.c (string_escape_byte8):
1096 * coding.c (coding_alloc_by_realloc):
1097 * doprnt.c (doprnt):
1098 * editfns.c (Fformat):
1099 * eval.c (verror):
1100 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1101 since they may not be the same number.
1102 * editfns.c (Finsert_char):
1103 * fileio.c (Finsert_file_contents):
1104 Likewise for BUF_BYTES_MAX.
1105
1106 * image.c: Use ptrdiff_t, not int, for sizes.
1107 (slurp_file): Switch from int to ptrdiff_t.
1108 All uses changed.
1109 (slurp_file): Check that file size fits in both size_t (for
1110 malloc) and ptrdiff_t (for sanity and safety).
1111
1112 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1113 if b->modtime has its maximal value.
1114
1115 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1116
1117 Don't assume time_t can fit into int.
1118 * buffer.h (struct buffer.modtime): Now time_t, not int.
1119 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1120 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1121
1122 Minor fixes for signed vs unsigned integers.
1123 * character.h (MAYBE_UNIFY_CHAR):
1124 * charset.c (maybe_unify_char):
1125 * keyboard.c (read_char, reorder_modifiers):
1126 XINT -> XFASTINT, since the integer must be nonnegative.
1127 * ftfont.c (ftfont_spec_pattern):
1128 * keymap.c (access_keymap, silly_event_symbol_error):
1129 XUINT -> XFASTINT, since the integer must be nonnegative.
1130 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1131 since it makes no difference and we prefer signed.
1132 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1133 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1134 nonnegative.
1135
1136 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1137
1138 * window.h (Fwindow_frame): Declare.
1139
1140 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1143 (SPARE_MEMORY): Always define.
1144 (LARGE_REQUEST): Remove.
1145 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1146
1147 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1148
1149 * lisp.h: Move EXFUNS for Fframe_root_window,
1150 Fframe_first_window and Fset_frame_selected_window to window.h.
1151
1152 * window.h: Move EXFUNS for Fframe_root_window,
1153 Fframe_first_window and Fset_frame_selected_window here from
1154 lisp.h.
1155
1156 * frame.c (Fwindow_frame, Fframe_first_window)
1157 (Fframe_root_window, Fframe_selected_window)
1158 (Fset_frame_selected_window): Move to window.c.
1159 (Factive_minibuffer_window): Move to minibuf.c.
1160 (Fother_visible_frames_p): New function.
1161
1162 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1163
1164 * window.c (decode_window, decode_any_window): Move up in code.
1165 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1166 (inhibit_frame_unsplittable): Remove unused variable.
1167 (Fwindow_buffer): Move up and rewrite doc-string.
1168 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1169 (Fwindow_prev): New functions.
1170 (Fwindow_frame): Move here from frame.c. Accept any window as
1171 argument.
1172 (Fframe_root_window, Fframe_first_window)
1173 (Fframe_selected_window): Move here from frame.c. Accept frame
1174 or arbitrary window as argument. Update doc-strings.
1175 (Fminibuffer_window): Move up in code.
1176 (Fwindow_minibuffer_p): Move up in code and simplify.
1177 (Fset_frame_selected_window): Move here from frame.c.
1178 Marginal rewrite.
1179 (Fselected_window, select_window, Fselect_window): Move up in
1180 code. Minor doc-string fixes.
1181
1182 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1183
1184 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1185 Do not assume that spare memory exists; that assumption is valid
1186 only if SYSTEM_MALLOC.
1187 (LARGE_REQUEST): New macro, so that the issue of large requests
1188 is separated from the issue of spare memory.
1189
1190 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1191
1192 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1193 format. (Bug#8806)
1194
1195 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1196
1197 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1198 before statements.
1199
1200 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1201
1202 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1203
1204 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1205
1206 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1207 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1208
1209 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1210
1211 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1212
1213 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1214
1215 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1216 (x_clipboard_manager_save): Add return value.
1217 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1218 New error handlers.
1219 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1220 Obey Vx_select_enable_clipboard_manager. Catch errors in
1221 x_clipboard_manager_save (Bug#8779).
1222 (Vx_select_enable_clipboard_manager): New variable.
1223 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1224
1225 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1226
1227 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1228
1229 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1230
1231 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1232 in the current matrix if keep_current_p is non-zero.
1233
1234 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1235
1236 * bidi.c (bidi_level_of_next_char): Fix last change.
1237
1238 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1239
1240 Support bidi reordering of text covered by display properties.
1241
1242 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1243 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1244 (bidi_cache_search, bidi_cache_iterator_state)
1245 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1246 (bidi_level_of_next_char, bidi_move_to_visually_next):
1247 Support character positions inside a run of characters covered by a
1248 display string.
1249 (bidi_paragraph_init, bidi_resolve_explicit_1)
1250 (bidi_level_of_next_char): Call bidi_fetch_char and
1251 bidi_fetch_char_advance instead of FETCH_CHAR and
1252 FETCH_CHAR_ADVANCE.
1253 (bidi_init_it): Initialize new members.
1254 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1255 definitions.
1256 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1257 instead of using explicit *_CHAR codes.
1258 (bidi_resolve_explicit, bidi_resolve_weak):
1259 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1260 bidirectional text is supported only in multibyte buffers.
1261 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1262 it to initialize the frame_window_p member of struct bidi_it.
1263 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1264 (bidi_resolve_explicit, bidi_resolve_weak)
1265 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1266 bidi_it->nchars is non-positive.
1267 (bidi_level_of_next_char): Don't try to lookup the cache for the
1268 next/previous character if nothing is cached there yet, or if we
1269 were just reseat()'ed to a new position.
1270
1271 * xdisp.c (set_cursor_from_row): Set start and stop points
1272 according to the row's direction when priming the loop that looks
1273 for the glyph on which to display cursor.
1274 (single_display_spec_intangible_p): Function deleted.
1275 (display_prop_intangible_p): Reimplement to call
1276 handle_display_spec instead of single_display_spec_intangible_p.
1277 Accept 3 additional arguments needed by handle_display_spec.
1278 This fixes incorrect cursor motion across display property with complex
1279 values: lists, `(when COND...)' forms, etc.
1280 (single_display_spec_string_p): Support property values that are
1281 lists with the argument STRING its top-level element.
1282 (display_prop_string_p): Fix the condition for processing a
1283 property that is a list to be consistent with handle_display_spec.
1284 (handle_display_spec): New function, refactored from the
1285 last portion of handle_display_prop.
1286 (compute_display_string_pos): Accept additional argument
1287 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1288 value of a `display' property is a "replacing spec".
1289 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1290 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1291 the display property, but just return a value indicating whether
1292 the display property will replace the characters it covers.
1293 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1294 frame_window_p members of struct bidi_it.
1295 (compute_display_string_pos, compute_display_string_end):
1296 New functions.
1297 (push_it): Accept second argument POSITION, where pop_it should
1298 jump to continue iteration.
1299 (reseat_1): Initialize bidi_it.disp_pos.
1300
1301 * keyboard.c (adjust_point_for_property): Adjust the call to
1302 display_prop_intangible_p to its new signature.
1303
1304 * dispextern.h (struct bidi_it): New member frame_window_p.
1305 (bidi_init_it): Update prototypes.
1306 (display_prop_intangible_p): Update prototype.
1307 (compute_display_string_pos, compute_display_string_end):
1308 Declare prototypes.
1309 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1310 EMACS_INT.
1311
1312 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 Malloc failure behavior now depends on size of allocation.
1315 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1316 * lisp.h: Change signatures accordingly.
1317 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1318 All callers changed. (Bug#8762)
1319
1320 * gnutls.c: Use Emacs's memory allocators.
1321 Without this change, the gnutls library would invoke malloc etc.
1322 directly, which causes problems on non-SYNC_INPUT hosts, and which
1323 runs afoul of improving memory_full behavior. (Bug#8761)
1324 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1325 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1326 xfree instead of the default malloc, realloc, free.
1327 (Fgnutls_boot): No need to check for memory allocation failure,
1328 since xmalloc does that for us.
1329
1330 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1331 * category.c (hash_get_category_set):
1332 * ccl.c (ccl_driver):
1333 * charset.c (Fdefine_charset_internal):
1334 * charset.h (struct charset.hash_index):
1335 * composite.c (get_composition_id, gstring_lookup_cache)
1336 (composition_gstring_put_cache):
1337 * composite.h (struct composition.hash_index):
1338 * dispextern.h (struct image.hash):
1339 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1340 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1341 (hashfn_equal, hashfn_user_defined, make_hash_table)
1342 (maybe_resize_hash_table, hash_lookup, hash_put)
1343 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1344 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1345 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1346 * image.c (make_image, search_image_cache, lookup_image)
1347 (xpm_put_color_table_h):
1348 * lisp.h (struct Lisp_Hash_Table):
1349 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1350 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1351 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1352 * alloc.c (allocate_vectorlike):
1353 Check for overflow in vector size calculations.
1354 * ccl.c (ccl_driver):
1355 Check for overflow when converting EMACS_INT to int.
1356 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1357 need to be updated by these changes.
1358 * fns.c (make_hash_table, maybe_resize_hash_table):
1359 Check for integer overflow with large hash tables.
1360 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1361 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1362 (SXHASH_REDUCE): New macro.
1363 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1364 Use it instead of discarding useful hash info with large hash values.
1365 (sxhash_float): New function.
1366 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1367 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1368 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1369 Rewrite to use FIXNUM_BITS, as this simplifies things.
1370 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1371 Adjust signatures to match updated version of code.
1372 (consing_since_gc): Now EMACS_INT, since a single hash table can
1373 use more than INT_MAX bytes.
1374
1375 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1376
1377 Make it possible to build with GCC-4.6+ -O2 -flto.
1378
1379 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1380
1381 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1382
1383 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1384 Call minibuffer-inactive-mode.
1385
1386 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1387
1388 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1389 Update dependencies.
1390
1391 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1392
1393 * data.c (init_data): Remove code for UTS, this system is not
1394 supported anymore.
1395
1396 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1397
1398 Don't force ./temacs to start in terminal mode.
1399
1400 * frame.c (make_initial_frame): Initialize faces in all cases, not
1401 only when CANNOT_DUMP is defined.
1402 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1403
1404 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1405
1406 * dispnew.c (add_window_display_history): Use const for the string
1407 pointer. Remove declaration, not needed.
1408
1409 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 Use 'inline', not 'INLINE'.
1412 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1413 * alloc.c, fontset.c (INLINE): Remove.
1414 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1415 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1416 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1417 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1418 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1419
1420 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1421
1422 Make it possible to run ./temacs.
1423
1424 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1425 syms_of_callproc does the same thing. Remove test for
1426 "initialized", do it in the caller.
1427 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1428
1429 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1430
1431 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1432 (read_minibuf): Use get_minibuffer.
1433 (syms_of_minibuf): Use DEFSYM.
1434 (Qmetadata): New var.
1435 * data.c (Qbuffer): Don't make it static.
1436 (syms_of_data): Use DEFSYM.
1437
1438 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1439
1440 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1441 (CCL_CODE_MIN): New macro.
1442
1443 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1446
1447 * eval.c (Qdebug): Now static.
1448 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1449 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1450 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1451
1452 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1453
1454 * image.c: Various fixes to ImageMagick code comments.
1455 (Fimagemagick_types): Doc fix.
1456
1457 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1458
1459 Minor fixes prompted by GCC 4.6.0 warnings.
1460
1461 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1462
1463 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1464 (x_clipboard_manager_save_all): Move extern decl to ...
1465 * xterm.h: ... here, so that it can be checked for consistency.
1466
1467 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1468
1469 * xselect.c (x_clipboard_manager_save_frame)
1470 (x_clipboard_manager_save_all): New functions.
1471 (Fx_clipboard_manager_save): Lisp function deleted.
1472
1473 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1474 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1475
1476 * xterm.h: Update prototype.
1477
1478 2011-05-28 William Xu <william.xwl@gmail.com>
1479
1480 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1481 exiting (Bug#8239).
1482
1483 2011-05-28 Jim Meyering <meyering@redhat.com>
1484
1485 Avoid a sign-extension bug in crypto_hash_function.
1486 * fns.c (to_uchar): Define.
1487 (crypto_hash_function): Use it to convert some newly-signed
1488 variables to unsigned, to avoid sign-extension bugs. For example,
1489 without this change, (md5 "truc") would evaluate to
1490 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1491 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1492 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1493
1494 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1495
1496 Integer overflow fixes.
1497
1498 * dbusbind.c: Serial number integer overflow fixes.
1499 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1500 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1501 to hold a serial number that is too large for a fixnum.
1502 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1503 Check for serial numbers out of range. Decode any serial number
1504 that was so large that it became a float. (Bug#8722)
1505
1506 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1507 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1508 Use XFASTINT rather than XUINT when numbers are nonnegative.
1509 (xd_append_arg, Fdbus_method_return_internal):
1510 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1511 arguments, check that Lisp number is nonnegative, rather than
1512 silently wrapping negative numbers around. (Bug#8722)
1513 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1514 (Bug#8722)
1515
1516 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1517
1518 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1519
1520 ccl: add integer overflow checks
1521 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1522 (IN_INT_RANGE): New macros.
1523 (ccl_driver): Use them to check for integer overflow when
1524 decoding a CCL program. Many of the new checks are whether XINT (x)
1525 fits in int; it doesn't always, on 64-bit hosts. The new version
1526 doesn't catch all possible integer overflows, but it's an
1527 improvement. (Bug#8719)
1528
1529 * alloc.c (make_event_array): Use XINT, not XUINT.
1530 There's no need for unsigned here.
1531
1532 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1533 This follows up to the 2011-05-06 change that substituted uintptr_t
1534 for EMACS_INT. This case wasn't caught back then.
1535
1536 Rework Fformat to avoid integer overflow issues.
1537 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1538 now (part of C89). Include <verify.h>.
1539 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1540 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1541 (Fformat): Avoid the prepass trying to compute sizes; it was only
1542 approximate and thus did not catch overflow reliably. Instead, walk
1543 through the format just once, formatting and computing sizes as we go,
1544 checking for integer overflow at every step, and allocating a larger
1545 buffer as needed. Keep track separately whether the format is
1546 multibyte. Keep only the most-recently calculated precision, rather
1547 than them all. Record whether each argument has been converted to
1548 string. Use EMACS_INT, not int, for byte and char and arg counts.
1549 Support field widths and precisions larger than INT_MAX. Avoid
1550 sprintf's undefined behavior with conversion specifications such as %#d
1551 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1552 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1553 formatting out-of-range floating point numbers with int
1554 formats. (Bug#8668)
1555
1556 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1557
1558 * data.c: Avoid integer truncation in expressions involving floats.
1559 * data.c: Include <intprops.h>.
1560 (arith_driver): When there's an integer overflow in an expression
1561 involving floating point, convert the integers to floating point
1562 so that the resulting value does not suffer from catastrophic
1563 integer truncation. For example, on a 64-bit host (* 4
1564 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1565 Do not rely on undefined behavior after integer overflow.
1566
1567 merge count_size_as_multibyte, parse_str_to_multibyte
1568 * character.c, character.h (count_size_as_multibyte):
1569 Rename from parse_str_to_multibyte; all uses changed.
1570 Check for integer overflow.
1571 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1572 since it's now a duplicate of the other. This is more of
1573 a character than a buffer op, so better that it's in character.c.
1574 * fns.c, print.c: Adjust to above changes.
1575
1576 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1577
1578 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1579
1580 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1581
1582 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1583 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1584 (x_clipboard_manager_save): Now static.
1585 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1586
1587 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1588 (crypto_hash_function): Now static.
1589 Fix pointer signedness problems. Avoid unnecessary initializations.
1590
1591 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1592
1593 * termhooks.h (Vselection_alist): Make it terminal-local.
1594
1595 * terminal.c (create_terminal): Initialize it.
1596
1597 * xselect.c: Support for clipboard managers.
1598 (Vselection_alist): Move to termhooks.h as terminal-local var.
1599 (LOCAL_SELECTION): New macro.
1600 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1601 (symbol_to_x_atom): Remove gratuitous arg.
1602 (x_handle_selection_request, lisp_data_to_selection_data)
1603 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1604 (x_own_selection, x_get_local_selection, x_convert_selection):
1605 New arg, specifying work frame. Use terminal-local Vselection_alist.
1606 (some_frame_on_display): Delete unused function.
1607 (Fx_own_selection_internal, Fx_get_selection_internal)
1608 (Fx_disown_selection_internal, Fx_selection_owner_p)
1609 (Fx_selection_exists_p): New optional frame arg.
1610 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1611 (x_handle_selection_clear): Don't treat other terminals with the
1612 same keyboard specially. Use the terminal-local Vselection_alist.
1613 (x_clear_frame_selections): Use Frun_hook_with_args.
1614
1615 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1616
1617 * xterm.h: Add support for those atoms.
1618
1619 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1620
1621 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1622 (converted_selections, conversion_fail_tag): New global variables.
1623 (x_selection_request_lisp_error): Free the above.
1624 (x_get_local_selection): Remove unnecessary code.
1625 (x_reply_selection_request): Args changed; handle arbitrary array
1626 of converted selections stored in converted_selections.
1627 Separate the XChangeProperty and SelectionNotify steps.
1628 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1629 (x_convert_selection): New function.
1630 (x_handle_selection_event): Simplify.
1631 (x_get_foreign_selection): Don't ignore incoming requests while
1632 waiting for an answer; this will fail when we implement
1633 SAVE_TARGETS, and seems unnecessary anyway.
1634 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1635 (Vx_sent_selection_functions): Doc fix.
1636
1637 2011-05-26 Leo Liu <sdl.web@gmail.com>
1638
1639 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1640
1641 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1642
1643 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1644
1645 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1646 for fringe update if it has periodic bitmap.
1647 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1648 and fringe_bitmap_periodic_p.
1649
1650 * fringe.c (get_fringe_bitmap_data): New function.
1651 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1652 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1653 row. Mark glyph row for fringe update if periodicity changed.
1654
1655 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1656 for fringe update unless it has periodic bitmap.
1657
1658 2011-05-25 Kenichi Handa <handa@m17n.org>
1659
1660 * xdisp.c (get_next_display_element): Set correct it->face_id for
1661 a static composition.
1662
1663 2011-05-24 Leo Liu <sdl.web@gmail.com>
1664
1665 * deps.mk (fns.o):
1666 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1667
1668 * fns.c (crypto_hash_function, Fsha1): New function.
1669 (Fmd5): Use crypto_hash_function.
1670 (syms_of_fns): Add Ssha1.
1671
1672 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 * gnutls.c: Remove unused macros.
1675 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1676 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1677 Remove macros that are defined and never used.
1678 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1679
1680 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1681
1682 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1683 (Fx_get_selection_internal): Minor cleanup.
1684 (Fx_own_selection_internal): Rename arguments for consistency with
1685 select.el.
1686
1687 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1690
1691 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1692
1693 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1694
1695 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1696
1697 * dispnew.c (scrolling_window): Don't exclude the case that the
1698 last enabled row in the desired matrix touches the bottom boundary.
1699
1700 2011-05-21 Glenn Morris <rgm@gnu.org>
1701
1702 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1703 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1704 and add some more files.
1705
1706 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1707
1708 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1709 report_file_error introduced by the change from 2011-05-07.
1710
1711 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 * systime.h (Time): Define only if emacs is defined.
1714 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1715 where the include path doesn't have X11/X.h by default. See
1716 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1717
1718 2011-05-20 Kenichi Handa <handa@m17n.org>
1719
1720 * composite.c (find_automatic_composition): Fix previous change.
1721
1722 2011-05-20 Glenn Morris <rgm@gnu.org>
1723
1724 * lisp.mk: New file, split from Makefile.in.
1725 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1726 (shortlisp): Remove.
1727 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1728
1729 2011-05-19 Glenn Morris <rgm@gnu.org>
1730
1731 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1732 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1733 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1734 (lisp): Set the order to that of loadup.el.
1735 (shortlisp): Make it a copy of $lisp.
1736 (SOME_MACHINE_LISP): Remove.
1737 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1738 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1739
1740 2011-05-18 Kenichi Handa <handa@m17n.org>
1741
1742 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1743 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1744 (find_automatic_composition): Mostly rewrite for efficiency.
1745
1746 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1747
1748 * makefile.w32-in: Update dependencies.
1749
1750 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1751
1752 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1753 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1754
1755 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1756
1757 Fix some integer overflow issues, such as string length overflow.
1758
1759 * insdel.c (count_size_as_multibyte): Check for string overflow.
1760
1761 * character.c (lisp_string_width): Check for string overflow.
1762 Use EMACS_INT, not int, for string indexes and lengths; in
1763 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1764 the resulting string length overflows an EMACS_INT; instead,
1765 report a string overflow if no precision given. When checking for
1766 precision exhaustion, use a check that cannot possibly have
1767 integer overflow. (Bug#8675)
1768 * character.h (lisp_string_width): Adjust to new signature.
1769
1770 * alloc.c (string_overflow): New function.
1771 (Fmake_string): Use it. This doesn't change behavior, but saves
1772 a few bytes and will simplify future changes.
1773 * character.c (string_escape_byte8): Likewise.
1774 * lisp.h (string_overflow): New decl.
1775
1776 Fixups, following up to the user-interface timestamp change.
1777 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1778 for UI timestamps, instead of unsigned long.
1779 * msdos.c (mouse_get_pos): Likewise.
1780 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1781 * w32gui.h (Time): Define by including "systime.h" rather than by
1782 declaring it ourselves. (Bug#8664)
1783
1784 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1785 * image.c (clear_image_cache): Likewise.
1786
1787 * term.c (term_mouse_position): Don't assume time_t wraparound.
1788
1789 Be more systematic about user-interface timestamps.
1790 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1791 and sometimes 'EMACS_UINT', to represent these timestamps.
1792 This change causes it to use 'Time' uniformly, as that's what X uses.
1793 This makes the code easier to follow, and makes it easier to catch
1794 integer overflow bugs such as Bug#8664.
1795 * frame.c (Fmouse_position, Fmouse_pixel_position):
1796 Use Time, not unsigned long, for user-interface timestamps.
1797 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1798 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1799 * keyboard.h (last_event_timestamp): Likewise.
1800 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1801 * menu.h (xmenu_show): Likewise.
1802 * term.c (term_mouse_position): Likewise.
1803 * termhooks.h (struct input_event.timestamp): Likewise.
1804 (struct terminal.mouse_position_hook): Likewise.
1805 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1806 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1807 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1808 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1809 what it was before.
1810 * menu.h, termhooks.h: Include "systime.h", for Time.
1811
1812 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1813 Don't assume that the difference between two unsigned long values
1814 can fit into an integer. At this point, we know button_down_time
1815 <= event->timestamp, so the difference must be nonnegative, so
1816 there's no need to cast the result if double-click-time is
1817 nonnegative, as it should be; check that it's nonnegative, just in
1818 case. This bug is triggered when events are more than 2**31 ms
1819 apart (about 25 days). (Bug#8664)
1820
1821 * xselect.c (last_event_timestamp): Remove duplicate decl.
1822 (x_own_selection): Remove needless cast to unsigned long.
1823
1824 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1825 that always fit in int. Use a sentinel instead of a counter, to
1826 avoid a temp and to allay GCC's concerns about possible int overflow.
1827 * frame.h (struct frame): Use int for menu_bar_items_used
1828 instead of EMACS_INT, since it always fits in int.
1829
1830 * menu.c (grow_menu_items): Check for int overflow.
1831
1832 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1833
1834 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1835 Before, the code was not consistent. These values cannot exceed
1836 2**31 - 1 so there's no need to make them unsigned.
1837 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1838 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1839 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1840 as modifiers.
1841 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1842
1843 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1844 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1845 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1846 presumably because the widths might not match.
1847
1848 * window.c (size_window): Avoid needless test at loop start.
1849
1850 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1851
1852 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1853
1854 2011-05-12 Drew Adams <drew.adams@oracle.com>
1855
1856 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1857
1858 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1859
1860 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1861 `width' to `bar_area_x' and `bar_area_width', respectively.
1862 (x_scroll_run): Take account of fringe background extension.
1863
1864 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1865 Rename local vars `left' and `width' to `bar_area_x' and
1866 `bar_area_width', respectively.
1867 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1868 background extension.
1869
1870 2011-05-10 Jim Meyering <meyering@redhat.com>
1871
1872 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1873
1874 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1875
1876 * image.c (Finit_image_library): Return t for built-in image types,
1877 like pbm and xbm. (Bug#8640)
1878
1879 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1880
1881 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1882
1883 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1884
1885 * w32console.c (Fset_screen_color): Doc fix.
1886 (Fget_screen_color): New function.
1887 (syms_of_ntterm): Defsubr it.
1888
1889 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1890 unlink the temporary file if Fcall_process didn't create it in the
1891 first place.
1892 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1893 child process will be redirected to a file specified with `:file'.
1894 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1895 cue to call_process_cleanup not to close that handle.
1896
1897 2011-05-07 Ben Key <bkey76@gmail.com>
1898
1899 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1900 one of two shell specific rules, either bootstrap-temacs-CMD or
1901 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1902 to the previous implementation of the bootstrap-temacs rule.
1903 The bootstrap-temacs-CMD rule is similar to the previous
1904 implementation of the bootstrap-temacs rule except that it
1905 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1906 variable.
1907
1908 These changes, along with some changes to nt/configure.bat,
1909 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1910 earlier fix to add support for --cflags and --ldflags options
1911 that include quotes so that it works whether make uses cmd or
1912 sh as the shell.
1913
1914 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1915
1916 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1917 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1918 is a constant.
1919 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1920 a string. Handle both cases.
1921 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1922 (Fdbus_register_method): Use Qinvalid_function.
1923
1924 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1925
1926 * makefile.w32-in: Update dependencies.
1927 (LISP_H): Add inttypes.h and stdin.h.
1928 (PROCESS_H): Add unistd.h.
1929
1930 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1931
1932 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1933 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1934
1935 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1936
1937 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1938
1939 * term.c (vfatal): Remove stray call to va_end.
1940 It's not needed and the C Standard doesn't allow it here anyway.
1941
1942 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1943 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1944
1945 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1946 bytes.
1947
1948 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1949
1950 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1951
1952 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1953
1954 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1955
1956 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1957
1958 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1959 * charset.c (Fdefine_charset_internal): Don't initialize
1960 charset.code_space[15]. The value was garbage, on hosts with
1961 32-bit int (Bug#8600).
1962
1963 * lread.c (read_integer): Be more consistent with string-to-number.
1964 Use string_to_number to do the actual conversion; this avoids
1965 rounding errors and fixes some other screwups. Without this fix,
1966 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1967 (digit_to_number): Move earlier, for benefit of read_integer.
1968 Return -1 if the digit is out of range for the base, -2 if it is
1969 not a digit in any supported base. (Bug#8602)
1970
1971 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1972
1973 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1974 to match comment at start of function. This also removes a
1975 GCC warning about overflow in a 32+64-bit port.
1976
1977 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1978
1979 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1980 Reported by Stefan Monnier in
1981 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1982 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1983 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1984
1985 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1986 (EMACS_UINTPTR): Likewise, with uintptr_t.
1987
1988 * lisp.h: Prefer 64-bit EMACS_INT if available.
1989 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1990 on 32-bit hosts that have 64-bit int, so that they can access
1991 large files.
1992 However, temporarily disable this change unless the temporary
1993 symbol WIDE_EMACS_INT is defined.
1994
1995 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1996
1997 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1998 This removes an assumption that EMACS_INT and long are the same
1999 width as pointers. The assumption is true for Emacs porting targets
2000 now, but we want to make other targets possible.
2001 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2002 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2003 In the rest of the code, change types of integers that hold casted
2004 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2005 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2006 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2007 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2008 No need to cast type when ORing.
2009 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2010 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2011 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2012 assume EMACS_INT is the same width as char *.
2013 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2014 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2015 Remove no-longer-needed casts.
2016 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2017 (xg_tool_bar_help_callback, xg_make_tool_item):
2018 Use EMACS_INTPTR to hold an integer
2019 that will be cast to void *; this can avoid a GCC warning
2020 if EMACS_INT is not the same width as void *.
2021 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2022 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2023 (current_message_1, set_message_1):
2024 Use a local to convert to proper width without a cast.
2025 * xmenu.c (dialog_selection_callback): Likewise.
2026
2027 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2028 Also, don't assume VALBITS / RAND_BITS is less than 5,
2029 and don't rely on undefined behavior when shifting a 1 left into
2030 the sign bit.
2031 * lisp.h (get_random): Change signature to match.
2032
2033 * lread.c (hash_string): Use size_t, not int, for hash computation.
2034 Normally we prefer signed values; but hashing is special, because
2035 it's better to use unsigned division on hash table sizes so that
2036 the remainder is nonnegative. Also, size_t is the natural width
2037 for hashing into memory. The previous code used 'int', which doesn't
2038 retain enough info to hash well into very large tables.
2039 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2040
2041 * dbusbind.c: Don't possibly lose pointer info when converting.
2042 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2043 Use XPNTR rather than XHASH, so that the high-order bits of
2044 the pointer aren't lost when converting through void *.
2045
2046 * eval.c (Fautoload): Don't double-shift a pointer.
2047
2048 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2049
2050 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2051
2052 * gnutls.c (DEF_GNUTLS_FN):
2053 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2054
2055 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2056
2057 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2058 marker. (Bug#8610)
2059
2060 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2061
2062 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2063 New version that can reserve upto 2GB of heap space.
2064
2065 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2066
2067 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2068
2069 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2070
2071 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2072 `gnutls_certificate_set_x509_key_file'.
2073
2074 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2075
2076 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2077 Update dependencies.
2078
2079 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2080
2081 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2082 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2083 Remove unused parameter `fildes'.
2084 * process.c (read_process_output, send_process): Don't pass it.
2085
2086 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2087
2088 Fix previous change: the library cache is defined in w32.c.
2089 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2090 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2091
2092 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2093
2094 Implement dynamic loading of GnuTLS on Windows.
2095
2096 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2097 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2098 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2099 Declare.
2100
2101 * gnutls.c (Qgnutls_dll): Define.
2102 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2103 (gnutls_*): Declare function pointers.
2104 (init_gnutls_functions): New function to initialize function pointers.
2105 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2106 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2107 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2108 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2109 (emacs_gnutls_write, emacs_gnutls_read)
2110 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2111 (Fgnutls_available_p): New function.
2112 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2113 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2114 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2115
2116 * image.c: Include w32.h.
2117 (Vimage_type_cache): Delete.
2118 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2119 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2120 (w32_delayed_load): Move to w32.c.
2121
2122 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2123
2124 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2125 (w32_delayed_load): Move from image.c. When loading a library, record
2126 its filename in the :loaded-from property of the library id.
2127 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2128 Initialize and staticpro them.
2129 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2130
2131 * process.c: Include lisp.h before w32.h, not after.
2132 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2133 instead of gnutls_record_check_pending.
2134
2135 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2136
2137 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2138
2139 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2140 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2141 as passed in.
2142
2143 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2144
2145 * xterm.c (x_set_frame_alpha): Do not set property on anything
2146 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2147
2148 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2149
2150 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2151
2152 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2153
2154 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2155 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2156 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2157 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2158 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2159 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2160 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2161 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2162 (Qgnutls_bootprop_callbacks_verify): Make static.
2163
2164 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2165
2166 * callproc.c: Indentation fixup.
2167
2168 * sysdep.c (wait_for_termination_1): Make static.
2169 (wait_for_termination, interruptible_wait_for_termination):
2170 Move after wait_for_termination_1.
2171
2172 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2173
2174 * sysdep.c (interruptible_wait_for_termination): New function
2175 which is like wait_for_termination, but allows keyboard
2176 interruptions.
2177
2178 * callproc.c (Fcall_process): Add (:file "file") as an option for
2179 the STDOUT buffer.
2180 (Fcall_process_region): Ditto.
2181
2182 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2183
2184 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2185 rather than `XVECTOR (FOO)->size'.
2186
2187 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2188 inttypes.h, as a gnulib replacement is used if it not available in
2189 system headers.
2190
2191 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2192
2193 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2194 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2195 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2196
2197 * coding.c (coding_alloc_by_realloc): Error out if destination
2198 will grow beyond MOST_POSITIVE_FIXNUM.
2199 (decode_coding_emacs_mule): Abort if there isn't enough place in
2200 charbuf for the composition carryover bytes. Reserve an extra
2201 space for up to 2 characters produced in a loop.
2202 (decode_coding_iso_2022): Abort if there isn't enough place in
2203 charbuf for the composition carryover bytes.
2204
2205 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2206
2207 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2208 aborting when %lld or %lll format is passed.
2209 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2210 %llo or %llx format is passed. (Bug#8545)
2211
2212 * window.c (window_scroll_line_based): Use a marker instead of
2213 simple variables to record original value of point. (Bug#7952)
2214
2215 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2216 produced by %s or %c overflows available buffer space. (Bug#8545)
2217
2218 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2219
2220 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2221 (SIZE_MAX): Move defn after all includes, as they might #define it.
2222
2223 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2224
2225 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2226
2227 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2228
2229 * keyboard.c (Qdelayed_warnings_hook): Define.
2230 (command_loop_1): Run `delayed-warnings-hook'
2231 if Vdelayed_warnings_list is non-nil.
2232 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2233 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2234
2235 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2236
2237 * doprnt.c (doprnt): Don't return value smaller than the buffer
2238 size if the message was truncated. (Bug#8545).
2239
2240 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2241
2242 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2243 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2244
2245 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2246
2247 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2248
2249 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2250
2251 * makefile.w32-in: Update dependencies.
2252
2253 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2254
2255 Improve `doprnt' and its usage. (Bug#8545)
2256 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2257 `format_end'. Remove support for %l as a conversion specifier.
2258 Don't use xrealloc. Improve diagnostics when the %l size modifier
2259 is used. Update the commentary.
2260
2261 * eval.c (verror): Simplify calculation of size_t.
2262
2263 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2264 messages.
2265
2266 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2267
2268 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2269 change.
2270
2271 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2272
2273 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2274 This makes this file independent of the recent pseudovector change.
2275
2276 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2277
2278 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2279
2280 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2281 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2282 Remove unused local.
2283 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2284
2285 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2286 GCC 4.6.0 optimizes based on type-based alias analysis.
2287 For example, if b is of type struct buffer * and v of type struct
2288 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2289 != &v->size, and therefore "v->size = 1; b->size = 2; return
2290 v->size;" must therefore return 1. This assumption is incorrect
2291 for Emacs, since it type-puns struct Lisp_Vector * with many other
2292 types. To fix this problem, this patch adds a new type struct
2293 vectorlike_header that documents the constraints on layout of vectors
2294 and pseudovectors, and helps optimizing compilers not get fooled
2295 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2296 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2297 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2298 the size member.
2299 (XSETPVECTYPE): Rewrite in terms of new macro.
2300 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2301 This is a bit clearer, and further avoids the possibility of
2302 undesirable aliasing.
2303 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2304 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2305 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2306 since Lisp_Subr is a special case (no "next" field).
2307 (ASIZE): Now uses header.size rather than size.
2308 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2309 to avoid the hassle of writing XVECTOR (foo)->header.size.
2310 (struct vectorlike_header): New type.
2311 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2312 object, to help avoid aliasing.
2313 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2314 (SUBRP): Likewise, since Lisp_Subr is a special case.
2315 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2316 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2317 (struct Lisp_Hash_Table): Combine first two members into a single
2318 struct vectorlike_header member. All uses of "size" and "next" members
2319 changed to be "header.size" and "header.next".
2320 * buffer.h (struct buffer): Likewise.
2321 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2322 * frame.h (struct frame): Likewise.
2323 * process.h (struct Lisp_Process): Likewise.
2324 * termhooks.h (struct terminal): Likewise.
2325 * window.c (struct save_window_data, struct saved_window): Likewise.
2326 * window.h (struct window): Likewise.
2327 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2328 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2329 * buffer.c (init_buffer_once): Likewise.
2330 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2331 special case.
2332 * process.c (Fformat_network_address): Use local var for size,
2333 for brevity.
2334
2335 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2336
2337 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2338 * data.c (atof): Remove decl; no longer used or needed.
2339 (digit_to_number): Move to lread.c.
2340 (Fstring_to_number): Use new string_to_number function, to be
2341 consistent with how the Lisp reader treats infinities and NaNs.
2342 Do not assume that floating-point numbers represent EMACS_INT
2343 without losing information; this is not true on most 64-bit hosts.
2344 Avoid double-rounding errors, by insisting on integers when
2345 parsing non-base-10 numbers, as the documentation specifies.
2346 * lisp.h (string_to_number): New decl, replacing ...
2347 (isfloat_string): Remove.
2348 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2349 (read1): Do not accept +. and -. as integers; this
2350 appears to have been a coding error. Similarly, do not accept
2351 strings like +-1e0 as floating point numbers. Do not report
2352 overflow for integer overflows unless the base is not 10 which
2353 means we have no simple and reliable way to continue.
2354 Break out the floating-point parsing into a new
2355 function string_to_number, so that Fstring_to_number parses
2356 floating point numbers consistently with the Lisp reader.
2357 (digit_to_number): Move here from data.c. Make it static inline.
2358 (E_CHAR, EXP_INT): Remove, replacing with ...
2359 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2360 (string_to_number): New function, replacing isfloat_string.
2361 This function checks for valid syntax and produces the resulting
2362 Lisp float number too. Rework it so that string-to-number
2363 no longer mishandles examples like "1.0e+". Use strtoumax,
2364 so that overflow for non-base-10 numbers is reported only when
2365 there's no portable and simple way to convert to floating point.
2366
2367 * textprop.c (set_text_properties_1): Rewrite for clarity,
2368 and to avoid GCC warning about integer overflow.
2369
2370 * intervals.h (struct interval): Use EMACS_INT for members
2371 where EMACS_UINT might cause problems. See
2372 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2373 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2374 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2375 All uses changed.
2376 (offset_intervals): Tell GCC not to worry about length overflow
2377 when negating a negative length.
2378
2379 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2380 (overrun_check_free): Likewise.
2381
2382 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2383 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2384 word size.
2385
2386 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2387 (gnutls_make_error): Rename local to avoid shadowing.
2388 (gnutls_emacs_global_deinit): ifdef out; not used.
2389 (Fgnutls_boot): Use const for pointer to readonly storage.
2390 Comment out unused local. Fix pointer signedness problems.
2391
2392 * lread.c (openp): Don't stuff size_t into an 'int'.
2393 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2394 about possible signed overflow.
2395
2396 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2397 (GDK_KEY_g): Don't define if already defined.
2398 (xg_prepare_tooltip): Avoid pointer signedness problem.
2399 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2400
2401 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2402 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2403
2404 * xfns.c (Fx_window_property): Simplify a bit,
2405 to make a bit faster and to avoid GCC 4.6.0 warning.
2406 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2407
2408 * fns.c (internal_equal): Don't assume size_t fits in int.
2409
2410 * alloc.c (compact_small_strings): Tighten assertion a little.
2411
2412 Replace pEd with more-general pI, and fix some printf arg casts.
2413 * lisp.h (pI): New macro, generalizing old pEd macro to other
2414 conversion specifiers. For example, use "...%"pI"d..." rather
2415 than "...%"pEd"...".
2416 (pEd): Remove. All uses replaced with similar uses of pI.
2417 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2418 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2419 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2420 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2421 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2422 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2423 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2424 64-bit hosts.
2425 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2426 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2427 * print.c (safe_debug_print, print_object): Likewise.
2428 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2429 to int.
2430 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2431 avoiding the 0 flag, which is not portable.
2432 * process.c (Fmake_network_process): Use pI to avoid cast.
2433 * region-cache.c (pp_cache): Likewise.
2434 * xdisp.c (decode_mode_spec): Likewise.
2435 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2436 behavior on 64-bit hosts with printf arg.
2437 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2438 (x_stop_queuing_selection_requests): Likewise.
2439 (x_get_window_property): Don't truncate byte count to an 'int'
2440 when tracing.
2441
2442 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2443 here, since it parses constructs like leading '-' and spaces,
2444 which are not wanted; and it overflows with large numbers.
2445 Instead, simply match F[0-9]+, which is what is wanted anyway.
2446
2447 * alloc.c: Remove unportable assumptions about struct layout.
2448 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2449 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2450 (allocate_vectorlike, make_pure_vector): Use the new macros,
2451 plus offsetof, to remove unportable assumptions about struct layout.
2452 These assumptions hold on all porting targets that I know of, but
2453 they are not guaranteed, they're easy to remove, and removing them
2454 makes further changes easier.
2455
2456 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2457 This doesn't fix a bug but makes the code clearer.
2458 (string_overrun_cookie): Now const. Use initializers that
2459 don't formally overflow signed char, to avoid warnings.
2460 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2461 can cause Emacs to crash when string overrun checking is enabled.
2462 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2463 multiple of sizeof (EMACS_INT); it need not be, if
2464 alignof(EMACS_INT) < sizeof (EMACS_INT).
2465 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2466
2467 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2468
2469 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2470
2471 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2472
2473 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2474 supposed to be handshaking. (Bug#8556)
2475 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2476
2477 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2478
2479 * lisp.h (Qdebug): List symbol.
2480 * eval.c (Qdebug): Restore global linkage.
2481 * keyboard.c (debug-on-event): New variable.
2482 (handle_user_signal): Break into debugger when debug-on-event
2483 matches the current signal symbol.
2484
2485 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2486
2487 * alloc.c (check_sblock, check_string_bytes)
2488 (check_string_free_list): Convert to standard C.
2489
2490 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2491
2492 * w32.c (emacs_gnutls_push): Fix typo.
2493
2494 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2495
2496 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2497 "cast to pointer from integer of different size".
2498
2499 Improve doprnt and its use in verror. (Bug#8545)
2500 * doprnt.c (doprnt): Document the set of format control sequences
2501 supported by the function. Use SAFE_ALLOCA instead of always
2502 using `alloca'.
2503
2504 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2505 is one byte too soon. Don't use xrealloc; instead xfree and
2506 xmalloc anew.
2507
2508 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2509
2510 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2511 callbacks stage.
2512
2513 * gnutls.c: Renamed global_initialized to
2514 gnutls_global_initialized. Added internals for the
2515 :verify-hostname-error, :verify-error, and :verify-flags
2516 parameters of `gnutls-boot' and documented those parameters in the
2517 docstring. Start callback support.
2518 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2519 unless a fatal error occured. Call gnutls_alert_send_appropriate
2520 on error. Return error code.
2521 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2522 (emacs_gnutls_read): Likewise.
2523 (Fgnutls_boot): Return handshake error code.
2524 (emacs_gnutls_handle_error): New function.
2525 (wsaerror_to_errno): Likewise.
2526
2527 * w32.h (emacs_gnutls_pull): Add prototype.
2528 (emacs_gnutls_push): Likewise.
2529
2530 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2531 (emacs_gnutls_push): Likewise.
2532
2533 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2534
2535 * process.c (wait_reading_process_output): Check if GnuTLS
2536 buffered some data internally if no FDs are set for TLS
2537 connections.
2538
2539 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2540 (LIBS): Link to USER_LIBS.
2541 ($(BLD)/gnutls.$(0)): New target.
2542
2543 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2544
2545 * xdisp.c (handle_single_display_spec): Rename the
2546 display_replaced_before_p argument into display_replaced_p, to
2547 make it consistent with the commentary. Fix typos in the
2548 commentary.
2549
2550 * textprop.c (syms_of_textprop): Remove dead code.
2551 (copy_text_properties): Delete obsolete commentary about an
2552 interface that was deleted long ago. Fix typos in the description
2553 of arguments.
2554
2555 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2556 to changes in oldXMenu/XMenu.h from 2011-04-16.
2557 <menu_help_message, prev_menu_help_message>: Constify.
2558 (IT_menu_make_room): menu->help_text is now `const char **';
2559 adjust.
2560
2561 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2562 to changes in oldXMenu/XMenu.h from 2011-04-16.
2563 (struct XMenu): Declare `help_text' `const char **'.
2564
2565 * xfaces.c <Qunspecified>: Make extern again.
2566
2567 * syntax.c: Include sys/types.h before including regex.h, as
2568 required by Posix.
2569
2570 * doc.c (get_doc_string): Improve the format passed to `error'.
2571
2572 * doprnt.c (doprnt): Improve commentary.
2573
2574 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2575
2576 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2577 them with etags.
2578
2579 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2580 changes in globals.h immediately force recompilation.
2581 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2582 $(CURDIR)/s/ms-w32.h.
2583 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2584
2585 * character.c (Fchar_direction): Function deleted.
2586 (syms_of_character): Don't defsubr it.
2587 <char-direction-table>: Deleted.
2588
2589 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2590
2591 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2592 * doprnt.c: Include limits.h.
2593 (SIZE_MAX): New macro.
2594 (doprnt): Return a size_t value. 2nd arg is now size_t.
2595 Many local variables are now size_t instead of int or unsigned.
2596 Improve overflow protection. Support `l' modifier for integer
2597 conversions. Support %l conversion. Don't assume an EMACS_INT
2598 argument for integer conversions and for %c.
2599
2600 * lisp.h (doprnt): Restore prototype.
2601
2602 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2603 $(SRC)/character.h.
2604
2605 * Makefile.in (base_obj): Add back doprnt.o.
2606
2607 * deps.mk (doprnt.o): Add back prerequisites.
2608 (callint.o): Depend on character.h.
2609
2610 * eval.c (internal_lisp_condition_case): Include the handler
2611 representation in the error message.
2612 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2613 when breaking from the loop.
2614
2615 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2616
2617 * callint.c (Fcall_interactively): When displaying error message
2618 about invalid control letter, pass the character's codepoint, not
2619 a pointer to its multibyte form. Improve display of the character
2620 in octal and display also its hex code.
2621
2622 * character.c (char_string): Use %x to display the (unsigned)
2623 codepoint of an invalid character, to avoid displaying a bogus
2624 negative value.
2625
2626 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2627 `error', not SYMBOL_NAME itself.
2628
2629 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2630 character arguments to `error'.
2631
2632 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2633 to `error' in error message about FINAL_CHAR argument. Make sure
2634 FINAL_CHAR is a character, and use %c when it is passed as
2635 argument to `error'.
2636
2637 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2638
2639 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2640
2641 * w32.c: Include <time.h>.
2642 (sys_localtime): New function.
2643
2644 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2645
2646 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2647
2648 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2649
2650 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2651
2652 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2653 zombies (Bug#8467).
2654
2655 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2656
2657 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2658 gl_state.e_property when gl_state.object is Qt.
2659
2660 * insdel.c (make_gap_larger): Remove limitation of buffer size
2661 to <= INT_MAX.
2662
2663 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2664
2665 * xdisp.c (lookup_glyphless_char_display)
2666 (produce_glyphless_glyph): Handle cons cell entry in
2667 glyphless-char-display.
2668 (Vglyphless_char_display): Document it.
2669
2670 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2671 glyphless-char-display.
2672
2673 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2674
2675 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2676
2677 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2678
2679 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2680 definition for no-X builds.
2681
2682 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 Static checks with GCC 4.6.0 and non-default toolkits.
2685
2686 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2687
2688 * process.c (keyboard_bit_set): Define only if SIGIO.
2689 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2690 (send_process): Repair possible setjmp clobbering.
2691
2692 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2693
2694 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2695
2696 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2697
2698 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2699 Define only if needed.
2700
2701 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2702 by pacifying GCC about it. Maybe it's time to retire it?
2703 * xfaces.c (USG, __TIMEVAL__): Likewise.
2704
2705 * dispextern.h (struct redisplay_interface): Rename param
2706 to avoid shadowing.
2707 * termhooks.h (struct terminal): Likewise.
2708 * xterm.c (xembed_send_message): Likewise.
2709
2710 * insdel.c (make_gap_smaller): Define only if
2711 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2712
2713 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2714 it.
2715
2716 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2717 so that we aren't warned about unused symbols.
2718
2719 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2720
2721 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2722
2723 * xfns.c (x_real_positions): Mark locals as initialized.
2724
2725 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2726
2727 * xterm.c: Fix problems found by static analysis with other toolkits.
2728 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2729 (x_dispatch_event): Declare static if USE_GTK, and
2730 define if USE_GTK || USE_X_TOOLKIT.
2731 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2732 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2733 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2734 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2735
2736 * xmenu.c (menu_help_callback): Pointer type fixes.
2737 Use const pointers when pointing at readonly data. Avoid pointer
2738 signedness clashes.
2739 (FALSE): Remove unused macro.
2740 (update_frame_menubar): Remove unused decl.
2741
2742 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2743
2744 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2745 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2746 (single_menu_item): Rename local to avoid shadowing.
2747
2748 * keyboard.c (make_lispy_event): Remove unused local var.
2749
2750 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2751 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2752
2753 * bitmaps: Change bitmaps from unsigned char back to the X11
2754 compatible char. Avoid the old compiler warnings about
2755 out-of-range initializers by using, for example, '\xab' rather
2756 than 0xab.
2757
2758 * xgselect.c (xgselect_initialize): Check vs interface
2759 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2760
2761 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2762
2763 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2764 to read-only memory.
2765
2766 * fns.c (vector): Remove; this old hack is no longer needed.
2767
2768 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2769 Remove unused var.
2770 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2771
2772 * xrdb.c (x_load_resources): Omit unused local.
2773
2774 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2775 (x_window): Rename locals to avoid shadowing.
2776 (USG): Use the kludged USG macro, to pacify gcc.
2777
2778 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2779 (x_term_init): Remove local to avoid shadowing.
2780
2781 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2782
2783 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2784 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2785
2786 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2787
2788 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2789
2790 Fix regex.c, syntax.c and friends for buffers > 2GB.
2791 * syntax.h (struct gl_state_s): Declare character position members
2792 EMACS_INT.
2793
2794 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2795
2796 * textprop.c (verify_interval_modification, interval_of):
2797 Declare arguments EMACS_INT.
2798
2799 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2800 EMACS_INT.
2801
2802 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2803
2804 * indent.c (Fvertical_motion): Local variable it_start is now
2805 EMACS_INT.
2806
2807 * regex.c (re_match, re_match_2, re_match_2_internal)
2808 (bcmp_translate, regcomp, regexec, print_double_string)
2809 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2810 (re_compile_pattern, re_exec): Declare arguments and local
2811 variables `size_t' and `ssize_t' and return values `regoff_t', as
2812 appropriate.
2813 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2814 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2815 <compile_stack_type>: `size' and `avail' are now `size_t'.
2816
2817 * regex.h <regoff_t>: Use ssize_t, not int.
2818 (re_search, re_search_2, re_match, re_match_2): Arguments that
2819 specify buffer/string position and length are now ssize_t and
2820 size_t. Return type is regoff_t.
2821
2822 2011-04-16 Ben Key <bkey76@gmail.com>
2823
2824 * nsfont.m: Fixed bugs in ns_get_family and
2825 ns_descriptor_to_entity that were caused by using free to
2826 deallocate memory blocks that were allocated by xmalloc (via
2827 xstrdup). This caused Emacs to crash when compiled with
2828 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2829 --enable-checking=xmallocoverrun). xfree is now used to
2830 deallocate these memory blocks.
2831
2832 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2833
2834 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2835
2836 emacs_write: Accept and return EMACS_INT for sizes.
2837 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2838 et seq.
2839 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2840 Accept and return EMACS_INT.
2841 (emacs_gnutls_write): Return the number of bytes written on
2842 partial writes.
2843 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2844 (emacs_read, emacs_write): Remove check for negative size, as the
2845 Emacs source code has been audited now.
2846 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2847 (emacs_read, emacs_write): Use it.
2848 * process.c (send_process): Adjust to the new signatures of
2849 emacs_write and emacs_gnutls_write. Do not attempt to store
2850 a byte offset into an 'int'; it might overflow.
2851 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2852
2853 * sound.c: Don't assume sizes fit in 'int'.
2854 (struct sound_device.period_size, alsa_period_size):
2855 Return EMACS_INT, not int.
2856 (struct sound_device.write, vox_write, alsa_write):
2857 Accept EMACS_INT, not int.
2858 (wav_play, au_play): Use EMACS_INT to store sizes and to
2859 record read return values.
2860
2861 2011-04-15 Ben Key <bkey76@gmail.com>
2862
2863 * keyboard.c (Qundefined): Don't declare static since it is used
2864 in nsfns.m.
2865 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2866 static since they are used in nsfont.m.
2867
2868 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2869
2870 * process.c (Qprocessp): Don't declare static.
2871 * lisp.h (Qprocessp): Declare again.
2872
2873 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2874
2875 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2876
2877 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 Improve C-level modularity by making more things 'static'.
2880
2881 Don't publish debugger-only interfaces to other modules.
2882 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2883 (verify_bytepos, count_markers): Move decls to the only modules
2884 that need them.
2885 * region-cache.h (pp_cache): Likewise.
2886 * window.h (check_all_windows): Likewise.
2887 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2888
2889 * sysdep.c (croak): Now static, if
2890 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2891 * syssignal.h (croak): Declare only if not static.
2892
2893 * alloc.c (refill_memory_reserve): Now static if
2894 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2895 * lisp.h (refill_memory_reserve): Declare only if not static.
2896
2897 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2898 Define only if USE_LUCID.
2899
2900 * xrdb.c (x_customization_string, x_rm_string): Now static.
2901
2902 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2903 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2904
2905 * xdisp.c (draw_row_with_mouse_face): Now static.
2906 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2907
2908 * window.h (check_all_windows): Mark externally visible.
2909
2910 * window.c (window_deletion_count): Now static.
2911
2912 * undo.c: Make symbols static if they're not exported.
2913 (last_undo_buffer, last_boundary_position, pending_boundary):
2914 Now static.
2915
2916 * textprop.c (interval_insert_behind_hooks): Now static.
2917 (interval_insert_in_front_hooks): Likewise.
2918
2919 * term.c: Make symbols static if they're not exported.
2920 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2921 (max_frame_lines, tty_set_terminal_modes):
2922 (tty_reset_terminal_modes, tty_turn_off_highlight):
2923 (get_tty_terminal): Now static.
2924 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2925 * termhooks.h (term_mouse_moveto): Do not declare if
2926 HAVE_WINDOW_SYSTEM.
2927 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2928 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2929
2930 * sysdep.c: Make symbols static if they're not exported.
2931 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2932 Now static.
2933 (sigprocmask_set, full_mask): Remove; unused.
2934 (wait_debugging): Mark as visible.
2935 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2936 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2937
2938 * syntax.c (syntax_temp): Define only if !__GNUC__.
2939
2940 * sound.c (current_sound_device, current_sound): Now static.
2941
2942 * search.c (searchbufs, searchbuf_head): Now static.
2943
2944 * scroll.c (scroll_cost): Remove; unused.
2945 * dispextern.h (scroll_cost): Remove decl.
2946
2947 * region-cache.h (pp_cache): Mark as externally visible.
2948
2949 * process.c: Make symbols static if they're not exported.
2950 (process_tick, update_tick, create_process, chan_process):
2951 (Vprocess_alist, proc_buffered_char, datagram_access):
2952 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2953 (deactivate_process): Mark defn as static, as well as decl.
2954 * lisp.h (create_process): Remove decl.
2955 * process.h (chan_process, Vprocess_alist): Remove decls.
2956
2957 * print.c: Make symbols static if they're not exported.
2958 (print_depth, new_backquote_output, being_printed, print_buffer):
2959 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2960 (print_interval, print_number_index, initial_stderr_stream):
2961 Now static.
2962 * lisp.h (Fprinc): Remove decl.
2963 (debug_output_compilation_hack): Mark as externally visible.
2964
2965 * sysdep.c (croak): Move decl from here to syssignal.h.
2966 * syssignal.h (croak): Put it here, so the API can be checked when
2967 'croak' is called from dissociate_if_controlling_tty.
2968
2969 * minibuf.c: Make symbols static if they're not exported.
2970 (minibuf_save_list, choose_minibuf_frame): Now static.
2971 * lisp.h (choose_minibuf_frame): Remove decl.
2972
2973 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2974
2975 * lread.c: Make symbols static if they're not exported.
2976 (read_objects, initial_obarray, oblookup_last_bucket_number):
2977 Now static.
2978 (make_symbol): Remove; unused.
2979 * lisp.h (initial_obarray, make_symbol): Remove decls.
2980
2981 * keyboard.c: Make symbols static if they're not exported.
2982 (single_kboard, recent_keys_index, total_keys, recent_keys):
2983 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2984 (this_single_command_key_start, echoing, last_auto_save):
2985 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2986 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2987 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2988 (Vlispy_mouse_stem, double_click_count):
2989 Now static.
2990 (force_auto_save_soon): Define only if SIGDANGER.
2991 (ignore_mouse_drag_p): Now static if
2992 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2993 (print_help): Remove; unused.
2994 (stop_character, last_timer_event): Mark as externally visible.
2995 * keyboard.h (ignore_mouse_drag_p): Declare only if
2996 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2997 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2998 * lisp.h (echoing): Remove decl.
2999 (force_auto_save_soon): Declare only if SIGDANGER.
3000 * xdisp.c (redisplay_window): Simplify code, to make it more
3001 obvious that ignore_mouse_drag_p is not accessed if !defined
3002 USE_GTK && !defined HAVE_NS.
3003
3004 * intervals.c: Make symbols static if they're not exported.
3005 (merge_properties_sticky, merge_interval_right, delete_interval):
3006 Now static.
3007 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3008
3009 * insdel.c: Make symbols static if they're not exported.
3010 However, leave prepare_to_modify_buffer alone. It's never
3011 called from outside this function, but that appears to be a bug.
3012 (combine_after_change_list, combine_after_change_buffer):
3013 (adjust_after_replace, signal_before_change): Now static.
3014 (adjust_after_replace_noundo): Remove; unused.
3015 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3016 (signal_before_change): Remove decls.
3017
3018 * indent.c (val_compute_motion, val_vmotion): Now static.
3019
3020 * image.c: Make symbols static if they're not exported.
3021 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3022 if USE_GTK.
3023 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3024 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3025
3026 * fringe.c (standard_bitmaps): Now static.
3027 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3028
3029 * frame.c: Make symbols static if they're not exported.
3030 (x_report_frame_params, make_terminal_frame): Now static.
3031 (get_frame_param): Now static, unless HAVE_NS.
3032 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3033 (x_get_resource_string): Remove; not used.
3034 * frame.h (make_terminal_frame, x_report_frame_params):
3035 (x_get_resource_string); Remove decls.
3036 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3037 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3038
3039 * font.c, fontset.c: Make symbols static if they're not exported.
3040 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3041 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3042 * font.c (font_close_object): Now static.
3043 * font.h (font_close_object): Remove.
3044 * fontset.c (FONTSET_OBJLIST): Remove.
3045 (free_realized_fontset) #if-0 the body, which does nothing.
3046 (face_suitable_for_char_p): #if-0, as it's never called.
3047 * fontset.h (face_suitable_for_char_p): Remove decl.
3048 * xfaces.c (face_at_string_position):
3049 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3050 since 0 is always ASCII.
3051
3052 * fns.c (weak_hash_tables): Now static.
3053
3054 * fileio.c: Make symbols static if they're not exported.
3055 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3056 (Vwrite_region_annotation_buffers): Now static.
3057
3058 * eval.c: Make symbols static if they're not exported.
3059 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3060 * lisp.h (backtrace_list): Remove decl.
3061
3062 * emacs.c: Make symbols static if they're not exported.
3063 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3064 (fatal_error_code, fatal_error_signal_hook, standard_args):
3065 Now static.
3066 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3067 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3068 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3069 * lisp.h (fatal_error_signal_hook): Remove decl.
3070 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3071
3072 * editfns.c: Move a (normally-unused) function to its only use.
3073 * editfns.c, lisp.h (get_operating_system_release): Remove.
3074 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3075 worth the hassle of breaking this out.
3076
3077 * xterm.c: Make symbols static if they're not exported.
3078 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3079 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3080 (x_destroy_window, x_delete_display):
3081 Now static.
3082 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3083 (x_mouse_leave): Remove; unused.
3084 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3085 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3086 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3087 Remove decls.
3088 (x_mouse_leave): Declare only if WINDOWSNT.
3089 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3090 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3091 USE_X_TOOLKIT.
3092
3093 * ftxfont.c: Make symbols static if they're not exported.
3094 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3095 HAVE_FREETYPE.
3096 * font.h (ftxfont_driver): Likewise.
3097
3098 * xfns.c: Make symbols static if they're not exported.
3099 (x_last_font_name, x_display_info_for_name):
3100 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3101 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3102 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3103 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3104 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3105 (last_show_tip_args): Now static.
3106 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3107 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3108 (x_screen_planes): Remove; unused.
3109 * dispextern.h (x_screen_planes): Remove decl.
3110
3111 * dispnew.c: Make symbols static if they're not exported.
3112 * dispextern.h (redraw_garbaged_frames, scrolling):
3113 (increment_row_positions): Remove.
3114 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3115 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3116 Now static.
3117 (redraw_garbaged_frames): Remove; unused.
3118
3119 * xfaces.c: Make symbols static if they're not exported.
3120 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3121 Remove decls.
3122 * xterm.h (defined_color): Remove decls.
3123 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3124 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3125 (menu_face_changed_default, defined_color, free_realized_face):
3126 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3127 (ascii_face_of_lisp_face): Remove; unused.
3128
3129 * xdisp.c: Make symbols static if they're not exported.
3130 * dispextern.h (scratch_glyph_row, window_box_edges):
3131 (glyph_to_pixel_coords, set_cursor_from_row):
3132 (get_next_display_element, set_iterator_to_next):
3133 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3134 (show_mouse_face): Remove decls
3135 * frame.h (message_buf_print): Likewise.
3136 * lisp.h (pop_message, set_message, check_point_in_composition):
3137 Likewise.
3138 * xterm.h (set_vertical_scroll_bar): Likewise.
3139 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3140 (message_buf_print, scratch_glyph_row, displayed_buffer):
3141 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3142 (get_next_display_element, show_mouse_face, window_box_edges):
3143 (frame_to_window_pixel_xy, check_point_in_composition):
3144 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3145 (glyph_to_pixel_coords): Remove; unused.
3146
3147 * dired.c (file_name_completion): Now static.
3148
3149 * dbusbind.c (xd_in_read_queued_messages): Now static.
3150
3151 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3152 * data.c (circular_list_error): Remove.
3153
3154 * commands.h (last_point_position, last_point_position_buffer):
3155 (last_point_position_window): Remove decls.
3156 * keyboard.c: Make these variables static.
3157
3158 * coding.h (coding, code_convert_region, encode_coding_gap):
3159 Remove decls.
3160 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3161 (iso_code_class, detect_coding, code_convert_region): Now static.
3162 (encode_coding_gap): Remove; unused.
3163
3164 * chartab.c (chartab_chars, chartab_bits): Now static.
3165
3166 * charset.h (charset_iso_8859_1): Remove decl.
3167 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3168 Now static.
3169
3170 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3171 * ccl.c (Vccl_program_table): Now static.
3172 (check_ccl_update): Remove; unused.
3173
3174 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3175 * category.h: ... from here.
3176 * category.c (check_category_table, set_category_set): Now static.
3177
3178 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3179 * lisp.h: Remove these decls.
3180
3181 * buffer.c (buffer_count): Remove unused var.
3182
3183 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3184 so that it's not optimized away.
3185 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3186 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3187 exported only to the debugger.
3188
3189 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3190 * atimer.h (run_all_atimers): Remove; not exported.
3191
3192 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3193 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3194 was inaccessible from Lisp.
3195 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3196 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3197
3198 alloc.c: Import and export fewer symbols, and remove unused items.
3199 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3200 is defined.
3201 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3202 it's not optimized away by whole-program optimization.
3203 (message_enable_multibyte, free_misc): Remove.
3204 (catchlist, handlerlist, mark_backtrace):
3205 Declare only if BYTE_MARK_STACK.
3206 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3207 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3208 (message_enable_multibyte): Remove decl.
3209 (free_misc, interval_free_list, float_block, float_block_index):
3210 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3211 (cons_free_list, last_marked_index):
3212 Now static.
3213 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3214 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3215 (mark_backtrace): Define only if BYTE_MARK_STACK.
3216 * xdisp.c (message_enable_multibyte): Now static.
3217
3218 Declare Lisp_Object Q* variables to be 'static' if not exported.
3219 This makes it easier for human readers (and static analyzers)
3220 to see whether these variables are used from other modules.
3221 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3222 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3223 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3224 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3225 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3226 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3227 * xmenu.c, xselect.c:
3228 Declare Q* vars static if they are not used in other modules.
3229 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3230 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3231 Remove decls of unexported vars.
3232 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3233
3234 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3235
3236 Make Emacs functions such as Fatom 'static' by default.
3237 This makes it easier for human readers (and static analyzers)
3238 to see whether these functions can be called from other modules.
3239 DEFUN now defines a static function. To make the function external
3240 so that it can be used in other C modules, use the new macro DEFUE.
3241 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3242 (Finit_image_library):
3243 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3244 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3245 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3246 Remove decls, since these functions are now static.
3247 (Funintern, Fget_internal_run_time): New decls, since these functions
3248 were already external.
3249
3250 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3251 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3252 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3253 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3254 * keyboard.c, keymap.c, lread.c:
3255 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3256 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3257 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3258 Mark functions with DEFUE instead of DEFUN,
3259 if they are used in other modules.
3260 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3261 decls for now-static functions.
3262 * buffer.h (Fdelete_overlay): Remove decl.
3263 * callproc.c (Fgetenv_internal): Mark as internal.
3264 * composite.c (Fremove_list_of_text_properties): Remove decl.
3265 (Fcomposition_get_gstring): New forward static decl.
3266 * composite.h (Fcomposite_get_gstring): Remove decl.
3267 * dired.c (Ffile_attributes): New forward static decl.
3268 * doc.c (Fdocumntation_property): New forward static decl.
3269 * eval.c (Ffetch_bytecode): New forward static decl.
3270 (Funintern): Remove extern decl; now in .h file where it belongs.
3271 * fileio.c (Fmake_symbolic_link): New forward static decl.
3272 * image.c (Finit_image_library): New forward static decl.
3273 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3274 * intervals.h (Fprevious_property_change):
3275 (Fremove_list_of_text_properties): Remove decls.
3276 * keyboard.c (Fthis_command_keys): Remove decl.
3277 (Fcommand_execute): New forward static decl.
3278 * keymap.c (Flookup_key): New forward static decl.
3279 (Fcopy_keymap): Now static.
3280 * keymap.h (Flookup_key): Remove decl.
3281 * process.c (Fget_process): New forward static decl.
3282 (Fprocess_datagram_address): Mark as internal.
3283 * syntax.c (Fsyntax_table_p): New forward static decl.
3284 (skip_chars): Remove duplicate decl.
3285 * textprop.c (Fprevious_property_change): New forward static decl.
3286 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3287 Now internal.
3288 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3289 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3290
3291 * editfns.c (Fformat): Remove unreachable code.
3292
3293 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3294
3295 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3296 change. (Bug#8496)
3297
3298 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3299
3300 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3301 when at ZV. (Bug#8487)
3302
3303 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3304
3305 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3306 (Bug#8437)
3307 * keyboard.c (parse_tool_bar_item): Likewise.
3308 * sound.c (sound_cleanup, alsa_close): Likewise.
3309 * termcap.c (tgetent): Likewise.
3310 * xfns.c (x_default_font_parameter): Likewise.
3311 * xsettings.c (read_and_apply_settings): Likewise.
3312
3313 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3314 (overrun_check_free): Protoize.
3315
3316 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3317
3318 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3319 since callers should never pass a negative size.
3320 Change the signature to match that of plain 'read' and 'write'; see
3321 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3322 * lisp.h: Update prototypes of emacs_write and emacs_read.
3323
3324 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3325
3326 * xdisp.c (redisplay_window): Don't try to determine the character
3327 position of the scroll margin if the window start point w->startp
3328 is outside the buffer's accessible region. (Bug#8468)
3329
3330 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3331
3332 Fix write-region and its subroutines for buffers > 2GB.
3333 * fileio.c (a_write, e_write): Modify declaration of arguments and
3334 local variables to support buffers larger than 2GB.
3335 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3336
3337 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3338 argument, local variables, and return value.
3339
3340 * lisp.h: Update prototypes of emacs_write and emacs_read.
3341
3342 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3343
3344 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3345
3346 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3347
3348 Fix more problems found by GCC 4.6.0's static checks.
3349
3350 * xdisp.c (vmessage): Use a better test for character truncation.
3351
3352 * charset.c (load_charset_map): <, not <=, for optimization,
3353 and to avoid potential problems with integer overflow.
3354 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3355 * casetab.c (set_identity, shuffle): Likewise.
3356 * editfns.c (Fformat): Likewise.
3357 * syntax.c (skip_chars): Likewise.
3358
3359 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3360 This also lets GCC 4.6.0 generate slightly better loop code.
3361
3362 * callint.c (Fcall_interactively): <, not <=, for optimization.
3363 (Fcall_interactively): Count the number of arguments produced,
3364 not the number of arguments given. This is simpler and lets GCC
3365 4.6.0 generate slightly better code.
3366
3367 * ftfont.c: Distingish more carefully between FcChar8 and char.
3368 The previous code passed unsigned char * to a functions like
3369 strlen and xstrcasecmp that expect char *, which does not
3370 conform to the C standard.
3371 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3372 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3373 char * when the C standard requires it.
3374
3375 * keyboard.c (read_char): Remove unused var.
3376
3377 * eval.c: Port to Windows vsnprintf (Bug#8435).
3378 Include <limits.h>.
3379 (SIZE_MAX): Define if the headers do not.
3380 (verror): Do not give up if vsnprintf returns a negative count.
3381 Instead, grow the buffer. This ports to Windows vsnprintf, which
3382 does not conform to C99. Problem reported by Eli Zaretskii.
3383 Also, simplify the allocation scheme, by avoiding the need for
3384 calling realloc, and removing the ALLOCATED variable.
3385
3386 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3387
3388 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3389 But keep the doprint source code for now, as we might revamp it
3390 and use it again (Bug#8435).
3391 * lisp.h (doprnt): Remove.
3392 * Makefile.in (base_obj): Remove doprnt.o.
3393 * deps.mk (doprnt.o): Remove.
3394
3395 error: Print 32- and 64-bit integers portably (Bug#8435).
3396 Without this change, on typical 64-bit hosts error ("...%d...", N)
3397 was used to print both 32- and 64-bit integers N, which relied on
3398 undefined behavior.
3399 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3400 New macro.
3401 * lisp.h (error, verror): Mark as printf-like functions.
3402 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3403 Report overflow in size calculations when allocating printf buffer.
3404 Do not truncate output string at its first null byte.
3405 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3406 Truncate the output at a character boundary, since vsnprintf does not
3407 do that.
3408 * charset.c (check_iso_charset_parameter): Convert internal
3409 character to string before calling 'error', since %c now has the
3410 printf meaning.
3411 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3412 overflow when computing char to be passed to 'error'. Do not
3413 pass Lisp_Object to 'error'; pass the integer instead.
3414 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3415 formatted with plain %d.
3416
3417 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3418
3419 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3420
3421 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3422
3423 * xterm.c (x_catch_errors): Remove duplicate declaration.
3424
3425 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3426
3427 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3428
3429 2011-04-10 Jim Meyering <meyering@redhat.com>
3430
3431 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3432 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3433 return ssize_t not "int", and use size_t as the buffer length.
3434 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3435 * gnutls.h: Update declarations.
3436 * process.c (read_process_output): Use ssize_t, to match.
3437 (send_process): Likewise.
3438
3439 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3440
3441 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3442
3443 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3444
3445 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3446 Use unsigned char, to match FcChar8 type definition.
3447
3448 * xterm.c (handle_one_xevent):
3449 * xmenu.c (create_and_show_popup_menu):
3450 * xselect.c (x_decline_selection_request)
3451 (x_reply_selection_request): Avoid type-punned deref of X events.
3452
3453 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3454
3455 Fix some uses of `int' instead of EMACS_INT.
3456 * search.c (string_match_1, fast_string_match)
3457 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3458 (scan_buffer, find_next_newline_no_quit)
3459 (find_before_next_newline, search_command, Freplace_match)
3460 (Fmatch_data): Make some `int' variables be EMACS_INT.
3461
3462 * xdisp.c (display_count_lines): 3rd argument and return value now
3463 EMACS_INT. All callers changed.
3464 (pint2hrstr): Last argument is now EMACS_INT.
3465
3466 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3467 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3468 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3469 (decode_coding_utf_16, decode_coding_emacs_mule)
3470 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3471 (decode_coding_ccl, decode_coding_charset)
3472 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3473 (decode_coding_iso_2022, decode_coding_emacs_mule)
3474 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3475 <char_offset, last_offset>: Declare EMACS_INT.
3476 (encode_coding_utf_8, encode_coding_utf_16)
3477 (encode_coding_emacs_mule, encode_invocation_designation)
3478 (encode_designation_at_bol, encode_coding_iso_2022)
3479 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3480 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3481 Declare EMACS_INT.
3482 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3483 (encode_invocation_designation): Last argument P_NCHARS is now
3484 EMACS_INT.
3485 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3486 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3487
3488 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3489 All users changed.
3490
3491 * ccl.c (Fccl_execute_on_string): Declare some variables
3492 EMACS_INT.
3493
3494 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3495
3496 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3497
3498 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3499
3500 * process.c (Fformat_network_address): Doc fix.
3501
3502 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3503
3504 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3505
3506 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3507
3508 * keyboard.c (read_char): Call Lisp function help-form-show,
3509 instead of using internal_with_output_to_temp_buffer.
3510 (Qhelp_form_show): New var.
3511 (syms_of_keyboard): Use DEFSYM macro.
3512
3513 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3514
3515 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3516
3517 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3518
3519 * process.c (Flist_processes): Remove to Lisp.
3520 (list_processes_1): Delete.
3521
3522 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3523
3524 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3525
3526 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3527
3528 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3529
3530 Fix more problems found by GCC 4.6.0's static checks.
3531
3532 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3533
3534 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3535
3536 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3537
3538 * xdisp.c (vmessage): Mark as a printf-like function.
3539
3540 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3541
3542 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3543
3544 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3545 printf-like functions.
3546 (tiff_load): Add casts to remove these marks before passing them
3547 to system-supplied API.
3548
3549 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3550
3551 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3552 This avoids several warnings with gcc -Wstrict-overflow.
3553 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3554 directly, rather than having caller test rule sign. This avoids
3555 some unnecessary tests.
3556 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3557 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3558 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3559
3560 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3561 (xfont_open): Avoid unnecessary tests.
3562
3563 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3564
3565 * composite.h, composite.c (composition_gstring_put_cache):
3566 Use EMACS_INT, not int, for length.
3567
3568 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3569 breaking out part of COMPOSITION_DECODE_RULE.
3570 (COMPOSITION_DECODE_RULE): Use it.
3571 * composite.c (get_composition_id): Remove unused local vars,
3572 by using the new macro.
3573
3574 * textprop.c (set_text_properties_1): Change while to do-while,
3575 since the condition is always true at first.
3576
3577 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3578 (interval_deletion_adjustment): Return unsigned value.
3579 All uses changed.
3580
3581 * process.c (list_processes_1, create_pty, read_process_output):
3582 (exec_sentinel): Remove vars that were set but not used.
3583 (create_pty): Remove unnecessary "volatile"s.
3584 (Fnetwork_interface_info): Avoid possibility of int overflow.
3585 (read_process_output): Do adaptive read buffering even if carryover.
3586 (read_process_output): Simplify nbytes computation if buffered.
3587
3588 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3589
3590 * syntax.c (scan_words): Remove var that was set but not used.
3591 (update_syntax_table): Use unsigned instead of int.
3592
3593 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3594 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3595 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3596
3597 * print.c (print_error_message): Avoid int overflow.
3598
3599 * font.c (font_list_entities): Redo for clarity,
3600 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3601
3602 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3603 (font_score): Avoid potential overflow in diff calculation.
3604
3605 * fns.c (substring_both): Remove var that is set but not used.
3606 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3607
3608 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3609
3610 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3611 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3612 can always succeed if overflow has undefined behavior.
3613
3614 * search.c (boyer_moore, wordify): Remove vars set but not used.
3615 (wordify): Omit three unnecessary tests.
3616
3617 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3618 All callers changed. This avoids the need for an unused var.
3619
3620 * casefiddle.c (casify_region): Remove var that is set but not used.
3621
3622 * dired.c (file_name_completion): Remove var that is set but not used.
3623
3624 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3625
3626 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3627 (Finsert_file_contents): Remove unnecessary code checking fd.
3628
3629 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3630 Check for integer overflow on size calculations.
3631
3632 * buffer.c (Fprevious_overlay_change): Remove var that is set
3633 but not used.
3634
3635 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3636 Remove vars that are set but not used.
3637 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3638 (timer_check_2): Mark vars as initialized.
3639
3640 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3641
3642 * image.c (lookup_image): Remove var that is set but not used.
3643 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3644
3645 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3646 that are set but not used.
3647
3648 * xfns.c (make_invisible_cursor): Don't return garbage
3649 if XCreateBitmapFromData fails (Bug#8410).
3650
3651 * xselect.c (x_get_local_selection, x_handle_property_notify):
3652 Remove vars that are set but not used.
3653
3654 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3655 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3656
3657 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3658 Remove var that is set but not used.
3659 (scroll_bar_windows_size): Now size_t, not int.
3660 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3661 Check for overflow.
3662
3663 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3664 (map_tty_color) [!defined MSDOS]: Likewise.
3665
3666 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3667
3668 * coding.c: Remove vars that are set but not used.
3669 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3670 All callers changed.
3671 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3672 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3673 (decode_coding_charset): Remove vars that are set but not used.
3674
3675 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3676 that is set but not used.
3677
3678 * print.c (print_object): Remove var that is set but not used.
3679
3680 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3681 The gnulib version avoids calling malloc in the usual case,
3682 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3683 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3684 * filelock.c (current_lock_owner): Likewise.
3685 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3686 * sysdep.c: Include allocator.h, careadlinkat.h.
3687 (emacs_no_realloc_allocator): New static constant.
3688 (emacs_readlink): New function.
3689 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3690 ../lib/careadlinkat.h.
3691
3692 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3693
3694 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3695 first non-nil return value).
3696
3697 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3698
3699 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3700 if not defined (Bug#8403).
3701
3702 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3703
3704 * xdisp.c (display_count_lines): Remove parameter `start',
3705 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3706 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3707 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3708 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3709 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3710 and thereabouts. All callers changed.
3711 (get_per_char_metric): Remove parameter `f', unused since
3712 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3713
3714 2011-04-02 Jim Meyering <meyering@redhat.com>
3715
3716 do not dereference NULL upon failed strdup
3717 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3718 (ns_get_family): Likewise.
3719
3720 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3721
3722 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3723
3724 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3725
3726 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3727 later (Bug#8403).
3728
3729 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3730
3731 Add lexical binding.
3732
3733 * window.c (Ftemp_output_buffer_show): New fun.
3734 (Fsave_window_excursion):
3735 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3736
3737 * lread.c (lisp_file_lexically_bound_p): New function.
3738 (Fload): Bind Qlexical_binding.
3739 (readevalloop): Remove `evalfun' arg.
3740 Bind Qinternal_interpreter_environment.
3741 (Feval_buffer): Bind Qlexical_binding.
3742 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3743 Mark as dynamic.
3744 (syms_of_lread): Declare `lexical-binding'.
3745
3746 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3747
3748 * keyboard.c (eval_dyn): New fun.
3749 (menu_item_eval_property): Use it.
3750
3751 * image.c (parse_image_spec): Use Ffunctionp.
3752
3753 * fns.c (concat, mapcar1): Accept byte-code-functions.
3754
3755 * eval.c (Fsetq): Handle lexical vars.
3756 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3757 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3758 (FletX, Flet): Obey lexical binding.
3759 (Fcommandp): Handle closures.
3760 (Feval): New `lexical' arg.
3761 (eval_sub): New function extracted from Feval. Use it almost
3762 everywhere where Feval was used. Look up vars in lexical env.
3763 Handle closures.
3764 (Ffunctionp): Move from subr.el.
3765 (Ffuncall): Handle closures.
3766 (apply_lambda): Remove `eval_flags'.
3767 (funcall_lambda): Handle closures and new byte-code-functions.
3768 (Fspecial_variable_p): New function.
3769 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3770 but without exporting it to Lisp.
3771
3772 * doc.c (Fdocumentation, store_function_docstring):
3773 * data.c (Finteractive_form): Handle closures.
3774
3775 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3776 interactive spec.
3777
3778 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3779 New byte-codes.
3780 (exec_byte_code): New function extracted from Fbyte_code to handle new
3781 calling convention for byte-code-functions. Add new byte-codes.
3782
3783 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3784
3785 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3786
3787 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3788
3789 * xdisp.c (redisplay_internal): Fix prototype.
3790
3791 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3792
3793 * xdisp.c (SCROLL_LIMIT): New macro.
3794 (try_scrolling): Use it when setting scroll_limit.
3795 Limit scrolling to 100 screen lines.
3796 (redisplay_window): Even when falling back on "recentering",
3797 position point in the window according to scroll-conservatively,
3798 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3799
3800 (try_scrolling): When point is above the window, allow searching
3801 as far as scroll_max, or one screenful, to compute vertical
3802 distance from PT to the scroll margin position. This prevents
3803 try_scrolling from unnecessarily failing when
3804 scroll-conservatively is set to a value slightly larger than the
3805 window height. Clean up the case of PT below the margin at bottom
3806 of window: scroll_max can no longer be INT_MAX. When aggressive
3807 scrolling is in use, don't let point enter the opposite scroll
3808 margin as result of the scroll.
3809 (syms_of_xdisp) <scroll-conservatively>: Document the
3810 threshold of 100 lines for never-recentering scrolling.
3811
3812 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3813
3814 * dispextern.h (move_it_by_lines):
3815 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3816 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3817 (message_log_check_duplicate): Remove parameters `prev_bol' and
3818 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3819 (redisplay_internal): Remove parameter `preserve_echo_area',
3820 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3821
3822 * indent.c (Fvertical_motion):
3823 * window.c (window_scroll_pixel_based, Frecenter):
3824 Don't pass `need_y_p' to `move_it_by_lines'.
3825
3826 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3827
3828 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3829 steal a few bits to be more compact.
3830 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3831 Remove unneeded casts.
3832
3833 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3834
3835 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3836
3837 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3838 binding" message (bug#7967).
3839
3840 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3841
3842 Fix more problems found by GCC 4.6.0's static checks.
3843
3844 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3845 Remove unused local var.
3846
3847 * editfns.c (Fmessage_box): Remove unused local var.
3848
3849 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3850 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3851 Omit unused local vars.
3852 * window.c (shrink_windows): Omit unused local var.
3853 * menu.c (digest_single_submenu): Omit unused local var.
3854 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3855 Omit unused local var.
3856
3857 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3858 Don't assume string length fits in int.
3859 (keyremap_step, read_key_sequence): Use size_t for sizes.
3860 (read_key_sequence): Don't check last_real_key_start redundantly.
3861
3862 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3863 instead of alloca (Bug#8344).
3864
3865 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3866 (Fbacktrace_frame): Don't assume nframes fits in int.
3867
3868 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3869
3870 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3871 concerns.
3872
3873 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3874
3875 * cm.c (calccost): Turn while-do into do-while, for clarity.
3876
3877 * keyboard.c (syms_of_keyboard): Use the same style as later
3878 in this function when indexing through an array. This also
3879 works around GCC bug 48267.
3880
3881 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3882
3883 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3884
3885 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3886 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3887
3888 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3889 This avoids undefined behavior on integer overflow, and is a bit
3890 more convenient anyway since it is compared to a size_t variable.
3891
3892 Variadic C functions now count arguments with size_t, not int.
3893 This avoids an unnecessary limitation on 64-bit machines, which
3894 caused (substring ...) to crash on large vectors (Bug#8344).
3895 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3896 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3897 All variadic functions and their callers changed accordingly.
3898 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3899 * data.c (arith_driver, float_arith_driver): Likewise.
3900 * editfns.c (general_insert_function): Likewise.
3901 * eval.c (struct backtrace.nargs, interactive_p)
3902 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3903 (funcall_lambda, mark_backtrace): Likewise.
3904 * fns.c (concat): Likewise.
3905 * frame.c (x_set_frame_parameters): Likewise.
3906 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3907 0 if not found, not -1. All callers changed.
3908
3909 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3910 (stack_copy_size): Now size_t, not int.
3911 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3912
3913 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3914
3915 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3916 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3917 All callers changed.
3918
3919 * lisp.h (multibyte_char_to_unibyte):
3920 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3921 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3922 * character.h (CHAR_TO_BYTE8):
3923 * cmds.c (internal_self_insert):
3924 * editfns.c (general_insert_function):
3925 * keymap.c (push_key_description):
3926 * search.c (Freplace_match):
3927 * xdisp.c (message_dolog, set_message_1): All callers changed.
3928
3929 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3930
3931 * keyboard.c (safe_run_hook_funcall): New function.
3932 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3933 don't set the hook to nil, but remove the offending function instead.
3934 (Qcommand_hook_internal): Remove, unused.
3935 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3936 Vcommand_hook_internal.
3937
3938 * eval.c (enum run_hooks_condition): Remove.
3939 (funcall_nil, funcall_not): New functions.
3940 (run_hook_with_args): Call each function through a `funcall' argument.
3941 Remove `cond' argument, now redundant.
3942 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3943 (Frun_hook_with_args_until_failure): Adjust accordingly.
3944 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3945
3946 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3947
3948 * dispextern.h (string_buffer_position): Remove declaration.
3949
3950 * print.c (strout): Remove parameter `multibyte', unused since
3951 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3952
3953 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3954 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3955 All callers changed.
3956
3957 * w32.c (_wsa_errlist): Use braces for struct initializers.
3958
3959 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3960 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3961 All callers changed.
3962 (string_buffer_position): Likewise. Also, make static (it's never
3963 used outside xdisp.c).
3964 (cursor_row_p): Remove parameter `w', unused since
3965 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3966 (decode_mode_spec): Remove parameter `precision', introduced during
3967 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3968 All callers changed.
3969
3970 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3971
3972 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3973
3974 2011-03-27 Anders Lindgren <andlind@gmail.com>
3975
3976 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3977 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3978 (ns_update_auto_hide_menu_bar): New functions.
3979 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3980 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3981 ns_constrain_all_frames.
3982 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3983 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3984
3985 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3986
3987 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3988
3989 2011-03-27 Glenn Morris <rgm@gnu.org>
3990
3991 * syssignal.h: Replace RETSIGTYPE with void.
3992 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3993 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3994 Replace SIGTYPE with void everywhere.
3995 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3996 * s/template.h (SIGTYPE): Remove commented out definition.
3997
3998 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3999
4000 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4001 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4002
4003 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4004
4005 * w32.c (read_unc_volume): Use parameter `henum', instead of
4006 global variable `wget_enum_handle'.
4007
4008 * keymap.c (describe_vector): Remove parameters `indices' and
4009 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4010 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4011
4012 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4013
4014 * keyboard.c (timer_check): Remove parameter `do_it_now',
4015 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4016 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4017 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4018
4019 * keyboard.c (read_char):
4020 * w32menu.c (w32_menu_display_help):
4021 * xmenu.c (show_help_event, menu_help_callback):
4022 Adjust calls to `show_help_echo'.
4023
4024 * gtkutil.c (xg_maybe_add_timer):
4025 * keyboard.c (readable_events):
4026 * process.c (wait_reading_process_output):
4027 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4028
4029 * insdel.c (adjust_markers_gap_motion):
4030 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4031 (gap_left, gap_right): Don't call it.
4032
4033 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4034
4035 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4036 incurred during fontification.
4037
4038 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4039
4040 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4041 (DEFVAR_PER_BUFFER): Don't pass it.
4042
4043 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4044 (scrolling_window): Don't pass it.
4045
4046 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4047
4048 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4049
4050 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4051 and `suffix'.
4052 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4053 of variables specific to SELinux and computation of `encoded_absname'.
4054
4055 * image.c (XPutPixel): Remove unused variable `height'.
4056
4057 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4058
4059 * unexw32.c (get_section_info): Remove unused variable `section'.
4060
4061 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4062 (system_process_attributes): Remove unused variable `sess'.
4063 (sys_read): Remove unused variable `err'.
4064
4065 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4066 (w32_wnd_proc): Remove unused variable `isdead'.
4067 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4068 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4069 (x_create_tip_frame): Remove unused variable `tem'.
4070
4071 * w32inevt.c (w32_console_read_socket):
4072 Remove unused variable `no_events'.
4073
4074 * w32term.c (x_draw_composite_glyph_string_foreground):
4075 Remove unused variable `width'.
4076
4077 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4078
4079 * w32term.c (x_set_glyph_string_clipping):
4080 Don't pass uninitialized region to CombineRgn.
4081
4082 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4083
4084 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4085 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4086 (Fx_close_connection): Remove unused variable `i'.
4087
4088 * w32font.c (w32font_draw): Return number of glyphs.
4089 (w32font_open_internal): Remove unused variable `i'.
4090 (w32font_driver): Add missing initializer.
4091
4092 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4093 (fill_in_menu): Remove unused variable `items_added'.
4094
4095 * w32term.c (last_mouse_press_frame): Remove static global variable.
4096 (w32_clip_to_row): Remove unused variable `f'.
4097 (x_delete_terminal): Remove unused variable `i'.
4098
4099 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4100 (NOTHING): Remove unused static global variable.
4101 (uniscribe_check_otf): Remove unused variable `table'.
4102 (uniscribe_font_driver): Add missing initializers.
4103
4104 2011-03-23 Julien Danjou <julien@danjou.info>
4105
4106 * term.c (Fsuspend_tty, Fresume_tty):
4107 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4108 * window.c (temp_output_buffer_show):
4109 * insdel.c (signal_before_change):
4110 * frame.c (Fhandle_switch_frame):
4111 * fileio.c (Fdo_auto_save):
4112 * emacs.c (Fkill_emacs):
4113 * editfns.c (save_excursion_restore):
4114 * cmds.c (internal_self_insert):
4115 * callint.c (Fcall_interactively):
4116 * buffer.c (Fkill_all_local_variables):
4117 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4118 Use Frun_hooks.
4119 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4120 unconditionnaly since it does the check itself.
4121
4122 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4123
4124 Fix more problems found by GCC 4.5.2's static checks.
4125
4126 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4127 the first time through the loop, since we know p0 < p1 then.
4128 This also avoids a gcc -Wstrict-overflow warning.
4129
4130 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4131 leading to a memory leak, possible in functions like
4132 load_charset_map_from_file that can allocate an unbounded number
4133 of objects (Bug#8318).
4134
4135 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4136 that could (at least in theory) be that large.
4137
4138 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4139 This is less likely to overflow, and avoids undefined behavior if
4140 overflow does occur. All callers changed. Use strtoul to scan
4141 for the unsigned long integer.
4142 (pint2hrstr): Simplify and tune code slightly.
4143 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4144
4145 * scroll.c (do_scrolling): Work around GCC bug 48228.
4146 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4147
4148 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4149 This also avoids a warning with gcc -Wstrict-overflow.
4150 (validate_x_resource_name): Simplify count usage.
4151 This also avoids a warning with gcc -Wstrict-overflow.
4152
4153 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4154 fail (Bug#8306).
4155
4156 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4157
4158 * process.c (Fmake_network_process): Use socklen_t, not int,
4159 where POSIX says socklen_t is required in portable programs.
4160 This fixes a porting bug on hosts like 64-bit HP-UX, where
4161 socklen_t is wider than int (Bug#8277).
4162 (Fmake_network_process, server_accept_connection):
4163 (wait_reading_process_output, read_process_output):
4164 Likewise.
4165
4166 * process.c: Rename or move locals to avoid shadowing.
4167 (list_processes_1, Fmake_network_process):
4168 (read_process_output_error_handler, exec_sentinel_error_handler):
4169 Rename or move locals.
4170 (Fmake_network_process): Define label "retry_connect" only if needed.
4171 (Fnetwork_interface_info): Fix pointer signedness.
4172 (process_send_signal): Add cast to avoid pointer signedness problem.
4173 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4174 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4175
4176 Make tparam.h and terminfo.c consistent.
4177 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4178 Include tparam.h instead, since it declares them.
4179 * cm.h (PC): Remove extern decl; tparam.h now does this.
4180 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4181 * terminfo.c: Include tparam.h, to check interfaces.
4182 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4183 (tparam): Adjust signature to match interface in tparam.h;
4184 this removes some undefined behavior. Check that outstring and len
4185 are zero, which they always are with Emacs.
4186 * tparam.h (PC, BC, UP): New extern decls.
4187
4188 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4189 (xftfont_open): Rename locals to avoid shadowing.
4190
4191 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4192 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4193 (OTF_TAG_SYM): Omit macro if not needed.
4194 (ftfont_list): Remove unused local.
4195 (get_adstyle_property, ftfont_pattern_entity):
4196 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4197 Rename locals to avoid shadowing.
4198
4199 * xfont.c (xfont_list_family): Mark var as initialized.
4200
4201 * xml.c (make_dom): Now static.
4202
4203 * composite.c (composition_compute_stop_pos): Rename local to
4204 avoid shadowing.
4205 (composition_reseat_it): Remove unused locals.
4206 (find_automatic_composition, composition_adjust_point): Likewise.
4207 (composition_update_it): Mark var as initialized.
4208 (find_automatic_composition): Mark vars as initialized,
4209 with a FIXME (Bug#8290).
4210
4211 character.h: Rename locals to avoid shadowing.
4212 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4213 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4214 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4215 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4216 to avoid shadowing.
4217
4218 * textprop.c (property_change_between_p): Remove; unused.
4219
4220 * intervals.c (interval_start_pos): Now static.
4221
4222 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4223
4224 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4225 Rename locals to avoid shadowing.
4226
4227 * sound.c (wav_play, au_play, Fplay_sound_internal):
4228 Fix pointer signedness.
4229 (alsa_choose_format): Remove unused local var.
4230 (wav_play): Initialize a variable to 0, to prevent undefined
4231 behavior (Bug#8278).
4232
4233 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4234
4235 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4236
4237 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4238 clobbering (Bug#8298).
4239 * sysdep.c (sys_subshell): Likewise.
4240 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4241
4242 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4243 This should get cleaned up, so that child_setup has the
4244 same signature on all platforms.
4245
4246 * callproc.c (call_process_cleanup): Now static.
4247 (relocate_fd): Rename locals to avoid shadowing.
4248
4249 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4250
4251 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4252 not to be necessary, and produces flickering.
4253
4254 2011-03-20 Glenn Morris <rgm@gnu.org>
4255
4256 * config.in: Remove file.
4257
4258 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4259
4260 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4261 are now in src/globals.h.
4262 (syms_of_minibuf): Remove spurious & from previous change.
4263
4264 2011-03-20 Leo <sdl.web@gmail.com>
4265
4266 * minibuf.c (completing-read-function): New variable.
4267 (completing-read-default): Rename from completing-read.
4268 (completing-read): Call completing-read-function.
4269
4270 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4271
4272 * xfaces.c (Fx_load_color_file):
4273 Read color file from absolute filename (bug#8250).
4274
4275 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4276
4277 * makefile.w32-in: Update dependencies.
4278
4279 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4280
4281 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4282
4283 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4284
4285 Fix more problems found by GCC 4.5.2's static checks.
4286
4287 * process.c (make_serial_process_unwind, send_process_trap):
4288 (sigchld_handler): Now static.
4289
4290 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4291 That way, the code declares only the vars that it needs.
4292 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4293 * s/cygwin.h (PTY_ITERATION): Likewise.
4294 * s/darwin.h (PTY_ITERATION): Likewise.
4295 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4296
4297 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4298 * process.c (allocate_pty): Don't declare stb unless it's needed.
4299
4300 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4301 (CONSTANTLIM): Remove; unused.
4302 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4303 Define only if needed.
4304
4305 * unexelf.c (unexec): Name an expression,
4306 to avoid gcc -Wbad-function-cast warning.
4307 Use a different way to cause a compilation error if anyone uses
4308 n rather than nn, a way that does not involve shadowing.
4309 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4310
4311 * deps.mk (unexalpha.o): Remove; unused.
4312
4313 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4314 * unexec.h: New file.
4315 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4316 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4317 Depend on unexec.h.
4318 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4319 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4320 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4321 Change as necessary to match prototype in unexec.h.
4322
4323 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4324 shadowing.
4325 (back_comment, skip_chars): Mark vars as initialized.
4326
4327 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4328 Rename locals to avoid shadowing.
4329
4330 * lread.c (read1): Rewrite so as not to use empty "else".
4331 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4332
4333 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4334
4335 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4336 warning when compiling print.c.
4337
4338 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4339 instead of using an uninitialized var.
4340 (font_sort_entities): Mark var as initialized.
4341
4342 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4343
4344 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4345 pointers to constants.
4346 (font_parse_fcname): Remove unused vars.
4347 (font_delete_unmatched): Now static.
4348 (font_get_spec): Remove; unused.
4349 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4350 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4351 Rename or move locals to avoid shadowing.
4352
4353 * fns.c (require_nesting_list, require_unwind): Now static.
4354 (Ffillarray): Rename locals to avoid shadowing.
4355
4356 * floatfns.c (domain_error2): Define only if needed.
4357 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4358
4359 * alloc.c (mark_backtrace): Move decl from here ...
4360 * lisp.h: ... to here, so that it can be checked.
4361
4362 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4363 (Fdefvar): Rewrite so as not to use empty "else".
4364 (lisp_indirect_variable): Name an expression,
4365 to avoid gcc -Wbad-function-cast warning.
4366 (Fdefvar): Rename locals to avoid shadowing.
4367
4368 * callint.c (quotify_arg, quotify_args): Now static.
4369 (Fcall_interactively): Rename locals to avoid shadowing.
4370 Use const pointer when appropriate.
4371
4372 * lisp.h (get_system_name, get_operating_system_release):
4373 Move decls here, to check interfaces.
4374 * process.c (get_operating_system_release): Move decl to lisp.h.
4375 * xrdb.c (get_system_name): Likewise.
4376 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4377 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4378 some of which prompt warnings from gcc -Wbad-function-cast.
4379 (Fformat_time_string, Fencode_time, Finsert_char):
4380 (Ftranslate_region_internal, Fformat):
4381 Rename or remove local vars to avoid shadowing.
4382 (Ftranslate_region_internal): Mark var as initialized.
4383
4384 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4385 avoid shadowing.
4386
4387 * lisp.h (eassert): Check that the argument compiles, even if
4388 ENABLE_CHECKING is not defined.
4389
4390 * data.c (Findirect_variable): Name an expression, to avoid
4391 gcc -Wbad-function-cast warning.
4392 (default_value, arithcompare, arith_driver, arith_error): Now static.
4393 (store_symval_forwarding): Rename local to avoid shadowing.
4394 (Fmake_variable_buffer_local, Fmake_local_variable):
4395 Mark variables as initialized.
4396 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4397
4398 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4399 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4400 Rename locals to avoid shadowing.
4401 (mark_stack): Move local variables into the #ifdef region where
4402 they're used.
4403 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4404 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4405 needed otherwise.
4406 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4407 (GC_STRING_CHARS): Remove; not used.
4408 (Fmemory_limit): Cast sbrk's returned value to char *.
4409
4410 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4411 avoids undefined behavior in theory.
4412
4413 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4414
4415 Use functions, not macros, for up- and down-casing (Bug#8254).
4416 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4417 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4418 to use the following functions instead of these macros.
4419 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4420 EMACS_INT, since callers assume the returned value fits in int.
4421 (upcase1): Likewise, for UPCASE_TABLE.
4422 (uppercasep, lowercasep, upcase): New static inline functions.
4423 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4424 the race-condition problem in the old DOWNCASE.
4425
4426 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4427 Rename locals to avoid shadowing.
4428 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4429 (regex_compile, re_search_2, re_match_2_internal):
4430 Remove unused local vars.
4431 (FREE_VAR): Rewrite so as not to use empty "else",
4432 which gcc can warn about.
4433 (regex_compile, re_match_2_internal): Mark locals as initialized.
4434 (RETALLOC_IF): Define only if needed.
4435 (WORDCHAR_P): Likewise. This one is never needed, but is used
4436 only in a comment talking about a compiler bug, so put inside
4437 the #if 0 of that comment.
4438 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4439 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4440 Remove; unused.
4441
4442 * search.c (boyer_moore): Rename locals to avoid shadowing.
4443 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4444 (PREV_CHAR_BOUNDARY): Likewise.
4445
4446 * search.c (simple_search): Remove unused var.
4447
4448 * dired.c (compile_pattern): Move decl from here ...
4449 * lisp.h: ... to here, so that it can be checked.
4450 (struct re_registers): New forward decl.
4451
4452 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4453
4454 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4455 All uses changed.
4456 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4457 Rename locals to avoid shadowing.
4458 (Fvertical_motion): Mark locals as initialized.
4459
4460 * casefiddle.c (casify_object, casify_region): Now static.
4461 (casify_region): Mark local as initialized.
4462
4463 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4464
4465 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4466 New macros, so that the caller can use some names other than
4467 gcpro1, gcpro2, etc.
4468 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4469 of the new macros.
4470 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4471 argument, for consistency with GCPRO2_VAR, etc: it is now the
4472 prefix of the variable, not the variable itself. All uses
4473 changed.
4474 * dired.c (directory_files_internal, file_name_completion):
4475 Rename locals to avoid shadowing.
4476
4477 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4478 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4479 dired.c's scmp function, had undefined behavior.
4480 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4481 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4482 * buffer.h: ... to here, because these macros use current_buffer,
4483 and the new implementation with inline functions needs to have
4484 current_buffer in scope now, rather than later when the macros
4485 are used.
4486 (downcase, upcase1): New static inline functions.
4487 (DOWNCASE, UPCASE1): Reimplement using these functions.
4488 This avoids undefined behavior in expressions like
4489 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4490 from race conditions in accessing the global variables
4491 case_temp1 and case_temp2.
4492 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4493 * lisp.h (case_temp1, case_temp2): Remove their decls.
4494 * character.h (ASCII_CHAR_P): Move from here ...
4495 * lisp.h: ... to here, so that the inline functions mentioned
4496 above can use them.
4497
4498 * dired.c (directory_files_internal_unwind): Now static.
4499
4500 * fileio.c (file_name_as_directory, directory_file_name):
4501 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4502 Now static.
4503 (file_name_as_directory): Use const pointers when appropriate.
4504 (Fexpand_file_name): Likewise. In particular, newdir might
4505 point at constant storage, so make it a const pointer.
4506 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4507 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4508 signedness issues.
4509 (Fset_file_times, Finsert_file_contents, auto_save_error):
4510 Rename locals to avoid shadowing.
4511
4512 * minibuf.c (choose_minibuf_frame_1): Now static.
4513 (Ftry_completion, Fall_completions): Rename or remove locals
4514 to avoid shadowing.
4515
4516 * marker.c (bytepos_to_charpos): Remove; unused.
4517
4518 * lisp.h (verify_bytepos, count_markers): New decls,
4519 so that gcc does not warn that these functions aren't declared.
4520
4521 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4522 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4523 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4524 (copy_text): Remove unused local var.
4525
4526 * filelock.c (within_one_second): Now static.
4527 (lock_file_1): Rename local to avoid shadowing.
4528
4529 * buffer.c (fix_overlays_before): Mark locals as initialized.
4530 (fix_start_end_in_overlays): Likewise. This function should be
4531 simplified by using pointers-to-pointers, but that's a different
4532 matter.
4533 (switch_to_buffer_1): Now static.
4534 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4535 (report_overlay_modification): Rename locals to avoid shadowing.
4536
4537 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4538 Fix pointer signedness issue.
4539 (sys_subshell): Mark local as volatile if checking for lint,
4540 to suppress a gcc -Wclobbered warning that does not seem to be right.
4541 (MAXPATHLEN): Define only if needed.
4542
4543 * process.c (serial_open, serial_configure): Move decls from here ...
4544 * systty.h: ... to here, so that they can be checked.
4545
4546 * fns.c (get_random, seed_random): Move extern decls from here ...
4547 * lisp.h: ... to here, so that they can be checked.
4548
4549 * sysdep.c (reset_io): Now static.
4550 (wait_for_termination_signal): Remove; unused.
4551
4552 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4553 (copy_keymap_item, append_key, push_text_char_description):
4554 Now static.
4555 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4556 (DENSE_TABLE_SIZE): Remove; unused.
4557 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4558 (describe_map_tree):
4559 Rename locals to avoid shadowing.
4560
4561 * keyboard.c: Declare functions static if they are not used elsewhere.
4562 (echo_char, echo_dash, cmd_error, top_level_2):
4563 (poll_for_input, handle_async_input): Now static.
4564 (read_char, kbd_buffer_get_event, make_lispy_position):
4565 (make_lispy_event, make_lispy_movement, apply_modifiers):
4566 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4567 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4568 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4569 (read_key_sequence, read_char): Mark locals as initialized.
4570 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4571
4572 * keyboard.h (make_ctrl_char): New decl.
4573 (mark_kboards): Move decl here ...
4574 * alloc.c (mark_kboards): ... from here.
4575
4576 * lisp.h (force_auto_save_soon): New decl.
4577
4578 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4579 (DEFINE_DUMMY_FUNCTION): New macro.
4580 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4581 Use it.
4582 (main): Add casts to avoid warnings
4583 if GCC considers string literals to be constants.
4584
4585 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4586
4587 * dbusbind.c: Pointer signedness fixes.
4588 (xd_signature, xd_append_arg, xd_initialize):
4589 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4590 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4591 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4592 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4593
4594 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4595 if GCC considers string literals to be constants.
4596 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4597
4598 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4599
4600 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4601 (print_preprocess, print_object): New macro to fix last change.
4602
4603 * print.c (print_preprocess): Don't forget font objects.
4604
4605 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4606
4607 * emacs.c (USAGE3): Doc fixes.
4608
4609 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4610
4611 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4612 structure.
4613
4614 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4615
4616 * lisp.h (VWindow_system, Qfile_name_history):
4617 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4618 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4619 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4620
4621 * w32select.c: Don't #include "keyboard.h".
4622 (run_protected): Add extern declaration for waiting_for_input.
4623
4624 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4625 * w32console.c (detect_input_pending, read_input_pending)
4626 (encode_terminal_code):
4627 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4628 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4629 (w32_system_caret_y, Qfile_name_history):
4630 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4631 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4632 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4633 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4634 * w32proc.c (Qlocal, report_file_error):
4635 * w32term.c (Vwindow_system, updating_frame):
4636 * w32uniscribe.c (initialized, uniscribe_font_driver):
4637 Remove unneeded extern declarations.
4638
4639 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4640
4641 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4642
4643 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4644
4645 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4646 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4647 These macros can no longer be used for assignment.
4648
4649 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4650 Assign struct members directly, instead of using BUF_BEGV etc.
4651 (record_buffer_markers, fetch_buffer_markers): New functions for
4652 recording and fetching special buffer markers.
4653 (set_buffer_internal_1, set_buffer_temp): Use them.
4654
4655 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4656
4657 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4658
4659 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4660 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4661
4662 * xdisp.c (hscroll_window_tree):
4663 (reconsider_clip_changes): Use PT instead of BUF_PT.
4664
4665 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4666
4667 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4668 $(EMACS_ROOT)/lib/intprops.h.
4669
4670 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4671
4672 Fix more problems found by GCC 4.5.2's static checks.
4673
4674 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4675 to unsigned char * to avoid compiler diagnostic.
4676 (xg_free_frame_widgets): Make it clear that a local variable is
4677 needed only if USE_GTK_TOOLTIP.
4678 (gdk_window_get_screen): Make it clear that this macro is needed
4679 only if USE_GTK_TOOLTIP.
4680 (int_gtk_range_get_value): New function, which avoids a diagnostic
4681 from gcc -Wbad-function-cast.
4682 (xg_set_toolkit_scroll_bar_thumb): Use it.
4683 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4684 diagnostic from gcc -Wbad-function-cast.
4685 (get_utf8_string, xg_get_file_with_chooser):
4686 Rename locals to avoid shadowing.
4687 (create_dialog): Move locals to avoid shadowing.
4688
4689 * xgselect.c (xg_select): Remove unused var.
4690
4691 * image.c (four_corners_best): Mark locals as initialized.
4692 (gif_load): Initialize transparent_p to zero (Bug#8238).
4693 Mark another local as initialized.
4694 (my_png_error, my_error_exit): Mark with NO_RETURN.
4695
4696 * image.c (clear_image_cache): Now static.
4697 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4698 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4699 (x_edge_detection): Remove unnecessary cast that
4700 gcc -Wbad-function-cast diagnoses.
4701 (gif_load): Fix pointer signedness.
4702 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4703 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4704
4705 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4706
4707 Improve quality of tests for time stamp overflow.
4708 For example, without this patch (encode-time 0 0 0 1 1
4709 1152921504606846976) returns the obviously-bogus value (-948597
4710 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4711 reports time overflow. See
4712 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4713 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4714 * editfns.c: Include limits.h and intprops.h.
4715 (TIME_T_MIN, TIME_T_MAX): New macros.
4716 (time_overflow): Move earlier, to before first use.
4717 (hi_time, lo_time): New functions, for an accurate test for
4718 out-of-range times.
4719 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4720 (Fget_internal_run_time): Don't assume time_t fits in int.
4721 (make_time): Use list2 instead of Fcons twice.
4722 (Fdecode_time): More accurate test for out-of-range times.
4723 (check_tm_member): New function.
4724 (Fencode_time): Use it, to test for out-of-range times.
4725 (lisp_time_argument): Don't rely on undefined left-shift and
4726 right-shift behavior when checking for time stamp overflow.
4727
4728 * editfns.c (time_overflow): New function, refactoring common code.
4729 (Fformat_time_string, Fdecode_time, Fencode_time):
4730 (Fcurrent_time_string): Use it.
4731
4732 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4733 * dired.c (make_time): Move to ...
4734 * editfns.c (make_time): ... here.
4735 * systime.h: Note the move.
4736
4737 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4738
4739 * fringe.c (update_window_fringes): Remove unused variables.
4740
4741 * unexmacosx.c (copy_data_segment): Also copy __got section.
4742 (Bug#8223)
4743
4744 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4745
4746 * termcap.c [MSDOS]: Include "msdos.h".
4747 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4748 Constify `char *' arguments and their references according to
4749 prototypes in tparam.h.
4750
4751 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4752
4753 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4754 Adapt all references accordingly.
4755
4756 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4757
4758 2011-03-11 Tom Tromey <tromey@redhat.com>
4759
4760 * buffer.c (syms_of_buffer): Remove obsolete comment.
4761
4762 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4763
4764 * termhooks.h (encode_terminal_code): Declare prototype.
4765
4766 * msdos.c (encode_terminal_code): Don't declare prototype.
4767
4768 * term.c (encode_terminal_code): Now external again, used by
4769 w32console.c and msdos.c.
4770
4771 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4772 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4773
4774 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4775
4776 Fix some minor problems found by GCC 4.5.2's static checks.
4777
4778 * fringe.c (update_window_fringes): Mark locals as initialized
4779 (Bug#8227).
4780 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4781
4782 * alloc.c (mark_fringe_data): Move decl from here ...
4783 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4784 to check its interface.
4785 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4786
4787 * fontset.c (free_realized_fontset): Now static.
4788 (Fset_fontset_font): Rename local to avoid shadowing.
4789 (fontset_font): Mark local as initialized.
4790 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4791
4792 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4793
4794 * xselect.c (x_disown_buffer_selections): Remove; not used.
4795 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4796 (x_own_selection, Fx_disown_selection_internal): Rename locals
4797 to avoid shadowing.
4798 (x_handle_dnd_message): Remove local to avoid shadowing.
4799
4800 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4801 so that the caller can use some name other than gcpro1.
4802 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4803 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4804 (Fx_backspace_delete_keys_p):
4805 Use them to avoid shadowing, and rename vars to avoid shadowing.
4806 (x_decode_color, x_set_name, x_window): Now static.
4807 (Fx_create_frame): Add braces to silence GCC warning.
4808 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4809 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4810 Remove unused locals.
4811 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4812 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4813 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4814 macros.
4815
4816 * xterm.h (x_mouse_leave): New decl.
4817
4818 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4819 Remove unused functions.
4820 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4821 (x_calc_absolute_position): Now static.
4822 (XTread_socket): Don't define label "out" unless it's used.
4823 Don't declare local "event" unless it's used.
4824 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4825 unless they are used.
4826 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4827 (x_fatal_error_signal): Remove; not used.
4828 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4829 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4830 (x_error_catcher, x_connection_closed, x_error_handler):
4831 (x_error_quitter, xembed_send_message, x_iconify_frame):
4832 (my_log_handler): Rename locals to avoid shadowing.
4833 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4834 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4835
4836 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4837 Rename or move locals to avoid shadowing.
4838 (tty_defined_color, merge_face_heights): Now static.
4839 (free_realized_faces_for_fontset): Remove; not used.
4840 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4841 does not deduce is never used uninitialized.
4842 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4843 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4844
4845 * terminal.c (store_terminal_param): Now static.
4846
4847 * xmenu.c (menu_highlight_callback): Now static.
4848 (set_frame_menubar): Remove unused local.
4849 (xmenu_show): Rename parameter to avoid shadowing.
4850 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4851 since they might point to immutable storage.
4852 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4853 since it's unused otherwise.
4854
4855 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4856 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4857 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4858 avoids a gcc -Wuninitialized diagnostic.
4859 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4860 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4861 does not deduce are never used uninitialized.
4862
4863 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4864
4865 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4866 * window.c (window_loop, size_window):
4867 (run_window_configuration_change_hook, enlarge_window): Likewise.
4868
4869 * window.c (display_buffer): Now static.
4870 (size_window): Mark variables that gcc -Wuninitialized
4871 does not deduce are never used uninitialized.
4872 * window.h (check_all_windows): New decl, to forestall
4873 gcc -Wmissing-prototypes diagnostic.
4874 * dispextern.h (bidi_dump_cached_states): Likewise.
4875
4876 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4877 shadowing.
4878 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4879 Include <limits.h>.
4880 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4881 and to avoid gcc -Wuninitialized warning.
4882 (load_charset_map): Mark variables that gcc -Wuninitialized
4883 does not deduce are never used uninitialized.
4884 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4885
4886 * coding.c (coding_set_source, coding_set_destination):
4887 Use "else { /* comment */ }" rather than "else /* comment */;"
4888 for clarity, and to avoid gcc -Wempty-body warning.
4889 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4890 a block, when the outer 'i' will do.
4891 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4892 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4893 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4894 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4895 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4896 Rename locals to avoid shadowing.
4897 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4898 * coding.c (emacs_mule_char, encode_invocation_designation):
4899 Now static, since they're not used elsewhere.
4900 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4901 (decode_coding_object, encode_coding_object, detect_coding_system):
4902 (decode_coding_emacs_mule): Mark variables that gcc
4903 -Wuninitialized does not deduce are never used uninitialized.
4904 (detect_coding_iso_2022): Initialize a local variable that might
4905 be used uninitialized. Leave a FIXME because it's not clear that
4906 this initialization is needed. (Bug#8211)
4907 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4908 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4909 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4910 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4911 Remove unused macros.
4912
4913 * category.c (hash_get_category_set): Remove unused local var.
4914 (copy_category_table): Now static, since it's not used elsewhere.
4915 * character.c (string_count_byte8): Likewise.
4916
4917 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4918 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4919
4920 * chartab.c (copy_sub_char_table): Now static, since it's not used
4921 elsewhere.
4922 (sub_char_table_ref_and_range, char_table_ref_and_range):
4923 Rename locals to avoid shadowing.
4924 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4925
4926 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4927 (BIDI_BOB): Remove unused macro.
4928
4929 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4930 deduce are never used uninitialized.
4931 * term.c (encode_terminal_code): Likewise.
4932
4933 * term.c (encode_terminal_code): Now static. Remove unused local.
4934
4935 * tparam.h: New file.
4936 * term.c, tparam.h: Include it.
4937 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4938 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4939 Move these decls to tparam.h, and make them agree with what
4940 is actually in tparam.c. The previous trick of using incompatible
4941 decls in different modules does not conform to the C standard.
4942 All callers of tparam changed to use tparam's actual API.
4943 * tparam.c (tparam1, tparam, tgoto):
4944 Use const pointers where appropriate.
4945
4946 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4947 * cm.h (struct cm): Likewise.
4948 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4949 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4950 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4951 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4952 (turn_on_face, init_tty): Likewise.
4953 * termchar.h (struct tty_display_info): Likewise.
4954
4955 * term.c (term_mouse_position): Rename local to avoid shadowing.
4956
4957 * alloc.c (mark_ttys): Move decl from here ...
4958 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4959
4960 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4961
4962 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4963
4964 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4965
4966 * search.c (compile_pattern_1): Remove argument regp, unused since
4967 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4968 (compile_pattern): Don't pass it.
4969
4970 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4971
4972 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4973 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4974 for ! HAVE_GTK3.
4975 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4976
4977 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4978
4979 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4980 gdk_window_get_screen, gdk_window_get_geometry,
4981 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4982 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4983 (xg_get_pixbuf_from_pixmap): New function.
4984 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4985 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4986 Call xg_get_pixbuf_from_pixmap instead of
4987 gdk_pixbuf_get_from_drawable.
4988 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4989 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4990 (xg_check_special_colors): Use GtkStyleContext and its functions
4991 for HAVE_GTK3.
4992 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4993 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4994 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4995 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4996 Call gtk_widget_get_preferred_size.
4997 (xg_frame_resized): gdk_window_get_geometry only takes 5
4998 parameters.
4999 (xg_win_to_widget, xg_event_is_for_menubar):
5000 Call gdk_x11_window_lookup_for_display.
5001 (xg_set_widget_bg): New function.
5002 (delete_cb): New function.
5003 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5004 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5005 (xg_set_background_color): Call xg_set_widget_bg.
5006 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5007 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5008 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5009 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5010 if ! HAVE_GTK3.
5011 (update_frame_tool_bar): Call gtk_widget_hide.
5012 (xg_initialize): Use GDK_KEY_g.
5013
5014 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5015 if ! HAVE_GTK3
5016 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5017
5018 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5019 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5020 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5021
5022 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5023
5024 * w32xfns.c (select_palette): Check success of RealizePalette against
5025 GDI_ERROR, not zero.
5026
5027 See ChangeLog.11 for earlier changes.
5028
5029 ;; Local Variables:
5030 ;; coding: utf-8
5031 ;; End:
5032
5033 Copyright (C) 2011 Free Software Foundation, Inc.
5034
5035 This file is part of GNU Emacs.
5036
5037 GNU Emacs is free software: you can redistribute it and/or modify
5038 it under the terms of the GNU General Public License as published by
5039 the Free Software Foundation, either version 3 of the License, or
5040 (at your option) any later version.
5041
5042 GNU Emacs is distributed in the hope that it will be useful,
5043 but WITHOUT ANY WARRANTY; without even the implied warranty of
5044 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5045 GNU General Public License for more details.
5046
5047 You should have received a copy of the GNU General Public License
5048 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.