lispref/internals.texi Memory Usage tiny change
[bpt/emacs.git] / src / ChangeLog
1 2012-03-03 Glenn Morris <rgm@gnu.org>
2
3 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4
5 2012-03-02 Eli Zaretskii <eliz@gnu.org>
6
7 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
8 position past the first glyph_row that ends at ZV. (Bug#10902)
9 (redisplay_window, next_element_from_string): Fix typos in
10 comments.
11 (redisplay_window): Pass to move_it_vertically the margin in
12 pixels, not in screen lines.
13
14 2012-03-02 Glenn Morris <rgm@gnu.org>
15
16 * buffer.c (buffer-list-update-hook): Doc fix.
17
18 2012-02-29 Eli Zaretskii <eliz@gnu.org>
19
20 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
21 push_it before setting up the iterator for the first overlay
22 string, even if we have an empty string loaded.
23 (next_overlay_string): If there's an empty string on the iterator
24 stack, pop the stack. (Bug#10903)
25
26 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
27
28 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
29 Suggested by Stefan Monnier in
30 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
31 * alloc.c (widen_to_Lisp_Object): New static function.
32 (mark_memory): Also mark Lisp_Objects by fetching pointer words
33 and widening them to Lisp_Objects. This would work even if
34 USE_LSB_TAG is defined and wide integers are used, which might
35 happen in a future version of Emacs.
36
37 2012-02-25 Chong Yidong <cyd@gnu.org>
38
39 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
40 Doc fix.
41
42 * xselect.c (Fx_selection_exists_p): Doc fix.
43 (x_clipboard_manager_save_all): Print an informative message
44 before saving to clipboard manager.
45
46 2012-02-24 Chong Yidong <cyd@gnu.org>
47
48 * keyboard.c (process_special_events): Handle all X selection
49 requests in kbd_buffer, not just the next one (Bug#8869).
50
51 2012-02-23 Chong Yidong <cyd@gnu.org>
52
53 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
54 call when setting menu-bar-lines and tool-bar-lines parameters.
55 (unwind_create_frame_1): New helper function.
56
57 * window.c (inhibit_window_configuration_change_hook): New var.
58 (run_window_configuration_change_hook): Obey it.
59 (syms_of_window): Initialize it.
60
61 2012-02-22 Chong Yidong <cyd@gnu.org>
62
63 * xterm.c (x_draw_image_relief): Add missing type check for
64 Vtool_bar_button_margin (Bug#10743).
65
66 2012-02-21 Chong Yidong <cyd@gnu.org>
67
68 * fileio.c (Vfile_name_handler_alist): Doc fix.
69
70 * buffer.c (Fget_file_buffer): Protect against invalid file
71 handler return value.
72
73 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
74
75 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
76 when computing $valmask.
77
78 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
79 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
80 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
81 It's useless in that case, and it can cause problems on hosts
82 that allocate halves of EMACS_INT values separately.
83 Reported by Dan Horák. Diagnosed by Andreas Schwab in
84 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
85 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
86 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
87 it avoids undefined behavior on hosts where shifting right by more
88 than the word width has undefined behavior.
89
90 2012-02-19 Chong Yidong <cyd@gnu.org>
91
92 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
93 (Funhandled_file_name_directory, Ffile_name_as_directory)
94 (Fdirectory_file_name, Fexpand_file_name)
95 (Fsubstitute_in_file_name): Protect against invalid file handler
96 return values (Bug#10845).
97
98 2012-02-18 Eli Zaretskii <eliz@gnu.org>
99
100 * .gdbinit (pitx): Fix incorrect references to fields of the
101 iterator stack.
102
103 2012-02-17 Chong Yidong <cyd@gnu.org>
104
105 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
106
107 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
108
109 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
110 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
111
112 2012-02-15 Chong Yidong <cyd@gnu.org>
113
114 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
115 marked as special. Also, starting docstrings with * is obsolete.
116
117 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
118
119 * gnutls.c (emacs_gnutls_write): Fix last change.
120
121 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
122
123 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
124 send_process.
125
126 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
127
128 * keymap.c (Fsingle_key_description): Handle char ranges.
129
130 2012-02-12 Chong Yidong <cyd@gnu.org>
131
132 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
133 as that creates a dangerous corner case.
134
135 * window.c (Fdelete_window_internal): Invalidate the mouse
136 highlight (Bug#9904).
137
138 2012-02-12 Glenn Morris <rgm@gnu.org>
139
140 * xselect.c (Fx_own_selection_internal)
141 (Fx_get_selection_internal, Fx_disown_selection_internal)
142 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
143 * nsselect.m (Fx_own_selection_internal)
144 (Fx_disown_selection_internal, Fx_selection_exists_p)
145 (Fx_selection_owner_p, Fx_get_selection_internal):
146 Sync docs and argument specs with the xselect.c versions.
147
148 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
149
150 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
151
152 2012-02-11 Eli Zaretskii <eliz@gnu.org>
153
154 * w32select.c (Fx_selection_exists_p): Sync doc string and
155 argument list with xselect.c. (Bug#10783)
156
157 * w16select.c (Fx_selection_exists_p): Sync doc string and
158 argument list with xselect.c. (Bug#10783)
159
160 2012-02-10 Glenn Morris <rgm@gnu.org>
161
162 * fns.c (Fsecure_hash): Doc fix.
163
164 2012-02-09 Kenichi Handa <handa@m17n.org>
165
166 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
167
168 2012-02-07 Chong Yidong <cyd@gnu.org>
169
170 * buffer.c (Fbuffer_local_variables)
171 (buffer_lisp_local_variables): Handle unbound vars correctly;
172 don't let Qunbound leak into Lisp.
173
174 2012-02-07 Glenn Morris <rgm@gnu.org>
175
176 * image.c (Fimagemagick_types): Doc fix.
177
178 * image.c (imagemagick-render-type): Change it from a lisp object
179 to an integer. Move the doc here from the lisp manual.
180 Treat all values not equal to 0 the same.
181
182 2012-02-06 Chong Yidong <cyd@gnu.org>
183
184 * doc.c (store_function_docstring): Avoid applying docstring of
185 alias to base function (Bug#2603).
186
187 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
188
189 * .gdbinit (pp1, pv1): Remove redundant defines.
190 (pr): Use pp.
191
192 2012-02-04 Chong Yidong <cyd@gnu.org>
193
194 * nsterm.m: Declare a global (Bug#10694).
195
196 2012-02-04 Eli Zaretskii <eliz@gnu.org>
197
198 * w32.c (get_emacs_configuration_options): Include
199 --enable-checking, if specified, in the return value.
200
201 2012-02-04 Martin Rudalics <rudalics@gmx.at>
202
203 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
204 after rounding frame sizes. (Bug#9723)
205
206 2012-02-04 Eli Zaretskii <eliz@gnu.org>
207
208 * keyboard.c (adjust_point_for_property): Don't position point
209 before BEGV. (Bug#10696)
210
211 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
212
213 Handle overflow when computing char display width (Bug#9496).
214 * character.c (char_width): Return EMACS_INT, not int.
215 (char_width, c_string_width): Check for overflow when
216 computing the width; this is possible now that individual
217 characters can have unbounded width. Problem introduced
218 by merge from Emacs 23 on 2012-01-19.
219
220 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
221
222 * dbusbind.c (Fdbus_register_method): Mention the return value
223 :ignore in the docstring.
224
225 2012-02-02 Glenn Morris <rgm@gnu.org>
226
227 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
228
229 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
230 Unconditionally set to t. (Bug#10673)
231 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
232 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
233 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
234
235 2012-02-02 Kenichi Handa <handa@m17n.org>
236
237 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
238 0, do not call append_composite_glyph.
239
240 2012-02-02 Kenichi Handa <handa@m17n.org>
241
242 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
243 NULL (Bug#6988).
244 (x_produce_glyphs): If the component of a composition is a null
245 string, set it->pixel_width to 1 to avoid zero-width glyph.
246
247 2012-02-01 Eli Zaretskii <eliz@gnu.org>
248
249 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
250 first 2 arguments are identical. This makes inserting large
251 output from a subprocess an order of magnitude faster on
252 MS-Windows, where all sbrk'ed memory is always contiguous.
253
254 2012-01-31 Glenn Morris <rgm@gnu.org>
255
256 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
257 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
258 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
259
260 2012-01-29 Glenn Morris <rgm@gnu.org>
261
262 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
263
264 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
265
266 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
267
268 2012-01-28 Chong Yidong <cyd@gnu.org>
269
270 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
271
272 2012-01-26 Chong Yidong <cyd@gnu.org>
273
274 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
275
276 * search.c (Fsearch_forward, Fsearch_backward): Document negative
277 repeat counts (Bug#10507).
278
279 2012-01-26 Glenn Morris <rgm@gnu.org>
280
281 * lread.c (syms_of_lread): Doc fix.
282
283 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
284
285 * coding.c (encode_designation_at_bol): Change return value to
286 EMACS_INT.
287
288 2012-01-25 Chong Yidong <cyd@gnu.org>
289
290 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
291
292 2012-01-21 Chong Yidong <cyd@gnu.org>
293
294 * floatfns.c (Fcopysign): Make the second argument non-optional,
295 since nil is not allowed anyway.
296
297 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
298
299 * process.c (read_process_output): Use p instead of XPROCESS (proc).
300 (send_process): Likewise.
301
302 2012-01-19 Martin Rudalics <rudalics@gmx.at>
303
304 * window.c (save_window_save, Fcurrent_window_configuration)
305 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
306 doc-strings.
307
308 2012-01-19 Kenichi Handa <handa@m17n.org>
309
310 * character.c (char_width): New function.
311 (Fchar_width, c_string_width, lisp_string_width):
312 Use char_width (Bug#9496).
313
314 2012-01-16 Martin Rudalics <rudalics@gmx.at>
315
316 * window.c (Vwindow_persistent_parameters): New variable.
317 (Fset_window_configuration, save_window_save): Handle persistent
318 window parameters.
319
320 2012-01-14 Eli Zaretskii <eliz@gnu.org>
321
322 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
323 thrashing the stack of the thread. (Bug#9087)
324
325 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
326
327 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
328
329 2012-01-11 Eli Zaretskii <eliz@gnu.org>
330
331 * xdisp.c (rows_from_pos_range): Handle the case where the
332 highlight ends on a newline. (Bug#10464)
333 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
334 he end column for display of highlight that ends on a newline
335 before a R2L line.
336
337 2012-01-11 Glenn Morris <rgm@gnu.org>
338
339 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
340 from load-path also when installation-directory is nil. (Bug#10208)
341
342 2012-01-10 Glenn Morris <rgm@gnu.org>
343
344 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
345
346 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
347 Update template values to be closer to their typical values these days.
348
349 2012-01-09 Eli Zaretskii <eliz@gnu.org>
350
351 * xdisp.c (rows_from_pos_range): Accept additional argument
352 DISP_STRING, and accept any glyph in a row whose object is that
353 string as eligible for mouse highlight. Fixes mouse highlight of
354 display strings from overlays. (Bug#10464)
355
356 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
357
358 emacs: fix an auto-save permissions race condition (Bug#10400)
359 * fileio.c (auto_saving_dir_umask): New static var.
360 (Fmake_directory_internal): Use it.
361 (do_auto_save_make_dir): Set it, instead of invoking chmod after
362 creating the directory. The old code temporarily assigns
363 too-generous permissions to the directory.
364 (do_auto_save_eh): Clear it.
365 (Fdo_auto_save): Catch all errors, not just file errors, so
366 that the var is always cleared.
367
368 2012-01-07 Eli Zaretskii <eliz@gnu.org>
369
370 * search.c (scan_buffer): Pass character positions to
371 know_region_cache, not byte positions. (Bug#6540)
372
373 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
374
375 * w32.c (sys_rename): Report EXDEV when rename of a directory
376 fails because the target is on another logical disk. (Bug#10284)
377
378 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
379
380 * xterm.c (x_embed_request_focus): New function.
381
382 * xterm.h: Add prototype.
383
384 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
385
386 2012-01-05 Glenn Morris <rgm@gnu.org>
387
388 * emacs.c (emacs_copyright): Update short copyright year to 2012.
389
390 2012-01-01 Eli Zaretskii <eliz@gnu.org>
391
392 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
393 Load gnutls_transport_set_lowat only if GnuTLS version is below
394 2.11.1.
395 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
396 GnuTLS versions below 2.11.1.
397
398 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
399
400 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
401 to the doc string advising against its use for altering the way
402 windows are scrolled.
403
404 2011-12-28 Kenichi Handa <handa@m17n.org>
405
406 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
407 coding-system ASCII compatible only when it does not produce BOM
408 on encoding (Bug#10383).
409
410 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
411
412 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
413 can scroll.
414 (create_and_show_popup_menu): Always use menu_position_func for
415 Gtk3 (Bug#10361).
416
417 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
418
419 * callint.c (Fcall_interactively): Don't truncate prompt string.
420
421 2011-12-23 Eli Zaretskii <eliz@gnu.org>
422
423 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
424 property that ends at ZV, so that the bidi iteration could be
425 resumed from there (after widening). (Bug#10360)
426
427 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
428
429 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
430
431 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
432
433 * nsterm.m (x_free_frame_resources):
434 Release f->output_data.ns->miniimage.
435 (ns_index_color): Fix indentation. Do not retain
436 color_table->colors[i].
437
438 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
439 before returning.
440
441 * nsfns.m (x_set_background_color): Assign return value from
442 ns_index_color to face-background instead of NSColor*.
443 (ns_implicitly_set_icon_type): Fix indentation.
444 Change assignment in for loop to comparison.
445
446 * emacs.c (ns_pool): New variable.
447 (main): Assign ns_pool.
448 (Fkill_emacs): Call ns_release_autorelease_pool.
449
450 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
451 autorelease fdesc, release fdAttrs and tdict.
452 (ns_get_covering_families): Release charset.
453 (ns_findfonts): Release NSFontDescriptor created with new.
454 (ns_uni_to_glyphs): Fix indentation.
455 (setString): Release attrStr before assigning new value.
456
457 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
458
459 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
460 and NS_IMPL_COCOA.
461 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
462 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
463
464 2011-12-18 David Reitter <reitter@cmu.edu>
465
466 * nsterm.m (ns_term_init): Subscribe for notifications
467 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
468 to method trackingNotification in EmacsMenu.
469
470 * nsmenu.m (trackingMenu): New variable.
471 (trackingNotification): New method (from Aquamacs).
472 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
473 from Aquamacs (Bug#7030).
474
475 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
476
477 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
478 (symbol_to_nsstring): Fix indentation.
479 (ns_symbol_to_pb): New function.
480 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
481 (Fns_rotate_cut_buffers_internal): Removed.
482 (Fns_store_selection_internal): Renamed from
483 Fns_store_cut_buffer_internal.
484 (ns_get_foreign_selection, Fx_own_selection_internal)
485 (Fx_disown_selection_internal, Fx_selection_exists_p)
486 (Fns_get_selection_internal, Fns_store_selection_internal):
487 Use ns_symbol_to_pb and check if return value is nil.
488 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
489 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
490 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
491 renamed to Sns_store_selection_internal.
492 (ns_handle_selection_request): Move code to Fx_own_selection_internal
493 and remove this function.
494 (ns_handle_selection_clear): Remove, never used.
495 (Fx_own_selection_internal): Move code from ns_handle_selection_request
496 here.
497
498 2011-12-17 Ken Brown <kbrown@cornell.edu>
499
500 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
501 GID is unknown (Bug#10257).
502
503 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
504
505 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
506 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
507 which caused a build failure on GNU/Linux IA-64. This problem was
508 introduced by my 2011-10-07 patch.
509
510 2011-12-15 Juri Linkov <juri@jurta.org>
511
512 * image.c (imagemagick_error): New function. (Bug#10112)
513 (imagemagick_load_image): Comment out `MagickSetResolution' call.
514 Use `imagemagick_error' where ImageMagick functions return
515 `MagickFalse'.
516 (Fimagemagick_types): Add `Fnreverse' to return the list in the
517 proper order.
518
519 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
520
521 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
522 fill background (Bug#8992).
523
524 2011-12-13 Martin Rudalics <rudalics@gmx.at>
525
526 * window.c (Vwindow_combination_resize)
527 (Vwindow_combination_limit): Use t instead of non-nil in
528 doc-strings.
529 (Vrecenter_redisplay): Add first sentence of doc-string on
530 separate line.
531 (Frecenter): Fix doc-string typo.
532
533 2011-12-11 Kenichi Handa <handa@m17n.org>
534
535 * coding.c (Funencodable_char_position): Pay attention to the
536 buffer text relocation (Bug#9389).
537
538 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
539
540 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
541 gtk_init (Bug#10100).
542
543 2011-12-10 Eli Zaretskii <eliz@gnu.org>
544
545 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
546 IT->string is nil. (Bug#10263)
547
548 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
549
550 * nsterm.h (x_free_frame_resources): Declare.
551
552 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
553 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
554
555 * nsterm.h (ns_get_defaults_value): Declare.
556
557 * nsterm.m (ns_default): Call ns_get_defaults_value.
558
559 2011-12-09 Eli Zaretskii <eliz@gnu.org>
560
561 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
562 (Bug#10170)
563
564 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
565
566 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
567 that where the value of an _OBJC_* symbol points to is in the .bss
568 section (Bug#10240).
569
570 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
571
572 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
573 after the loop to call ccl_driver at least once (Bug#8619).
574
575 2011-12-08 Kenichi Handa <handa@m17n.org>
576
577 * ftfont.c (get_adstyle_property): Fix previous change
578 (Bug#10233).
579
580 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
581
582 * w32.c (init_environment): If no_site_lisp, remove site-lisp
583 dirs from the default value of EMACSLOADPATH (bug#10208).
584
585 2011-12-07 Glenn Morris <rgm@gnu.org>
586
587 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
588 installation and source directories as well. (Bug#10208)
589
590 2011-12-06 Chong Yidong <cyd@gnu.org>
591
592 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
593
594 2011-12-06 Glenn Morris <rgm@gnu.org>
595
596 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
597 as an error, not just -1. (Bug#10217)
598
599 2011-12-05 Chong Yidong <cyd@gnu.org>
600
601 * keyboard.c (process_special_events): New function.
602 (swallow_events, Finput_pending_p): Use it (Bug#10195).
603
604 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
605
606 * coding.c (encode_designation_at_bol): Don't use uninitialized
607 local variable (Bug#9318).
608
609 2011-12-05 Kenichi Handa <handa@m17n.org>
610
611 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
612 return Qnil (Bug#8046, Bug#10193).
613
614 2011-12-05 Kenichi Handa <handa@m17n.org>
615
616 * coding.c (encode_designation_at_bol): New args charbuf_end and
617 dst. Return the number of produced bytes. Callers changed.
618 (coding_set_source): Return how many bytes coding->source was
619 relocated.
620 (coding_set_destination): Return how many bytes
621 coding->destination was relocated.
622 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
623 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
624
625 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
626
627 * coding.c (CODING_CHAR_CHARSET_P): New macro.
628 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
629 macro (Bug#9318).
630
631 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
632
633 The following changes are to fix Bug#9318.
634
635 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
636 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
637 (encode_coding_iso_2022, encode_coding_sjis)
638 (encode_coding_big5, encode_coding_charset): Use the above macros.
639
640 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
641
642 * lisp.h (process_quit_flag): Fix external declaration.
643
644 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
645
646 Don't macro-inline non-performance-critical code.
647 * eval.c (process_quit_flag): New function.
648 * lisp.h (QUIT): Use it.
649
650 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
651
652 * nsfns.m (get_geometry_from_preferences): New function.
653 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
654
655 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
656
657 * emacs.c (Qkill_emacs): Define.
658 (syms_of_emacs): Initialize it.
659 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
660 Qquit_flag to `kill-emacs' instead.
661 (quit_throw_to_read_char): Add parameter `from_signal'.
662 All callers changed. Call Fkill_emacs if requested and safe.
663 * lisp.h (QUIT): Call Fkill_emacs if requested.
664
665 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
666
667 * widget.c (update_wm_hints): Return if wmshell is null.
668 (widget_update_wm_size_hints): New function.
669
670 * widget.h (widget_update_wm_size_hints): Declare.
671
672 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
673 widget_update_wm_size_hints (Bug#10104).
674
675 2011-12-03 Eli Zaretskii <eliz@gnu.org>
676
677 * xdisp.c (handle_invisible_prop): If the invisible text ends just
678 before a newline, prepare the bidi iterator for consuming the
679 newline, and keep the current paragraph direction. (Bug#10183)
680 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
681
682 2011-12-02 Juri Linkov <juri@jurta.org>
683
684 * search.c (Fword_search_regexp): New Lisp function created from
685 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
686 (Fword_search_backward, Fword_search_forward)
687 (Fword_search_backward_lax, Fword_search_forward_lax):
688 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
689 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
690
691 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
692
693 * fileio.c (Finsert_file_contents): Move after-change-function call
694 to before the "handled:" label, since all "goto handled" appear in
695 cases where the *-change-functions have already been properly called
696 (bug#10117).
697
698 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
699
700 * keyboard.c (interrupt_signal): Don't call kill-emacs when
701 waiting for input. (Bug#10169)
702
703 2011-11-30 Eli Zaretskii <eliz@gnu.org>
704
705 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
706 verifies glyph row's hash code--we have just reallocated the
707 glyphs, so their contents can be complete garbage. (Bug#10164)
708
709 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
710
711 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
712
713 2011-11-30 Eli Zaretskii <eliz@gnu.org>
714
715 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
716 attributes are tested _before_ calling verify_row_hash, to protect
717 against GCC re-ordering of the tests. (Bug#10164)
718
719 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
720
721 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
722
723 * xterm.c (handle_one_xevent): Only set async_visible and friends
724 if net_wm_state_hidden_seen is non-zero (Bug#10002)
725 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
726 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
727
728 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
729
730 Remove GCPRO-related macros that exist only to avoid shadowing locals.
731 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
732 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
733 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
734 All uses changed to use GCPRO1 etc.
735 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
736 Revert to old implementation (i.e., before 2011-03-11).
737
738 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
739
740 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
741 of scroll runs so as to avoid assigning disabled bogus rows and
742 unnecessary graphics copy operations.
743
744 2011-11-27 Eli Zaretskii <eliz@gnu.org>
745
746 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
747 (snprintf) [_MSC_VER]: Redirect to _snprintf.
748 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
749 (malloc, free, realloc, calloc): Redirect to e_* only when
750 compiling Emacs.
751
752 * lisp.h (GCTYPEBITS): Move before first use.
753 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
754 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
755 this macro definition.
756
757 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
758 _MSC_VER.
759
760 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
761
762 * gtkutil.c (xg_create_frame_widgets):
763 Call gtk_window_set_has_resize_grip (FALSE) if that function is
764 present with Gtk+ 2.0.
765
766 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
767
768 * fileio.c (Finsert_file_contents): Undo previous change; see
769 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
770
771 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
772
773 Rename locals to avoid shadowing.
774 * fileio.c (Finsert_file_contents):
775 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
776 * process.c (wait_reading_process_output):
777 Rename inner 'proc' to 'p' to avoid shadowing.
778 Indent for consistency with usual Emacs style.
779
780 2011-11-25 Eli Zaretskii <eliz@gnu.org>
781
782 * xdisp.c (redisplay_window): If cursor row is not fully visible
783 after recentering, and scroll-conservatively is set to a large
784 number, scroll window by a few more lines to make the cursor fully
785 visible and out of scroll-margin. (Bug#10105)
786 (start_display): Don't move to the next line if the display should
787 start at a newline that is part of a display vector or an overlay
788 string. (Bug#10119)
789
790 2011-11-24 Juri Linkov <juri@jurta.org>
791
792 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
793 after the `MagickPingImage' call. (Bug#10112)
794
795 2011-11-23 Chong Yidong <cyd@gnu.org>
796
797 * window.c (Fcoordinates_in_window_p): Accept only live windows.
798
799 2011-11-23 Martin Rudalics <rudalics@gmx.at>
800
801 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
802 making another buffer current. (Bug#10114)
803
804 2011-11-23 Glenn Morris <rgm@gnu.org>
805
806 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
807
808 2011-11-23 Chong Yidong <cyd@gnu.org>
809
810 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
811 using it (Bug#5984).
812
813 2011-11-22 Eli Zaretskii <eliz@gnu.org>
814
815 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
816 and header-lines, as they don't have one computed for them.
817 (Bug#10098)
818
819 * .gdbinit (prow): Make displayed values more self-explaining.
820 Add row's hash code.
821
822 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
823
824 * process.c (wait_reading_process_output): Fix asynchrounous
825 GnuTLS socket handling on some versions of the GnuTLS library.
826 (wait_reading_process_output): Add comment and URL.
827
828 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
829
830 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
831
832 2011-11-21 Chong Yidong <cyd@gnu.org>
833
834 * window.c (Fnext_window, Fprevious_window): Doc fix.
835
836 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
837
838 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
839
840 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
841
842 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
843
844 2011-11-20 Martin Rudalics <rudalics@gmx.at>
845
846 * window.c (Fset_window_combination_limit): Rename argument
847 STATUS to LIMIT.
848 (Vwindow_combination_limit): Remove "status" from doc-string.
849
850 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
851
852 * m/ibms390.h: Remove.
853 * m/ibms390x.h: Don't include "ibms390.h".
854
855 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
856
857 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
858 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
859
860 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
861
862 * casetab.c (Fset_case_table):
863 * charset.c (Fcharset_after): Fix typos.
864
865 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
866
867 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
868 Otherwise, valgrind does not work on some platforms.
869 Problem reported by Andreas Schwab in
870 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
871 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
872 is set, removing the need for VIRT_ADDRESS_VARIES.
873 (PURE_P): Use a more-efficient implementation that needs just one
874 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
875 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
876 to 4 (xorl, subq, cmpq, setbe).
877 * alloc.c (pure): Always extern now, since that's the
878 VIRT_ADDR_VARIES behavior.
879 (PURE_POINTER_P): Use a single comparison, not two, for
880 consistency with the new puresize.h.
881 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
882 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
883 Remove VIRT_ADDR_VARIES no longer needed.
884
885 2011-11-19 Eli Zaretskii <eliz@gnu.org>
886
887 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
888 (erase_phys_cursor, update_window_cursor, show_mouse_face)
889 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
890 behave as if the cursor position were at the window margin.
891
892 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
893 and the cursor position is out of bounds, behave as if the cursor
894 position were at the window margin. (Bug#10075)
895
896 2011-11-18 Chong Yidong <cyd@gnu.org>
897
898 * window.c (Fwindow_combination_limit): Make first argument
899 non-optional, since it is meaningless for live windows like the
900 selected window.
901
902 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
903
904 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
905
906 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
907
908 * intervals.c: Fix grafting over the whole buffer (bug#10071).
909 (graft_intervals_into_buffer): Simplify.
910
911 2011-11-18 Eli Zaretskii <eliz@gnu.org>
912
913 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
914 hash values of the two rows.
915 (copy_row_except_pointers): Preserve the used[] arrays and the
916 hash values of the two rows. (Bug#10035)
917 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
918
919 * xdisp.c (row_hash): New function, body extracted from
920 compute_line_metrics.
921 (compute_line_metrics): Call row_hash, instead of computing the
922 hash code inline.
923
924 * dispnew.c (verify_row_hash): Call row_hash for computing the
925 hash code of a row, instead of duplicating code from xdisp.c.
926
927 * dispextern.h (row_hash): Add prototype.
928
929 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
930
931 * frame.c (delete_frame): Don't delete the terminal when the last
932 X frame is closed if emacs is built with GTK toolkit.
933
934 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
935
936 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
937
938 2011-11-17 Martin Rudalics <rudalics@gmx.at>
939
940 * window.c (Vwindow_splits): Rename to
941 Vwindow_combination_resize. Suggested by Juri Linkov.
942 (Fsplit_window_internal): Use Vwindow_combination_resize instead
943 of Vwindow_splits.
944
945 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
946
947 * nsfns.m (Fns_font_name):
948 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
949
950 2011-11-16 Martin Rudalics <rudalics@gmx.at>
951
952 * window.h (window): Rename slot "nest" to "combination_limit".
953 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
954 (Fset_window_nest): Rename to Fset_window_combination_limit.
955 (Vwindow_nest): Rename to Vwindow_combination_limit.
956 (recombine_windows, make_parent_window, make_window)
957 (Fsplit_window_internal, saved_window)
958 (Fset_window_configuration, save_window_save): Rename all
959 occurrences of window_nest to window_combination_limit.
960
961 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
962
963 * image.c (imagemagick_load_image): Fix typo.
964
965 2011-11-14 Eli Zaretskii <eliz@gnu.org>
966
967 * xdisp.c (display_line): Move the call to
968 highlight_trailing_whitespace before the call to
969 compute_line_metrics, since the latter needs to see the final
970 faces of all the glyphs to compute ROW's hash value.
971 Fixes assertion violations in row_equal_p. (Bug#10035)
972
973 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
974
975 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
976 just return (bug#10044).
977
978 2011-11-12 Eli Zaretskii <eliz@gnu.org>
979
980 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
981 with user-defined heap size. Bump the default size of the temacs
982 heap to 27MB, to avoid memory warning when running temacs.
983 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
984
985 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
986 current_matrix and desired_matrix. (Bug#9990)
987 (verify_row_hash) [XASSERTS]: New function.
988 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
989 that the hash value of glyph rows is correct.
990
991 2011-11-12 Martin Rudalics <rudalics@gmx.at>
992
993 * window.h (window): Remove splits slot.
994 * window.c (Fwindow_splits, Fset_window_splits): Remove.
995 (Fdelete_other_windows_internal, make_parent_window)
996 (make_window, Fsplit_window_internal, Fdelete_window_internal)
997 (Fset_window_configuration, save_window_save): Don't deal with
998 split status of windows.
999 (saved_window): Remove splits slot.
1000 (Vwindow_splits): Rewrite doc-string.
1001
1002 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1003
1004 * xfns.c (unwind_create_frame):
1005 * nsfns.m (unwind_create_frame):
1006 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1007 Vframe_list (Bug#9999).
1008
1009 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1010
1011 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1012
1013 2011-11-11 Kenichi Handa <handa@m17n.org>
1014
1015 * callproc.c (Fcall_process): Set the member dst_multibyte of
1016 process_coding.
1017
1018 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1019
1020 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1021 avoid a crash (bug#9496).
1022
1023 2011-11-09 Chong Yidong <cyd@gnu.org>
1024
1025 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1026 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1027
1028 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1029
1030 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1031
1032 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1033
1034 Avoid some portability problems by eschewing 'extern inline' functions.
1035 The trivial performance wins aren't worth the portability hassles; see
1036 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1037 et seq.
1038 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1039 (window_box_width, window_box_left, window_box_left_offset)
1040 (window_box_right, window_box_right_offset): Undo previous change,
1041 by removing the "extern"s.
1042 * intervals.c (adjust_intervals_for_insertion)
1043 (adjust_intervals_for_deletion): Undo previous change,
1044 making these static again.
1045 (offset_intervals, temp_set_point_both, temp_set_point)
1046 (copy_intervals_to_string): No longer inline.
1047 * xdisp.c (window_text_bottom_y, window_box_width)
1048 (window_box_height, window_box_left_offset)
1049 (window_box_right_offset, window_box_left, window_box_right)
1050 (window_box): No longer inline.
1051
1052 2011-11-08 Chong Yidong <cyd@gnu.org>
1053
1054 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1055 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1056 Signal an error if not a live window.
1057 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1058 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1059
1060 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1061
1062 * lisp.h (syms_of_abbrev): Remove declaration.
1063 Reported by CHENG Gao <chenggao@royau.me>.
1064
1065 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1066
1067 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1068 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1069 of temacs in GUI mode.
1070
1071 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1072
1073 * window.h: Declare delete_all_child_windows instead of
1074 delete_all_subwindows.
1075 * window.c (Fwindow_nest, Fset_window_nest)
1076 (Fset_window_new_total, Fset_window_new_normal)
1077 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1078 (delete_all_subwindows): Rename to delete_all_child_windows.
1079 (Fdelete_other_windows_internal, Fset_window_configuration):
1080 Call delete_all_child_windows instead of delete_all_subwindows.
1081 * frame.c (delete_frame): Call delete_all_child_windows instead
1082 of delete_all_subwindows.
1083
1084 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1085
1086 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1087 This is also needed for porting to any host where GC_MARK_STACK is
1088 not GC_MAKE_GCPROS_NOOPS.
1089 (which_symbols): Use it.
1090
1091 2011-11-07 Kenichi Handa <handa@m17n.org>
1092
1093 * coding.c (coding_set_destination): Check coding->src_pos only
1094 when coding->src_object is a buffer (bug#9910).
1095
1096 * process.c (send_process): Set the member src_multibyte of coding
1097 to 0 (bug#9911) when sending a unibyte text.
1098
1099 * callproc.c (Fcall_process): Set the member src_multibyte of
1100 process_coding to 0 (bug#9912).
1101
1102 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1103
1104 * xmenu.c (cleanup_widget_value_tree): New function.
1105 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1106 calling free_menubar_widget_value_tree directly (Bug#9830).
1107
1108 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 Fix some portability problems with 'inline'.
1111 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1112 (window_box_width, window_box_left, window_box_left_offset)
1113 (window_box_right, window_box_right_offset): Declare extern.
1114 Otherwise, these inline functions do not conform to C99 and
1115 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1116 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1117 * intervals.c (adjust_intervals_for_insertion)
1118 (adjust_intervals_for_deletion): Now extern, because otherwise the
1119 extern inline functions 'offset_intervals' couldn't refer to it.
1120 (static_offset_intervals): Remove.
1121 (offset_intervals): Rewrite using the old contents of
1122 static_offset_intervals. The old version didn't conform to C99
1123 because an extern inline function contained a reference to an
1124 identifier with static linkage.
1125
1126 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1127
1128 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1129 GC.
1130
1131 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1132
1133 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1134 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1135 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1136 return Qleft_to_right.
1137
1138 2011-11-06 Chong Yidong <cyd@gnu.org>
1139
1140 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1141 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1142 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1143 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1144 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1145 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1146 (Fwindow_vscroll): Doc fix.
1147 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1148 argument, since it makes no sense to pass a live window and for
1149 consistency with window-child.
1150
1151 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1152
1153 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1154 support MSVC.
1155
1156 2011-11-05 Jason Rumney <jasonr@gnu.org>
1157
1158 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1159 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1160 fonts (Bug#6029).
1161 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1162 bitwise arithmetic preventing use of unicode-sip and non-truetype
1163 opentype fonts.
1164
1165 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1166
1167 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1168 "emacs"-only part.
1169
1170 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1171 initialization code to keep similarity to xfns.c after changes
1172 from 2011-11-05.
1173
1174 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1175
1176 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1177 (unwind_create_frame): New function (Bug#9943).
1178 (Fx_create_frame): Restructure code to be more similar to the one in
1179 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1180 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1181 Move terminal->reference_count++ just before making the frame official
1182 (Bug#9943).
1183
1184 * nsterm.m (x_free_frame_resources): New function.
1185 (x_destroy_window): Move code to x_free_frame_resources.
1186
1187 * xfns.c (unwind_create_frame): Fix comment.
1188 (Fx_create_frame, x_create_tip_frame):
1189 Move terminal->reference_count++ just before making the frame
1190 official. Move initialization of image_cache_refcount and
1191 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1192
1193 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1194
1195 Support MSVC build with newer versions of Visual Studio.
1196 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1197 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1198 nt/gmake.defs.
1199
1200 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1201 which are not supported by MSVC.
1202 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1203 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1204 bitfields.
1205 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1206 types in bitfields.
1207 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1208
1209 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1210
1211 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1212
1213 Support MSVC build with newer versions of Visual Studio.
1214 * w32.c: Don't include w32api.h for MSVC.
1215 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1216
1217 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1218 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1219 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1220 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1221 e_* cousins.
1222 (alloca) [_MSC_VER]: Define to _alloca.
1223
1224 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1225
1226 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1227
1228 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1229
1230 * xdisp.c (note_mouse_highlight): If either of
1231 previous/next-single-property-change returns nil, treat that as
1232 the beginning or the end of the buffer. (Bug#9955)
1233
1234 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1235
1236 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1237 label is not null (Bug#9951).
1238 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1239 may be NULL.
1240
1241 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1242
1243 * window.c (Fwindow_body_size): Mention in the doc string that the
1244 return value is in frame's canonical units. (Bug#9949)
1245
1246 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1247
1248 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1249
1250 * w32fns.c (unwind_create_frame): If needed, free the glyph
1251 matrices of the partially constructed frame. (Bug#9943)
1252 * xfns.c (unwind_create_frame): Likewise.
1253
1254 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1255
1256 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1257 Don't stop backward scan on the continuation glyph, even though
1258 its CHARPOS is positive.
1259 (mouse_face_from_buffer_pos, note_mouse_highlight):
1260 Rename cover_string to disp_string.
1261
1262 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1263
1264 * window.c (temp_output_buffer_show): Don't use
1265 Vtemp_buffer_show_specifiers.
1266 (Vtemp_buffer_show_specifiers): Remove unused variable.
1267
1268 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1269
1270 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1271 past the beginning of the current glyph matrix.
1272
1273 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1274
1275 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1276 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1277 HAVE_GTK3 (Bug#9869).
1278
1279 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1280 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1281
1282 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1283
1284 * xterm.c: Declare x_handle_net_wm_state to return int.
1285 (handle_one_xevent): Check if we are iconified but don't have
1286 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1287 (get_current_wm_state): Return non-zero if not hidden,
1288 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1289 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1290 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1291 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1292
1293 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1296 so that this new function doesn't get optimized away by a
1297 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1298
1299 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1300
1301 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1302
1303 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1304
1305 Fix the `xbytecode' command.
1306 * .gdbinit (xprintbytestr): New command.
1307 (xwhichsymbols): Rename from `which'; all callers changed.
1308 (xbytecode): Print the byte-code string as well.
1309
1310 2011-10-29 Kim Storm <storm@cua.dk>
1311
1312 * alloc.c (which_symbols): New function.
1313
1314 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1315
1316 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1317 line. (Bug#9903)
1318
1319 2011-10-29 Glenn Morris <rgm@gnu.org>
1320
1321 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1322 Not clear what it was for, and it causes various bugs. (Bug#9839)
1323
1324 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1325
1326 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1327 possible random value that matches one of those tested as
1328 condition to clear the mouse face.
1329
1330 2011-10-28 Chong Yidong <cyd@gnu.org>
1331
1332 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1333
1334 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1335
1336 * window.c (make_window): Initialize phys_cursor_on_p.
1337
1338 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1339
1340 * lisp.h (struct Lisp_Symbol): Update comments.
1341
1342 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1343
1344 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1345
1346 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1347
1348 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1349 <oslsachem@gmail.com> for helping to debug this.
1350
1351 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1352 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1353 (g_b_init_get_glyph_outline_w): New static variables.
1354 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1355 (GetGlyphOutlineW_Proc): New typedefs.
1356 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1357 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1358 New functions.
1359 (w32font_open_internal, compute_metrics):
1360 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1361 instead of calling the "wide" APIs directly.
1362
1363 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1364
1365 * w32.h (syms_of_w32font): Add prototype.
1366
1367 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1368
1369 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1370 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1371 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1372 (Fmove_to_window_line): Doc fix.
1373
1374 2011-10-27 Chong Yidong <cyd@gnu.org>
1375
1376 * process.c (make_process): Set gnutls_state to NULL.
1377
1378 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1379 non-NULL, regardless of GNUTLS_INITSTAGE.
1380 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1381 an error. Set process slots as soon as we allocate them.
1382
1383 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1384
1385 2011-10-27 Chong Yidong <cyd@gnu.org>
1386
1387 * gnutls.c (emacs_gnutls_deinit): New function.
1388 Deallocate credentials structures as well as calling gnutls_deinit.
1389 (Fgnutls_deinit, Fgnutls_boot): Use it.
1390
1391 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1392 (deactivate_process): Call emacs_gnutls_deinit.
1393
1394 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * image.c (x_create_x_image_and_pixmap):
1397 * w32.c (sys_rename, w32_delayed_load):
1398 * w32font.c (fill_in_logfont):
1399 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1400
1401 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1402
1403 * w32fns.c (w32_default_color_map): New function,
1404 extracted from Fw32_default_color_map.
1405 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1406
1407 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1408
1409 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1410
1411 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1412
1413 * keyboard.c (test_undefined): New function (bug#9751).
1414 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1415
1416 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1417
1418 * sysdep.c (init_sys_modes): Fix the check for the controlling
1419 terminal (Bug#6649).
1420
1421 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1422
1423 * dispextern.h (struct bidi_it): New member next_en_type.
1424
1425 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1426 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1427 current character, check also for next_en_type being WEAK_EN.
1428 (bidi_resolve_weak): Don't enter the expensive loop if the current
1429 position is before next_en_pos. Record the bidi type of the first
1430 non-ET, non-BN character we find, in addition to its position.
1431 (bidi_level_of_next_char): Invalidate next_en_type when
1432 next_en_pos is over-stepped.
1433
1434 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1437 * editfns.c: Rewrite current-time-zone so that it invokes
1438 the equivalent of (format-time-string "%Z") to get the time zone name.
1439 This fixes a bug when the time zone name contains characters that
1440 need converting from the system time locale to Emacs internal format.
1441 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1442 that patch fixed format-time-string to do the conversion, but
1443 I forgot to fix current-time-zone.
1444 (format_time_string): New function, containing most of
1445 what Fformat_time_string used to contain.
1446 (Fformat_time_string): Rewrite in terms of format_time_string.
1447 This doesn't change this function's behavior.
1448 (current-time-zone): Rewrite to use format_time_string.
1449 This fixes the bug reported by Michael Schierl in
1450 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1451 Jason Rumney's 2007-06-07 change worked around this bug, but
1452 didn't fix it.
1453 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1454
1455 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1456
1457 * xdisp.c (start_display): If the character at POS is displayed
1458 via a display vector, reset IT->current.dpvec_index to zero.
1459 (try_window_reusing_current_matrix): If a line ends in a display
1460 vector or the next line starts in a display vector, continue
1461 redrawing the window even though the character position of
1462 start_row was reached.
1463 (Bug#9771, part 2)
1464
1465 2011-10-18 Chong Yidong <cyd@gnu.org>
1466
1467 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1468 with nobreak-char-display too.
1469
1470 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1471
1472 Fix part 3 of bug#9771.
1473 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1474 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1475 non-neutral characters if the current character is a paragraph
1476 separator (a.k.a. Newline). This avoids running the same
1477 expensive loop twice, once when we consume the preceding newline
1478 and the other time when the line actually needs to be displayed.
1479 Avoid the loop when we see neutrals on the base embedding level
1480 following a character whose directionality is the same as the
1481 paragraph's. This avoids running the expensive loop when a line
1482 ends in a long sequence of neutrals, like control characters.
1483 Add assertion against STRONG_AL type. Slightly rearrange code
1484 that determines the type of a neutral given the first non-neutral
1485 that follows it.
1486 (bidi_level_of_next_char): Set next_en_pos to zero when
1487 invalidating its info.
1488
1489 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1490
1491 * xdisp.c (push_display_prop): Determine whether to record string
1492 or buffer position by IT->string, not by IT->method. Allow
1493 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1494 (move_it_vertically_backward): Don't look for character position
1495 immediately after the newline when in a continuation line.
1496 (Bug#9771, part 1)
1497
1498 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1499
1500 * window.c (coordinates_in_window): Rewrite and delabelize
1501 vertical border check. (Bug#5357) (Bug#9618)
1502
1503 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1504
1505 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1506 errors in XSetWindowBorder (bug#9310).
1507
1508 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1509
1510 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1511 avoid crash when xmalloc overrun checking is enabled.
1512
1513 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1514
1515 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1516 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1517 cursor motion with <left> and <right> arrow keys.
1518
1519 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1520 some callers set that themselves.
1521
1522 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1523
1524 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1525 display string and the previous row comes from the same string and
1526 is empty. (Bug#9739) (Bug#9738)
1527
1528 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1529
1530 * doc.c (get_doc_string): Encode file name (bug#9735).
1531
1532 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1533
1534 * bidi.c (bidi_level_of_next_char):
1535 * xdisp.c (get_visually_first_element): Remove old incorrect
1536 comments regarding the Unicode Line Separator character.
1537
1538 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1539
1540 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1541
1542 * alloc.c (Fgc_status): Do not access beyond zombies array
1543 boundary if nzombies > MAX_ZOMBIES.
1544 * alloc.c (dump_zombies): Add missing format specifier.
1545
1546 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1547
1548 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1549 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1550
1551 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1552 Some packages use them to denote characters with modifiers.
1553
1554 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1555
1556 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1557 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1558 matching a pp-number. Rename parameter var to var1.
1559
1560 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1561
1562 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1563
1564 2011-10-08 Glenn Morris <rgm@gnu.org>
1565
1566 * callint.c (Fcall_interactively): Give a more explicit error for the
1567 'c' case with a non-character input. (Bug#8479)
1568
1569 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1570
1571 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1572 lines.
1573 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1574 lines that are hscrolled on the left.
1575
1576 * dispnew.c (buffer_posn_from_coords): Account for a possible
1577 presence of header-line. (Bug#4426)
1578
1579 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1580
1581 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1582 Don't advertise functionality which we discourage or doesn't work.
1583
1584 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1585
1586 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1587 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1588 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1589 this makes Emacs dump core during garbage collection on rare
1590 occasions. sizeof is obviously inferior to offsetof here, so
1591 stick with offsetof.
1592 (GC_POINTER_ALIGNMENT): New macro.
1593 (mark_memory): Omit 3rd (offset) arg; caller changed.
1594 Don't assume EMACS_INT alignment is the same as pointer alignment.
1595
1596 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1597
1598 * keyboard.c (read_key_sequence_remapped): New var.
1599 (read_key_sequence): Compute remapping in the right buffer.
1600 (command_loop_1): Use read_key_sequence's remapping directly.
1601
1602 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1603
1604 * dired.c (file_name_completion): Don't expand file name.
1605 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1606 before checking file name handler.
1607
1608 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1609 they've been requested explicitly (bug#9591).
1610
1611 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1612
1613 * keymap.c (Fsingle_key_description): Use make_specified_string
1614 instead of build_string to build string from push_key_description.
1615 (Bug#5193)
1616
1617 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1618
1619 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1620 This fixes a Y2038 bug on 64-bit hosts.
1621 * buffer.c (reset_buffer):
1622 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1623 (Fclear_buffer_auto_save_failure):
1624 Use 0, not -1, to represent an unset failure time, since time_t
1625 might not be signed.
1626
1627 Remove dependency on glibc malloc internals.
1628 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1629 Move back here from lisp.h, but with their new implementations.
1630 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1631 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1632 * charset.c (charset_table_init): New static var.
1633 (syms_of_charset): Use it instead of xmalloc. This removes a
1634 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1635 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1636 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1637 Move back to alloc.c.
1638 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1639 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1640
1641 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1642
1643 * nsterm.m (windowDidResize): Call x_set_window_size only when
1644 ns_in_resize is true. Otherwise set pixelwidth/height and
1645 call change_frame_size (Bug#9628).
1646
1647 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1648
1649 Port --enable-checking=all to Fedora 14 x86-64.
1650 * charset.c (syms_of_charset): Also account for glibc malloc's
1651 internal overhead when calculating the initial malloc maximum.
1652
1653 Port --enable-checking=all to Fedora 14 x86.
1654 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1655 Move to lisp.h.
1656 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1657 (overrun_check_realloc, overrun_check_free):
1658 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1659 That way, xmalloc returns a properly-aligned pointer even if
1660 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1661 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1662 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1663 into account when calculating the initial malloc maximum.
1664 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1665 Move here from alloc.c, so that charset.c can use it too.
1666 Properly align; the old code wasn't right for common 32-bit hosts
1667 when configured with --enable-checking=all.
1668 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1669 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1670
1671 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1672
1673 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1674 use EDOM.
1675
1676 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1677
1678 * xdisp.c (compute_display_string_end): If there's no display
1679 string at CHARPOS, return -1.
1680
1681 * bidi.c (bidi_fetch_char): When compute_display_string_end
1682 returns a negative value, treat the character as a normal
1683 character not covered by a display string. (Bug#9624)
1684
1685 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1686
1687 * lread.c (Fread_from_string): Fix typo in docstring.
1688
1689 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1690
1691 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1692 newline, reseat the iterator instead of bidi-iterating there one
1693 character at a time. (Bug#9610)
1694 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1695 TO_CHARPOS if the bidi iterator is at base embedding level.
1696
1697 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1698
1699 * lread.c (readevalloop): Use correct code for NBSP.
1700 (read1): Likewise. (Bug#9608)
1701
1702 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1703
1704 * dbusbind.c (Fdbus_register_signal): When service is not
1705 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1706
1707 2011-09-25 Glenn Morris <rgm@gnu.org>
1708
1709 * buffer.c (truncate-lines): Doc fix.
1710
1711 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1712
1713 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1714 (Fset_window_next_buffers): Doc fix.
1715
1716 2011-09-24 Glenn Morris <rgm@gnu.org>
1717
1718 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1719
1720 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1721
1722 Fix minor problems found by static checking.
1723 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1724 * indent.c (Fvertical_motion): Fix == vs = typo.
1725
1726 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1727
1728 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1729 Default value is now t. Doc fix.
1730
1731 * indent.c (Fvertical_motion): Compute and apply the overshoot
1732 logic when moving up, not only when moving down. Fix the
1733 confusing name and values of the it_overshoot_expected variable;
1734 logic changes accordingly. (Bug#9254) (Bug#9549)
1735
1736 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1737 CHARPOS is covered by a display string which includes newlines.
1738 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1739 is covered by a display string with embedded newlines.
1740
1741 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1742
1743 * dbusbind.c (Fdbus_register_signal): Add match rule to
1744 Vdbus_registered_objects_table. (Bug#9581)
1745 (Fdbus_register_method, Vdbus_registered_objects_table):
1746 Fix docstring.
1747
1748 2011-09-24 Jim Meyering <meyering@redhat.com>
1749
1750 do not ignore write error for any output size
1751 The previous change was incomplete.
1752 While it makes emacs --batch detect the vast majority of stdout
1753 write failures, errors were still ignored whenever the output size is
1754 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1755 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1756 && echo FAIL: ignored write error
1757 FAIL: ignored write error
1758 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1759 && echo FAIL: ignored write error
1760 FAIL: ignored write error
1761 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1762
1763 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1764
1765 * emacs.c (Fkill_emacs): In noninteractive mode exit
1766 non-successfully if a write error occurred on stdout. (Bug#9574)
1767
1768 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1769
1770 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1771 the xassert test.
1772
1773 * dispextern.h (struct it): Update the comment documenting what
1774 can it->OBJECT be.
1775
1776 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1777
1778 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1779 a display string, extend search for cursor position to end of row.
1780 (find_row_edges): If the row ends in a newline from a display
1781 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1782 Handle the case of a display string with multiple newlines.
1783 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1784 non-empty line. Fixes confusing cursor motion with arrow keys at
1785 the beginning of a line that starts with whitespace.
1786
1787 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1788
1789 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1790 (bug#9493).
1791
1792 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1793
1794 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1795 boolean (Bug#9154).
1796
1797 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1798
1799 * xdisp.c (display_line): Record maximum and minimum buffer
1800 positions even if no glyphs were produced (e.g., by a zero-width
1801 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1802 buffer positions that will be removed from the glyph row because
1803 they don't fit.
1804 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1805 column is beyond frame width: don't subtract 1 "pixel" when
1806 computing width of the stretch.
1807 (reseat_at_next_visible_line_start): Undo the change made on
1808 2011-09-17 that saved paragraph information and restored it after
1809 the call to `reseat'. (Bug#9545)
1810
1811 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1812
1813 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1814 and turn window cursor on if cleared (Bug#9415).
1815
1816 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1817
1818 * search.c (boyer_moore): Take unibyte characters from pattern
1819 literally. (Bug#9458)
1820
1821 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1822
1823 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1824
1825 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1826
1827 Fix minor problem found by static checking.
1828 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1829 initialized, to pacify gcc -Wuninitialized.
1830
1831 * fileio.c: Report proper errno when syscall falls.
1832 (Finsert_file_contents): Save and restore errno,
1833 so that report_file_error outputs the correct diagnostic.
1834 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1835
1836 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1837
1838 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1839
1840 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1841
1842 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1843 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1844
1845 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1846
1847 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1848 about the current paragraph and restore it after the call to reseat.
1849
1850 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1851 (bidi_find_paragraph_start): Search back for paragraph beginning
1852 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1853 (bidi_move_to_visually_next): Only trigger paragraph-related
1854 computations when the last character is a newline or at EOB, not
1855 just any NEUTRAL_B. (Bug#9470)
1856
1857 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1858 truncated lines if point is covered by a display string. (Bug#9524)
1859
1860 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1861
1862 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1863 (cons_to_x_long): New function.
1864 (lisp_data_to_selection_data): Use it. Correct the test for
1865 short-versus-long data; it was negated. Break out of vector
1866 loop, for efficiency, when a long datum is discovered.
1867
1868 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1869
1870 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1871
1872 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1873
1874 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1875 GCC PR/17406) by declaring this function with external scope.
1876
1877 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1878
1879 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1880 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1881
1882 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1883
1884 * editfns.c (Fformat): Correctly handle text properties on "%%".
1885
1886 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1887
1888 * xterm.c (x_draw_composite_glyph_string_foreground):
1889 * w32term.c (x_draw_composite_glyph_string_foreground):
1890 * term.c (encode_terminal_code):
1891 * composite.c (composition_update_it, get_composition_id):
1892 * xdisp.c (get_next_display_element)
1893 (fill_composite_glyph_string): Add comments about special meaning
1894 of TAB characters in a composition.
1895
1896 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1897
1898 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1899 This occurs when processing a multibyte format.
1900 Problem reported by Wolfgang Jenker.
1901
1902 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1903
1904 * xdisp.c (try_cursor_movement): Only check for exact match if
1905 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1906
1907 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1908
1909 Remove unused external symbols.
1910 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1911 * xdisp.c (calc_pixel_width_or_height): Now static.
1912 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1913 * indent.c (check_display_width):
1914 * w32term.c: Fix comment to match code.
1915 * xterm.c, xterm.h (x_catching_errors): Remove.
1916
1917 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1918
1919 * xselect.c: Use signed conversions more consistently (Bug#9498).
1920 (selection_data_to_lisp_data): Assume incoming selection data are
1921 signed integers, not unsigned. This is to be consistent with
1922 outgoing selection data, which was modified to use signed integers
1923 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1924 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1925 expects long, not unsigned long.
1926
1927 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1928
1929 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1930 computation of loop end. Reported by Johan Bockgård
1931 <bojohan@gnu.org>.
1932
1933 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1934
1935 * frame.c (Fother_visible_frames_p): Function deleted.
1936
1937 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1938
1939 * indent.c (compute_motion): Process display vector front to back
1940 rather than the other way around. (Bug#2496)
1941
1942 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1943
1944 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1945
1946 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1947
1948 * minibuf.c (Fread_from_minibuffer): Doc fix.
1949
1950 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1951
1952 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1953 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1954
1955 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1956
1957 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1958 value for non-existent files.
1959
1960 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1961
1962 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1963 set its "size" to -1. This will set the modtime_size field of
1964 the corresponding buffer to -1, which is what
1965 verify-visited-file-modtime expects for files that do not exist.
1966 (Bug#9139)
1967
1968 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1969
1970 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1971 here ...
1972 * lisp.h: ... from here. push_key_description is no longer
1973 defined in keyboard.c, so its declaration should not be in
1974 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1975 logically belongs with push_key_description.
1976
1977 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1978
1979 * buffer.h: Include <sys/types.h> instead of <time.h>.
1980 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1981 Problem reported by Herbert J. Skuhra.
1982
1983 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1984
1985 * xml.c (parse_region): Make the parsing work for
1986 non-comment-starting XML files again (bug#9144).
1987
1988 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1989
1990 * image.c (gif_load): Fix calculation of bottom and right corner.
1991 (Bug#9468)
1992
1993 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1994
1995 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1996 redisplay in small windows.
1997
1998 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1999
2000 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2001
2002 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2003
2004 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2005 Operate on live windows only.
2006
2007 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2008
2009 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2010
2011 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2012
2013 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2014 only under bidi iteration.
2015
2016 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2017
2018 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2019
2020 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2021
2022 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2023 Without this fix, the command to link temacs failed due to an
2024 undefined symbol __builtin_isnan. This is because
2025 /usr/include/iso/math_c99.h #defines isnan(x) to
2026 __builtin_isnan(x), but the bundled gcc, which identifies itself
2027 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2028 a __builtin_isnan.
2029 * floatfns.c (isnan): #undef, and then #define to a clone of
2030 what's in data.c.
2031 (Fisnan): Always define, since it's always available now.
2032 (syms_of_floatfns): Always define isnan at the Lisp level.
2033
2034 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2037
2038 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2041 The previous code assumed that file offsets (off_t values) fit in
2042 EMACS_INT variables, which is not true on typical 32-bit hosts.
2043 The code messed up by falsely reporting buffer overflow in cases
2044 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2045 when "big" contains more than 2**29 bytes, even though this
2046 inserts just one byte and does not overflow the buffer.
2047 (Finsert_file_contents): Store file offsets as off_t
2048 values, not as EMACS_INT values. Check for overflow when
2049 converting between EMACS_INT and off_t. When checking for
2050 buffer overflow or for overlap, take the offsets into account.
2051 Don't use EMACS_INT for small values where int suffices.
2052 When checking for overlap, fix a typo: ZV was used where
2053 ZV_BYTE was intended.
2054 (Fwrite_region): Don't assume off_t fits into 'long'.
2055 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2056
2057 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2058
2059 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2060
2061 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 sprintf-related integer and memory overflow issues (Bug#9412).
2064
2065 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2066 (esprintf, exprintf, evxprintf): New functions.
2067 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2068 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2069 (modify_event_symbol): Do not assume that the length of
2070 name_alist_or_stem is safe to alloca and fits in int.
2071 (Fexecute_extended_command): Likewise for function name and binding.
2072 (Frecursion_depth): Wrap around reliably on integer overflow.
2073 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2074 since some callers pass EMACS_INT values.
2075 (Fsingle_key_description): Don't crash if symbol name contains more
2076 than MAX_ALLOCA bytes.
2077 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2078 (get_minibuffer): Arg is now EMACS_INT, not int.
2079 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2080 (esprintf, exprintf, evxprintf): New decls.
2081 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2082
2083 * dbusbind.c (signature_cat): New function.
2084 (xd_signature, Fdbus_register_signal):
2085 Do not overrun buffer; instead, report string overflow.
2086
2087 * dispnew.c (add_window_display_history): Don't overrun buffer.
2088 Truncate instead; this is OK since it's just a log.
2089
2090 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2091 even if the time zone offset is outlandishly large.
2092 Don't mishandle offset == INT_MIN.
2093
2094 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2095 when creating daemon; the previous buffer-overflow check was incorrect.
2096
2097 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2098 which has the guts of the old verror function.
2099
2100 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2101 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2102
2103 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2104 (font_unparse_xlfd): Don't blindly alloca long strings.
2105 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2106 fits in int, when using sprintf. Use single snprintf to count
2107 length of string rather than counting it via multiple sprintfs;
2108 that's simpler and more reliable.
2109 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2110 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2111 sprintf, in case result does not fit in int.
2112
2113 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2114 (fontset_from_font): Print it.
2115
2116 * frame.c (tty_frame_count): Now printmax_t, not int.
2117 (make_terminal_frame, set_term_frame_name): Print it.
2118 (x_report_frame_params): In X, window IDs are unsigned long,
2119 not signed long, so print them as unsigned.
2120 (validate_x_resource_name): Check for implausibly long names,
2121 and don't assume name length fits in 'int'.
2122 (x_get_resource_string): Don't blindly alloca invocation name;
2123 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2124 not fit in int.
2125
2126 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2127 (xg_check_special_colors, xg_set_geometry):
2128 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2129
2130 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2131 Use esprintf, not sprintf, in case result does not fit in int.
2132
2133 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2134 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2135 it as a large positive number.
2136 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2137 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2138
2139 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2140 in case result does not fit in int.
2141
2142 * print.c (float_to_string): Detect width overflow more reliably.
2143 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2144 buffer overrun. Don't assume list length fits in 'int'. Treat
2145 print length of 0 as 0, not as infinity; to be consistent with other
2146 uses of print length in this function. Don't overflow print length
2147 index. Don't assume hash table size fits in 'long', or that
2148 vectorlike size fits in 'unsigned long'.
2149
2150 * process.c (make_process): Use printmax_t, not int, to format
2151 process-name gensyms.
2152
2153 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2154
2155 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2156 to avoid potential buffer overrun.
2157
2158 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2159 if X resource line is longer than 512 bytes.
2160
2161 * xfns.c (x_window): Make sprintf buffer a bit bigger
2162 to avoid potential buffer overrun.
2163
2164 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2165
2166 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2167
2168 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 Integer overflow fixes for scrolling, etc.
2171 Without these, Emacs silently mishandles large integers sometimes.
2172 For example, "C-u 4294967297 M-x recenter" was treated as if
2173 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2174
2175 * xdisp.c (try_window_id): Check Emacs fixnum range before
2176 converting to 'int'.
2177
2178 * window.c (window_scroll_line_based, Frecenter):
2179 Check that an Emacs fixnum is in range before assigning it to 'int'.
2180 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2181 values converted from Emacs fixnums.
2182 (Frecenter): Don't wrap around a line count if it is out of 'int'
2183 range; instead, treat it as an extreme value.
2184 (Fset_window_configuration, compare_window_configurations):
2185 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2186
2187 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2188 that can exceed INT_MAX. Check that EMACS_INT value is in range
2189 before assigning it to the (possibly-narrower) index.
2190 (match_limit): Don't assume that a fixnum can fit in 'int'.
2191
2192 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2193 exceed INT_MAX.
2194
2195 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2196 (Fvertical_motion): Don't wrap around LINES values that don't fit
2197 in 'int'. Instead, treat them as extreme values. This is good
2198 enough for windows, which can't have more than INT_MAX lines anyway.
2199
2200 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2201
2202 * Require libxml/parser.h to avoid compilation warning.
2203
2204 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2205
2206 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2207 since this reportedly can destroy thread storage.
2208
2209 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2210
2211 * syntax.c (find_defun_start): Update all cache variables if
2212 exiting early (Bug#9401).
2213
2214 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2215
2216 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2217
2218 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2219 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2220 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2221
2222 * term.c (tty_append_glyph): New function.
2223 (produce_stretch_glyph): Static function and its prototype deleted.
2224
2225 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2226 Add prototypes.
2227
2228 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2229
2230 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2231 when checking :margin (Bug#9390).
2232 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2233 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2234 so that the name doesn't mislead. All uses changed.
2235
2236 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2237
2238 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2239 set_tty_hooks.
2240
2241 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2242
2243 * xdisp.c (move_it_to): Don't bail out early when reaching
2244 position beyond to_charpos, if we are scanning backwards.
2245 (move_it_vertically_backward): When DY == 0, make sure we get to
2246 the first character in the line after the newline.
2247
2248 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2249
2250 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2251 (ccl_driver): Do not generate an out-of-range pointer.
2252 (Fccl_execute_on_string): Remove unnecessary check for
2253 integer overflow, noted by Stefan Monnier in
2254 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2255 Remove a FIXME that didn't need fixing.
2256 Simplify the newly-introduced buffer reallocation code.
2257
2258 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2259
2260 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2261
2262 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2263
2264 Integer and memory overflow issues (Bug#9196).
2265
2266 * doc.c (get_doc_string): Rework so that
2267 get_doc_string_buffer_size is the actual buffer size, rather than
2268 being 1 less than the actual buffer size; this makes xpalloc more
2269 convenient.
2270
2271 * image.c (x_allocate_bitmap_record, cache_image):
2272 * xselect.c (Fx_register_dnd_atom):
2273 Simplify previous changes by using xpalloc.
2274
2275 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2276 since either will do and ptrdiff_t is convenient with xpalloc.
2277
2278 * charset.c (charset_table_size)
2279 (struct charset_sort_data.priority): Now ptrdiff_t.
2280 (charset_compare): Don't overflow if priorities differ greatly.
2281 (Fsort_charsets): Don't assume list length fits in int.
2282 Check for size-calculation overflow when allocating sort data.
2283 (syms_of_charset): Allocate an initial charset table that is
2284 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2285
2286 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2287
2288 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2289 The actual value is always <= INT_MAX, and leaving it unsigned made
2290 overflow checking harder.
2291
2292 * dispextern.h (struct glyph_matrix.rows_allocated)
2293 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2294 with xpalloc. The values are still always <= INT_MAX.
2295
2296 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2297
2298 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2299 (SAFE_NALLOCA): New macro.
2300
2301 * region-cache.c (struct boundary.pos, find_cache_boundary)
2302 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2303 (set_cache_region, invalidate_region_cache)
2304 (revalidate_region_cache, know_region_cache, region_cache_forward)
2305 (region_cache_backward, pp_cache):
2306 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2307 so that ptrdiff_t * can be passed to xpalloc.
2308 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2309 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2310 (pp_cache): Don't assume cache_len fits in int.
2311 * region-cache.h: Adjust extern decls to match.
2312
2313 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2314 EMACS_INT, since either will do, for xpalloc.
2315
2316 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2317 (xnmalloc, xnrealloc, xpalloc): New functions.
2318
2319 * bidi.c (bidi_shelve_header_size): New constant.
2320 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2321 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2322
2323 * bidi.c (bidi_cache_shrink):
2324 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2325 (overlay_strings):
2326 Don't update size of array until after memory allocation succeeds,
2327 because xmalloc/xrealloc may not return.
2328 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2329 now that we have proper integer overflow checking.
2330 (record_overlay_string, overlay_strings): Catch overflows when
2331 calculating size of overlay_str_buf.
2332
2333 * callproc.c (Fcall_process): Check for size overflow when
2334 calculating size of args2.
2335 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2336 Normally we prefer signed values, but sticking with ptrdiff_t would
2337 require adding more-complicated checks.
2338
2339 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2340 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2341 Redo buffer-overflow calculations to avoid integer overflow.
2342 Add a FIXME comment where memory seems to be over-allocated.
2343
2344 * character.c (Fstring): Check for size-calculation overflow.
2345
2346 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2347 unnecessary integer overflow. Check for size overflow.
2348 (encode_coding_object): Don't update size until xmalloc succeeds.
2349
2350 * composite.c (get_composition_id): Check for overflow in glyph
2351 length calculations.
2352
2353 Integer and memory overflow fixes for display code.
2354 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2355 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2356 (scrolling_window): Check for overflow in size calculations.
2357 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2358 Don't assume glyph table len fits in int.
2359 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2360 (row_table_size): Now ptrdiff_t, not int.
2361 (scrolling_window): Avoid overflow in size calculations.
2362 Don't update size until allocation succeeds.
2363 * fns.c (concat): Check for overflow in size calculations.
2364 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2365 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2366 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2367
2368 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2369 (get_doc_string): Check for size calculation overflow.
2370 Don't update size until allocation succeeds.
2371 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2372 EMACS_INT, where ptrdiff_t will do.
2373 (Fsubstitute_command_keys): Check for string overflow.
2374
2375 * editfns.c (set_time_zone_rule): Don't assume environment length
2376 fits in int.
2377 (message_length): Now ptrdiff_t, not int.
2378 (Fmessage_box): Don't update size until allocation succeeds.
2379 Don't assume message length fits in int.
2380 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2381
2382 * emacs.c (main): Do not reallocate argv, since there is a null at
2383 the end that can be overwritten, and this way there's no need to
2384 worry about size-calculation overflow.
2385 (sort_args): Check for size-calculation overflow.
2386
2387 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2388 alloc succeeds.
2389 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2390
2391 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2392 (x_set_scroll_bar_width, x_figure_window_size):
2393 Check for integer overflow.
2394 (x_set_alpha): Do not assume XINT fits in int.
2395
2396 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2397 This is for the members text_lines, text_cols, total_lines, total_cols,
2398 where the system imposes an 'int' limit.
2399
2400 * fringe.c (Fdefine_fringe_bitmap):
2401 Don't update size until alloc works.
2402
2403 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2404 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2405
2406 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2407 Check for size-calculation overflow.
2408 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2409 do, as we prefer signed integers.
2410 (id_to_widget.max_size, id_to_widget.used)
2411 (xg_store_widget_in_map, xg_remove_widget_from_map)
2412 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2413 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2414 Use and return ptrdiff_t, not int.
2415 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2416 * gtkutil.h: Change prototypes to match the above.
2417
2418 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2419 are duplicate now that they've been promoted to lisp.h.
2420 (x_allocate_bitmap_record, x_alloc_image_color)
2421 (make_image_cache, cache_image, xpm_load):
2422 Don't update size until alloc is done.
2423 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2424 (x_detect_edges):
2425 Check for size calculation overflow.
2426 (ct_colors_allocated_max): New constant.
2427 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2428 overflow.
2429
2430 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2431 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2432 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2433 Use ptrdiff_t, not int, to count maps.
2434 (read_char_minibuf_menu_prompt): Check for overflow in size
2435 calculations. Don't update size until allocation succeeds.
2436 Redo calculations to avoid overflow.
2437 * keyboard.h: Change prototypes to match the above.
2438
2439 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2440 to count maps.
2441 (current_minor_maps): Check for size calculation overflow.
2442 * keymap.h: Change prototypes to match the above.
2443
2444 * lread.c (read1, init_obarray): Don't update size until alloc done.
2445
2446 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2447 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2448
2449 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2450 Now ptrdiff_t, not int.
2451 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2452 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2453
2454 * process.c (Fnetwork_interface_list): Check for overflow
2455 in size calculation.
2456
2457 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2458
2459 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2460 overflow. Don't bother calling xmalloc when xrealloc will do.
2461
2462 * search.c (Freplace_match): Check for size calculation overflow.
2463 (Fset_match_data): Don't assume list lengths fit in 'int'.
2464
2465 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2466 for command line length. Do not attempt to address one before the
2467 beginning of an array, as that's not portable.
2468
2469 * term.c (max_frame_lines): Remove; unused.
2470 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2471 not int.
2472 (encode_terminal_code, calculate_costs): Check for size
2473 calculation overflow.
2474 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2475 table lengths and related sizes. Don't update size until alloc
2476 done. Redo calculations to avoid overflow.
2477 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2478
2479 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2480 subtracting pointers.
2481 (gobble_line): Check for overflow more carefully. Don't update size
2482 until alloc done.
2483
2484 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2485 Don't update size until alloc done.
2486 Redo size calculations to avoid overflow.
2487 Check for size calculation overflow.
2488 (main) [DEBUG]: Fix typo in invoking tparam1.
2489
2490 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2491 Use ptrdiff_t, not int, for sizes.
2492 (store_mode_line_noprop_char): Don't update size until alloc done.
2493
2494 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2495 Use ptrdiff_t, not int, for sizes.
2496 (Finternal_make_lisp_face, cache_face):
2497 Check for size calculation overflow.
2498 (cache_face): Treat size calculation overflows as if they were
2499 memory exhaustion (the usual treatment), rather than aborting.
2500
2501 * xfns.c (x_encode_text, x_set_name_internal)
2502 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2503 sizes, since they can exceed INT_MAX in size. Check for size
2504 calculation overflow.
2505
2506 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2507 (xg_select): Check for size calculation overflow.
2508 Don't update size until alloc done.
2509
2510 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2511 as sprintf is limited to int lengths.
2512
2513 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2514 (X_LONG_MIN): New macros.
2515 Use them to make the following changes clearer.
2516 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2517 This change doesn't affect the value now, but it may help remind
2518 future maintainers not to raise the value too much later.
2519 (SELECTION_QUANTUM): Remove, replacing with ...
2520 (selection_quantum): ... new function, which avoids overflow.
2521 All uses changed.
2522 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2523 assumption that selection length fits in 'int'.
2524 (x_reply_selection_request, x_handle_selection_request)
2525 (x_get_window_property, receive_incremental_selection)
2526 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2527 (lisp_data_to_selection_data, clean_local_selection_data):
2528 Use ptrdiff_t, not int, to record length of selection.
2529 (x_reply_selection_request, x_get_window_property)
2530 (receive_incremental_selection, x_property_data_to_lisp):
2531 Redo calculations to avoid overflow.
2532 (x_reply_selection_request): When sending hint, ceiling it at
2533 X_LONG_MAX rather than relying on wraparound overflow to send
2534 something.
2535 (x_get_window_property, receive_incremental_selection)
2536 (lisp_data_to_selection_data, x_property_data_to_lisp):
2537 Check for size-calculation overflow.
2538 (x_get_window_property, receive_incremental_selection)
2539 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2540 Don't store size until memory allocation succeeds.
2541 (x_get_window_property): Plug memory leak on memory exhaustion.
2542 Don't double-block input; malloc is safe here. Don't assume 2**34
2543 - 4 fits in unsigned long. Add an xassert to check
2544 XGetWindowProperty overflow. Be more careful about overflow
2545 calculations, and distinguish size from memory overflow better.
2546 (receive_incremental_selection): When tracing, don't assume
2547 unsigned int is less than INT_MAX.
2548 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2549 harmful) conversions of unsigned short to int.
2550 (lisp_data_to_selection_data): Don't assume that integers
2551 in the range -65535 through -1 fit in an X unsigned short.
2552 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2553 result parameters unless successful. Rely on cons_to_unsigned
2554 to report problems with elements; the old code wasn't right anyway.
2555 (x_check_property_data): Check for int overflow; we cannot use
2556 a wider type due to X limits.
2557 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2558
2559 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2560
2561 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2562 (x_term_init): Check for size calculation overflow.
2563 (x_color_cells): Don't store size until memory allocation succeeds.
2564 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2565 Don't assume alloca size is less than MAX_ALLOCA.
2566 (x_term_init): Don't assume length fits in int (sprintf is limited
2567 to int size).
2568
2569 Use ptrdiff_t for composition IDs.
2570 * character.c (lisp_string_width):
2571 * composite.c (composition_table_size, n_compositions)
2572 (get_composition_id, composition_gstring_from_id):
2573 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2574 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2575 * window.c (Frecenter):
2576 Use ptrdiff_t, not int, for composition IDs.
2577 * composite.c (get_composition_id): Check for integer overflow.
2578 * composite.h: Adjust prototypes to match the above changes.
2579
2580 Use ptrdiff_t for hash table indexes.
2581 * category.c (hash_get_category_set):
2582 * ccl.c (ccl_driver):
2583 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2584 * coding.c (coding_system_charset_list, detect_coding_system):
2585 * coding.h (struct coding_system.id):
2586 * composite.c (get_composition_id, gstring_lookup_cache):
2587 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2588 * image.c (xpm_get_color_table_h):
2589 * lisp.h (hash_lookup, hash_put):
2590 * minibuf.c (Ftest_completion):
2591 Use ptrdiff_t for hash table indexes, not int (which is too
2592 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2593 32-bit --with-wide-int hosts).
2594
2595 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2596 Add a FIXME comment about memory leaks.
2597 (syms_of_charset): Don't assume xmalloc returns.
2598
2599 Don't assume that stated character widths fit in int.
2600 * character.c (Fchar_width, c_string_width, lisp_string_width):
2601 * character.h (CHAR_WIDTH):
2602 * indent.c (MULTIBYTE_BYTES_WIDTH):
2603 Use sanitize_char_width to avoid undefined and/or bad behavior
2604 with outlandish widths.
2605 * character.h (sanitize_tab_width): Rename from sanitize_width,
2606 now that we have two such functions. All uses changed.
2607 (sanitize_char_width): New inline function.
2608
2609 Don't assume that tab-width fits in int.
2610 * character.h (sanitize_width): New inline function.
2611 (SANE_TAB_WIDTH): New macro.
2612 (ASCII_CHAR_WIDTH): Use it.
2613 * indent.c (sane_tab_width): Remove. All uses replaced by
2614 SANE_TAB_WIDTH (current_buffer).
2615 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2616
2617 * fileio.c: Integer overflow issues with file modes.
2618 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2619
2620 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2621 Remove unreachable code.
2622 (read_hex, load_charset_map_from_file): Check for integer overflow.
2623
2624 * xterm.c: Don't go over XClientMessageEvent limit.
2625 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2626 (x_send_scroll_bar_event): Likewise. Check that the size does not
2627 exceed limits imposed by XClientMessageEvent, as well as the usual
2628 ptrdiff_t and size_t limits.
2629
2630 * keyboard.c: Overflow, signedness and related fixes.
2631 (make_lispy_movement): Use same integer type in forward decl
2632 that is used in the definition.
2633 (read_key_sequence, keyremap_step):
2634 Change bufsize argument back to int, undoing my 2011-03-30 change.
2635 We prefer signed types, and int is wide enough here.
2636 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2637 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2638 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2639 length, not size_t. Use ptrdiff_t for index, not int.
2640 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2641 possibility of integer overflow.
2642
2643 Overflow, signedness and related fixes for images.
2644
2645 * dispextern.h (struct it.stack[0].u.image.image_id)
2646 (struct_it.image_id, struct image.id, struct image_cache.size)
2647 (struct image_cache.used, struct image_cache.ref_count):
2648 * gtkutil.c (update_frame_tool_bar):
2649 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2650 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2651 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2652 * nsmenu.m (update_frame_tool_bar):
2653 * xdisp.c (calc_pixel_width_or_height):
2654 * xfns.c (image_cache_refcount):
2655 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2656 on typical 64-bit hosts.
2657
2658 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2659 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2660 Omit unnecessary casts to int.
2661 (parse_image_spec): Check that integers fall into 'int' range
2662 when the callers expect that.
2663 (image_ascent): Redo ascent calculation to avoid int overflow.
2664 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2665 (lookup_image): Remove unnecessary tests.
2666 (xbm_image_p): Locals are now of int, not EMACS_INT,
2667 since parse_image_check makes sure they fit into int.
2668 (png_load, gif_load, svg_load_image):
2669 Prefer int to unsigned where either will do.
2670 (tiff_handler): New function, combining the cores of the
2671 old tiff_error_handler and tiff_warning_handler.
2672 This function is rewritten to use vsnprintf and thereby avoid
2673 stack buffer overflows. It uses only the features of vsnprintf
2674 that are common to both POSIX and native Microsoft.
2675 (tiff_error_handler, tiff_warning_handler): Use it.
2676 (tiff_load, gif_load, imagemagick_load_image):
2677 Don't assume :index value fits in 'int'.
2678 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2679 (imagemagick_load_image): Check that crop parameters fit into
2680 the integer types that MagickCropImage accepts. Don't assume
2681 Vimagemagick_render_type has a nonnegative value. Don't assume
2682 size_t fits in 'long'.
2683 (gs_load): Use printmax_t to print the widest integers possible.
2684 Check for integer overflow when computing image height and width.
2685
2686 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2687
2688 * xdisp.c (redisplay_window): Don't force window start if point
2689 will be invisible in the resulting window. (Bug#9324)
2690
2691 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2692
2693 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2694 the display spec is of the form `(space ...)'.
2695 (handle_display_spec): Return the value returned by
2696 handle_single_display_spec, not just 1 or zero.
2697 (handle_single_display_spec): If the display spec is of the form
2698 `(space ...)', and specifies display in the text area, return 2
2699 rather than 1.
2700 (try_cursor_movement): Check for the need to scroll more
2701 accurately, and prefer exact match for point under bidi.
2702 Don't advance `row' beyond the last row of the window.
2703
2704 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2705 into disp_prop; all users changed.
2706
2707 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2708 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2709 for the text covered by the display property.
2710
2711 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2712
2713 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2714 Change return value to nil.
2715 (Frecord_buffer): Delete unused function.
2716
2717 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2718
2719 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2720 buffers, return left-to-right.
2721 (set_cursor_from_row): Consider candidate row a win if its glyph
2722 represents a newline and point is on that newline. Fixes cursor
2723 positioning on the newline at EOL of R2L text within L2R
2724 paragraph, and vice versa.
2725 (try_cursor_movement): Check continued rows, in addition to
2726 continuation rows. Fixes unwarranted scroll when point enters a
2727 continued line of R2L text within an L2R paragraph, or vice versa.
2728 (cursor_row_p): Consider the case of point being equal to
2729 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2730 from the end of a short line to the beginning of a continued line
2731 of R2L text within L2R paragraph.
2732 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2733 composed characters.
2734
2735 * bidi.c (bidi_check_type): Use xassert.
2736 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2737 members.
2738
2739 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2740
2741 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2742 a character.
2743
2744 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2745
2746 * nsfont.m (ns_otf_to_script): Fix typo.
2747
2748 2011-08-22 Kenichi Handa <handa@m17n.org>
2749
2750 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2751 extra slot even if the purpose is char-code-property-table.
2752
2753 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2754
2755 * xdisp.c (redisplay_window): When computing centering_position,
2756 account for the height of the header line. (Bug#8874)
2757
2758 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2759 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2760 candidate is selected by the mouse, and that candidate has a
2761 composed character under the mouse.
2762
2763 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2764 coordinates reported by pos-visible-in-window-p for a composed
2765 character in column zero.
2766
2767 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2768
2769 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2770
2771 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2772
2773 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2774 consider it a hit if to_charpos is anywhere in the range of the
2775 composed buffer positions.
2776
2777 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2778
2779 * image.c (gif_load): Don't assume that each subimage has the same
2780 dimensions as the base image. Handle disposal method that is
2781 "undefined" by the gif spec (Bug#9335).
2782
2783 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2784
2785 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2786 (Fcondition_case): Document `debug' symbol in error handler.
2787
2788 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2789
2790 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2791 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2792 from an Org mode buffer to a Speedbar frame.
2793
2794 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2795 a composition, take its buffer position from IT->cmp_it.charpos.
2796 Fixes cursor positioning at the beginning of a line that begins
2797 with a composed character.
2798
2799 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2800
2801 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2802 character bidirectional type, use STRONG_L instead. Fixes crashes
2803 in a buffer produced by `describe-categories'.
2804
2805 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2806 members before the level stack, so they would be saved and
2807 restored when copying iterator state. Fixes incorrect reordering
2808 around TABs covered by display properties.
2809
2810 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2811
2812 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2813
2814 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2815
2816 * eval.c (internal_condition_case, internal_condition_case_1)
2817 (internal_condition_case_2, internal_condition_case_n):
2818 Remove unnecessary aborts (Bug#9081).
2819
2820 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2821
2822 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2823 has no `load' handler, try opening the file locally. (Bug#9311)
2824
2825 2011-08-16 Ken Brown <kbrown@cornell.edu>
2826
2827 * gmalloc.c: Expand comment.
2828
2829 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2830
2831 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2832 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2833
2834 2011-08-16 Ken Brown <kbrown@cornell.edu>
2835
2836 Fix memory allocation problems in Cygwin build (Bug#9273).
2837
2838 * unexcw.c ( __malloc_initialized): Declare external variable.
2839 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2840
2841 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2842 New variables.
2843 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2844 dumped emacs.
2845 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2846 in the static heap.
2847 [CYGWIN] (special_realloc): New function.
2848 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2849 requests to realloc storage in the static heap.
2850
2851 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2852
2853 * bidi.c (bidi_initialize): Remove unused local.
2854
2855 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2856
2857 * bidimirror.h:
2858 * biditype.h: Remove file.
2859 * makefile.w32-in ($(BLD)/bidi.$(O)):
2860 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2861
2862 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2863
2864 * chartab.c: Improve commentary for the uniprop_table API.
2865
2866 * bidi.c (bidi_paragraph_init): Support zero value of
2867 bidi_ignore_explicit_marks_for_paragraph_level.
2868 (bidi_initialize): Use uniprop_table instead of including
2869 biditype.h and bidimirror.h.
2870
2871 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2872 coordinates of the iterator when restoring from ppos_it.
2873 (Bug#9296)
2874
2875 2011-08-14 Kenichi Handa <handa@m17n.org>
2876
2877 * process.c (create_process): Call setup_process_coding_systems
2878 after the pid of the process is set to -1 (Bug#8162).
2879
2880 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2881
2882 * xdisp.c (move_it_in_display_line_to): Don't invoke
2883 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2884 ppos_it. Fixes vertical cursor motion when line beginning is
2885 covered by an image. (Bug#9296)
2886
2887 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2888
2889 * nsterm.h (ns_run_ascript): Declare.
2890 (NSAPP_DATA2_RUNASSCRIPT): Define.
2891
2892 * nsfns.m (as_script, as_result, as_status): New static variables.
2893 (ns_run_ascript): New function.
2894 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2895 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2896 the event loop. Get status from as_status (Bug#7276).
2897
2898 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2899 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2900 the event loop (Bug#7276).
2901
2902 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2903
2904 * gnutls.c (QCgnutls_bootprop_priority)
2905 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2906 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2907 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2908 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2909 (QCgnutls_bootprop_verify_hostname_error)
2910 (QCgnutls_bootprop_callbacks_verify): Rename from
2911 Qgnutls_bootprop_..., all uses changed.
2912
2913 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2914 uses changed.
2915
2916 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2917
2918 * xfaces.c (Qframe_set_background_mode): Now static.
2919 * dispextern.h (Qframe_set_background_mode): Remove decl.
2920
2921 * process.c (Fnetwork_interface_info): Declare local only if needed.
2922
2923 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2924
2925 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2926 (Fnetwork_interface_list): Allocate in increments of bytes instead
2927 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2928 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2929 sockaddr.
2930 (struct ifflag_def): notrailers is smart on OSX.
2931 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2932 Get hardware address with getifaddrs if available.
2933
2934 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2935
2936 * xdisp.c (iterate_out_of_display_property): xassert that
2937 IT->position is set to within IT->object's boundaries. Break from
2938 the loop as soon as EOB is reached; avoids infloops in redisplay
2939 when IT->position is set up wrongly due to some bug.
2940 Set IT->current to match the bidi iterator unconditionally.
2941 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2942 entry. Force push_it to save on the stack the current
2943 buffer/string position, to be restored by pop_it. Fix flags in
2944 the iterator structure wrt the object coming from a display
2945 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2946 properties. (Bug#9284)
2947
2948 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2949
2950 * fontset.c (fontset_get_font_group): Add proper type checks.
2951 (Bug#9172)
2952
2953 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2954
2955 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2956 and LC_VERSION_MIN_MACOSX.
2957 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2958 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2959
2960 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2961
2962 * xdisp.c (forward_to_next_line_start): Allow to use the
2963 no-display-properties-and-no-overlays under bidi display.
2964 Set disp_pos in the bidi iterator to avoid searches for display
2965 properties and overlays.
2966
2967 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2968
2969 * editfns.c (Fset_time_zone_rule): Document relationship with the
2970 setenv function.
2971
2972 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2973 the font entity extracted from the cache (Bug#8109).
2974
2975 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2976
2977 * composite.c (autocmp_chars): Don't reset point. That is done by
2978 restore_point_unwind (Bug#5984).
2979
2980 2011-08-07 Juri Linkov <juri@jurta.org>
2981
2982 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2983 to show the arg `TIME' instead of `TIMEVAL'.
2984
2985 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2986
2987 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2988 display property strides EOL and includes a newline, as in
2989 longlines-mode. (Bug#9254)
2990 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2991 word-wrap under bidirectional display. (Bug#9224)
2992
2993 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2994 is non-zero, even if the data buffer is NULL. Fixes a crash in
2995 vertical-motion with longlines-mode. (Bug#9254)
2996
2997 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2998
2999 * bidi.c <bidi_cache_total_alloc>: Now static.
3000 (bidi_initialize): Initialize bidi_cache_total_alloc.
3001
3002 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3003 cache. (Bug#9221)
3004
3005 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3006 amount allocated this far in `bidi_cache_total_alloc'.
3007 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3008 non-zero, only free the data buffer without restoring the cache
3009 contents. All callers changed.
3010
3011 * dispextern.h (bidi_unshelve_cache): Update prototype.
3012
3013 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3014 (move_it_in_display_line, move_it_to)
3015 (move_it_vertically_backward, move_it_by_lines): Replace the call
3016 to xfree to an equivalent call to bidi_unshelve_cache.
3017 (move_it_in_display_line_to): Fix logic of returning
3018 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3019
3020 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3021
3022 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3023 came from a string character with a `cursor' property. (Bug#9229)
3024
3025 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3026
3027 * Makefile.in (LIB_PTHREAD): New variable.
3028 (LIBES): Add LIB_PTHREAD (Bug#9216).
3029
3030 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3031 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3032
3033 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3034
3035 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3036
3037 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3038
3039 * xterm.c (x_find_topmost_parent): New function.
3040 (x_set_frame_alpha): Find topmost parent window with
3041 x_find_topmost_parent and set the property there also (bug#9181).
3042 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3043
3044 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3045
3046 * callproc.c (Fcall_process): Avoid vfork clobbering
3047 the local vars buffer, coding_systems, current_dir.
3048
3049 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3050
3051 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3052
3053 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3056 so that it is not optimized away.
3057
3058 * xdisp.c (compute_display_string_pos): Remove unused local.
3059
3060 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3061
3062 Fix slow cursor motion and scrolling in large buffers with
3063 selective display, like Org Mode buffers. (Bug#9218)
3064
3065 * dispextern.h (struct bidi_it): New member disp_prop_p.
3066
3067 * xdisp.c: Remove one-slot cache of display string positions.
3068 (compute_display_string_pos): Accept an additional argument
3069 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3070 for a display string or property. If found, set DISP_PROP_P
3071 non-zero.
3072
3073 * bidi.c (bidi_fetch_char): Accept an additional argument
3074 DISP_PROP_P, and pass it to compute_display_string_pos.
3075 Only handle text covered by a display string if DISP_PROP_P is returned
3076 non-zero. All callers of bidi_fetch_char changed.
3077
3078 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3079
3080 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3081
3082 2010-12-03 Don March <don@ohspite.net>
3083
3084 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3085 last character M-[char] is translated to ESC [char] (bug#7541).
3086
3087 2011-08-02 Kenichi Handa <handa@m17n.org>
3088
3089 * lisp.h (uniprop_table): Extern it.
3090
3091 * chartab.c (uniprop_table): Make it non-static.
3092
3093 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3094
3095 * xdisp.c (forward_to_next_line_start): Accept additional argument
3096 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3097 on the newline.
3098 (reseat_at_next_visible_line_start): Use the bidi iterator state
3099 returned by forward_to_next_line_start to restore the state of
3100 it->bidi_it after backing up to previous newline. (Bug#9212)
3101
3102 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3103
3104 * regex.c (re_comp): Protoize.
3105 (re_exec): Fix return type.
3106 (regexec): Fix type of `ret'. (Bug#9203)
3107
3108 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3109
3110 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3111 This is needed if max-image-size is a floating-point number.
3112
3113 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3114
3115 * print.c (print_object): Print empty symbol as ##.
3116
3117 * lread.c (read1): Read ## as empty symbol.
3118
3119 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3120
3121 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3122 setting frame foreground color (Bug#9175).
3123 (x_set_background_color): Likewise.
3124
3125 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3126 contents (Bug#9176).
3127 (EmacsTooltip -init): Remove bezels and add shadows to
3128 tooltip windows.
3129
3130 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3131 or scroll bar (Bug#8470).
3132
3133 * nsfont.m (nsfont_open): Remove assignment to voffset and
3134 unnecessary vars hshink, expand, hd, full_height, min_height.
3135 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3136
3137 * nsterm.h (nsfont_info): Remove voffset field.
3138
3139 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3140
3141 Implement strike-through and overline on NextStep (Bug#8863).
3142
3143 * nsfont.m (nsfont_open): Use underline position provided by font,
3144 instead of hard-coded value of 2.
3145 (nsfont_draw): Call ns_draw_text_decoration instead.
3146
3147 * nsterm.h: Add declaration for ns_draw_text_decoration.
3148
3149 * nsterm.m (ns_draw_text_decoration): New function for drawing
3150 underline, overline, and strike-through.
3151 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3152 ns_draw_text_decoration. Change treatment of cursor drawing to
3153 accommodate underlining, etc.
3154
3155 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3156
3157 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3158 default.
3159
3160 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3161
3162 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3163 Without this fix, if a signal arrives just after memory fills up,
3164 'malloc' might be invoked reentrantly.
3165
3166 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3167 In other words, assume that every image size is allowed, on non-X
3168 hosts. This assumption is probably wrong, but it lets Emacs compile.
3169
3170 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3171
3172 * regex.c (re_iswctype): Convert return values to boolean.
3173
3174 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3175
3176 * xdisp.c (compute_display_string_pos): Don't use cached display
3177 string position if the buffer had its restriction changed.
3178 (Bug#9184)
3179
3180 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3181
3182 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3183
3184 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3185
3186 Integer signedness and overflow and related fixes. (Bug#9079)
3187
3188 * bidi.c: Integer size and overflow fixes.
3189 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3190 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3191 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3192 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3193 (bidi_find_other_level_edge):
3194 Use ptrdiff_t instead of EMACS_INT where either will do.
3195 This works better on 32-bit hosts configured --with-wide-int.
3196 (bidi_cache_ensure_space): Check for size-calculation overflow.
3197 Use % rather than repeated addition, for better worst-case speed.
3198 Don't set bidi_cache_size until after xrealloc returns, because it
3199 might not return.
3200 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3201 (bidi_cache_ensure_space): Also check that the bidi cache size
3202 does not exceed that of the largest Lisp string or buffer. See Eli
3203 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3204
3205 * alloc.c (__malloc_size_t): Remove.
3206 All uses replaced by size_t. See Andreas Schwab's note
3207 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3208
3209 * image.c: Improve checking for integer overflow.
3210 (check_image_size): Assume that f is nonnull, since
3211 it is always nonnull in practice. This is one less thing to
3212 worry about when checking for integer overflow later.
3213 (x_check_image_size): New function, which checks for integer
3214 overflow issues inside X.
3215 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3216 This removes the need for a memory_full check.
3217 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3218 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3219 (xbm_read_bitmap_data): Change locals back to 'int', since
3220 their values must fit in 'int'.
3221 (xpm_load_image, png_load, tiff_load):
3222 Invoke x_create_x_image_and_pixmap earlier,
3223 to avoid much needless work if the image is too large.
3224 (tiff_load): Treat overly large images as if
3225 x_create_x_image_and_pixmap failed, not as malloc failures.
3226 (gs_load): Use x_check_image_size.
3227
3228 * gtkutil.c: Omit integer casts.
3229 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3230 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3231
3232 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3233
3234 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3235 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3236 would wrongly return t on a 64-bit host.
3237
3238 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3239 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3240 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3241 and therefore cause GCC to emit a bogus diagnostic in some cases.
3242
3243 * image.c: Integer signedness and overflow and related fixes.
3244 This is not an exhaustive set of fixes, but it's time to
3245 record what I've got.
3246 (lookup_pixel_color, check_image_size): Remove redundant decls.
3247 (check_image_size): Don't assume that arbitrary EMACS_INT values
3248 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3249 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3250 (tiff_load, imagemagick_load_image):
3251 Check for overflow in size calculations.
3252 (x_create_x_image_and_pixmap): Remove unnecessary test for
3253 xmalloc returning NULL; that can't happen.
3254 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3255 (xpm_color_bucket): Use better integer hashing function.
3256 (xpm_cache_color): Don't possibly over-allocate memory.
3257 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3258 (gif_memory_source):
3259 Use ptrdiff_t, not int or size_t, to record sizes.
3260 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3261 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3262 either works, as we prefer signed integers.
3263 (tiff_read_from_memory, tiff_write_from_memory):
3264 Return tsize_t, not size_t, since that's what the TIFF API wants.
3265 (tiff_read_from_memory): Don't fail simply because the read would
3266 go past EOF; instead, return a short read.
3267 (tiff_load): Omit no-longer-needed casts.
3268 (Fimagemagick_types): Don't assume size fits into 'int'.
3269
3270 Improve hashing quality when configured --with-wide-int.
3271 * fns.c (hash_string): New function, taken from sxhash_string.
3272 Do not discard information about ASCII character case; this
3273 discarding is no longer needed.
3274 (sxhash-string): Use it. Change sig to match it. Caller changed.
3275 * lisp.h: Declare it.
3276 * lread.c (hash_string): Remove, since we now use fns.c's version.
3277 The fns.c version returns a wider integer if --with-wide-int is
3278 specified, so this should help the quality of the hashing a bit.
3279
3280 * emacs.c: Integer overflow minor fix.
3281 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3282 Define only if GNU_LINUX.
3283 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3284
3285 * dispnew.c: Integer signedness and overflow fixes.
3286 Remove unnecessary forward decls, that were a maintenance hassle.
3287 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3288 All uses changed.
3289 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3290 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3291 (prepare_desired_row, line_draw_cost):
3292 Use int, not unsigned, where either works.
3293 (save_current_matrix, restore_current_matrix):
3294 Use ptrdiff_t, not size_t, where either works.
3295 (init_display): Check for overflow more accurately, and without
3296 relying on undefined behavior.
3297
3298 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3299 Remove, replacing with the new symbols in lisp.h. All uses changed.
3300 * fileio.c (make_temp_name):
3301 * filelock.c (lock_file_1, lock_file):
3302 * xdisp.c (message_dolog):
3303 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3304 Use pMd etc. instead.
3305 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3306 replacing the pWIDE etc. symbols removed from editfns.c.
3307
3308 * keyboard.h (num_input_events): Now uintmax_t.
3309 This is (very slightly) less likely to mess up due to wraparound.
3310 All uses changed.
3311
3312 * buffer.c: Integer signedness fixes.
3313 (alloc_buffer_text, enlarge_buffer_text):
3314 Use ptrdiff_t rather than size_t when either will do, as we prefer
3315 signed integers.
3316
3317 * alloc.c: Integer signedness and overflow fixes.
3318 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3319 (__malloc_size_t): Default to size_t, not to int.
3320 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3321 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3322 Prefer ptrdiff_t to size_t when either would do, as we prefer
3323 signed integers.
3324 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3325 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3326 Now const. Initialize with values that are in range even if char
3327 is signed.
3328 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3329 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3330 These functions do the right thing with sizes > 2**32.
3331 (check_depth): Now ptrdiff_t, not int.
3332 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3333 Adjust to new way of storing sizes. Check for size overflow bugs
3334 in rest of code.
3335 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3336 slightly wrong anyway, as it missed one instance of
3337 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3338 (refill_memory_reserve): Omit needless cast to size_t.
3339 (mark_object_loop_halt): Mark as externally visible.
3340
3341 * xselect.c: Integer signedness and overflow fixes.
3342 (Fx_register_dnd_atom, x_handle_dnd_message):
3343 Use ptrdiff_t, not size_t, since we prefer signed.
3344 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3345 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3346 x_dnd_atoms_size and x_dnd_atoms_length.
3347
3348 * doprnt.c: Prefer signed to unsigned when either works.
3349 * eval.c (verror):
3350 * doprnt.c (doprnt):
3351 * lisp.h (doprnt):
3352 * xdisp.c (vmessage):
3353 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3354 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3355 prefer signed arithmetic to avoid comparison confusion.
3356 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3357 but is a bit tricky.
3358
3359 Assume freestanding C89 headers, string.h, stdlib.h.
3360 * data.c, doprnt.c, floatfns.c, print.c:
3361 Include float.h unconditionally.
3362 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3363 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3364 * regex.c: Likewise for stddef.h, string.h.
3365 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3366 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3367 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3368 (STDC_HEADERS): Remove obsolete defines.
3369 * sysdep.c: Include limits.h unconditionally.
3370
3371 Assume support for memcmp, memcpy, memmove, memset.
3372 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3373 * regex.c (memcmp, memcpy):
3374 Remove; we assume C89 now.
3375
3376 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3377 (__malloc_safe_bcopy): Remove; no longer needed.
3378
3379 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3380 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3381 well either way, and we prefer signed to unsigned.
3382
3383 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3384
3385 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3386 closes the connection while we're reading (bug#9182).
3387
3388 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3389
3390 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3391 are specified (Bug#9168).
3392
3393 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3394
3395 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3396 Found by GCC static checking and --with-wide-int on a 32-bit host.
3397
3398 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3399
3400 * xdisp.c (compute_display_string_pos): Fix logic of caching
3401 previous display string position. Initialize cached_prev_pos to
3402 -1. Fixes slow-down at the beginning of a buffer.
3403
3404 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3405
3406 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3407 for attrs[LFACE_FONTSET_INDEX].
3408
3409 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3410
3411 * xml.c (parse_region): Remove unused local
3412 that was recently introduced.
3413
3414 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3415
3416 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3417 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3418
3419 * xdisp.c (move_it_in_display_line_to): Record the best matching
3420 position for TO_CHARPOS while scanning the line, and restore it on
3421 exit if none of the characters scanned was an exact match.
3422 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3423 when exact match is impossible due to invisible text, and the
3424 lines are truncated.
3425
3426 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3427
3428 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3429 for OSX >= 10.7.
3430
3431 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3432
3433 Fix a significant slow-down of cursor motion with C-n, C-p,
3434 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3435 auto-repeat under bidi redisplay in fontified buffers.
3436 * xdisp.c (compute_stop_pos_backwards): New function.
3437 (next_element_from_buffer): Call compute_stop_pos_backwards to
3438 find a suitable prev_stop when we find ourselves before
3439 base_level_stop.
3440 (reseat): Don't look for prev_stop, as that could mean a very long
3441 run.
3442 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3443 <cached_disp_overlay_modiff>: Cache for last found display string
3444 position.
3445 (compute_display_string_pos): Return the cached position if asked
3446 about the same buffer in the same area of character positions, and
3447 the buffer wasn't changed since the time the display string
3448 position was cached.
3449
3450 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3451
3452 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3453 is an integer, which is important for empty lines. (Bug#9149)
3454
3455 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3456
3457 * frame.c (Fmodify_frame_parameters): In tty case, update the
3458 default face if necessary (Bug#4238).
3459
3460 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3461
3462 * editfns.c (Fstring_to_char): No need to explain what a character
3463 is in the docstring (Bug#6576).
3464
3465 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3466
3467 * xml.c (parse_region): Make sure we always return a tree.
3468
3469 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3470
3471 * xml.c (parse_region): If a document contains only comments,
3472 return that, too.
3473
3474 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3475
3476 * xml.c (make_dom): Return comments, too.
3477
3478 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3479
3480 Port to OpenBSD.
3481 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3482 and the surrounding thread.
3483 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3484 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3485 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3486 timer goes off.
3487 * s/openbsd.h (BROKEN_SIGIO): Define.
3488 * unexelf.c (unexec) [__OpenBSD__]:
3489 Don't update the .mdebug section of the Alpha COFF symbol table.
3490
3491 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3492
3493 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3494 (bug#8460).
3495
3496 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3497
3498 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3499 This fixes some race conditions on the permissions of any newly
3500 created file.
3501
3502 * alloc.c (valid_pointer_p): Use pipe, not open.
3503 This fixes some permissions issues when debugging.
3504
3505 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3506 If fchown fails to set both uid and gid, try to set just gid,
3507 as that is sometimes allowed. Adjust the file's mode to eliminate
3508 setuid or setgid bits that are inappropriate if fchown fails.
3509
3510 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3511
3512 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3513 to compare Lisp_Objects.
3514 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3515 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3516 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3517
3518 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3519
3520 * lread.c (read_integer): Unread even EOF character.
3521 (read1): Likewise. Properly record start position of symbol.
3522
3523 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3524 symbol character follows.
3525
3526 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3527
3528 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3529 This works around a problem with the previous change to Fcopy_file.
3530 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3531 and without this change, GCC might complain about discarding
3532 fchown's return value.
3533
3534 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3535
3536 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3537
3538 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3539
3540 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3541
3542 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3543
3544 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3545 it's used from the C level.
3546
3547 * process.c: Use the same condition for POLL_FOR_INPUT in both
3548 keyboard.c and process.c (bug#1858).
3549
3550 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3551
3552 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3553 (Fgnutls_boot): Use it.
3554
3555 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3556
3557 * doc.c (Fsubstitute_command_keys): Revert last change.
3558
3559 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3560
3561 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3562 quotes the next character, and doesn't affect other longer
3563 sequences (bug#8935).
3564
3565 * lread.c (syms_of_lread): Clarify that is isn't only
3566 `eval-buffer' and `eval-defun' that's affected by
3567 `lexical-binding' (bug#8460).
3568
3569 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3570
3571 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3572 bidi redisplay when a line includes both an image and is truncated.
3573
3574 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3575
3576 Fix minor problems found by static checking.
3577 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3578 (elsz): Now a signed constant, not a size_t var. We prefer signed
3579 types to unsigned, to avoid integer comparison confusion. Without
3580 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3581 "cannot optimize loop, the loop counter may overflow", a symptom
3582 of the confusion.
3583 * indent.c (Fvertical_motion): Mark locals as initialized.
3584 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3585
3586 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3587
3588 * search.c (Fre_search_backward): Mention `case-fold-search' in
3589 all the re_search_* functions (bug#8138).
3590
3591 * keyboard.c (Fopen_dribble_file): Document when the file is
3592 closed (bug#8056).
3593
3594 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3595
3596 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3597 bidi_cache_idx.
3598
3599 Support bidi reordering of display and overlay strings.
3600 * xdisp.c (compute_display_string_pos)
3601 (compute_display_string_end): Accept additional argument STRING.
3602 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3603 (reseat_to_string): Initialize bidi_it->string.s and
3604 bidi_it->string.schars.
3605 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3606 NULL (avoids a crash in bidi_paragraph_init).
3607 Initialize itb.string.lstring.
3608 (init_iterator): Call bidi_init_it only of a valid
3609 buffer position was specified. Initialize paragraph_embedding to
3610 L2R.
3611 (reseat_to_string): Initialize the bidi iterator.
3612 (display_string): If we need to ignore text properties of
3613 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3614 original value of -1 will not work with bidi.)
3615 (compute_display_string_pos): First arg is now struct
3616 `text_pos *'; all callers changed. Support display properties on
3617 Lisp strings.
3618 (compute_display_string_end): Support display properties on Lisp
3619 strings.
3620 (init_iterator, reseat_1, reseat_to_string): Initialize the
3621 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3622 when iterating on a string not from display properties).
3623 (compute_display_string_pos, compute_display_string_end):
3624 Fix calculation of the object to scan. Fixes an error when using
3625 arrow keys.
3626 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3627 base_level_stop; instead, set base_level_stop to BEGV.
3628 Fixes crashes in vertical-motion.
3629 (next_element_from_buffer): Improve commentary for when
3630 the iterator is before prev_stop.
3631 (init_iterator): Initialize bidi_p from the default value of
3632 bidi-display-reordering, not from buffer-local value. Use the
3633 buffer-local value only if initializing for buffer iteration.
3634 (handle_invisible_prop): Support invisible properties on strings
3635 that are being bidi-reordered.
3636 (set_iterator_to_next): Support bidi reordering of C strings and
3637 Lisp strings.
3638 (next_element_from_string): Support bidi reordering of Lisp
3639 strings.
3640 (handle_stop_backwards): Support Lisp strings as well.
3641 (display_string): Support display of R2L glyph rows.
3642 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3643 (init_iterator): Don't initialize it->bidi_p for strings
3644 here.
3645 (reseat_to_string): Initialize it->bidi_p for strings here.
3646 (next_element_from_string, next_element_from_c_string)
3647 (next_element_from_buffer): Add xassert's for correspondence
3648 between IT's object being iterated and it->bidi_it.string
3649 structure.
3650 (face_before_or_after_it_pos): Support bidi iteration.
3651 (next_element_from_c_string): Handle the case of the first string
3652 character that is not the first one in the visual order.
3653 (get_visually_first_element): New function, refactored from common
3654 parts of next_element_from_buffer, next_element_from_string, and
3655 next_element_from_c_string.
3656 (tool_bar_lines_needed, redisplay_tool_bar)
3657 (display_menu_bar): Force left-to-right direction. Add a FIXME
3658 comment for making that be controlled by a user option.
3659 (push_it, pop_it): Save and restore the state of the
3660 bidi iterator. Save and restore the bidi_p flag.
3661 (pop_it): Iterate out of display property for string iteration as
3662 well.
3663 (iterate_out_of_display_property): Support iteration over strings.
3664 (handle_single_display_spec): Set up it->bidi_it for iteration
3665 over a display string, and call bidi_init_it.
3666 (handle_single_display_spec, next_overlay_string)
3667 (get_overlay_strings_1, push_display_prop): Set up the bidi
3668 iterator for displaying display or overlay strings.
3669 (forward_to_next_line_start): Don't use the shortcut if
3670 bidi-iterating.
3671 (back_to_previous_visible_line_start): If handle_display_prop
3672 pushed the iterator stack, restore the internal state of the bidi
3673 iterator by calling bidi_pop_it same number of times.
3674 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3675 and we are bidi-iterating, don't decrement the iterator position;
3676 instead, set the first_elt flag in the bidi iterator, to produce
3677 the same effect.
3678 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3679 (push_display_prop): xassert that we are iterating a buffer.
3680 (push_it, pop_it): Save and restore paragraph_embedding member.
3681 (handle_single_display_spec, next_overlay_string)
3682 (get_overlay_strings_1, reseat_1, reseat_to_string)
3683 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3684 correctly. Don't assume unibyte strings are not bidi-reordered.
3685 (compute_display_string_pos)
3686 (compute_display_string_end): Fix handling the case of C string.
3687 (push_it, pop_it): Save and restore from_disp_prop_p.
3688 (handle_single_display_spec, push_display_prop): Set the
3689 from_disp_prop_p flag.
3690 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3691 (pop_it): Call iterate_out_of_display_property only if we are
3692 popping after iteration over a string that came from a display
3693 property. Fix a typo in popping stretch info. Add an assertion
3694 for verifying that the iterator position is in sync with the bidi
3695 iterator.
3696 (handle_single_display_spec, get_overlay_strings_1)
3697 (push_display_prop): Fix initialization of paragraph direction for
3698 string when that of the parent object is not yet determined.
3699 (reseat_1): Call bidi_init_it to resync the bidi
3700 iterator with IT's position. (Bug#7616)
3701 (find_row_edges): If ROW->start.pos gives position
3702 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3703 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3704 Reset the from_disp_prop_p flag.
3705 (SAVE_IT, RESTORE_IT): New macros.
3706 (pos_visible_p, face_before_or_after_it_pos)
3707 (back_to_previous_visible_line_start)
3708 (move_it_in_display_line_to, move_it_in_display_line)
3709 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3710 (try_scrolling, redisplay_window, display_line): Use them when
3711 saving a temporary copy of the iterator and restoring it back.
3712 (back_to_previous_visible_line_start, reseat_1)
3713 (init_iterator): Empty the bidi cache "stack".
3714 (move_it_in_display_line_to): If iterator ended up at
3715 EOL, but we never saw any buffer positions smaller than
3716 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3717 motion in bidi-reordered lines.
3718 (move_it_in_display_line_to): Record prev_method and prev_pos
3719 immediately before the call to set_iterator_to_next. Fixes cursor
3720 motion in bidi-reordered lines with stretch glyphs and strings
3721 displayed in margins. (Bug#8133) (Bug#8867)
3722 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3723 TO_CHARPOS.
3724 (pos_visible_p): Support positions in bidi-reordered lines.
3725 Save and restore bidi cache.
3726
3727 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3728 (bidi_paragraph_info): Delete unused struct.
3729 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3730 (bidi_cache_start): New variable.
3731 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3732 to zero.
3733 (bidi_cache_fetch_state, bidi_cache_search)
3734 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3735 (bidi_cache_find, bidi_peek_at_next_level)
3736 (bidi_level_of_next_char, bidi_find_other_level_edge)
3737 (bidi_move_to_visually_next): Compare cache index with
3738 bidi_cache_start rather than with zero.
3739 (bidi_fetch_char): Accept new argument STRING; all callers
3740 changed. Support iteration over a string. Support strings with
3741 display properties. Support unibyte strings. Fix the type of
3742 `len' according to what STRING_CHAR_AND_LENGTH expects.
3743 (bidi_paragraph_init, bidi_resolve_explicit_1)
3744 (bidi_resolve_explicit, bidi_resolve_weak)
3745 (bidi_level_of_next_char, bidi_move_to_visually_next):
3746 Support iteration over a string.
3747 (bidi_set_sor_type, bidi_resolve_explicit_1)
3748 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3749 can now be zero (for strings); special values 0 and -1 were
3750 changed to -1 and -2, respectively.
3751 (bidi_char_at_pos): New function.
3752 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3753 Call it instead of FETCH_MULTIBYTE_CHAR.
3754 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3755 initialized to valid values.
3756 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3757 values.
3758 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3759 the test for valid cached positions. Fix the logic for looking up
3760 the sentinel state in the cache. GCPRO the Lisp string we are
3761 iterating.
3762 (bidi_push_it, bidi_pop_it): New functions.
3763 (bidi_initialize): Initialize the bidi cache start stack pointer.
3764 (bidi_cache_ensure_space): New function, refactored from part of
3765 bidi_cache_iterator_state. Don't assume the required size is just
3766 one BIDI_CACHE_CHUNK away.
3767 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3768 (bidi_count_bytes, bidi_char_at_pos): New functions.
3769 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3770 always valid if bidi_cache_idx is valid.
3771 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3772 is valid if it's going to be used.
3773 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3774 (bidi_cache_fetch_state, bidi_cache_search)
3775 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3776 (bidi_cache_iterator_state, bidi_cache_find)
3777 (bidi_find_other_level_edge, bidi_cache_start_stack):
3778 All variables related to cache indices are now EMACS_INT.
3779
3780 * dispextern.h (struct bidi_string_data): New structure.
3781 (struct bidi_it): New member `string'. Make flag members be 1-bit
3782 fields, and put them last in the struct.
3783 (compute_display_string_pos, compute_display_string_end):
3784 Update prototypes.
3785 (bidi_push_it, bidi_pop_it): Add prototypes.
3786 (struct iterator_stack_entry): New members bidi_p,
3787 paragraph_embedding, and from_disp_prop_p.
3788 (struct it): Member bidi_p is now a bit field 1 bit wide.
3789 (bidi_shelve_cache, bidi_unshelve_cache):
3790 Declare prototypes.
3791
3792 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3793 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3794 and vector-like objects.
3795
3796 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3797 cache around display iteration.
3798
3799 * window.c (Fwindow_end, window_scroll_pixel_based)
3800 (displayed_window_lines, Frecenter): Save and restore the bidi
3801 cache around display iteration.
3802
3803 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3804
3805 * editfns.c (Fdelete_region): Clarify the use of the named
3806 parameters (bug#6788).
3807
3808 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3809
3810 * indent.c (Fvertical_motion): Set and restore w->pointm when
3811 saving and restoring the window's buffer (Bug#9006).
3812
3813 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3814
3815 * editfns.c (Fstring_to_char): Clarify just what is returned
3816 (bug#6576). Text by Eli Zaretskii.
3817
3818 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3819
3820 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3821
3822 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3823
3824 * buffer.c (mmap_find): Fix a typo.
3825
3826 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3827
3828 Fix execution of x selection hooks.
3829 * xselect.c (Qx_lost_selection_functions)
3830 (Qx_sent_selection_functions): New vars.
3831 (syms_of_xselect): DEFSYM them.
3832 (x_handle_selection_request): Pass Qx_sent_selection_functions
3833 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3834 (x_handle_selection_clear,x_clear_frame_selections):
3835 Pass Qx_lost_selection_functions rather than
3836 Vx_lost_selection_functions to Frun_hook_with_args.
3837
3838 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3839
3840 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3841 The old code sometimes used this field without initializing it.
3842
3843 * alloc.c (gc_sweep): Don't read past end of array.
3844 In theory, the old code could also have corrupted Emacs internals,
3845 though it'd be very unlikely.
3846
3847 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3848
3849 * character.c (Fcharacterp): Don't advertise optional ignored
3850 argument. (Bug#4026)
3851
3852 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3853
3854 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3855 key" (bug#4257).
3856
3857 * window.c (Fset_window_start): Doc fix (bug#4199).
3858 (Fset_window_hscroll): Ditto.
3859
3860 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3861
3862 Fix minor new problems caught by GCC 4.6.1.
3863 * term.c (init_tty): Remove unused local.
3864 * xsettings.c (store_monospaced_changed): Define this function only
3865 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3866 not used otherwise.
3867
3868 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3869
3870 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3871
3872 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3873
3874 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3875 are the mini-buffer and the echo area (bug#3320).
3876
3877 * term.c (init_tty): Remove support for supdup, c10 and perq
3878 terminals, which are no longer supported (bug#1482).
3879
3880 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3881
3882 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3883
3884 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3885
3886 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3887 for non-popups (Bug#3642).
3888
3889 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3890
3891 * alloc.c (reset_malloc_hooks): Protoize.
3892 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3893 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3894 * cm.c (losecursor): Likewise.
3895 * data.c (fmod): Likewise.
3896 * dispnew.c (swap_glyphs_in_rows): Likewise.
3897 * emacs.c (memory_warning_signal): Likewise.
3898 * floatfns.c (float_error): Likewise.
3899 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3900 (otf_open, font_otf_capability, generate_otf_features)
3901 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3902 Likewise.
3903 * image.c (pbm_read_file): Likewise.
3904 * indent.c (string_display_width): Likewise.
3905 * intervals.c (check_for_interval, search_for_interval)
3906 (inc_interval_count, count_intervals, root_interval)
3907 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3908 * lread.c (defalias): Likewise.
3909 * ralloc.c (r_alloc_check): Likewise.
3910 * regex.c (set_image_of_range_1, set_image_of_range)
3911 (regex_grow_registers): Likewise.
3912 * sysdep.c (strerror): Likewise.
3913 * termcap.c (valid_filename_p, tprint, main): Likewise.
3914 * tparam.c (main): Likewise.
3915 * unexhp9k800.c (run_time_remap, save_data_space)
3916 (update_file_ptrs, read_header, write_header, calculate_checksum)
3917 (copy_file, copy_rest, display_header): Likewise.
3918 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3919 Likewise.
3920 * xdisp.c (check_it): Likewise.
3921 * xfaces.c (register_color, unregister_color, unregister_colors):
3922 Likewise.
3923 * xfns.c (print_fontset_result): Likewise.
3924 * xrdb.c (member, fatal, main): Likewise.
3925
3926 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3927
3928 Fix minor problems found by static checking (Bug#9031).
3929 * chartab.c (char_table_set_range, map_sub_char_table):
3930 Remove unused locals.
3931 (uniprop_table): Now static.
3932 * composite.c (_work_char): Remove unused static var.
3933
3934 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3935
3936 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3937
3938 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3939
3940 * gtkutil.c (qttip_cb): Remove code without function.
3941
3942 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3943
3944 * w32.c (pthread_sigmask): New stub.
3945
3946 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 Use pthread_sigmask, not sigprocmask (Bug#9010).
3949 sigprocmask is portable only for single-threaded applications, and
3950 Emacs can be multi-threaded when it uses GTK.
3951 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3952 (LIBES): Use it.
3953 * callproc.c (Fcall_process):
3954 * process.c (create_process):
3955 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3956 Use pthread_sigmask, not sigprocmask.
3957
3958 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3959
3960 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3961 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3962 wrong (Bug#8591).
3963
3964 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3965
3966 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3967 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3968 (xg_hide_tooltip): Fix comment.
3969
3970 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3971 in registerServicesMenuSendTypes.
3972 (validRequestorForSendType): Don't check ns_return_types.
3973
3974 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3975 ns_return_type.
3976
3977 2011-07-08 Jason Rumney <jasonr@gnu.org>
3978
3979 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3980 SH_SHOW for hidden windows (Bug#5482).
3981
3982 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3983 frame struct members of non-existent frames (Bug#6284).
3984
3985 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3986
3987 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3988 variable firstTime not needed on OSX >= 10.6.
3989 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3990 >= 10.5. Use setKnobProportion, setDoubleValue.
3991
3992 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3993 (MAC_OS_X_VERSION_10_5): Define if not defined.
3994 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3995 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3996 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3997
3998 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3999 cString and lossyCString on OSX >= 10.4
4000
4001 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4002 sizeToFit on OSX >= 10.2.
4003
4004 * nsimage.m (allocInitFromFile): Don't use deprecated method
4005 bestRepresentationForDevice on OSX >= 10.6.
4006
4007 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4008 to avoid warning.
4009
4010 * emacs.c: Declare unexec_init_emacs_zone.
4011
4012 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4013
4014 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4015
4016 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4017 on svcsMenu (Bug#8842).
4018
4019 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4020 ns_return_types.
4021 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4022
4023 * nsterm.m (QUTF8_STRING): Declare.
4024 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4025 (validRequestorForSendType): Return type is (id).
4026 Change indexOfObjectIdenticalTo to indexOfObject.
4027 Check if we have local selection before returning self (Bug#8842).
4028 (writeSelectionToPasteboard): Put local selection into paste board
4029 if we have a local selection (Bug#8842).
4030 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4031
4032 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4033 (ns_get_local_selection): Declare.
4034
4035 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4036
4037 * keymap.c (describe_map_tree): Don't insert a double newline at
4038 the end of the buffer (bug#1169) and return whether we inserted
4039 something.
4040
4041 * callint.c (Fcall_interactively): Change "reading args" to
4042 "providing args" to try to clarify what it does (bug#1010).
4043
4044 2011-07-07 Kenichi Handa <handa@m17n.org>
4045
4046 * composite.c (composition_compute_stop_pos): Ignore a static
4047 composition starting before CHARPOS (Bug#8915).
4048
4049 * xdisp.c (handle_composition_prop): Likewise.
4050
4051 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4052
4053 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4054 (Bug#9015)
4055
4056 2011-07-07 Kenichi Handa <handa@m17n.org>
4057
4058 * character.h (unicode_category_t): New enum type.
4059
4060 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4061 (Qchar_code_property_table): New variable.
4062 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4063 (UNIPROP_COMPRESSED_FORM_P): New macros.
4064 (char_table_ascii): Uncompress the compressed values.
4065 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4066 Uncompress the compressed values.
4067 (sub_char_table_ref_and_range): Likewise.
4068 (char_table_ref_and_range): Uncompress the compressed values.
4069 (sub_char_table_set): New arg is_uniprop. Callers changed.
4070 Uncompress the compressed values.
4071 (sub_char_table_set_range): Args changed. Callers changed.
4072 (char_table_set_range): Adjuted for the above change.
4073 (map_sub_char_table): Delete args default_val and parent. Add arg
4074 top. Give decoded values to a Lisp function.
4075 (map_char_table): Adjust for the above change. Give decoded
4076 values to a Lisp function. Gcpro more variables.
4077 (uniprop_table_uncompress)
4078 (uniprop_decode_value_run_length): New functions.
4079 (uniprop_decoder, uniprop_decoder_count): New variables.
4080 (uniprop_get_decoder, uniprop_encode_value_character)
4081 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4082 New functions.
4083 (uniprop_encoder, uniprop_encoder_count): New variables.
4084 (uniprop_get_encoder, uniprop_table)
4085 (Funicode_property_table_internal, Fget_unicode_property_internal)
4086 (Fput_unicode_property_internal): New functions.
4087 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4088 Sunicode_property_table_internal, Sget_unicode_property_internal,
4089 and Sput_unicode_property_internal. Defvar_lisp
4090 char-code-property-alist.
4091
4092 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4093 Vunicode_category_table.
4094
4095 * font.c (font_range): Adjust for the change of
4096 Vunicode_category_table.
4097
4098 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4099
4100 * m/iris4d.h: Remove file, move contents ...
4101 * s/irix6-5.h: ... here.
4102
4103 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4104
4105 Remove unportable assumption about struct layout (Bug#8884).
4106 * alloc.c (mark_buffer):
4107 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4108 (clone_per_buffer_values): Don't assume that
4109 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4110 This isn't true in general, and it's particularly not true
4111 if Emacs is configured with --with-wide-int.
4112 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4113 New macros, used in the buffer.c change.
4114
4115 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4116
4117 * xsettings.c: Use both GConf and GSettings if both are available.
4118 (store_config_changed_event): Add comment.
4119 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4120 (store_tool_bar_style_changed): New functions.
4121 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4122 (struct xsettings): Move font inside HAVE_XFT.
4123 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4124 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4125 Move inside HAVE_XFT.
4126 (something_changed_gsettingsCB): Rename from something_changedCB.
4127 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4128 also.
4129 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4130 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4131 (something_changed_gconfCB): Rename from something_changedCB.
4132 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4133 (parse_settings): Move check for font inside HAVE_XFT.
4134 (read_settings, apply_xft_settings): Add comment.
4135 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4136 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4137 call store_font_name_changed.
4138 (xft_settings_event): Add comment.
4139 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4140 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4141 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4142 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4143 (xsettings_initialize): Call init_gsettings last.
4144 (xsettings_get_system_font, xsettings_get_system_normal_font):
4145 Add comment.
4146
4147 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4148
4149 Random fixes. E.g., (random) never returned negative values.
4150 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4151 subseconds part to the entropy, as that's a bit more random.
4152 Prefer signed to unsigned, since the signedness doesn't matter and
4153 in general we prefer signed. When given a limit, use a
4154 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4155 latter isn't right if USE_2_TAGS_FOR_INTS.
4156 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4157 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4158
4159 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4160
4161 * textprop.c (text_property_stickiness):
4162 Obey Vtext_property_default_nonsticky.
4163 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4164 * w32fns.c (syms_of_w32fns):
4165 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4166
4167 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4168
4169 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4170 This is more efficient than Ffile_directory_p and avoids a minor race.
4171
4172 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4173
4174 * buffer.c (Foverlay_put): Say what the return value is
4175 (bug#7835).
4176
4177 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4178 is a directory before asking whether to use the file name
4179 (bug#7564).
4180 (barf_or_query_if_file_exists): Make the "File is a directory"
4181 error be more correct.
4182
4183 * fns.c (Frequire): Remove the mention of the .gz files, since
4184 that's installation-specific, but keep the mention of
4185 `get-load-suffixes'.
4186
4187 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4188
4189 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4190 Report string overflow if the output is too long.
4191
4192 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4193
4194 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4195 (syms_of_gnutls): Remove duplicate DEFSYM for
4196 Qgnutls_bootprop_verify_hostname_error, an error for
4197 Qgnutls_bootprop_verify_error (which is no longer used).
4198
4199 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4200 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4201 Also (re)move comments that are misplaced or no longer relevant.
4202
4203 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4204
4205 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4206
4207 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4208
4209 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4210 and background color parameters if they have been changed.
4211
4212 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4213
4214 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4215
4216 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4217
4218 * xsettings.c (SYSTEM_FONT): Define only when used.
4219 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4220
4221 * keymap.c (access_keymap_1): Now static.
4222
4223 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4224
4225 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4226 leave any prefix arg for the up event (Bug#1586).
4227
4228 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4229
4230 * lread.c (syms_of_lread): Mention single symbols defined by
4231 `defvar' or `defconst' (bug#7154).
4232
4233 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4234 (Frequire): Mention get-load-suffixes.
4235
4236 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4237
4238 * window.h (window): Remove clone_number slot.
4239 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4240 Remove.
4241 (make_parent_window, make_window, saved_window)
4242 (Fset_window_configuration, save_window_save): Don't deal with
4243 clone numbers.
4244 * buffer.c (Qclone_number): Remove declaration.
4245 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4246
4247 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4248
4249 Add multiple inheritance to keymaps.
4250 * keymap.c (Fmake_composed_keymap): New function.
4251 (Fset_keymap_parent): Simplify.
4252 (fix_submap_inheritance): Remove.
4253 (access_keymap_1): New function extracted from access_keymap to handle
4254 embedded parents and handle lists of maps.
4255 (access_keymap): Use it.
4256 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4257 (Fcopy_keymap): Handle embedded parents.
4258 (Fcommand_remapping, define_as_prefix): Simplify.
4259 (Fkey_binding): Simplify.
4260 (syms_of_keymap): Move minibuffer-local-completion-map,
4261 minibuffer-local-filename-completion-map,
4262 minibuffer-local-must-match-map, and
4263 minibuffer-local-filename-must-match-map to Elisp.
4264 (syms_of_keymap): Defsubr make-composed-keymap.
4265 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4266 (parse_menu_item): Trivial simplification.
4267
4268 2011-07-01 Glenn Morris <rgm@gnu.org>
4269
4270 * Makefile.in (SETTINGS_LIBS): Fix typo.
4271
4272 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4273
4274 * coding.c (Fencode_coding_string): Record the last coding system
4275 used, as the function doc string says (bug#8738).
4276
4277 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4278
4279 * xsettings.c (store_monospaced_changed): Take new font as arg and
4280 check for change against current_mono_font.
4281 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4282 (emacs_settings_constructor, emacs_settings_get_property)
4283 (emacs_settings_set_property, emacs_settings_class_init)
4284 (emacs_settings_init, gsettings_obj): Remove.
4285 (something_changedCB): New function for HAVE_GSETTINGS.
4286 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4287 with value as argument.
4288 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4289 g_settings_new (Bug#8967). Do not create gsettings_obj.
4290 Remove calls to g_settings_bind. Connect something_changedCB to
4291 "changed".
4292
4293 * xgselect.c: Add defined (HAVE_GSETTINGS).
4294 (xgselect_initialize): Ditto.
4295
4296 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4297 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4298 xg_select.
4299
4300 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4301
4302 * eval.c (struct backtrace): Simplify and port the data structure.
4303 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4304 signed bit field, as this assumption is not portable and it makes
4305 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4306 "char debug_on_exit : 1" as this is not portable either; instead,
4307 use the portable "unsigned int debug_on_exit : 1". Remove unused
4308 member evalargs. Remove obsolete comments about cc bombing out.
4309
4310 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4311
4312 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4313 Let HAVE_GSETTINGS override HAVE_GCONF.
4314 (store_monospaced_changed): New function.
4315 (EMACS_SETTINGS): A new type derived from GObject to handle
4316 GSettings notifications.
4317 (emacs_settings_constructor, emacs_settings_get_property)
4318 (emacs_settings_set_property, emacs_settings_class_init):
4319 New functions.
4320 (gsettings_client, gsettings_obj): New variables.
4321 (GSETTINGS_SCHEMA): New define.
4322 (something_changedCB): Call store_monospaced_changed.
4323 (init_gsettings): New function.
4324 (xsettings_initialize): Call init_gsettings.
4325 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4326 to NULL.
4327
4328 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4329 GCONF_CFLAGS/LIBS.
4330
4331 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4332
4333 * window.c (resize_root_window, grow_mini_window)
4334 (shrink_mini_window): Rename Qresize_root_window to
4335 Qwindow_resize_root_window and Qresize_root_window_vertically to
4336 Qwindow_resize_root_window_vertically.
4337
4338 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4339
4340 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4341
4342 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4343
4344 * makefile.w32-in: Redesign dependencies so they reflect more
4345 clearly which files are directly included by each source file,
4346 and not through other includes.
4347
4348 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4349
4350 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4351 (sort_overlays, overlay_strings): When an overlay's clone number
4352 matches the window's clone number process the overlay even if
4353 the overlay's window property doesn't match the current window.
4354
4355 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4356 (Fwindow_hchild): Rename to Fwindow_left_child.
4357 (Fwindow_next): Rename to Fwindow_next_sibling.
4358 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4359 (resize_window_check): Rename to window_resize_check.
4360 (resize_window_apply): Rename to window_resize_apply.
4361 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4362 (Fdelete_other_windows_internal, resize_frame_windows)
4363 (Fsplit_window_internal, Fdelete_window_internal)
4364 (grow_mini_window, shrink_mini_window)
4365 (Fresize_mini_window_internal): Fix callers accordingly.
4366
4367 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4368
4369 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4370 (emacs_fixed_set_min_size): Remove.
4371 (emacs_fixed_new): Take frame as argument.
4372
4373 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4374 (_EmacsFixedPrivate): Remove minwidth/height.
4375 Add struct frame *f.
4376 (emacs_fixed_init): Initialize priv->f.
4377 (get_parent_class, emacs_fixed_set_min_size): Remove.
4378 (emacs_fixed_new): Set priv->f to argument.
4379 (emacs_fixed_get_preferred_width)
4380 (emacs_fixed_get_preferred_height): Use min_width/height from
4381 frames size_hint to set minimum and natural (Bug#8919).
4382 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4383 and use min_width/height from frames size_hint to set
4384 min_width/height (Bug#8919).
4385
4386 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4387 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4388 Fix indentation.
4389
4390 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4391
4392 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4393 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4394 called at ZV.
4395
4396 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4397
4398 * process.c (wait_reading_process_output): Bypass select if
4399 waiting for a cell while ignoring keyboard input, and input is
4400 pending. Suggested by Jan Djärv (Bug#8869).
4401
4402 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4403
4404 Use gnulib's dup2 module instead of rolling our own.
4405 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4406
4407 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4408
4409 * dispnew.c (scrolling_window): Before scrolling, turn off a
4410 mouse-highlight in the window being scrolled.
4411
4412 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4413
4414 Move DEFSYM to lisp.h and use everywhere.
4415
4416 * character.h (DEFSYM): Move declaration...
4417 * lisp.h (DEFSYM): ...here.
4418
4419 * gnutls.c:
4420 * minibuf.c:
4421 * w32menu.c:
4422 * w32proc.c:
4423 * w32select.c: Don't include character.h.
4424
4425 * alloc.c (syms_of_alloc):
4426 * buffer.c (syms_of_buffer):
4427 * bytecode.c (syms_of_bytecode):
4428 * callint.c (syms_of_callint):
4429 * casefiddle.c (syms_of_casefiddle):
4430 * casetab.c (init_casetab_once):
4431 * category.c (init_category_once, syms_of_category):
4432 * ccl.c (syms_of_ccl):
4433 * cmds.c (syms_of_cmds):
4434 * composite.c (syms_of_composite):
4435 * dbusbind.c (syms_of_dbusbind):
4436 * dired.c (syms_of_dired):
4437 * dispnew.c (syms_of_display):
4438 * doc.c (syms_of_doc):
4439 * editfns.c (syms_of_editfns):
4440 * emacs.c (syms_of_emacs):
4441 * eval.c (syms_of_eval):
4442 * fileio.c (syms_of_fileio):
4443 * fns.c (syms_of_fns):
4444 * frame.c (syms_of_frame):
4445 * fringe.c (syms_of_fringe):
4446 * insdel.c (syms_of_insdel):
4447 * keymap.c (syms_of_keymap):
4448 * lread.c (init_obarray, syms_of_lread):
4449 * macros.c (syms_of_macros):
4450 * msdos.c (syms_of_msdos):
4451 * print.c (syms_of_print):
4452 * process.c (syms_of_process):
4453 * search.c (syms_of_search):
4454 * sound.c (syms_of_sound):
4455 * syntax.c (init_syntax_once, syms_of_syntax):
4456 * terminal.c (syms_of_terminal):
4457 * textprop.c (syms_of_textprop):
4458 * undo.c (syms_of_undo):
4459 * w32.c (globals_of_w32):
4460 * window.c (syms_of_window):
4461 * xdisp.c (syms_of_xdisp):
4462 * xfaces.c (syms_of_xfaces):
4463 * xfns.c (syms_of_xfns):
4464 * xmenu.c (syms_of_xmenu):
4465 * xsettings.c (syms_of_xsettings):
4466 * xterm.c (syms_of_xterm): Use DEFSYM.
4467
4468 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4469
4470 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4471
4472 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4473
4474 Integer and buffer overflow fixes (Bug#8873).
4475
4476 * print.c (printchar, strout): Check for string overflow.
4477 (PRINTPREPARE, printchar, strout):
4478 Don't set size unless allocation succeeds.
4479
4480 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4481 for sizes. Check for string overflow more accurately.
4482 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4483
4484 * macros.c: Integer and buffer overflow fixes.
4485 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4486 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4487 Use ptrdiff_t, not int, for sizes.
4488 Don't increment bufsize until after realloc succeeds.
4489 Check for size-calculation overflow.
4490 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4491
4492 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4493
4494 * lread.c: Integer overflow fixes.
4495 (read_integer): Radix is now EMACS_INT, not int,
4496 to improve quality of diagnostics for out-of-range radices.
4497 Calculate buffer size correctly for out-of-range radices.
4498 (read1): Check for integer overflow in radices, and in
4499 read-circle numbers.
4500 (read_escape): Avoid int overflow.
4501 (Fload, openp, read_buffer_size, read1)
4502 (substitute_object_recurse, read_vector, read_list, map_obarray):
4503 Use ptrdiff_t, not int, for sizes.
4504 (read1): Use EMACS_INT, not int, for sizes.
4505 Check for size overflow.
4506
4507 * image.c (cache_image): Check for size arithmetic overflow.
4508
4509 * lread.c: Integer overflow issues.
4510 (saved_doc_string_size, saved_doc_string_length)
4511 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4512 Now ptrdiff_t, not int.
4513 (read1): Don't assume doc string length fits in int. Check for
4514 out-of-range doc string lengths.
4515 (read_list): Don't assume file position fits in int.
4516 (read_escape): Check for hex character overflow.
4517
4518 2011-06-22 Leo Liu <sdl.web@gmail.com>
4519
4520 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4521 Move to minibuffer.el.
4522
4523 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4524
4525 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4526 The following patches are for when GLYPH_DEBUG && !XASSERT.
4527 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4528 * dispnew.c (flush_stdout):
4529 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4530 Mark as externally visible.
4531 * dispnew.c (check_window_matrix_pointers): Now static.
4532 * dispnew.c (window_to_frame_vpos):
4533 * xfns.c (unwind_create_frame):
4534 * xterm.c (x_check_font): Remove unused local.
4535 * scroll.c (CHECK_BOUNDS):
4536 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4537 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4538 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4539 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4540 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4541 Now static.
4542 (debug_method_add): Use va_list and vsprintf rather than relying
4543 on undefined behavior with wrong number of arguments.
4544 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4545 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4546 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4547 since we're not interested in debugging glyphs with old libraries.
4548 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4549 GCC 4.6.0's static checking.
4550
4551 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4552
4553 Integer overflow and signedness fixes (Bug#8873).
4554 A few related buffer overrun fixes, too.
4555
4556 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4557
4558 * dispextern.h (struct face.stipple):
4559 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4560 (x_bitmap_mask, x_allocate_bitmap_record)
4561 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4562 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4563 (x_create_bitmap_from_xpm_data):
4564 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4565 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4566 (.bitmaps_last):
4567 * xfaces.c (load_pixmap):
4568 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4569 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4570 (.bitmaps_last, struct x_output.icon_bitmap):
4571 Use ptrdiff_t, not int, for bitmap indexes.
4572 (x_allocate_bitmap_record): Check for size overflow.
4573 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4574
4575 Use ptrdiff_t, not int, for overlay counts.
4576 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4577 * editfns.c (overlays_around, get_pos_property):
4578 * textprop.c (get_char_property_and_overlay):
4579 * xdisp.c (next_overlay_change, note_mouse_highlight):
4580 * xfaces.c (face_at_buffer_position):
4581 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4582 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4583 (Fnext_overlay_change, Fprevious_overlay_change)
4584 (mouse_face_overlay_overlaps, Foverlays_in):
4585 Use ptrdiff_t, not int, for sizes.
4586 (overlays_at, overlays_in): Check for size-calculation overflow.
4587
4588 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4589
4590 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4591 (x_session_initialize): Do not assume string length fits in int.
4592
4593 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4594 This is unlikely, but can occur if DPI is outlandish.
4595
4596 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4597 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4598
4599 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4600 * xrdb.c (magic_file_p, search_magic_path):
4601 Omit last arg SUFFIX; it was always 0. All callers changed.
4602 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4603
4604 * xfont.c (xfont_match): Avoid need for strlen.
4605
4606 * xfns.c: Don't assume strlen fits in int.
4607 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4608
4609 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4610 not unsigned long, as we prefer signed integers. All callers changed.
4611 Detect integer overflow in repeat count.
4612 (message_dolog): Don't assume print length fits in 39 bytes.
4613 (display_mode_element): Don't assume strlen fits in int.
4614
4615 * termcap.c: Don't assume sizes fit in int and never overflow.
4616 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4617 (gobble_line): Check for size-calculation overflow.
4618
4619 * minibuf.c (Fread_buffer):
4620 * lread.c (intern, intern_c_string):
4621 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4622 Don't assume string length fits in int.
4623
4624 * keyboard.c (parse_tool_bar_item):
4625 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4626
4627 * font.c: Don't assume string length fits in int.
4628 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4629 Use ptrdiff_t, not int.
4630 (font_intern_prop): Don't assume string length fits in int.
4631 Don't assume integer property fits in fixnum.
4632 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4633
4634 * filelock.c: Fix some buffer overrun and integer overflow issues.
4635 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4636 Reformulate so as not to need the command string.
4637 Invoke gzip -cd rather than gunzip, as it's more portable.
4638 (lock_info_type, lock_file_1, lock_file):
4639 Don't assume pid_t and time_t fit in unsigned long.
4640 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4641 (current_lock_owner): Prefer signed type for sizes.
4642 Use memcpy, not strncpy, where memcpy is what is really wanted.
4643 Don't assume (via atoi) that time_t and pid_t fit in int.
4644 Check for time_t and/or pid_t out of range, e.g., via a network share.
4645 Don't alloca where an auto var works fine.
4646
4647 * fileio.c: Fix some integer overflow issues.
4648 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4649 Don't assume string length fits in int.
4650 (directory_file_name): Don't assume string length fits in long.
4651 (make_temp_name): Don't assume pid fits in int, or that its print
4652 length is less than 20.
4653
4654 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4655
4656 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4657
4658 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4659
4660 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4661 We prefer signed integers, even for size calculations.
4662
4663 * emacs.c: Don't assume string length fits in 'int'.
4664 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4665 (main): Don't invoke strlen when not needed.
4666
4667 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4668 (XD_DEBUG_MESSAGE): Don't waste a byte.
4669
4670 * callproc.c (getenv_internal_1, getenv_internal)
4671 (Fgetenv_internal):
4672 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4673
4674 * lread.c (invalid_syntax): Omit length argument.
4675 All uses changed. This doesn't fix a bug, but it simplifies the
4676 code away from its former Hollerith-constant appearance, and it's
4677 one less 'int' to worry about when looking at integer-overflow issues.
4678 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4679
4680 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4681 This didn't break anything, but it didn't help either.
4682 It's confusing to put a bogus integer in a place where the actual
4683 value does not matter.
4684 (LIST_END_P): Remove unused macro and its bogus comment.
4685 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4686
4687 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4688 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4689 implementation.
4690 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4691 We prefer signed types, and the value cannot exceed the EMACS_INT
4692 range anyway (because otherwise the length would not be representable).
4693 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4694 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4695 This avoids a GCC warning when WIDE_EMACS_INT.
4696
4697 * indent.c (sane_tab_width): New function.
4698 (current_column, scan_for_column, Findent_to, position_indentation)
4699 (compute_motion): Use it. This is just for clarity.
4700 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4701
4702 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4703
4704 * lisp.h (lint_assume): New macro.
4705 * composite.c (composition_gstring_put_cache):
4706 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4707
4708 * editfns.c, insdel.c:
4709 Omit unnecessary forward decls, to simplify future changes.
4710
4711 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4712
4713 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4714
4715 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4716 Use much-faster test for byte-length change.
4717 Don't assume string byte-length fits in 'int'.
4718 Check that character arg fits in 'int'.
4719 (mapcar1): Declare byte as byte, for clarity.
4720
4721 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4722
4723 * fns.c (concat): Catch string overflow earlier.
4724 Do not rely on integer wraparound.
4725
4726 * dispextern.h (struct it.overlay_strings_charpos)
4727 (struct it.selective): Now EMACS_INT, not int.
4728 * xdisp.c (forward_to_next_line_start)
4729 (back_to_previous_visible_line_start)
4730 (reseat_at_next_visible_line_start, next_element_from_buffer):
4731 Don't arbitrarily truncate the value of 'selective' to int.
4732
4733 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4734
4735 * composite.c: Don't truncate sizes to 'int'.
4736 (composition_gstring_p, composition_reseat_it)
4737 (composition_adjust_point): Use EMACS_INT, not int.
4738 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4739 not EMACS_UINT, for indexes.
4740
4741 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4742
4743 * buffer.c: Include <verify.h>.
4744 (struct sortvec.priority, struct sortstr.priority):
4745 Now EMACS_INT, not int.
4746 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4747 (struct sortstr.size, record_overlay_string)
4748 (struct sortstrlist.size, struct sortlist.used):
4749 Don't truncate size to int.
4750 (record_overlay_string): Check for size-calculation overflow.
4751 (init_buffer_once): Check at compile-time, not run-time.
4752
4753 2011-06-22 Jim Meyering <meyering@redhat.com>
4754
4755 Don't leak an XBM-image-sized buffer
4756 * image.c (xbm_load): Free the image buffer after using it.
4757
4758 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4759
4760 Port to Sun C.
4761 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4762 that Sun C diagnosed.
4763 * fns.c (secure_hash): Fix pointer signedness issue.
4764 * intervals.c (static_offset_intervals): New function.
4765 (offset_intervals): Use it.
4766
4767 2011-06-21 Leo Liu <sdl.web@gmail.com>
4768
4769 * deps.mk (fns.o):
4770 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4771 sha512.h.
4772
4773 * fns.c (secure_hash): Rename from crypto_hash_function and change
4774 the first arg to accept symbols.
4775 (Fsecure_hash): New primitive.
4776 (syms_of_fns): New symbols.
4777
4778 2011-06-20 Deniz Dogan <deniz@dogan.se>
4779
4780 * process.c (Fset_process_buffer): Clarify return value in
4781 docstring.
4782
4783 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4784
4785 * dispnew.c (add_window_display_history): Use BVAR.
4786
4787 * xdisp.c (debug_method_add): Use BVAR.
4788 (check_window_end, dump_glyph_matrix, dump_glyph)
4789 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4790
4791 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4792 Likewise.
4793
4794 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4795 check till after the cache is created in init_frame_faces.
4796
4797 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4798
4799 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4800
4801 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4802
4803 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4804 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4805 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4806
4807 Improve buffer-overflow checking (Bug#8873).
4808 * fileio.c (Finsert_file_contents):
4809 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4810 Remove the old (too-loose) buffer overflow checks.
4811 They weren't needed, since make_gap checks for buffer overflow.
4812 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4813 The old code merely checked for Emacs fixnum overflow, and relied
4814 on undefined (wraparound) behavior. The new code avoids undefined
4815 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4816
4817 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4818 Tune. Don't use wider integers than needed. Don't use alloca.
4819 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4820
4821 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4822
4823 * insdel.c, lisp.h (buffer_overflow): New function.
4824 (insert_from_buffer_1, replace_range, replace_range_2):
4825 * insdel.c (make_gap_larger):
4826 * editfns.c (Finsert_char):
4827 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4828
4829 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4830
4831 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4832
4833 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4834
4835 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4836 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4837
4838 * fileio.c: Don't assume EMACS_INT fits in off_t.
4839 (emacs_lseek): New static function.
4840 (Finsert_file_contents, Fwrite_region): Use it.
4841 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4842
4843 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4844
4845 * fns.c: Don't overflow int when computing a list length.
4846 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4847 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4848 truncation on 64-bit hosts. Check for QUIT every
4849 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4850 faster and is responsive enough.
4851 (Flength): Report an error instead of overflowing an integer.
4852 (Fsafe_length): Return a float if the value is not representable
4853 as a fixnum. This shouldn't happen except in contrived situations.
4854 (Fnthcdr, Fsort): Don't assume list length fits in int.
4855 (Fcopy_sequence): Don't assume vector length fits in int.
4856
4857 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4858 (header_size, word_size): New constants.
4859 (allocate_vectorlike): Don't check size overflow here.
4860 (allocate_vector): Check it here instead, since this is the only
4861 caller of allocate_vectorlike that could cause overflow.
4862 Check that the new vector's length is representable as a fixnum.
4863
4864 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4865 The previous code was bogus. For example, next_almost_prime (32)
4866 returned 39, which is undesirable as it is a multiple of 3; and
4867 next_almost_prime (24) returned 25, which is a multiple of 5 so
4868 why was the code bothering to check for multiples of 7?
4869
4870 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4871
4872 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4873
4874 Variadic C functions now count arguments with ptrdiff_t.
4875 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4876 Back then I didn't know that the Emacs coding style prefers signed int.
4877 Also, in the meantime I found a few more instances where arguments
4878 were being counted with int, which may truncate counts on 64-bit
4879 machines, or EMACS_INT, which may be unnecessarily wide.
4880 * lisp.h (struct Lisp_Subr.function.aMANY)
4881 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4882 Arg counts are now ptrdiff_t, not size_t.
4883 All variadic functions and their callers changed accordingly.
4884 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4885 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4886 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4887 * callint.c (Fcall_interactively): Check arg count for overflow,
4888 to avoid potential buffer overrun. Use signed char, not 'int',
4889 for 'varies' array, so that we needn't bother to check its size
4890 calculation for overflow.
4891 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4892 * eval.c (apply_lambda):
4893 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4894 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4895 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4896
4897 * callint.c (Fcall_interactively): Don't use index var as event count.
4898
4899 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4900 * mem-limits.h (SIZE): Remove; no longer used.
4901
4902 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4903
4904 Remove unnecessary casts.
4905 * xterm.c (x_term_init):
4906 * xfns.c (x_set_border_pixel):
4907 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4908 These aren't needed now that we assume ANSI C.
4909
4910 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4911 It's more likely to cause problems (due to unsigned overflow)
4912 than to cure them.
4913
4914 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4915
4916 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4917
4918 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4919
4920 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4921
4922 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4923
4924 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4925
4926 GLYPH_CODE_FACE returns EMACS_INT, not int.
4927 * dispextern.h (merge_faces):
4928 * xfaces.c (merge_faces):
4929 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4930 Don't assume EMACS_INT fits in int.
4931
4932 * character.h (CHAR_VALID_P): Remove unused parameter.
4933 * fontset.c, lisp.h, xdisp.c: All uses changed.
4934
4935 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4936
4937 * fns.c (concat): Minor tuning based on overflow analysis.
4938 This doesn't fix any bugs. Use int to hold character, instead
4939 of constantly refetching from Emacs object. Use XFASTINT, not
4940 XINT, for value known to be a character. Don't bother comparing
4941 a single byte to 0400, as it's always less.
4942
4943 * floatfns.c (Fexpt):
4944 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4945
4946 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4947 for characters.
4948
4949 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4950
4951 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4952 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4953 incorrectly succeed when S was a string, because 4294967386 was
4954 truncated before it was used.
4955
4956 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4957 Otherwise, an out-of-range integer could cause undefined behavior
4958 on a 64-bit host.
4959
4960 * composite.c: Use int, not EMACS_INT, for characters.
4961 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4962 EMACS_INT, for values that are known to be in character range.
4963 This doesn't fix any bugs but is the usual style inside Emacs and
4964 may generate better code on 32-bit machines.
4965
4966 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4967 This is for reasons similar to the recent CHAR_STRING fix.
4968 * charset.c (Fencode_char): Check that character arg is actually
4969 a character. Pass an int to ENCODE_CHAR.
4970 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4971 wider than 'int', as a compile-time check to prevent future regressions
4972 in this area.
4973
4974 * character.c (char_string): Remove unnecessary casts.
4975
4976 Make sure a 64-bit char is never passed to CHAR_STRING.
4977 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4978 by silently ignoring the top 32 bits, allowing some values
4979 that were far too large to be valid characters.
4980 * character.h: Include <verify.h>.
4981 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4982 arguments are no wider than unsigned, as a compile-time check
4983 to prevent future regressions in this area.
4984 * data.c (Faset):
4985 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4986 (Fsubst_char_in_region):
4987 * fns.c (concat):
4988 * xdisp.c (decode_mode_spec_coding):
4989 Adjust to CHAR_STRING's new requirement.
4990 * editfns.c (Finsert_char, Fsubst_char_in_region):
4991 * fns.c (concat): Check that character args are actually
4992 characters. Without this test, these functions did the wrong
4993 thing with wildly out-of-range values on 64-bit hosts.
4994
4995 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4996 These casts should not be needed on 32-bit hosts, either.
4997 * keyboard.c (read_char):
4998 * lread.c (Fload): Remove casts to unsigned.
4999
5000 * lisp.h (UNSIGNED_CMP): New macro.
5001 This fixes comparison bugs on 64-bit hosts.
5002 (ASCII_CHAR_P): Use it.
5003 * casefiddle.c (casify_object):
5004 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5005 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5006 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5007 * dispextern.h (FACE_FROM_ID):
5008 * keyboard.c (read_char): Use UNSIGNED_CMP.
5009
5010 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5011 not to EMACS_INT, to avoid GCC warning.
5012
5013 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5014
5015 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5016 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5017 isn't needed on 32-bit machines.
5018
5019 * buffer.c (Fgenerate_new_buffer_name):
5020 Use EMACS_INT for count, not int.
5021 (advance_to_char_boundary): Return EMACS_INT, not int.
5022
5023 * data.c (Qcompiled_function): Now static.
5024
5025 * window.c (window_body_lines): Now static.
5026
5027 * image.c (gif_load): Rename local to avoid shadowing.
5028
5029 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5030 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5031 * alloc.c (make_save_value): Integer argument is now of type
5032 ptrdiff_t, not int.
5033 (mark_object): Use ptrdiff_t, not int.
5034 * lisp.h (pD): New macro.
5035 * print.c (print_object): Use it.
5036
5037 * alloc.c: Use EMACS_INT, not int, to count objects.
5038 (total_conses, total_markers, total_symbols, total_vector_size)
5039 (total_free_conses, total_free_markers, total_free_symbols)
5040 (total_free_floats, total_floats, total_free_intervals)
5041 (total_intervals, total_strings, total_free_strings):
5042 Now EMACS_INT, not int. All uses changed.
5043 (Fgarbage_collect): Compute overall total using a double, so that
5044 integer overflow is less likely to be a problem. Check for overflow
5045 when converting back to an integer.
5046 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5047 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5048 These were 'int' variables that could overflow on 64-bit hosts;
5049 they were never used, so remove them instead of repairing them.
5050 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5051 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5052 Previously, this ceilinged at INT_MAX, but that doesn't work on
5053 64-bit machines.
5054 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5055
5056 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5057 (allocate_vectorlike): Check for ptrdiff_t overflow.
5058 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5059 when a (possibly-narrower) signed value would do just as well.
5060 We prefer using signed arithmetic, to avoid comparison confusion.
5061
5062 * alloc.c: Catch some string size overflows that we were missing.
5063 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5064 for convenience in STRING_BYTES_MAX.
5065 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5066 The definition here is exact; the one in lisp.h was approximate.
5067 (allocate_string_data): Check for string overflow. This catches
5068 some instances we weren't catching before. Also, it catches
5069 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5070 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5071 and ptrdiff_t and EMACS_INT are both 64 bits.
5072
5073 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5074 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5075 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5076
5077 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5078
5079 * alloc.c (Fmake_string): Check for out-of-range init.
5080
5081 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5082
5083 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5084
5085 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5086
5087 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5088 xg_get_default_scrollbar_width.
5089
5090 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5091 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5092 (style_changed_cb): Call update_theme_scrollbar_width and call
5093 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5094 all frames (Bug#8505).
5095 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5096 Call gtk_window_set_resizable if HAVE_GTK3.
5097 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5098 and height if HAVE_GTK3 (Bug#8505).
5099 (scroll_bar_width_for_theme): New variable.
5100 (update_theme_scrollbar_width): New function.
5101 (xg_get_default_scrollbar_width): Move code to
5102 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5103 (xg_initialize): Call update_theme_scrollbar_width.
5104
5105 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5106
5107 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5108
5109 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5110
5111 * frame.c (make_frame): Call other_buffer_safely instead of
5112 other_buffer.
5113
5114 * window.c (temp_output_buffer_show): Call display_buffer with
5115 second argument Vtemp_buffer_show_specifiers and reset latter
5116 immediately after the call.
5117 (Vtemp_buffer_show_specifiers): New variable.
5118 (auto_window_vscroll_p, next_screen_context_lines)
5119 (Vscroll_preserve_screen_position): Remove leading asterisks from
5120 doc-strings.
5121
5122 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5123
5124 Fix minor problems found by GCC 4.6.0 static checking.
5125 * buffer.c (Qclone_number): Remove for now, as it's unused.
5126 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5127 (record_buffer): Remove unused local.
5128 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5129 (set_frame_buffer_list): Remove; unused.
5130 * frame.h (other_visible_frames): Remove decl.
5131 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5132 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5133 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5134 if HAVE_GPM.
5135 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5136 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5137 Define only if HAVE_GPM.
5138 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5139 (update_hints_inhibit): Remove; never set. All uses removed.
5140 * widgetprv.h (emacsFrameClassRec): Remove decl.
5141 * window.c (delete_deletable_window): Now returns void, since it
5142 wasn't returning anything.
5143 (compare_window_configurations): Remove unused locals.
5144 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5145 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5146 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5147 the same widths as pointers. This follows up on the 2011-05-06 patch.
5148 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5149 * xterm.h: Likewise.
5150 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5151
5152 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5153
5154 * makefile.w32-in: Update dependencies.
5155 (LISP_H): Add lib/intprops.h.
5156
5157 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5158
5159 * image.c (gif_load): Add animation frame delay to the metadata.
5160 (syms_of_image): Use DEFSYM. New symbol `delay'.
5161
5162 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5163
5164 * window.c (delete_deletable_window): Re-add.
5165 (Fset_window_configuration): Rewrite to handle dead buffers and
5166 consequently deletable windows.
5167 (window_tree, Fwindow_tree): Remove. Supply functionality in
5168 window.el.
5169 (compare_window_configurations): Simplify code.
5170
5171 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5172
5173 * image.c (imagemagick_load_image): Fix type mismatch.
5174 (Fimagemagick_types): Likewise.
5175
5176 * window.h (replace_buffer_in_windows): Declare.
5177
5178 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5179
5180 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5181 Qclone_number. Remove external declaration of Qdelete_window.
5182 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5183 code.
5184 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5185 Run Qbuffer_list_update_hook if allowed.
5186 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5187 buffer list implementation.
5188 (other_buffer_safely): New function.
5189 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5190 calls to replace_buffer_in_windows and
5191 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5192 if allowed.
5193 (record_buffer): Inhibit quitting and rewrite using quittable
5194 functions. Run Qbuffer_list_update_hook if allowed.
5195 (Frecord_buffer, Funrecord_buffer): New functions.
5196 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5197 Move switch-to-buffer to window.el.
5198 (bury-buffer): Move to window.el.
5199 (Vbuffer_list_update_hook): New variable.
5200
5201 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5202 section.
5203
5204 * window.h (resize_frame_windows): Move up in code.
5205 (Fwindow_frame): Remove EXFUN.
5206 (replace_buffer_in_all_windows): Remove prototype.
5207 (replace_buffer_in_windows_safely): Add prototype.
5208
5209 * window.c: Declare Qdelete_window static again. Move down
5210 declaration of select_count.
5211 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5212 (Fother_window): Move to window.el.
5213 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5214 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5215 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5216 window.el.
5217 (replace_buffer_in_windows): Implement by calling
5218 Qreplace_buffer_in_windows.
5219 (replace_buffer_in_all_windows): Remove with some functionality
5220 moved into replace_buffer_in_windows_safely.
5221 (replace_buffer_in_windows_safely): New function.
5222 (select_window_norecord, select_frame_norecord): Move in front
5223 of run_window_configuration_change_hook. Remove now obsolete
5224 declarations.
5225 (Fset_window_buffer): Rewrite doc-string.
5226 Call Qrecord_window_buffer.
5227 (keys_of_window): Move binding for other-window to window.el.
5228
5229 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5230
5231 * dispextern.h (struct image): Replace data member, whose int_val
5232 and ptr_val fields were not used by anything, with a single
5233 lisp_val object.
5234
5235 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5236 (gif_clear_image, gif_load, imagemagick_load_image)
5237 (gs_clear_image, gs_load): Callers changed.
5238
5239 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5240
5241 * buffer.h: Include <time.h>, for time_t.
5242 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5243
5244 Fix minor problems found by static checking.
5245
5246 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5247
5248 Make identifiers static if they are not used in other modules.
5249 * data.c (Qcompiled_function, Qframe, Qvector):
5250 * image.c (QimageMagick, Qsvg):
5251 * minibuf.c (Qmetadata):
5252 * window.c (resize_window_check, resize_root_window): Now static.
5253 * window.h (resize_window_check, resize_root_window): Remove decls.
5254
5255 * window.c (window_deletion_count, delete_deletable_window):
5256 Remove; unused.
5257 (window_body_lines): Now static.
5258 (Fdelete_other_windows_internal): Mark vars as initialized.
5259 Make sure 'resize_failed' is initialized.
5260 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5261 (resize_window_apply): Remove unused local.
5262 * window.h (delete_deletable_window): Remove decl.
5263
5264 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5265 (imagemagick_load_image): Fix pointer signedness problem by changing
5266 last arg from unsigned char * to char *. All uses changed.
5267 Also, fix a local for similar reasons.
5268 Remove unused locals. Remove locals to avoid shadowing.
5269 (fn_rsvg_handle_free): Remove; unused.
5270 (svg_load, svg_load_image): Fix pointer signedness problem.
5271 (imagemagick_load_image): Don't use garbage pointer image_wand.
5272
5273 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5274
5275 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5276
5277 * image.c (gif_load): Fix omitted cast error introduced by
5278 2011-06-06 change.
5279
5280 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5281
5282 * window.h (resize_proportionally, orig_total_lines)
5283 (orig_top_line): Remove from window structure.
5284 (set_window_height, set_window_width, change_window_heights)
5285 (Fdelete_window): Remove prototypes.
5286 (resize_frame_windows): Remove duplicate declaration.
5287
5288 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5289
5290 * window.h (resize_frame_windows, resize_window_check)
5291 (delete_deletable_window, resize_root_window)
5292 (resize_frame_windows): Declare prototypes.
5293
5294 * window.c (resize_window_apply): Make definition be "static" to
5295 match the prototype.
5296
5297 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5298
5299 * window.c: Remove declarations of Qwindow_size_fixed,
5300 window_min_size_1, window_min_size_2, window_min_size,
5301 size_window, window_fixed_size_p, enlarge_window, delete_window.
5302 Remove static from declaration of Qdelete_window, it's
5303 temporarily needed by Fbury_buffer.
5304 (replace_window): Don't assign orig_top_line and
5305 orig_total_lines.
5306 (Fdelete_window, delete_window): Remove. Window deletion is
5307 handled by window.el.
5308 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5309 Replace Fdelete_window calls with calls to Qdelete_window.
5310 (Fdelete_other_windows): Remove. Deleting other windows is
5311 handled by window.el.
5312 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5313 handled in window.el.
5314 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5315 Window minimum sizes are handled in window.el.
5316 (shrink_windows, size_window, set_window_height)
5317 (set_window_width, change_window_heights, window_height)
5318 (window_width, CURBEG, CURSIZE, enlarge_window)
5319 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5320 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5321 handled in window.el.
5322 (make_dummy_parent): Rename to make_parent_window and give it a
5323 second argument horflag.
5324 (make_window): Don't set resize_proportionally any more.
5325 (Fsplit_window): Remove. Windows are split in window.el.
5326 (save_restore_action, save_restore_orig_size)
5327 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5328 Resize mini windows in window.el.
5329 (grow_mini_window, shrink_mini_window): Implement by calling
5330 Qresize_root_window_vertically, resize_window_check and
5331 resize_window_apply.
5332 (saved_window, Fset_window_configuration, save_window_save):
5333 Do not handle orig_top_line, orig_total_lines, and
5334 resize_proportionally.
5335 (window_min_height, window_min_width): Move to window.el.
5336 (keys_of_window): Move bindings for delete-other-windows,
5337 split-window, delete-window and enlarge-window to window.el.
5338
5339 * buffer.c: Temporarily extern Qdelete_window.
5340 (Fbury_buffer): Temporarily call Qdelete_window instead of
5341 Fdelete_window (Fbury_buffer will move to window.el soon).
5342
5343 * frame.c (set_menu_bar_lines_1): Remove code handling
5344 orig_top_line and orig_total_lines.
5345
5346 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5347 set_window_height but set heights directly.
5348 (change_frame_size_1): Use resize_frame_windows.
5349
5350 * xdisp.c (init_xdisp): Don't use set_window_height but set
5351 heights directly.
5352
5353 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5354 Use resize_frame_windows instead of change_window_heights and run
5355 run_window_configuration_change_hook.
5356
5357 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5358 instead of change_window_heights and run
5359 run_window_configuration_change_hook.
5360
5361 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5362
5363 * window.c (replace_window): Rename second argument REPLACEMENT to
5364 NEW. New third argument SETFLAG. Rewrite.
5365 (delete_window, make_dummy_parent): Call replace_window with
5366 third argument 1.
5367 (window_list_1): Move down in code.
5368 (run_window_configuration_change_hook): Move set_buffer part
5369 before select_frame_norecord part in order to unwind correctly.
5370 Rename count1 to count.
5371 (recombine_windows, delete_deletable_window, resize_root_window)
5372 (Fdelete_other_windows_internal)
5373 (Frun_window_configuration_change_hook, make_parent_window)
5374 (resize_window_check, resize_window_apply, Fresize_window_apply)
5375 (resize_frame_windows, Fsplit_window_internal)
5376 (Fdelete_window_internal, Fresize_mini_window_internal):
5377 New functions.
5378 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5379
5380 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5381
5382 * window.h (window): Add some new members to window structure -
5383 normal_lines, normal_cols, new_total, new_normal, clone_number,
5384 splits, nest, prev_buffers, next_buffers.
5385 (WINDOW_TOTAL_SIZE): Move here from window.c.
5386 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5387
5388 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5389 Remove.
5390 (make_dummy_parent): Set new members of windows structure.
5391 (make_window): Move down in code. Handle new members of window
5392 structure.
5393 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5394 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5395 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5396 (Fset_window_prev_buffers, Fwindow_next_buffers)
5397 (Fset_window_next_buffers, Fset_window_clone_number):
5398 New functions.
5399 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5400 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5401 Doc-string fixes.
5402 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5403 Argument WINDOW can be now internal window too.
5404 (Fwindow_use_time): Move up in code.
5405 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5406 Rewrite doc-string.
5407 (Fset_window_configuration, saved_window)
5408 (Fcurrent_window_configuration, save_window_save): Handle new
5409 members of window structure.
5410 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5411 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5412 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5413 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5414 Qget_mru_window, Qresize_root_window,
5415 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5416 Qauto_buffer_name; staticpro them.
5417
5418 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5419
5420 * window.c (Fwindow_total_size, Fwindow_left_column)
5421 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5422 (Fwindow_list_1): New functions.
5423 (window_box_text_cols): Replace with window_body_cols.
5424 (Fwindow_width, Fscroll_left, Fscroll_right):
5425 Use window_body_cols instead of window_box_text_cols.
5426 (delete_window, Fset_window_configuration):
5427 Call delete_all_subwindows with window as argument.
5428 (delete_all_subwindows): Take a window as argument and not a
5429 structure. Rewrite.
5430 (window_loop): Remove handling of GET_LRU_WINDOW and
5431 GET_LARGEST_WINDOW.
5432 (Fget_lru_window, Fget_largest_window): Move to window.el.
5433
5434 * window.h: Extern window_body_cols instead of
5435 window_box_text_cols. delete_all_subwindows now takes a
5436 Lisp_Object as argument.
5437
5438 * indent.c (compute_motion, Fcompute_motion):
5439 Use window_body_cols instead of window_box_text_cols.
5440
5441 * frame.c (delete_frame): Call delete_all_subwindows with root
5442 window as argument.
5443
5444 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5445
5446 * fns.c (Fputhash): Document return value.
5447
5448 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5449
5450 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5451
5452 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5453
5454 Cons<->int and similar integer overflow fixes (Bug#8794).
5455
5456 Check for overflow when converting integer to cons and back.
5457 * charset.c (Fdefine_charset_internal, Fdecode_char):
5458 Use cons_to_unsigned to catch overflow.
5459 (Fencode_char): Use INTEGER_TO_CONS.
5460 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5461 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5462 * data.c (long_to_cons, cons_to_long): Remove.
5463 (cons_to_unsigned, cons_to_signed): New functions.
5464 These signal an error for invalid or out-of-range values.
5465 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5466 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5467 * font.c (Ffont_variation_glyphs):
5468 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5469 * lisp.h: Include <intprops.h>.
5470 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5471 (cons_to_signed, cons_to_unsigned): New decls.
5472 (long_to_cons, cons_to_long): Remove decls.
5473 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5474 (Fprimitive_undo): Use CONS_TO_INTEGER.
5475 * xfns.c (Fx_window_property): Likewise.
5476 * xselect.c: Include <limits.h>.
5477 (x_own_selection, selection_data_to_lisp_data):
5478 Use INTEGER_TO_CONS.
5479 (x_handle_selection_request, x_handle_selection_clear)
5480 (x_get_foreign_selection, Fx_disown_selection_internal)
5481 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5482 (lisp_data_to_selection_data): Use cons_to_unsigned.
5483 (x_fill_property_data): Use cons_to_signed.
5484 Report values out of range.
5485
5486 Check for buffer and string overflow more precisely.
5487 * buffer.h (BUF_BYTES_MAX): New macro.
5488 * lisp.h (STRING_BYTES_MAX): New macro.
5489 * alloc.c (Fmake_string):
5490 * character.c (string_escape_byte8):
5491 * coding.c (coding_alloc_by_realloc):
5492 * doprnt.c (doprnt):
5493 * editfns.c (Fformat):
5494 * eval.c (verror):
5495 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5496 since they may not be the same number.
5497 * editfns.c (Finsert_char):
5498 * fileio.c (Finsert_file_contents):
5499 Likewise for BUF_BYTES_MAX.
5500
5501 * image.c: Use ptrdiff_t, not int, for sizes.
5502 (slurp_file): Switch from int to ptrdiff_t.
5503 All uses changed.
5504 (slurp_file): Check that file size fits in both size_t (for
5505 malloc) and ptrdiff_t (for sanity and safety).
5506
5507 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5508 if b->modtime has its maximal value.
5509
5510 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5511
5512 Don't assume time_t can fit into int.
5513 * buffer.h (struct buffer.modtime): Now time_t, not int.
5514 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5515 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5516
5517 Minor fixes for signed vs unsigned integers.
5518 * character.h (MAYBE_UNIFY_CHAR):
5519 * charset.c (maybe_unify_char):
5520 * keyboard.c (read_char, reorder_modifiers):
5521 XINT -> XFASTINT, since the integer must be nonnegative.
5522 * ftfont.c (ftfont_spec_pattern):
5523 * keymap.c (access_keymap, silly_event_symbol_error):
5524 XUINT -> XFASTINT, since the integer must be nonnegative.
5525 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5526 since it makes no difference and we prefer signed.
5527 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5528 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5529 nonnegative.
5530
5531 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5532
5533 * window.h (Fwindow_frame): Declare.
5534
5535 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5536
5537 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5538 (SPARE_MEMORY): Always define.
5539 (LARGE_REQUEST): Remove.
5540 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5541
5542 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5543
5544 * lisp.h: Move EXFUNS for Fframe_root_window,
5545 Fframe_first_window and Fset_frame_selected_window to window.h.
5546
5547 * window.h: Move EXFUNS for Fframe_root_window,
5548 Fframe_first_window and Fset_frame_selected_window here from
5549 lisp.h.
5550
5551 * frame.c (Fwindow_frame, Fframe_first_window)
5552 (Fframe_root_window, Fframe_selected_window)
5553 (Fset_frame_selected_window): Move to window.c.
5554 (Factive_minibuffer_window): Move to minibuf.c.
5555 (Fother_visible_frames_p): New function.
5556
5557 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5558
5559 * window.c (decode_window, decode_any_window): Move up in code.
5560 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5561 (inhibit_frame_unsplittable): Remove unused variable.
5562 (Fwindow_buffer): Move up and rewrite doc-string.
5563 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5564 (Fwindow_prev): New functions.
5565 (Fwindow_frame): Move here from frame.c. Accept any window as
5566 argument.
5567 (Fframe_root_window, Fframe_first_window)
5568 (Fframe_selected_window): Move here from frame.c. Accept frame
5569 or arbitrary window as argument. Update doc-strings.
5570 (Fminibuffer_window): Move up in code.
5571 (Fwindow_minibuffer_p): Move up in code and simplify.
5572 (Fset_frame_selected_window): Move here from frame.c.
5573 Marginal rewrite.
5574 (Fselected_window, select_window, Fselect_window): Move up in
5575 code. Minor doc-string fixes.
5576
5577 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5578
5579 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5580 Do not assume that spare memory exists; that assumption is valid
5581 only if SYSTEM_MALLOC.
5582 (LARGE_REQUEST): New macro, so that the issue of large requests
5583 is separated from the issue of spare memory.
5584
5585 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5586
5587 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5588 format. (Bug#8806)
5589
5590 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5591
5592 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5593 before statements.
5594
5595 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5596
5597 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5598
5599 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5600
5601 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5602 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5603
5604 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5605
5606 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5607
5608 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5609
5610 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5611 (x_clipboard_manager_save): Add return value.
5612 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5613 New error handlers.
5614 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5615 Obey Vx_select_enable_clipboard_manager. Catch errors in
5616 x_clipboard_manager_save (Bug#8779).
5617 (Vx_select_enable_clipboard_manager): New variable.
5618 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5619
5620 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5621
5622 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5623
5624 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5625
5626 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5627 in the current matrix if keep_current_p is non-zero.
5628
5629 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5630
5631 * bidi.c (bidi_level_of_next_char): Fix last change.
5632
5633 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5634
5635 Support bidi reordering of text covered by display properties.
5636
5637 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5638 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5639 (bidi_cache_search, bidi_cache_iterator_state)
5640 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5641 (bidi_level_of_next_char, bidi_move_to_visually_next):
5642 Support character positions inside a run of characters covered by a
5643 display string.
5644 (bidi_paragraph_init, bidi_resolve_explicit_1)
5645 (bidi_level_of_next_char): Call bidi_fetch_char and
5646 bidi_fetch_char_advance instead of FETCH_CHAR and
5647 FETCH_CHAR_ADVANCE.
5648 (bidi_init_it): Initialize new members.
5649 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5650 definitions.
5651 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5652 instead of using explicit *_CHAR codes.
5653 (bidi_resolve_explicit, bidi_resolve_weak):
5654 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5655 bidirectional text is supported only in multibyte buffers.
5656 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5657 it to initialize the frame_window_p member of struct bidi_it.
5658 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5659 (bidi_resolve_explicit, bidi_resolve_weak)
5660 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5661 bidi_it->nchars is non-positive.
5662 (bidi_level_of_next_char): Don't try to lookup the cache for the
5663 next/previous character if nothing is cached there yet, or if we
5664 were just reseat()'ed to a new position.
5665
5666 * xdisp.c (set_cursor_from_row): Set start and stop points
5667 according to the row's direction when priming the loop that looks
5668 for the glyph on which to display cursor.
5669 (single_display_spec_intangible_p): Function deleted.
5670 (display_prop_intangible_p): Reimplement to call
5671 handle_display_spec instead of single_display_spec_intangible_p.
5672 Accept 3 additional arguments needed by handle_display_spec.
5673 This fixes incorrect cursor motion across display property with complex
5674 values: lists, `(when COND...)' forms, etc.
5675 (single_display_spec_string_p): Support property values that are
5676 lists with the argument STRING its top-level element.
5677 (display_prop_string_p): Fix the condition for processing a
5678 property that is a list to be consistent with handle_display_spec.
5679 (handle_display_spec): New function, refactored from the
5680 last portion of handle_display_prop.
5681 (compute_display_string_pos): Accept additional argument
5682 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5683 value of a `display' property is a "replacing spec".
5684 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5685 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5686 the display property, but just return a value indicating whether
5687 the display property will replace the characters it covers.
5688 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5689 frame_window_p members of struct bidi_it.
5690 (compute_display_string_pos, compute_display_string_end):
5691 New functions.
5692 (push_it): Accept second argument POSITION, where pop_it should
5693 jump to continue iteration.
5694 (reseat_1): Initialize bidi_it.disp_pos.
5695
5696 * keyboard.c (adjust_point_for_property): Adjust the call to
5697 display_prop_intangible_p to its new signature.
5698
5699 * dispextern.h (struct bidi_it): New member frame_window_p.
5700 (bidi_init_it): Update prototypes.
5701 (display_prop_intangible_p): Update prototype.
5702 (compute_display_string_pos, compute_display_string_end):
5703 Declare prototypes.
5704 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5705 EMACS_INT.
5706
5707 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5708
5709 Malloc failure behavior now depends on size of allocation.
5710 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5711 * lisp.h: Change signatures accordingly.
5712 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5713 All callers changed. (Bug#8762)
5714
5715 * gnutls.c: Use Emacs's memory allocators.
5716 Without this change, the gnutls library would invoke malloc etc.
5717 directly, which causes problems on non-SYNC_INPUT hosts, and which
5718 runs afoul of improving memory_full behavior. (Bug#8761)
5719 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5720 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5721 xfree instead of the default malloc, realloc, free.
5722 (Fgnutls_boot): No need to check for memory allocation failure,
5723 since xmalloc does that for us.
5724
5725 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5726 * category.c (hash_get_category_set):
5727 * ccl.c (ccl_driver):
5728 * charset.c (Fdefine_charset_internal):
5729 * charset.h (struct charset.hash_index):
5730 * composite.c (get_composition_id, gstring_lookup_cache)
5731 (composition_gstring_put_cache):
5732 * composite.h (struct composition.hash_index):
5733 * dispextern.h (struct image.hash):
5734 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5735 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5736 (hashfn_equal, hashfn_user_defined, make_hash_table)
5737 (maybe_resize_hash_table, hash_lookup, hash_put)
5738 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5739 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5740 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5741 * image.c (make_image, search_image_cache, lookup_image)
5742 (xpm_put_color_table_h):
5743 * lisp.h (struct Lisp_Hash_Table):
5744 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5745 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5746 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5747 * alloc.c (allocate_vectorlike):
5748 Check for overflow in vector size calculations.
5749 * ccl.c (ccl_driver):
5750 Check for overflow when converting EMACS_INT to int.
5751 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5752 need to be updated by these changes.
5753 * fns.c (make_hash_table, maybe_resize_hash_table):
5754 Check for integer overflow with large hash tables.
5755 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5756 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5757 (SXHASH_REDUCE): New macro.
5758 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5759 Use it instead of discarding useful hash info with large hash values.
5760 (sxhash_float): New function.
5761 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5762 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5763 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5764 Rewrite to use FIXNUM_BITS, as this simplifies things.
5765 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5766 Adjust signatures to match updated version of code.
5767 (consing_since_gc): Now EMACS_INT, since a single hash table can
5768 use more than INT_MAX bytes.
5769
5770 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5771
5772 Make it possible to build with GCC-4.6+ -O2 -flto.
5773
5774 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5775
5776 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5777
5778 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5779 Call minibuffer-inactive-mode.
5780
5781 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5782
5783 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5784 Update dependencies.
5785
5786 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5787
5788 * data.c (init_data): Remove code for UTS, this system is not
5789 supported anymore.
5790
5791 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5792
5793 Don't force ./temacs to start in terminal mode.
5794
5795 * frame.c (make_initial_frame): Initialize faces in all cases, not
5796 only when CANNOT_DUMP is defined.
5797 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5798
5799 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5800
5801 * dispnew.c (add_window_display_history): Use const for the string
5802 pointer. Remove declaration, not needed.
5803
5804 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5805
5806 Use 'inline', not 'INLINE'.
5807 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5808 * alloc.c, fontset.c (INLINE): Remove.
5809 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5810 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5811 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5812 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5813 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5814
5815 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5816
5817 Make it possible to run ./temacs.
5818
5819 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5820 syms_of_callproc does the same thing. Remove test for
5821 "initialized", do it in the caller.
5822 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5823
5824 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5825
5826 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5827 (read_minibuf): Use get_minibuffer.
5828 (syms_of_minibuf): Use DEFSYM.
5829 (Qmetadata): New var.
5830 * data.c (Qbuffer): Don't make it static.
5831 (syms_of_data): Use DEFSYM.
5832
5833 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5834
5835 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5836 (CCL_CODE_MIN): New macro.
5837
5838 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5839
5840 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5841
5842 * eval.c (Qdebug): Now static.
5843 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5844 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5845 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5846
5847 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5848
5849 * image.c: Various fixes to ImageMagick code comments.
5850 (Fimagemagick_types): Doc fix.
5851
5852 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5853
5854 Minor fixes prompted by GCC 4.6.0 warnings.
5855
5856 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5857
5858 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5859 (x_clipboard_manager_save_all): Move extern decl to ...
5860 * xterm.h: ... here, so that it can be checked for consistency.
5861
5862 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5863
5864 * xselect.c (x_clipboard_manager_save_frame)
5865 (x_clipboard_manager_save_all): New functions.
5866 (Fx_clipboard_manager_save): Lisp function deleted.
5867
5868 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5869 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5870
5871 * xterm.h: Update prototype.
5872
5873 2011-05-28 William Xu <william.xwl@gmail.com>
5874
5875 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5876 exiting (Bug#8239).
5877
5878 2011-05-28 Jim Meyering <meyering@redhat.com>
5879
5880 Avoid a sign-extension bug in crypto_hash_function.
5881 * fns.c (to_uchar): Define.
5882 (crypto_hash_function): Use it to convert some newly-signed
5883 variables to unsigned, to avoid sign-extension bugs. For example,
5884 without this change, (md5 "truc") would evaluate to
5885 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5886 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5887 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5888
5889 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5890
5891 Integer overflow fixes.
5892
5893 * dbusbind.c: Serial number integer overflow fixes.
5894 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5895 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5896 to hold a serial number that is too large for a fixnum.
5897 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5898 Check for serial numbers out of range. Decode any serial number
5899 that was so large that it became a float. (Bug#8722)
5900
5901 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5902 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5903 Use XFASTINT rather than XUINT when numbers are nonnegative.
5904 (xd_append_arg, Fdbus_method_return_internal):
5905 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5906 arguments, check that Lisp number is nonnegative, rather than
5907 silently wrapping negative numbers around. (Bug#8722)
5908 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5909 (Bug#8722)
5910
5911 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5912
5913 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5914
5915 ccl: Add integer overflow checks.
5916 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5917 (IN_INT_RANGE): New macros.
5918 (ccl_driver): Use them to check for integer overflow when
5919 decoding a CCL program. Many of the new checks are whether XINT (x)
5920 fits in int; it doesn't always, on 64-bit hosts. The new version
5921 doesn't catch all possible integer overflows, but it's an
5922 improvement. (Bug#8719)
5923
5924 * alloc.c (make_event_array): Use XINT, not XUINT.
5925 There's no need for unsigned here.
5926
5927 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5928 This follows up to the 2011-05-06 change that substituted uintptr_t
5929 for EMACS_INT. This case wasn't caught back then.
5930
5931 Rework Fformat to avoid integer overflow issues.
5932 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5933 now (part of C89). Include <verify.h>.
5934 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5935 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5936 (Fformat): Avoid the prepass trying to compute sizes; it was only
5937 approximate and thus did not catch overflow reliably. Instead, walk
5938 through the format just once, formatting and computing sizes as we go,
5939 checking for integer overflow at every step, and allocating a larger
5940 buffer as needed. Keep track separately whether the format is
5941 multibyte. Keep only the most-recently calculated precision, rather
5942 than them all. Record whether each argument has been converted to
5943 string. Use EMACS_INT, not int, for byte and char and arg counts.
5944 Support field widths and precisions larger than INT_MAX. Avoid
5945 sprintf's undefined behavior with conversion specifications such as %#d
5946 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5947 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5948 formatting out-of-range floating point numbers with int
5949 formats. (Bug#8668)
5950
5951 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5952
5953 * data.c: Avoid integer truncation in expressions involving floats.
5954 * data.c: Include <intprops.h>.
5955 (arith_driver): When there's an integer overflow in an expression
5956 involving floating point, convert the integers to floating point
5957 so that the resulting value does not suffer from catastrophic
5958 integer truncation. For example, on a 64-bit host (* 4
5959 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5960 Do not rely on undefined behavior after integer overflow.
5961
5962 merge count_size_as_multibyte, parse_str_to_multibyte
5963 * character.c, character.h (count_size_as_multibyte):
5964 Rename from parse_str_to_multibyte; all uses changed.
5965 Check for integer overflow.
5966 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5967 since it's now a duplicate of the other. This is more of
5968 a character than a buffer op, so better that it's in character.c.
5969 * fns.c, print.c: Adjust to above changes.
5970
5971 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5972
5973 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5974
5975 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5976
5977 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5978 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5979 (x_clipboard_manager_save): Now static.
5980 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5981
5982 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5983 (crypto_hash_function): Now static.
5984 Fix pointer signedness problems. Avoid unnecessary initializations.
5985
5986 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5987
5988 * termhooks.h (Vselection_alist): Make it terminal-local.
5989
5990 * terminal.c (create_terminal): Initialize it.
5991
5992 * xselect.c: Support for clipboard managers.
5993 (Vselection_alist): Move to termhooks.h as terminal-local var.
5994 (LOCAL_SELECTION): New macro.
5995 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5996 (symbol_to_x_atom): Remove gratuitous arg.
5997 (x_handle_selection_request, lisp_data_to_selection_data)
5998 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5999 (x_own_selection, x_get_local_selection, x_convert_selection):
6000 New arg, specifying work frame. Use terminal-local Vselection_alist.
6001 (some_frame_on_display): Delete unused function.
6002 (Fx_own_selection_internal, Fx_get_selection_internal)
6003 (Fx_disown_selection_internal, Fx_selection_owner_p)
6004 (Fx_selection_exists_p): New optional frame arg.
6005 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6006 (x_handle_selection_clear): Don't treat other terminals with the
6007 same keyboard specially. Use the terminal-local Vselection_alist.
6008 (x_clear_frame_selections): Use Frun_hook_with_args.
6009
6010 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6011
6012 * xterm.h: Add support for those atoms.
6013
6014 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6015
6016 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6017 (converted_selections, conversion_fail_tag): New global variables.
6018 (x_selection_request_lisp_error): Free the above.
6019 (x_get_local_selection): Remove unnecessary code.
6020 (x_reply_selection_request): Args changed; handle arbitrary array
6021 of converted selections stored in converted_selections.
6022 Separate the XChangeProperty and SelectionNotify steps.
6023 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6024 (x_convert_selection): New function.
6025 (x_handle_selection_event): Simplify.
6026 (x_get_foreign_selection): Don't ignore incoming requests while
6027 waiting for an answer; this will fail when we implement
6028 SAVE_TARGETS, and seems unnecessary anyway.
6029 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6030 (Vx_sent_selection_functions): Doc fix.
6031
6032 2011-05-26 Leo Liu <sdl.web@gmail.com>
6033
6034 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6035
6036 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6037
6038 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6039
6040 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6041 for fringe update if it has periodic bitmap.
6042 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6043 and fringe_bitmap_periodic_p.
6044
6045 * fringe.c (get_fringe_bitmap_data): New function.
6046 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6047 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6048 row. Mark glyph row for fringe update if periodicity changed.
6049
6050 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6051 for fringe update unless it has periodic bitmap.
6052
6053 2011-05-25 Kenichi Handa <handa@m17n.org>
6054
6055 * xdisp.c (get_next_display_element): Set correct it->face_id for
6056 a static composition.
6057
6058 2011-05-24 Leo Liu <sdl.web@gmail.com>
6059
6060 * deps.mk (fns.o):
6061 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6062
6063 * fns.c (crypto_hash_function, Fsha1): New function.
6064 (Fmd5): Use crypto_hash_function.
6065 (syms_of_fns): Add Ssha1.
6066
6067 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6068
6069 * gnutls.c: Remove unused macros.
6070 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6071 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6072 Remove macros that are defined and never used.
6073 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6074
6075 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6076
6077 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6078 (Fx_get_selection_internal): Minor cleanup.
6079 (Fx_own_selection_internal): Rename arguments for consistency with
6080 select.el.
6081
6082 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6083
6084 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6085
6086 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6087
6088 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6089
6090 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6091
6092 * dispnew.c (scrolling_window): Don't exclude the case that the
6093 last enabled row in the desired matrix touches the bottom boundary.
6094
6095 2011-05-21 Glenn Morris <rgm@gnu.org>
6096
6097 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6098 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6099 and add some more files.
6100
6101 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6102
6103 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6104 report_file_error introduced by the change from 2011-05-07.
6105
6106 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6107
6108 * systime.h (Time): Define only if emacs is defined.
6109 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6110 where the include path doesn't have X11/X.h by default. See
6111 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6112
6113 2011-05-20 Kenichi Handa <handa@m17n.org>
6114
6115 * composite.c (find_automatic_composition): Fix previous change.
6116
6117 2011-05-20 Glenn Morris <rgm@gnu.org>
6118
6119 * lisp.mk: New file, split from Makefile.in.
6120 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6121 (shortlisp): Remove.
6122 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6123
6124 2011-05-19 Glenn Morris <rgm@gnu.org>
6125
6126 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6127 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6128 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6129 (lisp): Set the order to that of loadup.el.
6130 (shortlisp): Make it a copy of $lisp.
6131 (SOME_MACHINE_LISP): Remove.
6132 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6133 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6134
6135 2011-05-18 Kenichi Handa <handa@m17n.org>
6136
6137 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6138 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6139 (find_automatic_composition): Mostly rewrite for efficiency.
6140
6141 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6142
6143 * makefile.w32-in: Update dependencies.
6144
6145 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6146
6147 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6148 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6149
6150 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6151
6152 Fix some integer overflow issues, such as string length overflow.
6153
6154 * insdel.c (count_size_as_multibyte): Check for string overflow.
6155
6156 * character.c (lisp_string_width): Check for string overflow.
6157 Use EMACS_INT, not int, for string indexes and lengths; in
6158 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6159 the resulting string length overflows an EMACS_INT; instead,
6160 report a string overflow if no precision given. When checking for
6161 precision exhaustion, use a check that cannot possibly have
6162 integer overflow. (Bug#8675)
6163 * character.h (lisp_string_width): Adjust to new signature.
6164
6165 * alloc.c (string_overflow): New function.
6166 (Fmake_string): Use it. This doesn't change behavior, but saves
6167 a few bytes and will simplify future changes.
6168 * character.c (string_escape_byte8): Likewise.
6169 * lisp.h (string_overflow): New decl.
6170
6171 Fixups, following up to the user-interface timestamp change.
6172 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6173 for UI timestamps, instead of unsigned long.
6174 * msdos.c (mouse_get_pos): Likewise.
6175 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6176 * w32gui.h (Time): Define by including "systime.h" rather than by
6177 declaring it ourselves. (Bug#8664)
6178
6179 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6180 * image.c (clear_image_cache): Likewise.
6181
6182 * term.c (term_mouse_position): Don't assume time_t wraparound.
6183
6184 Be more systematic about user-interface timestamps.
6185 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6186 and sometimes 'EMACS_UINT', to represent these timestamps.
6187 This change causes it to use 'Time' uniformly, as that's what X uses.
6188 This makes the code easier to follow, and makes it easier to catch
6189 integer overflow bugs such as Bug#8664.
6190 * frame.c (Fmouse_position, Fmouse_pixel_position):
6191 Use Time, not unsigned long, for user-interface timestamps.
6192 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6193 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6194 * keyboard.h (last_event_timestamp): Likewise.
6195 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6196 * menu.h (xmenu_show): Likewise.
6197 * term.c (term_mouse_position): Likewise.
6198 * termhooks.h (struct input_event.timestamp): Likewise.
6199 (struct terminal.mouse_position_hook): Likewise.
6200 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6201 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6202 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6203 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6204 what it was before.
6205 * menu.h, termhooks.h: Include "systime.h", for Time.
6206
6207 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6208 Don't assume that the difference between two unsigned long values
6209 can fit into an integer. At this point, we know button_down_time
6210 <= event->timestamp, so the difference must be nonnegative, so
6211 there's no need to cast the result if double-click-time is
6212 nonnegative, as it should be; check that it's nonnegative, just in
6213 case. This bug is triggered when events are more than 2**31 ms
6214 apart (about 25 days). (Bug#8664)
6215
6216 * xselect.c (last_event_timestamp): Remove duplicate decl.
6217 (x_own_selection): Remove needless cast to unsigned long.
6218
6219 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6220 that always fit in int. Use a sentinel instead of a counter, to
6221 avoid a temp and to allay GCC's concerns about possible int overflow.
6222 * frame.h (struct frame): Use int for menu_bar_items_used
6223 instead of EMACS_INT, since it always fits in int.
6224
6225 * menu.c (grow_menu_items): Check for int overflow.
6226
6227 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6228
6229 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6230 Before, the code was not consistent. These values cannot exceed
6231 2**31 - 1 so there's no need to make them unsigned.
6232 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6233 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6234 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6235 as modifiers.
6236 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6237
6238 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6239 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6240 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6241 presumably because the widths might not match.
6242
6243 * window.c (size_window): Avoid needless test at loop start.
6244
6245 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6246
6247 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6248
6249 2011-05-12 Drew Adams <drew.adams@oracle.com>
6250
6251 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6252
6253 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6254
6255 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6256 `width' to `bar_area_x' and `bar_area_width', respectively.
6257 (x_scroll_run): Take account of fringe background extension.
6258
6259 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6260 Rename local vars `left' and `width' to `bar_area_x' and
6261 `bar_area_width', respectively.
6262 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6263 background extension.
6264
6265 2011-05-10 Jim Meyering <meyering@redhat.com>
6266
6267 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6268
6269 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6270
6271 * image.c (Finit_image_library): Return t for built-in image types,
6272 like pbm and xbm. (Bug#8640)
6273
6274 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6275
6276 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6277
6278 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6279
6280 * w32console.c (Fset_screen_color): Doc fix.
6281 (Fget_screen_color): New function.
6282 (syms_of_ntterm): Defsubr it.
6283
6284 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6285 unlink the temporary file if Fcall_process didn't create it in the
6286 first place.
6287 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6288 child process will be redirected to a file specified with `:file'.
6289 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6290 cue to call_process_cleanup not to close that handle.
6291
6292 2011-05-07 Ben Key <bkey76@gmail.com>
6293
6294 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6295 one of two shell specific rules, either bootstrap-temacs-CMD or
6296 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6297 to the previous implementation of the bootstrap-temacs rule.
6298 The bootstrap-temacs-CMD rule is similar to the previous
6299 implementation of the bootstrap-temacs rule except that it
6300 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6301 variable.
6302
6303 These changes, along with some changes to nt/configure.bat,
6304 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6305 earlier fix to add support for --cflags and --ldflags options
6306 that include quotes so that it works whether make uses cmd or
6307 sh as the shell.
6308
6309 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6310
6311 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6312 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6313 is a constant.
6314 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6315 a string. Handle both cases.
6316 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6317 (Fdbus_register_method): Use Qinvalid_function.
6318
6319 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6320
6321 * makefile.w32-in: Update dependencies.
6322 (LISP_H): Add inttypes.h and stdin.h.
6323 (PROCESS_H): Add unistd.h.
6324
6325 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6326
6327 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6328 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6329
6330 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6331
6332 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6333
6334 * term.c (vfatal): Remove stray call to va_end.
6335 It's not needed and the C Standard doesn't allow it here anyway.
6336
6337 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6338 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6339
6340 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6341 bytes.
6342
6343 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6344
6345 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6346
6347 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6348
6349 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6350
6351 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6352
6353 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6354 * charset.c (Fdefine_charset_internal): Don't initialize
6355 charset.code_space[15]. The value was garbage, on hosts with
6356 32-bit int (Bug#8600).
6357
6358 * lread.c (read_integer): Be more consistent with string-to-number.
6359 Use string_to_number to do the actual conversion; this avoids
6360 rounding errors and fixes some other screwups. Without this fix,
6361 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6362 (digit_to_number): Move earlier, for benefit of read_integer.
6363 Return -1 if the digit is out of range for the base, -2 if it is
6364 not a digit in any supported base. (Bug#8602)
6365
6366 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6367
6368 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6369 to match comment at start of function. This also removes a
6370 GCC warning about overflow in a 32+64-bit port.
6371
6372 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6373
6374 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6375 Reported by Stefan Monnier in
6376 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6377 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6378 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6379
6380 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6381 (EMACS_UINTPTR): Likewise, with uintptr_t.
6382
6383 * lisp.h: Prefer 64-bit EMACS_INT if available.
6384 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6385 on 32-bit hosts that have 64-bit int, so that they can access
6386 large files.
6387 However, temporarily disable this change unless the temporary
6388 symbol WIDE_EMACS_INT is defined.
6389
6390 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6391
6392 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6393 This removes an assumption that EMACS_INT and long are the same
6394 width as pointers. The assumption is true for Emacs porting targets
6395 now, but we want to make other targets possible.
6396 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6397 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6398 In the rest of the code, change types of integers that hold casted
6399 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6400 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6401 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6402 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6403 No need to cast type when ORing.
6404 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6405 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6406 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6407 assume EMACS_INT is the same width as char *.
6408 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6409 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6410 Remove no-longer-needed casts.
6411 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6412 (xg_tool_bar_help_callback, xg_make_tool_item):
6413 Use EMACS_INTPTR to hold an integer
6414 that will be cast to void *; this can avoid a GCC warning
6415 if EMACS_INT is not the same width as void *.
6416 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6417 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6418 (current_message_1, set_message_1):
6419 Use a local to convert to proper width without a cast.
6420 * xmenu.c (dialog_selection_callback): Likewise.
6421
6422 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6423 Also, don't assume VALBITS / RAND_BITS is less than 5,
6424 and don't rely on undefined behavior when shifting a 1 left into
6425 the sign bit.
6426 * lisp.h (get_random): Change signature to match.
6427
6428 * lread.c (hash_string): Use size_t, not int, for hash computation.
6429 Normally we prefer signed values; but hashing is special, because
6430 it's better to use unsigned division on hash table sizes so that
6431 the remainder is nonnegative. Also, size_t is the natural width
6432 for hashing into memory. The previous code used 'int', which doesn't
6433 retain enough info to hash well into very large tables.
6434 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6435
6436 * dbusbind.c: Don't possibly lose pointer info when converting.
6437 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6438 Use XPNTR rather than XHASH, so that the high-order bits of
6439 the pointer aren't lost when converting through void *.
6440
6441 * eval.c (Fautoload): Don't double-shift a pointer.
6442
6443 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6444
6445 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6446
6447 * gnutls.c (DEF_GNUTLS_FN):
6448 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6449
6450 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6451
6452 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6453 marker. (Bug#8610)
6454
6455 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6456
6457 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6458 New version that can reserve upto 2GB of heap space.
6459
6460 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6461
6462 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6463
6464 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6465
6466 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6467 `gnutls_certificate_set_x509_key_file'.
6468
6469 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6470
6471 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6472 Update dependencies.
6473
6474 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6475
6476 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6477 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6478 Remove unused parameter `fildes'.
6479 * process.c (read_process_output, send_process): Don't pass it.
6480
6481 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6482
6483 Fix previous change: the library cache is defined in w32.c.
6484 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6485 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6486
6487 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6488
6489 Implement dynamic loading of GnuTLS on Windows.
6490
6491 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6492 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6493 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6494 Declare.
6495
6496 * gnutls.c (Qgnutls_dll): Define.
6497 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6498 (gnutls_*): Declare function pointers.
6499 (init_gnutls_functions): New function to initialize function pointers.
6500 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6501 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6502 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6503 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6504 (emacs_gnutls_write, emacs_gnutls_read)
6505 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6506 (Fgnutls_available_p): New function.
6507 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6508 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6509 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6510
6511 * image.c: Include w32.h.
6512 (Vimage_type_cache): Delete.
6513 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6514 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6515 (w32_delayed_load): Move to w32.c.
6516
6517 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6518
6519 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6520 (w32_delayed_load): Move from image.c. When loading a library, record
6521 its filename in the :loaded-from property of the library id.
6522 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6523 Initialize and staticpro them.
6524 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6525
6526 * process.c: Include lisp.h before w32.h, not after.
6527 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6528 instead of gnutls_record_check_pending.
6529
6530 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6531
6532 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6533
6534 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6535 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6536 as passed in.
6537
6538 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6539
6540 * xterm.c (x_set_frame_alpha): Do not set property on anything
6541 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6542
6543 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6544
6545 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6546
6547 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6548
6549 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6550 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6551 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6552 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6553 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6554 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6555 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6556 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6557 (Qgnutls_bootprop_callbacks_verify): Make static.
6558
6559 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6560
6561 * callproc.c: Indentation fixup.
6562
6563 * sysdep.c (wait_for_termination_1): Make static.
6564 (wait_for_termination, interruptible_wait_for_termination):
6565 Move after wait_for_termination_1.
6566
6567 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6568
6569 * sysdep.c (interruptible_wait_for_termination): New function
6570 which is like wait_for_termination, but allows keyboard
6571 interruptions.
6572
6573 * callproc.c (Fcall_process): Add (:file "file") as an option for
6574 the STDOUT buffer.
6575 (Fcall_process_region): Ditto.
6576
6577 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6578
6579 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6580 rather than `XVECTOR (FOO)->size'.
6581
6582 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6583 inttypes.h, as a gnulib replacement is used if it not available in
6584 system headers.
6585
6586 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6587
6588 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6589 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6590 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6591
6592 * coding.c (coding_alloc_by_realloc): Error out if destination
6593 will grow beyond MOST_POSITIVE_FIXNUM.
6594 (decode_coding_emacs_mule): Abort if there isn't enough place in
6595 charbuf for the composition carryover bytes. Reserve an extra
6596 space for up to 2 characters produced in a loop.
6597 (decode_coding_iso_2022): Abort if there isn't enough place in
6598 charbuf for the composition carryover bytes.
6599
6600 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6601
6602 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6603 aborting when %lld or %lll format is passed.
6604 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6605 %llo or %llx format is passed. (Bug#8545)
6606
6607 * window.c (window_scroll_line_based): Use a marker instead of
6608 simple variables to record original value of point. (Bug#7952)
6609
6610 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6611 produced by %s or %c overflows available buffer space. (Bug#8545)
6612
6613 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6614
6615 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6616 (SIZE_MAX): Move defn after all includes, as they might #define it.
6617
6618 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6619
6620 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6621
6622 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6623
6624 * keyboard.c (Qdelayed_warnings_hook): Define.
6625 (command_loop_1): Run `delayed-warnings-hook'
6626 if Vdelayed_warnings_list is non-nil.
6627 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6628 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6629
6630 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6631
6632 * doprnt.c (doprnt): Don't return value smaller than the buffer
6633 size if the message was truncated. (Bug#8545).
6634
6635 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6636
6637 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6638 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6639
6640 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6641
6642 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6643
6644 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6645
6646 * makefile.w32-in: Update dependencies.
6647
6648 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6649
6650 Improve `doprnt' and its usage. (Bug#8545)
6651 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6652 `format_end'. Remove support for %l as a conversion specifier.
6653 Don't use xrealloc. Improve diagnostics when the %l size modifier
6654 is used. Update the commentary.
6655
6656 * eval.c (verror): Simplify calculation of size_t.
6657
6658 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6659 messages.
6660
6661 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6662
6663 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6664 change.
6665
6666 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6667
6668 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6669 This makes this file independent of the recent pseudovector change.
6670
6671 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6672
6673 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6674
6675 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6676 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6677 Remove unused local.
6678 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6679
6680 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6681 GCC 4.6.0 optimizes based on type-based alias analysis.
6682 For example, if b is of type struct buffer * and v of type struct
6683 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6684 != &v->size, and therefore "v->size = 1; b->size = 2; return
6685 v->size;" must therefore return 1. This assumption is incorrect
6686 for Emacs, since it type-puns struct Lisp_Vector * with many other
6687 types. To fix this problem, this patch adds a new type struct
6688 vectorlike_header that documents the constraints on layout of vectors
6689 and pseudovectors, and helps optimizing compilers not get fooled
6690 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6691 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6692 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6693 the size member.
6694 (XSETPVECTYPE): Rewrite in terms of new macro.
6695 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6696 This is a bit clearer, and further avoids the possibility of
6697 undesirable aliasing.
6698 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6699 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6700 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6701 since Lisp_Subr is a special case (no "next" field).
6702 (ASIZE): Now uses header.size rather than size.
6703 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6704 to avoid the hassle of writing XVECTOR (foo)->header.size.
6705 (struct vectorlike_header): New type.
6706 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6707 object, to help avoid aliasing.
6708 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6709 (SUBRP): Likewise, since Lisp_Subr is a special case.
6710 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6711 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6712 (struct Lisp_Hash_Table): Combine first two members into a single
6713 struct vectorlike_header member. All uses of "size" and "next" members
6714 changed to be "header.size" and "header.next".
6715 * buffer.h (struct buffer): Likewise.
6716 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6717 * frame.h (struct frame): Likewise.
6718 * process.h (struct Lisp_Process): Likewise.
6719 * termhooks.h (struct terminal): Likewise.
6720 * window.c (struct save_window_data, struct saved_window): Likewise.
6721 * window.h (struct window): Likewise.
6722 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6723 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6724 * buffer.c (init_buffer_once): Likewise.
6725 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6726 special case.
6727 * process.c (Fformat_network_address): Use local var for size,
6728 for brevity.
6729
6730 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6731
6732 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6733 * data.c (atof): Remove decl; no longer used or needed.
6734 (digit_to_number): Move to lread.c.
6735 (Fstring_to_number): Use new string_to_number function, to be
6736 consistent with how the Lisp reader treats infinities and NaNs.
6737 Do not assume that floating-point numbers represent EMACS_INT
6738 without losing information; this is not true on most 64-bit hosts.
6739 Avoid double-rounding errors, by insisting on integers when
6740 parsing non-base-10 numbers, as the documentation specifies.
6741 * lisp.h (string_to_number): New decl, replacing ...
6742 (isfloat_string): Remove.
6743 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6744 (read1): Do not accept +. and -. as integers; this
6745 appears to have been a coding error. Similarly, do not accept
6746 strings like +-1e0 as floating point numbers. Do not report
6747 overflow for integer overflows unless the base is not 10 which
6748 means we have no simple and reliable way to continue.
6749 Break out the floating-point parsing into a new
6750 function string_to_number, so that Fstring_to_number parses
6751 floating point numbers consistently with the Lisp reader.
6752 (digit_to_number): Move here from data.c. Make it static inline.
6753 (E_CHAR, EXP_INT): Remove, replacing with ...
6754 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6755 (string_to_number): New function, replacing isfloat_string.
6756 This function checks for valid syntax and produces the resulting
6757 Lisp float number too. Rework it so that string-to-number
6758 no longer mishandles examples like "1.0e+". Use strtoumax,
6759 so that overflow for non-base-10 numbers is reported only when
6760 there's no portable and simple way to convert to floating point.
6761
6762 * textprop.c (set_text_properties_1): Rewrite for clarity,
6763 and to avoid GCC warning about integer overflow.
6764
6765 * intervals.h (struct interval): Use EMACS_INT for members
6766 where EMACS_UINT might cause problems. See
6767 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6768 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6769 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6770 All uses changed.
6771 (offset_intervals): Tell GCC not to worry about length overflow
6772 when negating a negative length.
6773
6774 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6775 (overrun_check_free): Likewise.
6776
6777 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6778 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6779 word size.
6780
6781 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6782 (gnutls_make_error): Rename local to avoid shadowing.
6783 (gnutls_emacs_global_deinit): ifdef out; not used.
6784 (Fgnutls_boot): Use const for pointer to readonly storage.
6785 Comment out unused local. Fix pointer signedness problems.
6786
6787 * lread.c (openp): Don't stuff size_t into an 'int'.
6788 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6789 about possible signed overflow.
6790
6791 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6792 (GDK_KEY_g): Don't define if already defined.
6793 (xg_prepare_tooltip): Avoid pointer signedness problem.
6794 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6795
6796 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6797 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6798
6799 * xfns.c (Fx_window_property): Simplify a bit,
6800 to make a bit faster and to avoid GCC 4.6.0 warning.
6801 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6802
6803 * fns.c (internal_equal): Don't assume size_t fits in int.
6804
6805 * alloc.c (compact_small_strings): Tighten assertion a little.
6806
6807 Replace pEd with more-general pI, and fix some printf arg casts.
6808 * lisp.h (pI): New macro, generalizing old pEd macro to other
6809 conversion specifiers. For example, use "...%"pI"d..." rather
6810 than "...%"pEd"...".
6811 (pEd): Remove. All uses replaced with similar uses of pI.
6812 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6813 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6814 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6815 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6816 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6817 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6818 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6819 64-bit hosts.
6820 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6821 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6822 * print.c (safe_debug_print, print_object): Likewise.
6823 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6824 to int.
6825 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6826 avoiding the 0 flag, which is not portable.
6827 * process.c (Fmake_network_process): Use pI to avoid cast.
6828 * region-cache.c (pp_cache): Likewise.
6829 * xdisp.c (decode_mode_spec): Likewise.
6830 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6831 behavior on 64-bit hosts with printf arg.
6832 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6833 (x_stop_queuing_selection_requests): Likewise.
6834 (x_get_window_property): Don't truncate byte count to an 'int'
6835 when tracing.
6836
6837 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6838 here, since it parses constructs like leading '-' and spaces,
6839 which are not wanted; and it overflows with large numbers.
6840 Instead, simply match F[0-9]+, which is what is wanted anyway.
6841
6842 * alloc.c: Remove unportable assumptions about struct layout.
6843 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6844 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6845 (allocate_vectorlike, make_pure_vector): Use the new macros,
6846 plus offsetof, to remove unportable assumptions about struct layout.
6847 These assumptions hold on all porting targets that I know of, but
6848 they are not guaranteed, they're easy to remove, and removing them
6849 makes further changes easier.
6850
6851 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6852 This doesn't fix a bug but makes the code clearer.
6853 (string_overrun_cookie): Now const. Use initializers that
6854 don't formally overflow signed char, to avoid warnings.
6855 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6856 can cause Emacs to crash when string overrun checking is enabled.
6857 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6858 multiple of sizeof (EMACS_INT); it need not be, if
6859 alignof(EMACS_INT) < sizeof (EMACS_INT).
6860 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6861
6862 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6863
6864 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6865
6866 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6867
6868 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6869 supposed to be handshaking. (Bug#8556)
6870 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6871
6872 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6873
6874 * lisp.h (Qdebug): List symbol.
6875 * eval.c (Qdebug): Restore global linkage.
6876 * keyboard.c (debug-on-event): New variable.
6877 (handle_user_signal): Break into debugger when debug-on-event
6878 matches the current signal symbol.
6879
6880 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6881
6882 * alloc.c (check_sblock, check_string_bytes)
6883 (check_string_free_list): Convert to standard C.
6884
6885 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6886
6887 * w32.c (emacs_gnutls_push): Fix typo.
6888
6889 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6890
6891 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6892 "cast to pointer from integer of different size".
6893
6894 Improve doprnt and its use in verror. (Bug#8545)
6895 * doprnt.c (doprnt): Document the set of format control sequences
6896 supported by the function. Use SAFE_ALLOCA instead of always
6897 using `alloca'.
6898
6899 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6900 is one byte too soon. Don't use xrealloc; instead xfree and
6901 xmalloc anew.
6902
6903 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6904
6905 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6906 callbacks stage.
6907
6908 * gnutls.c: Renamed global_initialized to
6909 gnutls_global_initialized. Added internals for the
6910 :verify-hostname-error, :verify-error, and :verify-flags
6911 parameters of `gnutls-boot' and documented those parameters in the
6912 docstring. Start callback support.
6913 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6914 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6915 on error. Return error code.
6916 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6917 (emacs_gnutls_read): Likewise.
6918 (Fgnutls_boot): Return handshake error code.
6919 (emacs_gnutls_handle_error): New function.
6920 (wsaerror_to_errno): Likewise.
6921
6922 * w32.h (emacs_gnutls_pull): Add prototype.
6923 (emacs_gnutls_push): Likewise.
6924
6925 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6926 (emacs_gnutls_push): Likewise.
6927
6928 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6929
6930 * process.c (wait_reading_process_output): Check if GnuTLS
6931 buffered some data internally if no FDs are set for TLS
6932 connections.
6933
6934 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6935 (LIBS): Link to USER_LIBS.
6936 ($(BLD)/gnutls.$(0)): New target.
6937
6938 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6939
6940 * xdisp.c (handle_single_display_spec): Rename the
6941 display_replaced_before_p argument into display_replaced_p, to
6942 make it consistent with the commentary. Fix typos in the
6943 commentary.
6944
6945 * textprop.c (syms_of_textprop): Remove dead code.
6946 (copy_text_properties): Delete obsolete commentary about an
6947 interface that was deleted long ago. Fix typos in the description
6948 of arguments.
6949
6950 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6951 to changes in oldXMenu/XMenu.h from 2011-04-16.
6952 <menu_help_message, prev_menu_help_message>: Constify.
6953 (IT_menu_make_room): menu->help_text is now `const char **';
6954 adjust.
6955
6956 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6957 to changes in oldXMenu/XMenu.h from 2011-04-16.
6958 (struct XMenu): Declare `help_text' `const char **'.
6959
6960 * xfaces.c <Qunspecified>: Make extern again.
6961
6962 * syntax.c: Include sys/types.h before including regex.h, as
6963 required by Posix.
6964
6965 * doc.c (get_doc_string): Improve the format passed to `error'.
6966
6967 * doprnt.c (doprnt): Improve commentary.
6968
6969 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6970
6971 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6972 them with etags.
6973
6974 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6975 changes in globals.h immediately force recompilation.
6976 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6977 $(CURDIR)/s/ms-w32.h.
6978 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6979
6980 * character.c (Fchar_direction): Function deleted.
6981 (syms_of_character): Don't defsubr it.
6982 <char-direction-table>: Deleted.
6983
6984 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6985
6986 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6987 * doprnt.c: Include limits.h.
6988 (SIZE_MAX): New macro.
6989 (doprnt): Return a size_t value. 2nd arg is now size_t.
6990 Many local variables are now size_t instead of int or unsigned.
6991 Improve overflow protection. Support `l' modifier for integer
6992 conversions. Support %l conversion. Don't assume an EMACS_INT
6993 argument for integer conversions and for %c.
6994
6995 * lisp.h (doprnt): Restore prototype.
6996
6997 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6998 $(SRC)/character.h.
6999
7000 * Makefile.in (base_obj): Add back doprnt.o.
7001
7002 * deps.mk (doprnt.o): Add back prerequisites.
7003 (callint.o): Depend on character.h.
7004
7005 * eval.c (internal_lisp_condition_case): Include the handler
7006 representation in the error message.
7007 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7008 when breaking from the loop.
7009
7010 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7011
7012 * callint.c (Fcall_interactively): When displaying error message
7013 about invalid control letter, pass the character's codepoint, not
7014 a pointer to its multibyte form. Improve display of the character
7015 in octal and display also its hex code.
7016
7017 * character.c (char_string): Use %x to display the (unsigned)
7018 codepoint of an invalid character, to avoid displaying a bogus
7019 negative value.
7020
7021 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7022 `error', not SYMBOL_NAME itself.
7023
7024 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7025 character arguments to `error'.
7026
7027 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7028 to `error' in error message about FINAL_CHAR argument. Make sure
7029 FINAL_CHAR is a character, and use %c when it is passed as
7030 argument to `error'.
7031
7032 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7033
7034 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7035
7036 * w32.c: Include <time.h>.
7037 (sys_localtime): New function.
7038
7039 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7040
7041 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7042
7043 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7044
7045 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7046
7047 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7048 zombies (Bug#8467).
7049
7050 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7051
7052 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7053 gl_state.e_property when gl_state.object is Qt.
7054
7055 * insdel.c (make_gap_larger): Remove limitation of buffer size
7056 to <= INT_MAX.
7057
7058 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7059
7060 * xdisp.c (lookup_glyphless_char_display)
7061 (produce_glyphless_glyph): Handle cons cell entry in
7062 glyphless-char-display.
7063 (Vglyphless_char_display): Document it.
7064
7065 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7066 glyphless-char-display.
7067
7068 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7069
7070 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7071
7072 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7073
7074 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7075 definition for no-X builds.
7076
7077 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7078
7079 Static checks with GCC 4.6.0 and non-default toolkits.
7080
7081 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7082
7083 * process.c (keyboard_bit_set): Define only if SIGIO.
7084 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7085 (send_process): Repair possible setjmp clobbering.
7086
7087 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7088
7089 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7090
7091 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7092
7093 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7094 Define only if needed.
7095
7096 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7097 by pacifying GCC about it. Maybe it's time to retire it?
7098 * xfaces.c (USG, __TIMEVAL__): Likewise.
7099
7100 * dispextern.h (struct redisplay_interface): Rename param
7101 to avoid shadowing.
7102 * termhooks.h (struct terminal): Likewise.
7103 * xterm.c (xembed_send_message): Likewise.
7104
7105 * insdel.c (make_gap_smaller): Define only if
7106 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7107
7108 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7109 it.
7110
7111 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7112 so that we aren't warned about unused symbols.
7113
7114 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7115
7116 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7117
7118 * xfns.c (x_real_positions): Mark locals as initialized.
7119
7120 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7121
7122 * xterm.c: Fix problems found by static analysis with other toolkits.
7123 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7124 (x_dispatch_event): Declare static if USE_GTK, and
7125 define if USE_GTK || USE_X_TOOLKIT.
7126 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7127 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7128 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7129 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7130
7131 * xmenu.c (menu_help_callback): Pointer type fixes.
7132 Use const pointers when pointing at readonly data. Avoid pointer
7133 signedness clashes.
7134 (FALSE): Remove unused macro.
7135 (update_frame_menubar): Remove unused decl.
7136
7137 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7138
7139 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7140 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7141 (single_menu_item): Rename local to avoid shadowing.
7142
7143 * keyboard.c (make_lispy_event): Remove unused local var.
7144
7145 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7146 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7147
7148 * bitmaps: Change bitmaps from unsigned char back to the X11
7149 compatible char. Avoid the old compiler warnings about
7150 out-of-range initializers by using, for example, '\xab' rather
7151 than 0xab.
7152
7153 * xgselect.c (xgselect_initialize): Check vs interface
7154 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7155
7156 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7157
7158 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7159 to read-only memory.
7160
7161 * fns.c (vector): Remove; this old hack is no longer needed.
7162
7163 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7164 Remove unused var.
7165 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7166
7167 * xrdb.c (x_load_resources): Omit unused local.
7168
7169 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7170 (x_window): Rename locals to avoid shadowing.
7171 (USG): Use the kludged USG macro, to pacify gcc.
7172
7173 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7174 (x_term_init): Remove local to avoid shadowing.
7175
7176 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7177
7178 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7179 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7180
7181 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7182
7183 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7184
7185 Fix regex.c, syntax.c and friends for buffers > 2GB.
7186 * syntax.h (struct gl_state_s): Declare character position members
7187 EMACS_INT.
7188
7189 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7190
7191 * textprop.c (verify_interval_modification, interval_of):
7192 Declare arguments EMACS_INT.
7193
7194 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7195 EMACS_INT.
7196
7197 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7198
7199 * indent.c (Fvertical_motion): Local variable it_start is now
7200 EMACS_INT.
7201
7202 * regex.c (re_match, re_match_2, re_match_2_internal)
7203 (bcmp_translate, regcomp, regexec, print_double_string)
7204 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7205 (re_compile_pattern, re_exec): Declare arguments and local
7206 variables `size_t' and `ssize_t' and return values `regoff_t', as
7207 appropriate.
7208 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7209 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7210 <compile_stack_type>: `size' and `avail' are now `size_t'.
7211
7212 * regex.h <regoff_t>: Use ssize_t, not int.
7213 (re_search, re_search_2, re_match, re_match_2): Arguments that
7214 specify buffer/string position and length are now ssize_t and
7215 size_t. Return type is regoff_t.
7216
7217 2011-04-16 Ben Key <bkey76@gmail.com>
7218
7219 * nsfont.m: Fixed bugs in ns_get_family and
7220 ns_descriptor_to_entity that were caused by using free to
7221 deallocate memory blocks that were allocated by xmalloc (via
7222 xstrdup). This caused Emacs to crash when compiled with
7223 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7224 --enable-checking=xmallocoverrun). xfree is now used to
7225 deallocate these memory blocks.
7226
7227 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7228
7229 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7230
7231 emacs_write: Accept and return EMACS_INT for sizes.
7232 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7233 et seq.
7234 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7235 Accept and return EMACS_INT.
7236 (emacs_gnutls_write): Return the number of bytes written on
7237 partial writes.
7238 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7239 (emacs_read, emacs_write): Remove check for negative size, as the
7240 Emacs source code has been audited now.
7241 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7242 (emacs_read, emacs_write): Use it.
7243 * process.c (send_process): Adjust to the new signatures of
7244 emacs_write and emacs_gnutls_write. Do not attempt to store
7245 a byte offset into an 'int'; it might overflow.
7246 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7247
7248 * sound.c: Don't assume sizes fit in 'int'.
7249 (struct sound_device.period_size, alsa_period_size):
7250 Return EMACS_INT, not int.
7251 (struct sound_device.write, vox_write, alsa_write):
7252 Accept EMACS_INT, not int.
7253 (wav_play, au_play): Use EMACS_INT to store sizes and to
7254 record read return values.
7255
7256 2011-04-15 Ben Key <bkey76@gmail.com>
7257
7258 * keyboard.c (Qundefined): Don't declare static since it is used
7259 in nsfns.m.
7260 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7261 static since they are used in nsfont.m.
7262
7263 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7264
7265 * process.c (Qprocessp): Don't declare static.
7266 * lisp.h (Qprocessp): Declare again.
7267
7268 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7269
7270 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7271
7272 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7273
7274 Improve C-level modularity by making more things 'static'.
7275
7276 Don't publish debugger-only interfaces to other modules.
7277 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7278 (verify_bytepos, count_markers): Move decls to the only modules
7279 that need them.
7280 * region-cache.h (pp_cache): Likewise.
7281 * window.h (check_all_windows): Likewise.
7282 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7283
7284 * sysdep.c (croak): Now static, if
7285 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7286 * syssignal.h (croak): Declare only if not static.
7287
7288 * alloc.c (refill_memory_reserve): Now static if
7289 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7290 * lisp.h (refill_memory_reserve): Declare only if not static.
7291
7292 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7293 Define only if USE_LUCID.
7294
7295 * xrdb.c (x_customization_string, x_rm_string): Now static.
7296
7297 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7298 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7299
7300 * xdisp.c (draw_row_with_mouse_face): Now static.
7301 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7302
7303 * window.h (check_all_windows): Mark externally visible.
7304
7305 * window.c (window_deletion_count): Now static.
7306
7307 * undo.c: Make symbols static if they're not exported.
7308 (last_undo_buffer, last_boundary_position, pending_boundary):
7309 Now static.
7310
7311 * textprop.c (interval_insert_behind_hooks): Now static.
7312 (interval_insert_in_front_hooks): Likewise.
7313
7314 * term.c: Make symbols static if they're not exported.
7315 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7316 (max_frame_lines, tty_set_terminal_modes):
7317 (tty_reset_terminal_modes, tty_turn_off_highlight):
7318 (get_tty_terminal): Now static.
7319 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7320 * termhooks.h (term_mouse_moveto): Do not declare if
7321 HAVE_WINDOW_SYSTEM.
7322 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7323 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7324
7325 * sysdep.c: Make symbols static if they're not exported.
7326 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7327 Now static.
7328 (sigprocmask_set, full_mask): Remove; unused.
7329 (wait_debugging): Mark as visible.
7330 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7331 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7332
7333 * syntax.c (syntax_temp): Define only if !__GNUC__.
7334
7335 * sound.c (current_sound_device, current_sound): Now static.
7336
7337 * search.c (searchbufs, searchbuf_head): Now static.
7338
7339 * scroll.c (scroll_cost): Remove; unused.
7340 * dispextern.h (scroll_cost): Remove decl.
7341
7342 * region-cache.h (pp_cache): Mark as externally visible.
7343
7344 * process.c: Make symbols static if they're not exported.
7345 (process_tick, update_tick, create_process, chan_process):
7346 (Vprocess_alist, proc_buffered_char, datagram_access):
7347 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7348 (deactivate_process): Mark defn as static, as well as decl.
7349 * lisp.h (create_process): Remove decl.
7350 * process.h (chan_process, Vprocess_alist): Remove decls.
7351
7352 * print.c: Make symbols static if they're not exported.
7353 (print_depth, new_backquote_output, being_printed, print_buffer):
7354 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7355 (print_interval, print_number_index, initial_stderr_stream):
7356 Now static.
7357 * lisp.h (Fprinc): Remove decl.
7358 (debug_output_compilation_hack): Mark as externally visible.
7359
7360 * sysdep.c (croak): Move decl from here to syssignal.h.
7361 * syssignal.h (croak): Put it here, so the API can be checked when
7362 'croak' is called from dissociate_if_controlling_tty.
7363
7364 * minibuf.c: Make symbols static if they're not exported.
7365 (minibuf_save_list, choose_minibuf_frame): Now static.
7366 * lisp.h (choose_minibuf_frame): Remove decl.
7367
7368 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7369
7370 * lread.c: Make symbols static if they're not exported.
7371 (read_objects, initial_obarray, oblookup_last_bucket_number):
7372 Now static.
7373 (make_symbol): Remove; unused.
7374 * lisp.h (initial_obarray, make_symbol): Remove decls.
7375
7376 * keyboard.c: Make symbols static if they're not exported.
7377 (single_kboard, recent_keys_index, total_keys, recent_keys):
7378 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7379 (this_single_command_key_start, echoing, last_auto_save):
7380 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7381 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7382 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7383 (Vlispy_mouse_stem, double_click_count):
7384 Now static.
7385 (force_auto_save_soon): Define only if SIGDANGER.
7386 (ignore_mouse_drag_p): Now static if
7387 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7388 (print_help): Remove; unused.
7389 (stop_character, last_timer_event): Mark as externally visible.
7390 * keyboard.h (ignore_mouse_drag_p): Declare only if
7391 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7392 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7393 * lisp.h (echoing): Remove decl.
7394 (force_auto_save_soon): Declare only if SIGDANGER.
7395 * xdisp.c (redisplay_window): Simplify code, to make it more
7396 obvious that ignore_mouse_drag_p is not accessed if !defined
7397 USE_GTK && !defined HAVE_NS.
7398
7399 * intervals.c: Make symbols static if they're not exported.
7400 (merge_properties_sticky, merge_interval_right, delete_interval):
7401 Now static.
7402 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7403
7404 * insdel.c: Make symbols static if they're not exported.
7405 However, leave prepare_to_modify_buffer alone. It's never
7406 called from outside this function, but that appears to be a bug.
7407 (combine_after_change_list, combine_after_change_buffer):
7408 (adjust_after_replace, signal_before_change): Now static.
7409 (adjust_after_replace_noundo): Remove; unused.
7410 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7411 (signal_before_change): Remove decls.
7412
7413 * indent.c (val_compute_motion, val_vmotion): Now static.
7414
7415 * image.c: Make symbols static if they're not exported.
7416 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7417 if USE_GTK.
7418 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7419 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7420
7421 * fringe.c (standard_bitmaps): Now static.
7422 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7423
7424 * frame.c: Make symbols static if they're not exported.
7425 (x_report_frame_params, make_terminal_frame): Now static.
7426 (get_frame_param): Now static, unless HAVE_NS.
7427 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7428 (x_get_resource_string): Remove; not used.
7429 * frame.h (make_terminal_frame, x_report_frame_params):
7430 (x_get_resource_string); Remove decls.
7431 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7432 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7433
7434 * font.c, fontset.c: Make symbols static if they're not exported.
7435 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7436 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7437 * font.c (font_close_object): Now static.
7438 * font.h (font_close_object): Remove.
7439 * fontset.c (FONTSET_OBJLIST): Remove.
7440 (free_realized_fontset) #if-0 the body, which does nothing.
7441 (face_suitable_for_char_p): #if-0, as it's never called.
7442 * fontset.h (face_suitable_for_char_p): Remove decl.
7443 * xfaces.c (face_at_string_position):
7444 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7445 since 0 is always ASCII.
7446
7447 * fns.c (weak_hash_tables): Now static.
7448
7449 * fileio.c: Make symbols static if they're not exported.
7450 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7451 (Vwrite_region_annotation_buffers): Now static.
7452
7453 * eval.c: Make symbols static if they're not exported.
7454 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7455 * lisp.h (backtrace_list): Remove decl.
7456
7457 * emacs.c: Make symbols static if they're not exported.
7458 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7459 (fatal_error_code, fatal_error_signal_hook, standard_args):
7460 Now static.
7461 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7462 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7463 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7464 * lisp.h (fatal_error_signal_hook): Remove decl.
7465 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7466
7467 * editfns.c: Move a (normally-unused) function to its only use.
7468 * editfns.c, lisp.h (get_operating_system_release): Remove.
7469 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7470 worth the hassle of breaking this out.
7471
7472 * xterm.c: Make symbols static if they're not exported.
7473 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7474 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7475 (x_destroy_window, x_delete_display):
7476 Now static.
7477 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7478 (x_mouse_leave): Remove; unused.
7479 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7480 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7481 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7482 Remove decls.
7483 (x_mouse_leave): Declare only if WINDOWSNT.
7484 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7485 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7486 USE_X_TOOLKIT.
7487
7488 * ftxfont.c: Make symbols static if they're not exported.
7489 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7490 HAVE_FREETYPE.
7491 * font.h (ftxfont_driver): Likewise.
7492
7493 * xfns.c: Make symbols static if they're not exported.
7494 (x_last_font_name, x_display_info_for_name):
7495 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7496 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7497 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7498 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7499 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7500 (last_show_tip_args): Now static.
7501 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7502 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7503 (x_screen_planes): Remove; unused.
7504 * dispextern.h (x_screen_planes): Remove decl.
7505
7506 * dispnew.c: Make symbols static if they're not exported.
7507 * dispextern.h (redraw_garbaged_frames, scrolling):
7508 (increment_row_positions): Remove.
7509 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7510 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7511 Now static.
7512 (redraw_garbaged_frames): Remove; unused.
7513
7514 * xfaces.c: Make symbols static if they're not exported.
7515 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7516 Remove decls.
7517 * xterm.h (defined_color): Remove decls.
7518 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7519 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7520 (menu_face_changed_default, defined_color, free_realized_face):
7521 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7522 (ascii_face_of_lisp_face): Remove; unused.
7523
7524 * xdisp.c: Make symbols static if they're not exported.
7525 * dispextern.h (scratch_glyph_row, window_box_edges):
7526 (glyph_to_pixel_coords, set_cursor_from_row):
7527 (get_next_display_element, set_iterator_to_next):
7528 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7529 (show_mouse_face): Remove decls
7530 * frame.h (message_buf_print): Likewise.
7531 * lisp.h (pop_message, set_message, check_point_in_composition):
7532 Likewise.
7533 * xterm.h (set_vertical_scroll_bar): Likewise.
7534 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7535 (message_buf_print, scratch_glyph_row, displayed_buffer):
7536 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7537 (get_next_display_element, show_mouse_face, window_box_edges):
7538 (frame_to_window_pixel_xy, check_point_in_composition):
7539 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7540 (glyph_to_pixel_coords): Remove; unused.
7541
7542 * dired.c (file_name_completion): Now static.
7543
7544 * dbusbind.c (xd_in_read_queued_messages): Now static.
7545
7546 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7547 * data.c (circular_list_error): Remove.
7548
7549 * commands.h (last_point_position, last_point_position_buffer):
7550 (last_point_position_window): Remove decls.
7551 * keyboard.c: Make these variables static.
7552
7553 * coding.h (coding, code_convert_region, encode_coding_gap):
7554 Remove decls.
7555 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7556 (iso_code_class, detect_coding, code_convert_region): Now static.
7557 (encode_coding_gap): Remove; unused.
7558
7559 * chartab.c (chartab_chars, chartab_bits): Now static.
7560
7561 * charset.h (charset_iso_8859_1): Remove decl.
7562 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7563 Now static.
7564
7565 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7566 * ccl.c (Vccl_program_table): Now static.
7567 (check_ccl_update): Remove; unused.
7568
7569 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7570 * category.h: ... from here.
7571 * category.c (check_category_table, set_category_set): Now static.
7572
7573 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7574 * lisp.h: Remove these decls.
7575
7576 * buffer.c (buffer_count): Remove unused var.
7577
7578 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7579 so that it's not optimized away.
7580 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7581 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7582 exported only to the debugger.
7583
7584 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7585 * atimer.h (run_all_atimers): Remove; not exported.
7586
7587 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7588 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7589 was inaccessible from Lisp.
7590 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7591 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7592
7593 alloc.c: Import and export fewer symbols, and remove unused items.
7594 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7595 is defined.
7596 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7597 it's not optimized away by whole-program optimization.
7598 (message_enable_multibyte, free_misc): Remove.
7599 (catchlist, handlerlist, mark_backtrace):
7600 Declare only if BYTE_MARK_STACK.
7601 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7602 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7603 (message_enable_multibyte): Remove decl.
7604 (free_misc, interval_free_list, float_block, float_block_index):
7605 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7606 (cons_free_list, last_marked_index):
7607 Now static.
7608 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7609 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7610 (mark_backtrace): Define only if BYTE_MARK_STACK.
7611 * xdisp.c (message_enable_multibyte): Now static.
7612
7613 Declare Lisp_Object Q* variables to be 'static' if not exported.
7614 This makes it easier for human readers (and static analyzers)
7615 to see whether these variables are used from other modules.
7616 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7617 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7618 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7619 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7620 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7621 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7622 * xmenu.c, xselect.c:
7623 Declare Q* vars static if they are not used in other modules.
7624 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7625 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7626 Remove decls of unexported vars.
7627 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7628
7629 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7630
7631 Make Emacs functions such as Fatom 'static' by default.
7632 This makes it easier for human readers (and static analyzers)
7633 to see whether these functions can be called from other modules.
7634 DEFUN now defines a static function. To make the function external
7635 so that it can be used in other C modules, use the new macro DEFUE.
7636 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7637 (Finit_image_library):
7638 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7639 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7640 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7641 Remove decls, since these functions are now static.
7642 (Funintern, Fget_internal_run_time): New decls, since these functions
7643 were already external.
7644
7645 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7646 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7647 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7648 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7649 * keyboard.c, keymap.c, lread.c:
7650 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7651 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7652 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7653 Mark functions with DEFUE instead of DEFUN,
7654 if they are used in other modules.
7655 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7656 decls for now-static functions.
7657 * buffer.h (Fdelete_overlay): Remove decl.
7658 * callproc.c (Fgetenv_internal): Mark as internal.
7659 * composite.c (Fremove_list_of_text_properties): Remove decl.
7660 (Fcomposition_get_gstring): New forward static decl.
7661 * composite.h (Fcomposite_get_gstring): Remove decl.
7662 * dired.c (Ffile_attributes): New forward static decl.
7663 * doc.c (Fdocumntation_property): New forward static decl.
7664 * eval.c (Ffetch_bytecode): New forward static decl.
7665 (Funintern): Remove extern decl; now in .h file where it belongs.
7666 * fileio.c (Fmake_symbolic_link): New forward static decl.
7667 * image.c (Finit_image_library): New forward static decl.
7668 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7669 * intervals.h (Fprevious_property_change):
7670 (Fremove_list_of_text_properties): Remove decls.
7671 * keyboard.c (Fthis_command_keys): Remove decl.
7672 (Fcommand_execute): New forward static decl.
7673 * keymap.c (Flookup_key): New forward static decl.
7674 (Fcopy_keymap): Now static.
7675 * keymap.h (Flookup_key): Remove decl.
7676 * process.c (Fget_process): New forward static decl.
7677 (Fprocess_datagram_address): Mark as internal.
7678 * syntax.c (Fsyntax_table_p): New forward static decl.
7679 (skip_chars): Remove duplicate decl.
7680 * textprop.c (Fprevious_property_change): New forward static decl.
7681 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7682 Now internal.
7683 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7684 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7685
7686 * editfns.c (Fformat): Remove unreachable code.
7687
7688 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7689
7690 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7691 change. (Bug#8496)
7692
7693 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7694
7695 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7696 when at ZV. (Bug#8487)
7697
7698 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7699
7700 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7701 (Bug#8437)
7702 * keyboard.c (parse_tool_bar_item): Likewise.
7703 * sound.c (sound_cleanup, alsa_close): Likewise.
7704 * termcap.c (tgetent): Likewise.
7705 * xfns.c (x_default_font_parameter): Likewise.
7706 * xsettings.c (read_and_apply_settings): Likewise.
7707
7708 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7709 (overrun_check_free): Protoize.
7710
7711 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7712
7713 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7714 since callers should never pass a negative size.
7715 Change the signature to match that of plain 'read' and 'write'; see
7716 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7717 * lisp.h: Update prototypes of emacs_write and emacs_read.
7718
7719 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7720
7721 * xdisp.c (redisplay_window): Don't try to determine the character
7722 position of the scroll margin if the window start point w->startp
7723 is outside the buffer's accessible region. (Bug#8468)
7724
7725 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7726
7727 Fix write-region and its subroutines for buffers > 2GB.
7728 * fileio.c (a_write, e_write): Modify declaration of arguments and
7729 local variables to support buffers larger than 2GB.
7730 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7731
7732 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7733 argument, local variables, and return value.
7734
7735 * lisp.h: Update prototypes of emacs_write and emacs_read.
7736
7737 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7738
7739 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7740
7741 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7742
7743 Fix more problems found by GCC 4.6.0's static checks.
7744
7745 * xdisp.c (vmessage): Use a better test for character truncation.
7746
7747 * charset.c (load_charset_map): <, not <=, for optimization,
7748 and to avoid potential problems with integer overflow.
7749 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7750 * casetab.c (set_identity, shuffle): Likewise.
7751 * editfns.c (Fformat): Likewise.
7752 * syntax.c (skip_chars): Likewise.
7753
7754 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7755 This also lets GCC 4.6.0 generate slightly better loop code.
7756
7757 * callint.c (Fcall_interactively): <, not <=, for optimization.
7758 (Fcall_interactively): Count the number of arguments produced,
7759 not the number of arguments given. This is simpler and lets GCC
7760 4.6.0 generate slightly better code.
7761
7762 * ftfont.c: Distingish more carefully between FcChar8 and char.
7763 The previous code passed unsigned char * to a functions like
7764 strlen and xstrcasecmp that expect char *, which does not
7765 conform to the C standard.
7766 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7767 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7768 char * when the C standard requires it.
7769
7770 * keyboard.c (read_char): Remove unused var.
7771
7772 * eval.c: Port to Windows vsnprintf (Bug#8435).
7773 Include <limits.h>.
7774 (SIZE_MAX): Define if the headers do not.
7775 (verror): Do not give up if vsnprintf returns a negative count.
7776 Instead, grow the buffer. This ports to Windows vsnprintf, which
7777 does not conform to C99. Problem reported by Eli Zaretskii.
7778 Also, simplify the allocation scheme, by avoiding the need for
7779 calling realloc, and removing the ALLOCATED variable.
7780
7781 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7782
7783 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7784 But keep the doprint source code for now, as we might revamp it
7785 and use it again (Bug#8435).
7786 * lisp.h (doprnt): Remove.
7787 * Makefile.in (base_obj): Remove doprnt.o.
7788 * deps.mk (doprnt.o): Remove.
7789
7790 error: Print 32- and 64-bit integers portably (Bug#8435).
7791 Without this change, on typical 64-bit hosts error ("...%d...", N)
7792 was used to print both 32- and 64-bit integers N, which relied on
7793 undefined behavior.
7794 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7795 * lisp.h (error, verror): Mark as printf-like functions.
7796 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7797 Report overflow in size calculations when allocating printf buffer.
7798 Do not truncate output string at its first null byte.
7799 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7800 Truncate the output at a character boundary, since vsnprintf does not
7801 do that.
7802 * charset.c (check_iso_charset_parameter): Convert internal
7803 character to string before calling 'error', since %c now has the
7804 printf meaning.
7805 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7806 overflow when computing char to be passed to 'error'. Do not
7807 pass Lisp_Object to 'error'; pass the integer instead.
7808 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7809 formatted with plain %d.
7810
7811 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7812
7813 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7814
7815 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7816
7817 * xterm.c (x_catch_errors): Remove duplicate declaration.
7818
7819 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7820
7821 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7822
7823 2011-04-10 Jim Meyering <meyering@redhat.com>
7824
7825 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7826 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7827 return ssize_t not "int", and use size_t as the buffer length.
7828 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7829 * gnutls.h: Update declarations.
7830 * process.c (read_process_output): Use ssize_t, to match.
7831 (send_process): Likewise.
7832
7833 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7834
7835 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7836
7837 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7838
7839 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7840 Use unsigned char, to match FcChar8 type definition.
7841
7842 * xterm.c (handle_one_xevent):
7843 * xmenu.c (create_and_show_popup_menu):
7844 * xselect.c (x_decline_selection_request)
7845 (x_reply_selection_request): Avoid type-punned deref of X events.
7846
7847 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7848
7849 Fix some uses of `int' instead of EMACS_INT.
7850 * search.c (string_match_1, fast_string_match)
7851 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7852 (scan_buffer, find_next_newline_no_quit)
7853 (find_before_next_newline, search_command, Freplace_match)
7854 (Fmatch_data): Make some `int' variables be EMACS_INT.
7855
7856 * xdisp.c (display_count_lines): 3rd argument and return value now
7857 EMACS_INT. All callers changed.
7858 (pint2hrstr): Last argument is now EMACS_INT.
7859
7860 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7861 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7862 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7863 (decode_coding_utf_16, decode_coding_emacs_mule)
7864 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7865 (decode_coding_ccl, decode_coding_charset)
7866 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7867 (decode_coding_iso_2022, decode_coding_emacs_mule)
7868 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7869 <char_offset, last_offset>: Declare EMACS_INT.
7870 (encode_coding_utf_8, encode_coding_utf_16)
7871 (encode_coding_emacs_mule, encode_invocation_designation)
7872 (encode_designation_at_bol, encode_coding_iso_2022)
7873 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7874 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7875 Declare EMACS_INT.
7876 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7877 (encode_invocation_designation): Last argument P_NCHARS is now
7878 EMACS_INT.
7879 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7880 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7881
7882 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7883 All users changed.
7884
7885 * ccl.c (Fccl_execute_on_string): Declare some variables
7886 EMACS_INT.
7887
7888 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7889
7890 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7891
7892 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7893
7894 * process.c (Fformat_network_address): Doc fix.
7895
7896 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7897
7898 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7899
7900 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7901
7902 * keyboard.c (read_char): Call Lisp function help-form-show,
7903 instead of using internal_with_output_to_temp_buffer.
7904 (Qhelp_form_show): New var.
7905 (syms_of_keyboard): Use DEFSYM macro.
7906
7907 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7908
7909 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7910
7911 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7912
7913 * process.c (Flist_processes): Remove to Lisp.
7914 (list_processes_1): Delete.
7915
7916 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7917
7918 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7919
7920 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7921
7922 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7923
7924 Fix more problems found by GCC 4.6.0's static checks.
7925
7926 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7927
7928 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7929
7930 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7931
7932 * xdisp.c (vmessage): Mark as a printf-like function.
7933
7934 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7935
7936 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7937
7938 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7939 printf-like functions.
7940 (tiff_load): Add casts to remove these marks before passing them
7941 to system-supplied API.
7942
7943 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7944
7945 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7946 This avoids several warnings with gcc -Wstrict-overflow.
7947 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7948 directly, rather than having caller test rule sign. This avoids
7949 some unnecessary tests.
7950 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7951 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7952 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7953
7954 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7955 (xfont_open): Avoid unnecessary tests.
7956
7957 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7958
7959 * composite.h, composite.c (composition_gstring_put_cache):
7960 Use EMACS_INT, not int, for length.
7961
7962 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7963 breaking out part of COMPOSITION_DECODE_RULE.
7964 (COMPOSITION_DECODE_RULE): Use it.
7965 * composite.c (get_composition_id): Remove unused local vars,
7966 by using the new macro.
7967
7968 * textprop.c (set_text_properties_1): Change while to do-while,
7969 since the condition is always true at first.
7970
7971 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7972 (interval_deletion_adjustment): Return unsigned value.
7973 All uses changed.
7974
7975 * process.c (list_processes_1, create_pty, read_process_output):
7976 (exec_sentinel): Remove vars that were set but not used.
7977 (create_pty): Remove unnecessary "volatile"s.
7978 (Fnetwork_interface_info): Avoid possibility of int overflow.
7979 (read_process_output): Do adaptive read buffering even if carryover.
7980 (read_process_output): Simplify nbytes computation if buffered.
7981
7982 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7983
7984 * syntax.c (scan_words): Remove var that was set but not used.
7985 (update_syntax_table): Use unsigned instead of int.
7986
7987 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7988 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7989 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7990
7991 * print.c (print_error_message): Avoid int overflow.
7992
7993 * font.c (font_list_entities): Redo for clarity,
7994 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7995
7996 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7997 (font_score): Avoid potential overflow in diff calculation.
7998
7999 * fns.c (substring_both): Remove var that is set but not used.
8000 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8001
8002 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8003
8004 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8005 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8006 can always succeed if overflow has undefined behavior.
8007
8008 * search.c (boyer_moore, wordify): Remove vars set but not used.
8009 (wordify): Omit three unnecessary tests.
8010
8011 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8012 All callers changed. This avoids the need for an unused var.
8013
8014 * casefiddle.c (casify_region): Remove var that is set but not used.
8015
8016 * dired.c (file_name_completion): Remove var that is set but not used.
8017
8018 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8019
8020 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8021 (Finsert_file_contents): Remove unnecessary code checking fd.
8022
8023 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8024 Check for integer overflow on size calculations.
8025
8026 * buffer.c (Fprevious_overlay_change): Remove var that is set
8027 but not used.
8028
8029 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8030 Remove vars that are set but not used.
8031 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8032 (timer_check_2): Mark vars as initialized.
8033
8034 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8035
8036 * image.c (lookup_image): Remove var that is set but not used.
8037 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8038
8039 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8040 that are set but not used.
8041
8042 * xfns.c (make_invisible_cursor): Don't return garbage
8043 if XCreateBitmapFromData fails (Bug#8410).
8044
8045 * xselect.c (x_get_local_selection, x_handle_property_notify):
8046 Remove vars that are set but not used.
8047
8048 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8049 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8050
8051 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8052 Remove var that is set but not used.
8053 (scroll_bar_windows_size): Now size_t, not int.
8054 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8055 Check for overflow.
8056
8057 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8058 (map_tty_color) [!defined MSDOS]: Likewise.
8059
8060 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8061
8062 * coding.c: Remove vars that are set but not used.
8063 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8064 All callers changed.
8065 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8066 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8067 (decode_coding_charset): Remove vars that are set but not used.
8068
8069 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8070 that is set but not used.
8071
8072 * print.c (print_object): Remove var that is set but not used.
8073
8074 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8075 The gnulib version avoids calling malloc in the usual case,
8076 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8077 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8078 * filelock.c (current_lock_owner): Likewise.
8079 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8080 * sysdep.c: Include allocator.h, careadlinkat.h.
8081 (emacs_no_realloc_allocator): New static constant.
8082 (emacs_readlink): New function.
8083 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8084 ../lib/careadlinkat.h.
8085
8086 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8087
8088 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8089 first non-nil return value).
8090
8091 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8092
8093 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8094 if not defined (Bug#8403).
8095
8096 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8097
8098 * xdisp.c (display_count_lines): Remove parameter `start',
8099 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8100 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8101 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8102 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8103 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8104 and thereabouts. All callers changed.
8105 (get_per_char_metric): Remove parameter `f', unused since
8106 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8107
8108 2011-04-02 Jim Meyering <meyering@redhat.com>
8109
8110 do not dereference NULL upon failed strdup
8111 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8112 (ns_get_family): Likewise.
8113
8114 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8115
8116 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8117
8118 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8119
8120 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8121 later (Bug#8403).
8122
8123 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8124
8125 Add lexical binding.
8126
8127 * window.c (Ftemp_output_buffer_show): New fun.
8128 (Fsave_window_excursion):
8129 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8130
8131 * lread.c (lisp_file_lexically_bound_p): New function.
8132 (Fload): Bind Qlexical_binding.
8133 (readevalloop): Remove `evalfun' arg.
8134 Bind Qinternal_interpreter_environment.
8135 (Feval_buffer): Bind Qlexical_binding.
8136 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8137 Mark as dynamic.
8138 (syms_of_lread): Declare `lexical-binding'.
8139
8140 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8141
8142 * keyboard.c (eval_dyn): New fun.
8143 (menu_item_eval_property): Use it.
8144
8145 * image.c (parse_image_spec): Use Ffunctionp.
8146
8147 * fns.c (concat, mapcar1): Accept byte-code-functions.
8148
8149 * eval.c (Fsetq): Handle lexical vars.
8150 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8151 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8152 (FletX, Flet): Obey lexical binding.
8153 (Fcommandp): Handle closures.
8154 (Feval): New `lexical' arg.
8155 (eval_sub): New function extracted from Feval. Use it almost
8156 everywhere where Feval was used. Look up vars in lexical env.
8157 Handle closures.
8158 (Ffunctionp): Move from subr.el.
8159 (Ffuncall): Handle closures.
8160 (apply_lambda): Remove `eval_flags'.
8161 (funcall_lambda): Handle closures and new byte-code-functions.
8162 (Fspecial_variable_p): New function.
8163 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8164 but without exporting it to Lisp.
8165
8166 * doc.c (Fdocumentation, store_function_docstring):
8167 * data.c (Finteractive_form): Handle closures.
8168
8169 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8170 interactive spec.
8171
8172 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8173 New byte-codes.
8174 (exec_byte_code): New function extracted from Fbyte_code to handle new
8175 calling convention for byte-code-functions. Add new byte-codes.
8176
8177 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8178
8179 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8180
8181 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8182
8183 * xdisp.c (redisplay_internal): Fix prototype.
8184
8185 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8186
8187 * xdisp.c (SCROLL_LIMIT): New macro.
8188 (try_scrolling): Use it when setting scroll_limit.
8189 Limit scrolling to 100 screen lines.
8190 (redisplay_window): Even when falling back on "recentering",
8191 position point in the window according to scroll-conservatively,
8192 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8193
8194 (try_scrolling): When point is above the window, allow searching
8195 as far as scroll_max, or one screenful, to compute vertical
8196 distance from PT to the scroll margin position. This prevents
8197 try_scrolling from unnecessarily failing when
8198 scroll-conservatively is set to a value slightly larger than the
8199 window height. Clean up the case of PT below the margin at bottom
8200 of window: scroll_max can no longer be INT_MAX. When aggressive
8201 scrolling is in use, don't let point enter the opposite scroll
8202 margin as result of the scroll.
8203 (syms_of_xdisp) <scroll-conservatively>: Document the
8204 threshold of 100 lines for never-recentering scrolling.
8205
8206 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8207
8208 * dispextern.h (move_it_by_lines):
8209 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8210 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8211 (message_log_check_duplicate): Remove parameters `prev_bol' and
8212 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8213 (redisplay_internal): Remove parameter `preserve_echo_area',
8214 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8215
8216 * indent.c (Fvertical_motion):
8217 * window.c (window_scroll_pixel_based, Frecenter):
8218 Don't pass `need_y_p' to `move_it_by_lines'.
8219
8220 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8221
8222 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8223 steal a few bits to be more compact.
8224 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8225 Remove unneeded casts.
8226
8227 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8228
8229 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8230
8231 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8232 binding" message (bug#7967).
8233
8234 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8235
8236 Fix more problems found by GCC 4.6.0's static checks.
8237
8238 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8239 Remove unused local var.
8240
8241 * editfns.c (Fmessage_box): Remove unused local var.
8242
8243 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8244 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8245 Omit unused local vars.
8246 * window.c (shrink_windows): Omit unused local var.
8247 * menu.c (digest_single_submenu): Omit unused local var.
8248 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8249 Omit unused local var.
8250
8251 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8252 Don't assume string length fits in int.
8253 (keyremap_step, read_key_sequence): Use size_t for sizes.
8254 (read_key_sequence): Don't check last_real_key_start redundantly.
8255
8256 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8257 instead of alloca (Bug#8344).
8258
8259 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8260 (Fbacktrace_frame): Don't assume nframes fits in int.
8261
8262 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8263
8264 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8265 concerns.
8266
8267 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8268
8269 * cm.c (calccost): Turn while-do into do-while, for clarity.
8270
8271 * keyboard.c (syms_of_keyboard): Use the same style as later
8272 in this function when indexing through an array. This also
8273 works around GCC bug 48267.
8274
8275 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8276
8277 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8278
8279 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8280 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8281
8282 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8283 This avoids undefined behavior on integer overflow, and is a bit
8284 more convenient anyway since it is compared to a size_t variable.
8285
8286 Variadic C functions now count arguments with size_t, not int.
8287 This avoids an unnecessary limitation on 64-bit machines, which
8288 caused (substring ...) to crash on large vectors (Bug#8344).
8289 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8290 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8291 All variadic functions and their callers changed accordingly.
8292 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8293 * data.c (arith_driver, float_arith_driver): Likewise.
8294 * editfns.c (general_insert_function): Likewise.
8295 * eval.c (struct backtrace.nargs, interactive_p)
8296 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8297 (funcall_lambda, mark_backtrace): Likewise.
8298 * fns.c (concat): Likewise.
8299 * frame.c (x_set_frame_parameters): Likewise.
8300 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8301 0 if not found, not -1. All callers changed.
8302
8303 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8304 (stack_copy_size): Now size_t, not int.
8305 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8306
8307 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8308
8309 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8310 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8311 All callers changed.
8312
8313 * lisp.h (multibyte_char_to_unibyte):
8314 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8315 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8316 * character.h (CHAR_TO_BYTE8):
8317 * cmds.c (internal_self_insert):
8318 * editfns.c (general_insert_function):
8319 * keymap.c (push_key_description):
8320 * search.c (Freplace_match):
8321 * xdisp.c (message_dolog, set_message_1): All callers changed.
8322
8323 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8324
8325 * keyboard.c (safe_run_hook_funcall): New function.
8326 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8327 don't set the hook to nil, but remove the offending function instead.
8328 (Qcommand_hook_internal): Remove, unused.
8329 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8330 Vcommand_hook_internal.
8331
8332 * eval.c (enum run_hooks_condition): Remove.
8333 (funcall_nil, funcall_not): New functions.
8334 (run_hook_with_args): Call each function through a `funcall' argument.
8335 Remove `cond' argument, now redundant.
8336 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8337 (Frun_hook_with_args_until_failure): Adjust accordingly.
8338 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8339
8340 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8341
8342 * dispextern.h (string_buffer_position): Remove declaration.
8343
8344 * print.c (strout): Remove parameter `multibyte', unused since
8345 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8346
8347 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8348 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8349 All callers changed.
8350
8351 * w32.c (_wsa_errlist): Use braces for struct initializers.
8352
8353 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8354 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8355 All callers changed.
8356 (string_buffer_position): Likewise. Also, make static (it's never
8357 used outside xdisp.c).
8358 (cursor_row_p): Remove parameter `w', unused since
8359 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8360 (decode_mode_spec): Remove parameter `precision', introduced during
8361 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8362 All callers changed.
8363
8364 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8365
8366 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8367
8368 2011-03-27 Anders Lindgren <andlind@gmail.com>
8369
8370 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8371 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8372 (ns_update_auto_hide_menu_bar): New functions.
8373 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8374 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8375 ns_constrain_all_frames.
8376 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8377 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8378
8379 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8380
8381 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8382
8383 2011-03-27 Glenn Morris <rgm@gnu.org>
8384
8385 * syssignal.h: Replace RETSIGTYPE with void.
8386 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8387 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8388 Replace SIGTYPE with void everywhere.
8389 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8390 * s/template.h (SIGTYPE): Remove commented out definition.
8391
8392 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8393
8394 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8395 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8396
8397 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8398
8399 * w32.c (read_unc_volume): Use parameter `henum', instead of
8400 global variable `wget_enum_handle'.
8401
8402 * keymap.c (describe_vector): Remove parameters `indices' and
8403 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8404 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8405
8406 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8407
8408 * keyboard.c (timer_check): Remove parameter `do_it_now',
8409 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8410 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8411 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8412
8413 * keyboard.c (read_char):
8414 * w32menu.c (w32_menu_display_help):
8415 * xmenu.c (show_help_event, menu_help_callback):
8416 Adjust calls to `show_help_echo'.
8417
8418 * gtkutil.c (xg_maybe_add_timer):
8419 * keyboard.c (readable_events):
8420 * process.c (wait_reading_process_output):
8421 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8422
8423 * insdel.c (adjust_markers_gap_motion):
8424 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8425 (gap_left, gap_right): Don't call it.
8426
8427 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8428
8429 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8430 incurred during fontification.
8431
8432 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8433
8434 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8435 (DEFVAR_PER_BUFFER): Don't pass it.
8436
8437 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8438 (scrolling_window): Don't pass it.
8439
8440 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8441
8442 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8443
8444 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8445 and `suffix'.
8446 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8447 of variables specific to SELinux and computation of `encoded_absname'.
8448
8449 * image.c (XPutPixel): Remove unused variable `height'.
8450
8451 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8452
8453 * unexw32.c (get_section_info): Remove unused variable `section'.
8454
8455 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8456 (system_process_attributes): Remove unused variable `sess'.
8457 (sys_read): Remove unused variable `err'.
8458
8459 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8460 (w32_wnd_proc): Remove unused variable `isdead'.
8461 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8462 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8463 (x_create_tip_frame): Remove unused variable `tem'.
8464
8465 * w32inevt.c (w32_console_read_socket):
8466 Remove unused variable `no_events'.
8467
8468 * w32term.c (x_draw_composite_glyph_string_foreground):
8469 Remove unused variable `width'.
8470
8471 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8472
8473 * w32term.c (x_set_glyph_string_clipping):
8474 Don't pass uninitialized region to CombineRgn.
8475
8476 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8477
8478 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8479 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8480 (Fx_close_connection): Remove unused variable `i'.
8481
8482 * w32font.c (w32font_draw): Return number of glyphs.
8483 (w32font_open_internal): Remove unused variable `i'.
8484 (w32font_driver): Add missing initializer.
8485
8486 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8487 (fill_in_menu): Remove unused variable `items_added'.
8488
8489 * w32term.c (last_mouse_press_frame): Remove static global variable.
8490 (w32_clip_to_row): Remove unused variable `f'.
8491 (x_delete_terminal): Remove unused variable `i'.
8492
8493 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8494 (NOTHING): Remove unused static global variable.
8495 (uniscribe_check_otf): Remove unused variable `table'.
8496 (uniscribe_font_driver): Add missing initializers.
8497
8498 2011-03-23 Julien Danjou <julien@danjou.info>
8499
8500 * term.c (Fsuspend_tty, Fresume_tty):
8501 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8502 * window.c (temp_output_buffer_show):
8503 * insdel.c (signal_before_change):
8504 * frame.c (Fhandle_switch_frame):
8505 * fileio.c (Fdo_auto_save):
8506 * emacs.c (Fkill_emacs):
8507 * editfns.c (save_excursion_restore):
8508 * cmds.c (internal_self_insert):
8509 * callint.c (Fcall_interactively):
8510 * buffer.c (Fkill_all_local_variables):
8511 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8512 Use Frun_hooks.
8513 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8514 unconditionally since it does the check itself.
8515
8516 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8517
8518 Fix more problems found by GCC 4.5.2's static checks.
8519
8520 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8521 the first time through the loop, since we know p0 < p1 then.
8522 This also avoids a gcc -Wstrict-overflow warning.
8523
8524 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8525 leading to a memory leak, possible in functions like
8526 load_charset_map_from_file that can allocate an unbounded number
8527 of objects (Bug#8318).
8528
8529 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8530 that could (at least in theory) be that large.
8531
8532 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8533 This is less likely to overflow, and avoids undefined behavior if
8534 overflow does occur. All callers changed. Use strtoul to scan
8535 for the unsigned long integer.
8536 (pint2hrstr): Simplify and tune code slightly.
8537 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8538
8539 * scroll.c (do_scrolling): Work around GCC bug 48228.
8540 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8541
8542 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8543 This also avoids a warning with gcc -Wstrict-overflow.
8544 (validate_x_resource_name): Simplify count usage.
8545 This also avoids a warning with gcc -Wstrict-overflow.
8546
8547 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8548 fail (Bug#8306).
8549
8550 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8551
8552 * process.c (Fmake_network_process): Use socklen_t, not int,
8553 where POSIX says socklen_t is required in portable programs.
8554 This fixes a porting bug on hosts like 64-bit HP-UX, where
8555 socklen_t is wider than int (Bug#8277).
8556 (Fmake_network_process, server_accept_connection):
8557 (wait_reading_process_output, read_process_output):
8558 Likewise.
8559
8560 * process.c: Rename or move locals to avoid shadowing.
8561 (list_processes_1, Fmake_network_process):
8562 (read_process_output_error_handler, exec_sentinel_error_handler):
8563 Rename or move locals.
8564 (Fmake_network_process): Define label "retry_connect" only if needed.
8565 (Fnetwork_interface_info): Fix pointer signedness.
8566 (process_send_signal): Add cast to avoid pointer signedness problem.
8567 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8568 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8569
8570 Make tparam.h and terminfo.c consistent.
8571 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8572 Include tparam.h instead, since it declares them.
8573 * cm.h (PC): Remove extern decl; tparam.h now does this.
8574 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8575 * terminfo.c: Include tparam.h, to check interfaces.
8576 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8577 (tparam): Adjust signature to match interface in tparam.h;
8578 this removes some undefined behavior. Check that outstring and len
8579 are zero, which they always are with Emacs.
8580 * tparam.h (PC, BC, UP): New extern decls.
8581
8582 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8583 (xftfont_open): Rename locals to avoid shadowing.
8584
8585 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8586 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8587 (OTF_TAG_SYM): Omit macro if not needed.
8588 (ftfont_list): Remove unused local.
8589 (get_adstyle_property, ftfont_pattern_entity):
8590 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8591 Rename locals to avoid shadowing.
8592
8593 * xfont.c (xfont_list_family): Mark var as initialized.
8594
8595 * xml.c (make_dom): Now static.
8596
8597 * composite.c (composition_compute_stop_pos): Rename local to
8598 avoid shadowing.
8599 (composition_reseat_it): Remove unused locals.
8600 (find_automatic_composition, composition_adjust_point): Likewise.
8601 (composition_update_it): Mark var as initialized.
8602 (find_automatic_composition): Mark vars as initialized,
8603 with a FIXME (Bug#8290).
8604
8605 character.h: Rename locals to avoid shadowing.
8606 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8607 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8608 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8609 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8610 to avoid shadowing.
8611
8612 * textprop.c (property_change_between_p): Remove; unused.
8613
8614 * intervals.c (interval_start_pos): Now static.
8615
8616 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8617
8618 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8619 Rename locals to avoid shadowing.
8620
8621 * sound.c (wav_play, au_play, Fplay_sound_internal):
8622 Fix pointer signedness.
8623 (alsa_choose_format): Remove unused local var.
8624 (wav_play): Initialize a variable to 0, to prevent undefined
8625 behavior (Bug#8278).
8626
8627 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8628
8629 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8630
8631 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8632 clobbering (Bug#8298).
8633 * sysdep.c (sys_subshell): Likewise.
8634 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8635
8636 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8637 This should get cleaned up, so that child_setup has the
8638 same signature on all platforms.
8639
8640 * callproc.c (call_process_cleanup): Now static.
8641 (relocate_fd): Rename locals to avoid shadowing.
8642
8643 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8644
8645 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8646 not to be necessary, and produces flickering.
8647
8648 2011-03-20 Glenn Morris <rgm@gnu.org>
8649
8650 * config.in: Remove file.
8651
8652 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8653
8654 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8655 are now in src/globals.h.
8656 (syms_of_minibuf): Remove spurious & from previous change.
8657
8658 2011-03-20 Leo Liu <sdl.web@gmail.com>
8659
8660 * minibuf.c (completing-read-function): New variable.
8661 (completing-read-default): Rename from completing-read.
8662 (completing-read): Call completing-read-function.
8663
8664 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8665
8666 * xfaces.c (Fx_load_color_file):
8667 Read color file from absolute filename (bug#8250).
8668
8669 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8670
8671 * makefile.w32-in: Update dependencies.
8672
8673 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8674
8675 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8676
8677 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8678
8679 Fix more problems found by GCC 4.5.2's static checks.
8680
8681 * process.c (make_serial_process_unwind, send_process_trap):
8682 (sigchld_handler): Now static.
8683
8684 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8685 That way, the code declares only the vars that it needs.
8686 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8687 * s/cygwin.h (PTY_ITERATION): Likewise.
8688 * s/darwin.h (PTY_ITERATION): Likewise.
8689 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8690
8691 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8692 * process.c (allocate_pty): Don't declare stb unless it's needed.
8693
8694 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8695 (CONSTANTLIM): Remove; unused.
8696 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8697 Define only if needed.
8698
8699 * unexelf.c (unexec): Name an expression,
8700 to avoid gcc -Wbad-function-cast warning.
8701 Use a different way to cause a compilation error if anyone uses
8702 n rather than nn, a way that does not involve shadowing.
8703 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8704
8705 * deps.mk (unexalpha.o): Remove; unused.
8706
8707 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8708 * unexec.h: New file.
8709 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8710 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8711 Depend on unexec.h.
8712 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8713 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8714 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8715 Change as necessary to match prototype in unexec.h.
8716
8717 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8718 shadowing.
8719 (back_comment, skip_chars): Mark vars as initialized.
8720
8721 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8722 Rename locals to avoid shadowing.
8723
8724 * lread.c (read1): Rewrite so as not to use empty "else".
8725 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8726
8727 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8728
8729 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8730 warning when compiling print.c.
8731
8732 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8733 instead of using an uninitialized var.
8734 (font_sort_entities): Mark var as initialized.
8735
8736 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8737
8738 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8739 pointers to constants.
8740 (font_parse_fcname): Remove unused vars.
8741 (font_delete_unmatched): Now static.
8742 (font_get_spec): Remove; unused.
8743 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8744 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8745 Rename or move locals to avoid shadowing.
8746
8747 * fns.c (require_nesting_list, require_unwind): Now static.
8748 (Ffillarray): Rename locals to avoid shadowing.
8749
8750 * floatfns.c (domain_error2): Define only if needed.
8751 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8752
8753 * alloc.c (mark_backtrace): Move decl from here ...
8754 * lisp.h: ... to here, so that it can be checked.
8755
8756 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8757 (Fdefvar): Rewrite so as not to use empty "else".
8758 (lisp_indirect_variable): Name an expression,
8759 to avoid gcc -Wbad-function-cast warning.
8760 (Fdefvar): Rename locals to avoid shadowing.
8761
8762 * callint.c (quotify_arg, quotify_args): Now static.
8763 (Fcall_interactively): Rename locals to avoid shadowing.
8764 Use const pointer when appropriate.
8765
8766 * lisp.h (get_system_name, get_operating_system_release):
8767 Move decls here, to check interfaces.
8768 * process.c (get_operating_system_release): Move decl to lisp.h.
8769 * xrdb.c (get_system_name): Likewise.
8770 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8771 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8772 some of which prompt warnings from gcc -Wbad-function-cast.
8773 (Fformat_time_string, Fencode_time, Finsert_char):
8774 (Ftranslate_region_internal, Fformat):
8775 Rename or remove local vars to avoid shadowing.
8776 (Ftranslate_region_internal): Mark var as initialized.
8777
8778 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8779 avoid shadowing.
8780
8781 * lisp.h (eassert): Check that the argument compiles, even if
8782 ENABLE_CHECKING is not defined.
8783
8784 * data.c (Findirect_variable): Name an expression, to avoid
8785 gcc -Wbad-function-cast warning.
8786 (default_value, arithcompare, arith_driver, arith_error): Now static.
8787 (store_symval_forwarding): Rename local to avoid shadowing.
8788 (Fmake_variable_buffer_local, Fmake_local_variable):
8789 Mark variables as initialized.
8790 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8791
8792 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8793 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8794 Rename locals to avoid shadowing.
8795 (mark_stack): Move local variables into the #ifdef region where
8796 they're used.
8797 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8798 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8799 needed otherwise.
8800 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8801 (GC_STRING_CHARS): Remove; not used.
8802 (Fmemory_limit): Cast sbrk's returned value to char *.
8803
8804 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8805 avoids undefined behavior in theory.
8806
8807 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8808
8809 Use functions, not macros, for up- and down-casing (Bug#8254).
8810 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8811 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8812 to use the following functions instead of these macros.
8813 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8814 EMACS_INT, since callers assume the returned value fits in int.
8815 (upcase1): Likewise, for UPCASE_TABLE.
8816 (uppercasep, lowercasep, upcase): New static inline functions.
8817 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8818 the race-condition problem in the old DOWNCASE.
8819
8820 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8821 Rename locals to avoid shadowing.
8822 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8823 (regex_compile, re_search_2, re_match_2_internal):
8824 Remove unused local vars.
8825 (FREE_VAR): Rewrite so as not to use empty "else",
8826 which gcc can warn about.
8827 (regex_compile, re_match_2_internal): Mark locals as initialized.
8828 (RETALLOC_IF): Define only if needed.
8829 (WORDCHAR_P): Likewise. This one is never needed, but is used
8830 only in a comment talking about a compiler bug, so put inside
8831 the #if 0 of that comment.
8832 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8833 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8834 Remove; unused.
8835
8836 * search.c (boyer_moore): Rename locals to avoid shadowing.
8837 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8838 (PREV_CHAR_BOUNDARY): Likewise.
8839
8840 * search.c (simple_search): Remove unused var.
8841
8842 * dired.c (compile_pattern): Move decl from here ...
8843 * lisp.h: ... to here, so that it can be checked.
8844 (struct re_registers): New forward decl.
8845
8846 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8847
8848 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8849 All uses changed.
8850 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8851 Rename locals to avoid shadowing.
8852 (Fvertical_motion): Mark locals as initialized.
8853
8854 * casefiddle.c (casify_object, casify_region): Now static.
8855 (casify_region): Mark local as initialized.
8856
8857 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8858
8859 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8860 New macros, so that the caller can use some names other than
8861 gcpro1, gcpro2, etc.
8862 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8863 of the new macros.
8864 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8865 argument, for consistency with GCPRO2_VAR, etc: it is now the
8866 prefix of the variable, not the variable itself. All uses
8867 changed.
8868 * dired.c (directory_files_internal, file_name_completion):
8869 Rename locals to avoid shadowing.
8870
8871 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8872 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8873 dired.c's scmp function, had undefined behavior.
8874 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8875 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8876 * buffer.h: ... to here, because these macros use current_buffer,
8877 and the new implementation with inline functions needs to have
8878 current_buffer in scope now, rather than later when the macros
8879 are used.
8880 (downcase, upcase1): New static inline functions.
8881 (DOWNCASE, UPCASE1): Reimplement using these functions.
8882 This avoids undefined behavior in expressions like
8883 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8884 from race conditions in accessing the global variables
8885 case_temp1 and case_temp2.
8886 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8887 * lisp.h (case_temp1, case_temp2): Remove their decls.
8888 * character.h (ASCII_CHAR_P): Move from here ...
8889 * lisp.h: ... to here, so that the inline functions mentioned
8890 above can use them.
8891
8892 * dired.c (directory_files_internal_unwind): Now static.
8893
8894 * fileio.c (file_name_as_directory, directory_file_name):
8895 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8896 Now static.
8897 (file_name_as_directory): Use const pointers when appropriate.
8898 (Fexpand_file_name): Likewise. In particular, newdir might
8899 point at constant storage, so make it a const pointer.
8900 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8901 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8902 signedness issues.
8903 (Fset_file_times, Finsert_file_contents, auto_save_error):
8904 Rename locals to avoid shadowing.
8905
8906 * minibuf.c (choose_minibuf_frame_1): Now static.
8907 (Ftry_completion, Fall_completions): Rename or remove locals
8908 to avoid shadowing.
8909
8910 * marker.c (bytepos_to_charpos): Remove; unused.
8911
8912 * lisp.h (verify_bytepos, count_markers): New decls,
8913 so that gcc does not warn that these functions aren't declared.
8914
8915 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8916 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8917 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8918 (copy_text): Remove unused local var.
8919
8920 * filelock.c (within_one_second): Now static.
8921 (lock_file_1): Rename local to avoid shadowing.
8922
8923 * buffer.c (fix_overlays_before): Mark locals as initialized.
8924 (fix_start_end_in_overlays): Likewise. This function should be
8925 simplified by using pointers-to-pointers, but that's a different
8926 matter.
8927 (switch_to_buffer_1): Now static.
8928 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8929 (report_overlay_modification): Rename locals to avoid shadowing.
8930
8931 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8932 Fix pointer signedness issue.
8933 (sys_subshell): Mark local as volatile if checking for lint,
8934 to suppress a gcc -Wclobbered warning that does not seem to be right.
8935 (MAXPATHLEN): Define only if needed.
8936
8937 * process.c (serial_open, serial_configure): Move decls from here ...
8938 * systty.h: ... to here, so that they can be checked.
8939
8940 * fns.c (get_random, seed_random): Move extern decls from here ...
8941 * lisp.h: ... to here, so that they can be checked.
8942
8943 * sysdep.c (reset_io): Now static.
8944 (wait_for_termination_signal): Remove; unused.
8945
8946 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8947 (copy_keymap_item, append_key, push_text_char_description):
8948 Now static.
8949 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8950 (DENSE_TABLE_SIZE): Remove; unused.
8951 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8952 (describe_map_tree):
8953 Rename locals to avoid shadowing.
8954
8955 * keyboard.c: Declare functions static if they are not used elsewhere.
8956 (echo_char, echo_dash, cmd_error, top_level_2):
8957 (poll_for_input, handle_async_input): Now static.
8958 (read_char, kbd_buffer_get_event, make_lispy_position):
8959 (make_lispy_event, make_lispy_movement, apply_modifiers):
8960 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8961 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8962 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8963 (read_key_sequence, read_char): Mark locals as initialized.
8964 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8965
8966 * keyboard.h (make_ctrl_char): New decl.
8967 (mark_kboards): Move decl here ...
8968 * alloc.c (mark_kboards): ... from here.
8969
8970 * lisp.h (force_auto_save_soon): New decl.
8971
8972 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8973 (DEFINE_DUMMY_FUNCTION): New macro.
8974 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8975 Use it.
8976 (main): Add casts to avoid warnings
8977 if GCC considers string literals to be constants.
8978
8979 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8980
8981 * dbusbind.c: Pointer signedness fixes.
8982 (xd_signature, xd_append_arg, xd_initialize):
8983 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8984 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8985 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8986 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8987
8988 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8989 if GCC considers string literals to be constants.
8990 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8991
8992 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8993
8994 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8995 (print_preprocess, print_object): New macro to fix last change.
8996
8997 * print.c (print_preprocess): Don't forget font objects.
8998
8999 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9000
9001 * emacs.c (USAGE3): Doc fixes.
9002
9003 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9004
9005 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9006 structure.
9007
9008 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9009
9010 * lisp.h (VWindow_system, Qfile_name_history):
9011 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9012 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9013 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9014
9015 * w32select.c: Don't #include "keyboard.h".
9016 (run_protected): Add extern declaration for waiting_for_input.
9017
9018 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9019 * w32console.c (detect_input_pending, read_input_pending)
9020 (encode_terminal_code):
9021 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9022 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9023 (w32_system_caret_y, Qfile_name_history):
9024 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9025 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9026 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9027 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9028 * w32proc.c (Qlocal, report_file_error):
9029 * w32term.c (Vwindow_system, updating_frame):
9030 * w32uniscribe.c (initialized, uniscribe_font_driver):
9031 Remove unneeded extern declarations.
9032
9033 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9034
9035 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9036
9037 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9038
9039 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9040 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9041 These macros can no longer be used for assignment.
9042
9043 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9044 Assign struct members directly, instead of using BUF_BEGV etc.
9045 (record_buffer_markers, fetch_buffer_markers): New functions for
9046 recording and fetching special buffer markers.
9047 (set_buffer_internal_1, set_buffer_temp): Use them.
9048
9049 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9050
9051 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9052
9053 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9054 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9055
9056 * xdisp.c (hscroll_window_tree):
9057 (reconsider_clip_changes): Use PT instead of BUF_PT.
9058
9059 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9060
9061 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9062 $(EMACS_ROOT)/lib/intprops.h.
9063
9064 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9065
9066 Fix more problems found by GCC 4.5.2's static checks.
9067
9068 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9069 to unsigned char * to avoid compiler diagnostic.
9070 (xg_free_frame_widgets): Make it clear that a local variable is
9071 needed only if USE_GTK_TOOLTIP.
9072 (gdk_window_get_screen): Make it clear that this macro is needed
9073 only if USE_GTK_TOOLTIP.
9074 (int_gtk_range_get_value): New function, which avoids a diagnostic
9075 from gcc -Wbad-function-cast.
9076 (xg_set_toolkit_scroll_bar_thumb): Use it.
9077 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9078 diagnostic from gcc -Wbad-function-cast.
9079 (get_utf8_string, xg_get_file_with_chooser):
9080 Rename locals to avoid shadowing.
9081 (create_dialog): Move locals to avoid shadowing.
9082
9083 * xgselect.c (xg_select): Remove unused var.
9084
9085 * image.c (four_corners_best): Mark locals as initialized.
9086 (gif_load): Initialize transparent_p to zero (Bug#8238).
9087 Mark another local as initialized.
9088 (my_png_error, my_error_exit): Mark with NO_RETURN.
9089
9090 * image.c (clear_image_cache): Now static.
9091 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9092 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9093 (x_edge_detection): Remove unnecessary cast that
9094 gcc -Wbad-function-cast diagnoses.
9095 (gif_load): Fix pointer signedness.
9096 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9097 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9098
9099 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9100
9101 Improve quality of tests for time stamp overflow.
9102 For example, without this patch (encode-time 0 0 0 1 1
9103 1152921504606846976) returns the obviously-bogus value (-948597
9104 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9105 reports time overflow. See
9106 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9107 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9108 * editfns.c: Include limits.h and intprops.h.
9109 (TIME_T_MIN, TIME_T_MAX): New macros.
9110 (time_overflow): Move earlier, to before first use.
9111 (hi_time, lo_time): New functions, for an accurate test for
9112 out-of-range times.
9113 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9114 (Fget_internal_run_time): Don't assume time_t fits in int.
9115 (make_time): Use list2 instead of Fcons twice.
9116 (Fdecode_time): More accurate test for out-of-range times.
9117 (check_tm_member): New function.
9118 (Fencode_time): Use it, to test for out-of-range times.
9119 (lisp_time_argument): Don't rely on undefined left-shift and
9120 right-shift behavior when checking for time stamp overflow.
9121
9122 * editfns.c (time_overflow): New function, refactoring common code.
9123 (Fformat_time_string, Fdecode_time, Fencode_time):
9124 (Fcurrent_time_string): Use it.
9125
9126 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9127 * dired.c (make_time): Move to ...
9128 * editfns.c (make_time): ... here.
9129 * systime.h: Note the move.
9130
9131 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9132
9133 * fringe.c (update_window_fringes): Remove unused variables.
9134
9135 * unexmacosx.c (copy_data_segment): Also copy __got section.
9136 (Bug#8223)
9137
9138 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9139
9140 * termcap.c [MSDOS]: Include "msdos.h".
9141 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9142 Constify `char *' arguments and their references according to
9143 prototypes in tparam.h.
9144
9145 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9146
9147 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9148 Adapt all references accordingly.
9149
9150 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9151
9152 2011-03-11 Tom Tromey <tromey@redhat.com>
9153
9154 * buffer.c (syms_of_buffer): Remove obsolete comment.
9155
9156 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9157
9158 * termhooks.h (encode_terminal_code): Declare prototype.
9159
9160 * msdos.c (encode_terminal_code): Don't declare prototype.
9161
9162 * term.c (encode_terminal_code): Now external again, used by
9163 w32console.c and msdos.c.
9164
9165 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9166 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9167
9168 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9169
9170 Fix some minor problems found by GCC 4.5.2's static checks.
9171
9172 * fringe.c (update_window_fringes): Mark locals as initialized
9173 (Bug#8227).
9174 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9175
9176 * alloc.c (mark_fringe_data): Move decl from here ...
9177 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9178 to check its interface.
9179 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9180
9181 * fontset.c (free_realized_fontset): Now static.
9182 (Fset_fontset_font): Rename local to avoid shadowing.
9183 (fontset_font): Mark local as initialized.
9184 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9185
9186 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9187
9188 * xselect.c (x_disown_buffer_selections): Remove; not used.
9189 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9190 (x_own_selection, Fx_disown_selection_internal): Rename locals
9191 to avoid shadowing.
9192 (x_handle_dnd_message): Remove local to avoid shadowing.
9193
9194 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9195 so that the caller can use some name other than gcpro1.
9196 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9197 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9198 (Fx_backspace_delete_keys_p):
9199 Use them to avoid shadowing, and rename vars to avoid shadowing.
9200 (x_decode_color, x_set_name, x_window): Now static.
9201 (Fx_create_frame): Add braces to silence GCC warning.
9202 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9203 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9204 Remove unused locals.
9205 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9206 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9207 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9208 macros.
9209
9210 * xterm.h (x_mouse_leave): New decl.
9211
9212 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9213 Remove unused functions.
9214 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9215 (x_calc_absolute_position): Now static.
9216 (XTread_socket): Don't define label "out" unless it's used.
9217 Don't declare local "event" unless it's used.
9218 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9219 unless they are used.
9220 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9221 (x_fatal_error_signal): Remove; not used.
9222 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9223 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9224 (x_error_catcher, x_connection_closed, x_error_handler):
9225 (x_error_quitter, xembed_send_message, x_iconify_frame):
9226 (my_log_handler): Rename locals to avoid shadowing.
9227 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9228 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9229
9230 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9231 Rename or move locals to avoid shadowing.
9232 (tty_defined_color, merge_face_heights): Now static.
9233 (free_realized_faces_for_fontset): Remove; not used.
9234 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9235 does not deduce is never used uninitialized.
9236 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9237 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9238
9239 * terminal.c (store_terminal_param): Now static.
9240
9241 * xmenu.c (menu_highlight_callback): Now static.
9242 (set_frame_menubar): Remove unused local.
9243 (xmenu_show): Rename parameter to avoid shadowing.
9244 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9245 since they might point to immutable storage.
9246 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9247 since it's unused otherwise.
9248
9249 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9250 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9251 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9252 avoids a gcc -Wuninitialized diagnostic.
9253 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9254 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9255 does not deduce are never used uninitialized.
9256
9257 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9258
9259 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9260 * window.c (window_loop, size_window):
9261 (run_window_configuration_change_hook, enlarge_window): Likewise.
9262
9263 * window.c (display_buffer): Now static.
9264 (size_window): Mark variables that gcc -Wuninitialized
9265 does not deduce are never used uninitialized.
9266 * window.h (check_all_windows): New decl, to forestall
9267 gcc -Wmissing-prototypes diagnostic.
9268 * dispextern.h (bidi_dump_cached_states): Likewise.
9269
9270 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9271 shadowing.
9272 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9273 Include <limits.h>.
9274 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9275 and to avoid gcc -Wuninitialized warning.
9276 (load_charset_map): Mark variables that gcc -Wuninitialized
9277 does not deduce are never used uninitialized.
9278 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9279
9280 * coding.c (coding_set_source, coding_set_destination):
9281 Use "else { /* comment */ }" rather than "else /* comment */;"
9282 for clarity, and to avoid gcc -Wempty-body warning.
9283 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9284 a block, when the outer 'i' will do.
9285 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9286 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9287 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9288 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9289 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9290 Rename locals to avoid shadowing.
9291 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9292 * coding.c (emacs_mule_char, encode_invocation_designation):
9293 Now static, since they're not used elsewhere.
9294 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9295 (decode_coding_object, encode_coding_object, detect_coding_system):
9296 (decode_coding_emacs_mule): Mark variables that gcc
9297 -Wuninitialized does not deduce are never used uninitialized.
9298 (detect_coding_iso_2022): Initialize a local variable that might
9299 be used uninitialized. Leave a FIXME because it's not clear that
9300 this initialization is needed. (Bug#8211)
9301 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9302 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9303 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9304 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9305 Remove unused macros.
9306
9307 * category.c (hash_get_category_set): Remove unused local var.
9308 (copy_category_table): Now static, since it's not used elsewhere.
9309 * character.c (string_count_byte8): Likewise.
9310
9311 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9312 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9313
9314 * chartab.c (copy_sub_char_table): Now static, since it's not used
9315 elsewhere.
9316 (sub_char_table_ref_and_range, char_table_ref_and_range):
9317 Rename locals to avoid shadowing.
9318 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9319
9320 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9321 (BIDI_BOB): Remove unused macro.
9322
9323 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9324 deduce are never used uninitialized.
9325 * term.c (encode_terminal_code): Likewise.
9326
9327 * term.c (encode_terminal_code): Now static. Remove unused local.
9328
9329 * tparam.h: New file.
9330 * term.c, tparam.h: Include it.
9331 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9332 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9333 Move these decls to tparam.h, and make them agree with what
9334 is actually in tparam.c. The previous trick of using incompatible
9335 decls in different modules does not conform to the C standard.
9336 All callers of tparam changed to use tparam's actual API.
9337 * tparam.c (tparam1, tparam, tgoto):
9338 Use const pointers where appropriate.
9339
9340 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9341 * cm.h (struct cm): Likewise.
9342 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9343 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9344 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9345 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9346 (turn_on_face, init_tty): Likewise.
9347 * termchar.h (struct tty_display_info): Likewise.
9348
9349 * term.c (term_mouse_position): Rename local to avoid shadowing.
9350
9351 * alloc.c (mark_ttys): Move decl from here ...
9352 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9353
9354 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9355
9356 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9357
9358 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9359
9360 * search.c (compile_pattern_1): Remove argument regp, unused since
9361 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9362 (compile_pattern): Don't pass it.
9363
9364 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9365
9366 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9367 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9368 for ! HAVE_GTK3.
9369 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9370
9371 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9372
9373 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9374 gdk_window_get_screen, gdk_window_get_geometry,
9375 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9376 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9377 (xg_get_pixbuf_from_pixmap): New function.
9378 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9379 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9380 Call xg_get_pixbuf_from_pixmap instead of
9381 gdk_pixbuf_get_from_drawable.
9382 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9383 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9384 (xg_check_special_colors): Use GtkStyleContext and its functions
9385 for HAVE_GTK3.
9386 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9387 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9388 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9389 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9390 Call gtk_widget_get_preferred_size.
9391 (xg_frame_resized): gdk_window_get_geometry only takes 5
9392 parameters.
9393 (xg_win_to_widget, xg_event_is_for_menubar):
9394 Call gdk_x11_window_lookup_for_display.
9395 (xg_set_widget_bg): New function.
9396 (delete_cb): New function.
9397 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9398 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9399 (xg_set_background_color): Call xg_set_widget_bg.
9400 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9401 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9402 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9403 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9404 if ! HAVE_GTK3.
9405 (update_frame_tool_bar): Call gtk_widget_hide.
9406 (xg_initialize): Use GDK_KEY_g.
9407
9408 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9409 if ! HAVE_GTK3
9410 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9411
9412 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9413 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9414 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9415
9416 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9417
9418 * w32xfns.c (select_palette): Check success of RealizePalette against
9419 GDI_ERROR, not zero.
9420
9421 See ChangeLog.11 for earlier changes.
9422
9423 ;; Local Variables:
9424 ;; coding: utf-8
9425 ;; End:
9426
9427 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9428
9429 This file is part of GNU Emacs.
9430
9431 GNU Emacs is free software: you can redistribute it and/or modify
9432 it under the terms of the GNU General Public License as published by
9433 the Free Software Foundation, either version 3 of the License, or
9434 (at your option) any later version.
9435
9436 GNU Emacs is distributed in the hope that it will be useful,
9437 but WITHOUT ANY WARRANTY; without even the implied warranty of
9438 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9439 GNU General Public License for more details.
9440
9441 You should have received a copy of the GNU General Public License
9442 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.