1 2011-08-24 Paul Eggert <eggert@cs.ucla.edu>
3 Integer and memory overflow issues (Bug#9196).
5 * doc.c (get_doc_string): Rework so that
6 get_doc_string_buffer_size is the actual buffer size, rather than
7 being 1 less than the actual buffer size; this makes xpalloc more
10 * image.c (x_allocate_bitmap_record, cache_image):
11 * xselect.c (Fx_register_dnd_atom):
12 Simplify previous changes by using xpalloc.
14 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
15 since either will do and ptrdiff_t is convenient with xpalloc.
17 * charset.c (charset_table_size)
18 (struct charset_sort_data.priority): Now ptrdiff_t.
19 (charset_compare): Don't overflow if priorities differ greatly.
20 (Fsort_charsets): Don't assume list length fits in int.
21 Check for size-calculation overflow when allocating sort data.
22 (syms_of_charset): Allocate an initial charset table that is
23 just under 64 KiB, to avoid problems with glibc malloc and mmap.
25 * cmds.c (internal_self_insert): Check for size-calculation overflow.
27 * composite.h (struct composition.glyph_len): Now int, not unsigned.
28 The actual value is always <= INT_MAX, and leaving it unsigned made
29 overflow checking harder.
31 * dispextern.h (struct glyph_matrix.rows_allocated)
32 (struct face_cache.size): Now ptrdiff_t, for convenience in use
33 with xpalloc. The values are still always <= INT_MAX.
35 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
37 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
38 (SAFE_NALLOCA): New macro.
40 * region-cache.c (struct boundary.pos, find_cache_boundary)
41 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
42 (set_cache_region, invalidate_region_cache)
43 (revalidate_region_cache, know_region_cache, region_cache_forward)
44 (region_cache_backward, pp_cache):
45 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
46 so that ptrdiff_t * can be passed to xpalloc.
47 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
48 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
49 (pp_cache): Don't assume cache_len fits in int.
50 * region-cache.h: Adjust extern decls to match.
52 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
53 EMACS_INT, since either will do, for xpalloc.
55 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
56 (xnmalloc, xnrealloc, xpalloc): New functions.
58 * bidi.c (bidi_shelve_header_size): New constant.
59 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
60 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
62 * bidi.c (bidi_cache_shrink):
63 * buffer.c (overlays_at, overlays_in, record_overlay_string)
65 Don't update size of array until after memory allocation succeeds,
66 because xmalloc/xrealloc may not return.
67 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
68 now that we have proper integer overflow checking.
69 (record_overlay_string, overlay_strings): Catch overflows when
70 calculating size of overlay_str_buf.
72 * callproc.c (Fcall_process): Check for size overflow when
73 calculating size of args2.
74 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
75 Normally we prefer signed values, but sticking with ptrdiff_t would
76 require adding more-complicated checks.
78 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
79 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
80 Redo buffer-overflow calculations to avoid integer overflow.
81 Add a FIXME comment where memory seems to be over-allocated.
83 * character.c (Fstring): Check for size-calculation overflow.
85 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
86 unnecessary integer overflow. Check for size overflow.
87 (encode_coding_object): Don't update size until xmalloc succeeds.
89 * composite.c (get_composition_id): Check for overflow in glyph
92 Integer and memory overflow fixes for display code.
93 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
94 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
95 (scrolling_window): Check for overflow in size calculations.
96 (line_draw_cost, realloc_glyph_pool, add_row_entry):
97 Don't assume glyph table len fits in int.
98 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
99 (row_table_size): Now ptrdiff_t, not int.
100 (scrolling_window): Avoid overflow in size calculations.
101 Don't update size until allocation succeeds.
102 * fns.c (concat): Check for overflow in size calculations.
103 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
104 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
105 (NEXT_ALMOST_PRIME_LIMIT): New constant.
107 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
108 (get_doc_string): Check for size calculation overflow.
109 Don't update size until allocation succeeds.
110 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
111 EMACS_INT, where ptrdiff_t will do.
112 (Fsubstitute_command_keys): Check for string overflow.
114 * editfns.c (set_time_zone_rule): Don't assume environment length
116 (message_length): Now ptrdiff_t, not int.
117 (Fmessage_box): Don't update size until allocation succeeds.
118 Don't assume message length fits in int.
119 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
121 * emacs.c (main): Do not reallocate argv, since there is a null at
122 the end that can be overwritten, and this way there's no need to
123 worry about size-calculation overflow.
124 (sort_args): Check for size-calculation overflow.
126 * eval.c (init_eval_once, grow_specpdl): Don't update size until
128 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
130 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
131 (x_set_scroll_bar_width, x_figure_window_size):
132 Check for integer overflow.
133 (x_set_alpha): Do not assume XINT fits in int.
135 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
136 This is for the members text_lines, text_cols, total_lines, total_cols,
137 where the system imposes an 'int' limit.
139 * fringe.c (Fdefine_fringe_bitmap):
140 Don't update size until alloc works.
142 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
143 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
145 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
146 Check for size-calculation overflow.
147 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
148 do, as we prefer signed integers.
149 (id_to_widget.max_size, id_to_widget.used)
150 (xg_store_widget_in_map, xg_remove_widget_from_map)
151 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
152 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
153 Use and return ptrdiff_t, not int.
154 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
155 * gtkutil.h: Change prototypes to match the above.
157 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
158 are duplicate now that they've been promoted to lisp.h.
159 (x_allocate_bitmap_record, x_alloc_image_color)
160 (make_image_cache, cache_image, xpm_load):
161 Don't update size until alloc is done.
162 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
164 Check for size calculation overflow.
165 (ct_colors_allocated_max): New constant.
166 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
169 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
170 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
171 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
172 Use ptrdiff_t, not int, to count maps.
173 (read_char_minibuf_menu_prompt): Check for overflow in size
174 calculations. Don't update size until allocation succeeds. Redo
175 calculations to avoid overflow.
176 * keyboard.h: Change prototypes to match the above.
178 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
180 (current_minor_maps): Check for size calculation overflow.
181 * keymap.h: Change prototypes to match the above.
183 * lread.c (read1, init_obarray): Don't update size until alloc done.
185 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
186 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
188 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
189 Now ptrdiff_t, not int.
190 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
191 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
193 * process.c (Fnetwork_interface_list): Check for overflow
196 * region-cache.c (move_cache_gap): Check for size calculation overflow.
198 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
199 overflow. Don't bother calling xmalloc when xrealloc will do.
201 * search.c (Freplace_match): Check for size calculation overflow.
202 (Fset_match_data): Don't assume list lengths fit in 'int'.
204 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
205 for command line length. Do not attempt to address one before the
206 beginning of an array, as that's not portable.
208 * term.c (max_frame_lines): Remove; unused.
209 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
211 (encode_terminal_code, calculate_costs): Check for size
212 calculation overflow.
213 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
214 table lengths and related sizes. Don't update size until alloc
215 done. Redo calculations to avoid overflow.
216 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
218 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
219 subtracting pointers.
220 (gobble_line): Check for overflow more carefully. Don't update size
223 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
224 Don't update size until alloc done.
225 Redo size calculations to avoid overflow.
226 Check for size calculation overflow.
227 (main) [DEBUG]: Fix typo in invoking tparam1.
229 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
230 Use ptrdiff_t, not int, for sizes.
231 (store_mode_line_noprop_char): Don't update size until alloc done.
233 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
234 Use ptrdiff_t, not int, for sizes.
235 (Finternal_make_lisp_face, cache_face):
236 Check for size calculation overflow.
237 (cache_face): Treat size calculation overflows as if they were
238 memory exhaustion (the usual treatment), rather than aborting.
240 * xfns.c (x_encode_text, x_set_name_internal)
241 (Fx_change_window_property): Use ptrdiff_t, not int, to count
242 sizes, since they can exceed INT_MAX in size. Check for size
243 calculation overflow.
245 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
246 (xg_select): Check for size calculation overflow.
247 Don't update size until alloc done.
249 * xrdb.c (get_environ_db): Don't assume path length fits in int,
250 as sprintf is limited to int lengths.
252 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
253 (X_LONG_MIN): New macros.
254 Use them to make the following changes clearer.
255 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
256 This change doesn't affect the value now, but it may help remind
257 future maintainers not to raise the value too much later.
258 (SELECTION_QUANTUM): Remove, replacing with ...
259 (selection_quantum): ... new function, which avoids overflow.
261 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
262 assumption that selection length fits in 'int'.
263 (x_reply_selection_request, x_handle_selection_request)
264 (x_get_window_property, receive_incremental_selection)
265 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
266 (lisp_data_to_selection_data, clean_local_selection_data):
267 Use ptrdiff_t, not int, to record length of selection.
268 (x_reply_selection_request, x_get_window_property)
269 (receive_incremental_selection, x_property_data_to_lisp):
270 Redo calculations to avoid overflow.
271 (x_reply_selection_request): When sending hint, ceiling it at
272 X_LONG_MAX rather than relying on wraparound overflow to send
274 (x_get_window_property, receive_incremental_selection)
275 (lisp_data_to_selection_data, x_property_data_to_lisp):
276 Check for size-calculation overflow.
277 (x_get_window_property, receive_incremental_selection)
278 (lisp_data_to_selection_data, Fx_register_dnd_atom):
279 Don't store size until memory allocation succeeds.
280 (x_get_window_property): Plug memory leak on memory exhaustion.
281 Don't double-block input; malloc is safe here. Don't assume 2**34
282 - 4 fits in unsigned long. Add an xassert to check
283 XGetWindowProperty overflow. Be more careful about overflow
284 calculations, and distinguish size from memory overflow better.
285 (receive_incremental_selection): When tracing, don't assume
286 unsigned int is less than INT_MAX.
287 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
288 harmful) conversions of unsigned short to int.
289 (lisp_data_to_selection_data): Don't assume that integers
290 in the range -65535 through -1 fit in an X unsigned short.
291 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
292 result parameters unless successful. Rely on cons_to_unsigned
293 to report problems with elements; the old code wasn't right anyway.
294 (x_check_property_data): Check for int overflow; we cannot use
295 a wider type due to X limits.
296 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
298 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
300 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
301 (x_term_init): Check for size calculation overflow.
302 (x_color_cells): Don't store size until memory allocation succeeds.
303 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
304 Don't assume alloca size is less than MAX_ALLOCA.
305 (x_term_init): Don't assume length fits in int (sprintf is limited
308 Use ptrdiff_t for composition IDs.
309 * character.c (lisp_string_width):
310 * composite.c (composition_table_size, n_compositions)
311 (get_composition_id, composition_gstring_from_id):
312 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
313 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
314 * window.c (Frecenter):
315 Use ptrdiff_t, not int, for composition IDs.
316 * composite.c (get_composition_id): Check for integer overflow.
317 * composite.h: Adjust prototypes to match the above changes.
319 Use ptrdiff_t for hash table indexes.
320 * category.c (hash_get_category_set):
321 * ccl.c (ccl_driver):
322 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
323 * coding.c (coding_system_charset_list, detect_coding_system):
324 * coding.h (struct coding_system.id):
325 * composite.c (get_composition_id, gstring_lookup_cache):
326 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
327 * image.c (xpm_get_color_table_h):
328 * lisp.h (hash_lookup, hash_put):
329 * minibuf.c (Ftest_completion):
330 Use ptrdiff_t for hash table indexes, not int (which is too
331 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
332 32-bit --with-wide-int hosts).
334 * charset.c (Fdefine_charset_internal): Check for integer overflow.
335 Add a FIXME comment about memory leaks.
336 (syms_of_charset): Don't assume xmalloc returns.
338 Don't assume that stated character widths fit in int.
339 * character.c (Fchar_width, c_string_width, lisp_string_width):
340 * character.h (CHAR_WIDTH):
341 * indent.c (MULTIBYTE_BYTES_WIDTH):
342 Use sanitize_char_width to avoid undefined and/or bad behavior
343 with outlandish widths.
344 * character.h (sanitize_tab_width): Renamed from sanitize_width,
345 now that we have two such functions. All uses changed.
346 (sanitize_char_width): New inline function.
348 Don't assume that tab-width fits in int.
349 * character.h (sanitize_width): New inline function.
350 (SANE_TAB_WIDTH): New macro.
351 (ASCII_CHAR_WIDTH): Use it.
352 * indent.c (sane_tab_width): Remove. All uses replaced by
353 SANE_TAB_WIDTH (current_buffer).
354 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
356 * fileio.c: Integer overflow issues with file modes.
357 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
359 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
360 Remove unreachable code.
361 (read_hex, load_charset_map_from_file): Check for integer overflow.
363 * xterm.c: don't go over XClientMessageEvent limit
364 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
365 (x_send_scroll_bar_event): Likewise. Check that the size does not
366 exceed limits imposed by XClientMessageEvent, as well as the usual
367 ptrdiff_t and size_t limits.
369 * keyboard.c: Overflow, signedness and related fixes.
370 (make_lispy_movement): Use same integer type in forward decl
371 that is used in the definition.
372 (read_key_sequence, keyremap_step):
373 Change bufsize argument back to int, undoing my 2011-03-30 change.
374 We prefer signed types, and int is wide enough here.
375 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
376 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
377 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
378 length, not size_t. Use ptrdiff_t for index, not int.
379 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
380 possibility of integer overflow.
382 Overflow, signedness and related fixes for images.
384 * dispextern.h (struct it.stack[0].u.image.image_id)
385 (struct_it.image_id, struct image.id, struct image_cache.size)
386 (struct image_cache.used, struct image_cache.ref_count):
387 * gtkutil.c (update_frame_tool_bar):
388 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
389 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
390 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
391 * nsmenu.m (update_frame_tool_bar):
392 * xdisp.c (calc_pixel_width_or_height):
393 * xfns.c (image_cache_refcount):
394 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
395 on typical 64-bit hosts.
397 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
398 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
399 Omit unnecessary casts to int.
400 (parse_image_spec): Check that integers fall into 'int' range
401 when the callers expect that.
402 (image_ascent): Redo ascent calculation to avoid int overflow.
403 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
404 (lookup_image): Remove unnecessary tests.
405 (xbm_image_p): Locals are now of int, not EMACS_INT,
406 since parse_image_check makes sure they fit into int.
407 (png_load, gif_load, svg_load_image):
408 Prefer int to unsigned where either will do.
409 (tiff_handler): New function, combining the cores of the
410 old tiff_error_handler and tiff_warning_handler. This
411 function is rewritten to use vsnprintf and thereby avoid
412 stack buffer overflows. It uses only the features of vsnprintf
413 that are common to both POSIX and native Microsoft.
414 (tiff_error_handler, tiff_warning_handler): Use it.
415 (tiff_load, gif_load, imagemagick_load_image):
416 Don't assume :index value fits in 'int'.
417 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
418 (imagemagick_load_image): Check that crop parameters fit into
419 the integer types that MagickCropImage accepts. Don't assume
420 Vimagemagick_render_type has a nonnegative value. Don't assume
421 size_t fits in 'long'.
422 (gs_load): Use printmax_t to print the widest integers possible.
423 Check for integer overflow when computing image height and width.
425 2011-08-24 Eli Zaretskii <eliz@gnu.org>
427 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
428 buffers, return left-to-right.
429 (set_cursor_from_row): Consider candidate row a win if its glyph
430 represents a newline and point is on that newline. Fixes cursor
431 positioning on the newline at EOL of R2L text within L2R
432 paragraph, and vice versa.
433 (try_cursor_movement): Check continued rows, in addition to
434 continuation rows. Fixes unwarranted scroll when point enters a
435 continued line of R2L text within an L2R paragraph, or vice versa.
436 (cursor_row_p): Consider the case of point being equal to
437 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
438 from the end of a short line to the beginning of a continued line
439 of R2L text within L2R paragraph.
440 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
443 * bidi.c (bidi_check_type): Use xassert.
444 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
447 2011-08-23 Eli Zaretskii <eliz@gnu.org>
449 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
452 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
454 * nsfont.m (ns_otf_to_script): Fix typo.
456 2011-08-22 Kenichi Handa <handa@m17n.org>
458 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
459 extra slot even if the purpose is char-code-property-table.
461 2011-08-23 Eli Zaretskii <eliz@gnu.org>
463 * xdisp.c (redisplay_window): When computing centering_position,
464 account for the height of the header line. (Bug#8874)
466 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
467 instead of CHAR_TO_BYTE. Fixes a crash when a completion
468 candidate is selected by the mouse, and that candidate has a
469 composed character under the mouse.
471 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
472 coordinates reported by pos-visible-in-window-p for a composed
473 character in column zero.
475 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
477 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
479 2011-08-22 Eli Zaretskii <eliz@gnu.org>
481 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
482 consider it a hit if to_charpos is anywhere in the range of the
483 composed buffer positions.
485 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
487 * image.c (gif_load): Don't assume that each subimage has the same
488 dimensions as the base image. Handle disposal method that is
489 "undefined" by the gif spec (Bug#9335).
491 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
493 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
494 (Fcondition_case): Document `debug' symbol in error handler.
496 2011-08-19 Eli Zaretskii <eliz@gnu.org>
498 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
499 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
500 from an Org mode buffer to a Speedbar frame.
502 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
503 a composition, take its buffer position from IT->cmp_it.charpos.
504 Fixes cursor positioning at the beginning of a line that begins
505 with a composed character.
507 2011-08-18 Eli Zaretskii <eliz@gnu.org>
509 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
510 character bidirectional type, use STRONG_L instead. Fixes crashes
511 in a buffer produced by `describe-categories'.
513 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
514 members before the level stack, so they would be saved and
515 restored when copying iterator state. Fixes incorrect reordering
516 around TABs covered by display properties.
518 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
520 * process.c (Fnetwork_interface_list): Correctly determine buffer
523 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
525 * eval.c (internal_condition_case, internal_condition_case_1)
526 (internal_condition_case_2, internal_condition_case_n):
527 Remove unnecessary aborts (Bug#9081).
529 2011-08-17 Eli Zaretskii <eliz@gnu.org>
531 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
532 has no `load' handler, try opening the file locally. (Bug#9311)
534 2011-08-16 Ken Brown <kbrown@cornell.edu>
536 * gmalloc.c: Expand comment.
538 2011-08-16 Eli Zaretskii <eliz@gnu.org>
540 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
541 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
543 2011-08-16 Ken Brown <kbrown@cornell.edu>
545 Fix memory allocation problems in Cygwin build (Bug#9273).
547 * unexcw.c ( __malloc_initialized): Declare external variable.
548 (fixup_executable): Force the dumped emacs to reinitialize malloc.
550 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
552 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
554 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
556 [CYGWIN] (special_realloc): New function.
557 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
558 requests to realloc storage in the static heap.
560 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
562 * bidi.c (bidi_initialize): Remove unused local.
564 2011-08-15 Eli Zaretskii <eliz@gnu.org>
566 * biditype.h: File removed.
568 * bidimirror.h: File removed.
570 * deps.mk (bidi.o): Remove biditype.h and
573 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
576 * dispextern.h: Fix a typo in the comment to bidi_type_t.
578 * chartab.c: Improve commentary for the uniprop_table API.
580 * bidi.c (bidi_paragraph_init): Support zero value of
581 bidi_ignore_explicit_marks_for_paragraph_level.
582 (bidi_initialize): Use uniprop_table instead of including
583 biditype.h and bidimirror.h.
585 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
586 coordinates of the iterator when restoring from ppos_it.
589 2011-08-14 Kenichi Handa <handa@m17n.org>
591 * process.c (create_process): Call setup_process_coding_systems
592 after the pid of the process is set to -1 (Bug#8162).
594 2011-08-14 Eli Zaretskii <eliz@gnu.org>
596 * xdisp.c (move_it_in_display_line_to): Don't invoke
597 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
598 ppos_it. Fixes vertical cursor motion when line beginning is
599 covered by an image. (Bug#9296)
601 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
603 * nsterm.h (ns_run_ascript): Declare.
604 (NSAPP_DATA2_RUNASSCRIPT): Define.
606 * nsfns.m (as_script, as_result, as_status): New static variables.
607 (ns_run_ascript): New function.
608 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
609 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
610 the event loop. Get status from as_status (Bug#7276).
612 * nsterm.m (sendEvent): If event is NSApplicationDefined and
613 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
614 the event loop (Bug#7276).
616 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
618 * gnutls.c (QCgnutls_bootprop_priority)
619 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
620 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
621 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
622 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
623 (QCgnutls_bootprop_verify_hostname_error)
624 (QCgnutls_bootprop_callbacks_verify): Rename from
625 Qgnutls_bootprop_..., all uses changed.
627 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
630 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
632 * xfaces.c (Qframe_set_background_mode): Now static.
633 * dispextern.h (Qframe_set_background_mode): Remove decl.
635 * process.c (Fnetwork_interface_info): Declare local only if needed.
637 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
639 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
640 (Fnetwork_interface_list): Allocate in increments of bytes instead
641 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
642 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
644 (struct ifflag_def): notrailers is smart on OSX.
645 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
646 Get hardware address with getifaddrs if available.
648 2011-08-12 Eli Zaretskii <eliz@gnu.org>
650 * xdisp.c (iterate_out_of_display_property): xassert that
651 IT->position is set to within IT->object's boundaries. Break from
652 the loop as soon as EOB is reached; avoids infloops in redisplay
653 when IT->position is set up wrongly due to some bug.
654 Set IT->current to match the bidi iterator unconditionally.
655 (push_display_prop): Allow GET_FROM_STRING as IT->method on
656 entry. Force push_it to save on the stack the current
657 buffer/string position, to be restored by pop_it. Fix flags in
658 the iterator structure wrt the object coming from a display
659 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
660 properties. (Bug#9284)
662 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
664 * fontset.c (fontset_get_font_group): Add proper type checks.
667 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
669 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
670 and LC_VERSION_MIN_MACOSX.
671 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
672 (dump_it) [LC_FUNCTION_STARTS]: Use it.
674 2011-08-08 Eli Zaretskii <eliz@gnu.org>
676 * xdisp.c (forward_to_next_line_start): Allow to use the
677 no-display-properties-and-no-overlays under bidi display.
678 Set disp_pos in the bidi iterator to avoid searches for display
679 properties and overlays.
681 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
683 * editfns.c (Fset_time_zone_rule): Document relationship with the
686 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
687 the font entity extracted from the cache (Bug#8109).
689 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
691 * composite.c (autocmp_chars): Don't reset point. That is done by
692 restore_point_unwind (Bug#5984).
694 2011-08-07 Juri Linkov <juri@jurta.org>
696 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
697 to show the arg `TIME' instead of `TIMEVAL'.
699 2011-08-06 Eli Zaretskii <eliz@gnu.org>
701 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
702 display property strides EOL and includes a newline, as in
703 longlines-mode. (Bug#9254)
704 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
705 word-wrap under bidirectional display. (Bug#9224)
707 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
708 is non-zero, even if the data buffer is NULL. Fixes a crash in
709 vertical-motion with longlines-mode. (Bug#9254)
711 2011-08-05 Eli Zaretskii <eliz@gnu.org>
713 * bidi.c <bidi_cache_total_alloc>: Now static.
714 (bidi_initialize): Initialize bidi_cache_total_alloc.
716 * xdisp.c (display_line): Release buffer allocated for shelved bidi
719 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
720 amount allocated this far in `bidi_cache_total_alloc'.
721 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
722 non-zero, only free the data buffer without restoring the cache
723 contents. All callers changed.
725 * dispextern.h (bidi_unshelve_cache): Update prototype.
727 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
728 (move_it_in_display_line, move_it_to)
729 (move_it_vertically_backward, move_it_by_lines): Replace the call
730 to xfree to an equivalent call to bidi_unshelve_cache.
731 (move_it_in_display_line_to): Fix logic of returning
732 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
734 2011-08-05 Eli Zaretskii <eliz@gnu.org>
736 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
737 came from a string character with a `cursor' property. (Bug#9229)
739 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
741 * Makefile.in (LIB_PTHREAD): New variable.
742 (LIBES): Add LIB_PTHREAD (Bug#9216).
744 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
745 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
747 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
749 * regex.c (re_iswctype): Remove some redundant boolean
752 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
754 * xterm.c (x_find_topmost_parent): New function.
755 (x_set_frame_alpha): Find topmost parent window with
756 x_find_topmost_parent and set the property there also (bug#9181).
757 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
759 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
761 * callproc.c (Fcall_process): Avoid vfork clobbering
762 the local vars buffer, coding_systems, current_dir.
764 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
766 * keymap.c (Fmake_composed_keymap): Move to subr.el.
768 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
770 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
771 so that it is not optimized away.
773 * xdisp.c (compute_display_string_pos): Remove unused local.
775 2011-08-02 Eli Zaretskii <eliz@gnu.org>
777 Fix slow cursor motion and scrolling in large buffers with
778 selective display, like Org Mode buffers. (Bug#9218)
780 * dispextern.h (struct bidi_it): New member disp_prop_p.
782 * xdisp.c: Remove one-slot cache of display string positions.
783 (compute_display_string_pos): Accept an additional argument
784 DISP_PROP_P; callers changed. Scan at most 5K characters forward
785 for a display string or property. If found, set DISP_PROP_P
788 * bidi.c (bidi_fetch_char): Accept an additional argument
789 DISP_PROP_P, and pass it to compute_display_string_pos.
790 Only handle text covered by a display string if DISP_PROP_P is returned
791 non-zero. All callers of bidi_fetch_char changed.
793 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
795 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
797 2010-12-03 Don March <don@ohspite.net>
799 * keymap.c (Fdefine_key): Fix non-prefix key error message when
800 last character M-[char] is translated to ESC [char] (bug#7541).
802 2011-08-02 Kenichi Handa <handa@m17n.org>
804 * lisp.h (uniprop_table): Extern it.
806 * chartab.c (uniprop_table): Make it non-static.
808 2011-08-01 Eli Zaretskii <eliz@gnu.org>
810 * xdisp.c (forward_to_next_line_start): Accept additional argument
811 BIDI_IT_PREV, and store into it the state of the bidi iterator had
813 (reseat_at_next_visible_line_start): Use the bidi iterator state
814 returned by forward_to_next_line_start to restore the state of
815 it->bidi_it after backing up to previous newline. (Bug#9212)
817 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
819 * regex.c (re_comp): Protoize.
820 (re_exec): Fix return type.
821 (regexec): Fix type of `ret'. (Bug#9203)
823 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
825 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
826 This is needed if max-image-size is a floating-point number.
828 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
830 * print.c (print_object): Print empty symbol as ##.
832 * lread.c (read1): Read ## as empty symbol.
834 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
836 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
837 setting frame foreground color (Bug#9175).
838 (x_set_background_color): Likewise.
840 * nsmenu.m (-setText): Size tooltip dimensions precisely to
842 (EmacsTooltip -init): Remove bezels and add shadows to
845 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
846 or scroll bar (Bug#8470).
848 * nsfont.m (nsfont_open): Remove assignment to voffset and
849 unnecessary vars hshink, expand, hd, full_height, min_height.
850 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
852 * nsterm.h (nsfont_info): Remove voffset field.
854 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
856 Implement strike-through and overline on NextStep (Bug#8863).
858 * nsfont.m (nsfont_open): Use underline position provided by font,
859 instead of hard-coded value of 2.
860 (nsfont_draw): Call ns_draw_text_decoration instead.
862 * nsterm.h: Add declaration for ns_draw_text_decoration.
864 * nsterm.m (ns_draw_text_decoration): New function for drawing
865 underline, overline, and strike-through.
866 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
867 ns_draw_text_decoration. Change treatment of cursor drawing to
868 accomodate underlining, etc.
870 2011-07-28 Eli Zaretskii <eliz@gnu.org>
872 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
875 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
877 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
878 Without this fix, if a signal arrives just after memory fills up,
879 'malloc' might be invoked reentrantly.
881 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
882 In other words, assume that every image size is allowed, on non-X
883 hosts. This assumption is probably wrong, but it lets Emacs compile.
885 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
887 * regex.c (re_iswctype): Convert return values to boolean.
889 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
891 * xdisp.c (compute_display_string_pos): Don't use cached display
892 string position if the buffer had its restriction changed.
895 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
897 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
899 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
901 Integer signedness and overflow and related fixes. (Bug#9079)
903 * bidi.c: Integer size and overflow fixes.
904 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
905 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
906 (bidi_cache_find_level_change, bidi_cache_ensure_space)
907 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
908 (bidi_find_other_level_edge):
909 Use ptrdiff_t instead of EMACS_INT where either will do.
910 This works better on 32-bit hosts configured --with-wide-int.
911 (bidi_cache_ensure_space): Check for size-calculation overflow.
912 Use % rather than repeated addition, for better worst-case speed.
913 Don't set bidi_cache_size until after xrealloc returns, because it
915 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
916 (bidi_cache_ensure_space): Also check that the bidi cache size
917 does not exceed that of the largest Lisp string or buffer. See Eli
918 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
920 * alloc.c (__malloc_size_t): Remove.
921 All uses replaced by size_t. See Andreas Schwab's note
922 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
924 * image.c: Improve checking for integer overflow.
925 (check_image_size): Assume that f is nonnull, since
926 it is always nonnull in practice. This is one less thing to
927 worry about when checking for integer overflow later.
928 (x_check_image_size): New function, which checks for integer
929 overflow issues inside X.
930 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
931 This removes the need for a memory_full check.
932 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
933 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
934 (xbm_read_bitmap_data): Change locals back to 'int', since
935 their values must fit in 'int'.
936 (xpm_load_image, png_load, tiff_load):
937 Invoke x_create_x_image_and_pixmap earlier,
938 to avoid much needless work if the image is too large.
939 (tiff_load): Treat overly large images as if
940 x_create_x_image_and_pixmap failed, not as malloc failures.
941 (gs_load): Use x_check_image_size.
943 * gtkutil.c: Omit integer casts.
944 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
945 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
947 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
949 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
950 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
951 would wrongly return t on a 64-bit host.
953 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
954 The plain *_OVERFLOW macros run afoul of GCC bug 49705
955 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
956 and therefore cause GCC to emit a bogus diagnostic in some cases.
958 * image.c: Integer signedness and overflow and related fixes.
959 This is not an exhaustive set of fixes, but it's time to
960 record what I've got.
961 (lookup_pixel_color, check_image_size): Remove redundant decls.
962 (check_image_size): Don't assume that arbitrary EMACS_INT values
963 fit in 'int', or that arbitrary 'double' values fit in 'int'.
964 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
965 (tiff_load, imagemagick_load_image):
966 Check for overflow in size calculations.
967 (x_create_x_image_and_pixmap): Remove unnecessary test for
968 xmalloc returning NULL; that can't happen.
969 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
970 (xpm_color_bucket): Use better integer hashing function.
971 (xpm_cache_color): Don't possibly over-allocate memory.
972 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
974 Use ptrdiff_t, not int or size_t, to record sizes.
975 (png_load): Don't assume values greater than 2**31 fit in 'int'.
976 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
977 either works, as we prefer signed integers.
978 (tiff_read_from_memory, tiff_write_from_memory):
979 Return tsize_t, not size_t, since that's what the TIFF API wants.
980 (tiff_read_from_memory): Don't fail simply because the read would
981 go past EOF; instead, return a short read.
982 (tiff_load): Omit no-longer-needed casts.
983 (Fimagemagick_types): Don't assume size fits into 'int'.
985 Improve hashing quality when configured --with-wide-int.
986 * fns.c (hash_string): New function, taken from sxhash_string.
987 Do not discard information about ASCII character case; this
988 discarding is no longer needed.
989 (sxhash-string): Use it. Change sig to match it. Caller changed.
990 * lisp.h: Declare it.
991 * lread.c (hash_string): Remove, since we now use fns.c's version.
992 The fns.c version returns a wider integer if --with-wide-int is
993 specified, so this should help the quality of the hashing a bit.
995 * emacs.c: Integer overflow minor fix.
996 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
997 Define only if GNU_LINUX.
998 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1000 * dispnew.c: Integer signedness and overflow fixes.
1001 Remove unnecessary forward decls, that were a maintenance hassle.
1002 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1004 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1005 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1006 (prepare_desired_row, line_draw_cost):
1007 Use int, not unsigned, where either works.
1008 (save_current_matrix, restore_current_matrix):
1009 Use ptrdiff_t, not size_t, where either works.
1010 (init_display): Check for overflow more accurately, and without
1011 relying on undefined behavior.
1013 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1014 Remove, replacing with the new symbols in lisp.h. All uses changed.
1015 * fileio.c (make_temp_name):
1016 * filelock.c (lock_file_1, lock_file):
1017 * xdisp.c (message_dolog):
1018 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1019 Use pMd etc. instead.
1020 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1021 replacing the pWIDE etc. symbols removed from editfns.c.
1023 * keyboard.h (num_input_events): Now uintmax_t.
1024 This is (very slightly) less likely to mess up due to wraparound.
1027 * buffer.c: Integer signedness fixes.
1028 (alloc_buffer_text, enlarge_buffer_text):
1029 Use ptrdiff_t rather than size_t when either will do, as we prefer
1032 * alloc.c: Integer signedness and overflow fixes.
1033 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1034 (__malloc_size_t): Default to size_t, not to int.
1035 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1036 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1037 Prefer ptrdiff_t to size_t when either would do, as we prefer
1039 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1040 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1041 Now const. Initialize with values that are in range even if char
1043 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1044 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1045 These functions do the right thing with sizes > 2**32.
1046 (check_depth): Now ptrdiff_t, not int.
1047 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1048 Adjust to new way of storing sizes. Check for size overflow bugs
1050 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1051 slightly wrong anyway, as it missed one instance of
1052 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1053 (refill_memory_reserve): Omit needless cast to size_t.
1054 (mark_object_loop_halt): Mark as externally visible.
1056 * xselect.c: Integer signedness and overflow fixes.
1057 (Fx_register_dnd_atom, x_handle_dnd_message):
1058 Use ptrdiff_t, not size_t, since we prefer signed.
1059 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1060 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1061 x_dnd_atoms_size and x_dnd_atoms_length.
1063 * doprnt.c: Prefer signed to unsigned when either works.
1065 * doprnt.c (doprnt):
1067 * xdisp.c (vmessage):
1068 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1069 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1070 prefer signed arithmetic to avoid comparison confusion.
1071 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1072 but is a bit tricky.
1074 Assume freestanding C89 headers, string.h, stdlib.h.
1075 * data.c, doprnt.c, floatfns.c, print.c:
1076 Include float.h unconditionally.
1077 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1078 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1079 * regex.c: Likewise for stddef.h, string.h.
1080 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1081 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1082 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1083 (STDC_HEADERS): Remove obsolete defines.
1084 * sysdep.c: Include limits.h unconditionally.
1086 Assume support for memcmp, memcpy, memmove, memset.
1087 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1088 * regex.c (memcmp, memcpy):
1089 Remove; we assume C89 now.
1091 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1092 (__malloc_safe_bcopy): Remove; no longer needed.
1094 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1095 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1096 well either way, and we prefer signed to unsigned.
1098 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1100 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1101 closes the connection while we're reading (bug#9182).
1103 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1105 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1106 are specified (Bug#9168).
1108 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1110 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1111 Found by GCC static checking and --with-wide-int on a 32-bit host.
1113 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1115 * xdisp.c (compute_display_string_pos): Fix logic of caching
1116 previous display string position. Initialize cached_prev_pos to
1117 -1. Fixes slow-down at the beginning of a buffer.
1119 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1121 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1122 for attrs[LFACE_FONTSET_INDEX].
1124 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1126 * xml.c (parse_region): Remove unused local
1127 that was recently introduced.
1129 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1131 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1132 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1134 * xdisp.c (move_it_in_display_line_to): Record the best matching
1135 position for TO_CHARPOS while scanning the line, and restore it on
1136 exit if none of the characters scanned was an exact match.
1137 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1138 when exact match is impossible due to invisible text, and the
1139 lines are truncated.
1141 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1143 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1146 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1148 Fix a significant slow-down of cursor motion with C-n, C-p,
1149 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1150 auto-repeat under bidi redisplay in fontified buffers.
1151 * xdisp.c (compute_stop_pos_backwards): New function.
1152 (next_element_from_buffer): Call compute_stop_pos_backwards to
1153 find a suitable prev_stop when we find ourselves before
1155 (reseat): Don't look for prev_stop, as that could mean a very long
1157 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1158 <cached_disp_overlay_modiff>: Cache for last found display string
1160 (compute_display_string_pos): Return the cached position if asked
1161 about the same buffer in the same area of character positions, and
1162 the buffer wasn't changed since the time the display string
1163 position was cached.
1165 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1167 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1168 is an integer, which is important for empty lines. (Bug#9149)
1170 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1172 * frame.c (Fmodify_frame_parameters): In tty case, update the
1173 default face if necessary (Bug#4238).
1175 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1177 * editfns.c (Fstring_to_char): No need to explain what a character
1178 is in the docstring (Bug#6576).
1180 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1182 * xml.c (parse_region): Make sure we always return a tree.
1184 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1186 * xml.c (parse_region): If a document contains only comments,
1189 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1191 * xml.c (make_dom): Return comments, too.
1193 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1196 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1197 and the surrounding thread.
1198 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1199 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1200 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1202 * s/openbsd.h (BROKEN_SIGIO): Define.
1203 * unexelf.c (unexec) [__OpenBSD__]:
1204 Don't update the .mdebug section of the Alpha COFF symbol table.
1206 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1208 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1211 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1213 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1214 This fixes some race conditions on the permissions of any newly
1217 * alloc.c (valid_pointer_p): Use pipe, not open.
1218 This fixes some permissions issues when debugging.
1220 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1221 If fchown fails to set both uid and gid, try to set just gid,
1222 as that is sometimes allowed. Adjust the file's mode to eliminate
1223 setuid or setgid bits that are inappropriate if fchown fails.
1225 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1227 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1228 to compare Lisp_Objects.
1229 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1230 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1231 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1233 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1235 * lread.c (read_integer): Unread even EOF character.
1236 (read1): Likewise. Properly record start position of symbol.
1238 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1239 symbol character follows.
1241 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1243 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1244 This works around a problem with the previous change to Fcopy_file.
1245 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1246 and without this change, GCC might complain about discarding
1247 fchown's return value.
1249 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1251 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1253 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1255 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1257 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1259 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1260 it's used from the C level.
1262 * process.c: Use the same condition for POLL_FOR_INPUT in both
1263 keyboard.c and process.c (bug#1858).
1265 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1267 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1268 (Fgnutls_boot): Use it.
1270 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1272 * doc.c (Fsubstitute_command_keys): Revert last change.
1274 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1276 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1277 quotes the next character, and doesn't affect other longer
1278 sequences (bug#8935).
1280 * lread.c (syms_of_lread): Clarify that is isn't only
1281 `eval-buffer' and `eval-defun' that's affected by
1282 `lexical-binding' (bug#8460).
1284 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1286 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1287 bidi redisplay when a line includes both an image and is
1290 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1292 Fix minor problems found by static checking.
1293 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1294 (elsz): Now a signed constant, not a size_t var. We prefer signed
1295 types to unsigned, to avoid integer comparison confusion. Without
1296 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1297 "cannot optimize loop, the loop counter may overflow", a symptom
1299 * indent.c (Fvertical_motion): Mark locals as initialized.
1300 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1302 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1304 * search.c (Fre_search_backward): Mention `case-fold-search' in
1305 all the re_search_* functions (bug#8138).
1307 * keyboard.c (Fopen_dribble_file): Document when the file is
1310 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1312 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1315 Support bidi reordering of display and overlay strings.
1316 * xdisp.c (compute_display_string_pos)
1317 (compute_display_string_end): Accept additional argument STRING.
1318 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1319 (reseat_to_string): Initialize bidi_it->string.s and
1320 bidi_it->string.schars.
1321 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1322 NULL (avoids a crash in bidi_paragraph_init).
1323 Initialize itb.string.lstring.
1324 (init_iterator): Call bidi_init_it only of a valid
1325 buffer position was specified. Initialize paragraph_embedding to
1327 (reseat_to_string): Initialize the bidi iterator.
1328 (display_string): If we need to ignore text properties of
1329 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1330 original value of -1 will not work with bidi.)
1331 (compute_display_string_pos): First arg is now struct
1332 `text_pos *'; all callers changed. Support display properties on
1334 (compute_display_string_end): Support display properties on Lisp
1336 (init_iterator, reseat_1, reseat_to_string): Initialize the
1337 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1338 when iterating on a string not from display properties).
1339 (compute_display_string_pos, compute_display_string_end):
1340 Fix calculation of the object to scan. Fixes an error when using
1342 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1343 base_level_stop; instead, set base_level_stop to BEGV.
1344 Fixes crashes in vertical-motion.
1345 (next_element_from_buffer): Improve commentary for when
1346 the iterator is before prev_stop.
1347 (init_iterator): Initialize bidi_p from the default value of
1348 bidi-display-reordering, not from buffer-local value. Use the
1349 buffer-local value only if initializing for buffer iteration.
1350 (handle_invisible_prop): Support invisible properties on strings
1351 that are being bidi-reordered.
1352 (set_iterator_to_next): Support bidi reordering of C strings and
1354 (next_element_from_string): Support bidi reordering of Lisp
1356 (handle_stop_backwards): Support Lisp strings as well.
1357 (display_string): Support display of R2L glyph rows.
1358 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1359 (init_iterator): Don't initialize it->bidi_p for strings
1361 (reseat_to_string): Initialize it->bidi_p for strings here.
1362 (next_element_from_string, next_element_from_c_string)
1363 (next_element_from_buffer): Add xassert's for correspondence
1364 between IT's object being iterated and it->bidi_it.string
1366 (face_before_or_after_it_pos): Support bidi iteration.
1367 (next_element_from_c_string): Handle the case of the first string
1368 character that is not the first one in the visual order.
1369 (get_visually_first_element): New function, refactored from common
1370 parts of next_element_from_buffer, next_element_from_string, and
1371 next_element_from_c_string.
1372 (tool_bar_lines_needed, redisplay_tool_bar)
1373 (display_menu_bar): Force left-to-right direction. Add a FIXME
1374 comment for making that be controlled by a user option.
1375 (push_it, pop_it): Save and restore the state of the
1376 bidi iterator. Save and restore the bidi_p flag.
1377 (pop_it): Iterate out of display property for string iteration as
1379 (iterate_out_of_display_property): Support iteration over strings.
1380 (handle_single_display_spec): Set up it->bidi_it for iteration
1381 over a display string, and call bidi_init_it.
1382 (handle_single_display_spec, next_overlay_string)
1383 (get_overlay_strings_1, push_display_prop): Set up the bidi
1384 iterator for displaying display or overlay strings.
1385 (forward_to_next_line_start): Don't use the shortcut if
1387 (back_to_previous_visible_line_start): If handle_display_prop
1388 pushed the iterator stack, restore the internal state of the bidi
1389 iterator by calling bidi_pop_it same number of times.
1390 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1391 and we are bidi-iterating, don't decrement the iterator position;
1392 instead, set the first_elt flag in the bidi iterator, to produce
1394 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1395 (push_display_prop): xassert that we are iterating a buffer.
1396 (push_it, pop_it): Save and restore paragraph_embedding member.
1397 (handle_single_display_spec, next_overlay_string)
1398 (get_overlay_strings_1, reseat_1, reseat_to_string)
1399 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1400 correctly. Don't assume unibyte strings are not bidi-reordered.
1401 (compute_display_string_pos)
1402 (compute_display_string_end): Fix handling the case of C string.
1403 (push_it, pop_it): Save and restore from_disp_prop_p.
1404 (handle_single_display_spec, push_display_prop): Set the
1405 from_disp_prop_p flag.
1406 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1407 (pop_it): Call iterate_out_of_display_property only if we are
1408 popping after iteration over a string that came from a display
1409 property. Fix a typo in popping stretch info. Add an assertion
1410 for verifying that the iterator position is in sync with the bidi
1412 (handle_single_display_spec, get_overlay_strings_1)
1413 (push_display_prop): Fix initialization of paragraph direction for
1414 string when that of the parent object is not yet determined.
1415 (reseat_1): Call bidi_init_it to resync the bidi
1416 iterator with IT's position. (Bug#7616)
1417 (find_row_edges): If ROW->start.pos gives position
1418 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1419 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1420 Reset the from_disp_prop_p flag.
1421 (SAVE_IT, RESTORE_IT): New macros.
1422 (pos_visible_p, face_before_or_after_it_pos)
1423 (back_to_previous_visible_line_start)
1424 (move_it_in_display_line_to, move_it_in_display_line)
1425 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1426 (try_scrolling, redisplay_window, display_line): Use them when
1427 saving a temporary copy of the iterator and restoring it back.
1428 (back_to_previous_visible_line_start, reseat_1)
1429 (init_iterator): Empty the bidi cache "stack".
1430 (move_it_in_display_line_to): If iterator ended up at
1431 EOL, but we never saw any buffer positions smaller than
1432 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1433 motion in bidi-reordered lines.
1434 (move_it_in_display_line_to): Record prev_method and prev_pos
1435 immediately before the call to set_iterator_to_next. Fixes cursor
1436 motion in bidi-reordered lines with stretch glyphs and strings
1437 displayed in margins. (Bug#8133) (Bug#8867)
1438 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1440 (pos_visible_p): Support positions in bidi-reordered lines.
1441 Save and restore bidi cache.
1443 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1444 (bidi_paragraph_info): Delete unused struct.
1445 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1446 (bidi_cache_start): New variable.
1447 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1449 (bidi_cache_fetch_state, bidi_cache_search)
1450 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1451 (bidi_cache_find, bidi_peek_at_next_level)
1452 (bidi_level_of_next_char, bidi_find_other_level_edge)
1453 (bidi_move_to_visually_next): Compare cache index with
1454 bidi_cache_start rather than with zero.
1455 (bidi_fetch_char): Accept new argument STRING; all callers
1456 changed. Support iteration over a string. Support strings with
1457 display properties. Support unibyte strings. Fix the type of
1458 `len' according to what STRING_CHAR_AND_LENGTH expects.
1459 (bidi_paragraph_init, bidi_resolve_explicit_1)
1460 (bidi_resolve_explicit, bidi_resolve_weak)
1461 (bidi_level_of_next_char, bidi_move_to_visually_next):
1462 Support iteration over a string.
1463 (bidi_set_sor_type, bidi_resolve_explicit_1)
1464 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1465 can now be zero (for strings); special values 0 and -1 were
1466 changed to -1 and -2, respectively.
1467 (bidi_char_at_pos): New function.
1468 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1469 Call it instead of FETCH_MULTIBYTE_CHAR.
1470 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1471 initialized to valid values.
1472 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1474 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1475 the test for valid cached positions. Fix the logic for looking up
1476 the sentinel state in the cache. GCPRO the Lisp string we are
1478 (bidi_push_it, bidi_pop_it): New functions.
1479 (bidi_initialize): Initialize the bidi cache start stack pointer.
1480 (bidi_cache_ensure_space): New function, refactored from part of
1481 bidi_cache_iterator_state. Don't assume the required size is just
1482 one BIDI_CACHE_CHUNK away.
1483 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1484 (bidi_count_bytes, bidi_char_at_pos): New functions.
1485 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1486 always valid if bidi_cache_idx is valid.
1487 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1488 is valid if it's going to be used.
1489 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1490 (bidi_cache_fetch_state, bidi_cache_search)
1491 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1492 (bidi_cache_iterator_state, bidi_cache_find)
1493 (bidi_find_other_level_edge, bidi_cache_start_stack):
1494 All variables related to cache indices are now EMACS_INT.
1496 * dispextern.h (struct bidi_string_data): New structure.
1497 (struct bidi_it): New member `string'. Make flag members be 1-bit
1498 fields, and put them last in the struct.
1499 (compute_display_string_pos, compute_display_string_end):
1501 (bidi_push_it, bidi_pop_it): Add prototypes.
1502 (struct iterator_stack_entry): New members bidi_p,
1503 paragraph_embedding, and from_disp_prop_p.
1504 (struct it): Member bidi_p is now a bit field 1 bit wide.
1505 (bidi_shelve_cache, bidi_unshelve_cache):
1508 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1509 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1510 and vector-like objects.
1512 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1513 cache around display iteration.
1515 * window.c (Fwindow_end, window_scroll_pixel_based)
1516 (displayed_window_lines, Frecenter): Save and restore the bidi
1517 cache around display iteration.
1519 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1521 * editfns.c (Fdelete_region): Clarify the use of the named
1522 parameters (bug#6788).
1524 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1526 * indent.c (Fvertical_motion): Set and restore w->pointm when
1527 saving and restoring the window's buffer (Bug#9006).
1529 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1531 * editfns.c (Fstring_to_char): Clarify just what is returned
1532 (bug#6576). Text by Eli Zaretskii.
1534 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1536 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1538 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1540 * buffer.c (mmap_find): Fix a typo.
1542 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1544 Fix execution of x selection hooks.
1545 * xselect.c (Qx_lost_selection_functions)
1546 (Qx_sent_selection_functions): New vars.
1547 (syms_of_xselect): DEFSYM them.
1548 (x_handle_selection_request): Pass Qx_sent_selection_functions
1549 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1550 (x_handle_selection_clear,x_clear_frame_selections):
1551 Pass Qx_lost_selection_functions rather than
1552 Vx_lost_selection_functions to Frun_hook_with_args.
1554 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1556 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1557 The old code sometimes used this field without initializing it.
1559 * alloc.c (gc_sweep): Don't read past end of array.
1560 In theory, the old code could also have corrupted Emacs internals,
1561 though it'd be very unlikely.
1563 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1565 * character.c (Fcharacterp): Don't advertise optional ignored
1566 argument. (Bug#4026)
1568 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1570 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1573 * window.c (Fset_window_start): Doc fix (bug#4199).
1574 (Fset_window_hscroll): Ditto.
1576 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1578 Fix minor new problems caught by GCC 4.6.1.
1579 * term.c (init_tty): Remove unused local.
1580 * xsettings.c (store_monospaced_changed): Define this function only
1581 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1584 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1586 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1588 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1590 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1591 are the mini-buffer and the echo area (bug#3320).
1593 * term.c (init_tty): Remove support for supdup, c10 and perq
1594 terminals, which are no longer supported (bug#1482).
1596 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1598 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1600 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1602 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1603 for non-popups (Bug#3642).
1605 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1607 * alloc.c (reset_malloc_hooks): Protoize.
1608 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1609 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1610 * cm.c (losecursor): Likewise.
1611 * data.c (fmod): Likewise.
1612 * dispnew.c (swap_glyphs_in_rows): Likewise.
1613 * emacs.c (memory_warning_signal): Likewise.
1614 * floatfns.c (float_error): Likewise.
1615 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1616 (otf_open, font_otf_capability, generate_otf_features)
1617 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1619 * image.c (pbm_read_file): Likewise.
1620 * indent.c (string_display_width): Likewise.
1621 * intervals.c (check_for_interval, search_for_interval)
1622 (inc_interval_count, count_intervals, root_interval)
1623 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1624 * lread.c (defalias): Likewise.
1625 * ralloc.c (r_alloc_check): Likewise.
1626 * regex.c (set_image_of_range_1, set_image_of_range)
1627 (regex_grow_registers): Likewise.
1628 * sysdep.c (strerror): Likewise.
1629 * termcap.c (valid_filename_p, tprint, main): Likewise.
1630 * tparam.c (main): Likewise.
1631 * unexhp9k800.c (run_time_remap, save_data_space)
1632 (update_file_ptrs, read_header, write_header, calculate_checksum)
1633 (copy_file, copy_rest, display_header): Likewise.
1634 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1636 * xdisp.c (check_it): Likewise.
1637 * xfaces.c (register_color, unregister_color, unregister_colors):
1639 * xfns.c (print_fontset_result): Likewise.
1640 * xrdb.c (member, fatal, main): Likewise.
1642 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1644 Fix minor problems found by static checking (Bug#9031).
1645 * chartab.c (char_table_set_range, map_sub_char_table):
1646 Remove unused locals.
1647 (uniprop_table): Now static.
1648 * composite.c (_work_char): Remove unused static var.
1650 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1652 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1654 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1656 * gtkutil.c (qttip_cb): Remove code without function.
1658 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1660 * w32.c (pthread_sigmask): New stub.
1662 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1664 Use pthread_sigmask, not sigprocmask (Bug#9010).
1665 sigprocmask is portable only for single-threaded applications, and
1666 Emacs can be multi-threaded when it uses GTK.
1667 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1669 * callproc.c (Fcall_process):
1670 * process.c (create_process):
1671 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1672 Use pthread_sigmask, not sigprocmask.
1674 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1676 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1677 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1680 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1682 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1683 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1684 (xg_hide_tooltip): Fix comment.
1686 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1687 in registerServicesMenuSendTypes.
1688 (validRequestorForSendType): Don't check ns_return_types.
1690 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1693 2011-07-08 Jason Rumney <jasonr@gnu.org>
1695 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1696 frame struct members of non-existent frames (Bug#6284).
1698 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1700 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1701 variable firstTime not needed on OSX >= 10.6.
1702 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1703 >= 10.5. Use setKnobProportion, setDoubleValue.
1705 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1706 (MAC_OS_X_VERSION_10_5): Define if not defined.
1707 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1708 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1709 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1711 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1712 cString and lossyCString on OSX >= 10.4
1714 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1715 sizeToFit on OSX >= 10.2.
1717 * nsimage.m (allocInitFromFile): Don't use deprecated method
1718 bestRepresentationForDevice on OSX >= 10.6.
1720 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1723 * emacs.c: Declare unexec_init_emacs_zone.
1725 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1727 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1729 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1730 on svcsMenu (Bug#8842).
1732 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1734 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1736 * nsterm.m (QUTF8_STRING): Declare.
1737 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1738 (validRequestorForSendType): Return type is (id).
1739 Change indexOfObjectIdenticalTo to indexOfObject.
1740 Check if we have local selection before returning self (Bug#8842).
1741 (writeSelectionToPasteboard): Put local selection into paste board
1742 if we have a local selection (Bug#8842).
1743 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1745 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1746 (ns_get_local_selection): Declare.
1748 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1750 * keymap.c (describe_map_tree): Don't insert a double newline at
1751 the end of the buffer (bug#1169) and return whether we inserted
1754 * callint.c (Fcall_interactively): Change "reading args" to
1755 "providing args" to try to clarify what it does (bug#1010).
1757 2011-07-07 Kenichi Handa <handa@m17n.org>
1759 * composite.c (composition_compute_stop_pos): Ignore a static
1760 composition starting before CHARPOS (Bug#8915).
1762 * xdisp.c (handle_composition_prop): Likewise.
1764 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1766 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1769 2011-07-07 Kenichi Handa <handa@m17n.org>
1771 * character.h (unicode_category_t): New enum type.
1773 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1774 (Qchar_code_property_table): New variable.
1775 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1776 (UNIPROP_COMPRESSED_FORM_P): New macros.
1777 (char_table_ascii): Uncompress the compressed values.
1778 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1779 Uncompress the compressed values.
1780 (sub_char_table_ref_and_range): Likewise.
1781 (char_table_ref_and_range): Uncompress the compressed values.
1782 (sub_char_table_set): New arg is_uniprop. Callers changed.
1783 Uncompress the compressed values.
1784 (sub_char_table_set_range): Args changed. Callers changed.
1785 (char_table_set_range): Adjuted for the above change.
1786 (map_sub_char_table): Delete args default_val and parent. Add arg
1787 top. Give decoded values to a Lisp function.
1788 (map_char_table): Adjust for the above change. Give decoded
1789 values to a Lisp function. Gcpro more variables.
1790 (uniprop_table_uncompress)
1791 (uniprop_decode_value_run_length): New functions.
1792 (uniprop_decoder, uniprop_decoder_count): New variables.
1793 (uniprop_get_decoder, uniprop_encode_value_character)
1794 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1796 (uniprop_encoder, uniprop_encoder_count): New variables.
1797 (uniprop_get_encoder, uniprop_table)
1798 (Funicode_property_table_internal, Fget_unicode_property_internal)
1799 (Fput_unicode_property_internal): New functions.
1800 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1801 Sunicode_property_table_internal, Sget_unicode_property_internal,
1802 and Sput_unicode_property_internal. Defvar_lisp
1803 char-code-property-alist.
1805 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1806 Vunicode_category_table.
1808 * font.c (font_range): Adjust for the change of
1809 Vunicode_category_table.
1811 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1813 * m/iris4d.h: Remove file, move contents ...
1814 * s/irix6-5.h: ... here.
1816 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1818 Remove unportable assumption about struct layout (Bug#8884).
1819 * alloc.c (mark_buffer):
1820 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1821 (clone_per_buffer_values): Don't assume that
1822 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1823 This isn't true in general, and it's particularly not true
1824 if Emacs is configured with --with-wide-int.
1825 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1826 New macros, used in the buffer.c change.
1828 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1830 * xsettings.c: Use both GConf and GSettings if both are available.
1831 (store_config_changed_event): Add comment.
1832 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1833 (store_tool_bar_style_changed): New functions.
1834 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1835 (struct xsettings): Move font inside HAVE_XFT.
1836 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1837 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1838 Move inside HAVE_XFT.
1839 (something_changed_gsettingsCB): Rename from something_changedCB.
1840 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1842 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1843 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1844 (something_changed_gconfCB): Rename from something_changedCB.
1845 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1846 (parse_settings): Move check for font inside HAVE_XFT.
1847 (read_settings, apply_xft_settings): Add comment.
1848 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1849 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1850 call store_font_name_changed.
1851 (xft_settings_event): Add comment.
1852 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1853 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1854 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1855 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1856 (xsettings_initialize): Call init_gsettings last.
1857 (xsettings_get_system_font, xsettings_get_system_normal_font):
1860 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1862 Random fixes. E.g., (random) never returned negative values.
1863 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1864 subseconds part to the entropy, as that's a bit more random.
1865 Prefer signed to unsigned, since the signedness doesn't matter and
1866 in general we prefer signed. When given a limit, use a
1867 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1868 latter isn't right if USE_2_TAGS_FOR_INTS.
1869 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1870 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1872 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1874 * textprop.c (text_property_stickiness):
1875 Obey Vtext_property_default_nonsticky.
1876 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1877 * w32fns.c (syms_of_w32fns):
1878 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1880 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1882 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1883 This is more efficient than Ffile_directory_p and avoids a minor race.
1885 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1887 * buffer.c (Foverlay_put): Say what the return value is
1890 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1891 is a directory before asking whether to use the file name
1893 (barf_or_query_if_file_exists): Make the "File is a directory"
1894 error be more correct.
1896 * fns.c (Frequire): Remove the mention of the .gz files, since
1897 that's installation-specific, but keep the mention of
1898 `get-load-suffixes'.
1900 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1902 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1903 Report string overflow if the output is too long.
1905 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1907 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1908 (syms_of_gnutls): Remove duplicate DEFSYM for
1909 Qgnutls_bootprop_verify_hostname_error, an error for
1910 Qgnutls_bootprop_verify_error (which is no longer used).
1912 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1913 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1914 Also (re)move comments that are misplaced or no longer relevant.
1916 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1918 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1920 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1922 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1923 and background color parameters if they have been changed.
1925 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1927 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1929 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1931 * xsettings.c (SYSTEM_FONT): Define only when used.
1932 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1934 * keymap.c (access_keymap_1): Now static.
1936 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1938 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1939 leave any prefix arg for the up event (Bug#1586).
1941 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1943 * lread.c (syms_of_lread): Mention single symbols defined by
1944 `defvar' or `defconst' (bug#7154).
1946 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1947 (Frequire): Mention get-load-suffixes.
1949 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1951 * window.h (window): Remove clone_number slot.
1952 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1954 (make_parent_window, make_window, saved_window)
1955 (Fset_window_configuration, save_window_save): Don't deal with
1957 * buffer.c (Qclone_number): Remove declaration.
1958 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1960 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1962 Add multiple inheritance to keymaps.
1963 * keymap.c (Fmake_composed_keymap): New function.
1964 (Fset_keymap_parent): Simplify.
1965 (fix_submap_inheritance): Remove.
1966 (access_keymap_1): New function extracted from access_keymap to handle
1967 embedded parents and handle lists of maps.
1968 (access_keymap): Use it.
1969 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1970 (Fcopy_keymap): Handle embedded parents.
1971 (Fcommand_remapping, define_as_prefix): Simplify.
1972 (Fkey_binding): Simplify.
1973 (syms_of_keymap): Move minibuffer-local-completion-map,
1974 minibuffer-local-filename-completion-map,
1975 minibuffer-local-must-match-map, and
1976 minibuffer-local-filename-must-match-map to Elisp.
1977 (syms_of_keymap): Defsubr make-composed-keymap.
1978 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1979 (parse_menu_item): Trivial simplification.
1981 2011-07-01 Glenn Morris <rgm@gnu.org>
1983 * Makefile.in (SETTINGS_LIBS): Fix typo.
1985 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1987 * coding.c (Fencode_coding_string): Record the last coding system
1988 used, as the function doc string says (bug#8738).
1990 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1992 * xsettings.c (store_monospaced_changed): Take new font as arg and
1993 check for change against current_mono_font.
1994 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1995 (emacs_settings_constructor, emacs_settings_get_property)
1996 (emacs_settings_set_property, emacs_settings_class_init)
1997 (emacs_settings_init, gsettings_obj): Remove.
1998 (something_changedCB): New function for HAVE_GSETTINGS.
1999 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2000 with value as argument.
2001 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2002 g_settings_new (Bug#8967). Do not create gsettings_obj.
2003 Remove calls to g_settings_bind. Connect something_changedCB to
2006 * xgselect.c: Add defined (HAVE_GSETTINGS).
2007 (xgselect_initialize): Ditto.
2009 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2010 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2013 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2015 * eval.c (struct backtrace): Simplify and port the data structure.
2016 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2017 signed bit field, as this assumption is not portable and it makes
2018 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2019 "char debug_on_exit : 1" as this is not portable either; instead,
2020 use the portable "unsigned int debug_on_exit : 1". Remove unused
2021 member evalargs. Remove obsolete comments about cc bombing out.
2023 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2025 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2026 Let HAVE_GSETTINGS override HAVE_GCONF.
2027 (store_monospaced_changed): New function.
2028 (EMACS_SETTINGS): A new type derived from GObject to handle
2029 GSettings notifications.
2030 (emacs_settings_constructor, emacs_settings_get_property)
2031 (emacs_settings_set_property, emacs_settings_class_init):
2033 (gsettings_client, gsettings_obj): New variables.
2034 (GSETTINGS_SCHEMA): New define.
2035 (something_changedCB): Call store_monospaced_changed.
2036 (init_gsettings): New function.
2037 (xsettings_initialize): Call init_gsettings.
2038 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2041 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2044 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2046 * window.c (resize_root_window, grow_mini_window)
2047 (shrink_mini_window): Rename Qresize_root_window to
2048 Qwindow_resize_root_window and Qresize_root_window_vertically to
2049 Qwindow_resize_root_window_vertically.
2051 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2053 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2055 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2057 * makefile.w32-in: Redesign dependencies so they reflect more
2058 clearly which files are directly included by each source file,
2059 and not through other includes.
2061 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2063 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2064 (sort_overlays, overlay_strings): When an overlay's clone number
2065 matches the window's clone number process the overlay even if
2066 the overlay's window property doesn't match the current window.
2068 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2069 (Fwindow_hchild): Rename to Fwindow_left_child.
2070 (Fwindow_next): Rename to Fwindow_next_sibling.
2071 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2072 (resize_window_check): Rename to window_resize_check.
2073 (resize_window_apply): Rename to window_resize_apply.
2074 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2075 (Fdelete_other_windows_internal, resize_frame_windows)
2076 (Fsplit_window_internal, Fdelete_window_internal)
2077 (grow_mini_window, shrink_mini_window)
2078 (Fresize_mini_window_internal): Fix callers accordingly.
2080 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2082 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2083 (emacs_fixed_set_min_size): Remove.
2084 (emacs_fixed_new): Take frame as argument.
2086 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2087 (_EmacsFixedPrivate): Remove minwidth/height.
2088 Add struct frame *f.
2089 (emacs_fixed_init): Initialize priv->f.
2090 (get_parent_class, emacs_fixed_set_min_size): Remove.
2091 (emacs_fixed_new): Set priv->f to argument.
2092 (emacs_fixed_get_preferred_width)
2093 (emacs_fixed_get_preferred_height): Use min_width/height from
2094 frames size_hint to set minimum and natural (Bug#8919).
2095 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2096 and use min_width/height from frames size_hint to set
2097 min_width/height (Bug#8919).
2099 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2100 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2103 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2105 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2106 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2109 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2111 * process.c (wait_reading_process_output): Bypass select if
2112 waiting for a cell while ignoring keyboard input, and input is
2113 pending. Suggested by Jan Djärv (Bug#8869).
2115 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2117 Use gnulib's dup2 module instead of rolling our own.
2118 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2120 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2122 * dispnew.c (scrolling_window): Before scrolling, turn off a
2123 mouse-highlight in the window being scrolled.
2125 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2127 Move DEFSYM to lisp.h and use everywhere.
2129 * character.h (DEFSYM): Move declaration...
2130 * lisp.h (DEFSYM): ...here.
2136 * w32select.c: Don't include character.h.
2138 * alloc.c (syms_of_alloc):
2139 * buffer.c (syms_of_buffer):
2140 * bytecode.c (syms_of_bytecode):
2141 * callint.c (syms_of_callint):
2142 * casefiddle.c (syms_of_casefiddle):
2143 * casetab.c (init_casetab_once):
2144 * category.c (init_category_once, syms_of_category):
2145 * ccl.c (syms_of_ccl):
2146 * cmds.c (syms_of_cmds):
2147 * composite.c (syms_of_composite):
2148 * dbusbind.c (syms_of_dbusbind):
2149 * dired.c (syms_of_dired):
2150 * dispnew.c (syms_of_display):
2151 * doc.c (syms_of_doc):
2152 * editfns.c (syms_of_editfns):
2153 * emacs.c (syms_of_emacs):
2154 * eval.c (syms_of_eval):
2155 * fileio.c (syms_of_fileio):
2156 * fns.c (syms_of_fns):
2157 * frame.c (syms_of_frame):
2158 * fringe.c (syms_of_fringe):
2159 * insdel.c (syms_of_insdel):
2160 * keymap.c (syms_of_keymap):
2161 * lread.c (init_obarray, syms_of_lread):
2162 * macros.c (syms_of_macros):
2163 * msdos.c (syms_of_msdos):
2164 * print.c (syms_of_print):
2165 * process.c (syms_of_process):
2166 * search.c (syms_of_search):
2167 * sound.c (syms_of_sound):
2168 * syntax.c (init_syntax_once, syms_of_syntax):
2169 * terminal.c (syms_of_terminal):
2170 * textprop.c (syms_of_textprop):
2171 * undo.c (syms_of_undo):
2172 * w32.c (globals_of_w32):
2173 * window.c (syms_of_window):
2174 * xdisp.c (syms_of_xdisp):
2175 * xfaces.c (syms_of_xfaces):
2176 * xfns.c (syms_of_xfns):
2177 * xmenu.c (syms_of_xmenu):
2178 * xsettings.c (syms_of_xsettings):
2179 * xterm.c (syms_of_xterm): Use DEFSYM.
2181 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2183 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2185 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2187 Integer and buffer overflow fixes (Bug#8873).
2189 * print.c (printchar, strout): Check for string overflow.
2190 (PRINTPREPARE, printchar, strout):
2191 Don't set size unless allocation succeeds.
2193 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2194 for sizes. Check for string overflow more accurately.
2195 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2197 * macros.c: Integer and buffer overflow fixes.
2198 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2199 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2200 Use ptrdiff_t, not int, for sizes.
2201 Don't increment bufsize until after realloc succeeds.
2202 Check for size-calculation overflow.
2203 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2205 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2207 * lread.c: Integer overflow fixes.
2208 (read_integer): Radix is now EMACS_INT, not int,
2209 to improve quality of diagnostics for out-of-range radices.
2210 Calculate buffer size correctly for out-of-range radices.
2211 (read1): Check for integer overflow in radices, and in
2212 read-circle numbers.
2213 (read_escape): Avoid int overflow.
2214 (Fload, openp, read_buffer_size, read1)
2215 (substitute_object_recurse, read_vector, read_list, map_obarray):
2216 Use ptrdiff_t, not int, for sizes.
2217 (read1): Use EMACS_INT, not int, for sizes.
2218 Check for size overflow.
2220 * image.c (cache_image): Check for size arithmetic overflow.
2222 * lread.c: Integer overflow issues.
2223 (saved_doc_string_size, saved_doc_string_length)
2224 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2225 Now ptrdiff_t, not int.
2226 (read1): Don't assume doc string length fits in int. Check for
2227 out-of-range doc string lengths.
2228 (read_list): Don't assume file position fits in int.
2229 (read_escape): Check for hex character overflow.
2231 2011-06-22 Leo Liu <sdl.web@gmail.com>
2233 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2234 Move to minibuffer.el.
2236 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2238 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2239 The following patches are for when GLYPH_DEBUG && !XASSERT.
2240 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2241 * dispnew.c (flush_stdout):
2242 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2243 Mark as externally visible.
2244 * dispnew.c (check_window_matrix_pointers): Now static.
2245 * dispnew.c (window_to_frame_vpos):
2246 * xfns.c (unwind_create_frame):
2247 * xterm.c (x_check_font): Remove unused local.
2248 * scroll.c (CHECK_BOUNDS):
2249 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2250 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2251 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2252 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2253 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2255 (debug_method_add): Use va_list and vsprintf rather than relying
2256 on undefined behavior with wrong number of arguments.
2257 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2258 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2259 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2260 since we're not interested in debugging glyphs with old libraries.
2261 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2262 GCC 4.6.0's static checking.
2264 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2266 Integer overflow and signedness fixes (Bug#8873).
2267 A few related buffer overrun fixes, too.
2269 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2271 * dispextern.h (struct face.stipple):
2272 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2273 (x_bitmap_mask, x_allocate_bitmap_record)
2274 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2275 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2276 (x_create_bitmap_from_xpm_data):
2277 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2278 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2280 * xfaces.c (load_pixmap):
2281 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2282 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2283 (.bitmaps_last, struct x_output.icon_bitmap):
2284 Use ptrdiff_t, not int, for bitmap indexes.
2285 (x_allocate_bitmap_record): Check for size overflow.
2286 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2288 Use ptrdiff_t, not int, for overlay counts.
2289 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2290 * editfns.c (overlays_around, get_pos_property):
2291 * textprop.c (get_char_property_and_overlay):
2292 * xdisp.c (next_overlay_change, note_mouse_highlight):
2293 * xfaces.c (face_at_buffer_position):
2294 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2295 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2296 (Fnext_overlay_change, Fprevious_overlay_change)
2297 (mouse_face_overlay_overlaps, Foverlays_in):
2298 Use ptrdiff_t, not int, for sizes.
2299 (overlays_at, overlays_in): Check for size-calculation overflow.
2301 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2303 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2304 (x_session_initialize): Do not assume string length fits in int.
2306 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2307 This is unlikely, but can occur if DPI is outlandish.
2309 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2310 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2312 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2313 * xrdb.c (magic_file_p, search_magic_path):
2314 Omit last arg SUFFIX; it was always 0. All callers changed.
2315 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2317 * xfont.c (xfont_match): Avoid need for strlen.
2319 * xfns.c: Don't assume strlen fits in int.
2320 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2322 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2323 not unsigned long, as we prefer signed integers. All callers changed.
2324 Detect integer overflow in repeat count.
2325 (message_dolog): Don't assume print length fits in 39 bytes.
2326 (display_mode_element): Don't assume strlen fits in int.
2328 * termcap.c: Don't assume sizes fit in int and never overflow.
2329 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2330 (gobble_line): Check for size-calculation overflow.
2332 * minibuf.c (Fread_buffer):
2333 * lread.c (intern, intern_c_string):
2334 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2335 Don't assume string length fits in int.
2337 * keyboard.c (parse_tool_bar_item):
2338 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2340 * font.c: Don't assume string length fits in int.
2341 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2342 Use ptrdiff_t, not int.
2343 (font_intern_prop): Don't assume string length fits in int.
2344 Don't assume integer property fits in fixnum.
2345 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2347 * filelock.c: Fix some buffer overrun and integer overflow issues.
2348 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2349 Reformulate so as not to need the command string.
2350 Invoke gzip -cd rather than gunzip, as it's more portable.
2351 (lock_info_type, lock_file_1, lock_file):
2352 Don't assume pid_t and time_t fit in unsigned long.
2353 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2354 (current_lock_owner): Prefer signed type for sizes.
2355 Use memcpy, not strncpy, where memcpy is what is really wanted.
2356 Don't assume (via atoi) that time_t and pid_t fit in int.
2357 Check for time_t and/or pid_t out of range, e.g., via a network share.
2358 Don't alloca where an auto var works fine.
2360 * fileio.c: Fix some integer overflow issues.
2361 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2362 Don't assume string length fits in int.
2363 (directory_file_name): Don't assume string length fits in long.
2364 (make_temp_name): Don't assume pid fits in int, or that its print
2365 length is less than 20.
2367 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2369 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2371 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2373 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2374 We prefer signed integers, even for size calculations.
2376 * emacs.c: Don't assume string length fits in 'int'.
2377 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2378 (main): Don't invoke strlen when not needed.
2380 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2381 (XD_DEBUG_MESSAGE): Don't waste a byte.
2383 * callproc.c (getenv_internal_1, getenv_internal)
2385 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2387 * lread.c (invalid_syntax): Omit length argument.
2388 All uses changed. This doesn't fix a bug, but it simplifies the
2389 code away from its former Hollerith-constant appearance, and it's
2390 one less 'int' to worry about when looking at integer-overflow issues.
2391 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2393 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2394 This didn't break anything, but it didn't help either.
2395 It's confusing to put a bogus integer in a place where the actual
2396 value does not matter.
2397 (LIST_END_P): Remove unused macro and its bogus comment.
2398 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2400 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2401 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2403 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2404 We prefer signed types, and the value cannot exceed the EMACS_INT
2405 range anyway (because otherwise the length would not be representable).
2406 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2407 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2408 This avoids a GCC warning when WIDE_EMACS_INT.
2410 * indent.c (sane_tab_width): New function.
2411 (current_column, scan_for_column, Findent_to, position_indentation)
2412 (compute_motion): Use it. This is just for clarity.
2413 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2415 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2417 * lisp.h (lint_assume): New macro.
2418 * composite.c (composition_gstring_put_cache):
2419 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2421 * editfns.c, insdel.c:
2422 Omit unnecessary forward decls, to simplify future changes.
2424 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2426 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2428 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2429 Use much-faster test for byte-length change.
2430 Don't assume string byte-length fits in 'int'.
2431 Check that character arg fits in 'int'.
2432 (mapcar1): Declare byte as byte, for clarity.
2434 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2436 * fns.c (concat): Catch string overflow earlier.
2437 Do not rely on integer wraparound.
2439 * dispextern.h (struct it.overlay_strings_charpos)
2440 (struct it.selective): Now EMACS_INT, not int.
2441 * xdisp.c (forward_to_next_line_start)
2442 (back_to_previous_visible_line_start)
2443 (reseat_at_next_visible_line_start, next_element_from_buffer):
2444 Don't arbitrarily truncate the value of 'selective' to int.
2446 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2448 * composite.c: Don't truncate sizes to 'int'.
2449 (composition_gstring_p, composition_reseat_it)
2450 (composition_adjust_point): Use EMACS_INT, not int.
2451 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2452 not EMACS_UINT, for indexes.
2454 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2456 * buffer.c: Include <verify.h>.
2457 (struct sortvec.priority, struct sortstr.priority):
2458 Now EMACS_INT, not int.
2459 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2460 (struct sortstr.size, record_overlay_string)
2461 (struct sortstrlist.size, struct sortlist.used):
2462 Don't truncate size to int.
2463 (record_overlay_string): Check for size-calculation overflow.
2464 (init_buffer_once): Check at compile-time, not run-time.
2466 2011-06-22 Jim Meyering <meyering@redhat.com>
2468 Don't leak an XBM-image-sized buffer
2469 * image.c (xbm_load): Free the image buffer after using it.
2471 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2474 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2475 that Sun C diagnosed.
2476 * fns.c (secure_hash): Fix pointer signedness issue.
2477 * intervals.c (static_offset_intervals): New function.
2478 (offset_intervals): Use it.
2480 2011-06-21 Leo Liu <sdl.web@gmail.com>
2483 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2486 * fns.c (secure_hash): Rename from crypto_hash_function and change
2487 the first arg to accept symbols.
2488 (Fsecure_hash): New primitive.
2489 (syms_of_fns): New symbols.
2491 2011-06-20 Deniz Dogan <deniz@dogan.se>
2493 * process.c (Fset_process_buffer): Clarify return value in
2496 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2498 * dispnew.c (add_window_display_history): Use BVAR.
2500 * xdisp.c (debug_method_add): Use BVAR.
2501 (check_window_end, dump_glyph_matrix, dump_glyph)
2502 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2504 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2507 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2508 check till after the cache is created in init_frame_faces.
2510 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2512 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2514 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2516 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2517 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2518 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2520 Improve buffer-overflow checking (Bug#8873).
2521 * fileio.c (Finsert_file_contents):
2522 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2523 Remove the old (too-loose) buffer overflow checks.
2524 They weren't needed, since make_gap checks for buffer overflow.
2525 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2526 The old code merely checked for Emacs fixnum overflow, and relied
2527 on undefined (wraparound) behavior. The new code avoids undefined
2528 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2530 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2531 Tune. Don't use wider integers than needed. Don't use alloca.
2532 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2534 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2536 * insdel.c, lisp.h (buffer_overflow): New function.
2537 (insert_from_buffer_1, replace_range, replace_range_2):
2538 * insdel.c (make_gap_larger):
2539 * editfns.c (Finsert_char):
2540 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2542 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2544 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2546 Integer overflow and signedness fixes (Bug#8873).
2548 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2549 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2551 * fileio.c: Don't assume EMACS_INT fits in off_t.
2552 (emacs_lseek): New static function.
2553 (Finsert_file_contents, Fwrite_region): Use it.
2554 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2556 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2558 * fns.c: Don't overflow int when computing a list length.
2559 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2560 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2561 truncation on 64-bit hosts. Check for QUIT every
2562 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2563 faster and is responsive enough.
2564 (Flength): Report an error instead of overflowing an integer.
2565 (Fsafe_length): Return a float if the value is not representable
2566 as a fixnum. This shouldn't happen except in contrived situations.
2567 (Fnthcdr, Fsort): Don't assume list length fits in int.
2568 (Fcopy_sequence): Don't assume vector length fits in int.
2570 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2571 (header_size, word_size): New constants.
2572 (allocate_vectorlike): Don't check size overflow here.
2573 (allocate_vector): Check it here instead, since this is the only
2574 caller of allocate_vectorlike that could cause overflow.
2575 Check that the new vector's length is representable as a fixnum.
2577 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2578 The previous code was bogus. For example, next_almost_prime (32)
2579 returned 39, which is undesirable as it is a multiple of 3; and
2580 next_almost_prime (24) returned 25, which is a multiple of 5 so
2581 why was the code bothering to check for multiples of 7?
2583 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2585 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2587 Variadic C functions now count arguments with ptrdiff_t.
2588 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2589 Back then I didn't know that the Emacs coding style prefers signed int.
2590 Also, in the meantime I found a few more instances where arguments
2591 were being counted with int, which may truncate counts on 64-bit
2592 machines, or EMACS_INT, which may be unnecessarily wide.
2593 * lisp.h (struct Lisp_Subr.function.aMANY)
2594 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2595 Arg counts are now ptrdiff_t, not size_t.
2596 All variadic functions and their callers changed accordingly.
2597 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2598 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2599 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2600 * callint.c (Fcall_interactively): Check arg count for overflow,
2601 to avoid potential buffer overrun. Use signed char, not 'int',
2602 for 'varies' array, so that we needn't bother to check its size
2603 calculation for overflow.
2604 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2605 * eval.c (apply_lambda):
2606 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2607 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2608 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2610 * callint.c (Fcall_interactively): Don't use index var as event count.
2612 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2613 * mem-limits.h (SIZE): Remove; no longer used.
2615 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2617 Remove unnecessary casts.
2618 * xterm.c (x_term_init):
2619 * xfns.c (x_set_border_pixel):
2620 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2621 These aren't needed now that we assume ANSI C.
2623 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2624 It's more likely to cause problems (due to unsigned overflow)
2627 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2629 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2631 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2633 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2635 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2637 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2639 GLYPH_CODE_FACE returns EMACS_INT, not int.
2640 * dispextern.h (merge_faces):
2641 * xfaces.c (merge_faces):
2642 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2643 Don't assume EMACS_INT fits in int.
2645 * character.h (CHAR_VALID_P): Remove unused parameter.
2646 * fontset.c, lisp.h, xdisp.c: All uses changed.
2648 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2650 * fns.c (concat): Minor tuning based on overflow analysis.
2651 This doesn't fix any bugs. Use int to hold character, instead
2652 of constantly refetching from Emacs object. Use XFASTINT, not
2653 XINT, for value known to be a character. Don't bother comparing
2654 a single byte to 0400, as it's always less.
2656 * floatfns.c (Fexpt):
2657 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2659 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2662 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2664 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2665 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2666 incorrectly succeed when S was a string, because 4294967386 was
2667 truncated before it was used.
2669 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2670 Otherwise, an out-of-range integer could cause undefined behavior
2673 * composite.c: Use int, not EMACS_INT, for characters.
2674 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2675 EMACS_INT, for values that are known to be in character range.
2676 This doesn't fix any bugs but is the usual style inside Emacs and
2677 may generate better code on 32-bit machines.
2679 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2680 This is for reasons similar to the recent CHAR_STRING fix.
2681 * charset.c (Fencode_char): Check that character arg is actually
2682 a character. Pass an int to ENCODE_CHAR.
2683 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2684 wider than 'int', as a compile-time check to prevent future regressions
2687 * character.c (char_string): Remove unnecessary casts.
2689 Make sure a 64-bit char is never passed to CHAR_STRING.
2690 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2691 by silently ignoring the top 32 bits, allowing some values
2692 that were far too large to be valid characters.
2693 * character.h: Include <verify.h>.
2694 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2695 arguments are no wider than unsigned, as a compile-time check
2696 to prevent future regressions in this area.
2698 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2699 (Fsubst_char_in_region):
2701 * xdisp.c (decode_mode_spec_coding):
2702 Adjust to CHAR_STRING's new requirement.
2703 * editfns.c (Finsert_char, Fsubst_char_in_region):
2704 * fns.c (concat): Check that character args are actually
2705 characters. Without this test, these functions did the wrong
2706 thing with wildly out-of-range values on 64-bit hosts.
2708 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2709 These casts should not be needed on 32-bit hosts, either.
2710 * keyboard.c (read_char):
2711 * lread.c (Fload): Remove casts to unsigned.
2713 * lisp.h (UNSIGNED_CMP): New macro.
2714 This fixes comparison bugs on 64-bit hosts.
2715 (ASCII_CHAR_P): Use it.
2716 * casefiddle.c (casify_object):
2717 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2718 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2719 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2720 * dispextern.h (FACE_FROM_ID):
2721 * keyboard.c (read_char): Use UNSIGNED_CMP.
2723 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2724 not to EMACS_INT, to avoid GCC warning.
2726 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2728 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2729 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2730 isn't needed on 32-bit machines.
2732 * buffer.c (Fgenerate_new_buffer_name):
2733 Use EMACS_INT for count, not int.
2734 (advance_to_char_boundary): Return EMACS_INT, not int.
2736 * data.c (Qcompiled_function): Now static.
2738 * window.c (window_body_lines): Now static.
2740 * image.c (gif_load): Rename local to avoid shadowing.
2742 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2743 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2744 * alloc.c (make_save_value): Integer argument is now of type
2746 (mark_object): Use ptrdiff_t, not int.
2747 * lisp.h (pD): New macro.
2748 * print.c (print_object): Use it.
2750 * alloc.c: Use EMACS_INT, not int, to count objects.
2751 (total_conses, total_markers, total_symbols, total_vector_size)
2752 (total_free_conses, total_free_markers, total_free_symbols)
2753 (total_free_floats, total_floats, total_free_intervals)
2754 (total_intervals, total_strings, total_free_strings):
2755 Now EMACS_INT, not int. All uses changed.
2756 (Fgarbage_collect): Compute overall total using a double, so that
2757 integer overflow is less likely to be a problem. Check for overflow
2758 when converting back to an integer.
2759 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2760 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2761 These were 'int' variables that could overflow on 64-bit hosts;
2762 they were never used, so remove them instead of repairing them.
2763 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2764 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2765 Previously, this ceilinged at INT_MAX, but that doesn't work on
2767 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2769 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2770 (allocate_vectorlike): Check for ptrdiff_t overflow.
2771 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2772 when a (possibly-narrower) signed value would do just as well.
2773 We prefer using signed arithmetic, to avoid comparison confusion.
2775 * alloc.c: Catch some string size overflows that we were missing.
2776 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2777 for convenience in STRING_BYTES_MAX.
2778 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2779 The definition here is exact; the one in lisp.h was approximate.
2780 (allocate_string_data): Check for string overflow. This catches
2781 some instances we weren't catching before. Also, it catches
2782 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2783 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2784 and ptrdiff_t and EMACS_INT are both 64 bits.
2786 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2787 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2788 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2790 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2792 * alloc.c (Fmake_string): Check for out-of-range init.
2794 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2796 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2798 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2800 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2801 xg_get_default_scrollbar_width.
2803 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2804 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2805 (style_changed_cb): Call update_theme_scrollbar_width and call
2806 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2807 all frames (Bug#8505).
2808 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2809 Call gtk_window_set_resizable if HAVE_GTK3.
2810 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2811 and height if HAVE_GTK3 (Bug#8505).
2812 (scroll_bar_width_for_theme): New variable.
2813 (update_theme_scrollbar_width): New function.
2814 (xg_get_default_scrollbar_width): Move code to
2815 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2816 (xg_initialize): Call update_theme_scrollbar_width.
2818 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2820 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2822 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2824 * frame.c (make_frame): Call other_buffer_safely instead of
2827 * window.c (temp_output_buffer_show): Call display_buffer with
2828 second argument Vtemp_buffer_show_specifiers and reset latter
2829 immediately after the call.
2830 (Vtemp_buffer_show_specifiers): New variable.
2831 (auto_window_vscroll_p, next_screen_context_lines)
2832 (Vscroll_preserve_screen_position): Remove leading asterisks from
2835 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2837 Fix minor problems found by GCC 4.6.0 static checking.
2838 * buffer.c (Qclone_number): Remove for now, as it's unused.
2839 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2840 (record_buffer): Remove unused local.
2841 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2842 (set_frame_buffer_list): Remove; unused.
2843 * frame.h (other_visible_frames): Remove decl.
2844 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2845 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2846 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2848 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2849 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2850 Define only if HAVE_GPM.
2851 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2852 (update_hints_inhibit): Remove; never set. All uses removed.
2853 * widgetprv.h (emacsFrameClassRec): Remove decl.
2854 * window.c (delete_deletable_window): Now returns void, since it
2855 wasn't returning anything.
2856 (compare_window_configurations): Remove unused locals.
2857 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2858 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2859 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2860 the same widths as pointers. This follows up on the 2011-05-06 patch.
2861 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2862 * xterm.h: Likewise.
2863 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2865 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2867 * makefile.w32-in: Update dependencies.
2868 (LISP_H): Add lib/intprops.h.
2870 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2872 * image.c (gif_load): Add animation frame delay to the metadata.
2873 (syms_of_image): Use DEFSYM. New symbol `delay'.
2875 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2877 * window.c (delete_deletable_window): Re-add.
2878 (Fset_window_configuration): Rewrite to handle dead buffers and
2879 consequently deletable windows.
2880 (window_tree, Fwindow_tree): Remove. Supply functionality in
2882 (compare_window_configurations): Simplify code.
2884 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2886 * image.c (imagemagick_load_image): Fix type mismatch.
2887 (Fimagemagick_types): Likewise.
2889 * window.h (replace_buffer_in_windows): Declare.
2891 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2893 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2894 Qclone_number. Remove external declaration of Qdelete_window.
2895 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2897 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2898 Run Qbuffer_list_update_hook if allowed.
2899 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2900 buffer list implementation.
2901 (other_buffer_safely): New function.
2902 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2903 calls to replace_buffer_in_windows and
2904 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2906 (record_buffer): Inhibit quitting and rewrite using quittable
2907 functions. Run Qbuffer_list_update_hook if allowed.
2908 (Frecord_buffer, Funrecord_buffer): New functions.
2909 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2910 Move switch-to-buffer to window.el.
2911 (bury-buffer): Move to window.el.
2912 (Vbuffer_list_update_hook): New variable.
2914 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2917 * window.h (resize_frame_windows): Move up in code.
2918 (Fwindow_frame): Remove EXFUN.
2919 (replace_buffer_in_all_windows): Remove prototype.
2920 (replace_buffer_in_windows_safely): Add prototype.
2922 * window.c: Declare Qdelete_window static again. Move down
2923 declaration of select_count.
2924 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2925 (Fother_window): Move to window.el.
2926 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2927 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2928 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2930 (replace_buffer_in_windows): Implement by calling
2931 Qreplace_buffer_in_windows.
2932 (replace_buffer_in_all_windows): Remove with some functionality
2933 moved into replace_buffer_in_windows_safely.
2934 (replace_buffer_in_windows_safely): New function.
2935 (select_window_norecord, select_frame_norecord): Move in front
2936 of run_window_configuration_change_hook. Remove now obsolete
2938 (Fset_window_buffer): Rewrite doc-string.
2939 Call Qrecord_window_buffer.
2940 (keys_of_window): Move binding for other-window to window.el.
2942 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2944 * dispextern.h (struct image): Replace data member, whose int_val
2945 and ptr_val fields were not used by anything, with a single
2948 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2949 (gif_clear_image, gif_load, imagemagick_load_image)
2950 (gs_clear_image, gs_load): Callers changed.
2952 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2954 * buffer.h: Include <time.h>, for time_t.
2955 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2957 Fix minor problems found by static checking.
2959 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2961 Make identifiers static if they are not used in other modules.
2962 * data.c (Qcompiled_function, Qframe, Qvector):
2963 * image.c (QimageMagick, Qsvg):
2964 * minibuf.c (Qmetadata):
2965 * window.c (resize_window_check, resize_root_window): Now static.
2966 * window.h (resize_window_check, resize_root_window): Remove decls.
2968 * window.c (window_deletion_count, delete_deletable_window):
2970 (window_body_lines): Now static.
2971 (Fdelete_other_windows_internal): Mark vars as initialized.
2972 Make sure 'resize_failed' is initialized.
2973 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2974 (resize_window_apply): Remove unused local.
2975 * window.h (delete_deletable_window): Remove decl.
2977 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2978 (imagemagick_load_image): Fix pointer signedness problem by changing
2979 last arg from unsigned char * to char *. All uses changed.
2980 Also, fix a local for similar reasons.
2981 Remove unused locals. Remove locals to avoid shadowing.
2982 (fn_rsvg_handle_free): Remove; unused.
2983 (svg_load, svg_load_image): Fix pointer signedness problem.
2984 (imagemagick_load_image): Don't use garbage pointer image_wand.
2986 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2988 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2990 * image.c (gif_load): Fix omitted cast error introduced by
2993 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2995 * window.h (resize_proportionally, orig_total_lines)
2996 (orig_top_line): Remove from window structure.
2997 (set_window_height, set_window_width, change_window_heights)
2998 (Fdelete_window): Remove prototypes.
2999 (resize_frame_windows): Remove duplicate declaration.
3001 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3003 * window.h (resize_frame_windows, resize_window_check)
3004 (delete_deletable_window, resize_root_window)
3005 (resize_frame_windows): Declare prototypes.
3007 * window.c (resize_window_apply): Make definition be "static" to
3008 match the prototype.
3010 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3012 * window.c: Remove declarations of Qwindow_size_fixed,
3013 window_min_size_1, window_min_size_2, window_min_size,
3014 size_window, window_fixed_size_p, enlarge_window, delete_window.
3015 Remove static from declaration of Qdelete_window, it's
3016 temporarily needed by Fbury_buffer.
3017 (replace_window): Don't assign orig_top_line and
3019 (Fdelete_window, delete_window): Remove. Window deletion is
3020 handled by window.el.
3021 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3022 Replace Fdelete_window calls with calls to Qdelete_window.
3023 (Fdelete_other_windows): Remove. Deleting other windows is
3024 handled by window.el.
3025 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3026 handled in window.el.
3027 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3028 Window minimum sizes are handled in window.el.
3029 (shrink_windows, size_window, set_window_height)
3030 (set_window_width, change_window_heights, window_height)
3031 (window_width, CURBEG, CURSIZE, enlarge_window)
3032 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3033 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3034 handled in window.el.
3035 (make_dummy_parent): Rename to make_parent_window and give it a
3036 second argument horflag.
3037 (make_window): Don't set resize_proportionally any more.
3038 (Fsplit_window): Remove. Windows are split in window.el.
3039 (save_restore_action, save_restore_orig_size)
3040 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3041 Resize mini windows in window.el.
3042 (grow_mini_window, shrink_mini_window): Implement by calling
3043 Qresize_root_window_vertically, resize_window_check and
3044 resize_window_apply.
3045 (saved_window, Fset_window_configuration, save_window_save):
3046 Do not handle orig_top_line, orig_total_lines, and
3047 resize_proportionally.
3048 (window_min_height, window_min_width): Move to window.el.
3049 (keys_of_window): Move bindings for delete-other-windows,
3050 split-window, delete-window and enlarge-window to window.el.
3052 * buffer.c: Temporarily extern Qdelete_window.
3053 (Fbury_buffer): Temporarily call Qdelete_window instead of
3054 Fdelete_window (Fbury_buffer will move to window.el soon).
3056 * frame.c (set_menu_bar_lines_1): Remove code handling
3057 orig_top_line and orig_total_lines.
3059 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3060 set_window_height but set heights directly.
3061 (change_frame_size_1): Use resize_frame_windows.
3063 * xdisp.c (init_xdisp): Don't use set_window_height but set
3066 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3067 Use resize_frame_windows instead of change_window_heights and run
3068 run_window_configuration_change_hook.
3070 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3071 instead of change_window_heights and run
3072 run_window_configuration_change_hook.
3074 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3076 * window.c (replace_window): Rename second argument REPLACEMENT to
3077 NEW. New third argument SETFLAG. Rewrite.
3078 (delete_window, make_dummy_parent): Call replace_window with
3080 (window_list_1): Move down in code.
3081 (run_window_configuration_change_hook): Move set_buffer part
3082 before select_frame_norecord part in order to unwind correctly.
3083 Rename count1 to count.
3084 (recombine_windows, delete_deletable_window, resize_root_window)
3085 (Fdelete_other_windows_internal)
3086 (Frun_window_configuration_change_hook, make_parent_window)
3087 (resize_window_check, resize_window_apply, Fresize_window_apply)
3088 (resize_frame_windows, Fsplit_window_internal)
3089 (Fdelete_window_internal, Fresize_mini_window_internal):
3091 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3093 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3095 * window.h (window): Add some new members to window structure -
3096 normal_lines, normal_cols, new_total, new_normal, clone_number,
3097 splits, nest, prev_buffers, next_buffers.
3098 (WINDOW_TOTAL_SIZE): Move here from window.c.
3099 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3101 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3103 (make_dummy_parent): Set new members of windows structure.
3104 (make_window): Move down in code. Handle new members of window
3106 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3107 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3108 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3109 (Fset_window_prev_buffers, Fwindow_next_buffers)
3110 (Fset_window_next_buffers, Fset_window_clone_number):
3112 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3113 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3115 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3116 Argument WINDOW can be now internal window too.
3117 (Fwindow_use_time): Move up in code.
3118 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3120 (Fset_window_configuration, saved_window)
3121 (Fcurrent_window_configuration, save_window_save): Handle new
3122 members of window structure.
3123 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3124 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3125 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3126 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3127 Qget_mru_window, Qresize_root_window,
3128 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3129 Qauto_buffer_name; staticpro them.
3131 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3133 * window.c (Fwindow_total_size, Fwindow_left_column)
3134 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3135 (Fwindow_list_1): New functions.
3136 (window_box_text_cols): Replace with window_body_cols.
3137 (Fwindow_width, Fscroll_left, Fscroll_right):
3138 Use window_body_cols instead of window_box_text_cols.
3139 (delete_window, Fset_window_configuration):
3140 Call delete_all_subwindows with window as argument.
3141 (delete_all_subwindows): Take a window as argument and not a
3143 (window_loop): Remove handling of GET_LRU_WINDOW and
3145 (Fget_lru_window, Fget_largest_window): Move to window.el.
3147 * window.h: Extern window_body_cols instead of
3148 window_box_text_cols. delete_all_subwindows now takes a
3149 Lisp_Object as argument.
3151 * indent.c (compute_motion, Fcompute_motion):
3152 Use window_body_cols instead of window_box_text_cols.
3154 * frame.c (delete_frame): Call delete_all_subwindows with root
3157 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3159 * fns.c (Fputhash): Document return value.
3161 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3163 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3165 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3167 Cons<->int and similar integer overflow fixes (Bug#8794).
3169 Check for overflow when converting integer to cons and back.
3170 * charset.c (Fdefine_charset_internal, Fdecode_char):
3171 Use cons_to_unsigned to catch overflow.
3172 (Fencode_char): Use INTEGER_TO_CONS.
3173 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3174 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3175 * data.c (long_to_cons, cons_to_long): Remove.
3176 (cons_to_unsigned, cons_to_signed): New functions.
3177 These signal an error for invalid or out-of-range values.
3178 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3179 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3180 * font.c (Ffont_variation_glyphs):
3181 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3182 * lisp.h: Include <intprops.h>.
3183 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3184 (cons_to_signed, cons_to_unsigned): New decls.
3185 (long_to_cons, cons_to_long): Remove decls.
3186 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3187 (Fprimitive_undo): Use CONS_TO_INTEGER.
3188 * xfns.c (Fx_window_property): Likewise.
3189 * xselect.c: Include <limits.h>.
3190 (x_own_selection, selection_data_to_lisp_data):
3191 Use INTEGER_TO_CONS.
3192 (x_handle_selection_request, x_handle_selection_clear)
3193 (x_get_foreign_selection, Fx_disown_selection_internal)
3194 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3195 (lisp_data_to_selection_data): Use cons_to_unsigned.
3196 (x_fill_property_data): Use cons_to_signed.
3197 Report values out of range.
3199 Check for buffer and string overflow more precisely.
3200 * buffer.h (BUF_BYTES_MAX): New macro.
3201 * lisp.h (STRING_BYTES_MAX): New macro.
3202 * alloc.c (Fmake_string):
3203 * character.c (string_escape_byte8):
3204 * coding.c (coding_alloc_by_realloc):
3205 * doprnt.c (doprnt):
3206 * editfns.c (Fformat):
3208 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3209 since they may not be the same number.
3210 * editfns.c (Finsert_char):
3211 * fileio.c (Finsert_file_contents):
3212 Likewise for BUF_BYTES_MAX.
3214 * image.c: Use ptrdiff_t, not int, for sizes.
3215 (slurp_file): Switch from int to ptrdiff_t.
3217 (slurp_file): Check that file size fits in both size_t (for
3218 malloc) and ptrdiff_t (for sanity and safety).
3220 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3221 if b->modtime has its maximal value.
3223 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3225 Don't assume time_t can fit into int.
3226 * buffer.h (struct buffer.modtime): Now time_t, not int.
3227 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3228 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3230 Minor fixes for signed vs unsigned integers.
3231 * character.h (MAYBE_UNIFY_CHAR):
3232 * charset.c (maybe_unify_char):
3233 * keyboard.c (read_char, reorder_modifiers):
3234 XINT -> XFASTINT, since the integer must be nonnegative.
3235 * ftfont.c (ftfont_spec_pattern):
3236 * keymap.c (access_keymap, silly_event_symbol_error):
3237 XUINT -> XFASTINT, since the integer must be nonnegative.
3238 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3239 since it makes no difference and we prefer signed.
3240 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3241 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3244 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3246 * window.h (Fwindow_frame): Declare.
3248 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3250 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3251 (SPARE_MEMORY): Always define.
3252 (LARGE_REQUEST): Remove.
3253 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3255 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3257 * lisp.h: Move EXFUNS for Fframe_root_window,
3258 Fframe_first_window and Fset_frame_selected_window to window.h.
3260 * window.h: Move EXFUNS for Fframe_root_window,
3261 Fframe_first_window and Fset_frame_selected_window here from
3264 * frame.c (Fwindow_frame, Fframe_first_window)
3265 (Fframe_root_window, Fframe_selected_window)
3266 (Fset_frame_selected_window): Move to window.c.
3267 (Factive_minibuffer_window): Move to minibuf.c.
3268 (Fother_visible_frames_p): New function.
3270 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3272 * window.c (decode_window, decode_any_window): Move up in code.
3273 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3274 (inhibit_frame_unsplittable): Remove unused variable.
3275 (Fwindow_buffer): Move up and rewrite doc-string.
3276 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3277 (Fwindow_prev): New functions.
3278 (Fwindow_frame): Move here from frame.c. Accept any window as
3280 (Fframe_root_window, Fframe_first_window)
3281 (Fframe_selected_window): Move here from frame.c. Accept frame
3282 or arbitrary window as argument. Update doc-strings.
3283 (Fminibuffer_window): Move up in code.
3284 (Fwindow_minibuffer_p): Move up in code and simplify.
3285 (Fset_frame_selected_window): Move here from frame.c.
3287 (Fselected_window, select_window, Fselect_window): Move up in
3288 code. Minor doc-string fixes.
3290 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3292 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3293 Do not assume that spare memory exists; that assumption is valid
3294 only if SYSTEM_MALLOC.
3295 (LARGE_REQUEST): New macro, so that the issue of large requests
3296 is separated from the issue of spare memory.
3298 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3300 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3303 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3305 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3308 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3310 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3312 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3314 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3315 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3317 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3319 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3321 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3323 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3324 (x_clipboard_manager_save): Add return value.
3325 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3327 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3328 Obey Vx_select_enable_clipboard_manager. Catch errors in
3329 x_clipboard_manager_save (Bug#8779).
3330 (Vx_select_enable_clipboard_manager): New variable.
3331 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3333 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3335 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3337 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3339 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3340 in the current matrix if keep_current_p is non-zero.
3342 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3344 * bidi.c (bidi_level_of_next_char): Fix last change.
3346 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3348 Support bidi reordering of text covered by display properties.
3350 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3351 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3352 (bidi_cache_search, bidi_cache_iterator_state)
3353 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3354 (bidi_level_of_next_char, bidi_move_to_visually_next):
3355 Support character positions inside a run of characters covered by a
3357 (bidi_paragraph_init, bidi_resolve_explicit_1)
3358 (bidi_level_of_next_char): Call bidi_fetch_char and
3359 bidi_fetch_char_advance instead of FETCH_CHAR and
3361 (bidi_init_it): Initialize new members.
3362 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3364 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3365 instead of using explicit *_CHAR codes.
3366 (bidi_resolve_explicit, bidi_resolve_weak):
3367 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3368 bidirectional text is supported only in multibyte buffers.
3369 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3370 it to initialize the frame_window_p member of struct bidi_it.
3371 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3372 (bidi_resolve_explicit, bidi_resolve_weak)
3373 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3374 bidi_it->nchars is non-positive.
3375 (bidi_level_of_next_char): Don't try to lookup the cache for the
3376 next/previous character if nothing is cached there yet, or if we
3377 were just reseat()'ed to a new position.
3379 * xdisp.c (set_cursor_from_row): Set start and stop points
3380 according to the row's direction when priming the loop that looks
3381 for the glyph on which to display cursor.
3382 (single_display_spec_intangible_p): Function deleted.
3383 (display_prop_intangible_p): Reimplement to call
3384 handle_display_spec instead of single_display_spec_intangible_p.
3385 Accept 3 additional arguments needed by handle_display_spec.
3386 This fixes incorrect cursor motion across display property with complex
3387 values: lists, `(when COND...)' forms, etc.
3388 (single_display_spec_string_p): Support property values that are
3389 lists with the argument STRING its top-level element.
3390 (display_prop_string_p): Fix the condition for processing a
3391 property that is a list to be consistent with handle_display_spec.
3392 (handle_display_spec): New function, refactored from the
3393 last portion of handle_display_prop.
3394 (compute_display_string_pos): Accept additional argument
3395 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3396 value of a `display' property is a "replacing spec".
3397 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3398 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3399 the display property, but just return a value indicating whether
3400 the display property will replace the characters it covers.
3401 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3402 frame_window_p members of struct bidi_it.
3403 (compute_display_string_pos, compute_display_string_end):
3405 (push_it): Accept second argument POSITION, where pop_it should
3406 jump to continue iteration.
3407 (reseat_1): Initialize bidi_it.disp_pos.
3409 * keyboard.c (adjust_point_for_property): Adjust the call to
3410 display_prop_intangible_p to its new signature.
3412 * dispextern.h (struct bidi_it): New member frame_window_p.
3413 (bidi_init_it): Update prototypes.
3414 (display_prop_intangible_p): Update prototype.
3415 (compute_display_string_pos, compute_display_string_end):
3417 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3420 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3422 Malloc failure behavior now depends on size of allocation.
3423 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3424 * lisp.h: Change signatures accordingly.
3425 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3426 All callers changed. (Bug#8762)
3428 * gnutls.c: Use Emacs's memory allocators.
3429 Without this change, the gnutls library would invoke malloc etc.
3430 directly, which causes problems on non-SYNC_INPUT hosts, and which
3431 runs afoul of improving memory_full behavior. (Bug#8761)
3432 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3433 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3434 xfree instead of the default malloc, realloc, free.
3435 (Fgnutls_boot): No need to check for memory allocation failure,
3436 since xmalloc does that for us.
3438 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3439 * category.c (hash_get_category_set):
3440 * ccl.c (ccl_driver):
3441 * charset.c (Fdefine_charset_internal):
3442 * charset.h (struct charset.hash_index):
3443 * composite.c (get_composition_id, gstring_lookup_cache)
3444 (composition_gstring_put_cache):
3445 * composite.h (struct composition.hash_index):
3446 * dispextern.h (struct image.hash):
3447 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3448 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3449 (hashfn_equal, hashfn_user_defined, make_hash_table)
3450 (maybe_resize_hash_table, hash_lookup, hash_put)
3451 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3452 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3453 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3454 * image.c (make_image, search_image_cache, lookup_image)
3455 (xpm_put_color_table_h):
3456 * lisp.h (struct Lisp_Hash_Table):
3457 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3458 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3459 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3460 * alloc.c (allocate_vectorlike):
3461 Check for overflow in vector size calculations.
3462 * ccl.c (ccl_driver):
3463 Check for overflow when converting EMACS_INT to int.
3464 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3465 need to be updated by these changes.
3466 * fns.c (make_hash_table, maybe_resize_hash_table):
3467 Check for integer overflow with large hash tables.
3468 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3469 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3470 (SXHASH_REDUCE): New macro.
3471 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3472 Use it instead of discarding useful hash info with large hash values.
3473 (sxhash_float): New function.
3474 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3475 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3476 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3477 Rewrite to use FIXNUM_BITS, as this simplifies things.
3478 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3479 Adjust signatures to match updated version of code.
3480 (consing_since_gc): Now EMACS_INT, since a single hash table can
3481 use more than INT_MAX bytes.
3483 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3485 Make it possible to build with GCC-4.6+ -O2 -flto.
3487 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3489 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3491 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3492 Call minibuffer-inactive-mode.
3494 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3496 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3497 Update dependencies.
3499 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3501 * data.c (init_data): Remove code for UTS, this system is not
3504 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3506 Don't force ./temacs to start in terminal mode.
3508 * frame.c (make_initial_frame): Initialize faces in all cases, not
3509 only when CANNOT_DUMP is defined.
3510 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3512 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3514 * dispnew.c (add_window_display_history): Use const for the string
3515 pointer. Remove declaration, not needed.
3517 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3519 Use 'inline', not 'INLINE'.
3520 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3521 * alloc.c, fontset.c (INLINE): Remove.
3522 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3523 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3524 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3525 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3526 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3528 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3530 Make it possible to run ./temacs.
3532 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3533 syms_of_callproc does the same thing. Remove test for
3534 "initialized", do it in the caller.
3535 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3537 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3539 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3540 (read_minibuf): Use get_minibuffer.
3541 (syms_of_minibuf): Use DEFSYM.
3542 (Qmetadata): New var.
3543 * data.c (Qbuffer): Don't make it static.
3544 (syms_of_data): Use DEFSYM.
3546 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3548 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3549 (CCL_CODE_MIN): New macro.
3551 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3553 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3555 * eval.c (Qdebug): Now static.
3556 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3557 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3558 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3560 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3562 * image.c: Various fixes to ImageMagick code comments.
3563 (Fimagemagick_types): Doc fix.
3565 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3567 Minor fixes prompted by GCC 4.6.0 warnings.
3569 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3571 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3572 (x_clipboard_manager_save_all): Move extern decl to ...
3573 * xterm.h: ... here, so that it can be checked for consistency.
3575 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3577 * xselect.c (x_clipboard_manager_save_frame)
3578 (x_clipboard_manager_save_all): New functions.
3579 (Fx_clipboard_manager_save): Lisp function deleted.
3581 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3582 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3584 * xterm.h: Update prototype.
3586 2011-05-28 William Xu <william.xwl@gmail.com>
3588 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3591 2011-05-28 Jim Meyering <meyering@redhat.com>
3593 Avoid a sign-extension bug in crypto_hash_function.
3594 * fns.c (to_uchar): Define.
3595 (crypto_hash_function): Use it to convert some newly-signed
3596 variables to unsigned, to avoid sign-extension bugs. For example,
3597 without this change, (md5 "truc") would evaluate to
3598 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3599 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3600 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3602 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3604 Integer overflow fixes.
3606 * dbusbind.c: Serial number integer overflow fixes.
3607 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3608 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3609 to hold a serial number that is too large for a fixnum.
3610 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3611 Check for serial numbers out of range. Decode any serial number
3612 that was so large that it became a float. (Bug#8722)
3614 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3615 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3616 Use XFASTINT rather than XUINT when numbers are nonnegative.
3617 (xd_append_arg, Fdbus_method_return_internal):
3618 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3619 arguments, check that Lisp number is nonnegative, rather than
3620 silently wrapping negative numbers around. (Bug#8722)
3621 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3624 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3626 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3628 ccl: add integer overflow checks
3629 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3630 (IN_INT_RANGE): New macros.
3631 (ccl_driver): Use them to check for integer overflow when
3632 decoding a CCL program. Many of the new checks are whether XINT (x)
3633 fits in int; it doesn't always, on 64-bit hosts. The new version
3634 doesn't catch all possible integer overflows, but it's an
3635 improvement. (Bug#8719)
3637 * alloc.c (make_event_array): Use XINT, not XUINT.
3638 There's no need for unsigned here.
3640 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3641 This follows up to the 2011-05-06 change that substituted uintptr_t
3642 for EMACS_INT. This case wasn't caught back then.
3644 Rework Fformat to avoid integer overflow issues.
3645 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3646 now (part of C89). Include <verify.h>.
3647 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3648 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3649 (Fformat): Avoid the prepass trying to compute sizes; it was only
3650 approximate and thus did not catch overflow reliably. Instead, walk
3651 through the format just once, formatting and computing sizes as we go,
3652 checking for integer overflow at every step, and allocating a larger
3653 buffer as needed. Keep track separately whether the format is
3654 multibyte. Keep only the most-recently calculated precision, rather
3655 than them all. Record whether each argument has been converted to
3656 string. Use EMACS_INT, not int, for byte and char and arg counts.
3657 Support field widths and precisions larger than INT_MAX. Avoid
3658 sprintf's undefined behavior with conversion specifications such as %#d
3659 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3660 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3661 formatting out-of-range floating point numbers with int
3664 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3666 * data.c: Avoid integer truncation in expressions involving floats.
3667 * data.c: Include <intprops.h>.
3668 (arith_driver): When there's an integer overflow in an expression
3669 involving floating point, convert the integers to floating point
3670 so that the resulting value does not suffer from catastrophic
3671 integer truncation. For example, on a 64-bit host (* 4
3672 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3673 Do not rely on undefined behavior after integer overflow.
3675 merge count_size_as_multibyte, parse_str_to_multibyte
3676 * character.c, character.h (count_size_as_multibyte):
3677 Rename from parse_str_to_multibyte; all uses changed.
3678 Check for integer overflow.
3679 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3680 since it's now a duplicate of the other. This is more of
3681 a character than a buffer op, so better that it's in character.c.
3682 * fns.c, print.c: Adjust to above changes.
3684 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3686 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3688 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3690 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3691 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3692 (x_clipboard_manager_save): Now static.
3693 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3695 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3696 (crypto_hash_function): Now static.
3697 Fix pointer signedness problems. Avoid unnecessary initializations.
3699 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3701 * termhooks.h (Vselection_alist): Make it terminal-local.
3703 * terminal.c (create_terminal): Initialize it.
3705 * xselect.c: Support for clipboard managers.
3706 (Vselection_alist): Move to termhooks.h as terminal-local var.
3707 (LOCAL_SELECTION): New macro.
3708 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3709 (symbol_to_x_atom): Remove gratuitous arg.
3710 (x_handle_selection_request, lisp_data_to_selection_data)
3711 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3712 (x_own_selection, x_get_local_selection, x_convert_selection):
3713 New arg, specifying work frame. Use terminal-local Vselection_alist.
3714 (some_frame_on_display): Delete unused function.
3715 (Fx_own_selection_internal, Fx_get_selection_internal)
3716 (Fx_disown_selection_internal, Fx_selection_owner_p)
3717 (Fx_selection_exists_p): New optional frame arg.
3718 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3719 (x_handle_selection_clear): Don't treat other terminals with the
3720 same keyboard specially. Use the terminal-local Vselection_alist.
3721 (x_clear_frame_selections): Use Frun_hook_with_args.
3723 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3725 * xterm.h: Add support for those atoms.
3727 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3729 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3730 (converted_selections, conversion_fail_tag): New global variables.
3731 (x_selection_request_lisp_error): Free the above.
3732 (x_get_local_selection): Remove unnecessary code.
3733 (x_reply_selection_request): Args changed; handle arbitrary array
3734 of converted selections stored in converted_selections.
3735 Separate the XChangeProperty and SelectionNotify steps.
3736 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3737 (x_convert_selection): New function.
3738 (x_handle_selection_event): Simplify.
3739 (x_get_foreign_selection): Don't ignore incoming requests while
3740 waiting for an answer; this will fail when we implement
3741 SAVE_TARGETS, and seems unnecessary anyway.
3742 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3743 (Vx_sent_selection_functions): Doc fix.
3745 2011-05-26 Leo Liu <sdl.web@gmail.com>
3747 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3749 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3751 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3753 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3754 for fringe update if it has periodic bitmap.
3755 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3756 and fringe_bitmap_periodic_p.
3758 * fringe.c (get_fringe_bitmap_data): New function.
3759 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3760 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3761 row. Mark glyph row for fringe update if periodicity changed.
3763 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3764 for fringe update unless it has periodic bitmap.
3766 2011-05-25 Kenichi Handa <handa@m17n.org>
3768 * xdisp.c (get_next_display_element): Set correct it->face_id for
3769 a static composition.
3771 2011-05-24 Leo Liu <sdl.web@gmail.com>
3774 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3776 * fns.c (crypto_hash_function, Fsha1): New function.
3777 (Fmd5): Use crypto_hash_function.
3778 (syms_of_fns): Add Ssha1.
3780 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3782 * gnutls.c: Remove unused macros.
3783 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3784 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3785 Remove macros that are defined and never used.
3786 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3788 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3790 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3791 (Fx_get_selection_internal): Minor cleanup.
3792 (Fx_own_selection_internal): Rename arguments for consistency with
3795 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3797 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3799 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3801 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3803 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3805 * dispnew.c (scrolling_window): Don't exclude the case that the
3806 last enabled row in the desired matrix touches the bottom boundary.
3808 2011-05-21 Glenn Morris <rgm@gnu.org>
3810 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3811 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3812 and add some more files.
3814 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3816 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3817 report_file_error introduced by the change from 2011-05-07.
3819 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3821 * systime.h (Time): Define only if emacs is defined.
3822 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3823 where the include path doesn't have X11/X.h by default. See
3824 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3826 2011-05-20 Kenichi Handa <handa@m17n.org>
3828 * composite.c (find_automatic_composition): Fix previous change.
3830 2011-05-20 Glenn Morris <rgm@gnu.org>
3832 * lisp.mk: New file, split from Makefile.in.
3833 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3834 (shortlisp): Remove.
3835 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3837 2011-05-19 Glenn Morris <rgm@gnu.org>
3839 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3840 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3841 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3842 (lisp): Set the order to that of loadup.el.
3843 (shortlisp): Make it a copy of $lisp.
3844 (SOME_MACHINE_LISP): Remove.
3845 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3846 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3848 2011-05-18 Kenichi Handa <handa@m17n.org>
3850 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3851 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3852 (find_automatic_composition): Mostly rewrite for efficiency.
3854 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3856 * makefile.w32-in: Update dependencies.
3858 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3860 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3861 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3863 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3865 Fix some integer overflow issues, such as string length overflow.
3867 * insdel.c (count_size_as_multibyte): Check for string overflow.
3869 * character.c (lisp_string_width): Check for string overflow.
3870 Use EMACS_INT, not int, for string indexes and lengths; in
3871 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3872 the resulting string length overflows an EMACS_INT; instead,
3873 report a string overflow if no precision given. When checking for
3874 precision exhaustion, use a check that cannot possibly have
3875 integer overflow. (Bug#8675)
3876 * character.h (lisp_string_width): Adjust to new signature.
3878 * alloc.c (string_overflow): New function.
3879 (Fmake_string): Use it. This doesn't change behavior, but saves
3880 a few bytes and will simplify future changes.
3881 * character.c (string_escape_byte8): Likewise.
3882 * lisp.h (string_overflow): New decl.
3884 Fixups, following up to the user-interface timestamp change.
3885 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3886 for UI timestamps, instead of unsigned long.
3887 * msdos.c (mouse_get_pos): Likewise.
3888 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3889 * w32gui.h (Time): Define by including "systime.h" rather than by
3890 declaring it ourselves. (Bug#8664)
3892 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3893 * image.c (clear_image_cache): Likewise.
3895 * term.c (term_mouse_position): Don't assume time_t wraparound.
3897 Be more systematic about user-interface timestamps.
3898 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3899 and sometimes 'EMACS_UINT', to represent these timestamps.
3900 This change causes it to use 'Time' uniformly, as that's what X uses.
3901 This makes the code easier to follow, and makes it easier to catch
3902 integer overflow bugs such as Bug#8664.
3903 * frame.c (Fmouse_position, Fmouse_pixel_position):
3904 Use Time, not unsigned long, for user-interface timestamps.
3905 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3906 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3907 * keyboard.h (last_event_timestamp): Likewise.
3908 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3909 * menu.h (xmenu_show): Likewise.
3910 * term.c (term_mouse_position): Likewise.
3911 * termhooks.h (struct input_event.timestamp): Likewise.
3912 (struct terminal.mouse_position_hook): Likewise.
3913 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3914 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3915 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3916 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3918 * menu.h, termhooks.h: Include "systime.h", for Time.
3920 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3921 Don't assume that the difference between two unsigned long values
3922 can fit into an integer. At this point, we know button_down_time
3923 <= event->timestamp, so the difference must be nonnegative, so
3924 there's no need to cast the result if double-click-time is
3925 nonnegative, as it should be; check that it's nonnegative, just in
3926 case. This bug is triggered when events are more than 2**31 ms
3927 apart (about 25 days). (Bug#8664)
3929 * xselect.c (last_event_timestamp): Remove duplicate decl.
3930 (x_own_selection): Remove needless cast to unsigned long.
3932 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3933 that always fit in int. Use a sentinel instead of a counter, to
3934 avoid a temp and to allay GCC's concerns about possible int overflow.
3935 * frame.h (struct frame): Use int for menu_bar_items_used
3936 instead of EMACS_INT, since it always fits in int.
3938 * menu.c (grow_menu_items): Check for int overflow.
3940 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3942 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3943 Before, the code was not consistent. These values cannot exceed
3944 2**31 - 1 so there's no need to make them unsigned.
3945 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3946 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3947 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3949 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3951 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3952 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3953 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3954 presumably because the widths might not match.
3956 * window.c (size_window): Avoid needless test at loop start.
3958 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3960 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3962 2011-05-12 Drew Adams <drew.adams@oracle.com>
3964 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3966 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3968 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3969 `width' to `bar_area_x' and `bar_area_width', respectively.
3970 (x_scroll_run): Take account of fringe background extension.
3972 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3973 Rename local vars `left' and `width' to `bar_area_x' and
3974 `bar_area_width', respectively.
3975 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3976 background extension.
3978 2011-05-10 Jim Meyering <meyering@redhat.com>
3980 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3982 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3984 * image.c (Finit_image_library): Return t for built-in image types,
3985 like pbm and xbm. (Bug#8640)
3987 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3989 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3991 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3993 * w32console.c (Fset_screen_color): Doc fix.
3994 (Fget_screen_color): New function.
3995 (syms_of_ntterm): Defsubr it.
3997 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3998 unlink the temporary file if Fcall_process didn't create it in the
4000 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4001 child process will be redirected to a file specified with `:file'.
4002 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4003 cue to call_process_cleanup not to close that handle.
4005 2011-05-07 Ben Key <bkey76@gmail.com>
4007 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4008 one of two shell specific rules, either bootstrap-temacs-CMD or
4009 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4010 to the previous implementation of the bootstrap-temacs rule.
4011 The bootstrap-temacs-CMD rule is similar to the previous
4012 implementation of the bootstrap-temacs rule except that it
4013 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4016 These changes, along with some changes to nt/configure.bat,
4017 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4018 earlier fix to add support for --cflags and --ldflags options
4019 that include quotes so that it works whether make uses cmd or
4022 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4024 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4025 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4027 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4028 a string. Handle both cases.
4029 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4030 (Fdbus_register_method): Use Qinvalid_function.
4032 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4034 * makefile.w32-in: Update dependencies.
4035 (LISP_H): Add inttypes.h and stdin.h.
4036 (PROCESS_H): Add unistd.h.
4038 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4040 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4041 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4043 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4045 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4047 * term.c (vfatal): Remove stray call to va_end.
4048 It's not needed and the C Standard doesn't allow it here anyway.
4050 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4051 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4053 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4056 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4058 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4060 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4062 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4064 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4066 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4067 * charset.c (Fdefine_charset_internal): Don't initialize
4068 charset.code_space[15]. The value was garbage, on hosts with
4069 32-bit int (Bug#8600).
4071 * lread.c (read_integer): Be more consistent with string-to-number.
4072 Use string_to_number to do the actual conversion; this avoids
4073 rounding errors and fixes some other screwups. Without this fix,
4074 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4075 (digit_to_number): Move earlier, for benefit of read_integer.
4076 Return -1 if the digit is out of range for the base, -2 if it is
4077 not a digit in any supported base. (Bug#8602)
4079 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4081 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4082 to match comment at start of function. This also removes a
4083 GCC warning about overflow in a 32+64-bit port.
4085 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4087 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4088 Reported by Stefan Monnier in
4089 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4090 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4091 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4093 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4094 (EMACS_UINTPTR): Likewise, with uintptr_t.
4096 * lisp.h: Prefer 64-bit EMACS_INT if available.
4097 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4098 on 32-bit hosts that have 64-bit int, so that they can access
4100 However, temporarily disable this change unless the temporary
4101 symbol WIDE_EMACS_INT is defined.
4103 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4105 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4106 This removes an assumption that EMACS_INT and long are the same
4107 width as pointers. The assumption is true for Emacs porting targets
4108 now, but we want to make other targets possible.
4109 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4110 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4111 In the rest of the code, change types of integers that hold casted
4112 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4113 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4114 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4115 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4116 No need to cast type when ORing.
4117 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4118 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4119 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4120 assume EMACS_INT is the same width as char *.
4121 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4122 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4123 Remove no-longer-needed casts.
4124 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4125 (xg_tool_bar_help_callback, xg_make_tool_item):
4126 Use EMACS_INTPTR to hold an integer
4127 that will be cast to void *; this can avoid a GCC warning
4128 if EMACS_INT is not the same width as void *.
4129 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4130 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4131 (current_message_1, set_message_1):
4132 Use a local to convert to proper width without a cast.
4133 * xmenu.c (dialog_selection_callback): Likewise.
4135 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4136 Also, don't assume VALBITS / RAND_BITS is less than 5,
4137 and don't rely on undefined behavior when shifting a 1 left into
4139 * lisp.h (get_random): Change signature to match.
4141 * lread.c (hash_string): Use size_t, not int, for hash computation.
4142 Normally we prefer signed values; but hashing is special, because
4143 it's better to use unsigned division on hash table sizes so that
4144 the remainder is nonnegative. Also, size_t is the natural width
4145 for hashing into memory. The previous code used 'int', which doesn't
4146 retain enough info to hash well into very large tables.
4147 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4149 * dbusbind.c: Don't possibly lose pointer info when converting.
4150 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4151 Use XPNTR rather than XHASH, so that the high-order bits of
4152 the pointer aren't lost when converting through void *.
4154 * eval.c (Fautoload): Don't double-shift a pointer.
4156 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4158 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4160 * gnutls.c (DEF_GNUTLS_FN):
4161 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4163 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4165 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4168 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4170 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4171 New version that can reserve upto 2GB of heap space.
4173 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4175 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4177 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4179 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4180 `gnutls_certificate_set_x509_key_file'.
4182 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4184 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4185 Update dependencies.
4187 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4189 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4190 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4191 Remove unused parameter `fildes'.
4192 * process.c (read_process_output, send_process): Don't pass it.
4194 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4196 Fix previous change: the library cache is defined in w32.c.
4197 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4198 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4200 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4202 Implement dynamic loading of GnuTLS on Windows.
4204 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4205 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4206 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4209 * gnutls.c (Qgnutls_dll): Define.
4210 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4211 (gnutls_*): Declare function pointers.
4212 (init_gnutls_functions): New function to initialize function pointers.
4213 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4214 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4215 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4216 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4217 (emacs_gnutls_write, emacs_gnutls_read)
4218 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4219 (Fgnutls_available_p): New function.
4220 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4221 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4222 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4224 * image.c: Include w32.h.
4225 (Vimage_type_cache): Delete.
4226 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4227 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4228 (w32_delayed_load): Move to w32.c.
4230 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4232 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4233 (w32_delayed_load): Move from image.c. When loading a library, record
4234 its filename in the :loaded-from property of the library id.
4235 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4236 Initialize and staticpro them.
4237 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4239 * process.c: Include lisp.h before w32.h, not after.
4240 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4241 instead of gnutls_record_check_pending.
4243 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4245 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4247 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4248 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4251 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4253 * xterm.c (x_set_frame_alpha): Do not set property on anything
4254 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4256 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4258 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4260 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4262 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4263 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4264 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4265 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4266 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4267 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4268 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4269 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4270 (Qgnutls_bootprop_callbacks_verify): Make static.
4272 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4274 * callproc.c: Indentation fixup.
4276 * sysdep.c (wait_for_termination_1): Make static.
4277 (wait_for_termination, interruptible_wait_for_termination):
4278 Move after wait_for_termination_1.
4280 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4282 * sysdep.c (interruptible_wait_for_termination): New function
4283 which is like wait_for_termination, but allows keyboard
4286 * callproc.c (Fcall_process): Add (:file "file") as an option for
4288 (Fcall_process_region): Ditto.
4290 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4292 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4293 rather than `XVECTOR (FOO)->size'.
4295 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4296 inttypes.h, as a gnulib replacement is used if it not available in
4299 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4301 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4302 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4303 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4305 * coding.c (coding_alloc_by_realloc): Error out if destination
4306 will grow beyond MOST_POSITIVE_FIXNUM.
4307 (decode_coding_emacs_mule): Abort if there isn't enough place in
4308 charbuf for the composition carryover bytes. Reserve an extra
4309 space for up to 2 characters produced in a loop.
4310 (decode_coding_iso_2022): Abort if there isn't enough place in
4311 charbuf for the composition carryover bytes.
4313 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4315 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4316 aborting when %lld or %lll format is passed.
4317 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4318 %llo or %llx format is passed. (Bug#8545)
4320 * window.c (window_scroll_line_based): Use a marker instead of
4321 simple variables to record original value of point. (Bug#7952)
4323 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4324 produced by %s or %c overflows available buffer space. (Bug#8545)
4326 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4328 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4329 (SIZE_MAX): Move defn after all includes, as they might #define it.
4331 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4333 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4335 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4337 * keyboard.c (Qdelayed_warnings_hook): Define.
4338 (command_loop_1): Run `delayed-warnings-hook'
4339 if Vdelayed_warnings_list is non-nil.
4340 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4341 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4343 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4345 * doprnt.c (doprnt): Don't return value smaller than the buffer
4346 size if the message was truncated. (Bug#8545).
4348 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4350 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4351 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4353 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4355 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4357 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4359 * makefile.w32-in: Update dependencies.
4361 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4363 Improve `doprnt' and its usage. (Bug#8545)
4364 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4365 `format_end'. Remove support for %l as a conversion specifier.
4366 Don't use xrealloc. Improve diagnostics when the %l size modifier
4367 is used. Update the commentary.
4369 * eval.c (verror): Simplify calculation of size_t.
4371 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4374 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4376 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4379 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4381 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4382 This makes this file independent of the recent pseudovector change.
4384 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4386 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4388 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4389 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4390 Remove unused local.
4391 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4393 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4394 GCC 4.6.0 optimizes based on type-based alias analysis.
4395 For example, if b is of type struct buffer * and v of type struct
4396 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4397 != &v->size, and therefore "v->size = 1; b->size = 2; return
4398 v->size;" must therefore return 1. This assumption is incorrect
4399 for Emacs, since it type-puns struct Lisp_Vector * with many other
4400 types. To fix this problem, this patch adds a new type struct
4401 vectorlike_header that documents the constraints on layout of vectors
4402 and pseudovectors, and helps optimizing compilers not get fooled
4403 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4404 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4405 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4407 (XSETPVECTYPE): Rewrite in terms of new macro.
4408 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4409 This is a bit clearer, and further avoids the possibility of
4410 undesirable aliasing.
4411 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4412 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4413 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4414 since Lisp_Subr is a special case (no "next" field).
4415 (ASIZE): Now uses header.size rather than size.
4416 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4417 to avoid the hassle of writing XVECTOR (foo)->header.size.
4418 (struct vectorlike_header): New type.
4419 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4420 object, to help avoid aliasing.
4421 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4422 (SUBRP): Likewise, since Lisp_Subr is a special case.
4423 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4424 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4425 (struct Lisp_Hash_Table): Combine first two members into a single
4426 struct vectorlike_header member. All uses of "size" and "next" members
4427 changed to be "header.size" and "header.next".
4428 * buffer.h (struct buffer): Likewise.
4429 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4430 * frame.h (struct frame): Likewise.
4431 * process.h (struct Lisp_Process): Likewise.
4432 * termhooks.h (struct terminal): Likewise.
4433 * window.c (struct save_window_data, struct saved_window): Likewise.
4434 * window.h (struct window): Likewise.
4435 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4436 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4437 * buffer.c (init_buffer_once): Likewise.
4438 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4440 * process.c (Fformat_network_address): Use local var for size,
4443 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4445 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4446 * data.c (atof): Remove decl; no longer used or needed.
4447 (digit_to_number): Move to lread.c.
4448 (Fstring_to_number): Use new string_to_number function, to be
4449 consistent with how the Lisp reader treats infinities and NaNs.
4450 Do not assume that floating-point numbers represent EMACS_INT
4451 without losing information; this is not true on most 64-bit hosts.
4452 Avoid double-rounding errors, by insisting on integers when
4453 parsing non-base-10 numbers, as the documentation specifies.
4454 * lisp.h (string_to_number): New decl, replacing ...
4455 (isfloat_string): Remove.
4456 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4457 (read1): Do not accept +. and -. as integers; this
4458 appears to have been a coding error. Similarly, do not accept
4459 strings like +-1e0 as floating point numbers. Do not report
4460 overflow for integer overflows unless the base is not 10 which
4461 means we have no simple and reliable way to continue.
4462 Break out the floating-point parsing into a new
4463 function string_to_number, so that Fstring_to_number parses
4464 floating point numbers consistently with the Lisp reader.
4465 (digit_to_number): Move here from data.c. Make it static inline.
4466 (E_CHAR, EXP_INT): Remove, replacing with ...
4467 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4468 (string_to_number): New function, replacing isfloat_string.
4469 This function checks for valid syntax and produces the resulting
4470 Lisp float number too. Rework it so that string-to-number
4471 no longer mishandles examples like "1.0e+". Use strtoumax,
4472 so that overflow for non-base-10 numbers is reported only when
4473 there's no portable and simple way to convert to floating point.
4475 * textprop.c (set_text_properties_1): Rewrite for clarity,
4476 and to avoid GCC warning about integer overflow.
4478 * intervals.h (struct interval): Use EMACS_INT for members
4479 where EMACS_UINT might cause problems. See
4480 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4481 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4482 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4484 (offset_intervals): Tell GCC not to worry about length overflow
4485 when negating a negative length.
4487 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4488 (overrun_check_free): Likewise.
4490 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4491 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4494 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4495 (gnutls_make_error): Rename local to avoid shadowing.
4496 (gnutls_emacs_global_deinit): ifdef out; not used.
4497 (Fgnutls_boot): Use const for pointer to readonly storage.
4498 Comment out unused local. Fix pointer signedness problems.
4500 * lread.c (openp): Don't stuff size_t into an 'int'.
4501 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4502 about possible signed overflow.
4504 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4505 (GDK_KEY_g): Don't define if already defined.
4506 (xg_prepare_tooltip): Avoid pointer signedness problem.
4507 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4509 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4510 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4512 * xfns.c (Fx_window_property): Simplify a bit,
4513 to make a bit faster and to avoid GCC 4.6.0 warning.
4514 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4516 * fns.c (internal_equal): Don't assume size_t fits in int.
4518 * alloc.c (compact_small_strings): Tighten assertion a little.
4520 Replace pEd with more-general pI, and fix some printf arg casts.
4521 * lisp.h (pI): New macro, generalizing old pEd macro to other
4522 conversion specifiers. For example, use "...%"pI"d..." rather
4523 than "...%"pEd"...".
4524 (pEd): Remove. All uses replaced with similar uses of pI.
4525 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4526 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4527 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4528 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4529 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4530 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4531 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4533 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4534 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4535 * print.c (safe_debug_print, print_object): Likewise.
4536 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4538 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4539 avoiding the 0 flag, which is not portable.
4540 * process.c (Fmake_network_process): Use pI to avoid cast.
4541 * region-cache.c (pp_cache): Likewise.
4542 * xdisp.c (decode_mode_spec): Likewise.
4543 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4544 behavior on 64-bit hosts with printf arg.
4545 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4546 (x_stop_queuing_selection_requests): Likewise.
4547 (x_get_window_property): Don't truncate byte count to an 'int'
4550 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4551 here, since it parses constructs like leading '-' and spaces,
4552 which are not wanted; and it overflows with large numbers.
4553 Instead, simply match F[0-9]+, which is what is wanted anyway.
4555 * alloc.c: Remove unportable assumptions about struct layout.
4556 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4557 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4558 (allocate_vectorlike, make_pure_vector): Use the new macros,
4559 plus offsetof, to remove unportable assumptions about struct layout.
4560 These assumptions hold on all porting targets that I know of, but
4561 they are not guaranteed, they're easy to remove, and removing them
4562 makes further changes easier.
4564 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4565 This doesn't fix a bug but makes the code clearer.
4566 (string_overrun_cookie): Now const. Use initializers that
4567 don't formally overflow signed char, to avoid warnings.
4568 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4569 can cause Emacs to crash when string overrun checking is enabled.
4570 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4571 multiple of sizeof (EMACS_INT); it need not be, if
4572 alignof(EMACS_INT) < sizeof (EMACS_INT).
4573 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4575 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4577 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4579 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4581 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4582 supposed to be handshaking. (Bug#8556)
4583 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4585 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4587 * lisp.h (Qdebug): List symbol.
4588 * eval.c (Qdebug): Restore global linkage.
4589 * keyboard.c (debug-on-event): New variable.
4590 (handle_user_signal): Break into debugger when debug-on-event
4591 matches the current signal symbol.
4593 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4595 * alloc.c (check_sblock, check_string_bytes)
4596 (check_string_free_list): Convert to standard C.
4598 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4600 * w32.c (emacs_gnutls_push): Fix typo.
4602 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4604 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4605 "cast to pointer from integer of different size".
4607 Improve doprnt and its use in verror. (Bug#8545)
4608 * doprnt.c (doprnt): Document the set of format control sequences
4609 supported by the function. Use SAFE_ALLOCA instead of always
4612 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4613 is one byte too soon. Don't use xrealloc; instead xfree and
4616 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4618 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4621 * gnutls.c: Renamed global_initialized to
4622 gnutls_global_initialized. Added internals for the
4623 :verify-hostname-error, :verify-error, and :verify-flags
4624 parameters of `gnutls-boot' and documented those parameters in the
4625 docstring. Start callback support.
4626 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4627 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4628 on error. Return error code.
4629 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4630 (emacs_gnutls_read): Likewise.
4631 (Fgnutls_boot): Return handshake error code.
4632 (emacs_gnutls_handle_error): New function.
4633 (wsaerror_to_errno): Likewise.
4635 * w32.h (emacs_gnutls_pull): Add prototype.
4636 (emacs_gnutls_push): Likewise.
4638 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4639 (emacs_gnutls_push): Likewise.
4641 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4643 * process.c (wait_reading_process_output): Check if GnuTLS
4644 buffered some data internally if no FDs are set for TLS
4647 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4648 (LIBS): Link to USER_LIBS.
4649 ($(BLD)/gnutls.$(0)): New target.
4651 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4653 * xdisp.c (handle_single_display_spec): Rename the
4654 display_replaced_before_p argument into display_replaced_p, to
4655 make it consistent with the commentary. Fix typos in the
4658 * textprop.c (syms_of_textprop): Remove dead code.
4659 (copy_text_properties): Delete obsolete commentary about an
4660 interface that was deleted long ago. Fix typos in the description
4663 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4664 to changes in oldXMenu/XMenu.h from 2011-04-16.
4665 <menu_help_message, prev_menu_help_message>: Constify.
4666 (IT_menu_make_room): menu->help_text is now `const char **';
4669 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4670 to changes in oldXMenu/XMenu.h from 2011-04-16.
4671 (struct XMenu): Declare `help_text' `const char **'.
4673 * xfaces.c <Qunspecified>: Make extern again.
4675 * syntax.c: Include sys/types.h before including regex.h, as
4678 * doc.c (get_doc_string): Improve the format passed to `error'.
4680 * doprnt.c (doprnt): Improve commentary.
4682 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4684 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4687 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4688 changes in globals.h immediately force recompilation.
4689 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4690 $(CURDIR)/s/ms-w32.h.
4691 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4693 * character.c (Fchar_direction): Function deleted.
4694 (syms_of_character): Don't defsubr it.
4695 <char-direction-table>: Deleted.
4697 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4699 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4700 * doprnt.c: Include limits.h.
4701 (SIZE_MAX): New macro.
4702 (doprnt): Return a size_t value. 2nd arg is now size_t.
4703 Many local variables are now size_t instead of int or unsigned.
4704 Improve overflow protection. Support `l' modifier for integer
4705 conversions. Support %l conversion. Don't assume an EMACS_INT
4706 argument for integer conversions and for %c.
4708 * lisp.h (doprnt): Restore prototype.
4710 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4713 * Makefile.in (base_obj): Add back doprnt.o.
4715 * deps.mk (doprnt.o): Add back prerequisites.
4716 (callint.o): Depend on character.h.
4718 * eval.c (internal_lisp_condition_case): Include the handler
4719 representation in the error message.
4720 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4721 when breaking from the loop.
4723 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4725 * callint.c (Fcall_interactively): When displaying error message
4726 about invalid control letter, pass the character's codepoint, not
4727 a pointer to its multibyte form. Improve display of the character
4728 in octal and display also its hex code.
4730 * character.c (char_string): Use %x to display the (unsigned)
4731 codepoint of an invalid character, to avoid displaying a bogus
4734 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4735 `error', not SYMBOL_NAME itself.
4737 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4738 character arguments to `error'.
4740 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4741 to `error' in error message about FINAL_CHAR argument. Make sure
4742 FINAL_CHAR is a character, and use %c when it is passed as
4743 argument to `error'.
4745 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4747 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4749 * w32.c: Include <time.h>.
4750 (sys_localtime): New function.
4752 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4754 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4756 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4758 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4760 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4763 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4765 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4766 gl_state.e_property when gl_state.object is Qt.
4768 * insdel.c (make_gap_larger): Remove limitation of buffer size
4771 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4773 * xdisp.c (lookup_glyphless_char_display)
4774 (produce_glyphless_glyph): Handle cons cell entry in
4775 glyphless-char-display.
4776 (Vglyphless_char_display): Document it.
4778 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4779 glyphless-char-display.
4781 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4783 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4785 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4787 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4788 definition for no-X builds.
4790 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4792 Static checks with GCC 4.6.0 and non-default toolkits.
4794 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4796 * process.c (keyboard_bit_set): Define only if SIGIO.
4797 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4798 (send_process): Repair possible setjmp clobbering.
4800 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4802 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4804 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4806 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4807 Define only if needed.
4809 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4810 by pacifying GCC about it. Maybe it's time to retire it?
4811 * xfaces.c (USG, __TIMEVAL__): Likewise.
4813 * dispextern.h (struct redisplay_interface): Rename param
4815 * termhooks.h (struct terminal): Likewise.
4816 * xterm.c (xembed_send_message): Likewise.
4818 * insdel.c (make_gap_smaller): Define only if
4819 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4821 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4824 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4825 so that we aren't warned about unused symbols.
4827 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4829 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4831 * xfns.c (x_real_positions): Mark locals as initialized.
4833 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4835 * xterm.c: Fix problems found by static analysis with other toolkits.
4836 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4837 (x_dispatch_event): Declare static if USE_GTK, and
4838 define if USE_GTK || USE_X_TOOLKIT.
4839 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4840 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4841 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4842 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4844 * xmenu.c (menu_help_callback): Pointer type fixes.
4845 Use const pointers when pointing at readonly data. Avoid pointer
4847 (FALSE): Remove unused macro.
4848 (update_frame_menubar): Remove unused decl.
4850 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4852 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4853 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4854 (single_menu_item): Rename local to avoid shadowing.
4856 * keyboard.c (make_lispy_event): Remove unused local var.
4858 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4859 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4861 * bitmaps: Change bitmaps from unsigned char back to the X11
4862 compatible char. Avoid the old compiler warnings about
4863 out-of-range initializers by using, for example, '\xab' rather
4866 * xgselect.c (xgselect_initialize): Check vs interface
4867 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4869 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4871 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4872 to read-only memory.
4874 * fns.c (vector): Remove; this old hack is no longer needed.
4876 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4878 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4880 * xrdb.c (x_load_resources): Omit unused local.
4882 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4883 (x_window): Rename locals to avoid shadowing.
4884 (USG): Use the kludged USG macro, to pacify gcc.
4886 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4887 (x_term_init): Remove local to avoid shadowing.
4889 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4891 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4892 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4894 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4896 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4898 Fix regex.c, syntax.c and friends for buffers > 2GB.
4899 * syntax.h (struct gl_state_s): Declare character position members
4902 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4904 * textprop.c (verify_interval_modification, interval_of):
4905 Declare arguments EMACS_INT.
4907 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4910 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4912 * indent.c (Fvertical_motion): Local variable it_start is now
4915 * regex.c (re_match, re_match_2, re_match_2_internal)
4916 (bcmp_translate, regcomp, regexec, print_double_string)
4917 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4918 (re_compile_pattern, re_exec): Declare arguments and local
4919 variables `size_t' and `ssize_t' and return values `regoff_t', as
4921 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4922 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4923 <compile_stack_type>: `size' and `avail' are now `size_t'.
4925 * regex.h <regoff_t>: Use ssize_t, not int.
4926 (re_search, re_search_2, re_match, re_match_2): Arguments that
4927 specify buffer/string position and length are now ssize_t and
4928 size_t. Return type is regoff_t.
4930 2011-04-16 Ben Key <bkey76@gmail.com>
4932 * nsfont.m: Fixed bugs in ns_get_family and
4933 ns_descriptor_to_entity that were caused by using free to
4934 deallocate memory blocks that were allocated by xmalloc (via
4935 xstrdup). This caused Emacs to crash when compiled with
4936 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4937 --enable-checking=xmallocoverrun). xfree is now used to
4938 deallocate these memory blocks.
4940 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4942 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4944 emacs_write: Accept and return EMACS_INT for sizes.
4945 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4947 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4948 Accept and return EMACS_INT.
4949 (emacs_gnutls_write): Return the number of bytes written on
4951 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4952 (emacs_read, emacs_write): Remove check for negative size, as the
4953 Emacs source code has been audited now.
4954 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4955 (emacs_read, emacs_write): Use it.
4956 * process.c (send_process): Adjust to the new signatures of
4957 emacs_write and emacs_gnutls_write. Do not attempt to store
4958 a byte offset into an 'int'; it might overflow.
4959 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4961 * sound.c: Don't assume sizes fit in 'int'.
4962 (struct sound_device.period_size, alsa_period_size):
4963 Return EMACS_INT, not int.
4964 (struct sound_device.write, vox_write, alsa_write):
4965 Accept EMACS_INT, not int.
4966 (wav_play, au_play): Use EMACS_INT to store sizes and to
4967 record read return values.
4969 2011-04-15 Ben Key <bkey76@gmail.com>
4971 * keyboard.c (Qundefined): Don't declare static since it is used
4973 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4974 static since they are used in nsfont.m.
4976 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4978 * process.c (Qprocessp): Don't declare static.
4979 * lisp.h (Qprocessp): Declare again.
4981 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4983 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4985 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4987 Improve C-level modularity by making more things 'static'.
4989 Don't publish debugger-only interfaces to other modules.
4990 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4991 (verify_bytepos, count_markers): Move decls to the only modules
4993 * region-cache.h (pp_cache): Likewise.
4994 * window.h (check_all_windows): Likewise.
4995 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4997 * sysdep.c (croak): Now static, if
4998 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4999 * syssignal.h (croak): Declare only if not static.
5001 * alloc.c (refill_memory_reserve): Now static if
5002 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5003 * lisp.h (refill_memory_reserve): Declare only if not static.
5005 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5006 Define only if USE_LUCID.
5008 * xrdb.c (x_customization_string, x_rm_string): Now static.
5010 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5011 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5013 * xdisp.c (draw_row_with_mouse_face): Now static.
5014 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5016 * window.h (check_all_windows): Mark externally visible.
5018 * window.c (window_deletion_count): Now static.
5020 * undo.c: Make symbols static if they're not exported.
5021 (last_undo_buffer, last_boundary_position, pending_boundary):
5024 * textprop.c (interval_insert_behind_hooks): Now static.
5025 (interval_insert_in_front_hooks): Likewise.
5027 * term.c: Make symbols static if they're not exported.
5028 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5029 (max_frame_lines, tty_set_terminal_modes):
5030 (tty_reset_terminal_modes, tty_turn_off_highlight):
5031 (get_tty_terminal): Now static.
5032 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5033 * termhooks.h (term_mouse_moveto): Do not declare if
5035 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5036 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5038 * sysdep.c: Make symbols static if they're not exported.
5039 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5041 (sigprocmask_set, full_mask): Remove; unused.
5042 (wait_debugging): Mark as visible.
5043 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5044 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5046 * syntax.c (syntax_temp): Define only if !__GNUC__.
5048 * sound.c (current_sound_device, current_sound): Now static.
5050 * search.c (searchbufs, searchbuf_head): Now static.
5052 * scroll.c (scroll_cost): Remove; unused.
5053 * dispextern.h (scroll_cost): Remove decl.
5055 * region-cache.h (pp_cache): Mark as externally visible.
5057 * process.c: Make symbols static if they're not exported.
5058 (process_tick, update_tick, create_process, chan_process):
5059 (Vprocess_alist, proc_buffered_char, datagram_access):
5060 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5061 (deactivate_process): Mark defn as static, as well as decl.
5062 * lisp.h (create_process): Remove decl.
5063 * process.h (chan_process, Vprocess_alist): Remove decls.
5065 * print.c: Make symbols static if they're not exported.
5066 (print_depth, new_backquote_output, being_printed, print_buffer):
5067 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5068 (print_interval, print_number_index, initial_stderr_stream):
5070 * lisp.h (Fprinc): Remove decl.
5071 (debug_output_compilation_hack): Mark as externally visible.
5073 * sysdep.c (croak): Move decl from here to syssignal.h.
5074 * syssignal.h (croak): Put it here, so the API can be checked when
5075 'croak' is called from dissociate_if_controlling_tty.
5077 * minibuf.c: Make symbols static if they're not exported.
5078 (minibuf_save_list, choose_minibuf_frame): Now static.
5079 * lisp.h (choose_minibuf_frame): Remove decl.
5081 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5083 * lread.c: Make symbols static if they're not exported.
5084 (read_objects, initial_obarray, oblookup_last_bucket_number):
5086 (make_symbol): Remove; unused.
5087 * lisp.h (initial_obarray, make_symbol): Remove decls.
5089 * keyboard.c: Make symbols static if they're not exported.
5090 (single_kboard, recent_keys_index, total_keys, recent_keys):
5091 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5092 (this_single_command_key_start, echoing, last_auto_save):
5093 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5094 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5095 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5096 (Vlispy_mouse_stem, double_click_count):
5098 (force_auto_save_soon): Define only if SIGDANGER.
5099 (ignore_mouse_drag_p): Now static if
5100 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5101 (print_help): Remove; unused.
5102 (stop_character, last_timer_event): Mark as externally visible.
5103 * keyboard.h (ignore_mouse_drag_p): Declare only if
5104 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5105 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5106 * lisp.h (echoing): Remove decl.
5107 (force_auto_save_soon): Declare only if SIGDANGER.
5108 * xdisp.c (redisplay_window): Simplify code, to make it more
5109 obvious that ignore_mouse_drag_p is not accessed if !defined
5110 USE_GTK && !defined HAVE_NS.
5112 * intervals.c: Make symbols static if they're not exported.
5113 (merge_properties_sticky, merge_interval_right, delete_interval):
5115 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5117 * insdel.c: Make symbols static if they're not exported.
5118 However, leave prepare_to_modify_buffer alone. It's never
5119 called from outside this function, but that appears to be a bug.
5120 (combine_after_change_list, combine_after_change_buffer):
5121 (adjust_after_replace, signal_before_change): Now static.
5122 (adjust_after_replace_noundo): Remove; unused.
5123 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5124 (signal_before_change): Remove decls.
5126 * indent.c (val_compute_motion, val_vmotion): Now static.
5128 * image.c: Make symbols static if they're not exported.
5129 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5131 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5132 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5134 * fringe.c (standard_bitmaps): Now static.
5135 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5137 * frame.c: Make symbols static if they're not exported.
5138 (x_report_frame_params, make_terminal_frame): Now static.
5139 (get_frame_param): Now static, unless HAVE_NS.
5140 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5141 (x_get_resource_string): Remove; not used.
5142 * frame.h (make_terminal_frame, x_report_frame_params):
5143 (x_get_resource_string); Remove decls.
5144 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5145 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5147 * font.c, fontset.c: Make symbols static if they're not exported.
5148 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5149 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5150 * font.c (font_close_object): Now static.
5151 * font.h (font_close_object): Remove.
5152 * fontset.c (FONTSET_OBJLIST): Remove.
5153 (free_realized_fontset) #if-0 the body, which does nothing.
5154 (face_suitable_for_char_p): #if-0, as it's never called.
5155 * fontset.h (face_suitable_for_char_p): Remove decl.
5156 * xfaces.c (face_at_string_position):
5157 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5158 since 0 is always ASCII.
5160 * fns.c (weak_hash_tables): Now static.
5162 * fileio.c: Make symbols static if they're not exported.
5163 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5164 (Vwrite_region_annotation_buffers): Now static.
5166 * eval.c: Make symbols static if they're not exported.
5167 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5168 * lisp.h (backtrace_list): Remove decl.
5170 * emacs.c: Make symbols static if they're not exported.
5171 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5172 (fatal_error_code, fatal_error_signal_hook, standard_args):
5174 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5175 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5176 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5177 * lisp.h (fatal_error_signal_hook): Remove decl.
5178 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5180 * editfns.c: Move a (normally-unused) function to its only use.
5181 * editfns.c, lisp.h (get_operating_system_release): Remove.
5182 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5183 worth the hassle of breaking this out.
5185 * xterm.c: Make symbols static if they're not exported.
5186 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5187 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5188 (x_destroy_window, x_delete_display):
5190 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5191 (x_mouse_leave): Remove; unused.
5192 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5193 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5194 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5196 (x_mouse_leave): Declare only if WINDOWSNT.
5197 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5198 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5201 * ftxfont.c: Make symbols static if they're not exported.
5202 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5204 * font.h (ftxfont_driver): Likewise.
5206 * xfns.c: Make symbols static if they're not exported.
5207 (x_last_font_name, x_display_info_for_name):
5208 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5209 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5210 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5211 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5212 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5213 (last_show_tip_args): Now static.
5214 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5215 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5216 (x_screen_planes): Remove; unused.
5217 * dispextern.h (x_screen_planes): Remove decl.
5219 * dispnew.c: Make symbols static if they're not exported.
5220 * dispextern.h (redraw_garbaged_frames, scrolling):
5221 (increment_row_positions): Remove.
5222 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5223 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5225 (redraw_garbaged_frames): Remove; unused.
5227 * xfaces.c: Make symbols static if they're not exported.
5228 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5230 * xterm.h (defined_color): Remove decls.
5231 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5232 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5233 (menu_face_changed_default, defined_color, free_realized_face):
5234 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5235 (ascii_face_of_lisp_face): Remove; unused.
5237 * xdisp.c: Make symbols static if they're not exported.
5238 * dispextern.h (scratch_glyph_row, window_box_edges):
5239 (glyph_to_pixel_coords, set_cursor_from_row):
5240 (get_next_display_element, set_iterator_to_next):
5241 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5242 (show_mouse_face): Remove decls
5243 * frame.h (message_buf_print): Likewise.
5244 * lisp.h (pop_message, set_message, check_point_in_composition):
5246 * xterm.h (set_vertical_scroll_bar): Likewise.
5247 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5248 (message_buf_print, scratch_glyph_row, displayed_buffer):
5249 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5250 (get_next_display_element, show_mouse_face, window_box_edges):
5251 (frame_to_window_pixel_xy, check_point_in_composition):
5252 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5253 (glyph_to_pixel_coords): Remove; unused.
5255 * dired.c (file_name_completion): Now static.
5257 * dbusbind.c (xd_in_read_queued_messages): Now static.
5259 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5260 * data.c (circular_list_error): Remove.
5262 * commands.h (last_point_position, last_point_position_buffer):
5263 (last_point_position_window): Remove decls.
5264 * keyboard.c: Make these variables static.
5266 * coding.h (coding, code_convert_region, encode_coding_gap):
5268 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5269 (iso_code_class, detect_coding, code_convert_region): Now static.
5270 (encode_coding_gap): Remove; unused.
5272 * chartab.c (chartab_chars, chartab_bits): Now static.
5274 * charset.h (charset_iso_8859_1): Remove decl.
5275 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5278 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5279 * ccl.c (Vccl_program_table): Now static.
5280 (check_ccl_update): Remove; unused.
5282 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5283 * category.h: ... from here.
5284 * category.c (check_category_table, set_category_set): Now static.
5286 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5287 * lisp.h: Remove these decls.
5289 * buffer.c (buffer_count): Remove unused var.
5291 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5292 so that it's not optimized away.
5293 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5294 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5295 exported only to the debugger.
5297 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5298 * atimer.h (run_all_atimers): Remove; not exported.
5300 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5301 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5302 was inaccessible from Lisp.
5303 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5304 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5306 alloc.c: Import and export fewer symbols, and remove unused items.
5307 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5309 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5310 it's not optimized away by whole-program optimization.
5311 (message_enable_multibyte, free_misc): Remove.
5312 (catchlist, handlerlist, mark_backtrace):
5313 Declare only if BYTE_MARK_STACK.
5314 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5315 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5316 (message_enable_multibyte): Remove decl.
5317 (free_misc, interval_free_list, float_block, float_block_index):
5318 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5319 (cons_free_list, last_marked_index):
5321 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5322 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5323 (mark_backtrace): Define only if BYTE_MARK_STACK.
5324 * xdisp.c (message_enable_multibyte): Now static.
5326 Declare Lisp_Object Q* variables to be 'static' if not exported.
5327 This makes it easier for human readers (and static analyzers)
5328 to see whether these variables are used from other modules.
5329 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5330 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5331 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5332 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5333 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5334 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5335 * xmenu.c, xselect.c:
5336 Declare Q* vars static if they are not used in other modules.
5337 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5338 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5339 Remove decls of unexported vars.
5340 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5342 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5344 Make Emacs functions such as Fatom 'static' by default.
5345 This makes it easier for human readers (and static analyzers)
5346 to see whether these functions can be called from other modules.
5347 DEFUN now defines a static function. To make the function external
5348 so that it can be used in other C modules, use the new macro DEFUE.
5349 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5350 (Finit_image_library):
5351 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5352 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5353 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5354 Remove decls, since these functions are now static.
5355 (Funintern, Fget_internal_run_time): New decls, since these functions
5356 were already external.
5358 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5359 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5360 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5361 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5362 * keyboard.c, keymap.c, lread.c:
5363 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5364 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5365 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5366 Mark functions with DEFUE instead of DEFUN,
5367 if they are used in other modules.
5368 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5369 decls for now-static functions.
5370 * buffer.h (Fdelete_overlay): Remove decl.
5371 * callproc.c (Fgetenv_internal): Mark as internal.
5372 * composite.c (Fremove_list_of_text_properties): Remove decl.
5373 (Fcomposition_get_gstring): New forward static decl.
5374 * composite.h (Fcomposite_get_gstring): Remove decl.
5375 * dired.c (Ffile_attributes): New forward static decl.
5376 * doc.c (Fdocumntation_property): New forward static decl.
5377 * eval.c (Ffetch_bytecode): New forward static decl.
5378 (Funintern): Remove extern decl; now in .h file where it belongs.
5379 * fileio.c (Fmake_symbolic_link): New forward static decl.
5380 * image.c (Finit_image_library): New forward static decl.
5381 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5382 * intervals.h (Fprevious_property_change):
5383 (Fremove_list_of_text_properties): Remove decls.
5384 * keyboard.c (Fthis_command_keys): Remove decl.
5385 (Fcommand_execute): New forward static decl.
5386 * keymap.c (Flookup_key): New forward static decl.
5387 (Fcopy_keymap): Now static.
5388 * keymap.h (Flookup_key): Remove decl.
5389 * process.c (Fget_process): New forward static decl.
5390 (Fprocess_datagram_address): Mark as internal.
5391 * syntax.c (Fsyntax_table_p): New forward static decl.
5392 (skip_chars): Remove duplicate decl.
5393 * textprop.c (Fprevious_property_change): New forward static decl.
5394 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5396 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5397 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5399 * editfns.c (Fformat): Remove unreachable code.
5401 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5403 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5406 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5408 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5409 when at ZV. (Bug#8487)
5411 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5413 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5415 * keyboard.c (parse_tool_bar_item): Likewise.
5416 * sound.c (sound_cleanup, alsa_close): Likewise.
5417 * termcap.c (tgetent): Likewise.
5418 * xfns.c (x_default_font_parameter): Likewise.
5419 * xsettings.c (read_and_apply_settings): Likewise.
5421 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5422 (overrun_check_free): Protoize.
5424 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5426 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5427 since callers should never pass a negative size.
5428 Change the signature to match that of plain 'read' and 'write'; see
5429 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5430 * lisp.h: Update prototypes of emacs_write and emacs_read.
5432 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5434 * xdisp.c (redisplay_window): Don't try to determine the character
5435 position of the scroll margin if the window start point w->startp
5436 is outside the buffer's accessible region. (Bug#8468)
5438 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5440 Fix write-region and its subroutines for buffers > 2GB.
5441 * fileio.c (a_write, e_write): Modify declaration of arguments and
5442 local variables to support buffers larger than 2GB.
5443 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5445 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5446 argument, local variables, and return value.
5448 * lisp.h: Update prototypes of emacs_write and emacs_read.
5450 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5452 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5454 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5456 Fix more problems found by GCC 4.6.0's static checks.
5458 * xdisp.c (vmessage): Use a better test for character truncation.
5460 * charset.c (load_charset_map): <, not <=, for optimization,
5461 and to avoid potential problems with integer overflow.
5462 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5463 * casetab.c (set_identity, shuffle): Likewise.
5464 * editfns.c (Fformat): Likewise.
5465 * syntax.c (skip_chars): Likewise.
5467 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5468 This also lets GCC 4.6.0 generate slightly better loop code.
5470 * callint.c (Fcall_interactively): <, not <=, for optimization.
5471 (Fcall_interactively): Count the number of arguments produced,
5472 not the number of arguments given. This is simpler and lets GCC
5473 4.6.0 generate slightly better code.
5475 * ftfont.c: Distingish more carefully between FcChar8 and char.
5476 The previous code passed unsigned char * to a functions like
5477 strlen and xstrcasecmp that expect char *, which does not
5478 conform to the C standard.
5479 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5480 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5481 char * when the C standard requires it.
5483 * keyboard.c (read_char): Remove unused var.
5485 * eval.c: Port to Windows vsnprintf (Bug#8435).
5487 (SIZE_MAX): Define if the headers do not.
5488 (verror): Do not give up if vsnprintf returns a negative count.
5489 Instead, grow the buffer. This ports to Windows vsnprintf, which
5490 does not conform to C99. Problem reported by Eli Zaretskii.
5491 Also, simplify the allocation scheme, by avoiding the need for
5492 calling realloc, and removing the ALLOCATED variable.
5494 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5496 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5497 But keep the doprint source code for now, as we might revamp it
5498 and use it again (Bug#8435).
5499 * lisp.h (doprnt): Remove.
5500 * Makefile.in (base_obj): Remove doprnt.o.
5501 * deps.mk (doprnt.o): Remove.
5503 error: Print 32- and 64-bit integers portably (Bug#8435).
5504 Without this change, on typical 64-bit hosts error ("...%d...", N)
5505 was used to print both 32- and 64-bit integers N, which relied on
5507 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5509 * lisp.h (error, verror): Mark as printf-like functions.
5510 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5511 Report overflow in size calculations when allocating printf buffer.
5512 Do not truncate output string at its first null byte.
5513 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5514 Truncate the output at a character boundary, since vsnprintf does not
5516 * charset.c (check_iso_charset_parameter): Convert internal
5517 character to string before calling 'error', since %c now has the
5519 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5520 overflow when computing char to be passed to 'error'. Do not
5521 pass Lisp_Object to 'error'; pass the integer instead.
5522 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5523 formatted with plain %d.
5525 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5527 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5529 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5531 * xterm.c (x_catch_errors): Remove duplicate declaration.
5533 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5535 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5537 2011-04-10 Jim Meyering <meyering@redhat.com>
5539 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5540 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5541 return ssize_t not "int", and use size_t as the buffer length.
5542 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5543 * gnutls.h: Update declarations.
5544 * process.c (read_process_output): Use ssize_t, to match.
5545 (send_process): Likewise.
5547 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5549 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5551 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5553 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5554 Use unsigned char, to match FcChar8 type definition.
5556 * xterm.c (handle_one_xevent):
5557 * xmenu.c (create_and_show_popup_menu):
5558 * xselect.c (x_decline_selection_request)
5559 (x_reply_selection_request): Avoid type-punned deref of X events.
5561 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5563 Fix some uses of `int' instead of EMACS_INT.
5564 * search.c (string_match_1, fast_string_match)
5565 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5566 (scan_buffer, find_next_newline_no_quit)
5567 (find_before_next_newline, search_command, Freplace_match)
5568 (Fmatch_data): Make some `int' variables be EMACS_INT.
5570 * xdisp.c (display_count_lines): 3rd argument and return value now
5571 EMACS_INT. All callers changed.
5572 (pint2hrstr): Last argument is now EMACS_INT.
5574 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5575 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5576 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5577 (decode_coding_utf_16, decode_coding_emacs_mule)
5578 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5579 (decode_coding_ccl, decode_coding_charset)
5580 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5581 (decode_coding_iso_2022, decode_coding_emacs_mule)
5582 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5583 <char_offset, last_offset>: Declare EMACS_INT.
5584 (encode_coding_utf_8, encode_coding_utf_16)
5585 (encode_coding_emacs_mule, encode_invocation_designation)
5586 (encode_designation_at_bol, encode_coding_iso_2022)
5587 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5588 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5590 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5591 (encode_invocation_designation): Last argument P_NCHARS is now
5593 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5594 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5596 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5599 * ccl.c (Fccl_execute_on_string): Declare some variables
5602 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5604 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5606 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5608 * process.c (Fformat_network_address): Doc fix.
5610 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5612 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5614 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5616 * keyboard.c (read_char): Call Lisp function help-form-show,
5617 instead of using internal_with_output_to_temp_buffer.
5618 (Qhelp_form_show): New var.
5619 (syms_of_keyboard): Use DEFSYM macro.
5621 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5623 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5625 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5627 * process.c (Flist_processes): Remove to Lisp.
5628 (list_processes_1): Delete.
5630 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5632 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5634 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5636 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5638 Fix more problems found by GCC 4.6.0's static checks.
5640 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5642 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5644 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5646 * xdisp.c (vmessage): Mark as a printf-like function.
5648 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5650 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5652 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5653 printf-like functions.
5654 (tiff_load): Add casts to remove these marks before passing them
5655 to system-supplied API.
5657 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5659 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5660 This avoids several warnings with gcc -Wstrict-overflow.
5661 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5662 directly, rather than having caller test rule sign. This avoids
5663 some unnecessary tests.
5664 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5665 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5666 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5668 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5669 (xfont_open): Avoid unnecessary tests.
5671 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5673 * composite.h, composite.c (composition_gstring_put_cache):
5674 Use EMACS_INT, not int, for length.
5676 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5677 breaking out part of COMPOSITION_DECODE_RULE.
5678 (COMPOSITION_DECODE_RULE): Use it.
5679 * composite.c (get_composition_id): Remove unused local vars,
5680 by using the new macro.
5682 * textprop.c (set_text_properties_1): Change while to do-while,
5683 since the condition is always true at first.
5685 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5686 (interval_deletion_adjustment): Return unsigned value.
5689 * process.c (list_processes_1, create_pty, read_process_output):
5690 (exec_sentinel): Remove vars that were set but not used.
5691 (create_pty): Remove unnecessary "volatile"s.
5692 (Fnetwork_interface_info): Avoid possibility of int overflow.
5693 (read_process_output): Do adaptive read buffering even if carryover.
5694 (read_process_output): Simplify nbytes computation if buffered.
5696 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5698 * syntax.c (scan_words): Remove var that was set but not used.
5699 (update_syntax_table): Use unsigned instead of int.
5701 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5702 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5703 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5705 * print.c (print_error_message): Avoid int overflow.
5707 * font.c (font_list_entities): Redo for clarity,
5708 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5710 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5711 (font_score): Avoid potential overflow in diff calculation.
5713 * fns.c (substring_both): Remove var that is set but not used.
5714 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5716 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5718 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5719 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5720 can always succeed if overflow has undefined behavior.
5722 * search.c (boyer_moore, wordify): Remove vars set but not used.
5723 (wordify): Omit three unnecessary tests.
5725 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5726 All callers changed. This avoids the need for an unused var.
5728 * casefiddle.c (casify_region): Remove var that is set but not used.
5730 * dired.c (file_name_completion): Remove var that is set but not used.
5732 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5734 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5735 (Finsert_file_contents): Remove unnecessary code checking fd.
5737 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5738 Check for integer overflow on size calculations.
5740 * buffer.c (Fprevious_overlay_change): Remove var that is set
5743 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5744 Remove vars that are set but not used.
5745 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5746 (timer_check_2): Mark vars as initialized.
5748 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5750 * image.c (lookup_image): Remove var that is set but not used.
5751 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5753 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5754 that are set but not used.
5756 * xfns.c (make_invisible_cursor): Don't return garbage
5757 if XCreateBitmapFromData fails (Bug#8410).
5759 * xselect.c (x_get_local_selection, x_handle_property_notify):
5760 Remove vars that are set but not used.
5762 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5763 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5765 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5766 Remove var that is set but not used.
5767 (scroll_bar_windows_size): Now size_t, not int.
5768 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5771 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5772 (map_tty_color) [!defined MSDOS]: Likewise.
5774 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5776 * coding.c: Remove vars that are set but not used.
5777 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5778 All callers changed.
5779 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5780 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5781 (decode_coding_charset): Remove vars that are set but not used.
5783 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5784 that is set but not used.
5786 * print.c (print_object): Remove var that is set but not used.
5788 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5789 The gnulib version avoids calling malloc in the usual case,
5790 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5791 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5792 * filelock.c (current_lock_owner): Likewise.
5793 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5794 * sysdep.c: Include allocator.h, careadlinkat.h.
5795 (emacs_no_realloc_allocator): New static constant.
5796 (emacs_readlink): New function.
5797 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5798 ../lib/careadlinkat.h.
5800 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5802 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5803 first non-nil return value).
5805 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5807 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5808 if not defined (Bug#8403).
5810 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5812 * xdisp.c (display_count_lines): Remove parameter `start',
5813 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5814 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5815 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5816 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5817 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5818 and thereabouts. All callers changed.
5819 (get_per_char_metric): Remove parameter `f', unused since
5820 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5822 2011-04-02 Jim Meyering <meyering@redhat.com>
5824 do not dereference NULL upon failed strdup
5825 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5826 (ns_get_family): Likewise.
5828 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5830 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5832 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5834 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5837 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5839 Add lexical binding.
5841 * window.c (Ftemp_output_buffer_show): New fun.
5842 (Fsave_window_excursion):
5843 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5845 * lread.c (lisp_file_lexically_bound_p): New function.
5846 (Fload): Bind Qlexical_binding.
5847 (readevalloop): Remove `evalfun' arg.
5848 Bind Qinternal_interpreter_environment.
5849 (Feval_buffer): Bind Qlexical_binding.
5850 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5852 (syms_of_lread): Declare `lexical-binding'.
5854 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5856 * keyboard.c (eval_dyn): New fun.
5857 (menu_item_eval_property): Use it.
5859 * image.c (parse_image_spec): Use Ffunctionp.
5861 * fns.c (concat, mapcar1): Accept byte-code-functions.
5863 * eval.c (Fsetq): Handle lexical vars.
5864 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5865 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5866 (FletX, Flet): Obey lexical binding.
5867 (Fcommandp): Handle closures.
5868 (Feval): New `lexical' arg.
5869 (eval_sub): New function extracted from Feval. Use it almost
5870 everywhere where Feval was used. Look up vars in lexical env.
5872 (Ffunctionp): Move from subr.el.
5873 (Ffuncall): Handle closures.
5874 (apply_lambda): Remove `eval_flags'.
5875 (funcall_lambda): Handle closures and new byte-code-functions.
5876 (Fspecial_variable_p): New function.
5877 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5878 but without exporting it to Lisp.
5880 * doc.c (Fdocumentation, store_function_docstring):
5881 * data.c (Finteractive_form): Handle closures.
5883 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5886 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5888 (exec_byte_code): New function extracted from Fbyte_code to handle new
5889 calling convention for byte-code-functions. Add new byte-codes.
5891 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5893 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5895 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5897 * xdisp.c (redisplay_internal): Fix prototype.
5899 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5901 * xdisp.c (SCROLL_LIMIT): New macro.
5902 (try_scrolling): Use it when setting scroll_limit.
5903 Limit scrolling to 100 screen lines.
5904 (redisplay_window): Even when falling back on "recentering",
5905 position point in the window according to scroll-conservatively,
5906 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5908 (try_scrolling): When point is above the window, allow searching
5909 as far as scroll_max, or one screenful, to compute vertical
5910 distance from PT to the scroll margin position. This prevents
5911 try_scrolling from unnecessarily failing when
5912 scroll-conservatively is set to a value slightly larger than the
5913 window height. Clean up the case of PT below the margin at bottom
5914 of window: scroll_max can no longer be INT_MAX. When aggressive
5915 scrolling is in use, don't let point enter the opposite scroll
5916 margin as result of the scroll.
5917 (syms_of_xdisp) <scroll-conservatively>: Document the
5918 threshold of 100 lines for never-recentering scrolling.
5920 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5922 * dispextern.h (move_it_by_lines):
5923 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5924 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5925 (message_log_check_duplicate): Remove parameters `prev_bol' and
5926 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5927 (redisplay_internal): Remove parameter `preserve_echo_area',
5928 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5930 * indent.c (Fvertical_motion):
5931 * window.c (window_scroll_pixel_based, Frecenter):
5932 Don't pass `need_y_p' to `move_it_by_lines'.
5934 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5936 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5937 steal a few bits to be more compact.
5938 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5939 Remove unneeded casts.
5941 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5943 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5945 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5946 binding" message (bug#7967).
5948 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5950 Fix more problems found by GCC 4.6.0's static checks.
5952 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5953 Remove unused local var.
5955 * editfns.c (Fmessage_box): Remove unused local var.
5957 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5958 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5959 Omit unused local vars.
5960 * window.c (shrink_windows): Omit unused local var.
5961 * menu.c (digest_single_submenu): Omit unused local var.
5962 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5963 Omit unused local var.
5965 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5966 Don't assume string length fits in int.
5967 (keyremap_step, read_key_sequence): Use size_t for sizes.
5968 (read_key_sequence): Don't check last_real_key_start redundantly.
5970 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5971 instead of alloca (Bug#8344).
5973 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5974 (Fbacktrace_frame): Don't assume nframes fits in int.
5976 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5978 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5981 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5983 * cm.c (calccost): Turn while-do into do-while, for clarity.
5985 * keyboard.c (syms_of_keyboard): Use the same style as later
5986 in this function when indexing through an array. This also
5987 works around GCC bug 48267.
5989 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5991 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5993 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5994 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5996 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5997 This avoids undefined behavior on integer overflow, and is a bit
5998 more convenient anyway since it is compared to a size_t variable.
6000 Variadic C functions now count arguments with size_t, not int.
6001 This avoids an unnecessary limitation on 64-bit machines, which
6002 caused (substring ...) to crash on large vectors (Bug#8344).
6003 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6004 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6005 All variadic functions and their callers changed accordingly.
6006 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6007 * data.c (arith_driver, float_arith_driver): Likewise.
6008 * editfns.c (general_insert_function): Likewise.
6009 * eval.c (struct backtrace.nargs, interactive_p)
6010 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6011 (funcall_lambda, mark_backtrace): Likewise.
6012 * fns.c (concat): Likewise.
6013 * frame.c (x_set_frame_parameters): Likewise.
6014 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6015 0 if not found, not -1. All callers changed.
6017 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6018 (stack_copy_size): Now size_t, not int.
6019 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6021 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6023 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6024 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6025 All callers changed.
6027 * lisp.h (multibyte_char_to_unibyte):
6028 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6029 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6030 * character.h (CHAR_TO_BYTE8):
6031 * cmds.c (internal_self_insert):
6032 * editfns.c (general_insert_function):
6033 * keymap.c (push_key_description):
6034 * search.c (Freplace_match):
6035 * xdisp.c (message_dolog, set_message_1): All callers changed.
6037 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6039 * keyboard.c (safe_run_hook_funcall): New function.
6040 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6041 don't set the hook to nil, but remove the offending function instead.
6042 (Qcommand_hook_internal): Remove, unused.
6043 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6044 Vcommand_hook_internal.
6046 * eval.c (enum run_hooks_condition): Remove.
6047 (funcall_nil, funcall_not): New functions.
6048 (run_hook_with_args): Call each function through a `funcall' argument.
6049 Remove `cond' argument, now redundant.
6050 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6051 (Frun_hook_with_args_until_failure): Adjust accordingly.
6052 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6054 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6056 * dispextern.h (string_buffer_position): Remove declaration.
6058 * print.c (strout): Remove parameter `multibyte', unused since
6059 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6061 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6062 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6063 All callers changed.
6065 * w32.c (_wsa_errlist): Use braces for struct initializers.
6067 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6068 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6069 All callers changed.
6070 (string_buffer_position): Likewise. Also, make static (it's never
6071 used outside xdisp.c).
6072 (cursor_row_p): Remove parameter `w', unused since
6073 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6074 (decode_mode_spec): Remove parameter `precision', introduced during
6075 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6076 All callers changed.
6078 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6080 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6082 2011-03-27 Anders Lindgren <andlind@gmail.com>
6084 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6085 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6086 (ns_update_auto_hide_menu_bar): New functions.
6087 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6088 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6089 ns_constrain_all_frames.
6090 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6091 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6093 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6095 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6097 2011-03-27 Glenn Morris <rgm@gnu.org>
6099 * syssignal.h: Replace RETSIGTYPE with void.
6100 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6101 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6102 Replace SIGTYPE with void everywhere.
6103 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6104 * s/template.h (SIGTYPE): Remove commented out definition.
6106 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6108 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6109 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6111 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6113 * w32.c (read_unc_volume): Use parameter `henum', instead of
6114 global variable `wget_enum_handle'.
6116 * keymap.c (describe_vector): Remove parameters `indices' and
6117 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6118 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6120 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6122 * keyboard.c (timer_check): Remove parameter `do_it_now',
6123 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6124 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6125 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6127 * keyboard.c (read_char):
6128 * w32menu.c (w32_menu_display_help):
6129 * xmenu.c (show_help_event, menu_help_callback):
6130 Adjust calls to `show_help_echo'.
6132 * gtkutil.c (xg_maybe_add_timer):
6133 * keyboard.c (readable_events):
6134 * process.c (wait_reading_process_output):
6135 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6137 * insdel.c (adjust_markers_gap_motion):
6138 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6139 (gap_left, gap_right): Don't call it.
6141 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6143 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6144 incurred during fontification.
6146 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6148 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6149 (DEFVAR_PER_BUFFER): Don't pass it.
6151 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6152 (scrolling_window): Don't pass it.
6154 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6156 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6158 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6160 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6161 of variables specific to SELinux and computation of `encoded_absname'.
6163 * image.c (XPutPixel): Remove unused variable `height'.
6165 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6167 * unexw32.c (get_section_info): Remove unused variable `section'.
6169 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6170 (system_process_attributes): Remove unused variable `sess'.
6171 (sys_read): Remove unused variable `err'.
6173 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6174 (w32_wnd_proc): Remove unused variable `isdead'.
6175 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6176 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6177 (x_create_tip_frame): Remove unused variable `tem'.
6179 * w32inevt.c (w32_console_read_socket):
6180 Remove unused variable `no_events'.
6182 * w32term.c (x_draw_composite_glyph_string_foreground):
6183 Remove unused variable `width'.
6185 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6187 * w32term.c (x_set_glyph_string_clipping):
6188 Don't pass uninitialized region to CombineRgn.
6190 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6192 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6193 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6194 (Fx_close_connection): Remove unused variable `i'.
6196 * w32font.c (w32font_draw): Return number of glyphs.
6197 (w32font_open_internal): Remove unused variable `i'.
6198 (w32font_driver): Add missing initializer.
6200 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6201 (fill_in_menu): Remove unused variable `items_added'.
6203 * w32term.c (last_mouse_press_frame): Remove static global variable.
6204 (w32_clip_to_row): Remove unused variable `f'.
6205 (x_delete_terminal): Remove unused variable `i'.
6207 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6208 (NOTHING): Remove unused static global variable.
6209 (uniscribe_check_otf): Remove unused variable `table'.
6210 (uniscribe_font_driver): Add missing initializers.
6212 2011-03-23 Julien Danjou <julien@danjou.info>
6214 * term.c (Fsuspend_tty, Fresume_tty):
6215 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6216 * window.c (temp_output_buffer_show):
6217 * insdel.c (signal_before_change):
6218 * frame.c (Fhandle_switch_frame):
6219 * fileio.c (Fdo_auto_save):
6220 * emacs.c (Fkill_emacs):
6221 * editfns.c (save_excursion_restore):
6222 * cmds.c (internal_self_insert):
6223 * callint.c (Fcall_interactively):
6224 * buffer.c (Fkill_all_local_variables):
6225 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6227 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6228 unconditionnaly since it does the check itself.
6230 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6232 Fix more problems found by GCC 4.5.2's static checks.
6234 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6235 the first time through the loop, since we know p0 < p1 then.
6236 This also avoids a gcc -Wstrict-overflow warning.
6238 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6239 leading to a memory leak, possible in functions like
6240 load_charset_map_from_file that can allocate an unbounded number
6241 of objects (Bug#8318).
6243 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6244 that could (at least in theory) be that large.
6246 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6247 This is less likely to overflow, and avoids undefined behavior if
6248 overflow does occur. All callers changed. Use strtoul to scan
6249 for the unsigned long integer.
6250 (pint2hrstr): Simplify and tune code slightly.
6251 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6253 * scroll.c (do_scrolling): Work around GCC bug 48228.
6254 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6256 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6257 This also avoids a warning with gcc -Wstrict-overflow.
6258 (validate_x_resource_name): Simplify count usage.
6259 This also avoids a warning with gcc -Wstrict-overflow.
6261 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6264 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6266 * process.c (Fmake_network_process): Use socklen_t, not int,
6267 where POSIX says socklen_t is required in portable programs.
6268 This fixes a porting bug on hosts like 64-bit HP-UX, where
6269 socklen_t is wider than int (Bug#8277).
6270 (Fmake_network_process, server_accept_connection):
6271 (wait_reading_process_output, read_process_output):
6274 * process.c: Rename or move locals to avoid shadowing.
6275 (list_processes_1, Fmake_network_process):
6276 (read_process_output_error_handler, exec_sentinel_error_handler):
6277 Rename or move locals.
6278 (Fmake_network_process): Define label "retry_connect" only if needed.
6279 (Fnetwork_interface_info): Fix pointer signedness.
6280 (process_send_signal): Add cast to avoid pointer signedness problem.
6281 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6282 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6284 Make tparam.h and terminfo.c consistent.
6285 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6286 Include tparam.h instead, since it declares them.
6287 * cm.h (PC): Remove extern decl; tparam.h now does this.
6288 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6289 * terminfo.c: Include tparam.h, to check interfaces.
6290 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6291 (tparam): Adjust signature to match interface in tparam.h;
6292 this removes some undefined behavior. Check that outstring and len
6293 are zero, which they always are with Emacs.
6294 * tparam.h (PC, BC, UP): New extern decls.
6296 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6297 (xftfont_open): Rename locals to avoid shadowing.
6299 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6300 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6301 (OTF_TAG_SYM): Omit macro if not needed.
6302 (ftfont_list): Remove unused local.
6303 (get_adstyle_property, ftfont_pattern_entity):
6304 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6305 Rename locals to avoid shadowing.
6307 * xfont.c (xfont_list_family): Mark var as initialized.
6309 * xml.c (make_dom): Now static.
6311 * composite.c (composition_compute_stop_pos): Rename local to
6313 (composition_reseat_it): Remove unused locals.
6314 (find_automatic_composition, composition_adjust_point): Likewise.
6315 (composition_update_it): Mark var as initialized.
6316 (find_automatic_composition): Mark vars as initialized,
6317 with a FIXME (Bug#8290).
6319 character.h: Rename locals to avoid shadowing.
6320 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6321 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6322 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6323 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6326 * textprop.c (property_change_between_p): Remove; unused.
6328 * intervals.c (interval_start_pos): Now static.
6330 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6332 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6333 Rename locals to avoid shadowing.
6335 * sound.c (wav_play, au_play, Fplay_sound_internal):
6336 Fix pointer signedness.
6337 (alsa_choose_format): Remove unused local var.
6338 (wav_play): Initialize a variable to 0, to prevent undefined
6339 behavior (Bug#8278).
6341 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6343 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6345 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6346 clobbering (Bug#8298).
6347 * sysdep.c (sys_subshell): Likewise.
6348 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6350 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6351 This should get cleaned up, so that child_setup has the
6352 same signature on all platforms.
6354 * callproc.c (call_process_cleanup): Now static.
6355 (relocate_fd): Rename locals to avoid shadowing.
6357 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6359 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6360 not to be necessary, and produces flickering.
6362 2011-03-20 Glenn Morris <rgm@gnu.org>
6364 * config.in: Remove file.
6366 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6368 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6369 are now in src/globals.h.
6370 (syms_of_minibuf): Remove spurious & from previous change.
6372 2011-03-20 Leo <sdl.web@gmail.com>
6374 * minibuf.c (completing-read-function): New variable.
6375 (completing-read-default): Rename from completing-read.
6376 (completing-read): Call completing-read-function.
6378 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6380 * xfaces.c (Fx_load_color_file):
6381 Read color file from absolute filename (bug#8250).
6383 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6385 * makefile.w32-in: Update dependencies.
6387 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6389 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6391 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6393 Fix more problems found by GCC 4.5.2's static checks.
6395 * process.c (make_serial_process_unwind, send_process_trap):
6396 (sigchld_handler): Now static.
6398 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6399 That way, the code declares only the vars that it needs.
6400 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6401 * s/cygwin.h (PTY_ITERATION): Likewise.
6402 * s/darwin.h (PTY_ITERATION): Likewise.
6403 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6405 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6406 * process.c (allocate_pty): Don't declare stb unless it's needed.
6408 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6409 (CONSTANTLIM): Remove; unused.
6410 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6411 Define only if needed.
6413 * unexelf.c (unexec): Name an expression,
6414 to avoid gcc -Wbad-function-cast warning.
6415 Use a different way to cause a compilation error if anyone uses
6416 n rather than nn, a way that does not involve shadowing.
6417 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6419 * deps.mk (unexalpha.o): Remove; unused.
6421 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6422 * unexec.h: New file.
6423 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6424 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6426 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6427 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6428 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6429 Change as necessary to match prototype in unexec.h.
6431 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6433 (back_comment, skip_chars): Mark vars as initialized.
6435 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6436 Rename locals to avoid shadowing.
6438 * lread.c (read1): Rewrite so as not to use empty "else".
6439 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6441 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6443 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6444 warning when compiling print.c.
6446 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6447 instead of using an uninitialized var.
6448 (font_sort_entities): Mark var as initialized.
6450 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6452 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6453 pointers to constants.
6454 (font_parse_fcname): Remove unused vars.
6455 (font_delete_unmatched): Now static.
6456 (font_get_spec): Remove; unused.
6457 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6458 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6459 Rename or move locals to avoid shadowing.
6461 * fns.c (require_nesting_list, require_unwind): Now static.
6462 (Ffillarray): Rename locals to avoid shadowing.
6464 * floatfns.c (domain_error2): Define only if needed.
6465 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6467 * alloc.c (mark_backtrace): Move decl from here ...
6468 * lisp.h: ... to here, so that it can be checked.
6470 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6471 (Fdefvar): Rewrite so as not to use empty "else".
6472 (lisp_indirect_variable): Name an expression,
6473 to avoid gcc -Wbad-function-cast warning.
6474 (Fdefvar): Rename locals to avoid shadowing.
6476 * callint.c (quotify_arg, quotify_args): Now static.
6477 (Fcall_interactively): Rename locals to avoid shadowing.
6478 Use const pointer when appropriate.
6480 * lisp.h (get_system_name, get_operating_system_release):
6481 Move decls here, to check interfaces.
6482 * process.c (get_operating_system_release): Move decl to lisp.h.
6483 * xrdb.c (get_system_name): Likewise.
6484 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6485 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6486 some of which prompt warnings from gcc -Wbad-function-cast.
6487 (Fformat_time_string, Fencode_time, Finsert_char):
6488 (Ftranslate_region_internal, Fformat):
6489 Rename or remove local vars to avoid shadowing.
6490 (Ftranslate_region_internal): Mark var as initialized.
6492 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6495 * lisp.h (eassert): Check that the argument compiles, even if
6496 ENABLE_CHECKING is not defined.
6498 * data.c (Findirect_variable): Name an expression, to avoid
6499 gcc -Wbad-function-cast warning.
6500 (default_value, arithcompare, arith_driver, arith_error): Now static.
6501 (store_symval_forwarding): Rename local to avoid shadowing.
6502 (Fmake_variable_buffer_local, Fmake_local_variable):
6503 Mark variables as initialized.
6504 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6506 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6507 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6508 Rename locals to avoid shadowing.
6509 (mark_stack): Move local variables into the #ifdef region where
6511 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6512 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6514 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6515 (GC_STRING_CHARS): Remove; not used.
6516 (Fmemory_limit): Cast sbrk's returned value to char *.
6518 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6519 avoids undefined behavior in theory.
6521 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6523 Use functions, not macros, for up- and down-casing (Bug#8254).
6524 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6525 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6526 to use the following functions instead of these macros.
6527 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6528 EMACS_INT, since callers assume the returned value fits in int.
6529 (upcase1): Likewise, for UPCASE_TABLE.
6530 (uppercasep, lowercasep, upcase): New static inline functions.
6531 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6532 the race-condition problem in the old DOWNCASE.
6534 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6535 Rename locals to avoid shadowing.
6536 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6537 (regex_compile, re_search_2, re_match_2_internal):
6538 Remove unused local vars.
6539 (FREE_VAR): Rewrite so as not to use empty "else",
6540 which gcc can warn about.
6541 (regex_compile, re_match_2_internal): Mark locals as initialized.
6542 (RETALLOC_IF): Define only if needed.
6543 (WORDCHAR_P): Likewise. This one is never needed, but is used
6544 only in a comment talking about a compiler bug, so put inside
6545 the #if 0 of that comment.
6546 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6547 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6550 * search.c (boyer_moore): Rename locals to avoid shadowing.
6551 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6552 (PREV_CHAR_BOUNDARY): Likewise.
6554 * search.c (simple_search): Remove unused var.
6556 * dired.c (compile_pattern): Move decl from here ...
6557 * lisp.h: ... to here, so that it can be checked.
6558 (struct re_registers): New forward decl.
6560 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6562 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6564 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6565 Rename locals to avoid shadowing.
6566 (Fvertical_motion): Mark locals as initialized.
6568 * casefiddle.c (casify_object, casify_region): Now static.
6569 (casify_region): Mark local as initialized.
6571 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6573 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6574 New macros, so that the caller can use some names other than
6575 gcpro1, gcpro2, etc.
6576 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6578 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6579 argument, for consistency with GCPRO2_VAR, etc: it is now the
6580 prefix of the variable, not the variable itself. All uses
6582 * dired.c (directory_files_internal, file_name_completion):
6583 Rename locals to avoid shadowing.
6585 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6586 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6587 dired.c's scmp function, had undefined behavior.
6588 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6589 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6590 * buffer.h: ... to here, because these macros use current_buffer,
6591 and the new implementation with inline functions needs to have
6592 current_buffer in scope now, rather than later when the macros
6594 (downcase, upcase1): New static inline functions.
6595 (DOWNCASE, UPCASE1): Reimplement using these functions.
6596 This avoids undefined behavior in expressions like
6597 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6598 from race conditions in accessing the global variables
6599 case_temp1 and case_temp2.
6600 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6601 * lisp.h (case_temp1, case_temp2): Remove their decls.
6602 * character.h (ASCII_CHAR_P): Move from here ...
6603 * lisp.h: ... to here, so that the inline functions mentioned
6606 * dired.c (directory_files_internal_unwind): Now static.
6608 * fileio.c (file_name_as_directory, directory_file_name):
6609 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6611 (file_name_as_directory): Use const pointers when appropriate.
6612 (Fexpand_file_name): Likewise. In particular, newdir might
6613 point at constant storage, so make it a const pointer.
6614 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6615 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6617 (Fset_file_times, Finsert_file_contents, auto_save_error):
6618 Rename locals to avoid shadowing.
6620 * minibuf.c (choose_minibuf_frame_1): Now static.
6621 (Ftry_completion, Fall_completions): Rename or remove locals
6624 * marker.c (bytepos_to_charpos): Remove; unused.
6626 * lisp.h (verify_bytepos, count_markers): New decls,
6627 so that gcc does not warn that these functions aren't declared.
6629 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6630 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6631 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6632 (copy_text): Remove unused local var.
6634 * filelock.c (within_one_second): Now static.
6635 (lock_file_1): Rename local to avoid shadowing.
6637 * buffer.c (fix_overlays_before): Mark locals as initialized.
6638 (fix_start_end_in_overlays): Likewise. This function should be
6639 simplified by using pointers-to-pointers, but that's a different
6641 (switch_to_buffer_1): Now static.
6642 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6643 (report_overlay_modification): Rename locals to avoid shadowing.
6645 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6646 Fix pointer signedness issue.
6647 (sys_subshell): Mark local as volatile if checking for lint,
6648 to suppress a gcc -Wclobbered warning that does not seem to be right.
6649 (MAXPATHLEN): Define only if needed.
6651 * process.c (serial_open, serial_configure): Move decls from here ...
6652 * systty.h: ... to here, so that they can be checked.
6654 * fns.c (get_random, seed_random): Move extern decls from here ...
6655 * lisp.h: ... to here, so that they can be checked.
6657 * sysdep.c (reset_io): Now static.
6658 (wait_for_termination_signal): Remove; unused.
6660 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6661 (copy_keymap_item, append_key, push_text_char_description):
6663 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6664 (DENSE_TABLE_SIZE): Remove; unused.
6665 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6666 (describe_map_tree):
6667 Rename locals to avoid shadowing.
6669 * keyboard.c: Declare functions static if they are not used elsewhere.
6670 (echo_char, echo_dash, cmd_error, top_level_2):
6671 (poll_for_input, handle_async_input): Now static.
6672 (read_char, kbd_buffer_get_event, make_lispy_position):
6673 (make_lispy_event, make_lispy_movement, apply_modifiers):
6674 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6675 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6676 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6677 (read_key_sequence, read_char): Mark locals as initialized.
6678 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6680 * keyboard.h (make_ctrl_char): New decl.
6681 (mark_kboards): Move decl here ...
6682 * alloc.c (mark_kboards): ... from here.
6684 * lisp.h (force_auto_save_soon): New decl.
6686 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6687 (DEFINE_DUMMY_FUNCTION): New macro.
6688 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6690 (main): Add casts to avoid warnings
6691 if GCC considers string literals to be constants.
6693 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6695 * dbusbind.c: Pointer signedness fixes.
6696 (xd_signature, xd_append_arg, xd_initialize):
6697 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6698 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6699 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6700 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6702 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6703 if GCC considers string literals to be constants.
6704 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6706 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6708 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6709 (print_preprocess, print_object): New macro to fix last change.
6711 * print.c (print_preprocess): Don't forget font objects.
6713 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6715 * emacs.c (USAGE3): Doc fixes.
6717 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6719 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6722 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6724 * lisp.h (VWindow_system, Qfile_name_history):
6725 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6726 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6727 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6729 * w32select.c: Don't #include "keyboard.h".
6730 (run_protected): Add extern declaration for waiting_for_input.
6732 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6733 * w32console.c (detect_input_pending, read_input_pending)
6734 (encode_terminal_code):
6735 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6736 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6737 (w32_system_caret_y, Qfile_name_history):
6738 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6739 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6740 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6741 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6742 * w32proc.c (Qlocal, report_file_error):
6743 * w32term.c (Vwindow_system, updating_frame):
6744 * w32uniscribe.c (initialized, uniscribe_font_driver):
6745 Remove unneeded extern declarations.
6747 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6749 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6751 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6753 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6754 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6755 These macros can no longer be used for assignment.
6757 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6758 Assign struct members directly, instead of using BUF_BEGV etc.
6759 (record_buffer_markers, fetch_buffer_markers): New functions for
6760 recording and fetching special buffer markers.
6761 (set_buffer_internal_1, set_buffer_temp): Use them.
6763 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6765 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6767 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6768 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6770 * xdisp.c (hscroll_window_tree):
6771 (reconsider_clip_changes): Use PT instead of BUF_PT.
6773 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6775 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6776 $(EMACS_ROOT)/lib/intprops.h.
6778 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6780 Fix more problems found by GCC 4.5.2's static checks.
6782 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6783 to unsigned char * to avoid compiler diagnostic.
6784 (xg_free_frame_widgets): Make it clear that a local variable is
6785 needed only if USE_GTK_TOOLTIP.
6786 (gdk_window_get_screen): Make it clear that this macro is needed
6787 only if USE_GTK_TOOLTIP.
6788 (int_gtk_range_get_value): New function, which avoids a diagnostic
6789 from gcc -Wbad-function-cast.
6790 (xg_set_toolkit_scroll_bar_thumb): Use it.
6791 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6792 diagnostic from gcc -Wbad-function-cast.
6793 (get_utf8_string, xg_get_file_with_chooser):
6794 Rename locals to avoid shadowing.
6795 (create_dialog): Move locals to avoid shadowing.
6797 * xgselect.c (xg_select): Remove unused var.
6799 * image.c (four_corners_best): Mark locals as initialized.
6800 (gif_load): Initialize transparent_p to zero (Bug#8238).
6801 Mark another local as initialized.
6802 (my_png_error, my_error_exit): Mark with NO_RETURN.
6804 * image.c (clear_image_cache): Now static.
6805 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6806 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6807 (x_edge_detection): Remove unnecessary cast that
6808 gcc -Wbad-function-cast diagnoses.
6809 (gif_load): Fix pointer signedness.
6810 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6811 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6813 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6815 Improve quality of tests for time stamp overflow.
6816 For example, without this patch (encode-time 0 0 0 1 1
6817 1152921504606846976) returns the obviously-bogus value (-948597
6818 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6819 reports time overflow. See
6820 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6821 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6822 * editfns.c: Include limits.h and intprops.h.
6823 (TIME_T_MIN, TIME_T_MAX): New macros.
6824 (time_overflow): Move earlier, to before first use.
6825 (hi_time, lo_time): New functions, for an accurate test for
6827 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6828 (Fget_internal_run_time): Don't assume time_t fits in int.
6829 (make_time): Use list2 instead of Fcons twice.
6830 (Fdecode_time): More accurate test for out-of-range times.
6831 (check_tm_member): New function.
6832 (Fencode_time): Use it, to test for out-of-range times.
6833 (lisp_time_argument): Don't rely on undefined left-shift and
6834 right-shift behavior when checking for time stamp overflow.
6836 * editfns.c (time_overflow): New function, refactoring common code.
6837 (Fformat_time_string, Fdecode_time, Fencode_time):
6838 (Fcurrent_time_string): Use it.
6840 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6841 * dired.c (make_time): Move to ...
6842 * editfns.c (make_time): ... here.
6843 * systime.h: Note the move.
6845 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6847 * fringe.c (update_window_fringes): Remove unused variables.
6849 * unexmacosx.c (copy_data_segment): Also copy __got section.
6852 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6854 * termcap.c [MSDOS]: Include "msdos.h".
6855 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6856 Constify `char *' arguments and their references according to
6857 prototypes in tparam.h.
6859 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6861 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6862 Adapt all references accordingly.
6864 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6866 2011-03-11 Tom Tromey <tromey@redhat.com>
6868 * buffer.c (syms_of_buffer): Remove obsolete comment.
6870 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6872 * termhooks.h (encode_terminal_code): Declare prototype.
6874 * msdos.c (encode_terminal_code): Don't declare prototype.
6876 * term.c (encode_terminal_code): Now external again, used by
6877 w32console.c and msdos.c.
6879 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6880 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6882 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6884 Fix some minor problems found by GCC 4.5.2's static checks.
6886 * fringe.c (update_window_fringes): Mark locals as initialized
6888 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6890 * alloc.c (mark_fringe_data): Move decl from here ...
6891 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6892 to check its interface.
6893 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6895 * fontset.c (free_realized_fontset): Now static.
6896 (Fset_fontset_font): Rename local to avoid shadowing.
6897 (fontset_font): Mark local as initialized.
6898 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6900 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6902 * xselect.c (x_disown_buffer_selections): Remove; not used.
6903 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6904 (x_own_selection, Fx_disown_selection_internal): Rename locals
6906 (x_handle_dnd_message): Remove local to avoid shadowing.
6908 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6909 so that the caller can use some name other than gcpro1.
6910 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6911 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6912 (Fx_backspace_delete_keys_p):
6913 Use them to avoid shadowing, and rename vars to avoid shadowing.
6914 (x_decode_color, x_set_name, x_window): Now static.
6915 (Fx_create_frame): Add braces to silence GCC warning.
6916 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6917 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6918 Remove unused locals.
6919 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6920 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6921 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6924 * xterm.h (x_mouse_leave): New decl.
6926 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6927 Remove unused functions.
6928 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6929 (x_calc_absolute_position): Now static.
6930 (XTread_socket): Don't define label "out" unless it's used.
6931 Don't declare local "event" unless it's used.
6932 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6933 unless they are used.
6934 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6935 (x_fatal_error_signal): Remove; not used.
6936 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6937 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6938 (x_error_catcher, x_connection_closed, x_error_handler):
6939 (x_error_quitter, xembed_send_message, x_iconify_frame):
6940 (my_log_handler): Rename locals to avoid shadowing.
6941 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6942 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6944 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6945 Rename or move locals to avoid shadowing.
6946 (tty_defined_color, merge_face_heights): Now static.
6947 (free_realized_faces_for_fontset): Remove; not used.
6948 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6949 does not deduce is never used uninitialized.
6950 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6951 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6953 * terminal.c (store_terminal_param): Now static.
6955 * xmenu.c (menu_highlight_callback): Now static.
6956 (set_frame_menubar): Remove unused local.
6957 (xmenu_show): Rename parameter to avoid shadowing.
6958 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6959 since they might point to immutable storage.
6960 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6961 since it's unused otherwise.
6963 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6964 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6965 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6966 avoids a gcc -Wuninitialized diagnostic.
6967 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6968 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6969 does not deduce are never used uninitialized.
6971 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6973 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6974 * window.c (window_loop, size_window):
6975 (run_window_configuration_change_hook, enlarge_window): Likewise.
6977 * window.c (display_buffer): Now static.
6978 (size_window): Mark variables that gcc -Wuninitialized
6979 does not deduce are never used uninitialized.
6980 * window.h (check_all_windows): New decl, to forestall
6981 gcc -Wmissing-prototypes diagnostic.
6982 * dispextern.h (bidi_dump_cached_states): Likewise.
6984 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6986 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6988 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6989 and to avoid gcc -Wuninitialized warning.
6990 (load_charset_map): Mark variables that gcc -Wuninitialized
6991 does not deduce are never used uninitialized.
6992 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6994 * coding.c (coding_set_source, coding_set_destination):
6995 Use "else { /* comment */ }" rather than "else /* comment */;"
6996 for clarity, and to avoid gcc -Wempty-body warning.
6997 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6998 a block, when the outer 'i' will do.
6999 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7000 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7001 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7002 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7003 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7004 Rename locals to avoid shadowing.
7005 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7006 * coding.c (emacs_mule_char, encode_invocation_designation):
7007 Now static, since they're not used elsewhere.
7008 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7009 (decode_coding_object, encode_coding_object, detect_coding_system):
7010 (decode_coding_emacs_mule): Mark variables that gcc
7011 -Wuninitialized does not deduce are never used uninitialized.
7012 (detect_coding_iso_2022): Initialize a local variable that might
7013 be used uninitialized. Leave a FIXME because it's not clear that
7014 this initialization is needed. (Bug#8211)
7015 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7016 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7017 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7018 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7019 Remove unused macros.
7021 * category.c (hash_get_category_set): Remove unused local var.
7022 (copy_category_table): Now static, since it's not used elsewhere.
7023 * character.c (string_count_byte8): Likewise.
7025 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7026 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7028 * chartab.c (copy_sub_char_table): Now static, since it's not used
7030 (sub_char_table_ref_and_range, char_table_ref_and_range):
7031 Rename locals to avoid shadowing.
7032 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7034 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7035 (BIDI_BOB): Remove unused macro.
7037 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7038 deduce are never used uninitialized.
7039 * term.c (encode_terminal_code): Likewise.
7041 * term.c (encode_terminal_code): Now static. Remove unused local.
7043 * tparam.h: New file.
7044 * term.c, tparam.h: Include it.
7045 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7046 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7047 Move these decls to tparam.h, and make them agree with what
7048 is actually in tparam.c. The previous trick of using incompatible
7049 decls in different modules does not conform to the C standard.
7050 All callers of tparam changed to use tparam's actual API.
7051 * tparam.c (tparam1, tparam, tgoto):
7052 Use const pointers where appropriate.
7054 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7055 * cm.h (struct cm): Likewise.
7056 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7057 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7058 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7059 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7060 (turn_on_face, init_tty): Likewise.
7061 * termchar.h (struct tty_display_info): Likewise.
7063 * term.c (term_mouse_position): Rename local to avoid shadowing.
7065 * alloc.c (mark_ttys): Move decl from here ...
7066 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7068 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7070 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7072 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7074 * search.c (compile_pattern_1): Remove argument regp, unused since
7075 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7076 (compile_pattern): Don't pass it.
7078 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7080 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7081 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7083 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7085 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7087 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7088 gdk_window_get_screen, gdk_window_get_geometry,
7089 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7090 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7091 (xg_get_pixbuf_from_pixmap): New function.
7092 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7093 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7094 Call xg_get_pixbuf_from_pixmap instead of
7095 gdk_pixbuf_get_from_drawable.
7096 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7097 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7098 (xg_check_special_colors): Use GtkStyleContext and its functions
7100 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7101 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7102 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7103 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7104 Call gtk_widget_get_preferred_size.
7105 (xg_frame_resized): gdk_window_get_geometry only takes 5
7107 (xg_win_to_widget, xg_event_is_for_menubar):
7108 Call gdk_x11_window_lookup_for_display.
7109 (xg_set_widget_bg): New function.
7110 (delete_cb): New function.
7111 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7112 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7113 (xg_set_background_color): Call xg_set_widget_bg.
7114 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7115 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7116 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7117 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7119 (update_frame_tool_bar): Call gtk_widget_hide.
7120 (xg_initialize): Use GDK_KEY_g.
7122 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7124 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7126 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7127 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7128 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7130 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7132 * w32xfns.c (select_palette): Check success of RealizePalette against
7133 GDI_ERROR, not zero.
7135 See ChangeLog.11 for earlier changes.
7141 Copyright (C) 2011 Free Software Foundation, Inc.
7143 This file is part of GNU Emacs.
7145 GNU Emacs is free software: you can redistribute it and/or modify
7146 it under the terms of the GNU General Public License as published by
7147 the Free Software Foundation, either version 3 of the License, or
7148 (at your option) any later version.
7150 GNU Emacs is distributed in the hope that it will be useful,
7151 but WITHOUT ANY WARRANTY; without even the implied warranty of
7152 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7153 GNU General Public License for more details.
7155 You should have received a copy of the GNU General Public License
7156 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.