* apt-pkg/pkgcache.cc:
authorMichael Vogt <michael.vogt@ubuntu.com>
Mon, 9 Feb 2009 13:38:11 +0000 (14:38 +0100)
committerMichael Vogt <michael.vogt@ubuntu.com>
Mon, 9 Feb 2009 13:38:11 +0000 (14:38 +0100)
  - do not run "dpkg --configure pkg" if pkg is in trigger-awaited
    state (LP: #322955)
  - do not unlink files in partial/ (thanks to robbiew)

apt-pkg/pkgcache.cc
debian/changelog
methods/https.cc

index 8eb6208..4fbf42c 100644 (file)
@@ -275,8 +275,12 @@ pkgCache::PkgIterator::OkState pkgCache::PkgIterator::State() const
    
    if (Pkg->CurrentState == pkgCache::State::UnPacked ||
        Pkg->CurrentState == pkgCache::State::HalfConfigured ||
-       Pkg->CurrentState == pkgCache::State::TriggersPending ||
-       Pkg->CurrentState == pkgCache::State::TriggersAwaited)
+      //we don't need to care for triggers awaiting packages
+      //dpkg will deal with them automatically when the 
+      //trigger pending action is run (those packages are usually
+      //in half-configured or triggers-pending state)
+      //Pkg->CurrentState == pkgCache::State::TriggersAwaited
+       Pkg->CurrentState == pkgCache::State::TriggersPending)
       return NeedsConfigure;
    
    if (Pkg->CurrentState == pkgCache::State::HalfInstalled ||
index 23a0514..0e2d3af 100644 (file)
@@ -32,8 +32,12 @@ apt (0.7.20.2ubuntu1) jaunty; urgency=low
   * cmdline/apt-get.cc:
     - default to "false" for the "APT::Get::Build-Dep-Automatic"
       option (follow debian here)
+  * apt-pkg/pkgcache.cc:
+    - do not run "dpkg --configure pkg" if pkg is in trigger-awaited
+      state (LP: #322955)
   * methods/https.cc:
     - add Acquire::https::AllowRedirect support
+    - do not unlink files in partial/ (thanks to robbiew)
 
   [ Dereck Wonnacott ]
   * Clarify the --help for 'purge' (LP: #243948)
index 87de545..8bf44b5 100644 (file)
@@ -253,7 +253,6 @@ bool HttpsMethod::Fetch(FetchItem *Itm)
    // cleanup
    if(success != 0) 
    {
-      unlink(File->Name().c_str());
       _error->Error("%s", curl_errorstr);
       Fail();
       return true;