apt-pkg/packagemanager.cc

   1 // -*- mode: cpp; mode: fold -*-
   2 // Description                                                          /*{{{*/
   3 // $Id: packagemanager.cc,v 1.30 2003/04/27 03:04:15 doogie Exp $
   4 /* ######################################################################
   5
   6    Package Manager - Abstacts the package manager
   7
   8    More work is needed in the area of transitioning provides, ie exim
   9    replacing smail. This can cause interesing side effects.
  10
  11    Other cases involving conflicts+replaces should be tested.
  12
  13    ##################################################################### */
  14                                                                         /*}}}*/
  15 // Include Files                                                        /*{{{*/
  16 #include <apt-pkg/packagemanager.h>
  17 #include <apt-pkg/orderlist.h>
  18 #include <apt-pkg/depcache.h>
  19 #include <apt-pkg/error.h>
  20 #include <apt-pkg/version.h>
  21 #include <apt-pkg/acquire-item.h>
  22 #include <apt-pkg/algorithms.h>
  23 #include <apt-pkg/configuration.h>
  24 #include <apt-pkg/sptr.h>
  25
  26 #include <apti18n.h>
  27 #include <iostream>
  28 #include <fcntl.h>
  29                                                                         /*}}}*/
  30 using namespace std;
  31
  32 // PM::PackageManager - Constructor                                     /*{{{*/
  33 // ---------------------------------------------------------------------
  34 /* */
  35 pkgPackageManager::pkgPackageManager(pkgDepCache *pCache) : Cache(*pCache)
  36 {
  37    FileNames = new string[Cache.Head().PackageCount];
  38    List = 0;
  39    Debug = _config->FindB("Debug::pkgPackageManager",false);
  40 }
  41                                                                         /*}}}*/
  42 // PM::PackageManager - Destructor                                      /*{{{*/
  43 // ---------------------------------------------------------------------
  44 /* */
  45 pkgPackageManager::~pkgPackageManager()
  46 {
  47    delete List;
  48    delete [] FileNames;
  49 }
  50                                                                         /*}}}*/
  51 // PM::GetArchives - Queue the archives for download                    /*{{{*/
  52 // ---------------------------------------------------------------------
  53 /* */
  54 bool pkgPackageManager::GetArchives(pkgAcquire *Owner,pkgSourceList *Sources,
  55                                     pkgRecords *Recs)
  56 {
  57    if (CreateOrderList() == false)
  58       return false;
  59
  60    bool const ordering =
  61         _config->FindB("PackageManager::UnpackAll",true) ?
  62                 List->OrderUnpack() : List->OrderCritical();
  63    if (ordering == false)
  64       return _error->Error("Internal ordering error");
  65
  66    for (pkgOrderList::iterator I = List->begin(); I != List->end(); I++)
  67    {
  68       PkgIterator Pkg(Cache,*I);
  69       FileNames[Pkg->ID] = string();
  70
  71       // Skip packages to erase
  72       if (Cache[Pkg].Delete() == true)
  73          continue;
  74
  75       // Skip Packages that need configure only.
  76       if (Pkg.State() == pkgCache::PkgIterator::NeedsConfigure &&
  77           Cache[Pkg].Keep() == true)
  78          continue;
  79
  80       // Skip already processed packages
  81       if (List->IsNow(Pkg) == false)
  82          continue;
  83
  84       new pkgAcqArchive(Owner,Sources,Recs,Cache[Pkg].InstVerIter(Cache),
  85                         FileNames[Pkg->ID]);
  86    }
  87
  88    return true;
  89 }
  90                                                                         /*}}}*/
  91 // PM::FixMissing - Keep all missing packages                           /*{{{*/
  92 // ---------------------------------------------------------------------
  93 /* This is called to correct the installation when packages could not
  94    be downloaded. */
  95 bool pkgPackageManager::FixMissing()
  96 {
  97    pkgDepCache::ActionGroup group(Cache);
  98    pkgProblemResolver Resolve(&Cache);
  99    List->SetFileList(FileNames);
 100
 101    bool Bad = false;
 102    for (PkgIterator I = Cache.PkgBegin(); I.end() == false; I++)
 103    {
 104       if (List->IsMissing(I) == false)
 105          continue;
 106
 107       // Okay, this file is missing and we need it. Mark it for keep
 108       Bad = true;
 109       Cache.MarkKeep(I, false, false);
 110    }
 111
 112    // We have to empty the list otherwise it will not have the new changes
 113    delete List;
 114    List = 0;
 115
 116    if (Bad == false)
 117       return true;
 118
 119    // Now downgrade everything that is broken
 120    return Resolve.ResolveByKeep() == true && Cache.BrokenCount() == 0;
 121 }
 122                                                                         /*}}}*/
 123 // PM::ImmediateAdd - Add the immediate flag recursivly                 /*{{{*/
 124 // ---------------------------------------------------------------------
 125 /* This adds the immediate flag to the pkg and recursively to the
 126    dependendies
 127  */
 128 void pkgPackageManager::ImmediateAdd(PkgIterator I, bool UseInstallVer)
 129 {
 130    DepIterator D;
 131
 132    if(UseInstallVer)
 133    {
 134       if(Cache[I].InstallVer == 0)
 135          return;
 136       D = Cache[I].InstVerIter(Cache).DependsList();
 137    } else {
 138       if (I->CurrentVer == 0)
 139          return;
 140       D = I.CurrentVer().DependsList();
 141    }
 142
 143    for ( /* nothing */  ; D.end() == false; D++)
 144       if (D->Type == pkgCache::Dep::Depends || D->Type == pkgCache::Dep::PreDepends)
 145       {
 146          if(!List->IsFlag(D.TargetPkg(), pkgOrderList::Immediate))
 147          {
 148             if(Debug)
 149                clog << "ImmediateAdd(): Adding Immediate flag to " << I.Name() << endl;
 150             List->Flag(D.TargetPkg(),pkgOrderList::Immediate);
 151             ImmediateAdd(D.TargetPkg(), UseInstallVer);
 152          }
 153       }
 154    return;
 155 }
 156                                                                         /*}}}*/
 157 // PM::CreateOrderList - Create the ordering class                      /*{{{*/
 158 // ---------------------------------------------------------------------
 159 /* This populates the ordering list with all the packages that are
 160    going to change. */
 161 bool pkgPackageManager::CreateOrderList()
 162 {
 163    if (List != 0)
 164       return true;
 165
 166    delete List;
 167    List = new pkgOrderList(&Cache);
 168
 169    static bool const NoImmConfigure = !_config->FindB("APT::Immediate-Configure",true);
 170
 171    // Generate the list of affected packages and sort it
 172    for (PkgIterator I = Cache.PkgBegin(); I.end() == false; I++)
 173    {
 174       // Ignore no-version packages
 175       if (I->VersionList == 0)
 176          continue;
 177
 178       // Mark the package and its dependends for immediate configuration
 179       if (((I->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential ||
 180            (I->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important) &&
 181           NoImmConfigure == false)
 182       {
 183          if(Debug)
 184             clog << "CreateOrderList(): Adding Immediate flag for " << I.Name() << endl;
 185          List->Flag(I,pkgOrderList::Immediate);
 186
 187          // Look for other install packages to make immediate configurea
 188          ImmediateAdd(I, true);
 189
 190          // And again with the current version.
 191          ImmediateAdd(I, false);
 192       }
 193
 194       // Not interesting
 195       if ((Cache[I].Keep() == true ||
 196           Cache[I].InstVerIter(Cache) == I.CurrentVer()) &&
 197           I.State() == pkgCache::PkgIterator::NeedsNothing &&
 198           (Cache[I].iFlags & pkgDepCache::ReInstall) != pkgDepCache::ReInstall &&
 199           (I.Purge() != false || Cache[I].Mode != pkgDepCache::ModeDelete ||
 200            (Cache[I].iFlags & pkgDepCache::Purge) != pkgDepCache::Purge))
 201          continue;
 202
 203       // Append it to the list
 204       List->push_back(I);
 205    }
 206
 207    return true;
 208 }
 209                                                                         /*}}}*/
 210 // PM::DepAlwaysTrue - Returns true if this dep is irrelevent           /*{{{*/
 211 // ---------------------------------------------------------------------
 212 /* The restriction on provides is to eliminate the case when provides
 213    are transitioning between valid states [ie exim to smail] */
 214 bool pkgPackageManager::DepAlwaysTrue(DepIterator D)
 215 {
 216    if (D.TargetPkg()->ProvidesList != 0)
 217       return false;
 218
 219    if ((Cache[D] & pkgDepCache::DepInstall) != 0 &&
 220        (Cache[D] & pkgDepCache::DepNow) != 0)
 221       return true;
 222    return false;
 223 }
 224                                                                         /*}}}*/
 225 // PM::CheckRConflicts - Look for reverse conflicts                     /*{{{*/
 226 // ---------------------------------------------------------------------
 227 /* This looks over the reverses for a conflicts line that needs early
 228    removal. */
 229 bool pkgPackageManager::CheckRConflicts(PkgIterator Pkg,DepIterator D,
 230                                         const char *Ver)
 231 {
 232    for (;D.end() == false; D++)
 233    {
 234       if (D->Type != pkgCache::Dep::Conflicts &&
 235           D->Type != pkgCache::Dep::Obsoletes)
 236          continue;
 237
 238       // The package hasnt been changed
 239       if (List->IsNow(Pkg) == false)
 240          continue;
 241
 242       // Ignore self conflicts, ignore conflicts from irrelevent versions
 243       if (D.ParentPkg() == Pkg || D.ParentVer() != D.ParentPkg().CurrentVer())
 244          continue;
 245
 246       if (Cache.VS().CheckDep(Ver,D->CompareOp,D.TargetVer()) == false)
 247          continue;
 248
 249       if (EarlyRemove(D.ParentPkg()) == false)
 250          return _error->Error("Reverse conflicts early remove for package '%s' failed",
 251                               Pkg.Name());
 252    }
 253    return true;
 254 }
 255                                                                         /*}}}*/
 256 // PM::ConfigureAll - Run the all out configuration                     /*{{{*/
 257 // ---------------------------------------------------------------------
 258 /* This configures every package. It is assumed they are all unpacked and
 259    that the final configuration is valid. */
 260 bool pkgPackageManager::ConfigureAll()
 261 {
 262    pkgOrderList OList(&Cache);
 263
 264    // Populate the order list
 265    for (pkgOrderList::iterator I = List->begin(); I != List->end(); I++)
 266       if (List->IsFlag(pkgCache::PkgIterator(Cache,*I),
 267                        pkgOrderList::UnPacked) == true)
 268          OList.push_back(*I);
 269
 270    if (OList.OrderConfigure() == false)
 271       return false;
 272
 273    std::string const conf = _config->Find("PackageManager::Configure","all");
 274    bool const ConfigurePkgs = (conf == "all");
 275
 276    // Perform the configuring
 277    for (pkgOrderList::iterator I = OList.begin(); I != OList.end(); I++)
 278    {
 279       PkgIterator Pkg(Cache,*I);
 280
 281       if (ConfigurePkgs == true && Configure(Pkg) == false)
 282          return false;
 283
 284       List->Flag(Pkg,pkgOrderList::Configured,pkgOrderList::States);
 285    }
 286
 287    return true;
 288 }
 289                                                                         /*}}}*/
 290 // PM::SmartConfigure - Perform immediate configuration of the pkg      /*{{{*/
 291 // ---------------------------------------------------------------------
 292 /* This routine scheduals the configuration of the given package and all
 293    of it's dependents. */
 294 bool pkgPackageManager::SmartConfigure(PkgIterator Pkg)
 295 {
 296    if (Debug == true)
 297       clog << "SmartConfigure " << Pkg.Name() << endl;
 298
 299    pkgOrderList OList(&Cache);
 300
 301    if (DepAdd(OList,Pkg) == false)
 302       return false;
 303
 304    static std::string const conf = _config->Find("PackageManager::Configure","all");
 305    static bool const ConfigurePkgs = (conf == "all" || conf == "smart");
 306
 307    if (ConfigurePkgs == true)
 308       if (OList.OrderConfigure() == false)
 309          return false;
 310
 311    // Perform the configuring
 312    for (pkgOrderList::iterator I = OList.begin(); I != OList.end(); I++)
 313    {
 314       PkgIterator Pkg(Cache,*I);
 315
 316       if (ConfigurePkgs == true && Configure(Pkg) == false)
 317          return false;
 318
 319       List->Flag(Pkg,pkgOrderList::Configured,pkgOrderList::States);
 320    }
 321
 322    // Sanity Check
 323    if (List->IsFlag(Pkg,pkgOrderList::Configured) == false)
 324       return _error->Error("Internal error, could not immediate configure %s",Pkg.Name());
 325
 326    return true;
 327 }
 328                                                                         /*}}}*/
 329 // PM::DepAdd - Add all dependents to the oder list                     /*{{{*/
 330 // ---------------------------------------------------------------------
 331 /* This recursively adds all dependents to the order list */
 332 bool pkgPackageManager::DepAdd(pkgOrderList &OList,PkgIterator Pkg,int Depth)
 333 {
 334    if (OList.IsFlag(Pkg,pkgOrderList::Added) == true)
 335       return true;
 336    if (List->IsFlag(Pkg,pkgOrderList::Configured) == true)
 337       return true;
 338    if (List->IsFlag(Pkg,pkgOrderList::UnPacked) == false)
 339       return false;
 340
 341    // Put the package on the list
 342    OList.push_back(Pkg);
 343    OList.Flag(Pkg,pkgOrderList::Added);
 344    Depth++;
 345
 346    // Check the dependencies to see if they are all satisfied.
 347    bool Bad = false;
 348    for (DepIterator D = Cache[Pkg].InstVerIter(Cache).DependsList(); D.end() == false;)
 349    {
 350       if (D->Type != pkgCache::Dep::Depends && D->Type != pkgCache::Dep::PreDepends)
 351       {
 352          D++;
 353          continue;
 354       }
 355
 356       // Grok or groups
 357       Bad = true;
 358       for (bool LastOR = true; D.end() == false && LastOR == true; D++)
 359       {
 360          LastOR = (D->CompareOp & pkgCache::Dep::Or) == pkgCache::Dep::Or;
 361
 362          if (Bad == false)
 363             continue;
 364
 365          SPtrArray<Version *> VList = D.AllTargets();
 366          for (Version **I = VList; *I != 0 && Bad == true; I++)
 367          {
 368             VerIterator Ver(Cache,*I);
 369             PkgIterator Pkg = Ver.ParentPkg();
 370
 371             // See if the current version is ok
 372             if (Pkg.CurrentVer() == Ver && List->IsNow(Pkg) == true &&
 373                 Pkg.State() == PkgIterator::NeedsNothing)
 374             {
 375                Bad = false;
 376                continue;
 377             }
 378
 379             // Not the install version
 380             if (Cache[Pkg].InstallVer != *I ||
 381                 (Cache[Pkg].Keep() == true && Pkg.State() == PkgIterator::NeedsNothing))
 382                continue;
 383
 384             if (List->IsFlag(Pkg,pkgOrderList::UnPacked) == true)
 385                Bad = !DepAdd(OList,Pkg,Depth);
 386             if (List->IsFlag(Pkg,pkgOrderList::Configured) == true)
 387                Bad = false;
 388          }
 389       }
 390
 391       if (Bad == true)
 392       {
 393          OList.Flag(Pkg,0,pkgOrderList::Added);
 394          OList.pop_back();
 395          Depth--;
 396          return false;
 397       }
 398    }
 399
 400    Depth--;
 401    return true;
 402 }
 403                                                                         /*}}}*/
 404 // PM::EarlyRemove - Perform removal of packages before their time      /*{{{*/
 405 // ---------------------------------------------------------------------
 406 /* This is called to deal with conflicts arising from unpacking */
 407 bool pkgPackageManager::EarlyRemove(PkgIterator Pkg)
 408 {
 409    if (List->IsNow(Pkg) == false)
 410       return true;
 411
 412    // Already removed it
 413    if (List->IsFlag(Pkg,pkgOrderList::Removed) == true)
 414       return true;
 415
 416    // Woops, it will not be re-installed!
 417    if (List->IsFlag(Pkg,pkgOrderList::InList) == false)
 418       return false;
 419
 420    // Essential packages get special treatment
 421    bool IsEssential = false;
 422    if ((Pkg->Flags & pkgCache::Flag::Essential) != 0)
 423       IsEssential = true;
 424
 425    /* Check for packages that are the dependents of essential packages and
 426       promote them too */
 427    if (Pkg->CurrentVer != 0)
 428    {
 429       for (DepIterator D = Pkg.RevDependsList(); D.end() == false &&
 430            IsEssential == false; D++)
 431          if (D->Type == pkgCache::Dep::Depends || D->Type == pkgCache::Dep::PreDepends)
 432             if ((D.ParentPkg()->Flags & pkgCache::Flag::Essential) != 0)
 433                IsEssential = true;
 434    }
 435
 436    if (IsEssential == true)
 437    {
 438       if (_config->FindB("APT::Force-LoopBreak",false) == false)
 439          return _error->Error(_("This installation run will require temporarily "
 440                                 "removing the essential package %s due to a "
 441                                 "Conflicts/Pre-Depends loop. This is often bad, "
 442                                 "but if you really want to do it, activate the "
 443                                 "APT::Force-LoopBreak option."),Pkg.Name());
 444    }
 445
 446    bool Res = SmartRemove(Pkg);
 447    if (Cache[Pkg].Delete() == false)
 448       List->Flag(Pkg,pkgOrderList::Removed,pkgOrderList::States);
 449
 450    return Res;
 451 }
 452                                                                         /*}}}*/
 453 // PM::SmartRemove - Removal Helper                                     /*{{{*/
 454 // ---------------------------------------------------------------------
 455 /* */
 456 bool pkgPackageManager::SmartRemove(PkgIterator Pkg)
 457 {
 458    if (List->IsNow(Pkg) == false)
 459       return true;
 460
 461    List->Flag(Pkg,pkgOrderList::Configured,pkgOrderList::States);
 462    return Remove(Pkg,(Cache[Pkg].iFlags & pkgDepCache::Purge) == pkgDepCache::Purge);
 463 }
 464                                                                         /*}}}*/
 465 // PM::SmartUnPack - Install helper                                     /*{{{*/
 466 // ---------------------------------------------------------------------
 467 /* This performs the task of handling pre-depends. */
 468 bool pkgPackageManager::SmartUnPack(PkgIterator Pkg)
 469 {
 470    // Check if it is already unpacked
 471    if (Pkg.State() == pkgCache::PkgIterator::NeedsConfigure &&
 472        Cache[Pkg].Keep() == true)
 473    {
 474       List->Flag(Pkg,pkgOrderList::UnPacked,pkgOrderList::States);
 475       if (List->IsFlag(Pkg,pkgOrderList::Immediate) == true)
 476          if (SmartConfigure(Pkg) == false)
 477             return _error->Error("Internal Error, Could not perform immediate configuration (1) on %s",Pkg.Name());
 478       return true;
 479    }
 480
 481    /* See if this packages install version has any predependencies
 482       that are not met by 'now' packages. */
 483    for (DepIterator D = Cache[Pkg].InstVerIter(Cache).DependsList();
 484         D.end() == false; )
 485    {
 486       // Compute a single dependency element (glob or)
 487       pkgCache::DepIterator Start;
 488       pkgCache::DepIterator End;
 489       D.GlobOr(Start,End);
 490
 491       while (End->Type == pkgCache::Dep::PreDepends)
 492       {
 493          if (Debug == true)
 494             clog << "PreDepends order for " << Pkg.Name() << std::endl;
 495
 496          // Look for possible ok targets.
 497          SPtrArray<Version *> VList = Start.AllTargets();
 498          bool Bad = true;
 499          for (Version **I = VList; *I != 0 && Bad == true; I++)
 500          {
 501             VerIterator Ver(Cache,*I);
 502             PkgIterator Pkg = Ver.ParentPkg();
 503
 504             // See if the current version is ok
 505             if (Pkg.CurrentVer() == Ver && List->IsNow(Pkg) == true &&
 506                 Pkg.State() == PkgIterator::NeedsNothing)
 507             {
 508                Bad = false;
 509                if (Debug == true)
 510                   clog << "Found ok package " << Pkg.Name() << endl;
 511                continue;
 512             }
 513          }
 514
 515          // Look for something that could be configured.
 516          for (Version **I = VList; *I != 0 && Bad == true; I++)
 517          {
 518             VerIterator Ver(Cache,*I);
 519             PkgIterator Pkg = Ver.ParentPkg();
 520
 521             // Not the install version
 522             if (Cache[Pkg].InstallVer != *I ||
 523                 (Cache[Pkg].Keep() == true && Pkg.State() == PkgIterator::NeedsNothing))
 524                continue;
 525
 526             if (Debug == true)
 527                clog << "Trying to SmartConfigure " << Pkg.Name() << endl;
 528             Bad = !SmartConfigure(Pkg);
 529          }
 530
 531          /* If this or element did not match then continue on to the
 532             next or element until a matching element is found */
 533          if (Bad == true)
 534          {
 535             // This triggers if someone make a pre-depends/depend loop.
 536             if (Start == End)
 537                return _error->Error("Couldn't configure pre-depend %s for %s, "
 538                                     "probably a dependency cycle.",
 539                                     End.TargetPkg().Name(),Pkg.Name());
 540             Start++;
 541          }
 542          else
 543             break;
 544       }
 545
 546       if (End->Type == pkgCache::Dep::Conflicts ||
 547           End->Type == pkgCache::Dep::Obsoletes)
 548       {
 549          /* Look for conflicts. Two packages that are both in the install
 550             state cannot conflict so we don't check.. */
 551          SPtrArray<Version *> VList = End.AllTargets();
 552          for (Version **I = VList; *I != 0; I++)
 553          {
 554             VerIterator Ver(Cache,*I);
 555             PkgIterator Pkg = Ver.ParentPkg();
 556
 557             // See if the current version is conflicting
 558             if (Pkg.CurrentVer() == Ver && List->IsNow(Pkg) == true)
 559             {
 560                if (EarlyRemove(Pkg) == false)
 561                   return _error->Error("Internal Error, Could not early remove %s",Pkg.Name());
 562             }
 563          }
 564       }
 565    }
 566
 567    // Check for reverse conflicts.
 568    if (CheckRConflicts(Pkg,Pkg.RevDependsList(),
 569                    Cache[Pkg].InstVerIter(Cache).VerStr()) == false)
 570       return false;
 571
 572    for (PrvIterator P = Cache[Pkg].InstVerIter(Cache).ProvidesList();
 573         P.end() == false; P++)
 574       CheckRConflicts(Pkg,P.ParentPkg().RevDependsList(),P.ProvideVersion());
 575
 576    if (Install(Pkg,FileNames[Pkg->ID]) == false)
 577       return false;
 578
 579    List->Flag(Pkg,pkgOrderList::UnPacked,pkgOrderList::States);
 580
 581    // Perform immedate configuration of the package.
 582    if (List->IsFlag(Pkg,pkgOrderList::Immediate) == true)
 583       if (SmartConfigure(Pkg) == false)
 584          return _error->Error("Internal Error, Could not perform immediate configuration (2) on %s",Pkg.Name());
 585
 586    return true;
 587 }
 588                                                                         /*}}}*/
 589 // PM::OrderInstall - Installation ordering routine                     /*{{{*/
 590 // ---------------------------------------------------------------------
 591 /* */
 592 pkgPackageManager::OrderResult pkgPackageManager::OrderInstall()
 593 {
 594    if (CreateOrderList() == false)
 595       return Failed;
 596
 597    Reset();
 598
 599    if (Debug == true)
 600       clog << "Beginning to order" << endl;
 601
 602    bool const ordering =
 603         _config->FindB("PackageManager::UnpackAll",true) ?
 604                 List->OrderUnpack(FileNames) : List->OrderCritical();
 605    if (ordering == false)
 606    {
 607       _error->Error("Internal ordering error");
 608       return Failed;
 609    }
 610
 611    if (Debug == true)
 612       clog << "Done ordering" << endl;
 613
 614    bool DoneSomething = false;
 615    for (pkgOrderList::iterator I = List->begin(); I != List->end(); I++)
 616    {
 617       PkgIterator Pkg(Cache,*I);
 618
 619       if (List->IsNow(Pkg) == false)
 620       {
 621          if (Debug == true)
 622             clog << "Skipping already done " << Pkg.Name() << endl;
 623          continue;
 624       }
 625
 626       if (List->IsMissing(Pkg) == true)
 627       {
 628          if (Debug == true)
 629             clog << "Sequence completed at " << Pkg.Name() << endl;
 630          if (DoneSomething == false)
 631          {
 632             _error->Error("Internal Error, ordering was unable to handle the media swap");
 633             return Failed;
 634          }
 635          return Incomplete;
 636       }
 637
 638       // Sanity check
 639       if (Cache[Pkg].Keep() == true &&
 640           Pkg.State() == pkgCache::PkgIterator::NeedsNothing &&
 641           (Cache[Pkg].iFlags & pkgDepCache::ReInstall) != pkgDepCache::ReInstall)
 642       {
 643          _error->Error("Internal Error, trying to manipulate a kept package (%s)",Pkg.Name());
 644          return Failed;
 645       }
 646
 647       // Perform a delete or an install
 648       if (Cache[Pkg].Delete() == true)
 649       {
 650          if (SmartRemove(Pkg) == false)
 651             return Failed;
 652       }
 653       else
 654          if (SmartUnPack(Pkg) == false)
 655             return Failed;
 656       DoneSomething = true;
 657    }
 658
 659    // Final run through the configure phase
 660    if (ConfigureAll() == false)
 661       return Failed;
 662
 663    // Sanity check
 664    for (pkgOrderList::iterator I = List->begin(); I != List->end(); I++)
 665    {
 666       if (List->IsFlag(*I,pkgOrderList::Configured) == false)
 667       {
 668          _error->Error("Internal error, packages left unconfigured. %s",
 669                        PkgIterator(Cache,*I).Name());
 670          return Failed;
 671       }
 672    }
 673
 674    return Completed;
 675 }
 676                                                                         /*}}}*/
 677 // PM::DoInstallPostFork - Does install part that happens after the fork /*{{{*/
 678 // ---------------------------------------------------------------------
 679 pkgPackageManager::OrderResult
 680 pkgPackageManager::DoInstallPostFork(int statusFd)
 681 {
 682       if(statusFd > 0)
 683          // FIXME: use SetCloseExec here once it taught about throwing
 684          //        exceptions instead of doing _exit(100) on failure
 685          fcntl(statusFd,F_SETFD,FD_CLOEXEC);
 686       bool goResult = Go(statusFd);
 687       if(goResult == false)
 688          return Failed;
 689
 690       return Res;
 691 };
 692
 693 // PM::DoInstall - Does the installation                                /*{{{*/
 694 // ---------------------------------------------------------------------
 695 /* This uses the filenames in FileNames and the information in the
 696    DepCache to perform the installation of packages.*/
 697 pkgPackageManager::OrderResult pkgPackageManager::DoInstall(int statusFd)
 698 {
 699    if(DoInstallPreFork() == Failed)
 700       return Failed;
 701
 702    return DoInstallPostFork(statusFd);
 703 }
 704                                                                         /*}}}*/