Fix LED configuration for PS2AVRGB boards (#7989)
authorfauxpark <fauxpark@gmail.com>
Fri, 24 Jan 2020 03:24:10 +0000 (14:24 +1100)
committerJames Young <18669334+noroadsleft@users.noreply.github.com>
Fri, 24 Jan 2020 03:24:10 +0000 (19:24 -0800)
* Fix LED configuration for PS2AVRGB boards

* Undo backlight on state changes

38 files changed:
keyboards/ares/ares.c
keyboards/ares/config.h
keyboards/bfake/bfake.c
keyboards/bfake/config.h
keyboards/db/db63/config.h
keyboards/donutcables/budget96/budget96.c
keyboards/donutcables/budget96/config.h
keyboards/eve/meteor/meteor.c
keyboards/exclusive/e6v2/le_bmc/le_bmc.c
keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c
keyboards/exent/config.h
keyboards/exent/exent.c
keyboards/facew/config.h
keyboards/facew/facew.c
keyboards/ft/mars80/config.h
keyboards/ft/mars80/mars80.c
keyboards/gray_studio/hb85/config.h
keyboards/gray_studio/hb85/hb85.c
keyboards/j80/j80.c
keyboards/jc65/v32a/v32a.c
keyboards/kbdfans/kbdpad/mk1/mk1.c
keyboards/mehkee96/mehkee96.c
keyboards/panc60/panc60.c
keyboards/pearl/pearl.c
keyboards/percent/canoe/canoe.c
keyboards/percent/skog/skog.c
keyboards/percent/skog_lite/skog_lite.c
keyboards/singa/singa.c
keyboards/tgr/alice/alice.c
keyboards/tgr/jane/jane.c
keyboards/unikorn/unikorn.c
keyboards/winkeyless/bface/bface.c
keyboards/winkeyless/bmini/bmini.c
keyboards/winkeyless/bminiex/bminiex.c
keyboards/ymd75/ymd75.c
keyboards/ymd96/ymd96.c
keyboards/ymdk/bface/bface.c
keyboards/ymdk_np21/ymdk_np21.c

index e6379cb..95d4b87 100644 (file)
@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index c50587d..e298dfc 100644 (file)
@@ -39,6 +39,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1
index eb328ba..6d0c927 100644 (file)
@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index 7c814cc..ef7a866 100644 (file)
@@ -39,6 +39,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1
index 488409e..3183201 100644 (file)
@@ -41,4 +41,3 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
-
index 7317e24..5f3436d 100644 (file)
@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index dddc807..0e05bb7 100644 (file)
@@ -39,4 +39,5 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
index ac1ca5d..1d080b3 100644 (file)
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index b09e588..df79cc5 100644 (file)
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index a0a6c57..ea74d87 100644 (file)
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index 4921746..48aee22 100644 (file)
@@ -41,6 +41,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1
index c6870f2..a935e9e 100644 (file)
@@ -25,16 +25,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index 0dc35e6..be44254 100644 (file)
@@ -39,4 +39,5 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
index fc17646..2f091ae 100644 (file)
@@ -25,13 +25,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index 38c3e85..8c1ebe4 100644 (file)
@@ -40,6 +40,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1
index ca19503..2c628a6 100644 (file)
@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index dff360e..f3fb20e 100644 (file)
@@ -33,3 +33,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define RGBLED_NUM 5
 #define RGBLIGHT_ANIMATIONS
+
+#define BACKLIGHT_PIN D4
+#define BACKLIGHT_LEVELS 3
index 57f5e60..4b3ff64 100644 (file)
@@ -27,16 +27,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index 4ac0200..bed30cd 100644 (file)
 
 #include "j80.h"
 
+void keyboard_pre_init_kb(void) {
+    led_init_ports();
+    keyboard_pre_init_user();
+}
+
+void led_init_ports(void) {
+    setPinOutput(D0);
+    setPinOutput(D1);
+    setPinOutput(D6);
+}
+
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, led_state.caps_lock);
         writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
         writePin(D6, led_state.scroll_lock);
     }
     return true;
index 627661a..f195e8f 100644 (file)
@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index f5fe477..540ba35 100644 (file)
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D0);
-    writePinHigh(D0);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
     }
     return true;
 }
index 2da25b6..ae83a1b 100644 (file)
@@ -25,14 +25,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index a200b25..d7ff529 100644 (file)
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index cebbc9f..b08ee6f 100644 (file)
@@ -26,16 +26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index d3c66db..dd31640 100644 (file)
@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index 2418339..152fc56 100644 (file)
@@ -27,14 +27,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index e611885..95d3982 100644 (file)
@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index 7b60e3c..360b214 100644 (file)
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index 9fb4957..a4a5c78 100644 (file)
@@ -26,16 +26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index 24183a0..fabdc0e 100644 (file)
@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index 26a5092..c2c85eb 100644 (file)
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index 49e8bbc..7d27096 100644 (file)
@@ -25,16 +25,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index fe3b74b..6529d44 100644 (file)
@@ -26,16 +26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index 365aeee..676f88e 100644 (file)
@@ -26,16 +26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }
index 1c5c380..0870a6c 100644 (file)
@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index c81435e..5841dec 100644 (file)
@@ -26,14 +26,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index e281040..b35b333 100644 (file)
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }
index b7c2001..63812c9 100644 (file)
@@ -25,7 +25,6 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D0);
-    writePinHigh(D0);
 }
 
 bool led_update_kb(led_t led_state) {