gnu: ghostscript: Incorporate grafted changes.
authorMarius Bakke <mbakke@fastmail.com>
Fri, 29 Nov 2019 21:16:56 +0000 (22:16 +0100)
committerMarius Bakke <mbakke@fastmail.com>
Thu, 5 Dec 2019 16:58:59 +0000 (17:58 +0100)
* gnu/packages/ghostscript.scm (ghostscript)[replacement]: Remove field.
[arguments]: Add "--disable-compile-inits" and "--with-fontpath" in #:configure-flags.
[native-inputs]: Add PKG-CONFIG.
[inputs]: Add FONTCONFIG and GS-FONTS.
(ghostscript/fixed): Remove variable.

gnu/packages/ghostscript.scm

index 7839ac5..224a836 100644 (file)
@@ -157,12 +157,6 @@ printing, and psresize, for adjusting page sizes.")
   (package
     (name "ghostscript")
     (version "9.27")
-
-    ;; The problems addressed by GHOSTSCRIPT/FIXED are not security-related,
-    ;; but they have a significant impact on usability, hence this graft.
-    ;; TODO: Ungraft on next update cycle.
-    (replacement ghostscript/fixed)
-
     (source
       (origin
         (method url-fetch)
@@ -205,6 +199,10 @@ printing, and psresize, for adjusting page sizes.")
              (string-append "ZLIBDIR="
                             (assoc-ref %build-inputs "zlib") "/include")
              "--enable-dynamic"
+             "--disable-compile-inits"
+             (string-append "--with-fontpath="
+                            (assoc-ref %build-inputs "gs-fonts")
+                            "/share/fonts/type1/ghostscript")
 
              ,@(if (%current-target-system)
                    '(;; Specify the native compiler, which is used to build 'echogs'
@@ -268,6 +266,7 @@ printing, and psresize, for adjusting page sizes.")
                #t))))))
     (native-inputs
      `(("perl" ,perl)
+       ("pkg-config" ,pkg-config)       ;needed for freetype
        ("python" ,python-wrapper)
        ("tcl" ,tcl)
 
@@ -278,7 +277,9 @@ printing, and psresize, for adjusting page sizes.")
                ("libjpeg/native" ,libjpeg))
              '())))
     (inputs
-     `(("freetype" ,freetype)
+     `(("fontconfig" ,fontconfig)
+       ("freetype" ,freetype)
+       ("gs-fonts" ,gs-fonts)
        ("jbig2dec" ,jbig2dec)
        ("libjpeg" ,libjpeg)
        ("libpaper" ,libpaper)
@@ -294,25 +295,6 @@ output file formats and printers.")
     (home-page "https://www.ghostscript.com/")
     (license license:agpl3+)))
 
-(define ghostscript/fixed
-  ;; This adds the Freetype dependency (among other things), which fixes the
-  ;; rendering issues described in <https://issues.guix.gnu.org/issue/34877>.
-  (package/inherit
-   ghostscript
-   (arguments
-    (substitute-keyword-arguments (package-arguments ghostscript)
-      ((#:configure-flags flags ''())
-       `(append (list "--disable-compile-inits"
-                      (string-append "--with-fontpath="
-                                     (assoc-ref %build-inputs "gs-fonts")
-                                     "/share/fonts/type1/ghostscript"))
-                ,flags))))
-   (native-inputs `(("pkg-config" ,pkg-config)    ;needed for freetype
-                    ,@(package-native-inputs ghostscript)))
-   (inputs `(("gs-fonts" ,gs-fonts)
-             ("fontconfig" ,fontconfig)
-             ,@(package-inputs ghostscript)))))
-
 (define-public ghostscript/x
   (package/inherit ghostscript
     (name (string-append (package-name ghostscript) "-with-x"))