-#include "PID_Autotuner.h"
-
-#include "Kernel.h"
-
-PID_Autotuner::PID_Autotuner()
-{
- t = NULL;
- s = NULL;
-}
-
-void PID_Autotuner::on_module_loaded()
-{
- tick = false;
- this->kernel->slow_ticker->attach(20, this, &PID_Autotuner::on_tick );
- register_for_event(ON_IDLE);
- register_for_event(ON_GCODE_RECEIVED);
-}
-
-void PID_Autotuner::begin(TemperatureControl *temp, double target, StreamOutput *stream)
-{
- if (t)
- t->heater_pin.set(0);
-
- s = stream;
- t = temp;
-
- t->target_temperature = 0.0;
-
- target_temperature = target;
-
- for (cycle = 0; cycle < 8; cycle++)
- {
- cycles[cycle].ticks_high = 0;
- cycles[cycle].ticks_low = 0;
- cycles[cycle].t_max = 0.0;
- cycles[cycle].t_min = 1000.0;
- }
- cycle = 0;
-
- s->printf("%s: Starting PID Autotune, M304 aborts\n", t->designator.c_str());
-
- bias = d = t->heater_pin.max_pwm() >> 1;
-
- output = true;
- last_output = true;
-}
-
-void PID_Autotuner::abort()
-{
- if (!t)
- return;
-
- t->target_temperature = 0;
- t->heater_pin.set(0);
- t = NULL;
-
- if (s)
- s->printf("PID Autotune Aborted\n");
- s = NULL;
-}
-
-void PID_Autotuner::on_gcode_received(void* argument)
-{
- Gcode* gcode = static_cast<Gcode*>(argument);
-
- if ((gcode->has_m) && (gcode->m == 304))
- abort();
-}
-
-uint32_t PID_Autotuner::on_tick(uint32_t dummy)
-{
- if (t)
- tick = true;
- return 0;
-}
-
-void PID_Autotuner::on_idle(void*)
-{
- if (!tick)
- return;
-
- tick = false;
-
- if (cycle >= PID_AUTOTUNER_CYCLES)
- return;
- if (t == NULL)
- return;
-
- if (t->last_reading > (target_temperature + 0.25))
- output = false;
- else if (t->last_reading < (target_temperature - 0.25))
- output = true;
-
- if (last_output == false && output)
- {
- s->printf("Cycle %d:\n\tMax: %5.1f Min: %5.1f high time: %3.1fs low time: %3.1fs\n", cycle, cycles[cycle].t_max, cycles[cycle].t_min, cycles[cycle].ticks_high / 20.0, cycles[cycle].ticks_low / 20.0);
-
- // this code taken from http://github.com/ErikZalm/Marlin/blob/Marlin_v1/Marlin/temperature.cpp
- bias += (d * (cycles[cycle].ticks_high - cycles[cycle].ticks_low) * (1000.0 / 20.0)) / ((cycles[cycle].ticks_high + cycles[cycle].ticks_low) * (1000.0 / 20.0));
- bias = confine(bias, 20, t->heater_pin.max_pwm() - 20);
- if (bias > (t->heater_pin.max_pwm() / 2))
- d = t->heater_pin.max_pwm() - 1 - bias;
- else
- d = bias;
- // end code from Marlin firmware
-
- cycle++;
- if (cycle == PID_AUTOTUNER_CYCLES)
- {
- t->heater_pin.set(0);
- t->set_desired_temperature(0.0);
- // TODO: finish
- double tmax_avg = 0.0,
- tmin_avg = 0.0,
- t_high_avg = 0.0,
- t_low_avg = 0.0;
- for (cycle = PID_AUTOTUNER_CYCLES - 3; cycle < PID_AUTOTUNER_CYCLES; cycle++)
- {
- tmax_avg += cycles[cycle].t_max;
- tmin_avg += cycles[cycle].t_min;
- t_high_avg += cycles[cycle].ticks_high;
- t_low_avg += cycles[cycle].ticks_low;
- }
- tmax_avg /= (PID_AUTOTUNER_CYCLES - 1.0);
- tmin_avg /= (PID_AUTOTUNER_CYCLES - 1.0);
- t_high_avg /= (PID_AUTOTUNER_CYCLES - 1.0);
- t_low_avg /= (PID_AUTOTUNER_CYCLES - 1.0);
-
- s->printf("Averages over last %d cycles: Max: %5.1fc Min: %5.1fc high samples: %3.0f low samples: %3.0f\n", 3, tmax_avg, tmin_avg, t_high_avg, t_low_avg);
-
- // this code taken from http://github.com/ErikZalm/Marlin/blob/Marlin_v1/Marlin/temperature.cpp
- double ku = (4.0 * d) / (3.141592653589 * (tmax_avg - tmin_avg) / 2.0);
- double tu = (t_low_avg + t_high_avg) * (1000.0 / 20.0) / 1000.0;
-
- s->printf("\tku: %g\n\ttu: %g\n", ku, tu);
-
- double kp = 0.6 * ku;
- double ki = 2 * kp / tu / 20.0;
- double kd = kp * tu / 8.0;
-
- s->printf("\tTrying:\n\tKp: %5.1f\n\tKi: %5.3f\n\tKd: %5.0f\n", kp, ki, kd);
- // end code from Marlin Firmware
-
- t->p_factor = kp;
- t->i_factor = ki;
- t->d_factor = kd;
-
- s->printf("PID Autotune Complete! The settings above have been loaded into memory, but not written to your config file.\n");
-
- t = NULL;
- s = NULL;
-
- return;
- }
- s->printf("Cycle %d:\n\tbias: %4d d: %4d\n", cycle, bias, d);
- }
-
- int ticks;
-
- if (output)
- {
- ticks = ++cycles[cycle].ticks_high;
- t->heater_pin.pwm((t->o = ((bias + d) >> 1)));
- }
- else
- {
- ticks = ++cycles[cycle].ticks_low;
- t->heater_pin.set((t->o = 0));
- }
-
- if ((ticks % 16) == 0)
- {
- s->printf("%s: %5.1f/%5.1f @%d %d %d/8\n", t->designator.c_str(), t->last_reading, target_temperature, t->o, (output?1:0), cycle);
- }
-
- if (t->last_reading > cycles[cycle].t_max)
- cycles[cycle].t_max = t->last_reading;
-
- if (t->last_reading < cycles[cycle].t_min)
- cycles[cycle].t_min = t->last_reading;
-
- last_output = output;
-}
+#include "PID_Autotuner.h"
+#include "Kernel.h"
+#include "SlowTicker.h"
+#include "Gcode.h"
+#include "TemperatureControl.h"
+#include "libs/StreamOutput.h"
+#include "TemperatureControlPublicAccess.h"
+#include "PublicDataRequest.h"
+#include "PublicData.h"
+
+#include <cmath> // std::abs
+
+//#define DEBUG_PRINTF s->printf
+#define DEBUG_PRINTF(...)
+
+PID_Autotuner::PID_Autotuner()
+{
+ temp_control = NULL;
+ s = NULL;
+ lastInputs = NULL;
+ peaks = NULL;
+ tick = false;
+ tickCnt = 0;
+}
+
+void PID_Autotuner::on_module_loaded()
+{
+ tick = false;
+ THEKERNEL->slow_ticker->attach(20, this, &PID_Autotuner::on_tick );
+ register_for_event(ON_IDLE);
+ register_for_event(ON_GCODE_RECEIVED);
+}
+
+void PID_Autotuner::begin(float target, StreamOutput *stream, int ncycles)
+{
+ noiseBand = 0.5;
+ oStep = temp_control->heater_pin.max_pwm(); // use max pwm to cycle temp
+ nLookBack = 5 * 20; // 5 seconds of lookback
+ lookBackCnt = 0;
+ tickCnt = 0;
+
+ if (lastInputs != NULL) delete[] lastInputs;
+ lastInputs = new float[nLookBack + 1];
+
+ s = stream;
+
+ temp_control->heater_pin.set(0);
+ temp_control->target_temperature = 0.0;
+
+ target_temperature = target;
+ requested_cycles = ncycles;
+
+ if (peaks != NULL) delete[] peaks;
+ peaks = new float[ncycles];
+
+ for (int i = 0; i < ncycles; i++) {
+ peaks[i] = 0.0;
+ }
+
+ peakType = 0;
+ peakCount = 0;
+ justchanged = false;
+
+ float refVal = temp_control->get_temperature();
+ absMax = refVal;
+ absMin = refVal;
+ output = oStep;
+ temp_control->heater_pin.pwm(oStep); // turn on to start heating
+
+ s->printf("%s: Starting PID Autotune, %d max cycles, M304 aborts\n", temp_control->designator.c_str(), ncycles);
+}
+
+void PID_Autotuner::abort()
+{
+ if (temp_control == NULL)
+ return;
+
+ temp_control->target_temperature = 0;
+ temp_control->heater_pin.set(0);
+ temp_control = NULL;
+
+ if (s)
+ s->printf("PID Autotune Aborted\n");
+ s = NULL;
+
+ if (peaks != NULL)
+ delete[] peaks;
+ peaks = NULL;
+ if (lastInputs != NULL)
+ delete[] lastInputs;
+ lastInputs = NULL;
+}
+
+void PID_Autotuner::on_gcode_received(void *argument)
+{
+ Gcode *gcode = static_cast<Gcode *>(argument);
+
+ if(gcode->has_m) {
+ if(gcode->m == 304) {
+ gcode->mark_as_taken();
+ abort();
+
+ } else if (gcode->m == 303 && gcode->has_letter('E')) {
+ gcode->mark_as_taken();
+ int pool_index = gcode->get_value('E');
+
+ // get the temperature control instance with this pool index
+ void *returned_data;
+ bool ok = THEKERNEL->public_data->get_value( temperature_control_checksum, pool_index_checksum, pool_index, &returned_data );
+
+ if (ok) {
+ this->temp_control = static_cast<TemperatureControl *>(returned_data);
+
+ } else {
+ gcode->stream->printf("No temperature control with index %d found\r\n", pool_index);
+ return;
+ }
+
+ float target = 150.0;
+ if (gcode->has_letter('S')) {
+ target = gcode->get_value('S');
+ gcode->stream->printf("Target: %5.1f\n", target);
+ }
+ int ncycles = 8;
+ if (gcode->has_letter('C')) {
+ ncycles = gcode->get_value('C');
+ }
+ gcode->stream->printf("Start PID tune for E%d\n", pool_index);
+ this->begin(target, gcode->stream, ncycles);
+ }
+ }
+}
+
+uint32_t PID_Autotuner::on_tick(uint32_t dummy)
+{
+ if (temp_control != NULL)
+ tick = true;
+
+ tickCnt += 1000 / 20; // millisecond tick count
+ return 0;
+}
+
+/**
+ * this autopid is based on https://github.com/br3ttb/Arduino-PID-AutoTune-Library/blob/master/PID_AutoTune_v0/PID_AutoTune_v0.cpp
+ */
+void PID_Autotuner::on_idle(void *)
+{
+ if (!tick)
+ return;
+
+ tick = false;
+
+ if (temp_control == NULL)
+ return;
+
+ if(peakCount >= requested_cycles) {
+ finishUp();
+ return;
+ }
+
+ float refVal = temp_control->get_temperature();
+
+ if (refVal > absMax) absMax = refVal;
+ if (refVal < absMin) absMin = refVal;
+
+ // oscillate the output base on the input's relation to the setpoint
+ if (refVal > target_temperature + noiseBand) {
+ output = 0;
+ //temp_control->heater_pin.pwm(output);
+ temp_control->heater_pin.set(0);
+ } else if (refVal < target_temperature - noiseBand) {
+ output = oStep;
+ temp_control->heater_pin.pwm(output);
+ }
+
+ bool isMax = true, isMin = true;
+
+ // id peaks
+ for (int i = nLookBack - 1; i >= 0; i--) {
+ float val = lastInputs[i];
+ if (isMax) isMax = refVal > val;
+ if (isMin) isMin = refVal < val;
+ lastInputs[i + 1] = lastInputs[i];
+ }
+
+ lastInputs[0] = refVal;
+
+ if (lookBackCnt < nLookBack) {
+ lookBackCnt++; // count number of times we have filled lastInputs
+ //we don't want to trust the maxes or mins until the inputs array has been filled
+ return;
+ }
+
+ if (isMax) {
+ if (peakType == 0) peakType = 1;
+ if (peakType == -1) {
+ peakType = 1;
+ justchanged = true;
+ peak2 = peak1;
+ }
+ peak1 = tickCnt;
+ peaks[peakCount] = refVal;
+
+ } else if (isMin) {
+ if (peakType == 0) peakType = -1;
+ if (peakType == 1) {
+ peakType = -1;
+ peakCount++;
+ justchanged = true;
+ }
+
+ if (peakCount < requested_cycles) peaks[peakCount] = refVal;
+ }
+
+ // we need to ignore the first cycle warming up from room temp
+
+ if (justchanged && peakCount > 2) {
+ if(peakCount == 3) { // reset min to new min
+ absMin = refVal;
+ }
+ //we've transitioned. check if we can autotune based on the last peaks
+ float avgSeparation = (std::abs(peaks[peakCount - 1] - peaks[peakCount - 2]) + std::abs(peaks[peakCount - 2] - peaks[peakCount - 3])) / 2;
+ s->printf("Cycle %d: max: %g, min: %g, avg separation: %g\n", peakCount, absMax, absMin, avgSeparation);
+ if (peakCount > 3 && avgSeparation < 0.05 * (absMax - absMin)) {
+ DEBUG_PRINTF("Stabilized\n");
+ finishUp();
+ return;
+ }
+ }
+
+ justchanged = false;
+
+ if ((tickCnt % 1000) == 0) {
+ s->printf("%s: %5.1f/%5.1f @%d %d/%d\n", temp_control->designator.c_str(), temp_control->get_temperature(), target_temperature, output, peakCount, requested_cycles);
+ DEBUG_PRINTF("lookBackCnt= %d, peakCount= %d, absmax= %g, absmin= %g, peak1= %lu, peak2= %lu\n", lookBackCnt, peakCount, absMax, absMin, peak1, peak2);
+ }
+}
+
+
+void PID_Autotuner::finishUp()
+{
+ //we can generate tuning parameters!
+ float Ku = 4 * (2 * oStep) / ((absMax - absMin) * 3.14159);
+ float Pu = (float)(peak1 - peak2) / 1000;
+ s->printf("\tKu: %g, Pu: %g\n", Ku, Pu);
+
+ float kp = 0.6 * Ku;
+ float ki = 1.2 * Ku / Pu;
+ float kd = Ku * Pu * 0.075;
+
+ s->printf("\tTrying:\n\tKp: %5.1f\n\tKi: %5.3f\n\tKd: %5.0f\n", kp, ki, kd);
+
+ temp_control->setPIDp(kp);
+ temp_control->setPIDi(ki);
+ temp_control->setPIDd(kd);
+
+ s->printf("PID Autotune Complete! The settings above have been loaded into memory, but not written to your config file.\n");
+
+
+ // and clean up
+ temp_control->target_temperature = 0;
+ temp_control->heater_pin.set(0);
+ temp_control = NULL;
+ s = NULL;
+
+ if (peaks != NULL)
+ delete[] peaks;
+ peaks = NULL;
+
+ if (lastInputs != NULL)
+ delete[] lastInputs;
+ lastInputs = NULL;
+}
HCoop / clinton / Smoothieware.git / blobdiff