made temperature runaway options configurable
[clinton/Smoothieware.git] / src / modules / tools / temperaturecontrol / TemperatureControl.cpp
CommitLineData
df27a6a3 1/*
cd011f58
AW
2 This file is part of Smoothie (http://smoothieware.org/). The motion control part is heavily based on Grbl (https://github.com/simen/grbl).
3 Smoothie is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
4 Smoothie is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
df27a6a3 5 You should have received a copy of the GNU General Public License along with Smoothie. If not, see <http://www.gnu.org/licenses/>.
cd011f58
AW
6*/
7
7b49793d 8// TODO : THIS FILE IS LAME, MUST BE MADE MUCH BETTER
cd011f58 9
ded56b35
AW
10#include "libs/Module.h"
11#include "libs/Kernel.h"
12#include <math.h>
13#include "TemperatureControl.h"
3c308aeb 14#include "TemperatureControlPool.h"
3c132bd0 15#include "libs/Pin.h"
3c4f2dd8 16#include "modules/robot/Conveyor.h"
8293d443 17#include "PublicDataRequest.h"
2fa50ca0 18
38b9f24a
L
19#include "PublicData.h"
20#include "ToolManagerPublicAccess.h"
61134a65
JM
21#include "StreamOutputPool.h"
22#include "Config.h"
23#include "checksumm.h"
24#include "Gcode.h"
61134a65 25#include "SlowTicker.h"
8d54c34c 26#include "ConfigValue.h"
66383b80 27#include "PID_Autotuner.h"
1f8dab1a
JM
28#include "SerialMessage.h"
29#include "utils.h"
ded56b35 30
9d955060 31// Temp sensor implementations:
32#include "Thermistor.h"
4710532a 33#include "max31855.h"
073d88ec 34#include "AD8495.h"
9d955060 35
8f91e4e6
MM
36#include "MRI_Hooks.h"
37
85eabc50
JM
38#define UNDEFINED -1
39
9d955060 40#define sensor_checksum CHECKSUM("sensor")
41
85eabc50
JM
42#define readings_per_second_checksum CHECKSUM("readings_per_second")
43#define max_pwm_checksum CHECKSUM("max_pwm")
44#define pwm_frequency_checksum CHECKSUM("pwm_frequency")
989d0e94
JM
45#define bang_bang_checksum CHECKSUM("bang_bang")
46#define hysteresis_checksum CHECKSUM("hysteresis")
85eabc50 47#define heater_pin_checksum CHECKSUM("heater_pin")
bb02929e 48#define max_temp_checksum CHECKSUM("max_temp")
3a014cbb 49#define min_temp_checksum CHECKSUM("min_temp")
85eabc50
JM
50
51#define get_m_code_checksum CHECKSUM("get_m_code")
52#define set_m_code_checksum CHECKSUM("set_m_code")
53#define set_and_wait_m_code_checksum CHECKSUM("set_and_wait_m_code")
54
55#define designator_checksum CHECKSUM("designator")
56
57#define p_factor_checksum CHECKSUM("p_factor")
58#define i_factor_checksum CHECKSUM("i_factor")
59#define d_factor_checksum CHECKSUM("d_factor")
60
61#define i_max_checksum CHECKSUM("i_max")
08f89868 62#define windup_checksum CHECKSUM("windup")
85eabc50
JM
63
64#define preset1_checksum CHECKSUM("preset1")
65#define preset2_checksum CHECKSUM("preset2")
66
1cd1bf1a
AW
67#define runaway_range_checksum CHECKSUM("runaway_range")
68#define runaway_timeout_checksum CHECKSUM("runaway_timeout")
69#define runaway_heating_timeout_checksum CHECKSUM("runaway_heating_timeout")
70
8e8b938e 71TemperatureControl::TemperatureControl(uint16_t name, int index)
d8baddd9 72{
8e8b938e
JM
73 name_checksum= name;
74 pool_index= index;
75 waiting= false;
01004e36 76 temp_violated= false;
8e8b938e 77 sensor= nullptr;
71cc73eb 78 readonly= false;
d8baddd9 79}
ded56b35 80
d8baddd9 81TemperatureControl::~TemperatureControl()
82{
83 delete sensor;
84}
4710532a
JM
85
86void TemperatureControl::on_module_loaded()
87{
907d5e8a 88
81b547a1 89 // We start not desiring any temp
907d5e8a 90 this->target_temperature = UNDEFINED;
f1e38d95 91 this->sensor_settings= false; // set to true if sensor settings have been overriden
ded56b35
AW
92
93 // Settings
71cc73eb 94 this->load_config();
ded56b35 95
ded56b35 96 // Register for events
b0be67b5 97 this->register_for_event(ON_GCODE_RECEIVED);
8293d443 98 this->register_for_event(ON_GET_PUBLIC_DATA);
71cc73eb
JM
99
100 if(!this->readonly) {
71cc73eb
JM
101 this->register_for_event(ON_SECOND_TICK);
102 this->register_for_event(ON_MAIN_LOOP);
103 this->register_for_event(ON_SET_PUBLIC_DATA);
104 this->register_for_event(ON_HALT);
105 }
3d1a4519
JM
106}
107
108void TemperatureControl::on_halt(void *arg)
109{
728477c4
JM
110 if(arg == nullptr) {
111 // turn off heater
112 this->o = 0;
113 this->heater_pin.set(0);
114 this->target_temperature = UNDEFINED;
115 }
ded56b35
AW
116}
117
4710532a
JM
118void TemperatureControl::on_main_loop(void *argument)
119{
01004e36
JM
120 if (this->temp_violated) {
121 this->temp_violated = false;
f0433db4 122 THEKERNEL->streams->printf("Error: MINTEMP or MAXTEMP triggered on %s. Check your temperature sensors!\n", designator.c_str());
01004e36
JM
123 THEKERNEL->streams->printf("HALT asserted - reset or M999 required\n");
124 THEKERNEL->call_event(ON_HALT, nullptr);
a7f12bed 125 }
7e57bc2c 126}
7dd8133c
AW
127
128// Get configuration from the config file
71cc73eb 129void TemperatureControl::load_config()
4710532a 130{
7dd8133c 131
1306ba99 132 // General config
314ab8f7
MM
133 this->set_m_code = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, set_m_code_checksum)->by_default(104)->as_number();
134 this->set_and_wait_m_code = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, set_and_wait_m_code_checksum)->by_default(109)->as_number();
135 this->get_m_code = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, get_m_code_checksum)->by_default(105)->as_number();
136 this->readings_per_second = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, readings_per_second_checksum)->by_default(20)->as_number();
7dee00e4 137
314ab8f7 138 this->designator = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, designator_checksum)->by_default(string("T"))->as_string();
b0be67b5 139
1cd1bf1a
AW
140 // Runaway parameters
141 this->runaway_range = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, runaway_range_checksum)->by_default(0)->as_number();
142 this->runaway_timeout = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, runaway_timeout_checksum)->by_default(0)->as_number();
143 this->runaway_heating_timeout = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, runaway_heating_timeout_checksum)->by_default(0)->as_number();
144
3a014cbb 145 // Max and min temperatures we are not allowed to get over (Safety)
01004e36 146 this->max_temp = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, max_temp_checksum)->by_default(300)->as_number();
3a014cbb 147 this->min_temp = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, min_temp_checksum)->by_default(0)->as_number();
7d4baeee 148
71cc73eb
JM
149 // Heater pin
150 this->heater_pin.from_string( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, heater_pin_checksum)->by_default("nc")->as_string());
151 if(this->heater_pin.connected()){
152 this->readonly= false;
153 this->heater_pin.as_output();
154
155 } else {
156 this->readonly= true;
157 }
158
d8baddd9 159 // For backward compatibility, default to a thermistor sensor.
160 std::string sensor_type = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, sensor_checksum)->by_default("thermistor")->as_string();
161
162 // Instantiate correct sensor (TBD: TempSensor factory?)
163 delete sensor;
164 sensor = nullptr; // In case we fail to create a new sensor.
4710532a 165 if(sensor_type.compare("thermistor") == 0) {
d8baddd9 166 sensor = new Thermistor();
4710532a 167 } else if(sensor_type.compare("max31855") == 0) {
d8baddd9 168 sensor = new Max31855();
073d88ec
E
169 } else if(sensor_type.compare("ad8495") == 0) {
170 sensor = new AD8495();
4710532a 171 } else {
d8baddd9 172 sensor = new TempSensor(); // A dummy implementation
173 }
174 sensor->UpdateConfig(temperature_control_checksum, this->name_checksum);
4710532a 175
71cc73eb
JM
176 this->preset1 = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, preset1_checksum)->by_default(0)->as_number();
177 this->preset2 = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, preset2_checksum)->by_default(0)->as_number();
f4bd4fc3 178
907d5e8a 179
c4f4cf73 180 // sigma-delta output modulation
b35ac71e 181 this->o = 0;
3c132bd0 182
71cc73eb
JM
183 if(!this->readonly) {
184 // used to enable bang bang control of heater
185 this->use_bangbang = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, bang_bang_checksum)->by_default(false)->as_bool();
186 this->hysteresis = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, hysteresis_checksum)->by_default(2)->as_number();
08f89868 187 this->windup = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, windup_checksum)->by_default(false)->as_bool();
71cc73eb
JM
188 this->heater_pin.max_pwm( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, max_pwm_checksum)->by_default(255)->as_number() );
189 this->heater_pin.set(0);
190 set_low_on_debug(heater_pin.port_number, heater_pin.pin);
191 // activate SD-DAC timer
192 THEKERNEL->slow_ticker->attach( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, pwm_frequency_checksum)->by_default(2000)->as_number(), &heater_pin, &Pwm::on_tick);
193 }
8f91e4e6 194
907d5e8a 195
f39da6fe 196 // reading tick
314ab8f7 197 THEKERNEL->slow_ticker->attach( this->readings_per_second, this, &TemperatureControl::thermistor_read_tick );
4710532a 198 this->PIDdt = 1.0 / this->readings_per_second;
f39da6fe 199
907d5e8a 200 // PID
314ab8f7 201 setPIDp( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, p_factor_checksum)->by_default(10 )->as_number() );
1ad23cd3 202 setPIDi( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, i_factor_checksum)->by_default(0.3f)->as_number() );
314ab8f7 203 setPIDd( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, d_factor_checksum)->by_default(200)->as_number() );
71cc73eb
JM
204
205 if(!this->readonly) {
206 // set to the same as max_pwm by default
207 this->i_max = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, i_max_checksum )->by_default(this->heater_pin.max_pwm())->as_number();
208 }
209
10e66797 210 this->iTerm = 0.0;
4710532a 211 this->lastInput = -1.0;
907d5e8a 212 this->last_reading = 0.0;
7dd8133c
AW
213}
214
4710532a
JM
215void TemperatureControl::on_gcode_received(void *argument)
216{
217 Gcode *gcode = static_cast<Gcode *>(argument);
8dfbc976 218 if (gcode->has_m) {
ee4711d1 219
4710532a 220 if( gcode->m == this->get_m_code ) {
93284f6f 221 char buf[32]; // should be big enough for any status
3517edce 222 int n = snprintf(buf, sizeof(buf), "%s:%3.1f /%3.1f @%d ", this->designator.c_str(), this->get_temperature(), ((target_temperature <= 0) ? 0.0 : target_temperature), this->o);
93284f6f 223 gcode->txt_after_ok.append(buf, n);
71cc73eb
JM
224 return;
225 }
8dfbc976 226
76f53dc6 227 if (gcode->m == 305) { // set or get sensor settings
76f53dc6 228 if (gcode->has_letter('S') && (gcode->get_value('S') == this->pool_index)) {
1f8dab1a 229 TempSensor::sensor_options_t args= gcode->get_args();
d22755f7
JM
230 args.erase('S'); // don't include the S
231 if(args.size() > 0) {
76f53dc6 232 // set the new options
d22755f7
JM
233 if(sensor->set_optional(args)) {
234 this->sensor_settings= true;
235 }else{
236 gcode->stream->printf("Unable to properly set sensor settings, make sure you specify all required values\n");
237 }
238 }else{
239 // don't override
240 this->sensor_settings= false;
76f53dc6
JM
241 }
242
243 }else if(!gcode->has_letter('S')) {
d22755f7 244 gcode->stream->printf("%s(S%d): using %s\n", this->designator.c_str(), this->pool_index, this->readonly?"Readonly" : this->use_bangbang?"Bangbang":"PID");
76f53dc6
JM
245 sensor->get_raw();
246 TempSensor::sensor_options_t options;
247 if(sensor->get_optional(options)) {
248 for(auto &i : options) {
249 // foreach optional value
a2e5f877 250 gcode->stream->printf("%s(S%d): %c %1.18f\n", this->designator.c_str(), this->pool_index, i.first, i.second);
76f53dc6
JM
251 }
252 }
253 }
254
255 return;
256 }
257
71cc73eb
JM
258 // readonly sensors don't handle the rest
259 if(this->readonly) return;
260
01004e36
JM
261 if (gcode->m == 143) {
262 if (gcode->has_letter('S') && (gcode->get_value('S') == this->pool_index)) {
263 if(gcode->has_letter('P')) {
264 max_temp= gcode->get_value('P');
265
266 } else {
267 gcode->stream->printf("Nothing set NOTE Usage is M143 S0 P300 where <S> is the hotend index and <P> is the maximum temp to set\n");
268 }
269
270 }else if(gcode->get_num_args() == 0) {
271 gcode->stream->printf("Maximum temperature for %s(%d) is %f°C\n", this->designator.c_str(), this->pool_index, max_temp);
272 }
273
274 } else if (gcode->m == 301) {
4710532a 275 if (gcode->has_letter('S') && (gcode->get_value('S') == this->pool_index)) {
827a49ca 276 if (gcode->has_letter('P'))
201e6dcf 277 setPIDp( gcode->get_value('P') );
827a49ca 278 if (gcode->has_letter('I'))
201e6dcf 279 setPIDi( gcode->get_value('I') );
827a49ca 280 if (gcode->has_letter('D'))
201e6dcf 281 setPIDd( gcode->get_value('D') );
827a49ca 282 if (gcode->has_letter('X'))
f1e38d95
JM
283 this->i_max = gcode->get_value('X');
284 if (gcode->has_letter('Y'))
285 this->heater_pin.max_pwm(gcode->get_value('Y'));
286
287 }else if(!gcode->has_letter('S')) {
288 gcode->stream->printf("%s(S%d): Pf:%g If:%g Df:%g X(I_max):%g max pwm: %d O:%d\n", this->designator.c_str(), this->pool_index, this->p_factor, this->i_factor / this->PIDdt, this->d_factor * this->PIDdt, this->i_max, this->heater_pin.max_pwm(), o);
289 }
290
4710532a 291 } else if (gcode->m == 500 || gcode->m == 503) { // M500 saves some volatile settings to config override file, M503 just prints the settings
f1e38d95
JM
292 gcode->stream->printf(";PID settings:\nM301 S%d P%1.4f I%1.4f D%1.4f X%1.4f Y%d\n", this->pool_index, this->p_factor, this->i_factor / this->PIDdt, this->d_factor * this->PIDdt, this->i_max, this->heater_pin.max_pwm());
293
01004e36
JM
294 gcode->stream->printf(";Max temperature setting:\nM143 S%d P%1.4f\n", this->pool_index, this->max_temp);
295
f1e38d95
JM
296 if(this->sensor_settings) {
297 // get or save any sensor specific optional values
298 TempSensor::sensor_options_t options;
299 if(sensor->get_optional(options) && !options.empty()) {
300 gcode->stream->printf(";Optional temp sensor specific settings:\nM305 S%d", this->pool_index);
301 for(auto &i : options) {
7d678d16 302 gcode->stream->printf(" %c%1.18f", i.first, i.second);
f1e38d95
JM
303 }
304 gcode->stream->printf("\n");
305 }
306 }
33e4cc02 307
8e8b938e 308 } else if( ( gcode->m == this->set_m_code || gcode->m == this->set_and_wait_m_code ) && gcode->has_letter('S')) {
42cb1b30 309 // this only gets handled if it is not controlled by the tool manager or is active in the toolmanager
8e8b938e
JM
310 this->active = true;
311
312 // this is safe as old configs as well as single extruder configs the toolmanager will not be running so will return false
313 // this will also ignore anything that the tool manager is not controlling and return false, otherwise it returns the active tool
314 void *returned_data;
75e6428d 315 bool ok = PublicData::get_value( tool_manager_checksum, is_active_tool_checksum, this->name_checksum, &returned_data );
8e8b938e
JM
316 if (ok) {
317 uint16_t active_tool_name = *static_cast<uint16_t *>(returned_data);
318 this->active = (active_tool_name == this->name_checksum);
319 }
320
321 if(this->active) {
42cb1b30
JM
322 // required so temp change happens in order
323 THEKERNEL->conveyor->wait_for_empty_queue();
2134bcf2 324
42cb1b30 325 float v = gcode->get_value('S');
db453125 326
42cb1b30
JM
327 if (v == 0.0) {
328 this->target_temperature = UNDEFINED;
329 this->heater_pin.set((this->o = 0));
330 } else {
331 this->set_desired_temperature(v);
ed52bf31
JM
332 // wait for temp to be reached, no more gcodes will be fetched until this is complete
333 if( gcode->m == this->set_and_wait_m_code) {
487976f7 334 if(isinf(get_temperature()) && isinf(sensor->get_temperature())) {
f0433db4 335 THEKERNEL->streams->printf("Temperature reading is unreliable on %s HALT asserted - reset or M999 required\n", designator.c_str());
487976f7
JM
336 THEKERNEL->call_event(ON_HALT, nullptr);
337 return;
338 }
339
ed52bf31
JM
340 this->waiting = true; // on_second_tick will announce temps
341 while ( get_temperature() < target_temperature ) {
342 THEKERNEL->call_event(ON_IDLE, this);
798295c1 343 // check if ON_HALT was called (usually by kill button)
aa896868
JM
344 if(THEKERNEL->is_halted() || this->target_temperature == UNDEFINED) {
345 THEKERNEL->streams->printf("Wait on temperature aborted by kill\n");
346 break;
347 }
ed52bf31
JM
348 }
349 this->waiting = false;
42cb1b30 350 }
cf1a7632 351 }
907d5e8a 352 }
df27a6a3 353 }
df27a6a3 354 }
ded56b35
AW
355}
356
4710532a
JM
357void TemperatureControl::on_get_public_data(void *argument)
358{
359 PublicDataRequest *pdr = static_cast<PublicDataRequest *>(argument);
201e6dcf 360
b19aa09d
JM
361 if(!pdr->starts_with(temperature_control_checksum)) return;
362
8e8b938e
JM
363 if(pdr->second_element_is(pool_index_checksum)) {
364 // asking for our instance pointer if we have this pool_index
365 if(pdr->third_element_is(this->pool_index)) {
366 static void *return_data;
367 return_data = this;
368 pdr->set_data_ptr(&return_data);
369 pdr->set_taken();
370 }
8e8b938e 371
56a6c8c1 372 }else if(pdr->second_element_is(poll_controls_checksum)) {
bab4e1bd 373 // polling for all temperature controls
3bfb2639
JM
374 // add our data to the list which is passed in via the data_ptr
375
376 std::vector<struct pad_temperature> *v= static_cast<std::vector<pad_temperature>*>(pdr->get_data_ptr());
bab4e1bd 377
3bfb2639 378 struct pad_temperature t;
bab4e1bd 379 // setup data
3bfb2639
JM
380 t.current_temperature = this->get_temperature();
381 t.target_temperature = (target_temperature <= 0) ? 0 : this->target_temperature;
382 t.pwm = this->o;
383 t.designator= this->designator;
384 t.id= this->name_checksum;
385 v->push_back(t);
386 pdr->set_taken();
b19aa09d 387
56a6c8c1
JM
388 }else if(pdr->second_element_is(current_temperature_checksum)) {
389 // if targeted at us
390 if(pdr->third_element_is(this->name_checksum)) {
564cf1f0 391 // ok this is targeted at us, so set the requ3sted data in the pointer passed into us
56a6c8c1
JM
392 struct pad_temperature *t= static_cast<pad_temperature*>(pdr->get_data_ptr());
393 t->current_temperature = this->get_temperature();
394 t->target_temperature = (target_temperature <= 0) ? 0 : this->target_temperature;
395 t->pwm = this->o;
396 t->designator= this->designator;
397 t->id= this->name_checksum;
398 pdr->set_taken();
56a6c8c1 399 }
b19aa09d 400 }
8e8b938e 401
8293d443 402}
db453125 403
4710532a
JM
404void TemperatureControl::on_set_public_data(void *argument)
405{
406 PublicDataRequest *pdr = static_cast<PublicDataRequest *>(argument);
77047e76 407
991d98cc 408 if(!pdr->starts_with(temperature_control_checksum)) return;
77047e76 409
8e8b938e 410 if(!pdr->second_element_is(this->name_checksum)) return;
77047e76 411
991d98cc 412 // ok this is targeted at us, so set the temp
ed52bf31 413 // NOTE unlike the M code this will set the temp now not when the queue is empty
4710532a 414 float t = *static_cast<float *>(pdr->get_data_ptr());
991d98cc
JM
415 this->set_desired_temperature(t);
416 pdr->set_taken();
77047e76
JM
417}
418
1ad23cd3 419void TemperatureControl::set_desired_temperature(float desired_temperature)
cf1a7632 420{
7d4baeee
AW
421 // Never go over the configured max temperature
422 if( desired_temperature > this->max_temp ){
423 desired_temperature = this->max_temp;
424 }
425
08f89868 426 if (desired_temperature == 1.0F)
cf1a7632 427 desired_temperature = preset1;
08f89868 428 else if (desired_temperature == 2.0F)
cf1a7632
MM
429 desired_temperature = preset2;
430
08f89868 431 float last_target_temperature= target_temperature;
907d5e8a 432 target_temperature = desired_temperature;
3517edce 433 if (desired_temperature <= 0.0F){
08f89868 434 // turning it off
b35ac71e 435 heater_pin.set((this->o = 0));
08f89868 436
3517edce 437 }else if(last_target_temperature <= 0.0F) {
08f89868
JM
438 // if it was off and we are now turning it on we need to initialize
439 this->lastInput= last_reading;
440 // set to whatever the output currently is See http://brettbeauregard.com/blog/2011/04/improving-the-beginner%E2%80%99s-pid-initialization/
441 this->iTerm= this->o;
442 if (this->iTerm > this->i_max) this->iTerm = this->i_max;
443 else if (this->iTerm < 0.0) this->iTerm = 0.0;
444 }
ded56b35
AW
445}
446
4710532a
JM
447float TemperatureControl::get_temperature()
448{
907d5e8a 449 return last_reading;
ded56b35
AW
450}
451
4710532a
JM
452uint32_t TemperatureControl::thermistor_read_tick(uint32_t dummy)
453{
9d955060 454 float temperature = sensor->get_temperature();
3517edce 455 if(!this->readonly && target_temperature > 2) {
01004e36
JM
456 if (isinf(temperature) || temperature < min_temp || temperature > max_temp) {
457 this->temp_violated = true;
907d5e8a 458 target_temperature = UNDEFINED;
4710532a
JM
459 heater_pin.set((this->o = 0));
460 } else {
907d5e8a 461 pid_process(temperature);
ded56b35 462 }
959dc7db 463 }
3517edce 464
907d5e8a 465 last_reading = temperature;
281967e4 466 return 0;
ded56b35
AW
467}
468
10e66797
JM
469/**
470 * Based on https://github.com/br3ttb/Arduino-PID-Library
471 */
1ad23cd3 472void TemperatureControl::pid_process(float temperature)
907d5e8a 473{
989d0e94 474 if(use_bangbang) {
b35ac71e 475 // bang bang is very simple, if temp is < target - hysteresis turn on full else if temp is > target + hysteresis turn heater off
989d0e94 476 // good for relays
4710532a 477 if(temperature > (target_temperature + hysteresis) && this->o > 0) {
989d0e94 478 heater_pin.set(false);
4710532a 479 this->o = 0; // for display purposes only
989d0e94 480
4710532a 481 } else if(temperature < (target_temperature - hysteresis) && this->o <= 0) {
989d0e94
JM
482 if(heater_pin.max_pwm() >= 255) {
483 // turn on full
484 this->heater_pin.set(true);
4710532a
JM
485 this->o = 255; // for display purposes only
486 } else {
989d0e94
JM
487 // only to whatever max pwm is configured
488 this->heater_pin.pwm(heater_pin.max_pwm());
4710532a 489 this->o = heater_pin.max_pwm(); // for display purposes only
989d0e94 490 }
989d0e94
JM
491 }
492 return;
493 }
ded56b35 494
989d0e94
JM
495 // regular PID control
496 float error = target_temperature - temperature;
08f89868 497
0d84905d
PA
498 float new_I = this->iTerm + (error * this->i_factor);
499 if (new_I > this->i_max) new_I = this->i_max;
500 else if (new_I < 0.0) new_I = 0.0;
08f89868 501 if(!this->windup) this->iTerm= new_I;
ded56b35 502
4710532a 503 float d = (temperature - this->lastInput);
ded56b35 504
10e66797
JM
505 // calculate the PID output
506 // TODO does this need to be scaled by max_pwm/256? I think not as p_factor already does that
0d84905d 507 this->o = (this->p_factor * error) + new_I - (this->d_factor * d);
8cdae54c 508
7dee00e4 509 if (this->o >= heater_pin.max_pwm())
7dee00e4 510 this->o = heater_pin.max_pwm();
27aecda6 511 else if (this->o < 0)
907d5e8a 512 this->o = 0;
08f89868 513 else if(this->windup)
0d84905d 514 this->iTerm = new_I; // Only update I term when output is not saturated.
907d5e8a 515
27aecda6 516 this->heater_pin.pwm(this->o);
4710532a 517 this->lastInput = temperature;
907d5e8a 518}
ded56b35 519
4710532a 520void TemperatureControl::on_second_tick(void *argument)
8ccab7cf 521{
3bf54d11
AW
522
523 // If waiting for a temperature to be reach, display it to keep host programs up to date on the progress
8ccab7cf 524 if (waiting)
3517edce 525 THEKERNEL->streams->printf("%s:%3.1f /%3.1f @%d\n", designator.c_str(), get_temperature(), ((target_temperature <= 0) ? 0.0 : target_temperature), o);
3bf54d11
AW
526
527 // Check whether or not there is a temperature runaway issue, if so stop everything and report it
e39c48c1
AW
528 if(THEKERNEL->is_halted()) return;
529
c6c03d35
AW
530 if( this->target_temperature <= 0 ){ // If we are not trying to heat, state is NOT_HEATING
531 this->runaway_state = NOT_HEATING;
1cd1bf1a 532 this->runaway_timer = 0;
3bf54d11
AW
533 }else{
534 switch( this->runaway_state ){
c6c03d35 535 case NOT_HEATING: // If we were previously not trying to heat, but we are now, change to state WAITING_FOR_TEMP_TO_BE_REACHED
3bf54d11 536 if( this->target_temperature > 0 ){
c6c03d35
AW
537 this->runaway_state = WAITING_FOR_TEMP_TO_BE_REACHED;
538 this->runaway_heating_timer = 0;
3bf54d11
AW
539 }
540 break;
c6c03d35 541 case WAITING_FOR_TEMP_TO_BE_REACHED: // In we are in state 1 ( waiting for temperature to be reached ), and the temperature has been reached, change to state TARGET_TEMPERATURE_REACHED
3bf54d11 542 if( this->get_temperature() >= this->target_temperature ){
c6c03d35
AW
543 this->runaway_state = TARGET_TEMPERATURE_REACHED;
544 }
545 this->runaway_heating_timer++;
1cd1bf1a 546 if( this->runaway_heating_timer > this->runaway_heating_timeout && this->runaway_heating_timeout != 0 ){
c6c03d35
AW
547 this->runaway_heating_timer = 0;
548 THEKERNEL->streams->printf("Error : Temperature too long to be reached on %s, HALT asserted, TURN POWER OFF IMMEDIATELY - reset or M999 required\n", designator.c_str());
549 THEKERNEL->call_event(ON_HALT, nullptr);
3bf54d11
AW
550 }
551 break;
c6c03d35 552 case TARGET_TEMPERATURE_REACHED: // If we are in state TARGET_TEMPERATURE_REACHED, check for thermal runaway
3bf54d11 553 // If the temperature is outside the acceptable range
1cd1bf1a 554 if( fabs( this->get_temperature() - this->target_temperature ) > this->runaway_range && this->runaway_range != 0 ){
3bf54d11
AW
555 // Increase the timer, aka « One more second with a problem maybe occuring »
556 this->runaway_timer++;
557
558 // If the timer has a too large value ( we have been too long outside the desired temperature range )
1cd1bf1a 559 if( this->runaway_timer > this->runaway_timeout && this->runaway_timeout != 0 ){
c6c03d35 560 THEKERNEL->streams->printf("Error : Temperature runaway on %s, HALT asserted, TURN POWER OFF IMMEDIATELY - reset or M999 required\n", designator.c_str());
3bf54d11 561 THEKERNEL->call_event(ON_HALT, nullptr);
3bf54d11
AW
562 }
563 }else{
564 // The temperature was inside the acceptable range, reset the timer
565 this->runaway_timer = 0;
566 }
567 break;
568 }
569 }
8ccab7cf 570}
201e6dcf 571
4710532a
JM
572void TemperatureControl::setPIDp(float p)
573{
574 this->p_factor = p;
201e6dcf
JM
575}
576
4710532a
JM
577void TemperatureControl::setPIDi(float i)
578{
579 this->i_factor = i * this->PIDdt;
201e6dcf
JM
580}
581
4710532a
JM
582void TemperatureControl::setPIDd(float d)
583{
584 this->d_factor = d / this->PIDdt;
201e6dcf 585}