(array-fill!): Exercise byte range and type checks.

[bpt/guile.git] / libguile / ChangeLog

2004-08-06  Kevin Ryde  <user42@zip.com.au>

	* unif.c (scm_uniform_vector_ref, scm_array_set_x): For byvect, force
	signed byte range checks by using scm_to_schar and scm_from_schar,
	don't want to depend on signedness of C char.

2004-08-05  Kevin Ryde  <user42@zip.com.au>

	* arbiters.c (scm_try_arbiter): Use scm_i_misc_mutex instead of
	SCM_DEFER_INTS.
	(scm_release_arbiter): Use scm_i_misc_mutex so return value can be
	guaranteed if multiple threads compete to unlock.
	Update docstrings per doc/ref/api-scheduling.texi.

	* filesys.c (scm_copy_file): Use fstat on the input fd rather than
	stat on the filename, to be certain a file rename can't mean we get
	info on one filesystem object but open another.  This fstat usage is
	similar to Emacs copy-file.
	
	* posix.c (scm_setgroups): Enhance docstring, per doc/ref/posix.texi.

	* simpos.c (scm_system_star): Change scm_from_long to scm_from_int on
	SIGINT and SIGQUIT, since those values are ints.

2004-08-03  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* num2integral.i.c, num2float.i.c: Removed.
	* Makefile.am (noinst_HEADERS): Updated.

	* numbers.h. numbers.c (scm_make_ratio): Renamed to
	scm_i_make_ratio and made static, replaced uses with scm_divide.
	(scm_complex_p): New, export as "complex?" to Scheme.
	(scm_number_p): Export as "number?" to Scheme.
	(scm_is_complex, scm_is_number): New.
	(scm_c_make_rectangular, scm_c_make_polar): New.
	(scm_make_rectangular, scm_make_polar): Use above.
	(scm_c_real_part, scm_c_imag_part, scm_c_magnitude, scm_c_angle):
	New.
	(scm_make_complex): Discouraged by moving to discouraged.h and
	discouraged.c.  Replaced all uses with scm_c_make_rectangular.
	
	* discouraged.h, discouraged.c, numbers.c, numbers.h
	(scm_is_rational): New.
	(scm_i_short2big, scm_i_int2big, scm_i_uint2big, scm_i_size2big,
	scm_i_ptrdiff2big, scm_i_long_long2big, scm_i_ulong_long2big):
	Removed prototypes.
	(scm_make_real, scm_num2dbl, scm_float2num, scm_double2num):
	Discouraged by moving to discouraged.h and discouraged.c.
	Replaced all uses with scm_from_double.
	(scm_num2float, scm_num2double): Discouraged by moving prototype
	to discouraged.h and rewriting in terms of scm_to_double.
	Replaced all uses with scm_to_double.
	(scm_to_double): Do not implement in terms of scm_num2dbl, use
	explicit code.
	(scm_from_double): Do not implement in terms of scm_make_real, use
	explicit code.
	
2004-08-02  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* init.c (scm_init_guile_1): Call scm_i_init_discouraged.

	* gen-scmconfig.h.in (SCM_I_GSC_ENABLE_DISCOURAGED): New.
	* gen-scmconfig.c (SCM_ENABLE_DISCOURAGED): Emit based on above.

	* eval.c (SCM_EVALIM, SCM_EVALIM2, SCM_XEVAL, SCM_XEVALCAR):
	Renamed to SCM_I_* in order to avoid collisions with the versions
	defined in deprecated.h.

	* discouraged.h, discouraged.c: New files.

	* deprecated.h (SCM_FALSEP, SCM_NFALSEP, SCM_BOOLP, SCM_EQ_P,
	SCM_NEGATE_BOOL, SCM_BOOL, SCM_BOOT_NOT): Promoted from being
	deprecated to being discouraged by moving to discouraged.h.

	* numbers.h, numbers.c, discouraged.h, discouraged.c
	(scm_short2num, scm_ushort2num, scm_int2num, scm_uint2num,
	scm_long2num, scm_ulong2num, scm_size2num, scm_ptrdiff2num,
	scm_num2short, scm_num2ushort, scm_num2int, scm_num2uint,
	scm_num2long, scm_num2ulong, scm_num2size, scm_num2ptrdiff,
	scm_long_long2num, scm_ulong_long2num, scm_num2long_long,
	scm_num2ulong_long): Discouraged by moving to discouraged.h and
	discouraged.c and reimplementing in terms of scm_from_* and
	scm_to_*.  Changed all uses to the new scm_from_* and scm_to_*
	functions.

	* numbers.h, numbers.c: Removed GUILE_DEBUG code.
	(scm_i_short2big, scm_i_ushort2big, scm_i_int2big, scm_i_uint2big,
	scm_i_size2big, scm_i_ptrdiff2big): Removed.
	(scm_i_long2big, scm_i_ulong2big): New, explicit definitions.  
	* conv-integer.i.c, conv-uinteger.i.c: Use them instead of
	explicit code.

2004-08-02  Kevin Ryde  <user42@zip.com.au>

	* __scm.h (SCM_DEFER_INTS, SCM_ALLOW_INTS): Add comments about past
	and current usage and migration.

2004-07-31  Kevin Ryde  <user42@zip.com.au>

	* error.c (scm_strerror): Use scm_i_misc_mutex around strerror since
	it's not thread safe.
	(scm_syserror): Use scm_strerror rather than SCM_I_STRERROR, to take
	advantage of this.
	* fports.c (scm_open_file): Use scm_strerror likewise.
	* filesys.c (scm_stat, scm_lstat): Ditto.

	* filesys.c (scm_copy_file): Avoid fd leak when destination file
	cannot be opened.

	* symbols.c (scm_gensym): Use scm_i_misc_mutex around gensym_counter
	update, for thread safety.
	(gensym_counter): Move into scm_gensym which is its only user.
	(scm_init_symbols): No need to explicitly initialize gensym_counter.

2004-07-29  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* numbers.h (scm_to_schar, scm_to_uchar, scm_to_char,
	scm_to_short, scm_to_ushort, scm_to_int, scm_to_uint, scm_to_long,
	scm_to_ulong, scm_to_long_long, scm_to_ulong_long, scm_to_intmax,
	scm_to_uintmax, scm_to_size_t, scm_to_ssize_t scm_from_schar,
	scm_from_uchar, scm_from_char, scm_from_short, scm_from_ushort,
	scm_from_int, scm_from_uint, scm_from_long, scm_from_ulong,
	scm_from_long_long, scm_from_ulong_long, scm_from_intmax,
	scm_from_uintmax, scm_from_size_t, scm_from_ssize_t): No longer
	defined in terms of scm_to_signed_integer, etc, but in terms of
	scm_to_int8, etc.

	* gen-scmconfig.c (SCM_SIZEOF_INTMAX, SCM_SIZEOF_SIZE_T): New.

	* gen-scmconfig.h.in: Removed SCM_I_GSC_*_LIMITS macros, they are
	no longer used.

	* __scm.h (SCM_I_UTYPE_MAX, SCM_I_TYPE_MAX, SCM_I_TYPE_MIN,
	SCM_I_SIZE_MAX, SCM_I_SSIZE_MIN, SCM_I_SSIZE_MAX): New.

	* __scm.h, gen-scmconfig.c (SCM_I_LLONG_MAX, SCM_I_LLONG_MIN,
	SCM_I_ULLONG_MAX, SCM_T_INT8_MIN, SCM_T_INT8_MAX, SCM_T_UINT8_MAX,
	SCM_T_INT16_MIN, SCM_T_INT16_MAX, SCM_T_UINT16_MAX,
	SCM_T_INT32_MIN, SCM_T_INT32_MAX, SCM_T_UINT32_MAX,
	SCM_T_INT64_MIN, SCM_T_INT64_MAX, SCM_T_UINT64_MAX,
	SCM_T_INTMAX_MIN, SCM_T_INTMAX_MAX, SCM_T_UINTMAX_MAX): Moved
	definition into __scm.h, using new SCM_I_TYPE_MIN, etc.
	
	* conv-integer.i.c, conv-uinteger.i.c: New files, used to generate
	the functions below.

	* Makefile.am (noinst_HEADERS): Added conv-integer.i.c and
	conv-uinteger.i.c.

	* numbers.c, numbers.h (scm_to_int8, scm_to_uint8, scm_to_int16,
	scm_to_uint16, scm_to_int32, scm_to_uint32, scm_to_int64,
	scm_to_uint64, scm_from_int8, scm_from_uint8, scm_from_int16,
	scm_from_uint16, scm_from_int32, scm_from_uint32, scm_from_int64,
	scm_from_uint64): Turned from macros into proper functions.
	(scm_to_signed_integer, scm_to_unsigned_integer,
	scm_from_signed_integer, scm_from_unsigned_integer): Generate via
	conv-integer.i.c and conv-uinteger.i.c, as well.
	
	* number.h (scm_to_ssize_t, scm_to_size_t): Use the new
	SCM_I_SSIZE_MIN, SCM_I_SSIZE_MAX, and SCM_I_SIZE_MAX macros for
	the limits.  Those are always defined.
	
2004-07-29  Kevin Ryde  <user42@zip.com.au>

	* posix.c (scm_ttyname): Use scm_i_misc_mutex for thread safety.

2004-07-28  Kevin Ryde  <user42@zip.com.au>

	* posix.c (scm_ctermid): Use an L_ctermid buf on the stack, for thread
	safety.

	* unif.c (scm_array_set_x): For svect, use scm_num2short for
	consistency with other vector types and to get arg and func name into
	error message.

2004-07-27  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* deprecated.h (SCM_FALSEP, SCM_NFALSEP, SCM_BOOLP, SCM_BOOL):
	Reimplement using scm_is_false, scm_is_true, scm_is_bool, and
	scm_from_bool, respectively.
	(SCM_NINUMP): Added.
	
	* tags.h, deprecated.h (SCM_EQ_P): Deprecated by moving it into
	deprecated.h.  Replaced all uses with scm_is_eq.

2004-07-24  Kevin Ryde  <user42@zip.com.au>

	* threads.c, threads.h (scm_i_misc_mutex): New SCM_GLOBAL_MUTEX.
	* posix.c (scm_crypt): Use it to protect static data in crypt().

2004-07-23  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* deprecated.h, deprecated.c, numbers.h (SCM_INUMP, SCM_NINUMP,
	SCM_INUM): Deprecated by renaming them to SCM_I_INUMP,
	SCM_I_NINUMP and SCM_I_INUM, respectively and adding deprecated
	versions to deprecated.h and deprecated.c.  Changed all uses to
	either use the SCM_I_ variants or scm_is_*, scm_to_*, or
	scm_from_*, as appropriate.

	* dynwind.c (scm_i_dowinds): Removed unused code that would call
	the unexisting scm_cross_dynwind_binding_scope for inums on the
	windlist.
	
2004-07-10  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* socket.c (ipv6_net_to_num, scm_from_ipv6): Renamed
	ipv6_net_to_num to scm_from_ipv6, for converting from an IPv6
	byte-wise address to a SCM integer.  Changed all uses.
	(ipv6_num_to_net, scm_to_ipv6): Renamed ipv6_num_to_net to
	scm_to_ipv6 and added type and range checking, for converting from
	an IPv& byte-wise address to a SCM integer.  Changed all uses.
	(bignum_in_ipv6_range_p, VALIDATE_INET6): Removed, their function
	is now done by scm_to_ipv6.
	
	* numbers.c (scm_to_signed_integer, scm_to_unsigned_integer): dot
	not accept inexact integers.

	* validate.h, deprecated.h (SCM_VALIDATE_INUM,
	SCM_VALIDATE_INUM_COPY, SCM_VALIDATE_BIGINT,
	SCM_VALIDATE_INUM_MIN, SCM_VALIDATE_INUM_MIN_COPY,
	SCM_VALIDATE_INUM_MIN_DEF_COPY,SCM_VALIDATE_INUM_DEF,
	SCM_VALIDATE_INUM_DEF_COPY, SCM_VALIDATE_INUM_RANGE,
	SCM_VALIDATE_INUM_RANGE_COPY): Deprecated because they make the
	fixnum/bignum distinction visible.  Changed all uses to
	scm_to_size_t or similar.

2004-07-09  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* cpp_cnvt.awk: Use scm_from_int instead of SCM_MAKINUM.

2004-07-10  Kevin Ryde  <user42@zip.com.au>

	* hash.c (scm_hashq, scm_hashv, scm_hash): Restrict to size>=1 rather
	than size>=0, since 0<=hash<size cannot be satisfied for size==0, and
	such a size causes divide-by-zeros in scm_hasher.

        * regex-posix.c (scm_make_regexp): Free rx on error, to avoid memory
	leak.

2004-07-08  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* numbers.c (scm_is_signed_integer, scm_is_unsigned_integer):
	Rewritten using the same logic as scm_to_signed_integer and
	scm_to_unsigned_integer, respectively, which is better(tm).  Also,
	use CHAR_BIT instead of hardcoding 8.
	(LLONG_MIN, LLONG_MAX, ULLONG_MAX): Removed and used
	SCM_I_LLONG_MIN etc. instead.
	
	* numbers.h (SCM_MAKINUM, SCM_I_MAKINUM): Renamed SCM_MAKINUM to
	SCM_I_MAKINUM and changed all uses.
	* deprecated.h, deprecated.c (SCM_MAKINUM): Newly deprecated.

	* gen-scmconfig.c (SCM_I_LLONG_MIN, SCM_I_LLONG_MAX,
	SCM_I_ULLONG_MAX): Instead of hard-coding the numbers, compute
	them by assuming twos-complement.

2004-07-07  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* gen-scmconfig.h.in: Added all the new SCM_I_GSC_*_LIMITS that
	configure now produces.
	* gen-scmconfig.c: Use them to output SCM_T_INT8_MIN, etc
	definitions, giving the limits of the integer types defined by
	Guile. Also, output a hard coded SCM_I_LLONG_MIN, etc since
	LLONG_MIN or LONG_LONG_MIN is hard to get at.

	* numbers.h (scm_to_short, scm_to_ushort): It's SHRT_MIN, etc, not
	SHORT_MIN.
	(scm_to_size_t): Use SIZE_MAX instead of cooking our own.
	(scm_to_long_long, scm_to_ulong_long, scm_to_int8, scm_to_uint8,
	scm_to_int16, scm_to_uint16, scm_to_int32, scm_to_uint32,
	scm_to_int64, scm_to_uint64, scm_to_intmax, scm_to_uintmax,
	scm_from_long_long, scm_from_ulong_long, scm_from_int8,
	scm_from_uint8, scm_from_int16, scm_from_uint16, scm_from_int32,
	scm_from_uint32, scm_from_int64, scm_from_uint64, scm_from_intmax,
	scm_from_uintmax): New.
	
2004-07-06  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* tags.h (scm_is_eq): New.

	* deprecated.h, boolean.h (SCM_FALSEP, SCM_NFALSEP, SCM_BOOL,
	SCM_NEGATE_BOOL, SCM_BOOLP): Deprecated by moving into
	"deprecated.h".  Replaced all uses with scm_is_false, scm_is_true,
	scm_from_bool, and scm_is_bool, respectively.

	* boolean.h (scm_is_bool): Fix bug in prototype.
	(scm_from_bool): The argument is "x" not "f", stupid.

	* boolean.c (scm_is_bool): Fix typo.

	* numbers.h, numbers.c (scm_is_integer, scm_is_signed_integer,
	scm_is_unsigned_integer, scm_to_signed_integer,
	scm_to_unsigned_integer, scm_to_schar, scm_to_uchar, scm_to_char,
	scm_to_short, scm_to_ushort, scm_to_long, scm_to_ulong,
	scm_to_size_t, scm_to_ssize_t, scm_from_schar, scm_from_uchar,
	scm_from_char, scm_from_short, scm_from_ushort, scm_from_int,
	scm_from_uint, scm_from_long, scm_from_ulong, scm_from_size_t,
	scm_from_ssize_t, scm_is_real, scm_to_double, scm_from_double):
	New.
	
2004-07-05  Marius Vollmer  <marius.vollmer@uni-dortmund.de>

	* boolean.h, boolean.c (scm_is_true, scm_is_false, scm_from_bool,
	scm_to_bool): New.

2004-06-27  Dirk Herrmann  <dirk@dirk-herrmanns-seiten.de>

	* backtrace.c (display_expression, display_frame): Call
	scm_i_unmemoize_expr for unmemoizing a memoized object holding a
	single memoized expression.

	* debug.c (memoized_print): Don't try to unmemoize the memoized
	object, since we can't know whether it holds a single expression
	or a body.

	(scm_mem_to_proc): Removed check for lambda expression, since it
	was moot anyway.  Whoever uses these functions for debugging
	purposes should know what they do: Creating invalid memoized code
	will cause crashes, independent of whether this check is present
	or not.

	(scm_proc_to_mem): Take the closure's code as it is and don't
	append a SCM_IM_LAMBDA isym.  To allow easier debugging, the
	memoized code should not be modified.

	* debug.[ch] (scm_unmemoize, scm_i_unmemoize_expr): Removed
	scm_unmemoize from public use, but made scm_i_unmemoize_expr
	available as a guile internal function instead.  However,
	scm_i_unmemoize_expr will only work on memoized objects that hold
	a single memoized expression.  It won't work with bodies.

	* debug.c (scm_procedure_source), macros.c (macro_print), print.c
	(scm_iprin1): Call scm_i_unmemocopy_body for unmemoizing a body,
	i. e. a list of expressions.

	* eval.c (unmemoize_exprs): Drop internal body markers from the
	output during unmemoization.

	* eval.[ch] (scm_unmemocopy, scm_i_unmemocopy_expr,
	scm_i_unmemocopy_body): Removed scm_unmemocopy from public use,
	but made scm_i_unmemocopy_expr and scm_i_unmemocopy_body available
	as guile internal functions instead.  scm_i_unmemoize_expr will
	only work on a single memoized expression, while
	scm_i_unmemocopy_body will only work on bodies.

2004-06-21  Dirk Herrmann  <dirk@dirk-herrmanns-seiten.de>

	* eval.c (unmemoize_exprs): Handle semi-memoized code.

	(scm_cons_source, scm_primitive_eval): Prefer higher level
	predicate SCM_FALSEP over SCM_IMP.

2004-06-15  Rob Browning  <rlb@defaultvalue.org>

	* script.c (scm_shell_usage): minor phrasing change.

	* gc_os_dep.c: update ifdefery for macosx.
	(scm_get_stack_base): separate result initialization from
	declaration to slience warnings with macosx and hp-ux using gcc