1 2012-05-21 Ken Brown <kbrown@cornell.edu>
3 * xgselect.c (xg_select): Fix first argument in call to 'select'
6 2012-05-20 Ken Brown <kbrown@cornell.edu>
8 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
9 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
11 2012-05-19 Ken Brown <kbrown@cornell.edu>
13 * xfns.c (x_in_use): Remove `static' qualifier.
14 * xterm.h (x_in_use): Declare.
15 * xgselect.c: Include xterm.h.
16 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
17 and `display_arg' (bug#9754).
19 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
21 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
23 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
24 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
26 2012-05-18 Eli Zaretskii <eliz@gnu.org>
28 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
30 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
31 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
33 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
34 reference to image_cache->refcount.
35 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
37 2012-05-17 Juri Linkov <juri@jurta.org>
39 * search.c (Fword_search_regexp, Fword_search_backward)
40 (Fword_search_forward, Fword_search_backward_lax)
41 (Fword_search_forward_lax): Move functions to isearch.el
42 (bug#10145, bug#11381).
44 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
46 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
48 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
50 * lread.c (init_obarray): Declare Qt and Qnil as special.
52 2012-05-14 Glenn Morris <rgm@gnu.org>
54 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
55 Put "libexec" before "bin", for the sake of init_callproc_1.
57 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
59 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
61 * unexaix.c: Port to more-recent AIX compilers.
62 (report_error, report_error_1, make_hdr, copy_sym)
63 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
64 Make arguments const char *, not char *, to avoid violations of C
65 standard and to fix some AIX warnings reported by Gilles Pion.
67 2012-05-14 Eli Zaretskii <eliz@gnu.org>
69 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
70 already have overlays loaded.
71 (handle_single_display_spec): Before returning without displaying
72 fringe bitmap, synchronize the bidi iterator with the main display
73 iterator, by calling iterate_out_of_display_property.
74 (iterate_out_of_display_property): Detect buffer iteration by
75 testing that it->string is a Lisp string.
76 (get_next_display_element): When the current object is exhausted,
77 and there's something on it->stack, call set_iterator_to_next to
78 proceed with what's on the stack, instead of returning zero.
79 (set_iterator_to_next): If called at the end of a Lisp string,
80 proceed to consider_string_end without incrementing string
81 position. Don't increment display vector index past the end of
82 the display vector. (Bug#11417)
83 (pos_visible_p): Don't report a position visible when move_it_to
84 stopped at the last line of window, which happens to be scanned
85 backwards by the bidi iteration. (Bug#11464)
87 2012-05-14 Eli Zaretskii <eliz@gnu.org>
89 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
90 and right-margin display specs even if the spec is invalid or we
91 are on a TTY, and thus unable to display on the fringes. That's
92 because the text with the property will not be displayed anyway,
93 so we need to signal to the caller that this is a "replacing"
94 display spec. This fixes display when the spec is invalid or we
97 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
99 * unexaix.c (make_hdr): Fix typo in prototype.
100 This bug broke the build on AIX. Problem reported by Gilles Pion.
102 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
104 * keyboard.c (kbd_buffer_get_event): Read special events also in
105 batch mode. (Bug#11415)
107 2012-05-12 Glenn Morris <rgm@gnu.org>
109 * ns.mk: Update for ns_appbindir no longer having trailing "/".
111 2012-05-12 Eli Zaretskii <eliz@gnu.org>
113 * lisp.mk (lisp): Add newcomment.elc.
115 2012-05-12 Glenn Morris <rgm@gnu.org>
117 * Makefile.in (MKDIR_P): New, set by configure.
118 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
120 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
122 Remove unused function hourglass_started.
123 * dispextern.h (hourglass_started):
124 * w32fns.c (hourglass_started):
125 * xdisp.c (hourglass_started): Remove.
127 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
129 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
132 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
134 * xgselect.c (xg_select): Put maxfds+1 into a var.
135 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
137 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
139 2012-05-10 Dave Abrahams <dave@boostpro.com>
141 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
142 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
144 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
146 * dbusbind.c (xd_registered_buses): New internal Lisp object.
147 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
148 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
149 Initialize xd_registered_buses.
151 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
153 Untag more efficiently if USE_LSB_TAG.
154 This is based on a proposal by YAMAMOTO Mitsuharu in
155 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
156 For an admittedly artificial (nth 8000 longlist) benchmark on
157 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
158 Emacs's overall text size by 1%.
159 * lisp.h (XUNTAG): New macro.
160 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
161 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
162 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
163 * eval.c (Fautoload):
164 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
165 * frame.h (XFRAME): Use XUNTAG.
167 Port recent dbusbind.c changes to 32-bit --with-wide-int.
168 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
169 Remove unportable assumptions about print widths of types like
171 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
172 intptr_t when converting between pointer and integer, to avoid GCC
173 warnings about wrong width.
175 2012-05-09 Eli Zaretskii <eliz@gnu.org>
177 * w32proc.c (new_child): Force Windows to reserve only 64KB of
178 stack for each reader_thread, instead of defaulting to 8MB
179 determined by the linker. This avoids failures in creating
180 subprocesses on Windows 7, see the discussion in this thread:
181 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
183 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
185 Fix up display of the *Minibuf-0* buffer in the mini window.
186 * keyboard.c (read_char): Don't clear the echo area if there's no
188 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
189 contents of *Minibuf-0*) if there's no message displayed in its stead.
191 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
193 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
196 2012-05-06 Chong Yidong <cyd@gnu.org>
198 * lisp.mk (lisp): Update.
200 2012-05-05 Jim Meyering <meyering@redhat.com>
202 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
204 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
206 * data.c (PUT_ERROR): New macro.
207 (syms_of_data): Use it. Add new error type `user-error'.
208 * undo.c (user_error): New function.
209 (Fprimitive_undo): Use it.
210 * print.c (print_error_message): Adjust print style for `user-error'.
211 * keyboard.c (user_error): New function.
212 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
214 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
216 Do not limit current-time-string to years 1000..9999.
217 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
218 (Fcurrent_time_string): Support any year that is supported by the
219 underlying localtime representation. Don't use asctime, as it
220 has undefined behavior for years outside the range -999..9999.
222 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
224 Fix race conditions involving setenv, gmtime, localtime, asctime.
225 Without this fix, interrupts could mess up code that uses these
226 nonreentrant functions, since setting TZ invalidates existing
227 tm_zone or tzname values, and since most of these functions return
228 pointers to static storage.
229 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
230 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
231 Grow the critical sections to include not just invoking
232 localtime/gmtime, but also accessing these functions' results
233 including their tm_zone values if any, and any related TZ setting.
234 (format_time_string): Last arg is now struct tm *, not struct tm **,
235 so that the struct tm is saved in the critical section.
236 All callers changed. Simplify allocation of initial buffer, partly
237 motivated by the fact that memory allocation needs to be outside
238 the critical section.
240 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
242 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
245 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
246 Remove duplicated buffer name initialization.
248 2012-05-02 Jim Meyering <jim@meyering.net>
250 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
252 * xfns.c (x_window): Use xstrdup (Bug#11375).
254 2012-05-02 Eli Zaretskii <eliz@gnu.org>
256 * xdisp.c (pos_visible_p): If already at a newline from the
257 display string before the 'while' loop, don't walk back the glyphs
258 from it3.glyph_row. Solves assertion violation when the display
259 string begins with a newline (egg.el). (Bug#11367)
261 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
263 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
266 2012-05-01 Glenn Morris <rgm@gnu.org>
268 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
269 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
270 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
271 All were removed before 23.1.
273 * dispnew.c: Remove HAVE_LIBNCURSES test;
274 it is always true on relevant platforms.
276 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
277 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
279 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
281 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
283 * .gdbinit (xpr): Remove checks for no longer existing misc types.
284 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
287 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
289 Do not avoid creating empty evaporating overlays (Bug#9642).
290 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
291 That is, do not delete an evaporating overlay if it becomes
292 empty after its bounds are adjusted to fit within its buffer.
293 This fix caused other problems, and I'm reverting it until we get
294 to the bottom of them.
296 2012-04-27 Chong Yidong <cyd@gnu.org>
298 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
300 2012-04-27 Eli Zaretskii <eliz@gnu.org>
302 * xdisp.c (pos_visible_p): If the window start position is beyond
303 ZV, start the display from buffer beginning. Prevents assertion
304 violation in init_iterator when the minibuffer window is scrolled
307 * window.c (window_scroll_pixel_based): Likewise.
309 2012-04-27 Chong Yidong <cyd@gnu.org>
311 * keymap.c (where_is_internal): Doc fix (Bug#10872).
313 2012-04-27 Glenn Morris <rgm@gnu.org>
315 * fileio.c (Fcopy_file, Fset_file_selinux_context):
316 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
318 2012-04-27 Eli Zaretskii <eliz@gnu.org>
320 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
321 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
323 2012-04-26 Eli Zaretskii <eliz@gnu.org>
325 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
326 display element, check also the underlying string or buffer
327 character. (Bug#11341)
329 * w32menu.c: Include w32heap.h.
330 (add_menu_item): If the call to AppendMenuW (via
331 unicode_append_menu) fails, disable Unicode menus only if we are
332 running on Windows 9X/Me.
334 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
336 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
337 (xgetint): Add missing shift for LSB tags.
339 2012-04-24 Martin Rudalics <rudalics@gmx.at>
341 * keyboard.c (read_char): Don't wipe echo area for select window
342 events: These might get delayed via `mouse-autoselect-window'
345 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
347 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
348 manipulation of :loaded-from data.
350 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
352 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
353 now a cons (bug#11311).
355 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
357 Do not create empty overlays with the evaporate property (Bug#9642).
358 * buffer.c (Fmove_overlay): Delete an evaporating overlay
359 if it becomes empty after its bounds are adjusted to fit within
360 its buffer. Without this fix, in a nonempty buffer (let ((o
361 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
362 yields an empty overlay that has the evaporate property, which is
363 not supposed to happen.
365 Fix minor GTK3 problems found by static checking.
366 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
367 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
368 (struct _EmacsFixedClass, emacs_fixed_get_type):
369 Move decls here from emacsgtkfixed.h, since they needn't be public.
370 (emacs_fixed_get_type): Now static.
371 (emacs_fixed_class_init): Omit unused local.
372 (emacs_fixed_child_type): Remove; unused.
373 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
374 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
375 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
376 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
377 (EMACS_FIXED_GET_CLASS): Remove; unused.
378 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
380 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
381 Problem reported by Juanma Barranquero for Windows -Wunused-function.
383 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
385 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
386 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
387 (__malloc_size_t, __malloc_ptrdiff_t):
388 Remove. All uses removed, replaced by the definiens if needed,
389 since we can assume C89 or better now.
390 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
391 (protect_malloc_state, align, get_contiguous_space)
392 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
393 (malloc_atfork_handler_child, malloc_enable_thread)
394 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
395 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
396 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
397 (special_realloc, _realloc_internal_nolock, _realloc_internal)
398 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
399 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
400 Define using prototypes, not old style.
401 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
402 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
403 (align): Don't assume that signed integer overflow wraps around.
404 Omit unused local var.
405 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
406 (_free_internal_nolock, memalign, mallochook, reallochook):
407 Omit no-longer-needed casts.
408 (valloc): Use getpagesize, not __getpagesize.
409 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
410 (struct hdr): The 'magic' member is now size_t, not unsigned long.
412 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
414 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
416 Move functions from C to Lisp. Make non-blocking method calls
417 the default. Implement further D-Bus standard interfaces.
419 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
420 (QCdbus_request_name_allow_replacement)
421 (QCdbus_request_name_replace_existing)
422 (QCdbus_request_name_do_not_queue)
423 (QCdbus_request_name_reply_primary_owner)
424 (QCdbus_request_name_reply_in_queue)
425 (QCdbus_request_name_reply_exists)
426 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
427 (QCdbus_registered_serial, QCdbus_registered_method)
428 (QCdbus_registered_signal): New Lisp objects.
429 (XD_DEBUG_MESSAGE): Use sizeof.
430 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
431 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
432 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
433 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
434 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
435 (xd_signature, xd_append_arg): Allow float for integer types.
436 (xd_get_connection_references): New function.
437 (xd_get_connection_address): Rename from xd_initialize.
438 Return cached address.
439 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
440 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
442 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
443 Return number of refcounts.
444 (Fdbus_get_unique_name): Make stronger parameter check.
445 (Fdbus_message_internal): New defun.
446 (Fdbus_call_method, Fdbus_call_method_asynchronously)
447 (Fdbus_method_return_internal, Fdbus_method_error_internal)
448 (Fdbus_send_signal, Fdbus_register_service)
449 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
450 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
451 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
452 (Vdbus_compiled_version, Vdbus_runtime_version)
453 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
454 (Vdbus_message_type_method_return, Vdbus_message_type_error)
455 (Vdbus_message_type_signal): New defvars.
456 (Vdbus_registered_buses, Vdbus_registered_objects_table):
459 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
461 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
462 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
463 Do not assume ptrdiff_t is the same width as 'int'.
465 * alloc.c: Handle unusual debugging option combinations.
466 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
467 since the two debugging options are incompatible.
468 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
470 (mem_init, mem_insert, mem_insert_fixup):
471 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
472 (NEED_MEM_INSERT): Remove; no longer needed.
474 2012-04-22 Leo Liu <sdl.web@gmail.com>
476 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
478 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
480 * sysdep.c [__FreeBSD__]: Minor cleanups.
481 (list_system_processes, system_process_attributes) [__FreeBSD__]:
482 Use Emacs indenting style more consistently. Avoid some casts.
483 Use 'double' consistently rather than mixing 'float' and 'double'.
485 2012-04-21 Eduard Wiebe <usenet@pusto.de>
487 * sysdep.c (list_system_processes, system_process_attributes):
488 Add implementation for FreeBSD (Bug#5243).
490 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
492 * lisp.mk (lisp): Update.
494 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
496 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
497 It is never used otherwise.
499 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
501 * print.c (print_preprocess): Only check print_depth if print-circle
503 (print_object): Check for cycles even when print-circle is nil and
504 print-gensym is t, but only check print_depth if print-circle is nil.
506 2012-04-20 Chong Yidong <cyd@gnu.org>
508 * process.c (wait_reading_process_output): If EIO occurs on a pty,
509 set the status to "failed" and ensure that sentinel is run.
511 2012-04-20 Glenn Morris <rgm@gnu.org>
513 * process.c (Fset_process_inherit_coding_system_flag)
514 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
515 (Fmake_network_process, Fmake_serial_process): Doc fix.
517 2012-04-20 Eli Zaretskii <eliz@gnu.org>
519 * xdisp.c (string_buffer_position_lim): Limit starting position to
521 (set_cursor_from_row): If called for a mode-line or header-line
522 row, return zero immediately.
523 (try_cursor_movement): If inside continuation line, don't back up
524 farther than the first row after the header line, if any.
525 Don't consider the header-line row as "partially visible", even if
526 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
528 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
530 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
533 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
534 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
536 configure: new option --enable-gcc-warnings (Bug#11207)
537 * Makefile.in (C_WARNINGS_SWITCH): Remove.
538 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
539 (ALL_CFLAGS): Use new macros rather than old.
540 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
541 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
542 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
543 -Wunused-result, -Wunused-variable. This should go away once
544 the Emacs and Gnulib regex code is merged.
545 (xmalloc, xrealloc): Now static.
547 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
549 * dired.c (Fsystem_groups): Remove unused local.
551 2012-04-17 Glenn Morris <rgm@gnu.org>
553 * dired.c (Fsystem_users): Doc fix.
555 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
557 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
558 (syms_of_dired): Add them.
560 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
562 Fix minor alloc.c problems found by static checking.
563 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
564 New extern decls, to avoid calling undeclared functions.
565 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
566 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
567 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
568 (NEED_MEM_INSERT): New macro.
569 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
570 Remove one incorrect comment and fix another.
572 Fix minor ralloc.c problems found by static checking.
573 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
574 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
575 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
576 (r_alloc_sbrk): Now static.
578 Improve ralloc.c interface checking.
579 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
580 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
581 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
582 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
583 [REL_ALLOC]: ... to here, to check interface.
584 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
585 Remove decls. This fixes an "It stinks!".
587 * alloc.c (which_symbols): Fix alignment issue / type clash.
589 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
591 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
592 (struct Lisp_Misc_Any): Likewise.
593 (struct Lisp_Free): Likewise.
594 * alloc.c (union aligned_Lisp_Symbol): Define.
595 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
596 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
597 (union aligned_Lisp_Misc): Define.
598 (MARKER_BLOCK_SIZE, struct marker_block): Use union
599 aligned_Lisp_Misc instead of union Lisp_Misc.
600 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
602 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
604 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
605 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
606 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
607 * s/netbsd.h, s/sol2-6.h:
608 Remove definition of GC_MARK_STACK, since the default now works.
609 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
610 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
611 no longer the default.
612 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
614 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
616 * lread.c (lisp_file_lexically_bound_p):
617 Fix hang at ";-*-\n" (bug#11238).
619 2012-04-14 Eli Zaretskii <eliz@gnu.org>
621 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
622 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
624 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
626 * nsterm.m (constrainFrameRect): Always constrain when there is only
627 one screen (Bug#10962).
629 2012-04-13 Ken Brown <kbrown@cornell.edu>
631 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
633 2012-04-13 Reuben Thomas <rrt@sc3d.org>
635 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
637 2012-04-11 Daniel Colascione <dancol@dancol.org>
639 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
640 against is gone. It's better to use vfork now so that when Cygwin
641 gains a new, working vfork, we use it automatically (bug#10398).
643 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
645 * window.c (save_window_save): Obey window-point-insertion-type.
647 2012-04-11 Glenn Morris <rgm@gnu.org>
649 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
651 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
653 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
655 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
657 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
658 (force_quit_count): New var.
659 (handle_interrupt): Use it.
661 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
663 * w32.c (w32_delayed_load): Record the full path of the library
664 being loaded (bug#10424).
666 2012-04-09 Glenn Morris <rgm@gnu.org>
668 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
669 not just in the obarray, before snarfing them. (Bug#11036)
671 * Makefile.in ($(leimdir)/leim-list.el):
672 Pass EMACS rather than BUILT_EMACS.
674 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
676 * process.c (make_process):
677 * process.h: Add integer `gnutls_handshakes_tried' member to
680 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
681 Add convenience `GNUTLS_LOG2i' macro.
683 * gnutls.c (gnutls_log_function2i): Convenience log function.
684 (emacs_gnutls_read): Use new log functions,
685 `gnutls_handshakes_tried' process member, and
686 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
687 attempts per process (connection).
689 2012-04-09 Chong Yidong <cyd@gnu.org>
691 * eval.c (Fuser_variable_p, user_variable_p_eh)
692 (lisp_indirect_variable): Functions deleted.
693 (Fdefvar): Caller changed.
695 * callint.c (Finteractive, Fcall_interactively):
696 * minibuf.c (Fread_variable): Callers changed.
698 2012-04-09 Eli Zaretskii <eliz@gnu.org>
700 * xdisp.c (set_cursor_from_row): If the display string appears in
701 the buffer at position that is closer to point than the position
702 after the display string, display the cursor on the first glyph of
703 the display string. Fixes cursor display when a 'display' text
704 property immediately follows invisible text. (Bug#11094)
706 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
708 composite.c: use 'double' consistently
709 * composite.c (get_composition_id): Use 'double' consistently
710 instead of converting 'float' to 'double' and vice versa; this is
711 easier to understand and avoids a GCC warning.
713 2012-04-09 Glenn Morris <rgm@gnu.org>
715 * Makefile.in: Generate leim-list with bootstrap-emacs, in
716 preparation for dumping it with emacs. (Bug#4789)
717 (leimdir): New variable.
718 ($(leimdir)/leim-list.el): New rule.
719 (emacs$(EXEEXT)): Depend on leim-list.el.
721 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
722 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
723 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
725 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
727 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
730 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
732 * xml.c (init_libxml2_functions) [WINDOWSNT]:
733 Remove unused local variable.
735 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
737 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
738 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
739 (mark_memory): Mark Lisp_Objects only if pointers might hide in
740 objects, as mark_maybe_pointer will catch them otherwise.
741 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
742 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
744 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
746 Fix typo that broke non-Windows builds.
747 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
749 2012-04-07 Eli Zaretskii <eliz@gnu.org>
751 Support building on MS-Windows with libxml2.
753 * makefile.w32-in (OBJ2): Add xml.$(O).
754 (GLOBAL_SOURCES): Add xml.c.
755 ($(BLD)/xml.$(O)): New dependency list.
757 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
758 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
759 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
760 [!WINDOWSNT]: New macros.
761 (init_libxml2_functions, libxml2_loaded_p): New functions.
762 (parse_region): Call fn_xmlCheckVersion instead of using the macro
763 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
764 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
765 Calls xmlCleanupParser only if libxml2 was loaded (or statically
767 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
768 Call init_libxml2_functions before calling libxml2 functions.
769 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
771 * emacs.c: Don't include libxml/parser.h.
772 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
773 xmlCleanupParser directly.
775 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
777 2012-04-07 Eli Zaretskii <eliz@gnu.org>
779 * indent.c (Fvertical_motion): If there is a display string at
780 point, use it.vpos to compute how many lines to backtrack after
781 move_it_to point. (Bug#11133)
783 2012-04-06 Eli Zaretskii <eliz@gnu.org>
785 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
786 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
787 about subtle differences between FETCH_CHAR* and STRING_CHAR*
788 macros related to unification of CJK characters. For the details,
789 see the discussion following the message here:
790 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
792 2012-04-04 Chong Yidong <cyd@gnu.org>
794 * keyboard.c (Vdelayed_warnings_list): Doc fix.
796 2012-04-01 Eli Zaretskii <eliz@gnu.org>
798 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
799 instead of alloca. (Bug#11138)
801 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
803 * w32menu.c (is_simple_dialog): Properly check lisp types.
806 2012-03-31 Eli Zaretskii <eliz@gnu.org>
808 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
809 position we get to after a call to move_it_to fails the
810 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
811 only if we wind up in a string from display property. (Bug#11063)
813 * window.c (Fdelete_other_windows_internal): Invalidate the row
814 and column information about mouse highlight, so that redisplay
815 restores it after reallocating the glyph matrices. (Bug#7464)
817 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
818 string comes from a `display' text property, use the buffer
819 position of that property as if we actually saw that position in
821 (move_it_by_lines): Remove the assertion that
822 "it->current_x == 0 && it->hpos == 0" which can be legitimately
823 violated when there's a before-string at the beginning of a line.
826 2012-03-30 Eli Zaretskii <eliz@gnu.org>
828 * xdisp.c (append_space_for_newline): If the default face was
829 remapped, use the remapped face for the appended newline.
830 (extend_face_to_end_of_line): Use the remapped default face for
831 extending the face to the end of the line.
832 (display_line): Call extend_face_to_end_of_line when the default
833 face was remapped. (Bug#11068)
835 2012-03-29 Eli Zaretskii <eliz@gnu.org>
837 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
839 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
841 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
843 2012-03-27 Glenn Morris <rgm@gnu.org>
845 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
848 2012-03-26 Kenichi Handa <handa@m17n.org>
850 * dispextern.h (struct glyph): Fix previous change. Change the
851 bit length of glyphless.ch to 25 (Bug#11082).
853 2012-03-26 Chong Yidong <cyd@gnu.org>
855 * keyboard.c (Vselection_inhibit_update_commands): New variable.
856 (command_loop_1): Use it; inhibit selection update for
857 handle-select-window too (Bug#8996).
859 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
861 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
863 2012-03-25 Kenichi Handa <handa@m17n.org>
865 * dispextern.h (struct glyph): Change the bit length of
866 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
868 2012-03-24 Eli Zaretskii <eliz@gnu.org>
870 * s/ms-w32.h (tzname): Include time.h before redirecting to
871 _tzname. Fixes the MSVC build. (Bug#9960)
873 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
875 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
878 * xterm.c (XTread_socket): Only modify handling_signal if
879 !SYNC_INPUT. (Bug#11080)
881 2012-03-23 Eli Zaretskii <eliz@gnu.org>
883 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
884 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
885 when fetching a multibyte character consumes more bytes than
886 CHAR_BYTES returns, due to unification of CJK characters in
887 string_char. (Bug#11073)
889 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
891 * process.c (wait_reading_process_output): Handle pty disconnect
892 by refraining from sending oneself a SIGCHLD (bug#10933).
894 2012-03-22 Chong Yidong <cyd@gnu.org>
896 * dispextern.h (struct it): New member string_from_prefix_prop_p.
898 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
899 Mark string as coming from a prefix property.
900 (handle_face_prop): Use default face for prefix strings (Bug#4281).
901 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
903 2012-03-21 Chong Yidong <cyd@gnu.org>
905 * xfaces.c (Vface_remapping_alist): Doc fix.
907 2012-03-20 Eli Zaretskii <eliz@gnu.org>
909 * w32proc.c (Fw32_set_console_codepage)
910 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
913 2012-03-20 Chong Yidong <cyd@gnu.org>
915 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
916 to reflect default non-nil value of redisplay-dont-pause.
918 2012-03-19 Kenichi Handa <handa@m17n.org>
920 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
921 it fit in a valid range (Bug#11003).
923 2012-03-18 Eli Zaretskii <eliz@gnu.org>
925 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
926 that is not from display property, accept the row as a "cursor
927 row" if one of the string's character has a non-nil `cursor'
928 property. Fixes cursor positioning when there are newlines in
929 overlay strings, e.g. in icomplete.el. (Bug#11035)
931 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
933 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
935 2012-03-12 Chong Yidong <cyd@gnu.org>
937 * eval.c (inhibit_lisp_code): Rename from
938 inhibit_window_configuration_change_hook; move from window.c.
940 * xfns.c (unwind_create_frame_1, Fx_create_frame):
941 * window.c (run_window_configuration_change_hook)
942 (syms_of_window): Callers changed.
944 2012-03-11 Chong Yidong <cyd@gnu.org>
946 * keymap.c (Fkey_description): Doc fix (Bug#9700).
948 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
950 2012-03-10 Chong Yidong <cyd@gnu.org>
952 * frame.c (other_visible_frames): Don't assume the selected frame
953 is visible (Bug#10955).
955 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
957 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
959 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
961 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
962 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
965 2012-03-03 Glenn Morris <rgm@gnu.org>
967 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
969 2012-03-02 Eli Zaretskii <eliz@gnu.org>
971 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
972 position past the first glyph_row that ends at ZV. (Bug#10902)
973 (redisplay_window, next_element_from_string): Fix typos in
975 (redisplay_window): Pass to move_it_vertically the margin in
976 pixels, not in screen lines.
978 2012-03-02 Glenn Morris <rgm@gnu.org>
980 * buffer.c (buffer-list-update-hook): Doc fix.
982 2012-02-29 Eli Zaretskii <eliz@gnu.org>
984 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
985 push_it before setting up the iterator for the first overlay
986 string, even if we have an empty string loaded.
987 (next_overlay_string): If there's an empty string on the iterator
988 stack, pop the stack. (Bug#10903)
990 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
992 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
993 Suggested by Stefan Monnier in
994 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
995 * alloc.c (widen_to_Lisp_Object): New static function.
996 (mark_memory): Also mark Lisp_Objects by fetching pointer words
997 and widening them to Lisp_Objects. This would work even if
998 USE_LSB_TAG is defined and wide integers are used, which might
999 happen in a future version of Emacs.
1001 2012-02-25 Chong Yidong <cyd@gnu.org>
1003 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1006 * xselect.c (Fx_selection_exists_p): Doc fix.
1007 (x_clipboard_manager_save_all): Print an informative message
1008 before saving to clipboard manager.
1010 2012-02-24 Chong Yidong <cyd@gnu.org>
1012 * keyboard.c (process_special_events): Handle all X selection
1013 requests in kbd_buffer, not just the next one (Bug#8869).
1015 2012-02-23 Chong Yidong <cyd@gnu.org>
1017 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1018 call when setting menu-bar-lines and tool-bar-lines parameters.
1019 (unwind_create_frame_1): New helper function.
1021 * window.c (inhibit_window_configuration_change_hook): New var.
1022 (run_window_configuration_change_hook): Obey it.
1023 (syms_of_window): Initialize it.
1025 2012-02-22 Chong Yidong <cyd@gnu.org>
1027 * xterm.c (x_draw_image_relief): Add missing type check for
1028 Vtool_bar_button_margin (Bug#10743).
1030 2012-02-21 Chong Yidong <cyd@gnu.org>
1032 * fileio.c (Vfile_name_handler_alist): Doc fix.
1034 * buffer.c (Fget_file_buffer): Protect against invalid file
1035 handler return value.
1037 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1039 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1040 when computing $valmask.
1042 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1043 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1044 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1045 It's useless in that case, and it can cause problems on hosts
1046 that allocate halves of EMACS_INT values separately.
1047 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1048 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1049 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1050 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1051 it avoids undefined behavior on hosts where shifting right by more
1052 than the word width has undefined behavior.
1054 2012-02-19 Chong Yidong <cyd@gnu.org>
1056 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1057 (Funhandled_file_name_directory, Ffile_name_as_directory)
1058 (Fdirectory_file_name, Fexpand_file_name)
1059 (Fsubstitute_in_file_name): Protect against invalid file handler
1060 return values (Bug#10845).
1062 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1064 * .gdbinit (pitx): Fix incorrect references to fields of the
1067 2012-02-17 Chong Yidong <cyd@gnu.org>
1069 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1071 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1073 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1074 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1076 2012-02-15 Chong Yidong <cyd@gnu.org>
1078 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1079 marked as special. Also, starting docstrings with * is obsolete.
1081 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1083 * gnutls.c (emacs_gnutls_write): Fix last change.
1085 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1087 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1090 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1092 * keymap.c (Fsingle_key_description): Handle char ranges.
1094 2012-02-12 Chong Yidong <cyd@gnu.org>
1096 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1097 as that creates a dangerous corner case.
1099 * window.c (Fdelete_window_internal): Invalidate the mouse
1100 highlight (Bug#9904).
1102 2012-02-12 Glenn Morris <rgm@gnu.org>
1104 * xselect.c (Fx_own_selection_internal)
1105 (Fx_get_selection_internal, Fx_disown_selection_internal)
1106 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1107 * nsselect.m (Fx_own_selection_internal)
1108 (Fx_disown_selection_internal, Fx_selection_exists_p)
1109 (Fx_selection_owner_p, Fx_get_selection_internal):
1110 Sync docs and argument specs with the xselect.c versions.
1112 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1114 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1116 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1118 * w32select.c (Fx_selection_exists_p): Sync doc string and
1119 argument list with xselect.c. (Bug#10783)
1121 * w16select.c (Fx_selection_exists_p): Sync doc string and
1122 argument list with xselect.c. (Bug#10783)
1124 2012-02-10 Glenn Morris <rgm@gnu.org>
1126 * fns.c (Fsecure_hash): Doc fix.
1128 2012-02-09 Kenichi Handa <handa@m17n.org>
1130 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1132 2012-02-07 Chong Yidong <cyd@gnu.org>
1134 * buffer.c (Fbuffer_local_variables)
1135 (buffer_lisp_local_variables): Handle unbound vars correctly;
1136 don't let Qunbound leak into Lisp.
1138 2012-02-07 Glenn Morris <rgm@gnu.org>
1140 * image.c (Fimagemagick_types): Doc fix.
1142 * image.c (imagemagick-render-type): Change it from a lisp object
1143 to an integer. Move the doc here from the lisp manual.
1144 Treat all values not equal to 0 the same.
1146 2012-02-06 Chong Yidong <cyd@gnu.org>
1148 * doc.c (store_function_docstring): Avoid applying docstring of
1149 alias to base function (Bug#2603).
1151 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1153 * .gdbinit (pp1, pv1): Remove redundant defines.
1156 2012-02-04 Chong Yidong <cyd@gnu.org>
1158 * nsterm.m: Declare a global (Bug#10694).
1160 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1162 * w32.c (get_emacs_configuration_options):
1163 Include --enable-checking, if specified, in the return value.
1165 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1167 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1168 after rounding frame sizes. (Bug#9723)
1170 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1172 * keyboard.c (adjust_point_for_property): Don't position point
1173 before BEGV. (Bug#10696)
1175 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1177 Handle overflow when computing char display width (Bug#9496).
1178 * character.c (char_width): Return EMACS_INT, not int.
1179 (char_width, c_string_width): Check for overflow when
1180 computing the width; this is possible now that individual
1181 characters can have unbounded width. Problem introduced
1182 by merge from Emacs 23 on 2012-01-19.
1184 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1186 * dbusbind.c (Fdbus_register_method): Mention the return value
1187 :ignore in the docstring.
1189 2012-02-02 Glenn Morris <rgm@gnu.org>
1191 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1193 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1194 Unconditionally set to t. (Bug#10673)
1195 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1196 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1197 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1199 2012-02-02 Kenichi Handa <handa@m17n.org>
1201 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1202 0, do not call append_composite_glyph.
1204 2012-02-02 Kenichi Handa <handa@m17n.org>
1206 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1208 (x_produce_glyphs): If the component of a composition is a null
1209 string, set it->pixel_width to 1 to avoid zero-width glyph.
1211 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1213 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1214 first 2 arguments are identical. This makes inserting large
1215 output from a subprocess an order of magnitude faster on
1216 MS-Windows, where all sbrk'ed memory is always contiguous.
1218 2012-01-31 Glenn Morris <rgm@gnu.org>
1220 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1221 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1222 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1224 2012-01-29 Glenn Morris <rgm@gnu.org>
1226 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1228 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1230 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1232 2012-01-28 Chong Yidong <cyd@gnu.org>
1234 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1236 2012-01-26 Chong Yidong <cyd@gnu.org>
1238 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1240 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1241 repeat counts (Bug#10507).
1243 2012-01-26 Glenn Morris <rgm@gnu.org>
1245 * lread.c (syms_of_lread): Doc fix.
1247 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1249 * coding.c (encode_designation_at_bol): Change return value to
1252 2012-01-25 Chong Yidong <cyd@gnu.org>
1254 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1256 2012-01-21 Chong Yidong <cyd@gnu.org>
1258 * floatfns.c (Fcopysign): Make the second argument non-optional,
1259 since nil is not allowed anyway.
1261 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1263 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1264 (send_process): Likewise.
1266 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1268 * window.c (save_window_save, Fcurrent_window_configuration)
1269 (Vwindow_persistent_parameters): Do not use Qstate.
1270 Rewrite doc-strings.
1272 2012-01-19 Kenichi Handa <handa@m17n.org>
1274 * character.c (char_width): New function.
1275 (Fchar_width, c_string_width, lisp_string_width):
1276 Use char_width (Bug#9496).
1278 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1280 * window.c (Vwindow_persistent_parameters): New variable.
1281 (Fset_window_configuration, save_window_save): Handle persistent
1284 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1286 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1287 thrashing the stack of the thread. (Bug#9087)
1289 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1291 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1293 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1295 * xdisp.c (rows_from_pos_range): Handle the case where the
1296 highlight ends on a newline. (Bug#10464)
1297 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1298 he end column for display of highlight that ends on a newline
1301 2012-01-11 Glenn Morris <rgm@gnu.org>
1303 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1304 from load-path also when installation-directory is nil. (Bug#10208)
1306 2012-01-10 Glenn Morris <rgm@gnu.org>
1308 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1310 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1311 Update template values to be closer to their typical values these days.
1313 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1315 * xdisp.c (rows_from_pos_range): Accept additional argument
1316 DISP_STRING, and accept any glyph in a row whose object is that
1317 string as eligible for mouse highlight. Fixes mouse highlight of
1318 display strings from overlays. (Bug#10464)
1320 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1322 emacs: fix an auto-save permissions race condition (Bug#10400)
1323 * fileio.c (auto_saving_dir_umask): New static var.
1324 (Fmake_directory_internal): Use it.
1325 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1326 creating the directory. The old code temporarily assigns
1327 too-generous permissions to the directory.
1328 (do_auto_save_eh): Clear it.
1329 (Fdo_auto_save): Catch all errors, not just file errors, so
1330 that the var is always cleared.
1332 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1334 * search.c (scan_buffer): Pass character positions to
1335 know_region_cache, not byte positions. (Bug#6540)
1337 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1339 * w32.c (sys_rename): Report EXDEV when rename of a directory
1340 fails because the target is on another logical disk. (Bug#10284)
1342 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1344 * xterm.c (x_embed_request_focus): New function.
1346 * xterm.h: Add prototype.
1348 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1350 2012-01-05 Glenn Morris <rgm@gnu.org>
1352 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1354 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1356 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1357 Load gnutls_transport_set_lowat only if GnuTLS version is below
1359 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1360 GnuTLS versions below 2.11.1.
1362 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1364 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1365 to the doc string advising against its use for altering the way
1366 windows are scrolled.
1368 2011-12-28 Kenichi Handa <handa@m17n.org>
1370 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1371 coding-system ASCII compatible only when it does not produce BOM
1372 on encoding (Bug#10383).
1374 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1376 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1378 (create_and_show_popup_menu): Always use menu_position_func for
1381 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1383 * callint.c (Fcall_interactively): Don't truncate prompt string.
1385 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1387 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1388 property that ends at ZV, so that the bidi iteration could be
1389 resumed from there (after widening). (Bug#10360)
1391 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1393 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1395 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1397 * nsterm.m (x_free_frame_resources):
1398 Release f->output_data.ns->miniimage.
1399 (ns_index_color): Fix indentation. Do not retain
1400 color_table->colors[i].
1402 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1405 * nsfns.m (x_set_background_color): Assign return value from
1406 ns_index_color to face-background instead of NSColor*.
1407 (ns_implicitly_set_icon_type): Fix indentation.
1408 Change assignment in for loop to comparison.
1410 * emacs.c (ns_pool): New variable.
1411 (main): Assign ns_pool.
1412 (Fkill_emacs): Call ns_release_autorelease_pool.
1414 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1415 autorelease fdesc, release fdAttrs and tdict.
1416 (ns_get_covering_families): Release charset.
1417 (ns_findfonts): Release NSFontDescriptor created with new.
1418 (ns_uni_to_glyphs): Fix indentation.
1419 (setString): Release attrStr before assigning new value.
1421 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1423 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1425 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1426 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1428 2011-12-18 David Reitter <reitter@cmu.edu>
1430 * nsterm.m (ns_term_init): Subscribe for notifications
1431 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1432 to method trackingNotification in EmacsMenu.
1434 * nsmenu.m (trackingMenu): New variable.
1435 (trackingNotification): New method (from Aquamacs).
1436 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1437 from Aquamacs (Bug#7030).
1439 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1441 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1442 (symbol_to_nsstring): Fix indentation.
1443 (ns_symbol_to_pb): New function.
1444 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1445 (Fns_rotate_cut_buffers_internal): Remove.
1446 (Fns_store_selection_internal): Rename from
1447 Fns_store_cut_buffer_internal.
1448 (ns_get_foreign_selection, Fx_own_selection_internal)
1449 (Fx_disown_selection_internal, Fx_selection_exists_p)
1450 (Fns_get_selection_internal, Fns_store_selection_internal):
1451 Use ns_symbol_to_pb and check if return value is nil.
1452 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1453 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1454 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1455 renamed to Sns_store_selection_internal.
1456 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1457 and remove this function.
1458 (ns_handle_selection_clear): Remove, never used.
1459 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1462 2011-12-17 Ken Brown <kbrown@cornell.edu>
1464 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1465 GID is unknown (Bug#10257).
1467 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1469 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1470 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1471 which caused a build failure on GNU/Linux IA-64. This problem was
1472 introduced by my 2011-10-07 patch.
1474 2011-12-15 Juri Linkov <juri@jurta.org>
1476 * image.c (imagemagick_error): New function. (Bug#10112)
1477 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1478 Use `imagemagick_error' where ImageMagick functions return
1480 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1483 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1485 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1486 fill background (Bug#8992).
1488 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1490 * window.c (Vwindow_combination_resize)
1491 (Vwindow_combination_limit): Use t instead of non-nil in
1493 (Vrecenter_redisplay): Add first sentence of doc-string on
1495 (Frecenter): Fix doc-string typo.
1497 2011-12-11 Kenichi Handa <handa@m17n.org>
1499 * coding.c (Funencodable_char_position): Pay attention to the
1500 buffer text relocation (Bug#9389).
1502 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1504 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1505 gtk_init (Bug#10100).
1507 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1509 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1510 IT->string is nil. (Bug#10263)
1512 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1514 * nsterm.h (x_free_frame_resources): Declare.
1516 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1517 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1519 * nsterm.h (ns_get_defaults_value): Declare.
1521 * nsterm.m (ns_default): Call ns_get_defaults_value.
1523 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1525 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1528 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1530 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1531 that where the value of an _OBJC_* symbol points to is in the .bss
1532 section (Bug#10240).
1534 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1536 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1537 after the loop to call ccl_driver at least once (Bug#8619).
1539 2011-12-08 Kenichi Handa <handa@m17n.org>
1541 * ftfont.c (get_adstyle_property): Fix previous change
1544 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1546 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1547 dirs from the default value of EMACSLOADPATH (bug#10208).
1549 2011-12-07 Glenn Morris <rgm@gnu.org>
1551 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1552 installation and source directories as well. (Bug#10208)
1554 2011-12-06 Chong Yidong <cyd@gnu.org>
1556 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1558 2011-12-06 Glenn Morris <rgm@gnu.org>
1560 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1561 as an error, not just -1. (Bug#10217)
1563 2011-12-05 Chong Yidong <cyd@gnu.org>
1565 * keyboard.c (process_special_events): New function.
1566 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1568 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1570 * coding.c (encode_designation_at_bol): Don't use uninitialized
1571 local variable (Bug#9318).
1573 2011-12-05 Kenichi Handa <handa@m17n.org>
1575 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1576 return Qnil (Bug#8046, Bug#10193).
1578 2011-12-05 Kenichi Handa <handa@m17n.org>
1580 * coding.c (encode_designation_at_bol): New args charbuf_end and
1581 dst. Return the number of produced bytes. Callers changed.
1582 (coding_set_source): Return how many bytes coding->source was
1584 (coding_set_destination): Return how many bytes
1585 coding->destination was relocated.
1586 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1587 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1589 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1591 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1592 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1595 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1597 The following changes are to fix Bug#9318.
1599 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1600 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1601 (encode_coding_iso_2022, encode_coding_sjis)
1602 (encode_coding_big5, encode_coding_charset): Use the above macros.
1604 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1606 * lisp.h (process_quit_flag): Fix external declaration.
1608 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1610 Don't macro-inline non-performance-critical code.
1611 * eval.c (process_quit_flag): New function.
1612 * lisp.h (QUIT): Use it.
1614 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1616 * nsfns.m (get_geometry_from_preferences): New function.
1617 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1619 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1621 * emacs.c (Qkill_emacs): Define.
1622 (syms_of_emacs): Initialize it.
1623 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1624 Qquit_flag to `kill-emacs' instead.
1625 (quit_throw_to_read_char): Add parameter `from_signal'.
1626 All callers changed. Call Fkill_emacs if requested and safe.
1627 * lisp.h (QUIT): Call Fkill_emacs if requested.
1629 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1631 * widget.c (update_wm_hints): Return if wmshell is null.
1632 (widget_update_wm_size_hints): New function.
1634 * widget.h (widget_update_wm_size_hints): Declare.
1636 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1637 widget_update_wm_size_hints (Bug#10104).
1639 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1641 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1642 before a newline, prepare the bidi iterator for consuming the
1643 newline, and keep the current paragraph direction. (Bug#10183)
1644 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1646 2011-12-02 Juri Linkov <juri@jurta.org>
1648 * search.c (Fword_search_regexp): New Lisp function created from
1649 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1650 (Fword_search_backward, Fword_search_forward)
1651 (Fword_search_backward_lax, Fword_search_forward_lax):
1652 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1653 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1655 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1657 * fileio.c (Finsert_file_contents): Move after-change-function call
1658 to before the "handled:" label, since all "goto handled" appear in
1659 cases where the *-change-functions have already been properly called
1662 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1664 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1665 waiting for input. (Bug#10169)
1667 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1669 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1670 verifies glyph row's hash code--we have just reallocated the
1671 glyphs, so their contents can be complete garbage. (Bug#10164)
1673 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1675 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1677 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1679 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1680 attributes are tested _before_ calling verify_row_hash, to protect
1681 against GCC re-ordering of the tests. (Bug#10164)
1683 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1685 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1687 * xterm.c (handle_one_xevent): Only set async_visible and friends
1688 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1689 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1690 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1692 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1694 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1695 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1696 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1697 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1698 All uses changed to use GCPRO1 etc.
1699 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1700 Revert to old implementation (i.e., before 2011-03-11).
1702 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1704 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1705 of scroll runs so as to avoid assigning disabled bogus rows and
1706 unnecessary graphics copy operations.
1708 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1710 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1711 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1712 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1713 (malloc, free, realloc, calloc): Redirect to e_* only when
1716 * lisp.h (GCTYPEBITS): Move before first use.
1717 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1718 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1719 this macro definition.
1721 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1724 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1726 * gtkutil.c (xg_create_frame_widgets):
1727 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1728 present with Gtk+ 2.0.
1730 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1732 * fileio.c (Finsert_file_contents): Undo previous change; see
1733 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1735 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1737 Rename locals to avoid shadowing.
1738 * fileio.c (Finsert_file_contents):
1739 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1740 * process.c (wait_reading_process_output):
1741 Rename inner 'proc' to 'p' to avoid shadowing.
1742 Indent for consistency with usual Emacs style.
1744 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1746 * xdisp.c (redisplay_window): If cursor row is not fully visible
1747 after recentering, and scroll-conservatively is set to a large
1748 number, scroll window by a few more lines to make the cursor fully
1749 visible and out of scroll-margin. (Bug#10105)
1750 (start_display): Don't move to the next line if the display should
1751 start at a newline that is part of a display vector or an overlay
1754 2011-11-24 Juri Linkov <juri@jurta.org>
1756 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1757 after the `MagickPingImage' call. (Bug#10112)
1759 2011-11-23 Chong Yidong <cyd@gnu.org>
1761 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1763 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1765 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1766 making another buffer current. (Bug#10114)
1768 2011-11-23 Glenn Morris <rgm@gnu.org>
1770 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1772 2011-11-23 Chong Yidong <cyd@gnu.org>
1774 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1775 using it (Bug#5984).
1777 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1779 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1780 and header-lines, as they don't have one computed for them.
1783 * .gdbinit (prow): Make displayed values more self-explaining.
1784 Add row's hash code.
1786 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1788 * process.c (wait_reading_process_output): Fix asynchrounous
1789 GnuTLS socket handling on some versions of the GnuTLS library.
1790 (wait_reading_process_output): Add comment and URL.
1792 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1794 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1796 2011-11-21 Chong Yidong <cyd@gnu.org>
1798 * window.c (Fnext_window, Fprevious_window): Doc fix.
1800 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1802 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1804 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1806 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1808 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1810 * window.c (Fset_window_combination_limit): Rename argument
1812 (Vwindow_combination_limit): Remove "status" from doc-string.
1814 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1816 * m/ibms390.h: Remove.
1817 * m/ibms390x.h: Don't include "ibms390.h".
1819 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1821 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1822 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1824 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1826 * casetab.c (Fset_case_table):
1827 * charset.c (Fcharset_after): Fix typos.
1829 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1831 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1832 Otherwise, valgrind does not work on some platforms.
1833 Problem reported by Andreas Schwab in
1834 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1835 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1836 is set, removing the need for VIRT_ADDRESS_VARIES.
1837 (PURE_P): Use a more-efficient implementation that needs just one
1838 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1839 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1840 to 4 (xorl, subq, cmpq, setbe).
1841 * alloc.c (pure): Always extern now, since that's the
1842 VIRT_ADDR_VARIES behavior.
1843 (PURE_POINTER_P): Use a single comparison, not two, for
1844 consistency with the new puresize.h.
1845 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1846 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1847 Remove VIRT_ADDR_VARIES no longer needed.
1849 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1851 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1852 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1853 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1854 behave as if the cursor position were at the window margin.
1856 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1857 and the cursor position is out of bounds, behave as if the cursor
1858 position were at the window margin. (Bug#10075)
1860 2011-11-18 Chong Yidong <cyd@gnu.org>
1862 * window.c (Fwindow_combination_limit): Make first argument
1863 non-optional, since it is meaningless for live windows like the
1866 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1868 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1870 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1872 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1873 (graft_intervals_into_buffer): Simplify.
1875 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1877 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1878 hash values of the two rows.
1879 (copy_row_except_pointers): Preserve the used[] arrays and the
1880 hash values of the two rows. (Bug#10035)
1881 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1883 * xdisp.c (row_hash): New function, body extracted from
1884 compute_line_metrics.
1885 (compute_line_metrics): Call row_hash, instead of computing the
1888 * dispnew.c (verify_row_hash): Call row_hash for computing the
1889 hash code of a row, instead of duplicating code from xdisp.c.
1891 * dispextern.h (row_hash): Add prototype.
1893 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1895 * frame.c (delete_frame): Don't delete the terminal when the last
1896 X frame is closed if emacs is built with GTK toolkit.
1898 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1900 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1902 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1904 * window.c (Vwindow_splits): Rename to
1905 Vwindow_combination_resize. Suggested by Juri Linkov.
1906 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1909 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1911 * nsfns.m (Fns_font_name):
1912 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1914 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1916 * window.h (window): Rename slot "nest" to "combination_limit".
1917 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1918 (Fset_window_nest): Rename to Fset_window_combination_limit.
1919 (Vwindow_nest): Rename to Vwindow_combination_limit.
1920 (recombine_windows, make_parent_window, make_window)
1921 (Fsplit_window_internal, saved_window)
1922 (Fset_window_configuration, save_window_save): Rename all
1923 occurrences of window_nest to window_combination_limit.
1925 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1927 * image.c (imagemagick_load_image): Fix typo.
1929 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1931 * xdisp.c (display_line): Move the call to
1932 highlight_trailing_whitespace before the call to
1933 compute_line_metrics, since the latter needs to see the final
1934 faces of all the glyphs to compute ROW's hash value.
1935 Fixes assertion violations in row_equal_p. (Bug#10035)
1937 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1939 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1940 just return (bug#10044).
1942 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1944 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1945 with user-defined heap size. Bump the default size of the temacs
1946 heap to 27MB, to avoid memory warning when running temacs.
1947 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1949 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1950 current_matrix and desired_matrix. (Bug#9990)
1951 (verify_row_hash) [XASSERTS]: New function.
1952 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1953 that the hash value of glyph rows is correct.
1955 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1957 * window.h (window): Remove splits slot.
1958 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1959 (Fdelete_other_windows_internal, make_parent_window)
1960 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1961 (Fset_window_configuration, save_window_save): Don't deal with
1962 split status of windows.
1963 (saved_window): Remove splits slot.
1964 (Vwindow_splits): Rewrite doc-string.
1966 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1968 * xfns.c (unwind_create_frame):
1969 * nsfns.m (unwind_create_frame):
1970 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1971 Vframe_list (Bug#9999).
1973 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1975 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1977 2011-11-11 Kenichi Handa <handa@m17n.org>
1979 * callproc.c (Fcall_process): Set the member dst_multibyte of
1982 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1984 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1985 avoid a crash (bug#9496).
1987 2011-11-09 Chong Yidong <cyd@gnu.org>
1989 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1990 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1992 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1994 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1996 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1998 Avoid some portability problems by eschewing 'extern inline' functions.
1999 The trivial performance wins aren't worth the portability hassles; see
2000 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2002 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2003 (window_box_width, window_box_left, window_box_left_offset)
2004 (window_box_right, window_box_right_offset): Undo previous change,
2005 by removing the "extern"s.
2006 * intervals.c (adjust_intervals_for_insertion)
2007 (adjust_intervals_for_deletion): Undo previous change,
2008 making these static again.
2009 (offset_intervals, temp_set_point_both, temp_set_point)
2010 (copy_intervals_to_string): No longer inline.
2011 * xdisp.c (window_text_bottom_y, window_box_width)
2012 (window_box_height, window_box_left_offset)
2013 (window_box_right_offset, window_box_left, window_box_right)
2014 (window_box): No longer inline.
2016 2011-11-08 Chong Yidong <cyd@gnu.org>
2018 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2019 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2020 Signal an error if not a live window.
2021 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2022 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2024 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2026 * lisp.h (syms_of_abbrev): Remove declaration.
2027 Reported by CHENG Gao <chenggao@royau.me>.
2029 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2031 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2032 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2033 of temacs in GUI mode.
2035 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2037 * window.h: Declare delete_all_child_windows instead of
2038 delete_all_subwindows.
2039 * window.c (Fwindow_nest, Fset_window_nest)
2040 (Fset_window_new_total, Fset_window_new_normal)
2041 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2042 (delete_all_subwindows): Rename to delete_all_child_windows.
2043 (Fdelete_other_windows_internal, Fset_window_configuration):
2044 Call delete_all_child_windows instead of delete_all_subwindows.
2045 * frame.c (delete_frame): Call delete_all_child_windows instead
2046 of delete_all_subwindows.
2048 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2050 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2051 This is also needed for porting to any host where GC_MARK_STACK is
2052 not GC_MAKE_GCPROS_NOOPS.
2053 (which_symbols): Use it.
2055 2011-11-07 Kenichi Handa <handa@m17n.org>
2057 * coding.c (coding_set_destination): Check coding->src_pos only
2058 when coding->src_object is a buffer (bug#9910).
2060 * process.c (send_process): Set the member src_multibyte of coding
2061 to 0 (bug#9911) when sending a unibyte text.
2063 * callproc.c (Fcall_process): Set the member src_multibyte of
2064 process_coding to 0 (bug#9912).
2066 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2068 * xmenu.c (cleanup_widget_value_tree): New function.
2069 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2070 calling free_menubar_widget_value_tree directly (Bug#9830).
2072 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2074 Fix some portability problems with 'inline'.
2075 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2076 (window_box_width, window_box_left, window_box_left_offset)
2077 (window_box_right, window_box_right_offset): Declare extern.
2078 Otherwise, these inline functions do not conform to C99 and
2079 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2080 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2081 * intervals.c (adjust_intervals_for_insertion)
2082 (adjust_intervals_for_deletion): Now extern, because otherwise the
2083 extern inline functions 'offset_intervals' couldn't refer to it.
2084 (static_offset_intervals): Remove.
2085 (offset_intervals): Rewrite using the old contents of
2086 static_offset_intervals. The old version didn't conform to C99
2087 because an extern inline function contained a reference to an
2088 identifier with static linkage.
2090 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2092 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2095 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2097 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2098 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2099 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2100 return Qleft_to_right.
2102 2011-11-06 Chong Yidong <cyd@gnu.org>
2104 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2105 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2106 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2107 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2108 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2109 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2110 (Fwindow_vscroll): Doc fix.
2111 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2112 argument, since it makes no sense to pass a live window and for
2113 consistency with window-child.
2115 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2117 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2120 2011-11-05 Jason Rumney <jasonr@gnu.org>
2122 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2123 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2125 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2126 bitwise arithmetic preventing use of unicode-sip and non-truetype
2129 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2131 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2134 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2135 initialization code to keep similarity to xfns.c after changes
2138 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2140 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2141 (unwind_create_frame): New function (Bug#9943).
2142 (Fx_create_frame): Restructure code to be more similar to the one in
2143 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2144 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2145 Move terminal->reference_count++ just before making the frame official
2148 * nsterm.m (x_free_frame_resources): New function.
2149 (x_destroy_window): Move code to x_free_frame_resources.
2151 * xfns.c (unwind_create_frame): Fix comment.
2152 (Fx_create_frame, x_create_tip_frame):
2153 Move terminal->reference_count++ just before making the frame
2154 official. Move initialization of image_cache_refcount and
2155 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2157 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2159 Support MSVC build with newer versions of Visual Studio.
2160 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2161 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2164 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2165 which are not supported by MSVC.
2166 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2167 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2169 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2171 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2173 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2175 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2177 Support MSVC build with newer versions of Visual Studio.
2178 * w32.c: Don't include w32api.h for MSVC.
2179 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2181 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2182 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2183 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2184 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2186 (alloca) [_MSC_VER]: Define to _alloca.
2188 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2190 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2192 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2194 * xdisp.c (note_mouse_highlight): If either of
2195 previous/next-single-property-change returns nil, treat that as
2196 the beginning or the end of the buffer. (Bug#9955)
2198 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2200 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2201 label is not null (Bug#9951).
2202 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2205 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2207 * window.c (Fwindow_body_size): Mention in the doc string that the
2208 return value is in frame's canonical units. (Bug#9949)
2210 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2212 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2214 * w32fns.c (unwind_create_frame): If needed, free the glyph
2215 matrices of the partially constructed frame. (Bug#9943)
2216 * xfns.c (unwind_create_frame): Likewise.
2218 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2220 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2221 Don't stop backward scan on the continuation glyph, even though
2222 its CHARPOS is positive.
2223 (mouse_face_from_buffer_pos, note_mouse_highlight):
2224 Rename cover_string to disp_string.
2226 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2228 * window.c (temp_output_buffer_show): Don't use
2229 Vtemp_buffer_show_specifiers.
2230 (Vtemp_buffer_show_specifiers): Remove unused variable.
2232 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2234 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2235 past the beginning of the current glyph matrix.
2237 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2239 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2240 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2241 HAVE_GTK3 (Bug#9869).
2243 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2244 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2246 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2248 * xterm.c: Declare x_handle_net_wm_state to return int.
2249 (handle_one_xevent): Check if we are iconified but don't have
2250 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2251 (get_current_wm_state): Return non-zero if not hidden,
2252 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2253 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2254 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2255 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2257 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2259 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2260 so that this new function doesn't get optimized away by a
2261 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2263 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2265 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2267 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2269 Fix the `xbytecode' command.
2270 * .gdbinit (xprintbytestr): New command.
2271 (xwhichsymbols): Rename from `which'; all callers changed.
2272 (xbytecode): Print the byte-code string as well.
2274 2011-10-29 Kim Storm <storm@cua.dk>
2276 * alloc.c (which_symbols): New function.
2278 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2280 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2283 2011-10-29 Glenn Morris <rgm@gnu.org>
2285 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2286 Not clear what it was for, and it causes various bugs. (Bug#9839)
2288 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2290 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2291 possible random value that matches one of those tested as
2292 condition to clear the mouse face.
2294 2011-10-28 Chong Yidong <cyd@gnu.org>
2296 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2298 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2300 * window.c (make_window): Initialize phys_cursor_on_p.
2302 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2304 * lisp.h (struct Lisp_Symbol): Update comments.
2306 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2308 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2310 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2312 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2313 <oslsachem@gmail.com> for helping to debug this.
2315 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2316 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2317 (g_b_init_get_glyph_outline_w): New static variables.
2318 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2319 (GetGlyphOutlineW_Proc): New typedefs.
2320 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2321 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2323 (w32font_open_internal, compute_metrics):
2324 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2325 instead of calling the "wide" APIs directly.
2327 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2329 * w32.h (syms_of_w32font): Add prototype.
2331 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2333 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2334 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2335 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2336 (Fmove_to_window_line): Doc fix.
2338 2011-10-27 Chong Yidong <cyd@gnu.org>
2340 * process.c (make_process): Set gnutls_state to NULL.
2342 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2343 non-NULL, regardless of GNUTLS_INITSTAGE.
2344 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2345 an error. Set process slots as soon as we allocate them.
2347 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2349 2011-10-27 Chong Yidong <cyd@gnu.org>
2351 * gnutls.c (emacs_gnutls_deinit): New function.
2352 Deallocate credentials structures as well as calling gnutls_deinit.
2353 (Fgnutls_deinit, Fgnutls_boot): Use it.
2355 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2356 (deactivate_process): Call emacs_gnutls_deinit.
2358 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2360 * image.c (x_create_x_image_and_pixmap):
2361 * w32.c (sys_rename, w32_delayed_load):
2362 * w32font.c (fill_in_logfont):
2363 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2365 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2367 * w32fns.c (w32_default_color_map): New function,
2368 extracted from Fw32_default_color_map.
2369 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2371 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2373 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2375 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2377 * keyboard.c (test_undefined): New function (bug#9751).
2378 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2380 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2382 * sysdep.c (init_sys_modes): Fix the check for the controlling
2383 terminal (Bug#6649).
2385 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2387 * dispextern.h (struct bidi_it): New member next_en_type.
2389 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2390 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2391 current character, check also for next_en_type being WEAK_EN.
2392 (bidi_resolve_weak): Don't enter the expensive loop if the current
2393 position is before next_en_pos. Record the bidi type of the first
2394 non-ET, non-BN character we find, in addition to its position.
2395 (bidi_level_of_next_char): Invalidate next_en_type when
2396 next_en_pos is over-stepped.
2398 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2400 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2401 * editfns.c: Rewrite current-time-zone so that it invokes
2402 the equivalent of (format-time-string "%Z") to get the time zone name.
2403 This fixes a bug when the time zone name contains characters that
2404 need converting from the system time locale to Emacs internal format.
2405 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2406 that patch fixed format-time-string to do the conversion, but
2407 I forgot to fix current-time-zone.
2408 (format_time_string): New function, containing most of
2409 what Fformat_time_string used to contain.
2410 (Fformat_time_string): Rewrite in terms of format_time_string.
2411 This doesn't change this function's behavior.
2412 (current-time-zone): Rewrite to use format_time_string.
2413 This fixes the bug reported by Michael Schierl in
2414 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2415 Jason Rumney's 2007-06-07 change worked around this bug, but
2417 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2419 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2421 * xdisp.c (start_display): If the character at POS is displayed
2422 via a display vector, reset IT->current.dpvec_index to zero.
2423 (try_window_reusing_current_matrix): If a line ends in a display
2424 vector or the next line starts in a display vector, continue
2425 redrawing the window even though the character position of
2426 start_row was reached.
2429 2011-10-18 Chong Yidong <cyd@gnu.org>
2431 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2432 with nobreak-char-display too.
2434 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2436 Fix part 3 of bug#9771.
2437 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2438 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2439 non-neutral characters if the current character is a paragraph
2440 separator (a.k.a. Newline). This avoids running the same
2441 expensive loop twice, once when we consume the preceding newline
2442 and the other time when the line actually needs to be displayed.
2443 Avoid the loop when we see neutrals on the base embedding level
2444 following a character whose directionality is the same as the
2445 paragraph's. This avoids running the expensive loop when a line
2446 ends in a long sequence of neutrals, like control characters.
2447 Add assertion against STRONG_AL type. Slightly rearrange code
2448 that determines the type of a neutral given the first non-neutral
2450 (bidi_level_of_next_char): Set next_en_pos to zero when
2451 invalidating its info.
2453 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2455 * xdisp.c (push_display_prop): Determine whether to record string
2456 or buffer position by IT->string, not by IT->method. Allow
2457 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2458 (move_it_vertically_backward): Don't look for character position
2459 immediately after the newline when in a continuation line.
2462 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2464 * window.c (coordinates_in_window): Rewrite and delabelize
2465 vertical border check. (Bug#5357) (Bug#9618)
2467 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2469 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2470 errors in XSetWindowBorder (bug#9310).
2472 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2474 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2475 avoid crash when xmalloc overrun checking is enabled.
2477 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2479 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2480 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2481 cursor motion with <left> and <right> arrow keys.
2483 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2484 some callers set that themselves.
2486 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2488 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2489 display string and the previous row comes from the same string and
2490 is empty. (Bug#9739) (Bug#9738)
2492 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2494 * doc.c (get_doc_string): Encode file name (bug#9735).
2496 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2498 * bidi.c (bidi_level_of_next_char):
2499 * xdisp.c (get_visually_first_element): Remove old incorrect
2500 comments regarding the Unicode Line Separator character.
2502 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2504 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2506 * alloc.c (Fgc_status): Do not access beyond zombies array
2507 boundary if nzombies > MAX_ZOMBIES.
2508 * alloc.c (dump_zombies): Add missing format specifier.
2510 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2512 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2513 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2515 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2516 Some packages use them to denote characters with modifiers.
2518 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2520 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2521 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2522 matching a pp-number. Rename parameter var to var1.
2524 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2526 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2528 2011-10-08 Glenn Morris <rgm@gnu.org>
2530 * callint.c (Fcall_interactively): Give a more explicit error for the
2531 'c' case with a non-character input. (Bug#8479)
2533 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2535 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2537 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2538 lines that are hscrolled on the left.
2540 * dispnew.c (buffer_posn_from_coords): Account for a possible
2541 presence of header-line. (Bug#4426)
2543 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2545 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2546 Don't advertise functionality which we discourage or doesn't work.
2548 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2550 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2551 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2552 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2553 this makes Emacs dump core during garbage collection on rare
2554 occasions. sizeof is obviously inferior to offsetof here, so
2555 stick with offsetof.
2556 (GC_POINTER_ALIGNMENT): New macro.
2557 (mark_memory): Omit 3rd (offset) arg; caller changed.
2558 Don't assume EMACS_INT alignment is the same as pointer alignment.
2560 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2562 * keyboard.c (read_key_sequence_remapped): New var.
2563 (read_key_sequence): Compute remapping in the right buffer.
2564 (command_loop_1): Use read_key_sequence's remapping directly.
2566 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2568 * dired.c (file_name_completion): Don't expand file name.
2569 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2570 before checking file name handler.
2572 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2573 they've been requested explicitly (bug#9591).
2575 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2577 * keymap.c (Fsingle_key_description): Use make_specified_string
2578 instead of build_string to build string from push_key_description.
2581 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2583 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2584 This fixes a Y2038 bug on 64-bit hosts.
2585 * buffer.c (reset_buffer):
2586 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2587 (Fclear_buffer_auto_save_failure):
2588 Use 0, not -1, to represent an unset failure time, since time_t
2589 might not be signed.
2591 Remove dependency on glibc malloc internals.
2592 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2593 Move back here from lisp.h, but with their new implementations.
2594 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2595 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2596 * charset.c (charset_table_init): New static var.
2597 (syms_of_charset): Use it instead of xmalloc. This removes a
2598 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2599 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2600 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2601 Move back to alloc.c.
2602 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2603 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2605 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2607 * nsterm.m (windowDidResize): Call x_set_window_size only when
2608 ns_in_resize is true. Otherwise set pixelwidth/height and
2609 call change_frame_size (Bug#9628).
2611 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2613 Port --enable-checking=all to Fedora 14 x86-64.
2614 * charset.c (syms_of_charset): Also account for glibc malloc's
2615 internal overhead when calculating the initial malloc maximum.
2617 Port --enable-checking=all to Fedora 14 x86.
2618 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2620 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2621 (overrun_check_realloc, overrun_check_free):
2622 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2623 That way, xmalloc returns a properly-aligned pointer even if
2624 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2625 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2626 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2627 into account when calculating the initial malloc maximum.
2628 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2629 Move here from alloc.c, so that charset.c can use it too.
2630 Properly align; the old code wasn't right for common 32-bit hosts
2631 when configured with --enable-checking=all.
2632 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2633 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2635 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2637 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2640 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2642 * xdisp.c (compute_display_string_end): If there's no display
2643 string at CHARPOS, return -1.
2645 * bidi.c (bidi_fetch_char): When compute_display_string_end
2646 returns a negative value, treat the character as a normal
2647 character not covered by a display string. (Bug#9624)
2649 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2651 * lread.c (Fread_from_string): Fix typo in docstring.
2653 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2655 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2656 newline, reseat the iterator instead of bidi-iterating there one
2657 character at a time. (Bug#9610)
2658 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2659 TO_CHARPOS if the bidi iterator is at base embedding level.
2661 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2663 * lread.c (readevalloop): Use correct code for NBSP.
2664 (read1): Likewise. (Bug#9608)
2666 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2668 * dbusbind.c (Fdbus_register_signal): When service is not
2669 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2671 2011-09-25 Glenn Morris <rgm@gnu.org>
2673 * buffer.c (truncate-lines): Doc fix.
2675 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2677 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2678 (Fset_window_next_buffers): Doc fix.
2680 2011-09-24 Glenn Morris <rgm@gnu.org>
2682 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2684 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2686 Fix minor problems found by static checking.
2687 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2688 * indent.c (Fvertical_motion): Fix == vs = typo.
2690 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2692 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2693 Default value is now t. Doc fix.
2695 * indent.c (Fvertical_motion): Compute and apply the overshoot
2696 logic when moving up, not only when moving down. Fix the
2697 confusing name and values of the it_overshoot_expected variable;
2698 logic changes accordingly. (Bug#9254) (Bug#9549)
2700 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2701 CHARPOS is covered by a display string which includes newlines.
2702 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2703 is covered by a display string with embedded newlines.
2705 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2707 * dbusbind.c (Fdbus_register_signal): Add match rule to
2708 Vdbus_registered_objects_table. (Bug#9581)
2709 (Fdbus_register_method, Vdbus_registered_objects_table):
2712 2011-09-24 Jim Meyering <meyering@redhat.com>
2714 do not ignore write error for any output size
2715 The previous change was incomplete.
2716 While it makes emacs --batch detect the vast majority of stdout
2717 write failures, errors were still ignored whenever the output size is
2718 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2719 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2720 && echo FAIL: ignored write error
2721 FAIL: ignored write error
2722 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2723 && echo FAIL: ignored write error
2724 FAIL: ignored write error
2725 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2727 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2729 * emacs.c (Fkill_emacs): In noninteractive mode exit
2730 non-successfully if a write error occurred on stdout. (Bug#9574)
2732 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2734 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2737 * dispextern.h (struct it): Update the comment documenting what
2740 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2742 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2743 a display string, extend search for cursor position to end of row.
2744 (find_row_edges): If the row ends in a newline from a display
2745 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2746 Handle the case of a display string with multiple newlines.
2747 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2748 non-empty line. Fixes confusing cursor motion with arrow keys at
2749 the beginning of a line that starts with whitespace.
2751 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2753 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2756 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2758 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2761 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2763 * xdisp.c (display_line): Record maximum and minimum buffer
2764 positions even if no glyphs were produced (e.g., by a zero-width
2765 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2766 buffer positions that will be removed from the glyph row because
2768 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2769 column is beyond frame width: don't subtract 1 "pixel" when
2770 computing width of the stretch.
2771 (reseat_at_next_visible_line_start): Undo the change made on
2772 2011-09-17 that saved paragraph information and restored it after
2773 the call to `reseat'. (Bug#9545)
2775 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2777 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2778 and turn window cursor on if cleared (Bug#9415).
2780 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2782 * search.c (boyer_moore): Take unibyte characters from pattern
2783 literally. (Bug#9458)
2785 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2787 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2789 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2791 Fix minor problem found by static checking.
2792 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2793 initialized, to pacify gcc -Wuninitialized.
2795 * fileio.c: Report proper errno when syscall falls.
2796 (Finsert_file_contents): Save and restore errno,
2797 so that report_file_error outputs the correct diagnostic.
2798 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2800 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2802 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2804 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2806 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2807 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2809 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2811 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2812 about the current paragraph and restore it after the call to reseat.
2814 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2815 (bidi_find_paragraph_start): Search back for paragraph beginning
2816 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2817 (bidi_move_to_visually_next): Only trigger paragraph-related
2818 computations when the last character is a newline or at EOB, not
2819 just any NEUTRAL_B. (Bug#9470)
2821 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2822 truncated lines if point is covered by a display string. (Bug#9524)
2824 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2826 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2827 (cons_to_x_long): New function.
2828 (lisp_data_to_selection_data): Use it. Correct the test for
2829 short-versus-long data; it was negated. Break out of vector
2830 loop, for efficiency, when a long datum is discovered.
2832 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2834 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2836 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2838 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2839 GCC PR/17406) by declaring this function with external scope.
2841 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2843 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2844 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2846 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2848 * editfns.c (Fformat): Correctly handle text properties on "%%".
2850 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2852 * xterm.c (x_draw_composite_glyph_string_foreground):
2853 * w32term.c (x_draw_composite_glyph_string_foreground):
2854 * term.c (encode_terminal_code):
2855 * composite.c (composition_update_it, get_composition_id):
2856 * xdisp.c (get_next_display_element)
2857 (fill_composite_glyph_string): Add comments about special meaning
2858 of TAB characters in a composition.
2860 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2862 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2863 This occurs when processing a multibyte format.
2864 Problem reported by Wolfgang Jenker.
2866 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2868 * xdisp.c (try_cursor_movement): Only check for exact match if
2869 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2871 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2873 Remove unused external symbols.
2874 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2875 * xdisp.c (calc_pixel_width_or_height): Now static.
2876 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2877 * indent.c (check_display_width):
2878 * w32term.c: Fix comment to match code.
2879 * xterm.c, xterm.h (x_catching_errors): Remove.
2881 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2883 * xselect.c: Use signed conversions more consistently (Bug#9498).
2884 (selection_data_to_lisp_data): Assume incoming selection data are
2885 signed integers, not unsigned. This is to be consistent with
2886 outgoing selection data, which was modified to use signed integers
2887 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2888 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2889 expects long, not unsigned long.
2891 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2893 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2894 computation of loop end. Reported by Johan Bockgård
2897 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2899 * frame.c (Fother_visible_frames_p): Function deleted.
2901 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2903 * indent.c (compute_motion): Process display vector front to back
2904 rather than the other way around. (Bug#2496)
2906 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2908 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2910 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2912 * minibuf.c (Fread_from_minibuffer): Doc fix.
2914 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2916 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2917 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2919 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2921 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2922 value for non-existent files.
2924 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2926 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2927 set its "size" to -1. This will set the modtime_size field of
2928 the corresponding buffer to -1, which is what
2929 verify-visited-file-modtime expects for files that do not exist.
2932 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2934 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2936 * lisp.h: ... from here. push_key_description is no longer
2937 defined in keyboard.c, so its declaration should not be in
2938 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2939 logically belongs with push_key_description.
2941 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2943 * buffer.h: Include <sys/types.h> instead of <time.h>.
2944 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2945 Problem reported by Herbert J. Skuhra.
2947 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2949 * xml.c (parse_region): Make the parsing work for
2950 non-comment-starting XML files again (bug#9144).
2952 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2954 * image.c (gif_load): Fix calculation of bottom and right corner.
2957 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2959 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2960 redisplay in small windows.
2962 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2964 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2966 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2968 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2969 Operate on live windows only.
2971 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2973 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2975 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2977 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2978 only under bidi iteration.
2980 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2982 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2984 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2986 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2987 Without this fix, the command to link temacs failed due to an
2988 undefined symbol __builtin_isnan. This is because
2989 /usr/include/iso/math_c99.h #defines isnan(x) to
2990 __builtin_isnan(x), but the bundled gcc, which identifies itself
2991 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2993 * floatfns.c (isnan): #undef, and then #define to a clone of
2995 (Fisnan): Always define, since it's always available now.
2996 (syms_of_floatfns): Always define isnan at the Lisp level.
2998 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3000 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3002 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3004 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3005 The previous code assumed that file offsets (off_t values) fit in
3006 EMACS_INT variables, which is not true on typical 32-bit hosts.
3007 The code messed up by falsely reporting buffer overflow in cases
3008 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3009 when "big" contains more than 2**29 bytes, even though this
3010 inserts just one byte and does not overflow the buffer.
3011 (Finsert_file_contents): Store file offsets as off_t
3012 values, not as EMACS_INT values. Check for overflow when
3013 converting between EMACS_INT and off_t. When checking for
3014 buffer overflow or for overlap, take the offsets into account.
3015 Don't use EMACS_INT for small values where int suffices.
3016 When checking for overlap, fix a typo: ZV was used where
3017 ZV_BYTE was intended.
3018 (Fwrite_region): Don't assume off_t fits into 'long'.
3019 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3021 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3023 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3025 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3027 sprintf-related integer and memory overflow issues (Bug#9412).
3029 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3030 (esprintf, exprintf, evxprintf): New functions.
3031 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3032 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3033 (modify_event_symbol): Do not assume that the length of
3034 name_alist_or_stem is safe to alloca and fits in int.
3035 (Fexecute_extended_command): Likewise for function name and binding.
3036 (Frecursion_depth): Wrap around reliably on integer overflow.
3037 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3038 since some callers pass EMACS_INT values.
3039 (Fsingle_key_description): Don't crash if symbol name contains more
3040 than MAX_ALLOCA bytes.
3041 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3042 (get_minibuffer): Arg is now EMACS_INT, not int.
3043 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
3044 (esprintf, exprintf, evxprintf): New decls.
3045 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3047 * dbusbind.c (signature_cat): New function.
3048 (xd_signature, Fdbus_register_signal):
3049 Do not overrun buffer; instead, report string overflow.
3051 * dispnew.c (add_window_display_history): Don't overrun buffer.
3052 Truncate instead; this is OK since it's just a log.
3054 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3055 even if the time zone offset is outlandishly large.
3056 Don't mishandle offset == INT_MIN.
3058 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3059 when creating daemon; the previous buffer-overflow check was incorrect.
3061 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3062 which has the guts of the old verror function.
3064 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3065 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3067 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3068 (font_unparse_xlfd): Don't blindly alloca long strings.
3069 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3070 fits in int, when using sprintf. Use single snprintf to count
3071 length of string rather than counting it via multiple sprintfs;
3072 that's simpler and more reliable.
3073 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3074 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3075 sprintf, in case result does not fit in int.
3077 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3078 (fontset_from_font): Print it.
3080 * frame.c (tty_frame_count): Now printmax_t, not int.
3081 (make_terminal_frame, set_term_frame_name): Print it.
3082 (x_report_frame_params): In X, window IDs are unsigned long,
3083 not signed long, so print them as unsigned.
3084 (validate_x_resource_name): Check for implausibly long names,
3085 and don't assume name length fits in 'int'.
3086 (x_get_resource_string): Don't blindly alloca invocation name;
3087 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3090 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3091 (xg_check_special_colors, xg_set_geometry):
3092 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3094 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3095 Use esprintf, not sprintf, in case result does not fit in int.
3097 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3098 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3099 it as a large positive number.
3100 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3101 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3103 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3104 in case result does not fit in int.
3106 * print.c (float_to_string): Detect width overflow more reliably.
3107 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3108 buffer overrun. Don't assume list length fits in 'int'. Treat
3109 print length of 0 as 0, not as infinity; to be consistent with other
3110 uses of print length in this function. Don't overflow print length
3111 index. Don't assume hash table size fits in 'long', or that
3112 vectorlike size fits in 'unsigned long'.
3114 * process.c (make_process): Use printmax_t, not int, to format
3115 process-name gensyms.
3117 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3119 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3120 to avoid potential buffer overrun.
3122 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3123 if X resource line is longer than 512 bytes.
3125 * xfns.c (x_window): Make sprintf buffer a bit bigger
3126 to avoid potential buffer overrun.
3128 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3130 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3132 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3134 Integer overflow fixes for scrolling, etc.
3135 Without these, Emacs silently mishandles large integers sometimes.
3136 For example, "C-u 4294967297 M-x recenter" was treated as if
3137 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3139 * xdisp.c (try_window_id): Check Emacs fixnum range before
3140 converting to 'int'.
3142 * window.c (window_scroll_line_based, Frecenter):
3143 Check that an Emacs fixnum is in range before assigning it to 'int'.
3144 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3145 values converted from Emacs fixnums.
3146 (Frecenter): Don't wrap around a line count if it is out of 'int'
3147 range; instead, treat it as an extreme value.
3148 (Fset_window_configuration, compare_window_configurations):
3149 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3151 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3152 that can exceed INT_MAX. Check that EMACS_INT value is in range
3153 before assigning it to the (possibly-narrower) index.
3154 (match_limit): Don't assume that a fixnum can fit in 'int'.
3156 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3159 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3160 (Fvertical_motion): Don't wrap around LINES values that don't fit
3161 in 'int'. Instead, treat them as extreme values. This is good
3162 enough for windows, which can't have more than INT_MAX lines anyway.
3164 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3166 * Require libxml/parser.h to avoid compilation warning.
3168 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3170 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3171 since this reportedly can destroy thread storage.
3173 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3175 * syntax.c (find_defun_start): Update all cache variables if
3176 exiting early (Bug#9401).
3178 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3180 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3182 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3183 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3184 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3186 * term.c (tty_append_glyph): New function.
3187 (produce_stretch_glyph): Static function and its prototype deleted.
3189 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3192 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3194 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3195 when checking :margin (Bug#9390).
3196 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3197 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3198 so that the name doesn't mislead. All uses changed.
3200 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3202 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3205 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3207 * xdisp.c (move_it_to): Don't bail out early when reaching
3208 position beyond to_charpos, if we are scanning backwards.
3209 (move_it_vertically_backward): When DY == 0, make sure we get to
3210 the first character in the line after the newline.
3212 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3214 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3215 (ccl_driver): Do not generate an out-of-range pointer.
3216 (Fccl_execute_on_string): Remove unnecessary check for
3217 integer overflow, noted by Stefan Monnier in
3218 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3219 Remove a FIXME that didn't need fixing.
3220 Simplify the newly-introduced buffer reallocation code.
3222 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3224 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3226 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3228 Integer and memory overflow issues (Bug#9196).
3230 * doc.c (get_doc_string): Rework so that
3231 get_doc_string_buffer_size is the actual buffer size, rather than
3232 being 1 less than the actual buffer size; this makes xpalloc more
3235 * image.c (x_allocate_bitmap_record, cache_image):
3236 * xselect.c (Fx_register_dnd_atom):
3237 Simplify previous changes by using xpalloc.
3239 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3240 since either will do and ptrdiff_t is convenient with xpalloc.
3242 * charset.c (charset_table_size)
3243 (struct charset_sort_data.priority): Now ptrdiff_t.
3244 (charset_compare): Don't overflow if priorities differ greatly.
3245 (Fsort_charsets): Don't assume list length fits in int.
3246 Check for size-calculation overflow when allocating sort data.
3247 (syms_of_charset): Allocate an initial charset table that is
3248 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3250 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3252 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3253 The actual value is always <= INT_MAX, and leaving it unsigned made
3254 overflow checking harder.
3256 * dispextern.h (struct glyph_matrix.rows_allocated)
3257 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3258 with xpalloc. The values are still always <= INT_MAX.
3260 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3262 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3263 (SAFE_NALLOCA): New macro.
3265 * region-cache.c (struct boundary.pos, find_cache_boundary)
3266 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3267 (set_cache_region, invalidate_region_cache)
3268 (revalidate_region_cache, know_region_cache, region_cache_forward)
3269 (region_cache_backward, pp_cache):
3270 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3271 so that ptrdiff_t * can be passed to xpalloc.
3272 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3273 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3274 (pp_cache): Don't assume cache_len fits in int.
3275 * region-cache.h: Adjust extern decls to match.
3277 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3278 EMACS_INT, since either will do, for xpalloc.
3280 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3281 (xnmalloc, xnrealloc, xpalloc): New functions.
3283 * bidi.c (bidi_shelve_header_size): New constant.
3284 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3285 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3287 * bidi.c (bidi_cache_shrink):
3288 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3290 Don't update size of array until after memory allocation succeeds,
3291 because xmalloc/xrealloc may not return.
3292 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3293 now that we have proper integer overflow checking.
3294 (record_overlay_string, overlay_strings): Catch overflows when
3295 calculating size of overlay_str_buf.
3297 * callproc.c (Fcall_process): Check for size overflow when
3298 calculating size of args2.
3299 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3300 Normally we prefer signed values, but sticking with ptrdiff_t would
3301 require adding more-complicated checks.
3303 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3304 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3305 Redo buffer-overflow calculations to avoid integer overflow.
3306 Add a FIXME comment where memory seems to be over-allocated.
3308 * character.c (Fstring): Check for size-calculation overflow.
3310 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3311 unnecessary integer overflow. Check for size overflow.
3312 (encode_coding_object): Don't update size until xmalloc succeeds.
3314 * composite.c (get_composition_id): Check for overflow in glyph
3315 length calculations.
3317 Integer and memory overflow fixes for display code.
3318 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3319 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3320 (scrolling_window): Check for overflow in size calculations.
3321 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3322 Don't assume glyph table len fits in int.
3323 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3324 (row_table_size): Now ptrdiff_t, not int.
3325 (scrolling_window): Avoid overflow in size calculations.
3326 Don't update size until allocation succeeds.
3327 * fns.c (concat): Check for overflow in size calculations.
3328 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3329 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3330 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3332 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3333 (get_doc_string): Check for size calculation overflow.
3334 Don't update size until allocation succeeds.
3335 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3336 EMACS_INT, where ptrdiff_t will do.
3337 (Fsubstitute_command_keys): Check for string overflow.
3339 * editfns.c (set_time_zone_rule): Don't assume environment length
3341 (message_length): Now ptrdiff_t, not int.
3342 (Fmessage_box): Don't update size until allocation succeeds.
3343 Don't assume message length fits in int.
3344 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3346 * emacs.c (main): Do not reallocate argv, since there is a null at
3347 the end that can be overwritten, and this way there's no need to
3348 worry about size-calculation overflow.
3349 (sort_args): Check for size-calculation overflow.
3351 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3353 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3355 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3356 (x_set_scroll_bar_width, x_figure_window_size):
3357 Check for integer overflow.
3358 (x_set_alpha): Do not assume XINT fits in int.
3360 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3361 This is for the members text_lines, text_cols, total_lines, total_cols,
3362 where the system imposes an 'int' limit.
3364 * fringe.c (Fdefine_fringe_bitmap):
3365 Don't update size until alloc works.
3367 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3368 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3370 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3371 Check for size-calculation overflow.
3372 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3373 do, as we prefer signed integers.
3374 (id_to_widget.max_size, id_to_widget.used)
3375 (xg_store_widget_in_map, xg_remove_widget_from_map)
3376 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3377 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3378 Use and return ptrdiff_t, not int.
3379 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3380 * gtkutil.h: Change prototypes to match the above.
3382 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3383 are duplicate now that they've been promoted to lisp.h.
3384 (x_allocate_bitmap_record, x_alloc_image_color)
3385 (make_image_cache, cache_image, xpm_load):
3386 Don't update size until alloc is done.
3387 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3389 Check for size calculation overflow.
3390 (ct_colors_allocated_max): New constant.
3391 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3394 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3395 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3396 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3397 Use ptrdiff_t, not int, to count maps.
3398 (read_char_minibuf_menu_prompt): Check for overflow in size
3399 calculations. Don't update size until allocation succeeds.
3400 Redo calculations to avoid overflow.
3401 * keyboard.h: Change prototypes to match the above.
3403 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3405 (current_minor_maps): Check for size calculation overflow.
3406 * keymap.h: Change prototypes to match the above.
3408 * lread.c (read1, init_obarray): Don't update size until alloc done.
3410 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3411 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3413 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3414 Now ptrdiff_t, not int.
3415 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3416 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3418 * process.c (Fnetwork_interface_list): Check for overflow
3419 in size calculation.
3421 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3423 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3424 overflow. Don't bother calling xmalloc when xrealloc will do.
3426 * search.c (Freplace_match): Check for size calculation overflow.
3427 (Fset_match_data): Don't assume list lengths fit in 'int'.
3429 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3430 for command line length. Do not attempt to address one before the
3431 beginning of an array, as that's not portable.
3433 * term.c (max_frame_lines): Remove; unused.
3434 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3436 (encode_terminal_code, calculate_costs): Check for size
3437 calculation overflow.
3438 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3439 table lengths and related sizes. Don't update size until alloc
3440 done. Redo calculations to avoid overflow.
3441 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3443 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3444 subtracting pointers.
3445 (gobble_line): Check for overflow more carefully. Don't update size
3448 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3449 Don't update size until alloc done.
3450 Redo size calculations to avoid overflow.
3451 Check for size calculation overflow.
3452 (main) [DEBUG]: Fix typo in invoking tparam1.
3454 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3455 Use ptrdiff_t, not int, for sizes.
3456 (store_mode_line_noprop_char): Don't update size until alloc done.
3458 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3459 Use ptrdiff_t, not int, for sizes.
3460 (Finternal_make_lisp_face, cache_face):
3461 Check for size calculation overflow.
3462 (cache_face): Treat size calculation overflows as if they were
3463 memory exhaustion (the usual treatment), rather than aborting.
3465 * xfns.c (x_encode_text, x_set_name_internal)
3466 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3467 sizes, since they can exceed INT_MAX in size. Check for size
3468 calculation overflow.
3470 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3471 (xg_select): Check for size calculation overflow.
3472 Don't update size until alloc done.
3474 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3475 as sprintf is limited to int lengths.
3477 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3478 (X_LONG_MIN): New macros.
3479 Use them to make the following changes clearer.
3480 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3481 This change doesn't affect the value now, but it may help remind
3482 future maintainers not to raise the value too much later.
3483 (SELECTION_QUANTUM): Remove, replacing with ...
3484 (selection_quantum): ... new function, which avoids overflow.
3486 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3487 assumption that selection length fits in 'int'.
3488 (x_reply_selection_request, x_handle_selection_request)
3489 (x_get_window_property, receive_incremental_selection)
3490 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3491 (lisp_data_to_selection_data, clean_local_selection_data):
3492 Use ptrdiff_t, not int, to record length of selection.
3493 (x_reply_selection_request, x_get_window_property)
3494 (receive_incremental_selection, x_property_data_to_lisp):
3495 Redo calculations to avoid overflow.
3496 (x_reply_selection_request): When sending hint, ceiling it at
3497 X_LONG_MAX rather than relying on wraparound overflow to send
3499 (x_get_window_property, receive_incremental_selection)
3500 (lisp_data_to_selection_data, x_property_data_to_lisp):
3501 Check for size-calculation overflow.
3502 (x_get_window_property, receive_incremental_selection)
3503 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3504 Don't store size until memory allocation succeeds.
3505 (x_get_window_property): Plug memory leak on memory exhaustion.
3506 Don't double-block input; malloc is safe here. Don't assume 2**34
3507 - 4 fits in unsigned long. Add an xassert to check
3508 XGetWindowProperty overflow. Be more careful about overflow
3509 calculations, and distinguish size from memory overflow better.
3510 (receive_incremental_selection): When tracing, don't assume
3511 unsigned int is less than INT_MAX.
3512 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3513 harmful) conversions of unsigned short to int.
3514 (lisp_data_to_selection_data): Don't assume that integers
3515 in the range -65535 through -1 fit in an X unsigned short.
3516 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3517 result parameters unless successful. Rely on cons_to_unsigned
3518 to report problems with elements; the old code wasn't right anyway.
3519 (x_check_property_data): Check for int overflow; we cannot use
3520 a wider type due to X limits.
3521 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3523 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3525 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3526 (x_term_init): Check for size calculation overflow.
3527 (x_color_cells): Don't store size until memory allocation succeeds.
3528 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3529 Don't assume alloca size is less than MAX_ALLOCA.
3530 (x_term_init): Don't assume length fits in int (sprintf is limited
3533 Use ptrdiff_t for composition IDs.
3534 * character.c (lisp_string_width):
3535 * composite.c (composition_table_size, n_compositions)
3536 (get_composition_id, composition_gstring_from_id):
3537 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3538 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3539 * window.c (Frecenter):
3540 Use ptrdiff_t, not int, for composition IDs.
3541 * composite.c (get_composition_id): Check for integer overflow.
3542 * composite.h: Adjust prototypes to match the above changes.
3544 Use ptrdiff_t for hash table indexes.
3545 * category.c (hash_get_category_set):
3546 * ccl.c (ccl_driver):
3547 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3548 * coding.c (coding_system_charset_list, detect_coding_system):
3549 * coding.h (struct coding_system.id):
3550 * composite.c (get_composition_id, gstring_lookup_cache):
3551 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3552 * image.c (xpm_get_color_table_h):
3553 * lisp.h (hash_lookup, hash_put):
3554 * minibuf.c (Ftest_completion):
3555 Use ptrdiff_t for hash table indexes, not int (which is too
3556 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3557 32-bit --with-wide-int hosts).
3559 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3560 Add a FIXME comment about memory leaks.
3561 (syms_of_charset): Don't assume xmalloc returns.
3563 Don't assume that stated character widths fit in int.
3564 * character.c (Fchar_width, c_string_width, lisp_string_width):
3565 * character.h (CHAR_WIDTH):
3566 * indent.c (MULTIBYTE_BYTES_WIDTH):
3567 Use sanitize_char_width to avoid undefined and/or bad behavior
3568 with outlandish widths.
3569 * character.h (sanitize_tab_width): Rename from sanitize_width,
3570 now that we have two such functions. All uses changed.
3571 (sanitize_char_width): New inline function.
3573 Don't assume that tab-width fits in int.
3574 * character.h (sanitize_width): New inline function.
3575 (SANE_TAB_WIDTH): New macro.
3576 (ASCII_CHAR_WIDTH): Use it.
3577 * indent.c (sane_tab_width): Remove. All uses replaced by
3578 SANE_TAB_WIDTH (current_buffer).
3579 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3581 * fileio.c: Integer overflow issues with file modes.
3582 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3584 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3585 Remove unreachable code.
3586 (read_hex, load_charset_map_from_file): Check for integer overflow.
3588 * xterm.c: Don't go over XClientMessageEvent limit.
3589 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3590 (x_send_scroll_bar_event): Likewise. Check that the size does not
3591 exceed limits imposed by XClientMessageEvent, as well as the usual
3592 ptrdiff_t and size_t limits.
3594 * keyboard.c: Overflow, signedness and related fixes.
3595 (make_lispy_movement): Use same integer type in forward decl
3596 that is used in the definition.
3597 (read_key_sequence, keyremap_step):
3598 Change bufsize argument back to int, undoing my 2011-03-30 change.
3599 We prefer signed types, and int is wide enough here.
3600 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3601 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3602 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3603 length, not size_t. Use ptrdiff_t for index, not int.
3604 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3605 possibility of integer overflow.
3607 Overflow, signedness and related fixes for images.
3609 * dispextern.h (struct it.stack[0].u.image.image_id)
3610 (struct_it.image_id, struct image.id, struct image_cache.size)
3611 (struct image_cache.used, struct image_cache.ref_count):
3612 * gtkutil.c (update_frame_tool_bar):
3613 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3614 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3615 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3616 * nsmenu.m (update_frame_tool_bar):
3617 * xdisp.c (calc_pixel_width_or_height):
3618 * xfns.c (image_cache_refcount):
3619 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3620 on typical 64-bit hosts.
3622 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3623 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3624 Omit unnecessary casts to int.
3625 (parse_image_spec): Check that integers fall into 'int' range
3626 when the callers expect that.
3627 (image_ascent): Redo ascent calculation to avoid int overflow.
3628 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3629 (lookup_image): Remove unnecessary tests.
3630 (xbm_image_p): Locals are now of int, not EMACS_INT,
3631 since parse_image_check makes sure they fit into int.
3632 (png_load, gif_load, svg_load_image):
3633 Prefer int to unsigned where either will do.
3634 (tiff_handler): New function, combining the cores of the
3635 old tiff_error_handler and tiff_warning_handler.
3636 This function is rewritten to use vsnprintf and thereby avoid
3637 stack buffer overflows. It uses only the features of vsnprintf
3638 that are common to both POSIX and native Microsoft.
3639 (tiff_error_handler, tiff_warning_handler): Use it.
3640 (tiff_load, gif_load, imagemagick_load_image):
3641 Don't assume :index value fits in 'int'.
3642 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3643 (imagemagick_load_image): Check that crop parameters fit into
3644 the integer types that MagickCropImage accepts. Don't assume
3645 Vimagemagick_render_type has a nonnegative value. Don't assume
3646 size_t fits in 'long'.
3647 (gs_load): Use printmax_t to print the widest integers possible.
3648 Check for integer overflow when computing image height and width.
3650 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3652 * xdisp.c (redisplay_window): Don't force window start if point
3653 will be invisible in the resulting window. (Bug#9324)
3655 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3657 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3658 the display spec is of the form `(space ...)'.
3659 (handle_display_spec): Return the value returned by
3660 handle_single_display_spec, not just 1 or zero.
3661 (handle_single_display_spec): If the display spec is of the form
3662 `(space ...)', and specifies display in the text area, return 2
3664 (try_cursor_movement): Check for the need to scroll more
3665 accurately, and prefer exact match for point under bidi.
3666 Don't advance `row' beyond the last row of the window.
3668 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3669 into disp_prop; all users changed.
3671 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3672 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3673 for the text covered by the display property.
3675 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3677 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3678 Change return value to nil.
3679 (Frecord_buffer): Delete unused function.
3681 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3683 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3684 buffers, return left-to-right.
3685 (set_cursor_from_row): Consider candidate row a win if its glyph
3686 represents a newline and point is on that newline. Fixes cursor
3687 positioning on the newline at EOL of R2L text within L2R
3688 paragraph, and vice versa.
3689 (try_cursor_movement): Check continued rows, in addition to
3690 continuation rows. Fixes unwarranted scroll when point enters a
3691 continued line of R2L text within an L2R paragraph, or vice versa.
3692 (cursor_row_p): Consider the case of point being equal to
3693 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3694 from the end of a short line to the beginning of a continued line
3695 of R2L text within L2R paragraph.
3696 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3697 composed characters.
3699 * bidi.c (bidi_check_type): Use xassert.
3700 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3703 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3705 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3708 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3710 * nsfont.m (ns_otf_to_script): Fix typo.
3712 2011-08-22 Kenichi Handa <handa@m17n.org>
3714 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3715 extra slot even if the purpose is char-code-property-table.
3717 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3719 * xdisp.c (redisplay_window): When computing centering_position,
3720 account for the height of the header line. (Bug#8874)
3722 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3723 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3724 candidate is selected by the mouse, and that candidate has a
3725 composed character under the mouse.
3727 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3728 coordinates reported by pos-visible-in-window-p for a composed
3729 character in column zero.
3731 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3733 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3735 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3737 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3738 consider it a hit if to_charpos is anywhere in the range of the
3739 composed buffer positions.
3741 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3743 * image.c (gif_load): Don't assume that each subimage has the same
3744 dimensions as the base image. Handle disposal method that is
3745 "undefined" by the gif spec (Bug#9335).
3747 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3749 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3750 (Fcondition_case): Document `debug' symbol in error handler.
3752 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3754 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3755 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3756 from an Org mode buffer to a Speedbar frame.
3758 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3759 a composition, take its buffer position from IT->cmp_it.charpos.
3760 Fixes cursor positioning at the beginning of a line that begins
3761 with a composed character.
3763 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3765 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3766 character bidirectional type, use STRONG_L instead. Fixes crashes
3767 in a buffer produced by `describe-categories'.
3769 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3770 members before the level stack, so they would be saved and
3771 restored when copying iterator state. Fixes incorrect reordering
3772 around TABs covered by display properties.
3774 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3776 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3778 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3780 * eval.c (internal_condition_case, internal_condition_case_1)
3781 (internal_condition_case_2, internal_condition_case_n):
3782 Remove unnecessary aborts (Bug#9081).
3784 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3786 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3787 has no `load' handler, try opening the file locally. (Bug#9311)
3789 2011-08-16 Ken Brown <kbrown@cornell.edu>
3791 * gmalloc.c: Expand comment.
3793 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3795 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3796 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3798 2011-08-16 Ken Brown <kbrown@cornell.edu>
3800 Fix memory allocation problems in Cygwin build (Bug#9273).
3802 * unexcw.c ( __malloc_initialized): Declare external variable.
3803 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3805 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3807 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3809 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3811 [CYGWIN] (special_realloc): New function.
3812 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3813 requests to realloc storage in the static heap.
3815 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3817 * bidi.c (bidi_initialize): Remove unused local.
3819 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3822 * biditype.h: Remove file.
3823 * makefile.w32-in ($(BLD)/bidi.$(O)):
3824 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3826 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3828 * chartab.c: Improve commentary for the uniprop_table API.
3830 * bidi.c (bidi_paragraph_init): Support zero value of
3831 bidi_ignore_explicit_marks_for_paragraph_level.
3832 (bidi_initialize): Use uniprop_table instead of including
3833 biditype.h and bidimirror.h.
3835 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3836 coordinates of the iterator when restoring from ppos_it.
3839 2011-08-14 Kenichi Handa <handa@m17n.org>
3841 * process.c (create_process): Call setup_process_coding_systems
3842 after the pid of the process is set to -1 (Bug#8162).
3844 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3846 * xdisp.c (move_it_in_display_line_to): Don't invoke
3847 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3848 ppos_it. Fixes vertical cursor motion when line beginning is
3849 covered by an image. (Bug#9296)
3851 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3853 * nsterm.h (ns_run_ascript): Declare.
3854 (NSAPP_DATA2_RUNASSCRIPT): Define.
3856 * nsfns.m (as_script, as_result, as_status): New static variables.
3857 (ns_run_ascript): New function.
3858 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3859 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3860 the event loop. Get status from as_status (Bug#7276).
3862 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3863 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3864 the event loop (Bug#7276).
3866 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3868 * gnutls.c (QCgnutls_bootprop_priority)
3869 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3870 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3871 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3872 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3873 (QCgnutls_bootprop_verify_hostname_error)
3874 (QCgnutls_bootprop_callbacks_verify): Rename from
3875 Qgnutls_bootprop_..., all uses changed.
3877 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3880 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3882 * xfaces.c (Qframe_set_background_mode): Now static.
3883 * dispextern.h (Qframe_set_background_mode): Remove decl.
3885 * process.c (Fnetwork_interface_info): Declare local only if needed.
3887 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3889 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3890 (Fnetwork_interface_list): Allocate in increments of bytes instead
3891 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3892 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3894 (struct ifflag_def): notrailers is smart on OSX.
3895 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3896 Get hardware address with getifaddrs if available.
3898 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3900 * xdisp.c (iterate_out_of_display_property): xassert that
3901 IT->position is set to within IT->object's boundaries. Break from
3902 the loop as soon as EOB is reached; avoids infloops in redisplay
3903 when IT->position is set up wrongly due to some bug.
3904 Set IT->current to match the bidi iterator unconditionally.
3905 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3906 entry. Force push_it to save on the stack the current
3907 buffer/string position, to be restored by pop_it. Fix flags in
3908 the iterator structure wrt the object coming from a display
3909 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3910 properties. (Bug#9284)
3912 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3914 * fontset.c (fontset_get_font_group): Add proper type checks.
3917 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3919 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3920 and LC_VERSION_MIN_MACOSX.
3921 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3922 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3924 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3926 * xdisp.c (forward_to_next_line_start): Allow to use the
3927 no-display-properties-and-no-overlays under bidi display.
3928 Set disp_pos in the bidi iterator to avoid searches for display
3929 properties and overlays.
3931 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3933 * editfns.c (Fset_time_zone_rule): Document relationship with the
3936 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3937 the font entity extracted from the cache (Bug#8109).
3939 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3941 * composite.c (autocmp_chars): Don't reset point. That is done by
3942 restore_point_unwind (Bug#5984).
3944 2011-08-07 Juri Linkov <juri@jurta.org>
3946 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3947 to show the arg `TIME' instead of `TIMEVAL'.
3949 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3951 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3952 display property strides EOL and includes a newline, as in
3953 longlines-mode. (Bug#9254)
3954 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3955 word-wrap under bidirectional display. (Bug#9224)
3957 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3958 is non-zero, even if the data buffer is NULL. Fixes a crash in
3959 vertical-motion with longlines-mode. (Bug#9254)
3961 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3963 * bidi.c <bidi_cache_total_alloc>: Now static.
3964 (bidi_initialize): Initialize bidi_cache_total_alloc.
3966 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3969 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3970 amount allocated this far in `bidi_cache_total_alloc'.
3971 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3972 non-zero, only free the data buffer without restoring the cache
3973 contents. All callers changed.
3975 * dispextern.h (bidi_unshelve_cache): Update prototype.
3977 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3978 (move_it_in_display_line, move_it_to)
3979 (move_it_vertically_backward, move_it_by_lines): Replace the call
3980 to xfree to an equivalent call to bidi_unshelve_cache.
3981 (move_it_in_display_line_to): Fix logic of returning
3982 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3984 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3986 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3987 came from a string character with a `cursor' property. (Bug#9229)
3989 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3991 * Makefile.in (LIB_PTHREAD): New variable.
3992 (LIBES): Add LIB_PTHREAD (Bug#9216).
3994 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3995 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3997 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3999 * regex.c (re_iswctype): Remove some redundant boolean conversions.
4001 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4003 * xterm.c (x_find_topmost_parent): New function.
4004 (x_set_frame_alpha): Find topmost parent window with
4005 x_find_topmost_parent and set the property there also (bug#9181).
4006 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4008 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4010 * callproc.c (Fcall_process): Avoid vfork clobbering
4011 the local vars buffer, coding_systems, current_dir.
4013 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4015 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4017 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4019 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4020 so that it is not optimized away.
4022 * xdisp.c (compute_display_string_pos): Remove unused local.
4024 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4026 Fix slow cursor motion and scrolling in large buffers with
4027 selective display, like Org Mode buffers. (Bug#9218)
4029 * dispextern.h (struct bidi_it): New member disp_prop_p.
4031 * xdisp.c: Remove one-slot cache of display string positions.
4032 (compute_display_string_pos): Accept an additional argument
4033 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4034 for a display string or property. If found, set DISP_PROP_P
4037 * bidi.c (bidi_fetch_char): Accept an additional argument
4038 DISP_PROP_P, and pass it to compute_display_string_pos.
4039 Only handle text covered by a display string if DISP_PROP_P is returned
4040 non-zero. All callers of bidi_fetch_char changed.
4042 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4044 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4046 2010-12-03 Don March <don@ohspite.net>
4048 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4049 last character M-[char] is translated to ESC [char] (bug#7541).
4051 2011-08-02 Kenichi Handa <handa@m17n.org>
4053 * lisp.h (uniprop_table): Extern it.
4055 * chartab.c (uniprop_table): Make it non-static.
4057 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4059 * xdisp.c (forward_to_next_line_start): Accept additional argument
4060 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4062 (reseat_at_next_visible_line_start): Use the bidi iterator state
4063 returned by forward_to_next_line_start to restore the state of
4064 it->bidi_it after backing up to previous newline. (Bug#9212)
4066 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4068 * regex.c (re_comp): Protoize.
4069 (re_exec): Fix return type.
4070 (regexec): Fix type of `ret'. (Bug#9203)
4072 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4074 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4075 This is needed if max-image-size is a floating-point number.
4077 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4079 * print.c (print_object): Print empty symbol as ##.
4081 * lread.c (read1): Read ## as empty symbol.
4083 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4085 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4086 setting frame foreground color (Bug#9175).
4087 (x_set_background_color): Likewise.
4089 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4090 contents (Bug#9176).
4091 (EmacsTooltip -init): Remove bezels and add shadows to
4094 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4095 or scroll bar (Bug#8470).
4097 * nsfont.m (nsfont_open): Remove assignment to voffset and
4098 unnecessary vars hshink, expand, hd, full_height, min_height.
4099 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4101 * nsterm.h (nsfont_info): Remove voffset field.
4103 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4105 Implement strike-through and overline on NextStep (Bug#8863).
4107 * nsfont.m (nsfont_open): Use underline position provided by font,
4108 instead of hard-coded value of 2.
4109 (nsfont_draw): Call ns_draw_text_decoration instead.
4111 * nsterm.h: Add declaration for ns_draw_text_decoration.
4113 * nsterm.m (ns_draw_text_decoration): New function for drawing
4114 underline, overline, and strike-through.
4115 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4116 ns_draw_text_decoration. Change treatment of cursor drawing to
4117 accommodate underlining, etc.
4119 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4121 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4124 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4126 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4127 Without this fix, if a signal arrives just after memory fills up,
4128 'malloc' might be invoked reentrantly.
4130 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4131 In other words, assume that every image size is allowed, on non-X
4132 hosts. This assumption is probably wrong, but it lets Emacs compile.
4134 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4136 * regex.c (re_iswctype): Convert return values to boolean.
4138 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4140 * xdisp.c (compute_display_string_pos): Don't use cached display
4141 string position if the buffer had its restriction changed.
4144 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4146 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4148 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4150 Integer signedness and overflow and related fixes. (Bug#9079)
4152 * bidi.c: Integer size and overflow fixes.
4153 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4154 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4155 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4156 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4157 (bidi_find_other_level_edge):
4158 Use ptrdiff_t instead of EMACS_INT where either will do.
4159 This works better on 32-bit hosts configured --with-wide-int.
4160 (bidi_cache_ensure_space): Check for size-calculation overflow.
4161 Use % rather than repeated addition, for better worst-case speed.
4162 Don't set bidi_cache_size until after xrealloc returns, because it
4164 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4165 (bidi_cache_ensure_space): Also check that the bidi cache size
4166 does not exceed that of the largest Lisp string or buffer. See Eli
4167 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4169 * alloc.c (__malloc_size_t): Remove.
4170 All uses replaced by size_t. See Andreas Schwab's note
4171 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4173 * image.c: Improve checking for integer overflow.
4174 (check_image_size): Assume that f is nonnull, since
4175 it is always nonnull in practice. This is one less thing to
4176 worry about when checking for integer overflow later.
4177 (x_check_image_size): New function, which checks for integer
4178 overflow issues inside X.
4179 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4180 This removes the need for a memory_full check.
4181 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4182 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4183 (xbm_read_bitmap_data): Change locals back to 'int', since
4184 their values must fit in 'int'.
4185 (xpm_load_image, png_load, tiff_load):
4186 Invoke x_create_x_image_and_pixmap earlier,
4187 to avoid much needless work if the image is too large.
4188 (tiff_load): Treat overly large images as if
4189 x_create_x_image_and_pixmap failed, not as malloc failures.
4190 (gs_load): Use x_check_image_size.
4192 * gtkutil.c: Omit integer casts.
4193 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4194 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4196 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4198 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4199 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4200 would wrongly return t on a 64-bit host.
4202 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4203 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4204 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4205 and therefore cause GCC to emit a bogus diagnostic in some cases.
4207 * image.c: Integer signedness and overflow and related fixes.
4208 This is not an exhaustive set of fixes, but it's time to
4209 record what I've got.
4210 (lookup_pixel_color, check_image_size): Remove redundant decls.
4211 (check_image_size): Don't assume that arbitrary EMACS_INT values
4212 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4213 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4214 (tiff_load, imagemagick_load_image):
4215 Check for overflow in size calculations.
4216 (x_create_x_image_and_pixmap): Remove unnecessary test for
4217 xmalloc returning NULL; that can't happen.
4218 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4219 (xpm_color_bucket): Use better integer hashing function.
4220 (xpm_cache_color): Don't possibly over-allocate memory.
4221 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4222 (gif_memory_source):
4223 Use ptrdiff_t, not int or size_t, to record sizes.
4224 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4225 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4226 either works, as we prefer signed integers.
4227 (tiff_read_from_memory, tiff_write_from_memory):
4228 Return tsize_t, not size_t, since that's what the TIFF API wants.
4229 (tiff_read_from_memory): Don't fail simply because the read would
4230 go past EOF; instead, return a short read.
4231 (tiff_load): Omit no-longer-needed casts.
4232 (Fimagemagick_types): Don't assume size fits into 'int'.
4234 Improve hashing quality when configured --with-wide-int.
4235 * fns.c (hash_string): New function, taken from sxhash_string.
4236 Do not discard information about ASCII character case; this
4237 discarding is no longer needed.
4238 (sxhash-string): Use it. Change sig to match it. Caller changed.
4239 * lisp.h: Declare it.
4240 * lread.c (hash_string): Remove, since we now use fns.c's version.
4241 The fns.c version returns a wider integer if --with-wide-int is
4242 specified, so this should help the quality of the hashing a bit.
4244 * emacs.c: Integer overflow minor fix.
4245 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4246 Define only if GNU_LINUX.
4247 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4249 * dispnew.c: Integer signedness and overflow fixes.
4250 Remove unnecessary forward decls, that were a maintenance hassle.
4251 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4253 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4254 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4255 (prepare_desired_row, line_draw_cost):
4256 Use int, not unsigned, where either works.
4257 (save_current_matrix, restore_current_matrix):
4258 Use ptrdiff_t, not size_t, where either works.
4259 (init_display): Check for overflow more accurately, and without
4260 relying on undefined behavior.
4262 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4263 Remove, replacing with the new symbols in lisp.h. All uses changed.
4264 * fileio.c (make_temp_name):
4265 * filelock.c (lock_file_1, lock_file):
4266 * xdisp.c (message_dolog):
4267 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4268 Use pMd etc. instead.
4269 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4270 replacing the pWIDE etc. symbols removed from editfns.c.
4272 * keyboard.h (num_input_events): Now uintmax_t.
4273 This is (very slightly) less likely to mess up due to wraparound.
4276 * buffer.c: Integer signedness fixes.
4277 (alloc_buffer_text, enlarge_buffer_text):
4278 Use ptrdiff_t rather than size_t when either will do, as we prefer
4281 * alloc.c: Integer signedness and overflow fixes.
4282 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4283 (__malloc_size_t): Default to size_t, not to int.
4284 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4285 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4286 Prefer ptrdiff_t to size_t when either would do, as we prefer
4288 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4289 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4290 Now const. Initialize with values that are in range even if char
4292 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4293 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4294 These functions do the right thing with sizes > 2**32.
4295 (check_depth): Now ptrdiff_t, not int.
4296 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4297 Adjust to new way of storing sizes. Check for size overflow bugs
4299 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4300 slightly wrong anyway, as it missed one instance of
4301 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4302 (refill_memory_reserve): Omit needless cast to size_t.
4303 (mark_object_loop_halt): Mark as externally visible.
4305 * xselect.c: Integer signedness and overflow fixes.
4306 (Fx_register_dnd_atom, x_handle_dnd_message):
4307 Use ptrdiff_t, not size_t, since we prefer signed.
4308 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4309 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4310 x_dnd_atoms_size and x_dnd_atoms_length.
4312 * doprnt.c: Prefer signed to unsigned when either works.
4314 * doprnt.c (doprnt):
4316 * xdisp.c (vmessage):
4317 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4318 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4319 prefer signed arithmetic to avoid comparison confusion.
4320 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4321 but is a bit tricky.
4323 Assume freestanding C89 headers, string.h, stdlib.h.
4324 * data.c, doprnt.c, floatfns.c, print.c:
4325 Include float.h unconditionally.
4326 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4327 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4328 * regex.c: Likewise for stddef.h, string.h.
4329 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4330 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4331 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4332 (STDC_HEADERS): Remove obsolete defines.
4333 * sysdep.c: Include limits.h unconditionally.
4335 Assume support for memcmp, memcpy, memmove, memset.
4336 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4337 * regex.c (memcmp, memcpy):
4338 Remove; we assume C89 now.
4340 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4341 (__malloc_safe_bcopy): Remove; no longer needed.
4343 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4344 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4345 well either way, and we prefer signed to unsigned.
4347 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4349 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4350 closes the connection while we're reading (bug#9182).
4352 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4354 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4355 are specified (Bug#9168).
4357 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4359 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4360 Found by GCC static checking and --with-wide-int on a 32-bit host.
4362 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4364 * xdisp.c (compute_display_string_pos): Fix logic of caching
4365 previous display string position. Initialize cached_prev_pos to
4366 -1. Fixes slow-down at the beginning of a buffer.
4368 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4370 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4371 for attrs[LFACE_FONTSET_INDEX].
4373 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4375 * xml.c (parse_region): Remove unused local
4376 that was recently introduced.
4378 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4380 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4381 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4383 * xdisp.c (move_it_in_display_line_to): Record the best matching
4384 position for TO_CHARPOS while scanning the line, and restore it on
4385 exit if none of the characters scanned was an exact match.
4386 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4387 when exact match is impossible due to invisible text, and the
4388 lines are truncated.
4390 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4392 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4395 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4397 Fix a significant slow-down of cursor motion with C-n, C-p,
4398 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4399 auto-repeat under bidi redisplay in fontified buffers.
4400 * xdisp.c (compute_stop_pos_backwards): New function.
4401 (next_element_from_buffer): Call compute_stop_pos_backwards to
4402 find a suitable prev_stop when we find ourselves before
4404 (reseat): Don't look for prev_stop, as that could mean a very long
4406 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4407 <cached_disp_overlay_modiff>: Cache for last found display string
4409 (compute_display_string_pos): Return the cached position if asked
4410 about the same buffer in the same area of character positions, and
4411 the buffer wasn't changed since the time the display string
4412 position was cached.
4414 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4416 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4417 is an integer, which is important for empty lines. (Bug#9149)
4419 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4421 * frame.c (Fmodify_frame_parameters): In tty case, update the
4422 default face if necessary (Bug#4238).
4424 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4426 * editfns.c (Fstring_to_char): No need to explain what a character
4427 is in the docstring (Bug#6576).
4429 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4431 * xml.c (parse_region): Make sure we always return a tree.
4433 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4435 * xml.c (parse_region): If a document contains only comments,
4438 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4440 * xml.c (make_dom): Return comments, too.
4442 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4445 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4446 and the surrounding thread.
4447 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4448 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4449 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4451 * s/openbsd.h (BROKEN_SIGIO): Define.
4452 * unexelf.c (unexec) [__OpenBSD__]:
4453 Don't update the .mdebug section of the Alpha COFF symbol table.
4455 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4457 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4460 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4462 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4463 This fixes some race conditions on the permissions of any newly
4466 * alloc.c (valid_pointer_p): Use pipe, not open.
4467 This fixes some permissions issues when debugging.
4469 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4470 If fchown fails to set both uid and gid, try to set just gid,
4471 as that is sometimes allowed. Adjust the file's mode to eliminate
4472 setuid or setgid bits that are inappropriate if fchown fails.
4474 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4476 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4477 to compare Lisp_Objects.
4478 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4479 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4480 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4482 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4484 * lread.c (read_integer): Unread even EOF character.
4485 (read1): Likewise. Properly record start position of symbol.
4487 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4488 symbol character follows.
4490 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4492 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4493 This works around a problem with the previous change to Fcopy_file.
4494 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4495 and without this change, GCC might complain about discarding
4496 fchown's return value.
4498 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4500 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4502 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4504 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4506 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4508 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4509 it's used from the C level.
4511 * process.c: Use the same condition for POLL_FOR_INPUT in both
4512 keyboard.c and process.c (bug#1858).
4514 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4516 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4517 (Fgnutls_boot): Use it.
4519 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4521 * doc.c (Fsubstitute_command_keys): Revert last change.
4523 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4525 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4526 quotes the next character, and doesn't affect other longer
4527 sequences (bug#8935).
4529 * lread.c (syms_of_lread): Clarify that is isn't only
4530 `eval-buffer' and `eval-defun' that's affected by
4531 `lexical-binding' (bug#8460).
4533 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4535 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4536 bidi redisplay when a line includes both an image and is truncated.
4538 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4540 Fix minor problems found by static checking.
4541 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4542 (elsz): Now a signed constant, not a size_t var. We prefer signed
4543 types to unsigned, to avoid integer comparison confusion. Without
4544 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4545 "cannot optimize loop, the loop counter may overflow", a symptom
4547 * indent.c (Fvertical_motion): Mark locals as initialized.
4548 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4550 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4552 * search.c (Fre_search_backward): Mention `case-fold-search' in
4553 all the re_search_* functions (bug#8138).
4555 * keyboard.c (Fopen_dribble_file): Document when the file is
4558 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4560 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4563 Support bidi reordering of display and overlay strings.
4564 * xdisp.c (compute_display_string_pos)
4565 (compute_display_string_end): Accept additional argument STRING.
4566 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4567 (reseat_to_string): Initialize bidi_it->string.s and
4568 bidi_it->string.schars.
4569 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4570 NULL (avoids a crash in bidi_paragraph_init).
4571 Initialize itb.string.lstring.
4572 (init_iterator): Call bidi_init_it only of a valid
4573 buffer position was specified. Initialize paragraph_embedding to
4575 (reseat_to_string): Initialize the bidi iterator.
4576 (display_string): If we need to ignore text properties of
4577 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4578 original value of -1 will not work with bidi.)
4579 (compute_display_string_pos): First arg is now struct
4580 `text_pos *'; all callers changed. Support display properties on
4582 (compute_display_string_end): Support display properties on Lisp
4584 (init_iterator, reseat_1, reseat_to_string): Initialize the
4585 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4586 when iterating on a string not from display properties).
4587 (compute_display_string_pos, compute_display_string_end):
4588 Fix calculation of the object to scan. Fixes an error when using
4590 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4591 base_level_stop; instead, set base_level_stop to BEGV.
4592 Fixes crashes in vertical-motion.
4593 (next_element_from_buffer): Improve commentary for when
4594 the iterator is before prev_stop.
4595 (init_iterator): Initialize bidi_p from the default value of
4596 bidi-display-reordering, not from buffer-local value. Use the
4597 buffer-local value only if initializing for buffer iteration.
4598 (handle_invisible_prop): Support invisible properties on strings
4599 that are being bidi-reordered.
4600 (set_iterator_to_next): Support bidi reordering of C strings and
4602 (next_element_from_string): Support bidi reordering of Lisp
4604 (handle_stop_backwards): Support Lisp strings as well.
4605 (display_string): Support display of R2L glyph rows.
4606 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4607 (init_iterator): Don't initialize it->bidi_p for strings
4609 (reseat_to_string): Initialize it->bidi_p for strings here.
4610 (next_element_from_string, next_element_from_c_string)
4611 (next_element_from_buffer): Add xassert's for correspondence
4612 between IT's object being iterated and it->bidi_it.string
4614 (face_before_or_after_it_pos): Support bidi iteration.
4615 (next_element_from_c_string): Handle the case of the first string
4616 character that is not the first one in the visual order.
4617 (get_visually_first_element): New function, refactored from common
4618 parts of next_element_from_buffer, next_element_from_string, and
4619 next_element_from_c_string.
4620 (tool_bar_lines_needed, redisplay_tool_bar)
4621 (display_menu_bar): Force left-to-right direction. Add a FIXME
4622 comment for making that be controlled by a user option.
4623 (push_it, pop_it): Save and restore the state of the
4624 bidi iterator. Save and restore the bidi_p flag.
4625 (pop_it): Iterate out of display property for string iteration as
4627 (iterate_out_of_display_property): Support iteration over strings.
4628 (handle_single_display_spec): Set up it->bidi_it for iteration
4629 over a display string, and call bidi_init_it.
4630 (handle_single_display_spec, next_overlay_string)
4631 (get_overlay_strings_1, push_display_prop): Set up the bidi
4632 iterator for displaying display or overlay strings.
4633 (forward_to_next_line_start): Don't use the shortcut if
4635 (back_to_previous_visible_line_start): If handle_display_prop
4636 pushed the iterator stack, restore the internal state of the bidi
4637 iterator by calling bidi_pop_it same number of times.
4638 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4639 and we are bidi-iterating, don't decrement the iterator position;
4640 instead, set the first_elt flag in the bidi iterator, to produce
4642 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4643 (push_display_prop): xassert that we are iterating a buffer.
4644 (push_it, pop_it): Save and restore paragraph_embedding member.
4645 (handle_single_display_spec, next_overlay_string)
4646 (get_overlay_strings_1, reseat_1, reseat_to_string)
4647 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4648 correctly. Don't assume unibyte strings are not bidi-reordered.
4649 (compute_display_string_pos)
4650 (compute_display_string_end): Fix handling the case of C string.
4651 (push_it, pop_it): Save and restore from_disp_prop_p.
4652 (handle_single_display_spec, push_display_prop): Set the
4653 from_disp_prop_p flag.
4654 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4655 (pop_it): Call iterate_out_of_display_property only if we are
4656 popping after iteration over a string that came from a display
4657 property. Fix a typo in popping stretch info. Add an assertion
4658 for verifying that the iterator position is in sync with the bidi
4660 (handle_single_display_spec, get_overlay_strings_1)
4661 (push_display_prop): Fix initialization of paragraph direction for
4662 string when that of the parent object is not yet determined.
4663 (reseat_1): Call bidi_init_it to resync the bidi
4664 iterator with IT's position. (Bug#7616)
4665 (find_row_edges): If ROW->start.pos gives position
4666 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4667 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4668 Reset the from_disp_prop_p flag.
4669 (SAVE_IT, RESTORE_IT): New macros.
4670 (pos_visible_p, face_before_or_after_it_pos)
4671 (back_to_previous_visible_line_start)
4672 (move_it_in_display_line_to, move_it_in_display_line)
4673 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4674 (try_scrolling, redisplay_window, display_line): Use them when
4675 saving a temporary copy of the iterator and restoring it back.
4676 (back_to_previous_visible_line_start, reseat_1)
4677 (init_iterator): Empty the bidi cache "stack".
4678 (move_it_in_display_line_to): If iterator ended up at
4679 EOL, but we never saw any buffer positions smaller than
4680 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4681 motion in bidi-reordered lines.
4682 (move_it_in_display_line_to): Record prev_method and prev_pos
4683 immediately before the call to set_iterator_to_next. Fixes cursor
4684 motion in bidi-reordered lines with stretch glyphs and strings
4685 displayed in margins. (Bug#8133) (Bug#8867)
4686 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4688 (pos_visible_p): Support positions in bidi-reordered lines.
4689 Save and restore bidi cache.
4691 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4692 (bidi_paragraph_info): Delete unused struct.
4693 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4694 (bidi_cache_start): New variable.
4695 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4697 (bidi_cache_fetch_state, bidi_cache_search)
4698 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4699 (bidi_cache_find, bidi_peek_at_next_level)
4700 (bidi_level_of_next_char, bidi_find_other_level_edge)
4701 (bidi_move_to_visually_next): Compare cache index with
4702 bidi_cache_start rather than with zero.
4703 (bidi_fetch_char): Accept new argument STRING; all callers
4704 changed. Support iteration over a string. Support strings with
4705 display properties. Support unibyte strings. Fix the type of
4706 `len' according to what STRING_CHAR_AND_LENGTH expects.
4707 (bidi_paragraph_init, bidi_resolve_explicit_1)
4708 (bidi_resolve_explicit, bidi_resolve_weak)
4709 (bidi_level_of_next_char, bidi_move_to_visually_next):
4710 Support iteration over a string.
4711 (bidi_set_sor_type, bidi_resolve_explicit_1)
4712 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4713 can now be zero (for strings); special values 0 and -1 were
4714 changed to -1 and -2, respectively.
4715 (bidi_char_at_pos): New function.
4716 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4717 Call it instead of FETCH_MULTIBYTE_CHAR.
4718 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4719 initialized to valid values.
4720 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4722 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4723 the test for valid cached positions. Fix the logic for looking up
4724 the sentinel state in the cache. GCPRO the Lisp string we are
4726 (bidi_push_it, bidi_pop_it): New functions.
4727 (bidi_initialize): Initialize the bidi cache start stack pointer.
4728 (bidi_cache_ensure_space): New function, refactored from part of
4729 bidi_cache_iterator_state. Don't assume the required size is just
4730 one BIDI_CACHE_CHUNK away.
4731 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4732 (bidi_count_bytes, bidi_char_at_pos): New functions.
4733 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4734 always valid if bidi_cache_idx is valid.
4735 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4736 is valid if it's going to be used.
4737 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4738 (bidi_cache_fetch_state, bidi_cache_search)
4739 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4740 (bidi_cache_iterator_state, bidi_cache_find)
4741 (bidi_find_other_level_edge, bidi_cache_start_stack):
4742 All variables related to cache indices are now EMACS_INT.
4744 * dispextern.h (struct bidi_string_data): New structure.
4745 (struct bidi_it): New member `string'. Make flag members be 1-bit
4746 fields, and put them last in the struct.
4747 (compute_display_string_pos, compute_display_string_end):
4749 (bidi_push_it, bidi_pop_it): Add prototypes.
4750 (struct iterator_stack_entry): New members bidi_p,
4751 paragraph_embedding, and from_disp_prop_p.
4752 (struct it): Member bidi_p is now a bit field 1 bit wide.
4753 (bidi_shelve_cache, bidi_unshelve_cache):
4756 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4757 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4758 and vector-like objects.
4760 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4761 cache around display iteration.
4763 * window.c (Fwindow_end, window_scroll_pixel_based)
4764 (displayed_window_lines, Frecenter): Save and restore the bidi
4765 cache around display iteration.
4767 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4769 * editfns.c (Fdelete_region): Clarify the use of the named
4770 parameters (bug#6788).
4772 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4774 * indent.c (Fvertical_motion): Set and restore w->pointm when
4775 saving and restoring the window's buffer (Bug#9006).
4777 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4779 * editfns.c (Fstring_to_char): Clarify just what is returned
4780 (bug#6576). Text by Eli Zaretskii.
4782 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4784 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4786 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4788 * buffer.c (mmap_find): Fix a typo.
4790 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4792 Fix execution of x selection hooks.
4793 * xselect.c (Qx_lost_selection_functions)
4794 (Qx_sent_selection_functions): New vars.
4795 (syms_of_xselect): DEFSYM them.
4796 (x_handle_selection_request): Pass Qx_sent_selection_functions
4797 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4798 (x_handle_selection_clear,x_clear_frame_selections):
4799 Pass Qx_lost_selection_functions rather than
4800 Vx_lost_selection_functions to Frun_hook_with_args.
4802 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4804 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4805 The old code sometimes used this field without initializing it.
4807 * alloc.c (gc_sweep): Don't read past end of array.
4808 In theory, the old code could also have corrupted Emacs internals,
4809 though it'd be very unlikely.
4811 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4813 * character.c (Fcharacterp): Don't advertise optional ignored
4814 argument. (Bug#4026)
4816 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4818 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4821 * window.c (Fset_window_start): Doc fix (bug#4199).
4822 (Fset_window_hscroll): Ditto.
4824 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4826 Fix minor new problems caught by GCC 4.6.1.
4827 * term.c (init_tty): Remove unused local.
4828 * xsettings.c (store_monospaced_changed): Define this function only
4829 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4832 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4834 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4836 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4838 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4839 are the mini-buffer and the echo area (bug#3320).
4841 * term.c (init_tty): Remove support for supdup, c10 and perq
4842 terminals, which are no longer supported (bug#1482).
4844 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4846 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4848 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4850 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4851 for non-popups (Bug#3642).
4853 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4855 * alloc.c (reset_malloc_hooks): Protoize.
4856 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4857 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4858 * cm.c (losecursor): Likewise.
4859 * data.c (fmod): Likewise.
4860 * dispnew.c (swap_glyphs_in_rows): Likewise.
4861 * emacs.c (memory_warning_signal): Likewise.
4862 * floatfns.c (float_error): Likewise.
4863 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4864 (otf_open, font_otf_capability, generate_otf_features)
4865 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4867 * image.c (pbm_read_file): Likewise.
4868 * indent.c (string_display_width): Likewise.
4869 * intervals.c (check_for_interval, search_for_interval)
4870 (inc_interval_count, count_intervals, root_interval)
4871 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4872 * lread.c (defalias): Likewise.
4873 * ralloc.c (r_alloc_check): Likewise.
4874 * regex.c (set_image_of_range_1, set_image_of_range)
4875 (regex_grow_registers): Likewise.
4876 * sysdep.c (strerror): Likewise.
4877 * termcap.c (valid_filename_p, tprint, main): Likewise.
4878 * tparam.c (main): Likewise.
4879 * unexhp9k800.c (run_time_remap, save_data_space)
4880 (update_file_ptrs, read_header, write_header, calculate_checksum)
4881 (copy_file, copy_rest, display_header): Likewise.
4882 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4884 * xdisp.c (check_it): Likewise.
4885 * xfaces.c (register_color, unregister_color, unregister_colors):
4887 * xfns.c (print_fontset_result): Likewise.
4888 * xrdb.c (member, fatal, main): Likewise.
4890 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4892 Fix minor problems found by static checking (Bug#9031).
4893 * chartab.c (char_table_set_range, map_sub_char_table):
4894 Remove unused locals.
4895 (uniprop_table): Now static.
4896 * composite.c (_work_char): Remove unused static var.
4898 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4900 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4902 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4904 * gtkutil.c (qttip_cb): Remove code without function.
4906 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4908 * w32.c (pthread_sigmask): New stub.
4910 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4912 Use pthread_sigmask, not sigprocmask (Bug#9010).
4913 sigprocmask is portable only for single-threaded applications, and
4914 Emacs can be multi-threaded when it uses GTK.
4915 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4917 * callproc.c (Fcall_process):
4918 * process.c (create_process):
4919 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4920 Use pthread_sigmask, not sigprocmask.
4922 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4924 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4925 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4928 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4930 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4931 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4932 (xg_hide_tooltip): Fix comment.
4934 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4935 in registerServicesMenuSendTypes.
4936 (validRequestorForSendType): Don't check ns_return_types.
4938 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4941 2011-07-08 Jason Rumney <jasonr@gnu.org>
4943 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4944 SH_SHOW for hidden windows (Bug#5482).
4946 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4947 frame struct members of non-existent frames (Bug#6284).
4949 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4951 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4952 variable firstTime not needed on OSX >= 10.6.
4953 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4954 >= 10.5. Use setKnobProportion, setDoubleValue.
4956 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4957 (MAC_OS_X_VERSION_10_5): Define if not defined.
4958 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4959 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4960 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4962 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4963 cString and lossyCString on OSX >= 10.4
4965 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4966 sizeToFit on OSX >= 10.2.
4968 * nsimage.m (allocInitFromFile): Don't use deprecated method
4969 bestRepresentationForDevice on OSX >= 10.6.
4971 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4974 * emacs.c: Declare unexec_init_emacs_zone.
4976 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4978 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4980 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4981 on svcsMenu (Bug#8842).
4983 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4985 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4987 * nsterm.m (QUTF8_STRING): Declare.
4988 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4989 (validRequestorForSendType): Return type is (id).
4990 Change indexOfObjectIdenticalTo to indexOfObject.
4991 Check if we have local selection before returning self (Bug#8842).
4992 (writeSelectionToPasteboard): Put local selection into paste board
4993 if we have a local selection (Bug#8842).
4994 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4996 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4997 (ns_get_local_selection): Declare.
4999 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5001 * keymap.c (describe_map_tree): Don't insert a double newline at
5002 the end of the buffer (bug#1169) and return whether we inserted
5005 * callint.c (Fcall_interactively): Change "reading args" to
5006 "providing args" to try to clarify what it does (bug#1010).
5008 2011-07-07 Kenichi Handa <handa@m17n.org>
5010 * composite.c (composition_compute_stop_pos): Ignore a static
5011 composition starting before CHARPOS (Bug#8915).
5013 * xdisp.c (handle_composition_prop): Likewise.
5015 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5017 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5020 2011-07-07 Kenichi Handa <handa@m17n.org>
5022 * character.h (unicode_category_t): New enum type.
5024 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5025 (Qchar_code_property_table): New variable.
5026 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5027 (UNIPROP_COMPRESSED_FORM_P): New macros.
5028 (char_table_ascii): Uncompress the compressed values.
5029 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5030 Uncompress the compressed values.
5031 (sub_char_table_ref_and_range): Likewise.
5032 (char_table_ref_and_range): Uncompress the compressed values.
5033 (sub_char_table_set): New arg is_uniprop. Callers changed.
5034 Uncompress the compressed values.
5035 (sub_char_table_set_range): Args changed. Callers changed.
5036 (char_table_set_range): Adjuted for the above change.
5037 (map_sub_char_table): Delete args default_val and parent. Add arg
5038 top. Give decoded values to a Lisp function.
5039 (map_char_table): Adjust for the above change. Give decoded
5040 values to a Lisp function. Gcpro more variables.
5041 (uniprop_table_uncompress)
5042 (uniprop_decode_value_run_length): New functions.
5043 (uniprop_decoder, uniprop_decoder_count): New variables.
5044 (uniprop_get_decoder, uniprop_encode_value_character)
5045 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5047 (uniprop_encoder, uniprop_encoder_count): New variables.
5048 (uniprop_get_encoder, uniprop_table)
5049 (Funicode_property_table_internal, Fget_unicode_property_internal)
5050 (Fput_unicode_property_internal): New functions.
5051 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5052 Sunicode_property_table_internal, Sget_unicode_property_internal,
5053 and Sput_unicode_property_internal. Defvar_lisp
5054 char-code-property-alist.
5056 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5057 Vunicode_category_table.
5059 * font.c (font_range): Adjust for the change of
5060 Vunicode_category_table.
5062 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5064 * m/iris4d.h: Remove file, move contents ...
5065 * s/irix6-5.h: ... here.
5067 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5069 Remove unportable assumption about struct layout (Bug#8884).
5070 * alloc.c (mark_buffer):
5071 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5072 (clone_per_buffer_values): Don't assume that
5073 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5074 This isn't true in general, and it's particularly not true
5075 if Emacs is configured with --with-wide-int.
5076 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5077 New macros, used in the buffer.c change.
5079 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5081 * xsettings.c: Use both GConf and GSettings if both are available.
5082 (store_config_changed_event): Add comment.
5083 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5084 (store_tool_bar_style_changed): New functions.
5085 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5086 (struct xsettings): Move font inside HAVE_XFT.
5087 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5088 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5089 Move inside HAVE_XFT.
5090 (something_changed_gsettingsCB): Rename from something_changedCB.
5091 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5093 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5094 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5095 (something_changed_gconfCB): Rename from something_changedCB.
5096 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5097 (parse_settings): Move check for font inside HAVE_XFT.
5098 (read_settings, apply_xft_settings): Add comment.
5099 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5100 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5101 call store_font_name_changed.
5102 (xft_settings_event): Add comment.
5103 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5104 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5105 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5106 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5107 (xsettings_initialize): Call init_gsettings last.
5108 (xsettings_get_system_font, xsettings_get_system_normal_font):
5111 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5113 Random fixes. E.g., (random) never returned negative values.
5114 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5115 subseconds part to the entropy, as that's a bit more random.
5116 Prefer signed to unsigned, since the signedness doesn't matter and
5117 in general we prefer signed. When given a limit, use a
5118 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5119 latter isn't right if USE_2_TAGS_FOR_INTS.
5120 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5121 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5123 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5125 * textprop.c (text_property_stickiness):
5126 Obey Vtext_property_default_nonsticky.
5127 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5128 * w32fns.c (syms_of_w32fns):
5129 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5131 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5133 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5134 This is more efficient than Ffile_directory_p and avoids a minor race.
5136 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5138 * buffer.c (Foverlay_put): Say what the return value is
5141 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5142 is a directory before asking whether to use the file name
5144 (barf_or_query_if_file_exists): Make the "File is a directory"
5145 error be more correct.
5147 * fns.c (Frequire): Remove the mention of the .gz files, since
5148 that's installation-specific, but keep the mention of
5149 `get-load-suffixes'.
5151 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5153 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5154 Report string overflow if the output is too long.
5156 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
5158 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5159 (syms_of_gnutls): Remove duplicate DEFSYM for
5160 Qgnutls_bootprop_verify_hostname_error, an error for
5161 Qgnutls_bootprop_verify_error (which is no longer used).
5163 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5164 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5165 Also (re)move comments that are misplaced or no longer relevant.
5167 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5169 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5171 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5173 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5174 and background color parameters if they have been changed.
5176 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5178 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5180 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5182 * xsettings.c (SYSTEM_FONT): Define only when used.
5183 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5185 * keymap.c (access_keymap_1): Now static.
5187 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5189 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5190 leave any prefix arg for the up event (Bug#1586).
5192 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5194 * lread.c (syms_of_lread): Mention single symbols defined by
5195 `defvar' or `defconst' (bug#7154).
5197 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5198 (Frequire): Mention get-load-suffixes.
5200 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5202 * window.h (window): Remove clone_number slot.
5203 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5205 (make_parent_window, make_window, saved_window)
5206 (Fset_window_configuration, save_window_save): Don't deal with
5208 * buffer.c (Qclone_number): Remove declaration.
5209 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5211 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5213 Add multiple inheritance to keymaps.
5214 * keymap.c (Fmake_composed_keymap): New function.
5215 (Fset_keymap_parent): Simplify.
5216 (fix_submap_inheritance): Remove.
5217 (access_keymap_1): New function extracted from access_keymap to handle
5218 embedded parents and handle lists of maps.
5219 (access_keymap): Use it.
5220 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5221 (Fcopy_keymap): Handle embedded parents.
5222 (Fcommand_remapping, define_as_prefix): Simplify.
5223 (Fkey_binding): Simplify.
5224 (syms_of_keymap): Move minibuffer-local-completion-map,
5225 minibuffer-local-filename-completion-map,
5226 minibuffer-local-must-match-map, and
5227 minibuffer-local-filename-must-match-map to Elisp.
5228 (syms_of_keymap): Defsubr make-composed-keymap.
5229 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5230 (parse_menu_item): Trivial simplification.
5232 2011-07-01 Glenn Morris <rgm@gnu.org>
5234 * Makefile.in (SETTINGS_LIBS): Fix typo.
5236 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5238 * coding.c (Fencode_coding_string): Record the last coding system
5239 used, as the function doc string says (bug#8738).
5241 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5243 * xsettings.c (store_monospaced_changed): Take new font as arg and
5244 check for change against current_mono_font.
5245 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5246 (emacs_settings_constructor, emacs_settings_get_property)
5247 (emacs_settings_set_property, emacs_settings_class_init)
5248 (emacs_settings_init, gsettings_obj): Remove.
5249 (something_changedCB): New function for HAVE_GSETTINGS.
5250 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5251 with value as argument.
5252 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5253 g_settings_new (Bug#8967). Do not create gsettings_obj.
5254 Remove calls to g_settings_bind. Connect something_changedCB to
5257 * xgselect.c: Add defined (HAVE_GSETTINGS).
5258 (xgselect_initialize): Ditto.
5260 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5261 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5264 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5266 * eval.c (struct backtrace): Simplify and port the data structure.
5267 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5268 signed bit field, as this assumption is not portable and it makes
5269 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5270 "char debug_on_exit : 1" as this is not portable either; instead,
5271 use the portable "unsigned int debug_on_exit : 1". Remove unused
5272 member evalargs. Remove obsolete comments about cc bombing out.
5274 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5276 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5277 Let HAVE_GSETTINGS override HAVE_GCONF.
5278 (store_monospaced_changed): New function.
5279 (EMACS_SETTINGS): A new type derived from GObject to handle
5280 GSettings notifications.
5281 (emacs_settings_constructor, emacs_settings_get_property)
5282 (emacs_settings_set_property, emacs_settings_class_init):
5284 (gsettings_client, gsettings_obj): New variables.
5285 (GSETTINGS_SCHEMA): New define.
5286 (something_changedCB): Call store_monospaced_changed.
5287 (init_gsettings): New function.
5288 (xsettings_initialize): Call init_gsettings.
5289 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5292 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5295 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5297 * window.c (resize_root_window, grow_mini_window)
5298 (shrink_mini_window): Rename Qresize_root_window to
5299 Qwindow_resize_root_window and Qresize_root_window_vertically to
5300 Qwindow_resize_root_window_vertically.
5302 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5304 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5306 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5308 * makefile.w32-in: Redesign dependencies so they reflect more
5309 clearly which files are directly included by each source file,
5310 and not through other includes.
5312 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5314 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5315 (sort_overlays, overlay_strings): When an overlay's clone number
5316 matches the window's clone number process the overlay even if
5317 the overlay's window property doesn't match the current window.
5319 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5320 (Fwindow_hchild): Rename to Fwindow_left_child.
5321 (Fwindow_next): Rename to Fwindow_next_sibling.
5322 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5323 (resize_window_check): Rename to window_resize_check.
5324 (resize_window_apply): Rename to window_resize_apply.
5325 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5326 (Fdelete_other_windows_internal, resize_frame_windows)
5327 (Fsplit_window_internal, Fdelete_window_internal)
5328 (grow_mini_window, shrink_mini_window)
5329 (Fresize_mini_window_internal): Fix callers accordingly.
5331 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5333 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5334 (emacs_fixed_set_min_size): Remove.
5335 (emacs_fixed_new): Take frame as argument.
5337 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5338 (_EmacsFixedPrivate): Remove minwidth/height.
5339 Add struct frame *f.
5340 (emacs_fixed_init): Initialize priv->f.
5341 (get_parent_class, emacs_fixed_set_min_size): Remove.
5342 (emacs_fixed_new): Set priv->f to argument.
5343 (emacs_fixed_get_preferred_width)
5344 (emacs_fixed_get_preferred_height): Use min_width/height from
5345 frames size_hint to set minimum and natural (Bug#8919).
5346 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5347 and use min_width/height from frames size_hint to set
5348 min_width/height (Bug#8919).
5350 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5351 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5354 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5356 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5357 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5360 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5362 * process.c (wait_reading_process_output): Bypass select if
5363 waiting for a cell while ignoring keyboard input, and input is
5364 pending. Suggested by Jan Djärv (Bug#8869).
5366 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5368 Use gnulib's dup2 module instead of rolling our own.
5369 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5371 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5373 * dispnew.c (scrolling_window): Before scrolling, turn off a
5374 mouse-highlight in the window being scrolled.
5376 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5378 Move DEFSYM to lisp.h and use everywhere.
5380 * character.h (DEFSYM): Move declaration...
5381 * lisp.h (DEFSYM): ...here.
5387 * w32select.c: Don't include character.h.
5389 * alloc.c (syms_of_alloc):
5390 * buffer.c (syms_of_buffer):
5391 * bytecode.c (syms_of_bytecode):
5392 * callint.c (syms_of_callint):
5393 * casefiddle.c (syms_of_casefiddle):
5394 * casetab.c (init_casetab_once):
5395 * category.c (init_category_once, syms_of_category):
5396 * ccl.c (syms_of_ccl):
5397 * cmds.c (syms_of_cmds):
5398 * composite.c (syms_of_composite):
5399 * dbusbind.c (syms_of_dbusbind):
5400 * dired.c (syms_of_dired):
5401 * dispnew.c (syms_of_display):
5402 * doc.c (syms_of_doc):
5403 * editfns.c (syms_of_editfns):
5404 * emacs.c (syms_of_emacs):
5405 * eval.c (syms_of_eval):
5406 * fileio.c (syms_of_fileio):
5407 * fns.c (syms_of_fns):
5408 * frame.c (syms_of_frame):
5409 * fringe.c (syms_of_fringe):
5410 * insdel.c (syms_of_insdel):
5411 * keymap.c (syms_of_keymap):
5412 * lread.c (init_obarray, syms_of_lread):
5413 * macros.c (syms_of_macros):
5414 * msdos.c (syms_of_msdos):
5415 * print.c (syms_of_print):
5416 * process.c (syms_of_process):
5417 * search.c (syms_of_search):
5418 * sound.c (syms_of_sound):
5419 * syntax.c (init_syntax_once, syms_of_syntax):
5420 * terminal.c (syms_of_terminal):
5421 * textprop.c (syms_of_textprop):
5422 * undo.c (syms_of_undo):
5423 * w32.c (globals_of_w32):
5424 * window.c (syms_of_window):
5425 * xdisp.c (syms_of_xdisp):
5426 * xfaces.c (syms_of_xfaces):
5427 * xfns.c (syms_of_xfns):
5428 * xmenu.c (syms_of_xmenu):
5429 * xsettings.c (syms_of_xsettings):
5430 * xterm.c (syms_of_xterm): Use DEFSYM.
5432 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5434 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5436 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5438 Integer and buffer overflow fixes (Bug#8873).
5440 * print.c (printchar, strout): Check for string overflow.
5441 (PRINTPREPARE, printchar, strout):
5442 Don't set size unless allocation succeeds.
5444 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5445 for sizes. Check for string overflow more accurately.
5446 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5448 * macros.c: Integer and buffer overflow fixes.
5449 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5450 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5451 Use ptrdiff_t, not int, for sizes.
5452 Don't increment bufsize until after realloc succeeds.
5453 Check for size-calculation overflow.
5454 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5456 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5458 * lread.c: Integer overflow fixes.
5459 (read_integer): Radix is now EMACS_INT, not int,
5460 to improve quality of diagnostics for out-of-range radices.
5461 Calculate buffer size correctly for out-of-range radices.
5462 (read1): Check for integer overflow in radices, and in
5463 read-circle numbers.
5464 (read_escape): Avoid int overflow.
5465 (Fload, openp, read_buffer_size, read1)
5466 (substitute_object_recurse, read_vector, read_list, map_obarray):
5467 Use ptrdiff_t, not int, for sizes.
5468 (read1): Use EMACS_INT, not int, for sizes.
5469 Check for size overflow.
5471 * image.c (cache_image): Check for size arithmetic overflow.
5473 * lread.c: Integer overflow issues.
5474 (saved_doc_string_size, saved_doc_string_length)
5475 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5476 Now ptrdiff_t, not int.
5477 (read1): Don't assume doc string length fits in int. Check for
5478 out-of-range doc string lengths.
5479 (read_list): Don't assume file position fits in int.
5480 (read_escape): Check for hex character overflow.
5482 2011-06-22 Leo Liu <sdl.web@gmail.com>
5484 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5485 Move to minibuffer.el.
5487 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5489 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5490 The following patches are for when GLYPH_DEBUG && !XASSERT.
5491 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5492 * dispnew.c (flush_stdout):
5493 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5494 Mark as externally visible.
5495 * dispnew.c (check_window_matrix_pointers): Now static.
5496 * dispnew.c (window_to_frame_vpos):
5497 * xfns.c (unwind_create_frame):
5498 * xterm.c (x_check_font): Remove unused local.
5499 * scroll.c (CHECK_BOUNDS):
5500 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5501 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5502 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5503 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5504 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5506 (debug_method_add): Use va_list and vsprintf rather than relying
5507 on undefined behavior with wrong number of arguments.
5508 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5509 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5510 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5511 since we're not interested in debugging glyphs with old libraries.
5512 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5513 GCC 4.6.0's static checking.
5515 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5517 Integer overflow and signedness fixes (Bug#8873).
5518 A few related buffer overrun fixes, too.
5520 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5522 * dispextern.h (struct face.stipple):
5523 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5524 (x_bitmap_mask, x_allocate_bitmap_record)
5525 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5526 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5527 (x_create_bitmap_from_xpm_data):
5528 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5529 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5531 * xfaces.c (load_pixmap):
5532 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5533 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5534 (.bitmaps_last, struct x_output.icon_bitmap):
5535 Use ptrdiff_t, not int, for bitmap indexes.
5536 (x_allocate_bitmap_record): Check for size overflow.
5537 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5539 Use ptrdiff_t, not int, for overlay counts.
5540 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5541 * editfns.c (overlays_around, get_pos_property):
5542 * textprop.c (get_char_property_and_overlay):
5543 * xdisp.c (next_overlay_change, note_mouse_highlight):
5544 * xfaces.c (face_at_buffer_position):
5545 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5546 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5547 (Fnext_overlay_change, Fprevious_overlay_change)
5548 (mouse_face_overlay_overlaps, Foverlays_in):
5549 Use ptrdiff_t, not int, for sizes.
5550 (overlays_at, overlays_in): Check for size-calculation overflow.
5552 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5554 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5555 (x_session_initialize): Do not assume string length fits in int.
5557 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5558 This is unlikely, but can occur if DPI is outlandish.
5560 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5561 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5563 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5564 * xrdb.c (magic_file_p, search_magic_path):
5565 Omit last arg SUFFIX; it was always 0. All callers changed.
5566 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5568 * xfont.c (xfont_match): Avoid need for strlen.
5570 * xfns.c: Don't assume strlen fits in int.
5571 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5573 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5574 not unsigned long, as we prefer signed integers. All callers changed.
5575 Detect integer overflow in repeat count.
5576 (message_dolog): Don't assume print length fits in 39 bytes.
5577 (display_mode_element): Don't assume strlen fits in int.
5579 * termcap.c: Don't assume sizes fit in int and never overflow.
5580 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5581 (gobble_line): Check for size-calculation overflow.
5583 * minibuf.c (Fread_buffer):
5584 * lread.c (intern, intern_c_string):
5585 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5586 Don't assume string length fits in int.
5588 * keyboard.c (parse_tool_bar_item):
5589 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5591 * font.c: Don't assume string length fits in int.
5592 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5593 Use ptrdiff_t, not int.
5594 (font_intern_prop): Don't assume string length fits in int.
5595 Don't assume integer property fits in fixnum.
5596 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5598 * filelock.c: Fix some buffer overrun and integer overflow issues.
5599 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5600 Reformulate so as not to need the command string.
5601 Invoke gzip -cd rather than gunzip, as it's more portable.
5602 (lock_info_type, lock_file_1, lock_file):
5603 Don't assume pid_t and time_t fit in unsigned long.
5604 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5605 (current_lock_owner): Prefer signed type for sizes.
5606 Use memcpy, not strncpy, where memcpy is what is really wanted.
5607 Don't assume (via atoi) that time_t and pid_t fit in int.
5608 Check for time_t and/or pid_t out of range, e.g., via a network share.
5609 Don't alloca where an auto var works fine.
5611 * fileio.c: Fix some integer overflow issues.
5612 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5613 Don't assume string length fits in int.
5614 (directory_file_name): Don't assume string length fits in long.
5615 (make_temp_name): Don't assume pid fits in int, or that its print
5616 length is less than 20.
5618 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5620 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5622 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5624 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5625 We prefer signed integers, even for size calculations.
5627 * emacs.c: Don't assume string length fits in 'int'.
5628 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5629 (main): Don't invoke strlen when not needed.
5631 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5632 (XD_DEBUG_MESSAGE): Don't waste a byte.
5634 * callproc.c (getenv_internal_1, getenv_internal)
5636 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5638 * lread.c (invalid_syntax): Omit length argument.
5639 All uses changed. This doesn't fix a bug, but it simplifies the
5640 code away from its former Hollerith-constant appearance, and it's
5641 one less 'int' to worry about when looking at integer-overflow issues.
5642 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5644 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5645 This didn't break anything, but it didn't help either.
5646 It's confusing to put a bogus integer in a place where the actual
5647 value does not matter.
5648 (LIST_END_P): Remove unused macro and its bogus comment.
5649 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5651 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5652 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5654 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5655 We prefer signed types, and the value cannot exceed the EMACS_INT
5656 range anyway (because otherwise the length would not be representable).
5657 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5658 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5659 This avoids a GCC warning when WIDE_EMACS_INT.
5661 * indent.c (sane_tab_width): New function.
5662 (current_column, scan_for_column, Findent_to, position_indentation)
5663 (compute_motion): Use it. This is just for clarity.
5664 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5666 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5668 * lisp.h (lint_assume): New macro.
5669 * composite.c (composition_gstring_put_cache):
5670 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5672 * editfns.c, insdel.c:
5673 Omit unnecessary forward decls, to simplify future changes.
5675 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5677 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5679 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5680 Use much-faster test for byte-length change.
5681 Don't assume string byte-length fits in 'int'.
5682 Check that character arg fits in 'int'.
5683 (mapcar1): Declare byte as byte, for clarity.
5685 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5687 * fns.c (concat): Catch string overflow earlier.
5688 Do not rely on integer wraparound.
5690 * dispextern.h (struct it.overlay_strings_charpos)
5691 (struct it.selective): Now EMACS_INT, not int.
5692 * xdisp.c (forward_to_next_line_start)
5693 (back_to_previous_visible_line_start)
5694 (reseat_at_next_visible_line_start, next_element_from_buffer):
5695 Don't arbitrarily truncate the value of 'selective' to int.
5697 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5699 * composite.c: Don't truncate sizes to 'int'.
5700 (composition_gstring_p, composition_reseat_it)
5701 (composition_adjust_point): Use EMACS_INT, not int.
5702 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5703 not EMACS_UINT, for indexes.
5705 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5707 * buffer.c: Include <verify.h>.
5708 (struct sortvec.priority, struct sortstr.priority):
5709 Now EMACS_INT, not int.
5710 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5711 (struct sortstr.size, record_overlay_string)
5712 (struct sortstrlist.size, struct sortlist.used):
5713 Don't truncate size to int.
5714 (record_overlay_string): Check for size-calculation overflow.
5715 (init_buffer_once): Check at compile-time, not run-time.
5717 2011-06-22 Jim Meyering <meyering@redhat.com>
5719 Don't leak an XBM-image-sized buffer
5720 * image.c (xbm_load): Free the image buffer after using it.
5722 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5725 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5726 that Sun C diagnosed.
5727 * fns.c (secure_hash): Fix pointer signedness issue.
5728 * intervals.c (static_offset_intervals): New function.
5729 (offset_intervals): Use it.
5731 2011-06-21 Leo Liu <sdl.web@gmail.com>
5734 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5737 * fns.c (secure_hash): Rename from crypto_hash_function and change
5738 the first arg to accept symbols.
5739 (Fsecure_hash): New primitive.
5740 (syms_of_fns): New symbols.
5742 2011-06-20 Deniz Dogan <deniz@dogan.se>
5744 * process.c (Fset_process_buffer): Clarify return value in
5747 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5749 * dispnew.c (add_window_display_history): Use BVAR.
5751 * xdisp.c (debug_method_add): Use BVAR.
5752 (check_window_end, dump_glyph_matrix, dump_glyph)
5753 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5755 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5758 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5759 check till after the cache is created in init_frame_faces.
5761 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5763 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5765 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5767 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5768 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5769 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5771 Improve buffer-overflow checking (Bug#8873).
5772 * fileio.c (Finsert_file_contents):
5773 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5774 Remove the old (too-loose) buffer overflow checks.
5775 They weren't needed, since make_gap checks for buffer overflow.
5776 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5777 The old code merely checked for Emacs fixnum overflow, and relied
5778 on undefined (wraparound) behavior. The new code avoids undefined
5779 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5781 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5782 Tune. Don't use wider integers than needed. Don't use alloca.
5783 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5785 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5787 * insdel.c, lisp.h (buffer_overflow): New function.
5788 (insert_from_buffer_1, replace_range, replace_range_2):
5789 * insdel.c (make_gap_larger):
5790 * editfns.c (Finsert_char):
5791 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5793 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5795 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5797 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5799 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5800 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5802 * fileio.c: Don't assume EMACS_INT fits in off_t.
5803 (emacs_lseek): New static function.
5804 (Finsert_file_contents, Fwrite_region): Use it.
5805 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5807 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5809 * fns.c: Don't overflow int when computing a list length.
5810 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5811 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5812 truncation on 64-bit hosts. Check for QUIT every
5813 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5814 faster and is responsive enough.
5815 (Flength): Report an error instead of overflowing an integer.
5816 (Fsafe_length): Return a float if the value is not representable
5817 as a fixnum. This shouldn't happen except in contrived situations.
5818 (Fnthcdr, Fsort): Don't assume list length fits in int.
5819 (Fcopy_sequence): Don't assume vector length fits in int.
5821 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5822 (header_size, word_size): New constants.
5823 (allocate_vectorlike): Don't check size overflow here.
5824 (allocate_vector): Check it here instead, since this is the only
5825 caller of allocate_vectorlike that could cause overflow.
5826 Check that the new vector's length is representable as a fixnum.
5828 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5829 The previous code was bogus. For example, next_almost_prime (32)
5830 returned 39, which is undesirable as it is a multiple of 3; and
5831 next_almost_prime (24) returned 25, which is a multiple of 5 so
5832 why was the code bothering to check for multiples of 7?
5834 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5836 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5838 Variadic C functions now count arguments with ptrdiff_t.
5839 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5840 Back then I didn't know that the Emacs coding style prefers signed int.
5841 Also, in the meantime I found a few more instances where arguments
5842 were being counted with int, which may truncate counts on 64-bit
5843 machines, or EMACS_INT, which may be unnecessarily wide.
5844 * lisp.h (struct Lisp_Subr.function.aMANY)
5845 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5846 Arg counts are now ptrdiff_t, not size_t.
5847 All variadic functions and their callers changed accordingly.
5848 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5849 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5850 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5851 * callint.c (Fcall_interactively): Check arg count for overflow,
5852 to avoid potential buffer overrun. Use signed char, not 'int',
5853 for 'varies' array, so that we needn't bother to check its size
5854 calculation for overflow.
5855 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5856 * eval.c (apply_lambda):
5857 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5858 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5859 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5861 * callint.c (Fcall_interactively): Don't use index var as event count.
5863 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5864 * mem-limits.h (SIZE): Remove; no longer used.
5866 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5868 Remove unnecessary casts.
5869 * xterm.c (x_term_init):
5870 * xfns.c (x_set_border_pixel):
5871 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5872 These aren't needed now that we assume ANSI C.
5874 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5875 It's more likely to cause problems (due to unsigned overflow)
5878 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5880 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5882 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5884 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5886 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5888 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5890 GLYPH_CODE_FACE returns EMACS_INT, not int.
5891 * dispextern.h (merge_faces):
5892 * xfaces.c (merge_faces):
5893 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5894 Don't assume EMACS_INT fits in int.
5896 * character.h (CHAR_VALID_P): Remove unused parameter.
5897 * fontset.c, lisp.h, xdisp.c: All uses changed.
5899 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5901 * fns.c (concat): Minor tuning based on overflow analysis.
5902 This doesn't fix any bugs. Use int to hold character, instead
5903 of constantly refetching from Emacs object. Use XFASTINT, not
5904 XINT, for value known to be a character. Don't bother comparing
5905 a single byte to 0400, as it's always less.
5907 * floatfns.c (Fexpt):
5908 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5910 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5913 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5915 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5916 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5917 incorrectly succeed when S was a string, because 4294967386 was
5918 truncated before it was used.
5920 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5921 Otherwise, an out-of-range integer could cause undefined behavior
5924 * composite.c: Use int, not EMACS_INT, for characters.
5925 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5926 EMACS_INT, for values that are known to be in character range.
5927 This doesn't fix any bugs but is the usual style inside Emacs and
5928 may generate better code on 32-bit machines.
5930 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5931 This is for reasons similar to the recent CHAR_STRING fix.
5932 * charset.c (Fencode_char): Check that character arg is actually
5933 a character. Pass an int to ENCODE_CHAR.
5934 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5935 wider than 'int', as a compile-time check to prevent future regressions
5938 * character.c (char_string): Remove unnecessary casts.
5940 Make sure a 64-bit char is never passed to CHAR_STRING.
5941 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5942 by silently ignoring the top 32 bits, allowing some values
5943 that were far too large to be valid characters.
5944 * character.h: Include <verify.h>.
5945 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5946 arguments are no wider than unsigned, as a compile-time check
5947 to prevent future regressions in this area.
5949 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5950 (Fsubst_char_in_region):
5952 * xdisp.c (decode_mode_spec_coding):
5953 Adjust to CHAR_STRING's new requirement.
5954 * editfns.c (Finsert_char, Fsubst_char_in_region):
5955 * fns.c (concat): Check that character args are actually
5956 characters. Without this test, these functions did the wrong
5957 thing with wildly out-of-range values on 64-bit hosts.
5959 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5960 These casts should not be needed on 32-bit hosts, either.
5961 * keyboard.c (read_char):
5962 * lread.c (Fload): Remove casts to unsigned.
5964 * lisp.h (UNSIGNED_CMP): New macro.
5965 This fixes comparison bugs on 64-bit hosts.
5966 (ASCII_CHAR_P): Use it.
5967 * casefiddle.c (casify_object):
5968 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5969 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5970 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5971 * dispextern.h (FACE_FROM_ID):
5972 * keyboard.c (read_char): Use UNSIGNED_CMP.
5974 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5975 not to EMACS_INT, to avoid GCC warning.
5977 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5979 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5980 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5981 isn't needed on 32-bit machines.
5983 * buffer.c (Fgenerate_new_buffer_name):
5984 Use EMACS_INT for count, not int.
5985 (advance_to_char_boundary): Return EMACS_INT, not int.
5987 * data.c (Qcompiled_function): Now static.
5989 * window.c (window_body_lines): Now static.
5991 * image.c (gif_load): Rename local to avoid shadowing.
5993 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5994 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5995 * alloc.c (make_save_value): Integer argument is now of type
5997 (mark_object): Use ptrdiff_t, not int.
5998 * lisp.h (pD): New macro.
5999 * print.c (print_object): Use it.
6001 * alloc.c: Use EMACS_INT, not int, to count objects.
6002 (total_conses, total_markers, total_symbols, total_vector_size)
6003 (total_free_conses, total_free_markers, total_free_symbols)
6004 (total_free_floats, total_floats, total_free_intervals)
6005 (total_intervals, total_strings, total_free_strings):
6006 Now EMACS_INT, not int. All uses changed.
6007 (Fgarbage_collect): Compute overall total using a double, so that
6008 integer overflow is less likely to be a problem. Check for overflow
6009 when converting back to an integer.
6010 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6011 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6012 These were 'int' variables that could overflow on 64-bit hosts;
6013 they were never used, so remove them instead of repairing them.
6014 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6015 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6016 Previously, this ceilinged at INT_MAX, but that doesn't work on
6018 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6020 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6021 (allocate_vectorlike): Check for ptrdiff_t overflow.
6022 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6023 when a (possibly-narrower) signed value would do just as well.
6024 We prefer using signed arithmetic, to avoid comparison confusion.
6026 * alloc.c: Catch some string size overflows that we were missing.
6027 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6028 for convenience in STRING_BYTES_MAX.
6029 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6030 The definition here is exact; the one in lisp.h was approximate.
6031 (allocate_string_data): Check for string overflow. This catches
6032 some instances we weren't catching before. Also, it catches
6033 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6034 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6035 and ptrdiff_t and EMACS_INT are both 64 bits.
6037 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6038 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6039 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
6041 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6043 * alloc.c (Fmake_string): Check for out-of-range init.
6045 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6047 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6049 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6051 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6052 xg_get_default_scrollbar_width.
6054 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6055 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6056 (style_changed_cb): Call update_theme_scrollbar_width and call
6057 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6058 all frames (Bug#8505).
6059 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6060 Call gtk_window_set_resizable if HAVE_GTK3.
6061 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6062 and height if HAVE_GTK3 (Bug#8505).
6063 (scroll_bar_width_for_theme): New variable.
6064 (update_theme_scrollbar_width): New function.
6065 (xg_get_default_scrollbar_width): Move code to
6066 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6067 (xg_initialize): Call update_theme_scrollbar_width.
6069 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6071 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6073 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6075 * frame.c (make_frame): Call other_buffer_safely instead of
6078 * window.c (temp_output_buffer_show): Call display_buffer with
6079 second argument Vtemp_buffer_show_specifiers and reset latter
6080 immediately after the call.
6081 (Vtemp_buffer_show_specifiers): New variable.
6082 (auto_window_vscroll_p, next_screen_context_lines)
6083 (Vscroll_preserve_screen_position): Remove leading asterisks from
6086 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6088 Fix minor problems found by GCC 4.6.0 static checking.
6089 * buffer.c (Qclone_number): Remove for now, as it's unused.
6090 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6091 (record_buffer): Remove unused local.
6092 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6093 (set_frame_buffer_list): Remove; unused.
6094 * frame.h (other_visible_frames): Remove decl.
6095 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6096 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6097 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6099 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6100 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6101 Define only if HAVE_GPM.
6102 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6103 (update_hints_inhibit): Remove; never set. All uses removed.
6104 * widgetprv.h (emacsFrameClassRec): Remove decl.
6105 * window.c (delete_deletable_window): Now returns void, since it
6106 wasn't returning anything.
6107 (compare_window_configurations): Remove unused locals.
6108 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6109 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6110 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6111 the same widths as pointers. This follows up on the 2011-05-06 patch.
6112 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6113 * xterm.h: Likewise.
6114 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6116 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6118 * makefile.w32-in: Update dependencies.
6119 (LISP_H): Add lib/intprops.h.
6121 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6123 * image.c (gif_load): Add animation frame delay to the metadata.
6124 (syms_of_image): Use DEFSYM. New symbol `delay'.
6126 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6128 * window.c (delete_deletable_window): Re-add.
6129 (Fset_window_configuration): Rewrite to handle dead buffers and
6130 consequently deletable windows.
6131 (window_tree, Fwindow_tree): Remove. Supply functionality in
6133 (compare_window_configurations): Simplify code.
6135 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6137 * image.c (imagemagick_load_image): Fix type mismatch.
6138 (Fimagemagick_types): Likewise.
6140 * window.h (replace_buffer_in_windows): Declare.
6142 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6144 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6145 Qclone_number. Remove external declaration of Qdelete_window.
6146 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6148 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6149 Run Qbuffer_list_update_hook if allowed.
6150 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6151 buffer list implementation.
6152 (other_buffer_safely): New function.
6153 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6154 calls to replace_buffer_in_windows and
6155 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6157 (record_buffer): Inhibit quitting and rewrite using quittable
6158 functions. Run Qbuffer_list_update_hook if allowed.
6159 (Frecord_buffer, Funrecord_buffer): New functions.
6160 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6161 Move switch-to-buffer to window.el.
6162 (bury-buffer): Move to window.el.
6163 (Vbuffer_list_update_hook): New variable.
6165 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6168 * window.h (resize_frame_windows): Move up in code.
6169 (Fwindow_frame): Remove EXFUN.
6170 (replace_buffer_in_all_windows): Remove prototype.
6171 (replace_buffer_in_windows_safely): Add prototype.
6173 * window.c: Declare Qdelete_window static again. Move down
6174 declaration of select_count.
6175 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6176 (Fother_window): Move to window.el.
6177 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6178 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6179 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6181 (replace_buffer_in_windows): Implement by calling
6182 Qreplace_buffer_in_windows.
6183 (replace_buffer_in_all_windows): Remove with some functionality
6184 moved into replace_buffer_in_windows_safely.
6185 (replace_buffer_in_windows_safely): New function.
6186 (select_window_norecord, select_frame_norecord): Move in front
6187 of run_window_configuration_change_hook. Remove now obsolete
6189 (Fset_window_buffer): Rewrite doc-string.
6190 Call Qrecord_window_buffer.
6191 (keys_of_window): Move binding for other-window to window.el.
6193 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6195 * dispextern.h (struct image): Replace data member, whose int_val
6196 and ptr_val fields were not used by anything, with a single
6199 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6200 (gif_clear_image, gif_load, imagemagick_load_image)
6201 (gs_clear_image, gs_load): Callers changed.
6203 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6205 * buffer.h: Include <time.h>, for time_t.
6206 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6208 Fix minor problems found by static checking.
6210 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6212 Make identifiers static if they are not used in other modules.
6213 * data.c (Qcompiled_function, Qframe, Qvector):
6214 * image.c (QimageMagick, Qsvg):
6215 * minibuf.c (Qmetadata):
6216 * window.c (resize_window_check, resize_root_window): Now static.
6217 * window.h (resize_window_check, resize_root_window): Remove decls.
6219 * window.c (window_deletion_count, delete_deletable_window):
6221 (window_body_lines): Now static.
6222 (Fdelete_other_windows_internal): Mark vars as initialized.
6223 Make sure 'resize_failed' is initialized.
6224 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6225 (resize_window_apply): Remove unused local.
6226 * window.h (delete_deletable_window): Remove decl.
6228 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6229 (imagemagick_load_image): Fix pointer signedness problem by changing
6230 last arg from unsigned char * to char *. All uses changed.
6231 Also, fix a local for similar reasons.
6232 Remove unused locals. Remove locals to avoid shadowing.
6233 (fn_rsvg_handle_free): Remove; unused.
6234 (svg_load, svg_load_image): Fix pointer signedness problem.
6235 (imagemagick_load_image): Don't use garbage pointer image_wand.
6237 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6239 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6241 * image.c (gif_load): Fix omitted cast error introduced by
6244 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6246 * window.h (resize_proportionally, orig_total_lines)
6247 (orig_top_line): Remove from window structure.
6248 (set_window_height, set_window_width, change_window_heights)
6249 (Fdelete_window): Remove prototypes.
6250 (resize_frame_windows): Remove duplicate declaration.
6252 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6254 * window.h (resize_frame_windows, resize_window_check)
6255 (delete_deletable_window, resize_root_window)
6256 (resize_frame_windows): Declare prototypes.
6258 * window.c (resize_window_apply): Make definition be "static" to
6259 match the prototype.
6261 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6263 * window.c: Remove declarations of Qwindow_size_fixed,
6264 window_min_size_1, window_min_size_2, window_min_size,
6265 size_window, window_fixed_size_p, enlarge_window, delete_window.
6266 Remove static from declaration of Qdelete_window, it's
6267 temporarily needed by Fbury_buffer.
6268 (replace_window): Don't assign orig_top_line and
6270 (Fdelete_window, delete_window): Remove. Window deletion is
6271 handled by window.el.
6272 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6273 Replace Fdelete_window calls with calls to Qdelete_window.
6274 (Fdelete_other_windows): Remove. Deleting other windows is
6275 handled by window.el.
6276 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6277 handled in window.el.
6278 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6279 Window minimum sizes are handled in window.el.
6280 (shrink_windows, size_window, set_window_height)
6281 (set_window_width, change_window_heights, window_height)
6282 (window_width, CURBEG, CURSIZE, enlarge_window)
6283 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6284 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6285 handled in window.el.
6286 (make_dummy_parent): Rename to make_parent_window and give it a
6287 second argument horflag.
6288 (make_window): Don't set resize_proportionally any more.
6289 (Fsplit_window): Remove. Windows are split in window.el.
6290 (save_restore_action, save_restore_orig_size)
6291 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6292 Resize mini windows in window.el.
6293 (grow_mini_window, shrink_mini_window): Implement by calling
6294 Qresize_root_window_vertically, resize_window_check and
6295 resize_window_apply.
6296 (saved_window, Fset_window_configuration, save_window_save):
6297 Do not handle orig_top_line, orig_total_lines, and
6298 resize_proportionally.
6299 (window_min_height, window_min_width): Move to window.el.
6300 (keys_of_window): Move bindings for delete-other-windows,
6301 split-window, delete-window and enlarge-window to window.el.
6303 * buffer.c: Temporarily extern Qdelete_window.
6304 (Fbury_buffer): Temporarily call Qdelete_window instead of
6305 Fdelete_window (Fbury_buffer will move to window.el soon).
6307 * frame.c (set_menu_bar_lines_1): Remove code handling
6308 orig_top_line and orig_total_lines.
6310 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6311 set_window_height but set heights directly.
6312 (change_frame_size_1): Use resize_frame_windows.
6314 * xdisp.c (init_xdisp): Don't use set_window_height but set
6317 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6318 Use resize_frame_windows instead of change_window_heights and run
6319 run_window_configuration_change_hook.
6321 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6322 instead of change_window_heights and run
6323 run_window_configuration_change_hook.
6325 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6327 * window.c (replace_window): Rename second argument REPLACEMENT to
6328 NEW. New third argument SETFLAG. Rewrite.
6329 (delete_window, make_dummy_parent): Call replace_window with
6331 (window_list_1): Move down in code.
6332 (run_window_configuration_change_hook): Move set_buffer part
6333 before select_frame_norecord part in order to unwind correctly.
6334 Rename count1 to count.
6335 (recombine_windows, delete_deletable_window, resize_root_window)
6336 (Fdelete_other_windows_internal)
6337 (Frun_window_configuration_change_hook, make_parent_window)
6338 (resize_window_check, resize_window_apply, Fresize_window_apply)
6339 (resize_frame_windows, Fsplit_window_internal)
6340 (Fdelete_window_internal, Fresize_mini_window_internal):
6342 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6344 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6346 * window.h (window): Add some new members to window structure -
6347 normal_lines, normal_cols, new_total, new_normal, clone_number,
6348 splits, nest, prev_buffers, next_buffers.
6349 (WINDOW_TOTAL_SIZE): Move here from window.c.
6350 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6352 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6354 (make_dummy_parent): Set new members of windows structure.
6355 (make_window): Move down in code. Handle new members of window
6357 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6358 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6359 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6360 (Fset_window_prev_buffers, Fwindow_next_buffers)
6361 (Fset_window_next_buffers, Fset_window_clone_number):
6363 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6364 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6366 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6367 Argument WINDOW can be now internal window too.
6368 (Fwindow_use_time): Move up in code.
6369 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6371 (Fset_window_configuration, saved_window)
6372 (Fcurrent_window_configuration, save_window_save): Handle new
6373 members of window structure.
6374 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6375 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6376 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6377 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6378 Qget_mru_window, Qresize_root_window,
6379 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6380 Qauto_buffer_name; staticpro them.
6382 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6384 * window.c (Fwindow_total_size, Fwindow_left_column)
6385 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6386 (Fwindow_list_1): New functions.
6387 (window_box_text_cols): Replace with window_body_cols.
6388 (Fwindow_width, Fscroll_left, Fscroll_right):
6389 Use window_body_cols instead of window_box_text_cols.
6390 (delete_window, Fset_window_configuration):
6391 Call delete_all_subwindows with window as argument.
6392 (delete_all_subwindows): Take a window as argument and not a
6394 (window_loop): Remove handling of GET_LRU_WINDOW and
6396 (Fget_lru_window, Fget_largest_window): Move to window.el.
6398 * window.h: Extern window_body_cols instead of
6399 window_box_text_cols. delete_all_subwindows now takes a
6400 Lisp_Object as argument.
6402 * indent.c (compute_motion, Fcompute_motion):
6403 Use window_body_cols instead of window_box_text_cols.
6405 * frame.c (delete_frame): Call delete_all_subwindows with root
6408 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6410 * fns.c (Fputhash): Document return value.
6412 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6414 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6416 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6418 Cons<->int and similar integer overflow fixes (Bug#8794).
6420 Check for overflow when converting integer to cons and back.
6421 * charset.c (Fdefine_charset_internal, Fdecode_char):
6422 Use cons_to_unsigned to catch overflow.
6423 (Fencode_char): Use INTEGER_TO_CONS.
6424 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6425 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6426 * data.c (long_to_cons, cons_to_long): Remove.
6427 (cons_to_unsigned, cons_to_signed): New functions.
6428 These signal an error for invalid or out-of-range values.
6429 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6430 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6431 * font.c (Ffont_variation_glyphs):
6432 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6433 * lisp.h: Include <intprops.h>.
6434 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6435 (cons_to_signed, cons_to_unsigned): New decls.
6436 (long_to_cons, cons_to_long): Remove decls.
6437 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6438 (Fprimitive_undo): Use CONS_TO_INTEGER.
6439 * xfns.c (Fx_window_property): Likewise.
6440 * xselect.c: Include <limits.h>.
6441 (x_own_selection, selection_data_to_lisp_data):
6442 Use INTEGER_TO_CONS.
6443 (x_handle_selection_request, x_handle_selection_clear)
6444 (x_get_foreign_selection, Fx_disown_selection_internal)
6445 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6446 (lisp_data_to_selection_data): Use cons_to_unsigned.
6447 (x_fill_property_data): Use cons_to_signed.
6448 Report values out of range.
6450 Check for buffer and string overflow more precisely.
6451 * buffer.h (BUF_BYTES_MAX): New macro.
6452 * lisp.h (STRING_BYTES_MAX): New macro.
6453 * alloc.c (Fmake_string):
6454 * character.c (string_escape_byte8):
6455 * coding.c (coding_alloc_by_realloc):
6456 * doprnt.c (doprnt):
6457 * editfns.c (Fformat):
6459 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6460 since they may not be the same number.
6461 * editfns.c (Finsert_char):
6462 * fileio.c (Finsert_file_contents):
6463 Likewise for BUF_BYTES_MAX.
6465 * image.c: Use ptrdiff_t, not int, for sizes.
6466 (slurp_file): Switch from int to ptrdiff_t.
6468 (slurp_file): Check that file size fits in both size_t (for
6469 malloc) and ptrdiff_t (for sanity and safety).
6471 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6472 if b->modtime has its maximal value.
6474 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6476 Don't assume time_t can fit into int.
6477 * buffer.h (struct buffer.modtime): Now time_t, not int.
6478 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6479 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6481 Minor fixes for signed vs unsigned integers.
6482 * character.h (MAYBE_UNIFY_CHAR):
6483 * charset.c (maybe_unify_char):
6484 * keyboard.c (read_char, reorder_modifiers):
6485 XINT -> XFASTINT, since the integer must be nonnegative.
6486 * ftfont.c (ftfont_spec_pattern):
6487 * keymap.c (access_keymap, silly_event_symbol_error):
6488 XUINT -> XFASTINT, since the integer must be nonnegative.
6489 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6490 since it makes no difference and we prefer signed.
6491 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6492 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6495 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6497 * window.h (Fwindow_frame): Declare.
6499 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6501 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6502 (SPARE_MEMORY): Always define.
6503 (LARGE_REQUEST): Remove.
6504 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6506 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6508 * lisp.h: Move EXFUNS for Fframe_root_window,
6509 Fframe_first_window and Fset_frame_selected_window to window.h.
6511 * window.h: Move EXFUNS for Fframe_root_window,
6512 Fframe_first_window and Fset_frame_selected_window here from
6515 * frame.c (Fwindow_frame, Fframe_first_window)
6516 (Fframe_root_window, Fframe_selected_window)
6517 (Fset_frame_selected_window): Move to window.c.
6518 (Factive_minibuffer_window): Move to minibuf.c.
6519 (Fother_visible_frames_p): New function.
6521 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6523 * window.c (decode_window, decode_any_window): Move up in code.
6524 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6525 (inhibit_frame_unsplittable): Remove unused variable.
6526 (Fwindow_buffer): Move up and rewrite doc-string.
6527 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6528 (Fwindow_prev): New functions.
6529 (Fwindow_frame): Move here from frame.c. Accept any window as
6531 (Fframe_root_window, Fframe_first_window)
6532 (Fframe_selected_window): Move here from frame.c. Accept frame
6533 or arbitrary window as argument. Update doc-strings.
6534 (Fminibuffer_window): Move up in code.
6535 (Fwindow_minibuffer_p): Move up in code and simplify.
6536 (Fset_frame_selected_window): Move here from frame.c.
6538 (Fselected_window, select_window, Fselect_window): Move up in
6539 code. Minor doc-string fixes.
6541 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6543 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6544 Do not assume that spare memory exists; that assumption is valid
6545 only if SYSTEM_MALLOC.
6546 (LARGE_REQUEST): New macro, so that the issue of large requests
6547 is separated from the issue of spare memory.
6549 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6551 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6554 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6556 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6559 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6561 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6563 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6565 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6566 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6568 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6570 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6572 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6574 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6575 (x_clipboard_manager_save): Add return value.
6576 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6578 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6579 Obey Vx_select_enable_clipboard_manager. Catch errors in
6580 x_clipboard_manager_save (Bug#8779).
6581 (Vx_select_enable_clipboard_manager): New variable.
6582 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6584 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6586 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6588 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6590 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6591 in the current matrix if keep_current_p is non-zero.
6593 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6595 * bidi.c (bidi_level_of_next_char): Fix last change.
6597 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6599 Support bidi reordering of text covered by display properties.
6601 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6602 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6603 (bidi_cache_search, bidi_cache_iterator_state)
6604 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6605 (bidi_level_of_next_char, bidi_move_to_visually_next):
6606 Support character positions inside a run of characters covered by a
6608 (bidi_paragraph_init, bidi_resolve_explicit_1)
6609 (bidi_level_of_next_char): Call bidi_fetch_char and
6610 bidi_fetch_char_advance instead of FETCH_CHAR and
6612 (bidi_init_it): Initialize new members.
6613 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6615 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6616 instead of using explicit *_CHAR codes.
6617 (bidi_resolve_explicit, bidi_resolve_weak):
6618 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6619 bidirectional text is supported only in multibyte buffers.
6620 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6621 it to initialize the frame_window_p member of struct bidi_it.
6622 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6623 (bidi_resolve_explicit, bidi_resolve_weak)
6624 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6625 bidi_it->nchars is non-positive.
6626 (bidi_level_of_next_char): Don't try to lookup the cache for the
6627 next/previous character if nothing is cached there yet, or if we
6628 were just reseat()'ed to a new position.
6630 * xdisp.c (set_cursor_from_row): Set start and stop points
6631 according to the row's direction when priming the loop that looks
6632 for the glyph on which to display cursor.
6633 (single_display_spec_intangible_p): Function deleted.
6634 (display_prop_intangible_p): Reimplement to call
6635 handle_display_spec instead of single_display_spec_intangible_p.
6636 Accept 3 additional arguments needed by handle_display_spec.
6637 This fixes incorrect cursor motion across display property with complex
6638 values: lists, `(when COND...)' forms, etc.
6639 (single_display_spec_string_p): Support property values that are
6640 lists with the argument STRING its top-level element.
6641 (display_prop_string_p): Fix the condition for processing a
6642 property that is a list to be consistent with handle_display_spec.
6643 (handle_display_spec): New function, refactored from the
6644 last portion of handle_display_prop.
6645 (compute_display_string_pos): Accept additional argument
6646 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6647 value of a `display' property is a "replacing spec".
6648 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6649 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6650 the display property, but just return a value indicating whether
6651 the display property will replace the characters it covers.
6652 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6653 frame_window_p members of struct bidi_it.
6654 (compute_display_string_pos, compute_display_string_end):
6656 (push_it): Accept second argument POSITION, where pop_it should
6657 jump to continue iteration.
6658 (reseat_1): Initialize bidi_it.disp_pos.
6660 * keyboard.c (adjust_point_for_property): Adjust the call to
6661 display_prop_intangible_p to its new signature.
6663 * dispextern.h (struct bidi_it): New member frame_window_p.
6664 (bidi_init_it): Update prototypes.
6665 (display_prop_intangible_p): Update prototype.
6666 (compute_display_string_pos, compute_display_string_end):
6668 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6671 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6673 Malloc failure behavior now depends on size of allocation.
6674 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6675 * lisp.h: Change signatures accordingly.
6676 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6677 All callers changed. (Bug#8762)
6679 * gnutls.c: Use Emacs's memory allocators.
6680 Without this change, the gnutls library would invoke malloc etc.
6681 directly, which causes problems on non-SYNC_INPUT hosts, and which
6682 runs afoul of improving memory_full behavior. (Bug#8761)
6683 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6684 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6685 xfree instead of the default malloc, realloc, free.
6686 (Fgnutls_boot): No need to check for memory allocation failure,
6687 since xmalloc does that for us.
6689 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6690 * category.c (hash_get_category_set):
6691 * ccl.c (ccl_driver):
6692 * charset.c (Fdefine_charset_internal):
6693 * charset.h (struct charset.hash_index):
6694 * composite.c (get_composition_id, gstring_lookup_cache)
6695 (composition_gstring_put_cache):
6696 * composite.h (struct composition.hash_index):
6697 * dispextern.h (struct image.hash):
6698 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6699 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6700 (hashfn_equal, hashfn_user_defined, make_hash_table)
6701 (maybe_resize_hash_table, hash_lookup, hash_put)
6702 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6703 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6704 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6705 * image.c (make_image, search_image_cache, lookup_image)
6706 (xpm_put_color_table_h):
6707 * lisp.h (struct Lisp_Hash_Table):
6708 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6709 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6710 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6711 * alloc.c (allocate_vectorlike):
6712 Check for overflow in vector size calculations.
6713 * ccl.c (ccl_driver):
6714 Check for overflow when converting EMACS_INT to int.
6715 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6716 need to be updated by these changes.
6717 * fns.c (make_hash_table, maybe_resize_hash_table):
6718 Check for integer overflow with large hash tables.
6719 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6720 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6721 (SXHASH_REDUCE): New macro.
6722 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6723 Use it instead of discarding useful hash info with large hash values.
6724 (sxhash_float): New function.
6725 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6726 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6727 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6728 Rewrite to use FIXNUM_BITS, as this simplifies things.
6729 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6730 Adjust signatures to match updated version of code.
6731 (consing_since_gc): Now EMACS_INT, since a single hash table can
6732 use more than INT_MAX bytes.
6734 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6736 Make it possible to build with GCC-4.6+ -O2 -flto.
6738 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6740 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6742 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6743 Call minibuffer-inactive-mode.
6745 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6747 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6748 Update dependencies.
6750 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6752 * data.c (init_data): Remove code for UTS, this system is not
6755 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6757 Don't force ./temacs to start in terminal mode.
6759 * frame.c (make_initial_frame): Initialize faces in all cases, not
6760 only when CANNOT_DUMP is defined.
6761 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6763 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6765 * dispnew.c (add_window_display_history): Use const for the string
6766 pointer. Remove declaration, not needed.
6768 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6770 Use 'inline', not 'INLINE'.
6771 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6772 * alloc.c, fontset.c (INLINE): Remove.
6773 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6774 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6775 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6776 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6777 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6779 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6781 Make it possible to run ./temacs.
6783 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6784 syms_of_callproc does the same thing. Remove test for
6785 "initialized", do it in the caller.
6786 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6788 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6790 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6791 (read_minibuf): Use get_minibuffer.
6792 (syms_of_minibuf): Use DEFSYM.
6793 (Qmetadata): New var.
6794 * data.c (Qbuffer): Don't make it static.
6795 (syms_of_data): Use DEFSYM.
6797 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6799 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6800 (CCL_CODE_MIN): New macro.
6802 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6804 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6806 * eval.c (Qdebug): Now static.
6807 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6808 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6809 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6811 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6813 * image.c: Various fixes to ImageMagick code comments.
6814 (Fimagemagick_types): Doc fix.
6816 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6818 Minor fixes prompted by GCC 4.6.0 warnings.
6820 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6822 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6823 (x_clipboard_manager_save_all): Move extern decl to ...
6824 * xterm.h: ... here, so that it can be checked for consistency.
6826 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6828 * xselect.c (x_clipboard_manager_save_frame)
6829 (x_clipboard_manager_save_all): New functions.
6830 (Fx_clipboard_manager_save): Lisp function deleted.
6832 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6833 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6835 * xterm.h: Update prototype.
6837 2011-05-28 William Xu <william.xwl@gmail.com>
6839 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6842 2011-05-28 Jim Meyering <meyering@redhat.com>
6844 Avoid a sign-extension bug in crypto_hash_function.
6845 * fns.c (to_uchar): Define.
6846 (crypto_hash_function): Use it to convert some newly-signed
6847 variables to unsigned, to avoid sign-extension bugs. For example,
6848 without this change, (md5 "truc") would evaluate to
6849 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6850 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6851 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6853 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6855 Integer overflow fixes.
6857 * dbusbind.c: Serial number integer overflow fixes.
6858 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6859 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6860 to hold a serial number that is too large for a fixnum.
6861 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6862 Check for serial numbers out of range. Decode any serial number
6863 that was so large that it became a float. (Bug#8722)
6865 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6866 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6867 Use XFASTINT rather than XUINT when numbers are nonnegative.
6868 (xd_append_arg, Fdbus_method_return_internal):
6869 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6870 arguments, check that Lisp number is nonnegative, rather than
6871 silently wrapping negative numbers around. (Bug#8722)
6872 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6875 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6877 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6879 ccl: Add integer overflow checks.
6880 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6881 (IN_INT_RANGE): New macros.
6882 (ccl_driver): Use them to check for integer overflow when
6883 decoding a CCL program. Many of the new checks are whether XINT (x)
6884 fits in int; it doesn't always, on 64-bit hosts. The new version
6885 doesn't catch all possible integer overflows, but it's an
6886 improvement. (Bug#8719)
6888 * alloc.c (make_event_array): Use XINT, not XUINT.
6889 There's no need for unsigned here.
6891 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6892 This follows up to the 2011-05-06 change that substituted uintptr_t
6893 for EMACS_INT. This case wasn't caught back then.
6895 Rework Fformat to avoid integer overflow issues.
6896 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6897 now (part of C89). Include <verify.h>.
6898 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6899 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6900 (Fformat): Avoid the prepass trying to compute sizes; it was only
6901 approximate and thus did not catch overflow reliably. Instead, walk
6902 through the format just once, formatting and computing sizes as we go,
6903 checking for integer overflow at every step, and allocating a larger
6904 buffer as needed. Keep track separately whether the format is
6905 multibyte. Keep only the most-recently calculated precision, rather
6906 than them all. Record whether each argument has been converted to
6907 string. Use EMACS_INT, not int, for byte and char and arg counts.
6908 Support field widths and precisions larger than INT_MAX. Avoid
6909 sprintf's undefined behavior with conversion specifications such as %#d
6910 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6911 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6912 formatting out-of-range floating point numbers with int
6915 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6917 * data.c: Avoid integer truncation in expressions involving floats.
6918 * data.c: Include <intprops.h>.
6919 (arith_driver): When there's an integer overflow in an expression
6920 involving floating point, convert the integers to floating point
6921 so that the resulting value does not suffer from catastrophic
6922 integer truncation. For example, on a 64-bit host (* 4
6923 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6924 Do not rely on undefined behavior after integer overflow.
6926 merge count_size_as_multibyte, parse_str_to_multibyte
6927 * character.c, character.h (count_size_as_multibyte):
6928 Rename from parse_str_to_multibyte; all uses changed.
6929 Check for integer overflow.
6930 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6931 since it's now a duplicate of the other. This is more of
6932 a character than a buffer op, so better that it's in character.c.
6933 * fns.c, print.c: Adjust to above changes.
6935 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6937 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6939 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6941 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6942 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6943 (x_clipboard_manager_save): Now static.
6944 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6946 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6947 (crypto_hash_function): Now static.
6948 Fix pointer signedness problems. Avoid unnecessary initializations.
6950 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6952 * termhooks.h (Vselection_alist): Make it terminal-local.
6954 * terminal.c (create_terminal): Initialize it.
6956 * xselect.c: Support for clipboard managers.
6957 (Vselection_alist): Move to termhooks.h as terminal-local var.
6958 (LOCAL_SELECTION): New macro.
6959 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6960 (symbol_to_x_atom): Remove gratuitous arg.
6961 (x_handle_selection_request, lisp_data_to_selection_data)
6962 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6963 (x_own_selection, x_get_local_selection, x_convert_selection):
6964 New arg, specifying work frame. Use terminal-local Vselection_alist.
6965 (some_frame_on_display): Delete unused function.
6966 (Fx_own_selection_internal, Fx_get_selection_internal)
6967 (Fx_disown_selection_internal, Fx_selection_owner_p)
6968 (Fx_selection_exists_p): New optional frame arg.
6969 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6970 (x_handle_selection_clear): Don't treat other terminals with the
6971 same keyboard specially. Use the terminal-local Vselection_alist.
6972 (x_clear_frame_selections): Use Frun_hook_with_args.
6974 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6976 * xterm.h: Add support for those atoms.
6978 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6980 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6981 (converted_selections, conversion_fail_tag): New global variables.
6982 (x_selection_request_lisp_error): Free the above.
6983 (x_get_local_selection): Remove unnecessary code.
6984 (x_reply_selection_request): Args changed; handle arbitrary array
6985 of converted selections stored in converted_selections.
6986 Separate the XChangeProperty and SelectionNotify steps.
6987 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6988 (x_convert_selection): New function.
6989 (x_handle_selection_event): Simplify.
6990 (x_get_foreign_selection): Don't ignore incoming requests while
6991 waiting for an answer; this will fail when we implement
6992 SAVE_TARGETS, and seems unnecessary anyway.
6993 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6994 (Vx_sent_selection_functions): Doc fix.
6996 2011-05-26 Leo Liu <sdl.web@gmail.com>
6998 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7000 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7002 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7004 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7005 for fringe update if it has periodic bitmap.
7006 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7007 and fringe_bitmap_periodic_p.
7009 * fringe.c (get_fringe_bitmap_data): New function.
7010 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7011 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7012 row. Mark glyph row for fringe update if periodicity changed.
7014 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7015 for fringe update unless it has periodic bitmap.
7017 2011-05-25 Kenichi Handa <handa@m17n.org>
7019 * xdisp.c (get_next_display_element): Set correct it->face_id for
7020 a static composition.
7022 2011-05-24 Leo Liu <sdl.web@gmail.com>
7025 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7027 * fns.c (crypto_hash_function, Fsha1): New function.
7028 (Fmd5): Use crypto_hash_function.
7029 (syms_of_fns): Add Ssha1.
7031 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7033 * gnutls.c: Remove unused macros.
7034 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7035 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7036 Remove macros that are defined and never used.
7037 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7039 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7041 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7042 (Fx_get_selection_internal): Minor cleanup.
7043 (Fx_own_selection_internal): Rename arguments for consistency with
7046 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7048 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7050 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7052 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7054 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7056 * dispnew.c (scrolling_window): Don't exclude the case that the
7057 last enabled row in the desired matrix touches the bottom boundary.
7059 2011-05-21 Glenn Morris <rgm@gnu.org>
7061 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7062 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7063 and add some more files.
7065 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7067 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7068 report_file_error introduced by the change from 2011-05-07.
7070 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7072 * systime.h (Time): Define only if emacs is defined.
7073 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7074 where the include path doesn't have X11/X.h by default. See
7075 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7077 2011-05-20 Kenichi Handa <handa@m17n.org>
7079 * composite.c (find_automatic_composition): Fix previous change.
7081 2011-05-20 Glenn Morris <rgm@gnu.org>
7083 * lisp.mk: New file, split from Makefile.in.
7084 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7085 (shortlisp): Remove.
7086 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7088 2011-05-19 Glenn Morris <rgm@gnu.org>
7090 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7091 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7092 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7093 (lisp): Set the order to that of loadup.el.
7094 (shortlisp): Make it a copy of $lisp.
7095 (SOME_MACHINE_LISP): Remove.
7096 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7097 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7099 2011-05-18 Kenichi Handa <handa@m17n.org>
7101 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7102 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7103 (find_automatic_composition): Mostly rewrite for efficiency.
7105 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7107 * makefile.w32-in: Update dependencies.
7109 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7111 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7112 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7114 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7116 Fix some integer overflow issues, such as string length overflow.
7118 * insdel.c (count_size_as_multibyte): Check for string overflow.
7120 * character.c (lisp_string_width): Check for string overflow.
7121 Use EMACS_INT, not int, for string indexes and lengths; in
7122 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7123 the resulting string length overflows an EMACS_INT; instead,
7124 report a string overflow if no precision given. When checking for
7125 precision exhaustion, use a check that cannot possibly have
7126 integer overflow. (Bug#8675)
7127 * character.h (lisp_string_width): Adjust to new signature.
7129 * alloc.c (string_overflow): New function.
7130 (Fmake_string): Use it. This doesn't change behavior, but saves
7131 a few bytes and will simplify future changes.
7132 * character.c (string_escape_byte8): Likewise.
7133 * lisp.h (string_overflow): New decl.
7135 Fixups, following up to the user-interface timestamp change.
7136 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7137 for UI timestamps, instead of unsigned long.
7138 * msdos.c (mouse_get_pos): Likewise.
7139 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
7140 * w32gui.h (Time): Define by including "systime.h" rather than by
7141 declaring it ourselves. (Bug#8664)
7143 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7144 * image.c (clear_image_cache): Likewise.
7146 * term.c (term_mouse_position): Don't assume time_t wraparound.
7148 Be more systematic about user-interface timestamps.
7149 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7150 and sometimes 'EMACS_UINT', to represent these timestamps.
7151 This change causes it to use 'Time' uniformly, as that's what X uses.
7152 This makes the code easier to follow, and makes it easier to catch
7153 integer overflow bugs such as Bug#8664.
7154 * frame.c (Fmouse_position, Fmouse_pixel_position):
7155 Use Time, not unsigned long, for user-interface timestamps.
7156 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7157 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7158 * keyboard.h (last_event_timestamp): Likewise.
7159 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7160 * menu.h (xmenu_show): Likewise.
7161 * term.c (term_mouse_position): Likewise.
7162 * termhooks.h (struct input_event.timestamp): Likewise.
7163 (struct terminal.mouse_position_hook): Likewise.
7164 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7165 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7166 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7167 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7169 * menu.h, termhooks.h: Include "systime.h", for Time.
7171 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7172 Don't assume that the difference between two unsigned long values
7173 can fit into an integer. At this point, we know button_down_time
7174 <= event->timestamp, so the difference must be nonnegative, so
7175 there's no need to cast the result if double-click-time is
7176 nonnegative, as it should be; check that it's nonnegative, just in
7177 case. This bug is triggered when events are more than 2**31 ms
7178 apart (about 25 days). (Bug#8664)
7180 * xselect.c (last_event_timestamp): Remove duplicate decl.
7181 (x_own_selection): Remove needless cast to unsigned long.
7183 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7184 that always fit in int. Use a sentinel instead of a counter, to
7185 avoid a temp and to allay GCC's concerns about possible int overflow.
7186 * frame.h (struct frame): Use int for menu_bar_items_used
7187 instead of EMACS_INT, since it always fits in int.
7189 * menu.c (grow_menu_items): Check for int overflow.
7191 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7193 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7194 Before, the code was not consistent. These values cannot exceed
7195 2**31 - 1 so there's no need to make them unsigned.
7196 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7197 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7198 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7200 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7202 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7203 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7204 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7205 presumably because the widths might not match.
7207 * window.c (size_window): Avoid needless test at loop start.
7209 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7211 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7213 2011-05-12 Drew Adams <drew.adams@oracle.com>
7215 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7217 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7219 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7220 `width' to `bar_area_x' and `bar_area_width', respectively.
7221 (x_scroll_run): Take account of fringe background extension.
7223 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7224 Rename local vars `left' and `width' to `bar_area_x' and
7225 `bar_area_width', respectively.
7226 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7227 background extension.
7229 2011-05-10 Jim Meyering <meyering@redhat.com>
7231 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7233 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7235 * image.c (Finit_image_library): Return t for built-in image types,
7236 like pbm and xbm. (Bug#8640)
7238 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7240 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7242 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7244 * w32console.c (Fset_screen_color): Doc fix.
7245 (Fget_screen_color): New function.
7246 (syms_of_ntterm): Defsubr it.
7248 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7249 unlink the temporary file if Fcall_process didn't create it in the
7251 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7252 child process will be redirected to a file specified with `:file'.
7253 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7254 cue to call_process_cleanup not to close that handle.
7256 2011-05-07 Ben Key <bkey76@gmail.com>
7258 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7259 one of two shell specific rules, either bootstrap-temacs-CMD or
7260 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7261 to the previous implementation of the bootstrap-temacs rule.
7262 The bootstrap-temacs-CMD rule is similar to the previous
7263 implementation of the bootstrap-temacs rule except that it
7264 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7267 These changes, along with some changes to nt/configure.bat,
7268 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7269 earlier fix to add support for --cflags and --ldflags options
7270 that include quotes so that it works whether make uses cmd or
7273 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7275 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7276 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7278 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7279 a string. Handle both cases.
7280 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7281 (Fdbus_register_method): Use Qinvalid_function.
7283 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7285 * makefile.w32-in: Update dependencies.
7286 (LISP_H): Add inttypes.h and stdin.h.
7287 (PROCESS_H): Add unistd.h.
7289 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7291 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7292 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7294 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7296 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7298 * term.c (vfatal): Remove stray call to va_end.
7299 It's not needed and the C Standard doesn't allow it here anyway.
7301 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7302 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7304 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7307 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7309 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7311 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7313 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7315 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7317 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7318 * charset.c (Fdefine_charset_internal): Don't initialize
7319 charset.code_space[15]. The value was garbage, on hosts with
7320 32-bit int (Bug#8600).
7322 * lread.c (read_integer): Be more consistent with string-to-number.
7323 Use string_to_number to do the actual conversion; this avoids
7324 rounding errors and fixes some other screwups. Without this fix,
7325 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7326 (digit_to_number): Move earlier, for benefit of read_integer.
7327 Return -1 if the digit is out of range for the base, -2 if it is
7328 not a digit in any supported base. (Bug#8602)
7330 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7332 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7333 to match comment at start of function. This also removes a
7334 GCC warning about overflow in a 32+64-bit port.
7336 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7338 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7339 Reported by Stefan Monnier in
7340 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7341 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7342 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7344 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7345 (EMACS_UINTPTR): Likewise, with uintptr_t.
7347 * lisp.h: Prefer 64-bit EMACS_INT if available.
7348 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7349 on 32-bit hosts that have 64-bit int, so that they can access
7351 However, temporarily disable this change unless the temporary
7352 symbol WIDE_EMACS_INT is defined.
7354 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7356 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7357 This removes an assumption that EMACS_INT and long are the same
7358 width as pointers. The assumption is true for Emacs porting targets
7359 now, but we want to make other targets possible.
7360 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7361 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7362 In the rest of the code, change types of integers that hold casted
7363 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7364 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7365 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7366 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7367 No need to cast type when ORing.
7368 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7369 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7370 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7371 assume EMACS_INT is the same width as char *.
7372 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7373 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7374 Remove no-longer-needed casts.
7375 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7376 (xg_tool_bar_help_callback, xg_make_tool_item):
7377 Use EMACS_INTPTR to hold an integer
7378 that will be cast to void *; this can avoid a GCC warning
7379 if EMACS_INT is not the same width as void *.
7380 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7381 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7382 (current_message_1, set_message_1):
7383 Use a local to convert to proper width without a cast.
7384 * xmenu.c (dialog_selection_callback): Likewise.
7386 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7387 Also, don't assume VALBITS / RAND_BITS is less than 5,
7388 and don't rely on undefined behavior when shifting a 1 left into
7390 * lisp.h (get_random): Change signature to match.
7392 * lread.c (hash_string): Use size_t, not int, for hash computation.
7393 Normally we prefer signed values; but hashing is special, because
7394 it's better to use unsigned division on hash table sizes so that
7395 the remainder is nonnegative. Also, size_t is the natural width
7396 for hashing into memory. The previous code used 'int', which doesn't
7397 retain enough info to hash well into very large tables.
7398 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7400 * dbusbind.c: Don't possibly lose pointer info when converting.
7401 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7402 Use XPNTR rather than XHASH, so that the high-order bits of
7403 the pointer aren't lost when converting through void *.
7405 * eval.c (Fautoload): Don't double-shift a pointer.
7407 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7409 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7411 * gnutls.c (DEF_GNUTLS_FN):
7412 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7414 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7416 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7419 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7421 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7422 New version that can reserve upto 2GB of heap space.
7424 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7426 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7428 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7430 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7431 `gnutls_certificate_set_x509_key_file'.
7433 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7435 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7436 Update dependencies.
7438 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7440 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7441 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7442 Remove unused parameter `fildes'.
7443 * process.c (read_process_output, send_process): Don't pass it.
7445 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7447 Fix previous change: the library cache is defined in w32.c.
7448 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7449 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7451 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7453 Implement dynamic loading of GnuTLS on Windows.
7455 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7456 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7457 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7460 * gnutls.c (Qgnutls_dll): Define.
7461 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7462 (gnutls_*): Declare function pointers.
7463 (init_gnutls_functions): New function to initialize function pointers.
7464 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7465 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7466 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7467 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7468 (emacs_gnutls_write, emacs_gnutls_read)
7469 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7470 (Fgnutls_available_p): New function.
7471 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7472 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7473 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7475 * image.c: Include w32.h.
7476 (Vimage_type_cache): Delete.
7477 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7478 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7479 (w32_delayed_load): Move to w32.c.
7481 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7483 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7484 (w32_delayed_load): Move from image.c. When loading a library, record
7485 its filename in the :loaded-from property of the library id.
7486 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7487 Initialize and staticpro them.
7488 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7490 * process.c: Include lisp.h before w32.h, not after.
7491 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7492 instead of gnutls_record_check_pending.
7494 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7496 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7498 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7499 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7502 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7504 * xterm.c (x_set_frame_alpha): Do not set property on anything
7505 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7507 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7509 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7511 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7513 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7514 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7515 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7516 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7517 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7518 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7519 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7520 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7521 (Qgnutls_bootprop_callbacks_verify): Make static.
7523 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7525 * callproc.c: Indentation fixup.
7527 * sysdep.c (wait_for_termination_1): Make static.
7528 (wait_for_termination, interruptible_wait_for_termination):
7529 Move after wait_for_termination_1.
7531 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7533 * sysdep.c (interruptible_wait_for_termination): New function
7534 which is like wait_for_termination, but allows keyboard
7537 * callproc.c (Fcall_process): Add (:file "file") as an option for
7539 (Fcall_process_region): Ditto.
7541 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7543 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7544 rather than `XVECTOR (FOO)->size'.
7546 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7547 inttypes.h, as a gnulib replacement is used if it not available in
7550 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7552 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7553 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7554 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7556 * coding.c (coding_alloc_by_realloc): Error out if destination
7557 will grow beyond MOST_POSITIVE_FIXNUM.
7558 (decode_coding_emacs_mule): Abort if there isn't enough place in
7559 charbuf for the composition carryover bytes. Reserve an extra
7560 space for up to 2 characters produced in a loop.
7561 (decode_coding_iso_2022): Abort if there isn't enough place in
7562 charbuf for the composition carryover bytes.
7564 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7566 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7567 aborting when %lld or %lll format is passed.
7568 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7569 %llo or %llx format is passed. (Bug#8545)
7571 * window.c (window_scroll_line_based): Use a marker instead of
7572 simple variables to record original value of point. (Bug#7952)
7574 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7575 produced by %s or %c overflows available buffer space. (Bug#8545)
7577 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7579 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7580 (SIZE_MAX): Move defn after all includes, as they might #define it.
7582 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7584 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7586 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7588 * keyboard.c (Qdelayed_warnings_hook): Define.
7589 (command_loop_1): Run `delayed-warnings-hook'
7590 if Vdelayed_warnings_list is non-nil.
7591 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7592 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7594 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7596 * doprnt.c (doprnt): Don't return value smaller than the buffer
7597 size if the message was truncated. (Bug#8545).
7599 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7601 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7602 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7604 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7606 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7608 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7610 * makefile.w32-in: Update dependencies.
7612 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7614 Improve `doprnt' and its usage. (Bug#8545)
7615 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7616 `format_end'. Remove support for %l as a conversion specifier.
7617 Don't use xrealloc. Improve diagnostics when the %l size modifier
7618 is used. Update the commentary.
7620 * eval.c (verror): Simplify calculation of size_t.
7622 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7625 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7627 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7630 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7632 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7633 This makes this file independent of the recent pseudovector change.
7635 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7637 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7639 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7640 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7641 Remove unused local.
7642 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7644 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7645 GCC 4.6.0 optimizes based on type-based alias analysis.
7646 For example, if b is of type struct buffer * and v of type struct
7647 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7648 != &v->size, and therefore "v->size = 1; b->size = 2; return
7649 v->size;" must therefore return 1. This assumption is incorrect
7650 for Emacs, since it type-puns struct Lisp_Vector * with many other
7651 types. To fix this problem, this patch adds a new type struct
7652 vectorlike_header that documents the constraints on layout of vectors
7653 and pseudovectors, and helps optimizing compilers not get fooled
7654 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7655 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7656 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7658 (XSETPVECTYPE): Rewrite in terms of new macro.
7659 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7660 This is a bit clearer, and further avoids the possibility of
7661 undesirable aliasing.
7662 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7663 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7664 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7665 since Lisp_Subr is a special case (no "next" field).
7666 (ASIZE): Now uses header.size rather than size.
7667 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7668 to avoid the hassle of writing XVECTOR (foo)->header.size.
7669 (struct vectorlike_header): New type.
7670 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7671 object, to help avoid aliasing.
7672 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7673 (SUBRP): Likewise, since Lisp_Subr is a special case.
7674 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7675 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7676 (struct Lisp_Hash_Table): Combine first two members into a single
7677 struct vectorlike_header member. All uses of "size" and "next" members
7678 changed to be "header.size" and "header.next".
7679 * buffer.h (struct buffer): Likewise.
7680 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7681 * frame.h (struct frame): Likewise.
7682 * process.h (struct Lisp_Process): Likewise.
7683 * termhooks.h (struct terminal): Likewise.
7684 * window.c (struct save_window_data, struct saved_window): Likewise.
7685 * window.h (struct window): Likewise.
7686 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7687 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7688 * buffer.c (init_buffer_once): Likewise.
7689 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7691 * process.c (Fformat_network_address): Use local var for size,
7694 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7696 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7697 * data.c (atof): Remove decl; no longer used or needed.
7698 (digit_to_number): Move to lread.c.
7699 (Fstring_to_number): Use new string_to_number function, to be
7700 consistent with how the Lisp reader treats infinities and NaNs.
7701 Do not assume that floating-point numbers represent EMACS_INT
7702 without losing information; this is not true on most 64-bit hosts.
7703 Avoid double-rounding errors, by insisting on integers when
7704 parsing non-base-10 numbers, as the documentation specifies.
7705 * lisp.h (string_to_number): New decl, replacing ...
7706 (isfloat_string): Remove.
7707 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7708 (read1): Do not accept +. and -. as integers; this
7709 appears to have been a coding error. Similarly, do not accept
7710 strings like +-1e0 as floating point numbers. Do not report
7711 overflow for integer overflows unless the base is not 10 which
7712 means we have no simple and reliable way to continue.
7713 Break out the floating-point parsing into a new
7714 function string_to_number, so that Fstring_to_number parses
7715 floating point numbers consistently with the Lisp reader.
7716 (digit_to_number): Move here from data.c. Make it static inline.
7717 (E_CHAR, EXP_INT): Remove, replacing with ...
7718 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7719 (string_to_number): New function, replacing isfloat_string.
7720 This function checks for valid syntax and produces the resulting
7721 Lisp float number too. Rework it so that string-to-number
7722 no longer mishandles examples like "1.0e+". Use strtoumax,
7723 so that overflow for non-base-10 numbers is reported only when
7724 there's no portable and simple way to convert to floating point.
7726 * textprop.c (set_text_properties_1): Rewrite for clarity,
7727 and to avoid GCC warning about integer overflow.
7729 * intervals.h (struct interval): Use EMACS_INT for members
7730 where EMACS_UINT might cause problems. See
7731 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7732 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7733 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7735 (offset_intervals): Tell GCC not to worry about length overflow
7736 when negating a negative length.
7738 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7739 (overrun_check_free): Likewise.
7741 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7742 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7745 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7746 (gnutls_make_error): Rename local to avoid shadowing.
7747 (gnutls_emacs_global_deinit): ifdef out; not used.
7748 (Fgnutls_boot): Use const for pointer to readonly storage.
7749 Comment out unused local. Fix pointer signedness problems.
7751 * lread.c (openp): Don't stuff size_t into an 'int'.
7752 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7753 about possible signed overflow.
7755 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7756 (GDK_KEY_g): Don't define if already defined.
7757 (xg_prepare_tooltip): Avoid pointer signedness problem.
7758 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7760 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7761 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7763 * xfns.c (Fx_window_property): Simplify a bit,
7764 to make a bit faster and to avoid GCC 4.6.0 warning.
7765 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7767 * fns.c (internal_equal): Don't assume size_t fits in int.
7769 * alloc.c (compact_small_strings): Tighten assertion a little.
7771 Replace pEd with more-general pI, and fix some printf arg casts.
7772 * lisp.h (pI): New macro, generalizing old pEd macro to other
7773 conversion specifiers. For example, use "...%"pI"d..." rather
7774 than "...%"pEd"...".
7775 (pEd): Remove. All uses replaced with similar uses of pI.
7776 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7777 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7778 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7779 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7780 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7781 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7782 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7784 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7785 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7786 * print.c (safe_debug_print, print_object): Likewise.
7787 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7789 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7790 avoiding the 0 flag, which is not portable.
7791 * process.c (Fmake_network_process): Use pI to avoid cast.
7792 * region-cache.c (pp_cache): Likewise.
7793 * xdisp.c (decode_mode_spec): Likewise.
7794 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7795 behavior on 64-bit hosts with printf arg.
7796 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7797 (x_stop_queuing_selection_requests): Likewise.
7798 (x_get_window_property): Don't truncate byte count to an 'int'
7801 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7802 here, since it parses constructs like leading '-' and spaces,
7803 which are not wanted; and it overflows with large numbers.
7804 Instead, simply match F[0-9]+, which is what is wanted anyway.
7806 * alloc.c: Remove unportable assumptions about struct layout.
7807 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7808 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7809 (allocate_vectorlike, make_pure_vector): Use the new macros,
7810 plus offsetof, to remove unportable assumptions about struct layout.
7811 These assumptions hold on all porting targets that I know of, but
7812 they are not guaranteed, they're easy to remove, and removing them
7813 makes further changes easier.
7815 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7816 This doesn't fix a bug but makes the code clearer.
7817 (string_overrun_cookie): Now const. Use initializers that
7818 don't formally overflow signed char, to avoid warnings.
7819 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7820 can cause Emacs to crash when string overrun checking is enabled.
7821 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7822 multiple of sizeof (EMACS_INT); it need not be, if
7823 alignof(EMACS_INT) < sizeof (EMACS_INT).
7824 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7826 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7828 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7830 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7832 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7833 supposed to be handshaking. (Bug#8556)
7834 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7836 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7838 * lisp.h (Qdebug): List symbol.
7839 * eval.c (Qdebug): Restore global linkage.
7840 * keyboard.c (debug-on-event): New variable.
7841 (handle_user_signal): Break into debugger when debug-on-event
7842 matches the current signal symbol.
7844 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7846 * alloc.c (check_sblock, check_string_bytes)
7847 (check_string_free_list): Convert to standard C.
7849 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7851 * w32.c (emacs_gnutls_push): Fix typo.
7853 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7855 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7856 "cast to pointer from integer of different size".
7858 Improve doprnt and its use in verror. (Bug#8545)
7859 * doprnt.c (doprnt): Document the set of format control sequences
7860 supported by the function. Use SAFE_ALLOCA instead of always
7863 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7864 is one byte too soon. Don't use xrealloc; instead xfree and
7867 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7869 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7872 * gnutls.c: Renamed global_initialized to
7873 gnutls_global_initialized. Added internals for the
7874 :verify-hostname-error, :verify-error, and :verify-flags
7875 parameters of `gnutls-boot' and documented those parameters in the
7876 docstring. Start callback support.
7877 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7878 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7879 on error. Return error code.
7880 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7881 (emacs_gnutls_read): Likewise.
7882 (Fgnutls_boot): Return handshake error code.
7883 (emacs_gnutls_handle_error): New function.
7884 (wsaerror_to_errno): Likewise.
7886 * w32.h (emacs_gnutls_pull): Add prototype.
7887 (emacs_gnutls_push): Likewise.
7889 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7890 (emacs_gnutls_push): Likewise.
7892 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7894 * process.c (wait_reading_process_output): Check if GnuTLS
7895 buffered some data internally if no FDs are set for TLS
7898 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7899 (LIBS): Link to USER_LIBS.
7900 ($(BLD)/gnutls.$(0)): New target.
7902 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7904 * xdisp.c (handle_single_display_spec): Rename the
7905 display_replaced_before_p argument into display_replaced_p, to
7906 make it consistent with the commentary. Fix typos in the
7909 * textprop.c (syms_of_textprop): Remove dead code.
7910 (copy_text_properties): Delete obsolete commentary about an
7911 interface that was deleted long ago. Fix typos in the description
7914 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7915 to changes in oldXMenu/XMenu.h from 2011-04-16.
7916 <menu_help_message, prev_menu_help_message>: Constify.
7917 (IT_menu_make_room): menu->help_text is now `const char **';
7920 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7921 to changes in oldXMenu/XMenu.h from 2011-04-16.
7922 (struct XMenu): Declare `help_text' `const char **'.
7924 * xfaces.c <Qunspecified>: Make extern again.
7926 * syntax.c: Include sys/types.h before including regex.h, as
7929 * doc.c (get_doc_string): Improve the format passed to `error'.
7931 * doprnt.c (doprnt): Improve commentary.
7933 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7935 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7938 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7939 changes in globals.h immediately force recompilation.
7940 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7941 $(CURDIR)/s/ms-w32.h.
7942 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7944 * character.c (Fchar_direction): Function deleted.
7945 (syms_of_character): Don't defsubr it.
7946 <char-direction-table>: Deleted.
7948 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7950 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7951 * doprnt.c: Include limits.h.
7952 (SIZE_MAX): New macro.
7953 (doprnt): Return a size_t value. 2nd arg is now size_t.
7954 Many local variables are now size_t instead of int or unsigned.
7955 Improve overflow protection. Support `l' modifier for integer
7956 conversions. Support %l conversion. Don't assume an EMACS_INT
7957 argument for integer conversions and for %c.
7959 * lisp.h (doprnt): Restore prototype.
7961 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7964 * Makefile.in (base_obj): Add back doprnt.o.
7966 * deps.mk (doprnt.o): Add back prerequisites.
7967 (callint.o): Depend on character.h.
7969 * eval.c (internal_lisp_condition_case): Include the handler
7970 representation in the error message.
7971 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7972 when breaking from the loop.
7974 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7976 * callint.c (Fcall_interactively): When displaying error message
7977 about invalid control letter, pass the character's codepoint, not
7978 a pointer to its multibyte form. Improve display of the character
7979 in octal and display also its hex code.
7981 * character.c (char_string): Use %x to display the (unsigned)
7982 codepoint of an invalid character, to avoid displaying a bogus
7985 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7986 `error', not SYMBOL_NAME itself.
7988 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7989 character arguments to `error'.
7991 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7992 to `error' in error message about FINAL_CHAR argument. Make sure
7993 FINAL_CHAR is a character, and use %c when it is passed as
7994 argument to `error'.
7996 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7998 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8000 * w32.c: Include <time.h>.
8001 (sys_localtime): New function.
8003 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
8005 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8007 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8009 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8011 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8014 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8016 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8017 gl_state.e_property when gl_state.object is Qt.
8019 * insdel.c (make_gap_larger): Remove limitation of buffer size
8022 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8024 * xdisp.c (lookup_glyphless_char_display)
8025 (produce_glyphless_glyph): Handle cons cell entry in
8026 glyphless-char-display.
8027 (Vglyphless_char_display): Document it.
8029 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8030 glyphless-char-display.
8032 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8034 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8036 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8038 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8039 definition for no-X builds.
8041 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
8043 Static checks with GCC 4.6.0 and non-default toolkits.
8045 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8047 * process.c (keyboard_bit_set): Define only if SIGIO.
8048 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8049 (send_process): Repair possible setjmp clobbering.
8051 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8053 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8055 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8057 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8058 Define only if needed.
8060 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8061 by pacifying GCC about it. Maybe it's time to retire it?
8062 * xfaces.c (USG, __TIMEVAL__): Likewise.
8064 * dispextern.h (struct redisplay_interface): Rename param
8066 * termhooks.h (struct terminal): Likewise.
8067 * xterm.c (xembed_send_message): Likewise.
8069 * insdel.c (make_gap_smaller): Define only if
8070 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8072 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8075 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8076 so that we aren't warned about unused symbols.
8078 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8080 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8082 * xfns.c (x_real_positions): Mark locals as initialized.
8084 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8086 * xterm.c: Fix problems found by static analysis with other toolkits.
8087 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8088 (x_dispatch_event): Declare static if USE_GTK, and
8089 define if USE_GTK || USE_X_TOOLKIT.
8090 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8091 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8092 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8093 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8095 * xmenu.c (menu_help_callback): Pointer type fixes.
8096 Use const pointers when pointing at readonly data. Avoid pointer
8098 (FALSE): Remove unused macro.
8099 (update_frame_menubar): Remove unused decl.
8101 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8103 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8104 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8105 (single_menu_item): Rename local to avoid shadowing.
8107 * keyboard.c (make_lispy_event): Remove unused local var.
8109 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8110 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8112 * bitmaps: Change bitmaps from unsigned char back to the X11
8113 compatible char. Avoid the old compiler warnings about
8114 out-of-range initializers by using, for example, '\xab' rather
8117 * xgselect.c (xgselect_initialize): Check vs interface
8118 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8120 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8122 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8123 to read-only memory.
8125 * fns.c (vector): Remove; this old hack is no longer needed.
8127 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
8129 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
8131 * xrdb.c (x_load_resources): Omit unused local.
8133 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8134 (x_window): Rename locals to avoid shadowing.
8135 (USG): Use the kludged USG macro, to pacify gcc.
8137 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
8138 (x_term_init): Remove local to avoid shadowing.
8140 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
8142 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8143 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8145 2011-04-16 Eli Zaretskii <eliz@gnu.org>
8147 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8149 Fix regex.c, syntax.c and friends for buffers > 2GB.
8150 * syntax.h (struct gl_state_s): Declare character position members
8153 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8155 * textprop.c (verify_interval_modification, interval_of):
8156 Declare arguments EMACS_INT.
8158 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8161 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8163 * indent.c (Fvertical_motion): Local variable it_start is now
8166 * regex.c (re_match, re_match_2, re_match_2_internal)
8167 (bcmp_translate, regcomp, regexec, print_double_string)
8168 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8169 (re_compile_pattern, re_exec): Declare arguments and local
8170 variables `size_t' and `ssize_t' and return values `regoff_t', as
8172 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8173 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8174 <compile_stack_type>: `size' and `avail' are now `size_t'.
8176 * regex.h <regoff_t>: Use ssize_t, not int.
8177 (re_search, re_search_2, re_match, re_match_2): Arguments that
8178 specify buffer/string position and length are now ssize_t and
8179 size_t. Return type is regoff_t.
8181 2011-04-16 Ben Key <bkey76@gmail.com>
8183 * nsfont.m: Fixed bugs in ns_get_family and
8184 ns_descriptor_to_entity that were caused by using free to
8185 deallocate memory blocks that were allocated by xmalloc (via
8186 xstrdup). This caused Emacs to crash when compiled with
8187 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8188 --enable-checking=xmallocoverrun). xfree is now used to
8189 deallocate these memory blocks.
8191 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8193 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8195 emacs_write: Accept and return EMACS_INT for sizes.
8196 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8198 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8199 Accept and return EMACS_INT.
8200 (emacs_gnutls_write): Return the number of bytes written on
8202 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8203 (emacs_read, emacs_write): Remove check for negative size, as the
8204 Emacs source code has been audited now.
8205 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8206 (emacs_read, emacs_write): Use it.
8207 * process.c (send_process): Adjust to the new signatures of
8208 emacs_write and emacs_gnutls_write. Do not attempt to store
8209 a byte offset into an 'int'; it might overflow.
8210 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8212 * sound.c: Don't assume sizes fit in 'int'.
8213 (struct sound_device.period_size, alsa_period_size):
8214 Return EMACS_INT, not int.
8215 (struct sound_device.write, vox_write, alsa_write):
8216 Accept EMACS_INT, not int.
8217 (wav_play, au_play): Use EMACS_INT to store sizes and to
8218 record read return values.
8220 2011-04-15 Ben Key <bkey76@gmail.com>
8222 * keyboard.c (Qundefined): Don't declare static since it is used
8224 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8225 static since they are used in nsfont.m.
8227 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8229 * process.c (Qprocessp): Don't declare static.
8230 * lisp.h (Qprocessp): Declare again.
8232 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8234 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8236 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8238 Improve C-level modularity by making more things 'static'.
8240 Don't publish debugger-only interfaces to other modules.
8241 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8242 (verify_bytepos, count_markers): Move decls to the only modules
8244 * region-cache.h (pp_cache): Likewise.
8245 * window.h (check_all_windows): Likewise.
8246 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8248 * sysdep.c (croak): Now static, if
8249 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8250 * syssignal.h (croak): Declare only if not static.
8252 * alloc.c (refill_memory_reserve): Now static if
8253 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8254 * lisp.h (refill_memory_reserve): Declare only if not static.
8256 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8257 Define only if USE_LUCID.
8259 * xrdb.c (x_customization_string, x_rm_string): Now static.
8261 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8262 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8264 * xdisp.c (draw_row_with_mouse_face): Now static.
8265 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8267 * window.h (check_all_windows): Mark externally visible.
8269 * window.c (window_deletion_count): Now static.
8271 * undo.c: Make symbols static if they're not exported.
8272 (last_undo_buffer, last_boundary_position, pending_boundary):
8275 * textprop.c (interval_insert_behind_hooks): Now static.
8276 (interval_insert_in_front_hooks): Likewise.
8278 * term.c: Make symbols static if they're not exported.
8279 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8280 (max_frame_lines, tty_set_terminal_modes):
8281 (tty_reset_terminal_modes, tty_turn_off_highlight):
8282 (get_tty_terminal): Now static.
8283 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8284 * termhooks.h (term_mouse_moveto): Do not declare if
8286 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8287 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8289 * sysdep.c: Make symbols static if they're not exported.
8290 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8292 (sigprocmask_set, full_mask): Remove; unused.
8293 (wait_debugging): Mark as visible.
8294 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8295 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8297 * syntax.c (syntax_temp): Define only if !__GNUC__.
8299 * sound.c (current_sound_device, current_sound): Now static.
8301 * search.c (searchbufs, searchbuf_head): Now static.
8303 * scroll.c (scroll_cost): Remove; unused.
8304 * dispextern.h (scroll_cost): Remove decl.
8306 * region-cache.h (pp_cache): Mark as externally visible.
8308 * process.c: Make symbols static if they're not exported.
8309 (process_tick, update_tick, create_process, chan_process):
8310 (Vprocess_alist, proc_buffered_char, datagram_access):
8311 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8312 (deactivate_process): Mark defn as static, as well as decl.
8313 * lisp.h (create_process): Remove decl.
8314 * process.h (chan_process, Vprocess_alist): Remove decls.
8316 * print.c: Make symbols static if they're not exported.
8317 (print_depth, new_backquote_output, being_printed, print_buffer):
8318 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8319 (print_interval, print_number_index, initial_stderr_stream):
8321 * lisp.h (Fprinc): Remove decl.
8322 (debug_output_compilation_hack): Mark as externally visible.
8324 * sysdep.c (croak): Move decl from here to syssignal.h.
8325 * syssignal.h (croak): Put it here, so the API can be checked when
8326 'croak' is called from dissociate_if_controlling_tty.
8328 * minibuf.c: Make symbols static if they're not exported.
8329 (minibuf_save_list, choose_minibuf_frame): Now static.
8330 * lisp.h (choose_minibuf_frame): Remove decl.
8332 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8334 * lread.c: Make symbols static if they're not exported.
8335 (read_objects, initial_obarray, oblookup_last_bucket_number):
8337 (make_symbol): Remove; unused.
8338 * lisp.h (initial_obarray, make_symbol): Remove decls.
8340 * keyboard.c: Make symbols static if they're not exported.
8341 (single_kboard, recent_keys_index, total_keys, recent_keys):
8342 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8343 (this_single_command_key_start, echoing, last_auto_save):
8344 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8345 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8346 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8347 (Vlispy_mouse_stem, double_click_count):
8349 (force_auto_save_soon): Define only if SIGDANGER.
8350 (ignore_mouse_drag_p): Now static if
8351 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8352 (print_help): Remove; unused.
8353 (stop_character, last_timer_event): Mark as externally visible.
8354 * keyboard.h (ignore_mouse_drag_p): Declare only if
8355 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8356 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8357 * lisp.h (echoing): Remove decl.
8358 (force_auto_save_soon): Declare only if SIGDANGER.
8359 * xdisp.c (redisplay_window): Simplify code, to make it more
8360 obvious that ignore_mouse_drag_p is not accessed if !defined
8361 USE_GTK && !defined HAVE_NS.
8363 * intervals.c: Make symbols static if they're not exported.
8364 (merge_properties_sticky, merge_interval_right, delete_interval):
8366 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8368 * insdel.c: Make symbols static if they're not exported.
8369 However, leave prepare_to_modify_buffer alone. It's never
8370 called from outside this function, but that appears to be a bug.
8371 (combine_after_change_list, combine_after_change_buffer):
8372 (adjust_after_replace, signal_before_change): Now static.
8373 (adjust_after_replace_noundo): Remove; unused.
8374 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8375 (signal_before_change): Remove decls.
8377 * indent.c (val_compute_motion, val_vmotion): Now static.
8379 * image.c: Make symbols static if they're not exported.
8380 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8382 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8383 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8385 * fringe.c (standard_bitmaps): Now static.
8386 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8388 * frame.c: Make symbols static if they're not exported.
8389 (x_report_frame_params, make_terminal_frame): Now static.
8390 (get_frame_param): Now static, unless HAVE_NS.
8391 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8392 (x_get_resource_string): Remove; not used.
8393 * frame.h (make_terminal_frame, x_report_frame_params):
8394 (x_get_resource_string); Remove decls.
8395 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8396 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8398 * font.c, fontset.c: Make symbols static if they're not exported.
8399 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8400 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8401 * font.c (font_close_object): Now static.
8402 * font.h (font_close_object): Remove.
8403 * fontset.c (FONTSET_OBJLIST): Remove.
8404 (free_realized_fontset) #if-0 the body, which does nothing.
8405 (face_suitable_for_char_p): #if-0, as it's never called.
8406 * fontset.h (face_suitable_for_char_p): Remove decl.
8407 * xfaces.c (face_at_string_position):
8408 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8409 since 0 is always ASCII.
8411 * fns.c (weak_hash_tables): Now static.
8413 * fileio.c: Make symbols static if they're not exported.
8414 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8415 (Vwrite_region_annotation_buffers): Now static.
8417 * eval.c: Make symbols static if they're not exported.
8418 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8419 * lisp.h (backtrace_list): Remove decl.
8421 * emacs.c: Make symbols static if they're not exported.
8422 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8423 (fatal_error_code, fatal_error_signal_hook, standard_args):
8425 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8426 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8427 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8428 * lisp.h (fatal_error_signal_hook): Remove decl.
8429 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8431 * editfns.c: Move a (normally-unused) function to its only use.
8432 * editfns.c, lisp.h (get_operating_system_release): Remove.
8433 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8434 worth the hassle of breaking this out.
8436 * xterm.c: Make symbols static if they're not exported.
8437 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8438 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8439 (x_destroy_window, x_delete_display):
8441 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8442 (x_mouse_leave): Remove; unused.
8443 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8444 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8445 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8447 (x_mouse_leave): Declare only if WINDOWSNT.
8448 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8449 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8452 * ftxfont.c: Make symbols static if they're not exported.
8453 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8455 * font.h (ftxfont_driver): Likewise.
8457 * xfns.c: Make symbols static if they're not exported.
8458 (x_last_font_name, x_display_info_for_name):
8459 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8460 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8461 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8462 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8463 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8464 (last_show_tip_args): Now static.
8465 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8466 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8467 (x_screen_planes): Remove; unused.
8468 * dispextern.h (x_screen_planes): Remove decl.
8470 * dispnew.c: Make symbols static if they're not exported.
8471 * dispextern.h (redraw_garbaged_frames, scrolling):
8472 (increment_row_positions): Remove.
8473 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8474 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8476 (redraw_garbaged_frames): Remove; unused.
8478 * xfaces.c: Make symbols static if they're not exported.
8479 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8481 * xterm.h (defined_color): Remove decls.
8482 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8483 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8484 (menu_face_changed_default, defined_color, free_realized_face):
8485 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8486 (ascii_face_of_lisp_face): Remove; unused.
8488 * xdisp.c: Make symbols static if they're not exported.
8489 * dispextern.h (scratch_glyph_row, window_box_edges):
8490 (glyph_to_pixel_coords, set_cursor_from_row):
8491 (get_next_display_element, set_iterator_to_next):
8492 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8493 (show_mouse_face): Remove decls
8494 * frame.h (message_buf_print): Likewise.
8495 * lisp.h (pop_message, set_message, check_point_in_composition):
8497 * xterm.h (set_vertical_scroll_bar): Likewise.
8498 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8499 (message_buf_print, scratch_glyph_row, displayed_buffer):
8500 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8501 (get_next_display_element, show_mouse_face, window_box_edges):
8502 (frame_to_window_pixel_xy, check_point_in_composition):
8503 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8504 (glyph_to_pixel_coords): Remove; unused.
8506 * dired.c (file_name_completion): Now static.
8508 * dbusbind.c (xd_in_read_queued_messages): Now static.
8510 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8511 * data.c (circular_list_error): Remove.
8513 * commands.h (last_point_position, last_point_position_buffer):
8514 (last_point_position_window): Remove decls.
8515 * keyboard.c: Make these variables static.
8517 * coding.h (coding, code_convert_region, encode_coding_gap):
8519 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8520 (iso_code_class, detect_coding, code_convert_region): Now static.
8521 (encode_coding_gap): Remove; unused.
8523 * chartab.c (chartab_chars, chartab_bits): Now static.
8525 * charset.h (charset_iso_8859_1): Remove decl.
8526 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8529 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8530 * ccl.c (Vccl_program_table): Now static.
8531 (check_ccl_update): Remove; unused.
8533 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8534 * category.h: ... from here.
8535 * category.c (check_category_table, set_category_set): Now static.
8537 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8538 * lisp.h: Remove these decls.
8540 * buffer.c (buffer_count): Remove unused var.
8542 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8543 so that it's not optimized away.
8544 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8545 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8546 exported only to the debugger.
8548 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8549 * atimer.h (run_all_atimers): Remove; not exported.
8551 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8552 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8553 was inaccessible from Lisp.
8554 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8555 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8557 alloc.c: Import and export fewer symbols, and remove unused items.
8558 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8560 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8561 it's not optimized away by whole-program optimization.
8562 (message_enable_multibyte, free_misc): Remove.
8563 (catchlist, handlerlist, mark_backtrace):
8564 Declare only if BYTE_MARK_STACK.
8565 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8566 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8567 (message_enable_multibyte): Remove decl.
8568 (free_misc, interval_free_list, float_block, float_block_index):
8569 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8570 (cons_free_list, last_marked_index):
8572 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8573 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8574 (mark_backtrace): Define only if BYTE_MARK_STACK.
8575 * xdisp.c (message_enable_multibyte): Now static.
8577 Declare Lisp_Object Q* variables to be 'static' if not exported.
8578 This makes it easier for human readers (and static analyzers)
8579 to see whether these variables are used from other modules.
8580 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8581 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8582 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8583 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8584 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8585 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8586 * xmenu.c, xselect.c:
8587 Declare Q* vars static if they are not used in other modules.
8588 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8589 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8590 Remove decls of unexported vars.
8591 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8593 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8595 Make Emacs functions such as Fatom 'static' by default.
8596 This makes it easier for human readers (and static analyzers)
8597 to see whether these functions can be called from other modules.
8598 DEFUN now defines a static function. To make the function external
8599 so that it can be used in other C modules, use the new macro DEFUE.
8600 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8601 (Finit_image_library):
8602 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8603 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8604 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8605 Remove decls, since these functions are now static.
8606 (Funintern, Fget_internal_run_time): New decls, since these functions
8607 were already external.
8609 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8610 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8611 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8612 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8613 * keyboard.c, keymap.c, lread.c:
8614 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8615 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8616 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8617 Mark functions with DEFUE instead of DEFUN,
8618 if they are used in other modules.
8619 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8620 decls for now-static functions.
8621 * buffer.h (Fdelete_overlay): Remove decl.
8622 * callproc.c (Fgetenv_internal): Mark as internal.
8623 * composite.c (Fremove_list_of_text_properties): Remove decl.
8624 (Fcomposition_get_gstring): New forward static decl.
8625 * composite.h (Fcomposite_get_gstring): Remove decl.
8626 * dired.c (Ffile_attributes): New forward static decl.
8627 * doc.c (Fdocumntation_property): New forward static decl.
8628 * eval.c (Ffetch_bytecode): New forward static decl.
8629 (Funintern): Remove extern decl; now in .h file where it belongs.
8630 * fileio.c (Fmake_symbolic_link): New forward static decl.
8631 * image.c (Finit_image_library): New forward static decl.
8632 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8633 * intervals.h (Fprevious_property_change):
8634 (Fremove_list_of_text_properties): Remove decls.
8635 * keyboard.c (Fthis_command_keys): Remove decl.
8636 (Fcommand_execute): New forward static decl.
8637 * keymap.c (Flookup_key): New forward static decl.
8638 (Fcopy_keymap): Now static.
8639 * keymap.h (Flookup_key): Remove decl.
8640 * process.c (Fget_process): New forward static decl.
8641 (Fprocess_datagram_address): Mark as internal.
8642 * syntax.c (Fsyntax_table_p): New forward static decl.
8643 (skip_chars): Remove duplicate decl.
8644 * textprop.c (Fprevious_property_change): New forward static decl.
8645 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8647 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8648 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8650 * editfns.c (Fformat): Remove unreachable code.
8652 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8654 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8657 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8659 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8660 when at ZV. (Bug#8487)
8662 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8664 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8666 * keyboard.c (parse_tool_bar_item): Likewise.
8667 * sound.c (sound_cleanup, alsa_close): Likewise.
8668 * termcap.c (tgetent): Likewise.
8669 * xfns.c (x_default_font_parameter): Likewise.
8670 * xsettings.c (read_and_apply_settings): Likewise.
8672 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8673 (overrun_check_free): Protoize.
8675 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8677 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8678 since callers should never pass a negative size.
8679 Change the signature to match that of plain 'read' and 'write'; see
8680 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8681 * lisp.h: Update prototypes of emacs_write and emacs_read.
8683 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8685 * xdisp.c (redisplay_window): Don't try to determine the character
8686 position of the scroll margin if the window start point w->startp
8687 is outside the buffer's accessible region. (Bug#8468)
8689 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8691 Fix write-region and its subroutines for buffers > 2GB.
8692 * fileio.c (a_write, e_write): Modify declaration of arguments and
8693 local variables to support buffers larger than 2GB.
8694 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8696 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8697 argument, local variables, and return value.
8699 * lisp.h: Update prototypes of emacs_write and emacs_read.
8701 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8703 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8705 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8707 Fix more problems found by GCC 4.6.0's static checks.
8709 * xdisp.c (vmessage): Use a better test for character truncation.
8711 * charset.c (load_charset_map): <, not <=, for optimization,
8712 and to avoid potential problems with integer overflow.
8713 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8714 * casetab.c (set_identity, shuffle): Likewise.
8715 * editfns.c (Fformat): Likewise.
8716 * syntax.c (skip_chars): Likewise.
8718 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8719 This also lets GCC 4.6.0 generate slightly better loop code.
8721 * callint.c (Fcall_interactively): <, not <=, for optimization.
8722 (Fcall_interactively): Count the number of arguments produced,
8723 not the number of arguments given. This is simpler and lets GCC
8724 4.6.0 generate slightly better code.
8726 * ftfont.c: Distingish more carefully between FcChar8 and char.
8727 The previous code passed unsigned char * to a functions like
8728 strlen and xstrcasecmp that expect char *, which does not
8729 conform to the C standard.
8730 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8731 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8732 char * when the C standard requires it.
8734 * keyboard.c (read_char): Remove unused var.
8736 * eval.c: Port to Windows vsnprintf (Bug#8435).
8738 (SIZE_MAX): Define if the headers do not.
8739 (verror): Do not give up if vsnprintf returns a negative count.
8740 Instead, grow the buffer. This ports to Windows vsnprintf, which
8741 does not conform to C99. Problem reported by Eli Zaretskii.
8742 Also, simplify the allocation scheme, by avoiding the need for
8743 calling realloc, and removing the ALLOCATED variable.
8745 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8747 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8748 But keep the doprint source code for now, as we might revamp it
8749 and use it again (Bug#8435).
8750 * lisp.h (doprnt): Remove.
8751 * Makefile.in (base_obj): Remove doprnt.o.
8752 * deps.mk (doprnt.o): Remove.
8754 error: Print 32- and 64-bit integers portably (Bug#8435).
8755 Without this change, on typical 64-bit hosts error ("...%d...", N)
8756 was used to print both 32- and 64-bit integers N, which relied on
8758 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8759 * lisp.h (error, verror): Mark as printf-like functions.
8760 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8761 Report overflow in size calculations when allocating printf buffer.
8762 Do not truncate output string at its first null byte.
8763 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8764 Truncate the output at a character boundary, since vsnprintf does not
8766 * charset.c (check_iso_charset_parameter): Convert internal
8767 character to string before calling 'error', since %c now has the
8769 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8770 overflow when computing char to be passed to 'error'. Do not
8771 pass Lisp_Object to 'error'; pass the integer instead.
8772 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8773 formatted with plain %d.
8775 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8777 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8779 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8781 * xterm.c (x_catch_errors): Remove duplicate declaration.
8783 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8785 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8787 2011-04-10 Jim Meyering <meyering@redhat.com>
8789 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8790 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8791 return ssize_t not "int", and use size_t as the buffer length.
8792 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8793 * gnutls.h: Update declarations.
8794 * process.c (read_process_output): Use ssize_t, to match.
8795 (send_process): Likewise.
8797 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8799 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8801 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8803 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8804 Use unsigned char, to match FcChar8 type definition.
8806 * xterm.c (handle_one_xevent):
8807 * xmenu.c (create_and_show_popup_menu):
8808 * xselect.c (x_decline_selection_request)
8809 (x_reply_selection_request): Avoid type-punned deref of X events.
8811 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8813 Fix some uses of `int' instead of EMACS_INT.
8814 * search.c (string_match_1, fast_string_match)
8815 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8816 (scan_buffer, find_next_newline_no_quit)
8817 (find_before_next_newline, search_command, Freplace_match)
8818 (Fmatch_data): Make some `int' variables be EMACS_INT.
8820 * xdisp.c (display_count_lines): 3rd argument and return value now
8821 EMACS_INT. All callers changed.
8822 (pint2hrstr): Last argument is now EMACS_INT.
8824 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8825 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8826 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8827 (decode_coding_utf_16, decode_coding_emacs_mule)
8828 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8829 (decode_coding_ccl, decode_coding_charset)
8830 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8831 (decode_coding_iso_2022, decode_coding_emacs_mule)
8832 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8833 <char_offset, last_offset>: Declare EMACS_INT.
8834 (encode_coding_utf_8, encode_coding_utf_16)
8835 (encode_coding_emacs_mule, encode_invocation_designation)
8836 (encode_designation_at_bol, encode_coding_iso_2022)
8837 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8838 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8840 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8841 (encode_invocation_designation): Last argument P_NCHARS is now
8843 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8844 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8846 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8849 * ccl.c (Fccl_execute_on_string): Declare some variables
8852 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8854 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8856 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8858 * process.c (Fformat_network_address): Doc fix.
8860 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8862 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8864 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8866 * keyboard.c (read_char): Call Lisp function help-form-show,
8867 instead of using internal_with_output_to_temp_buffer.
8868 (Qhelp_form_show): New var.
8869 (syms_of_keyboard): Use DEFSYM macro.
8871 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8873 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8875 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8877 * process.c (Flist_processes): Remove to Lisp.
8878 (list_processes_1): Delete.
8880 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8882 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8884 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8886 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8888 Fix more problems found by GCC 4.6.0's static checks.
8890 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8892 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8894 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8896 * xdisp.c (vmessage): Mark as a printf-like function.
8898 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8900 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8902 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8903 printf-like functions.
8904 (tiff_load): Add casts to remove these marks before passing them
8905 to system-supplied API.
8907 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8909 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8910 This avoids several warnings with gcc -Wstrict-overflow.
8911 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8912 directly, rather than having caller test rule sign. This avoids
8913 some unnecessary tests.
8914 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8915 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8916 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8918 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8919 (xfont_open): Avoid unnecessary tests.
8921 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8923 * composite.h, composite.c (composition_gstring_put_cache):
8924 Use EMACS_INT, not int, for length.
8926 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8927 breaking out part of COMPOSITION_DECODE_RULE.
8928 (COMPOSITION_DECODE_RULE): Use it.
8929 * composite.c (get_composition_id): Remove unused local vars,
8930 by using the new macro.
8932 * textprop.c (set_text_properties_1): Change while to do-while,
8933 since the condition is always true at first.
8935 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8936 (interval_deletion_adjustment): Return unsigned value.
8939 * process.c (list_processes_1, create_pty, read_process_output):
8940 (exec_sentinel): Remove vars that were set but not used.
8941 (create_pty): Remove unnecessary "volatile"s.
8942 (Fnetwork_interface_info): Avoid possibility of int overflow.
8943 (read_process_output): Do adaptive read buffering even if carryover.
8944 (read_process_output): Simplify nbytes computation if buffered.
8946 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8948 * syntax.c (scan_words): Remove var that was set but not used.
8949 (update_syntax_table): Use unsigned instead of int.
8951 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8952 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8953 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8955 * print.c (print_error_message): Avoid int overflow.
8957 * font.c (font_list_entities): Redo for clarity,
8958 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8960 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8961 (font_score): Avoid potential overflow in diff calculation.
8963 * fns.c (substring_both): Remove var that is set but not used.
8964 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8966 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8968 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8969 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8970 can always succeed if overflow has undefined behavior.
8972 * search.c (boyer_moore, wordify): Remove vars set but not used.
8973 (wordify): Omit three unnecessary tests.
8975 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8976 All callers changed. This avoids the need for an unused var.
8978 * casefiddle.c (casify_region): Remove var that is set but not used.
8980 * dired.c (file_name_completion): Remove var that is set but not used.
8982 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8984 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8985 (Finsert_file_contents): Remove unnecessary code checking fd.
8987 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8988 Check for integer overflow on size calculations.
8990 * buffer.c (Fprevious_overlay_change): Remove var that is set
8993 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8994 Remove vars that are set but not used.
8995 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8996 (timer_check_2): Mark vars as initialized.
8998 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9000 * image.c (lookup_image): Remove var that is set but not used.
9001 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
9003 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9004 that are set but not used.
9006 * xfns.c (make_invisible_cursor): Don't return garbage
9007 if XCreateBitmapFromData fails (Bug#8410).
9009 * xselect.c (x_get_local_selection, x_handle_property_notify):
9010 Remove vars that are set but not used.
9012 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9013 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9015 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9016 Remove var that is set but not used.
9017 (scroll_bar_windows_size): Now size_t, not int.
9018 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9021 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9022 (map_tty_color) [!defined MSDOS]: Likewise.
9024 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9026 * coding.c: Remove vars that are set but not used.
9027 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9028 All callers changed.
9029 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9030 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9031 (decode_coding_charset): Remove vars that are set but not used.
9033 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9034 that is set but not used.
9036 * print.c (print_object): Remove var that is set but not used.
9038 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9039 The gnulib version avoids calling malloc in the usual case,
9040 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9041 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9042 * filelock.c (current_lock_owner): Likewise.
9043 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9044 * sysdep.c: Include allocator.h, careadlinkat.h.
9045 (emacs_no_realloc_allocator): New static constant.
9046 (emacs_readlink): New function.
9047 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9048 ../lib/careadlinkat.h.
9050 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9052 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9053 first non-nil return value).
9055 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9057 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9058 if not defined (Bug#8403).
9060 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9062 * xdisp.c (display_count_lines): Remove parameter `start',
9063 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9064 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9065 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9066 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9067 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9068 and thereabouts. All callers changed.
9069 (get_per_char_metric): Remove parameter `f', unused since
9070 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9072 2011-04-02 Jim Meyering <meyering@redhat.com>
9074 do not dereference NULL upon failed strdup
9075 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9076 (ns_get_family): Likewise.
9078 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9080 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9082 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9084 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9087 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9089 Add lexical binding.
9091 * window.c (Ftemp_output_buffer_show): New fun.
9092 (Fsave_window_excursion):
9093 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9095 * lread.c (lisp_file_lexically_bound_p): New function.
9096 (Fload): Bind Qlexical_binding.
9097 (readevalloop): Remove `evalfun' arg.
9098 Bind Qinternal_interpreter_environment.
9099 (Feval_buffer): Bind Qlexical_binding.
9100 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9102 (syms_of_lread): Declare `lexical-binding'.
9104 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9106 * keyboard.c (eval_dyn): New fun.
9107 (menu_item_eval_property): Use it.
9109 * image.c (parse_image_spec): Use Ffunctionp.
9111 * fns.c (concat, mapcar1): Accept byte-code-functions.
9113 * eval.c (Fsetq): Handle lexical vars.
9114 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9115 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9116 (FletX, Flet): Obey lexical binding.
9117 (Fcommandp): Handle closures.
9118 (Feval): New `lexical' arg.
9119 (eval_sub): New function extracted from Feval. Use it almost
9120 everywhere where Feval was used. Look up vars in lexical env.
9122 (Ffunctionp): Move from subr.el.
9123 (Ffuncall): Handle closures.
9124 (apply_lambda): Remove `eval_flags'.
9125 (funcall_lambda): Handle closures and new byte-code-functions.
9126 (Fspecial_variable_p): New function.
9127 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9128 but without exporting it to Lisp.
9130 * doc.c (Fdocumentation, store_function_docstring):
9131 * data.c (Finteractive_form): Handle closures.
9133 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9136 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9138 (exec_byte_code): New function extracted from Fbyte_code to handle new
9139 calling convention for byte-code-functions. Add new byte-codes.
9141 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
9143 * alloc.c (Fmake_symbol): Init new `declared_special' field.
9145 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9147 * xdisp.c (redisplay_internal): Fix prototype.
9149 2011-03-31 Eli Zaretskii <eliz@gnu.org>
9151 * xdisp.c (SCROLL_LIMIT): New macro.
9152 (try_scrolling): Use it when setting scroll_limit.
9153 Limit scrolling to 100 screen lines.
9154 (redisplay_window): Even when falling back on "recentering",
9155 position point in the window according to scroll-conservatively,
9156 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9158 (try_scrolling): When point is above the window, allow searching
9159 as far as scroll_max, or one screenful, to compute vertical
9160 distance from PT to the scroll margin position. This prevents
9161 try_scrolling from unnecessarily failing when
9162 scroll-conservatively is set to a value slightly larger than the
9163 window height. Clean up the case of PT below the margin at bottom
9164 of window: scroll_max can no longer be INT_MAX. When aggressive
9165 scrolling is in use, don't let point enter the opposite scroll
9166 margin as result of the scroll.
9167 (syms_of_xdisp) <scroll-conservatively>: Document the
9168 threshold of 100 lines for never-recentering scrolling.
9170 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9172 * dispextern.h (move_it_by_lines):
9173 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9174 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9175 (message_log_check_duplicate): Remove parameters `prev_bol' and
9176 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9177 (redisplay_internal): Remove parameter `preserve_echo_area',
9178 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9180 * indent.c (Fvertical_motion):
9181 * window.c (window_scroll_pixel_based, Frecenter):
9182 Don't pass `need_y_p' to `move_it_by_lines'.
9184 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9186 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9187 steal a few bits to be more compact.
9188 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9189 Remove unneeded casts.
9191 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9193 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9195 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9196 binding" message (bug#7967).
9198 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9200 Fix more problems found by GCC 4.6.0's static checks.
9202 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9203 Remove unused local var.
9205 * editfns.c (Fmessage_box): Remove unused local var.
9207 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9208 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9209 Omit unused local vars.
9210 * window.c (shrink_windows): Omit unused local var.
9211 * menu.c (digest_single_submenu): Omit unused local var.
9212 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9213 Omit unused local var.
9215 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9216 Don't assume string length fits in int.
9217 (keyremap_step, read_key_sequence): Use size_t for sizes.
9218 (read_key_sequence): Don't check last_real_key_start redundantly.
9220 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9221 instead of alloca (Bug#8344).
9223 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9224 (Fbacktrace_frame): Don't assume nframes fits in int.
9226 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9228 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9231 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9233 * cm.c (calccost): Turn while-do into do-while, for clarity.
9235 * keyboard.c (syms_of_keyboard): Use the same style as later
9236 in this function when indexing through an array. This also
9237 works around GCC bug 48267.
9239 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9241 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9243 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9244 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9246 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9247 This avoids undefined behavior on integer overflow, and is a bit
9248 more convenient anyway since it is compared to a size_t variable.
9250 Variadic C functions now count arguments with size_t, not int.
9251 This avoids an unnecessary limitation on 64-bit machines, which
9252 caused (substring ...) to crash on large vectors (Bug#8344).
9253 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9254 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9255 All variadic functions and their callers changed accordingly.
9256 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9257 * data.c (arith_driver, float_arith_driver): Likewise.
9258 * editfns.c (general_insert_function): Likewise.
9259 * eval.c (struct backtrace.nargs, interactive_p)
9260 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9261 (funcall_lambda, mark_backtrace): Likewise.
9262 * fns.c (concat): Likewise.
9263 * frame.c (x_set_frame_parameters): Likewise.
9264 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9265 0 if not found, not -1. All callers changed.
9267 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9268 (stack_copy_size): Now size_t, not int.
9269 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9271 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9273 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9274 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9275 All callers changed.
9277 * lisp.h (multibyte_char_to_unibyte):
9278 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9279 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9280 * character.h (CHAR_TO_BYTE8):
9281 * cmds.c (internal_self_insert):
9282 * editfns.c (general_insert_function):
9283 * keymap.c (push_key_description):
9284 * search.c (Freplace_match):
9285 * xdisp.c (message_dolog, set_message_1): All callers changed.
9287 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9289 * keyboard.c (safe_run_hook_funcall): New function.
9290 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9291 don't set the hook to nil, but remove the offending function instead.
9292 (Qcommand_hook_internal): Remove, unused.
9293 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9294 Vcommand_hook_internal.
9296 * eval.c (enum run_hooks_condition): Remove.
9297 (funcall_nil, funcall_not): New functions.
9298 (run_hook_with_args): Call each function through a `funcall' argument.
9299 Remove `cond' argument, now redundant.
9300 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9301 (Frun_hook_with_args_until_failure): Adjust accordingly.
9302 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9304 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9306 * dispextern.h (string_buffer_position): Remove declaration.
9308 * print.c (strout): Remove parameter `multibyte', unused since
9309 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9311 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9312 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9313 All callers changed.
9315 * w32.c (_wsa_errlist): Use braces for struct initializers.
9317 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9318 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9319 All callers changed.
9320 (string_buffer_position): Likewise. Also, make static (it's never
9321 used outside xdisp.c).
9322 (cursor_row_p): Remove parameter `w', unused since
9323 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9324 (decode_mode_spec): Remove parameter `precision', introduced during
9325 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9326 All callers changed.
9328 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9330 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9332 2011-03-27 Anders Lindgren <andlind@gmail.com>
9334 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9335 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9336 (ns_update_auto_hide_menu_bar): New functions.
9337 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9338 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9339 ns_constrain_all_frames.
9340 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9341 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9343 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9345 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9347 2011-03-27 Glenn Morris <rgm@gnu.org>
9349 * syssignal.h: Replace RETSIGTYPE with void.
9350 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9351 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9352 Replace SIGTYPE with void everywhere.
9353 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9354 * s/template.h (SIGTYPE): Remove commented out definition.
9356 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9358 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9359 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9361 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9363 * w32.c (read_unc_volume): Use parameter `henum', instead of
9364 global variable `wget_enum_handle'.
9366 * keymap.c (describe_vector): Remove parameters `indices' and
9367 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9368 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9370 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9372 * keyboard.c (timer_check): Remove parameter `do_it_now',
9373 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9374 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9375 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9377 * keyboard.c (read_char):
9378 * w32menu.c (w32_menu_display_help):
9379 * xmenu.c (show_help_event, menu_help_callback):
9380 Adjust calls to `show_help_echo'.
9382 * gtkutil.c (xg_maybe_add_timer):
9383 * keyboard.c (readable_events):
9384 * process.c (wait_reading_process_output):
9385 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9387 * insdel.c (adjust_markers_gap_motion):
9388 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9389 (gap_left, gap_right): Don't call it.
9391 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9393 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9394 incurred during fontification.
9396 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9398 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9399 (DEFVAR_PER_BUFFER): Don't pass it.
9401 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9402 (scrolling_window): Don't pass it.
9404 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9406 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9408 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9410 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9411 of variables specific to SELinux and computation of `encoded_absname'.
9413 * image.c (XPutPixel): Remove unused variable `height'.
9415 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9417 * unexw32.c (get_section_info): Remove unused variable `section'.
9419 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9420 (system_process_attributes): Remove unused variable `sess'.
9421 (sys_read): Remove unused variable `err'.
9423 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9424 (w32_wnd_proc): Remove unused variable `isdead'.
9425 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9426 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9427 (x_create_tip_frame): Remove unused variable `tem'.
9429 * w32inevt.c (w32_console_read_socket):
9430 Remove unused variable `no_events'.
9432 * w32term.c (x_draw_composite_glyph_string_foreground):
9433 Remove unused variable `width'.
9435 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9437 * w32term.c (x_set_glyph_string_clipping):
9438 Don't pass uninitialized region to CombineRgn.
9440 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9442 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9443 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9444 (Fx_close_connection): Remove unused variable `i'.
9446 * w32font.c (w32font_draw): Return number of glyphs.
9447 (w32font_open_internal): Remove unused variable `i'.
9448 (w32font_driver): Add missing initializer.
9450 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9451 (fill_in_menu): Remove unused variable `items_added'.
9453 * w32term.c (last_mouse_press_frame): Remove static global variable.
9454 (w32_clip_to_row): Remove unused variable `f'.
9455 (x_delete_terminal): Remove unused variable `i'.
9457 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9458 (NOTHING): Remove unused static global variable.
9459 (uniscribe_check_otf): Remove unused variable `table'.
9460 (uniscribe_font_driver): Add missing initializers.
9462 2011-03-23 Julien Danjou <julien@danjou.info>
9464 * term.c (Fsuspend_tty, Fresume_tty):
9465 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9466 * window.c (temp_output_buffer_show):
9467 * insdel.c (signal_before_change):
9468 * frame.c (Fhandle_switch_frame):
9469 * fileio.c (Fdo_auto_save):
9470 * emacs.c (Fkill_emacs):
9471 * editfns.c (save_excursion_restore):
9472 * cmds.c (internal_self_insert):
9473 * callint.c (Fcall_interactively):
9474 * buffer.c (Fkill_all_local_variables):
9475 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9477 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9478 unconditionally since it does the check itself.
9480 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9482 Fix more problems found by GCC 4.5.2's static checks.
9484 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9485 the first time through the loop, since we know p0 < p1 then.
9486 This also avoids a gcc -Wstrict-overflow warning.
9488 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9489 leading to a memory leak, possible in functions like
9490 load_charset_map_from_file that can allocate an unbounded number
9491 of objects (Bug#8318).
9493 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9494 that could (at least in theory) be that large.
9496 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9497 This is less likely to overflow, and avoids undefined behavior if
9498 overflow does occur. All callers changed. Use strtoul to scan
9499 for the unsigned long integer.
9500 (pint2hrstr): Simplify and tune code slightly.
9501 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9503 * scroll.c (do_scrolling): Work around GCC bug 48228.
9504 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9506 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9507 This also avoids a warning with gcc -Wstrict-overflow.
9508 (validate_x_resource_name): Simplify count usage.
9509 This also avoids a warning with gcc -Wstrict-overflow.
9511 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9514 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9516 * process.c (Fmake_network_process): Use socklen_t, not int,
9517 where POSIX says socklen_t is required in portable programs.
9518 This fixes a porting bug on hosts like 64-bit HP-UX, where
9519 socklen_t is wider than int (Bug#8277).
9520 (Fmake_network_process, server_accept_connection):
9521 (wait_reading_process_output, read_process_output):
9524 * process.c: Rename or move locals to avoid shadowing.
9525 (list_processes_1, Fmake_network_process):
9526 (read_process_output_error_handler, exec_sentinel_error_handler):
9527 Rename or move locals.
9528 (Fmake_network_process): Define label "retry_connect" only if needed.
9529 (Fnetwork_interface_info): Fix pointer signedness.
9530 (process_send_signal): Add cast to avoid pointer signedness problem.
9531 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9532 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9534 Make tparam.h and terminfo.c consistent.
9535 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9536 Include tparam.h instead, since it declares them.
9537 * cm.h (PC): Remove extern decl; tparam.h now does this.
9538 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9539 * terminfo.c: Include tparam.h, to check interfaces.
9540 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9541 (tparam): Adjust signature to match interface in tparam.h;
9542 this removes some undefined behavior. Check that outstring and len
9543 are zero, which they always are with Emacs.
9544 * tparam.h (PC, BC, UP): New extern decls.
9546 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9547 (xftfont_open): Rename locals to avoid shadowing.
9549 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9550 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9551 (OTF_TAG_SYM): Omit macro if not needed.
9552 (ftfont_list): Remove unused local.
9553 (get_adstyle_property, ftfont_pattern_entity):
9554 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9555 Rename locals to avoid shadowing.
9557 * xfont.c (xfont_list_family): Mark var as initialized.
9559 * xml.c (make_dom): Now static.
9561 * composite.c (composition_compute_stop_pos): Rename local to
9563 (composition_reseat_it): Remove unused locals.
9564 (find_automatic_composition, composition_adjust_point): Likewise.
9565 (composition_update_it): Mark var as initialized.
9566 (find_automatic_composition): Mark vars as initialized,
9567 with a FIXME (Bug#8290).
9569 character.h: Rename locals to avoid shadowing.
9570 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9571 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9572 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9573 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9576 * textprop.c (property_change_between_p): Remove; unused.
9578 * intervals.c (interval_start_pos): Now static.
9580 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9582 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9583 Rename locals to avoid shadowing.
9585 * sound.c (wav_play, au_play, Fplay_sound_internal):
9586 Fix pointer signedness.
9587 (alsa_choose_format): Remove unused local var.
9588 (wav_play): Initialize a variable to 0, to prevent undefined
9589 behavior (Bug#8278).
9591 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9593 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9595 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9596 clobbering (Bug#8298).
9597 * sysdep.c (sys_subshell): Likewise.
9598 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9600 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9601 This should get cleaned up, so that child_setup has the
9602 same signature on all platforms.
9604 * callproc.c (call_process_cleanup): Now static.
9605 (relocate_fd): Rename locals to avoid shadowing.
9607 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9609 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9610 not to be necessary, and produces flickering.
9612 2011-03-20 Glenn Morris <rgm@gnu.org>
9614 * config.in: Remove file.
9616 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9618 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9619 are now in src/globals.h.
9620 (syms_of_minibuf): Remove spurious & from previous change.
9622 2011-03-20 Leo Liu <sdl.web@gmail.com>
9624 * minibuf.c (completing-read-function): New variable.
9625 (completing-read-default): Rename from completing-read.
9626 (completing-read): Call completing-read-function.
9628 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9630 * xfaces.c (Fx_load_color_file):
9631 Read color file from absolute filename (bug#8250).
9633 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9635 * makefile.w32-in: Update dependencies.
9637 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9639 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9641 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9643 Fix more problems found by GCC 4.5.2's static checks.
9645 * process.c (make_serial_process_unwind, send_process_trap):
9646 (sigchld_handler): Now static.
9648 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9649 That way, the code declares only the vars that it needs.
9650 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9651 * s/cygwin.h (PTY_ITERATION): Likewise.
9652 * s/darwin.h (PTY_ITERATION): Likewise.
9653 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9655 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9656 * process.c (allocate_pty): Don't declare stb unless it's needed.
9658 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9659 (CONSTANTLIM): Remove; unused.
9660 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9661 Define only if needed.
9663 * unexelf.c (unexec): Name an expression,
9664 to avoid gcc -Wbad-function-cast warning.
9665 Use a different way to cause a compilation error if anyone uses
9666 n rather than nn, a way that does not involve shadowing.
9667 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9669 * deps.mk (unexalpha.o): Remove; unused.
9671 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9672 * unexec.h: New file.
9673 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9674 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9676 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9677 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9678 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9679 Change as necessary to match prototype in unexec.h.
9681 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9683 (back_comment, skip_chars): Mark vars as initialized.
9685 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9686 Rename locals to avoid shadowing.
9688 * lread.c (read1): Rewrite so as not to use empty "else".
9689 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9691 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9693 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9694 warning when compiling print.c.
9696 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9697 instead of using an uninitialized var.
9698 (font_sort_entities): Mark var as initialized.
9700 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9702 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9703 pointers to constants.
9704 (font_parse_fcname): Remove unused vars.
9705 (font_delete_unmatched): Now static.
9706 (font_get_spec): Remove; unused.
9707 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9708 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9709 Rename or move locals to avoid shadowing.
9711 * fns.c (require_nesting_list, require_unwind): Now static.
9712 (Ffillarray): Rename locals to avoid shadowing.
9714 * floatfns.c (domain_error2): Define only if needed.
9715 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9717 * alloc.c (mark_backtrace): Move decl from here ...
9718 * lisp.h: ... to here, so that it can be checked.
9720 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9721 (Fdefvar): Rewrite so as not to use empty "else".
9722 (lisp_indirect_variable): Name an expression,
9723 to avoid gcc -Wbad-function-cast warning.
9724 (Fdefvar): Rename locals to avoid shadowing.
9726 * callint.c (quotify_arg, quotify_args): Now static.
9727 (Fcall_interactively): Rename locals to avoid shadowing.
9728 Use const pointer when appropriate.
9730 * lisp.h (get_system_name, get_operating_system_release):
9731 Move decls here, to check interfaces.
9732 * process.c (get_operating_system_release): Move decl to lisp.h.
9733 * xrdb.c (get_system_name): Likewise.
9734 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9735 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9736 some of which prompt warnings from gcc -Wbad-function-cast.
9737 (Fformat_time_string, Fencode_time, Finsert_char):
9738 (Ftranslate_region_internal, Fformat):
9739 Rename or remove local vars to avoid shadowing.
9740 (Ftranslate_region_internal): Mark var as initialized.
9742 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9745 * lisp.h (eassert): Check that the argument compiles, even if
9746 ENABLE_CHECKING is not defined.
9748 * data.c (Findirect_variable): Name an expression, to avoid
9749 gcc -Wbad-function-cast warning.
9750 (default_value, arithcompare, arith_driver, arith_error): Now static.
9751 (store_symval_forwarding): Rename local to avoid shadowing.
9752 (Fmake_variable_buffer_local, Fmake_local_variable):
9753 Mark variables as initialized.
9754 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9756 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9757 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9758 Rename locals to avoid shadowing.
9759 (mark_stack): Move local variables into the #ifdef region where
9761 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9762 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9764 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9765 (GC_STRING_CHARS): Remove; not used.
9766 (Fmemory_limit): Cast sbrk's returned value to char *.
9768 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9769 avoids undefined behavior in theory.
9771 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9773 Use functions, not macros, for up- and down-casing (Bug#8254).
9774 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9775 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9776 to use the following functions instead of these macros.
9777 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9778 EMACS_INT, since callers assume the returned value fits in int.
9779 (upcase1): Likewise, for UPCASE_TABLE.
9780 (uppercasep, lowercasep, upcase): New static inline functions.
9781 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9782 the race-condition problem in the old DOWNCASE.
9784 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9785 Rename locals to avoid shadowing.
9786 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9787 (regex_compile, re_search_2, re_match_2_internal):
9788 Remove unused local vars.
9789 (FREE_VAR): Rewrite so as not to use empty "else",
9790 which gcc can warn about.
9791 (regex_compile, re_match_2_internal): Mark locals as initialized.
9792 (RETALLOC_IF): Define only if needed.
9793 (WORDCHAR_P): Likewise. This one is never needed, but is used
9794 only in a comment talking about a compiler bug, so put inside
9795 the #if 0 of that comment.
9796 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9797 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9800 * search.c (boyer_moore): Rename locals to avoid shadowing.
9801 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9802 (PREV_CHAR_BOUNDARY): Likewise.
9804 * search.c (simple_search): Remove unused var.
9806 * dired.c (compile_pattern): Move decl from here ...
9807 * lisp.h: ... to here, so that it can be checked.
9808 (struct re_registers): New forward decl.
9810 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9812 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9814 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9815 Rename locals to avoid shadowing.
9816 (Fvertical_motion): Mark locals as initialized.
9818 * casefiddle.c (casify_object, casify_region): Now static.
9819 (casify_region): Mark local as initialized.
9821 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9823 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9824 New macros, so that the caller can use some names other than
9825 gcpro1, gcpro2, etc.
9826 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9828 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9829 argument, for consistency with GCPRO2_VAR, etc: it is now the
9830 prefix of the variable, not the variable itself. All uses
9832 * dired.c (directory_files_internal, file_name_completion):
9833 Rename locals to avoid shadowing.
9835 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9836 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9837 dired.c's scmp function, had undefined behavior.
9838 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9839 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9840 * buffer.h: ... to here, because these macros use current_buffer,
9841 and the new implementation with inline functions needs to have
9842 current_buffer in scope now, rather than later when the macros
9844 (downcase, upcase1): New static inline functions.
9845 (DOWNCASE, UPCASE1): Reimplement using these functions.
9846 This avoids undefined behavior in expressions like
9847 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9848 from race conditions in accessing the global variables
9849 case_temp1 and case_temp2.
9850 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9851 * lisp.h (case_temp1, case_temp2): Remove their decls.
9852 * character.h (ASCII_CHAR_P): Move from here ...
9853 * lisp.h: ... to here, so that the inline functions mentioned
9856 * dired.c (directory_files_internal_unwind): Now static.
9858 * fileio.c (file_name_as_directory, directory_file_name):
9859 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9861 (file_name_as_directory): Use const pointers when appropriate.
9862 (Fexpand_file_name): Likewise. In particular, newdir might
9863 point at constant storage, so make it a const pointer.
9864 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9865 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9867 (Fset_file_times, Finsert_file_contents, auto_save_error):
9868 Rename locals to avoid shadowing.
9870 * minibuf.c (choose_minibuf_frame_1): Now static.
9871 (Ftry_completion, Fall_completions): Rename or remove locals
9874 * marker.c (bytepos_to_charpos): Remove; unused.
9876 * lisp.h (verify_bytepos, count_markers): New decls,
9877 so that gcc does not warn that these functions aren't declared.
9879 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9880 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9881 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9882 (copy_text): Remove unused local var.
9884 * filelock.c (within_one_second): Now static.
9885 (lock_file_1): Rename local to avoid shadowing.
9887 * buffer.c (fix_overlays_before): Mark locals as initialized.
9888 (fix_start_end_in_overlays): Likewise. This function should be
9889 simplified by using pointers-to-pointers, but that's a different
9891 (switch_to_buffer_1): Now static.
9892 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9893 (report_overlay_modification): Rename locals to avoid shadowing.
9895 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9896 Fix pointer signedness issue.
9897 (sys_subshell): Mark local as volatile if checking for lint,
9898 to suppress a gcc -Wclobbered warning that does not seem to be right.
9899 (MAXPATHLEN): Define only if needed.
9901 * process.c (serial_open, serial_configure): Move decls from here ...
9902 * systty.h: ... to here, so that they can be checked.
9904 * fns.c (get_random, seed_random): Move extern decls from here ...
9905 * lisp.h: ... to here, so that they can be checked.
9907 * sysdep.c (reset_io): Now static.
9908 (wait_for_termination_signal): Remove; unused.
9910 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9911 (copy_keymap_item, append_key, push_text_char_description):
9913 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9914 (DENSE_TABLE_SIZE): Remove; unused.
9915 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9916 (describe_map_tree):
9917 Rename locals to avoid shadowing.
9919 * keyboard.c: Declare functions static if they are not used elsewhere.
9920 (echo_char, echo_dash, cmd_error, top_level_2):
9921 (poll_for_input, handle_async_input): Now static.
9922 (read_char, kbd_buffer_get_event, make_lispy_position):
9923 (make_lispy_event, make_lispy_movement, apply_modifiers):
9924 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9925 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9926 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9927 (read_key_sequence, read_char): Mark locals as initialized.
9928 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9930 * keyboard.h (make_ctrl_char): New decl.
9931 (mark_kboards): Move decl here ...
9932 * alloc.c (mark_kboards): ... from here.
9934 * lisp.h (force_auto_save_soon): New decl.
9936 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9937 (DEFINE_DUMMY_FUNCTION): New macro.
9938 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9940 (main): Add casts to avoid warnings
9941 if GCC considers string literals to be constants.
9943 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9945 * dbusbind.c: Pointer signedness fixes.
9946 (xd_signature, xd_append_arg, xd_initialize):
9947 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9948 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9949 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9950 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9952 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9953 if GCC considers string literals to be constants.
9954 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9956 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9958 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9959 (print_preprocess, print_object): New macro to fix last change.
9961 * print.c (print_preprocess): Don't forget font objects.
9963 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9965 * emacs.c (USAGE3): Doc fixes.
9967 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9969 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9972 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9974 * lisp.h (VWindow_system, Qfile_name_history):
9975 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9976 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9977 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9979 * w32select.c: Don't #include "keyboard.h".
9980 (run_protected): Add extern declaration for waiting_for_input.
9982 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9983 * w32console.c (detect_input_pending, read_input_pending)
9984 (encode_terminal_code):
9985 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9986 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9987 (w32_system_caret_y, Qfile_name_history):
9988 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9989 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9990 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9991 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9992 * w32proc.c (Qlocal, report_file_error):
9993 * w32term.c (Vwindow_system, updating_frame):
9994 * w32uniscribe.c (initialized, uniscribe_font_driver):
9995 Remove unneeded extern declarations.
9997 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9999 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
10001 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
10003 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10004 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10005 These macros can no longer be used for assignment.
10007 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10008 Assign struct members directly, instead of using BUF_BEGV etc.
10009 (record_buffer_markers, fetch_buffer_markers): New functions for
10010 recording and fetching special buffer markers.
10011 (set_buffer_internal_1, set_buffer_temp): Use them.
10013 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10015 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10017 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10018 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10020 * xdisp.c (hscroll_window_tree):
10021 (reconsider_clip_changes): Use PT instead of BUF_PT.
10023 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10025 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10026 $(EMACS_ROOT)/lib/intprops.h.
10028 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10030 Fix more problems found by GCC 4.5.2's static checks.
10032 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10033 to unsigned char * to avoid compiler diagnostic.
10034 (xg_free_frame_widgets): Make it clear that a local variable is
10035 needed only if USE_GTK_TOOLTIP.
10036 (gdk_window_get_screen): Make it clear that this macro is needed
10037 only if USE_GTK_TOOLTIP.
10038 (int_gtk_range_get_value): New function, which avoids a diagnostic
10039 from gcc -Wbad-function-cast.
10040 (xg_set_toolkit_scroll_bar_thumb): Use it.
10041 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10042 diagnostic from gcc -Wbad-function-cast.
10043 (get_utf8_string, xg_get_file_with_chooser):
10044 Rename locals to avoid shadowing.
10045 (create_dialog): Move locals to avoid shadowing.
10047 * xgselect.c (xg_select): Remove unused var.
10049 * image.c (four_corners_best): Mark locals as initialized.
10050 (gif_load): Initialize transparent_p to zero (Bug#8238).
10051 Mark another local as initialized.
10052 (my_png_error, my_error_exit): Mark with NO_RETURN.
10054 * image.c (clear_image_cache): Now static.
10055 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10056 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10057 (x_edge_detection): Remove unnecessary cast that
10058 gcc -Wbad-function-cast diagnoses.
10059 (gif_load): Fix pointer signedness.
10060 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10061 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10063 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10065 Improve quality of tests for time stamp overflow.
10066 For example, without this patch (encode-time 0 0 0 1 1
10067 1152921504606846976) returns the obviously-bogus value (-948597
10068 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10069 reports time overflow. See
10070 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10071 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10072 * editfns.c: Include limits.h and intprops.h.
10073 (TIME_T_MIN, TIME_T_MAX): New macros.
10074 (time_overflow): Move earlier, to before first use.
10075 (hi_time, lo_time): New functions, for an accurate test for
10076 out-of-range times.
10077 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10078 (Fget_internal_run_time): Don't assume time_t fits in int.
10079 (make_time): Use list2 instead of Fcons twice.
10080 (Fdecode_time): More accurate test for out-of-range times.
10081 (check_tm_member): New function.
10082 (Fencode_time): Use it, to test for out-of-range times.
10083 (lisp_time_argument): Don't rely on undefined left-shift and
10084 right-shift behavior when checking for time stamp overflow.
10086 * editfns.c (time_overflow): New function, refactoring common code.
10087 (Fformat_time_string, Fdecode_time, Fencode_time):
10088 (Fcurrent_time_string): Use it.
10090 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10091 * dired.c (make_time): Move to ...
10092 * editfns.c (make_time): ... here.
10093 * systime.h: Note the move.
10095 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10097 * fringe.c (update_window_fringes): Remove unused variables.
10099 * unexmacosx.c (copy_data_segment): Also copy __got section.
10102 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10104 * termcap.c [MSDOS]: Include "msdos.h".
10105 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10106 Constify `char *' arguments and their references according to
10107 prototypes in tparam.h.
10109 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10111 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10112 Adapt all references accordingly.
10114 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10116 2011-03-11 Tom Tromey <tromey@redhat.com>
10118 * buffer.c (syms_of_buffer): Remove obsolete comment.
10120 2011-03-11 Eli Zaretskii <eliz@gnu.org>
10122 * termhooks.h (encode_terminal_code): Declare prototype.
10124 * msdos.c (encode_terminal_code): Don't declare prototype.
10126 * term.c (encode_terminal_code): Now external again, used by
10127 w32console.c and msdos.c.
10129 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10130 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
10132 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
10134 Fix some minor problems found by GCC 4.5.2's static checks.
10136 * fringe.c (update_window_fringes): Mark locals as initialized
10138 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
10140 * alloc.c (mark_fringe_data): Move decl from here ...
10141 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10142 to check its interface.
10143 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10145 * fontset.c (free_realized_fontset): Now static.
10146 (Fset_fontset_font): Rename local to avoid shadowing.
10147 (fontset_font): Mark local as initialized.
10148 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10150 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10152 * xselect.c (x_disown_buffer_selections): Remove; not used.
10153 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10154 (x_own_selection, Fx_disown_selection_internal): Rename locals
10155 to avoid shadowing.
10156 (x_handle_dnd_message): Remove local to avoid shadowing.
10158 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10159 so that the caller can use some name other than gcpro1.
10160 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10161 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10162 (Fx_backspace_delete_keys_p):
10163 Use them to avoid shadowing, and rename vars to avoid shadowing.
10164 (x_decode_color, x_set_name, x_window): Now static.
10165 (Fx_create_frame): Add braces to silence GCC warning.
10166 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10167 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10168 Remove unused locals.
10169 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10170 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10171 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10174 * xterm.h (x_mouse_leave): New decl.
10176 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10177 Remove unused functions.
10178 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10179 (x_calc_absolute_position): Now static.
10180 (XTread_socket): Don't define label "out" unless it's used.
10181 Don't declare local "event" unless it's used.
10182 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10183 unless they are used.
10184 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10185 (x_fatal_error_signal): Remove; not used.
10186 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10187 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10188 (x_error_catcher, x_connection_closed, x_error_handler):
10189 (x_error_quitter, xembed_send_message, x_iconify_frame):
10190 (my_log_handler): Rename locals to avoid shadowing.
10191 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10192 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10194 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10195 Rename or move locals to avoid shadowing.
10196 (tty_defined_color, merge_face_heights): Now static.
10197 (free_realized_faces_for_fontset): Remove; not used.
10198 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10199 does not deduce is never used uninitialized.
10200 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10201 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10203 * terminal.c (store_terminal_param): Now static.
10205 * xmenu.c (menu_highlight_callback): Now static.
10206 (set_frame_menubar): Remove unused local.
10207 (xmenu_show): Rename parameter to avoid shadowing.
10208 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10209 since they might point to immutable storage.
10210 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10211 since it's unused otherwise.
10213 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10214 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10215 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10216 avoids a gcc -Wuninitialized diagnostic.
10217 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10218 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10219 does not deduce are never used uninitialized.
10221 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10223 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10224 * window.c (window_loop, size_window):
10225 (run_window_configuration_change_hook, enlarge_window): Likewise.
10227 * window.c (display_buffer): Now static.
10228 (size_window): Mark variables that gcc -Wuninitialized
10229 does not deduce are never used uninitialized.
10230 * window.h (check_all_windows): New decl, to forestall
10231 gcc -Wmissing-prototypes diagnostic.
10232 * dispextern.h (bidi_dump_cached_states): Likewise.
10234 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10236 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10237 Include <limits.h>.
10238 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10239 and to avoid gcc -Wuninitialized warning.
10240 (load_charset_map): Mark variables that gcc -Wuninitialized
10241 does not deduce are never used uninitialized.
10242 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10244 * coding.c (coding_set_source, coding_set_destination):
10245 Use "else { /* comment */ }" rather than "else /* comment */;"
10246 for clarity, and to avoid gcc -Wempty-body warning.
10247 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10248 a block, when the outer 'i' will do.
10249 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10250 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10251 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10252 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10253 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10254 Rename locals to avoid shadowing.
10255 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10256 * coding.c (emacs_mule_char, encode_invocation_designation):
10257 Now static, since they're not used elsewhere.
10258 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10259 (decode_coding_object, encode_coding_object, detect_coding_system):
10260 (decode_coding_emacs_mule): Mark variables that gcc
10261 -Wuninitialized does not deduce are never used uninitialized.
10262 (detect_coding_iso_2022): Initialize a local variable that might
10263 be used uninitialized. Leave a FIXME because it's not clear that
10264 this initialization is needed. (Bug#8211)
10265 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10266 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10267 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10268 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10269 Remove unused macros.
10271 * category.c (hash_get_category_set): Remove unused local var.
10272 (copy_category_table): Now static, since it's not used elsewhere.
10273 * character.c (string_count_byte8): Likewise.
10275 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10276 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10278 * chartab.c (copy_sub_char_table): Now static, since it's not used
10280 (sub_char_table_ref_and_range, char_table_ref_and_range):
10281 Rename locals to avoid shadowing.
10282 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10284 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10285 (BIDI_BOB): Remove unused macro.
10287 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10288 deduce are never used uninitialized.
10289 * term.c (encode_terminal_code): Likewise.
10291 * term.c (encode_terminal_code): Now static. Remove unused local.
10293 * tparam.h: New file.
10294 * term.c, tparam.h: Include it.
10295 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10296 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10297 Move these decls to tparam.h, and make them agree with what
10298 is actually in tparam.c. The previous trick of using incompatible
10299 decls in different modules does not conform to the C standard.
10300 All callers of tparam changed to use tparam's actual API.
10301 * tparam.c (tparam1, tparam, tgoto):
10302 Use const pointers where appropriate.
10304 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10305 * cm.h (struct cm): Likewise.
10306 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10307 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10308 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10309 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10310 (turn_on_face, init_tty): Likewise.
10311 * termchar.h (struct tty_display_info): Likewise.
10313 * term.c (term_mouse_position): Rename local to avoid shadowing.
10315 * alloc.c (mark_ttys): Move decl from here ...
10316 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10318 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10320 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10322 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10324 * search.c (compile_pattern_1): Remove argument regp, unused since
10325 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10326 (compile_pattern): Don't pass it.
10328 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10330 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10331 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10333 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10335 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10337 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10338 gdk_window_get_screen, gdk_window_get_geometry,
10339 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10340 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10341 (xg_get_pixbuf_from_pixmap): New function.
10342 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10343 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10344 Call xg_get_pixbuf_from_pixmap instead of
10345 gdk_pixbuf_get_from_drawable.
10346 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10347 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10348 (xg_check_special_colors): Use GtkStyleContext and its functions
10350 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10351 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10352 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10353 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10354 Call gtk_widget_get_preferred_size.
10355 (xg_frame_resized): gdk_window_get_geometry only takes 5
10357 (xg_win_to_widget, xg_event_is_for_menubar):
10358 Call gdk_x11_window_lookup_for_display.
10359 (xg_set_widget_bg): New function.
10360 (delete_cb): New function.
10361 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10362 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10363 (xg_set_background_color): Call xg_set_widget_bg.
10364 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10365 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10366 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10367 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10369 (update_frame_tool_bar): Call gtk_widget_hide.
10370 (xg_initialize): Use GDK_KEY_g.
10372 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10374 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10376 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10377 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10378 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10380 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10382 * w32xfns.c (select_palette): Check success of RealizePalette against
10383 GDI_ERROR, not zero.
10385 See ChangeLog.11 for earlier changes.
10387 ;; Local Variables:
10391 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10393 This file is part of GNU Emacs.
10395 GNU Emacs is free software: you can redistribute it and/or modify
10396 it under the terms of the GNU General Public License as published by
10397 the Free Software Foundation, either version 3 of the License, or
10398 (at your option) any later version.
10400 GNU Emacs is distributed in the hope that it will be useful,
10401 but WITHOUT ANY WARRANTY; without even the implied warranty of
10402 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10403 GNU General Public License for more details.
10405 You should have received a copy of the GNU General Public License
10406 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.