Fix cursor motion with long continued lines near window bottom.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4 the display spec is of the form `(space ...)'.
5 (handle_display_spec): Return the value returned by
6 handle_single_display_spec, not just 1 or zero.
7 (handle_single_display_spec): If the display spec is of the form
8 `(space ...)', and specifies display in the text area, return 2
9 rather than 1.
10 (try_cursor_movement): Check for the need to scroll more
11 accurately, and prefer exact match for point under bidi.
12
13 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
14 into disp_prop; all users changed.
15
16 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
17 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
18 for the text covered by the display property.
19
20 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
21
22 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
23 Change return value to nil.
24 (Frecord_buffer): Delete unused function.
25
26 2011-08-24 Eli Zaretskii <eliz@gnu.org>
27
28 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
29 buffers, return left-to-right.
30 (set_cursor_from_row): Consider candidate row a win if its glyph
31 represents a newline and point is on that newline. Fixes cursor
32 positioning on the newline at EOL of R2L text within L2R
33 paragraph, and vice versa.
34 (try_cursor_movement): Check continued rows, in addition to
35 continuation rows. Fixes unwarranted scroll when point enters a
36 continued line of R2L text within an L2R paragraph, or vice versa.
37 (cursor_row_p): Consider the case of point being equal to
38 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
39 from the end of a short line to the beginning of a continued line
40 of R2L text within L2R paragraph.
41 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
42 composed characters.
43
44 * bidi.c (bidi_check_type): Use xassert.
45 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
46 members.
47
48 2011-08-23 Eli Zaretskii <eliz@gnu.org>
49
50 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
51 a character.
52
53 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
54
55 * nsfont.m (ns_otf_to_script): Fix typo.
56
57 2011-08-22 Kenichi Handa <handa@m17n.org>
58
59 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
60 extra slot even if the purpose is char-code-property-table.
61
62 2011-08-23 Eli Zaretskii <eliz@gnu.org>
63
64 * xdisp.c (redisplay_window): When computing centering_position,
65 account for the height of the header line. (Bug#8874)
66
67 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
68 instead of CHAR_TO_BYTE. Fixes a crash when a completion
69 candidate is selected by the mouse, and that candidate has a
70 composed character under the mouse.
71
72 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
73 coordinates reported by pos-visible-in-window-p for a composed
74 character in column zero.
75
76 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
77
78 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
79
80 2011-08-22 Eli Zaretskii <eliz@gnu.org>
81
82 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
83 consider it a hit if to_charpos is anywhere in the range of the
84 composed buffer positions.
85
86 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
87
88 * image.c (gif_load): Don't assume that each subimage has the same
89 dimensions as the base image. Handle disposal method that is
90 "undefined" by the gif spec (Bug#9335).
91
92 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
93
94 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
95 (Fcondition_case): Document `debug' symbol in error handler.
96
97 2011-08-19 Eli Zaretskii <eliz@gnu.org>
98
99 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
100 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
101 from an Org mode buffer to a Speedbar frame.
102
103 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
104 a composition, take its buffer position from IT->cmp_it.charpos.
105 Fixes cursor positioning at the beginning of a line that begins
106 with a composed character.
107
108 2011-08-18 Eli Zaretskii <eliz@gnu.org>
109
110 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
111 character bidirectional type, use STRONG_L instead. Fixes crashes
112 in a buffer produced by `describe-categories'.
113
114 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
115 members before the level stack, so they would be saved and
116 restored when copying iterator state. Fixes incorrect reordering
117 around TABs covered by display properties.
118
119 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
120
121 * process.c (Fnetwork_interface_list): Correctly determine buffer
122 size.
123
124 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
125
126 * eval.c (internal_condition_case, internal_condition_case_1)
127 (internal_condition_case_2, internal_condition_case_n):
128 Remove unnecessary aborts (Bug#9081).
129
130 2011-08-17 Eli Zaretskii <eliz@gnu.org>
131
132 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
133 has no `load' handler, try opening the file locally. (Bug#9311)
134
135 2011-08-16 Ken Brown <kbrown@cornell.edu>
136
137 * gmalloc.c: Expand comment.
138
139 2011-08-16 Eli Zaretskii <eliz@gnu.org>
140
141 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
142 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
143
144 2011-08-16 Ken Brown <kbrown@cornell.edu>
145
146 Fix memory allocation problems in Cygwin build (Bug#9273).
147
148 * unexcw.c ( __malloc_initialized): Declare external variable.
149 (fixup_executable): Force the dumped emacs to reinitialize malloc.
150
151 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
152 New variables.
153 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
154 dumped emacs.
155 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
156 in the static heap.
157 [CYGWIN] (special_realloc): New function.
158 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
159 requests to realloc storage in the static heap.
160
161 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
162
163 * bidi.c (bidi_initialize): Remove unused local.
164
165 2011-08-15 Eli Zaretskii <eliz@gnu.org>
166
167 * biditype.h: File removed.
168
169 * bidimirror.h: File removed.
170
171 * deps.mk (bidi.o): Remove biditype.h and
172 bidimirror.h.
173
174 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
175 bidimirror.h.
176
177 * dispextern.h: Fix a typo in the comment to bidi_type_t.
178
179 * chartab.c: Improve commentary for the uniprop_table API.
180
181 * bidi.c (bidi_paragraph_init): Support zero value of
182 bidi_ignore_explicit_marks_for_paragraph_level.
183 (bidi_initialize): Use uniprop_table instead of including
184 biditype.h and bidimirror.h.
185
186 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
187 coordinates of the iterator when restoring from ppos_it.
188 (Bug#9296)
189
190 2011-08-14 Kenichi Handa <handa@m17n.org>
191
192 * process.c (create_process): Call setup_process_coding_systems
193 after the pid of the process is set to -1 (Bug#8162).
194
195 2011-08-14 Eli Zaretskii <eliz@gnu.org>
196
197 * xdisp.c (move_it_in_display_line_to): Don't invoke
198 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
199 ppos_it. Fixes vertical cursor motion when line beginning is
200 covered by an image. (Bug#9296)
201
202 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
203
204 * nsterm.h (ns_run_ascript): Declare.
205 (NSAPP_DATA2_RUNASSCRIPT): Define.
206
207 * nsfns.m (as_script, as_result, as_status): New static variables.
208 (ns_run_ascript): New function.
209 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
210 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
211 the event loop. Get status from as_status (Bug#7276).
212
213 * nsterm.m (sendEvent): If event is NSApplicationDefined and
214 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
215 the event loop (Bug#7276).
216
217 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
218
219 * gnutls.c (QCgnutls_bootprop_priority)
220 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
221 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
222 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
223 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
224 (QCgnutls_bootprop_verify_hostname_error)
225 (QCgnutls_bootprop_callbacks_verify): Rename from
226 Qgnutls_bootprop_..., all uses changed.
227
228 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
229 uses changed.
230
231 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
232
233 * xfaces.c (Qframe_set_background_mode): Now static.
234 * dispextern.h (Qframe_set_background_mode): Remove decl.
235
236 * process.c (Fnetwork_interface_info): Declare local only if needed.
237
238 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
239
240 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
241 (Fnetwork_interface_list): Allocate in increments of bytes instead
242 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
243 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
244 sockaddr.
245 (struct ifflag_def): notrailers is smart on OSX.
246 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
247 Get hardware address with getifaddrs if available.
248
249 2011-08-12 Eli Zaretskii <eliz@gnu.org>
250
251 * xdisp.c (iterate_out_of_display_property): xassert that
252 IT->position is set to within IT->object's boundaries. Break from
253 the loop as soon as EOB is reached; avoids infloops in redisplay
254 when IT->position is set up wrongly due to some bug.
255 Set IT->current to match the bidi iterator unconditionally.
256 (push_display_prop): Allow GET_FROM_STRING as IT->method on
257 entry. Force push_it to save on the stack the current
258 buffer/string position, to be restored by pop_it. Fix flags in
259 the iterator structure wrt the object coming from a display
260 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
261 properties. (Bug#9284)
262
263 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
264
265 * fontset.c (fontset_get_font_group): Add proper type checks.
266 (Bug#9172)
267
268 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
269
270 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
271 and LC_VERSION_MIN_MACOSX.
272 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
273 (dump_it) [LC_FUNCTION_STARTS]: Use it.
274
275 2011-08-08 Eli Zaretskii <eliz@gnu.org>
276
277 * xdisp.c (forward_to_next_line_start): Allow to use the
278 no-display-properties-and-no-overlays under bidi display.
279 Set disp_pos in the bidi iterator to avoid searches for display
280 properties and overlays.
281
282 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
283
284 * editfns.c (Fset_time_zone_rule): Document relationship with the
285 setenv function.
286
287 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
288 the font entity extracted from the cache (Bug#8109).
289
290 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
291
292 * composite.c (autocmp_chars): Don't reset point. That is done by
293 restore_point_unwind (Bug#5984).
294
295 2011-08-07 Juri Linkov <juri@jurta.org>
296
297 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
298 to show the arg `TIME' instead of `TIMEVAL'.
299
300 2011-08-06 Eli Zaretskii <eliz@gnu.org>
301
302 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
303 display property strides EOL and includes a newline, as in
304 longlines-mode. (Bug#9254)
305 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
306 word-wrap under bidirectional display. (Bug#9224)
307
308 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
309 is non-zero, even if the data buffer is NULL. Fixes a crash in
310 vertical-motion with longlines-mode. (Bug#9254)
311
312 2011-08-05 Eli Zaretskii <eliz@gnu.org>
313
314 * bidi.c <bidi_cache_total_alloc>: Now static.
315 (bidi_initialize): Initialize bidi_cache_total_alloc.
316
317 * xdisp.c (display_line): Release buffer allocated for shelved bidi
318 cache. (Bug#9221)
319
320 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
321 amount allocated this far in `bidi_cache_total_alloc'.
322 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
323 non-zero, only free the data buffer without restoring the cache
324 contents. All callers changed.
325
326 * dispextern.h (bidi_unshelve_cache): Update prototype.
327
328 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
329 (move_it_in_display_line, move_it_to)
330 (move_it_vertically_backward, move_it_by_lines): Replace the call
331 to xfree to an equivalent call to bidi_unshelve_cache.
332 (move_it_in_display_line_to): Fix logic of returning
333 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
334
335 2011-08-05 Eli Zaretskii <eliz@gnu.org>
336
337 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
338 came from a string character with a `cursor' property. (Bug#9229)
339
340 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
341
342 * Makefile.in (LIB_PTHREAD): New variable.
343 (LIBES): Add LIB_PTHREAD (Bug#9216).
344
345 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
346 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
347
348 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
349
350 * regex.c (re_iswctype): Remove some redundant boolean
351 conversions.
352
353 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
354
355 * xterm.c (x_find_topmost_parent): New function.
356 (x_set_frame_alpha): Find topmost parent window with
357 x_find_topmost_parent and set the property there also (bug#9181).
358 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
359
360 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
361
362 * callproc.c (Fcall_process): Avoid vfork clobbering
363 the local vars buffer, coding_systems, current_dir.
364
365 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
366
367 * keymap.c (Fmake_composed_keymap): Move to subr.el.
368
369 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
370
371 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
372 so that it is not optimized away.
373
374 * xdisp.c (compute_display_string_pos): Remove unused local.
375
376 2011-08-02 Eli Zaretskii <eliz@gnu.org>
377
378 Fix slow cursor motion and scrolling in large buffers with
379 selective display, like Org Mode buffers. (Bug#9218)
380
381 * dispextern.h (struct bidi_it): New member disp_prop_p.
382
383 * xdisp.c: Remove one-slot cache of display string positions.
384 (compute_display_string_pos): Accept an additional argument
385 DISP_PROP_P; callers changed. Scan at most 5K characters forward
386 for a display string or property. If found, set DISP_PROP_P
387 non-zero.
388
389 * bidi.c (bidi_fetch_char): Accept an additional argument
390 DISP_PROP_P, and pass it to compute_display_string_pos.
391 Only handle text covered by a display string if DISP_PROP_P is returned
392 non-zero. All callers of bidi_fetch_char changed.
393
394 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
395
396 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
397
398 2010-12-03 Don March <don@ohspite.net>
399
400 * keymap.c (Fdefine_key): Fix non-prefix key error message when
401 last character M-[char] is translated to ESC [char] (bug#7541).
402
403 2011-08-02 Kenichi Handa <handa@m17n.org>
404
405 * lisp.h (uniprop_table): Extern it.
406
407 * chartab.c (uniprop_table): Make it non-static.
408
409 2011-08-01 Eli Zaretskii <eliz@gnu.org>
410
411 * xdisp.c (forward_to_next_line_start): Accept additional argument
412 BIDI_IT_PREV, and store into it the state of the bidi iterator had
413 on the newline.
414 (reseat_at_next_visible_line_start): Use the bidi iterator state
415 returned by forward_to_next_line_start to restore the state of
416 it->bidi_it after backing up to previous newline. (Bug#9212)
417
418 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
419
420 * regex.c (re_comp): Protoize.
421 (re_exec): Fix return type.
422 (regexec): Fix type of `ret'. (Bug#9203)
423
424 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
425
426 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
427 This is needed if max-image-size is a floating-point number.
428
429 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
430
431 * print.c (print_object): Print empty symbol as ##.
432
433 * lread.c (read1): Read ## as empty symbol.
434
435 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
436
437 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
438 setting frame foreground color (Bug#9175).
439 (x_set_background_color): Likewise.
440
441 * nsmenu.m (-setText): Size tooltip dimensions precisely to
442 contents (Bug#9176).
443 (EmacsTooltip -init): Remove bezels and add shadows to
444 tooltip windows.
445
446 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
447 or scroll bar (Bug#8470).
448
449 * nsfont.m (nsfont_open): Remove assignment to voffset and
450 unnecessary vars hshink, expand, hd, full_height, min_height.
451 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
452
453 * nsterm.h (nsfont_info): Remove voffset field.
454
455 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
456
457 Implement strike-through and overline on NextStep (Bug#8863).
458
459 * nsfont.m (nsfont_open): Use underline position provided by font,
460 instead of hard-coded value of 2.
461 (nsfont_draw): Call ns_draw_text_decoration instead.
462
463 * nsterm.h: Add declaration for ns_draw_text_decoration.
464
465 * nsterm.m (ns_draw_text_decoration): New function for drawing
466 underline, overline, and strike-through.
467 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
468 ns_draw_text_decoration. Change treatment of cursor drawing to
469 accomodate underlining, etc.
470
471 2011-07-28 Eli Zaretskii <eliz@gnu.org>
472
473 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
474 default.
475
476 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
477
478 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
479 Without this fix, if a signal arrives just after memory fills up,
480 'malloc' might be invoked reentrantly.
481
482 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
483 In other words, assume that every image size is allowed, on non-X
484 hosts. This assumption is probably wrong, but it lets Emacs compile.
485
486 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
487
488 * regex.c (re_iswctype): Convert return values to boolean.
489
490 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
491
492 * xdisp.c (compute_display_string_pos): Don't use cached display
493 string position if the buffer had its restriction changed.
494 (Bug#9184)
495
496 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
497
498 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
499
500 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
501
502 Integer signedness and overflow and related fixes. (Bug#9079)
503
504 * bidi.c: Integer size and overflow fixes.
505 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
506 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
507 (bidi_cache_find_level_change, bidi_cache_ensure_space)
508 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
509 (bidi_find_other_level_edge):
510 Use ptrdiff_t instead of EMACS_INT where either will do.
511 This works better on 32-bit hosts configured --with-wide-int.
512 (bidi_cache_ensure_space): Check for size-calculation overflow.
513 Use % rather than repeated addition, for better worst-case speed.
514 Don't set bidi_cache_size until after xrealloc returns, because it
515 might not return.
516 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
517 (bidi_cache_ensure_space): Also check that the bidi cache size
518 does not exceed that of the largest Lisp string or buffer. See Eli
519 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
520
521 * alloc.c (__malloc_size_t): Remove.
522 All uses replaced by size_t. See Andreas Schwab's note
523 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
524
525 * image.c: Improve checking for integer overflow.
526 (check_image_size): Assume that f is nonnull, since
527 it is always nonnull in practice. This is one less thing to
528 worry about when checking for integer overflow later.
529 (x_check_image_size): New function, which checks for integer
530 overflow issues inside X.
531 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
532 This removes the need for a memory_full check.
533 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
534 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
535 (xbm_read_bitmap_data): Change locals back to 'int', since
536 their values must fit in 'int'.
537 (xpm_load_image, png_load, tiff_load):
538 Invoke x_create_x_image_and_pixmap earlier,
539 to avoid much needless work if the image is too large.
540 (tiff_load): Treat overly large images as if
541 x_create_x_image_and_pixmap failed, not as malloc failures.
542 (gs_load): Use x_check_image_size.
543
544 * gtkutil.c: Omit integer casts.
545 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
546 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
547
548 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
549
550 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
551 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
552 would wrongly return t on a 64-bit host.
553
554 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
555 The plain *_OVERFLOW macros run afoul of GCC bug 49705
556 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
557 and therefore cause GCC to emit a bogus diagnostic in some cases.
558
559 * image.c: Integer signedness and overflow and related fixes.
560 This is not an exhaustive set of fixes, but it's time to
561 record what I've got.
562 (lookup_pixel_color, check_image_size): Remove redundant decls.
563 (check_image_size): Don't assume that arbitrary EMACS_INT values
564 fit in 'int', or that arbitrary 'double' values fit in 'int'.
565 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
566 (tiff_load, imagemagick_load_image):
567 Check for overflow in size calculations.
568 (x_create_x_image_and_pixmap): Remove unnecessary test for
569 xmalloc returning NULL; that can't happen.
570 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
571 (xpm_color_bucket): Use better integer hashing function.
572 (xpm_cache_color): Don't possibly over-allocate memory.
573 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
574 (gif_memory_source):
575 Use ptrdiff_t, not int or size_t, to record sizes.
576 (png_load): Don't assume values greater than 2**31 fit in 'int'.
577 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
578 either works, as we prefer signed integers.
579 (tiff_read_from_memory, tiff_write_from_memory):
580 Return tsize_t, not size_t, since that's what the TIFF API wants.
581 (tiff_read_from_memory): Don't fail simply because the read would
582 go past EOF; instead, return a short read.
583 (tiff_load): Omit no-longer-needed casts.
584 (Fimagemagick_types): Don't assume size fits into 'int'.
585
586 Improve hashing quality when configured --with-wide-int.
587 * fns.c (hash_string): New function, taken from sxhash_string.
588 Do not discard information about ASCII character case; this
589 discarding is no longer needed.
590 (sxhash-string): Use it. Change sig to match it. Caller changed.
591 * lisp.h: Declare it.
592 * lread.c (hash_string): Remove, since we now use fns.c's version.
593 The fns.c version returns a wider integer if --with-wide-int is
594 specified, so this should help the quality of the hashing a bit.
595
596 * emacs.c: Integer overflow minor fix.
597 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
598 Define only if GNU_LINUX.
599 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
600
601 * dispnew.c: Integer signedness and overflow fixes.
602 Remove unnecessary forward decls, that were a maintenance hassle.
603 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
604 All uses changed.
605 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
606 (scrolling_window): Use ptrdiff_t, not int, for byte count.
607 (prepare_desired_row, line_draw_cost):
608 Use int, not unsigned, where either works.
609 (save_current_matrix, restore_current_matrix):
610 Use ptrdiff_t, not size_t, where either works.
611 (init_display): Check for overflow more accurately, and without
612 relying on undefined behavior.
613
614 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
615 Remove, replacing with the new symbols in lisp.h. All uses changed.
616 * fileio.c (make_temp_name):
617 * filelock.c (lock_file_1, lock_file):
618 * xdisp.c (message_dolog):
619 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
620 Use pMd etc. instead.
621 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
622 replacing the pWIDE etc. symbols removed from editfns.c.
623
624 * keyboard.h (num_input_events): Now uintmax_t.
625 This is (very slightly) less likely to mess up due to wraparound.
626 All uses changed.
627
628 * buffer.c: Integer signedness fixes.
629 (alloc_buffer_text, enlarge_buffer_text):
630 Use ptrdiff_t rather than size_t when either will do, as we prefer
631 signed integers.
632
633 * alloc.c: Integer signedness and overflow fixes.
634 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
635 (__malloc_size_t): Default to size_t, not to int.
636 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
637 (Fgarbage_collect, mark_object_loop_halt, mark_object):
638 Prefer ptrdiff_t to size_t when either would do, as we prefer
639 signed integers.
640 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
641 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
642 Now const. Initialize with values that are in range even if char
643 is signed.
644 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
645 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
646 These functions do the right thing with sizes > 2**32.
647 (check_depth): Now ptrdiff_t, not int.
648 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
649 Adjust to new way of storing sizes. Check for size overflow bugs
650 in rest of code.
651 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
652 slightly wrong anyway, as it missed one instance of
653 XMALLOC_OVERRUN_CHECK_OVERHEAD.
654 (refill_memory_reserve): Omit needless cast to size_t.
655 (mark_object_loop_halt): Mark as externally visible.
656
657 * xselect.c: Integer signedness and overflow fixes.
658 (Fx_register_dnd_atom, x_handle_dnd_message):
659 Use ptrdiff_t, not size_t, since we prefer signed.
660 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
661 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
662 x_dnd_atoms_size and x_dnd_atoms_length.
663
664 * doprnt.c: Prefer signed to unsigned when either works.
665 * eval.c (verror):
666 * doprnt.c (doprnt):
667 * lisp.h (doprnt):
668 * xdisp.c (vmessage):
669 Use ptrdiff_t, not size_t, when using or implementing doprnt,
670 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
671 prefer signed arithmetic to avoid comparison confusion.
672 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
673 but is a bit tricky.
674
675 Assume freestanding C89 headers, string.h, stdlib.h.
676 * data.c, doprnt.c, floatfns.c, print.c:
677 Include float.h unconditionally.
678 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
679 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
680 * regex.c: Likewise for stddef.h, string.h.
681 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
682 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
683 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
684 (STDC_HEADERS): Remove obsolete defines.
685 * sysdep.c: Include limits.h unconditionally.
686
687 Assume support for memcmp, memcpy, memmove, memset.
688 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
689 * regex.c (memcmp, memcpy):
690 Remove; we assume C89 now.
691
692 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
693 (__malloc_safe_bcopy): Remove; no longer needed.
694
695 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
696 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
697 well either way, and we prefer signed to unsigned.
698
699 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
700
701 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
702 closes the connection while we're reading (bug#9182).
703
704 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
705
706 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
707 are specified (Bug#9168).
708
709 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
710
711 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
712 Found by GCC static checking and --with-wide-int on a 32-bit host.
713
714 2011-07-25 Eli Zaretskii <eliz@gnu.org>
715
716 * xdisp.c (compute_display_string_pos): Fix logic of caching
717 previous display string position. Initialize cached_prev_pos to
718 -1. Fixes slow-down at the beginning of a buffer.
719
720 2011-07-24 Eli Zaretskii <eliz@gnu.org>
721
722 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
723 for attrs[LFACE_FONTSET_INDEX].
724
725 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
726
727 * xml.c (parse_region): Remove unused local
728 that was recently introduced.
729
730 2011-07-23 Eli Zaretskii <eliz@gnu.org>
731
732 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
733 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
734
735 * xdisp.c (move_it_in_display_line_to): Record the best matching
736 position for TO_CHARPOS while scanning the line, and restore it on
737 exit if none of the characters scanned was an exact match.
738 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
739 when exact match is impossible due to invisible text, and the
740 lines are truncated.
741
742 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
743
744 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
745 for OSX >= 10.7.
746
747 2011-07-22 Eli Zaretskii <eliz@gnu.org>
748
749 Fix a significant slow-down of cursor motion with C-n, C-p,
750 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
751 auto-repeat under bidi redisplay in fontified buffers.
752 * xdisp.c (compute_stop_pos_backwards): New function.
753 (next_element_from_buffer): Call compute_stop_pos_backwards to
754 find a suitable prev_stop when we find ourselves before
755 base_level_stop.
756 (reseat): Don't look for prev_stop, as that could mean a very long
757 run.
758 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
759 <cached_disp_overlay_modiff>: Cache for last found display string
760 position.
761 (compute_display_string_pos): Return the cached position if asked
762 about the same buffer in the same area of character positions, and
763 the buffer wasn't changed since the time the display string
764 position was cached.
765
766 2011-07-22 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
769 is an integer, which is important for empty lines. (Bug#9149)
770
771 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
772
773 * frame.c (Fmodify_frame_parameters): In tty case, update the
774 default face if necessary (Bug#4238).
775
776 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
777
778 * editfns.c (Fstring_to_char): No need to explain what a character
779 is in the docstring (Bug#6576).
780
781 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
782
783 * xml.c (parse_region): Make sure we always return a tree.
784
785 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
786
787 * xml.c (parse_region): If a document contains only comments,
788 return that, too.
789
790 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
791
792 * xml.c (make_dom): Return comments, too.
793
794 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
795
796 Port to OpenBSD.
797 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
798 and the surrounding thread.
799 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
800 rather than fgets, and retry after EINTR. Otherwise, 'emacs
801 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
802 timer goes off.
803 * s/openbsd.h (BROKEN_SIGIO): Define.
804 * unexelf.c (unexec) [__OpenBSD__]:
805 Don't update the .mdebug section of the Alpha COFF symbol table.
806
807 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
808
809 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
810 (bug#8460).
811
812 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
813
814 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
815 This fixes some race conditions on the permissions of any newly
816 created file.
817
818 * alloc.c (valid_pointer_p): Use pipe, not open.
819 This fixes some permissions issues when debugging.
820
821 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
822 If fchown fails to set both uid and gid, try to set just gid,
823 as that is sometimes allowed. Adjust the file's mode to eliminate
824 setuid or setgid bits that are inappropriate if fchown fails.
825
826 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
827
828 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
829 to compare Lisp_Objects.
830 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
831 global_gnutls_log_level, don't mistake it for a Lisp_Object.
832 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
833
834 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
835
836 * lread.c (read_integer): Unread even EOF character.
837 (read1): Likewise. Properly record start position of symbol.
838
839 * lread.c (read1): Read `#:' as empty uninterned symbol if no
840 symbol character follows.
841
842 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
843
844 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
845 This works around a problem with the previous change to Fcopy_file.
846 Recent glibc declares fchown with __attribute__((warn_unused_result)),
847 and without this change, GCC might complain about discarding
848 fchown's return value.
849
850 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
851
852 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
853
854 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
855
856 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
857
858 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
859
860 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
861 it's used from the C level.
862
863 * process.c: Use the same condition for POLL_FOR_INPUT in both
864 keyboard.c and process.c (bug#1858).
865
866 2011-07-09 Lawrence Mitchell <wence@gmx.li>
867
868 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
869 (Fgnutls_boot): Use it.
870
871 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
872
873 * doc.c (Fsubstitute_command_keys): Revert last change.
874
875 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
876
877 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
878 quotes the next character, and doesn't affect other longer
879 sequences (bug#8935).
880
881 * lread.c (syms_of_lread): Clarify that is isn't only
882 `eval-buffer' and `eval-defun' that's affected by
883 `lexical-binding' (bug#8460).
884
885 2011-07-15 Eli Zaretskii <eliz@gnu.org>
886
887 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
888 bidi redisplay when a line includes both an image and is
889 truncated.
890
891 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
892
893 Fix minor problems found by static checking.
894 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
895 (elsz): Now a signed constant, not a size_t var. We prefer signed
896 types to unsigned, to avoid integer comparison confusion. Without
897 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
898 "cannot optimize loop, the loop counter may overflow", a symptom
899 of the confusion.
900 * indent.c (Fvertical_motion): Mark locals as initialized.
901 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
902
903 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
904
905 * search.c (Fre_search_backward): Mention `case-fold-search' in
906 all the re_search_* functions (bug#8138).
907
908 * keyboard.c (Fopen_dribble_file): Document when the file is
909 closed (bug#8056).
910
911 2011-07-14 Eli Zaretskii <eliz@gnu.org>
912
913 * bidi.c (bidi_dump_cached_states): Fix format of displaying
914 bidi_cache_idx.
915
916 Support bidi reordering of display and overlay strings.
917 * xdisp.c (compute_display_string_pos)
918 (compute_display_string_end): Accept additional argument STRING.
919 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
920 (reseat_to_string): Initialize bidi_it->string.s and
921 bidi_it->string.schars.
922 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
923 NULL (avoids a crash in bidi_paragraph_init).
924 Initialize itb.string.lstring.
925 (init_iterator): Call bidi_init_it only of a valid
926 buffer position was specified. Initialize paragraph_embedding to
927 L2R.
928 (reseat_to_string): Initialize the bidi iterator.
929 (display_string): If we need to ignore text properties of
930 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
931 original value of -1 will not work with bidi.)
932 (compute_display_string_pos): First arg is now struct
933 `text_pos *'; all callers changed. Support display properties on
934 Lisp strings.
935 (compute_display_string_end): Support display properties on Lisp
936 strings.
937 (init_iterator, reseat_1, reseat_to_string): Initialize the
938 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
939 when iterating on a string not from display properties).
940 (compute_display_string_pos, compute_display_string_end):
941 Fix calculation of the object to scan. Fixes an error when using
942 arrow keys.
943 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
944 base_level_stop; instead, set base_level_stop to BEGV.
945 Fixes crashes in vertical-motion.
946 (next_element_from_buffer): Improve commentary for when
947 the iterator is before prev_stop.
948 (init_iterator): Initialize bidi_p from the default value of
949 bidi-display-reordering, not from buffer-local value. Use the
950 buffer-local value only if initializing for buffer iteration.
951 (handle_invisible_prop): Support invisible properties on strings
952 that are being bidi-reordered.
953 (set_iterator_to_next): Support bidi reordering of C strings and
954 Lisp strings.
955 (next_element_from_string): Support bidi reordering of Lisp
956 strings.
957 (handle_stop_backwards): Support Lisp strings as well.
958 (display_string): Support display of R2L glyph rows.
959 Use IT_STRING_CHARPOS when displaying from a Lisp string.
960 (init_iterator): Don't initialize it->bidi_p for strings
961 here.
962 (reseat_to_string): Initialize it->bidi_p for strings here.
963 (next_element_from_string, next_element_from_c_string)
964 (next_element_from_buffer): Add xassert's for correspondence
965 between IT's object being iterated and it->bidi_it.string
966 structure.
967 (face_before_or_after_it_pos): Support bidi iteration.
968 (next_element_from_c_string): Handle the case of the first string
969 character that is not the first one in the visual order.
970 (get_visually_first_element): New function, refactored from common
971 parts of next_element_from_buffer, next_element_from_string, and
972 next_element_from_c_string.
973 (tool_bar_lines_needed, redisplay_tool_bar)
974 (display_menu_bar): Force left-to-right direction. Add a FIXME
975 comment for making that be controlled by a user option.
976 (push_it, pop_it): Save and restore the state of the
977 bidi iterator. Save and restore the bidi_p flag.
978 (pop_it): Iterate out of display property for string iteration as
979 well.
980 (iterate_out_of_display_property): Support iteration over strings.
981 (handle_single_display_spec): Set up it->bidi_it for iteration
982 over a display string, and call bidi_init_it.
983 (handle_single_display_spec, next_overlay_string)
984 (get_overlay_strings_1, push_display_prop): Set up the bidi
985 iterator for displaying display or overlay strings.
986 (forward_to_next_line_start): Don't use the shortcut if
987 bidi-iterating.
988 (back_to_previous_visible_line_start): If handle_display_prop
989 pushed the iterator stack, restore the internal state of the bidi
990 iterator by calling bidi_pop_it same number of times.
991 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
992 and we are bidi-iterating, don't decrement the iterator position;
993 instead, set the first_elt flag in the bidi iterator, to produce
994 the same effect.
995 (reseat_1): Remove redundant setting of string_from_display_prop_p.
996 (push_display_prop): xassert that we are iterating a buffer.
997 (push_it, pop_it): Save and restore paragraph_embedding member.
998 (handle_single_display_spec, next_overlay_string)
999 (get_overlay_strings_1, reseat_1, reseat_to_string)
1000 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1001 correctly. Don't assume unibyte strings are not bidi-reordered.
1002 (compute_display_string_pos)
1003 (compute_display_string_end): Fix handling the case of C string.
1004 (push_it, pop_it): Save and restore from_disp_prop_p.
1005 (handle_single_display_spec, push_display_prop): Set the
1006 from_disp_prop_p flag.
1007 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1008 (pop_it): Call iterate_out_of_display_property only if we are
1009 popping after iteration over a string that came from a display
1010 property. Fix a typo in popping stretch info. Add an assertion
1011 for verifying that the iterator position is in sync with the bidi
1012 iterator.
1013 (handle_single_display_spec, get_overlay_strings_1)
1014 (push_display_prop): Fix initialization of paragraph direction for
1015 string when that of the parent object is not yet determined.
1016 (reseat_1): Call bidi_init_it to resync the bidi
1017 iterator with IT's position. (Bug#7616)
1018 (find_row_edges): If ROW->start.pos gives position
1019 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1020 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1021 Reset the from_disp_prop_p flag.
1022 (SAVE_IT, RESTORE_IT): New macros.
1023 (pos_visible_p, face_before_or_after_it_pos)
1024 (back_to_previous_visible_line_start)
1025 (move_it_in_display_line_to, move_it_in_display_line)
1026 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1027 (try_scrolling, redisplay_window, display_line): Use them when
1028 saving a temporary copy of the iterator and restoring it back.
1029 (back_to_previous_visible_line_start, reseat_1)
1030 (init_iterator): Empty the bidi cache "stack".
1031 (move_it_in_display_line_to): If iterator ended up at
1032 EOL, but we never saw any buffer positions smaller than
1033 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1034 motion in bidi-reordered lines.
1035 (move_it_in_display_line_to): Record prev_method and prev_pos
1036 immediately before the call to set_iterator_to_next. Fixes cursor
1037 motion in bidi-reordered lines with stretch glyphs and strings
1038 displayed in margins. (Bug#8133) (Bug#8867)
1039 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1040 TO_CHARPOS.
1041 (pos_visible_p): Support positions in bidi-reordered lines.
1042 Save and restore bidi cache.
1043
1044 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1045 (bidi_paragraph_info): Delete unused struct.
1046 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1047 (bidi_cache_start): New variable.
1048 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1049 to zero.
1050 (bidi_cache_fetch_state, bidi_cache_search)
1051 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1052 (bidi_cache_find, bidi_peek_at_next_level)
1053 (bidi_level_of_next_char, bidi_find_other_level_edge)
1054 (bidi_move_to_visually_next): Compare cache index with
1055 bidi_cache_start rather than with zero.
1056 (bidi_fetch_char): Accept new argument STRING; all callers
1057 changed. Support iteration over a string. Support strings with
1058 display properties. Support unibyte strings. Fix the type of
1059 `len' according to what STRING_CHAR_AND_LENGTH expects.
1060 (bidi_paragraph_init, bidi_resolve_explicit_1)
1061 (bidi_resolve_explicit, bidi_resolve_weak)
1062 (bidi_level_of_next_char, bidi_move_to_visually_next):
1063 Support iteration over a string.
1064 (bidi_set_sor_type, bidi_resolve_explicit_1)
1065 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1066 can now be zero (for strings); special values 0 and -1 were
1067 changed to -1 and -2, respectively.
1068 (bidi_char_at_pos): New function.
1069 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1070 Call it instead of FETCH_MULTIBYTE_CHAR.
1071 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1072 initialized to valid values.
1073 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1074 values.
1075 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1076 the test for valid cached positions. Fix the logic for looking up
1077 the sentinel state in the cache. GCPRO the Lisp string we are
1078 iterating.
1079 (bidi_push_it, bidi_pop_it): New functions.
1080 (bidi_initialize): Initialize the bidi cache start stack pointer.
1081 (bidi_cache_ensure_space): New function, refactored from part of
1082 bidi_cache_iterator_state. Don't assume the required size is just
1083 one BIDI_CACHE_CHUNK away.
1084 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1085 (bidi_count_bytes, bidi_char_at_pos): New functions.
1086 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1087 always valid if bidi_cache_idx is valid.
1088 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1089 is valid if it's going to be used.
1090 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1091 (bidi_cache_fetch_state, bidi_cache_search)
1092 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1093 (bidi_cache_iterator_state, bidi_cache_find)
1094 (bidi_find_other_level_edge, bidi_cache_start_stack):
1095 All variables related to cache indices are now EMACS_INT.
1096
1097 * dispextern.h (struct bidi_string_data): New structure.
1098 (struct bidi_it): New member `string'. Make flag members be 1-bit
1099 fields, and put them last in the struct.
1100 (compute_display_string_pos, compute_display_string_end):
1101 Update prototypes.
1102 (bidi_push_it, bidi_pop_it): Add prototypes.
1103 (struct iterator_stack_entry): New members bidi_p,
1104 paragraph_embedding, and from_disp_prop_p.
1105 (struct it): Member bidi_p is now a bit field 1 bit wide.
1106 (bidi_shelve_cache, bidi_unshelve_cache):
1107 Declare prototypes.
1108
1109 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1110 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1111 and vector-like objects.
1112
1113 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1114 cache around display iteration.
1115
1116 * window.c (Fwindow_end, window_scroll_pixel_based)
1117 (displayed_window_lines, Frecenter): Save and restore the bidi
1118 cache around display iteration.
1119
1120 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1121
1122 * editfns.c (Fdelete_region): Clarify the use of the named
1123 parameters (bug#6788).
1124
1125 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1126
1127 * indent.c (Fvertical_motion): Set and restore w->pointm when
1128 saving and restoring the window's buffer (Bug#9006).
1129
1130 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1131
1132 * editfns.c (Fstring_to_char): Clarify just what is returned
1133 (bug#6576). Text by Eli Zaretskii.
1134
1135 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1136
1137 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1138
1139 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1140
1141 * buffer.c (mmap_find): Fix a typo.
1142
1143 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1144
1145 Fix execution of x selection hooks.
1146 * xselect.c (Qx_lost_selection_functions)
1147 (Qx_sent_selection_functions): New vars.
1148 (syms_of_xselect): DEFSYM them.
1149 (x_handle_selection_request): Pass Qx_sent_selection_functions
1150 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1151 (x_handle_selection_clear,x_clear_frame_selections):
1152 Pass Qx_lost_selection_functions rather than
1153 Vx_lost_selection_functions to Frun_hook_with_args.
1154
1155 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1158 The old code sometimes used this field without initializing it.
1159
1160 * alloc.c (gc_sweep): Don't read past end of array.
1161 In theory, the old code could also have corrupted Emacs internals,
1162 though it'd be very unlikely.
1163
1164 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1165
1166 * character.c (Fcharacterp): Don't advertise optional ignored
1167 argument. (Bug#4026)
1168
1169 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1170
1171 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1172 key" (bug#4257).
1173
1174 * window.c (Fset_window_start): Doc fix (bug#4199).
1175 (Fset_window_hscroll): Ditto.
1176
1177 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 Fix minor new problems caught by GCC 4.6.1.
1180 * term.c (init_tty): Remove unused local.
1181 * xsettings.c (store_monospaced_changed): Define this function only
1182 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1183 not used otherwise.
1184
1185 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1186
1187 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1188
1189 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1190
1191 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1192 are the mini-buffer and the echo area (bug#3320).
1193
1194 * term.c (init_tty): Remove support for supdup, c10 and perq
1195 terminals, which are no longer supported (bug#1482).
1196
1197 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1198
1199 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1200
1201 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1202
1203 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1204 for non-popups (Bug#3642).
1205
1206 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1207
1208 * alloc.c (reset_malloc_hooks): Protoize.
1209 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1210 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1211 * cm.c (losecursor): Likewise.
1212 * data.c (fmod): Likewise.
1213 * dispnew.c (swap_glyphs_in_rows): Likewise.
1214 * emacs.c (memory_warning_signal): Likewise.
1215 * floatfns.c (float_error): Likewise.
1216 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1217 (otf_open, font_otf_capability, generate_otf_features)
1218 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1219 Likewise.
1220 * image.c (pbm_read_file): Likewise.
1221 * indent.c (string_display_width): Likewise.
1222 * intervals.c (check_for_interval, search_for_interval)
1223 (inc_interval_count, count_intervals, root_interval)
1224 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1225 * lread.c (defalias): Likewise.
1226 * ralloc.c (r_alloc_check): Likewise.
1227 * regex.c (set_image_of_range_1, set_image_of_range)
1228 (regex_grow_registers): Likewise.
1229 * sysdep.c (strerror): Likewise.
1230 * termcap.c (valid_filename_p, tprint, main): Likewise.
1231 * tparam.c (main): Likewise.
1232 * unexhp9k800.c (run_time_remap, save_data_space)
1233 (update_file_ptrs, read_header, write_header, calculate_checksum)
1234 (copy_file, copy_rest, display_header): Likewise.
1235 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1236 Likewise.
1237 * xdisp.c (check_it): Likewise.
1238 * xfaces.c (register_color, unregister_color, unregister_colors):
1239 Likewise.
1240 * xfns.c (print_fontset_result): Likewise.
1241 * xrdb.c (member, fatal, main): Likewise.
1242
1243 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 Fix minor problems found by static checking (Bug#9031).
1246 * chartab.c (char_table_set_range, map_sub_char_table):
1247 Remove unused locals.
1248 (uniprop_table): Now static.
1249 * composite.c (_work_char): Remove unused static var.
1250
1251 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1252
1253 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1254
1255 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1256
1257 * gtkutil.c (qttip_cb): Remove code without function.
1258
1259 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1260
1261 * w32.c (pthread_sigmask): New stub.
1262
1263 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1264
1265 Use pthread_sigmask, not sigprocmask (Bug#9010).
1266 sigprocmask is portable only for single-threaded applications, and
1267 Emacs can be multi-threaded when it uses GTK.
1268 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1269 (LIBES): Use it.
1270 * callproc.c (Fcall_process):
1271 * process.c (create_process):
1272 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1273 Use pthread_sigmask, not sigprocmask.
1274
1275 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1276
1277 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1278 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1279 wrong (Bug#8591).
1280
1281 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1282
1283 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1284 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1285 (xg_hide_tooltip): Fix comment.
1286
1287 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1288 in registerServicesMenuSendTypes.
1289 (validRequestorForSendType): Don't check ns_return_types.
1290
1291 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1292 ns_return_type.
1293
1294 2011-07-08 Jason Rumney <jasonr@gnu.org>
1295
1296 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1297 frame struct members of non-existent frames (Bug#6284).
1298
1299 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1300
1301 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1302 variable firstTime not needed on OSX >= 10.6.
1303 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1304 >= 10.5. Use setKnobProportion, setDoubleValue.
1305
1306 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1307 (MAC_OS_X_VERSION_10_5): Define if not defined.
1308 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1309 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1310 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1311
1312 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1313 cString and lossyCString on OSX >= 10.4
1314
1315 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1316 sizeToFit on OSX >= 10.2.
1317
1318 * nsimage.m (allocInitFromFile): Don't use deprecated method
1319 bestRepresentationForDevice on OSX >= 10.6.
1320
1321 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1322 to avoid warning.
1323
1324 * emacs.c: Declare unexec_init_emacs_zone.
1325
1326 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1327
1328 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1329
1330 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1331 on svcsMenu (Bug#8842).
1332
1333 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1334 ns_return_types.
1335 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1336
1337 * nsterm.m (QUTF8_STRING): Declare.
1338 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1339 (validRequestorForSendType): Return type is (id).
1340 Change indexOfObjectIdenticalTo to indexOfObject.
1341 Check if we have local selection before returning self (Bug#8842).
1342 (writeSelectionToPasteboard): Put local selection into paste board
1343 if we have a local selection (Bug#8842).
1344 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1345
1346 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1347 (ns_get_local_selection): Declare.
1348
1349 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1350
1351 * keymap.c (describe_map_tree): Don't insert a double newline at
1352 the end of the buffer (bug#1169) and return whether we inserted
1353 something.
1354
1355 * callint.c (Fcall_interactively): Change "reading args" to
1356 "providing args" to try to clarify what it does (bug#1010).
1357
1358 2011-07-07 Kenichi Handa <handa@m17n.org>
1359
1360 * composite.c (composition_compute_stop_pos): Ignore a static
1361 composition starting before CHARPOS (Bug#8915).
1362
1363 * xdisp.c (handle_composition_prop): Likewise.
1364
1365 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1366
1367 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1368 (Bug#9015)
1369
1370 2011-07-07 Kenichi Handa <handa@m17n.org>
1371
1372 * character.h (unicode_category_t): New enum type.
1373
1374 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1375 (Qchar_code_property_table): New variable.
1376 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1377 (UNIPROP_COMPRESSED_FORM_P): New macros.
1378 (char_table_ascii): Uncompress the compressed values.
1379 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1380 Uncompress the compressed values.
1381 (sub_char_table_ref_and_range): Likewise.
1382 (char_table_ref_and_range): Uncompress the compressed values.
1383 (sub_char_table_set): New arg is_uniprop. Callers changed.
1384 Uncompress the compressed values.
1385 (sub_char_table_set_range): Args changed. Callers changed.
1386 (char_table_set_range): Adjuted for the above change.
1387 (map_sub_char_table): Delete args default_val and parent. Add arg
1388 top. Give decoded values to a Lisp function.
1389 (map_char_table): Adjust for the above change. Give decoded
1390 values to a Lisp function. Gcpro more variables.
1391 (uniprop_table_uncompress)
1392 (uniprop_decode_value_run_length): New functions.
1393 (uniprop_decoder, uniprop_decoder_count): New variables.
1394 (uniprop_get_decoder, uniprop_encode_value_character)
1395 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1396 New functions.
1397 (uniprop_encoder, uniprop_encoder_count): New variables.
1398 (uniprop_get_encoder, uniprop_table)
1399 (Funicode_property_table_internal, Fget_unicode_property_internal)
1400 (Fput_unicode_property_internal): New functions.
1401 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1402 Sunicode_property_table_internal, Sget_unicode_property_internal,
1403 and Sput_unicode_property_internal. Defvar_lisp
1404 char-code-property-alist.
1405
1406 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1407 Vunicode_category_table.
1408
1409 * font.c (font_range): Adjust for the change of
1410 Vunicode_category_table.
1411
1412 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1413
1414 * m/iris4d.h: Remove file, move contents ...
1415 * s/irix6-5.h: ... here.
1416
1417 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 Remove unportable assumption about struct layout (Bug#8884).
1420 * alloc.c (mark_buffer):
1421 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1422 (clone_per_buffer_values): Don't assume that
1423 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1424 This isn't true in general, and it's particularly not true
1425 if Emacs is configured with --with-wide-int.
1426 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1427 New macros, used in the buffer.c change.
1428
1429 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1430
1431 * xsettings.c: Use both GConf and GSettings if both are available.
1432 (store_config_changed_event): Add comment.
1433 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1434 (store_tool_bar_style_changed): New functions.
1435 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1436 (struct xsettings): Move font inside HAVE_XFT.
1437 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1438 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1439 Move inside HAVE_XFT.
1440 (something_changed_gsettingsCB): Rename from something_changedCB.
1441 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1442 also.
1443 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1444 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1445 (something_changed_gconfCB): Rename from something_changedCB.
1446 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1447 (parse_settings): Move check for font inside HAVE_XFT.
1448 (read_settings, apply_xft_settings): Add comment.
1449 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1450 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1451 call store_font_name_changed.
1452 (xft_settings_event): Add comment.
1453 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1454 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1455 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1456 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1457 (xsettings_initialize): Call init_gsettings last.
1458 (xsettings_get_system_font, xsettings_get_system_normal_font):
1459 Add comment.
1460
1461 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 Random fixes. E.g., (random) never returned negative values.
1464 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1465 subseconds part to the entropy, as that's a bit more random.
1466 Prefer signed to unsigned, since the signedness doesn't matter and
1467 in general we prefer signed. When given a limit, use a
1468 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1469 latter isn't right if USE_2_TAGS_FOR_INTS.
1470 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1471 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1472
1473 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1474
1475 * textprop.c (text_property_stickiness):
1476 Obey Vtext_property_default_nonsticky.
1477 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1478 * w32fns.c (syms_of_w32fns):
1479 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1480
1481 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1482
1483 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1484 This is more efficient than Ffile_directory_p and avoids a minor race.
1485
1486 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1487
1488 * buffer.c (Foverlay_put): Say what the return value is
1489 (bug#7835).
1490
1491 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1492 is a directory before asking whether to use the file name
1493 (bug#7564).
1494 (barf_or_query_if_file_exists): Make the "File is a directory"
1495 error be more correct.
1496
1497 * fns.c (Frequire): Remove the mention of the .gz files, since
1498 that's installation-specific, but keep the mention of
1499 `get-load-suffixes'.
1500
1501 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1504 Report string overflow if the output is too long.
1505
1506 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1507
1508 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1509 (syms_of_gnutls): Remove duplicate DEFSYM for
1510 Qgnutls_bootprop_verify_hostname_error, an error for
1511 Qgnutls_bootprop_verify_error (which is no longer used).
1512
1513 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1514 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1515 Also (re)move comments that are misplaced or no longer relevant.
1516
1517 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1518
1519 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1520
1521 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1522
1523 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1524 and background color parameters if they have been changed.
1525
1526 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1527
1528 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1529
1530 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1531
1532 * xsettings.c (SYSTEM_FONT): Define only when used.
1533 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1534
1535 * keymap.c (access_keymap_1): Now static.
1536
1537 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1538
1539 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1540 leave any prefix arg for the up event (Bug#1586).
1541
1542 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1543
1544 * lread.c (syms_of_lread): Mention single symbols defined by
1545 `defvar' or `defconst' (bug#7154).
1546
1547 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1548 (Frequire): Mention get-load-suffixes.
1549
1550 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1551
1552 * window.h (window): Remove clone_number slot.
1553 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1554 Remove.
1555 (make_parent_window, make_window, saved_window)
1556 (Fset_window_configuration, save_window_save): Don't deal with
1557 clone numbers.
1558 * buffer.c (Qclone_number): Remove declaration.
1559 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1560
1561 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1562
1563 Add multiple inheritance to keymaps.
1564 * keymap.c (Fmake_composed_keymap): New function.
1565 (Fset_keymap_parent): Simplify.
1566 (fix_submap_inheritance): Remove.
1567 (access_keymap_1): New function extracted from access_keymap to handle
1568 embedded parents and handle lists of maps.
1569 (access_keymap): Use it.
1570 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1571 (Fcopy_keymap): Handle embedded parents.
1572 (Fcommand_remapping, define_as_prefix): Simplify.
1573 (Fkey_binding): Simplify.
1574 (syms_of_keymap): Move minibuffer-local-completion-map,
1575 minibuffer-local-filename-completion-map,
1576 minibuffer-local-must-match-map, and
1577 minibuffer-local-filename-must-match-map to Elisp.
1578 (syms_of_keymap): Defsubr make-composed-keymap.
1579 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1580 (parse_menu_item): Trivial simplification.
1581
1582 2011-07-01 Glenn Morris <rgm@gnu.org>
1583
1584 * Makefile.in (SETTINGS_LIBS): Fix typo.
1585
1586 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1587
1588 * coding.c (Fencode_coding_string): Record the last coding system
1589 used, as the function doc string says (bug#8738).
1590
1591 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1592
1593 * xsettings.c (store_monospaced_changed): Take new font as arg and
1594 check for change against current_mono_font.
1595 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1596 (emacs_settings_constructor, emacs_settings_get_property)
1597 (emacs_settings_set_property, emacs_settings_class_init)
1598 (emacs_settings_init, gsettings_obj): Remove.
1599 (something_changedCB): New function for HAVE_GSETTINGS.
1600 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1601 with value as argument.
1602 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1603 g_settings_new (Bug#8967). Do not create gsettings_obj.
1604 Remove calls to g_settings_bind. Connect something_changedCB to
1605 "changed".
1606
1607 * xgselect.c: Add defined (HAVE_GSETTINGS).
1608 (xgselect_initialize): Ditto.
1609
1610 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1611 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1612 xg_select.
1613
1614 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 * eval.c (struct backtrace): Simplify and port the data structure.
1617 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1618 signed bit field, as this assumption is not portable and it makes
1619 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1620 "char debug_on_exit : 1" as this is not portable either; instead,
1621 use the portable "unsigned int debug_on_exit : 1". Remove unused
1622 member evalargs. Remove obsolete comments about cc bombing out.
1623
1624 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1625
1626 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1627 Let HAVE_GSETTINGS override HAVE_GCONF.
1628 (store_monospaced_changed): New function.
1629 (EMACS_SETTINGS): A new type derived from GObject to handle
1630 GSettings notifications.
1631 (emacs_settings_constructor, emacs_settings_get_property)
1632 (emacs_settings_set_property, emacs_settings_class_init):
1633 New functions.
1634 (gsettings_client, gsettings_obj): New variables.
1635 (GSETTINGS_SCHEMA): New define.
1636 (something_changedCB): Call store_monospaced_changed.
1637 (init_gsettings): New function.
1638 (xsettings_initialize): Call init_gsettings.
1639 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1640 to NULL.
1641
1642 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1643 GCONF_CFLAGS/LIBS.
1644
1645 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1646
1647 * window.c (resize_root_window, grow_mini_window)
1648 (shrink_mini_window): Rename Qresize_root_window to
1649 Qwindow_resize_root_window and Qresize_root_window_vertically to
1650 Qwindow_resize_root_window_vertically.
1651
1652 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1653
1654 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1655
1656 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1657
1658 * makefile.w32-in: Redesign dependencies so they reflect more
1659 clearly which files are directly included by each source file,
1660 and not through other includes.
1661
1662 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1663
1664 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1665 (sort_overlays, overlay_strings): When an overlay's clone number
1666 matches the window's clone number process the overlay even if
1667 the overlay's window property doesn't match the current window.
1668
1669 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1670 (Fwindow_hchild): Rename to Fwindow_left_child.
1671 (Fwindow_next): Rename to Fwindow_next_sibling.
1672 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1673 (resize_window_check): Rename to window_resize_check.
1674 (resize_window_apply): Rename to window_resize_apply.
1675 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1676 (Fdelete_other_windows_internal, resize_frame_windows)
1677 (Fsplit_window_internal, Fdelete_window_internal)
1678 (grow_mini_window, shrink_mini_window)
1679 (Fresize_mini_window_internal): Fix callers accordingly.
1680
1681 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1682
1683 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1684 (emacs_fixed_set_min_size): Remove.
1685 (emacs_fixed_new): Take frame as argument.
1686
1687 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1688 (_EmacsFixedPrivate): Remove minwidth/height.
1689 Add struct frame *f.
1690 (emacs_fixed_init): Initialize priv->f.
1691 (get_parent_class, emacs_fixed_set_min_size): Remove.
1692 (emacs_fixed_new): Set priv->f to argument.
1693 (emacs_fixed_get_preferred_width)
1694 (emacs_fixed_get_preferred_height): Use min_width/height from
1695 frames size_hint to set minimum and natural (Bug#8919).
1696 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1697 and use min_width/height from frames size_hint to set
1698 min_width/height (Bug#8919).
1699
1700 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1701 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1702 Fix indentation.
1703
1704 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1705
1706 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1707 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1708 called at ZV.
1709
1710 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1711
1712 * process.c (wait_reading_process_output): Bypass select if
1713 waiting for a cell while ignoring keyboard input, and input is
1714 pending. Suggested by Jan Djärv (Bug#8869).
1715
1716 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 Use gnulib's dup2 module instead of rolling our own.
1719 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1720
1721 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1722
1723 * dispnew.c (scrolling_window): Before scrolling, turn off a
1724 mouse-highlight in the window being scrolled.
1725
1726 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1727
1728 Move DEFSYM to lisp.h and use everywhere.
1729
1730 * character.h (DEFSYM): Move declaration...
1731 * lisp.h (DEFSYM): ...here.
1732
1733 * gnutls.c:
1734 * minibuf.c:
1735 * w32menu.c:
1736 * w32proc.c:
1737 * w32select.c: Don't include character.h.
1738
1739 * alloc.c (syms_of_alloc):
1740 * buffer.c (syms_of_buffer):
1741 * bytecode.c (syms_of_bytecode):
1742 * callint.c (syms_of_callint):
1743 * casefiddle.c (syms_of_casefiddle):
1744 * casetab.c (init_casetab_once):
1745 * category.c (init_category_once, syms_of_category):
1746 * ccl.c (syms_of_ccl):
1747 * cmds.c (syms_of_cmds):
1748 * composite.c (syms_of_composite):
1749 * dbusbind.c (syms_of_dbusbind):
1750 * dired.c (syms_of_dired):
1751 * dispnew.c (syms_of_display):
1752 * doc.c (syms_of_doc):
1753 * editfns.c (syms_of_editfns):
1754 * emacs.c (syms_of_emacs):
1755 * eval.c (syms_of_eval):
1756 * fileio.c (syms_of_fileio):
1757 * fns.c (syms_of_fns):
1758 * frame.c (syms_of_frame):
1759 * fringe.c (syms_of_fringe):
1760 * insdel.c (syms_of_insdel):
1761 * keymap.c (syms_of_keymap):
1762 * lread.c (init_obarray, syms_of_lread):
1763 * macros.c (syms_of_macros):
1764 * msdos.c (syms_of_msdos):
1765 * print.c (syms_of_print):
1766 * process.c (syms_of_process):
1767 * search.c (syms_of_search):
1768 * sound.c (syms_of_sound):
1769 * syntax.c (init_syntax_once, syms_of_syntax):
1770 * terminal.c (syms_of_terminal):
1771 * textprop.c (syms_of_textprop):
1772 * undo.c (syms_of_undo):
1773 * w32.c (globals_of_w32):
1774 * window.c (syms_of_window):
1775 * xdisp.c (syms_of_xdisp):
1776 * xfaces.c (syms_of_xfaces):
1777 * xfns.c (syms_of_xfns):
1778 * xmenu.c (syms_of_xmenu):
1779 * xsettings.c (syms_of_xsettings):
1780 * xterm.c (syms_of_xterm): Use DEFSYM.
1781
1782 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1783
1784 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1785
1786 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 Integer and buffer overflow fixes (Bug#8873).
1789
1790 * print.c (printchar, strout): Check for string overflow.
1791 (PRINTPREPARE, printchar, strout):
1792 Don't set size unless allocation succeeds.
1793
1794 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1795 for sizes. Check for string overflow more accurately.
1796 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1797
1798 * macros.c: Integer and buffer overflow fixes.
1799 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1800 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1801 Use ptrdiff_t, not int, for sizes.
1802 Don't increment bufsize until after realloc succeeds.
1803 Check for size-calculation overflow.
1804 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1805
1806 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1807
1808 * lread.c: Integer overflow fixes.
1809 (read_integer): Radix is now EMACS_INT, not int,
1810 to improve quality of diagnostics for out-of-range radices.
1811 Calculate buffer size correctly for out-of-range radices.
1812 (read1): Check for integer overflow in radices, and in
1813 read-circle numbers.
1814 (read_escape): Avoid int overflow.
1815 (Fload, openp, read_buffer_size, read1)
1816 (substitute_object_recurse, read_vector, read_list, map_obarray):
1817 Use ptrdiff_t, not int, for sizes.
1818 (read1): Use EMACS_INT, not int, for sizes.
1819 Check for size overflow.
1820
1821 * image.c (cache_image): Check for size arithmetic overflow.
1822
1823 * lread.c: Integer overflow issues.
1824 (saved_doc_string_size, saved_doc_string_length)
1825 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1826 Now ptrdiff_t, not int.
1827 (read1): Don't assume doc string length fits in int. Check for
1828 out-of-range doc string lengths.
1829 (read_list): Don't assume file position fits in int.
1830 (read_escape): Check for hex character overflow.
1831
1832 2011-06-22 Leo Liu <sdl.web@gmail.com>
1833
1834 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1835 Move to minibuffer.el.
1836
1837 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1840 The following patches are for when GLYPH_DEBUG && !XASSERT.
1841 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1842 * dispnew.c (flush_stdout):
1843 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1844 Mark as externally visible.
1845 * dispnew.c (check_window_matrix_pointers): Now static.
1846 * dispnew.c (window_to_frame_vpos):
1847 * xfns.c (unwind_create_frame):
1848 * xterm.c (x_check_font): Remove unused local.
1849 * scroll.c (CHECK_BOUNDS):
1850 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1851 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1852 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1853 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1854 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1855 Now static.
1856 (debug_method_add): Use va_list and vsprintf rather than relying
1857 on undefined behavior with wrong number of arguments.
1858 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1859 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1860 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1861 since we're not interested in debugging glyphs with old libraries.
1862 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1863 GCC 4.6.0's static checking.
1864
1865 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 Integer overflow and signedness fixes (Bug#8873).
1868 A few related buffer overrun fixes, too.
1869
1870 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1871
1872 * dispextern.h (struct face.stipple):
1873 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1874 (x_bitmap_mask, x_allocate_bitmap_record)
1875 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1876 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1877 (x_create_bitmap_from_xpm_data):
1878 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1879 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1880 (.bitmaps_last):
1881 * xfaces.c (load_pixmap):
1882 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1883 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1884 (.bitmaps_last, struct x_output.icon_bitmap):
1885 Use ptrdiff_t, not int, for bitmap indexes.
1886 (x_allocate_bitmap_record): Check for size overflow.
1887 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1888
1889 Use ptrdiff_t, not int, for overlay counts.
1890 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1891 * editfns.c (overlays_around, get_pos_property):
1892 * textprop.c (get_char_property_and_overlay):
1893 * xdisp.c (next_overlay_change, note_mouse_highlight):
1894 * xfaces.c (face_at_buffer_position):
1895 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1896 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1897 (Fnext_overlay_change, Fprevious_overlay_change)
1898 (mouse_face_overlay_overlaps, Foverlays_in):
1899 Use ptrdiff_t, not int, for sizes.
1900 (overlays_at, overlays_in): Check for size-calculation overflow.
1901
1902 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1903
1904 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1905 (x_session_initialize): Do not assume string length fits in int.
1906
1907 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1908 This is unlikely, but can occur if DPI is outlandish.
1909
1910 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1911 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1912
1913 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1914 * xrdb.c (magic_file_p, search_magic_path):
1915 Omit last arg SUFFIX; it was always 0. All callers changed.
1916 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1917
1918 * xfont.c (xfont_match): Avoid need for strlen.
1919
1920 * xfns.c: Don't assume strlen fits in int.
1921 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1922
1923 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1924 not unsigned long, as we prefer signed integers. All callers changed.
1925 Detect integer overflow in repeat count.
1926 (message_dolog): Don't assume print length fits in 39 bytes.
1927 (display_mode_element): Don't assume strlen fits in int.
1928
1929 * termcap.c: Don't assume sizes fit in int and never overflow.
1930 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1931 (gobble_line): Check for size-calculation overflow.
1932
1933 * minibuf.c (Fread_buffer):
1934 * lread.c (intern, intern_c_string):
1935 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1936 Don't assume string length fits in int.
1937
1938 * keyboard.c (parse_tool_bar_item):
1939 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1940
1941 * font.c: Don't assume string length fits in int.
1942 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1943 Use ptrdiff_t, not int.
1944 (font_intern_prop): Don't assume string length fits in int.
1945 Don't assume integer property fits in fixnum.
1946 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1947
1948 * filelock.c: Fix some buffer overrun and integer overflow issues.
1949 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1950 Reformulate so as not to need the command string.
1951 Invoke gzip -cd rather than gunzip, as it's more portable.
1952 (lock_info_type, lock_file_1, lock_file):
1953 Don't assume pid_t and time_t fit in unsigned long.
1954 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1955 (current_lock_owner): Prefer signed type for sizes.
1956 Use memcpy, not strncpy, where memcpy is what is really wanted.
1957 Don't assume (via atoi) that time_t and pid_t fit in int.
1958 Check for time_t and/or pid_t out of range, e.g., via a network share.
1959 Don't alloca where an auto var works fine.
1960
1961 * fileio.c: Fix some integer overflow issues.
1962 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1963 Don't assume string length fits in int.
1964 (directory_file_name): Don't assume string length fits in long.
1965 (make_temp_name): Don't assume pid fits in int, or that its print
1966 length is less than 20.
1967
1968 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1969
1970 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1971
1972 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1973
1974 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1975 We prefer signed integers, even for size calculations.
1976
1977 * emacs.c: Don't assume string length fits in 'int'.
1978 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1979 (main): Don't invoke strlen when not needed.
1980
1981 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1982 (XD_DEBUG_MESSAGE): Don't waste a byte.
1983
1984 * callproc.c (getenv_internal_1, getenv_internal)
1985 (Fgetenv_internal):
1986 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1987
1988 * lread.c (invalid_syntax): Omit length argument.
1989 All uses changed. This doesn't fix a bug, but it simplifies the
1990 code away from its former Hollerith-constant appearance, and it's
1991 one less 'int' to worry about when looking at integer-overflow issues.
1992 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1993
1994 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1995 This didn't break anything, but it didn't help either.
1996 It's confusing to put a bogus integer in a place where the actual
1997 value does not matter.
1998 (LIST_END_P): Remove unused macro and its bogus comment.
1999 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2000
2001 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2002 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2003 implementation.
2004 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2005 We prefer signed types, and the value cannot exceed the EMACS_INT
2006 range anyway (because otherwise the length would not be representable).
2007 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2008 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2009 This avoids a GCC warning when WIDE_EMACS_INT.
2010
2011 * indent.c (sane_tab_width): New function.
2012 (current_column, scan_for_column, Findent_to, position_indentation)
2013 (compute_motion): Use it. This is just for clarity.
2014 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2015
2016 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2017
2018 * lisp.h (lint_assume): New macro.
2019 * composite.c (composition_gstring_put_cache):
2020 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2021
2022 * editfns.c, insdel.c:
2023 Omit unnecessary forward decls, to simplify future changes.
2024
2025 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2026
2027 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2028
2029 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2030 Use much-faster test for byte-length change.
2031 Don't assume string byte-length fits in 'int'.
2032 Check that character arg fits in 'int'.
2033 (mapcar1): Declare byte as byte, for clarity.
2034
2035 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2036
2037 * fns.c (concat): Catch string overflow earlier.
2038 Do not rely on integer wraparound.
2039
2040 * dispextern.h (struct it.overlay_strings_charpos)
2041 (struct it.selective): Now EMACS_INT, not int.
2042 * xdisp.c (forward_to_next_line_start)
2043 (back_to_previous_visible_line_start)
2044 (reseat_at_next_visible_line_start, next_element_from_buffer):
2045 Don't arbitrarily truncate the value of 'selective' to int.
2046
2047 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2048
2049 * composite.c: Don't truncate sizes to 'int'.
2050 (composition_gstring_p, composition_reseat_it)
2051 (composition_adjust_point): Use EMACS_INT, not int.
2052 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2053 not EMACS_UINT, for indexes.
2054
2055 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2056
2057 * buffer.c: Include <verify.h>.
2058 (struct sortvec.priority, struct sortstr.priority):
2059 Now EMACS_INT, not int.
2060 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2061 (struct sortstr.size, record_overlay_string)
2062 (struct sortstrlist.size, struct sortlist.used):
2063 Don't truncate size to int.
2064 (record_overlay_string): Check for size-calculation overflow.
2065 (init_buffer_once): Check at compile-time, not run-time.
2066
2067 2011-06-22 Jim Meyering <meyering@redhat.com>
2068
2069 Don't leak an XBM-image-sized buffer
2070 * image.c (xbm_load): Free the image buffer after using it.
2071
2072 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2073
2074 Port to Sun C.
2075 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2076 that Sun C diagnosed.
2077 * fns.c (secure_hash): Fix pointer signedness issue.
2078 * intervals.c (static_offset_intervals): New function.
2079 (offset_intervals): Use it.
2080
2081 2011-06-21 Leo Liu <sdl.web@gmail.com>
2082
2083 * deps.mk (fns.o):
2084 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2085 sha512.h.
2086
2087 * fns.c (secure_hash): Rename from crypto_hash_function and change
2088 the first arg to accept symbols.
2089 (Fsecure_hash): New primitive.
2090 (syms_of_fns): New symbols.
2091
2092 2011-06-20 Deniz Dogan <deniz@dogan.se>
2093
2094 * process.c (Fset_process_buffer): Clarify return value in
2095 docstring.
2096
2097 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2098
2099 * dispnew.c (add_window_display_history): Use BVAR.
2100
2101 * xdisp.c (debug_method_add): Use BVAR.
2102 (check_window_end, dump_glyph_matrix, dump_glyph)
2103 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2104
2105 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2106 Likewise.
2107
2108 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2109 check till after the cache is created in init_frame_faces.
2110
2111 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2112
2113 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2114
2115 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2116
2117 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2118 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2119 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2120
2121 Improve buffer-overflow checking (Bug#8873).
2122 * fileio.c (Finsert_file_contents):
2123 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2124 Remove the old (too-loose) buffer overflow checks.
2125 They weren't needed, since make_gap checks for buffer overflow.
2126 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2127 The old code merely checked for Emacs fixnum overflow, and relied
2128 on undefined (wraparound) behavior. The new code avoids undefined
2129 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2130
2131 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2132 Tune. Don't use wider integers than needed. Don't use alloca.
2133 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2134
2135 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2136
2137 * insdel.c, lisp.h (buffer_overflow): New function.
2138 (insert_from_buffer_1, replace_range, replace_range_2):
2139 * insdel.c (make_gap_larger):
2140 * editfns.c (Finsert_char):
2141 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2142
2143 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2144
2145 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2146
2147 Integer overflow and signedness fixes (Bug#8873).
2148
2149 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2150 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2151
2152 * fileio.c: Don't assume EMACS_INT fits in off_t.
2153 (emacs_lseek): New static function.
2154 (Finsert_file_contents, Fwrite_region): Use it.
2155 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2156
2157 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2158
2159 * fns.c: Don't overflow int when computing a list length.
2160 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2161 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2162 truncation on 64-bit hosts. Check for QUIT every
2163 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2164 faster and is responsive enough.
2165 (Flength): Report an error instead of overflowing an integer.
2166 (Fsafe_length): Return a float if the value is not representable
2167 as a fixnum. This shouldn't happen except in contrived situations.
2168 (Fnthcdr, Fsort): Don't assume list length fits in int.
2169 (Fcopy_sequence): Don't assume vector length fits in int.
2170
2171 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2172 (header_size, word_size): New constants.
2173 (allocate_vectorlike): Don't check size overflow here.
2174 (allocate_vector): Check it here instead, since this is the only
2175 caller of allocate_vectorlike that could cause overflow.
2176 Check that the new vector's length is representable as a fixnum.
2177
2178 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2179 The previous code was bogus. For example, next_almost_prime (32)
2180 returned 39, which is undesirable as it is a multiple of 3; and
2181 next_almost_prime (24) returned 25, which is a multiple of 5 so
2182 why was the code bothering to check for multiples of 7?
2183
2184 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2185
2186 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2187
2188 Variadic C functions now count arguments with ptrdiff_t.
2189 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2190 Back then I didn't know that the Emacs coding style prefers signed int.
2191 Also, in the meantime I found a few more instances where arguments
2192 were being counted with int, which may truncate counts on 64-bit
2193 machines, or EMACS_INT, which may be unnecessarily wide.
2194 * lisp.h (struct Lisp_Subr.function.aMANY)
2195 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2196 Arg counts are now ptrdiff_t, not size_t.
2197 All variadic functions and their callers changed accordingly.
2198 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2199 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2200 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2201 * callint.c (Fcall_interactively): Check arg count for overflow,
2202 to avoid potential buffer overrun. Use signed char, not 'int',
2203 for 'varies' array, so that we needn't bother to check its size
2204 calculation for overflow.
2205 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2206 * eval.c (apply_lambda):
2207 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2208 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2209 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2210
2211 * callint.c (Fcall_interactively): Don't use index var as event count.
2212
2213 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2214 * mem-limits.h (SIZE): Remove; no longer used.
2215
2216 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2217
2218 Remove unnecessary casts.
2219 * xterm.c (x_term_init):
2220 * xfns.c (x_set_border_pixel):
2221 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2222 These aren't needed now that we assume ANSI C.
2223
2224 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2225 It's more likely to cause problems (due to unsigned overflow)
2226 than to cure them.
2227
2228 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2229
2230 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2231
2232 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2233
2234 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2235
2236 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2237
2238 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2239
2240 GLYPH_CODE_FACE returns EMACS_INT, not int.
2241 * dispextern.h (merge_faces):
2242 * xfaces.c (merge_faces):
2243 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2244 Don't assume EMACS_INT fits in int.
2245
2246 * character.h (CHAR_VALID_P): Remove unused parameter.
2247 * fontset.c, lisp.h, xdisp.c: All uses changed.
2248
2249 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2250
2251 * fns.c (concat): Minor tuning based on overflow analysis.
2252 This doesn't fix any bugs. Use int to hold character, instead
2253 of constantly refetching from Emacs object. Use XFASTINT, not
2254 XINT, for value known to be a character. Don't bother comparing
2255 a single byte to 0400, as it's always less.
2256
2257 * floatfns.c (Fexpt):
2258 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2259
2260 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2261 for characters.
2262
2263 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2264
2265 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2266 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2267 incorrectly succeed when S was a string, because 4294967386 was
2268 truncated before it was used.
2269
2270 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2271 Otherwise, an out-of-range integer could cause undefined behavior
2272 on a 64-bit host.
2273
2274 * composite.c: Use int, not EMACS_INT, for characters.
2275 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2276 EMACS_INT, for values that are known to be in character range.
2277 This doesn't fix any bugs but is the usual style inside Emacs and
2278 may generate better code on 32-bit machines.
2279
2280 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2281 This is for reasons similar to the recent CHAR_STRING fix.
2282 * charset.c (Fencode_char): Check that character arg is actually
2283 a character. Pass an int to ENCODE_CHAR.
2284 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2285 wider than 'int', as a compile-time check to prevent future regressions
2286 in this area.
2287
2288 * character.c (char_string): Remove unnecessary casts.
2289
2290 Make sure a 64-bit char is never passed to CHAR_STRING.
2291 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2292 by silently ignoring the top 32 bits, allowing some values
2293 that were far too large to be valid characters.
2294 * character.h: Include <verify.h>.
2295 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2296 arguments are no wider than unsigned, as a compile-time check
2297 to prevent future regressions in this area.
2298 * data.c (Faset):
2299 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2300 (Fsubst_char_in_region):
2301 * fns.c (concat):
2302 * xdisp.c (decode_mode_spec_coding):
2303 Adjust to CHAR_STRING's new requirement.
2304 * editfns.c (Finsert_char, Fsubst_char_in_region):
2305 * fns.c (concat): Check that character args are actually
2306 characters. Without this test, these functions did the wrong
2307 thing with wildly out-of-range values on 64-bit hosts.
2308
2309 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2310 These casts should not be needed on 32-bit hosts, either.
2311 * keyboard.c (read_char):
2312 * lread.c (Fload): Remove casts to unsigned.
2313
2314 * lisp.h (UNSIGNED_CMP): New macro.
2315 This fixes comparison bugs on 64-bit hosts.
2316 (ASCII_CHAR_P): Use it.
2317 * casefiddle.c (casify_object):
2318 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2319 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2320 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2321 * dispextern.h (FACE_FROM_ID):
2322 * keyboard.c (read_char): Use UNSIGNED_CMP.
2323
2324 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2325 not to EMACS_INT, to avoid GCC warning.
2326
2327 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2328
2329 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2330 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2331 isn't needed on 32-bit machines.
2332
2333 * buffer.c (Fgenerate_new_buffer_name):
2334 Use EMACS_INT for count, not int.
2335 (advance_to_char_boundary): Return EMACS_INT, not int.
2336
2337 * data.c (Qcompiled_function): Now static.
2338
2339 * window.c (window_body_lines): Now static.
2340
2341 * image.c (gif_load): Rename local to avoid shadowing.
2342
2343 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2344 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2345 * alloc.c (make_save_value): Integer argument is now of type
2346 ptrdiff_t, not int.
2347 (mark_object): Use ptrdiff_t, not int.
2348 * lisp.h (pD): New macro.
2349 * print.c (print_object): Use it.
2350
2351 * alloc.c: Use EMACS_INT, not int, to count objects.
2352 (total_conses, total_markers, total_symbols, total_vector_size)
2353 (total_free_conses, total_free_markers, total_free_symbols)
2354 (total_free_floats, total_floats, total_free_intervals)
2355 (total_intervals, total_strings, total_free_strings):
2356 Now EMACS_INT, not int. All uses changed.
2357 (Fgarbage_collect): Compute overall total using a double, so that
2358 integer overflow is less likely to be a problem. Check for overflow
2359 when converting back to an integer.
2360 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2361 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2362 These were 'int' variables that could overflow on 64-bit hosts;
2363 they were never used, so remove them instead of repairing them.
2364 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2365 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2366 Previously, this ceilinged at INT_MAX, but that doesn't work on
2367 64-bit machines.
2368 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2369
2370 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2371 (allocate_vectorlike): Check for ptrdiff_t overflow.
2372 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2373 when a (possibly-narrower) signed value would do just as well.
2374 We prefer using signed arithmetic, to avoid comparison confusion.
2375
2376 * alloc.c: Catch some string size overflows that we were missing.
2377 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2378 for convenience in STRING_BYTES_MAX.
2379 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2380 The definition here is exact; the one in lisp.h was approximate.
2381 (allocate_string_data): Check for string overflow. This catches
2382 some instances we weren't catching before. Also, it catches
2383 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2384 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2385 and ptrdiff_t and EMACS_INT are both 64 bits.
2386
2387 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2388 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2389 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2390
2391 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2392
2393 * alloc.c (Fmake_string): Check for out-of-range init.
2394
2395 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2396
2397 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2398
2399 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2400
2401 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2402 xg_get_default_scrollbar_width.
2403
2404 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2405 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2406 (style_changed_cb): Call update_theme_scrollbar_width and call
2407 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2408 all frames (Bug#8505).
2409 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2410 Call gtk_window_set_resizable if HAVE_GTK3.
2411 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2412 and height if HAVE_GTK3 (Bug#8505).
2413 (scroll_bar_width_for_theme): New variable.
2414 (update_theme_scrollbar_width): New function.
2415 (xg_get_default_scrollbar_width): Move code to
2416 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2417 (xg_initialize): Call update_theme_scrollbar_width.
2418
2419 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2420
2421 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2422
2423 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2424
2425 * frame.c (make_frame): Call other_buffer_safely instead of
2426 other_buffer.
2427
2428 * window.c (temp_output_buffer_show): Call display_buffer with
2429 second argument Vtemp_buffer_show_specifiers and reset latter
2430 immediately after the call.
2431 (Vtemp_buffer_show_specifiers): New variable.
2432 (auto_window_vscroll_p, next_screen_context_lines)
2433 (Vscroll_preserve_screen_position): Remove leading asterisks from
2434 doc-strings.
2435
2436 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2437
2438 Fix minor problems found by GCC 4.6.0 static checking.
2439 * buffer.c (Qclone_number): Remove for now, as it's unused.
2440 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2441 (record_buffer): Remove unused local.
2442 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2443 (set_frame_buffer_list): Remove; unused.
2444 * frame.h (other_visible_frames): Remove decl.
2445 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2446 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2447 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2448 if HAVE_GPM.
2449 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2450 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2451 Define only if HAVE_GPM.
2452 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2453 (update_hints_inhibit): Remove; never set. All uses removed.
2454 * widgetprv.h (emacsFrameClassRec): Remove decl.
2455 * window.c (delete_deletable_window): Now returns void, since it
2456 wasn't returning anything.
2457 (compare_window_configurations): Remove unused locals.
2458 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2459 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2460 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2461 the same widths as pointers. This follows up on the 2011-05-06 patch.
2462 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2463 * xterm.h: Likewise.
2464 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2465
2466 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2467
2468 * makefile.w32-in: Update dependencies.
2469 (LISP_H): Add lib/intprops.h.
2470
2471 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2472
2473 * image.c (gif_load): Add animation frame delay to the metadata.
2474 (syms_of_image): Use DEFSYM. New symbol `delay'.
2475
2476 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2477
2478 * window.c (delete_deletable_window): Re-add.
2479 (Fset_window_configuration): Rewrite to handle dead buffers and
2480 consequently deletable windows.
2481 (window_tree, Fwindow_tree): Remove. Supply functionality in
2482 window.el.
2483 (compare_window_configurations): Simplify code.
2484
2485 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2486
2487 * image.c (imagemagick_load_image): Fix type mismatch.
2488 (Fimagemagick_types): Likewise.
2489
2490 * window.h (replace_buffer_in_windows): Declare.
2491
2492 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2493
2494 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2495 Qclone_number. Remove external declaration of Qdelete_window.
2496 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2497 code.
2498 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2499 Run Qbuffer_list_update_hook if allowed.
2500 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2501 buffer list implementation.
2502 (other_buffer_safely): New function.
2503 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2504 calls to replace_buffer_in_windows and
2505 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2506 if allowed.
2507 (record_buffer): Inhibit quitting and rewrite using quittable
2508 functions. Run Qbuffer_list_update_hook if allowed.
2509 (Frecord_buffer, Funrecord_buffer): New functions.
2510 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2511 Move switch-to-buffer to window.el.
2512 (bury-buffer): Move to window.el.
2513 (Vbuffer_list_update_hook): New variable.
2514
2515 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2516 section.
2517
2518 * window.h (resize_frame_windows): Move up in code.
2519 (Fwindow_frame): Remove EXFUN.
2520 (replace_buffer_in_all_windows): Remove prototype.
2521 (replace_buffer_in_windows_safely): Add prototype.
2522
2523 * window.c: Declare Qdelete_window static again. Move down
2524 declaration of select_count.
2525 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2526 (Fother_window): Move to window.el.
2527 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2528 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2529 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2530 window.el.
2531 (replace_buffer_in_windows): Implement by calling
2532 Qreplace_buffer_in_windows.
2533 (replace_buffer_in_all_windows): Remove with some functionality
2534 moved into replace_buffer_in_windows_safely.
2535 (replace_buffer_in_windows_safely): New function.
2536 (select_window_norecord, select_frame_norecord): Move in front
2537 of run_window_configuration_change_hook. Remove now obsolete
2538 declarations.
2539 (Fset_window_buffer): Rewrite doc-string.
2540 Call Qrecord_window_buffer.
2541 (keys_of_window): Move binding for other-window to window.el.
2542
2543 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2544
2545 * dispextern.h (struct image): Replace data member, whose int_val
2546 and ptr_val fields were not used by anything, with a single
2547 lisp_val object.
2548
2549 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2550 (gif_clear_image, gif_load, imagemagick_load_image)
2551 (gs_clear_image, gs_load): Callers changed.
2552
2553 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2554
2555 * buffer.h: Include <time.h>, for time_t.
2556 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2557
2558 Fix minor problems found by static checking.
2559
2560 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2561
2562 Make identifiers static if they are not used in other modules.
2563 * data.c (Qcompiled_function, Qframe, Qvector):
2564 * image.c (QimageMagick, Qsvg):
2565 * minibuf.c (Qmetadata):
2566 * window.c (resize_window_check, resize_root_window): Now static.
2567 * window.h (resize_window_check, resize_root_window): Remove decls.
2568
2569 * window.c (window_deletion_count, delete_deletable_window):
2570 Remove; unused.
2571 (window_body_lines): Now static.
2572 (Fdelete_other_windows_internal): Mark vars as initialized.
2573 Make sure 'resize_failed' is initialized.
2574 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2575 (resize_window_apply): Remove unused local.
2576 * window.h (delete_deletable_window): Remove decl.
2577
2578 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2579 (imagemagick_load_image): Fix pointer signedness problem by changing
2580 last arg from unsigned char * to char *. All uses changed.
2581 Also, fix a local for similar reasons.
2582 Remove unused locals. Remove locals to avoid shadowing.
2583 (fn_rsvg_handle_free): Remove; unused.
2584 (svg_load, svg_load_image): Fix pointer signedness problem.
2585 (imagemagick_load_image): Don't use garbage pointer image_wand.
2586
2587 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2588
2589 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2590
2591 * image.c (gif_load): Fix omitted cast error introduced by
2592 2011-06-06 change.
2593
2594 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2595
2596 * window.h (resize_proportionally, orig_total_lines)
2597 (orig_top_line): Remove from window structure.
2598 (set_window_height, set_window_width, change_window_heights)
2599 (Fdelete_window): Remove prototypes.
2600 (resize_frame_windows): Remove duplicate declaration.
2601
2602 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2603
2604 * window.h (resize_frame_windows, resize_window_check)
2605 (delete_deletable_window, resize_root_window)
2606 (resize_frame_windows): Declare prototypes.
2607
2608 * window.c (resize_window_apply): Make definition be "static" to
2609 match the prototype.
2610
2611 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2612
2613 * window.c: Remove declarations of Qwindow_size_fixed,
2614 window_min_size_1, window_min_size_2, window_min_size,
2615 size_window, window_fixed_size_p, enlarge_window, delete_window.
2616 Remove static from declaration of Qdelete_window, it's
2617 temporarily needed by Fbury_buffer.
2618 (replace_window): Don't assign orig_top_line and
2619 orig_total_lines.
2620 (Fdelete_window, delete_window): Remove. Window deletion is
2621 handled by window.el.
2622 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2623 Replace Fdelete_window calls with calls to Qdelete_window.
2624 (Fdelete_other_windows): Remove. Deleting other windows is
2625 handled by window.el.
2626 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2627 handled in window.el.
2628 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2629 Window minimum sizes are handled in window.el.
2630 (shrink_windows, size_window, set_window_height)
2631 (set_window_width, change_window_heights, window_height)
2632 (window_width, CURBEG, CURSIZE, enlarge_window)
2633 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2634 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2635 handled in window.el.
2636 (make_dummy_parent): Rename to make_parent_window and give it a
2637 second argument horflag.
2638 (make_window): Don't set resize_proportionally any more.
2639 (Fsplit_window): Remove. Windows are split in window.el.
2640 (save_restore_action, save_restore_orig_size)
2641 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2642 Resize mini windows in window.el.
2643 (grow_mini_window, shrink_mini_window): Implement by calling
2644 Qresize_root_window_vertically, resize_window_check and
2645 resize_window_apply.
2646 (saved_window, Fset_window_configuration, save_window_save):
2647 Do not handle orig_top_line, orig_total_lines, and
2648 resize_proportionally.
2649 (window_min_height, window_min_width): Move to window.el.
2650 (keys_of_window): Move bindings for delete-other-windows,
2651 split-window, delete-window and enlarge-window to window.el.
2652
2653 * buffer.c: Temporarily extern Qdelete_window.
2654 (Fbury_buffer): Temporarily call Qdelete_window instead of
2655 Fdelete_window (Fbury_buffer will move to window.el soon).
2656
2657 * frame.c (set_menu_bar_lines_1): Remove code handling
2658 orig_top_line and orig_total_lines.
2659
2660 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2661 set_window_height but set heights directly.
2662 (change_frame_size_1): Use resize_frame_windows.
2663
2664 * xdisp.c (init_xdisp): Don't use set_window_height but set
2665 heights directly.
2666
2667 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2668 Use resize_frame_windows instead of change_window_heights and run
2669 run_window_configuration_change_hook.
2670
2671 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2672 instead of change_window_heights and run
2673 run_window_configuration_change_hook.
2674
2675 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2676
2677 * window.c (replace_window): Rename second argument REPLACEMENT to
2678 NEW. New third argument SETFLAG. Rewrite.
2679 (delete_window, make_dummy_parent): Call replace_window with
2680 third argument 1.
2681 (window_list_1): Move down in code.
2682 (run_window_configuration_change_hook): Move set_buffer part
2683 before select_frame_norecord part in order to unwind correctly.
2684 Rename count1 to count.
2685 (recombine_windows, delete_deletable_window, resize_root_window)
2686 (Fdelete_other_windows_internal)
2687 (Frun_window_configuration_change_hook, make_parent_window)
2688 (resize_window_check, resize_window_apply, Fresize_window_apply)
2689 (resize_frame_windows, Fsplit_window_internal)
2690 (Fdelete_window_internal, Fresize_mini_window_internal):
2691 New functions.
2692 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2693
2694 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2695
2696 * window.h (window): Add some new members to window structure -
2697 normal_lines, normal_cols, new_total, new_normal, clone_number,
2698 splits, nest, prev_buffers, next_buffers.
2699 (WINDOW_TOTAL_SIZE): Move here from window.c.
2700 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2701
2702 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2703 Remove.
2704 (make_dummy_parent): Set new members of windows structure.
2705 (make_window): Move down in code. Handle new members of window
2706 structure.
2707 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2708 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2709 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2710 (Fset_window_prev_buffers, Fwindow_next_buffers)
2711 (Fset_window_next_buffers, Fset_window_clone_number):
2712 New functions.
2713 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2714 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2715 Doc-string fixes.
2716 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2717 Argument WINDOW can be now internal window too.
2718 (Fwindow_use_time): Move up in code.
2719 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2720 Rewrite doc-string.
2721 (Fset_window_configuration, saved_window)
2722 (Fcurrent_window_configuration, save_window_save): Handle new
2723 members of window structure.
2724 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2725 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2726 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2727 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2728 Qget_mru_window, Qresize_root_window,
2729 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2730 Qauto_buffer_name; staticpro them.
2731
2732 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2733
2734 * window.c (Fwindow_total_size, Fwindow_left_column)
2735 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2736 (Fwindow_list_1): New functions.
2737 (window_box_text_cols): Replace with window_body_cols.
2738 (Fwindow_width, Fscroll_left, Fscroll_right):
2739 Use window_body_cols instead of window_box_text_cols.
2740 (delete_window, Fset_window_configuration):
2741 Call delete_all_subwindows with window as argument.
2742 (delete_all_subwindows): Take a window as argument and not a
2743 structure. Rewrite.
2744 (window_loop): Remove handling of GET_LRU_WINDOW and
2745 GET_LARGEST_WINDOW.
2746 (Fget_lru_window, Fget_largest_window): Move to window.el.
2747
2748 * window.h: Extern window_body_cols instead of
2749 window_box_text_cols. delete_all_subwindows now takes a
2750 Lisp_Object as argument.
2751
2752 * indent.c (compute_motion, Fcompute_motion):
2753 Use window_body_cols instead of window_box_text_cols.
2754
2755 * frame.c (delete_frame): Call delete_all_subwindows with root
2756 window as argument.
2757
2758 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2759
2760 * fns.c (Fputhash): Document return value.
2761
2762 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2763
2764 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2765
2766 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 Cons<->int and similar integer overflow fixes (Bug#8794).
2769
2770 Check for overflow when converting integer to cons and back.
2771 * charset.c (Fdefine_charset_internal, Fdecode_char):
2772 Use cons_to_unsigned to catch overflow.
2773 (Fencode_char): Use INTEGER_TO_CONS.
2774 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2775 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2776 * data.c (long_to_cons, cons_to_long): Remove.
2777 (cons_to_unsigned, cons_to_signed): New functions.
2778 These signal an error for invalid or out-of-range values.
2779 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2780 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2781 * font.c (Ffont_variation_glyphs):
2782 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2783 * lisp.h: Include <intprops.h>.
2784 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2785 (cons_to_signed, cons_to_unsigned): New decls.
2786 (long_to_cons, cons_to_long): Remove decls.
2787 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2788 (Fprimitive_undo): Use CONS_TO_INTEGER.
2789 * xfns.c (Fx_window_property): Likewise.
2790 * xselect.c: Include <limits.h>.
2791 (x_own_selection, selection_data_to_lisp_data):
2792 Use INTEGER_TO_CONS.
2793 (x_handle_selection_request, x_handle_selection_clear)
2794 (x_get_foreign_selection, Fx_disown_selection_internal)
2795 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2796 (lisp_data_to_selection_data): Use cons_to_unsigned.
2797 (x_fill_property_data): Use cons_to_signed.
2798 Report values out of range.
2799
2800 Check for buffer and string overflow more precisely.
2801 * buffer.h (BUF_BYTES_MAX): New macro.
2802 * lisp.h (STRING_BYTES_MAX): New macro.
2803 * alloc.c (Fmake_string):
2804 * character.c (string_escape_byte8):
2805 * coding.c (coding_alloc_by_realloc):
2806 * doprnt.c (doprnt):
2807 * editfns.c (Fformat):
2808 * eval.c (verror):
2809 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2810 since they may not be the same number.
2811 * editfns.c (Finsert_char):
2812 * fileio.c (Finsert_file_contents):
2813 Likewise for BUF_BYTES_MAX.
2814
2815 * image.c: Use ptrdiff_t, not int, for sizes.
2816 (slurp_file): Switch from int to ptrdiff_t.
2817 All uses changed.
2818 (slurp_file): Check that file size fits in both size_t (for
2819 malloc) and ptrdiff_t (for sanity and safety).
2820
2821 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2822 if b->modtime has its maximal value.
2823
2824 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2825
2826 Don't assume time_t can fit into int.
2827 * buffer.h (struct buffer.modtime): Now time_t, not int.
2828 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2829 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2830
2831 Minor fixes for signed vs unsigned integers.
2832 * character.h (MAYBE_UNIFY_CHAR):
2833 * charset.c (maybe_unify_char):
2834 * keyboard.c (read_char, reorder_modifiers):
2835 XINT -> XFASTINT, since the integer must be nonnegative.
2836 * ftfont.c (ftfont_spec_pattern):
2837 * keymap.c (access_keymap, silly_event_symbol_error):
2838 XUINT -> XFASTINT, since the integer must be nonnegative.
2839 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2840 since it makes no difference and we prefer signed.
2841 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2842 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2843 nonnegative.
2844
2845 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2846
2847 * window.h (Fwindow_frame): Declare.
2848
2849 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2850
2851 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2852 (SPARE_MEMORY): Always define.
2853 (LARGE_REQUEST): Remove.
2854 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2855
2856 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2857
2858 * lisp.h: Move EXFUNS for Fframe_root_window,
2859 Fframe_first_window and Fset_frame_selected_window to window.h.
2860
2861 * window.h: Move EXFUNS for Fframe_root_window,
2862 Fframe_first_window and Fset_frame_selected_window here from
2863 lisp.h.
2864
2865 * frame.c (Fwindow_frame, Fframe_first_window)
2866 (Fframe_root_window, Fframe_selected_window)
2867 (Fset_frame_selected_window): Move to window.c.
2868 (Factive_minibuffer_window): Move to minibuf.c.
2869 (Fother_visible_frames_p): New function.
2870
2871 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2872
2873 * window.c (decode_window, decode_any_window): Move up in code.
2874 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2875 (inhibit_frame_unsplittable): Remove unused variable.
2876 (Fwindow_buffer): Move up and rewrite doc-string.
2877 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2878 (Fwindow_prev): New functions.
2879 (Fwindow_frame): Move here from frame.c. Accept any window as
2880 argument.
2881 (Fframe_root_window, Fframe_first_window)
2882 (Fframe_selected_window): Move here from frame.c. Accept frame
2883 or arbitrary window as argument. Update doc-strings.
2884 (Fminibuffer_window): Move up in code.
2885 (Fwindow_minibuffer_p): Move up in code and simplify.
2886 (Fset_frame_selected_window): Move here from frame.c.
2887 Marginal rewrite.
2888 (Fselected_window, select_window, Fselect_window): Move up in
2889 code. Minor doc-string fixes.
2890
2891 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2892
2893 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2894 Do not assume that spare memory exists; that assumption is valid
2895 only if SYSTEM_MALLOC.
2896 (LARGE_REQUEST): New macro, so that the issue of large requests
2897 is separated from the issue of spare memory.
2898
2899 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2900
2901 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2902 format. (Bug#8806)
2903
2904 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2905
2906 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2907 before statements.
2908
2909 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2910
2911 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2912
2913 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2914
2915 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2916 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2917
2918 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2919
2920 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2921
2922 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2923
2924 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2925 (x_clipboard_manager_save): Add return value.
2926 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2927 New error handlers.
2928 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2929 Obey Vx_select_enable_clipboard_manager. Catch errors in
2930 x_clipboard_manager_save (Bug#8779).
2931 (Vx_select_enable_clipboard_manager): New variable.
2932 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2933
2934 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2935
2936 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2937
2938 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2939
2940 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2941 in the current matrix if keep_current_p is non-zero.
2942
2943 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2944
2945 * bidi.c (bidi_level_of_next_char): Fix last change.
2946
2947 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2948
2949 Support bidi reordering of text covered by display properties.
2950
2951 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2952 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2953 (bidi_cache_search, bidi_cache_iterator_state)
2954 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2955 (bidi_level_of_next_char, bidi_move_to_visually_next):
2956 Support character positions inside a run of characters covered by a
2957 display string.
2958 (bidi_paragraph_init, bidi_resolve_explicit_1)
2959 (bidi_level_of_next_char): Call bidi_fetch_char and
2960 bidi_fetch_char_advance instead of FETCH_CHAR and
2961 FETCH_CHAR_ADVANCE.
2962 (bidi_init_it): Initialize new members.
2963 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2964 definitions.
2965 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2966 instead of using explicit *_CHAR codes.
2967 (bidi_resolve_explicit, bidi_resolve_weak):
2968 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2969 bidirectional text is supported only in multibyte buffers.
2970 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2971 it to initialize the frame_window_p member of struct bidi_it.
2972 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2973 (bidi_resolve_explicit, bidi_resolve_weak)
2974 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2975 bidi_it->nchars is non-positive.
2976 (bidi_level_of_next_char): Don't try to lookup the cache for the
2977 next/previous character if nothing is cached there yet, or if we
2978 were just reseat()'ed to a new position.
2979
2980 * xdisp.c (set_cursor_from_row): Set start and stop points
2981 according to the row's direction when priming the loop that looks
2982 for the glyph on which to display cursor.
2983 (single_display_spec_intangible_p): Function deleted.
2984 (display_prop_intangible_p): Reimplement to call
2985 handle_display_spec instead of single_display_spec_intangible_p.
2986 Accept 3 additional arguments needed by handle_display_spec.
2987 This fixes incorrect cursor motion across display property with complex
2988 values: lists, `(when COND...)' forms, etc.
2989 (single_display_spec_string_p): Support property values that are
2990 lists with the argument STRING its top-level element.
2991 (display_prop_string_p): Fix the condition for processing a
2992 property that is a list to be consistent with handle_display_spec.
2993 (handle_display_spec): New function, refactored from the
2994 last portion of handle_display_prop.
2995 (compute_display_string_pos): Accept additional argument
2996 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2997 value of a `display' property is a "replacing spec".
2998 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2999 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3000 the display property, but just return a value indicating whether
3001 the display property will replace the characters it covers.
3002 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3003 frame_window_p members of struct bidi_it.
3004 (compute_display_string_pos, compute_display_string_end):
3005 New functions.
3006 (push_it): Accept second argument POSITION, where pop_it should
3007 jump to continue iteration.
3008 (reseat_1): Initialize bidi_it.disp_pos.
3009
3010 * keyboard.c (adjust_point_for_property): Adjust the call to
3011 display_prop_intangible_p to its new signature.
3012
3013 * dispextern.h (struct bidi_it): New member frame_window_p.
3014 (bidi_init_it): Update prototypes.
3015 (display_prop_intangible_p): Update prototype.
3016 (compute_display_string_pos, compute_display_string_end):
3017 Declare prototypes.
3018 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3019 EMACS_INT.
3020
3021 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3022
3023 Malloc failure behavior now depends on size of allocation.
3024 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3025 * lisp.h: Change signatures accordingly.
3026 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3027 All callers changed. (Bug#8762)
3028
3029 * gnutls.c: Use Emacs's memory allocators.
3030 Without this change, the gnutls library would invoke malloc etc.
3031 directly, which causes problems on non-SYNC_INPUT hosts, and which
3032 runs afoul of improving memory_full behavior. (Bug#8761)
3033 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3034 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3035 xfree instead of the default malloc, realloc, free.
3036 (Fgnutls_boot): No need to check for memory allocation failure,
3037 since xmalloc does that for us.
3038
3039 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3040 * category.c (hash_get_category_set):
3041 * ccl.c (ccl_driver):
3042 * charset.c (Fdefine_charset_internal):
3043 * charset.h (struct charset.hash_index):
3044 * composite.c (get_composition_id, gstring_lookup_cache)
3045 (composition_gstring_put_cache):
3046 * composite.h (struct composition.hash_index):
3047 * dispextern.h (struct image.hash):
3048 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3049 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3050 (hashfn_equal, hashfn_user_defined, make_hash_table)
3051 (maybe_resize_hash_table, hash_lookup, hash_put)
3052 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3053 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3054 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3055 * image.c (make_image, search_image_cache, lookup_image)
3056 (xpm_put_color_table_h):
3057 * lisp.h (struct Lisp_Hash_Table):
3058 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3059 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3060 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3061 * alloc.c (allocate_vectorlike):
3062 Check for overflow in vector size calculations.
3063 * ccl.c (ccl_driver):
3064 Check for overflow when converting EMACS_INT to int.
3065 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3066 need to be updated by these changes.
3067 * fns.c (make_hash_table, maybe_resize_hash_table):
3068 Check for integer overflow with large hash tables.
3069 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3070 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3071 (SXHASH_REDUCE): New macro.
3072 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3073 Use it instead of discarding useful hash info with large hash values.
3074 (sxhash_float): New function.
3075 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3076 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3077 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3078 Rewrite to use FIXNUM_BITS, as this simplifies things.
3079 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3080 Adjust signatures to match updated version of code.
3081 (consing_since_gc): Now EMACS_INT, since a single hash table can
3082 use more than INT_MAX bytes.
3083
3084 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3085
3086 Make it possible to build with GCC-4.6+ -O2 -flto.
3087
3088 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3089
3090 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3091
3092 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3093 Call minibuffer-inactive-mode.
3094
3095 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3096
3097 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3098 Update dependencies.
3099
3100 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3101
3102 * data.c (init_data): Remove code for UTS, this system is not
3103 supported anymore.
3104
3105 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3106
3107 Don't force ./temacs to start in terminal mode.
3108
3109 * frame.c (make_initial_frame): Initialize faces in all cases, not
3110 only when CANNOT_DUMP is defined.
3111 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3112
3113 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3114
3115 * dispnew.c (add_window_display_history): Use const for the string
3116 pointer. Remove declaration, not needed.
3117
3118 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3119
3120 Use 'inline', not 'INLINE'.
3121 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3122 * alloc.c, fontset.c (INLINE): Remove.
3123 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3124 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3125 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3126 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3127 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3128
3129 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3130
3131 Make it possible to run ./temacs.
3132
3133 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3134 syms_of_callproc does the same thing. Remove test for
3135 "initialized", do it in the caller.
3136 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3137
3138 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3139
3140 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3141 (read_minibuf): Use get_minibuffer.
3142 (syms_of_minibuf): Use DEFSYM.
3143 (Qmetadata): New var.
3144 * data.c (Qbuffer): Don't make it static.
3145 (syms_of_data): Use DEFSYM.
3146
3147 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3150 (CCL_CODE_MIN): New macro.
3151
3152 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3153
3154 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3155
3156 * eval.c (Qdebug): Now static.
3157 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3158 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3159 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3160
3161 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3162
3163 * image.c: Various fixes to ImageMagick code comments.
3164 (Fimagemagick_types): Doc fix.
3165
3166 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3167
3168 Minor fixes prompted by GCC 4.6.0 warnings.
3169
3170 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3171
3172 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3173 (x_clipboard_manager_save_all): Move extern decl to ...
3174 * xterm.h: ... here, so that it can be checked for consistency.
3175
3176 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3177
3178 * xselect.c (x_clipboard_manager_save_frame)
3179 (x_clipboard_manager_save_all): New functions.
3180 (Fx_clipboard_manager_save): Lisp function deleted.
3181
3182 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3183 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3184
3185 * xterm.h: Update prototype.
3186
3187 2011-05-28 William Xu <william.xwl@gmail.com>
3188
3189 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3190 exiting (Bug#8239).
3191
3192 2011-05-28 Jim Meyering <meyering@redhat.com>
3193
3194 Avoid a sign-extension bug in crypto_hash_function.
3195 * fns.c (to_uchar): Define.
3196 (crypto_hash_function): Use it to convert some newly-signed
3197 variables to unsigned, to avoid sign-extension bugs. For example,
3198 without this change, (md5 "truc") would evaluate to
3199 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3200 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3201 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3202
3203 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 Integer overflow fixes.
3206
3207 * dbusbind.c: Serial number integer overflow fixes.
3208 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3209 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3210 to hold a serial number that is too large for a fixnum.
3211 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3212 Check for serial numbers out of range. Decode any serial number
3213 that was so large that it became a float. (Bug#8722)
3214
3215 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3216 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3217 Use XFASTINT rather than XUINT when numbers are nonnegative.
3218 (xd_append_arg, Fdbus_method_return_internal):
3219 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3220 arguments, check that Lisp number is nonnegative, rather than
3221 silently wrapping negative numbers around. (Bug#8722)
3222 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3223 (Bug#8722)
3224
3225 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3226
3227 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3228
3229 ccl: add integer overflow checks
3230 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3231 (IN_INT_RANGE): New macros.
3232 (ccl_driver): Use them to check for integer overflow when
3233 decoding a CCL program. Many of the new checks are whether XINT (x)
3234 fits in int; it doesn't always, on 64-bit hosts. The new version
3235 doesn't catch all possible integer overflows, but it's an
3236 improvement. (Bug#8719)
3237
3238 * alloc.c (make_event_array): Use XINT, not XUINT.
3239 There's no need for unsigned here.
3240
3241 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3242 This follows up to the 2011-05-06 change that substituted uintptr_t
3243 for EMACS_INT. This case wasn't caught back then.
3244
3245 Rework Fformat to avoid integer overflow issues.
3246 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3247 now (part of C89). Include <verify.h>.
3248 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3249 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3250 (Fformat): Avoid the prepass trying to compute sizes; it was only
3251 approximate and thus did not catch overflow reliably. Instead, walk
3252 through the format just once, formatting and computing sizes as we go,
3253 checking for integer overflow at every step, and allocating a larger
3254 buffer as needed. Keep track separately whether the format is
3255 multibyte. Keep only the most-recently calculated precision, rather
3256 than them all. Record whether each argument has been converted to
3257 string. Use EMACS_INT, not int, for byte and char and arg counts.
3258 Support field widths and precisions larger than INT_MAX. Avoid
3259 sprintf's undefined behavior with conversion specifications such as %#d
3260 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3261 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3262 formatting out-of-range floating point numbers with int
3263 formats. (Bug#8668)
3264
3265 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3266
3267 * data.c: Avoid integer truncation in expressions involving floats.
3268 * data.c: Include <intprops.h>.
3269 (arith_driver): When there's an integer overflow in an expression
3270 involving floating point, convert the integers to floating point
3271 so that the resulting value does not suffer from catastrophic
3272 integer truncation. For example, on a 64-bit host (* 4
3273 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3274 Do not rely on undefined behavior after integer overflow.
3275
3276 merge count_size_as_multibyte, parse_str_to_multibyte
3277 * character.c, character.h (count_size_as_multibyte):
3278 Rename from parse_str_to_multibyte; all uses changed.
3279 Check for integer overflow.
3280 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3281 since it's now a duplicate of the other. This is more of
3282 a character than a buffer op, so better that it's in character.c.
3283 * fns.c, print.c: Adjust to above changes.
3284
3285 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3286
3287 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3288
3289 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3290
3291 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3292 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3293 (x_clipboard_manager_save): Now static.
3294 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3295
3296 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3297 (crypto_hash_function): Now static.
3298 Fix pointer signedness problems. Avoid unnecessary initializations.
3299
3300 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3301
3302 * termhooks.h (Vselection_alist): Make it terminal-local.
3303
3304 * terminal.c (create_terminal): Initialize it.
3305
3306 * xselect.c: Support for clipboard managers.
3307 (Vselection_alist): Move to termhooks.h as terminal-local var.
3308 (LOCAL_SELECTION): New macro.
3309 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3310 (symbol_to_x_atom): Remove gratuitous arg.
3311 (x_handle_selection_request, lisp_data_to_selection_data)
3312 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3313 (x_own_selection, x_get_local_selection, x_convert_selection):
3314 New arg, specifying work frame. Use terminal-local Vselection_alist.
3315 (some_frame_on_display): Delete unused function.
3316 (Fx_own_selection_internal, Fx_get_selection_internal)
3317 (Fx_disown_selection_internal, Fx_selection_owner_p)
3318 (Fx_selection_exists_p): New optional frame arg.
3319 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3320 (x_handle_selection_clear): Don't treat other terminals with the
3321 same keyboard specially. Use the terminal-local Vselection_alist.
3322 (x_clear_frame_selections): Use Frun_hook_with_args.
3323
3324 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3325
3326 * xterm.h: Add support for those atoms.
3327
3328 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3329
3330 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3331 (converted_selections, conversion_fail_tag): New global variables.
3332 (x_selection_request_lisp_error): Free the above.
3333 (x_get_local_selection): Remove unnecessary code.
3334 (x_reply_selection_request): Args changed; handle arbitrary array
3335 of converted selections stored in converted_selections.
3336 Separate the XChangeProperty and SelectionNotify steps.
3337 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3338 (x_convert_selection): New function.
3339 (x_handle_selection_event): Simplify.
3340 (x_get_foreign_selection): Don't ignore incoming requests while
3341 waiting for an answer; this will fail when we implement
3342 SAVE_TARGETS, and seems unnecessary anyway.
3343 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3344 (Vx_sent_selection_functions): Doc fix.
3345
3346 2011-05-26 Leo Liu <sdl.web@gmail.com>
3347
3348 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3349
3350 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3351
3352 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3353
3354 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3355 for fringe update if it has periodic bitmap.
3356 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3357 and fringe_bitmap_periodic_p.
3358
3359 * fringe.c (get_fringe_bitmap_data): New function.
3360 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3361 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3362 row. Mark glyph row for fringe update if periodicity changed.
3363
3364 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3365 for fringe update unless it has periodic bitmap.
3366
3367 2011-05-25 Kenichi Handa <handa@m17n.org>
3368
3369 * xdisp.c (get_next_display_element): Set correct it->face_id for
3370 a static composition.
3371
3372 2011-05-24 Leo Liu <sdl.web@gmail.com>
3373
3374 * deps.mk (fns.o):
3375 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3376
3377 * fns.c (crypto_hash_function, Fsha1): New function.
3378 (Fmd5): Use crypto_hash_function.
3379 (syms_of_fns): Add Ssha1.
3380
3381 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3382
3383 * gnutls.c: Remove unused macros.
3384 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3385 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3386 Remove macros that are defined and never used.
3387 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3388
3389 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3390
3391 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3392 (Fx_get_selection_internal): Minor cleanup.
3393 (Fx_own_selection_internal): Rename arguments for consistency with
3394 select.el.
3395
3396 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3397
3398 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3399
3400 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3401
3402 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3403
3404 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3405
3406 * dispnew.c (scrolling_window): Don't exclude the case that the
3407 last enabled row in the desired matrix touches the bottom boundary.
3408
3409 2011-05-21 Glenn Morris <rgm@gnu.org>
3410
3411 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3412 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3413 and add some more files.
3414
3415 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3416
3417 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3418 report_file_error introduced by the change from 2011-05-07.
3419
3420 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3421
3422 * systime.h (Time): Define only if emacs is defined.
3423 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3424 where the include path doesn't have X11/X.h by default. See
3425 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3426
3427 2011-05-20 Kenichi Handa <handa@m17n.org>
3428
3429 * composite.c (find_automatic_composition): Fix previous change.
3430
3431 2011-05-20 Glenn Morris <rgm@gnu.org>
3432
3433 * lisp.mk: New file, split from Makefile.in.
3434 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3435 (shortlisp): Remove.
3436 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3437
3438 2011-05-19 Glenn Morris <rgm@gnu.org>
3439
3440 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3441 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3442 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3443 (lisp): Set the order to that of loadup.el.
3444 (shortlisp): Make it a copy of $lisp.
3445 (SOME_MACHINE_LISP): Remove.
3446 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3447 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3448
3449 2011-05-18 Kenichi Handa <handa@m17n.org>
3450
3451 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3452 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3453 (find_automatic_composition): Mostly rewrite for efficiency.
3454
3455 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3456
3457 * makefile.w32-in: Update dependencies.
3458
3459 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3460
3461 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3462 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3463
3464 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3465
3466 Fix some integer overflow issues, such as string length overflow.
3467
3468 * insdel.c (count_size_as_multibyte): Check for string overflow.
3469
3470 * character.c (lisp_string_width): Check for string overflow.
3471 Use EMACS_INT, not int, for string indexes and lengths; in
3472 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3473 the resulting string length overflows an EMACS_INT; instead,
3474 report a string overflow if no precision given. When checking for
3475 precision exhaustion, use a check that cannot possibly have
3476 integer overflow. (Bug#8675)
3477 * character.h (lisp_string_width): Adjust to new signature.
3478
3479 * alloc.c (string_overflow): New function.
3480 (Fmake_string): Use it. This doesn't change behavior, but saves
3481 a few bytes and will simplify future changes.
3482 * character.c (string_escape_byte8): Likewise.
3483 * lisp.h (string_overflow): New decl.
3484
3485 Fixups, following up to the user-interface timestamp change.
3486 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3487 for UI timestamps, instead of unsigned long.
3488 * msdos.c (mouse_get_pos): Likewise.
3489 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3490 * w32gui.h (Time): Define by including "systime.h" rather than by
3491 declaring it ourselves. (Bug#8664)
3492
3493 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3494 * image.c (clear_image_cache): Likewise.
3495
3496 * term.c (term_mouse_position): Don't assume time_t wraparound.
3497
3498 Be more systematic about user-interface timestamps.
3499 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3500 and sometimes 'EMACS_UINT', to represent these timestamps.
3501 This change causes it to use 'Time' uniformly, as that's what X uses.
3502 This makes the code easier to follow, and makes it easier to catch
3503 integer overflow bugs such as Bug#8664.
3504 * frame.c (Fmouse_position, Fmouse_pixel_position):
3505 Use Time, not unsigned long, for user-interface timestamps.
3506 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3507 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3508 * keyboard.h (last_event_timestamp): Likewise.
3509 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3510 * menu.h (xmenu_show): Likewise.
3511 * term.c (term_mouse_position): Likewise.
3512 * termhooks.h (struct input_event.timestamp): Likewise.
3513 (struct terminal.mouse_position_hook): Likewise.
3514 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3515 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3516 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3517 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3518 what it was before.
3519 * menu.h, termhooks.h: Include "systime.h", for Time.
3520
3521 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3522 Don't assume that the difference between two unsigned long values
3523 can fit into an integer. At this point, we know button_down_time
3524 <= event->timestamp, so the difference must be nonnegative, so
3525 there's no need to cast the result if double-click-time is
3526 nonnegative, as it should be; check that it's nonnegative, just in
3527 case. This bug is triggered when events are more than 2**31 ms
3528 apart (about 25 days). (Bug#8664)
3529
3530 * xselect.c (last_event_timestamp): Remove duplicate decl.
3531 (x_own_selection): Remove needless cast to unsigned long.
3532
3533 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3534 that always fit in int. Use a sentinel instead of a counter, to
3535 avoid a temp and to allay GCC's concerns about possible int overflow.
3536 * frame.h (struct frame): Use int for menu_bar_items_used
3537 instead of EMACS_INT, since it always fits in int.
3538
3539 * menu.c (grow_menu_items): Check for int overflow.
3540
3541 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3542
3543 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3544 Before, the code was not consistent. These values cannot exceed
3545 2**31 - 1 so there's no need to make them unsigned.
3546 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3547 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3548 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3549 as modifiers.
3550 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3551
3552 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3553 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3554 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3555 presumably because the widths might not match.
3556
3557 * window.c (size_window): Avoid needless test at loop start.
3558
3559 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3560
3561 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3562
3563 2011-05-12 Drew Adams <drew.adams@oracle.com>
3564
3565 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3566
3567 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3568
3569 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3570 `width' to `bar_area_x' and `bar_area_width', respectively.
3571 (x_scroll_run): Take account of fringe background extension.
3572
3573 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3574 Rename local vars `left' and `width' to `bar_area_x' and
3575 `bar_area_width', respectively.
3576 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3577 background extension.
3578
3579 2011-05-10 Jim Meyering <meyering@redhat.com>
3580
3581 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3582
3583 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3584
3585 * image.c (Finit_image_library): Return t for built-in image types,
3586 like pbm and xbm. (Bug#8640)
3587
3588 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3589
3590 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3591
3592 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3593
3594 * w32console.c (Fset_screen_color): Doc fix.
3595 (Fget_screen_color): New function.
3596 (syms_of_ntterm): Defsubr it.
3597
3598 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3599 unlink the temporary file if Fcall_process didn't create it in the
3600 first place.
3601 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3602 child process will be redirected to a file specified with `:file'.
3603 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3604 cue to call_process_cleanup not to close that handle.
3605
3606 2011-05-07 Ben Key <bkey76@gmail.com>
3607
3608 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3609 one of two shell specific rules, either bootstrap-temacs-CMD or
3610 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3611 to the previous implementation of the bootstrap-temacs rule.
3612 The bootstrap-temacs-CMD rule is similar to the previous
3613 implementation of the bootstrap-temacs rule except that it
3614 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3615 variable.
3616
3617 These changes, along with some changes to nt/configure.bat,
3618 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3619 earlier fix to add support for --cflags and --ldflags options
3620 that include quotes so that it works whether make uses cmd or
3621 sh as the shell.
3622
3623 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3624
3625 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3626 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3627 is a constant.
3628 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3629 a string. Handle both cases.
3630 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3631 (Fdbus_register_method): Use Qinvalid_function.
3632
3633 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3634
3635 * makefile.w32-in: Update dependencies.
3636 (LISP_H): Add inttypes.h and stdin.h.
3637 (PROCESS_H): Add unistd.h.
3638
3639 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3640
3641 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3642 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3643
3644 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3645
3646 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3647
3648 * term.c (vfatal): Remove stray call to va_end.
3649 It's not needed and the C Standard doesn't allow it here anyway.
3650
3651 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3652 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3653
3654 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3655 bytes.
3656
3657 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3658
3659 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3660
3661 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3662
3663 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3664
3665 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3666
3667 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3668 * charset.c (Fdefine_charset_internal): Don't initialize
3669 charset.code_space[15]. The value was garbage, on hosts with
3670 32-bit int (Bug#8600).
3671
3672 * lread.c (read_integer): Be more consistent with string-to-number.
3673 Use string_to_number to do the actual conversion; this avoids
3674 rounding errors and fixes some other screwups. Without this fix,
3675 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3676 (digit_to_number): Move earlier, for benefit of read_integer.
3677 Return -1 if the digit is out of range for the base, -2 if it is
3678 not a digit in any supported base. (Bug#8602)
3679
3680 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3681
3682 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3683 to match comment at start of function. This also removes a
3684 GCC warning about overflow in a 32+64-bit port.
3685
3686 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3687
3688 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3689 Reported by Stefan Monnier in
3690 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3691 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3692 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3693
3694 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3695 (EMACS_UINTPTR): Likewise, with uintptr_t.
3696
3697 * lisp.h: Prefer 64-bit EMACS_INT if available.
3698 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3699 on 32-bit hosts that have 64-bit int, so that they can access
3700 large files.
3701 However, temporarily disable this change unless the temporary
3702 symbol WIDE_EMACS_INT is defined.
3703
3704 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3705
3706 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3707 This removes an assumption that EMACS_INT and long are the same
3708 width as pointers. The assumption is true for Emacs porting targets
3709 now, but we want to make other targets possible.
3710 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3711 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3712 In the rest of the code, change types of integers that hold casted
3713 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3714 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3715 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3716 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3717 No need to cast type when ORing.
3718 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3719 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3720 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3721 assume EMACS_INT is the same width as char *.
3722 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3723 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3724 Remove no-longer-needed casts.
3725 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3726 (xg_tool_bar_help_callback, xg_make_tool_item):
3727 Use EMACS_INTPTR to hold an integer
3728 that will be cast to void *; this can avoid a GCC warning
3729 if EMACS_INT is not the same width as void *.
3730 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3731 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3732 (current_message_1, set_message_1):
3733 Use a local to convert to proper width without a cast.
3734 * xmenu.c (dialog_selection_callback): Likewise.
3735
3736 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3737 Also, don't assume VALBITS / RAND_BITS is less than 5,
3738 and don't rely on undefined behavior when shifting a 1 left into
3739 the sign bit.
3740 * lisp.h (get_random): Change signature to match.
3741
3742 * lread.c (hash_string): Use size_t, not int, for hash computation.
3743 Normally we prefer signed values; but hashing is special, because
3744 it's better to use unsigned division on hash table sizes so that
3745 the remainder is nonnegative. Also, size_t is the natural width
3746 for hashing into memory. The previous code used 'int', which doesn't
3747 retain enough info to hash well into very large tables.
3748 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3749
3750 * dbusbind.c: Don't possibly lose pointer info when converting.
3751 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3752 Use XPNTR rather than XHASH, so that the high-order bits of
3753 the pointer aren't lost when converting through void *.
3754
3755 * eval.c (Fautoload): Don't double-shift a pointer.
3756
3757 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3758
3759 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3760
3761 * gnutls.c (DEF_GNUTLS_FN):
3762 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3763
3764 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3765
3766 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3767 marker. (Bug#8610)
3768
3769 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3770
3771 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3772 New version that can reserve upto 2GB of heap space.
3773
3774 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3775
3776 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3777
3778 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3779
3780 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3781 `gnutls_certificate_set_x509_key_file'.
3782
3783 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3784
3785 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3786 Update dependencies.
3787
3788 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3789
3790 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3791 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3792 Remove unused parameter `fildes'.
3793 * process.c (read_process_output, send_process): Don't pass it.
3794
3795 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3796
3797 Fix previous change: the library cache is defined in w32.c.
3798 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3799 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3800
3801 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3802
3803 Implement dynamic loading of GnuTLS on Windows.
3804
3805 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3806 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3807 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3808 Declare.
3809
3810 * gnutls.c (Qgnutls_dll): Define.
3811 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3812 (gnutls_*): Declare function pointers.
3813 (init_gnutls_functions): New function to initialize function pointers.
3814 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3815 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3816 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3817 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3818 (emacs_gnutls_write, emacs_gnutls_read)
3819 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3820 (Fgnutls_available_p): New function.
3821 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3822 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3823 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3824
3825 * image.c: Include w32.h.
3826 (Vimage_type_cache): Delete.
3827 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3828 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3829 (w32_delayed_load): Move to w32.c.
3830
3831 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3832
3833 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3834 (w32_delayed_load): Move from image.c. When loading a library, record
3835 its filename in the :loaded-from property of the library id.
3836 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3837 Initialize and staticpro them.
3838 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3839
3840 * process.c: Include lisp.h before w32.h, not after.
3841 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3842 instead of gnutls_record_check_pending.
3843
3844 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3845
3846 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3847
3848 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3849 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3850 as passed in.
3851
3852 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3853
3854 * xterm.c (x_set_frame_alpha): Do not set property on anything
3855 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3856
3857 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3858
3859 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3860
3861 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3862
3863 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3864 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3865 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3866 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3867 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3868 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3869 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3870 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3871 (Qgnutls_bootprop_callbacks_verify): Make static.
3872
3873 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3874
3875 * callproc.c: Indentation fixup.
3876
3877 * sysdep.c (wait_for_termination_1): Make static.
3878 (wait_for_termination, interruptible_wait_for_termination):
3879 Move after wait_for_termination_1.
3880
3881 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3882
3883 * sysdep.c (interruptible_wait_for_termination): New function
3884 which is like wait_for_termination, but allows keyboard
3885 interruptions.
3886
3887 * callproc.c (Fcall_process): Add (:file "file") as an option for
3888 the STDOUT buffer.
3889 (Fcall_process_region): Ditto.
3890
3891 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3892
3893 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3894 rather than `XVECTOR (FOO)->size'.
3895
3896 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3897 inttypes.h, as a gnulib replacement is used if it not available in
3898 system headers.
3899
3900 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3901
3902 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3903 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3904 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3905
3906 * coding.c (coding_alloc_by_realloc): Error out if destination
3907 will grow beyond MOST_POSITIVE_FIXNUM.
3908 (decode_coding_emacs_mule): Abort if there isn't enough place in
3909 charbuf for the composition carryover bytes. Reserve an extra
3910 space for up to 2 characters produced in a loop.
3911 (decode_coding_iso_2022): Abort if there isn't enough place in
3912 charbuf for the composition carryover bytes.
3913
3914 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3915
3916 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3917 aborting when %lld or %lll format is passed.
3918 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3919 %llo or %llx format is passed. (Bug#8545)
3920
3921 * window.c (window_scroll_line_based): Use a marker instead of
3922 simple variables to record original value of point. (Bug#7952)
3923
3924 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3925 produced by %s or %c overflows available buffer space. (Bug#8545)
3926
3927 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3928
3929 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3930 (SIZE_MAX): Move defn after all includes, as they might #define it.
3931
3932 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3933
3934 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3935
3936 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3937
3938 * keyboard.c (Qdelayed_warnings_hook): Define.
3939 (command_loop_1): Run `delayed-warnings-hook'
3940 if Vdelayed_warnings_list is non-nil.
3941 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3942 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3943
3944 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3945
3946 * doprnt.c (doprnt): Don't return value smaller than the buffer
3947 size if the message was truncated. (Bug#8545).
3948
3949 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3950
3951 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3952 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3953
3954 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3955
3956 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3957
3958 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3959
3960 * makefile.w32-in: Update dependencies.
3961
3962 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3963
3964 Improve `doprnt' and its usage. (Bug#8545)
3965 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3966 `format_end'. Remove support for %l as a conversion specifier.
3967 Don't use xrealloc. Improve diagnostics when the %l size modifier
3968 is used. Update the commentary.
3969
3970 * eval.c (verror): Simplify calculation of size_t.
3971
3972 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3973 messages.
3974
3975 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3976
3977 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3978 change.
3979
3980 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3981
3982 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3983 This makes this file independent of the recent pseudovector change.
3984
3985 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3986
3987 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3988
3989 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3990 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3991 Remove unused local.
3992 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3993
3994 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3995 GCC 4.6.0 optimizes based on type-based alias analysis.
3996 For example, if b is of type struct buffer * and v of type struct
3997 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3998 != &v->size, and therefore "v->size = 1; b->size = 2; return
3999 v->size;" must therefore return 1. This assumption is incorrect
4000 for Emacs, since it type-puns struct Lisp_Vector * with many other
4001 types. To fix this problem, this patch adds a new type struct
4002 vectorlike_header that documents the constraints on layout of vectors
4003 and pseudovectors, and helps optimizing compilers not get fooled
4004 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4005 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4006 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4007 the size member.
4008 (XSETPVECTYPE): Rewrite in terms of new macro.
4009 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4010 This is a bit clearer, and further avoids the possibility of
4011 undesirable aliasing.
4012 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4013 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4014 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4015 since Lisp_Subr is a special case (no "next" field).
4016 (ASIZE): Now uses header.size rather than size.
4017 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4018 to avoid the hassle of writing XVECTOR (foo)->header.size.
4019 (struct vectorlike_header): New type.
4020 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4021 object, to help avoid aliasing.
4022 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4023 (SUBRP): Likewise, since Lisp_Subr is a special case.
4024 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4025 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4026 (struct Lisp_Hash_Table): Combine first two members into a single
4027 struct vectorlike_header member. All uses of "size" and "next" members
4028 changed to be "header.size" and "header.next".
4029 * buffer.h (struct buffer): Likewise.
4030 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4031 * frame.h (struct frame): Likewise.
4032 * process.h (struct Lisp_Process): Likewise.
4033 * termhooks.h (struct terminal): Likewise.
4034 * window.c (struct save_window_data, struct saved_window): Likewise.
4035 * window.h (struct window): Likewise.
4036 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4037 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4038 * buffer.c (init_buffer_once): Likewise.
4039 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4040 special case.
4041 * process.c (Fformat_network_address): Use local var for size,
4042 for brevity.
4043
4044 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4045
4046 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4047 * data.c (atof): Remove decl; no longer used or needed.
4048 (digit_to_number): Move to lread.c.
4049 (Fstring_to_number): Use new string_to_number function, to be
4050 consistent with how the Lisp reader treats infinities and NaNs.
4051 Do not assume that floating-point numbers represent EMACS_INT
4052 without losing information; this is not true on most 64-bit hosts.
4053 Avoid double-rounding errors, by insisting on integers when
4054 parsing non-base-10 numbers, as the documentation specifies.
4055 * lisp.h (string_to_number): New decl, replacing ...
4056 (isfloat_string): Remove.
4057 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4058 (read1): Do not accept +. and -. as integers; this
4059 appears to have been a coding error. Similarly, do not accept
4060 strings like +-1e0 as floating point numbers. Do not report
4061 overflow for integer overflows unless the base is not 10 which
4062 means we have no simple and reliable way to continue.
4063 Break out the floating-point parsing into a new
4064 function string_to_number, so that Fstring_to_number parses
4065 floating point numbers consistently with the Lisp reader.
4066 (digit_to_number): Move here from data.c. Make it static inline.
4067 (E_CHAR, EXP_INT): Remove, replacing with ...
4068 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4069 (string_to_number): New function, replacing isfloat_string.
4070 This function checks for valid syntax and produces the resulting
4071 Lisp float number too. Rework it so that string-to-number
4072 no longer mishandles examples like "1.0e+". Use strtoumax,
4073 so that overflow for non-base-10 numbers is reported only when
4074 there's no portable and simple way to convert to floating point.
4075
4076 * textprop.c (set_text_properties_1): Rewrite for clarity,
4077 and to avoid GCC warning about integer overflow.
4078
4079 * intervals.h (struct interval): Use EMACS_INT for members
4080 where EMACS_UINT might cause problems. See
4081 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4082 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4083 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4084 All uses changed.
4085 (offset_intervals): Tell GCC not to worry about length overflow
4086 when negating a negative length.
4087
4088 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4089 (overrun_check_free): Likewise.
4090
4091 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4092 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4093 word size.
4094
4095 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4096 (gnutls_make_error): Rename local to avoid shadowing.
4097 (gnutls_emacs_global_deinit): ifdef out; not used.
4098 (Fgnutls_boot): Use const for pointer to readonly storage.
4099 Comment out unused local. Fix pointer signedness problems.
4100
4101 * lread.c (openp): Don't stuff size_t into an 'int'.
4102 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4103 about possible signed overflow.
4104
4105 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4106 (GDK_KEY_g): Don't define if already defined.
4107 (xg_prepare_tooltip): Avoid pointer signedness problem.
4108 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4109
4110 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4111 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4112
4113 * xfns.c (Fx_window_property): Simplify a bit,
4114 to make a bit faster and to avoid GCC 4.6.0 warning.
4115 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4116
4117 * fns.c (internal_equal): Don't assume size_t fits in int.
4118
4119 * alloc.c (compact_small_strings): Tighten assertion a little.
4120
4121 Replace pEd with more-general pI, and fix some printf arg casts.
4122 * lisp.h (pI): New macro, generalizing old pEd macro to other
4123 conversion specifiers. For example, use "...%"pI"d..." rather
4124 than "...%"pEd"...".
4125 (pEd): Remove. All uses replaced with similar uses of pI.
4126 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4127 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4128 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4129 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4130 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4131 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4132 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4133 64-bit hosts.
4134 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4135 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4136 * print.c (safe_debug_print, print_object): Likewise.
4137 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4138 to int.
4139 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4140 avoiding the 0 flag, which is not portable.
4141 * process.c (Fmake_network_process): Use pI to avoid cast.
4142 * region-cache.c (pp_cache): Likewise.
4143 * xdisp.c (decode_mode_spec): Likewise.
4144 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4145 behavior on 64-bit hosts with printf arg.
4146 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4147 (x_stop_queuing_selection_requests): Likewise.
4148 (x_get_window_property): Don't truncate byte count to an 'int'
4149 when tracing.
4150
4151 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4152 here, since it parses constructs like leading '-' and spaces,
4153 which are not wanted; and it overflows with large numbers.
4154 Instead, simply match F[0-9]+, which is what is wanted anyway.
4155
4156 * alloc.c: Remove unportable assumptions about struct layout.
4157 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4158 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4159 (allocate_vectorlike, make_pure_vector): Use the new macros,
4160 plus offsetof, to remove unportable assumptions about struct layout.
4161 These assumptions hold on all porting targets that I know of, but
4162 they are not guaranteed, they're easy to remove, and removing them
4163 makes further changes easier.
4164
4165 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4166 This doesn't fix a bug but makes the code clearer.
4167 (string_overrun_cookie): Now const. Use initializers that
4168 don't formally overflow signed char, to avoid warnings.
4169 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4170 can cause Emacs to crash when string overrun checking is enabled.
4171 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4172 multiple of sizeof (EMACS_INT); it need not be, if
4173 alignof(EMACS_INT) < sizeof (EMACS_INT).
4174 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4175
4176 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4177
4178 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4179
4180 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4181
4182 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4183 supposed to be handshaking. (Bug#8556)
4184 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4185
4186 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4187
4188 * lisp.h (Qdebug): List symbol.
4189 * eval.c (Qdebug): Restore global linkage.
4190 * keyboard.c (debug-on-event): New variable.
4191 (handle_user_signal): Break into debugger when debug-on-event
4192 matches the current signal symbol.
4193
4194 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4195
4196 * alloc.c (check_sblock, check_string_bytes)
4197 (check_string_free_list): Convert to standard C.
4198
4199 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4200
4201 * w32.c (emacs_gnutls_push): Fix typo.
4202
4203 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4204
4205 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4206 "cast to pointer from integer of different size".
4207
4208 Improve doprnt and its use in verror. (Bug#8545)
4209 * doprnt.c (doprnt): Document the set of format control sequences
4210 supported by the function. Use SAFE_ALLOCA instead of always
4211 using `alloca'.
4212
4213 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4214 is one byte too soon. Don't use xrealloc; instead xfree and
4215 xmalloc anew.
4216
4217 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4218
4219 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4220 callbacks stage.
4221
4222 * gnutls.c: Renamed global_initialized to
4223 gnutls_global_initialized. Added internals for the
4224 :verify-hostname-error, :verify-error, and :verify-flags
4225 parameters of `gnutls-boot' and documented those parameters in the
4226 docstring. Start callback support.
4227 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4228 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4229 on error. Return error code.
4230 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4231 (emacs_gnutls_read): Likewise.
4232 (Fgnutls_boot): Return handshake error code.
4233 (emacs_gnutls_handle_error): New function.
4234 (wsaerror_to_errno): Likewise.
4235
4236 * w32.h (emacs_gnutls_pull): Add prototype.
4237 (emacs_gnutls_push): Likewise.
4238
4239 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4240 (emacs_gnutls_push): Likewise.
4241
4242 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4243
4244 * process.c (wait_reading_process_output): Check if GnuTLS
4245 buffered some data internally if no FDs are set for TLS
4246 connections.
4247
4248 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4249 (LIBS): Link to USER_LIBS.
4250 ($(BLD)/gnutls.$(0)): New target.
4251
4252 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4253
4254 * xdisp.c (handle_single_display_spec): Rename the
4255 display_replaced_before_p argument into display_replaced_p, to
4256 make it consistent with the commentary. Fix typos in the
4257 commentary.
4258
4259 * textprop.c (syms_of_textprop): Remove dead code.
4260 (copy_text_properties): Delete obsolete commentary about an
4261 interface that was deleted long ago. Fix typos in the description
4262 of arguments.
4263
4264 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4265 to changes in oldXMenu/XMenu.h from 2011-04-16.
4266 <menu_help_message, prev_menu_help_message>: Constify.
4267 (IT_menu_make_room): menu->help_text is now `const char **';
4268 adjust.
4269
4270 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4271 to changes in oldXMenu/XMenu.h from 2011-04-16.
4272 (struct XMenu): Declare `help_text' `const char **'.
4273
4274 * xfaces.c <Qunspecified>: Make extern again.
4275
4276 * syntax.c: Include sys/types.h before including regex.h, as
4277 required by Posix.
4278
4279 * doc.c (get_doc_string): Improve the format passed to `error'.
4280
4281 * doprnt.c (doprnt): Improve commentary.
4282
4283 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4284
4285 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4286 them with etags.
4287
4288 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4289 changes in globals.h immediately force recompilation.
4290 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4291 $(CURDIR)/s/ms-w32.h.
4292 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4293
4294 * character.c (Fchar_direction): Function deleted.
4295 (syms_of_character): Don't defsubr it.
4296 <char-direction-table>: Deleted.
4297
4298 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4299
4300 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4301 * doprnt.c: Include limits.h.
4302 (SIZE_MAX): New macro.
4303 (doprnt): Return a size_t value. 2nd arg is now size_t.
4304 Many local variables are now size_t instead of int or unsigned.
4305 Improve overflow protection. Support `l' modifier for integer
4306 conversions. Support %l conversion. Don't assume an EMACS_INT
4307 argument for integer conversions and for %c.
4308
4309 * lisp.h (doprnt): Restore prototype.
4310
4311 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4312 $(SRC)/character.h.
4313
4314 * Makefile.in (base_obj): Add back doprnt.o.
4315
4316 * deps.mk (doprnt.o): Add back prerequisites.
4317 (callint.o): Depend on character.h.
4318
4319 * eval.c (internal_lisp_condition_case): Include the handler
4320 representation in the error message.
4321 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4322 when breaking from the loop.
4323
4324 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4325
4326 * callint.c (Fcall_interactively): When displaying error message
4327 about invalid control letter, pass the character's codepoint, not
4328 a pointer to its multibyte form. Improve display of the character
4329 in octal and display also its hex code.
4330
4331 * character.c (char_string): Use %x to display the (unsigned)
4332 codepoint of an invalid character, to avoid displaying a bogus
4333 negative value.
4334
4335 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4336 `error', not SYMBOL_NAME itself.
4337
4338 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4339 character arguments to `error'.
4340
4341 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4342 to `error' in error message about FINAL_CHAR argument. Make sure
4343 FINAL_CHAR is a character, and use %c when it is passed as
4344 argument to `error'.
4345
4346 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4347
4348 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4349
4350 * w32.c: Include <time.h>.
4351 (sys_localtime): New function.
4352
4353 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4354
4355 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4356
4357 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4358
4359 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4360
4361 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4362 zombies (Bug#8467).
4363
4364 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4365
4366 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4367 gl_state.e_property when gl_state.object is Qt.
4368
4369 * insdel.c (make_gap_larger): Remove limitation of buffer size
4370 to <= INT_MAX.
4371
4372 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4373
4374 * xdisp.c (lookup_glyphless_char_display)
4375 (produce_glyphless_glyph): Handle cons cell entry in
4376 glyphless-char-display.
4377 (Vglyphless_char_display): Document it.
4378
4379 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4380 glyphless-char-display.
4381
4382 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4383
4384 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4385
4386 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4387
4388 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4389 definition for no-X builds.
4390
4391 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4392
4393 Static checks with GCC 4.6.0 and non-default toolkits.
4394
4395 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4396
4397 * process.c (keyboard_bit_set): Define only if SIGIO.
4398 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4399 (send_process): Repair possible setjmp clobbering.
4400
4401 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4402
4403 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4404
4405 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4406
4407 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4408 Define only if needed.
4409
4410 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4411 by pacifying GCC about it. Maybe it's time to retire it?
4412 * xfaces.c (USG, __TIMEVAL__): Likewise.
4413
4414 * dispextern.h (struct redisplay_interface): Rename param
4415 to avoid shadowing.
4416 * termhooks.h (struct terminal): Likewise.
4417 * xterm.c (xembed_send_message): Likewise.
4418
4419 * insdel.c (make_gap_smaller): Define only if
4420 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4421
4422 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4423 it.
4424
4425 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4426 so that we aren't warned about unused symbols.
4427
4428 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4429
4430 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4431
4432 * xfns.c (x_real_positions): Mark locals as initialized.
4433
4434 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4435
4436 * xterm.c: Fix problems found by static analysis with other toolkits.
4437 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4438 (x_dispatch_event): Declare static if USE_GTK, and
4439 define if USE_GTK || USE_X_TOOLKIT.
4440 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4441 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4442 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4443 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4444
4445 * xmenu.c (menu_help_callback): Pointer type fixes.
4446 Use const pointers when pointing at readonly data. Avoid pointer
4447 signedness clashes.
4448 (FALSE): Remove unused macro.
4449 (update_frame_menubar): Remove unused decl.
4450
4451 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4452
4453 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4454 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4455 (single_menu_item): Rename local to avoid shadowing.
4456
4457 * keyboard.c (make_lispy_event): Remove unused local var.
4458
4459 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4460 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4461
4462 * bitmaps: Change bitmaps from unsigned char back to the X11
4463 compatible char. Avoid the old compiler warnings about
4464 out-of-range initializers by using, for example, '\xab' rather
4465 than 0xab.
4466
4467 * xgselect.c (xgselect_initialize): Check vs interface
4468 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4469
4470 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4471
4472 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4473 to read-only memory.
4474
4475 * fns.c (vector): Remove; this old hack is no longer needed.
4476
4477 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4478 Remove unused var.
4479 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4480
4481 * xrdb.c (x_load_resources): Omit unused local.
4482
4483 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4484 (x_window): Rename locals to avoid shadowing.
4485 (USG): Use the kludged USG macro, to pacify gcc.
4486
4487 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4488 (x_term_init): Remove local to avoid shadowing.
4489
4490 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4491
4492 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4493 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4494
4495 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4496
4497 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4498
4499 Fix regex.c, syntax.c and friends for buffers > 2GB.
4500 * syntax.h (struct gl_state_s): Declare character position members
4501 EMACS_INT.
4502
4503 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4504
4505 * textprop.c (verify_interval_modification, interval_of):
4506 Declare arguments EMACS_INT.
4507
4508 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4509 EMACS_INT.
4510
4511 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4512
4513 * indent.c (Fvertical_motion): Local variable it_start is now
4514 EMACS_INT.
4515
4516 * regex.c (re_match, re_match_2, re_match_2_internal)
4517 (bcmp_translate, regcomp, regexec, print_double_string)
4518 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4519 (re_compile_pattern, re_exec): Declare arguments and local
4520 variables `size_t' and `ssize_t' and return values `regoff_t', as
4521 appropriate.
4522 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4523 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4524 <compile_stack_type>: `size' and `avail' are now `size_t'.
4525
4526 * regex.h <regoff_t>: Use ssize_t, not int.
4527 (re_search, re_search_2, re_match, re_match_2): Arguments that
4528 specify buffer/string position and length are now ssize_t and
4529 size_t. Return type is regoff_t.
4530
4531 2011-04-16 Ben Key <bkey76@gmail.com>
4532
4533 * nsfont.m: Fixed bugs in ns_get_family and
4534 ns_descriptor_to_entity that were caused by using free to
4535 deallocate memory blocks that were allocated by xmalloc (via
4536 xstrdup). This caused Emacs to crash when compiled with
4537 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4538 --enable-checking=xmallocoverrun). xfree is now used to
4539 deallocate these memory blocks.
4540
4541 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4542
4543 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4544
4545 emacs_write: Accept and return EMACS_INT for sizes.
4546 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4547 et seq.
4548 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4549 Accept and return EMACS_INT.
4550 (emacs_gnutls_write): Return the number of bytes written on
4551 partial writes.
4552 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4553 (emacs_read, emacs_write): Remove check for negative size, as the
4554 Emacs source code has been audited now.
4555 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4556 (emacs_read, emacs_write): Use it.
4557 * process.c (send_process): Adjust to the new signatures of
4558 emacs_write and emacs_gnutls_write. Do not attempt to store
4559 a byte offset into an 'int'; it might overflow.
4560 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4561
4562 * sound.c: Don't assume sizes fit in 'int'.
4563 (struct sound_device.period_size, alsa_period_size):
4564 Return EMACS_INT, not int.
4565 (struct sound_device.write, vox_write, alsa_write):
4566 Accept EMACS_INT, not int.
4567 (wav_play, au_play): Use EMACS_INT to store sizes and to
4568 record read return values.
4569
4570 2011-04-15 Ben Key <bkey76@gmail.com>
4571
4572 * keyboard.c (Qundefined): Don't declare static since it is used
4573 in nsfns.m.
4574 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4575 static since they are used in nsfont.m.
4576
4577 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4578
4579 * process.c (Qprocessp): Don't declare static.
4580 * lisp.h (Qprocessp): Declare again.
4581
4582 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4583
4584 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4585
4586 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4587
4588 Improve C-level modularity by making more things 'static'.
4589
4590 Don't publish debugger-only interfaces to other modules.
4591 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4592 (verify_bytepos, count_markers): Move decls to the only modules
4593 that need them.
4594 * region-cache.h (pp_cache): Likewise.
4595 * window.h (check_all_windows): Likewise.
4596 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4597
4598 * sysdep.c (croak): Now static, if
4599 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4600 * syssignal.h (croak): Declare only if not static.
4601
4602 * alloc.c (refill_memory_reserve): Now static if
4603 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4604 * lisp.h (refill_memory_reserve): Declare only if not static.
4605
4606 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4607 Define only if USE_LUCID.
4608
4609 * xrdb.c (x_customization_string, x_rm_string): Now static.
4610
4611 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4612 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4613
4614 * xdisp.c (draw_row_with_mouse_face): Now static.
4615 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4616
4617 * window.h (check_all_windows): Mark externally visible.
4618
4619 * window.c (window_deletion_count): Now static.
4620
4621 * undo.c: Make symbols static if they're not exported.
4622 (last_undo_buffer, last_boundary_position, pending_boundary):
4623 Now static.
4624
4625 * textprop.c (interval_insert_behind_hooks): Now static.
4626 (interval_insert_in_front_hooks): Likewise.
4627
4628 * term.c: Make symbols static if they're not exported.
4629 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4630 (max_frame_lines, tty_set_terminal_modes):
4631 (tty_reset_terminal_modes, tty_turn_off_highlight):
4632 (get_tty_terminal): Now static.
4633 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4634 * termhooks.h (term_mouse_moveto): Do not declare if
4635 HAVE_WINDOW_SYSTEM.
4636 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4637 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4638
4639 * sysdep.c: Make symbols static if they're not exported.
4640 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4641 Now static.
4642 (sigprocmask_set, full_mask): Remove; unused.
4643 (wait_debugging): Mark as visible.
4644 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4645 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4646
4647 * syntax.c (syntax_temp): Define only if !__GNUC__.
4648
4649 * sound.c (current_sound_device, current_sound): Now static.
4650
4651 * search.c (searchbufs, searchbuf_head): Now static.
4652
4653 * scroll.c (scroll_cost): Remove; unused.
4654 * dispextern.h (scroll_cost): Remove decl.
4655
4656 * region-cache.h (pp_cache): Mark as externally visible.
4657
4658 * process.c: Make symbols static if they're not exported.
4659 (process_tick, update_tick, create_process, chan_process):
4660 (Vprocess_alist, proc_buffered_char, datagram_access):
4661 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4662 (deactivate_process): Mark defn as static, as well as decl.
4663 * lisp.h (create_process): Remove decl.
4664 * process.h (chan_process, Vprocess_alist): Remove decls.
4665
4666 * print.c: Make symbols static if they're not exported.
4667 (print_depth, new_backquote_output, being_printed, print_buffer):
4668 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4669 (print_interval, print_number_index, initial_stderr_stream):
4670 Now static.
4671 * lisp.h (Fprinc): Remove decl.
4672 (debug_output_compilation_hack): Mark as externally visible.
4673
4674 * sysdep.c (croak): Move decl from here to syssignal.h.
4675 * syssignal.h (croak): Put it here, so the API can be checked when
4676 'croak' is called from dissociate_if_controlling_tty.
4677
4678 * minibuf.c: Make symbols static if they're not exported.
4679 (minibuf_save_list, choose_minibuf_frame): Now static.
4680 * lisp.h (choose_minibuf_frame): Remove decl.
4681
4682 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4683
4684 * lread.c: Make symbols static if they're not exported.
4685 (read_objects, initial_obarray, oblookup_last_bucket_number):
4686 Now static.
4687 (make_symbol): Remove; unused.
4688 * lisp.h (initial_obarray, make_symbol): Remove decls.
4689
4690 * keyboard.c: Make symbols static if they're not exported.
4691 (single_kboard, recent_keys_index, total_keys, recent_keys):
4692 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4693 (this_single_command_key_start, echoing, last_auto_save):
4694 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4695 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4696 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4697 (Vlispy_mouse_stem, double_click_count):
4698 Now static.
4699 (force_auto_save_soon): Define only if SIGDANGER.
4700 (ignore_mouse_drag_p): Now static if
4701 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4702 (print_help): Remove; unused.
4703 (stop_character, last_timer_event): Mark as externally visible.
4704 * keyboard.h (ignore_mouse_drag_p): Declare only if
4705 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4706 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4707 * lisp.h (echoing): Remove decl.
4708 (force_auto_save_soon): Declare only if SIGDANGER.
4709 * xdisp.c (redisplay_window): Simplify code, to make it more
4710 obvious that ignore_mouse_drag_p is not accessed if !defined
4711 USE_GTK && !defined HAVE_NS.
4712
4713 * intervals.c: Make symbols static if they're not exported.
4714 (merge_properties_sticky, merge_interval_right, delete_interval):
4715 Now static.
4716 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4717
4718 * insdel.c: Make symbols static if they're not exported.
4719 However, leave prepare_to_modify_buffer alone. It's never
4720 called from outside this function, but that appears to be a bug.
4721 (combine_after_change_list, combine_after_change_buffer):
4722 (adjust_after_replace, signal_before_change): Now static.
4723 (adjust_after_replace_noundo): Remove; unused.
4724 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4725 (signal_before_change): Remove decls.
4726
4727 * indent.c (val_compute_motion, val_vmotion): Now static.
4728
4729 * image.c: Make symbols static if they're not exported.
4730 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4731 if USE_GTK.
4732 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4733 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4734
4735 * fringe.c (standard_bitmaps): Now static.
4736 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4737
4738 * frame.c: Make symbols static if they're not exported.
4739 (x_report_frame_params, make_terminal_frame): Now static.
4740 (get_frame_param): Now static, unless HAVE_NS.
4741 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4742 (x_get_resource_string): Remove; not used.
4743 * frame.h (make_terminal_frame, x_report_frame_params):
4744 (x_get_resource_string); Remove decls.
4745 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4746 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4747
4748 * font.c, fontset.c: Make symbols static if they're not exported.
4749 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4750 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4751 * font.c (font_close_object): Now static.
4752 * font.h (font_close_object): Remove.
4753 * fontset.c (FONTSET_OBJLIST): Remove.
4754 (free_realized_fontset) #if-0 the body, which does nothing.
4755 (face_suitable_for_char_p): #if-0, as it's never called.
4756 * fontset.h (face_suitable_for_char_p): Remove decl.
4757 * xfaces.c (face_at_string_position):
4758 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4759 since 0 is always ASCII.
4760
4761 * fns.c (weak_hash_tables): Now static.
4762
4763 * fileio.c: Make symbols static if they're not exported.
4764 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4765 (Vwrite_region_annotation_buffers): Now static.
4766
4767 * eval.c: Make symbols static if they're not exported.
4768 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4769 * lisp.h (backtrace_list): Remove decl.
4770
4771 * emacs.c: Make symbols static if they're not exported.
4772 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4773 (fatal_error_code, fatal_error_signal_hook, standard_args):
4774 Now static.
4775 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4776 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4777 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4778 * lisp.h (fatal_error_signal_hook): Remove decl.
4779 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4780
4781 * editfns.c: Move a (normally-unused) function to its only use.
4782 * editfns.c, lisp.h (get_operating_system_release): Remove.
4783 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4784 worth the hassle of breaking this out.
4785
4786 * xterm.c: Make symbols static if they're not exported.
4787 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4788 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4789 (x_destroy_window, x_delete_display):
4790 Now static.
4791 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4792 (x_mouse_leave): Remove; unused.
4793 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4794 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4795 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4796 Remove decls.
4797 (x_mouse_leave): Declare only if WINDOWSNT.
4798 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4799 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4800 USE_X_TOOLKIT.
4801
4802 * ftxfont.c: Make symbols static if they're not exported.
4803 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4804 HAVE_FREETYPE.
4805 * font.h (ftxfont_driver): Likewise.
4806
4807 * xfns.c: Make symbols static if they're not exported.
4808 (x_last_font_name, x_display_info_for_name):
4809 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4810 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4811 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4812 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4813 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4814 (last_show_tip_args): Now static.
4815 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4816 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4817 (x_screen_planes): Remove; unused.
4818 * dispextern.h (x_screen_planes): Remove decl.
4819
4820 * dispnew.c: Make symbols static if they're not exported.
4821 * dispextern.h (redraw_garbaged_frames, scrolling):
4822 (increment_row_positions): Remove.
4823 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4824 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4825 Now static.
4826 (redraw_garbaged_frames): Remove; unused.
4827
4828 * xfaces.c: Make symbols static if they're not exported.
4829 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4830 Remove decls.
4831 * xterm.h (defined_color): Remove decls.
4832 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4833 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4834 (menu_face_changed_default, defined_color, free_realized_face):
4835 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4836 (ascii_face_of_lisp_face): Remove; unused.
4837
4838 * xdisp.c: Make symbols static if they're not exported.
4839 * dispextern.h (scratch_glyph_row, window_box_edges):
4840 (glyph_to_pixel_coords, set_cursor_from_row):
4841 (get_next_display_element, set_iterator_to_next):
4842 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4843 (show_mouse_face): Remove decls
4844 * frame.h (message_buf_print): Likewise.
4845 * lisp.h (pop_message, set_message, check_point_in_composition):
4846 Likewise.
4847 * xterm.h (set_vertical_scroll_bar): Likewise.
4848 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4849 (message_buf_print, scratch_glyph_row, displayed_buffer):
4850 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4851 (get_next_display_element, show_mouse_face, window_box_edges):
4852 (frame_to_window_pixel_xy, check_point_in_composition):
4853 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4854 (glyph_to_pixel_coords): Remove; unused.
4855
4856 * dired.c (file_name_completion): Now static.
4857
4858 * dbusbind.c (xd_in_read_queued_messages): Now static.
4859
4860 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4861 * data.c (circular_list_error): Remove.
4862
4863 * commands.h (last_point_position, last_point_position_buffer):
4864 (last_point_position_window): Remove decls.
4865 * keyboard.c: Make these variables static.
4866
4867 * coding.h (coding, code_convert_region, encode_coding_gap):
4868 Remove decls.
4869 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4870 (iso_code_class, detect_coding, code_convert_region): Now static.
4871 (encode_coding_gap): Remove; unused.
4872
4873 * chartab.c (chartab_chars, chartab_bits): Now static.
4874
4875 * charset.h (charset_iso_8859_1): Remove decl.
4876 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4877 Now static.
4878
4879 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4880 * ccl.c (Vccl_program_table): Now static.
4881 (check_ccl_update): Remove; unused.
4882
4883 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4884 * category.h: ... from here.
4885 * category.c (check_category_table, set_category_set): Now static.
4886
4887 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4888 * lisp.h: Remove these decls.
4889
4890 * buffer.c (buffer_count): Remove unused var.
4891
4892 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4893 so that it's not optimized away.
4894 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4895 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4896 exported only to the debugger.
4897
4898 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4899 * atimer.h (run_all_atimers): Remove; not exported.
4900
4901 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4902 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4903 was inaccessible from Lisp.
4904 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4905 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4906
4907 alloc.c: Import and export fewer symbols, and remove unused items.
4908 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4909 is defined.
4910 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4911 it's not optimized away by whole-program optimization.
4912 (message_enable_multibyte, free_misc): Remove.
4913 (catchlist, handlerlist, mark_backtrace):
4914 Declare only if BYTE_MARK_STACK.
4915 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4916 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4917 (message_enable_multibyte): Remove decl.
4918 (free_misc, interval_free_list, float_block, float_block_index):
4919 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4920 (cons_free_list, last_marked_index):
4921 Now static.
4922 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4923 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4924 (mark_backtrace): Define only if BYTE_MARK_STACK.
4925 * xdisp.c (message_enable_multibyte): Now static.
4926
4927 Declare Lisp_Object Q* variables to be 'static' if not exported.
4928 This makes it easier for human readers (and static analyzers)
4929 to see whether these variables are used from other modules.
4930 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4931 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4932 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4933 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4934 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4935 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4936 * xmenu.c, xselect.c:
4937 Declare Q* vars static if they are not used in other modules.
4938 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4939 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4940 Remove decls of unexported vars.
4941 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4942
4943 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4944
4945 Make Emacs functions such as Fatom 'static' by default.
4946 This makes it easier for human readers (and static analyzers)
4947 to see whether these functions can be called from other modules.
4948 DEFUN now defines a static function. To make the function external
4949 so that it can be used in other C modules, use the new macro DEFUE.
4950 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4951 (Finit_image_library):
4952 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4953 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4954 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4955 Remove decls, since these functions are now static.
4956 (Funintern, Fget_internal_run_time): New decls, since these functions
4957 were already external.
4958
4959 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4960 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4961 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4962 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4963 * keyboard.c, keymap.c, lread.c:
4964 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4965 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4966 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4967 Mark functions with DEFUE instead of DEFUN,
4968 if they are used in other modules.
4969 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4970 decls for now-static functions.
4971 * buffer.h (Fdelete_overlay): Remove decl.
4972 * callproc.c (Fgetenv_internal): Mark as internal.
4973 * composite.c (Fremove_list_of_text_properties): Remove decl.
4974 (Fcomposition_get_gstring): New forward static decl.
4975 * composite.h (Fcomposite_get_gstring): Remove decl.
4976 * dired.c (Ffile_attributes): New forward static decl.
4977 * doc.c (Fdocumntation_property): New forward static decl.
4978 * eval.c (Ffetch_bytecode): New forward static decl.
4979 (Funintern): Remove extern decl; now in .h file where it belongs.
4980 * fileio.c (Fmake_symbolic_link): New forward static decl.
4981 * image.c (Finit_image_library): New forward static decl.
4982 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4983 * intervals.h (Fprevious_property_change):
4984 (Fremove_list_of_text_properties): Remove decls.
4985 * keyboard.c (Fthis_command_keys): Remove decl.
4986 (Fcommand_execute): New forward static decl.
4987 * keymap.c (Flookup_key): New forward static decl.
4988 (Fcopy_keymap): Now static.
4989 * keymap.h (Flookup_key): Remove decl.
4990 * process.c (Fget_process): New forward static decl.
4991 (Fprocess_datagram_address): Mark as internal.
4992 * syntax.c (Fsyntax_table_p): New forward static decl.
4993 (skip_chars): Remove duplicate decl.
4994 * textprop.c (Fprevious_property_change): New forward static decl.
4995 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4996 Now internal.
4997 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4998 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4999
5000 * editfns.c (Fformat): Remove unreachable code.
5001
5002 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5003
5004 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5005 change. (Bug#8496)
5006
5007 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5008
5009 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5010 when at ZV. (Bug#8487)
5011
5012 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5013
5014 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5015 (Bug#8437)
5016 * keyboard.c (parse_tool_bar_item): Likewise.
5017 * sound.c (sound_cleanup, alsa_close): Likewise.
5018 * termcap.c (tgetent): Likewise.
5019 * xfns.c (x_default_font_parameter): Likewise.
5020 * xsettings.c (read_and_apply_settings): Likewise.
5021
5022 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5023 (overrun_check_free): Protoize.
5024
5025 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5026
5027 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5028 since callers should never pass a negative size.
5029 Change the signature to match that of plain 'read' and 'write'; see
5030 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5031 * lisp.h: Update prototypes of emacs_write and emacs_read.
5032
5033 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5034
5035 * xdisp.c (redisplay_window): Don't try to determine the character
5036 position of the scroll margin if the window start point w->startp
5037 is outside the buffer's accessible region. (Bug#8468)
5038
5039 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5040
5041 Fix write-region and its subroutines for buffers > 2GB.
5042 * fileio.c (a_write, e_write): Modify declaration of arguments and
5043 local variables to support buffers larger than 2GB.
5044 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5045
5046 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5047 argument, local variables, and return value.
5048
5049 * lisp.h: Update prototypes of emacs_write and emacs_read.
5050
5051 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5052
5053 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5054
5055 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5056
5057 Fix more problems found by GCC 4.6.0's static checks.
5058
5059 * xdisp.c (vmessage): Use a better test for character truncation.
5060
5061 * charset.c (load_charset_map): <, not <=, for optimization,
5062 and to avoid potential problems with integer overflow.
5063 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5064 * casetab.c (set_identity, shuffle): Likewise.
5065 * editfns.c (Fformat): Likewise.
5066 * syntax.c (skip_chars): Likewise.
5067
5068 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5069 This also lets GCC 4.6.0 generate slightly better loop code.
5070
5071 * callint.c (Fcall_interactively): <, not <=, for optimization.
5072 (Fcall_interactively): Count the number of arguments produced,
5073 not the number of arguments given. This is simpler and lets GCC
5074 4.6.0 generate slightly better code.
5075
5076 * ftfont.c: Distingish more carefully between FcChar8 and char.
5077 The previous code passed unsigned char * to a functions like
5078 strlen and xstrcasecmp that expect char *, which does not
5079 conform to the C standard.
5080 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5081 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5082 char * when the C standard requires it.
5083
5084 * keyboard.c (read_char): Remove unused var.
5085
5086 * eval.c: Port to Windows vsnprintf (Bug#8435).
5087 Include <limits.h>.
5088 (SIZE_MAX): Define if the headers do not.
5089 (verror): Do not give up if vsnprintf returns a negative count.
5090 Instead, grow the buffer. This ports to Windows vsnprintf, which
5091 does not conform to C99. Problem reported by Eli Zaretskii.
5092 Also, simplify the allocation scheme, by avoiding the need for
5093 calling realloc, and removing the ALLOCATED variable.
5094
5095 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5096
5097 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5098 But keep the doprint source code for now, as we might revamp it
5099 and use it again (Bug#8435).
5100 * lisp.h (doprnt): Remove.
5101 * Makefile.in (base_obj): Remove doprnt.o.
5102 * deps.mk (doprnt.o): Remove.
5103
5104 error: Print 32- and 64-bit integers portably (Bug#8435).
5105 Without this change, on typical 64-bit hosts error ("...%d...", N)
5106 was used to print both 32- and 64-bit integers N, which relied on
5107 undefined behavior.
5108 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5109 New macro.
5110 * lisp.h (error, verror): Mark as printf-like functions.
5111 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5112 Report overflow in size calculations when allocating printf buffer.
5113 Do not truncate output string at its first null byte.
5114 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5115 Truncate the output at a character boundary, since vsnprintf does not
5116 do that.
5117 * charset.c (check_iso_charset_parameter): Convert internal
5118 character to string before calling 'error', since %c now has the
5119 printf meaning.
5120 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5121 overflow when computing char to be passed to 'error'. Do not
5122 pass Lisp_Object to 'error'; pass the integer instead.
5123 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5124 formatted with plain %d.
5125
5126 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5127
5128 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5129
5130 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5131
5132 * xterm.c (x_catch_errors): Remove duplicate declaration.
5133
5134 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5135
5136 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5137
5138 2011-04-10 Jim Meyering <meyering@redhat.com>
5139
5140 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5141 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5142 return ssize_t not "int", and use size_t as the buffer length.
5143 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5144 * gnutls.h: Update declarations.
5145 * process.c (read_process_output): Use ssize_t, to match.
5146 (send_process): Likewise.
5147
5148 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5149
5150 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5151
5152 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5153
5154 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5155 Use unsigned char, to match FcChar8 type definition.
5156
5157 * xterm.c (handle_one_xevent):
5158 * xmenu.c (create_and_show_popup_menu):
5159 * xselect.c (x_decline_selection_request)
5160 (x_reply_selection_request): Avoid type-punned deref of X events.
5161
5162 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5163
5164 Fix some uses of `int' instead of EMACS_INT.
5165 * search.c (string_match_1, fast_string_match)
5166 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5167 (scan_buffer, find_next_newline_no_quit)
5168 (find_before_next_newline, search_command, Freplace_match)
5169 (Fmatch_data): Make some `int' variables be EMACS_INT.
5170
5171 * xdisp.c (display_count_lines): 3rd argument and return value now
5172 EMACS_INT. All callers changed.
5173 (pint2hrstr): Last argument is now EMACS_INT.
5174
5175 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5176 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5177 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5178 (decode_coding_utf_16, decode_coding_emacs_mule)
5179 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5180 (decode_coding_ccl, decode_coding_charset)
5181 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5182 (decode_coding_iso_2022, decode_coding_emacs_mule)
5183 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5184 <char_offset, last_offset>: Declare EMACS_INT.
5185 (encode_coding_utf_8, encode_coding_utf_16)
5186 (encode_coding_emacs_mule, encode_invocation_designation)
5187 (encode_designation_at_bol, encode_coding_iso_2022)
5188 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5189 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5190 Declare EMACS_INT.
5191 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5192 (encode_invocation_designation): Last argument P_NCHARS is now
5193 EMACS_INT.
5194 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5195 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5196
5197 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5198 All users changed.
5199
5200 * ccl.c (Fccl_execute_on_string): Declare some variables
5201 EMACS_INT.
5202
5203 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5204
5205 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5206
5207 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5208
5209 * process.c (Fformat_network_address): Doc fix.
5210
5211 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5212
5213 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5214
5215 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5216
5217 * keyboard.c (read_char): Call Lisp function help-form-show,
5218 instead of using internal_with_output_to_temp_buffer.
5219 (Qhelp_form_show): New var.
5220 (syms_of_keyboard): Use DEFSYM macro.
5221
5222 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5223
5224 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5225
5226 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5227
5228 * process.c (Flist_processes): Remove to Lisp.
5229 (list_processes_1): Delete.
5230
5231 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5232
5233 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5234
5235 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5236
5237 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5238
5239 Fix more problems found by GCC 4.6.0's static checks.
5240
5241 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5242
5243 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5244
5245 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5246
5247 * xdisp.c (vmessage): Mark as a printf-like function.
5248
5249 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5250
5251 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5252
5253 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5254 printf-like functions.
5255 (tiff_load): Add casts to remove these marks before passing them
5256 to system-supplied API.
5257
5258 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5259
5260 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5261 This avoids several warnings with gcc -Wstrict-overflow.
5262 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5263 directly, rather than having caller test rule sign. This avoids
5264 some unnecessary tests.
5265 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5266 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5267 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5268
5269 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5270 (xfont_open): Avoid unnecessary tests.
5271
5272 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5273
5274 * composite.h, composite.c (composition_gstring_put_cache):
5275 Use EMACS_INT, not int, for length.
5276
5277 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5278 breaking out part of COMPOSITION_DECODE_RULE.
5279 (COMPOSITION_DECODE_RULE): Use it.
5280 * composite.c (get_composition_id): Remove unused local vars,
5281 by using the new macro.
5282
5283 * textprop.c (set_text_properties_1): Change while to do-while,
5284 since the condition is always true at first.
5285
5286 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5287 (interval_deletion_adjustment): Return unsigned value.
5288 All uses changed.
5289
5290 * process.c (list_processes_1, create_pty, read_process_output):
5291 (exec_sentinel): Remove vars that were set but not used.
5292 (create_pty): Remove unnecessary "volatile"s.
5293 (Fnetwork_interface_info): Avoid possibility of int overflow.
5294 (read_process_output): Do adaptive read buffering even if carryover.
5295 (read_process_output): Simplify nbytes computation if buffered.
5296
5297 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5298
5299 * syntax.c (scan_words): Remove var that was set but not used.
5300 (update_syntax_table): Use unsigned instead of int.
5301
5302 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5303 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5304 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5305
5306 * print.c (print_error_message): Avoid int overflow.
5307
5308 * font.c (font_list_entities): Redo for clarity,
5309 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5310
5311 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5312 (font_score): Avoid potential overflow in diff calculation.
5313
5314 * fns.c (substring_both): Remove var that is set but not used.
5315 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5316
5317 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5318
5319 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5320 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5321 can always succeed if overflow has undefined behavior.
5322
5323 * search.c (boyer_moore, wordify): Remove vars set but not used.
5324 (wordify): Omit three unnecessary tests.
5325
5326 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5327 All callers changed. This avoids the need for an unused var.
5328
5329 * casefiddle.c (casify_region): Remove var that is set but not used.
5330
5331 * dired.c (file_name_completion): Remove var that is set but not used.
5332
5333 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5334
5335 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5336 (Finsert_file_contents): Remove unnecessary code checking fd.
5337
5338 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5339 Check for integer overflow on size calculations.
5340
5341 * buffer.c (Fprevious_overlay_change): Remove var that is set
5342 but not used.
5343
5344 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5345 Remove vars that are set but not used.
5346 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5347 (timer_check_2): Mark vars as initialized.
5348
5349 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5350
5351 * image.c (lookup_image): Remove var that is set but not used.
5352 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5353
5354 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5355 that are set but not used.
5356
5357 * xfns.c (make_invisible_cursor): Don't return garbage
5358 if XCreateBitmapFromData fails (Bug#8410).
5359
5360 * xselect.c (x_get_local_selection, x_handle_property_notify):
5361 Remove vars that are set but not used.
5362
5363 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5364 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5365
5366 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5367 Remove var that is set but not used.
5368 (scroll_bar_windows_size): Now size_t, not int.
5369 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5370 Check for overflow.
5371
5372 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5373 (map_tty_color) [!defined MSDOS]: Likewise.
5374
5375 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5376
5377 * coding.c: Remove vars that are set but not used.
5378 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5379 All callers changed.
5380 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5381 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5382 (decode_coding_charset): Remove vars that are set but not used.
5383
5384 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5385 that is set but not used.
5386
5387 * print.c (print_object): Remove var that is set but not used.
5388
5389 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5390 The gnulib version avoids calling malloc in the usual case,
5391 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5392 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5393 * filelock.c (current_lock_owner): Likewise.
5394 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5395 * sysdep.c: Include allocator.h, careadlinkat.h.
5396 (emacs_no_realloc_allocator): New static constant.
5397 (emacs_readlink): New function.
5398 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5399 ../lib/careadlinkat.h.
5400
5401 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5402
5403 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5404 first non-nil return value).
5405
5406 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5407
5408 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5409 if not defined (Bug#8403).
5410
5411 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5412
5413 * xdisp.c (display_count_lines): Remove parameter `start',
5414 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5415 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5416 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5417 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5418 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5419 and thereabouts. All callers changed.
5420 (get_per_char_metric): Remove parameter `f', unused since
5421 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5422
5423 2011-04-02 Jim Meyering <meyering@redhat.com>
5424
5425 do not dereference NULL upon failed strdup
5426 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5427 (ns_get_family): Likewise.
5428
5429 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5430
5431 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5432
5433 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5434
5435 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5436 later (Bug#8403).
5437
5438 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5439
5440 Add lexical binding.
5441
5442 * window.c (Ftemp_output_buffer_show): New fun.
5443 (Fsave_window_excursion):
5444 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5445
5446 * lread.c (lisp_file_lexically_bound_p): New function.
5447 (Fload): Bind Qlexical_binding.
5448 (readevalloop): Remove `evalfun' arg.
5449 Bind Qinternal_interpreter_environment.
5450 (Feval_buffer): Bind Qlexical_binding.
5451 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5452 Mark as dynamic.
5453 (syms_of_lread): Declare `lexical-binding'.
5454
5455 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5456
5457 * keyboard.c (eval_dyn): New fun.
5458 (menu_item_eval_property): Use it.
5459
5460 * image.c (parse_image_spec): Use Ffunctionp.
5461
5462 * fns.c (concat, mapcar1): Accept byte-code-functions.
5463
5464 * eval.c (Fsetq): Handle lexical vars.
5465 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5466 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5467 (FletX, Flet): Obey lexical binding.
5468 (Fcommandp): Handle closures.
5469 (Feval): New `lexical' arg.
5470 (eval_sub): New function extracted from Feval. Use it almost
5471 everywhere where Feval was used. Look up vars in lexical env.
5472 Handle closures.
5473 (Ffunctionp): Move from subr.el.
5474 (Ffuncall): Handle closures.
5475 (apply_lambda): Remove `eval_flags'.
5476 (funcall_lambda): Handle closures and new byte-code-functions.
5477 (Fspecial_variable_p): New function.
5478 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5479 but without exporting it to Lisp.
5480
5481 * doc.c (Fdocumentation, store_function_docstring):
5482 * data.c (Finteractive_form): Handle closures.
5483
5484 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5485 interactive spec.
5486
5487 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5488 New byte-codes.
5489 (exec_byte_code): New function extracted from Fbyte_code to handle new
5490 calling convention for byte-code-functions. Add new byte-codes.
5491
5492 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5493
5494 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5495
5496 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5497
5498 * xdisp.c (redisplay_internal): Fix prototype.
5499
5500 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5501
5502 * xdisp.c (SCROLL_LIMIT): New macro.
5503 (try_scrolling): Use it when setting scroll_limit.
5504 Limit scrolling to 100 screen lines.
5505 (redisplay_window): Even when falling back on "recentering",
5506 position point in the window according to scroll-conservatively,
5507 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5508
5509 (try_scrolling): When point is above the window, allow searching
5510 as far as scroll_max, or one screenful, to compute vertical
5511 distance from PT to the scroll margin position. This prevents
5512 try_scrolling from unnecessarily failing when
5513 scroll-conservatively is set to a value slightly larger than the
5514 window height. Clean up the case of PT below the margin at bottom
5515 of window: scroll_max can no longer be INT_MAX. When aggressive
5516 scrolling is in use, don't let point enter the opposite scroll
5517 margin as result of the scroll.
5518 (syms_of_xdisp) <scroll-conservatively>: Document the
5519 threshold of 100 lines for never-recentering scrolling.
5520
5521 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5522
5523 * dispextern.h (move_it_by_lines):
5524 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5525 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5526 (message_log_check_duplicate): Remove parameters `prev_bol' and
5527 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5528 (redisplay_internal): Remove parameter `preserve_echo_area',
5529 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5530
5531 * indent.c (Fvertical_motion):
5532 * window.c (window_scroll_pixel_based, Frecenter):
5533 Don't pass `need_y_p' to `move_it_by_lines'.
5534
5535 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5536
5537 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5538 steal a few bits to be more compact.
5539 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5540 Remove unneeded casts.
5541
5542 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5543
5544 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5545
5546 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5547 binding" message (bug#7967).
5548
5549 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5550
5551 Fix more problems found by GCC 4.6.0's static checks.
5552
5553 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5554 Remove unused local var.
5555
5556 * editfns.c (Fmessage_box): Remove unused local var.
5557
5558 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5559 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5560 Omit unused local vars.
5561 * window.c (shrink_windows): Omit unused local var.
5562 * menu.c (digest_single_submenu): Omit unused local var.
5563 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5564 Omit unused local var.
5565
5566 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5567 Don't assume string length fits in int.
5568 (keyremap_step, read_key_sequence): Use size_t for sizes.
5569 (read_key_sequence): Don't check last_real_key_start redundantly.
5570
5571 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5572 instead of alloca (Bug#8344).
5573
5574 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5575 (Fbacktrace_frame): Don't assume nframes fits in int.
5576
5577 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5578
5579 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5580 concerns.
5581
5582 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5583
5584 * cm.c (calccost): Turn while-do into do-while, for clarity.
5585
5586 * keyboard.c (syms_of_keyboard): Use the same style as later
5587 in this function when indexing through an array. This also
5588 works around GCC bug 48267.
5589
5590 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5591
5592 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5593
5594 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5595 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5596
5597 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5598 This avoids undefined behavior on integer overflow, and is a bit
5599 more convenient anyway since it is compared to a size_t variable.
5600
5601 Variadic C functions now count arguments with size_t, not int.
5602 This avoids an unnecessary limitation on 64-bit machines, which
5603 caused (substring ...) to crash on large vectors (Bug#8344).
5604 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5605 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5606 All variadic functions and their callers changed accordingly.
5607 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5608 * data.c (arith_driver, float_arith_driver): Likewise.
5609 * editfns.c (general_insert_function): Likewise.
5610 * eval.c (struct backtrace.nargs, interactive_p)
5611 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5612 (funcall_lambda, mark_backtrace): Likewise.
5613 * fns.c (concat): Likewise.
5614 * frame.c (x_set_frame_parameters): Likewise.
5615 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5616 0 if not found, not -1. All callers changed.
5617
5618 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5619 (stack_copy_size): Now size_t, not int.
5620 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5621
5622 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5623
5624 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5625 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5626 All callers changed.
5627
5628 * lisp.h (multibyte_char_to_unibyte):
5629 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5630 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5631 * character.h (CHAR_TO_BYTE8):
5632 * cmds.c (internal_self_insert):
5633 * editfns.c (general_insert_function):
5634 * keymap.c (push_key_description):
5635 * search.c (Freplace_match):
5636 * xdisp.c (message_dolog, set_message_1): All callers changed.
5637
5638 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5639
5640 * keyboard.c (safe_run_hook_funcall): New function.
5641 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5642 don't set the hook to nil, but remove the offending function instead.
5643 (Qcommand_hook_internal): Remove, unused.
5644 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5645 Vcommand_hook_internal.
5646
5647 * eval.c (enum run_hooks_condition): Remove.
5648 (funcall_nil, funcall_not): New functions.
5649 (run_hook_with_args): Call each function through a `funcall' argument.
5650 Remove `cond' argument, now redundant.
5651 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5652 (Frun_hook_with_args_until_failure): Adjust accordingly.
5653 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5654
5655 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5656
5657 * dispextern.h (string_buffer_position): Remove declaration.
5658
5659 * print.c (strout): Remove parameter `multibyte', unused since
5660 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5661
5662 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5663 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5664 All callers changed.
5665
5666 * w32.c (_wsa_errlist): Use braces for struct initializers.
5667
5668 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5669 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5670 All callers changed.
5671 (string_buffer_position): Likewise. Also, make static (it's never
5672 used outside xdisp.c).
5673 (cursor_row_p): Remove parameter `w', unused since
5674 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5675 (decode_mode_spec): Remove parameter `precision', introduced during
5676 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5677 All callers changed.
5678
5679 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5680
5681 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5682
5683 2011-03-27 Anders Lindgren <andlind@gmail.com>
5684
5685 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5686 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5687 (ns_update_auto_hide_menu_bar): New functions.
5688 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5689 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5690 ns_constrain_all_frames.
5691 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5692 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5693
5694 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5695
5696 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5697
5698 2011-03-27 Glenn Morris <rgm@gnu.org>
5699
5700 * syssignal.h: Replace RETSIGTYPE with void.
5701 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5702 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5703 Replace SIGTYPE with void everywhere.
5704 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5705 * s/template.h (SIGTYPE): Remove commented out definition.
5706
5707 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5708
5709 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5710 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5711
5712 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5713
5714 * w32.c (read_unc_volume): Use parameter `henum', instead of
5715 global variable `wget_enum_handle'.
5716
5717 * keymap.c (describe_vector): Remove parameters `indices' and
5718 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5719 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5720
5721 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5722
5723 * keyboard.c (timer_check): Remove parameter `do_it_now',
5724 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5725 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5726 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5727
5728 * keyboard.c (read_char):
5729 * w32menu.c (w32_menu_display_help):
5730 * xmenu.c (show_help_event, menu_help_callback):
5731 Adjust calls to `show_help_echo'.
5732
5733 * gtkutil.c (xg_maybe_add_timer):
5734 * keyboard.c (readable_events):
5735 * process.c (wait_reading_process_output):
5736 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5737
5738 * insdel.c (adjust_markers_gap_motion):
5739 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5740 (gap_left, gap_right): Don't call it.
5741
5742 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5743
5744 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5745 incurred during fontification.
5746
5747 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5748
5749 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5750 (DEFVAR_PER_BUFFER): Don't pass it.
5751
5752 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5753 (scrolling_window): Don't pass it.
5754
5755 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5756
5757 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5758
5759 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5760 and `suffix'.
5761 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5762 of variables specific to SELinux and computation of `encoded_absname'.
5763
5764 * image.c (XPutPixel): Remove unused variable `height'.
5765
5766 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5767
5768 * unexw32.c (get_section_info): Remove unused variable `section'.
5769
5770 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5771 (system_process_attributes): Remove unused variable `sess'.
5772 (sys_read): Remove unused variable `err'.
5773
5774 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5775 (w32_wnd_proc): Remove unused variable `isdead'.
5776 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5777 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5778 (x_create_tip_frame): Remove unused variable `tem'.
5779
5780 * w32inevt.c (w32_console_read_socket):
5781 Remove unused variable `no_events'.
5782
5783 * w32term.c (x_draw_composite_glyph_string_foreground):
5784 Remove unused variable `width'.
5785
5786 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5787
5788 * w32term.c (x_set_glyph_string_clipping):
5789 Don't pass uninitialized region to CombineRgn.
5790
5791 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5792
5793 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5794 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5795 (Fx_close_connection): Remove unused variable `i'.
5796
5797 * w32font.c (w32font_draw): Return number of glyphs.
5798 (w32font_open_internal): Remove unused variable `i'.
5799 (w32font_driver): Add missing initializer.
5800
5801 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5802 (fill_in_menu): Remove unused variable `items_added'.
5803
5804 * w32term.c (last_mouse_press_frame): Remove static global variable.
5805 (w32_clip_to_row): Remove unused variable `f'.
5806 (x_delete_terminal): Remove unused variable `i'.
5807
5808 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5809 (NOTHING): Remove unused static global variable.
5810 (uniscribe_check_otf): Remove unused variable `table'.
5811 (uniscribe_font_driver): Add missing initializers.
5812
5813 2011-03-23 Julien Danjou <julien@danjou.info>
5814
5815 * term.c (Fsuspend_tty, Fresume_tty):
5816 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5817 * window.c (temp_output_buffer_show):
5818 * insdel.c (signal_before_change):
5819 * frame.c (Fhandle_switch_frame):
5820 * fileio.c (Fdo_auto_save):
5821 * emacs.c (Fkill_emacs):
5822 * editfns.c (save_excursion_restore):
5823 * cmds.c (internal_self_insert):
5824 * callint.c (Fcall_interactively):
5825 * buffer.c (Fkill_all_local_variables):
5826 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5827 Use Frun_hooks.
5828 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5829 unconditionnaly since it does the check itself.
5830
5831 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5832
5833 Fix more problems found by GCC 4.5.2's static checks.
5834
5835 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5836 the first time through the loop, since we know p0 < p1 then.
5837 This also avoids a gcc -Wstrict-overflow warning.
5838
5839 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5840 leading to a memory leak, possible in functions like
5841 load_charset_map_from_file that can allocate an unbounded number
5842 of objects (Bug#8318).
5843
5844 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5845 that could (at least in theory) be that large.
5846
5847 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5848 This is less likely to overflow, and avoids undefined behavior if
5849 overflow does occur. All callers changed. Use strtoul to scan
5850 for the unsigned long integer.
5851 (pint2hrstr): Simplify and tune code slightly.
5852 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5853
5854 * scroll.c (do_scrolling): Work around GCC bug 48228.
5855 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5856
5857 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5858 This also avoids a warning with gcc -Wstrict-overflow.
5859 (validate_x_resource_name): Simplify count usage.
5860 This also avoids a warning with gcc -Wstrict-overflow.
5861
5862 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5863 fail (Bug#8306).
5864
5865 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5866
5867 * process.c (Fmake_network_process): Use socklen_t, not int,
5868 where POSIX says socklen_t is required in portable programs.
5869 This fixes a porting bug on hosts like 64-bit HP-UX, where
5870 socklen_t is wider than int (Bug#8277).
5871 (Fmake_network_process, server_accept_connection):
5872 (wait_reading_process_output, read_process_output):
5873 Likewise.
5874
5875 * process.c: Rename or move locals to avoid shadowing.
5876 (list_processes_1, Fmake_network_process):
5877 (read_process_output_error_handler, exec_sentinel_error_handler):
5878 Rename or move locals.
5879 (Fmake_network_process): Define label "retry_connect" only if needed.
5880 (Fnetwork_interface_info): Fix pointer signedness.
5881 (process_send_signal): Add cast to avoid pointer signedness problem.
5882 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5883 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5884
5885 Make tparam.h and terminfo.c consistent.
5886 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5887 Include tparam.h instead, since it declares them.
5888 * cm.h (PC): Remove extern decl; tparam.h now does this.
5889 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5890 * terminfo.c: Include tparam.h, to check interfaces.
5891 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5892 (tparam): Adjust signature to match interface in tparam.h;
5893 this removes some undefined behavior. Check that outstring and len
5894 are zero, which they always are with Emacs.
5895 * tparam.h (PC, BC, UP): New extern decls.
5896
5897 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5898 (xftfont_open): Rename locals to avoid shadowing.
5899
5900 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5901 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5902 (OTF_TAG_SYM): Omit macro if not needed.
5903 (ftfont_list): Remove unused local.
5904 (get_adstyle_property, ftfont_pattern_entity):
5905 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5906 Rename locals to avoid shadowing.
5907
5908 * xfont.c (xfont_list_family): Mark var as initialized.
5909
5910 * xml.c (make_dom): Now static.
5911
5912 * composite.c (composition_compute_stop_pos): Rename local to
5913 avoid shadowing.
5914 (composition_reseat_it): Remove unused locals.
5915 (find_automatic_composition, composition_adjust_point): Likewise.
5916 (composition_update_it): Mark var as initialized.
5917 (find_automatic_composition): Mark vars as initialized,
5918 with a FIXME (Bug#8290).
5919
5920 character.h: Rename locals to avoid shadowing.
5921 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5922 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5923 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5924 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5925 to avoid shadowing.
5926
5927 * textprop.c (property_change_between_p): Remove; unused.
5928
5929 * intervals.c (interval_start_pos): Now static.
5930
5931 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5932
5933 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5934 Rename locals to avoid shadowing.
5935
5936 * sound.c (wav_play, au_play, Fplay_sound_internal):
5937 Fix pointer signedness.
5938 (alsa_choose_format): Remove unused local var.
5939 (wav_play): Initialize a variable to 0, to prevent undefined
5940 behavior (Bug#8278).
5941
5942 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5943
5944 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5945
5946 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5947 clobbering (Bug#8298).
5948 * sysdep.c (sys_subshell): Likewise.
5949 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5950
5951 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5952 This should get cleaned up, so that child_setup has the
5953 same signature on all platforms.
5954
5955 * callproc.c (call_process_cleanup): Now static.
5956 (relocate_fd): Rename locals to avoid shadowing.
5957
5958 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5959
5960 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5961 not to be necessary, and produces flickering.
5962
5963 2011-03-20 Glenn Morris <rgm@gnu.org>
5964
5965 * config.in: Remove file.
5966
5967 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5968
5969 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5970 are now in src/globals.h.
5971 (syms_of_minibuf): Remove spurious & from previous change.
5972
5973 2011-03-20 Leo <sdl.web@gmail.com>
5974
5975 * minibuf.c (completing-read-function): New variable.
5976 (completing-read-default): Rename from completing-read.
5977 (completing-read): Call completing-read-function.
5978
5979 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5980
5981 * xfaces.c (Fx_load_color_file):
5982 Read color file from absolute filename (bug#8250).
5983
5984 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5985
5986 * makefile.w32-in: Update dependencies.
5987
5988 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5989
5990 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5991
5992 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5993
5994 Fix more problems found by GCC 4.5.2's static checks.
5995
5996 * process.c (make_serial_process_unwind, send_process_trap):
5997 (sigchld_handler): Now static.
5998
5999 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6000 That way, the code declares only the vars that it needs.
6001 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6002 * s/cygwin.h (PTY_ITERATION): Likewise.
6003 * s/darwin.h (PTY_ITERATION): Likewise.
6004 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6005
6006 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6007 * process.c (allocate_pty): Don't declare stb unless it's needed.
6008
6009 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6010 (CONSTANTLIM): Remove; unused.
6011 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6012 Define only if needed.
6013
6014 * unexelf.c (unexec): Name an expression,
6015 to avoid gcc -Wbad-function-cast warning.
6016 Use a different way to cause a compilation error if anyone uses
6017 n rather than nn, a way that does not involve shadowing.
6018 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6019
6020 * deps.mk (unexalpha.o): Remove; unused.
6021
6022 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6023 * unexec.h: New file.
6024 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6025 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6026 Depend on unexec.h.
6027 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6028 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6029 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6030 Change as necessary to match prototype in unexec.h.
6031
6032 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6033 shadowing.
6034 (back_comment, skip_chars): Mark vars as initialized.
6035
6036 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6037 Rename locals to avoid shadowing.
6038
6039 * lread.c (read1): Rewrite so as not to use empty "else".
6040 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6041
6042 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6043
6044 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6045 warning when compiling print.c.
6046
6047 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6048 instead of using an uninitialized var.
6049 (font_sort_entities): Mark var as initialized.
6050
6051 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6052
6053 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6054 pointers to constants.
6055 (font_parse_fcname): Remove unused vars.
6056 (font_delete_unmatched): Now static.
6057 (font_get_spec): Remove; unused.
6058 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6059 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6060 Rename or move locals to avoid shadowing.
6061
6062 * fns.c (require_nesting_list, require_unwind): Now static.
6063 (Ffillarray): Rename locals to avoid shadowing.
6064
6065 * floatfns.c (domain_error2): Define only if needed.
6066 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6067
6068 * alloc.c (mark_backtrace): Move decl from here ...
6069 * lisp.h: ... to here, so that it can be checked.
6070
6071 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6072 (Fdefvar): Rewrite so as not to use empty "else".
6073 (lisp_indirect_variable): Name an expression,
6074 to avoid gcc -Wbad-function-cast warning.
6075 (Fdefvar): Rename locals to avoid shadowing.
6076
6077 * callint.c (quotify_arg, quotify_args): Now static.
6078 (Fcall_interactively): Rename locals to avoid shadowing.
6079 Use const pointer when appropriate.
6080
6081 * lisp.h (get_system_name, get_operating_system_release):
6082 Move decls here, to check interfaces.
6083 * process.c (get_operating_system_release): Move decl to lisp.h.
6084 * xrdb.c (get_system_name): Likewise.
6085 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6086 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6087 some of which prompt warnings from gcc -Wbad-function-cast.
6088 (Fformat_time_string, Fencode_time, Finsert_char):
6089 (Ftranslate_region_internal, Fformat):
6090 Rename or remove local vars to avoid shadowing.
6091 (Ftranslate_region_internal): Mark var as initialized.
6092
6093 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6094 avoid shadowing.
6095
6096 * lisp.h (eassert): Check that the argument compiles, even if
6097 ENABLE_CHECKING is not defined.
6098
6099 * data.c (Findirect_variable): Name an expression, to avoid
6100 gcc -Wbad-function-cast warning.
6101 (default_value, arithcompare, arith_driver, arith_error): Now static.
6102 (store_symval_forwarding): Rename local to avoid shadowing.
6103 (Fmake_variable_buffer_local, Fmake_local_variable):
6104 Mark variables as initialized.
6105 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6106
6107 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6108 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6109 Rename locals to avoid shadowing.
6110 (mark_stack): Move local variables into the #ifdef region where
6111 they're used.
6112 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6113 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6114 needed otherwise.
6115 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6116 (GC_STRING_CHARS): Remove; not used.
6117 (Fmemory_limit): Cast sbrk's returned value to char *.
6118
6119 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6120 avoids undefined behavior in theory.
6121
6122 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6123
6124 Use functions, not macros, for up- and down-casing (Bug#8254).
6125 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6126 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6127 to use the following functions instead of these macros.
6128 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6129 EMACS_INT, since callers assume the returned value fits in int.
6130 (upcase1): Likewise, for UPCASE_TABLE.
6131 (uppercasep, lowercasep, upcase): New static inline functions.
6132 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6133 the race-condition problem in the old DOWNCASE.
6134
6135 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6136 Rename locals to avoid shadowing.
6137 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6138 (regex_compile, re_search_2, re_match_2_internal):
6139 Remove unused local vars.
6140 (FREE_VAR): Rewrite so as not to use empty "else",
6141 which gcc can warn about.
6142 (regex_compile, re_match_2_internal): Mark locals as initialized.
6143 (RETALLOC_IF): Define only if needed.
6144 (WORDCHAR_P): Likewise. This one is never needed, but is used
6145 only in a comment talking about a compiler bug, so put inside
6146 the #if 0 of that comment.
6147 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6148 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6149 Remove; unused.
6150
6151 * search.c (boyer_moore): Rename locals to avoid shadowing.
6152 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6153 (PREV_CHAR_BOUNDARY): Likewise.
6154
6155 * search.c (simple_search): Remove unused var.
6156
6157 * dired.c (compile_pattern): Move decl from here ...
6158 * lisp.h: ... to here, so that it can be checked.
6159 (struct re_registers): New forward decl.
6160
6161 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6162
6163 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6164 All uses changed.
6165 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6166 Rename locals to avoid shadowing.
6167 (Fvertical_motion): Mark locals as initialized.
6168
6169 * casefiddle.c (casify_object, casify_region): Now static.
6170 (casify_region): Mark local as initialized.
6171
6172 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6173
6174 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6175 New macros, so that the caller can use some names other than
6176 gcpro1, gcpro2, etc.
6177 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6178 of the new macros.
6179 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6180 argument, for consistency with GCPRO2_VAR, etc: it is now the
6181 prefix of the variable, not the variable itself. All uses
6182 changed.
6183 * dired.c (directory_files_internal, file_name_completion):
6184 Rename locals to avoid shadowing.
6185
6186 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6187 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6188 dired.c's scmp function, had undefined behavior.
6189 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6190 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6191 * buffer.h: ... to here, because these macros use current_buffer,
6192 and the new implementation with inline functions needs to have
6193 current_buffer in scope now, rather than later when the macros
6194 are used.
6195 (downcase, upcase1): New static inline functions.
6196 (DOWNCASE, UPCASE1): Reimplement using these functions.
6197 This avoids undefined behavior in expressions like
6198 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6199 from race conditions in accessing the global variables
6200 case_temp1 and case_temp2.
6201 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6202 * lisp.h (case_temp1, case_temp2): Remove their decls.
6203 * character.h (ASCII_CHAR_P): Move from here ...
6204 * lisp.h: ... to here, so that the inline functions mentioned
6205 above can use them.
6206
6207 * dired.c (directory_files_internal_unwind): Now static.
6208
6209 * fileio.c (file_name_as_directory, directory_file_name):
6210 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6211 Now static.
6212 (file_name_as_directory): Use const pointers when appropriate.
6213 (Fexpand_file_name): Likewise. In particular, newdir might
6214 point at constant storage, so make it a const pointer.
6215 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6216 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6217 signedness issues.
6218 (Fset_file_times, Finsert_file_contents, auto_save_error):
6219 Rename locals to avoid shadowing.
6220
6221 * minibuf.c (choose_minibuf_frame_1): Now static.
6222 (Ftry_completion, Fall_completions): Rename or remove locals
6223 to avoid shadowing.
6224
6225 * marker.c (bytepos_to_charpos): Remove; unused.
6226
6227 * lisp.h (verify_bytepos, count_markers): New decls,
6228 so that gcc does not warn that these functions aren't declared.
6229
6230 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6231 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6232 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6233 (copy_text): Remove unused local var.
6234
6235 * filelock.c (within_one_second): Now static.
6236 (lock_file_1): Rename local to avoid shadowing.
6237
6238 * buffer.c (fix_overlays_before): Mark locals as initialized.
6239 (fix_start_end_in_overlays): Likewise. This function should be
6240 simplified by using pointers-to-pointers, but that's a different
6241 matter.
6242 (switch_to_buffer_1): Now static.
6243 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6244 (report_overlay_modification): Rename locals to avoid shadowing.
6245
6246 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6247 Fix pointer signedness issue.
6248 (sys_subshell): Mark local as volatile if checking for lint,
6249 to suppress a gcc -Wclobbered warning that does not seem to be right.
6250 (MAXPATHLEN): Define only if needed.
6251
6252 * process.c (serial_open, serial_configure): Move decls from here ...
6253 * systty.h: ... to here, so that they can be checked.
6254
6255 * fns.c (get_random, seed_random): Move extern decls from here ...
6256 * lisp.h: ... to here, so that they can be checked.
6257
6258 * sysdep.c (reset_io): Now static.
6259 (wait_for_termination_signal): Remove; unused.
6260
6261 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6262 (copy_keymap_item, append_key, push_text_char_description):
6263 Now static.
6264 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6265 (DENSE_TABLE_SIZE): Remove; unused.
6266 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6267 (describe_map_tree):
6268 Rename locals to avoid shadowing.
6269
6270 * keyboard.c: Declare functions static if they are not used elsewhere.
6271 (echo_char, echo_dash, cmd_error, top_level_2):
6272 (poll_for_input, handle_async_input): Now static.
6273 (read_char, kbd_buffer_get_event, make_lispy_position):
6274 (make_lispy_event, make_lispy_movement, apply_modifiers):
6275 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6276 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6277 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6278 (read_key_sequence, read_char): Mark locals as initialized.
6279 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6280
6281 * keyboard.h (make_ctrl_char): New decl.
6282 (mark_kboards): Move decl here ...
6283 * alloc.c (mark_kboards): ... from here.
6284
6285 * lisp.h (force_auto_save_soon): New decl.
6286
6287 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6288 (DEFINE_DUMMY_FUNCTION): New macro.
6289 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6290 Use it.
6291 (main): Add casts to avoid warnings
6292 if GCC considers string literals to be constants.
6293
6294 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6295
6296 * dbusbind.c: Pointer signedness fixes.
6297 (xd_signature, xd_append_arg, xd_initialize):
6298 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6299 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6300 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6301 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6302
6303 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6304 if GCC considers string literals to be constants.
6305 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6306
6307 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6308
6309 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6310 (print_preprocess, print_object): New macro to fix last change.
6311
6312 * print.c (print_preprocess): Don't forget font objects.
6313
6314 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6315
6316 * emacs.c (USAGE3): Doc fixes.
6317
6318 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6319
6320 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6321 structure.
6322
6323 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6324
6325 * lisp.h (VWindow_system, Qfile_name_history):
6326 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6327 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6328 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6329
6330 * w32select.c: Don't #include "keyboard.h".
6331 (run_protected): Add extern declaration for waiting_for_input.
6332
6333 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6334 * w32console.c (detect_input_pending, read_input_pending)
6335 (encode_terminal_code):
6336 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6337 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6338 (w32_system_caret_y, Qfile_name_history):
6339 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6340 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6341 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6342 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6343 * w32proc.c (Qlocal, report_file_error):
6344 * w32term.c (Vwindow_system, updating_frame):
6345 * w32uniscribe.c (initialized, uniscribe_font_driver):
6346 Remove unneeded extern declarations.
6347
6348 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6349
6350 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6351
6352 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6353
6354 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6355 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6356 These macros can no longer be used for assignment.
6357
6358 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6359 Assign struct members directly, instead of using BUF_BEGV etc.
6360 (record_buffer_markers, fetch_buffer_markers): New functions for
6361 recording and fetching special buffer markers.
6362 (set_buffer_internal_1, set_buffer_temp): Use them.
6363
6364 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6365
6366 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6367
6368 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6369 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6370
6371 * xdisp.c (hscroll_window_tree):
6372 (reconsider_clip_changes): Use PT instead of BUF_PT.
6373
6374 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6375
6376 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6377 $(EMACS_ROOT)/lib/intprops.h.
6378
6379 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6380
6381 Fix more problems found by GCC 4.5.2's static checks.
6382
6383 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6384 to unsigned char * to avoid compiler diagnostic.
6385 (xg_free_frame_widgets): Make it clear that a local variable is
6386 needed only if USE_GTK_TOOLTIP.
6387 (gdk_window_get_screen): Make it clear that this macro is needed
6388 only if USE_GTK_TOOLTIP.
6389 (int_gtk_range_get_value): New function, which avoids a diagnostic
6390 from gcc -Wbad-function-cast.
6391 (xg_set_toolkit_scroll_bar_thumb): Use it.
6392 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6393 diagnostic from gcc -Wbad-function-cast.
6394 (get_utf8_string, xg_get_file_with_chooser):
6395 Rename locals to avoid shadowing.
6396 (create_dialog): Move locals to avoid shadowing.
6397
6398 * xgselect.c (xg_select): Remove unused var.
6399
6400 * image.c (four_corners_best): Mark locals as initialized.
6401 (gif_load): Initialize transparent_p to zero (Bug#8238).
6402 Mark another local as initialized.
6403 (my_png_error, my_error_exit): Mark with NO_RETURN.
6404
6405 * image.c (clear_image_cache): Now static.
6406 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6407 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6408 (x_edge_detection): Remove unnecessary cast that
6409 gcc -Wbad-function-cast diagnoses.
6410 (gif_load): Fix pointer signedness.
6411 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6412 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6413
6414 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6415
6416 Improve quality of tests for time stamp overflow.
6417 For example, without this patch (encode-time 0 0 0 1 1
6418 1152921504606846976) returns the obviously-bogus value (-948597
6419 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6420 reports time overflow. See
6421 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6422 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6423 * editfns.c: Include limits.h and intprops.h.
6424 (TIME_T_MIN, TIME_T_MAX): New macros.
6425 (time_overflow): Move earlier, to before first use.
6426 (hi_time, lo_time): New functions, for an accurate test for
6427 out-of-range times.
6428 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6429 (Fget_internal_run_time): Don't assume time_t fits in int.
6430 (make_time): Use list2 instead of Fcons twice.
6431 (Fdecode_time): More accurate test for out-of-range times.
6432 (check_tm_member): New function.
6433 (Fencode_time): Use it, to test for out-of-range times.
6434 (lisp_time_argument): Don't rely on undefined left-shift and
6435 right-shift behavior when checking for time stamp overflow.
6436
6437 * editfns.c (time_overflow): New function, refactoring common code.
6438 (Fformat_time_string, Fdecode_time, Fencode_time):
6439 (Fcurrent_time_string): Use it.
6440
6441 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6442 * dired.c (make_time): Move to ...
6443 * editfns.c (make_time): ... here.
6444 * systime.h: Note the move.
6445
6446 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6447
6448 * fringe.c (update_window_fringes): Remove unused variables.
6449
6450 * unexmacosx.c (copy_data_segment): Also copy __got section.
6451 (Bug#8223)
6452
6453 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6454
6455 * termcap.c [MSDOS]: Include "msdos.h".
6456 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6457 Constify `char *' arguments and their references according to
6458 prototypes in tparam.h.
6459
6460 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6461
6462 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6463 Adapt all references accordingly.
6464
6465 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6466
6467 2011-03-11 Tom Tromey <tromey@redhat.com>
6468
6469 * buffer.c (syms_of_buffer): Remove obsolete comment.
6470
6471 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6472
6473 * termhooks.h (encode_terminal_code): Declare prototype.
6474
6475 * msdos.c (encode_terminal_code): Don't declare prototype.
6476
6477 * term.c (encode_terminal_code): Now external again, used by
6478 w32console.c and msdos.c.
6479
6480 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6481 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6482
6483 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6484
6485 Fix some minor problems found by GCC 4.5.2's static checks.
6486
6487 * fringe.c (update_window_fringes): Mark locals as initialized
6488 (Bug#8227).
6489 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6490
6491 * alloc.c (mark_fringe_data): Move decl from here ...
6492 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6493 to check its interface.
6494 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6495
6496 * fontset.c (free_realized_fontset): Now static.
6497 (Fset_fontset_font): Rename local to avoid shadowing.
6498 (fontset_font): Mark local as initialized.
6499 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6500
6501 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6502
6503 * xselect.c (x_disown_buffer_selections): Remove; not used.
6504 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6505 (x_own_selection, Fx_disown_selection_internal): Rename locals
6506 to avoid shadowing.
6507 (x_handle_dnd_message): Remove local to avoid shadowing.
6508
6509 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6510 so that the caller can use some name other than gcpro1.
6511 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6512 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6513 (Fx_backspace_delete_keys_p):
6514 Use them to avoid shadowing, and rename vars to avoid shadowing.
6515 (x_decode_color, x_set_name, x_window): Now static.
6516 (Fx_create_frame): Add braces to silence GCC warning.
6517 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6518 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6519 Remove unused locals.
6520 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6521 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6522 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6523 macros.
6524
6525 * xterm.h (x_mouse_leave): New decl.
6526
6527 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6528 Remove unused functions.
6529 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6530 (x_calc_absolute_position): Now static.
6531 (XTread_socket): Don't define label "out" unless it's used.
6532 Don't declare local "event" unless it's used.
6533 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6534 unless they are used.
6535 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6536 (x_fatal_error_signal): Remove; not used.
6537 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6538 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6539 (x_error_catcher, x_connection_closed, x_error_handler):
6540 (x_error_quitter, xembed_send_message, x_iconify_frame):
6541 (my_log_handler): Rename locals to avoid shadowing.
6542 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6543 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6544
6545 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6546 Rename or move locals to avoid shadowing.
6547 (tty_defined_color, merge_face_heights): Now static.
6548 (free_realized_faces_for_fontset): Remove; not used.
6549 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6550 does not deduce is never used uninitialized.
6551 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6552 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6553
6554 * terminal.c (store_terminal_param): Now static.
6555
6556 * xmenu.c (menu_highlight_callback): Now static.
6557 (set_frame_menubar): Remove unused local.
6558 (xmenu_show): Rename parameter to avoid shadowing.
6559 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6560 since they might point to immutable storage.
6561 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6562 since it's unused otherwise.
6563
6564 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6565 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6566 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6567 avoids a gcc -Wuninitialized diagnostic.
6568 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6569 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6570 does not deduce are never used uninitialized.
6571
6572 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6573
6574 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6575 * window.c (window_loop, size_window):
6576 (run_window_configuration_change_hook, enlarge_window): Likewise.
6577
6578 * window.c (display_buffer): Now static.
6579 (size_window): Mark variables that gcc -Wuninitialized
6580 does not deduce are never used uninitialized.
6581 * window.h (check_all_windows): New decl, to forestall
6582 gcc -Wmissing-prototypes diagnostic.
6583 * dispextern.h (bidi_dump_cached_states): Likewise.
6584
6585 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6586 shadowing.
6587 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6588 Include <limits.h>.
6589 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6590 and to avoid gcc -Wuninitialized warning.
6591 (load_charset_map): Mark variables that gcc -Wuninitialized
6592 does not deduce are never used uninitialized.
6593 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6594
6595 * coding.c (coding_set_source, coding_set_destination):
6596 Use "else { /* comment */ }" rather than "else /* comment */;"
6597 for clarity, and to avoid gcc -Wempty-body warning.
6598 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6599 a block, when the outer 'i' will do.
6600 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6601 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6602 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6603 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6604 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6605 Rename locals to avoid shadowing.
6606 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6607 * coding.c (emacs_mule_char, encode_invocation_designation):
6608 Now static, since they're not used elsewhere.
6609 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6610 (decode_coding_object, encode_coding_object, detect_coding_system):
6611 (decode_coding_emacs_mule): Mark variables that gcc
6612 -Wuninitialized does not deduce are never used uninitialized.
6613 (detect_coding_iso_2022): Initialize a local variable that might
6614 be used uninitialized. Leave a FIXME because it's not clear that
6615 this initialization is needed. (Bug#8211)
6616 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6617 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6618 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6619 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6620 Remove unused macros.
6621
6622 * category.c (hash_get_category_set): Remove unused local var.
6623 (copy_category_table): Now static, since it's not used elsewhere.
6624 * character.c (string_count_byte8): Likewise.
6625
6626 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6627 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6628
6629 * chartab.c (copy_sub_char_table): Now static, since it's not used
6630 elsewhere.
6631 (sub_char_table_ref_and_range, char_table_ref_and_range):
6632 Rename locals to avoid shadowing.
6633 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6634
6635 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6636 (BIDI_BOB): Remove unused macro.
6637
6638 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6639 deduce are never used uninitialized.
6640 * term.c (encode_terminal_code): Likewise.
6641
6642 * term.c (encode_terminal_code): Now static. Remove unused local.
6643
6644 * tparam.h: New file.
6645 * term.c, tparam.h: Include it.
6646 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6647 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6648 Move these decls to tparam.h, and make them agree with what
6649 is actually in tparam.c. The previous trick of using incompatible
6650 decls in different modules does not conform to the C standard.
6651 All callers of tparam changed to use tparam's actual API.
6652 * tparam.c (tparam1, tparam, tgoto):
6653 Use const pointers where appropriate.
6654
6655 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6656 * cm.h (struct cm): Likewise.
6657 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6658 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6659 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6660 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6661 (turn_on_face, init_tty): Likewise.
6662 * termchar.h (struct tty_display_info): Likewise.
6663
6664 * term.c (term_mouse_position): Rename local to avoid shadowing.
6665
6666 * alloc.c (mark_ttys): Move decl from here ...
6667 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6668
6669 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6670
6671 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6672
6673 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6674
6675 * search.c (compile_pattern_1): Remove argument regp, unused since
6676 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6677 (compile_pattern): Don't pass it.
6678
6679 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6680
6681 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6682 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6683 for ! HAVE_GTK3.
6684 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6685
6686 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6687
6688 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6689 gdk_window_get_screen, gdk_window_get_geometry,
6690 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6691 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6692 (xg_get_pixbuf_from_pixmap): New function.
6693 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6694 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6695 Call xg_get_pixbuf_from_pixmap instead of
6696 gdk_pixbuf_get_from_drawable.
6697 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6698 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6699 (xg_check_special_colors): Use GtkStyleContext and its functions
6700 for HAVE_GTK3.
6701 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6702 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6703 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6704 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6705 Call gtk_widget_get_preferred_size.
6706 (xg_frame_resized): gdk_window_get_geometry only takes 5
6707 parameters.
6708 (xg_win_to_widget, xg_event_is_for_menubar):
6709 Call gdk_x11_window_lookup_for_display.
6710 (xg_set_widget_bg): New function.
6711 (delete_cb): New function.
6712 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6713 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6714 (xg_set_background_color): Call xg_set_widget_bg.
6715 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6716 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6717 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6718 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6719 if ! HAVE_GTK3.
6720 (update_frame_tool_bar): Call gtk_widget_hide.
6721 (xg_initialize): Use GDK_KEY_g.
6722
6723 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6724 if ! HAVE_GTK3
6725 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6726
6727 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6728 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6729 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6730
6731 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6732
6733 * w32xfns.c (select_palette): Check success of RealizePalette against
6734 GDI_ERROR, not zero.
6735
6736 See ChangeLog.11 for earlier changes.
6737
6738 ;; Local Variables:
6739 ;; coding: utf-8
6740 ;; End:
6741
6742 Copyright (C) 2011 Free Software Foundation, Inc.
6743
6744 This file is part of GNU Emacs.
6745
6746 GNU Emacs is free software: you can redistribute it and/or modify
6747 it under the terms of the GNU General Public License as published by
6748 the Free Software Foundation, either version 3 of the License, or
6749 (at your option) any later version.
6750
6751 GNU Emacs is distributed in the hope that it will be useful,
6752 but WITHOUT ANY WARRANTY; without even the implied warranty of
6753 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6754 GNU General Public License for more details.
6755
6756 You should have received a copy of the GNU General Public License
6757 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.