Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-19 Paul Eggert <eggert@cs.ucla.edu>
2
3 Integer and memory overflow issues (Bug#9196).
4
5 * doc.c (get_doc_string): Rework so that
6 get_doc_string_buffer_size is the actual buffer size, rather than
7 being 1 less than the actual buffer size; this makes xpalloc more
8 convenient.
9
10 * image.c (x_allocate_bitmap_record, cache_image):
11 * xselect.c (Fx_register_dnd_atom):
12 Simplify previous changes by using xpalloc.
13
14 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
15 since either will do and ptrdiff_t is convenient with xpalloc.
16
17 * charset.c (charset_table_size)
18 (struct charset_sort_data.priority): Now ptrdiff_t.
19 (charset_compare): Don't overflow if priorities differ greatly.
20 (Fsort_charsets): Don't assume list length fits in int.
21 Check for size-calculation overflow when allocating sort data.
22 (syms_of_charset): Allocate an initial charset table that is
23 just under 64 KiB, to avoid problems with glibc malloc and mmap.
24
25 * cmds.c (internal_self_insert): Check for size-calculation overflow.
26
27 * composite.h (struct composition.glyph_len): Now int, not unsigned.
28 The actual value is always <= INT_MAX, and leaving it unsigned made
29 overflow checking harder.
30
31 * dispextern.h (struct glyph_matrix.rows_allocated)
32 (struct face_cache.size): Now ptrdiff_t, for convenience in use
33 with xpalloc. The values are still always <= INT_MAX.
34
35 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
36
37 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
38 (SAFE_NALLOCA): New macro.
39
40 * region-cache.c (struct boundary.pos, find_cache_boundary)
41 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
42 (set_cache_region, invalidate_region_cache)
43 (revalidate_region_cache, know_region_cache, region_cache_forward)
44 (region_cache_backward, pp_cache):
45 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
46 so that ptrdiff_t * can be passed to xpalloc.
47 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
48 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
49 (pp_cache): Don't assume cache_len fits in int.
50 * region-cache.h: Adjust extern decls to match.
51
52 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
53 EMACS_INT, since either will do, for xpalloc.
54
55 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
56 (xnmalloc, xnrealloc, xpalloc): New functions.
57
58 * bidi.c (bidi_shelve_header_size): New constant.
59 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
60 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
61
62 * bidi.c (bidi_cache_shrink):
63 * buffer.c (overlays_at, overlays_in, record_overlay_string)
64 (overlay_strings):
65 Don't update size of array until after memory allocation succeeds,
66 because xmalloc/xrealloc may not return.
67 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
68 now that we have proper integer overflow checking.
69 (record_overlay_string, overlay_strings): Catch overflows when
70 calculating size of overlay_str_buf.
71
72 * callproc.c (Fcall_process): Check for size overflow when
73 calculating size of args2.
74 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
75 Normally we prefer signed values, but sticking with ptrdiff_t would
76 require adding more-complicated checks.
77
78 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
79 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
80 Redo buffer-overflow calculations to avoid integer overflow.
81 Add a FIXME comment where memory seems to be over-allocated.
82
83 * character.c (Fstring): Check for size-calculation overflow.
84
85 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
86 unnecessary integer overflow. Check for size overflow.
87 (encode_coding_object): Don't update size until xmalloc succeeds.
88
89 * composite.c (get_composition_id): Check for overflow in glyph
90 length calculations.
91
92 Integer and memory overflow fixes for display code.
93 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
94 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
95 (scrolling_window): Check for overflow in size calculations.
96 (line_draw_cost, realloc_glyph_pool, add_row_entry):
97 Don't assume glyph table len fits in int.
98 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
99 (row_table_size): Now ptrdiff_t, not int.
100 (scrolling_window): Avoid overflow in size calculations.
101 Don't update size until allocation succeeds.
102 * fns.c (concat): Check for overflow in size calculations.
103 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
104 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
105 (NEXT_ALMOST_PRIME_LIMIT): New constant.
106
107 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
108 (get_doc_string): Check for size calculation overflow.
109 Don't update size until allocation succeeds.
110 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
111 EMACS_INT, where ptrdiff_t will do.
112 (Fsubstitute_command_keys): Check for string overflow.
113
114 * editfns.c (set_time_zone_rule): Don't assume environment length
115 fits in int.
116 (message_length): Now ptrdiff_t, not int.
117 (Fmessage_box): Don't update size until allocation succeeds.
118 Don't assume message length fits in int.
119 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
120
121 * emacs.c (main): Do not reallocate argv, since there is a null at
122 the end that can be overwritten, and this way there's no need to
123 worry about size-calculation overflow.
124 (sort_args): Check for size-calculation overflow.
125
126 * eval.c (init_eval_once, grow_specpdl): Don't update size until
127 alloc succeeds.
128 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
129
130 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
131 (x_set_scroll_bar_width, x_figure_window_size):
132 Check for integer overflow.
133 (x_set_alpha): Do not assume XINT fits in int.
134
135 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
136 This is for the members text_lines, text_cols, total_lines, total_cols,
137 where the system imposes an 'int' limit.
138
139 * fringe.c (Fdefine_fringe_bitmap):
140 Don't update size until alloc works.
141
142 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
143 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
144
145 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
146 Check for size-calculation overflow.
147 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
148 do, as we prefer signed integers.
149 (id_to_widget.max_size, id_to_widget.used)
150 (xg_store_widget_in_map, xg_remove_widget_from_map)
151 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
152 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
153 Use and return ptrdiff_t, not int.
154 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
155 * gtkutil.h: Change prototypes to match the above.
156
157 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
158 are duplicate now that they've been promoted to lisp.h.
159 (x_allocate_bitmap_record, x_alloc_image_color)
160 (make_image_cache, cache_image, xpm_load):
161 Don't update size until alloc is done.
162 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
163 (x_detect_edges):
164 Check for size calculation overflow.
165 (ct_colors_allocated_max): New constant.
166 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
167 overflow.
168
169 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
170 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
171 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
172 Use ptrdiff_t, not int, to count maps.
173 (read_char_minibuf_menu_prompt): Check for overflow in size
174 calculations. Don't update size until allocation succeeds. Redo
175 calculations to avoid overflow.
176 * keyboard.h: Change prototypes to match the above.
177
178 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
179 to count maps.
180 (current_minor_maps): Check for size calculation overflow.
181 * keymap.h: Change prototypes to match the above.
182
183 * lread.c (read1, init_obarray): Don't update size until alloc done.
184
185 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
186 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
187
188 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
189 Now ptrdiff_t, not int.
190 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
191 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
192
193 * process.c (Fnetwork_interface_list): Check for overflow
194 in size calculation.
195
196 * region-cache.c (move_cache_gap): Check for size calculation overflow.
197
198 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
199 overflow. Don't bother calling xmalloc when xrealloc will do.
200
201 * search.c (Freplace_match): Check for size calculation overflow.
202 (Fset_match_data): Don't assume list lengths fit in 'int'.
203
204 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
205 for command line length. Do not attempt to address one before the
206 beginning of an array, as that's not portable.
207
208 * term.c (max_frame_lines): Remove; unused.
209 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
210 not int.
211 (encode_terminal_code, calculate_costs): Check for size
212 calculation overflow.
213 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
214 table lengths and related sizes. Don't update size until alloc
215 done. Redo calculations to avoid overflow.
216 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
217
218 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
219 subtracting pointers.
220 (gobble_line): Check for overflow more carefully. Don't update size
221 until alloc done.
222
223 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
224 Don't update size until alloc done.
225 Redo size calculations to avoid overflow.
226 Check for size calculation overflow.
227 (main) [DEBUG]: Fix typo in invoking tparam1.
228
229 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
230 Use ptrdiff_t, not int, for sizes.
231 (store_mode_line_noprop_char): Don't update size until alloc done.
232
233 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
234 Use ptrdiff_t, not int, for sizes.
235 (Finternal_make_lisp_face, cache_face):
236 Check for size calculation overflow.
237 (cache_face): Treat size calculation overflows as if they were
238 memory exhaustion (the usual treatment), rather than aborting.
239
240 * xfns.c (x_encode_text, x_set_name_internal)
241 (Fx_change_window_property): Use ptrdiff_t, not int, to count
242 sizes, since they can exceed INT_MAX in size. Check for size
243 calculation overflow.
244
245 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
246 (xg_select): Check for size calculation overflow.
247 Don't update size until alloc done.
248
249 * xrdb.c (get_environ_db): Don't assume path length fits in int,
250 as sprintf is limited to int lengths.
251
252 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
253 (X_LONG_MIN): New macros.
254 Use them to make the following changes clearer.
255 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
256 This change doesn't affect the value now, but it may help remind
257 future maintainers not to raise the value too much later.
258 (SELECTION_QUANTUM): Remove, replacing with ...
259 (selection_quantum): ... new function, which avoids overflow.
260 All uses changed.
261 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
262 assumption that selection length fits in 'int'.
263 (x_reply_selection_request, x_handle_selection_request)
264 (x_get_window_property, receive_incremental_selection)
265 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
266 (lisp_data_to_selection_data, clean_local_selection_data):
267 Use ptrdiff_t, not int, to record length of selection.
268 (x_reply_selection_request, x_get_window_property)
269 (receive_incremental_selection, x_property_data_to_lisp):
270 Redo calculations to avoid overflow.
271 (x_reply_selection_request): When sending hint, ceiling it at
272 X_LONG_MAX rather than relying on wraparound overflow to send
273 something.
274 (x_get_window_property, receive_incremental_selection)
275 (lisp_data_to_selection_data, x_property_data_to_lisp):
276 Check for size-calculation overflow.
277 (x_get_window_property, receive_incremental_selection)
278 (lisp_data_to_selection_data, Fx_register_dnd_atom):
279 Don't store size until memory allocation succeeds.
280 (x_get_window_property): Plug memory leak on memory exhaustion.
281 Don't double-block input; malloc is safe here. Don't assume 2**34
282 - 4 fits in unsigned long. Add an xassert to check
283 XGetWindowProperty overflow. Be more careful about overflow
284 calculations, and distinguish size from memory overflow better.
285 (receive_incremental_selection): When tracing, don't assume
286 unsigned int is less than INT_MAX.
287 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
288 harmful) conversions of unsigned short to int.
289 (lisp_data_to_selection_data): Don't assume that integers
290 in the range -65535 through -1 fit in an X unsigned short.
291 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
292 result parameters unless successful. Rely on cons_to_unsigned
293 to report problems with elements; the old code wasn't right anyway.
294 (x_check_property_data): Check for int overflow; we cannot use
295 a wider type due to X limits.
296 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
297
298 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
299
300 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
301 (x_term_init): Check for size calculation overflow.
302 (x_color_cells): Don't store size until memory allocation succeeds.
303 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
304 Don't assume alloca size is less than MAX_ALLOCA.
305 (x_term_init): Don't assume length fits in int (sprintf is limited
306 to int size).
307
308 Use ptrdiff_t for composition IDs.
309 * character.c (lisp_string_width):
310 * composite.c (composition_table_size, n_compositions)
311 (get_composition_id, composition_gstring_from_id):
312 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
313 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
314 * window.c (Frecenter):
315 Use ptrdiff_t, not int, for composition IDs.
316 * composite.c (get_composition_id): Check for integer overflow.
317 * composite.h: Adjust prototypes to match the above changes.
318
319 Use ptrdiff_t for hash table indexes.
320 * category.c (hash_get_category_set):
321 * ccl.c (ccl_driver):
322 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
323 * coding.c (coding_system_charset_list, detect_coding_system):
324 * coding.h (struct coding_system.id):
325 * composite.c (get_composition_id, gstring_lookup_cache):
326 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
327 * image.c (xpm_get_color_table_h):
328 * lisp.h (hash_lookup, hash_put):
329 * minibuf.c (Ftest_completion):
330 Use ptrdiff_t for hash table indexes, not int (which is too
331 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
332 32-bit --with-wide-int hosts).
333
334 * charset.c (Fdefine_charset_internal): Check for integer overflow.
335 Add a FIXME comment about memory leaks.
336 (syms_of_charset): Don't assume xmalloc returns.
337
338 Don't assume that stated character widths fit in int.
339 * character.c (Fchar_width, c_string_width, lisp_string_width):
340 * character.h (CHAR_WIDTH):
341 * indent.c (MULTIBYTE_BYTES_WIDTH):
342 Use sanitize_char_width to avoid undefined and/or bad behavior
343 with outlandish widths.
344 * character.h (sanitize_tab_width): Renamed from sanitize_width,
345 now that we have two such functions. All uses changed.
346 (sanitize_char_width): New inline function.
347
348 Don't assume that tab-width fits in int.
349 * character.h (sanitize_width): New inline function.
350 (SANE_TAB_WIDTH): New macro.
351 (ASCII_CHAR_WIDTH): Use it.
352 * indent.c (sane_tab_width): Remove. All uses replaced by
353 SANE_TAB_WIDTH (current_buffer).
354 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
355
356 * fileio.c: Integer overflow issues with file modes.
357 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
358
359 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
360 Remove unreachable code.
361 (read_hex, load_charset_map_from_file): Check for integer overflow.
362
363 * xterm.c: don't go over XClientMessageEvent limit
364 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
365 (x_send_scroll_bar_event): Likewise. Check that the size does not
366 exceed limits imposed by XClientMessageEvent, as well as the usual
367 ptrdiff_t and size_t limits.
368
369 * keyboard.c: Overflow, signedness and related fixes.
370 (make_lispy_movement): Use same integer type in forward decl
371 that is used in the definition.
372 (read_key_sequence, keyremap_step):
373 Change bufsize argument back to int, undoing my 2011-03-30 change.
374 We prefer signed types, and int is wide enough here.
375 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
376 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
377 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
378 length, not size_t. Use ptrdiff_t for index, not int.
379 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
380 possibility of integer overflow.
381
382 Overflow, signedness and related fixes for images.
383
384 * dispextern.h (struct it.stack[0].u.image.image_id)
385 (struct_it.image_id, struct image.id, struct image_cache.size)
386 (struct image_cache.used, struct image_cache.ref_count):
387 * gtkutil.c (update_frame_tool_bar):
388 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
389 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
390 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
391 * nsmenu.m (update_frame_tool_bar):
392 * xdisp.c (calc_pixel_width_or_height):
393 * xfns.c (image_cache_refcount):
394 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
395 on typical 64-bit hosts.
396
397 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
398 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
399 Omit unnecessary casts to int.
400 (parse_image_spec): Check that integers fall into 'int' range
401 when the callers expect that.
402 (image_ascent): Redo ascent calculation to avoid int overflow.
403 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
404 (lookup_image): Remove unnecessary tests.
405 (xbm_image_p): Locals are now of int, not EMACS_INT,
406 since parse_image_check makes sure they fit into int.
407 (png_load, gif_load, svg_load_image):
408 Prefer int to unsigned where either will do.
409 (tiff_handler): New function, combining the cores of the
410 old tiff_error_handler and tiff_warning_handler. This
411 function is rewritten to use vsnprintf and thereby avoid
412 stack buffer overflows. It uses only the features of vsnprintf
413 that are common to both POSIX and native Microsoft.
414 (tiff_error_handler, tiff_warning_handler): Use it.
415 (tiff_load, gif_load, imagemagick_load_image):
416 Don't assume :index value fits in 'int'.
417 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
418 (imagemagick_load_image): Check that crop parameters fit into
419 the integer types that MagickCropImage accepts. Don't assume
420 Vimagemagick_render_type has a nonnegative value. Don't assume
421 size_t fits in 'long'.
422 (gs_load): Use printmax_t to print the widest integers possible.
423 Check for integer overflow when computing image height and width.
424
425 2011-08-19 Eli Zaretskii <eliz@gnu.org>
426
427 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
428 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
429 from an Org mode buffer to a Speedbar frame.
430
431 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
432 a composition, take its buffer position from IT->cmp_it.charpos.
433 Fixes cursor positioning at the beginning of a line that begins
434 with a composed character.
435
436 2011-08-18 Eli Zaretskii <eliz@gnu.org>
437
438 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
439 character bidirectional type, use STRONG_L instead. Fixes crashes
440 in a buffer produced by `describe-categories'.
441
442 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
443 members before the level stack, so they would be saved and
444 restored when copying iterator state. Fixes incorrect reordering
445 around TABs covered by display properties.
446
447 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
448
449 * process.c (Fnetwork_interface_list): Correctly determine buffer
450 size.
451
452 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
453
454 * eval.c (internal_condition_case, internal_condition_case_1)
455 (internal_condition_case_2, internal_condition_case_n): Remove
456 unnecessary aborts (Bug#9081).
457
458 2011-08-17 Eli Zaretskii <eliz@gnu.org>
459
460 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
461 has no `load' handler, try opening the file locally. (Bug#9311)
462
463 2011-08-16 Ken Brown <kbrown@cornell.edu>
464
465 * gmalloc.c: Expand comment.
466
467 2011-08-16 Eli Zaretskii <eliz@gnu.org>
468
469 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
470 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
471
472 2011-08-16 Ken Brown <kbrown@cornell.edu>
473
474 Fix memory allocation problems in Cygwin build (Bug#9273).
475
476 * unexcw.c ( __malloc_initialized): Declare external variable.
477 (fixup_executable): Force the dumped emacs to reinitialize malloc.
478
479 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
480 variables.
481 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
482 dumped emacs.
483 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
484 in the static heap.
485 [CYGWIN] (special_realloc): New function.
486 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
487 requests to realloc storage in the static heap.
488
489 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
490
491 * bidi.c (bidi_initialize): Remove unused local.
492
493 2011-08-15 Eli Zaretskii <eliz@gnu.org>
494
495 * biditype.h: File removed.
496
497 * bidimirror.h: File removed.
498
499 * deps.mk (bidi.o): Remove biditype.h and
500 bidimirror.h.
501
502 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
503 bidimirror.h.
504
505 * dispextern.h: Fix a typo in the comment to bidi_type_t.
506
507 * chartab.c: Improve commentary for the uniprop_table API.
508
509 * bidi.c (bidi_paragraph_init): Support zero value of
510 bidi_ignore_explicit_marks_for_paragraph_level.
511 (bidi_initialize): Use uniprop_table instead of including
512 biditype.h and bidimirror.h.
513
514 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
515 coordinates of the iterator when restoring from ppos_it.
516 (Bug#9296)
517
518 2011-08-14 Kenichi Handa <handa@m17n.org>
519
520 * process.c (create_process): Call setup_process_coding_systems
521 after the pid of the process is set to -1 (Bug#8162).
522
523 2011-08-14 Eli Zaretskii <eliz@gnu.org>
524
525 * xdisp.c (move_it_in_display_line_to): Don't invoke
526 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
527 ppos_it. Fixes vertical cursor motion when line beginning is
528 covered by an image. (Bug#9296)
529
530 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
531
532 * nsterm.h (ns_run_ascript): Declare.
533 (NSAPP_DATA2_RUNASSCRIPT): Define.
534
535 * nsfns.m (as_script, as_result, as_status): New static variables.
536 (ns_run_ascript): New function.
537 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
538 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
539 the event loop. Get status from as_status (Bug#7276).
540
541 * nsterm.m (sendEvent): If event is NSApplicationDefined and
542 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
543 the event loop (Bug#7276).
544
545 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
546
547 * gnutls.c (QCgnutls_bootprop_priority)
548 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
549 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
550 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
551 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
552 (QCgnutls_bootprop_verify_hostname_error)
553 (QCgnutls_bootprop_callbacks_verify): Rename from
554 Qgnutls_bootprop_..., all uses changed.
555
556 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
557 uses changed.
558
559 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
560
561 * xfaces.c (Qframe_set_background_mode): Now static.
562 * dispextern.h (Qframe_set_background_mode): Remove decl.
563
564 * process.c (Fnetwork_interface_info): Declare local only if needed.
565
566 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
567
568 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
569 (Fnetwork_interface_list): Allocate in increments of bytes instead
570 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
571 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
572 sockaddr.
573 (struct ifflag_def): notrailers is smart on OSX.
574 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
575 Get hardware address with getifaddrs if available.
576
577 2011-08-12 Eli Zaretskii <eliz@gnu.org>
578
579 * xdisp.c (iterate_out_of_display_property): xassert that
580 IT->position is set to within IT->object's boundaries. Break from
581 the loop as soon as EOB is reached; avoids infloops in redisplay
582 when IT->position is set up wrongly due to some bug. Set
583 IT->current to match the bidi iterator unconditionally.
584 (push_display_prop): Allow GET_FROM_STRING as IT->method on
585 entry. Force push_it to save on the stack the current
586 buffer/string position, to be restored by pop_it. Fix flags in
587 the iterator structure wrt the object coming from a display
588 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
589 properties. (Bug#9284)
590
591 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
592
593 * fontset.c (fontset_get_font_group): Add proper type checks.
594 (Bug#9172)
595
596 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
597
598 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
599 and LC_VERSION_MIN_MACOSX.
600 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
601 (dump_it) [LC_FUNCTION_STARTS]: Use it.
602
603 2011-08-08 Eli Zaretskii <eliz@gnu.org>
604
605 * xdisp.c (forward_to_next_line_start): Allow to use the
606 no-display-properties-and-no-overlays under bidi display. Set
607 disp_pos in the bidi iterator to avoid searches for display
608 properties and overlays.
609
610 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
611
612 * editfns.c (Fset_time_zone_rule): Document relationship with the
613 setenv function.
614
615 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
616 the font entity extracted from the cache (Bug#8109).
617
618 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
619
620 * composite.c (autocmp_chars): Don't reset point. That is done by
621 restore_point_unwind (Bug#5984).
622
623 2011-08-07 Juri Linkov <juri@jurta.org>
624
625 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
626 to show the arg `TIME' instead of `TIMEVAL'.
627
628 2011-08-06 Eli Zaretskii <eliz@gnu.org>
629
630 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
631 display property strides EOL and includes a newline, as in
632 longlines-mode. (Bug#9254)
633 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
634 word-wrap under bidirectional display. (Bug#9224)
635
636 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
637 is non-zero, even if the data buffer is NULL. Fixes a crash in
638 vertical-motion with longlines-mode. (Bug#9254)
639
640 2011-08-05 Eli Zaretskii <eliz@gnu.org>
641
642 * bidi.c <bidi_cache_total_alloc>: Now static.
643 (bidi_initialize): Initialize bidi_cache_total_alloc.
644
645 *xdisp.c (display_line): Release buffer allocated for shelved bidi
646 cache. (Bug#9221)
647
648 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
649 amount allocated this far in `bidi_cache_total_alloc'.
650 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
651 non-zero, only free the data buffer without restoring the cache
652 contents. All callers changed.
653
654 * dispextern.h (bidi_unshelve_cache): Update prototype.
655
656 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
657 (move_it_in_display_line, move_it_to)
658 (move_it_vertically_backward, move_it_by_lines): Replace the call
659 to xfree to an equivalent call to bidi_unshelve_cache.
660 (move_it_in_display_line_to): Fix logic of returning
661 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
662
663 2011-08-05 Eli Zaretskii <eliz@gnu.org>
664
665 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
666 came from a string character with a `cursor' property. (Bug#9229)
667
668 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
669
670 * Makefile.in (LIB_PTHREAD): New variable.
671 (LIBES): Add LIB_PTHREAD (Bug#9216).
672
673 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
674 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
675
676 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
677
678 * regex.c (re_iswctype): Remove some redundant boolean
679 conversions.
680
681 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
682
683 * xterm.c (x_find_topmost_parent): New function.
684 (x_set_frame_alpha): Find topmost parent window with
685 x_find_topmost_parent and set the property there also (bug#9181).
686 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
687
688 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
689
690 * callproc.c (Fcall_process): Avoid vfork clobbering
691 the local vars buffer, coding_systems, current_dir.
692
693 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
694
695 * keymap.c (Fmake_composed_keymap): Move to subr.el.
696
697 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
698
699 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
700 so that it is not optimized away.
701
702 * xdisp.c (compute_display_string_pos): Remove unused local.
703
704 2011-08-02 Eli Zaretskii <eliz@gnu.org>
705
706 Fix slow cursor motion and scrolling in large buffers with
707 selective display, like Org Mode buffers. (Bug#9218)
708
709 * dispextern.h (struct bidi_it): New member disp_prop_p.
710
711 * xdisp.c: Remove one-slot cache of display string positions.
712 (compute_display_string_pos): Accept an additional argument
713 DISP_PROP_P; callers changed. Scan at most 5K characters forward
714 for a display string or property. If found, set DISP_PROP_P
715 non-zero.
716
717 * bidi.c (bidi_fetch_char): Accept an additional argument
718 DISP_PROP_P, and pass it to compute_display_string_pos.
719 Only handle text covered by a display string if DISP_PROP_P is returned
720 non-zero. All callers of bidi_fetch_char changed.
721
722 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
723
724 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
725
726 2010-12-03 Don March <don@ohspite.net>
727
728 * keymap.c (Fdefine_key): Fix non-prefix key error message when
729 last character M-[char] is translated to ESC [char] (bug#7541).
730
731 2011-08-02 Kenichi Handa <handa@m17n.org>
732
733 * lisp.h (uniprop_table): Extern it.
734
735 * chartab.c (uniprop_table): Make it non-static.
736
737 2011-08-01 Eli Zaretskii <eliz@gnu.org>
738
739 * xdisp.c (forward_to_next_line_start): Accept additional argument
740 BIDI_IT_PREV, and store into it the state of the bidi iterator had
741 on the newline.
742 (reseat_at_next_visible_line_start): Use the bidi iterator state
743 returned by forward_to_next_line_start to restore the state of
744 it->bidi_it after backing up to previous newline. (Bug#9212)
745
746 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
747
748 * regex.c (re_comp): Protoize.
749 (re_exec): Fix return type.
750 (regexec): Fix type of `ret'. (Bug#9203)
751
752 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
753
754 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
755 This is needed if max-image-size is a floating-point number.
756
757 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
758
759 * print.c (print_object): Print empty symbol as ##.
760
761 * lread.c (read1): Read ## as empty symbol.
762
763 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
764
765 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
766 setting frame foreground color (Bug#9175).
767 (x_set_background_color): Likewise.
768
769 * nsmenu.m (-setText): Size tooltip dimensions precisely to
770 contents (Bug#9176).
771 (EmacsTooltip -init): Remove bezels and add shadows to
772 tooltip windows.
773
774 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
775 or scroll bar (Bug#8470).
776
777 * nsfont.m (nsfont_open): Remove assignment to voffset and
778 unnecessary vars hshink, expand, hd, full_height, min_height.
779 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
780
781 * nsterm.h (nsfont_info): Remove voffset field.
782
783 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
784
785 Implement strike-through and overline on NextStep (Bug#8863).
786
787 * nsfont.m (nsfont_open): Use underline position provided by font,
788 instead of hard-coded value of 2.
789 (nsfont_draw): Call ns_draw_text_decoration instead.
790
791 * nsterm.h: Add declaration for ns_draw_text_decoration.
792
793 * nsterm.m (ns_draw_text_decoration): New function for drawing
794 underline, overline, and strike-through.
795 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
796 ns_draw_text_decoration. Change treatment of cursor drawing to
797 accomodate underlining, etc.
798
799 2011-07-28 Eli Zaretskii <eliz@gnu.org>
800
801 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
802 default.
803
804 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
805
806 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
807 Without this fix, if a signal arrives just after memory fills up,
808 'malloc' might be invoked reentrantly.
809
810 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
811 In other words, assume that every image size is allowed, on non-X
812 hosts. This assumption is probably wrong, but it lets Emacs compile.
813
814 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
815
816 * regex.c (re_iswctype): Convert return values to boolean.
817
818 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
819
820 * xdisp.c (compute_display_string_pos): Don't use cached display
821 string position if the buffer had its restriction changed.
822 (Bug#9184)
823
824 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
825
826 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
827
828 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
829
830 Integer signedness and overflow and related fixes. (Bug#9079)
831
832 * bidi.c: Integer size and overflow fixes.
833 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
834 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
835 (bidi_cache_find_level_change, bidi_cache_ensure_space)
836 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
837 (bidi_find_other_level_edge):
838 Use ptrdiff_t instead of EMACS_INT where either will do.
839 This works better on 32-bit hosts configured --with-wide-int.
840 (bidi_cache_ensure_space): Check for size-calculation overflow.
841 Use % rather than repeated addition, for better worst-case speed.
842 Don't set bidi_cache_size until after xrealloc returns, because it
843 might not return.
844 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
845 (bidi_cache_ensure_space): Also check that the bidi cache size
846 does not exceed that of the largest Lisp string or buffer. See Eli
847 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
848
849 * alloc.c (__malloc_size_t): Remove.
850 All uses replaced by size_t. See Andreas Schwab's note
851 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
852
853 * image.c: Improve checking for integer overflow.
854 (check_image_size): Assume that f is nonnull, since
855 it is always nonnull in practice. This is one less thing to
856 worry about when checking for integer overflow later.
857 (x_check_image_size): New function, which checks for integer
858 overflow issues inside X.
859 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
860 This removes the need for a memory_full check.
861 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
862 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
863 (xbm_read_bitmap_data): Change locals back to 'int', since
864 their values must fit in 'int'.
865 (xpm_load_image, png_load, tiff_load):
866 Invoke x_create_x_image_and_pixmap earlier,
867 to avoid much needless work if the image is too large.
868 (tiff_load): Treat overly large images as if
869 x_create_x_image_and_pixmap failed, not as malloc failures.
870 (gs_load): Use x_check_image_size.
871
872 * gtkutil.c: Omit integer casts.
873 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
874 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
875
876 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
877
878 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
879 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
880 would wrongly return t on a 64-bit host.
881
882 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
883 The plain *_OVERFLOW macros run afoul of GCC bug 49705
884 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
885 and therefore cause GCC to emit a bogus diagnostic in some cases.
886
887 * image.c: Integer signedness and overflow and related fixes.
888 This is not an exhaustive set of fixes, but it's time to
889 record what I've got.
890 (lookup_pixel_color, check_image_size): Remove redundant decls.
891 (check_image_size): Don't assume that arbitrary EMACS_INT values
892 fit in 'int', or that arbitrary 'double' values fit in 'int'.
893 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
894 (tiff_load, imagemagick_load_image):
895 Check for overflow in size calculations.
896 (x_create_x_image_and_pixmap): Remove unnecessary test for
897 xmalloc returning NULL; that can't happen.
898 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
899 (xpm_color_bucket): Use better integer hashing function.
900 (xpm_cache_color): Don't possibly over-allocate memory.
901 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
902 (gif_memory_source):
903 Use ptrdiff_t, not int or size_t, to record sizes.
904 (png_load): Don't assume values greater than 2**31 fit in 'int'.
905 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
906 either works, as we prefer signed integers.
907 (tiff_read_from_memory, tiff_write_from_memory):
908 Return tsize_t, not size_t, since that's what the TIFF API wants.
909 (tiff_read_from_memory): Don't fail simply because the read would
910 go past EOF; instead, return a short read.
911 (tiff_load): Omit no-longer-needed casts.
912 (Fimagemagick_types): Don't assume size fits into 'int'.
913
914 Improve hashing quality when configured --with-wide-int.
915 * fns.c (hash_string): New function, taken from sxhash_string.
916 Do not discard information about ASCII character case; this
917 discarding is no longer needed.
918 (sxhash-string): Use it. Change sig to match it. Caller changed.
919 * lisp.h: Declare it.
920 * lread.c (hash_string): Remove, since we now use fns.c's version.
921 The fns.c version returns a wider integer if --with-wide-int is
922 specified, so this should help the quality of the hashing a bit.
923
924 * emacs.c: Integer overflow minor fix.
925 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
926 Define only if GNU_LINUX.
927 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
928
929 * dispnew.c: Integer signedness and overflow fixes.
930 Remove unnecessary forward decls, that were a maintenance hassle.
931 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
932 All uses changed.
933 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
934 (scrolling_window): Use ptrdiff_t, not int, for byte count.
935 (prepare_desired_row, line_draw_cost):
936 Use int, not unsigned, where either works.
937 (save_current_matrix, restore_current_matrix):
938 Use ptrdiff_t, not size_t, where either works.
939 (init_display): Check for overflow more accurately, and without
940 relying on undefined behavior.
941
942 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
943 Remove, replacing with the new symbols in lisp.h. All uses changed.
944 * fileio.c (make_temp_name):
945 * filelock.c (lock_file_1, lock_file):
946 * xdisp.c (message_dolog):
947 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
948 Use pMd etc. instead.
949 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
950 replacing the pWIDE etc. symbols removed from editfns.c.
951
952 * keyboard.h (num_input_events): Now uintmax_t.
953 This is (very slightly) less likely to mess up due to wraparound.
954 All uses changed.
955
956 * buffer.c: Integer signedness fixes.
957 (alloc_buffer_text, enlarge_buffer_text):
958 Use ptrdiff_t rather than size_t when either will do, as we prefer
959 signed integers.
960
961 * alloc.c: Integer signedness and overflow fixes.
962 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
963 (__malloc_size_t): Default to size_t, not to int.
964 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
965 (Fgarbage_collect, mark_object_loop_halt, mark_object):
966 Prefer ptrdiff_t to size_t when either would do, as we prefer
967 signed integers.
968 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
969 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
970 Now const. Initialize with values that are in range even if char
971 is signed.
972 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
973 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
974 These functions do the right thing with sizes > 2**32.
975 (check_depth): Now ptrdiff_t, not int.
976 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
977 Adjust to new way of storing sizes. Check for size overflow bugs
978 in rest of code.
979 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
980 slightly wrong anyway, as it missed one instance of
981 XMALLOC_OVERRUN_CHECK_OVERHEAD.
982 (refill_memory_reserve): Omit needless cast to size_t.
983 (mark_object_loop_halt): Mark as externally visible.
984
985 * xselect.c: Integer signedness and overflow fixes.
986 (Fx_register_dnd_atom, x_handle_dnd_message):
987 Use ptrdiff_t, not size_t, since we prefer signed.
988 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
989 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
990 x_dnd_atoms_size and x_dnd_atoms_length.
991
992 * doprnt.c: Prefer signed to unsigned when either works.
993 * eval.c (verror):
994 * doprnt.c (doprnt):
995 * lisp.h (doprnt):
996 * xdisp.c (vmessage):
997 Use ptrdiff_t, not size_t, when using or implementing doprnt,
998 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
999 prefer signed arithmetic to avoid comparison confusion.
1000 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1001 but is a bit tricky.
1002
1003 Assume freestanding C89 headers, string.h, stdlib.h.
1004 * data.c, doprnt.c, floatfns.c, print.c:
1005 Include float.h unconditionally.
1006 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1007 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1008 * regex.c: Likewise for stddef.h, string.h.
1009 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1010 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1011 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1012 (STDC_HEADERS): Remove obsolete defines.
1013 * sysdep.c: Include limits.h unconditionally.
1014
1015 Assume support for memcmp, memcpy, memmove, memset.
1016 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1017 * regex.c (memcmp, memcpy):
1018 Remove; we assume C89 now.
1019
1020 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1021 (__malloc_safe_bcopy): Remove; no longer needed.
1022
1023 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1024 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1025 well either way, and we prefer signed to unsigned.
1026
1027 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1028
1029 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1030 closes the connection while we're reading (bug#9182).
1031
1032 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1033
1034 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1035 are specified (Bug#9168).
1036
1037 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1040 Found by GCC static checking and --with-wide-int on a 32-bit host.
1041
1042 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1043
1044 * xdisp.c (compute_display_string_pos): Fix logic of caching
1045 previous display string position. Initialize cached_prev_pos to
1046 -1. Fixes slow-down at the beginning of a buffer.
1047
1048 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1049
1050 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1051 for attrs[LFACE_FONTSET_INDEX].
1052
1053 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * xml.c (parse_region): Remove unused local
1056 that was recently introduced.
1057
1058 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1059
1060 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1061 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1062
1063 * xdisp.c (move_it_in_display_line_to): Record the best matching
1064 position for TO_CHARPOS while scanning the line, and restore it on
1065 exit if none of the characters scanned was an exact match.
1066 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1067 when exact match is impossible due to invisible text, and the
1068 lines are truncated.
1069
1070 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1071
1072 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1073 for OSX >= 10.7.
1074
1075 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1076
1077 Fix a significant slow-down of cursor motion with C-n, C-p,
1078 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1079 auto-repeat under bidi redisplay in fontified buffers.
1080 * xdisp.c (compute_stop_pos_backwards): New function.
1081 (next_element_from_buffer): Call compute_stop_pos_backwards to
1082 find a suitable prev_stop when we find ourselves before
1083 base_level_stop.
1084 (reseat): Don't look for prev_stop, as that could mean a very long
1085 run.
1086 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1087 <cached_disp_overlay_modiff>: Cache for last found display string
1088 position.
1089 (compute_display_string_pos): Return the cached position if asked
1090 about the same buffer in the same area of character positions, and
1091 the buffer wasn't changed since the time the display string
1092 position was cached.
1093
1094 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1095
1096 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1097 is an integer, which is important for empty lines. (Bug#9149)
1098
1099 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1100
1101 * frame.c (Fmodify_frame_parameters): In tty case, update the
1102 default face if necessary (Bug#4238).
1103
1104 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1105
1106 * editfns.c (Fstring_to_char): No need to explain what a character
1107 is in the docstring (Bug#6576).
1108
1109 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1110
1111 * xml.c (parse_region): Make sure we always return a tree.
1112
1113 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1114
1115 * xml.c (parse_region): If a document contains only comments,
1116 return that, too.
1117
1118 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1119
1120 * xml.c (make_dom): Return comments, too.
1121
1122 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 Port to OpenBSD.
1125 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1126 and the surrounding thread.
1127 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1128 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1129 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1130 timer goes off.
1131 * s/openbsd.h (BROKEN_SIGIO): Define.
1132 * unexelf.c (unexec) [__OpenBSD__]:
1133 Don't update the .mdebug section of the Alpha COFF symbol table.
1134
1135 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1136
1137 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1138 (bug#8460).
1139
1140 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1143 This fixes some race conditions on the permissions of any newly
1144 created file.
1145
1146 * alloc.c (valid_pointer_p): Use pipe, not open.
1147 This fixes some permissions issues when debugging.
1148
1149 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1150 If fchown fails to set both uid and gid, try to set just gid,
1151 as that is sometimes allowed. Adjust the file's mode to eliminate
1152 setuid or setgid bits that are inappropriate if fchown fails.
1153
1154 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1155
1156 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1157 to compare Lisp_Objects.
1158 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1159 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1160 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1161
1162 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1163
1164 * lread.c (read_integer): Unread even EOF character.
1165 (read1): Likewise. Properly record start position of symbol.
1166
1167 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1168 symbol character follows.
1169
1170 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1173 This works around a problem with the previous change to Fcopy_file.
1174 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1175 and without this change, GCC might complain about discarding
1176 fchown's return value.
1177
1178 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1179
1180 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1181
1182 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1183
1184 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1185
1186 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1187
1188 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1189 it's used from the C level.
1190
1191 * process.c: Use the same condition for POLL_FOR_INPUT in both
1192 keyboard.c and process.c (bug#1858).
1193
1194 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1195
1196 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1197 (Fgnutls_boot): Use it.
1198
1199 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1200
1201 * doc.c (Fsubstitute_command_keys): Revert last change.
1202
1203 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1204
1205 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1206 quotes the next character, and doesn't affect other longer
1207 sequences (bug#8935).
1208
1209 * lread.c (syms_of_lread): Clarify that is isn't only
1210 `eval-buffer' and `eval-defun' that's affected by
1211 `lexical-binding' (bug#8460).
1212
1213 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1214
1215 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1216 bidi redisplay when a line includes both an image and is
1217 truncated.
1218
1219 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1220
1221 Fix minor problems found by static checking.
1222 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1223 (elsz): Now a signed constant, not a size_t var. We prefer signed
1224 types to unsigned, to avoid integer comparison confusion. Without
1225 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1226 "cannot optimize loop, the loop counter may overflow", a symptom
1227 of the confusion.
1228 * indent.c (Fvertical_motion): Mark locals as initialized.
1229 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1230
1231 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1232
1233 * search.c (Fre_search_backward): Mention `case-fold-search' in
1234 all the re_search_* functions (bug#8138).
1235
1236 * keyboard.c (Fopen_dribble_file): Document when the file is
1237 closed (bug#8056).
1238
1239 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1240
1241 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1242 bidi_cache_idx.
1243
1244 Support bidi reordering of display and overlay strings.
1245 * xdisp.c (compute_display_string_pos)
1246 (compute_display_string_end): Accept additional argument STRING.
1247 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1248 (reseat_to_string): Initialize bidi_it->string.s and
1249 bidi_it->string.schars.
1250 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1251 NULL (avoids a crash in bidi_paragraph_init).
1252 Initialize itb.string.lstring.
1253 (init_iterator): Call bidi_init_it only of a valid
1254 buffer position was specified. Initialize paragraph_embedding to
1255 L2R.
1256 (reseat_to_string): Initialize the bidi iterator.
1257 (display_string): If we need to ignore text properties of
1258 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1259 original value of -1 will not work with bidi.)
1260 (compute_display_string_pos): First arg is now struct
1261 `text_pos *'; all callers changed. Support display properties on
1262 Lisp strings.
1263 (compute_display_string_end): Support display properties on Lisp
1264 strings.
1265 (init_iterator, reseat_1, reseat_to_string): Initialize the
1266 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1267 when iterating on a string not from display properties).
1268 (compute_display_string_pos, compute_display_string_end):
1269 Fix calculation of the object to scan. Fixes an error when using
1270 arrow keys.
1271 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1272 base_level_stop; instead, set base_level_stop to BEGV.
1273 Fixes crashes in vertical-motion.
1274 (next_element_from_buffer): Improve commentary for when
1275 the iterator is before prev_stop.
1276 (init_iterator): Initialize bidi_p from the default value of
1277 bidi-display-reordering, not from buffer-local value. Use the
1278 buffer-local value only if initializing for buffer iteration.
1279 (handle_invisible_prop): Support invisible properties on strings
1280 that are being bidi-reordered.
1281 (set_iterator_to_next): Support bidi reordering of C strings and
1282 Lisp strings.
1283 (next_element_from_string): Support bidi reordering of Lisp
1284 strings.
1285 (handle_stop_backwards): Support Lisp strings as well.
1286 (display_string): Support display of R2L glyph rows.
1287 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1288 (init_iterator): Don't initialize it->bidi_p for strings
1289 here.
1290 (reseat_to_string): Initialize it->bidi_p for strings here.
1291 (next_element_from_string, next_element_from_c_string)
1292 (next_element_from_buffer): Add xassert's for correspondence
1293 between IT's object being iterated and it->bidi_it.string
1294 structure.
1295 (face_before_or_after_it_pos): Support bidi iteration.
1296 (next_element_from_c_string): Handle the case of the first string
1297 character that is not the first one in the visual order.
1298 (get_visually_first_element): New function, refactored from common
1299 parts of next_element_from_buffer, next_element_from_string, and
1300 next_element_from_c_string.
1301 (tool_bar_lines_needed, redisplay_tool_bar)
1302 (display_menu_bar): Force left-to-right direction. Add a FIXME
1303 comment for making that be controlled by a user option.
1304 (push_it, pop_it): Save and restore the state of the
1305 bidi iterator. Save and restore the bidi_p flag.
1306 (pop_it): Iterate out of display property for string iteration as
1307 well.
1308 (iterate_out_of_display_property): Support iteration over strings.
1309 (handle_single_display_spec): Set up it->bidi_it for iteration
1310 over a display string, and call bidi_init_it.
1311 (handle_single_display_spec, next_overlay_string)
1312 (get_overlay_strings_1, push_display_prop): Set up the bidi
1313 iterator for displaying display or overlay strings.
1314 (forward_to_next_line_start): Don't use the shortcut if
1315 bidi-iterating.
1316 (back_to_previous_visible_line_start): If handle_display_prop
1317 pushed the iterator stack, restore the internal state of the bidi
1318 iterator by calling bidi_pop_it same number of times.
1319 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1320 and we are bidi-iterating, don't decrement the iterator position;
1321 instead, set the first_elt flag in the bidi iterator, to produce
1322 the same effect.
1323 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1324 (push_display_prop): xassert that we are iterating a buffer.
1325 (push_it, pop_it): Save and restore paragraph_embedding member.
1326 (handle_single_display_spec, next_overlay_string)
1327 (get_overlay_strings_1, reseat_1, reseat_to_string)
1328 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1329 correctly. Don't assume unibyte strings are not bidi-reordered.
1330 (compute_display_string_pos)
1331 (compute_display_string_end): Fix handling the case of C string.
1332 (push_it, pop_it): Save and restore from_disp_prop_p.
1333 (handle_single_display_spec, push_display_prop): Set the
1334 from_disp_prop_p flag.
1335 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1336 (pop_it): Call iterate_out_of_display_property only if we are
1337 popping after iteration over a string that came from a display
1338 property. Fix a typo in popping stretch info. Add an assertion
1339 for verifying that the iterator position is in sync with the bidi
1340 iterator.
1341 (handle_single_display_spec, get_overlay_strings_1)
1342 (push_display_prop): Fix initialization of paragraph direction for
1343 string when that of the parent object is not yet determined.
1344 (reseat_1): Call bidi_init_it to resync the bidi
1345 iterator with IT's position. (Bug#7616)
1346 (find_row_edges): If ROW->start.pos gives position
1347 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1348 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1349 Reset the from_disp_prop_p flag.
1350 (SAVE_IT, RESTORE_IT): New macros.
1351 (pos_visible_p, face_before_or_after_it_pos)
1352 (back_to_previous_visible_line_start)
1353 (move_it_in_display_line_to, move_it_in_display_line)
1354 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1355 (try_scrolling, redisplay_window, display_line): Use them when
1356 saving a temporary copy of the iterator and restoring it back.
1357 (back_to_previous_visible_line_start, reseat_1)
1358 (init_iterator): Empty the bidi cache "stack".
1359 (move_it_in_display_line_to): If iterator ended up at
1360 EOL, but we never saw any buffer positions smaller than
1361 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1362 motion in bidi-reordered lines.
1363 (move_it_in_display_line_to): Record prev_method and prev_pos
1364 immediately before the call to set_iterator_to_next. Fixes cursor
1365 motion in bidi-reordered lines with stretch glyphs and strings
1366 displayed in margins. (Bug#8133) (Bug#8867)
1367 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1368 TO_CHARPOS.
1369 (pos_visible_p): Support positions in bidi-reordered lines.
1370 Save and restore bidi cache.
1371
1372 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1373 (bidi_paragraph_info): Delete unused struct.
1374 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1375 (bidi_cache_start): New variable.
1376 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1377 to zero.
1378 (bidi_cache_fetch_state, bidi_cache_search)
1379 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1380 (bidi_cache_find, bidi_peek_at_next_level)
1381 (bidi_level_of_next_char, bidi_find_other_level_edge)
1382 (bidi_move_to_visually_next): Compare cache index with
1383 bidi_cache_start rather than with zero.
1384 (bidi_fetch_char): Accept new argument STRING; all callers
1385 changed. Support iteration over a string. Support strings with
1386 display properties. Support unibyte strings. Fix the type of
1387 `len' according to what STRING_CHAR_AND_LENGTH expects.
1388 (bidi_paragraph_init, bidi_resolve_explicit_1)
1389 (bidi_resolve_explicit, bidi_resolve_weak)
1390 (bidi_level_of_next_char, bidi_move_to_visually_next):
1391 Support iteration over a string.
1392 (bidi_set_sor_type, bidi_resolve_explicit_1)
1393 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1394 can now be zero (for strings); special values 0 and -1 were
1395 changed to -1 and -2, respectively.
1396 (bidi_char_at_pos): New function.
1397 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1398 Call it instead of FETCH_MULTIBYTE_CHAR.
1399 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1400 initialized to valid values.
1401 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1402 values.
1403 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1404 the test for valid cached positions. Fix the logic for looking up
1405 the sentinel state in the cache. GCPRO the Lisp string we are
1406 iterating.
1407 (bidi_push_it, bidi_pop_it): New functions.
1408 (bidi_initialize): Initialize the bidi cache start stack pointer.
1409 (bidi_cache_ensure_space): New function, refactored from part of
1410 bidi_cache_iterator_state. Don't assume the required size is just
1411 one BIDI_CACHE_CHUNK away.
1412 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1413 (bidi_count_bytes, bidi_char_at_pos): New functions.
1414 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1415 always valid if bidi_cache_idx is valid.
1416 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1417 is valid if it's going to be used.
1418 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1419 (bidi_cache_fetch_state, bidi_cache_search)
1420 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1421 (bidi_cache_iterator_state, bidi_cache_find)
1422 (bidi_find_other_level_edge, bidi_cache_start_stack):
1423 All variables related to cache indices are now EMACS_INT.
1424
1425 * dispextern.h (struct bidi_string_data): New structure.
1426 (struct bidi_it): New member `string'. Make flag members be 1-bit
1427 fields, and put them last in the struct.
1428 (compute_display_string_pos, compute_display_string_end):
1429 Update prototypes.
1430 (bidi_push_it, bidi_pop_it): Add prototypes.
1431 (struct iterator_stack_entry): New members bidi_p,
1432 paragraph_embedding, and from_disp_prop_p.
1433 (struct it): Member bidi_p is now a bit field 1 bit wide.
1434 (bidi_shelve_cache, bidi_unshelve_cache):
1435 Declare prototypes.
1436
1437 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1438 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1439 and vector-like objects.
1440
1441 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1442 cache around display iteration.
1443
1444 * window.c (Fwindow_end, window_scroll_pixel_based)
1445 (displayed_window_lines, Frecenter): Save and restore the bidi
1446 cache around display iteration.
1447
1448 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1449
1450 * editfns.c (Fdelete_region): Clarify the use of the named
1451 parameters (bug#6788).
1452
1453 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1454
1455 * indent.c (Fvertical_motion): Set and restore w->pointm when
1456 saving and restoring the window's buffer (Bug#9006).
1457
1458 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1459
1460 * editfns.c (Fstring_to_char): Clarify just what is returned
1461 (bug#6576). Text by Eli Zaretskii.
1462
1463 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1464
1465 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1466
1467 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1468
1469 * buffer.c (mmap_find): Fix a typo.
1470
1471 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1472
1473 Fix execution of x selection hooks.
1474 * xselect.c (Qx_lost_selection_functions)
1475 (Qx_sent_selection_functions): New vars.
1476 (syms_of_xselect): DEFSYM them.
1477 (x_handle_selection_request): Pass Qx_sent_selection_functions
1478 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1479 (x_handle_selection_clear,x_clear_frame_selections):
1480 Pass Qx_lost_selection_functions rather than
1481 Vx_lost_selection_functions to Frun_hook_with_args.
1482
1483 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1486 The old code sometimes used this field without initializing it.
1487
1488 * alloc.c (gc_sweep): Don't read past end of array.
1489 In theory, the old code could also have corrupted Emacs internals,
1490 though it'd be very unlikely.
1491
1492 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1493
1494 * character.c (Fcharacterp): Don't advertise optional ignored
1495 argument. (Bug#4026)
1496
1497 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1498
1499 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1500 key" (bug#4257).
1501
1502 * window.c (Fset_window_start): Doc fix (bug#4199).
1503 (Fset_window_hscroll): Ditto.
1504
1505 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1506
1507 Fix minor new problems caught by GCC 4.6.1.
1508 * term.c (init_tty): Remove unused local.
1509 * xsettings.c (store_monospaced_changed): Define this function only
1510 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1511 not used otherwise.
1512
1513 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1514
1515 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1516
1517 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1518
1519 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1520 are the mini-buffer and the echo area (bug#3320).
1521
1522 * term.c (init_tty): Remove support for supdup, c10 and perq
1523 terminals, which are no longer supported (bug#1482).
1524
1525 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1526
1527 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1528
1529 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1530
1531 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1532 for non-popups (Bug#3642).
1533
1534 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1535
1536 * alloc.c (reset_malloc_hooks): Protoize.
1537 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1538 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1539 * cm.c (losecursor): Likewise.
1540 * data.c (fmod): Likewise.
1541 * dispnew.c (swap_glyphs_in_rows): Likewise.
1542 * emacs.c (memory_warning_signal): Likewise.
1543 * floatfns.c (float_error): Likewise.
1544 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1545 (otf_open, font_otf_capability, generate_otf_features)
1546 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1547 Likewise.
1548 * image.c (pbm_read_file): Likewise.
1549 * indent.c (string_display_width): Likewise.
1550 * intervals.c (check_for_interval, search_for_interval)
1551 (inc_interval_count, count_intervals, root_interval)
1552 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1553 * lread.c (defalias): Likewise.
1554 * ralloc.c (r_alloc_check): Likewise.
1555 * regex.c (set_image_of_range_1, set_image_of_range)
1556 (regex_grow_registers): Likewise.
1557 * sysdep.c (strerror): Likewise.
1558 * termcap.c (valid_filename_p, tprint, main): Likewise.
1559 * tparam.c (main): Likewise.
1560 * unexhp9k800.c (run_time_remap, save_data_space)
1561 (update_file_ptrs, read_header, write_header, calculate_checksum)
1562 (copy_file, copy_rest, display_header): Likewise.
1563 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1564 Likewise.
1565 * xdisp.c (check_it): Likewise.
1566 * xfaces.c (register_color, unregister_color, unregister_colors):
1567 Likewise.
1568 * xfns.c (print_fontset_result): Likewise.
1569 * xrdb.c (member, fatal, main): Likewise.
1570
1571 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1572
1573 Fix minor problems found by static checking (Bug#9031).
1574 * chartab.c (char_table_set_range, map_sub_char_table):
1575 Remove unused locals.
1576 (uniprop_table): Now static.
1577 * composite.c (_work_char): Remove unused static var.
1578
1579 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1580
1581 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1582
1583 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1584
1585 * gtkutil.c (qttip_cb): Remove code without function.
1586
1587 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1588
1589 * w32.c (pthread_sigmask): New stub.
1590
1591 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1592
1593 Use pthread_sigmask, not sigprocmask (Bug#9010).
1594 sigprocmask is portable only for single-threaded applications, and
1595 Emacs can be multi-threaded when it uses GTK.
1596 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1597 (LIBES): Use it.
1598 * callproc.c (Fcall_process):
1599 * process.c (create_process):
1600 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1601 Use pthread_sigmask, not sigprocmask.
1602
1603 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1604
1605 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1606 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1607 wrong (Bug#8591).
1608
1609 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1610
1611 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1612 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1613 (xg_hide_tooltip): Fix comment.
1614
1615 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1616 in registerServicesMenuSendTypes.
1617 (validRequestorForSendType): Don't check ns_return_types.
1618
1619 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1620 ns_return_type.
1621
1622 2011-07-08 Jason Rumney <jasonr@gnu.org>
1623
1624 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1625 frame struct members of non-existent frames (Bug#6284).
1626
1627 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1628
1629 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1630 variable firstTime not needed on OSX >= 10.6.
1631 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1632 >= 10.5. Use setKnobProportion, setDoubleValue.
1633
1634 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1635 (MAC_OS_X_VERSION_10_5): Define if not defined.
1636 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1637 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1638 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1639
1640 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1641 cString and lossyCString on OSX >= 10.4
1642
1643 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1644 sizeToFit on OSX >= 10.2.
1645
1646 * nsimage.m (allocInitFromFile): Don't use deprecated method
1647 bestRepresentationForDevice on OSX >= 10.6.
1648
1649 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1650 to avoid warning.
1651
1652 * emacs.c: Declare unexec_init_emacs_zone.
1653
1654 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1655
1656 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1657
1658 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1659 on svcsMenu (Bug#8842).
1660
1661 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1662 ns_return_types.
1663 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1664
1665 * nsterm.m (QUTF8_STRING): Declare.
1666 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1667 (validRequestorForSendType): Return type is (id).
1668 Change indexOfObjectIdenticalTo to indexOfObject.
1669 Check if we have local selection before returning self (Bug#8842).
1670 (writeSelectionToPasteboard): Put local selection into paste board
1671 if we have a local selection (Bug#8842).
1672 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1673
1674 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1675 (ns_get_local_selection): Declare.
1676
1677 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1678
1679 * keymap.c (describe_map_tree): Don't insert a double newline at
1680 the end of the buffer (bug#1169) and return whether we inserted
1681 something.
1682
1683 * callint.c (Fcall_interactively): Change "reading args" to
1684 "providing args" to try to clarify what it does (bug#1010).
1685
1686 2011-07-07 Kenichi Handa <handa@m17n.org>
1687
1688 * composite.c (composition_compute_stop_pos): Ignore a static
1689 composition starting before CHARPOS (Bug#8915).
1690
1691 * xdisp.c (handle_composition_prop): Likewise.
1692
1693 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1694
1695 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1696 (Bug#9015)
1697
1698 2011-07-07 Kenichi Handa <handa@m17n.org>
1699
1700 * character.h (unicode_category_t): New enum type.
1701
1702 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1703 (Qchar_code_property_table): New variable.
1704 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1705 (UNIPROP_COMPRESSED_FORM_P): New macros.
1706 (char_table_ascii): Uncompress the compressed values.
1707 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1708 Uncompress the compressed values.
1709 (sub_char_table_ref_and_range): Likewise.
1710 (char_table_ref_and_range): Uncompress the compressed values.
1711 (sub_char_table_set): New arg is_uniprop. Callers changed.
1712 Uncompress the compressed values.
1713 (sub_char_table_set_range): Args changed. Callers changed.
1714 (char_table_set_range): Adjuted for the above change.
1715 (map_sub_char_table): Delete args default_val and parent. Add arg
1716 top. Give decoded values to a Lisp function.
1717 (map_char_table): Adjust for the above change. Give decoded
1718 values to a Lisp function. Gcpro more variables.
1719 (uniprop_table_uncompress)
1720 (uniprop_decode_value_run_length): New functions.
1721 (uniprop_decoder, uniprop_decoder_count): New variables.
1722 (uniprop_get_decoder, uniprop_encode_value_character)
1723 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1724 New functions.
1725 (uniprop_encoder, uniprop_encoder_count): New variables.
1726 (uniprop_get_encoder, uniprop_table)
1727 (Funicode_property_table_internal, Fget_unicode_property_internal)
1728 (Fput_unicode_property_internal): New functions.
1729 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1730 Sunicode_property_table_internal, Sget_unicode_property_internal,
1731 and Sput_unicode_property_internal. Defvar_lisp
1732 char-code-property-alist.
1733
1734 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1735 Vunicode_category_table.
1736
1737 * font.c (font_range): Adjust for the change of
1738 Vunicode_category_table.
1739
1740 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1741
1742 * m/iris4d.h: Remove file, move contents ...
1743 * s/irix6-5.h: ... here.
1744
1745 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1746
1747 Remove unportable assumption about struct layout (Bug#8884).
1748 * alloc.c (mark_buffer):
1749 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1750 (clone_per_buffer_values): Don't assume that
1751 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1752 This isn't true in general, and it's particularly not true
1753 if Emacs is configured with --with-wide-int.
1754 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1755 New macros, used in the buffer.c change.
1756
1757 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1758
1759 * xsettings.c: Use both GConf and GSettings if both are available.
1760 (store_config_changed_event): Add comment.
1761 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1762 (store_tool_bar_style_changed): New functions.
1763 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1764 (struct xsettings): Move font inside HAVE_XFT.
1765 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1766 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1767 Move inside HAVE_XFT.
1768 (something_changed_gsettingsCB): Rename from something_changedCB.
1769 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1770 also.
1771 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1772 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1773 (something_changed_gconfCB): Rename from something_changedCB.
1774 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1775 (parse_settings): Move check for font inside HAVE_XFT.
1776 (read_settings, apply_xft_settings): Add comment.
1777 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1778 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1779 call store_font_name_changed.
1780 (xft_settings_event): Add comment.
1781 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1782 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1783 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1784 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1785 (xsettings_initialize): Call init_gsettings last.
1786 (xsettings_get_system_font, xsettings_get_system_normal_font):
1787 Add comment.
1788
1789 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 Random fixes. E.g., (random) never returned negative values.
1792 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1793 subseconds part to the entropy, as that's a bit more random.
1794 Prefer signed to unsigned, since the signedness doesn't matter and
1795 in general we prefer signed. When given a limit, use a
1796 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1797 latter isn't right if USE_2_TAGS_FOR_INTS.
1798 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1799 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1800
1801 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1802
1803 * textprop.c (text_property_stickiness):
1804 Obey Vtext_property_default_nonsticky.
1805 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1806 * w32fns.c (syms_of_w32fns):
1807 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1808
1809 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1812 This is more efficient than Ffile_directory_p and avoids a minor race.
1813
1814 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1815
1816 * buffer.c (Foverlay_put): Say what the return value is
1817 (bug#7835).
1818
1819 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1820 is a directory before asking whether to use the file name
1821 (bug#7564).
1822 (barf_or_query_if_file_exists): Make the "File is a directory"
1823 error be more correct.
1824
1825 * fns.c (Frequire): Remove the mention of the .gz files, since
1826 that's installation-specific, but keep the mention of
1827 `get-load-suffixes'.
1828
1829 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1830
1831 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1832 Report string overflow if the output is too long.
1833
1834 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1835
1836 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1837 (syms_of_gnutls): Remove duplicate DEFSYM for
1838 Qgnutls_bootprop_verify_hostname_error, an error for
1839 Qgnutls_bootprop_verify_error (which is no longer used).
1840
1841 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1842 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1843 Also (re)move comments that are misplaced or no longer relevant.
1844
1845 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1846
1847 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1848
1849 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1850
1851 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1852 and background color parameters if they have been changed.
1853
1854 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1855
1856 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1857
1858 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1859
1860 * xsettings.c (SYSTEM_FONT): Define only when used.
1861 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1862
1863 * keymap.c (access_keymap_1): Now static.
1864
1865 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1866
1867 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1868 leave any prefix arg for the up event (Bug#1586).
1869
1870 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1871
1872 * lread.c (syms_of_lread): Mention single symbols defined by
1873 `defvar' or `defconst' (bug#7154).
1874
1875 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1876 (Frequire): Mention get-load-suffixes.
1877
1878 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1879
1880 * window.h (window): Remove clone_number slot.
1881 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1882 Remove.
1883 (make_parent_window, make_window, saved_window)
1884 (Fset_window_configuration, save_window_save): Don't deal with
1885 clone numbers.
1886 * buffer.c (Qclone_number): Remove declaration.
1887 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1888
1889 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1890
1891 Add multiple inheritance to keymaps.
1892 * keymap.c (Fmake_composed_keymap): New function.
1893 (Fset_keymap_parent): Simplify.
1894 (fix_submap_inheritance): Remove.
1895 (access_keymap_1): New function extracted from access_keymap to handle
1896 embedded parents and handle lists of maps.
1897 (access_keymap): Use it.
1898 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1899 (Fcopy_keymap): Handle embedded parents.
1900 (Fcommand_remapping, define_as_prefix): Simplify.
1901 (Fkey_binding): Simplify.
1902 (syms_of_keymap): Move minibuffer-local-completion-map,
1903 minibuffer-local-filename-completion-map,
1904 minibuffer-local-must-match-map, and
1905 minibuffer-local-filename-must-match-map to Elisp.
1906 (syms_of_keymap): Defsubr make-composed-keymap.
1907 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1908 (parse_menu_item): Trivial simplification.
1909
1910 2011-07-01 Glenn Morris <rgm@gnu.org>
1911
1912 * Makefile.in (SETTINGS_LIBS): Fix typo.
1913
1914 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1915
1916 * coding.c (Fencode_coding_string): Record the last coding system
1917 used, as the function doc string says (bug#8738).
1918
1919 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1920
1921 * xsettings.c (store_monospaced_changed): Take new font as arg and
1922 check for change against current_mono_font.
1923 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1924 (emacs_settings_constructor, emacs_settings_get_property)
1925 (emacs_settings_set_property, emacs_settings_class_init)
1926 (emacs_settings_init, gsettings_obj): Remove.
1927 (something_changedCB): New function for HAVE_GSETTINGS.
1928 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1929 with value as argument.
1930 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1931 g_settings_new (Bug#8967). Do not create gsettings_obj.
1932 Remove calls to g_settings_bind. Connect something_changedCB to
1933 "changed".
1934
1935 * xgselect.c: Add defined (HAVE_GSETTINGS).
1936 (xgselect_initialize): Ditto.
1937
1938 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1939 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1940 xg_select.
1941
1942 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 * eval.c (struct backtrace): Simplify and port the data structure.
1945 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1946 signed bit field, as this assumption is not portable and it makes
1947 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1948 "char debug_on_exit : 1" as this is not portable either; instead,
1949 use the portable "unsigned int debug_on_exit : 1". Remove unused
1950 member evalargs. Remove obsolete comments about cc bombing out.
1951
1952 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1953
1954 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1955 Let HAVE_GSETTINGS override HAVE_GCONF.
1956 (store_monospaced_changed): New function.
1957 (EMACS_SETTINGS): A new type derived from GObject to handle
1958 GSettings notifications.
1959 (emacs_settings_constructor, emacs_settings_get_property)
1960 (emacs_settings_set_property, emacs_settings_class_init):
1961 New functions.
1962 (gsettings_client, gsettings_obj): New variables.
1963 (GSETTINGS_SCHEMA): New define.
1964 (something_changedCB): Call store_monospaced_changed.
1965 (init_gsettings): New function.
1966 (xsettings_initialize): Call init_gsettings.
1967 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1968 to NULL.
1969
1970 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1971 GCONF_CFLAGS/LIBS.
1972
1973 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1974
1975 * window.c (resize_root_window, grow_mini_window)
1976 (shrink_mini_window): Rename Qresize_root_window to
1977 Qwindow_resize_root_window and Qresize_root_window_vertically to
1978 Qwindow_resize_root_window_vertically.
1979
1980 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1981
1982 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1983
1984 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1985
1986 * makefile.w32-in: Redesign dependencies so they reflect more
1987 clearly which files are directly included by each source file,
1988 and not through other includes.
1989
1990 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1991
1992 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1993 (sort_overlays, overlay_strings): When an overlay's clone number
1994 matches the window's clone number process the overlay even if
1995 the overlay's window property doesn't match the current window.
1996
1997 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1998 (Fwindow_hchild): Rename to Fwindow_left_child.
1999 (Fwindow_next): Rename to Fwindow_next_sibling.
2000 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2001 (resize_window_check): Rename to window_resize_check.
2002 (resize_window_apply): Rename to window_resize_apply.
2003 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2004 (Fdelete_other_windows_internal, resize_frame_windows)
2005 (Fsplit_window_internal, Fdelete_window_internal)
2006 (grow_mini_window, shrink_mini_window)
2007 (Fresize_mini_window_internal): Fix callers accordingly.
2008
2009 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2010
2011 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2012 (emacs_fixed_set_min_size): Remove.
2013 (emacs_fixed_new): Take frame as argument.
2014
2015 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2016 (_EmacsFixedPrivate): Remove minwidth/height.
2017 Add struct frame *f.
2018 (emacs_fixed_init): Initialize priv->f.
2019 (get_parent_class, emacs_fixed_set_min_size): Remove.
2020 (emacs_fixed_new): Set priv->f to argument.
2021 (emacs_fixed_get_preferred_width)
2022 (emacs_fixed_get_preferred_height): Use min_width/height from
2023 frames size_hint to set minimum and natural (Bug#8919).
2024 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2025 and use min_width/height from frames size_hint to set
2026 min_width/height (Bug#8919).
2027
2028 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2029 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2030 Fix indentation.
2031
2032 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2033
2034 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2035 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2036 called at ZV.
2037
2038 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2039
2040 * process.c (wait_reading_process_output): Bypass select if
2041 waiting for a cell while ignoring keyboard input, and input is
2042 pending. Suggested by Jan Djärv (Bug#8869).
2043
2044 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 Use gnulib's dup2 module instead of rolling our own.
2047 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2048
2049 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2050
2051 * dispnew.c (scrolling_window): Before scrolling, turn off a
2052 mouse-highlight in the window being scrolled.
2053
2054 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2055
2056 Move DEFSYM to lisp.h and use everywhere.
2057
2058 * character.h (DEFSYM): Move declaration...
2059 * lisp.h (DEFSYM): ...here.
2060
2061 * gnutls.c:
2062 * minibuf.c:
2063 * w32menu.c:
2064 * w32proc.c:
2065 * w32select.c: Don't include character.h.
2066
2067 * alloc.c (syms_of_alloc):
2068 * buffer.c (syms_of_buffer):
2069 * bytecode.c (syms_of_bytecode):
2070 * callint.c (syms_of_callint):
2071 * casefiddle.c (syms_of_casefiddle):
2072 * casetab.c (init_casetab_once):
2073 * category.c (init_category_once, syms_of_category):
2074 * ccl.c (syms_of_ccl):
2075 * cmds.c (syms_of_cmds):
2076 * composite.c (syms_of_composite):
2077 * dbusbind.c (syms_of_dbusbind):
2078 * dired.c (syms_of_dired):
2079 * dispnew.c (syms_of_display):
2080 * doc.c (syms_of_doc):
2081 * editfns.c (syms_of_editfns):
2082 * emacs.c (syms_of_emacs):
2083 * eval.c (syms_of_eval):
2084 * fileio.c (syms_of_fileio):
2085 * fns.c (syms_of_fns):
2086 * frame.c (syms_of_frame):
2087 * fringe.c (syms_of_fringe):
2088 * insdel.c (syms_of_insdel):
2089 * keymap.c (syms_of_keymap):
2090 * lread.c (init_obarray, syms_of_lread):
2091 * macros.c (syms_of_macros):
2092 * msdos.c (syms_of_msdos):
2093 * print.c (syms_of_print):
2094 * process.c (syms_of_process):
2095 * search.c (syms_of_search):
2096 * sound.c (syms_of_sound):
2097 * syntax.c (init_syntax_once, syms_of_syntax):
2098 * terminal.c (syms_of_terminal):
2099 * textprop.c (syms_of_textprop):
2100 * undo.c (syms_of_undo):
2101 * w32.c (globals_of_w32):
2102 * window.c (syms_of_window):
2103 * xdisp.c (syms_of_xdisp):
2104 * xfaces.c (syms_of_xfaces):
2105 * xfns.c (syms_of_xfns):
2106 * xmenu.c (syms_of_xmenu):
2107 * xsettings.c (syms_of_xsettings):
2108 * xterm.c (syms_of_xterm): Use DEFSYM.
2109
2110 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2111
2112 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2113
2114 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 Integer and buffer overflow fixes (Bug#8873).
2117
2118 * print.c (printchar, strout): Check for string overflow.
2119 (PRINTPREPARE, printchar, strout):
2120 Don't set size unless allocation succeeds.
2121
2122 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2123 for sizes. Check for string overflow more accurately.
2124 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2125
2126 * macros.c: Integer and buffer overflow fixes.
2127 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2128 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2129 Use ptrdiff_t, not int, for sizes.
2130 Don't increment bufsize until after realloc succeeds.
2131 Check for size-calculation overflow.
2132 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2133
2134 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2135
2136 * lread.c: Integer overflow fixes.
2137 (read_integer): Radix is now EMACS_INT, not int,
2138 to improve quality of diagnostics for out-of-range radices.
2139 Calculate buffer size correctly for out-of-range radices.
2140 (read1): Check for integer overflow in radices, and in
2141 read-circle numbers.
2142 (read_escape): Avoid int overflow.
2143 (Fload, openp, read_buffer_size, read1)
2144 (substitute_object_recurse, read_vector, read_list, map_obarray):
2145 Use ptrdiff_t, not int, for sizes.
2146 (read1): Use EMACS_INT, not int, for sizes.
2147 Check for size overflow.
2148
2149 * image.c (cache_image): Check for size arithmetic overflow.
2150
2151 * lread.c: Integer overflow issues.
2152 (saved_doc_string_size, saved_doc_string_length)
2153 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2154 Now ptrdiff_t, not int.
2155 (read1): Don't assume doc string length fits in int. Check for
2156 out-of-range doc string lengths.
2157 (read_list): Don't assume file position fits in int.
2158 (read_escape): Check for hex character overflow.
2159
2160 2011-06-22 Leo Liu <sdl.web@gmail.com>
2161
2162 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2163 Move to minibuffer.el.
2164
2165 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2166
2167 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2168 The following patches are for when GLYPH_DEBUG && !XASSERT.
2169 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2170 * dispnew.c (flush_stdout):
2171 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2172 Mark as externally visible.
2173 * dispnew.c (check_window_matrix_pointers): Now static.
2174 * dispnew.c (window_to_frame_vpos):
2175 * xfns.c (unwind_create_frame):
2176 * xterm.c (x_check_font): Remove unused local.
2177 * scroll.c (CHECK_BOUNDS):
2178 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2179 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2180 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2181 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2182 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2183 Now static.
2184 (debug_method_add): Use va_list and vsprintf rather than relying
2185 on undefined behavior with wrong number of arguments.
2186 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2187 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2188 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2189 since we're not interested in debugging glyphs with old libraries.
2190 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2191 GCC 4.6.0's static checking.
2192
2193 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 Integer overflow and signedness fixes (Bug#8873).
2196 A few related buffer overrun fixes, too.
2197
2198 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2199
2200 * dispextern.h (struct face.stipple):
2201 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2202 (x_bitmap_mask, x_allocate_bitmap_record)
2203 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2204 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2205 (x_create_bitmap_from_xpm_data):
2206 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2207 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2208 (.bitmaps_last):
2209 * xfaces.c (load_pixmap):
2210 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2211 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2212 (.bitmaps_last, struct x_output.icon_bitmap):
2213 Use ptrdiff_t, not int, for bitmap indexes.
2214 (x_allocate_bitmap_record): Check for size overflow.
2215 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2216
2217 Use ptrdiff_t, not int, for overlay counts.
2218 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2219 * editfns.c (overlays_around, get_pos_property):
2220 * textprop.c (get_char_property_and_overlay):
2221 * xdisp.c (next_overlay_change, note_mouse_highlight):
2222 * xfaces.c (face_at_buffer_position):
2223 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2224 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2225 (Fnext_overlay_change, Fprevious_overlay_change)
2226 (mouse_face_overlay_overlaps, Foverlays_in):
2227 Use ptrdiff_t, not int, for sizes.
2228 (overlays_at, overlays_in): Check for size-calculation overflow.
2229
2230 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2231
2232 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2233 (x_session_initialize): Do not assume string length fits in int.
2234
2235 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2236 This is unlikely, but can occur if DPI is outlandish.
2237
2238 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2239 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2240
2241 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2242 * xrdb.c (magic_file_p, search_magic_path):
2243 Omit last arg SUFFIX; it was always 0. All callers changed.
2244 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2245
2246 * xfont.c (xfont_match): Avoid need for strlen.
2247
2248 * xfns.c: Don't assume strlen fits in int.
2249 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2250
2251 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2252 not unsigned long, as we prefer signed integers. All callers changed.
2253 Detect integer overflow in repeat count.
2254 (message_dolog): Don't assume print length fits in 39 bytes.
2255 (display_mode_element): Don't assume strlen fits in int.
2256
2257 * termcap.c: Don't assume sizes fit in int and never overflow.
2258 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2259 (gobble_line): Check for size-calculation overflow.
2260
2261 * minibuf.c (Fread_buffer):
2262 * lread.c (intern, intern_c_string):
2263 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2264 Don't assume string length fits in int.
2265
2266 * keyboard.c (parse_tool_bar_item):
2267 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2268
2269 * font.c: Don't assume string length fits in int.
2270 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2271 Use ptrdiff_t, not int.
2272 (font_intern_prop): Don't assume string length fits in int.
2273 Don't assume integer property fits in fixnum.
2274 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2275
2276 * filelock.c: Fix some buffer overrun and integer overflow issues.
2277 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2278 Reformulate so as not to need the command string.
2279 Invoke gzip -cd rather than gunzip, as it's more portable.
2280 (lock_info_type, lock_file_1, lock_file):
2281 Don't assume pid_t and time_t fit in unsigned long.
2282 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2283 (current_lock_owner): Prefer signed type for sizes.
2284 Use memcpy, not strncpy, where memcpy is what is really wanted.
2285 Don't assume (via atoi) that time_t and pid_t fit in int.
2286 Check for time_t and/or pid_t out of range, e.g., via a network share.
2287 Don't alloca where an auto var works fine.
2288
2289 * fileio.c: Fix some integer overflow issues.
2290 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2291 Don't assume string length fits in int.
2292 (directory_file_name): Don't assume string length fits in long.
2293 (make_temp_name): Don't assume pid fits in int, or that its print
2294 length is less than 20.
2295
2296 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2297
2298 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2299
2300 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2301
2302 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2303 We prefer signed integers, even for size calculations.
2304
2305 * emacs.c: Don't assume string length fits in 'int'.
2306 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2307 (main): Don't invoke strlen when not needed.
2308
2309 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2310 (XD_DEBUG_MESSAGE): Don't waste a byte.
2311
2312 * callproc.c (getenv_internal_1, getenv_internal)
2313 (Fgetenv_internal):
2314 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2315
2316 * lread.c (invalid_syntax): Omit length argument.
2317 All uses changed. This doesn't fix a bug, but it simplifies the
2318 code away from its former Hollerith-constant appearance, and it's
2319 one less 'int' to worry about when looking at integer-overflow issues.
2320 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2321
2322 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2323 This didn't break anything, but it didn't help either.
2324 It's confusing to put a bogus integer in a place where the actual
2325 value does not matter.
2326 (LIST_END_P): Remove unused macro and its bogus comment.
2327 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2328
2329 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2330 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2331 implementation.
2332 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2333 We prefer signed types, and the value cannot exceed the EMACS_INT
2334 range anyway (because otherwise the length would not be representable).
2335 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2336 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2337 This avoids a GCC warning when WIDE_EMACS_INT.
2338
2339 * indent.c (sane_tab_width): New function.
2340 (current_column, scan_for_column, Findent_to, position_indentation)
2341 (compute_motion): Use it. This is just for clarity.
2342 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2343
2344 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2345
2346 * lisp.h (lint_assume): New macro.
2347 * composite.c (composition_gstring_put_cache):
2348 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2349
2350 * editfns.c, insdel.c:
2351 Omit unnecessary forward decls, to simplify future changes.
2352
2353 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2354
2355 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2356
2357 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2358 Use much-faster test for byte-length change.
2359 Don't assume string byte-length fits in 'int'.
2360 Check that character arg fits in 'int'.
2361 (mapcar1): Declare byte as byte, for clarity.
2362
2363 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2364
2365 * fns.c (concat): Catch string overflow earlier.
2366 Do not rely on integer wraparound.
2367
2368 * dispextern.h (struct it.overlay_strings_charpos)
2369 (struct it.selective): Now EMACS_INT, not int.
2370 * xdisp.c (forward_to_next_line_start)
2371 (back_to_previous_visible_line_start)
2372 (reseat_at_next_visible_line_start, next_element_from_buffer):
2373 Don't arbitrarily truncate the value of 'selective' to int.
2374
2375 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2376
2377 * composite.c: Don't truncate sizes to 'int'.
2378 (composition_gstring_p, composition_reseat_it)
2379 (composition_adjust_point): Use EMACS_INT, not int.
2380 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2381 not EMACS_UINT, for indexes.
2382
2383 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2384
2385 * buffer.c: Include <verify.h>.
2386 (struct sortvec.priority, struct sortstr.priority):
2387 Now EMACS_INT, not int.
2388 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2389 (struct sortstr.size, record_overlay_string)
2390 (struct sortstrlist.size, struct sortlist.used):
2391 Don't truncate size to int.
2392 (record_overlay_string): Check for size-calculation overflow.
2393 (init_buffer_once): Check at compile-time, not run-time.
2394
2395 2011-06-22 Jim Meyering <meyering@redhat.com>
2396
2397 Don't leak an XBM-image-sized buffer
2398 * image.c (xbm_load): Free the image buffer after using it.
2399
2400 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 Port to Sun C.
2403 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2404 that Sun C diagnosed.
2405 * fns.c (secure_hash): Fix pointer signedness issue.
2406 * intervals.c (static_offset_intervals): New function.
2407 (offset_intervals): Use it.
2408
2409 2011-06-21 Leo Liu <sdl.web@gmail.com>
2410
2411 * deps.mk (fns.o):
2412 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2413 sha512.h.
2414
2415 * fns.c (secure_hash): Rename from crypto_hash_function and change
2416 the first arg to accept symbols.
2417 (Fsecure_hash): New primitive.
2418 (syms_of_fns): New symbols.
2419
2420 2011-06-20 Deniz Dogan <deniz@dogan.se>
2421
2422 * process.c (Fset_process_buffer): Clarify return value in
2423 docstring.
2424
2425 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2426
2427 * dispnew.c (add_window_display_history): Use BVAR.
2428
2429 * xdisp.c (debug_method_add): Use BVAR.
2430 (check_window_end, dump_glyph_matrix, dump_glyph)
2431 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2432
2433 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2434 Likewise.
2435
2436 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2437 check till after the cache is created in init_frame_faces.
2438
2439 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2440
2441 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2442
2443 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2446 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2447 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2448
2449 Improve buffer-overflow checking (Bug#8873).
2450 * fileio.c (Finsert_file_contents):
2451 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2452 Remove the old (too-loose) buffer overflow checks.
2453 They weren't needed, since make_gap checks for buffer overflow.
2454 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2455 The old code merely checked for Emacs fixnum overflow, and relied
2456 on undefined (wraparound) behavior. The new code avoids undefined
2457 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2458
2459 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2460 Tune. Don't use wider integers than needed. Don't use alloca.
2461 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2462
2463 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2464
2465 * insdel.c, lisp.h (buffer_overflow): New function.
2466 (insert_from_buffer_1, replace_range, replace_range_2):
2467 * insdel.c (make_gap_larger):
2468 * editfns.c (Finsert_char):
2469 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2470
2471 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2472
2473 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 Integer overflow and signedness fixes (Bug#8873).
2476
2477 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2478 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2479
2480 * fileio.c: Don't assume EMACS_INT fits in off_t.
2481 (emacs_lseek): New static function.
2482 (Finsert_file_contents, Fwrite_region): Use it.
2483 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2484
2485 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2486
2487 * fns.c: Don't overflow int when computing a list length.
2488 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2489 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2490 truncation on 64-bit hosts. Check for QUIT every
2491 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2492 faster and is responsive enough.
2493 (Flength): Report an error instead of overflowing an integer.
2494 (Fsafe_length): Return a float if the value is not representable
2495 as a fixnum. This shouldn't happen except in contrived situations.
2496 (Fnthcdr, Fsort): Don't assume list length fits in int.
2497 (Fcopy_sequence): Don't assume vector length fits in int.
2498
2499 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2500 (header_size, word_size): New constants.
2501 (allocate_vectorlike): Don't check size overflow here.
2502 (allocate_vector): Check it here instead, since this is the only
2503 caller of allocate_vectorlike that could cause overflow.
2504 Check that the new vector's length is representable as a fixnum.
2505
2506 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2507 The previous code was bogus. For example, next_almost_prime (32)
2508 returned 39, which is undesirable as it is a multiple of 3; and
2509 next_almost_prime (24) returned 25, which is a multiple of 5 so
2510 why was the code bothering to check for multiples of 7?
2511
2512 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2513
2514 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2515
2516 Variadic C functions now count arguments with ptrdiff_t.
2517 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2518 Back then I didn't know that the Emacs coding style prefers signed int.
2519 Also, in the meantime I found a few more instances where arguments
2520 were being counted with int, which may truncate counts on 64-bit
2521 machines, or EMACS_INT, which may be unnecessarily wide.
2522 * lisp.h (struct Lisp_Subr.function.aMANY)
2523 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2524 Arg counts are now ptrdiff_t, not size_t.
2525 All variadic functions and their callers changed accordingly.
2526 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2527 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2528 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2529 * callint.c (Fcall_interactively): Check arg count for overflow,
2530 to avoid potential buffer overrun. Use signed char, not 'int',
2531 for 'varies' array, so that we needn't bother to check its size
2532 calculation for overflow.
2533 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2534 * eval.c (apply_lambda):
2535 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2536 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2537 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2538
2539 * callint.c (Fcall_interactively): Don't use index var as event count.
2540
2541 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2542 * mem-limits.h (SIZE): Remove; no longer used.
2543
2544 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2545
2546 Remove unnecessary casts.
2547 * xterm.c (x_term_init):
2548 * xfns.c (x_set_border_pixel):
2549 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2550 These aren't needed now that we assume ANSI C.
2551
2552 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2553 It's more likely to cause problems (due to unsigned overflow)
2554 than to cure them.
2555
2556 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2557
2558 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2559
2560 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2561
2562 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2563
2564 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2565
2566 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2567
2568 GLYPH_CODE_FACE returns EMACS_INT, not int.
2569 * dispextern.h (merge_faces):
2570 * xfaces.c (merge_faces):
2571 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2572 Don't assume EMACS_INT fits in int.
2573
2574 * character.h (CHAR_VALID_P): Remove unused parameter.
2575 * fontset.c, lisp.h, xdisp.c: All uses changed.
2576
2577 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2578
2579 * fns.c (concat): Minor tuning based on overflow analysis.
2580 This doesn't fix any bugs. Use int to hold character, instead
2581 of constantly refetching from Emacs object. Use XFASTINT, not
2582 XINT, for value known to be a character. Don't bother comparing
2583 a single byte to 0400, as it's always less.
2584
2585 * floatfns.c (Fexpt):
2586 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2587
2588 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2589 for characters.
2590
2591 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2592
2593 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2594 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2595 incorrectly succeed when S was a string, because 4294967386 was
2596 truncated before it was used.
2597
2598 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2599 Otherwise, an out-of-range integer could cause undefined behavior
2600 on a 64-bit host.
2601
2602 * composite.c: Use int, not EMACS_INT, for characters.
2603 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2604 EMACS_INT, for values that are known to be in character range.
2605 This doesn't fix any bugs but is the usual style inside Emacs and
2606 may generate better code on 32-bit machines.
2607
2608 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2609 This is for reasons similar to the recent CHAR_STRING fix.
2610 * charset.c (Fencode_char): Check that character arg is actually
2611 a character. Pass an int to ENCODE_CHAR.
2612 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2613 wider than 'int', as a compile-time check to prevent future regressions
2614 in this area.
2615
2616 * character.c (char_string): Remove unnecessary casts.
2617
2618 Make sure a 64-bit char is never passed to CHAR_STRING.
2619 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2620 by silently ignoring the top 32 bits, allowing some values
2621 that were far too large to be valid characters.
2622 * character.h: Include <verify.h>.
2623 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2624 arguments are no wider than unsigned, as a compile-time check
2625 to prevent future regressions in this area.
2626 * data.c (Faset):
2627 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2628 (Fsubst_char_in_region):
2629 * fns.c (concat):
2630 * xdisp.c (decode_mode_spec_coding):
2631 Adjust to CHAR_STRING's new requirement.
2632 * editfns.c (Finsert_char, Fsubst_char_in_region):
2633 * fns.c (concat): Check that character args are actually
2634 characters. Without this test, these functions did the wrong
2635 thing with wildly out-of-range values on 64-bit hosts.
2636
2637 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2638 These casts should not be needed on 32-bit hosts, either.
2639 * keyboard.c (read_char):
2640 * lread.c (Fload): Remove casts to unsigned.
2641
2642 * lisp.h (UNSIGNED_CMP): New macro.
2643 This fixes comparison bugs on 64-bit hosts.
2644 (ASCII_CHAR_P): Use it.
2645 * casefiddle.c (casify_object):
2646 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2647 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2648 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2649 * dispextern.h (FACE_FROM_ID):
2650 * keyboard.c (read_char): Use UNSIGNED_CMP.
2651
2652 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2653 not to EMACS_INT, to avoid GCC warning.
2654
2655 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2656
2657 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2658 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2659 isn't needed on 32-bit machines.
2660
2661 * buffer.c (Fgenerate_new_buffer_name):
2662 Use EMACS_INT for count, not int.
2663 (advance_to_char_boundary): Return EMACS_INT, not int.
2664
2665 * data.c (Qcompiled_function): Now static.
2666
2667 * window.c (window_body_lines): Now static.
2668
2669 * image.c (gif_load): Rename local to avoid shadowing.
2670
2671 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2672 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2673 * alloc.c (make_save_value): Integer argument is now of type
2674 ptrdiff_t, not int.
2675 (mark_object): Use ptrdiff_t, not int.
2676 * lisp.h (pD): New macro.
2677 * print.c (print_object): Use it.
2678
2679 * alloc.c: Use EMACS_INT, not int, to count objects.
2680 (total_conses, total_markers, total_symbols, total_vector_size)
2681 (total_free_conses, total_free_markers, total_free_symbols)
2682 (total_free_floats, total_floats, total_free_intervals)
2683 (total_intervals, total_strings, total_free_strings):
2684 Now EMACS_INT, not int. All uses changed.
2685 (Fgarbage_collect): Compute overall total using a double, so that
2686 integer overflow is less likely to be a problem. Check for overflow
2687 when converting back to an integer.
2688 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2689 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2690 These were 'int' variables that could overflow on 64-bit hosts;
2691 they were never used, so remove them instead of repairing them.
2692 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2693 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2694 Previously, this ceilinged at INT_MAX, but that doesn't work on
2695 64-bit machines.
2696 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2697
2698 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2699 (allocate_vectorlike): Check for ptrdiff_t overflow.
2700 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2701 when a (possibly-narrower) signed value would do just as well.
2702 We prefer using signed arithmetic, to avoid comparison confusion.
2703
2704 * alloc.c: Catch some string size overflows that we were missing.
2705 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2706 for convenience in STRING_BYTES_MAX.
2707 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2708 The definition here is exact; the one in lisp.h was approximate.
2709 (allocate_string_data): Check for string overflow. This catches
2710 some instances we weren't catching before. Also, it catches
2711 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2712 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2713 and ptrdiff_t and EMACS_INT are both 64 bits.
2714
2715 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2716 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2717 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2718
2719 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2720
2721 * alloc.c (Fmake_string): Check for out-of-range init.
2722
2723 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2724
2725 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2726
2727 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2728
2729 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2730 xg_get_default_scrollbar_width.
2731
2732 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2733 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2734 (style_changed_cb): Call update_theme_scrollbar_width and call
2735 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2736 all frames (Bug#8505).
2737 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2738 Call gtk_window_set_resizable if HAVE_GTK3.
2739 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2740 and height if HAVE_GTK3 (Bug#8505).
2741 (scroll_bar_width_for_theme): New variable.
2742 (update_theme_scrollbar_width): New function.
2743 (xg_get_default_scrollbar_width): Move code to
2744 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2745 (xg_initialize): Call update_theme_scrollbar_width.
2746
2747 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2748
2749 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2750
2751 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2752
2753 * frame.c (make_frame): Call other_buffer_safely instead of
2754 other_buffer.
2755
2756 * window.c (temp_output_buffer_show): Call display_buffer with
2757 second argument Vtemp_buffer_show_specifiers and reset latter
2758 immediately after the call.
2759 (Vtemp_buffer_show_specifiers): New variable.
2760 (auto_window_vscroll_p, next_screen_context_lines)
2761 (Vscroll_preserve_screen_position): Remove leading asterisks from
2762 doc-strings.
2763
2764 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2765
2766 Fix minor problems found by GCC 4.6.0 static checking.
2767 * buffer.c (Qclone_number): Remove for now, as it's unused.
2768 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2769 (record_buffer): Remove unused local.
2770 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2771 (set_frame_buffer_list): Remove; unused.
2772 * frame.h (other_visible_frames): Remove decl.
2773 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2774 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2775 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2776 if HAVE_GPM.
2777 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2778 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2779 Define only if HAVE_GPM.
2780 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2781 (update_hints_inhibit): Remove; never set. All uses removed.
2782 * widgetprv.h (emacsFrameClassRec): Remove decl.
2783 * window.c (delete_deletable_window): Now returns void, since it
2784 wasn't returning anything.
2785 (compare_window_configurations): Remove unused locals.
2786 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2787 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2788 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2789 the same widths as pointers. This follows up on the 2011-05-06 patch.
2790 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2791 * xterm.h: Likewise.
2792 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2793
2794 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2795
2796 * makefile.w32-in: Update dependencies.
2797 (LISP_H): Add lib/intprops.h.
2798
2799 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2800
2801 * image.c (gif_load): Add animation frame delay to the metadata.
2802 (syms_of_image): Use DEFSYM. New symbol `delay'.
2803
2804 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2805
2806 * window.c (delete_deletable_window): Re-add.
2807 (Fset_window_configuration): Rewrite to handle dead buffers and
2808 consequently deletable windows.
2809 (window_tree, Fwindow_tree): Remove. Supply functionality in
2810 window.el.
2811 (compare_window_configurations): Simplify code.
2812
2813 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2814
2815 * image.c (imagemagick_load_image): Fix type mismatch.
2816 (Fimagemagick_types): Likewise.
2817
2818 * window.h (replace_buffer_in_windows): Declare.
2819
2820 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2821
2822 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2823 Qclone_number. Remove external declaration of Qdelete_window.
2824 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2825 code.
2826 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2827 Run Qbuffer_list_update_hook if allowed.
2828 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2829 buffer list implementation.
2830 (other_buffer_safely): New function.
2831 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2832 calls to replace_buffer_in_windows and
2833 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2834 if allowed.
2835 (record_buffer): Inhibit quitting and rewrite using quittable
2836 functions. Run Qbuffer_list_update_hook if allowed.
2837 (Frecord_buffer, Funrecord_buffer): New functions.
2838 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2839 Move switch-to-buffer to window.el.
2840 (bury-buffer): Move to window.el.
2841 (Vbuffer_list_update_hook): New variable.
2842
2843 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2844 section.
2845
2846 * window.h (resize_frame_windows): Move up in code.
2847 (Fwindow_frame): Remove EXFUN.
2848 (replace_buffer_in_all_windows): Remove prototype.
2849 (replace_buffer_in_windows_safely): Add prototype.
2850
2851 * window.c: Declare Qdelete_window static again. Move down
2852 declaration of select_count.
2853 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2854 (Fother_window): Move to window.el.
2855 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2856 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2857 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2858 window.el.
2859 (replace_buffer_in_windows): Implement by calling
2860 Qreplace_buffer_in_windows.
2861 (replace_buffer_in_all_windows): Remove with some functionality
2862 moved into replace_buffer_in_windows_safely.
2863 (replace_buffer_in_windows_safely): New function.
2864 (select_window_norecord, select_frame_norecord): Move in front
2865 of run_window_configuration_change_hook. Remove now obsolete
2866 declarations.
2867 (Fset_window_buffer): Rewrite doc-string.
2868 Call Qrecord_window_buffer.
2869 (keys_of_window): Move binding for other-window to window.el.
2870
2871 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2872
2873 * dispextern.h (struct image): Replace data member, whose int_val
2874 and ptr_val fields were not used by anything, with a single
2875 lisp_val object.
2876
2877 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2878 (gif_clear_image, gif_load, imagemagick_load_image)
2879 (gs_clear_image, gs_load): Callers changed.
2880
2881 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2882
2883 * buffer.h: Include <time.h>, for time_t.
2884 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2885
2886 Fix minor problems found by static checking.
2887
2888 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2889
2890 Make identifiers static if they are not used in other modules.
2891 * data.c (Qcompiled_function, Qframe, Qvector):
2892 * image.c (QimageMagick, Qsvg):
2893 * minibuf.c (Qmetadata):
2894 * window.c (resize_window_check, resize_root_window): Now static.
2895 * window.h (resize_window_check, resize_root_window): Remove decls.
2896
2897 * window.c (window_deletion_count, delete_deletable_window):
2898 Remove; unused.
2899 (window_body_lines): Now static.
2900 (Fdelete_other_windows_internal): Mark vars as initialized.
2901 Make sure 'resize_failed' is initialized.
2902 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2903 (resize_window_apply): Remove unused local.
2904 * window.h (delete_deletable_window): Remove decl.
2905
2906 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2907 (imagemagick_load_image): Fix pointer signedness problem by changing
2908 last arg from unsigned char * to char *. All uses changed.
2909 Also, fix a local for similar reasons.
2910 Remove unused locals. Remove locals to avoid shadowing.
2911 (fn_rsvg_handle_free): Remove; unused.
2912 (svg_load, svg_load_image): Fix pointer signedness problem.
2913 (imagemagick_load_image): Don't use garbage pointer image_wand.
2914
2915 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2916
2917 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2918
2919 * image.c (gif_load): Fix omitted cast error introduced by
2920 2011-06-06 change.
2921
2922 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2923
2924 * window.h (resize_proportionally, orig_total_lines)
2925 (orig_top_line): Remove from window structure.
2926 (set_window_height, set_window_width, change_window_heights)
2927 (Fdelete_window): Remove prototypes.
2928 (resize_frame_windows): Remove duplicate declaration.
2929
2930 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2931
2932 * window.h (resize_frame_windows, resize_window_check)
2933 (delete_deletable_window, resize_root_window)
2934 (resize_frame_windows): Declare prototypes.
2935
2936 * window.c (resize_window_apply): Make definition be "static" to
2937 match the prototype.
2938
2939 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2940
2941 * window.c: Remove declarations of Qwindow_size_fixed,
2942 window_min_size_1, window_min_size_2, window_min_size,
2943 size_window, window_fixed_size_p, enlarge_window, delete_window.
2944 Remove static from declaration of Qdelete_window, it's
2945 temporarily needed by Fbury_buffer.
2946 (replace_window): Don't assign orig_top_line and
2947 orig_total_lines.
2948 (Fdelete_window, delete_window): Remove. Window deletion is
2949 handled by window.el.
2950 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2951 Replace Fdelete_window calls with calls to Qdelete_window.
2952 (Fdelete_other_windows): Remove. Deleting other windows is
2953 handled by window.el.
2954 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2955 handled in window.el.
2956 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2957 Window minimum sizes are handled in window.el.
2958 (shrink_windows, size_window, set_window_height)
2959 (set_window_width, change_window_heights, window_height)
2960 (window_width, CURBEG, CURSIZE, enlarge_window)
2961 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2962 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2963 handled in window.el.
2964 (make_dummy_parent): Rename to make_parent_window and give it a
2965 second argument horflag.
2966 (make_window): Don't set resize_proportionally any more.
2967 (Fsplit_window): Remove. Windows are split in window.el.
2968 (save_restore_action, save_restore_orig_size)
2969 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2970 Resize mini windows in window.el.
2971 (grow_mini_window, shrink_mini_window): Implement by calling
2972 Qresize_root_window_vertically, resize_window_check and
2973 resize_window_apply.
2974 (saved_window, Fset_window_configuration, save_window_save):
2975 Do not handle orig_top_line, orig_total_lines, and
2976 resize_proportionally.
2977 (window_min_height, window_min_width): Move to window.el.
2978 (keys_of_window): Move bindings for delete-other-windows,
2979 split-window, delete-window and enlarge-window to window.el.
2980
2981 * buffer.c: Temporarily extern Qdelete_window.
2982 (Fbury_buffer): Temporarily call Qdelete_window instead of
2983 Fdelete_window (Fbury_buffer will move to window.el soon).
2984
2985 * frame.c (set_menu_bar_lines_1): Remove code handling
2986 orig_top_line and orig_total_lines.
2987
2988 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2989 set_window_height but set heights directly.
2990 (change_frame_size_1): Use resize_frame_windows.
2991
2992 * xdisp.c (init_xdisp): Don't use set_window_height but set
2993 heights directly.
2994
2995 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2996 Use resize_frame_windows instead of change_window_heights and run
2997 run_window_configuration_change_hook.
2998
2999 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3000 instead of change_window_heights and run
3001 run_window_configuration_change_hook.
3002
3003 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3004
3005 * window.c (replace_window): Rename second argument REPLACEMENT to
3006 NEW. New third argument SETFLAG. Rewrite.
3007 (delete_window, make_dummy_parent): Call replace_window with
3008 third argument 1.
3009 (window_list_1): Move down in code.
3010 (run_window_configuration_change_hook): Move set_buffer part
3011 before select_frame_norecord part in order to unwind correctly.
3012 Rename count1 to count.
3013 (recombine_windows, delete_deletable_window, resize_root_window)
3014 (Fdelete_other_windows_internal)
3015 (Frun_window_configuration_change_hook, make_parent_window)
3016 (resize_window_check, resize_window_apply, Fresize_window_apply)
3017 (resize_frame_windows, Fsplit_window_internal)
3018 (Fdelete_window_internal, Fresize_mini_window_internal):
3019 New functions.
3020 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3021
3022 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3023
3024 * window.h (window): Add some new members to window structure -
3025 normal_lines, normal_cols, new_total, new_normal, clone_number,
3026 splits, nest, prev_buffers, next_buffers.
3027 (WINDOW_TOTAL_SIZE): Move here from window.c.
3028 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3029
3030 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3031 Remove.
3032 (make_dummy_parent): Set new members of windows structure.
3033 (make_window): Move down in code. Handle new members of window
3034 structure.
3035 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3036 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3037 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3038 (Fset_window_prev_buffers, Fwindow_next_buffers)
3039 (Fset_window_next_buffers, Fset_window_clone_number):
3040 New functions.
3041 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3042 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3043 Doc-string fixes.
3044 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3045 Argument WINDOW can be now internal window too.
3046 (Fwindow_use_time): Move up in code.
3047 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3048 Rewrite doc-string.
3049 (Fset_window_configuration, saved_window)
3050 (Fcurrent_window_configuration, save_window_save): Handle new
3051 members of window structure.
3052 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3053 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3054 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3055 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3056 Qget_mru_window, Qresize_root_window,
3057 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3058 Qauto_buffer_name; staticpro them.
3059
3060 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3061
3062 * window.c (Fwindow_total_size, Fwindow_left_column)
3063 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3064 (Fwindow_list_1): New functions.
3065 (window_box_text_cols): Replace with window_body_cols.
3066 (Fwindow_width, Fscroll_left, Fscroll_right):
3067 Use window_body_cols instead of window_box_text_cols.
3068 (delete_window, Fset_window_configuration):
3069 Call delete_all_subwindows with window as argument.
3070 (delete_all_subwindows): Take a window as argument and not a
3071 structure. Rewrite.
3072 (window_loop): Remove handling of GET_LRU_WINDOW and
3073 GET_LARGEST_WINDOW.
3074 (Fget_lru_window, Fget_largest_window): Move to window.el.
3075
3076 * window.h: Extern window_body_cols instead of
3077 window_box_text_cols. delete_all_subwindows now takes a
3078 Lisp_Object as argument.
3079
3080 * indent.c (compute_motion, Fcompute_motion):
3081 Use window_body_cols instead of window_box_text_cols.
3082
3083 * frame.c (delete_frame): Call delete_all_subwindows with root
3084 window as argument.
3085
3086 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3087
3088 * fns.c (Fputhash): Document return value.
3089
3090 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3091
3092 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3093
3094 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3095
3096 Cons<->int and similar integer overflow fixes (Bug#8794).
3097
3098 Check for overflow when converting integer to cons and back.
3099 * charset.c (Fdefine_charset_internal, Fdecode_char):
3100 Use cons_to_unsigned to catch overflow.
3101 (Fencode_char): Use INTEGER_TO_CONS.
3102 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3103 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3104 * data.c (long_to_cons, cons_to_long): Remove.
3105 (cons_to_unsigned, cons_to_signed): New functions.
3106 These signal an error for invalid or out-of-range values.
3107 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3108 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3109 * font.c (Ffont_variation_glyphs):
3110 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3111 * lisp.h: Include <intprops.h>.
3112 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3113 (cons_to_signed, cons_to_unsigned): New decls.
3114 (long_to_cons, cons_to_long): Remove decls.
3115 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3116 (Fprimitive_undo): Use CONS_TO_INTEGER.
3117 * xfns.c (Fx_window_property): Likewise.
3118 * xselect.c: Include <limits.h>.
3119 (x_own_selection, selection_data_to_lisp_data):
3120 Use INTEGER_TO_CONS.
3121 (x_handle_selection_request, x_handle_selection_clear)
3122 (x_get_foreign_selection, Fx_disown_selection_internal)
3123 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3124 (lisp_data_to_selection_data): Use cons_to_unsigned.
3125 (x_fill_property_data): Use cons_to_signed.
3126 Report values out of range.
3127
3128 Check for buffer and string overflow more precisely.
3129 * buffer.h (BUF_BYTES_MAX): New macro.
3130 * lisp.h (STRING_BYTES_MAX): New macro.
3131 * alloc.c (Fmake_string):
3132 * character.c (string_escape_byte8):
3133 * coding.c (coding_alloc_by_realloc):
3134 * doprnt.c (doprnt):
3135 * editfns.c (Fformat):
3136 * eval.c (verror):
3137 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3138 since they may not be the same number.
3139 * editfns.c (Finsert_char):
3140 * fileio.c (Finsert_file_contents):
3141 Likewise for BUF_BYTES_MAX.
3142
3143 * image.c: Use ptrdiff_t, not int, for sizes.
3144 (slurp_file): Switch from int to ptrdiff_t.
3145 All uses changed.
3146 (slurp_file): Check that file size fits in both size_t (for
3147 malloc) and ptrdiff_t (for sanity and safety).
3148
3149 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3150 if b->modtime has its maximal value.
3151
3152 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3153
3154 Don't assume time_t can fit into int.
3155 * buffer.h (struct buffer.modtime): Now time_t, not int.
3156 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3157 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3158
3159 Minor fixes for signed vs unsigned integers.
3160 * character.h (MAYBE_UNIFY_CHAR):
3161 * charset.c (maybe_unify_char):
3162 * keyboard.c (read_char, reorder_modifiers):
3163 XINT -> XFASTINT, since the integer must be nonnegative.
3164 * ftfont.c (ftfont_spec_pattern):
3165 * keymap.c (access_keymap, silly_event_symbol_error):
3166 XUINT -> XFASTINT, since the integer must be nonnegative.
3167 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3168 since it makes no difference and we prefer signed.
3169 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3170 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3171 nonnegative.
3172
3173 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3174
3175 * window.h (Fwindow_frame): Declare.
3176
3177 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3178
3179 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3180 (SPARE_MEMORY): Always define.
3181 (LARGE_REQUEST): Remove.
3182 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3183
3184 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3185
3186 * lisp.h: Move EXFUNS for Fframe_root_window,
3187 Fframe_first_window and Fset_frame_selected_window to window.h.
3188
3189 * window.h: Move EXFUNS for Fframe_root_window,
3190 Fframe_first_window and Fset_frame_selected_window here from
3191 lisp.h.
3192
3193 * frame.c (Fwindow_frame, Fframe_first_window)
3194 (Fframe_root_window, Fframe_selected_window)
3195 (Fset_frame_selected_window): Move to window.c.
3196 (Factive_minibuffer_window): Move to minibuf.c.
3197 (Fother_visible_frames_p): New function.
3198
3199 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3200
3201 * window.c (decode_window, decode_any_window): Move up in code.
3202 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3203 (inhibit_frame_unsplittable): Remove unused variable.
3204 (Fwindow_buffer): Move up and rewrite doc-string.
3205 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3206 (Fwindow_prev): New functions.
3207 (Fwindow_frame): Move here from frame.c. Accept any window as
3208 argument.
3209 (Fframe_root_window, Fframe_first_window)
3210 (Fframe_selected_window): Move here from frame.c. Accept frame
3211 or arbitrary window as argument. Update doc-strings.
3212 (Fminibuffer_window): Move up in code.
3213 (Fwindow_minibuffer_p): Move up in code and simplify.
3214 (Fset_frame_selected_window): Move here from frame.c.
3215 Marginal rewrite.
3216 (Fselected_window, select_window, Fselect_window): Move up in
3217 code. Minor doc-string fixes.
3218
3219 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3220
3221 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3222 Do not assume that spare memory exists; that assumption is valid
3223 only if SYSTEM_MALLOC.
3224 (LARGE_REQUEST): New macro, so that the issue of large requests
3225 is separated from the issue of spare memory.
3226
3227 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3228
3229 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3230 format. (Bug#8806)
3231
3232 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3233
3234 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3235 before statements.
3236
3237 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3238
3239 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3240
3241 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3242
3243 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3244 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3245
3246 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3247
3248 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3249
3250 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3251
3252 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3253 (x_clipboard_manager_save): Add return value.
3254 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3255 New error handlers.
3256 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3257 Obey Vx_select_enable_clipboard_manager. Catch errors in
3258 x_clipboard_manager_save (Bug#8779).
3259 (Vx_select_enable_clipboard_manager): New variable.
3260 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3261
3262 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3263
3264 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3265
3266 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3267
3268 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3269 in the current matrix if keep_current_p is non-zero.
3270
3271 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3272
3273 * bidi.c (bidi_level_of_next_char): Fix last change.
3274
3275 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3276
3277 Support bidi reordering of text covered by display properties.
3278
3279 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3280 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3281 (bidi_cache_search, bidi_cache_iterator_state)
3282 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3283 (bidi_level_of_next_char, bidi_move_to_visually_next):
3284 Support character positions inside a run of characters covered by a
3285 display string.
3286 (bidi_paragraph_init, bidi_resolve_explicit_1)
3287 (bidi_level_of_next_char): Call bidi_fetch_char and
3288 bidi_fetch_char_advance instead of FETCH_CHAR and
3289 FETCH_CHAR_ADVANCE.
3290 (bidi_init_it): Initialize new members.
3291 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3292 definitions.
3293 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3294 instead of using explicit *_CHAR codes.
3295 (bidi_resolve_explicit, bidi_resolve_weak):
3296 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3297 bidirectional text is supported only in multibyte buffers.
3298 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3299 it to initialize the frame_window_p member of struct bidi_it.
3300 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3301 (bidi_resolve_explicit, bidi_resolve_weak)
3302 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3303 bidi_it->nchars is non-positive.
3304 (bidi_level_of_next_char): Don't try to lookup the cache for the
3305 next/previous character if nothing is cached there yet, or if we
3306 were just reseat()'ed to a new position.
3307
3308 * xdisp.c (set_cursor_from_row): Set start and stop points
3309 according to the row's direction when priming the loop that looks
3310 for the glyph on which to display cursor.
3311 (single_display_spec_intangible_p): Function deleted.
3312 (display_prop_intangible_p): Reimplement to call
3313 handle_display_spec instead of single_display_spec_intangible_p.
3314 Accept 3 additional arguments needed by handle_display_spec.
3315 This fixes incorrect cursor motion across display property with complex
3316 values: lists, `(when COND...)' forms, etc.
3317 (single_display_spec_string_p): Support property values that are
3318 lists with the argument STRING its top-level element.
3319 (display_prop_string_p): Fix the condition for processing a
3320 property that is a list to be consistent with handle_display_spec.
3321 (handle_display_spec): New function, refactored from the
3322 last portion of handle_display_prop.
3323 (compute_display_string_pos): Accept additional argument
3324 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3325 value of a `display' property is a "replacing spec".
3326 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3327 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3328 the display property, but just return a value indicating whether
3329 the display property will replace the characters it covers.
3330 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3331 frame_window_p members of struct bidi_it.
3332 (compute_display_string_pos, compute_display_string_end):
3333 New functions.
3334 (push_it): Accept second argument POSITION, where pop_it should
3335 jump to continue iteration.
3336 (reseat_1): Initialize bidi_it.disp_pos.
3337
3338 * keyboard.c (adjust_point_for_property): Adjust the call to
3339 display_prop_intangible_p to its new signature.
3340
3341 * dispextern.h (struct bidi_it): New member frame_window_p.
3342 (bidi_init_it): Update prototypes.
3343 (display_prop_intangible_p): Update prototype.
3344 (compute_display_string_pos, compute_display_string_end):
3345 Declare prototypes.
3346 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3347 EMACS_INT.
3348
3349 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 Malloc failure behavior now depends on size of allocation.
3352 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3353 * lisp.h: Change signatures accordingly.
3354 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3355 All callers changed. (Bug#8762)
3356
3357 * gnutls.c: Use Emacs's memory allocators.
3358 Without this change, the gnutls library would invoke malloc etc.
3359 directly, which causes problems on non-SYNC_INPUT hosts, and which
3360 runs afoul of improving memory_full behavior. (Bug#8761)
3361 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3362 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3363 xfree instead of the default malloc, realloc, free.
3364 (Fgnutls_boot): No need to check for memory allocation failure,
3365 since xmalloc does that for us.
3366
3367 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3368 * category.c (hash_get_category_set):
3369 * ccl.c (ccl_driver):
3370 * charset.c (Fdefine_charset_internal):
3371 * charset.h (struct charset.hash_index):
3372 * composite.c (get_composition_id, gstring_lookup_cache)
3373 (composition_gstring_put_cache):
3374 * composite.h (struct composition.hash_index):
3375 * dispextern.h (struct image.hash):
3376 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3377 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3378 (hashfn_equal, hashfn_user_defined, make_hash_table)
3379 (maybe_resize_hash_table, hash_lookup, hash_put)
3380 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3381 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3382 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3383 * image.c (make_image, search_image_cache, lookup_image)
3384 (xpm_put_color_table_h):
3385 * lisp.h (struct Lisp_Hash_Table):
3386 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3387 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3388 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3389 * alloc.c (allocate_vectorlike):
3390 Check for overflow in vector size calculations.
3391 * ccl.c (ccl_driver):
3392 Check for overflow when converting EMACS_INT to int.
3393 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3394 need to be updated by these changes.
3395 * fns.c (make_hash_table, maybe_resize_hash_table):
3396 Check for integer overflow with large hash tables.
3397 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3398 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3399 (SXHASH_REDUCE): New macro.
3400 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3401 Use it instead of discarding useful hash info with large hash values.
3402 (sxhash_float): New function.
3403 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3404 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3405 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3406 Rewrite to use FIXNUM_BITS, as this simplifies things.
3407 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3408 Adjust signatures to match updated version of code.
3409 (consing_since_gc): Now EMACS_INT, since a single hash table can
3410 use more than INT_MAX bytes.
3411
3412 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3413
3414 Make it possible to build with GCC-4.6+ -O2 -flto.
3415
3416 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3417
3418 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3419
3420 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3421 Call minibuffer-inactive-mode.
3422
3423 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3424
3425 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3426 Update dependencies.
3427
3428 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3429
3430 * data.c (init_data): Remove code for UTS, this system is not
3431 supported anymore.
3432
3433 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3434
3435 Don't force ./temacs to start in terminal mode.
3436
3437 * frame.c (make_initial_frame): Initialize faces in all cases, not
3438 only when CANNOT_DUMP is defined.
3439 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3440
3441 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3442
3443 * dispnew.c (add_window_display_history): Use const for the string
3444 pointer. Remove declaration, not needed.
3445
3446 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3447
3448 Use 'inline', not 'INLINE'.
3449 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3450 * alloc.c, fontset.c (INLINE): Remove.
3451 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3452 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3453 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3454 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3455 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3456
3457 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3458
3459 Make it possible to run ./temacs.
3460
3461 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3462 syms_of_callproc does the same thing. Remove test for
3463 "initialized", do it in the caller.
3464 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3465
3466 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3467
3468 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3469 (read_minibuf): Use get_minibuffer.
3470 (syms_of_minibuf): Use DEFSYM.
3471 (Qmetadata): New var.
3472 * data.c (Qbuffer): Don't make it static.
3473 (syms_of_data): Use DEFSYM.
3474
3475 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3476
3477 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3478 (CCL_CODE_MIN): New macro.
3479
3480 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3481
3482 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3483
3484 * eval.c (Qdebug): Now static.
3485 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3486 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3487 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3488
3489 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3490
3491 * image.c: Various fixes to ImageMagick code comments.
3492 (Fimagemagick_types): Doc fix.
3493
3494 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3495
3496 Minor fixes prompted by GCC 4.6.0 warnings.
3497
3498 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3499
3500 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3501 (x_clipboard_manager_save_all): Move extern decl to ...
3502 * xterm.h: ... here, so that it can be checked for consistency.
3503
3504 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3505
3506 * xselect.c (x_clipboard_manager_save_frame)
3507 (x_clipboard_manager_save_all): New functions.
3508 (Fx_clipboard_manager_save): Lisp function deleted.
3509
3510 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3511 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3512
3513 * xterm.h: Update prototype.
3514
3515 2011-05-28 William Xu <william.xwl@gmail.com>
3516
3517 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3518 exiting (Bug#8239).
3519
3520 2011-05-28 Jim Meyering <meyering@redhat.com>
3521
3522 Avoid a sign-extension bug in crypto_hash_function.
3523 * fns.c (to_uchar): Define.
3524 (crypto_hash_function): Use it to convert some newly-signed
3525 variables to unsigned, to avoid sign-extension bugs. For example,
3526 without this change, (md5 "truc") would evaluate to
3527 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3528 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3529 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3530
3531 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3532
3533 Integer overflow fixes.
3534
3535 * dbusbind.c: Serial number integer overflow fixes.
3536 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3537 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3538 to hold a serial number that is too large for a fixnum.
3539 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3540 Check for serial numbers out of range. Decode any serial number
3541 that was so large that it became a float. (Bug#8722)
3542
3543 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3544 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3545 Use XFASTINT rather than XUINT when numbers are nonnegative.
3546 (xd_append_arg, Fdbus_method_return_internal):
3547 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3548 arguments, check that Lisp number is nonnegative, rather than
3549 silently wrapping negative numbers around. (Bug#8722)
3550 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3551 (Bug#8722)
3552
3553 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3554
3555 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3556
3557 ccl: add integer overflow checks
3558 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3559 (IN_INT_RANGE): New macros.
3560 (ccl_driver): Use them to check for integer overflow when
3561 decoding a CCL program. Many of the new checks are whether XINT (x)
3562 fits in int; it doesn't always, on 64-bit hosts. The new version
3563 doesn't catch all possible integer overflows, but it's an
3564 improvement. (Bug#8719)
3565
3566 * alloc.c (make_event_array): Use XINT, not XUINT.
3567 There's no need for unsigned here.
3568
3569 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3570 This follows up to the 2011-05-06 change that substituted uintptr_t
3571 for EMACS_INT. This case wasn't caught back then.
3572
3573 Rework Fformat to avoid integer overflow issues.
3574 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3575 now (part of C89). Include <verify.h>.
3576 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3577 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3578 (Fformat): Avoid the prepass trying to compute sizes; it was only
3579 approximate and thus did not catch overflow reliably. Instead, walk
3580 through the format just once, formatting and computing sizes as we go,
3581 checking for integer overflow at every step, and allocating a larger
3582 buffer as needed. Keep track separately whether the format is
3583 multibyte. Keep only the most-recently calculated precision, rather
3584 than them all. Record whether each argument has been converted to
3585 string. Use EMACS_INT, not int, for byte and char and arg counts.
3586 Support field widths and precisions larger than INT_MAX. Avoid
3587 sprintf's undefined behavior with conversion specifications such as %#d
3588 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3589 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3590 formatting out-of-range floating point numbers with int
3591 formats. (Bug#8668)
3592
3593 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3594
3595 * data.c: Avoid integer truncation in expressions involving floats.
3596 * data.c: Include <intprops.h>.
3597 (arith_driver): When there's an integer overflow in an expression
3598 involving floating point, convert the integers to floating point
3599 so that the resulting value does not suffer from catastrophic
3600 integer truncation. For example, on a 64-bit host (* 4
3601 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3602 Do not rely on undefined behavior after integer overflow.
3603
3604 merge count_size_as_multibyte, parse_str_to_multibyte
3605 * character.c, character.h (count_size_as_multibyte):
3606 Rename from parse_str_to_multibyte; all uses changed.
3607 Check for integer overflow.
3608 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3609 since it's now a duplicate of the other. This is more of
3610 a character than a buffer op, so better that it's in character.c.
3611 * fns.c, print.c: Adjust to above changes.
3612
3613 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3614
3615 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3616
3617 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3618
3619 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3620 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3621 (x_clipboard_manager_save): Now static.
3622 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3623
3624 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3625 (crypto_hash_function): Now static.
3626 Fix pointer signedness problems. Avoid unnecessary initializations.
3627
3628 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3629
3630 * termhooks.h (Vselection_alist): Make it terminal-local.
3631
3632 * terminal.c (create_terminal): Initialize it.
3633
3634 * xselect.c: Support for clipboard managers.
3635 (Vselection_alist): Move to termhooks.h as terminal-local var.
3636 (LOCAL_SELECTION): New macro.
3637 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3638 (symbol_to_x_atom): Remove gratuitous arg.
3639 (x_handle_selection_request, lisp_data_to_selection_data)
3640 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3641 (x_own_selection, x_get_local_selection, x_convert_selection):
3642 New arg, specifying work frame. Use terminal-local Vselection_alist.
3643 (some_frame_on_display): Delete unused function.
3644 (Fx_own_selection_internal, Fx_get_selection_internal)
3645 (Fx_disown_selection_internal, Fx_selection_owner_p)
3646 (Fx_selection_exists_p): New optional frame arg.
3647 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3648 (x_handle_selection_clear): Don't treat other terminals with the
3649 same keyboard specially. Use the terminal-local Vselection_alist.
3650 (x_clear_frame_selections): Use Frun_hook_with_args.
3651
3652 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3653
3654 * xterm.h: Add support for those atoms.
3655
3656 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3657
3658 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3659 (converted_selections, conversion_fail_tag): New global variables.
3660 (x_selection_request_lisp_error): Free the above.
3661 (x_get_local_selection): Remove unnecessary code.
3662 (x_reply_selection_request): Args changed; handle arbitrary array
3663 of converted selections stored in converted_selections.
3664 Separate the XChangeProperty and SelectionNotify steps.
3665 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3666 (x_convert_selection): New function.
3667 (x_handle_selection_event): Simplify.
3668 (x_get_foreign_selection): Don't ignore incoming requests while
3669 waiting for an answer; this will fail when we implement
3670 SAVE_TARGETS, and seems unnecessary anyway.
3671 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3672 (Vx_sent_selection_functions): Doc fix.
3673
3674 2011-05-26 Leo Liu <sdl.web@gmail.com>
3675
3676 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3677
3678 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3679
3680 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3681
3682 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3683 for fringe update if it has periodic bitmap.
3684 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3685 and fringe_bitmap_periodic_p.
3686
3687 * fringe.c (get_fringe_bitmap_data): New function.
3688 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3689 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3690 row. Mark glyph row for fringe update if periodicity changed.
3691
3692 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3693 for fringe update unless it has periodic bitmap.
3694
3695 2011-05-25 Kenichi Handa <handa@m17n.org>
3696
3697 * xdisp.c (get_next_display_element): Set correct it->face_id for
3698 a static composition.
3699
3700 2011-05-24 Leo Liu <sdl.web@gmail.com>
3701
3702 * deps.mk (fns.o):
3703 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3704
3705 * fns.c (crypto_hash_function, Fsha1): New function.
3706 (Fmd5): Use crypto_hash_function.
3707 (syms_of_fns): Add Ssha1.
3708
3709 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3710
3711 * gnutls.c: Remove unused macros.
3712 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3713 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3714 Remove macros that are defined and never used.
3715 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3716
3717 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3718
3719 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3720 (Fx_get_selection_internal): Minor cleanup.
3721 (Fx_own_selection_internal): Rename arguments for consistency with
3722 select.el.
3723
3724 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3725
3726 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3727
3728 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3729
3730 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3731
3732 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3733
3734 * dispnew.c (scrolling_window): Don't exclude the case that the
3735 last enabled row in the desired matrix touches the bottom boundary.
3736
3737 2011-05-21 Glenn Morris <rgm@gnu.org>
3738
3739 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3740 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3741 and add some more files.
3742
3743 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3744
3745 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3746 report_file_error introduced by the change from 2011-05-07.
3747
3748 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3749
3750 * systime.h (Time): Define only if emacs is defined.
3751 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3752 where the include path doesn't have X11/X.h by default. See
3753 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3754
3755 2011-05-20 Kenichi Handa <handa@m17n.org>
3756
3757 * composite.c (find_automatic_composition): Fix previous change.
3758
3759 2011-05-20 Glenn Morris <rgm@gnu.org>
3760
3761 * lisp.mk: New file, split from Makefile.in.
3762 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3763 (shortlisp): Remove.
3764 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3765
3766 2011-05-19 Glenn Morris <rgm@gnu.org>
3767
3768 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3769 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3770 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3771 (lisp): Set the order to that of loadup.el.
3772 (shortlisp): Make it a copy of $lisp.
3773 (SOME_MACHINE_LISP): Remove.
3774 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3775 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3776
3777 2011-05-18 Kenichi Handa <handa@m17n.org>
3778
3779 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3780 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3781 (find_automatic_composition): Mostly rewrite for efficiency.
3782
3783 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3784
3785 * makefile.w32-in: Update dependencies.
3786
3787 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3788
3789 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3790 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3791
3792 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3793
3794 Fix some integer overflow issues, such as string length overflow.
3795
3796 * insdel.c (count_size_as_multibyte): Check for string overflow.
3797
3798 * character.c (lisp_string_width): Check for string overflow.
3799 Use EMACS_INT, not int, for string indexes and lengths; in
3800 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3801 the resulting string length overflows an EMACS_INT; instead,
3802 report a string overflow if no precision given. When checking for
3803 precision exhaustion, use a check that cannot possibly have
3804 integer overflow. (Bug#8675)
3805 * character.h (lisp_string_width): Adjust to new signature.
3806
3807 * alloc.c (string_overflow): New function.
3808 (Fmake_string): Use it. This doesn't change behavior, but saves
3809 a few bytes and will simplify future changes.
3810 * character.c (string_escape_byte8): Likewise.
3811 * lisp.h (string_overflow): New decl.
3812
3813 Fixups, following up to the user-interface timestamp change.
3814 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3815 for UI timestamps, instead of unsigned long.
3816 * msdos.c (mouse_get_pos): Likewise.
3817 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3818 * w32gui.h (Time): Define by including "systime.h" rather than by
3819 declaring it ourselves. (Bug#8664)
3820
3821 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3822 * image.c (clear_image_cache): Likewise.
3823
3824 * term.c (term_mouse_position): Don't assume time_t wraparound.
3825
3826 Be more systematic about user-interface timestamps.
3827 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3828 and sometimes 'EMACS_UINT', to represent these timestamps.
3829 This change causes it to use 'Time' uniformly, as that's what X uses.
3830 This makes the code easier to follow, and makes it easier to catch
3831 integer overflow bugs such as Bug#8664.
3832 * frame.c (Fmouse_position, Fmouse_pixel_position):
3833 Use Time, not unsigned long, for user-interface timestamps.
3834 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3835 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3836 * keyboard.h (last_event_timestamp): Likewise.
3837 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3838 * menu.h (xmenu_show): Likewise.
3839 * term.c (term_mouse_position): Likewise.
3840 * termhooks.h (struct input_event.timestamp): Likewise.
3841 (struct terminal.mouse_position_hook): Likewise.
3842 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3843 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3844 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3845 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3846 what it was before.
3847 * menu.h, termhooks.h: Include "systime.h", for Time.
3848
3849 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3850 Don't assume that the difference between two unsigned long values
3851 can fit into an integer. At this point, we know button_down_time
3852 <= event->timestamp, so the difference must be nonnegative, so
3853 there's no need to cast the result if double-click-time is
3854 nonnegative, as it should be; check that it's nonnegative, just in
3855 case. This bug is triggered when events are more than 2**31 ms
3856 apart (about 25 days). (Bug#8664)
3857
3858 * xselect.c (last_event_timestamp): Remove duplicate decl.
3859 (x_own_selection): Remove needless cast to unsigned long.
3860
3861 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3862 that always fit in int. Use a sentinel instead of a counter, to
3863 avoid a temp and to allay GCC's concerns about possible int overflow.
3864 * frame.h (struct frame): Use int for menu_bar_items_used
3865 instead of EMACS_INT, since it always fits in int.
3866
3867 * menu.c (grow_menu_items): Check for int overflow.
3868
3869 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3870
3871 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3872 Before, the code was not consistent. These values cannot exceed
3873 2**31 - 1 so there's no need to make them unsigned.
3874 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3875 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3876 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3877 as modifiers.
3878 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3879
3880 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3881 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3882 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3883 presumably because the widths might not match.
3884
3885 * window.c (size_window): Avoid needless test at loop start.
3886
3887 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3888
3889 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3890
3891 2011-05-12 Drew Adams <drew.adams@oracle.com>
3892
3893 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3894
3895 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3896
3897 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3898 `width' to `bar_area_x' and `bar_area_width', respectively.
3899 (x_scroll_run): Take account of fringe background extension.
3900
3901 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3902 Rename local vars `left' and `width' to `bar_area_x' and
3903 `bar_area_width', respectively.
3904 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3905 background extension.
3906
3907 2011-05-10 Jim Meyering <meyering@redhat.com>
3908
3909 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3910
3911 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3912
3913 * image.c (Finit_image_library): Return t for built-in image types,
3914 like pbm and xbm. (Bug#8640)
3915
3916 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3917
3918 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3919
3920 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3921
3922 * w32console.c (Fset_screen_color): Doc fix.
3923 (Fget_screen_color): New function.
3924 (syms_of_ntterm): Defsubr it.
3925
3926 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3927 unlink the temporary file if Fcall_process didn't create it in the
3928 first place.
3929 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3930 child process will be redirected to a file specified with `:file'.
3931 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3932 cue to call_process_cleanup not to close that handle.
3933
3934 2011-05-07 Ben Key <bkey76@gmail.com>
3935
3936 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3937 one of two shell specific rules, either bootstrap-temacs-CMD or
3938 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3939 to the previous implementation of the bootstrap-temacs rule.
3940 The bootstrap-temacs-CMD rule is similar to the previous
3941 implementation of the bootstrap-temacs rule except that it
3942 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3943 variable.
3944
3945 These changes, along with some changes to nt/configure.bat,
3946 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3947 earlier fix to add support for --cflags and --ldflags options
3948 that include quotes so that it works whether make uses cmd or
3949 sh as the shell.
3950
3951 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3952
3953 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3954 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3955 is a constant.
3956 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3957 a string. Handle both cases.
3958 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3959 (Fdbus_register_method): Use Qinvalid_function.
3960
3961 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3962
3963 * makefile.w32-in: Update dependencies.
3964 (LISP_H): Add inttypes.h and stdin.h.
3965 (PROCESS_H): Add unistd.h.
3966
3967 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3968
3969 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3970 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3971
3972 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3975
3976 * term.c (vfatal): Remove stray call to va_end.
3977 It's not needed and the C Standard doesn't allow it here anyway.
3978
3979 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3980 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3981
3982 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3983 bytes.
3984
3985 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3986
3987 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3988
3989 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3990
3991 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3992
3993 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3994
3995 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3996 * charset.c (Fdefine_charset_internal): Don't initialize
3997 charset.code_space[15]. The value was garbage, on hosts with
3998 32-bit int (Bug#8600).
3999
4000 * lread.c (read_integer): Be more consistent with string-to-number.
4001 Use string_to_number to do the actual conversion; this avoids
4002 rounding errors and fixes some other screwups. Without this fix,
4003 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4004 (digit_to_number): Move earlier, for benefit of read_integer.
4005 Return -1 if the digit is out of range for the base, -2 if it is
4006 not a digit in any supported base. (Bug#8602)
4007
4008 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4009
4010 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4011 to match comment at start of function. This also removes a
4012 GCC warning about overflow in a 32+64-bit port.
4013
4014 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4015
4016 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4017 Reported by Stefan Monnier in
4018 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4019 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4020 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4021
4022 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4023 (EMACS_UINTPTR): Likewise, with uintptr_t.
4024
4025 * lisp.h: Prefer 64-bit EMACS_INT if available.
4026 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4027 on 32-bit hosts that have 64-bit int, so that they can access
4028 large files.
4029 However, temporarily disable this change unless the temporary
4030 symbol WIDE_EMACS_INT is defined.
4031
4032 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4033
4034 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4035 This removes an assumption that EMACS_INT and long are the same
4036 width as pointers. The assumption is true for Emacs porting targets
4037 now, but we want to make other targets possible.
4038 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4039 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4040 In the rest of the code, change types of integers that hold casted
4041 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4042 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4043 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4044 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4045 No need to cast type when ORing.
4046 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4047 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4048 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4049 assume EMACS_INT is the same width as char *.
4050 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4051 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4052 Remove no-longer-needed casts.
4053 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4054 (xg_tool_bar_help_callback, xg_make_tool_item):
4055 Use EMACS_INTPTR to hold an integer
4056 that will be cast to void *; this can avoid a GCC warning
4057 if EMACS_INT is not the same width as void *.
4058 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4059 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4060 (current_message_1, set_message_1):
4061 Use a local to convert to proper width without a cast.
4062 * xmenu.c (dialog_selection_callback): Likewise.
4063
4064 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4065 Also, don't assume VALBITS / RAND_BITS is less than 5,
4066 and don't rely on undefined behavior when shifting a 1 left into
4067 the sign bit.
4068 * lisp.h (get_random): Change signature to match.
4069
4070 * lread.c (hash_string): Use size_t, not int, for hash computation.
4071 Normally we prefer signed values; but hashing is special, because
4072 it's better to use unsigned division on hash table sizes so that
4073 the remainder is nonnegative. Also, size_t is the natural width
4074 for hashing into memory. The previous code used 'int', which doesn't
4075 retain enough info to hash well into very large tables.
4076 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4077
4078 * dbusbind.c: Don't possibly lose pointer info when converting.
4079 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4080 Use XPNTR rather than XHASH, so that the high-order bits of
4081 the pointer aren't lost when converting through void *.
4082
4083 * eval.c (Fautoload): Don't double-shift a pointer.
4084
4085 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4086
4087 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4088
4089 * gnutls.c (DEF_GNUTLS_FN):
4090 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4091
4092 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4093
4094 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4095 marker. (Bug#8610)
4096
4097 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4098
4099 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4100 New version that can reserve upto 2GB of heap space.
4101
4102 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4103
4104 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4105
4106 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4107
4108 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4109 `gnutls_certificate_set_x509_key_file'.
4110
4111 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4112
4113 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4114 Update dependencies.
4115
4116 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4117
4118 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4119 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4120 Remove unused parameter `fildes'.
4121 * process.c (read_process_output, send_process): Don't pass it.
4122
4123 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4124
4125 Fix previous change: the library cache is defined in w32.c.
4126 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4127 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4128
4129 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4130
4131 Implement dynamic loading of GnuTLS on Windows.
4132
4133 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4134 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4135 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4136 Declare.
4137
4138 * gnutls.c (Qgnutls_dll): Define.
4139 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4140 (gnutls_*): Declare function pointers.
4141 (init_gnutls_functions): New function to initialize function pointers.
4142 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4143 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4144 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4145 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4146 (emacs_gnutls_write, emacs_gnutls_read)
4147 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4148 (Fgnutls_available_p): New function.
4149 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4150 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4151 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4152
4153 * image.c: Include w32.h.
4154 (Vimage_type_cache): Delete.
4155 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4156 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4157 (w32_delayed_load): Move to w32.c.
4158
4159 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4160
4161 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4162 (w32_delayed_load): Move from image.c. When loading a library, record
4163 its filename in the :loaded-from property of the library id.
4164 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4165 Initialize and staticpro them.
4166 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4167
4168 * process.c: Include lisp.h before w32.h, not after.
4169 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4170 instead of gnutls_record_check_pending.
4171
4172 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4173
4174 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4175
4176 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4177 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4178 as passed in.
4179
4180 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4181
4182 * xterm.c (x_set_frame_alpha): Do not set property on anything
4183 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4184
4185 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4186
4187 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4188
4189 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4190
4191 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4192 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4193 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4194 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4195 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4196 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4197 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4198 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4199 (Qgnutls_bootprop_callbacks_verify): Make static.
4200
4201 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4202
4203 * callproc.c: Indentation fixup.
4204
4205 * sysdep.c (wait_for_termination_1): Make static.
4206 (wait_for_termination, interruptible_wait_for_termination):
4207 Move after wait_for_termination_1.
4208
4209 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4210
4211 * sysdep.c (interruptible_wait_for_termination): New function
4212 which is like wait_for_termination, but allows keyboard
4213 interruptions.
4214
4215 * callproc.c (Fcall_process): Add (:file "file") as an option for
4216 the STDOUT buffer.
4217 (Fcall_process_region): Ditto.
4218
4219 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4220
4221 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4222 rather than `XVECTOR (FOO)->size'.
4223
4224 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4225 inttypes.h, as a gnulib replacement is used if it not available in
4226 system headers.
4227
4228 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4229
4230 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4231 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4232 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4233
4234 * coding.c (coding_alloc_by_realloc): Error out if destination
4235 will grow beyond MOST_POSITIVE_FIXNUM.
4236 (decode_coding_emacs_mule): Abort if there isn't enough place in
4237 charbuf for the composition carryover bytes. Reserve an extra
4238 space for up to 2 characters produced in a loop.
4239 (decode_coding_iso_2022): Abort if there isn't enough place in
4240 charbuf for the composition carryover bytes.
4241
4242 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4243
4244 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4245 aborting when %lld or %lll format is passed.
4246 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4247 %llo or %llx format is passed. (Bug#8545)
4248
4249 * window.c (window_scroll_line_based): Use a marker instead of
4250 simple variables to record original value of point. (Bug#7952)
4251
4252 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4253 produced by %s or %c overflows available buffer space. (Bug#8545)
4254
4255 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4258 (SIZE_MAX): Move defn after all includes, as they might #define it.
4259
4260 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4261
4262 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4263
4264 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4265
4266 * keyboard.c (Qdelayed_warnings_hook): Define.
4267 (command_loop_1): Run `delayed-warnings-hook'
4268 if Vdelayed_warnings_list is non-nil.
4269 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4270 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4271
4272 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4273
4274 * doprnt.c (doprnt): Don't return value smaller than the buffer
4275 size if the message was truncated. (Bug#8545).
4276
4277 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4278
4279 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4280 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4281
4282 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4283
4284 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4285
4286 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4287
4288 * makefile.w32-in: Update dependencies.
4289
4290 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4291
4292 Improve `doprnt' and its usage. (Bug#8545)
4293 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4294 `format_end'. Remove support for %l as a conversion specifier.
4295 Don't use xrealloc. Improve diagnostics when the %l size modifier
4296 is used. Update the commentary.
4297
4298 * eval.c (verror): Simplify calculation of size_t.
4299
4300 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4301 messages.
4302
4303 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4304
4305 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4306 change.
4307
4308 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4309
4310 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4311 This makes this file independent of the recent pseudovector change.
4312
4313 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4314
4315 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4316
4317 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4318 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4319 Remove unused local.
4320 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4321
4322 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4323 GCC 4.6.0 optimizes based on type-based alias analysis.
4324 For example, if b is of type struct buffer * and v of type struct
4325 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4326 != &v->size, and therefore "v->size = 1; b->size = 2; return
4327 v->size;" must therefore return 1. This assumption is incorrect
4328 for Emacs, since it type-puns struct Lisp_Vector * with many other
4329 types. To fix this problem, this patch adds a new type struct
4330 vectorlike_header that documents the constraints on layout of vectors
4331 and pseudovectors, and helps optimizing compilers not get fooled
4332 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4333 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4334 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4335 the size member.
4336 (XSETPVECTYPE): Rewrite in terms of new macro.
4337 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4338 This is a bit clearer, and further avoids the possibility of
4339 undesirable aliasing.
4340 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4341 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4342 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4343 since Lisp_Subr is a special case (no "next" field).
4344 (ASIZE): Now uses header.size rather than size.
4345 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4346 to avoid the hassle of writing XVECTOR (foo)->header.size.
4347 (struct vectorlike_header): New type.
4348 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4349 object, to help avoid aliasing.
4350 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4351 (SUBRP): Likewise, since Lisp_Subr is a special case.
4352 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4353 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4354 (struct Lisp_Hash_Table): Combine first two members into a single
4355 struct vectorlike_header member. All uses of "size" and "next" members
4356 changed to be "header.size" and "header.next".
4357 * buffer.h (struct buffer): Likewise.
4358 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4359 * frame.h (struct frame): Likewise.
4360 * process.h (struct Lisp_Process): Likewise.
4361 * termhooks.h (struct terminal): Likewise.
4362 * window.c (struct save_window_data, struct saved_window): Likewise.
4363 * window.h (struct window): Likewise.
4364 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4365 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4366 * buffer.c (init_buffer_once): Likewise.
4367 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4368 special case.
4369 * process.c (Fformat_network_address): Use local var for size,
4370 for brevity.
4371
4372 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4373
4374 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4375 * data.c (atof): Remove decl; no longer used or needed.
4376 (digit_to_number): Move to lread.c.
4377 (Fstring_to_number): Use new string_to_number function, to be
4378 consistent with how the Lisp reader treats infinities and NaNs.
4379 Do not assume that floating-point numbers represent EMACS_INT
4380 without losing information; this is not true on most 64-bit hosts.
4381 Avoid double-rounding errors, by insisting on integers when
4382 parsing non-base-10 numbers, as the documentation specifies.
4383 * lisp.h (string_to_number): New decl, replacing ...
4384 (isfloat_string): Remove.
4385 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4386 (read1): Do not accept +. and -. as integers; this
4387 appears to have been a coding error. Similarly, do not accept
4388 strings like +-1e0 as floating point numbers. Do not report
4389 overflow for integer overflows unless the base is not 10 which
4390 means we have no simple and reliable way to continue.
4391 Break out the floating-point parsing into a new
4392 function string_to_number, so that Fstring_to_number parses
4393 floating point numbers consistently with the Lisp reader.
4394 (digit_to_number): Move here from data.c. Make it static inline.
4395 (E_CHAR, EXP_INT): Remove, replacing with ...
4396 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4397 (string_to_number): New function, replacing isfloat_string.
4398 This function checks for valid syntax and produces the resulting
4399 Lisp float number too. Rework it so that string-to-number
4400 no longer mishandles examples like "1.0e+". Use strtoumax,
4401 so that overflow for non-base-10 numbers is reported only when
4402 there's no portable and simple way to convert to floating point.
4403
4404 * textprop.c (set_text_properties_1): Rewrite for clarity,
4405 and to avoid GCC warning about integer overflow.
4406
4407 * intervals.h (struct interval): Use EMACS_INT for members
4408 where EMACS_UINT might cause problems. See
4409 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4410 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4411 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4412 All uses changed.
4413 (offset_intervals): Tell GCC not to worry about length overflow
4414 when negating a negative length.
4415
4416 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4417 (overrun_check_free): Likewise.
4418
4419 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4420 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4421 word size.
4422
4423 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4424 (gnutls_make_error): Rename local to avoid shadowing.
4425 (gnutls_emacs_global_deinit): ifdef out; not used.
4426 (Fgnutls_boot): Use const for pointer to readonly storage.
4427 Comment out unused local. Fix pointer signedness problems.
4428
4429 * lread.c (openp): Don't stuff size_t into an 'int'.
4430 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4431 about possible signed overflow.
4432
4433 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4434 (GDK_KEY_g): Don't define if already defined.
4435 (xg_prepare_tooltip): Avoid pointer signedness problem.
4436 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4437
4438 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4439 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4440
4441 * xfns.c (Fx_window_property): Simplify a bit,
4442 to make a bit faster and to avoid GCC 4.6.0 warning.
4443 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4444
4445 * fns.c (internal_equal): Don't assume size_t fits in int.
4446
4447 * alloc.c (compact_small_strings): Tighten assertion a little.
4448
4449 Replace pEd with more-general pI, and fix some printf arg casts.
4450 * lisp.h (pI): New macro, generalizing old pEd macro to other
4451 conversion specifiers. For example, use "...%"pI"d..." rather
4452 than "...%"pEd"...".
4453 (pEd): Remove. All uses replaced with similar uses of pI.
4454 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4455 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4456 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4457 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4458 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4459 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4460 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4461 64-bit hosts.
4462 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4463 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4464 * print.c (safe_debug_print, print_object): Likewise.
4465 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4466 to int.
4467 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4468 avoiding the 0 flag, which is not portable.
4469 * process.c (Fmake_network_process): Use pI to avoid cast.
4470 * region-cache.c (pp_cache): Likewise.
4471 * xdisp.c (decode_mode_spec): Likewise.
4472 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4473 behavior on 64-bit hosts with printf arg.
4474 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4475 (x_stop_queuing_selection_requests): Likewise.
4476 (x_get_window_property): Don't truncate byte count to an 'int'
4477 when tracing.
4478
4479 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4480 here, since it parses constructs like leading '-' and spaces,
4481 which are not wanted; and it overflows with large numbers.
4482 Instead, simply match F[0-9]+, which is what is wanted anyway.
4483
4484 * alloc.c: Remove unportable assumptions about struct layout.
4485 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4486 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4487 (allocate_vectorlike, make_pure_vector): Use the new macros,
4488 plus offsetof, to remove unportable assumptions about struct layout.
4489 These assumptions hold on all porting targets that I know of, but
4490 they are not guaranteed, they're easy to remove, and removing them
4491 makes further changes easier.
4492
4493 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4494 This doesn't fix a bug but makes the code clearer.
4495 (string_overrun_cookie): Now const. Use initializers that
4496 don't formally overflow signed char, to avoid warnings.
4497 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4498 can cause Emacs to crash when string overrun checking is enabled.
4499 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4500 multiple of sizeof (EMACS_INT); it need not be, if
4501 alignof(EMACS_INT) < sizeof (EMACS_INT).
4502 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4503
4504 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4505
4506 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4507
4508 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4509
4510 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4511 supposed to be handshaking. (Bug#8556)
4512 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4513
4514 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4515
4516 * lisp.h (Qdebug): List symbol.
4517 * eval.c (Qdebug): Restore global linkage.
4518 * keyboard.c (debug-on-event): New variable.
4519 (handle_user_signal): Break into debugger when debug-on-event
4520 matches the current signal symbol.
4521
4522 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4523
4524 * alloc.c (check_sblock, check_string_bytes)
4525 (check_string_free_list): Convert to standard C.
4526
4527 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4528
4529 * w32.c (emacs_gnutls_push): Fix typo.
4530
4531 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4532
4533 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4534 "cast to pointer from integer of different size".
4535
4536 Improve doprnt and its use in verror. (Bug#8545)
4537 * doprnt.c (doprnt): Document the set of format control sequences
4538 supported by the function. Use SAFE_ALLOCA instead of always
4539 using `alloca'.
4540
4541 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4542 is one byte too soon. Don't use xrealloc; instead xfree and
4543 xmalloc anew.
4544
4545 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4546
4547 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4548 callbacks stage.
4549
4550 * gnutls.c: Renamed global_initialized to
4551 gnutls_global_initialized. Added internals for the
4552 :verify-hostname-error, :verify-error, and :verify-flags
4553 parameters of `gnutls-boot' and documented those parameters in the
4554 docstring. Start callback support.
4555 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4556 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4557 on error. Return error code.
4558 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4559 (emacs_gnutls_read): Likewise.
4560 (Fgnutls_boot): Return handshake error code.
4561 (emacs_gnutls_handle_error): New function.
4562 (wsaerror_to_errno): Likewise.
4563
4564 * w32.h (emacs_gnutls_pull): Add prototype.
4565 (emacs_gnutls_push): Likewise.
4566
4567 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4568 (emacs_gnutls_push): Likewise.
4569
4570 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4571
4572 * process.c (wait_reading_process_output): Check if GnuTLS
4573 buffered some data internally if no FDs are set for TLS
4574 connections.
4575
4576 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4577 (LIBS): Link to USER_LIBS.
4578 ($(BLD)/gnutls.$(0)): New target.
4579
4580 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4581
4582 * xdisp.c (handle_single_display_spec): Rename the
4583 display_replaced_before_p argument into display_replaced_p, to
4584 make it consistent with the commentary. Fix typos in the
4585 commentary.
4586
4587 * textprop.c (syms_of_textprop): Remove dead code.
4588 (copy_text_properties): Delete obsolete commentary about an
4589 interface that was deleted long ago. Fix typos in the description
4590 of arguments.
4591
4592 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4593 to changes in oldXMenu/XMenu.h from 2011-04-16.
4594 <menu_help_message, prev_menu_help_message>: Constify.
4595 (IT_menu_make_room): menu->help_text is now `const char **';
4596 adjust.
4597
4598 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4599 to changes in oldXMenu/XMenu.h from 2011-04-16.
4600 (struct XMenu): Declare `help_text' `const char **'.
4601
4602 * xfaces.c <Qunspecified>: Make extern again.
4603
4604 * syntax.c: Include sys/types.h before including regex.h, as
4605 required by Posix.
4606
4607 * doc.c (get_doc_string): Improve the format passed to `error'.
4608
4609 * doprnt.c (doprnt): Improve commentary.
4610
4611 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4612
4613 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4614 them with etags.
4615
4616 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4617 changes in globals.h immediately force recompilation.
4618 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4619 $(CURDIR)/s/ms-w32.h.
4620 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4621
4622 * character.c (Fchar_direction): Function deleted.
4623 (syms_of_character): Don't defsubr it.
4624 <char-direction-table>: Deleted.
4625
4626 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4627
4628 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4629 * doprnt.c: Include limits.h.
4630 (SIZE_MAX): New macro.
4631 (doprnt): Return a size_t value. 2nd arg is now size_t.
4632 Many local variables are now size_t instead of int or unsigned.
4633 Improve overflow protection. Support `l' modifier for integer
4634 conversions. Support %l conversion. Don't assume an EMACS_INT
4635 argument for integer conversions and for %c.
4636
4637 * lisp.h (doprnt): Restore prototype.
4638
4639 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4640 $(SRC)/character.h.
4641
4642 * Makefile.in (base_obj): Add back doprnt.o.
4643
4644 * deps.mk (doprnt.o): Add back prerequisites.
4645 (callint.o): Depend on character.h.
4646
4647 * eval.c (internal_lisp_condition_case): Include the handler
4648 representation in the error message.
4649 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4650 when breaking from the loop.
4651
4652 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4653
4654 * callint.c (Fcall_interactively): When displaying error message
4655 about invalid control letter, pass the character's codepoint, not
4656 a pointer to its multibyte form. Improve display of the character
4657 in octal and display also its hex code.
4658
4659 * character.c (char_string): Use %x to display the (unsigned)
4660 codepoint of an invalid character, to avoid displaying a bogus
4661 negative value.
4662
4663 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4664 `error', not SYMBOL_NAME itself.
4665
4666 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4667 character arguments to `error'.
4668
4669 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4670 to `error' in error message about FINAL_CHAR argument. Make sure
4671 FINAL_CHAR is a character, and use %c when it is passed as
4672 argument to `error'.
4673
4674 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4675
4676 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4677
4678 * w32.c: Include <time.h>.
4679 (sys_localtime): New function.
4680
4681 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4682
4683 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4684
4685 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4686
4687 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4688
4689 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4690 zombies (Bug#8467).
4691
4692 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4693
4694 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4695 gl_state.e_property when gl_state.object is Qt.
4696
4697 * insdel.c (make_gap_larger): Remove limitation of buffer size
4698 to <= INT_MAX.
4699
4700 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4701
4702 * xdisp.c (lookup_glyphless_char_display)
4703 (produce_glyphless_glyph): Handle cons cell entry in
4704 glyphless-char-display.
4705 (Vglyphless_char_display): Document it.
4706
4707 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4708 glyphless-char-display.
4709
4710 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4711
4712 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4713
4714 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4715
4716 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4717 definition for no-X builds.
4718
4719 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4720
4721 Static checks with GCC 4.6.0 and non-default toolkits.
4722
4723 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4724
4725 * process.c (keyboard_bit_set): Define only if SIGIO.
4726 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4727 (send_process): Repair possible setjmp clobbering.
4728
4729 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4730
4731 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4732
4733 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4734
4735 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4736 Define only if needed.
4737
4738 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4739 by pacifying GCC about it. Maybe it's time to retire it?
4740 * xfaces.c (USG, __TIMEVAL__): Likewise.
4741
4742 * dispextern.h (struct redisplay_interface): Rename param
4743 to avoid shadowing.
4744 * termhooks.h (struct terminal): Likewise.
4745 * xterm.c (xembed_send_message): Likewise.
4746
4747 * insdel.c (make_gap_smaller): Define only if
4748 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4749
4750 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4751 it.
4752
4753 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4754 so that we aren't warned about unused symbols.
4755
4756 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4757
4758 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4759
4760 * xfns.c (x_real_positions): Mark locals as initialized.
4761
4762 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4763
4764 * xterm.c: Fix problems found by static analysis with other toolkits.
4765 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4766 (x_dispatch_event): Declare static if USE_GTK, and
4767 define if USE_GTK || USE_X_TOOLKIT.
4768 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4769 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4770 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4771 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4772
4773 * xmenu.c (menu_help_callback): Pointer type fixes.
4774 Use const pointers when pointing at readonly data. Avoid pointer
4775 signedness clashes.
4776 (FALSE): Remove unused macro.
4777 (update_frame_menubar): Remove unused decl.
4778
4779 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4780
4781 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4782 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4783 (single_menu_item): Rename local to avoid shadowing.
4784
4785 * keyboard.c (make_lispy_event): Remove unused local var.
4786
4787 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4788 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4789
4790 * bitmaps: Change bitmaps from unsigned char back to the X11
4791 compatible char. Avoid the old compiler warnings about
4792 out-of-range initializers by using, for example, '\xab' rather
4793 than 0xab.
4794
4795 * xgselect.c (xgselect_initialize): Check vs interface
4796 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4797
4798 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4799
4800 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4801 to read-only memory.
4802
4803 * fns.c (vector): Remove; this old hack is no longer needed.
4804
4805 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4806 Remove unused var.
4807 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4808
4809 * xrdb.c (x_load_resources): Omit unused local.
4810
4811 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4812 (x_window): Rename locals to avoid shadowing.
4813 (USG): Use the kludged USG macro, to pacify gcc.
4814
4815 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4816 (x_term_init): Remove local to avoid shadowing.
4817
4818 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4819
4820 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4821 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4822
4823 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4824
4825 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4826
4827 Fix regex.c, syntax.c and friends for buffers > 2GB.
4828 * syntax.h (struct gl_state_s): Declare character position members
4829 EMACS_INT.
4830
4831 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4832
4833 * textprop.c (verify_interval_modification, interval_of):
4834 Declare arguments EMACS_INT.
4835
4836 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4837 EMACS_INT.
4838
4839 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4840
4841 * indent.c (Fvertical_motion): Local variable it_start is now
4842 EMACS_INT.
4843
4844 * regex.c (re_match, re_match_2, re_match_2_internal)
4845 (bcmp_translate, regcomp, regexec, print_double_string)
4846 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4847 (re_compile_pattern, re_exec): Declare arguments and local
4848 variables `size_t' and `ssize_t' and return values `regoff_t', as
4849 appropriate.
4850 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4851 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4852 <compile_stack_type>: `size' and `avail' are now `size_t'.
4853
4854 * regex.h <regoff_t>: Use ssize_t, not int.
4855 (re_search, re_search_2, re_match, re_match_2): Arguments that
4856 specify buffer/string position and length are now ssize_t and
4857 size_t. Return type is regoff_t.
4858
4859 2011-04-16 Ben Key <bkey76@gmail.com>
4860
4861 * nsfont.m: Fixed bugs in ns_get_family and
4862 ns_descriptor_to_entity that were caused by using free to
4863 deallocate memory blocks that were allocated by xmalloc (via
4864 xstrdup). This caused Emacs to crash when compiled with
4865 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4866 --enable-checking=xmallocoverrun). xfree is now used to
4867 deallocate these memory blocks.
4868
4869 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4870
4871 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4872
4873 emacs_write: Accept and return EMACS_INT for sizes.
4874 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4875 et seq.
4876 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4877 Accept and return EMACS_INT.
4878 (emacs_gnutls_write): Return the number of bytes written on
4879 partial writes.
4880 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4881 (emacs_read, emacs_write): Remove check for negative size, as the
4882 Emacs source code has been audited now.
4883 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4884 (emacs_read, emacs_write): Use it.
4885 * process.c (send_process): Adjust to the new signatures of
4886 emacs_write and emacs_gnutls_write. Do not attempt to store
4887 a byte offset into an 'int'; it might overflow.
4888 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4889
4890 * sound.c: Don't assume sizes fit in 'int'.
4891 (struct sound_device.period_size, alsa_period_size):
4892 Return EMACS_INT, not int.
4893 (struct sound_device.write, vox_write, alsa_write):
4894 Accept EMACS_INT, not int.
4895 (wav_play, au_play): Use EMACS_INT to store sizes and to
4896 record read return values.
4897
4898 2011-04-15 Ben Key <bkey76@gmail.com>
4899
4900 * keyboard.c (Qundefined): Don't declare static since it is used
4901 in nsfns.m.
4902 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4903 static since they are used in nsfont.m.
4904
4905 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4906
4907 * process.c (Qprocessp): Don't declare static.
4908 * lisp.h (Qprocessp): Declare again.
4909
4910 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4911
4912 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4913
4914 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4915
4916 Improve C-level modularity by making more things 'static'.
4917
4918 Don't publish debugger-only interfaces to other modules.
4919 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4920 (verify_bytepos, count_markers): Move decls to the only modules
4921 that need them.
4922 * region-cache.h (pp_cache): Likewise.
4923 * window.h (check_all_windows): Likewise.
4924 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4925
4926 * sysdep.c (croak): Now static, if
4927 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4928 * syssignal.h (croak): Declare only if not static.
4929
4930 * alloc.c (refill_memory_reserve): Now static if
4931 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4932 * lisp.h (refill_memory_reserve): Declare only if not static.
4933
4934 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4935 Define only if USE_LUCID.
4936
4937 * xrdb.c (x_customization_string, x_rm_string): Now static.
4938
4939 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4940 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4941
4942 * xdisp.c (draw_row_with_mouse_face): Now static.
4943 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4944
4945 * window.h (check_all_windows): Mark externally visible.
4946
4947 * window.c (window_deletion_count): Now static.
4948
4949 * undo.c: Make symbols static if they're not exported.
4950 (last_undo_buffer, last_boundary_position, pending_boundary):
4951 Now static.
4952
4953 * textprop.c (interval_insert_behind_hooks): Now static.
4954 (interval_insert_in_front_hooks): Likewise.
4955
4956 * term.c: Make symbols static if they're not exported.
4957 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4958 (max_frame_lines, tty_set_terminal_modes):
4959 (tty_reset_terminal_modes, tty_turn_off_highlight):
4960 (get_tty_terminal): Now static.
4961 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4962 * termhooks.h (term_mouse_moveto): Do not declare if
4963 HAVE_WINDOW_SYSTEM.
4964 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4965 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4966
4967 * sysdep.c: Make symbols static if they're not exported.
4968 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4969 Now static.
4970 (sigprocmask_set, full_mask): Remove; unused.
4971 (wait_debugging): Mark as visible.
4972 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4973 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4974
4975 * syntax.c (syntax_temp): Define only if !__GNUC__.
4976
4977 * sound.c (current_sound_device, current_sound): Now static.
4978
4979 * search.c (searchbufs, searchbuf_head): Now static.
4980
4981 * scroll.c (scroll_cost): Remove; unused.
4982 * dispextern.h (scroll_cost): Remove decl.
4983
4984 * region-cache.h (pp_cache): Mark as externally visible.
4985
4986 * process.c: Make symbols static if they're not exported.
4987 (process_tick, update_tick, create_process, chan_process):
4988 (Vprocess_alist, proc_buffered_char, datagram_access):
4989 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4990 (deactivate_process): Mark defn as static, as well as decl.
4991 * lisp.h (create_process): Remove decl.
4992 * process.h (chan_process, Vprocess_alist): Remove decls.
4993
4994 * print.c: Make symbols static if they're not exported.
4995 (print_depth, new_backquote_output, being_printed, print_buffer):
4996 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4997 (print_interval, print_number_index, initial_stderr_stream):
4998 Now static.
4999 * lisp.h (Fprinc): Remove decl.
5000 (debug_output_compilation_hack): Mark as externally visible.
5001
5002 * sysdep.c (croak): Move decl from here to syssignal.h.
5003 * syssignal.h (croak): Put it here, so the API can be checked when
5004 'croak' is called from dissociate_if_controlling_tty.
5005
5006 * minibuf.c: Make symbols static if they're not exported.
5007 (minibuf_save_list, choose_minibuf_frame): Now static.
5008 * lisp.h (choose_minibuf_frame): Remove decl.
5009
5010 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5011
5012 * lread.c: Make symbols static if they're not exported.
5013 (read_objects, initial_obarray, oblookup_last_bucket_number):
5014 Now static.
5015 (make_symbol): Remove; unused.
5016 * lisp.h (initial_obarray, make_symbol): Remove decls.
5017
5018 * keyboard.c: Make symbols static if they're not exported.
5019 (single_kboard, recent_keys_index, total_keys, recent_keys):
5020 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5021 (this_single_command_key_start, echoing, last_auto_save):
5022 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5023 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5024 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5025 (Vlispy_mouse_stem, double_click_count):
5026 Now static.
5027 (force_auto_save_soon): Define only if SIGDANGER.
5028 (ignore_mouse_drag_p): Now static if
5029 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5030 (print_help): Remove; unused.
5031 (stop_character, last_timer_event): Mark as externally visible.
5032 * keyboard.h (ignore_mouse_drag_p): Declare only if
5033 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5034 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5035 * lisp.h (echoing): Remove decl.
5036 (force_auto_save_soon): Declare only if SIGDANGER.
5037 * xdisp.c (redisplay_window): Simplify code, to make it more
5038 obvious that ignore_mouse_drag_p is not accessed if !defined
5039 USE_GTK && !defined HAVE_NS.
5040
5041 * intervals.c: Make symbols static if they're not exported.
5042 (merge_properties_sticky, merge_interval_right, delete_interval):
5043 Now static.
5044 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5045
5046 * insdel.c: Make symbols static if they're not exported.
5047 However, leave prepare_to_modify_buffer alone. It's never
5048 called from outside this function, but that appears to be a bug.
5049 (combine_after_change_list, combine_after_change_buffer):
5050 (adjust_after_replace, signal_before_change): Now static.
5051 (adjust_after_replace_noundo): Remove; unused.
5052 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5053 (signal_before_change): Remove decls.
5054
5055 * indent.c (val_compute_motion, val_vmotion): Now static.
5056
5057 * image.c: Make symbols static if they're not exported.
5058 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5059 if USE_GTK.
5060 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5061 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5062
5063 * fringe.c (standard_bitmaps): Now static.
5064 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5065
5066 * frame.c: Make symbols static if they're not exported.
5067 (x_report_frame_params, make_terminal_frame): Now static.
5068 (get_frame_param): Now static, unless HAVE_NS.
5069 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5070 (x_get_resource_string): Remove; not used.
5071 * frame.h (make_terminal_frame, x_report_frame_params):
5072 (x_get_resource_string); Remove decls.
5073 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5074 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5075
5076 * font.c, fontset.c: Make symbols static if they're not exported.
5077 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5078 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5079 * font.c (font_close_object): Now static.
5080 * font.h (font_close_object): Remove.
5081 * fontset.c (FONTSET_OBJLIST): Remove.
5082 (free_realized_fontset) #if-0 the body, which does nothing.
5083 (face_suitable_for_char_p): #if-0, as it's never called.
5084 * fontset.h (face_suitable_for_char_p): Remove decl.
5085 * xfaces.c (face_at_string_position):
5086 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5087 since 0 is always ASCII.
5088
5089 * fns.c (weak_hash_tables): Now static.
5090
5091 * fileio.c: Make symbols static if they're not exported.
5092 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5093 (Vwrite_region_annotation_buffers): Now static.
5094
5095 * eval.c: Make symbols static if they're not exported.
5096 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5097 * lisp.h (backtrace_list): Remove decl.
5098
5099 * emacs.c: Make symbols static if they're not exported.
5100 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5101 (fatal_error_code, fatal_error_signal_hook, standard_args):
5102 Now static.
5103 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5104 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5105 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5106 * lisp.h (fatal_error_signal_hook): Remove decl.
5107 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5108
5109 * editfns.c: Move a (normally-unused) function to its only use.
5110 * editfns.c, lisp.h (get_operating_system_release): Remove.
5111 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5112 worth the hassle of breaking this out.
5113
5114 * xterm.c: Make symbols static if they're not exported.
5115 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5116 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5117 (x_destroy_window, x_delete_display):
5118 Now static.
5119 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5120 (x_mouse_leave): Remove; unused.
5121 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5122 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5123 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5124 Remove decls.
5125 (x_mouse_leave): Declare only if WINDOWSNT.
5126 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5127 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5128 USE_X_TOOLKIT.
5129
5130 * ftxfont.c: Make symbols static if they're not exported.
5131 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5132 HAVE_FREETYPE.
5133 * font.h (ftxfont_driver): Likewise.
5134
5135 * xfns.c: Make symbols static if they're not exported.
5136 (x_last_font_name, x_display_info_for_name):
5137 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5138 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5139 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5140 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5141 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5142 (last_show_tip_args): Now static.
5143 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5144 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5145 (x_screen_planes): Remove; unused.
5146 * dispextern.h (x_screen_planes): Remove decl.
5147
5148 * dispnew.c: Make symbols static if they're not exported.
5149 * dispextern.h (redraw_garbaged_frames, scrolling):
5150 (increment_row_positions): Remove.
5151 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5152 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5153 Now static.
5154 (redraw_garbaged_frames): Remove; unused.
5155
5156 * xfaces.c: Make symbols static if they're not exported.
5157 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5158 Remove decls.
5159 * xterm.h (defined_color): Remove decls.
5160 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5161 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5162 (menu_face_changed_default, defined_color, free_realized_face):
5163 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5164 (ascii_face_of_lisp_face): Remove; unused.
5165
5166 * xdisp.c: Make symbols static if they're not exported.
5167 * dispextern.h (scratch_glyph_row, window_box_edges):
5168 (glyph_to_pixel_coords, set_cursor_from_row):
5169 (get_next_display_element, set_iterator_to_next):
5170 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5171 (show_mouse_face): Remove decls
5172 * frame.h (message_buf_print): Likewise.
5173 * lisp.h (pop_message, set_message, check_point_in_composition):
5174 Likewise.
5175 * xterm.h (set_vertical_scroll_bar): Likewise.
5176 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5177 (message_buf_print, scratch_glyph_row, displayed_buffer):
5178 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5179 (get_next_display_element, show_mouse_face, window_box_edges):
5180 (frame_to_window_pixel_xy, check_point_in_composition):
5181 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5182 (glyph_to_pixel_coords): Remove; unused.
5183
5184 * dired.c (file_name_completion): Now static.
5185
5186 * dbusbind.c (xd_in_read_queued_messages): Now static.
5187
5188 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5189 * data.c (circular_list_error): Remove.
5190
5191 * commands.h (last_point_position, last_point_position_buffer):
5192 (last_point_position_window): Remove decls.
5193 * keyboard.c: Make these variables static.
5194
5195 * coding.h (coding, code_convert_region, encode_coding_gap):
5196 Remove decls.
5197 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5198 (iso_code_class, detect_coding, code_convert_region): Now static.
5199 (encode_coding_gap): Remove; unused.
5200
5201 * chartab.c (chartab_chars, chartab_bits): Now static.
5202
5203 * charset.h (charset_iso_8859_1): Remove decl.
5204 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5205 Now static.
5206
5207 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5208 * ccl.c (Vccl_program_table): Now static.
5209 (check_ccl_update): Remove; unused.
5210
5211 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5212 * category.h: ... from here.
5213 * category.c (check_category_table, set_category_set): Now static.
5214
5215 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5216 * lisp.h: Remove these decls.
5217
5218 * buffer.c (buffer_count): Remove unused var.
5219
5220 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5221 so that it's not optimized away.
5222 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5223 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5224 exported only to the debugger.
5225
5226 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5227 * atimer.h (run_all_atimers): Remove; not exported.
5228
5229 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5230 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5231 was inaccessible from Lisp.
5232 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5233 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5234
5235 alloc.c: Import and export fewer symbols, and remove unused items.
5236 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5237 is defined.
5238 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5239 it's not optimized away by whole-program optimization.
5240 (message_enable_multibyte, free_misc): Remove.
5241 (catchlist, handlerlist, mark_backtrace):
5242 Declare only if BYTE_MARK_STACK.
5243 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5244 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5245 (message_enable_multibyte): Remove decl.
5246 (free_misc, interval_free_list, float_block, float_block_index):
5247 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5248 (cons_free_list, last_marked_index):
5249 Now static.
5250 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5251 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5252 (mark_backtrace): Define only if BYTE_MARK_STACK.
5253 * xdisp.c (message_enable_multibyte): Now static.
5254
5255 Declare Lisp_Object Q* variables to be 'static' if not exported.
5256 This makes it easier for human readers (and static analyzers)
5257 to see whether these variables are used from other modules.
5258 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5259 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5260 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5261 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5262 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5263 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5264 * xmenu.c, xselect.c:
5265 Declare Q* vars static if they are not used in other modules.
5266 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5267 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5268 Remove decls of unexported vars.
5269 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5270
5271 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5272
5273 Make Emacs functions such as Fatom 'static' by default.
5274 This makes it easier for human readers (and static analyzers)
5275 to see whether these functions can be called from other modules.
5276 DEFUN now defines a static function. To make the function external
5277 so that it can be used in other C modules, use the new macro DEFUE.
5278 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5279 (Finit_image_library):
5280 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5281 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5282 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5283 Remove decls, since these functions are now static.
5284 (Funintern, Fget_internal_run_time): New decls, since these functions
5285 were already external.
5286
5287 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5288 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5289 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5290 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5291 * keyboard.c, keymap.c, lread.c:
5292 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5293 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5294 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5295 Mark functions with DEFUE instead of DEFUN,
5296 if they are used in other modules.
5297 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5298 decls for now-static functions.
5299 * buffer.h (Fdelete_overlay): Remove decl.
5300 * callproc.c (Fgetenv_internal): Mark as internal.
5301 * composite.c (Fremove_list_of_text_properties): Remove decl.
5302 (Fcomposition_get_gstring): New forward static decl.
5303 * composite.h (Fcomposite_get_gstring): Remove decl.
5304 * dired.c (Ffile_attributes): New forward static decl.
5305 * doc.c (Fdocumntation_property): New forward static decl.
5306 * eval.c (Ffetch_bytecode): New forward static decl.
5307 (Funintern): Remove extern decl; now in .h file where it belongs.
5308 * fileio.c (Fmake_symbolic_link): New forward static decl.
5309 * image.c (Finit_image_library): New forward static decl.
5310 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5311 * intervals.h (Fprevious_property_change):
5312 (Fremove_list_of_text_properties): Remove decls.
5313 * keyboard.c (Fthis_command_keys): Remove decl.
5314 (Fcommand_execute): New forward static decl.
5315 * keymap.c (Flookup_key): New forward static decl.
5316 (Fcopy_keymap): Now static.
5317 * keymap.h (Flookup_key): Remove decl.
5318 * process.c (Fget_process): New forward static decl.
5319 (Fprocess_datagram_address): Mark as internal.
5320 * syntax.c (Fsyntax_table_p): New forward static decl.
5321 (skip_chars): Remove duplicate decl.
5322 * textprop.c (Fprevious_property_change): New forward static decl.
5323 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5324 Now internal.
5325 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5326 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5327
5328 * editfns.c (Fformat): Remove unreachable code.
5329
5330 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5331
5332 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5333 change. (Bug#8496)
5334
5335 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5336
5337 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5338 when at ZV. (Bug#8487)
5339
5340 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5341
5342 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5343 (Bug#8437)
5344 * keyboard.c (parse_tool_bar_item): Likewise.
5345 * sound.c (sound_cleanup, alsa_close): Likewise.
5346 * termcap.c (tgetent): Likewise.
5347 * xfns.c (x_default_font_parameter): Likewise.
5348 * xsettings.c (read_and_apply_settings): Likewise.
5349
5350 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5351 (overrun_check_free): Protoize.
5352
5353 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5354
5355 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5356 since callers should never pass a negative size.
5357 Change the signature to match that of plain 'read' and 'write'; see
5358 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5359 * lisp.h: Update prototypes of emacs_write and emacs_read.
5360
5361 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5362
5363 * xdisp.c (redisplay_window): Don't try to determine the character
5364 position of the scroll margin if the window start point w->startp
5365 is outside the buffer's accessible region. (Bug#8468)
5366
5367 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5368
5369 Fix write-region and its subroutines for buffers > 2GB.
5370 * fileio.c (a_write, e_write): Modify declaration of arguments and
5371 local variables to support buffers larger than 2GB.
5372 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5373
5374 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5375 argument, local variables, and return value.
5376
5377 * lisp.h: Update prototypes of emacs_write and emacs_read.
5378
5379 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5380
5381 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5382
5383 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5384
5385 Fix more problems found by GCC 4.6.0's static checks.
5386
5387 * xdisp.c (vmessage): Use a better test for character truncation.
5388
5389 * charset.c (load_charset_map): <, not <=, for optimization,
5390 and to avoid potential problems with integer overflow.
5391 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5392 * casetab.c (set_identity, shuffle): Likewise.
5393 * editfns.c (Fformat): Likewise.
5394 * syntax.c (skip_chars): Likewise.
5395
5396 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5397 This also lets GCC 4.6.0 generate slightly better loop code.
5398
5399 * callint.c (Fcall_interactively): <, not <=, for optimization.
5400 (Fcall_interactively): Count the number of arguments produced,
5401 not the number of arguments given. This is simpler and lets GCC
5402 4.6.0 generate slightly better code.
5403
5404 * ftfont.c: Distingish more carefully between FcChar8 and char.
5405 The previous code passed unsigned char * to a functions like
5406 strlen and xstrcasecmp that expect char *, which does not
5407 conform to the C standard.
5408 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5409 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5410 char * when the C standard requires it.
5411
5412 * keyboard.c (read_char): Remove unused var.
5413
5414 * eval.c: Port to Windows vsnprintf (Bug#8435).
5415 Include <limits.h>.
5416 (SIZE_MAX): Define if the headers do not.
5417 (verror): Do not give up if vsnprintf returns a negative count.
5418 Instead, grow the buffer. This ports to Windows vsnprintf, which
5419 does not conform to C99. Problem reported by Eli Zaretskii.
5420 Also, simplify the allocation scheme, by avoiding the need for
5421 calling realloc, and removing the ALLOCATED variable.
5422
5423 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5424
5425 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5426 But keep the doprint source code for now, as we might revamp it
5427 and use it again (Bug#8435).
5428 * lisp.h (doprnt): Remove.
5429 * Makefile.in (base_obj): Remove doprnt.o.
5430 * deps.mk (doprnt.o): Remove.
5431
5432 error: Print 32- and 64-bit integers portably (Bug#8435).
5433 Without this change, on typical 64-bit hosts error ("...%d...", N)
5434 was used to print both 32- and 64-bit integers N, which relied on
5435 undefined behavior.
5436 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5437 New macro.
5438 * lisp.h (error, verror): Mark as printf-like functions.
5439 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5440 Report overflow in size calculations when allocating printf buffer.
5441 Do not truncate output string at its first null byte.
5442 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5443 Truncate the output at a character boundary, since vsnprintf does not
5444 do that.
5445 * charset.c (check_iso_charset_parameter): Convert internal
5446 character to string before calling 'error', since %c now has the
5447 printf meaning.
5448 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5449 overflow when computing char to be passed to 'error'. Do not
5450 pass Lisp_Object to 'error'; pass the integer instead.
5451 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5452 formatted with plain %d.
5453
5454 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5455
5456 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5457
5458 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5459
5460 * xterm.c (x_catch_errors): Remove duplicate declaration.
5461
5462 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5463
5464 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5465
5466 2011-04-10 Jim Meyering <meyering@redhat.com>
5467
5468 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5469 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5470 return ssize_t not "int", and use size_t as the buffer length.
5471 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5472 * gnutls.h: Update declarations.
5473 * process.c (read_process_output): Use ssize_t, to match.
5474 (send_process): Likewise.
5475
5476 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5477
5478 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5479
5480 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5481
5482 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5483 Use unsigned char, to match FcChar8 type definition.
5484
5485 * xterm.c (handle_one_xevent):
5486 * xmenu.c (create_and_show_popup_menu):
5487 * xselect.c (x_decline_selection_request)
5488 (x_reply_selection_request): Avoid type-punned deref of X events.
5489
5490 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5491
5492 Fix some uses of `int' instead of EMACS_INT.
5493 * search.c (string_match_1, fast_string_match)
5494 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5495 (scan_buffer, find_next_newline_no_quit)
5496 (find_before_next_newline, search_command, Freplace_match)
5497 (Fmatch_data): Make some `int' variables be EMACS_INT.
5498
5499 * xdisp.c (display_count_lines): 3rd argument and return value now
5500 EMACS_INT. All callers changed.
5501 (pint2hrstr): Last argument is now EMACS_INT.
5502
5503 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5504 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5505 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5506 (decode_coding_utf_16, decode_coding_emacs_mule)
5507 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5508 (decode_coding_ccl, decode_coding_charset)
5509 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5510 (decode_coding_iso_2022, decode_coding_emacs_mule)
5511 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5512 <char_offset, last_offset>: Declare EMACS_INT.
5513 (encode_coding_utf_8, encode_coding_utf_16)
5514 (encode_coding_emacs_mule, encode_invocation_designation)
5515 (encode_designation_at_bol, encode_coding_iso_2022)
5516 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5517 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5518 Declare EMACS_INT.
5519 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5520 (encode_invocation_designation): Last argument P_NCHARS is now
5521 EMACS_INT.
5522 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5523 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5524
5525 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5526 All users changed.
5527
5528 * ccl.c (Fccl_execute_on_string): Declare some variables
5529 EMACS_INT.
5530
5531 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5532
5533 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5534
5535 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5536
5537 * process.c (Fformat_network_address): Doc fix.
5538
5539 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5540
5541 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5542
5543 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5544
5545 * keyboard.c (read_char): Call Lisp function help-form-show,
5546 instead of using internal_with_output_to_temp_buffer.
5547 (Qhelp_form_show): New var.
5548 (syms_of_keyboard): Use DEFSYM macro.
5549
5550 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5551
5552 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5553
5554 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5555
5556 * process.c (Flist_processes): Remove to Lisp.
5557 (list_processes_1): Delete.
5558
5559 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5560
5561 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5562
5563 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5564
5565 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5566
5567 Fix more problems found by GCC 4.6.0's static checks.
5568
5569 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5570
5571 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5572
5573 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5574
5575 * xdisp.c (vmessage): Mark as a printf-like function.
5576
5577 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5578
5579 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5580
5581 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5582 printf-like functions.
5583 (tiff_load): Add casts to remove these marks before passing them
5584 to system-supplied API.
5585
5586 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5587
5588 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5589 This avoids several warnings with gcc -Wstrict-overflow.
5590 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5591 directly, rather than having caller test rule sign. This avoids
5592 some unnecessary tests.
5593 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5594 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5595 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5596
5597 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5598 (xfont_open): Avoid unnecessary tests.
5599
5600 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5601
5602 * composite.h, composite.c (composition_gstring_put_cache):
5603 Use EMACS_INT, not int, for length.
5604
5605 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5606 breaking out part of COMPOSITION_DECODE_RULE.
5607 (COMPOSITION_DECODE_RULE): Use it.
5608 * composite.c (get_composition_id): Remove unused local vars,
5609 by using the new macro.
5610
5611 * textprop.c (set_text_properties_1): Change while to do-while,
5612 since the condition is always true at first.
5613
5614 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5615 (interval_deletion_adjustment): Return unsigned value.
5616 All uses changed.
5617
5618 * process.c (list_processes_1, create_pty, read_process_output):
5619 (exec_sentinel): Remove vars that were set but not used.
5620 (create_pty): Remove unnecessary "volatile"s.
5621 (Fnetwork_interface_info): Avoid possibility of int overflow.
5622 (read_process_output): Do adaptive read buffering even if carryover.
5623 (read_process_output): Simplify nbytes computation if buffered.
5624
5625 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5626
5627 * syntax.c (scan_words): Remove var that was set but not used.
5628 (update_syntax_table): Use unsigned instead of int.
5629
5630 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5631 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5632 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5633
5634 * print.c (print_error_message): Avoid int overflow.
5635
5636 * font.c (font_list_entities): Redo for clarity,
5637 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5638
5639 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5640 (font_score): Avoid potential overflow in diff calculation.
5641
5642 * fns.c (substring_both): Remove var that is set but not used.
5643 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5644
5645 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5646
5647 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5648 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5649 can always succeed if overflow has undefined behavior.
5650
5651 * search.c (boyer_moore, wordify): Remove vars set but not used.
5652 (wordify): Omit three unnecessary tests.
5653
5654 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5655 All callers changed. This avoids the need for an unused var.
5656
5657 * casefiddle.c (casify_region): Remove var that is set but not used.
5658
5659 * dired.c (file_name_completion): Remove var that is set but not used.
5660
5661 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5662
5663 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5664 (Finsert_file_contents): Remove unnecessary code checking fd.
5665
5666 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5667 Check for integer overflow on size calculations.
5668
5669 * buffer.c (Fprevious_overlay_change): Remove var that is set
5670 but not used.
5671
5672 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5673 Remove vars that are set but not used.
5674 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5675 (timer_check_2): Mark vars as initialized.
5676
5677 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5678
5679 * image.c (lookup_image): Remove var that is set but not used.
5680 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5681
5682 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5683 that are set but not used.
5684
5685 * xfns.c (make_invisible_cursor): Don't return garbage
5686 if XCreateBitmapFromData fails (Bug#8410).
5687
5688 * xselect.c (x_get_local_selection, x_handle_property_notify):
5689 Remove vars that are set but not used.
5690
5691 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5692 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5693
5694 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5695 Remove var that is set but not used.
5696 (scroll_bar_windows_size): Now size_t, not int.
5697 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5698 Check for overflow.
5699
5700 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5701 (map_tty_color) [!defined MSDOS]: Likewise.
5702
5703 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5704
5705 * coding.c: Remove vars that are set but not used.
5706 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5707 All callers changed.
5708 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5709 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5710 (decode_coding_charset): Remove vars that are set but not used.
5711
5712 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5713 that is set but not used.
5714
5715 * print.c (print_object): Remove var that is set but not used.
5716
5717 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5718 The gnulib version avoids calling malloc in the usual case,
5719 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5720 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5721 * filelock.c (current_lock_owner): Likewise.
5722 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5723 * sysdep.c: Include allocator.h, careadlinkat.h.
5724 (emacs_no_realloc_allocator): New static constant.
5725 (emacs_readlink): New function.
5726 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5727 ../lib/careadlinkat.h.
5728
5729 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5730
5731 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5732 first non-nil return value).
5733
5734 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5735
5736 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5737 if not defined (Bug#8403).
5738
5739 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5740
5741 * xdisp.c (display_count_lines): Remove parameter `start',
5742 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5743 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5744 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5745 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5746 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5747 and thereabouts. All callers changed.
5748 (get_per_char_metric): Remove parameter `f', unused since
5749 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5750
5751 2011-04-02 Jim Meyering <meyering@redhat.com>
5752
5753 do not dereference NULL upon failed strdup
5754 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5755 (ns_get_family): Likewise.
5756
5757 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5758
5759 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5760
5761 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5762
5763 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5764 later (Bug#8403).
5765
5766 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5767
5768 Add lexical binding.
5769
5770 * window.c (Ftemp_output_buffer_show): New fun.
5771 (Fsave_window_excursion):
5772 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5773
5774 * lread.c (lisp_file_lexically_bound_p): New function.
5775 (Fload): Bind Qlexical_binding.
5776 (readevalloop): Remove `evalfun' arg.
5777 Bind Qinternal_interpreter_environment.
5778 (Feval_buffer): Bind Qlexical_binding.
5779 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5780 Mark as dynamic.
5781 (syms_of_lread): Declare `lexical-binding'.
5782
5783 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5784
5785 * keyboard.c (eval_dyn): New fun.
5786 (menu_item_eval_property): Use it.
5787
5788 * image.c (parse_image_spec): Use Ffunctionp.
5789
5790 * fns.c (concat, mapcar1): Accept byte-code-functions.
5791
5792 * eval.c (Fsetq): Handle lexical vars.
5793 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5794 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5795 (FletX, Flet): Obey lexical binding.
5796 (Fcommandp): Handle closures.
5797 (Feval): New `lexical' arg.
5798 (eval_sub): New function extracted from Feval. Use it almost
5799 everywhere where Feval was used. Look up vars in lexical env.
5800 Handle closures.
5801 (Ffunctionp): Move from subr.el.
5802 (Ffuncall): Handle closures.
5803 (apply_lambda): Remove `eval_flags'.
5804 (funcall_lambda): Handle closures and new byte-code-functions.
5805 (Fspecial_variable_p): New function.
5806 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5807 but without exporting it to Lisp.
5808
5809 * doc.c (Fdocumentation, store_function_docstring):
5810 * data.c (Finteractive_form): Handle closures.
5811
5812 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5813 interactive spec.
5814
5815 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5816 New byte-codes.
5817 (exec_byte_code): New function extracted from Fbyte_code to handle new
5818 calling convention for byte-code-functions. Add new byte-codes.
5819
5820 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5821
5822 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5823
5824 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5825
5826 * xdisp.c (redisplay_internal): Fix prototype.
5827
5828 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5829
5830 * xdisp.c (SCROLL_LIMIT): New macro.
5831 (try_scrolling): Use it when setting scroll_limit.
5832 Limit scrolling to 100 screen lines.
5833 (redisplay_window): Even when falling back on "recentering",
5834 position point in the window according to scroll-conservatively,
5835 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5836
5837 (try_scrolling): When point is above the window, allow searching
5838 as far as scroll_max, or one screenful, to compute vertical
5839 distance from PT to the scroll margin position. This prevents
5840 try_scrolling from unnecessarily failing when
5841 scroll-conservatively is set to a value slightly larger than the
5842 window height. Clean up the case of PT below the margin at bottom
5843 of window: scroll_max can no longer be INT_MAX. When aggressive
5844 scrolling is in use, don't let point enter the opposite scroll
5845 margin as result of the scroll.
5846 (syms_of_xdisp) <scroll-conservatively>: Document the
5847 threshold of 100 lines for never-recentering scrolling.
5848
5849 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5850
5851 * dispextern.h (move_it_by_lines):
5852 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5853 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5854 (message_log_check_duplicate): Remove parameters `prev_bol' and
5855 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5856 (redisplay_internal): Remove parameter `preserve_echo_area',
5857 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5858
5859 * indent.c (Fvertical_motion):
5860 * window.c (window_scroll_pixel_based, Frecenter):
5861 Don't pass `need_y_p' to `move_it_by_lines'.
5862
5863 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5864
5865 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5866 steal a few bits to be more compact.
5867 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5868 Remove unneeded casts.
5869
5870 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5871
5872 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5873
5874 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5875 binding" message (bug#7967).
5876
5877 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5878
5879 Fix more problems found by GCC 4.6.0's static checks.
5880
5881 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5882 Remove unused local var.
5883
5884 * editfns.c (Fmessage_box): Remove unused local var.
5885
5886 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5887 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5888 Omit unused local vars.
5889 * window.c (shrink_windows): Omit unused local var.
5890 * menu.c (digest_single_submenu): Omit unused local var.
5891 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5892 Omit unused local var.
5893
5894 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5895 Don't assume string length fits in int.
5896 (keyremap_step, read_key_sequence): Use size_t for sizes.
5897 (read_key_sequence): Don't check last_real_key_start redundantly.
5898
5899 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5900 instead of alloca (Bug#8344).
5901
5902 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5903 (Fbacktrace_frame): Don't assume nframes fits in int.
5904
5905 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5906
5907 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5908 concerns.
5909
5910 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5911
5912 * cm.c (calccost): Turn while-do into do-while, for clarity.
5913
5914 * keyboard.c (syms_of_keyboard): Use the same style as later
5915 in this function when indexing through an array. This also
5916 works around GCC bug 48267.
5917
5918 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5919
5920 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5921
5922 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5923 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5924
5925 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5926 This avoids undefined behavior on integer overflow, and is a bit
5927 more convenient anyway since it is compared to a size_t variable.
5928
5929 Variadic C functions now count arguments with size_t, not int.
5930 This avoids an unnecessary limitation on 64-bit machines, which
5931 caused (substring ...) to crash on large vectors (Bug#8344).
5932 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5933 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5934 All variadic functions and their callers changed accordingly.
5935 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5936 * data.c (arith_driver, float_arith_driver): Likewise.
5937 * editfns.c (general_insert_function): Likewise.
5938 * eval.c (struct backtrace.nargs, interactive_p)
5939 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5940 (funcall_lambda, mark_backtrace): Likewise.
5941 * fns.c (concat): Likewise.
5942 * frame.c (x_set_frame_parameters): Likewise.
5943 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5944 0 if not found, not -1. All callers changed.
5945
5946 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5947 (stack_copy_size): Now size_t, not int.
5948 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5949
5950 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5951
5952 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5953 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5954 All callers changed.
5955
5956 * lisp.h (multibyte_char_to_unibyte):
5957 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5958 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5959 * character.h (CHAR_TO_BYTE8):
5960 * cmds.c (internal_self_insert):
5961 * editfns.c (general_insert_function):
5962 * keymap.c (push_key_description):
5963 * search.c (Freplace_match):
5964 * xdisp.c (message_dolog, set_message_1): All callers changed.
5965
5966 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5967
5968 * keyboard.c (safe_run_hook_funcall): New function.
5969 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5970 don't set the hook to nil, but remove the offending function instead.
5971 (Qcommand_hook_internal): Remove, unused.
5972 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5973 Vcommand_hook_internal.
5974
5975 * eval.c (enum run_hooks_condition): Remove.
5976 (funcall_nil, funcall_not): New functions.
5977 (run_hook_with_args): Call each function through a `funcall' argument.
5978 Remove `cond' argument, now redundant.
5979 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5980 (Frun_hook_with_args_until_failure): Adjust accordingly.
5981 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5982
5983 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5984
5985 * dispextern.h (string_buffer_position): Remove declaration.
5986
5987 * print.c (strout): Remove parameter `multibyte', unused since
5988 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5989
5990 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5991 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5992 All callers changed.
5993
5994 * w32.c (_wsa_errlist): Use braces for struct initializers.
5995
5996 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5997 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5998 All callers changed.
5999 (string_buffer_position): Likewise. Also, make static (it's never
6000 used outside xdisp.c).
6001 (cursor_row_p): Remove parameter `w', unused since
6002 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6003 (decode_mode_spec): Remove parameter `precision', introduced during
6004 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6005 All callers changed.
6006
6007 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6008
6009 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6010
6011 2011-03-27 Anders Lindgren <andlind@gmail.com>
6012
6013 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6014 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6015 (ns_update_auto_hide_menu_bar): New functions.
6016 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6017 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6018 ns_constrain_all_frames.
6019 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6020 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6021
6022 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6023
6024 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6025
6026 2011-03-27 Glenn Morris <rgm@gnu.org>
6027
6028 * syssignal.h: Replace RETSIGTYPE with void.
6029 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6030 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6031 Replace SIGTYPE with void everywhere.
6032 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6033 * s/template.h (SIGTYPE): Remove commented out definition.
6034
6035 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6036
6037 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6038 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6039
6040 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6041
6042 * w32.c (read_unc_volume): Use parameter `henum', instead of
6043 global variable `wget_enum_handle'.
6044
6045 * keymap.c (describe_vector): Remove parameters `indices' and
6046 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6047 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6048
6049 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6050
6051 * keyboard.c (timer_check): Remove parameter `do_it_now',
6052 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6053 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6054 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6055
6056 * keyboard.c (read_char):
6057 * w32menu.c (w32_menu_display_help):
6058 * xmenu.c (show_help_event, menu_help_callback):
6059 Adjust calls to `show_help_echo'.
6060
6061 * gtkutil.c (xg_maybe_add_timer):
6062 * keyboard.c (readable_events):
6063 * process.c (wait_reading_process_output):
6064 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6065
6066 * insdel.c (adjust_markers_gap_motion):
6067 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6068 (gap_left, gap_right): Don't call it.
6069
6070 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6071
6072 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6073 incurred during fontification.
6074
6075 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6076
6077 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6078 (DEFVAR_PER_BUFFER): Don't pass it.
6079
6080 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6081 (scrolling_window): Don't pass it.
6082
6083 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6084
6085 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6086
6087 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6088 and `suffix'.
6089 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6090 of variables specific to SELinux and computation of `encoded_absname'.
6091
6092 * image.c (XPutPixel): Remove unused variable `height'.
6093
6094 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6095
6096 * unexw32.c (get_section_info): Remove unused variable `section'.
6097
6098 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6099 (system_process_attributes): Remove unused variable `sess'.
6100 (sys_read): Remove unused variable `err'.
6101
6102 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6103 (w32_wnd_proc): Remove unused variable `isdead'.
6104 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6105 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6106 (x_create_tip_frame): Remove unused variable `tem'.
6107
6108 * w32inevt.c (w32_console_read_socket):
6109 Remove unused variable `no_events'.
6110
6111 * w32term.c (x_draw_composite_glyph_string_foreground):
6112 Remove unused variable `width'.
6113
6114 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6115
6116 * w32term.c (x_set_glyph_string_clipping):
6117 Don't pass uninitialized region to CombineRgn.
6118
6119 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6120
6121 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6122 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6123 (Fx_close_connection): Remove unused variable `i'.
6124
6125 * w32font.c (w32font_draw): Return number of glyphs.
6126 (w32font_open_internal): Remove unused variable `i'.
6127 (w32font_driver): Add missing initializer.
6128
6129 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6130 (fill_in_menu): Remove unused variable `items_added'.
6131
6132 * w32term.c (last_mouse_press_frame): Remove static global variable.
6133 (w32_clip_to_row): Remove unused variable `f'.
6134 (x_delete_terminal): Remove unused variable `i'.
6135
6136 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6137 (NOTHING): Remove unused static global variable.
6138 (uniscribe_check_otf): Remove unused variable `table'.
6139 (uniscribe_font_driver): Add missing initializers.
6140
6141 2011-03-23 Julien Danjou <julien@danjou.info>
6142
6143 * term.c (Fsuspend_tty, Fresume_tty):
6144 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6145 * window.c (temp_output_buffer_show):
6146 * insdel.c (signal_before_change):
6147 * frame.c (Fhandle_switch_frame):
6148 * fileio.c (Fdo_auto_save):
6149 * emacs.c (Fkill_emacs):
6150 * editfns.c (save_excursion_restore):
6151 * cmds.c (internal_self_insert):
6152 * callint.c (Fcall_interactively):
6153 * buffer.c (Fkill_all_local_variables):
6154 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6155 Use Frun_hooks.
6156 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6157 unconditionnaly since it does the check itself.
6158
6159 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6160
6161 Fix more problems found by GCC 4.5.2's static checks.
6162
6163 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6164 the first time through the loop, since we know p0 < p1 then.
6165 This also avoids a gcc -Wstrict-overflow warning.
6166
6167 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6168 leading to a memory leak, possible in functions like
6169 load_charset_map_from_file that can allocate an unbounded number
6170 of objects (Bug#8318).
6171
6172 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6173 that could (at least in theory) be that large.
6174
6175 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6176 This is less likely to overflow, and avoids undefined behavior if
6177 overflow does occur. All callers changed. Use strtoul to scan
6178 for the unsigned long integer.
6179 (pint2hrstr): Simplify and tune code slightly.
6180 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6181
6182 * scroll.c (do_scrolling): Work around GCC bug 48228.
6183 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6184
6185 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6186 This also avoids a warning with gcc -Wstrict-overflow.
6187 (validate_x_resource_name): Simplify count usage.
6188 This also avoids a warning with gcc -Wstrict-overflow.
6189
6190 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6191 fail (Bug#8306).
6192
6193 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6194
6195 * process.c (Fmake_network_process): Use socklen_t, not int,
6196 where POSIX says socklen_t is required in portable programs.
6197 This fixes a porting bug on hosts like 64-bit HP-UX, where
6198 socklen_t is wider than int (Bug#8277).
6199 (Fmake_network_process, server_accept_connection):
6200 (wait_reading_process_output, read_process_output):
6201 Likewise.
6202
6203 * process.c: Rename or move locals to avoid shadowing.
6204 (list_processes_1, Fmake_network_process):
6205 (read_process_output_error_handler, exec_sentinel_error_handler):
6206 Rename or move locals.
6207 (Fmake_network_process): Define label "retry_connect" only if needed.
6208 (Fnetwork_interface_info): Fix pointer signedness.
6209 (process_send_signal): Add cast to avoid pointer signedness problem.
6210 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6211 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6212
6213 Make tparam.h and terminfo.c consistent.
6214 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6215 Include tparam.h instead, since it declares them.
6216 * cm.h (PC): Remove extern decl; tparam.h now does this.
6217 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6218 * terminfo.c: Include tparam.h, to check interfaces.
6219 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6220 (tparam): Adjust signature to match interface in tparam.h;
6221 this removes some undefined behavior. Check that outstring and len
6222 are zero, which they always are with Emacs.
6223 * tparam.h (PC, BC, UP): New extern decls.
6224
6225 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6226 (xftfont_open): Rename locals to avoid shadowing.
6227
6228 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6229 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6230 (OTF_TAG_SYM): Omit macro if not needed.
6231 (ftfont_list): Remove unused local.
6232 (get_adstyle_property, ftfont_pattern_entity):
6233 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6234 Rename locals to avoid shadowing.
6235
6236 * xfont.c (xfont_list_family): Mark var as initialized.
6237
6238 * xml.c (make_dom): Now static.
6239
6240 * composite.c (composition_compute_stop_pos): Rename local to
6241 avoid shadowing.
6242 (composition_reseat_it): Remove unused locals.
6243 (find_automatic_composition, composition_adjust_point): Likewise.
6244 (composition_update_it): Mark var as initialized.
6245 (find_automatic_composition): Mark vars as initialized,
6246 with a FIXME (Bug#8290).
6247
6248 character.h: Rename locals to avoid shadowing.
6249 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6250 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6251 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6252 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6253 to avoid shadowing.
6254
6255 * textprop.c (property_change_between_p): Remove; unused.
6256
6257 * intervals.c (interval_start_pos): Now static.
6258
6259 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6260
6261 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6262 Rename locals to avoid shadowing.
6263
6264 * sound.c (wav_play, au_play, Fplay_sound_internal):
6265 Fix pointer signedness.
6266 (alsa_choose_format): Remove unused local var.
6267 (wav_play): Initialize a variable to 0, to prevent undefined
6268 behavior (Bug#8278).
6269
6270 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6271
6272 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6273
6274 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6275 clobbering (Bug#8298).
6276 * sysdep.c (sys_subshell): Likewise.
6277 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6278
6279 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6280 This should get cleaned up, so that child_setup has the
6281 same signature on all platforms.
6282
6283 * callproc.c (call_process_cleanup): Now static.
6284 (relocate_fd): Rename locals to avoid shadowing.
6285
6286 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6287
6288 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6289 not to be necessary, and produces flickering.
6290
6291 2011-03-20 Glenn Morris <rgm@gnu.org>
6292
6293 * config.in: Remove file.
6294
6295 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6296
6297 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6298 are now in src/globals.h.
6299 (syms_of_minibuf): Remove spurious & from previous change.
6300
6301 2011-03-20 Leo <sdl.web@gmail.com>
6302
6303 * minibuf.c (completing-read-function): New variable.
6304 (completing-read-default): Rename from completing-read.
6305 (completing-read): Call completing-read-function.
6306
6307 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6308
6309 * xfaces.c (Fx_load_color_file):
6310 Read color file from absolute filename (bug#8250).
6311
6312 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6313
6314 * makefile.w32-in: Update dependencies.
6315
6316 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6317
6318 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6319
6320 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6321
6322 Fix more problems found by GCC 4.5.2's static checks.
6323
6324 * process.c (make_serial_process_unwind, send_process_trap):
6325 (sigchld_handler): Now static.
6326
6327 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6328 That way, the code declares only the vars that it needs.
6329 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6330 * s/cygwin.h (PTY_ITERATION): Likewise.
6331 * s/darwin.h (PTY_ITERATION): Likewise.
6332 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6333
6334 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6335 * process.c (allocate_pty): Don't declare stb unless it's needed.
6336
6337 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6338 (CONSTANTLIM): Remove; unused.
6339 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6340 Define only if needed.
6341
6342 * unexelf.c (unexec): Name an expression,
6343 to avoid gcc -Wbad-function-cast warning.
6344 Use a different way to cause a compilation error if anyone uses
6345 n rather than nn, a way that does not involve shadowing.
6346 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6347
6348 * deps.mk (unexalpha.o): Remove; unused.
6349
6350 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6351 * unexec.h: New file.
6352 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6353 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6354 Depend on unexec.h.
6355 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6356 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6357 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6358 Change as necessary to match prototype in unexec.h.
6359
6360 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6361 shadowing.
6362 (back_comment, skip_chars): Mark vars as initialized.
6363
6364 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6365 Rename locals to avoid shadowing.
6366
6367 * lread.c (read1): Rewrite so as not to use empty "else".
6368 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6369
6370 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6371
6372 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6373 warning when compiling print.c.
6374
6375 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6376 instead of using an uninitialized var.
6377 (font_sort_entities): Mark var as initialized.
6378
6379 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6380
6381 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6382 pointers to constants.
6383 (font_parse_fcname): Remove unused vars.
6384 (font_delete_unmatched): Now static.
6385 (font_get_spec): Remove; unused.
6386 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6387 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6388 Rename or move locals to avoid shadowing.
6389
6390 * fns.c (require_nesting_list, require_unwind): Now static.
6391 (Ffillarray): Rename locals to avoid shadowing.
6392
6393 * floatfns.c (domain_error2): Define only if needed.
6394 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6395
6396 * alloc.c (mark_backtrace): Move decl from here ...
6397 * lisp.h: ... to here, so that it can be checked.
6398
6399 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6400 (Fdefvar): Rewrite so as not to use empty "else".
6401 (lisp_indirect_variable): Name an expression,
6402 to avoid gcc -Wbad-function-cast warning.
6403 (Fdefvar): Rename locals to avoid shadowing.
6404
6405 * callint.c (quotify_arg, quotify_args): Now static.
6406 (Fcall_interactively): Rename locals to avoid shadowing.
6407 Use const pointer when appropriate.
6408
6409 * lisp.h (get_system_name, get_operating_system_release):
6410 Move decls here, to check interfaces.
6411 * process.c (get_operating_system_release): Move decl to lisp.h.
6412 * xrdb.c (get_system_name): Likewise.
6413 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6414 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6415 some of which prompt warnings from gcc -Wbad-function-cast.
6416 (Fformat_time_string, Fencode_time, Finsert_char):
6417 (Ftranslate_region_internal, Fformat):
6418 Rename or remove local vars to avoid shadowing.
6419 (Ftranslate_region_internal): Mark var as initialized.
6420
6421 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6422 avoid shadowing.
6423
6424 * lisp.h (eassert): Check that the argument compiles, even if
6425 ENABLE_CHECKING is not defined.
6426
6427 * data.c (Findirect_variable): Name an expression, to avoid
6428 gcc -Wbad-function-cast warning.
6429 (default_value, arithcompare, arith_driver, arith_error): Now static.
6430 (store_symval_forwarding): Rename local to avoid shadowing.
6431 (Fmake_variable_buffer_local, Fmake_local_variable):
6432 Mark variables as initialized.
6433 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6434
6435 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6436 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6437 Rename locals to avoid shadowing.
6438 (mark_stack): Move local variables into the #ifdef region where
6439 they're used.
6440 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6441 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6442 needed otherwise.
6443 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6444 (GC_STRING_CHARS): Remove; not used.
6445 (Fmemory_limit): Cast sbrk's returned value to char *.
6446
6447 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6448 avoids undefined behavior in theory.
6449
6450 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6451
6452 Use functions, not macros, for up- and down-casing (Bug#8254).
6453 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6454 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6455 to use the following functions instead of these macros.
6456 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6457 EMACS_INT, since callers assume the returned value fits in int.
6458 (upcase1): Likewise, for UPCASE_TABLE.
6459 (uppercasep, lowercasep, upcase): New static inline functions.
6460 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6461 the race-condition problem in the old DOWNCASE.
6462
6463 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6464 Rename locals to avoid shadowing.
6465 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6466 (regex_compile, re_search_2, re_match_2_internal):
6467 Remove unused local vars.
6468 (FREE_VAR): Rewrite so as not to use empty "else",
6469 which gcc can warn about.
6470 (regex_compile, re_match_2_internal): Mark locals as initialized.
6471 (RETALLOC_IF): Define only if needed.
6472 (WORDCHAR_P): Likewise. This one is never needed, but is used
6473 only in a comment talking about a compiler bug, so put inside
6474 the #if 0 of that comment.
6475 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6476 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6477 Remove; unused.
6478
6479 * search.c (boyer_moore): Rename locals to avoid shadowing.
6480 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6481 (PREV_CHAR_BOUNDARY): Likewise.
6482
6483 * search.c (simple_search): Remove unused var.
6484
6485 * dired.c (compile_pattern): Move decl from here ...
6486 * lisp.h: ... to here, so that it can be checked.
6487 (struct re_registers): New forward decl.
6488
6489 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6490
6491 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6492 All uses changed.
6493 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6494 Rename locals to avoid shadowing.
6495 (Fvertical_motion): Mark locals as initialized.
6496
6497 * casefiddle.c (casify_object, casify_region): Now static.
6498 (casify_region): Mark local as initialized.
6499
6500 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6501
6502 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6503 New macros, so that the caller can use some names other than
6504 gcpro1, gcpro2, etc.
6505 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6506 of the new macros.
6507 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6508 argument, for consistency with GCPRO2_VAR, etc: it is now the
6509 prefix of the variable, not the variable itself. All uses
6510 changed.
6511 * dired.c (directory_files_internal, file_name_completion):
6512 Rename locals to avoid shadowing.
6513
6514 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6515 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6516 dired.c's scmp function, had undefined behavior.
6517 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6518 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6519 * buffer.h: ... to here, because these macros use current_buffer,
6520 and the new implementation with inline functions needs to have
6521 current_buffer in scope now, rather than later when the macros
6522 are used.
6523 (downcase, upcase1): New static inline functions.
6524 (DOWNCASE, UPCASE1): Reimplement using these functions.
6525 This avoids undefined behavior in expressions like
6526 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6527 from race conditions in accessing the global variables
6528 case_temp1 and case_temp2.
6529 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6530 * lisp.h (case_temp1, case_temp2): Remove their decls.
6531 * character.h (ASCII_CHAR_P): Move from here ...
6532 * lisp.h: ... to here, so that the inline functions mentioned
6533 above can use them.
6534
6535 * dired.c (directory_files_internal_unwind): Now static.
6536
6537 * fileio.c (file_name_as_directory, directory_file_name):
6538 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6539 Now static.
6540 (file_name_as_directory): Use const pointers when appropriate.
6541 (Fexpand_file_name): Likewise. In particular, newdir might
6542 point at constant storage, so make it a const pointer.
6543 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6544 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6545 signedness issues.
6546 (Fset_file_times, Finsert_file_contents, auto_save_error):
6547 Rename locals to avoid shadowing.
6548
6549 * minibuf.c (choose_minibuf_frame_1): Now static.
6550 (Ftry_completion, Fall_completions): Rename or remove locals
6551 to avoid shadowing.
6552
6553 * marker.c (bytepos_to_charpos): Remove; unused.
6554
6555 * lisp.h (verify_bytepos, count_markers): New decls,
6556 so that gcc does not warn that these functions aren't declared.
6557
6558 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6559 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6560 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6561 (copy_text): Remove unused local var.
6562
6563 * filelock.c (within_one_second): Now static.
6564 (lock_file_1): Rename local to avoid shadowing.
6565
6566 * buffer.c (fix_overlays_before): Mark locals as initialized.
6567 (fix_start_end_in_overlays): Likewise. This function should be
6568 simplified by using pointers-to-pointers, but that's a different
6569 matter.
6570 (switch_to_buffer_1): Now static.
6571 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6572 (report_overlay_modification): Rename locals to avoid shadowing.
6573
6574 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6575 Fix pointer signedness issue.
6576 (sys_subshell): Mark local as volatile if checking for lint,
6577 to suppress a gcc -Wclobbered warning that does not seem to be right.
6578 (MAXPATHLEN): Define only if needed.
6579
6580 * process.c (serial_open, serial_configure): Move decls from here ...
6581 * systty.h: ... to here, so that they can be checked.
6582
6583 * fns.c (get_random, seed_random): Move extern decls from here ...
6584 * lisp.h: ... to here, so that they can be checked.
6585
6586 * sysdep.c (reset_io): Now static.
6587 (wait_for_termination_signal): Remove; unused.
6588
6589 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6590 (copy_keymap_item, append_key, push_text_char_description):
6591 Now static.
6592 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6593 (DENSE_TABLE_SIZE): Remove; unused.
6594 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6595 (describe_map_tree):
6596 Rename locals to avoid shadowing.
6597
6598 * keyboard.c: Declare functions static if they are not used elsewhere.
6599 (echo_char, echo_dash, cmd_error, top_level_2):
6600 (poll_for_input, handle_async_input): Now static.
6601 (read_char, kbd_buffer_get_event, make_lispy_position):
6602 (make_lispy_event, make_lispy_movement, apply_modifiers):
6603 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6604 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6605 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6606 (read_key_sequence, read_char): Mark locals as initialized.
6607 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6608
6609 * keyboard.h (make_ctrl_char): New decl.
6610 (mark_kboards): Move decl here ...
6611 * alloc.c (mark_kboards): ... from here.
6612
6613 * lisp.h (force_auto_save_soon): New decl.
6614
6615 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6616 (DEFINE_DUMMY_FUNCTION): New macro.
6617 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6618 Use it.
6619 (main): Add casts to avoid warnings
6620 if GCC considers string literals to be constants.
6621
6622 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6623
6624 * dbusbind.c: Pointer signedness fixes.
6625 (xd_signature, xd_append_arg, xd_initialize):
6626 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6627 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6628 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6629 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6630
6631 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6632 if GCC considers string literals to be constants.
6633 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6634
6635 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6636
6637 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6638 (print_preprocess, print_object): New macro to fix last change.
6639
6640 * print.c (print_preprocess): Don't forget font objects.
6641
6642 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6643
6644 * emacs.c (USAGE3): Doc fixes.
6645
6646 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6647
6648 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6649 structure.
6650
6651 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6652
6653 * lisp.h (VWindow_system, Qfile_name_history):
6654 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6655 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6656 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6657
6658 * w32select.c: Don't #include "keyboard.h".
6659 (run_protected): Add extern declaration for waiting_for_input.
6660
6661 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6662 * w32console.c (detect_input_pending, read_input_pending)
6663 (encode_terminal_code):
6664 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6665 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6666 (w32_system_caret_y, Qfile_name_history):
6667 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6668 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6669 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6670 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6671 * w32proc.c (Qlocal, report_file_error):
6672 * w32term.c (Vwindow_system, updating_frame):
6673 * w32uniscribe.c (initialized, uniscribe_font_driver):
6674 Remove unneeded extern declarations.
6675
6676 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6677
6678 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6679
6680 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6681
6682 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6683 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6684 These macros can no longer be used for assignment.
6685
6686 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6687 Assign struct members directly, instead of using BUF_BEGV etc.
6688 (record_buffer_markers, fetch_buffer_markers): New functions for
6689 recording and fetching special buffer markers.
6690 (set_buffer_internal_1, set_buffer_temp): Use them.
6691
6692 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6693
6694 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6695
6696 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6697 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6698
6699 * xdisp.c (hscroll_window_tree):
6700 (reconsider_clip_changes): Use PT instead of BUF_PT.
6701
6702 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6703
6704 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6705 $(EMACS_ROOT)/lib/intprops.h.
6706
6707 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6708
6709 Fix more problems found by GCC 4.5.2's static checks.
6710
6711 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6712 to unsigned char * to avoid compiler diagnostic.
6713 (xg_free_frame_widgets): Make it clear that a local variable is
6714 needed only if USE_GTK_TOOLTIP.
6715 (gdk_window_get_screen): Make it clear that this macro is needed
6716 only if USE_GTK_TOOLTIP.
6717 (int_gtk_range_get_value): New function, which avoids a diagnostic
6718 from gcc -Wbad-function-cast.
6719 (xg_set_toolkit_scroll_bar_thumb): Use it.
6720 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6721 diagnostic from gcc -Wbad-function-cast.
6722 (get_utf8_string, xg_get_file_with_chooser):
6723 Rename locals to avoid shadowing.
6724 (create_dialog): Move locals to avoid shadowing.
6725
6726 * xgselect.c (xg_select): Remove unused var.
6727
6728 * image.c (four_corners_best): Mark locals as initialized.
6729 (gif_load): Initialize transparent_p to zero (Bug#8238).
6730 Mark another local as initialized.
6731 (my_png_error, my_error_exit): Mark with NO_RETURN.
6732
6733 * image.c (clear_image_cache): Now static.
6734 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6735 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6736 (x_edge_detection): Remove unnecessary cast that
6737 gcc -Wbad-function-cast diagnoses.
6738 (gif_load): Fix pointer signedness.
6739 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6740 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6741
6742 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6743
6744 Improve quality of tests for time stamp overflow.
6745 For example, without this patch (encode-time 0 0 0 1 1
6746 1152921504606846976) returns the obviously-bogus value (-948597
6747 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6748 reports time overflow. See
6749 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6750 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6751 * editfns.c: Include limits.h and intprops.h.
6752 (TIME_T_MIN, TIME_T_MAX): New macros.
6753 (time_overflow): Move earlier, to before first use.
6754 (hi_time, lo_time): New functions, for an accurate test for
6755 out-of-range times.
6756 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6757 (Fget_internal_run_time): Don't assume time_t fits in int.
6758 (make_time): Use list2 instead of Fcons twice.
6759 (Fdecode_time): More accurate test for out-of-range times.
6760 (check_tm_member): New function.
6761 (Fencode_time): Use it, to test for out-of-range times.
6762 (lisp_time_argument): Don't rely on undefined left-shift and
6763 right-shift behavior when checking for time stamp overflow.
6764
6765 * editfns.c (time_overflow): New function, refactoring common code.
6766 (Fformat_time_string, Fdecode_time, Fencode_time):
6767 (Fcurrent_time_string): Use it.
6768
6769 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6770 * dired.c (make_time): Move to ...
6771 * editfns.c (make_time): ... here.
6772 * systime.h: Note the move.
6773
6774 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6775
6776 * fringe.c (update_window_fringes): Remove unused variables.
6777
6778 * unexmacosx.c (copy_data_segment): Also copy __got section.
6779 (Bug#8223)
6780
6781 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6782
6783 * termcap.c [MSDOS]: Include "msdos.h".
6784 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6785 Constify `char *' arguments and their references according to
6786 prototypes in tparam.h.
6787
6788 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6789
6790 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6791 Adapt all references accordingly.
6792
6793 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6794
6795 2011-03-11 Tom Tromey <tromey@redhat.com>
6796
6797 * buffer.c (syms_of_buffer): Remove obsolete comment.
6798
6799 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6800
6801 * termhooks.h (encode_terminal_code): Declare prototype.
6802
6803 * msdos.c (encode_terminal_code): Don't declare prototype.
6804
6805 * term.c (encode_terminal_code): Now external again, used by
6806 w32console.c and msdos.c.
6807
6808 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6809 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6810
6811 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6812
6813 Fix some minor problems found by GCC 4.5.2's static checks.
6814
6815 * fringe.c (update_window_fringes): Mark locals as initialized
6816 (Bug#8227).
6817 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6818
6819 * alloc.c (mark_fringe_data): Move decl from here ...
6820 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6821 to check its interface.
6822 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6823
6824 * fontset.c (free_realized_fontset): Now static.
6825 (Fset_fontset_font): Rename local to avoid shadowing.
6826 (fontset_font): Mark local as initialized.
6827 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6828
6829 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6830
6831 * xselect.c (x_disown_buffer_selections): Remove; not used.
6832 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6833 (x_own_selection, Fx_disown_selection_internal): Rename locals
6834 to avoid shadowing.
6835 (x_handle_dnd_message): Remove local to avoid shadowing.
6836
6837 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6838 so that the caller can use some name other than gcpro1.
6839 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6840 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6841 (Fx_backspace_delete_keys_p):
6842 Use them to avoid shadowing, and rename vars to avoid shadowing.
6843 (x_decode_color, x_set_name, x_window): Now static.
6844 (Fx_create_frame): Add braces to silence GCC warning.
6845 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6846 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6847 Remove unused locals.
6848 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6849 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6850 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6851 macros.
6852
6853 * xterm.h (x_mouse_leave): New decl.
6854
6855 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6856 Remove unused functions.
6857 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6858 (x_calc_absolute_position): Now static.
6859 (XTread_socket): Don't define label "out" unless it's used.
6860 Don't declare local "event" unless it's used.
6861 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6862 unless they are used.
6863 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6864 (x_fatal_error_signal): Remove; not used.
6865 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6866 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6867 (x_error_catcher, x_connection_closed, x_error_handler):
6868 (x_error_quitter, xembed_send_message, x_iconify_frame):
6869 (my_log_handler): Rename locals to avoid shadowing.
6870 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6871 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6872
6873 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6874 Rename or move locals to avoid shadowing.
6875 (tty_defined_color, merge_face_heights): Now static.
6876 (free_realized_faces_for_fontset): Remove; not used.
6877 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6878 does not deduce is never used uninitialized.
6879 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6880 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6881
6882 * terminal.c (store_terminal_param): Now static.
6883
6884 * xmenu.c (menu_highlight_callback): Now static.
6885 (set_frame_menubar): Remove unused local.
6886 (xmenu_show): Rename parameter to avoid shadowing.
6887 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6888 since they might point to immutable storage.
6889 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6890 since it's unused otherwise.
6891
6892 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6893 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6894 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6895 avoids a gcc -Wuninitialized diagnostic.
6896 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6897 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6898 does not deduce are never used uninitialized.
6899
6900 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6901
6902 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6903 * window.c (window_loop, size_window):
6904 (run_window_configuration_change_hook, enlarge_window): Likewise.
6905
6906 * window.c (display_buffer): Now static.
6907 (size_window): Mark variables that gcc -Wuninitialized
6908 does not deduce are never used uninitialized.
6909 * window.h (check_all_windows): New decl, to forestall
6910 gcc -Wmissing-prototypes diagnostic.
6911 * dispextern.h (bidi_dump_cached_states): Likewise.
6912
6913 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6914 shadowing.
6915 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6916 Include <limits.h>.
6917 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6918 and to avoid gcc -Wuninitialized warning.
6919 (load_charset_map): Mark variables that gcc -Wuninitialized
6920 does not deduce are never used uninitialized.
6921 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6922
6923 * coding.c (coding_set_source, coding_set_destination):
6924 Use "else { /* comment */ }" rather than "else /* comment */;"
6925 for clarity, and to avoid gcc -Wempty-body warning.
6926 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6927 a block, when the outer 'i' will do.
6928 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6929 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6930 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6931 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6932 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6933 Rename locals to avoid shadowing.
6934 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6935 * coding.c (emacs_mule_char, encode_invocation_designation):
6936 Now static, since they're not used elsewhere.
6937 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6938 (decode_coding_object, encode_coding_object, detect_coding_system):
6939 (decode_coding_emacs_mule): Mark variables that gcc
6940 -Wuninitialized does not deduce are never used uninitialized.
6941 (detect_coding_iso_2022): Initialize a local variable that might
6942 be used uninitialized. Leave a FIXME because it's not clear that
6943 this initialization is needed. (Bug#8211)
6944 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6945 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6946 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6947 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6948 Remove unused macros.
6949
6950 * category.c (hash_get_category_set): Remove unused local var.
6951 (copy_category_table): Now static, since it's not used elsewhere.
6952 * character.c (string_count_byte8): Likewise.
6953
6954 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6955 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6956
6957 * chartab.c (copy_sub_char_table): Now static, since it's not used
6958 elsewhere.
6959 (sub_char_table_ref_and_range, char_table_ref_and_range):
6960 Rename locals to avoid shadowing.
6961 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6962
6963 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6964 (BIDI_BOB): Remove unused macro.
6965
6966 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6967 deduce are never used uninitialized.
6968 * term.c (encode_terminal_code): Likewise.
6969
6970 * term.c (encode_terminal_code): Now static. Remove unused local.
6971
6972 * tparam.h: New file.
6973 * term.c, tparam.h: Include it.
6974 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6975 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6976 Move these decls to tparam.h, and make them agree with what
6977 is actually in tparam.c. The previous trick of using incompatible
6978 decls in different modules does not conform to the C standard.
6979 All callers of tparam changed to use tparam's actual API.
6980 * tparam.c (tparam1, tparam, tgoto):
6981 Use const pointers where appropriate.
6982
6983 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6984 * cm.h (struct cm): Likewise.
6985 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6986 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6987 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6988 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6989 (turn_on_face, init_tty): Likewise.
6990 * termchar.h (struct tty_display_info): Likewise.
6991
6992 * term.c (term_mouse_position): Rename local to avoid shadowing.
6993
6994 * alloc.c (mark_ttys): Move decl from here ...
6995 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6996
6997 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6998
6999 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7000
7001 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7002
7003 * search.c (compile_pattern_1): Remove argument regp, unused since
7004 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7005 (compile_pattern): Don't pass it.
7006
7007 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7008
7009 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7010 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7011 for ! HAVE_GTK3.
7012 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7013
7014 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7015
7016 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7017 gdk_window_get_screen, gdk_window_get_geometry,
7018 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7019 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7020 (xg_get_pixbuf_from_pixmap): New function.
7021 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7022 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7023 Call xg_get_pixbuf_from_pixmap instead of
7024 gdk_pixbuf_get_from_drawable.
7025 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7026 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7027 (xg_check_special_colors): Use GtkStyleContext and its functions
7028 for HAVE_GTK3.
7029 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7030 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7031 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7032 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7033 Call gtk_widget_get_preferred_size.
7034 (xg_frame_resized): gdk_window_get_geometry only takes 5
7035 parameters.
7036 (xg_win_to_widget, xg_event_is_for_menubar):
7037 Call gdk_x11_window_lookup_for_display.
7038 (xg_set_widget_bg): New function.
7039 (delete_cb): New function.
7040 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7041 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7042 (xg_set_background_color): Call xg_set_widget_bg.
7043 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7044 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7045 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7046 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7047 if ! HAVE_GTK3.
7048 (update_frame_tool_bar): Call gtk_widget_hide.
7049 (xg_initialize): Use GDK_KEY_g.
7050
7051 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7052 if ! HAVE_GTK3
7053 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7054
7055 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7056 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7057 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7058
7059 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7060
7061 * w32xfns.c (select_palette): Check success of RealizePalette against
7062 GDI_ERROR, not zero.
7063
7064 See ChangeLog.11 for earlier changes.
7065
7066 ;; Local Variables:
7067 ;; coding: utf-8
7068 ;; End:
7069
7070 Copyright (C) 2011 Free Software Foundation, Inc.
7071
7072 This file is part of GNU Emacs.
7073
7074 GNU Emacs is free software: you can redistribute it and/or modify
7075 it under the terms of the GNU General Public License as published by
7076 the Free Software Foundation, either version 3 of the License, or
7077 (at your option) any later version.
7078
7079 GNU Emacs is distributed in the hope that it will be useful,
7080 but WITHOUT ANY WARRANTY; without even the implied warranty of
7081 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7082 GNU General Public License for more details.
7083
7084 You should have received a copy of the GNU General Public License
7085 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.