1 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3 Fix minor ralloc.c problems found by static checking.
4 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
6 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
7 (r_alloc_sbrk): Now static.
9 Improve ralloc.c interface checking.
10 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
11 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
12 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
13 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
14 [REL_ALLOC]: ... to here, to check interface.
15 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
16 Remove decls. This fixes an "It stinks!".
18 * alloc.c (which_symbols): Fix alignment issue / type clash.
20 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
22 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
23 (struct Lisp_Misc_Any): Likewise.
24 (struct Lisp_Free): Likewise.
25 * alloc.c (union aligned_Lisp_Symbol): Define.
26 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
27 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
28 (union aligned_Lisp_Misc): Define.
29 (MARKER_BLOCK_SIZE, struct marker_block): Use union
30 aligned_Lisp_Misc instead of union Lisp_Misc.
31 (Fmake_symbol, allocate_misc, gc_sweep): Adjust
33 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
35 configure: new option --enable-gcc-warnings (Bug#11207)
36 * Makefile.in (C_WARNINGS_SWITCH): Remove.
37 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
38 (ALL_CFLAGS): Use new macros rather than old.
39 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
40 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
41 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
42 -Wunused-result, -Wunused-variable. This should go away once
43 the Emacs and Gnulib regex code is merged.
44 (xmalloc, xrealloc): Now static.
46 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
48 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
49 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
50 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
51 * s/netbsd.h, s/sol2-6.h:
52 Remove definition of GC_MARK_STACK, since the default now works.
53 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
54 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
55 no longer the default.
56 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
58 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
60 * lread.c (lisp_file_lexically_bound_p):
61 Fix hang at ";-*-\n" (bug#11238).
63 2012-04-14 Eli Zaretskii <eliz@gnu.org>
65 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
66 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
68 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
70 * nsterm.m (constrainFrameRect): Always constrain when there is only
71 one screen (Bug#10962).
73 2012-04-13 Ken Brown <kbrown@cornell.edu>
75 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
77 2012-04-13 Reuben Thomas <rrt@sc3d.org>
79 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
81 2012-04-11 Daniel Colascione <dancol@dancol.org>
83 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
84 against is gone. It's better to use vfork now so that when Cygwin
85 gains a new, working vfork, we use it automatically (bug#10398).
87 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
89 * window.c (save_window_save): Obey window-point-insertion-type.
91 2012-04-11 Glenn Morris <rgm@gnu.org>
93 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
95 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
97 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
99 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
101 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
102 (force_quit_count): New var.
103 (handle_interrupt): Use it.
105 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
107 * w32.c (w32_delayed_load): Record the full path of the library
108 being loaded (bug#10424).
110 2012-04-09 Glenn Morris <rgm@gnu.org>
112 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
113 not just in the obarray, before snarfing them. (Bug#11036)
115 * Makefile.in ($(leimdir)/leim-list.el):
116 Pass EMACS rather than BUILT_EMACS.
118 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
120 * process.c (make_process):
121 * process.h: Add integer `gnutls_handshakes_tried' member to
124 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
125 Add convenience `GNUTLS_LOG2i' macro.
127 * gnutls.c (gnutls_log_function2i): Convenience log function.
128 (emacs_gnutls_read): Use new log functions,
129 `gnutls_handshakes_tried' process member, and
130 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
131 attempts per process (connection).
133 2012-04-09 Chong Yidong <cyd@gnu.org>
135 * eval.c (Fuser_variable_p, user_variable_p_eh)
136 (lisp_indirect_variable): Functions deleted.
137 (Fdefvar): Caller changed.
139 * callint.c (Finteractive, Fcall_interactively):
140 * minibuf.c (Fread_variable): Callers changed.
142 2012-04-09 Eli Zaretskii <eliz@gnu.org>
144 * xdisp.c (set_cursor_from_row): If the display string appears in
145 the buffer at position that is closer to point than the position
146 after the display string, display the cursor on the first glyph of
147 the display string. Fixes cursor display when a 'display' text
148 property immediately follows invisible text. (Bug#11094)
150 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
152 composite.c: use 'double' consistently
153 * composite.c (get_composition_id): Use 'double' consistently
154 instead of converting 'float' to 'double' and vice versa; this is
155 easier to understand and avoids a GCC warning.
157 2012-04-09 Glenn Morris <rgm@gnu.org>
159 * Makefile.in: Generate leim-list with bootstrap-emacs, in
160 preparation for dumping it with emacs. (Bug#4789)
161 (leimdir): New variable.
162 ($(leimdir)/leim-list.el): New rule.
163 (emacs$(EXEEXT)): Depend on leim-list.el.
165 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
166 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
167 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
169 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
171 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
174 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
176 * xml.c (init_libxml2_functions) [WINDOWSNT]:
177 Remove unused local variable.
179 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
181 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
182 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
183 (mark_memory): Mark Lisp_Objects only if pointers might hide in
184 objects, as mark_maybe_pointer will catch them otherwise.
185 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
186 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
188 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
190 Fix typo that broke non-Windows builds.
191 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
193 2012-04-07 Eli Zaretskii <eliz@gnu.org>
195 Support building on MS-Windows with libxml2.
197 * makefile.w32-in (OBJ2): Add xml.$(O).
198 (GLOBAL_SOURCES): Add xml.c.
199 ($(BLD)/xml.$(O)): New dependency list.
201 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
202 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
203 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
204 [!WINDOWSNT]: New macros.
205 (init_libxml2_functions, libxml2_loaded_p): New functions.
206 (parse_region): Call fn_xmlCheckVersion instead of using the macro
207 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
208 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
209 Calls xmlCleanupParser only if libxml2 was loaded (or statically
211 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
212 Call init_libxml2_functions before calling libxml2 functions.
213 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
215 * emacs.c: Don't include libxml/parser.h.
216 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
217 xmlCleanupParser directly.
219 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
221 2012-04-07 Eli Zaretskii <eliz@gnu.org>
223 * indent.c (Fvertical_motion): If there is a display string at
224 point, use it.vpos to compute how many lines to backtrack after
225 move_it_to point. (Bug#11133)
227 2012-04-06 Eli Zaretskii <eliz@gnu.org>
229 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
230 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
231 about subtle differences between FETCH_CHAR* and STRING_CHAR*
232 macros related to unification of CJK characters. For the details,
233 see the discussion following the message here:
234 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
236 2012-04-04 Chong Yidong <cyd@gnu.org>
238 * keyboard.c (Vdelayed_warnings_list): Doc fix.
240 2012-04-01 Eli Zaretskii <eliz@gnu.org>
242 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
243 instead of alloca. (Bug#11138)
245 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
247 * w32menu.c (is_simple_dialog): Properly check lisp types.
250 2012-03-31 Eli Zaretskii <eliz@gnu.org>
252 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
253 position we get to after a call to move_it_to fails the
254 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
255 only if we wind up in a string from display property. (Bug#11063)
257 * window.c (Fdelete_other_windows_internal): Invalidate the row
258 and column information about mouse highlight, so that redisplay
259 restores it after reallocating the glyph matrices. (Bug#7464)
261 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
262 string comes from a `display' text property, use the buffer
263 position of that property as if we actually saw that position in
265 (move_it_by_lines): Remove the assertion that
266 "it->current_x == 0 && it->hpos == 0" which can be legitimately
267 violated when there's a before-string at the beginning of a line.
270 2012-03-30 Eli Zaretskii <eliz@gnu.org>
272 * xdisp.c (append_space_for_newline): If the default face was
273 remapped, use the remapped face for the appended newline.
274 (extend_face_to_end_of_line): Use the remapped default face for
275 extending the face to the end of the line.
276 (display_line): Call extend_face_to_end_of_line when the default
277 face was remapped. (Bug#11068)
279 2012-03-29 Eli Zaretskii <eliz@gnu.org>
281 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
283 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
285 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
287 2012-03-27 Glenn Morris <rgm@gnu.org>
289 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
292 2012-03-26 Kenichi Handa <handa@m17n.org>
294 * dispextern.h (struct glyph): Fix previous change. Change the
295 bit length of glyphless.ch to 25 (Bug#11082).
297 2012-03-26 Chong Yidong <cyd@gnu.org>
299 * keyboard.c (Vselection_inhibit_update_commands): New variable.
300 (command_loop_1): Use it; inhibit selection update for
301 handle-select-window too (Bug#8996).
303 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
305 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
307 2012-03-25 Kenichi Handa <handa@m17n.org>
309 * dispextern.h (struct glyph): Change the bit length of
310 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
312 2012-03-24 Eli Zaretskii <eliz@gnu.org>
314 * s/ms-w32.h (tzname): Include time.h before redirecting to
315 _tzname. Fixes the MSVC build. (Bug#9960)
317 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
319 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
322 * xterm.c (XTread_socket): Only modify handling_signal if
323 !SYNC_INPUT. (Bug#11080)
325 2012-03-23 Eli Zaretskii <eliz@gnu.org>
327 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
328 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
329 when fetching a multibyte character consumes more bytes than
330 CHAR_BYTES returns, due to unification of CJK characters in
331 string_char. (Bug#11073)
333 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
335 * process.c (wait_reading_process_output): Handle pty disconnect
336 by refraining from sending oneself a SIGCHLD (bug#10933).
338 2012-03-22 Chong Yidong <cyd@gnu.org>
340 * dispextern.h (struct it): New member string_from_prefix_prop_p.
342 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
343 Mark string as coming from a prefix property.
344 (handle_face_prop): Use default face for prefix strings (Bug#4281).
345 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
347 2012-03-21 Chong Yidong <cyd@gnu.org>
349 * xfaces.c (Vface_remapping_alist): Doc fix.
351 2012-03-20 Eli Zaretskii <eliz@gnu.org>
353 * w32proc.c (Fw32_set_console_codepage)
354 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
357 2012-03-20 Chong Yidong <cyd@gnu.org>
359 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
360 to reflect default non-nil value of redisplay-dont-pause.
362 2012-03-19 Kenichi Handa <handa@m17n.org>
364 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
365 it fit in a valid range (Bug#11003).
367 2012-03-18 Eli Zaretskii <eliz@gnu.org>
369 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
370 that is not from display property, accept the row as a "cursor
371 row" if one of the string's character has a non-nil `cursor'
372 property. Fixes cursor positioning when there are newlines in
373 overlay strings, e.g. in icomplete.el. (Bug#11035)
375 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
377 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
379 2012-03-12 Chong Yidong <cyd@gnu.org>
381 * eval.c (inhibit_lisp_code): Rename from
382 inhibit_window_configuration_change_hook; move from window.c.
384 * xfns.c (unwind_create_frame_1, Fx_create_frame):
385 * window.c (run_window_configuration_change_hook)
386 (syms_of_window): Callers changed.
388 2012-03-11 Chong Yidong <cyd@gnu.org>
390 * keymap.c (Fkey_description): Doc fix (Bug#9700).
392 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
394 2012-03-10 Chong Yidong <cyd@gnu.org>
396 * frame.c (other_visible_frames): Don't assume the selected frame
397 is visible (Bug#10955).
399 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
401 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
403 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
405 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
406 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
409 2012-03-03 Glenn Morris <rgm@gnu.org>
411 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
413 2012-03-02 Eli Zaretskii <eliz@gnu.org>
415 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
416 position past the first glyph_row that ends at ZV. (Bug#10902)
417 (redisplay_window, next_element_from_string): Fix typos in
419 (redisplay_window): Pass to move_it_vertically the margin in
420 pixels, not in screen lines.
422 2012-03-02 Glenn Morris <rgm@gnu.org>
424 * buffer.c (buffer-list-update-hook): Doc fix.
426 2012-02-29 Eli Zaretskii <eliz@gnu.org>
428 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
429 push_it before setting up the iterator for the first overlay
430 string, even if we have an empty string loaded.
431 (next_overlay_string): If there's an empty string on the iterator
432 stack, pop the stack. (Bug#10903)
434 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
436 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
437 Suggested by Stefan Monnier in
438 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
439 * alloc.c (widen_to_Lisp_Object): New static function.
440 (mark_memory): Also mark Lisp_Objects by fetching pointer words
441 and widening them to Lisp_Objects. This would work even if
442 USE_LSB_TAG is defined and wide integers are used, which might
443 happen in a future version of Emacs.
445 2012-02-25 Chong Yidong <cyd@gnu.org>
447 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
450 * xselect.c (Fx_selection_exists_p): Doc fix.
451 (x_clipboard_manager_save_all): Print an informative message
452 before saving to clipboard manager.
454 2012-02-24 Chong Yidong <cyd@gnu.org>
456 * keyboard.c (process_special_events): Handle all X selection
457 requests in kbd_buffer, not just the next one (Bug#8869).
459 2012-02-23 Chong Yidong <cyd@gnu.org>
461 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
462 call when setting menu-bar-lines and tool-bar-lines parameters.
463 (unwind_create_frame_1): New helper function.
465 * window.c (inhibit_window_configuration_change_hook): New var.
466 (run_window_configuration_change_hook): Obey it.
467 (syms_of_window): Initialize it.
469 2012-02-22 Chong Yidong <cyd@gnu.org>
471 * xterm.c (x_draw_image_relief): Add missing type check for
472 Vtool_bar_button_margin (Bug#10743).
474 2012-02-21 Chong Yidong <cyd@gnu.org>
476 * fileio.c (Vfile_name_handler_alist): Doc fix.
478 * buffer.c (Fget_file_buffer): Protect against invalid file
479 handler return value.
481 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
483 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
484 when computing $valmask.
486 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
487 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
488 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
489 It's useless in that case, and it can cause problems on hosts
490 that allocate halves of EMACS_INT values separately.
491 Reported by Dan Horák. Diagnosed by Andreas Schwab in
492 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
493 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
494 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
495 it avoids undefined behavior on hosts where shifting right by more
496 than the word width has undefined behavior.
498 2012-02-19 Chong Yidong <cyd@gnu.org>
500 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
501 (Funhandled_file_name_directory, Ffile_name_as_directory)
502 (Fdirectory_file_name, Fexpand_file_name)
503 (Fsubstitute_in_file_name): Protect against invalid file handler
504 return values (Bug#10845).
506 2012-02-18 Eli Zaretskii <eliz@gnu.org>
508 * .gdbinit (pitx): Fix incorrect references to fields of the
511 2012-02-17 Chong Yidong <cyd@gnu.org>
513 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
515 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
517 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
518 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
520 2012-02-15 Chong Yidong <cyd@gnu.org>
522 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
523 marked as special. Also, starting docstrings with * is obsolete.
525 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
527 * gnutls.c (emacs_gnutls_write): Fix last change.
529 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
531 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
534 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
536 * keymap.c (Fsingle_key_description): Handle char ranges.
538 2012-02-12 Chong Yidong <cyd@gnu.org>
540 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
541 as that creates a dangerous corner case.
543 * window.c (Fdelete_window_internal): Invalidate the mouse
544 highlight (Bug#9904).
546 2012-02-12 Glenn Morris <rgm@gnu.org>
548 * xselect.c (Fx_own_selection_internal)
549 (Fx_get_selection_internal, Fx_disown_selection_internal)
550 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
551 * nsselect.m (Fx_own_selection_internal)
552 (Fx_disown_selection_internal, Fx_selection_exists_p)
553 (Fx_selection_owner_p, Fx_get_selection_internal):
554 Sync docs and argument specs with the xselect.c versions.
556 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
558 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
560 2012-02-11 Eli Zaretskii <eliz@gnu.org>
562 * w32select.c (Fx_selection_exists_p): Sync doc string and
563 argument list with xselect.c. (Bug#10783)
565 * w16select.c (Fx_selection_exists_p): Sync doc string and
566 argument list with xselect.c. (Bug#10783)
568 2012-02-10 Glenn Morris <rgm@gnu.org>
570 * fns.c (Fsecure_hash): Doc fix.
572 2012-02-09 Kenichi Handa <handa@m17n.org>
574 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
576 2012-02-07 Chong Yidong <cyd@gnu.org>
578 * buffer.c (Fbuffer_local_variables)
579 (buffer_lisp_local_variables): Handle unbound vars correctly;
580 don't let Qunbound leak into Lisp.
582 2012-02-07 Glenn Morris <rgm@gnu.org>
584 * image.c (Fimagemagick_types): Doc fix.
586 * image.c (imagemagick-render-type): Change it from a lisp object
587 to an integer. Move the doc here from the lisp manual.
588 Treat all values not equal to 0 the same.
590 2012-02-06 Chong Yidong <cyd@gnu.org>
592 * doc.c (store_function_docstring): Avoid applying docstring of
593 alias to base function (Bug#2603).
595 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
597 * .gdbinit (pp1, pv1): Remove redundant defines.
600 2012-02-04 Chong Yidong <cyd@gnu.org>
602 * nsterm.m: Declare a global (Bug#10694).
604 2012-02-04 Eli Zaretskii <eliz@gnu.org>
606 * w32.c (get_emacs_configuration_options):
607 Include --enable-checking, if specified, in the return value.
609 2012-02-04 Martin Rudalics <rudalics@gmx.at>
611 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
612 after rounding frame sizes. (Bug#9723)
614 2012-02-04 Eli Zaretskii <eliz@gnu.org>
616 * keyboard.c (adjust_point_for_property): Don't position point
617 before BEGV. (Bug#10696)
619 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
621 Handle overflow when computing char display width (Bug#9496).
622 * character.c (char_width): Return EMACS_INT, not int.
623 (char_width, c_string_width): Check for overflow when
624 computing the width; this is possible now that individual
625 characters can have unbounded width. Problem introduced
626 by merge from Emacs 23 on 2012-01-19.
628 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
630 * dbusbind.c (Fdbus_register_method): Mention the return value
631 :ignore in the docstring.
633 2012-02-02 Glenn Morris <rgm@gnu.org>
635 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
637 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
638 Unconditionally set to t. (Bug#10673)
639 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
640 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
641 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
643 2012-02-02 Kenichi Handa <handa@m17n.org>
645 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
646 0, do not call append_composite_glyph.
648 2012-02-02 Kenichi Handa <handa@m17n.org>
650 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
652 (x_produce_glyphs): If the component of a composition is a null
653 string, set it->pixel_width to 1 to avoid zero-width glyph.
655 2012-02-01 Eli Zaretskii <eliz@gnu.org>
657 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
658 first 2 arguments are identical. This makes inserting large
659 output from a subprocess an order of magnitude faster on
660 MS-Windows, where all sbrk'ed memory is always contiguous.
662 2012-01-31 Glenn Morris <rgm@gnu.org>
664 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
665 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
666 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
668 2012-01-29 Glenn Morris <rgm@gnu.org>
670 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
672 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
674 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
676 2012-01-28 Chong Yidong <cyd@gnu.org>
678 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
680 2012-01-26 Chong Yidong <cyd@gnu.org>
682 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
684 * search.c (Fsearch_forward, Fsearch_backward): Document negative
685 repeat counts (Bug#10507).
687 2012-01-26 Glenn Morris <rgm@gnu.org>
689 * lread.c (syms_of_lread): Doc fix.
691 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
693 * coding.c (encode_designation_at_bol): Change return value to
696 2012-01-25 Chong Yidong <cyd@gnu.org>
698 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
700 2012-01-21 Chong Yidong <cyd@gnu.org>
702 * floatfns.c (Fcopysign): Make the second argument non-optional,
703 since nil is not allowed anyway.
705 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
707 * process.c (read_process_output): Use p instead of XPROCESS (proc).
708 (send_process): Likewise.
710 2012-01-19 Martin Rudalics <rudalics@gmx.at>
712 * window.c (save_window_save, Fcurrent_window_configuration)
713 (Vwindow_persistent_parameters): Do not use Qstate.
716 2012-01-19 Kenichi Handa <handa@m17n.org>
718 * character.c (char_width): New function.
719 (Fchar_width, c_string_width, lisp_string_width):
720 Use char_width (Bug#9496).
722 2012-01-16 Martin Rudalics <rudalics@gmx.at>
724 * window.c (Vwindow_persistent_parameters): New variable.
725 (Fset_window_configuration, save_window_save): Handle persistent
728 2012-01-14 Eli Zaretskii <eliz@gnu.org>
730 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
731 thrashing the stack of the thread. (Bug#9087)
733 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
735 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
737 2012-01-11 Eli Zaretskii <eliz@gnu.org>
739 * xdisp.c (rows_from_pos_range): Handle the case where the
740 highlight ends on a newline. (Bug#10464)
741 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
742 he end column for display of highlight that ends on a newline
745 2012-01-11 Glenn Morris <rgm@gnu.org>
747 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
748 from load-path also when installation-directory is nil. (Bug#10208)
750 2012-01-10 Glenn Morris <rgm@gnu.org>
752 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
754 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
755 Update template values to be closer to their typical values these days.
757 2012-01-09 Eli Zaretskii <eliz@gnu.org>
759 * xdisp.c (rows_from_pos_range): Accept additional argument
760 DISP_STRING, and accept any glyph in a row whose object is that
761 string as eligible for mouse highlight. Fixes mouse highlight of
762 display strings from overlays. (Bug#10464)
764 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
766 emacs: fix an auto-save permissions race condition (Bug#10400)
767 * fileio.c (auto_saving_dir_umask): New static var.
768 (Fmake_directory_internal): Use it.
769 (do_auto_save_make_dir): Set it, instead of invoking chmod after
770 creating the directory. The old code temporarily assigns
771 too-generous permissions to the directory.
772 (do_auto_save_eh): Clear it.
773 (Fdo_auto_save): Catch all errors, not just file errors, so
774 that the var is always cleared.
776 2012-01-07 Eli Zaretskii <eliz@gnu.org>
778 * search.c (scan_buffer): Pass character positions to
779 know_region_cache, not byte positions. (Bug#6540)
781 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
783 * w32.c (sys_rename): Report EXDEV when rename of a directory
784 fails because the target is on another logical disk. (Bug#10284)
786 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
788 * xterm.c (x_embed_request_focus): New function.
790 * xterm.h: Add prototype.
792 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
794 2012-01-05 Glenn Morris <rgm@gnu.org>
796 * emacs.c (emacs_copyright): Update short copyright year to 2012.
798 2012-01-01 Eli Zaretskii <eliz@gnu.org>
800 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
801 Load gnutls_transport_set_lowat only if GnuTLS version is below
803 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
804 GnuTLS versions below 2.11.1.
806 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
808 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
809 to the doc string advising against its use for altering the way
810 windows are scrolled.
812 2011-12-28 Kenichi Handa <handa@m17n.org>
814 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
815 coding-system ASCII compatible only when it does not produce BOM
816 on encoding (Bug#10383).
818 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
820 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
822 (create_and_show_popup_menu): Always use menu_position_func for
825 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
827 * callint.c (Fcall_interactively): Don't truncate prompt string.
829 2011-12-23 Eli Zaretskii <eliz@gnu.org>
831 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
832 property that ends at ZV, so that the bidi iteration could be
833 resumed from there (after widening). (Bug#10360)
835 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
837 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
839 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
841 * nsterm.m (x_free_frame_resources):
842 Release f->output_data.ns->miniimage.
843 (ns_index_color): Fix indentation. Do not retain
844 color_table->colors[i].
846 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
849 * nsfns.m (x_set_background_color): Assign return value from
850 ns_index_color to face-background instead of NSColor*.
851 (ns_implicitly_set_icon_type): Fix indentation.
852 Change assignment in for loop to comparison.
854 * emacs.c (ns_pool): New variable.
855 (main): Assign ns_pool.
856 (Fkill_emacs): Call ns_release_autorelease_pool.
858 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
859 autorelease fdesc, release fdAttrs and tdict.
860 (ns_get_covering_families): Release charset.
861 (ns_findfonts): Release NSFontDescriptor created with new.
862 (ns_uni_to_glyphs): Fix indentation.
863 (setString): Release attrStr before assigning new value.
865 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
867 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
869 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
870 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
872 2011-12-18 David Reitter <reitter@cmu.edu>
874 * nsterm.m (ns_term_init): Subscribe for notifications
875 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
876 to method trackingNotification in EmacsMenu.
878 * nsmenu.m (trackingMenu): New variable.
879 (trackingNotification): New method (from Aquamacs).
880 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
881 from Aquamacs (Bug#7030).
883 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
885 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
886 (symbol_to_nsstring): Fix indentation.
887 (ns_symbol_to_pb): New function.
888 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
889 (Fns_rotate_cut_buffers_internal): Remove.
890 (Fns_store_selection_internal): Rename from
891 Fns_store_cut_buffer_internal.
892 (ns_get_foreign_selection, Fx_own_selection_internal)
893 (Fx_disown_selection_internal, Fx_selection_exists_p)
894 (Fns_get_selection_internal, Fns_store_selection_internal):
895 Use ns_symbol_to_pb and check if return value is nil.
896 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
897 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
898 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
899 renamed to Sns_store_selection_internal.
900 (ns_handle_selection_request): Move code to Fx_own_selection_internal
901 and remove this function.
902 (ns_handle_selection_clear): Remove, never used.
903 (Fx_own_selection_internal): Move code from ns_handle_selection_request
906 2011-12-17 Ken Brown <kbrown@cornell.edu>
908 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
909 GID is unknown (Bug#10257).
911 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
913 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
914 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
915 which caused a build failure on GNU/Linux IA-64. This problem was
916 introduced by my 2011-10-07 patch.
918 2011-12-15 Juri Linkov <juri@jurta.org>
920 * image.c (imagemagick_error): New function. (Bug#10112)
921 (imagemagick_load_image): Comment out `MagickSetResolution' call.
922 Use `imagemagick_error' where ImageMagick functions return
924 (Fimagemagick_types): Add `Fnreverse' to return the list in the
927 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
929 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
930 fill background (Bug#8992).
932 2011-12-13 Martin Rudalics <rudalics@gmx.at>
934 * window.c (Vwindow_combination_resize)
935 (Vwindow_combination_limit): Use t instead of non-nil in
937 (Vrecenter_redisplay): Add first sentence of doc-string on
939 (Frecenter): Fix doc-string typo.
941 2011-12-11 Kenichi Handa <handa@m17n.org>
943 * coding.c (Funencodable_char_position): Pay attention to the
944 buffer text relocation (Bug#9389).
946 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
948 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
949 gtk_init (Bug#10100).
951 2011-12-10 Eli Zaretskii <eliz@gnu.org>
953 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
954 IT->string is nil. (Bug#10263)
956 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
958 * nsterm.h (x_free_frame_resources): Declare.
960 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
961 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
963 * nsterm.h (ns_get_defaults_value): Declare.
965 * nsterm.m (ns_default): Call ns_get_defaults_value.
967 2011-12-09 Eli Zaretskii <eliz@gnu.org>
969 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
972 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
974 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
975 that where the value of an _OBJC_* symbol points to is in the .bss
978 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
980 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
981 after the loop to call ccl_driver at least once (Bug#8619).
983 2011-12-08 Kenichi Handa <handa@m17n.org>
985 * ftfont.c (get_adstyle_property): Fix previous change
988 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
990 * w32.c (init_environment): If no_site_lisp, remove site-lisp
991 dirs from the default value of EMACSLOADPATH (bug#10208).
993 2011-12-07 Glenn Morris <rgm@gnu.org>
995 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
996 installation and source directories as well. (Bug#10208)
998 2011-12-06 Chong Yidong <cyd@gnu.org>
1000 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1002 2011-12-06 Glenn Morris <rgm@gnu.org>
1004 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1005 as an error, not just -1. (Bug#10217)
1007 2011-12-05 Chong Yidong <cyd@gnu.org>
1009 * keyboard.c (process_special_events): New function.
1010 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1012 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1014 * coding.c (encode_designation_at_bol): Don't use uninitialized
1015 local variable (Bug#9318).
1017 2011-12-05 Kenichi Handa <handa@m17n.org>
1019 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1020 return Qnil (Bug#8046, Bug#10193).
1022 2011-12-05 Kenichi Handa <handa@m17n.org>
1024 * coding.c (encode_designation_at_bol): New args charbuf_end and
1025 dst. Return the number of produced bytes. Callers changed.
1026 (coding_set_source): Return how many bytes coding->source was
1028 (coding_set_destination): Return how many bytes
1029 coding->destination was relocated.
1030 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1031 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1033 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1035 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1036 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1039 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1041 The following changes are to fix Bug#9318.
1043 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1044 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1045 (encode_coding_iso_2022, encode_coding_sjis)
1046 (encode_coding_big5, encode_coding_charset): Use the above macros.
1048 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1050 * lisp.h (process_quit_flag): Fix external declaration.
1052 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1054 Don't macro-inline non-performance-critical code.
1055 * eval.c (process_quit_flag): New function.
1056 * lisp.h (QUIT): Use it.
1058 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1060 * nsfns.m (get_geometry_from_preferences): New function.
1061 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1063 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1065 * emacs.c (Qkill_emacs): Define.
1066 (syms_of_emacs): Initialize it.
1067 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1068 Qquit_flag to `kill-emacs' instead.
1069 (quit_throw_to_read_char): Add parameter `from_signal'.
1070 All callers changed. Call Fkill_emacs if requested and safe.
1071 * lisp.h (QUIT): Call Fkill_emacs if requested.
1073 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1075 * widget.c (update_wm_hints): Return if wmshell is null.
1076 (widget_update_wm_size_hints): New function.
1078 * widget.h (widget_update_wm_size_hints): Declare.
1080 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1081 widget_update_wm_size_hints (Bug#10104).
1083 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1085 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1086 before a newline, prepare the bidi iterator for consuming the
1087 newline, and keep the current paragraph direction. (Bug#10183)
1088 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1090 2011-12-02 Juri Linkov <juri@jurta.org>
1092 * search.c (Fword_search_regexp): New Lisp function created from
1093 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1094 (Fword_search_backward, Fword_search_forward)
1095 (Fword_search_backward_lax, Fword_search_forward_lax):
1096 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1097 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1099 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1101 * fileio.c (Finsert_file_contents): Move after-change-function call
1102 to before the "handled:" label, since all "goto handled" appear in
1103 cases where the *-change-functions have already been properly called
1106 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1108 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1109 waiting for input. (Bug#10169)
1111 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1113 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1114 verifies glyph row's hash code--we have just reallocated the
1115 glyphs, so their contents can be complete garbage. (Bug#10164)
1117 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1119 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1121 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1123 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1124 attributes are tested _before_ calling verify_row_hash, to protect
1125 against GCC re-ordering of the tests. (Bug#10164)
1127 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1129 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1131 * xterm.c (handle_one_xevent): Only set async_visible and friends
1132 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1133 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1134 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1136 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1138 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1139 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1140 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1141 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1142 All uses changed to use GCPRO1 etc.
1143 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1144 Revert to old implementation (i.e., before 2011-03-11).
1146 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1148 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1149 of scroll runs so as to avoid assigning disabled bogus rows and
1150 unnecessary graphics copy operations.
1152 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1154 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1155 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1156 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1157 (malloc, free, realloc, calloc): Redirect to e_* only when
1160 * lisp.h (GCTYPEBITS): Move before first use.
1161 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1162 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1163 this macro definition.
1165 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1168 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1170 * gtkutil.c (xg_create_frame_widgets):
1171 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1172 present with Gtk+ 2.0.
1174 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1176 * fileio.c (Finsert_file_contents): Undo previous change; see
1177 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1179 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1181 Rename locals to avoid shadowing.
1182 * fileio.c (Finsert_file_contents):
1183 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1184 * process.c (wait_reading_process_output):
1185 Rename inner 'proc' to 'p' to avoid shadowing.
1186 Indent for consistency with usual Emacs style.
1188 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1190 * xdisp.c (redisplay_window): If cursor row is not fully visible
1191 after recentering, and scroll-conservatively is set to a large
1192 number, scroll window by a few more lines to make the cursor fully
1193 visible and out of scroll-margin. (Bug#10105)
1194 (start_display): Don't move to the next line if the display should
1195 start at a newline that is part of a display vector or an overlay
1198 2011-11-24 Juri Linkov <juri@jurta.org>
1200 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1201 after the `MagickPingImage' call. (Bug#10112)
1203 2011-11-23 Chong Yidong <cyd@gnu.org>
1205 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1207 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1209 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1210 making another buffer current. (Bug#10114)
1212 2011-11-23 Glenn Morris <rgm@gnu.org>
1214 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1216 2011-11-23 Chong Yidong <cyd@gnu.org>
1218 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1219 using it (Bug#5984).
1221 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1223 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1224 and header-lines, as they don't have one computed for them.
1227 * .gdbinit (prow): Make displayed values more self-explaining.
1228 Add row's hash code.
1230 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1232 * process.c (wait_reading_process_output): Fix asynchrounous
1233 GnuTLS socket handling on some versions of the GnuTLS library.
1234 (wait_reading_process_output): Add comment and URL.
1236 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1238 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1240 2011-11-21 Chong Yidong <cyd@gnu.org>
1242 * window.c (Fnext_window, Fprevious_window): Doc fix.
1244 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1246 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1248 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1250 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1252 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1254 * window.c (Fset_window_combination_limit): Rename argument
1256 (Vwindow_combination_limit): Remove "status" from doc-string.
1258 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1260 * m/ibms390.h: Remove.
1261 * m/ibms390x.h: Don't include "ibms390.h".
1263 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1265 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1266 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1268 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1270 * casetab.c (Fset_case_table):
1271 * charset.c (Fcharset_after): Fix typos.
1273 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1275 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1276 Otherwise, valgrind does not work on some platforms.
1277 Problem reported by Andreas Schwab in
1278 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1279 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1280 is set, removing the need for VIRT_ADDRESS_VARIES.
1281 (PURE_P): Use a more-efficient implementation that needs just one
1282 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1283 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1284 to 4 (xorl, subq, cmpq, setbe).
1285 * alloc.c (pure): Always extern now, since that's the
1286 VIRT_ADDR_VARIES behavior.
1287 (PURE_POINTER_P): Use a single comparison, not two, for
1288 consistency with the new puresize.h.
1289 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1290 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1291 Remove VIRT_ADDR_VARIES no longer needed.
1293 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1295 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1296 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1297 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1298 behave as if the cursor position were at the window margin.
1300 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1301 and the cursor position is out of bounds, behave as if the cursor
1302 position were at the window margin. (Bug#10075)
1304 2011-11-18 Chong Yidong <cyd@gnu.org>
1306 * window.c (Fwindow_combination_limit): Make first argument
1307 non-optional, since it is meaningless for live windows like the
1310 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1312 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1314 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1316 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1317 (graft_intervals_into_buffer): Simplify.
1319 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1321 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1322 hash values of the two rows.
1323 (copy_row_except_pointers): Preserve the used[] arrays and the
1324 hash values of the two rows. (Bug#10035)
1325 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1327 * xdisp.c (row_hash): New function, body extracted from
1328 compute_line_metrics.
1329 (compute_line_metrics): Call row_hash, instead of computing the
1332 * dispnew.c (verify_row_hash): Call row_hash for computing the
1333 hash code of a row, instead of duplicating code from xdisp.c.
1335 * dispextern.h (row_hash): Add prototype.
1337 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1339 * frame.c (delete_frame): Don't delete the terminal when the last
1340 X frame is closed if emacs is built with GTK toolkit.
1342 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1344 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1346 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1348 * window.c (Vwindow_splits): Rename to
1349 Vwindow_combination_resize. Suggested by Juri Linkov.
1350 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1353 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1355 * nsfns.m (Fns_font_name):
1356 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1358 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1360 * window.h (window): Rename slot "nest" to "combination_limit".
1361 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1362 (Fset_window_nest): Rename to Fset_window_combination_limit.
1363 (Vwindow_nest): Rename to Vwindow_combination_limit.
1364 (recombine_windows, make_parent_window, make_window)
1365 (Fsplit_window_internal, saved_window)
1366 (Fset_window_configuration, save_window_save): Rename all
1367 occurrences of window_nest to window_combination_limit.
1369 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1371 * image.c (imagemagick_load_image): Fix typo.
1373 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1375 * xdisp.c (display_line): Move the call to
1376 highlight_trailing_whitespace before the call to
1377 compute_line_metrics, since the latter needs to see the final
1378 faces of all the glyphs to compute ROW's hash value.
1379 Fixes assertion violations in row_equal_p. (Bug#10035)
1381 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1383 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1384 just return (bug#10044).
1386 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1388 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1389 with user-defined heap size. Bump the default size of the temacs
1390 heap to 27MB, to avoid memory warning when running temacs.
1391 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1393 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1394 current_matrix and desired_matrix. (Bug#9990)
1395 (verify_row_hash) [XASSERTS]: New function.
1396 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1397 that the hash value of glyph rows is correct.
1399 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1401 * window.h (window): Remove splits slot.
1402 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1403 (Fdelete_other_windows_internal, make_parent_window)
1404 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1405 (Fset_window_configuration, save_window_save): Don't deal with
1406 split status of windows.
1407 (saved_window): Remove splits slot.
1408 (Vwindow_splits): Rewrite doc-string.
1410 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1412 * xfns.c (unwind_create_frame):
1413 * nsfns.m (unwind_create_frame):
1414 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1415 Vframe_list (Bug#9999).
1417 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1419 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1421 2011-11-11 Kenichi Handa <handa@m17n.org>
1423 * callproc.c (Fcall_process): Set the member dst_multibyte of
1426 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1428 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1429 avoid a crash (bug#9496).
1431 2011-11-09 Chong Yidong <cyd@gnu.org>
1433 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1434 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1436 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1438 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1440 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1442 Avoid some portability problems by eschewing 'extern inline' functions.
1443 The trivial performance wins aren't worth the portability hassles; see
1444 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1446 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1447 (window_box_width, window_box_left, window_box_left_offset)
1448 (window_box_right, window_box_right_offset): Undo previous change,
1449 by removing the "extern"s.
1450 * intervals.c (adjust_intervals_for_insertion)
1451 (adjust_intervals_for_deletion): Undo previous change,
1452 making these static again.
1453 (offset_intervals, temp_set_point_both, temp_set_point)
1454 (copy_intervals_to_string): No longer inline.
1455 * xdisp.c (window_text_bottom_y, window_box_width)
1456 (window_box_height, window_box_left_offset)
1457 (window_box_right_offset, window_box_left, window_box_right)
1458 (window_box): No longer inline.
1460 2011-11-08 Chong Yidong <cyd@gnu.org>
1462 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1463 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1464 Signal an error if not a live window.
1465 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1466 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1468 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1470 * lisp.h (syms_of_abbrev): Remove declaration.
1471 Reported by CHENG Gao <chenggao@royau.me>.
1473 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1475 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1476 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1477 of temacs in GUI mode.
1479 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1481 * window.h: Declare delete_all_child_windows instead of
1482 delete_all_subwindows.
1483 * window.c (Fwindow_nest, Fset_window_nest)
1484 (Fset_window_new_total, Fset_window_new_normal)
1485 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1486 (delete_all_subwindows): Rename to delete_all_child_windows.
1487 (Fdelete_other_windows_internal, Fset_window_configuration):
1488 Call delete_all_child_windows instead of delete_all_subwindows.
1489 * frame.c (delete_frame): Call delete_all_child_windows instead
1490 of delete_all_subwindows.
1492 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1494 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1495 This is also needed for porting to any host where GC_MARK_STACK is
1496 not GC_MAKE_GCPROS_NOOPS.
1497 (which_symbols): Use it.
1499 2011-11-07 Kenichi Handa <handa@m17n.org>
1501 * coding.c (coding_set_destination): Check coding->src_pos only
1502 when coding->src_object is a buffer (bug#9910).
1504 * process.c (send_process): Set the member src_multibyte of coding
1505 to 0 (bug#9911) when sending a unibyte text.
1507 * callproc.c (Fcall_process): Set the member src_multibyte of
1508 process_coding to 0 (bug#9912).
1510 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1512 * xmenu.c (cleanup_widget_value_tree): New function.
1513 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1514 calling free_menubar_widget_value_tree directly (Bug#9830).
1516 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1518 Fix some portability problems with 'inline'.
1519 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1520 (window_box_width, window_box_left, window_box_left_offset)
1521 (window_box_right, window_box_right_offset): Declare extern.
1522 Otherwise, these inline functions do not conform to C99 and
1523 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1524 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1525 * intervals.c (adjust_intervals_for_insertion)
1526 (adjust_intervals_for_deletion): Now extern, because otherwise the
1527 extern inline functions 'offset_intervals' couldn't refer to it.
1528 (static_offset_intervals): Remove.
1529 (offset_intervals): Rewrite using the old contents of
1530 static_offset_intervals. The old version didn't conform to C99
1531 because an extern inline function contained a reference to an
1532 identifier with static linkage.
1534 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1536 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1539 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1541 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1542 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1543 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1544 return Qleft_to_right.
1546 2011-11-06 Chong Yidong <cyd@gnu.org>
1548 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1549 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1550 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1551 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1552 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1553 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1554 (Fwindow_vscroll): Doc fix.
1555 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1556 argument, since it makes no sense to pass a live window and for
1557 consistency with window-child.
1559 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1561 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1564 2011-11-05 Jason Rumney <jasonr@gnu.org>
1566 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1567 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1569 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1570 bitwise arithmetic preventing use of unicode-sip and non-truetype
1573 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1575 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1578 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1579 initialization code to keep similarity to xfns.c after changes
1582 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1584 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1585 (unwind_create_frame): New function (Bug#9943).
1586 (Fx_create_frame): Restructure code to be more similar to the one in
1587 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1588 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1589 Move terminal->reference_count++ just before making the frame official
1592 * nsterm.m (x_free_frame_resources): New function.
1593 (x_destroy_window): Move code to x_free_frame_resources.
1595 * xfns.c (unwind_create_frame): Fix comment.
1596 (Fx_create_frame, x_create_tip_frame):
1597 Move terminal->reference_count++ just before making the frame
1598 official. Move initialization of image_cache_refcount and
1599 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1601 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1603 Support MSVC build with newer versions of Visual Studio.
1604 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1605 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1608 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1609 which are not supported by MSVC.
1610 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1611 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1613 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1615 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1617 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1619 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1621 Support MSVC build with newer versions of Visual Studio.
1622 * w32.c: Don't include w32api.h for MSVC.
1623 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1625 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1626 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1627 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1628 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1630 (alloca) [_MSC_VER]: Define to _alloca.
1632 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1634 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1636 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1638 * xdisp.c (note_mouse_highlight): If either of
1639 previous/next-single-property-change returns nil, treat that as
1640 the beginning or the end of the buffer. (Bug#9955)
1642 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1644 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1645 label is not null (Bug#9951).
1646 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1649 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1651 * window.c (Fwindow_body_size): Mention in the doc string that the
1652 return value is in frame's canonical units. (Bug#9949)
1654 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1656 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1658 * w32fns.c (unwind_create_frame): If needed, free the glyph
1659 matrices of the partially constructed frame. (Bug#9943)
1660 * xfns.c (unwind_create_frame): Likewise.
1662 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1664 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1665 Don't stop backward scan on the continuation glyph, even though
1666 its CHARPOS is positive.
1667 (mouse_face_from_buffer_pos, note_mouse_highlight):
1668 Rename cover_string to disp_string.
1670 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1672 * window.c (temp_output_buffer_show): Don't use
1673 Vtemp_buffer_show_specifiers.
1674 (Vtemp_buffer_show_specifiers): Remove unused variable.
1676 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1678 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1679 past the beginning of the current glyph matrix.
1681 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1683 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1684 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1685 HAVE_GTK3 (Bug#9869).
1687 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1688 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1690 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1692 * xterm.c: Declare x_handle_net_wm_state to return int.
1693 (handle_one_xevent): Check if we are iconified but don't have
1694 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1695 (get_current_wm_state): Return non-zero if not hidden,
1696 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1697 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1698 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1699 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1701 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1703 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1704 so that this new function doesn't get optimized away by a
1705 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1707 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1709 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1711 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1713 Fix the `xbytecode' command.
1714 * .gdbinit (xprintbytestr): New command.
1715 (xwhichsymbols): Rename from `which'; all callers changed.
1716 (xbytecode): Print the byte-code string as well.
1718 2011-10-29 Kim Storm <storm@cua.dk>
1720 * alloc.c (which_symbols): New function.
1722 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1724 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1727 2011-10-29 Glenn Morris <rgm@gnu.org>
1729 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1730 Not clear what it was for, and it causes various bugs. (Bug#9839)
1732 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1734 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1735 possible random value that matches one of those tested as
1736 condition to clear the mouse face.
1738 2011-10-28 Chong Yidong <cyd@gnu.org>
1740 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1742 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1744 * window.c (make_window): Initialize phys_cursor_on_p.
1746 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1748 * lisp.h (struct Lisp_Symbol): Update comments.
1750 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1752 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1754 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1756 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1757 <oslsachem@gmail.com> for helping to debug this.
1759 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1760 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1761 (g_b_init_get_glyph_outline_w): New static variables.
1762 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1763 (GetGlyphOutlineW_Proc): New typedefs.
1764 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1765 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1767 (w32font_open_internal, compute_metrics):
1768 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1769 instead of calling the "wide" APIs directly.
1771 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1773 * w32.h (syms_of_w32font): Add prototype.
1775 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1777 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1778 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1779 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1780 (Fmove_to_window_line): Doc fix.
1782 2011-10-27 Chong Yidong <cyd@gnu.org>
1784 * process.c (make_process): Set gnutls_state to NULL.
1786 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1787 non-NULL, regardless of GNUTLS_INITSTAGE.
1788 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1789 an error. Set process slots as soon as we allocate them.
1791 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1793 2011-10-27 Chong Yidong <cyd@gnu.org>
1795 * gnutls.c (emacs_gnutls_deinit): New function.
1796 Deallocate credentials structures as well as calling gnutls_deinit.
1797 (Fgnutls_deinit, Fgnutls_boot): Use it.
1799 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1800 (deactivate_process): Call emacs_gnutls_deinit.
1802 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1804 * image.c (x_create_x_image_and_pixmap):
1805 * w32.c (sys_rename, w32_delayed_load):
1806 * w32font.c (fill_in_logfont):
1807 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1809 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1811 * w32fns.c (w32_default_color_map): New function,
1812 extracted from Fw32_default_color_map.
1813 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1815 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1817 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1819 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1821 * keyboard.c (test_undefined): New function (bug#9751).
1822 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1824 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1826 * sysdep.c (init_sys_modes): Fix the check for the controlling
1827 terminal (Bug#6649).
1829 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1831 * dispextern.h (struct bidi_it): New member next_en_type.
1833 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1834 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1835 current character, check also for next_en_type being WEAK_EN.
1836 (bidi_resolve_weak): Don't enter the expensive loop if the current
1837 position is before next_en_pos. Record the bidi type of the first
1838 non-ET, non-BN character we find, in addition to its position.
1839 (bidi_level_of_next_char): Invalidate next_en_type when
1840 next_en_pos is over-stepped.
1842 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1844 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1845 * editfns.c: Rewrite current-time-zone so that it invokes
1846 the equivalent of (format-time-string "%Z") to get the time zone name.
1847 This fixes a bug when the time zone name contains characters that
1848 need converting from the system time locale to Emacs internal format.
1849 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1850 that patch fixed format-time-string to do the conversion, but
1851 I forgot to fix current-time-zone.
1852 (format_time_string): New function, containing most of
1853 what Fformat_time_string used to contain.
1854 (Fformat_time_string): Rewrite in terms of format_time_string.
1855 This doesn't change this function's behavior.
1856 (current-time-zone): Rewrite to use format_time_string.
1857 This fixes the bug reported by Michael Schierl in
1858 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1859 Jason Rumney's 2007-06-07 change worked around this bug, but
1861 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1863 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1865 * xdisp.c (start_display): If the character at POS is displayed
1866 via a display vector, reset IT->current.dpvec_index to zero.
1867 (try_window_reusing_current_matrix): If a line ends in a display
1868 vector or the next line starts in a display vector, continue
1869 redrawing the window even though the character position of
1870 start_row was reached.
1873 2011-10-18 Chong Yidong <cyd@gnu.org>
1875 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1876 with nobreak-char-display too.
1878 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1880 Fix part 3 of bug#9771.
1881 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1882 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1883 non-neutral characters if the current character is a paragraph
1884 separator (a.k.a. Newline). This avoids running the same
1885 expensive loop twice, once when we consume the preceding newline
1886 and the other time when the line actually needs to be displayed.
1887 Avoid the loop when we see neutrals on the base embedding level
1888 following a character whose directionality is the same as the
1889 paragraph's. This avoids running the expensive loop when a line
1890 ends in a long sequence of neutrals, like control characters.
1891 Add assertion against STRONG_AL type. Slightly rearrange code
1892 that determines the type of a neutral given the first non-neutral
1894 (bidi_level_of_next_char): Set next_en_pos to zero when
1895 invalidating its info.
1897 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1899 * xdisp.c (push_display_prop): Determine whether to record string
1900 or buffer position by IT->string, not by IT->method. Allow
1901 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1902 (move_it_vertically_backward): Don't look for character position
1903 immediately after the newline when in a continuation line.
1906 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1908 * window.c (coordinates_in_window): Rewrite and delabelize
1909 vertical border check. (Bug#5357) (Bug#9618)
1911 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1913 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1914 errors in XSetWindowBorder (bug#9310).
1916 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1918 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1919 avoid crash when xmalloc overrun checking is enabled.
1921 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1923 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1924 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1925 cursor motion with <left> and <right> arrow keys.
1927 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1928 some callers set that themselves.
1930 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1932 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1933 display string and the previous row comes from the same string and
1934 is empty. (Bug#9739) (Bug#9738)
1936 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1938 * doc.c (get_doc_string): Encode file name (bug#9735).
1940 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1942 * bidi.c (bidi_level_of_next_char):
1943 * xdisp.c (get_visually_first_element): Remove old incorrect
1944 comments regarding the Unicode Line Separator character.
1946 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1948 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1950 * alloc.c (Fgc_status): Do not access beyond zombies array
1951 boundary if nzombies > MAX_ZOMBIES.
1952 * alloc.c (dump_zombies): Add missing format specifier.
1954 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1956 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1957 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1959 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1960 Some packages use them to denote characters with modifiers.
1962 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1964 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1965 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1966 matching a pp-number. Rename parameter var to var1.
1968 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1970 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1972 2011-10-08 Glenn Morris <rgm@gnu.org>
1974 * callint.c (Fcall_interactively): Give a more explicit error for the
1975 'c' case with a non-character input. (Bug#8479)
1977 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1979 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1981 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1982 lines that are hscrolled on the left.
1984 * dispnew.c (buffer_posn_from_coords): Account for a possible
1985 presence of header-line. (Bug#4426)
1987 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1989 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1990 Don't advertise functionality which we discourage or doesn't work.
1992 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1994 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1995 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1996 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1997 this makes Emacs dump core during garbage collection on rare
1998 occasions. sizeof is obviously inferior to offsetof here, so
1999 stick with offsetof.
2000 (GC_POINTER_ALIGNMENT): New macro.
2001 (mark_memory): Omit 3rd (offset) arg; caller changed.
2002 Don't assume EMACS_INT alignment is the same as pointer alignment.
2004 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2006 * keyboard.c (read_key_sequence_remapped): New var.
2007 (read_key_sequence): Compute remapping in the right buffer.
2008 (command_loop_1): Use read_key_sequence's remapping directly.
2010 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2012 * dired.c (file_name_completion): Don't expand file name.
2013 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2014 before checking file name handler.
2016 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2017 they've been requested explicitly (bug#9591).
2019 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2021 * keymap.c (Fsingle_key_description): Use make_specified_string
2022 instead of build_string to build string from push_key_description.
2025 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2027 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2028 This fixes a Y2038 bug on 64-bit hosts.
2029 * buffer.c (reset_buffer):
2030 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2031 (Fclear_buffer_auto_save_failure):
2032 Use 0, not -1, to represent an unset failure time, since time_t
2033 might not be signed.
2035 Remove dependency on glibc malloc internals.
2036 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2037 Move back here from lisp.h, but with their new implementations.
2038 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2039 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2040 * charset.c (charset_table_init): New static var.
2041 (syms_of_charset): Use it instead of xmalloc. This removes a
2042 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2043 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2044 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2045 Move back to alloc.c.
2046 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2047 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2049 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2051 * nsterm.m (windowDidResize): Call x_set_window_size only when
2052 ns_in_resize is true. Otherwise set pixelwidth/height and
2053 call change_frame_size (Bug#9628).
2055 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2057 Port --enable-checking=all to Fedora 14 x86-64.
2058 * charset.c (syms_of_charset): Also account for glibc malloc's
2059 internal overhead when calculating the initial malloc maximum.
2061 Port --enable-checking=all to Fedora 14 x86.
2062 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2064 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2065 (overrun_check_realloc, overrun_check_free):
2066 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2067 That way, xmalloc returns a properly-aligned pointer even if
2068 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2069 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2070 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2071 into account when calculating the initial malloc maximum.
2072 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2073 Move here from alloc.c, so that charset.c can use it too.
2074 Properly align; the old code wasn't right for common 32-bit hosts
2075 when configured with --enable-checking=all.
2076 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2077 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2079 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2081 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2084 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2086 * xdisp.c (compute_display_string_end): If there's no display
2087 string at CHARPOS, return -1.
2089 * bidi.c (bidi_fetch_char): When compute_display_string_end
2090 returns a negative value, treat the character as a normal
2091 character not covered by a display string. (Bug#9624)
2093 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2095 * lread.c (Fread_from_string): Fix typo in docstring.
2097 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2099 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2100 newline, reseat the iterator instead of bidi-iterating there one
2101 character at a time. (Bug#9610)
2102 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2103 TO_CHARPOS if the bidi iterator is at base embedding level.
2105 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2107 * lread.c (readevalloop): Use correct code for NBSP.
2108 (read1): Likewise. (Bug#9608)
2110 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2112 * dbusbind.c (Fdbus_register_signal): When service is not
2113 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2115 2011-09-25 Glenn Morris <rgm@gnu.org>
2117 * buffer.c (truncate-lines): Doc fix.
2119 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2121 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2122 (Fset_window_next_buffers): Doc fix.
2124 2011-09-24 Glenn Morris <rgm@gnu.org>
2126 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2128 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2130 Fix minor problems found by static checking.
2131 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2132 * indent.c (Fvertical_motion): Fix == vs = typo.
2134 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2136 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2137 Default value is now t. Doc fix.
2139 * indent.c (Fvertical_motion): Compute and apply the overshoot
2140 logic when moving up, not only when moving down. Fix the
2141 confusing name and values of the it_overshoot_expected variable;
2142 logic changes accordingly. (Bug#9254) (Bug#9549)
2144 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2145 CHARPOS is covered by a display string which includes newlines.
2146 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2147 is covered by a display string with embedded newlines.
2149 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2151 * dbusbind.c (Fdbus_register_signal): Add match rule to
2152 Vdbus_registered_objects_table. (Bug#9581)
2153 (Fdbus_register_method, Vdbus_registered_objects_table):
2156 2011-09-24 Jim Meyering <meyering@redhat.com>
2158 do not ignore write error for any output size
2159 The previous change was incomplete.
2160 While it makes emacs --batch detect the vast majority of stdout
2161 write failures, errors were still ignored whenever the output size is
2162 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2163 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2164 && echo FAIL: ignored write error
2165 FAIL: ignored write error
2166 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2167 && echo FAIL: ignored write error
2168 FAIL: ignored write error
2169 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2171 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2173 * emacs.c (Fkill_emacs): In noninteractive mode exit
2174 non-successfully if a write error occurred on stdout. (Bug#9574)
2176 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2178 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2181 * dispextern.h (struct it): Update the comment documenting what
2184 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2186 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2187 a display string, extend search for cursor position to end of row.
2188 (find_row_edges): If the row ends in a newline from a display
2189 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2190 Handle the case of a display string with multiple newlines.
2191 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2192 non-empty line. Fixes confusing cursor motion with arrow keys at
2193 the beginning of a line that starts with whitespace.
2195 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2197 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2200 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2202 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2205 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2207 * xdisp.c (display_line): Record maximum and minimum buffer
2208 positions even if no glyphs were produced (e.g., by a zero-width
2209 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2210 buffer positions that will be removed from the glyph row because
2212 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2213 column is beyond frame width: don't subtract 1 "pixel" when
2214 computing width of the stretch.
2215 (reseat_at_next_visible_line_start): Undo the change made on
2216 2011-09-17 that saved paragraph information and restored it after
2217 the call to `reseat'. (Bug#9545)
2219 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2221 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2222 and turn window cursor on if cleared (Bug#9415).
2224 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2226 * search.c (boyer_moore): Take unibyte characters from pattern
2227 literally. (Bug#9458)
2229 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2231 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2233 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2235 Fix minor problem found by static checking.
2236 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2237 initialized, to pacify gcc -Wuninitialized.
2239 * fileio.c: Report proper errno when syscall falls.
2240 (Finsert_file_contents): Save and restore errno,
2241 so that report_file_error outputs the correct diagnostic.
2242 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2244 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2246 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2248 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2250 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2251 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2253 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2255 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2256 about the current paragraph and restore it after the call to reseat.
2258 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2259 (bidi_find_paragraph_start): Search back for paragraph beginning
2260 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2261 (bidi_move_to_visually_next): Only trigger paragraph-related
2262 computations when the last character is a newline or at EOB, not
2263 just any NEUTRAL_B. (Bug#9470)
2265 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2266 truncated lines if point is covered by a display string. (Bug#9524)
2268 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2270 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2271 (cons_to_x_long): New function.
2272 (lisp_data_to_selection_data): Use it. Correct the test for
2273 short-versus-long data; it was negated. Break out of vector
2274 loop, for efficiency, when a long datum is discovered.
2276 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2278 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2280 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2282 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2283 GCC PR/17406) by declaring this function with external scope.
2285 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2287 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2288 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2290 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2292 * editfns.c (Fformat): Correctly handle text properties on "%%".
2294 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2296 * xterm.c (x_draw_composite_glyph_string_foreground):
2297 * w32term.c (x_draw_composite_glyph_string_foreground):
2298 * term.c (encode_terminal_code):
2299 * composite.c (composition_update_it, get_composition_id):
2300 * xdisp.c (get_next_display_element)
2301 (fill_composite_glyph_string): Add comments about special meaning
2302 of TAB characters in a composition.
2304 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2306 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2307 This occurs when processing a multibyte format.
2308 Problem reported by Wolfgang Jenker.
2310 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2312 * xdisp.c (try_cursor_movement): Only check for exact match if
2313 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2315 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2317 Remove unused external symbols.
2318 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2319 * xdisp.c (calc_pixel_width_or_height): Now static.
2320 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2321 * indent.c (check_display_width):
2322 * w32term.c: Fix comment to match code.
2323 * xterm.c, xterm.h (x_catching_errors): Remove.
2325 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2327 * xselect.c: Use signed conversions more consistently (Bug#9498).
2328 (selection_data_to_lisp_data): Assume incoming selection data are
2329 signed integers, not unsigned. This is to be consistent with
2330 outgoing selection data, which was modified to use signed integers
2331 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2332 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2333 expects long, not unsigned long.
2335 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2337 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2338 computation of loop end. Reported by Johan Bockgård
2341 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2343 * frame.c (Fother_visible_frames_p): Function deleted.
2345 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2347 * indent.c (compute_motion): Process display vector front to back
2348 rather than the other way around. (Bug#2496)
2350 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2352 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2354 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2356 * minibuf.c (Fread_from_minibuffer): Doc fix.
2358 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2360 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2361 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2363 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2365 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2366 value for non-existent files.
2368 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2370 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2371 set its "size" to -1. This will set the modtime_size field of
2372 the corresponding buffer to -1, which is what
2373 verify-visited-file-modtime expects for files that do not exist.
2376 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2378 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2380 * lisp.h: ... from here. push_key_description is no longer
2381 defined in keyboard.c, so its declaration should not be in
2382 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2383 logically belongs with push_key_description.
2385 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2387 * buffer.h: Include <sys/types.h> instead of <time.h>.
2388 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2389 Problem reported by Herbert J. Skuhra.
2391 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2393 * xml.c (parse_region): Make the parsing work for
2394 non-comment-starting XML files again (bug#9144).
2396 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2398 * image.c (gif_load): Fix calculation of bottom and right corner.
2401 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2403 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2404 redisplay in small windows.
2406 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2408 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2410 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2412 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2413 Operate on live windows only.
2415 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2417 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2419 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2421 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2422 only under bidi iteration.
2424 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2426 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2428 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2430 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2431 Without this fix, the command to link temacs failed due to an
2432 undefined symbol __builtin_isnan. This is because
2433 /usr/include/iso/math_c99.h #defines isnan(x) to
2434 __builtin_isnan(x), but the bundled gcc, which identifies itself
2435 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2437 * floatfns.c (isnan): #undef, and then #define to a clone of
2439 (Fisnan): Always define, since it's always available now.
2440 (syms_of_floatfns): Always define isnan at the Lisp level.
2442 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2444 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2446 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2448 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2449 The previous code assumed that file offsets (off_t values) fit in
2450 EMACS_INT variables, which is not true on typical 32-bit hosts.
2451 The code messed up by falsely reporting buffer overflow in cases
2452 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2453 when "big" contains more than 2**29 bytes, even though this
2454 inserts just one byte and does not overflow the buffer.
2455 (Finsert_file_contents): Store file offsets as off_t
2456 values, not as EMACS_INT values. Check for overflow when
2457 converting between EMACS_INT and off_t. When checking for
2458 buffer overflow or for overlap, take the offsets into account.
2459 Don't use EMACS_INT for small values where int suffices.
2460 When checking for overlap, fix a typo: ZV was used where
2461 ZV_BYTE was intended.
2462 (Fwrite_region): Don't assume off_t fits into 'long'.
2463 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2465 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2467 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2469 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2471 sprintf-related integer and memory overflow issues (Bug#9412).
2473 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2474 (esprintf, exprintf, evxprintf): New functions.
2475 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2476 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2477 (modify_event_symbol): Do not assume that the length of
2478 name_alist_or_stem is safe to alloca and fits in int.
2479 (Fexecute_extended_command): Likewise for function name and binding.
2480 (Frecursion_depth): Wrap around reliably on integer overflow.
2481 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2482 since some callers pass EMACS_INT values.
2483 (Fsingle_key_description): Don't crash if symbol name contains more
2484 than MAX_ALLOCA bytes.
2485 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2486 (get_minibuffer): Arg is now EMACS_INT, not int.
2487 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2488 (esprintf, exprintf, evxprintf): New decls.
2489 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2491 * dbusbind.c (signature_cat): New function.
2492 (xd_signature, Fdbus_register_signal):
2493 Do not overrun buffer; instead, report string overflow.
2495 * dispnew.c (add_window_display_history): Don't overrun buffer.
2496 Truncate instead; this is OK since it's just a log.
2498 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2499 even if the time zone offset is outlandishly large.
2500 Don't mishandle offset == INT_MIN.
2502 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2503 when creating daemon; the previous buffer-overflow check was incorrect.
2505 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2506 which has the guts of the old verror function.
2508 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2509 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2511 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2512 (font_unparse_xlfd): Don't blindly alloca long strings.
2513 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2514 fits in int, when using sprintf. Use single snprintf to count
2515 length of string rather than counting it via multiple sprintfs;
2516 that's simpler and more reliable.
2517 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2518 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2519 sprintf, in case result does not fit in int.
2521 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2522 (fontset_from_font): Print it.
2524 * frame.c (tty_frame_count): Now printmax_t, not int.
2525 (make_terminal_frame, set_term_frame_name): Print it.
2526 (x_report_frame_params): In X, window IDs are unsigned long,
2527 not signed long, so print them as unsigned.
2528 (validate_x_resource_name): Check for implausibly long names,
2529 and don't assume name length fits in 'int'.
2530 (x_get_resource_string): Don't blindly alloca invocation name;
2531 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2534 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2535 (xg_check_special_colors, xg_set_geometry):
2536 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2538 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2539 Use esprintf, not sprintf, in case result does not fit in int.
2541 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2542 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2543 it as a large positive number.
2544 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2545 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2547 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2548 in case result does not fit in int.
2550 * print.c (float_to_string): Detect width overflow more reliably.
2551 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2552 buffer overrun. Don't assume list length fits in 'int'. Treat
2553 print length of 0 as 0, not as infinity; to be consistent with other
2554 uses of print length in this function. Don't overflow print length
2555 index. Don't assume hash table size fits in 'long', or that
2556 vectorlike size fits in 'unsigned long'.
2558 * process.c (make_process): Use printmax_t, not int, to format
2559 process-name gensyms.
2561 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2563 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2564 to avoid potential buffer overrun.
2566 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2567 if X resource line is longer than 512 bytes.
2569 * xfns.c (x_window): Make sprintf buffer a bit bigger
2570 to avoid potential buffer overrun.
2572 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2574 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2576 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2578 Integer overflow fixes for scrolling, etc.
2579 Without these, Emacs silently mishandles large integers sometimes.
2580 For example, "C-u 4294967297 M-x recenter" was treated as if
2581 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2583 * xdisp.c (try_window_id): Check Emacs fixnum range before
2584 converting to 'int'.
2586 * window.c (window_scroll_line_based, Frecenter):
2587 Check that an Emacs fixnum is in range before assigning it to 'int'.
2588 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2589 values converted from Emacs fixnums.
2590 (Frecenter): Don't wrap around a line count if it is out of 'int'
2591 range; instead, treat it as an extreme value.
2592 (Fset_window_configuration, compare_window_configurations):
2593 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2595 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2596 that can exceed INT_MAX. Check that EMACS_INT value is in range
2597 before assigning it to the (possibly-narrower) index.
2598 (match_limit): Don't assume that a fixnum can fit in 'int'.
2600 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2603 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2604 (Fvertical_motion): Don't wrap around LINES values that don't fit
2605 in 'int'. Instead, treat them as extreme values. This is good
2606 enough for windows, which can't have more than INT_MAX lines anyway.
2608 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2610 * Require libxml/parser.h to avoid compilation warning.
2612 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2614 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2615 since this reportedly can destroy thread storage.
2617 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2619 * syntax.c (find_defun_start): Update all cache variables if
2620 exiting early (Bug#9401).
2622 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2624 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2626 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2627 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2628 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2630 * term.c (tty_append_glyph): New function.
2631 (produce_stretch_glyph): Static function and its prototype deleted.
2633 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2636 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2638 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2639 when checking :margin (Bug#9390).
2640 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2641 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2642 so that the name doesn't mislead. All uses changed.
2644 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2646 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2649 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2651 * xdisp.c (move_it_to): Don't bail out early when reaching
2652 position beyond to_charpos, if we are scanning backwards.
2653 (move_it_vertically_backward): When DY == 0, make sure we get to
2654 the first character in the line after the newline.
2656 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2658 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2659 (ccl_driver): Do not generate an out-of-range pointer.
2660 (Fccl_execute_on_string): Remove unnecessary check for
2661 integer overflow, noted by Stefan Monnier in
2662 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2663 Remove a FIXME that didn't need fixing.
2664 Simplify the newly-introduced buffer reallocation code.
2666 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2668 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2670 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2672 Integer and memory overflow issues (Bug#9196).
2674 * doc.c (get_doc_string): Rework so that
2675 get_doc_string_buffer_size is the actual buffer size, rather than
2676 being 1 less than the actual buffer size; this makes xpalloc more
2679 * image.c (x_allocate_bitmap_record, cache_image):
2680 * xselect.c (Fx_register_dnd_atom):
2681 Simplify previous changes by using xpalloc.
2683 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2684 since either will do and ptrdiff_t is convenient with xpalloc.
2686 * charset.c (charset_table_size)
2687 (struct charset_sort_data.priority): Now ptrdiff_t.
2688 (charset_compare): Don't overflow if priorities differ greatly.
2689 (Fsort_charsets): Don't assume list length fits in int.
2690 Check for size-calculation overflow when allocating sort data.
2691 (syms_of_charset): Allocate an initial charset table that is
2692 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2694 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2696 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2697 The actual value is always <= INT_MAX, and leaving it unsigned made
2698 overflow checking harder.
2700 * dispextern.h (struct glyph_matrix.rows_allocated)
2701 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2702 with xpalloc. The values are still always <= INT_MAX.
2704 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2706 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2707 (SAFE_NALLOCA): New macro.
2709 * region-cache.c (struct boundary.pos, find_cache_boundary)
2710 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2711 (set_cache_region, invalidate_region_cache)
2712 (revalidate_region_cache, know_region_cache, region_cache_forward)
2713 (region_cache_backward, pp_cache):
2714 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2715 so that ptrdiff_t * can be passed to xpalloc.
2716 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2717 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2718 (pp_cache): Don't assume cache_len fits in int.
2719 * region-cache.h: Adjust extern decls to match.
2721 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2722 EMACS_INT, since either will do, for xpalloc.
2724 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2725 (xnmalloc, xnrealloc, xpalloc): New functions.
2727 * bidi.c (bidi_shelve_header_size): New constant.
2728 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2729 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2731 * bidi.c (bidi_cache_shrink):
2732 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2734 Don't update size of array until after memory allocation succeeds,
2735 because xmalloc/xrealloc may not return.
2736 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2737 now that we have proper integer overflow checking.
2738 (record_overlay_string, overlay_strings): Catch overflows when
2739 calculating size of overlay_str_buf.
2741 * callproc.c (Fcall_process): Check for size overflow when
2742 calculating size of args2.
2743 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2744 Normally we prefer signed values, but sticking with ptrdiff_t would
2745 require adding more-complicated checks.
2747 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2748 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2749 Redo buffer-overflow calculations to avoid integer overflow.
2750 Add a FIXME comment where memory seems to be over-allocated.
2752 * character.c (Fstring): Check for size-calculation overflow.
2754 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2755 unnecessary integer overflow. Check for size overflow.
2756 (encode_coding_object): Don't update size until xmalloc succeeds.
2758 * composite.c (get_composition_id): Check for overflow in glyph
2759 length calculations.
2761 Integer and memory overflow fixes for display code.
2762 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2763 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2764 (scrolling_window): Check for overflow in size calculations.
2765 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2766 Don't assume glyph table len fits in int.
2767 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2768 (row_table_size): Now ptrdiff_t, not int.
2769 (scrolling_window): Avoid overflow in size calculations.
2770 Don't update size until allocation succeeds.
2771 * fns.c (concat): Check for overflow in size calculations.
2772 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2773 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2774 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2776 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2777 (get_doc_string): Check for size calculation overflow.
2778 Don't update size until allocation succeeds.
2779 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2780 EMACS_INT, where ptrdiff_t will do.
2781 (Fsubstitute_command_keys): Check for string overflow.
2783 * editfns.c (set_time_zone_rule): Don't assume environment length
2785 (message_length): Now ptrdiff_t, not int.
2786 (Fmessage_box): Don't update size until allocation succeeds.
2787 Don't assume message length fits in int.
2788 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2790 * emacs.c (main): Do not reallocate argv, since there is a null at
2791 the end that can be overwritten, and this way there's no need to
2792 worry about size-calculation overflow.
2793 (sort_args): Check for size-calculation overflow.
2795 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2797 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2799 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2800 (x_set_scroll_bar_width, x_figure_window_size):
2801 Check for integer overflow.
2802 (x_set_alpha): Do not assume XINT fits in int.
2804 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2805 This is for the members text_lines, text_cols, total_lines, total_cols,
2806 where the system imposes an 'int' limit.
2808 * fringe.c (Fdefine_fringe_bitmap):
2809 Don't update size until alloc works.
2811 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2812 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2814 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2815 Check for size-calculation overflow.
2816 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2817 do, as we prefer signed integers.
2818 (id_to_widget.max_size, id_to_widget.used)
2819 (xg_store_widget_in_map, xg_remove_widget_from_map)
2820 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2821 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2822 Use and return ptrdiff_t, not int.
2823 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2824 * gtkutil.h: Change prototypes to match the above.
2826 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2827 are duplicate now that they've been promoted to lisp.h.
2828 (x_allocate_bitmap_record, x_alloc_image_color)
2829 (make_image_cache, cache_image, xpm_load):
2830 Don't update size until alloc is done.
2831 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2833 Check for size calculation overflow.
2834 (ct_colors_allocated_max): New constant.
2835 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2838 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2839 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2840 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2841 Use ptrdiff_t, not int, to count maps.
2842 (read_char_minibuf_menu_prompt): Check for overflow in size
2843 calculations. Don't update size until allocation succeeds.
2844 Redo calculations to avoid overflow.
2845 * keyboard.h: Change prototypes to match the above.
2847 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2849 (current_minor_maps): Check for size calculation overflow.
2850 * keymap.h: Change prototypes to match the above.
2852 * lread.c (read1, init_obarray): Don't update size until alloc done.
2854 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2855 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2857 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2858 Now ptrdiff_t, not int.
2859 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2860 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2862 * process.c (Fnetwork_interface_list): Check for overflow
2863 in size calculation.
2865 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2867 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2868 overflow. Don't bother calling xmalloc when xrealloc will do.
2870 * search.c (Freplace_match): Check for size calculation overflow.
2871 (Fset_match_data): Don't assume list lengths fit in 'int'.
2873 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2874 for command line length. Do not attempt to address one before the
2875 beginning of an array, as that's not portable.
2877 * term.c (max_frame_lines): Remove; unused.
2878 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2880 (encode_terminal_code, calculate_costs): Check for size
2881 calculation overflow.
2882 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2883 table lengths and related sizes. Don't update size until alloc
2884 done. Redo calculations to avoid overflow.
2885 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2887 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2888 subtracting pointers.
2889 (gobble_line): Check for overflow more carefully. Don't update size
2892 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2893 Don't update size until alloc done.
2894 Redo size calculations to avoid overflow.
2895 Check for size calculation overflow.
2896 (main) [DEBUG]: Fix typo in invoking tparam1.
2898 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2899 Use ptrdiff_t, not int, for sizes.
2900 (store_mode_line_noprop_char): Don't update size until alloc done.
2902 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2903 Use ptrdiff_t, not int, for sizes.
2904 (Finternal_make_lisp_face, cache_face):
2905 Check for size calculation overflow.
2906 (cache_face): Treat size calculation overflows as if they were
2907 memory exhaustion (the usual treatment), rather than aborting.
2909 * xfns.c (x_encode_text, x_set_name_internal)
2910 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2911 sizes, since they can exceed INT_MAX in size. Check for size
2912 calculation overflow.
2914 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2915 (xg_select): Check for size calculation overflow.
2916 Don't update size until alloc done.
2918 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2919 as sprintf is limited to int lengths.
2921 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2922 (X_LONG_MIN): New macros.
2923 Use them to make the following changes clearer.
2924 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2925 This change doesn't affect the value now, but it may help remind
2926 future maintainers not to raise the value too much later.
2927 (SELECTION_QUANTUM): Remove, replacing with ...
2928 (selection_quantum): ... new function, which avoids overflow.
2930 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2931 assumption that selection length fits in 'int'.
2932 (x_reply_selection_request, x_handle_selection_request)
2933 (x_get_window_property, receive_incremental_selection)
2934 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2935 (lisp_data_to_selection_data, clean_local_selection_data):
2936 Use ptrdiff_t, not int, to record length of selection.
2937 (x_reply_selection_request, x_get_window_property)
2938 (receive_incremental_selection, x_property_data_to_lisp):
2939 Redo calculations to avoid overflow.
2940 (x_reply_selection_request): When sending hint, ceiling it at
2941 X_LONG_MAX rather than relying on wraparound overflow to send
2943 (x_get_window_property, receive_incremental_selection)
2944 (lisp_data_to_selection_data, x_property_data_to_lisp):
2945 Check for size-calculation overflow.
2946 (x_get_window_property, receive_incremental_selection)
2947 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2948 Don't store size until memory allocation succeeds.
2949 (x_get_window_property): Plug memory leak on memory exhaustion.
2950 Don't double-block input; malloc is safe here. Don't assume 2**34
2951 - 4 fits in unsigned long. Add an xassert to check
2952 XGetWindowProperty overflow. Be more careful about overflow
2953 calculations, and distinguish size from memory overflow better.
2954 (receive_incremental_selection): When tracing, don't assume
2955 unsigned int is less than INT_MAX.
2956 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2957 harmful) conversions of unsigned short to int.
2958 (lisp_data_to_selection_data): Don't assume that integers
2959 in the range -65535 through -1 fit in an X unsigned short.
2960 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2961 result parameters unless successful. Rely on cons_to_unsigned
2962 to report problems with elements; the old code wasn't right anyway.
2963 (x_check_property_data): Check for int overflow; we cannot use
2964 a wider type due to X limits.
2965 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2967 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2969 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2970 (x_term_init): Check for size calculation overflow.
2971 (x_color_cells): Don't store size until memory allocation succeeds.
2972 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2973 Don't assume alloca size is less than MAX_ALLOCA.
2974 (x_term_init): Don't assume length fits in int (sprintf is limited
2977 Use ptrdiff_t for composition IDs.
2978 * character.c (lisp_string_width):
2979 * composite.c (composition_table_size, n_compositions)
2980 (get_composition_id, composition_gstring_from_id):
2981 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2982 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2983 * window.c (Frecenter):
2984 Use ptrdiff_t, not int, for composition IDs.
2985 * composite.c (get_composition_id): Check for integer overflow.
2986 * composite.h: Adjust prototypes to match the above changes.
2988 Use ptrdiff_t for hash table indexes.
2989 * category.c (hash_get_category_set):
2990 * ccl.c (ccl_driver):
2991 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2992 * coding.c (coding_system_charset_list, detect_coding_system):
2993 * coding.h (struct coding_system.id):
2994 * composite.c (get_composition_id, gstring_lookup_cache):
2995 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2996 * image.c (xpm_get_color_table_h):
2997 * lisp.h (hash_lookup, hash_put):
2998 * minibuf.c (Ftest_completion):
2999 Use ptrdiff_t for hash table indexes, not int (which is too
3000 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3001 32-bit --with-wide-int hosts).
3003 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3004 Add a FIXME comment about memory leaks.
3005 (syms_of_charset): Don't assume xmalloc returns.
3007 Don't assume that stated character widths fit in int.
3008 * character.c (Fchar_width, c_string_width, lisp_string_width):
3009 * character.h (CHAR_WIDTH):
3010 * indent.c (MULTIBYTE_BYTES_WIDTH):
3011 Use sanitize_char_width to avoid undefined and/or bad behavior
3012 with outlandish widths.
3013 * character.h (sanitize_tab_width): Rename from sanitize_width,
3014 now that we have two such functions. All uses changed.
3015 (sanitize_char_width): New inline function.
3017 Don't assume that tab-width fits in int.
3018 * character.h (sanitize_width): New inline function.
3019 (SANE_TAB_WIDTH): New macro.
3020 (ASCII_CHAR_WIDTH): Use it.
3021 * indent.c (sane_tab_width): Remove. All uses replaced by
3022 SANE_TAB_WIDTH (current_buffer).
3023 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3025 * fileio.c: Integer overflow issues with file modes.
3026 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3028 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3029 Remove unreachable code.
3030 (read_hex, load_charset_map_from_file): Check for integer overflow.
3032 * xterm.c: Don't go over XClientMessageEvent limit.
3033 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3034 (x_send_scroll_bar_event): Likewise. Check that the size does not
3035 exceed limits imposed by XClientMessageEvent, as well as the usual
3036 ptrdiff_t and size_t limits.
3038 * keyboard.c: Overflow, signedness and related fixes.
3039 (make_lispy_movement): Use same integer type in forward decl
3040 that is used in the definition.
3041 (read_key_sequence, keyremap_step):
3042 Change bufsize argument back to int, undoing my 2011-03-30 change.
3043 We prefer signed types, and int is wide enough here.
3044 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3045 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3046 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3047 length, not size_t. Use ptrdiff_t for index, not int.
3048 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3049 possibility of integer overflow.
3051 Overflow, signedness and related fixes for images.
3053 * dispextern.h (struct it.stack[0].u.image.image_id)
3054 (struct_it.image_id, struct image.id, struct image_cache.size)
3055 (struct image_cache.used, struct image_cache.ref_count):
3056 * gtkutil.c (update_frame_tool_bar):
3057 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3058 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3059 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3060 * nsmenu.m (update_frame_tool_bar):
3061 * xdisp.c (calc_pixel_width_or_height):
3062 * xfns.c (image_cache_refcount):
3063 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3064 on typical 64-bit hosts.
3066 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3067 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3068 Omit unnecessary casts to int.
3069 (parse_image_spec): Check that integers fall into 'int' range
3070 when the callers expect that.
3071 (image_ascent): Redo ascent calculation to avoid int overflow.
3072 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3073 (lookup_image): Remove unnecessary tests.
3074 (xbm_image_p): Locals are now of int, not EMACS_INT,
3075 since parse_image_check makes sure they fit into int.
3076 (png_load, gif_load, svg_load_image):
3077 Prefer int to unsigned where either will do.
3078 (tiff_handler): New function, combining the cores of the
3079 old tiff_error_handler and tiff_warning_handler.
3080 This function is rewritten to use vsnprintf and thereby avoid
3081 stack buffer overflows. It uses only the features of vsnprintf
3082 that are common to both POSIX and native Microsoft.
3083 (tiff_error_handler, tiff_warning_handler): Use it.
3084 (tiff_load, gif_load, imagemagick_load_image):
3085 Don't assume :index value fits in 'int'.
3086 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3087 (imagemagick_load_image): Check that crop parameters fit into
3088 the integer types that MagickCropImage accepts. Don't assume
3089 Vimagemagick_render_type has a nonnegative value. Don't assume
3090 size_t fits in 'long'.
3091 (gs_load): Use printmax_t to print the widest integers possible.
3092 Check for integer overflow when computing image height and width.
3094 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3096 * xdisp.c (redisplay_window): Don't force window start if point
3097 will be invisible in the resulting window. (Bug#9324)
3099 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3101 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3102 the display spec is of the form `(space ...)'.
3103 (handle_display_spec): Return the value returned by
3104 handle_single_display_spec, not just 1 or zero.
3105 (handle_single_display_spec): If the display spec is of the form
3106 `(space ...)', and specifies display in the text area, return 2
3108 (try_cursor_movement): Check for the need to scroll more
3109 accurately, and prefer exact match for point under bidi.
3110 Don't advance `row' beyond the last row of the window.
3112 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3113 into disp_prop; all users changed.
3115 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3116 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3117 for the text covered by the display property.
3119 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3121 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3122 Change return value to nil.
3123 (Frecord_buffer): Delete unused function.
3125 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3127 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3128 buffers, return left-to-right.
3129 (set_cursor_from_row): Consider candidate row a win if its glyph
3130 represents a newline and point is on that newline. Fixes cursor
3131 positioning on the newline at EOL of R2L text within L2R
3132 paragraph, and vice versa.
3133 (try_cursor_movement): Check continued rows, in addition to
3134 continuation rows. Fixes unwarranted scroll when point enters a
3135 continued line of R2L text within an L2R paragraph, or vice versa.
3136 (cursor_row_p): Consider the case of point being equal to
3137 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3138 from the end of a short line to the beginning of a continued line
3139 of R2L text within L2R paragraph.
3140 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3141 composed characters.
3143 * bidi.c (bidi_check_type): Use xassert.
3144 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3147 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3149 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3152 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3154 * nsfont.m (ns_otf_to_script): Fix typo.
3156 2011-08-22 Kenichi Handa <handa@m17n.org>
3158 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3159 extra slot even if the purpose is char-code-property-table.
3161 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3163 * xdisp.c (redisplay_window): When computing centering_position,
3164 account for the height of the header line. (Bug#8874)
3166 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3167 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3168 candidate is selected by the mouse, and that candidate has a
3169 composed character under the mouse.
3171 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3172 coordinates reported by pos-visible-in-window-p for a composed
3173 character in column zero.
3175 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3177 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3179 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3181 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3182 consider it a hit if to_charpos is anywhere in the range of the
3183 composed buffer positions.
3185 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3187 * image.c (gif_load): Don't assume that each subimage has the same
3188 dimensions as the base image. Handle disposal method that is
3189 "undefined" by the gif spec (Bug#9335).
3191 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3193 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3194 (Fcondition_case): Document `debug' symbol in error handler.
3196 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3198 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3199 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3200 from an Org mode buffer to a Speedbar frame.
3202 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3203 a composition, take its buffer position from IT->cmp_it.charpos.
3204 Fixes cursor positioning at the beginning of a line that begins
3205 with a composed character.
3207 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3209 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3210 character bidirectional type, use STRONG_L instead. Fixes crashes
3211 in a buffer produced by `describe-categories'.
3213 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3214 members before the level stack, so they would be saved and
3215 restored when copying iterator state. Fixes incorrect reordering
3216 around TABs covered by display properties.
3218 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3220 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3222 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3224 * eval.c (internal_condition_case, internal_condition_case_1)
3225 (internal_condition_case_2, internal_condition_case_n):
3226 Remove unnecessary aborts (Bug#9081).
3228 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3230 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3231 has no `load' handler, try opening the file locally. (Bug#9311)
3233 2011-08-16 Ken Brown <kbrown@cornell.edu>
3235 * gmalloc.c: Expand comment.
3237 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3239 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3240 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3242 2011-08-16 Ken Brown <kbrown@cornell.edu>
3244 Fix memory allocation problems in Cygwin build (Bug#9273).
3246 * unexcw.c ( __malloc_initialized): Declare external variable.
3247 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3249 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3251 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3253 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3255 [CYGWIN] (special_realloc): New function.
3256 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3257 requests to realloc storage in the static heap.
3259 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3261 * bidi.c (bidi_initialize): Remove unused local.
3263 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3266 * biditype.h: Remove file.
3267 * makefile.w32-in ($(BLD)/bidi.$(O)):
3268 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3270 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3272 * chartab.c: Improve commentary for the uniprop_table API.
3274 * bidi.c (bidi_paragraph_init): Support zero value of
3275 bidi_ignore_explicit_marks_for_paragraph_level.
3276 (bidi_initialize): Use uniprop_table instead of including
3277 biditype.h and bidimirror.h.
3279 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3280 coordinates of the iterator when restoring from ppos_it.
3283 2011-08-14 Kenichi Handa <handa@m17n.org>
3285 * process.c (create_process): Call setup_process_coding_systems
3286 after the pid of the process is set to -1 (Bug#8162).
3288 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3290 * xdisp.c (move_it_in_display_line_to): Don't invoke
3291 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3292 ppos_it. Fixes vertical cursor motion when line beginning is
3293 covered by an image. (Bug#9296)
3295 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3297 * nsterm.h (ns_run_ascript): Declare.
3298 (NSAPP_DATA2_RUNASSCRIPT): Define.
3300 * nsfns.m (as_script, as_result, as_status): New static variables.
3301 (ns_run_ascript): New function.
3302 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3303 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3304 the event loop. Get status from as_status (Bug#7276).
3306 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3307 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3308 the event loop (Bug#7276).
3310 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3312 * gnutls.c (QCgnutls_bootprop_priority)
3313 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3314 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3315 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3316 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3317 (QCgnutls_bootprop_verify_hostname_error)
3318 (QCgnutls_bootprop_callbacks_verify): Rename from
3319 Qgnutls_bootprop_..., all uses changed.
3321 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3324 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3326 * xfaces.c (Qframe_set_background_mode): Now static.
3327 * dispextern.h (Qframe_set_background_mode): Remove decl.
3329 * process.c (Fnetwork_interface_info): Declare local only if needed.
3331 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3333 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3334 (Fnetwork_interface_list): Allocate in increments of bytes instead
3335 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3336 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3338 (struct ifflag_def): notrailers is smart on OSX.
3339 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3340 Get hardware address with getifaddrs if available.
3342 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3344 * xdisp.c (iterate_out_of_display_property): xassert that
3345 IT->position is set to within IT->object's boundaries. Break from
3346 the loop as soon as EOB is reached; avoids infloops in redisplay
3347 when IT->position is set up wrongly due to some bug.
3348 Set IT->current to match the bidi iterator unconditionally.
3349 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3350 entry. Force push_it to save on the stack the current
3351 buffer/string position, to be restored by pop_it. Fix flags in
3352 the iterator structure wrt the object coming from a display
3353 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3354 properties. (Bug#9284)
3356 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3358 * fontset.c (fontset_get_font_group): Add proper type checks.
3361 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3363 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3364 and LC_VERSION_MIN_MACOSX.
3365 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3366 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3368 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3370 * xdisp.c (forward_to_next_line_start): Allow to use the
3371 no-display-properties-and-no-overlays under bidi display.
3372 Set disp_pos in the bidi iterator to avoid searches for display
3373 properties and overlays.
3375 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3377 * editfns.c (Fset_time_zone_rule): Document relationship with the
3380 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3381 the font entity extracted from the cache (Bug#8109).
3383 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3385 * composite.c (autocmp_chars): Don't reset point. That is done by
3386 restore_point_unwind (Bug#5984).
3388 2011-08-07 Juri Linkov <juri@jurta.org>
3390 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3391 to show the arg `TIME' instead of `TIMEVAL'.
3393 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3395 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3396 display property strides EOL and includes a newline, as in
3397 longlines-mode. (Bug#9254)
3398 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3399 word-wrap under bidirectional display. (Bug#9224)
3401 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3402 is non-zero, even if the data buffer is NULL. Fixes a crash in
3403 vertical-motion with longlines-mode. (Bug#9254)
3405 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3407 * bidi.c <bidi_cache_total_alloc>: Now static.
3408 (bidi_initialize): Initialize bidi_cache_total_alloc.
3410 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3413 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3414 amount allocated this far in `bidi_cache_total_alloc'.
3415 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3416 non-zero, only free the data buffer without restoring the cache
3417 contents. All callers changed.
3419 * dispextern.h (bidi_unshelve_cache): Update prototype.
3421 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3422 (move_it_in_display_line, move_it_to)
3423 (move_it_vertically_backward, move_it_by_lines): Replace the call
3424 to xfree to an equivalent call to bidi_unshelve_cache.
3425 (move_it_in_display_line_to): Fix logic of returning
3426 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3428 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3430 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3431 came from a string character with a `cursor' property. (Bug#9229)
3433 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3435 * Makefile.in (LIB_PTHREAD): New variable.
3436 (LIBES): Add LIB_PTHREAD (Bug#9216).
3438 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3439 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3441 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3443 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3445 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3447 * xterm.c (x_find_topmost_parent): New function.
3448 (x_set_frame_alpha): Find topmost parent window with
3449 x_find_topmost_parent and set the property there also (bug#9181).
3450 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3452 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3454 * callproc.c (Fcall_process): Avoid vfork clobbering
3455 the local vars buffer, coding_systems, current_dir.
3457 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3459 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3461 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3463 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3464 so that it is not optimized away.
3466 * xdisp.c (compute_display_string_pos): Remove unused local.
3468 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3470 Fix slow cursor motion and scrolling in large buffers with
3471 selective display, like Org Mode buffers. (Bug#9218)
3473 * dispextern.h (struct bidi_it): New member disp_prop_p.
3475 * xdisp.c: Remove one-slot cache of display string positions.
3476 (compute_display_string_pos): Accept an additional argument
3477 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3478 for a display string or property. If found, set DISP_PROP_P
3481 * bidi.c (bidi_fetch_char): Accept an additional argument
3482 DISP_PROP_P, and pass it to compute_display_string_pos.
3483 Only handle text covered by a display string if DISP_PROP_P is returned
3484 non-zero. All callers of bidi_fetch_char changed.
3486 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3488 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3490 2010-12-03 Don March <don@ohspite.net>
3492 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3493 last character M-[char] is translated to ESC [char] (bug#7541).
3495 2011-08-02 Kenichi Handa <handa@m17n.org>
3497 * lisp.h (uniprop_table): Extern it.
3499 * chartab.c (uniprop_table): Make it non-static.
3501 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3503 * xdisp.c (forward_to_next_line_start): Accept additional argument
3504 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3506 (reseat_at_next_visible_line_start): Use the bidi iterator state
3507 returned by forward_to_next_line_start to restore the state of
3508 it->bidi_it after backing up to previous newline. (Bug#9212)
3510 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3512 * regex.c (re_comp): Protoize.
3513 (re_exec): Fix return type.
3514 (regexec): Fix type of `ret'. (Bug#9203)
3516 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3518 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3519 This is needed if max-image-size is a floating-point number.
3521 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3523 * print.c (print_object): Print empty symbol as ##.
3525 * lread.c (read1): Read ## as empty symbol.
3527 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3529 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3530 setting frame foreground color (Bug#9175).
3531 (x_set_background_color): Likewise.
3533 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3534 contents (Bug#9176).
3535 (EmacsTooltip -init): Remove bezels and add shadows to
3538 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3539 or scroll bar (Bug#8470).
3541 * nsfont.m (nsfont_open): Remove assignment to voffset and
3542 unnecessary vars hshink, expand, hd, full_height, min_height.
3543 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3545 * nsterm.h (nsfont_info): Remove voffset field.
3547 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3549 Implement strike-through and overline on NextStep (Bug#8863).
3551 * nsfont.m (nsfont_open): Use underline position provided by font,
3552 instead of hard-coded value of 2.
3553 (nsfont_draw): Call ns_draw_text_decoration instead.
3555 * nsterm.h: Add declaration for ns_draw_text_decoration.
3557 * nsterm.m (ns_draw_text_decoration): New function for drawing
3558 underline, overline, and strike-through.
3559 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3560 ns_draw_text_decoration. Change treatment of cursor drawing to
3561 accommodate underlining, etc.
3563 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3565 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3568 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3570 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3571 Without this fix, if a signal arrives just after memory fills up,
3572 'malloc' might be invoked reentrantly.
3574 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3575 In other words, assume that every image size is allowed, on non-X
3576 hosts. This assumption is probably wrong, but it lets Emacs compile.
3578 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3580 * regex.c (re_iswctype): Convert return values to boolean.
3582 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3584 * xdisp.c (compute_display_string_pos): Don't use cached display
3585 string position if the buffer had its restriction changed.
3588 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3590 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3592 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3594 Integer signedness and overflow and related fixes. (Bug#9079)
3596 * bidi.c: Integer size and overflow fixes.
3597 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3598 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3599 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3600 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3601 (bidi_find_other_level_edge):
3602 Use ptrdiff_t instead of EMACS_INT where either will do.
3603 This works better on 32-bit hosts configured --with-wide-int.
3604 (bidi_cache_ensure_space): Check for size-calculation overflow.
3605 Use % rather than repeated addition, for better worst-case speed.
3606 Don't set bidi_cache_size until after xrealloc returns, because it
3608 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3609 (bidi_cache_ensure_space): Also check that the bidi cache size
3610 does not exceed that of the largest Lisp string or buffer. See Eli
3611 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3613 * alloc.c (__malloc_size_t): Remove.
3614 All uses replaced by size_t. See Andreas Schwab's note
3615 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3617 * image.c: Improve checking for integer overflow.
3618 (check_image_size): Assume that f is nonnull, since
3619 it is always nonnull in practice. This is one less thing to
3620 worry about when checking for integer overflow later.
3621 (x_check_image_size): New function, which checks for integer
3622 overflow issues inside X.
3623 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3624 This removes the need for a memory_full check.
3625 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3626 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3627 (xbm_read_bitmap_data): Change locals back to 'int', since
3628 their values must fit in 'int'.
3629 (xpm_load_image, png_load, tiff_load):
3630 Invoke x_create_x_image_and_pixmap earlier,
3631 to avoid much needless work if the image is too large.
3632 (tiff_load): Treat overly large images as if
3633 x_create_x_image_and_pixmap failed, not as malloc failures.
3634 (gs_load): Use x_check_image_size.
3636 * gtkutil.c: Omit integer casts.
3637 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3638 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3640 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3642 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3643 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3644 would wrongly return t on a 64-bit host.
3646 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3647 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3648 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3649 and therefore cause GCC to emit a bogus diagnostic in some cases.
3651 * image.c: Integer signedness and overflow and related fixes.
3652 This is not an exhaustive set of fixes, but it's time to
3653 record what I've got.
3654 (lookup_pixel_color, check_image_size): Remove redundant decls.
3655 (check_image_size): Don't assume that arbitrary EMACS_INT values
3656 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3657 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3658 (tiff_load, imagemagick_load_image):
3659 Check for overflow in size calculations.
3660 (x_create_x_image_and_pixmap): Remove unnecessary test for
3661 xmalloc returning NULL; that can't happen.
3662 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3663 (xpm_color_bucket): Use better integer hashing function.
3664 (xpm_cache_color): Don't possibly over-allocate memory.
3665 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3666 (gif_memory_source):
3667 Use ptrdiff_t, not int or size_t, to record sizes.
3668 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3669 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3670 either works, as we prefer signed integers.
3671 (tiff_read_from_memory, tiff_write_from_memory):
3672 Return tsize_t, not size_t, since that's what the TIFF API wants.
3673 (tiff_read_from_memory): Don't fail simply because the read would
3674 go past EOF; instead, return a short read.
3675 (tiff_load): Omit no-longer-needed casts.
3676 (Fimagemagick_types): Don't assume size fits into 'int'.
3678 Improve hashing quality when configured --with-wide-int.
3679 * fns.c (hash_string): New function, taken from sxhash_string.
3680 Do not discard information about ASCII character case; this
3681 discarding is no longer needed.
3682 (sxhash-string): Use it. Change sig to match it. Caller changed.
3683 * lisp.h: Declare it.
3684 * lread.c (hash_string): Remove, since we now use fns.c's version.
3685 The fns.c version returns a wider integer if --with-wide-int is
3686 specified, so this should help the quality of the hashing a bit.
3688 * emacs.c: Integer overflow minor fix.
3689 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3690 Define only if GNU_LINUX.
3691 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3693 * dispnew.c: Integer signedness and overflow fixes.
3694 Remove unnecessary forward decls, that were a maintenance hassle.
3695 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3697 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3698 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3699 (prepare_desired_row, line_draw_cost):
3700 Use int, not unsigned, where either works.
3701 (save_current_matrix, restore_current_matrix):
3702 Use ptrdiff_t, not size_t, where either works.
3703 (init_display): Check for overflow more accurately, and without
3704 relying on undefined behavior.
3706 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3707 Remove, replacing with the new symbols in lisp.h. All uses changed.
3708 * fileio.c (make_temp_name):
3709 * filelock.c (lock_file_1, lock_file):
3710 * xdisp.c (message_dolog):
3711 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3712 Use pMd etc. instead.
3713 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3714 replacing the pWIDE etc. symbols removed from editfns.c.
3716 * keyboard.h (num_input_events): Now uintmax_t.
3717 This is (very slightly) less likely to mess up due to wraparound.
3720 * buffer.c: Integer signedness fixes.
3721 (alloc_buffer_text, enlarge_buffer_text):
3722 Use ptrdiff_t rather than size_t when either will do, as we prefer
3725 * alloc.c: Integer signedness and overflow fixes.
3726 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3727 (__malloc_size_t): Default to size_t, not to int.
3728 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3729 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3730 Prefer ptrdiff_t to size_t when either would do, as we prefer
3732 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3733 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3734 Now const. Initialize with values that are in range even if char
3736 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3737 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3738 These functions do the right thing with sizes > 2**32.
3739 (check_depth): Now ptrdiff_t, not int.
3740 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3741 Adjust to new way of storing sizes. Check for size overflow bugs
3743 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3744 slightly wrong anyway, as it missed one instance of
3745 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3746 (refill_memory_reserve): Omit needless cast to size_t.
3747 (mark_object_loop_halt): Mark as externally visible.
3749 * xselect.c: Integer signedness and overflow fixes.
3750 (Fx_register_dnd_atom, x_handle_dnd_message):
3751 Use ptrdiff_t, not size_t, since we prefer signed.
3752 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3753 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3754 x_dnd_atoms_size and x_dnd_atoms_length.
3756 * doprnt.c: Prefer signed to unsigned when either works.
3758 * doprnt.c (doprnt):
3760 * xdisp.c (vmessage):
3761 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3762 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3763 prefer signed arithmetic to avoid comparison confusion.
3764 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3765 but is a bit tricky.
3767 Assume freestanding C89 headers, string.h, stdlib.h.
3768 * data.c, doprnt.c, floatfns.c, print.c:
3769 Include float.h unconditionally.
3770 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3771 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3772 * regex.c: Likewise for stddef.h, string.h.
3773 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3774 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3775 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3776 (STDC_HEADERS): Remove obsolete defines.
3777 * sysdep.c: Include limits.h unconditionally.
3779 Assume support for memcmp, memcpy, memmove, memset.
3780 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3781 * regex.c (memcmp, memcpy):
3782 Remove; we assume C89 now.
3784 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3785 (__malloc_safe_bcopy): Remove; no longer needed.
3787 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3788 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3789 well either way, and we prefer signed to unsigned.
3791 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3793 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3794 closes the connection while we're reading (bug#9182).
3796 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3798 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3799 are specified (Bug#9168).
3801 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3803 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3804 Found by GCC static checking and --with-wide-int on a 32-bit host.
3806 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3808 * xdisp.c (compute_display_string_pos): Fix logic of caching
3809 previous display string position. Initialize cached_prev_pos to
3810 -1. Fixes slow-down at the beginning of a buffer.
3812 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3814 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3815 for attrs[LFACE_FONTSET_INDEX].
3817 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3819 * xml.c (parse_region): Remove unused local
3820 that was recently introduced.
3822 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3824 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3825 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3827 * xdisp.c (move_it_in_display_line_to): Record the best matching
3828 position for TO_CHARPOS while scanning the line, and restore it on
3829 exit if none of the characters scanned was an exact match.
3830 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3831 when exact match is impossible due to invisible text, and the
3832 lines are truncated.
3834 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3836 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3839 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3841 Fix a significant slow-down of cursor motion with C-n, C-p,
3842 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3843 auto-repeat under bidi redisplay in fontified buffers.
3844 * xdisp.c (compute_stop_pos_backwards): New function.
3845 (next_element_from_buffer): Call compute_stop_pos_backwards to
3846 find a suitable prev_stop when we find ourselves before
3848 (reseat): Don't look for prev_stop, as that could mean a very long
3850 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3851 <cached_disp_overlay_modiff>: Cache for last found display string
3853 (compute_display_string_pos): Return the cached position if asked
3854 about the same buffer in the same area of character positions, and
3855 the buffer wasn't changed since the time the display string
3856 position was cached.
3858 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3860 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3861 is an integer, which is important for empty lines. (Bug#9149)
3863 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3865 * frame.c (Fmodify_frame_parameters): In tty case, update the
3866 default face if necessary (Bug#4238).
3868 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3870 * editfns.c (Fstring_to_char): No need to explain what a character
3871 is in the docstring (Bug#6576).
3873 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3875 * xml.c (parse_region): Make sure we always return a tree.
3877 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3879 * xml.c (parse_region): If a document contains only comments,
3882 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3884 * xml.c (make_dom): Return comments, too.
3886 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3889 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3890 and the surrounding thread.
3891 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3892 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3893 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3895 * s/openbsd.h (BROKEN_SIGIO): Define.
3896 * unexelf.c (unexec) [__OpenBSD__]:
3897 Don't update the .mdebug section of the Alpha COFF symbol table.
3899 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3901 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3904 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3906 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3907 This fixes some race conditions on the permissions of any newly
3910 * alloc.c (valid_pointer_p): Use pipe, not open.
3911 This fixes some permissions issues when debugging.
3913 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3914 If fchown fails to set both uid and gid, try to set just gid,
3915 as that is sometimes allowed. Adjust the file's mode to eliminate
3916 setuid or setgid bits that are inappropriate if fchown fails.
3918 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3920 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3921 to compare Lisp_Objects.
3922 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3923 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3924 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3926 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3928 * lread.c (read_integer): Unread even EOF character.
3929 (read1): Likewise. Properly record start position of symbol.
3931 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3932 symbol character follows.
3934 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3936 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3937 This works around a problem with the previous change to Fcopy_file.
3938 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3939 and without this change, GCC might complain about discarding
3940 fchown's return value.
3942 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3944 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3946 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3948 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3950 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3952 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3953 it's used from the C level.
3955 * process.c: Use the same condition for POLL_FOR_INPUT in both
3956 keyboard.c and process.c (bug#1858).
3958 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3960 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3961 (Fgnutls_boot): Use it.
3963 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3965 * doc.c (Fsubstitute_command_keys): Revert last change.
3967 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3969 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3970 quotes the next character, and doesn't affect other longer
3971 sequences (bug#8935).
3973 * lread.c (syms_of_lread): Clarify that is isn't only
3974 `eval-buffer' and `eval-defun' that's affected by
3975 `lexical-binding' (bug#8460).
3977 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3979 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3980 bidi redisplay when a line includes both an image and is truncated.
3982 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3984 Fix minor problems found by static checking.
3985 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3986 (elsz): Now a signed constant, not a size_t var. We prefer signed
3987 types to unsigned, to avoid integer comparison confusion. Without
3988 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3989 "cannot optimize loop, the loop counter may overflow", a symptom
3991 * indent.c (Fvertical_motion): Mark locals as initialized.
3992 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3994 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3996 * search.c (Fre_search_backward): Mention `case-fold-search' in
3997 all the re_search_* functions (bug#8138).
3999 * keyboard.c (Fopen_dribble_file): Document when the file is
4002 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4004 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4007 Support bidi reordering of display and overlay strings.
4008 * xdisp.c (compute_display_string_pos)
4009 (compute_display_string_end): Accept additional argument STRING.
4010 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4011 (reseat_to_string): Initialize bidi_it->string.s and
4012 bidi_it->string.schars.
4013 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4014 NULL (avoids a crash in bidi_paragraph_init).
4015 Initialize itb.string.lstring.
4016 (init_iterator): Call bidi_init_it only of a valid
4017 buffer position was specified. Initialize paragraph_embedding to
4019 (reseat_to_string): Initialize the bidi iterator.
4020 (display_string): If we need to ignore text properties of
4021 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4022 original value of -1 will not work with bidi.)
4023 (compute_display_string_pos): First arg is now struct
4024 `text_pos *'; all callers changed. Support display properties on
4026 (compute_display_string_end): Support display properties on Lisp
4028 (init_iterator, reseat_1, reseat_to_string): Initialize the
4029 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4030 when iterating on a string not from display properties).
4031 (compute_display_string_pos, compute_display_string_end):
4032 Fix calculation of the object to scan. Fixes an error when using
4034 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4035 base_level_stop; instead, set base_level_stop to BEGV.
4036 Fixes crashes in vertical-motion.
4037 (next_element_from_buffer): Improve commentary for when
4038 the iterator is before prev_stop.
4039 (init_iterator): Initialize bidi_p from the default value of
4040 bidi-display-reordering, not from buffer-local value. Use the
4041 buffer-local value only if initializing for buffer iteration.
4042 (handle_invisible_prop): Support invisible properties on strings
4043 that are being bidi-reordered.
4044 (set_iterator_to_next): Support bidi reordering of C strings and
4046 (next_element_from_string): Support bidi reordering of Lisp
4048 (handle_stop_backwards): Support Lisp strings as well.
4049 (display_string): Support display of R2L glyph rows.
4050 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4051 (init_iterator): Don't initialize it->bidi_p for strings
4053 (reseat_to_string): Initialize it->bidi_p for strings here.
4054 (next_element_from_string, next_element_from_c_string)
4055 (next_element_from_buffer): Add xassert's for correspondence
4056 between IT's object being iterated and it->bidi_it.string
4058 (face_before_or_after_it_pos): Support bidi iteration.
4059 (next_element_from_c_string): Handle the case of the first string
4060 character that is not the first one in the visual order.
4061 (get_visually_first_element): New function, refactored from common
4062 parts of next_element_from_buffer, next_element_from_string, and
4063 next_element_from_c_string.
4064 (tool_bar_lines_needed, redisplay_tool_bar)
4065 (display_menu_bar): Force left-to-right direction. Add a FIXME
4066 comment for making that be controlled by a user option.
4067 (push_it, pop_it): Save and restore the state of the
4068 bidi iterator. Save and restore the bidi_p flag.
4069 (pop_it): Iterate out of display property for string iteration as
4071 (iterate_out_of_display_property): Support iteration over strings.
4072 (handle_single_display_spec): Set up it->bidi_it for iteration
4073 over a display string, and call bidi_init_it.
4074 (handle_single_display_spec, next_overlay_string)
4075 (get_overlay_strings_1, push_display_prop): Set up the bidi
4076 iterator for displaying display or overlay strings.
4077 (forward_to_next_line_start): Don't use the shortcut if
4079 (back_to_previous_visible_line_start): If handle_display_prop
4080 pushed the iterator stack, restore the internal state of the bidi
4081 iterator by calling bidi_pop_it same number of times.
4082 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4083 and we are bidi-iterating, don't decrement the iterator position;
4084 instead, set the first_elt flag in the bidi iterator, to produce
4086 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4087 (push_display_prop): xassert that we are iterating a buffer.
4088 (push_it, pop_it): Save and restore paragraph_embedding member.
4089 (handle_single_display_spec, next_overlay_string)
4090 (get_overlay_strings_1, reseat_1, reseat_to_string)
4091 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4092 correctly. Don't assume unibyte strings are not bidi-reordered.
4093 (compute_display_string_pos)
4094 (compute_display_string_end): Fix handling the case of C string.
4095 (push_it, pop_it): Save and restore from_disp_prop_p.
4096 (handle_single_display_spec, push_display_prop): Set the
4097 from_disp_prop_p flag.
4098 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4099 (pop_it): Call iterate_out_of_display_property only if we are
4100 popping after iteration over a string that came from a display
4101 property. Fix a typo in popping stretch info. Add an assertion
4102 for verifying that the iterator position is in sync with the bidi
4104 (handle_single_display_spec, get_overlay_strings_1)
4105 (push_display_prop): Fix initialization of paragraph direction for
4106 string when that of the parent object is not yet determined.
4107 (reseat_1): Call bidi_init_it to resync the bidi
4108 iterator with IT's position. (Bug#7616)
4109 (find_row_edges): If ROW->start.pos gives position
4110 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4111 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4112 Reset the from_disp_prop_p flag.
4113 (SAVE_IT, RESTORE_IT): New macros.
4114 (pos_visible_p, face_before_or_after_it_pos)
4115 (back_to_previous_visible_line_start)
4116 (move_it_in_display_line_to, move_it_in_display_line)
4117 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4118 (try_scrolling, redisplay_window, display_line): Use them when
4119 saving a temporary copy of the iterator and restoring it back.
4120 (back_to_previous_visible_line_start, reseat_1)
4121 (init_iterator): Empty the bidi cache "stack".
4122 (move_it_in_display_line_to): If iterator ended up at
4123 EOL, but we never saw any buffer positions smaller than
4124 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4125 motion in bidi-reordered lines.
4126 (move_it_in_display_line_to): Record prev_method and prev_pos
4127 immediately before the call to set_iterator_to_next. Fixes cursor
4128 motion in bidi-reordered lines with stretch glyphs and strings
4129 displayed in margins. (Bug#8133) (Bug#8867)
4130 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4132 (pos_visible_p): Support positions in bidi-reordered lines.
4133 Save and restore bidi cache.
4135 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4136 (bidi_paragraph_info): Delete unused struct.
4137 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4138 (bidi_cache_start): New variable.
4139 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4141 (bidi_cache_fetch_state, bidi_cache_search)
4142 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4143 (bidi_cache_find, bidi_peek_at_next_level)
4144 (bidi_level_of_next_char, bidi_find_other_level_edge)
4145 (bidi_move_to_visually_next): Compare cache index with
4146 bidi_cache_start rather than with zero.
4147 (bidi_fetch_char): Accept new argument STRING; all callers
4148 changed. Support iteration over a string. Support strings with
4149 display properties. Support unibyte strings. Fix the type of
4150 `len' according to what STRING_CHAR_AND_LENGTH expects.
4151 (bidi_paragraph_init, bidi_resolve_explicit_1)
4152 (bidi_resolve_explicit, bidi_resolve_weak)
4153 (bidi_level_of_next_char, bidi_move_to_visually_next):
4154 Support iteration over a string.
4155 (bidi_set_sor_type, bidi_resolve_explicit_1)
4156 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4157 can now be zero (for strings); special values 0 and -1 were
4158 changed to -1 and -2, respectively.
4159 (bidi_char_at_pos): New function.
4160 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4161 Call it instead of FETCH_MULTIBYTE_CHAR.
4162 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4163 initialized to valid values.
4164 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4166 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4167 the test for valid cached positions. Fix the logic for looking up
4168 the sentinel state in the cache. GCPRO the Lisp string we are
4170 (bidi_push_it, bidi_pop_it): New functions.
4171 (bidi_initialize): Initialize the bidi cache start stack pointer.
4172 (bidi_cache_ensure_space): New function, refactored from part of
4173 bidi_cache_iterator_state. Don't assume the required size is just
4174 one BIDI_CACHE_CHUNK away.
4175 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4176 (bidi_count_bytes, bidi_char_at_pos): New functions.
4177 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4178 always valid if bidi_cache_idx is valid.
4179 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4180 is valid if it's going to be used.
4181 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4182 (bidi_cache_fetch_state, bidi_cache_search)
4183 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4184 (bidi_cache_iterator_state, bidi_cache_find)
4185 (bidi_find_other_level_edge, bidi_cache_start_stack):
4186 All variables related to cache indices are now EMACS_INT.
4188 * dispextern.h (struct bidi_string_data): New structure.
4189 (struct bidi_it): New member `string'. Make flag members be 1-bit
4190 fields, and put them last in the struct.
4191 (compute_display_string_pos, compute_display_string_end):
4193 (bidi_push_it, bidi_pop_it): Add prototypes.
4194 (struct iterator_stack_entry): New members bidi_p,
4195 paragraph_embedding, and from_disp_prop_p.
4196 (struct it): Member bidi_p is now a bit field 1 bit wide.
4197 (bidi_shelve_cache, bidi_unshelve_cache):
4200 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4201 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4202 and vector-like objects.
4204 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4205 cache around display iteration.
4207 * window.c (Fwindow_end, window_scroll_pixel_based)
4208 (displayed_window_lines, Frecenter): Save and restore the bidi
4209 cache around display iteration.
4211 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4213 * editfns.c (Fdelete_region): Clarify the use of the named
4214 parameters (bug#6788).
4216 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4218 * indent.c (Fvertical_motion): Set and restore w->pointm when
4219 saving and restoring the window's buffer (Bug#9006).
4221 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4223 * editfns.c (Fstring_to_char): Clarify just what is returned
4224 (bug#6576). Text by Eli Zaretskii.
4226 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4228 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4230 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4232 * buffer.c (mmap_find): Fix a typo.
4234 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4236 Fix execution of x selection hooks.
4237 * xselect.c (Qx_lost_selection_functions)
4238 (Qx_sent_selection_functions): New vars.
4239 (syms_of_xselect): DEFSYM them.
4240 (x_handle_selection_request): Pass Qx_sent_selection_functions
4241 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4242 (x_handle_selection_clear,x_clear_frame_selections):
4243 Pass Qx_lost_selection_functions rather than
4244 Vx_lost_selection_functions to Frun_hook_with_args.
4246 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4248 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4249 The old code sometimes used this field without initializing it.
4251 * alloc.c (gc_sweep): Don't read past end of array.
4252 In theory, the old code could also have corrupted Emacs internals,
4253 though it'd be very unlikely.
4255 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4257 * character.c (Fcharacterp): Don't advertise optional ignored
4258 argument. (Bug#4026)
4260 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4262 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4265 * window.c (Fset_window_start): Doc fix (bug#4199).
4266 (Fset_window_hscroll): Ditto.
4268 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4270 Fix minor new problems caught by GCC 4.6.1.
4271 * term.c (init_tty): Remove unused local.
4272 * xsettings.c (store_monospaced_changed): Define this function only
4273 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4276 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4278 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4280 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4282 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4283 are the mini-buffer and the echo area (bug#3320).
4285 * term.c (init_tty): Remove support for supdup, c10 and perq
4286 terminals, which are no longer supported (bug#1482).
4288 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4290 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4292 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4294 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4295 for non-popups (Bug#3642).
4297 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4299 * alloc.c (reset_malloc_hooks): Protoize.
4300 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4301 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4302 * cm.c (losecursor): Likewise.
4303 * data.c (fmod): Likewise.
4304 * dispnew.c (swap_glyphs_in_rows): Likewise.
4305 * emacs.c (memory_warning_signal): Likewise.
4306 * floatfns.c (float_error): Likewise.
4307 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4308 (otf_open, font_otf_capability, generate_otf_features)
4309 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4311 * image.c (pbm_read_file): Likewise.
4312 * indent.c (string_display_width): Likewise.
4313 * intervals.c (check_for_interval, search_for_interval)
4314 (inc_interval_count, count_intervals, root_interval)
4315 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4316 * lread.c (defalias): Likewise.
4317 * ralloc.c (r_alloc_check): Likewise.
4318 * regex.c (set_image_of_range_1, set_image_of_range)
4319 (regex_grow_registers): Likewise.
4320 * sysdep.c (strerror): Likewise.
4321 * termcap.c (valid_filename_p, tprint, main): Likewise.
4322 * tparam.c (main): Likewise.
4323 * unexhp9k800.c (run_time_remap, save_data_space)
4324 (update_file_ptrs, read_header, write_header, calculate_checksum)
4325 (copy_file, copy_rest, display_header): Likewise.
4326 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4328 * xdisp.c (check_it): Likewise.
4329 * xfaces.c (register_color, unregister_color, unregister_colors):
4331 * xfns.c (print_fontset_result): Likewise.
4332 * xrdb.c (member, fatal, main): Likewise.
4334 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4336 Fix minor problems found by static checking (Bug#9031).
4337 * chartab.c (char_table_set_range, map_sub_char_table):
4338 Remove unused locals.
4339 (uniprop_table): Now static.
4340 * composite.c (_work_char): Remove unused static var.
4342 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4344 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4346 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4348 * gtkutil.c (qttip_cb): Remove code without function.
4350 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4352 * w32.c (pthread_sigmask): New stub.
4354 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4356 Use pthread_sigmask, not sigprocmask (Bug#9010).
4357 sigprocmask is portable only for single-threaded applications, and
4358 Emacs can be multi-threaded when it uses GTK.
4359 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4361 * callproc.c (Fcall_process):
4362 * process.c (create_process):
4363 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4364 Use pthread_sigmask, not sigprocmask.
4366 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4368 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4369 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4372 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4374 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4375 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4376 (xg_hide_tooltip): Fix comment.
4378 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4379 in registerServicesMenuSendTypes.
4380 (validRequestorForSendType): Don't check ns_return_types.
4382 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4385 2011-07-08 Jason Rumney <jasonr@gnu.org>
4387 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4388 SH_SHOW for hidden windows (Bug#5482).
4390 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4391 frame struct members of non-existent frames (Bug#6284).
4393 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4395 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4396 variable firstTime not needed on OSX >= 10.6.
4397 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4398 >= 10.5. Use setKnobProportion, setDoubleValue.
4400 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4401 (MAC_OS_X_VERSION_10_5): Define if not defined.
4402 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4403 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4404 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4406 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4407 cString and lossyCString on OSX >= 10.4
4409 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4410 sizeToFit on OSX >= 10.2.
4412 * nsimage.m (allocInitFromFile): Don't use deprecated method
4413 bestRepresentationForDevice on OSX >= 10.6.
4415 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4418 * emacs.c: Declare unexec_init_emacs_zone.
4420 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4422 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4424 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4425 on svcsMenu (Bug#8842).
4427 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4429 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4431 * nsterm.m (QUTF8_STRING): Declare.
4432 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4433 (validRequestorForSendType): Return type is (id).
4434 Change indexOfObjectIdenticalTo to indexOfObject.
4435 Check if we have local selection before returning self (Bug#8842).
4436 (writeSelectionToPasteboard): Put local selection into paste board
4437 if we have a local selection (Bug#8842).
4438 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4440 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4441 (ns_get_local_selection): Declare.
4443 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4445 * keymap.c (describe_map_tree): Don't insert a double newline at
4446 the end of the buffer (bug#1169) and return whether we inserted
4449 * callint.c (Fcall_interactively): Change "reading args" to
4450 "providing args" to try to clarify what it does (bug#1010).
4452 2011-07-07 Kenichi Handa <handa@m17n.org>
4454 * composite.c (composition_compute_stop_pos): Ignore a static
4455 composition starting before CHARPOS (Bug#8915).
4457 * xdisp.c (handle_composition_prop): Likewise.
4459 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4461 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4464 2011-07-07 Kenichi Handa <handa@m17n.org>
4466 * character.h (unicode_category_t): New enum type.
4468 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4469 (Qchar_code_property_table): New variable.
4470 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4471 (UNIPROP_COMPRESSED_FORM_P): New macros.
4472 (char_table_ascii): Uncompress the compressed values.
4473 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4474 Uncompress the compressed values.
4475 (sub_char_table_ref_and_range): Likewise.
4476 (char_table_ref_and_range): Uncompress the compressed values.
4477 (sub_char_table_set): New arg is_uniprop. Callers changed.
4478 Uncompress the compressed values.
4479 (sub_char_table_set_range): Args changed. Callers changed.
4480 (char_table_set_range): Adjuted for the above change.
4481 (map_sub_char_table): Delete args default_val and parent. Add arg
4482 top. Give decoded values to a Lisp function.
4483 (map_char_table): Adjust for the above change. Give decoded
4484 values to a Lisp function. Gcpro more variables.
4485 (uniprop_table_uncompress)
4486 (uniprop_decode_value_run_length): New functions.
4487 (uniprop_decoder, uniprop_decoder_count): New variables.
4488 (uniprop_get_decoder, uniprop_encode_value_character)
4489 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4491 (uniprop_encoder, uniprop_encoder_count): New variables.
4492 (uniprop_get_encoder, uniprop_table)
4493 (Funicode_property_table_internal, Fget_unicode_property_internal)
4494 (Fput_unicode_property_internal): New functions.
4495 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4496 Sunicode_property_table_internal, Sget_unicode_property_internal,
4497 and Sput_unicode_property_internal. Defvar_lisp
4498 char-code-property-alist.
4500 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4501 Vunicode_category_table.
4503 * font.c (font_range): Adjust for the change of
4504 Vunicode_category_table.
4506 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4508 * m/iris4d.h: Remove file, move contents ...
4509 * s/irix6-5.h: ... here.
4511 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4513 Remove unportable assumption about struct layout (Bug#8884).
4514 * alloc.c (mark_buffer):
4515 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4516 (clone_per_buffer_values): Don't assume that
4517 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4518 This isn't true in general, and it's particularly not true
4519 if Emacs is configured with --with-wide-int.
4520 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4521 New macros, used in the buffer.c change.
4523 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4525 * xsettings.c: Use both GConf and GSettings if both are available.
4526 (store_config_changed_event): Add comment.
4527 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4528 (store_tool_bar_style_changed): New functions.
4529 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4530 (struct xsettings): Move font inside HAVE_XFT.
4531 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4532 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4533 Move inside HAVE_XFT.
4534 (something_changed_gsettingsCB): Rename from something_changedCB.
4535 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4537 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4538 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4539 (something_changed_gconfCB): Rename from something_changedCB.
4540 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4541 (parse_settings): Move check for font inside HAVE_XFT.
4542 (read_settings, apply_xft_settings): Add comment.
4543 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4544 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4545 call store_font_name_changed.
4546 (xft_settings_event): Add comment.
4547 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4548 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4549 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4550 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4551 (xsettings_initialize): Call init_gsettings last.
4552 (xsettings_get_system_font, xsettings_get_system_normal_font):
4555 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4557 Random fixes. E.g., (random) never returned negative values.
4558 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4559 subseconds part to the entropy, as that's a bit more random.
4560 Prefer signed to unsigned, since the signedness doesn't matter and
4561 in general we prefer signed. When given a limit, use a
4562 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4563 latter isn't right if USE_2_TAGS_FOR_INTS.
4564 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4565 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4567 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4569 * textprop.c (text_property_stickiness):
4570 Obey Vtext_property_default_nonsticky.
4571 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4572 * w32fns.c (syms_of_w32fns):
4573 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4575 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4577 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4578 This is more efficient than Ffile_directory_p and avoids a minor race.
4580 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4582 * buffer.c (Foverlay_put): Say what the return value is
4585 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4586 is a directory before asking whether to use the file name
4588 (barf_or_query_if_file_exists): Make the "File is a directory"
4589 error be more correct.
4591 * fns.c (Frequire): Remove the mention of the .gz files, since
4592 that's installation-specific, but keep the mention of
4593 `get-load-suffixes'.
4595 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4597 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4598 Report string overflow if the output is too long.
4600 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4602 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4603 (syms_of_gnutls): Remove duplicate DEFSYM for
4604 Qgnutls_bootprop_verify_hostname_error, an error for
4605 Qgnutls_bootprop_verify_error (which is no longer used).
4607 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4608 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4609 Also (re)move comments that are misplaced or no longer relevant.
4611 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4613 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4615 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4617 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4618 and background color parameters if they have been changed.
4620 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4622 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4624 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4626 * xsettings.c (SYSTEM_FONT): Define only when used.
4627 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4629 * keymap.c (access_keymap_1): Now static.
4631 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4633 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4634 leave any prefix arg for the up event (Bug#1586).
4636 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4638 * lread.c (syms_of_lread): Mention single symbols defined by
4639 `defvar' or `defconst' (bug#7154).
4641 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4642 (Frequire): Mention get-load-suffixes.
4644 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4646 * window.h (window): Remove clone_number slot.
4647 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4649 (make_parent_window, make_window, saved_window)
4650 (Fset_window_configuration, save_window_save): Don't deal with
4652 * buffer.c (Qclone_number): Remove declaration.
4653 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4655 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4657 Add multiple inheritance to keymaps.
4658 * keymap.c (Fmake_composed_keymap): New function.
4659 (Fset_keymap_parent): Simplify.
4660 (fix_submap_inheritance): Remove.
4661 (access_keymap_1): New function extracted from access_keymap to handle
4662 embedded parents and handle lists of maps.
4663 (access_keymap): Use it.
4664 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4665 (Fcopy_keymap): Handle embedded parents.
4666 (Fcommand_remapping, define_as_prefix): Simplify.
4667 (Fkey_binding): Simplify.
4668 (syms_of_keymap): Move minibuffer-local-completion-map,
4669 minibuffer-local-filename-completion-map,
4670 minibuffer-local-must-match-map, and
4671 minibuffer-local-filename-must-match-map to Elisp.
4672 (syms_of_keymap): Defsubr make-composed-keymap.
4673 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4674 (parse_menu_item): Trivial simplification.
4676 2011-07-01 Glenn Morris <rgm@gnu.org>
4678 * Makefile.in (SETTINGS_LIBS): Fix typo.
4680 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4682 * coding.c (Fencode_coding_string): Record the last coding system
4683 used, as the function doc string says (bug#8738).
4685 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4687 * xsettings.c (store_monospaced_changed): Take new font as arg and
4688 check for change against current_mono_font.
4689 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4690 (emacs_settings_constructor, emacs_settings_get_property)
4691 (emacs_settings_set_property, emacs_settings_class_init)
4692 (emacs_settings_init, gsettings_obj): Remove.
4693 (something_changedCB): New function for HAVE_GSETTINGS.
4694 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4695 with value as argument.
4696 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4697 g_settings_new (Bug#8967). Do not create gsettings_obj.
4698 Remove calls to g_settings_bind. Connect something_changedCB to
4701 * xgselect.c: Add defined (HAVE_GSETTINGS).
4702 (xgselect_initialize): Ditto.
4704 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4705 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4708 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4710 * eval.c (struct backtrace): Simplify and port the data structure.
4711 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4712 signed bit field, as this assumption is not portable and it makes
4713 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4714 "char debug_on_exit : 1" as this is not portable either; instead,
4715 use the portable "unsigned int debug_on_exit : 1". Remove unused
4716 member evalargs. Remove obsolete comments about cc bombing out.
4718 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4720 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4721 Let HAVE_GSETTINGS override HAVE_GCONF.
4722 (store_monospaced_changed): New function.
4723 (EMACS_SETTINGS): A new type derived from GObject to handle
4724 GSettings notifications.
4725 (emacs_settings_constructor, emacs_settings_get_property)
4726 (emacs_settings_set_property, emacs_settings_class_init):
4728 (gsettings_client, gsettings_obj): New variables.
4729 (GSETTINGS_SCHEMA): New define.
4730 (something_changedCB): Call store_monospaced_changed.
4731 (init_gsettings): New function.
4732 (xsettings_initialize): Call init_gsettings.
4733 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4736 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4739 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4741 * window.c (resize_root_window, grow_mini_window)
4742 (shrink_mini_window): Rename Qresize_root_window to
4743 Qwindow_resize_root_window and Qresize_root_window_vertically to
4744 Qwindow_resize_root_window_vertically.
4746 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4748 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4750 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4752 * makefile.w32-in: Redesign dependencies so they reflect more
4753 clearly which files are directly included by each source file,
4754 and not through other includes.
4756 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4758 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4759 (sort_overlays, overlay_strings): When an overlay's clone number
4760 matches the window's clone number process the overlay even if
4761 the overlay's window property doesn't match the current window.
4763 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4764 (Fwindow_hchild): Rename to Fwindow_left_child.
4765 (Fwindow_next): Rename to Fwindow_next_sibling.
4766 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4767 (resize_window_check): Rename to window_resize_check.
4768 (resize_window_apply): Rename to window_resize_apply.
4769 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4770 (Fdelete_other_windows_internal, resize_frame_windows)
4771 (Fsplit_window_internal, Fdelete_window_internal)
4772 (grow_mini_window, shrink_mini_window)
4773 (Fresize_mini_window_internal): Fix callers accordingly.
4775 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4777 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4778 (emacs_fixed_set_min_size): Remove.
4779 (emacs_fixed_new): Take frame as argument.
4781 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4782 (_EmacsFixedPrivate): Remove minwidth/height.
4783 Add struct frame *f.
4784 (emacs_fixed_init): Initialize priv->f.
4785 (get_parent_class, emacs_fixed_set_min_size): Remove.
4786 (emacs_fixed_new): Set priv->f to argument.
4787 (emacs_fixed_get_preferred_width)
4788 (emacs_fixed_get_preferred_height): Use min_width/height from
4789 frames size_hint to set minimum and natural (Bug#8919).
4790 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4791 and use min_width/height from frames size_hint to set
4792 min_width/height (Bug#8919).
4794 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4795 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4798 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4800 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4801 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4804 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4806 * process.c (wait_reading_process_output): Bypass select if
4807 waiting for a cell while ignoring keyboard input, and input is
4808 pending. Suggested by Jan Djärv (Bug#8869).
4810 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4812 Use gnulib's dup2 module instead of rolling our own.
4813 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4815 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4817 * dispnew.c (scrolling_window): Before scrolling, turn off a
4818 mouse-highlight in the window being scrolled.
4820 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4822 Move DEFSYM to lisp.h and use everywhere.
4824 * character.h (DEFSYM): Move declaration...
4825 * lisp.h (DEFSYM): ...here.
4831 * w32select.c: Don't include character.h.
4833 * alloc.c (syms_of_alloc):
4834 * buffer.c (syms_of_buffer):
4835 * bytecode.c (syms_of_bytecode):
4836 * callint.c (syms_of_callint):
4837 * casefiddle.c (syms_of_casefiddle):
4838 * casetab.c (init_casetab_once):
4839 * category.c (init_category_once, syms_of_category):
4840 * ccl.c (syms_of_ccl):
4841 * cmds.c (syms_of_cmds):
4842 * composite.c (syms_of_composite):
4843 * dbusbind.c (syms_of_dbusbind):
4844 * dired.c (syms_of_dired):
4845 * dispnew.c (syms_of_display):
4846 * doc.c (syms_of_doc):
4847 * editfns.c (syms_of_editfns):
4848 * emacs.c (syms_of_emacs):
4849 * eval.c (syms_of_eval):
4850 * fileio.c (syms_of_fileio):
4851 * fns.c (syms_of_fns):
4852 * frame.c (syms_of_frame):
4853 * fringe.c (syms_of_fringe):
4854 * insdel.c (syms_of_insdel):
4855 * keymap.c (syms_of_keymap):
4856 * lread.c (init_obarray, syms_of_lread):
4857 * macros.c (syms_of_macros):
4858 * msdos.c (syms_of_msdos):
4859 * print.c (syms_of_print):
4860 * process.c (syms_of_process):
4861 * search.c (syms_of_search):
4862 * sound.c (syms_of_sound):
4863 * syntax.c (init_syntax_once, syms_of_syntax):
4864 * terminal.c (syms_of_terminal):
4865 * textprop.c (syms_of_textprop):
4866 * undo.c (syms_of_undo):
4867 * w32.c (globals_of_w32):
4868 * window.c (syms_of_window):
4869 * xdisp.c (syms_of_xdisp):
4870 * xfaces.c (syms_of_xfaces):
4871 * xfns.c (syms_of_xfns):
4872 * xmenu.c (syms_of_xmenu):
4873 * xsettings.c (syms_of_xsettings):
4874 * xterm.c (syms_of_xterm): Use DEFSYM.
4876 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4878 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4880 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4882 Integer and buffer overflow fixes (Bug#8873).
4884 * print.c (printchar, strout): Check for string overflow.
4885 (PRINTPREPARE, printchar, strout):
4886 Don't set size unless allocation succeeds.
4888 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4889 for sizes. Check for string overflow more accurately.
4890 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4892 * macros.c: Integer and buffer overflow fixes.
4893 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4894 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4895 Use ptrdiff_t, not int, for sizes.
4896 Don't increment bufsize until after realloc succeeds.
4897 Check for size-calculation overflow.
4898 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4900 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4902 * lread.c: Integer overflow fixes.
4903 (read_integer): Radix is now EMACS_INT, not int,
4904 to improve quality of diagnostics for out-of-range radices.
4905 Calculate buffer size correctly for out-of-range radices.
4906 (read1): Check for integer overflow in radices, and in
4907 read-circle numbers.
4908 (read_escape): Avoid int overflow.
4909 (Fload, openp, read_buffer_size, read1)
4910 (substitute_object_recurse, read_vector, read_list, map_obarray):
4911 Use ptrdiff_t, not int, for sizes.
4912 (read1): Use EMACS_INT, not int, for sizes.
4913 Check for size overflow.
4915 * image.c (cache_image): Check for size arithmetic overflow.
4917 * lread.c: Integer overflow issues.
4918 (saved_doc_string_size, saved_doc_string_length)
4919 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4920 Now ptrdiff_t, not int.
4921 (read1): Don't assume doc string length fits in int. Check for
4922 out-of-range doc string lengths.
4923 (read_list): Don't assume file position fits in int.
4924 (read_escape): Check for hex character overflow.
4926 2011-06-22 Leo Liu <sdl.web@gmail.com>
4928 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4929 Move to minibuffer.el.
4931 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4933 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4934 The following patches are for when GLYPH_DEBUG && !XASSERT.
4935 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4936 * dispnew.c (flush_stdout):
4937 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4938 Mark as externally visible.
4939 * dispnew.c (check_window_matrix_pointers): Now static.
4940 * dispnew.c (window_to_frame_vpos):
4941 * xfns.c (unwind_create_frame):
4942 * xterm.c (x_check_font): Remove unused local.
4943 * scroll.c (CHECK_BOUNDS):
4944 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4945 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4946 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4947 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4948 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4950 (debug_method_add): Use va_list and vsprintf rather than relying
4951 on undefined behavior with wrong number of arguments.
4952 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4953 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4954 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4955 since we're not interested in debugging glyphs with old libraries.
4956 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4957 GCC 4.6.0's static checking.
4959 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4961 Integer overflow and signedness fixes (Bug#8873).
4962 A few related buffer overrun fixes, too.
4964 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4966 * dispextern.h (struct face.stipple):
4967 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4968 (x_bitmap_mask, x_allocate_bitmap_record)
4969 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4970 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4971 (x_create_bitmap_from_xpm_data):
4972 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4973 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4975 * xfaces.c (load_pixmap):
4976 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4977 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4978 (.bitmaps_last, struct x_output.icon_bitmap):
4979 Use ptrdiff_t, not int, for bitmap indexes.
4980 (x_allocate_bitmap_record): Check for size overflow.
4981 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4983 Use ptrdiff_t, not int, for overlay counts.
4984 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4985 * editfns.c (overlays_around, get_pos_property):
4986 * textprop.c (get_char_property_and_overlay):
4987 * xdisp.c (next_overlay_change, note_mouse_highlight):
4988 * xfaces.c (face_at_buffer_position):
4989 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4990 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4991 (Fnext_overlay_change, Fprevious_overlay_change)
4992 (mouse_face_overlay_overlaps, Foverlays_in):
4993 Use ptrdiff_t, not int, for sizes.
4994 (overlays_at, overlays_in): Check for size-calculation overflow.
4996 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4998 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4999 (x_session_initialize): Do not assume string length fits in int.
5001 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5002 This is unlikely, but can occur if DPI is outlandish.
5004 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5005 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5007 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5008 * xrdb.c (magic_file_p, search_magic_path):
5009 Omit last arg SUFFIX; it was always 0. All callers changed.
5010 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5012 * xfont.c (xfont_match): Avoid need for strlen.
5014 * xfns.c: Don't assume strlen fits in int.
5015 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5017 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5018 not unsigned long, as we prefer signed integers. All callers changed.
5019 Detect integer overflow in repeat count.
5020 (message_dolog): Don't assume print length fits in 39 bytes.
5021 (display_mode_element): Don't assume strlen fits in int.
5023 * termcap.c: Don't assume sizes fit in int and never overflow.
5024 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5025 (gobble_line): Check for size-calculation overflow.
5027 * minibuf.c (Fread_buffer):
5028 * lread.c (intern, intern_c_string):
5029 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5030 Don't assume string length fits in int.
5032 * keyboard.c (parse_tool_bar_item):
5033 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5035 * font.c: Don't assume string length fits in int.
5036 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5037 Use ptrdiff_t, not int.
5038 (font_intern_prop): Don't assume string length fits in int.
5039 Don't assume integer property fits in fixnum.
5040 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5042 * filelock.c: Fix some buffer overrun and integer overflow issues.
5043 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5044 Reformulate so as not to need the command string.
5045 Invoke gzip -cd rather than gunzip, as it's more portable.
5046 (lock_info_type, lock_file_1, lock_file):
5047 Don't assume pid_t and time_t fit in unsigned long.
5048 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5049 (current_lock_owner): Prefer signed type for sizes.
5050 Use memcpy, not strncpy, where memcpy is what is really wanted.
5051 Don't assume (via atoi) that time_t and pid_t fit in int.
5052 Check for time_t and/or pid_t out of range, e.g., via a network share.
5053 Don't alloca where an auto var works fine.
5055 * fileio.c: Fix some integer overflow issues.
5056 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5057 Don't assume string length fits in int.
5058 (directory_file_name): Don't assume string length fits in long.
5059 (make_temp_name): Don't assume pid fits in int, or that its print
5060 length is less than 20.
5062 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5064 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5066 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5068 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5069 We prefer signed integers, even for size calculations.
5071 * emacs.c: Don't assume string length fits in 'int'.
5072 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5073 (main): Don't invoke strlen when not needed.
5075 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5076 (XD_DEBUG_MESSAGE): Don't waste a byte.
5078 * callproc.c (getenv_internal_1, getenv_internal)
5080 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5082 * lread.c (invalid_syntax): Omit length argument.
5083 All uses changed. This doesn't fix a bug, but it simplifies the
5084 code away from its former Hollerith-constant appearance, and it's
5085 one less 'int' to worry about when looking at integer-overflow issues.
5086 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5088 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5089 This didn't break anything, but it didn't help either.
5090 It's confusing to put a bogus integer in a place where the actual
5091 value does not matter.
5092 (LIST_END_P): Remove unused macro and its bogus comment.
5093 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5095 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5096 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5098 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5099 We prefer signed types, and the value cannot exceed the EMACS_INT
5100 range anyway (because otherwise the length would not be representable).
5101 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5102 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5103 This avoids a GCC warning when WIDE_EMACS_INT.
5105 * indent.c (sane_tab_width): New function.
5106 (current_column, scan_for_column, Findent_to, position_indentation)
5107 (compute_motion): Use it. This is just for clarity.
5108 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5110 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5112 * lisp.h (lint_assume): New macro.
5113 * composite.c (composition_gstring_put_cache):
5114 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5116 * editfns.c, insdel.c:
5117 Omit unnecessary forward decls, to simplify future changes.
5119 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5121 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5123 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5124 Use much-faster test for byte-length change.
5125 Don't assume string byte-length fits in 'int'.
5126 Check that character arg fits in 'int'.
5127 (mapcar1): Declare byte as byte, for clarity.
5129 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5131 * fns.c (concat): Catch string overflow earlier.
5132 Do not rely on integer wraparound.
5134 * dispextern.h (struct it.overlay_strings_charpos)
5135 (struct it.selective): Now EMACS_INT, not int.
5136 * xdisp.c (forward_to_next_line_start)
5137 (back_to_previous_visible_line_start)
5138 (reseat_at_next_visible_line_start, next_element_from_buffer):
5139 Don't arbitrarily truncate the value of 'selective' to int.
5141 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5143 * composite.c: Don't truncate sizes to 'int'.
5144 (composition_gstring_p, composition_reseat_it)
5145 (composition_adjust_point): Use EMACS_INT, not int.
5146 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5147 not EMACS_UINT, for indexes.
5149 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5151 * buffer.c: Include <verify.h>.
5152 (struct sortvec.priority, struct sortstr.priority):
5153 Now EMACS_INT, not int.
5154 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5155 (struct sortstr.size, record_overlay_string)
5156 (struct sortstrlist.size, struct sortlist.used):
5157 Don't truncate size to int.
5158 (record_overlay_string): Check for size-calculation overflow.
5159 (init_buffer_once): Check at compile-time, not run-time.
5161 2011-06-22 Jim Meyering <meyering@redhat.com>
5163 Don't leak an XBM-image-sized buffer
5164 * image.c (xbm_load): Free the image buffer after using it.
5166 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5169 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5170 that Sun C diagnosed.
5171 * fns.c (secure_hash): Fix pointer signedness issue.
5172 * intervals.c (static_offset_intervals): New function.
5173 (offset_intervals): Use it.
5175 2011-06-21 Leo Liu <sdl.web@gmail.com>
5178 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5181 * fns.c (secure_hash): Rename from crypto_hash_function and change
5182 the first arg to accept symbols.
5183 (Fsecure_hash): New primitive.
5184 (syms_of_fns): New symbols.
5186 2011-06-20 Deniz Dogan <deniz@dogan.se>
5188 * process.c (Fset_process_buffer): Clarify return value in
5191 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5193 * dispnew.c (add_window_display_history): Use BVAR.
5195 * xdisp.c (debug_method_add): Use BVAR.
5196 (check_window_end, dump_glyph_matrix, dump_glyph)
5197 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5199 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5202 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5203 check till after the cache is created in init_frame_faces.
5205 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5207 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5209 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5211 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5212 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5213 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5215 Improve buffer-overflow checking (Bug#8873).
5216 * fileio.c (Finsert_file_contents):
5217 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5218 Remove the old (too-loose) buffer overflow checks.
5219 They weren't needed, since make_gap checks for buffer overflow.
5220 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5221 The old code merely checked for Emacs fixnum overflow, and relied
5222 on undefined (wraparound) behavior. The new code avoids undefined
5223 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5225 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5226 Tune. Don't use wider integers than needed. Don't use alloca.
5227 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5229 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5231 * insdel.c, lisp.h (buffer_overflow): New function.
5232 (insert_from_buffer_1, replace_range, replace_range_2):
5233 * insdel.c (make_gap_larger):
5234 * editfns.c (Finsert_char):
5235 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5237 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5239 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5241 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5243 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5244 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5246 * fileio.c: Don't assume EMACS_INT fits in off_t.
5247 (emacs_lseek): New static function.
5248 (Finsert_file_contents, Fwrite_region): Use it.
5249 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5251 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5253 * fns.c: Don't overflow int when computing a list length.
5254 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5255 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5256 truncation on 64-bit hosts. Check for QUIT every
5257 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5258 faster and is responsive enough.
5259 (Flength): Report an error instead of overflowing an integer.
5260 (Fsafe_length): Return a float if the value is not representable
5261 as a fixnum. This shouldn't happen except in contrived situations.
5262 (Fnthcdr, Fsort): Don't assume list length fits in int.
5263 (Fcopy_sequence): Don't assume vector length fits in int.
5265 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5266 (header_size, word_size): New constants.
5267 (allocate_vectorlike): Don't check size overflow here.
5268 (allocate_vector): Check it here instead, since this is the only
5269 caller of allocate_vectorlike that could cause overflow.
5270 Check that the new vector's length is representable as a fixnum.
5272 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5273 The previous code was bogus. For example, next_almost_prime (32)
5274 returned 39, which is undesirable as it is a multiple of 3; and
5275 next_almost_prime (24) returned 25, which is a multiple of 5 so
5276 why was the code bothering to check for multiples of 7?
5278 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5280 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5282 Variadic C functions now count arguments with ptrdiff_t.
5283 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5284 Back then I didn't know that the Emacs coding style prefers signed int.
5285 Also, in the meantime I found a few more instances where arguments
5286 were being counted with int, which may truncate counts on 64-bit
5287 machines, or EMACS_INT, which may be unnecessarily wide.
5288 * lisp.h (struct Lisp_Subr.function.aMANY)
5289 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5290 Arg counts are now ptrdiff_t, not size_t.
5291 All variadic functions and their callers changed accordingly.
5292 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5293 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5294 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5295 * callint.c (Fcall_interactively): Check arg count for overflow,
5296 to avoid potential buffer overrun. Use signed char, not 'int',
5297 for 'varies' array, so that we needn't bother to check its size
5298 calculation for overflow.
5299 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5300 * eval.c (apply_lambda):
5301 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5302 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5303 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5305 * callint.c (Fcall_interactively): Don't use index var as event count.
5307 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5308 * mem-limits.h (SIZE): Remove; no longer used.
5310 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5312 Remove unnecessary casts.
5313 * xterm.c (x_term_init):
5314 * xfns.c (x_set_border_pixel):
5315 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5316 These aren't needed now that we assume ANSI C.
5318 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5319 It's more likely to cause problems (due to unsigned overflow)
5322 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5324 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5326 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5328 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5330 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5332 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5334 GLYPH_CODE_FACE returns EMACS_INT, not int.
5335 * dispextern.h (merge_faces):
5336 * xfaces.c (merge_faces):
5337 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5338 Don't assume EMACS_INT fits in int.
5340 * character.h (CHAR_VALID_P): Remove unused parameter.
5341 * fontset.c, lisp.h, xdisp.c: All uses changed.
5343 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5345 * fns.c (concat): Minor tuning based on overflow analysis.
5346 This doesn't fix any bugs. Use int to hold character, instead
5347 of constantly refetching from Emacs object. Use XFASTINT, not
5348 XINT, for value known to be a character. Don't bother comparing
5349 a single byte to 0400, as it's always less.
5351 * floatfns.c (Fexpt):
5352 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5354 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5357 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5359 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5360 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5361 incorrectly succeed when S was a string, because 4294967386 was
5362 truncated before it was used.
5364 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5365 Otherwise, an out-of-range integer could cause undefined behavior
5368 * composite.c: Use int, not EMACS_INT, for characters.
5369 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5370 EMACS_INT, for values that are known to be in character range.
5371 This doesn't fix any bugs but is the usual style inside Emacs and
5372 may generate better code on 32-bit machines.
5374 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5375 This is for reasons similar to the recent CHAR_STRING fix.
5376 * charset.c (Fencode_char): Check that character arg is actually
5377 a character. Pass an int to ENCODE_CHAR.
5378 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5379 wider than 'int', as a compile-time check to prevent future regressions
5382 * character.c (char_string): Remove unnecessary casts.
5384 Make sure a 64-bit char is never passed to CHAR_STRING.
5385 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5386 by silently ignoring the top 32 bits, allowing some values
5387 that were far too large to be valid characters.
5388 * character.h: Include <verify.h>.
5389 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5390 arguments are no wider than unsigned, as a compile-time check
5391 to prevent future regressions in this area.
5393 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5394 (Fsubst_char_in_region):
5396 * xdisp.c (decode_mode_spec_coding):
5397 Adjust to CHAR_STRING's new requirement.
5398 * editfns.c (Finsert_char, Fsubst_char_in_region):
5399 * fns.c (concat): Check that character args are actually
5400 characters. Without this test, these functions did the wrong
5401 thing with wildly out-of-range values on 64-bit hosts.
5403 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5404 These casts should not be needed on 32-bit hosts, either.
5405 * keyboard.c (read_char):
5406 * lread.c (Fload): Remove casts to unsigned.
5408 * lisp.h (UNSIGNED_CMP): New macro.
5409 This fixes comparison bugs on 64-bit hosts.
5410 (ASCII_CHAR_P): Use it.
5411 * casefiddle.c (casify_object):
5412 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5413 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5414 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5415 * dispextern.h (FACE_FROM_ID):
5416 * keyboard.c (read_char): Use UNSIGNED_CMP.
5418 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5419 not to EMACS_INT, to avoid GCC warning.
5421 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5423 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5424 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5425 isn't needed on 32-bit machines.
5427 * buffer.c (Fgenerate_new_buffer_name):
5428 Use EMACS_INT for count, not int.
5429 (advance_to_char_boundary): Return EMACS_INT, not int.
5431 * data.c (Qcompiled_function): Now static.
5433 * window.c (window_body_lines): Now static.
5435 * image.c (gif_load): Rename local to avoid shadowing.
5437 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5438 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5439 * alloc.c (make_save_value): Integer argument is now of type
5441 (mark_object): Use ptrdiff_t, not int.
5442 * lisp.h (pD): New macro.
5443 * print.c (print_object): Use it.
5445 * alloc.c: Use EMACS_INT, not int, to count objects.
5446 (total_conses, total_markers, total_symbols, total_vector_size)
5447 (total_free_conses, total_free_markers, total_free_symbols)
5448 (total_free_floats, total_floats, total_free_intervals)
5449 (total_intervals, total_strings, total_free_strings):
5450 Now EMACS_INT, not int. All uses changed.
5451 (Fgarbage_collect): Compute overall total using a double, so that
5452 integer overflow is less likely to be a problem. Check for overflow
5453 when converting back to an integer.
5454 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5455 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5456 These were 'int' variables that could overflow on 64-bit hosts;
5457 they were never used, so remove them instead of repairing them.
5458 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5459 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5460 Previously, this ceilinged at INT_MAX, but that doesn't work on
5462 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5464 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5465 (allocate_vectorlike): Check for ptrdiff_t overflow.
5466 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5467 when a (possibly-narrower) signed value would do just as well.
5468 We prefer using signed arithmetic, to avoid comparison confusion.
5470 * alloc.c: Catch some string size overflows that we were missing.
5471 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5472 for convenience in STRING_BYTES_MAX.
5473 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5474 The definition here is exact; the one in lisp.h was approximate.
5475 (allocate_string_data): Check for string overflow. This catches
5476 some instances we weren't catching before. Also, it catches
5477 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5478 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5479 and ptrdiff_t and EMACS_INT are both 64 bits.
5481 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5482 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5483 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5485 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5487 * alloc.c (Fmake_string): Check for out-of-range init.
5489 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5491 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5493 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5495 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5496 xg_get_default_scrollbar_width.
5498 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5499 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5500 (style_changed_cb): Call update_theme_scrollbar_width and call
5501 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5502 all frames (Bug#8505).
5503 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5504 Call gtk_window_set_resizable if HAVE_GTK3.
5505 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5506 and height if HAVE_GTK3 (Bug#8505).
5507 (scroll_bar_width_for_theme): New variable.
5508 (update_theme_scrollbar_width): New function.
5509 (xg_get_default_scrollbar_width): Move code to
5510 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5511 (xg_initialize): Call update_theme_scrollbar_width.
5513 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5515 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5517 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5519 * frame.c (make_frame): Call other_buffer_safely instead of
5522 * window.c (temp_output_buffer_show): Call display_buffer with
5523 second argument Vtemp_buffer_show_specifiers and reset latter
5524 immediately after the call.
5525 (Vtemp_buffer_show_specifiers): New variable.
5526 (auto_window_vscroll_p, next_screen_context_lines)
5527 (Vscroll_preserve_screen_position): Remove leading asterisks from
5530 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5532 Fix minor problems found by GCC 4.6.0 static checking.
5533 * buffer.c (Qclone_number): Remove for now, as it's unused.
5534 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5535 (record_buffer): Remove unused local.
5536 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5537 (set_frame_buffer_list): Remove; unused.
5538 * frame.h (other_visible_frames): Remove decl.
5539 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5540 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5541 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5543 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5544 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5545 Define only if HAVE_GPM.
5546 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5547 (update_hints_inhibit): Remove; never set. All uses removed.
5548 * widgetprv.h (emacsFrameClassRec): Remove decl.
5549 * window.c (delete_deletable_window): Now returns void, since it
5550 wasn't returning anything.
5551 (compare_window_configurations): Remove unused locals.
5552 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5553 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5554 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5555 the same widths as pointers. This follows up on the 2011-05-06 patch.
5556 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5557 * xterm.h: Likewise.
5558 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5560 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5562 * makefile.w32-in: Update dependencies.
5563 (LISP_H): Add lib/intprops.h.
5565 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5567 * image.c (gif_load): Add animation frame delay to the metadata.
5568 (syms_of_image): Use DEFSYM. New symbol `delay'.
5570 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5572 * window.c (delete_deletable_window): Re-add.
5573 (Fset_window_configuration): Rewrite to handle dead buffers and
5574 consequently deletable windows.
5575 (window_tree, Fwindow_tree): Remove. Supply functionality in
5577 (compare_window_configurations): Simplify code.
5579 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5581 * image.c (imagemagick_load_image): Fix type mismatch.
5582 (Fimagemagick_types): Likewise.
5584 * window.h (replace_buffer_in_windows): Declare.
5586 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5588 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5589 Qclone_number. Remove external declaration of Qdelete_window.
5590 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5592 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5593 Run Qbuffer_list_update_hook if allowed.
5594 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5595 buffer list implementation.
5596 (other_buffer_safely): New function.
5597 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5598 calls to replace_buffer_in_windows and
5599 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5601 (record_buffer): Inhibit quitting and rewrite using quittable
5602 functions. Run Qbuffer_list_update_hook if allowed.
5603 (Frecord_buffer, Funrecord_buffer): New functions.
5604 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5605 Move switch-to-buffer to window.el.
5606 (bury-buffer): Move to window.el.
5607 (Vbuffer_list_update_hook): New variable.
5609 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5612 * window.h (resize_frame_windows): Move up in code.
5613 (Fwindow_frame): Remove EXFUN.
5614 (replace_buffer_in_all_windows): Remove prototype.
5615 (replace_buffer_in_windows_safely): Add prototype.
5617 * window.c: Declare Qdelete_window static again. Move down
5618 declaration of select_count.
5619 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5620 (Fother_window): Move to window.el.
5621 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5622 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5623 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5625 (replace_buffer_in_windows): Implement by calling
5626 Qreplace_buffer_in_windows.
5627 (replace_buffer_in_all_windows): Remove with some functionality
5628 moved into replace_buffer_in_windows_safely.
5629 (replace_buffer_in_windows_safely): New function.
5630 (select_window_norecord, select_frame_norecord): Move in front
5631 of run_window_configuration_change_hook. Remove now obsolete
5633 (Fset_window_buffer): Rewrite doc-string.
5634 Call Qrecord_window_buffer.
5635 (keys_of_window): Move binding for other-window to window.el.
5637 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5639 * dispextern.h (struct image): Replace data member, whose int_val
5640 and ptr_val fields were not used by anything, with a single
5643 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5644 (gif_clear_image, gif_load, imagemagick_load_image)
5645 (gs_clear_image, gs_load): Callers changed.
5647 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5649 * buffer.h: Include <time.h>, for time_t.
5650 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5652 Fix minor problems found by static checking.
5654 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5656 Make identifiers static if they are not used in other modules.
5657 * data.c (Qcompiled_function, Qframe, Qvector):
5658 * image.c (QimageMagick, Qsvg):
5659 * minibuf.c (Qmetadata):
5660 * window.c (resize_window_check, resize_root_window): Now static.
5661 * window.h (resize_window_check, resize_root_window): Remove decls.
5663 * window.c (window_deletion_count, delete_deletable_window):
5665 (window_body_lines): Now static.
5666 (Fdelete_other_windows_internal): Mark vars as initialized.
5667 Make sure 'resize_failed' is initialized.
5668 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5669 (resize_window_apply): Remove unused local.
5670 * window.h (delete_deletable_window): Remove decl.
5672 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5673 (imagemagick_load_image): Fix pointer signedness problem by changing
5674 last arg from unsigned char * to char *. All uses changed.
5675 Also, fix a local for similar reasons.
5676 Remove unused locals. Remove locals to avoid shadowing.
5677 (fn_rsvg_handle_free): Remove; unused.
5678 (svg_load, svg_load_image): Fix pointer signedness problem.
5679 (imagemagick_load_image): Don't use garbage pointer image_wand.
5681 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5683 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5685 * image.c (gif_load): Fix omitted cast error introduced by
5688 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5690 * window.h (resize_proportionally, orig_total_lines)
5691 (orig_top_line): Remove from window structure.
5692 (set_window_height, set_window_width, change_window_heights)
5693 (Fdelete_window): Remove prototypes.
5694 (resize_frame_windows): Remove duplicate declaration.
5696 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5698 * window.h (resize_frame_windows, resize_window_check)
5699 (delete_deletable_window, resize_root_window)
5700 (resize_frame_windows): Declare prototypes.
5702 * window.c (resize_window_apply): Make definition be "static" to
5703 match the prototype.
5705 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5707 * window.c: Remove declarations of Qwindow_size_fixed,
5708 window_min_size_1, window_min_size_2, window_min_size,
5709 size_window, window_fixed_size_p, enlarge_window, delete_window.
5710 Remove static from declaration of Qdelete_window, it's
5711 temporarily needed by Fbury_buffer.
5712 (replace_window): Don't assign orig_top_line and
5714 (Fdelete_window, delete_window): Remove. Window deletion is
5715 handled by window.el.
5716 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5717 Replace Fdelete_window calls with calls to Qdelete_window.
5718 (Fdelete_other_windows): Remove. Deleting other windows is
5719 handled by window.el.
5720 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5721 handled in window.el.
5722 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5723 Window minimum sizes are handled in window.el.
5724 (shrink_windows, size_window, set_window_height)
5725 (set_window_width, change_window_heights, window_height)
5726 (window_width, CURBEG, CURSIZE, enlarge_window)
5727 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5728 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5729 handled in window.el.
5730 (make_dummy_parent): Rename to make_parent_window and give it a
5731 second argument horflag.
5732 (make_window): Don't set resize_proportionally any more.
5733 (Fsplit_window): Remove. Windows are split in window.el.
5734 (save_restore_action, save_restore_orig_size)
5735 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5736 Resize mini windows in window.el.
5737 (grow_mini_window, shrink_mini_window): Implement by calling
5738 Qresize_root_window_vertically, resize_window_check and
5739 resize_window_apply.
5740 (saved_window, Fset_window_configuration, save_window_save):
5741 Do not handle orig_top_line, orig_total_lines, and
5742 resize_proportionally.
5743 (window_min_height, window_min_width): Move to window.el.
5744 (keys_of_window): Move bindings for delete-other-windows,
5745 split-window, delete-window and enlarge-window to window.el.
5747 * buffer.c: Temporarily extern Qdelete_window.
5748 (Fbury_buffer): Temporarily call Qdelete_window instead of
5749 Fdelete_window (Fbury_buffer will move to window.el soon).
5751 * frame.c (set_menu_bar_lines_1): Remove code handling
5752 orig_top_line and orig_total_lines.
5754 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5755 set_window_height but set heights directly.
5756 (change_frame_size_1): Use resize_frame_windows.
5758 * xdisp.c (init_xdisp): Don't use set_window_height but set
5761 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5762 Use resize_frame_windows instead of change_window_heights and run
5763 run_window_configuration_change_hook.
5765 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5766 instead of change_window_heights and run
5767 run_window_configuration_change_hook.
5769 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5771 * window.c (replace_window): Rename second argument REPLACEMENT to
5772 NEW. New third argument SETFLAG. Rewrite.
5773 (delete_window, make_dummy_parent): Call replace_window with
5775 (window_list_1): Move down in code.
5776 (run_window_configuration_change_hook): Move set_buffer part
5777 before select_frame_norecord part in order to unwind correctly.
5778 Rename count1 to count.
5779 (recombine_windows, delete_deletable_window, resize_root_window)
5780 (Fdelete_other_windows_internal)
5781 (Frun_window_configuration_change_hook, make_parent_window)
5782 (resize_window_check, resize_window_apply, Fresize_window_apply)
5783 (resize_frame_windows, Fsplit_window_internal)
5784 (Fdelete_window_internal, Fresize_mini_window_internal):
5786 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5788 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5790 * window.h (window): Add some new members to window structure -
5791 normal_lines, normal_cols, new_total, new_normal, clone_number,
5792 splits, nest, prev_buffers, next_buffers.
5793 (WINDOW_TOTAL_SIZE): Move here from window.c.
5794 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5796 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5798 (make_dummy_parent): Set new members of windows structure.
5799 (make_window): Move down in code. Handle new members of window
5801 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5802 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5803 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5804 (Fset_window_prev_buffers, Fwindow_next_buffers)
5805 (Fset_window_next_buffers, Fset_window_clone_number):
5807 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5808 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5810 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5811 Argument WINDOW can be now internal window too.
5812 (Fwindow_use_time): Move up in code.
5813 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5815 (Fset_window_configuration, saved_window)
5816 (Fcurrent_window_configuration, save_window_save): Handle new
5817 members of window structure.
5818 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5819 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5820 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5821 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5822 Qget_mru_window, Qresize_root_window,
5823 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5824 Qauto_buffer_name; staticpro them.
5826 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5828 * window.c (Fwindow_total_size, Fwindow_left_column)
5829 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5830 (Fwindow_list_1): New functions.
5831 (window_box_text_cols): Replace with window_body_cols.
5832 (Fwindow_width, Fscroll_left, Fscroll_right):
5833 Use window_body_cols instead of window_box_text_cols.
5834 (delete_window, Fset_window_configuration):
5835 Call delete_all_subwindows with window as argument.
5836 (delete_all_subwindows): Take a window as argument and not a
5838 (window_loop): Remove handling of GET_LRU_WINDOW and
5840 (Fget_lru_window, Fget_largest_window): Move to window.el.
5842 * window.h: Extern window_body_cols instead of
5843 window_box_text_cols. delete_all_subwindows now takes a
5844 Lisp_Object as argument.
5846 * indent.c (compute_motion, Fcompute_motion):
5847 Use window_body_cols instead of window_box_text_cols.
5849 * frame.c (delete_frame): Call delete_all_subwindows with root
5852 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5854 * fns.c (Fputhash): Document return value.
5856 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5858 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5860 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5862 Cons<->int and similar integer overflow fixes (Bug#8794).
5864 Check for overflow when converting integer to cons and back.
5865 * charset.c (Fdefine_charset_internal, Fdecode_char):
5866 Use cons_to_unsigned to catch overflow.
5867 (Fencode_char): Use INTEGER_TO_CONS.
5868 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5869 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5870 * data.c (long_to_cons, cons_to_long): Remove.
5871 (cons_to_unsigned, cons_to_signed): New functions.
5872 These signal an error for invalid or out-of-range values.
5873 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5874 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5875 * font.c (Ffont_variation_glyphs):
5876 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5877 * lisp.h: Include <intprops.h>.
5878 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5879 (cons_to_signed, cons_to_unsigned): New decls.
5880 (long_to_cons, cons_to_long): Remove decls.
5881 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5882 (Fprimitive_undo): Use CONS_TO_INTEGER.
5883 * xfns.c (Fx_window_property): Likewise.
5884 * xselect.c: Include <limits.h>.
5885 (x_own_selection, selection_data_to_lisp_data):
5886 Use INTEGER_TO_CONS.
5887 (x_handle_selection_request, x_handle_selection_clear)
5888 (x_get_foreign_selection, Fx_disown_selection_internal)
5889 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5890 (lisp_data_to_selection_data): Use cons_to_unsigned.
5891 (x_fill_property_data): Use cons_to_signed.
5892 Report values out of range.
5894 Check for buffer and string overflow more precisely.
5895 * buffer.h (BUF_BYTES_MAX): New macro.
5896 * lisp.h (STRING_BYTES_MAX): New macro.
5897 * alloc.c (Fmake_string):
5898 * character.c (string_escape_byte8):
5899 * coding.c (coding_alloc_by_realloc):
5900 * doprnt.c (doprnt):
5901 * editfns.c (Fformat):
5903 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5904 since they may not be the same number.
5905 * editfns.c (Finsert_char):
5906 * fileio.c (Finsert_file_contents):
5907 Likewise for BUF_BYTES_MAX.
5909 * image.c: Use ptrdiff_t, not int, for sizes.
5910 (slurp_file): Switch from int to ptrdiff_t.
5912 (slurp_file): Check that file size fits in both size_t (for
5913 malloc) and ptrdiff_t (for sanity and safety).
5915 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5916 if b->modtime has its maximal value.
5918 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5920 Don't assume time_t can fit into int.
5921 * buffer.h (struct buffer.modtime): Now time_t, not int.
5922 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5923 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5925 Minor fixes for signed vs unsigned integers.
5926 * character.h (MAYBE_UNIFY_CHAR):
5927 * charset.c (maybe_unify_char):
5928 * keyboard.c (read_char, reorder_modifiers):
5929 XINT -> XFASTINT, since the integer must be nonnegative.
5930 * ftfont.c (ftfont_spec_pattern):
5931 * keymap.c (access_keymap, silly_event_symbol_error):
5932 XUINT -> XFASTINT, since the integer must be nonnegative.
5933 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5934 since it makes no difference and we prefer signed.
5935 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5936 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5939 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5941 * window.h (Fwindow_frame): Declare.
5943 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5945 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5946 (SPARE_MEMORY): Always define.
5947 (LARGE_REQUEST): Remove.
5948 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5950 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5952 * lisp.h: Move EXFUNS for Fframe_root_window,
5953 Fframe_first_window and Fset_frame_selected_window to window.h.
5955 * window.h: Move EXFUNS for Fframe_root_window,
5956 Fframe_first_window and Fset_frame_selected_window here from
5959 * frame.c (Fwindow_frame, Fframe_first_window)
5960 (Fframe_root_window, Fframe_selected_window)
5961 (Fset_frame_selected_window): Move to window.c.
5962 (Factive_minibuffer_window): Move to minibuf.c.
5963 (Fother_visible_frames_p): New function.
5965 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5967 * window.c (decode_window, decode_any_window): Move up in code.
5968 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5969 (inhibit_frame_unsplittable): Remove unused variable.
5970 (Fwindow_buffer): Move up and rewrite doc-string.
5971 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5972 (Fwindow_prev): New functions.
5973 (Fwindow_frame): Move here from frame.c. Accept any window as
5975 (Fframe_root_window, Fframe_first_window)
5976 (Fframe_selected_window): Move here from frame.c. Accept frame
5977 or arbitrary window as argument. Update doc-strings.
5978 (Fminibuffer_window): Move up in code.
5979 (Fwindow_minibuffer_p): Move up in code and simplify.
5980 (Fset_frame_selected_window): Move here from frame.c.
5982 (Fselected_window, select_window, Fselect_window): Move up in
5983 code. Minor doc-string fixes.
5985 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5987 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5988 Do not assume that spare memory exists; that assumption is valid
5989 only if SYSTEM_MALLOC.
5990 (LARGE_REQUEST): New macro, so that the issue of large requests
5991 is separated from the issue of spare memory.
5993 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5995 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5998 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6000 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6003 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6005 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6007 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6009 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6010 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6012 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6014 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6016 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6018 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6019 (x_clipboard_manager_save): Add return value.
6020 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6022 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6023 Obey Vx_select_enable_clipboard_manager. Catch errors in
6024 x_clipboard_manager_save (Bug#8779).
6025 (Vx_select_enable_clipboard_manager): New variable.
6026 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6028 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6030 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6032 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6034 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6035 in the current matrix if keep_current_p is non-zero.
6037 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6039 * bidi.c (bidi_level_of_next_char): Fix last change.
6041 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6043 Support bidi reordering of text covered by display properties.
6045 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6046 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6047 (bidi_cache_search, bidi_cache_iterator_state)
6048 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6049 (bidi_level_of_next_char, bidi_move_to_visually_next):
6050 Support character positions inside a run of characters covered by a
6052 (bidi_paragraph_init, bidi_resolve_explicit_1)
6053 (bidi_level_of_next_char): Call bidi_fetch_char and
6054 bidi_fetch_char_advance instead of FETCH_CHAR and
6056 (bidi_init_it): Initialize new members.
6057 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6059 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6060 instead of using explicit *_CHAR codes.
6061 (bidi_resolve_explicit, bidi_resolve_weak):
6062 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6063 bidirectional text is supported only in multibyte buffers.
6064 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6065 it to initialize the frame_window_p member of struct bidi_it.
6066 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6067 (bidi_resolve_explicit, bidi_resolve_weak)
6068 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6069 bidi_it->nchars is non-positive.
6070 (bidi_level_of_next_char): Don't try to lookup the cache for the
6071 next/previous character if nothing is cached there yet, or if we
6072 were just reseat()'ed to a new position.
6074 * xdisp.c (set_cursor_from_row): Set start and stop points
6075 according to the row's direction when priming the loop that looks
6076 for the glyph on which to display cursor.
6077 (single_display_spec_intangible_p): Function deleted.
6078 (display_prop_intangible_p): Reimplement to call
6079 handle_display_spec instead of single_display_spec_intangible_p.
6080 Accept 3 additional arguments needed by handle_display_spec.
6081 This fixes incorrect cursor motion across display property with complex
6082 values: lists, `(when COND...)' forms, etc.
6083 (single_display_spec_string_p): Support property values that are
6084 lists with the argument STRING its top-level element.
6085 (display_prop_string_p): Fix the condition for processing a
6086 property that is a list to be consistent with handle_display_spec.
6087 (handle_display_spec): New function, refactored from the
6088 last portion of handle_display_prop.
6089 (compute_display_string_pos): Accept additional argument
6090 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6091 value of a `display' property is a "replacing spec".
6092 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6093 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6094 the display property, but just return a value indicating whether
6095 the display property will replace the characters it covers.
6096 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6097 frame_window_p members of struct bidi_it.
6098 (compute_display_string_pos, compute_display_string_end):
6100 (push_it): Accept second argument POSITION, where pop_it should
6101 jump to continue iteration.
6102 (reseat_1): Initialize bidi_it.disp_pos.
6104 * keyboard.c (adjust_point_for_property): Adjust the call to
6105 display_prop_intangible_p to its new signature.
6107 * dispextern.h (struct bidi_it): New member frame_window_p.
6108 (bidi_init_it): Update prototypes.
6109 (display_prop_intangible_p): Update prototype.
6110 (compute_display_string_pos, compute_display_string_end):
6112 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6115 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6117 Malloc failure behavior now depends on size of allocation.
6118 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6119 * lisp.h: Change signatures accordingly.
6120 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6121 All callers changed. (Bug#8762)
6123 * gnutls.c: Use Emacs's memory allocators.
6124 Without this change, the gnutls library would invoke malloc etc.
6125 directly, which causes problems on non-SYNC_INPUT hosts, and which
6126 runs afoul of improving memory_full behavior. (Bug#8761)
6127 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6128 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6129 xfree instead of the default malloc, realloc, free.
6130 (Fgnutls_boot): No need to check for memory allocation failure,
6131 since xmalloc does that for us.
6133 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6134 * category.c (hash_get_category_set):
6135 * ccl.c (ccl_driver):
6136 * charset.c (Fdefine_charset_internal):
6137 * charset.h (struct charset.hash_index):
6138 * composite.c (get_composition_id, gstring_lookup_cache)
6139 (composition_gstring_put_cache):
6140 * composite.h (struct composition.hash_index):
6141 * dispextern.h (struct image.hash):
6142 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6143 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6144 (hashfn_equal, hashfn_user_defined, make_hash_table)
6145 (maybe_resize_hash_table, hash_lookup, hash_put)
6146 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6147 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6148 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6149 * image.c (make_image, search_image_cache, lookup_image)
6150 (xpm_put_color_table_h):
6151 * lisp.h (struct Lisp_Hash_Table):
6152 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6153 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6154 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6155 * alloc.c (allocate_vectorlike):
6156 Check for overflow in vector size calculations.
6157 * ccl.c (ccl_driver):
6158 Check for overflow when converting EMACS_INT to int.
6159 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6160 need to be updated by these changes.
6161 * fns.c (make_hash_table, maybe_resize_hash_table):
6162 Check for integer overflow with large hash tables.
6163 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6164 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6165 (SXHASH_REDUCE): New macro.
6166 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6167 Use it instead of discarding useful hash info with large hash values.
6168 (sxhash_float): New function.
6169 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6170 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6171 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6172 Rewrite to use FIXNUM_BITS, as this simplifies things.
6173 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6174 Adjust signatures to match updated version of code.
6175 (consing_since_gc): Now EMACS_INT, since a single hash table can
6176 use more than INT_MAX bytes.
6178 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6180 Make it possible to build with GCC-4.6+ -O2 -flto.
6182 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6184 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6186 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6187 Call minibuffer-inactive-mode.
6189 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6191 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6192 Update dependencies.
6194 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6196 * data.c (init_data): Remove code for UTS, this system is not
6199 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6201 Don't force ./temacs to start in terminal mode.
6203 * frame.c (make_initial_frame): Initialize faces in all cases, not
6204 only when CANNOT_DUMP is defined.
6205 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6207 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6209 * dispnew.c (add_window_display_history): Use const for the string
6210 pointer. Remove declaration, not needed.
6212 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6214 Use 'inline', not 'INLINE'.
6215 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6216 * alloc.c, fontset.c (INLINE): Remove.
6217 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6218 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6219 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6220 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6221 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6223 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6225 Make it possible to run ./temacs.
6227 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6228 syms_of_callproc does the same thing. Remove test for
6229 "initialized", do it in the caller.
6230 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6232 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6234 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6235 (read_minibuf): Use get_minibuffer.
6236 (syms_of_minibuf): Use DEFSYM.
6237 (Qmetadata): New var.
6238 * data.c (Qbuffer): Don't make it static.
6239 (syms_of_data): Use DEFSYM.
6241 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6243 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6244 (CCL_CODE_MIN): New macro.
6246 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6248 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6250 * eval.c (Qdebug): Now static.
6251 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6252 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6253 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6255 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6257 * image.c: Various fixes to ImageMagick code comments.
6258 (Fimagemagick_types): Doc fix.
6260 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6262 Minor fixes prompted by GCC 4.6.0 warnings.
6264 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6266 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6267 (x_clipboard_manager_save_all): Move extern decl to ...
6268 * xterm.h: ... here, so that it can be checked for consistency.
6270 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6272 * xselect.c (x_clipboard_manager_save_frame)
6273 (x_clipboard_manager_save_all): New functions.
6274 (Fx_clipboard_manager_save): Lisp function deleted.
6276 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6277 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6279 * xterm.h: Update prototype.
6281 2011-05-28 William Xu <william.xwl@gmail.com>
6283 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6286 2011-05-28 Jim Meyering <meyering@redhat.com>
6288 Avoid a sign-extension bug in crypto_hash_function.
6289 * fns.c (to_uchar): Define.
6290 (crypto_hash_function): Use it to convert some newly-signed
6291 variables to unsigned, to avoid sign-extension bugs. For example,
6292 without this change, (md5 "truc") would evaluate to
6293 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6294 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6295 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6297 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6299 Integer overflow fixes.
6301 * dbusbind.c: Serial number integer overflow fixes.
6302 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6303 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6304 to hold a serial number that is too large for a fixnum.
6305 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6306 Check for serial numbers out of range. Decode any serial number
6307 that was so large that it became a float. (Bug#8722)
6309 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6310 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6311 Use XFASTINT rather than XUINT when numbers are nonnegative.
6312 (xd_append_arg, Fdbus_method_return_internal):
6313 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6314 arguments, check that Lisp number is nonnegative, rather than
6315 silently wrapping negative numbers around. (Bug#8722)
6316 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6319 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6321 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6323 ccl: Add integer overflow checks.
6324 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6325 (IN_INT_RANGE): New macros.
6326 (ccl_driver): Use them to check for integer overflow when
6327 decoding a CCL program. Many of the new checks are whether XINT (x)
6328 fits in int; it doesn't always, on 64-bit hosts. The new version
6329 doesn't catch all possible integer overflows, but it's an
6330 improvement. (Bug#8719)
6332 * alloc.c (make_event_array): Use XINT, not XUINT.
6333 There's no need for unsigned here.
6335 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6336 This follows up to the 2011-05-06 change that substituted uintptr_t
6337 for EMACS_INT. This case wasn't caught back then.
6339 Rework Fformat to avoid integer overflow issues.
6340 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6341 now (part of C89). Include <verify.h>.
6342 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6343 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6344 (Fformat): Avoid the prepass trying to compute sizes; it was only
6345 approximate and thus did not catch overflow reliably. Instead, walk
6346 through the format just once, formatting and computing sizes as we go,
6347 checking for integer overflow at every step, and allocating a larger
6348 buffer as needed. Keep track separately whether the format is
6349 multibyte. Keep only the most-recently calculated precision, rather
6350 than them all. Record whether each argument has been converted to
6351 string. Use EMACS_INT, not int, for byte and char and arg counts.
6352 Support field widths and precisions larger than INT_MAX. Avoid
6353 sprintf's undefined behavior with conversion specifications such as %#d
6354 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6355 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6356 formatting out-of-range floating point numbers with int
6359 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6361 * data.c: Avoid integer truncation in expressions involving floats.
6362 * data.c: Include <intprops.h>.
6363 (arith_driver): When there's an integer overflow in an expression
6364 involving floating point, convert the integers to floating point
6365 so that the resulting value does not suffer from catastrophic
6366 integer truncation. For example, on a 64-bit host (* 4
6367 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6368 Do not rely on undefined behavior after integer overflow.
6370 merge count_size_as_multibyte, parse_str_to_multibyte
6371 * character.c, character.h (count_size_as_multibyte):
6372 Rename from parse_str_to_multibyte; all uses changed.
6373 Check for integer overflow.
6374 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6375 since it's now a duplicate of the other. This is more of
6376 a character than a buffer op, so better that it's in character.c.
6377 * fns.c, print.c: Adjust to above changes.
6379 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6381 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6383 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6385 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6386 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6387 (x_clipboard_manager_save): Now static.
6388 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6390 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6391 (crypto_hash_function): Now static.
6392 Fix pointer signedness problems. Avoid unnecessary initializations.
6394 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6396 * termhooks.h (Vselection_alist): Make it terminal-local.
6398 * terminal.c (create_terminal): Initialize it.
6400 * xselect.c: Support for clipboard managers.
6401 (Vselection_alist): Move to termhooks.h as terminal-local var.
6402 (LOCAL_SELECTION): New macro.
6403 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6404 (symbol_to_x_atom): Remove gratuitous arg.
6405 (x_handle_selection_request, lisp_data_to_selection_data)
6406 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6407 (x_own_selection, x_get_local_selection, x_convert_selection):
6408 New arg, specifying work frame. Use terminal-local Vselection_alist.
6409 (some_frame_on_display): Delete unused function.
6410 (Fx_own_selection_internal, Fx_get_selection_internal)
6411 (Fx_disown_selection_internal, Fx_selection_owner_p)
6412 (Fx_selection_exists_p): New optional frame arg.
6413 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6414 (x_handle_selection_clear): Don't treat other terminals with the
6415 same keyboard specially. Use the terminal-local Vselection_alist.
6416 (x_clear_frame_selections): Use Frun_hook_with_args.
6418 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6420 * xterm.h: Add support for those atoms.
6422 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6424 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6425 (converted_selections, conversion_fail_tag): New global variables.
6426 (x_selection_request_lisp_error): Free the above.
6427 (x_get_local_selection): Remove unnecessary code.
6428 (x_reply_selection_request): Args changed; handle arbitrary array
6429 of converted selections stored in converted_selections.
6430 Separate the XChangeProperty and SelectionNotify steps.
6431 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6432 (x_convert_selection): New function.
6433 (x_handle_selection_event): Simplify.
6434 (x_get_foreign_selection): Don't ignore incoming requests while
6435 waiting for an answer; this will fail when we implement
6436 SAVE_TARGETS, and seems unnecessary anyway.
6437 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6438 (Vx_sent_selection_functions): Doc fix.
6440 2011-05-26 Leo Liu <sdl.web@gmail.com>
6442 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6444 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6446 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6448 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6449 for fringe update if it has periodic bitmap.
6450 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6451 and fringe_bitmap_periodic_p.
6453 * fringe.c (get_fringe_bitmap_data): New function.
6454 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6455 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6456 row. Mark glyph row for fringe update if periodicity changed.
6458 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6459 for fringe update unless it has periodic bitmap.
6461 2011-05-25 Kenichi Handa <handa@m17n.org>
6463 * xdisp.c (get_next_display_element): Set correct it->face_id for
6464 a static composition.
6466 2011-05-24 Leo Liu <sdl.web@gmail.com>
6469 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6471 * fns.c (crypto_hash_function, Fsha1): New function.
6472 (Fmd5): Use crypto_hash_function.
6473 (syms_of_fns): Add Ssha1.
6475 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6477 * gnutls.c: Remove unused macros.
6478 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6479 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6480 Remove macros that are defined and never used.
6481 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6483 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6485 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6486 (Fx_get_selection_internal): Minor cleanup.
6487 (Fx_own_selection_internal): Rename arguments for consistency with
6490 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6492 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6494 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6496 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6498 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6500 * dispnew.c (scrolling_window): Don't exclude the case that the
6501 last enabled row in the desired matrix touches the bottom boundary.
6503 2011-05-21 Glenn Morris <rgm@gnu.org>
6505 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6506 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6507 and add some more files.
6509 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6511 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6512 report_file_error introduced by the change from 2011-05-07.
6514 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6516 * systime.h (Time): Define only if emacs is defined.
6517 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6518 where the include path doesn't have X11/X.h by default. See
6519 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6521 2011-05-20 Kenichi Handa <handa@m17n.org>
6523 * composite.c (find_automatic_composition): Fix previous change.
6525 2011-05-20 Glenn Morris <rgm@gnu.org>
6527 * lisp.mk: New file, split from Makefile.in.
6528 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6529 (shortlisp): Remove.
6530 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6532 2011-05-19 Glenn Morris <rgm@gnu.org>
6534 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6535 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6536 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6537 (lisp): Set the order to that of loadup.el.
6538 (shortlisp): Make it a copy of $lisp.
6539 (SOME_MACHINE_LISP): Remove.
6540 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6541 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6543 2011-05-18 Kenichi Handa <handa@m17n.org>
6545 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6546 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6547 (find_automatic_composition): Mostly rewrite for efficiency.
6549 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6551 * makefile.w32-in: Update dependencies.
6553 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6555 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6556 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6558 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6560 Fix some integer overflow issues, such as string length overflow.
6562 * insdel.c (count_size_as_multibyte): Check for string overflow.
6564 * character.c (lisp_string_width): Check for string overflow.
6565 Use EMACS_INT, not int, for string indexes and lengths; in
6566 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6567 the resulting string length overflows an EMACS_INT; instead,
6568 report a string overflow if no precision given. When checking for
6569 precision exhaustion, use a check that cannot possibly have
6570 integer overflow. (Bug#8675)
6571 * character.h (lisp_string_width): Adjust to new signature.
6573 * alloc.c (string_overflow): New function.
6574 (Fmake_string): Use it. This doesn't change behavior, but saves
6575 a few bytes and will simplify future changes.
6576 * character.c (string_escape_byte8): Likewise.
6577 * lisp.h (string_overflow): New decl.
6579 Fixups, following up to the user-interface timestamp change.
6580 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6581 for UI timestamps, instead of unsigned long.
6582 * msdos.c (mouse_get_pos): Likewise.
6583 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6584 * w32gui.h (Time): Define by including "systime.h" rather than by
6585 declaring it ourselves. (Bug#8664)
6587 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6588 * image.c (clear_image_cache): Likewise.
6590 * term.c (term_mouse_position): Don't assume time_t wraparound.
6592 Be more systematic about user-interface timestamps.
6593 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6594 and sometimes 'EMACS_UINT', to represent these timestamps.
6595 This change causes it to use 'Time' uniformly, as that's what X uses.
6596 This makes the code easier to follow, and makes it easier to catch
6597 integer overflow bugs such as Bug#8664.
6598 * frame.c (Fmouse_position, Fmouse_pixel_position):
6599 Use Time, not unsigned long, for user-interface timestamps.
6600 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6601 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6602 * keyboard.h (last_event_timestamp): Likewise.
6603 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6604 * menu.h (xmenu_show): Likewise.
6605 * term.c (term_mouse_position): Likewise.
6606 * termhooks.h (struct input_event.timestamp): Likewise.
6607 (struct terminal.mouse_position_hook): Likewise.
6608 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6609 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6610 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6611 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6613 * menu.h, termhooks.h: Include "systime.h", for Time.
6615 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6616 Don't assume that the difference between two unsigned long values
6617 can fit into an integer. At this point, we know button_down_time
6618 <= event->timestamp, so the difference must be nonnegative, so
6619 there's no need to cast the result if double-click-time is
6620 nonnegative, as it should be; check that it's nonnegative, just in
6621 case. This bug is triggered when events are more than 2**31 ms
6622 apart (about 25 days). (Bug#8664)
6624 * xselect.c (last_event_timestamp): Remove duplicate decl.
6625 (x_own_selection): Remove needless cast to unsigned long.
6627 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6628 that always fit in int. Use a sentinel instead of a counter, to
6629 avoid a temp and to allay GCC's concerns about possible int overflow.
6630 * frame.h (struct frame): Use int for menu_bar_items_used
6631 instead of EMACS_INT, since it always fits in int.
6633 * menu.c (grow_menu_items): Check for int overflow.
6635 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6637 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6638 Before, the code was not consistent. These values cannot exceed
6639 2**31 - 1 so there's no need to make them unsigned.
6640 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6641 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6642 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6644 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6646 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6647 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6648 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6649 presumably because the widths might not match.
6651 * window.c (size_window): Avoid needless test at loop start.
6653 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6655 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6657 2011-05-12 Drew Adams <drew.adams@oracle.com>
6659 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6661 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6663 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6664 `width' to `bar_area_x' and `bar_area_width', respectively.
6665 (x_scroll_run): Take account of fringe background extension.
6667 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6668 Rename local vars `left' and `width' to `bar_area_x' and
6669 `bar_area_width', respectively.
6670 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6671 background extension.
6673 2011-05-10 Jim Meyering <meyering@redhat.com>
6675 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6677 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6679 * image.c (Finit_image_library): Return t for built-in image types,
6680 like pbm and xbm. (Bug#8640)
6682 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6684 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6686 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6688 * w32console.c (Fset_screen_color): Doc fix.
6689 (Fget_screen_color): New function.
6690 (syms_of_ntterm): Defsubr it.
6692 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6693 unlink the temporary file if Fcall_process didn't create it in the
6695 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6696 child process will be redirected to a file specified with `:file'.
6697 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6698 cue to call_process_cleanup not to close that handle.
6700 2011-05-07 Ben Key <bkey76@gmail.com>
6702 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6703 one of two shell specific rules, either bootstrap-temacs-CMD or
6704 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6705 to the previous implementation of the bootstrap-temacs rule.
6706 The bootstrap-temacs-CMD rule is similar to the previous
6707 implementation of the bootstrap-temacs rule except that it
6708 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6711 These changes, along with some changes to nt/configure.bat,
6712 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6713 earlier fix to add support for --cflags and --ldflags options
6714 that include quotes so that it works whether make uses cmd or
6717 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6719 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6720 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6722 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6723 a string. Handle both cases.
6724 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6725 (Fdbus_register_method): Use Qinvalid_function.
6727 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6729 * makefile.w32-in: Update dependencies.
6730 (LISP_H): Add inttypes.h and stdin.h.
6731 (PROCESS_H): Add unistd.h.
6733 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6735 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6736 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6738 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6740 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6742 * term.c (vfatal): Remove stray call to va_end.
6743 It's not needed and the C Standard doesn't allow it here anyway.
6745 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6746 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6748 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6751 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6753 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6755 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6757 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6759 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6761 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6762 * charset.c (Fdefine_charset_internal): Don't initialize
6763 charset.code_space[15]. The value was garbage, on hosts with
6764 32-bit int (Bug#8600).
6766 * lread.c (read_integer): Be more consistent with string-to-number.
6767 Use string_to_number to do the actual conversion; this avoids
6768 rounding errors and fixes some other screwups. Without this fix,
6769 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6770 (digit_to_number): Move earlier, for benefit of read_integer.
6771 Return -1 if the digit is out of range for the base, -2 if it is
6772 not a digit in any supported base. (Bug#8602)
6774 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6776 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6777 to match comment at start of function. This also removes a
6778 GCC warning about overflow in a 32+64-bit port.
6780 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6782 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6783 Reported by Stefan Monnier in
6784 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6785 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6786 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6788 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6789 (EMACS_UINTPTR): Likewise, with uintptr_t.
6791 * lisp.h: Prefer 64-bit EMACS_INT if available.
6792 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6793 on 32-bit hosts that have 64-bit int, so that they can access
6795 However, temporarily disable this change unless the temporary
6796 symbol WIDE_EMACS_INT is defined.
6798 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6800 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6801 This removes an assumption that EMACS_INT and long are the same
6802 width as pointers. The assumption is true for Emacs porting targets
6803 now, but we want to make other targets possible.
6804 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6805 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6806 In the rest of the code, change types of integers that hold casted
6807 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6808 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6809 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6810 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6811 No need to cast type when ORing.
6812 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6813 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6814 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6815 assume EMACS_INT is the same width as char *.
6816 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6817 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6818 Remove no-longer-needed casts.
6819 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6820 (xg_tool_bar_help_callback, xg_make_tool_item):
6821 Use EMACS_INTPTR to hold an integer
6822 that will be cast to void *; this can avoid a GCC warning
6823 if EMACS_INT is not the same width as void *.
6824 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6825 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6826 (current_message_1, set_message_1):
6827 Use a local to convert to proper width without a cast.
6828 * xmenu.c (dialog_selection_callback): Likewise.
6830 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6831 Also, don't assume VALBITS / RAND_BITS is less than 5,
6832 and don't rely on undefined behavior when shifting a 1 left into
6834 * lisp.h (get_random): Change signature to match.
6836 * lread.c (hash_string): Use size_t, not int, for hash computation.
6837 Normally we prefer signed values; but hashing is special, because
6838 it's better to use unsigned division on hash table sizes so that
6839 the remainder is nonnegative. Also, size_t is the natural width
6840 for hashing into memory. The previous code used 'int', which doesn't
6841 retain enough info to hash well into very large tables.
6842 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6844 * dbusbind.c: Don't possibly lose pointer info when converting.
6845 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6846 Use XPNTR rather than XHASH, so that the high-order bits of
6847 the pointer aren't lost when converting through void *.
6849 * eval.c (Fautoload): Don't double-shift a pointer.
6851 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6853 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6855 * gnutls.c (DEF_GNUTLS_FN):
6856 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6858 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6860 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6863 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6865 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6866 New version that can reserve upto 2GB of heap space.
6868 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6870 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6872 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6874 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6875 `gnutls_certificate_set_x509_key_file'.
6877 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6879 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6880 Update dependencies.
6882 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6884 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6885 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6886 Remove unused parameter `fildes'.
6887 * process.c (read_process_output, send_process): Don't pass it.
6889 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6891 Fix previous change: the library cache is defined in w32.c.
6892 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6893 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6895 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6897 Implement dynamic loading of GnuTLS on Windows.
6899 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6900 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6901 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6904 * gnutls.c (Qgnutls_dll): Define.
6905 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6906 (gnutls_*): Declare function pointers.
6907 (init_gnutls_functions): New function to initialize function pointers.
6908 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6909 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6910 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6911 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6912 (emacs_gnutls_write, emacs_gnutls_read)
6913 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6914 (Fgnutls_available_p): New function.
6915 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6916 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6917 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6919 * image.c: Include w32.h.
6920 (Vimage_type_cache): Delete.
6921 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6922 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6923 (w32_delayed_load): Move to w32.c.
6925 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6927 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6928 (w32_delayed_load): Move from image.c. When loading a library, record
6929 its filename in the :loaded-from property of the library id.
6930 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6931 Initialize and staticpro them.
6932 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6934 * process.c: Include lisp.h before w32.h, not after.
6935 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6936 instead of gnutls_record_check_pending.
6938 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6940 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6942 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6943 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6946 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6948 * xterm.c (x_set_frame_alpha): Do not set property on anything
6949 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6951 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6953 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6955 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6957 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6958 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6959 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6960 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6961 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6962 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6963 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6964 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6965 (Qgnutls_bootprop_callbacks_verify): Make static.
6967 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6969 * callproc.c: Indentation fixup.
6971 * sysdep.c (wait_for_termination_1): Make static.
6972 (wait_for_termination, interruptible_wait_for_termination):
6973 Move after wait_for_termination_1.
6975 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6977 * sysdep.c (interruptible_wait_for_termination): New function
6978 which is like wait_for_termination, but allows keyboard
6981 * callproc.c (Fcall_process): Add (:file "file") as an option for
6983 (Fcall_process_region): Ditto.
6985 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6987 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6988 rather than `XVECTOR (FOO)->size'.
6990 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6991 inttypes.h, as a gnulib replacement is used if it not available in
6994 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6996 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6997 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6998 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7000 * coding.c (coding_alloc_by_realloc): Error out if destination
7001 will grow beyond MOST_POSITIVE_FIXNUM.
7002 (decode_coding_emacs_mule): Abort if there isn't enough place in
7003 charbuf for the composition carryover bytes. Reserve an extra
7004 space for up to 2 characters produced in a loop.
7005 (decode_coding_iso_2022): Abort if there isn't enough place in
7006 charbuf for the composition carryover bytes.
7008 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7010 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7011 aborting when %lld or %lll format is passed.
7012 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7013 %llo or %llx format is passed. (Bug#8545)
7015 * window.c (window_scroll_line_based): Use a marker instead of
7016 simple variables to record original value of point. (Bug#7952)
7018 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7019 produced by %s or %c overflows available buffer space. (Bug#8545)
7021 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7023 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7024 (SIZE_MAX): Move defn after all includes, as they might #define it.
7026 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7028 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7030 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7032 * keyboard.c (Qdelayed_warnings_hook): Define.
7033 (command_loop_1): Run `delayed-warnings-hook'
7034 if Vdelayed_warnings_list is non-nil.
7035 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7036 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7038 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7040 * doprnt.c (doprnt): Don't return value smaller than the buffer
7041 size if the message was truncated. (Bug#8545).
7043 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7045 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7046 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7048 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7050 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7052 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7054 * makefile.w32-in: Update dependencies.
7056 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7058 Improve `doprnt' and its usage. (Bug#8545)
7059 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7060 `format_end'. Remove support for %l as a conversion specifier.
7061 Don't use xrealloc. Improve diagnostics when the %l size modifier
7062 is used. Update the commentary.
7064 * eval.c (verror): Simplify calculation of size_t.
7066 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7069 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7071 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7074 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7076 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7077 This makes this file independent of the recent pseudovector change.
7079 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7081 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7083 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7084 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7085 Remove unused local.
7086 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7088 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7089 GCC 4.6.0 optimizes based on type-based alias analysis.
7090 For example, if b is of type struct buffer * and v of type struct
7091 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7092 != &v->size, and therefore "v->size = 1; b->size = 2; return
7093 v->size;" must therefore return 1. This assumption is incorrect
7094 for Emacs, since it type-puns struct Lisp_Vector * with many other
7095 types. To fix this problem, this patch adds a new type struct
7096 vectorlike_header that documents the constraints on layout of vectors
7097 and pseudovectors, and helps optimizing compilers not get fooled
7098 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7099 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7100 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7102 (XSETPVECTYPE): Rewrite in terms of new macro.
7103 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7104 This is a bit clearer, and further avoids the possibility of
7105 undesirable aliasing.
7106 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7107 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7108 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7109 since Lisp_Subr is a special case (no "next" field).
7110 (ASIZE): Now uses header.size rather than size.
7111 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7112 to avoid the hassle of writing XVECTOR (foo)->header.size.
7113 (struct vectorlike_header): New type.
7114 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7115 object, to help avoid aliasing.
7116 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7117 (SUBRP): Likewise, since Lisp_Subr is a special case.
7118 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7119 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7120 (struct Lisp_Hash_Table): Combine first two members into a single
7121 struct vectorlike_header member. All uses of "size" and "next" members
7122 changed to be "header.size" and "header.next".
7123 * buffer.h (struct buffer): Likewise.
7124 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7125 * frame.h (struct frame): Likewise.
7126 * process.h (struct Lisp_Process): Likewise.
7127 * termhooks.h (struct terminal): Likewise.
7128 * window.c (struct save_window_data, struct saved_window): Likewise.
7129 * window.h (struct window): Likewise.
7130 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7131 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7132 * buffer.c (init_buffer_once): Likewise.
7133 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7135 * process.c (Fformat_network_address): Use local var for size,
7138 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7140 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7141 * data.c (atof): Remove decl; no longer used or needed.
7142 (digit_to_number): Move to lread.c.
7143 (Fstring_to_number): Use new string_to_number function, to be
7144 consistent with how the Lisp reader treats infinities and NaNs.
7145 Do not assume that floating-point numbers represent EMACS_INT
7146 without losing information; this is not true on most 64-bit hosts.
7147 Avoid double-rounding errors, by insisting on integers when
7148 parsing non-base-10 numbers, as the documentation specifies.
7149 * lisp.h (string_to_number): New decl, replacing ...
7150 (isfloat_string): Remove.
7151 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7152 (read1): Do not accept +. and -. as integers; this
7153 appears to have been a coding error. Similarly, do not accept
7154 strings like +-1e0 as floating point numbers. Do not report
7155 overflow for integer overflows unless the base is not 10 which
7156 means we have no simple and reliable way to continue.
7157 Break out the floating-point parsing into a new
7158 function string_to_number, so that Fstring_to_number parses
7159 floating point numbers consistently with the Lisp reader.
7160 (digit_to_number): Move here from data.c. Make it static inline.
7161 (E_CHAR, EXP_INT): Remove, replacing with ...
7162 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7163 (string_to_number): New function, replacing isfloat_string.
7164 This function checks for valid syntax and produces the resulting
7165 Lisp float number too. Rework it so that string-to-number
7166 no longer mishandles examples like "1.0e+". Use strtoumax,
7167 so that overflow for non-base-10 numbers is reported only when
7168 there's no portable and simple way to convert to floating point.
7170 * textprop.c (set_text_properties_1): Rewrite for clarity,
7171 and to avoid GCC warning about integer overflow.
7173 * intervals.h (struct interval): Use EMACS_INT for members
7174 where EMACS_UINT might cause problems. See
7175 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7176 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7177 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7179 (offset_intervals): Tell GCC not to worry about length overflow
7180 when negating a negative length.
7182 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7183 (overrun_check_free): Likewise.
7185 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7186 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7189 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7190 (gnutls_make_error): Rename local to avoid shadowing.
7191 (gnutls_emacs_global_deinit): ifdef out; not used.
7192 (Fgnutls_boot): Use const for pointer to readonly storage.
7193 Comment out unused local. Fix pointer signedness problems.
7195 * lread.c (openp): Don't stuff size_t into an 'int'.
7196 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7197 about possible signed overflow.
7199 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7200 (GDK_KEY_g): Don't define if already defined.
7201 (xg_prepare_tooltip): Avoid pointer signedness problem.
7202 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7204 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7205 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7207 * xfns.c (Fx_window_property): Simplify a bit,
7208 to make a bit faster and to avoid GCC 4.6.0 warning.
7209 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7211 * fns.c (internal_equal): Don't assume size_t fits in int.
7213 * alloc.c (compact_small_strings): Tighten assertion a little.
7215 Replace pEd with more-general pI, and fix some printf arg casts.
7216 * lisp.h (pI): New macro, generalizing old pEd macro to other
7217 conversion specifiers. For example, use "...%"pI"d..." rather
7218 than "...%"pEd"...".
7219 (pEd): Remove. All uses replaced with similar uses of pI.
7220 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7221 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7222 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7223 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7224 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7225 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7226 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7228 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7229 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7230 * print.c (safe_debug_print, print_object): Likewise.
7231 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7233 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7234 avoiding the 0 flag, which is not portable.
7235 * process.c (Fmake_network_process): Use pI to avoid cast.
7236 * region-cache.c (pp_cache): Likewise.
7237 * xdisp.c (decode_mode_spec): Likewise.
7238 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7239 behavior on 64-bit hosts with printf arg.
7240 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7241 (x_stop_queuing_selection_requests): Likewise.
7242 (x_get_window_property): Don't truncate byte count to an 'int'
7245 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7246 here, since it parses constructs like leading '-' and spaces,
7247 which are not wanted; and it overflows with large numbers.
7248 Instead, simply match F[0-9]+, which is what is wanted anyway.
7250 * alloc.c: Remove unportable assumptions about struct layout.
7251 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7252 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7253 (allocate_vectorlike, make_pure_vector): Use the new macros,
7254 plus offsetof, to remove unportable assumptions about struct layout.
7255 These assumptions hold on all porting targets that I know of, but
7256 they are not guaranteed, they're easy to remove, and removing them
7257 makes further changes easier.
7259 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7260 This doesn't fix a bug but makes the code clearer.
7261 (string_overrun_cookie): Now const. Use initializers that
7262 don't formally overflow signed char, to avoid warnings.
7263 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7264 can cause Emacs to crash when string overrun checking is enabled.
7265 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7266 multiple of sizeof (EMACS_INT); it need not be, if
7267 alignof(EMACS_INT) < sizeof (EMACS_INT).
7268 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7270 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7272 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7274 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7276 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7277 supposed to be handshaking. (Bug#8556)
7278 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7280 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7282 * lisp.h (Qdebug): List symbol.
7283 * eval.c (Qdebug): Restore global linkage.
7284 * keyboard.c (debug-on-event): New variable.
7285 (handle_user_signal): Break into debugger when debug-on-event
7286 matches the current signal symbol.
7288 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7290 * alloc.c (check_sblock, check_string_bytes)
7291 (check_string_free_list): Convert to standard C.
7293 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7295 * w32.c (emacs_gnutls_push): Fix typo.
7297 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7299 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7300 "cast to pointer from integer of different size".
7302 Improve doprnt and its use in verror. (Bug#8545)
7303 * doprnt.c (doprnt): Document the set of format control sequences
7304 supported by the function. Use SAFE_ALLOCA instead of always
7307 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7308 is one byte too soon. Don't use xrealloc; instead xfree and
7311 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7313 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7316 * gnutls.c: Renamed global_initialized to
7317 gnutls_global_initialized. Added internals for the
7318 :verify-hostname-error, :verify-error, and :verify-flags
7319 parameters of `gnutls-boot' and documented those parameters in the
7320 docstring. Start callback support.
7321 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7322 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7323 on error. Return error code.
7324 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7325 (emacs_gnutls_read): Likewise.
7326 (Fgnutls_boot): Return handshake error code.
7327 (emacs_gnutls_handle_error): New function.
7328 (wsaerror_to_errno): Likewise.
7330 * w32.h (emacs_gnutls_pull): Add prototype.
7331 (emacs_gnutls_push): Likewise.
7333 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7334 (emacs_gnutls_push): Likewise.
7336 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7338 * process.c (wait_reading_process_output): Check if GnuTLS
7339 buffered some data internally if no FDs are set for TLS
7342 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7343 (LIBS): Link to USER_LIBS.
7344 ($(BLD)/gnutls.$(0)): New target.
7346 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7348 * xdisp.c (handle_single_display_spec): Rename the
7349 display_replaced_before_p argument into display_replaced_p, to
7350 make it consistent with the commentary. Fix typos in the
7353 * textprop.c (syms_of_textprop): Remove dead code.
7354 (copy_text_properties): Delete obsolete commentary about an
7355 interface that was deleted long ago. Fix typos in the description
7358 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7359 to changes in oldXMenu/XMenu.h from 2011-04-16.
7360 <menu_help_message, prev_menu_help_message>: Constify.
7361 (IT_menu_make_room): menu->help_text is now `const char **';
7364 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7365 to changes in oldXMenu/XMenu.h from 2011-04-16.
7366 (struct XMenu): Declare `help_text' `const char **'.
7368 * xfaces.c <Qunspecified>: Make extern again.
7370 * syntax.c: Include sys/types.h before including regex.h, as
7373 * doc.c (get_doc_string): Improve the format passed to `error'.
7375 * doprnt.c (doprnt): Improve commentary.
7377 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7379 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7382 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7383 changes in globals.h immediately force recompilation.
7384 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7385 $(CURDIR)/s/ms-w32.h.
7386 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7388 * character.c (Fchar_direction): Function deleted.
7389 (syms_of_character): Don't defsubr it.
7390 <char-direction-table>: Deleted.
7392 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7394 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7395 * doprnt.c: Include limits.h.
7396 (SIZE_MAX): New macro.
7397 (doprnt): Return a size_t value. 2nd arg is now size_t.
7398 Many local variables are now size_t instead of int or unsigned.
7399 Improve overflow protection. Support `l' modifier for integer
7400 conversions. Support %l conversion. Don't assume an EMACS_INT
7401 argument for integer conversions and for %c.
7403 * lisp.h (doprnt): Restore prototype.
7405 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7408 * Makefile.in (base_obj): Add back doprnt.o.
7410 * deps.mk (doprnt.o): Add back prerequisites.
7411 (callint.o): Depend on character.h.
7413 * eval.c (internal_lisp_condition_case): Include the handler
7414 representation in the error message.
7415 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7416 when breaking from the loop.
7418 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7420 * callint.c (Fcall_interactively): When displaying error message
7421 about invalid control letter, pass the character's codepoint, not
7422 a pointer to its multibyte form. Improve display of the character
7423 in octal and display also its hex code.
7425 * character.c (char_string): Use %x to display the (unsigned)
7426 codepoint of an invalid character, to avoid displaying a bogus
7429 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7430 `error', not SYMBOL_NAME itself.
7432 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7433 character arguments to `error'.
7435 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7436 to `error' in error message about FINAL_CHAR argument. Make sure
7437 FINAL_CHAR is a character, and use %c when it is passed as
7438 argument to `error'.
7440 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7442 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7444 * w32.c: Include <time.h>.
7445 (sys_localtime): New function.
7447 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7449 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7451 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7453 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7455 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7458 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7460 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7461 gl_state.e_property when gl_state.object is Qt.
7463 * insdel.c (make_gap_larger): Remove limitation of buffer size
7466 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7468 * xdisp.c (lookup_glyphless_char_display)
7469 (produce_glyphless_glyph): Handle cons cell entry in
7470 glyphless-char-display.
7471 (Vglyphless_char_display): Document it.
7473 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7474 glyphless-char-display.
7476 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7478 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7480 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7482 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7483 definition for no-X builds.
7485 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7487 Static checks with GCC 4.6.0 and non-default toolkits.
7489 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7491 * process.c (keyboard_bit_set): Define only if SIGIO.
7492 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7493 (send_process): Repair possible setjmp clobbering.
7495 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7497 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7499 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7501 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7502 Define only if needed.
7504 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7505 by pacifying GCC about it. Maybe it's time to retire it?
7506 * xfaces.c (USG, __TIMEVAL__): Likewise.
7508 * dispextern.h (struct redisplay_interface): Rename param
7510 * termhooks.h (struct terminal): Likewise.
7511 * xterm.c (xembed_send_message): Likewise.
7513 * insdel.c (make_gap_smaller): Define only if
7514 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7516 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7519 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7520 so that we aren't warned about unused symbols.
7522 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7524 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7526 * xfns.c (x_real_positions): Mark locals as initialized.
7528 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7530 * xterm.c: Fix problems found by static analysis with other toolkits.
7531 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7532 (x_dispatch_event): Declare static if USE_GTK, and
7533 define if USE_GTK || USE_X_TOOLKIT.
7534 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7535 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7536 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7537 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7539 * xmenu.c (menu_help_callback): Pointer type fixes.
7540 Use const pointers when pointing at readonly data. Avoid pointer
7542 (FALSE): Remove unused macro.
7543 (update_frame_menubar): Remove unused decl.
7545 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7547 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7548 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7549 (single_menu_item): Rename local to avoid shadowing.
7551 * keyboard.c (make_lispy_event): Remove unused local var.
7553 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7554 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7556 * bitmaps: Change bitmaps from unsigned char back to the X11
7557 compatible char. Avoid the old compiler warnings about
7558 out-of-range initializers by using, for example, '\xab' rather
7561 * xgselect.c (xgselect_initialize): Check vs interface
7562 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7564 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7566 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7567 to read-only memory.
7569 * fns.c (vector): Remove; this old hack is no longer needed.
7571 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7573 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7575 * xrdb.c (x_load_resources): Omit unused local.
7577 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7578 (x_window): Rename locals to avoid shadowing.
7579 (USG): Use the kludged USG macro, to pacify gcc.
7581 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7582 (x_term_init): Remove local to avoid shadowing.
7584 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7586 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7587 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7589 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7591 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7593 Fix regex.c, syntax.c and friends for buffers > 2GB.
7594 * syntax.h (struct gl_state_s): Declare character position members
7597 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7599 * textprop.c (verify_interval_modification, interval_of):
7600 Declare arguments EMACS_INT.
7602 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7605 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7607 * indent.c (Fvertical_motion): Local variable it_start is now
7610 * regex.c (re_match, re_match_2, re_match_2_internal)
7611 (bcmp_translate, regcomp, regexec, print_double_string)
7612 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7613 (re_compile_pattern, re_exec): Declare arguments and local
7614 variables `size_t' and `ssize_t' and return values `regoff_t', as
7616 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7617 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7618 <compile_stack_type>: `size' and `avail' are now `size_t'.
7620 * regex.h <regoff_t>: Use ssize_t, not int.
7621 (re_search, re_search_2, re_match, re_match_2): Arguments that
7622 specify buffer/string position and length are now ssize_t and
7623 size_t. Return type is regoff_t.
7625 2011-04-16 Ben Key <bkey76@gmail.com>
7627 * nsfont.m: Fixed bugs in ns_get_family and
7628 ns_descriptor_to_entity that were caused by using free to
7629 deallocate memory blocks that were allocated by xmalloc (via
7630 xstrdup). This caused Emacs to crash when compiled with
7631 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7632 --enable-checking=xmallocoverrun). xfree is now used to
7633 deallocate these memory blocks.
7635 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7637 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7639 emacs_write: Accept and return EMACS_INT for sizes.
7640 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7642 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7643 Accept and return EMACS_INT.
7644 (emacs_gnutls_write): Return the number of bytes written on
7646 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7647 (emacs_read, emacs_write): Remove check for negative size, as the
7648 Emacs source code has been audited now.
7649 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7650 (emacs_read, emacs_write): Use it.
7651 * process.c (send_process): Adjust to the new signatures of
7652 emacs_write and emacs_gnutls_write. Do not attempt to store
7653 a byte offset into an 'int'; it might overflow.
7654 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7656 * sound.c: Don't assume sizes fit in 'int'.
7657 (struct sound_device.period_size, alsa_period_size):
7658 Return EMACS_INT, not int.
7659 (struct sound_device.write, vox_write, alsa_write):
7660 Accept EMACS_INT, not int.
7661 (wav_play, au_play): Use EMACS_INT to store sizes and to
7662 record read return values.
7664 2011-04-15 Ben Key <bkey76@gmail.com>
7666 * keyboard.c (Qundefined): Don't declare static since it is used
7668 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7669 static since they are used in nsfont.m.
7671 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7673 * process.c (Qprocessp): Don't declare static.
7674 * lisp.h (Qprocessp): Declare again.
7676 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7678 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7680 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7682 Improve C-level modularity by making more things 'static'.
7684 Don't publish debugger-only interfaces to other modules.
7685 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7686 (verify_bytepos, count_markers): Move decls to the only modules
7688 * region-cache.h (pp_cache): Likewise.
7689 * window.h (check_all_windows): Likewise.
7690 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7692 * sysdep.c (croak): Now static, if
7693 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7694 * syssignal.h (croak): Declare only if not static.
7696 * alloc.c (refill_memory_reserve): Now static if
7697 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7698 * lisp.h (refill_memory_reserve): Declare only if not static.
7700 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7701 Define only if USE_LUCID.
7703 * xrdb.c (x_customization_string, x_rm_string): Now static.
7705 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7706 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7708 * xdisp.c (draw_row_with_mouse_face): Now static.
7709 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7711 * window.h (check_all_windows): Mark externally visible.
7713 * window.c (window_deletion_count): Now static.
7715 * undo.c: Make symbols static if they're not exported.
7716 (last_undo_buffer, last_boundary_position, pending_boundary):
7719 * textprop.c (interval_insert_behind_hooks): Now static.
7720 (interval_insert_in_front_hooks): Likewise.
7722 * term.c: Make symbols static if they're not exported.
7723 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7724 (max_frame_lines, tty_set_terminal_modes):
7725 (tty_reset_terminal_modes, tty_turn_off_highlight):
7726 (get_tty_terminal): Now static.
7727 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7728 * termhooks.h (term_mouse_moveto): Do not declare if
7730 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7731 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7733 * sysdep.c: Make symbols static if they're not exported.
7734 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7736 (sigprocmask_set, full_mask): Remove; unused.
7737 (wait_debugging): Mark as visible.
7738 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7739 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7741 * syntax.c (syntax_temp): Define only if !__GNUC__.
7743 * sound.c (current_sound_device, current_sound): Now static.
7745 * search.c (searchbufs, searchbuf_head): Now static.
7747 * scroll.c (scroll_cost): Remove; unused.
7748 * dispextern.h (scroll_cost): Remove decl.
7750 * region-cache.h (pp_cache): Mark as externally visible.
7752 * process.c: Make symbols static if they're not exported.
7753 (process_tick, update_tick, create_process, chan_process):
7754 (Vprocess_alist, proc_buffered_char, datagram_access):
7755 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7756 (deactivate_process): Mark defn as static, as well as decl.
7757 * lisp.h (create_process): Remove decl.
7758 * process.h (chan_process, Vprocess_alist): Remove decls.
7760 * print.c: Make symbols static if they're not exported.
7761 (print_depth, new_backquote_output, being_printed, print_buffer):
7762 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7763 (print_interval, print_number_index, initial_stderr_stream):
7765 * lisp.h (Fprinc): Remove decl.
7766 (debug_output_compilation_hack): Mark as externally visible.
7768 * sysdep.c (croak): Move decl from here to syssignal.h.
7769 * syssignal.h (croak): Put it here, so the API can be checked when
7770 'croak' is called from dissociate_if_controlling_tty.
7772 * minibuf.c: Make symbols static if they're not exported.
7773 (minibuf_save_list, choose_minibuf_frame): Now static.
7774 * lisp.h (choose_minibuf_frame): Remove decl.
7776 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7778 * lread.c: Make symbols static if they're not exported.
7779 (read_objects, initial_obarray, oblookup_last_bucket_number):
7781 (make_symbol): Remove; unused.
7782 * lisp.h (initial_obarray, make_symbol): Remove decls.
7784 * keyboard.c: Make symbols static if they're not exported.
7785 (single_kboard, recent_keys_index, total_keys, recent_keys):
7786 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7787 (this_single_command_key_start, echoing, last_auto_save):
7788 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7789 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7790 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7791 (Vlispy_mouse_stem, double_click_count):
7793 (force_auto_save_soon): Define only if SIGDANGER.
7794 (ignore_mouse_drag_p): Now static if
7795 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7796 (print_help): Remove; unused.
7797 (stop_character, last_timer_event): Mark as externally visible.
7798 * keyboard.h (ignore_mouse_drag_p): Declare only if
7799 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7800 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7801 * lisp.h (echoing): Remove decl.
7802 (force_auto_save_soon): Declare only if SIGDANGER.
7803 * xdisp.c (redisplay_window): Simplify code, to make it more
7804 obvious that ignore_mouse_drag_p is not accessed if !defined
7805 USE_GTK && !defined HAVE_NS.
7807 * intervals.c: Make symbols static if they're not exported.
7808 (merge_properties_sticky, merge_interval_right, delete_interval):
7810 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7812 * insdel.c: Make symbols static if they're not exported.
7813 However, leave prepare_to_modify_buffer alone. It's never
7814 called from outside this function, but that appears to be a bug.
7815 (combine_after_change_list, combine_after_change_buffer):
7816 (adjust_after_replace, signal_before_change): Now static.
7817 (adjust_after_replace_noundo): Remove; unused.
7818 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7819 (signal_before_change): Remove decls.
7821 * indent.c (val_compute_motion, val_vmotion): Now static.
7823 * image.c: Make symbols static if they're not exported.
7824 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7826 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7827 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7829 * fringe.c (standard_bitmaps): Now static.
7830 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7832 * frame.c: Make symbols static if they're not exported.
7833 (x_report_frame_params, make_terminal_frame): Now static.
7834 (get_frame_param): Now static, unless HAVE_NS.
7835 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7836 (x_get_resource_string): Remove; not used.
7837 * frame.h (make_terminal_frame, x_report_frame_params):
7838 (x_get_resource_string); Remove decls.
7839 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7840 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7842 * font.c, fontset.c: Make symbols static if they're not exported.
7843 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7844 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7845 * font.c (font_close_object): Now static.
7846 * font.h (font_close_object): Remove.
7847 * fontset.c (FONTSET_OBJLIST): Remove.
7848 (free_realized_fontset) #if-0 the body, which does nothing.
7849 (face_suitable_for_char_p): #if-0, as it's never called.
7850 * fontset.h (face_suitable_for_char_p): Remove decl.
7851 * xfaces.c (face_at_string_position):
7852 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7853 since 0 is always ASCII.
7855 * fns.c (weak_hash_tables): Now static.
7857 * fileio.c: Make symbols static if they're not exported.
7858 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7859 (Vwrite_region_annotation_buffers): Now static.
7861 * eval.c: Make symbols static if they're not exported.
7862 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7863 * lisp.h (backtrace_list): Remove decl.
7865 * emacs.c: Make symbols static if they're not exported.
7866 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7867 (fatal_error_code, fatal_error_signal_hook, standard_args):
7869 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7870 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7871 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7872 * lisp.h (fatal_error_signal_hook): Remove decl.
7873 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7875 * editfns.c: Move a (normally-unused) function to its only use.
7876 * editfns.c, lisp.h (get_operating_system_release): Remove.
7877 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7878 worth the hassle of breaking this out.
7880 * xterm.c: Make symbols static if they're not exported.
7881 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7882 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7883 (x_destroy_window, x_delete_display):
7885 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7886 (x_mouse_leave): Remove; unused.
7887 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7888 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7889 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7891 (x_mouse_leave): Declare only if WINDOWSNT.
7892 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7893 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7896 * ftxfont.c: Make symbols static if they're not exported.
7897 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7899 * font.h (ftxfont_driver): Likewise.
7901 * xfns.c: Make symbols static if they're not exported.
7902 (x_last_font_name, x_display_info_for_name):
7903 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7904 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7905 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7906 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7907 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7908 (last_show_tip_args): Now static.
7909 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7910 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7911 (x_screen_planes): Remove; unused.
7912 * dispextern.h (x_screen_planes): Remove decl.
7914 * dispnew.c: Make symbols static if they're not exported.
7915 * dispextern.h (redraw_garbaged_frames, scrolling):
7916 (increment_row_positions): Remove.
7917 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7918 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7920 (redraw_garbaged_frames): Remove; unused.
7922 * xfaces.c: Make symbols static if they're not exported.
7923 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7925 * xterm.h (defined_color): Remove decls.
7926 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7927 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7928 (menu_face_changed_default, defined_color, free_realized_face):
7929 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7930 (ascii_face_of_lisp_face): Remove; unused.
7932 * xdisp.c: Make symbols static if they're not exported.
7933 * dispextern.h (scratch_glyph_row, window_box_edges):
7934 (glyph_to_pixel_coords, set_cursor_from_row):
7935 (get_next_display_element, set_iterator_to_next):
7936 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7937 (show_mouse_face): Remove decls
7938 * frame.h (message_buf_print): Likewise.
7939 * lisp.h (pop_message, set_message, check_point_in_composition):
7941 * xterm.h (set_vertical_scroll_bar): Likewise.
7942 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7943 (message_buf_print, scratch_glyph_row, displayed_buffer):
7944 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7945 (get_next_display_element, show_mouse_face, window_box_edges):
7946 (frame_to_window_pixel_xy, check_point_in_composition):
7947 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7948 (glyph_to_pixel_coords): Remove; unused.
7950 * dired.c (file_name_completion): Now static.
7952 * dbusbind.c (xd_in_read_queued_messages): Now static.
7954 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7955 * data.c (circular_list_error): Remove.
7957 * commands.h (last_point_position, last_point_position_buffer):
7958 (last_point_position_window): Remove decls.
7959 * keyboard.c: Make these variables static.
7961 * coding.h (coding, code_convert_region, encode_coding_gap):
7963 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7964 (iso_code_class, detect_coding, code_convert_region): Now static.
7965 (encode_coding_gap): Remove; unused.
7967 * chartab.c (chartab_chars, chartab_bits): Now static.
7969 * charset.h (charset_iso_8859_1): Remove decl.
7970 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7973 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7974 * ccl.c (Vccl_program_table): Now static.
7975 (check_ccl_update): Remove; unused.
7977 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7978 * category.h: ... from here.
7979 * category.c (check_category_table, set_category_set): Now static.
7981 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7982 * lisp.h: Remove these decls.
7984 * buffer.c (buffer_count): Remove unused var.
7986 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7987 so that it's not optimized away.
7988 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7989 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7990 exported only to the debugger.
7992 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7993 * atimer.h (run_all_atimers): Remove; not exported.
7995 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7996 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7997 was inaccessible from Lisp.
7998 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7999 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8001 alloc.c: Import and export fewer symbols, and remove unused items.
8002 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8004 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8005 it's not optimized away by whole-program optimization.
8006 (message_enable_multibyte, free_misc): Remove.
8007 (catchlist, handlerlist, mark_backtrace):
8008 Declare only if BYTE_MARK_STACK.
8009 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8010 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8011 (message_enable_multibyte): Remove decl.
8012 (free_misc, interval_free_list, float_block, float_block_index):
8013 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8014 (cons_free_list, last_marked_index):
8016 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8017 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8018 (mark_backtrace): Define only if BYTE_MARK_STACK.
8019 * xdisp.c (message_enable_multibyte): Now static.
8021 Declare Lisp_Object Q* variables to be 'static' if not exported.
8022 This makes it easier for human readers (and static analyzers)
8023 to see whether these variables are used from other modules.
8024 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8025 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8026 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8027 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8028 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8029 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8030 * xmenu.c, xselect.c:
8031 Declare Q* vars static if they are not used in other modules.
8032 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8033 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8034 Remove decls of unexported vars.
8035 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8037 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8039 Make Emacs functions such as Fatom 'static' by default.
8040 This makes it easier for human readers (and static analyzers)
8041 to see whether these functions can be called from other modules.
8042 DEFUN now defines a static function. To make the function external
8043 so that it can be used in other C modules, use the new macro DEFUE.
8044 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8045 (Finit_image_library):
8046 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8047 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8048 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8049 Remove decls, since these functions are now static.
8050 (Funintern, Fget_internal_run_time): New decls, since these functions
8051 were already external.
8053 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8054 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8055 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8056 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8057 * keyboard.c, keymap.c, lread.c:
8058 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8059 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8060 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8061 Mark functions with DEFUE instead of DEFUN,
8062 if they are used in other modules.
8063 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8064 decls for now-static functions.
8065 * buffer.h (Fdelete_overlay): Remove decl.
8066 * callproc.c (Fgetenv_internal): Mark as internal.
8067 * composite.c (Fremove_list_of_text_properties): Remove decl.
8068 (Fcomposition_get_gstring): New forward static decl.
8069 * composite.h (Fcomposite_get_gstring): Remove decl.
8070 * dired.c (Ffile_attributes): New forward static decl.
8071 * doc.c (Fdocumntation_property): New forward static decl.
8072 * eval.c (Ffetch_bytecode): New forward static decl.
8073 (Funintern): Remove extern decl; now in .h file where it belongs.
8074 * fileio.c (Fmake_symbolic_link): New forward static decl.
8075 * image.c (Finit_image_library): New forward static decl.
8076 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8077 * intervals.h (Fprevious_property_change):
8078 (Fremove_list_of_text_properties): Remove decls.
8079 * keyboard.c (Fthis_command_keys): Remove decl.
8080 (Fcommand_execute): New forward static decl.
8081 * keymap.c (Flookup_key): New forward static decl.
8082 (Fcopy_keymap): Now static.
8083 * keymap.h (Flookup_key): Remove decl.
8084 * process.c (Fget_process): New forward static decl.
8085 (Fprocess_datagram_address): Mark as internal.
8086 * syntax.c (Fsyntax_table_p): New forward static decl.
8087 (skip_chars): Remove duplicate decl.
8088 * textprop.c (Fprevious_property_change): New forward static decl.
8089 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8091 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8092 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8094 * editfns.c (Fformat): Remove unreachable code.
8096 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8098 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8101 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8103 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8104 when at ZV. (Bug#8487)
8106 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8108 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8110 * keyboard.c (parse_tool_bar_item): Likewise.
8111 * sound.c (sound_cleanup, alsa_close): Likewise.
8112 * termcap.c (tgetent): Likewise.
8113 * xfns.c (x_default_font_parameter): Likewise.
8114 * xsettings.c (read_and_apply_settings): Likewise.
8116 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8117 (overrun_check_free): Protoize.
8119 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8121 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8122 since callers should never pass a negative size.
8123 Change the signature to match that of plain 'read' and 'write'; see
8124 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8125 * lisp.h: Update prototypes of emacs_write and emacs_read.
8127 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8129 * xdisp.c (redisplay_window): Don't try to determine the character
8130 position of the scroll margin if the window start point w->startp
8131 is outside the buffer's accessible region. (Bug#8468)
8133 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8135 Fix write-region and its subroutines for buffers > 2GB.
8136 * fileio.c (a_write, e_write): Modify declaration of arguments and
8137 local variables to support buffers larger than 2GB.
8138 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8140 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8141 argument, local variables, and return value.
8143 * lisp.h: Update prototypes of emacs_write and emacs_read.
8145 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8147 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8149 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8151 Fix more problems found by GCC 4.6.0's static checks.
8153 * xdisp.c (vmessage): Use a better test for character truncation.
8155 * charset.c (load_charset_map): <, not <=, for optimization,
8156 and to avoid potential problems with integer overflow.
8157 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8158 * casetab.c (set_identity, shuffle): Likewise.
8159 * editfns.c (Fformat): Likewise.
8160 * syntax.c (skip_chars): Likewise.
8162 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8163 This also lets GCC 4.6.0 generate slightly better loop code.
8165 * callint.c (Fcall_interactively): <, not <=, for optimization.
8166 (Fcall_interactively): Count the number of arguments produced,
8167 not the number of arguments given. This is simpler and lets GCC
8168 4.6.0 generate slightly better code.
8170 * ftfont.c: Distingish more carefully between FcChar8 and char.
8171 The previous code passed unsigned char * to a functions like
8172 strlen and xstrcasecmp that expect char *, which does not
8173 conform to the C standard.
8174 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8175 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8176 char * when the C standard requires it.
8178 * keyboard.c (read_char): Remove unused var.
8180 * eval.c: Port to Windows vsnprintf (Bug#8435).
8182 (SIZE_MAX): Define if the headers do not.
8183 (verror): Do not give up if vsnprintf returns a negative count.
8184 Instead, grow the buffer. This ports to Windows vsnprintf, which
8185 does not conform to C99. Problem reported by Eli Zaretskii.
8186 Also, simplify the allocation scheme, by avoiding the need for
8187 calling realloc, and removing the ALLOCATED variable.
8189 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8191 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8192 But keep the doprint source code for now, as we might revamp it
8193 and use it again (Bug#8435).
8194 * lisp.h (doprnt): Remove.
8195 * Makefile.in (base_obj): Remove doprnt.o.
8196 * deps.mk (doprnt.o): Remove.
8198 error: Print 32- and 64-bit integers portably (Bug#8435).
8199 Without this change, on typical 64-bit hosts error ("...%d...", N)
8200 was used to print both 32- and 64-bit integers N, which relied on
8202 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8203 * lisp.h (error, verror): Mark as printf-like functions.
8204 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8205 Report overflow in size calculations when allocating printf buffer.
8206 Do not truncate output string at its first null byte.
8207 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8208 Truncate the output at a character boundary, since vsnprintf does not
8210 * charset.c (check_iso_charset_parameter): Convert internal
8211 character to string before calling 'error', since %c now has the
8213 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8214 overflow when computing char to be passed to 'error'. Do not
8215 pass Lisp_Object to 'error'; pass the integer instead.
8216 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8217 formatted with plain %d.
8219 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8221 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8223 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8225 * xterm.c (x_catch_errors): Remove duplicate declaration.
8227 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8229 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8231 2011-04-10 Jim Meyering <meyering@redhat.com>
8233 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8234 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8235 return ssize_t not "int", and use size_t as the buffer length.
8236 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8237 * gnutls.h: Update declarations.
8238 * process.c (read_process_output): Use ssize_t, to match.
8239 (send_process): Likewise.
8241 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8243 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8245 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8247 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8248 Use unsigned char, to match FcChar8 type definition.
8250 * xterm.c (handle_one_xevent):
8251 * xmenu.c (create_and_show_popup_menu):
8252 * xselect.c (x_decline_selection_request)
8253 (x_reply_selection_request): Avoid type-punned deref of X events.
8255 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8257 Fix some uses of `int' instead of EMACS_INT.
8258 * search.c (string_match_1, fast_string_match)
8259 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8260 (scan_buffer, find_next_newline_no_quit)
8261 (find_before_next_newline, search_command, Freplace_match)
8262 (Fmatch_data): Make some `int' variables be EMACS_INT.
8264 * xdisp.c (display_count_lines): 3rd argument and return value now
8265 EMACS_INT. All callers changed.
8266 (pint2hrstr): Last argument is now EMACS_INT.
8268 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8269 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8270 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8271 (decode_coding_utf_16, decode_coding_emacs_mule)
8272 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8273 (decode_coding_ccl, decode_coding_charset)
8274 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8275 (decode_coding_iso_2022, decode_coding_emacs_mule)
8276 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8277 <char_offset, last_offset>: Declare EMACS_INT.
8278 (encode_coding_utf_8, encode_coding_utf_16)
8279 (encode_coding_emacs_mule, encode_invocation_designation)
8280 (encode_designation_at_bol, encode_coding_iso_2022)
8281 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8282 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8284 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8285 (encode_invocation_designation): Last argument P_NCHARS is now
8287 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8288 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8290 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8293 * ccl.c (Fccl_execute_on_string): Declare some variables
8296 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8298 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8300 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8302 * process.c (Fformat_network_address): Doc fix.
8304 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8306 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8308 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8310 * keyboard.c (read_char): Call Lisp function help-form-show,
8311 instead of using internal_with_output_to_temp_buffer.
8312 (Qhelp_form_show): New var.
8313 (syms_of_keyboard): Use DEFSYM macro.
8315 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8317 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8319 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8321 * process.c (Flist_processes): Remove to Lisp.
8322 (list_processes_1): Delete.
8324 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8326 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8328 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8330 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8332 Fix more problems found by GCC 4.6.0's static checks.
8334 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8336 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8338 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8340 * xdisp.c (vmessage): Mark as a printf-like function.
8342 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8344 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8346 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8347 printf-like functions.
8348 (tiff_load): Add casts to remove these marks before passing them
8349 to system-supplied API.
8351 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8353 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8354 This avoids several warnings with gcc -Wstrict-overflow.
8355 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8356 directly, rather than having caller test rule sign. This avoids
8357 some unnecessary tests.
8358 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8359 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8360 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8362 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8363 (xfont_open): Avoid unnecessary tests.
8365 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8367 * composite.h, composite.c (composition_gstring_put_cache):
8368 Use EMACS_INT, not int, for length.
8370 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8371 breaking out part of COMPOSITION_DECODE_RULE.
8372 (COMPOSITION_DECODE_RULE): Use it.
8373 * composite.c (get_composition_id): Remove unused local vars,
8374 by using the new macro.
8376 * textprop.c (set_text_properties_1): Change while to do-while,
8377 since the condition is always true at first.
8379 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8380 (interval_deletion_adjustment): Return unsigned value.
8383 * process.c (list_processes_1, create_pty, read_process_output):
8384 (exec_sentinel): Remove vars that were set but not used.
8385 (create_pty): Remove unnecessary "volatile"s.
8386 (Fnetwork_interface_info): Avoid possibility of int overflow.
8387 (read_process_output): Do adaptive read buffering even if carryover.
8388 (read_process_output): Simplify nbytes computation if buffered.
8390 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8392 * syntax.c (scan_words): Remove var that was set but not used.
8393 (update_syntax_table): Use unsigned instead of int.
8395 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8396 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8397 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8399 * print.c (print_error_message): Avoid int overflow.
8401 * font.c (font_list_entities): Redo for clarity,
8402 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8404 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8405 (font_score): Avoid potential overflow in diff calculation.
8407 * fns.c (substring_both): Remove var that is set but not used.
8408 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8410 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8412 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8413 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8414 can always succeed if overflow has undefined behavior.
8416 * search.c (boyer_moore, wordify): Remove vars set but not used.
8417 (wordify): Omit three unnecessary tests.
8419 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8420 All callers changed. This avoids the need for an unused var.
8422 * casefiddle.c (casify_region): Remove var that is set but not used.
8424 * dired.c (file_name_completion): Remove var that is set but not used.
8426 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8428 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8429 (Finsert_file_contents): Remove unnecessary code checking fd.
8431 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8432 Check for integer overflow on size calculations.
8434 * buffer.c (Fprevious_overlay_change): Remove var that is set
8437 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8438 Remove vars that are set but not used.
8439 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8440 (timer_check_2): Mark vars as initialized.
8442 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8444 * image.c (lookup_image): Remove var that is set but not used.
8445 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8447 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8448 that are set but not used.
8450 * xfns.c (make_invisible_cursor): Don't return garbage
8451 if XCreateBitmapFromData fails (Bug#8410).
8453 * xselect.c (x_get_local_selection, x_handle_property_notify):
8454 Remove vars that are set but not used.
8456 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8457 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8459 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8460 Remove var that is set but not used.
8461 (scroll_bar_windows_size): Now size_t, not int.
8462 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8465 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8466 (map_tty_color) [!defined MSDOS]: Likewise.
8468 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8470 * coding.c: Remove vars that are set but not used.
8471 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8472 All callers changed.
8473 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8474 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8475 (decode_coding_charset): Remove vars that are set but not used.
8477 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8478 that is set but not used.
8480 * print.c (print_object): Remove var that is set but not used.
8482 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8483 The gnulib version avoids calling malloc in the usual case,
8484 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8485 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8486 * filelock.c (current_lock_owner): Likewise.
8487 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8488 * sysdep.c: Include allocator.h, careadlinkat.h.
8489 (emacs_no_realloc_allocator): New static constant.
8490 (emacs_readlink): New function.
8491 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8492 ../lib/careadlinkat.h.
8494 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8496 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8497 first non-nil return value).
8499 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8501 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8502 if not defined (Bug#8403).
8504 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8506 * xdisp.c (display_count_lines): Remove parameter `start',
8507 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8508 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8509 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8510 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8511 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8512 and thereabouts. All callers changed.
8513 (get_per_char_metric): Remove parameter `f', unused since
8514 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8516 2011-04-02 Jim Meyering <meyering@redhat.com>
8518 do not dereference NULL upon failed strdup
8519 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8520 (ns_get_family): Likewise.
8522 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8524 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8526 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8528 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8531 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8533 Add lexical binding.
8535 * window.c (Ftemp_output_buffer_show): New fun.
8536 (Fsave_window_excursion):
8537 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8539 * lread.c (lisp_file_lexically_bound_p): New function.
8540 (Fload): Bind Qlexical_binding.
8541 (readevalloop): Remove `evalfun' arg.
8542 Bind Qinternal_interpreter_environment.
8543 (Feval_buffer): Bind Qlexical_binding.
8544 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8546 (syms_of_lread): Declare `lexical-binding'.
8548 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8550 * keyboard.c (eval_dyn): New fun.
8551 (menu_item_eval_property): Use it.
8553 * image.c (parse_image_spec): Use Ffunctionp.
8555 * fns.c (concat, mapcar1): Accept byte-code-functions.
8557 * eval.c (Fsetq): Handle lexical vars.
8558 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8559 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8560 (FletX, Flet): Obey lexical binding.
8561 (Fcommandp): Handle closures.
8562 (Feval): New `lexical' arg.
8563 (eval_sub): New function extracted from Feval. Use it almost
8564 everywhere where Feval was used. Look up vars in lexical env.
8566 (Ffunctionp): Move from subr.el.
8567 (Ffuncall): Handle closures.
8568 (apply_lambda): Remove `eval_flags'.
8569 (funcall_lambda): Handle closures and new byte-code-functions.
8570 (Fspecial_variable_p): New function.
8571 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8572 but without exporting it to Lisp.
8574 * doc.c (Fdocumentation, store_function_docstring):
8575 * data.c (Finteractive_form): Handle closures.
8577 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8580 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8582 (exec_byte_code): New function extracted from Fbyte_code to handle new
8583 calling convention for byte-code-functions. Add new byte-codes.
8585 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8587 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8589 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8591 * xdisp.c (redisplay_internal): Fix prototype.
8593 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8595 * xdisp.c (SCROLL_LIMIT): New macro.
8596 (try_scrolling): Use it when setting scroll_limit.
8597 Limit scrolling to 100 screen lines.
8598 (redisplay_window): Even when falling back on "recentering",
8599 position point in the window according to scroll-conservatively,
8600 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8602 (try_scrolling): When point is above the window, allow searching
8603 as far as scroll_max, or one screenful, to compute vertical
8604 distance from PT to the scroll margin position. This prevents
8605 try_scrolling from unnecessarily failing when
8606 scroll-conservatively is set to a value slightly larger than the
8607 window height. Clean up the case of PT below the margin at bottom
8608 of window: scroll_max can no longer be INT_MAX. When aggressive
8609 scrolling is in use, don't let point enter the opposite scroll
8610 margin as result of the scroll.
8611 (syms_of_xdisp) <scroll-conservatively>: Document the
8612 threshold of 100 lines for never-recentering scrolling.
8614 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8616 * dispextern.h (move_it_by_lines):
8617 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8618 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8619 (message_log_check_duplicate): Remove parameters `prev_bol' and
8620 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8621 (redisplay_internal): Remove parameter `preserve_echo_area',
8622 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8624 * indent.c (Fvertical_motion):
8625 * window.c (window_scroll_pixel_based, Frecenter):
8626 Don't pass `need_y_p' to `move_it_by_lines'.
8628 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8630 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8631 steal a few bits to be more compact.
8632 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8633 Remove unneeded casts.
8635 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8637 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8639 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8640 binding" message (bug#7967).
8642 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8644 Fix more problems found by GCC 4.6.0's static checks.
8646 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8647 Remove unused local var.
8649 * editfns.c (Fmessage_box): Remove unused local var.
8651 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8652 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8653 Omit unused local vars.
8654 * window.c (shrink_windows): Omit unused local var.
8655 * menu.c (digest_single_submenu): Omit unused local var.
8656 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8657 Omit unused local var.
8659 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8660 Don't assume string length fits in int.
8661 (keyremap_step, read_key_sequence): Use size_t for sizes.
8662 (read_key_sequence): Don't check last_real_key_start redundantly.
8664 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8665 instead of alloca (Bug#8344).
8667 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8668 (Fbacktrace_frame): Don't assume nframes fits in int.
8670 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8672 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8675 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8677 * cm.c (calccost): Turn while-do into do-while, for clarity.
8679 * keyboard.c (syms_of_keyboard): Use the same style as later
8680 in this function when indexing through an array. This also
8681 works around GCC bug 48267.
8683 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8685 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8687 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8688 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8690 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8691 This avoids undefined behavior on integer overflow, and is a bit
8692 more convenient anyway since it is compared to a size_t variable.
8694 Variadic C functions now count arguments with size_t, not int.
8695 This avoids an unnecessary limitation on 64-bit machines, which
8696 caused (substring ...) to crash on large vectors (Bug#8344).
8697 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8698 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8699 All variadic functions and their callers changed accordingly.
8700 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8701 * data.c (arith_driver, float_arith_driver): Likewise.
8702 * editfns.c (general_insert_function): Likewise.
8703 * eval.c (struct backtrace.nargs, interactive_p)
8704 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8705 (funcall_lambda, mark_backtrace): Likewise.
8706 * fns.c (concat): Likewise.
8707 * frame.c (x_set_frame_parameters): Likewise.
8708 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8709 0 if not found, not -1. All callers changed.
8711 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8712 (stack_copy_size): Now size_t, not int.
8713 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8715 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8717 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8718 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8719 All callers changed.
8721 * lisp.h (multibyte_char_to_unibyte):
8722 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8723 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8724 * character.h (CHAR_TO_BYTE8):
8725 * cmds.c (internal_self_insert):
8726 * editfns.c (general_insert_function):
8727 * keymap.c (push_key_description):
8728 * search.c (Freplace_match):
8729 * xdisp.c (message_dolog, set_message_1): All callers changed.
8731 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8733 * keyboard.c (safe_run_hook_funcall): New function.
8734 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8735 don't set the hook to nil, but remove the offending function instead.
8736 (Qcommand_hook_internal): Remove, unused.
8737 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8738 Vcommand_hook_internal.
8740 * eval.c (enum run_hooks_condition): Remove.
8741 (funcall_nil, funcall_not): New functions.
8742 (run_hook_with_args): Call each function through a `funcall' argument.
8743 Remove `cond' argument, now redundant.
8744 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8745 (Frun_hook_with_args_until_failure): Adjust accordingly.
8746 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8748 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8750 * dispextern.h (string_buffer_position): Remove declaration.
8752 * print.c (strout): Remove parameter `multibyte', unused since
8753 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8755 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8756 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8757 All callers changed.
8759 * w32.c (_wsa_errlist): Use braces for struct initializers.
8761 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8762 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8763 All callers changed.
8764 (string_buffer_position): Likewise. Also, make static (it's never
8765 used outside xdisp.c).
8766 (cursor_row_p): Remove parameter `w', unused since
8767 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8768 (decode_mode_spec): Remove parameter `precision', introduced during
8769 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8770 All callers changed.
8772 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8774 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8776 2011-03-27 Anders Lindgren <andlind@gmail.com>
8778 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8779 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8780 (ns_update_auto_hide_menu_bar): New functions.
8781 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8782 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8783 ns_constrain_all_frames.
8784 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8785 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8787 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8789 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8791 2011-03-27 Glenn Morris <rgm@gnu.org>
8793 * syssignal.h: Replace RETSIGTYPE with void.
8794 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8795 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8796 Replace SIGTYPE with void everywhere.
8797 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8798 * s/template.h (SIGTYPE): Remove commented out definition.
8800 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8802 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8803 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8805 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8807 * w32.c (read_unc_volume): Use parameter `henum', instead of
8808 global variable `wget_enum_handle'.
8810 * keymap.c (describe_vector): Remove parameters `indices' and
8811 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8812 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8814 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8816 * keyboard.c (timer_check): Remove parameter `do_it_now',
8817 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8818 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8819 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8821 * keyboard.c (read_char):
8822 * w32menu.c (w32_menu_display_help):
8823 * xmenu.c (show_help_event, menu_help_callback):
8824 Adjust calls to `show_help_echo'.
8826 * gtkutil.c (xg_maybe_add_timer):
8827 * keyboard.c (readable_events):
8828 * process.c (wait_reading_process_output):
8829 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8831 * insdel.c (adjust_markers_gap_motion):
8832 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8833 (gap_left, gap_right): Don't call it.
8835 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8837 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8838 incurred during fontification.
8840 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8842 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8843 (DEFVAR_PER_BUFFER): Don't pass it.
8845 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8846 (scrolling_window): Don't pass it.
8848 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8850 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8852 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8854 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8855 of variables specific to SELinux and computation of `encoded_absname'.
8857 * image.c (XPutPixel): Remove unused variable `height'.
8859 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8861 * unexw32.c (get_section_info): Remove unused variable `section'.
8863 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8864 (system_process_attributes): Remove unused variable `sess'.
8865 (sys_read): Remove unused variable `err'.
8867 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8868 (w32_wnd_proc): Remove unused variable `isdead'.
8869 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8870 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8871 (x_create_tip_frame): Remove unused variable `tem'.
8873 * w32inevt.c (w32_console_read_socket):
8874 Remove unused variable `no_events'.
8876 * w32term.c (x_draw_composite_glyph_string_foreground):
8877 Remove unused variable `width'.
8879 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8881 * w32term.c (x_set_glyph_string_clipping):
8882 Don't pass uninitialized region to CombineRgn.
8884 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8886 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8887 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8888 (Fx_close_connection): Remove unused variable `i'.
8890 * w32font.c (w32font_draw): Return number of glyphs.
8891 (w32font_open_internal): Remove unused variable `i'.
8892 (w32font_driver): Add missing initializer.
8894 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8895 (fill_in_menu): Remove unused variable `items_added'.
8897 * w32term.c (last_mouse_press_frame): Remove static global variable.
8898 (w32_clip_to_row): Remove unused variable `f'.
8899 (x_delete_terminal): Remove unused variable `i'.
8901 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8902 (NOTHING): Remove unused static global variable.
8903 (uniscribe_check_otf): Remove unused variable `table'.
8904 (uniscribe_font_driver): Add missing initializers.
8906 2011-03-23 Julien Danjou <julien@danjou.info>
8908 * term.c (Fsuspend_tty, Fresume_tty):
8909 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8910 * window.c (temp_output_buffer_show):
8911 * insdel.c (signal_before_change):
8912 * frame.c (Fhandle_switch_frame):
8913 * fileio.c (Fdo_auto_save):
8914 * emacs.c (Fkill_emacs):
8915 * editfns.c (save_excursion_restore):
8916 * cmds.c (internal_self_insert):
8917 * callint.c (Fcall_interactively):
8918 * buffer.c (Fkill_all_local_variables):
8919 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8921 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8922 unconditionally since it does the check itself.
8924 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8926 Fix more problems found by GCC 4.5.2's static checks.
8928 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8929 the first time through the loop, since we know p0 < p1 then.
8930 This also avoids a gcc -Wstrict-overflow warning.
8932 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8933 leading to a memory leak, possible in functions like
8934 load_charset_map_from_file that can allocate an unbounded number
8935 of objects (Bug#8318).
8937 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8938 that could (at least in theory) be that large.
8940 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8941 This is less likely to overflow, and avoids undefined behavior if
8942 overflow does occur. All callers changed. Use strtoul to scan
8943 for the unsigned long integer.
8944 (pint2hrstr): Simplify and tune code slightly.
8945 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8947 * scroll.c (do_scrolling): Work around GCC bug 48228.
8948 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8950 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8951 This also avoids a warning with gcc -Wstrict-overflow.
8952 (validate_x_resource_name): Simplify count usage.
8953 This also avoids a warning with gcc -Wstrict-overflow.
8955 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8958 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8960 * process.c (Fmake_network_process): Use socklen_t, not int,
8961 where POSIX says socklen_t is required in portable programs.
8962 This fixes a porting bug on hosts like 64-bit HP-UX, where
8963 socklen_t is wider than int (Bug#8277).
8964 (Fmake_network_process, server_accept_connection):
8965 (wait_reading_process_output, read_process_output):
8968 * process.c: Rename or move locals to avoid shadowing.
8969 (list_processes_1, Fmake_network_process):
8970 (read_process_output_error_handler, exec_sentinel_error_handler):
8971 Rename or move locals.
8972 (Fmake_network_process): Define label "retry_connect" only if needed.
8973 (Fnetwork_interface_info): Fix pointer signedness.
8974 (process_send_signal): Add cast to avoid pointer signedness problem.
8975 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8976 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8978 Make tparam.h and terminfo.c consistent.
8979 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8980 Include tparam.h instead, since it declares them.
8981 * cm.h (PC): Remove extern decl; tparam.h now does this.
8982 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8983 * terminfo.c: Include tparam.h, to check interfaces.
8984 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8985 (tparam): Adjust signature to match interface in tparam.h;
8986 this removes some undefined behavior. Check that outstring and len
8987 are zero, which they always are with Emacs.
8988 * tparam.h (PC, BC, UP): New extern decls.
8990 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8991 (xftfont_open): Rename locals to avoid shadowing.
8993 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8994 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8995 (OTF_TAG_SYM): Omit macro if not needed.
8996 (ftfont_list): Remove unused local.
8997 (get_adstyle_property, ftfont_pattern_entity):
8998 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8999 Rename locals to avoid shadowing.
9001 * xfont.c (xfont_list_family): Mark var as initialized.
9003 * xml.c (make_dom): Now static.
9005 * composite.c (composition_compute_stop_pos): Rename local to
9007 (composition_reseat_it): Remove unused locals.
9008 (find_automatic_composition, composition_adjust_point): Likewise.
9009 (composition_update_it): Mark var as initialized.
9010 (find_automatic_composition): Mark vars as initialized,
9011 with a FIXME (Bug#8290).
9013 character.h: Rename locals to avoid shadowing.
9014 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9015 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9016 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9017 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9020 * textprop.c (property_change_between_p): Remove; unused.
9022 * intervals.c (interval_start_pos): Now static.
9024 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9026 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9027 Rename locals to avoid shadowing.
9029 * sound.c (wav_play, au_play, Fplay_sound_internal):
9030 Fix pointer signedness.
9031 (alsa_choose_format): Remove unused local var.
9032 (wav_play): Initialize a variable to 0, to prevent undefined
9033 behavior (Bug#8278).
9035 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9037 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9039 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9040 clobbering (Bug#8298).
9041 * sysdep.c (sys_subshell): Likewise.
9042 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9044 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9045 This should get cleaned up, so that child_setup has the
9046 same signature on all platforms.
9048 * callproc.c (call_process_cleanup): Now static.
9049 (relocate_fd): Rename locals to avoid shadowing.
9051 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9053 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9054 not to be necessary, and produces flickering.
9056 2011-03-20 Glenn Morris <rgm@gnu.org>
9058 * config.in: Remove file.
9060 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9062 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9063 are now in src/globals.h.
9064 (syms_of_minibuf): Remove spurious & from previous change.
9066 2011-03-20 Leo Liu <sdl.web@gmail.com>
9068 * minibuf.c (completing-read-function): New variable.
9069 (completing-read-default): Rename from completing-read.
9070 (completing-read): Call completing-read-function.
9072 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9074 * xfaces.c (Fx_load_color_file):
9075 Read color file from absolute filename (bug#8250).
9077 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9079 * makefile.w32-in: Update dependencies.
9081 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9083 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9085 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9087 Fix more problems found by GCC 4.5.2's static checks.
9089 * process.c (make_serial_process_unwind, send_process_trap):
9090 (sigchld_handler): Now static.
9092 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9093 That way, the code declares only the vars that it needs.
9094 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9095 * s/cygwin.h (PTY_ITERATION): Likewise.
9096 * s/darwin.h (PTY_ITERATION): Likewise.
9097 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9099 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9100 * process.c (allocate_pty): Don't declare stb unless it's needed.
9102 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9103 (CONSTANTLIM): Remove; unused.
9104 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9105 Define only if needed.
9107 * unexelf.c (unexec): Name an expression,
9108 to avoid gcc -Wbad-function-cast warning.
9109 Use a different way to cause a compilation error if anyone uses
9110 n rather than nn, a way that does not involve shadowing.
9111 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9113 * deps.mk (unexalpha.o): Remove; unused.
9115 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9116 * unexec.h: New file.
9117 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9118 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9120 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9121 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9122 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9123 Change as necessary to match prototype in unexec.h.
9125 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9127 (back_comment, skip_chars): Mark vars as initialized.
9129 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9130 Rename locals to avoid shadowing.
9132 * lread.c (read1): Rewrite so as not to use empty "else".
9133 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9135 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9137 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9138 warning when compiling print.c.
9140 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9141 instead of using an uninitialized var.
9142 (font_sort_entities): Mark var as initialized.
9144 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9146 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9147 pointers to constants.
9148 (font_parse_fcname): Remove unused vars.
9149 (font_delete_unmatched): Now static.
9150 (font_get_spec): Remove; unused.
9151 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9152 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9153 Rename or move locals to avoid shadowing.
9155 * fns.c (require_nesting_list, require_unwind): Now static.
9156 (Ffillarray): Rename locals to avoid shadowing.
9158 * floatfns.c (domain_error2): Define only if needed.
9159 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9161 * alloc.c (mark_backtrace): Move decl from here ...
9162 * lisp.h: ... to here, so that it can be checked.
9164 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9165 (Fdefvar): Rewrite so as not to use empty "else".
9166 (lisp_indirect_variable): Name an expression,
9167 to avoid gcc -Wbad-function-cast warning.
9168 (Fdefvar): Rename locals to avoid shadowing.
9170 * callint.c (quotify_arg, quotify_args): Now static.
9171 (Fcall_interactively): Rename locals to avoid shadowing.
9172 Use const pointer when appropriate.
9174 * lisp.h (get_system_name, get_operating_system_release):
9175 Move decls here, to check interfaces.
9176 * process.c (get_operating_system_release): Move decl to lisp.h.
9177 * xrdb.c (get_system_name): Likewise.
9178 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9179 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9180 some of which prompt warnings from gcc -Wbad-function-cast.
9181 (Fformat_time_string, Fencode_time, Finsert_char):
9182 (Ftranslate_region_internal, Fformat):
9183 Rename or remove local vars to avoid shadowing.
9184 (Ftranslate_region_internal): Mark var as initialized.
9186 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9189 * lisp.h (eassert): Check that the argument compiles, even if
9190 ENABLE_CHECKING is not defined.
9192 * data.c (Findirect_variable): Name an expression, to avoid
9193 gcc -Wbad-function-cast warning.
9194 (default_value, arithcompare, arith_driver, arith_error): Now static.
9195 (store_symval_forwarding): Rename local to avoid shadowing.
9196 (Fmake_variable_buffer_local, Fmake_local_variable):
9197 Mark variables as initialized.
9198 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9200 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9201 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9202 Rename locals to avoid shadowing.
9203 (mark_stack): Move local variables into the #ifdef region where
9205 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9206 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9208 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9209 (GC_STRING_CHARS): Remove; not used.
9210 (Fmemory_limit): Cast sbrk's returned value to char *.
9212 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9213 avoids undefined behavior in theory.
9215 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9217 Use functions, not macros, for up- and down-casing (Bug#8254).
9218 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9219 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9220 to use the following functions instead of these macros.
9221 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9222 EMACS_INT, since callers assume the returned value fits in int.
9223 (upcase1): Likewise, for UPCASE_TABLE.
9224 (uppercasep, lowercasep, upcase): New static inline functions.
9225 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9226 the race-condition problem in the old DOWNCASE.
9228 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9229 Rename locals to avoid shadowing.
9230 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9231 (regex_compile, re_search_2, re_match_2_internal):
9232 Remove unused local vars.
9233 (FREE_VAR): Rewrite so as not to use empty "else",
9234 which gcc can warn about.
9235 (regex_compile, re_match_2_internal): Mark locals as initialized.
9236 (RETALLOC_IF): Define only if needed.
9237 (WORDCHAR_P): Likewise. This one is never needed, but is used
9238 only in a comment talking about a compiler bug, so put inside
9239 the #if 0 of that comment.
9240 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9241 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9244 * search.c (boyer_moore): Rename locals to avoid shadowing.
9245 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9246 (PREV_CHAR_BOUNDARY): Likewise.
9248 * search.c (simple_search): Remove unused var.
9250 * dired.c (compile_pattern): Move decl from here ...
9251 * lisp.h: ... to here, so that it can be checked.
9252 (struct re_registers): New forward decl.
9254 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9256 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9258 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9259 Rename locals to avoid shadowing.
9260 (Fvertical_motion): Mark locals as initialized.
9262 * casefiddle.c (casify_object, casify_region): Now static.
9263 (casify_region): Mark local as initialized.
9265 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9267 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9268 New macros, so that the caller can use some names other than
9269 gcpro1, gcpro2, etc.
9270 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9272 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9273 argument, for consistency with GCPRO2_VAR, etc: it is now the
9274 prefix of the variable, not the variable itself. All uses
9276 * dired.c (directory_files_internal, file_name_completion):
9277 Rename locals to avoid shadowing.
9279 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9280 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9281 dired.c's scmp function, had undefined behavior.
9282 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9283 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9284 * buffer.h: ... to here, because these macros use current_buffer,
9285 and the new implementation with inline functions needs to have
9286 current_buffer in scope now, rather than later when the macros
9288 (downcase, upcase1): New static inline functions.
9289 (DOWNCASE, UPCASE1): Reimplement using these functions.
9290 This avoids undefined behavior in expressions like
9291 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9292 from race conditions in accessing the global variables
9293 case_temp1 and case_temp2.
9294 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9295 * lisp.h (case_temp1, case_temp2): Remove their decls.
9296 * character.h (ASCII_CHAR_P): Move from here ...
9297 * lisp.h: ... to here, so that the inline functions mentioned
9300 * dired.c (directory_files_internal_unwind): Now static.
9302 * fileio.c (file_name_as_directory, directory_file_name):
9303 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9305 (file_name_as_directory): Use const pointers when appropriate.
9306 (Fexpand_file_name): Likewise. In particular, newdir might
9307 point at constant storage, so make it a const pointer.
9308 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9309 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9311 (Fset_file_times, Finsert_file_contents, auto_save_error):
9312 Rename locals to avoid shadowing.
9314 * minibuf.c (choose_minibuf_frame_1): Now static.
9315 (Ftry_completion, Fall_completions): Rename or remove locals
9318 * marker.c (bytepos_to_charpos): Remove; unused.
9320 * lisp.h (verify_bytepos, count_markers): New decls,
9321 so that gcc does not warn that these functions aren't declared.
9323 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9324 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9325 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9326 (copy_text): Remove unused local var.
9328 * filelock.c (within_one_second): Now static.
9329 (lock_file_1): Rename local to avoid shadowing.
9331 * buffer.c (fix_overlays_before): Mark locals as initialized.
9332 (fix_start_end_in_overlays): Likewise. This function should be
9333 simplified by using pointers-to-pointers, but that's a different
9335 (switch_to_buffer_1): Now static.
9336 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9337 (report_overlay_modification): Rename locals to avoid shadowing.
9339 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9340 Fix pointer signedness issue.
9341 (sys_subshell): Mark local as volatile if checking for lint,
9342 to suppress a gcc -Wclobbered warning that does not seem to be right.
9343 (MAXPATHLEN): Define only if needed.
9345 * process.c (serial_open, serial_configure): Move decls from here ...
9346 * systty.h: ... to here, so that they can be checked.
9348 * fns.c (get_random, seed_random): Move extern decls from here ...
9349 * lisp.h: ... to here, so that they can be checked.
9351 * sysdep.c (reset_io): Now static.
9352 (wait_for_termination_signal): Remove; unused.
9354 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9355 (copy_keymap_item, append_key, push_text_char_description):
9357 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9358 (DENSE_TABLE_SIZE): Remove; unused.
9359 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9360 (describe_map_tree):
9361 Rename locals to avoid shadowing.
9363 * keyboard.c: Declare functions static if they are not used elsewhere.
9364 (echo_char, echo_dash, cmd_error, top_level_2):
9365 (poll_for_input, handle_async_input): Now static.
9366 (read_char, kbd_buffer_get_event, make_lispy_position):
9367 (make_lispy_event, make_lispy_movement, apply_modifiers):
9368 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9369 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9370 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9371 (read_key_sequence, read_char): Mark locals as initialized.
9372 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9374 * keyboard.h (make_ctrl_char): New decl.
9375 (mark_kboards): Move decl here ...
9376 * alloc.c (mark_kboards): ... from here.
9378 * lisp.h (force_auto_save_soon): New decl.
9380 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9381 (DEFINE_DUMMY_FUNCTION): New macro.
9382 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9384 (main): Add casts to avoid warnings
9385 if GCC considers string literals to be constants.
9387 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9389 * dbusbind.c: Pointer signedness fixes.
9390 (xd_signature, xd_append_arg, xd_initialize):
9391 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9392 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9393 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9394 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9396 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9397 if GCC considers string literals to be constants.
9398 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9400 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9402 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9403 (print_preprocess, print_object): New macro to fix last change.
9405 * print.c (print_preprocess): Don't forget font objects.
9407 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9409 * emacs.c (USAGE3): Doc fixes.
9411 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9413 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9416 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9418 * lisp.h (VWindow_system, Qfile_name_history):
9419 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9420 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9421 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9423 * w32select.c: Don't #include "keyboard.h".
9424 (run_protected): Add extern declaration for waiting_for_input.
9426 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9427 * w32console.c (detect_input_pending, read_input_pending)
9428 (encode_terminal_code):
9429 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9430 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9431 (w32_system_caret_y, Qfile_name_history):
9432 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9433 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9434 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9435 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9436 * w32proc.c (Qlocal, report_file_error):
9437 * w32term.c (Vwindow_system, updating_frame):
9438 * w32uniscribe.c (initialized, uniscribe_font_driver):
9439 Remove unneeded extern declarations.
9441 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9443 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9445 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9447 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9448 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9449 These macros can no longer be used for assignment.
9451 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9452 Assign struct members directly, instead of using BUF_BEGV etc.
9453 (record_buffer_markers, fetch_buffer_markers): New functions for
9454 recording and fetching special buffer markers.
9455 (set_buffer_internal_1, set_buffer_temp): Use them.
9457 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9459 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9461 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9462 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9464 * xdisp.c (hscroll_window_tree):
9465 (reconsider_clip_changes): Use PT instead of BUF_PT.
9467 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9469 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9470 $(EMACS_ROOT)/lib/intprops.h.
9472 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9474 Fix more problems found by GCC 4.5.2's static checks.
9476 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9477 to unsigned char * to avoid compiler diagnostic.
9478 (xg_free_frame_widgets): Make it clear that a local variable is
9479 needed only if USE_GTK_TOOLTIP.
9480 (gdk_window_get_screen): Make it clear that this macro is needed
9481 only if USE_GTK_TOOLTIP.
9482 (int_gtk_range_get_value): New function, which avoids a diagnostic
9483 from gcc -Wbad-function-cast.
9484 (xg_set_toolkit_scroll_bar_thumb): Use it.
9485 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9486 diagnostic from gcc -Wbad-function-cast.
9487 (get_utf8_string, xg_get_file_with_chooser):
9488 Rename locals to avoid shadowing.
9489 (create_dialog): Move locals to avoid shadowing.
9491 * xgselect.c (xg_select): Remove unused var.
9493 * image.c (four_corners_best): Mark locals as initialized.
9494 (gif_load): Initialize transparent_p to zero (Bug#8238).
9495 Mark another local as initialized.
9496 (my_png_error, my_error_exit): Mark with NO_RETURN.
9498 * image.c (clear_image_cache): Now static.
9499 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9500 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9501 (x_edge_detection): Remove unnecessary cast that
9502 gcc -Wbad-function-cast diagnoses.
9503 (gif_load): Fix pointer signedness.
9504 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9505 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9507 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9509 Improve quality of tests for time stamp overflow.
9510 For example, without this patch (encode-time 0 0 0 1 1
9511 1152921504606846976) returns the obviously-bogus value (-948597
9512 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9513 reports time overflow. See
9514 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9515 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9516 * editfns.c: Include limits.h and intprops.h.
9517 (TIME_T_MIN, TIME_T_MAX): New macros.
9518 (time_overflow): Move earlier, to before first use.
9519 (hi_time, lo_time): New functions, for an accurate test for
9521 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9522 (Fget_internal_run_time): Don't assume time_t fits in int.
9523 (make_time): Use list2 instead of Fcons twice.
9524 (Fdecode_time): More accurate test for out-of-range times.
9525 (check_tm_member): New function.
9526 (Fencode_time): Use it, to test for out-of-range times.
9527 (lisp_time_argument): Don't rely on undefined left-shift and
9528 right-shift behavior when checking for time stamp overflow.
9530 * editfns.c (time_overflow): New function, refactoring common code.
9531 (Fformat_time_string, Fdecode_time, Fencode_time):
9532 (Fcurrent_time_string): Use it.
9534 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9535 * dired.c (make_time): Move to ...
9536 * editfns.c (make_time): ... here.
9537 * systime.h: Note the move.
9539 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9541 * fringe.c (update_window_fringes): Remove unused variables.
9543 * unexmacosx.c (copy_data_segment): Also copy __got section.
9546 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9548 * termcap.c [MSDOS]: Include "msdos.h".
9549 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9550 Constify `char *' arguments and their references according to
9551 prototypes in tparam.h.
9553 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9555 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9556 Adapt all references accordingly.
9558 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9560 2011-03-11 Tom Tromey <tromey@redhat.com>
9562 * buffer.c (syms_of_buffer): Remove obsolete comment.
9564 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9566 * termhooks.h (encode_terminal_code): Declare prototype.
9568 * msdos.c (encode_terminal_code): Don't declare prototype.
9570 * term.c (encode_terminal_code): Now external again, used by
9571 w32console.c and msdos.c.
9573 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9574 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9576 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9578 Fix some minor problems found by GCC 4.5.2's static checks.
9580 * fringe.c (update_window_fringes): Mark locals as initialized
9582 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9584 * alloc.c (mark_fringe_data): Move decl from here ...
9585 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9586 to check its interface.
9587 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9589 * fontset.c (free_realized_fontset): Now static.
9590 (Fset_fontset_font): Rename local to avoid shadowing.
9591 (fontset_font): Mark local as initialized.
9592 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9594 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9596 * xselect.c (x_disown_buffer_selections): Remove; not used.
9597 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9598 (x_own_selection, Fx_disown_selection_internal): Rename locals
9600 (x_handle_dnd_message): Remove local to avoid shadowing.
9602 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9603 so that the caller can use some name other than gcpro1.
9604 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9605 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9606 (Fx_backspace_delete_keys_p):
9607 Use them to avoid shadowing, and rename vars to avoid shadowing.
9608 (x_decode_color, x_set_name, x_window): Now static.
9609 (Fx_create_frame): Add braces to silence GCC warning.
9610 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9611 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9612 Remove unused locals.
9613 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9614 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9615 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9618 * xterm.h (x_mouse_leave): New decl.
9620 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9621 Remove unused functions.
9622 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9623 (x_calc_absolute_position): Now static.
9624 (XTread_socket): Don't define label "out" unless it's used.
9625 Don't declare local "event" unless it's used.
9626 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9627 unless they are used.
9628 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9629 (x_fatal_error_signal): Remove; not used.
9630 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9631 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9632 (x_error_catcher, x_connection_closed, x_error_handler):
9633 (x_error_quitter, xembed_send_message, x_iconify_frame):
9634 (my_log_handler): Rename locals to avoid shadowing.
9635 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9636 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9638 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9639 Rename or move locals to avoid shadowing.
9640 (tty_defined_color, merge_face_heights): Now static.
9641 (free_realized_faces_for_fontset): Remove; not used.
9642 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9643 does not deduce is never used uninitialized.
9644 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9645 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9647 * terminal.c (store_terminal_param): Now static.
9649 * xmenu.c (menu_highlight_callback): Now static.
9650 (set_frame_menubar): Remove unused local.
9651 (xmenu_show): Rename parameter to avoid shadowing.
9652 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9653 since they might point to immutable storage.
9654 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9655 since it's unused otherwise.
9657 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9658 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9659 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9660 avoids a gcc -Wuninitialized diagnostic.
9661 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9662 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9663 does not deduce are never used uninitialized.
9665 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9667 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9668 * window.c (window_loop, size_window):
9669 (run_window_configuration_change_hook, enlarge_window): Likewise.
9671 * window.c (display_buffer): Now static.
9672 (size_window): Mark variables that gcc -Wuninitialized
9673 does not deduce are never used uninitialized.
9674 * window.h (check_all_windows): New decl, to forestall
9675 gcc -Wmissing-prototypes diagnostic.
9676 * dispextern.h (bidi_dump_cached_states): Likewise.
9678 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9680 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9682 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9683 and to avoid gcc -Wuninitialized warning.
9684 (load_charset_map): Mark variables that gcc -Wuninitialized
9685 does not deduce are never used uninitialized.
9686 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9688 * coding.c (coding_set_source, coding_set_destination):
9689 Use "else { /* comment */ }" rather than "else /* comment */;"
9690 for clarity, and to avoid gcc -Wempty-body warning.
9691 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9692 a block, when the outer 'i' will do.
9693 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9694 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9695 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9696 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9697 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9698 Rename locals to avoid shadowing.
9699 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9700 * coding.c (emacs_mule_char, encode_invocation_designation):
9701 Now static, since they're not used elsewhere.
9702 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9703 (decode_coding_object, encode_coding_object, detect_coding_system):
9704 (decode_coding_emacs_mule): Mark variables that gcc
9705 -Wuninitialized does not deduce are never used uninitialized.
9706 (detect_coding_iso_2022): Initialize a local variable that might
9707 be used uninitialized. Leave a FIXME because it's not clear that
9708 this initialization is needed. (Bug#8211)
9709 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9710 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9711 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9712 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9713 Remove unused macros.
9715 * category.c (hash_get_category_set): Remove unused local var.
9716 (copy_category_table): Now static, since it's not used elsewhere.
9717 * character.c (string_count_byte8): Likewise.
9719 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9720 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9722 * chartab.c (copy_sub_char_table): Now static, since it's not used
9724 (sub_char_table_ref_and_range, char_table_ref_and_range):
9725 Rename locals to avoid shadowing.
9726 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9728 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9729 (BIDI_BOB): Remove unused macro.
9731 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9732 deduce are never used uninitialized.
9733 * term.c (encode_terminal_code): Likewise.
9735 * term.c (encode_terminal_code): Now static. Remove unused local.
9737 * tparam.h: New file.
9738 * term.c, tparam.h: Include it.
9739 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9740 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9741 Move these decls to tparam.h, and make them agree with what
9742 is actually in tparam.c. The previous trick of using incompatible
9743 decls in different modules does not conform to the C standard.
9744 All callers of tparam changed to use tparam's actual API.
9745 * tparam.c (tparam1, tparam, tgoto):
9746 Use const pointers where appropriate.
9748 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9749 * cm.h (struct cm): Likewise.
9750 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9751 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9752 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9753 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9754 (turn_on_face, init_tty): Likewise.
9755 * termchar.h (struct tty_display_info): Likewise.
9757 * term.c (term_mouse_position): Rename local to avoid shadowing.
9759 * alloc.c (mark_ttys): Move decl from here ...
9760 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9762 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9764 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9766 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9768 * search.c (compile_pattern_1): Remove argument regp, unused since
9769 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9770 (compile_pattern): Don't pass it.
9772 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9774 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9775 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9777 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9779 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9781 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9782 gdk_window_get_screen, gdk_window_get_geometry,
9783 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9784 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9785 (xg_get_pixbuf_from_pixmap): New function.
9786 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9787 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9788 Call xg_get_pixbuf_from_pixmap instead of
9789 gdk_pixbuf_get_from_drawable.
9790 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9791 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9792 (xg_check_special_colors): Use GtkStyleContext and its functions
9794 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9795 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9796 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9797 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9798 Call gtk_widget_get_preferred_size.
9799 (xg_frame_resized): gdk_window_get_geometry only takes 5
9801 (xg_win_to_widget, xg_event_is_for_menubar):
9802 Call gdk_x11_window_lookup_for_display.
9803 (xg_set_widget_bg): New function.
9804 (delete_cb): New function.
9805 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9806 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9807 (xg_set_background_color): Call xg_set_widget_bg.
9808 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9809 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9810 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9811 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9813 (update_frame_tool_bar): Call gtk_widget_hide.
9814 (xg_initialize): Use GDK_KEY_g.
9816 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9818 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9820 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9821 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9822 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9824 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9826 * w32xfns.c (select_palette): Check success of RealizePalette against
9827 GDI_ERROR, not zero.
9829 See ChangeLog.11 for earlier changes.
9835 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9837 This file is part of GNU Emacs.
9839 GNU Emacs is free software: you can redistribute it and/or modify
9840 it under the terms of the GNU General Public License as published by
9841 the Free Software Foundation, either version 3 of the License, or
9842 (at your option) any later version.
9844 GNU Emacs is distributed in the hope that it will be useful,
9845 but WITHOUT ANY WARRANTY; without even the implied warranty of
9846 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9847 GNU General Public License for more details.
9849 You should have received a copy of the GNU General Public License
9850 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.